[Mail] Tapping top of message scrolls back to copied text instead of top of the message
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2
3         Assign ews117 to EWS High-Sierra Debug queues
4         https://bugs.webkit.org/show_bug.cgi?id=200993
5
6         Reviewed by Jonathan Bedard.
7
8         * BuildSlaveSupport/ews-build/config.json:
9
10 2019-08-21  Daniel Bates  <dabates@apple.com>
11
12         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
13         https://bugs.webkit.org/show_bug.cgi?id=200742
14
15         Reviewed by Simon Fraser.
16
17         The OptionSet synthetic provider must respond to requests for the value of m_storage
18         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
19         of the type summary.
20
21         Synthetic providers substitute alternative debug information (children) for the default
22         information for a variable. The OptionSet type summary is implemented in terms of the
23         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
24         before invoking the type summary handler then evaluating GetChildMemberWithName() on
25         the SBValue passed to the type summary handler will access the substitute information
26         instead of the original debug information. As a result OptionSet's synthetic provider's
27         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
28         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
29         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
30         should return a valid value.
31
32         * lldb/lldb_webkit.py:
33         (FlagEnumerationProvider.__init__):
34         (FlagEnumerationProvider):
35         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
36         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
37         (FlagEnumerationProvider.size): Added.
38         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
39         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
40         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
41         and removed self.size. For the latter we can just expose a getter that returns the size of
42         the list self._elements.
43         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
44         value of m_storage.
45         (WTFOptionSetProvider):
46         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
47         matches the specified index.
48
49 2019-08-21  Alex Christensen  <achristensen@webkit.org>
50
51         Disabling text autosizing should prevent text autosizing
52         https://bugs.webkit.org/show_bug.cgi?id=200955
53         <rdar://problem/48095374>
54
55         Reviewed by Simon Fraser.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
59         (TEST):
60
61 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
62
63         [GTK][WPE] Make debug-test-runner work
64         https://bugs.webkit.org/show_bug.cgi?id=193576
65
66         Reviewed by Michael Catanzaro.
67
68         * Scripts/webkitdirs.pm:
69         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
70         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
71         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
72         (execUnixAppForDebugging): Added.
73         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
74
75 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
76
77         Put keygen element behind a runtime flag and disable it by default
78         https://bugs.webkit.org/show_bug.cgi?id=200850
79
80         Reviewed by Antti Koivisto.
81
82         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
83
84         * DumpRenderTree/TestOptions.cpp:
85         (TestOptions::TestOptions):
86         * DumpRenderTree/TestOptions.h:
87         * DumpRenderTree/mac/DumpRenderTree.mm:
88         (setWebPreferencesForTestOptions):
89         * DumpRenderTree/win/DumpRenderTree.cpp:
90         (setWebPreferencesForTestOptions):
91         * WebKitTestRunner/TestController.cpp:
92         (WTR::TestController::resetPreferencesToConsistentValues):
93         (WTR::updateTestOptionsFromTestHeader):
94         * WebKitTestRunner/TestOptions.h:
95         (WTR::TestOptions::hasSameInitializationOptions const):
96
97 2019-08-21  Chris Dumez  <cdumez@apple.com>
98
99         Add internal setting to disable SecureContext checks
100         https://bugs.webkit.org/show_bug.cgi?id=200980
101         <rdar://problem/54438512>
102
103         Reviewed by Alex Christensen.
104
105         Add API test coverage.
106
107         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
108         (log):
109         (requestPermission):
110
111 2019-08-21  Keith Rollin  <krollin@apple.com>
112
113         Remove support for watchOS < 6.0
114         https://bugs.webkit.org/show_bug.cgi?id=200937
115         <rdar://problem/54524009>
116
117         Reviewed by Darin Adler.
118
119         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
120         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
121         60000. This means that expressions like
122         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
123         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
124
125         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
126         (TestWebKitAPI::TEST):
127
128 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
129
130         [results.webkit.org Webkit.css] Add right sidebar
131         https://bugs.webkit.org/show_bug.cgi?id=200946
132
133         Reviewed by Jonathan Bedard.
134
135         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
136         (@media screen and (min-width: 600px) and (orientation: landscape)):
137         (.main.left):
138         (@media screen and (min-width: 768px) and (orientation: landscape)):
139         (.sidebar.right):
140
141 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
142
143         results.webkit.org: Add ToolTips
144         https://bugs.webkit.org/show_bug.cgi?id=200801
145
146         Rubber-stamped by Aakash Jain.
147
148         When dots or scale labels are hovered over, we should display a tool tip with additional information about
149         The specific element.
150
151         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
152         (.tooltip): Add class for ToolTip text box.
153         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
154         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
155         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
156         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
157         repositories at a given time.
158         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
159         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
160         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
161         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
162         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
163         (_ToolTip):
164         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
165         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
166         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
167         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
168         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
169         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
170         dot and scale elements.
171         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
172         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
173
174 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
175
176         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
177         https://bugs.webkit.org/show_bug.cgi?id=200782
178
179         Reviewed by Saam Barati.
180
181         * Scripts/run-jsc-stress-tests:
182
183 2019-08-20  Darin Adler  <darin@apple.com>
184
185         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
186         https://bugs.webkit.org/show_bug.cgi?id=200921
187
188         Reviewed by Saam Barati.
189
190         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
191         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
192         need to abort after the first failure. Added three new tests to the VariadicAppend
193         test to cover various cases of upconverting from 8-bit to 16-bit strings.
194
195 2019-08-20  Dean Jackson  <dino@apple.com>
196
197         REGRESSION: Open in New Tab is missing from context menu
198         https://bugs.webkit.org/show_bug.cgi?id=200909
199         <rdar://problem/54476169>
200
201         Reviewed by Simon Fraser.
202
203         Add a new test that runs through the legacy context menu
204         flow, and verifies that it will be called if there aren't
205         appropriate delegates for the new API.
206
207         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
208         (contextMenuWebViewDriver):
209         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
210         (TEST):
211         (-[LegacyPreviewViewController previewActionItems]):
212         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
213         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
214         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
215         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
216         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
217
218 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
219
220         [JSC] OSR entry to Wasm OMG
221         https://bugs.webkit.org/show_bug.cgi?id=200362
222
223         Reviewed by Michael Saboff.
224
225         * Scripts/run-jsc-stress-tests:
226
227 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
228
229         [results.webkit.org Timeline] Disable back gesture
230         https://bugs.webkit.org/show_bug.cgi?id=200839
231
232         Reviewed by Jonathan Bedard.
233
234         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
235         * resultsdbpy/resultsdbpy/view/templates/base.html:
236
237 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
238
239         results-webkit.org: Add timeout to Redis locks
240         https://bugs.webkit.org/show_bug.cgi?id=200890
241
242         Reviewed by Aakash Jain.
243
244         * resultsdbpy/resultsdbpy/model/upload_context.py:
245         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
246
247 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
248
249         Remove IDB-specific quota
250         https://bugs.webkit.org/show_bug.cgi?id=196545
251         <rdar://problem/54201783>
252
253         Reviewed by Youenn Fablet.
254
255         * DumpRenderTree/TestRunner.cpp:
256         (TestRunner::staticFunctions):
257         (setIDBPerOriginQuotaCallback): Deleted.
258         * DumpRenderTree/TestRunner.h:
259         * DumpRenderTree/mac/DumpRenderTree.mm:
260         (runTest):
261         * DumpRenderTree/mac/TestRunnerMac.mm:
262         (TestRunner::setIDBPerOriginQuota): Deleted.
263         * DumpRenderTree/win/TestRunnerWin.cpp:
264         (TestRunner::setIDBPerOriginQuota): Deleted.
265         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
266         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
267         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
269         * WebKitTestRunner/TestController.cpp:
270         (WTR::TestController::resetStateToConsistentValues):
271         (WTR::TestController::setIDBPerOriginQuota): Deleted.
272         * WebKitTestRunner/TestController.h:
273         * WebKitTestRunner/TestInvocation.cpp:
274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
275
276 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
277
278         [WTF] Style checker should tell errors when it finds std::make_unique
279         https://bugs.webkit.org/show_bug.cgi?id=200878
280
281         Reviewed by Ross Kirsling.
282
283         * Scripts/webkitpy/style/checkers/cpp.py:
284         (check_wtf_make_unique):
285         (check_style):
286         (CppChecker):
287
288 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
289
290         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
291         https://bugs.webkit.org/show_bug.cgi?id=200620
292
293         Reviewed by Geoffrey Garen.
294
295         * DumpRenderTree/TestRunner.cpp:
296         (addURLToRedirectCallback):
297         (setWillSendRequestClearHeaderCallback):
298         (TestRunner::setAccummulateLogsForChannel):
299         (TestRunner::runUIScript):
300         (TestRunner::setOpenPanelFiles):
301         * DumpRenderTree/mac/DumpRenderTree.mm:
302         (dumpFramesAsText):
303         * DumpRenderTree/mac/EventSendingController.mm:
304         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
305         * DumpRenderTree/win/DRTDataObject.cpp:
306         (DRTDataObject::SetData):
307         * DumpRenderTree/win/FrameLoadDelegate.cpp:
308         (FrameLoadDelegate::FrameLoadDelegate):
309         * DumpRenderTree/win/UIDelegate.cpp:
310         (DRTUndoManager::DRTUndoManager):
311         (UIDelegate::UIDelegate):
312         (UIDelegate::resetUndoManager):
313         * TestWebKitAPI/JavaScriptTest.cpp:
314         (TestWebKitAPI::runJSTest):
315         * TestWebKitAPI/PlatformUtilities.cpp:
316         (TestWebKitAPI::Util::toSTD):
317         * TestWebKitAPI/Tests/WTF/Expected.cpp:
318         (TestWebKitAPI::TEST):
319         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
322         (TestWebKitAPI::TEST):
323         (TestWebKitAPI::testMovingUsingEnsure):
324         (TestWebKitAPI::testMovingUsingAdd):
325         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
326         (TestWebKitAPI::TEST):
327         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WTF/Lock.cpp:
330         (TestWebKitAPI::runLockTest):
331         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
332         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WTF/Variant.cpp:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
341         (TestWebKitAPI::CARingBufferTest::SetUp):
342         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
343         (TestWebKitAPI::createTestValue):
344         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
345         (TestWebKitAPI::TEST):
346         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
347         (TestWebKitAPI::TEST_F):
348         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
349         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
350         (TestWebKitAPI::createNewPage):
351         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
352         (TestWebKitAPI::createNewPage):
353         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
354         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
355         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
356         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
357         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
358         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
359         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
360         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
361         (serverCallback):
362         (testWebViewAuthenticationProxyHTTPS):
363         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
364         (WebKitDOMDOMWindowTest::create):
365         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
366         (TestWebKitAPI::Util::toSTD):
367         * TestWebKitAPI/cocoa/TestWKWebView.mm:
368         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
369         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
370         * TestWebKitAPI/mac/TestFontOptions.mm:
371         (-[TestFontOptions initWithFontOptions:]):
372         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
373         (WTR::EventSendingController::callAfterScrollingCompletes):
374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
375         (WTR::InjectedBundle::didCreatePage):
376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
377         (WTR::TestRunner::setOpenPanelFiles):
378         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
379         * WebKitTestRunner/StringFunctions.h:
380         (WTR::toSTD):
381         (WTR::toWTFString):
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::TestController::initialize):
384         (WTR::TestController::generatePageConfiguration):
385         (WTR::TestController::resetStateToConsistentValues):
386         (WTR::createTestURL):
387         (WTR::TestController::runTest):
388         (WTR::TestController::platformCreateWebView):
389         * WebKitTestRunner/TestInvocation.cpp:
390         (WTR::TestInvocation::runUISideScript):
391         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
392         (WTR::TestController::platformCreateWebView):
393         (WTR::TestController::setDefaultCalendarType):
394         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
395         (WTR::getGDKKeySymForKeyRef):
396         * WebKitTestRunner/ios/TestControllerIOS.mm:
397         (WTR::TestController::platformResetStateToConsistentValues):
398         (WTR::TestController::setKeyboardInputModeIdentifier):
399         * WebKitTestRunner/mac/EventSenderProxy.mm:
400         (WTR::EventSenderProxy::mouseDown):
401         (WTR::EventSenderProxy::mouseUp):
402         (WTR::EventSenderProxy::mouseMoveTo):
403         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
404         (WTR::wpeKeySymForKeyRef):
405
406 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
407
408         [ESNext] Implement optional chaining
409         https://bugs.webkit.org/show_bug.cgi?id=200199
410
411         Reviewed by Yusuke Suzuki.
412
413         * Scripts/run-jsc-stress-tests:
414
415 2019-08-17  Tim Horton  <timothy_horton@apple.com>
416
417         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
418         https://bugs.webkit.org/show_bug.cgi?id=200866
419         <rdar://problem/50254021>
420
421         Reviewed by Simon Fraser.
422
423         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
424         (WTR::PlatformWebView::windowSnapshotImage):
425         Replace some logging with release assertions that we are snapshotting a reasonable
426         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
427         "silently" failing with just a log that will be ignored is not helpful.
428
429 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
430
431         [WTF] ThreadGroupRemove test is flaky
432         https://bugs.webkit.org/show_bug.cgi?id=200763
433
434         Reviewed by Mark Lam.
435
436         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
437         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
438         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
439         and releasing the lock after that.
440
441         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
442         (TestWebKitAPI::TEST):
443
444 2019-08-17  Eric Liang  <ericliang@apple.com>
445
446         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
447         https://bugs.webkit.org/show_bug.cgi?id=200367
448
449         Reviewed by Darin Adler.
450
451         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
452
453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
454         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
455         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
456         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
457         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
458         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
459         (TestWebKitAPI::TEST):
460
461 2019-08-17  Sam Weinig  <weinig@apple.com>
462
463         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
464         https://bugs.webkit.org/show_bug.cgi?id=200756
465
466         Reviewed by Darin Adler.
467
468         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
469         StringBuilder::append(...).
470
471         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
472         (TestWebKitAPI::TEST):
473
474 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
475
476         [iOS WK2] Scroll indicators disappear sometimes
477         https://bugs.webkit.org/show_bug.cgi?id=200791
478
479         Reviewed by Tim Horton.
480
481         Tests that test that scroll indicators survive subview replacement, and that
482         a custom view also survives subview replacement.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/cocoa/TestWKWebView.h:
488         * TestWebKitAPI/cocoa/TestWKWebView.mm:
489         (-[TestWKWebView performAfterLoading:]):
490         (-[UIView wkFirstSubviewWithClass:]):
491         (-[UIView wkFirstSubviewWithBoundsSize:]):
492         * TestWebKitAPI/ios/composited.html: Added.
493         * TestWebKitAPI/ios/overflow-scroll.html: Added.
494
495 2019-08-16  John Wilander  <wilander@apple.com>
496
497         Add John Wilander as WebKit Reviewer
498         https://bugs.webkit.org/show_bug.cgi?id=200837
499
500         Unreviewed update to contributors.json to change my status to reviewer.
501         See email on reviewers mailing list for proof of granted privileges.
502
503         * Scripts/webkitpy/common/config/contributors.json:
504
505 2019-08-16  Timothy Hatcher  <timothy@apple.com>
506
507         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
508         https://bugs.webkit.org/show_bug.cgi?id=200802
509         rdar://problem/54357818
510
511         Reviewed by Tim Horton.
512
513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
514         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
515         (-[OpaqueTestWKWebView isOpaque]): Added.
516         (-[NonOpaqueTestWKWebView isOpaque]): Added.
517         (isOpaque): Added.
518         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
519         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
520         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
521
522 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
523
524         [ews] Add build steps for Windows Factory
525         https://bugs.webkit.org/show_bug.cgi?id=200813
526
527         Reviewed by Jonathan Bedard.
528
529         * BuildSlaveSupport/ews-build/factories.py:
530         (WindowsFactory.__init__):
531
532 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
533
534         [ews] Report machine uptime in PrintConfiguration
535         https://bugs.webkit.org/show_bug.cgi?id=200812
536
537         Reviewed by Jonathan Bedard.
538
539         * BuildSlaveSupport/ews-build/steps.py:
540         (PrintConfiguration): Added uptime command.
541         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
542
543 2019-08-16  Chris Lord  <clord@igalia.com>
544
545         Add shared-mime-info to WPE WebKit jhbuild
546         https://bugs.webkit.org/show_bug.cgi?id=200768
547
548         Reviewed by Carlos Alberto Lopez Perez.
549
550         * wpe/jhbuild.modules:
551
552 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
553
554         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
555         https://bugs.webkit.org/show_bug.cgi?id=200620
556
557         Reviewed by Geoffrey Garen.
558
559         * DumpRenderTree/AccessibilityController.h:
560         * DumpRenderTree/GCController.h:
561         * DumpRenderTree/win/DRTDataObject.cpp:
562         * DumpRenderTree/win/DRTDataObject.h:
563         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
564         * DumpRenderTree/win/DRTDropSource.h:
565         * DumpRenderTree/win/DraggingInfo.h:
566         * DumpRenderTree/win/EditingDelegate.h:
567         * DumpRenderTree/win/EventSender.cpp:
568         * DumpRenderTree/win/FrameLoadDelegate.h:
569         * DumpRenderTree/win/HistoryDelegate.h:
570         * DumpRenderTree/win/MD5.h:
571         * DumpRenderTree/win/PolicyDelegate.h:
572         * DumpRenderTree/win/ResourceLoadDelegate.h:
573         * DumpRenderTree/win/TextInputController.h:
574         * DumpRenderTree/win/UIDelegate.cpp:
575         * DumpRenderTree/win/UIDelegate.h:
576         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
577         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
578         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
579         * TestWebKitAPI/Counters.h:
580         * TestWebKitAPI/PlatformWebView.h:
581         * TestWebKitAPI/Tests/WTF/Expected.cpp:
582         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
583         (TestWebKitAPI::DerefObserver::ref):
584         (TestWebKitAPI::DerefObserver::deref):
585         (TestWebKitAPI::TEST):
586         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
587         (TestWebKitAPI::DerefObserver::ref):
588         (TestWebKitAPI::DerefObserver::deref):
589         (TestWebKitAPI::TEST):
590         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
591         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
592         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
593         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
594         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
595         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
596         * WebKitTestRunner/EventSenderProxy.h:
597         * WebKitTestRunner/GeolocationProviderMock.h:
598         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
599         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
601         * WebKitTestRunner/PlatformWebView.h:
602         * WebKitTestRunner/TestInvocation.h:
603
604 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
605
606         Some improvements on web storage
607         https://bugs.webkit.org/show_bug.cgi?id=200373
608
609         Reviewed by Geoffrey Garen.
610
611         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
612         (TEST): update expectation for behavior change.
613
614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
615         database file.
616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
617         (WTR::TestRunner::syncLocalStorage):
618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
619
620         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
621         (WTR::TestController::resetStateToConsistentValues):
622         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
623         (WTR::StorageVoidCallback):
624         (WTR::TestController::clearIndexedDatabases):
625         (WTR::TestController::clearLocalStorage):
626         (WTR::TestController::syncLocalStorage):
627         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
628         with StorageVoidCallbackContext for general usage.
629         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
630         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
631         * WebKitTestRunner/TestController.h:
632
633         * WebKitTestRunner/TestInvocation.cpp:
634         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
635         SyncLocalStorage.
636
637 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
638
639         results.webkit.org: Add content hook to FlaskRequestsResponse
640         https://bugs.webkit.org/show_bug.cgi?id=200721
641
642         Rubber-stamped by Aakash Jain.
643
644         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
645         (FlaskRequestsResponse):
646         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
647         Response, conforming to request's API.
648
649 2019-08-15  Alex Christensen  <achristensen@webkit.org>
650
651         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
652         https://bugs.webkit.org/show_bug.cgi?id=200750
653         <rdar://problem/54232261> and <rdar://problem/52355829>
654
655         Reviewed by Tim Horton.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
658         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
659         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
660         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
661         (contextMenuWebViewDriver):
662         (TEST):
663
664 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
665
666         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
667         https://bugs.webkit.org/show_bug.cgi?id=200726
668
669         Reviewed by Simon Fraser.
670
671         To get the pixels as an array of colors, draw the image into a memory
672         context. The backing memory buffer can then be accessed to get the image
673         pixels' colors.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
676         (TestWebKitAPI::TEST):
677
678 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
679
680         Unreviewed, rolling out r248526.
681
682         Caused two IndexedDB perf tests to fail
683
684         Reverted changeset:
685
686         "Remove IDB-specific quota"
687         https://bugs.webkit.org/show_bug.cgi?id=196545
688         https://trac.webkit.org/changeset/248526
689
690 2019-08-14  Keith Rollin  <krollin@apple.com>
691
692         Remove support for macOS < 10.13
693         https://bugs.webkit.org/show_bug.cgi?id=200694
694         <rdar://problem/54278851>
695
696         Reviewed by Youenn Fablet.
697
698         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
699         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
700         101300. This means that expressions like
701         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
702         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
703
704         * MiniBrowser/AppKitCompatibilityDeclarations.h:
705         * MiniBrowser/mac/SettingsController.m:
706         (-[SettingsController init]):
707         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
708         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
709         (TestWebKitAPI::createPlatformFont): Deleted.
710         (TestWebKitAPI::compareFonts): Deleted.
711         (TestWebKitAPI::TEST_F): Deleted.
712         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
713         (TestWebKitAPI::TEST):
714         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
715         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
716         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
717         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
718         (runWebsiteDataStoreCustomPaths):
719         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
720
721 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
722
723         [JSC] Less contended MetaAllocator
724         https://bugs.webkit.org/show_bug.cgi?id=200278
725
726         Reviewed by Mark Lam.
727
728         Update the interface.
729
730         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
731
732 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
733
734         results.webkit.org: 500 errors on API endpoints don't return JSON
735         https://bugs.webkit.org/show_bug.cgi?id=200722
736
737         Reviewed by Aakash Jain.
738
739         * resultsdbpy/resultsdbpy/controller/api_routes.py:
740         (APIRoutes.response_500): We should return the response, instead of abort.
741
742 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
743
744         results.webkit.org: Don't save configuration multiple times in upload
745         https://bugs.webkit.org/show_bug.cgi?id=200719
746
747         Reviewed by Aakash Jain.
748
749         * resultsdbpy/resultsdbpy/model/upload_context.py:
750         (UploadContext.upload_test_results): Move registering of the configuration out
751         of the branch loop.
752
753 2019-08-14  Youenn Fablet  <youenn@apple.com>
754
755         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
756         https://bugs.webkit.org/show_bug.cgi?id=200706
757
758         Reviewed by Alex Christensen.
759
760         Libwebrtc is now soft-linked so we can reenable this test.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
763         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
764
765 2019-08-13  Sam Weinig  <weinig@apple.com>
766
767         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
768         https://bugs.webkit.org/show_bug.cgi?id=200675
769
770         Reviewed by Darin Adler.
771
772         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
773         (TestWebKitAPI::TEST):
774         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
775
776 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
777
778         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
779         https://bugs.webkit.org/show_bug.cgi?id=200456
780
781         Reviewed by Jonathan Bedard.
782
783         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
784
785         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
786
787         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
788         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
789         (pointPolygonCollisionDetect): Detact
790         (pointRightRayLineSegmentCollisionDetect):
791         (ColorBatchRender):
792         (ColorBatchRender.prototype.lazyCreateColorSeqs):
793         (ColorBatchRender.prototype.addSeq):
794         (ColorBatchRender.prototype.batchRender):
795         (ColorBatchRender.prototype.clear):
796         (xScrollStreamRenderFactory):
797         (Timeline.CanvasSeriesComponent):
798         (offscreenCachedRenderFactory): Deleted.
799
800 2019-08-13  John Wilander  <wilander@apple.com>
801
802         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
803         https://bugs.webkit.org/show_bug.cgi?id=200642
804         <rdar://problem/53962073>
805
806         Reviewed by Alex Christensen.
807
808         This patch adds test infrastructure to query whether an origin has an
809         isolated NSURLSession or not.
810
811         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
812         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
813         (WTR::TestRunner::hasStatisticsIsolatedSession):
814         * WebKitTestRunner/InjectedBundle/TestRunner.h:
815         * WebKitTestRunner/TestController.cpp:
816         (WTR::TestController::hasStatisticsIsolatedSession):
817         * WebKitTestRunner/TestController.h:
818         * WebKitTestRunner/TestInvocation.cpp:
819         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
820
821 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
822
823         Update my status in contributors.json to committer.
824
825         Reviewed by Unreviewed
826
827         * Scripts/webkitpy/common/config/contributors.json:
828
829 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
830
831         Adds WebAuthn and AppSSO into watchlist
832         https://bugs.webkit.org/show_bug.cgi?id=200647
833
834         Reviewed by Dewei Zhu.
835
836         * Scripts/webkitpy/common/config/watchlist:
837
838 2019-08-13  Chris Dumez  <cdumez@apple.com>
839
840         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
841         https://bugs.webkit.org/show_bug.cgi?id=200674
842         <rdar://problem/50692748>
843
844         Reviewed by Geoff Garen.
845
846         Add API test coverage.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
849
850 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
851
852         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
853         https://bugs.webkit.org/show_bug.cgi?id=199857
854
855         Reviewed by Yusuke Suzuki.
856
857         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
858         (TestWebKitAPI::countThreadGroups):
859         (TestWebKitAPI::TEST):
860
861 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
862
863         AX: Homebrew is not allowed to run any script under sudo.
864         https://bugs.webkit.org/show_bug.cgi?id=173801
865
866         Reviewed by Carlos Alberto Lopez Perez.
867
868         Latest versions of Homebrew throw an error when run as root.
869         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
870
871         * gtk/install-dependencies:
872
873 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
874
875         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
876         https://bugs.webkit.org/show_bug.cgi?id=200644
877
878         Reviewed by Aakash Jain.
879
880         * Scripts/webkitpy/port/simulator_process.py:
881         (SimulatorProcess._start): Define system PID after launching app.
882
883 2019-08-12  Sam Weinig  <weinig@apple.com>
884
885         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
886         https://bugs.webkit.org/show_bug.cgi?id=200614
887
888         Reviewed by Darin Adler.
889
890         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
891         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
892         
893         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
894         StringBuilder::appendSubstring(...).
895
896         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
897         (TestWebKitAPI::TEST):
898         Update for renames.
899
900 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
901
902         Fix Crash in Mail Search
903         https://bugs.webkit.org/show_bug.cgi?id=200589
904
905         Reviewed by Tim Horton.
906
907         If you search backwards first in mail, we would crash,
908         this tests that codepath.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
911         (TEST):
912
913 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
914
915         [iPadOS] Web pages sometimes load at half width in Safari
916         https://bugs.webkit.org/show_bug.cgi?id=200624
917         <rdar://problem/52694257>
918
919         Reviewed by Simon Fraser.
920
921         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
922         web page is created using the post-animated-resize web view dimensions, rather than the original layout
923         dimensions.
924
925         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
926
927 2019-08-12  Daniel Bates  <dabates@apple.com>
928
929         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
930         https://bugs.webkit.org/show_bug.cgi?id=200548
931
932         Reviewed by Darin Adler.
933
934         Expose infrastructure to simulate a literal raw key down and a literal key up event.
935
936         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
937         * TestRunnerShared/UIScriptContext/UIScriptController.h:
938         (WTR::UIScriptController::rawKeyDown):
939         (WTR::UIScriptController::rawKeyUp):
940         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
941         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
942         (WTR::UIScriptControllerIOS::rawKeyDown):
943         (WTR::UIScriptControllerIOS::rawKeyUp):
944
945 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
946
947         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
948         https://bugs.webkit.org/show_bug.cgi?id=200584
949
950         Reviewed by Philippe Normand.
951
952         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
953         Ignore style libwebrtc optionnal 'style issue'
954
955         * Scripts/webkitpy/style/checker.py:
956         * gstreamer/jhbuild.modules:
957         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
958
959 2019-08-12  Youenn Fablet  <youenn@apple.com>
960
961         Remove IDB-specific quota
962         https://bugs.webkit.org/show_bug.cgi?id=196545
963
964         Reviewed by Alex Christensen.
965
966         * DumpRenderTree/TestRunner.cpp:
967         (TestRunner::staticFunctions):
968         (setIDBPerOriginQuotaCallback): Deleted.
969         * DumpRenderTree/TestRunner.h:
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (runTest):
972         * DumpRenderTree/mac/TestRunnerMac.mm:
973         (TestRunner::setIDBPerOriginQuota): Deleted.
974         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
975         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
976         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
977         * WebKitTestRunner/InjectedBundle/TestRunner.h:
978         * WebKitTestRunner/TestController.cpp:
979         (WTR::TestController::resetStateToConsistentValues):
980         (WTR::TestController::setIDBPerOriginQuota): Deleted.
981         * WebKitTestRunner/TestController.h:
982         * WebKitTestRunner/TestInvocation.cpp:
983         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
984
985 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
986
987         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
988         https://bugs.webkit.org/show_bug.cgi?id=200621
989
990         Reviewed by Dan Bernstein.
991
992         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
993
994 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
997         https://bugs.webkit.org/show_bug.cgi?id=200604
998         <rdar://problem/51273130>
999
1000         Reviewed by Megan Gardner.
1001
1002         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
1003         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
1004         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
1005         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
1006         remains the same.
1007
1008         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
1009         the caret rect at initial scale 1.
1010
1011         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1012
1013 2019-08-09  Ali Juma  <ajuma@chromium.org>
1014
1015         Don't allow cross-origin iframes to autofocus
1016         https://bugs.webkit.org/show_bug.cgi?id=200515
1017         <rdar://problem/54092988>
1018
1019         Reviewed by Ryosuke Niwa.
1020
1021         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
1022         of cross-origin iframes, since it depends on focusing one of the
1023         frames.
1024
1025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1026         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1027         (TestWebKitAPI::TEST):
1028         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
1029
1030 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
1033         https://bugs.webkit.org/show_bug.cgi?id=200591
1034         <rdar://problem/54102238>
1035
1036         Reviewed by Ryosuke Niwa and Tim Horton.
1037
1038         Add a new API test to exercise -supportsImagePaste.
1039
1040         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1041         (TestWebKitAPI::TEST):
1042         * TestWebKitAPI/ios/UIKitSPI.h:
1043
1044 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1045
1046         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
1047         [ews-build] Set svn:ignore to various EWS Buildbot files
1048         https://bugs.webkit.org/show_bug.cgi?id=200581
1049
1050         Reviewed by Jonathan Bedard.
1051
1052         * BuildSlaveSupport/ews-build: Added property svn:ignore.
1053
1054 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1055
1056         [ews-build] Set svn:ignore to various EWS Buildbot files
1057         https://bugs.webkit.org/show_bug.cgi?id=200581
1058
1059         Reviewed by Jonathan Bedard.
1060
1061         * BuildSlaveSupport/ews-build: Added property svn:ignore.
1062
1063 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1064
1065         [ews] Add buildbot.tac to repository
1066         https://bugs.webkit.org/show_bug.cgi?id=200580
1067
1068         Reviewed by Jonathan Bedard.
1069
1070         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
1071
1072 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
1073
1074         [GTK] Add missing spellchecking packages to dependencies script
1075         https://bugs.webkit.org/show_bug.cgi?id=200574
1076
1077         Reviewed by Philippe Normand.
1078
1079         These are needed for the spellchecking test in WebContext API tests.
1080
1081         * gtk/install-dependencies:
1082
1083 2019-08-08  Jon Lee  <jonlee@apple.com>
1084
1085         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
1086
1087 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
1088
1089         webkitpy: Disable shared clipboard between Simulators
1090         https://bugs.webkit.org/show_bug.cgi?id=200546
1091
1092         Reviewed by Aakash Jain.
1093
1094         * Scripts/webkitpy/xcode/simulated_device.py:
1095         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
1096         managed by run-webkit-tests.
1097
1098 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
1099
1100         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
1101         https://bugs.webkit.org/show_bug.cgi?id=200539
1102         <rdar://problem/54082550>
1103
1104         Reviewed by Dean Jackson.
1105
1106         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1107         * PlatformFTW.cmake: Added.
1108
1109 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1110
1111         [iOS] Position image information should respect the image orientation
1112         https://bugs.webkit.org/show_bug.cgi?id=200487
1113
1114         Reviewed by Simon Fraser.
1115
1116         Add an API test to verify the position image information is drawn rotated
1117         because of respecting its image orientation.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
1123         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
1124
1125 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
1126
1127         [GTK] Fix WebContext languages test
1128         https://bugs.webkit.org/show_bug.cgi?id=200538
1129
1130         Reviewed by Alex Christensen.
1131
1132         This test broke after the format of Accepted-Languages
1133         was changed in r238236, update.
1134
1135         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1136         (testWebContextLanguages):
1137
1138 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
1139
1140         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
1141         https://bugs.webkit.org/show_bug.cgi?id=200536
1142
1143         Reviewed by Carlos Alberto Lopez Perez.
1144
1145         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1146         (testWebsiteDataDatabases): Databases take a moment to be written,
1147         wait before fetching the data as it's done in other tests.
1148
1149 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
1150
1151         results.webkit.org: Use canvas for timeline
1152         https://bugs.webkit.org/show_bug.cgi?id=200172
1153
1154         Rubber-stamped by Aakash Jain.
1155
1156         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1157         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
1158         (Commit.compare): Ditto.
1159         (_CommitBank.commitByUuid): Ditto.
1160         (_CommitBank._loadSiblings): Ditto.
1161         (_CommitBank._load): Ditto.
1162         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1163         (tickForCommit): Deleted.
1164         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
1165         which encompasses all results. Crucially, this function must exclude an UUIDs which may
1166         refer to results excluded because of the limit argument.
1167         (renderTimeline): Deleted.
1168         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
1169         with those results.
1170         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
1171         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
1172         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
1173         (inPlaceCombine): Combine result objects together.
1174         (statsForSingleResult): Turn a single result into a stat object.
1175         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
1176         (Dot): Deleted.
1177         (TimelineFromEndpoint): Renamed from Timeline.
1178         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
1179         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
1180         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
1181         cache contents.
1182         (TimelineFromEndpoint.reload): Remove management of nested timelines.
1183         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
1184         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
1185         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1186
1187 2019-08-08  Brady Eidson  <beidson@apple.com>
1188
1189         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
1190         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
1191
1192         Reviewed by Geoff Garen.
1193
1194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1195         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
1196
1197 2019-08-08  Rob Buis  <rbuis@igalia.com>
1198
1199         Add runtime flag for lazy image loading
1200         https://bugs.webkit.org/show_bug.cgi?id=199794
1201
1202         Reviewed by Darin Adler.
1203
1204         Set lazyImageLoading preference as part of experimental features. Add
1205         TestOption for lazy image loading.
1206
1207         * DumpRenderTree/TestOptions.cpp:
1208         (TestOptions::TestOptions):
1209         * DumpRenderTree/TestOptions.h:
1210         * DumpRenderTree/mac/DumpRenderTree.mm:
1211         (enableExperimentalFeatures):
1212         (setWebPreferencesForTestOptions):
1213         * DumpRenderTree/win/DumpRenderTree.cpp:
1214         (enableExperimentalFeatures):
1215
1216 2019-08-08  Rob Buis  <rbuis@igalia.com>
1217
1218         Import lazy loading WPT tests
1219         https://bugs.webkit.org/show_bug.cgi?id=199795
1220
1221         Reviewed by Darin Adler.
1222
1223         Only do loading/ exception for WebKit specific, non WPT tests.
1224
1225         * DumpRenderTree/mac/DumpRenderTree.mm:
1226         (shouldLogFrameLoadDelegates):
1227         * WebKitTestRunner/TestInvocation.cpp:
1228         (WTR::TestInvocation::TestInvocation):
1229
1230 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1231
1232         [Win][MiniBrowser] Add key accelerators for reload and close window
1233         https://bugs.webkit.org/show_bug.cgi?id=200497
1234
1235         Reviewed by Brent Fulgham.
1236
1237         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
1238
1239         * MiniBrowser/win/MainWindow.cpp:
1240         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
1241         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
1242         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
1243
1244 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
1245
1246         Add WHLSL and WebGPU to the watchlist file
1247         https://bugs.webkit.org/show_bug.cgi?id=200509
1248
1249         Reviewed by Robin Morisset.
1250
1251         * Scripts/webkitpy/common/config/watchlist:
1252
1253 2019-08-07  Keith Rollin  <krollin@apple.com>
1254
1255         Unreviewed build fix after r248317 -- disable XCBuild because it
1256         breaks incremental builds.
1257
1258         * Scripts/webkitdirs.pm:
1259         (canUseXCBuild):
1260
1261 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1262
1263         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
1264         https://bugs.webkit.org/show_bug.cgi?id=200465
1265
1266         Reviewed by Alex Christensen.
1267
1268         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
1269         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
1270         finishing the test.
1271         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1272         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
1273
1274 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1275
1276         Unreviewed, a build fix after r248308
1277
1278         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
1279
1280         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1281
1282 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1283
1284         Unreviewed, a build fix after r248319
1285
1286         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
1287
1288         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1290         (WTR::TestController::addTestKeyToKeychain):
1291         (WTR::TestController::cleanUpKeychain):
1292         (WTR::TestController::keyExistsInKeychain):
1293
1294 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1295
1296         Unreviewed, a build fix after r248308
1297
1298         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
1299
1300         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1301         (WTR::TestController::addTestKeyToKeychain):
1302         (WTR::TestController::cleanUpKeychain):
1303         (WTR::TestController::keyExistsInKeychain):
1304
1305 2019-08-06  Keith Rollin  <krollin@apple.com>
1306
1307         Enable XCBuild for `make` and `build-webkit` builds
1308         https://bugs.webkit.org/show_bug.cgi?id=200476
1309         <rdar://problem/50771065>
1310
1311         Reviewed by Jonathan Bedard.
1312
1313         All projects have now been tested under XCBuild and successfully
1314         build. Enable the use of XCBuild when performing builds with `make` or
1315         `build-webkit` and when using a sufficient version of Xcode. We set
1316         this version to Xcode 11 since Xcode 10 -- even though it supports
1317         XCBuild -- does not support a build facility needed to build WebKit
1318         (Bug 197072, Bug 197116, Bug 197340).
1319
1320         Do not enable XCBuild in the Xcode projects themselves since these
1321         projects may need to be used under older versions of Xcode and there's
1322         no way to make those project changes sensitive to the version of Xcode
1323         being used. This means that builds performed in the Xcode IDE will not
1324         use XCBuild.
1325
1326         * Scripts/webkitdirs.pm:
1327         (canUseXCBuild):
1328
1329 2019-08-06  Chris Dumez  <cdumez@apple.com>
1330
1331         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
1332         https://bugs.webkit.org/show_bug.cgi?id=200475
1333
1334         Reviewed by Darin Adler.
1335
1336         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1337         (TestWebKitAPI::stringViewFromLiteral):
1338         (TestWebKitAPI::stringViewFromUTF8):
1339
1340 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1341
1342         Update my status in contributors.json to reviewer.
1343
1344         Regained the status after following the procedure for inactive contributors.
1345         See r247136 for further explanation.
1346
1347         * Scripts/webkitpy/common/config/contributors.json:
1348
1349 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1350
1351         [WebAuthN] Enable LocalAuthenticator for macOS
1352         https://bugs.webkit.org/show_bug.cgi?id=182772
1353         <rdar://problem/43347920>
1354
1355         Reviewed by Brent Fulgham.
1356
1357         Add an entitlement file to WebKitTestRunner such that it can access
1358         the modern macOS keychain.
1359
1360         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
1361         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1362         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1363         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1364         (WTR::TestController::addTestKeyToKeychain):
1365         (WTR::TestController::cleanUpKeychain):
1366         (WTR::TestController::keyExistsInKeychain):
1367
1368 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
1369
1370         [results.webkit.org Timeline] Performance improvements
1371         https://bugs.webkit.org/show_bug.cgi?id=200406
1372
1373         Reviewed by Jonathan Bedard.
1374
1375         1. Unhook the scroll event when a series/axis have been removed from the container
1376         2. Fix the axis's cache data structure out of sync.
1377         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
1378         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
1379
1380
1381         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1382         (Signal.prototype.removeListener):
1383         (prototype.stopAction): Unregsiter an action handler
1384         (Ref):
1385         (Ref.prototype.apply):
1386         (Ref.prototype.destory):
1387         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1388         (ApplyNewChildren):
1389         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1390         (Timeline.CanvasSeriesComponent):
1391
1392 2019-08-06  Jer Noble  <jer.noble@apple.com>
1393
1394         Add test for behavior introduced in r248174
1395         https://bugs.webkit.org/show_bug.cgi?id=200446
1396
1397         Reviewed by Eric Carlson.
1398
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
1401         (WebKit::configureSecheuristic):
1402         (WebKit::TEST):
1403
1404 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
1405
1406         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
1407         https://bugs.webkit.org/show_bug.cgi?id=200464
1408
1409         Reviewed by Ross Kirsling.
1410
1411         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
1412         menu, Alt-F4 to close window, and etc) don't work.
1413
1414         WK1 WebView doesn't have this issue because it processes key events
1415         properly.
1416
1417         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1418         (WebKitBrowserWindow::WebKitBrowserWindow):
1419         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
1420         unhandled key events to the main window.
1421         * MiniBrowser/win/WebKitBrowserWindow.h:
1422
1423 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
1424
1425         iOS 13: Overflow:hidden on body prevents PDF scroll
1426         https://bugs.webkit.org/show_bug.cgi?id=200435
1427         rdar://problem/53942888
1428
1429         Reviewed by Tim Horton.
1430
1431         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
1432         to make sure that the scroll view is scrollable.
1433
1434         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
1435         (TestWebKitAPI::TEST):
1436
1437 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
1438
1439         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
1440         https://bugs.webkit.org/show_bug.cgi?id=200400
1441
1442         Reviewed by Jonathan Bedard.
1443
1444         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1445         (StatusBubble._build_bubble):
1446         (StatusBubble._queue_position):
1447
1448 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
1449
1450         run-webkit-tests asserts when the iPhone XR simulator is running
1451         https://bugs.webkit.org/show_bug.cgi?id=200404
1452         <rdar://problem/53878739>
1453
1454         Reviewed by Dean Jackson.
1455
1456         Support unicode in all logging statements tied to device model.
1457
1458         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1459         (Manager.run):
1460         * Scripts/webkitpy/layout_tests/views/printing.py:
1461         (Printer.print_baseline_search_path):
1462         * Scripts/webkitpy/port/device.py:
1463         (Device.__repr__):
1464         * Scripts/webkitpy/port/device_port.py:
1465         (DevicePort._install):
1466         (DevicePort.setup_test_run):
1467         (DevicePort.clean_up_test_run):
1468         (DevicePort.configuration_for_upload):
1469         * Scripts/webkitpy/port/ios.py:
1470         (IOSPort.default_baseline_search_path):
1471         * Scripts/webkitpy/xcode/device_type.py:
1472         (DeviceType.__str__):
1473         * Scripts/webkitpy/xcode/simulated_device.py:
1474         (SimulatedDeviceManager.populate_available_devices):
1475         (SimulatedDeviceManager._find_available_name):
1476         (SimulatedDeviceManager._get_device_identifier_for_type):
1477         (SimulatedDeviceManager._create_or_find_device_for_request):
1478         (SimulatedDeviceManager._does_fulfill_request):
1479         (SimulatedDeviceManager._wait_until_device_in_state):
1480         (SimulatedDeviceManager._wait_until_device_is_usable):
1481         (SimulatedDeviceManager._boot_device):
1482         (SimulatedDeviceManager.initialize_devices):
1483         (SimulatedDeviceManager.max_supported_simulators):
1484         (SimulatedDeviceManager.swap):
1485         (SimulatedDevice.is_usable):
1486         (SimulatedDevice._shut_down):
1487         (SimulatedDevice._delete):
1488         (SimulatedDevice.launch_app):
1489         (SimulatedDevice.__repr__):
1490
1491 2019-08-04  Chris Dumez  <cdumez@apple.com>
1492
1493         Ping loads should not prevent page caching
1494         https://bugs.webkit.org/show_bug.cgi?id=200418
1495         <rdar://problem/53901632>
1496
1497         Reviewed by Darin Adler.
1498
1499         Add TestOption to enable PageCache at UIProcess-level so that we can test
1500         page caching when navigating cross-origin with PSON enabled.
1501
1502         * WebKitTestRunner/TestController.cpp:
1503         (WTR::TestController::resetPreferencesToConsistentValues):
1504         (WTR::updateTestOptionsFromTestHeader):
1505         * WebKitTestRunner/TestOptions.h:
1506         (WTR::TestOptions::hasSameInitializationOptions const):
1507
1508 2019-08-02  Keith Rollin  <krollin@apple.com>
1509
1510         Consistently use Obj-C boolean literals
1511         https://bugs.webkit.org/show_bug.cgi?id=200405
1512         <rdar://problem/53880043>
1513
1514         Reviewed by Simon Fraser, Joseph Pecoraro.
1515
1516         There are places where we use equivalent but different expressions for
1517         Obj-C boolean objects. For example, we use both [NSNumber
1518         numberWithBool:YES] and @YES. There are places where both are used in
1519         the same function, such as -[WebPreferences initialize]. The boolean
1520         literal is in greater use and is more succinct, so standardize on
1521         that. Also, change @(YES/NO) to @YES/NO.
1522
1523         * DumpRenderTree/mac/ObjCController.m:
1524         (-[ObjCController objectOfClass:]):
1525         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1526         (TEST):
1527         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1528         (overrideAddObserverForName):
1529         * TestWebKitAPI/ios/mainIOS.mm:
1530         (main):
1531         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1532         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1533         * TestWebKitAPI/mac/mainMac.mm:
1534         (main):
1535         * WebKitLauncher/WebKitNightlyEnabler.m:
1536         (enableWebKitNightlyBehaviour):
1537
1538 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1539
1540         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
1541         https://bugs.webkit.org/show_bug.cgi?id=200402
1542         <rdar://problem/53823368>
1543
1544         Reviewed by Tim Horton.
1545
1546         Make it possible to run this test using the iPad simulator.
1547
1548         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1549
1550         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
1551         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
1552         since this would result in differently sized text.
1553
1554         (mainScreenReferenceBoundsOverride):
1555         * TestWebKitAPI/ios/UIKitSPI.h:
1556
1557 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
1558
1559         API tests using permanent credentials should clear credentials left by previous tests
1560         https://bugs.webkit.org/show_bug.cgi?id=199729
1561
1562         Reviewed by Alex Christensen.
1563
1564         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
1565         credentials will not affect tests running after. There is a case where permanent credentials were left on the
1566         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
1567         failure. To prevent this from happening again, add cleanup at the begining of the tests.
1568
1569         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1570         (TEST):
1571         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1572         (TestWebKitAPI::TEST):
1573
1574 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
1575
1576         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
1577         https://bugs.webkit.org/show_bug.cgi?id=200394
1578         <rdar://problem/52914964>
1579
1580         Reviewed by Chris Fleizach.
1581
1582         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
1583
1584         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1585         (WTR::AccessibilityUIElement::isInTableCell const):
1586         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1587         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1588         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1589         (WTR::AccessibilityUIElement::isInTableCell const):
1590
1591 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
1592
1593         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
1594         https://bugs.webkit.org/show_bug.cgi?id=200397
1595
1596         Reviewed by Jonathan Bedard.
1597
1598         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1599
1600 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1601
1602         [macOS 10.15] Image dragged from Safari does not appear in Notes
1603         https://bugs.webkit.org/show_bug.cgi?id=188490
1604         <rdar://problem/39462717>
1605
1606         Reviewed by Andy Estes.
1607
1608         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
1609
1610         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1611
1612 2019-08-02  Alex Christensen  <achristensen@webkit.org>
1613
1614         Fix API test after r248139
1615         https://bugs.webkit.org/show_bug.cgi?id=200102
1616
1617         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1618         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1619         This was supposed to be removed as part of reverting r245322.
1620
1621 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1622
1623         results.webkit.org: Force update cache when timeline updated
1624         https://bugs.webkit.org/show_bug.cgi?id=200363
1625
1626         Reviewed by Jonathan Bedard.
1627
1628         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1629         (offscreenCachedRenderFactory): Add ability to force the redraw.
1630         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
1631         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
1632
1633 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1634
1635         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
1636         https://bugs.webkit.org/show_bug.cgi?id=200360
1637
1638         Reviewed by Tim Horton.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1641         (cleanupITPDatabase):
1642         (TEST):
1643
1644 2019-08-01  Alex Christensen  <achristensen@webkit.org>
1645
1646         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
1647         https://bugs.webkit.org/show_bug.cgi?id=200102
1648         <rdar://problem/53275114>
1649
1650         Reviewed by Darin Adler.
1651
1652         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
1653         and because clicking on a TestWKWebView only works on Mac.
1654
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
1657         (-[UploadDelegate initWithDirectory:]):
1658         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1659         (-[UploadDelegate sentDirectory]):
1660         (TEST):
1661         * TestWebKitAPI/cocoa/TestWKWebView.h:
1662         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1663         (-[TestWKWebView sendClickAtPoint:]):
1664
1665 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1666
1667         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
1668         https://bugs.webkit.org/show_bug.cgi?id=200321
1669
1670         Reviewed by Jonathan Bedard.
1671
1672         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1673         Let the axis' height be defined in the option. Timeine component will use this value as
1674         padding-top for headers which allows headers start in the right position, even with multiple
1675         top axises.
1676         (Timeline.CanvasSeriesComponent):
1677         (prototype.Timeline.CanvasContainer):
1678
1679 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
1680
1681         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
1682         https://bugs.webkit.org/show_bug.cgi?id=200347
1683
1684         Reviewed by Jonathan Bedard.
1685
1686         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1687         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
1688
1689 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
1690
1691         Improve flakiness of SOAuthorizationRedirect tests
1692         https://bugs.webkit.org/show_bug.cgi?id=200320
1693         <rdar://problem/53767057>
1694
1695         Reviewed by Alex Christensen.
1696
1697         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
1698         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
1699         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
1700         is executed.
1701
1702         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1703         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1704         (resetState):
1705         (TestWebKitAPI::TEST):
1706
1707 2019-08-01  Keith Rollin  <krollin@apple.com>
1708
1709         Update TestWebKitAPI for XCBuild
1710         https://bugs.webkit.org/show_bug.cgi?id=200311
1711         <rdar://problem/53773804>
1712
1713         Reviewed by Alex Christensen.
1714
1715         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
1716         technique. Now update WebKitLegacy to build under XCBuild after those
1717         changes. This work involves adding an "Apply Configuration to
1718         XCFileLists" build target, adding a check-xcfilelists.sh script,
1719         adding a "Check xcfilelists" build phase that calls that script,
1720         adding knowledge of the project to the generate-xcfilelists script,
1721         creating new .xcfilelist files, and adding those to the project.
1722
1723         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1724         (Application.__init__):
1725         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1726         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1727         (TestWebKitAPIGenerator):
1728         (TestWebKitAPIGenerator._get_project_file_path):
1729         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
1730         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
1731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
1733
1734 2019-08-01  Youenn Fablet  <youenn@apple.com>
1735
1736         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
1737         https://bugs.webkit.org/show_bug.cgi?id=200317
1738
1739         Reviewed by Eric Carlson.
1740
1741         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
1742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1743         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1744         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1745         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1746         (TestWebKitAPI::TEST):
1747
1748 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
1749
1750         New EWS: Cannot see build status page when patch is waiting for tester
1751         https://bugs.webkit.org/show_bug.cgi?id=200333
1752
1753         Reviewed by Jonathan Bedard.
1754
1755         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1756         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
1757
1758 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1759
1760         [SOUP] Switch to use libsoup WebSockets API
1761         https://bugs.webkit.org/show_bug.cgi?id=200162
1762
1763         Reviewed by Michael Catanzaro.
1764
1765         Update libsoup version to 2.67.90.
1766
1767         * gtk/jhbuild.modules:
1768         * wpe/jhbuild.modules:
1769
1770 2019-07-31  Andy Estes  <aestes@apple.com>
1771
1772         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1773         https://bugs.webkit.org/show_bug.cgi?id=200293
1774         <rdar://problem/52937749>
1775
1776         Reviewed by Alex Christensen.
1777
1778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1779         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1780         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1781         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1782         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1783         (TEST):
1784
1785 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1786
1787         [ews-build] Enable all macOS queues on new EWS
1788         https://bugs.webkit.org/show_bug.cgi?id=199944
1789
1790         Reviewed by Jonathan Bedard.
1791
1792         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1793         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1794         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1795         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1797         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1798
1799 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1800
1801         Unreviewed test gardening, disable failing test for rdar://51752593.
1802
1803         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1804
1805 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1806
1807         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1808         https://bugs.webkit.org/show_bug.cgi?id=200318
1809
1810         Reviewed by Aakash Jain.
1811
1812         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1813         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1814         (Timeline.CanvasXAxisComponent): Use getLabel function.
1815
1816 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1817
1818         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1819         https://bugs.webkit.org/show_bug.cgi?id=200306
1820
1821         Reviewed by Michael Catanzaro.
1822
1823         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1824         jsc-glib-4.0-scan for example).
1825
1826         * Scripts/webkitdirs.pm:
1827         (generateBuildSystemFromCMakeProject):
1828
1829 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1830
1831         Unreviewed test gardening, disable failing test for rdar://52355829.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1834         (TEST):
1835
1836 2019-07-31  Keith Rollin  <krollin@apple.com>
1837
1838         Update WebKitLegacy for XCBuild
1839         https://bugs.webkit.org/show_bug.cgi?id=200310
1840         <rdar://problem/53773708>
1841
1842         Reviewed by Alex Christensen.
1843
1844         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1845         technique. Now update WebKitLegacy to build under XCBuild after those
1846         changes. This work involves adding an "Apply Configuration to
1847         XCFileLists" build target, adding a check-xcfilelists.sh script,
1848         adding a "Check xcfilelists" build phase that calls that script,
1849         adding knowledge of the project to the generate-xcfilelists script,
1850         creating new .xcfilelist files, and adding those to the project.
1851
1852         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1853         (Application.__init__):
1854         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1855         (JavaScriptCoreGenerator):
1856         (WebCoreGenerator):
1857         (WebKitGenerator):
1858         (WebKitGenerator._get_generate_unified_sources_script):
1859         (WebKitLegacyGenerator):
1860         (WebKitLegacyGenerator._get_project_file_path):
1861         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1862
1863 2019-07-31  Chris Dumez  <cdumez@apple.com>
1864
1865         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1866         https://bugs.webkit.org/show_bug.cgi?id=200086
1867         <rdar://problem/53501721>
1868
1869         Reviewed by Alex Christensen.
1870
1871         re-enable the API test.
1872
1873         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1874         (TEST):
1875
1876 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1877
1878         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1879         https://bugs.webkit.org/show_bug.cgi?id=200291
1880         <rdar://problem/53717946>
1881
1882         Reviewed by Megan Gardner.
1883
1884         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1885         after closing the web view, while the web view's content view isn't the first responder.
1886
1887         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1888         * TestWebKitAPI/ios/UIKitSPI.h:
1889
1890 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1891
1892         [GTK] Datalist element support for TextFieldInputType
1893         https://bugs.webkit.org/show_bug.cgi?id=98934
1894
1895         Reviewed by Michael Catanzaro.
1896
1897         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1898
1899         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1900         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1901         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1902
1903 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1904
1905         Remove some needless comments that snuck into the tree
1906
1907         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1908         (WTR::UIScriptController::setHardwareKeyboardAttached):
1909         (WTR::UIScriptController::playBackEventStream):
1910
1911 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1912
1913         [WebKit] Add PageLoadState::Observer C API
1914         https://bugs.webkit.org/show_bug.cgi?id=199848
1915
1916         Reviewed by Alex Christensen.
1917
1918         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1919         (WebKitBrowserWindow::WebKitBrowserWindow):
1920         (WebKitBrowserWindow::didChangeTitle):
1921         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1922         * MiniBrowser/win/WebKitBrowserWindow.h:
1923         * TestWebKitAPI/CMakeLists.txt:
1924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1925         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1926         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1927         (TestWebKitAPI::didChangeActiveURL):
1928         (TestWebKitAPI::didChangeCanGoBack):
1929         (TestWebKitAPI::didChangeCanGoForward):
1930         (TestWebKitAPI::didChangeCertificateInfo):
1931         (TestWebKitAPI::didChangeEstimatedProgress):
1932         (TestWebKitAPI::didChangeHasOnlySecureContent):
1933         (TestWebKitAPI::didChangeIsLoading):
1934         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1935         (TestWebKitAPI::didChangeTitle):
1936         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1937         (TestWebKitAPI::didSwapWebProcesses):
1938         (TestWebKitAPI::willChangeActiveURL):
1939         (TestWebKitAPI::willChangeCanGoBack):
1940         (TestWebKitAPI::willChangeCanGoForward):
1941         (TestWebKitAPI::willChangeCertificateInfo):
1942         (TestWebKitAPI::willChangeEstimatedProgress):
1943         (TestWebKitAPI::willChangeHasOnlySecureContent):
1944         (TestWebKitAPI::willChangeIsLoading):
1945         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1946         (TestWebKitAPI::willChangeTitle):
1947         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1948         (TestWebKitAPI::didFinishNavigation):
1949         (TestWebKitAPI::TEST):
1950
1951 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1952
1953         DumpRenderTree.app: Add CFBundleShortVersionString
1954         https://bugs.webkit.org/show_bug.cgi?id=200269
1955         <rdar://problem/53412596>
1956
1957         Rubber-stamped by Aakash Jain.
1958
1959         * DumpRenderTree/ios/Info.plist:
1960
1961 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1962
1963         Add layout test coverage for <https://webkit.org/b/200215>
1964         https://bugs.webkit.org/show_bug.cgi?id=200245
1965         <rdar://problem/52976965>
1966
1967         Reviewed by Tim Horton.
1968
1969         Add new testing infrastructure. See below for more details.
1970
1971         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1972         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1973         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1974         (WTR::UIScriptController::setWillCreateNewPageCallback):
1975         (WTR::UIScriptController::willCreateNewPageCallback const):
1976
1977         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1978         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1979
1980         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1981         (WTR::UIScriptController::becomeFirstResponder):
1982
1983         Add and implement a Cocoa platform hook to make the web view first responder.
1984
1985         * WebKitTestRunner/TestController.cpp:
1986         (WTR::TestController::createOtherPage):
1987         * WebKitTestRunner/TestInvocation.cpp:
1988         (WTR::TestInvocation::willCreateNewPage):
1989         * WebKitTestRunner/TestInvocation.h:
1990         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1991         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1992         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1993
1994 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1995
1996         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1997         https://bugs.webkit.org/show_bug.cgi?id=200217
1998
1999         Reviewed by Alex Christensen.
2000
2001         * MiniBrowser/win/BrowserWindow.h:
2002         * MiniBrowser/win/MainWindow.cpp:
2003         (MainWindow::init):
2004         (MainWindow::resizeSubViews):
2005         (MainWindow::WndProc):
2006         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
2007         * MiniBrowser/win/MiniBrowserLib.rc:
2008         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
2009         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2010         (WebKitBrowserWindow::reload):
2011         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
2012         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2013         (WebKitLegacyBrowserWindow::reload):
2014         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2015
2016 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
2017
2018         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
2019         https://bugs.webkit.org/show_bug.cgi?id=200218
2020
2021         Reviewed by Alex Christensen.
2022
2023         Moved the scheme supplementing logic from
2024         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
2025
2026         * MiniBrowser/win/MainWindow.cpp:
2027         (MainWindow::loadURL):
2028         (MainWindow::onURLBarEnter):
2029         * MiniBrowser/win/MainWindow.h:
2030         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2031         (WebKitLegacyBrowserWindow::loadURL):
2032
2033 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
2034
2035         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
2036         https://bugs.webkit.org/show_bug.cgi?id=200254
2037
2038         Unreviewed infrastructure fix.
2039
2040         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
2041
2042 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
2043
2044         [Canvas Timeline] Compact canvas timeline
2045         https://bugs.webkit.org/show_bug.cgi?id=200177
2046
2047         Reviewed by Jonathan Bedard.
2048
2049         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2050         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2051         (Timeline.CanvasSeriesComponent):
2052
2053 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         Multiple context menu actions broken for YouTube videos
2056         https://bugs.webkit.org/show_bug.cgi?id=199999
2057
2058         Reviewed by Eric Carlson.
2059
2060         Add a test case to check copy link address, open in new window and download options are not included in the
2061         context menu for non-downloadable media.
2062
2063         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2064         (writeNextChunk):
2065         (serverCallback):
2066         (testContextMenuLiveStream):
2067         (beforeAll):
2068         (afterAll):
2069
2070 2019-07-28  Tim Horton  <timothy_horton@apple.com>
2071
2072         Reorganize UIScriptController into platform-specific subclasses
2073         https://bugs.webkit.org/show_bug.cgi?id=200027
2074
2075         Reviewed by Simon Fraser.
2076
2077         Instead of a mishmash of #ifdefs and extraneous empty functions,
2078         reorganize UIScriptController so that we have a base class
2079         with functions that assert if called (to make it harder to
2080         accidentally write a test that depends on unimplemented
2081         functionality), and override them in platform specific subclasses
2082         as functionality is added.
2083
2084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2085         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
2086         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2087         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
2088         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2089         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2090         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2091         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2092         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
2093         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
2094         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2095         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
2096         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
2097         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2098         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
2099         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2100
2101 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2102
2103         [Win][MiniBrowser] Remove PageLoadTestClient
2104         https://bugs.webkit.org/show_bug.cgi?id=200155
2105
2106         Reviewed by Brent Fulgham.
2107
2108         It is not used nowadays.
2109
2110         * MiniBrowser/win/CMakeLists.txt:
2111         * MiniBrowser/win/Common.cpp:
2112         (parseCommandLine):
2113         * MiniBrowser/win/Common.h:
2114         * MiniBrowser/win/MainWindow.cpp:
2115         (MainWindow::init):
2116         * MiniBrowser/win/MainWindow.h:
2117         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2118         (MiniBrowserWebHost::updateAddressBar):
2119         (MiniBrowserWebHost::didFinishLoadForFrame):
2120         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
2121         (MiniBrowserWebHost::didFailLoadWithError):
2122         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
2123         (MiniBrowserWebHost::didFirstLayoutInFrame):
2124         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
2125         * MiniBrowser/win/PageLoadTestClient.h: Removed.
2126         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2127         (ResourceLoadDelegate::identifierForInitialRequest):
2128         (ResourceLoadDelegate::willSendRequest):
2129         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2130         (ResourceLoadDelegate::didFailLoadingWithError):
2131         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2132         (WebKitBrowserWindow::create):
2133         (WebKitBrowserWindow::createNewPage):
2134         * MiniBrowser/win/WebKitBrowserWindow.h:
2135         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2136         (WebKitLegacyBrowserWindow::create):
2137         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2138         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
2139         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2140         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
2141         * MiniBrowser/win/WinMain.cpp:
2142         (wWinMain):
2143
2144 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2145
2146         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
2147         https://bugs.webkit.org/show_bug.cgi?id=200150
2148         <rdar://problem/53280170>
2149
2150         Reviewed by Brent Fulgham.
2151
2152         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2153         (TestWebKitAPI::TEST):
2154
2155 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2156
2157         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
2158         https://bugs.webkit.org/show_bug.cgi?id=200090
2159
2160         Unreviewed follow-up fix.
2161
2162         * resultsdbpy/resultsdbpy/view/view_routes.py:
2163         (ViewRoutes.__init__): Keep /search endpoint for existing links
2164
2165 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2166
2167         results.webkit.org: Add switch to filter results by expectation
2168         https://bugs.webkit.org/show_bug.cgi?id=200134
2169
2170         Rubber-stamped by Aakash Jain.
2171
2172         Users of the results database should be able to easily differentiate tests which are expected
2173         to fail verse tests which are unexpectedly failing.
2174
2175         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2176         (Timeline.render): Respect the willFilterExpected variable.
2177         (LegendLabel): Generates html for label in the legend.
2178         (Legend): Add switch for filter results.
2179         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
2180         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2181
2182 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
2183
2184         [ews-build] Use update-webkit script in Style EWS
2185         https://bugs.webkit.org/show_bug.cgi?id=193196
2186
2187         Reviewed by Jonathan Bedard.
2188
2189         * BuildSlaveSupport/ews-build/factories.py:
2190         (StyleFactory): Updated to use CheckOutSource step as well.
2191         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
2192         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2193
2194 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2195
2196         results.webkit.org: Support buildbot 0.8 CI links
2197         https://bugs.webkit.org/show_bug.cgi?id=200146
2198
2199         Reviewed by Aakash Jain.
2200
2201         * resultsdbpy/resultsdbpy/model/ci_context.py:
2202         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
2203         (BuildbotEightURLFactory.__init__):
2204         (BuildbotEightURLFactory.url):
2205         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
2206         (URLFactoryTest.test_old_builder_url):
2207         (URLFactoryTest):
2208         (URLFactoryTest.test_old_worker_url):
2209
2210 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2211
2212         results.webkit.org: Suite results shouldn't be the landing page
2213         https://bugs.webkit.org/show_bug.cgi?id=200090
2214
2215         Reviewed by Aakash Jain.
2216
2217         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
2218         * resultsdbpy/resultsdbpy/view/view_routes.py:
2219         (ViewRoutes.__init__): Make search the landing page instead of suite results.
2220         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
2221         (WebSiteUnittest.test_main):
2222
2223 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2224
2225         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
2226         https://bugs.webkit.org/show_bug.cgi?id=200127
2227
2228         Unreviewed follow-up fix.
2229
2230         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2231         (Dot.toString): Use self instead of this in render callback.
2232
2233 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
2234
2235         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
2236         https://bugs.webkit.org/show_bug.cgi?id=200108
2237         <rdar://problem/53521238>
2238
2239         Reviewed by Chris Dumez.
2240
2241         Added an API test.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2244         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2245         (TEST):
2246
2247 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
2248
2249         results.webkit.org: Color should be the worst result, count should include all results
2250         https://bugs.webkit.org/show_bug.cgi?id=200127
2251
2252         Rubber-stamped by Aakash Jain.
2253
2254         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2255         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
2256
2257 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
2258
2259         [Timeline]: Make timeline header width automatic, instead of fixed width
2260         https://bugs.webkit.org/show_bug.cgi?id=200059
2261
2262         Reviewed by Jonathan Bedard.
2263
2264         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
2265         (.dot.crash):
2266         (.timeline>.header): Deleted.
2267         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2268         (.timeline>.content):
2269         (.timeline>.header):
2270
2271 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
2272
2273         [ESNext] Implement nullish coalescing
2274         https://bugs.webkit.org/show_bug.cgi?id=200072
2275
2276         Reviewed by Darin Adler.
2277
2278         * Scripts/run-jsc-stress-tests:
2279
2280 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2281
2282         Add Takashi Komori and Tomoki Imai as contributors
2283
2284         Unreviewed.
2285
2286         * Scripts/webkitpy/common/config/contributors.json:
2287
2288 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
2289
2290         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
2291         https://bugs.webkit.org/show_bug.cgi?id=200103
2292
2293         Reviewed by Mark Lam.
2294
2295         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
2296         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
2297
2298         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
2299         to the future implementation changes while it catches the severe issues we had.
2300
2301         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2302         (assertEmptyPointerSet):
2303         (assertHasOnlyObjects):
2304         (assertClean):
2305         (TEST):
2306         (allocateAndDeallocate):
2307
2308 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
2309
2310         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
2311         https://bugs.webkit.org/show_bug.cgi?id=200074
2312
2313         Reviewed by Michael Catanzaro.
2314
2315         There was a latent issue. PluginTest::indicateTestFailure was
2316         using WTF::sleep without linking WTF.
2317
2318         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2319         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
2320
2321 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
2322
2323         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
2324         https://bugs.webkit.org/show_bug.cgi?id=200073
2325
2326         Reviewed by Michael Catanzaro.
2327
2328         * TestWebKitAPI/PlatformGTK.cmake:
2329         * TestWebKitAPI/PlatformWPE.cmake:
2330         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
2331
2332 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2333
2334         [webkitperl] runCommand doesn't work in Windows Perl
2335         https://bugs.webkit.org/show_bug.cgi?id=199900
2336
2337         Reviewed by Don Olmstead.
2338
2339         runCommand was always failing implicit fork by using 'open' with
2340         '-|' in Windows Perl. Explicitly specify the command to 'open' not
2341         to do the implicit fork.
2342
2343         There is one more difference between Windows and Unix. 'open'
2344         successes on Windows even for non existent command while it fails
2345         on Unix. So, return the same error code on Unix as well as
2346         Windows.
2347
2348         * Scripts/VCSUtils.pm: Specified the command to 'open'.
2349         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
2350         command is not available on Windows. Use Perl ($^X) instead.
2351
2352 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
2353
2354         Allow Clients to Add Fields to the AutoFillContext Dictionary.
2355         https://bugs.webkit.org/show_bug.cgi?id=199326
2356         rdar://problem/42816957
2357
2358         Reviewed by Wenson Hsieh.
2359
2360         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2361         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
2362         is being properly populated with additional context dictionary.
2363
2364         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2365         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2366         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
2367         which will populate the additional autofill context dictionary.
2368
2369         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
2370         populates the additional autofill context dictionary.
2371
2372         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
2373         context dictionary.
2374
2375         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
2376         input field requires strong password work.
2377
2378         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
2379         input field requires strong password work.
2380
2381         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
2382         password work.
2383
2384 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
2385
2386         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2387         https://bugs.webkit.org/show_bug.cgi?id=199489
2388
2389         Reviewed by Aakash Jain.
2390
2391         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2392         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
2393         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
2394         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2395         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
2396         (runTest): Record test binary failure
2397         (reportTestFailures): Report test binary failure
2398         (runJSCStressTests):
2399         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
2400         (JscOnlyPort.build_jsc_command):
2401         (JscOnlyPort):
2402         (JscOnlyPort.run_javascriptcore_tests_command):
2403         * Scripts/webkitpy/common/config/ports_unittest.py:
2404         (DeprecatedPortTest.test_jsconly_port):
2405
2406 2019-07-24  Zalan Bujtas  <zalan@apple.com>
2407
2408         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
2409         https://bugs.webkit.org/show_bug.cgi?id=200079
2410         <rdar://problem/53474325>
2411
2412         Reviewed by Wenson Hsieh.
2413
2414         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
2415
2416         * WebKitTestRunner/ios/TestControllerIOS.mm:
2417         (WTR::TestController::platformResetPreferencesToConsistentValues):
2418
2419 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2420
2421         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
2422         https://bugs.webkit.org/show_bug.cgi?id=199927
2423
2424         Reviewed by Alex Christensen.
2425
2426         convertAbsolutepathToWebKitPath was failing to convert paths on
2427         Windows Perl due to path separators mismatch.
2428
2429         Renamed convertAbsolutepathToWebKitPath to
2430         convertAbsolutePathToRelativeUnixPath, and changed it to replace
2431         paths to relative Unix paths.
2432
2433         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2434         (convertAbsolutePathToRelativeUnixPath): Added.
2435         (convertAbsolutepathToWebKitPath): Deleted.
2436
2437 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2438
2439         Fix iOS API test after r247759
2440         https://bugs.webkit.org/show_bug.cgi?id=200045
2441
2442         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2443         (TEST):
2444         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
2445         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
2446
2447 2019-07-23  Keith Rollin  <krollin@apple.com>
2448
2449         Remove rest of NavigatorContentUtils support
2450         https://bugs.webkit.org/show_bug.cgi?id=200052
2451         <rdar://problem/53467357>
2452
2453         Reviewed by Alex Christensen.
2454
2455         Bug 196070 removes most of the support for the never-used
2456         NavigatorContentUtils facility. However, there were still a couple of
2457         left-over references after that change. This patch sweeps those up.
2458
2459         * Scripts/webkitperl/FeatureList.pm:
2460
2461 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2462
2463         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2464         https://bugs.webkit.org/show_bug.cgi?id=200045
2465
2466         Reviewed by Mark Lam.
2467
2468         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2469         (TEST):
2470
2471 2019-07-23  Russell Epstein  <repstein@apple.com>
2472
2473         Unreviewed, rolling out r247745.
2474
2475         This broke API test
2476         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
2477         indicated by EWS
2478
2479         Reverted changeset:
2480
2481         "Move javaScriptConfigurationDirectory SPI from
2482         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
2483         runtime switchable"
2484         https://bugs.webkit.org/show_bug.cgi?id=200045
2485         https://trac.webkit.org/changeset/247745
2486
2487 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2488
2489         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
2490         https://bugs.webkit.org/show_bug.cgi?id=200045
2491
2492         Reviewed by Mark Lam.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2495         (TEST):
2496
2497 2019-07-23  Alex Christensen  <achristensen@webkit.org>
2498
2499         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
2500         https://bugs.webkit.org/show_bug.cgi?id=199972
2501
2502         Reviewed by Jer Noble.
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2505         (TEST):
2506
2507 2019-07-23  Alicia Boya García  <aboya@igalia.com>
2508
2509         [WTF] Add DataMutex and MainThreadData wrappers
2510         https://bugs.webkit.org/show_bug.cgi?id=199831
2511
2512         Reviewed by Alex Christensen.
2513
2514         Added a very simple test that checks that DataMutex<T> indeed takes
2515         the lock and indeed holds data.
2516
2517         * TestWebKitAPI/CMakeLists.txt:
2518         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
2519         (TestWebKitAPI::TEST):
2520
2521 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2522
2523         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
2524         https://bugs.webkit.org/show_bug.cgi?id=200021
2525         <rdar://problem/53301325>
2526
2527         Reviewed by Ryosuke Niwa.
2528
2529         Add support for grabbing the child menu items of a context menu item.
2530
2531         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2532         (WTR::getMenuItemChildrenCallback):
2533
2534 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
2535
2536         WebKit should strip away system font names from the pasted content
2537         https://bugs.webkit.org/show_bug.cgi?id=199975
2538         <rdar://problem/53336353>
2539
2540         Reviewed by Darin Adler.
2541
2542         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
2543
2544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2545         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2546         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
2547
2548 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] EWS fails to parse multi-line full_results.json
2551         https://bugs.webkit.org/show_bug.cgi?id=199992
2552
2553         Reviewed by Alexey Proskuryakov.
2554
2555         * BuildSlaveSupport/ews-build/layout_test_failures.py:
2556         (LayoutTestFailures.results_from_string): Concatenate content into single line.
2557         * BuildSlaveSupport/ews-build/steps_unittest.py:
2558         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
2559
2560 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2561
2562         resultsdbpy: Handle case where the previous commit doesn't have the changelog
2563         https://bugs.webkit.org/show_bug.cgi?id=200015
2564
2565         Reviewed by Aakash Jain.
2566
2567         * resultsdbpy/resultsdbpy/model/repository.py:
2568         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
2569
2570 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2571
2572         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
2573         https://bugs.webkit.org/show_bug.cgi?id=200013
2574         <rdar://problem/52526901>
2575
2576         Reviewed by Simon Fraser.
2577
2578         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
2579
2580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2581         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
2582         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
2583         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
2584         * TestWebKitAPI/ios/UIKitSPI.h:
2585
2586 2019-07-22  Jer Noble  <jer.noble@apple.com>
2587
2588         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
2589         https://bugs.webkit.org/show_bug.cgi?id=199971
2590         <rdar://problem/51951218>
2591
2592         Reviewed by Alex Christensen.
2593
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
2596         (TestWebKitAPI::TEST):
2597
2598 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-build] Add an EWS to run services tests
2601         https://bugs.webkit.org/show_bug.cgi?id=199994
2602
2603         Reviewed by Jonathan Bedard.
2604
2605         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
2606         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
2607         * BuildSlaveSupport/ews-build/steps.py:
2608         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
2609         (RunEWSUnitTests): Build step to run EWS unit-tests.
2610         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
2611         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2612         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
2613
2614 2019-07-22  Youenn Fablet  <youenn@apple.com>
2615
2616         Disable MediaRecorder for legacy WebKit
2617         https://bugs.webkit.org/show_bug.cgi?id=200001
2618         <rdar://problem/53400030>
2619
2620         Reviewed by Eric Carlson.
2621
2622         Enable MediaRecorder for testing purposes.
2623
2624         * DumpRenderTree/mac/DumpRenderTree.mm:
2625         (createWebViewAndOffscreenWindow):
2626
2627 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
2628
2629         results.webkit.org: Timeline header is too small
2630         https://bugs.webkit.org/show_bug.cgi?id=199955
2631
2632         Reviewed by Aakash Jain.
2633
2634         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
2635         (.timeline>.header): Make timeline header larder to fit configuration names.
2636
2637 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2638
2639         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
2640         https://bugs.webkit.org/show_bug.cgi?id=199954
2641
2642         Reviewed by Geoff Garen.
2643
2644         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2645         (TEST):
2646
2647 2019-07-22  Alex Christensen  <achristensen@webkit.org>
2648
2649         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
2650         https://bugs.webkit.org/show_bug.cgi?id=199917
2651
2652         Reviewed by Sam Weinig.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2655         (TEST):
2656
2657 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
2658
2659         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
2660         https://bugs.webkit.org/show_bug.cgi?id=199980
2661
2662         Reviewed by Jonathan Bedard.
2663
2664         * BuildSlaveSupport/ews-build/steps.py:
2665         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
2666         * BuildSlaveSupport/ews-build/steps_unittest.py:
2667         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
2668         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
2669
2670 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2671
2672         [webkitpy] Add an unit test for setting up the driver environment without starting it.
2673         https://bugs.webkit.org/show_bug.cgi?id=199945
2674
2675         Reviewed by Michael Catanzaro.
2676
2677         This adds an unit test for the change implemented in r247663.
2678
2679         * Scripts/webkitpy/port/driver_unittest.py:
2680         (DriverTest.test_setup_environ_base_vars):
2681         (DriverTest):
2682         (DriverTest.test_setup_environ_without_starting_driver):
2683
2684 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2685
2686         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
2687         https://bugs.webkit.org/show_bug.cgi?id=199993
2688         <rdar://problem/49523528>
2689
2690         Reviewed by Beth Dakin.
2691
2692         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/cocoa/TestWKWebView.h:
2697
2698 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
2699
2700         Add accessibilityInsertText for text insertion in edit fields.
2701         https://bugs.webkit.org/show_bug.cgi?id=199973
2702
2703         Reviewed by Chris Fleizach.
2704
2705         Renamed accessibilityInsertText to _accessibilityInsertText.
2706
2707         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2708         (AccessibilityUIElement::insertText):
2709         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2710         (AccessibilityUIElement::insertText):
2711         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2712         (WTR::AccessibilityUIElement::insertText):
2713         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2714         (WTR::AccessibilityUIElement::insertText):
2715
2716 2019-07-20  Chris Dumez  <cdumez@apple.com>
2717
2718         Speed up HashTable decoding by reserving capacity and avoiding rehashing
2719         https://bugs.webkit.org/show_bug.cgi?id=199982
2720
2721         Reviewed by Saam Barati.
2722
2723         Add API test coverage.
2724
2725         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2726         (TestWebKitAPI::TEST):
2727
2728 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
2729
2730         Add accessibilityInsertText for text insertion in edit fields.
2731         https://bugs.webkit.org/show_bug.cgi?id=199973
2732
2733         Reviewed by Chris Fleizach.
2734
2735         Glue code to run new LayoutTests.
2736         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2737         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2738         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2739         (WTR::AccessibilityUIElement::insertText):
2740         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2741         (WTR::AccessibilityUIElement::insertText):
2742         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2743         (WTR::AccessibilityUIElement::insertText):
2744         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2745         (WTR::AccessibilityUIElement::insertText):
2746
2747 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2748
2749         Move webkit.css to opensource to support resultsdbpy's frontend
2750         https://bugs.webkit.org/show_bug.cgi?id=199957
2751
2752         Reviewed by Jonathan Bedard.
2753
2754         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
2755         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
2756         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
2757         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
2758
2759 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2760
2761         Move Ref.js to WebKit to support resultsdbpy's frontend
2762         https://bugs.webkit.org/show_bug.cgi?id=199956
2763
2764         Reviewed by Jonathan Bedard.
2765
2766         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2767         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2768         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2769         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2770         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2771         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2772         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2773         * resultsdbpy/resultsdbpy/view/templates/base.html:
2774         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2775         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2776         * resultsdbpy/resultsdbpy/view/templates/search.html:
2777         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2778         * resultsdbpy/resultsdbpy/view/view_routes.py:
2779
2780 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2781
2782         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2783         https://bugs.webkit.org/show_bug.cgi?id=199945
2784
2785         Reviewed by Michael Catanzaro.
2786
2787         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2788         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2789         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2790
2791         * Scripts/webkitpy/port/driver.py:
2792         (Driver._setup_environ_for_driver):
2793         (Driver._create_temporal_directories):
2794         (Driver):
2795         (Driver._start):
2796         (Driver._delete_temporal_directories):
2797         (Driver.stop):
2798         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2799         (main):
2800         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2801         (WebDriverTestRunner.__init__):
2802         * glib/api_test_runner.py:
2803         (TestRunner._setup_testing_environment): Ditto.
2804
2805 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-build] Display pre-existing Layout test failure names in the build summary
2808         https://bugs.webkit.org/show_bug.cgi?id=199941
2809
2810         Reviewed by Jonathan Bedard.
2811
2812         * BuildSlaveSupport/ews-build/steps.py:
2813         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2814
2815 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2816
2817         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2818         https://bugs.webkit.org/show_bug.cgi?id=199738
2819
2820         Reviewed by Michael Catanzaro.
2821
2822         Run the tests with an empty homedir that is created inside the driver tmpdir.
2823         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2824
2825         This is done to ensure that the test results are not affected by the user settings of any library.
2826
2827         * Scripts/webkitpy/port/driver.py:
2828         (Driver._setup_environ_for_driver):
2829         * Scripts/webkitpy/port/driver_unittest.py:
2830         (DriverTest.test_setup_environ_base_vars):
2831         (DriverTest):
2832         (DriverTest.test_create_temporal_home_dir):
2833
2834 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2835
2836         Remove pywebsockets from thirdparty
2837         https://bugs.webkit.org/show_bug.cgi?id=199710
2838
2839         Reviewed by Jonathan Bedard.
2840
2841         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2842         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2843
2844         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2845         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2846         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2847         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2848         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2849         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2850         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2851         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2852         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2853         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2854         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2855         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2856         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2857         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2858         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2859         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2860         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2861         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2862         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2863         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2864         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2865         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2866
2867 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2868
2869         results.webkit.org: Move resultsdbpy to WebKit
2870         https://bugs.webkit.org/show_bug.cgi?id=199837
2871         <rdar://problem/53172130>
2872
2873         Rubber-stamped by Aakash Jain.
2874
2875         Moving the entirety of the resultsdbpy library, which provides utilities to build
2876         a database designed to store, visualize and organize test results, into WebKit.
2877
2878         * Scripts/webkitpy/style/checker.py:
2879         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2880         * resultsdbpy: Added.
2881         * resultsdbpy/MANIFEST.in: Added.
2882         * resultsdbpy/README.md: Added.
2883         * resultsdbpy/resultsdbpy: Added.
2884         * resultsdbpy/resultsdbpy/__init__.py: Added.
2885         * resultsdbpy/resultsdbpy/controller: Added.
2886         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2887         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2888         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2889         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2890         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2891         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2892         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2893         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2894         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2895         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2896         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2897         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2898         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2899         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2900         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2901         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2902         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2903         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2904         * resultsdbpy/resultsdbpy/flask_support: Added.
2905         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2906         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2907         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2908         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2909         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2910         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2911         * resultsdbpy/resultsdbpy/model: Added.
2912         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2913         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2914         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2915         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2916         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2917         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2918         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2919         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2920         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2921         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2922         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2923         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2924         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2925         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2926         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2927         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2928         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2929         * resultsdbpy/resultsdbpy/model/model.py: Added.
2930         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2931         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2932         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2933         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2934         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2935         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2936         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2937         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2938         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2939         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2940         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2941         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2942         * resultsdbpy/resultsdbpy/run-tests: Added.
2943         * resultsdbpy/resultsdbpy/view: Added.
2944         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2945         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2946         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2947         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2948         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2949         * resultsdbpy/resultsdbpy/view/static: Added.
2950         * resultsdbpy/resultsdbpy/view/static/css: Added.
2951         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2952         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2953         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2954         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2955         * resultsdbpy/resultsdbpy/view/static/js: Added.
2956         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2957         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2958         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2959         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2960         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2961         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2962         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2963         * resultsdbpy/resultsdbpy/view/templates: Added.
2964         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2965         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2966         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2967         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2968         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2969         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2970         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2971         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2972         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2973         * resultsdbpy/setup.py: Added.
2974
2975 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2976
2977         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2978         https://bugs.webkit.org/show_bug.cgi?id=199923
2979
2980         Reviewed by Youenn Fablet.
2981
2982         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2983         (TestWebKitAPI::TEST):
2984
2985 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2986
2987         [ews-build] Enable iOS WK2 tester queue on new EWS
2988         https://bugs.webkit.org/show_bug.cgi?id=199867
2989
2990         Reviewed by Jonathan Bedard.
2991
2992         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2993         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2995         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2996
2997 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2998
2999         [ews-build] Add build step to AnalyzeLayoutTestsResults
3000         https://bugs.webkit.org/show_bug.cgi?id=199877
3001
3002         Reviewed by Jonathan Bedard.
3003
3004         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
3005
3006         * BuildSlaveSupport/ews-build/steps.py:
3007         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
3008         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
3009         (AnalyzeLayoutTestsResults.report_failure):
3010         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3011         (AnalyzeLayoutTestsResults.retry_build):
3012         (AnalyzeLayoutTestsResults._results_failed_different_tests):
3013         (AnalyzeLayoutTestsResults._report_flaky_tests):
3014         (AnalyzeLayoutTestsResults.start):
3015         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3016
3017 2019-07-18  Alex Christensen  <achristensen@webkit.org>
3018
3019         Move NetworkCache ownership from NetworkProcess to NetworkSession
3020         https://bugs.webkit.org/show_bug.cgi?id=199817
3021
3022         Reviewed by Geoff Garen.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3025         (TEST):
3026         * TestWebKitAPI/cocoa/TestWKWebView.h:
3027         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3028         (-[WKWebView synchronouslyLoadRequest:]):
3029
3030 2019-07-18  Youenn Fablet  <youenn@apple.com>
3031
3032         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
3033         https://bugs.webkit.org/show_bug.cgi?id=199769
3034         <rdar://problem/49390297>
3035
3036         Reviewed by Myles C. Maxfield.
3037
3038         Add a font containing one extended character not found in system fonts.
3039
3040         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3041         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
3042
3043 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
3044
3045         Unreviewed, Add Olivier Blin as contributor
3046
3047         * Scripts/webkitpy/common/config/contributors.json:
3048
3049 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3050
3051         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
3052         https://bugs.webkit.org/show_bug.cgi?id=199855
3053
3054         Reviewed by Michael Catanzaro.
3055
3056         The webkitpy drivers for GTK and WPE use their own versions for setting
3057         up the environment and starting/stopping the drivers.
3058         This refactors those drivers to use the base class driver functions.
3059         As a benefit we get some fixes like support for setting the profiler
3060         environment variables, and a simpler code.
3061
3062         * Scripts/webkitpy/port/driver.py:
3063         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
3064         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
3065         * Scripts/webkitpy/port/headlessdriver.py:
3066         (HeadlessDriver._setup_environ_for_test):
3067         * Scripts/webkitpy/port/waylanddriver.py:
3068         (WaylandDriver._setup_environ_for_test):
3069         * Scripts/webkitpy/port/westondriver.py:
3070         (WestonDriver._setup_environ_for_test):
3071         (WestonDriver.stop):
3072         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
3073         (WestonDriverTest.make_driver):
3074         * Scripts/webkitpy/port/xorgdriver.py:
3075         (XorgDriver._setup_environ_for_test):
3076         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
3077         (XvfbDriver._setup_environ_for_test):
3078         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
3079         (XvfbDriverTest.make_driver):
3080         (XvfbDriverTest.test_start):
3081         (XvfbDriverTest.test_start_arbitrary_worker_number):
3082         * Scripts/webkitpy/w3c/wpt_runner.py:
3083         (main): Start the driver before trying to get its environment to define all the environment variables.
3084         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3085         (WebDriverTestRunner.__init__): Ditto.
3086         * glib/api_test_runner.py:
3087         (TestRunner._setup_testing_environment): Ditto.
3088
3089 2019-07-17  Antoine Quint  <graouts@apple.com>
3090
3091         Disable Pointer Events prior to watchOS 6
3092         https://bugs.webkit.org/show_bug.cgi?id=199890
3093         <rdar://problem/53206113>
3094
3095         Reviewed by Dean Jackson.
3096
3097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3098
3099 2019-07-17  Christopher Reid  <chris.reid@sony.com>
3100
3101         Bytecode cache should use FileSystem
3102         https://bugs.webkit.org/show_bug.cgi?id=199759
3103
3104         Reviewed by Yusuke Suzuki.
3105
3106         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3107
3108 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
3109
3110         check-webkit-style: Add limited Python3 support
3111         https://bugs.webkit.org/show_bug.cgi?id=199870
3112
3113         Rubber-stamped by Aakash Jain.
3114
3115         Since new services will be added in the near future which are Python 3, we
3116         need to support Python 3 style checks. For now, assume all Python files are
3117         Python 2 unless otherwise specified.
3118
3119         * Scripts/webkitpy/style/checker.py:
3120         (_all_categories): Add pycodestyle to valid categories for testing.
3121         (CheckerDispatcher._create_checker): Check that the provided Python file is in
3122         one of the declared Python 3 directories.
3123         * Scripts/webkitpy/style/checkers/python.py:
3124         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
3125         instead of pep8.
3126         (Python3Checker.__init__):
3127         (Python3Checker.check):
3128         * Scripts/webkitpy/thirdparty/__init__.py:
3129         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
3130         (AutoinstallImportHook._install_pycodestyle):
3131
3132 2019-07-17  Sam Weinig  <weinig@apple.com>
3133
3134         Add StringBuilder member function which allows makeString() style variadic argument construction
3135         https://bugs.webkit.org/show_bug.cgi?id=198997
3136
3137         Reviewed by Darin Adler.
3138
3139         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3140         Add basic test showing that StringBuilder::flexibleAppend can be used to
3141         append one or more string adaptable types.
3142
3143         * TestWebKitAPI/CMakeLists.txt:
3144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3145         Add WTFStringUtilities.cpp
3146
3147         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3148         Add basic test showing that StringBuilder::flexibleAppend can be used to
3149         append one or more string adaptable types.
3150
3151         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3152         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
3153         * TestWebKitAPI/WTFStringUtilities.h:
3154         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
3155         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
3156
3157 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         Remove the file superfluously added in r247535.
3160
3161         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
3162         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
3163
3164 2019-07-17  Alex Christensen  <achristensen@webkit.org>
3165
3166         Add a runtime-disabled dialog element skeleton
3167         https://bugs.webkit.org/show_bug.cgi?id=199839
3168
3169         Reviewed by Ryosuke Niwa.
3170
3171         * DumpRenderTree/mac/DumpRenderTree.mm:
3172         (resetWebPreferencesToConsistentValues):
3173         * WebKitTestRunner/TestController.cpp:
3174         (WTR::TestController::resetPreferencesToConsistentValues):
3175         Enable the dialog element for layout tests.
3176
3177 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
3178
3179         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
3180         https://bugs.webkit.org/show_bug.cgi?id=199851
3181
3182         Reviewed by Wenson Hsieh.
3183
3184         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
3185         this code is getting directly triggered from UIKeyboard's code.
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3188         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
3189         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
3190         * TestWebKitAPI/ios/UIKitSPI.h:
3191
3192 2019-07-17  Commit Queue  <commit-queue@webkit.org>
3193
3194         Unreviewed, rolling out r247505.
3195         https://bugs.webkit.org/show_bug.cgi?id=199871
3196
3197         "Caused failed ASSERT in stress test" (Requested by creid on
3198         #webkit).
3199
3200         Reverted changeset:
3201
3202         "Bytecode cache should use FileSystem"
3203         https://bugs.webkit.org/show_bug.cgi?id=199759
3204         https://trac.webkit.org/changeset/247505
3205
3206 2019-07-17  Russell Epstein  <russell_e@apple.com>
3207
3208         Adding self to contributors.json
3209
3210         Unreviewed.
3211
3212         * Scripts/webkitpy/common/config/contributors.json:
3213
3214 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews-build] Parse full_results.json for layout-tests
3217         https://bugs.webkit.org/show_bug.cgi?id=199804
3218
3219         Reviewed by Jonathan Bedard.
3220
3221         * BuildSlaveSupport/ews-build/steps.py:
3222         (RunWebKitTests.start): Monitor json output.
3223         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
3224         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
3225         by the patch or are pre-existing.
3226         (ReRunWebKitTests.commandComplete): Ditto.
3227         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
3228         * BuildSlaveSupport/ews-build/steps_unittest.py:
3229         (BuildStepMixinAdditions.getProperty): Added.
3230         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
3231         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
3232
3233 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3234
3235         Unreviewed, rolling out r247512.
3236
3237         Broke API test runners
3238
3239         Reverted changeset:
3240
3241         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
3242         for setting up the environment and start the drivers."
3243         https://bugs.webkit.org/show_bug.cgi?id=199855
3244         https://trac.webkit.org/changeset/247512
3245
3246 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3247
3248         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
3249         https://bugs.webkit.org/show_bug.cgi?id=199855
3250
3251         Reviewed by Carlos Garcia Campos.
3252
3253         The webkitpy drivers for GTK and WPE use their own versions for setting
3254         up the environment and starting/stopping the drivers.
3255         This refactors those drivers to use the base class driver functions.
3256         As a benefit we get some fixes like support for setting the profiler
3257         environment variables, and a simpler code.
3258
3259         * Scripts/webkitpy/port/driver.py:
3260         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
3261         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
3262         * Scripts/webkitpy/port/headlessdriver.py:
3263         (HeadlessDriver._setup_environ_for_test):
3264         * Scripts/webkitpy/port/waylanddriver.py:
3265         (WaylandDriver._setup_environ_for_test):
3266         * Scripts/webkitpy/port/westondriver.py:
3267         (WestonDriver._setup_environ_for_test):
3268         (WestonDriver.stop):
3269         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
3270         (WestonDriverTest.make_driver):
3271         * Scripts/webkitpy/port/xorgdriver.py:
3272         (XorgDriver._setup_environ_for_test):
3273         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
3274         (XvfbDriver._setup_environ_for_test):
3275         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
3276         (XvfbDriverTest.make_driver):
3277         (XvfbDriverTest.test_start):
3278         (XvfbDriverTest.test_start_arbitrary_worker_number):
3279
3280 2019-07-16  Christopher Reid  <chris.reid@sony.com>
3281
3282         Bytecode cache should use FileSystem
3283         https://bugs.webkit.org/show_bug.cgi?id=199759
3284
3285         Reviewed by Yusuke Suzuki.
3286
3287         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3288
3289 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
3290
3291         svn-create-patch duplicates diffs when adding directories
3292         https://bugs.webkit.org/show_bug.cgi?id=199842
3293
3294         Reviewed by Dewei Zhu.
3295
3296         * Scripts/svn-create-patch:
3297         (findKind): Add function which returns what 'kind' of file the provided path is.
3298         (generateFileList): If the path is a directory and being added, don't add it.
3299         Instead, rely on the fact that its children will be added.
3300
3301 2019-07-16  Tim Horton  <timothy_horton@apple.com>
3302
3303         NSTextFinder holes don't scroll with the page
3304         https://bugs.webkit.org/show_bug.cgi?id=199815
3305         <rdar://problem/52280514>
3306
3307         Reviewed by Simon Fraser.
3308
3309         * MiniBrowser/mac/WK2BrowserWindowController.m:
3310         (-[MiniBrowserNSTextFinder performAction:]):
3311         (-[WK2BrowserWindowController awakeFromNib]):
3312         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
3313         -performAction: so that we can intercept the close action and
3314         hide our own find UI, since there is no delegate for that action yet.
3315
3316         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
3317         (TEST):
3318
3319 2019-07-15  Keith Miller  <keith_miller@apple.com>
3320
3321         JSGlobalObject type macros should support feature flags and WeakRef should have one
3322         https://bugs.webkit.org/show_bug.cgi?id=199601
3323
3324         Reviewed by Mark Lam.
3325
3326         JSC options need to be set before the window is created for the test.
3327
3328         * DumpRenderTree/mac/DumpRenderTree.mm:
3329         (resetWebViewToConsistentStateBeforeTesting):
3330         * DumpRenderTree/win/DumpRenderTree.cpp:
3331         (setJSCOptions):
3332         (resetWebViewToConsistentStateBeforeTesting):
3333
3334 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
3335
3336         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
3337         https://bugs.webkit.org/show_bug.cgi?id=193108
3338
3339         Reviewed by Simon Fraser.
3340
3341         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
3342         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
3343         at the wrong scale.
3344
3345         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3346         (takeWindowSnapshot):
3347         (createBitmapContextFromWebView):
3348
3349 2019-07-15  Brady Eidson  <beidson@apple.com>
3350
3351         Make WKURLSchemeTask thread safe.
3352         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
3353
3354         Reviewed by Alex Christensen.
3355
3356         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3357
3358 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
3359
3360         Unreviewed, a build fix after r247437
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3363         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
3364
3365 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3366
3367         [macOS 10.15] Cannot unbold selected text when the system font is used
3368         https://bugs.webkit.org/show_bug.cgi?id=199788
3369         <rdar://problem/52142570>
3370
3371         Reviewed by Tim Horton.
3372
3373         Add a new API test to verify that bolding and unbolding updates the
3374         shared font manager's selected font.
3375
3376         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3377         (TestWebKitAPI::TEST):
3378
3379 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
3380
3381         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
3382         https://bugs.webkit.org/show_bug.cgi?id=199790
3383         <rdar://problem/52790112>
3384
3385         Reviewed by Brent Fulgham.
3386
3387         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
3388
3389         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3390         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
3391         (configureSOAuthorizationWebView):
3392         (TestWebKitAPI::TEST):
3393         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
3394         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
3395         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3396         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
3397         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
3398
3399 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
3400
3401         window.openDatabase is not writable
3402         https://bugs.webkit.org/show_bug.cgi?id=199737
3403         <rdar://problem/52551332>
3404
3405         Reviewed by Chris Dumez.
3406
3407         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
3408         (TEST):
3409         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
3410
3411 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
3412
3413         [ews-build] Parse and display layout test failures
3414         https://bugs.webkit.org/show_bug.cgi?id=199709
3415
3416         Rubber-stamped by Jonathan Bedard.
3417
3418         * BuildSlaveSupport/ews-build/steps.py:
3419         (RunWebKitTests.start): Initialize log_observer.
3420         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
3421         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
3422         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
3423         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
3424         (RunWebKitTests.getResultSummary): Update build and step summary.
3425         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
3426
3427 2019-07-15  Commit Queue  <commit-queue@webkit.org>
3428
3429         Unreviewed, rolling out r247393.
3430         https://bugs.webkit.org/show_bug.cgi?id=199797
3431
3432         broke mips and arm EWS (Requested by guijemont on #webkit).
3433
3434         Reverted changeset:
3435
3436         "run-javascriptcore-tests won't report test results for
3437         testmasm, testair, testb3, testdfg and test api"
3438         https://bugs.webkit.org/show_bug.cgi?id=199489
3439         https://trac.webkit.org/changeset/247393
3440
3441 2019-07-12  Andy Estes  <aestes@apple.com>
3442
3443         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
3444         https://bugs.webkit.org/show_bug.cgi?id=199768
3445         <rdar://problem/52002206>
3446
3447         Reviewed by Geoffrey Garen.
3448
3449         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3450         (TEST):
3451
3452 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3453
3454         [ews-build] Remove wincairo queue from old EWS and dashboard
3455         https://bugs.webkit.org/show_bug.cgi?id=199776
3456
3457         Reviewed by Don Olmstead.
3458
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3460         * QueueStatusServer/config/queues.py:
3461
3462 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3463
3464         [ews-build] Enable wincairo queue on new EWS
3465         https://bugs.webkit.org/show_bug.cgi?id=199593
3466
3467         Reviewed by Don Olmstead.
3468
3469         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
3470         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
3471         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3472         (StatusBubble): Enable wincairo status-bubble.
3473
3474 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-app] Enable logging for clicking SubmitToEWS button
3477         https://bugs.webkit.org/show_bug.cgi?id=199757
3478
3479         Unreviewed minor infrastructure fix.
3480
3481         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3482         (SubmitToEWS.post): Change logging level from debug to info.
3483
3484 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3485
3486         Enable client certificate authentication unit test
3487         https://bugs.webkit.org/show_bug.cgi?id=199735
3488
3489         Reviewed by Chris Dumez.
3490
3491         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3492         (TEST):
3493         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
3494         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
3495
3496 2019-07-12  Alex Christensen  <achristensen@webkit.org>
3497
3498         Begin unifying TestWebKitAPI build
3499         https://bugs.webkit.org/show_bug.cgi?id=199728
3500
3501         Reviewed by Keith Miller.
3502
3503         * TestWebKitAPI/Configurations/Base.xcconfig:
3504         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
3505         * TestWebKitAPI/Sources.txt: Added.
3506         * TestWebKitAPI/SourcesCocoa.txt: Added.
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508
3509 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
3510
3511         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3512         https://bugs.webkit.org/show_bug.cgi?id=199489
3513         <rdar://problem/47891081>
3514
3515         Reviewed by Aakash Jain.
3516
3517         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3518         (RunJavaScriptCoreTests.countFailures):
3519         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3520         * Scripts/run-javascriptcore-tests:
3521         (runTest):
3522         (reportTestFailures):
3523         (runJSCStressTests):
3524
3525 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
3528         https://bugs.webkit.org/show_bug.cgi?id=199743
3529
3530         Reviewed by Jonathan Bedard.
3531
3532         * BuildSlaveSupport/ews-build/steps.py:
3533         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3534
3535 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3536
3537         Unreviewed follow-up fix to r247364.
3538         [ews-build] Add build step to clean up .git/index.lock file
3539         https://bugs.webkit.org/show_bug.cgi?id=199722
3540
3541         * BuildSlaveSupport/ews-build/steps.py:
3542         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
3543         to be run after this step.
3544
3545 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
3546
3547         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
3548         https://bugs.webkit.org/show_bug.cgi?id=199524
3549         <rdar://problem/52783816>
3550
3551         Reviewed by Saam Barati.
3552
3553         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
3554         But this test has several problems.
3555
3556         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
3557            number is calculated by pageSize / sizeof(T), and this does not account the header
3558            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
3559            is very small, we can have many objects in one IsoPage. As a result, we need a large
3560            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
3561            less than numObjects.
3562
3563         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
3564            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
3565            page. This also makes the intention of this test wrong.
3566
3567         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
3568
3569         We make this test robust while we still keep this test white-box one to test the critical feature
3570         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
3571         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
3572         tier live, and check whether the deallocated memory is reused.
3573
3574         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3575         (TEST):
3576
3577 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
3578
3579         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
3580         https://bugs.webkit.org/show_bug.cgi?id=199625
3581
3582         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
3583         with ENABLE(ACCESSIBILITY) in the code.
3584
3585         Additionally, the TestRunner code generator now honors the
3586         Conditional IDL format.
3587
3588         Reviewed by Konstantin Tokarev.
3589
3590         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3591         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3592         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3593         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3594         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3595         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
3596         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
3597         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3598         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3599         (_generateImplementationFile):
3600
3601 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
3602
3603         [ews-build] Add build step to clean up .git/index.lock file
3604         https://bugs.webkit.org/show_bug.cgi?id=199722
3605
3606         Reviewed by Jonathan Bedard.
3607
3608         * BuildSlaveSupport/ews-build/steps.py:
3609         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
3610         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
3611         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
3612         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3613
3614 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
3615
3616         [iOS 13] Enable WebKit build
3617         https://bugs.webkit.org/show_bug.cgi?id=199481
3618         <rdar://problem/52619048>
3619
3620         Reviewed by Tim Horton.
3621
3622         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
3623
3624 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
3625
3626         Add test expectations and baselines for iOS 13
3627         https://bugs.webkit.org/show_bug.cgi?id=199329
3628
3629         Reviewed by Jonathan Bedard.
3630
3631         * Scripts/webkitpy/port/ios.py:
3632         (IOSPort): Increment current version to 13.
3633         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
3634         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
3635         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
3636         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
3637         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
3638         (IOSSimulatorTest.make_port):
3639         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
3640         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
3641         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
3642         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
3643         (IOSTest.make_port):
3644
3645 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
3646
3647         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
3648         https://bugs.webkit.org/show_bug.cgi?id=199692
3649
3650         Reviewed by Chris Fleizach.
3651
3652         Add support for output of AXDeletion and AXInsertion roles for tests.
3653         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
3654         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
3655
3656         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3657         * gtk/jhbuild.modules:
3658         * wpe/jhbuild.modules:
3659
3660 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
3661
3662         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
3663         https://bugs.webkit.org/show_bug.cgi?id=199707
3664
3665         Reviewed by Aakash Jain.
3666
3667         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
3668
3669 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
3670
3671         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
3672         https://bugs.webkit.org/show_bug.cgi?id=199693
3673         rdar://problem/51930364
3674
3675         Reviewed by Tim Horton.
3676
3677         New API tests that test scrollability with various combinations of content, insets,
3678         input accessory bars etc.
3679
3680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3681         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
3682         (TestWebKitAPI::webViewWithAutofocusedInput):
3683         (TestWebKitAPI::TEST):
3684
3685 2019-07-10  Tim Horton  <timothy_horton@apple.com>
3686
3687         Long pressing on attachments will crash the WebContent process
3688         https://bugs.webkit.org/show_bug.cgi?id=199696
3689         <rdar://problem/52920241>
3690
3691         Reviewed by Dean Jackson.
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3694         (TestWebKitAPI::TEST):
3695         Add a test that previously crashed.
3696
3697 2019-07-10  Dean Jackson  <dino@apple.com>
3698
3699         Support MacCatalyst in run-webkit-app
3700         https://bugs.webkit.org/show_bug.cgi?id=199690
3701
3702         Reviewed by Tim Horton.
3703
3704         Add a --maccatalyst option to run-webkit-app that
3705         can launch MacCatalyst applications with a built WebKit.
3706
3707         * Scripts/webkitdirs.pm:
3708         (argumentsForConfiguration):
3709         (determineXcodeSDK):
3710         (xcodeSDKPlatformName):
3711         (determineConfigurationProductDir):
3712         (determinePortName):
3713         (isCatalystWebKit):
3714         (isAppleCocoaWebKit):
3715         (willUseCatalystSDK):
3716
3717 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3718
3719         [MacOS] Filter VPA info logged to stdout
3720         https://bugs.webkit.org/show_bug.cgi?id=199673
3721
3722         Reviewed by Eric Carlson.
3723
3724         * Scripts/webkitpy/port/mac.py:
3725         (MacPort.logging_patterns_to_strip):
3726
3727 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3728
3729         Unreviewed, rolling out r247286.
3730
3731         Caused TestWTF.WTF.StringOperators to fail on debug bots
3732
3733         Reverted changeset:
3734
3735         "Add StringBuilder member function which allows makeString()
3736         style variadic argument construction"
3737         https://bugs.webkit.org/show_bug.cgi?id=198997
3738         https://trac.webkit.org/changeset/247286
3739
3740 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
3741
3742         [ews-build] Explicitly use perl or python while invoking scripts
3743         https://bugs.webkit.org/show_bug.cgi?id=199669
3744
3745         Reviewed by Jonathan Bedard.
3746
3747         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
3748         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3749
3750 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
3751
3752         Run tests on mips EWS
3753         https://bugs.webkit.org/show_bug.cgi?id=196854
3754
3755         Reviewed by Carlos Garcia Campos.
3756
3757         * Scripts/webkitpy/common/config/ews.json:
3758
3759 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3760
3761         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
3762         https://bugs.webkit.org/show_bug.cgi?id=199579
3763
3764         Reviewed by Carlos Garcia Campos.
3765
3766         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3767         (TestWebKitAPI::TEST):
3768
3769 2019-07-09  Chris Dumez  <cdumez@apple.com>
3770
3771         Fix integer type encoding / decoding in WKRemoteObjectCoder
3772         https://bugs.webkit.org/show_bug.cgi?id=199643
3773         <rdar://problem/52732342>
3774
3775         Reviewed by Anders Carlsson.
3776
3777         Update API test coverage.
3778
3779         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3780         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3781         (TEST):
3782         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3783         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3784         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3785         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3786         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3787
3788 2019-07-09  Sam Weinig  <weinig@apple.com>
3789
3790         Add StringBuilder member function which allows makeString() style variadic argument construction
3791         https://bugs.webkit.org/show_bug.cgi?id=198997
3792
3793         Reviewed by Darin Adler.
3794
3795         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3796         Add basic test showing that StringBuilder::flexibleAppend can be used to
3797         append one or more string adaptable types.
3798
3799 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3800
3801         Only allow fetching and removing session credentials from WebsiteDataStore
3802         https://bugs.webkit.org/show_bug.cgi?id=199385
3803         <rdar://problem/52622080>
3804
3805         Reviewed by Alex Christensen.
3806
3807         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3808         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3809         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3810
3811         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3812         (TEST):
3813         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3814         (TestWebKitAPI::TEST):
3815
3816 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3817
3818         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3819         https://bugs.webkit.org/show_bug.cgi?id=199628
3820
3821         Reviewed by Brady Eidson.
3822
3823         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3824         (TestWebKitAPI::TEST_F):
3825
3826 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3827
3828         Remove invalid assertion in URLParser::domainToASCII
3829         https://bugs.webkit.org/show_bug.cgi?id=199624
3830
3831         Reviewed by Brady Eidson.
3832
3833         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3834         (TestWebKitAPI::TEST_F):
3835
3836 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3837
3838         URLParser should reserialize IPv6 addresses that end with a colon
3839         https://bugs.webkit.org/show_bug.cgi?id=199627
3840
3841         Reviewed by Brady Eidson.
3842
3843         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3844         (TestWebKitAPI::TEST_F):
3845
3846 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3847
3848         [ews-build] Do not run unix commands for windows in PrintConfiguration
3849         https://bugs.webkit.org/show_bug.cgi?id=199605
3850
3851         Reviewed by Jonathan Bedard.
3852
3853         * BuildSlaveSupport/ews-build/steps.py:
3854
3855 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3856
3857         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3858         https://bugs.webkit.org/show_bug.cgi?id=199487
3859
3860         Reviewed by Ross Kirsling.
3861
3862         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3863         failing to open testglobalscope_constructors_file which was
3864         created by using tempfile.mkstemp() because it keeps the file
3865         open. Use tempfile.mkdtemp() to create temporary files in the
3866         temporary directory instead of tempfile.mkstemp().
3867
3868         * Scripts/webkitpy/bindings/main.py:
3869         (BindingsTests.run_tests):
3870         (BindingsTests.main):
3871         (BindingsTests.close_and_remove): Deleted.
3872
3873 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3874
3875         [ews-build] Add KillOldProcesses step before running API or Layout tests
3876         https://bugs.webkit.org/show_bug.cgi?id=199592
3877
3878         Reviewed by Jonathan Bedard.
3879
3880         * BuildSlaveSupport/ews-build/factories.py:
3881
3882 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3883
3884         test-webkitpy: Explicitly use Python 2.7 lldb library
3885         https://bugs.webkit.org/show_bug.cgi?id=199578
3886         <rdar://problem/51853557>
3887
3888         Reviewed by Aakash Jain.
3889
3890         * Scripts/webkitpy/common/system/systemhost.py:
3891         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3892         * Scripts/webkitpy/test/main.py:
3893         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3894
3895 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3896
3897         Add test expectations and baselines for Catalina
3898         https://bugs.webkit.org/show_bug.cgi?id=199328
3899
3900         Reviewed by Jonathan Bedard.
3901
3902         * Scripts/webkitpy/port/mac.py:
3903         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3904
3905 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3906
3907         Implement MappedFileData for Windows
3908         https://bugs.webkit.org/show_bug.cgi?id=198269
3909
3910         Reviewed by Darin Adler.
3911
3912         * TestWebKitAPI/PlatformWin.cmake:
3913
3914 2019-07-08  Charlie Turner  <cturner@igalia.com>
3915
3916         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3917         https://bugs.webkit.org/show_bug.cgi?id=197558
3918
3919         Reviewed by Xabier Rodriguez-Calvar.
3920
3921         On shutdown we can easily deadlock the web process if we don't
3922         ensure all network operations are completed before comitting state
3923         changes. In HLS, make sure the network operations are cancelled,
3924         and also prevent hlsdemux's retry logic from scuppering our
3925         efforts.
3926
3927         * gstreamer/jhbuild.modules: Include the patch.
3928         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3929
3930 2019-07-08  Antoine Quint  <graouts@apple.com>
3931
3932         [Pointer Events] Enable only on the most recent version of the supported iOS family
3933         https://bugs.webkit.org/show_bug.cgi?id=199562
3934         <rdar://problem/52766511>
3935
3936         Reviewed by Dean Jackson.
3937
3938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3939
3940 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3941
3942         Long hang when loading a cnn.com page on iOS
3943         https://bugs.webkit.org/show_bug.cgi?id=199556
3944
3945         Reviewed by Zalan Bujtas.
3946
3947         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3948         to load a test page of your choice.
3949
3950         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3951         (-[WebViewController viewDidLoad]):
3952
3953 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3954
3955         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3956         https://bugs.webkit.org/show_bug.cgi?id=199503
3957
3958         Reviewed by Wenson Hsieh.
3959
3960         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3961         _requestActivatedElementAtPosition
3962
3963         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3964         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3965         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3966         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3967         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3968         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3969         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3970         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3971         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3972         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3973         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3974         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3975
3976 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3977
3978         Unreviewed, rolling out r247115.
3979
3980         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3981
3982         Reverted changeset:
3983
3984         "[WHLSL] Standard library is too big to directly include in
3985         WebCore"
3986         https://bugs.webkit.org/show_bug.cgi?id=198186
3987         https://trac.webkit.org/changeset/247115
3988
3989 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3990
3991         Unreviewed, rolling out r247123.
3992
3993         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3994         fail.
3995
3996         Reverted changeset:
3997
3998         "Only allow fetching and removing session credentials from
3999         WebsiteDataStore"
4000         https://bugs.webkit.org/show_bug.cgi?id=199385
4001         https://trac.webkit.org/changeset/247123
4002
4003 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
4004
4005         Touching media controls sometimes shows software keyboard
4006         https://bugs.webkit.org/show_bug.cgi?id=199490
4007         <rdar://problem/52076270>
4008
4009         Reviewed by Eric Carlson.
4010
4011         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
4012         ChangeLog entries for more detail.
4013
4014         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4015         (WTR::UIScriptController::hasInputSession const):
4016         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4017         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4018         (WTR::UIScriptController::hasInputSession const):
4019         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4020         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4021         (WTR::UIScriptController::hasInputSession const):
4022
4023 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
4026         https://bugs.webkit.org/show_bug.cgi?id=199458
4027
4028         Reviewed by Michael Catanzaro.
4029
4030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4031         * QueueStatusServer/config/queues.py:
4032
4033 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4034
4035         [GTK] Fix browserperfdash script after r239522
4036         https://bugs.webkit.org/show_bug.cgi?id=199496
4037
4038         Reviewed by Michael Catanzaro.
4039
4040         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
4041         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
4042
4043 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4044
4045         [webkitpy] test-webkitpy is broken on Linux since r246662
4046         https://bugs.webkit.org/show_bug.cgi?id=199493
4047
4048         Reviewed by Michael Catanzaro.
4049
4050         * Scripts/webkitpy/test/main.py:
4051         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
4052
4053 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4054
4055         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
4056         https://bugs.webkit.org/show_bug.cgi?id=199406
4057
4058         Reviewed by Michael Catanzaro.
4059
4060         Install the Woff2 libraries and headers from the system package
4061         and stop building them on the JHBuild.
4062
4063         * gtk/install-dependencies:
4064         * gtk/jhbuild.modules:
4065         * wpe/install-dependencies:
4066         * wpe/jhbuild.modules:
4067
4068 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4069
4070         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
4071         https://bugs.webkit.org/show_bug.cgi?id=199449
4072
4073         Reviewed by Michael Catanzaro.
4074
4075         * Scripts/webkitdirs.pm:
4076         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
4077
4078 2019-07-01  Philippe Normand  <pnormand@igalia.com>
4079
4080         Unreviewed, GTK a11y tests fix after r247071
4081
4082         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4083         (WTR::AccessibilityUIElement::popupValue const):
4084
4085 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
4086
4087         [ews-build] Enable WPE and GTK queues on new EWS
4088         https://bugs.webkit.org/show_bug.cgi?id=199234
4089
4090         Reviewed by Jonathan Bedard.
4091
4092         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
4093         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
4094         * BuildSlaveSupport/ews-build/steps.py:
4095         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
4096         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4097         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4098         (StatusBubble): Enable gtk and wpe status-bubbles.
4099
4100 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
4101
4102         Only allow fetching and removing session credentials from WebsiteDataStore
4103         https://bugs.webkit.org/show_bug.cgi?id=199385
4104
4105         Reviewed by Alex Christensen.
4106
4107         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
4108         (TestWebKitAPI::TEST):
4109
4110 2019-07-03  Tim Horton  <timothy_horton@apple.com>
4111
4112         UI process exception when dragging an <attachment> with no content type
4113         https://bugs.webkit.org/show_bug.cgi?id=199480
4114         <rdar://problem/44351353>
4115
4116         Reviewed by Wenson Hsieh.
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4119         (TestWebKitAPI::TEST):
4120         Add a test; before the change, it crashes.
4121
4122 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
4123
4124         [Catalina] Enable WebKit build
4125         https://bugs.webkit.org/show_bug.cgi?id=199209
4126
4127         Reviewed by Darin Adler.
4128
4129         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
4130
4131 2019-07-03  Sam Weinig  <weinig@apple.com>
4132
4133         Adopt simple structured bindings in more places
4134         https://bugs.webkit.org/show_bug.cgi?id=199247
4135
4136         Reviewed by Alex Christensen.
4137
4138         Replaces simple uses of std::tie() with structured bindings. Does not touch
4139         uses of std::tie() that are not initial declarations, use std::ignore or in
4140         case where the binding is captured by a lambda, as structured bindings don't
4141         work for those cases yet.
4142
4143         * TestWebKitAPI/ios/PreferredContentMode.mm:
4144         (TestWebKitAPI::TEST):
4145
4146 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
4147
4148         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
4149
4150         * BuildSlaveSupport/ews-build/steps.py:
4151         (PrintConfiguration.run):
4152
4153 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
4154
4155         [ews-build] Add build steps to Install Wpe and Gtk dependencies
4156         https://bugs.webkit.org/show_bug.cgi?id=199408
4157
4158         Reviewed by Michael Catanzaro.
4159
4160         * BuildSlaveSupport/ews-build/steps.py:
4161         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
4162         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
4163         (InstallWpeDependencies): Ditto for WPE.
4164         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4165
4166 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
4167
4168         [ews-build] Allow skipping uploading built product for few builders
4169         https://bugs.webkit.org/show_bug.cgi?id=199422
4170
4171         Reviewed by Michael Catanzaro.
4172
4173         * BuildSlaveSupport/ews-build/steps.py:
4174         (CompileWebKit.__init__): Added optional skipUpload parameter.
4175         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
4176
4177 2019-07-02  Tim Horton  <timothy_horton@apple.com>
4178
4179         REGRESSION (r243240): Unable to swipe back in Safari
4180         https://bugs.webkit.org/show_bug.cgi?id=199394
4181         <rdar://problem/51137447>
4182
4183         Reviewed by Wenson Hsieh.
4184
4185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4186         Make sure that we actually end up with swipe gesture recognizers installed
4187         after process swap and crash.
4188
4189 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
4190
4191         Enhance support of aria-haspopup per ARIA 1.1 specification.
4192         https://bugs.webkit.org/show_bug.cgi?id=199216
4193         <rdar://problem/46221342>
4194
4195         Reviewed by Chris Fleizach.
4196
4197         * DumpRenderTree/AccessibilityUIElement.cpp:
4198         (getPopupValueCallback):
4199         (AccessibilityUIElement::getJSClass):
4200         * DumpRenderTree/AccessibilityUIElement.h:
4201         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4202         (AccessibilityUIElement::popupValue const):
4203         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4204         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4205         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4206         (WTR::AccessibilityUIElement::popupValue const):
4207         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4208         (WTR::AccessibilityUIElement::popupValue const):
4209
4210 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
4211
4212         [ews-build] Do not print worker environment variables in each build step [part 2]
4213         https://bugs.webkit.org/show_bug.cgi?id=199405
4214
4215         Reviewed by Jonathan Bedard.
4216
4217         * BuildSlaveSupport/ews-build/steps.py:
4218         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
4219         (CleanWorkingDirectory.__init__): Ditto.
4220         (RunBindingsTests.__init__): Ditto.
4221         (RunWebKitPerlTests.__init__): Ditto.
4222         (RunWebKitPyTests.__init__): Ditto.
4223         (CompileWebKit.__init__): Ditto.
4224         (ArchiveTestResults.__init__): Ditto.
4225         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
4226
4227 2019-07-02  Jer Noble  <jer.noble@apple.com>
4228
4229         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
4230         https://bugs.webkit.org/show_bug.cgi?id=199381
4231         <rdar://problem/52483103>
4232
4233         Reviewed by Eric Carlson.
4234
4235         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
4236
4237 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
4238
4239         [ews-build] Update bot configuration for WPE and GTK
4240         https://bugs.webkit.org/show_bug.cgi?id=199238
4241
4242         Reviewed by Michael Catanzaro.
4243
4244         * BuildSlaveSupport/ews-build/config.json:
4245
4246 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
4247
4248         [ews-build] Make PrintConfiguration platform aware
4249         https://bugs.webkit.org/show_bug.cgi?id=196657
4250
4251         Reviewed by Lucas Forschler.
4252
4253         * BuildSlaveSupport/ews-build/steps.py:
4254         (PrintConfiguration): Specified platform-specific command lists.
4255         (PrintConfiguration.run): Override run method and specify platform specific commands.
4256         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4257
4258 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
4259
4260         [Wasm-References] Disable references by default
4261         https://bugs.webkit.org/show_bug.cgi?id=199390
4262
4263         Reviewed by Saam Barati.
4264
4265         * Scripts/run-jsc-stress-tests:
4266
4267 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
4268
4269         Unreviewed. Revert r246965 to fix build break
4270         since r247019 reverted its related changes.
4271
4272         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4273         (WTR::AccessibilityUIElement::popupValue const): Deleted.
4274
4275 2019-07-01  Alex Christensen  <achristensen@webkit.org>
4276
4277         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
4278         https://bugs.webkit.org/show_bug.cgi?id=199371
4279         <rdar://problem/52352905>
4280
4281         Reviewed by Tim Horton.
4282
4283         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
4284         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
4285         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
4286         (-[NavigationActionSPIDelegate spiCalled]):
4287         (TEST):
4288
4289 2019-07-01  Alex Christensen  <achristensen@webkit.org>
4290
4291         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
4292         https://bugs.webkit.org/show_bug.cgi?id=199296
4293         <rdar://problem/51041960>
4294
4295         Reviewed by Darin Adler.
4296
4297         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4298         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
4299
4300 2019-07-01  Truitt Savell  <tsavell@apple.com>
4301
4302         Unreviewed, rolling out r246958.
4303
4304         Broke inspector/dom/getAccessibilityPropertiesForNode.html
4305
4306         Reverted changeset:
4307
4308         "Enhance support of aria-haspopup per ARIA 1.1 specification."
4309         https://bugs.webkit.org/show_bug.cgi?id=199216
4310         https://trac.webkit.org/changeset/246958
4311
4312 2019-07-01  Philippe Normand  <pnormand@igalia.com>
4313
4314         Unreviewed, GTK a11y tests fix after r246958
4315
4316         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4317         (WTR::AccessibilityUIElement::popupValue const):
4318
4319 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
4320
4321         Enhance support of aria-haspopup per ARIA 1.1 specification.
4322         https://bugs.webkit.org/show_bug.cgi?id=199216
4323         <rdar://problem/46221342>
4324
4325         Reviewed by Chris Fleizach.
4326
4327         * DumpRenderTree/AccessibilityUIElement.cpp:
4328         (getPopupValueCallback):
4329         (AccessibilityUIElement::getJSClass):
4330         * DumpRenderTree/AccessibilityUIElement.h:
4331         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4332         (AccessibilityUIElement::popupValue const):
4333         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4334         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4335         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4336         (WTR::AccessibilityUIElement::popupValue const):
4337         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4338         (WTR::AccessibilityUIElement::popupValue const):
4339
4340 2019-06-28  Robin Morisset  <rmorisset@apple.com>
4341
4342         Adding myself as a reviewer to contributors.json.
4343
4344         Unreviewed.
4345
4346         * Scripts/webkitpy/common/config/contributors.json:
4347
4348 2019-06-28  Jer Noble  <jer.noble@apple.com>
4349
4350         Add new -[WKWebView _closeAllMediaPresentations] SPI
4351         https://bugs.webkit.org/show_bug.cgi?id=199294
4352         <rdar://problem/51965958>
4353
4354         Reviewed by Alex Christensen.
4355
4356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4357         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
4358         (TEST):
4359
4360 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
4361
4362         Add a regression test for change r246901
4363         https://bugs.webkit.org/show_bug.cgi?id=199290
4364
4365         Reviewed by Geoffrey Garen.
4366
4367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4368         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
4369         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4370         (TEST):
4371         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
4372
4373 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
4374
4375         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
4376         https://bugs.webkit.org/show_bug.cgi?id=199317
4377
4378         Reviewed by Michael Catanzaro.
4379
4380         While IconDatabase and all code using it was removed,
4381         ENABLE_ICONDATABASE still exists as build option and C++ macro.
4382
4383         * Scripts/webkitperl/FeatureList.pm:
4384         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4385         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
4386         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
4387
4388 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4389
4390         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
4391         https://bugs.webkit.org/show_bug.cgi?id=199310
4392         <rdar://problem/52292137>
4393
4394         Reviewed by Megan Gardner.
4395
4396         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
4397         _elementDidFocus.
4398
4399         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4400         (TestWebKitAPI::TEST):
4401         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
4402         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
4403         (-[TestInputDelegate setDidStartInputSessionHandler:]):
4404         (-[TestInputDelegate didStartInputSessionHandler]):
4405
4406         Add plumbing for a handler block in TestInputDelegate.
4407
4408         (-[TestInputDelegate setWillStartInputSessionHandler:]):
4409
4410         Drive-by style fixes to add a space between id and < for Objective-C protocols.
4411
4412         (-[TestInputDelegate willStartInputSessionHandler]):
4413         (-[TestInputDelegate _webView:willStartInputSession:]):
4414         (-[TestInputDelegate _webView:didStartInputSession:]):
4415         * TestWebKitAPI/cocoa/TestWKWebView.h:
4416         * TestWebKitAPI/ios/UIKitSPI.h:
4417
4418         Add a declaration for _selectionClipRects.
4419
4420 2019-06-27  Zalan Bujtas  <zalan@apple.com>
4421
4422         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
4423         https://bugs.webkit.org/show_bug.cgi?id=199303
4424         <rdar://problem/51340927>
4425
4426         Reviewed by Tim Horton.
4427
4428         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
4429         (TEST):
4430
4431 2019-06-27  Beth Dakin  <bdakin@apple.com>
4432
4433         Upstream use of MACCATALYST
4434         https://bugs.webkit.org/show_bug.cgi?id=199245
4435         rdar://problem/51687723
4436
4437         Reviewed by Tim Horton.
4438
4439         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
4440         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
4441         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
4442         * MiniBrowser/Configurations/SDKVariant.xcconfig:
4443         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
4444         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
4445         (JavaScriptCoreGenerator):
4446         (WebCoreGenerator):
4447         (WebKitGenerator):
4448         * TestWebKitAPI/Configurations/Base.xcconfig:
4449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4450         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
4451         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4452         * WebEditingTester/Configurations/SDKVariant.xcconfig:
4453         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
4454         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
4455         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
4456
4457 2019-06-27  Saam Barati  <sbarati@apple.com>
4458
4459         Make WEBGPU enabled only on Mojave and later.
4460
4461         Rubber-stamped by Myles C. Maxfield.
4462
4463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4464
4465 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
4466
4467         [ews-build] Do not print worker environment variables in each build step
4468         https://bugs.webkit.org/show_bug.cgi?id=197319
4469
4470         Reviewed by Lucas Forschler.
4471
4472         * BuildSlaveSupport/ews-build/steps.py:
4473         (CheckOutSource.__init__): Disabled logging of environment variables.
4474         (ApplyPatch.__init__): Ditto.
4475         (KillOldProcesses.__init__): Ditto.
4476         (ArchiveBuiltProduct.__init__): Ditto.
4477         (DownloadBuiltProduct.__init__): Ditto.
4478         (ExtractBuiltProduct.__init__): Ditto.
4479         (RunAPITests.__init__): Ditto.
4480         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
4481
4482 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
4483
4484         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
4485         https://bugs.webkit.org/show_bug.cgi?id=199232
4486         <rdar://problem/51718328>
4487
4488         Reviewed by Youenn Fablet.
4489
4490         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4491         (TestWebKitAPI::TEST):
4492         Add a test that utilizes TCPServer as local files always omit referrer.
4493
4494 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
4495
4496         [ews-build] Add configuration and architecture for WPE and GTK builders
4497         https://bugs.webkit.org/show_bug.cgi?id=199249
4498
4499         Reviewed by Jonathan Bedard.
4500
4501         * BuildSlaveSupport/ews-build/config.json:
4502
4503 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
4504
4505         [ews-build] Add check for duplicate workers in config.json
4506         https://bugs.webkit.org/show_bug.cgi?id=199240
4507
4508         Reviewed by Jonathan Bedard.
4509
4510         * BuildSlaveSupport/ews-build/loadConfig.py:
4511         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
4512         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
4513         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
4514
4515 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
4516
4517         [Win] MiniBrowser should make better font choices
4518         https://bugs.webkit.org/show_bug.cgi?id=199244
4519
4520         Reviewed by Brent Fulgham.
4521
4522         * MiniBrowser/win/MainWindow.cpp:
4523         (MainWindow::updateDeviceScaleFactor):
4524         * MiniBrowser/win/MiniBrowserLib.rc:
4525
4526 2019-06-26  Alex Christensen  <achristensen@webkit.org>
4527
4528         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
4529         https://bugs.webkit.org/show_bug.cgi?id=199230
4530         <rdar://51757107>
4531
4532         Reviewed by Andy Estes.
4533
4534         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
4535         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
4536         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
4537         * WebKitTestRunner/TestController.cpp:
4538         (WTR::TestController::generatePageConfiguration):
4539         (WTR::TestController::createWebViewWithOptions):
4540         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
4541         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
4542         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4543         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
4544         * WebKitTestRunner/TestController.h:
4545         * WebKitTestRunner/TestInvocation.cpp:
4546         (WTR::TestInvocation::invoke):
4547         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4548
4549 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
4550
4551         [Win][MiniBrowser] Remove obsolete code after r246814.
4552         https://bugs.webkit.org/show_bug.cgi?id=199233
4553
4554         Reviewed by Fujii Hironori.
4555
4556         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4557         (MiniBrowserWebHost::didFinishLoadForFrame):
4558         (SimpleEventListener::SimpleEventListener): Deleted.
4559         (SimpleEventListener::handleEvent): Deleted.
4560
4561 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
4562
4563         Implement a new SPI to inform clients about AppSSO
4564         https://bugs.webkit.org/show_bug.cgi?id=199085
4565         <rdar://problem/50028246>
4566
4567         Reviewed by Geoffrey Garen.
4568
4569         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4570         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
4571         (-[TestSOAuthorizationNavigationDelegate init]):
4572         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
4573         (TestWebKitAPI::TEST):
4574
4575 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4576
4577         [ews-build] Retry Layout test in case of failures
4578         https://bugs.webkit.org/show_bug.cgi?id=199194
4579
4580         Reviewed by Jonathan Bedard.
4581
4582         * BuildSlaveSupport/ews-build/steps.py:
4583         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
4584         (ReRunWebKitTests): Build step to re-run layout tests.
4585         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
4586         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
4587         (RunWebKitTestsWithoutPatch.evaluateCommand):
4588
4589 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4590
4591         [ews-build] Combine various patchFailed*Tests properties
4592         https://bugs.webkit.org/show_bug.cgi?id=199193
4593
4594         Reviewed by Jonathan Bedard.
4595
4596         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property
4597         can also be used for layout-tests later on.
4598         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
4599
4600 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
4601
4602         [Win] MiniBrowser should default to webkit.org
4603         https://bugs.webkit.org/show_bug.cgi?id=199201
4604
4605         Reviewed by Don Olmstead.
4606
4607         * MiniBrowser/win/BrowserWindow.h:
4608         * MiniBrowser/win/MiniBrowserReplace.h:
4609         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4610         (WebKitBrowserWindow::loadHTMLString): Deleted.
4611         * MiniBrowser/win/WebKitBrowserWindow.h:
4612         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4613         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
4614         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
4615         * MiniBrowser/win/WinMain.cpp:
4616         (wWinMain):
4617
4618 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4619
4620         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
4621         https://bugs.webkit.org/show_bug.cgi?id=199192
4622         <rdar://problem/51554509>
4623
4624         Reviewed by Tim Horton.
4625
4626         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
4627         verify that we gracefully handle web process termination and web view unparenting mid-drag.
4628
4629         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4630         (TestWebKitAPI::TEST):
4631         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4632         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4633         (-[DragAndDropSimulator _resetSimulatedState]):
4634         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
4635         (-[DragAndDropSimulator _advanceProgress]):
4636         (-[DragAndDropSimulator liftPreviews]):
4637         (-[DragAndDropSimulator cancellationPreviews]):
4638         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
4639         (-[DragAndDropSimulator sessionWillBeginBlock]):
4640         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
4641
4642 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
4643
4644         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
4645         https://bugs.webkit.org/show_bug.cgi?id=199178
4646
4647         Reviewed by Jonathan Bedard.
4648
4649         * BuildSlaveSupport/ews-build/steps.py:
4650         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
4651         (ExtractTestResults.__init__): Ditto.
4652         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
4653
4654 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
4655
4656         Add user agent quirk for bankofamerica.com
4657         https://bugs.webkit.org/show_bug.cgi?id=199154
4658
4659         Reviewed by Carlos Garcia Campos.
4660
4661         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4662         (TestWebKitAPI::TEST):
4663
4664 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
4665
4666         Fully rename WebKitGTK+ -> WebKitGTK everywhere
4667         https://bugs.webkit.org/show_bug.cgi?id=199159
4668
4669         Reviewed by Carlos Garcia Campos.
4670
4671         * BuildSlaveSupport/gtk/README:
4672         * MiniBrowser/gtk/BrowserWindow.c:
4673         * MiniBrowser/gtk/main.c:
4674         (aboutURISchemeRequestCallback):
4675         * Scripts/webkitpy/common/config/contributionareas.py:
4676         * Scripts/webkitpy/common/config/contributors.json:
4677         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
4678         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4679         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4680         (testWebViewResources):
4681         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4682         (testWebViewMouseTarget):
4683         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4684         (testWebExtensionGetTitle):
4685         (testDocumentLoadedSignal):
4686         (testWebExtensionFormControlsAssociated):
4687         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4688         (testWebKitSettingsUserAgent):
4689         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4690         (testWebViewRunJavaScript):
4691         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
4692         (main):
4693         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4694         (prepareContextMenuTestView):
4695         (testContextMenuPopulateMenu):
4696         (testContextMenuCustomMenu):
4697         (testContextMenuDisableMenu):
4698         (testContextMenuSubMenu):
4699         (testContextMenuDismissed):
4700         (testContextMenuWebExtensionMenu):
4701         (testContextMenuWebExtensionNode):
4702         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4703         (testInspectorDefault):
4704         (testInspectorManualAttachDetach):
4705         (testInspectorCustomContainerDestroyed):
4706         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4707         (testWebViewPrint):
4708         (testPrintOperationPrint):
4709         (testPrintOperationErrors):
4710         * gtk/install-dependencies:
4711         * gtk/jhbuild.modules:
4712         * gtkdoc/generate-gtkdoc:
4713         * wpe/install-dependencies:
4714
4715 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4716
4717         contributors.json not canonicalized since r243297
4718         https://bugs.webkit.org/show_bug.cgi?id=199161
4719
4720         Reviewed by Alexey Proskuryakov.
4721
4722         Canonicalize it using 'validate-committer-lists --canonicalize'
4723
4724         * Scripts/webkitpy/common/config/contributors.json:
4725
4726 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
4727
4728         webkitpy: Build style should be lower-case
4729         https://bugs.webkit.org/show_bug.cgi?id=199158
4730
4731         Reviewed by Aakash Jain.
4732
4733         * Scripts/webkitpy/test/main.py:
4734         (Tester._run_tests): Make all styles lower-case.
4735
4736 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4737
4738         [ews-build] Remove iOS queue from old EWS and dashboard
4739         https://bugs.webkit.org/show_bug.cgi?id=199150
4740
4741         Reviewed by Jonathan Bedard.
4742
4743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4744         * QueueStatusServer/config/queues.py:
4745
4746 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
4747
4748         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
4749         https://bugs.webkit.org/show_bug.cgi?id=198795
4750
4751         Unreviewed test gardening.
4752
4753         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4754         (TestWebKitAPI::TEST): Disable flaky test.
4755
4756 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4757
4758         [ews-build] Enable iOS-12-Build queue on new EWS
4759         https://bugs.webkit.org/show_bug.cgi?id=199149
4760
4761         Reviewed by Jonathan Bedard.
4762
4763         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
4764         this queue.
4765         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4766         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
4767         will keep the builders to the left and testers to the right.
4768
4769 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4770
4771         [ews-build] Upload test results after running layout-tests
4772         https://bugs.webkit.org/show_bug.cgi?id=199120
4773
4774         Reviewed by Jonathan Bedard.
4775
4776         * BuildSlaveSupport/ews-build/steps.py:
4777         (RunWebKitTests.evaluateCommand):
4778         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4779
4780 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
4781
4782         [ews-build] EWS should provide option to download layout test results zip file
4783         https://bugs.webkit.org/show_bug.cgi?id=199121
4784
4785         Reviewed by Jonathan Bedard.
4786
4787         * BuildSlaveSupport/ews-build/steps.py:
4788         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url.
4789         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
4790
4791 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4792
4793         Add user agent quirk for Google Drive
4794         https://bugs.webkit.org/show_bug.cgi?id=199153
4795
4796         Reviewed by Carlos Garcia Campos.
4797
4798         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4799         (TestWebKitAPI::TEST):
4800
4801 2019-06-22  Zalan Bujtas  <zalan@apple.com>
4802
4803         [LFC] Expand tests coverage (328 new tests -> 2652).
4804
4805         * LayoutReloaded/misc/LFC-passing-tests.txt:
4806
4807 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
4808
4809         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
4810         https://bugs.webkit.org/show_bug.cgi?id=199107
4811         <rdar://problem/43663611>
4812
4813         Reviewed by Chris Fleizach.
4814
4815         iOS implementation for AccessibilityUIElement::hasPopup.
4816         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4817         (WTR::AccessibilityUIElement::hasPopup const):
4818
4819 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
4820
4821         Unreviewed, add myself to CMake watchlist
4822
4823         * Scripts/webkitpy/common/config/watchlist:
4824
4825 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
4826
4827         openDatabase should return an empty object when WebSQL is disabled
4828         https://bugs.webkit.org/show_bug.cgi?id=198805
4829
4830         Reviewed by Geoffrey Garen.
4831
4832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4833         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
4834         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
4835         (TEST):
4836         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
4837
4838 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
4839
4840         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
4841         https://bugs.webkit.org/show_bug.cgi?id=199114
4842         <rdar://problem/51671674>
4843
4844         Reviewed by Youenn Fablet.
4845
4846         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4847         (-[TestSOAuthorizationNavigationDelegate init]):
4848         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4849         (configureSOAuthorizationWebView):
4850         (TestWebKitAPI::TEST):
4851
4852 2019-06-21  Youenn Fablet  <youenn@apple.com>
4853
4854         WebPageProxy should use the right path for sandbox extension
4855         https://bugs.webkit.org/show_bug.cgi?id=198902
4856         <rdar://problem/50772810>
4857
4858         Reviewed by Geoffrey Garen.
4859
4860         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
4861         (TEST):
4862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4863
4864 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4865
4866         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
4867         https://bugs.webkit.org/show_bug.cgi?id=199094
4868
4869         Reviewed by Carlos Garcia Campos.
4870
4871         * MiniBrowser/gtk/BrowserTab.c:
4872         (runColorChooserCallback):
4873         (browserTabConstructed):
4874         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4875         (testWebViewSyncRequestOnMaxConns):
4876         (beforeAll):
4877         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4878         (testWebSocketTLSErrors):
4879         (beforeAll):
4880         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4881         (WebKitTestServer::~WebKitTestServer):
4882         (WebKitTestServer::getWebSocketURIForPath const):
4883         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4884         (WTR::AccessibilityUIElement::rowHeaders const):
4885         (WTR::AccessibilityUIElement::columnHeaders const):
4886         (WTR::AccessibilityUIElement::isAttributeSettable):
4887         (WTR::AccessibilityUIElement::x):
4888         (WTR::AccessibilityUIElement::y):
4889         (WTR::AccessibilityUIElement::width):
4890         (WTR::AccessibilityUIElement::height):
4891         (WTR::AccessibilityUIElement::clickPointX):
4892         (WTR::AccessibilityUIElement::clickPointY):
4893         (WTR::AccessibilityUIElement::intValue const):
4894         (WTR::AccessibilityUIElement::minValue):
4895         (WTR::AccessibilityUIElement::maxValue):
4896         (WTR::stringAtOffset):
4897
4898 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
4899
4900         test-webkitpy is broken on macOS Catalina
4901         https://bugs.webkit.org/show_bug.cgi?id=199078
4902
4903         Reviewed by Jonathan Bedard.
4904
4905         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
4906         to the runner.
4907         (main):
4908         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
4909
4910 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
4911
4912         Change status to "committer" in contributors.json
4913
4914         Unreviewed.
4915
4916         * Scripts/webkitpy/common/config/contributors.json:
4917
4918 2019-06-20  Alex Christensen  <achristensen@webkit.org>
4919
4920         Add unit test for UIContextMenuConfiguration API
4921         https://bugs.webkit.org/show_bug.cgi?id=199043
4922
4923         Reviewed by Wenson Hsieh.
4924
4925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4926         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
4927         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
4928         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
4929         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
4930         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
4931         (TEST):
4932         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
4933         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
4934         (-[TestContextMenuDriver delegate]):
4935         (-[TestContextMenuDriver setDelegate:]):
4936         (-[TestContextMenuDriver view]):
4937         (-[TestContextMenuDriver setView:]):
4938         (-[TestContextMenuDriver allowableMovement]):
4939         (-[TestContextMenuDriver setAllowableMovement:]):
4940         (-[TestContextMenuDriver primaryGestureRecognizer]):
4941         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
4942         (-[TestContextMenuDriver touchDuration]):
4943         (-[TestContextMenuDriver setTouchDuration:]):
4944         (-[TestContextMenuDriver locationInCoordinateSpace:]):
4945         (-[TestContextMenuDriver cancelInteraction]):
4946         (-[TestContextMenuDriver begin:]):
4947         (-[TestContextMenuDriver clickDown]):
4948         (-[TestContextMenuDriver clickUp]):
4949         (-[TestContextMenuDriver end]):
4950         * TestWebKitAPI/ios/UIKitSPI.h:
4951
4952 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4953
4954         [ews-app] Status bubble should not turn orange when any build step is skipped
4955         https://bugs.webkit.org/show_bug.cgi?id=199079
4956
4957         Reviewed by Jonathan Bedard.
4958
4959         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4960
4961 2019-06-20  Alex Christensen  <achristensen@webkit.org>
4962
4963         Fix an internal engineering build after r246605
4964        ​https://bugs.webkit.org/show_bug.cgi?id=197800
4965
4966         * TestWebKitAPI/TCPServer.cpp:
4967
4968 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4969
4970         [ews-build] Triggered builds should use same revision as parent build
4971         https://bugs.webkit.org/show_bug.cgi?id=198289
4972
4973         Reviewed by Jonathan Bedard.
4974
4975         * BuildSlaveSupport/ews-build/steps.py:
4976         (CheckOutSpecificRevision): Build step to checkout specific revision.
4977         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
4978         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
4979         (CheckOutSpecificRevision.start): Run appropriate git command.
4980         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
4981         builds use same revision as parent build.
4982         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4983         * BuildSlaveSupport/ews-build/factories.py:
4984         (Factory.__init__): Added CheckOutSpecificRevision step.
4985
4986 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
4987
4988         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
4989         https://bugs.webkit.org/show_bug.cgi?id=199073
4990
4991         Reviewed by Jonathan Bedard.
4992
4993         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
4994
4995 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
4996
4997         [GTK] Enable navigation swipe layout tests
4998         https://bugs.webkit.org/show_bug.cgi?id=198995
4999
5000         Reviewed by Michael Catanzaro.
5001
5002         Add a way for tests to enable and then control swipe gesture on GTK.
5003
5004         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
5005         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
5006         * WebKitTestRunner/PlatformGTK.cmake:
5007         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
5008         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
5009         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
5010         (WTR::UIScriptController::beginBackSwipe):
5011         (WTR::UIScriptController::completeBackSwipe):
5012
5013 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
5014
5015         [GTK] HTTP layout tests don't run in flatpak
5016         https://bugs.webkit.org/show_bug.cgi?id=199067
5017
5018         Reviewed by Michael Catanzaro.
5019
5020         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
5021         check that path. Instead, add /app/lib/perl to Apache config directly.
5022
5023         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
5024         /.flatpak-info instead.
5025
5026         * Scripts/webkitpy/port/base.py:
5027         (Port._is_flatpak):
5028         (Port._in_flatpak_sandbox):
5029         * flatpak/flatpakutils.py:
5030         (WebkitFlatpak.run_in_sandbox):
5031         (is_sandboxed):
5032
5033 2019-06-18  Darin Adler  <darin@apple.com>
5034
5035         Tidy up the remaining bits of the AtomicString to AtomString rename
5036         https://bugs.webkit.org/show_bug.cgi?id=198990
5037
5038         Reviewed by Michael Catanzaro.
5039
5040         * Scripts/do-webcore-rename: Removed already-done renames.
5041         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
5042
5043 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
5044
5045         [GTK] Remove support for GTK2 plugins
5046         https://bugs.webkit.org/show_bug.cgi?id=199065
5047
5048         Reviewed by Sergio Villar Senin.
5049