Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
4         https://bugs.webkit.org/show_bug.cgi?id=194641
5
6         Reviewed by Geoffrey Garen.
7
8         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
9         so that the test would fail without this fix.
10
11         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
12         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
13
14 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
15
16         [ews-app] Change log level for a log statement
17
18         Unreviewed minor fix.
19
20         * BuildSlaveSupport/ews-app/ews/models/patch.py:
21         (Patch.save_patch):
22
23 2019-02-13  Jer Noble  <jer.noble@apple.com>
24
25         [Cocoa] Media elements will restart network buffering just before suspending
26         https://bugs.webkit.org/show_bug.cgi?id=193691
27
28         Reviewed by Eric Carlson.
29
30         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
31         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
32         (TEST):
33
34 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
35
36         [ews-app] Fetch builder id to name mapping
37         https://bugs.webkit.org/show_bug.cgi?id=194355
38
39         Reviewed by Lucas Forschler.
40
41         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
42         (Buildbot.get_builder_id_to_name_mapping):
43         (Buildbot._get_display_name_from_builder_name):
44
45 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
46
47         Further restricting webarchive loads
48         https://bugs.webkit.org/show_bug.cgi?id=194567
49         <rdar://problem/47610130>
50
51         Reviewed by Youenn Fablet.
52
53         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
54         navigations on drop.
55
56         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
57         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
58         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
59         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
60         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
61         (TestWebKitAPI::TEST):
62         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
63         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
64         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
65         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
66         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
67         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
68         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
69
70 2019-02-13  John Wilander  <wilander@apple.com>
71
72         Store Ad Click Attribution requests in the network process
73         https://bugs.webkit.org/show_bug.cgi?id=194510
74         <rdar://problem/47650118>
75
76         Reviewed by Alex Christensen and Daniel Bates.
77
78         This patch adds two TestRunner functions:
79         - dumpAdClickAttribution()
80         - clearAdClickAttribution()
81
82         They call into the network process to dump and clear Ad Click
83         Attribution state, respectively.
84
85         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
86         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
87         (WTR::TestRunner::dumpAdClickAttribution):
88         (WTR::TestRunner::clearAdClickAttribution):
89         * WebKitTestRunner/InjectedBundle/TestRunner.h:
90         * WebKitTestRunner/TestController.cpp:
91         (WTR::TestController::resetStateToConsistentValues):
92         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
93         (WTR::adClickAttributionStringResultCallback):
94         (WTR::TestController::dumpAdClickAttribution):
95         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
96         (WTR::adClickAttributionVoidCallback):
97         (WTR::TestController::clearAdClickAttribution):
98         * WebKitTestRunner/TestController.h:
99         * WebKitTestRunner/TestInvocation.cpp:
100         (WTR::TestInvocation::dumpResults):
101         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
102         (WTR::TestInvocation::dumpAdClickAttribution):
103         * WebKitTestRunner/TestInvocation.h:
104
105 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
106
107         [ews-app] Generate status-bubble
108         https://bugs.webkit.org/show_bug.cgi?id=194572
109
110         Reviewed by Lucas Forschler.
111
112         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
113         (StatusBubble._build_bubble):
114         (StatusBubble._should_show_bubble_for):
115         (StatusBubble._build_bubbles_for_patch):
116
117 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
118
119         [ews-app] Add status bubble html template
120         https://bugs.webkit.org/show_bug.cgi?id=194571
121
122         Reviewed by Lucas Forschler.
123
124         * BuildSlaveSupport/ews-app/ews/templates: Added.
125         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
126
127 2019-02-12  Chris Dumez  <cdumez@apple.com>
128
129         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
130         https://bugs.webkit.org/show_bug.cgi?id=194568
131         <rdar://problem/47944490>
132
133         Reviewed by Ryosuke Niwa.
134
135         Add API test coverage.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
138         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
139
140 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
141
142         webkitpy: Remove bug_dummy from parsed test expectations
143         https://bugs.webkit.org/show_bug.cgi?id=194562
144         <rdar://problem/47853999>
145
146         Reviewed by Lucas Forschler.
147
148         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
149         (TestExpectationParser):
150         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
151         skipped tests.
152         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
153
154 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
155
156         [ews-app] Add method to fetch patch
157         https://bugs.webkit.org/show_bug.cgi?id=194518
158
159         Reviewed by Lucas Forschler.
160
161         * BuildSlaveSupport/ews-app/ews/models/patch.py:
162         (Patch.get_patch):
163
164 2019-02-12  Zalan Bujtas  <zalan@apple.com>
165
166         [LFC] Expand tests coverage (60 new tests -> 860)
167
168         Unreviewed test gardening (run-singly, --child-processes=1).
169
170         * LayoutReloaded/misc/LFC-passing-tests.txt:
171
172 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
173
174         Allow pages to trigger programmatic paste from script on iOS
175         https://bugs.webkit.org/show_bug.cgi?id=194271
176         <rdar://problem/47808810>
177
178         Reviewed by Tim Horton.
179
180         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
181
182         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
183         (WTR::UIScriptController::platformSetDidShowMenuCallback):
184         (WTR::UIScriptController::platformSetDidHideMenuCallback):
185         (WTR::UIScriptController::rectForMenuAction const):
186
187         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
188         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
189         for when the menu is shown or hidden.
190
191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
192         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
193         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
194         (WTR::UIScriptController::setDidShowMenuCallback):
195         (WTR::UIScriptController::didShowMenuCallback const):
196         (WTR::UIScriptController::setDidHideMenuCallback):
197         (WTR::UIScriptController::didHideMenuCallback const):
198         (WTR::UIScriptController::platformSetDidShowMenuCallback):
199         (WTR::UIScriptController::platformSetDidHideMenuCallback):
200         (WTR::UIScriptController::rectForMenuAction const):
201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
202         * WebKitTestRunner/TestController.cpp:
203         (WTR::TestController::resetPreferencesToConsistentValues):
204         (WTR::updateTestOptionsFromTestHeader):
205         * WebKitTestRunner/TestOptions.h:
206
207         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
208         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
209
210         (WTR::TestOptions::hasSameInitializationOptions const):
211         * WebKitTestRunner/UIScriptControllerCocoa.mm:
212         (WTR::UIScriptController::calendarType const):
213         (WTR::UIScriptController::platformUndoManager const):
214         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
215         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
216         (-[TestRunnerWKWebView initWithFrame:configuration:]):
217         (-[TestRunnerWKWebView dealloc]):
218         (-[TestRunnerWKWebView _didShowMenu]):
219         (-[TestRunnerWKWebView _didHideMenu]):
220
221         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
222
223         * WebKitTestRunner/ios/TestControllerIOS.mm:
224         (WTR::handleMenuWillHideNotification):
225         (WTR::handleMenuDidHideNotification):
226         (WTR::TestController::platformInitialize):
227         (WTR::TestController::platformDestroy):
228         (WTR::TestController::platformResetStateToConsistentValues):
229
230         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
231         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
232
233         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
234         (WTR::forEachViewInHierarchy):
235         (WTR::findViewInHierarchyOfType):
236
237         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
238         functions that dig through a given view's hierarchy in search of a view of a given class.
239
240         (WTR::UIScriptController::selectionStartGrabberViewRect const):
241         (WTR::UIScriptController::selectionEndGrabberViewRect const):
242         (WTR::UIScriptController::selectionCaretViewRect const):
243         (WTR::UIScriptController::selectionRangeViewRects const):
244         (WTR::UIScriptController::platformSetDidShowMenuCallback):
245         (WTR::UIScriptController::platformSetDidHideMenuCallback):
246
247         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
248
249         (WTR::UIScriptController::rectForMenuAction const):
250
251         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
252         callout bar) whose label matches the given string.
253
254         (WTR::UIScriptController::platformContentView const):
255
256         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
257         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
258         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
259
260         (WTR::UIScriptController::platformUndoManager const): Deleted.
261         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
262         (WTR::UIScriptController::platformContentView const):
263         (WTR::UIScriptController::platformUndoManager const): Deleted.
264
265 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
266
267         webkitpy: No option to only show unexpected failures in results.html for iPad
268         https://bugs.webkit.org/show_bug.cgi?id=194554
269         <rdar://problem/47922442>
270
271         Rubber-stamped by Aakash Jain.
272
273         Just because a TestExpecations file does not exist for a specific platform does not mean that
274         TestExpecations are not being used, given that platforms inherit test expectations.
275
276         * Scripts/webkitpy/port/base.py:
277         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
278         * Scripts/webkitpy/port/base_unittest.py:
279         (PortTest.test_uses_test_expectations_file):
280
281 2019-02-12  Alex Christensen  <achristensen@webkit.org>
282
283         Remove setDefersLoading infrastructure from WebKit2
284         https://bugs.webkit.org/show_bug.cgi?id=194506
285
286         Reviewed by Brady Eidson.
287
288         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
290         (WTR::TestRunner::setDefersLoading): Deleted.
291         * WebKitTestRunner/InjectedBundle/TestRunner.h:
292
293 2019-02-12  Alex Christensen  <achristensen@webkit.org>
294
295         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
296         https://bugs.webkit.org/show_bug.cgi?id=194522
297         <rdar://problem/47789393>
298
299         Reviewed by Chris Dumez.
300
301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
302         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
303         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
305
306 2019-02-12  Andy Estes  <aestes@apple.com>
307
308         [iOSMac] Enable Parental Controls Content Filtering
309         https://bugs.webkit.org/show_bug.cgi?id=194521
310         <rdar://39732376>
311
312         Reviewed by Tim Horton.
313
314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
315
316 2019-02-12  Zalan Bujtas  <zalan@apple.com>
317
318         [LFC][IFC] Add intrinsic width support for float boxes.
319         https://bugs.webkit.org/show_bug.cgi?id=194528
320
321         Reviewed by Antti Koivisto.
322
323         Expand tests coverage (2 new tests -> 800).
324         (This is the correct test ordering --runs-singly --child-processes=1)
325
326         * LayoutReloaded/misc/LFC-passing-tests.txt:
327
328 2019-02-12  Rob Buis  <rbuis@igalia.com>
329
330         Implement serializing in MIME type parser
331         https://bugs.webkit.org/show_bug.cgi?id=193909
332
333         Reviewed by Darin Adler.
334
335         Add various tests involving upper case, non-ASCII, control/null characters,
336         various HTTP whitespace, single quotes and an unpaired surrogate.
337
338         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
339         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
340         (TestWebKitAPI::serializeIfValid):
341         (TestWebKitAPI::TEST):
342
343 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
344
345         [Cocoa] Ask platform for generic font family mappings
346         https://bugs.webkit.org/show_bug.cgi?id=187723
347         <rdar://problem/41892438>
348
349         Reviewed by Brent Fulgham.
350
351         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
352
353         * DumpRenderTree/mac/DumpRenderTree.mm:
354         (allowedFontFamilySet):
355         * WebKitTestRunner/mac/TestControllerMac.mm:
356         (WTR::allowedFontFamilySet):
357
358 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
359
360         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
361         https://bugs.webkit.org/show_bug.cgi?id=193622
362
363         Reviewed by Michael Catanzaro.
364
365         This adds support for loading content extension rule sets from the JSON files which
366         accompany the corresponding layout test, using the C API. The Cocoa specific parts
367         of WKTR for this could be removed, but that is left for a follow-up patch with
368         cleanups.
369
370         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
371         * WebKitTestRunner/TestController.cpp:
372         (WTR::testPath): Subtract one from the length when constructing the result std::string to
373         avoid having the null-terminator copied into the result.
374         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
375         part of the preparations to run a test.
376         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
377         (WTR::contentExtensionStoreCallback): Added.
378         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
379         used for content extensions test.
380         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
381         extensions and compiling the JSON rule set for tests involving content extensions.
382         (WTR::TestController::resetContentExtensions): Removes the content extension built for
383         testing and disables content extensions.
384         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
385         resetContentExtensions().
386         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
387         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
388         configureContentExtensionForTest(), and userContentController().
389
390 2019-02-11  Daniel Bates  <dabates@apple.com>
391
392         [iOS] Mouse/Touch/Pointer events are missing modifier keys
393         https://bugs.webkit.org/show_bug.cgi?id=191446
394         <rdar://problem/45929460>
395
396         Reviewed by Tim Horton.
397
398         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
399
400         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
401         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
402         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
403         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
404         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
405         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
406         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
407         * TestRunnerShared/UIScriptContext/UIScriptController.h:
408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
409         (WTR::arrayLength):
410         (WTR::parseModifierArray):
411         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
412         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
413         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
414         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
415
416 2019-02-11  Commit Queue  <commit-queue@webkit.org>
417
418         Unreviewed, rolling out r241272 and r241276.
419         https://bugs.webkit.org/show_bug.cgi?id=194514
420
421         Broke the Apple Internal build and the fix requires human
422         intervention :( (Requested by dydz on #webkit).
423
424         Reverted changesets:
425
426         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
427         https://bugs.webkit.org/show_bug.cgi?id=191446
428         https://trac.webkit.org/changeset/241272
429
430         "Fix internal iOS build after r241272"
431         https://bugs.webkit.org/show_bug.cgi?id=191446
432         https://trac.webkit.org/changeset/241276
433
434 2019-02-11  Truitt Savell  <tsavell@apple.com>
435
436         Unreviewed, rolling out r241269.
437
438         Caused 5 layout tests crashes on Mac WK1
439
440         Reverted changeset:
441
442         "DumpRenderTree should report unknown options"
443         https://bugs.webkit.org/show_bug.cgi?id=191303
444         https://trac.webkit.org/changeset/241269
445
446 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
447
448         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
449         https://bugs.webkit.org/show_bug.cgi?id=194313
450
451         Reviewed by Tim Horton.
452
453         Add a helper to determine whether the web view is presenting modal UI.
454
455         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
456         (WTR::UIScriptController::isPresentingModally const):
457         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
458         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
459         (WTR::UIScriptController::isPresentingModally const):
460         * TestRunnerShared/UIScriptContext/UIScriptController.h:
461         * WebKitTestRunner/UIScriptControllerCocoa.mm:
462         (WTR::UIScriptController::calendarType const): Deleted.
463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
464         (WTR::UIScriptController::isPresentingModally const):
465         (WTR::UIScriptController::calendarType const):
466         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
467         (WTR::UIScriptController::calendarType const):
468
469 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
470
471         GCHeapInspector: Show the retained sizes in more places
472         https://bugs.webkit.org/show_bug.cgi?id=194464
473
474         Reviewed by Simon Fraser.
475
476         * GCHeapInspector/gc-heap-inspector.html:
477         * GCHeapInspector/script/interface.js:
478         (HeapInspectorUtils.humanReadableSize):
479         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
480         (HeapInspectorUtils.spanForNode.span.span):
481         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
482         (HeapSnapshotInspector.prototype.buildRoots):
483
484 2019-02-11  Daniel Bates  <dabates@apple.com>
485
486         [iOS] Mouse/Touch/Pointer events are missing modifier keys
487         https://bugs.webkit.org/show_bug.cgi?id=191446
488         <rdar://problem/45929460>
489
490         Reviewed by Tim Horton.
491
492         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
493
494         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
495         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
496         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
497         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
498         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
499         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
500         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
501         * TestRunnerShared/UIScriptContext/UIScriptController.h:
502         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
503         (WTR::arrayLength):
504         (WTR::parseModifierArray):
505         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
506         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
507         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
508         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
509
510 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
511
512         DumpRenderTree should report unknown options
513         https://bugs.webkit.org/show_bug.cgi?id=191303
514
515         Reviewed by Frédéric Wang.
516
517         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
518         to report unknown options.
519         Added and assigned test options which are currently used in tests.
520
521         * DumpRenderTree/TestOptions.cpp:
522         (TestOptions::TestOptions):
523
524 2019-02-11  Truitt Savell  <tsavell@apple.com>
525
526         Unreviewed, rolling out r241229.
527
528         Revision broke internal builds for watchOS.
529
530         Reverted changeset:
531
532         "[Cocoa] Ask platform for generic font family mappings"
533         https://bugs.webkit.org/show_bug.cgi?id=187723
534         https://trac.webkit.org/changeset/241229
535
536 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
537
538         [WinCairo][MiniBrowser] Basic authentication always fails.
539         https://bugs.webkit.org/show_bug.cgi?id=194496
540
541         Reviewed by Don Olmstead.
542
543         * MiniBrowser/win/DialogHelper.h:
544         (Dialog::getText):
545
546 2019-02-11  Philippe Normand  <pnormand@igalia.com>
547
548         [GStreamer] GstMappedBuffer testsuite build fails
549         https://bugs.webkit.org/show_bug.cgi?id=194495
550
551         Reviewed by Carlos Garcia Campos.
552
553         Fix the build by explicitely adding the gstreamer1.0-audio include
554         directories to the include path.
555
556         * TestWebKitAPI/PlatformGTK.cmake:
557         * TestWebKitAPI/PlatformWPE.cmake:
558
559 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         [GTK][WPE] Add enable-javascript-markup setting
562         https://bugs.webkit.org/show_bug.cgi?id=193439
563
564         Reviewed by Michael Catanzaro.
565
566         Add test cases to check the new setting.
567
568         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
569         (testWebKitSettings):
570         (testWebKitSettingsJavaScriptMarkup):
571         (beforeAll):
572
573 2019-02-10  Darin Adler  <darin@apple.com>
574
575         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
576         https://bugs.webkit.org/show_bug.cgi?id=194485
577
578         Reviewed by Daniel Bates.
579
580         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
581
582 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
583
584         Add more tests for clampTo<>()
585         https://bugs.webkit.org/show_bug.cgi?id=194462
586
587         Reviewed by Geoffrey Garen.
588
589         Darin suggested to test the very last floating point number
590         at the boundaries when truncating to integer.
591         I added test for max/min and max-1/min-1.
592
593         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
594         (TestWebKitAPI::TEST):
595
596 2019-02-09  Darin Adler  <darin@apple.com>
597
598         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
599         https://bugs.webkit.org/show_bug.cgi?id=194021
600
601         Reviewed by Geoffrey Garen.
602
603         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
604         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
605         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
606
607 2019-02-09  Zalan Bujtas  <zalan@apple.com>
608
609         [LFC][IFC] Add intrinsic width support for basic inline containers
610         https://bugs.webkit.org/show_bug.cgi?id=194473
611
612         Reviewed by Antti Koivisto.
613
614         Expand tests coverage (11 new tests -> 798)
615
616         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
617
618 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
619
620         Fix MiniBrowser's entitlements
621         https://bugs.webkit.org/show_bug.cgi?id=192431
622
623         Reviewed by Joseph Pecoraro.
624
625         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
626         files, making it impossible to load any extension.
627
628         * MiniBrowser/MiniBrowser.entitlements:
629
630 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
631
632         [Cocoa] Ask platform for generic font family mappings
633         https://bugs.webkit.org/show_bug.cgi?id=187723
634         <rdar://problem/41892438>
635
636         Reviewed by Brent Fulgham.
637
638         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
639
640         * DumpRenderTree/mac/DumpRenderTree.mm:
641         (allowedFontFamilySet):
642         * WebKitTestRunner/mac/TestControllerMac.mm:
643         (WTR::allowedFontFamilySet):
644
645 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
646
647         [GTK] Implement back/forward touchpad gesture
648         https://bugs.webkit.org/show_bug.cgi?id=193919
649
650         Reviewed by Michael Catanzaro.
651
652         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
653         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
654
655 2019-02-08  Alex Christensen  <achristensen@webkit.org>
656
657         Add SPI to use networking daemon instead of XPC service
658         https://bugs.webkit.org/show_bug.cgi?id=194427
659
660         Reviewed by Geoffrey Garen
661
662         * MiniBrowser/MiniBrowser.entitlements:
663
664 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
665
666         [ews-build] Ensure that every builder in config.json has short name
667         https://bugs.webkit.org/show_bug.cgi?id=194461
668
669         Reviewed by Lucas Forschler.
670
671         * BuildSlaveSupport/ews-build/loadConfig.py:
672         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
673
674 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
675
676         [ews-build] Add short name to config.json
677         https://bugs.webkit.org/show_bug.cgi?id=194456
678
679         Reviewed by Lucas Forschler.
680
681         * BuildSlaveSupport/ews-build/config.json: Added short name.
682         * BuildSlaveSupport/ews-build/loadConfig.py:
683         (loadBuilderConfig): Set the short name as the builder description.
684
685 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
686
687         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
688         https://bugs.webkit.org/show_bug.cgi?id=194418
689
690         Reviewed by Lucas Forschler.
691
692         Do not include errors trying when finding crashlogs at the end of
693         a run-webkit-tests run since we don't process those errors.
694
695         * Scripts/webkitpy/port/darwin.py:
696         (DarwinPort._look_for_all_crash_logs_in_log_dir):
697         * Scripts/webkitpy/port/ios_device.py:
698         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
699         * Scripts/webkitpy/port/watch_device.py:
700         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
701
702 2019-02-08  Beth Dakin  <bdakin@apple.com>
703
704         Add afterScreenUpdates to WKSnapshotConfiguration
705         https://bugs.webkit.org/show_bug.cgi?id=194362
706         -and corresponding-
707         <rdar://problem/40655528> Please add an "after screen updates" property to 
708         WKSnapshotConfiguration (to solve blank snapshots)
709
710         Reviewed by Tim Horton.
711
712         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
713         (TEST):
714
715 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
716
717         clampTo(): do not convert the input to double when dealing with integers
718         https://bugs.webkit.org/show_bug.cgi?id=194263
719         <rdar://problem/47692312>
720
721         Reviewed by Darin Adler.
722
723         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
724         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
725         (TestWebKitAPI::testClampFloatingPointToInteger):
726         (TestWebKitAPI::testClampSameSignIntegers):
727         (TestWebKitAPI::testClampUnsignedToSigned):
728         (TestWebKitAPI::testClampSignedToUnsigned):
729
730 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
731
732         webkitpy: Respect --dedicated-simulators flag
733         https://bugs.webkit.org/show_bug.cgi?id=194416
734         <rdar://problem/47894722>
735
736         Reviewed by Lucas Forschler.
737
738         * Scripts/webkitpy/port/device_port.py:
739         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
740         available devices can be safely ignored.
741
742 2019-02-07  Keith Rollin  <krollin@apple.com>
743
744         Remove extra copy of 100x100-red.tga
745         https://bugs.webkit.org/show_bug.cgi?id=194371
746         <rdar://problem/47873465>
747
748         Reviewed by Said Abou-Hallawa.
749
750         In order to help it pass its tests, Bug 194190 added a second copy of
751         the file 100x100-red.tga. However, it turns out that this additional
752         file wasn't actually needed, and that that sole previous copy was
753         sufficient. At the same time, this second copy -- which was copied to
754         the same location in the build output as the first copy -- now caused
755         XCBuild to complain because there were two production rules for the
756         same output file. Address this by removing the newly-added extra copy.
757
758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
759         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
760
761 2019-02-07  Alex Christensen  <achristensen@webkit.org>
762
763         Deprecate WKBundlePageSetDefersLoading
764         https://bugs.webkit.org/show_bug.cgi?id=191394
765
766         Reviewed by Dean Jackson.
767
768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
769         (WTR::TestRunner::setDefersLoading):
770
771 2019-02-07  Zalan Bujtas  <zalan@apple.com>
772
773         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
774         https://bugs.webkit.org/show_bug.cgi?id=194391
775
776         Reviewed by Antti Koivisto.
777
778         * LayoutReloaded/misc/LFC-passing-tests.txt:
779
780 2019-02-06  Keith Rollin  <krollin@apple.com>
781
782         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
783         https://bugs.webkit.org/show_bug.cgi?id=193975
784         <rdar://problem/47643306>
785
786         Reviewed by Tim Horton.
787
788         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
789         the Info.plist file into the bundle. This step is not necessary as the
790         implicit "bundle up all the build products into a framework" build
791         phase does this already. Having the Copy Bundle Resources phase do
792         this causes a conflict under XCBuild, which objects to two build
793         phases producing the same file (Info.plist). Address this by removing
794         Info.plist from the Copy Bundle Resources phase.
795
796         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
797
798 2019-02-06  Keith Rollin  <krollin@apple.com>
799
800         Really enable the automatic checking and regenerations of .xcfilelists during builds
801         https://bugs.webkit.org/show_bug.cgi?id=194357
802         <rdar://problem/47861231>
803
804         Reviewed by Chris Dumez.
805
806         Bug 194124 was supposed to enable the automatic checking and
807         regenerating of .xcfilelist files during the build. While related
808         changes were included in that patch, the change to actually enable the
809         operation somehow was omitted. This patch actually enables the
810         operation. The check-xcfilelist.sh scripts now check
811         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
812         from the checking.
813
814         * DumpRenderTree/Scripts/check-xcfilelists.sh:
815         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
816
817 2019-02-06  David Kilzer  <ddkilzer@apple.com>
818
819         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
820         <https://webkit.org/b/194286>
821         <rdar://problem/47815558>
822
823         Reviewed by Alexey Proskuryakov.
824
825         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
826         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
827         WKRetainPtr<> to avoid leaking the WKDataRef.
828
829 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
830
831         Unreviewed, fix a typo
832
833         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
834
835 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
836
837         [GTK][WPE] force libpsl build to use ICU in jhbuild
838         https://bugs.webkit.org/show_bug.cgi?id=194288
839
840         Reviewed by Carlos Garcia Campos.
841
842         * gtk/jhbuild.modules:
843         Require ICU for libpsl build in jhbuild, like done in WPE.
844
845 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
846
847         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
848         https://bugs.webkit.org/show_bug.cgi?id=194209
849
850         Reviewed by Carlos Garcia Campos.
851
852         Enhance TestCookieManager to ensure this doesn't happen again.
853
854         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
855         (testCookieManagerPersistentStorage):
856         (beforeAll):
857
858 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
859
860         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
861         https://bugs.webkit.org/show_bug.cgi?id=194324
862
863         Reviewed by Andy Estes.
864
865         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
866         part of the name is already implicit, since this is in testing code in TestOptions.
867
868         * WebKitTestRunner/TestController.cpp:
869         (WTR::TestController::generateContextConfiguration const):
870         (WTR::updateTestOptionsFromTestHeader):
871         * WebKitTestRunner/TestOptions.h:
872         (WTR::TestOptions::hasSameInitializationOptions const):
873
874 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
875
876         [ews-build] Allow * as platform for builders and workers
877         https://bugs.webkit.org/show_bug.cgi?id=188533
878
879         Reviewed by Lucas Forschler.
880
881         * BuildSlaveSupport/ews-build/loadConfig.py:
882         (checkWorkersAndBuildersForConsistency):
883
884 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
885
886         [ews-build] Add few bots to config.json
887         https://bugs.webkit.org/show_bug.cgi?id=194304
888
889         Reviewed by Lucas Forschler.
890
891         * BuildSlaveSupport/ews-build/config.json:
892
893 2019-02-05  Keith Rollin  <krollin@apple.com>
894
895         Enable the automatic checking and regenerations of .xcfilelists during builds
896         https://bugs.webkit.org/show_bug.cgi?id=194124
897         <rdar://problem/47721277>
898
899         Reviewed by Tim Horton.
900
901         Bug 193790 add a facility for checking -- during build time -- that
902         any needed .xcfilelist files are up-to-date and for updating them if
903         they are not. This facility was initially opt-in by setting
904         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
905         the process seemed robust. Its now time to enable this facility and
906         make it opt-out. If there is a need to disable this facility, set and
907         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
908         running `make` or `build-webkit`, or before running Xcode from the
909         command line.
910
911         Additionally, remove the step that generates a list of source files
912         going into the UnifiedSources build step. It's only necessarily to
913         specify Sources.txt and SourcesCocoa.txt as inputs.
914
915         * Scripts/generate-xcfilelists:
916
917 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
918
919         [GTK][WPE] force libpsl build to use ICU in jhbuild
920         https://bugs.webkit.org/show_bug.cgi?id=194288
921
922         Reviewed by Philippe Normand.
923
924         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
925         This can cause build failures if libidn is detected but libunistring is not available.
926
927         Make sure that ICU is used for runtime and builtin PSL data.
928
929         * gtk/jhbuild.modules:
930         * wpe/jhbuild.modules:
931
932 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
933
934         [ews-app] Modified timestamp should be updated on updating data
935         https://bugs.webkit.org/show_bug.cgi?id=194295
936
937         Reviewed by Lucas Forschler.
938
939         * BuildSlaveSupport/ews-app/ews/models/build.py:
940         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
941         * BuildSlaveSupport/ews-app/ews/models/step.py:
942
943 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
944
945         Unreviewed, rolling out r240742.
946
947         Causes crashes on iOS simulator.
948
949         Reverted changeset:
950
951         "[iOS] Keyups for non-modifier keys identified as "Dead" when
952         not focused in a content-editable element"
953         https://bugs.webkit.org/show_bug.cgi?id=192824
954         https://trac.webkit.org/changeset/240742
955
956 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
957
958         run-webkit-tests emits message "...running None" when running tests
959         https://bugs.webkit.org/show_bug.cgi?id=194133
960         <rdar://problem/47724738>
961
962         Reviewed by Lucas Forschler.
963
964         * Scripts/webkitpy/xcode/device_type.py:
965         (DeviceType.__str__): Use both version mapping tables and use just the variant
966         name if no version name is available.
967         * Scripts/webkitpy/xcode/device_type_unittest.py:
968         (DeviceTypeTest):
969         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
970         an associated named.
971
972 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
973
974         [WPE] require python3-setuptools for meson build in jhbuild
975         https://bugs.webkit.org/show_bug.cgi?id=194287
976
977         Reviewed by Philippe Normand.
978
979         python3-setuptools is needed to build meson in jhbuild.
980         It is already required by the GTK port.
981
982         * wpe/install-dependencies:
983
984 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
985
986         [ews-app] Add method to save BuilderMapping to database
987         https://bugs.webkit.org/show_bug.cgi?id=194264
988
989         Reviewed by Lucas Forschler.
990
991         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
992         (BuilderMapping.__str__):
993         (BuilderMapping):
994         (BuilderMapping.save_mapping):
995         (BuilderMapping.update_mapping):
996         (BuilderMapping.get_existing_mapping):
997         (BuilderMapping.is_valid_mapping):
998
999 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1000
1001         [ews-app] Add timestamp fields for BuilderMappings
1002         https://bugs.webkit.org/show_bug.cgi?id=194266
1003
1004         Reviewed by Lucas Forschler.
1005
1006         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1007         (BuilderMapping):
1008
1009 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1010
1011         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1012         https://bugs.webkit.org/show_bug.cgi?id=174816
1013
1014         Reviewed by Michael Catanzaro.
1015
1016         Add tests for webkit_uri_for_display().
1017
1018         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1019         (testURIForDisplayUnaffected):
1020         (testURIForDisplayAffected):
1021         (beforeAll):
1022         (afterAll):
1023         * TestWebKitAPI/glib/CMakeLists.txt:
1024
1025 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1026
1027         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1028         https://bugs.webkit.org/show_bug.cgi?id=194158
1029         <rdar://problem/47737268>
1030
1031         Rubber-stamped by Aakash Jain.
1032
1033         * Scripts/webkitpy/port/device_port.py:
1034         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1035
1036 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1037
1038         [CG] Enable setAdditionalSupportedImageTypes for WK1
1039         https://bugs.webkit.org/show_bug.cgi?id=194190
1040
1041         Reviewed by Tim Horton.
1042
1043         Add a test similar to the one under WebKit Cocoa but make it create a
1044         WebView instead of a WKWebView.
1045
1046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1047         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1048         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1049         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1050         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1051         (TestWebKitAPI::runTest):
1052         (TestWebKitAPI::TEST):
1053
1054 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1055
1056         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1057         https://bugs.webkit.org/show_bug.cgi?id=194168
1058
1059         Reviewed by Simon Fraser.
1060
1061         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1062
1063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1064         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1065         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1066         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1067         (TEST):
1068         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1069         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1070
1071 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1072
1073         REGRESSION (r237269): webkit-patch what-broke is broken 
1074         https://bugs.webkit.org/show_bug.cgi?id=193025
1075
1076         Reviewed by Aakash Jain.
1077
1078         * Scripts/webkitpy/common/host.py:
1079         (Host.buildbot):
1080         (Host.bugzilla): Renamed to 'buildbot'.
1081
1082 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1083
1084         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1085         https://bugs.webkit.org/show_bug.cgi?id=194207
1086
1087         Reviewed by Tim Horton.
1088
1089         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1090         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1091         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1092         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1093         start and delete forwards to remove the original attachment.
1094
1095         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1096         (TestWebKitAPI::TEST):
1097
1098 2019-02-04  Youenn Fablet  <youenn@apple.com>
1099
1100         Capture state should be managed consistently when doing process swapping
1101         https://bugs.webkit.org/show_bug.cgi?id=194122
1102         <rdar://problem/47609293>
1103
1104         Reviewed by Eric Carlson.
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1107         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1108         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1109         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1110         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1111         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1112         (WTR::TestRunner::isDoingMediaCapture const):
1113         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1114         * WebKitTestRunner/TestController.cpp:
1115         (WTR::TestController::isDoingMediaCapture const):
1116         * WebKitTestRunner/TestController.h:
1117         * WebKitTestRunner/TestInvocation.cpp:
1118         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1119         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1120         (WTR::TestController::isDoingMediaCapture const):
1121
1122 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1123
1124         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1125         https://bugs.webkit.org/show_bug.cgi?id=194142
1126
1127         Reviewed by Ross Kirsling.
1128
1129         There three 'separator' variables in TestController.cpp. Renamed
1130         it 'pathSeparator', and unified them.
1131
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::TestController::generateContextConfiguration const):
1134         (WTR::createTestURL):
1135         (WTR::TestController::platformAdjustContext):
1136
1137 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1138
1139         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1140         https://bugs.webkit.org/show_bug.cgi?id=194198
1141
1142         Reviewed by Antti Koivisto.
1143
1144         No need to set the banner heights on navigation now, since Page stores them.
1145
1146         * MiniBrowser/mac/WK2BrowserWindowController.m:
1147         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1148
1149 2019-02-03  John Wilander  <wilander@apple.com>
1150
1151         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1152         https://bugs.webkit.org/show_bug.cgi?id=194104
1153         <rdar://problem/47649991>
1154
1155         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1156
1157         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1158         (TestWebKitAPI::TEST):
1159             Changed numeric types from unsigned short to uint32_t.
1160
1161 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1162
1163         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1164         <https://webkit.org/b/194178>
1165         <rdar://problem/47753473>
1166
1167         Reviewed by Alexey Proskuryakov.
1168
1169         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1170         (WTR::uninstallFakeHelvetica): Pass nullptr into
1171         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1172
1173 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1174
1175         [LFC] Initialize ICB's style with fixed width/height.
1176         https://bugs.webkit.org/show_bug.cgi?id=194188
1177
1178         Reviewed by Antti Koivisto.
1179
1180         * LayoutReloaded/misc/LFC-passing-tests.txt:
1181
1182 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1183
1184         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1185         https://bugs.webkit.org/show_bug.cgi?id=194185
1186
1187         Reviewed by Antti Koivisto.
1188
1189         * LayoutReloaded/misc/LFC-passing-tests.txt:
1190
1191 2018-12-16  Darin Adler  <darin@apple.com>
1192
1193         Convert additional String::format clients to alternative approaches
1194         https://bugs.webkit.org/show_bug.cgi?id=192746
1195
1196         Reviewed by Alexey Proskuryakov.
1197
1198         * WebKitTestRunner/TestController.cpp:
1199         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1200         as an intermediate in code that ultimately constructs a WTF::String.
1201         (WTR::userMediaOriginHash): Use makeString.
1202         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1203         (WTR::TestController::didPerformClientRedirect): Ditto.
1204         (WTR::TestController::didPerformServerRedirect): Ditto.
1205         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1206
1207 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1208
1209         [ews-build] Add unit test to verify builder keys
1210         https://bugs.webkit.org/show_bug.cgi?id=194152
1211
1212         Reviewed by Lucas Forschler.
1213
1214         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1215         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1216
1217 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1218
1219         [LFC] Expand tests coverage (12 new tests -> 787)
1220
1221         Unreviewed test gardening.
1222
1223         * LayoutReloaded/misc/LFC-passing-tests.txt:
1224
1225 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1226
1227         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1228         https://bugs.webkit.org/show_bug.cgi?id=194163
1229
1230         Reviewed by Simon Fraser.
1231
1232         775
1233
1234         * LayoutReloaded/misc/LFC-passing-tests.txt:
1235
1236 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1237
1238         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1239         https://bugs.webkit.org/show_bug.cgi?id=194140
1240         <rdar://problem/47728098>
1241
1242         Reviewed by Tim Horton.
1243
1244         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1246         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1247
1248         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1249         test to induce an IPC deadlock when presenting a modal alert during touch start.
1250
1251         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::runJavaScriptAlert):
1254
1255         Add a client callback function for running JavaScript alerts.
1256
1257         (WTR::TestController::createOtherPage):
1258         (WTR::TestController::generateContextConfiguration const):
1259
1260         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1261         the fix in this patch.
1262
1263         (WTR::TestController::createWebViewWithOptions):
1264
1265         Plumb TestOptions to generateContextConfiguration.
1266
1267         (WTR::TestController::resetPreferencesToConsistentValues):
1268         (WTR::TestController::resetStateToConsistentValues):
1269         (WTR::updateTestOptionsFromTestHeader):
1270         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1271         (WTR::TestController::handleJavaScriptAlert):
1272         * WebKitTestRunner/TestController.h:
1273         * WebKitTestRunner/TestInvocation.cpp:
1274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1275         * WebKitTestRunner/TestOptions.h:
1276         (WTR::TestOptions::hasSameInitializationOptions const):
1277
1278 2019-02-01  Chris Dumez  <cdumez@apple.com>
1279
1280         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1281         https://bugs.webkit.org/show_bug.cgi?id=193740
1282         <rdar://problem/47527267>
1283
1284         Reviewed by Alex Christensen.
1285
1286         Add API test coverage.
1287
1288         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1289
1290 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-app] Add display name field to BuilderMapping model
1293         https://bugs.webkit.org/show_bug.cgi?id=194153
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1298         (BuilderMapping):
1299
1300 2019-02-01  Youenn Fablet  <youenn@apple.com>
1301
1302         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1303         https://bugs.webkit.org/show_bug.cgi?id=194155
1304
1305         Reviewed by Eric Carlson.
1306
1307         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1308         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1309         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1310
1311 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1312
1313         [LFC] Adjust replaced element's intrinsic ratio
1314         https://bugs.webkit.org/show_bug.cgi?id=194154
1315
1316         Reviewed by Antti Koivisto.
1317
1318         761
1319
1320         * LayoutReloaded/misc/LFC-passing-tests.txt:
1321
1322 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1323
1324         [WPE] Show test results in minibrowser
1325         https://bugs.webkit.org/show_bug.cgi?id=194150
1326
1327         Reviewed by Žan Doberšek.
1328
1329         * Scripts/webkitpy/port/wpe.py:
1330         (WPEPort.show_results_html_file):
1331
1332 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1335         https://bugs.webkit.org/show_bug.cgi?id=194151
1336
1337         Reviewed by Žan Doberšek.
1338
1339         ALT + <- go back
1340         ALT + -> go forward
1341
1342         * MiniBrowser/wpe/main.cpp:
1343         (main):
1344
1345 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1346
1347         [LFC] Set intrinsic size on Layout::Replaced
1348         https://bugs.webkit.org/show_bug.cgi?id=194139
1349
1350         Reviewed by Antti Koivisto.
1351
1352         744
1353
1354         * LayoutReloaded/misc/LFC-passing-tests.txt:
1355
1356 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1357
1358         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1359         https://bugs.webkit.org/show_bug.cgi?id=194146
1360
1361         Reviewed by Xabier Rodriguez-Calvar.
1362
1363         It allows to open relative paths.
1364
1365         * MiniBrowser/wpe/main.cpp:
1366         (main):
1367
1368 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1369
1370         Update flakiness dashboard configuration after recent queue changes
1371         https://bugs.webkit.org/show_bug.cgi?id=194127
1372
1373         Rubber-stamped by Aakash Jain.
1374
1375         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1376
1377         * TestResultServer/static-dashboards/builders.jsonp:
1378
1379 2019-01-31  Youenn Fablet  <youenn@apple.com>
1380
1381         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1382         https://bugs.webkit.org/show_bug.cgi?id=194106
1383         <rdar://problem/47676333>
1384
1385         Reviewed by Ryosuke Niwa.
1386
1387         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1388         (TestWebKitAPI::didFinishNavigation):
1389         (TestWebKitAPI::TEST):
1390         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1391
1392 2019-01-31  Chris Dumez  <cdumez@apple.com>
1393
1394         Page zoom level is lost after a process swap or a crash
1395         https://bugs.webkit.org/show_bug.cgi?id=194105
1396         <rdar://problem/47610781>
1397
1398         Reviewed by Alex Christensen.
1399
1400         Add API test coverage.
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1403         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1404
1405 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1406
1407         Revert r238819 which is unneeded and caused a performance regression.
1408         https://bugs.webkit.org/show_bug.cgi?id=192272
1409         <rdar://problem/46664625>
1410
1411         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1412         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1413         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1414
1415 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1416
1417         Formalize WebKitAdditions mechanism of LoadOptimizer
1418         https://bugs.webkit.org/show_bug.cgi?id=193886
1419         <rdar://problem/47696809>
1420
1421         Reviewed by Brent Fulgham.
1422
1423         * MiniBrowser/MiniBrowser.entitlements:
1424         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1425
1426 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1427
1428         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1429         https://bugs.webkit.org/show_bug.cgi?id=194090
1430
1431         Reviewed by Antti Koivisto.
1432
1433         * LayoutReloaded/misc/LFC-passing-tests.txt:
1434
1435 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1436
1437         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1438         https://bugs.webkit.org/show_bug.cgi?id=194074
1439
1440         Reviewed by Antti Koivisto.
1441
1442         * LayoutReloaded/misc/LFC-passing-tests.txt:
1443
1444 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1445
1446         [LFC][BFC] Add support for block level replaced box.
1447         https://bugs.webkit.org/show_bug.cgi?id=194071
1448
1449         Reviewed by Antti Koivisto.
1450
1451         * LayoutReloaded/misc/LFC-passing-tests.txt:
1452
1453 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1454
1455         Fix WebKitTestRunner's testPath with Windows full paths
1456         https://bugs.webkit.org/show_bug.cgi?id=194012
1457
1458         Reviewed by Alex Christensen.
1459
1460         updateTestOptionsFromTestHeader failed to open test files because
1461         testPath returned wrong file paths. It returned a path "/C:/..."
1462         if a URL "file:///C:/..." was given.
1463
1464         * WebKitTestRunner/TestController.cpp:
1465         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1466
1467 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1468
1469         [WPE] Bump font related dependencies to match the GTK+ port
1470         https://bugs.webkit.org/show_bug.cgi?id=194017
1471
1472         Reviewed by Žan Doberšek.
1473
1474         * wpe/jhbuild.modules:
1475         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1476         * wpe/patches/icudata-stdlibs.patch: Added.
1477
1478 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1479
1480         Enable swipe tests on iOS
1481         https://bugs.webkit.org/show_bug.cgi?id=194076
1482
1483         Reviewed by Geoffrey Garen.
1484
1485         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1486         it causes a debug assertion failure in runUIScript.
1487
1488         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1489         (WTR::UIScriptController::beginBackSwipe):
1490         (WTR::UIScriptController::completeBackSwipe):
1491
1492 2019-01-30  Keith Rollin  <krollin@apple.com>
1493
1494         Use correct printf format specifier
1495         https://bugs.webkit.org/show_bug.cgi?id=194062
1496         <rdar://problem/47686167>
1497
1498         Reviewed by Alexey Proskuryakov.
1499
1500         LayoutTestSpellChecker.mm is trying to format a variable of type
1501         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1502         actually an unsigned long long. Fix this by formatting with %llu.
1503
1504         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1505         (-[LayoutTestTextCheckingResult description]):
1506
1507 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1508
1509         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1510         https://bugs.webkit.org/show_bug.cgi?id=193979
1511
1512         Reviewed by Wenson Hsieh.
1513
1514         Fix the test for iOS. Make the test work with iOS UA string.
1515
1516         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1517
1518 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1519
1520         Replace High Sierra LLINT CLoop bot due to hardware failure
1521         https://bugs.webkit.org/show_bug.cgi?id=194066
1522
1523         Reviewed by Aakash Jain.
1524
1525         * BuildSlaveSupport/build.webkit.org-config/config.json:
1526
1527 2019-01-30  Keith Rollin  <krollin@apple.com>
1528
1529         [NSDragItem init] is unavailable
1530         https://bugs.webkit.org/show_bug.cgi?id=194059
1531         <rdar://problem/47685715>
1532
1533         Reviewed by Wenson Hsieh.
1534
1535         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1536         DumpRenderTree and TestWebKitAPI, which both try to create an
1537         NSDragItem in a manner that invokes this method. Address this by using
1538         -initWithPasteboardWriter instead.
1539
1540         Note that the parameter passed to initWithPasteboardWriter is likely
1541         incorrect. In both cases, the object passed does not conform to
1542         NSPasteboardWriting. However, with this fix, we're no worse off than
1543         before, and can now perform builds with newer compilers and SDKs until
1544         a real fix can be crafted. That work is tracked in
1545         https://bugs.webkit.org/show_bug.cgi?id=194060
1546
1547         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1548         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1549         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1550         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1551
1552 2019-01-30  Daniel Bates  <dabates@apple.com>
1553
1554         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1555         https://bugs.webkit.org/show_bug.cgi?id=192824
1556         <rdar://problem/47100332>
1557
1558         Reviewed by Wenson Hsieh.
1559
1560         Fix a bug where the wrong usage code was used for F13 thru F24.
1561
1562         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1563         (keyCodeForDOMFunctionKey):
1564
1565 2019-01-30  Chris Dumez  <cdumez@apple.com>
1566
1567         Regression(PSON) Load hang can occur on history navigation
1568         https://bugs.webkit.org/show_bug.cgi?id=194030
1569         <rdar://problem/47656939>
1570
1571         Reviewed by Antti Koivisto.
1572
1573         Add API test coverage.
1574
1575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1576
1577 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1578
1579         [LFC] Expand tests coverage.
1580
1581         Unreviewed test gardening.
1582
1583         * LayoutReloaded/misc/LFC-passing-tests.txt:
1584
1585 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1586
1587         [Flatpak] Add openjpeg support
1588         https://bugs.webkit.org/show_bug.cgi?id=194019
1589
1590         Reviewed by Michael Catanzaro.
1591
1592         * flatpak/org.webkit.CommonModules.yaml:
1593
1594 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1595
1596         Unreviewed, rolling out r240708.
1597         https://bugs.webkit.org/show_bug.cgi?id=194022
1598
1599         It broke WPE build (Requested by KaL on #webkit).
1600
1601         Reverted changeset:
1602
1603         "[WPE] Bump font related dependencies to match the GTK+ port"
1604         https://bugs.webkit.org/show_bug.cgi?id=194017
1605         https://trac.webkit.org/changeset/240708
1606
1607 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1608
1609         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1610         https://bugs.webkit.org/show_bug.cgi?id=194001
1611
1612         Reviewed by Antti Koivisto.
1613
1614         * LayoutReloaded/misc/LFC-passing-tests.txt:
1615
1616 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1617
1618         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1619         https://bugs.webkit.org/show_bug.cgi?id=194020
1620
1621         Reviewed by Antti Koivisto.
1622
1623         * LayoutReloaded/misc/LFC-passing-tests.txt:
1624
1625 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1626
1627         AX: Support color well on iOS
1628         https://bugs.webkit.org/show_bug.cgi?id=194010
1629
1630         Reviewed by Joanmarie Diggs.
1631
1632         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1633         (WTR::AccessibilityUIElement::stringAttributeValue):
1634
1635 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1636
1637         [WPE] Bump font related dependencies to match the GTK+ port
1638         https://bugs.webkit.org/show_bug.cgi?id=194017
1639
1640         Reviewed by Žan Doberšek.
1641
1642         * wpe/jhbuild.modules:
1643         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1644         * wpe/patches/icudata-stdlibs.patch: Added.
1645
1646 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1647
1648         [Mac] Update window scale API usage
1649         https://bugs.webkit.org/show_bug.cgi?id=193991
1650         rdar://problem/47614795
1651
1652         Reviewed by Tim Horton.
1653
1654         * DumpRenderTree/mac/DumpRenderTree.mm:
1655         (changeWindowScaleIfNeeded):
1656         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1658         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1659
1660 2019-01-29  Chris Dumez  <cdumez@apple.com>
1661
1662         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1663         https://bugs.webkit.org/show_bug.cgi?id=193977
1664         <rdar://problem/47643716>
1665
1666         Reviewed by Geoff Garen.
1667
1668         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1669         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1670         to the previous provisional committing *before* we make the last load. 
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1673
1674 2019-01-29  Youenn Fablet  <youenn@apple.com>
1675
1676         Adopt new SPI to evaluate server certificate trust
1677         https://bugs.webkit.org/show_bug.cgi?id=193355
1678
1679         Reviewed by Alex Christensen.
1680
1681         Add infrastructure to handle HTTPS server trust evaluation testing.
1682
1683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1685         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1686         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1687         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1689         * WebKitTestRunner/TestController.cpp:
1690         (WTR::TestController::resetPreferencesToConsistentValues):
1691         (WTR::TestController::didReceiveAuthenticationChallenge):
1692         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1693         * WebKitTestRunner/TestController.h:
1694         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1695         * WebKitTestRunner/TestInvocation.cpp:
1696         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1698         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1699
1700 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1701
1702         [ews-build] Add build step to print bot Configuration
1703         https://bugs.webkit.org/show_bug.cgi?id=193887
1704
1705         Reviewed by Lucas Forschler.
1706
1707         * BuildSlaveSupport/ews-build/steps.py:
1708         (PrintConfiguration): Build step to print configuration.
1709         * BuildSlaveSupport/ews-build/factories.py:
1710
1711 2019-01-29  Chris Dumez  <cdumez@apple.com>
1712
1713         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1714         https://bugs.webkit.org/show_bug.cgi?id=193967
1715         <rdar://problem/47635348>
1716
1717         Reviewed by Alex Christensen.
1718
1719         Add API test coverage.
1720
1721         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1722         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1723
1724 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1725
1726         [ews-app] Handle incoming results data
1727         https://bugs.webkit.org/show_bug.cgi?id=193973
1728
1729         Reviewed by Lucas Forschler.
1730
1731         * BuildSlaveSupport/ews-app/ews/views/results.py:
1732
1733 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews-app] Make the results url generic
1736         https://bugs.webkit.org/show_bug.cgi?id=193928
1737
1738         Reviewed by Lucas Forschler.
1739
1740         * BuildSlaveSupport/ews-app/ews/urls.py:
1741
1742 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1743
1744         [ews-build] Configure buildbot to send events to ews-app
1745         https://bugs.webkit.org/show_bug.cgi?id=193968
1746
1747         Reviewed by Lucas Forschler.
1748
1749         * BuildSlaveSupport/ews-build/events.py: Added.
1750         * BuildSlaveSupport/ews-build/master.cfg:
1751
1752 2019-01-29  Keith Rollin  <krollin@apple.com>
1753
1754         Add .xcfilelists to Run Script build phases
1755         https://bugs.webkit.org/show_bug.cgi?id=193792
1756         <rdar://problem/47201785>
1757
1758         Reviewed by Alex Christensen.
1759
1760         As part of supporting XCBuild, update the necessary Run Script build
1761         phases in their Xcode projects to refer to their associated
1762         .xcfilelist files.
1763
1764         Note that the addition of these files bumps the Xcode project version
1765         number to something that's Xcode 10 compatible. This change means that
1766         older versions of the Xcode IDE can't read these projects. Nor can it
1767         fully load workspaces that refer to these projects (the updated
1768         projects are shown as non-expandable placeholders). `xcodebuild` can
1769         still build these projects; it's just that the IDE can't open them.
1770
1771         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1772         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1773
1774 2019-01-29  John Wilander  <wilander@apple.com>
1775
1776         Add data abstraction and validation for Ad Click Attribution
1777         https://bugs.webkit.org/show_bug.cgi?id=193916
1778         <rdar://problem/47603481>
1779
1780         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1781
1782         Ad click attribution has two steps. First, the storage of an ad
1783         campaign ID for a click that takes the user to a destination
1784         site. Second, a conversion on the destination site that can be
1785         attributed to the ad click.
1786
1787         This patch adds a class that represents a request for ad click
1788         attribution. Validation makes sure that the bits of entropy
1789         reported through this mechanism is limited.
1790
1791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1792         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1793         (TestWebKitAPI::TEST):
1794
1795 2019-01-29  Chris Dumez  <cdumez@apple.com>
1796
1797         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1798         https://bugs.webkit.org/show_bug.cgi?id=193932
1799         <rdar://problem/47598947>
1800
1801         Reviewed by Brady Eidson.
1802
1803         Add API test coverage.
1804
1805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1806
1807 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1808
1809         Adding new passing LFC tests.
1810
1811         Unreviewed test gardening.
1812
1813         * LayoutReloaded/misc/LFC-passing-tests.txt:
1814
1815 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1816
1817         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1818         https://bugs.webkit.org/show_bug.cgi?id=193964
1819
1820         Reviewed by Antti Koivisto.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1825
1826         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1827         https://bugs.webkit.org/show_bug.cgi?id=193954
1828
1829         Reviewed by Antti Koivisto.
1830
1831         * LayoutReloaded/misc/LFC-passing-tests.txt:
1832
1833 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1834
1835         WebDriver: add support for running subtests
1836         https://bugs.webkit.org/show_bug.cgi?id=193904
1837
1838         Reviewed by Michael Catanzaro.
1839
1840         pytest already supports it by passing test.py::subtest, so we can do the same.
1841
1842         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1843         (get_item_name): Made this global.
1844         (CollectRecorder.__init__): Receive the parameter to ignore.
1845         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1846         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1847         (collect): Add parameter to ignore.
1848         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1849         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1850         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1851         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1852         (WebDriverTestRunnerSelenium.run): Ditto.
1853         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1854         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1855         (WebDriverTestRunnerW3C.run): Ditto.
1856
1857 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1858
1859         User agent string override for navigator.userAgent should be site specific quirks
1860         https://bugs.webkit.org/show_bug.cgi?id=193950
1861
1862         Reviewed by Brent Fulgham.
1863
1864         Updated per the _WKWebsitePolicies rename.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1867         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1868
1869 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1870
1871         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1872         https://bugs.webkit.org/show_bug.cgi?id=193941
1873
1874         Reviewed by Alex Christensen.
1875
1876         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1877         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1878         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1879         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1880         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1881         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1882         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1883         * TestWebKitAPI/Tests/WTF/Time.cpp:
1884         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1885         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1886         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1887         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1888
1889 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1890
1891         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1892
1893         * Scripts/webkitpy/common/config/contributors.json:
1894
1895 2019-01-28  Andy Estes  <aestes@apple.com>
1896
1897         [watchOS] Enable Parental Controls content filtering
1898         https://bugs.webkit.org/show_bug.cgi?id=193939
1899         <rdar://problem/46641912>
1900
1901         Reviewed by Ryosuke Niwa.
1902
1903         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1904
1905 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1906
1907         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1908         <https://webkit.org/b/193884>
1909
1910         Reviewed by Jiewen Tan.
1911
1912         * Scripts/webkitpy/style/checkers/cpp.py:
1913         (check_language): Add LocalAuthentication to
1914         `frameworks_with_soft_links`.
1915
1916 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1917
1918         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1919         https://bugs.webkit.org/show_bug.cgi?id=193891
1920
1921         Reviewed by Ross Kirsling.
1922
1923         There were three problems in window sizes of WebView and the host window.
1924         1. The sizes of pixel image output were incorrect.
1925         2. The host window is going to appear after window.resize was invoked.
1926         3. window.resize resized only the host window, not WebView.
1927
1928         This change solves them with a following approach.
1929         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1930         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1931            as well as DumpRenderTree in order to match the client area and the window area.
1932         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1933         d. PlatformWebView::setWindowFrame changes both window sizes.
1934         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1935
1936         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1937         (WTR::PlatformWebView::PlatformWebView): Create the host window
1938         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1939         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1940         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1941
1942 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1943
1944         [ews-app] Add method to save Step data to database
1945         https://bugs.webkit.org/show_bug.cgi?id=193890
1946
1947         Reviewed by Lucas Forschler.
1948
1949         * BuildSlaveSupport/ews-app/ews/models/step.py:
1950         (Step.save_step): Method to save step data.
1951         (Step.update_step): Method to update step data.
1952         (Step.get_existing_step): Method to fetch existing step from database.
1953         (Step.is_valid_result): Method to validate valid step result.
1954
1955 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1956
1957         [ews-app] Add method to save Build data to database
1958         https://bugs.webkit.org/show_bug.cgi?id=193735
1959
1960         Reviewed by Lucas Forschler.
1961
1962         * BuildSlaveSupport/ews-app/ews/models/build.py:
1963         (Build.save_build): Method to save build information to database.
1964         (Build.get_existing_build): Method to fetch existing build from database.
1965         (Build.is_valid_result): Method to validate build result.
1966         * BuildSlaveSupport/ews-app/ews/common/util.py:
1967         (is_valid_int_id): Method to validate valid id.
1968
1969 2019-01-28  Chris Dumez  <cdumez@apple.com>
1970
1971         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1972         https://bugs.webkit.org/show_bug.cgi?id=193915
1973         <rdar://problem/47560907>
1974
1975         Reviewed by Alex Christensen.
1976
1977         Add API test coverage.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1980
1981 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1982
1983         [ews-app] Rename id variables
1984         https://bugs.webkit.org/show_bug.cgi?id=193883
1985
1986         Reviewed by Lucas Forschler.
1987
1988         * BuildSlaveSupport/ews-app/ews/models/build.py:
1989         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1990         * BuildSlaveSupport/ews-app/ews/models/step.py:
1991         * BuildSlaveSupport/ews-app/ews/urls.py:
1992         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1993         * BuildSlaveSupport/ews-app/ews/views/results.py:
1994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1995
1996 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-app] Allow certain fields to be empty
1999         https://bugs.webkit.org/show_bug.cgi?id=193892
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-app/ews/models/build.py:
2004         * BuildSlaveSupport/ews-app/ews/models/step.py:
2005
2006 2019-01-28  Rob Buis  <rbuis@igalia.com>
2007
2008         Update MIME type parser
2009         https://bugs.webkit.org/show_bug.cgi?id=180526
2010
2011         Reviewed by Frédéric Wang.
2012
2013         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2014         (TestWebKitAPI::TEST):
2015
2016 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2017
2018         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2019         https://bugs.webkit.org/show_bug.cgi?id=193896
2020
2021         Reviewed by Antti Koivisto.
2022
2023         * LayoutReloaded/misc/LFC-passing-tests.txt:
2024
2025 2018-12-15  Darin Adler  <darin@apple.com>
2026
2027         Replace many uses of String::format with more type-safe alternatives
2028         https://bugs.webkit.org/show_bug.cgi?id=192742
2029
2030         Reviewed by Mark Lam.
2031
2032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2033         (WTR::cacheTestRunnerCallback): Use makeString.
2034         * WebKitTestRunner/TestController.cpp:
2035         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2036         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2037
2038 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2039
2040         Use a load optimizer for some sites
2041         https://bugs.webkit.org/show_bug.cgi?id=193881
2042         <rdar://problem/46325455>
2043
2044         Reviewed by Brent Fulgham.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2048
2049 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2050
2051         AX: Introduce a static accessibility tree
2052         https://bugs.webkit.org/show_bug.cgi?id=193348
2053         <rdar://problem/47203295>
2054
2055         Reviewed by Ryosuke Niwa.
2056
2057         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2058
2059 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2060
2061         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2062         https://bugs.webkit.org/show_bug.cgi?id=193867
2063
2064         Reviewed by Antti Koivisto.
2065
2066         * LayoutReloaded/misc/LFC-passing-tests.txt:
2067
2068 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2069
2070         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2071         https://bugs.webkit.org/show_bug.cgi?id=193865
2072
2073         Reviewed by Antti Koivisto.
2074
2075         * LayoutReloaded/misc/LFC-passing-tests.txt:
2076
2077 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2078
2079         Need a mechanism to override navigator.userAgent
2080         https://bugs.webkit.org/show_bug.cgi?id=193762
2081         <rdar://problem/47504939>
2082
2083         Reviewed by Brent Fulgham.
2084
2085         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2086
2087         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2088         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2089         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2090
2091 2019-01-25  Dean Jackson  <dino@apple.com>
2092
2093         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2094         https://bugs.webkit.org/show_bug.cgi?id=193831
2095         <rdar://problem/47399263>
2096
2097         Reviewed by Chris Dumez.
2098
2099         Two new tests that exercise cross-origin and same-origin System
2100         Previews.
2101
2102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2103
2104 2019-01-25  Keith Rollin  <krollin@apple.com>
2105
2106         Update Xcode projects with "Check .xcfilelists" build phase
2107         https://bugs.webkit.org/show_bug.cgi?id=193790
2108         <rdar://problem/47201374>
2109
2110         Reviewed by Alex Christensen.
2111
2112         Support for XCBuild includes specifying inputs and outputs to various
2113         Run Script build phases. These inputs and outputs are specified as
2114         .xcfilelist files. Once created, these .xcfilelist files need to be
2115         kept up-to-date. In order to check that they are up-to-date or not,
2116         add an Xcode build step that invokes an external script that performs
2117         the checking. If the .xcfilelists are found to be out-of-date, update
2118         them, halt the build, and instruct the developer to restart the build
2119         with up-to-date files.
2120
2121         At this time, the checking and regenerating is performed only if the
2122         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2123         who want to use this facility can set this variable and test out the
2124         checking/regenerating. Once it seems like there are no egregious
2125         issues that upset a developer's workflow, we'll unconditionally enable
2126         this facility.
2127
2128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2129         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2130         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2131         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2132
2133 2019-01-25  Keith Rollin  <krollin@apple.com>
2134
2135         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2136         https://bugs.webkit.org/show_bug.cgi?id=193781
2137         <rdar://problem/47201153>
2138
2139         Reviewed by Alex Christensen.
2140
2141         Part of generating the .xcfilelists used as part of adopting XCBuild
2142         includes running `make DerivedSources.make` from a standalone script.
2143         It’s important for this invocation to have the same environment as
2144         when the actual build invokes `make DerivedSources.make`. If the
2145         environments are different, then the two invocations will provide
2146         different results. In order to get the same environment in the
2147         standalone script, have the script launch xcodebuild targeting the
2148         "Apply Configuration to XCFileLists" build target, which will then
2149         re-invoke our standalone script. The script is now running again, this
2150         time in an environment with all workspace, project, target, xcconfig
2151         and other environment variables established.
2152
2153         The "Apply Configuration to XCFileLists" build target accomplishes
2154         this task via a small embedded shell script that consists only of:
2155
2156             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2157
2158         The process that invokes "Apply Configuration to XCFileLists" first
2159         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2160         evaluated and exports it into the shell environment. When xcodebuild
2161         is invoked, it inherits the value of this variable and can `eval` the
2162         contents of that variable. Our external standalone script can then set
2163         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2164         of command-line parameters needed to restart itself in the appropriate
2165         state.
2166
2167         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2168         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2169
2170 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2171
2172         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2173         https://bugs.webkit.org/show_bug.cgi?id=193802
2174         <rdar://problem/46010580>
2175
2176         Reviewed by Andy Estes.
2177
2178         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2179         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2180         (TEST):
2181
2182 2019-01-25  Daniel Bates  <dabates@apple.com>
2183
2184         [iOS] uiController.keyDown() does not translate Control modified key
2185         https://bugs.webkit.org/show_bug.cgi?id=192898
2186
2187         Reviewed by Wenson Hsieh.
2188
2189         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2190         key translation, as applicable. Among other cases, key translation occurs when performing
2191         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2192         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2193         human pressing down and releasing key(s) using a hardware keyboard.
2194
2195         * WebKitTestRunner/ios/HIDEventGenerator.h:
2196         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2197         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2198
2199         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2200         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2201         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2202         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2203         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2204         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2205         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2206         (-[HIDEventGenerator longPress:completionBlock:]):
2207         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2208         Update code for above renaming.
2209
2210         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2211         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2212
2213         (-[HIDEventGenerator keyDown:]): Added.
2214         (-[HIDEventGenerator keyUp:]): Added.
2215         (-[HIDEventGenerator keyPress:completionBlock:]):
2216         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2217         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2218         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2219         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2220         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2221         (WTR::parseModifier): Deleted.
2222
2223 2019-01-25  Keith Rollin  <krollin@apple.com>
2224
2225         Complete the implementation of generate-xcfilelists
2226         https://bugs.webkit.org/show_bug.cgi?id=193782
2227
2228         Reviewed by Alex Christensen.
2229
2230         A preliminary version of generate-xcfilelists was added in r238008.
2231         This patch updates that script in order to:
2232
2233         - Support checking of .xcfilelists
2234         - Perform better execution of `make DerivedSources.make` by
2235           relaunching generate-xcfilelists under xcodebuild
2236         - Support incremental generation and checking of .xcfilelists
2237         - Support supplementary .xcfilelists files from WebKitAdditions
2238         - Support being wrapped by parallel version of generate-xcfilelists in
2239           Internal that adds support for (re)generating WebKit projects in
2240           that repo.
2241         - Support builds that have been performed in WebKitBuild as well as
2242           ~/Library/Developer/code/DerivedData
2243         - Increase robustness and debugging facilities.
2244
2245         * Scripts/generate-xcfilelists:
2246
2247 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2248
2249         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2250         https://bugs.webkit.org/show_bug.cgi?id=193297
2251         <rdar://problem/47158841>
2252
2253         Unreviewed test case fix.
2254
2255         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2256         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2259         (TEST):
2260
2261 2019-01-25  Keith Rollin  <krollin@apple.com>
2262
2263         Update existing .xcfilelists
2264         https://bugs.webkit.org/show_bug.cgi?id=193791
2265         <rdar://problem/47201706>
2266
2267         Reviewed by Alex Christensen.
2268
2269         Many .xcfilelist files were added in r238824 in order to support
2270         XCBuild. Update these with recent changes to the set of build files
2271         and with the current generate-xcfilelist script.
2272
2273         * DumpRenderTree/DerivedSources-input.xcfilelist:
2274         * DumpRenderTree/DerivedSources-output.xcfilelist:
2275         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2276         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2277
2278 2019-01-25  Keith Rollin  <krollin@apple.com>
2279
2280         Fix missing dependencies in extract-dependencies-from-makefile
2281         https://bugs.webkit.org/show_bug.cgi?id=193783
2282         <rdar://problem/47201571>
2283
2284         Reviewed by Alex Christensen.
2285
2286         The extract-dependencies-from-makefile script generates .xcfilelists
2287         for XCBuild by invoking a makefile in --debug mode, parsing the
2288         dependency information in the output, and extracting information
2289         regarding targets and dependents. However, the way `make` emits this
2290         dependency information is not rigorous, and so we need to determine
2291         what lines to look for and parse by trial and error. This approach
2292         didn't coriginally atch all the information we needed to collect, so
2293         update the script to look for the additional lines we now know to look
2294         for.
2295
2296         * Scripts/extract-dependencies-from-makefile:
2297         (Parser):
2298         (Parser.addTarget):
2299         (Parser.addPrereq):
2300         (Parser.doParse):
2301
2302 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2303
2304         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2305         https://bugs.webkit.org/show_bug.cgi?id=193297
2306         <rdar://problem/47158841>
2307
2308         Reviewed by Alex Christensen.
2309
2310         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2311             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2313         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2314         activating the message used to trigger the callback when it is set.
2315
2316 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2317
2318         WKWebView.goBack should reload if there is a safe browsing warning
2319         https://bugs.webkit.org/show_bug.cgi?id=193805
2320         <rdar://problem/46908216>
2321
2322         Reviewed by Geoff Garen.
2323
2324         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2325         (+[Simple3LookupContext sharedLookupContext]):
2326         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2327         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2328         (TEST):
2329
2330 2019-01-25  Chris Dumez  <cdumez@apple.com>
2331
2332         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2333         https://bugs.webkit.org/show_bug.cgi?id=193788
2334         <rdar://problem/47531231>
2335
2336         Reviewed by Alex Christensen.
2337
2338         Add API test coverage.
2339
2340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2341         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2342
2343 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2344
2345         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2346         https://bugs.webkit.org/show_bug.cgi?id=193771
2347
2348         Unreviewed infrastructure fix.
2349
2350         * Scripts/webkitpy/port/darwin.py:
2351         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2352
2353 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2354
2355         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2356
2357 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2358
2359         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2360
2361         * Scripts/webkitpy/common/config/contributors.json:
2362
2363 2019-01-25  Chris Dumez  <cdumez@apple.com>
2364
2365         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2366         https://bugs.webkit.org/show_bug.cgi?id=193779
2367         <rdar://problem/46170903>
2368
2369         Reviewed by Antti Koivisto.
2370
2371         Add API test that quickly navigates forward to a previous process without waiting for it to
2372         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2373         the process' previous page when reconnecting the it for the forward navigation.
2374
2375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2376
2377 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2378
2379         Need a way for JavaScript (or bundle) code to participate in undo
2380         https://bugs.webkit.org/show_bug.cgi?id=190009
2381         <rdar://problem/44807048>
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2386         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2387
2388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2389         (WTR::UIScriptController::lastUndoLabel const):
2390         (WTR::UIScriptController::firstRedoLabel const):
2391         (WTR::UIScriptController::platformUndoManager const):
2392         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2393         (WTR::UIScriptController::lastUndoLabel const):
2394         (WTR::UIScriptController::firstRedoLabel const):
2395         (WTR::UIScriptController::platformUndoManager const):
2396         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2397         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2398         (WTR::UIScriptController::lastUndoLabel const):
2399         (WTR::UIScriptController::firstRedoLabel const):
2400         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2401         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2402         (WTR::UIScriptController::lastUndoLabel const):
2403         (WTR::UIScriptController::firstRedoLabel const):
2404         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2405         (WTR::UIScriptController::platformUndoManager const):
2406         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2407         (WTR::UIScriptController::platformUndoManager const):
2408
2409 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2410
2411         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2412         https://bugs.webkit.org/show_bug.cgi?id=193824
2413
2414         Reviewed by Antti Koivisto.
2415
2416         * LayoutReloaded/misc/LFC-passing-tests.txt:
2417
2418 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2419
2420         Update macOS JSC bot configurations
2421         https://bugs.webkit.org/show_bug.cgi?id=193739
2422
2423         Reviewed by Alexey Proskuryakov.
2424
2425         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2427         (BubbleQueueServer): Move JSC EWS to Mojave section.
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2429         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2430         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2431
2432 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2433
2434         [Win][WebKitTestRunner] Implement EventSenderProxy
2435         https://bugs.webkit.org/show_bug.cgi?id=193755
2436
2437         Reviewed by Don Olmstead.
2438
2439         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2440         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2441         (WTR::EventSenderProxy::dispatchMessage):
2442         (WTR::EventSenderProxy::EventSenderProxy):
2443         (WTR::EventSenderProxy::mouseDown):
2444         (WTR::EventSenderProxy::mouseUp):
2445         (WTR::EventSenderProxy::mouseMoveTo):
2446         (WTR::EventSenderProxy::mouseScrollBy):
2447         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2448
2449 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2450
2451         Unreviewed fix for API test failure after r240437.
2452
2453         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2454
2455         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2456
2457 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2458
2459         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2460         https://bugs.webkit.org/show_bug.cgi?id=193787
2461         <rdar://problem/47497634>
2462
2463         Reviewed by Alexey Proskuryakov.
2464
2465         * Scripts/webkitdirs.pm:
2466         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2467
2468 2019-01-24  Truitt Savell  <tsavell@apple.com>
2469
2470         Unreviewed, rolling out r240446.
2471
2472         Casued 5 API failures
2473
2474         Reverted changeset:
2475
2476         "Activate the WebResourceLoadStatisticsStore in the
2477         NetworkProcess and deactivate it in the UIProcess."
2478         https://bugs.webkit.org/show_bug.cgi?id=193297
2479         https://trac.webkit.org/changeset/240446
2480
2481 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2482
2483         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2484         https://bugs.webkit.org/show_bug.cgi?id=193741
2485         <rdar://problem/47135030>
2486
2487         Reviewed by Antti Koivisto and Simon Fraser.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2490         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2491         (TestWebKitAPI::TEST):
2492
2493 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2494
2495         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2496         https://bugs.webkit.org/show_bug.cgi?id=193297
2497         <rdar://problem/47158841>
2498
2499         Reviewed by Alex Christensen.
2500
2501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2502         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2503         activating the message used to trigger the callback when it is set.
2504
2505 2019-01-24  John Wilander  <wilander@apple.com>
2506
2507         Add Ad Click Attribution as an internal/experimental feature
2508         https://bugs.webkit.org/show_bug.cgi?id=193685
2509         <rdar://problem/47450399>
2510
2511         Reviewed by Brent Fulgham.
2512
2513         Added test option adClickAttributionEnabled.
2514
2515         * DumpRenderTree/TestOptions.cpp:
2516         (TestOptions::TestOptions):
2517         * DumpRenderTree/TestOptions.h:
2518         * DumpRenderTree/mac/DumpRenderTree.mm:
2519         (setWebPreferencesForTestOptions):
2520
2521 2019-01-24  Antti Koivisto  <antti@apple.com>
2522
2523         [PSON] Flash on back navigation on Mac
2524         https://bugs.webkit.org/show_bug.cgi?id=193716
2525         <rdar://problem/47148458>
2526
2527         Reviewed by Chris Dumez.
2528
2529         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2530
2531         Closing of the previous page is delayed so waiting for didFinishNavigation is
2532         not sufficient to guarantee we have received all the messages. Wait for them.
2533
2534 2019-01-24  Chris Dumez  <cdumez@apple.com>
2535
2536         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2537         https://bugs.webkit.org/show_bug.cgi?id=193761
2538         <rdar://problem/47456405>
2539
2540         Reviewed by Alex Christensen.
2541
2542         Add API test coverage.
2543
2544         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2545
2546 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2547
2548         webkitpy: Missing PID in crashlog name should not be fatal
2549         https://bugs.webkit.org/show_bug.cgi?id=193771
2550
2551         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2552         of raising an exception.
2553
2554         Reviewed by Lucas Forschler.
2555
2556         * Scripts/webkitpy/port/darwin.py:
2557         (DarwinPort._merge_crash_logs):
2558
2559 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2560
2561         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2562         https://bugs.webkit.org/show_bug.cgi?id=193746
2563
2564         Reviewed by Youenn Fablet.
2565
2566         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2567         so we'd best just not call it.
2568
2569         * Scripts/webkitpy/w3c/test_exporter.py:
2570         (WebPlatformTestExporter.create_branch_with_patch):
2571
2572 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2573
2574         Move FileSystem to WTF
2575         https://bugs.webkit.org/show_bug.cgi?id=193602
2576
2577         Reviewed by Yusuke Suzuki.
2578
2579         * DumpRenderTree/win/DumpRenderTree.cpp:
2580         * TestWebKitAPI/CMakeLists.txt:
2581         * TestWebKitAPI/PlatformGTK.cmake:
2582         * TestWebKitAPI/PlatformJSCOnly.cmake:
2583         * TestWebKitAPI/PlatformPlayStation.cmake:
2584         * TestWebKitAPI/PlatformWPE.cmake:
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2587         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2588         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2589         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2590         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2591         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2592         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2593         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2594         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2595
2596 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2597
2598         [WPE] Remove hard dependency on subprocess32 for the API tests
2599
2600         Rubber-stamped by Carlos Garcia Campos.
2601
2602         * glib/api_test_runner.py:
2603         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2604         its presence only when running WPEQt tests.
2605
2606 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2607
2608         [GLIB] Expose JavaScriptCore options in GLib public API
2609         https://bugs.webkit.org/show_bug.cgi?id=188742
2610
2611         Reviewed by Michael Catanzaro.
2612
2613         Add a test for the new API.
2614
2615         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2616         (testsJSCOptions):
2617         (main):
2618
2619 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         [GTK][WPE] Support JPEG 2000 images
2622         https://bugs.webkit.org/show_bug.cgi?id=186272
2623
2624         Reviewed by Žan Doberšek.
2625
2626         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2627
2628         * gtk/jhbuild.modules:
2629         * wpe/jhbuild.modules:
2630
2631 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2632
2633         check-webkit-style should warn when using soft-linking macros in a header
2634         <https://webkit.org/b/193750>
2635
2636         Reviewed by Darin Adler.
2637
2638         * Scripts/webkitpy/style/checkers/cpp.py:
2639         (check_language): Add softlink/header check by refactoring the
2640         softlink/framework check.
2641         (CppChecker): Enable softlink/header check by default.
2642         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2643         (CppStyleTest.test_softlink_framework): Rename from
2644         CppStyleTest.test_softlink() and change test framework name in
2645         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2646         files. Set file_name for macros that only appear in headers.
2647         (CppStyleTest.test_softlink_header): Add tests for using
2648         soft-link macros in headers.
2649
2650 2019-01-23  Chris Dumez  <cdumez@apple.com>
2651
2652         Deprecate API to limit the maximum number of WebProcesses
2653         https://bugs.webkit.org/show_bug.cgi?id=193725
2654         <rdar://problem/47464879>
2655
2656         Reviewed by Geoff Garen.
2657
2658         Update existing API tests to stop using deprecated API.
2659
2660         * MiniBrowser/mac/AppDelegate.m:
2661         (defaultConfiguration):
2662         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2663         (TestWebKitAPI::TEST):
2664         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2665         (TestWebKitAPI::TEST):
2666         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2667         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2668         (TEST):
2669         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2670         (TEST):
2671
2672 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2673
2674         [ews-app] Rename ews model buildermappings to buildermapping
2675         https://bugs.webkit.org/show_bug.cgi?id=193729
2676
2677         Reviewed by Lucas Forschler.
2678
2679         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2680         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2681         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2682
2683 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2684
2685         [ews-app] Rename ews model steps to step
2686         https://bugs.webkit.org/show_bug.cgi?id=193697
2687
2688         Reviewed by Lucas Forschler.
2689
2690         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2691         (Step): Renamed Steps to Step.
2692
2693 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2694
2695         Clean up IndexedDB files between tests
2696         https://bugs.webkit.org/show_bug.cgi?id=192796
2697         <rdar://problem/46824999>
2698
2699         Reviewed by Geoffrey Garen.
2700
2701         * DumpRenderTree/mac/DumpRenderTree.mm:
2702         (runTest):
2703         * WebKitTestRunner/TestController.cpp:
2704         (WTR::TestController::resetStateToConsistentValues):
2705         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2706         (WTR::RemoveAllIndexedDatabasesCallback):
2707         (WTR::TestController::ClearIndexedDatabases):
2708         * WebKitTestRunner/TestController.h:
2709         * WebKitTestRunner/TestInvocation.cpp:
2710         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2711
2712 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2713
2714         [ews-app] Rename ews model Builds to Build
2715         https://bugs.webkit.org/show_bug.cgi?id=193695
2716
2717         Reviewed by Lucas Forschler.
2718
2719         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2720         (Build): Renamed Builds to Build.
2721
2722 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2723
2724         webkitpy: Wait longer when launching WebKitTestRunner
2725         https://bugs.webkit.org/show_bug.cgi?id=193734
2726
2727         Reviewed by Aakash Jain.
2728
2729         * Scripts/webkitpy/port/simulator_process.py:
2730         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2731
2732 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2733
2734         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2735         https://bugs.webkit.org/show_bug.cgi?id=193182
2736         <rdar://problem/47452154>
2737
2738         Reviewed by Tim Horton.
2739
2740         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2741         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2742         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2743
2744         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2745         preventing later tests from recognizing gestures.
2746
2747         * WebKitTestRunner/ios/TestControllerIOS.mm:
2748         (WTR::TestController::platformResetStateToConsistentValues):
2749
2750         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2751
2752 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2753
2754         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2755         https://bugs.webkit.org/show_bug.cgi?id=193722
2756         <rdar://problem/47481475>
2757
2758         Reviewed by Lucas Forschler.
2759
2760         iPhone and iPad ports should both use the iOS config.
2761
2762         * Scripts/webkitpy/port/ios_simulator.py:
2763         (IPhoneSimulatorPort.__init__):
2764         (IPadSimulatorPort.__init__):
2765
2766 2019-01-23  Rob Buis  <rbuis@igalia.com>
2767
2768         Update MIME type parser
2769         https://bugs.webkit.org/show_bug.cgi?id=180526
2770
2771         Reviewed by Frédéric Wang.
2772
2773         Add unit tests for both parse modes of ParsedContentType.
2774
2775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2776         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2777         (TestWebKitAPI::TEST):
2778
2779 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2780
2781         [ews-app] fetch loop should not stop on network issues
2782         https://bugs.webkit.org/show_bug.cgi?id=193666
2783
2784         Reviewed by Lucas Forschler.
2785
2786         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2787         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2788
2789 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2790
2791         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2792         https://bugs.webkit.org/show_bug.cgi?id=189165
2793         <rdar://problem/47433765>
2794
2795         Reviewed by Tim Horton.
2796
2797         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2798         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2799         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2800         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2801         would make its way to the UI process by the time the layer tree commit is finished.
2802
2803         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2804         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2805         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2806         will fail because it asks for -_autofillContext too early.
2807
2808         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2809         is handled in the UI process.
2810
2811         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2812
2813         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2814         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2815         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2816         input session.
2817
2818         (-[AutofillTestView textInputHasAutofillContext]):
2819
2820         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2821
2822         * TestWebKitAPI/cocoa/TestWKWebView.h:
2823         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2824         (nextInputSessionChangeCount):
2825
2826         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2827         This includes changing the focused element from one to another.
2828
2829         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2830         (-[TestWKWebView didStartFormControlInteraction]):
2831         (-[TestWKWebView didEndFormControlInteraction]):
2832         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2833
2834         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2835         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2836         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2837         that doesn't require an input session to one that doesn't.
2838
2839 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2840
2841         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2842         <https://webkit.org/b/193676>
2843
2844         Reviewed by Alexey Proskuryakov.
2845
2846         * Scripts/webkitpy/style/checkers/cpp.py:
2847         (check_member_initialization_list):
2848         - Don't report missing whitespace around colon if the colon at
2849           the start of the line is formatted correctly.
2850         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2851         (WebKitStyleTest.test_member_initialization_list):
2852         - Add a test for a missing permutation of existing tests.
2853         - Add a test this false-positive.
2854         - Add blank lines between subtests to make them easier to read.
2855
2856 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2857
2858         [build.webkit.org] Unit-test failure after r237113
2859         https://bugs.webkit.org/show_bug.cgi?id=193669
2860
2861         Reviewed by Michael Catanzaro.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2864         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2865         multiple or zero flags.
2866
2867 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2868
2869         Cache bytecode to disk
2870         https://bugs.webkit.org/show_bug.cgi?id=192782
2871         <rdar://problem/46084932>
2872
2873         Reviewed by Keith Miller.
2874
2875         Add test helper to execute bytecode-cache tests: it executes each test
2876         twice, the first with JSC_diskCachePath set to a temporary directory
2877         and second with JSC_forceDiskCache=true (in addition to the cache path)
2878         to guarantee that only the disk cache is being used and no new
2879         UnlinkedCodeBlocks are being created.
2880
2881         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2882         * Scripts/run-jsc-stress-tests:
2883
2884 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2885
2886         [css-logical] Implement flow-relative margin, padding and border shorthands
2887         https://bugs.webkit.org/show_bug.cgi?id=188697
2888
2889         Reviewed by Simon Fraser and Antti Koivisto.
2890
2891         * DumpRenderTree/TestOptions.cpp:
2892         (TestOptions::TestOptions):
2893         * DumpRenderTree/TestOptions.h:
2894         * DumpRenderTree/mac/DumpRenderTree.mm:
2895         (setWebPreferencesForTestOptions):
2896         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2897
2898         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2899         (JSONCSSPropertiesChecker.check_codegen_properties):
2900         Allow CSS property definitions to have a 'runtime-flag' parameter which
2901         disables the property when the specified runtime flag is disabled.
2902
2903 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2904
2905         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2906         https://bugs.webkit.org/show_bug.cgi?id=193643
2907
2908         Reviewed by Michael Catanzaro.
2909
2910         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2911         * wpe/jhbuild.modules: Ditto.
2912
2913 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2914
2915         [LFC][Floats] Take float top position into account when computing containing block height.
2916         https://bugs.webkit.org/show_bug.cgi?id=193655
2917
2918         Reviewed by Antti Koivisto.
2919
2920         * LayoutReloaded/misc/LFC-passing-tests.txt:
2921
2922 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2923
2924         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2925         <https://webkit.org/b/193645>
2926         <rdar://problem/47421574>
2927
2928         Reviewed by Alex Christensen.
2929
2930         - Now checks for local soft-linking of all frameworks that have
2931           their own *SoftLinking.{cpp,h,mm} files.
2932         - Changes softlink/uikit warning to softlink/framework.
2933
2934         * Scripts/webkitpy/style/checkers/cpp.py:
2935         (check_language):
2936         (CppChecker):
2937         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2938         (CppStyleTest):
2939
2940 2019-01-20  Saam Barati  <sbarati@apple.com>
2941
2942         Rollout r240210: It broke tests on iOS
2943         https://bugs.webkit.org/show_bug.cgi?id=193640
2944
2945         Unreviewed.
2946
2947         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2948         * Scripts/run-jsc-stress-tests:
2949
2950 2019-01-20  chris fleizach  <cfleizach@apple.com>
2951
2952         AX: Support returning relative frames for accessibility
2953         https://bugs.webkit.org/show_bug.cgi?id=193414
2954         <rdar://problem/47268501>
2955
2956         Reviewed by Zalan Bujtas.
2957
2958         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2959         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2960         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2961         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2962         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2963         (WTR::attributesOfElement):
2964         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2965
2966 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2967
2968         Unreviewed, add my new email address
2969
2970         * Scripts/webkitpy/common/config/contributors.json:
2971
2972 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2973
2974         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2975         https://bugs.webkit.org/show_bug.cgi?id=193617
2976
2977         Reviewed by Antti Koivisto.
2978
2979         * LayoutReloaded/misc/LFC-passing-tests.txt:
2980
2981 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2982
2983         Unreviewed, rolling out r240209.
2984
2985         Broke GTK/WPE injected bundle
2986
2987         Reverted changeset:
2988
2989         "AX: Support returning relative frames for accessibility"
2990         https://bugs.webkit.org/show_bug.cgi?id=193414
2991         https://trac.webkit.org/changeset/240209
2992
2993 2019-01-12  Dan Bernstein  <mitz@apple.com>
2994
2995         [Cocoa] Avoid importing directly from subumbrella frameworks
2996         https://bugs.webkit.org/show_bug.cgi?id=186016
2997         <rdar://problem/40591038>
2998
2999         Reviewed by Sam Weinig.
3000
3001         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3002           LaunchServices header.
3003         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3004           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3005         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3006           when using SDKs earlier than 10.13.
3007         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3008           and OTHER_CPLUSPLUSFLAGS.
3009         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3010           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3011         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3012           LaunchServices header.
3013
3014 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3015
3016         Cache bytecode to disk
3017         https://bugs.webkit.org/show_bug.cgi?id=192782
3018         <rdar://problem/46084932>
3019
3020         Reviewed by Keith Miller.
3021
3022         Add test helper to execute bytecode-cache tests: it executes each test
3023         twice, the first with JSC_diskCachePath set to a temporary directory
3024         and second with JSC_forceDiskCache=true (in addition to the cache path)
3025         to guarantee that only the disk cache is being used and no new
3026         UnlinkedCodeBlocks are being created.
3027
3028         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3029         * Scripts/run-jsc-stress-tests:
3030
3031 2019-01-20  chris fleizach  <cfleizach@apple.com>
3032
3033         AX: Support returning relative frames for accessibility
3034         https://bugs.webkit.org/show_bug.cgi?id=193414
3035         <rdar://problem/47268501>
3036
3037         Reviewed by Zalan Bujtas.
3038
3039         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3040         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3041         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3042         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3043         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3044         (WTR::attributesOfElement):
3045         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3046
3047 2019-01-20  Antoine Quint  <graouts@apple.com>
3048
3049         Add a POINTER_EVENTS feature flag
3050         https://bugs.webkit.org/show_bug.cgi?id=193577
3051         <rdar://problem/47408511>
3052
3053         Unreviewed. Also enable Pointer Events for iosmac.
3054
3055         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3056
3057 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3058
3059         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3060         https://bugs.webkit.org/show_bug.cgi?id=193613
3061
3062         Reviewed by Antti Koivisto.
3063
3064         * LayoutReloaded/misc/LFC-passing-tests.txt:
3065
3066 2019-01-19  Antoine Quint  <graouts@apple.com>
3067
3068         Add a POINTER_EVENTS feature flag
3069         https://bugs.webkit.org/show_bug.cgi?id=193577
3070
3071         Reviewed by Dean Jackson.
3072
3073         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3074
3075 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3076
3077         Disable the run-jsc-stress-test remote host key check [second round].
3078         https://bugs.webkit.org/show_bug.cgi?id=192988
3079
3080         Reviewed by Dewei Zhu.
3081
3082         * Scripts/run-jsc-stress-tests:
3083
3084 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3085
3086         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3087         https://bugs.webkit.org/show_bug.cgi?id=193597
3088
3089         Reviewed by Lucas Forschler.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3092
3093 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3096         https://bugs.webkit.org/show_bug.cgi?id=193595
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3101         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3102         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3103
3104 2019-01-18  Chris Dumez  <cdumez@apple.com>
3105
3106         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3107         https://bugs.webkit.org/show_bug.cgi?id=193588
3108         <rdar://problem/47131566>
3109
3110         Reviewed by Alex Christensen.
3111
3112         Add layout test coverage.
3113
3114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3115
3116 2019-01-18  Jer Noble  <jer.noble@apple.com>
3117
3118         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3119         https://bugs.webkit.org/show_bug.cgi?id=189553
3120
3121         Reviewed by Tim Horton.
3122
3123         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3124
3125         * ContentExtensionTester/Configurations/Base.xcconfig:
3126         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3127         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3128         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3129         * ImageDiff/cg/Configurations/Base.xcconfig:
3130         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3131         * MiniBrowser/Configurations/Base.xcconfig:
3132         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3133         * MobileMiniBrowser/Configurations/Base.xcconfig:
3134         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3135         * Scripts/webkitpy/style/checker.py:
3136         (_all_categories):
3137         (FileType):
3138         (CheckerDispatcher._file_type):
3139         (CheckerDispatcher._create_checker):
3140         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3141         (SDKVariantChecker):
3142         (SDKVariantChecker.__init__):
3143         (SDKVariantChecker.check):
3144         * TestWebKitAPI/Configurations/Base.xcconfig:
3145         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3146         * WebEditingTester/Configurations/Base.xcconfig:
3147         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3148         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3149         * WebKitTestRunner/Configurations/Base.xcconfig:
3150         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3151         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3152         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3153
3154 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3155
3156         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3157         <https://webkit.org/b/193568>
3158         <rdar://problem/47381130>
3159
3160         Reviewed by Alex Christensen.
3161
3162         Make sure no one re-introduces UIKit soft-linking by adding a
3163         style rule.
3164
3165         * Scripts/webkitpy/style/checkers/cpp.py:
3166         (check_language): Add softlink/uikit check.
3167         (CppChecker): Enable softlink/uikit check.
3168         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3169         (CppStyleTest): Add test for softlink/uikit.
3170
3171 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3172
3173         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3174         https://bugs.webkit.org/show_bug.cgi?id=193584
3175
3176         Change "-dev" to "-devel".
3177
3178         Reviewed by Michael Catanzaro.
3179
3180         * gtk/install-dependencies:
3181
3182 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3183
3184         webkitpy: Add iPhone and iPad ports
3185         https://bugs.webkit.org/show_bug.cgi?id=193537
3186         <rdar://problem/47353390>
3187
3188         Reviewed by Lucas Forschler.
3189
3190         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3191         ports. Note that this separation is optional, the --ios-simulator command remains.
3192
3193         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3194         (RunTest.test_device_type_test_division): Drive-by fix.
3195         (RunTest.test_device_type_specific_listing): Ditto.
3196         (RunTest.test_ipad_test_division):
3197         (RunTest):
3198         (RunTest.test_ipad_listing):
3199         * Scripts/webkitpy/port/factory.py:
3200         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3201         (PortFactory):
3202         * Scripts/webkitpy/port/ios_simulator.py:
3203         (IPhoneSimulatorPort):
3204         (IPadSimulatorPort):
3205
3206 2019-01-18  Chris Dumez  <cdumez@apple.com>
3207
3208         Regression(PSON) Scroll position is not always restored properly when navigating back
3209         https://bugs.webkit.org/show_bug.cgi?id=193578
3210         <rdar://problem/47386331>
3211
3212         Reviewed by Tim Horton.
3213
3214         Add API test coverage.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3217
3218 2019-01-18  Youenn Fablet  <youenn@apple.com>
3219
3220         Add a new SPI to request for cache storage quota increase
3221         https://bugs.webkit.org/show_bug.cgi?id=193323
3222
3223         Reviewed by Alex Christensen.
3224
3225         Implement WebsiteDataStore quota delegate to handle quota requests.
3226         By default, do not update quota.
3227         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3228
3229         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3230         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3231         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3233         * WebKitTestRunner/TestController.cpp:
3234         (WTR::TestController::allowCacheStorageQuotaIncrease):
3235         * WebKitTestRunner/TestController.h:
3236         * WebKitTestRunner/TestInvocation.cpp:
3237         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3238         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3239         (-[CacheStorageQuotaManager init]):
3240         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3241         (WTR::initializeWebViewConfiguration):
3242         (WTR::TestController::cocoaResetStateToConsistentValues):
3243         (WTR::TestController::allowCacheStorageQuotaIncrease):
3244
3245 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3246
3247         [ews-build] Pass owner to the triggered builds
3248         https://bugs.webkit.org/show_bug.cgi?id=193574
3249
3250         Reviewed by Lucas Forschler.
3251
3252         * BuildSlaveSupport/ews-build/factories.py:
3253         (BuildFactory.propertiesToPassToTriggers):
3254
3255 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-app] Send patch author as a build property
3258         https://bugs.webkit.org/show_bug.cgi?id=193560
3259
3260         Reviewed by Lucas Forschler.
3261
3262         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3263         (BugzillaPatchFetcher.fetch):
3264
3265 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3266
3267         webkitpy: Implement device type specific expected results (Follow-up fix)
3268         https://bugs.webkit.org/show_bug.cgi?id=192162
3269         <rdar://problem/46345449>
3270
3271         Unreviewed infrastructure fix.
3272
3273         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3274         (Manager.run): Don't boot a device if no tests are available to run on it.
3275
3276 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3277
3278         webkitpy: Implement device type specific expected results (Follow-up fix)
3279         https://bugs.webkit.org/show_bug.cgi?id=192162
3280         <rdar://problem/46345449>
3281
3282         Unreviewed infrastructure fix.
3283
3284         * Scripts/webkitpy/api_tests/manager.py:
3285         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3286
3287 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3288
3289         webkitpy: Implement device type specific expected results (Part 2)
3290         https://bugs.webkit.org/show_bug.cgi?id=192162
3291         <rdar://problem/46345449>
3292
3293         Rubber-stamped by Aakash Jain.
3294
3295         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3296         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3297         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3298
3299         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3300         (LayoutTestFinder.find_tests): Pass device_type through.
3301         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3302         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3303         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3304         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3305         (Manager._collect_tests): Pass device type to test finder.
3306         (Manager._needs_web_platform_test):
3307         (Manager._prepare_lists): Index _expectations by device type.
3308         (Manager._test_input_for_file):
3309         (Manager._test_is_slow): Ditto.
3310         (Manager._test_should_dump_jsconsolelog_in_stderr):
3311         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3312         (Manager._get_test_inputs):
3313         (Manager._update_worker_count):
3314         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3315         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3316         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3317         the one which runs the test.
3318         (Manager._run_test_subset):
3319         (Manager._run_tests): Index _expectations by current_device_type.
3320         (Manager._print_expectation_line_for_test): Ditto.
3321         (Manager._print_expectations_for_subset): Ditto.
3322         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3323         Unlike run, this function will behave the same regardless of what devices are available.
3324         (Manager._custom_device_for_test): Deleted.
3325         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3326         (ManagerTest.test_uses_custom_device): Deleted.
3327         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3328         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3329         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3330         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3331         all of the expectations.
3332         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3333         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3334         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3335         (TestExpectations.__init__): Allow device_type to be passed through.
3336         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3337         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3338         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3339         (summarize_results):
3340         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3341         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3342         a test ran with, one must check all expectations to find the first non-skip expectation.
3343         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3344         (RunTest.test_device_type_test_division):
3345         (RunTest):
3346         (RunTest.test_device_type_specific_listing):
3347         * Scripts/webkitpy/port/base.py:
3348         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3349         (Port.supported_device_types): The result of this function will change based on what devices are available.
3350         * Scripts/webkitpy/port/device_port.py:
3351         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3352         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3353         can be used.
3354         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3355         any, or the DEFAULT_DEVICE_TYPES of the port.
3356         * Scripts/webkitpy/port/ios.py:
3357         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3358         * Scripts/webkitpy/port/ios_simulator.py:
3359         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3360         * Scripts/webkitpy/port/watch.py:
3361         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3362         * Scripts/webkitpy/port/watch_simulator.py:
3363         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3364         * Scripts/webkitpy/xcode/device_type.py:
3365         (DeviceType):
3366         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3367
3368 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3369
3370         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3371         https://bugs.webkit.org/show_bug.cgi?id=193575
3372
3373         Reviewed by Michael Catanzaro.
3374
3375         Allow the script to run without explicit port argument because
3376         it's specific to the WPE port anyway.
3377
3378         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3379         and simplify the rest of the code accordingly.
3380
3381 2019-01-18  Charlie Turner  <cturner@igalia.com>
3382
3383         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3384         https://bugs.webkit.org/show_bug.cgi?id=192229
3385
3386         Reviewed by Xabier Rodriguez-Calvar.
3387
3388         * MiniBrowser/wpe/main.cpp:
3389         (main): Enable encrypted-media by default.
3390
3391 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3392
3393         [Flatpak] Missing KeyboardInterrupt exception handler
3394         https://bugs.webkit.org/show_bug.cgi?id=193570
3395
3396         Reviewed by Michael Catanzaro.
3397
3398         * flatpak/flatpakutils.py:
3399         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3400
3401 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3402
3403         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3404         https://bugs.webkit.org/show_bug.cgi?id=193564
3405
3406         Reviewed by Antti Koivisto.
3407
3408         * LayoutReloaded/misc/LFC-passing-tests.txt:
3409
3410 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3411
3412         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3413         https://bugs.webkit.org/show_bug.cgi?id=193562
3414
3415         Reviewed by Antti Koivisto.
3416
3417         * LayoutReloaded/misc/LFC-passing-tests.txt:
3418
3419 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3420
3421         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3422         https://bugs.webkit.org/show_bug.cgi?id=193555
3423
3424         Reviewed by Antti Koivisto.
3425
3426         * LayoutReloaded/misc/LFC-passing-tests.txt:
3427
3428 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3429
3430         [WPE] Add Qt extension
3431         https://bugs.webkit.org/show_bug.cgi?id=191464
3432
3433         Reviewed by Carlos Garcia Campos.
3434
3435         MiniBrowser and API tests for the WPE Qt API. To run the
3436         MiniBrowser a new script is introduced. Example invocation:
3437
3438         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3439
3440         Also note-worthy is the introduction of the python2-subprocess32
3441         dependency to run the GLib API tests.
3442
3443         * MiniBrowser/wpe/CMakeLists.txt:
3444         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3445         * MiniBrowser/wpe/qt/main.cpp: Added.
3446         (main):
3447         * MiniBrowser/wpe/qt/main.qml: Added.
3448         * MiniBrowser/wpe/qt/qml.qrc: Added.
3449         * Scripts/run-gtk-tests:
3450         (GtkTestRunner.is_google_test):
3451         (GtkTestRunner):
3452         (GtkTestRunner.is_qt_test):
3453         * Scripts/run-qt-wpe-minibrowser: Added.
3454         * Scripts/run-wpe-tests:
3455         (WPETestRunner):
3456         (WPETestRunner.is_google_test):
3457         (WPETestRunner.is_qt_test):
3458         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3459         (TestLoad::main):
3460         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3461         (TestLoadHtml::main):
3462         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3463         (TestLoadRequest::main):
3464         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3465         (TestRunJavaScript::main):
3466         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3467         (waitForSignal):
3468         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3469         (LoadSpy::LoadSpy):
3470         (LoadSpy::~LoadSpy):
3471         (LoadSpy::onLoadingChanged):
3472         (LoadStartedCatcher::LoadStartedCatcher):
3473         (LoadStartedCatcher::~LoadStartedCatcher):
3474         (LoadStartedCatcher::onLoadingChanged):
3475         (waitForLoadSucceeded):
3476         (waitForLoadFailed):
3477         * TestWebKitAPI/glib/CMakeLists.txt:
3478         * flatpak/flatpakutils.py:
3479         (WebkitFlatpak.load_from_args):
3480         (WebkitFlatpak.__init__):
3481         (WebkitFlatpak.clean_args):
3482         (WebkitFlatpak.run_in_sandbox):
3483         * flatpak/org.webkit.CommonModules.yaml:
3484         * flatpak/org.webkit.WPE.yaml:
3485         * flatpak/org.webkit.WPEModules.yaml:
3486         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3487         * flatpak/org.webkit.WebKit.yaml:
3488         * glib/api_test_runner.py:
3489         (TestRunner._run_test_qt):
3490         (TestRunner.is_qt_test):
3491         (TestRunner._run_test):
3492
3493 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3494
3495         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3496         https://bugs.webkit.org/show_bug.cgi?id=193494
3497         <rdar://problem/46859627>
3498
3499         Reviewed by Simon Fraser and Tim Horton.
3500
3501         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3502         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3503
3504         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3505         (WTR::UIScriptController::contentOffsetX const):
3506         (WTR::UIScriptController::contentOffsetY const):
3507         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3508         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3509         (WTR::UIScriptController::contentOffsetX const):
3510         (WTR::UIScriptController::contentOffsetY const):
3511         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3512
3513         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3514
3515         * WebKitTestRunner/TestController.cpp:
3516         (WTR::updateTestOptionsFromTestHeader):
3517         * WebKitTestRunner/TestOptions.h:
3518         (WTR::TestOptions::hasSameInitializationOptions const):
3519         * WebKitTestRunner/ios/TestControllerIOS.mm:
3520         (WTR::TestController::platformResetStateToConsistentValues):
3521         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3522         (WTR::UIScriptController::contentOffsetX const):
3523         (WTR::UIScriptController::contentOffsetY const):
3524
3525 2019-01-17  Truitt Savell  <tsavell@apple.com>
3526
3527         Unreviewed, rolling out r240124.
3528
3529         This commit broke an internal build.
3530
3531         Reverted changeset:
3532
3533         "SDK_VARIANT build destinations should be separate from non-
3534         SDK_VARIANT builds"
3535         https://bugs.webkit.org/show_bug.cgi?id=189553
3536         https://trac.webkit.org/changeset/240124
3537
3538 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3539
3540         Fix string concatenation API test after r239920
3541         https://bugs.webkit.org/show_bug.cgi?id=193551
3542         <rdar://problem/47359304>
3543
3544         Reviewed by Youenn Fablet.
3545
3546         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3547         (TestWebKitAPI::TEST):
3548         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3549         in WebKit's build configuration like it apparently is on Linux.
3550
3551 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews-build] validate-patch should handle the case when bug_id is None
3554         https://bugs.webkit.org/show_bug.cgi?id=193547
3555
3556         Reviewed by Lucas Forschler.
3557
3558         * BuildSlaveSupport/ews-build/steps.py:
3559         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3560         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3561
3562 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3563
3564         [ews-build] Add patch author information in build
3565         https://bugs.webkit.org/show_bug.cgi?id=193465
3566
3567         Reviewed by Lucas Forschler.
3568
3569         * BuildSlaveSupport/ews-build/steps.py:
3570         (ValidatePatch._is_patch_obsolete):
3571
3572 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3573
3574         [ews-build] Pass bug_id to the triggered builds
3575         https://bugs.webkit.org/show_bug.cgi?id=193548
3576
3577         Reviewed by Lucas Forschler.
3578
3579         * BuildSlaveSupport/ews-build/factories.py:
3580         (BuildFactory.propertiesToPassToTriggers):
3581
3582 2019-01-17  Jer Noble  <jer.noble@apple.com>
3583
3584         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3585         https://bugs.webkit.org/show_bug.cgi?id=189553
3586
3587         Reviewed by Tim Horton.
3588
3589         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3590
3591         * ContentExtensionTester/Configurations/Base.xcconfig:
3592         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3593         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3594         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3595         * ImageDiff/cg/Configurations/Base.xcconfig:
3596         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3597         * MiniBrowser/Configurations/Base.xcconfig:
3598         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3599         * MobileMiniBrowser/Configurations/Base.xcconfig:
3600         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3601         * Scripts/webkitpy/style/checker.py:
3602         (_all_categories):
3603         (FileType):
3604         (CheckerDispatcher._file_type):
3605         (CheckerDispatcher._create_checker):
3606         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3607         (SDKVariantChecker):
3608         (SDKVariantChecker.__init__):
3609         (SDKVariantChecker.check):
3610         * TestWebKitAPI/Configurations/Base.xcconfig:
3611         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3612         * WebEditingTester/Configurations/Base.xcconfig:
3613         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3614         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3615         * WebKitTestRunner/Configurations/Base.xcconfig:
3616         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3617         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3618         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3619
3620 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3621
3622         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3623         https://bugs.webkit.org/show_bug.cgi?id=193534
3624
3625         Reviewed by Antti Koivisto.
3626
3627         * LayoutReloaded/misc/LFC-passing-tests.txt:
3628
3629 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3630
3631         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3632         https://bugs.webkit.org/show_bug.cgi?id=193528
3633
3634         Reviewed by Antti Koivisto.
3635
3636         * LayoutReloaded/misc/LFC-passing-tests.txt:
3637
3638 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3639
3640         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3641         https://bugs.webkit.org/show_bug.cgi?id=193520
3642
3643         Reviewed by Antti Koivisto.
3644
3645         * LayoutReloaded/misc/LFC-passing-tests.txt:
3646
3647 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3648
3649         [ews-build] unapply-patch step should not update source
3650         https://bugs.webkit.org/show_bug.cgi?id=193234
3651
3652         Reviewed by Lucas Forschler.
3653
3654         * BuildSlaveSupport/ews-build/steps.py:
3655         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3656         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3657
3658 2019-01-16  Youenn Fablet  <youenn@apple.com>
3659
3660         Add a new SPI for controlling getUserMedia
3661         https://bugs.webkit.org/show_bug.cgi?id=192793
3662
3663         Reviewed by Eric Carlson.
3664
3665         * MiniBrowser/mac/WK2BrowserWindowController.m:
3666         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3667         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3668         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3669         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3670         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3671         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3672         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3673         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3674         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3675         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3676         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3677         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3678         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3679         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3680
3681 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3682
3683         [LFC][BFC] Inflow non-replaced used width should not be negative.
3684         https://bugs.webkit.org/show_bug.cgi?id=193495
3685
3686         Reviewed by Antti Koivisto.
3687
3688         * LayoutReloaded/misc/LFC-passing-tests.txt:
3689
3690 2019-01-16  Chris Dumez  <cdumez@apple.com>
3691
3692         Regression(PSON) View becomes blank after click a cross-site download link
3693         https://bugs.webkit.org/show_bug.cgi?id=193361
3694         <rdar://problem/47099573>
3695
3696         Reviewed by Geoffrey Garen.
3697
3698         Add API test coverage.
3699
3700         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3701         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3702
3703 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3704
3705         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3706         https://bugs.webkit.org/show_bug.cgi?id=193470
3707
3708         Reviewed by Antti Koivisto.
3709
3710         * LayoutReloaded/misc/LFC-passing-tests.txt:
3711
3712 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3713
3714         [LFC] Adjust margin box verification.
3715         https://bugs.webkit.org/show_bug.cgi?id=193482
3716
3717         Reviewed by Antti Koivisto.
3718
3719         * LayoutReloaded/misc/LFC-passing-tests.txt:
3720
3721 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3722
3723         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3724         https://bugs.webkit.org/show_bug.cgi?id=193451
3725
3726         Reviewed by Geoffrey Garen.
3727
3728         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3729         (TEST):
3730         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3731         (runWebsiteDataStoreCustomPaths):
3732
3733 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3734
3735         webkitpy: Support boolean simctl isAvailable
3736         https://bugs.webkit.org/show_bug.cgi?id=193472
3737         <rdar://problem/47296150>
3738
3739         Reviewed by Ryosuke Niwa.
3740
3741         * Scripts/webkitpy/xcode/simulated_device.py:
3742         (SimulatedDeviceManager._create_runtimes):
3743         (SimulatedDeviceManager._create_device_with_runtime):
3744
3745 2019-01-15  Chris Dumez  <cdumez@apple.com>
3746
3747         Unreviewed, rolling out r239993, r239995, r239997, and
3748         r239999.
3749
3750         Caused assertions under
3751         ViewGestureController::disconnectFromProcess()
3752
3753         Reverted changesets:
3754
3755         "Regression(PSON) View becomes blank after click a cross-site
3756         download link"
3757         https://bugs.webkit.org/show_bug.cgi?id=193361
3758         https://trac.webkit.org/changeset/239993
3759
3760         "Unreviewed iOS build fix after r239993."
3761         https://trac.webkit.org/changeset/239995
3762
3763         "Fix iOS build after r239993"
3764         https://bugs.webkit.org/show_bug.cgi?id=193361
3765         https://trac.webkit.org/changeset/239997
3766
3767         "Unreviewed, revert part of r239997 as it is not needed to fix
3768         the build."
3769         https://trac.webkit.org/changeset/239999
3770
3771 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3772
3773         Cannot tab out of WKWebView on macOS
3774         https://bugs.webkit.org/show_bug.cgi?id=161448
3775         <rdar://problem/28100085>
3776
3777         Reviewed by Dean Jackson.
3778
3779         Add a test that tabbing into and out of WKWebView works correctly.
3780
3781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3782         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3783         (WebKit2_CommandBackForwardTest::SetUp):
3784         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3785         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3786         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3787         (-[FocusableView canBecomeKeyView]):
3788         (TEST):
3789         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3790         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3791         (-[OffscreenWindow initWithSize:]):
3792         (-[OffscreenWindow isKeyWindow]):
3793         (-[OffscreenWindow isVisible]):
3794         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3795         (TestWebKitAPI::PlatformWebView::initialize):
3796         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3797         (-[ActiveOffscreenWindow isVisible]): Deleted.
3798         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3799
3800 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3801
3802         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3803         https://bugs.webkit.org/show_bug.cgi?id=193459
3804
3805         Reviewed by Mark Lam.
3806
3807         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3808         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3809
3810 2019-01-15  Chris Dumez  <cdumez@apple.com>
3811
3812         Regression(PSON) View becomes blank after click a cross-site download link
3813         https://bugs.webkit.org/show_bug.cgi?id=193361
3814         <rdar://problem/47099573>
3815
3816         Reviewed by Geoff Garen.
3817
3818         Add API test coverage.
3819
3820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3821         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3822
3823 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3824
3825         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3826         https://bugs.webkit.org/show_bug.cgi?id=193448
3827
3828         Reviewed by Antti Koivisto.
3829
3830         * LayoutReloaded/misc/LFC-passing-tests.txt:
3831
3832 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3833
3834         webkitpy: Implement device type specific expected results (Part 1)
3835         https://bugs.webkit.org/show_bug.cgi?id=192162
3836
3837         Reviewed by Lucas Forschler.
3838
3839         Device type specific expected results covers two related ideas. The first (covered by this change)
3840         is where to search for -expected.* files. The second is which tests to run based on the
3841         TestExpectations.txt file.
3842
3843         After this change, the baseline search path will be determined by the type of device running a
3844         test. Device type will be passed into any function which picks a file based on the baseline search
3845         path.
3846
3847         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3848         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3849         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3850         (Manager.run): Print baseline search path for each round of devices.
3851         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3852         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3853         (SingleTestRunner._expected_driver_output): Ditto.
3854         (SingleTestRunner._driver_input): Ditto.
3855         * Scripts/webkitpy/layout_tests/views/printing.py:
3856         (Printer.print_config): Move printing of baseline search path to a separate function.
3857         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3858         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3859         (Testprinter.test_print_config):
3860         (Testprinter.test_print_baseline_search_path):
3861         * Scripts/webkitpy/port/base.py:
3862         (Port.baseline_search_path): Pass device_type through.
3863         (Port._expected_baselines_for_suffixes): Ditto.
3864         (Port.expected_baselines): Ditto.
3865         (Port.expected_filename): Ditto.
3866         (Port.expected_checksum): Ditto.
3867         (Port.expected_image): Ditto.
3868         (Port.expected_audio): Ditto.
3869         (Port.expected_text): Ditto.
3870         (Port.reference_files): Ditto.
3871         (Port.tests): Ditto.
3872         (Port._expanded_paths): Ditto.
3873         (Port.skipped_layout_tests): Ditto.
3874         (Port.expectations_dict): Ditto.
3875         (Port._port_specific_expectations_files): Ditto.
3876         (Port.expectations_files): Ditto.
3877         (Port.test_search_path): Ditto.
3878         (Port._tests_for_other_platforms): Ditto.
3879         * Scripts/webkitpy/port/base_unittest.py:
3880         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3881         (PortTest.test_nonexistant_expectations): Ditto.
3882         (test_ref_tests_platform_directory): Ditto.
3883         * Scripts/webkitpy/port/darwin.py:
3884         (DarwinPort._port_specific_expectations_files): Accept device_type.
3885         * Scripts/webkitpy/port/driver.py:
3886         (DriverProxy):
3887         (DriverProxy.host): Expose _target_host for device_type information.
3888         * Scripts/webkitpy/port/gtk.py:
3889         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3890         * Scripts/webkitpy/port/ios.py:
3891         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3892         * Scripts/webkitpy/port/mac.py:
3893         (MacPort. default_baseline_search_path): Ditto.
3894         * Scripts/webkitpy/port/port_testcase.py:
3895         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3896         * Scripts/webkitpy/port/test.py:
3897         * Scripts/webkitpy/port/watch.py:
3898         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3899         * Scripts/webkitpy/port/win.py:
3900         (WinPort.test_search_path): Accept, but do not use, device_type.
3901         * Scripts/webkitpy/port/wpe.py:
3902         (WPEPort._port_specific_expectations_files): Ditto.
3903         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3904         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3905
3906 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3907
3908         [LFC] Use the containing block's padding box to position out-of-flow elements.
3909         https://bugs.webkit.org/show_bug.cgi?id=193431
3910
3911         Reviewed by Antti Koivisto.
3912
3913         * LayoutReloaded/misc/LFC-passing-tests.txt:
3914
3915 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3916
3917         Move a test implementation file that got misplaced in the Xcode project
3918
3919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3920
3921 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3922
3923         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3924         r239913, and r239914.
3925         https://bugs.webkit.org/show_bug.cgi?id=193407
3926
3927         These revisions caused an internal failure (Requested by
3928         Truitt on #webkit).
3929
3930         Reverted changesets:
3931
3932         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3933         https://bugs.webkit.org/show_bug.cgi?id=186016
3934         https://trac.webkit.org/changeset/239901
3935
3936         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3937         https://trac.webkit.org/changeset/239909
3938
3939         "Tried to fix the build."
3940         https://trac.webkit.org/changeset/239910
3941
3942         "Fixed iOS builds after r239910."
3943         https://trac.webkit.org/changeset/239912
3944
3945         "More build fixing."
3946         https://trac.webkit.org/changeset/239913
3947
3948         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3949         https://trac.webkit.org/changeset/239914
3950
3951 2019-01-14  Mark Lam  <mark.lam@apple.com>
3952
3953         Re-enable ability to build --cloop builds.
3954         https://bugs.webkit.org/show_bug.cgi?id=192955
3955         <rdar://problem/46882363>
3956
3957         Reviewed by Saam barati and Keith Miller.
3958
3959         The --cloop build option was being ignored this whole time since r236381.
3960         This patch makes it possible to build CLoop builds again.
3961
3962         * Scripts/build-jsc:
3963         * Scripts/webkitperl/FeatureList.pm:
3964         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3965
3966 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3967
3968         webkitpy: Expose device_type from host-like objects
3969         https://bugs.webkit.org/show_bug.cgi?id=193406
3970         <rdar://problem/47262305>
3971
3972         Reviewed by Lucas Forschler.
3973
3974         Devices should expose device_type. As a result, all host objects should
3975         provide a device_type property, even if they do not yet define a device_type.
3976
3977         * Scripts/webkitpy/common/system/systemhost.py:
3978         (SystemHost):
3979         (SystemHost.device_type):
3980         * Scripts/webkitpy/common/system/systemhost_mock.py:
3981         (MockSystemHost):
3982         (MockSystemHost.device_type):
3983         * Scripts/webkitpy/port/device.py:
3984         (Device):
3985         (Device.device_type):
3986         * Scripts/webkitpy/xcode/simulated_device.py:
3987         (SimulatedDeviceManager._find_exisiting_device_for_request):
3988         (SimulatedDeviceManager._disambiguate_device_type):
3989         (SimulatedDeviceManager._does_fulfill_request):
3990         (SimulatedDeviceManager.device_count_for_type):
3991         (SimulatedDeviceManager.initialize_devices):
3992         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3993         (test_available_devices):
3994         (test_swapping_devices):
3995
3996 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3997
3998         webkitpy: Support alternate simctl device list output (Follow-up fix)
3999         https://bugs.webkit.org/show_bug.cgi?id=193362
4000         <rdar://problem/47122965>
4001
4002         Rubber-stamped by Lucas Forschler.
4003
4004         * Scripts/webkitpy/xcode/simulated_device.py:
4005         (SimulatedDeviceManager.populate_available_devices):
4006
4007 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4008
4009         [iOS] Expose SPI to access the current sentence boundary and selection state
4010         https://bugs.webkit.org/show_bug.cgi?id=193398
4011         <rdar://problem/45893108>
4012
4013         Reviewed by Dean Jackson.
4014
4015         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4016         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4017         expected.
4018
4019         * TestWebKitAPI/EditingTestHarness.h:
4020         * TestWebKitAPI/EditingTestHarness.mm:
4021         (-[EditingTestHarness moveBackward]):
4022         (-[EditingTestHarness moveForward]):
4023         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4024
4025         Add a couple of new helper methods on EditingTestHarness.
4026
4027         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4028         (-[SelectionChangeObserver initWithWebView:]):
4029         (-[SelectionChangeObserver webView]):
4030         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4031         (-[SelectionChangeObserver currentSelectionAttributes]):
4032
4033 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4034
4035         [LFC][BFC] Add basic box-sizing support.
4036         https://bugs.webkit.org/show_bug.cgi?id=193392
4037
4038         Reviewed by Antti Koivisto.
4039
4040         * LayoutReloaded/misc/LFC-passing-tests.txt:
4041
4042 2019-01-14  Charlie Turner  <cturner@igalia.com>
4043
4044         [WPE] API test gardening
4045         https://bugs.webkit.org/show_bug.cgi?id=193319
4046
4047         Reviewed by Michael Catanzaro.
4048
4049         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4050         passing tests.
4051
4052 2019-01-14  Charlie Turner  <cturner@igalia.com>
4053
4054         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4055         https://bugs.webkit.org/show_bug.cgi?id=192977
4056
4057         Reviewed by Carlos Garcia Campos.
4058
4059         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4060         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4061         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4062         (TestWebKitAPI::GStreamerTest::SetUp):
4063         (TestWebKitAPI::GStreamerTest::TearDown):
4064         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4065         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4066         (TestWebKitAPI::TEST_F):
4067
4068 2019-01-14  Charlie Turner  <cturner@igalia.com>
4069
4070         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4071         https://bugs.webkit.org/show_bug.cgi?id=193332
4072
4073         Reviewed by Michael Catanzaro.
4074
4075         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4076         defined as a char16_t, which changed in ICU 59, the
4077         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4078         unsigned short. This test is relying on the behaviour that
4079         UChar=unsigned short, which doesn't hold across platforms and ICU
4080         library versions. The full fix would be a special syntax for
4081         literal characters so that these ambiguities do not arise. That
4082         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4083         (TestWebKitAPI::TEST):
4084
4085 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4086
4087         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4088
4089         * Scripts/make-dist:
4090         (Distcheck.configure):
4091
4092 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4093
4094         [ews-build] Update macOS queue configurations
4095         https://bugs.webkit.org/show_bug.cgi?id=193365
4096         <rdar://problem/47221073>
4097
4098         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4099
4100         * BuildSlaveSupport/ews-build/config.json:
4101
4102 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4103
4104         [LFC] Adjust assert for statically positioned fixed elements
4105         https://bugs.webkit.org/show_bug.cgi?id=193385
4106
4107         Reviewed by Antti Koivisto.
4108
4109         * LayoutReloaded/misc/LFC-passing-tests.txt:
4110
4111 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4112
4113         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4114         https://bugs.webkit.org/show_bug.cgi?id=193387
4115
4116         Reviewed by Carlos Garcia Campos.
4117
4118         * MiniBrowser/wpe/main.cpp:
4119         (main):
4120
4121 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4122
4123         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4124         https://bugs.webkit.org/show_bug.cgi?id=191655
4125         rdar://problem/46074680
4126
4127         Reviewed by Megan Gardner.
4128
4129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4130         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4131
4132 2019-01-12  Dan Bernstein  <mitz@apple.com>
4133
4134         [Cocoa] Avoid importing directly from subumbrella frameworks
4135         https://bugs.webkit.org/show_bug.cgi?id=186016
4136         <rdar://problem/40591038>
4137
4138         Reviewed by Sam Weinig.
4139
4140         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4141           LaunchServices header.
4142         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4143           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4144         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4145           when using SDKs earlier than 10.13.
4146         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4147           and OTHER_CPLUSPLUSFLAGS.
4148         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4149           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4150         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4151           LaunchServices header.
4152
4153 2019-01-11  John Wilander  <wilander@apple.com>
4154
4155         Compile out Web API Statistics Collection
4156         https://bugs.webkit.org/show_bug.cgi?id=193370
4157         <rdar://problem/45388584>
4158
4159         Reviewed by Brent Fulgham.
4160
4161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4162             Defined ENABLE_WEB_API_STATISTICS, off by default.
4163
4164 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4165
4166         [WPE] Add gtk-doc
4167         https://bugs.webkit.org/show_bug.cgi?id=178900
4168
4169         Reviewed by Michael Catanzaro.
4170
4171         Add Tools/gtkdoc to manifest.txt.in files.
4172         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4173
4174         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4175         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4176
4177 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4178
4179         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4180         https://bugs.webkit.org/show_bug.cgi?id=193364
4181         <rdar://problem/47214117>
4182
4183         Reviewed by Tim Horton.
4184
4185         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4186         precise, whereas dragging near the middle of the textarea does.
4187
4188         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4189         (TestWebKitAPI::TEST):
4190
4191 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4192
4193         webkitpy: Support alternate simctl device list output
4194         https://bugs.webkit.org/show_bug.cgi?id=193362
4195         <rdar://problem/47122965>
4196
4197         Reviewed by Lucas Forschler.
4198
4199         * Scripts/webkitpy/xcode/simulated_device.py:
4200         (SimulatedDeviceManager.populate_available_devices):
4201
4202 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4203
4204         [ews-build] Update macOS queue configurations
4205         https://bugs.webkit.org/show_bug.cgi?id=193365
4206
4207         Reviewed by Lucas Forschler.
4208
4209         * BuildSlaveSupport/ews-build/config.json:
4210
4211 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4212
4213         webkitpy: Incorporate device type into baseline search path
4214         https://bugs.webkit.org/show_bug.cgi?id=193356
4215         <rdar://problem/47215515>
4216
4217         Reviewed by Lucas Forschler.
4218
4219         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4220
4221         * Scripts/webkitpy/port/base.py:
4222         (Port.default_baseline_search_path): Allow device type to be passed in.
4223         * Scripts/webkitpy/port/gtk.py:
4224         (GtkPort.default_baseline_search_path): Ignore device type.
4225         * Scripts/webkitpy/port/ios.py:
4226         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4227         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4228         * Scripts/webkitpy/port/ios_device_unittest.py:
4229         (IOSDeviceTest):
4230         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4231         (IOSSimulatorTest):
4232         * Scripts/webkitpy/port/mac.py:
4233         (MacPort.default_baseline_search_path): Ignore device type.
4234         * Scripts/webkitpy/port/watch.py:
4235         (WatchPort.default_baseline_search_path): Ditto.
4236         * Scripts/webkitpy/port/win.py:
4237         (WinPort.default_baseline_search_path): Ditto.
4238         (WinCairoPort.default_baseline_search_path): Ditto.
4239         * Scripts/webkitpy/port/wpe.py:
4240         (WPEPort.default_baseline_search_path): Ditto.
4241
4242 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4243
4244         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4245         https://bugs.webkit.org/show_bug.cgi?id=193352
4246         <rdar://problem/47210736>
4247
4248         Reviewed by Lucas Forschler.
4249
4250         * Scripts/webkitpy/layout_tests/views/printing.py:
4251         (Printer.print_config): Print list on only baseline search paths which exist. 
4252         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4253         (Testprinter.test_print_config):
4254
4255 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4256
4257         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4258         https://bugs.webkit.org/show_bug.cgi?id=193340
4259
4260         Reviewed by David Kilzer.
4261
4262         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4263         (WTR::InjectedBundle::didReceiveMessageToPage):
4264         Pull the strings out into a WKRetainPtr.
4265
4266         * WebKitTestRunner/WebNotificationProvider.cpp:
4267         (WTR::WebNotificationProvider::closeWebNotification):
4268         Adopt the created value into the WKRetainPtr.
4269
4270         * WebKitTestRunner/mac/TestControllerMac.mm:
4271         (WTR::generateWhitelist):
4272         Immediately adopt a created value to avoid potential mistakes.
4273
4274 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4275
4276         Enable DFG on ARM/Linux again
4277         https://bugs.webkit.org/show_bug.cgi?id=192496
4278
4279         Reviewed by Yusuke Suzuki.
4280
4281         After changing the bytecode format DFG was disabled on all 32-bit
4282         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4283         on ARM by default.
4284
4285         * Scripts/run-jsc-stress-tests:
4286
4287 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4288
4289         Unreviewed, fix #ifdef in API test added in r239851.
4290         https://bugs.webkit.org/show_bug.cgi?id=193327
4291         rdar://problem/47093222
4292
4293         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4294
4295 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4296
4297         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4298         https://bugs.webkit.org/show_bug.cgi?id=193109
4299         <rdar://problem/44807048>
4300
4301         Reviewed by Ryosuke Niwa.
4302
4303         Introduce and respect a test option to enable the UndoManager API.
4304
4305         * WebKitTestRunner/TestController.cpp:
4306         (WTR::updateTestOptionsFromTestHeader):
4307         * WebKitTestRunner/TestOptions.h:
4308         (WTR::TestOptions::hasSameInitializationOptions const):
4309         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4310         (WTR::TestController::platformCreateWebView):
4311
4312 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4313
4314         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4315         https://bugs.webkit.org/show_bug.cgi?id=193346
4316
4317         Reviewed by Antti Koivisto.
4318
4319         * LayoutReloaded/misc/LFC-passing-tests.txt:
4320
4321 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4322
4323         Unreviewed, fix typo that breaks dashboard link.
4324
4325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4326         (WebKitBuildbot):
4327
4328 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>