Unreviewed. Add Pablo Saavedra to the list of contributors.
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
2
3         Unreviewed. Add Pablo Saavedra to the list of contributors.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2018-09-19  Philippe Normand  <pnormand@igalia.com>
8
9         [GStreamer] Add support for AV1 decoding
10         https://bugs.webkit.org/show_bug.cgi?id=189647
11
12         Reviewed by Žan Doberšek.
13
14         Add patches required for AV1 decoding support. They're all
15         upstream already and will be shipped in GStreamer 1.16. The aom
16         GStreamer plugin depends on the aom library for which there's no
17         official release yet.
18
19         * gstreamer/jhbuild.modules:
20         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
21         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
22         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
23         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
24         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
25         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
26
27 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
28
29         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
30         https://bugs.webkit.org/show_bug.cgi?id=189702
31         <rdar://problem/44541704>
32
33         Reviewed by Aakash Jain.
34
35         * Scripts/webkitpy/layout_tests/controllers/manager.py:
36         (Manager._set_up_run): Move build check and clobbering to run, since set up is
37         run multiple times for iOS simulator.
38         (Manager.run):
39
40 2018-09-18  Chris Dumez  <cdumez@apple.com>
41
42         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
43         https://bugs.webkit.org/show_bug.cgi?id=189681
44         <rdar://problem/44526171>
45
46         Reviewed by Alex Christensen and Zalan Bujtas.
47
48         Add API test coverage.
49
50         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
51         (TestWebKitAPI::didFinishNavigation):
52         (TestWebKitAPI::TEST):
53
54 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
55
56         [WPE] Implement mouse event modifiers
57         https://bugs.webkit.org/show_bug.cgi?id=189697
58
59         Reviewed by Carlos Garcia Campos.
60
61         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
62         (WTR::wkEventModifiersToWPE):
63         (WTR::EventSenderProxy::mouseDown):
64         (WTR::EventSenderProxy::mouseUp):
65
66 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
67
68         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
69         https://bugs.webkit.org/show_bug.cgi?id=185339
70
71         Reviewed by Mark Lam.
72
73         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
74         (TestWebKitAPI::ToUpperConverter::stopProducing):
75         (TestWebKitAPI::ToUpperConverter::stopConsuming):
76
77 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
78
79         Many modern media control tests leak documents in testing
80         https://bugs.webkit.org/show_bug.cgi?id=189437
81
82         Reviewed by Darin Adler.
83         
84         In order to accurately detect leaks in media controls tests which use lots of
85         SVGImages, we have to:
86         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
87           to clear references to elements.
88         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
89           to drop the last handle to the CachedResource for an SVGImage.
90         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
91           to run again after that timer has fired.
92         
93         This should fix most of the spurious leak reports involving SVGImage documents.
94
95         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
96         (WTR::InjectedBundle::reportLiveDocuments):
97         (WTR::InjectedBundle::didReceiveMessageToPage):
98
99 2018-09-17  Chris Dumez  <cdumez@apple.com>
100
101         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
102         https://bugs.webkit.org/show_bug.cgi?id=189602
103         <rdar://problem/44430549>
104
105         Reviewed by Geoff Garen.
106
107         Add API test coverage.
108
109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
110
111 2018-09-17  Philippe Normand  <pnormand@igalia.com>
112
113         [JHBuild] Update to GStreamer 1.14.3
114         https://bugs.webkit.org/show_bug.cgi?id=189450
115
116         Reviewed by Xabier Rodriguez-Calvar.
117
118         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
119
120 2018-09-17  Philippe Normand  <pnormand@igalia.com>
121
122         [JHBuild] Doesn't check sha256 sums
123         https://bugs.webkit.org/show_bug.cgi?id=189646
124
125         Reviewed by Michael Catanzaro.
126
127         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
128
129 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
130
131         Move IndexedDB to Network Process
132         https://bugs.webkit.org/show_bug.cgi?id=189415
133         <rdar://problem/44396973>
134
135         Reviewed by Chris Dumez.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
138         (TEST):
139         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
140         (TEST):
141         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
142         (TEST):
143         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
144         (TEST):
145         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
146         (TEST):
147
148 2018-09-08  Darin Adler  <darin@apple.com>
149
150         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
151         https://bugs.webkit.org/show_bug.cgi?id=189455
152
153         Reviewed by Keith Miller.
154
155         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
156         testing and even for macOS vs. iOS vs. Windows platform-specific code.
157         For now, this patch just makes corresponding changes to the copied code.
158         Later we might get better results by merging more code instead of having
159         all these separate copies.
160
161         * DumpRenderTree/AccessibilityController.cpp:
162         (AccessibilityController::makeWindowObject): Use the adopt function
163         instead of the special Adopt constructor of JSRetainPtr.
164
165         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
166
167         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
168         (allAttributesCallback): Don't adopt at this level; changed the
169         underlying function to return a JSRetainPtr so the adopt is right next
170         to the call to the create or copy function.
171         (attributesOfLinkedUIElementsCallback): Ditto.
172         (attributesOfDocumentLinksCallback): Ditto.
173         (attributesOfChildrenCallback): Ditto.
174         (parameterizedAttributeNamesCallback): Ditto.
175         (attributesOfColumnHeadersCallback): Ditto.
176         (attributesOfRowHeadersCallback): Ditto.
177         (attributesOfColumnsCallback): Ditto.
178         (attributesOfRowsCallback): Ditto.
179         (attributesOfVisibleCellsCallback): Ditto.
180         (attributesOfHeaderCallback): Ditto.
181         (rowIndexRangeCallback): Ditto.
182         (columnIndexRangeCallback): Ditto.
183         (rangeForLineCallback): Ditto.
184         (boundsForRangeCallback): Ditto.
185         (rangeForPositionCallback): Ditto.
186         (stringForRangeCallback): Ditto.
187         (attributedStringForRangeCallback): Ditto.
188         (uiElementCountForSearchPredicateCallback): Use the free adopt
189         function instead of the adopt member function.
190         (uiElementForSearchPredicateCallback): Ditto.
191         (selectTextWithCriteriaCallback): Don't adopt at this level.
192         (attributedStringForElementCallback): Ditto.
193         (setValueCallback): Use free adopt.
194         (stringAttributeValueCallback): Don't adopt at this level.
195         (uiElementArrayAttributeValueCallback): Ditto.
196         (uiElementAttributeValueCallback): Ditto.
197         (stringForTextMarkerRangeCallback): Ditto.
198         (attributedStringForTextMarkerRangeCallback): Ditto.
199         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
200         (getARIADropEffectsCallback): Ditto.
201         (getClassListCallback): Ditto.
202         (getRoleCallback): Ditto.
203         (getSubroleCallback): Ditto.
204         (getRoleDescriptionCallback): Ditto.
205         (getComputedRoleStringCallback): Ditto.
206         (getTitleCallback): Ditto.
207         (getDescriptionCallback): Ditto.
208         (getStringValueCallback): Ditto.
209         (getLanguageCallback): Ditto.
210         (getHelpTextCallback): Ditto.
211         (getOrientationCallback): Ditto.
212         (getPathDescriptionCallback): Ditto.
213         (getSelectedTextRangeCallback): Ditto.
214         (speakAsCallback): Ditto.
215         (getValueDescriptionCallback): Ditto.
216         (getAccessibilityValueCallback): Ditto.
217         (getDocumentEncodingCallback): Ditto.
218         (getDocumentURICallback): Ditto.
219         (getURLCallback): Ditto.
220         (characterAtOffsetCallback): Ditto.
221         (wordAtOffsetCallback): Ditto.
222         (lineAtOffsetCallback): Ditto.
223         (sentenceAtOffsetCallback): Ditto.
224         (stringForSelectionCallback): Ditto.
225         (getIdentifierCallback): Ditto.
226         (getTraitsCallback): Ditto.
227         (supportedActionsCallback): Ditto.
228         (mathPostscriptsDescriptionCallback): Ditto.
229         (mathPrescriptsDescriptionCallback): Ditto.
230         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
231         (AccessibilityUIElement::rangeForPosition): Ditto.
232         (AccessibilityUIElement::speakAs): Ditto.
233         (AccessibilityUIElement::pathDescription const): Ditto.
234         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
235         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
236         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
237
238         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
239         raw pointers for the results of the functions that create strings.
240         The old way was difficult to get right; the functions didn't even follow
241         the create/copy naming rule.
242
243         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
244         (_platformTypeConstructor): Use the adopt function instead of the
245         JSRetainPtr adopt constructor. Also nullptr instead of 0.
246
247         * DumpRenderTree/GCController.cpp:
248         (GCController::makeWindowObject): Use adopt function instead of constructor.
249
250         * DumpRenderTree/TestRunner.cpp:
251         (pathToLocalResourceCallback): Use adopt function instead of constructor.
252         (addDisallowedURLCallback): Ditto.
253         (addURLToRedirectCallback): Ditto.
254         (clearApplicationCacheForOriginCallback): Ditto.
255         (applicationCacheDiskUsageForOriginCallback): Ditto.
256         (decodeHostNameCallback): Don't adopt at this level.
257         (encodeHostNameCallback): Ditto.
258         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
259         (findStringCallback): Use adopt function instead of constructor.
260         (isCommandEnabledCallback): Ditto.
261         (overridePreferenceCallback): Ditto.
262         (queueLoadCallback): Ditto.
263         (queueLoadHTMLStringCallback): Ditto.
264         (queueLoadingScriptCallback): Ditto.
265         (queueNonLoadingScriptCallback): Ditto.
266         (setAuthenticationPasswordCallback): Ditto.
267         (setAuthenticationUsernameCallback): Ditto.
268         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
269         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
270         (setPOSIXLocaleCallback): Ditto.
271         (setPersistentUserStyleSheetLocationCallback): Ditto.
272         (setUserStyleSheetLocationCallback): Ditto.
273         (setValueForUserCallback): Ditto.
274         (setWillSendRequestClearHeaderCallback): Ditto.
275         (setPageVisibilityCallback): Ditto.
276         (evaluateInWebInspectorCallback): Ditto.
277         (evaluateScriptInIsolatedWorldCallback): Ditto.
278         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
279         (addOriginAccessWhitelistEntryCallback): Ditto.
280         (removeOriginAccessWhitelistEntryCallback): Ditto.
281         (setScrollbarPolicyCallback): Ditto.
282         (addUserScriptCallback): Ditto.
283         (addUserStyleSheetCallback): Ditto.
284         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
285         (authenticateSessionCallback): Ditto.
286         (getTitleTextDirectionCallback): Ditto.
287         (getInspectorTestStubURLCallback): Ditto.
288         (simulateLegacyWebNotificationClickCallback): Ditto.
289         (setTextDirectionCallback): Ditto.
290         (grantWebNotificationPermissionCallback): Ditto.
291         (denyWebNotificationPermissionCallback): Ditto.
292         (accummulateLogsForChannel): Ditto.
293         (runUIScriptCallback): Ditto.
294         (TestRunner::makeWindowObject): Ditto.
295         (TestRunner::uiScriptDidComplete): Ditto.
296         (TestRunner::setOpenPanelFiles): Ditto.
297
298         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
299         raw pointers for the results of the functions that create strings.
300
301         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
302         (AccessibilityController::platformName const): Use the adopt
303         function instead of the adopt constructor.
304
305         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
306         (createEmptyJSString): Added. This helper function makes reduces the
307         repetitive code to create empty strings.
308         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
309         (AccessibilityUIElement::identifier): Ditto.
310         (AccessibilityUIElement::traits): Ditto.
311         (AccessibilityUIElement::url): Ditto.
312         (AccessibilityUIElement::speakAs): Ditto.
313         (AccessibilityUIElement::stringForSelection): Ditto.
314         (AccessibilityUIElement::stringForRange): Ditto.
315         (AccessibilityUIElement::attributedStringForRange): Ditto.
316         (AccessibilityUIElement::attributedStringForElement): Ditto.
317         (AccessibilityUIElement::pathDescription const): Ditto.
318         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
319         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
320         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
321         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
322         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
323         (AccessibilityUIElement::attributesOfChildren): Ditto.
324         (AccessibilityUIElement::allAttributes): Ditto.
325         (AccessibilityUIElement::stringAttributeValue): Ditto.
326         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
327         (AccessibilityUIElement::role): Ditto.
328         (AccessibilityUIElement::subrole): Ditto.
329         (AccessibilityUIElement::roleDescription): Ditto.
330         (AccessibilityUIElement::computedRoleString): Ditto.
331         (AccessibilityUIElement::title): Ditto.
332         (AccessibilityUIElement::description): Ditto.
333         (AccessibilityUIElement::orientation const): Ditto.
334         (AccessibilityUIElement::stringValue): Ditto.
335         (AccessibilityUIElement::language): Ditto.
336         (AccessibilityUIElement::helpText const): Ditto.
337         (AccessibilityUIElement::valueDescription): Ditto.
338         (AccessibilityUIElement::ariaDropEffects const): Ditto.
339         (AccessibilityUIElement::boundsForRange): Ditto.
340         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
341         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
342         (AccessibilityUIElement::attributesOfColumns): Ditto.
343         (AccessibilityUIElement::attributesOfRows): Ditto.
344         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
345         (AccessibilityUIElement::attributesOfHeader): Ditto.
346         (AccessibilityUIElement::rowIndexRange): Ditto.
347         (AccessibilityUIElement::columnIndexRange): Ditto.
348         (AccessibilityUIElement::selectedTextRange): Ditto.
349         (AccessibilityUIElement::accessibilityValue const): Ditto.
350         (AccessibilityUIElement::documentEncoding): Ditto.
351         (AccessibilityUIElement::documentURI): Ditto.
352         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
353         (AccessibilityUIElement::classList const): Ditto.
354
355         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
356         createJSStringRef method to return a JSRetainPtr.
357         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
358         (-[NSString createJSStringRef]): Ditto.
359         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
360         adopt function instead of the adopt constructor.
361         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
362         (AccessibilityController::platformName const): Ditto.
363
364         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
365         (-[NSString createJSStringRef]): Return a JSRetainPtr.
366         (makeValueRefForValue): Updated for the above, no adopt needed here now.
367         (makeObjectRefForDictionary): Ditto.
368         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
369
370         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
371         (createEmptyJSString): Added. This helper function makes reduces the
372         repetitive code to create empty strings.
373         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
374         (descriptionOfElements): Ditto.
375         (selectTextParameterizedAttributeForCriteria): Ditto.
376         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
377         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
378         (AccessibilityUIElement::attributesOfChildren): Ditto.
379         (AccessibilityUIElement::allAttributes): Ditto.
380         (AccessibilityUIElement::stringAttributeValue): Ditto.
381         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
382         (AccessibilityUIElement::role): Ditto.
383         (AccessibilityUIElement::subrole): Ditto.
384         (AccessibilityUIElement::roleDescription): Ditto.
385         (AccessibilityUIElement::computedRoleString): Ditto.
386         (AccessibilityUIElement::title): Ditto.
387         (AccessibilityUIElement::description): Ditto.
388         (AccessibilityUIElement::orientation const): Ditto.
389         (AccessibilityUIElement::stringValue): Ditto.
390         (AccessibilityUIElement::language): Ditto.
391         (AccessibilityUIElement::helpText const): Ditto.
392         (AccessibilityUIElement::valueDescription): Ditto.
393         (AccessibilityUIElement::speakAs): Ditto.
394         (AccessibilityUIElement::classList const): Ditto.
395         (AccessibilityUIElement::ariaDropEffects const): Ditto.
396         (AccessibilityUIElement::rangeForLine): Ditto.
397         (AccessibilityUIElement::rangeForPosition): Ditto.
398         (AccessibilityUIElement::boundsForRange): Ditto.
399         (AccessibilityUIElement::stringForRange): Ditto.
400         (AccessibilityUIElement::attributedStringForRange): Ditto.
401         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
402         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
403         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
404         (AccessibilityUIElement::attributesOfColumns): Ditto.
405         (AccessibilityUIElement::attributesOfRows): Ditto.
406         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
407         (AccessibilityUIElement::attributesOfHeader): Ditto.
408         (AccessibilityUIElement::rowIndexRange): Ditto.
409         (AccessibilityUIElement::columnIndexRange): Ditto.
410         (AccessibilityUIElement::pathDescription const): Ditto.
411         (AccessibilityUIElement::selectedTextRange): Ditto.
412         (AccessibilityUIElement::accessibilityValue const): Ditto.
413         (AccessibilityUIElement::documentEncoding): Ditto.
414         (AccessibilityUIElement::documentURI): Ditto.
415         (AccessibilityUIElement::url): Ditto.
416         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
417         (createJSStringRef): Ditto.
418         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
419         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
420         (AccessibilityUIElement::supportedActions): Ditto.
421         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
422         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
423
424         * DumpRenderTree/mac/FrameLoadDelegate.mm:
425         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
426         Use the adopt function instead of the adopt constructor.
427         * DumpRenderTree/mac/TestRunnerMac.mm:
428         (originsArrayToJS): Ditto.
429         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
430         (TestRunner::copyEncodedHostName): Ditto.
431         (TestRunner::pathToLocalResource): Ditto.
432         (TestRunner::queueLoad): Use adopt function instead of constructor.
433         (TestRunner::findString): Ditto.
434         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
435
436         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
437         (AccessibilityController::winNotificationReceived): Use adopt function
438         instead of adopt constructor.
439         (AccessibilityController::platformName const): Ditto.
440
441         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
442         (createEmptyJSString): Added. This helper function makes reduces the
443         repetitive code to create empty strings.
444         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
445         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
446         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
447         (AccessibilityUIElement::attributesOfChildren): Ditto.
448         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
449         (AccessibilityUIElement::role): Ditto.
450         (AccessibilityUIElement::subrole): Ditto.
451         (AccessibilityUIElement::roleDescription): Ditto.
452         (AccessibilityUIElement::computedRoleString): Ditto.
453         (AccessibilityUIElement::title): Ditto.
454         (AccessibilityUIElement::description): Ditto.
455         (AccessibilityUIElement::stringValue): Ditto.
456         (AccessibilityUIElement::language): Ditto.
457         (AccessibilityUIElement::helpText const): Ditto.
458         (AccessibilityUIElement::valueDescription): Ditto.
459         (AccessibilityUIElement::ariaDropEffects const): Ditto.
460         (AccessibilityUIElement::orientation const): Ditto.
461         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
462         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
463         (AccessibilityUIElement::attributesOfColumns): Ditto.
464         (AccessibilityUIElement::attributesOfRows): Ditto.
465         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
466         (AccessibilityUIElement::attributesOfHeader): Ditto.
467         (AccessibilityUIElement::rowIndexRange): Ditto.
468         (AccessibilityUIElement::columnIndexRange): Ditto.
469         (AccessibilityUIElement::boundsForRange): Ditto.
470         (AccessibilityUIElement::stringForRange): Ditto.
471         (AccessibilityUIElement::attributedStringForRange): Ditto.
472         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
473         (AccessibilityUIElement::selectedTextRange): Ditto.
474         (AccessibilityUIElement::stringAttributeValue): Ditto.
475         (AccessibilityUIElement::accessibilityValue const): Ditto.
476         (AccessibilityUIElement::documentEncoding): Ditto.
477         (AccessibilityUIElement::documentURI): Ditto.
478         (AccessibilityUIElement::url): Ditto.
479         (AccessibilityUIElement::classList const): Ditto.
480
481         * DumpRenderTree/win/TestRunnerWin.cpp:
482         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
483         (TestRunner::copyEncodedHostName): Ditto.
484         (TestRunner::pathToLocalResource): Ditto.
485         (TestRunner::queueLoad): Ditto.
486         (TestRunner::findString): Ditto.
487         (TestRunner::inspectorTestStubURL): Ditto.
488
489         * TestRunnerShared/Bindings/JSWrapper.h:
490         (WTR::setProperty): Use adopt function instead of constructor.
491         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
492         (UIScriptContext::UIScriptContext): Ditto.
493         (UIScriptContext::runUIScript): Ditto.
494         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
495         (WTR::toDeviceOrientation): Ditto.
496
497         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
498         (nsTextCheckingType): Changed this function to not take an rvalue
499         reference to a JSRetainPtr since it doesn't take ownership.
500         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
501         for the above change.
502
503         * TestWebKitAPI/JavaScriptTest.cpp:
504         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
505         adopt member function.
506
507         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
508         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
509         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
510         adopt constructor.
511         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
512
513         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
514         Removed unneeded includes.
515         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
516         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
517         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
518
519         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
520         (_platformTypeConstructor): Use the adopt function instead of the
521         JSRetainPtr adopt constructor. Also nullptr instead of 0.
522
523         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
524         (WTR::arrayLength): Use adopt function instead of constructor.
525         (WTR::parseModifierArray): Ditto.
526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
527         (WTR::propertyValue): Ditto.
528         (WTR::dumpPath): Ditto.
529         (WTR::toJS): Ditto.
530         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
531         (WTR::TestRunner::findString): Ditto.
532         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
533         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
534         (WTR::TestRunner::setOpenPanelFiles): Ditto.
535         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
536         (WTR::AccessibilityController::platformName): Ditto.
537
538         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
539         (-[NSString createJSStringRef]): Return a JSRetainPtr.
540         This fixes storage leaks in many functions below, which were using
541         the create function and putting the value right into a JSRetainPtr
542         without adoption.
543         (WTR::createEmptyJSString): Added. This helper function reduces the
544         repetitive code to create empty strings.
545         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
546         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
547         Use createEmptyJSString, fixing a storage leak due to missing adoption.
548         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
549         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
550         (WTR::AccessibilityUIElement::allAttributes): Ditto.
551         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
552         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
553         (WTR::AccessibilityUIElement::role): Ditto.
554         (WTR::AccessibilityUIElement::subrole): Ditto.
555         (WTR::AccessibilityUIElement::roleDescription): Ditto.
556         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
557         (WTR::AccessibilityUIElement::title): Ditto.
558         (WTR::AccessibilityUIElement::orientation const): Ditto.
559         (WTR::AccessibilityUIElement::language): Ditto.
560         (WTR::AccessibilityUIElement::valueDescription): Ditto.
561         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
562         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
563         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
564         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
565         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
566         Use createEmptyJSString, fixing a storage leak due to missing adoption.
567         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
568         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
569         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
570         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
571         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
572         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
573         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
574         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
575         (WTR::AccessibilityUIElement::documentURI): Ditto.
576         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
577         null check.
578         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
579         Use createEmptyJSString, fixing a storage leak due to missing adoption.
580
581         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
582         Use JSRetainPtr for the return value of createJSStringRef.
583         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
584         (-[NSString createJSStringRef]): Ditto.
585         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
586         adopt function instead of the adopt constructor.
587         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
588         (WTR::AccessibilityController::platformName): Ditto
589
590         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
591         (-[NSString createJSStringRef]): Return a JSRetainPtr.
592         (makeValueRefForValue): Updated for above by removing adopt.
593         (makeObjectRefForDictionary): Ditto.
594         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
595
596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
597         (WTR::createEmptyJSString): Added. This helper function makes reduces the
598         repetitive code to create empty strings.
599         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
600         (WTR::descriptionOfElements): Ditto.
601         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
602         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
603         fixing a storage leak due to missing adoption.
604         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
605         (WTR::AccessibilityUIElement::documentURI): Ditto.
606         (WTR::createJSStringRef): Return a JSRetainPtr.
607
608         * WebKitTestRunner/StringFunctions.h:
609         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
610         (WTR::toJS): Use the adopt function instead of the constructor.
611
612 2018-09-14  Dean Jackson  <dino@grorg.org>
613
614         Add Justin Michaud.
615
616         * Scripts/webkitpy/common/config/contributors.json:
617
618 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
619
620         bots should pass --clobber-old-results to run-webkit-tests
621         https://bugs.webkit.org/show_bug.cgi?id=189623
622
623         Reviewed by Aakash Jain.
624
625         In order to ensure that bots to not produce confusing results due to transient execptions,
626         or run out of space if they continually hit an exception, old layout test results should be clobbered.
627
628         * BuildSlaveSupport/build.webkit.org-config/steps.py:
629         (RunWebKitTests):
630
631 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
632
633         Unreviewed, rolling out r235954.
634
635         Breaks the watchOS build.
636
637         Reverted changeset:
638
639         "Move IndexedDB to Network Process"
640         https://bugs.webkit.org/show_bug.cgi?id=189415
641         https://trac.webkit.org/changeset/235954
642
643 2018-09-13  Daniel Bates  <dabates@apple.com>
644
645         Add Copy WebKit Permalink plugin for Sublime Text
646         https://bugs.webkit.org/show_bug.cgi?id=189589
647
648         Rubber-stamped by Joseph Pecoraro.
649
650         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
651         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
652         active document with or without blame annotations.
653
654         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
655         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
656         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
657         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
658         and Command + Shift + Control + Option + C, respectively.
659
660         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
661         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
662         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
663         * CopyPermalink/Sublime Text/INSTALL: Added.
664         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
665         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
666         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
667
668 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
669
670         Unreviewed. Fix WebDriver tests after r235225.
671
672         Use wpt serve command to run the http server.
673
674         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
675         (WebDriverW3CWebServer.__init__):
676         (WebDriverW3CWebServer.start):
677         (WebDriverW3CWebServer.stop):
678
679 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
680
681         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
682         https://bugs.webkit.org/show_bug.cgi?id=189544
683
684         Reviewed by Michael Catanzaro.
685
686         Add test cases for the new API.
687
688         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
689         (testWebViewJavaScriptDialogs):
690
691 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
692
693         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
694         https://bugs.webkit.org/show_bug.cgi?id=189496
695         <rdar://problem/44370981>
696
697         Unreviewed warning fix.
698
699         r235929 has introduced a new compilation warning:
700         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
701
702         * ImageDiff/cairo/PlatformImageCairo.cpp:
703         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
704
705 2018-09-12  Dan Bernstein  <mitz@apple.com>
706
707         [Cocoa] Complete support for Paste as Quotation
708         https://bugs.webkit.org/show_bug.cgi?id=189504
709
710         Reviewed by Wenson Hsieh.
711
712         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
713
714 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
715
716         Move IndexedDB to Network Process
717         https://bugs.webkit.org/show_bug.cgi?id=189415
718
719         Reviewed by Geoffrey Garen.
720
721         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
722         (TEST):
723         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
724         (TEST):
725         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
726         (TEST):
727         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
728         (TEST):
729         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
730         (TEST):
731
732 2018-09-12  Chris Dumez  <cdumez@apple.com>
733
734         PSON: No process swap on back navigation after URL bar navigation
735         https://bugs.webkit.org/show_bug.cgi?id=189557
736         <rdar://problem/44353108>
737
738         Reviewed by Alex Christensen.
739
740         Add API test coverage.
741
742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
743
744 2018-09-11  Dean Jackson  <dino@apple.com>
745
746         Header parsing for experimental and internal debug features
747         https://bugs.webkit.org/show_bug.cgi?id=189486
748         <rdar://problem/44320618>
749
750         Reviewed by Tim Horton.
751
752         Keep track of experimental and internal debug features in TestOptions, and
753         allow webkit-test-runner headers to toggle them by name.
754
755         * DumpRenderTree/TestOptions.cpp:
756         (TestOptions::TestOptions):
757         * WebKitTestRunner/TestController.cpp:
758         (WTR::TestController::resetPreferencesToConsistentValues):
759         (WTR::updateTestOptionsFromTestHeader):
760         * WebKitTestRunner/TestOptions.h:
761         (WTR::TestOptions::hasSameInitializationOptions const):
762
763 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
764
765         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
766         https://bugs.webkit.org/show_bug.cgi?id=189492
767
768         Reviewed by Alex Christensen.
769
770         0 and nullptr can't be implicitly converted to
771         AccessibilityUIElement because only Windows port typedefs
772         PlatformUIElement as COMPtr<IAccessible> not a pointer.
773
774         Replaced "return 0" and "return nullptr" with "return { nullptr }".
775
776         * DumpRenderTree/AccessibilityUIElement.cpp:
777         (AccessibilityUIElement::horizontalScrollbar const):
778         (AccessibilityUIElement::verticalScrollbar const):
779         (AccessibilityUIElement::uiElementAttributeValue const):
780         (AccessibilityUIElement::accessibilityElementForTextMarker):
781         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
782         (AccessibilityController::elementAtPoint):
783         (AccessibilityController::accessibleElementById):
784         (AccessibilityController::focusedElement):
785         (AccessibilityController::rootElement):
786         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
787         (AccessibilityUIElement::elementAtPoint):
788         (AccessibilityUIElement::linkedUIElementAtIndex):
789         (AccessibilityUIElement::getChildAtIndex):
790         (AccessibilityUIElement::titleUIElement):
791         (AccessibilityUIElement::parentElement):
792         (AccessibilityUIElement::uiElementForSearchPredicate):
793         (AccessibilityUIElement::cellForColumnAndRow):
794         (AccessibilityUIElement::disclosedRowAtIndex):
795         (AccessibilityUIElement::ariaOwnsElementAtIndex):
796         (AccessibilityUIElement::ariaFlowToElementAtIndex):
797         (AccessibilityUIElement::ariaControlsElementAtIndex):
798         (AccessibilityUIElement::selectedRowAtIndex):
799         (AccessibilityUIElement::rowAtIndex):
800         (AccessibilityUIElement::disclosedByRow):
801         (AccessibilityUIElement::selectedChildAtIndex const):
802
803 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
804
805         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
806         https://bugs.webkit.org/show_bug.cgi?id=189382
807
808         Reviewed by Ryosuke Niwa.
809
810         Fix the test by specifying colors in RGB colorspace.
811
812         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
813         (TestWebKitAPI::TEST):
814
815 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
816
817         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
818         https://bugs.webkit.org/show_bug.cgi?id=189496
819
820         Reviewed by Alex Christensen.
821
822         * ImageDiff/cairo/PlatformImageCairo.cpp:
823         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
824         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
825
826 2018-09-07  Dean Jackson  <dino@apple.com>
827
828         Add and expose Internal features from WebKit
829         https://bugs.webkit.org/show_bug.cgi?id=189442
830         <rdar://problem/44243404>
831
832         Reviewed by Simon Fraser.
833
834         Update MiniBrowser to expose an Internal feature menu.
835
836         * MiniBrowser/mac/AppDelegate.m:
837         (defaultConfiguration):
838         * MiniBrowser/mac/SettingsController.m:
839         (-[SettingsController _populateMenu]):
840         (-[SettingsController validateMenuItem:]):
841         (-[SettingsController toggleExperimentalFeature:]):
842         (-[SettingsController toggleInternalDebugFeature:]):
843
844 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         [macOS] [WK2] Support changing foreground colors via color panel
847         https://bugs.webkit.org/show_bug.cgi?id=189382
848         <rdar://problem/44227311>
849
850         Reviewed by Ryosuke Niwa.
851
852         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
853         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
854         colors, as well as making different parts of a word different colors.
855
856         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
857         (-[TestWKWebView collapseToEnd]):
858         (webViewForFontManagerTesting):
859         (TestWebKitAPI::TEST):
860         * TestWebKitAPI/cocoa/TestWKWebView.h:
861
862 == Rolled over to ChangeLog-2018-09-11 ==