requestAnimationFrame should execute before the next frame
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2
3         requestAnimationFrame should execute before the next frame
4         https://bugs.webkit.org/show_bug.cgi?id=177484
5
6         Reviewed by Simon Fraser.
7
8         Add trace points for the page RenderingUpdate.
9
10         * Tracing/SystemTracePoints.plist:
11
12 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
13
14         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
15         https://bugs.webkit.org/show_bug.cgi?id=196760
16
17         Reviewed by Don Olmstead.
18
19         vswhere.exe has been bundled since Visual Studio 2017 version
20         15.2. We shouldn't download vswhere.exe.
21
22         * Scripts/build-jsc: Do not call update-vswhere.py.
23         * Scripts/build-webkit: Ditto.
24         * Scripts/update-vswhere.py: Removed.
25         * Scripts/webkitdirs.pm:
26         (requireModulesForVSWhere): Deleted.
27         (pickCurrentVisualStudioInstallation): Deleted.
28         (visualStudioInstallDirVSWhere): Return the latest installed VS
29         installation path by using the bundled vswhere.exe.
30         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
31         (visualStudioInstallDirFallback): Removed.
32
33 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
34
35         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
36         https://bugs.webkit.org/show_bug.cgi?id=196780
37
38         Reviewed by Alexey Proskuryakov.
39
40         * BuildSlaveSupport/ews-build/steps.py:
41         * BuildSlaveSupport/ews-build/steps_unittest.py:
42
43 2019-04-10  Alex Christensen  <achristensen@webkit.org>
44
45         Add SPI WKNavigationResponse._downloadAttribute
46         https://bugs.webkit.org/show_bug.cgi?id=196755
47         <rdar://49587365>
48
49         Reviewed by Brady Eidson.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
52         (-[NavigationResponseTestDelegate navigationResponse]):
53         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
54         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
55         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
56         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
57         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
58         (readRequest):
59         (writeResponse):
60         (TEST):
61
62 2019-04-10  Tim Horton  <timothy_horton@apple.com>
63
64         Add modern API for overriding the page's specified viewport configuration
65         https://bugs.webkit.org/show_bug.cgi?id=167734
66         <rdar://problem/30331795>
67
68         Reviewed by Simon Fraser.
69
70         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
71         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
72
73 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
74
75         Add support for incremental bytecode cache updates
76         https://bugs.webkit.org/show_bug.cgi?id=195000
77
78         Reviewed by Filip Pizlo.
79
80         Exit when the initial run to generate bytecode fails.
81
82         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
83
84 2019-04-10  Alex Christensen  <achristensen@webkit.org>
85
86         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
87         https://bugs.webkit.org/show_bug.cgi?id=196744
88         <rdar://49415309>
89
90         Reviewed by Chris Dumez.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
93         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
94
95 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
96
97         Add a way to opt into modern compatibility mode in layout tests
98         https://bugs.webkit.org/show_bug.cgi?id=196770
99         <rdar://problem/49777550>
100
101         Reviewed by Antoine Quint.
102
103         Add a new test option to enable modern compatibility mode in layout tests.
104
105         * WebKitTestRunner/TestController.cpp:
106         (WTR::updateTestOptionsFromTestHeader):
107         * WebKitTestRunner/TestController.h:
108         * WebKitTestRunner/TestOptions.h:
109         (WTR::TestOptions::hasSameInitializationOptions const):
110         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
111         (WTR::TestController::platformCreateWebView):
112         (WTR::TestController::enableModernCompatibilityMode):
113
114 2019-04-10  Andy Estes  <aestes@apple.com>
115
116         Try to fix the 32-bit watchOS build.
117
118         * TestWebKitAPI/cocoa/TestWKWebView.mm:
119         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
120
121 2019-04-10  Antoine Quint  <graouts@apple.com>
122
123         Enable Pointer Events on watchOS
124         https://bugs.webkit.org/show_bug.cgi?id=196771
125         <rdar://problem/49040909>
126
127         Reviewed by Dean Jackson.
128
129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
130
131 2019-04-10  Philippe Normand  <pnormand@igalia.com>
132
133         Unreviewed. Fix WPE accessibility tests after r244059.
134
135         We are failing to load the injected bundle due to undefined symbol
136         AccessibilityUIElement::replaceTextInRange().
137
138         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
139         (WTR::AccessibilityUIElement::replaceTextInRange):
140
141 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
142
143         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
144         https://bugs.webkit.org/show_bug.cgi?id=196727
145
146         Reviewed by Fujii Hironori.
147
148         * MiniBrowser/win/WebKitBrowserWindow.cpp:
149         (WebKitBrowserWindow::create):
150
151 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-build] Add unit tests for PrintConfiguration
154         https://bugs.webkit.org/show_bug.cgi?id=196752
155
156         Reviewed by Dewei Zhu.
157
158         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
159
160 2019-04-09  Keith Rollin  <krollin@apple.com>
161
162         Unreviewed build maintenance -- update .xcfilelists.
163
164         * DumpRenderTree/DerivedSources-input.xcfilelist:
165         * DumpRenderTree/DerivedSources-output.xcfilelist:
166
167 2019-04-09  Zalan Bujtas  <zalan@apple.com>
168
169         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
170         https://bugs.webkit.org/show_bug.cgi?id=196743
171         <rdar://problem/43897551>
172
173         Reviewed by Tim Horton.
174
175         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
176         (TEST):
177
178 2019-04-09  Youenn Fablet  <youenn@apple.com>
179
180         Close service worker database on network process suspension
181         https://bugs.webkit.org/show_bug.cgi?id=196623
182         <rdar://problem/48930869>
183
184         Reviewed by Alex Christensen.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
187
188 2019-04-09  Daniel Bates  <dabates@apple.com>
189
190         [iPad] Should open popover when the spacebar is pressed
191         https://bugs.webkit.org/show_bug.cgi?id=196360
192         <rdar://problem/49389129>
193
194         Reviewed by Brent Fulgham.
195
196         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
197
198         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
199         (WTR::UIScriptController::isShowingPopover const): Added.
200         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
201         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
202         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
203         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
204         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
205         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
206         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
207         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
208         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
209         (WTR::UIScriptController::isShowingPopover const): Added.
210         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
211         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
212         * TestRunnerShared/UIScriptContext/UIScriptController.h:
213         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
214         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
215         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
216         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
217         (-[TestRunnerWKWebView _willPresentPopover]): Added.
218         (-[TestRunnerWKWebView _didDismissPopover]): Added.
219         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
220         (WTR::UIScriptController::isShowingPopover const): Added.
221         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
222         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
223
224 2019-04-09  Alex Christensen  <achristensen@webkit.org>
225
226         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
227         https://bugs.webkit.org/show_bug.cgi?id=196665
228         <rdar://45115669>
229
230         Reviewed by Geoff Garen.
231
232         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
233         (goBack):
234         (+[SimpleLookupContext sharedLookupContext]):
235         (-[SimpleLookupContext lookUpURL:completionHandler:]):
236         (TEST):
237         (+[Simple3LookupContext sharedLookupContext]): Deleted.
238         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
239
240 2019-04-09  John Wilander  <wilander@apple.com>
241
242         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
243         https://bugs.webkit.org/show_bug.cgi?id=196558
244         <rdar://problem/47650245>
245
246         Reviewed by Youenn Fablet.
247
248         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
249         (TestWebKitAPI::TEST):
250             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
251
252 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
253
254         [CMake] Apple builds should use ICU_INCLUDE_DIRS
255         https://bugs.webkit.org/show_bug.cgi?id=196720
256
257         Reviewed by Konstantin Tokarev.
258
259         * TestWebKitAPI/PlatformMac.cmake:
260
261 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
262
263         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
264         https://bugs.webkit.org/show_bug.cgi?id=196694
265         <rdar://problem/48388734>
266
267         Rubber-stamped by Aakash Jain.
268
269         * Scripts/webkitpy/port/image_diff.py:
270         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
271         * Scripts/webkitpy/port/server_process.py:
272         (ServerProcess.has_available_stdout): Check if stdout has data in it.
273         (ServerProcess._wait_for_data_and_update_buffers_using_select):
274         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
275         * Scripts/webkitpy/port/server_process_mock.py:
276         (MockServerProcess.has_available_stdout):
277         * Scripts/webkitpy/port/server_process_unittest.py:
278         (TestServerProcess.serial_test_basic):
279
280 2019-04-09  Jer Noble  <jer.noble@apple.com>
281
282         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
283         https://bugs.webkit.org/show_bug.cgi?id=196097
284
285         Reviewed by Eric Carlson.
286
287         Drive-by bug fix: allow tests to play audio without a user gesture by default.
288
289         * DumpRenderTree/mac/DumpRenderTree.mm:
290         (resetWebPreferencesToConsistentValues):
291         * WebKitTestRunner/TestController.cpp:
292         (WTR::TestController::resetPreferencesToConsistentValues):
293
294 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
295
296         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
297         https://bugs.webkit.org/show_bug.cgi?id=196690
298
299         Reviewed by Michael Catanzaro.
300
301         * QueueStatusServer/config/queues.py:
302         * Scripts/webkitpy/common/config/ews.json:
303         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
304         (test_ews_name):
305
306 2019-04-09  Chris Dumez  <cdumez@apple.com>
307
308         Loads using loadHTMLString() cause flashing when process-swapping
309         https://bugs.webkit.org/show_bug.cgi?id=196714
310         <rdar://problem/49637354>
311
312         Reviewed by Antti Koivisto.
313
314         Add API test coverage.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
317
318 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
319
320         Unreviewed. Fix ATK accessibility tests after r244059.
321
322         We are failing to load the injected bundle due to undefined symbol
323         AccessibilityUIElement::replaceTextInRange().
324
325         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
326         (WTR::AccessibilityUIElement::replaceTextInRange):
327
328 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
329
330         AX: Support API: accessibilityReplaceRange:withText
331         https://bugs.webkit.org/show_bug.cgi?id=196636
332
333         Unreviewed build fix for Windows port.
334
335         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
336         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
337
338 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
339
340         [CMake][WinCairo] Separate copied headers into different directories
341         https://bugs.webkit.org/show_bug.cgi?id=196655
342
343         Reviewed by Michael Catanzaro.
344
345         * DumpRenderTree/CMakeLists.txt:
346         * MiniBrowser/win/CMakeLists.txt:
347         * TestWebKitAPI/CMakeLists.txt:
348         * TestWebKitAPI/PlatformWin.cmake:
349
350 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
351
352         Log stack-trace for run-webkit-tests when interrupted
353         https://bugs.webkit.org/show_bug.cgi?id=176393
354         <rdar://problem/34262310>
355
356         Reviewed by Lucas Forschler.
357
358         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
359         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
360         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
361         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
362         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
364         (main): Set handlers to log stack trace on interruption.
365
366 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
367
368         AX: Support API: accessibilityReplaceRange:withText
369         https://bugs.webkit.org/show_bug.cgi?id=196636
370
371         Unreviewed build fix for Windows port.
372
373         * DumpRenderTree/AccessibilityUIElement.cpp:
374         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
375
376 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
377
378         [ews-build] Scripts using Buildbot API have CORS error
379         https://bugs.webkit.org/show_bug.cgi?id=196709
380
381         Reviewed by Alexey Proskuryakov.
382
383         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
384
385 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
386
387         AX: Support API: accessibilityReplaceRange:withText
388         https://bugs.webkit.org/show_bug.cgi?id=196636
389
390         Reviewed by Daniel Bates.
391
392         * DumpRenderTree/AccessibilityUIElement.cpp:
393         (replaceTextInRangeCallback):
394         (AccessibilityUIElement::replaceTextInRange):
395         (AccessibilityUIElement::getJSClass):
396         * DumpRenderTree/AccessibilityUIElement.h:
397         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
398         (AccessibilityUIElement::replaceTextInRange):
399         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
400         (AccessibilityUIElement::replaceTextInRange):
401         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
402         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
403         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
404         (WTR::AccessibilityUIElement::replaceTextInRange):
405         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
406         (WTR::AccessibilityUIElement::replaceTextInRange):
407
408 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
409
410         [iOS] Do not allow starting selection drags when selection views are not visible
411         https://bugs.webkit.org/show_bug.cgi?id=196686
412         <rdar://problem/49399192>
413
414         Reviewed by Tim Horton.
415
416         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
417         also add some new API tests to cover scenarios where the web view is not first responder.
418
419         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
420         (TestWebKitAPI::TEST):
421         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
422
423         Add a switch to optionally make the web view first responder when starting the simulated drag.
424
425         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
426         (-[DragAndDropSimulator initWithWebView:]):
427         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
428
429 2019-04-08  Justin Fan  <justin_fan@apple.com>
430
431         [Web GPU] Fix Web GPU experimental feature on iOS
432         https://bugs.webkit.org/show_bug.cgi?id=196632
433
434         Reviewed by Myles C. Maxfield.
435
436         Properly make Web GPU available on iOS 11+.
437
438         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
439
440 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
441
442         [ews-build] Do not upload archive when Compile Fails
443         https://bugs.webkit.org/show_bug.cgi?id=196674
444
445         Reviewed by Alexey Proskuryakov.
446
447         * BuildSlaveSupport/ews-build/factories.py:
448         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
449         * BuildSlaveSupport/ews-build/steps.py:
450         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
451         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
452         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
453
454 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
455
456         Enable DFG on MIPS
457         https://bugs.webkit.org/show_bug.cgi?id=196689
458
459         Reviewed by Žan Doberšek.
460
461         Since the bytecode change, we enabled the baseline JIT on mips in
462         r240432, but DFG is still missing. With this change, all tests are
463         passing on a ci20 board.
464
465         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
466
467 2019-04-08  Philippe Normand  <pnormand@igalia.com>
468
469         [Flatpak] Second run update-webkitwpe-flatpak fails
470         https://bugs.webkit.org/show_bug.cgi?id=192702
471
472         Reviewed by Carlos Garcia Campos.
473
474         * flatpak/flatpakutils.py:
475         (FlatpakObject.flatpak): Fix typo.
476         (FlatpakPackage.install): When installing, also update to the configured remote commit.
477         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
478
479 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
480
481         [GTK][WPE] outlook.live.com displays old-fashioned UI
482         https://bugs.webkit.org/show_bug.cgi?id=196642
483
484         Reviewed by Carlos Garcia Campos.
485
486         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
487         (TestWebKitAPI::TEST): New Mac platform quirk test.
488
489 2019-04-07  Commit Queue  <commit-queue@webkit.org>
490
491         Unreviewed, rolling out r243956.
492         https://bugs.webkit.org/show_bug.cgi?id=196688
493
494         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
495         by aakashjain on #webkit).
496
497         Reverted changeset:
498
499         "Clicking "Go Back" from a safe browsing warning from an
500         iframe should navigate the WKWebView back to the previous
501         page"
502         https://bugs.webkit.org/show_bug.cgi?id=196665
503         https://trac.webkit.org/changeset/243956
504
505 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
506
507         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
508         https://bugs.webkit.org/show_bug.cgi?id=196669
509
510         Reviewed by Geoffrey Garen.
511
512         Added three new unit tests for WeakHashSet.
513
514         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
515         (WTF_WeakPtr.WeakHashSetConstObjects):
516         (WTF_WeakPtr.WeakHashSetComputesEmpty):
517         (WTF_WeakPtr.WeakHashSetComputeSize):
518
519 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
520
521         Hide next and previous form control buttons when WKWebView is editable
522         https://bugs.webkit.org/show_bug.cgi?id=196672
523         <rdar://problem/35625321>
524
525         Reviewed by Tim Horton.
526
527         Add a new API test.
528
529         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
530         (-[TestWKWebView lastTrailingBarButtonGroup]):
531         (TestWebKitAPI::TEST):
532         * TestWebKitAPI/ios/UIKitSPI.h:
533
534 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
535
536         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
537         https://bugs.webkit.org/show_bug.cgi?id=196077
538         <rdar://problem/49108202>
539
540         Reviewed by Chris Dumez.
541
542         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
543         on new web view.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
546
547 2019-04-05  Saam Barati  <sbarati@apple.com>
548
549         Make compare-results understand MotionMark
550         https://bugs.webkit.org/show_bug.cgi?id=196666
551
552         Reviewed by Yusuke Suzuki.
553
554         * Scripts/compare-results:
555         (PLT5Results):
556         (detectMotionMark):
557         (detectMotionMark1_1):
558         (motionMarkResults):
559         (motionMark1_1Results):
560         (detectBenchmark):
561         (biggerIsBetter):
562         (main):
563
564 2019-04-05  Alex Christensen  <achristensen@webkit.org>
565
566         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
567         https://bugs.webkit.org/show_bug.cgi?id=196665
568         <rdar://45115669>
569
570         Reviewed by Geoff Garen.
571
572         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
573         (goBack):
574         (+[SimpleLookupContext sharedLookupContext]):
575         (-[SimpleLookupContext lookUpURL:completionHandler:]):
576         (TEST):
577         (+[Simple3LookupContext sharedLookupContext]): Deleted.
578         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
579
580 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
581
582         [ews-build] Add configuration and architecture for windows builders
583         https://bugs.webkit.org/show_bug.cgi?id=196660
584
585         Reviewed by Lucas Forschler.
586
587         * BuildSlaveSupport/ews-build/config.json:
588
589 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
590
591         webkitpy: Don't run subsequent rounds if interrupted
592         https://bugs.webkit.org/show_bug.cgi?id=196646
593
594         Reviewed by Aakash Jain.
595
596         * Scripts/webkitpy/layout_tests/controllers/manager.py:
597         (Manager.run): Bail out if interrupted.
598
599 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
600
601         Test sessionStorage in PSON private browsing mode
602         https://bugs.webkit.org/show_bug.cgi?id=196561
603
604         Reviewed by Alex Christensen.
605
606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
607
608 2019-04-05  Commit Queue  <commit-queue@webkit.org>
609
610         Unreviewed, rolling out r243833.
611         https://bugs.webkit.org/show_bug.cgi?id=196645
612
613         This change breaks build of WPE and GTK ports (Requested by
614         annulen on #webkit).
615
616         Reverted changeset:
617
618         "[CMake][WTF] Mirror XCode header directories"
619         https://bugs.webkit.org/show_bug.cgi?id=191662
620         https://trac.webkit.org/changeset/243833
621
622 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
623
624         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
625         https://bugs.webkit.org/show_bug.cgi?id=196635
626
627         Reviewed by Antti Koivisto.
628         
629         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
630         for a test to enable async frame scrolling via:
631             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
632         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
633         
634         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
635
636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
637         (WTR::InjectedBundle::beginTesting):
638         * WebKitTestRunner/TestController.cpp:
639         (WTR::TestController::resetPreferencesToConsistentValues):
640
641 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
642
643         Use a correct LC_RPATH when building with ASan
644         https://bugs.webkit.org/show_bug.cgi?id=196576
645
646         Reviewed by David Kilzer.
647
648         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
649         so that ../Frameworks is checked. This is simpler and more reliable than updating
650         each SPC service xcconfig.
651
652 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
653
654         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
655         https://bugs.webkit.org/show_bug.cgi?id=196629
656
657         Reviewed by Lucas Forschler.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
660
661 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
662
663         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
664         https://bugs.webkit.org/show_bug.cgi?id=196618
665
666         Reviewed by Lucas Forschler.
667
668         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
669         (StatusBubble): Added QUEUE_TRIGGERS.
670         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
671         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
672         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
673         its parent(builder).
674
675 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
676
677         [ews-app] Status-bubble steps are sometimes displayed in reverse order
678         https://bugs.webkit.org/show_bug.cgi?id=196625
679
680         Reviewed by Lucas Forschler.
681
682         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
683         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
684
685 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
686
687         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
688         https://bugs.webkit.org/show_bug.cgi?id=196630
689
690         Reviewed by Wenson Hsieh.
691
692         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
693
694 2019-04-04  Youenn Fablet  <youenn@apple.com>
695
696         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
697         https://bugs.webkit.org/show_bug.cgi?id=196543
698
699         Reviewed by Alex Christensen.
700
701         * WebKitTestRunner/TestController.cpp:
702         (WTR::TestController::generatePageConfiguration):
703
704 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
705
706         [ews-app] Status bubble should not display skipped buildbot steps
707         https://bugs.webkit.org/show_bug.cgi?id=196584
708
709         Reviewed by Lucas Forschler.
710
711         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
712
713 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
714
715         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
716         https://bugs.webkit.org/show_bug.cgi?id=196620
717
718         Reviewed by Lucas Forschler.
719
720         * BuildSlaveSupport/ews-app/ews/config.py:
721
722 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
723
724         [Win] DumpRenderTreeWatchDog.py is not checked into source
725         https://bugs.webkit.org/show_bug.cgi?id=196567
726         <rdar://problem/49525901>
727
728         Reviewed by Lucas Forschler.
729
730         This script is used on Win EWS bots to terminate hanging DRT processes.
731
732         * EWSTools/dumprendertreewatchdog.py: Added.
733
734 2019-04-04  Chris Dumez  <cdumez@apple.com>
735
736         Unreviewed, roll out r243858 which made tests time out.
737
738         Disable new API tests on Windows instead.
739
740         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
741         (TestWebKitAPI::TEST):
742
743 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
744
745         [ATK] Cleanup WebPageAccessibilityObjectAtk
746         https://bugs.webkit.org/show_bug.cgi?id=196537
747
748         Reviewed by Michael Catanzaro.
749
750         Also consider files under atk directories as exceptions for GObject conventions.
751
752         * Scripts/webkitpy/style/checkers/cpp.py:
753         (check_identifier_name_in_declaration):
754
755 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
756
757         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
758         https://bugs.webkit.org/show_bug.cgi?id=196588
759         <rdar://problem/49365787>
760
761         Unreviewed build fix for Windows port.
762
763         error C3861: 'kill': identifier not found
764
765         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
766         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
767
768 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
769
770         [ews-build] Cancel build and similar operations should have authentication
771         https://bugs.webkit.org/show_bug.cgi?id=196520
772
773         Reviewed by Dewei Zhu.
774
775         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
776         environment variables.
777
778 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
779
780         [ews-build] Do not trigger queues which are not in production yet
781         https://bugs.webkit.org/show_bug.cgi?id=196581
782
783         Reviewed by Dewei Zhu.
784
785         * BuildSlaveSupport/ews-build/config.json:
786
787 2019-04-03  Chris Dumez  <cdumez@apple.com>
788
789         Unreviewed, fix typo in the name of API test added in r243848.
790
791         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
792         (TestWebKitAPI::TEST):
793
794 2019-04-03  Chris Dumez  <cdumez@apple.com>
795
796         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
797         https://bugs.webkit.org/show_bug.cgi?id=196588
798         <rdar://problem/49365787>
799
800         Reviewed by Ryosuke Niwa.
801
802         Add API test coverage.
803
804         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
805         (TestWebKitAPI::nullJavaScriptCallback):
806         (TestWebKitAPI::didCrashCheckFrames):
807         (TestWebKitAPI::TEST):
808
809 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
810
811         run-webkit-tests: Upload test results (new results database)
812         https://bugs.webkit.org/show_bug.cgi?id=196577
813         <rdar://problem/34841155>
814
815         Reviewed by Lucas Forschler.
816
817         * Scripts/webkitpy/layout_tests/controllers/manager.py:
818         (Manager.run): Upload results after each device shard, since the configuration will be
819         different for each device.
820         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
821         uploaded to a results database.
822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
823         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
824
825 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
826
827         -apple-trailing-word is needed for browser detection
828         https://bugs.webkit.org/show_bug.cgi?id=196575
829
830         Unreviewed.
831
832         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
833
834 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
835
836         [CMake][WTF] Mirror XCode header directories
837         https://bugs.webkit.org/show_bug.cgi?id=191662
838
839         Reviewed by Konstantin Tokarev.
840
841         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
842         builds.
843
844         * CMakeLists.txt:
845         * DumpRenderTree/CMakeLists.txt:
846         * DumpRenderTree/PlatformWin.cmake:
847         * MiniBrowser/win/CMakeLists.txt:
848         * TestWebKitAPI/CMakeLists.txt:
849         * TestWebKitAPI/PlatformWin.cmake:
850         * WebKitTestRunner/PlatformGTK.cmake:
851         * WebKitTestRunner/PlatformWin.cmake:
852
853 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
854
855         [ews-app] Status bubble should not display certain infrastructure status messages
856         https://bugs.webkit.org/show_bug.cgi?id=196550
857
858         Reviewed by Lucas Forschler.
859
860         Do not display the steps which are un-needed for end-user. This information is still avaiable
861         if the user click on the bubble and look at the Buildbot build.
862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
863         (StatusBubble._steps_messages):
864         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
865
866 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
867
868         [ews-build] Use https for sending data to ews-app
869         https://bugs.webkit.org/show_bug.cgi?id=196492
870
871         Reviewed by Lucas Forschler.
872
873         * BuildSlaveSupport/ews-build/events.py:
874
875 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
876
877         Remove support for -apple-trailing-word
878         https://bugs.webkit.org/show_bug.cgi?id=196525
879
880         Reviewed by Zalan Bujtas.
881
882         This CSS property is nonstandard and not used.
883
884         * Scripts/webkitperl/FeatureList.pm:
885         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
886
887 2019-04-03  Youenn Fablet  <youenn@apple.com>
888
889         Add a test for DOMCache on multiple browsing in case of private browsing
890         https://bugs.webkit.org/show_bug.cgi?id=196524
891
892         Reviewed by Alex Christensen.
893
894         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
895         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
896
897 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
898
899         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
900         https://bugs.webkit.org/show_bug.cgi?id=196540
901
902         Reviewed by Aakash Jain.
903
904         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
905
906 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
907
908         Add plumbing for a compatibility mode preference in WebKit
909         https://bugs.webkit.org/show_bug.cgi?id=196005
910
911         Reviewed by Tim Horton.
912
913         Add new API tests.
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
916         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
917
918 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
919
920         [WPE][GTK] Update libsrtp dependency package for Debian
921         https://bugs.webkit.org/show_bug.cgi?id=196528
922
923         Reviewed by Frédéric Wang.
924
925         * gtk/install-dependencies:
926         * wpe/install-dependencies:
927
928 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
929
930         [WK2] Add support for Window's beforeprint / afterprint events
931         https://bugs.webkit.org/show_bug.cgi?id=196478
932         <rdar://problem/49535124>
933
934         Unreviewed build fix for MSVC.
935
936         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
937
938         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
939
940         * WebKitTestRunner/TestController.cpp:
941         (WTR::printFrame): Use int and float literals.
942
943 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
944
945         [ews-build] Reassign bots to queues
946
947         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
948
949 2019-04-02  Chris Dumez  <cdumez@apple.com>
950
951         [WK2] Add support for Window's beforeprint / afterprint events
952         https://bugs.webkit.org/show_bug.cgi?id=196478
953
954         Reviewed by Alex Christensen.
955
956         Add minimal implementation for printFrame in WebKitTestRunner.
957
958         * WebKitTestRunner/TestController.cpp:
959         (WTR::printFrame):
960         (WTR::TestController::createOtherPage):
961         (WTR::TestController::createWebViewWithOptions):
962
963 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
966         https://bugs.webkit.org/show_bug.cgi?id=196491
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
971
972 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
973
974         [ews-build] Configure buildbot try credentials in environment variables
975         https://bugs.webkit.org/show_bug.cgi?id=196501
976
977         Reviewed by Lucas Forschler.
978
979         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
980         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
981         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
982
983 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
984
985         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
986         https://bugs.webkit.org/show_bug.cgi?id=196496
987         <rdar://problem/49521634>
988
989         Reviewed by Chris Dumez.
990
991         Add new API tests (see WebKit ChangeLog for more detail).
992
993         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
994         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
995         (TEST):
996
997 2019-04-02  David Kilzer  <ddkilzer@apple.com>
998
999         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1000         <https://webkit.org/b/196499>
1001
1002         Reviewed by Alexey Proskuryakov.
1003
1004         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1005         ENABLE_ADDRESS_SANITIZER.
1006
1007 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1008
1009         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1010         https://bugs.webkit.org/show_bug.cgi?id=182757
1011
1012         Reviewed by Don Olmstead.
1013
1014         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1015         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1016
1017 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1018
1019         run-api-tests: Upload test results
1020         https://bugs.webkit.org/show_bug.cgi?id=196323
1021         <rdar://problem/49356714>
1022
1023         Reviewed by Lucas Forschler.
1024
1025         * Scripts/webkitpy/api_tests/manager.py:
1026         (Manager):
1027         (Manager.run): Upload results to a results database.
1028         * Scripts/webkitpy/api_tests/run_api_tests.py:
1029         (parse_args): Add upload arguments.
1030         * Scripts/webkitpy/port/base.py:
1031         (Port):
1032         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1033         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1034         with commits from any other associated repositories.
1035         * Scripts/webkitpy/port/device.py:
1036         (Device):
1037         (Device.build_version): Access build_versoin of underlying platform device.
1038         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1039         (IOSSimulatorTest):
1040         (IOSSimulatorTest.test_configuration_for_upload):
1041         * Scripts/webkitpy/port/device_port.py:
1042         (DevicePort):
1043         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1044         the same as the machine uploading results.
1045         * Scripts/webkitpy/port/mac.py:
1046         (MacPort):
1047         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1048         * Scripts/webkitpy/port/mac_unittest.py:
1049         (MacTest):
1050         (MacTest.test_configuration_for_upload):
1051         * Scripts/webkitpy/xcode/simulated_device.py:
1052         (SimulatedDeviceManager._create_device_with_runtime):
1053         (SimulatedDevice.__init__): Create simulated device with a build_version.
1054         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1055         (test_existing_simulator):
1056
1057 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1058
1059         Remove extra newline characters (Follow-up fix to r243707)
1060
1061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1062
1063 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1064
1065         [ews-app] Use API_KEY to accept results data
1066         https://bugs.webkit.org/show_bug.cgi?id=196461
1067
1068         Reviewed by Dewei Zhu.
1069
1070         * BuildSlaveSupport/ews-app/ews/views/results.py:
1071         (Results.post): Validate EWS_API_KEY before accepting any data.
1072         * BuildSlaveSupport/ews-build/events.py:
1073         (Events.sendData): Send EWS_API_KEY if available along with event data.
1074
1075 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1076
1077         Unable to copy and paste a PDF from Notes into Mail compose body
1078         https://bugs.webkit.org/show_bug.cgi?id=196442
1079         <rdar://problem/48573098>
1080
1081         Reviewed by Tim Horton.
1082
1083         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1084         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1085         to be specified on the item providers.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1088         (TestWebKitAPI::mapItemForTesting):
1089         (TestWebKitAPI::contactItemForTesting):
1090
1091 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1092
1093         Make UIWKDocumentContext rects per-character instead of per-word
1094         https://bugs.webkit.org/show_bug.cgi?id=196459
1095
1096         Reviewed by Wenson Hsieh.
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1099         (TEST):
1100         Adjust test results due to switching to per-character rects.
1101
1102 2019-04-01  Chris Dumez  <cdumez@apple.com>
1103
1104         UIProcess crash when a prewarmed process is terminated
1105         https://bugs.webkit.org/show_bug.cgi?id=196451
1106         <rdar://problem/49245471>
1107
1108         Reviewed by Geoffrey Garen.
1109
1110         Add API test coverage.
1111
1112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1113         (TEST):
1114
1115 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1116
1117         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1118         https://bugs.webkit.org/show_bug.cgi?id=196449
1119
1120         Reviewed by Lucas Forschler.
1121
1122         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1123         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1124         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1125         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1126
1127 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1130         https://bugs.webkit.org/show_bug.cgi?id=196444
1131
1132         Reviewed by Lucas Forschler.
1133
1134         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1135
1136 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1137
1138         Add SPI to canonicalize NSURLs with WTF::URL
1139         https://bugs.webkit.org/show_bug.cgi?id=196415
1140         <rdar://problem/44980271>
1141
1142         Reviewed by Darin Adler.
1143
1144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1145         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1146         (TestWebKitAPI::TEST):
1147
1148 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1149
1150         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1151         https://bugs.webkit.org/show_bug.cgi?id=196441
1152
1153         Reviewed by Carlos Garcia Campos.
1154
1155         Don't cache the wpe_view_backend object that might not exist yet at the
1156         time of EventSenderProxy constructor invocation, but instead retrieve
1157         that object whenever it's required for event dispatching. This should
1158         avoid crashes in this constructor now that it's invoked before any
1159         PlatformWindow has been set up (as changed in r243496).
1160
1161         * WebKitTestRunner/EventSenderProxy.h:
1162         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1163         (WTR::viewBackend):
1164         (WTR::EventSenderProxy::EventSenderProxy):
1165         (WTR::EventSenderProxy::mouseDown):
1166         (WTR::EventSenderProxy::mouseUp):
1167         (WTR::EventSenderProxy::mouseMoveTo):
1168         (WTR::EventSenderProxy::mouseScrollBy):
1169         (WTR::EventSenderProxy::keyDown):
1170         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1171
1172 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1173
1174         [Win][WebKit] MiniBrowser should support high DPI display
1175         https://bugs.webkit.org/show_bug.cgi?id=196391
1176
1177         Reviewed by Alex Christensen.
1178
1179         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1180         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1181         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1182         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1183
1184 2019-03-31  Sam Weinig  <weinig@apple.com>
1185
1186         Remove more i386 specific configurations
1187         https://bugs.webkit.org/show_bug.cgi?id=196430
1188
1189         Reviewed by Alexey Proskuryakov.
1190
1191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1192         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1193
1194 2019-03-31  Andy Estes  <aestes@apple.com>
1195
1196         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1197         https://bugs.webkit.org/show_bug.cgi?id=196433
1198         <rdar://problem/49293305>
1199
1200         Reviewed by Tim Horton.
1201
1202         Enhanced API test coverage to include all navigation response policy decisions in both
1203         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1204
1205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1206         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1207         (TestWebKitAPI::TEST):
1208         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1209         (readFile):
1210         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1211         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1212         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1213         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1214         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1215         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1216         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1217         (-[QuickLookDelegate _downloadDidStart:]):
1218         (-[QuickLookDelegate _download:didReceiveResponse:]):
1219         (-[QuickLookDelegate _download:didReceiveData:]):
1220         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1221         (-[QuickLookDelegate _downloadDidFinish:]):
1222         (-[QuickLookDelegate _download:didFailWithError:]):
1223         (-[QuickLookDelegate _downloadDidCancel:]):
1224         (-[QuickLookDelegate verifyDownload]):
1225         (runTest):
1226         (runTestDecideBeforeLoading):
1227         (runTestDecideAfterLoading):
1228         (TEST):
1229         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1230         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1231         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1232         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1233         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1234         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1235         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1236         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1237         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1238         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1239         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1240         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1241         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1242         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1243
1244 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1245
1246         [CMake] add testdfg as target with build-jsc
1247         https://bugs.webkit.org/show_bug.cgi?id=196393
1248
1249         Reviewed by Saam Barati.
1250
1251         Added testdfg as one of the targets to build when
1252         using CMake.
1253
1254         * Scripts/build-jsc:
1255
1256 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1257
1258         Delete WebMetal implementation in favor of WebGPU
1259         https://bugs.webkit.org/show_bug.cgi?id=195418
1260
1261         Reviewed by Dean Jackson.
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (enableExperimentalFeatures):
1265         (resetWebPreferencesToConsistentValues):
1266         * Scripts/webkitperl/FeatureList.pm:
1267         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1269         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1270         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1271         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1272         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1273         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1274         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1275         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1276         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1277         (WTR::InjectedBundle::beginTesting):
1278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1279         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1280         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1281
1282 2019-03-29  Chris Dumez  <cdumez@apple.com>
1283
1284         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1285         https://bugs.webkit.org/show_bug.cgi?id=196405
1286         <rdar://problem/49428130>
1287
1288         Reviewed by Wenson Hsieh.
1289
1290         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1291         the popover presentation methods to be no-ops. Use this in the new test added in
1292         r243523 so that we do not swizzle those methods for all tests. This is needed because
1293         those WatchOS tests rely on the popover getting presented and interactive.
1294
1295         * WebKitTestRunner/TestController.cpp:
1296         (WTR::updateTestOptionsFromTestHeader):
1297         * WebKitTestRunner/TestController.h:
1298         * WebKitTestRunner/TestOptions.h:
1299         (WTR::TestOptions::hasSameInitializationOptions const):
1300         * WebKitTestRunner/ios/TestControllerIOS.mm:
1301         (WTR::TestController::platformInitialize):
1302         (WTR::TestController::platformResetStateToConsistentValues):
1303
1304 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1305
1306         [Curl] Add Server Trust Evaluation Support.
1307         https://bugs.webkit.org/show_bug.cgi?id=191646
1308
1309         Reviewed by Fujii Hironori.
1310
1311         Implemented MiniBrowser UI for asking if user trusts the server.
1312
1313         * MiniBrowser/win/Common.cpp:
1314         (askServerTrustEvaluation):
1315         (replaceString):
1316         * MiniBrowser/win/Common.h:
1317         * MiniBrowser/win/MiniBrowserLib.rc:
1318         * MiniBrowser/win/MiniBrowserLibResource.h:
1319         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1320         (createPEMString):
1321         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1322         (WebKitBrowserWindow::canTrustServerCertificate):
1323         * MiniBrowser/win/WebKitBrowserWindow.h:
1324
1325 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1326
1327         Implement ResizeObserver.
1328         https://bugs.webkit.org/show_bug.cgi?id=157743
1329
1330         Reviewed by Simon Fraser.
1331
1332         Support resizeObserverEnabled webPreferences.
1333
1334         * DumpRenderTree/TestOptions.cpp:
1335         (TestOptions::TestOptions):
1336         * DumpRenderTree/TestOptions.h:
1337         * DumpRenderTree/mac/DumpRenderTree.mm:
1338         (setWebPreferencesForTestOptions):
1339         * DumpRenderTree/win/DumpRenderTree.cpp:
1340         (enableExperimentalFeatures):
1341         * Scripts/webkitperl/FeatureList.pm:
1342         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1343
1344 2019-03-28  John Wilander  <wilander@apple.com>
1345
1346         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1347         https://bugs.webkit.org/show_bug.cgi?id=196281
1348         <rdar://problem/48938748>
1349
1350         Reviewed by Alex Christensen.
1351
1352         This patch adds the function isStatisticsHasLocalStorage() to the
1353         TestRunner. With it, the page can query the WebsiteDataStore in the
1354         UI process to make sure that it sees LocalStorage.
1355
1356         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1357         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1358         (WTR::TestRunner::isStatisticsHasLocalStorage):
1359         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1360         * WebKitTestRunner/TestController.cpp:
1361         (WTR::TestController::isStatisticsHasLocalStorage):
1362         * WebKitTestRunner/TestController.h:
1363         * WebKitTestRunner/TestInvocation.cpp:
1364         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1365
1366 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1367
1368         API::Data::createWithoutCopying should do a null check before calling CFRelease
1369         https://bugs.webkit.org/show_bug.cgi?id=196276
1370         <rdar://problem/48059859>
1371
1372         Reviewed by Alex Christensen.
1373
1374         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1378         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1379         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1380         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1381         (TestWebKitAPI::TEST):
1382
1383 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1384
1385         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1386         https://bugs.webkit.org/show_bug.cgi?id=186276
1387
1388         Reviewed by Carlos Garcia Campos.
1389
1390         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1391         (webViewLoadChanged):
1392         (testWebResourceGetDataError):
1393         (testWebResourceGetDataEmpty):
1394         (beforeAll):
1395         (webViewloadChanged): Deleted.
1396
1397 2019-03-27  Andy Estes  <aestes@apple.com>
1398
1399         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1400         https://bugs.webkit.org/show_bug.cgi?id=196317
1401
1402         Reviewed by Dan Bernstein.
1403
1404         package-root copies built products into a staging directory using ditto(1), which does not
1405         follow symbolic links as it traverses a directory. Now that the files in
1406         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1407         itself, these become broken links when ditto'd into the staging directory.
1408
1409         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1410
1411         * Scripts/package-root:
1412
1413 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1414
1415         [ews-app] Update display text of Submit for ews analysis
1416         https://bugs.webkit.org/show_bug.cgi?id=196309
1417
1418         Reviewed by Dewei Zhu.
1419
1420         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1421
1422 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1423
1424         run-webkit-tests should check for leaks in WebKit processes
1425         <https://webkit.org/b/193772>
1426         <rdar://problem/46526680>
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         This works by doing the following:
1431         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1432           The list of child processes are returned one per line:
1433           process.name: pid
1434         - Run the "#LIST CHILD PROCESSES" command just before the
1435           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1436           processes on the ServerProcess object.
1437         - When the `--leaks` switch is handled, run check_for_leaks() on
1438           each child process after the main test harness.
1439
1440         * DumpRenderTree/mac/DumpRenderTree.mm:
1441         (handleControlCommand):
1442         - Use strncmp() instead of strcmp().
1443         - Add support for handling "#LIST CHILD PROCESSES" command.
1444
1445         * Scripts/webkitpy/port/base.py:
1446         (Port.check_for_leaks):
1447         * Scripts/webkitpy/port/darwin.py:
1448         (DarwinPort.check_for_leaks):
1449         - Rename redundant 'process_pid' argument to 'process_id'.
1450
1451         * Scripts/webkitpy/port/driver.py:
1452         (Driver.do_post_tests_work):
1453         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1454           longer the only command this sends to WebKitTestRunner.
1455         - If the `--leaks` switch is present, send the
1456           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1457           result using Port.set_webkit_processes().
1458         (Driver._parse_child_processes_output):
1459         - Add helper method to parse list of child process names and
1460           process IDs returned from WebKitTestRunner.
1461
1462         * Scripts/webkitpy/port/ios_device.py:
1463         (IOSDevicePort.check_for_leaks):
1464         - Rename redundant 'process_pid' argument to 'process_id'.
1465
1466         * Scripts/webkitpy/port/leakdetector.py:
1467         (LeakDetector._parse_leaks_output):
1468         - Return early if there is no leaks_output.
1469         (LeakDetector.check_for_leaks):
1470         - Rename redundant 'process_pid' argument to 'process_id'.
1471
1472         * Scripts/webkitpy/port/server_process.py:
1473         (ServerProcess.__init__):
1474         (ServerProcess.child_processes):
1475         (ServerProcess.set_child_processes):
1476         - Add instance variable to Port to store list of child process
1477           names and process IDs returned from WebKitTestRunner.
1478         (ServerProcess._start):
1479         - Clear self._child_processes.
1480         (ServerProcess.stop):
1481         - If self._child_processes is set, call
1482           self._port.check_for_leaks() for each child process.
1483
1484         * Scripts/webkitpy/port/server_process_unittest.py:
1485         (TrivialMockPort.check_for_leaks):
1486         - Rename redundant 'process_pid' argument to 'process_id'.
1487
1488         * Scripts/webkitpy/port/simulator_process.py:
1489         (SimulatorProcess.stop):
1490         - If self._child_processes is set, call
1491           self._port.check_for_leaks() for each child process.
1492
1493         * Scripts/webkitpy/port/watch_device.py:
1494         (WatchDevicePort.check_for_leaks):
1495         - Rename redundant 'process_pid' argument to 'process_id'.
1496
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::TestController::dumpResponse):
1499         - Extract method from findAndDumpWorldLeaks() so that it may be
1500           reused by findAndDumpWebKitProcessIdentifiers().
1501         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1502         - Add method to output process name and process ID of both the
1503           WebContent and Networking processes.
1504         (WTR::TestController::findAndDumpWorldLeaks):
1505         - Fix missing newline in output when there were no abandoned
1506           documents.
1507         - Call dumpResponse() for extracted code.
1508         (WTR::TestController::handleControlCommand):
1509         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1510         - Use strncmp() instead of strcmp().
1511         - Call findAndDumpWebKitProcessIdentifiers() when
1512           "#LIST CHILD PROCESSES" command is sent.
1513         * WebKitTestRunner/TestController.h:
1514         (WTR::TestController::dumpResponse):
1515         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1516         - Declare methods.
1517
1518 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1519
1520         Unreviewed. Add GLib API test cases after r243434.
1521
1522         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1523         (testWebViewActiveURI):
1524         (serverCallback):
1525         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1526         (sendRequestCallback):
1527
1528 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1529
1530         Geolocation request not complete when watch request was started in a different web process
1531         https://bugs.webkit.org/show_bug.cgi?id=195996
1532
1533         Reviewed by Alex Christensen.
1534
1535         Add a test case.
1536
1537         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1538         (TestWebKitAPI::runJavaScriptAlert):
1539         (TestWebKitAPI::TEST):
1540
1541 2019-03-26  Keith Rollin  <krollin@apple.com>
1542
1543         Update the way generate-xcfilelists returns strings from functions
1544         https://bugs.webkit.org/show_bug.cgi?id=195975
1545         <rdar://problem/49040807>
1546
1547         Reviewed by Dean Jackson.
1548
1549         There are places where generate-xcfilelists executes assignments with
1550         statements like:
1551
1552             FOO=$(some_function)
1553
1554         where "some_function" return a string by echoing it. E.g.
1555
1556             some_function()
1557             {
1558                 echo "Hello, World"
1559             }
1560
1561         This is a common idiom, but it has a problem if "some_function" needs
1562         to call "exit" in an attempt to halt the entire script right then and
1563         there. Since "some_function" is called inside of $(), it's being
1564         executed in a sub-shell. Calling exit in that sub-shell simply exits
1565         that shell; it doesn't not exit the outer shell in which the main part
1566         of the script is still running. As such, the main script keeps
1567         executing when the intent was for the script to halt.
1568
1569         The solution to this is to use a different idiom for returning
1570         strings. The one we now is to pass in the name of the variable to
1571         receive the string result:
1572
1573             some_function()
1574             {
1575                 variable_name=$1
1576                 eval $variable_name ="Hello, World"
1577             }
1578
1579         The call site now looks like
1580
1581             some_function FOO
1582
1583         Because there's no invocation of a sub-shell, some_function can now
1584         call "exit" if it wants to, and the entire script will exit at that
1585         point.
1586
1587         * Scripts/generate-xcfilelists:
1588
1589 2019-03-26  Chris Dumez  <cdumez@apple.com>
1590
1591         Add basic layout test coverage for File Picker on iOS
1592         https://bugs.webkit.org/show_bug.cgi?id=196265
1593
1594         Reviewed by Wenson Hsieh.
1595
1596         Add layout test infrastructure to test the file picker on iOS.
1597
1598         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1599         (WTR::UIScriptController::dismissFilePicker):
1600         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1601         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1602         (WTR::UIScriptController::dismissFilePicker):
1603         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1604         * WebKitTestRunner/TestController.cpp:
1605         (WTR::TestController::createWebViewWithOptions):
1606         (WTR::updateTestOptionsFromTestHeader):
1607         * WebKitTestRunner/TestOptions.h:
1608         (WTR::TestOptions::hasSameInitializationOptions const):
1609         * WebKitTestRunner/ios/TestControllerIOS.mm:
1610         (overridePresentViewController):
1611         (WTR::TestController::platformInitialize):
1612         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1613         (WTR::UIScriptController::dismissFilePicker):
1614
1615 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1616
1617         Implement async paste method on UIWKInteractionViewProtocol
1618         https://bugs.webkit.org/show_bug.cgi?id=196267
1619         <rdar://problem/49236346>
1620
1621         Reviewed by Tim Horton.
1622
1623         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1624         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1625         are now a part of all iOS 12 internal SDKs.
1626
1627         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1628
1629         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1630         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1631
1632         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1633         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1634         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1635         * TestWebKitAPI/ios/UIKitSPI.h:
1636
1637 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1638
1639         [ews-build] Use PostgreSQL for ews.webkit.org database
1640         https://bugs.webkit.org/show_bug.cgi?id=196270
1641
1642         Reviewed by Lucas Forschler.
1643
1644         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1645
1646 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1647
1648         [ews] Reset simctl states on reboot
1649         https://bugs.webkit.org/show_bug.cgi?id=196260
1650
1651         Rubber-stamped by Aakash Jain.
1652
1653         * EWSTools/start-queue-mac.sh:
1654
1655 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1656
1657         [ews-build] Use PostgreSQL for ews-build database
1658         https://bugs.webkit.org/show_bug.cgi?id=196229
1659
1660         Reviewed by Lucas Forschler.
1661
1662         * BuildSlaveSupport/ews-build/master.cfg:
1663
1664 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-build] Get master_hostname dynamically in master.cfg
1667         https://bugs.webkit.org/show_bug.cgi?id=196255
1668
1669         Reviewed by Lucas Forschler.
1670
1671         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1672         send events data in test mode.
1673
1674 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1675
1676         [ews-app] Set db_constraint to False for Foreign Keys
1677         https://bugs.webkit.org/show_bug.cgi?id=196252
1678
1679         Reviewed by Lucas Forschler.
1680
1681         * BuildSlaveSupport/ews-app/ews/models/build.py:
1682         * BuildSlaveSupport/ews-app/ews/models/step.py:
1683
1684 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1685
1686         [ews-build] is_test_mode_enabled should default to True
1687         https://bugs.webkit.org/show_bug.cgi?id=196248
1688
1689         Reviewed by Lucas Forschler.
1690
1691         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1692
1693 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1694
1695         [ews-app] Add webkitperl to ENABLED_QUEUES
1696         https://bugs.webkit.org/show_bug.cgi?id=196253
1697
1698         Reviewed by Lucas Forschler.
1699
1700         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1701
1702 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1703
1704         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1705         https://bugs.webkit.org/show_bug.cgi?id=196211
1706         rdar://problem/49110552
1707
1708         Reviewed by Tim Horton.
1709
1710         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1711         Make sure that EventSenderProxy always exists when running tests. We used to create
1712         it when resetting before the first test, which is a bit too late.
1713
1714         * WebKitTestRunner/TestController.h:
1715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1716         (WTR::TestController::platformCreateWebView):
1717         (WTR::TestController::platformCreateOtherPage):
1718         (WTR::TestController::finishCreatingPlatformWebView):
1719         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1720         (WTR::PlatformWebView::PlatformWebView):
1721         Moved some code that made NSWindow use NSEvent during web view creation. We may
1722         need to move more if some other case us found, but this is enough for now.
1723
1724 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         Unreviewed. Fix typo in GLib geolocation API after r243285.
1727
1728         gelocation -> geolocation.
1729
1730         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1731         (testGeolocationManagerWatchPosition):
1732
1733 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1734
1735         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1736         https://bugs.webkit.org/show_bug.cgi?id=196213
1737
1738         Reviewed by Geoff Garen.
1739
1740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1741         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1742         (credentialWithIdentityAndKeychainPath):
1743         (-[ChallengeDelegate webView:didFinishNavigation:]):
1744         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1745         (TestWebKitAPI::TEST):
1746
1747 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1748
1749         Expected shouldn't assume its contained types are copyable
1750         https://bugs.webkit.org/show_bug.cgi?id=195986
1751
1752         Reviewed by JF Bastien.
1753
1754         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1755         (TestWebKitAPI::NonCopyable::operator== const):
1756         (TestWebKitAPI::NonCopyable::operator!= const):
1757         (TestWebKitAPI::TEST):
1758
1759 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1760
1761         Remove some now-unnecessary dynamic class lookup
1762         https://bugs.webkit.org/show_bug.cgi?id=196237
1763
1764         Reviewed by Simon Fraser.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1767         (makeRequest):
1768         (TEST):
1769
1770 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1771
1772         Unreviewed, rolling out r243450.
1773
1774         AppleWin and WinCairo port builds get broken.
1775
1776         Reverted changeset:
1777
1778         "Add test for fix of #196095"
1779         https://bugs.webkit.org/show_bug.cgi?id=196097
1780         https://trac.webkit.org/changeset/243450
1781
1782 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1783
1784         Unreviewed, rolling out r243465.
1785         https://bugs.webkit.org/show_bug.cgi?id=196226
1786
1787         the test doesn't build (Requested by thorton on #webkit).
1788
1789         Reverted changeset:
1790
1791         "Do not terminate the NetworkProcess if a third party
1792         application sends a NSCredential with a SecIdentityRef"
1793         https://bugs.webkit.org/show_bug.cgi?id=196213
1794         https://trac.webkit.org/changeset/243465
1795
1796 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1797
1798         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1799         https://bugs.webkit.org/show_bug.cgi?id=196213
1800
1801         Reviewed by Geoff Garen.
1802
1803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1804         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1805         (credentialWithIdentityAndKeychainPath):
1806         (-[ChallengeDelegate webView:didFinishNavigation:]):
1807         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1808         (TestWebKitAPI::TEST):
1809
1810 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1811
1812         [ews-build] Gracefully handle missing patch_id in events
1813         https://bugs.webkit.org/show_bug.cgi?id=196216
1814
1815         Reviewed by Lucas Forschler.
1816
1817         * BuildSlaveSupport/ews-build/events.py:
1818
1819 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1820
1821         [ews-build] use lz4 compression for improving buildbot performance
1822         https://bugs.webkit.org/show_bug.cgi?id=196155
1823
1824         Reviewed by Lucas Forschler.
1825
1826         * BuildSlaveSupport/ews-build/master.cfg:
1827
1828 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1829
1830         Pull some API testing helper methods out of TestWKWebView
1831         https://bugs.webkit.org/show_bug.cgi?id=196212
1832
1833         Reviewed by Tim Horton.
1834
1835         Refactor some more API testing utility methods, so that they can be used in
1836         tests that do not use TestWKWebView.
1837
1838         * TestWebKitAPI/cocoa/TestWKWebView.h:
1839         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1840         (-[WKWebView loadTestPageNamed:]):
1841         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1842         (-[WKWebView synchronouslyLoadHTMLString:]):
1843         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1844         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1845         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1846         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1847         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1848
1849 2019-03-25  Jer Noble  <jer.noble@apple.com>
1850
1851         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1852         https://bugs.webkit.org/show_bug.cgi?id=196097
1853
1854         Reviewed by Eric Carlson.
1855
1856         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1857
1858         * DumpRenderTree/mac/DumpRenderTree.mm:
1859         (resetWebPreferencesToConsistentValues):
1860         * WebKitTestRunner/TestController.cpp:
1861         (WTR::TestController::resetPreferencesToConsistentValues):
1862
1863 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1864
1865         Pull IPadUserInterfaceSwizzler out into a separate header file
1866         https://bugs.webkit.org/show_bug.cgi?id=196193
1867
1868         Reviewed by Anders Carlsson.
1869
1870         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1871         be used in other API tests.
1872
1873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1874         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1875         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1876         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1877         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1878         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1879         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1880
1881 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1882
1883         Remove NavigatorContentUtils in WebCore/Modules
1884         https://bugs.webkit.org/show_bug.cgi?id=196070
1885
1886         Reviewed by Alex Christensen.
1887
1888         NavigatorContentUtils was to support the custom scheme spec [1].
1889         However, in WebKit side, no port has supported the feature in
1890         WebKit layer after EFL port was removed. So there has been the
1891         only IDL implementation of the NavigatorContentUtils in WebCore.
1892         So we don't need to keep the implementation in WebCore anymore.
1893
1894         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1895
1896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1897
1898 2019-03-24  Andy Estes  <aestes@apple.com>
1899
1900         [watchOS] Remove unused Proximity Networking code
1901         https://bugs.webkit.org/show_bug.cgi?id=196188
1902
1903         Reviewed by Tim Horton.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1906         (TEST):
1907
1908 2019-03-23  Keith Miller  <keith_miller@apple.com>
1909
1910         Refactor clz/ctz and fix getLSBSet.
1911         https://bugs.webkit.org/show_bug.cgi?id=196162
1912
1913         Reviewed by Saam Barati.
1914
1915         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1916
1917         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1918         (TestWebKitAPI::TEST):
1919
1920 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1921
1922         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1923         https://bugs.webkit.org/show_bug.cgi?id=196143
1924
1925         Reviewed by Michael Catanzaro.
1926
1927         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1928         directories.
1929
1930         * Scripts/webkitpy/style/checkers/cpp.py:
1931         (check_identifier_name_in_declaration):
1932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1933         (WebKitStyleTest.test_names):
1934
1935 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1936
1937         [Flatpak] Manifest expanding fails for qt WPE extension
1938         https://bugs.webkit.org/show_bug.cgi?id=196148
1939
1940         Reviewed by Alex Christensen.
1941
1942         * flatpak/flatpakutils.py:
1943         (expand_submodules_recurse): The last recurse manifest expand
1944         iteration might lead to a single module so take it into account
1945         and don't try to recurse further.
1946
1947 2019-03-22  Chris Dumez  <cdumez@apple.com>
1948
1949         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1950         https://bugs.webkit.org/show_bug.cgi?id=195348
1951         <rdar://problem/48622090>
1952
1953         Reviewed by Alex Christensen.
1954
1955         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1956         to NO when test.options().shouldIgnoreMetaViewport is false.
1957
1958         * WebKitTestRunner/ios/TestControllerIOS.mm:
1959         (WTR::TestController::platformConfigureViewForTest):
1960
1961 2019-03-22  Chris Dumez  <cdumez@apple.com>
1962
1963         Prewarmed processes should be usable with any website data store
1964         https://bugs.webkit.org/show_bug.cgi?id=196104
1965
1966         Reviewed by Alex Christensen.
1967
1968         Add API test coverage.
1969
1970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1971         (runInitialWarmedProcessUsedTest):
1972         (TEST):
1973
1974 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1975
1976         Back out local changes to Alex's Subversion working directory
1977
1978         They were accidentally committed.
1979
1980         * Scripts/webkitpy/common/system/abstractexecutive.py:
1981         (AbstractExecutive.wait_newest):
1982         * Scripts/webkitpy/common/system/executive.py:
1983         (Executive.running_pids):
1984         * Scripts/webkitpy/common/system/executive_mock.py:
1985         (MockExecutive.running_pids):
1986         * Scripts/webkitpy/common/system/executive_unittest.py:
1987         (ExecutiveTest.serial_test_running_pids):
1988         * Scripts/webkitpy/port/darwin.py:
1989         (DarwinPort.check_for_leaks):
1990         * Scripts/webkitpy/port/leakdetector.py:
1991         (LeakDetector.check_for_leaks):
1992         - This was the hack attached to Bug 193772.
1993
1994         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1995         (+[WebKitTestRunnerEvent mouseLocation]):
1996         - This works around a crash on an internal build.
1997
1998 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1999
2000         Fix the build after r243354
2001         https://bugs.webkit.org/show_bug.cgi?id=196138
2002         <rdar://problem/49145951>
2003
2004         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2005         (TEST):
2006         * TestWebKitAPI/ios/UIKitSPI.h:
2007
2008 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2009
2010         Adopt UIWKDocumentContext
2011         https://bugs.webkit.org/show_bug.cgi?id=196040
2012         <rdar://problem/48642440>
2013
2014         Reviewed by Ryosuke Niwa.
2015
2016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2017         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2018         (makeRequest):
2019         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2020         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2021         (applyStyle):
2022         (TEST):
2023         Add tests for UIWKDocumentContext.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2026         (TEST):
2027         (recursiveFindWKContentView): Deleted.
2028         * TestWebKitAPI/cocoa/TestWKWebView.h:
2029         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2030         (recursiveFindWKContentView):
2031         (-[TestWKWebView wkContentView]):
2032         * TestWebKitAPI/ios/UIKitSPI.h:
2033         Share the WKContentView finding code between tests.
2034
2035 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2036
2037         [iOS WK2] Turn on async overflow scrolling by default
2038         https://bugs.webkit.org/show_bug.cgi?id=196011
2039         rdar://problem/48453859
2040
2041         Reviewed by Antti Koivisto.
2042         
2043         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2044         since so many basic layout tests have different results when compositing is triggered for
2045         overflow.
2046         
2047         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2048
2049         * WebKitTestRunner/TestController.cpp:
2050         (WTR::TestController::resetPreferencesToConsistentValues):
2051
2052 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2053
2054         [ews-build] Retry API test in case of failures
2055         https://bugs.webkit.org/show_bug.cgi?id=196004
2056
2057         Reviewed by Lucas Forschler.
2058
2059         * BuildSlaveSupport/ews-build/steps.py:
2060         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2061         (CompileWebKitToT.doStepIf): Ditto.
2062         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2063         (ReRunAPITests): Re-run API tests.
2064         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2065         (RunAPITestsWithoutPatch): Run API tests without patch.
2066         (RunAPITestsWithoutPatch.doStepIf):
2067         (RunAPITestsWithoutPatch.hideStepIf):
2068         (RunAPITestsWithoutPatch.evaluateCommand):
2069         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2070         (AnalyzeAPITestsResults.start):
2071         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2072         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2073         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2074         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2075
2076 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [ews-build] Update queues configurations
2079         https://bugs.webkit.org/show_bug.cgi?id=196074
2080
2081         Reviewed by Dewei Zhu.
2082
2083         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2084         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2085
2086 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2089         https://bugs.webkit.org/show_bug.cgi?id=195680
2090         <rdar://problem/48903534>
2091
2092         Unreviewed infrastructure fix.
2093
2094         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2095         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2096
2097 2019-03-21  Andy Estes  <aestes@apple.com>
2098
2099         [iOS] Apple Pay should be available in documents with no user agent scripts
2100         https://bugs.webkit.org/show_bug.cgi?id=196061
2101         <rdar://problem/48649391>
2102
2103         Reviewed by Brady Eidson.
2104
2105         Added API tests and related infrastructure.
2106
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2109         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2110         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2113         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2114         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2115         * TestWebKitAPI/cocoa/TestProtocol.mm:
2116         (-[TestProtocol startLoading]):
2117         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2118         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2119         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2120         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2121
2122 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2123
2124         REGRESSSION (r243297): webkitpy tests broken
2125         https://bugs.webkit.org/show_bug.cgi?id=196108
2126
2127         Reviewed by Aakash Jain.
2128
2129         r243297 updated contributors.json, which broke a few unit tests.
2130
2131         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2132         (IRCCommandTest.test_whois):
2133         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2134
2135 2019-03-21  Chris Dumez  <cdumez@apple.com>
2136
2137         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2138         https://bugs.webkit.org/show_bug.cgi?id=196041
2139         <rdar://problem/49083230>
2140
2141         Reviewed by Alex Christensen.
2142
2143         Add API test coverage.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2146         (TEST):
2147
2148 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2149
2150         Add SPI to inform applications of WKContentRuleList actions
2151         https://bugs.webkit.org/show_bug.cgi?id=195965
2152         <rdar://problem/42664365>
2153
2154         Reviewed by Geoff Garen.
2155
2156         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2157         (TestWebKitAPI::allActionsForResourceLoad):
2158         (TestWebKitAPI::testRequest):
2159         (TestWebKitAPI::TEST_F):
2160         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2161         (Notification::description):
2162         (Notification::operator== const):
2163         (toVector):
2164         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2165         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2166         (makeContentRuleList):
2167         (TEST):
2168         (makeWarnContentRuleList): Deleted.
2169
2170 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2171
2172         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2173         https://bugs.webkit.org/show_bug.cgi?id=196088
2174
2175         Reviewed by Brian Burg.
2176
2177         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2178         Support checks when only one platform is specified. Also deprecate macosx() and
2179         force the use of macos() instead.
2180
2181         * Scripts/webkitpy/style/checkers/cpp.py:
2182         (check_min_versions_of_wk_api_available):
2183         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2184         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2185
2186 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2187
2188         Update status inactive committers' status to 'contributor'.
2189
2190         * Scripts/webkitpy/common/config/contributors.json:
2191
2192 2019-03-21  Xan Lopez  <xan@igalia.com>
2193
2194         [JSC][x86] Drop support for x87 floating point
2195         https://bugs.webkit.org/show_bug.cgi?id=194853
2196
2197         Reviewed by Don Olmstead.
2198
2199         Force SSE2 on x86/32bit builds.
2200
2201         * Scripts/webkitdirs.pm:
2202         (generateBuildSystemFromCMakeProject):
2203
2204 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2205
2206         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2207         https://bugs.webkit.org/show_bug.cgi?id=196073
2208
2209         Reviewed by Michael Catanzaro.
2210
2211         Add test cases to check functions and constructors with no arguments but receiving user data.
2212
2213         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2214         (checkUserData):
2215         (testJSCFunction):
2216         (fooCreateWithUserData):
2217         (testJSCClass):
2218
2219 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2220
2221         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2222
2223         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2224
2225         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2226
2227 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2228
2229         [GTK][WPE] Add API to provide geolocation information
2230         https://bugs.webkit.org/show_bug.cgi?id=195940
2231
2232         Reviewed by Michael Catanzaro.
2233
2234         Add a new test to check the new API.
2235
2236         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2237         (testGeolocationManagerCurrentPosition):
2238         (testGeolocationManagerWatchPosition):
2239         (beforeAll):
2240         (afterAll):
2241         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2242         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2243         (beforeAll): Ditto.
2244         * TestWebKitAPI/glib/CMakeLists.txt:
2245
2246 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         [GLib] Returning G_TYPE_OBJECT from a method does not work
2249         https://bugs.webkit.org/show_bug.cgi?id=195574
2250
2251         Reviewed by Michael Catanzaro.
2252
2253         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2254
2255         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2256         (getGFile):
2257         (getParent):
2258         (createGString):
2259         (getGString):
2260         (getGStringCopyWillRaise):
2261         (getGStringCopy):
2262         (getGStringStr):
2263         (getGStringLen):
2264         (freeGString):
2265         (testJSCClass):
2266
2267 2019-03-20  Saam Barati  <sbarati@apple.com>
2268
2269         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2270         https://bugs.webkit.org/show_bug.cgi?id=195721
2271
2272         Reviewed by Filip Pizlo.
2273
2274         * Scripts/run-javascriptcore-tests:
2275
2276 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2277
2278         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2279         https://bugs.webkit.org/show_bug.cgi?id=196049
2280
2281         Reviewed by Tim Horton.
2282
2283         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2284         overflow scrolling in general, so rename it.
2285
2286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2287
2288 2019-03-20  Daniel Bates  <dabates@apple.com>
2289
2290         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2291         https://bugs.webkit.org/show_bug.cgi?id=196031
2292         <rdar://problem/49078172>
2293
2294         Reviewed by Tim Horton.
2295
2296         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2297         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2298         same code path used when the Done button is pressed to dismiss the <select> picker.
2299
2300         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2301         (TestWebKitAPI::TEST):
2302
2303 2019-03-20  Chris Dumez  <cdumez@apple.com>
2304
2305         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2306         https://bugs.webkit.org/show_bug.cgi?id=196029
2307         <rdar://problem/48954651>
2308
2309         Reviewed by Tim Horton.
2310
2311         Add API test coverage.
2312
2313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2314
2315 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2316
2317         [ews-build] Improve failure summary string for ApplyPatch step
2318         https://bugs.webkit.org/show_bug.cgi?id=195995
2319
2320         Reviewed by Alexey Proskuryakov.
2321
2322         * BuildSlaveSupport/ews-build/steps.py:
2323         (ApplyPatch.getResultSummary): Override getResultSummary.
2324
2325 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2326
2327         AX: Implement support for new meter ARIA role
2328         https://bugs.webkit.org/show_bug.cgi?id=195966
2329
2330         Reviewed by Chris Fleizach.
2331
2332         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2333         to AXLevelIndicator.
2334
2335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2336
2337 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2338
2339         [WebAuthN] Implement FIDO AppID extension
2340         https://bugs.webkit.org/show_bug.cgi?id=143491
2341         <rdar://problem/48298273>
2342
2343         Reviewed by Brent Fulgham.
2344
2345         Add a test that covers the new flag of convertToU2fSignCommand.
2346
2347         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2348         (TestWebKitAPI::TEST):
2349         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2350         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2351         (TestWebKitAPI::TEST):
2352
2353 2019-03-19  Keith Rollin  <krollin@apple.com>
2354
2355         Add support for more platforms to generate-xcfilelists
2356         https://bugs.webkit.org/show_bug.cgi?id=195977
2357
2358         Reviewed by Alexey Proskuryakov.
2359
2360         generate-xcfilelists incorrectly complains when involved with building
2361         WebKit for iphonesimulator:
2362
2363             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2364             …
2365             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2366
2367         Address this by teaching generate-xcfilelists about more platforms.
2368
2369         * Scripts/generate-xcfilelists:
2370
2371 2019-03-19  John Wilander  <wilander@apple.com>
2372
2373         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2374         https://bugs.webkit.org/show_bug.cgi?id=195923
2375         <rdar://problem/49001272>
2376
2377         Reviewed by Alex Christensen.
2378
2379         This patch does the following to the TestRunner:
2380         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2381         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2382         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2383
2384         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2386         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2388         * WebKitTestRunner/TestController.cpp:
2389         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2390         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2391         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2392         * WebKitTestRunner/TestController.h:
2393         * WebKitTestRunner/TestInvocation.cpp:
2394         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2395
2396 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2397
2398         [CMake] Support more clang and gcc sanitizers
2399         https://bugs.webkit.org/show_bug.cgi?id=195956
2400
2401         Reviewed by Michael Catanzaro.
2402
2403         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2404
2405 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2406
2407         [ews-build] Improve summary for PrintConfiguration step
2408         https://bugs.webkit.org/show_bug.cgi?id=195945
2409
2410         Reviewed by Lucas Forschler.
2411
2412         * BuildSlaveSupport/ews-build/steps.py:
2413         (PrintConfiguration.getResultSummary): Override getResultSummary.
2414
2415 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2416
2417         [ews-build] Improve summary for CheckOutSource step
2418         https://bugs.webkit.org/show_bug.cgi?id=195963
2419
2420         Reviewed by Lucas Forschler.
2421
2422         * BuildSlaveSupport/ews-build/steps.py:
2423         (CheckOutSource.getResultSummary):
2424
2425 2019-03-19  Daniel Bates  <dabates@apple.com>
2426
2427         [iOS] Focus not preserved when switching between tabs
2428         https://bugs.webkit.org/show_bug.cgi?id=195820
2429         <rdar://problem/43614450>
2430
2431         Reviewed by Brent Fulgham.
2432
2433         Add tests to ensure that we restore focus when resigning and becoming first responder.
2434
2435         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2436         (TestWebKitAPI::TEST):
2437
2438 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2439
2440         Make WTFLogChannelState and WTFLogLevel enum classes
2441         https://bugs.webkit.org/show_bug.cgi?id=195904
2442
2443         Reviewed by Eric Carlson.
2444
2445         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2446         (TestWebKitAPI::TEST_F):
2447
2448 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2449
2450         [GStreamer][EME] Backported mssdemux protection data crash fix
2451         https://bugs.webkit.org/show_bug.cgi?id=195918
2452
2453         Reviewed by Philippe Normand.
2454
2455         * gstreamer/jhbuild.modules:
2456         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2457
2458 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2459
2460         Unreviewed, rolling out r243132.
2461
2462         Broke GTK build
2463
2464         Reverted changeset:
2465
2466         "Make WTFLogChannelState and WTFLogLevel enum classes"
2467         https://bugs.webkit.org/show_bug.cgi?id=195904
2468         https://trac.webkit.org/changeset/243132
2469
2470 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2471
2472         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2473
2474         * Scripts/webkitdirs.pm:
2475         (builtDylibPathForName): Adjust the shared library name that's changed
2476         with the API version bump in r243073.
2477
2478 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2479
2480         Make WTFLogChannelState and WTFLogLevel enum classes
2481         https://bugs.webkit.org/show_bug.cgi?id=195904
2482
2483         Reviewed by Eric Carlson.
2484
2485         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2486         (TestWebKitAPI::TEST_F):
2487
2488 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2489
2490         Disable flaky test added in r2431100
2491         https://webkit.org/b/195785
2492
2493         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2494         (TestWebKitAPI::TEST):
2495         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2496
2497 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2498
2499         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2500         https://bugs.webkit.org/show_bug.cgi?id=195916
2501
2502         Reviewed by Tim Horton.
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2505         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2506
2507 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2508
2509         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2510
2511         * Scripts/webkitpy/common/config/contributors.json:
2512
2513 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2514
2515         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2516         https://bugs.webkit.org/show_bug.cgi?id=195785
2517
2518         Reviewed by Geoffrey Garen.
2519
2520         * TestWebKitAPI/TCPServer.cpp: Added.
2521         (TestWebKitAPI::TCPServer::TCPServer):
2522         (TestWebKitAPI::TCPServer::~TCPServer):
2523         (TestWebKitAPI::TCPServer::socketBindListen):
2524         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2525         * TestWebKitAPI/TCPServer.h: Added.
2526         (TestWebKitAPI::TCPServer::port const):
2527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2528         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2529         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2530         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2531         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2532         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2533         (TestWebKitAPI::respondSlowly):
2534         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2535         (TestWebKitAPI::downloadAtRate):
2536         (TestWebKitAPI::TEST):
2537
2538 2019-03-18  Saam Barati  <sbarati@apple.com>
2539
2540         Add a plan file for JetStream 2
2541         https://bugs.webkit.org/show_bug.cgi?id=190734
2542
2543         Reviewed by Mark Lam.
2544
2545         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2546
2547 2019-03-18  Chris Dumez  <cdumez@apple.com>
2548
2549         Delay WebProcess launch until a load is triggered in a Web view
2550         https://bugs.webkit.org/show_bug.cgi?id=195758
2551         <rdar://problem/48126013>
2552
2553         Reviewed by Geoff Garen.
2554
2555         Add API test coverage. Also update some existing API tests to not expect
2556         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2557
2558         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2559         (TestWebKitAPI::TEST):
2560         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2561         (TestWebKitAPI::TEST):
2562         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2563         (TEST):
2564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2565         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2566         (TEST):
2567         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2568         (TEST):
2569         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2570
2571 2019-03-18  Xan Lopez  <xan@igalia.com>
2572
2573         [CMake] Prevent potential warning when determining $architecture
2574         https://bugs.webkit.org/show_bug.cgi?id=195891
2575
2576         Reviewed by Michael Catanzaro.
2577
2578         It's possible for generateBuildSystemForCMakeProject to be called
2579         before determineArchitecture() is ever called. This will make the
2580         first eq check with $architecture to be bogus (and print a
2581         warning). Change that to an eq check with architecture(), which
2582         implicitly calls determineArchitecture() if needed, and change all
2583         the other similar cases in the method in the same way to prevent
2584         future bugs like this one.
2585
2586         * Scripts/webkitdirs.pm:
2587         (generateBuildSystemFromCMakeProject):
2588
2589 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2590
2591         [WPE] Tarballs generated with “make dist” cannot build documentation
2592         https://bugs.webkit.org/show_bug.cgi?id=195885
2593
2594         Reviewed by Carlos Garcia Campos.
2595
2596         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2597
2598 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2599
2600         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2601         https://bugs.webkit.org/show_bug.cgi?id=195883
2602
2603         Reviewed by Carlos Garcia Campos.
2604
2605         * gtkdoc/gtkdoc.py:
2606         (GTKDoc._run_command): When commands fail to run, include the full command line for
2607         the program invocation and the output it has generated on the standard error stream.
2608
2609 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2610
2611         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2612         https://bugs.webkit.org/show_bug.cgi?id=195786
2613
2614         Reviewed by Philippe Normand.
2615
2616         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2617         * wpe/jhbuild.modules: Ditto.
2618
2619 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2620
2621         [ews-build] Don't run clean builds on EWS builders
2622         https://bugs.webkit.org/show_bug.cgi?id=195851
2623
2624         Reviewed by Geoffrey Garen.
2625
2626         * BuildSlaveSupport/ews-build/factories.py:
2627
2628 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2629
2630         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2631         https://bugs.webkit.org/show_bug.cgi?id=195849
2632
2633         Reviewed by Chris Dumez.
2634
2635         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2638         (runWebsiteDataStoreCustomPaths):
2639
2640 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2641
2642         webkitpy: Upload test results
2643         https://bugs.webkit.org/show_bug.cgi?id=195755
2644         <rdar://problem/48896182>
2645
2646         Reviewed by Aakash Jain.
2647
2648         Establish a new format for uploading results that is not tied to layout tests, apply
2649         that format to webkitpy tests.
2650
2651         * Scripts/webkitpy/common/checkout/scm/git.py:
2652         (Git.native_branch): Return what branch the current checkout is on.
2653         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2654         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2655         * Scripts/webkitpy/common/checkout/scm/svn.py:
2656         (SVN.native_branch): Ditto.
2657         * Scripts/webkitpy/common/system/platforminfo.py:
2658         (PlatformInfo.build_version): Return a build version for Mac.
2659         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2660         (MockPlatformInfo.__init__):
2661         (MockPlatformInfo.build_version):
2662         * Scripts/webkitpy/results: Added.
2663         * Scripts/webkitpy/results/__init__.py: Added.
2664         * Scripts/webkitpy/results/options.py: Added.
2665         (upload_options): OptParse list for upload options.
2666         * Scripts/webkitpy/results/upload.py: Added.
2667         (Upload): Class which enforces the upload format expected by the results server.
2668         (Upload.Expectations):
2669         (Upload.create_configuration):
2670         (Upload.create_commit):
2671         (Upload.create_details):
2672         (Upload.create_run_stats):
2673         (Upload.create_test_result):
2674         (Upload.__init__):
2675         (Upload.Encoder): Encode Upload object as json.
2676         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2677         * Scripts/webkitpy/results/upload_unittest.py: Added.
2678         * Scripts/webkitpy/test/main.py:
2679         (Tester._parse_args): Add upload arguments.
2680         (Tester._run_tests): Allow results to be uploaded.
2681         * Scripts/webkitpy/test/runner.py:
2682         (Runner.__init__): Record which tests were run, rather than just counting them.
2683         (Runner.handle):
2684         * Scripts/webkitpy/test/runner_unittest.py:
2685         (RunnerTest.test_run):
2686         * Scripts/webkitpy/thirdparty/__init__.py:
2687         (AutoinstallImportHook.find_module): Add requests auto-install.
2688         (AutoinstallImportHook._install_requests):
2689         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2690         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2691
2692 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2693
2694         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2695         https://bugs.webkit.org/show_bug.cgi?id=195810
2696
2697         Reviewed by Tim Horton.
2698
2699         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2700         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2701         ending certain layout tests.
2702
2703         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2704         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2705         (-[TestRunnerWKWebView dealloc]):
2706         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2707
2708         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2709         helper method when destroying the web view, and when resetting state between tests.
2710
2711         * WebKitTestRunner/ios/TestControllerIOS.mm:
2712         (WTR::TestController::platformResetStateToConsistentValues):
2713
2714         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2715
2716 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2717
2718         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2719         https://bugs.webkit.org/show_bug.cgi?id=190350
2720         <rdar://problem/45089503>
2721
2722         Reviewed by Geoffrey Garen.
2723
2724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2725         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2726         (TEST):
2727         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2728         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2729         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2730         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2731         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2732         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2733         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2734         (runTest):
2735         (createDirectories):
2736         (TEST):
2737         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2738         (TEST):
2739         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2740         (TEST):
2741
2742 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2743
2744         Add support to WebPage for getting the contents as an attributed string.
2745         https://bugs.webkit.org/show_bug.cgi?id=195636
2746         rdar://problem/45055697
2747
2748         Reviewed by Tim Horton.
2749
2750         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2751         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2752
2753 2019-03-15  Chris Dumez  <cdumez@apple.com>
2754
2755         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2756         https://bugs.webkit.org/show_bug.cgi?id=195747
2757
2758         Reviewed by Geoff Garen.
2759
2760         Add API test coverage.
2761
2762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2763
2764 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2765
2766         Unreviewed, rolling out r242952.
2767
2768         Causing API failures on iOS Simulator
2769
2770         Reverted changeset:
2771
2772         "[PSON] Make sure the WebProcessCache is leverage when
2773         relaunching a process after termination"
2774         https://bugs.webkit.org/show_bug.cgi?id=195747
2775         https://trac.webkit.org/changeset/242952
2776
2777 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2778
2779         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2780         https://bugs.webkit.org/show_bug.cgi?id=195740
2781
2782         Reviewed by Ross Kirsling.
2783
2784         window.open doesn't work for WebKitBrowserWindow because it is not
2785         implemented yet.
2786
2787         1. Implemented createNewPage callback of WKPageUIClient.
2788         2. Changed MainWindow to take a BrowserWindow factory function
2789           instead of BrowserWindowType to be flexible to create
2790           BrowserWindow with extra settings.
2791         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2792           because it is not relevant with MainWindow anymore.
2793
2794         * MiniBrowser/win/Common.cpp:
2795         (parseCommandLine):
2796         * MiniBrowser/win/Common.h:
2797         (CommandLineOptions::CommandLineOptions):
2798         * MiniBrowser/win/MainWindow.cpp:
2799         (MainWindow::MainWindow):
2800         (MainWindow::create):
2801         (MainWindow::init):
2802         (MainWindow::WndProc):
2803         * MiniBrowser/win/MainWindow.h:
2804         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2805         (PrintWebUIDelegate::createWebViewWithRequest):
2806         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2807         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2808         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2809         (WebKitBrowserWindow::updateProxySettings):
2810         (WebKitBrowserWindow::createNewPage):
2811         * MiniBrowser/win/WebKitBrowserWindow.h:
2812         * MiniBrowser/win/WinMain.cpp:
2813         (wWinMain):
2814
2815 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2816
2817         Make it possible to test scrolling tree layer manipulation more easily
2818         https://bugs.webkit.org/show_bug.cgi?id=195780
2819
2820         Reviewed by Tim Horton.
2821         
2822         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2823         cuts off communication of scrolling tree scrolls back to the web process
2824         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2825         allows tests to trigger scrolls which run the scrolling tree layer positioning
2826         logic, but never get another commit from the web process that might mask
2827         scrolling tree bugs.
2828         
2829         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2830         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2831         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2832
2833         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2834         (WTR::UIScriptController::scrollUpdatesDisabled const):
2835         (WTR::UIScriptController::setScrollUpdatesDisabled):
2836         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2837         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2838         (WTR::UIScriptController::scrollUpdatesDisabled const):
2839         (WTR::UIScriptController::setScrollUpdatesDisabled):
2840         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2841         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2842         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2843         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2844         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2845         * WebKitTestRunner/ios/TestControllerIOS.mm:
2846         (WTR::TestController::platformResetStateToConsistentValues):
2847         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2848         (WTR::UIScriptController::scrollUpdatesDisabled const):
2849         (WTR::UIScriptController::setScrollUpdatesDisabled):
2850
2851 2019-03-14  Youenn Fablet  <youenn@apple.com>
2852
2853         Move IDB storage in private browsing mode to NetworkProcess
2854         https://bugs.webkit.org/show_bug.cgi?id=195602
2855
2856         Reviewed by Brady Eidson.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2859         (TEST):
2860
2861 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2862
2863         [ews-build] Make descriptionDone messages more readable
2864         https://bugs.webkit.org/show_bug.cgi?id=195760
2865
2866         Reviewed by Lucas Forschler.
2867
2868         * BuildSlaveSupport/ews-build/steps.py:
2869         * BuildSlaveSupport/ews-build/steps_unittest.py:
2870
2871 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2872
2873         [ews-build] Generate status-bubble hover-over messages
2874         https://bugs.webkit.org/show_bug.cgi?id=195680
2875
2876         Reviewed by Lucas Forschler.
2877
2878         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2879         (StatusBubble):
2880         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2881         on hover-over.
2882         (StatusBubble._iso_time):
2883         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2884         hover-over message.
2885         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2886
2887 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2888
2889         [ews-app] Gracefully handle the case when state_string is None
2890         https://bugs.webkit.org/show_bug.cgi?id=195753
2891
2892         Reviewed by Lucas Forschler.
2893
2894         * BuildSlaveSupport/ews-app/ews/models/build.py:
2895         * BuildSlaveSupport/ews-app/ews/models/step.py:
2896
2897 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-app] Status bubble display pending for currently running build step
2900         https://bugs.webkit.org/show_bug.cgi?id=195744
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-build/events.py:
2905         (Events.stepStarted): If state_string is pending, replace it with step name.
2906
2907 2019-03-14  Chris Dumez  <cdumez@apple.com>
2908
2909         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2910         https://bugs.webkit.org/show_bug.cgi?id=195750
2911
2912         Reviewed by Geoffrey Garen.
2913
2914         Add API test coverage.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2917         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2918         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2919         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2920
2921 2019-03-14  Chris Dumez  <cdumez@apple.com>
2922
2923         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2924         https://bugs.webkit.org/show_bug.cgi?id=195747
2925
2926         Reviewed by Geoff Garen.
2927
2928         Add API test coverage.
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2931
2932 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2933
2934         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2935         https://bugs.webkit.org/show_bug.cgi?id=195725
2936         <rdar://problem/48545062>
2937
2938         Reviewed by Tim Horton.
2939
2940         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2941         handler is nil.
2942
2943         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2944         (TestWebKitAPI::TEST):
2945
2946 2019-03-13  Sam Weinig  <sam@webkit.org>
2947
2948         Add utility function to allow easy reverse range-based iteration of a container
2949         https://bugs.webkit.org/show_bug.cgi?id=195542
2950
2951         Reviewed by Antti Koivisto.
2952
2953         * TestWebKitAPI/CMakeLists.txt:
2954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2955         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2956         (TestWebKitAPI::TEST):
2957         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2958
2959 2019-03-13  Chris Dumez  <cdumez@apple.com>
2960
2961         Use a ServiceWorker process per registrable domain
2962         https://bugs.webkit.org/show_bug.cgi?id=195649
2963
2964         Reviewed by Youenn Fablet.
2965
2966         Update API test coverage.
2967
2968         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2969
2970 2019-03-13  Chris Dumez  <cdumez@apple.com>
2971
2972         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2973         https://bugs.webkit.org/show_bug.cgi?id=195684
2974         <rdar://problem/48294714>
2975
2976         Reviewed by Antti Koivisto.
2977
2978         Add API test coverage.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2981
2982 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2983
2984         [ews-app] Remove unused patch view
2985         https://bugs.webkit.org/show_bug.cgi?id=195669
2986
2987         Reviewed by Lucas Forschler.
2988
2989         * BuildSlaveSupport/ews-app/ews/urls.py:
2990         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2991
2992 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-app] Use Buildbot result code variables
2995         https://bugs.webkit.org/show_bug.cgi?id=195668
2996
2997         Reviewed by Alexey Proskuryakov.
2998
2999         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3000         (Buildbot): Added Buildbot result code variables.
3001         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3002         (StatusBubble._build_bubble): Used Buildbot result code variables.
3003
3004 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3005
3006         [Flatpak] Expand submodule recursively
3007         https://bugs.webkit.org/show_bug.cgi?id=195672
3008
3009         Building WPE with flatpak was impossible without that as it was raising an exception.
3010         Also update wpebackend-fdo to match what is built in jhbuild
3011
3012         Reviewed by Philippe Normand.
3013
3014         * flatpak/flatpakutils.py:
3015         (expand_submodules_recurse):
3016         (expand_manifest):
3017         * flatpak/org.webkit.WPEModules.yaml:
3018
3019 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-app] status bubble should be hidden for certain builds
3022         https://bugs.webkit.org/show_bug.cgi?id=194597
3023
3024         Reviewed by Dewei Zhu.
3025
3026         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3027         (StatusBubble._build_bubble):
3028         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3029         because the patch didn't have relevant changes.
3030         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3031         in production yet.
3032
3033 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3034
3035         [Win] Fix a slew of simple clang-cl warnings.
3036         https://bugs.webkit.org/show_bug.cgi?id=195652
3037
3038         Reviewed by Don Olmstead.
3039
3040         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3041         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3042
3043 2019-03-12  Justin Fan  <justin_fan@apple.com>
3044
3045         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3046         https://bugs.webkit.org/show_bug.cgi?id=195518
3047         <rdar://problem/46322356>
3048
3049         Reviewed by Myles C. Maxfield.
3050
3051         * DumpRenderTree/DerivedSources-input.xcfilelist:
3052         * DumpRenderTree/DerivedSources-output.xcfilelist:
3053
3054 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3055
3056         Unreviewed, rolling out r242825.
3057         https://bugs.webkit.org/show_bug.cgi?id=195648
3058
3059         "Broke webkitpy tests with my change to
3060         lldb_dump_class_layout.py" (Requested by rmorisset on
3061         #webkit).
3062
3063         Reverted changeset:
3064
3065         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3066         classes with suspicious padding"
3067         https://bugs.webkit.org/show_bug.cgi?id=195573
3068         https://trac.webkit.org/changeset/242825
3069
3070 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3071
3072         [ews-build] Show status bubbles while the patch is waiting in queue
3073         https://bugs.webkit.org/show_bug.cgi?id=195618
3074
3075         Reviewed by Lucas Forschler.
3076
3077         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3078         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3079         enabled in initial deployment.
3080         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3081         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3082         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3083         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3084         (StatusBubble._build_bubbles_for_patch):
3085
3086 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3087
3088         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3089         https://bugs.webkit.org/show_bug.cgi?id=195573
3090
3091         Reviewed by Simon Fraser.
3092
3093         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3094
3095         * Scripts/dump-class-layout:
3096         (main):
3097         * lldb/lldb_dump_class_layout.py:
3098         (ClassLayout.__init__):
3099         (ClassLayout._compute_padding_recursive):
3100         (LLDBDebuggerInstance.dump_layout_for_classname):
3101         (LLDBDebuggerInstance):
3102         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3103         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3104
3105 2019-03-12  Chris Dumez  <cdumez@apple.com>
3106
3107         Device Orientation access permission should be denied unless explicitly granted by the client
3108         https://bugs.webkit.org/show_bug.cgi?id=195625
3109
3110         Reviewed by Youenn Fablet.
3111
3112         add API test coverage.
3113
3114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3115         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3116         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3117         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3118         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3119         (runDeviceOrientationTest):
3120         (TEST):
3121         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3122         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3123
3124 2019-03-12  Jer Noble  <jer.noble@apple.com>
3125
3126         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3127         https://bugs.webkit.org/show_bug.cgi?id=195137
3128         <rdar://problem/48810307>
3129
3130         Reviewed by Eric Carlson.
3131
3132         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3133         (TestWebKitAPI::TEST):
3134
3135 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3136
3137         [ews-build] Change urls from uat to production
3138         https://bugs.webkit.org/show_bug.cgi?id=195566
3139
3140         Reviewed by Lucas Forschler.
3141
3142         * BuildSlaveSupport/ews-app/ews/config.py:
3143         * BuildSlaveSupport/ews-build/events.py:
3144         * BuildSlaveSupport/ews-build/steps.py:
3145
3146 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3147
3148         [ews-build] change max_builds for local-worker to 1
3149         https://bugs.webkit.org/show_bug.cgi?id=195568
3150
3151         Reviewed by Lucas Forschler.
3152
3153         * BuildSlaveSupport/ews-build/loadConfig.py:
3154
3155 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3156
3157         Fix the build
3158
3159         * TestRunnerShared/spi/PencilKitTestSPI.h:
3160         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3161
3162 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3163
3164         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3165         https://bugs.webkit.org/show_bug.cgi?id=194131
3166
3167         Reviewed by Michael Catanzaro.
3168
3169         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3170         (uriChanged):
3171         (testUnfinishedSubresourceLoad):
3172         (serverCallback):
3173         (beforeAll):
3174
3175 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3176
3177         WTF::Expected should use std::addressof instead of operator&
3178         https://bugs.webkit.org/show_bug.cgi?id=195604
3179
3180         Reviewed by Myles Maxfield.
3181
3182         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3183         (TestWebKitAPI::Unique::Unique):
3184         (TestWebKitAPI::Unique::operator&):
3185         (TestWebKitAPI::TEST):
3186
3187 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3188
3189         Add Optional to Forward.h.
3190         https://bugs.webkit.org/show_bug.cgi?id=195586
3191
3192         Reviewed by Darin Adler.
3193
3194         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3195         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3196         Remove unnecessary includes from headers.
3197
3198 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3199
3200         Add testing API to hit-test and scroll overflow scrollers
3201         https://bugs.webkit.org/show_bug.cgi?id=195278
3202
3203         Reviewed by Antti Koivisto.
3204         
3205         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3206         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3207         
3208         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3209
3210         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3211         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3212         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3213         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3214         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3215         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3216         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3217         (WTR::enclosingScrollViewIncludingSelf):
3218         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3219
3220 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3221
3222         API test WebKit.RequestTextInputContext fails on iOS
3223         https://bugs.webkit.org/show_bug.cgi?id=195585
3224
3225         Reviewed by Wenson Hsieh and Simon Fraser.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3228         (applyStyle):
3229         (TEST):
3230         Add a viewport, so that the coordinates match up on iOS.
3231         Scroll by moving the UIScrollView's contentOffset.
3232
3233 2019-03-11  Chris Dumez  <cdumez@apple.com>
3234
3235         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3236         https://bugs.webkit.org/show_bug.cgi?id=195506
3237         <rdar://problem/48733477>
3238
3239         Reviewed by Alex Christensen.
3240
3241         Add API test coverage.
3242
3243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3244
3245 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3246
3247         Adding myself to contributors.json
3248
3249         Unreviewed, addming myself to contributors.json .
3250
3251         * Scripts/webkitpy/common/config/contributors.json:
3252
3253 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3254
3255         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3256         https://bugs.webkit.org/show_bug.cgi?id=195511
3257         <rdar://problem/44873269>
3258
3259         Reviewed by Darin Adler.
3260
3261         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3262         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3263         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3264         (TEST_F):
3265
3266 2019-03-11  Chris Dumez  <cdumez@apple.com>
3267
3268         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3269         https://bugs.webkit.org/show_bug.cgi?id=195561
3270
3271         Reviewed by Youenn Fablet.
3272
3273         Make sure the JS in the test requests for permission to receive device orientation events.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3276
3277 2019-03-11  Youenn Fablet  <youenn@apple.com>
3278
3279         Allow storage quota increase by default in WTR
3280         https://bugs.webkit.org/show_bug.cgi?id=195541
3281
3282         Reviewed by Geoffrey Garen.
3283
3284         Allow storage quota increase by default in WTR.
3285         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3286         Use this for tests that explicitly need cache increase.
3287
3288         Instead of increasing quota by 2, make sure the next request is
3289         granted by adding all given parameters.
3290
3291         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3292         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3293         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3294         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3295         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3296         * WebKitTestRunner/TestController.cpp:
3297         (WTR::TestController::setAllowStorageQuotaIncrease):
3298         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3299         * WebKitTestRunner/TestController.h:
3300         * WebKitTestRunner/TestInvocation.cpp:
3301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3302         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3303         (WTR::TestController::cocoaResetStateToConsistentValues):
3304         (WTR::TestController::setAllowStorageQuotaIncrease):
3305         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3306         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3307         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3308
3309 2019-03-11  Xan Lopez  <xan@igalia.com>
3310
3311         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3312         https://bugs.webkit.org/show_bug.cgi?id=194147
3313
3314         Reviewed by Michael Saboff.
3315
3316         To make --32-bit work correctly on Linux/64bit we need to:
3317
3318         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3319         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3320         unfortunately CMake only allows us to do this during
3321         crosscompilation, which is overkill here.
3322         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3323         pkg-config detection module uses the x86 .pc files instead of the
3324         x86_64 ones.
3325         - Set the -m32 flags for the compiler.
3326
3327         * Scripts/webkitdirs.pm:
3328         (generateBuildSystemFromCMakeProject):
3329
3330 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3331
3332         Add MotionMark-1.1 plan file for run-benchmark script.
3333         https://bugs.webkit.org/show_bug.cgi?id=195481
3334
3335         Rubber-stamped by Darin Adler.
3336
3337         Run-benchmark script should support MontionMark-1.1.
3338
3339         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3340
3341 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3342
3343         [ews-app] Add support for submit-to-ews url
3344         https://bugs.webkit.org/show_bug.cgi?id=195477
3345
3346         Reviewed by Lucas Forschler.
3347
3348         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3349         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3350         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3351         * BuildSlaveSupport/ews-app/ews/urls.py:
3352         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3353
3354 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3355
3356         Unreviewed, rolling out r242688, r242643, r242624.
3357
3358         Caused multiple layout test failures and crashes on iOS and macOS.
3359
3360         Reverted changeset:
3361
3362         "requestAnimationFrame should execute before the next frame"
3363         https://bugs.webkit.org/show_bug.cgi?id=177484
3364         https://trac.webkit.org/changeset/242624/webkit
3365
3366         * Tracing/SystemTracePoints.plist:
3367
3368 2019-03-11  John Wilander  <wilander@apple.com>
3369
3370         Resource Load Statistics: Make it possible exclude localhost from classification
3371         https://bugs.webkit.org/show_bug.cgi?id=195474
3372         <rdar://problem/47520577>
3373
3374         Reviewed by Brent Fulgham.
3375
3376         This patch allows for localhost to be excluded from classification and
3377         treatment as a prevalent resource.
3378
3379         The WebKit Tools change adds a new function called
3380         testRunner.setStatisticsIsRunningTest() which can be used to control this
3381         behavior.
3382
3383         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3384         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3385         (WTR::TestRunner::setStatisticsIsRunningTest):
3386         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3387         * WebKitTestRunner/TestController.cpp:
3388         (WTR::TestController::setStatisticsIsRunningTest):
3389         * WebKitTestRunner/TestController.h:
3390         * WebKitTestRunner/TestInvocation.cpp:
3391         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3392
3393 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3394
3395         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3396         https://bugs.webkit.org/show_bug.cgi?id=195560
3397
3398         Reviewed by Lucas Forschler.
3399
3400         * BuildSlaveSupport/ews-build/master.cfg:
3401
3402 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3403
3404         Unreviewed, rolling out r242698.
3405
3406         API test crashes on bots.
3407
3408         Reverted changeset:
3409
3410         "Add a WKContentRuleList variant that uses copied memory
3411         instead of mmap'd shared memory for class A containerized
3412         apps"
3413         https://bugs.webkit.org/show_bug.cgi?id=195511
3414         https://trac.webkit.org/changeset/242698
3415
3416 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3417
3418         [WPE] Enable web process sandbox
3419         https://bugs.webkit.org/show_bug.cgi?id=195169
3420
3421         Reviewed by Daniel Bates.
3422
3423         * wpe/install-dependencies:
3424         * wpe/jhbuild.modules:
3425
3426 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3427
3428         [ews-app] Use port 17000 for worker communication
3429         https://bugs.webkit.org/show_bug.cgi?id=195558
3430
3431         Reviewed by Lucas Forschler.
3432
3433         * BuildSlaveSupport/ews-build/master.cfg:
3434
3435 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-build] unit-tests fail when passwords.json is missing
3438         https://bugs.webkit.org/show_bug.cgi?id=195557
3439
3440         Reviewed by Lucas Forschler.
3441
3442         * BuildSlaveSupport/ews-build/loadConfig.py:
3443         (loadBuilderConfig):
3444         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3445         (ConfigDotJSONTest.test_configuration):
3446         * BuildSlaveSupport/ews-build/master.cfg:
3447
3448 2019-03-11  Truitt Savell  <tsavell@apple.com>
3449
3450         Unreviewed, rolling out r242702.
3451
3452         Broke High Sierra builders.
3453
3454         Reverted changeset:
3455
3456         "Add utility function to allow easy reverse range-based
3457         iteration of a container"
3458         https://bugs.webkit.org/show_bug.cgi?id=195542
3459         https://trac.webkit.org/changeset/242702
3460
3461 2019-03-11  Sam Weinig  <sam@webkit.org>
3462
3463         Add utility function to allow easy reverse range-based iteration of a container
3464         https://bugs.webkit.org/show_bug.cgi?id=195542
3465
3466         Reviewed by Antti Koivisto.
3467
3468         * TestWebKitAPI/CMakeLists.txt:
3469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3471         (TestWebKitAPI::TEST):
3472         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3473
3474 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3475
3476         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3477         https://bugs.webkit.org/show_bug.cgi?id=195511
3478         <rdar://problem/44873269>
3479
3480         Reviewed by Darin Adler.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3483         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3484         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3485         (TEST_F):
3486
3487 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3488
3489         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3490         https://bugs.webkit.org/show_bug.cgi?id=195499
3491
3492         Reviewed by Darin Adler.
3493
3494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3495         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3496         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3497         (-[WKWebView synchronouslyFocusTextInputContext:]):
3498         (applyStyle):
3499         (applyIframe):
3500         (TEST):
3501         Add some tests for this SPI.
3502
3503 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3504
3505         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3506         https://bugs.webkit.org/show_bug.cgi?id=181151
3507
3508         Reviewed by Don Olmstead.
3509
3510         * TestWebKitAPI/CMakeLists.txt:
3511         * TestWebKitAPI/PlatformWin.cmake:
3512         Enable TestWTF RunLoop tests in all platforms.
3513
3514         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3515         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3516         (TestWebKitAPI::DerivedOneShotTimer::fired):
3517         (TestWebKitAPI::TEST):
3518         Only a few platforms support nested RunLoop.
3519
3520         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3521         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3522
3523 2019-03-10  David Quesada  <david_quesada@apple.com>
3524
3525         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3526         https://bugs.webkit.org/show_bug.cgi?id=152480
3527
3528         Reviewed by Chris Dumez.
3529
3530         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3531         there are no additional references to the process pool besides the one held by
3532         the download, waits for the download to finish (in the sense that the
3533         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3534         measure, also check that the process pool has been deallocated at the end of the
3535         test. The test wouldn't be meaningful if the process pool were still alive.
3536
3537         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3538         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3539         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3540             The download will be canceled because the delegate does not implement the
3541             method to decide the download's destination, so this is where we know the
3542             DownloadProxyMap is done with the DownloadProxy.
3543         (TEST):
3544
3545 2019-03-08  Chris Dumez  <cdumez@apple.com>
3546
3547         Add support for Device Orientation / Motion permission API
3548         https://bugs.webkit.org/show_bug.cgi?id=195329
3549         <rdar://problem/47645367>
3550
3551         Reviewed by Geoffrey Garen.
3552
3553         Add test infrastructure to help test the Device Orientation / Motion permission API.
3554
3555         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3556         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3557         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3559         * WebKitTestRunner/TestController.cpp:
3560         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3561         (WTR::TestController::createWebViewWithOptions):
3562         (WTR::TestController::resetStateToConsistentValues):
3563         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3564         * WebKitTestRunner/TestController.h:
3565         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3566         * WebKitTestRunner/TestInvocation.cpp:
3567         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3568
3569 2019-03-08  Saam barati  <sbarati@apple.com>
3570
3571         Add a compare-results script to compare benchmark results
3572         https://bugs.webkit.org/show_bug.cgi?id=195486
3573         <rdar://problem/48723397>
3574
3575         Reviewed by Geoffrey Garen.
3576
3577         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3578         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3579         to extend it to learn about our other benchmarks.
3580
3581         * Scripts/compare-results: Added.
3582         (readJSONFile):
3583         (detectJetStream2):
3584         (JetStream2Results):
3585         (detectSpeedometer2):
3586         (Speedometer2Results):
3587         (detectPLT5):
3588         (PLT5Results):
3589         (detectBenchmark):
3590         (biggerIsBetter):
3591         (ttest):
3592         (getOptions):
3593         (main):
3594
3595 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3596
3597         Ensure old tab state is cleared between iterations of run-benchmark
3598         https://bugs.webkit.org/show_bug.cgi?id=195393
3599         <rdar://problem/46885583>
3600
3601         Reviewed by Dewei Zhu.
3602
3603         a) ensure the default to restore state is not set
3604         b) terminate Safari correctly
3605         c) Set the system default to ignore Persistent State in Safari
3606
3607         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3608         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3609         (OSXBrowserDriver.prepare_env): 
3610         (OSXBrowserDriver.restore_env):
3611         (OSXBrowserDriver.close_browsers):
3612         (OSXBrowserDriver._terminate_processes):
3613         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3614         (OSXChromeDriver):
3615         (OSXChromeCanaryDriver):
3616         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3617         (OSXFirefoxDriver):
3618         (OSXFirefoxNightlyDriver):
3619         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3620         (OSXSafariDriver):
3621         (OSXSafariDriver.prepare_env):
3622
3623 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3624
3625         [GTK] Several InputMethodFilter tests are failing
3626         https://bugs.webkit.org/show_bug.cgi?id=195408
3627
3628         Reviewed by Carlos Garcia Campos.
3629
3630         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3631         Regressed in r241751.
3632         Hexadecimal values of keycodes are expressed now in upper letters.
3633         Composited characters should be cast to UTF8 strings.
3634
3635         (TestWebKitAPI::TEST):
3636
3637 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3638
3639         [GTK] Make Tools/gtkdoc python3 compatible
3640         https://bugs.webkit.org/show_bug.cgi?id=195359
3641
3642         Reviewed by Carlos Garcia Campos.
3643
3644         * gtkdoc/generate-gtkdoc:
3645         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3646         work with Python 2 and 3.
3647         (get_gtkdoc_module_paths):
3648         The iteritems() was removed in Python 3, so let's use items() that's
3649         available in Python 2 and 3.
3650         (get_generator_for_config):
3651         * gtkdoc/gtkdoc.py:
3652         (GTKDoc._run_command):
3653         The sys.stdout.write() is expecting str in Python 3 and not bytes
3654         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3655         for passing the bytes there.
3656
3657 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3658
3659         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3660         https://bugs.webkit.org/show_bug.cgi?id=195346
3661         <rdar://problem/48667048>
3662
3663         Unreviewed build fix for clang-cl.
3664
3665         * DumpRenderTree/win/DumpRenderTree.cpp:
3666         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3667
3668 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3669
3670         requestAnimationFrame should execute before the next frame
3671         https://bugs.webkit.org/show_bug.cgi?id=177484
3672
3673         Reviewed by Simon Fraser.
3674
3675         Add trace points for the page RenderingUpdate.
3676
3677         * Tracing/SystemTracePoints.plist:
3678
3679 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3680
3681         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3682         https://bugs.webkit.org/show_bug.cgi?id=195353
3683         <rdar://problem/48626394>
3684
3685         Reviewed by Simon Fraser.
3686
3687         * WebKitTestRunner/ios/TestControllerIOS.mm:
3688         (WTR::TestController::platformResetPreferencesToConsistentValues):
3689
3690 2019-03-07  John Wilander  <wilander@apple.com>
3691
3692         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3693         https://bugs.webkit.org/show_bug.cgi?id=195383
3694         <rdar://problem/48570136>
3695
3696         Reviewed by Brent Fulgham.
3697
3698         This patch adds test infrastructure to purge only script-accessible cookies,
3699         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3700
3701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3703         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3705         * WebKitTestRunner/TestController.cpp:
3706         (WTR::TestController::statisticsDeleteCookiesForHost):
3707         * WebKitTestRunner/TestController.h:
3708         * WebKitTestRunner/TestInvocation.cpp:
3709         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3710
3711 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3712
3713         Unreviewed, rolling out r242354.
3714         https://bugs.webkit.org/show_bug.cgi?id=195402
3715
3716         breaks layout tests in all configurations (Requested by
3717         zdobersek on #webkit).
3718
3719         Reverted changeset:
3720
3721         "[WPE] Enable web process sandbox"
3722         https://bugs.webkit.org/show_bug.cgi?id=195169
3723         https://trac.webkit.org/changeset/242354
3724
3725 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3726
3727         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3728         https://bugs.webkit.org/show_bug.cgi?id=195346
3729
3730         Reviewed by Fujii Hironori.
3731
3732         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3733         (TestWebKitAPI::TEST):
3734         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3735
3736         * DumpRenderTree/win/DumpRenderTree.cpp:
3737         (findFontFallback):
3738         (addFontFallbackIfPresent):
3739         (removeFontFallbackIfPresent):
3740         (main):
3741         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3742         (TestWebKitAPI::Util::moduleDirectory):
3743         (TestWebKitAPI::Util::createInjectedBundlePath):
3744         Use wchar helpers as needed.
3745
3746 2019-03-06  Rob Buis  <rbuis@igalia.com>
3747
3748         Consider supporting the `referrerpolicy` attribute.
3749         https://bugs.webkit.org/show_bug.cgi?id=179053
3750
3751         Reviewed by Darin Adler.
3752
3753         Add a runtime flag for referrerpolicy attribute.
3754
3755         * DumpRenderTree/mac/DumpRenderTree.mm:
3756         (enableExperimentalFeatures):
3757
3758 2019-03-05  Daniel Bates  <dabates@apple.com>
3759
3760         Update expected API test result following r242379
3761         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3762
3763         Update expected x-coordinate of selection rect now that the left padding of
3764         a textarea is sized in ems (so dependent on the font size) just like the left
3765         padding of a text field.
3766
3767         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3768         (TestWebKitAPI::TEST):
3769
3770 2019-03-05  David Quesada  <david_quesada@apple.com>
3771
3772         [WK2] It should be possible to follow links with 'download' attributes
3773         https://bugs.webkit.org/show_bug.cgi?id=195145
3774         rdar://problem/48462642
3775
3776         Reviewed by Alex Christensen.
3777
3778         Add a unit test to verify that activating links with 'download' attributes now
3779         navigates to the linked resource, rather than starts downloading it. Add another
3780         to verify that it is still possible to explicitly download the link via the
3781         'Download' navigation action policy.
3782
3783         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3784         (-[DownloadAttributeTestDelegate init]):
3785         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3786         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3787         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3788         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3789         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3790         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3791         (TEST):
3792         * WebKitTestRunner/TestController.cpp:
3793         (WTR::TestController::decidePolicyForNavigationAction):
3794         * WebKitTestRunner/TestController.h:
3795
3796 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3797
3798         [Curl] Implement Cookie Accept Policy.
3799         https://bugs.webkit.org/show_bug.cgi?id=191645
3800
3801         Reviewed by Fujii Hironori.
3802
3803         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3804         (TestWebKitAPI::Curl::TEST_F):
3805
3806 2019-03-05  Youenn Fablet  <youenn@apple.com>
3807
3808         Rename requestCacheStorageSpace to requestStorageSpace
3809         https://bugs.webkit.org/show_bug.cgi?id=195282
3810
3811         Reviewed by Chris Dumez.
3812
3813         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3814         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3815         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3816
3817 2019-03-05  Brady Eidson  <beidson@apple.com>
3818
3819         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3820         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3821
3822         Reviewed by Tim Horton.
3823
3824         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3825         different directory into that same WKWebView should work.
3826
3827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3828         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3829
3830 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3831
3832         Add WeakHashSet
3833         https://bugs.webkit.org/show_bug.cgi?id=195152
3834
3835         Reviewed by Antti Koivisto.
3836
3837         Added tests for WeakHashSet.
3838
3839         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3840         (TestWebKitAPI::Base::Base): Moved.
3841         (TestWebKitAPI::Derived::foo): Moved.
3842         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3843         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3844         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3845         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3846
3847 2019-03-04  Chris Dumez  <cdumez@apple.com>
3848
3849         Do not share WebProcesses between private and regular sessions
3850         https://bugs.webkit.org/show_bug.cgi?id=195189
3851         <rdar://problem/48421064>
3852
3853         Reviewed by Alex Christensen.
3854
3855         Add API test coverage.
3856
3857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3858         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3859
3860 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3861
3862         [WPE] Enable web process sandbox
3863         https://bugs.webkit.org/show_bug.cgi?id=195169
3864
3865         Reviewed by Daniel Bates.
3866
3867         * wpe/install-dependencies:
3868         * wpe/jhbuild.modules:
3869
3870 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3871
3872         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3873         https://bugs.webkit.org/show_bug.cgi?id=195206
3874
3875         Reviewed by Žan Doberšek.
3876
3877         Add a new test case.
3878
3879         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3880         (testJSCClass):
3881
3882 2019-03-04  Charlie Turner  <cturner@igalia.com>
3883
3884         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3885         https://bugs.webkit.org/show_bug.cgi?id=194898
3886
3887         Reviewed by Žan Doberšek.
3888
3889         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3890         a GCC extension that permits arithmetic on void* pointer. Inline
3891         the macro until this issue is fixed upstream.
3892
3893 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3894
3895         Rid the world of WK_API_ENABLED
3896         https://bugs.webkit.org/show_bug.cgi?id=195263
3897
3898         Reviewed by Dan Bernstein.
3899
3900         List of changed files elided because it's useless.
3901
3902 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3903
3904         Unreviewed follow-up to r242292.
3905
3906         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3907
3908         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3909         (TestWebKitAPI::testStrip): Renamed from strip.
3910         (TestWebKitAPI::TEST):
3911
3912 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3913
3914         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3915
3916         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3917         and bug #194272 for details.
3918
3919         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3920
3921 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3922
3923         Remove some more unused 32-bit code
3924         https://bugs.webkit.org/show_bug.cgi?id=195255
3925
3926         Reviewed by Darin Adler.
3927
3928         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3929         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3930         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3931         (NPP_New):
3932         (NPP_HandleEvent):
3933         (handleEventCarbon): Deleted.
3934
3935 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3936
3937         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3938
3939         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3940         (TestWebKitAPI::TEST):
3941
3942 2019-03-01  Darin Adler  <darin@apple.com>
3943
3944         Finish removing String::format
3945         https://bugs.webkit.org/show_bug.cgi?id=194893
3946
3947         Reviewed by Daniel Bates.
3948 '
3949         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3950
3951 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3952
3953         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3954         https://bugs.webkit.org/show_bug.cgi?id=195229
3955         <rdar://problem/48520362>
3956
3957         Reviewed by Chris Dumez.
3958
3959         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3960         (TEST):
3961
3962 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3963
3964         Add a system trace scope for event region building
3965         https://bugs.webkit.org/show_bug.cgi?id=195226
3966
3967         Reviewed by Jon Lee.
3968
3969         This trace scope measures the time spend converting element rects into Region objects,
3970         which can be large on some pages.
3971
3972         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3973
3974         * Tracing/SystemTracePoints.plist:
3975
3976 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3977
3978         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3979         https://bugs.webkit.org/show_bug.cgi?id=194612
3980
3981         Reviewed by Alex Christensen.
3982
3983         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3984         Just test the new string-processing function and don't touch the actual environment.
3985         (Test cases are all as before, but based on operator== instead of strcmp.)
3986
3987 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3988
3989         [ews-app] Update primary keys for handling multiple Buildbot instances
3990         https://bugs.webkit.org/show_bug.cgi?id=195120
3991
3992         Reviewed by Stephanie Lewis.
3993
3994         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3995         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3996         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3997
3998         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3999         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4000         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4001         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4002         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4003         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4004
4005 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4006
4007         [WinCairo] Enable service worker
4008         https://bugs.webkit.org/show_bug.cgi?id=188318
4009
4010         Reviewed by Youenn Fablet.
4011
4012         * DumpRenderTree/DumpRenderTreePrefix.h:
4013         * TestWebKitAPI/PlatformWin.cmake:
4014         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4015         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4016         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4017
4018 2019-03-01  Justin Fan  <justin_fan@apple.com>
4019
4020         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4021         https://bugs.webkit.org/show_bug.cgi?id=195191
4022
4023         Rubber-stamped by Dean Jackson.
4024
4025         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4026
4027         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4028
4029 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4030
4031         Unreviewed, fix lldb webkitpy tests
4032         https://bugs.webkit.org/show_bug.cgi?id=194375
4033
4034         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4035
4036         * lldb/lldb_webkit.py:
4037         (WTFStringImplProvider.is_8bit):
4038
4039 2019-02-28  David Quesada  <david_quesada@apple.com>
4040
4041         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4042         https://bugs.webkit.org/show_bug.cgi?id=195121
4043         rdar://problem/48450302
4044
4045         Reviewed by Alex Christensen.
4046
4047         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4048         configurations where the 'download' attribute is absent, blank, or populated
4049         with a filename, and where the anchor element is same-origin or cross-origin
4050         (meaning the 'download' attribute shouldn't be honored).
4051
4052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4053         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4054         (-[NavigationActionTestDelegate init]):
4055         (-[NavigationActionTestDelegate navigationAction]):
4056         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4057         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4058         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4059         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4060         (TEST):
4061
4062 2019-02-28  Antoine Quint  <graouts@apple.com>
4063
4064         Enable the Pointer Events runtime flag by default
4065         https://bugs.webkit.org/show_bug.cgi?id=195156
4066
4067         Reviewed by Dean Jackson.
4068
4069         * DumpRenderTree/mac/DumpRenderTree.mm:
4070         (enableExperimentalFeatures):
4071
4072 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4073
4074         Several PasteImage API tests are flaky
4075         https://bugs.webkit.org/show_bug.cgi?id=195160
4076
4077         Reviewed by Tim Horton.
4078
4079         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4080         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4081         listening for a "load" event after image load is already complete.
4082
4083         To address this, make these tests first register a "load" event handler, then run script to insert an image
4084         element into the document, and finally wait until the load event is observed before checking image size.
4085
4086         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4087
4088 2019-02-28  Chris Dumez  <cdumez@apple.com>
4089
4090         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4091         https://bugs.webkit.org/show_bug.cgi?id=195107
4092
4093         Reviewed by Alex Christensen.
4094
4095         Give some time for the zoom level to get restored.
4096
4097         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4098
4099 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4100
4101         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4102         https://bugs.webkit.org/show_bug.cgi?id=194958
4103
4104         Reviewed by Geoffrey Garen.
4105
4106         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4107         (TEST):
4108
4109 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4110
4111         [ews-app] Update method to save build to handle builder_display_name
4112         https://bugs.webkit.org/show_bug.cgi?id=195047
4113
4114         Reviewed by Dewei Zhu.
4115
4116         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4117         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4118
4119 2019-02-28  Justin Fan  <justin_fan@apple.com>
4120
4121         [Web GPU] Enable Web GPU only on 64-bit
4122         https://bugs.webkit.org/show_bug.cgi?id=195139
4123
4124         Because Metal is only supported on 64 bit apps.
4125
4126         Unreviewed build fix.
4127
4128         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4129
4130 2019-02-27  Youenn Fablet  <youenn@apple.com>
4131
4132         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4133         https://bugs.webkit.org/show_bug.cgi?id=194959
4134
4135         Reviewed by Chris Dumez.
4136
4137         Spin loop until getting the condition to remove flakiness.
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4140
4141 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4142
4143         [ews-build] Buildbot should include builder_display_name in the build events
4144         https://bugs.webkit.org/show_bug.cgi?id=195045
4145
4146         Reviewed by Dewei Zhu.
4147
4148         * BuildSlaveSupport/ews-build/events.py:
4149         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4150         buildername to builder_name to be consistent in naming style.
4151         (Events.buildFinished): Ditto.
4152
4153 2019-02-27  Chris Dumez  <cdumez@apple.com>
4154
4155         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4156         https://bugs.webkit.org/show_bug.cgi?id=194480
4157
4158         Reviewed by Brady Eidson.
4159
4160         Update existing API test to make it more likely to reproduce the issue.
4161
4162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4163
4164 2019-02-27  Brady Eidson  <beidson@apple.com>
4165
4166         Universal links from Google search results pages don't open the app.
4167         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4168
4169         Reviewed by Geoffrey Garen.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4172         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4173         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4174         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4175
4176 2019-02-27  Chris Dumez  <cdumez@apple.com>
4177
4178         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4179         https://bugs.webkit.org/show_bug.cgi?id=195102
4180
4181         Reviewed by Geoffrey Garen.
4182
4183         If the number of processes is not yet what we expect, wait a bit and check again to give
4184         processes some time to exit.
4185
4186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4187
4188 2019-02-27  Chris Dumez  <cdumez@apple.com>
4189
4190         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4191         https://bugs.webkit.org/show_bug.cgi?id=194545
4192
4193         Reviewed by Brady Eidson.
4194
4195         Make sure the test navigates forward and then back only once. Previously, navigating
4196         back would trigger a navigation again in a timer.
4197
4198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4199
4200 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4201
4202         High Sierra Debug JSC test queue should use faster hardware
4203         https://bugs.webkit.org/show_bug.cgi?id=194603
4204
4205         Rubber-stamped by Alexey Proskuryakov.
4206
4207         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4208
4209         * BuildSlaveSupport/build.webkit.org-config/config.json:
4210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4211         (BubbleQueueServer):
4212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4213         (WebKitBuildbot):
4214         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4215         * QueueStatusServer/config/queues.py:
4216         * Scripts/webkitpy/common/config/ews.json:
4217         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4218         (test_ews_name):
4219
4220 2019-02-27  John Wilander  <wilander@apple.com>
4221
4222         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4223         https://bugs.webkit.org/show_bug.cgi?id=195071
4224         <rdar://problem/48417690>
4225
4226         Reviewed by Alex Christensen and Brent Fulgham.
4227
4228         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4229         (TestWebKitAPI::createURL):
4230             Convenience function.
4231         (TestWebKitAPI::TEST):
4232             WebCore::AdClickAttribution now takes a URL when creating Source and
4233             Destination.
4234         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4235         (TestWebKitAPI::TEST):
4236             WebCore::AdClickAttribution now takes a URL when creating Source and
4237             Destination.
4238
4239 2019-02-27  Antoine Quint  <graouts@apple.com>
4240
4241         Support Pointer Events on macOS
4242         https://bugs.webkit.org/show_bug.cgi?id=195008
4243         <rdar://problem/47454419>
4244
4245         Reviewed by Dean Jackson.
4246
4247         * DumpRenderTree/mac/DumpRenderTree.mm:
4248         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4250
4251 2019-02-26  Mark Lam  <mark.lam@apple.com>
4252
4253         Remove remaining poisoning code.
4254         https://bugs.webkit.org/show_bug.cgi?id=194138
4255
4256         Reviewed by Saam Barati.
4257
4258         * TestWebKitAPI/CMakeLists.txt:
4259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4260         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4261         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4262         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4263         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4264         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4265         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4266
4267 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4268
4269         Move ephemeral local storage from WebProcess to UIProcess
4270         https://bugs.webkit.org/show_bug.cgi?id=195074
4271         <rdar://problem/47937975>
4272
4273         Reviewed by Geoff Garen.
4274
4275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4276
4277 2019-02-20  Jer Noble  <jer.noble@apple.com>
4278
4279         [Cocoa] Media elements will restart network buffering just before suspending
4280         https://bugs.webkit.org/show_bug.cgi?id=193691
4281
4282         Reviewed by Eric Carlson.
4283
4284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4286         (TEST):
4287
4288 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4289
4290         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4291         https://bugs.webkit.org/show_bug.cgi?id=191652
4292
4293         Reviewed by Alex Christensen.
4294
4295         Fix WinCairo MiniBrowser behavior of authentication dialog.
4296
4297         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4298         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4299
4300 2019-02-26  Youenn Fablet  <youenn@apple.com>
4301
4302         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4303         https://bugs.webkit.org/show_bug.cgi?id=195028
4304         <rdar://problem/48243733>
4305
4306         Reviewed by Eric Carlson.
4307
4308         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4309
4310 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4311
4312         [WPE] Add API for webview background color configuration
4313         https://bugs.webkit.org/show_bug.cgi?id=192305
4314
4315         Reviewed by Michael Catanzaro.
4316
4317         * MiniBrowser/wpe/main.cpp:
4318         (main): Add a new option to configure the webview background
4319         color. Example: --bg-color=transparent.
4320         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4321         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4322         (beforeAll): Ditto.
4323
4324 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4325
4326         scalableNativeWebpageParameters() is not preserved on new page navigation.
4327         https://bugs.webkit.org/show_bug.cgi?id=194892
4328         <rdar://problem/47538280>
4329
4330         Reviewed by Wenson Hsieh.
4331         
4332         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4333
4334         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4335         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4336         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4337         (WTR::UIScriptController::allowsViewportShrinkToFit):
4338         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4339         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4340         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4341         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4342         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4343         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4344
4345 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4346
4347         [ews-app] Add model for handling multiple Buildbot instances
4348         https://bugs.webkit.org/show_bug.cgi?id=194863
4349
4350         Reviewed by Stephanie Lewis.
4351
4352         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4353
4354 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4355
4356         [ews-app] Remove BuilderMapping table
4357         https://bugs.webkit.org/show_bug.cgi?id=194961
4358
4359         Reviewed by Stephanie Lewis.
4360
4361         Store builder name directly in build table, instead of having a separate
4362         table for it.
4363
4364         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4365         * BuildSlaveSupport/ews-app/ews/models/build.py:
4366         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4367         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4368
4369 2019-02-25  John Wilander  <wilander@apple.com>
4370
4371         Introduce and adopt new class RegistrableDomain for eTLD+1
4372         https://bugs.webkit.org/show_bug.cgi?id=194791