Add script to merge run_benchmark jsons
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-19  Keith Miller  <keith_miller@apple.com>
2
3         Add script to merge run_benchmark jsons
4         https://bugs.webkit.org/show_bug.cgi?id=197107
5
6         Reviewed by Michael Saboff.
7
8         The script basically recursively decends through all json objects until it gets
9         to an array or JSON primitive and concats or takes the first value, respectively.
10
11         This patch also adds +x bits to the compare-results script so it
12         can be run directly from the command line. I had to add a new line so that svn
13         will accept the change... yay svn!
14
15         * Scripts/compare-results:
16         * Scripts/merge-result-jsons: Added.
17         (readJSONFile):
18         (deepAppend):
19         (mergeJSONs):
20         (main):
21
22 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
25         https://bugs.webkit.org/show_bug.cgi?id=197079
26
27         Reviewed by Darin Adler.
28
29         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
30
31         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
32         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
33
34 2019-04-18  Commit Queue  <commit-queue@webkit.org>
35
36         Unreviewed, rolling out r244434.
37         https://bugs.webkit.org/show_bug.cgi?id=197089
38
39         caused 1 API test failure (Requested by zalan on #webkit).
40
41         Reverted changeset:
42
43         "Regression (r244291): Broken API Test
44         AutoLayoutRenderingProgressRelativeOrdering"
45         https://bugs.webkit.org/show_bug.cgi?id=196948
46         https://trac.webkit.org/changeset/244434
47
48 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
49
50         Add new compatibility mode API on WKNavigation
51         https://bugs.webkit.org/show_bug.cgi?id=197069
52         <rdar://problem/50025800>
53
54         Reviewed by Tim Horton.
55
56         Add a block property for -didCommitNavigation to TestNavigationDelegate.
57
58         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
59         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
60         (-[TestNavigationDelegate webView:didCommitNavigation:]):
61
62 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
63
64         [CMake] Make WebCore headers copies
65         https://bugs.webkit.org/show_bug.cgi?id=182512
66         <rdar://problem/37510435>
67
68         Reviewed by Alex Christensen.
69
70         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
71         ports.
72
73         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
74         of WebCore headers using "*.h" were modified to <WebCore/*.h>
75
76         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
77         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
78         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
79         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
80         * TestWebKitAPI/CMakeLists.txt:
81         * TestWebKitAPI/PlatformWin.cmake:
82         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
83         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
84         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
85
86 2019-04-18  Jer Noble  <jer.noble@apple.com>
87
88         Add support for parsing FairPlayStreaming PSSH boxes.
89         https://bugs.webkit.org/show_bug.cgi?id=197064
90
91         Reviewed by Eric Carlson.
92
93         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
94         (TestWebKitAPI::TEST):
95
96 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
97
98         InjectedBundle parameters often need initialization function called before unarchiving
99         https://bugs.webkit.org/show_bug.cgi?id=189709
100         <rdar://problem/44573653>
101
102         Reviewed by Ryosuke Niwa.
103
104         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
105         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
106
107 2019-04-18  Zalan Bujtas  <zalan@apple.com>
108
109         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
110         https://bugs.webkit.org/show_bug.cgi?id=196948
111         <rdar://problem/49927131>
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
116         (TEST): 
117         The expected order of incoming events is
118         1. didInvalidateIntrinsicContentSize
119         2. didFirstLayout
120         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
121         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
122         (and remember, all we care about is ordering).
123
124 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
125
126         Unreviewed, rolling out r244299.
127
128         Breaks internal tests.
129
130         Reverted changeset:
131
132         "InjectedBundle parameters often need initialization function
133         called before unarchiving"
134         https://bugs.webkit.org/show_bug.cgi?id=189709
135         https://trac.webkit.org/changeset/244299
136
137 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
138
139         [WTF] StringBuilder should set correct m_is8Bit flag when merging
140         https://bugs.webkit.org/show_bug.cgi?id=197053
141
142         Reviewed by Saam Barati.
143
144         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
145         (TestWebKitAPI::TEST):
146
147 2019-04-17  Tim Horton  <timothy_horton@apple.com>
148
149         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
150         https://bugs.webkit.org/show_bug.cgi?id=197028
151         <rdar://problem/49985290>
152
153         Reviewed by Wenson Hsieh.
154
155         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
156         (TEST):
157         Liberal application of waitForNextPresentationUpdate works around a race
158         where if the page rapidly changes its viewport arguments (or an API client
159         rapidly changes its viewport arguments), we'd get stuck thinking that the
160         user had intentionally zoomed the page, and stop resetting the initial scale.
161         This deserves a separate bug, but no need to keep the test failing while
162         we think about it.
163
164 2019-04-17  Tim Horton  <timothy_horton@apple.com>
165
166         REGRESSION (r241988): Switching tabs is slow
167         https://bugs.webkit.org/show_bug.cgi?id=197037
168         <rdar://problem/49951473>
169
170         Reviewed by Simon Fraser.
171
172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
173         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
174         (TEST):
175         * TestWebKitAPI/cocoa/TestWKWebView.h:
176         * TestWebKitAPI/cocoa/TestWKWebView.mm:
177         (-[TestWKWebView addToTestWindow]):
178         Add a test that hangs without this fix.
179
180 2019-04-17  Truitt Savell  <tsavell@apple.com>
181
182         Unreviewed, rolling out r244400.
183
184         Caused testing to exit early with assertionon Debug WK2
185
186         Reverted changeset:
187
188         "UI↔Web deadlock when printing with a JavaScript alert
189         visible"
190         https://bugs.webkit.org/show_bug.cgi?id=196839
191         https://trac.webkit.org/changeset/244400
192
193 2019-04-17  Brady Eidson  <beidson@apple.com>
194
195         Link clicks in PDFs shouldn't send referrer headers.
196         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
197
198         Reviewed by Tim Horton.
199
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
202         (putPDFBytesCallback):
203         (emptyReleaseInfoCallback):
204         (createPDFWithLinkToURL):
205         (TEST):
206
207 2019-04-17  Tim Horton  <timothy_horton@apple.com>
208
209         UI↔Web deadlock when printing with a JavaScript alert visible
210         https://bugs.webkit.org/show_bug.cgi?id=196839
211         <rdar://problem/49157642>
212
213         Reviewed by Andy Estes.
214
215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
216         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
217         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
218         (TEST):
219
220 2019-04-17  Alex Christensen  <achristensen@webkit.org>
221
222         WKRetainPtr's adoption constructor should be private
223         https://bugs.webkit.org/show_bug.cgi?id=197019
224
225         Reviewed by Tim Horton.
226
227         * DumpRenderTree/mac/DumpRenderTree.mm:
228         (dumpFramesAsText):
229         * TestWebKitAPI/InjectedBundleController.cpp:
230         (TestWebKitAPI::InjectedBundleController::initialize):
231         * TestWebKitAPI/PlatformUtilities.cpp:
232         (TestWebKitAPI::Util::createContextWithInjectedBundle):
233         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
234         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
235         (TestWebKitAPI::Util::toWK):
236         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
237         (TestWebKitAPI::TEST):
238         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
239         (TestWebKitAPI::TEST):
240         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
245         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
246         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
249         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
250         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
255         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
256         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
257         (TestWebKitAPI::TEST):
258         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
259         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
260         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
265         (TestWebKitAPI::TEST):
266         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
267         (TestWebKitAPI::TEST):
268         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WebKit/Find.cpp:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
273         (TestWebKitAPI::TEST):
274         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
275         (TestWebKitAPI::TEST):
276         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
287         (TestWebKitAPI::TEST):
288         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
289         (TestWebKitAPI::TEST):
290         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
291         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
292         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
295         (TestWebKitAPI::TEST):
296         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
297         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
298         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
299         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
302         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
303         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
308         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
309         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
312         (TestWebKitAPI::loadAlternateHTMLString):
313         (TestWebKitAPI::TEST):
314         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
315         (TestWebKitAPI::TEST):
316         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
317         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
318         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
319         (TestWebKitAPI::buildAndPerformTest):
320         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
321         (TestWebKitAPI::TEST):
322         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
323         (TestWebKitAPI::TEST):
324         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
325         (TestWebKitAPI::TEST):
326         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
327         (TestWebKitAPI::TEST):
328         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
331         (TestWebKitAPI::TEST):
332         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
341         (TestWebKitAPI::TEST):
342         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
343         (TestWebKitAPI::TEST):
344         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
345         (TestWebKitAPI::TEST):
346         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
349         (TestWebKitAPI::TEST):
350         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
351         (TestWebKitAPI::TEST):
352         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
353         (TestWebKitAPI::TEST):
354         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
361         (TestWebKitAPI::TEST):
362         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
363         (TestWebKitAPI::TEST):
364         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
367         (TestWebKitAPI::TEST):
368         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
369         (TestWebKitAPI::TEST):
370         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
373         (TestWebKitAPI::TEST):
374         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
375         (TestWebKitAPI::TEST):
376         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
377         (TestWebKitAPI::TEST):
378         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
379         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
380         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
383         (TestWebKitAPI::TEST):
384         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
385         (TestWebKitAPI::TEST):
386         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
393         (TestWebKitAPI::TEST):
394         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
402         (TEST):
403         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
404         (TEST):
405         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
406         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
407         (TEST):
408         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
409         (TestWebKitAPI::TEST):
410         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
411         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
412         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
413         (WTR::getMenuItemTitleCallback):
414         (WTR::createMouseMessageBody):
415         (WTR::EventSendingController::mouseDown):
416         (WTR::EventSendingController::mouseUp):
417         (WTR::EventSendingController::mouseMoveTo):
418         (WTR::EventSendingController::mouseForceClick):
419         (WTR::EventSendingController::startAndCancelMouseForceClick):
420         (WTR::EventSendingController::mouseForceDown):
421         (WTR::EventSendingController::mouseForceUp):
422         (WTR::EventSendingController::mouseForceChanged):
423         (WTR::EventSendingController::leapForward):
424         (WTR::EventSendingController::scheduleAsynchronousClick):
425         (WTR::createKeyDownMessageBody):
426         (WTR::EventSendingController::keyDown):
427         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
428         (WTR::EventSendingController::mouseScrollBy):
429         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
430         (WTR::EventSendingController::continuousMouseScrollBy):
431         (WTR::EventSendingController::addTouchPoint):
432         (WTR::EventSendingController::updateTouchPoint):
433         (WTR::EventSendingController::setTouchModifier):
434         (WTR::EventSendingController::setTouchPointRadius):
435         (WTR::EventSendingController::touchStart):
436         (WTR::EventSendingController::touchMove):
437         (WTR::EventSendingController::touchEnd):
438         (WTR::EventSendingController::touchCancel):
439         (WTR::EventSendingController::clearTouchPoints):
440         (WTR::EventSendingController::releaseTouchPoint):
441         (WTR::EventSendingController::cancelTouchPoint):
442         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
443         (WTR::InjectedBundle::didCreatePage):
444         (WTR::InjectedBundle::didReceiveMessage):
445         (WTR::InjectedBundle::didReceiveMessageToPage):
446         (WTR::InjectedBundle::booleanForKey):
447         (WTR::InjectedBundle::done):
448         (WTR::InjectedBundle::dumpToStdErr):
449         (WTR::InjectedBundle::outputText):
450         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
451         (WTR::InjectedBundle::postAddChromeInputField):
452         (WTR::InjectedBundle::postRemoveChromeInputField):
453         (WTR::InjectedBundle::postFocusWebView):
454         (WTR::InjectedBundle::postSetBackingScaleFactor):
455         (WTR::InjectedBundle::postSetWindowIsKey):
456         (WTR::InjectedBundle::postSetViewSize):
457         (WTR::InjectedBundle::postSimulateWebNotificationClick):
458         (WTR::InjectedBundle::postSetAddsVisitedLinks):
459         (WTR::InjectedBundle::setGeolocationPermission):
460         (WTR::InjectedBundle::setMockGeolocationPosition):
461         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
462         (WTR::InjectedBundle::isGeolocationProviderActive const):
463         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
464         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
465         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
466         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
467         (WTR::InjectedBundle::setCustomPolicyDelegate):
468         (WTR::InjectedBundle::setHidden):
469         (WTR::InjectedBundle::setCacheModel):
470         (WTR::InjectedBundle::shouldProcessWorkQueue const):
471         (WTR::InjectedBundle::processWorkQueue):
472         (WTR::InjectedBundle::queueBackNavigation):
473         (WTR::InjectedBundle::queueForwardNavigation):
474         (WTR::InjectedBundle::queueLoad):
475         (WTR::InjectedBundle::queueLoadHTMLString):
476         (WTR::InjectedBundle::queueReload):
477         (WTR::InjectedBundle::queueLoadingScript):
478         (WTR::InjectedBundle::queueNonLoadingScript):
479         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
480         (WTR::frameToStr):
481         (WTR::InjectedBundlePage::InjectedBundlePage):
482         (WTR::dumpFrameDescriptionSuitableForTestResult):
483         (WTR::dumpFrameScrollPosition):
484         (WTR::dumpDescendantFrameScrollPositions):
485         (WTR::dumpFrameText):
486         (WTR::dumpDescendantFramesText):
487         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
488         (WTR::TestRunner::shouldDumpPixels const):
489         (WTR::TestRunner::setDumpPixels):
490         (WTR::TestRunner::whatToDump const):
491         (WTR::TestRunner::setWhatToDump):
492         (WTR::TestRunner::setWaitUntilDone):
493         (WTR::TestRunner::shouldWaitUntilDone const):
494         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
495         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
496         (WTR::TestRunner::clearAllDatabases):
497         (WTR::TestRunner::setIDBPerOriginQuota):
498         (WTR::TestRunner::originsWithApplicationCache):
499         (WTR::TestRunner::setCanOpenWindows):
500         (WTR::TestRunner::setXSSAuditorEnabled):
501         (WTR::TestRunner::setMediaDevicesEnabled):
502         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
503         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
504         (WTR::TestRunner::setCustomUserAgent):
505         (WTR::TestRunner::setWebAPIStatisticsEnabled):
506         (WTR::TestRunner::setModernMediaControlsEnabled):
507         (WTR::TestRunner::setWebGL2Enabled):
508         (WTR::TestRunner::setWritableStreamAPIEnabled):
509         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
510         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
511         (WTR::TestRunner::setAllowsAnySSLCertificate):
512         (WTR::TestRunner::setPluginsEnabled):
513         (WTR::TestRunner::setValueForUser):
514         (WTR::TestRunner::setAudioResult):
515         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
516         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
517         (WTR::TestRunner::setAlwaysAcceptCookies):
518         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
519         (WTR::TestRunner::isDoingMediaCapture const):
520         (WTR::TestRunner::queueLoad):
521         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
522         (WTR::TestRunner::setHandlesAuthenticationChallenges):
523         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
524         (WTR::TestRunner::setShouldLogDownloadCallbacks):
525         (WTR::TestRunner::setAuthenticationUsername):
526         (WTR::TestRunner::setAuthenticationPassword):
527         (WTR::TestRunner::secureEventInputIsEnabled const):
528         (WTR::TestRunner::setBlockAllPlugins):
529         (WTR::TestRunner::setPluginSupportedMode):
530         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
531         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
532         (WTR::TestRunner::setNavigationGesturesEnabled):
533         (WTR::TestRunner::setIgnoresViewportScaleLimits):
534         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
535         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
536         (WTR::TestRunner::terminateNetworkProcess):
537         (WTR::TestRunner::terminateServiceWorkerProcess):
538         (WTR::TestRunner::runUIScript):
539         (WTR::TestRunner::setStatisticsDebugMode):
540         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
541         (WTR::TestRunner::setStatisticsLastSeen):
542         (WTR::TestRunner::setStatisticsPrevalentResource):
543         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
544         (WTR::TestRunner::dumpResourceLoadStatistics):
545         (WTR::TestRunner::isStatisticsPrevalentResource):
546         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
547         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
548         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
549         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
550         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
551         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
552         (WTR::TestRunner::setStatisticsGrandfathered):
553         (WTR::TestRunner::isStatisticsGrandfathered):
554         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
555         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
556         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
557         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
558         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
559         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
560         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
561         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
562         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
563         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
564         (WTR::TestRunner::statisticsUpdateCookieBlocking):
565         (WTR::TestRunner::statisticsSubmitTelemetry):
566         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
567         (WTR::TestRunner::setStatisticsIsRunningTest):
568         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
569         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
570         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
571         (WTR::TestRunner::setStatisticsGrandfatheringTime):
572         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
573         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
574         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
575         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
576         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
577         (WTR::TestRunner::statisticsDeleteCookiesForHost):
578         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
579         (WTR::TestRunner::statisticsResetToConsistentState):
580         (WTR::TestRunner::setStorageAccessAPIEnabled):
581         (WTR::TestRunner::getAllStorageAccessEntries):
582         (WTR::TestRunner::addMockMediaDevice):
583         (WTR::TestRunner::clearMockMediaDevices):
584         (WTR::TestRunner::removeMockMediaDevice):
585         (WTR::TestRunner::resetMockMediaDevices):
586         (WTR::TestRunner::connectMockGamepad):
587         (WTR::TestRunner::disconnectMockGamepad):
588         (WTR::TestRunner::setMockGamepadDetails):
589         (WTR::TestRunner::setMockGamepadAxisValue):
590         (WTR::TestRunner::setMockGamepadButtonValue):
591         (WTR::TestRunner::removeAllSessionCredentials):
592         (WTR::TestRunner::clearDOMCache):
593         (WTR::TestRunner::clearDOMCaches):
594         (WTR::TestRunner::hasDOMCache):
595         (WTR::TestRunner::domCacheSize):
596         (WTR::TestRunner::setAllowStorageQuotaIncrease):
597         (WTR::TestRunner::getApplicationManifestThen):
598         (WTR::TestRunner::injectUserScript):
599         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
600         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
601         (WTR::TestRunner::addTestKeyToKeychain):
602         (WTR::TestRunner::cleanUpKeychain):
603         (WTR::TestRunner::keyExistsInKeychain):
604         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
605         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
606         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
607         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
608         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
609         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
610         * WebKitTestRunner/TestController.cpp:
611         (WTR::TestController::initialize):
612         (WTR::parseStringTestHeaderValueAsRelativePath):
613         (WTR::updateTestOptionsFromTestHeader):
614         (WTR::TestController::runTest):
615         (WTR::TestController::didReceiveLiveDocumentsList):
616         (WTR::TestController::didReceiveMessageFromInjectedBundle):
617         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
618         (WTR::TestController::didFinishNavigation):
619         (WTR::TestController::didReceiveAuthenticationChallenge):
620         * WebKitTestRunner/TestInvocation.cpp:
621         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
623         (WTR::TestInvocation::uiScriptDidComplete):
624         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
625         * WebKitTestRunner/WebNotificationProvider.cpp:
626         (WTR::WebNotificationProvider::closeWebNotification):
627         * WebKitTestRunner/WorkQueueManager.cpp:
628         (WTR::ScriptItem::ScriptItem):
629         (WTR::WorkQueueManager::queueLoad):
630         (WTR::WorkQueueManager::queueLoadHTMLString):
631
632 2019-04-17  Alex Christensen  <achristensen@webkit.org>
633
634         Add a comment to make my test from r244139 less mysterious.
635         https://bugs.webkit.org/show_bug.cgi?id=196744
636
637         As suggested by Darin Adler.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
640         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
641
642 2019-04-17  Chris Dumez  <cdumez@apple.com>
643
644         Remember device orientation permission for the duration of the browsing session
645         https://bugs.webkit.org/show_bug.cgi?id=196992
646         <rdar://problem/49946067>
647
648         Reviewed by Alex Christensen.
649
650         Add API test coverage.
651
652         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
653         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
654         (TEST):
655
656 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
659         https://bugs.webkit.org/show_bug.cgi?id=196675
660
661         Reviewed by Lucas Forschler.
662
663         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
664         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
665
666 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
667
668         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
669         https://bugs.webkit.org/show_bug.cgi?id=196919
670         <rdar://problem/41630459>
671
672         Reviewed by Tim Horton.
673
674         Add iOS support for several new testing hooks. See below for more detail.
675
676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
677         (WTR::UIScriptController::isDismissingMenu const):
678
679         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
680         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
681         by UIKit when dismissing the callout bar (i.e. UIMenuController).
682
683         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
684         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
685         (WTR::UIScriptController::isDismissingMenu const):
686         * TestRunnerShared/UIScriptContext/UIScriptController.h:
687         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
688         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
689         (WTR::InjectedBundle::didReceiveMessageToPage):
690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
691         (WTR::TestRunner::setAllowedMenuActions):
692
693         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
694         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
695         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
696         against the name of the custom action.
697
698         (WTR::TestRunner::installCustomMenuAction):
699
700         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
701         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
702         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
703         triggered.
704
705         (WTR::TestRunner::performCustomMenuAction):
706
707         Invoked when the custom menu action is triggered.
708
709         * WebKitTestRunner/InjectedBundle/TestRunner.h:
710         * WebKitTestRunner/TestController.cpp:
711         (WTR::TestController::installCustomMenuAction):
712         (WTR::TestController::setAllowedMenuActions):
713         * WebKitTestRunner/TestController.h:
714         * WebKitTestRunner/TestInvocation.cpp:
715         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
716         (WTR::TestInvocation::performCustomMenuAction):
717
718         Add plumbing to call back into the injected bundle when performing the custom action.
719
720         * WebKitTestRunner/TestInvocation.h:
721         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
722         (WTR::TestController::installCustomMenuAction):
723         (WTR::TestController::setAllowedMenuActions):
724         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
725         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
726         (-[TestRunnerWKWebView initWithFrame:configuration:]):
727         (-[TestRunnerWKWebView becomeFirstResponder]):
728         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
729
730         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
731         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
732         in the Mail app on iOS.
733
734         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
735         (-[TestRunnerWKWebView setAllowedMenuActions:]):
736         (-[TestRunnerWKWebView resetCustomMenuAction]):
737         (-[TestRunnerWKWebView performCustomAction:]):
738         (-[TestRunnerWKWebView canPerformAction:withSender:]):
739         (-[TestRunnerWKWebView _willHideMenu]):
740         (-[TestRunnerWKWebView _didHideMenu]):
741         * WebKitTestRunner/ios/TestControllerIOS.mm:
742         (WTR::TestController::platformResetStateToConsistentValues):
743
744         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
745         if specified.
746
747         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
748         (WTR::UIScriptController::isDismissingMenu const):
749
750 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
751
752         Allow sharing from imageSheet on an image document
753         https://bugs.webkit.org/show_bug.cgi?id=196891
754         <rdar://problem/25377386>
755
756         Reviewed by Tim Horton.
757
758         Test to make sure that the correct imageURL is extracted from an image element.
759
760         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
761         (TestWebKitAPI::TEST):
762
763 2019-04-16  Alex Christensen  <achristensen@webkit.org>
764
765         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
766         https://bugs.webkit.org/show_bug.cgi?id=196995
767
768         Reviewed by Brady Eidson.
769
770         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
771         (TEST):
772
773 2019-04-16  Chris Dumez  <cdumez@apple.com>
774
775         URL set by document.open() is not communicated to the UIProcess
776         https://bugs.webkit.org/show_bug.cgi?id=196941
777         <rdar://problem/49237544>
778
779         Reviewed by Geoff Garen.
780
781         Add API test coverage.
782
783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
784         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
785         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
786         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
787         (TEST):
788
789 2019-04-16  Commit Queue  <commit-queue@webkit.org>
790
791         Unreviewed, rolling out r244321.
792         https://bugs.webkit.org/show_bug.cgi?id=196968
793
794         Causing all WK2 Debug builds to exit early after Assertion
795         failures. (Requested by ShawnRoberts on #webkit).
796
797         Reverted changeset:
798
799         "URL set by document.open() is not communicated to the
800         UIProcess"
801         https://bugs.webkit.org/show_bug.cgi?id=196941
802         https://trac.webkit.org/changeset/244321
803
804 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
805
806         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
807         https://bugs.webkit.org/show_bug.cgi?id=196948
808
809         Reviewed by Zalan Bujtas.
810
811         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
812         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
813
814 2019-04-15  Chris Dumez  <cdumez@apple.com>
815
816         URL set by document.open() is not communicated to the UIProcess
817         https://bugs.webkit.org/show_bug.cgi?id=196941
818         <rdar://problem/49237544>
819
820         Reviewed by Geoffrey Garen.
821
822         Add API test coverage.
823
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
826         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
827         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
828         (TEST):
829
830 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
831
832         Using Tools/Scripts/clean-webkit should not install requests
833         https://bugs.webkit.org/show_bug.cgi?id=196940
834
835         Reviewed by Lucas Forschler.
836
837         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
838         existing, depending on the path autoinstalled is run through.
839         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
840         needed.
841         (Port.configuration_for_upload):
842         (Port.commits_for_upload):
843
844 2019-04-15  Alex Christensen  <achristensen@webkit.org>
845
846         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
847         https://bugs.webkit.org/show_bug.cgi?id=196773
848
849         Reviewed by Jer Noble.
850
851         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
852         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
853         (TEST):
854
855 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
856
857         ews-build should clearly indicate flaky test failures
858         https://bugs.webkit.org/show_bug.cgi?id=196947
859
860         Reviewed by Lucas Forschler.
861
862         * BuildSlaveSupport/ews-build/steps.py:
863         (AnalyzeAPITestsResults.analyzeResults):
864
865 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
866
867         InjectedBundle parameters often need initialization function called before unarchiving
868         https://bugs.webkit.org/show_bug.cgi?id=189709
869         <rdar://problem/44573653>
870
871         Reviewed by Ryosuke Niwa.
872
873         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
874         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
875
876 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
877
878         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
879         https://bugs.webkit.org/show_bug.cgi?id=196681
880
881         Reviewed by Darin Adler.
882
883         Added tests.
884
885         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
886         (WTF_HashSet.RemoveIf):
887         (WTF_HashSet.RemoveIfShrinkToBestSize):
888
889 2019-04-15  John Wilander  <wilander@apple.com>
890
891         Send delayed Ad Click Attribution conversion requests to the click source
892         https://bugs.webkit.org/show_bug.cgi?id=196838
893         <rdar://problem/47650157>
894
895         Reviewed by Chris Dumez and Youenn Fablet.
896
897         This patch adds test infrastructure to override the default behavior in
898         WebKit::NetworkAdClickAttribution.
899
900         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
901         (TestWebKitAPI::TEST):
902         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
904         (WTR::TestRunner::dumpAdClickAttribution):
905         (WTR::TestRunner::clearAdClickAttribution):
906         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
907         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
909         * WebKitTestRunner/TestController.cpp:
910         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
911         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
912         * WebKitTestRunner/TestController.h:
913         * WebKitTestRunner/TestInvocation.cpp:
914         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
915
916 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
917
918         [ews-app] status-bubble should display position in queue
919         https://bugs.webkit.org/show_bug.cgi?id=196607
920
921         Reviewed by Lucas Forschler.
922
923         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
924         (StatusBubble._build_bubble):
925         (StatusBubble._queue_position): Method to calculate patch's position in queue.
926
927 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
928
929         [ews-build] Do not run clean build by default on EWS builders
930         https://bugs.webkit.org/show_bug.cgi?id=196897
931
932         Reviewed by Lucas Forschler.
933
934         * BuildSlaveSupport/ews-build/steps.py:
935         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
936         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
937         untracked directories like WebKitBuild).
938         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
939         untracked files/directories (like WebKitBuild).
940
941 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
942
943         TestRunner::notifyDone() should be safely reentrant
944         https://bugs.webkit.org/show_bug.cgi?id=196898
945
946         Reviewed by Darin Adler.
947
948         It is currently possible that TestRunner::notifyDone() will call itself, since
949         notifyDone() will force a repaint, which can start executing JavaScript, which
950         may call notifyDone() again. This can lead to test failures and flakiness.
951         Fix this by setting the m_waitToDump flag before calling the dump() method.
952
953         * DumpRenderTree/mac/TestRunnerMac.mm:
954         (TestRunner::notifyDone):
955         (TestRunner::forceImmediateCompletion):
956         * DumpRenderTree/win/TestRunnerWin.cpp:
957         (TestRunner::notifyDone):
958         (TestRunner::forceImmediateCompletion):
959
960 2019-04-15  Philippe Normand  <pnormand@igalia.com>
961
962         [GTK][WPE] Add enable-media websetting
963         https://bugs.webkit.org/show_bug.cgi?id=196863
964
965         Reviewed by Michael Catanzaro.
966
967         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
968         (testWebKitSettings): Add test for the enable-media web-setting.
969
970 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
971
972         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
973         https://bugs.webkit.org/show_bug.cgi?id=196905
974         <rdar://problem/49886096>
975
976         Reviewed by Tim Horton.
977
978         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
979         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
980         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
981         delay timer, we end up with this sequence of events in the problematic (failure) case:
982
983         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
984             ...IPC from UI to web process...
985         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
986             ...IPC from web to UI process...
987         (c) [UI]    Invoke completion handler for script #1
988         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
989             ...IPC from UI to web process...
990         (e) [Web]   Evaluate script #2 in the web process
991         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
992
993         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
994         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
995         #2 is run in step (e).
996
997         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
998         the UI process by waiting on a script message posted by the web process, after attachment updates are
999         dispatched.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1002         (TestWebKitAPI::TEST):
1003
1004 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1005
1006         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1007         https://bugs.webkit.org/show_bug.cgi?id=196909
1008
1009         Reviewed by Wenson Hsieh.
1010
1011         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1012         (TestWebKitAPI::TEST):
1013
1014 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1015
1016         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1017         https://bugs.webkit.org/show_bug.cgi?id=196880
1018
1019         Reviewed by Yusuke Suzuki.
1020
1021         Add a new function for bytecode cache tests that does not forceDiskCache
1022         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1023         test added in this patch, since the code is invalid and therefore won't be
1024         cached. It should also be useful for tests that evaluate dynamically
1025         generated code.
1026
1027         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1028         * Scripts/run-jsc-stress-tests:
1029
1030 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1031
1032         Update AudioSession route sharing policy
1033         https://bugs.webkit.org/show_bug.cgi?id=196776
1034         <rdar://problem/46501611>
1035
1036         Reviewed by Jer Noble.
1037
1038         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1039         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1040         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1041         (TestWebKitAPI::TEST):
1042
1043 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1044
1045         [iOS] Software keyboard is shown too frequently on some websites
1046         https://bugs.webkit.org/show_bug.cgi?id=195856
1047         <rdar://problem/49191395>
1048
1049         Reviewed by Darin Adler.
1050
1051         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1052
1053         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1054         (WTR::UIScriptController::setHardwareKeyboardAttached):
1055         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1056         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1057         (WTR::UIScriptController::setHardwareKeyboardAttached):
1058         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1059         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1060
1061         Additionally link against GraphicsServices in WebKitTestRunner.
1062
1063         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1064         (WTR::TestController::platformResetStateToConsistentValues):
1065         (WTR::UIScriptController::setHardwareKeyboardAttached):
1066
1067 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1068
1069         [GTK][WPE] Fix pacman install-dependencies packages
1070         https://bugs.webkit.org/show_bug.cgi?id=196817
1071
1072         Reviewed by Žan Doberšek.
1073         
1074         python3-setuptools is called python-setuptools
1075         ruby-highline is only available on AUR
1076         libv4l-devel is incorporated in v4l-utils
1077
1078         * gtk/install-dependencies:
1079         * wpe/install-dependencies:
1080
1081 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         [GTK] REGRESSION(r243860): Many tests failing
1084         https://bugs.webkit.org/show_bug.cgi?id=196791
1085
1086         Reviewed by Joanmarie Diggs.
1087
1088         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1089         multiple documents and check that accessibility hierarchy is updated after a navigation.
1090
1091         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1092         (loadChangedCallback):
1093         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1094         (AccessibilityTest::AccessibilityTest):
1095         (AccessibilityTest::~AccessibilityTest):
1096         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1097         (AccessibilityTest::findTestServerApplication):
1098         (AccessibilityTest::findDocumentWeb):
1099         (AccessibilityTest::findRootObject):
1100         (AccessibilityTest::waitUntilChildrenRemoved):
1101         (AccessibilityTest::ensureProxy):
1102         (testAtspiBasicHierarchy):
1103         (beforeAll):
1104         (afterAll):
1105
1106 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1107
1108         [ews-build] Handle bug titles with unicode characters
1109         https://bugs.webkit.org/show_bug.cgi?id=196802
1110
1111         Reviewed by Dewei Zhu.
1112
1113         * BuildSlaveSupport/ews-build/steps.py:
1114         (ValidatePatch._is_bug_closed):
1115
1116 2019-04-11  Michael Saboff  <msaboff@apple.com>
1117
1118         Improve the Inline Cache Stats code
1119         https://bugs.webkit.org/show_bug.cgi?id=196836
1120
1121         Reviewed by Saam Barati.
1122
1123         Added a new script to consolidate and arrange the output of --useICStats option.
1124
1125         This script merges the output from every group into one large table and sorts it from most common to
1126         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1127         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1128         Put together, this is useful to see what property accesses are not getting cached.
1129
1130         * Scripts/ic-stats.py: Added.
1131         (ICStats):
1132         (ICStats.__init__):
1133         (ICStats.parse):
1134         (ICStats.dumpStats):
1135         (usage):
1136
1137 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1138
1139         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1140         https://bugs.webkit.org/show_bug.cgi?id=196809
1141         <rdar://49800762>
1142
1143         Reviewed by Brady Eidson.
1144
1145         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1146         (TEST):
1147
1148 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1149
1150         requestAnimationFrame should execute before the next frame
1151         https://bugs.webkit.org/show_bug.cgi?id=177484
1152
1153         Reviewed by Simon Fraser.
1154
1155         Add trace points for the page RenderingUpdate.
1156
1157         * Tracing/SystemTracePoints.plist:
1158
1159 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1160
1161         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1162         https://bugs.webkit.org/show_bug.cgi?id=196760
1163
1164         Reviewed by Don Olmstead.
1165
1166         vswhere.exe has been bundled since Visual Studio 2017 version
1167         15.2. We shouldn't download vswhere.exe.
1168
1169         * Scripts/build-jsc: Do not call update-vswhere.py.
1170         * Scripts/build-webkit: Ditto.
1171         * Scripts/update-vswhere.py: Removed.
1172         * Scripts/webkitdirs.pm:
1173         (requireModulesForVSWhere): Deleted.
1174         (pickCurrentVisualStudioInstallation): Deleted.
1175         (visualStudioInstallDirVSWhere): Return the latest installed VS
1176         installation path by using the bundled vswhere.exe.
1177         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1178         (visualStudioInstallDirFallback): Removed.
1179
1180 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1183         https://bugs.webkit.org/show_bug.cgi?id=196780
1184
1185         Reviewed by Alexey Proskuryakov.
1186
1187         * BuildSlaveSupport/ews-build/steps.py:
1188         * BuildSlaveSupport/ews-build/steps_unittest.py:
1189
1190 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1191
1192         Add SPI WKNavigationResponse._downloadAttribute
1193         https://bugs.webkit.org/show_bug.cgi?id=196755
1194         <rdar://49587365>
1195
1196         Reviewed by Brady Eidson.
1197
1198         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1199         (-[NavigationResponseTestDelegate navigationResponse]):
1200         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1201         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1202         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1203         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1204         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1205         (readRequest):
1206         (writeResponse):
1207         (TEST):
1208
1209 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1210
1211         Add modern API for overriding the page's specified viewport configuration
1212         https://bugs.webkit.org/show_bug.cgi?id=167734
1213         <rdar://problem/30331795>
1214
1215         Reviewed by Simon Fraser.
1216
1217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1218         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1219
1220 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1221
1222         Add support for incremental bytecode cache updates
1223         https://bugs.webkit.org/show_bug.cgi?id=195000
1224
1225         Reviewed by Filip Pizlo.
1226
1227         Exit when the initial run to generate bytecode fails.
1228
1229         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1230
1231 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1232
1233         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1234         https://bugs.webkit.org/show_bug.cgi?id=196744
1235         <rdar://49415309>
1236
1237         Reviewed by Chris Dumez.
1238
1239         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1240         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1241
1242 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1243
1244         Add a way to opt into modern compatibility mode in layout tests
1245         https://bugs.webkit.org/show_bug.cgi?id=196770
1246         <rdar://problem/49777550>
1247
1248         Reviewed by Antoine Quint.
1249
1250         Add a new test option to enable modern compatibility mode in layout tests.
1251
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::updateTestOptionsFromTestHeader):
1254         * WebKitTestRunner/TestController.h:
1255         * WebKitTestRunner/TestOptions.h:
1256         (WTR::TestOptions::hasSameInitializationOptions const):
1257         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1258         (WTR::TestController::platformCreateWebView):
1259         (WTR::TestController::enableModernCompatibilityMode):
1260
1261 2019-04-10  Andy Estes  <aestes@apple.com>
1262
1263         Try to fix the 32-bit watchOS build.
1264
1265         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1266         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1267
1268 2019-04-10  Antoine Quint  <graouts@apple.com>
1269
1270         Enable Pointer Events on watchOS
1271         https://bugs.webkit.org/show_bug.cgi?id=196771
1272         <rdar://problem/49040909>
1273
1274         Reviewed by Dean Jackson.
1275
1276         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1277
1278 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1279
1280         Unreviewed. Fix WPE accessibility tests after r244059.
1281
1282         We are failing to load the injected bundle due to undefined symbol
1283         AccessibilityUIElement::replaceTextInRange().
1284
1285         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1286         (WTR::AccessibilityUIElement::replaceTextInRange):
1287
1288 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1289
1290         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1291         https://bugs.webkit.org/show_bug.cgi?id=196727
1292
1293         Reviewed by Fujii Hironori.
1294
1295         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1296         (WebKitBrowserWindow::create):
1297
1298 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-build] Add unit tests for PrintConfiguration
1301         https://bugs.webkit.org/show_bug.cgi?id=196752
1302
1303         Reviewed by Dewei Zhu.
1304
1305         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1306
1307 2019-04-09  Keith Rollin  <krollin@apple.com>
1308
1309         Unreviewed build maintenance -- update .xcfilelists.
1310
1311         * DumpRenderTree/DerivedSources-input.xcfilelist:
1312         * DumpRenderTree/DerivedSources-output.xcfilelist:
1313
1314 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1315
1316         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1317         https://bugs.webkit.org/show_bug.cgi?id=196743
1318         <rdar://problem/43897551>
1319
1320         Reviewed by Tim Horton.
1321
1322         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1323         (TEST):
1324
1325 2019-04-09  Youenn Fablet  <youenn@apple.com>
1326
1327         Close service worker database on network process suspension
1328         https://bugs.webkit.org/show_bug.cgi?id=196623
1329         <rdar://problem/48930869>
1330
1331         Reviewed by Alex Christensen.
1332
1333         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1334
1335 2019-04-09  Daniel Bates  <dabates@apple.com>
1336
1337         [iPad] Should open popover when the spacebar is pressed
1338         https://bugs.webkit.org/show_bug.cgi?id=196360
1339         <rdar://problem/49389129>
1340
1341         Reviewed by Brent Fulgham.
1342
1343         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1344
1345         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1346         (WTR::UIScriptController::isShowingPopover const): Added.
1347         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1348         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1349         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1350         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1351         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1352         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1353         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1354         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1355         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1356         (WTR::UIScriptController::isShowingPopover const): Added.
1357         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1358         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1359         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1360         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1361         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1362         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1363         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1364         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1365         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1366         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1367         (WTR::UIScriptController::isShowingPopover const): Added.
1368         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1369         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1370
1371 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1372
1373         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1374         https://bugs.webkit.org/show_bug.cgi?id=196665
1375         <rdar://45115669>
1376
1377         Reviewed by Geoff Garen.
1378
1379         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1380         (goBack):
1381         (+[SimpleLookupContext sharedLookupContext]):
1382         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1383         (TEST):
1384         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1385         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1386
1387 2019-04-09  John Wilander  <wilander@apple.com>
1388
1389         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1390         https://bugs.webkit.org/show_bug.cgi?id=196558
1391         <rdar://problem/47650245>
1392
1393         Reviewed by Youenn Fablet.
1394
1395         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1396         (TestWebKitAPI::TEST):
1397             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1398
1399 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1400
1401         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1402         https://bugs.webkit.org/show_bug.cgi?id=196720
1403
1404         Reviewed by Konstantin Tokarev.
1405
1406         * TestWebKitAPI/PlatformMac.cmake:
1407
1408 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1409
1410         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1411         https://bugs.webkit.org/show_bug.cgi?id=196694
1412         <rdar://problem/48388734>
1413
1414         Rubber-stamped by Aakash Jain.
1415
1416         * Scripts/webkitpy/port/image_diff.py:
1417         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1418         * Scripts/webkitpy/port/server_process.py:
1419         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1420         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1421         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1422         * Scripts/webkitpy/port/server_process_mock.py:
1423         (MockServerProcess.has_available_stdout):
1424         * Scripts/webkitpy/port/server_process_unittest.py:
1425         (TestServerProcess.serial_test_basic):
1426
1427 2019-04-09  Jer Noble  <jer.noble@apple.com>
1428
1429         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1430         https://bugs.webkit.org/show_bug.cgi?id=196097
1431
1432         Reviewed by Eric Carlson.
1433
1434         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1435
1436         * DumpRenderTree/mac/DumpRenderTree.mm:
1437         (resetWebPreferencesToConsistentValues):
1438         * WebKitTestRunner/TestController.cpp:
1439         (WTR::TestController::resetPreferencesToConsistentValues):
1440
1441 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1442
1443         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1444         https://bugs.webkit.org/show_bug.cgi?id=196690
1445
1446         Reviewed by Michael Catanzaro.
1447
1448         * QueueStatusServer/config/queues.py:
1449         * Scripts/webkitpy/common/config/ews.json:
1450         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1451         (test_ews_name):
1452
1453 2019-04-09  Chris Dumez  <cdumez@apple.com>
1454
1455         Loads using loadHTMLString() cause flashing when process-swapping
1456         https://bugs.webkit.org/show_bug.cgi?id=196714
1457         <rdar://problem/49637354>
1458
1459         Reviewed by Antti Koivisto.
1460
1461         Add API test coverage.
1462
1463         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1464
1465 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         Unreviewed. Fix ATK accessibility tests after r244059.
1468
1469         We are failing to load the injected bundle due to undefined symbol
1470         AccessibilityUIElement::replaceTextInRange().
1471
1472         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1473         (WTR::AccessibilityUIElement::replaceTextInRange):
1474
1475 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1476
1477         AX: Support API: accessibilityReplaceRange:withText
1478         https://bugs.webkit.org/show_bug.cgi?id=196636
1479
1480         Unreviewed build fix for Windows port.
1481
1482         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1483         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1484
1485 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1486
1487         [CMake][WinCairo] Separate copied headers into different directories
1488         https://bugs.webkit.org/show_bug.cgi?id=196655
1489
1490         Reviewed by Michael Catanzaro.
1491
1492         * DumpRenderTree/CMakeLists.txt:
1493         * MiniBrowser/win/CMakeLists.txt:
1494         * TestWebKitAPI/CMakeLists.txt:
1495         * TestWebKitAPI/PlatformWin.cmake:
1496
1497 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1498
1499         Log stack-trace for run-webkit-tests when interrupted
1500         https://bugs.webkit.org/show_bug.cgi?id=176393
1501         <rdar://problem/34262310>
1502
1503         Reviewed by Lucas Forschler.
1504
1505         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1506         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1507         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1508         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1509         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1511         (main): Set handlers to log stack trace on interruption.
1512
1513 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1514
1515         AX: Support API: accessibilityReplaceRange:withText
1516         https://bugs.webkit.org/show_bug.cgi?id=196636
1517
1518         Unreviewed build fix for Windows port.
1519
1520         * DumpRenderTree/AccessibilityUIElement.cpp:
1521         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1522
1523 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1524
1525         [ews-build] Scripts using Buildbot API have CORS error
1526         https://bugs.webkit.org/show_bug.cgi?id=196709
1527
1528         Reviewed by Alexey Proskuryakov.
1529
1530         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1531
1532 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1533
1534         AX: Support API: accessibilityReplaceRange:withText
1535         https://bugs.webkit.org/show_bug.cgi?id=196636
1536
1537         Reviewed by Daniel Bates.
1538
1539         * DumpRenderTree/AccessibilityUIElement.cpp:
1540         (replaceTextInRangeCallback):
1541         (AccessibilityUIElement::replaceTextInRange):
1542         (AccessibilityUIElement::getJSClass):
1543         * DumpRenderTree/AccessibilityUIElement.h:
1544         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1545         (AccessibilityUIElement::replaceTextInRange):
1546         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1547         (AccessibilityUIElement::replaceTextInRange):
1548         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1549         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1550         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1551         (WTR::AccessibilityUIElement::replaceTextInRange):
1552         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1553         (WTR::AccessibilityUIElement::replaceTextInRange):
1554
1555 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1556
1557         [iOS] Do not allow starting selection drags when selection views are not visible
1558         https://bugs.webkit.org/show_bug.cgi?id=196686
1559         <rdar://problem/49399192>
1560
1561         Reviewed by Tim Horton.
1562
1563         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1564         also add some new API tests to cover scenarios where the web view is not first responder.
1565
1566         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1567         (TestWebKitAPI::TEST):
1568         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1569
1570         Add a switch to optionally make the web view first responder when starting the simulated drag.
1571
1572         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1573         (-[DragAndDropSimulator initWithWebView:]):
1574         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1575
1576 2019-04-08  Justin Fan  <justin_fan@apple.com>
1577
1578         [Web GPU] Fix Web GPU experimental feature on iOS
1579         https://bugs.webkit.org/show_bug.cgi?id=196632
1580
1581         Reviewed by Myles C. Maxfield.
1582
1583         Properly make Web GPU available on iOS 11+.
1584
1585         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1586
1587 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1588
1589         [ews-build] Do not upload archive when Compile Fails
1590         https://bugs.webkit.org/show_bug.cgi?id=196674
1591
1592         Reviewed by Alexey Proskuryakov.
1593
1594         * BuildSlaveSupport/ews-build/factories.py:
1595         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1596         * BuildSlaveSupport/ews-build/steps.py:
1597         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1598         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1599         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1600
1601 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1602
1603         Enable DFG on MIPS
1604         https://bugs.webkit.org/show_bug.cgi?id=196689
1605
1606         Reviewed by Žan Doberšek.
1607
1608         Since the bytecode change, we enabled the baseline JIT on mips in
1609         r240432, but DFG is still missing. With this change, all tests are
1610         passing on a ci20 board.
1611
1612         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1613
1614 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1615
1616         [Flatpak] Second run update-webkitwpe-flatpak fails
1617         https://bugs.webkit.org/show_bug.cgi?id=192702
1618
1619         Reviewed by Carlos Garcia Campos.
1620
1621         * flatpak/flatpakutils.py:
1622         (FlatpakObject.flatpak): Fix typo.
1623         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1624         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1625
1626 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1627
1628         [GTK][WPE] outlook.live.com displays old-fashioned UI
1629         https://bugs.webkit.org/show_bug.cgi?id=196642
1630
1631         Reviewed by Carlos Garcia Campos.
1632
1633         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1634         (TestWebKitAPI::TEST): New Mac platform quirk test.
1635
1636 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1637
1638         Unreviewed, rolling out r243956.
1639         https://bugs.webkit.org/show_bug.cgi?id=196688
1640
1641         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1642         by aakashjain on #webkit).
1643
1644         Reverted changeset:
1645
1646         "Clicking "Go Back" from a safe browsing warning from an
1647         iframe should navigate the WKWebView back to the previous
1648         page"
1649         https://bugs.webkit.org/show_bug.cgi?id=196665
1650         https://trac.webkit.org/changeset/243956
1651
1652 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1653
1654         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1655         https://bugs.webkit.org/show_bug.cgi?id=196669
1656
1657         Reviewed by Geoffrey Garen.
1658
1659         Added three new unit tests for WeakHashSet.
1660
1661         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1662         (WTF_WeakPtr.WeakHashSetConstObjects):
1663         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1664         (WTF_WeakPtr.WeakHashSetComputeSize):
1665
1666 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1667
1668         Hide next and previous form control buttons when WKWebView is editable
1669         https://bugs.webkit.org/show_bug.cgi?id=196672
1670         <rdar://problem/35625321>
1671
1672         Reviewed by Tim Horton.
1673
1674         Add a new API test.
1675
1676         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1677         (-[TestWKWebView lastTrailingBarButtonGroup]):
1678         (TestWebKitAPI::TEST):
1679         * TestWebKitAPI/ios/UIKitSPI.h:
1680
1681 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1682
1683         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1684         https://bugs.webkit.org/show_bug.cgi?id=196077
1685         <rdar://problem/49108202>
1686
1687         Reviewed by Chris Dumez.
1688
1689         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1690         on new web view.
1691
1692         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1693
1694 2019-04-05  Saam Barati  <sbarati@apple.com>
1695
1696         Make compare-results understand MotionMark
1697         https://bugs.webkit.org/show_bug.cgi?id=196666
1698
1699         Reviewed by Yusuke Suzuki.
1700
1701         * Scripts/compare-results:
1702         (PLT5Results):
1703         (detectMotionMark):
1704         (detectMotionMark1_1):
1705         (motionMarkResults):
1706         (motionMark1_1Results):
1707         (detectBenchmark):
1708         (biggerIsBetter):
1709         (main):
1710
1711 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1712
1713         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1714         https://bugs.webkit.org/show_bug.cgi?id=196665
1715         <rdar://45115669>
1716
1717         Reviewed by Geoff Garen.
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1720         (goBack):
1721         (+[SimpleLookupContext sharedLookupContext]):
1722         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1723         (TEST):
1724         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1725         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1726
1727 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-build] Add configuration and architecture for windows builders
1730         https://bugs.webkit.org/show_bug.cgi?id=196660
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/ews-build/config.json:
1735
1736 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1737
1738         webkitpy: Don't run subsequent rounds if interrupted
1739         https://bugs.webkit.org/show_bug.cgi?id=196646
1740
1741         Reviewed by Aakash Jain.
1742
1743         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1744         (Manager.run): Bail out if interrupted.
1745
1746 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1747
1748         Test sessionStorage in PSON private browsing mode
1749         https://bugs.webkit.org/show_bug.cgi?id=196561
1750
1751         Reviewed by Alex Christensen.
1752
1753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1754
1755 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1756
1757         Unreviewed, rolling out r243833.
1758         https://bugs.webkit.org/show_bug.cgi?id=196645
1759
1760         This change breaks build of WPE and GTK ports (Requested by
1761         annulen on #webkit).
1762
1763         Reverted changeset:
1764
1765         "[CMake][WTF] Mirror XCode header directories"
1766         https://bugs.webkit.org/show_bug.cgi?id=191662
1767         https://trac.webkit.org/changeset/243833
1768
1769 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1770
1771         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1772         https://bugs.webkit.org/show_bug.cgi?id=196635
1773
1774         Reviewed by Antti Koivisto.
1775         
1776         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1777         for a test to enable async frame scrolling via:
1778             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1779         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1780         
1781         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1782
1783         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1784         (WTR::InjectedBundle::beginTesting):
1785         * WebKitTestRunner/TestController.cpp:
1786         (WTR::TestController::resetPreferencesToConsistentValues):
1787
1788 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1789
1790         Use a correct LC_RPATH when building with ASan
1791         https://bugs.webkit.org/show_bug.cgi?id=196576
1792
1793         Reviewed by David Kilzer.
1794
1795         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1796         so that ../Frameworks is checked. This is simpler and more reliable than updating
1797         each SPC service xcconfig.
1798
1799 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1800
1801         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1802         https://bugs.webkit.org/show_bug.cgi?id=196629
1803
1804         Reviewed by Lucas Forschler.
1805
1806         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1807
1808 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1809
1810         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1811         https://bugs.webkit.org/show_bug.cgi?id=196618
1812
1813         Reviewed by Lucas Forschler.
1814
1815         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1816         (StatusBubble): Added QUEUE_TRIGGERS.
1817         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1818         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1819         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1820         its parent(builder).
1821
1822 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1823
1824         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1825         https://bugs.webkit.org/show_bug.cgi?id=196625
1826
1827         Reviewed by Lucas Forschler.
1828
1829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1830         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1831
1832 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1833
1834         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1835         https://bugs.webkit.org/show_bug.cgi?id=196630
1836
1837         Reviewed by Wenson Hsieh.
1838
1839         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1840
1841 2019-04-04  Youenn Fablet  <youenn@apple.com>
1842
1843         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1844         https://bugs.webkit.org/show_bug.cgi?id=196543
1845
1846         Reviewed by Alex Christensen.
1847
1848         * WebKitTestRunner/TestController.cpp:
1849         (WTR::TestController::generatePageConfiguration):
1850
1851 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1852
1853         [ews-app] Status bubble should not display skipped buildbot steps
1854         https://bugs.webkit.org/show_bug.cgi?id=196584
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1859
1860 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1861
1862         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1863         https://bugs.webkit.org/show_bug.cgi?id=196620
1864
1865         Reviewed by Lucas Forschler.
1866
1867         * BuildSlaveSupport/ews-app/ews/config.py:
1868
1869 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1870
1871         [Win] DumpRenderTreeWatchDog.py is not checked into source
1872         https://bugs.webkit.org/show_bug.cgi?id=196567
1873         <rdar://problem/49525901>
1874
1875         Reviewed by Lucas Forschler.
1876
1877         This script is used on Win EWS bots to terminate hanging DRT processes.
1878
1879         * EWSTools/dumprendertreewatchdog.py: Added.
1880
1881 2019-04-04  Chris Dumez  <cdumez@apple.com>
1882
1883         Unreviewed, roll out r243858 which made tests time out.
1884
1885         Disable new API tests on Windows instead.
1886
1887         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1888         (TestWebKitAPI::TEST):
1889
1890 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1891
1892         [ATK] Cleanup WebPageAccessibilityObjectAtk
1893         https://bugs.webkit.org/show_bug.cgi?id=196537
1894
1895         Reviewed by Michael Catanzaro.
1896
1897         Also consider files under atk directories as exceptions for GObject conventions.
1898
1899         * Scripts/webkitpy/style/checkers/cpp.py:
1900         (check_identifier_name_in_declaration):
1901
1902 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1903
1904         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1905         https://bugs.webkit.org/show_bug.cgi?id=196588
1906         <rdar://problem/49365787>
1907
1908         Unreviewed build fix for Windows port.
1909
1910         error C3861: 'kill': identifier not found
1911
1912         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1913         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1914
1915 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1916
1917         [ews-build] Cancel build and similar operations should have authentication
1918         https://bugs.webkit.org/show_bug.cgi?id=196520
1919
1920         Reviewed by Dewei Zhu.
1921
1922         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1923         environment variables.
1924
1925 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1926
1927         [ews-build] Do not trigger queues which are not in production yet
1928         https://bugs.webkit.org/show_bug.cgi?id=196581
1929
1930         Reviewed by Dewei Zhu.
1931
1932         * BuildSlaveSupport/ews-build/config.json:
1933
1934 2019-04-03  Chris Dumez  <cdumez@apple.com>
1935
1936         Unreviewed, fix typo in the name of API test added in r243848.
1937
1938         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1939         (TestWebKitAPI::TEST):
1940
1941 2019-04-03  Chris Dumez  <cdumez@apple.com>
1942
1943         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1944         https://bugs.webkit.org/show_bug.cgi?id=196588
1945         <rdar://problem/49365787>
1946
1947         Reviewed by Ryosuke Niwa.
1948
1949         Add API test coverage.
1950
1951         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1952         (TestWebKitAPI::nullJavaScriptCallback):
1953         (TestWebKitAPI::didCrashCheckFrames):
1954         (TestWebKitAPI::TEST):
1955
1956 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1957
1958         run-webkit-tests: Upload test results (new results database)
1959         https://bugs.webkit.org/show_bug.cgi?id=196577
1960         <rdar://problem/34841155>
1961
1962         Reviewed by Lucas Forschler.
1963
1964         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1965         (Manager.run): Upload results after each device shard, since the configuration will be
1966         different for each device.
1967         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1968         uploaded to a results database.
1969         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1970         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1971
1972 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1973
1974         -apple-trailing-word is needed for browser detection
1975         https://bugs.webkit.org/show_bug.cgi?id=196575
1976
1977         Unreviewed.
1978
1979         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1980
1981 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1982
1983         [CMake][WTF] Mirror XCode header directories
1984         https://bugs.webkit.org/show_bug.cgi?id=191662
1985
1986         Reviewed by Konstantin Tokarev.
1987
1988         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1989         builds.
1990
1991         * CMakeLists.txt:
1992         * DumpRenderTree/CMakeLists.txt:
1993         * DumpRenderTree/PlatformWin.cmake:
1994         * MiniBrowser/win/CMakeLists.txt:
1995         * TestWebKitAPI/CMakeLists.txt:
1996         * TestWebKitAPI/PlatformWin.cmake:
1997         * WebKitTestRunner/PlatformGTK.cmake:
1998         * WebKitTestRunner/PlatformWin.cmake:
1999
2000 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [ews-app] Status bubble should not display certain infrastructure status messages
2003         https://bugs.webkit.org/show_bug.cgi?id=196550
2004
2005         Reviewed by Lucas Forschler.
2006
2007         Do not display the steps which are un-needed for end-user. This information is still avaiable
2008         if the user click on the bubble and look at the Buildbot build.
2009         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2010         (StatusBubble._steps_messages):
2011         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2012
2013 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2014
2015         [ews-build] Use https for sending data to ews-app
2016         https://bugs.webkit.org/show_bug.cgi?id=196492
2017
2018         Reviewed by Lucas Forschler.
2019
2020         * BuildSlaveSupport/ews-build/events.py:
2021
2022 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2023
2024         Remove support for -apple-trailing-word
2025         https://bugs.webkit.org/show_bug.cgi?id=196525
2026
2027         Reviewed by Zalan Bujtas.
2028
2029         This CSS property is nonstandard and not used.
2030
2031         * Scripts/webkitperl/FeatureList.pm:
2032         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2033
2034 2019-04-03  Youenn Fablet  <youenn@apple.com>
2035
2036         Add a test for DOMCache on multiple browsing in case of private browsing
2037         https://bugs.webkit.org/show_bug.cgi?id=196524
2038
2039         Reviewed by Alex Christensen.
2040
2041         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2042         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2043
2044 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2045
2046         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2047         https://bugs.webkit.org/show_bug.cgi?id=196540
2048
2049         Reviewed by Aakash Jain.
2050
2051         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2052
2053 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2054
2055         Add plumbing for a compatibility mode preference in WebKit
2056         https://bugs.webkit.org/show_bug.cgi?id=196005
2057
2058         Reviewed by Tim Horton.
2059
2060         Add new API tests.
2061
2062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2064
2065 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2066
2067         [WPE][GTK] Update libsrtp dependency package for Debian
2068         https://bugs.webkit.org/show_bug.cgi?id=196528
2069
2070         Reviewed by Frédéric Wang.
2071
2072         * gtk/install-dependencies:
2073         * wpe/install-dependencies:
2074
2075 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2076
2077         [WK2] Add support for Window's beforeprint / afterprint events
2078         https://bugs.webkit.org/show_bug.cgi?id=196478
2079         <rdar://problem/49535124>
2080
2081         Unreviewed build fix for MSVC.
2082
2083         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2084
2085         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2086
2087         * WebKitTestRunner/TestController.cpp:
2088         (WTR::printFrame): Use int and float literals.
2089
2090 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2091
2092         [ews-build] Reassign bots to queues
2093
2094         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2095
2096 2019-04-02  Chris Dumez  <cdumez@apple.com>
2097
2098         [WK2] Add support for Window's beforeprint / afterprint events
2099         https://bugs.webkit.org/show_bug.cgi?id=196478
2100
2101         Reviewed by Alex Christensen.
2102
2103         Add minimal implementation for printFrame in WebKitTestRunner.
2104
2105         * WebKitTestRunner/TestController.cpp:
2106         (WTR::printFrame):
2107         (WTR::TestController::createOtherPage):
2108         (WTR::TestController::createWebViewWithOptions):
2109
2110 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2113         https://bugs.webkit.org/show_bug.cgi?id=196491
2114
2115         Reviewed by Lucas Forschler.
2116
2117         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2118
2119 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-build] Configure buildbot try credentials in environment variables
2122         https://bugs.webkit.org/show_bug.cgi?id=196501
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2127         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2128         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2129
2130 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2131
2132         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2133         https://bugs.webkit.org/show_bug.cgi?id=196496
2134         <rdar://problem/49521634>
2135
2136         Reviewed by Chris Dumez.
2137
2138         Add new API tests (see WebKit ChangeLog for more detail).
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2141         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2142         (TEST):
2143
2144 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2145
2146         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2147         <https://webkit.org/b/196499>
2148
2149         Reviewed by Alexey Proskuryakov.
2150
2151         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2152         ENABLE_ADDRESS_SANITIZER.
2153
2154 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2155
2156         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2157         https://bugs.webkit.org/show_bug.cgi?id=182757
2158
2159         Reviewed by Don Olmstead.
2160
2161         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2162         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2163
2164 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2165
2166         run-api-tests: Upload test results
2167         https://bugs.webkit.org/show_bug.cgi?id=196323
2168         <rdar://problem/49356714>
2169
2170         Reviewed by Lucas Forschler.
2171
2172         * Scripts/webkitpy/api_tests/manager.py:
2173         (Manager):
2174         (Manager.run): Upload results to a results database.
2175         * Scripts/webkitpy/api_tests/run_api_tests.py:
2176         (parse_args): Add upload arguments.
2177         * Scripts/webkitpy/port/base.py:
2178         (Port):
2179         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2180         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2181         with commits from any other associated repositories.
2182         * Scripts/webkitpy/port/device.py:
2183         (Device):
2184         (Device.build_version): Access build_versoin of underlying platform device.
2185         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2186         (IOSSimulatorTest):
2187         (IOSSimulatorTest.test_configuration_for_upload):
2188         * Scripts/webkitpy/port/device_port.py:
2189         (DevicePort):
2190         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2191         the same as the machine uploading results.
2192         * Scripts/webkitpy/port/mac.py:
2193         (MacPort):
2194         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2195         * Scripts/webkitpy/port/mac_unittest.py:
2196         (MacTest):
2197         (MacTest.test_configuration_for_upload):
2198         * Scripts/webkitpy/xcode/simulated_device.py:
2199         (SimulatedDeviceManager._create_device_with_runtime):
2200         (SimulatedDevice.__init__): Create simulated device with a build_version.
2201         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2202         (test_existing_simulator):
2203
2204 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2205
2206         Remove extra newline characters (Follow-up fix to r243707)
2207
2208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2209
2210 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-app] Use API_KEY to accept results data
2213         https://bugs.webkit.org/show_bug.cgi?id=196461
2214
2215         Reviewed by Dewei Zhu.
2216
2217         * BuildSlaveSupport/ews-app/ews/views/results.py:
2218         (Results.post): Validate EWS_API_KEY before accepting any data.
2219         * BuildSlaveSupport/ews-build/events.py:
2220         (Events.sendData): Send EWS_API_KEY if available along with event data.
2221
2222 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2223
2224         Unable to copy and paste a PDF from Notes into Mail compose body
2225         https://bugs.webkit.org/show_bug.cgi?id=196442
2226         <rdar://problem/48573098>
2227
2228         Reviewed by Tim Horton.
2229
2230         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2231         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2232         to be specified on the item providers.
2233
2234         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2235         (TestWebKitAPI::mapItemForTesting):
2236         (TestWebKitAPI::contactItemForTesting):
2237
2238 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2239
2240         Make UIWKDocumentContext rects per-character instead of per-word
2241         https://bugs.webkit.org/show_bug.cgi?id=196459
2242
2243         Reviewed by Wenson Hsieh.
2244
2245         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2246         (TEST):
2247         Adjust test results due to switching to per-character rects.
2248
2249 2019-04-01  Chris Dumez  <cdumez@apple.com>
2250
2251         UIProcess crash when a prewarmed process is terminated
2252         https://bugs.webkit.org/show_bug.cgi?id=196451
2253         <rdar://problem/49245471>
2254
2255         Reviewed by Geoffrey Garen.
2256
2257         Add API test coverage.
2258
2259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2260         (TEST):
2261
2262 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2263
2264         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2265         https://bugs.webkit.org/show_bug.cgi?id=196449
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2270         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2271         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2272         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2273
2274 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2275
2276         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2277         https://bugs.webkit.org/show_bug.cgi?id=196444
2278
2279         Reviewed by Lucas Forschler.
2280
2281         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2282
2283 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2284
2285         Add SPI to canonicalize NSURLs with WTF::URL
2286         https://bugs.webkit.org/show_bug.cgi?id=196415
2287         <rdar://problem/44980271>
2288
2289         Reviewed by Darin Adler.
2290
2291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2292         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2293         (TestWebKitAPI::TEST):
2294
2295 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2296
2297         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2298         https://bugs.webkit.org/show_bug.cgi?id=196441
2299
2300         Reviewed by Carlos Garcia Campos.
2301
2302         Don't cache the wpe_view_backend object that might not exist yet at the
2303         time of EventSenderProxy constructor invocation, but instead retrieve
2304         that object whenever it's required for event dispatching. This should
2305         avoid crashes in this constructor now that it's invoked before any
2306         PlatformWindow has been set up (as changed in r243496).
2307
2308         * WebKitTestRunner/EventSenderProxy.h:
2309         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2310         (WTR::viewBackend):
2311         (WTR::EventSenderProxy::EventSenderProxy):
2312         (WTR::EventSenderProxy::mouseDown):
2313         (WTR::EventSenderProxy::mouseUp):
2314         (WTR::EventSenderProxy::mouseMoveTo):
2315         (WTR::EventSenderProxy::mouseScrollBy):
2316         (WTR::EventSenderProxy::keyDown):
2317         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2318
2319 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2320
2321         [Win][WebKit] MiniBrowser should support high DPI display
2322         https://bugs.webkit.org/show_bug.cgi?id=196391
2323
2324         Reviewed by Alex Christensen.
2325
2326         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2327         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2328         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2329         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2330
2331 2019-03-31  Sam Weinig  <weinig@apple.com>
2332
2333         Remove more i386 specific configurations
2334         https://bugs.webkit.org/show_bug.cgi?id=196430
2335
2336         Reviewed by Alexey Proskuryakov.
2337
2338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2339         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2340
2341 2019-03-31  Andy Estes  <aestes@apple.com>
2342
2343         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2344         https://bugs.webkit.org/show_bug.cgi?id=196433
2345         <rdar://problem/49293305>
2346
2347         Reviewed by Tim Horton.
2348
2349         Enhanced API test coverage to include all navigation response policy decisions in both
2350         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2354         (TestWebKitAPI::TEST):
2355         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2356         (readFile):
2357         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2358         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2359         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2360         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2361         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2362         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2363         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2364         (-[QuickLookDelegate _downloadDidStart:]):
2365         (-[QuickLookDelegate _download:didReceiveResponse:]):
2366         (-[QuickLookDelegate _download:didReceiveData:]):
2367         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2368         (-[QuickLookDelegate _downloadDidFinish:]):
2369         (-[QuickLookDelegate _download:didFailWithError:]):
2370         (-[QuickLookDelegate _downloadDidCancel:]):
2371         (-[QuickLookDelegate verifyDownload]):
2372         (runTest):
2373         (runTestDecideBeforeLoading):
2374         (runTestDecideAfterLoading):
2375         (TEST):
2376         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2377         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2378         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2379         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2380         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2381         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2382         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2383         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2384         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2385         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2386         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2387         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2388         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2389         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2390
2391 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2392
2393         [CMake] add testdfg as target with build-jsc
2394         https://bugs.webkit.org/show_bug.cgi?id=196393
2395
2396         Reviewed by Saam Barati.
2397
2398         Added testdfg as one of the targets to build when
2399         using CMake.
2400
2401         * Scripts/build-jsc:
2402
2403 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2404
2405         Delete WebMetal implementation in favor of WebGPU
2406         https://bugs.webkit.org/show_bug.cgi?id=195418
2407
2408         Reviewed by Dean Jackson.
2409
2410         * DumpRenderTree/mac/DumpRenderTree.mm:
2411         (enableExperimentalFeatures):
2412         (resetWebPreferencesToConsistentValues):
2413         * Scripts/webkitperl/FeatureList.pm:
2414         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2416         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2417         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2418         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2419         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2420         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2421         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2422         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2423         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2424         (WTR::InjectedBundle::beginTesting):
2425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2426         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2428
2429 2019-03-29  Chris Dumez  <cdumez@apple.com>
2430
2431         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2432         https://bugs.webkit.org/show_bug.cgi?id=196405
2433         <rdar://problem/49428130>
2434
2435         Reviewed by Wenson Hsieh.
2436
2437         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2438         the popover presentation methods to be no-ops. Use this in the new test added in
2439         r243523 so that we do not swizzle those methods for all tests. This is needed because
2440         those WatchOS tests rely on the popover getting presented and interactive.
2441
2442         * WebKitTestRunner/TestController.cpp:
2443         (WTR::updateTestOptionsFromTestHeader):
2444         * WebKitTestRunner/TestController.h:
2445         * WebKitTestRunner/TestOptions.h:
2446         (WTR::TestOptions::hasSameInitializationOptions const):
2447         * WebKitTestRunner/ios/TestControllerIOS.mm:
2448         (WTR::TestController::platformInitialize):
2449         (WTR::TestController::platformResetStateToConsistentValues):
2450
2451 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2452
2453         [Curl] Add Server Trust Evaluation Support.
2454         https://bugs.webkit.org/show_bug.cgi?id=191646
2455
2456         Reviewed by Fujii Hironori.
2457
2458         Implemented MiniBrowser UI for asking if user trusts the server.
2459
2460         * MiniBrowser/win/Common.cpp:
2461         (askServerTrustEvaluation):
2462         (replaceString):
2463         * MiniBrowser/win/Common.h:
2464         * MiniBrowser/win/MiniBrowserLib.rc:
2465         * MiniBrowser/win/MiniBrowserLibResource.h:
2466         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2467         (createPEMString):
2468         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2469         (WebKitBrowserWindow::canTrustServerCertificate):
2470         * MiniBrowser/win/WebKitBrowserWindow.h:
2471
2472 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2473
2474         Implement ResizeObserver.
2475         https://bugs.webkit.org/show_bug.cgi?id=157743
2476
2477         Reviewed by Simon Fraser.
2478
2479         Support resizeObserverEnabled webPreferences.
2480
2481         * DumpRenderTree/TestOptions.cpp:
2482         (TestOptions::TestOptions):
2483         * DumpRenderTree/TestOptions.h:
2484         * DumpRenderTree/mac/DumpRenderTree.mm:
2485         (setWebPreferencesForTestOptions):
2486         * DumpRenderTree/win/DumpRenderTree.cpp:
2487         (enableExperimentalFeatures):
2488         * Scripts/webkitperl/FeatureList.pm:
2489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2490
2491 2019-03-28  John Wilander  <wilander@apple.com>
2492
2493         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2494         https://bugs.webkit.org/show_bug.cgi?id=196281
2495         <rdar://problem/48938748>
2496
2497         Reviewed by Alex Christensen.
2498
2499         This patch adds the function isStatisticsHasLocalStorage() to the
2500         TestRunner. With it, the page can query the WebsiteDataStore in the
2501         UI process to make sure that it sees LocalStorage.
2502
2503         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2505         (WTR::TestRunner::isStatisticsHasLocalStorage):
2506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::TestController::isStatisticsHasLocalStorage):
2509         * WebKitTestRunner/TestController.h:
2510         * WebKitTestRunner/TestInvocation.cpp:
2511         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2512
2513 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2514
2515         API::Data::createWithoutCopying should do a null check before calling CFRelease
2516         https://bugs.webkit.org/show_bug.cgi?id=196276
2517         <rdar://problem/48059859>
2518
2519         Reviewed by Alex Christensen.
2520
2521         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2522
2523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2524         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2525         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2526         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2527         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2528         (TestWebKitAPI::TEST):
2529
2530 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2531
2532         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2533         https://bugs.webkit.org/show_bug.cgi?id=186276
2534
2535         Reviewed by Carlos Garcia Campos.
2536
2537         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2538         (webViewLoadChanged):
2539         (testWebResourceGetDataError):
2540         (testWebResourceGetDataEmpty):
2541         (beforeAll):
2542         (webViewloadChanged): Deleted.
2543
2544 2019-03-27  Andy Estes  <aestes@apple.com>
2545
2546         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2547         https://bugs.webkit.org/show_bug.cgi?id=196317
2548
2549         Reviewed by Dan Bernstein.
2550
2551         package-root copies built products into a staging directory using ditto(1), which does not
2552         follow symbolic links as it traverses a directory. Now that the files in
2553         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2554         itself, these become broken links when ditto'd into the staging directory.
2555
2556         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2557
2558         * Scripts/package-root:
2559
2560 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2561
2562         [ews-app] Update display text of Submit for ews analysis
2563         https://bugs.webkit.org/show_bug.cgi?id=196309
2564
2565         Reviewed by Dewei Zhu.
2566
2567         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2568
2569 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2570
2571         run-webkit-tests should check for leaks in WebKit processes
2572         <https://webkit.org/b/193772>
2573         <rdar://problem/46526680>
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         This works by doing the following:
2578         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2579           The list of child processes are returned one per line:
2580           process.name: pid
2581         - Run the "#LIST CHILD PROCESSES" command just before the
2582           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2583           processes on the ServerProcess object.
2584         - When the `--leaks` switch is handled, run check_for_leaks() on
2585           each child process after the main test harness.
2586
2587         * DumpRenderTree/mac/DumpRenderTree.mm:
2588         (handleControlCommand):
2589         - Use strncmp() instead of strcmp().
2590         - Add support for handling "#LIST CHILD PROCESSES" command.
2591
2592         * Scripts/webkitpy/port/base.py:
2593         (Port.check_for_leaks):
2594         * Scripts/webkitpy/port/darwin.py:
2595         (DarwinPort.check_for_leaks):
2596         - Rename redundant 'process_pid' argument to 'process_id'.
2597
2598         * Scripts/webkitpy/port/driver.py:
2599         (Driver.do_post_tests_work):
2600         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2601           longer the only command this sends to WebKitTestRunner.
2602         - If the `--leaks` switch is present, send the
2603           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2604           result using Port.set_webkit_processes().
2605         (Driver._parse_child_processes_output):
2606         - Add helper method to parse list of child process names and
2607           process IDs returned from WebKitTestRunner.
2608
2609         * Scripts/webkitpy/port/ios_device.py:
2610         (IOSDevicePort.check_for_leaks):
2611         - Rename redundant 'process_pid' argument to 'process_id'.
2612
2613         * Scripts/webkitpy/port/leakdetector.py:
2614         (LeakDetector._parse_leaks_output):
2615         - Return early if there is no leaks_output.
2616         (LeakDetector.check_for_leaks):
2617         - Rename redundant 'process_pid' argument to 'process_id'.
2618
2619         * Scripts/webkitpy/port/server_process.py:
2620         (ServerProcess.__init__):
2621         (ServerProcess.child_processes):
2622         (ServerProcess.set_child_processes):
2623         - Add instance variable to Port to store list of child process
2624           names and process IDs returned from WebKitTestRunner.
2625         (ServerProcess._start):
2626         - Clear self._child_processes.
2627         (ServerProcess.stop):
2628         - If self._child_processes is set, call
2629           self._port.check_for_leaks() for each child process.
2630
2631         * Scripts/webkitpy/port/server_process_unittest.py:
2632         (TrivialMockPort.check_for_leaks):
2633         - Rename redundant 'process_pid' argument to 'process_id'.
2634
2635         * Scripts/webkitpy/port/simulator_process.py:
2636         (SimulatorProcess.stop):
2637         - If self._child_processes is set, call
2638           self._port.check_for_leaks() for each child process.
2639
2640         * Scripts/webkitpy/port/watch_device.py:
2641         (WatchDevicePort.check_for_leaks):
2642         - Rename redundant 'process_pid' argument to 'process_id'.
2643
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::TestController::dumpResponse):
2646         - Extract method from findAndDumpWorldLeaks() so that it may be
2647           reused by findAndDumpWebKitProcessIdentifiers().
2648         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2649         - Add method to output process name and process ID of both the
2650           WebContent and Networking processes.
2651         (WTR::TestController::findAndDumpWorldLeaks):
2652         - Fix missing newline in output when there were no abandoned
2653           documents.
2654         - Call dumpResponse() for extracted code.
2655         (WTR::TestController::handleControlCommand):
2656         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2657         - Use strncmp() instead of strcmp().
2658         - Call findAndDumpWebKitProcessIdentifiers() when
2659           "#LIST CHILD PROCESSES" command is sent.
2660         * WebKitTestRunner/TestController.h:
2661         (WTR::TestController::dumpResponse):
2662         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2663         - Declare methods.
2664
2665 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         Unreviewed. Add GLib API test cases after r243434.
2668
2669         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2670         (testWebViewActiveURI):
2671         (serverCallback):
2672         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2673         (sendRequestCallback):
2674
2675 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2676
2677         Geolocation request not complete when watch request was started in a different web process
2678         https://bugs.webkit.org/show_bug.cgi?id=195996
2679
2680         Reviewed by Alex Christensen.
2681
2682         Add a test case.
2683
2684         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2685         (TestWebKitAPI::runJavaScriptAlert):
2686         (TestWebKitAPI::TEST):
2687
2688 2019-03-26  Keith Rollin  <krollin@apple.com>
2689
2690         Update the way generate-xcfilelists returns strings from functions
2691         https://bugs.webkit.org/show_bug.cgi?id=195975
2692         <rdar://problem/49040807>
2693
2694         Reviewed by Dean Jackson.
2695
2696         There are places where generate-xcfilelists executes assignments with
2697         statements like:
2698
2699             FOO=$(some_function)
2700
2701         where "some_function" return a string by echoing it. E.g.
2702
2703             some_function()
2704             {
2705                 echo "Hello, World"
2706             }
2707
2708         This is a common idiom, but it has a problem if "some_function" needs
2709         to call "exit" in an attempt to halt the entire script right then and
2710         there. Since "some_function" is called inside of $(), it's being
2711         executed in a sub-shell. Calling exit in that sub-shell simply exits
2712         that shell; it doesn't not exit the outer shell in which the main part
2713         of the script is still running. As such, the main script keeps
2714         executing when the intent was for the script to halt.
2715
2716         The solution to this is to use a different idiom for returning
2717         strings. The one we now is to pass in the name of the variable to
2718         receive the string result:
2719
2720             some_function()
2721             {
2722                 variable_name=$1
2723                 eval $variable_name ="Hello, World"
2724             }
2725
2726         The call site now looks like
2727
2728             some_function FOO
2729
2730         Because there's no invocation of a sub-shell, some_function can now
2731         call "exit" if it wants to, and the entire script will exit at that
2732         point.
2733
2734         * Scripts/generate-xcfilelists:
2735
2736 2019-03-26  Chris Dumez  <cdumez@apple.com>
2737
2738         Add basic layout test coverage for File Picker on iOS
2739         https://bugs.webkit.org/show_bug.cgi?id=196265
2740
2741         Reviewed by Wenson Hsieh.
2742
2743         Add layout test infrastructure to test the file picker on iOS.
2744
2745         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2746         (WTR::UIScriptController::dismissFilePicker):
2747         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2748         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2749         (WTR::UIScriptController::dismissFilePicker):
2750         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2751         * WebKitTestRunner/TestController.cpp:
2752         (WTR::TestController::createWebViewWithOptions):
2753         (WTR::updateTestOptionsFromTestHeader):
2754         * WebKitTestRunner/TestOptions.h:
2755         (WTR::TestOptions::hasSameInitializationOptions const):
2756         * WebKitTestRunner/ios/TestControllerIOS.mm:
2757         (overridePresentViewController):
2758         (WTR::TestController::platformInitialize):
2759         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2760         (WTR::UIScriptController::dismissFilePicker):
2761
2762 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2763
2764         Implement async paste method on UIWKInteractionViewProtocol
2765         https://bugs.webkit.org/show_bug.cgi?id=196267
2766         <rdar://problem/49236346>
2767
2768         Reviewed by Tim Horton.
2769
2770         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2771         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2772         are now a part of all iOS 12 internal SDKs.
2773
2774         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2775
2776         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2777         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2778
2779         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2780         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2781         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2782         * TestWebKitAPI/ios/UIKitSPI.h:
2783
2784 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2785
2786         [ews-build] Use PostgreSQL for ews.webkit.org database
2787         https://bugs.webkit.org/show_bug.cgi?id=196270
2788
2789         Reviewed by Lucas Forschler.
2790
2791         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2792
2793 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2794
2795         [ews] Reset simctl states on reboot
2796         https://bugs.webkit.org/show_bug.cgi?id=196260
2797
2798         Rubber-stamped by Aakash Jain.
2799
2800         * EWSTools/start-queue-mac.sh:
2801
2802 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2803
2804         [ews-build] Use PostgreSQL for ews-build database
2805         https://bugs.webkit.org/show_bug.cgi?id=196229
2806
2807         Reviewed by Lucas Forschler.
2808
2809         * BuildSlaveSupport/ews-build/master.cfg:
2810
2811 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2812
2813         [ews-build] Get master_hostname dynamically in master.cfg
2814         https://bugs.webkit.org/show_bug.cgi?id=196255
2815
2816         Reviewed by Lucas Forschler.
2817
2818         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2819         send events data in test mode.
2820
2821 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2822
2823         [ews-app] Set db_constraint to False for Foreign Keys
2824         https://bugs.webkit.org/show_bug.cgi?id=196252
2825
2826         Reviewed by Lucas Forschler.
2827
2828         * BuildSlaveSupport/ews-app/ews/models/build.py:
2829         * BuildSlaveSupport/ews-app/ews/models/step.py:
2830
2831 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2832
2833         [ews-build] is_test_mode_enabled should default to True
2834         https://bugs.webkit.org/show_bug.cgi?id=196248
2835
2836         Reviewed by Lucas Forschler.
2837
2838         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2839
2840 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2841
2842         [ews-app] Add webkitperl to ENABLED_QUEUES
2843         https://bugs.webkit.org/show_bug.cgi?id=196253
2844
2845         Reviewed by Lucas Forschler.
2846
2847         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2848
2849 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2850
2851         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2852         https://bugs.webkit.org/show_bug.cgi?id=196211
2853         rdar://problem/49110552
2854
2855         Reviewed by Tim Horton.
2856
2857         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2858         Make sure that EventSenderProxy always exists when running tests. We used to create
2859         it when resetting before the first test, which is a bit too late.
2860
2861         * WebKitTestRunner/TestController.h:
2862         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2863         (WTR::TestController::platformCreateWebView):
2864         (WTR::TestController::platformCreateOtherPage):
2865         (WTR::TestController::finishCreatingPlatformWebView):
2866         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2867         (WTR::PlatformWebView::PlatformWebView):
2868         Moved some code that made NSWindow use NSEvent during web view creation. We may
2869         need to move more if some other case us found, but this is enough for now.
2870
2871 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2872
2873         Unreviewed. Fix typo in GLib geolocation API after r243285.
2874
2875         gelocation -> geolocation.
2876
2877         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2878         (testGeolocationManagerWatchPosition):
2879
2880 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2881
2882         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2883         https://bugs.webkit.org/show_bug.cgi?id=196213
2884
2885         Reviewed by Geoff Garen.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2889         (credentialWithIdentityAndKeychainPath):
2890         (-[ChallengeDelegate webView:didFinishNavigation:]):
2891         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2892         (TestWebKitAPI::TEST):
2893
2894 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2895
2896         Expected shouldn't assume its contained types are copyable
2897         https://bugs.webkit.org/show_bug.cgi?id=195986
2898
2899         Reviewed by JF Bastien.
2900
2901         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2902         (TestWebKitAPI::NonCopyable::operator== const):
2903         (TestWebKitAPI::NonCopyable::operator!= const):
2904         (TestWebKitAPI::TEST):
2905
2906 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2907
2908         Remove some now-unnecessary dynamic class lookup
2909         https://bugs.webkit.org/show_bug.cgi?id=196237
2910
2911         Reviewed by Simon Fraser.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2914         (makeRequest):
2915         (TEST):
2916
2917 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2918
2919         Unreviewed, rolling out r243450.
2920
2921         AppleWin and WinCairo port builds get broken.
2922
2923         Reverted changeset:
2924
2925         "Add test for fix of #196095"
2926         https://bugs.webkit.org/show_bug.cgi?id=196097
2927         https://trac.webkit.org/changeset/243450
2928
2929 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2930
2931         Unreviewed, rolling out r243465.
2932         https://bugs.webkit.org/show_bug.cgi?id=196226
2933
2934         the test doesn't build (Requested by thorton on #webkit).
2935
2936         Reverted changeset:
2937
2938         "Do not terminate the NetworkProcess if a third party
2939         application sends a NSCredential with a SecIdentityRef"
2940         https://bugs.webkit.org/show_bug.cgi?id=196213
2941         https://trac.webkit.org/changeset/243465
2942
2943 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2944
2945         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2946         https://bugs.webkit.org/show_bug.cgi?id=196213
2947
2948         Reviewed by Geoff Garen.
2949
2950         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2951         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2952         (credentialWithIdentityAndKeychainPath):
2953         (-[ChallengeDelegate webView:didFinishNavigation:]):
2954         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2955         (TestWebKitAPI::TEST):
2956
2957 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews-build] Gracefully handle missing patch_id in events
2960         https://bugs.webkit.org/show_bug.cgi?id=196216
2961
2962         Reviewed by Lucas Forschler.
2963
2964         * BuildSlaveSupport/ews-build/events.py:
2965
2966 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-build] use lz4 compression for improving buildbot performance
2969         https://bugs.webkit.org/show_bug.cgi?id=196155
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * BuildSlaveSupport/ews-build/master.cfg:
2974
2975 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2976
2977         Pull some API testing helper methods out of TestWKWebView
2978         https://bugs.webkit.org/show_bug.cgi?id=196212
2979
2980         Reviewed by Tim Horton.
2981
2982         Refactor some more API testing utility methods, so that they can be used in
2983         tests that do not use TestWKWebView.
2984
2985         * TestWebKitAPI/cocoa/TestWKWebView.h:
2986         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2987         (-[WKWebView loadTestPageNamed:]):
2988         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2989         (-[WKWebView synchronouslyLoadHTMLString:]):
2990         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2991         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2992         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2993         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2994         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2995
2996 2019-03-25  Jer Noble  <jer.noble@apple.com>
2997
2998         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2999         https://bugs.webkit.org/show_bug.cgi?id=196097
3000
3001         Reviewed by Eric Carlson.
3002
3003         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3004
3005         * DumpRenderTree/mac/DumpRenderTree.mm:
3006         (resetWebPreferencesToConsistentValues):
3007         * WebKitTestRunner/TestController.cpp:
3008         (WTR::TestController::resetPreferencesToConsistentValues):
3009
3010 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         Pull IPadUserInterfaceSwizzler out into a separate header file
3013         https://bugs.webkit.org/show_bug.cgi?id=196193
3014
3015         Reviewed by Anders Carlsson.
3016
3017         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3018         be used in other API tests.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3022         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3023         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3024         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3025         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3026         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3027
3028 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3029
3030         Remove NavigatorContentUtils in WebCore/Modules
3031         https://bugs.webkit.org/show_bug.cgi?id=196070
3032
3033         Reviewed by Alex Christensen.
3034
3035         NavigatorContentUtils was to support the custom scheme spec [1].
3036         However, in WebKit side, no port has supported the feature in
3037         WebKit layer after EFL port was removed. So there has been the
3038         only IDL implementation of the NavigatorContentUtils in WebCore.
3039         So we don't need to keep the implementation in WebCore anymore.
3040
3041         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3042
3043         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3044
3045 2019-03-24  Andy Estes  <aestes@apple.com>
3046
3047         [watchOS] Remove unused Proximity Networking code
3048         https://bugs.webkit.org/show_bug.cgi?id=196188
3049
3050         Reviewed by Tim Horton.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3053         (TEST):
3054
3055 2019-03-23  Keith Miller  <keith_miller@apple.com>
3056
3057         Refactor clz/ctz and fix getLSBSet.
3058         https://bugs.webkit.org/show_bug.cgi?id=196162
3059
3060         Reviewed by Saam Barati.
3061
3062         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3063
3064         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3065         (TestWebKitAPI::TEST):
3066
3067 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3068
3069         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3070         https://bugs.webkit.org/show_bug.cgi?id=196143
3071
3072         Reviewed by Michael Catanzaro.
3073
3074         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3075         directories.
3076
3077         * Scripts/webkitpy/style/checkers/cpp.py:
3078         (check_identifier_name_in_declaration):
3079         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3080         (WebKitStyleTest.test_names):
3081
3082 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3083
3084         [Flatpak] Manifest expanding fails for qt WPE extension
3085         https://bugs.webkit.org/show_bug.cgi?id=196148
3086
3087         Reviewed by Alex Christensen.
3088
3089         * flatpak/flatpakutils.py:
3090         (expand_submodules_recurse): The last recurse manifest expand
3091         iteration might lead to a single module so take it into account
3092         and don't try to recurse further.
3093
3094 2019-03-22  Chris Dumez  <cdumez@apple.com>
3095
3096         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3097         https://bugs.webkit.org/show_bug.cgi?id=195348
3098         <rdar://problem/48622090>
3099
3100         Reviewed by Alex Christensen.
3101
3102         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3103         to NO when test.options().shouldIgnoreMetaViewport is false.
3104
3105         * WebKitTestRunner/ios/TestControllerIOS.mm:
3106         (WTR::TestController::platformConfigureViewForTest):
3107
3108 2019-03-22  Chris Dumez  <cdumez@apple.com>
3109
3110         Prewarmed processes should be usable with any website data store
3111         https://bugs.webkit.org/show_bug.cgi?id=196104
3112
3113         Reviewed by Alex Christensen.
3114
3115         Add API test coverage.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3118         (runInitialWarmedProcessUsedTest):
3119         (TEST):
3120
3121 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3122
3123         Back out local changes to Alex's Subversion working directory
3124
3125         They were accidentally committed.
3126
3127         * Scripts/webkitpy/common/system/abstractexecutive.py:
3128         (AbstractExecutive.wait_newest):
3129         * Scripts/webkitpy/common/system/executive.py:
3130         (Executive.running_pids):
3131         * Scripts/webkitpy/common/system/executive_mock.py:
3132         (MockExecutive.running_pids):
3133         * Scripts/webkitpy/common/system/executive_unittest.py:
3134         (ExecutiveTest.serial_test_running_pids):
3135         * Scripts/webkitpy/port/darwin.py:
3136         (DarwinPort.check_for_leaks):
3137         * Scripts/webkitpy/port/leakdetector.py:
3138         (LeakDetector.check_for_leaks):
3139         - This was the hack attached to Bug 193772.
3140
3141         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3142         (+[WebKitTestRunnerEvent mouseLocation]):
3143         - This works around a crash on an internal build.
3144
3145 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3146
3147         Fix the build after r243354
3148         https://bugs.webkit.org/show_bug.cgi?id=196138
3149         <rdar://problem/49145951>
3150
3151         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3152         (TEST):
3153         * TestWebKitAPI/ios/UIKitSPI.h:
3154
3155 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3156
3157         Adopt UIWKDocumentContext
3158         https://bugs.webkit.org/show_bug.cgi?id=196040
3159         <rdar://problem/48642440>
3160
3161         Reviewed by Ryosuke Niwa.
3162
3163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3164         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3165         (makeRequest):
3166         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3167         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3168         (applyStyle):
3169         (TEST):
3170         Add tests for UIWKDocumentContext.
3171
3172         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3173         (TEST):
3174         (recursiveFindWKContentView): Deleted.
3175         * TestWebKitAPI/cocoa/TestWKWebView.h:
3176         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3177         (recursiveFindWKContentView):
3178         (-[TestWKWebView wkContentView]):
3179         * TestWebKitAPI/ios/UIKitSPI.h:
3180         Share the WKContentView finding code between tests.
3181
3182 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3183
3184         [iOS WK2] Turn on async overflow scrolling by default
3185         https://bugs.webkit.org/show_bug.cgi?id=196011
3186         rdar://problem/48453859
3187
3188         Reviewed by Antti Koivisto.
3189         
3190         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3191         since so many basic layout tests have different results when compositing is triggered for
3192         overflow.
3193         
3194         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3195
3196         * WebKitTestRunner/TestController.cpp:
3197         (WTR::TestController::resetPreferencesToConsistentValues):
3198
3199 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3200
3201         [ews-build] Retry API test in case of failures
3202         https://bugs.webkit.org/show_bug.cgi?id=196004
3203
3204         Reviewed by Lucas Forschler.
3205
3206         * BuildSlaveSupport/ews-build/steps.py:
3207         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3208         (CompileWebKitToT.doStepIf): Ditto.
3209         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3210         (ReRunAPITests): Re-run API tests.
3211         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3212         (RunAPITestsWithoutPatch): Run API tests without patch.
3213         (RunAPITestsWithoutPatch.doStepIf):
3214         (RunAPITestsWithoutPatch.hideStepIf):
3215         (RunAPITestsWithoutPatch.evaluateCommand):
3216         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3217         (AnalyzeAPITestsResults.start):
3218         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3219         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3220         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3221         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3222
3223 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3224
3225         [ews-build] Update queues configurations
3226         https://bugs.webkit.org/show_bug.cgi?id=196074
3227
3228         Reviewed by Dewei Zhu.
3229
3230         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3231         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3232
3233 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3234
3235         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3236         https://bugs.webkit.org/show_bug.cgi?id=195680
3237         <rdar://problem/48903534>
3238
3239         Unreviewed infrastructure fix.
3240
3241         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3242         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3243
3244 2019-03-21  Andy Estes  <aestes@apple.com>
3245
3246         [iOS] Apple Pay should be available in documents with no user agent scripts
3247         https://bugs.webkit.org/show_bug.cgi?id=196061
3248         <rdar://problem/48649391>
3249
3250         Reviewed by Brady Eidson.
3251
3252         Added API tests and related infrastructure.
3253
3254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3255         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3256         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3257         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3258         (TestWebKitAPI::TEST):
3259         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3260         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3261         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3262         * TestWebKitAPI/cocoa/TestProtocol.mm:
3263         (-[TestProtocol startLoading]):
3264         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3265         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3266         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3267         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3268
3269 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3270
3271         REGRESSSION (r243297): webkitpy tests broken
3272         https://bugs.webkit.org/show_bug.cgi?id=196108
3273
3274         Reviewed by Aakash Jain.
3275
3276         r243297 updated contributors.json, which broke a few unit tests.
3277
3278         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3279         (IRCCommandTest.test_whois):
3280         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3281
3282 2019-03-21  Chris Dumez  <cdumez@apple.com>
3283
3284         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3285         https://bugs.webkit.org/show_bug.cgi?id=196041
3286         <rdar://problem/49083230>
3287
3288         Reviewed by Alex Christensen.
3289
3290         Add API test coverage.
3291
3292         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3293         (TEST):
3294
3295 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3296
3297         Add SPI to inform applications of WKContentRuleList actions
3298         https://bugs.webkit.org/show_bug.cgi?id=195965
3299         <rdar://problem/42664365>
3300
3301         Reviewed by Geoff Garen.
3302
3303         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3304         (TestWebKitAPI::allActionsForResourceLoad):
3305         (TestWebKitAPI::testRequest):
3306         (TestWebKitAPI::TEST_F):
3307         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3308         (Notification::description):
3309         (Notification::operator== const):
3310         (toVector):
3311         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3312         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3313         (makeContentRuleList):
3314         (TEST):
3315         (makeWarnContentRuleList): Deleted.
3316
3317 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3318
3319         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3320         https://bugs.webkit.org/show_bug.cgi?id=196088
3321
3322         Reviewed by Brian Burg.
3323
3324         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3325         Support checks when only one platform is specified. Also deprecate macosx() and
3326         force the use of macos() instead.
3327
3328         * Scripts/webkitpy/style/checkers/cpp.py:
3329         (check_min_versions_of_wk_api_available):
3330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3331         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3332
3333 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3334
3335         Update status inactive committers' status to 'contributor'.
3336
3337         * Scripts/webkitpy/common/config/contributors.json:
3338
3339 2019-03-21  Xan Lopez  <xan@igalia.com>
3340
3341         [JSC][x86] Drop support for x87 floating point
3342         https://bugs.webkit.org/show_bug.cgi?id=194853
3343
3344         Reviewed by Don Olmstead.
3345
3346         Force SSE2 on x86/32bit builds.
3347
3348         * Scripts/webkitdirs.pm:
3349         (generateBuildSystemFromCMakeProject):
3350
3351 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3352
3353         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3354         https://bugs.webkit.org/show_bug.cgi?id=196073
3355
3356         Reviewed by Michael Catanzaro.
3357
3358         Add test cases to check functions and constructors with no arguments but receiving user data.
3359
3360         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3361         (checkUserData):
3362         (testJSCFunction):
3363         (fooCreateWithUserData):
3364         (testJSCClass):
3365
3366 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3367
3368         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3369
3370         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3371
3372         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3373
3374 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3375
3376         [GTK][WPE] Add API to provide geolocation information
3377         https://bugs.webkit.org/show_bug.cgi?id=195940
3378
3379         Reviewed by Michael Catanzaro.
3380
3381         Add a new test to check the new API.
3382
3383         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3384         (testGeolocationManagerCurrentPosition):
3385         (testGeolocationManagerWatchPosition):
3386         (beforeAll):
3387         (afterAll):
3388         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3389         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3390         (beforeAll): Ditto.
3391         * TestWebKitAPI/glib/CMakeLists.txt:
3392
3393 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3394
3395         [GLib] Returning G_TYPE_OBJECT from a method does not work
3396         https://bugs.webkit.org/show_bug.cgi?id=195574
3397
3398         Reviewed by Michael Catanzaro.
3399
3400         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3401
3402         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3403         (getGFile):
3404         (getParent):
3405         (createGString):
3406         (getGString):
3407         (getGStringCopyWillRaise):
3408         (getGStringCopy):
3409         (getGStringStr):
3410         (getGStringLen):
3411         (freeGString):
3412         (testJSCClass):
3413
3414 2019-03-20  Saam Barati  <sbarati@apple.com>
3415
3416         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3417         https://bugs.webkit.org/show_bug.cgi?id=195721
3418
3419         Reviewed by Filip Pizlo.
3420
3421         * Scripts/run-javascriptcore-tests:
3422
3423 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3424
3425         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3426         https://bugs.webkit.org/show_bug.cgi?id=196049
3427
3428         Reviewed by Tim Horton.
3429
3430         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3431         overflow scrolling in general, so rename it.
3432
3433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3434
3435 2019-03-20  Daniel Bates  <dabates@apple.com>
3436
3437         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3438         https://bugs.webkit.org/show_bug.cgi?id=196031
3439         <rdar://problem/49078172>
3440
3441         Reviewed by Tim Horton.
3442
3443         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3444         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3445         same code path used when the Done button is pressed to dismiss the <select> picker.
3446
3447         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3448         (TestWebKitAPI::TEST):
3449
3450 2019-03-20  Chris Dumez  <cdumez@apple.com>
3451
3452         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3453         https://bugs.webkit.org/show_bug.cgi?id=196029
3454         <rdar://problem/48954651>
3455
3456         Reviewed by Tim Horton.
3457
3458         Add API test coverage.
3459
3460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3461
3462 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3463
3464         [ews-build] Improve failure summary string for ApplyPatch step
3465         https://bugs.webkit.org/show_bug.cgi?id=195995
3466
3467         Reviewed by Alexey Proskuryakov.
3468
3469         * BuildSlaveSupport/ews-build/steps.py:
3470         (ApplyPatch.getResultSummary): Override getResultSummary.
3471
3472 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3473
3474         AX: Implement support for new meter ARIA role
3475         https://bugs.webkit.org/show_bug.cgi?id=195966
3476
3477         Reviewed by Chris Fleizach.
3478
3479         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3480         to AXLevelIndicator.
3481
3482         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3483
3484 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3485
3486         [WebAuthN] Implement FIDO AppID extension
3487         https://bugs.webkit.org/show_bug.cgi?id=143491
3488         <rdar://problem/48298273>
3489
3490         Reviewed by Brent Fulgham.
3491
3492         Add a test that covers the new flag of convertToU2fSignCommand.
3493
3494         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3495         (TestWebKitAPI::TEST):
3496         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3497         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3498         (TestWebKitAPI::TEST):
3499
3500 2019-03-19  Keith Rollin  <krollin@apple.com>
3501
3502         Add support for more platforms to generate-xcfilelists
3503         https://bugs.webkit.org/show_bug.cgi?id=195977
3504
3505         Reviewed by Alexey Proskuryakov.
3506
3507         generate-xcfilelists incorrectly complains when involved with building
3508         WebKit for iphonesimulator:
3509
3510             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3511             …
3512             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3513
3514         Address this by teaching generate-xcfilelists about more platforms.
3515
3516         * Scripts/generate-xcfilelists:
3517
3518 2019-03-19  John Wilander  <wilander@apple.com>
3519
3520         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3521         https://bugs.webkit.org/show_bug.cgi?id=195923
3522         <rdar://problem/49001272>
3523
3524         Reviewed by Alex Christensen.
3525
3526         This patch does the following to the TestRunner:
3527         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3528         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3529         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3530
3531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3533         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3534         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3535         * WebKitTestRunner/TestController.cpp:
3536         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3537         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3538         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3539         * WebKitTestRunner/TestController.h:
3540         * WebKitTestRunner/TestInvocation.cpp:
3541         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3542
3543 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3544
3545         [CMake] Support more clang and gcc sanitizers
3546         https://bugs.webkit.org/show_bug.cgi?id=195956
3547
3548         Reviewed by Michael Catanzaro.
3549
3550         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3551
3552 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3553
3554         [ews-build] Improve summary for PrintConfiguration step
3555         https://bugs.webkit.org/show_bug.cgi?id=195945
3556
3557         Reviewed by Lucas Forschler.
3558
3559         * BuildSlaveSupport/ews-build/steps.py:
3560         (PrintConfiguration.getResultSummary): Override getResultSummary.
3561
3562 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3563
3564         [ews-build] Improve summary for CheckOutSource step
3565         https://bugs.webkit.org/show_bug.cgi?id=195963
3566
3567         Reviewed by Lucas Forschler.
3568
3569         * BuildSlaveSupport/ews-build/steps.py:
3570         (CheckOutSource.getResultSummary):
3571
3572 2019-03-19  Daniel Bates  <dabates@apple.com>
3573
3574         [iOS] Focus not preserved when switching between tabs
3575         https://bugs.webkit.org/show_bug.cgi?id=195820
3576         <rdar://problem/43614450>
3577
3578         Reviewed by Brent Fulgham.
3579
3580         Add tests to ensure that we restore focus when resigning and becoming first responder.
3581
3582         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3583         (TestWebKitAPI::TEST):
3584
3585 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3586
3587         Make WTFLogChannelState and WTFLogLevel enum classes
3588         https://bugs.webkit.org/show_bug.cgi?id=195904
3589
3590         Reviewed by Eric Carlson.
3591
3592         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3593         (TestWebKitAPI::TEST_F):
3594
3595 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3596
3597         [GStreamer][EME] Backported mssdemux protection data crash fix
3598         https://bugs.webkit.org/show_bug.cgi?id=195918
3599
3600         Reviewed by Philippe Normand.
3601
3602         * gstreamer/jhbuild.modules:
3603         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3604
3605 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3606
3607         Unreviewed, rolling out r243132.
3608
3609         Broke GTK build
3610
3611         Reverted changeset:
3612
3613         "Make WTFLogChannelState and WTFLogLevel enum classes"
3614         https://bugs.webkit.org/show_bug.cgi?id=195904
3615         https://trac.webkit.org/changeset/243132
3616
3617 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3618
3619         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3620
3621         * Scripts/webkitdirs.pm:
3622         (builtDylibPathForName): Adjust the shared library name that's changed
3623         with the API version bump in r243073.
3624
3625 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3626
3627         Make WTFLogChannelState and WTFLogLevel enum classes
3628         https://bugs.webkit.org/show_bug.cgi?id=195904
3629
3630         Reviewed by Eric Carlson.
3631
3632         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3633         (TestWebKitAPI::TEST_F):
3634
3635 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3636
3637         Disable flaky test added in r2431100
3638         https://webkit.org/b/195785
3639
3640         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3641         (TestWebKitAPI::TEST):
3642         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3643
3644 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3645
3646         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3647         https://bugs.webkit.org/show_bug.cgi?id=195916
3648
3649         Reviewed by Tim Horton.
3650
3651         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3652         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3653
3654 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3655
3656         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3657
3658         * Scripts/webkitpy/common/config/contributors.json:
3659
3660 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3661
3662         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3663         https://bugs.webkit.org/show_bug.cgi?id=195785
3664
3665         Reviewed by Geoffrey Garen.
3666
3667         * TestWebKitAPI/TCPServer.cpp: Added.
3668         (TestWebKitAPI::TCPServer::TCPServer):
3669         (TestWebKitAPI::TCPServer::~TCPServer):
3670         (TestWebKitAPI::TCPServer::socketBindListen):
3671         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3672         * TestWebKitAPI/TCPServer.h: Added.
3673         (TestWebKitAPI::TCPServer::port const):
3674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3675         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3676         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3677         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3678         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3679         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3680         (TestWebKitAPI::respondSlowly):
3681         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3682         (TestWebKitAPI::downloadAtRate):
3683         (TestWebKitAPI::TEST):
3684
3685 2019-03-18  Saam Barati  <sbarati@apple.com>
3686
3687         Add a plan file for JetStream 2
3688         https://bugs.webkit.org/show_bug.cgi?id=190734
3689
3690         Reviewed by Mark Lam.
3691
3692         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3693
3694 2019-03-18  Chris Dumez  <cdumez@apple.com>
3695
3696         Delay WebProcess launch until a load is triggered in a Web view
3697         https://bugs.webkit.org/show_bug.cgi?id=195758
3698         <rdar://problem/48126013>
3699
3700         Reviewed by Geoff Garen.
3701
3702         Add API test coverage. Also update some existing API tests to not expect
3703         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3704
3705         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3706         (TestWebKitAPI::TEST):
3707         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3708         (TestWebKitAPI::TEST):
3709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3710         (TEST):
3711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3712         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3713         (TEST):
3714         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3715         (TEST):
3716         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3717
3718 2019-03-18  Xan Lopez  <xan@igalia.com>
3719
3720         [CMake] Prevent potential warning when determining $architecture
3721         https://bugs.webkit.org/show_bug.cgi?id=195891
3722
3723         Reviewed by Michael Catanzaro.
3724
3725         It's possible for generateBuildSystemForCMakeProject to be called
3726         before determineArchitecture() is ever called. This will make the
3727         first eq check with $architecture to be bogus (and print a
3728         warning). Change that to an eq check with architecture(), which
3729         implicitly calls determineArchitecture() if needed, and change all
3730         the other similar cases in the method in the same way to prevent
3731         future bugs like this one.
3732
3733         * Scripts/webkitdirs.pm:
3734         (generateBuildSystemFromCMakeProject):
3735
3736 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3737
3738         [WPE] Tarballs generated with “make dist” cannot build documentation
3739         https://bugs.webkit.org/show_bug.cgi?id=195885
3740
3741         Reviewed by Carlos Garcia Campos.
3742
3743         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3744
3745 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3746
3747         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3748         https://bugs.webkit.org/show_bug.cgi?id=195883
3749
3750         Reviewed by Carlos Garcia Campos.
3751
3752         * gtkdoc/gtkdoc.py:
3753         (GTKDoc._run_command): When commands fail to run, include the full command line for
3754         the program invocation and the output it has generated on the standard error stream.
3755
3756 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3757
3758         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3759         https://bugs.webkit.org/show_bug.cgi?id=195786
3760
3761         Reviewed by Philippe Normand.
3762
3763         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3764         * wpe/jhbuild.modules: Ditto.
3765
3766 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3767
3768         [ews-build] Don't run clean builds on EWS builders
3769         https://bugs.webkit.org/show_bug.cgi?id=195851
3770
3771         Reviewed by Geoffrey Garen.
3772
3773         * BuildSlaveSupport/ews-build/factories.py:
3774
3775 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3776
3777         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3778         https://bugs.webkit.org/show_bug.cgi?id=195849
3779
3780         Reviewed by Chris Dumez.
3781
3782         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3783
3784         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3785         (runWebsiteDataStoreCustomPaths):
3786
3787 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3788
3789         webkitpy: Upload test results
3790         https://bugs.webkit.org/show_bug.cgi?id=195755
3791         <rdar://problem/48896182>
3792
3793         Reviewed by Aakash Jain.
3794
3795         Establish a new format for uploading results that is not tied to layout tests, apply
3796         that format to webkitpy tests.
3797
3798         * Scripts/webkitpy/common/checkout/scm/git.py:
3799         (Git.native_branch): Return what branch the current checkout is on.
3800         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3801         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3802         * Scripts/webkitpy/common/checkout/scm/svn.py:
3803         (SVN.native_branch): Ditto.
3804         * Scripts/webkitpy/common/system/platforminfo.py:
3805         (PlatformInfo.build_version): Return a build version for Mac.
3806         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3807         (MockPlatformInfo.__init__):
3808         (MockPlatformInfo.build_version):
3809         * Scripts/webkitpy/results: Added.
3810         * Scripts/webkitpy/results/__init__.py: Added.
3811         * Scripts/webkitpy/results/options.py: Added.
3812         (upload_options): OptParse list for upload options.
3813         * Scripts/webkitpy/results/upload.py: Added.
3814         (Upload): Class which enforces the upload format expected by the results server.
3815         (Upload.Expectations):
3816         (Upload.create_configuration):
3817         (Upload.create_commit):
3818         (Upload.create_details):
3819         (Upload.create_run_stats):
3820         (Upload.create_test_result):
3821         (Upload.__init__):
3822         (Upload.Encoder): Encode Upload object as json.
3823         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3824         * Scripts/webkitpy/results/upload_unittest.py: Added.
3825         * Scripts/webkitpy/test/main.py:
3826         (Tester._parse_args): Add upload arguments.
3827         (Tester._run_tests): Allow results to be uploaded.
3828         * Scripts/webkitpy/test/runner.py:
3829         (Runner.__init__): Record which tests were run, rather than just counting them.
3830         (Runner.handle):
3831         * Scripts/webkitpy/test/runner_unittest.py:
3832         (RunnerTest.test_run):
3833         * Scripts/webkitpy/thirdparty/__init__.py:
3834         (AutoinstallImportHook.find_module): Add requests auto-install.
3835         (AutoinstallImportHook._install_requests):
3836         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3837         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3838
3839 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3840
3841         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3842         https://bugs.webkit.org/show_bug.cgi?id=195810
3843
3844         Reviewed by Tim Horton.
3845
3846         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3847         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3848         ending certain layout tests.
3849
3850         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3851         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3852         (-[TestRunnerWKWebView dealloc]):
3853         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3854
3855         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3856         helper method when destroying the web view, and when resetting state between tests.
3857
3858         * WebKitTestRunner/ios/TestControllerIOS.mm:
3859         (WTR::TestController::platformResetStateToConsistentValues):
3860
3861         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3862
3863 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3864
3865         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3866         https://bugs.webkit.org/show_bug.cgi?id=190350
3867         <rdar://problem/45089503>
3868
3869         Reviewed by Geoffrey Garen.
3870
3871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3872         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3873         (TEST):
3874         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3875         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3876         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3877         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3878         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3879         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3880         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3881         (runTest):
3882         (createDirectories):
3883         (TEST):
3884         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3885         (TEST):
3886         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3887         (TEST):
3888
3889 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3890
3891         Add support to WebPage for getting the contents as an attributed string.
3892         https://bugs.webkit.org/show_bug.cgi?id=195636
3893         rdar://problem/45055697
3894
3895         Reviewed by Tim Horton.
3896
3897         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3898         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3899
3900 2019-03-15  Chris Dumez  <cdumez@apple.com>
3901
3902         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3903         https://bugs.webkit.org/show_bug.cgi?id=195747
3904
3905         Reviewed by Geoff Garen.
3906
3907         Add API test coverage.
3908
3909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3910
3911 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3912
3913         Unreviewed, rolling out r242952.
3914
3915         Causing API failures on iOS Simulator
3916
3917         Reverted changeset:
3918
3919         "[PSON] Make sure the WebProcessCache is leverage when
3920         relaunching a process after termination"
3921         https://bugs.webkit.org/show_bug.cgi?id=195747
3922         https://trac.webkit.org/changeset/242952
3923
3924 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3925
3926         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3927         https://bugs.webkit.org/show_bug.cgi?id=195740
3928
3929         Reviewed by Ross Kirsling.
3930
3931         window.open doesn't work for WebKitBrowserWindow because it is not
3932         implemented yet.
3933
3934         1. Implemented createNewPage callback of WKPageUIClient.
3935         2. Changed MainWindow to take a BrowserWindow factory function
3936           instead of BrowserWindowType to be flexible to create
3937           BrowserWindow with extra settings.
3938         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3939           because it is not relevant with MainWindow anymore.
3940
3941         * MiniBrowser/win/Common.cpp:
3942         (parseCommandLine):
3943         * MiniBrowser/win/Common.h:
3944         (CommandLineOptions::CommandLineOptions):
3945         * MiniBrowser/win/MainWindow.cpp:
3946         (MainWindow::MainWindow):
3947         (MainWindow::create):
3948         (MainWindow::init):
3949         (MainWindow::WndProc):
3950         * MiniBrowser/win/MainWindow.h:
3951         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3952         (PrintWebUIDelegate::createWebViewWithRequest):
3953         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3954         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3955         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3956         (WebKitBrowserWindow::updateProxySettings):
3957         (WebKitBrowserWindow::createNewPage):
3958         * MiniBrowser/win/WebKitBrowserWindow.h:
3959         * MiniBrowser/win/WinMain.cpp:
3960         (wWinMain):
3961
3962 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3963
3964         Make it possible to test scrolling tree layer manipulation more easily
3965         https://bugs.webkit.org/show_bug.cgi?id=195780
3966
3967         Reviewed by Tim Horton.
3968         
3969         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3970         cuts off communication of scrolling tree scrolls back to the web process
3971         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3972         allows tests to trigger scrolls which run the scrolling tree layer positioning
3973         logic, but never get another commit from the web process that might mask
3974         scrolling tree bugs.
3975         
3976         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3977         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3978         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3979
3980         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3981         (WTR::UIScriptController::scrollUpdatesDisabled const):
3982         (WTR::UIScriptController::setScrollUpdatesDisabled):
3983         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3984         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3985         (WTR::UIScriptController::scrollUpdatesDisabled const):
3986         (WTR::UIScriptController::setScrollUpdatesDisabled):
3987         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3988         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3989         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3990         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3991         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3992         * WebKitTestRunner/ios/TestControllerIOS.mm:
3993         (WTR::TestController::platformResetStateToConsistentValues):
3994         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3995         (WTR::UIScriptController::scrollUpdatesDisabled const):
3996         (WTR::UIScriptController::setScrollUpdatesDisabled):
3997
3998 2019-03-14  Youenn Fablet  <youenn@apple.com>
3999
4000         Move IDB storage in private browsing mode to NetworkProcess
4001         https://bugs.webkit.org/show_bug.cgi?id=195602
4002
4003         Reviewed by Brady Eidson.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4006         (TEST):
4007
4008 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4009
4010         [ews-build] Make descriptionDone messages more readable
4011         https://bugs.webkit.org/show_bug.cgi?id=195760
4012
4013         Reviewed by Lucas Forschler.
4014
4015         * BuildSlaveSupport/ews-build/steps.py:
4016         * BuildSlaveSupport/ews-build/steps_unittest.py:
4017
4018 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4019
4020         [ews-build] Generate status-bubble hover-over messages
4021         https://bugs.webkit.org/show_bug.cgi?id=195680
4022
4023         Reviewed by Lucas Forschler.
4024
4025         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4026         (StatusBubble):
4027         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4028         on hover-over.
4029         (StatusBubble._iso_time):
4030         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4031         hover-over message.
4032         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4033
4034 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4035
4036         [ews-app] Gracefully handle the case when state_string is None
4037         https://bugs.webkit.org/show_bug.cgi?id=195753
4038
4039         Reviewed by Lucas Forschler.
4040
4041         * BuildSlaveSupport/ews-app/ews/models/build.py:
4042         * BuildSlaveSupport/ews-app/ews/models/step.py:
4043
4044 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4045
4046         [ews-app] Status bubble display pending for currently running build step
4047         https://bugs.webkit.org/show_bug.cgi?id=195744
4048
4049         Reviewed by Lucas Forschler.
4050
4051         * BuildSlaveSupport/ews-build/events.py:
4052         (Events.stepStarted): If state_string is pending, replace it with step name.
4053
4054 2019-03-14  Chris Dumez  <cdumez@apple.com>
4055
4056         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4057         https://bugs.webkit.org/show_bug.cgi?id=195750
4058
4059         Reviewed by Geoffrey Garen.
4060
4061         Add API test coverage.
4062
4063         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4064         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4065         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4066         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4067
4068 2019-03-14  Chris Dumez  <cdumez@apple.com>
4069
4070         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4071         https://bugs.webkit.org/show_bug.cgi?id=195747
4072
4073         Reviewed by Geoff Garen.
4074
4075         Add API test coverage.
4076
4077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4078
4079 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4080
4081         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4082         https://bugs.webkit.org/show_bug.cgi?id=195725
4083         <rdar://problem/48545062>
4084
4085         Reviewed by Tim Horton.
4086
4087         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4088         handler is nil.
4089
4090         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4091         (TestWebKitAPI::TEST):
4092
4093 2019-03-13  Sam Weinig  <sam@webkit.org>
4094
4095         Add utility function to allow easy reverse range-based iteration of a container
4096         https://bugs.webkit.org/show_bug.cgi?id=195542
4097
4098         Reviewed by Antti Koivisto.
4099
4100         * TestWebKitAPI/CMakeLists.txt:
4101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4102         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4103         (TestWebKitAPI::TEST):
4104         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4105
4106 2019-03-13  Chris Dumez  <cdumez@apple.com>
4107
4108         Use a ServiceWorker process per registrable domain
4109         https://bugs.webkit.org/show_bug.cgi?id=195649
4110
4111         Reviewed by Youenn Fablet.
4112
4113         Update API test coverage.
4114
4115         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4116
4117 2019-03-13  Chris Dumez  <cdumez@apple.com>
4118
4119         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4120         https://bugs.webkit.org/show_bug.cgi?id=195684
4121         <rdar://problem/48294714>
4122
4123         Reviewed by Antti Koivisto.
4124
4125         Add API test coverage.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4128
4129 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4130
4131         [ews-app] Remove unused patch view
4132         https://bugs.webkit.org/show_bug.cgi?id=195669
4133
4134         Reviewed by Lucas Forschler.
4135
4136         * BuildSlaveSupport/ews-app/ews/urls.py:
4137         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4138
4139 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4140
4141         [ews-app] Use Buildbot result code variables
4142         https://bugs.webkit.org/show_bug.cgi?id=195668
4143
4144         Reviewed by Alexey Proskuryakov.
4145
4146         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4147         (Buildbot): Added Buildbot result code variables.
4148         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4149         (StatusBubble._build_bubble): Used Buildbot result code variables.
4150
4151 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4152
4153         [Flatpak] Expand submodule recursively
4154         https://bugs.webkit.org/show_bug.cgi?id=195672
4155
4156         Building WPE with flatpak was impossible without that as it was raising an exception.
4157         Also update wpebackend-fdo to match what is built in jhbuild
4158
4159         Reviewed by Philippe Normand.
4160
4161         * flatpak/flatpakutils.py:
4162         (expand_submodules_recurse):
4163         (expand_manifest):
4164         * flatpak/org.webkit.WPEModules.yaml:
4165
4166 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4167
4168         [ews-app] status bubble should be hidden for certain builds
4169         https://bugs.webkit.org/show_bug.cgi?id=194597
4170
4171         Reviewed by Dewei Zhu.
4172
4173         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4174         (StatusBubble._build_bubble):
4175         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4176         because the patch didn't have relevant changes.
4177         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4178         in production yet.
4179
4180 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4181
4182         [Win] Fix a slew of simple clang-cl warnings.
4183         https://bugs.webkit.org/show_bug.cgi?id=195652
4184
4185         Reviewed by Don Olmstead.
4186
4187         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4188         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4189
4190 2019-03-12  Justin Fan  <justin_fan@apple.com>
4191
4192         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4193         https://bugs.webkit.org/show_bug.cgi?id=195518
4194         <rdar://problem/46322356>
4195
4196         Reviewed by Myles C. Maxfield.
4197
4198         * DumpRenderTree/DerivedSources-input.xcfilelist:
4199         * DumpRenderTree/DerivedSources-output.xcfilelist:
4200
4201 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4202
4203         Unreviewed, rolling out r242825.
4204         https://bugs.webkit.org/show_bug.cgi?id=195648
4205
4206         "Broke webkitpy tests with my change to
4207         lldb_dump_class_layout.py" (Requested by rmorisset on
4208         #webkit).
4209
4210         Reverted changeset:
4211
4212         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4213         classes with suspicious padding"
4214         https://bugs.webkit.org/show_bug.cgi?id=195573
4215         https://trac.webkit.org/changeset/242825
4216
4217 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4218
4219         [ews-build] Show status bubbles while the patch is waiting in queue
4220         https://bugs.webkit.org/show_bug.cgi?id=195618
4221
4222         Reviewed by Lucas Forschler.
4223
4224         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4225         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4226         enabled in initial deployment.
4227         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4228         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4229         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4230         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4231         (StatusBubble._build_bubbles_for_patch):
4232
4233 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4234
4235         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4236         https://bugs.webkit.org/show_bug.cgi?id=195573
4237
4238         Reviewed by Simon Fraser.
4239
4240         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4241
4242         * Scripts/dump-class-layout:
4243         (main):
4244         * lldb/lldb_dump_class_layout.py:
4245         (ClassLayout.__init__):
4246         (ClassLayout._compute_padding_recursive):
4247         (LLDBDebuggerInstance.dump_layout_for_classname):
4248         (LLDBDebuggerInstance):
4249         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4250         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4251
4252 2019-03-12  Chris Dumez  <cdumez@apple.com>
4253
4254         Device Orientation access permission should be denied unless explicitly granted by the client
4255         https://bugs.webkit.org/show_bug.cgi?id=195625
4256
4257         Reviewed by Youenn Fablet.
4258
4259         add API test coverage.
4260
4261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4262         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4263         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4264         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4265         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4266         (runDeviceOrientationTest):
4267         (TEST):
4268         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4269         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4270
4271 2019-03-12  Jer Noble  <jer.noble@apple.com>
4272
4273         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4274         https://bugs.webkit.org/show_bug.cgi?id=195137
4275         <rdar://problem/48810307>
4276
4277         Reviewed by Eric Carlson.
4278
4279         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4280         (TestWebKitAPI::TEST):
4281
4282 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4283
4284         [ews-build] Change urls from uat to production
4285         https://bugs.webkit.org/show_bug.cgi?id=195566
4286
4287         Reviewed by Lucas Forschler.
4288
4289         * BuildSlaveSupport/ews-app/ews/config.py:
4290         * BuildSlaveSupport/ews-build/events.py:
4291         * BuildSlaveSupport/ews-build/steps.py:
4292
4293 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4294
4295         [ews-build] change max_builds for local-worker to 1
4296         https://bugs.webkit.org/show_bug.cgi?id=195568
4297
4298         Reviewed by Lucas Forschler.
4299
4300         * BuildSlaveSupport/ews-build/loadConfig.py:
4301
4302 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4303
4304         Fix the build
4305
4306         * TestRunnerShared/spi/PencilKitTestSPI.h:
4307         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4308
4309 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4310
4311         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4312         https://bugs.webkit.org/show_bug.cgi?id=194131
4313
4314         Reviewed by Michael Catanzaro.
4315
4316         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4317         (uriChanged):
4318         (testUnfinishedSubresourceLoad):
4319         (serverCallback):
4320         (beforeAll):
4321