Unreviewed, rolling out r212237.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-14  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r212237.
4         https://bugs.webkit.org/show_bug.cgi?id=168298
5
6         This was a wrong fix (Requested by rniwa on #webkit).
7
8         Reverted changeset:
9
10         "Nwtr unexpectedly passes mismatch ref test if the hashes
11         doesn't match but no diff"
12         https://bugs.webkit.org/show_bug.cgi?id=168221
13         http://trac.webkit.org/changeset/212237
14
15 2017-02-13  Alex Christensen  <achristensen@webkit.org>
16
17         URLs with an invalid IPv4 address should be invalid
18         https://bugs.webkit.org/show_bug.cgi?id=168260
19
20         Reviewed by Tim Horton.
21
22         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
23         (TestWebKitAPI::TEST_F):
24         Update tests to reflect new correct behavior.
25
26 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
27
28         [WinCairo] Add Build Slave
29         https://bugs.webkit.org/show_bug.cgi?id=168263
30
31         Reviewed by Lucas Forschler.
32
33         * BuildSlaveSupport/build.webkit.org-config/config.json:
34
35 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
36
37         Fix the build after r212254
38
39         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
40         (-[DataInteractionSimulator _currentLocation]):
41
42 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
43
44         [WK2] Add test infrastructure and unit tests for data interaction
45         https://bugs.webkit.org/show_bug.cgi?id=168159
46         <rdar://problem/30477634>
47
48         Reviewed by Tim Horton.
49
50         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
51         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
52         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
53         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
54         gesture has already been recognized) at regular intervals over the course of the test.
55
56         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
57         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
58         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
59         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
60
61         New test pages for data interaction.
62
63         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
64         (TestWebKitAPI::runTestsExpectingToObserveEvents):
65         (TestWebKitAPI::TEST):
66         * TestWebKitAPI/cocoa/TestWKWebView.mm:
67         (-[TestWKWebView stringByEvaluatingJavaScript:]):
68         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
69         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
70         (-[MockLongPressGestureRecognizer initWithWindow:]):
71         (-[MockLongPressGestureRecognizer locationInView:]):
72         (-[MockLongPressGestureRecognizer state]):
73         (-[MockLongPressGestureRecognizer numberOfTouches]):
74         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
75         (-[DataInteractionSimulator dealloc]):
76         (-[DataInteractionSimulator run]):
77
78         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
79         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
80         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
81
82         (-[DataInteractionSimulator _advanceProgress]):
83
84         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
85         completed, and calls _finishDataInteraction when progress is at 1.
86
87         (-[DataInteractionSimulator _finishDataInteraction]):
88         (-[DataInteractionSimulator _currentLocation]):
89         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
90         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
91         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
92         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
93         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
94
95 2017-02-13  Alex Christensen  <achristensen@webkit.org>
96
97         Percent should be allowed in non-special URL hosts
98         https://bugs.webkit.org/show_bug.cgi?id=168255
99
100         Reviewed by Tim Horton.
101
102         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
103         (TestWebKitAPI::TEST_F):
104
105 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
106
107         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
108         https://bugs.webkit.org/show_bug.cgi?id=168221
109
110         Reviewed by Ryosuke Niwa.
111
112         There is a logic error in comparing mismatch ref test images. In
113         mismatch ref tests, it should be failed if two images has no diff.
114         But, if the hashes are different, nwtr unexpectedly pass the
115         mismatch ref test.
116
117         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
118         (SingleTestRunner._compare_output_with_reference): Fail the
119         mismatch ref test if hashes of two images are equal. Invoke
120         ImageDiff if the hashes don't match.
121
122 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
123
124         Update custom line breaking iterators to the latest version of Unicode
125         https://bugs.webkit.org/show_bug.cgi?id=168182
126
127         Reviewed by Zalan Bujtas.
128
129         Treat the system's ICU as the source of truth to compare breaking positions against.
130
131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
132         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
133         (generateJavaScriptForTest):
134         (breakingLocationsFromICU):
135         (testAFewStrings):
136         (TEST):
137         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
138         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
139
140 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
141
142         [GTK] Several failing WebViewEditor API tests
143         https://bugs.webkit.org/show_bug.cgi?id=161608
144
145         Reviewed by Carlos Garcia Campos.
146
147         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
148         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
149         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
150         except the first one, which is still broken due to unrelated bug #151654.
151
152         * Scripts/run-gtk-tests:
153         (TestRunner):
154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
155
156 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
157
158         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
159
160         * Scripts/run-gtk-tests:
161         (TestRunner):
162
163 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
164
165         Unreviewed, skip flaky form-controls-associated-signal test
166
167         * Scripts/run-gtk-tests:
168         (TestRunner):
169
170 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
171
172         [GTK] Handle caps lock indicator in event modifiers
173         https://bugs.webkit.org/show_bug.cgi?id=168186
174
175         Reviewed by Michael Catanzaro.
176
177         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
178         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
179
180 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
181
182         MiniBrowser WK1 fails to update URL for within-page navigations
183         https://bugs.webkit.org/show_bug.cgi?id=168173
184
185         Reviewed by Tim Horton.
186         
187         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
188         anchors updates the URL field.
189
190         * MiniBrowser/mac/WK1BrowserWindowController.m:
191         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
192
193 2017-02-10  John Wilander  <wilander@apple.com>
194
195         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
196         https://bugs.webkit.org/show_bug.cgi?id=167474
197         <rdar://problem/24681808>
198         <rdar://problem/24703286>
199         <rdar://problem/30290270>
200
201         This patch adds test infrastructure to allow testing 
202         of the various rules in place for data records removal.
203
204         Reviewed by Andy Estes.
205
206         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
207         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
208         (WTR::InjectedBundle::didReceiveMessageToPage):
209             Callback mechanism to tell pages that a website data store
210             scan has happened.
211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
212         (WTR::TestRunner::setStatisticsPrevalentResource):
213         (WTR::TestRunner::isStatisticsPrevalentResource):
214         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
215         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
216         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
217         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
218         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
219         (WTR::TestRunner::statisticsFireDataModificationHandler):
220         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
221         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
222         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
223         (WTR::TestRunner::statisticsResetToConsistentState):
224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::setStatisticsPrevalentResource):
227         (WTR::TestController::isStatisticsPrevalentResource):
228         (WTR::TestController::setStatisticsHasHadUserInteraction):
229         (WTR::TestController::isStatisticsHasHadUserInteraction):
230         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
231         (WTR::TestController::statisticsFireDataModificationHandler):
232         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
233         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
234         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
235         (WTR::TestController::statisticsResetToConsistentState):
236         * WebKitTestRunner/TestController.h:
237             These are all configuration and test functions.
238         * WebKitTestRunner/TestInvocation.cpp:
239         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
240
241 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
242
243         REGRESSION(r182916) run-perf-tests never timeouts
244         https://bugs.webkit.org/show_bug.cgi?id=167626
245
246         Reviewed by Ryosuke Niwa.
247
248         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
249         was beeing ignored because the driver was created with no_timeout=True
250         unconditionally.
251         This adds a new parameter --no-timeout (disabled by default), that
252         allows to use the driver with the expected timeout values.
253         It also passes --no-timeout to DRT/WTR to ensure that timeouts
254         are always controlled by the Python Driver.
255
256         * Scripts/webkitpy/performance_tests/perftest.py:
257         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
258         (PerfTest.run): Disabling timeout should be done when the Driver is created.
259         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
260         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
261         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
262         (_run_tests_set): Pass the no-timeout parameter.
263         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
264         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
265         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
266         (MainTest.test_parse_args): Test that the argument no-timeout.
267
268 2017-02-10  Daniel Bates  <dabates@apple.com>
269
270         Detach frame from document when entering page cache
271         https://bugs.webkit.org/show_bug.cgi?id=166774
272         <rdar://problem/29904368>
273
274         Reviewed by Chris Dumez.
275
276         * DumpRenderTree/mac/DumpRenderTree.mm:
277         (resetWebPreferencesToConsistentValues):
278         * DumpRenderTree/win/DumpRenderTree.cpp:
279         (resetWebPreferencesToConsistentValues):
280         * WebKitTestRunner/TestController.cpp:
281         (WTR::TestController::resetPreferencesToConsistentValues):
282
283 2017-02-10  Tim Horton  <timothy_horton@apple.com>
284
285         Infinite UI process hang under ensurePositionInformationIsUpToDate
286         https://bugs.webkit.org/show_bug.cgi?id=168154
287         <rdar://problem/30428673>
288
289         Reviewed by Simon Fraser.
290
291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
292         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
293         (recursiveFindHighlightLongPressRecognizer):
294         (TEST):
295         Add a somewhat nasty test that does an async interaction information update, but
296         kills the Web process before it arrives, and then does a sync interaction
297         information update, which will wait for the oustanding async interaction
298         information update if we still think it's coming. Before the patch, this
299         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
300
301 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
302
303         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
304         https://bugs.webkit.org/show_bug.cgi?id=168127
305         rdar://problem/30467120
306
307         Reviewed by Tim Horton.
308
309         Reparent the web view before we try to fetch it via:
310             [[[window contentView] subviews] objectAtIndex:0];
311         which would throw an exception if the test unparented it.
312
313         * DumpRenderTree/mac/DumpRenderTree.mm:
314         (resetWebViewToConsistentStateBeforeTesting):
315         (runTest):
316
317 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
318
319         [Resource Timing] Enable Resource Timing by default in Tests
320         https://bugs.webkit.org/show_bug.cgi?id=168145
321
322         Reviewed by Ryosuke Niwa.
323
324         * DumpRenderTree/mac/DumpRenderTree.mm:
325         (resetWebPreferencesToConsistentValues):
326         * DumpRenderTree/win/DumpRenderTree.cpp:
327         (resetWebPreferencesToConsistentValues):
328         * WebKitTestRunner/TestController.cpp:
329         (WTR::TestController::resetPreferencesToConsistentValues):
330
331 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
332
333         Removing LayoutTestRelay
334         https://bugs.webkit.org/show_bug.cgi?id=165927
335
336         Reviewed by Daniel Bates.
337         Part 2
338
339         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
340         simulators through simctl (iOS 10 and later), use this functionality instead.
341
342         * BuildSlaveSupport/built-product-archive:
343         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
344         Added a FIXME that we will need to implement similar archiving machinery once we build
345         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
346         * BuildSlaveSupport/kill-old-processes:
347         (main): Remove LayoutTestRelay from list of processes.
348         * LayoutTestRelay: Removed LayoutTestRelay.
349         * Makefile:
350         * Scripts/build-layouttestrelay: Removed.
351         * Scripts/build-webkit: Removed LayoutTestRelay references.
352
353 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
354
355         [WebCrypto] Add WebCryptoAPI to watchlist
356         https://bugs.webkit.org/show_bug.cgi?id=168138
357
358         Reviewed by Youenn Fablet.
359
360         * Scripts/webkitpy/common/config/watchlist:
361
362 2017-02-10  Brady Eidson  <beidson@apple.com>
363
364         Replace all WebKit Library Version checks in WK2 with SDK version checks.
365         https://bugs.webkit.org/show_bug.cgi?id=168124
366
367         Reviewed by Geoffrey Garen.
368
369         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
370         
371         * MiniBrowser/mac/main.m:
372         (main):
373         * MobileMiniBrowser/MobileMiniBrowser/main.m:
374         (main):
375         * TestWebKitAPI/ios/mainIOS.mm:
376         (main):
377         * TestWebKitAPI/mac/mainMac.mm:
378         (main):
379         * WebKitTestRunner/ios/mainIOS.mm:
380         (main):
381         * WebKitTestRunner/mac/main.mm:
382         (setDefaultsToConsistentValuesForTesting):
383
384 2017-02-10  Alex Christensen  <achristensen@webkit.org>
385
386         Fix El Capitan build.
387
388         * Scripts/build-webkit:
389         Don't build libwebrtc anywhere for now.
390
391 2017-02-10  Andy Estes  <aestes@apple.com>
392
393         Move two MiniBrowserBundle settings out of the .pbxproj
394         https://bugs.webkit.org/show_bug.cgi?id=168106
395
396         Reviewed by Tim Horton.
397
398         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
399         the project file. This removes the project file override.
400
401         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
402
403         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
404         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
405
406 2017-02-10  Alex Christensen  <achristensen@webkit.org>
407
408         Fix 32-and-64-bit build on El Capitan.
409
410         * Scripts/build-webkit:
411         Somebody's building with something like this:
412         build-webkit ARCHS="i386 x86_64"
413         We want this to also not build libwebrtc for now.
414
415 2017-02-10  Alex Christensen  <achristensen@webkit.org>
416
417         Fix 32-bit build on El Capitan.
418
419         * Scripts/build-webkit:
420         The bot uses ARCHS=i386 instead of --32-bit.
421         This is a hack, but it should fix the bot until I can do a better fix in the morning.
422
423 2017-02-10  Alex Christensen  <achristensen@webkit.org>
424
425         Fix 32-bit build on El Capitan.
426
427         * Scripts/build-webkit:
428         Don't build i386 libwebrtc.
429
430 2017-02-09  Alex Christensen  <achristensen@webkit.org>
431
432         Unreviewed, rolling out r212040.
433
434         Broke build.  I'm not surprised
435
436         Reverted changeset:
437
438         "[WebRTC][Mac] Activate libwebrtc"
439         https://bugs.webkit.org/show_bug.cgi?id=167293
440         http://trac.webkit.org/changeset/212040
441
442 2017-02-09  Alex Christensen  <achristensen@webkit.org>
443
444         Build libwebrtc on bots without using it yet
445         https://bugs.webkit.org/show_bug.cgi?id=168062
446
447         Reviewed by Brent Fulgham.
448
449         * Scripts/build-webkit:
450
451 2017-02-09  Alex Christensen  <achristensen@webkit.org>
452
453         Don't build libwebrtc.
454
455         * Scripts/build-webkit:
456         Not ready yet.  It broke El Capitan and iOS.
457
458 2017-02-09  Alex Christensen  <achristensen@webkit.org>
459
460         Build libwebrtc on bots without using it yet
461         https://bugs.webkit.org/show_bug.cgi?id=168062
462
463         Reviewed by Brent Fulgham.
464
465         * Scripts/build-webkit:
466
467 2017-02-09  Alex Christensen  <achristensen@webkit.org>
468
469         Rename isAppleMacWebKit to isAppleCocoaWebKit
470         https://bugs.webkit.org/show_bug.cgi?id=168075
471
472         Reviewed by Geoffrey Garen.
473
474         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
475
476         * Scripts/build-api-tests:
477         * Scripts/build-dumprendertree:
478         * Scripts/build-jsc:
479         (buildMyProject):
480         * Scripts/build-layouttestrelay:
481         * Scripts/build-webkit:
482         * Scripts/build-webkittestrunner:
483         * Scripts/run-api-tests:
484         (isSupportedPlatform):
485         (runTest):
486         (listAllTests):
487         (prepareEnvironmentForRunningTestTool):
488         * Scripts/run-content-extension-tester:
489         * Scripts/run-javascriptcore-tests:
490         * Scripts/run-minibrowser:
491         * Scripts/show-pretty-diff:
492         * Scripts/webkitdirs.pm:
493         (determineBaseProductDir):
494         (determineArchitecture):
495         (determinePassedArchitecture):
496         (safariPath):
497         (builtDylibPathForName):
498         (checkFrameworks):
499         (isAppleWebKit):
500         (isAppleCocoaWebKit):
501         (determineNmPath):
502         (launcherName):
503         (wrapperPrefixIfNeeded):
504         (isCMakeBuild):
505         (mobileSafariBundle):
506         (debugSafari):
507         (runSafari):
508         (runMiniBrowser):
509         (debugMiniBrowser):
510         (runWebKitTestRunner):
511         (debugWebKitTestRunner):
512         (isAppleMacWebKit): Deleted.
513         * Scripts/webkitperl/FeatureList.pm:
514
515 2017-02-09  Alex Christensen  <achristensen@webkit.org>
516
517         Revert r211991
518         https://bugs.webkit.org/show_bug.cgi?id=168062
519
520         * Scripts/build-webkit:
521         Not quite ready yet.
522
523 2017-02-09  Alex Christensen  <achristensen@webkit.org>
524
525         Build libwebrtc on bots without using it yet
526         https://bugs.webkit.org/show_bug.cgi?id=168062
527
528         Reviewed by Brent Fulgham.
529
530         * Scripts/build-webkit:
531         Build libwebrtc on Mac when we build ANGLE.
532
533 2017-02-09  Youenn Fablet  <youenn@apple.com>
534
535         Improve W3C importer command line options
536         https://bugs.webkit.org/show_bug.cgi?id=167448
537
538         Reviewed by Ryosuke Niwa.
539
540         Making the list of test paths to import the main arguments of the script.
541         Allow passing the source directory to import as a -s option.
542         Adding a warning when given test paths are skipped by default in ImportExpectations.
543
544         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
545         Link conversion rules do not change when imported tests are downloaded by the script.
546
547         * Scripts/webkitpy/w3c/test_importer.py:
548         (main):
549         (parse_args):
550         (TestImporter.__init__):
551         (TestImporter.do_import):
552         (TestImporter):
553         (TestImporter.check_imported_expectations):
554
555 2017-02-08  Chris Dumez  <cdumez@apple.com>
556
557         Update web-platform-tests resources
558         https://bugs.webkit.org/show_bug.cgi?id=168026
559
560         Reviewed by Youenn Fablet.
561
562         Stop copying testharness.js from resources/ to web-platform-tests/resources.
563
564         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
565         (WebPlatformTestServer._copy_webkit_test_files):
566
567 2017-02-08  Andy Estes  <aestes@apple.com>
568
569         Custom protocols should not continue loading after a network process crash
570         https://bugs.webkit.org/show_bug.cgi?id=168028
571         <rdar://problem/27607520>
572
573         Reviewed by Brady Eidson.
574
575         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
576         (processGroup):
577         (-[CloseWhileStartingProtocol startLoading]):
578         (-[CloseWhileStartingProtocol stopLoading]):
579         (TestWebKitAPI::runTest):
580         (TestWebKitAPI::TEST):
581
582 2017-02-08  Dan Bernstein  <mitz@apple.com>
583
584         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
585         https://bugs.webkit.org/show_bug.cgi?id=168031
586
587         Reviewed by Tim Horton.
588
589         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
590         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
591         (TEST):
592         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
593         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
594
595 2017-02-08  Chris Dumez  <cdumez@apple.com>
596
597         Use smaller tiles in windows that are not active to facilitate App Napping
598         https://bugs.webkit.org/show_bug.cgi?id=167997
599         <rdar://problem/30358835>
600
601         Reviewed by Simon Fraser.
602
603         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
604         (WTR::PlatformWebView::setWindowIsKey):
605         Actually update windowIsKey state of NSWindow so the WebView
606         properly updates its activity state.
607
608 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
609
610         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
611         https://bugs.webkit.org/show_bug.cgi?id=167942
612         <rdar://problem/30315079>
613
614         Reviewed by Tim Horton.
615
616         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
617         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
618         contenteditable in these cases.
619
620         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
621         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
622         performDragOperation:) directly.
623
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
626         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
627         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
628         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
629         (-[DragSource draggingSourceOperationMaskForLocal:]):
630         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
631         (-[DragInfo lastMousePosition]):
632         (-[DragInfo setLastMousePosition:]):
633         (-[DragInfo draggingDestinationWindow]):
634         (-[DragInfo draggingSourceOperationMask]):
635         (-[DragInfo draggingLocation]):
636         (-[DragInfo draggedImageLocation]):
637         (-[DragInfo draggedImage]):
638         (-[DragInfo draggingPasteboard]):
639         (-[DragInfo draggingSource]):
640         (-[DragInfo draggingSequenceNumber]):
641         (-[DragInfo slideDraggedImageTo:]):
642         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
643         (-[DragInfo draggingFormation]):
644         (-[DragInfo setDraggingFormation:]):
645         (-[DragInfo animatesToDestination]):
646         (-[DragInfo setAnimatesToDestination:]):
647         (-[DragInfo numberOfValidItemsForDrop]):
648         (-[DragInfo setNumberOfValidItemsForDrop:]):
649         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
650         (-[DragInfo springLoadingHighlight]):
651         (-[DragInfo resetSpringLoading]):
652         (TestWebKitAPI::getTestImage):
653         (TestWebKitAPI::webViewAfterPerformingDragOperation):
654         (TestWebKitAPI::TEST):
655         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
656
657 2017-02-08  Jer Noble  <jer.noble@apple.com>
658
659         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
660         https://bugs.webkit.org/show_bug.cgi?id=168007
661
662         Reviewed by Alex Christensen.
663
664         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
665         (didFinishLoadForFrame):
666         (TestWebKitAPI::TEST):
667
668 2017-02-08  Commit Queue  <commit-queue@webkit.org>
669
670         Unreviewed, rolling out r211873.
671         https://bugs.webkit.org/show_bug.cgi?id=168001
672
673         It's in jhbuild for consistent layout tests (Requested by
674         mcatanzaro on #webkit).
675
676         Reverted changeset:
677
678         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
679         https://bugs.webkit.org/show_bug.cgi?id=167993
680         http://trac.webkit.org/changeset/211873
681
682 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
683
684         [GTK] Add icu packages to Tools/gtk/install-dependencies
685         https://bugs.webkit.org/show_bug.cgi?id=167993
686
687         Reviewed by Michael Catanzaro.
688
689         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
690         depending in the GNU/Linux distribution)
691
692 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
693
694         Update flakiness dashboard configuration.
695         https://bugs.webkit.org/show_bug.cgi?id=167957
696
697         Reviewed by Alexey Proskuryakov.
698
699         * TestResultServer/static-dashboards/builders.jsonp:
700
701 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
702
703         Replace a bot that has an incorrect configuration.
704         https://bugs.webkit.org/show_bug.cgi?id=167747
705
706         Rubber-stamped by Alexey Proskuryakov.
707
708         * BuildSlaveSupport/build.webkit.org-config/config.json:
709
710 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
711
712         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
713         https://bugs.webkit.org/show_bug.cgi?id=167927
714
715         Reviewed by Brent Fulgham.
716
717         Enable ComplexTextController API tests on the Win and GTK ports.
718
719         * TestWebKitAPI/PlatformGTK.cmake:
720         * TestWebKitAPI/PlatformWin.cmake:
721
722 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
723
724         File index appended to previous file in svn-create-patch with SVN 1.9
725         https://bugs.webkit.org/show_bug.cgi?id=167903
726         <rdar://problem/30387395>
727
728         Reviewed by Daniel Bates.
729
730         * Scripts/VCSUtils.pm:
731         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
732         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
733         trailing newline character from the expected result before comparing it to the actual result.
734
735 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
736
737         [webkitdirs] remove unused host_processor variable in determineArchitecture()
738         https://bugs.webkit.org/show_bug.cgi?id=167936
739
740         Reviewed by Michael Catanzaro.
741
742         * Scripts/webkitdirs.pm:
743         (determineArchitecture):
744         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
745         since r195083.
746
747 2017-02-07  Youenn Fablet  <youenn@apple.com>
748
749         Use a JSON file to define which WPT files/folders to import
750         https://bugs.webkit.org/show_bug.cgi?id=167923
751
752         Reviewed by Alex Christensen.
753
754         * Scripts/webkitpy/w3c/test_downloader.py:
755         (TestDownloader.__init__):
756         (TestDownloader._init_paths_from_expectations):
757         * Scripts/webkitpy/w3c/test_importer.py:
758         (parse_args):
759         * Scripts/webkitpy/w3c/test_importer_unittest.py:
760
761 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
762
763         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
764         https://bugs.webkit.org/show_bug.cgi?id=167916
765
766         Reviewed by Carlos Garcia Campos.
767
768         URL of mesa-11.0.6.tar.xz has been moved.
769
770         * gtk/jhbuild.modules: Fix the module path.
771
772 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
773
774         Static Analyzer: Address some leaks in MiniBrowser
775         https://bugs.webkit.org/show_bug.cgi?id=167897
776
777         Reviewed by Alexey Proskuryakov.
778
779         * MiniBrowser/mac/BrowserWindowController.m:
780         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
781         * MiniBrowser/mac/ExtensionManagerWindowController.m:
782         (-[ExtensionManagerWindowController add:]):
783         (-[ExtensionManagerWindowController remove:]):
784         * MiniBrowser/mac/SettingsController.m:
785         (-[SettingsController _populateMenu]):
786         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
787         Address obvious leaks caught by the static analyzer.
788
789 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
790
791         Migrate ComplexTextController to use platform-independent types
792         https://bugs.webkit.org/show_bug.cgi?id=167833
793
794         Reviewed by Brent Fulgham.
795
796         Migrate tests away from platform-dependent types.
797
798         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
799         (TestWebKitAPI::TEST_F):
800
801 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
802
803         Correct File Path Handling in SecurityOrigin and FileSystem
804         https://bugs.webkit.org/show_bug.cgi?id=167894
805         <rdar://problem/30380080>
806
807         Reviewed by Alexey Proskuryakov.
808
809         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
810         and perform same-volume checks using filesystem-compatible paths.        
811         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
812         filesystem paths, and perform validation of same-volume checks.
813         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
814         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
815         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
816         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
817
818 2017-02-06  Jer Noble  <jer.noble@apple.com>
819
820         Playback stalls when a SourceBuffer append causes frame eviction
821         https://bugs.webkit.org/show_bug.cgi?id=167834
822
823         Reviewed by Eric Carlson.
824
825         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
826         for the WTF::MediaTime class.
827
828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
829         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
830         (TestWebKitAPI::TEST):
831         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
832         (WTF::operator<<):
833         (TestWebKitAPI::TestSample::create):
834         (TestWebKitAPI::TestSample::TestSample):
835         (TestWebKitAPI::TEST_F):
836
837 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
838
839         Change capitalization in platform name after r211735.
840
841         Unreviewed dashboard fix.
842
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
844         (WebKitBuildbot):
845
846 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
847
848         Move the Leaks bot to Sierra
849         https://bugs.webkit.org/show_bug.cgi?id=167886
850
851         Reviewed by Daniel Bates.
852
853         * BuildSlaveSupport/build.webkit.org-config/config.json:
854         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
855         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
856         (LeaksViewer._displayURLPrompt):
857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
858         (WebKitBuildbot):
859
860 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
861
862         Prevent app crash on launch during simctl install workaround
863         https://bugs.webkit.org/show_bug.cgi?id=167685
864
865         Reviewed by Daniel Bates.
866
867         * Scripts/webkitpy/port/simulator_process.py:
868         (SimulatorProcess.__init__): Pass environment to install.
869         * Scripts/webkitpy/xcode/simulator.py:
870         (Device.install_app): Accept environment, pass environment to launch.
871
872 2017-02-06  Alex Christensen  <achristensen@webkit.org>
873
874         Rebase API tests after r211638
875         https://bugs.webkit.org/show_bug.cgi?id=167779
876
877         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
878         (TestWebKitAPI::TEST_F):
879         URLs with non-special schemes and characters like % in the host now fail to parse,
880         more like their special counterparts and according to spec.
881
882 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
883
884         Unreviewed trivial fix after r211697.
885         https://bugs.webkit.org/show_bug.cgi?id=167863
886
887         * Scripts/run-javascriptcore-tests:
888         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
889
890 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
891
892         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
893         https://bugs.webkit.org/show_bug.cgi?id=167850
894
895         Reviewed by Tim Horton.
896
897         * DumpRenderTree/TestRunner.cpp:
898         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
899
900 2017-02-04  Andreas Kling  <akling@apple.com>
901
902         Plug some leaks in TestController and UIScriptContext.
903         <https://webkit.org/b/167839>
904
905         Reviewed by Alexey Proskuryakov.
906
907         Fix a couple of the leaks seen on the leaks bot.
908
909         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
910         (UIScriptContext::runUIScript):
911         * WebKitTestRunner/TestController.cpp:
912         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
913         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
914
915 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
916
917         WK1 mouse events are missing movementX and movementY for pointerlock.
918         https://bugs.webkit.org/show_bug.cgi?id=167775
919         rdar://problem/30343810
920
921         Reviewed by Alexey Proskuryakov.
922
923         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
924
925         * DumpRenderTree/mac/EventSendingController.mm:
926         (-[EventSendingController mouseMoveToX:Y:]):
927         * WebKitTestRunner/mac/EventSenderProxy.mm:
928         (WTR::EventSenderProxy::mouseMoveTo):
929
930 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
931
932         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
933         https://bugs.webkit.org/show_bug.cgi?id=167774
934
935         Reviewed by Tim Horton.
936
937         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
938         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
939         web process are async, so the callback fires after the web process gets the new state.
940
941         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
942         (WTR::UIScriptController::removeViewFromWindow):
943         (WTR::UIScriptController::addViewToWindow):
944         * DumpRenderTree/mac/DumpRenderTree.mm:
945         (createWebViewAndOffscreenWindow):
946         (resetWebViewToConsistentStateBeforeTesting):
947         * DumpRenderTree/mac/DumpRenderTreeMac.h:
948         * DumpRenderTree/mac/UIScriptControllerMac.mm:
949         (WTR::UIScriptController::removeViewFromWindow):
950         (WTR::UIScriptController::addViewToWindow):
951         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
952         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
953         (WTR::UIScriptController::removeViewFromWindow):
954         (WTR::UIScriptController::addViewToWindow):
955         * TestRunnerShared/UIScriptContext/UIScriptController.h:
956         * WebKitTestRunner/PlatformWebView.h:
957         * WebKitTestRunner/TestController.cpp:
958         (WTR::TestController::resetStateToConsistentValues):
959         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
960         (WTR::PlatformWebView::removeFromWindow):
961         (WTR::PlatformWebView::addToWindow):
962         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
963         (WTR::UIScriptController::removeViewFromWindow):
964         (WTR::UIScriptController::addViewToWindow):
965         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
966         (WTR::PlatformWebView::removeFromWindow):
967         (WTR::PlatformWebView::addToWindow):
968         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
969         (WTR::UIScriptController::removeViewFromWindow):
970         (WTR::UIScriptController::addViewToWindow):
971
972 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
973
974         Remove check for SkipSafariExecutableEntitlementChecks
975         https://bugs.webkit.org/show_bug.cgi?id=167762
976
977         Reviewed by Dan Bernstein.
978
979         Follow-up fix: don't break internal behavior.
980
981         * Scripts/webkitdirs.pm:
982         (safariPath):
983         (executableHasEntitlements): Deleted.
984         (safariPathFromSafariBundle): Deleted.
985         (installedSafariPath): Deleted.
986
987 2017-02-03  Daniel Bates  <dabates@apple.com>
988
989         [Mac][WK2] Add SPI to override the Content Security Policy of a page
990         https://bugs.webkit.org/show_bug.cgi?id=167810
991         <rdar://problem/30102568>
992
993         Reviewed by Anders Carlsson.
994
995         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
996
997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
998         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
999         (TEST):
1000         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1001         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1002         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1003         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1004
1005 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1006
1007         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1008         https://bugs.webkit.org/show_bug.cgi?id=167773
1009         <rdar://problem/30221102>
1010
1011         Reviewed by Ryosuke Niwa.
1012
1013         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1014         (TestWebKitAPI::TEST_F):
1015
1016 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1017
1018         Remove check for SkipSafariExecutableEntitlementChecks
1019         https://bugs.webkit.org/show_bug.cgi?id=167762
1020         rdar://problem/22480673
1021
1022         Reviewed by Dan Bernstein.
1023
1024         * Scripts/webkitdirs.pm:
1025         (safariPathFromSafariBundle):
1026         (skipSafariExecutableEntitlementChecks): Deleted.
1027
1028 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1029
1030         Undefined subroutine in svn-create-patch
1031         https://bugs.webkit.org/show_bug.cgi?id=167742
1032
1033         Unreviewed build-fix after r211543.
1034
1035         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1036
1037 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1038
1039         Unreviewed. Fix jhbuild dependencies build.
1040
1041         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1042         Patch updated.
1043
1044 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1045
1046         [EME][GStreamer] Fixed decryptor selection
1047         https://bugs.webkit.org/show_bug.cgi?id=167588
1048
1049         Reviewed by Žan Doberšek.
1050
1051         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1052
1053         * gtk/jhbuild.modules: Added patches to gstreamer and
1054         gst-plugins-good packages.
1055         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1056         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1057
1058 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1059
1060         Make run-benchmark script supports 'config' key in test plan.
1061         https://bugs.webkit.org/show_bug.cgi?id=167715
1062
1063         Reviewed by Ryosuke Niwa.
1064
1065         Add support for 'config' key in test paln.
1066         'config' key is a dictionary that specifies environment configurations while test is running.
1067         Specifies orientation to be portrait in MotionMark benchmark.
1068
1069         * Scripts/webkitpy/benchmark_runner/README.md:
1070         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1071         (BenchmarkRunner.__init__):
1072         (BenchmarkRunner._run_benchmark):
1073         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1074         (BrowserDriver.prepare_env):
1075         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1076         (LinuxBrowserDriver.prepare_env):
1077         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1078         (OSXBrowserDriver.prepare_env):
1079         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1080         (OSXSafariDriver.prepare_env):
1081         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1082
1083 2017-02-01  Daniel Bates  <dabates@apple.com>
1084
1085         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1086         https://bugs.webkit.org/show_bug.cgi?id=167169
1087
1088         Reviewed by David Kilzer.
1089
1090         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1091         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1092         header from the output of "svn diff" on a file that was copied or moved.
1093
1094         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1095         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1096         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1097         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1098         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1099         of a file with only a property change also does not contain any chunk range lines. Therefore
1100         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1101         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1102         we should directly test for the presence of a leading SVN diff header with an empty body and
1103         remove such lines from the diff.
1104
1105         * Scripts/VCSUtils.pm:
1106         (fixSVNPatchForAdditionWithHistory): Added.
1107         * Scripts/svn-create-patch:
1108         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1109         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1110         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1111
1112 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1113
1114         [Mac] Update CARingBuffer class
1115         https://bugs.webkit.org/show_bug.cgi?id=167656
1116
1117         Reviewed by Jer Noble.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1121         (TestWebKitAPI::CARingBufferTest::SetUp):
1122         (TestWebKitAPI::CARingBufferTest::setup):
1123         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1124         (TestWebKitAPI::CARingBufferTest::description):
1125         (TestWebKitAPI::CARingBufferTest::bufferList):
1126         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1127         (TestWebKitAPI::CARingBufferTest::capacity):
1128         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1129         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1130         (TestWebKitAPI::TEST_F):
1131         (TestWebKitAPI::MixingTest::run):
1132
1133 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1134
1135         [Mac] TestWebKitAPI includes system frameworks incorrectly
1136         https://bugs.webkit.org/show_bug.cgi?id=167703
1137         rdar://problem/30301498
1138
1139         Reviewed by Ryosuke Niwa.
1140
1141         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1142         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1143
1144         Also, reduced the number of subframework search paths, looks like we only need one now.
1145
1146         * TestWebKitAPI/Configurations/Base.xcconfig:
1147
1148 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1149
1150         Correct "filesHaveSameVolume" predicate
1151         https://bugs.webkit.org/show_bug.cgi?id=167696
1152         <rdar://problem/30298722>
1153
1154         Reviewed by David Kilzer.
1155
1156         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1157         percent-escaped path inputs.
1158
1159         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1160         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1161         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1162         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1163         (TestWebKitAPI::TEST_F):
1164
1165 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1166
1167         Unreviewed. Fix coding style in MiniBrowser
1168
1169         * MiniBrowser/gtk/BrowserWindow.c:
1170         (editingCommandCallback):
1171         (insertImageCommandCallback):
1172         (insertLinkCommandCallback):
1173
1174 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1175
1176         [GTK] Add an API to add a custom tab into the print dialog
1177         https://bugs.webkit.org/show_bug.cgi?id=151998
1178
1179         Reviewed by Carlos Garcia Campos.
1180
1181         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1182         that is testing a newly added API.
1183
1184         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1185         (testPrintCustomWidget):
1186         (beforeAll):
1187
1188 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1189
1190         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1191         https://bugs.webkit.org/show_bug.cgi?id=166529
1192
1193         Reviewed by Xabier Rodriguez-Calvar.
1194
1195         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1196         New patch version accepted in GStreamer upstream.
1197
1198 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1199
1200         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1201         https://bugs.webkit.org/show_bug.cgi?id=167498
1202
1203         Reviewed by Carlos Garcia Campos.
1204
1205         Depending on the distro version you can need either libxfont1-dev
1206         or libfont-dev to build with jhbuild.
1207
1208         * gtk/install-dependencies:
1209
1210 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1211
1212         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1213         https://bugs.webkit.org/show_bug.cgi?id=167594
1214
1215         Unreviewed test gardening.
1216
1217         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1218
1219         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1220         (TEST):
1221
1222 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1223
1224         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1225         https://bugs.webkit.org/show_bug.cgi?id=167676
1226
1227         Reviewed by Saam Barati.
1228
1229         * Scripts/run-javascriptcore-tests:
1230         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1231
1232 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1233
1234         Make Dump Render Tree not crash
1235         https://bugs.webkit.org/show_bug.cgi?id=167667
1236
1237         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1238         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1239         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1240         This does not fix any tests, it just fixes the crash.
1241         
1242         Reviewed by Simon Fraser.
1243
1244         * DumpRenderTree/TestRunner.cpp:
1245         (TestRunner::callUIScriptCallback):
1246
1247 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1248
1249         Workaround for simctl install failing to report install failure
1250         https://bugs.webkit.org/show_bug.cgi?id=167654
1251
1252         Reviewed by Daniel Bates.
1253
1254         simctl install will sometimes report success even though install has failed.
1255         To workaround this bug, we attempt an app launch after install to ensure
1256         install has succeeded.
1257
1258         * Scripts/webkitpy/xcode/simulator.py:
1259         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1260         (Device.launch_app): Correct comment.
1261
1262 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1263
1264         Unreviewed webkitpy fix after r211405.
1265
1266         * Scripts/webkitpy/xcode/simulator.py:
1267         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1268
1269 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1270
1271         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1272
1273         * gtk/manifest.txt.in:
1274
1275 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1276
1277         AX: enable search predication for iOS
1278         https://bugs.webkit.org/show_bug.cgi?id=167558
1279         <rdar://problem/30251367>
1280
1281         Reviewed by Joanmarie Diggs.
1282
1283         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1284         (AccessibilityUIElement::uiElementForSearchPredicate):
1285         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1286         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1287         (searchPredicateParameterizedAttributeForSearchCriteria):
1288         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1289         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1290         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1291         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1292         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1293         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1294         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1295         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1296         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1297         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1298         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1299
1300 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1301
1302         Workaround for simctl launch bug
1303         https://bugs.webkit.org/show_bug.cgi?id=167613
1304
1305         Reviewed by Daniel Bates.
1306
1307         simctl launch will sometimes fail because of a race condition when many
1308         simulators are being run simultaneously. These failures will always have
1309         an exit code of 1. This change attempts to launch an app multiple times
1310         before reporting a failure to workaround this bug.
1311
1312         * Scripts/webkitpy/xcode/simulator.py:
1313         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1314
1315 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1316
1317         Commit queue fails to look at real name aliases for the reviewer
1318         https://bugs.webkit.org/show_bug.cgi?id=167422
1319
1320         Reviewed by Joseph Pecoraro.
1321
1322         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1323         (test_has_valid_reviewer): Added tests.
1324
1325         * Scripts/webkitpy/common/config/committers.py:
1326         (CommitterList._name_to_contributor_map):
1327         Made _name_to_contributor_map include alias names.
1328
1329         * Scripts/webkitpy/common/config/committers_unittest.py:
1330         (CommittersTest.test_contributors_by_fuzzy_match):
1331         Removed subtests that are now obsolete, as these matches are strict. It is not
1332         obvious if distance based fuzzy matching for names is useful at all, but we can
1333         look into that some other time.
1334
1335 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1336
1337         QueueStatusServer should have an explicit timeout for _fetch_url
1338         https://bugs.webkit.org/show_bug.cgi?id=167467
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * Scripts/webkitpy/common/net/statusserver.py:
1343         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1344
1345 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1346
1347         Add support for Trac instances that host multiple projects.
1348         https://bugs.webkit.org/show_bug.cgi?id=167524
1349
1350         Reviewed by Alexey Proskuryakov.
1351
1352         When multiple projects are hosted on a single Trac instance, the current
1353         behavior will retrieve changesets from all tracked projects.
1354         This patch teaches Trac.js to get project-specific changesets from Trac.
1355         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1356         when querying the Trac timeline.
1357
1358         To tell Trac to be aware of multi-project instances we leverage the 
1359         `options` parameter when creating a new instance: 
1360
1361             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1362
1363         If this option is not provided, the original behaviour will prevail.
1364         Additionally, add corresponding tests.
1365
1366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1367         (Trac): Reason about new optional parameter 'projectIdentifier'.
1368         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1369         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1370         replace default parameter `changeset=on` with `repo-projectname=on`.
1371         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1373         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1375         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1376         Add the following tests:
1377             test("revisionURL")
1378             test("revisionURL with Trac Identifier")
1379             test("_xmlTimelineURL")
1380             test("_xmlTimelineURL with Trac Identifier")
1381         (this.view._latestProductiveIteration): Fix missing ';'.
1382
1383 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1384
1385         Correct spacing regression on inter-element complex path shaping on some fonts
1386         https://bugs.webkit.org/show_bug.cgi?id=166013
1387
1388         Reviewed by Simon Fraser.
1389
1390         Unskip existing tests and make some new tests:
1391         - Testing complex text with no origins
1392         - Testing initial expansions
1393         - Testing the sign of vertical advances
1394
1395         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1396         (TestWebKitAPI::TEST_F):
1397
1398 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1399
1400         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1401         https://bugs.webkit.org/show_bug.cgi?id=167596
1402
1403         Reviewed by Daniel Bates.
1404
1405         We avoid needing a thin directory by invoking the zip program with
1406         the list of directories from the build directory to be zipped,
1407         and by using the zip feature to exclude files matching a pattern.
1408
1409         * BuildSlaveSupport/built-product-archive:
1410         (copyBuildFiles):
1411         (createZipFromList):
1412         (archiveBuiltProduct):
1413
1414 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1415
1416         Use simctl instead of LayoutTestRelay
1417         https://bugs.webkit.org/show_bug.cgi?id=165927
1418
1419         Reviewed by Daniel Bates.
1420
1421         Part 1
1422
1423         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1424         simulators through simctl (iOS 10 and later), use this functionality instead.
1425
1426         * Scripts/webkitpy/port/base.py:
1427         (Port.__init__): Added _test_runner_process_constructor.
1428         * Scripts/webkitpy/port/darwin.py:
1429         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1430         * Scripts/webkitpy/port/driver.py:
1431         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1432         (IOSSimulatorDriver): Deleted.
1433         * Scripts/webkitpy/port/driver_unittest.py:
1434         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1435         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1436         (DriverTest.test_start_actually_starts): Ditto.
1437         * Scripts/webkitpy/port/ios.py:
1438         (IOSSimulatorPort): Remove relay_name.
1439         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1440         (IOSSimulatorPort._create_simulators): Formatting change.
1441         (IOSSimulatorPort.relay_path): Deleted.
1442         (IOSSimulatorPort._check_relay): Deleted.
1443         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1444         (IOSSimulatorPort._build_relay): Deleted.
1445         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1446         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1447         * Scripts/webkitpy/port/ios_unittest.py:
1448         (iosTest.test_32bit): Update test.
1449         (iosTest.test_64bit): Update test.
1450         * Scripts/webkitpy/port/server_process.py:
1451         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1452         (ServerProcess._set_file_nonblocking): Added to share common code.
1453         * Scripts/webkitpy/port/server_process_mock.py:
1454         (MockServerProcess.__init__): Added argument worker_number.
1455         * Scripts/webkitpy/port/simulator_process.py: Added.
1456         (SimulatorProcess): Added.
1457         (SimulatorProcess.Popen): Added.
1458         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1459         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1460         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1461         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1462         (SimulatorProcess._reset): Added. Unlink fifos.
1463         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1464         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1465         * Scripts/webkitpy/xcode/simulator.py:
1466         (Device.__init__): Accept host to run install/launch/terminate.
1467         (Device.install_app): Install app to target Device.
1468         (Device.launch_app): Launch app on target Device.
1469         (Device.terminate_app): Shutdown app on target Device.
1470         (Simulator._parse_devices): Pass host to Device.
1471
1472 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1473
1474         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1475         https://bugs.webkit.org/show_bug.cgi?id=167411
1476
1477         Reviewed by Michael Catanzaro.
1478
1479         Disable the ARM iwMMXt fast path for pixman, because it triggers
1480         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1481
1482         * gtk/jhbuild.modules:
1483
1484 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1485
1486         [GTK] Add API to handle the accelerated compositing policy
1487         https://bugs.webkit.org/show_bug.cgi?id=167509
1488
1489         Reviewed by Michael Catanzaro.
1490
1491         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1492         as a special case. Also add test cases to the get/set API.
1493
1494         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1495         (hardwareAccelerationPolicyToString):
1496         (stringToHardwareAccelerationPolicy):
1497         (cellRendererChanged):
1498         (browserSettingsDialogConstructed):
1499         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1500         (testWebKitSettings):
1501
1502 2017-01-29  Andy Estes  <aestes@apple.com>
1503
1504         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1505         https://bugs.webkit.org/show_bug.cgi?id=167563
1506         <rdar://problem/30253207>
1507
1508         Reviewed by Andreas Kling.
1509
1510         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1511         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1512         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1513         (runTest):
1514         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1515         (TEST):
1516
1517 2017-01-29  Dan Bernstein  <mitz@apple.com>
1518
1519         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1520         https://bugs.webkit.org/show_bug.cgi?id=167565
1521
1522         Reviewed by Sam Weinig.
1523
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1525         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1526         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1527         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1528         (TEST):
1529         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1530         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1531         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1532         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1533
1534 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1535
1536         Add Link Preload as an off-by-default experimental feature menu item.
1537         https://bugs.webkit.org/show_bug.cgi?id=167201
1538
1539         Reviewed by Ryosuke Niwa.
1540
1541         * DumpRenderTree/mac/DumpRenderTree.mm:
1542         (resetWebPreferencesToConsistentValues):
1543         * DumpRenderTree/win/DumpRenderTree.cpp:
1544         (resetWebPreferencesToConsistentValues):
1545
1546 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1547
1548         Add User Timing Experimental Feature
1549         https://bugs.webkit.org/show_bug.cgi?id=167542
1550         <rdar://problem/22746307>
1551
1552         Reviewed by Ryosuke Niwa.
1553
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (enableExperimentalFeatures):
1556         (resetWebPreferencesToConsistentValues):
1557         * DumpRenderTree/win/DumpRenderTree.cpp:
1558         (enableExperimentalFeatures):
1559
1560 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1561
1562         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1563         https://bugs.webkit.org/show_bug.cgi?id=167519
1564
1565         Reviewed by Ryosuke Niwa.
1566
1567         * QueueStatusServer/templates/statusbubble.html:
1568         To measure the bubbleContainer's width, it must not be wrapping based
1569         on its parent container. So when measuring the width temporarily set
1570         the parent to a very large width so as to not artificially wrap us.
1571         Restore the parent's width after measuring.
1572
1573 2017-01-27  Andy Estes  <aestes@apple.com>
1574
1575         [iOS] Add a test for _WKNSFileManagerExtras
1576         https://bugs.webkit.org/show_bug.cgi?id=167478
1577
1578         Reviewed by Andreas Kling.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1582         (expectAttributes):
1583         (TEST):
1584
1585 2017-01-27  Keith Miller  <keith_miller@apple.com>
1586
1587         run-benchmarks should make sure it passes the test url to the right application
1588         https://bugs.webkit.org/show_bug.cgi?id=167533
1589
1590         Reviewed by Joseph Pecoraro.
1591
1592         This fixes an issue when trying to run-benchmark script with the
1593         system default browser set to STP. Previously, it would run
1594         the test in STP rather than the provided build. Now, it should run
1595         in the provided build.
1596
1597         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1598         (OSXSafariDriver.launch_url):
1599
1600 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1601
1602         [Cocoa] Prepare ComplexTextController for unit testing
1603         https://bugs.webkit.org/show_bug.cgi?id=167493
1604
1605         Reviewed by Simon Fraser.
1606
1607         Addressing post-review comments from Simon Fraser.
1608
1609         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1610         (TestWebKitAPI::TEST_F):
1611
1612 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1613
1614         [Cocoa] Prepare ComplexTextController for unit testing
1615         https://bugs.webkit.org/show_bug.cgi?id=167493
1616
1617         Reviewed by Dean Jackson.
1618
1619         Create four unit tests.
1620
1621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1622         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1623         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1624         (TestWebKitAPI::TEST_F):
1625
1626 2017-01-26  Chris Dumez  <cdumez@apple.com>
1627
1628         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1629         https://bugs.webkit.org/show_bug.cgi?id=167421
1630         <rdar://problem/30188490>
1631
1632         Reviewed by Darin Adler.
1633
1634         Add a new setting allowing layout tests to enable PageCache in a window
1635         that has an opener, for convenience.
1636
1637         * DumpRenderTree/mac/DumpRenderTree.mm:
1638         (resetWebPreferencesToConsistentValues):
1639         * DumpRenderTree/win/DumpRenderTree.cpp:
1640         (resetWebPreferencesToConsistentValues):
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::resetPreferencesToConsistentValues):
1643
1644 2017-01-26  Keith Miller  <keith_miller@apple.com>
1645
1646         classInfo should take a VM so it is not materialized from the object on each call
1647         https://bugs.webkit.org/show_bug.cgi?id=167424
1648
1649         Rubber Stamped by Michael Saboff.
1650
1651         Previously, classInfo() would get the VM from the target's
1652         MarkedBlock.  Most callers already have a VM on hand, so it is
1653         wasteful to compute the VM from the marked block every time. This
1654         patch refactors some of the most common callers of classInfo(),
1655         jsDynamicCast and inherits to take a VM as well.
1656
1657         * DumpRenderTree/TestRunner.cpp:
1658         (setAudioResultCallback):
1659
1660 2017-01-26  Jer Noble  <jer.noble@apple.com>
1661
1662         Autoplay muted videos stop playback of any streaming app in the background
1663         https://bugs.webkit.org/show_bug.cgi?id=163993
1664         <rdar://problem/29020431>
1665
1666         Reviewed by Eric Carlson.
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1669         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1670         (TestWebKitAPI::TEST):
1671         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1672
1673 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1674
1675         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1676         https://bugs.webkit.org/show_bug.cgi?id=167466
1677
1678         Unreviewed test gardening.
1679
1680         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1681         (TEST):
1682
1683 2017-01-26  Matt Rajca  <mrajca@apple.com>
1684
1685         Notify clients when the user plays media otherwise prevented from autoplaying
1686         https://bugs.webkit.org/show_bug.cgi?id=167390
1687
1688         Reviewed by Alex Christensen.
1689
1690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1691         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1692         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1693         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1694         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1695         (TEST):
1696         * TestWebKitAPI/cocoa/TestWKWebView.h:
1697         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1698         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1699         (-[TestWKWebView waitForLoad]):
1700         (-[TestWKWebView mouseUpAtPoint:]):
1701         * WebKitTestRunner/TestController.cpp:
1702         (WTR::TestController::createOtherPage):
1703         (WTR::TestController::createWebViewWithOptions):
1704
1705 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1706
1707         Crash when setting custom scale factor.
1708         https://bugs.webkit.org/show_bug.cgi?id=167369
1709
1710         Reviewed by Sam Weinig.
1711
1712         Added API test.
1713
1714         * TestWebKitAPI/PlatformWin.cmake:
1715         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1716         (TestWebKitAPI::WebKitCreateInstance):
1717         (TestWebKitAPI::ScaleWebView::SetUp):
1718         (TestWebKitAPI::ScaleWebView::TearDown):
1719         (TestWebKitAPI::TEST_F):
1720
1721 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1722
1723         run-benchmark nests MotionMark results by the suite name twice
1724         https://bugs.webkit.org/show_bug.cgi?id=164948
1725
1726         Reviewed by Said Abou-Hallawa.
1727
1728         Use a single level MotionMark now that this is the name of the benchmark,
1729         and we no longer have tests that aren't part of the MotionMark suite.
1730
1731         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1732
1733 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1734
1735         Unreviewed, rolling out r211193.
1736
1737         This change broke internal builds.
1738
1739         Reverted changeset:
1740
1741         "Notify clients when the user plays media otherwise prevented
1742         from autoplaying"
1743         https://bugs.webkit.org/show_bug.cgi?id=167390
1744         http://trac.webkit.org/changeset/211193
1745
1746 2017-01-25  Matt Rajca  <mrajca@apple.com>
1747
1748         Notify clients when the user plays media otherwise prevented from autoplaying
1749         https://bugs.webkit.org/show_bug.cgi?id=167390
1750
1751         Reviewed by Alex Christensen.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1755         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1756         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1757         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1758         (TEST):
1759         * TestWebKitAPI/cocoa/TestWKWebView.h:
1760         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1761         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1762         (-[TestWKWebView waitForLoad]):
1763         (-[TestWKWebView mouseUpAtPoint:]):
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::TestController::createOtherPage):
1766         (WTR::TestController::createWebViewWithOptions):
1767
1768 2017-01-25  Matt Rajca  <mrajca@apple.com>
1769
1770         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1771         https://bugs.webkit.org/show_bug.cgi?id=167385
1772
1773         Reviewed by Alex Christensen.
1774
1775         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1776         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1778         (TEST): Allow inline (rather than full screen) media playback on iOS.
1779
1780 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1783         https://bugs.webkit.org/show_bug.cgi?id=167414
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         Add a test case to check ephemeral web views don't write favicons to the database.
1788
1789         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1790         (ephemeralViewLoadChanged):
1791         (testPrivateBrowsing):
1792         (testFaviconDatabase):
1793
1794 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1795
1796         [GTK] Add a private browsing mode to MiniBrowser
1797         https://bugs.webkit.org/show_bug.cgi?id=167413
1798
1799         Reviewed by Michael Catanzaro.
1800
1801         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1802         private windows, even on non-private instances.
1803
1804         * MiniBrowser/gtk/BrowserWindow.c:
1805         (webViewTitleChanged): Add [Private] to title window for private windows.
1806         (webViewCreate): Pass web context to browser_window_new.
1807         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1808         (browserWindowFinalize): Disconnect web context signal handlers.
1809         (browser_window_init): Add shortcut for opening private window.
1810         (browser_window_new): It now receives the context and connect to download-started here.
1811         (browser_window_get_web_context): Return the context.
1812         * MiniBrowser/gtk/BrowserWindow.h:
1813         * MiniBrowser/gtk/main.c:
1814         (createBrowserTab): Create the web view for the window web context.
1815         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1816         (aboutDataHandleRequest): Ditto.
1817         (aboutURISchemeRequestCallback): Ditto.
1818         (main): Create ephemeral web context if private command line option is used.
1819
1820 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1821
1822         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1823         https://bugs.webkit.org/show_bug.cgi?id=167409
1824
1825         Reviewed by Antti Koivisto.
1826
1827         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1828         as well as tests for the newly added matchingElementInFlatTree.
1829
1830         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1831         (TestWebKitAPI::runJavaScriptAlert):
1832         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1833         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1834         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1835
1836 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1837
1838         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1839         https://bugs.webkit.org/show_bug.cgi?id=167370
1840
1841         Reviewed by Michael Catanzaro.
1842
1843         Add several test cases of ephemeral web views.
1844
1845         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1846         (testWebViewAuthenticationStorage):
1847         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1848         (ephemeralViewloadChanged):
1849         (testCookieManagerEphemeral):
1850         (beforeAll):
1851         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1852         (testWebKitSettings):
1853         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1854         (testWebContextEphemeral):
1855         (ephemeralViewloadChanged):
1856         (testWebContextProxySettings):
1857         (beforeAll):
1858         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1859         (ephemeralViewloadChanged):
1860         (testWebViewEphemeral):
1861         (beforeAll):
1862         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1863         (ephemeralViewloadChanged):
1864         (testWebsiteDataEphemeral):
1865         (beforeAll):
1866
1867 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1868
1869         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1870         https://bugs.webkit.org/show_bug.cgi?id=167402
1871
1872         Reviewed by Ryosuke Niwa.
1873
1874         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1875         (TestWebKitAPI::TEST):
1876
1877 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1878
1879         Add simple line layout toggle to MiniBrowser
1880         https://bugs.webkit.org/show_bug.cgi?id=167405
1881
1882         Reviewed by Andreas Kling.
1883
1884         * MiniBrowser/mac/SettingsController.h:
1885         * MiniBrowser/mac/SettingsController.m:
1886         (-[SettingsController _populateMenu]):
1887         (-[SettingsController validateMenuItem:]):
1888         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1889         (-[SettingsController simpleLineLayoutEnabled]):
1890         * MiniBrowser/mac/WK1BrowserWindowController.m:
1891         (-[WK1BrowserWindowController didChangeSettings]):
1892         * MiniBrowser/mac/WK2BrowserWindowController.m:
1893         (-[WK2BrowserWindowController didChangeSettings]):
1894
1895 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1896
1897         WKR does not include my nick when commit-queue lands my patch
1898         https://bugs.webkit.org/show_bug.cgi?id=167388
1899
1900         Reviewed by Ryosuke Niwa.
1901
1902         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1903         (NewCommitBot._summarize_commit_log):
1904         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1905         Perform nickname insertion before grabbing "Patch by" details.
1906         This way we can include the nickname with the full name.
1907
1908 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1909
1910         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1911         https://bugs.webkit.org/show_bug.cgi?id=167394
1912
1913         Reviewed by Ryosuke Niwa.
1914
1915         * Scripts/webkitperl/FeatureList.pm:
1916         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1917
1918 2017-01-24  Youenn Fablet  <youenn@apple.com>
1919
1920         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1921         https://bugs.webkit.org/show_bug.cgi?id=167353
1922
1923         Reviewed by Alex Christensen.
1924
1925         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1926         (CMakeGenerator.initialize_targets):
1927
1928 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1929
1930         WKR should not confuse Miguel Gomez with Andres Gomez
1931         https://bugs.webkit.org/show_bug.cgi?id=167389
1932
1933         Reviewed by Lucas Forschler.
1934
1935         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1936         "mAndres Gomez". Fix this.
1937
1938         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1939         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1940         space on each side of the email address, so expect both spaces to be there before
1941         considering the email for replacement.
1942         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1943
1944 2017-01-24  Matt Rajca  <mrajca@apple.com>
1945
1946         Pass down website autoplay policies to media elements
1947         https://bugs.webkit.org/show_bug.cgi?id=167355
1948
1949         Reviewed by Alex Christensen.
1950
1951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1953         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1954         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1955         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1956         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1957         (TEST):
1958
1959 2017-01-24  Nan Wang  <n_wang@apple.com>
1960
1961         AX: Speak Selection does not work in an iframe
1962         https://bugs.webkit.org/show_bug.cgi?id=166794
1963         <rdar://problem/29913013>
1964
1965         Reviewed by Chris Fleizach.
1966
1967         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1968         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1969         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1970         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1971         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1972         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1973         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1974         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1975         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1976         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1977         (-[TestRunnerWKWebView dealloc]):
1978         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1979         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1980         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1981         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1982         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1983
1984 2017-01-24  Daniel Bates  <dabates@apple.com>
1985
1986         StringView.split() should use an iterator design pattern instead of allocating a Vector
1987         https://bugs.webkit.org/show_bug.cgi?id=163225
1988
1989         Reviewed by Darin Adler.
1990
1991         Add unit tests for StringView.split().
1992
1993         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1994         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1995         used in the StringView.split() unit tests.
1996         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1997         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1998         object to a Vector of String objects.
1999         (TestWebKitAPI::TEST): Added the following tests:
2000             - WTF.StringViewSplitEmptyAndNullStrings
2001             - WTF.StringViewSplitBasic
2002             - WTF.StringViewSplitWithConsecutiveSeparators
2003
2004 2017-01-23  Anders Carlsson  <andersca@apple.com>
2005
2006         The Score Esports crashes on launch
2007         https://bugs.webkit.org/show_bug.cgi?id=167338
2008         rdar://problem/29948645
2009
2010         Reviewed by Dan Bernstein.
2011
2012         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2013         (TestWebKitAPI::TEST):
2014         Add a test.
2015
2016 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2019         https://bugs.webkit.org/show_bug.cgi?id=146589
2020
2021         Reviewed by Michael Catanzaro.
2022
2023         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2024         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2025
2026         * MiniBrowser/gtk/BrowserWindow.c:
2027         (webViewDecidePolicy):
2028         (newTabCallback):
2029         * MiniBrowser/gtk/main.c:
2030         (createBrowserTab):
2031         (aboutDataRequestFree):
2032         (aboutDataRequestNew):
2033         (aboutDataRequestForView):
2034         (websiteDataRemovedCallback):
2035         (websiteDataClearedCallback):
2036         (aboutDataScriptMessageReceivedCallback):
2037         (domainListFree):
2038         (aboutDataFillTable):
2039         (gotWebsiteDataCallback):
2040         (aboutDataHandleRequest):
2041         (aboutURISchemeRequestCallback):
2042         (main):
2043         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2044         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2045         (serverCallback):
2046         (beforeAll):
2047         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2048         (serverCallback):
2049         (WebsiteDataTest::WebsiteDataTest):
2050         (WebsiteDataTest::~WebsiteDataTest):
2051         (WebsiteDataTest::fetch):
2052         (WebsiteDataTest::remove):
2053         (WebsiteDataTest::clear):
2054         (testWebsiteDataConfiguration):
2055         (testWebsiteDataCache):
2056         (testWebsiteDataStorage):
2057         (testWebsiteDataDatabases):
2058         (testWebsiteDataAppcache):
2059         (beforeAll):
2060         (afterAll):
2061
2062 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2063
2064         Unreviewed, rolling out r211062.
2065         https://bugs.webkit.org/show_bug.cgi?id=167354
2066
2067         broke API tests (Requested by alexchristensen on #webkit).
2068
2069         Reverted changeset:
2070
2071         "Pass down website autoplay policies to media elements"
2072         https://bugs.webkit.org/show_bug.cgi?id=167132
2073         http://trac.webkit.org/changeset/211062
2074
2075 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2076
2077         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2078         https://bugs.webkit.org/show_bug.cgi?id=167330
2079
2080         Reviewed by Tim Horton.
2081
2082         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2083         (TestWebKitAPI::TEST_F):
2084
2085 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2086
2087         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2088         https://bugs.webkit.org/show_bug.cgi?id=167317
2089
2090         Reviewed by Sam Weinig.
2091
2092         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2093         (TestWebKitAPI::TEST_F):
2094
2095 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2096
2097         svn-create-patch should emit properties when files are moved or copied
2098         https://bugs.webkit.org/show_bug.cgi?id=167264
2099
2100         Reviewed by Daniel Bates.
2101
2102         * Scripts/svn-create-patch:
2103         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2104
2105 2017-01-23  Youenn Fablet  <youenn@apple.com>
2106
2107         [WebRTC] Filter libwebrtc link flags
2108         https://bugs.webkit.org/show_bug.cgi?id=167287
2109
2110         Reviewed by Alex Christensen.
2111
2112         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2113         (CMakeGenerator._compute_link_flags):
2114         (CMakeGenerator._compute_link_flags.keep_flag):
2115         (CMakeGenerator._generate_compile_target_options):
2116
2117 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2118
2119         [WebRTC] Make VP8 optional in libwebrtc
2120         https://bugs.webkit.org/show_bug.cgi?id=167257
2121
2122         Reviewed by Darin Adler.
2123
2124         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2125         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2126
2127 2017-01-23  Jer Noble  <jer.noble@apple.com>
2128
2129         Video details does not apear and missing scrubber in Control Center
2130         https://bugs.webkit.org/show_bug.cgi?id=167233
2131
2132         Reviewed by Alex Christensen.
2133
2134         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2135         NowPlayingControlTests for iOS.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2139         (-[NowPlayingTestWebView setWindowVisible:]):
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2142         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2143         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2144         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2145         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2146         (SOFT_LINK_CLASS):
2147         (-[TestMessageHandler addMessage:withHandler:]):
2148         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2149         (__simulated_forceClickAssociatedEventsMask):
2150         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2151         (-[TestWKWebViewHostWindow isKeyWindow]):
2152         (-[TestWKWebViewHostWindow makeKeyWindow]):
2153         (-[TestWKWebViewHostWindow resignKeyWindow]):
2154         (-[TestWKWebView initWithFrame:]):
2155         (-[TestWKWebView initWithFrame:configuration:]):
2156         (-[TestWKWebView _setUpTestWindow:]):
2157         (-[TestWKWebView performAfterReceivingMessage:action:]):
2158         (-[TestWKWebView loadTestPageNamed:]):
2159         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2160         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2161         (-[TestWKWebView waitForMessage:]):
2162         (-[TestWKWebView performAfterLoading:]):
2163         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2164         (-[TestWKWebView typeCharacter:]):
2165
2166 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2167
2168         Unreviewed. Bring back gtk-doc error messages after r209981.
2169
2170         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2171         impossible to know what's wrong.
2172
2173         * gtk/gtkdoc.py:
2174         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2175
2176 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2177
2178         [WebRTC] Update build system to make G711 optional in libwebrtc
2179         https://bugs.webkit.org/show_bug.cgi?id=167256
2180
2181         Reviewed by Alex Christensen.
2182
2183         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2184         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2185
2186 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2187
2188         Cleanup RuntimeEnabledFeatures
2189         https://bugs.webkit.org/show_bug.cgi?id=167228
2190
2191         Reviewed by Simon Fraser.
2192
2193         * DumpRenderTree/mac/DumpRenderTree.mm:
2194         (enableExperimentalFeatures):
2195         (resetWebPreferencesToConsistentValues):
2196         (setWebPreferencesForTestOptions):
2197         (resetWebViewToConsistentStateBeforeTesting):
2198         * DumpRenderTree/win/DumpRenderTree.cpp:
2199         (enableExperimentalFeatures):
2200         (resetWebPreferencesToConsistentValues):
2201         More closely match WebKitTestRunner initialization of preferences
2202         for experimental features.
2203
2204 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2205
2206         Build Fix for Windows DumpRenderTree after r210976
2207         https://bugs.webkit.org/show_bug.cgi?id=167115
2208
2209         * DumpRenderTree/win/DumpRenderTree.cpp:
2210         (resetWebPreferencesToConsistentValues):
2211
2212 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2213
2214         Remove outdated ENABLE(CSP_NEXT) build flag
2215         https://bugs.webkit.org/show_bug.cgi?id=167252
2216
2217         Reviewed by Brent Fulgham.
2218
2219         * Scripts/webkitperl/FeatureList.pm:
2220         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2221
2222 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2223
2224         Build Fix for Windows DumpRenderTree after r210976
2225
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (resetWebPreferencesToConsistentValues):
2228
2229 2017-01-20  Antoine Quint  <graouts@apple.com>
2230
2231         Web Animations should be off by default and enabled as an experimental feature
2232         https://bugs.webkit.org/show_bug.cgi?id=167115
2233         <rdar://problem/30048963>
2234
2235         Reviewed by Joseph Pecoraro.
2236
2237         Turn Web Animations on in DRT.
2238
2239         * DumpRenderTree/mac/DumpRenderTree.mm:
2240         (resetWebPreferencesToConsistentValues):
2241         * DumpRenderTree/win/DumpRenderTree.cpp:
2242         (resetWebPreferencesToConsistentValues):
2243
2244 2017-01-20  Youenn Fablet  <youenn@apple.com>
2245
2246         [WebRTC] Add libwebrtc build infrastructure
2247         https://bugs.webkit.org/show_bug.cgi?id=167207
2248
2249         Reviewed by Alex Christensen.
2250
2251         Adding a script doing the libwebrtc project json to CMake file conversion.
2252
2253         * Scripts/generate-libwebrtc-cmake: Added.
2254         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2255         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2256
2257 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2258
2259         Mini Browser: Show tooltip for Experimental Features
2260         https://bugs.webkit.org/show_bug.cgi?id=167225
2261
2262         Reviewed by Alex Christensen.
2263
2264         * MiniBrowser/mac/SettingsController.m:
2265         (-[SettingsController _populateMenu]):
2266         Include the full details string as a tooltip.
2267
2268 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2269
2270         [Win] Test output results should not be written twice.
2271         https://bugs.webkit.org/show_bug.cgi?id=167197
2272
2273         Reviewed by Brent Fulgham.
2274
2275         Prevent test output from being written twice by returning early from
2276         the dump() function, if it already has been called.
2277         This patch also adds a missing newline to a test output line. 
2278         
2279         * DumpRenderTree/win/DumpRenderTree.cpp:
2280         (dump):
2281
2282 2017-01-20  Antoine Quint  <graouts@apple.com>
2283
2284         [Modern Media Controls] Turn modern media controls on by default
2285         https://bugs.webkit.org/show_bug.cgi?id=165668
2286
2287         Reviewed by Dean Jackson.
2288
2289         Enabled modern media controls by default in test runners.
2290
2291         * DumpRenderTree/TestOptions.h:
2292         * WebKitTestRunner/TestOptions.h:
2293
2294 2017-01-19  Chris Dumez  <cdumez@apple.com>
2295
2296         iterable<> should be enabled on WK1
2297         https://bugs.webkit.org/show_bug.cgi?id=167221
2298         <rdar://problem/30108531>
2299
2300         Reviewed by Youenn Fablet.
2301
2302         * DumpRenderTree/mac/DumpRenderTree.mm:
2303         (resetWebPreferencesToConsistentValues):
2304         * DumpRenderTree/win/DumpRenderTree.cpp:
2305         (resetWebPreferencesToConsistentValues):
2306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2307         (WTR::InjectedBundle::beginTesting):
2308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2309         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2311
2312 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2313
2314         Ensure status server logs go to log file
2315         https://bugs.webkit.org/show_bug.cgi?id=167210
2316
2317         Reviewed by Alexey Proskuryakov.
2318
2319         * Scripts/webkitpy/common/net/statusserver.py:
2320         (StatusServer.next_work_item): Change log level from debug to info in
2321         order to facilitate deubgging issues.
2322         (StatusServer.update_work_items): Same.
2323
2324 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2325
2326         Additional selection tests and interpolation fix
2327         https://bugs.webkit.org/show_bug.cgi?id=167171
2328
2329         Reviewed by Simon Fraser.
2330
2331         We weren't adding the final event when interpolating event streams.
2332
2333         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2334         (-[HIDEventGenerator interpolatedEvents:]):
2335
2336 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2337
2338         [Cocoa] Variation fonts are erroneously disabled on iOS
2339         https://bugs.webkit.org/show_bug.cgi?id=167172
2340
2341         Reviewed by Simon Fraser.
2342
2343         OpenSource builders don't seem to understand sdk=embedded*.
2344
2345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2346
2347 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2348
2349         Unreviewed. Fix GTK+ unit tests failing since r210531.
2350
2351         Avoid using paths to files that don't actually exist.
2352
2353         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2354         (testWebKitConsoleMessageNetworkError):
2355         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2356         (testContextMenuDefaultMenu):
2357         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2358         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2359         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2360
2361 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         [GTK] Provide API to set proxy settings
2364         https://bugs.webkit.org/show_bug.cgi?id=128674
2365
2366         Reviewed by Michael Catanzaro.
2367
2368         Add tests for new proxy settings API.
2369
2370         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2371         (serverCallback):
2372         (ProxyTest::ProxyTest):
2373         (ProxyTest::~ProxyTest):
2374         (ProxyTest::loadURIAndGetMainResourceData):
2375         (ProxyTest::proxyServerPortAsString):
2376         (testWebContextProxySettings):
2377         (beforeAll):
2378
2379 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2380
2381         Add back my old email address so old commits will still match it.
2382
2383         * Scripts/webkitpy/common/config/contributors.json:
2384
2385 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2386
2387         Remove my old email address from contributors.json and watchlist.
2388
2389         * Scripts/validate-committer-lists:
2390         (CommitterListFromGit): Change the mapping to the correct email.
2391         * Scripts/webkitpy/common/config/contributors.json:
2392         * Scripts/webkitpy/common/config/watchlist:
2393
2394 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2395
2396         Unreviewed, rolling out r210848.
2397
2398         This change introduced media-related LayoutTest failures and
2399         crashes on macOS.
2400
2401         Reverted changeset:
2402
2403         "[Modern Media Controls] Turn modern media controls on by
2404         default"
2405         https://bugs.webkit.org/show_bug.cgi?id=165668
2406         http://trac.webkit.org/changeset/210848
2407
2408 2017-01-18  Andreas Kling  <akling@apple.com>
2409
2410         Document::securityOrigin() should return a reference.
2411         <https://webkit.org/b/167124>
2412
2413         Reviewed by Sam Weinig.
2414
2415         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2416         (TestWebKitAPI::TEST_F):
2417
2418 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2419
2420         [Win] Clipboard tests are flaky.
2421         https://bugs.webkit.org/show_bug.cgi?id=167088
2422
2423         Reviewed by Brent Fulgham.
2424
2425         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2426         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2427
2428         * DumpRenderTree/win/DumpRenderTree.cpp:
2429         (main):
2430
2431 2017-01-18  Antoine Quint  <graouts@apple.com>
2432
2433         [Modern Media Controls] Turn modern media controls on by default
2434         https://bugs.webkit.org/show_bug.cgi?id=165668
2435
2436         Reviewed by Dean Jackson.
2437
2438         Enabled modern media controls by default in test runners. 
2439
2440         * DumpRenderTree/TestOptions.h:
2441         * WebKitTestRunner/TestOptions.h:
2442
2443 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2444
2445         Unreviewed, rolling out r210834
2446         https://bugs.webkit.org/show_bug.cgi?id=165668
2447
2448         It introduced dozens of test timeouts.
2449
2450         Reverted changeset:
2451         "[Modern Media Controls] Turn modern media controls on by default"
2452         https://bugs.webkit.org/show_bug.cgi?id=165668
2453         http://trac.webkit.org/changeset/210834
2454
2455 2017-01-17  Antoine Quint  <graouts@apple.com>
2456
2457         [Modern Media Controls] Turn modern media controls on by default
2458         https://bugs.webkit.org/show_bug.cgi?id=165668
2459
2460         Reviewed by Dean Jackson.
2461
2462         Enabled modern media controls by default in test runners. 
2463
2464         * DumpRenderTree/TestOptions.h:
2465         * WebKitTestRunner/TestOptions.h:
2466
2467 2017-01-17  Chris Dumez  <cdumez@apple.com>
2468
2469         Document title changed twice when setting document.title
2470         https://bugs.webkit.org/show_bug.cgi?id=167065
2471
2472         Reviewed by Darin Adler.
2473
2474         Add WebKit2GTK API test that was written by Michael Catanzaro.
2475
2476         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2477         (testWebViewTitleChange):
2478         (beforeAll):
2479
2480 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2481
2482         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2483         https://bugs.webkit.org/show_bug.cgi?id=116551
2484         <rdar://problem/13949830>
2485
2486         Reviewed by Alex Christensen.
2487
2488         * Scripts/webkitperl/FeatureList.pm:
2489         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2490         that is part of the existing WEB_TIMING feature.
2491
2492         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2493
2494 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2495
2496         'webkit-patch post' no longer works with moved/copied files
2497         https://bugs.webkit.org/show_bug.cgi?id=166914
2498         <rdar://problem/29979707>
2499
2500         Reviewed by Daniel Bates.
2501
2502         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2503         file outputs only the "Index:" line with an empty body.  This workaround
2504         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2505         public email list tracking this bug is below.
2506         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2507         
2508
2509         * Scripts/svn-create-patch:
2510         (generateDiff): Ignore an "Index:" line with an empty body.
2511
2512 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2513
2514         Remove the REQUEST_ANIMATION_FRAME flag
2515         https://bugs.webkit.org/show_bug.cgi?id=156980
2516         <rdar://problem/25906849>
2517
2518         Reviewed by Simon Fraser.
2519
2520         * Scripts/webkitperl/FeatureList.pm:
2521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2522
2523 2017-01-15  Sam Weinig  <sam@webkit.org>
2524
2525         Add the ability to use numbers in makeString()
2526         https://bugs.webkit.org/show_bug.cgi?id=167087
2527
2528         Reviewed by Darin Adler.
2529
2530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2531         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2532         Add tests for StringConcatenate, focusing on new numeric additions.
2533
2534 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2535
2536         Unreviewed, remove stale comment.
2537
2538         This test was fixed by r163173.
2539
2540         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2541
2542 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2543
2544         Annotate large string tests with largeHeap
2545         https://bugs.webkit.org/show_bug.cgi?id=167054
2546
2547         Reviewed by Filip Pizlo.
2548
2549         * Scripts/run-javascriptcore-tests:
2550         * Scripts/run-jsc-stress-tests:
2551
2552 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2553
2554         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2555         https://bugs.webkit.org/show_bug.cgi?id=167043
2556
2557         Reviewed by Darin Adler.
2558
2559         * Scripts/webkitperl/FeatureList.pm:
2560
2561 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2562
2563         Remove ENABLE(DETAILS_ELEMENT) guards
2564         https://bugs.webkit.org/show_bug.cgi?id=167042
2565
2566         Reviewed by Alex Christensen.
2567
2568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2569
2570 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2571
2572         26 MotionMark performance tests failing
2573         https://bugs.webkit.org/show_bug.cgi?id=166854
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         Unrelated change. This is the last place that we need to rename Animometer
2578         to MotionMark.
2579
2580         * Scripts/webkitpy/common/config/watchlist:
2581
2582 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2583
2584         run-jsc-benchmarks' echo should have -e option
2585         https://bugs.webkit.org/show_bug.cgi?id=167009
2586
2587         Reviewed by Sam Weinig.
2588
2589         echo requires `-e` option to use escape sequence.
2590         Without it, in some environment (in my Fedora 25), the escape sequence is not
2591         recognized and just dumped as `\c` etc.
2592
2593         * Scripts/run-jsc-benchmarks:
2594
2595 2017-01-12  Chris Dumez  <cdumez@apple.com>
2596
2597         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2598         https://bugs.webkit.org/show_bug.cgi?id=166995
2599
2600         Reviewed by Jer Noble.
2601
2602         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2603         as some people are having trouble building without it.
2604
2605         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2606
2607 2017-01-12  Sam Weinig  <sam@webkit.org>
2608
2609         Add the ability to filter the set of bindings tests you want to run
2610         https://bugs.webkit.org/show_bug.cgi?id=166977
2611
2612         Reviewed by Tim Horton.
2613
2614         Allows doing things like:
2615             run-bindings-tests TestObj* TestCEReactions*
2616         
2617         to run only those tests that match the patterns.
2618
2619         * Scripts/run-bindings-tests:
2620         (main):
2621         Switch to using optparse and pass the remaining args as the filters.
2622
2623         * Scripts/webkitpy/bindings/main.py:
2624         (BindingsTests.__init__):
2625         Store the pattens.
2626
2627         (BindingsTests.test_matches_patterns):
2628         Add helper predicate to determine if a test should be run. When no
2629         patterns are present, all tests should run.
2630
2631         (BindingsTests.run_tests):
2632         Filter tests using the passed in patterns.
2633
2634 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2635
2636         Followup fix after r210503.
2637         https://bugs.webkit.org/show_bug.cgi?id=166887
2638
2639         Reviewed by Alex Christensen.
2640
2641         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2642         duplicated file handle on Windows. This patch fixes the remaining call sites.
2643
2644         * DumpRenderTree/PixelDumpSupport.cpp:
2645         * DumpRenderTree/TestRunner.cpp:
2646         (TestRunner::waitToDumpWatchdogTimerFired):
2647         * DumpRenderTree/TestRunner.h:
2648         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2649         * DumpRenderTree/win/DumpRenderTree.cpp:
2650         * DumpRenderTree/win/DumpRenderTreeWin.h:
2651         * DumpRenderTree/win/TestRunnerWin.cpp:
2652         (TestRunner::setSpellCheckerLoggingEnabled):
2653
2654 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2655
2656         Add committer status for Megan
2657         https://bugs.webkit.org/show_bug.cgi?id=166954
2658
2659         Reviewed by Tim Horton.
2660
2661         Add committer status for Megan Gardner
2662
2663         * Scripts/webkitpy/common/config/contributors.json:
2664
2665 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2666
2667         Unreviewed test fix after r210599.
2668
2669         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2670         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2671
2672 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2673
2674         Unreviewed build fix after r210599.
2675
2676         Add missing files.
2677
2678         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2679         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2680
2681 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2682
2683         File scheme should not allow access of a resource on a different volume.
2684         https://bugs.webkit.org/show_bug.cgi?id=158552
2685         <rdar://problem/15307582>
2686
2687         Reviewed by Alex Christensen.
2688
2689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2690         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2691         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2692
2693 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2694
2695         Unreviewed, rolling out r210571.
2696
2697         This change broke the 32-bit macOS build and caused LayoutTest
2698         failures.
2699
2700         Reverted changeset:
2701
2702         "File scheme should not allow access of a resource on a
2703         different volume."
2704         https://bugs.webkit.org/show_bug.cgi?id=158552
2705         http://trac.webkit.org/changeset/210571
2706
2707 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2708
2709         [GTK] install-dependencies script misses gdb
2710         https://bugs.webkit.org/show_bug.cgi?id=166917
2711
2712         Reviewed by Michael Catanzaro.
2713
2714         gdb is needed for generating the crash logs.
2715
2716         * gtk/install-dependencies:
2717
2718 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2719
2720         [GTK] No way for applications to set notification permissions without waiting for permission request
2721         https://bugs.webkit.org/show_bug.cgi?id=163366
2722
2723         Reviewed by Carlos Garcia Campos.
2724
2725         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2726         (testWebViewNotification):
2727         (setInitialNotificationPermissionsAllowedCallback):
2728         (setInitialNotificationPermissionsDisallowedCallback):
2729         (testWebViewNotificationInitialPermissionAllowed):
2730         (testWebViewNotificationInitialPermissionDisallowed):
2731         (beforeAll):
2732         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2733         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2734         (WebViewTest::WebViewTest):
2735         (WebViewTest::initializeWebView):
2736         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2737
2738 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2739
2740         MobileMiniBrowser tests don't work by default
2741         https://bugs.webkit.org/show_bug.cgi?id=166910
2742
2743         Reviewed by Alex Christensen.
2744
2745         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2746         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2747
2748 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2749
2750         File scheme should not allow access of a resource on a different volume.
2751         https://bugs.webkit.org/show_bug.cgi?id=158552
2752         <rdar://problem/15307582>
2753
2754         Reviewed by Alex Christensen.
2755
2756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2757         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2758         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2759
2760 2017-01-10  Mark Lam  <mark.lam@apple.com>
2761
2762         Reverting run-jsc-stress-tests' $buildType to use string values.
2763         https://bugs.webkit.org/show_bug.cgi?id=166912
2764
2765         Rubber stamped by Filip Pizlo.
2766
2767         This is so that we can test for it in the tests e.g.
2768         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2769
2770         * Scripts/run-jsc-stress-tests:
2771
2772 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2773
2774         Temporarily add back the file removed in r210463 to unbreak internal bots.
2775
2776         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2777
2778 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2779
2780         svn-apply failed to apply a patch (deleting file with svn property)
2781         https://bugs.webkit.org/show_bug.cgi?id=165953
2782
2783         Reviewed by Daniel Bates.
2784
2785         * Scripts/VCSUtils.pm:
2786         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2787         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2788
2789 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2790
2791         Update flakiness dashboard configuration.
2792         https://bugs.webkit.org/show_bug.cgi?id=166869
2793
2794         Reviewed by Alexey Proskuryakov.
2795
2796         * TestResultServer/static-dashboards/builders.jsonp:
2797         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2798
2799 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2800
2801         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2802         https://bugs.webkit.org/show_bug.cgi?id=165232
2803
2804         Unreviewed follow-up patch after r210539 and r210523.
2805
2806         Instead of using that environment variable, the argument
2807         --display-server=xorg should be passed now.
2808
2809         The GTK+ performance bot was the only bot using this, and is
2810         already passing --display-server=xorg after r210539.
2811
2812         * Scripts/webkitpy/port/gtk.py:
2813         (GtkPort._driver_class):
2814
2815 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2816
2817         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2818         https://bugs.webkit.org/show_bug.cgi?id=166872
2819
2820         Reviewed by Michael Catanzaro.
2821
2822         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2823         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2824         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2825         The step RunWebKitTests already has support for it.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/config.json:
2828         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2829         (RunGtkAPITests.start):
2830         (RunAndUploadPerfTests.start):
2831         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2832
2833 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2834
2835         Unreviewed, rolling out r210531.
2836
2837         This change broke the 32-bit macOS build and caused LayoutTest
2838         failures.
2839
2840         Reverted changeset:
2841
2842         "File scheme should not allow access of a resource on a
2843         different volume."
2844         https://bugs.webkit.org/show_bug.cgi?id=158552
2845         http://trac.webkit.org/changeset/210531
2846
2847 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2848
2849         File scheme should not allow access of a resource on a different volume.
2850         https://bugs.webkit.org/show_bug.cgi?id=158552
2851         <rdar://problem/15307582>
2852
2853         Reviewed by Alex Christensen.
2854
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2856         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2857         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2858
2859 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2860
2861         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2862         https://bugs.webkit.org/show_bug.cgi?id=165232
2863
2864         Reviewed by Michael Catanzaro.
2865
2866         Add a new WaylandDriver to run the tests in the user current wayland session.
2867
2868         Also merge all the configuration options for selecting the display server inside one
2869         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2870
2871         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2872
2873         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2874         (TestRunner._create_driver):
2875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2876         (parse_args):
2877         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2878         (PerfTestsRunner._parse_args):
2879         * Scripts/webkitpy/port/gtk.py:
2880         (GtkPort.__init__):
2881         (GtkPort._driver_class):
2882         (GtkPort._search_paths):
2883         * Scripts/webkitpy/port/waylanddriver.py: Added.
2884         (WaylandDriver):
2885         (WaylandDriver.check_driver):
2886         (WaylandDriver._setup_environ_for_test):
2887         (WaylandDriver._start):
2888
2889 2017-01-09  Andy Estes  <aestes@apple.com>
2890
2891         [QuickLook] Add a layout test for webkit.org/b/135651
2892         https://bugs.webkit.org/show_bug.cgi?id=166855
2893
2894         Reviewed by Andreas Kling.
2895
2896         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2897         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2898         errors with code WebKitErrorCannotShowURL.
2899         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2900         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2901         not specific to WebKit2 error codes.
2902
2903 2017-01-09  Antoine Quint  <graouts@apple.com>
2904
2905         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2906         https://bugs.webkit.org/show_bug.cgi?id=166837
2907
2908         Reviewed by Alex Christensen.
2909
2910         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2911         the provided value when trying to determine the path to the test file. Failing
2912         that, we use the computed URL or the raw path provided to cover all cases.
2913         
2914         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2915         by applying this patch and seeing the number test failures dramatically reduced
2916         with WK1 due to the option to turn modern media controls off for older media controls
2917         tests.
2918
2919         * DumpRenderTree/DumpRenderTree.h:
2920         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2921         (parseInputLine):
2922         * DumpRenderTree/TestOptions.h:
2923         * DumpRenderTree/TestOptions.mm:
2924         (TestOptions::TestOptions):
2925         * DumpRenderTree/mac/DumpRenderTree.mm:
2926         (runTest):
2927
2928 2017-01-09  Milan Crha  <mcrha@redhat.com>
2929
2930         prepare-ChangeLog: Correct help string for --style option
2931         https://bugs.webkit.org/show_bug.cgi?id=166725
2932
2933         Reviewed by Alexey Proskuryakov.
2934
2935         * Scripts/prepare-ChangeLog:
2936         (main):
2937
2938 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2939
2940         https://bugs.webkit.org/show_bug.cgi?id=166839
2941         Add php7 support for macOS.
2942         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2943
2944         Reviewed by Alexey Proskuryakov.
2945
2946         * Scripts/webkitpy/port/base.py:
2947         (Port._is_darwin_php_version_7):
2948         (Port._debian_php_version):
2949         (Port):
2950         (Port._darwin_php_version):
2951         (Port._apache_config_file_name_for_platform):
2952
2953 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2954
2955         [GTK] Should support key and code properties on keyboard events
2956         https://bugs.webkit.org/show_bug.cgi?id=166759
2957
2958         Reviewed by Carlos Garcia Campos.
2959
2960         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2961         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2962         on tests.
2963
2964 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2965
2966         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2967         https://bugs.webkit.org/show_bug.cgi?id=166760
2968
2969         Reviewed by Darin Adler.
2970
2971         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2972         We can work around that by duplicating and redirecting stdout.
2973
2974         * DumpRenderTree/PixelDumpSupport.cpp:
2975         (dumpWebViewAsPixelsAndCompareWithExpected):
2976         (printPNG):
2977         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2978         (logEventProc):
2979         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2980         (DRTDesktopNotificationPresenter::showDesktopNotification):
2981         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2982         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2983         * DumpRenderTree/win/DumpRenderTree.cpp:
2984         (dumpFrameScrollPosition):
2985         (dumpHistoryItem):
2986         (dumpBackForwardList):
2987         (dump):
2988         (runTest):
2989         (main):
2990         * DumpRenderTree/win/DumpRenderTreeWin.h:
2991         * DumpRenderTree/win/EditingDelegate.cpp:
2992         (EditingDelegate::shouldBeginEditingInDOMRange):
2993         (EditingDelegate::shouldEndEditingInDOMRange):
2994         (EditingDelegate::shouldInsertNode):
2995         (EditingDelegate::shouldInsertText):
2996         (EditingDelegate::shouldDeleteDOMRange):
2997         (EditingDelegate::shouldChangeSelectedDOMRange):
2998         (EditingDelegate::shouldApplyStyle):
2999         (EditingDelegate::shouldChangeTypingStyle):
3000         (EditingDelegate::doPlatformCommand):
3001         (EditingDelegate::webViewDidBeginEditing):
3002         (EditingDelegate::webViewDidChange):
3003         (EditingDelegate::webViewDidEndEditing):
3004         (EditingDelegate::webViewDidChangeTypingStyle):
3005         (EditingDelegate::webViewDidChangeSelection):
3006         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3007         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3008         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3009         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3010         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3011         (FrameLoadDelegate::didCommitLoadForFrame):
3012         (FrameLoadDelegate::didReceiveTitle):
3013         (FrameLoadDelegate::didFinishLoadForFrame):
3014         (FrameLoadDelegate::didFailLoadWithError):
3015         (FrameLoadDelegate::willPerformClientRedirectToURL):
3016         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3017         (FrameLoadDelegate::windowScriptObjectAvailable):
3018         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3019         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3020         (FrameLoadDelegate::didDisplayInsecureContent):
3021         (FrameLoadDelegate::didRunInsecureContent):
3022         (FrameLoadDelegate::webViewProgressFinishedNotification):
3023         * DumpRenderTree/win/HistoryDelegate.cpp:
3024         (HistoryDelegate::didNavigateWithNavigationData):
3025         (HistoryDelegate::didPerformClientRedirectFromURL):
3026         (HistoryDelegate::didPerformServerRedirectFromURL):
3027         (HistoryDelegate::updateHistoryTitle):
3028         (HistoryDelegate::populateVisitedLinksForWebView):
3029         * DumpRenderTree/win/PolicyDelegate.cpp:
3030         (PolicyDelegate::decidePolicyForNavigationAction):
3031         (PolicyDelegate::unableToImplementPolicyWithError):
3032         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3033         (ResourceLoadDelegate::willSendRequest):
3034         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3035         (ResourceLoadDelegate::didReceiveResponse):
3036         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3037         (ResourceLoadDelegate::didFailLoadingWithError):
3038         * DumpRenderTree/win/TestRunnerWin.cpp:
3039         (TestRunner::addDisallowedURL):
3040         (TestRunner::originsWithApplicationCache):
3041         (TestRunner::setStorageDatabaseIdleInterval):
3042         (TestRunner::closeIdleLocalStorageDatabases):
3043         (TestRunner::copyDecodedHostName):
3044         (TestRunner::copyEncodedHostName):
3045         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3046         (TestRunner::isGeolocationProviderActive):
3047         (TestRunner::pathToLocalResource):
3048         (TestRunner::setMockDeviceOrientation):
3049         (TestRunner::setMockGeolocationPosition):
3050         (TestRunner::setMockGeolocationPositionUnavailableError):
3051         (TestRunner::setSpatialNavigationEnabled):
3052         (TestRunner::setAutomaticLinkDetectionEnabled):
3053         (TestRunner::isCommandEnabled):
3054         (TestRunner::authenticateSession):
3055         (TestRunner::addChromeInputField):
3056         (TestRunner::removeChromeInputField):
3057         (TestRunner::focusWebView):
3058         (TestRunner::grantWebNotificationPermission):
3059         (TestRunner::denyWebNotificationPermission):
3060         (TestRunner::removeAllWebNotificationPermissions):
3061         (TestRunner::simulateWebNotificationClick):
3062         (TestRunner::imageCountInGeneralPasteboard):
3063         * DumpRenderTree/win/UIDelegate.cpp:
3064         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3065         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3066         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3067         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3068         (UIDelegate::webViewAddMessageToConsole):
3069         (UIDelegate::exceededDatabaseQuota):
3070         (UIDelegate::setStatusText):
3071         (UIDelegate::didPressMissingPluginButton):
3072
3073 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3074
3075         Add a setting to create editable MiniBrowser windows by default
3076         https://bugs.webkit.org/show_bug.cgi?id=166806
3077
3078         Reviewed by Beth Dakin.
3079
3080         * MiniBrowser/mac/AppDelegate.m:
3081         (-[BrowserAppDelegate createBrowserWindowController:]):
3082         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3083         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3084         * MiniBrowser/mac/SettingsController.h:
3085         * MiniBrowser/mac/SettingsController.m:
3086         (-[SettingsController _populateMenu]):
3087         (-[SettingsController validateMenuItem:]):
3088         (-[SettingsController toggleCreateEditorByDefault:]):
3089         (-[SettingsController createEditorByDefault]):
3090         Add a setting and update the key equivalents accordingly.
3091         Also make sure to make the right kind of window on launch.
3092
3093 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3094
3095         Fix the 32-bit build.
3096
3097         * MiniBrowser/mac/BrowserWindowController.h:
3098         * MiniBrowser/mac/BrowserWindowController.m:
3099
3100 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3101
3102         Fix the 32-bit build.
3103
3104         * MiniBrowser/mac/BrowserWindowController.m:
3105
3106 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3107
3108         Make it possible to drop HTML files on the MiniBrowser icon
3109         https://bugs.webkit.org/show_bug.cgi?id=166802
3110
3111         Reviewed by Simon Fraser.
3112
3113         * MiniBrowser/mac/AppDelegate.m:
3114         (-[BrowserAppDelegate application:openFile:]):
3115         * MiniBrowser/mac/Info.plist:
3116         If you're using an editable window, the usual trick of dropping on the
3117         window doesn't work anymore (it makes an <attachment> instead).
3118
3119 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3120
3121         MiniBrowser window gets smaller each time it is instantiated
3122         https://bugs.webkit.org/show_bug.cgi?id=166807
3123
3124         Reviewed by Andy Estes.
3125
3126         * MiniBrowser/mac/BrowserWindowController.m:
3127         (-[BrowserWindowController windowDidLoad]):
3128         * MiniBrowser/mac/BrowserWindow.xib:
3129         Turn on full-window content view support with IB, instead of waiting
3130         until after the views have been loaded. This seems to resolve the
3131         longstanding ever-shrinking-window problem.
3132
3133 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3134
3135         Add indent/outdent items to MiniBrowser's new format menu
3136         https://bugs.webkit.org/show_bug.cgi?id=166805
3137
3138         Reviewed by Dan Bernstein.
3139
3140         * MiniBrowser/mac/MainMenu.xib:
3141
3142 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3143
3144         Add a stock Format menu to MiniBrowser
3145         https://bugs.webkit.org/show_bug.cgi?id=166804
3146
3147         Reviewed by Andy Estes.
3148
3149         * MiniBrowser/mac/MainMenu.xib:
3150         Many of the features automatically work with editable web views.
3151         However, this seems to expose a bug where none of the font-related features
3152         (Cmd-B, for example) work until the first time the font panel is shown,
3153         per process, which will need to be investigated separately.
3154
3155 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3156
3157         Remove unused applicationWillTerminate methods from MiniBrowser
3158         https://bugs.webkit.org/show_bug.cgi?id=166803
3159
3160         Reviewed by Andy Estes.
3161
3162         * MiniBrowser/mac/AppDelegate.m:
3163         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3164         * MiniBrowser/mac/BrowserWindowController.h:
3165         * MiniBrowser/mac/BrowserWindowController.m:
3166         (-[BrowserWindowController applicationTerminating]): Deleted.
3167         * MiniBrowser/mac/WK1BrowserWindowController.m:
3168         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3169         * MiniBrowser/mac/WK2BrowserWindowController.m:
3170         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3171
3172 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3173
3174         Add the ability to create empty contentEditable windows in MiniBrowser
3175         https://bugs.webkit.org/show_bug.cgi?id=166801
3176
3177         Reviewed by Wenson Hsieh.
3178
3179         * MiniBrowser/mac/AppDelegate.h:
3180         * MiniBrowser/mac/AppDelegate.m:
3181         (-[BrowserAppDelegate createBrowserWindowController:]):
3182         (-[BrowserAppDelegate newWindow:]):
3183         (-[BrowserAppDelegate newEditorWindow:]):
3184         (-[BrowserAppDelegate openDocument:]):
3185         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3186         * MiniBrowser/mac/BrowserWindowController.h:
3187         * MiniBrowser/mac/BrowserWindowController.m:
3188         (-[BrowserWindowController loadHTMLString:]):
3189         (-[BrowserWindowController toggleEditable:]):
3190         * MiniBrowser/mac/MainMenu.xib:
3191         * MiniBrowser/mac/WK1BrowserWindowController.m:
3192         (-[WK1BrowserWindowController awakeFromNib]):
3193         (-[WK1BrowserWindowController loadHTMLString:]):
3194         (-[WK1BrowserWindowController validateMenuItem:]):
3195         (-[WK1BrowserWindowController setEditable:]):
3196         (-[WK1BrowserWindowController updateTitle:]):
3197         * MiniBrowser/mac/WK2BrowserWindowController.m:
3198         (-[WK2BrowserWindowController awakeFromNib]):
3199         (-[WK2BrowserWindowController validateMenuItem:]):
3200         (-[WK2BrowserWindowController setEditable:]):
3201         (-[WK2BrowserWindowController updateTitle:]):
3202         (-[WK2BrowserWindowController loadHTMLString:]):
3203         Merge more functionality from WebEditingTester.
3204         Add two menu items for creating empty editable WebKit1/2 windows.
3205         Add a menu item to the Edit menu to toggle editability on any window.
3206
3207 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3208
3209         Implement find-in-page in MiniBrowser
3210         https://bugs.webkit.org/show_bug.cgi?id=166799
3211
3212         Reviewed by Andy Estes.
3213
3214         * MiniBrowser/mac/BrowserWindow.xib:
3215         * MiniBrowser/mac/BrowserWindowController.h:
3216         * MiniBrowser/mac/BrowserWindowController.m:
3217         (-[BrowserWindowController find:]): Deleted.
3218         * MiniBrowser/mac/MainMenu.xib:
3219         * MiniBrowser/mac/WK1BrowserWindowController.m:
3220         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3221         (-[WK1BrowserWindowController find:]): Deleted.
3222         * MiniBrowser/mac/WK2BrowserWindowController.m:
3223         (-[WK2BrowserWindowController awakeFromNib]):
3224         (-[WK2BrowserWindowController dealloc]):
3225         (-[WK2BrowserWindowController validateMenuItem:]):
3226         (-[WK2BrowserWindowController performTextFinderAction:]):
3227         (-[WK2BrowserWindowController findBarView]):
3228         (-[WK2BrowserWindowController setFindBarView:]):
3229         (-[WK2BrowserWindowController isFindBarVisible]):
3230         (-[WK2BrowserWindowController setFindBarVisible:]):
3231         (-[WK2BrowserWindowController contentView]):
3232         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3233         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3234         (-[WK2BrowserWindowController find:]): Deleted.
3235         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3236         protocol. At first glance, it's pretty broken, but vaguely works.
3237
3238 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3239
3240         Share the implementation of MiniBrowser view hiding functionality
3241         https://bugs.webkit.org/show_bug.cgi?id=166800
3242
3243         Reviewed by Andy Estes.
3244
3245         * MiniBrowser/mac/BrowserWindowController.m:
3246         (-[BrowserWindowController showHideWebView:]):
3247         (-[BrowserWindowController removeReinsertWebView:]):
3248         * MiniBrowser/mac/WK1BrowserWindowController.m:
3249         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3250         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3251         * MiniBrowser/mac/WK2BrowserWindowController.m:
3252         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3253         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3254         Move the implementation of these two things to the shared superclass,
3255         since they don't depend on WebKit-specific things.
3256         Also, there was no reason to retain the (WK)WebView while it was unparented,
3257         as the BrowserWindowController maintains a reference the entire time.
3258
3259 2017-01-06  Andy Estes  <aestes@apple.com>
3260
3261         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3262         https://bugs.webkit.org/show_bug.cgi?id=166789
3263
3264         Reviewed by Alex Christensen.
3265
3266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3267         * DumpRenderTree/PlatformMac.cmake:
3268         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3269         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3270         * DumpRenderTree/mac/DumpRenderTree.mm:
3271         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3272         createXMLStringFromWebArchiveData().
3273         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3274         * WebKitTestRunner/Configurations/Base.xcconfig:
3275         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3277         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3278         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3279         createXMLStringFromWebArchiveData().
3280         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3281         * WebKitTestRunner/PlatformMac.cmake:
3282         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3283         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3284
3285 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3286
3287         Minor cleanups to IndentOutdentCommand and related code
3288         https://bugs.webkit.org/show_bug.cgi?id=166791
3289
3290         Reviewed by Simon Fraser.
3291
3292         * WebEditingTester/EditingOperations.m:
3293         (editingOperations):
3294         Add the outdent operation to WebEditingTester.
3295
3296 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3297
3298         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3299         https://bugs.webkit.org/show_bug.cgi?id=166785
3300
3301         Reviewed by Ryosuke Niwa.
3302
3303         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3304         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3305
3306 2017-01-06  Antoine Quint  <graouts@apple.com>
3307
3308         Support webkit-test-runner key-value pairs in http tests
3309         https://bugs.webkit.org/show_bug.cgi?id=149812
3310
3311         Reviewed by Alex Christensen.
3312
3313         We pass the absolute path for a test through to WKTR so that we can parse
3314         tests that are running as URLs for webkit-test-runner options.
3315
3316         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3317         (parseInputLine):
3318
3319         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3320
3321         * Scripts/webkitpy/port/driver.py:
3322         (Driver._command_from_driver_input):
3323
3324         Pass the absolute path to the file through the CLI.
3325
3326         * WebKitTestRunner/TestController.cpp:
3327         (WTR::updateTestOptionsFromTestHeader):
3328         (WTR::TestController::testOptionsForTest):
3329         (WTR::parseInputLine):
3330         (WTR::TestController::runTest):
3331         * WebKitTestRunner/TestController.h:
3332
3333 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3334
3335         Warning about unconnectable outlets when opening a MiniBrowser window
3336         https://bugs.webkit.org/show_bug.cgi?id=166756
3337
3338         Reviewed by Dan Bernstein.
3339
3340         * MiniBrowser/mac/BrowserWindow.xib:
3341         When launching MiniBrowser, it says:
3342         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3343             (MBToolbarItem): missing setter or instance variable
3344         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3345             (NSButtonCell): missing setter or instance variable.
3346
3347         It looks like someone added the connection from the share button
3348         to the BrowserWindowController three times; only one of the connections
3349         is valid. Remove the other two.
3350
3351 2017-01-05  Keith Rollin  <krollin@apple.com>
3352
3353         Add WebCore::URL::protocolHostAndPort
3354         https://bugs.webkit.org/show_bug.cgi?id=166426
3355
3356         Reviewed by Alex Christensen.
3357
3358         Add test for protocolHostAndPort.
3359
3360         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3361         (TestWebKitAPI::TEST_F):
3362
3363 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3364
3365         [Win] Archive test result is failing.
3366         https://bugs.webkit.org/show_bug.cgi?id=166720
3367
3368         Reviewed by Alex Christensen.
3369
3370         Deleting the layout test result folder is sometimes failing
3371         on Windows. This is not a critical error.
3372
3373         * BuildSlaveSupport/test-result-archive:
3374         (archiveTestResults):
3375
3376 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3377
3378         [GTK] Minibrowser: Add printing support
3379         https://bugs.webkit.org/show_bug.cgi?id=165298
3380
3381         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3382         an error during the print, it's printed on the console.
3383
3384         Reviewed by Michael Catanzaro.
3385
3386         * MiniBrowser/gtk/BrowserWindow.c:
3387         (webKitPrintOperationFailedCallback):
3388         (printPage):
3389         (browser_window_init):
3390
3391 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3392
3393         [css-grid] Fix crash clamping grid lines
3394         https://bugs.webkit.org/show_bug.cgi?id=166637
3395
3396         Reviewed by Darin Adler.
3397
3398         Creates new unit test to verify that the maximum tracks limit
3399         is used in GridPosition too.
3400
3401         * TestWebKitAPI/PlatformEfl.cmake:
3402         * TestWebKitAPI/PlatformGTK.cmake:
3403         * TestWebKitAPI/PlatformWin.cmake:
3404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3405         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3406         (TestWebKitAPI::TEST):
3407
3408 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3409
3410         Move editing history scripts to WebCore PrivateHeaders
3411         https://bugs.webkit.org/show_bug.cgi?id=166709
3412         <rdar://problem/29876612>
3413
3414         Reviewed by Dan Bernstein.
3415
3416         Update references to editing script files in WebCore that were moved.
3417
3418         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3419
3420 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3421
3422         Unreviewed, build fix after r210313 part 2
3423         https://bugs.webkit.org/show_bug.cgi?id=166676
3424
3425         Add 'U' suffix.
3426
3427         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3428         (TestWebKitAPI::TEST):
3429         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3430         (TestWebKitAPI::TEST):
3431
3432 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3433
3434         Limit thread name appropriately
3435         https://bugs.webkit.org/show_bug.cgi?id=166676
3436
3437         Reviewed by Sam Weinig.
3438
3439         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3440         (TestWebKitAPI::TEST):
3441         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3442         (TestWebKitAPI::TEST):
3443
3444 2017-01-04  Andy Estes  <aestes@apple.com>
3445
3446         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3447         https://bugs.webkit.org/show_bug.cgi?id=166696
3448
3449         Reviewed by Tim Horton.
3450
3451         * TestWebKitAPI/PlatformGTK.cmake:
3452         * TestWebKitAPI/PlatformWin.cmake:
3453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3454         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3455         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3456         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3457         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3458         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3459         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3460
3461 2017-01-03  Brian Burg  <bburg@apple.com>
3462
3463         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3464         https://bugs.webkit.org/show_bug.cgi?id=166003
3465         <rdar://problem/28718990>
3466
3467         Reviewed by Joseph Pecoraro.
3468
3469         Teach run-inspector-generator-tests to generate test output using the platform name
3470         derived from the directory that the test is in. For example, tests in the /generic/
3471         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3472
3473         * Scripts/webkitpy/inspector/main.py:
3474         (InspectorGeneratorTests.generate_from_json):
3475         (InspectorGeneratorTests.run_tests):
3476         (InspectorGeneratorTests.main):
3477
3478 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3479
3480         Unreviewed cmake buildfix after r210266.
3481
3482         * DumpRenderTree/PlatformMac.cmake:
3483
3484 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3485
3486         Provide a setting for clients to always prefer low-power WebGL
3487         https://bugs.webkit.org/show_bug.cgi?id=166675
3488         <rdar://problem/29834093>
3489
3490         Reviewed by Dan Bernstein.
3491
3492         * MiniBrowser/mac/Info.plist:
3493         Have MiniBrowser claim to be a modern app that supports
3494         automatic graphics switching. WebKit needs to support automatic
3495         graphics switching, so our test app might as well. Without this
3496         Info.plist parameter, this change has no effect, and bringing up
3497         a WebGL context still brings up the discrete GPU (also true of the
3498         existing web-exposed preferLowPowerToHighPerformance API).
3499
3500 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3501
3502         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3503         https://bugs.webkit.org/show_bug.cgi?id=166645
3504
3505         Reviewed by Carlos Garcia Campos.
3506
3507         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3508         (TestWebKitAPI::TEST):
3509
3510 2017-01-03  Andy Estes  <aestes@apple.com>
3511
3512         Place all the Cocoa WebCore API tests in the same directory
3513         https://bugs.webkit.org/show_bug.cgi?id=166673
3514
3515         Reviewed by Michael Catanzaro.
3516
3517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3518         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3519         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3520         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3521
3522 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3523
3524         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3525         https://bugs.webkit.org/show_bug.cgi?id=166450
3526         <rdar://problem/29447824>
3527
3528         Reviewed by Darin Adler.
3529
3530         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3531         * DumpRenderTree/TestRunner.cpp:
3532         (TestRunner::staticFunctions):
3533         * DumpRenderTree/mac/TestRunnerMac.mm:
3534         (setSpellCheckerLoggingEnabledCallback):
3535         * DumpRenderTree/win/TestRunnerWin.cpp:
3536         (setSpellCheckerLoggingEnabledCallback):
3537         * DumpRenderTree/mac/DumpRenderTree.mm:
3538         (resetWebViewToConsistentStateBeforeTesting):
3539         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3540         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3541         (stringForCorrectionResponse):
3542         (drt_NSSpellChecker_recordResponseToCorrection):
3543         (swizzleNSSpellCheckerMethodsIfNeeded):
3544         (setSpellCheckerLoggingEnabled):
3545         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3546         set to true, logs to stdout (which ends up in the test result) whenever
3547         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3548         is called, and then calls the original method. It is reset to false between tests.
3549
3550 2017-01-03  Sam Weinig  <sam@webkit.org>
3551
3552         Make WTF::Expected support Ref template parameters
3553         https://bugs.webkit.org/show_bug.cgi?id=166662
3554
3555         Reviewed by Alex Christensen.
3556
3557         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3558         (TestWebKitAPI::TEST):
3559         Add tests for using Ref with Expected.
3560
3561 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3562
3563         [GTK] Expose WebKitSecurityOrigin API
3564         https://bugs.webkit.org/show_bug.cgi?id=166632
3565
3566         Reviewed by Carlos Garcia Campos.
3567
3568         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3569         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3570         (testSecurityOriginBasicConstructor):
3571         (testSecurityOriginURIConstructor):
3572         (testSecurityOriginDefaultPort):
3573         (testSecurityOriginFileURI):
3574         (testSecurityOriginDataURI):
3575         (beforeAll):
3576         (afterAll):
3577
3578 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3579
3580         [GTK] HTTP auth layout tests are flaky
3581         https://bugs.webkit.org/show_bug.cgi?id=158919
3582
3583         Reviewed by Michael Catanzaro.
3584
3585         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3586         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3587         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3588         missing valac in the bots.
3589
3590 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3591
3592         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3593         https://bugs.webkit.org/show_bug.cgi?id=165797
3594
3595         Reviewed by Michael Catanzaro.
3596
3597         Move directory ruleset after all exclude rules of Source rulset.
3598
3599         * gtk/manifest.txt.in:
3600
3601 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3602
3603         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3604         https://bugs.webkit.org/show_bug.cgi?id=166636
3605
3606         Reviewed by Darin Adler.
3607
3608         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3609         (TestWebKitAPI::TEST):
3610
3611 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3612
3613         [GTK] WebCore/CSSParser unit test is not being built
3614         https://bugs.webkit.org/show_bug.cgi?id=166492
3615
3616         Reviewed by Michael Catanzaro.
3617
3618         This test was introduced in r175930, but we were not building
3619         it on GTK+ port since r176015.
3620         This patch marks the test to be built again on GTK+.
3621         JFTR, the test is passing right now.
3622
3623         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3624         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3625
3626 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3627
3628         AX: Expose block quote level to iOS API
3629         https://bugs.webkit.org/show_bug.cgi?id=166629
3630         <rdar://problem/29834793>
3631
3632         Reviewed by Darin Adler.
3633
3634         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3635         (AccessibilityUIElement::numberAttributeValue):
3636         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3637         (WTR::AccessibilityUIElement::numberAttributeValue):
3638
3639 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3640
3641         SecurityOrigin::create triplet constructor does not canonicalize port
3642         https://bugs.webkit.org/show_bug.cgi?id=166624
3643
3644         Reviewed by Daniel Bates.
3645
3646         * TestWebKitAPI/PlatformGTK.cmake:
3647         * TestWebKitAPI/PlatformWin.cmake:
3648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3649         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3650         (TestWebKitAPI::SecurityOriginTest::SetUp):
3651         (TestWebKitAPI::TEST_F):
3652
3653 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3654
3655         [GTK] Improve user agent construction
3656         https://bugs.webkit.org/show_bug.cgi?id=142074
3657
3658         Reviewed by Carlos Garcia Campos.
3659
3660         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3661         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3662         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3663         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3664         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3665         (TestWebKitAPI::TEST):
3666
3667 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3668
3669         [GTK] Improve user agent construction
3670         https://bugs.webkit.org/show_bug.cgi?id=142074
3671
3672         Reviewed by Carlos Garcia Campos.
3673
3674         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3675         (TestWebKitAPI::TEST):
3676
3677 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3678
3679         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3680         https://bugs.webkit.org/show_bug.cgi?id=166472
3681         rdar://problem/29675551
3682
3683         Reviewed by Tim Horton.
3684
3685         These changes are necessary to allow the mouse to leave the WTR window while
3686         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3687         (which DRT does); we'd always go through mouseMoved, which hits an early return
3688         in WebViewImpl::mouseMoved() when the point is outside the view.
3689
3690         * WebKitTestRunner/mac/EventSenderProxy.mm:
3691         (WTR::EventSenderProxy::mouseMoveTo):
3692
3693 2016-12-23  Andy Estes  <aestes@apple.com>
3694
3695         [iOS] Fix some crashing webarchive tests
3696         https://bugs.webkit.org/show_bug.cgi?id=166470
3697
3698         Reviewed by Andreas Kling.
3699
3700         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3701         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3702         so this change uses that on both platforms.
3703
3704         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3705         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3706         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3707         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3708         * WebKitTestRunner/PlatformMac.cmake:
3709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3710         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3711
3712 2016-12-22  Saam Barati  <sbarati@apple.com>
3713
3714         WebAssembly: Silence the output of the spec-tests
3715         https://bugs.webkit.org/show_bug.cgi?id=166417
3716
3717         Reviewed by Mark Lam.
3718
3719         * Scripts/run-jsc-stress-tests:
3720
3721 2016-12-22  Zhuo Li  <zachli@apple.com>
3722
3723         [Cocoa] SPI for setloadsImagesAutomatically.
3724         https://bugs.webkit.org/show_bug.cgi?id=166401.
3725
3726         Reviewed by Darin Adler.
3727
3728         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3729         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3730         _loadsImagesAutomatically returns YES.
3731
3732 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3733
3734         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3735         https://bugs.webkit.org/show_bug.cgi?id=161328
3736         <rdar://problem/28475977>
3737
3738         Reviewed by Darin Adler.
3739
3740         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3741         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3742         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3743         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3744         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3745         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3746         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3747         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3748         we finish running a test and before we load the next test.
3749
3750         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3751         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3752         previous test started zooming and then finished before zooming completed. Since this happens before the next
3753         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3754
3755         * WebKitTestRunner/ios/TestControllerIOS.mm:
3756         (WTR::TestController::platformResetStateToConsistentValues):
3757
3758 2016-12-22  Jer Noble  <jer.noble@apple.com>
3759
3760         Muted media element playback should not interrupt other audio playback
3761         https://bugs.webkit.org/show_bug.cgi?id=166347
3762
3763         Reviewed by Eric Carlson.
3764
3765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3766         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3767         (TestWebKitAPI::TEST):
3768         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3769
3770 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3771
3772         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3773         https://bugs.webkit.org/show_bug.cgi?id=166346
3774
3775         Reviewed by Carlos Garcia Campos.
3776
3777         Enable WebRTC by default to simplify testing.
3778
3779         * MiniBrowser/gtk/main.c:
3780         (main):
3781
3782 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3783
3784         REGRESSION: API test failure: WKWebView.LocalStorageClear
3785         https://bugs.webkit.org/show_bug.cgi?id=166032
3786         <rdar://problem/29758423>
3787
3788         Reviewed by Simon Fraser.
3789
3790         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3791         to ensure that the view is destroyed before the callback fires.
3792
3793         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3794         (TEST):
3795
3796 2016-12-21  Saam Barati  <sbarati@apple.com>
3797
3798         WebAssembly: Import spec tests
3799         https://bugs.webkit.org/show_bug.cgi?id=166395
3800
3801         Rubber stamped by Keith Miller.
3802
3803         * Scripts/run-jsc-stress-tests:
3804
3805 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3806
3807         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3808         https://bugs.webkit.org/show_bug.cgi?id=166033
3809         <rdar://problem/29758428>
3810
3811         Reviewed by Simon Fraser.
3812
3813         Add an @autoreleasepool around the code that allocates the WKWebView, 
3814         so that it can be destroyed by removing the last reference in _downloadDidStart.
3815
3816         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3817         (TEST):
3818
3819 2016-12-21  Daniel Bates  <dabates@apple.com>
3820
3821         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3822         https://bugs.webkit.org/show_bug.cgi?id=166356
3823
3824         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3825         as a means to allow a test to explicit allow an embedding client to open a new windows
3826         such that the default behavior is for the embedding client to forbid such an action.
3827         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3828         it is currently skipped on WebKit2 because questions were raised in the patch for
3829         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3830         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3831         this test.
3832
3833         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3834         (WTR::TestRunner::setCanOpenWindows):
3835
3836 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3837
3838         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3839         https://bugs.webkit.org/show_bug.cgi?id=166031
3840
3841         Reviewed by Tim Horton.
3842         
3843         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3844         to ensure that the view is destroyed before the callback fires.
3845
3846         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3847
3848 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3849
3850         Throw Exception when test doesn't clean up HID Events properly
3851         https://bugs.webkit.org/show_bug.cgi?id=166271
3852
3853         Reviewed by Simon Fraser.
3854
3855         Add in a check when UIScriptController is deleted to make sure that the HID event
3856         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3857         the program to crash without any good information. Crashes are race-y, and will still
3858         happen with malformed test, but the information will be much more helpful. 
3859
3860         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3861         (WTR::UIScriptController::checkForClean):
3862         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3863         (UIScriptContext::~UIScriptContext):
3864         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3865         (WTR::UIScriptController::checkForClean):
3866         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3867         * WebKitTestRunner/ios/HIDEventGenerator.h:
3868         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3869         (-[HIDEventGenerator checkHIDCallbacksClear]):
3870         * WebKitTestRunner/ios/TestControllerIOS.mm:
3871         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3872         (WTR::UIScriptController::checkForClean):
3873
3874 2016-12-20  Andy Estes  <aestes@apple.com>
3875
3876         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3877         https://bugs.webkit.org/show_bug.cgi?id=165992
3878
3879         Reviewed by Brady Eidson.
3880
3881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3882         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3883         (expectException):
3884         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3885         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3886         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3887         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3888         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3889         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3890         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3891         (TEST):
3892         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3893
3894 2016-12-20  Dean Jackson  <dino@apple.com>
3895
3896         Remove INDIE_UI
3897         https://bugs.webkit.org/show_bug.cgi?id=165881
3898         <rdar://problem/29672532>
3899
3900         Reviewed by Simon Fraser.
3901
3902         The Indie UI work has been discontinued.
3903
3904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3905
3906 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3907
3908         [ES6] Enable ES6 Modules
3909         https://bugs.webkit.org/show_bug.cgi?id=165849
3910
3911         Reviewed by Geoffrey Garen.
3912
3913         * DumpRenderTree/mac/DumpRenderTree.mm:
3914         (resetWebPreferencesToConsistentValues):
3915         * DumpRenderTree/win/DumpRenderTree.cpp:
3916         (resetWebPreferencesToConsistentValues):
3917         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3918         (WTR::InjectedBundle::beginTesting):
3919         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3920         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3921         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3922
3923 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3924
3925         Repurpose bots and clean up dashboard.
3926         https://bugs.webkit.org/show_bug.cgi?id=166045
3927
3928         Reviewed by Lucas Forschler.
3929
3930         * BuildSlaveSupport/build.webkit.org-config/config.json:
3931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3932         (BubbleQueueServer):
3933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3935         (WebKitBuildbot):
3936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3937         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3938
3939 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3940
3941         [CMake] TestWebKitAPIBase links to itself
3942         https://bugs.webkit.org/show_bug.cgi?id=165985
3943
3944         Reviewed by Alex Christensen.
3945
3946         Fix CMake warning about a target linking to itself, which makes no sense.
3947
3948         * TestWebKitAPI/CMakeLists.txt:
3949
3950 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3951
3952         [GTK] GtkDoc build should be quieter
3953         https://bugs.webkit.org/show_bug.cgi?id=165994
3954
3955         Reviewed by Carlos Garcia Campos.
3956
3957         Make it not print by default.
3958
3959         * gtk/generate-gtkdoc:
3960         (get_generator_for_config):
3961         (generate_doc):
3962         * gtk/gtkdoc.py:
3963         (GTKDoc._run_command):
3964         (GTKDoc._copy_doc_files_to_output_dir):
3965
3966 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3967
3968         Expose a way for MiniBrowser to simulate header and footer banners
3969         https://bugs.webkit.org/show_bug.cgi?id=166005
3970
3971         Reviewed by Wenson Hsieh.
3972         
3973         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3974         banners. This only works in WebKit2.
3975         
3976         We need to reset these on each navigation, since newly created FrameViews
3977         don't re-fetch the header and footer height stored on Page.
3978         
3979         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3980         as well as fixing webViewWebContentProcessDidTerminate:
3981
3982         * MiniBrowser/mac/SettingsController.h:
3983         * MiniBrowser/mac/SettingsController.m:
3984         (-[SettingsController _populateMenu]):
3985         (-[SettingsController validateMenuItem:]):
3986         (-[SettingsController toggleReserveSpaceForBanners:]):
3987         (-[SettingsController isSpaceReservedForBanners]):
3988         * MiniBrowser/mac/WK2BrowserWindowController.m:
3989         (-[WK2BrowserWindowController didChangeSettings]):
3990         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3991         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3992         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3993         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3994
3995 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3996
3997         Fix iOS test results after r209967.
3998         
3999         Subtracting out the status bar height was erroneously happening for all tests,
4000         not just for flexible viewport tests.
4001         
4002         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
4003
4004         * WebKitTestRunner/PlatformWebView.h:
4005         * WebKitTestRunner/TestController.cpp:
4006         (WTR::TestController::resetStateToConsistentValues):
4007         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4008         (WTR::PlatformWebView::resizeTo):
4009         (WTR::PlatformWebView::setWindowFrame):
4010         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4011         (WTR::PlatformWebView::resizeTo):
4012         (WTR::PlatformWebView::setWindowFrame):
4013         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4014         (WTR::PlatformWebView::resizeTo):
4015         (WTR::PlatformWebView::setWindowFrame):
4016         * WebKitTestRunner/ios/TestControllerIOS.mm:
4017         (WTR::TestController::platformConfigureViewForTest):
4018         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4019         (WTR::PlatformWebView::resizeTo):
4020         (WTR::PlatformWebView::setWindowFrame):
4021
4022 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
4023
4024         [EFL] bump EFL version to 1.18.4
4025         https://bugs.webkit.org/show_bug.cgi?id=166004
4026
4027         Reviewed by Gyuyoung Kim.
4028
4029         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
4030
4031 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4032
4033         Visual viewports: bottom fixed elements disappear behind the keyboard
4034         https://bugs.webkit.org/show_bug.cgi?id=165983
4035         <rdar://problem/29409852>
4036
4037         Reviewed by Simon Fraser.
4038
4039         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4040         the keyboard when it is up.
4041
4042         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4043         (WTR::UIScriptController::inputViewBounds):
4044         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4045         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4046         (WTR::UIScriptController::inputViewBounds):
4047         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4048         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4049         (WTR::viewRectForWindowRect):
4050
4051         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4052         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4053         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4054
4055         (WTR::PlatformWebView::PlatformWebView):
4056         (WTR::PlatformWebView::setWindowFrame):
4057         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4058         (WTR::UIScriptController::inputViewBounds):
4059
4060 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4061
4062         Deleting a character converted from pinyin after an image causes a Safari crash
4063         https://bugs.webkit.org/show_bug.cgi?id=165839
4064         <rdar://problem/27951933>
4065
4066         Reviewed by Wenson Hsieh.
4067
4068         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4069         while the proposed range contains an image. This should not cause a WebProcess to crash
4070         or send an invalid message to the UIProcess.
4071
4072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4073         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4074         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4075         (TestWebKitAPI::didFinishLoadForFrame):
4076         (TestWebKitAPI::processDidCrash):
4077         (TestWebKitAPI::invalidMessageFunction):
4078         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4079
4080 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4081
4082         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4083         https://bugs.webkit.org/show_bug.cgi?id=165767
4084         <rdar://problem/29602382>
4085
4086         Reviewed by Simon Fraser.
4087
4088         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4089         WebKit2 ChangeLog for more details.
4090
4091         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4092         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4093         (WTR::UIScriptController::textSelectionCaretRect):
4094         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4095         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4096         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4097         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4098         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4099         (WTR::UIScriptController::textSelectionCaretRect):
4100         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4101         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4102         (-[TestRunnerWKWebView _setStableStateOverride:]):
4103
4104         Force the WKWebView to update its visible content rects when changing the stable state override.
4105
4106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4107         (WTR::toNSDictionary):
4108         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4109         (WTR::UIScriptController::selectionRangeViewRects):
4110         (WTR::UIScriptController::textSelectionCaretRect):
4111         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4112         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4113
4114 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4115
4116         Arguments called in wrong order
4117         https://bugs.webkit.org/show_bug.cgi?id=165923
4118
4119         Reviewed by Simon Fraser.
4120
4121         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4122         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4123
4124         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4125         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4126         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4127
4128 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4129
4130         [EFL] Disable non-srcdir builds for failing libraries
4131         https://bugs.webkit.org/show_bug.cgi?id=165896
4132
4133         Reviewed by Gyuyoung Kim.
4134
4135         * efl/jhbuild.modules: Set non srcdir builds to no
4136
4137 2016-12-15  Daniel Bates  <dabates@apple.com>
4138
4139         check-style should not complain about code in icu directories
4140         https://bugs.webkit.org/show_bug.cgi?id=53929
4141
4142         Reviewed by Darin Adler.
4143
4144         Skip style checking of imported ICU headers to avoid a deluge of style issues
4145         as they do not conform to the WebKit Code Style guideline. We want to preserve
4146         the formatting of these headers so as to make it straightforward to merge
4147         changes to them, if necessary.
4148
4149         * Scripts/webkitpy/style/checker.py:
4150
4151 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4152
4153         Move JSC testers from Yosemite to Sierra
4154         https://bugs.webkit.org/show_bug.cgi?id=165925
4155
4156         Reviewed by Lucas Forschler.
4157
4158         * BuildSlaveSupport/build.webkit.org-config/config.json:
4159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4160         (WebKitBuildbot):
4161
4162 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4163
4164         Add coordinate space to event streams and streamline tests
4165         https://bugs.webkit.org/show_bug.cgi?id=165119
4166
4167         Reviewed by Simon Fraser.
4168
4169         Update event streams to allow for both content and global coordinate space.
4170         Update example script to more accurately show all the available options.
4171
4172         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4173         * WebKitTestRunner/ios/HIDEventGenerator.h:
4174         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4175         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4176         (WTR::convertCoordinates):
4177         (WTR::UIScriptController::sendEventStream):
4178
4179 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4180
4181         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4182         https://bugs.webkit.org/show_bug.cgi?id=165855
4183
4184         Reviewed by Philippe Normand.
4185
4186         GStreamer's autogen.sh enables gtk-doc always so we end up building
4187         docs even if we disable them. Use the configure script instead, since
4188         we build from packages and these include it already.
4189
4190         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4191         upstream gstreamer packages.
4192
4193 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4194
4195         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4196         https://bugs.webkit.org/show_bug.cgi?id=165885
4197         <rdar://problem/29476917>
4198
4199         Reviewed by Darin Adler.
4200
4201         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4202         (TestWebKitAPI::utf16String): Deleted.
4203         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4204         (TestWebKitAPI::TEST_F):
4205         * TestWebKitAPI/WTFStringUtilities.h:
4206         (utf16String):
4207         Moved from URLParser to share with other tests.
4208
4209 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4210
4211         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4212         https://bugs.webkit.org/show_bug.cgi?id=165843
4213
4214         Reviewed by Antti Koivisto.
4215
4216         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4217         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4218         and DumpRenderTree's runUIScript would hit an assertion :(
4219
4220         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4222         (WTR::TestRunner::isWebKit2):
4223
4224 2016-12-14  Brady Eidson  <beidson@apple.com>
4225
4226         IndexedDB 2.0: Massively speedup IDBIndex.get().
4227         https://bugs.webkit.org/show_bug.cgi?id=165802
4228
4229         Reviewed by Alex Christensen.
4230
4231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4232         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4233         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4234         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4235         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4236
4237 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4238
4239         [GTK][EFL] Update the JHBuild version.
4240         https://bugs.webkit.org/show_bug.cgi?id=165838
4241
4242         Reviewed by Michael Catanzaro.
4243
4244         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4245         usage of the JHBUILD_MIRROR feature with git repositories.
4246
4247 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4248
4249         [GTK] Yasm is needed for building the JHBuild after r208940
4250         https://bugs.webkit.org/show_bug.cgi?id=165837
4251
4252         Reviewed by Alejandro G. Castro.
4253
4254         * gtk/install-dependencies: Yasm is needed for building libvpx.
4255
4256 2016-12-14  Youenn Fablet  <youenn@apple.com>
4257
4258         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4259         https://bugs.webkit.org/show_bug.cgi?id=161310
4260
4261         Reviewed by Ryosuke Niwa.
4262
4263         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4264         When set, WTR and DRT output JS console log in the stderr and not the test output.
4265         This allows removing potentially flaky information while still being able to read it for investigation.
4266
4267         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4268
4269         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4270         This test should have this option when fetch API will start logging resource loader errors.
4271
4272         * DumpRenderTree/DumpRenderTree.h:
4273         (TestCommand::TestCommand): Deleted.
4274         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4275         (parseInputLine):
4276         * DumpRenderTree/TestRunner.h:
4277         (TestRunner::setDumpJSConsoleLogInStdErr):
4278         (TestRunner::dumpJSConsoleLogInStdErr):
4279         * DumpRenderTree/mac/DumpRenderTree.mm:
4280         (runTest):
4281         * DumpRenderTree/mac/UIDelegate.mm:
4282         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4283         * DumpRenderTree/win/DumpRenderTree.cpp:
4284         (runTest):
4285         * DumpRenderTree/win/UIDelegate.cpp:
4286         (UIDelegate::webViewAddMessageToConsole):
4287         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4288         (TestExpectationParser._tokenize_line):
4289         * Scripts/webkitpy/port/driver.py:
4290         (Driver._command_from_driver_input):
4291         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4292         (WTR::InjectedBundle::didReceiveMessageToPage):
4293         (WTR::InjectedBundle::dumpToStdErr):
4294         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4295         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4296         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4297         (WTR::InjectedBundlePage::willAddMessageToConsole):
4298         * WebKitTestRunner/TestController.cpp:
4299         (WTR::parseInputLine):
4300         (WTR::TestController::runTest):
4301         (WTR::TestCommand::TestCommand): Deleted.
4302         * WebKitTestRunner/TestInvocation.cpp:
4303         (WTR::TestInvocation::invoke):
4304         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4305         * WebKitTestRunner/TestInvocation.h:
4306         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4307
4308
4309 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4310