REGRESSION(r168471): Duplicate builddirs broke the build master.
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         REGRESSION(r168471): Duplicate builddirs broke the build master.
4         https://bugs.webkit.org/show_bug.cgi?id=132688
5
6         Reviewed by Carlos Garcia Campos.
7
8         Rename the builddirs of the new GTK bots introduced on r168471 to
9         be unique. Otherwise the master will break.
10
11         * BuildSlaveSupport/build.webkit.org-config/config.json:
12
13 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
14
15         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
16         https://bugs.webkit.org/show_bug.cgi?id=132674
17
18         Reviewed by Philippe Normand.
19
20         Only ignore mkdir failure when exception is raised because the
21         file already exists and it's a directory.
22
23         * gtk/webkitdom.py:
24         (write_doc_files):
25
26 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
27
28         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
29         https://bugs.webkit.org/show_bug.cgi?id=131358
30
31         Reviewed by Carlos Garcia Campos.
32
33         Current 64-bit GTK build bots (Release and Debug) not only test
34         the build, but run all tests. Split each one of the bots in
35         BuildOnly and TestWebKit2.
36
37         This will allow us to have a better overview of the status of
38         the GTK port.
39
40         Original patch from Sergio Villar Senin <svillar@igalia.com>
41
42         * BuildSlaveSupport/build.webkit.org-config/config.json:
43         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
44         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
45         (WebKitBuildbot):
46         * Scripts/webkitpy/port/builders.py:
47         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
48         (TestRebaselineTest.test_baseline_directory):
49         * TestResultServer/static-dashboards/builders.jsonp:
50         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
51         (resetGlobals):
52         * TestResultServer/static-dashboards/loader_unittests.js:
53
54 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
55
56         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
57         https://bugs.webkit.org/show_bug.cgi?id=126022
58
59         Reviewed by Benjamin Poulain.
60
61         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
62
63         Added an unit test case to check if scroll position and scale are restored properly.
64
65         * TestWebKitAPI/PlatformEfl.cmake:
66         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
67         (TestWebKitAPI::didFinishLoadForFrame):
68         (TestWebKitAPI::didChangeContentsPosition):
69         (TestWebKitAPI::TEST):
70         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
71         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
72
73 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
74
75         WebKit1 is flashy when compositing layers come and go
76         https://bugs.webkit.org/show_bug.cgi?id=132655
77         <rdar://problem/16830981&16788846>
78
79         Reviewed by Sam Weinig.
80         
81         Revert the change from r166117.
82
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (updateDisplay):
85
86 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
87
88         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
89         https://bugs.webkit.org/show_bug.cgi?id=132622
90
91         Reviewed by Mario Sanchez Prada.
92
93         * DumpRenderTree/AccessibilityUIElement.cpp:
94         (selectTextWithCriteriaCallback):
95         (isEqualCallback):
96         * DumpRenderTree/AccessibilityUIElement.h:
97         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
98         (AccessibilityUIElement::selectTextWithCriteria):
99         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
100         (AccessibilityUIElement::selectTextWithCriteria):
101         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
102         (selectTextParameterizedAttributeForCriteria):
103         (AccessibilityUIElement::selectTextWithCriteria):
104         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
105         (AccessibilityUIElement::selectTextWithCriteria):
106         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
107         (WTR::AccessibilityUIElement::selectTextWithCriteria):
108         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
109         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
110         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
111         (WTR::AccessibilityUIElement::selectTextWithCriteria):
112         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
113         (WTR::AccessibilityUIElement::selectTextWithCriteria):
114         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
115         (WTR::selectTextParameterizedAttributeForCriteria):
116         (WTR::AccessibilityUIElement::selectTextWithCriteria):
117
118 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
119
120         [SOUP] TLSErrors do not cause page load to fail when not ignored
121         https://bugs.webkit.org/show_bug.cgi?id=121548
122
123         Reviewed by Sergio Villar Senin.
124
125         Add unit tests to check that the load fails with TLS errors in
126         case of a redirection.
127
128         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
129         (testTLSErrorsRedirect):
130         (httpsServerCallback):
131         (beforeAll):
132
133 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
134
135         [CSS Grid Layout] Remove runtime feature
136         https://bugs.webkit.org/show_bug.cgi?id=132382
137
138         Reviewed by Benjamin Poulain.
139
140         Remove cssGridLayoutEnabled setting usage.
141
142         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
143         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
144         * DumpRenderTree/efl/TestRunnerEfl.cpp:
145         (TestRunner::overridePreference):
146         * DumpRenderTree/mac/DumpRenderTree.mm:
147         (resetWebPreferencesToConsistentValues):
148
149 2014-05-06  David Kilzer  <ddkilzer@apple.com>
150
151         Add Makefile targets for copying static libraries (LLVM and WKSI)
152         <http://webkit.org/b/132619>
153
154         Reviewed by Mark Rowe.
155
156         * Scripts/copy-webkitlibraries-to-product-directory: Set a
157         sensible default for product directory if not specified on
158         either the command-line or in the environment (by Xcode) by
159         calling productDir() in webkitdirs.pm.
160
161 2014-05-06  Brady Eidson  <beidson@apple.com>
162
163         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
164         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
165
166         Reviewed by Sam Weinig.
167
168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
169
170         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
171         (TestWebKitAPI::itemURLLastComponentIsString):
172         (TestWebKitAPI::didFinishLoadForFrame):
173         (TestWebKitAPI::willGoToBackForwardListItem):
174         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
175         (TestWebKitAPI::setPageLoaderClient):
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
178         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
179
180         * WebKitTestRunner/TestController.cpp:
181         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
182
183 2014-05-06  Darin Adler  <darin@apple.com>
184
185         Try to fix iOS build.
186
187         * DumpRenderTree/mac/TestRunnerMac.mm:
188         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
189         Updated since I changed testRunner into a pointer instead of a reference.
190         Updated argument names to avoid conflict with field names.
191         (-[APITestDelegateIPhone run]): Ditto.
192         (-[APITestDelegateIPhone _cleanUp]): Ditto.
193
194 2014-05-06  Commit Queue  <commit-queue@webkit.org>
195
196         Unreviewed, rolling out r168304.
197         https://bugs.webkit.org/show_bug.cgi?id=132607
198
199         Broke the build (Requested by KaL on #webkit).
200
201         Reverted changeset:
202
203         "[GTK][CMake] Unable to do make install"
204         https://bugs.webkit.org/show_bug.cgi?id=130188
205         http://trac.webkit.org/changeset/168304
206
207 2014-05-04  Darin Adler  <darin@apple.com>
208
209         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
210         https://bugs.webkit.org/show_bug.cgi?id=80222
211
212         Reviewed by Alexey Proskuryakov.
213
214         * DumpRenderTree/mac/TestRunnerMac.mm:
215         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
216         do more work here so we don't use RetainPtr local variables.
217         (-[APITestDelegateIPhone dealloc]): Added.
218         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
219         created. Updated for changes to member names and types.
220         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
221         updated for changes to member names and types. Changed to two word spelling.
222         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
223         name of _cleanUp method.
224         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
225         Ditto.
226         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
227
228 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
229
230         Clean up Image Document and tweak the layout and viewport
231         https://bugs.webkit.org/show_bug.cgi?id=132552
232
233         Reviewed by Anders Carlsson.
234
235         * DumpRenderTree/mac/DumpRenderTree.mm:
236         (resetWebPreferencesToConsistentValues):
237         Update the default settings to have something consistent with WebKit2.
238
239 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
240
241         [GTK][CMake] Unable to do make install
242         https://bugs.webkit.org/show_bug.cgi?id=130188
243
244         Reviewed by Carlos Garcia Campos.
245
246         * Scripts/webkitdirs.pm:
247         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
248         will give an early signal that a change has broken the documentation.
249
250 2014-05-05  Pratik Solanki  <psolanki@apple.com>
251
252         Update framework locations in package-root
253         https://bugs.webkit.org/show_bug.cgi?id=132571
254
255         Reviewed by Simon Fraser.
256
257         * Scripts/package-root:
258
259 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
260
261         [EFL][WK2] Refactor favicon database APIs
262         https://bugs.webkit.org/show_bug.cgi?id=132519
263
264         Reviewed by Gyuyoung Kim.
265
266         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
267         (update_view_favicon):
268         (on_icon_changed_cb):
269         (window_free):
270         (on_url_changed):
271         (window_create):
272         (on_view_favicon_changed): Deleted.
273
274 2014-05-02  Mark Rowe  <mrowe@apple.com>
275
276         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
277
278         Reviewed by Dan Bernstein.
279
280         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
281         when determining which LLVM archive to extract.
282
283 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
284
285         Add Jeremy as a committer.
286         https://bugs.webkit.org/show_bug.cgi?id=132492
287
288         Reviewed by Jer Noble.
289
290         Add myself as a committer.
291
292         * Scripts/webkitpy/common/config/contributors.json:
293
294 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
295
296         Add Jeremy as a committer.
297         https://bugs.webkit.org/show_bug.cgi?id=132492
298
299         Reviewed by Jer Noble.
300
301         Add Jeremy Jones to the committers file.
302
303         * Scripts/webkitpy/common/config/contributors.json:
304
305 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
306
307         Hard to figure out how to run a single test with run-api-tests
308         https://bugs.webkit.org/show_bug.cgi?id=116332
309
310         Reviewed by Alexey Proskuryakov.
311
312         * Scripts/run-api-tests: add two examples to the help message.
313
314 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
315
316         Fix several memory leaks found by code inspection
317         https://bugs.webkit.org/show_bug.cgi?id=132472
318
319         Reviewed by Geoffrey Garen.
320         
321         Fix memory leaks.
322
323         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
324         (TestWebKitAPI::TEST):
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
326         (WTR::InjectedBundlePage::willSendRequestForFrame):
327         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
328         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
329
330 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
331
332         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
333         https://bugs.webkit.org/show_bug.cgi?id=132446
334
335         Reviewed by Mark Hahnenberg.
336         
337         Test the FTL by default now that it's enabled by default.
338
339         * Scripts/run-javascriptcore-tests:
340
341 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
342
343         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
344         https://bugs.webkit.org/show_bug.cgi?id=132240
345
346         Reviewed by Anders Carlsson.
347
348         Removed ewk_view_setting_tiled_backingstore related code.
349
350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
351         (DumpRenderTreeChrome::createView):
352         (shouldUseTiledBackingStore): Deleted.
353         * EWebLauncher/main.c:
354         (windowCreate):
355         (parseUserArguments):
356
357 2014-05-01  Anders Carlsson  <andersca@apple.com>
358
359         window.testRunner.keepWebHistory() should update the UI process state
360         https://bugs.webkit.org/show_bug.cgi?id=132440
361
362         Reviewed by Dan Bernstein.
363
364         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
365         (WTR::InjectedBundle::postSetAddsVisitedLinks):
366         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
368         (WTR::TestRunner::keepWebHistory):
369         * WebKitTestRunner/TestInvocation.cpp:
370         (WTR::TestInvocation::invoke):
371         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
372
373 2014-05-01  David Kilzer  <ddkilzer@apple.com>
374
375         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
376         <http://webkit.org/b/132432>
377
378         Reviewed by Tim Horton.
379
380         * Scripts/webkitperl/FeatureList.pm: Remove support for
381         --plugin-proxy-for-video switch.
382
383 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
384
385         Kernel sysctl interface hw.activecpu don't exists on Linux.
386         https://bugs.webkit.org/show_bug.cgi?id=132286
387
388         Reviewed by Filip Pizlo.
389
390         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
391         calling sysctl over hw.activecpu
392
393 2014-04-30  Anders Carlsson  <andersca@apple.com>
394
395         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
396         https://bugs.webkit.org/show_bug.cgi?id=132399
397         <rdar://problem/15920046>
398
399         Reviewed by Dan Bernstein.
400
401         * Scripts/check-for-webkit-framework-include-consistency:
402         Allos WAK headers in WebKitLegacy as well as WebKit.
403
404         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
405         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
406         Update header imports.
407
408 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
409
410         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
411         https://bugs.webkit.org/show_bug.cgi?id=131954
412
413         Reviewed by Darin Adler.
414         
415         WebKitTestRunner was adding application-specific information to crash reports
416         to log the test path, but only in the web process. Fix it to also do this
417         for the UI process, for both iOS and OS X.
418         
419         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
420         both iOS and OS X.
421         
422         Factored crash reprorter-related code into CrashReporterInfo, and call it from
423         a new TestController::platformWillRunTest() function on Mac and iOS.
424         
425         Also remove Xcode-added unit test junk from the project.
426
427         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
428         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
429         * WebKitTestRunner/TestController.cpp:
430         (WTR::TestController::runTest):
431         * WebKitTestRunner/TestController.h:
432         * WebKitTestRunner/TestInvocation.cpp:
433         (WTR::TestInvocation::url):
434         * WebKitTestRunner/TestInvocation.h:
435         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
436         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
437         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
438         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
439         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
440         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
441         (WTR::testPathFromURL):
442         (WTR::setCrashReportApplicationSpecificInformationToURL):
443         * WebKitTestRunner/efl/TestControllerEfl.cpp:
444         (WTR::TestController::platformWillRunTest):
445         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
446         (WTR::TestController::platformWillRunTest):
447         * WebKitTestRunner/ios/TestControllerIOS.mm:
448         (WTR::TestController::platformWillRunTest):
449         (WTR::TestController::setHidden):
450         * WebKitTestRunner/mac/TestControllerMac.mm:
451         (WTR::TestController::platformWillRunTest):
452
453 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
454
455         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
456
457         Reviewed by Tim Horton.
458
459         * DumpRenderTree/mac/DumpRenderTree.mm:
460         (resetWebPreferencesToConsistentValues):
461         (prepareConsistentTestingEnvironment):
462
463 2014-04-30  Anders Carlsson  <andersca@apple.com>
464
465         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
466         https://bugs.webkit.org/show_bug.cgi?id=132397
467
468         Reviewed by Dan Bernstein.
469
470         * Scripts/check-for-inappropriate-macros-in-external-headers:
471
472 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
473
474         [GTK] Make it easier to run CMake for downstreams
475         https://bugs.webkit.org/show_bug.cgi?id=132370
476
477         Reviewed by Carlos Garcia Campos.
478
479         * Scripts/webkitdirs.pm:
480         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
481         the GTK+ port.
482
483 2014-04-29  Stephanie Lewis  <slewis@apple.com>
484
485         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
486         
487         Rubber stamped by Jessie Berlin.
488
489         JSON.pm was removed from our tools setup.
490
491         * Scripts/generate-coverage-data:
492
493 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
494
495         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
496         https://bugs.webkit.org/show_bug.cgi?id=112840
497
498         Rubber stamped by Geoffrey Garen.
499
500         * Scripts/build-jsc: Enable it on Mac.
501         * Scripts/build-webkit: Enable it on Mac.
502         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
503
504 2014-04-28  Sam Weinig  <sam@webkit.org>
505
506         REGRESSION (r167751): svn-create-patch is very slow
507         https://bugs.webkit.org/show_bug.cgi?id=132300
508
509         Reviewed by Alexey Proskuryakov.
510
511         * Scripts/svn-create-patch:
512         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
513         by calling `svn-create-patch --style`.
514
515 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
516
517         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
518         https://bugs.webkit.org/show_bug.cgi?id=132190
519
520         Reviewed by Gustavo Noronha Silva.
521
522         * Scripts/webkitdirs.pm:
523         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
524             if ninja is in the path.
525         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
526             to the previous ninja generator if not.
527
528 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
529
530         check-webkit-style should understand --git-index
531         https://bugs.webkit.org/show_bug.cgi?id=125364
532
533         Reviewed by Csaba Osztrogonác.
534
535         * Scripts/webkitpy/common/checkout/scm/git.py:
536         (Git.create_patch): The command now supports the --cached option.
537         * Scripts/webkitpy/style/main.py:
538         (CheckWebKitStyle.main): Passing the --git-index option.
539         * Scripts/webkitpy/style/optparser.py:
540         (CommandOptionValues.__init__): The git-index option is switched off by default.
541         (CommandOptionValues.__eq__): Equality check for the new option.
542         (ArgumentParser._create_option_parser):Adding the --git-index option
543         (ArgumentParser.parse):
544         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
545         (CommandOptionValuesTest.test_init): 
546         (CommandOptionValuesTest.test_eq):
547
548 2014-04-28  Michael Saboff  <msaboff@apple.com>
549
550         Crash in platform/mac/accessibility/table-visible-rows.html
551         https://bugs.webkit.org/show_bug.cgi?id=132146
552
553         Reviewed by Filip Pizlo.
554
555         Instead of creating a local JSValueRef array on the stack and passing that to
556         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
557         values using the JSObjectSetPropertyAtIndex() API.
558
559         * DumpRenderTree/AccessibilityUIElement.cpp:
560         (elementsForRangeCallback):
561         (convertElementsToObjectArray):
562         * DumpRenderTree/mac/TestRunnerMac.mm:
563         (originsArrayToJS):
564         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
565         (WTR::EventSendingController::contextClick):
566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
567         (WTR::stringArrayToJS):
568         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
569         (WTR::convertElementsToObjectArray):
570
571 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
572
573         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
574         "no-cjit" runs force the old-school threshold.
575
576         Rubber stamped by Mark Hahnenberg.
577
578         * Scripts/run-jsc-stress-tests:
579
580 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
581
582         [GTK] install-dependencies should also install ruby-json and ruby-highline
583         https://bugs.webkit.org/show_bug.cgi?id=132292
584
585         Reviewed by Philippe Normand.
586
587         * gtk/install-dependencies: Install ruby json and highline packages.
588
589 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
590
591         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
592         https://bugs.webkit.org/show_bug.cgi?id=132176
593
594         Reviewed by Gyuyoung Kim.
595
596         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
597         and turn off indexedDB feature until the sqlite implementation is introduced.
598
599         * Scripts/webkitperl/FeatureList.pm:
600
601 2014-04-25  James Craig  <jcraig@apple.com>
602
603         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
604         https://bugs.webkit.org/show_bug.cgi?id=132209
605
606         Reviewed by Daniel Bates.
607
608         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
609         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
610
611         * Scripts/prepare-ChangeLog:
612         (main): 
613
614 2014-04-25  Michael Saboff  <msaboff@apple.com>
615
616         Crash in platform/mac/accessibility/table-visible-rows.html
617         https://bugs.webkit.org/show_bug.cgi?id=132146
618
619         Reviewed by Mark Lam.
620
621         Changed to use a local JSValueRef array temporary instead of a
622         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
623         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
624         the temporary values could be collected.
625
626         * DumpRenderTree/AccessibilityUIElement.cpp:
627         (convertElementsToObjectArray):
628         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
629         (WTR::EventSendingController::contextClick):
630         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
631         (WTR::convertElementsToObjectArray):
632
633 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
634
635         Unreviewed GTK gardening
636
637         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
638         (TestRunner):
639
640 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
641
642         prepare-ChangeLog reports as deleted methods that has not been removed.
643         https://bugs.webkit.org/show_bug.cgi?id=131733
644
645         Reviewed by Ryosuke Niwa.
646
647         * Scripts/prepare-ChangeLog:
648         (originalFile): Set merge base to origin/master by default.
649
650 2014-04-23  James Craig  <jcraig@apple.com>
651
652         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
653         https://bugs.webkit.org/show_bug.cgi?id=131115
654
655         Reviewed by Daniel Bates.
656
657         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
658
659         * Scripts/commit-log-editor: Added --no-style.
660         * Scripts/prepare-ChangeLog: Primary patch.
661         (main): Primary patch.
662         (createPatchCommand): Added --no-style.
663         * Scripts/svn-create-patch: Primary patch.
664         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
665         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
666         (SVN.create_patch): Added --no-style.
667
668 2014-04-23  Anders Carlsson  <andersca@apple.com>
669
670         Try to fix iOS build.
671
672         * DumpRenderTree/mac/DumpRenderTree.mm:
673
674 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
675
676         Eliminate internals.setMockScrollbarsEnabled()
677         https://bugs.webkit.org/show_bug.cgi?id=132085
678
679         Reviewed by Tim Horton.
680
681         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
682         No need to reset the preference, there is no way it can change.
683
684 2014-04-23  James Craig  <jcraig@apple.com>
685
686         Unreviewed. Moving myself from Contributors to Committers list.
687
688         * Scripts/webkitpy/common/config/contributors.json:
689
690 2014-04-23  Tim Horton  <timothy_horton@apple.com>
691
692         Mock scrollbars don't always work in DumpRenderTree
693         https://bugs.webkit.org/show_bug.cgi?id=132082
694
695         Reviewed by Alexey Proskuryakov.
696
697         * DumpRenderTree/mac/DumpRenderTree.mm:
698         (prepareConsistentTestingEnvironment):
699         Set the mock scrollbar setting before creating the WebView, as this setting
700         cannot be dynamically changed, so any scrollbars that are created during
701         WebView initialization and are not replaced before snapshotting will end
702         up being platform scrollbars instead of mock ones.
703         WebKitTestRunner already sets this preference before creating WKViews,
704         so we're just matching its behavior.
705
706 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [GTK] ShadowRoot API was removed in r164131
709         https://bugs.webkit.org/show_bug.cgi?id=132059
710
711         Reviewed by Gustavo Noronha Silva.
712
713         Add WebKitDOMShadowRoot to the list of deleted classes to generate
714         the API docs.
715
716         * gtk/webkitdom.py:
717         (WebKitDOMDocGenerator):
718
719 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
720
721         [GTK] run-webkit-tests script is failing to invoke run-launcher
722         https://bugs.webkit.org/show_bug.cgi?id=132051
723
724         Reviewed by Philippe Normand.
725
726         After the WK1 support was dropped, if run-webkit-tests is executed
727         without --no-show-results parameter, the launcher is being called
728         using a -2 parameter that is it causing the run-launcher to break.
729
730         * Scripts/webkitpy/port/gtk.py:
731         (GtkPort.show_results_html_file):
732
733 2014-04-22  Tim Horton  <timothy_horton@apple.com>
734
735         DumpRenderTree generates black snapshots on some platforms
736         https://bugs.webkit.org/show_bug.cgi?id=132029
737         <rdar://problem/16679363>
738
739         Reviewed by Simon Fraser.
740
741         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
742         (createBitmapContextFromWebView):
743         DRT checks with the WebView to determine whether it can use the window's
744         backing store directly or (because of compositing) needs to take a WindowServer
745         snapshot. However, on some platforms and in some situations, the window can
746         be layer backed without the WebView necessarily currently being composited.
747         We should check with the window in addition to the WebView before going
748         ahead and using its backing store.
749
750 2014-04-22  Tim Horton  <timothy_horton@apple.com>
751
752         DumpRenderTree generates white snapshots on some platforms
753         https://bugs.webkit.org/show_bug.cgi?id=132026
754         <rdar://problem/16679363>
755
756         Reviewed by Simon Fraser.
757
758         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
759         Link DRT against QuartzCore.
760
761         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
762         (createBitmapContextFromWebView):
763         Force CoreAnimation to synchronously update layers in a more explicit
764         way that doesn't depend on AppKit behavior. This is very similar to what
765         WebKitTestRunner does (indirectly) during its force repaint.
766
767 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
768
769         [Win] Support Python 2.7 in Cygwin
770         https://bugs.webkit.org/show_bug.cgi?id=132023
771
772         Reviewed by Michael Saboff.
773
774         * Scripts/webkitdirs.pm:
775         (checkInstalledTools): Remove check for Python 2.7, since
776         it now works properly.
777
778 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
779
780         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
781         https://bugs.webkit.org/show_bug.cgi?id=130867
782         <rdar://problem/16432456> 
783
784         Reviewed by Mark Hahnenberg.
785
786         * Scripts/build-webkit:
787         * Scripts/copy-webkitlibraries-to-product-directory:
788
789 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
790
791         [GTK] Fails to build documentation when output is redirected
792         https://bugs.webkit.org/show_bug.cgi?id=131178
793
794         Reviewed by Martin Robinson.
795
796         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
797         explicitly to avoid encoding issues when they are redirected.
798
799 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
800
801         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
802         https://bugs.webkit.org/show_bug.cgi?id=131911
803
804         Reviewed by Martin Robinson.
805
806         common.get_build_path returns release path even though Debug configuration
807         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
808
809         * gtk/ycm_extra_conf.py:
810         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
811         (FlagsForFile):
812
813 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
814
815         Unreviewed build fix.
816
817         * DumpRenderTree/mac/EventSendingController.mm:
818         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
819         Correct a typo that prevented tests from working properly.
820
821 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
822
823         [GTK] Should have the ability to output composited contents during layout testing
824         https://bugs.webkit.org/show_bug.cgi?id=131864
825
826         Reviewed by Philippe Normand.
827
828         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
829         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
830         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
831         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
832         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
833
834 2014-04-21  Sam Weinig  <sam@webkit.org>
835
836         Attempt to fix the tests.
837
838         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
839         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
840         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
841
842 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
843
844         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
845         being the same as a "quick run", which is meant for genuinely slow tests).
846
847         * Scripts/run-jsc-stress-tests:
848
849 2014-04-21  Darin Adler  <darin@apple.com>
850
851         Add HashSet::takeAny
852         https://bugs.webkit.org/show_bug.cgi?id=131928
853
854         Reviewed by Benjamin Poulain.
855
856         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
857
858 2014-04-20  Dan Bernstein  <mitz@apple.com>
859
860         Fixed a test timing out after r167572.
861
862         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
863         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
864         -webView:didFinishLoadingNavigation:.
865
866 2014-04-20  Commit Queue  <commit-queue@webkit.org>
867
868         Unreviewed, rolling out r167510.
869         https://bugs.webkit.org/show_bug.cgi?id=131915
870
871         broke GTK Debug bot (Requested by philn on #webkit).
872
873         Reverted changeset:
874
875         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
876         it when running layout tests"
877         https://bugs.webkit.org/show_bug.cgi?id=131472
878         http://trac.webkit.org/changeset/167510
879
880 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
881
882         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
883         https://bugs.webkit.org/show_bug.cgi?id=131472
884
885         Reviewed by Philippe Normand.
886
887         * Scripts/webkitpy/port/gtk.py:
888         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
889         when running WebKitTestRunner with run-webkit-tests.
890         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
891         installed.
892         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
893         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
894         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
895         deal.
896
897 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
898
899         DownloadDecideDestinationCrash API test uses an incorrect value for path
900         https://bugs.webkit.org/show_bug.cgi?id=131845
901         <rdar://problem/15925560>
902
903         Reviewed by Enrica Casucci.
904
905         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
906         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
907
908 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
909
910         [Mac] AttributedStringTest API tests fail with async text input
911         https://bugs.webkit.org/show_bug.cgi?id=131833
912
913         Reviewed by Enrica Casucci.
914
915         Don't run sync NSTextInputClient tests where we don't implement these calls.
916
917         * TestWebKitAPI/Tests/mac/AttributedString.mm:
918         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
919         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
920         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
921         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
922         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
923         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
924
925 2014-04-18  Philippe Normand  <pnormand@igalia.com>
926
927         Remove NETWORK_INFO support
928         https://bugs.webkit.org/show_bug.cgi?id=131841
929
930         Reviewed by Gyuyoung Kim.
931
932         * Scripts/webkitperl/FeatureList.pm:
933
934 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
935
936         [GTK] YouCompleteMe doesn't work for cmake build system.
937         https://bugs.webkit.org/show_bug.cgi?id=131591
938
939         Reviewed by Martin Robinson.
940
941         Add cmake build system support for YouCompleteMe. It should work regardless of
942         using make or ninja. In addition, autotools related code is removed since it's
943         not used anymore in WebKit.
944
945         * Scripts/webkitdirs.pm:
946         (generateBuildSystemFromCMakeProject):
947         * gtk/ycm_extra_conf.py:
948         (transform_relative_paths_to_absolute_paths):
949         (FlagsForFile):
950
951 2014-04-17  Anders Carlsson  <andersca@apple.com>
952
953         Fix build.
954
955         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
956         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
957         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
958
959 2014-04-17  Anders Carlsson  <andersca@apple.com>
960
961         Remove unused API enums
962         https://bugs.webkit.org/show_bug.cgi?id=131836
963
964         Reviewed by Tim Horton.
965
966         * MiniBrowser/mac/WK2BrowserWindowController.m:
967         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
968
969 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
970
971         [Win] A few final cleanups to the DataObject classes.
972         https://bugs.webkit.org/show_bug.cgi?id=131784
973
974         Reviewed by Anders Carlsson.
975
976         * DumpRenderTree/win/DRTDataObject.cpp:
977         (DRTDataObject::clearData): Use 'last()' method.
978         * DumpRenderTree/win/UIDelegate.cpp:
979         (DRTUndoStack::pop): Use 'takeLast()' method.
980
981 2014-04-17  Andres Gomez  <agomez@igalia.com>
982
983         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
984         https://bugs.webkit.org/show_bug.cgi?id=131365
985
986         Reviewed by Brent Fulgham.
987
988         The cygwin installer is now downloading the wanted versions for
989         the local installation given to the setup wizard.
990
991         * CygwinDownloader/cygwin-downloader.py:
992         * CygwinDownloader/cygwin-downloader.zip:
993
994 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
995
996         [GTK] Make run-webkit-tests always use WKTR
997         https://bugs.webkit.org/show_bug.cgi?id=131737
998
999         Reviewed by Darin Adler.
1000
1001         Now that the GTK+ port only has support for WebKit2, instruct
1002         run-webkit-tests to always use WKTR. This avoids needing to pass
1003         flag "-2" every time.
1004
1005         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1006         (_set_up_derived_options): Always set webkit_test_runner when
1007         the platform is GTK+.
1008
1009 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1010
1011         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1012         https://bugs.webkit.org/show_bug.cgi?id=131760
1013
1014         Reviewed by Philippe Normand.
1015
1016         * gtk/install-dependencies: Install ninja-build when it's available.
1017
1018 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1019
1020         [Win] run-javascriptcore-tests fails to run.
1021         https://bugs.webkit.org/show_bug.cgi?id=131761
1022
1023         Reviewed by Brent Fulgham.
1024
1025         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1026
1027 2014-04-16  Andres Gomez  <agomez@igalia.com>
1028
1029         [Win] Pass default parameters to cygwin setup wizard
1030         https://bugs.webkit.org/show_bug.cgi?id=131361
1031
1032         Reviewed by Brent Fulgham.
1033
1034         Added some parameters to the cygwin setup wizard so the user
1035         doesn't really have to do any interaction.
1036
1037         * CygwinDownloader/cygwin-downloader.py:
1038         * CygwinDownloader/cygwin-downloader.zip:
1039
1040 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1041
1042         [Win] Eliminate use of deleteAllValues in Windows Files
1043         https://bugs.webkit.org/show_bug.cgi?id=131631
1044
1045         Reviewed by Darin Adler.
1046
1047         Switch to std::unique_ptr for memory lifetime. Get rid of
1048         deleteAllValues now that it is no longer needed. Use ranged
1049         for loops where possible.
1050
1051         * DumpRenderTree/win/DRTDataObject.cpp:
1052         (WCEnumFormatEtc::WCEnumFormatEtc):
1053         (DRTDataObject::~DRTDataObject):
1054         (DRTDataObject::GetData):
1055         (DRTDataObject::QueryGetData):
1056         (DRTDataObject::SetData):
1057         (DRTDataObject::clearData):
1058         * DumpRenderTree/win/DRTDataObject.h:
1059         * DumpRenderTree/win/UIDelegate.cpp:
1060         (DRTUndoObject::DRTUndoObject):
1061         (DRTUndoObject::~DRTUndoObject):
1062         (DRTUndoStack::~DRTUndoStack):
1063         (DRTUndoStack::clear):
1064         (DRTUndoStack::pop):
1065         (DRTUndoManager::DRTUndoManager):
1066         (DRTUndoManager::redo):
1067         (DRTUndoManager::undo):
1068         (UIDelegate::UIDelegate):
1069         (UIDelegate::resetUndoManager):
1070         * DumpRenderTree/win/UIDelegate.h:
1071
1072 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1073
1074         [GTK] Unreviewed GTK gardening.
1075
1076         Update list of skipped unit tests:
1077
1078           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1079
1080           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1081           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1082
1083         * Scripts/run-gtk-tests:
1084         (TestRunner):
1085
1086 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1087
1088         check-webkit-style doesn't check code style in .mm or .m files
1089         https://bugs.webkit.org/show_bug.cgi?id=131708
1090
1091         Reviewed by Darin Adler.
1092
1093         * Scripts/webkitpy/style/checker.py:
1094         * Scripts/webkitpy/style/checker_unittest.py:
1095         (CheckerDispatcherDispatchTest.test_cpp_paths):
1096         (CheckerDispatcherDispatchTest.test_text_paths):
1097         Check .mm and .m files as C++.
1098
1099         * Scripts/webkitpy/style/checkers/cpp.py:
1100         (check_spacing):
1101         Add an override for our ordinary "missing spaces around =" for @synthesize,
1102         which should look like "@synthesize propertyName=_varName;"
1103
1104         Add an override for "missing space before {" for blocks' "^{".
1105
1106         Don't follow the "extra space before [" rule for Objective-C, because
1107         it breaks this rule in a multitude of ways because of method calls.
1108
1109         (check_braces):
1110         Don't complain about { not being on the end of the previous line if
1111         the previous line starts with "- (" or "+ (", which would indicate a
1112         Objective-C method definition.
1113
1114 2014-04-16  Darin Adler  <darin@apple.com>
1115
1116         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1117         https://bugs.webkit.org/show_bug.cgi?id=131735
1118
1119         Reviewed by Alexey Proskuryakov.
1120
1121         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1122         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1123         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1124         way, but gtest works better this way.
1125
1126 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1127
1128         [EFL] Fix problems with the pixel dump.
1129         https://bugs.webkit.org/show_bug.cgi?id=131265
1130
1131         Reviewed by Gyuyoung Kim.
1132
1133         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1134         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1135         which causes that nothing is drawn.
1136
1137         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1138         One of new functions is AcceleratedCompositingContext::extractImageData(),
1139         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1140         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1141
1142         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1143         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1144
1145 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1146
1147         Update LLVM export scrpt to handle the build directory being different from the
1148         source directory.
1149
1150         Rubber stamped by Geoffrey Garen.
1151
1152         * Scripts/export-llvm-build:
1153
1154 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1155
1156         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1157         https://bugs.webkit.org/show_bug.cgi?id=131695
1158
1159         Reviewed by Antti Koivisto.
1160
1161         Updated.
1162
1163         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1164
1165 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1166
1167         [GTK] Reduce the binary size by compressing the text based web inspector resources
1168         https://bugs.webkit.org/show_bug.cgi?id=121545
1169
1170         Reviewed by Gustavo Noronha Silva.
1171
1172         Compress text based files when compiling inspector resources. It
1173         reduces the binary size in 3MB.
1174
1175         * gtk/generate-inspector-gresource-manifest.py:
1176         (find_all_files_in_directory):
1177         (is_compressible):
1178
1179 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1180
1181         Remove Gtk WebKit1 tester.
1182
1183         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1184         results over and over as fast as it could.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1187         (WebKitBuildbot):
1188
1189 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1190
1191         Wrong link for webkitpy tests results in dashboard popover
1192         https://bugs.webkit.org/show_bug.cgi?id=131664
1193
1194         Reviewed by Timothy Hatcher.
1195
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1197         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1198         Use a correct link.
1199
1200 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1201
1202         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1203
1204         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1205
1206         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1207         (CommitMessageForThisCommitTest):
1208
1209 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1210
1211         Fix commit-log-editor bug revealed by r165447
1212         https://bugs.webkit.org/show_bug.cgi?id=130676
1213
1214         Reviewed by Csaba Osztrogonác.
1215
1216         * Scripts/commit-log-editor:
1217         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1218         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1219         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1220         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1221
1222 2014-04-13  Darin Adler  <darin@apple.com>
1223
1224         userVisibleString should not try to "encode" host names
1225         https://bugs.webkit.org/show_bug.cgi?id=131587
1226         rdar://problem/14686849
1227
1228         Reviewed by Alexey Proskuryakov.
1229
1230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1231
1232         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1233         Coverage is tiny at this point; we could add a lot more cases!
1234
1235 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1236
1237         Use #include instead of #import
1238         https://bugs.webkit.org/show_bug.cgi?id=131604
1239
1240         Reviewed by Darin Adler.
1241
1242         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1243
1244         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1245
1246 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1247
1248         Make slow-stress tests run faster by running fewer VM variants.
1249
1250         Rubber stamped by Geoffrey Garen.
1251
1252         * Scripts/run-javascriptcore-tests:
1253         * Scripts/run-jsc-stress-tests:
1254
1255 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1256
1257         [CMake] Add missing WTF unit tests
1258         https://bugs.webkit.org/show_bug.cgi?id=131459
1259
1260         Reviewed by Martin Robinson.
1261
1262         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1263         that should be compiled into the TestWTF binary.
1264
1265 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1266
1267         [Gtk] run-launcher doesn't work by default
1268         https://bugs.webkit.org/show_bug.cgi?id=131494
1269
1270         Reviewed by Philippe Normand.
1271
1272         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1273         * Scripts/webkitdirs.pm:
1274         (launcherName): Same.
1275         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1276         * gtk/common.py:
1277         (get_build_path.is_valid_build_directory): Same.
1278         * gtk/manifest.txt: Same.
1279
1280 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1281
1282         Unreviewed, rolling out r167046.
1283         https://bugs.webkit.org/show_bug.cgi?id=131479
1284
1285         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1286         on #webkit).
1287
1288         Reverted changeset:
1289
1290         "Remove "System Font" from whitelisted DRT fonts and char
1291         width calculations"
1292         https://bugs.webkit.org/show_bug.cgi?id=131411
1293         http://trac.webkit.org/changeset/167046
1294
1295 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1296
1297         Remove "System Font" from whitelisted DRT fonts and char width calculations
1298         https://bugs.webkit.org/show_bug.cgi?id=131411
1299
1300         Reviewed by Tim Horton.
1301
1302         Covered by existing tests.
1303
1304         * DumpRenderTree/mac/DumpRenderTree.mm:
1305         (allowedFontFamilySet):
1306
1307 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1308
1309         systemHiddenFontFamilySet in DRT is unnecessary
1310         https://bugs.webkit.org/show_bug.cgi?id=131414
1311
1312         Reviewed by Tim Horton.
1313
1314         It doesn't seem to affect test results on my machine.
1315
1316         * DumpRenderTree/mac/DumpRenderTree.mm:
1317         (drt_NSFontManager_availableFonts):
1318         (systemHiddenFontFamilySet): Deleted.
1319
1320 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1321
1322         [Win] Unreviewed test fix: Don't double-release BSTR.
1323
1324         * DumpRenderTree/win/DumpRenderTree.cpp:
1325         (dump): Remove unneeded call to SysFreeString now that we are
1326         using _bstr_t for this variable.
1327
1328 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1329
1330         [Win] Various DumpRenderTree Fixes.
1331         https://bugs.webkit.org/show_bug.cgi?id=131446.
1332
1333         Reviewed by Tim Horton.
1334
1335         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1336         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1337         (AccessibilityUIElement::description): Ditto.
1338         (AccessibilityUIElement::helpText): Ditto.
1339         (AccessibilityUIElement::intValue): Ditto.
1340         (AccessibilityUIElement::isPressActionSupported): Ditto.
1341         (AccessibilityUIElement::accessibilityValue): Ditto.
1342         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1343         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1344         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1345         (DRTDesktopNotificationPresenter::Release): Ditto.
1346         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1347         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1348         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1349         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1350         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1351         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1352         * DumpRenderTree/win/DumpRenderTree.cpp:
1353         (dumpFrameScrollPosition): Ditto.
1354         (dumpFramesAsText): Ditto.
1355         (compareHistoryItems): Ditto.
1356         (dumpHistoryItem): Ditto.
1357         (dump): Ditto.
1358         (resetDefaultsToConsistentValues): Ditto.
1359         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1360         (runTest): Ditto.
1361         (createWebViewAndOffscreenWindow): Ditto.
1362         * DumpRenderTree/win/EditingDelegate.cpp:
1363         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1364         (EditingDelegate::AddRef): Ditto.
1365         (EditingDelegate::Release): Ditto.
1366         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1367         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1368         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1369         (EditingDelegate::shouldInsertNode): Ditto.
1370         (EditingDelegate::shouldInsertText): Ditto.
1371         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1372         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1373         (EditingDelegate::shouldApplyStyle): Ditto.
1374         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1375         (EditingDelegate::doPlatformCommand): Ditto.
1376         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1377         (EditingDelegate::webViewDidChange): Ditto.
1378         (EditingDelegate::webViewDidEndEditing): Ditto.
1379         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1380         (EditingDelegate::webViewDidChangeSelection): Ditto.
1381         (EditingDelegate::checkSpellingOfString): Ditto.
1382         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1383         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1384         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1385         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1386         (FrameLoadDelegate::AddRef): Ditto.
1387         (FrameLoadDelegate::Release): Ditto.
1388         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1389         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1390         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1391         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1392         (FrameLoadDelegate::didReceiveTitle): Ditto.
1393         (FrameLoadDelegate::didChangeIcons): Ditto.
1394         (delegatesWithDelayedWork): Ditto.
1395         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1396         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1397         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1398         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1399         (FrameLoadDelegate::willCloseFrame): Ditto.
1400         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1401         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1402         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1403         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1404         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1405         * DumpRenderTree/win/FrameLoadDelegate.h:
1406         * DumpRenderTree/win/HistoryDelegate.cpp:
1407         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1408         (HistoryDelegate::updateHistoryTitle): Ditto.
1409         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1410         * DumpRenderTree/win/PolicyDelegate.cpp:
1411         (dumpPath):
1412         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1413         (PolicyDelegate::AddRef): Ditto.
1414         (PolicyDelegate::Release): Ditto.
1415         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1416         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1417         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1418         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1419         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1420         (ResourceLoadDelegate::AddRef): Ditto.
1421         (ResourceLoadDelegate::Release): Ditto.
1422         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1423         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1424         (ResourceLoadDelegate::willSendRequest): Ditto.
1425         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1426         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1427         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1428         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1429         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1430         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1431         (TestRunner::setUserStyleSheetLocation): Ditto.
1432         (TestRunner::execCommand): Ditto.
1433         (TestRunner::overridePreference): Ditto.
1434         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1435         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1436         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1437         (TextInputController::insertText): Ditto.
1438         * DumpRenderTree/win/UIDelegate.cpp:
1439         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1440         (UIDelegate::AddRef): Ditto.
1441         (UIDelegate::Release): Ditto.
1442         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1443         (UIDelegate::trackCustomPopupMenu): Ditto.
1444         (UIDelegate::registerUndoWithTarget): Ditto.
1445         (UIDelegate::removeAllActionsWithTarget): Ditto.
1446         (UIDelegate::setActionTitle): Ditto.
1447         (UIDelegate::undo): Ditto.
1448         (UIDelegate::redo): Ditto.
1449         (UIDelegate::canUndo): Ditto.
1450         (UIDelegate::canRedo): Ditto.
1451         (UIDelegate::printFrame): Ditto.
1452         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1453         (UIDelegate::webViewHeaderHeight): Ditto.
1454         (UIDelegate::webViewFooterHeight): Ditto.
1455         (UIDelegate::drawHeaderInRect): Ditto.
1456         (UIDelegate::drawFooterInRect): Ditto.
1457         (UIDelegate::webViewPrintingMarginRect): Ditto.
1458         (UIDelegate::canRunModal): Ditto.
1459         (UIDelegate::createModalDialog): Ditto.
1460         (UIDelegate::runModal): Ditto.
1461         (UIDelegate::isMenuBarVisible): Ditto.
1462         (UIDelegate::setMenuBarVisible): Ditto.
1463         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1464         (UIDelegate::paintCustomScrollbar): Ditto.
1465         (UIDelegate::paintCustomScrollCorner): Ditto.
1466         (UIDelegate::setFrame): Ditto.
1467         (UIDelegate::webViewFrame): Ditto.
1468         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1469         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1470         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1471         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1472         (UIDelegate::webViewAddMessageToConsole): Ditto.
1473         (UIDelegate::doDragDrop): Ditto.
1474         (UIDelegate::webViewGetDlgCode): Ditto.
1475         (UIDelegate::createWebViewWithRequest): Ditto.
1476         (UIDelegate::webViewClose): Ditto.
1477         (UIDelegate::webViewFocus): Ditto.
1478         (UIDelegate::webViewUnfocus): Ditto.
1479         (UIDelegate::webViewPainted): Ditto.
1480         (UIDelegate::exceededDatabaseQuota): Ditto.
1481         (UIDelegate::embeddedViewWithArguments): Ditto.
1482         (UIDelegate::webViewClosing): Ditto.
1483         (UIDelegate::webViewSetCursor): Ditto.
1484         (UIDelegate::webViewDidInvalidate): Ditto.
1485         (UIDelegate::setStatusText): Ditto.
1486         (UIDelegate::desktopNotificationsDelegate): Ditto.
1487         (UIDelegate::drawBackground): Ditto.
1488         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1489         (UIDelegate::didPressMissingPluginButton): Ditto.
1490         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1491         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1492         (LoadHTMLStringItem::invoke): Ditto.
1493         (ScriptItem::invoke): Ditto.
1494
1495 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1496
1497         Stylechecker: False positive on inline asm code.
1498         https://bugs.webkit.org/show_bug.cgi?id=130570
1499
1500         Reviewed by Csaba Osztrogonác.
1501
1502         Disable stylechecking in asm blocks.
1503
1504         * Scripts/webkitpy/style/checkers/cpp.py:
1505         (process_line):
1506         (_InlineASMState):
1507         (_InlineASMState.__init__):
1508         (_InlineASMState.process_line):
1509         (_InlineASMState.isInside):
1510         (_process_lines):
1511         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1512         (WebKitStyleTest.test_member_initialization_list):
1513
1514 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1515
1516         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1517         https://bugs.webkit.org/show_bug.cgi?id=131029
1518
1519         Reviewed by Philippe Normand.
1520
1521         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1522         tests and remove the getWebKit1TestResoucesDir() method.
1523
1524         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1525         (testDownloadLocalFile): Use Test::getResourcesDir().
1526         (testDownloadLocalFileError): Ditto.
1527         (serverCallback): Ditto.
1528         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1529         (serverCallback): Ditto.
1530         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1531         (httpServerCallback): Ditto.
1532         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1533         (serverCallback): Ditto.
1534         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1535         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1536         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1537         (Test::getWebKit1TestResoucesDir): Deleted.
1538
1539 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1540
1541         [WK2] HTTP authentication regression tests fail
1542         https://bugs.webkit.org/show_bug.cgi?id=81627
1543         <rdar://problem/11079296>
1544
1545         Reviewed by Anders Carlsson.
1546
1547         * WebKitTestRunner/TestController.h:
1548         * WebKitTestRunner/TestController.cpp:
1549         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1550         to pageLoaderClient structure.
1551         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1552         for password based authentication (we do get server trust challenges on some tests,
1553         which WKTR can't handle).
1554         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1555         calls won't be made, at least on CFNetwork based platforms.
1556         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1557         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1558         make sense to associate auth requests with individual resources - there can be
1559         multiple resources loading at once from the same protection space, so WebKit1 API
1560         that had a resource identifier was inherently racy.
1561
1562 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1563
1564         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1565         https://bugs.webkit.org/show_bug.cgi?id=131427
1566
1567         Reviewed by Gyuyoung Kim.
1568
1569         Since r166973, font path was changed.
1570
1571         * DumpRenderTree/PlatformEfl.cmake:
1572         * WebKitTestRunner/PlatformEfl.cmake:
1573
1574 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1575
1576         Fix the build-jsc build
1577         https://bugs.webkit.org/show_bug.cgi?id=131410
1578
1579         Reviewed by Michael Saboff.
1580
1581         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1582         WTF depends on it.
1583
1584 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1585
1586         [GTK] Remove WebKit1 unit tests
1587         https://bugs.webkit.org/show_bug.cgi?id=131359
1588
1589         Reviewed by Anders Carlsson.
1590
1591         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1592         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1593         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1594
1595         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1596         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1597         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1598         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1599         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1600         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1601         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1602         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1603         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1604         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1605         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1606         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1607         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1608         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1609         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1610         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1611         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1612         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1613         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1614         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1615         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1616         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1617         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1618         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1619         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1620         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1621         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1622         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1623         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1624         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1625         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1626         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1627         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1628         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1629         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1630         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1631         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1632         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1633
1634 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1635
1636         Unreviewed gardening (Take 2): Prevent users from attempting
1637         to build with known invalid cURL. 
1638
1639         * Scripts/webkitdirs.pm:
1640         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1641         7.33.0 (the known good version).
1642
1643 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1644
1645         [GTK] Remove DumpRenderTree and GtkLauncher
1646         https://bugs.webkit.org/show_bug.cgi?id=131373
1647
1648         Reviewed by Andreas Kling.
1649
1650         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1651         no longer necessary now that WebKit1 GTK+ will be removed.
1652
1653         * CMakeLists.txt:
1654         * DumpRenderTree/PlatformGTK.cmake: Removed.
1655         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1656         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1657         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1658         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1659         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1660         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1661         * DumpRenderTree/gtk/EventSender.h: Removed.
1662         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1663         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1664         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1665         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1666         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1667         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1668         * DumpRenderTree/gtk/TextInputController.h: Removed.
1669         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1670         * GtkLauncher/CMakeLists.txt: Removed.
1671         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1672         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1673         * GtkLauncher/main.c: Removed.
1674         * GtkLauncher/simple.svg: Removed.
1675         * GtkLauncher/text.html: Removed.
1676         * WebKitTestRunner/PlatformGTK.cmake:
1677         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1678         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1679         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1680
1681 2014-04-08  Mark Rowe  <mrowe@apple.com>
1682
1683         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1684         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1685
1686         Reviewed by Alexey Proskuryakov.
1687
1688         * Scripts/webkitdirs.pm:
1689         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1690         (execMacWebKitAppForDebugging): Ditto.
1691
1692 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1693
1694         Build bmalloc on iOS too
1695         https://bugs.webkit.org/show_bug.cgi?id=131381
1696
1697         Reviewed by Andreas Kling.
1698
1699         * Scripts/build-webkit:
1700
1701 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1702
1703         Unreviewed gardening: Prevent users from attempting
1704         to build with known invalid cURL.
1705
1706         * Scripts/webkitdirs.pm:
1707         (checkInstalledTools): Block build attempts with bad
1708         Cygwin tool set.
1709
1710 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1711
1712         Build bmalloc on Mac
1713         https://bugs.webkit.org/show_bug.cgi?id=131333
1714
1715         Reviewed by Mark Rowe.
1716
1717         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1718         (Note: Just testing Mac is not good enough because in this
1719         script 'Mac' means 'Mac or iOS'.)
1720
1721 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1722
1723         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1724         https://bugs.webkit.org/show_bug.cgi?id=130951
1725
1726         Reviewed by Geoffrey Garen.
1727
1728         * Scripts/run-javascriptcore-tests:
1729
1730 2014-04-06  Darin Adler  <darin@apple.com>
1731
1732         Rework CSS calc logic, fixing some reference count mistakes in Length
1733         https://bugs.webkit.org/show_bug.cgi?id=131280
1734
1735         Reviewed by Andreas Kling.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1738         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1739
1740 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1741
1742         Enable WEB_REPLAY for PLATFORM(MAC)
1743         https://bugs.webkit.org/show_bug.cgi?id=130700
1744
1745         Reviewed by Timothy Hatcher.
1746
1747         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1748
1749 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1750
1751         [CMake] Include X11's include dirs in TestNetscapePlugin
1752         https://bugs.webkit.org/show_bug.cgi?id=131270
1753
1754         Reviewed by Martin Robinson.
1755
1756         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1757         TestNetscapePlugin includes WebCore code that includes X headers.
1758
1759 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1760
1761         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1762         <http://webkit.org/b/130986>
1763
1764         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1765         prefix to TileCache class names in exception list.
1766
1767 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1768
1769         [GTK] kill-old-processes should kill dbus-daemon processes
1770         https://bugs.webkit.org/show_bug.cgi?id=127352
1771
1772         Reviewed by Martin Robinson.
1773
1774         * BuildSlaveSupport/kill-old-processes:
1775         (main):
1776
1777 2014-04-04  Andres Gomez  <agomez@igalia.com>
1778
1779         [Win] Update obsolete packages in cygwin
1780         https://bugs.webkit.org/show_bug.cgi?id=126264
1781
1782         Reviewed by Brent Fulgham.
1783
1784         Removed "apache" and "minires" as the first has been replaced by
1785         "lighttpd" and the second is now integrated into
1786         "cygwin". Replaced the transitional and now obsolete "gcc" package
1787         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1788         since the newer version available is "2.7.3" which breaks the
1789         build due to some funniness with environment variable handling.
1790
1791         * CygwinDownloader/cygwin-downloader.py:
1792         * CygwinDownloader/cygwin-downloader.zip:
1793
1794 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1795
1796         check-webkit-style: Improve warnings on Objective-C @property syntax
1797         https://bugs.webkit.org/show_bug.cgi?id=131200
1798
1799         Reviewed by Dan Bernstein.
1800
1801         * Scripts/webkitpy/style/checkers/cpp.py:
1802         (check_spacing):
1803         (CppChecker):
1804         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1805         (CppStyleTest.test_spacing_in_objective_c_properties):
1806
1807 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1808
1809         Unreviewed. Moving my name to commiter section
1810
1811         * Scripts/webkitpy/common/config/contributors.json:
1812
1813 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1814
1815         Unreviewed. Add myself as a committer.
1816
1817         * Scripts/webkitpy/common/config/contributors.json:
1818
1819 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1820
1821         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1822         https://bugs.webkit.org/show_bug.cgi?id=130391
1823
1824         Reviewed by Gyuyoung Kim.
1825
1826         Change the implementation of the zoom functionality from ewk_view_scale_set
1827         to ewk_view_page_zoom_set.
1828
1829         * MiniBrowser/efl/main.c:
1830
1831 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1832
1833         [webkitpy] perf profiler does not understand --call-graph argument
1834         https://bugs.webkit.org/show_bug.cgi?id=131132
1835
1836         Reviewed by Ryosuke Niwa.
1837
1838         New versions of perf profiler have changed the argument from --call-graph to -g.
1839
1840         * Scripts/webkitpy/common/system/profiler.py:
1841         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1842         * Scripts/webkitpy/port/driver_unittest.py:
1843         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1844
1845 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1846
1847         Add EFL WK2 performance bot to build.webkit.org
1848         https://bugs.webkit.org/show_bug.cgi?id=131034
1849
1850         Fix after r166707, use "Perf" instead of "perf" for consistency.
1851
1852         Reviewed by Csaba Osztrogonác.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/config.json:
1855
1856 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1857
1858         Add EFL WK2 performance bot to build.webkit.org
1859         https://bugs.webkit.org/show_bug.cgi?id=131034
1860
1861         Reviewed by Csaba Osztrogonác.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/config.json:
1864
1865 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1866
1867         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1868         https://bugs.webkit.org/show_bug.cgi?id=131151
1869
1870         Reviewed by Gyuyoung Kim.
1871
1872         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1873         (TouchEventInfo::TouchEventInfo):
1874         (sendTouchEvent):
1875         (addTouchPointCallback):
1876         (updateTouchPointCallback):
1877         (cancelTouchPointCallback):
1878         (releaseTouchPointCallback):
1879
1880 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1881
1882         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1883         <http://webkit.org/b/131045>
1884
1885         Reviewed by Daniel Bates.
1886
1887         * Scripts/filter-build-webkit:
1888         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1889         of clang, plus debug data for all DVTAssertions.
1890
1891 2014-04-01  Dean Jackson  <dino@apple.com>
1892
1893         Load Media Controls js/css from bundle
1894         https://bugs.webkit.org/show_bug.cgi?id=131086
1895
1896         Reviewed by Eric Carlson.
1897
1898         We're now putting CSS files into the bundle, so remove the test for them.
1899
1900         * Scripts/check-for-inappropriate-files-in-framework:
1901
1902 2014-04-02  Martin Hock  <mhock@apple.com>
1903
1904         Unify private browsing with sessions.
1905         https://bugs.webkit.org/show_bug.cgi?id=130099
1906
1907         Reviewed by Alexey Proskuryakov.
1908
1909         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1912         (TestWebKitAPI::didNavigateWithNavigationData):
1913         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1914         (TestWebKitAPI::TEST):
1915
1916         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1917         (TestWebKitAPI::didNavigateWithoutNavigationData):
1918         (TestWebKitAPI::didNavigateWithNavigationData):
1919         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1920         (TestWebKitAPI::TEST):
1921
1922 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1923
1924         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1925         https://bugs.webkit.org/show_bug.cgi?id=130343
1926
1927         Reviewed by Gustavo Noronha Silva.
1928
1929         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1930         of directories on the command line and look for all appropriate files in those directories for the
1931         GResource archive. Also make archive paths relative to those directories.
1932         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1933         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1934
1935 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1936
1937         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1938         https://bugs.webkit.org/show_bug.cgi?id=131106
1939
1940         Reviewed by Csaba Osztrogonác.
1941
1942         * Scripts/webkitpy/tool/commands/download.py:
1943         (AbstractRolloutPrepCommand._prepare_state):
1944         * Scripts/webkitpy/tool/commands/download_unittest.py:
1945         (test_prepare_rollout):
1946         (test_create_rollout):
1947         (test_create_rollout_resolved):
1948         (test_rollout):
1949
1950 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1951
1952         [EFL] Add option to use separate web process for new window in MiniBrowser
1953         https://bugs.webkit.org/show_bug.cgi?id=130190
1954
1955         Reviewed by Gyuyoung Kim.
1956
1957         New created window (CTRL + n) will be open in separated web process.
1958         This option is enabled by adding a flag (S/separate-process) with launching
1959         MiniBrowser.
1960
1961         * MiniBrowser/efl/main.c:
1962         (elm_main):
1963
1964 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1965
1966         [GTK] Move NEWS file to a new location
1967         https://bugs.webkit.org/show_bug.cgi?id=130901
1968
1969         Reviewed by Brent Fulgham.
1970
1971         * gtk/manifest.txt: Update the NEWS file path.
1972
1973 2014-04-01  Anders Carlsson  <andersca@apple.com>
1974
1975         Fix build.
1976
1977         * MiniBrowser/mac/WK2BrowserWindowController.m:
1978         (-[WK2BrowserWindowController awakeFromNib]):
1979         (-[WK2BrowserWindowController dealloc]):
1980         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1981
1982 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1983
1984         Unreviewed test gardening.
1985
1986         * Scripts/webkitpy/port/base_unittest.py:
1987         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1988
1989 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1990
1991         [CSS Exclusions] Remove exclusions parsing support
1992         https://bugs.webkit.org/show_bug.cgi?id=131046
1993
1994         Reviewed by David Hyatt.
1995
1996         * Scripts/webkitperl/FeatureList.pm:
1997
1998 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1999
2000         [GTK] Remove last reference to GTK+ WK1 EWS
2001         https://bugs.webkit.org/show_bug.cgi?id=131058
2002
2003         Reviewed by Martin Robinson.
2004
2005         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2006
2007         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2008
2009 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2010
2011         Add a 32bit JSC builder/tester.
2012         https://bugs.webkit.org/show_bug.cgi?id=131054
2013         
2014         Reviewed by Michael Saboff.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/config.json:
2017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2018         (Compile32bitJSC):
2019         (Run32bitJSCTests):
2020         (Run32bitJSCTests.countFailures):
2021         (BuildAndTest32bitJSCFactory):
2022         (BuildAndTest32bitJSCFactory.__init__):
2023
2024 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2025
2026         [GTK] No longer build WebKit1 gtkdoc
2027         https://bugs.webkit.org/show_bug.cgi?id=130970
2028
2029         Reviewed by Anders Carlsson.
2030
2031         * gtk/common.py:
2032         (gtk_version_of_pkg_config_file): Deleted.
2033         * gtk/generate-gtkdoc:
2034         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2035         was only applicable for WebKit1.
2036         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2037
2038 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2039
2040         [GTK] Running minibrowser with url crashes in debug build
2041         https://bugs.webkit.org/show_bug.cgi?id=130492
2042
2043         Reviewed by Martin Robinson.
2044
2045         Update "uri-scheme" test not to use invalid URIs in it, so we
2046         don't get a mistmatch when comparing the original URI stored in
2047         the test class with the one returned by the WebKitWebView.
2048
2049         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2050         (testWebContextURIScheme): Update the test.
2051
2052 2014-04-01  Mihai Tica  <mitica@adobe.com>
2053
2054         Unreviewed: Add myself as a commiter to the contributors list.
2055
2056         * Scripts/webkitpy/common/config/contributors.json:
2057
2058 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2059
2060         [EFL][WK2] Extract the control of page background out of color_set
2061         https://bugs.webkit.org/show_bug.cgi?id=127539
2062
2063         Reviewed by Gyuyoung Kim.
2064
2065         Added an option(C) to change background color.
2066
2067         * MiniBrowser/efl/main.c:
2068         (window_create):
2069         (elm_main):
2070
2071 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2072
2073         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2074
2075         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2076
2077 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2078
2079         Unreviewed test correction after r166530.
2080
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2083         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2084
2085 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2086
2087         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2088         https://bugs.webkit.org/show_bug.cgi?id=130987
2089
2090         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2091         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2092
2093         Reviewed by Martin Robinson.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/config.json:
2096
2097 2014-03-31  Dean Jackson  <dino@apple.com>
2098
2099         Remove WEB_ANIMATIONS
2100         https://bugs.webkit.org/show_bug.cgi?id=130989
2101
2102         Reviewed by Simon Fraser.
2103
2104         Remove this feature flag until we plan to implement.
2105
2106         * Scripts/webkitperl/FeatureList.pm:
2107
2108 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2109
2110         Reduced Latched Scroll Test Flakiness
2111         https://bugs.webkit.org/show_bug.cgi?id=130983
2112
2113         Reviewed by Darin Adler.
2114
2115         * DumpRenderTree/mac/DumpRenderTree.mm:
2116         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2117         * DumpRenderTree/mac/EventSendingController.mm:
2118         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2119         with high resolution flags turned on.
2120         * WebKitTestRunner/mac/EventSenderProxy.mm:
2121         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2122
2123 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2124
2125         run-webkit-tests should have a --no-timeout option
2126         https://bugs.webkit.org/show_bug.cgi?id=128286
2127
2128         Reviewed by Joseph Pecoraro.
2129
2130         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2131         (Worker._run_test): Renaming _run_test_with_timeout()
2132         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2133         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2134         (Worker._run_test_in_this_thread):
2135         (Worker._run_test_with_timeout): Deleted.
2136         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2137         (parse_args): Added the --no-timeout option
2138
2139 2014-03-31  Samuel White  <samuel_white@apple.com>
2140
2141         AX: Need ability to get line range for text marker.
2142         https://bugs.webkit.org/show_bug.cgi?id=130906
2143
2144         Reviewed by Chris Fleizach.
2145
2146         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2147
2148         * DumpRenderTree/AccessibilityUIElement.cpp:
2149         (lineTextMarkerRangeForTextMarkerCallback):
2150         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2151         (AccessibilityUIElement::getJSClass):
2152         * DumpRenderTree/AccessibilityUIElement.h:
2153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2154         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2155         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2156         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2157         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2158         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2160         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2161         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2162         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2164         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2165
2166 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2167
2168         More validation for FTL inline caches
2169         https://bugs.webkit.org/show_bug.cgi?id=130948
2170
2171         Reviewed by Geoffrey Garen.
2172
2173         * Scripts/run-jsc-stress-tests:
2174
2175 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2176
2177         [GTK] Do not run WebKit1 unit tests by default
2178         https://bugs.webkit.org/show_bug.cgi?id=130968
2179
2180         Reviewed by Martin Robinson.
2181
2182         * Scripts/run-gtk-tests:
2183         (TestRunner):
2184
2185 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2186
2187         [GTK] Remove scripts code only applicable to autotools
2188         https://bugs.webkit.org/show_bug.cgi?id=130841
2189
2190         Reviewed by Anders Carlsson.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2193         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2194         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2195         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2196         * gtk/find-make-dist-errors: Removed.
2197         * gtk/generate-feature-defines-files: Removed.
2198         * gtk/manifest.txt: No longer need to consider autotools files.
2199
2200 2014-03-30  Andy Estes  <aestes@apple.com>
2201
2202         Fix two failing layout tests on Mountain Lion after r166466.
2203
2204         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2205         (-[DownloadDelegate _downloadDidStart:]):
2206
2207 2014-03-30  Andy Estes  <aestes@apple.com>
2208
2209         [Cocoa] Add an originatingWebView property to _WKDownload
2210         https://bugs.webkit.org/show_bug.cgi?id=130945
2211
2212         Reviewed by Anders Carlsson.
2213
2214         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2215         (-[DownloadDelegate _downloadDidStart:]):
2216         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2217         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2218         (TEST):
2219
2220 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2221
2222         Land the stackmap register liveness glue with the uses of the liveness disabled
2223         https://bugs.webkit.org/show_bug.cgi?id=130924
2224
2225         Reviewed by Oliver Hunt.
2226
2227         * Scripts/run-jsc-stress-tests:
2228
2229 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2230
2231         Update WebKit1.StringTruncator for Mountain Lion.
2232
2233         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2234         due to different font metrics on 10.8.
2235
2236 2014-03-28  Darin Adler  <darin@apple.com>
2237
2238         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2239         https://bugs.webkit.org/show_bug.cgi?id=130889
2240
2241         Reviewed by Alexey Proskuryakov.
2242
2243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2244         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2245         WebStringTruncator methods; should be good for a start. These are dependent on the
2246         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2247
2248 2014-03-28  Martin Hock  <mhock@apple.com>
2249
2250         Unreviewed. Add myself as a committer.
2251
2252         * Scripts/webkitpy/common/config/contributors.json:
2253
2254 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2255
2256         Remove WebKit1 GTK+ bots
2257         https://bugs.webkit.org/show_bug.cgi?id=130904
2258
2259         Reviewed by Anders Carlsson.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2262         all bots are testing WebKit2 only.
2263         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2264         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2265         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2266         * Scripts/webkitpy/port/builders.py: Ditto.
2267         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2268         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2269
2270 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2271
2272         Remove Brian Burg's apple.com email address.
2273
2274         * Scripts/webkitpy/common/config/contributors.json:
2275
2276 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2277
2278         bisect-builds should print Trac 'changeset' URL if only one build is detected
2279         <http://webkit.org/b/130903>
2280
2281         Reviewed by Dan Bernstein.
2282
2283         * Scripts/bisect-builds:
2284         (printTracLink): Print a direct link to the Trac 'changeset'
2285         URL if there is only one revision in the range.
2286
2287 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2288
2289         [EFL] Bump glib version from 2.36 to 2.38 
2290         https://bugs.webkit.org/show_bug.cgi?id=130886
2291
2292         Reviewed by Csaba Osztrogonác.
2293
2294         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2295         we need to bump glib version up to 2.38 as gtk port.
2296
2297         * efl/jhbuild.modules:
2298
2299 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2300
2301         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2302
2303         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2304         the globalhistory directory.
2305
2306         Reviewed by Sam Weinig.
2307
2308         * WebKitTestRunner/TestController.cpp:
2309         (WTR::TestController::TestController):
2310         (WTR::TestController::initialize): Set the history client.
2311         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2312         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2313         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2314         and we don't yet have API to access the data in question.
2315         (WTR::TestController::didPerformClientRedirect):
2316         (WTR::TestController::didPerformServerRedirect):
2317         (WTR::TestController::didUpdateHistoryTitle):
2318         * WebKitTestRunner/TestController.h:
2319         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2320         * WebKitTestRunner/TestInvocation.cpp:
2321         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2322         (WTR::TestInvocation::invoke):
2323
2324 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2325
2326         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2327
2328         * Scripts/build-webkit:
2329         * Scripts/copy-webkitlibraries-to-product-directory:
2330
2331 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2332
2333         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2334         https://bugs.webkit.org/show_bug.cgi?id=130867
2335         <rdar://problem/16432456> 
2336
2337         Reviewed by Mark Hahnenberg.
2338
2339         * Scripts/build-webkit:
2340         * Scripts/copy-webkitlibraries-to-product-directory:
2341
2342 2014-03-26  Andy Estes  <aestes@apple.com>
2343
2344         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2345         https://bugs.webkit.org/show_bug.cgi?id=130805
2346
2347         Reviewed by Dan Bernstein.
2348
2349         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2350         (-[DownloadDelegate _download:didReceiveResponse:]):
2351         (-[DownloadDelegate _downloadDidFinish:]):
2352         (runTest):
2353         (TEST):
2354         (-[FailingDownloadDelegate _downloadDidFinish:]):
2355         (-[FailingDownloadDelegate _download:didFailWithError:]):
2356         (-[FailingDownloadDelegate _downloadDidCancel:]):
2357         (-[CancelledDownloadDelegate _downloadDidStart:]):
2358         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2359         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2360         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2361         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2362         (-[DownloadDelegate sourceURL]): Deleted.
2363         (runTestWithNavigationDelegate): Deleted.
2364
2365 2014-03-26  Anders Carlsson  <andersca@apple.com>
2366
2367         Change MiniBrowser to hold on to window controllers instead of windows
2368         https://bugs.webkit.org/show_bug.cgi?id=130797
2369
2370         Reviewed by Oliver Hunt.
2371
2372         * MiniBrowser/mac/AppDelegate.h:
2373         * MiniBrowser/mac/AppDelegate.m:
2374         (-[BrowserAppDelegate init]):
2375         (-[BrowserAppDelegate newWindow:]):
2376         (-[BrowserAppDelegate browserWindowWillClose:]):
2377         (-[BrowserAppDelegate applicationWillTerminate:]):
2378         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2379
2380 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2381
2382         Unreviewed, rolling out r166264.
2383         https://bugs.webkit.org/show_bug.cgi?id=130785
2384
2385         Broke some window.opener tests for WK2 Mavericks (Requested by
2386         brrian__ on #webkit).
2387
2388         Reverted changeset:
2389
2390         "Web Replay: resource unique identifiers should be unique-per-
2391         frame, not globally"
2392         https://bugs.webkit.org/show_bug.cgi?id=130632
2393         http://trac.webkit.org/changeset/166264
2394
2395 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2396
2397         [CSS Shapes] Remove shape-inside support
2398         https://bugs.webkit.org/show_bug.cgi?id=130698
2399
2400         Reviewed by David Hyatt.
2401
2402         * Scripts/webkitperl/FeatureList.pm:
2403
2404 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2405
2406         Unreviewed. Add myself as a committer.
2407
2408         * Scripts/webkitpy/common/config/contributors.json:
2409
2410 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2411
2412         run-launcher is Perl script so use elsif and not elif
2413         https://bugs.webkit.org/show_bug.cgi?id=130771
2414
2415         Reviewed by Carlos Garcia Campos.
2416
2417         * Scripts/run-launcher:
2418
2419 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2420
2421         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2422         https://bugs.webkit.org/show_bug.cgi?id=130575
2423
2424         Reviewed by Mario Sanchez Prada.
2425
2426         Change ATK version to 2.11.92. Adjust current implementation.
2427
2428         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2429         (AccessibilityUIElement::intValue):
2430         (AccessibilityUIElement::minValue):
2431         (AccessibilityUIElement::maxValue):
2432         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2433         (WTR::AccessibilityUIElement::intValue):
2434         (WTR::AccessibilityUIElement::minValue):
2435         (WTR::AccessibilityUIElement::maxValue):
2436         * efl/jhbuild.modules:
2437         * gtk/jhbuild.modules:
2438
2439 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2440
2441         [GTK] The gnumake package is no longer needed in jhbuild
2442         https://bugs.webkit.org/show_bug.cgi?id=130121
2443
2444         Reviewed by Martin Robinson.
2445
2446         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2447         for a debug build cmake/system-gnumake worked just fine for me.
2448
2449         * gtk/jhbuild.modules: Removed gnumake.
2450         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2451         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2452
2453 2014-03-25  Andy Estes  <aestes@apple.com>
2454
2455         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2456
2457         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2458         (-[DownloadDelegate _download:didReceiveData:]):
2459         (-[DownloadDelegate _downloadDidFinish:]):
2460
2461 2014-03-25  Brian Burg  <bburg@apple.com>
2462
2463         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2464         https://bugs.webkit.org/show_bug.cgi?id=130623
2465
2466         Reviewed by Timothy Hatcher.
2467
2468         The resource loader callback dumping routines assumed that resource identifiers
2469         were globally unique. Its map of resource identifiers to URLs must also track the
2470         frame associated with the resource.
2471
2472         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2473         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2474         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2475         stable as long as the frame is valid.
2476         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2477         (WTR::InjectedBundlePage::willSendRequestForFrame):
2478         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2479         (WTR::InjectedBundlePage::didFinishLoadForResource):
2480         (WTR::InjectedBundlePage::didFailLoadForResource):
2481
2482 2014-03-25  Andy Estes  <aestes@apple.com>
2483
2484         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2485
2486         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2487         (-[DownloadDelegate _download:didReceiveResponse:]):
2488         (-[DownloadDelegate _download:didReceiveData:]):
2489
2490 2014-03-25  Andy Estes  <aestes@apple.com>
2491
2492         Add some debug logging to an API test that's failing on Mountain Lion.
2493
2494         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2495         (-[DownloadDelegate _download:didReceiveResponse:]):
2496         (-[DownloadDelegate _downloadDidFinish:]):
2497
2498 2014-03-25  Anders Carlsson  <andersca@apple.com>
2499
2500         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2501         https://bugs.webkit.org/show_bug.cgi?id=130732
2502
2503         Reviewed by Tim Horton.
2504
2505         * MiniBrowser/mac/WK2BrowserWindowController.m:
2506         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2507
2508 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2509
2510         [GTK] Remove the autotools build
2511         https://bugs.webkit.org/show_bug.cgi?id=130717
2512
2513         Reviewed by Anders Carlsson.
2514
2515         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2516         * GNUmakefile.am: Removed.
2517         * GtkLauncher/GNUmakefile.am: Removed.
2518         * GtkLauncher/main.c: Remove references to the autotools configure file.
2519         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2520         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2521         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2522         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2523         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2524         * Scripts/build-webkit: No longer handle autotools.
2525         * Scripts/run-gtk-tests: Ditto.
2526         (TestRunner._setup_testing_environment):
2527         * Scripts/run-launcher: Ditto.
2528         * Scripts/webkitdirs.pm: Ditto.
2529         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2530         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2531         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2532         * Scripts/webkitpy/style/checker.py:
2533         * TestWebKitAPI/GNUmakefile.am: Removed.
2534         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2535         * WebKitTestRunner/GNUmakefile.am: Removed.
2536         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2537         * gtk/GNUmakefile.am: Removed.
2538         * gtk/common.py: Remove checks for the autotools build.
2539         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2540
2541 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2542
2543         prepare-ChangeLog throws false positive warnings for modified files.
2544         https://bugs.webkit.org/show_bug.cgi?id=130687
2545
2546         Reviewed by Darin Adler.
2547
2548         * Scripts/prepare-ChangeLog:
2549         (originalFile): Ignore git commit paremeter.
2550         We don't need this to get the unmodified file.
2551         (extractLineRangeBeforeChange):
2552         Simplify the if statement. Follow-up after r166189.
2553
2554 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2555
2556         [EFL] Add ARM64 build support
2557         https://bugs.webkit.org/show_bug.cgi?id=130506
2558
2559         Rubber stamped by Gyuyoung Kim.
2560
2561         * Scripts/webkitdirs.pm:
2562         (isARM): Detect aarch64 as ARM.
2563
2564 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2565
2566         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2567         https://bugs.webkit.org/show_bug.cgi?id=130137
2568
2569         Reviewed by Csaba Osztrogonác.
2570
2571         * Scripts/webkitpy/common/checkout/changelog.py:
2572         (ChangeLogEntry._parse_bug_description):
2573         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2574         (test_parse_log_entries_from_changelog):
2575         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2576         (CheckoutTest.test_commit_info_for_revision):
2577
2578 2014-03-24  Andy Estes  <aestes@apple.com>
2579
2580         Fix the iOS build of TestWebKitAPI.
2581
2582         * TestWebKitAPI/Configurations/Base.xcconfig:
2583         * TestWebKitAPI/PlatformUtilities.h:
2584
2585 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2586
2587         Fix prepare-ChangeLog after r166156.
2588         https://bugs.webkit.org/show_bug.cgi?id=130674
2589
2590         Reviewed by Darin Adler.
2591
2592         * Scripts/prepare-ChangeLog:
2593         (generateFunctionLists):
2594         (extractLineRangeBeforeChange):
2595
2596 2014-03-24  Andy Estes  <aestes@apple.com>
2597
2598         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2599         https://bugs.webkit.org/show_bug.cgi?id=129322
2600
2601         Reviewed by Anders Carlsson.
2602
2603         Add an API test suite for _WKDownload.
2604
2605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2606         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2607         (-[DownloadDelegate initWithSourceURL:]):
2608         (-[DownloadDelegate sourceURL]):
2609         (-[DownloadDelegate _downloadDidStart:]):
2610         (-[DownloadDelegate _download:didReceiveResponse:]):
2611         (-[DownloadDelegate _download:didReceiveData:]):
2612         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2613         (-[DownloadDelegate _downloadDidFinish:]):
2614         (TEST):
2615         (runTestWithNavigationDelegate):
2616         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2617         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2618
2619 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2620
2621         filter-build-webkit: reduce unfiltered output
2622         https://bugs.webkit.org/show_bug.cgi?id=130485
2623
2624         Reviewed by Brent Fulgham.
2625
2626         * Scripts/filter-build-webkit:
2627         (shouldIgnoreLine):
2628
2629 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2630
2631         prepare-ChangeLog should list functions that have been removed too.
2632         https://bugs.webkit.org/show_bug.cgi?id=130508
2633
2634         Reviewed by Darin Adler.
2635
2636         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2637         We have to read the functions and the line ranges of them from the source
2638         before the change, then search for overlaps between them and the changed
2639         line ranges from diff.
2640
2641         * Scripts/prepare-ChangeLog:
2642         (originalFile): Get original source command.
2643         (generateFunctionLists): Collect deleted functions too.
2644         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2645         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2646         deleted functions ranges too.
2647         (extractLineRange): Renamed to extractLineRangeAfterChange.
2648
2649 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2650
2651         Move all EFL typedefs into EflTypedefs.h.
2652         https://bugs.webkit.org/show_bug.cgi?id=130511
2653
2654         Reviewed by Gyuyoung Kim.
2655
2656         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2657         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2658         * WebKitTestRunner/PlatformWebView.h: Ditto.
2659
2660 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2661
2662         Don't flush compositing layers within FrameView::willPaintContents()
2663         https://bugs.webkit.org/show_bug.cgi?id=130627
2664         <rdar://problem/16368869>
2665
2666         Reviewed by Sam Weinig.
2667         
2668         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2669         does not flush.
2670         
2671         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2672         into an explicit function called before dumping. 
2673         
2674         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2675         are flushed to CA. They will be pushed to the window by snapshotting.
2676
2677         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2678         Fix weird path to IOKit.framework.
2679         * DumpRenderTree/mac/DumpRenderTree.mm:
2680         (updateDisplay):
2681         (dump):
2682         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2683         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2684         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2685
2686 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2687
2688         fix-blink-patch: tool to fix up renamed directory paths in Blink
2689         <http://webkit.org/b/130609>
2690
2691         Reviewed by Ryosuke Niwa.
2692
2693         Usage: cat blink.patch | fix-blink-patch | svn-apply
2694
2695         * Scripts/fix-blink-patch: Added.
2696
2697 2014-03-21  Darin Adler  <darin@apple.com>
2698
2699         Remove use of deprecatedCharacters in WebKit API tests
2700         https://bugs.webkit.org/show_bug.cgi?id=130602
2701
2702         Reviewed by Antti Koivisto.
2703
2704         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2705         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2706         (TestWebKitAPI::expectEmpty): Use characters8.
2707         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2708
2709         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2710         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2711         the deprecatedCharacters function itself, which we are about to delete.
2712
2713 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2714
2715         [webkitpy] Fix has_valid_reviewer()
2716         https://bugs.webkit.org/show_bug.cgi?id=130589
2717
2718         Reviewed by Csaba Osztrogonác.
2719
2720         * Scripts/webkitpy/common/checkout/changelog.py:
2721         (ChangeLogEntry.has_valid_reviewer):
2722         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2723         (test_has_valid_reviewer):
2724         * Scripts/webkitpy/common/config/committers.py:
2725         (CommitterList._reviewer_only):
2726         (CommitterList.committer_by_name):
2727         (CommitterList.reviewer_by_email):
2728         (CommitterList):
2729         (CommitterList.reviewer_by_name):
2730
2731 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2732
2733         Add cache support for jhbuild
2734         https://bugs.webkit.org/show_bug.cgi?id=130588
2735
2736         Reviewed by Csaba Osztrogonác.
2737
2738         * jhbuild/jhbuildrc_common.py:
2739         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2740
2741 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2742
2743         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2744         https://bugs.webkit.org/show_bug.cgi?id=130504
2745
2746         Reviewed by Martin Robinson.
2747
2748         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2749         CMake if not specified.
2750         * Scripts/webkitdirs.pm:
2751         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2752         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2753
2754 2014-03-21  Andreas Kling  <akling@apple.com>
2755
2756         RetainPtr API test should use CFArray instead of CFString for testing.
2757         <rdar://problem/16384899>
2758
2759         Unreviewed bot fix.
2760
2761         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2762         (TestWebKitAPI::TEST):
2763         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2764         (TestWebKitAPI::TEST):
2765
2766 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2767
2768         Move to using std::unique_ptr for EFL objects.
2769         https://bugs.webkit.org/show_bug.cgi?id=129853
2770
2771         Reviewed by Gyuyoung Kim.
2772
2773         EflUniquePtr is a template alias of std::unique_ptr
2774         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2775         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2776
2777         * DumpRenderTree/efl/DumpRenderTree.cpp:
2778         (main):
2779         * ImageDiff/efl/ImageDiff.cpp:
2780         (initEfl):
2781         (main):
2782
2783 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2784
2785         Unreviewed buildfix after r165983 for non Cocoa platforms
2786
2787         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2788
2789         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2790         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2791         * WebKitTestRunner/TestController.cpp:
2792
2793 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2794
2795         [GTK][CMake] Add support for building with Clang
2796         https://bugs.webkit.org/show_bug.cgi?id=130260
2797
2798         Reviewed by Martin Robinson.
2799
2800         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2801         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2802         included GTest framework headers.
2803         * gtk/generate-gtkdoc:
2804         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2805         in case of using Clang since that is now set by the CMake rule.
2806
2807 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2808
2809         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2810         https://bugs.webkit.org/show_bug.cgi?id=130476
2811
2812         Reviewed by Anders Carlsson.
2813         
2814         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2815
2816         * MiniBrowser/mac/WK1BrowserWindowController.m:
2817         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2818         Remove log.
2819         * MiniBrowser/mac/WK2BrowserWindowController.m:
2820         (-[WK2BrowserWindowController awakeFromNib]):
2821         (-[WK2BrowserWindowController validateMenuItem:]):
2822         (-[WK2BrowserWindowController reload:]):
2823         Hook up reload.
2824         (-[WK2BrowserWindowController toggleZoomMode:]):
2825         (-[WK2BrowserWindowController resetZoom:]):
2826         (-[WK2BrowserWindowController canResetZoom]):
2827         (-[WK2BrowserWindowController currentZoomFactor]):
2828         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2829         (-[WK2BrowserWindowController canZoomIn]):
2830         (-[WK2BrowserWindowController canZoomOut]):
2831
2832 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2833
2834         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2835         https://bugs.webkit.org/show_bug.cgi?id=130463
2836
2837         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2838
2839 2014-03-18  Samuel White  <samuel_white@apple.com>
2840
2841         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2842         https://bugs.webkit.org/show_bug.cgi?id=130250
2843
2844         Reviewed by Chris Fleizach.
2845
2846         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2847
2848         * DumpRenderTree/AccessibilityController.cpp:
2849         (enableEnhancedAccessibilityCallback):
2850         (getEnhancedAccessibilityEnabledCallback):
2851         (AccessibilityController::getJSClass):
2852         * DumpRenderTree/AccessibilityController.h:
2853         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2854         (AccessibilityController::enableEnhancedAccessibility):
2855         (AccessibilityController::enhancedAccessibilityEnabled):
2856         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2857         (AccessibilityController::enableEnhancedAccessibility):
2858         (AccessibilityController::enhancedAccessibilityEnabled):
2859         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2860         (AccessibilityController::enableEnhancedAccessibility):
2861         (AccessibilityController::enhancedAccessibilityEnabled):
2862         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2863         (AccessibilityController::enableEnhancedAccessibility):
2864         (AccessibilityController::enhancedAccessibilityEnabled):
2865         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2866         (WTR::AccessibilityController::enableEnhancedAccessibility):
2867         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2868         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2869         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2870
2871 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2872
2873         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2874         yet).
2875
2876         * Scripts/webkitpy/common/config/contributors.json:
2877
2878 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2879
2880         Web Inspector: Remove stale ReportMemoryUsagePlugin
2881         https://bugs.webkit.org/show_bug.cgi?id=130405
2882
2883         Reviewed by Andreas Kling.
2884
2885         This clang plugin looks like it was used for the old Inspector memory
2886         instrumentation that was removed. So the tool can be removed.
2887
2888         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2889         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2890         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2891         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2892
2893 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2894
2895         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2896         https://bugs.webkit.org/show_bug.cgi?id=130220
2897
2898         Reviewed by Csaba Osztrogonác.
2899
2900         * Scripts/webkitpy/common/checkout/changelog.py:
2901         (ChangeLog.set_reviewer):
2902         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2903         (test_set_reviewer):
2904
2905 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2906
2907         More FTL enabling.
2908
2909         Rubber stamped by Dan Bernstein.
2910
2911         * Tools/Scripts/build-webkit:
2912
2913 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2914
2915         Renable pagination mode in WK2 MiniBrowser
2916         https://bugs.webkit.org/show_bug.cgi?id=130374
2917
2918         Reviewed by Anders Carlsson.
2919         
2920         Put the implementation of togglePaginationMode: back, and correctly
2921         enable the menu item.
2922
2923         * MiniBrowser/mac/WK2BrowserWindowController.m:
2924         (-[WK2BrowserWindowController validateMenuItem:]):
2925         (-[WK2BrowserWindowController isPaginated]):
2926         (-[WK2BrowserWindowController togglePaginationMode:]):
2927
2928 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2929
2930         Add --reset option to Tools/Scripts/set-webkit-configuration script
2931         https://bugs.webkit.org/show_bug.cgi?id=130401
2932
2933         Reviewed by Csaba Osztrogonác.
2934
2935         * Scripts/set-webkit-configuration:
2936
2937 2014-03-18  Alberto Garcia  <berto@igalia.com>
2938
2939         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2940         https://bugs.webkit.org/show_bug.cgi?id=130388
2941
2942         Reviewed by Sergio Villar Senin.
2943
2944         * Scripts/webkitdirs.pm:
2945         (shouldRemoveCMakeCache): make sure that the build directory
2946         exists before attempting to create a file in it.
2947
2948 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2949
2950         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2951         https://bugs.webkit.org/show_bug.cgi?id=130336
2952
2953         Reviewed by Gyuyoung Kim.
2954
2955         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2956         requires a space between literal and string macro [-Wliteral-suffix]'
2957         warning treated as error.
2958
2959         This patch applies a solution from r162448 to the EFL port.
2960
2961         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2962         * efl/jhbuild.modules: Added appropriate patch section.
2963
2964 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2965
2966         webkitpy test rebaseline.
2967
2968         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2969         (MainTest.test_default_args):
2970
2971 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2972
2973         --profile should imply --test-runner-count=1 in run-perf-tests
2974         https://bugs.webkit.org/show_bug.cgi?id=130375
2975
2976         Reviewed by Benjamin Poulain.
2977
2978         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2979
2980         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2981         (PerfTestsRunner._parse_args): Use -1 as the default value.
2982         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2983         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2984         should be 1.
2985
2986 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2987
2988         Address some style nits.
2989
2990         * MiniBrowser/mac/WK2BrowserWindowController.m:
2991
2992 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2993
2994         Add transparent window support back into MiniBrowser
2995         https://bugs.webkit.org/show_bug.cgi?id=130363
2996
2997         Reviewed by Anders Carlsson.
2998         
2999         Re-enable transparent window support for WK2.
3000
3001         * MiniBrowser/mac/WK2BrowserWindowController.m:
3002         (-[WK2BrowserWindowController validateMenuItem:]):
3003         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3004
3005 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3006
3007         Fix the 32-bit build; make the open panel make a WK1 window.
3008
3009         * MiniBrowser/mac/AppDelegate.m:
3010         (-[BrowserAppDelegate openDocument:]):
3011
3012 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3013
3014         Convert MiniBrowser to use WKWebView API
3015         https://bugs.webkit.org/show_bug.cgi?id=130061
3016
3017         Reviewed by Anders Carlsson.
3018         
3019         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3020         as possible.
3021         
3022         Some functionality was removed temporarily:
3023             - text zoom, page zoom
3024             - reload
3025             - pagination mode
3026             - transparent window
3027             - dumping source
3028             - window.open support
3029             - beforeUnload panel
3030             - find in page
3031
3032         * MiniBrowser/mac/AppDelegate.h:
3033         * MiniBrowser/mac/AppDelegate.m:
3034         (-[BrowserAppDelegate init]):
3035         (-[BrowserAppDelegate newWindow:]):
3036         (-[BrowserAppDelegate applicationWillTerminate:]):
3037         (-[BrowserAppDelegate openDocument:]):
3038         * MiniBrowser/mac/WK2BrowserWindowController.h:
3039         * MiniBrowser/mac/WK2BrowserWindowController.m:
3040         (-[WK2BrowserWindowController awakeFromNib]):
3041         (-[WK2BrowserWindowController dealloc]):
3042         (-[WK2BrowserWindowController fetch:]):
3043         (-[WK2BrowserWindowController validateMenuItem:]):
3044         (-[WK2BrowserWindowController reload:]):
3045         (-[WK2BrowserWindowController goBack:]):
3046         (-[WK2BrowserWindowController goForward:]):
3047         (-[WK2BrowserWindowController toggleZoomMode:]):
3048         (-[WK2BrowserWindowController resetZoom:]):
3049         (-[WK2BrowserWindowController canResetZoom]):
3050         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3051         (-[WK2BrowserWindowController togglePaginationMode:]):
3052         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3053         (-[WK2BrowserWindowController windowShouldClose:]):
3054         (-[WK2BrowserWindowController applicationTerminating]):
3055         (-[WK2BrowserWindowController currentZoomFactor]):
3056         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3057         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3058         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3059         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3060         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3061         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3062         (-[WK2BrowserWindowController find:]):
3063         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3064         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3065         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3066         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3067         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3068         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3069         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3070         * WebKitTestRunner/PlatformWebView.h:
3071         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3072         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3073
3074 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3075
3076         Use RunLoop objects through references instead of pointers
3077         https://bugs.webkit.org/show_bug.cgi?id=130313
3078
3079         Reviewed by Andreas Kling.
3080
3081         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3082         return RunLoop reference instead of a pointer.
3083
3084         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3085         (loadedCallback):
3086         (clickedCallback):
3087
3088 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3089
3090         sort-export-file --help doesn't work (missing 'use')
3091         https://bugs.webkit.org/show_bug.cgi?id=130338
3092
3093         Reviewed by Anders Carlsson.
3094
3095         * Scripts/sort-export-file:
3096         Add a missing 'use', and fix a typo in an error message.
3097
3098 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3099
3100         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3101         https://bugs.webkit.org/show_bug.cgi?id=130155
3102
3103         Reviewed by Philippe Normand.
3104
3105         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3106
3107 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3108
3109         [GTK] MiniBrowser fails to load injected bundle lib
3110         https://bugs.webkit.org/show_bug.cgi?id=130332
3111
3112         Reviewed by Anders Carlsson.
3113
3114         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3115
3116         * MiniBrowser/gtk/main.c:
3117         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3118         process is spawn.
3119
3120 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3121
3122         [EFL] Enable TOUCH_SLIDER macro
3123         https://bugs.webkit.org/show_bug.cgi?id=130185
3124
3125         Reviewed by Gyuyoung Kim.
3126
3127         * Scripts/webkitperl/FeatureList.pm:
3128
3129 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3130
3131         [GTK][CMake] Build with -fno-rtti
3132         https://bugs.webkit.org/show_bug.cgi?id=130261
3133
3134         Reviewed by Martin Robinson.
3135
3136         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3137         defined to 0 to prevent typeid use in included GTest headers.
3138
3139 2014-03-16  Brian Burg  <bburg@apple.com>
3140
3141         Web Inspector: vended backend commands file should be generated as part of the build
3142         https://bugs.webkit.org/show_bug.cgi?id=130110
3143
3144         Reviewed by Timothy Hatcher.
3145
3146         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3147
3148 2014-03-16  Diego Pino García  <dpino@igalia.com>
3149
3150         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3151         https://bugs.webkit.org/show_bug.cgi?id=128999
3152
3153         Reviewed by Philippe Normand.
3154
3155         * MiniBrowser/gtk/BrowserWindow.c:
3156         (reloadPage):
3157         (reloadPageIgnoringCache):
3158         (browser_window_init):
3159
3160 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3161
3162         [GTK] Improve ninja detection in webkitdirs.pm
3163         https://bugs.webkit.org/show_bug.cgi?id=129902
3164
3165         Reviewed by Daniel Bates.
3166
3167         * Scripts/webkitdirs.pm:
3168         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3169         us to look for ninja-build as well.
3170
3171 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3172
3173         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3174         https://bugs.webkit.org/show_bug.cgi?id=130276
3175         <rdar://problem/16266927>
3176         
3177         Reviewed by Simon Fraser.
3178
3179         * BuildSlaveSupport/build-launcher-app:
3180         * BuildSlaveSupport/build-launcher-dmg:
3181         * DumpRenderTree/DumpRenderTree.h:
3182         * DumpRenderTree/DumpRenderTreePrefix.h:
3183         * DumpRenderTree/GCController.cpp:
3184         * DumpRenderTree/GCController.h:
3185         * DumpRenderTree/JavaScriptThreading.cpp:
3186         * DumpRenderTree/JavaScriptThreading.h:
3187         * DumpRenderTree/PixelDumpSupport.cpp:
3188         * DumpRenderTree/PixelDumpSupport.h:
3189         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3190         * DumpRenderTree/TestRunner.cpp:
3191         * DumpRenderTree/TestRunner.h:
3192         * DumpRenderTree/WorkQueue.cpp:
3193         * DumpRenderTree/WorkQueue.h:
3194         * DumpRenderTree/WorkQueueItem.h:
3195         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3196         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3197         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3198         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3199         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3200         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3201         * DumpRenderTree/efl/EditingCallbacks.cpp:
3202         * DumpRenderTree/efl/EditingCallbacks.h:
3203         * DumpRenderTree/efl/EventSender.cpp:
3204         * DumpRenderTree/efl/EventSender.h:
3205         * DumpRenderTree/efl/GCControllerEfl.cpp:
3206         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3207         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3209         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3210         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3211         * DumpRenderTree/gtk/EditingCallbacks.h:
3212         * DumpRenderTree/gtk/EventSender.cpp:
3213         * DumpRenderTree/gtk/EventSender.h:
3214         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3215         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3216         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3217         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3218         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3219         * DumpRenderTree/gtk/TextInputController.cpp:
3220         * DumpRenderTree/gtk/TextInputController.h:
3221         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3222         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3223         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3224         * DumpRenderTree/mac/AppleScriptController.h:
3225         * DumpRenderTree/mac/AppleScriptController.m:
3226         * DumpRenderTree/mac/CheckedMalloc.cpp:
3227         * DumpRenderTree/mac/CheckedMalloc.h:
3228         * DumpRenderTree/mac/DumpRenderTree.mm:
3229         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3230         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3231         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3232         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3233         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3234         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3235         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3236         * DumpRenderTree/mac/EditingDelegate.h:
3237         * DumpRenderTree/mac/EditingDelegate.mm:
3238         * DumpRenderTree/mac/EventSendingController.h:
3239         * DumpRenderTree/mac/EventSendingController.mm:
3240         * DumpRenderTree/mac/FrameLoadDelegate.h:
3241         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3242         * DumpRenderTree/mac/GCControllerMac.mm:
3243         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3244         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3245         * DumpRenderTree/mac/NavigationController.h:
3246         * DumpRenderTree/mac/NavigationController.m:
3247         * DumpRenderTree/mac/ObjCController.h:
3248         * DumpRenderTree/mac/ObjCController.m:
3249         * DumpRenderTree/mac/ObjCPlugin.h:
3250         * DumpRenderTree/mac/ObjCPlugin.m:
3251         * DumpRenderTree/mac/ObjCPluginFunction.h:
3252         * DumpRenderTree/mac/ObjCPluginFunction.m:
3253         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3254         * DumpRenderTree/mac/PolicyDelegate.h:
3255         * DumpRenderTree/mac/PolicyDelegate.mm:
3256         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3257         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3258         * DumpRenderTree/mac/TestRunnerMac.mm:
3259         * DumpRenderTree/mac/TextInputController.h:
3260         * DumpRenderTree/mac/TextInputController.m:
3261         * DumpRenderTree/mac/UIDelegate.h:
3262         * DumpRenderTree/mac/UIDelegate.mm:
3263         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3264         * DumpRenderTree/win/DRTDataObject.cpp:
3265         * DumpRenderTree/win/DRTDataObject.h:
3266         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3267         * DumpRenderTree/win/DRTDropSource.cpp:
3268         * DumpRenderTree/win/DRTDropSource.h:
3269         * DumpRenderTree/win/DraggingInfo.h:
3270         * DumpRenderTree/win/DumpRenderTree.cpp:
3271         * DumpRenderTree/win/DumpRenderTreeWin.h:
3272         * DumpRenderTree/win/EditingDelegate.cpp:
3273         * DumpRenderTree/win/EditingDelegate.h:
3274         * DumpRenderTree/win/EventSender.cpp:
3275         * DumpRenderTree/win/EventSender.h:
3276         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3277         * DumpRenderTree/win/FrameLoadDelegate.h:
3278         * DumpRenderTree/win/GCControllerWin.cpp:
3279         * DumpRenderTree/win/HistoryDelegate.cpp:
3280         * DumpRenderTree/win/HistoryDelegate.h:
3281         * DumpRenderTree/win/MD5.cpp:
3282         * DumpRenderTree/win/MD5.h:
3283         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3284         * DumpRenderTree/win/PolicyDelegate.cpp:
3285         * DumpRenderTree/win/PolicyDelegate.h:
3286         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3287         * DumpRenderTree/win/ResourceLoadDelegate.h:
3288         * DumpRenderTree/win/TestRunnerWin.cpp:
3289         * DumpRenderTree/win/TextInputController.cpp:
3290         * DumpRenderTree/win/TextInputController.h:
3291         * DumpRenderTree/win/TextInputControllerWin.cpp:
3292         * DumpRenderTree/win/UIDelegate.cpp:
3293         * DumpRenderTree/win/UIDelegate.h:
3294         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3295         * EWebLauncher/main.c:
3296         * GtkLauncher/main.c:
3297         * ImageDiff/efl/ImageDiff.cpp:
3298         * ImageDiff/gtk/ImageDiff.cpp:
3299         * MiniBrowser/gtk/main.c:
3300         * Scripts/SpacingHeuristics.pm:
3301         * Scripts/VCSUtils.pm:
3302         * Scripts/bisect-builds:
3303         * Scripts/build-dumprendertree:
3304         * Scripts/build-jsc:
3305         * Scripts/build-webkit:
3306         * Scripts/check-dom-results:
3307         * Scripts/check-for-exit-time-destructors:
3308         * Scripts/check-for-global-initializers:
3309         * Scripts/commit-log-editor:
3310         * Scripts/compare-timing-files:
3311         * Scripts/debug-minibrowser:
3312         * Scripts/debug-safari:
3313         * Scripts/do-file-rename:
3314         * Scripts/find-extra-includes:
3315         * Scripts/generate-coverage-data:
3316         * Scripts/make-script-test-wrappers:
3317         * Scripts/malloc-tree:
3318         * Scripts/old-run-webkit-tests:
3319         * Scripts/parse-malloc-history:
3320         * Scripts/report-include-statistics:
3321         * Scripts/resolve-ChangeLogs:
3322         * Scripts/run-bindings-tests:
3323         * Scripts/run-iexploder-tests:
3324         * Scripts/run-javascriptcore-tests:
3325         * Scripts/run-jsc:
3326         * Scripts/run-launcher:
3327         * Scripts/run-leaks:
3328         * Scripts/run-mangleme-tests:
3329         * Scripts/run-minibrowser:
3330         * Scripts/run-pageloadtest:
3331         * Scripts/run-regexp-tests:
3332         * Scripts/run-safari:
3333         * Scripts/run-sunspider:
3334         * Scripts/run-webkit-app:
3335         * Scripts/sampstat:
3336         * Scripts/set-webkit-configuration:
3337         * Scripts/sort-Xcode-project-file:
3338         * Scripts/sort-export-file:
3339         * Scripts/split-file-by-class:
3340         * Scripts/sunspider-compare-results:
3341         * Scripts/svn-apply:
3342         * Scripts/svn-create-patch:
3343         * Scripts/svn-unapply:
3344         * Scripts/test-webkit-scripts:
3345         * Scripts/update-javascriptcore-test-results:
3346         * Scripts/update-webkit:
3347         * Scripts/update-webkit-auxiliary-libs:
3348         * Scripts/update-webkit-dependency:
3349         * Scripts/update-webkit-localizable-strings:
3350         * Scripts/update-webkit-support-libs:
3351         * Scripts/update-webkit-wincairo-libs:
3352         * Scripts/webkit-build-directory:
3353         * Scripts/webkitdirs.pm:
3354         (installedSafariPath):
3355         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3356         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3357         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3358         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3359         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3360         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3361         * Scripts/webkitperl/features.pm:
3362         * Scripts/webkitperl/httpd.pm:
3363         * Scripts/webkitpy/bindings/main.py:
3364         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3365         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3366         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3367         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3368         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3369         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3370         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3371         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3372         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3373         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3374         * WebKitTestRunner/PixelDumpSupport.cpp:
3375         * WebKitTestRunner/PixelDumpSupport.h:
3376         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3377         * WinLauncher/WinLauncher.cpp:
3378         * WinLauncher/WinLauncher.h:
3379         * WinLauncher/stdafx.cpp:
3380         * WinLauncher/stdafx.h:
3381
3382 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3383
3384         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3385         https://bugs.webkit.org/show_bug.cgi?id=130265
3386
3387         Reviewed by Michael Saboff.
3388
3389         * Scripts/build-webkit:
3390         * Scripts/copy-webkitlibraries-to-product-directory:
3391
3392 2014-03-14  Landry Breuil  <landry@openbsd.org>
3393
3394         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3395         Also allow to set MAKE in the environment.
3396         https://bugs.webkit.org/show_bug.cgi?id=129991
3397
3398         Reviewed by Andreas Kling.
3399
3400         * Scripts/webkitdirs.pm:
3401         (determineArchitecture):
3402         (determineNumberOfCPUs):
3403         (isBSD):
3404         (buildAutotoolsProject):
3405         * Scripts/webkitpy/common/system/platforminfo.py:
3406         (PlatformInfo.__init__):
3407         (PlatformInfo.is_openbsd):
3408         (PlatformInfo):
3409         (PlatformInfo.is_netbsd):
3410         (PlatformInfo._determine_os_name):
3411
3412 2014-03-14  Dean Jackson  <dino@apple.com>
3413
3414         Remove libWebKitSystemInterfaceLion.a
3415         https://bugs.webkit.org/show_bug.cgi?id=130254
3416
3417         Reviewed by Geoffrey Garen and Andreas Kling.
3418
3419         No need to copy the Lion libraries into the build.
3420
3421         * Scripts/copy-webkitlibraries-to-product-directory:
3422
3423 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3424
3425         [EFL][MiniBrowser] Revise help messages of command line parameters
3426         https://bugs.webkit.org/show_bug.cgi?id=130222
3427
3428         Reviewed by Csaba Osztrogonác.
3429
3430         Correct the default value description and make help messages to be consistent.
3431
3432         * MiniBrowser/efl/main.c:
3433
3434 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3435
3436         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3437         https://bugs.webkit.org/show_bug.cgi?id=129612
3438
3439         Reviewed by Darin Adler.
3440
3441         For new code use static NeverDestroyed<T> instead.
3442
3443         * DumpRenderTree/JavaScriptThreading.cpp:
3444         (javaScriptThreadsMutex):
3445         (javaScriptThreads):
3446         * DumpRenderTree/efl/EventSender.cpp:
3447         (touchPointList):
3448         (delayedEventQueue):
3449         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3450         (delegatesWithDelayedWork):
3451         * Scripts/check-for-exit-time-destructors:
3452         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3453         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3454         (testsMap):
3455
3456 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3457
3458         [EFL][WK2] Fix compilation warning in Minibrowser
3459         https://bugs.webkit.org/show_bug.cgi?id=130132
3460
3461         Reviewed by Csaba Osztrogonác.
3462
3463         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3464
3465         * MiniBrowser/efl/main.c:
3466         (on_download_request):
3467
3468 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3469
3470         FTL should support IsBlah
3471         https://bugs.webkit.org/show_bug.cgi?id=130202
3472
3473         Reviewed by Geoffrey Garen.
3474         
3475         Running existing JSRegress tests with noInline gives us coverage for these
3476         changes. Chances are, this will also give coverage for other interesting things
3477         as well.
3478
3479         * Scripts/run-jsc-stress-tests:
3480
3481 2014-03-12  Brian Burg  <bburg@apple.com>
3482
3483         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3484         https://bugs.webkit.org/show_bug.cgi?id=129744
3485
3486         Reviewed by Timothy Hatcher.
3487
3488         * DumpRenderTree/TestRunner.cpp:
3489         (evaluateInWebInspectorCallback):
3490         * DumpRenderTree/TestRunner.h:
3491         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3492         (TestRunner::evaluateInWebInspector):
3493         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3494         (TestRunner::evaluateInWebInspector):
3495         * DumpRenderTree/mac/TestRunnerMac.mm:
3496         (TestRunner::evaluateInWebInspector):
3497         * DumpRenderTree/win/TestRunnerWin.cpp:
3498         (TestRunner::evaluateInWebInspector):
3499         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3500         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3501         (WTR::TestRunner::evaluateInWebInspector):
3502         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3503
3504 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3505
3506         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3507         https://bugs.webkit.org/show_bug.cgi?id=130129
3508
3509         Reviewed by Csaba Osztrogonác.
3510
3511         * Scripts/webkitdirs.pm:
3512         (canUseNinja): Redirecting stderr to /dev/null
3513
3514 2014-03-13  Andres Gomez  <agomez@igalia.com>
3515
3516         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3517         https://bugs.webkit.org/show_bug.cgi?id=130092
3518
3519         Reviewed by Csaba Osztrogonác.
3520
3521         Added "python-dev" as dependency for deb based distros. It is
3522         already present for rpm based distros. This dependency will allow
3523         libxml2 to generate its python bindings, needed by gtk-doc.
3524
3525         * gtk/install-dependencies:
3526
3527 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3528
3529         Unreviewed. Fix GTK+ cmake build after r165488.
3530
3531         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3532
3533 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3534
3535         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3536         https://bugs.webkit.org/show_bug.cgi?id=130014
3537
3538         Reviewed by Martin Robinson.
3539
3540         Include cmake or autotools config header.
3541
3542         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3543         * MiniBrowser/gtk/BrowserSearchBar.c:
3544         * MiniBrowser/gtk/BrowserWindow.c:
3545         * MiniBrowser/gtk/main.c:
3546
3547 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3548
3549         Unreviewed, rolling out r165471.
3550         https://bugs.webkit.org/show_bug.cgi?id=130139
3551
3552         Didn't really fix the issue and broke another bot (Requested
3553         by mrobinson on #webkit).
3554
3555         Reverted changeset:
3556
3557         "[CMake] Newer versions of CMake cannot find older versions of
3558         Freetype"
3559         https://bugs.webkit.org/show_bug.cgi?id=130107
3560         http://trac.webkit.org/changeset/165471
3561
3562 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3563
3564         It should be possible to build WebKit with FTL on iOS
3565         https://bugs.webkit.org/show_bug.cgi?id=130116
3566
3567         Reviewed by Dan Bernstein.
3568
3569         * Scripts/build-webkit:
3570         * Scripts/copy-webkitlibraries-to-product-directory:
3571
3572 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3573
3574         [Win] Remove use of QTSDK
3575         https://bugs.webkit.org/show_bug.cgi?id=130049
3576
3577         Reviewed by Darin Adler.
3578
3579         * DumpRenderTree/win/DumpRenderTree.cpp:
3580         (initialize): Remove QuickTime code.
3581         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3582         building QTMovieWin.
3583
3584 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3585
3586         [GTK][CMAKE] Too verbose build output
3587         https://bugs.webkit.org/show_bug.cgi?id=130076
3588
3589         Reviewed by Carlos Garcia Campos.
3590
3591         Instead of building with cmake --build which isn't smart about pretty printing and
3592         colors, we build with a script which calls the proper build command.
3593
3594         * Scripts/webkitdirs.pm:
3595         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3596         the CMake configuration pass.
3597
3598 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3599
3600         [CMake] Newer versions of CMake cannot find older versions of Freetype
3601         https://bugs.webkit.org/show_bug.cgi?id=130107
3602
3603         Reviewed by Gustavo Noronha Silva.
3604
3605         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3606         to CMake during jhbuild initialization.
3607
3608 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3609
3610         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3611         https://bugs.webkit.org/show_bug.cgi?id=129961
3612
3613         Reviewed by Simon Fraser.
3614
3615         Now scaled content can go through the window capturing mechanism too for compositing content.
3616         AppleMagnifiedMode is redundant.
3617
3618         * DumpRenderTree/mac/DumpRenderTree.mm:
3619         (setDefaultsToConsistentValuesForTesting):
3620         (runTest):
3621         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3622         (createBitmapContextFromWebView):
3623         * WebKitTestRunner/PlatformWebView.h:
3624         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3625         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3626         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3627         (WTR::PlatformWebView::didInitializeClients):
3628         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3629         (WTR::PlatformWebView::forceWindowFramesChanged):
3630         * WebKitTestRunner/mac/main.mm:
3631         (setDefaultsToConsistentValuesForTesting):
3632
3633 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3634
3635         Unreviewed. Add myself as a committer.
3636
3637         * Scripts/webkitpy/common/config/contributors.json:
3638
3639 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3640
3641         Unreviewed build fix on the EFL port when used lower version of ATK
3642
3643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3644         (WTR::AccessibilityUIElement::y): Fixed typo.
3645
3646 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3647
3648         Some images are blank in the rebaseline server UI
3649         https://bugs.webkit.org/show_bug.cgi?id=130104
3650
3651         Reviewed by Tim Horton.
3652
3653         Let the server check for images in the 'retries' directory
3654         if it can't find an image otherwise.
3655
3656         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3657         (RebaselineHTTPRequestHandler.test_result):
3658
3659 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3660
3661         [GTK][CMake] --update-gtk has no effect
3662         https://bugs.webkit.org/show_bug.cgi?id=130088
3663
3664         Reviewed by Philippe Normand.
3665
3666         * Scripts/webkitdirs.pm:
3667         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3668         as an argument.
3669
3670 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3671
3672         Add "System Font" to the list of whitelisted DRT fonts
3673         https://bugs.webkit.org/show_bug.cgi?id=130046
3674
3675         Reviewed by Darin Adler.
3676
3677         * DumpRenderTree/mac/DumpRenderTree.mm:
3678         (allowedFontFamilySet):
3679         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3680
3681 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3682
3683         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3684         https://bugs.webkit.org/show_bug.cgi?id=130064
3685
3686         Reviewed by Philippe Normand.
3687
3688         * efl/jhbuildrc: Remove duplicated code.
3689         * gtk/jhbuildrc: Remove duplicated code.
3690         * jhbuild/jhbuildrc_common.py:
3691         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3692         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3693         and is apparently necessary for GTK+.
3694
3695 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3696
3697         check-webkit-style failed to complain about missing braces
3698         https://bugs.webkit.org/show_bug.cgi?id=34189
3699
3700         Reviewed by Ryosuke Niwa.
3701
3702         * Scripts/webkitpy/style/checkers/cpp.py:
3703         (check_braces):
3704         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3705         (WebKitStyleTest.test_braces):
3706
3707 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3708
3709         Remove Qt cruft from style checker.
3710         https://bugs.webkit.org/show_bug.cgi?id=130085
3711
3712         Reviewed by Csaba Osztrogonác.
3713
3714         There is no 'foreach' keyword in c++. That was a Qt feature
3715         added in: http://trac.webkit.org/changeset/46113
3716         Qt was removed from WebKit, so we should remove the checks
3717         of this keyword from check-webkit-style scripts.
3718
3719         * Scripts/webkitpy/style/checkers/cpp.py:
3720         (check_spacing_for_function_call):
3721         (check_spacing):
3722         (check_braces):
3723         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3724         (CppStyleTest.test_mismatching_spaces_in_parens):
3725         (CppStyleTest.test_spacing_for_fncall):
3726         (WebKitStyleTest.test_braces):
3727
3728 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3729
3730         [GTK] update-webkitgtk-libs needs itstool
3731         https://bugs.webkit.org/show_bug.cgi?id=130082
3732
3733         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3734         itstool is a dependency of building gtk-doc from version 1.19, so it should
3735         be added to Tools/gtk/install-dependencies script, too.
3736
3737         Reviewed by Philippe Normand.
3738
3739         * gtk/install-dependencies:
3740
3741 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3742
3743         webkitbot rollout ChangeLogs should be nicer
3744         https://bugs.webkit.org/show_bug.cgi?id=122654
3745
3746         Reviewed by Csaba Osztrogonác.
3747
3748         Added bug urls and descriptions of rolled out patches to the rollout changelog
3749         if they are present in the original changelog. Additionally removed the list of
3750         changed files and functions.
3751
3752         * Scripts/webkitpy/common/checkout/changelog.py:
3753         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3754         * Scripts/webkitpy/common/checkout/checkout.py:
3755         (Checkout._changelog_data_for_revision): Store bug description.
3756         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3757         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3758         (CheckoutTest.test_commit_info_for_revision):
3759         * Scripts/webkitpy/common/checkout/commitinfo.py:
3760         (CommitInfo.bug_description): Added.
3761         (CommitInfo.to_json):
3762         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3763         (CommitInfoTest.test_commit_info_creation):
3764         * Scripts/webkitpy/tool/commands/download.py:
3765         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3766         out patches for creating rollout changelog.
3767         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3768         caused the regression is stored in state["bug_blocked"] now.
3769         * Scripts/webkitpy/tool/commands/download_unittest.py:
3770         (test_prepare_rollout):
3771         (test_create_rollout_multiple_revision):
3772         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3773         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3774         rolled out patches to the changelog.
3775         (PrepareChangeLogForRevert.run):
3776         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3777         (UpdateChangeLogsForRevertTest):
3778         (test_message_for_revert):
3779         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3780         (ReopenBugAfterRollout.run):
3781
3782 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3783
3784         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3785         https://bugs.webkit.org/show_bug.cgi?id=130021
3786
3787         Reviewed by Mario Sanchez Prada.
3788
3789         Replace deprecated functions to use new API from ATK 2.11.90.
3790
3791         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3792         (AccessibilityUIElement::x):
3793         (AccessibilityUIElement::y):
3794         (AccessibilityUIElement::width):
3795         (AccessibilityUIElement::height):
3796         (AccessibilityUIElement::clickPointX):
3797         (AccessibilityUIElement::clickPointY):
3798         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3799         (WTR::AccessibilityUIElement::x):
3800         (WTR::AccessibilityUIElement::y):
3801         (WTR::AccessibilityUIElement::width):
3802         (WTR::AccessibilityUIElement::height):
3803         (WTR::AccessibilityUIElement::clickPointX):
3804         (WTR::AccessibilityUIElement::clickPointY):
3805
3806 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3807
3808         [ATK] Expose aria-posinset and aria-setsize through object attributes
3809         https://bugs.webkit.org/show_bug.cgi?id=130011
3810
3811         Reviewed by Chris Fleizach.
3812
3813         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3814
3815         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3816         (AccessibilityUIElement::numberAttributeValue):
3817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3818         (WTR::AccessibilityUIElement::numberAttributeValue):
3819
3820 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3821
3822         [Win] Unreviewed build fix.
3823
3824         Some bad Windows code was committed at some point that prevents the Apple Windows port
3825         from finding its runtime dependencies reliably.
3826
3827         * win/DLLLauncher/DLLLauncherMain.cpp:
3828         (appleApplicationSupportDirectory): Restored this function.
3829         (modifyPath): Update to use appleApplicationSupportDirectory function.
3830
3831 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3832
3833         Let the user define the full address of the performance-site-server for uploading results
3834         https://bugs.webkit.org/show_bug.cgi?id=129819
3835
3836         Reviewed by Ryosuke Niwa.
3837
3838         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3839         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3840         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3841         protocol for now, in order to avoid breaking the perf bots.
3842
3843         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3844         (_upload_json):
3845         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3846         (MainTest.test_upload_json):
3847
3848 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3849
3850         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3851         https://bugs.webkit.org/show_bug.cgi?id=130023
3852
3853         Reviewed by Dean Jackson.
3854
3855         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3856         /SAFESEH flag to DLL launcher process.
3857
3858 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3859
3860         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3861         https://bugs.webkit.org/show_bug.cgi?id=129980
3862
3863         Reviewed by Carlos Garcia Campos.
3864
3865         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3866
3867 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3868
3869         [GTK] Remove the WebView source-mode WebKit1 test
3870         https://bugs.webkit.org/show_bug.cgi?id=129976
3871
3872         Reviewed by Carlos Garcia Campos.
3873
3874         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3875
3876 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3877
3878         Unreviewed build fix for GTKbuild after the switch to CMake
3879
3880         * gtk/common.py:
3881         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3882         test-only bot doesn't have any build files.
3883
3884 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3885
3886         [GTK] built-product-archive does not handle GTK+ CMake build
3887         https://bugs.webkit.org/show_bug.cgi?id=129941
3888
3889         * BuildSlaveSupport/built-product-archive:
3890         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3891         the CMake build.
3892
3893 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3894
3895         [GTK] Include CMake into install-dependencies script
3896         https://bugs.webkit.org/show_bug.cgi?id=129909
3897
3898         Reviewed by Martin Robinson.
3899
3900         As since r165267 buid-webkit uses CMake by default, the dependency
3901         with 'cmake' package should be introduced.
3902
3903         * gtk/install-dependencies: Ditto.
3904
3905 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3906
3907         REGRESSION(165267): Broke a webkitpy unit tests
3908         https://bugs.webkit.org/show_bug.cgi?id=129904
3909
3910         Reviewed by Jon Honeycutt.
3911
3912         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3913         (GtkPort._is_cmake_build):
3914
3915 2014-03-07  Andres Gomez  <agomez@igalia.com>
3916
3917         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3918         https://bugs.webkit.org/show_bug.cgi?id=129893
3919
3920         Reviewed by Martin Robinson.
3921
3922         Added "git-svn" as dependency for deb based distros and,
3923         additionally, "subversion" for rpm based distros.
3924
3925         * gtk/install-dependencies:
3926
3927 2014-03-07  Roger Fong  <roger_fong@apple.com>
3928
3929         Remove dummy setSystemWebGLLoadPolicy client method.
3930         https://bugs.webkit.org/show_bug.cgi?id=129873.
3931
3932         Reviewed by Dean Jackson.
3933
3934         * WebKitTestRunner/TestController.cpp:
3935         (WTR::TestController::createWebViewWithOptions):
3936
3937 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3938
3939         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3940         https://bugs.webkit.org/show_bug.cgi?id=129886
3941
3942         Reviewed by Mark Lam.
3943
3944         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3945         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3946         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3947         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3948         make it through when in non-verbose mode.
3949
3950 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3951
3952         [GTK] buid-webkit should use CMake by default
3953         https://bugs.webkit.org/show_bug.cgi?id=129855
3954
3955         Reviewed by Carlos Garcia Campos.
3956
3957         Make the CMake build the default GTK+ build when using build-webkit. This will
3958         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3959         so that we have --gtk and --gtkautotools.
3960
3961         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3962         * Scripts/webkitpy/port/gtk.py: Ditto.
3963
3964 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3965
3966         [CMake] [GTK] Build with ninja when it is available
3967         https://bugs.webkit.org/show_bug.cgi?id=129805
3968
3969         Reviewed by Philippe Normand.
3970
3971         * Scripts/webkitdirs.pm:
3972         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3973         if it's available on the system.
3974         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3975         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3976
3977 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3978
3979         If the FTL is build-time enabled then it should be run-time enabled.
3980
3981         Rubber stamped by Geoffrey Garen.
3982
3983         * Scripts/run-jsc-stress-tests:
3984
3985 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3986
3987         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3988         https://bugs.webkit.org/show_bug.cgi?id=129837
3989
3990         Reviewed by Michael Saboff.
3991
3992         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3993         The fix is to use find instead of ls like we do in shell-runner.sh.
3994
3995         * Scripts/run-jsc-stress-tests:
3996
3997 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3998
3999         filter-build-webkit should not strip .o
4000         https://bugs.webkit.org/show_bug.cgi?id=129614
4001
4002         Reviewed by Dean Jackson.
4003
4004         This makes it much easier to jump from the failing output at
4005         the end back up to the compile errors earlier in the output.
4006
4007         * Scripts/filter-build-webkit:
4008
4009 2014-03-06  Anders Carlsson  <andersca@apple.com>
4010
4011         Build WebKit2 before building WebKit
4012         https://bugs.webkit.org/show_bug.cgi?id=129831
4013         <rdar://problem/15920020>
4014
4015         Reviewed by Dan Bernstein.
4016
4017         * Scripts/build-webkit:
4018         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4019
4020 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4021
4022         make-3.82 fails to build on ARM/Linux
4023         https://bugs.webkit.org/show_bug.cgi?id=107926
4024
4025         Reviewed by Martin Robinson.
4026
4027         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4028         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4029         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4030         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4031
4032         * gtk/patches/make-3.82-arg-list-length.patch:
4033
4034 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4035
4036         [GTK] Close the page when the view is disposed instead of when finalized
4037         https://bugs.webkit.org/show_bug.cgi?id=129783
4038
4039         Reviewed by Sergio Villar Senin.
4040
4041         Add test case but disabled for now because it's affetected by bug #129684.
4042
4043         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4044         (testProcessPerWebView):
4045
4046 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4047
4048         [GTK] MiniBrowser crashes when opening several urls passed as command line options
4049         https://bugs.webkit.org/show_bug.cgi?id=129738
4050
4051         Reviewed by Sergio Villar Senin.
4052
4053         The problem is that we are calling g_object_unref() for the
4054         WebKitWebSettings everytime we set it to a WebKitWebView, but the
4055         view only increases the reference counter when the settings is not
4056         the same it currently has. We should release our reference once.
4057
4058         * MiniBrowser/gtk/main.c:
4059         (createBrowserWindow):
4060         (main):
4061
4062 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4063
4064         [GTK][CMake] Tarball is created with wrong tarball paths
4065         https://bugs.webkit.org/show_bug.cgi?id=129496
4066
4067         Reviewed by Daniel Bates.
4068
4069         * gtk/make-dist.py:
4070         (Manifest.__init__): I inadvertently inverted the logic of these checks when
4071         landing the original patch with some suggestions from the reviewer. With the
4072         checks corrected, the tarball path is constructed properly.
4073
4074 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
4075
4076         Unreviewed. Update my email in contributors.json
4077
4078         * Scripts/webkitpy/common/config/contributors.json:
4079
4080 2014-03-05  Dean Jackson  <dino@apple.com>
4081
4082         [WebGL] Use WKSI to see what the system policy for WebGL is
4083         https://bugs.webkit.org/show_bug.cgi?id=129722
4084         <rdar://problem/15790542>
4085
4086         Reviewed by Tim Horton.
4087
4088         Dummy entry for setSystemWebGLLoadPolicy.
4089
4090         * WebKitTestRunner/TestController.cpp:
4091         (WTR::TestController::createWebViewWithOptions):
4092
4093 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
4094
4095         [GTK][CMake] Generate documentation for the DOM bindings
4096         https://bugs.webkit.org/show_bug.cgi?id=126211
4097
4098         Reviewed by Carlos Garcia Campos.
4099
4100         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
4101         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
4102         * gtk/generate-webkitdom-doc-files: Removed.
4103         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
4104         that it can be called by generate-gtkdoc.
4105
4106 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4107
4108         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
4109         https://bugs.webkit.org/show_bug.cgi?id=129380
4110
4111         Reviewed by Philippe Normand.
4112
4113         * Scripts/webkitdirs.pm:
4114         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
4115         skipping CMake execution.
4116
4117 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4118
4119         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
4120         https://bugs.webkit.org/show_bug.cgi?id=129651
4121
4122         Reviewed by Philippe Normand.
4123
4124         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
4125
4126 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4127
4128         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
4129         https://bugs.webkit.org/show_bug.cgi?id=129637
4130
4131         Reviewed by Carlos Garcia Campos.
4132
4133         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4134         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
4135         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
4136         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
4137         New API typically just requires a rebaseline and isn't necessarily a faiulre.
4138         (TestFactory.__init__): Add the test for GTK+.
4139         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
4140
4141 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
4142
4143         [ATK] Expose missing functionalities of AtkTableCell to AT
4144         https://bugs.webkit.org/show_bug.cgi?id=129492
4145
4146         Reviewed by Mario Sanchez Prada.
4147
4148         Reducing some code by using new API of AtkTableCell.
4149
4150         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4151         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4152
4153 2014-03-04  Alex Christensen  <achristensen@webkit.org>
4154
4155         Preparing to run layout tests on Wincairo.
4156         https://bugs.webkit.org/show_bug.cgi?id=129709
4157
4158         Reviewed by Brent Fulgham.
4159
4160         * Scripts/webkitdirs.pm:
4161         (setPathForRunningWebKitApp):
4162         Add GStreamer directory for WinCairo running layout tests.
4163         * win/DLLLauncher/DLLLauncherMain.cpp:
4164         (modifyPath):
4165         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
4166
4167 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
4168
4169         [GTK] Simplify the GObject DOM bindings API break check into one step
4170         https://bugs.webkit.org/show_bug.cgi?id=129571
4171
4172         Reviewed by Carlos Garcia Campos.
4173
4174         * GNUmakefile.am: Add the API break check to 'make check.'
4175         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
4176         * gtk/check-gdom-symbols: Removed.
4177         * gtk/webkitdom.py: Added.
4178         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
4179         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
4180
4181 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
4182
4183         Add Jeremy Jones to the contributors list as a contributor.
4184
4185         * Scripts/webkitpy/common/config/contributors.json:
4186
4187 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4188
4189         Unreviewed. Update contact email.
4190         https://bugs.webkit.org/show_bug.cgi?id=129610
4191
4192         * Scripts/webkitpy/common/config/contributors.json:
4193
4194 2014-03-02  Brian Burg  <bburg@apple.com>
4195
4196         Web Inspector model tests load wrong inspector page under WebKitTestRunner
4197         https://bugs.webkit.org/show_bug.cgi?id=129460
4198
4199         Reviewed by Dan Bernstein.
4200
4201         Don't unconditionally open the inspector before running an inspector test.
4202         Instead, the test should request that the inspector open when it's ready.
4203
4204         This change was lost during a rebase, but is the same change made to
4205         DumpRenderTree.
4206
4207         * WebKitTestRunner/TestInvocation.cpp:
4208         (WTR::TestInvocation::invoke): 
4209
4210 2014-03-02  Darin Adler  <darin@apple.com>
4211
4212         Split TextIteratorBehavior into a separate header
4213         https://bugs.webkit.org/show_bug.cgi?id=129578
4214
4215         Reviewed by Sam Weinig.
4216
4217         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
4218         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
4219         task easy, but the remove is still a bit of a pain.
4220
4221 2014-03-02  Darin Adler  <darin@apple.com>
4222
4223         Sort Mac platform export files so they merge better
4224         https://bugs.webkit.org/show_bug.cgi?id=129581
4225
4226         Reviewed by Sam Weinig.
4227
4228         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
4229         Mac export files in a "canonical" order for this project.
4230
4231 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4232
4233         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4234         https://bugs.webkit.org/show_bug.cgi?id=129438
4235
4236         Reviewed by Simon Fraser.
4237
4238         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4239         offscreen window. It makes testing subpixel rendering and positioning possible.
4240
4241         Both the offscreen window's and WebKit's scaling are set accordingly.
4242
4243         * DumpRenderTree/mac/DumpRenderTree.mm:
4244         (createWebViewAndOffscreenWindow): cleanup
4245         (destroyWebViewAndOffscreenWindow): cleanup
4246         (dumpRenderTree):
4247         (changeWindowScaleIfNeeded):
4248         (runTest):
4249         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4250         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4251         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
4252         * WebKitTestRunner/PlatformWebView.h:
4253         * WebKitTestRunner/TestInvocation.cpp:
4254         (WTR::changeWindowScaleIfNeeded):
4255         (WTR::TestInvocation::invoke):
4256         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4257         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4258         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4259         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4260         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4261         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4262         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4263         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4264
4265 2014-02-28  Anders Carlsson  <andersca@apple.com>
4266
4267         Remove logging.
4268
4269         Reviewed by Dan Bernstein.
4270
4271         * MiniBrowser/mac/WK2BrowserWindowController.m:
4272         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
4273
4274 2014-02-28  Daniel Bates  <dabates@apple.com>
4275
4276         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
4277         https://bugs.webkit.org/show_bug.cgi?id=129163
4278
4279         Reviewed by David Kilzer.
4280
4281         Fixes an issue where DumpRenderTree Perl Support may build with the specified
4282         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
4283         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
4284         bundle.
4285
4286         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
4287         which is specified either explicitly when building with MAKE(1) or implicitly by
4288         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
4289         the OS X SDK and toolchain since the built products are only applicable to OS X.
4290
4291         * DumpRenderTree/ios/PerlSupport/Makefile:
4292
4293 2014-02-28  Commit Queue  <commit-queue@webkit.org>
4294
4295         Unreviewed, rolling out r164859.
4296         http://trac.webkit.org/changeset/164859
4297         https://bugs.webkit.org/show_bug.cgi?id=129483
4298
4299         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
4300         #webkit).
4301
4302         * DumpRenderTree/mac/DumpRenderTree.mm:
4303         (createWebViewAndOffscreenWindow):
4304         (dumpRenderTree):
4305         (runTest):
4306         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4307         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4308         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
4309         * WebKitTestRunner/PlatformWebView.h:
4310         * WebKitTestRunner/TestInvocation.cpp:
4311         (WTR::TestInvocation::invoke):
4312         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4313         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4314         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4315         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4316         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
4317
4318 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4319
4320         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4321         https://bugs.webkit.org/show_bug.cgi?id=129438
4322
4323         Reviewed by Simon Fraser.
4324
4325       &nbs