[ews-app] status-bubble should display position in queue
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] status-bubble should display position in queue
4         https://bugs.webkit.org/show_bug.cgi?id=196607
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
9         (StatusBubble._build_bubble):
10         (StatusBubble._queue_position): Method to calculate patch's position in queue.
11
12 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
13
14         [ews-build] Do not run clean build by default on EWS builders
15         https://bugs.webkit.org/show_bug.cgi?id=196897
16
17         Reviewed by Lucas Forschler.
18
19         * BuildSlaveSupport/ews-build/steps.py:
20         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
21         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
22         untracked directories like WebKitBuild).
23         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
24         untracked files/directories (like WebKitBuild).
25
26 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
27
28         TestRunner::notifyDone() should be safely reentrant
29         https://bugs.webkit.org/show_bug.cgi?id=196898
30
31         Reviewed by Darin Adler.
32
33         It is currently possible that TestRunner::notifyDone() will call itself, since
34         notifyDone() will force a repaint, which can start executing JavaScript, which
35         may call notifyDone() again. This can lead to test failures and flakiness.
36         Fix this by setting the m_waitToDump flag before calling the dump() method.
37
38         * DumpRenderTree/mac/TestRunnerMac.mm:
39         (TestRunner::notifyDone):
40         (TestRunner::forceImmediateCompletion):
41         * DumpRenderTree/win/TestRunnerWin.cpp:
42         (TestRunner::notifyDone):
43         (TestRunner::forceImmediateCompletion):
44
45 2019-04-15  Philippe Normand  <pnormand@igalia.com>
46
47         [GTK][WPE] Add enable-media websetting
48         https://bugs.webkit.org/show_bug.cgi?id=196863
49
50         Reviewed by Michael Catanzaro.
51
52         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
53         (testWebKitSettings): Add test for the enable-media web-setting.
54
55 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
56
57         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
58         https://bugs.webkit.org/show_bug.cgi?id=196905
59         <rdar://problem/49886096>
60
61         Reviewed by Tim Horton.
62
63         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
64         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
65         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
66         delay timer, we end up with this sequence of events in the problematic (failure) case:
67
68         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
69             ...IPC from UI to web process...
70         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
71             ...IPC from web to UI process...
72         (c) [UI]    Invoke completion handler for script #1
73         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
74             ...IPC from UI to web process...
75         (e) [Web]   Evaluate script #2 in the web process
76         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
77
78         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
79         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
80         #2 is run in step (e).
81
82         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
83         the UI process by waiting on a script message posted by the web process, after attachment updates are
84         dispatched.
85
86         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
87         (TestWebKitAPI::TEST):
88
89 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
90
91         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
92         https://bugs.webkit.org/show_bug.cgi?id=196909
93
94         Reviewed by Wenson Hsieh.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
97         (TestWebKitAPI::TEST):
98
99 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
100
101         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
102         https://bugs.webkit.org/show_bug.cgi?id=196880
103
104         Reviewed by Yusuke Suzuki.
105
106         Add a new function for bytecode cache tests that does not forceDiskCache
107         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
108         test added in this patch, since the code is invalid and therefore won't be
109         cached. It should also be useful for tests that evaluate dynamically
110         generated code.
111
112         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
113         * Scripts/run-jsc-stress-tests:
114
115 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
116
117         Update AudioSession route sharing policy
118         https://bugs.webkit.org/show_bug.cgi?id=196776
119         <rdar://problem/46501611>
120
121         Reviewed by Jer Noble.
122
123         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
124         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
125         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
126         (TestWebKitAPI::TEST):
127
128 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
129
130         [iOS] Software keyboard is shown too frequently on some websites
131         https://bugs.webkit.org/show_bug.cgi?id=195856
132         <rdar://problem/49191395>
133
134         Reviewed by Darin Adler.
135
136         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
137
138         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
139         (WTR::UIScriptController::setHardwareKeyboardAttached):
140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
142         (WTR::UIScriptController::setHardwareKeyboardAttached):
143         * TestRunnerShared/UIScriptContext/UIScriptController.h:
144         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
145
146         Additionally link against GraphicsServices in WebKitTestRunner.
147
148         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
149         (WTR::TestController::platformResetStateToConsistentValues):
150         (WTR::UIScriptController::setHardwareKeyboardAttached):
151
152 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
153
154         [GTK][WPE] Fix pacman install-dependencies packages
155         https://bugs.webkit.org/show_bug.cgi?id=196817
156
157         Reviewed by Žan Doberšek.
158         
159         python3-setuptools is called python-setuptools
160         ruby-highline is only available on AUR
161         libv4l-devel is incorporated in v4l-utils
162
163         * gtk/install-dependencies:
164         * wpe/install-dependencies:
165
166 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
167
168         [GTK] REGRESSION(r243860): Many tests failing
169         https://bugs.webkit.org/show_bug.cgi?id=196791
170
171         Reviewed by Joanmarie Diggs.
172
173         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
174         multiple documents and check that accessibility hierarchy is updated after a navigation.
175
176         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
177         (loadChangedCallback):
178         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
179         (AccessibilityTest::AccessibilityTest):
180         (AccessibilityTest::~AccessibilityTest):
181         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
182         (AccessibilityTest::findTestServerApplication):
183         (AccessibilityTest::findDocumentWeb):
184         (AccessibilityTest::findRootObject):
185         (AccessibilityTest::waitUntilChildrenRemoved):
186         (AccessibilityTest::ensureProxy):
187         (testAtspiBasicHierarchy):
188         (beforeAll):
189         (afterAll):
190
191 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews-build] Handle bug titles with unicode characters
194         https://bugs.webkit.org/show_bug.cgi?id=196802
195
196         Reviewed by Dewei Zhu.
197
198         * BuildSlaveSupport/ews-build/steps.py:
199         (ValidatePatch._is_bug_closed):
200
201 2019-04-11  Michael Saboff  <msaboff@apple.com>
202
203         Improve the Inline Cache Stats code
204         https://bugs.webkit.org/show_bug.cgi?id=196836
205
206         Reviewed by Saam Barati.
207
208         Added a new script to consolidate and arrange the output of --useICStats option.
209
210         This script merges the output from every group into one large table and sorts it from most common to
211         least common.  It also counts the slow path GetById and PutById variants and then calculates the
212         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
213         Put together, this is useful to see what property accesses are not getting cached.
214
215         * Scripts/ic-stats.py: Added.
216         (ICStats):
217         (ICStats.__init__):
218         (ICStats.parse):
219         (ICStats.dumpStats):
220         (usage):
221
222 2019-04-10  Alex Christensen  <achristensen@webkit.org>
223
224         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
225         https://bugs.webkit.org/show_bug.cgi?id=196809
226         <rdar://49800762>
227
228         Reviewed by Brady Eidson.
229
230         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
231         (TEST):
232
233 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
234
235         requestAnimationFrame should execute before the next frame
236         https://bugs.webkit.org/show_bug.cgi?id=177484
237
238         Reviewed by Simon Fraser.
239
240         Add trace points for the page RenderingUpdate.
241
242         * Tracing/SystemTracePoints.plist:
243
244 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
245
246         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
247         https://bugs.webkit.org/show_bug.cgi?id=196760
248
249         Reviewed by Don Olmstead.
250
251         vswhere.exe has been bundled since Visual Studio 2017 version
252         15.2. We shouldn't download vswhere.exe.
253
254         * Scripts/build-jsc: Do not call update-vswhere.py.
255         * Scripts/build-webkit: Ditto.
256         * Scripts/update-vswhere.py: Removed.
257         * Scripts/webkitdirs.pm:
258         (requireModulesForVSWhere): Deleted.
259         (pickCurrentVisualStudioInstallation): Deleted.
260         (visualStudioInstallDirVSWhere): Return the latest installed VS
261         installation path by using the bundled vswhere.exe.
262         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
263         (visualStudioInstallDirFallback): Removed.
264
265 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
266
267         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
268         https://bugs.webkit.org/show_bug.cgi?id=196780
269
270         Reviewed by Alexey Proskuryakov.
271
272         * BuildSlaveSupport/ews-build/steps.py:
273         * BuildSlaveSupport/ews-build/steps_unittest.py:
274
275 2019-04-10  Alex Christensen  <achristensen@webkit.org>
276
277         Add SPI WKNavigationResponse._downloadAttribute
278         https://bugs.webkit.org/show_bug.cgi?id=196755
279         <rdar://49587365>
280
281         Reviewed by Brady Eidson.
282
283         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
284         (-[NavigationResponseTestDelegate navigationResponse]):
285         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
286         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
287         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
288         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
289         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
290         (readRequest):
291         (writeResponse):
292         (TEST):
293
294 2019-04-10  Tim Horton  <timothy_horton@apple.com>
295
296         Add modern API for overriding the page's specified viewport configuration
297         https://bugs.webkit.org/show_bug.cgi?id=167734
298         <rdar://problem/30331795>
299
300         Reviewed by Simon Fraser.
301
302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
303         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
304
305 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
306
307         Add support for incremental bytecode cache updates
308         https://bugs.webkit.org/show_bug.cgi?id=195000
309
310         Reviewed by Filip Pizlo.
311
312         Exit when the initial run to generate bytecode fails.
313
314         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
315
316 2019-04-10  Alex Christensen  <achristensen@webkit.org>
317
318         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
319         https://bugs.webkit.org/show_bug.cgi?id=196744
320         <rdar://49415309>
321
322         Reviewed by Chris Dumez.
323
324         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
325         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
326
327 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
328
329         Add a way to opt into modern compatibility mode in layout tests
330         https://bugs.webkit.org/show_bug.cgi?id=196770
331         <rdar://problem/49777550>
332
333         Reviewed by Antoine Quint.
334
335         Add a new test option to enable modern compatibility mode in layout tests.
336
337         * WebKitTestRunner/TestController.cpp:
338         (WTR::updateTestOptionsFromTestHeader):
339         * WebKitTestRunner/TestController.h:
340         * WebKitTestRunner/TestOptions.h:
341         (WTR::TestOptions::hasSameInitializationOptions const):
342         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
343         (WTR::TestController::platformCreateWebView):
344         (WTR::TestController::enableModernCompatibilityMode):
345
346 2019-04-10  Andy Estes  <aestes@apple.com>
347
348         Try to fix the 32-bit watchOS build.
349
350         * TestWebKitAPI/cocoa/TestWKWebView.mm:
351         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
352
353 2019-04-10  Antoine Quint  <graouts@apple.com>
354
355         Enable Pointer Events on watchOS
356         https://bugs.webkit.org/show_bug.cgi?id=196771
357         <rdar://problem/49040909>
358
359         Reviewed by Dean Jackson.
360
361         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
362
363 2019-04-10  Philippe Normand  <pnormand@igalia.com>
364
365         Unreviewed. Fix WPE accessibility tests after r244059.
366
367         We are failing to load the injected bundle due to undefined symbol
368         AccessibilityUIElement::replaceTextInRange().
369
370         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
371         (WTR::AccessibilityUIElement::replaceTextInRange):
372
373 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
374
375         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
376         https://bugs.webkit.org/show_bug.cgi?id=196727
377
378         Reviewed by Fujii Hironori.
379
380         * MiniBrowser/win/WebKitBrowserWindow.cpp:
381         (WebKitBrowserWindow::create):
382
383 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
384
385         [ews-build] Add unit tests for PrintConfiguration
386         https://bugs.webkit.org/show_bug.cgi?id=196752
387
388         Reviewed by Dewei Zhu.
389
390         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
391
392 2019-04-09  Keith Rollin  <krollin@apple.com>
393
394         Unreviewed build maintenance -- update .xcfilelists.
395
396         * DumpRenderTree/DerivedSources-input.xcfilelist:
397         * DumpRenderTree/DerivedSources-output.xcfilelist:
398
399 2019-04-09  Zalan Bujtas  <zalan@apple.com>
400
401         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
402         https://bugs.webkit.org/show_bug.cgi?id=196743
403         <rdar://problem/43897551>
404
405         Reviewed by Tim Horton.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
408         (TEST):
409
410 2019-04-09  Youenn Fablet  <youenn@apple.com>
411
412         Close service worker database on network process suspension
413         https://bugs.webkit.org/show_bug.cgi?id=196623
414         <rdar://problem/48930869>
415
416         Reviewed by Alex Christensen.
417
418         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
419
420 2019-04-09  Daniel Bates  <dabates@apple.com>
421
422         [iPad] Should open popover when the spacebar is pressed
423         https://bugs.webkit.org/show_bug.cgi?id=196360
424         <rdar://problem/49389129>
425
426         Reviewed by Brent Fulgham.
427
428         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
429
430         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
431         (WTR::UIScriptController::isShowingPopover const): Added.
432         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
433         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
434         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
435         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
436         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
437         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
438         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
439         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
440         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
441         (WTR::UIScriptController::isShowingPopover const): Added.
442         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
443         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
444         * TestRunnerShared/UIScriptContext/UIScriptController.h:
445         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
446         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
447         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
448         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
449         (-[TestRunnerWKWebView _willPresentPopover]): Added.
450         (-[TestRunnerWKWebView _didDismissPopover]): Added.
451         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
452         (WTR::UIScriptController::isShowingPopover const): Added.
453         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
454         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
455
456 2019-04-09  Alex Christensen  <achristensen@webkit.org>
457
458         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
459         https://bugs.webkit.org/show_bug.cgi?id=196665
460         <rdar://45115669>
461
462         Reviewed by Geoff Garen.
463
464         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
465         (goBack):
466         (+[SimpleLookupContext sharedLookupContext]):
467         (-[SimpleLookupContext lookUpURL:completionHandler:]):
468         (TEST):
469         (+[Simple3LookupContext sharedLookupContext]): Deleted.
470         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
471
472 2019-04-09  John Wilander  <wilander@apple.com>
473
474         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
475         https://bugs.webkit.org/show_bug.cgi?id=196558
476         <rdar://problem/47650245>
477
478         Reviewed by Youenn Fablet.
479
480         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
481         (TestWebKitAPI::TEST):
482             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
483
484 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
485
486         [CMake] Apple builds should use ICU_INCLUDE_DIRS
487         https://bugs.webkit.org/show_bug.cgi?id=196720
488
489         Reviewed by Konstantin Tokarev.
490
491         * TestWebKitAPI/PlatformMac.cmake:
492
493 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
494
495         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
496         https://bugs.webkit.org/show_bug.cgi?id=196694
497         <rdar://problem/48388734>
498
499         Rubber-stamped by Aakash Jain.
500
501         * Scripts/webkitpy/port/image_diff.py:
502         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
503         * Scripts/webkitpy/port/server_process.py:
504         (ServerProcess.has_available_stdout): Check if stdout has data in it.
505         (ServerProcess._wait_for_data_and_update_buffers_using_select):
506         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
507         * Scripts/webkitpy/port/server_process_mock.py:
508         (MockServerProcess.has_available_stdout):
509         * Scripts/webkitpy/port/server_process_unittest.py:
510         (TestServerProcess.serial_test_basic):
511
512 2019-04-09  Jer Noble  <jer.noble@apple.com>
513
514         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
515         https://bugs.webkit.org/show_bug.cgi?id=196097
516
517         Reviewed by Eric Carlson.
518
519         Drive-by bug fix: allow tests to play audio without a user gesture by default.
520
521         * DumpRenderTree/mac/DumpRenderTree.mm:
522         (resetWebPreferencesToConsistentValues):
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::TestController::resetPreferencesToConsistentValues):
525
526 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
527
528         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
529         https://bugs.webkit.org/show_bug.cgi?id=196690
530
531         Reviewed by Michael Catanzaro.
532
533         * QueueStatusServer/config/queues.py:
534         * Scripts/webkitpy/common/config/ews.json:
535         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
536         (test_ews_name):
537
538 2019-04-09  Chris Dumez  <cdumez@apple.com>
539
540         Loads using loadHTMLString() cause flashing when process-swapping
541         https://bugs.webkit.org/show_bug.cgi?id=196714
542         <rdar://problem/49637354>
543
544         Reviewed by Antti Koivisto.
545
546         Add API test coverage.
547
548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
549
550 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
551
552         Unreviewed. Fix ATK accessibility tests after r244059.
553
554         We are failing to load the injected bundle due to undefined symbol
555         AccessibilityUIElement::replaceTextInRange().
556
557         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
558         (WTR::AccessibilityUIElement::replaceTextInRange):
559
560 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
561
562         AX: Support API: accessibilityReplaceRange:withText
563         https://bugs.webkit.org/show_bug.cgi?id=196636
564
565         Unreviewed build fix for Windows port.
566
567         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
568         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
569
570 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
571
572         [CMake][WinCairo] Separate copied headers into different directories
573         https://bugs.webkit.org/show_bug.cgi?id=196655
574
575         Reviewed by Michael Catanzaro.
576
577         * DumpRenderTree/CMakeLists.txt:
578         * MiniBrowser/win/CMakeLists.txt:
579         * TestWebKitAPI/CMakeLists.txt:
580         * TestWebKitAPI/PlatformWin.cmake:
581
582 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
583
584         Log stack-trace for run-webkit-tests when interrupted
585         https://bugs.webkit.org/show_bug.cgi?id=176393
586         <rdar://problem/34262310>
587
588         Reviewed by Lucas Forschler.
589
590         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
591         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
592         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
593         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
594         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
596         (main): Set handlers to log stack trace on interruption.
597
598 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
599
600         AX: Support API: accessibilityReplaceRange:withText
601         https://bugs.webkit.org/show_bug.cgi?id=196636
602
603         Unreviewed build fix for Windows port.
604
605         * DumpRenderTree/AccessibilityUIElement.cpp:
606         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
607
608 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
609
610         [ews-build] Scripts using Buildbot API have CORS error
611         https://bugs.webkit.org/show_bug.cgi?id=196709
612
613         Reviewed by Alexey Proskuryakov.
614
615         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
616
617 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
618
619         AX: Support API: accessibilityReplaceRange:withText
620         https://bugs.webkit.org/show_bug.cgi?id=196636
621
622         Reviewed by Daniel Bates.
623
624         * DumpRenderTree/AccessibilityUIElement.cpp:
625         (replaceTextInRangeCallback):
626         (AccessibilityUIElement::replaceTextInRange):
627         (AccessibilityUIElement::getJSClass):
628         * DumpRenderTree/AccessibilityUIElement.h:
629         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
630         (AccessibilityUIElement::replaceTextInRange):
631         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
632         (AccessibilityUIElement::replaceTextInRange):
633         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
634         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
635         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
636         (WTR::AccessibilityUIElement::replaceTextInRange):
637         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
638         (WTR::AccessibilityUIElement::replaceTextInRange):
639
640 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
641
642         [iOS] Do not allow starting selection drags when selection views are not visible
643         https://bugs.webkit.org/show_bug.cgi?id=196686
644         <rdar://problem/49399192>
645
646         Reviewed by Tim Horton.
647
648         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
649         also add some new API tests to cover scenarios where the web view is not first responder.
650
651         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
652         (TestWebKitAPI::TEST):
653         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
654
655         Add a switch to optionally make the web view first responder when starting the simulated drag.
656
657         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
658         (-[DragAndDropSimulator initWithWebView:]):
659         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
660
661 2019-04-08  Justin Fan  <justin_fan@apple.com>
662
663         [Web GPU] Fix Web GPU experimental feature on iOS
664         https://bugs.webkit.org/show_bug.cgi?id=196632
665
666         Reviewed by Myles C. Maxfield.
667
668         Properly make Web GPU available on iOS 11+.
669
670         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
671
672 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews-build] Do not upload archive when Compile Fails
675         https://bugs.webkit.org/show_bug.cgi?id=196674
676
677         Reviewed by Alexey Proskuryakov.
678
679         * BuildSlaveSupport/ews-build/factories.py:
680         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
681         * BuildSlaveSupport/ews-build/steps.py:
682         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
683         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
684         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
685
686 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
687
688         Enable DFG on MIPS
689         https://bugs.webkit.org/show_bug.cgi?id=196689
690
691         Reviewed by Žan Doberšek.
692
693         Since the bytecode change, we enabled the baseline JIT on mips in
694         r240432, but DFG is still missing. With this change, all tests are
695         passing on a ci20 board.
696
697         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
698
699 2019-04-08  Philippe Normand  <pnormand@igalia.com>
700
701         [Flatpak] Second run update-webkitwpe-flatpak fails
702         https://bugs.webkit.org/show_bug.cgi?id=192702
703
704         Reviewed by Carlos Garcia Campos.
705
706         * flatpak/flatpakutils.py:
707         (FlatpakObject.flatpak): Fix typo.
708         (FlatpakPackage.install): When installing, also update to the configured remote commit.
709         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
710
711 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
712
713         [GTK][WPE] outlook.live.com displays old-fashioned UI
714         https://bugs.webkit.org/show_bug.cgi?id=196642
715
716         Reviewed by Carlos Garcia Campos.
717
718         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
719         (TestWebKitAPI::TEST): New Mac platform quirk test.
720
721 2019-04-07  Commit Queue  <commit-queue@webkit.org>
722
723         Unreviewed, rolling out r243956.
724         https://bugs.webkit.org/show_bug.cgi?id=196688
725
726         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
727         by aakashjain on #webkit).
728
729         Reverted changeset:
730
731         "Clicking "Go Back" from a safe browsing warning from an
732         iframe should navigate the WKWebView back to the previous
733         page"
734         https://bugs.webkit.org/show_bug.cgi?id=196665
735         https://trac.webkit.org/changeset/243956
736
737 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
738
739         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
740         https://bugs.webkit.org/show_bug.cgi?id=196669
741
742         Reviewed by Geoffrey Garen.
743
744         Added three new unit tests for WeakHashSet.
745
746         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
747         (WTF_WeakPtr.WeakHashSetConstObjects):
748         (WTF_WeakPtr.WeakHashSetComputesEmpty):
749         (WTF_WeakPtr.WeakHashSetComputeSize):
750
751 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
752
753         Hide next and previous form control buttons when WKWebView is editable
754         https://bugs.webkit.org/show_bug.cgi?id=196672
755         <rdar://problem/35625321>
756
757         Reviewed by Tim Horton.
758
759         Add a new API test.
760
761         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
762         (-[TestWKWebView lastTrailingBarButtonGroup]):
763         (TestWebKitAPI::TEST):
764         * TestWebKitAPI/ios/UIKitSPI.h:
765
766 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
767
768         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
769         https://bugs.webkit.org/show_bug.cgi?id=196077
770         <rdar://problem/49108202>
771
772         Reviewed by Chris Dumez.
773
774         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
775         on new web view.
776
777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
778
779 2019-04-05  Saam Barati  <sbarati@apple.com>
780
781         Make compare-results understand MotionMark
782         https://bugs.webkit.org/show_bug.cgi?id=196666
783
784         Reviewed by Yusuke Suzuki.
785
786         * Scripts/compare-results:
787         (PLT5Results):
788         (detectMotionMark):
789         (detectMotionMark1_1):
790         (motionMarkResults):
791         (motionMark1_1Results):
792         (detectBenchmark):
793         (biggerIsBetter):
794         (main):
795
796 2019-04-05  Alex Christensen  <achristensen@webkit.org>
797
798         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
799         https://bugs.webkit.org/show_bug.cgi?id=196665
800         <rdar://45115669>
801
802         Reviewed by Geoff Garen.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
805         (goBack):
806         (+[SimpleLookupContext sharedLookupContext]):
807         (-[SimpleLookupContext lookUpURL:completionHandler:]):
808         (TEST):
809         (+[Simple3LookupContext sharedLookupContext]): Deleted.
810         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
811
812 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
813
814         [ews-build] Add configuration and architecture for windows builders
815         https://bugs.webkit.org/show_bug.cgi?id=196660
816
817         Reviewed by Lucas Forschler.
818
819         * BuildSlaveSupport/ews-build/config.json:
820
821 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
822
823         webkitpy: Don't run subsequent rounds if interrupted
824         https://bugs.webkit.org/show_bug.cgi?id=196646
825
826         Reviewed by Aakash Jain.
827
828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
829         (Manager.run): Bail out if interrupted.
830
831 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
832
833         Test sessionStorage in PSON private browsing mode
834         https://bugs.webkit.org/show_bug.cgi?id=196561
835
836         Reviewed by Alex Christensen.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
839
840 2019-04-05  Commit Queue  <commit-queue@webkit.org>
841
842         Unreviewed, rolling out r243833.
843         https://bugs.webkit.org/show_bug.cgi?id=196645
844
845         This change breaks build of WPE and GTK ports (Requested by
846         annulen on #webkit).
847
848         Reverted changeset:
849
850         "[CMake][WTF] Mirror XCode header directories"
851         https://bugs.webkit.org/show_bug.cgi?id=191662
852         https://trac.webkit.org/changeset/243833
853
854 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
855
856         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
857         https://bugs.webkit.org/show_bug.cgi?id=196635
858
859         Reviewed by Antti Koivisto.
860         
861         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
862         for a test to enable async frame scrolling via:
863             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
864         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
865         
866         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
867
868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
869         (WTR::InjectedBundle::beginTesting):
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::resetPreferencesToConsistentValues):
872
873 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
874
875         Use a correct LC_RPATH when building with ASan
876         https://bugs.webkit.org/show_bug.cgi?id=196576
877
878         Reviewed by David Kilzer.
879
880         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
881         so that ../Frameworks is checked. This is simpler and more reliable than updating
882         each SPC service xcconfig.
883
884 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
885
886         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
887         https://bugs.webkit.org/show_bug.cgi?id=196629
888
889         Reviewed by Lucas Forschler.
890
891         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
892
893 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
896         https://bugs.webkit.org/show_bug.cgi?id=196618
897
898         Reviewed by Lucas Forschler.
899
900         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
901         (StatusBubble): Added QUEUE_TRIGGERS.
902         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
903         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
904         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
905         its parent(builder).
906
907 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-app] Status-bubble steps are sometimes displayed in reverse order
910         https://bugs.webkit.org/show_bug.cgi?id=196625
911
912         Reviewed by Lucas Forschler.
913
914         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
915         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
916
917 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
918
919         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
920         https://bugs.webkit.org/show_bug.cgi?id=196630
921
922         Reviewed by Wenson Hsieh.
923
924         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
925
926 2019-04-04  Youenn Fablet  <youenn@apple.com>
927
928         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
929         https://bugs.webkit.org/show_bug.cgi?id=196543
930
931         Reviewed by Alex Christensen.
932
933         * WebKitTestRunner/TestController.cpp:
934         (WTR::TestController::generatePageConfiguration):
935
936 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
937
938         [ews-app] Status bubble should not display skipped buildbot steps
939         https://bugs.webkit.org/show_bug.cgi?id=196584
940
941         Reviewed by Lucas Forschler.
942
943         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
944
945 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
946
947         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
948         https://bugs.webkit.org/show_bug.cgi?id=196620
949
950         Reviewed by Lucas Forschler.
951
952         * BuildSlaveSupport/ews-app/ews/config.py:
953
954 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
955
956         [Win] DumpRenderTreeWatchDog.py is not checked into source
957         https://bugs.webkit.org/show_bug.cgi?id=196567
958         <rdar://problem/49525901>
959
960         Reviewed by Lucas Forschler.
961
962         This script is used on Win EWS bots to terminate hanging DRT processes.
963
964         * EWSTools/dumprendertreewatchdog.py: Added.
965
966 2019-04-04  Chris Dumez  <cdumez@apple.com>
967
968         Unreviewed, roll out r243858 which made tests time out.
969
970         Disable new API tests on Windows instead.
971
972         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
973         (TestWebKitAPI::TEST):
974
975 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
976
977         [ATK] Cleanup WebPageAccessibilityObjectAtk
978         https://bugs.webkit.org/show_bug.cgi?id=196537
979
980         Reviewed by Michael Catanzaro.
981
982         Also consider files under atk directories as exceptions for GObject conventions.
983
984         * Scripts/webkitpy/style/checkers/cpp.py:
985         (check_identifier_name_in_declaration):
986
987 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
988
989         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
990         https://bugs.webkit.org/show_bug.cgi?id=196588
991         <rdar://problem/49365787>
992
993         Unreviewed build fix for Windows port.
994
995         error C3861: 'kill': identifier not found
996
997         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
998         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
999
1000 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-build] Cancel build and similar operations should have authentication
1003         https://bugs.webkit.org/show_bug.cgi?id=196520
1004
1005         Reviewed by Dewei Zhu.
1006
1007         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1008         environment variables.
1009
1010 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-build] Do not trigger queues which are not in production yet
1013         https://bugs.webkit.org/show_bug.cgi?id=196581
1014
1015         Reviewed by Dewei Zhu.
1016
1017         * BuildSlaveSupport/ews-build/config.json:
1018
1019 2019-04-03  Chris Dumez  <cdumez@apple.com>
1020
1021         Unreviewed, fix typo in the name of API test added in r243848.
1022
1023         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1024         (TestWebKitAPI::TEST):
1025
1026 2019-04-03  Chris Dumez  <cdumez@apple.com>
1027
1028         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1029         https://bugs.webkit.org/show_bug.cgi?id=196588
1030         <rdar://problem/49365787>
1031
1032         Reviewed by Ryosuke Niwa.
1033
1034         Add API test coverage.
1035
1036         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1037         (TestWebKitAPI::nullJavaScriptCallback):
1038         (TestWebKitAPI::didCrashCheckFrames):
1039         (TestWebKitAPI::TEST):
1040
1041 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1042
1043         run-webkit-tests: Upload test results (new results database)
1044         https://bugs.webkit.org/show_bug.cgi?id=196577
1045         <rdar://problem/34841155>
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1050         (Manager.run): Upload results after each device shard, since the configuration will be
1051         different for each device.
1052         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1053         uploaded to a results database.
1054         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1055         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1056
1057 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1058
1059         -apple-trailing-word is needed for browser detection
1060         https://bugs.webkit.org/show_bug.cgi?id=196575
1061
1062         Unreviewed.
1063
1064         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1065
1066 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1067
1068         [CMake][WTF] Mirror XCode header directories
1069         https://bugs.webkit.org/show_bug.cgi?id=191662
1070
1071         Reviewed by Konstantin Tokarev.
1072
1073         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1074         builds.
1075
1076         * CMakeLists.txt:
1077         * DumpRenderTree/CMakeLists.txt:
1078         * DumpRenderTree/PlatformWin.cmake:
1079         * MiniBrowser/win/CMakeLists.txt:
1080         * TestWebKitAPI/CMakeLists.txt:
1081         * TestWebKitAPI/PlatformWin.cmake:
1082         * WebKitTestRunner/PlatformGTK.cmake:
1083         * WebKitTestRunner/PlatformWin.cmake:
1084
1085 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1086
1087         [ews-app] Status bubble should not display certain infrastructure status messages
1088         https://bugs.webkit.org/show_bug.cgi?id=196550
1089
1090         Reviewed by Lucas Forschler.
1091
1092         Do not display the steps which are un-needed for end-user. This information is still avaiable
1093         if the user click on the bubble and look at the Buildbot build.
1094         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1095         (StatusBubble._steps_messages):
1096         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1097
1098 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] Use https for sending data to ews-app
1101         https://bugs.webkit.org/show_bug.cgi?id=196492
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/events.py:
1106
1107 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1108
1109         Remove support for -apple-trailing-word
1110         https://bugs.webkit.org/show_bug.cgi?id=196525
1111
1112         Reviewed by Zalan Bujtas.
1113
1114         This CSS property is nonstandard and not used.
1115
1116         * Scripts/webkitperl/FeatureList.pm:
1117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1118
1119 2019-04-03  Youenn Fablet  <youenn@apple.com>
1120
1121         Add a test for DOMCache on multiple browsing in case of private browsing
1122         https://bugs.webkit.org/show_bug.cgi?id=196524
1123
1124         Reviewed by Alex Christensen.
1125
1126         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1127         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1128
1129 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1130
1131         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1132         https://bugs.webkit.org/show_bug.cgi?id=196540
1133
1134         Reviewed by Aakash Jain.
1135
1136         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1137
1138 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1139
1140         Add plumbing for a compatibility mode preference in WebKit
1141         https://bugs.webkit.org/show_bug.cgi?id=196005
1142
1143         Reviewed by Tim Horton.
1144
1145         Add new API tests.
1146
1147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1148         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1149
1150 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1151
1152         [WPE][GTK] Update libsrtp dependency package for Debian
1153         https://bugs.webkit.org/show_bug.cgi?id=196528
1154
1155         Reviewed by Frédéric Wang.
1156
1157         * gtk/install-dependencies:
1158         * wpe/install-dependencies:
1159
1160 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1161
1162         [WK2] Add support for Window's beforeprint / afterprint events
1163         https://bugs.webkit.org/show_bug.cgi?id=196478
1164         <rdar://problem/49535124>
1165
1166         Unreviewed build fix for MSVC.
1167
1168         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1169
1170         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1171
1172         * WebKitTestRunner/TestController.cpp:
1173         (WTR::printFrame): Use int and float literals.
1174
1175 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1176
1177         [ews-build] Reassign bots to queues
1178
1179         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1180
1181 2019-04-02  Chris Dumez  <cdumez@apple.com>
1182
1183         [WK2] Add support for Window's beforeprint / afterprint events
1184         https://bugs.webkit.org/show_bug.cgi?id=196478
1185
1186         Reviewed by Alex Christensen.
1187
1188         Add minimal implementation for printFrame in WebKitTestRunner.
1189
1190         * WebKitTestRunner/TestController.cpp:
1191         (WTR::printFrame):
1192         (WTR::TestController::createOtherPage):
1193         (WTR::TestController::createWebViewWithOptions):
1194
1195 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1196
1197         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1198         https://bugs.webkit.org/show_bug.cgi?id=196491
1199
1200         Reviewed by Lucas Forschler.
1201
1202         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1203
1204 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1205
1206         [ews-build] Configure buildbot try credentials in environment variables
1207         https://bugs.webkit.org/show_bug.cgi?id=196501
1208
1209         Reviewed by Lucas Forschler.
1210
1211         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1212         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1213         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1214
1215 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1216
1217         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1218         https://bugs.webkit.org/show_bug.cgi?id=196496
1219         <rdar://problem/49521634>
1220
1221         Reviewed by Chris Dumez.
1222
1223         Add new API tests (see WebKit ChangeLog for more detail).
1224
1225         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1226         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1227         (TEST):
1228
1229 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1230
1231         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1232         <https://webkit.org/b/196499>
1233
1234         Reviewed by Alexey Proskuryakov.
1235
1236         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1237         ENABLE_ADDRESS_SANITIZER.
1238
1239 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1240
1241         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1242         https://bugs.webkit.org/show_bug.cgi?id=182757
1243
1244         Reviewed by Don Olmstead.
1245
1246         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1247         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1248
1249 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1250
1251         run-api-tests: Upload test results
1252         https://bugs.webkit.org/show_bug.cgi?id=196323
1253         <rdar://problem/49356714>
1254
1255         Reviewed by Lucas Forschler.
1256
1257         * Scripts/webkitpy/api_tests/manager.py:
1258         (Manager):
1259         (Manager.run): Upload results to a results database.
1260         * Scripts/webkitpy/api_tests/run_api_tests.py:
1261         (parse_args): Add upload arguments.
1262         * Scripts/webkitpy/port/base.py:
1263         (Port):
1264         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1265         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1266         with commits from any other associated repositories.
1267         * Scripts/webkitpy/port/device.py:
1268         (Device):
1269         (Device.build_version): Access build_versoin of underlying platform device.
1270         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1271         (IOSSimulatorTest):
1272         (IOSSimulatorTest.test_configuration_for_upload):
1273         * Scripts/webkitpy/port/device_port.py:
1274         (DevicePort):
1275         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1276         the same as the machine uploading results.
1277         * Scripts/webkitpy/port/mac.py:
1278         (MacPort):
1279         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1280         * Scripts/webkitpy/port/mac_unittest.py:
1281         (MacTest):
1282         (MacTest.test_configuration_for_upload):
1283         * Scripts/webkitpy/xcode/simulated_device.py:
1284         (SimulatedDeviceManager._create_device_with_runtime):
1285         (SimulatedDevice.__init__): Create simulated device with a build_version.
1286         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1287         (test_existing_simulator):
1288
1289 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1290
1291         Remove extra newline characters (Follow-up fix to r243707)
1292
1293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1294
1295 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews-app] Use API_KEY to accept results data
1298         https://bugs.webkit.org/show_bug.cgi?id=196461
1299
1300         Reviewed by Dewei Zhu.
1301
1302         * BuildSlaveSupport/ews-app/ews/views/results.py:
1303         (Results.post): Validate EWS_API_KEY before accepting any data.
1304         * BuildSlaveSupport/ews-build/events.py:
1305         (Events.sendData): Send EWS_API_KEY if available along with event data.
1306
1307 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1308
1309         Unable to copy and paste a PDF from Notes into Mail compose body
1310         https://bugs.webkit.org/show_bug.cgi?id=196442
1311         <rdar://problem/48573098>
1312
1313         Reviewed by Tim Horton.
1314
1315         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1316         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1317         to be specified on the item providers.
1318
1319         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1320         (TestWebKitAPI::mapItemForTesting):
1321         (TestWebKitAPI::contactItemForTesting):
1322
1323 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1324
1325         Make UIWKDocumentContext rects per-character instead of per-word
1326         https://bugs.webkit.org/show_bug.cgi?id=196459
1327
1328         Reviewed by Wenson Hsieh.
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1331         (TEST):
1332         Adjust test results due to switching to per-character rects.
1333
1334 2019-04-01  Chris Dumez  <cdumez@apple.com>
1335
1336         UIProcess crash when a prewarmed process is terminated
1337         https://bugs.webkit.org/show_bug.cgi?id=196451
1338         <rdar://problem/49245471>
1339
1340         Reviewed by Geoffrey Garen.
1341
1342         Add API test coverage.
1343
1344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1345         (TEST):
1346
1347 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1350         https://bugs.webkit.org/show_bug.cgi?id=196449
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1355         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1356         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1357         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1358
1359 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1362         https://bugs.webkit.org/show_bug.cgi?id=196444
1363
1364         Reviewed by Lucas Forschler.
1365
1366         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1367
1368 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1369
1370         Add SPI to canonicalize NSURLs with WTF::URL
1371         https://bugs.webkit.org/show_bug.cgi?id=196415
1372         <rdar://problem/44980271>
1373
1374         Reviewed by Darin Adler.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1378         (TestWebKitAPI::TEST):
1379
1380 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1381
1382         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1383         https://bugs.webkit.org/show_bug.cgi?id=196441
1384
1385         Reviewed by Carlos Garcia Campos.
1386
1387         Don't cache the wpe_view_backend object that might not exist yet at the
1388         time of EventSenderProxy constructor invocation, but instead retrieve
1389         that object whenever it's required for event dispatching. This should
1390         avoid crashes in this constructor now that it's invoked before any
1391         PlatformWindow has been set up (as changed in r243496).
1392
1393         * WebKitTestRunner/EventSenderProxy.h:
1394         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1395         (WTR::viewBackend):
1396         (WTR::EventSenderProxy::EventSenderProxy):
1397         (WTR::EventSenderProxy::mouseDown):
1398         (WTR::EventSenderProxy::mouseUp):
1399         (WTR::EventSenderProxy::mouseMoveTo):
1400         (WTR::EventSenderProxy::mouseScrollBy):
1401         (WTR::EventSenderProxy::keyDown):
1402         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1403
1404 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1405
1406         [Win][WebKit] MiniBrowser should support high DPI display
1407         https://bugs.webkit.org/show_bug.cgi?id=196391
1408
1409         Reviewed by Alex Christensen.
1410
1411         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1412         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1413         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1414         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1415
1416 2019-03-31  Sam Weinig  <weinig@apple.com>
1417
1418         Remove more i386 specific configurations
1419         https://bugs.webkit.org/show_bug.cgi?id=196430
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1424         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1425
1426 2019-03-31  Andy Estes  <aestes@apple.com>
1427
1428         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1429         https://bugs.webkit.org/show_bug.cgi?id=196433
1430         <rdar://problem/49293305>
1431
1432         Reviewed by Tim Horton.
1433
1434         Enhanced API test coverage to include all navigation response policy decisions in both
1435         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1439         (TestWebKitAPI::TEST):
1440         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1441         (readFile):
1442         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1443         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1444         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1445         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1446         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1447         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1448         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1449         (-[QuickLookDelegate _downloadDidStart:]):
1450         (-[QuickLookDelegate _download:didReceiveResponse:]):
1451         (-[QuickLookDelegate _download:didReceiveData:]):
1452         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1453         (-[QuickLookDelegate _downloadDidFinish:]):
1454         (-[QuickLookDelegate _download:didFailWithError:]):
1455         (-[QuickLookDelegate _downloadDidCancel:]):
1456         (-[QuickLookDelegate verifyDownload]):
1457         (runTest):
1458         (runTestDecideBeforeLoading):
1459         (runTestDecideAfterLoading):
1460         (TEST):
1461         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1462         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1463         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1464         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1465         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1466         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1467         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1468         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1469         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1470         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1471         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1472         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1473         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1474         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1475
1476 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1477
1478         [CMake] add testdfg as target with build-jsc
1479         https://bugs.webkit.org/show_bug.cgi?id=196393
1480
1481         Reviewed by Saam Barati.
1482
1483         Added testdfg as one of the targets to build when
1484         using CMake.
1485
1486         * Scripts/build-jsc:
1487
1488 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1489
1490         Delete WebMetal implementation in favor of WebGPU
1491         https://bugs.webkit.org/show_bug.cgi?id=195418
1492
1493         Reviewed by Dean Jackson.
1494
1495         * DumpRenderTree/mac/DumpRenderTree.mm:
1496         (enableExperimentalFeatures):
1497         (resetWebPreferencesToConsistentValues):
1498         * Scripts/webkitperl/FeatureList.pm:
1499         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1502         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1503         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1504         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1505         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1506         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1507         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1508         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1509         (WTR::InjectedBundle::beginTesting):
1510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1511         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1513
1514 2019-03-29  Chris Dumez  <cdumez@apple.com>
1515
1516         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1517         https://bugs.webkit.org/show_bug.cgi?id=196405
1518         <rdar://problem/49428130>
1519
1520         Reviewed by Wenson Hsieh.
1521
1522         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1523         the popover presentation methods to be no-ops. Use this in the new test added in
1524         r243523 so that we do not swizzle those methods for all tests. This is needed because
1525         those WatchOS tests rely on the popover getting presented and interactive.
1526
1527         * WebKitTestRunner/TestController.cpp:
1528         (WTR::updateTestOptionsFromTestHeader):
1529         * WebKitTestRunner/TestController.h:
1530         * WebKitTestRunner/TestOptions.h:
1531         (WTR::TestOptions::hasSameInitializationOptions const):
1532         * WebKitTestRunner/ios/TestControllerIOS.mm:
1533         (WTR::TestController::platformInitialize):
1534         (WTR::TestController::platformResetStateToConsistentValues):
1535
1536 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1537
1538         [Curl] Add Server Trust Evaluation Support.
1539         https://bugs.webkit.org/show_bug.cgi?id=191646
1540
1541         Reviewed by Fujii Hironori.
1542
1543         Implemented MiniBrowser UI for asking if user trusts the server.
1544
1545         * MiniBrowser/win/Common.cpp:
1546         (askServerTrustEvaluation):
1547         (replaceString):
1548         * MiniBrowser/win/Common.h:
1549         * MiniBrowser/win/MiniBrowserLib.rc:
1550         * MiniBrowser/win/MiniBrowserLibResource.h:
1551         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1552         (createPEMString):
1553         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1554         (WebKitBrowserWindow::canTrustServerCertificate):
1555         * MiniBrowser/win/WebKitBrowserWindow.h:
1556
1557 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1558
1559         Implement ResizeObserver.
1560         https://bugs.webkit.org/show_bug.cgi?id=157743
1561
1562         Reviewed by Simon Fraser.
1563
1564         Support resizeObserverEnabled webPreferences.
1565
1566         * DumpRenderTree/TestOptions.cpp:
1567         (TestOptions::TestOptions):
1568         * DumpRenderTree/TestOptions.h:
1569         * DumpRenderTree/mac/DumpRenderTree.mm:
1570         (setWebPreferencesForTestOptions):
1571         * DumpRenderTree/win/DumpRenderTree.cpp:
1572         (enableExperimentalFeatures):
1573         * Scripts/webkitperl/FeatureList.pm:
1574         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1575
1576 2019-03-28  John Wilander  <wilander@apple.com>
1577
1578         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1579         https://bugs.webkit.org/show_bug.cgi?id=196281
1580         <rdar://problem/48938748>
1581
1582         Reviewed by Alex Christensen.
1583
1584         This patch adds the function isStatisticsHasLocalStorage() to the
1585         TestRunner. With it, the page can query the WebsiteDataStore in the
1586         UI process to make sure that it sees LocalStorage.
1587
1588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1590         (WTR::TestRunner::isStatisticsHasLocalStorage):
1591         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1592         * WebKitTestRunner/TestController.cpp:
1593         (WTR::TestController::isStatisticsHasLocalStorage):
1594         * WebKitTestRunner/TestController.h:
1595         * WebKitTestRunner/TestInvocation.cpp:
1596         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1597
1598 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1599
1600         API::Data::createWithoutCopying should do a null check before calling CFRelease
1601         https://bugs.webkit.org/show_bug.cgi?id=196276
1602         <rdar://problem/48059859>
1603
1604         Reviewed by Alex Christensen.
1605
1606         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1607
1608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1609         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1610         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1611         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1612         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1613         (TestWebKitAPI::TEST):
1614
1615 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1616
1617         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1618         https://bugs.webkit.org/show_bug.cgi?id=186276
1619
1620         Reviewed by Carlos Garcia Campos.
1621
1622         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1623         (webViewLoadChanged):
1624         (testWebResourceGetDataError):
1625         (testWebResourceGetDataEmpty):
1626         (beforeAll):
1627         (webViewloadChanged): Deleted.
1628
1629 2019-03-27  Andy Estes  <aestes@apple.com>
1630
1631         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1632         https://bugs.webkit.org/show_bug.cgi?id=196317
1633
1634         Reviewed by Dan Bernstein.
1635
1636         package-root copies built products into a staging directory using ditto(1), which does not
1637         follow symbolic links as it traverses a directory. Now that the files in
1638         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1639         itself, these become broken links when ditto'd into the staging directory.
1640
1641         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1642
1643         * Scripts/package-root:
1644
1645 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1646
1647         [ews-app] Update display text of Submit for ews analysis
1648         https://bugs.webkit.org/show_bug.cgi?id=196309
1649
1650         Reviewed by Dewei Zhu.
1651
1652         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1653
1654 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1655
1656         run-webkit-tests should check for leaks in WebKit processes
1657         <https://webkit.org/b/193772>
1658         <rdar://problem/46526680>
1659
1660         Reviewed by Ryosuke Niwa.
1661
1662         This works by doing the following:
1663         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1664           The list of child processes are returned one per line:
1665           process.name: pid
1666         - Run the "#LIST CHILD PROCESSES" command just before the
1667           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1668           processes on the ServerProcess object.
1669         - When the `--leaks` switch is handled, run check_for_leaks() on
1670           each child process after the main test harness.
1671
1672         * DumpRenderTree/mac/DumpRenderTree.mm:
1673         (handleControlCommand):
1674         - Use strncmp() instead of strcmp().
1675         - Add support for handling "#LIST CHILD PROCESSES" command.
1676
1677         * Scripts/webkitpy/port/base.py:
1678         (Port.check_for_leaks):
1679         * Scripts/webkitpy/port/darwin.py:
1680         (DarwinPort.check_for_leaks):
1681         - Rename redundant 'process_pid' argument to 'process_id'.
1682
1683         * Scripts/webkitpy/port/driver.py:
1684         (Driver.do_post_tests_work):
1685         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1686           longer the only command this sends to WebKitTestRunner.
1687         - If the `--leaks` switch is present, send the
1688           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1689           result using Port.set_webkit_processes().
1690         (Driver._parse_child_processes_output):
1691         - Add helper method to parse list of child process names and
1692           process IDs returned from WebKitTestRunner.
1693
1694         * Scripts/webkitpy/port/ios_device.py:
1695         (IOSDevicePort.check_for_leaks):
1696         - Rename redundant 'process_pid' argument to 'process_id'.
1697
1698         * Scripts/webkitpy/port/leakdetector.py:
1699         (LeakDetector._parse_leaks_output):
1700         - Return early if there is no leaks_output.
1701         (LeakDetector.check_for_leaks):
1702         - Rename redundant 'process_pid' argument to 'process_id'.
1703
1704         * Scripts/webkitpy/port/server_process.py:
1705         (ServerProcess.__init__):
1706         (ServerProcess.child_processes):
1707         (ServerProcess.set_child_processes):
1708         - Add instance variable to Port to store list of child process
1709           names and process IDs returned from WebKitTestRunner.
1710         (ServerProcess._start):
1711         - Clear self._child_processes.
1712         (ServerProcess.stop):
1713         - If self._child_processes is set, call
1714           self._port.check_for_leaks() for each child process.
1715
1716         * Scripts/webkitpy/port/server_process_unittest.py:
1717         (TrivialMockPort.check_for_leaks):
1718         - Rename redundant 'process_pid' argument to 'process_id'.
1719
1720         * Scripts/webkitpy/port/simulator_process.py:
1721         (SimulatorProcess.stop):
1722         - If self._child_processes is set, call
1723           self._port.check_for_leaks() for each child process.
1724
1725         * Scripts/webkitpy/port/watch_device.py:
1726         (WatchDevicePort.check_for_leaks):
1727         - Rename redundant 'process_pid' argument to 'process_id'.
1728
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::dumpResponse):
1731         - Extract method from findAndDumpWorldLeaks() so that it may be
1732           reused by findAndDumpWebKitProcessIdentifiers().
1733         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1734         - Add method to output process name and process ID of both the
1735           WebContent and Networking processes.
1736         (WTR::TestController::findAndDumpWorldLeaks):
1737         - Fix missing newline in output when there were no abandoned
1738           documents.
1739         - Call dumpResponse() for extracted code.
1740         (WTR::TestController::handleControlCommand):
1741         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1742         - Use strncmp() instead of strcmp().
1743         - Call findAndDumpWebKitProcessIdentifiers() when
1744           "#LIST CHILD PROCESSES" command is sent.
1745         * WebKitTestRunner/TestController.h:
1746         (WTR::TestController::dumpResponse):
1747         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1748         - Declare methods.
1749
1750 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1751
1752         Unreviewed. Add GLib API test cases after r243434.
1753
1754         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1755         (testWebViewActiveURI):
1756         (serverCallback):
1757         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1758         (sendRequestCallback):
1759
1760 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         Geolocation request not complete when watch request was started in a different web process
1763         https://bugs.webkit.org/show_bug.cgi?id=195996
1764
1765         Reviewed by Alex Christensen.
1766
1767         Add a test case.
1768
1769         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1770         (TestWebKitAPI::runJavaScriptAlert):
1771         (TestWebKitAPI::TEST):
1772
1773 2019-03-26  Keith Rollin  <krollin@apple.com>
1774
1775         Update the way generate-xcfilelists returns strings from functions
1776         https://bugs.webkit.org/show_bug.cgi?id=195975
1777         <rdar://problem/49040807>
1778
1779         Reviewed by Dean Jackson.
1780
1781         There are places where generate-xcfilelists executes assignments with
1782         statements like:
1783
1784             FOO=$(some_function)
1785
1786         where "some_function" return a string by echoing it. E.g.
1787
1788             some_function()
1789             {
1790                 echo "Hello, World"
1791             }
1792
1793         This is a common idiom, but it has a problem if "some_function" needs
1794         to call "exit" in an attempt to halt the entire script right then and
1795         there. Since "some_function" is called inside of $(), it's being
1796         executed in a sub-shell. Calling exit in that sub-shell simply exits
1797         that shell; it doesn't not exit the outer shell in which the main part
1798         of the script is still running. As such, the main script keeps
1799         executing when the intent was for the script to halt.
1800
1801         The solution to this is to use a different idiom for returning
1802         strings. The one we now is to pass in the name of the variable to
1803         receive the string result:
1804
1805             some_function()
1806             {
1807                 variable_name=$1
1808                 eval $variable_name ="Hello, World"
1809             }
1810
1811         The call site now looks like
1812
1813             some_function FOO
1814
1815         Because there's no invocation of a sub-shell, some_function can now
1816         call "exit" if it wants to, and the entire script will exit at that
1817         point.
1818
1819         * Scripts/generate-xcfilelists:
1820
1821 2019-03-26  Chris Dumez  <cdumez@apple.com>
1822
1823         Add basic layout test coverage for File Picker on iOS
1824         https://bugs.webkit.org/show_bug.cgi?id=196265
1825
1826         Reviewed by Wenson Hsieh.
1827
1828         Add layout test infrastructure to test the file picker on iOS.
1829
1830         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1831         (WTR::UIScriptController::dismissFilePicker):
1832         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1833         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1834         (WTR::UIScriptController::dismissFilePicker):
1835         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1836         * WebKitTestRunner/TestController.cpp:
1837         (WTR::TestController::createWebViewWithOptions):
1838         (WTR::updateTestOptionsFromTestHeader):
1839         * WebKitTestRunner/TestOptions.h:
1840         (WTR::TestOptions::hasSameInitializationOptions const):
1841         * WebKitTestRunner/ios/TestControllerIOS.mm:
1842         (overridePresentViewController):
1843         (WTR::TestController::platformInitialize):
1844         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1845         (WTR::UIScriptController::dismissFilePicker):
1846
1847 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1848
1849         Implement async paste method on UIWKInteractionViewProtocol
1850         https://bugs.webkit.org/show_bug.cgi?id=196267
1851         <rdar://problem/49236346>
1852
1853         Reviewed by Tim Horton.
1854
1855         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1856         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1857         are now a part of all iOS 12 internal SDKs.
1858
1859         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1860
1861         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1862         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1863
1864         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1865         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1866         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1867         * TestWebKitAPI/ios/UIKitSPI.h:
1868
1869 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews-build] Use PostgreSQL for ews.webkit.org database
1872         https://bugs.webkit.org/show_bug.cgi?id=196270
1873
1874         Reviewed by Lucas Forschler.
1875
1876         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1877
1878 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1879
1880         [ews] Reset simctl states on reboot
1881         https://bugs.webkit.org/show_bug.cgi?id=196260
1882
1883         Rubber-stamped by Aakash Jain.
1884
1885         * EWSTools/start-queue-mac.sh:
1886
1887 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-build] Use PostgreSQL for ews-build database
1890         https://bugs.webkit.org/show_bug.cgi?id=196229
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/ews-build/master.cfg:
1895
1896 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1897
1898         [ews-build] Get master_hostname dynamically in master.cfg
1899         https://bugs.webkit.org/show_bug.cgi?id=196255
1900
1901         Reviewed by Lucas Forschler.
1902
1903         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1904         send events data in test mode.
1905
1906 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1907
1908         [ews-app] Set db_constraint to False for Foreign Keys
1909         https://bugs.webkit.org/show_bug.cgi?id=196252
1910
1911         Reviewed by Lucas Forschler.
1912
1913         * BuildSlaveSupport/ews-app/ews/models/build.py:
1914         * BuildSlaveSupport/ews-app/ews/models/step.py:
1915
1916 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1917
1918         [ews-build] is_test_mode_enabled should default to True
1919         https://bugs.webkit.org/show_bug.cgi?id=196248
1920
1921         Reviewed by Lucas Forschler.
1922
1923         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1924
1925 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1926
1927         [ews-app] Add webkitperl to ENABLED_QUEUES
1928         https://bugs.webkit.org/show_bug.cgi?id=196253
1929
1930         Reviewed by Lucas Forschler.
1931
1932         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1933
1934 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1935
1936         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1937         https://bugs.webkit.org/show_bug.cgi?id=196211
1938         rdar://problem/49110552
1939
1940         Reviewed by Tim Horton.
1941
1942         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1943         Make sure that EventSenderProxy always exists when running tests. We used to create
1944         it when resetting before the first test, which is a bit too late.
1945
1946         * WebKitTestRunner/TestController.h:
1947         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1948         (WTR::TestController::platformCreateWebView):
1949         (WTR::TestController::platformCreateOtherPage):
1950         (WTR::TestController::finishCreatingPlatformWebView):
1951         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1952         (WTR::PlatformWebView::PlatformWebView):
1953         Moved some code that made NSWindow use NSEvent during web view creation. We may
1954         need to move more if some other case us found, but this is enough for now.
1955
1956 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1957
1958         Unreviewed. Fix typo in GLib geolocation API after r243285.
1959
1960         gelocation -> geolocation.
1961
1962         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1963         (testGeolocationManagerWatchPosition):
1964
1965 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1966
1967         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1968         https://bugs.webkit.org/show_bug.cgi?id=196213
1969
1970         Reviewed by Geoff Garen.
1971
1972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1973         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1974         (credentialWithIdentityAndKeychainPath):
1975         (-[ChallengeDelegate webView:didFinishNavigation:]):
1976         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1977         (TestWebKitAPI::TEST):
1978
1979 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1980
1981         Expected shouldn't assume its contained types are copyable
1982         https://bugs.webkit.org/show_bug.cgi?id=195986
1983
1984         Reviewed by JF Bastien.
1985
1986         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1987         (TestWebKitAPI::NonCopyable::operator== const):
1988         (TestWebKitAPI::NonCopyable::operator!= const):
1989         (TestWebKitAPI::TEST):
1990
1991 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1992
1993         Remove some now-unnecessary dynamic class lookup
1994         https://bugs.webkit.org/show_bug.cgi?id=196237
1995
1996         Reviewed by Simon Fraser.
1997
1998         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1999         (makeRequest):
2000         (TEST):
2001
2002 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2003
2004         Unreviewed, rolling out r243450.
2005
2006         AppleWin and WinCairo port builds get broken.
2007
2008         Reverted changeset:
2009
2010         "Add test for fix of #196095"
2011         https://bugs.webkit.org/show_bug.cgi?id=196097
2012         https://trac.webkit.org/changeset/243450
2013
2014 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2015
2016         Unreviewed, rolling out r243465.
2017         https://bugs.webkit.org/show_bug.cgi?id=196226
2018
2019         the test doesn't build (Requested by thorton on #webkit).
2020
2021         Reverted changeset:
2022
2023         "Do not terminate the NetworkProcess if a third party
2024         application sends a NSCredential with a SecIdentityRef"
2025         https://bugs.webkit.org/show_bug.cgi?id=196213
2026         https://trac.webkit.org/changeset/243465
2027
2028 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2029
2030         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2031         https://bugs.webkit.org/show_bug.cgi?id=196213
2032
2033         Reviewed by Geoff Garen.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2037         (credentialWithIdentityAndKeychainPath):
2038         (-[ChallengeDelegate webView:didFinishNavigation:]):
2039         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2040         (TestWebKitAPI::TEST):
2041
2042 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2043
2044         [ews-build] Gracefully handle missing patch_id in events
2045         https://bugs.webkit.org/show_bug.cgi?id=196216
2046
2047         Reviewed by Lucas Forschler.
2048
2049         * BuildSlaveSupport/ews-build/events.py:
2050
2051 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2052
2053         [ews-build] use lz4 compression for improving buildbot performance
2054         https://bugs.webkit.org/show_bug.cgi?id=196155
2055
2056         Reviewed by Lucas Forschler.
2057
2058         * BuildSlaveSupport/ews-build/master.cfg:
2059
2060 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2061
2062         Pull some API testing helper methods out of TestWKWebView
2063         https://bugs.webkit.org/show_bug.cgi?id=196212
2064
2065         Reviewed by Tim Horton.
2066
2067         Refactor some more API testing utility methods, so that they can be used in
2068         tests that do not use TestWKWebView.
2069
2070         * TestWebKitAPI/cocoa/TestWKWebView.h:
2071         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2072         (-[WKWebView loadTestPageNamed:]):
2073         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2074         (-[WKWebView synchronouslyLoadHTMLString:]):
2075         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2076         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2077         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2078         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2079         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2080
2081 2019-03-25  Jer Noble  <jer.noble@apple.com>
2082
2083         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2084         https://bugs.webkit.org/show_bug.cgi?id=196097
2085
2086         Reviewed by Eric Carlson.
2087
2088         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2089
2090         * DumpRenderTree/mac/DumpRenderTree.mm:
2091         (resetWebPreferencesToConsistentValues):
2092         * WebKitTestRunner/TestController.cpp:
2093         (WTR::TestController::resetPreferencesToConsistentValues):
2094
2095 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2096
2097         Pull IPadUserInterfaceSwizzler out into a separate header file
2098         https://bugs.webkit.org/show_bug.cgi?id=196193
2099
2100         Reviewed by Anders Carlsson.
2101
2102         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2103         be used in other API tests.
2104
2105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2106         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2107         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2108         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2109         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2110         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2111         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2112
2113 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2114
2115         Remove NavigatorContentUtils in WebCore/Modules
2116         https://bugs.webkit.org/show_bug.cgi?id=196070
2117
2118         Reviewed by Alex Christensen.
2119
2120         NavigatorContentUtils was to support the custom scheme spec [1].
2121         However, in WebKit side, no port has supported the feature in
2122         WebKit layer after EFL port was removed. So there has been the
2123         only IDL implementation of the NavigatorContentUtils in WebCore.
2124         So we don't need to keep the implementation in WebCore anymore.
2125
2126         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2127
2128         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2129
2130 2019-03-24  Andy Estes  <aestes@apple.com>
2131
2132         [watchOS] Remove unused Proximity Networking code
2133         https://bugs.webkit.org/show_bug.cgi?id=196188
2134
2135         Reviewed by Tim Horton.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2138         (TEST):
2139
2140 2019-03-23  Keith Miller  <keith_miller@apple.com>
2141
2142         Refactor clz/ctz and fix getLSBSet.
2143         https://bugs.webkit.org/show_bug.cgi?id=196162
2144
2145         Reviewed by Saam Barati.
2146
2147         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2148
2149         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2150         (TestWebKitAPI::TEST):
2151
2152 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2153
2154         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2155         https://bugs.webkit.org/show_bug.cgi?id=196143
2156
2157         Reviewed by Michael Catanzaro.
2158
2159         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2160         directories.
2161
2162         * Scripts/webkitpy/style/checkers/cpp.py:
2163         (check_identifier_name_in_declaration):
2164         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2165         (WebKitStyleTest.test_names):
2166
2167 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2168
2169         [Flatpak] Manifest expanding fails for qt WPE extension
2170         https://bugs.webkit.org/show_bug.cgi?id=196148
2171
2172         Reviewed by Alex Christensen.
2173
2174         * flatpak/flatpakutils.py:
2175         (expand_submodules_recurse): The last recurse manifest expand
2176         iteration might lead to a single module so take it into account
2177         and don't try to recurse further.
2178
2179 2019-03-22  Chris Dumez  <cdumez@apple.com>
2180
2181         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2182         https://bugs.webkit.org/show_bug.cgi?id=195348
2183         <rdar://problem/48622090>
2184
2185         Reviewed by Alex Christensen.
2186
2187         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2188         to NO when test.options().shouldIgnoreMetaViewport is false.
2189
2190         * WebKitTestRunner/ios/TestControllerIOS.mm:
2191         (WTR::TestController::platformConfigureViewForTest):
2192
2193 2019-03-22  Chris Dumez  <cdumez@apple.com>
2194
2195         Prewarmed processes should be usable with any website data store
2196         https://bugs.webkit.org/show_bug.cgi?id=196104
2197
2198         Reviewed by Alex Christensen.
2199
2200         Add API test coverage.
2201
2202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2203         (runInitialWarmedProcessUsedTest):
2204         (TEST):
2205
2206 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2207
2208         Back out local changes to Alex's Subversion working directory
2209
2210         They were accidentally committed.
2211
2212         * Scripts/webkitpy/common/system/abstractexecutive.py:
2213         (AbstractExecutive.wait_newest):
2214         * Scripts/webkitpy/common/system/executive.py:
2215         (Executive.running_pids):
2216         * Scripts/webkitpy/common/system/executive_mock.py:
2217         (MockExecutive.running_pids):
2218         * Scripts/webkitpy/common/system/executive_unittest.py:
2219         (ExecutiveTest.serial_test_running_pids):
2220         * Scripts/webkitpy/port/darwin.py:
2221         (DarwinPort.check_for_leaks):
2222         * Scripts/webkitpy/port/leakdetector.py:
2223         (LeakDetector.check_for_leaks):
2224         - This was the hack attached to Bug 193772.
2225
2226         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2227         (+[WebKitTestRunnerEvent mouseLocation]):
2228         - This works around a crash on an internal build.
2229
2230 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2231
2232         Fix the build after r243354
2233         https://bugs.webkit.org/show_bug.cgi?id=196138
2234         <rdar://problem/49145951>
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2237         (TEST):
2238         * TestWebKitAPI/ios/UIKitSPI.h:
2239
2240 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2241
2242         Adopt UIWKDocumentContext
2243         https://bugs.webkit.org/show_bug.cgi?id=196040
2244         <rdar://problem/48642440>
2245
2246         Reviewed by Ryosuke Niwa.
2247
2248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2249         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2250         (makeRequest):
2251         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2252         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2253         (applyStyle):
2254         (TEST):
2255         Add tests for UIWKDocumentContext.
2256
2257         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2258         (TEST):
2259         (recursiveFindWKContentView): Deleted.
2260         * TestWebKitAPI/cocoa/TestWKWebView.h:
2261         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2262         (recursiveFindWKContentView):
2263         (-[TestWKWebView wkContentView]):
2264         * TestWebKitAPI/ios/UIKitSPI.h:
2265         Share the WKContentView finding code between tests.
2266
2267 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2268
2269         [iOS WK2] Turn on async overflow scrolling by default
2270         https://bugs.webkit.org/show_bug.cgi?id=196011
2271         rdar://problem/48453859
2272
2273         Reviewed by Antti Koivisto.
2274         
2275         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2276         since so many basic layout tests have different results when compositing is triggered for
2277         overflow.
2278         
2279         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2280
2281         * WebKitTestRunner/TestController.cpp:
2282         (WTR::TestController::resetPreferencesToConsistentValues):
2283
2284 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2285
2286         [ews-build] Retry API test in case of failures
2287         https://bugs.webkit.org/show_bug.cgi?id=196004
2288
2289         Reviewed by Lucas Forschler.
2290
2291         * BuildSlaveSupport/ews-build/steps.py:
2292         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2293         (CompileWebKitToT.doStepIf): Ditto.
2294         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2295         (ReRunAPITests): Re-run API tests.
2296         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2297         (RunAPITestsWithoutPatch): Run API tests without patch.
2298         (RunAPITestsWithoutPatch.doStepIf):
2299         (RunAPITestsWithoutPatch.hideStepIf):
2300         (RunAPITestsWithoutPatch.evaluateCommand):
2301         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2302         (AnalyzeAPITestsResults.start):
2303         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2304         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2305         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2306         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2307
2308 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-build] Update queues configurations
2311         https://bugs.webkit.org/show_bug.cgi?id=196074
2312
2313         Reviewed by Dewei Zhu.
2314
2315         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2316         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2317
2318 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2319
2320         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2321         https://bugs.webkit.org/show_bug.cgi?id=195680
2322         <rdar://problem/48903534>
2323
2324         Unreviewed infrastructure fix.
2325
2326         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2327         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2328
2329 2019-03-21  Andy Estes  <aestes@apple.com>
2330
2331         [iOS] Apple Pay should be available in documents with no user agent scripts
2332         https://bugs.webkit.org/show_bug.cgi?id=196061
2333         <rdar://problem/48649391>
2334
2335         Reviewed by Brady Eidson.
2336
2337         Added API tests and related infrastructure.
2338
2339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2340         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2341         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2342         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2343         (TestWebKitAPI::TEST):
2344         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2345         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2346         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2347         * TestWebKitAPI/cocoa/TestProtocol.mm:
2348         (-[TestProtocol startLoading]):
2349         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2350         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2351         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2352         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2353
2354 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2355
2356         REGRESSSION (r243297): webkitpy tests broken
2357         https://bugs.webkit.org/show_bug.cgi?id=196108
2358
2359         Reviewed by Aakash Jain.
2360
2361         r243297 updated contributors.json, which broke a few unit tests.
2362
2363         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2364         (IRCCommandTest.test_whois):
2365         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2366
2367 2019-03-21  Chris Dumez  <cdumez@apple.com>
2368
2369         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2370         https://bugs.webkit.org/show_bug.cgi?id=196041
2371         <rdar://problem/49083230>
2372
2373         Reviewed by Alex Christensen.
2374
2375         Add API test coverage.
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2378         (TEST):
2379
2380 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2381
2382         Add SPI to inform applications of WKContentRuleList actions
2383         https://bugs.webkit.org/show_bug.cgi?id=195965
2384         <rdar://problem/42664365>
2385
2386         Reviewed by Geoff Garen.
2387
2388         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2389         (TestWebKitAPI::allActionsForResourceLoad):
2390         (TestWebKitAPI::testRequest):
2391         (TestWebKitAPI::TEST_F):
2392         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2393         (Notification::description):
2394         (Notification::operator== const):
2395         (toVector):
2396         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2397         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2398         (makeContentRuleList):
2399         (TEST):
2400         (makeWarnContentRuleList): Deleted.
2401
2402 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2403
2404         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2405         https://bugs.webkit.org/show_bug.cgi?id=196088
2406
2407         Reviewed by Brian Burg.
2408
2409         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2410         Support checks when only one platform is specified. Also deprecate macosx() and
2411         force the use of macos() instead.
2412
2413         * Scripts/webkitpy/style/checkers/cpp.py:
2414         (check_min_versions_of_wk_api_available):
2415         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2416         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2417
2418 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2419
2420         Update status inactive committers' status to 'contributor'.
2421
2422         * Scripts/webkitpy/common/config/contributors.json:
2423
2424 2019-03-21  Xan Lopez  <xan@igalia.com>
2425
2426         [JSC][x86] Drop support for x87 floating point
2427         https://bugs.webkit.org/show_bug.cgi?id=194853
2428
2429         Reviewed by Don Olmstead.
2430
2431         Force SSE2 on x86/32bit builds.
2432
2433         * Scripts/webkitdirs.pm:
2434         (generateBuildSystemFromCMakeProject):
2435
2436 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2437
2438         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2439         https://bugs.webkit.org/show_bug.cgi?id=196073
2440
2441         Reviewed by Michael Catanzaro.
2442
2443         Add test cases to check functions and constructors with no arguments but receiving user data.
2444
2445         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2446         (checkUserData):
2447         (testJSCFunction):
2448         (fooCreateWithUserData):
2449         (testJSCClass):
2450
2451 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2452
2453         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2454
2455         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2456
2457         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2458
2459 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2460
2461         [GTK][WPE] Add API to provide geolocation information
2462         https://bugs.webkit.org/show_bug.cgi?id=195940
2463
2464         Reviewed by Michael Catanzaro.
2465
2466         Add a new test to check the new API.
2467
2468         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2469         (testGeolocationManagerCurrentPosition):
2470         (testGeolocationManagerWatchPosition):
2471         (beforeAll):
2472         (afterAll):
2473         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2474         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2475         (beforeAll): Ditto.
2476         * TestWebKitAPI/glib/CMakeLists.txt:
2477
2478 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2479
2480         [GLib] Returning G_TYPE_OBJECT from a method does not work
2481         https://bugs.webkit.org/show_bug.cgi?id=195574
2482
2483         Reviewed by Michael Catanzaro.
2484
2485         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2486
2487         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2488         (getGFile):
2489         (getParent):
2490         (createGString):
2491         (getGString):
2492         (getGStringCopyWillRaise):
2493         (getGStringCopy):
2494         (getGStringStr):
2495         (getGStringLen):
2496         (freeGString):
2497         (testJSCClass):
2498
2499 2019-03-20  Saam Barati  <sbarati@apple.com>
2500
2501         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2502         https://bugs.webkit.org/show_bug.cgi?id=195721
2503
2504         Reviewed by Filip Pizlo.
2505
2506         * Scripts/run-javascriptcore-tests:
2507
2508 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2509
2510         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2511         https://bugs.webkit.org/show_bug.cgi?id=196049
2512
2513         Reviewed by Tim Horton.
2514
2515         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2516         overflow scrolling in general, so rename it.
2517
2518         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2519
2520 2019-03-20  Daniel Bates  <dabates@apple.com>
2521
2522         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2523         https://bugs.webkit.org/show_bug.cgi?id=196031
2524         <rdar://problem/49078172>
2525
2526         Reviewed by Tim Horton.
2527
2528         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2529         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2530         same code path used when the Done button is pressed to dismiss the <select> picker.
2531
2532         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2533         (TestWebKitAPI::TEST):
2534
2535 2019-03-20  Chris Dumez  <cdumez@apple.com>
2536
2537         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2538         https://bugs.webkit.org/show_bug.cgi?id=196029
2539         <rdar://problem/48954651>
2540
2541         Reviewed by Tim Horton.
2542
2543         Add API test coverage.
2544
2545         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2546
2547 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2548
2549         [ews-build] Improve failure summary string for ApplyPatch step
2550         https://bugs.webkit.org/show_bug.cgi?id=195995
2551
2552         Reviewed by Alexey Proskuryakov.
2553
2554         * BuildSlaveSupport/ews-build/steps.py:
2555         (ApplyPatch.getResultSummary): Override getResultSummary.
2556
2557 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2558
2559         AX: Implement support for new meter ARIA role
2560         https://bugs.webkit.org/show_bug.cgi?id=195966
2561
2562         Reviewed by Chris Fleizach.
2563
2564         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2565         to AXLevelIndicator.
2566
2567         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2568
2569 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2570
2571         [WebAuthN] Implement FIDO AppID extension
2572         https://bugs.webkit.org/show_bug.cgi?id=143491
2573         <rdar://problem/48298273>
2574
2575         Reviewed by Brent Fulgham.
2576
2577         Add a test that covers the new flag of convertToU2fSignCommand.
2578
2579         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2580         (TestWebKitAPI::TEST):
2581         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2582         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2583         (TestWebKitAPI::TEST):
2584
2585 2019-03-19  Keith Rollin  <krollin@apple.com>
2586
2587         Add support for more platforms to generate-xcfilelists
2588         https://bugs.webkit.org/show_bug.cgi?id=195977
2589
2590         Reviewed by Alexey Proskuryakov.
2591
2592         generate-xcfilelists incorrectly complains when involved with building
2593         WebKit for iphonesimulator:
2594
2595             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2596             …
2597             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2598
2599         Address this by teaching generate-xcfilelists about more platforms.
2600
2601         * Scripts/generate-xcfilelists:
2602
2603 2019-03-19  John Wilander  <wilander@apple.com>
2604
2605         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2606         https://bugs.webkit.org/show_bug.cgi?id=195923
2607         <rdar://problem/49001272>
2608
2609         Reviewed by Alex Christensen.
2610
2611         This patch does the following to the TestRunner:
2612         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2613         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2614         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2615
2616         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2618         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2620         * WebKitTestRunner/TestController.cpp:
2621         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2622         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2623         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2624         * WebKitTestRunner/TestController.h:
2625         * WebKitTestRunner/TestInvocation.cpp:
2626         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2627
2628 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2629
2630         [CMake] Support more clang and gcc sanitizers
2631         https://bugs.webkit.org/show_bug.cgi?id=195956
2632
2633         Reviewed by Michael Catanzaro.
2634
2635         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2636
2637 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2638
2639         [ews-build] Improve summary for PrintConfiguration step
2640         https://bugs.webkit.org/show_bug.cgi?id=195945
2641
2642         Reviewed by Lucas Forschler.
2643
2644         * BuildSlaveSupport/ews-build/steps.py:
2645         (PrintConfiguration.getResultSummary): Override getResultSummary.
2646
2647 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2648
2649         [ews-build] Improve summary for CheckOutSource step
2650         https://bugs.webkit.org/show_bug.cgi?id=195963
2651
2652         Reviewed by Lucas Forschler.
2653
2654         * BuildSlaveSupport/ews-build/steps.py:
2655         (CheckOutSource.getResultSummary):
2656
2657 2019-03-19  Daniel Bates  <dabates@apple.com>
2658
2659         [iOS] Focus not preserved when switching between tabs
2660         https://bugs.webkit.org/show_bug.cgi?id=195820
2661         <rdar://problem/43614450>
2662
2663         Reviewed by Brent Fulgham.
2664
2665         Add tests to ensure that we restore focus when resigning and becoming first responder.
2666
2667         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2668         (TestWebKitAPI::TEST):
2669
2670 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2671
2672         Make WTFLogChannelState and WTFLogLevel enum classes
2673         https://bugs.webkit.org/show_bug.cgi?id=195904
2674
2675         Reviewed by Eric Carlson.
2676
2677         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2678         (TestWebKitAPI::TEST_F):
2679
2680 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2681
2682         [GStreamer][EME] Backported mssdemux protection data crash fix
2683         https://bugs.webkit.org/show_bug.cgi?id=195918
2684
2685         Reviewed by Philippe Normand.
2686
2687         * gstreamer/jhbuild.modules:
2688         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2689
2690 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2691
2692         Unreviewed, rolling out r243132.
2693
2694         Broke GTK build
2695
2696         Reverted changeset:
2697
2698         "Make WTFLogChannelState and WTFLogLevel enum classes"
2699         https://bugs.webkit.org/show_bug.cgi?id=195904
2700         https://trac.webkit.org/changeset/243132
2701
2702 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2703
2704         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2705
2706         * Scripts/webkitdirs.pm:
2707         (builtDylibPathForName): Adjust the shared library name that's changed
2708         with the API version bump in r243073.
2709
2710 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2711
2712         Make WTFLogChannelState and WTFLogLevel enum classes
2713         https://bugs.webkit.org/show_bug.cgi?id=195904
2714
2715         Reviewed by Eric Carlson.
2716
2717         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2718         (TestWebKitAPI::TEST_F):
2719
2720 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2721
2722         Disable flaky test added in r2431100
2723         https://webkit.org/b/195785
2724
2725         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2726         (TestWebKitAPI::TEST):
2727         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2728
2729 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2730
2731         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2732         https://bugs.webkit.org/show_bug.cgi?id=195916
2733
2734         Reviewed by Tim Horton.
2735
2736         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2737         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2738
2739 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2742
2743         * Scripts/webkitpy/common/config/contributors.json:
2744
2745 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2746
2747         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2748         https://bugs.webkit.org/show_bug.cgi?id=195785
2749
2750         Reviewed by Geoffrey Garen.
2751
2752         * TestWebKitAPI/TCPServer.cpp: Added.
2753         (TestWebKitAPI::TCPServer::TCPServer):
2754         (TestWebKitAPI::TCPServer::~TCPServer):
2755         (TestWebKitAPI::TCPServer::socketBindListen):
2756         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2757         * TestWebKitAPI/TCPServer.h: Added.
2758         (TestWebKitAPI::TCPServer::port const):
2759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2760         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2761         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2762         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2763         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2764         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2765         (TestWebKitAPI::respondSlowly):
2766         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2767         (TestWebKitAPI::downloadAtRate):
2768         (TestWebKitAPI::TEST):
2769
2770 2019-03-18  Saam Barati  <sbarati@apple.com>
2771
2772         Add a plan file for JetStream 2
2773         https://bugs.webkit.org/show_bug.cgi?id=190734
2774
2775         Reviewed by Mark Lam.
2776
2777         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2778
2779 2019-03-18  Chris Dumez  <cdumez@apple.com>
2780
2781         Delay WebProcess launch until a load is triggered in a Web view
2782         https://bugs.webkit.org/show_bug.cgi?id=195758
2783         <rdar://problem/48126013>
2784
2785         Reviewed by Geoff Garen.
2786
2787         Add API test coverage. Also update some existing API tests to not expect
2788         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2789
2790         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2791         (TestWebKitAPI::TEST):
2792         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2793         (TestWebKitAPI::TEST):
2794         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2795         (TEST):
2796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2797         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2798         (TEST):
2799         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2800         (TEST):
2801         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2802
2803 2019-03-18  Xan Lopez  <xan@igalia.com>
2804
2805         [CMake] Prevent potential warning when determining $architecture
2806         https://bugs.webkit.org/show_bug.cgi?id=195891
2807
2808         Reviewed by Michael Catanzaro.
2809
2810         It's possible for generateBuildSystemForCMakeProject to be called
2811         before determineArchitecture() is ever called. This will make the
2812         first eq check with $architecture to be bogus (and print a
2813         warning). Change that to an eq check with architecture(), which
2814         implicitly calls determineArchitecture() if needed, and change all
2815         the other similar cases in the method in the same way to prevent
2816         future bugs like this one.
2817
2818         * Scripts/webkitdirs.pm:
2819         (generateBuildSystemFromCMakeProject):
2820
2821 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2822
2823         [WPE] Tarballs generated with “make dist” cannot build documentation
2824         https://bugs.webkit.org/show_bug.cgi?id=195885
2825
2826         Reviewed by Carlos Garcia Campos.
2827
2828         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2829
2830 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2831
2832         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2833         https://bugs.webkit.org/show_bug.cgi?id=195883
2834
2835         Reviewed by Carlos Garcia Campos.
2836
2837         * gtkdoc/gtkdoc.py:
2838         (GTKDoc._run_command): When commands fail to run, include the full command line for
2839         the program invocation and the output it has generated on the standard error stream.
2840
2841 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2842
2843         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2844         https://bugs.webkit.org/show_bug.cgi?id=195786
2845
2846         Reviewed by Philippe Normand.
2847
2848         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2849         * wpe/jhbuild.modules: Ditto.
2850
2851 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2852
2853         [ews-build] Don't run clean builds on EWS builders
2854         https://bugs.webkit.org/show_bug.cgi?id=195851
2855
2856         Reviewed by Geoffrey Garen.
2857
2858         * BuildSlaveSupport/ews-build/factories.py:
2859
2860 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2861
2862         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2863         https://bugs.webkit.org/show_bug.cgi?id=195849
2864
2865         Reviewed by Chris Dumez.
2866
2867         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2870         (runWebsiteDataStoreCustomPaths):
2871
2872 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2873
2874         webkitpy: Upload test results
2875         https://bugs.webkit.org/show_bug.cgi?id=195755
2876         <rdar://problem/48896182>
2877
2878         Reviewed by Aakash Jain.
2879
2880         Establish a new format for uploading results that is not tied to layout tests, apply
2881         that format to webkitpy tests.
2882
2883         * Scripts/webkitpy/common/checkout/scm/git.py:
2884         (Git.native_branch): Return what branch the current checkout is on.
2885         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2886         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2887         * Scripts/webkitpy/common/checkout/scm/svn.py:
2888         (SVN.native_branch): Ditto.
2889         * Scripts/webkitpy/common/system/platforminfo.py:
2890         (PlatformInfo.build_version): Return a build version for Mac.
2891         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2892         (MockPlatformInfo.__init__):
2893         (MockPlatformInfo.build_version):
2894         * Scripts/webkitpy/results: Added.
2895         * Scripts/webkitpy/results/__init__.py: Added.
2896         * Scripts/webkitpy/results/options.py: Added.
2897         (upload_options): OptParse list for upload options.
2898         * Scripts/webkitpy/results/upload.py: Added.
2899         (Upload): Class which enforces the upload format expected by the results server.
2900         (Upload.Expectations):
2901         (Upload.create_configuration):
2902         (Upload.create_commit):
2903         (Upload.create_details):
2904         (Upload.create_run_stats):
2905         (Upload.create_test_result):
2906         (Upload.__init__):
2907         (Upload.Encoder): Encode Upload object as json.
2908         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2909         * Scripts/webkitpy/results/upload_unittest.py: Added.
2910         * Scripts/webkitpy/test/main.py:
2911         (Tester._parse_args): Add upload arguments.
2912         (Tester._run_tests): Allow results to be uploaded.
2913         * Scripts/webkitpy/test/runner.py:
2914         (Runner.__init__): Record which tests were run, rather than just counting them.
2915         (Runner.handle):
2916         * Scripts/webkitpy/test/runner_unittest.py:
2917         (RunnerTest.test_run):
2918         * Scripts/webkitpy/thirdparty/__init__.py:
2919         (AutoinstallImportHook.find_module): Add requests auto-install.
2920         (AutoinstallImportHook._install_requests):
2921         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2922         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2923
2924 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2925
2926         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2927         https://bugs.webkit.org/show_bug.cgi?id=195810
2928
2929         Reviewed by Tim Horton.
2930
2931         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2932         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2933         ending certain layout tests.
2934
2935         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2936         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2937         (-[TestRunnerWKWebView dealloc]):
2938         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2939
2940         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2941         helper method when destroying the web view, and when resetting state between tests.
2942
2943         * WebKitTestRunner/ios/TestControllerIOS.mm:
2944         (WTR::TestController::platformResetStateToConsistentValues):
2945
2946         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2947
2948 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2949
2950         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2951         https://bugs.webkit.org/show_bug.cgi?id=190350
2952         <rdar://problem/45089503>
2953
2954         Reviewed by Geoffrey Garen.
2955
2956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2957         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2958         (TEST):
2959         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2960         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2961         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2962         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2963         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2964         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2965         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2966         (runTest):
2967         (createDirectories):
2968         (TEST):
2969         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2970         (TEST):
2971         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2972         (TEST):
2973
2974 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2975
2976         Add support to WebPage for getting the contents as an attributed string.
2977         https://bugs.webkit.org/show_bug.cgi?id=195636
2978         rdar://problem/45055697
2979
2980         Reviewed by Tim Horton.
2981
2982         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2983         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2984
2985 2019-03-15  Chris Dumez  <cdumez@apple.com>
2986
2987         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2988         https://bugs.webkit.org/show_bug.cgi?id=195747
2989
2990         Reviewed by Geoff Garen.
2991
2992         Add API test coverage.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2995
2996 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2997
2998         Unreviewed, rolling out r242952.
2999
3000         Causing API failures on iOS Simulator
3001
3002         Reverted changeset:
3003
3004         "[PSON] Make sure the WebProcessCache is leverage when
3005         relaunching a process after termination"
3006         https://bugs.webkit.org/show_bug.cgi?id=195747
3007         https://trac.webkit.org/changeset/242952
3008
3009 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3010
3011         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3012         https://bugs.webkit.org/show_bug.cgi?id=195740
3013
3014         Reviewed by Ross Kirsling.
3015
3016         window.open doesn't work for WebKitBrowserWindow because it is not
3017         implemented yet.
3018
3019         1. Implemented createNewPage callback of WKPageUIClient.
3020         2. Changed MainWindow to take a BrowserWindow factory function
3021           instead of BrowserWindowType to be flexible to create
3022           BrowserWindow with extra settings.
3023         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3024           because it is not relevant with MainWindow anymore.
3025
3026         * MiniBrowser/win/Common.cpp:
3027         (parseCommandLine):
3028         * MiniBrowser/win/Common.h:
3029         (CommandLineOptions::CommandLineOptions):
3030         * MiniBrowser/win/MainWindow.cpp:
3031         (MainWindow::MainWindow):
3032         (MainWindow::create):
3033         (MainWindow::init):
3034         (MainWindow::WndProc):
3035         * MiniBrowser/win/MainWindow.h:
3036         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3037         (PrintWebUIDelegate::createWebViewWithRequest):
3038         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3039         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3040         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3041         (WebKitBrowserWindow::updateProxySettings):
3042         (WebKitBrowserWindow::createNewPage):
3043         * MiniBrowser/win/WebKitBrowserWindow.h:
3044         * MiniBrowser/win/WinMain.cpp:
3045         (wWinMain):
3046
3047 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3048
3049         Make it possible to test scrolling tree layer manipulation more easily
3050         https://bugs.webkit.org/show_bug.cgi?id=195780
3051
3052         Reviewed by Tim Horton.
3053         
3054         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3055         cuts off communication of scrolling tree scrolls back to the web process
3056         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3057         allows tests to trigger scrolls which run the scrolling tree layer positioning
3058         logic, but never get another commit from the web process that might mask
3059         scrolling tree bugs.
3060         
3061         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3062         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3063         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3064
3065         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3066         (WTR::UIScriptController::scrollUpdatesDisabled const):
3067         (WTR::UIScriptController::setScrollUpdatesDisabled):
3068         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3069         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3070         (WTR::UIScriptController::scrollUpdatesDisabled const):
3071         (WTR::UIScriptController::setScrollUpdatesDisabled):
3072         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3073         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3074         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3075         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3076         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3077         * WebKitTestRunner/ios/TestControllerIOS.mm:
3078         (WTR::TestController::platformResetStateToConsistentValues):
3079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3080         (WTR::UIScriptController::scrollUpdatesDisabled const):
3081         (WTR::UIScriptController::setScrollUpdatesDisabled):
3082
3083 2019-03-14  Youenn Fablet  <youenn@apple.com>
3084
3085         Move IDB storage in private browsing mode to NetworkProcess
3086         https://bugs.webkit.org/show_bug.cgi?id=195602
3087
3088         Reviewed by Brady Eidson.
3089
3090         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3091         (TEST):
3092
3093 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [ews-build] Make descriptionDone messages more readable
3096         https://bugs.webkit.org/show_bug.cgi?id=195760
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/ews-build/steps.py:
3101         * BuildSlaveSupport/ews-build/steps_unittest.py:
3102
3103 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3104
3105         [ews-build] Generate status-bubble hover-over messages
3106         https://bugs.webkit.org/show_bug.cgi?id=195680
3107
3108         Reviewed by Lucas Forschler.
3109
3110         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3111         (StatusBubble):
3112         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3113         on hover-over.
3114         (StatusBubble._iso_time):
3115         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3116         hover-over message.
3117         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3118
3119 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3120
3121         [ews-app] Gracefully handle the case when state_string is None
3122         https://bugs.webkit.org/show_bug.cgi?id=195753
3123
3124         Reviewed by Lucas Forschler.
3125
3126         * BuildSlaveSupport/ews-app/ews/models/build.py:
3127         * BuildSlaveSupport/ews-app/ews/models/step.py:
3128
3129 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-app] Status bubble display pending for currently running build step
3132         https://bugs.webkit.org/show_bug.cgi?id=195744
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-build/events.py:
3137         (Events.stepStarted): If state_string is pending, replace it with step name.
3138
3139 2019-03-14  Chris Dumez  <cdumez@apple.com>
3140
3141         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3142         https://bugs.webkit.org/show_bug.cgi?id=195750
3143
3144         Reviewed by Geoffrey Garen.
3145
3146         Add API test coverage.
3147
3148         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3149         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3150         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3151         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3152
3153 2019-03-14  Chris Dumez  <cdumez@apple.com>
3154
3155         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3156         https://bugs.webkit.org/show_bug.cgi?id=195747
3157
3158         Reviewed by Geoff Garen.
3159
3160         Add API test coverage.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3163
3164 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3165
3166         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3167         https://bugs.webkit.org/show_bug.cgi?id=195725
3168         <rdar://problem/48545062>
3169
3170         Reviewed by Tim Horton.
3171
3172         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3173         handler is nil.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3176         (TestWebKitAPI::TEST):
3177
3178 2019-03-13  Sam Weinig  <sam@webkit.org>
3179
3180         Add utility function to allow easy reverse range-based iteration of a container
3181         https://bugs.webkit.org/show_bug.cgi?id=195542
3182
3183         Reviewed by Antti Koivisto.
3184
3185         * TestWebKitAPI/CMakeLists.txt:
3186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3187         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3188         (TestWebKitAPI::TEST):
3189         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3190
3191 2019-03-13  Chris Dumez  <cdumez@apple.com>
3192
3193         Use a ServiceWorker process per registrable domain
3194         https://bugs.webkit.org/show_bug.cgi?id=195649
3195
3196         Reviewed by Youenn Fablet.
3197
3198         Update API test coverage.
3199
3200         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3201
3202 2019-03-13  Chris Dumez  <cdumez@apple.com>
3203
3204         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3205         https://bugs.webkit.org/show_bug.cgi?id=195684
3206         <rdar://problem/48294714>
3207
3208         Reviewed by Antti Koivisto.
3209
3210         Add API test coverage.
3211
3212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3213
3214 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews-app] Remove unused patch view
3217         https://bugs.webkit.org/show_bug.cgi?id=195669
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * BuildSlaveSupport/ews-app/ews/urls.py:
3222         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3223
3224 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3225
3226         [ews-app] Use Buildbot result code variables
3227         https://bugs.webkit.org/show_bug.cgi?id=195668
3228
3229         Reviewed by Alexey Proskuryakov.
3230
3231         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3232         (Buildbot): Added Buildbot result code variables.
3233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3234         (StatusBubble._build_bubble): Used Buildbot result code variables.
3235
3236 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3237
3238         [Flatpak] Expand submodule recursively
3239         https://bugs.webkit.org/show_bug.cgi?id=195672
3240
3241         Building WPE with flatpak was impossible without that as it was raising an exception.
3242         Also update wpebackend-fdo to match what is built in jhbuild
3243
3244         Reviewed by Philippe Normand.
3245
3246         * flatpak/flatpakutils.py:
3247         (expand_submodules_recurse):
3248         (expand_manifest):
3249         * flatpak/org.webkit.WPEModules.yaml:
3250
3251 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-app] status bubble should be hidden for certain builds
3254         https://bugs.webkit.org/show_bug.cgi?id=194597
3255
3256         Reviewed by Dewei Zhu.
3257
3258         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3259         (StatusBubble._build_bubble):
3260         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3261         because the patch didn't have relevant changes.
3262         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3263         in production yet.
3264
3265 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3266
3267         [Win] Fix a slew of simple clang-cl warnings.
3268         https://bugs.webkit.org/show_bug.cgi?id=195652
3269
3270         Reviewed by Don Olmstead.
3271
3272         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3273         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3274
3275 2019-03-12  Justin Fan  <justin_fan@apple.com>
3276
3277         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3278         https://bugs.webkit.org/show_bug.cgi?id=195518
3279         <rdar://problem/46322356>
3280
3281         Reviewed by Myles C. Maxfield.
3282
3283         * DumpRenderTree/DerivedSources-input.xcfilelist:
3284         * DumpRenderTree/DerivedSources-output.xcfilelist:
3285
3286 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3287
3288         Unreviewed, rolling out r242825.
3289         https://bugs.webkit.org/show_bug.cgi?id=195648
3290
3291         "Broke webkitpy tests with my change to
3292         lldb_dump_class_layout.py" (Requested by rmorisset on
3293         #webkit).
3294
3295         Reverted changeset:
3296
3297         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3298         classes with suspicious padding"
3299         https://bugs.webkit.org/show_bug.cgi?id=195573
3300         https://trac.webkit.org/changeset/242825
3301
3302 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3303
3304         [ews-build] Show status bubbles while the patch is waiting in queue
3305         https://bugs.webkit.org/show_bug.cgi?id=195618
3306
3307         Reviewed by Lucas Forschler.
3308
3309         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3310         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3311         enabled in initial deployment.
3312         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3313         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3314         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3315         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3316         (StatusBubble._build_bubbles_for_patch):
3317
3318 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3319
3320         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3321         https://bugs.webkit.org/show_bug.cgi?id=195573
3322
3323         Reviewed by Simon Fraser.
3324
3325         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3326
3327         * Scripts/dump-class-layout:
3328         (main):
3329         * lldb/lldb_dump_class_layout.py:
3330         (ClassLayout.__init__):
3331         (ClassLayout._compute_padding_recursive):
3332         (LLDBDebuggerInstance.dump_layout_for_classname):
3333         (LLDBDebuggerInstance):
3334         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3335         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3336
3337 2019-03-12  Chris Dumez  <cdumez@apple.com>
3338
3339         Device Orientation access permission should be denied unless explicitly granted by the client
3340         https://bugs.webkit.org/show_bug.cgi?id=195625
3341
3342         Reviewed by Youenn Fablet.
3343
3344         add API test coverage.
3345
3346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3347         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3348         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3349         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3350         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3351         (runDeviceOrientationTest):
3352         (TEST):
3353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3354         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3355
3356 2019-03-12  Jer Noble  <jer.noble@apple.com>
3357
3358         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3359         https://bugs.webkit.org/show_bug.cgi?id=195137
3360         <rdar://problem/48810307>
3361
3362         Reviewed by Eric Carlson.
3363
3364         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3365         (TestWebKitAPI::TEST):
3366
3367 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3368
3369         [ews-build] Change urls from uat to production
3370         https://bugs.webkit.org/show_bug.cgi?id=195566
3371
3372         Reviewed by Lucas Forschler.
3373
3374         * BuildSlaveSupport/ews-app/ews/config.py:
3375         * BuildSlaveSupport/ews-build/events.py:
3376         * BuildSlaveSupport/ews-build/steps.py:
3377
3378 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3379
3380         [ews-build] change max_builds for local-worker to 1
3381         https://bugs.webkit.org/show_bug.cgi?id=195568
3382
3383         Reviewed by Lucas Forschler.
3384
3385         * BuildSlaveSupport/ews-build/loadConfig.py:
3386
3387 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3388
3389         Fix the build
3390
3391         * TestRunnerShared/spi/PencilKitTestSPI.h:
3392         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3393
3394 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3395
3396         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3397         https://bugs.webkit.org/show_bug.cgi?id=194131
3398
3399         Reviewed by Michael Catanzaro.
3400
3401         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3402         (uriChanged):
3403         (testUnfinishedSubresourceLoad):
3404         (serverCallback):
3405         (beforeAll):
3406
3407 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3408
3409         WTF::Expected should use std::addressof instead of operator&
3410         https://bugs.webkit.org/show_bug.cgi?id=195604
3411
3412         Reviewed by Myles Maxfield.
3413
3414         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3415         (TestWebKitAPI::Unique::Unique):
3416         (TestWebKitAPI::Unique::operator&):
3417         (TestWebKitAPI::TEST):
3418
3419 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3420
3421         Add Optional to Forward.h.
3422         https://bugs.webkit.org/show_bug.cgi?id=195586
3423
3424         Reviewed by Darin Adler.
3425
3426         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3427         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3428         Remove unnecessary includes from headers.
3429
3430 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3431
3432         Add testing API to hit-test and scroll overflow scrollers
3433         https://bugs.webkit.org/show_bug.cgi?id=195278
3434
3435         Reviewed by Antti Koivisto.
3436         
3437         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3438         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3439         
3440         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3441
3442         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3443         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3444         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3445         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3446         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3447         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3448         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3449         (WTR::enclosingScrollViewIncludingSelf):
3450         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3451
3452 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3453
3454         API test WebKit.RequestTextInputContext fails on iOS
3455         https://bugs.webkit.org/show_bug.cgi?id=195585
3456
3457         Reviewed by Wenson Hsieh and Simon Fraser.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3460         (applyStyle):
3461         (TEST):
3462         Add a viewport, so that the coordinates match up on iOS.
3463         Scroll by moving the UIScrollView's contentOffset.
3464
3465 2019-03-11  Chris Dumez  <cdumez@apple.com>
3466
3467         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3468         https://bugs.webkit.org/show_bug.cgi?id=195506
3469         <rdar://problem/48733477>
3470
3471         Reviewed by Alex Christensen.
3472
3473         Add API test coverage.
3474
3475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3476
3477 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3478
3479         Adding myself to contributors.json
3480
3481         Unreviewed, addming myself to contributors.json .
3482
3483         * Scripts/webkitpy/common/config/contributors.json:
3484
3485 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3486
3487         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3488         https://bugs.webkit.org/show_bug.cgi?id=195511
3489         <rdar://problem/44873269>
3490
3491         Reviewed by Darin Adler.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3494         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3495         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3496         (TEST_F):
3497
3498 2019-03-11  Chris Dumez  <cdumez@apple.com>
3499
3500         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3501         https://bugs.webkit.org/show_bug.cgi?id=195561
3502
3503         Reviewed by Youenn Fablet.
3504
3505         Make sure the JS in the test requests for permission to receive device orientation events.
3506
3507         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3508
3509 2019-03-11  Youenn Fablet  <youenn@apple.com>
3510
3511         Allow storage quota increase by default in WTR
3512         https://bugs.webkit.org/show_bug.cgi?id=195541
3513
3514         Reviewed by Geoffrey Garen.
3515
3516         Allow storage quota increase by default in WTR.
3517         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3518         Use this for tests that explicitly need cache increase.
3519
3520         Instead of increasing quota by 2, make sure the next request is
3521         granted by adding all given parameters.
3522
3523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3525         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3526         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::setAllowStorageQuotaIncrease):
3530         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3531         * WebKitTestRunner/TestController.h:
3532         * WebKitTestRunner/TestInvocation.cpp:
3533         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3534         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3535         (WTR::TestController::cocoaResetStateToConsistentValues):
3536         (WTR::TestController::setAllowStorageQuotaIncrease):
3537         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3538         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3539         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3540
3541 2019-03-11  Xan Lopez  <xan@igalia.com>
3542
3543         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3544         https://bugs.webkit.org/show_bug.cgi?id=194147
3545
3546         Reviewed by Michael Saboff.
3547
3548         To make --32-bit work correctly on Linux/64bit we need to:
3549
3550         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3551         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3552         unfortunately CMake only allows us to do this during
3553         crosscompilation, which is overkill here.
3554         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3555         pkg-config detection module uses the x86 .pc files instead of the
3556         x86_64 ones.
3557         - Set the -m32 flags for the compiler.
3558
3559         * Scripts/webkitdirs.pm:
3560         (generateBuildSystemFromCMakeProject):
3561
3562 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3563
3564         Add MotionMark-1.1 plan file for run-benchmark script.
3565         https://bugs.webkit.org/show_bug.cgi?id=195481
3566
3567         Rubber-stamped by Darin Adler.
3568
3569         Run-benchmark script should support MontionMark-1.1.
3570
3571         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3572
3573 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3574
3575         [ews-app] Add support for submit-to-ews url
3576         https://bugs.webkit.org/show_bug.cgi?id=195477
3577
3578         Reviewed by Lucas Forschler.
3579
3580         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3581         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3582         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3583         * BuildSlaveSupport/ews-app/ews/urls.py:
3584         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3585
3586 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3587
3588         Unreviewed, rolling out r242688, r242643, r242624.
3589
3590         Caused multiple layout test failures and crashes on iOS and macOS.
3591
3592         Reverted changeset:
3593
3594         "requestAnimationFrame should execute before the next frame"
3595         https://bugs.webkit.org/show_bug.cgi?id=177484
3596         https://trac.webkit.org/changeset/242624/webkit
3597
3598         * Tracing/SystemTracePoints.plist:
3599
3600 2019-03-11  John Wilander  <wilander@apple.com>
3601
3602         Resource Load Statistics: Make it possible exclude localhost from classification
3603         https://bugs.webkit.org/show_bug.cgi?id=195474
3604         <rdar://problem/47520577>
3605
3606         Reviewed by Brent Fulgham.
3607
3608         This patch allows for localhost to be excluded from classification and
3609         treatment as a prevalent resource.
3610
3611         The WebKit Tools change adds a new function called
3612         testRunner.setStatisticsIsRunningTest() which can be used to control this
3613         behavior.
3614
3615         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3617         (WTR::TestRunner::setStatisticsIsRunningTest):
3618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3619         * WebKitTestRunner/TestController.cpp:
3620         (WTR::TestController::setStatisticsIsRunningTest):
3621         * WebKitTestRunner/TestController.h:
3622         * WebKitTestRunner/TestInvocation.cpp:
3623         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3624
3625 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3626
3627         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3628         https://bugs.webkit.org/show_bug.cgi?id=195560
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * BuildSlaveSupport/ews-build/master.cfg:
3633
3634 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3635
3636         Unreviewed, rolling out r242698.
3637
3638         API test crashes on bots.
3639
3640         Reverted changeset:
3641
3642         "Add a WKContentRuleList variant that uses copied memory
3643         instead of mmap'd shared memory for class A containerized
3644         apps"
3645         https://bugs.webkit.org/show_bug.cgi?id=195511
3646         https://trac.webkit.org/changeset/242698
3647
3648 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3649
3650         [WPE] Enable web process sandbox
3651         https://bugs.webkit.org/show_bug.cgi?id=195169
3652
3653         Reviewed by Daniel Bates.
3654
3655         * wpe/install-dependencies:
3656         * wpe/jhbuild.modules:
3657
3658 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3659
3660         [ews-app] Use port 17000 for worker communication
3661         https://bugs.webkit.org/show_bug.cgi?id=195558
3662
3663         Reviewed by Lucas Forschler.
3664
3665         * BuildSlaveSupport/ews-build/master.cfg:
3666
3667 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3668
3669         [ews-build] unit-tests fail when passwords.json is missing
3670         https://bugs.webkit.org/show_bug.cgi?id=195557
3671
3672         Reviewed by Lucas Forschler.
3673
3674         * BuildSlaveSupport/ews-build/loadConfig.py:
3675         (loadBuilderConfig):
3676         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3677         (ConfigDotJSONTest.test_configuration):
3678         * BuildSlaveSupport/ews-build/master.cfg:
3679
3680 2019-03-11  Truitt Savell  <tsavell@apple.com>
3681
3682         Unreviewed, rolling out r242702.
3683
3684         Broke High Sierra builders.
3685
3686         Reverted changeset:
3687
3688         "Add utility function to allow easy reverse range-based
3689         iteration of a container"
3690         https://bugs.webkit.org/show_bug.cgi?id=195542
3691         https://trac.webkit.org/changeset/242702
3692
3693 2019-03-11  Sam Weinig  <sam@webkit.org>
3694
3695         Add utility function to allow easy reverse range-based iteration of a container
3696         https://bugs.webkit.org/show_bug.cgi?id=195542
3697
3698         Reviewed by Antti Koivisto.
3699
3700         * TestWebKitAPI/CMakeLists.txt:
3701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3702         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3703         (TestWebKitAPI::TEST):
3704         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3705
3706 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3707
3708         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3709         https://bugs.webkit.org/show_bug.cgi?id=195511
3710         <rdar://problem/44873269>
3711
3712         Reviewed by Darin Adler.
3713
3714         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3715         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3716         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3717         (TEST_F):
3718
3719 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3720
3721         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3722         https://bugs.webkit.org/show_bug.cgi?id=195499
3723
3724         Reviewed by Darin Adler.
3725
3726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3727         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3728         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3729         (-[WKWebView synchronouslyFocusTextInputContext:]):
3730         (applyStyle):
3731         (applyIframe):
3732         (TEST):
3733         Add some tests for this SPI.
3734
3735 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3736
3737         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3738         https://bugs.webkit.org/show_bug.cgi?id=181151
3739
3740         Reviewed by Don Olmstead.
3741
3742         * TestWebKitAPI/CMakeLists.txt:
3743         * TestWebKitAPI/PlatformWin.cmake:
3744         Enable TestWTF RunLoop tests in all platforms.
3745
3746         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3747         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3748         (TestWebKitAPI::DerivedOneShotTimer::fired):
3749         (TestWebKitAPI::TEST):
3750         Only a few platforms support nested RunLoop.
3751
3752         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3753         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3754
3755 2019-03-10  David Quesada  <david_quesada@apple.com>
3756
3757         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3758         https://bugs.webkit.org/show_bug.cgi?id=152480
3759
3760         Reviewed by Chris Dumez.
3761
3762         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3763         there are no additional references to the process pool besides the one held by
3764         the download, waits for the download to finish (in the sense that the
3765         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3766         measure, also check that the process pool has been deallocated at the end of the
3767         test. The test wouldn't be meaningful if the process pool were still alive.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3770         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3771         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3772             The download will be canceled because the delegate does not implement the
3773             method to decide the download's destination, so this is where we know the
3774             DownloadProxyMap is done with the DownloadProxy.
3775         (TEST):
3776
3777 2019-03-08  Chris Dumez  <cdumez@apple.com>
3778
3779         Add support for Device Orientation / Motion permission API
3780         https://bugs.webkit.org/show_bug.cgi?id=195329
3781         <rdar://problem/47645367>
3782
3783         Reviewed by Geoffrey Garen.
3784
3785         Add test infrastructure to help test the Device Orientation / Motion permission API.
3786
3787         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3789         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3790         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3791         * WebKitTestRunner/TestController.cpp:
3792         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3793         (WTR::TestController::createWebViewWithOptions):
3794         (WTR::TestController::resetStateToConsistentValues):
3795         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3796         * WebKitTestRunner/TestController.h:
3797         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3798         * WebKitTestRunner/TestInvocation.cpp:
3799         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3800
3801 2019-03-08  Saam barati  <sbarati@apple.com>
3802
3803         Add a compare-results script to compare benchmark results
3804         https://bugs.webkit.org/show_bug.cgi?id=195486
3805         <rdar://problem/48723397>
3806
3807         Reviewed by Geoffrey Garen.
3808
3809         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3810         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3811         to extend it to learn about our other benchmarks.
3812
3813         * Scripts/compare-results: Added.
3814         (readJSONFile):
3815         (detectJetStream2):
3816         (JetStream2Results):
3817         (detectSpeedometer2):
3818         (Speedometer2Results):
3819         (detectPLT5):
3820         (PLT5Results):
3821         (detectBenchmark):
3822         (biggerIsBetter):
3823         (ttest):
3824         (getOptions):
3825         (main):
3826
3827 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3828
3829         Ensure old tab state is cleared between iterations of run-benchmark
3830         https://bugs.webkit.org/show_bug.cgi?id=195393
3831         <rdar://problem/46885583>
3832
3833         Reviewed by Dewei Zhu.
3834
3835         a) ensure the default to restore state is not set
3836         b) terminate Safari correctly
3837         c) Set the system default to ignore Persistent State in Safari
3838
3839         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3840         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3841         (OSXBrowserDriver.prepare_env): 
3842         (OSXBrowserDriver.restore_env):
3843         (OSXBrowserDriver.close_browsers):
3844         (OSXBrowserDriver._terminate_processes):
3845         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3846         (OSXChromeDriver):
3847         (OSXChromeCanaryDriver):
3848         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3849         (OSXFirefoxDriver):
3850         (OSXFirefoxNightlyDriver):
3851         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3852         (OSXSafariDriver):
3853         (OSXSafariDriver.prepare_env):
3854
3855 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3856
3857         [GTK] Several InputMethodFilter tests are failing
3858         https://bugs.webkit.org/show_bug.cgi?id=195408
3859
3860         Reviewed by Carlos Garcia Campos.
3861
3862         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3863         Regressed in r241751.
3864         Hexadecimal values of keycodes are expressed now in upper letters.
3865         Composited characters should be cast to UTF8 strings.
3866
3867         (TestWebKitAPI::TEST):
3868
3869 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3870
3871         [GTK] Make Tools/gtkdoc python3 compatible
3872         https://bugs.webkit.org/show_bug.cgi?id=195359
3873
3874         Reviewed by Carlos Garcia Campos.
3875
3876         * gtkdoc/generate-gtkdoc:
3877         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3878         work with Python 2 and 3.
3879         (get_gtkdoc_module_paths):
3880         The iteritems() was removed in Python 3, so let's use items() that's
3881         available in Python 2 and 3.
3882         (get_generator_for_config):
3883         * gtkdoc/gtkdoc.py:
3884         (GTKDoc._run_command):
3885         The sys.stdout.write() is expecting str in Python 3 and not bytes
3886         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3887         for passing the bytes there.
3888
3889 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3890
3891         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3892         https://bugs.webkit.org/show_bug.cgi?id=195346
3893         <rdar://problem/48667048>
3894
3895         Unreviewed build fix for clang-cl.
3896
3897         * DumpRenderTree/win/DumpRenderTree.cpp:
3898         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3899
3900 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3901
3902         requestAnimationFrame should execute before the next frame
3903         https://bugs.webkit.org/show_bug.cgi?id=177484
3904
3905         Reviewed by Simon Fraser.
3906
3907         Add trace points for the page RenderingUpdate.
3908
3909         * Tracing/SystemTracePoints.plist:
3910
3911 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3912
3913         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3914         https://bugs.webkit.org/show_bug.cgi?id=195353
3915         <rdar://problem/48626394>
3916
3917         Reviewed by Simon Fraser.
3918
3919         * WebKitTestRunner/ios/TestControllerIOS.mm:
3920         (WTR::TestController::platformResetPreferencesToConsistentValues):
3921
3922 2019-03-07  John Wilander  <wilander@apple.com>
3923
3924         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3925         https://bugs.webkit.org/show_bug.cgi?id=195383
3926         <rdar://problem/48570136>
3927
3928         Reviewed by Brent Fulgham.
3929
3930         This patch adds test infrastructure to purge only script-accessible cookies,
3931         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3932
3933         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3934         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3935         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3937         * WebKitTestRunner/TestController.cpp:
3938         (WTR::TestController::statisticsDeleteCookiesForHost):
3939         * WebKitTestRunner/TestController.h:
3940         * WebKitTestRunner/TestInvocation.cpp:
3941         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3942
3943 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3944
3945         Unreviewed, rolling out r242354.
3946         https://bugs.webkit.org/show_bug.cgi?id=195402
3947
3948         breaks layout tests in all configurations (Requested by
3949         zdobersek on #webkit).
3950
3951         Reverted changeset:
3952
3953         "[WPE] Enable web process sandbox"
3954         https://bugs.webkit.org/show_bug.cgi?id=195169
3955         https://trac.webkit.org/changeset/242354
3956
3957 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3958
3959         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3960         https://bugs.webkit.org/show_bug.cgi?id=195346
3961
3962         Reviewed by Fujii Hironori.
3963
3964         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3965         (TestWebKitAPI::TEST):
3966         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3967
3968         * DumpRenderTree/win/DumpRenderTree.cpp:
3969         (findFontFallback):
3970         (addFontFallbackIfPresent):
3971         (removeFontFallbackIfPresent):
3972         (main):
3973         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3974         (TestWebKitAPI::Util::moduleDirectory):
3975         (TestWebKitAPI::Util::createInjectedBundlePath):
3976         Use wchar helpers as needed.
3977
3978 2019-03-06  Rob Buis  <rbuis@igalia.com>
3979
3980         Consider supporting the `referrerpolicy` attribute.
3981         https://bugs.webkit.org/show_bug.cgi?id=179053
3982
3983         Reviewed by Darin Adler.
3984
3985         Add a runtime flag for referrerpolicy attribute.
3986
3987         * DumpRenderTree/mac/DumpRenderTree.mm:
3988         (enableExperimentalFeatures):
3989
3990 2019-03-05  Daniel Bates  <dabates@apple.com>
3991
3992         Update expected API test result following r242379
3993         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3994
3995         Update expected x-coordinate of selection rect now that the left padding of
3996         a textarea is sized in ems (so dependent on the font size) just like the left
3997         padding of a text field.
3998
3999         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4000         (TestWebKitAPI::TEST):
4001
4002 2019-03-05  David Quesada  <david_quesada@apple.com>
4003
4004         [WK2] It should be possible to follow links with 'download' attributes
4005         https://bugs.webkit.org/show_bug.cgi?id=195145
4006         rdar://problem/48462642
4007
4008         Reviewed by Alex Christensen.
4009
4010         Add a unit test to verify that activating links with 'download' attributes now
4011         navigates to the linked resource, rather than starts downloading it. Add another
4012         to verify that it is still possible to explicitly download the link via the
4013         'Download' navigation action policy.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4016         (-[DownloadAttributeTestDelegate init]):
4017         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4018         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4019         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4020         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4021         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4022         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4023         (TEST):
4024         * WebKitTestRunner/TestController.cpp:
4025         (WTR::TestController::decidePolicyForNavigationAction):
4026         * WebKitTestRunner/TestController.h:
4027
4028 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4029
4030         [Curl] Implement Cookie Accept Policy.
4031         https://bugs.webkit.org/show_bug.cgi?id=191645
4032
4033         Reviewed by Fujii Hironori.
4034
4035         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4036         (TestWebKitAPI::Curl::TEST_F):
4037
4038 2019-03-05  Youenn Fablet  <youenn@apple.com>
4039
4040         Rename requestCacheStorageSpace to requestStorageSpace
4041         https://bugs.webkit.org/show_bug.cgi?id=195282
4042
4043         Reviewed by Chris Dumez.
4044
4045         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4046         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4047         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4048
4049 2019-03-05  Brady Eidson  <beidson@apple.com>
4050
4051         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4052         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4053
4054         Reviewed by Tim Horton.
4055
4056         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4057         different directory into that same WKWebView should work.
4058
4059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4060         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4061
4062 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4063
4064         Add WeakHashSet
4065         https://bugs.webkit.org/show_bug.cgi?id=195152
4066
4067         Reviewed by Antti Koivisto.
4068
4069         Added tests for WeakHashSet.
4070
4071         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4072         (TestWebKitAPI::Base::Base): Moved.
4073         (TestWebKitAPI::Derived::foo): Moved.
4074         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4075         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4076         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4077         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4078
4079 2019-03-04  Chris Dumez  <cdumez@apple.com>
4080
4081         Do not share WebProcesses between private and regular sessions
4082         https://bugs.webkit.org/show_bug.cgi?id=195189
4083         <rdar://problem/48421064>
4084
4085         Reviewed by Alex Christensen.
4086
4087         Add API test coverage.
4088
4089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4090         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4091
4092 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4093
4094         [WPE] Enable web process sandbox
4095         https://bugs.webkit.org/show_bug.cgi?id=195169
4096
4097         Reviewed by Daniel Bates.
4098
4099         * wpe/install-dependencies:
4100         * wpe/jhbuild.modules:
4101
4102 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4103
4104         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4105         https://bugs.webkit.org/show_bug.cgi?id=195206
4106
4107         Reviewed by Žan Doberšek.
4108
4109         Add a new test case.
4110
4111         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4112         (testJSCClass):
4113
4114 2019-03-04  Charlie Turner  <cturner@igalia.com>
4115
4116         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4117         https://bugs.webkit.org/show_bug.cgi?id=194898
4118
4119         Reviewed by Žan Doberšek.
4120
4121         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4122         a GCC extension that permits arithmetic on void* pointer. Inline
4123         the macro until this issue is fixed upstream.
4124
4125 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4126
4127         Rid the world of WK_API_ENABLED
4128         https://bugs.webkit.org/show_bug.cgi?id=195263
4129
4130         Reviewed by Dan Bernstein.
4131
4132         List of changed files elided because it's useless.
4133
4134 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4135
4136         Unreviewed follow-up to r242292.
4137
4138         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4139
4140         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4141         (TestWebKitAPI::testStrip): Renamed from strip.
4142         (TestWebKitAPI::TEST):
4143
4144 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4145
4146         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4147
4148         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4149         and bug #194272 for details.
4150
4151         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4152
4153 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4154
4155         Remove some more unused 32-bit code
4156         https://bugs.webkit.org/show_bug.cgi?id=195255
4157
4158         Reviewed by Darin Adler.
4159
4160         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4161         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4162         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4163         (NPP_New):
4164         (NPP_HandleEvent):
4165         (handleEventCarbon): Deleted.
4166
4167 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4168
4169         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4170
4171         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4172         (TestWebKitAPI::TEST):
4173
4174 2019-03-01  Darin Adler  <darin@apple.com>
4175
4176         Finish removing String::format
4177         https://bugs.webkit.org/show_bug.cgi?id=194893
4178
4179         Reviewed by Daniel Bates.
4180 '
4181         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4182
4183 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4184
4185         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4186         https://bugs.webkit.org/show_bug.cgi?id=195229
4187         <rdar://problem/48520362>
4188
4189         Reviewed by Chris Dumez.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4192         (TEST):
4193
4194 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4195
4196         Add a system trace scope for event region building
4197         https://bugs.webkit.org/show_bug.cgi?id=195226
4198
4199         Reviewed by Jon Lee.
4200
4201         This trace scope measures the time spend converting element rects into Region objects,
4202         which can be large on some pages.
4203
4204         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4205
4206         * Tracing/SystemTracePoints.plist:
4207
4208 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4209
4210         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4211         https://bugs.webkit.org/show_bug.cgi?id=194612
4212
4213         Reviewed by Alex Christensen.
4214
4215         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4216         Just test the new string-processing function and don't touch the actual environment.
4217         (Test cases are all as before, but based on operator== instead of strcmp.)
4218
4219 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4220
4221         [ews-app] Update primary keys for handling multiple Buildbot instances
4222         https://bugs.webkit.org/show_bug.cgi?id=195120
4223
4224         Reviewed by Stephanie Lewis.
4225
4226         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4227         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4228         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4229
4230         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4231         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4232         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4233         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4234         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4235         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4236
4237 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4238
4239         [WinCairo] Enable service worker
4240         https://bugs.webkit.org/show_bug.cgi?id=188318
4241
4242         Reviewed by Youenn Fablet.
4243
4244         * DumpRenderTree/DumpRenderTreePrefix.h:
4245         * TestWebKitAPI/PlatformWin.cmake:
4246         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4247         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4248         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4249
4250 2019-03-01  Justin Fan  <justin_fan@apple.com>
4251
4252         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4253         https://bugs.webkit.org/show_bug.cgi?id=195191
4254
4255         Rubber-stamped by Dean Jackson.
4256
4257         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4258
4259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4260
4261 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4262
4263         Unreviewed, fix lldb webkitpy tests
4264         https://bugs.webkit.org/show_bug.cgi?id=194375
4265
4266         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4267
4268         * lldb/lldb_webkit.py:
4269         (WTFStringImplProvider.is_8bit):
4270
4271 2019-02-28  David Quesada  <david_quesada@apple.com>
4272
4273         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4274         https://bugs.webkit.org/show_bug.cgi?id=195121
4275         rdar://problem/48450302
4276
4277         Reviewed by Alex Christensen.
4278
4279         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4280         configurations where the 'download' attribute is absent, blank, or populated
4281         with a filename, and where the anchor element is same-origin or cross-origin
4282         (meaning the 'download' attribute shouldn't be honored).
4283
4284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4285         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4286         (-[NavigationActionTestDelegate init]):
4287         (-[NavigationActionTestDelegate navigationAction]):
4288         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4289         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4290         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4291         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4292         (TEST):
4293
4294 2019-02-28  Antoine Quint  <graouts@apple.com>
4295
4296         Enable the Pointer Events runtime flag by default
4297         https://bugs.webkit.org/show_bug.cgi?id=195156
4298
4299         Reviewed by Dean Jackson.
4300
4301         * DumpRenderTree/mac/DumpRenderTree.mm:
4302         (enableExperimentalFeatures):
4303
4304 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4305
4306         Several PasteImage API tests are flaky
4307         https://bugs.webkit.org/show_bug.cgi?id=195160
4308
4309         Reviewed by Tim Horton.
4310
4311         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4312         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4313         listening for a "load" event after image load is already complete.
4314
4315         To address this, make these tests first register a "load" event handler, then run script to insert an image
4316         element into the document, and finally wait until the load event is observed before checking image size.
4317
4318         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4319
4320 2019-02-28  Chris Dumez  <cdumez@apple.com>
4321
4322         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4323         https://bugs.webkit.org/show_bug.cgi?id=195107
4324
4325         Reviewed by Alex Christensen.
4326
4327         Give some time for the zoom level to get restored.
4328
4329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4330
4331 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4332
4333         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4334         https://bugs.webkit.org/show_bug.cgi?id=194958
4335
4336         Reviewed by Geoffrey Garen.
4337
4338         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4339         (TEST):
4340
4341 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4342
4343         [ews-app] Update method to save build to handle builder_display_name
4344         https://bugs.webkit.org/show_bug.cgi?id=195047
4345
4346         Reviewed by Dewei Zhu.
4347
4348         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4349         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4350
4351 2019-02-28  Justin Fan  <justin_fan@apple.com>
4352
4353         [Web GPU] Enable Web GPU only on 64-bit
4354         https://bugs.webkit.org/show_bug.cgi?id=195139
4355
4356         Because Metal is only supported on 64 bit apps.
4357
4358         Unreviewed build fix.
4359
4360         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4361
4362 2019-02-27  Youenn Fablet  <youenn@apple.com>