Remember device orientation permission for the duration of the browsing session
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Chris Dumez  <cdumez@apple.com>
2
3         Remember device orientation permission for the duration of the browsing session
4         https://bugs.webkit.org/show_bug.cgi?id=196992
5         <rdar://problem/49946067>
6
7         Reviewed by Alex Christensen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
12         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
13         (TEST):
14
15 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
16
17         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
18         https://bugs.webkit.org/show_bug.cgi?id=196675
19
20         Reviewed by Lucas Forschler.
21
22         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
23         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
24
25 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
26
27         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
28         https://bugs.webkit.org/show_bug.cgi?id=196919
29         <rdar://problem/41630459>
30
31         Reviewed by Tim Horton.
32
33         Add iOS support for several new testing hooks. See below for more detail.
34
35         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
36         (WTR::UIScriptController::isDismissingMenu const):
37
38         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
39         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
40         by UIKit when dismissing the callout bar (i.e. UIMenuController).
41
42         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
43         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
44         (WTR::UIScriptController::isDismissingMenu const):
45         * TestRunnerShared/UIScriptContext/UIScriptController.h:
46         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
47         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
48         (WTR::InjectedBundle::didReceiveMessageToPage):
49         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
50         (WTR::TestRunner::setAllowedMenuActions):
51
52         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
53         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
54         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
55         against the name of the custom action.
56
57         (WTR::TestRunner::installCustomMenuAction):
58
59         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
60         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
61         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
62         triggered.
63
64         (WTR::TestRunner::performCustomMenuAction):
65
66         Invoked when the custom menu action is triggered.
67
68         * WebKitTestRunner/InjectedBundle/TestRunner.h:
69         * WebKitTestRunner/TestController.cpp:
70         (WTR::TestController::installCustomMenuAction):
71         (WTR::TestController::setAllowedMenuActions):
72         * WebKitTestRunner/TestController.h:
73         * WebKitTestRunner/TestInvocation.cpp:
74         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
75         (WTR::TestInvocation::performCustomMenuAction):
76
77         Add plumbing to call back into the injected bundle when performing the custom action.
78
79         * WebKitTestRunner/TestInvocation.h:
80         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
81         (WTR::TestController::installCustomMenuAction):
82         (WTR::TestController::setAllowedMenuActions):
83         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
84         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
85         (-[TestRunnerWKWebView initWithFrame:configuration:]):
86         (-[TestRunnerWKWebView becomeFirstResponder]):
87         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
88
89         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
90         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
91         in the Mail app on iOS.
92
93         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
94         (-[TestRunnerWKWebView setAllowedMenuActions:]):
95         (-[TestRunnerWKWebView resetCustomMenuAction]):
96         (-[TestRunnerWKWebView performCustomAction:]):
97         (-[TestRunnerWKWebView canPerformAction:withSender:]):
98         (-[TestRunnerWKWebView _willHideMenu]):
99         (-[TestRunnerWKWebView _didHideMenu]):
100         * WebKitTestRunner/ios/TestControllerIOS.mm:
101         (WTR::TestController::platformResetStateToConsistentValues):
102
103         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
104         if specified.
105
106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
107         (WTR::UIScriptController::isDismissingMenu const):
108
109 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
110
111         Allow sharing from imageSheet on an image document
112         https://bugs.webkit.org/show_bug.cgi?id=196891
113         <rdar://problem/25377386>
114
115         Reviewed by Tim Horton.
116
117         Test to make sure that the correct imageURL is extracted from an image element.
118
119         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
120         (TestWebKitAPI::TEST):
121
122 2019-04-16  Alex Christensen  <achristensen@webkit.org>
123
124         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
125         https://bugs.webkit.org/show_bug.cgi?id=196995
126
127         Reviewed by Brady Eidson.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
130         (TEST):
131
132 2019-04-16  Chris Dumez  <cdumez@apple.com>
133
134         URL set by document.open() is not communicated to the UIProcess
135         https://bugs.webkit.org/show_bug.cgi?id=196941
136         <rdar://problem/49237544>
137
138         Reviewed by Geoff Garen.
139
140         Add API test coverage.
141
142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
143         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
144         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
145         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
146         (TEST):
147
148 2019-04-16  Commit Queue  <commit-queue@webkit.org>
149
150         Unreviewed, rolling out r244321.
151         https://bugs.webkit.org/show_bug.cgi?id=196968
152
153         Causing all WK2 Debug builds to exit early after Assertion
154         failures. (Requested by ShawnRoberts on #webkit).
155
156         Reverted changeset:
157
158         "URL set by document.open() is not communicated to the
159         UIProcess"
160         https://bugs.webkit.org/show_bug.cgi?id=196941
161         https://trac.webkit.org/changeset/244321
162
163 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
164
165         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
166         https://bugs.webkit.org/show_bug.cgi?id=196948
167
168         Reviewed by Zalan Bujtas.
169
170         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
171         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
172
173 2019-04-15  Chris Dumez  <cdumez@apple.com>
174
175         URL set by document.open() is not communicated to the UIProcess
176         https://bugs.webkit.org/show_bug.cgi?id=196941
177         <rdar://problem/49237544>
178
179         Reviewed by Geoffrey Garen.
180
181         Add API test coverage.
182
183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
184         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
185         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
186         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
187         (TEST):
188
189 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
190
191         Using Tools/Scripts/clean-webkit should not install requests
192         https://bugs.webkit.org/show_bug.cgi?id=196940
193
194         Reviewed by Lucas Forschler.
195
196         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
197         existing, depending on the path autoinstalled is run through.
198         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
199         needed.
200         (Port.configuration_for_upload):
201         (Port.commits_for_upload):
202
203 2019-04-15  Alex Christensen  <achristensen@webkit.org>
204
205         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
206         https://bugs.webkit.org/show_bug.cgi?id=196773
207
208         Reviewed by Jer Noble.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
211         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
212         (TEST):
213
214 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
215
216         ews-build should clearly indicate flaky test failures
217         https://bugs.webkit.org/show_bug.cgi?id=196947
218
219         Reviewed by Lucas Forschler.
220
221         * BuildSlaveSupport/ews-build/steps.py:
222         (AnalyzeAPITestsResults.analyzeResults):
223
224 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
225
226         InjectedBundle parameters often need initialization function called before unarchiving
227         https://bugs.webkit.org/show_bug.cgi?id=189709
228         <rdar://problem/44573653>
229
230         Reviewed by Ryosuke Niwa.
231
232         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
233         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
234
235 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
236
237         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
238         https://bugs.webkit.org/show_bug.cgi?id=196681
239
240         Reviewed by Darin Adler.
241
242         Added tests.
243
244         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
245         (WTF_HashSet.RemoveIf):
246         (WTF_HashSet.RemoveIfShrinkToBestSize):
247
248 2019-04-15  John Wilander  <wilander@apple.com>
249
250         Send delayed Ad Click Attribution conversion requests to the click source
251         https://bugs.webkit.org/show_bug.cgi?id=196838
252         <rdar://problem/47650157>
253
254         Reviewed by Chris Dumez and Youenn Fablet.
255
256         This patch adds test infrastructure to override the default behavior in
257         WebKit::NetworkAdClickAttribution.
258
259         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
260         (TestWebKitAPI::TEST):
261         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
263         (WTR::TestRunner::dumpAdClickAttribution):
264         (WTR::TestRunner::clearAdClickAttribution):
265         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
266         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
270         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
271         * WebKitTestRunner/TestController.h:
272         * WebKitTestRunner/TestInvocation.cpp:
273         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
274
275 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
276
277         [ews-app] status-bubble should display position in queue
278         https://bugs.webkit.org/show_bug.cgi?id=196607
279
280         Reviewed by Lucas Forschler.
281
282         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
283         (StatusBubble._build_bubble):
284         (StatusBubble._queue_position): Method to calculate patch's position in queue.
285
286 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
287
288         [ews-build] Do not run clean build by default on EWS builders
289         https://bugs.webkit.org/show_bug.cgi?id=196897
290
291         Reviewed by Lucas Forschler.
292
293         * BuildSlaveSupport/ews-build/steps.py:
294         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
295         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
296         untracked directories like WebKitBuild).
297         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
298         untracked files/directories (like WebKitBuild).
299
300 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
301
302         TestRunner::notifyDone() should be safely reentrant
303         https://bugs.webkit.org/show_bug.cgi?id=196898
304
305         Reviewed by Darin Adler.
306
307         It is currently possible that TestRunner::notifyDone() will call itself, since
308         notifyDone() will force a repaint, which can start executing JavaScript, which
309         may call notifyDone() again. This can lead to test failures and flakiness.
310         Fix this by setting the m_waitToDump flag before calling the dump() method.
311
312         * DumpRenderTree/mac/TestRunnerMac.mm:
313         (TestRunner::notifyDone):
314         (TestRunner::forceImmediateCompletion):
315         * DumpRenderTree/win/TestRunnerWin.cpp:
316         (TestRunner::notifyDone):
317         (TestRunner::forceImmediateCompletion):
318
319 2019-04-15  Philippe Normand  <pnormand@igalia.com>
320
321         [GTK][WPE] Add enable-media websetting
322         https://bugs.webkit.org/show_bug.cgi?id=196863
323
324         Reviewed by Michael Catanzaro.
325
326         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
327         (testWebKitSettings): Add test for the enable-media web-setting.
328
329 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
330
331         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
332         https://bugs.webkit.org/show_bug.cgi?id=196905
333         <rdar://problem/49886096>
334
335         Reviewed by Tim Horton.
336
337         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
338         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
339         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
340         delay timer, we end up with this sequence of events in the problematic (failure) case:
341
342         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
343             ...IPC from UI to web process...
344         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
345             ...IPC from web to UI process...
346         (c) [UI]    Invoke completion handler for script #1
347         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
348             ...IPC from UI to web process...
349         (e) [Web]   Evaluate script #2 in the web process
350         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
351
352         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
353         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
354         #2 is run in step (e).
355
356         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
357         the UI process by waiting on a script message posted by the web process, after attachment updates are
358         dispatched.
359
360         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
361         (TestWebKitAPI::TEST):
362
363 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
364
365         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
366         https://bugs.webkit.org/show_bug.cgi?id=196909
367
368         Reviewed by Wenson Hsieh.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
371         (TestWebKitAPI::TEST):
372
373 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
374
375         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
376         https://bugs.webkit.org/show_bug.cgi?id=196880
377
378         Reviewed by Yusuke Suzuki.
379
380         Add a new function for bytecode cache tests that does not forceDiskCache
381         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
382         test added in this patch, since the code is invalid and therefore won't be
383         cached. It should also be useful for tests that evaluate dynamically
384         generated code.
385
386         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
387         * Scripts/run-jsc-stress-tests:
388
389 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
390
391         Update AudioSession route sharing policy
392         https://bugs.webkit.org/show_bug.cgi?id=196776
393         <rdar://problem/46501611>
394
395         Reviewed by Jer Noble.
396
397         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
398         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
399         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
400         (TestWebKitAPI::TEST):
401
402 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
403
404         [iOS] Software keyboard is shown too frequently on some websites
405         https://bugs.webkit.org/show_bug.cgi?id=195856
406         <rdar://problem/49191395>
407
408         Reviewed by Darin Adler.
409
410         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
411
412         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
413         (WTR::UIScriptController::setHardwareKeyboardAttached):
414         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
415         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
416         (WTR::UIScriptController::setHardwareKeyboardAttached):
417         * TestRunnerShared/UIScriptContext/UIScriptController.h:
418         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
419
420         Additionally link against GraphicsServices in WebKitTestRunner.
421
422         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
423         (WTR::TestController::platformResetStateToConsistentValues):
424         (WTR::UIScriptController::setHardwareKeyboardAttached):
425
426 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
427
428         [GTK][WPE] Fix pacman install-dependencies packages
429         https://bugs.webkit.org/show_bug.cgi?id=196817
430
431         Reviewed by Žan Doberšek.
432         
433         python3-setuptools is called python-setuptools
434         ruby-highline is only available on AUR
435         libv4l-devel is incorporated in v4l-utils
436
437         * gtk/install-dependencies:
438         * wpe/install-dependencies:
439
440 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
441
442         [GTK] REGRESSION(r243860): Many tests failing
443         https://bugs.webkit.org/show_bug.cgi?id=196791
444
445         Reviewed by Joanmarie Diggs.
446
447         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
448         multiple documents and check that accessibility hierarchy is updated after a navigation.
449
450         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
451         (loadChangedCallback):
452         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
453         (AccessibilityTest::AccessibilityTest):
454         (AccessibilityTest::~AccessibilityTest):
455         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
456         (AccessibilityTest::findTestServerApplication):
457         (AccessibilityTest::findDocumentWeb):
458         (AccessibilityTest::findRootObject):
459         (AccessibilityTest::waitUntilChildrenRemoved):
460         (AccessibilityTest::ensureProxy):
461         (testAtspiBasicHierarchy):
462         (beforeAll):
463         (afterAll):
464
465 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-build] Handle bug titles with unicode characters
468         https://bugs.webkit.org/show_bug.cgi?id=196802
469
470         Reviewed by Dewei Zhu.
471
472         * BuildSlaveSupport/ews-build/steps.py:
473         (ValidatePatch._is_bug_closed):
474
475 2019-04-11  Michael Saboff  <msaboff@apple.com>
476
477         Improve the Inline Cache Stats code
478         https://bugs.webkit.org/show_bug.cgi?id=196836
479
480         Reviewed by Saam Barati.
481
482         Added a new script to consolidate and arrange the output of --useICStats option.
483
484         This script merges the output from every group into one large table and sorts it from most common to
485         least common.  It also counts the slow path GetById and PutById variants and then calculates the
486         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
487         Put together, this is useful to see what property accesses are not getting cached.
488
489         * Scripts/ic-stats.py: Added.
490         (ICStats):
491         (ICStats.__init__):
492         (ICStats.parse):
493         (ICStats.dumpStats):
494         (usage):
495
496 2019-04-10  Alex Christensen  <achristensen@webkit.org>
497
498         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
499         https://bugs.webkit.org/show_bug.cgi?id=196809
500         <rdar://49800762>
501
502         Reviewed by Brady Eidson.
503
504         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
505         (TEST):
506
507 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
508
509         requestAnimationFrame should execute before the next frame
510         https://bugs.webkit.org/show_bug.cgi?id=177484
511
512         Reviewed by Simon Fraser.
513
514         Add trace points for the page RenderingUpdate.
515
516         * Tracing/SystemTracePoints.plist:
517
518 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
519
520         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
521         https://bugs.webkit.org/show_bug.cgi?id=196760
522
523         Reviewed by Don Olmstead.
524
525         vswhere.exe has been bundled since Visual Studio 2017 version
526         15.2. We shouldn't download vswhere.exe.
527
528         * Scripts/build-jsc: Do not call update-vswhere.py.
529         * Scripts/build-webkit: Ditto.
530         * Scripts/update-vswhere.py: Removed.
531         * Scripts/webkitdirs.pm:
532         (requireModulesForVSWhere): Deleted.
533         (pickCurrentVisualStudioInstallation): Deleted.
534         (visualStudioInstallDirVSWhere): Return the latest installed VS
535         installation path by using the bundled vswhere.exe.
536         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
537         (visualStudioInstallDirFallback): Removed.
538
539 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
540
541         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
542         https://bugs.webkit.org/show_bug.cgi?id=196780
543
544         Reviewed by Alexey Proskuryakov.
545
546         * BuildSlaveSupport/ews-build/steps.py:
547         * BuildSlaveSupport/ews-build/steps_unittest.py:
548
549 2019-04-10  Alex Christensen  <achristensen@webkit.org>
550
551         Add SPI WKNavigationResponse._downloadAttribute
552         https://bugs.webkit.org/show_bug.cgi?id=196755
553         <rdar://49587365>
554
555         Reviewed by Brady Eidson.
556
557         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
558         (-[NavigationResponseTestDelegate navigationResponse]):
559         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
560         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
561         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
562         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
563         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
564         (readRequest):
565         (writeResponse):
566         (TEST):
567
568 2019-04-10  Tim Horton  <timothy_horton@apple.com>
569
570         Add modern API for overriding the page's specified viewport configuration
571         https://bugs.webkit.org/show_bug.cgi?id=167734
572         <rdar://problem/30331795>
573
574         Reviewed by Simon Fraser.
575
576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
577         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
578
579 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
580
581         Add support for incremental bytecode cache updates
582         https://bugs.webkit.org/show_bug.cgi?id=195000
583
584         Reviewed by Filip Pizlo.
585
586         Exit when the initial run to generate bytecode fails.
587
588         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
589
590 2019-04-10  Alex Christensen  <achristensen@webkit.org>
591
592         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
593         https://bugs.webkit.org/show_bug.cgi?id=196744
594         <rdar://49415309>
595
596         Reviewed by Chris Dumez.
597
598         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
599         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
600
601 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
602
603         Add a way to opt into modern compatibility mode in layout tests
604         https://bugs.webkit.org/show_bug.cgi?id=196770
605         <rdar://problem/49777550>
606
607         Reviewed by Antoine Quint.
608
609         Add a new test option to enable modern compatibility mode in layout tests.
610
611         * WebKitTestRunner/TestController.cpp:
612         (WTR::updateTestOptionsFromTestHeader):
613         * WebKitTestRunner/TestController.h:
614         * WebKitTestRunner/TestOptions.h:
615         (WTR::TestOptions::hasSameInitializationOptions const):
616         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
617         (WTR::TestController::platformCreateWebView):
618         (WTR::TestController::enableModernCompatibilityMode):
619
620 2019-04-10  Andy Estes  <aestes@apple.com>
621
622         Try to fix the 32-bit watchOS build.
623
624         * TestWebKitAPI/cocoa/TestWKWebView.mm:
625         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
626
627 2019-04-10  Antoine Quint  <graouts@apple.com>
628
629         Enable Pointer Events on watchOS
630         https://bugs.webkit.org/show_bug.cgi?id=196771
631         <rdar://problem/49040909>
632
633         Reviewed by Dean Jackson.
634
635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
636
637 2019-04-10  Philippe Normand  <pnormand@igalia.com>
638
639         Unreviewed. Fix WPE accessibility tests after r244059.
640
641         We are failing to load the injected bundle due to undefined symbol
642         AccessibilityUIElement::replaceTextInRange().
643
644         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
645         (WTR::AccessibilityUIElement::replaceTextInRange):
646
647 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
648
649         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
650         https://bugs.webkit.org/show_bug.cgi?id=196727
651
652         Reviewed by Fujii Hironori.
653
654         * MiniBrowser/win/WebKitBrowserWindow.cpp:
655         (WebKitBrowserWindow::create):
656
657 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
658
659         [ews-build] Add unit tests for PrintConfiguration
660         https://bugs.webkit.org/show_bug.cgi?id=196752
661
662         Reviewed by Dewei Zhu.
663
664         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
665
666 2019-04-09  Keith Rollin  <krollin@apple.com>
667
668         Unreviewed build maintenance -- update .xcfilelists.
669
670         * DumpRenderTree/DerivedSources-input.xcfilelist:
671         * DumpRenderTree/DerivedSources-output.xcfilelist:
672
673 2019-04-09  Zalan Bujtas  <zalan@apple.com>
674
675         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
676         https://bugs.webkit.org/show_bug.cgi?id=196743
677         <rdar://problem/43897551>
678
679         Reviewed by Tim Horton.
680
681         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
682         (TEST):
683
684 2019-04-09  Youenn Fablet  <youenn@apple.com>
685
686         Close service worker database on network process suspension
687         https://bugs.webkit.org/show_bug.cgi?id=196623
688         <rdar://problem/48930869>
689
690         Reviewed by Alex Christensen.
691
692         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
693
694 2019-04-09  Daniel Bates  <dabates@apple.com>
695
696         [iPad] Should open popover when the spacebar is pressed
697         https://bugs.webkit.org/show_bug.cgi?id=196360
698         <rdar://problem/49389129>
699
700         Reviewed by Brent Fulgham.
701
702         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
703
704         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
705         (WTR::UIScriptController::isShowingPopover const): Added.
706         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
707         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
708         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
709         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
710         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
711         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
712         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
713         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
714         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
715         (WTR::UIScriptController::isShowingPopover const): Added.
716         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
717         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
718         * TestRunnerShared/UIScriptContext/UIScriptController.h:
719         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
720         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
721         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
722         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
723         (-[TestRunnerWKWebView _willPresentPopover]): Added.
724         (-[TestRunnerWKWebView _didDismissPopover]): Added.
725         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
726         (WTR::UIScriptController::isShowingPopover const): Added.
727         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
728         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
729
730 2019-04-09  Alex Christensen  <achristensen@webkit.org>
731
732         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
733         https://bugs.webkit.org/show_bug.cgi?id=196665
734         <rdar://45115669>
735
736         Reviewed by Geoff Garen.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
739         (goBack):
740         (+[SimpleLookupContext sharedLookupContext]):
741         (-[SimpleLookupContext lookUpURL:completionHandler:]):
742         (TEST):
743         (+[Simple3LookupContext sharedLookupContext]): Deleted.
744         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
745
746 2019-04-09  John Wilander  <wilander@apple.com>
747
748         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
749         https://bugs.webkit.org/show_bug.cgi?id=196558
750         <rdar://problem/47650245>
751
752         Reviewed by Youenn Fablet.
753
754         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
755         (TestWebKitAPI::TEST):
756             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
757
758 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
759
760         [CMake] Apple builds should use ICU_INCLUDE_DIRS
761         https://bugs.webkit.org/show_bug.cgi?id=196720
762
763         Reviewed by Konstantin Tokarev.
764
765         * TestWebKitAPI/PlatformMac.cmake:
766
767 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
768
769         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
770         https://bugs.webkit.org/show_bug.cgi?id=196694
771         <rdar://problem/48388734>
772
773         Rubber-stamped by Aakash Jain.
774
775         * Scripts/webkitpy/port/image_diff.py:
776         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
777         * Scripts/webkitpy/port/server_process.py:
778         (ServerProcess.has_available_stdout): Check if stdout has data in it.
779         (ServerProcess._wait_for_data_and_update_buffers_using_select):
780         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
781         * Scripts/webkitpy/port/server_process_mock.py:
782         (MockServerProcess.has_available_stdout):
783         * Scripts/webkitpy/port/server_process_unittest.py:
784         (TestServerProcess.serial_test_basic):
785
786 2019-04-09  Jer Noble  <jer.noble@apple.com>
787
788         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
789         https://bugs.webkit.org/show_bug.cgi?id=196097
790
791         Reviewed by Eric Carlson.
792
793         Drive-by bug fix: allow tests to play audio without a user gesture by default.
794
795         * DumpRenderTree/mac/DumpRenderTree.mm:
796         (resetWebPreferencesToConsistentValues):
797         * WebKitTestRunner/TestController.cpp:
798         (WTR::TestController::resetPreferencesToConsistentValues):
799
800 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
801
802         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
803         https://bugs.webkit.org/show_bug.cgi?id=196690
804
805         Reviewed by Michael Catanzaro.
806
807         * QueueStatusServer/config/queues.py:
808         * Scripts/webkitpy/common/config/ews.json:
809         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
810         (test_ews_name):
811
812 2019-04-09  Chris Dumez  <cdumez@apple.com>
813
814         Loads using loadHTMLString() cause flashing when process-swapping
815         https://bugs.webkit.org/show_bug.cgi?id=196714
816         <rdar://problem/49637354>
817
818         Reviewed by Antti Koivisto.
819
820         Add API test coverage.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823
824 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
825
826         Unreviewed. Fix ATK accessibility tests after r244059.
827
828         We are failing to load the injected bundle due to undefined symbol
829         AccessibilityUIElement::replaceTextInRange().
830
831         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
832         (WTR::AccessibilityUIElement::replaceTextInRange):
833
834 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
835
836         AX: Support API: accessibilityReplaceRange:withText
837         https://bugs.webkit.org/show_bug.cgi?id=196636
838
839         Unreviewed build fix for Windows port.
840
841         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
842         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
843
844 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
845
846         [CMake][WinCairo] Separate copied headers into different directories
847         https://bugs.webkit.org/show_bug.cgi?id=196655
848
849         Reviewed by Michael Catanzaro.
850
851         * DumpRenderTree/CMakeLists.txt:
852         * MiniBrowser/win/CMakeLists.txt:
853         * TestWebKitAPI/CMakeLists.txt:
854         * TestWebKitAPI/PlatformWin.cmake:
855
856 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
857
858         Log stack-trace for run-webkit-tests when interrupted
859         https://bugs.webkit.org/show_bug.cgi?id=176393
860         <rdar://problem/34262310>
861
862         Reviewed by Lucas Forschler.
863
864         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
865         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
866         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
867         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
868         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
870         (main): Set handlers to log stack trace on interruption.
871
872 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
873
874         AX: Support API: accessibilityReplaceRange:withText
875         https://bugs.webkit.org/show_bug.cgi?id=196636
876
877         Unreviewed build fix for Windows port.
878
879         * DumpRenderTree/AccessibilityUIElement.cpp:
880         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
881
882 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
883
884         [ews-build] Scripts using Buildbot API have CORS error
885         https://bugs.webkit.org/show_bug.cgi?id=196709
886
887         Reviewed by Alexey Proskuryakov.
888
889         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
890
891 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
892
893         AX: Support API: accessibilityReplaceRange:withText
894         https://bugs.webkit.org/show_bug.cgi?id=196636
895
896         Reviewed by Daniel Bates.
897
898         * DumpRenderTree/AccessibilityUIElement.cpp:
899         (replaceTextInRangeCallback):
900         (AccessibilityUIElement::replaceTextInRange):
901         (AccessibilityUIElement::getJSClass):
902         * DumpRenderTree/AccessibilityUIElement.h:
903         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
904         (AccessibilityUIElement::replaceTextInRange):
905         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
906         (AccessibilityUIElement::replaceTextInRange):
907         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
908         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
909         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
910         (WTR::AccessibilityUIElement::replaceTextInRange):
911         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
912         (WTR::AccessibilityUIElement::replaceTextInRange):
913
914 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
915
916         [iOS] Do not allow starting selection drags when selection views are not visible
917         https://bugs.webkit.org/show_bug.cgi?id=196686
918         <rdar://problem/49399192>
919
920         Reviewed by Tim Horton.
921
922         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
923         also add some new API tests to cover scenarios where the web view is not first responder.
924
925         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
928
929         Add a switch to optionally make the web view first responder when starting the simulated drag.
930
931         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
932         (-[DragAndDropSimulator initWithWebView:]):
933         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
934
935 2019-04-08  Justin Fan  <justin_fan@apple.com>
936
937         [Web GPU] Fix Web GPU experimental feature on iOS
938         https://bugs.webkit.org/show_bug.cgi?id=196632
939
940         Reviewed by Myles C. Maxfield.
941
942         Properly make Web GPU available on iOS 11+.
943
944         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
945
946 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
947
948         [ews-build] Do not upload archive when Compile Fails
949         https://bugs.webkit.org/show_bug.cgi?id=196674
950
951         Reviewed by Alexey Proskuryakov.
952
953         * BuildSlaveSupport/ews-build/factories.py:
954         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
955         * BuildSlaveSupport/ews-build/steps.py:
956         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
957         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
958         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
959
960 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
961
962         Enable DFG on MIPS
963         https://bugs.webkit.org/show_bug.cgi?id=196689
964
965         Reviewed by Žan Doberšek.
966
967         Since the bytecode change, we enabled the baseline JIT on mips in
968         r240432, but DFG is still missing. With this change, all tests are
969         passing on a ci20 board.
970
971         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
972
973 2019-04-08  Philippe Normand  <pnormand@igalia.com>
974
975         [Flatpak] Second run update-webkitwpe-flatpak fails
976         https://bugs.webkit.org/show_bug.cgi?id=192702
977
978         Reviewed by Carlos Garcia Campos.
979
980         * flatpak/flatpakutils.py:
981         (FlatpakObject.flatpak): Fix typo.
982         (FlatpakPackage.install): When installing, also update to the configured remote commit.
983         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
984
985 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
986
987         [GTK][WPE] outlook.live.com displays old-fashioned UI
988         https://bugs.webkit.org/show_bug.cgi?id=196642
989
990         Reviewed by Carlos Garcia Campos.
991
992         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
993         (TestWebKitAPI::TEST): New Mac platform quirk test.
994
995 2019-04-07  Commit Queue  <commit-queue@webkit.org>
996
997         Unreviewed, rolling out r243956.
998         https://bugs.webkit.org/show_bug.cgi?id=196688
999
1000         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1001         by aakashjain on #webkit).
1002
1003         Reverted changeset:
1004
1005         "Clicking "Go Back" from a safe browsing warning from an
1006         iframe should navigate the WKWebView back to the previous
1007         page"
1008         https://bugs.webkit.org/show_bug.cgi?id=196665
1009         https://trac.webkit.org/changeset/243956
1010
1011 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1012
1013         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1014         https://bugs.webkit.org/show_bug.cgi?id=196669
1015
1016         Reviewed by Geoffrey Garen.
1017
1018         Added three new unit tests for WeakHashSet.
1019
1020         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1021         (WTF_WeakPtr.WeakHashSetConstObjects):
1022         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1023         (WTF_WeakPtr.WeakHashSetComputeSize):
1024
1025 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1026
1027         Hide next and previous form control buttons when WKWebView is editable
1028         https://bugs.webkit.org/show_bug.cgi?id=196672
1029         <rdar://problem/35625321>
1030
1031         Reviewed by Tim Horton.
1032
1033         Add a new API test.
1034
1035         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1036         (-[TestWKWebView lastTrailingBarButtonGroup]):
1037         (TestWebKitAPI::TEST):
1038         * TestWebKitAPI/ios/UIKitSPI.h:
1039
1040 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1041
1042         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1043         https://bugs.webkit.org/show_bug.cgi?id=196077
1044         <rdar://problem/49108202>
1045
1046         Reviewed by Chris Dumez.
1047
1048         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1049         on new web view.
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1052
1053 2019-04-05  Saam Barati  <sbarati@apple.com>
1054
1055         Make compare-results understand MotionMark
1056         https://bugs.webkit.org/show_bug.cgi?id=196666
1057
1058         Reviewed by Yusuke Suzuki.
1059
1060         * Scripts/compare-results:
1061         (PLT5Results):
1062         (detectMotionMark):
1063         (detectMotionMark1_1):
1064         (motionMarkResults):
1065         (motionMark1_1Results):
1066         (detectBenchmark):
1067         (biggerIsBetter):
1068         (main):
1069
1070 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1071
1072         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1073         https://bugs.webkit.org/show_bug.cgi?id=196665
1074         <rdar://45115669>
1075
1076         Reviewed by Geoff Garen.
1077
1078         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1079         (goBack):
1080         (+[SimpleLookupContext sharedLookupContext]):
1081         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1082         (TEST):
1083         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1084         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1085
1086 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-build] Add configuration and architecture for windows builders
1089         https://bugs.webkit.org/show_bug.cgi?id=196660
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-build/config.json:
1094
1095 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1096
1097         webkitpy: Don't run subsequent rounds if interrupted
1098         https://bugs.webkit.org/show_bug.cgi?id=196646
1099
1100         Reviewed by Aakash Jain.
1101
1102         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1103         (Manager.run): Bail out if interrupted.
1104
1105 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1106
1107         Test sessionStorage in PSON private browsing mode
1108         https://bugs.webkit.org/show_bug.cgi?id=196561
1109
1110         Reviewed by Alex Christensen.
1111
1112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1113
1114 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1115
1116         Unreviewed, rolling out r243833.
1117         https://bugs.webkit.org/show_bug.cgi?id=196645
1118
1119         This change breaks build of WPE and GTK ports (Requested by
1120         annulen on #webkit).
1121
1122         Reverted changeset:
1123
1124         "[CMake][WTF] Mirror XCode header directories"
1125         https://bugs.webkit.org/show_bug.cgi?id=191662
1126         https://trac.webkit.org/changeset/243833
1127
1128 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1129
1130         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1131         https://bugs.webkit.org/show_bug.cgi?id=196635
1132
1133         Reviewed by Antti Koivisto.
1134         
1135         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1136         for a test to enable async frame scrolling via:
1137             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1138         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1139         
1140         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1141
1142         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1143         (WTR::InjectedBundle::beginTesting):
1144         * WebKitTestRunner/TestController.cpp:
1145         (WTR::TestController::resetPreferencesToConsistentValues):
1146
1147 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1148
1149         Use a correct LC_RPATH when building with ASan
1150         https://bugs.webkit.org/show_bug.cgi?id=196576
1151
1152         Reviewed by David Kilzer.
1153
1154         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1155         so that ../Frameworks is checked. This is simpler and more reliable than updating
1156         each SPC service xcconfig.
1157
1158 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1159
1160         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1161         https://bugs.webkit.org/show_bug.cgi?id=196629
1162
1163         Reviewed by Lucas Forschler.
1164
1165         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1166
1167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1168
1169         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1170         https://bugs.webkit.org/show_bug.cgi?id=196618
1171
1172         Reviewed by Lucas Forschler.
1173
1174         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1175         (StatusBubble): Added QUEUE_TRIGGERS.
1176         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1177         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1178         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1179         its parent(builder).
1180
1181 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1182
1183         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1184         https://bugs.webkit.org/show_bug.cgi?id=196625
1185
1186         Reviewed by Lucas Forschler.
1187
1188         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1189         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1190
1191 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1192
1193         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1194         https://bugs.webkit.org/show_bug.cgi?id=196630
1195
1196         Reviewed by Wenson Hsieh.
1197
1198         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1199
1200 2019-04-04  Youenn Fablet  <youenn@apple.com>
1201
1202         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1203         https://bugs.webkit.org/show_bug.cgi?id=196543
1204
1205         Reviewed by Alex Christensen.
1206
1207         * WebKitTestRunner/TestController.cpp:
1208         (WTR::TestController::generatePageConfiguration):
1209
1210 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-app] Status bubble should not display skipped buildbot steps
1213         https://bugs.webkit.org/show_bug.cgi?id=196584
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1218
1219 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1220
1221         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1222         https://bugs.webkit.org/show_bug.cgi?id=196620
1223
1224         Reviewed by Lucas Forschler.
1225
1226         * BuildSlaveSupport/ews-app/ews/config.py:
1227
1228 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1229
1230         [Win] DumpRenderTreeWatchDog.py is not checked into source
1231         https://bugs.webkit.org/show_bug.cgi?id=196567
1232         <rdar://problem/49525901>
1233
1234         Reviewed by Lucas Forschler.
1235
1236         This script is used on Win EWS bots to terminate hanging DRT processes.
1237
1238         * EWSTools/dumprendertreewatchdog.py: Added.
1239
1240 2019-04-04  Chris Dumez  <cdumez@apple.com>
1241
1242         Unreviewed, roll out r243858 which made tests time out.
1243
1244         Disable new API tests on Windows instead.
1245
1246         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1247         (TestWebKitAPI::TEST):
1248
1249 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1250
1251         [ATK] Cleanup WebPageAccessibilityObjectAtk
1252         https://bugs.webkit.org/show_bug.cgi?id=196537
1253
1254         Reviewed by Michael Catanzaro.
1255
1256         Also consider files under atk directories as exceptions for GObject conventions.
1257
1258         * Scripts/webkitpy/style/checkers/cpp.py:
1259         (check_identifier_name_in_declaration):
1260
1261 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1262
1263         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1264         https://bugs.webkit.org/show_bug.cgi?id=196588
1265         <rdar://problem/49365787>
1266
1267         Unreviewed build fix for Windows port.
1268
1269         error C3861: 'kill': identifier not found
1270
1271         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1272         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1273
1274 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1275
1276         [ews-build] Cancel build and similar operations should have authentication
1277         https://bugs.webkit.org/show_bug.cgi?id=196520
1278
1279         Reviewed by Dewei Zhu.
1280
1281         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1282         environment variables.
1283
1284 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-build] Do not trigger queues which are not in production yet
1287         https://bugs.webkit.org/show_bug.cgi?id=196581
1288
1289         Reviewed by Dewei Zhu.
1290
1291         * BuildSlaveSupport/ews-build/config.json:
1292
1293 2019-04-03  Chris Dumez  <cdumez@apple.com>
1294
1295         Unreviewed, fix typo in the name of API test added in r243848.
1296
1297         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1298         (TestWebKitAPI::TEST):
1299
1300 2019-04-03  Chris Dumez  <cdumez@apple.com>
1301
1302         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1303         https://bugs.webkit.org/show_bug.cgi?id=196588
1304         <rdar://problem/49365787>
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         Add API test coverage.
1309
1310         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1311         (TestWebKitAPI::nullJavaScriptCallback):
1312         (TestWebKitAPI::didCrashCheckFrames):
1313         (TestWebKitAPI::TEST):
1314
1315 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1316
1317         run-webkit-tests: Upload test results (new results database)
1318         https://bugs.webkit.org/show_bug.cgi?id=196577
1319         <rdar://problem/34841155>
1320
1321         Reviewed by Lucas Forschler.
1322
1323         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1324         (Manager.run): Upload results after each device shard, since the configuration will be
1325         different for each device.
1326         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1327         uploaded to a results database.
1328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1329         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1330
1331 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1332
1333         -apple-trailing-word is needed for browser detection
1334         https://bugs.webkit.org/show_bug.cgi?id=196575
1335
1336         Unreviewed.
1337
1338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1339
1340 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1341
1342         [CMake][WTF] Mirror XCode header directories
1343         https://bugs.webkit.org/show_bug.cgi?id=191662
1344
1345         Reviewed by Konstantin Tokarev.
1346
1347         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1348         builds.
1349
1350         * CMakeLists.txt:
1351         * DumpRenderTree/CMakeLists.txt:
1352         * DumpRenderTree/PlatformWin.cmake:
1353         * MiniBrowser/win/CMakeLists.txt:
1354         * TestWebKitAPI/CMakeLists.txt:
1355         * TestWebKitAPI/PlatformWin.cmake:
1356         * WebKitTestRunner/PlatformGTK.cmake:
1357         * WebKitTestRunner/PlatformWin.cmake:
1358
1359 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1360
1361         [ews-app] Status bubble should not display certain infrastructure status messages
1362         https://bugs.webkit.org/show_bug.cgi?id=196550
1363
1364         Reviewed by Lucas Forschler.
1365
1366         Do not display the steps which are un-needed for end-user. This information is still avaiable
1367         if the user click on the bubble and look at the Buildbot build.
1368         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1369         (StatusBubble._steps_messages):
1370         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1371
1372 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1373
1374         [ews-build] Use https for sending data to ews-app
1375         https://bugs.webkit.org/show_bug.cgi?id=196492
1376
1377         Reviewed by Lucas Forschler.
1378
1379         * BuildSlaveSupport/ews-build/events.py:
1380
1381 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1382
1383         Remove support for -apple-trailing-word
1384         https://bugs.webkit.org/show_bug.cgi?id=196525
1385
1386         Reviewed by Zalan Bujtas.
1387
1388         This CSS property is nonstandard and not used.
1389
1390         * Scripts/webkitperl/FeatureList.pm:
1391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1392
1393 2019-04-03  Youenn Fablet  <youenn@apple.com>
1394
1395         Add a test for DOMCache on multiple browsing in case of private browsing
1396         https://bugs.webkit.org/show_bug.cgi?id=196524
1397
1398         Reviewed by Alex Christensen.
1399
1400         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1401         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1402
1403 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1404
1405         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1406         https://bugs.webkit.org/show_bug.cgi?id=196540
1407
1408         Reviewed by Aakash Jain.
1409
1410         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1411
1412 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1413
1414         Add plumbing for a compatibility mode preference in WebKit
1415         https://bugs.webkit.org/show_bug.cgi?id=196005
1416
1417         Reviewed by Tim Horton.
1418
1419         Add new API tests.
1420
1421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1422         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1423
1424 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1425
1426         [WPE][GTK] Update libsrtp dependency package for Debian
1427         https://bugs.webkit.org/show_bug.cgi?id=196528
1428
1429         Reviewed by Frédéric Wang.
1430
1431         * gtk/install-dependencies:
1432         * wpe/install-dependencies:
1433
1434 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1435
1436         [WK2] Add support for Window's beforeprint / afterprint events
1437         https://bugs.webkit.org/show_bug.cgi?id=196478
1438         <rdar://problem/49535124>
1439
1440         Unreviewed build fix for MSVC.
1441
1442         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1443
1444         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1445
1446         * WebKitTestRunner/TestController.cpp:
1447         (WTR::printFrame): Use int and float literals.
1448
1449 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1450
1451         [ews-build] Reassign bots to queues
1452
1453         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1454
1455 2019-04-02  Chris Dumez  <cdumez@apple.com>
1456
1457         [WK2] Add support for Window's beforeprint / afterprint events
1458         https://bugs.webkit.org/show_bug.cgi?id=196478
1459
1460         Reviewed by Alex Christensen.
1461
1462         Add minimal implementation for printFrame in WebKitTestRunner.
1463
1464         * WebKitTestRunner/TestController.cpp:
1465         (WTR::printFrame):
1466         (WTR::TestController::createOtherPage):
1467         (WTR::TestController::createWebViewWithOptions):
1468
1469 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1470
1471         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1472         https://bugs.webkit.org/show_bug.cgi?id=196491
1473
1474         Reviewed by Lucas Forschler.
1475
1476         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1477
1478 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-build] Configure buildbot try credentials in environment variables
1481         https://bugs.webkit.org/show_bug.cgi?id=196501
1482
1483         Reviewed by Lucas Forschler.
1484
1485         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1486         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1487         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1488
1489 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1490
1491         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1492         https://bugs.webkit.org/show_bug.cgi?id=196496
1493         <rdar://problem/49521634>
1494
1495         Reviewed by Chris Dumez.
1496
1497         Add new API tests (see WebKit ChangeLog for more detail).
1498
1499         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1500         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1501         (TEST):
1502
1503 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1504
1505         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1506         <https://webkit.org/b/196499>
1507
1508         Reviewed by Alexey Proskuryakov.
1509
1510         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1511         ENABLE_ADDRESS_SANITIZER.
1512
1513 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1514
1515         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1516         https://bugs.webkit.org/show_bug.cgi?id=182757
1517
1518         Reviewed by Don Olmstead.
1519
1520         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1521         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1522
1523 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1524
1525         run-api-tests: Upload test results
1526         https://bugs.webkit.org/show_bug.cgi?id=196323
1527         <rdar://problem/49356714>
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * Scripts/webkitpy/api_tests/manager.py:
1532         (Manager):
1533         (Manager.run): Upload results to a results database.
1534         * Scripts/webkitpy/api_tests/run_api_tests.py:
1535         (parse_args): Add upload arguments.
1536         * Scripts/webkitpy/port/base.py:
1537         (Port):
1538         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1539         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1540         with commits from any other associated repositories.
1541         * Scripts/webkitpy/port/device.py:
1542         (Device):
1543         (Device.build_version): Access build_versoin of underlying platform device.
1544         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1545         (IOSSimulatorTest):
1546         (IOSSimulatorTest.test_configuration_for_upload):
1547         * Scripts/webkitpy/port/device_port.py:
1548         (DevicePort):
1549         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1550         the same as the machine uploading results.
1551         * Scripts/webkitpy/port/mac.py:
1552         (MacPort):
1553         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1554         * Scripts/webkitpy/port/mac_unittest.py:
1555         (MacTest):
1556         (MacTest.test_configuration_for_upload):
1557         * Scripts/webkitpy/xcode/simulated_device.py:
1558         (SimulatedDeviceManager._create_device_with_runtime):
1559         (SimulatedDevice.__init__): Create simulated device with a build_version.
1560         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1561         (test_existing_simulator):
1562
1563 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1564
1565         Remove extra newline characters (Follow-up fix to r243707)
1566
1567         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1568
1569 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1570
1571         [ews-app] Use API_KEY to accept results data
1572         https://bugs.webkit.org/show_bug.cgi?id=196461
1573
1574         Reviewed by Dewei Zhu.
1575
1576         * BuildSlaveSupport/ews-app/ews/views/results.py:
1577         (Results.post): Validate EWS_API_KEY before accepting any data.
1578         * BuildSlaveSupport/ews-build/events.py:
1579         (Events.sendData): Send EWS_API_KEY if available along with event data.
1580
1581 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1582
1583         Unable to copy and paste a PDF from Notes into Mail compose body
1584         https://bugs.webkit.org/show_bug.cgi?id=196442
1585         <rdar://problem/48573098>
1586
1587         Reviewed by Tim Horton.
1588
1589         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1590         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1591         to be specified on the item providers.
1592
1593         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1594         (TestWebKitAPI::mapItemForTesting):
1595         (TestWebKitAPI::contactItemForTesting):
1596
1597 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1598
1599         Make UIWKDocumentContext rects per-character instead of per-word
1600         https://bugs.webkit.org/show_bug.cgi?id=196459
1601
1602         Reviewed by Wenson Hsieh.
1603
1604         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1605         (TEST):
1606         Adjust test results due to switching to per-character rects.
1607
1608 2019-04-01  Chris Dumez  <cdumez@apple.com>
1609
1610         UIProcess crash when a prewarmed process is terminated
1611         https://bugs.webkit.org/show_bug.cgi?id=196451
1612         <rdar://problem/49245471>
1613
1614         Reviewed by Geoffrey Garen.
1615
1616         Add API test coverage.
1617
1618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1619         (TEST):
1620
1621 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1622
1623         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1624         https://bugs.webkit.org/show_bug.cgi?id=196449
1625
1626         Reviewed by Lucas Forschler.
1627
1628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1629         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1630         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1631         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1632
1633 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1634
1635         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1636         https://bugs.webkit.org/show_bug.cgi?id=196444
1637
1638         Reviewed by Lucas Forschler.
1639
1640         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1641
1642 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1643
1644         Add SPI to canonicalize NSURLs with WTF::URL
1645         https://bugs.webkit.org/show_bug.cgi?id=196415
1646         <rdar://problem/44980271>
1647
1648         Reviewed by Darin Adler.
1649
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1652         (TestWebKitAPI::TEST):
1653
1654 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1655
1656         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1657         https://bugs.webkit.org/show_bug.cgi?id=196441
1658
1659         Reviewed by Carlos Garcia Campos.
1660
1661         Don't cache the wpe_view_backend object that might not exist yet at the
1662         time of EventSenderProxy constructor invocation, but instead retrieve
1663         that object whenever it's required for event dispatching. This should
1664         avoid crashes in this constructor now that it's invoked before any
1665         PlatformWindow has been set up (as changed in r243496).
1666
1667         * WebKitTestRunner/EventSenderProxy.h:
1668         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1669         (WTR::viewBackend):
1670         (WTR::EventSenderProxy::EventSenderProxy):
1671         (WTR::EventSenderProxy::mouseDown):
1672         (WTR::EventSenderProxy::mouseUp):
1673         (WTR::EventSenderProxy::mouseMoveTo):
1674         (WTR::EventSenderProxy::mouseScrollBy):
1675         (WTR::EventSenderProxy::keyDown):
1676         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1677
1678 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1679
1680         [Win][WebKit] MiniBrowser should support high DPI display
1681         https://bugs.webkit.org/show_bug.cgi?id=196391
1682
1683         Reviewed by Alex Christensen.
1684
1685         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1686         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1687         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1688         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1689
1690 2019-03-31  Sam Weinig  <weinig@apple.com>
1691
1692         Remove more i386 specific configurations
1693         https://bugs.webkit.org/show_bug.cgi?id=196430
1694
1695         Reviewed by Alexey Proskuryakov.
1696
1697         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1698         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1699
1700 2019-03-31  Andy Estes  <aestes@apple.com>
1701
1702         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1703         https://bugs.webkit.org/show_bug.cgi?id=196433
1704         <rdar://problem/49293305>
1705
1706         Reviewed by Tim Horton.
1707
1708         Enhanced API test coverage to include all navigation response policy decisions in both
1709         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1710
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1713         (TestWebKitAPI::TEST):
1714         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1715         (readFile):
1716         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1717         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1718         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1719         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1720         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1721         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1722         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1723         (-[QuickLookDelegate _downloadDidStart:]):
1724         (-[QuickLookDelegate _download:didReceiveResponse:]):
1725         (-[QuickLookDelegate _download:didReceiveData:]):
1726         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1727         (-[QuickLookDelegate _downloadDidFinish:]):
1728         (-[QuickLookDelegate _download:didFailWithError:]):
1729         (-[QuickLookDelegate _downloadDidCancel:]):
1730         (-[QuickLookDelegate verifyDownload]):
1731         (runTest):
1732         (runTestDecideBeforeLoading):
1733         (runTestDecideAfterLoading):
1734         (TEST):
1735         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1736         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1737         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1738         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1739         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1740         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1741         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1742         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1743         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1744         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1745         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1746         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1747         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1748         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1749
1750 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1751
1752         [CMake] add testdfg as target with build-jsc
1753         https://bugs.webkit.org/show_bug.cgi?id=196393
1754
1755         Reviewed by Saam Barati.
1756
1757         Added testdfg as one of the targets to build when
1758         using CMake.
1759
1760         * Scripts/build-jsc:
1761
1762 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1763
1764         Delete WebMetal implementation in favor of WebGPU
1765         https://bugs.webkit.org/show_bug.cgi?id=195418
1766
1767         Reviewed by Dean Jackson.
1768
1769         * DumpRenderTree/mac/DumpRenderTree.mm:
1770         (enableExperimentalFeatures):
1771         (resetWebPreferencesToConsistentValues):
1772         * Scripts/webkitperl/FeatureList.pm:
1773         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1775         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1776         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1777         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1778         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1779         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1780         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1781         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1782         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1783         (WTR::InjectedBundle::beginTesting):
1784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1785         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1786         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1787
1788 2019-03-29  Chris Dumez  <cdumez@apple.com>
1789
1790         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1791         https://bugs.webkit.org/show_bug.cgi?id=196405
1792         <rdar://problem/49428130>
1793
1794         Reviewed by Wenson Hsieh.
1795
1796         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1797         the popover presentation methods to be no-ops. Use this in the new test added in
1798         r243523 so that we do not swizzle those methods for all tests. This is needed because
1799         those WatchOS tests rely on the popover getting presented and interactive.
1800
1801         * WebKitTestRunner/TestController.cpp:
1802         (WTR::updateTestOptionsFromTestHeader):
1803         * WebKitTestRunner/TestController.h:
1804         * WebKitTestRunner/TestOptions.h:
1805         (WTR::TestOptions::hasSameInitializationOptions const):
1806         * WebKitTestRunner/ios/TestControllerIOS.mm:
1807         (WTR::TestController::platformInitialize):
1808         (WTR::TestController::platformResetStateToConsistentValues):
1809
1810 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1811
1812         [Curl] Add Server Trust Evaluation Support.
1813         https://bugs.webkit.org/show_bug.cgi?id=191646
1814
1815         Reviewed by Fujii Hironori.
1816
1817         Implemented MiniBrowser UI for asking if user trusts the server.
1818
1819         * MiniBrowser/win/Common.cpp:
1820         (askServerTrustEvaluation):
1821         (replaceString):
1822         * MiniBrowser/win/Common.h:
1823         * MiniBrowser/win/MiniBrowserLib.rc:
1824         * MiniBrowser/win/MiniBrowserLibResource.h:
1825         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1826         (createPEMString):
1827         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1828         (WebKitBrowserWindow::canTrustServerCertificate):
1829         * MiniBrowser/win/WebKitBrowserWindow.h:
1830
1831 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1832
1833         Implement ResizeObserver.
1834         https://bugs.webkit.org/show_bug.cgi?id=157743
1835
1836         Reviewed by Simon Fraser.
1837
1838         Support resizeObserverEnabled webPreferences.
1839
1840         * DumpRenderTree/TestOptions.cpp:
1841         (TestOptions::TestOptions):
1842         * DumpRenderTree/TestOptions.h:
1843         * DumpRenderTree/mac/DumpRenderTree.mm:
1844         (setWebPreferencesForTestOptions):
1845         * DumpRenderTree/win/DumpRenderTree.cpp:
1846         (enableExperimentalFeatures):
1847         * Scripts/webkitperl/FeatureList.pm:
1848         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1849
1850 2019-03-28  John Wilander  <wilander@apple.com>
1851
1852         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1853         https://bugs.webkit.org/show_bug.cgi?id=196281
1854         <rdar://problem/48938748>
1855
1856         Reviewed by Alex Christensen.
1857
1858         This patch adds the function isStatisticsHasLocalStorage() to the
1859         TestRunner. With it, the page can query the WebsiteDataStore in the
1860         UI process to make sure that it sees LocalStorage.
1861
1862         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1864         (WTR::TestRunner::isStatisticsHasLocalStorage):
1865         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::TestController::isStatisticsHasLocalStorage):
1868         * WebKitTestRunner/TestController.h:
1869         * WebKitTestRunner/TestInvocation.cpp:
1870         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1871
1872 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1873
1874         API::Data::createWithoutCopying should do a null check before calling CFRelease
1875         https://bugs.webkit.org/show_bug.cgi?id=196276
1876         <rdar://problem/48059859>
1877
1878         Reviewed by Alex Christensen.
1879
1880         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1881
1882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1883         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1884         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1885         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1886         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1887         (TestWebKitAPI::TEST):
1888
1889 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1890
1891         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1892         https://bugs.webkit.org/show_bug.cgi?id=186276
1893
1894         Reviewed by Carlos Garcia Campos.
1895
1896         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1897         (webViewLoadChanged):
1898         (testWebResourceGetDataError):
1899         (testWebResourceGetDataEmpty):
1900         (beforeAll):
1901         (webViewloadChanged): Deleted.
1902
1903 2019-03-27  Andy Estes  <aestes@apple.com>
1904
1905         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1906         https://bugs.webkit.org/show_bug.cgi?id=196317
1907
1908         Reviewed by Dan Bernstein.
1909
1910         package-root copies built products into a staging directory using ditto(1), which does not
1911         follow symbolic links as it traverses a directory. Now that the files in
1912         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1913         itself, these become broken links when ditto'd into the staging directory.
1914
1915         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1916
1917         * Scripts/package-root:
1918
1919 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1920
1921         [ews-app] Update display text of Submit for ews analysis
1922         https://bugs.webkit.org/show_bug.cgi?id=196309
1923
1924         Reviewed by Dewei Zhu.
1925
1926         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1927
1928 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1929
1930         run-webkit-tests should check for leaks in WebKit processes
1931         <https://webkit.org/b/193772>
1932         <rdar://problem/46526680>
1933
1934         Reviewed by Ryosuke Niwa.
1935
1936         This works by doing the following:
1937         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1938           The list of child processes are returned one per line:
1939           process.name: pid
1940         - Run the "#LIST CHILD PROCESSES" command just before the
1941           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1942           processes on the ServerProcess object.
1943         - When the `--leaks` switch is handled, run check_for_leaks() on
1944           each child process after the main test harness.
1945
1946         * DumpRenderTree/mac/DumpRenderTree.mm:
1947         (handleControlCommand):
1948         - Use strncmp() instead of strcmp().
1949         - Add support for handling "#LIST CHILD PROCESSES" command.
1950
1951         * Scripts/webkitpy/port/base.py:
1952         (Port.check_for_leaks):
1953         * Scripts/webkitpy/port/darwin.py:
1954         (DarwinPort.check_for_leaks):
1955         - Rename redundant 'process_pid' argument to 'process_id'.
1956
1957         * Scripts/webkitpy/port/driver.py:
1958         (Driver.do_post_tests_work):
1959         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1960           longer the only command this sends to WebKitTestRunner.
1961         - If the `--leaks` switch is present, send the
1962           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1963           result using Port.set_webkit_processes().
1964         (Driver._parse_child_processes_output):
1965         - Add helper method to parse list of child process names and
1966           process IDs returned from WebKitTestRunner.
1967
1968         * Scripts/webkitpy/port/ios_device.py:
1969         (IOSDevicePort.check_for_leaks):
1970         - Rename redundant 'process_pid' argument to 'process_id'.
1971
1972         * Scripts/webkitpy/port/leakdetector.py:
1973         (LeakDetector._parse_leaks_output):
1974         - Return early if there is no leaks_output.
1975         (LeakDetector.check_for_leaks):
1976         - Rename redundant 'process_pid' argument to 'process_id'.
1977
1978         * Scripts/webkitpy/port/server_process.py:
1979         (ServerProcess.__init__):
1980         (ServerProcess.child_processes):
1981         (ServerProcess.set_child_processes):
1982         - Add instance variable to Port to store list of child process
1983           names and process IDs returned from WebKitTestRunner.
1984         (ServerProcess._start):
1985         - Clear self._child_processes.
1986         (ServerProcess.stop):
1987         - If self._child_processes is set, call
1988           self._port.check_for_leaks() for each child process.
1989
1990         * Scripts/webkitpy/port/server_process_unittest.py:
1991         (TrivialMockPort.check_for_leaks):
1992         - Rename redundant 'process_pid' argument to 'process_id'.
1993
1994         * Scripts/webkitpy/port/simulator_process.py:
1995         (SimulatorProcess.stop):
1996         - If self._child_processes is set, call
1997           self._port.check_for_leaks() for each child process.
1998
1999         * Scripts/webkitpy/port/watch_device.py:
2000         (WatchDevicePort.check_for_leaks):
2001         - Rename redundant 'process_pid' argument to 'process_id'.
2002
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::dumpResponse):
2005         - Extract method from findAndDumpWorldLeaks() so that it may be
2006           reused by findAndDumpWebKitProcessIdentifiers().
2007         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2008         - Add method to output process name and process ID of both the
2009           WebContent and Networking processes.
2010         (WTR::TestController::findAndDumpWorldLeaks):
2011         - Fix missing newline in output when there were no abandoned
2012           documents.
2013         - Call dumpResponse() for extracted code.
2014         (WTR::TestController::handleControlCommand):
2015         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2016         - Use strncmp() instead of strcmp().
2017         - Call findAndDumpWebKitProcessIdentifiers() when
2018           "#LIST CHILD PROCESSES" command is sent.
2019         * WebKitTestRunner/TestController.h:
2020         (WTR::TestController::dumpResponse):
2021         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2022         - Declare methods.
2023
2024 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2025
2026         Unreviewed. Add GLib API test cases after r243434.
2027
2028         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2029         (testWebViewActiveURI):
2030         (serverCallback):
2031         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2032         (sendRequestCallback):
2033
2034 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2035
2036         Geolocation request not complete when watch request was started in a different web process
2037         https://bugs.webkit.org/show_bug.cgi?id=195996
2038
2039         Reviewed by Alex Christensen.
2040
2041         Add a test case.
2042
2043         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2044         (TestWebKitAPI::runJavaScriptAlert):
2045         (TestWebKitAPI::TEST):
2046
2047 2019-03-26  Keith Rollin  <krollin@apple.com>
2048
2049         Update the way generate-xcfilelists returns strings from functions
2050         https://bugs.webkit.org/show_bug.cgi?id=195975
2051         <rdar://problem/49040807>
2052
2053         Reviewed by Dean Jackson.
2054
2055         There are places where generate-xcfilelists executes assignments with
2056         statements like:
2057
2058             FOO=$(some_function)
2059
2060         where "some_function" return a string by echoing it. E.g.
2061
2062             some_function()
2063             {
2064                 echo "Hello, World"
2065             }
2066
2067         This is a common idiom, but it has a problem if "some_function" needs
2068         to call "exit" in an attempt to halt the entire script right then and
2069         there. Since "some_function" is called inside of $(), it's being
2070         executed in a sub-shell. Calling exit in that sub-shell simply exits
2071         that shell; it doesn't not exit the outer shell in which the main part
2072         of the script is still running. As such, the main script keeps
2073         executing when the intent was for the script to halt.
2074
2075         The solution to this is to use a different idiom for returning
2076         strings. The one we now is to pass in the name of the variable to
2077         receive the string result:
2078
2079             some_function()
2080             {
2081                 variable_name=$1
2082                 eval $variable_name ="Hello, World"
2083             }
2084
2085         The call site now looks like
2086
2087             some_function FOO
2088
2089         Because there's no invocation of a sub-shell, some_function can now
2090         call "exit" if it wants to, and the entire script will exit at that
2091         point.
2092
2093         * Scripts/generate-xcfilelists:
2094
2095 2019-03-26  Chris Dumez  <cdumez@apple.com>
2096
2097         Add basic layout test coverage for File Picker on iOS
2098         https://bugs.webkit.org/show_bug.cgi?id=196265
2099
2100         Reviewed by Wenson Hsieh.
2101
2102         Add layout test infrastructure to test the file picker on iOS.
2103
2104         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2105         (WTR::UIScriptController::dismissFilePicker):
2106         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2107         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2108         (WTR::UIScriptController::dismissFilePicker):
2109         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2110         * WebKitTestRunner/TestController.cpp:
2111         (WTR::TestController::createWebViewWithOptions):
2112         (WTR::updateTestOptionsFromTestHeader):
2113         * WebKitTestRunner/TestOptions.h:
2114         (WTR::TestOptions::hasSameInitializationOptions const):
2115         * WebKitTestRunner/ios/TestControllerIOS.mm:
2116         (overridePresentViewController):
2117         (WTR::TestController::platformInitialize):
2118         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2119         (WTR::UIScriptController::dismissFilePicker):
2120
2121 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2122
2123         Implement async paste method on UIWKInteractionViewProtocol
2124         https://bugs.webkit.org/show_bug.cgi?id=196267
2125         <rdar://problem/49236346>
2126
2127         Reviewed by Tim Horton.
2128
2129         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2130         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2131         are now a part of all iOS 12 internal SDKs.
2132
2133         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2134
2135         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2136         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2137
2138         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2139         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2140         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2141         * TestWebKitAPI/ios/UIKitSPI.h:
2142
2143 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2144
2145         [ews-build] Use PostgreSQL for ews.webkit.org database
2146         https://bugs.webkit.org/show_bug.cgi?id=196270
2147
2148         Reviewed by Lucas Forschler.
2149
2150         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2151
2152 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2153
2154         [ews] Reset simctl states on reboot
2155         https://bugs.webkit.org/show_bug.cgi?id=196260
2156
2157         Rubber-stamped by Aakash Jain.
2158
2159         * EWSTools/start-queue-mac.sh:
2160
2161 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2162
2163         [ews-build] Use PostgreSQL for ews-build database
2164         https://bugs.webkit.org/show_bug.cgi?id=196229
2165
2166         Reviewed by Lucas Forschler.
2167
2168         * BuildSlaveSupport/ews-build/master.cfg:
2169
2170 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2171
2172         [ews-build] Get master_hostname dynamically in master.cfg
2173         https://bugs.webkit.org/show_bug.cgi?id=196255
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2178         send events data in test mode.
2179
2180 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2181
2182         [ews-app] Set db_constraint to False for Foreign Keys
2183         https://bugs.webkit.org/show_bug.cgi?id=196252
2184
2185         Reviewed by Lucas Forschler.
2186
2187         * BuildSlaveSupport/ews-app/ews/models/build.py:
2188         * BuildSlaveSupport/ews-app/ews/models/step.py:
2189
2190 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2191
2192         [ews-build] is_test_mode_enabled should default to True
2193         https://bugs.webkit.org/show_bug.cgi?id=196248
2194
2195         Reviewed by Lucas Forschler.
2196
2197         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2198
2199 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2200
2201         [ews-app] Add webkitperl to ENABLED_QUEUES
2202         https://bugs.webkit.org/show_bug.cgi?id=196253
2203
2204         Reviewed by Lucas Forschler.
2205
2206         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2207
2208 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2209
2210         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2211         https://bugs.webkit.org/show_bug.cgi?id=196211
2212         rdar://problem/49110552
2213
2214         Reviewed by Tim Horton.
2215
2216         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2217         Make sure that EventSenderProxy always exists when running tests. We used to create
2218         it when resetting before the first test, which is a bit too late.
2219
2220         * WebKitTestRunner/TestController.h:
2221         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2222         (WTR::TestController::platformCreateWebView):
2223         (WTR::TestController::platformCreateOtherPage):
2224         (WTR::TestController::finishCreatingPlatformWebView):
2225         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2226         (WTR::PlatformWebView::PlatformWebView):
2227         Moved some code that made NSWindow use NSEvent during web view creation. We may
2228         need to move more if some other case us found, but this is enough for now.
2229
2230 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         Unreviewed. Fix typo in GLib geolocation API after r243285.
2233
2234         gelocation -> geolocation.
2235
2236         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2237         (testGeolocationManagerWatchPosition):
2238
2239 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2240
2241         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2242         https://bugs.webkit.org/show_bug.cgi?id=196213
2243
2244         Reviewed by Geoff Garen.
2245
2246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2247         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2248         (credentialWithIdentityAndKeychainPath):
2249         (-[ChallengeDelegate webView:didFinishNavigation:]):
2250         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2251         (TestWebKitAPI::TEST):
2252
2253 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2254
2255         Expected shouldn't assume its contained types are copyable
2256         https://bugs.webkit.org/show_bug.cgi?id=195986
2257
2258         Reviewed by JF Bastien.
2259
2260         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2261         (TestWebKitAPI::NonCopyable::operator== const):
2262         (TestWebKitAPI::NonCopyable::operator!= const):
2263         (TestWebKitAPI::TEST):
2264
2265 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2266
2267         Remove some now-unnecessary dynamic class lookup
2268         https://bugs.webkit.org/show_bug.cgi?id=196237
2269
2270         Reviewed by Simon Fraser.
2271
2272         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2273         (makeRequest):
2274         (TEST):
2275
2276 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2277
2278         Unreviewed, rolling out r243450.
2279
2280         AppleWin and WinCairo port builds get broken.
2281
2282         Reverted changeset:
2283
2284         "Add test for fix of #196095"
2285         https://bugs.webkit.org/show_bug.cgi?id=196097
2286         https://trac.webkit.org/changeset/243450
2287
2288 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2289
2290         Unreviewed, rolling out r243465.
2291         https://bugs.webkit.org/show_bug.cgi?id=196226
2292
2293         the test doesn't build (Requested by thorton on #webkit).
2294
2295         Reverted changeset:
2296
2297         "Do not terminate the NetworkProcess if a third party
2298         application sends a NSCredential with a SecIdentityRef"
2299         https://bugs.webkit.org/show_bug.cgi?id=196213
2300         https://trac.webkit.org/changeset/243465
2301
2302 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2303
2304         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2305         https://bugs.webkit.org/show_bug.cgi?id=196213
2306
2307         Reviewed by Geoff Garen.
2308
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2311         (credentialWithIdentityAndKeychainPath):
2312         (-[ChallengeDelegate webView:didFinishNavigation:]):
2313         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2314         (TestWebKitAPI::TEST):
2315
2316 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2317
2318         [ews-build] Gracefully handle missing patch_id in events
2319         https://bugs.webkit.org/show_bug.cgi?id=196216
2320
2321         Reviewed by Lucas Forschler.
2322
2323         * BuildSlaveSupport/ews-build/events.py:
2324
2325 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2326
2327         [ews-build] use lz4 compression for improving buildbot performance
2328         https://bugs.webkit.org/show_bug.cgi?id=196155
2329
2330         Reviewed by Lucas Forschler.
2331
2332         * BuildSlaveSupport/ews-build/master.cfg:
2333
2334 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2335
2336         Pull some API testing helper methods out of TestWKWebView
2337         https://bugs.webkit.org/show_bug.cgi?id=196212
2338
2339         Reviewed by Tim Horton.
2340
2341         Refactor some more API testing utility methods, so that they can be used in
2342         tests that do not use TestWKWebView.
2343
2344         * TestWebKitAPI/cocoa/TestWKWebView.h:
2345         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2346         (-[WKWebView loadTestPageNamed:]):
2347         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2348         (-[WKWebView synchronouslyLoadHTMLString:]):
2349         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2350         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2351         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2352         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2353         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2354
2355 2019-03-25  Jer Noble  <jer.noble@apple.com>
2356
2357         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2358         https://bugs.webkit.org/show_bug.cgi?id=196097
2359
2360         Reviewed by Eric Carlson.
2361
2362         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2363
2364         * DumpRenderTree/mac/DumpRenderTree.mm:
2365         (resetWebPreferencesToConsistentValues):
2366         * WebKitTestRunner/TestController.cpp:
2367         (WTR::TestController::resetPreferencesToConsistentValues):
2368
2369 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2370
2371         Pull IPadUserInterfaceSwizzler out into a separate header file
2372         https://bugs.webkit.org/show_bug.cgi?id=196193
2373
2374         Reviewed by Anders Carlsson.
2375
2376         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2377         be used in other API tests.
2378
2379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2380         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2381         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2382         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2383         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2384         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2385         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2386
2387 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2388
2389         Remove NavigatorContentUtils in WebCore/Modules
2390         https://bugs.webkit.org/show_bug.cgi?id=196070
2391
2392         Reviewed by Alex Christensen.
2393
2394         NavigatorContentUtils was to support the custom scheme spec [1].
2395         However, in WebKit side, no port has supported the feature in
2396         WebKit layer after EFL port was removed. So there has been the
2397         only IDL implementation of the NavigatorContentUtils in WebCore.
2398         So we don't need to keep the implementation in WebCore anymore.
2399
2400         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2401
2402         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2403
2404 2019-03-24  Andy Estes  <aestes@apple.com>
2405
2406         [watchOS] Remove unused Proximity Networking code
2407         https://bugs.webkit.org/show_bug.cgi?id=196188
2408
2409         Reviewed by Tim Horton.
2410
2411         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2412         (TEST):
2413
2414 2019-03-23  Keith Miller  <keith_miller@apple.com>
2415
2416         Refactor clz/ctz and fix getLSBSet.
2417         https://bugs.webkit.org/show_bug.cgi?id=196162
2418
2419         Reviewed by Saam Barati.
2420
2421         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2422
2423         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2424         (TestWebKitAPI::TEST):
2425
2426 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2427
2428         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2429         https://bugs.webkit.org/show_bug.cgi?id=196143
2430
2431         Reviewed by Michael Catanzaro.
2432
2433         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2434         directories.
2435
2436         * Scripts/webkitpy/style/checkers/cpp.py:
2437         (check_identifier_name_in_declaration):
2438         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2439         (WebKitStyleTest.test_names):
2440
2441 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2442
2443         [Flatpak] Manifest expanding fails for qt WPE extension
2444         https://bugs.webkit.org/show_bug.cgi?id=196148
2445
2446         Reviewed by Alex Christensen.
2447
2448         * flatpak/flatpakutils.py:
2449         (expand_submodules_recurse): The last recurse manifest expand
2450         iteration might lead to a single module so take it into account
2451         and don't try to recurse further.
2452
2453 2019-03-22  Chris Dumez  <cdumez@apple.com>
2454
2455         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2456         https://bugs.webkit.org/show_bug.cgi?id=195348
2457         <rdar://problem/48622090>
2458
2459         Reviewed by Alex Christensen.
2460
2461         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2462         to NO when test.options().shouldIgnoreMetaViewport is false.
2463
2464         * WebKitTestRunner/ios/TestControllerIOS.mm:
2465         (WTR::TestController::platformConfigureViewForTest):
2466
2467 2019-03-22  Chris Dumez  <cdumez@apple.com>
2468
2469         Prewarmed processes should be usable with any website data store
2470         https://bugs.webkit.org/show_bug.cgi?id=196104
2471
2472         Reviewed by Alex Christensen.
2473
2474         Add API test coverage.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2477         (runInitialWarmedProcessUsedTest):
2478         (TEST):
2479
2480 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2481
2482         Back out local changes to Alex's Subversion working directory
2483
2484         They were accidentally committed.
2485
2486         * Scripts/webkitpy/common/system/abstractexecutive.py:
2487         (AbstractExecutive.wait_newest):
2488         * Scripts/webkitpy/common/system/executive.py:
2489         (Executive.running_pids):
2490         * Scripts/webkitpy/common/system/executive_mock.py:
2491         (MockExecutive.running_pids):
2492         * Scripts/webkitpy/common/system/executive_unittest.py:
2493         (ExecutiveTest.serial_test_running_pids):
2494         * Scripts/webkitpy/port/darwin.py:
2495         (DarwinPort.check_for_leaks):
2496         * Scripts/webkitpy/port/leakdetector.py:
2497         (LeakDetector.check_for_leaks):
2498         - This was the hack attached to Bug 193772.
2499
2500         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2501         (+[WebKitTestRunnerEvent mouseLocation]):
2502         - This works around a crash on an internal build.
2503
2504 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2505
2506         Fix the build after r243354
2507         https://bugs.webkit.org/show_bug.cgi?id=196138
2508         <rdar://problem/49145951>
2509
2510         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2511         (TEST):
2512         * TestWebKitAPI/ios/UIKitSPI.h:
2513
2514 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2515
2516         Adopt UIWKDocumentContext
2517         https://bugs.webkit.org/show_bug.cgi?id=196040
2518         <rdar://problem/48642440>
2519
2520         Reviewed by Ryosuke Niwa.
2521
2522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2523         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2524         (makeRequest):
2525         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2526         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2527         (applyStyle):
2528         (TEST):
2529         Add tests for UIWKDocumentContext.
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2532         (TEST):
2533         (recursiveFindWKContentView): Deleted.
2534         * TestWebKitAPI/cocoa/TestWKWebView.h:
2535         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2536         (recursiveFindWKContentView):
2537         (-[TestWKWebView wkContentView]):
2538         * TestWebKitAPI/ios/UIKitSPI.h:
2539         Share the WKContentView finding code between tests.
2540
2541 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2542
2543         [iOS WK2] Turn on async overflow scrolling by default
2544         https://bugs.webkit.org/show_bug.cgi?id=196011
2545         rdar://problem/48453859
2546
2547         Reviewed by Antti Koivisto.
2548         
2549         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2550         since so many basic layout tests have different results when compositing is triggered for
2551         overflow.
2552         
2553         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2554
2555         * WebKitTestRunner/TestController.cpp:
2556         (WTR::TestController::resetPreferencesToConsistentValues):
2557
2558 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] Retry API test in case of failures
2561         https://bugs.webkit.org/show_bug.cgi?id=196004
2562
2563         Reviewed by Lucas Forschler.
2564
2565         * BuildSlaveSupport/ews-build/steps.py:
2566         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2567         (CompileWebKitToT.doStepIf): Ditto.
2568         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2569         (ReRunAPITests): Re-run API tests.
2570         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2571         (RunAPITestsWithoutPatch): Run API tests without patch.
2572         (RunAPITestsWithoutPatch.doStepIf):
2573         (RunAPITestsWithoutPatch.hideStepIf):
2574         (RunAPITestsWithoutPatch.evaluateCommand):
2575         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2576         (AnalyzeAPITestsResults.start):
2577         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2578         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2579         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2580         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2581
2582 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2583
2584         [ews-build] Update queues configurations
2585         https://bugs.webkit.org/show_bug.cgi?id=196074
2586
2587         Reviewed by Dewei Zhu.
2588
2589         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2590         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2591
2592 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2595         https://bugs.webkit.org/show_bug.cgi?id=195680
2596         <rdar://problem/48903534>
2597
2598         Unreviewed infrastructure fix.
2599
2600         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2601         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2602
2603 2019-03-21  Andy Estes  <aestes@apple.com>
2604
2605         [iOS] Apple Pay should be available in documents with no user agent scripts
2606         https://bugs.webkit.org/show_bug.cgi?id=196061
2607         <rdar://problem/48649391>
2608
2609         Reviewed by Brady Eidson.
2610
2611         Added API tests and related infrastructure.
2612
2613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2614         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2615         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2616         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2617         (TestWebKitAPI::TEST):
2618         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2619         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2620         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2621         * TestWebKitAPI/cocoa/TestProtocol.mm:
2622         (-[TestProtocol startLoading]):
2623         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2624         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2625         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2626         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2627
2628 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2629
2630         REGRESSSION (r243297): webkitpy tests broken
2631         https://bugs.webkit.org/show_bug.cgi?id=196108
2632
2633         Reviewed by Aakash Jain.
2634
2635         r243297 updated contributors.json, which broke a few unit tests.
2636
2637         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2638         (IRCCommandTest.test_whois):
2639         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2640
2641 2019-03-21  Chris Dumez  <cdumez@apple.com>
2642
2643         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2644         https://bugs.webkit.org/show_bug.cgi?id=196041
2645         <rdar://problem/49083230>
2646
2647         Reviewed by Alex Christensen.
2648
2649         Add API test coverage.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2652         (TEST):
2653
2654 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2655
2656         Add SPI to inform applications of WKContentRuleList actions
2657         https://bugs.webkit.org/show_bug.cgi?id=195965
2658         <rdar://problem/42664365>
2659
2660         Reviewed by Geoff Garen.
2661
2662         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2663         (TestWebKitAPI::allActionsForResourceLoad):
2664         (TestWebKitAPI::testRequest):
2665         (TestWebKitAPI::TEST_F):
2666         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2667         (Notification::description):
2668         (Notification::operator== const):
2669         (toVector):
2670         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2671         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2672         (makeContentRuleList):
2673         (TEST):
2674         (makeWarnContentRuleList): Deleted.
2675
2676 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2677
2678         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2679         https://bugs.webkit.org/show_bug.cgi?id=196088
2680
2681         Reviewed by Brian Burg.
2682
2683         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2684         Support checks when only one platform is specified. Also deprecate macosx() and
2685         force the use of macos() instead.
2686
2687         * Scripts/webkitpy/style/checkers/cpp.py:
2688         (check_min_versions_of_wk_api_available):
2689         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2690         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2691
2692 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2693
2694         Update status inactive committers' status to 'contributor'.
2695
2696         * Scripts/webkitpy/common/config/contributors.json:
2697
2698 2019-03-21  Xan Lopez  <xan@igalia.com>
2699
2700         [JSC][x86] Drop support for x87 floating point
2701         https://bugs.webkit.org/show_bug.cgi?id=194853
2702
2703         Reviewed by Don Olmstead.
2704
2705         Force SSE2 on x86/32bit builds.
2706
2707         * Scripts/webkitdirs.pm:
2708         (generateBuildSystemFromCMakeProject):
2709
2710 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2711
2712         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2713         https://bugs.webkit.org/show_bug.cgi?id=196073
2714
2715         Reviewed by Michael Catanzaro.
2716
2717         Add test cases to check functions and constructors with no arguments but receiving user data.
2718
2719         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2720         (checkUserData):
2721         (testJSCFunction):
2722         (fooCreateWithUserData):
2723         (testJSCClass):
2724
2725 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2726
2727         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2728
2729         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2730
2731         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2732
2733 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2734
2735         [GTK][WPE] Add API to provide geolocation information
2736         https://bugs.webkit.org/show_bug.cgi?id=195940
2737
2738         Reviewed by Michael Catanzaro.
2739
2740         Add a new test to check the new API.
2741
2742         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2743         (testGeolocationManagerCurrentPosition):
2744         (testGeolocationManagerWatchPosition):
2745         (beforeAll):
2746         (afterAll):
2747         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2748         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2749         (beforeAll): Ditto.
2750         * TestWebKitAPI/glib/CMakeLists.txt:
2751
2752 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2753
2754         [GLib] Returning G_TYPE_OBJECT from a method does not work
2755         https://bugs.webkit.org/show_bug.cgi?id=195574
2756
2757         Reviewed by Michael Catanzaro.
2758
2759         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2760
2761         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2762         (getGFile):
2763         (getParent):
2764         (createGString):
2765         (getGString):
2766         (getGStringCopyWillRaise):
2767         (getGStringCopy):
2768         (getGStringStr):
2769         (getGStringLen):
2770         (freeGString):
2771         (testJSCClass):
2772
2773 2019-03-20  Saam Barati  <sbarati@apple.com>
2774
2775         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2776         https://bugs.webkit.org/show_bug.cgi?id=195721
2777
2778         Reviewed by Filip Pizlo.
2779
2780         * Scripts/run-javascriptcore-tests:
2781
2782 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2783
2784         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2785         https://bugs.webkit.org/show_bug.cgi?id=196049
2786
2787         Reviewed by Tim Horton.
2788
2789         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2790         overflow scrolling in general, so rename it.
2791
2792         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2793
2794 2019-03-20  Daniel Bates  <dabates@apple.com>
2795
2796         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2797         https://bugs.webkit.org/show_bug.cgi?id=196031
2798         <rdar://problem/49078172>
2799
2800         Reviewed by Tim Horton.
2801
2802         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2803         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2804         same code path used when the Done button is pressed to dismiss the <select> picker.
2805
2806         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2807         (TestWebKitAPI::TEST):
2808
2809 2019-03-20  Chris Dumez  <cdumez@apple.com>
2810
2811         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2812         https://bugs.webkit.org/show_bug.cgi?id=196029
2813         <rdar://problem/48954651>
2814
2815         Reviewed by Tim Horton.
2816
2817         Add API test coverage.
2818
2819         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2820
2821 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2822
2823         [ews-build] Improve failure summary string for ApplyPatch step
2824         https://bugs.webkit.org/show_bug.cgi?id=195995
2825
2826         Reviewed by Alexey Proskuryakov.
2827
2828         * BuildSlaveSupport/ews-build/steps.py:
2829         (ApplyPatch.getResultSummary): Override getResultSummary.
2830
2831 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2832
2833         AX: Implement support for new meter ARIA role
2834         https://bugs.webkit.org/show_bug.cgi?id=195966
2835
2836         Reviewed by Chris Fleizach.
2837
2838         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2839         to AXLevelIndicator.
2840
2841         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2842
2843 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2844
2845         [WebAuthN] Implement FIDO AppID extension
2846         https://bugs.webkit.org/show_bug.cgi?id=143491
2847         <rdar://problem/48298273>
2848
2849         Reviewed by Brent Fulgham.
2850
2851         Add a test that covers the new flag of convertToU2fSignCommand.
2852
2853         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2854         (TestWebKitAPI::TEST):
2855         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2856         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2857         (TestWebKitAPI::TEST):
2858
2859 2019-03-19  Keith Rollin  <krollin@apple.com>
2860
2861         Add support for more platforms to generate-xcfilelists
2862         https://bugs.webkit.org/show_bug.cgi?id=195977
2863
2864         Reviewed by Alexey Proskuryakov.
2865
2866         generate-xcfilelists incorrectly complains when involved with building
2867         WebKit for iphonesimulator:
2868
2869             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2870             …
2871             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2872
2873         Address this by teaching generate-xcfilelists about more platforms.
2874
2875         * Scripts/generate-xcfilelists:
2876
2877 2019-03-19  John Wilander  <wilander@apple.com>
2878
2879         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2880         https://bugs.webkit.org/show_bug.cgi?id=195923
2881         <rdar://problem/49001272>
2882
2883         Reviewed by Alex Christensen.
2884
2885         This patch does the following to the TestRunner:
2886         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2887         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2888         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2889
2890         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2892         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2893         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2896         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2897         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2898         * WebKitTestRunner/TestController.h:
2899         * WebKitTestRunner/TestInvocation.cpp:
2900         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2901
2902 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2903
2904         [CMake] Support more clang and gcc sanitizers
2905         https://bugs.webkit.org/show_bug.cgi?id=195956
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2910
2911 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2912
2913         [ews-build] Improve summary for PrintConfiguration step
2914         https://bugs.webkit.org/show_bug.cgi?id=195945
2915
2916         Reviewed by Lucas Forschler.
2917
2918         * BuildSlaveSupport/ews-build/steps.py:
2919         (PrintConfiguration.getResultSummary): Override getResultSummary.
2920
2921 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2922
2923         [ews-build] Improve summary for CheckOutSource step
2924         https://bugs.webkit.org/show_bug.cgi?id=195963
2925
2926         Reviewed by Lucas Forschler.
2927
2928         * BuildSlaveSupport/ews-build/steps.py:
2929         (CheckOutSource.getResultSummary):
2930
2931 2019-03-19  Daniel Bates  <dabates@apple.com>
2932
2933         [iOS] Focus not preserved when switching between tabs
2934         https://bugs.webkit.org/show_bug.cgi?id=195820
2935         <rdar://problem/43614450>
2936
2937         Reviewed by Brent Fulgham.
2938
2939         Add tests to ensure that we restore focus when resigning and becoming first responder.
2940
2941         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2942         (TestWebKitAPI::TEST):
2943
2944 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2945
2946         Make WTFLogChannelState and WTFLogLevel enum classes
2947         https://bugs.webkit.org/show_bug.cgi?id=195904
2948
2949         Reviewed by Eric Carlson.
2950
2951         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2952         (TestWebKitAPI::TEST_F):
2953
2954 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2955
2956         [GStreamer][EME] Backported mssdemux protection data crash fix
2957         https://bugs.webkit.org/show_bug.cgi?id=195918
2958
2959         Reviewed by Philippe Normand.
2960
2961         * gstreamer/jhbuild.modules:
2962         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2963
2964 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2965
2966         Unreviewed, rolling out r243132.
2967
2968         Broke GTK build
2969
2970         Reverted changeset:
2971
2972         "Make WTFLogChannelState and WTFLogLevel enum classes"
2973         https://bugs.webkit.org/show_bug.cgi?id=195904
2974         https://trac.webkit.org/changeset/243132
2975
2976 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2977
2978         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2979
2980         * Scripts/webkitdirs.pm:
2981         (builtDylibPathForName): Adjust the shared library name that's changed
2982         with the API version bump in r243073.
2983
2984 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2985
2986         Make WTFLogChannelState and WTFLogLevel enum classes
2987         https://bugs.webkit.org/show_bug.cgi?id=195904
2988
2989         Reviewed by Eric Carlson.
2990
2991         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2992         (TestWebKitAPI::TEST_F):
2993
2994 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2995
2996         Disable flaky test added in r2431100
2997         https://webkit.org/b/195785
2998
2999         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3000         (TestWebKitAPI::TEST):
3001         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3002
3003 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3004
3005         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3006         https://bugs.webkit.org/show_bug.cgi?id=195916
3007
3008         Reviewed by Tim Horton.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3011         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3012
3013 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3014
3015         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3016
3017         * Scripts/webkitpy/common/config/contributors.json:
3018
3019 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3020
3021         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3022         https://bugs.webkit.org/show_bug.cgi?id=195785
3023
3024         Reviewed by Geoffrey Garen.
3025
3026         * TestWebKitAPI/TCPServer.cpp: Added.
3027         (TestWebKitAPI::TCPServer::TCPServer):
3028         (TestWebKitAPI::TCPServer::~TCPServer):
3029         (TestWebKitAPI::TCPServer::socketBindListen):
3030         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3031         * TestWebKitAPI/TCPServer.h: Added.
3032         (TestWebKitAPI::TCPServer::port const):
3033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3034         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3035         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3036         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3037         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3038         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3039         (TestWebKitAPI::respondSlowly):
3040         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3041         (TestWebKitAPI::downloadAtRate):
3042         (TestWebKitAPI::TEST):
3043
3044 2019-03-18  Saam Barati  <sbarati@apple.com>
3045
3046         Add a plan file for JetStream 2
3047         https://bugs.webkit.org/show_bug.cgi?id=190734
3048
3049         Reviewed by Mark Lam.
3050
3051         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3052
3053 2019-03-18  Chris Dumez  <cdumez@apple.com>
3054
3055         Delay WebProcess launch until a load is triggered in a Web view
3056         https://bugs.webkit.org/show_bug.cgi?id=195758
3057         <rdar://problem/48126013>
3058
3059         Reviewed by Geoff Garen.
3060
3061         Add API test coverage. Also update some existing API tests to not expect
3062         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3063
3064         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3065         (TestWebKitAPI::TEST):
3066         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3067         (TestWebKitAPI::TEST):
3068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3069         (TEST):
3070         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3071         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3072         (TEST):
3073         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3074         (TEST):
3075         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3076
3077 2019-03-18  Xan Lopez  <xan@igalia.com>
3078
3079         [CMake] Prevent potential warning when determining $architecture
3080         https://bugs.webkit.org/show_bug.cgi?id=195891
3081
3082         Reviewed by Michael Catanzaro.
3083
3084         It's possible for generateBuildSystemForCMakeProject to be called
3085         before determineArchitecture() is ever called. This will make the
3086         first eq check with $architecture to be bogus (and print a
3087         warning). Change that to an eq check with architecture(), which
3088         implicitly calls determineArchitecture() if needed, and change all
3089         the other similar cases in the method in the same way to prevent
3090         future bugs like this one.
3091
3092         * Scripts/webkitdirs.pm:
3093         (generateBuildSystemFromCMakeProject):
3094
3095 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3096
3097         [WPE] Tarballs generated with “make dist” cannot build documentation
3098         https://bugs.webkit.org/show_bug.cgi?id=195885
3099
3100         Reviewed by Carlos Garcia Campos.
3101
3102         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3103
3104 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3105
3106         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3107         https://bugs.webkit.org/show_bug.cgi?id=195883
3108
3109         Reviewed by Carlos Garcia Campos.
3110
3111         * gtkdoc/gtkdoc.py:
3112         (GTKDoc._run_command): When commands fail to run, include the full command line for
3113         the program invocation and the output it has generated on the standard error stream.
3114
3115 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3116
3117         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3118         https://bugs.webkit.org/show_bug.cgi?id=195786
3119
3120         Reviewed by Philippe Normand.
3121
3122         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3123         * wpe/jhbuild.modules: Ditto.
3124
3125 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3126
3127         [ews-build] Don't run clean builds on EWS builders
3128         https://bugs.webkit.org/show_bug.cgi?id=195851
3129
3130         Reviewed by Geoffrey Garen.
3131
3132         * BuildSlaveSupport/ews-build/factories.py:
3133
3134 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3135
3136         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3137         https://bugs.webkit.org/show_bug.cgi?id=195849
3138
3139         Reviewed by Chris Dumez.
3140
3141         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3142
3143         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3144         (runWebsiteDataStoreCustomPaths):
3145
3146 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3147
3148         webkitpy: Upload test results
3149         https://bugs.webkit.org/show_bug.cgi?id=195755
3150         <rdar://problem/48896182>
3151
3152         Reviewed by Aakash Jain.
3153
3154         Establish a new format for uploading results that is not tied to layout tests, apply
3155         that format to webkitpy tests.
3156
3157         * Scripts/webkitpy/common/checkout/scm/git.py:
3158         (Git.native_branch): Return what branch the current checkout is on.
3159         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3160         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3161         * Scripts/webkitpy/common/checkout/scm/svn.py:
3162         (SVN.native_branch): Ditto.
3163         * Scripts/webkitpy/common/system/platforminfo.py:
3164         (PlatformInfo.build_version): Return a build version for Mac.
3165         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3166         (MockPlatformInfo.__init__):
3167         (MockPlatformInfo.build_version):
3168         * Scripts/webkitpy/results: Added.
3169         * Scripts/webkitpy/results/__init__.py: Added.
3170         * Scripts/webkitpy/results/options.py: Added.
3171         (upload_options): OptParse list for upload options.
3172         * Scripts/webkitpy/results/upload.py: Added.
3173         (Upload): Class which enforces the upload format expected by the results server.
3174         (Upload.Expectations):
3175         (Upload.create_configuration):
3176         (Upload.create_commit):
3177         (Upload.create_details):
3178         (Upload.create_run_stats):
3179         (Upload.create_test_result):
3180         (Upload.__init__):
3181         (Upload.Encoder): Encode Upload object as json.
3182         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3183         * Scripts/webkitpy/results/upload_unittest.py: Added.
3184         * Scripts/webkitpy/test/main.py:
3185         (Tester._parse_args): Add upload arguments.
3186         (Tester._run_tests): Allow results to be uploaded.
3187         * Scripts/webkitpy/test/runner.py:
3188         (Runner.__init__): Record which tests were run, rather than just counting them.
3189         (Runner.handle):
3190         * Scripts/webkitpy/test/runner_unittest.py:
3191         (RunnerTest.test_run):
3192         * Scripts/webkitpy/thirdparty/__init__.py:
3193         (AutoinstallImportHook.find_module): Add requests auto-install.
3194         (AutoinstallImportHook._install_requests):
3195         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3196         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3197
3198 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3199
3200         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3201         https://bugs.webkit.org/show_bug.cgi?id=195810
3202
3203         Reviewed by Tim Horton.
3204
3205         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3206         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3207         ending certain layout tests.
3208
3209         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3210         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3211         (-[TestRunnerWKWebView dealloc]):
3212         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3213
3214         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3215         helper method when destroying the web view, and when resetting state between tests.
3216
3217         * WebKitTestRunner/ios/TestControllerIOS.mm:
3218         (WTR::TestController::platformResetStateToConsistentValues):
3219
3220         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3221
3222 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3223
3224         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3225         https://bugs.webkit.org/show_bug.cgi?id=190350
3226         <rdar://problem/45089503>
3227
3228         Reviewed by Geoffrey Garen.
3229
3230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3231         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3232         (TEST):
3233         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3234         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3235         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3236         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3237         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3238         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3239         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3240         (runTest):
3241         (createDirectories):
3242         (TEST):
3243         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3244         (TEST):
3245         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3246         (TEST):
3247
3248 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3249
3250         Add support to WebPage for getting the contents as an attributed string.
3251         https://bugs.webkit.org/show_bug.cgi?id=195636
3252         rdar://problem/45055697
3253
3254         Reviewed by Tim Horton.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3257         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3258
3259 2019-03-15  Chris Dumez  <cdumez@apple.com>
3260
3261         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3262         https://bugs.webkit.org/show_bug.cgi?id=195747
3263
3264         Reviewed by Geoff Garen.
3265
3266         Add API test coverage.
3267
3268         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3269
3270 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3271
3272         Unreviewed, rolling out r242952.
3273
3274         Causing API failures on iOS Simulator
3275
3276         Reverted changeset:
3277
3278         "[PSON] Make sure the WebProcessCache is leverage when
3279         relaunching a process after termination"
3280         https://bugs.webkit.org/show_bug.cgi?id=195747
3281         https://trac.webkit.org/changeset/242952
3282
3283 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3284
3285         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3286         https://bugs.webkit.org/show_bug.cgi?id=195740
3287
3288         Reviewed by Ross Kirsling.
3289
3290         window.open doesn't work for WebKitBrowserWindow because it is not
3291         implemented yet.
3292
3293         1. Implemented createNewPage callback of WKPageUIClient.
3294         2. Changed MainWindow to take a BrowserWindow factory function
3295           instead of BrowserWindowType to be flexible to create
3296           BrowserWindow with extra settings.
3297         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3298           because it is not relevant with MainWindow anymore.
3299
3300         * MiniBrowser/win/Common.cpp:
3301         (parseCommandLine):
3302         * MiniBrowser/win/Common.h:
3303         (CommandLineOptions::CommandLineOptions):
3304         * MiniBrowser/win/MainWindow.cpp:
3305         (MainWindow::MainWindow):
3306         (MainWindow::create):
3307         (MainWindow::init):
3308         (MainWindow::WndProc):
3309         * MiniBrowser/win/MainWindow.h:
3310         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3311         (PrintWebUIDelegate::createWebViewWithRequest):
3312         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3313         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3314         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3315         (WebKitBrowserWindow::updateProxySettings):
3316         (WebKitBrowserWindow::createNewPage):
3317         * MiniBrowser/win/WebKitBrowserWindow.h:
3318         * MiniBrowser/win/WinMain.cpp:
3319         (wWinMain):
3320
3321 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3322
3323         Make it possible to test scrolling tree layer manipulation more easily
3324         https://bugs.webkit.org/show_bug.cgi?id=195780
3325
3326         Reviewed by Tim Horton.
3327         
3328         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3329         cuts off communication of scrolling tree scrolls back to the web process
3330         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3331         allows tests to trigger scrolls which run the scrolling tree layer positioning
3332         logic, but never get another commit from the web process that might mask
3333         scrolling tree bugs.
3334         
3335         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3336         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3337         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3338
3339         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3340         (WTR::UIScriptController::scrollUpdatesDisabled const):
3341         (WTR::UIScriptController::setScrollUpdatesDisabled):
3342         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3343         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3344         (WTR::UIScriptController::scrollUpdatesDisabled const):
3345         (WTR::UIScriptController::setScrollUpdatesDisabled):
3346         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3347         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3348         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3349         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3350         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3351         * WebKitTestRunner/ios/TestControllerIOS.mm:
3352         (WTR::TestController::platformResetStateToConsistentValues):
3353         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3354         (WTR::UIScriptController::scrollUpdatesDisabled const):
3355         (WTR::UIScriptController::setScrollUpdatesDisabled):
3356
3357 2019-03-14  Youenn Fablet  <youenn@apple.com>
3358
3359         Move IDB storage in private browsing mode to NetworkProcess
3360         https://bugs.webkit.org/show_bug.cgi?id=195602
3361
3362         Reviewed by Brady Eidson.
3363
3364         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3365         (TEST):
3366
3367 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3368
3369         [ews-build] Make descriptionDone messages more readable
3370         https://bugs.webkit.org/show_bug.cgi?id=195760
3371
3372         Reviewed by Lucas Forschler.
3373
3374         * BuildSlaveSupport/ews-build/steps.py:
3375         * BuildSlaveSupport/ews-build/steps_unittest.py:
3376
3377 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3378
3379         [ews-build] Generate status-bubble hover-over messages
3380         https://bugs.webkit.org/show_bug.cgi?id=195680
3381
3382         Reviewed by Lucas Forschler.
3383
3384         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3385         (StatusBubble):
3386         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3387         on hover-over.
3388         (StatusBubble._iso_time):
3389         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3390         hover-over message.
3391         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3392
3393 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3394
3395         [ews-app] Gracefully handle the case when state_string is None
3396         https://bugs.webkit.org/show_bug.cgi?id=195753
3397
3398         Reviewed by Lucas Forschler.
3399
3400         * BuildSlaveSupport/ews-app/ews/models/build.py:
3401         * BuildSlaveSupport/ews-app/ews/models/step.py:
3402
3403 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-app] Status bubble display pending for currently running build step
3406         https://bugs.webkit.org/show_bug.cgi?id=195744
3407
3408         Reviewed by Lucas Forschler.
3409
3410         * BuildSlaveSupport/ews-build/events.py:
3411         (Events.stepStarted): If state_string is pending, replace it with step name.
3412
3413 2019-03-14  Chris Dumez  <cdumez@apple.com>
3414
3415         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3416         https://bugs.webkit.org/show_bug.cgi?id=195750
3417
3418         Reviewed by Geoffrey Garen.
3419
3420         Add API test coverage.
3421
3422         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3423         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3424         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3425         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3426
3427 2019-03-14  Chris Dumez  <cdumez@apple.com>
3428
3429         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3430         https://bugs.webkit.org/show_bug.cgi?id=195747
3431
3432         Reviewed by Geoff Garen.
3433
3434         Add API test coverage.
3435
3436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3437
3438 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3439
3440         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3441         https://bugs.webkit.org/show_bug.cgi?id=195725
3442         <rdar://problem/48545062>
3443
3444         Reviewed by Tim Horton.
3445
3446         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3447         handler is nil.
3448
3449         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3450         (TestWebKitAPI::TEST):
3451
3452 2019-03-13  Sam Weinig  <sam@webkit.org>
3453
3454         Add utility function to allow easy reverse range-based iteration of a container
3455         https://bugs.webkit.org/show_bug.cgi?id=195542
3456
3457         Reviewed by Antti Koivisto.
3458
3459         * TestWebKitAPI/CMakeLists.txt:
3460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3461         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3462         (TestWebKitAPI::TEST):
3463         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3464
3465 2019-03-13  Chris Dumez  <cdumez@apple.com>
3466
3467         Use a ServiceWorker process per registrable domain
3468         https://bugs.webkit.org/show_bug.cgi?id=195649
3469
3470         Reviewed by Youenn Fablet.
3471
3472         Update API test coverage.
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3475
3476 2019-03-13  Chris Dumez  <cdumez@apple.com>
3477
3478         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3479         https://bugs.webkit.org/show_bug.cgi?id=195684
3480         <rdar://problem/48294714>
3481
3482         Reviewed by Antti Koivisto.
3483
3484         Add API test coverage.
3485
3486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3487
3488 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-app] Remove unused patch view
3491         https://bugs.webkit.org/show_bug.cgi?id=195669
3492
3493         Reviewed by Lucas Forschler.
3494
3495         * BuildSlaveSupport/ews-app/ews/urls.py:
3496         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3497
3498 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-app] Use Buildbot result code variables
3501         https://bugs.webkit.org/show_bug.cgi?id=195668
3502
3503         Reviewed by Alexey Proskuryakov.
3504
3505         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3506         (Buildbot): Added Buildbot result code variables.
3507         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3508         (StatusBubble._build_bubble): Used Buildbot result code variables.
3509
3510 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3511
3512         [Flatpak] Expand submodule recursively
3513         https://bugs.webkit.org/show_bug.cgi?id=195672
3514
3515         Building WPE with flatpak was impossible without that as it was raising an exception.
3516         Also update wpebackend-fdo to match what is built in jhbuild
3517
3518         Reviewed by Philippe Normand.
3519
3520         * flatpak/flatpakutils.py:
3521         (expand_submodules_recurse):
3522         (expand_manifest):
3523         * flatpak/org.webkit.WPEModules.yaml:
3524
3525 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-app] status bubble should be hidden for certain builds
3528         https://bugs.webkit.org/show_bug.cgi?id=194597
3529
3530         Reviewed by Dewei Zhu.
3531
3532         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3533         (StatusBubble._build_bubble):
3534         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3535         because the patch didn't have relevant changes.
3536         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3537         in production yet.
3538
3539 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3540
3541         [Win] Fix a slew of simple clang-cl warnings.
3542         https://bugs.webkit.org/show_bug.cgi?id=195652
3543
3544         Reviewed by Don Olmstead.
3545
3546         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3547         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3548
3549 2019-03-12  Justin Fan  <justin_fan@apple.com>
3550
3551         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3552         https://bugs.webkit.org/show_bug.cgi?id=195518
3553         <rdar://problem/46322356>
3554
3555         Reviewed by Myles C. Maxfield.
3556
3557         * DumpRenderTree/DerivedSources-input.xcfilelist:
3558         * DumpRenderTree/DerivedSources-output.xcfilelist:
3559
3560 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3561
3562         Unreviewed, rolling out r242825.
3563         https://bugs.webkit.org/show_bug.cgi?id=195648
3564
3565         "Broke webkitpy tests with my change to
3566         lldb_dump_class_layout.py" (Requested by rmorisset on
3567         #webkit).
3568
3569         Reverted changeset:
3570
3571         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3572         classes with suspicious padding"
3573         https://bugs.webkit.org/show_bug.cgi?id=195573
3574         https://trac.webkit.org/changeset/242825
3575
3576 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3577
3578         [ews-build] Show status bubbles while the patch is waiting in queue
3579         https://bugs.webkit.org/show_bug.cgi?id=195618
3580
3581         Reviewed by Lucas Forschler.
3582
3583         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3584         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3585         enabled in initial deployment.
3586         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3587         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3588         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3589         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3590         (StatusBubble._build_bubbles_for_patch):
3591
3592 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3593
3594         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3595         https://bugs.webkit.org/show_bug.cgi?id=195573
3596
3597         Reviewed by Simon Fraser.
3598
3599         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3600
3601         * Scripts/dump-class-layout:
3602         (main):
3603         * lldb/lldb_dump_class_layout.py:
3604         (ClassLayout.__init__):
3605         (ClassLayout._compute_padding_recursive):
3606         (LLDBDebuggerInstance.dump_layout_for_classname):
3607         (LLDBDebuggerInstance):
3608         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3609         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3610
3611 2019-03-12  Chris Dumez  <cdumez@apple.com>
3612
3613         Device Orientation access permission should be denied unless explicitly granted by the client
3614         https://bugs.webkit.org/show_bug.cgi?id=195625
3615
3616         Reviewed by Youenn Fablet.
3617
3618         add API test coverage.
3619
3620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3621         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3622         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3623         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3624         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3625         (runDeviceOrientationTest):
3626         (TEST):
3627         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3628         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3629
3630 2019-03-12  Jer Noble  <jer.noble@apple.com>
3631
3632         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3633         https://bugs.webkit.org/show_bug.cgi?id=195137
3634         <rdar://problem/48810307>
3635
3636         Reviewed by Eric Carlson.
3637
3638         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3639         (TestWebKitAPI::TEST):
3640
3641 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3642
3643         [ews-build] Change urls from uat to production
3644         https://bugs.webkit.org/show_bug.cgi?id=195566
3645
3646         Reviewed by Lucas Forschler.
3647
3648         * BuildSlaveSupport/ews-app/ews/config.py:
3649         * BuildSlaveSupport/ews-build/events.py:
3650         * BuildSlaveSupport/ews-build/steps.py:
3651
3652 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3653
3654         [ews-build] change max_builds for local-worker to 1
3655         https://bugs.webkit.org/show_bug.cgi?id=195568
3656
3657         Reviewed by Lucas Forschler.
3658
3659         * BuildSlaveSupport/ews-build/loadConfig.py:
3660
3661 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3662
3663         Fix the build
3664
3665         * TestRunnerShared/spi/PencilKitTestSPI.h:
3666         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3667
3668 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3669
3670         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3671         https://bugs.webkit.org/show_bug.cgi?id=194131
3672
3673         Reviewed by Michael Catanzaro.
3674
3675         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3676         (uriChanged):
3677         (testUnfinishedSubresourceLoad):
3678         (serverCallback):
3679         (beforeAll):
3680
3681 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3682
3683         WTF::Expected should use std::addressof instead of operator&
3684         https://bugs.webkit.org/show_bug.cgi?id=195604
3685
3686         Reviewed by Myles Maxfield.
3687
3688         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3689         (TestWebKitAPI::Unique::Unique):
3690         (TestWebKitAPI::Unique::operator&):
3691         (TestWebKitAPI::TEST):
3692
3693 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3694
3695         Add Optional to Forward.h.
3696         https://bugs.webkit.org/show_bug.cgi?id=195586
3697
3698         Reviewed by Darin Adler.
3699
3700         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3701         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3702         Remove unnecessary includes from headers.
3703
3704 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3705
3706         Add testing API to hit-test and scroll overflow scrollers
3707         https://bugs.webkit.org/show_bug.cgi?id=195278
3708
3709         Reviewed by Antti Koivisto.
3710         
3711         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3712         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3713         
3714         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3715
3716         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3717         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3719         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3720         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3721         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3722         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3723         (WTR::enclosingScrollViewIncludingSelf):
3724         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3725
3726 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3727
3728         API test WebKit.RequestTextInputContext fails on iOS
3729         https://bugs.webkit.org/show_bug.cgi?id=195585
3730
3731         Reviewed by Wenson Hsieh and Simon Fraser.
3732
3733         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3734         (applyStyle):
3735         (TEST):
3736         Add a viewport, so that the coordinates match up on iOS.
3737         Scroll by moving the UIScrollView's contentOffset.
3738
3739 2019-03-11  Chris Dumez  <cdumez@apple.com>
3740
3741         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3742         https://bugs.webkit.org/show_bug.cgi?id=195506
3743         <rdar://problem/48733477>
3744
3745         Reviewed by Alex Christensen.
3746
3747         Add API test coverage.
3748
3749         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3750
3751 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3752
3753         Adding myself to contributors.json
3754
3755         Unreviewed, addming myself to contributors.json .
3756
3757         * Scripts/webkitpy/common/config/contributors.json:
3758
3759 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3760
3761         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3762         https://bugs.webkit.org/show_bug.cgi?id=195511
3763         <rdar://problem/44873269>
3764
3765         Reviewed by Darin Adler.
3766
3767         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3768         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3769         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3770         (TEST_F):
3771
3772 2019-03-11  Chris Dumez  <cdumez@apple.com>
3773
3774         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3775         https://bugs.webkit.org/show_bug.cgi?id=195561
3776
3777         Reviewed by Youenn Fablet.
3778
3779         Make sure the JS in the test requests for permission to receive device orientation events.
3780
3781         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3782
3783 2019-03-11  Youenn Fablet  <youenn@apple.com>
3784
3785         Allow storage quota increase by default in WTR
3786         https://bugs.webkit.org/show_bug.cgi?id=195541
3787
3788         Reviewed by Geoffrey Garen.
3789
3790         Allow storage quota increase by default in WTR.
3791         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3792         Use this for tests that explicitly need cache increase.
3793
3794         Instead of increasing quota by 2, make sure the next request is
3795         granted by adding all given parameters.
3796
3797         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3798         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3799         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3800         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3801         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3802         * WebKitTestRunner/TestController.cpp:
3803         (WTR::TestController::setAllowStorageQuotaIncrease):
3804         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3805         * WebKitTestRunner/TestController.h:
3806         * WebKitTestRunner/TestInvocation.cpp:
3807         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3808         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3809         (WTR::TestController::cocoaResetStateToConsistentValues):
3810         (WTR::TestController::setAllowStorageQuotaIncrease):
3811         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3812         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3813         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3814
3815 2019-03-11  Xan Lopez  <xan@igalia.com>
3816
3817         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3818         https://bugs.webkit.org/show_bug.cgi?id=194147
3819
3820         Reviewed by Michael Saboff.
3821
3822         To make --32-bit work correctly on Linux/64bit we need to:
3823
3824         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3825         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3826         unfortunately CMake only allows us to do this during
3827         crosscompilation, which is overkill here.
3828         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3829         pkg-config detection module uses the x86 .pc files instead of the
3830         x86_64 ones.
3831         - Set the -m32 flags for the compiler.
3832
3833         * Scripts/webkitdirs.pm:
3834         (generateBuildSystemFromCMakeProject):
3835
3836 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3837
3838         Add MotionMark-1.1 plan file for run-benchmark script.
3839         https://bugs.webkit.org/show_bug.cgi?id=195481
3840
3841         Rubber-stamped by Darin Adler.
3842
3843         Run-benchmark script should support MontionMark-1.1.
3844
3845         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3846
3847 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3848
3849         [ews-app] Add support for submit-to-ews url
3850         https://bugs.webkit.org/show_bug.cgi?id=195477
3851
3852         Reviewed by Lucas Forschler.
3853
3854         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3855         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3856         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3857         * BuildSlaveSupport/ews-app/ews/urls.py:
3858         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3859
3860 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3861
3862         Unreviewed, rolling out r242688, r242643, r242624.
3863
3864         Caused multiple layout test failures and crashes on iOS and macOS.
3865
3866         Reverted changeset:
3867
3868         "requestAnimationFrame should execute before the next frame"
3869         https://bugs.webkit.org/show_bug.cgi?id=177484
3870         https://trac.webkit.org/changeset/242624/webkit
3871
3872         * Tracing/SystemTracePoints.plist:
3873
3874 2019-03-11  John Wilander  <wilander@apple.com>
3875
3876         Resource Load Statistics: Make it possible exclude localhost from classification
3877         https://bugs.webkit.org/show_bug.cgi?id=195474
3878         <rdar://problem/47520577>
3879
3880         Reviewed by Brent Fulgham.
3881
3882         This patch allows for localhost to be excluded from classification and
3883         treatment as a prevalent resource.
3884
3885         The WebKit Tools change adds a new function called
3886         testRunner.setStatisticsIsRunningTest() which can be used to control this
3887         behavior.
3888
3889         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3890         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3891         (WTR::TestRunner::setStatisticsIsRunningTest):
3892         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3893         * WebKitTestRunner/TestController.cpp:
3894         (WTR::TestController::setStatisticsIsRunningTest):
3895         * WebKitTestRunner/TestController.h:
3896         * WebKitTestRunner/TestInvocation.cpp:
3897         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3898
3899 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3900
3901         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3902         https://bugs.webkit.org/show_bug.cgi?id=195560
3903
3904         Reviewed by Lucas Forschler.
3905
3906         * BuildSlaveSupport/ews-build/master.cfg:
3907
3908 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3909
3910         Unreviewed, rolling out r242698.
3911
3912         API test crashes on bots.
3913
3914         Reverted changeset:
3915
3916         "Add a WKContentRuleList variant that uses copied memory
3917         instead of mmap'd shared memory for class A containerized
3918         apps"
3919         https://bugs.webkit.org/show_bug.cgi?id=195511
3920         https://trac.webkit.org/changeset/242698
3921
3922 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3923
3924         [WPE] Enable web process sandbox
3925         https://bugs.webkit.org/show_bug.cgi?id=195169
3926
3927         Reviewed by Daniel Bates.
3928
3929         * wpe/install-dependencies:
3930         * wpe/jhbuild.modules:
3931
3932 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3933
3934         [ews-app] Use port 17000 for worker communication
3935         https://bugs.webkit.org/show_bug.cgi?id=195558
3936
3937         Reviewed by Lucas Forschler.
3938
3939         * BuildSlaveSupport/ews-build/master.cfg:
3940
3941 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3942
3943         [ews-build] unit-tests fail when passwords.json is missing
3944         https://bugs.webkit.org/show_bug.cgi?id=195557
3945
3946         Reviewed by Lucas Forschler.
3947
3948         * BuildSlaveSupport/ews-build/loadConfig.py:
3949         (loadBuilderConfig):
3950         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3951         (ConfigDotJSONTest.test_configuration):
3952         * BuildSlaveSupport/ews-build/master.cfg:
3953
3954 2019-03-11  Truitt Savell  <tsavell@apple.com>
3955
3956         Unreviewed, rolling out r242702.
3957
3958         Broke High Sierra builders.
3959
3960         Reverted changeset:
3961
3962         "Add utility function to allow easy reverse range-based
3963         iteration of a container"
3964         https://bugs.webkit.org/show_bug.cgi?id=195542
3965         https://trac.webkit.org/changeset/242702
3966
3967 2019-03-11  Sam Weinig  <sam@webkit.org>
3968
3969         Add utility function to allow easy reverse range-based iteration of a container
3970         https://bugs.webkit.org/show_bug.cgi?id=195542
3971
3972         Reviewed by Antti Koivisto.
3973
3974         * TestWebKitAPI/CMakeLists.txt:
3975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3976         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3977         (TestWebKitAPI::TEST):
3978         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3979
3980 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3981
3982         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3983         https://bugs.webkit.org/show_bug.cgi?id=195511
3984         <rdar://problem/44873269>
3985
3986         Reviewed by Darin Adler.
3987
3988         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3989         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3990         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3991         (TEST_F):
3992
3993 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3994
3995         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3996         https://bugs.webkit.org/show_bug.cgi?id=195499
3997
3998         Reviewed by Darin Adler.
3999
4000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4001         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
4002         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
4003         (-[WKWebView synchronouslyFocusTextInputContext:]):
4004         (applyStyle):
4005         (applyIframe):
4006         (TEST):
4007         Add some tests for this SPI.
4008
4009 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
4010
4011         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
4012         https://bugs.webkit.org/show_bug.cgi?id=181151
4013
4014         Reviewed by Don Olmstead.
4015
4016         * TestWebKitAPI/CMakeLists.txt:
4017         * TestWebKitAPI/PlatformWin.cmake:
4018         Enable TestWTF RunLoop tests in all platforms.
4019
4020         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
4021         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
4022         (TestWebKitAPI::DerivedOneShotTimer::fired):
4023         (TestWebKitAPI::TEST):
4024         Only a few platforms support nested RunLoop.
4025
4026         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
4027         (TestWebKitAPI::DerivedRepeatingTimer::fired):
4028
4029 2019-03-10  David Quesada  <david_quesada@apple.com>
4030
4031         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
4032         https://bugs.webkit.org/show_bug.cgi?id=152480
4033
4034         Reviewed by Chris Dumez.
4035
4036         Add a unit test based on Daniel Bates's test case that starts a download, ensures
4037         there are no additional references to the process pool besides the one held by
4038         the download, waits for the download to finish (in the sense that the
4039         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
4040         measure, also check that the process pool has been deallocated at the end of the
4041         test. The test wouldn't be meaningful if the process pool were still alive.
4042
4043         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4044         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
4045         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
4046             The download will be canceled because the delegate does not implement the
4047             method to decide the download's destination, so this is where we know the
4048             DownloadProxyMap is done with the DownloadProxy.
4049         (TEST):
4050
4051 2019-03-08  Chris Dumez  <cdumez@apple.com>
4052
4053         Add support for Device Orientation / Motion permission API
4054         https://bugs.webkit.org/show_bug.cgi?id=195329
4055         <rdar://problem/47645367>
4056
4057         Reviewed by Geoffrey Garen.
4058
4059         Add test infrastructure to help test the Device Orientation / Motion permission API.
4060
4061         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4062         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4063         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
4064         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4065         * WebKitTestRunner/TestController.cpp:
4066         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
4067         (WTR::TestController::createWebViewWithOptions):
4068         (WTR::TestController::resetStateToConsistentValues):
4069         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
4070         * WebKitTestRunner/TestController.h:
4071         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
4072         * WebKitTestRunner/TestInvocation.cpp:
4073         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4074
4075 2019-03-08  Saam barati  <sbarati@apple.com>
4076
4077         Add a compare-results script to compare benchmark results
4078         https://bugs.webkit.org/show_bug.cgi?id=195486
4079         <rdar://problem/48723397>
4080
4081         Reviewed by Geoffrey Garen.
4082
4083         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
4084         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
4085         to extend it to learn about our other benchmarks.
4086
4087         * Scripts/compare-results: Added.
4088         (readJSONFile):
4089         (detectJetStream2):
4090         (JetStream2Results):
4091         (detectSpeedometer2):
4092         (Speedometer2Results):
4093         (detectPLT5):
4094         (PLT5Results):
4095         (detectBenchmark):
4096         (biggerIsBetter):
4097         (ttest):
4098         (getOptions):
4099         (main):
4100
4101 2019-03-08  Stephanie Lewis  <slewis@apple.com>
4102
4103         Ensure old tab state is cleared between iterations of run-benchmark
4104         https://bugs.webkit.org/show_bug.cgi?id=195393
4105         <rdar://problem/46885583>
4106
4107         Reviewed by Dewei Zhu.
4108
4109         a) ensure the default to restore state is not set
4110         b) terminate Safari correctly
4111         c) Set the system default to ignore Persistent State in Safari
4112
4113         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4114         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
4115         (OSXBrowserDriver.prepare_env): 
4116         (OSXBrowserDriver.restore_env):
4117         (OSXBrowserDriver.close_browsers):
4118         (OSXBrowserDriver._terminate_processes):
4119         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
4120         (OSXChromeDriver):
4121         (OSXChromeCanaryDriver):
4122         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
4123         (OSXFirefoxDriver):
4124         (OSXFirefoxNightlyDriver):
4125         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
4126         (OSXSafariDriver):
4127         (OSXSafariDriver.prepare_env):
4128
4129 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
4130
4131         [GTK] Several InputMethodFilter tests are failing
4132         https://bugs.webkit.org/show_bug.cgi?id=195408
4133
4134         Reviewed by Carlos Garcia Campos.
4135
4136         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
4137         Regressed in r241751.
4138         Hexadecimal values of keycodes are expressed now in upper letters.
4139         Composited characters should be cast to UTF8 strings.
4140
4141         (TestWebKitAPI::TEST):
4142
4143 2019-03-07  Tomas Popela  <tpopela@redhat.com>
4144
4145         [GTK] Make Tools/gtkdoc python3 compatible
4146         https://bugs.webkit.org/show_bug.cgi?id=195359
4147
4148         Reviewed by Carlos Garcia Campos.
4149
4150         * gtkdoc/generate-gtkdoc:
4151         ConfigParser was reworked in Python 3.2 so we have adapt the code to
4152         work with Python 2 and 3.
4153         (get_gtkdoc_module_paths):
4154         The iteritems() was removed in Python 3, so let's use items() that's
4155         available in Python 2 and 3.
4156         (get_generator_for_config):
4157         * gtkdoc/gtkdoc.py:
4158         (GTKDoc._run_command):
4159         The sys.stdout.write() is expecting str in Python 3 and not bytes
4160         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
4161         for passing the bytes there.
4162
4163 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4164
4165         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4166         https://bugs.webkit.org/show_bug.cgi?id=195346
4167         <rdar://problem/48667048>
4168
4169         Unreviewed build fix for clang-cl.
4170
4171         * DumpRenderTree/win/DumpRenderTree.cpp:
4172         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
4173
4174 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
4175
4176         requestAnimationFrame should execute before the next frame
4177         https://bugs.webkit.org/show_bug.cgi?id=177484
4178
4179         Reviewed by Simon Fraser.
4180
4181         Add trace points for the page RenderingUpdate.
4182
4183         * Tracing/SystemTracePoints.plist:
4184
4185 2019-03-07  Zalan Bujtas  <zalan@apple.com>
4186
4187         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4188         https://bugs.webkit.org/show_bug.cgi?id=195353
4189         <rdar://problem/48626394>
4190
4191         Reviewed by Simon Fraser.
4192
4193         * WebKitTestRunner/ios/TestControllerIOS.mm:
4194         (WTR::TestController::platformResetPreferencesToConsistentValues):
4195
4196 2019-03-07  John Wilander  <wilander@apple.com>
4197
4198         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4199         https://bugs.webkit.org/show_bug.cgi?id=195383
4200         <rdar://problem/48570136>
4201
4202         Reviewed by Brent Fulgham.
4203
4204         This patch adds test infrastructure to purge only script-accessible cookies,
4205         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4206
4207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4209         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4210         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4211         * WebKitTestRunner/TestController.cpp:
4212         (WTR::TestController::statisticsDeleteCookiesForHost):
4213         * WebKitTestRunner/TestController.h:
4214         * WebKitTestRunner/TestInvocation.cpp:
4215         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4216
4217 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4218
4219         Unreviewed, rolling out r242354.
4220         https://bugs.webkit.org/show_bug.cgi?id=195402
4221
4222         breaks layout tests in all configurations (Requested by
4223         zdobersek on #webkit).
4224
4225         Reverted changeset:
4226
4227         "[WPE] Enable web process sandbox"
4228         https://bugs.webkit.org/show_bug.cgi?id=195169
4229         https://trac.webkit.org/changeset/242354
4230
4231 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4232
4233         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4234         https://bugs.webkit.org/show_bug.cgi?id=195346
4235
4236         Reviewed by Fujii Hironori.
4237
4238         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4239         (TestWebKitAPI::TEST):
4240         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4241
4242         * DumpRenderTree/win/DumpRenderTree.cpp:
4243         (findFontFallback):
4244         (addFontFallbackIfPresent):
4245         (removeFontFallbackIfPresent):
4246         (main):
4247         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4248         (TestWebKitAPI::Util::moduleDirectory):
4249         (TestWebKitAPI::Util::createInjectedBundlePath):
4250         Use wchar helpers as needed.
4251
4252 2019-03-06  Rob Buis  <rbuis@igalia.com>
4253
4254         Consider supporting the `referrerpolicy` attribute.
4255         https://bugs.webkit.org/show_bug.cgi?id=179053
4256
4257         Reviewed by Darin Adler.
4258
4259         Add a runtime flag for referrerpolicy attribute.
4260
4261         * DumpRenderTree/mac/DumpRenderTree.mm:
4262         (enableExperimentalFeatures):
4263
4264 2019-03-05  Daniel Bates  <dabates@apple.com>
4265
4266         Update expected API test result following r242379
4267         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4268
4269         Update expected x-coordinate of selection rect now that the left padding of
4270         a textarea is sized in ems (so dependent on the font size) just like the left
4271         padding of a text field.
4272
4273         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4274         (TestWebKitAPI::TEST):
4275
4276 2019-03-05  David Quesada  <david_quesada@apple.com>
4277
4278         [WK2] It should be possible to follow links with 'download' attributes
4279         https://bugs.webkit.org/show_bug.cgi?id=195145
4280         rdar://problem/48462642
4281
4282         Reviewed by Alex Christensen.
4283
4284         Add a unit test to verify that activating links with 'download' attributes now
4285         navigates to the linked resource, rather than starts downloading it. Add another
4286         to verify that it is still possible to explicitly download the link via the
4287         'Download' navigation action policy.
4288
4289         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4290         (-[DownloadAttributeTestDelegate init]):
4291         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4292         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4293         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4294         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4295         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4296         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4297         (TEST):
4298         * WebKitTestRunner/TestController.cpp:
4299         (WTR::TestController::decidePolicyForNavigationAction):
4300         * WebKitTestRunner/TestController.h:
4301
4302 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4303
4304         [Curl] Implement Cookie Accept Policy.
4305         https://bugs.webkit.org/show_bug.cgi?id=191645
4306
4307         Reviewed by Fujii Hironori.
4308
4309         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4310         (TestWebKitAPI::Curl::TEST_F):
4311
4312 2019-03-05  Youenn Fablet  <youenn@apple.com>
4313
4314         Rename requestCacheStorageSpace to requestStorageSpace
4315         https://bugs.webkit.org/show_bug.cgi?id=195282
4316
4317         Reviewed by Chris Dumez.
4318
4319         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4320         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4321         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4322
4323 2019-03-05  Brady Eidson  <beidson@apple.com>
4324
4325         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4326         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4327
4328         Reviewed by Tim Horton.
4329
4330         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4331         different directory into that same WKWebView should work.
4332
4333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4334         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4335
4336 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4337
4338         Add WeakHashSet
4339         https://bugs.webkit.org/show_bug.cgi?id=195152
4340
4341         Reviewed by Antti Koivisto.
4342
4343         Added tests for WeakHashSet.
4344
4345         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4346         (TestWebKitAPI::Base::Base): Moved.
4347         (TestWebKitAPI::Derived::foo): Moved.
4348         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4349         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4350         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4351         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4352