[ews-build] Do not upload archive when Compile Fails
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Do not upload archive when Compile Fails
4         https://bugs.webkit.org/show_bug.cgi?id=196674
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/ews-build/factories.py:
9         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
10         * BuildSlaveSupport/ews-build/steps.py:
11         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
12         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
13         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
14
15 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
16
17         Enable DFG on MIPS
18         https://bugs.webkit.org/show_bug.cgi?id=196689
19
20         Reviewed by Žan Doberšek.
21
22         Since the bytecode change, we enabled the baseline JIT on mips in
23         r240432, but DFG is still missing. With this change, all tests are
24         passing on a ci20 board.
25
26         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
27
28 2019-04-08  Philippe Normand  <pnormand@igalia.com>
29
30         [Flatpak] Second run update-webkitwpe-flatpak fails
31         https://bugs.webkit.org/show_bug.cgi?id=192702
32
33         Reviewed by Carlos Garcia Campos.
34
35         * flatpak/flatpakutils.py:
36         (FlatpakObject.flatpak): Fix typo.
37         (FlatpakPackage.install): When installing, also update to the configured remote commit.
38         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
39
40 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
41
42         [GTK][WPE] outlook.live.com displays old-fashioned UI
43         https://bugs.webkit.org/show_bug.cgi?id=196642
44
45         Reviewed by Carlos Garcia Campos.
46
47         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
48         (TestWebKitAPI::TEST): New Mac platform quirk test.
49
50 2019-04-07  Commit Queue  <commit-queue@webkit.org>
51
52         Unreviewed, rolling out r243956.
53         https://bugs.webkit.org/show_bug.cgi?id=196688
54
55         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
56         by aakashjain on #webkit).
57
58         Reverted changeset:
59
60         "Clicking "Go Back" from a safe browsing warning from an
61         iframe should navigate the WKWebView back to the previous
62         page"
63         https://bugs.webkit.org/show_bug.cgi?id=196665
64         https://trac.webkit.org/changeset/243956
65
66 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
67
68         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
69         https://bugs.webkit.org/show_bug.cgi?id=196669
70
71         Reviewed by Geoffrey Garen.
72
73         Added three new unit tests for WeakHashSet.
74
75         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
76         (WTF_WeakPtr.WeakHashSetConstObjects):
77         (WTF_WeakPtr.WeakHashSetComputesEmpty):
78         (WTF_WeakPtr.WeakHashSetComputeSize):
79
80 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
81
82         Hide next and previous form control buttons when WKWebView is editable
83         https://bugs.webkit.org/show_bug.cgi?id=196672
84         <rdar://problem/35625321>
85
86         Reviewed by Tim Horton.
87
88         Add a new API test.
89
90         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
91         (-[TestWKWebView lastTrailingBarButtonGroup]):
92         (TestWebKitAPI::TEST):
93         * TestWebKitAPI/ios/UIKitSPI.h:
94
95 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
96
97         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
98         https://bugs.webkit.org/show_bug.cgi?id=196077
99         <rdar://problem/49108202>
100
101         Reviewed by Chris Dumez.
102
103         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
104         on new web view.
105
106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
107
108 2019-04-05  Saam Barati  <sbarati@apple.com>
109
110         Make compare-results understand MotionMark
111         https://bugs.webkit.org/show_bug.cgi?id=196666
112
113         Reviewed by Yusuke Suzuki.
114
115         * Scripts/compare-results:
116         (PLT5Results):
117         (detectMotionMark):
118         (detectMotionMark1_1):
119         (motionMarkResults):
120         (motionMark1_1Results):
121         (detectBenchmark):
122         (biggerIsBetter):
123         (main):
124
125 2019-04-05  Alex Christensen  <achristensen@webkit.org>
126
127         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
128         https://bugs.webkit.org/show_bug.cgi?id=196665
129         <rdar://45115669>
130
131         Reviewed by Geoff Garen.
132
133         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
134         (goBack):
135         (+[SimpleLookupContext sharedLookupContext]):
136         (-[SimpleLookupContext lookUpURL:completionHandler:]):
137         (TEST):
138         (+[Simple3LookupContext sharedLookupContext]): Deleted.
139         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
140
141 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
142
143         [ews-build] Add configuration and architecture for windows builders
144         https://bugs.webkit.org/show_bug.cgi?id=196660
145
146         Reviewed by Lucas Forschler.
147
148         * BuildSlaveSupport/ews-build/config.json:
149
150 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
151
152         webkitpy: Don't run subsequent rounds if interrupted
153         https://bugs.webkit.org/show_bug.cgi?id=196646
154
155         Reviewed by Aakash Jain.
156
157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
158         (Manager.run): Bail out if interrupted.
159
160 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
161
162         Test sessionStorage in PSON private browsing mode
163         https://bugs.webkit.org/show_bug.cgi?id=196561
164
165         Reviewed by Alex Christensen.
166
167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
168
169 2019-04-05  Commit Queue  <commit-queue@webkit.org>
170
171         Unreviewed, rolling out r243833.
172         https://bugs.webkit.org/show_bug.cgi?id=196645
173
174         This change breaks build of WPE and GTK ports (Requested by
175         annulen on #webkit).
176
177         Reverted changeset:
178
179         "[CMake][WTF] Mirror XCode header directories"
180         https://bugs.webkit.org/show_bug.cgi?id=191662
181         https://trac.webkit.org/changeset/243833
182
183 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
184
185         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
186         https://bugs.webkit.org/show_bug.cgi?id=196635
187
188         Reviewed by Antti Koivisto.
189         
190         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
191         for a test to enable async frame scrolling via:
192             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
193         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
194         
195         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
196
197         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
198         (WTR::InjectedBundle::beginTesting):
199         * WebKitTestRunner/TestController.cpp:
200         (WTR::TestController::resetPreferencesToConsistentValues):
201
202 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
203
204         Use a correct LC_RPATH when building with ASan
205         https://bugs.webkit.org/show_bug.cgi?id=196576
206
207         Reviewed by David Kilzer.
208
209         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
210         so that ../Frameworks is checked. This is simpler and more reliable than updating
211         each SPC service xcconfig.
212
213 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
214
215         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
216         https://bugs.webkit.org/show_bug.cgi?id=196629
217
218         Reviewed by Lucas Forschler.
219
220         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
221
222 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
225         https://bugs.webkit.org/show_bug.cgi?id=196618
226
227         Reviewed by Lucas Forschler.
228
229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
230         (StatusBubble): Added QUEUE_TRIGGERS.
231         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
232         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
233         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
234         its parent(builder).
235
236 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
237
238         [ews-app] Status-bubble steps are sometimes displayed in reverse order
239         https://bugs.webkit.org/show_bug.cgi?id=196625
240
241         Reviewed by Lucas Forschler.
242
243         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
244         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
245
246 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
247
248         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
249         https://bugs.webkit.org/show_bug.cgi?id=196630
250
251         Reviewed by Wenson Hsieh.
252
253         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
254
255 2019-04-04  Youenn Fablet  <youenn@apple.com>
256
257         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
258         https://bugs.webkit.org/show_bug.cgi?id=196543
259
260         Reviewed by Alex Christensen.
261
262         * WebKitTestRunner/TestController.cpp:
263         (WTR::TestController::generatePageConfiguration):
264
265 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
266
267         [ews-app] Status bubble should not display skipped buildbot steps
268         https://bugs.webkit.org/show_bug.cgi?id=196584
269
270         Reviewed by Lucas Forschler.
271
272         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
273
274 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
277         https://bugs.webkit.org/show_bug.cgi?id=196620
278
279         Reviewed by Lucas Forschler.
280
281         * BuildSlaveSupport/ews-app/ews/config.py:
282
283 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
284
285         [Win] DumpRenderTreeWatchDog.py is not checked into source
286         https://bugs.webkit.org/show_bug.cgi?id=196567
287         <rdar://problem/49525901>
288
289         Reviewed by Lucas Forschler.
290
291         This script is used on Win EWS bots to terminate hanging DRT processes.
292
293         * EWSTools/dumprendertreewatchdog.py: Added.
294
295 2019-04-04  Chris Dumez  <cdumez@apple.com>
296
297         Unreviewed, roll out r243858 which made tests time out.
298
299         Disable new API tests on Windows instead.
300
301         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
302         (TestWebKitAPI::TEST):
303
304 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
305
306         [ATK] Cleanup WebPageAccessibilityObjectAtk
307         https://bugs.webkit.org/show_bug.cgi?id=196537
308
309         Reviewed by Michael Catanzaro.
310
311         Also consider files under atk directories as exceptions for GObject conventions.
312
313         * Scripts/webkitpy/style/checkers/cpp.py:
314         (check_identifier_name_in_declaration):
315
316 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
317
318         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
319         https://bugs.webkit.org/show_bug.cgi?id=196588
320         <rdar://problem/49365787>
321
322         Unreviewed build fix for Windows port.
323
324         error C3861: 'kill': identifier not found
325
326         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
327         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
328
329 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-build] Cancel build and similar operations should have authentication
332         https://bugs.webkit.org/show_bug.cgi?id=196520
333
334         Reviewed by Dewei Zhu.
335
336         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
337         environment variables.
338
339 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
340
341         [ews-build] Do not trigger queues which are not in production yet
342         https://bugs.webkit.org/show_bug.cgi?id=196581
343
344         Reviewed by Dewei Zhu.
345
346         * BuildSlaveSupport/ews-build/config.json:
347
348 2019-04-03  Chris Dumez  <cdumez@apple.com>
349
350         Unreviewed, fix typo in the name of API test added in r243848.
351
352         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
353         (TestWebKitAPI::TEST):
354
355 2019-04-03  Chris Dumez  <cdumez@apple.com>
356
357         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
358         https://bugs.webkit.org/show_bug.cgi?id=196588
359         <rdar://problem/49365787>
360
361         Reviewed by Ryosuke Niwa.
362
363         Add API test coverage.
364
365         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
366         (TestWebKitAPI::nullJavaScriptCallback):
367         (TestWebKitAPI::didCrashCheckFrames):
368         (TestWebKitAPI::TEST):
369
370 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
371
372         run-webkit-tests: Upload test results (new results database)
373         https://bugs.webkit.org/show_bug.cgi?id=196577
374         <rdar://problem/34841155>
375
376         Reviewed by Lucas Forschler.
377
378         * Scripts/webkitpy/layout_tests/controllers/manager.py:
379         (Manager.run): Upload results after each device shard, since the configuration will be
380         different for each device.
381         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
382         uploaded to a results database.
383         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
384         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
385
386 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
387
388         -apple-trailing-word is needed for browser detection
389         https://bugs.webkit.org/show_bug.cgi?id=196575
390
391         Unreviewed.
392
393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
394
395 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
396
397         [CMake][WTF] Mirror XCode header directories
398         https://bugs.webkit.org/show_bug.cgi?id=191662
399
400         Reviewed by Konstantin Tokarev.
401
402         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
403         builds.
404
405         * CMakeLists.txt:
406         * DumpRenderTree/CMakeLists.txt:
407         * DumpRenderTree/PlatformWin.cmake:
408         * MiniBrowser/win/CMakeLists.txt:
409         * TestWebKitAPI/CMakeLists.txt:
410         * TestWebKitAPI/PlatformWin.cmake:
411         * WebKitTestRunner/PlatformGTK.cmake:
412         * WebKitTestRunner/PlatformWin.cmake:
413
414 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
415
416         [ews-app] Status bubble should not display certain infrastructure status messages
417         https://bugs.webkit.org/show_bug.cgi?id=196550
418
419         Reviewed by Lucas Forschler.
420
421         Do not display the steps which are un-needed for end-user. This information is still avaiable
422         if the user click on the bubble and look at the Buildbot build.
423         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
424         (StatusBubble._steps_messages):
425         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
426
427 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
428
429         [ews-build] Use https for sending data to ews-app
430         https://bugs.webkit.org/show_bug.cgi?id=196492
431
432         Reviewed by Lucas Forschler.
433
434         * BuildSlaveSupport/ews-build/events.py:
435
436 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
437
438         Remove support for -apple-trailing-word
439         https://bugs.webkit.org/show_bug.cgi?id=196525
440
441         Reviewed by Zalan Bujtas.
442
443         This CSS property is nonstandard and not used.
444
445         * Scripts/webkitperl/FeatureList.pm:
446         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
447
448 2019-04-03  Youenn Fablet  <youenn@apple.com>
449
450         Add a test for DOMCache on multiple browsing in case of private browsing
451         https://bugs.webkit.org/show_bug.cgi?id=196524
452
453         Reviewed by Alex Christensen.
454
455         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
456         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
457
458 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
459
460         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
461         https://bugs.webkit.org/show_bug.cgi?id=196540
462
463         Reviewed by Aakash Jain.
464
465         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
466
467 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
468
469         Add plumbing for a compatibility mode preference in WebKit
470         https://bugs.webkit.org/show_bug.cgi?id=196005
471
472         Reviewed by Tim Horton.
473
474         Add new API tests.
475
476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
477         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
478
479 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
480
481         [WPE][GTK] Update libsrtp dependency package for Debian
482         https://bugs.webkit.org/show_bug.cgi?id=196528
483
484         Reviewed by Frédéric Wang.
485
486         * gtk/install-dependencies:
487         * wpe/install-dependencies:
488
489 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
490
491         [WK2] Add support for Window's beforeprint / afterprint events
492         https://bugs.webkit.org/show_bug.cgi?id=196478
493         <rdar://problem/49535124>
494
495         Unreviewed build fix for MSVC.
496
497         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
498
499         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
500
501         * WebKitTestRunner/TestController.cpp:
502         (WTR::printFrame): Use int and float literals.
503
504 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
505
506         [ews-build] Reassign bots to queues
507
508         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
509
510 2019-04-02  Chris Dumez  <cdumez@apple.com>
511
512         [WK2] Add support for Window's beforeprint / afterprint events
513         https://bugs.webkit.org/show_bug.cgi?id=196478
514
515         Reviewed by Alex Christensen.
516
517         Add minimal implementation for printFrame in WebKitTestRunner.
518
519         * WebKitTestRunner/TestController.cpp:
520         (WTR::printFrame):
521         (WTR::TestController::createOtherPage):
522         (WTR::TestController::createWebViewWithOptions):
523
524 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
525
526         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
527         https://bugs.webkit.org/show_bug.cgi?id=196491
528
529         Reviewed by Lucas Forschler.
530
531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
532
533 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
534
535         [ews-build] Configure buildbot try credentials in environment variables
536         https://bugs.webkit.org/show_bug.cgi?id=196501
537
538         Reviewed by Lucas Forschler.
539
540         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
541         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
542         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
543
544 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
545
546         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
547         https://bugs.webkit.org/show_bug.cgi?id=196496
548         <rdar://problem/49521634>
549
550         Reviewed by Chris Dumez.
551
552         Add new API tests (see WebKit ChangeLog for more detail).
553
554         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
555         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
556         (TEST):
557
558 2019-04-02  David Kilzer  <ddkilzer@apple.com>
559
560         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
561         <https://webkit.org/b/196499>
562
563         Reviewed by Alexey Proskuryakov.
564
565         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
566         ENABLE_ADDRESS_SANITIZER.
567
568 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
569
570         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
571         https://bugs.webkit.org/show_bug.cgi?id=182757
572
573         Reviewed by Don Olmstead.
574
575         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
576         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
577
578 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
579
580         run-api-tests: Upload test results
581         https://bugs.webkit.org/show_bug.cgi?id=196323
582         <rdar://problem/49356714>
583
584         Reviewed by Lucas Forschler.
585
586         * Scripts/webkitpy/api_tests/manager.py:
587         (Manager):
588         (Manager.run): Upload results to a results database.
589         * Scripts/webkitpy/api_tests/run_api_tests.py:
590         (parse_args): Add upload arguments.
591         * Scripts/webkitpy/port/base.py:
592         (Port):
593         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
594         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
595         with commits from any other associated repositories.
596         * Scripts/webkitpy/port/device.py:
597         (Device):
598         (Device.build_version): Access build_versoin of underlying platform device.
599         * Scripts/webkitpy/port/ios_simulator_unittest.py:
600         (IOSSimulatorTest):
601         (IOSSimulatorTest.test_configuration_for_upload):
602         * Scripts/webkitpy/port/device_port.py:
603         (DevicePort):
604         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
605         the same as the machine uploading results.
606         * Scripts/webkitpy/port/mac.py:
607         (MacPort):
608         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
609         * Scripts/webkitpy/port/mac_unittest.py:
610         (MacTest):
611         (MacTest.test_configuration_for_upload):
612         * Scripts/webkitpy/xcode/simulated_device.py:
613         (SimulatedDeviceManager._create_device_with_runtime):
614         (SimulatedDevice.__init__): Create simulated device with a build_version.
615         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
616         (test_existing_simulator):
617
618 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
619
620         Remove extra newline characters (Follow-up fix to r243707)
621
622         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
623
624 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
625
626         [ews-app] Use API_KEY to accept results data
627         https://bugs.webkit.org/show_bug.cgi?id=196461
628
629         Reviewed by Dewei Zhu.
630
631         * BuildSlaveSupport/ews-app/ews/views/results.py:
632         (Results.post): Validate EWS_API_KEY before accepting any data.
633         * BuildSlaveSupport/ews-build/events.py:
634         (Events.sendData): Send EWS_API_KEY if available along with event data.
635
636 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
637
638         Unable to copy and paste a PDF from Notes into Mail compose body
639         https://bugs.webkit.org/show_bug.cgi?id=196442
640         <rdar://problem/48573098>
641
642         Reviewed by Tim Horton.
643
644         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
645         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
646         to be specified on the item providers.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
649         (TestWebKitAPI::mapItemForTesting):
650         (TestWebKitAPI::contactItemForTesting):
651
652 2019-04-01  Tim Horton  <timothy_horton@apple.com>
653
654         Make UIWKDocumentContext rects per-character instead of per-word
655         https://bugs.webkit.org/show_bug.cgi?id=196459
656
657         Reviewed by Wenson Hsieh.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
660         (TEST):
661         Adjust test results due to switching to per-character rects.
662
663 2019-04-01  Chris Dumez  <cdumez@apple.com>
664
665         UIProcess crash when a prewarmed process is terminated
666         https://bugs.webkit.org/show_bug.cgi?id=196451
667         <rdar://problem/49245471>
668
669         Reviewed by Geoffrey Garen.
670
671         Add API test coverage.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
674         (TEST):
675
676 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
677
678         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
679         https://bugs.webkit.org/show_bug.cgi?id=196449
680
681         Reviewed by Lucas Forschler.
682
683         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
684         (StatusBubble.get_os_details): Method to get OS and Xcode details.
685         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
686         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
687
688 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
689
690         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
691         https://bugs.webkit.org/show_bug.cgi?id=196444
692
693         Reviewed by Lucas Forschler.
694
695         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
696
697 2019-04-01  Alex Christensen  <achristensen@webkit.org>
698
699         Add SPI to canonicalize NSURLs with WTF::URL
700         https://bugs.webkit.org/show_bug.cgi?id=196415
701         <rdar://problem/44980271>
702
703         Reviewed by Darin Adler.
704
705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
707         (TestWebKitAPI::TEST):
708
709 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
710
711         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
712         https://bugs.webkit.org/show_bug.cgi?id=196441
713
714         Reviewed by Carlos Garcia Campos.
715
716         Don't cache the wpe_view_backend object that might not exist yet at the
717         time of EventSenderProxy constructor invocation, but instead retrieve
718         that object whenever it's required for event dispatching. This should
719         avoid crashes in this constructor now that it's invoked before any
720         PlatformWindow has been set up (as changed in r243496).
721
722         * WebKitTestRunner/EventSenderProxy.h:
723         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
724         (WTR::viewBackend):
725         (WTR::EventSenderProxy::EventSenderProxy):
726         (WTR::EventSenderProxy::mouseDown):
727         (WTR::EventSenderProxy::mouseUp):
728         (WTR::EventSenderProxy::mouseMoveTo):
729         (WTR::EventSenderProxy::mouseScrollBy):
730         (WTR::EventSenderProxy::keyDown):
731         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
732
733 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
734
735         [Win][WebKit] MiniBrowser should support high DPI display
736         https://bugs.webkit.org/show_bug.cgi?id=196391
737
738         Reviewed by Alex Christensen.
739
740         * MiniBrowser/win/WebKitBrowserWindow.cpp:
741         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
742         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
743         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
744
745 2019-03-31  Sam Weinig  <weinig@apple.com>
746
747         Remove more i386 specific configurations
748         https://bugs.webkit.org/show_bug.cgi?id=196430
749
750         Reviewed by Alexey Proskuryakov.
751
752         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
753         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
754
755 2019-03-31  Andy Estes  <aestes@apple.com>
756
757         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
758         https://bugs.webkit.org/show_bug.cgi?id=196433
759         <rdar://problem/49293305>
760
761         Reviewed by Tim Horton.
762
763         Enhanced API test coverage to include all navigation response policy decisions in both
764         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
765
766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
767         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
768         (TestWebKitAPI::TEST):
769         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
770         (readFile):
771         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
772         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
773         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
774         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
775         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
776         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
777         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
778         (-[QuickLookDelegate _downloadDidStart:]):
779         (-[QuickLookDelegate _download:didReceiveResponse:]):
780         (-[QuickLookDelegate _download:didReceiveData:]):
781         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
782         (-[QuickLookDelegate _downloadDidFinish:]):
783         (-[QuickLookDelegate _download:didFailWithError:]):
784         (-[QuickLookDelegate _downloadDidCancel:]):
785         (-[QuickLookDelegate verifyDownload]):
786         (runTest):
787         (runTestDecideBeforeLoading):
788         (runTestDecideAfterLoading):
789         (TEST):
790         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
791         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
792         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
793         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
794         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
795         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
796         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
797         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
798         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
799         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
800         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
801         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
802         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
803         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
804
805 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
806
807         [CMake] add testdfg as target with build-jsc
808         https://bugs.webkit.org/show_bug.cgi?id=196393
809
810         Reviewed by Saam Barati.
811
812         Added testdfg as one of the targets to build when
813         using CMake.
814
815         * Scripts/build-jsc:
816
817 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
818
819         Delete WebMetal implementation in favor of WebGPU
820         https://bugs.webkit.org/show_bug.cgi?id=195418
821
822         Reviewed by Dean Jackson.
823
824         * DumpRenderTree/mac/DumpRenderTree.mm:
825         (enableExperimentalFeatures):
826         (resetWebPreferencesToConsistentValues):
827         * Scripts/webkitperl/FeatureList.pm:
828         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
830         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
831         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
832         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
833         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
834         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
835         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
836         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
837         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
838         (WTR::InjectedBundle::beginTesting):
839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
840         (WTR::TestRunner::setWebMetalEnabled): Deleted.
841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
842
843 2019-03-29  Chris Dumez  <cdumez@apple.com>
844
845         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
846         https://bugs.webkit.org/show_bug.cgi?id=196405
847         <rdar://problem/49428130>
848
849         Reviewed by Wenson Hsieh.
850
851         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
852         the popover presentation methods to be no-ops. Use this in the new test added in
853         r243523 so that we do not swizzle those methods for all tests. This is needed because
854         those WatchOS tests rely on the popover getting presented and interactive.
855
856         * WebKitTestRunner/TestController.cpp:
857         (WTR::updateTestOptionsFromTestHeader):
858         * WebKitTestRunner/TestController.h:
859         * WebKitTestRunner/TestOptions.h:
860         (WTR::TestOptions::hasSameInitializationOptions const):
861         * WebKitTestRunner/ios/TestControllerIOS.mm:
862         (WTR::TestController::platformInitialize):
863         (WTR::TestController::platformResetStateToConsistentValues):
864
865 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
866
867         [Curl] Add Server Trust Evaluation Support.
868         https://bugs.webkit.org/show_bug.cgi?id=191646
869
870         Reviewed by Fujii Hironori.
871
872         Implemented MiniBrowser UI for asking if user trusts the server.
873
874         * MiniBrowser/win/Common.cpp:
875         (askServerTrustEvaluation):
876         (replaceString):
877         * MiniBrowser/win/Common.h:
878         * MiniBrowser/win/MiniBrowserLib.rc:
879         * MiniBrowser/win/MiniBrowserLibResource.h:
880         * MiniBrowser/win/WebKitBrowserWindow.cpp:
881         (createPEMString):
882         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
883         (WebKitBrowserWindow::canTrustServerCertificate):
884         * MiniBrowser/win/WebKitBrowserWindow.h:
885
886 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
887
888         Implement ResizeObserver.
889         https://bugs.webkit.org/show_bug.cgi?id=157743
890
891         Reviewed by Simon Fraser.
892
893         Support resizeObserverEnabled webPreferences.
894
895         * DumpRenderTree/TestOptions.cpp:
896         (TestOptions::TestOptions):
897         * DumpRenderTree/TestOptions.h:
898         * DumpRenderTree/mac/DumpRenderTree.mm:
899         (setWebPreferencesForTestOptions):
900         * DumpRenderTree/win/DumpRenderTree.cpp:
901         (enableExperimentalFeatures):
902         * Scripts/webkitperl/FeatureList.pm:
903         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
904
905 2019-03-28  John Wilander  <wilander@apple.com>
906
907         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
908         https://bugs.webkit.org/show_bug.cgi?id=196281
909         <rdar://problem/48938748>
910
911         Reviewed by Alex Christensen.
912
913         This patch adds the function isStatisticsHasLocalStorage() to the
914         TestRunner. With it, the page can query the WebsiteDataStore in the
915         UI process to make sure that it sees LocalStorage.
916
917         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
919         (WTR::TestRunner::isStatisticsHasLocalStorage):
920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
921         * WebKitTestRunner/TestController.cpp:
922         (WTR::TestController::isStatisticsHasLocalStorage):
923         * WebKitTestRunner/TestController.h:
924         * WebKitTestRunner/TestInvocation.cpp:
925         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
926
927 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
928
929         API::Data::createWithoutCopying should do a null check before calling CFRelease
930         https://bugs.webkit.org/show_bug.cgi?id=196276
931         <rdar://problem/48059859>
932
933         Reviewed by Alex Christensen.
934
935         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
936
937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
938         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
939         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
940         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
941         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
942         (TestWebKitAPI::TEST):
943
944 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
945
946         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
947         https://bugs.webkit.org/show_bug.cgi?id=186276
948
949         Reviewed by Carlos Garcia Campos.
950
951         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
952         (webViewLoadChanged):
953         (testWebResourceGetDataError):
954         (testWebResourceGetDataEmpty):
955         (beforeAll):
956         (webViewloadChanged): Deleted.
957
958 2019-03-27  Andy Estes  <aestes@apple.com>
959
960         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
961         https://bugs.webkit.org/show_bug.cgi?id=196317
962
963         Reviewed by Dan Bernstein.
964
965         package-root copies built products into a staging directory using ditto(1), which does not
966         follow symbolic links as it traverses a directory. Now that the files in
967         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
968         itself, these become broken links when ditto'd into the staging directory.
969
970         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
971
972         * Scripts/package-root:
973
974 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-app] Update display text of Submit for ews analysis
977         https://bugs.webkit.org/show_bug.cgi?id=196309
978
979         Reviewed by Dewei Zhu.
980
981         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
982
983 2019-03-27  David Kilzer  <ddkilzer@apple.com>
984
985         run-webkit-tests should check for leaks in WebKit processes
986         <https://webkit.org/b/193772>
987         <rdar://problem/46526680>
988
989         Reviewed by Ryosuke Niwa.
990
991         This works by doing the following:
992         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
993           The list of child processes are returned one per line:
994           process.name: pid
995         - Run the "#LIST CHILD PROCESSES" command just before the
996           "#CHECK FOR WORLD LEAKS" command, and store the list of child
997           processes on the ServerProcess object.
998         - When the `--leaks` switch is handled, run check_for_leaks() on
999           each child process after the main test harness.
1000
1001         * DumpRenderTree/mac/DumpRenderTree.mm:
1002         (handleControlCommand):
1003         - Use strncmp() instead of strcmp().
1004         - Add support for handling "#LIST CHILD PROCESSES" command.
1005
1006         * Scripts/webkitpy/port/base.py:
1007         (Port.check_for_leaks):
1008         * Scripts/webkitpy/port/darwin.py:
1009         (DarwinPort.check_for_leaks):
1010         - Rename redundant 'process_pid' argument to 'process_id'.
1011
1012         * Scripts/webkitpy/port/driver.py:
1013         (Driver.do_post_tests_work):
1014         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1015           longer the only command this sends to WebKitTestRunner.
1016         - If the `--leaks` switch is present, send the
1017           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1018           result using Port.set_webkit_processes().
1019         (Driver._parse_child_processes_output):
1020         - Add helper method to parse list of child process names and
1021           process IDs returned from WebKitTestRunner.
1022
1023         * Scripts/webkitpy/port/ios_device.py:
1024         (IOSDevicePort.check_for_leaks):
1025         - Rename redundant 'process_pid' argument to 'process_id'.
1026
1027         * Scripts/webkitpy/port/leakdetector.py:
1028         (LeakDetector._parse_leaks_output):
1029         - Return early if there is no leaks_output.
1030         (LeakDetector.check_for_leaks):
1031         - Rename redundant 'process_pid' argument to 'process_id'.
1032
1033         * Scripts/webkitpy/port/server_process.py:
1034         (ServerProcess.__init__):
1035         (ServerProcess.child_processes):
1036         (ServerProcess.set_child_processes):
1037         - Add instance variable to Port to store list of child process
1038           names and process IDs returned from WebKitTestRunner.
1039         (ServerProcess._start):
1040         - Clear self._child_processes.
1041         (ServerProcess.stop):
1042         - If self._child_processes is set, call
1043           self._port.check_for_leaks() for each child process.
1044
1045         * Scripts/webkitpy/port/server_process_unittest.py:
1046         (TrivialMockPort.check_for_leaks):
1047         - Rename redundant 'process_pid' argument to 'process_id'.
1048
1049         * Scripts/webkitpy/port/simulator_process.py:
1050         (SimulatorProcess.stop):
1051         - If self._child_processes is set, call
1052           self._port.check_for_leaks() for each child process.
1053
1054         * Scripts/webkitpy/port/watch_device.py:
1055         (WatchDevicePort.check_for_leaks):
1056         - Rename redundant 'process_pid' argument to 'process_id'.
1057
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::TestController::dumpResponse):
1060         - Extract method from findAndDumpWorldLeaks() so that it may be
1061           reused by findAndDumpWebKitProcessIdentifiers().
1062         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1063         - Add method to output process name and process ID of both the
1064           WebContent and Networking processes.
1065         (WTR::TestController::findAndDumpWorldLeaks):
1066         - Fix missing newline in output when there were no abandoned
1067           documents.
1068         - Call dumpResponse() for extracted code.
1069         (WTR::TestController::handleControlCommand):
1070         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1071         - Use strncmp() instead of strcmp().
1072         - Call findAndDumpWebKitProcessIdentifiers() when
1073           "#LIST CHILD PROCESSES" command is sent.
1074         * WebKitTestRunner/TestController.h:
1075         (WTR::TestController::dumpResponse):
1076         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1077         - Declare methods.
1078
1079 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1080
1081         Unreviewed. Add GLib API test cases after r243434.
1082
1083         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1084         (testWebViewActiveURI):
1085         (serverCallback):
1086         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1087         (sendRequestCallback):
1088
1089 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1090
1091         Geolocation request not complete when watch request was started in a different web process
1092         https://bugs.webkit.org/show_bug.cgi?id=195996
1093
1094         Reviewed by Alex Christensen.
1095
1096         Add a test case.
1097
1098         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1099         (TestWebKitAPI::runJavaScriptAlert):
1100         (TestWebKitAPI::TEST):
1101
1102 2019-03-26  Keith Rollin  <krollin@apple.com>
1103
1104         Update the way generate-xcfilelists returns strings from functions
1105         https://bugs.webkit.org/show_bug.cgi?id=195975
1106         <rdar://problem/49040807>
1107
1108         Reviewed by Dean Jackson.
1109
1110         There are places where generate-xcfilelists executes assignments with
1111         statements like:
1112
1113             FOO=$(some_function)
1114
1115         where "some_function" return a string by echoing it. E.g.
1116
1117             some_function()
1118             {
1119                 echo "Hello, World"
1120             }
1121
1122         This is a common idiom, but it has a problem if "some_function" needs
1123         to call "exit" in an attempt to halt the entire script right then and
1124         there. Since "some_function" is called inside of $(), it's being
1125         executed in a sub-shell. Calling exit in that sub-shell simply exits
1126         that shell; it doesn't not exit the outer shell in which the main part
1127         of the script is still running. As such, the main script keeps
1128         executing when the intent was for the script to halt.
1129
1130         The solution to this is to use a different idiom for returning
1131         strings. The one we now is to pass in the name of the variable to
1132         receive the string result:
1133
1134             some_function()
1135             {
1136                 variable_name=$1
1137                 eval $variable_name ="Hello, World"
1138             }
1139
1140         The call site now looks like
1141
1142             some_function FOO
1143
1144         Because there's no invocation of a sub-shell, some_function can now
1145         call "exit" if it wants to, and the entire script will exit at that
1146         point.
1147
1148         * Scripts/generate-xcfilelists:
1149
1150 2019-03-26  Chris Dumez  <cdumez@apple.com>
1151
1152         Add basic layout test coverage for File Picker on iOS
1153         https://bugs.webkit.org/show_bug.cgi?id=196265
1154
1155         Reviewed by Wenson Hsieh.
1156
1157         Add layout test infrastructure to test the file picker on iOS.
1158
1159         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1160         (WTR::UIScriptController::dismissFilePicker):
1161         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1162         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1163         (WTR::UIScriptController::dismissFilePicker):
1164         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::TestController::createWebViewWithOptions):
1167         (WTR::updateTestOptionsFromTestHeader):
1168         * WebKitTestRunner/TestOptions.h:
1169         (WTR::TestOptions::hasSameInitializationOptions const):
1170         * WebKitTestRunner/ios/TestControllerIOS.mm:
1171         (overridePresentViewController):
1172         (WTR::TestController::platformInitialize):
1173         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1174         (WTR::UIScriptController::dismissFilePicker):
1175
1176 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1177
1178         Implement async paste method on UIWKInteractionViewProtocol
1179         https://bugs.webkit.org/show_bug.cgi?id=196267
1180         <rdar://problem/49236346>
1181
1182         Reviewed by Tim Horton.
1183
1184         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1185         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1186         are now a part of all iOS 12 internal SDKs.
1187
1188         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1189
1190         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1191         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1192
1193         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1194         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1195         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1196         * TestWebKitAPI/ios/UIKitSPI.h:
1197
1198 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1199
1200         [ews-build] Use PostgreSQL for ews.webkit.org database
1201         https://bugs.webkit.org/show_bug.cgi?id=196270
1202
1203         Reviewed by Lucas Forschler.
1204
1205         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1206
1207 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1208
1209         [ews] Reset simctl states on reboot
1210         https://bugs.webkit.org/show_bug.cgi?id=196260
1211
1212         Rubber-stamped by Aakash Jain.
1213
1214         * EWSTools/start-queue-mac.sh:
1215
1216 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [ews-build] Use PostgreSQL for ews-build database
1219         https://bugs.webkit.org/show_bug.cgi?id=196229
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * BuildSlaveSupport/ews-build/master.cfg:
1224
1225 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1226
1227         [ews-build] Get master_hostname dynamically in master.cfg
1228         https://bugs.webkit.org/show_bug.cgi?id=196255
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1233         send events data in test mode.
1234
1235 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1236
1237         [ews-app] Set db_constraint to False for Foreign Keys
1238         https://bugs.webkit.org/show_bug.cgi?id=196252
1239
1240         Reviewed by Lucas Forschler.
1241
1242         * BuildSlaveSupport/ews-app/ews/models/build.py:
1243         * BuildSlaveSupport/ews-app/ews/models/step.py:
1244
1245 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1246
1247         [ews-build] is_test_mode_enabled should default to True
1248         https://bugs.webkit.org/show_bug.cgi?id=196248
1249
1250         Reviewed by Lucas Forschler.
1251
1252         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1253
1254 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1255
1256         [ews-app] Add webkitperl to ENABLED_QUEUES
1257         https://bugs.webkit.org/show_bug.cgi?id=196253
1258
1259         Reviewed by Lucas Forschler.
1260
1261         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1262
1263 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1264
1265         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1266         https://bugs.webkit.org/show_bug.cgi?id=196211
1267         rdar://problem/49110552
1268
1269         Reviewed by Tim Horton.
1270
1271         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1272         Make sure that EventSenderProxy always exists when running tests. We used to create
1273         it when resetting before the first test, which is a bit too late.
1274
1275         * WebKitTestRunner/TestController.h:
1276         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1277         (WTR::TestController::platformCreateWebView):
1278         (WTR::TestController::platformCreateOtherPage):
1279         (WTR::TestController::finishCreatingPlatformWebView):
1280         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1281         (WTR::PlatformWebView::PlatformWebView):
1282         Moved some code that made NSWindow use NSEvent during web view creation. We may
1283         need to move more if some other case us found, but this is enough for now.
1284
1285 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1286
1287         Unreviewed. Fix typo in GLib geolocation API after r243285.
1288
1289         gelocation -> geolocation.
1290
1291         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1292         (testGeolocationManagerWatchPosition):
1293
1294 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1295
1296         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1297         https://bugs.webkit.org/show_bug.cgi?id=196213
1298
1299         Reviewed by Geoff Garen.
1300
1301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1302         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1303         (credentialWithIdentityAndKeychainPath):
1304         (-[ChallengeDelegate webView:didFinishNavigation:]):
1305         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1306         (TestWebKitAPI::TEST):
1307
1308 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1309
1310         Expected shouldn't assume its contained types are copyable
1311         https://bugs.webkit.org/show_bug.cgi?id=195986
1312
1313         Reviewed by JF Bastien.
1314
1315         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1316         (TestWebKitAPI::NonCopyable::operator== const):
1317         (TestWebKitAPI::NonCopyable::operator!= const):
1318         (TestWebKitAPI::TEST):
1319
1320 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1321
1322         Remove some now-unnecessary dynamic class lookup
1323         https://bugs.webkit.org/show_bug.cgi?id=196237
1324
1325         Reviewed by Simon Fraser.
1326
1327         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1328         (makeRequest):
1329         (TEST):
1330
1331 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1332
1333         Unreviewed, rolling out r243450.
1334
1335         AppleWin and WinCairo port builds get broken.
1336
1337         Reverted changeset:
1338
1339         "Add test for fix of #196095"
1340         https://bugs.webkit.org/show_bug.cgi?id=196097
1341         https://trac.webkit.org/changeset/243450
1342
1343 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1344
1345         Unreviewed, rolling out r243465.
1346         https://bugs.webkit.org/show_bug.cgi?id=196226
1347
1348         the test doesn't build (Requested by thorton on #webkit).
1349
1350         Reverted changeset:
1351
1352         "Do not terminate the NetworkProcess if a third party
1353         application sends a NSCredential with a SecIdentityRef"
1354         https://bugs.webkit.org/show_bug.cgi?id=196213
1355         https://trac.webkit.org/changeset/243465
1356
1357 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1358
1359         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1360         https://bugs.webkit.org/show_bug.cgi?id=196213
1361
1362         Reviewed by Geoff Garen.
1363
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1366         (credentialWithIdentityAndKeychainPath):
1367         (-[ChallengeDelegate webView:didFinishNavigation:]):
1368         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1369         (TestWebKitAPI::TEST):
1370
1371 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1372
1373         [ews-build] Gracefully handle missing patch_id in events
1374         https://bugs.webkit.org/show_bug.cgi?id=196216
1375
1376         Reviewed by Lucas Forschler.
1377
1378         * BuildSlaveSupport/ews-build/events.py:
1379
1380 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1381
1382         [ews-build] use lz4 compression for improving buildbot performance
1383         https://bugs.webkit.org/show_bug.cgi?id=196155
1384
1385         Reviewed by Lucas Forschler.
1386
1387         * BuildSlaveSupport/ews-build/master.cfg:
1388
1389 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1390
1391         Pull some API testing helper methods out of TestWKWebView
1392         https://bugs.webkit.org/show_bug.cgi?id=196212
1393
1394         Reviewed by Tim Horton.
1395
1396         Refactor some more API testing utility methods, so that they can be used in
1397         tests that do not use TestWKWebView.
1398
1399         * TestWebKitAPI/cocoa/TestWKWebView.h:
1400         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1401         (-[WKWebView loadTestPageNamed:]):
1402         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1403         (-[WKWebView synchronouslyLoadHTMLString:]):
1404         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1405         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1406         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1407         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1408         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1409
1410 2019-03-25  Jer Noble  <jer.noble@apple.com>
1411
1412         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1413         https://bugs.webkit.org/show_bug.cgi?id=196097
1414
1415         Reviewed by Eric Carlson.
1416
1417         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1418
1419         * DumpRenderTree/mac/DumpRenderTree.mm:
1420         (resetWebPreferencesToConsistentValues):
1421         * WebKitTestRunner/TestController.cpp:
1422         (WTR::TestController::resetPreferencesToConsistentValues):
1423
1424 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1425
1426         Pull IPadUserInterfaceSwizzler out into a separate header file
1427         https://bugs.webkit.org/show_bug.cgi?id=196193
1428
1429         Reviewed by Anders Carlsson.
1430
1431         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1432         be used in other API tests.
1433
1434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1435         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1436         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1437         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1438         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1439         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1440         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1441
1442 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1443
1444         Remove NavigatorContentUtils in WebCore/Modules
1445         https://bugs.webkit.org/show_bug.cgi?id=196070
1446
1447         Reviewed by Alex Christensen.
1448
1449         NavigatorContentUtils was to support the custom scheme spec [1].
1450         However, in WebKit side, no port has supported the feature in
1451         WebKit layer after EFL port was removed. So there has been the
1452         only IDL implementation of the NavigatorContentUtils in WebCore.
1453         So we don't need to keep the implementation in WebCore anymore.
1454
1455         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1456
1457         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1458
1459 2019-03-24  Andy Estes  <aestes@apple.com>
1460
1461         [watchOS] Remove unused Proximity Networking code
1462         https://bugs.webkit.org/show_bug.cgi?id=196188
1463
1464         Reviewed by Tim Horton.
1465
1466         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1467         (TEST):
1468
1469 2019-03-23  Keith Miller  <keith_miller@apple.com>
1470
1471         Refactor clz/ctz and fix getLSBSet.
1472         https://bugs.webkit.org/show_bug.cgi?id=196162
1473
1474         Reviewed by Saam Barati.
1475
1476         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1477
1478         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1479         (TestWebKitAPI::TEST):
1480
1481 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1482
1483         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1484         https://bugs.webkit.org/show_bug.cgi?id=196143
1485
1486         Reviewed by Michael Catanzaro.
1487
1488         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1489         directories.
1490
1491         * Scripts/webkitpy/style/checkers/cpp.py:
1492         (check_identifier_name_in_declaration):
1493         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1494         (WebKitStyleTest.test_names):
1495
1496 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1497
1498         [Flatpak] Manifest expanding fails for qt WPE extension
1499         https://bugs.webkit.org/show_bug.cgi?id=196148
1500
1501         Reviewed by Alex Christensen.
1502
1503         * flatpak/flatpakutils.py:
1504         (expand_submodules_recurse): The last recurse manifest expand
1505         iteration might lead to a single module so take it into account
1506         and don't try to recurse further.
1507
1508 2019-03-22  Chris Dumez  <cdumez@apple.com>
1509
1510         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1511         https://bugs.webkit.org/show_bug.cgi?id=195348
1512         <rdar://problem/48622090>
1513
1514         Reviewed by Alex Christensen.
1515
1516         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1517         to NO when test.options().shouldIgnoreMetaViewport is false.
1518
1519         * WebKitTestRunner/ios/TestControllerIOS.mm:
1520         (WTR::TestController::platformConfigureViewForTest):
1521
1522 2019-03-22  Chris Dumez  <cdumez@apple.com>
1523
1524         Prewarmed processes should be usable with any website data store
1525         https://bugs.webkit.org/show_bug.cgi?id=196104
1526
1527         Reviewed by Alex Christensen.
1528
1529         Add API test coverage.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1532         (runInitialWarmedProcessUsedTest):
1533         (TEST):
1534
1535 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1536
1537         Back out local changes to Alex's Subversion working directory
1538
1539         They were accidentally committed.
1540
1541         * Scripts/webkitpy/common/system/abstractexecutive.py:
1542         (AbstractExecutive.wait_newest):
1543         * Scripts/webkitpy/common/system/executive.py:
1544         (Executive.running_pids):
1545         * Scripts/webkitpy/common/system/executive_mock.py:
1546         (MockExecutive.running_pids):
1547         * Scripts/webkitpy/common/system/executive_unittest.py:
1548         (ExecutiveTest.serial_test_running_pids):
1549         * Scripts/webkitpy/port/darwin.py:
1550         (DarwinPort.check_for_leaks):
1551         * Scripts/webkitpy/port/leakdetector.py:
1552         (LeakDetector.check_for_leaks):
1553         - This was the hack attached to Bug 193772.
1554
1555         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1556         (+[WebKitTestRunnerEvent mouseLocation]):
1557         - This works around a crash on an internal build.
1558
1559 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1560
1561         Fix the build after r243354
1562         https://bugs.webkit.org/show_bug.cgi?id=196138
1563         <rdar://problem/49145951>
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1566         (TEST):
1567         * TestWebKitAPI/ios/UIKitSPI.h:
1568
1569 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1570
1571         Adopt UIWKDocumentContext
1572         https://bugs.webkit.org/show_bug.cgi?id=196040
1573         <rdar://problem/48642440>
1574
1575         Reviewed by Ryosuke Niwa.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1579         (makeRequest):
1580         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1581         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1582         (applyStyle):
1583         (TEST):
1584         Add tests for UIWKDocumentContext.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1587         (TEST):
1588         (recursiveFindWKContentView): Deleted.
1589         * TestWebKitAPI/cocoa/TestWKWebView.h:
1590         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1591         (recursiveFindWKContentView):
1592         (-[TestWKWebView wkContentView]):
1593         * TestWebKitAPI/ios/UIKitSPI.h:
1594         Share the WKContentView finding code between tests.
1595
1596 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1597
1598         [iOS WK2] Turn on async overflow scrolling by default
1599         https://bugs.webkit.org/show_bug.cgi?id=196011
1600         rdar://problem/48453859
1601
1602         Reviewed by Antti Koivisto.
1603         
1604         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1605         since so many basic layout tests have different results when compositing is triggered for
1606         overflow.
1607         
1608         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1609
1610         * WebKitTestRunner/TestController.cpp:
1611         (WTR::TestController::resetPreferencesToConsistentValues):
1612
1613 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1614
1615         [ews-build] Retry API test in case of failures
1616         https://bugs.webkit.org/show_bug.cgi?id=196004
1617
1618         Reviewed by Lucas Forschler.
1619
1620         * BuildSlaveSupport/ews-build/steps.py:
1621         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1622         (CompileWebKitToT.doStepIf): Ditto.
1623         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1624         (ReRunAPITests): Re-run API tests.
1625         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1626         (RunAPITestsWithoutPatch): Run API tests without patch.
1627         (RunAPITestsWithoutPatch.doStepIf):
1628         (RunAPITestsWithoutPatch.hideStepIf):
1629         (RunAPITestsWithoutPatch.evaluateCommand):
1630         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1631         (AnalyzeAPITestsResults.start):
1632         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1633         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1634         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1635         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1636
1637 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1638
1639         [ews-build] Update queues configurations
1640         https://bugs.webkit.org/show_bug.cgi?id=196074
1641
1642         Reviewed by Dewei Zhu.
1643
1644         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1645         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1646
1647 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1648
1649         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1650         https://bugs.webkit.org/show_bug.cgi?id=195680
1651         <rdar://problem/48903534>
1652
1653         Unreviewed infrastructure fix.
1654
1655         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1656         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1657
1658 2019-03-21  Andy Estes  <aestes@apple.com>
1659
1660         [iOS] Apple Pay should be available in documents with no user agent scripts
1661         https://bugs.webkit.org/show_bug.cgi?id=196061
1662         <rdar://problem/48649391>
1663
1664         Reviewed by Brady Eidson.
1665
1666         Added API tests and related infrastructure.
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1669         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1670         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1671         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1672         (TestWebKitAPI::TEST):
1673         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1674         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1675         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1676         * TestWebKitAPI/cocoa/TestProtocol.mm:
1677         (-[TestProtocol startLoading]):
1678         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1679         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1680         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1681         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1682
1683 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1684
1685         REGRESSSION (r243297): webkitpy tests broken
1686         https://bugs.webkit.org/show_bug.cgi?id=196108
1687
1688         Reviewed by Aakash Jain.
1689
1690         r243297 updated contributors.json, which broke a few unit tests.
1691
1692         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1693         (IRCCommandTest.test_whois):
1694         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1695
1696 2019-03-21  Chris Dumez  <cdumez@apple.com>
1697
1698         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1699         https://bugs.webkit.org/show_bug.cgi?id=196041
1700         <rdar://problem/49083230>
1701
1702         Reviewed by Alex Christensen.
1703
1704         Add API test coverage.
1705
1706         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1707         (TEST):
1708
1709 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1710
1711         Add SPI to inform applications of WKContentRuleList actions
1712         https://bugs.webkit.org/show_bug.cgi?id=195965
1713         <rdar://problem/42664365>
1714
1715         Reviewed by Geoff Garen.
1716
1717         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1718         (TestWebKitAPI::allActionsForResourceLoad):
1719         (TestWebKitAPI::testRequest):
1720         (TestWebKitAPI::TEST_F):
1721         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1722         (Notification::description):
1723         (Notification::operator== const):
1724         (toVector):
1725         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1726         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1727         (makeContentRuleList):
1728         (TEST):
1729         (makeWarnContentRuleList): Deleted.
1730
1731 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1732
1733         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1734         https://bugs.webkit.org/show_bug.cgi?id=196088
1735
1736         Reviewed by Brian Burg.
1737
1738         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1739         Support checks when only one platform is specified. Also deprecate macosx() and
1740         force the use of macos() instead.
1741
1742         * Scripts/webkitpy/style/checkers/cpp.py:
1743         (check_min_versions_of_wk_api_available):
1744         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1745         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1746
1747 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1748
1749         Update status inactive committers' status to 'contributor'.
1750
1751         * Scripts/webkitpy/common/config/contributors.json:
1752
1753 2019-03-21  Xan Lopez  <xan@igalia.com>
1754
1755         [JSC][x86] Drop support for x87 floating point
1756         https://bugs.webkit.org/show_bug.cgi?id=194853
1757
1758         Reviewed by Don Olmstead.
1759
1760         Force SSE2 on x86/32bit builds.
1761
1762         * Scripts/webkitdirs.pm:
1763         (generateBuildSystemFromCMakeProject):
1764
1765 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1766
1767         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1768         https://bugs.webkit.org/show_bug.cgi?id=196073
1769
1770         Reviewed by Michael Catanzaro.
1771
1772         Add test cases to check functions and constructors with no arguments but receiving user data.
1773
1774         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1775         (checkUserData):
1776         (testJSCFunction):
1777         (fooCreateWithUserData):
1778         (testJSCClass):
1779
1780 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1783
1784         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1785
1786         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1787
1788 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1789
1790         [GTK][WPE] Add API to provide geolocation information
1791         https://bugs.webkit.org/show_bug.cgi?id=195940
1792
1793         Reviewed by Michael Catanzaro.
1794
1795         Add a new test to check the new API.
1796
1797         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1798         (testGeolocationManagerCurrentPosition):
1799         (testGeolocationManagerWatchPosition):
1800         (beforeAll):
1801         (afterAll):
1802         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1803         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1804         (beforeAll): Ditto.
1805         * TestWebKitAPI/glib/CMakeLists.txt:
1806
1807 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         [GLib] Returning G_TYPE_OBJECT from a method does not work
1810         https://bugs.webkit.org/show_bug.cgi?id=195574
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1815
1816         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1817         (getGFile):
1818         (getParent):
1819         (createGString):
1820         (getGString):
1821         (getGStringCopyWillRaise):
1822         (getGStringCopy):
1823         (getGStringStr):
1824         (getGStringLen):
1825         (freeGString):
1826         (testJSCClass):
1827
1828 2019-03-20  Saam Barati  <sbarati@apple.com>
1829
1830         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1831         https://bugs.webkit.org/show_bug.cgi?id=195721
1832
1833         Reviewed by Filip Pizlo.
1834
1835         * Scripts/run-javascriptcore-tests:
1836
1837 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1838
1839         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1840         https://bugs.webkit.org/show_bug.cgi?id=196049
1841
1842         Reviewed by Tim Horton.
1843
1844         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1845         overflow scrolling in general, so rename it.
1846
1847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1848
1849 2019-03-20  Daniel Bates  <dabates@apple.com>
1850
1851         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1852         https://bugs.webkit.org/show_bug.cgi?id=196031
1853         <rdar://problem/49078172>
1854
1855         Reviewed by Tim Horton.
1856
1857         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1858         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1859         same code path used when the Done button is pressed to dismiss the <select> picker.
1860
1861         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1862         (TestWebKitAPI::TEST):
1863
1864 2019-03-20  Chris Dumez  <cdumez@apple.com>
1865
1866         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1867         https://bugs.webkit.org/show_bug.cgi?id=196029
1868         <rdar://problem/48954651>
1869
1870         Reviewed by Tim Horton.
1871
1872         Add API test coverage.
1873
1874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1875
1876 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-build] Improve failure summary string for ApplyPatch step
1879         https://bugs.webkit.org/show_bug.cgi?id=195995
1880
1881         Reviewed by Alexey Proskuryakov.
1882
1883         * BuildSlaveSupport/ews-build/steps.py:
1884         (ApplyPatch.getResultSummary): Override getResultSummary.
1885
1886 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1887
1888         AX: Implement support for new meter ARIA role
1889         https://bugs.webkit.org/show_bug.cgi?id=195966
1890
1891         Reviewed by Chris Fleizach.
1892
1893         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1894         to AXLevelIndicator.
1895
1896         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1897
1898 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1899
1900         [WebAuthN] Implement FIDO AppID extension
1901         https://bugs.webkit.org/show_bug.cgi?id=143491
1902         <rdar://problem/48298273>
1903
1904         Reviewed by Brent Fulgham.
1905
1906         Add a test that covers the new flag of convertToU2fSignCommand.
1907
1908         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1909         (TestWebKitAPI::TEST):
1910         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1911         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1912         (TestWebKitAPI::TEST):
1913
1914 2019-03-19  Keith Rollin  <krollin@apple.com>
1915
1916         Add support for more platforms to generate-xcfilelists
1917         https://bugs.webkit.org/show_bug.cgi?id=195977
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         generate-xcfilelists incorrectly complains when involved with building
1922         WebKit for iphonesimulator:
1923
1924             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1925             …
1926             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1927
1928         Address this by teaching generate-xcfilelists about more platforms.
1929
1930         * Scripts/generate-xcfilelists:
1931
1932 2019-03-19  John Wilander  <wilander@apple.com>
1933
1934         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1935         https://bugs.webkit.org/show_bug.cgi?id=195923
1936         <rdar://problem/49001272>
1937
1938         Reviewed by Alex Christensen.
1939
1940         This patch does the following to the TestRunner:
1941         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1942         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1943         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1944
1945         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1946         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1947         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1951         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1952         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1953         * WebKitTestRunner/TestController.h:
1954         * WebKitTestRunner/TestInvocation.cpp:
1955         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1956
1957 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1958
1959         [CMake] Support more clang and gcc sanitizers
1960         https://bugs.webkit.org/show_bug.cgi?id=195956
1961
1962         Reviewed by Michael Catanzaro.
1963
1964         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1965
1966 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-build] Improve summary for PrintConfiguration step
1969         https://bugs.webkit.org/show_bug.cgi?id=195945
1970
1971         Reviewed by Lucas Forschler.
1972
1973         * BuildSlaveSupport/ews-build/steps.py:
1974         (PrintConfiguration.getResultSummary): Override getResultSummary.
1975
1976 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews-build] Improve summary for CheckOutSource step
1979         https://bugs.webkit.org/show_bug.cgi?id=195963
1980
1981         Reviewed by Lucas Forschler.
1982
1983         * BuildSlaveSupport/ews-build/steps.py:
1984         (CheckOutSource.getResultSummary):
1985
1986 2019-03-19  Daniel Bates  <dabates@apple.com>
1987
1988         [iOS] Focus not preserved when switching between tabs
1989         https://bugs.webkit.org/show_bug.cgi?id=195820
1990         <rdar://problem/43614450>
1991
1992         Reviewed by Brent Fulgham.
1993
1994         Add tests to ensure that we restore focus when resigning and becoming first responder.
1995
1996         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1997         (TestWebKitAPI::TEST):
1998
1999 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2000
2001         Make WTFLogChannelState and WTFLogLevel enum classes
2002         https://bugs.webkit.org/show_bug.cgi?id=195904
2003
2004         Reviewed by Eric Carlson.
2005
2006         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2007         (TestWebKitAPI::TEST_F):
2008
2009 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2010
2011         [GStreamer][EME] Backported mssdemux protection data crash fix
2012         https://bugs.webkit.org/show_bug.cgi?id=195918
2013
2014         Reviewed by Philippe Normand.
2015
2016         * gstreamer/jhbuild.modules:
2017         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2018
2019 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2020
2021         Unreviewed, rolling out r243132.
2022
2023         Broke GTK build
2024
2025         Reverted changeset:
2026
2027         "Make WTFLogChannelState and WTFLogLevel enum classes"
2028         https://bugs.webkit.org/show_bug.cgi?id=195904
2029         https://trac.webkit.org/changeset/243132
2030
2031 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2032
2033         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2034
2035         * Scripts/webkitdirs.pm:
2036         (builtDylibPathForName): Adjust the shared library name that's changed
2037         with the API version bump in r243073.
2038
2039 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2040
2041         Make WTFLogChannelState and WTFLogLevel enum classes
2042         https://bugs.webkit.org/show_bug.cgi?id=195904
2043
2044         Reviewed by Eric Carlson.
2045
2046         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2047         (TestWebKitAPI::TEST_F):
2048
2049 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2050
2051         Disable flaky test added in r2431100
2052         https://webkit.org/b/195785
2053
2054         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2055         (TestWebKitAPI::TEST):
2056         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2057
2058 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2059
2060         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2061         https://bugs.webkit.org/show_bug.cgi?id=195916
2062
2063         Reviewed by Tim Horton.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2066         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2067
2068 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2069
2070         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2071
2072         * Scripts/webkitpy/common/config/contributors.json:
2073
2074 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2075
2076         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2077         https://bugs.webkit.org/show_bug.cgi?id=195785
2078
2079         Reviewed by Geoffrey Garen.
2080
2081         * TestWebKitAPI/TCPServer.cpp: Added.
2082         (TestWebKitAPI::TCPServer::TCPServer):
2083         (TestWebKitAPI::TCPServer::~TCPServer):
2084         (TestWebKitAPI::TCPServer::socketBindListen):
2085         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2086         * TestWebKitAPI/TCPServer.h: Added.
2087         (TestWebKitAPI::TCPServer::port const):
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2090         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2091         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2092         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2093         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2094         (TestWebKitAPI::respondSlowly):
2095         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2096         (TestWebKitAPI::downloadAtRate):
2097         (TestWebKitAPI::TEST):
2098
2099 2019-03-18  Saam Barati  <sbarati@apple.com>
2100
2101         Add a plan file for JetStream 2
2102         https://bugs.webkit.org/show_bug.cgi?id=190734
2103
2104         Reviewed by Mark Lam.
2105
2106         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2107
2108 2019-03-18  Chris Dumez  <cdumez@apple.com>
2109
2110         Delay WebProcess launch until a load is triggered in a Web view
2111         https://bugs.webkit.org/show_bug.cgi?id=195758
2112         <rdar://problem/48126013>
2113
2114         Reviewed by Geoff Garen.
2115
2116         Add API test coverage. Also update some existing API tests to not expect
2117         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2118
2119         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2124         (TEST):
2125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2126         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2127         (TEST):
2128         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2129         (TEST):
2130         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2131
2132 2019-03-18  Xan Lopez  <xan@igalia.com>
2133
2134         [CMake] Prevent potential warning when determining $architecture
2135         https://bugs.webkit.org/show_bug.cgi?id=195891
2136
2137         Reviewed by Michael Catanzaro.
2138
2139         It's possible for generateBuildSystemForCMakeProject to be called
2140         before determineArchitecture() is ever called. This will make the
2141         first eq check with $architecture to be bogus (and print a
2142         warning). Change that to an eq check with architecture(), which
2143         implicitly calls determineArchitecture() if needed, and change all
2144         the other similar cases in the method in the same way to prevent
2145         future bugs like this one.
2146
2147         * Scripts/webkitdirs.pm:
2148         (generateBuildSystemFromCMakeProject):
2149
2150 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2151
2152         [WPE] Tarballs generated with “make dist” cannot build documentation
2153         https://bugs.webkit.org/show_bug.cgi?id=195885
2154
2155         Reviewed by Carlos Garcia Campos.
2156
2157         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2158
2159 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2160
2161         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2162         https://bugs.webkit.org/show_bug.cgi?id=195883
2163
2164         Reviewed by Carlos Garcia Campos.
2165
2166         * gtkdoc/gtkdoc.py:
2167         (GTKDoc._run_command): When commands fail to run, include the full command line for
2168         the program invocation and the output it has generated on the standard error stream.
2169
2170 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2171
2172         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2173         https://bugs.webkit.org/show_bug.cgi?id=195786
2174
2175         Reviewed by Philippe Normand.
2176
2177         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2178         * wpe/jhbuild.modules: Ditto.
2179
2180 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2181
2182         [ews-build] Don't run clean builds on EWS builders
2183         https://bugs.webkit.org/show_bug.cgi?id=195851
2184
2185         Reviewed by Geoffrey Garen.
2186
2187         * BuildSlaveSupport/ews-build/factories.py:
2188
2189 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2190
2191         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2192         https://bugs.webkit.org/show_bug.cgi?id=195849
2193
2194         Reviewed by Chris Dumez.
2195
2196         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2199         (runWebsiteDataStoreCustomPaths):
2200
2201 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2202
2203         webkitpy: Upload test results
2204         https://bugs.webkit.org/show_bug.cgi?id=195755
2205         <rdar://problem/48896182>
2206
2207         Reviewed by Aakash Jain.
2208
2209         Establish a new format for uploading results that is not tied to layout tests, apply
2210         that format to webkitpy tests.
2211
2212         * Scripts/webkitpy/common/checkout/scm/git.py:
2213         (Git.native_branch): Return what branch the current checkout is on.
2214         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2215         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2216         * Scripts/webkitpy/common/checkout/scm/svn.py:
2217         (SVN.native_branch): Ditto.
2218         * Scripts/webkitpy/common/system/platforminfo.py:
2219         (PlatformInfo.build_version): Return a build version for Mac.
2220         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2221         (MockPlatformInfo.__init__):
2222         (MockPlatformInfo.build_version):
2223         * Scripts/webkitpy/results: Added.
2224         * Scripts/webkitpy/results/__init__.py: Added.
2225         * Scripts/webkitpy/results/options.py: Added.
2226         (upload_options): OptParse list for upload options.
2227         * Scripts/webkitpy/results/upload.py: Added.
2228         (Upload): Class which enforces the upload format expected by the results server.
2229         (Upload.Expectations):
2230         (Upload.create_configuration):
2231         (Upload.create_commit):
2232         (Upload.create_details):
2233         (Upload.create_run_stats):
2234         (Upload.create_test_result):
2235         (Upload.__init__):
2236         (Upload.Encoder): Encode Upload object as json.
2237         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2238         * Scripts/webkitpy/results/upload_unittest.py: Added.
2239         * Scripts/webkitpy/test/main.py:
2240         (Tester._parse_args): Add upload arguments.
2241         (Tester._run_tests): Allow results to be uploaded.
2242         * Scripts/webkitpy/test/runner.py:
2243         (Runner.__init__): Record which tests were run, rather than just counting them.
2244         (Runner.handle):
2245         * Scripts/webkitpy/test/runner_unittest.py:
2246         (RunnerTest.test_run):
2247         * Scripts/webkitpy/thirdparty/__init__.py:
2248         (AutoinstallImportHook.find_module): Add requests auto-install.
2249         (AutoinstallImportHook._install_requests):
2250         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2251         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2252
2253 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2254
2255         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2256         https://bugs.webkit.org/show_bug.cgi?id=195810
2257
2258         Reviewed by Tim Horton.
2259
2260         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2261         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2262         ending certain layout tests.
2263
2264         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2265         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2266         (-[TestRunnerWKWebView dealloc]):
2267         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2268
2269         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2270         helper method when destroying the web view, and when resetting state between tests.
2271
2272         * WebKitTestRunner/ios/TestControllerIOS.mm:
2273         (WTR::TestController::platformResetStateToConsistentValues):
2274
2275         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2276
2277 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2278
2279         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2280         https://bugs.webkit.org/show_bug.cgi?id=190350
2281         <rdar://problem/45089503>
2282
2283         Reviewed by Geoffrey Garen.
2284
2285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2286         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2287         (TEST):
2288         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2289         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2290         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2291         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2292         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2293         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2294         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2295         (runTest):
2296         (createDirectories):
2297         (TEST):
2298         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2299         (TEST):
2300         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2301         (TEST):
2302
2303 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2304
2305         Add support to WebPage for getting the contents as an attributed string.
2306         https://bugs.webkit.org/show_bug.cgi?id=195636
2307         rdar://problem/45055697
2308
2309         Reviewed by Tim Horton.
2310
2311         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2312         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2313
2314 2019-03-15  Chris Dumez  <cdumez@apple.com>
2315
2316         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2317         https://bugs.webkit.org/show_bug.cgi?id=195747
2318
2319         Reviewed by Geoff Garen.
2320
2321         Add API test coverage.
2322
2323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2324
2325 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2326
2327         Unreviewed, rolling out r242952.
2328
2329         Causing API failures on iOS Simulator
2330
2331         Reverted changeset:
2332
2333         "[PSON] Make sure the WebProcessCache is leverage when
2334         relaunching a process after termination"
2335         https://bugs.webkit.org/show_bug.cgi?id=195747
2336         https://trac.webkit.org/changeset/242952
2337
2338 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2339
2340         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2341         https://bugs.webkit.org/show_bug.cgi?id=195740
2342
2343         Reviewed by Ross Kirsling.
2344
2345         window.open doesn't work for WebKitBrowserWindow because it is not
2346         implemented yet.
2347
2348         1. Implemented createNewPage callback of WKPageUIClient.
2349         2. Changed MainWindow to take a BrowserWindow factory function
2350           instead of BrowserWindowType to be flexible to create
2351           BrowserWindow with extra settings.
2352         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2353           because it is not relevant with MainWindow anymore.
2354
2355         * MiniBrowser/win/Common.cpp:
2356         (parseCommandLine):
2357         * MiniBrowser/win/Common.h:
2358         (CommandLineOptions::CommandLineOptions):
2359         * MiniBrowser/win/MainWindow.cpp:
2360         (MainWindow::MainWindow):
2361         (MainWindow::create):
2362         (MainWindow::init):
2363         (MainWindow::WndProc):
2364         * MiniBrowser/win/MainWindow.h:
2365         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2366         (PrintWebUIDelegate::createWebViewWithRequest):
2367         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2368         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2369         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2370         (WebKitBrowserWindow::updateProxySettings):
2371         (WebKitBrowserWindow::createNewPage):
2372         * MiniBrowser/win/WebKitBrowserWindow.h:
2373         * MiniBrowser/win/WinMain.cpp:
2374         (wWinMain):
2375
2376 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2377
2378         Make it possible to test scrolling tree layer manipulation more easily
2379         https://bugs.webkit.org/show_bug.cgi?id=195780
2380
2381         Reviewed by Tim Horton.
2382         
2383         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2384         cuts off communication of scrolling tree scrolls back to the web process
2385         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2386         allows tests to trigger scrolls which run the scrolling tree layer positioning
2387         logic, but never get another commit from the web process that might mask
2388         scrolling tree bugs.
2389         
2390         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2391         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2392         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2393
2394         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2395         (WTR::UIScriptController::scrollUpdatesDisabled const):
2396         (WTR::UIScriptController::setScrollUpdatesDisabled):
2397         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2398         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2399         (WTR::UIScriptController::scrollUpdatesDisabled const):
2400         (WTR::UIScriptController::setScrollUpdatesDisabled):
2401         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2402         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2403         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2404         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2405         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2406         * WebKitTestRunner/ios/TestControllerIOS.mm:
2407         (WTR::TestController::platformResetStateToConsistentValues):
2408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2409         (WTR::UIScriptController::scrollUpdatesDisabled const):
2410         (WTR::UIScriptController::setScrollUpdatesDisabled):
2411
2412 2019-03-14  Youenn Fablet  <youenn@apple.com>
2413
2414         Move IDB storage in private browsing mode to NetworkProcess
2415         https://bugs.webkit.org/show_bug.cgi?id=195602
2416
2417         Reviewed by Brady Eidson.
2418
2419         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2420         (TEST):
2421
2422 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2423
2424         [ews-build] Make descriptionDone messages more readable
2425         https://bugs.webkit.org/show_bug.cgi?id=195760
2426
2427         Reviewed by Lucas Forschler.
2428
2429         * BuildSlaveSupport/ews-build/steps.py:
2430         * BuildSlaveSupport/ews-build/steps_unittest.py:
2431
2432 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2433
2434         [ews-build] Generate status-bubble hover-over messages
2435         https://bugs.webkit.org/show_bug.cgi?id=195680
2436
2437         Reviewed by Lucas Forschler.
2438
2439         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2440         (StatusBubble):
2441         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2442         on hover-over.
2443         (StatusBubble._iso_time):
2444         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2445         hover-over message.
2446         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2447
2448 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2449
2450         [ews-app] Gracefully handle the case when state_string is None
2451         https://bugs.webkit.org/show_bug.cgi?id=195753
2452
2453         Reviewed by Lucas Forschler.
2454
2455         * BuildSlaveSupport/ews-app/ews/models/build.py:
2456         * BuildSlaveSupport/ews-app/ews/models/step.py:
2457
2458 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews-app] Status bubble display pending for currently running build step
2461         https://bugs.webkit.org/show_bug.cgi?id=195744
2462
2463         Reviewed by Lucas Forschler.
2464
2465         * BuildSlaveSupport/ews-build/events.py:
2466         (Events.stepStarted): If state_string is pending, replace it with step name.
2467
2468 2019-03-14  Chris Dumez  <cdumez@apple.com>
2469
2470         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2471         https://bugs.webkit.org/show_bug.cgi?id=195750
2472
2473         Reviewed by Geoffrey Garen.
2474
2475         Add API test coverage.
2476
2477         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2478         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2479         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2480         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2481
2482 2019-03-14  Chris Dumez  <cdumez@apple.com>
2483
2484         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2485         https://bugs.webkit.org/show_bug.cgi?id=195747
2486
2487         Reviewed by Geoff Garen.
2488
2489         Add API test coverage.
2490
2491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2492
2493 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2494
2495         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2496         https://bugs.webkit.org/show_bug.cgi?id=195725
2497         <rdar://problem/48545062>
2498
2499         Reviewed by Tim Horton.
2500
2501         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2502         handler is nil.
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2505         (TestWebKitAPI::TEST):
2506
2507 2019-03-13  Sam Weinig  <sam@webkit.org>
2508
2509         Add utility function to allow easy reverse range-based iteration of a container
2510         https://bugs.webkit.org/show_bug.cgi?id=195542
2511
2512         Reviewed by Antti Koivisto.
2513
2514         * TestWebKitAPI/CMakeLists.txt:
2515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2516         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2517         (TestWebKitAPI::TEST):
2518         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2519
2520 2019-03-13  Chris Dumez  <cdumez@apple.com>
2521
2522         Use a ServiceWorker process per registrable domain
2523         https://bugs.webkit.org/show_bug.cgi?id=195649
2524
2525         Reviewed by Youenn Fablet.
2526
2527         Update API test coverage.
2528
2529         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2530
2531 2019-03-13  Chris Dumez  <cdumez@apple.com>
2532
2533         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2534         https://bugs.webkit.org/show_bug.cgi?id=195684
2535         <rdar://problem/48294714>
2536
2537         Reviewed by Antti Koivisto.
2538
2539         Add API test coverage.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2542
2543 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2544
2545         [ews-app] Remove unused patch view
2546         https://bugs.webkit.org/show_bug.cgi?id=195669
2547
2548         Reviewed by Lucas Forschler.
2549
2550         * BuildSlaveSupport/ews-app/ews/urls.py:
2551         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2552
2553 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2554
2555         [ews-app] Use Buildbot result code variables
2556         https://bugs.webkit.org/show_bug.cgi?id=195668
2557
2558         Reviewed by Alexey Proskuryakov.
2559
2560         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2561         (Buildbot): Added Buildbot result code variables.
2562         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2563         (StatusBubble._build_bubble): Used Buildbot result code variables.
2564
2565 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2566
2567         [Flatpak] Expand submodule recursively
2568         https://bugs.webkit.org/show_bug.cgi?id=195672
2569
2570         Building WPE with flatpak was impossible without that as it was raising an exception.
2571         Also update wpebackend-fdo to match what is built in jhbuild
2572
2573         Reviewed by Philippe Normand.
2574
2575         * flatpak/flatpakutils.py:
2576         (expand_submodules_recurse):
2577         (expand_manifest):
2578         * flatpak/org.webkit.WPEModules.yaml:
2579
2580 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews-app] status bubble should be hidden for certain builds
2583         https://bugs.webkit.org/show_bug.cgi?id=194597
2584
2585         Reviewed by Dewei Zhu.
2586
2587         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2588         (StatusBubble._build_bubble):
2589         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2590         because the patch didn't have relevant changes.
2591         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2592         in production yet.
2593
2594 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2595
2596         [Win] Fix a slew of simple clang-cl warnings.
2597         https://bugs.webkit.org/show_bug.cgi?id=195652
2598
2599         Reviewed by Don Olmstead.
2600
2601         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2602         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2603
2604 2019-03-12  Justin Fan  <justin_fan@apple.com>
2605
2606         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2607         https://bugs.webkit.org/show_bug.cgi?id=195518
2608         <rdar://problem/46322356>
2609
2610         Reviewed by Myles C. Maxfield.
2611
2612         * DumpRenderTree/DerivedSources-input.xcfilelist:
2613         * DumpRenderTree/DerivedSources-output.xcfilelist:
2614
2615 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2616
2617         Unreviewed, rolling out r242825.
2618         https://bugs.webkit.org/show_bug.cgi?id=195648
2619
2620         "Broke webkitpy tests with my change to
2621         lldb_dump_class_layout.py" (Requested by rmorisset on
2622         #webkit).
2623
2624         Reverted changeset:
2625
2626         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2627         classes with suspicious padding"
2628         https://bugs.webkit.org/show_bug.cgi?id=195573
2629         https://trac.webkit.org/changeset/242825
2630
2631 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2632
2633         [ews-build] Show status bubbles while the patch is waiting in queue
2634         https://bugs.webkit.org/show_bug.cgi?id=195618
2635
2636         Reviewed by Lucas Forschler.
2637
2638         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2639         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2640         enabled in initial deployment.
2641         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2642         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2643         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2644         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2645         (StatusBubble._build_bubbles_for_patch):
2646
2647 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2648
2649         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2650         https://bugs.webkit.org/show_bug.cgi?id=195573
2651
2652         Reviewed by Simon Fraser.
2653
2654         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2655
2656         * Scripts/dump-class-layout:
2657         (main):
2658         * lldb/lldb_dump_class_layout.py:
2659         (ClassLayout.__init__):
2660         (ClassLayout._compute_padding_recursive):
2661         (LLDBDebuggerInstance.dump_layout_for_classname):
2662         (LLDBDebuggerInstance):
2663         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2664         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2665
2666 2019-03-12  Chris Dumez  <cdumez@apple.com>
2667
2668         Device Orientation access permission should be denied unless explicitly granted by the client
2669         https://bugs.webkit.org/show_bug.cgi?id=195625
2670
2671         Reviewed by Youenn Fablet.
2672
2673         add API test coverage.
2674
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2677         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2678         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2679         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2680         (runDeviceOrientationTest):
2681         (TEST):
2682         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2683         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2684
2685 2019-03-12  Jer Noble  <jer.noble@apple.com>
2686
2687         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2688         https://bugs.webkit.org/show_bug.cgi?id=195137
2689         <rdar://problem/48810307>
2690
2691         Reviewed by Eric Carlson.
2692
2693         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2694         (TestWebKitAPI::TEST):
2695
2696 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-build] Change urls from uat to production
2699         https://bugs.webkit.org/show_bug.cgi?id=195566
2700
2701         Reviewed by Lucas Forschler.
2702
2703         * BuildSlaveSupport/ews-app/ews/config.py:
2704         * BuildSlaveSupport/ews-build/events.py:
2705         * BuildSlaveSupport/ews-build/steps.py:
2706
2707 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2708
2709         [ews-build] change max_builds for local-worker to 1
2710         https://bugs.webkit.org/show_bug.cgi?id=195568
2711
2712         Reviewed by Lucas Forschler.
2713
2714         * BuildSlaveSupport/ews-build/loadConfig.py:
2715
2716 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2717
2718         Fix the build
2719
2720         * TestRunnerShared/spi/PencilKitTestSPI.h:
2721         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2722
2723 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2724
2725         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2726         https://bugs.webkit.org/show_bug.cgi?id=194131
2727
2728         Reviewed by Michael Catanzaro.
2729
2730         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2731         (uriChanged):
2732         (testUnfinishedSubresourceLoad):
2733         (serverCallback):
2734         (beforeAll):
2735
2736 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2737
2738         WTF::Expected should use std::addressof instead of operator&
2739         https://bugs.webkit.org/show_bug.cgi?id=195604
2740
2741         Reviewed by Myles Maxfield.
2742
2743         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2744         (TestWebKitAPI::Unique::Unique):
2745         (TestWebKitAPI::Unique::operator&):
2746         (TestWebKitAPI::TEST):
2747
2748 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2749
2750         Add Optional to Forward.h.
2751         https://bugs.webkit.org/show_bug.cgi?id=195586
2752
2753         Reviewed by Darin Adler.
2754
2755         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2756         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2757         Remove unnecessary includes from headers.
2758
2759 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2760
2761         Add testing API to hit-test and scroll overflow scrollers
2762         https://bugs.webkit.org/show_bug.cgi?id=195278
2763
2764         Reviewed by Antti Koivisto.
2765         
2766         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2767         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2768         
2769         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2770
2771         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2772         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2773         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2774         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2775         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2776         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2777         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2778         (WTR::enclosingScrollViewIncludingSelf):
2779         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2780
2781 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2782
2783         API test WebKit.RequestTextInputContext fails on iOS
2784         https://bugs.webkit.org/show_bug.cgi?id=195585
2785
2786         Reviewed by Wenson Hsieh and Simon Fraser.
2787
2788         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2789         (applyStyle):
2790         (TEST):
2791         Add a viewport, so that the coordinates match up on iOS.
2792         Scroll by moving the UIScrollView's contentOffset.
2793
2794 2019-03-11  Chris Dumez  <cdumez@apple.com>
2795
2796         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2797         https://bugs.webkit.org/show_bug.cgi?id=195506
2798         <rdar://problem/48733477>
2799
2800         Reviewed by Alex Christensen.
2801
2802         Add API test coverage.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2805
2806 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2807
2808         Adding myself to contributors.json
2809
2810         Unreviewed, addming myself to contributors.json .
2811
2812         * Scripts/webkitpy/common/config/contributors.json:
2813
2814 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2815
2816         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2817         https://bugs.webkit.org/show_bug.cgi?id=195511
2818         <rdar://problem/44873269>
2819
2820         Reviewed by Darin Adler.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2823         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2824         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2825         (TEST_F):
2826
2827 2019-03-11  Chris Dumez  <cdumez@apple.com>
2828
2829         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2830         https://bugs.webkit.org/show_bug.cgi?id=195561
2831
2832         Reviewed by Youenn Fablet.
2833
2834         Make sure the JS in the test requests for permission to receive device orientation events.
2835
2836         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2837
2838 2019-03-11  Youenn Fablet  <youenn@apple.com>
2839
2840         Allow storage quota increase by default in WTR
2841         https://bugs.webkit.org/show_bug.cgi?id=195541
2842
2843         Reviewed by Geoffrey Garen.
2844
2845         Allow storage quota increase by default in WTR.
2846         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2847         Use this for tests that explicitly need cache increase.
2848
2849         Instead of increasing quota by 2, make sure the next request is
2850         granted by adding all given parameters.
2851
2852         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2853         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2854         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2855         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2856         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2857         * WebKitTestRunner/TestController.cpp:
2858         (WTR::TestController::setAllowStorageQuotaIncrease):
2859         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2860         * WebKitTestRunner/TestController.h:
2861         * WebKitTestRunner/TestInvocation.cpp:
2862         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2863         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2864         (WTR::TestController::cocoaResetStateToConsistentValues):
2865         (WTR::TestController::setAllowStorageQuotaIncrease):
2866         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2867         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2868         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2869
2870 2019-03-11  Xan Lopez  <xan@igalia.com>
2871
2872         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2873         https://bugs.webkit.org/show_bug.cgi?id=194147
2874
2875         Reviewed by Michael Saboff.
2876
2877         To make --32-bit work correctly on Linux/64bit we need to:
2878
2879         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2880         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2881         unfortunately CMake only allows us to do this during
2882         crosscompilation, which is overkill here.
2883         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2884         pkg-config detection module uses the x86 .pc files instead of the
2885         x86_64 ones.
2886         - Set the -m32 flags for the compiler.
2887
2888         * Scripts/webkitdirs.pm:
2889         (generateBuildSystemFromCMakeProject):
2890
2891 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2892
2893         Add MotionMark-1.1 plan file for run-benchmark script.
2894         https://bugs.webkit.org/show_bug.cgi?id=195481
2895
2896         Rubber-stamped by Darin Adler.
2897
2898         Run-benchmark script should support MontionMark-1.1.
2899
2900         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2901
2902 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-app] Add support for submit-to-ews url
2905         https://bugs.webkit.org/show_bug.cgi?id=195477
2906
2907         Reviewed by Lucas Forschler.
2908
2909         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2910         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2911         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2912         * BuildSlaveSupport/ews-app/ews/urls.py:
2913         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2914
2915 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2916
2917         Unreviewed, rolling out r242688, r242643, r242624.
2918
2919         Caused multiple layout test failures and crashes on iOS and macOS.
2920
2921         Reverted changeset:
2922
2923         "requestAnimationFrame should execute before the next frame"
2924         https://bugs.webkit.org/show_bug.cgi?id=177484
2925         https://trac.webkit.org/changeset/242624/webkit
2926
2927         * Tracing/SystemTracePoints.plist:
2928
2929 2019-03-11  John Wilander  <wilander@apple.com>
2930
2931         Resource Load Statistics: Make it possible exclude localhost from classification
2932         https://bugs.webkit.org/show_bug.cgi?id=195474
2933         <rdar://problem/47520577>
2934
2935         Reviewed by Brent Fulgham.
2936
2937         This patch allows for localhost to be excluded from classification and
2938         treatment as a prevalent resource.
2939
2940         The WebKit Tools change adds a new function called
2941         testRunner.setStatisticsIsRunningTest() which can be used to control this
2942         behavior.
2943
2944         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2946         (WTR::TestRunner::setStatisticsIsRunningTest):
2947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2948         * WebKitTestRunner/TestController.cpp:
2949         (WTR::TestController::setStatisticsIsRunningTest):
2950         * WebKitTestRunner/TestController.h:
2951         * WebKitTestRunner/TestInvocation.cpp:
2952         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2953
2954 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2955
2956         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2957         https://bugs.webkit.org/show_bug.cgi?id=195560
2958
2959         Reviewed by Lucas Forschler.
2960
2961         * BuildSlaveSupport/ews-build/master.cfg:
2962
2963 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2964
2965         Unreviewed, rolling out r242698.
2966
2967         API test crashes on bots.
2968
2969         Reverted changeset:
2970
2971         "Add a WKContentRuleList variant that uses copied memory
2972         instead of mmap'd shared memory for class A containerized
2973         apps"
2974         https://bugs.webkit.org/show_bug.cgi?id=195511
2975         https://trac.webkit.org/changeset/242698
2976
2977 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2978
2979         [WPE] Enable web process sandbox
2980         https://bugs.webkit.org/show_bug.cgi?id=195169
2981
2982         Reviewed by Daniel Bates.
2983
2984         * wpe/install-dependencies:
2985         * wpe/jhbuild.modules:
2986
2987 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-app] Use port 17000 for worker communication
2990         https://bugs.webkit.org/show_bug.cgi?id=195558
2991
2992         Reviewed by Lucas Forschler.
2993
2994         * BuildSlaveSupport/ews-build/master.cfg:
2995
2996 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2997
2998         [ews-build] unit-tests fail when passwords.json is missing
2999         https://bugs.webkit.org/show_bug.cgi?id=195557
3000
3001         Reviewed by Lucas Forschler.
3002
3003         * BuildSlaveSupport/ews-build/loadConfig.py:
3004         (loadBuilderConfig):
3005         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3006         (ConfigDotJSONTest.test_configuration):
3007         * BuildSlaveSupport/ews-build/master.cfg:
3008
3009 2019-03-11  Truitt Savell  <tsavell@apple.com>
3010
3011         Unreviewed, rolling out r242702.
3012
3013         Broke High Sierra builders.
3014
3015         Reverted changeset:
3016
3017         "Add utility function to allow easy reverse range-based
3018         iteration of a container"
3019         https://bugs.webkit.org/show_bug.cgi?id=195542
3020         https://trac.webkit.org/changeset/242702
3021
3022 2019-03-11  Sam Weinig  <sam@webkit.org>
3023
3024         Add utility function to allow easy reverse range-based iteration of a container
3025         https://bugs.webkit.org/show_bug.cgi?id=195542
3026
3027         Reviewed by Antti Koivisto.
3028
3029         * TestWebKitAPI/CMakeLists.txt:
3030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3032         (TestWebKitAPI::TEST):
3033         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3034
3035 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3036
3037         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3038         https://bugs.webkit.org/show_bug.cgi?id=195511
3039         <rdar://problem/44873269>
3040
3041         Reviewed by Darin Adler.
3042
3043         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3044         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3045         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3046         (TEST_F):
3047
3048 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3049
3050         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3051         https://bugs.webkit.org/show_bug.cgi?id=195499
3052
3053         Reviewed by Darin Adler.
3054
3055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3056         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3057         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3058         (-[WKWebView synchronouslyFocusTextInputContext:]):
3059         (applyStyle):
3060         (applyIframe):
3061         (TEST):
3062         Add some tests for this SPI.
3063
3064 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3065
3066         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3067         https://bugs.webkit.org/show_bug.cgi?id=181151
3068
3069         Reviewed by Don Olmstead.
3070
3071         * TestWebKitAPI/CMakeLists.txt:
3072         * TestWebKitAPI/PlatformWin.cmake:
3073         Enable TestWTF RunLoop tests in all platforms.
3074
3075         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3076         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3077         (TestWebKitAPI::DerivedOneShotTimer::fired):
3078         (TestWebKitAPI::TEST):
3079         Only a few platforms support nested RunLoop.
3080
3081         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3082         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3083
3084 2019-03-10  David Quesada  <david_quesada@apple.com>
3085
3086         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3087         https://bugs.webkit.org/show_bug.cgi?id=152480
3088
3089         Reviewed by Chris Dumez.
3090
3091         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3092         there are no additional references to the process pool besides the one held by
3093         the download, waits for the download to finish (in the sense that the
3094         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3095         measure, also check that the process pool has been deallocated at the end of the
3096         test. The test wouldn't be meaningful if the process pool were still alive.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3099         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3100         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3101             The download will be canceled because the delegate does not implement the
3102             method to decide the download's destination, so this is where we know the
3103             DownloadProxyMap is done with the DownloadProxy.
3104         (TEST):
3105
3106 2019-03-08  Chris Dumez  <cdumez@apple.com>
3107
3108         Add support for Device Orientation / Motion permission API
3109         https://bugs.webkit.org/show_bug.cgi?id=195329
3110         <rdar://problem/47645367>
3111
3112         Reviewed by Geoffrey Garen.
3113
3114         Add test infrastructure to help test the Device Orientation / Motion permission API.
3115
3116         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3117         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3118         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3119         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3120         * WebKitTestRunner/TestController.cpp:
3121         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3122         (WTR::TestController::createWebViewWithOptions):
3123         (WTR::TestController::resetStateToConsistentValues):
3124         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3125         * WebKitTestRunner/TestController.h:
3126         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3127         * WebKitTestRunner/TestInvocation.cpp:
3128         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3129
3130 2019-03-08  Saam barati  <sbarati@apple.com>
3131
3132         Add a compare-results script to compare benchmark results
3133         https://bugs.webkit.org/show_bug.cgi?id=195486
3134         <rdar://problem/48723397>
3135
3136         Reviewed by Geoffrey Garen.
3137
3138         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3139         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3140         to extend it to learn about our other benchmarks.
3141
3142         * Scripts/compare-results: Added.
3143         (readJSONFile):
3144         (detectJetStream2):
3145         (JetStream2Results):
3146         (detectSpeedometer2):
3147         (Speedometer2Results):
3148         (detectPLT5):
3149         (PLT5Results):
3150         (detectBenchmark):
3151         (biggerIsBetter):
3152         (ttest):
3153         (getOptions):
3154         (main):
3155
3156 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3157
3158         Ensure old tab state is cleared between iterations of run-benchmark
3159         https://bugs.webkit.org/show_bug.cgi?id=195393
3160         <rdar://problem/46885583>
3161
3162         Reviewed by Dewei Zhu.
3163
3164         a) ensure the default to restore state is not set
3165         b) terminate Safari correctly
3166         c) Set the system default to ignore Persistent State in Safari
3167
3168         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3169         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3170         (OSXBrowserDriver.prepare_env): 
3171         (OSXBrowserDriver.restore_env):
3172         (OSXBrowserDriver.close_browsers):
3173         (OSXBrowserDriver._terminate_processes):
3174         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3175         (OSXChromeDriver):
3176         (OSXChromeCanaryDriver):
3177         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3178         (OSXFirefoxDriver):
3179         (OSXFirefoxNightlyDriver):
3180         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3181         (OSXSafariDriver):
3182         (OSXSafariDriver.prepare_env):
3183
3184 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3185
3186         [GTK] Several InputMethodFilter tests are failing
3187         https://bugs.webkit.org/show_bug.cgi?id=195408
3188
3189         Reviewed by Carlos Garcia Campos.
3190
3191         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3192         Regressed in r241751.
3193         Hexadecimal values of keycodes are expressed now in upper letters.
3194         Composited characters should be cast to UTF8 strings.
3195
3196         (TestWebKitAPI::TEST):
3197
3198 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3199
3200         [GTK] Make Tools/gtkdoc python3 compatible
3201         https://bugs.webkit.org/show_bug.cgi?id=195359
3202
3203         Reviewed by Carlos Garcia Campos.
3204
3205         * gtkdoc/generate-gtkdoc:
3206         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3207         work with Python 2 and 3.
3208         (get_gtkdoc_module_paths):
3209         The iteritems() was removed in Python 3, so let's use items() that's
3210         available in Python 2 and 3.
3211         (get_generator_for_config):
3212         * gtkdoc/gtkdoc.py:
3213         (GTKDoc._run_command):
3214         The sys.stdout.write() is expecting str in Python 3 and not bytes
3215         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3216         for passing the bytes there.
3217
3218 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3219
3220         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3221         https://bugs.webkit.org/show_bug.cgi?id=195346
3222         <rdar://problem/48667048>
3223
3224         Unreviewed build fix for clang-cl.
3225
3226         * DumpRenderTree/win/DumpRenderTree.cpp:
3227         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3228
3229 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3230
3231         requestAnimationFrame should execute before the next frame
3232         https://bugs.webkit.org/show_bug.cgi?id=177484
3233
3234         Reviewed by Simon Fraser.
3235
3236         Add trace points for the page RenderingUpdate.
3237
3238         * Tracing/SystemTracePoints.plist:
3239
3240 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3241
3242         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3243         https://bugs.webkit.org/show_bug.cgi?id=195353
3244         <rdar://problem/48626394>
3245
3246         Reviewed by Simon Fraser.
3247
3248         * WebKitTestRunner/ios/TestControllerIOS.mm:
3249         (WTR::TestController::platformResetPreferencesToConsistentValues):
3250
3251 2019-03-07  John Wilander  <wilander@apple.com>
3252
3253         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3254         https://bugs.webkit.org/show_bug.cgi?id=195383
3255         <rdar://problem/48570136>
3256
3257         Reviewed by Brent Fulgham.
3258
3259         This patch adds test infrastructure to purge only script-accessible cookies,
3260         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3261
3262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3264         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3265         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3266         * WebKitTestRunner/TestController.cpp:
3267         (WTR::TestController::statisticsDeleteCookiesForHost):
3268         * WebKitTestRunner/TestController.h:
3269         * WebKitTestRunner/TestInvocation.cpp:
3270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3271
3272 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3273
3274         Unreviewed, rolling out r242354.
3275         https://bugs.webkit.org/show_bug.cgi?id=195402
3276
3277         breaks layout tests in all configurations (Requested by
3278         zdobersek on #webkit).
3279
3280         Reverted changeset:
3281
3282         "[WPE] Enable web process sandbox"
3283         https://bugs.webkit.org/show_bug.cgi?id=195169
3284         https://trac.webkit.org/changeset/242354
3285
3286 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3287
3288         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3289         https://bugs.webkit.org/show_bug.cgi?id=195346
3290
3291         Reviewed by Fujii Hironori.
3292
3293         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3294         (TestWebKitAPI::TEST):
3295         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3296
3297         * DumpRenderTree/win/DumpRenderTree.cpp:
3298         (findFontFallback):
3299         (addFontFallbackIfPresent):
3300         (removeFontFallbackIfPresent):
3301         (main):
3302         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3303         (TestWebKitAPI::Util::moduleDirectory):
3304         (TestWebKitAPI::Util::createInjectedBundlePath):
3305         Use wchar helpers as needed.
3306
3307 2019-03-06  Rob Buis  <rbuis@igalia.com>
3308
3309         Consider supporting the `referrerpolicy` attribute.
3310         https://bugs.webkit.org/show_bug.cgi?id=179053
3311
3312         Reviewed by Darin Adler.
3313
3314         Add a runtime flag for referrerpolicy attribute.
3315
3316         * DumpRenderTree/mac/DumpRenderTree.mm:
3317         (enableExperimentalFeatures):
3318
3319 2019-03-05  Daniel Bates  <dabates@apple.com>
3320
3321         Update expected API test result following r242379
3322         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3323
3324         Update expected x-coordinate of selection rect now that the left padding of
3325         a textarea is sized in ems (so dependent on the font size) just like the left
3326         padding of a text field.
3327
3328         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3329         (TestWebKitAPI::TEST):
3330
3331 2019-03-05  David Quesada  <david_quesada@apple.com>
3332
3333         [WK2] It should be possible to follow links with 'download' attributes
3334         https://bugs.webkit.org/show_bug.cgi?id=195145
3335         rdar://problem/48462642
3336
3337         Reviewed by Alex Christensen.
3338
3339         Add a unit test to verify that activating links with 'download' attributes now
3340         navigates to the linked resource, rather than starts downloading it. Add another
3341         to verify that it is still possible to explicitly download the link via the
3342         'Download' navigation action policy.
3343
3344         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3345         (-[DownloadAttributeTestDelegate init]):
3346         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3347         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3348         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3349         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3350         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3351         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3352         (TEST):
3353         * WebKitTestRunner/TestController.cpp:
3354         (WTR::TestController::decidePolicyForNavigationAction):
3355         * WebKitTestRunner/TestController.h:
3356
3357 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3358
3359         [Curl] Implement Cookie Accept Policy.
3360         https://bugs.webkit.org/show_bug.cgi?id=191645
3361
3362         Reviewed by Fujii Hironori.
3363
3364         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3365         (TestWebKitAPI::Curl::TEST_F):
3366
3367 2019-03-05  Youenn Fablet  <youenn@apple.com>
3368
3369         Rename requestCacheStorageSpace to requestStorageSpace
3370         https://bugs.webkit.org/show_bug.cgi?id=195282
3371
3372         Reviewed by Chris Dumez.
3373
3374         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3375         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3376         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3377
3378 2019-03-05  Brady Eidson  <beidson@apple.com>
3379
3380         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3381         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3382
3383         Reviewed by Tim Horton.
3384
3385         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3386         different directory into that same WKWebView should work.
3387
3388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3389         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3390
3391 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3392
3393         Add WeakHashSet
3394         https://bugs.webkit.org/show_bug.cgi?id=195152
3395
3396         Reviewed by Antti Koivisto.
3397
3398         Added tests for WeakHashSet.
3399
3400         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3401         (TestWebKitAPI::Base::Base): Moved.
3402         (TestWebKitAPI::Derived::foo): Moved.
3403         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3404         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3405         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3406         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3407
3408 2019-03-04  Chris Dumez  <cdumez@apple.com>
3409
3410         Do not share WebProcesses between private and regular sessions
3411         https://bugs.webkit.org/show_bug.cgi?id=195189
3412         <rdar://problem/48421064>
3413
3414         Reviewed by Alex Christensen.
3415
3416         Add API test coverage.
3417
3418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3419         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3420
3421 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3422
3423         [WPE] Enable web process sandbox
3424         https://bugs.webkit.org/show_bug.cgi?id=195169
3425
3426         Reviewed by Daniel Bates.
3427
3428         * wpe/install-dependencies:
3429         * wpe/jhbuild.modules:
3430
3431 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3432
3433         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3434         https://bugs.webkit.org/show_bug.cgi?id=195206
3435
3436         Reviewed by Žan Doberšek.
3437
3438         Add a new test case.
3439
3440         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3441         (testJSCClass):
3442
3443 2019-03-04  Charlie Turner  <cturner@igalia.com>
3444
3445         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3446         https://bugs.webkit.org/show_bug.cgi?id=194898
3447
3448         Reviewed by Žan Doberšek.
3449
3450         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3451         a GCC extension that permits arithmetic on void* pointer. Inline
3452         the macro until this issue is fixed upstream.
3453
3454 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3455
3456         Rid the world of WK_API_ENABLED
3457         https://bugs.webkit.org/show_bug.cgi?id=195263
3458
3459         Reviewed by Dan Bernstein.
3460
3461         List of changed files elided because it's useless.
3462
3463 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3464
3465         Unreviewed follow-up to r242292.
3466
3467         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3468
3469         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3470         (TestWebKitAPI::testStrip): Renamed from strip.
3471         (TestWebKitAPI::TEST):
3472
3473 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3474
3475         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3476
3477         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3478         and bug #194272 for details.
3479
3480         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3481
3482 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3483
3484         Remove some more unused 32-bit code
3485         https://bugs.webkit.org/show_bug.cgi?id=195255
3486
3487         Reviewed by Darin Adler.
3488
3489         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3490         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3491         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3492         (NPP_New):
3493         (NPP_HandleEvent):
3494         (handleEventCarbon): Deleted.
3495
3496 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3497
3498         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3499
3500         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3501         (TestWebKitAPI::TEST):
3502
3503 2019-03-01  Darin Adler  <darin@apple.com>
3504
3505         Finish removing String::format
3506         https://bugs.webkit.org/show_bug.cgi?id=194893
3507
3508         Reviewed by Daniel Bates.
3509 '
3510         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3511
3512 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3513
3514         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3515         https://bugs.webkit.org/show_bug.cgi?id=195229
3516         <rdar://problem/48520362>
3517
3518         Reviewed by Chris Dumez.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3521         (TEST):
3522
3523 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3524
3525         Add a system trace scope for event region building
3526         https://bugs.webkit.org/show_bug.cgi?id=195226
3527
3528         Reviewed by Jon Lee.
3529
3530         This trace scope measures the time spend converting element rects into Region objects,
3531         which can be large on some pages.
3532
3533         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3534
3535         * Tracing/SystemTracePoints.plist:
3536
3537 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3538
3539         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3540         https://bugs.webkit.org/show_bug.cgi?id=194612
3541
3542         Reviewed by Alex Christensen.
3543
3544         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3545         Just test the new string-processing function and don't touch the actual environment.
3546         (Test cases are all as before, but based on operator== instead of strcmp.)
3547
3548 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3549
3550         [ews-app] Update primary keys for handling multiple Buildbot instances
3551         https://bugs.webkit.org/show_bug.cgi?id=195120
3552
3553         Reviewed by Stephanie Lewis.
3554
3555         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3556         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3557         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3558
3559         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3560         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3561         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3562         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3563         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3564         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3565
3566 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3567
3568         [WinCairo] Enable service worker
3569         https://bugs.webkit.org/show_bug.cgi?id=188318
3570
3571         Reviewed by Youenn Fablet.
3572
3573         * DumpRenderTree/DumpRenderTreePrefix.h:
3574         * TestWebKitAPI/PlatformWin.cmake:
3575         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3576         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3577         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3578
3579 2019-03-01  Justin Fan  <justin_fan@apple.com>
3580
3581         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3582         https://bugs.webkit.org/show_bug.cgi?id=195191
3583
3584         Rubber-stamped by Dean Jackson.
3585
3586         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3587
3588         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3589
3590 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3591
3592         Unreviewed, fix lldb webkitpy tests
3593         https://bugs.webkit.org/show_bug.cgi?id=194375
3594
3595         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3596
3597         * lldb/lldb_webkit.py:
3598         (WTFStringImplProvider.is_8bit):
3599
3600 2019-02-28  David Quesada  <david_quesada@apple.com>
3601
3602         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3603         https://bugs.webkit.org/show_bug.cgi?id=195121
3604         rdar://problem/48450302
3605
3606         Reviewed by Alex Christensen.
3607
3608         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3609         configurations where the 'download' attribute is absent, blank, or populated
3610         with a filename, and where the anchor element is same-origin or cross-origin
3611         (meaning the 'download' attribute shouldn't be honored).
3612
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3615         (-[NavigationActionTestDelegate init]):
3616         (-[NavigationActionTestDelegate navigationAction]):
3617         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3618         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3619         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3620         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3621         (TEST):
3622
3623 2019-02-28  Antoine Quint  <graouts@apple.com>
3624
3625         Enable the Pointer Events runtime flag by default
3626         https://bugs.webkit.org/show_bug.cgi?id=195156
3627
3628         Reviewed by Dean Jackson.
3629
3630         * DumpRenderTree/mac/DumpRenderTree.mm:
3631         (enableExperimentalFeatures):
3632
3633 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3634
3635         Several PasteImage API tests are flaky
3636         https://bugs.webkit.org/show_bug.cgi?id=195160
3637
3638         Reviewed by Tim Horton.
3639
3640         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3641         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3642         listening for a "load" event after image load is already complete.
3643
3644         To address this, make these tests first register a "load" event handler, then run script to insert an image
3645         element into the document, and finally wait until the load event is observed before checking image size.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3648
3649 2019-02-28  Chris Dumez  <cdumez@apple.com>
3650
3651         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3652         https://bugs.webkit.org/show_bug.cgi?id=195107
3653
3654         Reviewed by Alex Christensen.
3655
3656         Give some time for the zoom level to get restored.
3657
3658         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3659
3660 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3661
3662         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3663         https://bugs.webkit.org/show_bug.cgi?id=194958
3664
3665         Reviewed by Geoffrey Garen.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3668         (TEST):
3669
3670 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3671
3672         [ews-app] Update method to save build to handle builder_display_name
3673         https://bugs.webkit.org/show_bug.cgi?id=195047
3674
3675         Reviewed by Dewei Zhu.
3676
3677         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3678         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3679
3680 2019-02-28  Justin Fan  <justin_fan@apple.com>
3681
3682         [Web GPU] Enable Web GPU only on 64-bit
3683         https://bugs.webkit.org/show_bug.cgi?id=195139
3684
3685         Because Metal is only supported on 64 bit apps.
3686
3687         Unreviewed build fix.
3688
3689         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3690
3691 2019-02-27  Youenn Fablet  <youenn@apple.com>
3692
3693         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3694         https://bugs.webkit.org/show_bug.cgi?id=194959
3695
3696         Reviewed by Chris Dumez.
3697
3698         Spin loop until getting the condition to remove flakiness.
3699
3700         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3701
3702 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3703
3704         [ews-build] Buildbot should include builder_display_name in the build events
3705         https://bugs.webkit.org/show_bug.cgi?id=195045
3706
3707         Reviewed by Dewei Zhu.
3708
3709         * BuildSlaveSupport/ews-build/events.py:
3710         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3711         buildername to builder_name to be consistent in naming style.
3712         (Events.buildFinished): Ditto.
3713
3714 2019-02-27  Chris Dumez  <cdumez@apple.com>
3715
3716         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3717         https://bugs.webkit.org/show_bug.cgi?id=194480
3718
3719         Reviewed by Brady Eidson.
3720
3721         Update existing API test to make it more likely to reproduce the issue.
3722
3723         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3724
3725 2019-02-27  Brady Eidson  <beidson@apple.com>
3726
3727         Universal links from Google search results pages don't open the app.
3728         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3729
3730         Reviewed by Geoffrey Garen.
3731
3732         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3733         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3734         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3735         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3736
3737 2019-02-27  Chris Dumez  <cdumez@apple.com>
3738
3739         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3740         https://bugs.webkit.org/show_bug.cgi?id=195102
3741
3742         Reviewed by Geoffrey Garen.
3743
3744         If the number of processes is not yet what we expect, wait a bit and check again to give
3745         processes some time to exit.
3746
3747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3748
3749 2019-02-27  Chris Dumez  <cdumez@apple.com>
3750
3751         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3752         https://bugs.webkit.org/show_bug.cgi?id=194545
3753
3754         Reviewed by Brady Eidson.
3755
3756         Make sure the test navigates forward and then back only once. Previously, navigating
3757         back would trigger a navigation again in a timer.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3760
3761 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3762
3763         High Sierra Debug JSC test queue should use faster hardware
3764         https://bugs.webkit.org/show_bug.cgi?id=194603
3765
3766         Rubber-stamped by Alexey Proskuryakov.
3767
3768         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/config.json:
3771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3772         (BubbleQueueServer):
3773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3774         (WebKitBuildbot):
3775         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3776         * QueueStatusServer/config/queues.py:
3777         * Scripts/webkitpy/common/config/ews.json:
3778         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3779         (test_ews_name):
3780
3781 2019-02-27  John Wilander  <wilander@apple.com>
3782
3783         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3784         https://bugs.webkit.org/show_bug.cgi?id=195071
3785         <rdar://problem/48417690>
3786
3787         Reviewed by Alex Christensen and Brent Fulgham.
3788
3789         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3790         (TestWebKitAPI::createURL):
3791             Convenience function.
3792         (TestWebKitAPI::TEST):
3793             WebCore::AdClickAttribution now takes a URL when creating Source and
3794             Destination.
3795         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3796         (TestWebKitAPI::TEST):
3797             WebCore::AdClickAttribution now takes a URL when creating Source and
3798             Destination.
3799
3800 2019-02-27  Antoine Quint  <graouts@apple.com>
3801
3802         Support Pointer Events on macOS
3803         https://bugs.webkit.org/show_bug.cgi?id=195008
3804         <rdar://problem/47454419>
3805
3806         Reviewed by Dean Jackson.
3807
3808         * DumpRenderTree/mac/DumpRenderTree.mm:
3809         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3810         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3811
3812 2019-02-26  Mark Lam  <mark.lam@apple.com>
3813
3814         Remove remaining poisoning code.
3815         https://bugs.webkit.org/show_bug.cgi?id=194138
3816
3817         Reviewed by Saam Barati.
3818
3819         * TestWebKitAPI/CMakeLists.txt:
3820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3821         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3822         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3823         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3824         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3825         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3826         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3827
3828 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3829
3830         Move ephemeral local storage from WebProcess to UIProcess
3831         https://bugs.webkit.org/show_bug.cgi?id=195074
3832         <rdar://problem/47937975>
3833
3834         Reviewed by Geoff Garen.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3837
3838 2019-02-20  Jer Noble  <jer.noble@apple.com>
3839
3840         [Cocoa] Media elements will restart network buffering just before suspending
3841         https://bugs.webkit.org/show_bug.cgi?id=193691
3842
3843         Reviewed by Eric Carlson.
3844
3845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3847         (TEST):
3848
3849 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3850
3851         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3852         https://bugs.webkit.org/show_bug.cgi?id=191652
3853
3854         Reviewed by Alex Christensen.
3855
3856         Fix WinCairo MiniBrowser behavior of authentication dialog.
3857
3858         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3859         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3860
3861 2019-02-26  Youenn Fablet  <youenn@apple.com>
3862
3863         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3864         https://bugs.webkit.org/show_bug.cgi?id=195028
3865         <rdar://problem/48243733>
3866
3867         Reviewed by Eric Carlson.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3870
3871 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3872
3873         [WPE] Add API for webview background color configuration
3874         https://bugs.webkit.org/show_bug.cgi?id=192305
3875
3876         Reviewed by Michael Catanzaro.
3877
3878         * MiniBrowser/wpe/main.cpp:
3879         (main): Add a new option to configure the webview background
3880         color. Example: --bg-color=transparent.
3881         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3882         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3883         (beforeAll): Ditto.
3884
3885 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3886
3887         scalableNativeWebpageParameters() is not preserved on new page navigation.
3888         https://bugs.webkit.org/show_bug.cgi?id=194892
3889         <rdar://problem/47538280>
3890
3891         Reviewed by Wenson Hsieh.
3892         
3893         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3894
3895         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3896         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3897         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3898         (WTR::UIScriptController::allowsViewportShrinkToFit):
3899         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3900         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3901         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3902         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3903         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3904         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3905
3906 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3907
3908         [ews-app] Add model for handling multiple Buildbot instances
3909         https://bugs.webkit.org/show_bug.cgi?id=194863
3910
3911         Reviewed by Stephanie Lewis.
3912
3913         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3914
3915 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3916
3917         [ews-app] Remove BuilderMapping table
3918         https://bugs.webkit.org/show_bug.cgi?id=194961
3919
3920         Reviewed by Stephanie Lewis.
3921
3922         Store builder name directly in build table, instead of having a separate
3923         table for it.
3924
3925         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3926         * BuildSlaveSupport/ews-app/ews/models/build.py:
3927         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3928         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3929
3930 2019-02-25  John Wilander  <wilander@apple.com>
3931
3932         Introduce and adopt new class RegistrableDomain for eTLD+1
3933         https://bugs.webkit.org/show_bug.cgi?id=194791
3934         <rdar://problem/48179240>
3935
3936         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3937
3938         This patch adds an API test and replaces two instances of
3939         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3940
3941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3942         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3943         (TestWebKitAPI::TEST):
3944             Changed two strings to make sure the registrable domains are still considered
3945             invalid and pass the test.
3946         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3947         (TestWebKitAPI::TEST):
3948         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3949         (WTR::InjectedBundle::didReceiveMessageToPage):
3950
3951 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3952
3953         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3954         https://bugs.webkit.org/show_bug.cgi?id=195001
3955
3956         Reviewed by Carlos Garcia Campos.
3957
3958         API version 1.0 always includes the functionality previously guarded with
3959         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3960         unconditionally.
3961
3962         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3963         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3964         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3965         (WebViewTest::showInWindow): Ditto.
3966         (WebViewTest::hideView): Ditto.
3967         * wpe/backends/HeadlessViewBackend.cpp:
3968         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3969         * wpe/backends/ViewBackend.cpp:
3970         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3971         * wpe/backends/WindowViewBackend.cpp:
3972         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3973         WPE_BACKEND_CHECK_VERSION().
3974         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3975
3976 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3977
3978         [Flatpak] Add support for flatpak > 1.1.2
3979         https://bugs.webkit.org/show_bug.cgi?id=194088
3980
3981         Flatpak 1.2 is now out so we need to support that
3982         version now.
3983
3984         Reviewed by Michael Catanzaro.
3985
3986         * flatpak/flatpakutils.py:
3987         (check_flatpak):
3988         (FlatpakPackages.__init__):
3989         (FlatpakPackages.__detect_packages):
3990         (FlatpakPackages.__detect_packages.in):
3991         (FlatpakRepos.update):
3992
3993 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3994
3995         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3996         https://bugs.webkit.org/show_bug.cgi?id=194998
3997
3998         Reviewed by Carlos Garcia Campos.
3999
4000         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4001         to a Git checkout and using the latest commit containing various fixes
4002         and improvements.
4003
4004 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4005
4006         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4007         https://bugs.webkit.org/show_bug.cgi?id=194981
4008
4009         Reviewed by Žan Doberšek.
4010
4011         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4012         (TestWebKitAPI::TEST):
4013
4014 2019-02-23  Keith Miller  <keith_miller@apple.com>
4015
4016         Add new mac target numbers
4017         https://bugs.webkit.org/show_bug.cgi?id=194955
4018
4019         Reviewed by Tim Horton.
4020
4021         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4022         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4023         * MiniBrowser/Configurations/Base.xcconfig:
4024         * TestWebKitAPI/Configurations/Base.xcconfig:
4025         * WebKitTestRunner/Configurations/Base.xcconfig:
4026
4027 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4028
4029         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4030         https://bugs.webkit.org/show_bug.cgi?id=194846
4031
4032         Reviewed by Don Olmstead.
4033
4034         Added _search_paths() and _port_specific_expectations_files() for
4035         WinCairoPort.
4036
4037         * Scripts/webkitpy/port/win.py:
4038         (WinCairoPort.default_baseline_search_path):
4039         (WinCairoPort):
4040         (WinCairoPort._port_specific_expectations_files):
4041         (WinCairoPort._search_paths):
4042
4043 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4044
4045         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4046         https://bugs.webkit.org/show_bug.cgi?id=194963
4047
4048         Reviewed by Dean Jackson.
4049
4050         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4051         Do a `contains` check instead of `equals`, because in debug builds we
4052         put the GraphicsLayer pointer in a prefix.
4053
4054 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4055
4056         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4057         https://bugs.webkit.org/show_bug.cgi?id=194873
4058         <rdar://problem/46701974>
4059
4060         Reviewed by Tim Horton.
4061
4062         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4063
4064         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4065         (WTR::UIScriptController::menuRect const):
4066         (WTR::UIScriptController::isShowingMenu const):
4067         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4068         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4069         (WTR::UIScriptController::menuRect const):
4070
4071         Add a function to query the bounds of the callout menu in content coordinates.
4072
4073         (WTR::UIScriptController::isShowingMenu const):
4074
4075         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4076
4077         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4078         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4079         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4080         (WTR::UIScriptController::rectForMenuAction const):
4081         (WTR::UIScriptController::menuRect const):
4082         (WTR::UIScriptController::isShowingMenu const):
4083         (WTR::findViewInHierarchyOfType): Deleted.
4084
4085 2019-02-22  Chris Dumez  <cdumez@apple.com>
4086
4087         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4088         https://bugs.webkit.org/show_bug.cgi?id=194954
4089         <rdar://problem/48127957>
4090
4091         Reviewed by Alex Christensen.
4092
4093         Add API test coverage.
4094
4095         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4096         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4097         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4098         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4099
4100 2019-02-22  Chris Dumez  <cdumez@apple.com>
4101
4102         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4103         https://bugs.webkit.org/show_bug.cgi?id=194924
4104         <rdar://problem/48216125>
4105
4106         Reviewed by Geoffrey Garen.
4107
4108         Add API test coverage.
4109
4110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4111
4112 2019-02-22  Chris Dumez  <cdumez@apple.com>
4113
4114         Unreviewed, disable API test added in r241928 on iOS.
4115
4116         The cache is not enabled on devices with less than 3GB of RAM.
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4119
4120 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4121
4122         Hardcode Visual Viewports on everywhere except iOS WK1
4123         https://bugs.webkit.org/show_bug.cgi?id=194928
4124
4125         Reviewed by Zalan Bujtas.
4126
4127         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4128         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4129         set it to false. The setting has shipped for several years and there's no need to turn
4130         it off now.
4131
4132         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4133         Visual Viewports are not enabled.
4134         
4135         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4136         that only runs in WK2
4137
4138         * MiniBrowser/mac/SettingsController.h:
4139         * MiniBrowser/mac/SettingsController.m:
4140         (-[SettingsController init]):
4141         (-[SettingsController _populateMenu]):
4142         (-[SettingsController validateMenuItem:]):
4143         (-[SettingsController visualViewportEnabled]): Deleted.
4144         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4145         * MiniBrowser/mac/WK1BrowserWindowController.m:
4146         (-[WK1BrowserWindowController didChangeSettings]):
4147         * MiniBrowser/mac/WK2BrowserWindowController.m:
4148         (-[WK2BrowserWindowController didChangeSettings]):
4149
4150 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4151
4152         Discard cached processes when clearing website data store
4153         https://bugs.webkit.org/show_bug.cgi?id=194894
4154
4155         Reviewed by Chris Dumez.
4156
4157         Added a test case.
4158
4159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4160         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4161
4162 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4163
4164         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4165         https://bugs.webkit.org/show_bug.cgi?id=194914
4166         <rdar://problem/47586889>
4167
4168         Reviewed by Geoffrey Garen.
4169
4170         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4171         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4172         (TEST):
4173         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4174
4175 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4176
4177         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4178         <https://webkit.org/b/194761>
4179
4180         Reviewed by Myles Maxfield.
4181
4182         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4183         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4184         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4185         to use ARC-compliant cast.
4186         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4187         ARC-compliant cast.
4188         (WTR::installFakeHelvetica): Log `error` to console if
4189         CTFontManagerRegisterFontsForURL() fails, but only on supported
4190         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4191         Call CFRelease() on `error` to fix the leak.  Update to use
4192         ARC-compliant cast.
4193         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4194         cast.
4195
4196 2019-02-21  Chris Dumez  <cdumez@apple.com>
4197
4198         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4199         https://bugs.webkit.org/show_bug.cgi?id=194481
4200
4201         Reviewed by Alex Christensen.
4202
4203         Give the processes a chance to shutdown and wait until we reached the expected number
4204         of processes.
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4207
4208 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4209
4210         Fix the macOS build
4211
4212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4213
4214 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4215
4216         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4219         I am a backwards.
4220
4221 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4222
4223         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4226         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4227         We could force on UI-side compositing, but I feel like the test might be more
4228         valuable exercising the normal path on each platform (though the original
4229         bug was also UI-side specific). Though we can't validate that the overlay
4230         layer was installed successfully, there are layout tests that do that.
4231
4232 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4233
4234         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4235         https://bugs.webkit.org/show_bug.cgi?id=194845
4236         <rdar://problem/47944579>
4237
4238         Reviewed by Antti Koivisto.
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4242
4243 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4244
4245         [LFC][Floats] Add support for placing formatting roots in-between floats.
4246         https://bugs.webkit.org/show_bug.cgi?id=194902
4247
4248         Reviewed by Antti Koivisto.
4249
4250         * LayoutReloaded/misc/LFC-passing-tests.txt:
4251
4252 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4253
4254         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4255         https://bugs.webkit.org/show_bug.cgi?id=194901
4256
4257         Unreviewed build fix.
4258
4259         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4260         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4261         WPEBackend-fdo-0.1 as library name.
4262
4263 2019-02-21  Rob Buis  <rbuis@igalia.com>
4264
4265         Update MIME type parser
4266         https://bugs.webkit.org/show_bug.cgi?id=180526
4267
4268         Reviewed by Darin Adler.
4269
4270         Add tests involving leading and trailing whitespace, non-token
4271         characters and quoted strings.
4272
4273         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4274         (TestWebKitAPI::TEST):
4275
4276 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4277
4278         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4279         https://bugs.webkit.org/show_bug.cgi?id=194884
4280
4281         Reviewed by Michael Catanzaro.
4282
4283         * PlatformWin.cmake:
4284
4285 2019-02-20  Chris Dumez  <cdumez@apple.com>
4286
4287         Add API test for <rdar://problem/47471222>
4288         https://bugs.webkit.org/show_bug.cgi?id=194847
4289
4290         Reviewed by Alex Christensen.
4291
4292         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4293
4294 2019-02-20  Chris Dumez  <cdumez@apple.com>
4295
4296         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4297         https://bugs.webkit.org/show_bug.cgi?id=194872
4298         <rdar://problem/47924500>
4299
4300         Reviewed by Alex Christensen.
4301
4302         Add API test coverage.
4303
4304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4305
4306 2019-02-20  Jer Noble  <jer.noble@apple.com>
4307
4308         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4309         https://bugs.webkit.org/show_bug.cgi?id=191332
4310
4311         Reviewed by Dean Jackson.
4312
4313         * Scripts/git-is-in-range: Added.
4314
4315 2019-02-20  Andy Estes  <aestes@apple.com>
4316
4317         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4318         https://bugs.webkit.org/show_bug.cgi?id=194869
4319
4320         Rubber-stamped by Jer Noble.
4321
4322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4323         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4324         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4325         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4328
4329 2019-02-20  Chris Dumez  <cdumez@apple.com>
4330
4331         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4332         https://bugs.webkit.org/show_bug.cgi?id=194857
4333         <rdar://problem/47759323>
4334
4335         Reviewed by Alex Christensen.
4336
4337         Add API test coverage.
4338
4339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4340
4341 2019-02-20  Chris Dumez  <cdumez@apple.com>
4342
4343         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4344         https://bugs.webkit.org/show_bug.cgi?id=194829
4345         <rdar://problem/47889906>
4346
4347         Reviewed by Alexey Proskuryakov.
4348
4349         Every time the TestOptions were changing we were creating both a new Web view and
4350         a new WKContext, which would start a new Network process. In most cases, we only
4351         need to contruct a new Web view and we do can keep reusing the same WKContext.
4352         This patch implements this optimization and thus avoids spinning a lot of new
4353         Network processes while running the layout tests.
4354
4355         * WebKitTestRunner/TestController.cpp:
4356         (WTR::TestController::generateContextConfiguration const):
4357         (WTR::TestController::generatePageConfiguration):
4358         (WTR::TestController::createWebViewWithOptions):
4359         (WTR::TestController::resetPreferencesToConsistentValues):
4360         (WTR::updateTestOptionsFromTestHeader):
4361         * WebKitTestRunner/TestController.h:
4362         * WebKitTestRunner/TestOptions.h:
4363         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4364         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4365         (WTR::TestOptions::hasSameInitializationOptions const):
4366         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4367         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4368         (WTR::TestController::platformAddTestOptions const):