[Qt] Remove old cruft from the qmake build system
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         [Qt] Remove old cruft from the qmake build system
4
5         Rubber-stamped by Simon Hausmann.
6
7         * DumpRenderTree/qt/DumpRenderTree.pro:
8         * qmake/mkspecs/features/default_post.prf:
9
10 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
11
12         [Qt] Enable force_static_libs_as_shared for development
13
14         Not enabled for buildbots or production-builds (part of Qt5)
15
16         Reviewed by Simon Hausmann.
17
18         * qmake/mkspecs/features/default_post.prf:
19
20 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
21
22         [Qt] Make force_static_libs_as_shared work on Mac OS
23
24         We had to move a few LIBS += around that were in the wrong place,
25         and not caught when everything was just linked into the final
26         QtWebKit library.
27
28         Reviewed by Simon Hausmann.
29
30         * qmake/mkspecs/features/default_post.prf:
31         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
32
33 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
34
35         [Qt] Fix build of WTR on Windows
36
37         Reviewed by Tor Arne Vestbø.
38
39         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
40         With qmake's unix makefile generator as well as with the MingW generator,
41         the directory where the pro file lives (WTR/) is automatically added to
42         the include search path, but not so with MSVC. Instead of relying on qmake's
43         implicit feature here, add WTR/ explicitly to the include search path.
44
45         * WebKitTestRunner/Target.pri:
46
47 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
48
49         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
50         https://bugs.webkit.org/show_bug.cgi?id=42691
51
52         Reviewed by Kenneth Rohde Christiansen.
53
54         Add implementation for testrunner.setStopProvisionalFrameLoads()
55         in WebKitTestRunner.
56
57         Original patch by Alexey Proskuryakov.
58
59         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
60         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
61         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
62         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
63         (WTR::TestRunner::TestRunner):
64         * WebKitTestRunner/InjectedBundle/TestRunner.h:
65         (TestRunner):
66         (WTR::TestRunner::setStopProvisionalFrameLoads):
67         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
68
69 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
70
71         [Qt] Fix handling of debug/release/debug_and_release/build_all
72
73         We now pick up the defaults from Qt, in default_pre (CONFIG already
74         contains the appropriate values for debug and release). We then let
75         the command line arguments to qmake, or the project files themselves,
76         override the configuration, and finally we sanitize the configuration
77         in default_post.
78
79         Reviewed by Simon Hausmann.
80
81         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
82         * Scripts/webkitdirs.pm:
83         (buildQMakeProjects):
84         * qmake/mkspecs/features/default_post.prf:
85         * qmake/mkspecs/features/default_pre.prf:
86         * qmake/mkspecs/features/mac/default_pre.prf:
87
88 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
89
90         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
91         https://bugs.webkit.org/show_bug.cgi?id=42687
92
93         Reviewed by Kenneth Rohde Christiansen.
94
95         Implement testRunner.setTabKeyCyclesThroughElements for
96         WebKitTestRunner.
97
98         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
99         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
100         (WTR::InjectedBundle::beginTesting):
101         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
102         (WTR::TestRunner::setTabKeyCyclesThroughElements):
103         (WTR):
104         * WebKitTestRunner/InjectedBundle/TestRunner.h:
105         (TestRunner):
106
107 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
108
109         EventSendingController::keyDown does not support non-array modifier arguments
110         https://bugs.webkit.org/show_bug.cgi?id=96727
111
112         Reviewed by Kenneth Rohde Christiansen.
113
114         Add support for handling a string as modifier argument to
115         EventSendingController::keyDown.
116
117         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
118         (WTR::parseModifierArray):
119
120 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
121
122         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
123         https://bugs.webkit.org/show_bug.cgi?id=42546
124
125         Reviewed by Kenneth Rohde Christiansen.
126
127         Exported TestRunner::setCustomPolicyDelegate() method.
128         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
129
130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
132         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
133
134 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
135
136         [GTK] Clear application cache between tests in DumpRenderTree
137         https://bugs.webkit.org/show_bug.cgi?id=96543
138
139         Reviewed by Philippe Normand.
140
141         Call the new DumpRenderTreeSupportGtk method to clear application cache
142         after each test in DumpRenderTree.
143
144         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
145         as well. It's now being set in XvfbDriver._start so that each driver is assigned
146         a cache directory that's constructed out of the driver's name and its worker
147         number. These directories are located in the layout tests results directory.
148         At least on the builders this ensures a driver-specific empty cache directory
149         with each test run.
150
151         * DumpRenderTree/gtk/DumpRenderTree.cpp:
152         (runTest):
153         * Scripts/webkitpy/layout_tests/port/gtk.py:
154         (GtkPort.setup_environ_for_server):
155         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
156         (XvfbDriver._start):
157
158 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
159
160         [Qt] Fix linking on Windows
161
162         Reviewed by Tor Arne Vestbø.
163
164         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
165         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
166         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
167         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
168
169         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
170         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
171         after the module. Therefore QT did never contain webkit anymore and we always passed
172         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
173
174         This patch introduces a creating_module configuration that is used to
175         scope the qt/pkgconfig sanitization.
176
177         * qmake/mkspecs/features/default_post.prf:
178
179 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
180
181         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
182         https://bugs.webkit.org/show_bug.cgi?id=96740
183
184         Reviewed by Kenneth Rohde Christiansen.
185
186         Dump information expected by the test cases about the following
187         frame load callbacks:
188         "didDisplayInsecureContentForFrame"
189         "didRunInsecureContentForFrame"
190         "didDetectXSSForFrame"
191
192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
193         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
194         as expected by test results by calling pathSuitableForTestResult() instead
195         of printing raw URL.
196         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
197         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
198         (WTR::InjectedBundlePage::didDetectXSSForFrame):
199
200 2012-09-14  Peter Beverloo  <peter@chromium.org>
201
202         The runtime/unsigned category should be valid in the cpp style-checker.
203         https://bugs.webkit.org/show_bug.cgi?id=96748
204
205         Reviewed by Csaba Osztrogonác.
206
207         This is causing the webkitpy tests to fail because it's not listed in the
208         category array. Furthermore, change an "int" to "long" because it's
209         throwing a double error in one of the earlier asserts.
210
211         * Scripts/webkitpy/style/checkers/cpp.py:
212         (CppChecker):
213         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
214         (WebKitStyleTest.test_names):
215
216 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
217
218         Evas_Object* is a ref'ed structure, so tread it as such
219         https://bugs.webkit.org/show_bug.cgi?id=96659
220
221         Reviewed by Adam Barth.
222
223         Replace OwnPtr<Evas_Object> with RefPtr.
224
225         * DumpRenderTree/efl/ImageDiff.cpp:
226         (calculateDifference):
227         (printImageDifferences):
228         (readImageFromStdin):
229         (main):
230
231 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
232
233         Unreviewed, rolling out r128507.
234         http://trac.webkit.org/changeset/128507
235         https://bugs.webkit.org/show_bug.cgi?id=96659
236
237         Revert. r128507 makes too many crashes in EFL layout test bots.
238
239         * DumpRenderTree/efl/ImageDiff.cpp:
240         (calculateDifference):
241         (printImageDifferences):
242         (readImageFromStdin):
243         (main):
244
245 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
246
247         Make compile with both OS(WINCE) and PLATFORM(QT) support
248         https://bugs.webkit.org/show_bug.cgi?id=95536
249
250         Reviewed by Simon Hausmann.
251
252         Fix wince support in qmake files
253
254         * Tools.pro:
255         * qmake/mkspecs/features/configure.prf:
256         * qmake/mkspecs/features/default_post.prf:
257         * qmake/mkspecs/features/features.prf:
258         * qmake/mkspecs/features/functions.prf:
259
260 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
261
262         [WK2] Add color picker API support for WebKit2
263         https://bugs.webkit.org/show_bug.cgi?id=95058
264
265         Reviewed by Gyuyoung Kim.
266
267         Initialization code for color picker callbacks in UI client.
268
269         * MiniBrowser/mac/BrowserWindowController.m:
270         (-[BrowserWindowController awakeFromNib]):
271         * MiniBrowser/win/BrowserView.cpp:
272         (BrowserView::create):
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::TestController::createOtherPage):
275         (WTR::TestController::initialize):
276
277 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
278
279         Upgrade yutak to reviewer
280         https://bugs.webkit.org/show_bug.cgi?id=96721
281
282         Reviewed by Kent Tamura.
283
284         * Scripts/webkitpy/common/config/committers.py:
285
286 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
287
288         Make the style checker report usage of "unsigned int"
289         https://bugs.webkit.org/show_bug.cgi?id=96693
290
291         Reviewed by Dirk Pranke.
292
293         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
294
295         * Scripts/webkitpy/style/checkers/cpp.py:
296         (check_language):
297
298 2012-09-13  Philip Rogers  <pdr@google.com>
299
300         Add gender-neutral form of webkit-patch land-cowboy
301         https://bugs.webkit.org/show_bug.cgi?id=96709
302
303         Reviewed by Adam Barth.
304
305         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
306
307         * Scripts/webkitpy/tool/commands/download.py:
308         (LandCowhand):
309
310 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
311
312         [EFL] Remove some parameters in browserCreate()
313         https://bugs.webkit.org/show_bug.cgi?id=96499
314
315         Reviewed by Kenneth Rohde Christiansen.
316
317         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
318         And I have moved some parameters into User_Arguments.
319
320         * EWebLauncher/main.c:
321         (_User_Arguments):
322         (_ELauncher):
323         (on_key_down):
324         (browserCreate):
325         (findThemePath):
326         (parseUserArguments):
327         (main):
328
329 2012-09-13  Mark Lam  <mark.lam@apple.com>
330
331         Unreviewed. Adding myself to the committers list.
332
333         * Scripts/webkitpy/common/config/committers.py:
334
335 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
336
337         run-perf-tests output cryptic error when the config file is missing.
338         https://bugs.webkit.org/show_bug.cgi?id=96453
339
340         Reviewed by Tony Chang.
341
342         Add a special error message when a configuration file is missing.
343
344         Also update the help message of --source-json-path to signify the fact it specifies
345         the configuration file on performance tests bots.
346
347         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
348         (PerfTestsRunner._parse_args):
349         (PerfTestsRunner._generate_and_show_results):
350         (PerfTestsRunner._merge_slave_config_json):
351         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
352         (_test_run_with_json_output): Make upload to fail by default and assert the result
353         in the function so that we can return logs instead.
354         (_test_run_with_json_output.mock_upload_json):
355         (test_run_with_json_output):
356         (test_run_with_description):
357         (test_run_respects_no_results):
358         (test_run_with_slave_config_json):
359         (test_run_with_bad_slave_config_json):
360         (test_run_with_multiple_repositories):
361
362 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
363
364         Evas_Object* is a ref'ed structure, so tread it as such
365         https://bugs.webkit.org/show_bug.cgi?id=96659
366
367         Reviewed by Adam Barth.
368
369         Replace OwnPtr<Evas_Object> with RefPtr.
370
371         * DumpRenderTree/efl/ImageDiff.cpp:
372         (calculateDifference):
373         (printImageDifferences):
374         (readImageFromStdin):
375         (main):
376
377 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
378
379         One more unreviewed trivial fix after r128399.
380
381         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
382
383 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
384
385         Unreviewed trivial fix after r128399.
386
387         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
388         (getLatestSVNRevision):
389         (waitForSVNRevision):
390
391 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
392
393         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
394         https://bugs.webkit.org/show_bug.cgi?id=96366
395
396         Reviewed by Anders Carlsson.
397
398         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
399         by calling shouldClose() on the FrameLoader.
400
401         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
402         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
403         (WTR::TestRunner::callShouldCloseOnWebView):
404         (WTR):
405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
406         (TestRunner):
407
408 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
409
410         Unreviewed, rolling out r128453.
411         http://trac.webkit.org/changeset/128453
412         https://bugs.webkit.org/show_bug.cgi?id=96681
413
414         Having tests use the same appcache directory leads to timeouts
415         (Requested by zdobersek on #webkit).
416
417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
418         (runTest):
419         * Scripts/webkitpy/layout_tests/port/gtk.py:
420         (GtkPort.setup_environ_for_server):
421
422 2012-09-13  James Robinson  <jamesr@chromium.org>
423
424         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
425         https://bugs.webkit.org/show_bug.cgi?id=96678
426
427         Reviewed by Dirk Pranke.
428
429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
430         (.):
431
432 2012-09-13  Rob Buis  <rbuis@rim.com>
433
434         Unreviewed changes to watchlist.
435
436         - Add myself to BlackBerry bugs
437
438         * Scripts/webkitpy/common/config/watchlist:
439
440 2012-09-13  Stephen Chenney  <schenney@chromium.org>
441
442         Add an SVG entry to the watchlist
443
444         Unreviewed config change.
445
446         * Scripts/webkitpy/common/config/watchlist:
447         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
448         - Added myself and pdr as watchers
449
450 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
451
452         [Qt] Make WebKit2 work on Windows with Qt 5
453         https://bugs.webkit.org/show_bug.cgi?id=76776
454
455         Reviewed by Tor Arne Vestbø.
456
457         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
458         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
459         that for the GL TextureMapper (it's only built when that feature is set).
460
461         * qmake/mkspecs/features/configure.prf:
462
463 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
464
465         [Qt] Ensure that QT is finalized before loading qt_module.prf
466
467         As qt_module.prf does dependency tracking based on the content of the
468         QT variable. The intermediate WebKit modules modify the variable in
469         their .pri files, so we have to ensure we've loaded all the modules
470         before loading qt_module.
471
472         Reviewed by Tor Arne Vestbø.
473         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
474
475         * qmake/mkspecs/features/default_post.prf:
476         * qmake/mkspecs/features/webkit_modules.prf: Added.
477
478 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
479
480         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
481         https://bugs.webkit.org/show_bug.cgi?id=96633
482
483         Reviewed by Csaba Osztrogonác.
484
485         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
486         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
487         It's the usual problem and the usual solution is to rename one of the conflicting files.
488         This patch chooses to rename DRT instead of WTR and MBR.
489
490         Fixed include order at the same time to match style guide.
491
492         * DumpRenderTree/qt/DumpRenderTree.pro:
493         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
494         (messageHandler):
495         (isOption):
496         (takeOptionValue):
497         (printUsage):
498         (main):
499
500 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
501
502         The Script run-launcher should support -2 in combination with --efl
503         https://bugs.webkit.org/show_bug.cgi?id=96639
504
505         Reviewed by Simon Hausmann.
506
507         Support running the MiniBrowser then supplied -2 as argument.
508
509         * Scripts/run-launcher:
510
511 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
512
513         Unreviewed, add my Intel email address to the list.
514
515         * Scripts/webkitpy/common/config/committers.py:
516
517 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
518
519         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
520
521         Reviewed by Ossy.
522
523         * qmake/mkspecs/features/default_post.prf:
524
525 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
526
527         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
528         https://bugs.webkit.org/show_bug.cgi?id=82294
529
530         Reviewed by Gyuyoung Kim.
531
532         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
533
534         * DumpRenderTree/efl/TestRunnerEfl.cpp:
535         (TestRunner::layerTreeAsText):
536
537 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
538
539         [GTK] Clear application cache between tests in DumpRenderTree
540         https://bugs.webkit.org/show_bug.cgi?id=96543
541
542         Reviewed by Philippe Normand.
543
544         Call the new DumpRenderTreeSupportGtk method to clear application cache
545         after each test.
546
547         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
548         as well. Currently it points to a subdirectory in the layout tests results
549         directory. At least on the builders this ensures an empty cache directory
550         with each test run.
551
552         * DumpRenderTree/gtk/DumpRenderTree.cpp:
553         (runTest):
554         * Scripts/webkitpy/layout_tests/port/gtk.py:
555         (GtkPort.setup_environ_for_server):
556
557 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
558
559         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
560
561         Unless it's actually a dependency of the public QtWebKit API.
562
563         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
564         files with their _PRIVATE equivivalent, but that's likely to break when
565         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
566         clean up the variables in default_post.
567
568         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
569         longer needed, as it was a workaround for the intermediate libraries ending
570         up in the prl file. And, since CONFIG -= staticlib was there to support
571         the explicitlib option, we can remove that too (as well as the exception
572         for gprof, since it would be empty). If gprof needs tweaks to always link
573         statically they should go in gprof.prf.
574
575         Reviewed by Simon Hausmann.
576
577         * qmake/mkspecs/features/default_post.prf:
578         * qmake/mkspecs/features/functions.prf:
579
580 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
581
582         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
583         https://bugs.webkit.org/show_bug.cgi?id=96632
584
585         Reviewed by Carlos Garcia Campos.
586
587         Fix this by using atk_object_get_n_accessible_children instead of
588         calling getChildren() from childCount.
589
590         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
591         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
592         loop by using atk_object_get_n_accessible_children().
593
594 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
595
596         [Qt][Win] Enable USE(3D_GRAPHICS)
597         https://bugs.webkit.org/show_bug.cgi?id=90879
598
599         Reviewed by Kenneth Rohde Christiansen.
600
601         Enable it on Windows as well as on QNX (bug fixed).
602
603         * qmake/mkspecs/features/features.prf:
604
605 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
606
607         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
608         https://bugs.webkit.org/show_bug.cgi?id=96359
609
610         Reviewed by Tor Arne Vestbø.
611
612         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
613         lexer. The only viable alternative I could find on Windows that provides
614         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
615         so let's use that one instead.
616
617         * Scripts/webkitdirs.pm:
618         (checkRequiredSystemConfig):
619         * qmake/mkspecs/features/default_pre.prf:
620
621 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
622
623         [Qt] Add configuration for production builds
624         https://bugs.webkit.org/show_bug.cgi?id=96607
625
626         Reviewed by Kenneth Rohde Christiansen.
627
628         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
629         and enable all-in-one-files optimizations.
630
631         * qmake/mkspecs/features/production_build.prf: Added.
632
633 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
634
635         [Qt] GStreamer detection does not work when cross-compiling
636         https://bugs.webkit.org/show_bug.cgi?id=96608
637
638         Reviewed by Kenneth Rohde Christiansen.
639
640         When cross-compiling it is not safe to just use system(pkg-config),
641         because there is a high probability that it will find packages in the
642         host system instead of in the target one. Instead use qmake's new
643         packagesExist() function that takes care of this delicate aspect of
644         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
645         PKG_CONFIG_LIBDIR accordingly.
646
647         * qmake/mkspecs/features/features.prf:
648
649 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
650
651         [WK2][WTR] More efficient string handling in InjectedBundlePage
652         https://bugs.webkit.org/show_bug.cgi?id=96609
653
654         Reviewed by Kenneth Rohde Christiansen.
655
656         Update StringBuilder usage in InjectedBundlePage to follow
657         the latest recommandations for efficient string handling:
658         http://trac.webkit.org/wiki/EfficientStrings
659
660         This involves using appendLiteral() or appendNumber()
661         instead of append() whenever possible.
662
663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664         (WTR::dumpPath):
665         (WTR::rangeToStr):
666         (WTR::styleDecToStr):
667         (WTR::frameToStr):
668         (WTR::dumpResourceURL):
669         (WTR):
670         (WTR::dumpFrameDescriptionSuitableForTestResult):
671         (WTR::dumpRequestDescriptionSuitableForTestResult):
672         (WTR::dumpResponseDescriptionSuitableForTestResult):
673         (WTR::dumpErrorDescriptionSuitableForTestResult):
674         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
675         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
676         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
677         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
678         (WTR::InjectedBundlePage::didCommitLoadForFrame):
679         (WTR::InjectedBundlePage::didFinishProgress):
680         (WTR::dumpFrameScrollPosition):
681         (WTR::dumpFrameText):
682         (WTR::dumpDescendantFramesText):
683         (WTR::InjectedBundlePage::didFinishLoadForFrame):
684         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
685         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
686         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
687         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
688         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
689         (WTR::InjectedBundlePage::willSendRequestForFrame):
690         (WTR::InjectedBundlePage::didReceiveResponseForResource):
691         (WTR::InjectedBundlePage::didFinishLoadForResource):
692         (WTR::InjectedBundlePage::didFailLoadForResource):
693         (WTR::InjectedBundlePage::shouldCacheResponse):
694         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
695         (WTR::InjectedBundlePage::willAddMessageToConsole):
696         (WTR::InjectedBundlePage::willSetStatusbarText):
697         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
698         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
699         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
700         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
701         (WTR::InjectedBundlePage::shouldBeginEditing):
702         (WTR::InjectedBundlePage::shouldEndEditing):
703         (WTR::InjectedBundlePage::shouldInsertNode):
704         (WTR::InjectedBundlePage::shouldInsertText):
705         (WTR::InjectedBundlePage::shouldDeleteRange):
706         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
707         (WTR::InjectedBundlePage::shouldApplyStyle):
708         (WTR::InjectedBundlePage::didBeginEditing):
709         (WTR::InjectedBundlePage::didEndEditing):
710         (WTR::InjectedBundlePage::didChange):
711         (WTR::InjectedBundlePage::didChangeSelection):
712         (WTR::InjectedBundlePage::supportsFullScreen):
713         (WTR::InjectedBundlePage::enterFullScreenForElement):
714         (WTR::InjectedBundlePage::exitFullScreenForElement):
715         (WTR::InjectedBundlePage::beganEnterFullScreen):
716         (WTR::InjectedBundlePage::beganExitFullScreen):
717         (WTR::InjectedBundlePage::closeFullScreen):
718         (WTR::dumpBackForwardListItem):
719         (WTR::InjectedBundlePage::dumpBackForwardList):
720
721 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
722
723         [Qt][WK2] Memory leaks in Qt's TestRunner
724         https://bugs.webkit.org/show_bug.cgi?id=96603
725
726         Reviewed by Csaba Osztrogonác.
727
728         Fix memory leaks in Qt's TestRunner code by adopting WKString
729         created with WKStringCreateWithUTF8CString().
730
731         * WebKitTestRunner/qt/TestControllerQt.cpp:
732         (WTR::TestController::initializeInjectedBundlePath):
733         (WTR::TestController::initializeTestPluginDirectory):
734
735 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
736
737         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
738         https://bugs.webkit.org/show_bug.cgi?id=96506
739
740         Reviewed by Dirk Pranke.
741
742         Lower the timeout value to 6 seconds for release configuration and 12 seconds
743         for debug configuration. These are the same values the Chromium port uses.
744
745         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
746         the layout tests under WebKit2 generally) requires more attention and gardening
747         than what the current effort produces.
748
749         The unit test is updated as well to test these changes.
750
751         * Scripts/webkitpy/layout_tests/port/gtk.py:
752         (GtkPort.default_timeout_ms):
753         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
754         (GtkPortTest.test_default_timeout_ms):
755         (GtkPortTest.assertLinesEqual):
756
757 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
758
759         Add SVN mirror handling feature to build.webkit.org
760         https://bugs.webkit.org/show_bug.cgi?id=85887
761
762         Reviewed by Dirk Pranke.
763
764         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
765         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
766         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
767         (ConfigureBuild.start):
768         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
769         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
770         (Factory.__init__):
771         (BuildFactory.__init__):
772         (TestFactory.__init__):
773         (BuildAndTestFactory.__init__):
774         (BuildAndPerfTestFactory.__init__):
775         (BuildAndPerfTestWebKit2Factory.__init__):
776         (DownloadAndPerfTestFactory.__init__):
777         (DownloadAndPerfTestWebKit2Factory.__init__):
778         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
779         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
780         (SVNMirrorTest):
781         (SVNMirrorTest.setUp): Load config.json once at startup.
782         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
783         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
784         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
785         (getLatestSVNRevision): Get the latest SVN revison from the given server.
786         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
787                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
788
789 2012-09-12  Kangil Han  <kangil.han@samsung.com>
790
791         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
792         https://bugs.webkit.org/show_bug.cgi?id=81606
793
794         Reviewed by Tim Horton.
795
796         6 seconds is harsh for some jquery test cases.
797         Therefore, adjust the value to match DumpRenderTree.
798
799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
800         (WTR):
801
802 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
803
804         [EFL] Support download attribute feature
805         https://bugs.webkit.org/show_bug.cgi?id=96462
806
807         Reviewed by Gyuyoung Kim.
808
809         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
810         and add "download,request" callback to the DumpRenderTree for EFL.
811
812         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
813         (DumpRenderTreeChrome::createView):
814         (DumpRenderTreeChrome::onDownloadRequest):
815         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
816         (DumpRenderTreeChrome):
817         * Scripts/webkitperl/FeatureList.pm:
818
819 2012-09-12  Stephanie Lewis  <slewis@apple.com>
820
821         Reduce parallism on the wk2 testers.
822         https://bugs.webkit.org/show_bug.cgi?id=95906
823
824         Reviewed by Dirk Pranke.
825
826         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
827         resource contention.  Reducing the number of processes alleviates the issue.  
828
829         Starting by reducing 25%.
830
831         * Scripts/webkitpy/layout_tests/port/mac.py:
832         (MacPort.default_child_processes):
833
834 2012-09-12  Brady Eidson  <beidson@apple.com>
835
836         Assert in NetscapePlugin::destroy() with async plugin init
837         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
838
839         Reviewed by Anders Carlsson.
840
841         Expose NPN_Invoke to plug-in tests:
842         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
843         (PluginTest::NPN_Invoke):
844         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
845         (PluginTest):
846
847         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
848         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
849         (InvokeDestroysPluginWithinNPP_New):
850         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
851         (InvokeDestroysPluginWithinNPP_New::NPP_New):
852         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
853
854 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
855
856         refactor TestExpectations tokenization slightly in preparation for the new syntax
857         https://bugs.webkit.org/show_bug.cgi?id=96564
858
859         Reviewed by Ojan Vafai.
860
861         This change changes how we will tokenize/lex the
862         TestExpectations files, in preparation for supporting both the
863         old syntax and the new one. This change by itself should be a
864         no-op.
865
866         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
867         (TestExpectationParser._tokenize_line):
868         (TestExpectationParser):
869         (TestExpectationParser._tokenize_line_using_old_format):
870         (TestExpectationParser._tokenize_line_using_new_format):
871
872 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
873
874         remove unused testexpectations editing code from webkitpy, garden-o-matic
875         https://bugs.webkit.org/show_bug.cgi?id=96562
876
877         Reviewed by Adam Barth.
878
879         This code was prototyped but never fully realized. Removing
880         until it reanimates :).
881
882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
884         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
885         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
886         * Scripts/webkitpy/tool/servers/gardeningserver.py:
887         (BuildCoverageExtrapolator.extrapolate_test_configurations):
888         (GardeningHTTPRequestHandler._run_webkit_patch):
889         (GardeningHTTPRequestHandler.ping):
890         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
891         (BuildCoverageExtrapolatorTest.test_extrapolate):
892         (GardeningServerTest.test_rebaseline_new_port):
893
894 2012-09-12  Lucas Forschler  <lforschler@apple.com>
895
896         Remove unused bot, apple-xserve-1.
897         https://bugs.webkit.org/show_bug.cgi?id=96570
898         
899         Reviewed by Stephanie Lewis.
900
901         * BuildSlaveSupport/build.webkit.org-config/config.json:
902
903 2012-09-12  Xan Lopez  <xlopez@igalia.com>
904
905         [GTK] We attempt to rebase documentation even if it's not present
906         https://bugs.webkit.org/show_bug.cgi?id=96553
907
908         Reviewed by Martin Robinson.
909
910         Do not make the documentation rebase step fatal. This allows make
911         install to succeed when there's no documentation generated.
912
913         * gtk/generate-gtkdoc:
914
915 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
916
917         Respect WEBKITOUTPUTDIR when running EFL tests
918         https://bugs.webkit.org/show_bug.cgi?id=96528
919
920         Reviewed by Dirk Pranke.
921
922         Expose user set WEBKITOUTPUTDIR to the web process.
923
924         * Scripts/webkitpy/layout_tests/port/driver.py:
925         (Driver._start): Add WEBKITOUTPUTDIR to the environment
926         of the web process and its potential jhbuild wrapper.
927
928 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
929
930         webkitdirs: fix uname version handling for cygwin
931         https://bugs.webkit.org/show_bug.cgi?id=96436
932
933         Reviewed by Jon Honeycutt.
934
935         Newer versions of cygwin embed an additional version string
936         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
937         Update the code to handle that.
938
939         * Scripts/webkitdirs.pm:
940         (setupAppleWinEnv):
941
942 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
943
944         Regression(r128338): Broke Windows build
945         https://bugs.webkit.org/show_bug.cgi?id=96537
946
947         Unreviewed build fix.
948
949         Fix Apple-Win build by allocating array dynamically
950         since its size is not constant.
951
952         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
953         (WTR::stringArrayToJS):
954
955 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
956
957         [chromium] Add a virtual test suite for fast/hidpi
958         https://bugs.webkit.org/show_bug.cgi?id=90192
959
960         Reviewed by Dirk Pranke.
961
962         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
963         on the hardware accelerated path as the software path.
964
965         * DumpRenderTree/chromium/WebPreferences.cpp:
966         (WebPreferences::applyTo):
967         * Scripts/webkitpy/layout_tests/port/chromium.py:
968         (ChromiumPort.virtual_test_suites):
969
970 2012-09-12  Adam Klein  <adamk@chromium.org>
971
972         [chromium] Add content_browsertests to the flakiness dashboard
973         https://bugs.webkit.org/show_bug.cgi?id=96535
974
975         Reviewed by Ojan Vafai.
976
977         * TestResultServer/static-dashboards/dashboard_base.js:
978
979 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
980
981         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
982         https://bugs.webkit.org/show_bug.cgi?id=96496
983
984         Reviewed by Kenneth Rohde Christiansen.
985
986         Add implementation for originsWithApplicationCache to
987         WebKitTestRunner.
988
989         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
991         (WTR::stringArrayToJS):
992         (WTR):
993         (WTR::TestRunner::originsWithApplicationCache):
994         * WebKitTestRunner/InjectedBundle/TestRunner.h:
995         (TestRunner):
996
997 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
998
999         Fix Qt/Windows build with Python3
1000         https://bugs.webkit.org/show_bug.cgi?id=96473
1001
1002         Reviewed by Csaba Osztrogonác.
1003
1004         In Python 3 print is a real function, so we must use parentheses around
1005         the function parameters. This is backwards compatible with Python 2.
1006
1007         * Scripts/generate-win32-export-forwards:
1008
1009 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1010
1011         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1012
1013         As pointed out by Kevin, we should inject the "set PATH=..." statement
1014         to add the GnuWin32 directory only if that directory actually exists.
1015
1016         * qmake/mkspecs/features/default_post.prf:
1017
1018 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1019
1020         [EFL] [WK2] Memory leaks in TestControllerEfl
1021         https://bugs.webkit.org/show_bug.cgi?id=96525
1022
1023         Reviewed by Kenneth Rohde Christiansen.
1024
1025         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1026         of WKString created with WKStringCreateWithUTF8CString().
1027
1028         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1029         (WTR::TestController::initializeInjectedBundlePath):
1030         (WTR::TestController::initializeTestPluginDirectory):
1031
1032 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1033
1034         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1035         https://bugs.webkit.org/show_bug.cgi?id=96374
1036
1037         Reviewed by Kenneth Rohde Christiansen.
1038
1039         Implement support for dumpApplicationCacheDelegateCallbacks
1040         and disallowIncreaseForApplicationCacheQuota in
1041         WebKitTestRunner and properly dump the information
1042         expected by the tests.
1043
1044         If the application cache quota is reached for a given
1045         security origin, WebKitTestRunner will reset the quota
1046         to its default value, unless intructed not to via
1047         disallowIncreaseForApplicationCacheQuota().
1048
1049         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1050         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1051         (WTR::InjectedBundlePage::InjectedBundlePage):
1052         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1053         (WTR):
1054         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1055         (InjectedBundlePage):
1056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1057         (WTR::TestRunner::TestRunner):
1058         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1059         (WTR):
1060         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1061         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1062         (TestRunner):
1063         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1064         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1065
1066 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1067
1068         [chromium] remove deprecated and unused sets import from chromium_android driver
1069         https://bugs.webkit.org/show_bug.cgi?id=96485
1070
1071         Reviewed by Dirk Pranke.
1072
1073         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1074
1075 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1076
1077         Flakiness dashboard doesn't recognize new Chromium Android test builder
1078         https://bugs.webkit.org/show_bug.cgi?id=96523
1079
1080         Reviewed by Ojan Vafai.
1081
1082         Properly return 'ANDROID' as the Chromium platform for Android builders.
1083
1084         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1085         (chromiumPlatform):
1086         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1087         (test):
1088
1089 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1090
1091         [Qt] Build on Windows requires bison/flex in PATH
1092         https://bugs.webkit.org/show_bug.cgi?id=96358
1093
1094         Reviewed by Tor Arne Vestbø.
1095
1096         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1097         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1098         a separate installation of various GNU tools is required as the operating system doesn't come with
1099         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1100         the gnuwin32 directory of the qt5.git top-level repository.
1101
1102         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1103
1104         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1105         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1106         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1107         updated with the new tool.
1108
1109         * Scripts/webkitdirs.pm:
1110         (checkRequiredSystemConfig):
1111         * qmake/mkspecs/features/default_post.prf:
1112
1113 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1114
1115         [Qt] Update build-jsc after r128174
1116
1117         Reviewed by Ossy.
1118
1119         * Scripts/build-jsc:
1120
1121 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1122
1123         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1124
1125         By hard-coding the names of the targets we defined we ended up just
1126         redefining the previous target when using addStrictSubdirOrderBetween
1127         more than once in a single project file.
1128
1129         We now embed the two base targets into the target names.
1130
1131         Reviewed by Simon Hausmann.
1132
1133         * qmake/mkspecs/features/functions.prf:
1134
1135 2012-09-12  Philippe Liard  <pliard@google.com>
1136
1137         Depend on {base,net} GYP targets rather than {base,net}_java.
1138         https://bugs.webkit.org/show_bug.cgi?id=95690
1139
1140         Reviewed by Adam Barth.
1141
1142         {base,net}_java became 'private' targets on the Chromium side that
1143         clients should not depend on (see
1144         https://chromiumcodereview.appspot.com/10913083/).
1145         This removes a bunch of trailing white spaces additionally in
1146         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1147
1148         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1149         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1150
1151 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1152
1153         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1154         https://bugs.webkit.org/show_bug.cgi?id=96494
1155
1156         Reviewed by Tor Arne Vestbø.
1157
1158         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1159         plugin process feature if we don't have NPAPI.
1160
1161         * qmake/mkspecs/features/features.prf:
1162
1163 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1164
1165         Unreviewed, rolling out r128280.
1166         http://trac.webkit.org/changeset/128280
1167         https://bugs.webkit.org/show_bug.cgi?id=96498
1168
1169         it broke compilation on windows debug bot (Requested by loislo
1170         on #webkit).
1171
1172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1174         (WTR::InjectedBundlePage::InjectedBundlePage):
1175         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1176         (InjectedBundlePage):
1177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1178         (WTR::TestRunner::TestRunner):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1180         (TestRunner):
1181
1182 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1183
1184         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1185         https://bugs.webkit.org/show_bug.cgi?id=96488
1186
1187         Reviewed by Tor Arne Vestbø.
1188
1189         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1190         because there are no such targets. We want the generated sources to be independent from release
1191         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1192         redirect to the same general-purpose target (first) of creating the derived sources.
1193
1194         * qmake/mkspecs/features/default_post.prf:
1195
1196 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1197
1198         [EFL] Make DumpRenderTree smarter at finding the fonts
1199         http://webkit.org/b/96281
1200
1201         Reviewed by Gyuyoung Kim.
1202
1203         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1204         Use CString consistently.
1205
1206         * DumpRenderTree/efl/FontManagement.cpp:
1207         (buildPath):
1208         (getCoreFontFiles):
1209         (addFontDirectory):
1210         (addFontFiles):
1211         (getCustomBuildDir):
1212         (getPlatformFontsPath):
1213         (addFontsToEnvironment):
1214
1215 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1216
1217         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1218         https://bugs.webkit.org/show_bug.cgi?id=96374
1219
1220         Reviewed by Kenneth Rohde Christiansen.
1221
1222         Implement support for dumpApplicationCacheDelegateCallbacks
1223         and disallowIncreaseForApplicationCacheQuota in
1224         WebKitTestRunner and properly dump the information
1225         expected by the tests.
1226
1227         If the application cache quota is reached for a given
1228         security origin, WebKitTestRunner will reset the quota
1229         to its default value, unless intructed not to via
1230         disallowIncreaseForApplicationCacheQuota().
1231
1232         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1233         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1234         (WTR::InjectedBundlePage::InjectedBundlePage):
1235         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1236         (WTR):
1237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1238         (InjectedBundlePage):
1239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1240         (WTR::TestRunner::TestRunner):
1241         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1242         (WTR):
1243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1244         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1245         (TestRunner):
1246         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1247         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1248
1249 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1250
1251         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1252         https://bugs.webkit.org/show_bug.cgi?id=96388
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         Exported TestRunner.workerThreadCount as readonly attribute.
1257
1258         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1259         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1260         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1261         (WTR):
1262         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1263         (TestRunner):
1264
1265 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1266
1267         [chromium] Consume a user gesture when creating a new view.
1268         https://bugs.webkit.org/show_bug.cgi?id=96373
1269
1270         Reviewed by Adam Barth.
1271
1272         * DumpRenderTree/chromium/WebViewHost.cpp:
1273         (WebViewHost::createView):
1274
1275 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1276
1277         [WK2][WTR] Some of TestRunner special options are not reset before testing
1278         https://bugs.webkit.org/show_bug.cgi?id=96384
1279
1280         Reviewed by Kenneth Rohde Christiansen.
1281
1282         Now values of the following special options are reset:
1283         void setAcceptsEditing(in boolean value);
1284         void setCloseRemainingWindowsWhenComplete(in boolean value);
1285         void setXSSAuditorEnabled(in boolean value);
1286         void setAllowFileAccessFromFileURLs(in boolean value);
1287         void setPluginsEnabled(in boolean value);
1288         void setPopupBlockingEnabled(in boolean value);
1289
1290         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1291         (WTR::InjectedBundle::beginTesting):
1292
1293 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1294
1295         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1296         https://bugs.webkit.org/show_bug.cgi?id=96273
1297
1298         Reviewed by Gyuyoung Kim.
1299
1300         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1301         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1302
1303         * WebKitTestRunner/CMakeLists.txt:
1304
1305 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1306
1307         [chromium] rename webkit_resources
1308         https://bugs.webkit.org/show_bug.cgi?id=95874
1309
1310         Reviewed by James Robinson.
1311
1312         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1313
1314 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1315
1316         [chromium] don't include content shell builders in the garden-o-matic view
1317         https://bugs.webkit.org/show_bug.cgi?id=96418
1318
1319         Reviewed by James Robinson.
1320
1321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1322
1323 2012-09-11  Adam Klein  <adamk@chromium.org>
1324
1325         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1326         https://bugs.webkit.org/show_bug.cgi?id=96411
1327
1328         Reviewed by Adam Barth.
1329
1330         Previously only the exact string "warning" was treated as a warning
1331         result. This patch treats any string with "warning" as a substring
1332         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1333
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1335         (.):
1336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1337
1338 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1339
1340         Restore original value of mock scrollbars enabled in InternalSettings
1341         https://bugs.webkit.org/show_bug.cgi?id=87680
1342
1343         Reviewed by Adam Barth.
1344
1345         Added backup support for mock scrollbars state in
1346         InternalSettings::Backup, and removed support for these
1347         from Qt's DumpRenderTree.
1348
1349         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1350         (WebCore::WebPage::resetSettings):
1351         * DumpRenderTree/qt/TestRunnerQt.cpp:
1352         (TestRunner::setFrameFlatteningEnabled):
1353         * DumpRenderTree/qt/TestRunnerQt.h:
1354         (TestRunner):
1355
1356 2012-09-11  Dan Bernstein  <mitz@apple.com>
1357
1358         Fixed a bug where kill-old-processes failed to kill clang++.
1359
1360         Rubber-stamped by Alexey Proskuryakov.
1361
1362         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1363         where it is passed as a regular expression to killall.
1364
1365 2012-09-11  Philippe Liard  <pliard@google.com>
1366
1367         Make sure that md5sum is not setup on non-Chromium Android platforms.
1368         https://bugs.webkit.org/show_bug.cgi?id=96393
1369
1370         Reviewed by Adam Barth.
1371
1372         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1373         which is also invoked on non-Chromium Android platforms. The following patch
1374         moves this logic to _startup_test() which is guaranteed to be invoked
1375         only on Android.
1376
1377         This also updates the prompt unit test in chromium_android_unittest.py.
1378
1379         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1380         (ChromiumAndroidDriver.__init__):
1381         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1382         (ChromiumAndroidDriver._setup_test):
1383
1384 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1385
1386         [EFL] Rewrite the EFL-related Find modules
1387         https://bugs.webkit.org/show_bug.cgi?id=95237
1388
1389         Reviewed by Kenneth Rohde Christiansen.
1390
1391         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1392         property and include all the Enlightenment Foundation Libraries
1393         required by the target.
1394         * EWebLauncher/CMakeLists.txt: Ditto.
1395         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1396         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1397         now that they are not added implicitly.
1398         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1399         property.
1400         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1401         property and include all the Enlightenment Foundation Libraries
1402         required by the target.
1403
1404 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1405
1406         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1407         https://bugs.webkit.org/show_bug.cgi?id=96379
1408
1409         Reviewed by Kenneth Rohde Christiansen.
1410
1411         Add implementation for setApplicationCacheOriginQuota
1412         to WebKitTestRunner.
1413
1414         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1415         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1416         (WTR::TestRunner::setApplicationCacheOriginQuota):
1417         (WTR):
1418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1419         (TestRunner):
1420
1421 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1422
1423         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1424         https://bugs.webkit.org/show_bug.cgi?id=91988
1425
1426         Reviewed by Kenneth Rohde Christiansen.
1427
1428         Regular key events generated by Qt for the tab key fill both
1429         keyCode and keyText, so we should do the same for our fake events.
1430
1431         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1432         (WTR::EventSenderProxy::keyDown):
1433
1434 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1435
1436         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1437         https://bugs.webkit.org/show_bug.cgi?id=96269
1438
1439         Reviewed by Kenneth Rohde Christiansen.
1440
1441         Exported missing testRunner.setSpatialNavigationEnabled() method.
1442
1443         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1444         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1445         (WTR::InjectedBundle::beginTesting):
1446         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1447         (WTR::TestRunner::setSpatialNavigationEnabled):
1448         (WTR):
1449         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1450         (TestRunner):
1451
1452 2012-09-11  Philippe Liard  <pliard@chromium.org>
1453
1454         Support LayoutTests on non-rooted devices for Chromium Android.
1455         https://bugs.webkit.org/show_bug.cgi?id=95346
1456
1457         Reviewed by Dirk Pranke.
1458
1459         We were requiring root permissions to sync resource files with the
1460         device by comparing host and device files' timestamp after we
1461         synchronized the device and host clocks.
1462         We now rely on md5sum provided by Chromium to handle data files
1463         synchronization.
1464
1465         * Scripts/webkitpy/layout_tests/port/chromium.py:
1466         (ChromiumPort._check_driver_build_up_to_date):
1467         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1468         (ChromiumAndroidDriver.__init__):
1469         (ChromiumAndroidDriver._setup_test):
1470         (ChromiumAndroidDriver._push_executable):
1471         (ChromiumAndroidDriver._push_test_resources):
1472         (ChromiumAndroidDriver._read_prompt):
1473
1474 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1475
1476         [Qt] Fix output paths on Windows
1477
1478         Reviewed by Tor Arne Vestbø.
1479
1480         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1481         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1482         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1483         incorrect here and instead for the calculation we should use forward slashes.
1484
1485         * qmake/mkspecs/features/default_pre.prf:
1486
1487 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1488
1489         [Qt] Fix passing of defines from the build system
1490
1491         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1492         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1493         will add it's own defaults if the features are not defined.
1494
1495         At some point we might want to run a configure-test to inspect what
1496         Platform.h will do, so we can sync up the build system's view of
1497         the feature-defines with the compile-time situation.
1498
1499         Reviewed by Simon Hausmann.
1500
1501         * qmake/mkspecs/features/functions.prf:
1502
1503 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1504
1505         [Qt] Fix --qt option to build-webkit
1506
1507         Reviewed by Ossy.
1508
1509         * Scripts/webkitdirs.pm:
1510         (buildQMakeProjects):
1511
1512 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1513
1514         [Qt] Add a configure step to the Qt build system
1515
1516         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1517         the build-webkit script is still supported, and will add slightly more
1518         logic to the build, such as detecting the need for clean or incremental
1519         builds.
1520
1521         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1522         all things related to configuring the build, such as use/have/enable flags,
1523         and these are translated to defines in default_post. Project files should
1524         no longer check contains(DEFINES,...) to detect features, but use the new
1525         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1526         options have been translated into WEBKIT_CONFIG options as well, and can
1527         be checked using build?().
1528
1529         Reviewed by Simon Hausmann.
1530
1531         * DumpRenderTree/qt/DumpRenderTree.pro:
1532         * MiniBrowser/qt/MiniBrowser.pro:
1533         * QtTestBrowser/QtTestBrowser.pro:
1534         * Scripts/build-webkit:
1535         * Scripts/webkitdirs.pm:
1536         (qtFeatureDefaults):
1537         (buildQMakeProjects):
1538         * Tools.pro:
1539         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1540         * WebKitTestRunner/InjectedBundle/Target.pri:
1541         * WebKitTestRunner/Target.pri:
1542         * qmake/.qmake.cache: Added.
1543         * qmake/configure.pri: Removed.
1544         * qmake/configure.pro: Removed.
1545         * qmake/dump-features: Added.
1546         * qmake/mkspecs/features/configure.prf: Added.
1547         * qmake/mkspecs/features/default_post.prf:
1548         * qmake/mkspecs/features/default_pre.prf:
1549         * qmake/mkspecs/features/features.prf:
1550         * qmake/mkspecs/features/features.pri:
1551         * qmake/mkspecs/features/functions.prf:
1552         * qmake/mkspecs/features/gprof.prf:
1553         * qmake/mkspecs/features/mac/default_pre.prf:
1554         * qmake/mkspecs/features/win32/default_pre.prf:
1555
1556 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1557
1558         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1559         https://bugs.webkit.org/show_bug.cgi?id=96372
1560
1561         Reviewed by Kenneth Rohde Christiansen.
1562
1563         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1564
1565         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1567         (WTR::TestRunner::clearApplicationCacheForOrigin):
1568         (WTR):
1569         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1570         (TestRunner):
1571
1572 2012-09-11  Peter Beverloo  <peter@chromium.org>
1573
1574         Don't ignore .pak files when making an archive for Android
1575         https://bugs.webkit.org/show_bug.cgi?id=96375
1576
1577         Reviewed by Jochen Eisinger.
1578
1579         The .pak files do need to be pushed to the device, which is currently
1580         preventing the layout test runner from correctly pushing all files.
1581
1582         * BuildSlaveSupport/built-product-archive:
1583         (archiveBuiltProduct):
1584
1585 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1586
1587         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1588         https://bugs.webkit.org/show_bug.cgi?id=96256
1589
1590         Reviewed by Kenneth Rohde Christiansen.
1591
1592         Exported TestRunner::setMinimumTimerInterval() method.
1593
1594         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1595         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1596         (WTR::InjectedBundle::beginTesting):
1597         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1598         (WTR::TestRunner::setMinimumTimerInterval):
1599         (WTR):
1600         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1601         (TestRunner):
1602
1603 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1604
1605         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1606         https://bugs.webkit.org/show_bug.cgi?id=96097
1607
1608         Reviewed by Adam Barth.
1609
1610         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1611         (MockWebRTCPeerConnectionHandler::addStream):
1612         (MockWebRTCPeerConnectionHandler::removeStream):
1613
1614 2012-09-11  Peter Beverloo  <peter@chromium.org>
1615
1616         Recognize the "--chromium-android" argument in run-webkit-tests
1617         https://bugs.webkit.org/show_bug.cgi?id=96369
1618
1619         Reviewed by Jochen Eisinger.
1620
1621         Chromium for the Android platform cannot determine the platform based on
1622         the host itself, so we'll use the --chromium-android argument as the build
1623         master passes to run-webkit-tests. Make sure the layout test runner
1624         can pick the right port when doing so.
1625
1626         * Scripts/run-webkit-tests:
1627         * Scripts/webkitpy/layout_tests/port/factory.py:
1628         (port_options):
1629
1630 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1631
1632         [QT] Fix build with newer qmake from Qt 5
1633
1634         Rubber-stamped by Tor Arne Vestbø.
1635
1636         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1637         it with the use of QT_HOST_DATA/mkspecs.
1638         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1639
1640         * Scripts/webkitdirs.pm:
1641         (builtDylibPathForName):
1642         (qtMakeCommand):
1643
1644 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1645
1646         [Qt] Remove Qt 4 syncqt, no longer needed
1647
1648         Reviewed by Simon Hausmann.
1649
1650         * qmake/syncqt-4.8: Removed.
1651
1652 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1653
1654         [Qt][WK2] Fix the build with recent Qt5
1655         https://bugs.webkit.org/show_bug.cgi?id=96283
1656
1657         Reviewed by Simon Hausmann.
1658
1659         We should not use deprecated Qt API because doing that results
1660         in build failure since all the deprecated API was disabled
1661         in qtbase (https://codereview.qt-project.org/#change,24890).
1662
1663         * DumpRenderTree/qt/main.cpp:
1664         (main):
1665         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1666         (MiniBrowserApplication::notify):
1667         * MiniBrowser/qt/raw/View.cpp:
1668         (View::exposeEvent):
1669         (main):
1670
1671 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1672
1673         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1674         https://bugs.webkit.org/show_bug.cgi?id=87188
1675
1676         Reviewed by Kenneth Rohde Christiansen.
1677
1678         Add implementation for applicationCacheDiskUsageForOrigin()
1679         in WebKitTestRunner.
1680
1681         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1682         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1683         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1684         (WTR):
1685         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1686         (TestRunner):
1687
1688 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1689
1690         Properly expose <legend> elements to ATs
1691         https://bugs.webkit.org/show_bug.cgi?id=84137
1692
1693         Reviewed by Chris Fleizach.
1694
1695         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1696         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1697         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1698
1699         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1700         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1701
1702 2012-09-10  Jer Noble  <jer.noble@apple.com>
1703
1704         Unreviewed; rolling out r128081.
1705         http://trac.webkit.org/changeset/128081
1706         https://bugs.webkit.org/show_bug.cgi?id=96134
1707
1708         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1709
1710         * DumpRenderTree/TestRunner.cpp:
1711         (TestRunner::TestRunner):
1712         (TestRunner::staticFunctions):
1713         * DumpRenderTree/TestRunner.h:
1714         (TestRunner):
1715         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1716         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1717         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1718         (WTR::InjectedBundlePage::InjectedBundlePage):
1719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1720         (InjectedBundlePage):
1721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1722         (WTR::TestRunner::TestRunner):
1723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1724         (TestRunner):
1725
1726 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1727
1728         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1729         https://bugs.webkit.org/show_bug.cgi?id=96205
1730
1731         Reviewed by Tony Chang.
1732
1733         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1734         internally, which means that it would support only 1 TestExpectations file per port. This
1735         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1736         and efl-wk1 -> efl).
1737
1738         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1739         instead so that all the ports TestExpectations are recognized. The ports are also
1740         constructed twice, with "webkit_test_runner" option set to True and False so that we
1741         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1742
1743         * Scripts/webkitpy/style/checkers/test_expectations.py:
1744         (TestExpectationsChecker._determine_port_from_expectations_path):
1745         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1746         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1747
1748 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1749
1750         [WTR] Generated source files should include config.h
1751         https://bugs.webkit.org/show_bug.cgi?id=96254
1752
1753         Reviewed by Benjamin Poulain.
1754
1755         Current coding style has encouraged to include config.h at the first position,
1756         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1757         this rule.
1758         Therefore, this patch added it.
1759
1760         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1761         (_generateImplementationFile):
1762
1763 2012-09-10  Rick Byers  <rbyers@chromium.org>
1764
1765         Add handling of new GestureTapCancel in DRT
1766         
1767         https://bugs.webkit.org/show_bug.cgi?id=96183
1768
1769         Reviewed by Adam Barth.
1770
1771         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1772         (TestWebPlugin::handleInputEvent):
1773
1774 2012-09-10  Brady Eidson  <beidson@apple.com>
1775
1776         Javascript in foreground tabs should not wait synchronously for plug-ins to load
1777         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
1778
1779         Reviewed by Geoff Garen.
1780
1781         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
1782
1783         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
1784         (PluginObject):
1785         (SlowNPPNew::PluginObject::PluginObject):
1786         (SlowNPPNew::PluginObject::~PluginObject):
1787         (SlowNPPNew::PluginObject::hasProperty):
1788         (SlowNPPNew::PluginObject::getProperty):
1789         (SlowNPPNew::NPP_GetValue):
1790         (SlowNPPNew):
1791
1792 2012-09-10  Tim Horton  <timothy_horton@apple.com>
1793
1794         WKTR often reports an unresponsive WebProcess on Mac bots
1795         https://bugs.webkit.org/show_bug.cgi?id=95906
1796
1797         Reviewed by Dan Bernstein.
1798
1799         Attempt to work around resource contention issues by increasing the NRWT
1800         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
1801
1802         * Scripts/webkitpy/layout_tests/port/base.py:
1803         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
1804         * WebKitTestRunner/TestController.cpp:
1805         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
1806
1807 2012-09-07  Jer Noble  <jer.noble@apple.com>
1808
1809         <audio> and <video> should send Do Not Track when appropriate
1810         https://bugs.webkit.org/show_bug.cgi?id=96134
1811
1812         Reviewed by Eric Carlson.
1813
1814         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
1815         WTR. Add FrameLoaderClient client methods for retrieving that value.
1816
1817         * DumpRenderTree/TestRunner.cpp:
1818         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
1819         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
1820         * DumpRenderTree/TestRunner.h:
1821         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
1822         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1823         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1824         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
1825             Pass the question on to the TestRunner.
1826         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1827         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1828         (WTR::InjectedBundlePage::InjectedBundlePage):
1829             Add the setShouldSendDoNotTrackHTTPHeader client function.
1830         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
1831             Pass the question on to the TestRunner.
1832         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1833         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1834         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1835         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1836         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
1837
1838 2012-09-10  Ojan Vafai  <ojan@chromium.org>
1839
1840         Make EFL bots work on the flakiness dashboard
1841         https://bugs.webkit.org/show_bug.cgi?id=96164
1842
1843         Reviewed by Tony Chang.
1844
1845         Also, update outdated unittests that had started failing.
1846
1847         * TestResultServer/static-dashboards/builders.js:
1848         (isWebkitTestRunner):
1849         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1850         (nonChromiumPlatform):
1851         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1852         (test):
1853
1854 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
1855
1856         [chromium] MediaStream API: Remove the Descriptor postfix
1857         https://bugs.webkit.org/show_bug.cgi?id=96268
1858
1859         Reviewed by Adam Barth.
1860
1861         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
1862         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
1863
1864         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1865         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1866         (MockWebRTCPeerConnectionHandler::createOffer):
1867         (MockWebRTCPeerConnectionHandler::createAnswer):
1868         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1869         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1870         (MockWebRTCPeerConnectionHandler::localDescription):
1871         (MockWebRTCPeerConnectionHandler::remoteDescription):
1872         (MockWebRTCPeerConnectionHandler::addICECandidate):
1873         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1874         (MockWebRTCPeerConnectionHandler):
1875
1876 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1877
1878         [Gtk] failure to build jhbuild dependencies with cups 1.6
1879         https://bugs.webkit.org/show_bug.cgi?id=95991
1880
1881         Reviewed by Gustavo Noronha Silva.
1882
1883         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
1884         building with cups >= 1.6 [GNOME #670373].
1885
1886         * gtk/jhbuild.modules:
1887
1888 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1889
1890         [EFL][DRT] Encoding issue in printed console messages
1891         https://bugs.webkit.org/show_bug.cgi?id=96263
1892
1893         Reviewed by Kenneth Rohde Christiansen.
1894
1895         Correctly handle CONSOLE messages that contain non-ascii
1896         characters in EFL's DRT. We need to use String::fromUTF8()
1897         to construct a WTF::String from a raw string.
1898
1899         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1900         (onConsoleMessage):
1901
1902 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1903
1904         [WK2][WTR] User style sheet location should be reset before each test
1905         https://bugs.webkit.org/show_bug.cgi?id=96262
1906
1907         Reviewed by Kenneth Rohde Christiansen.
1908
1909         User style sheet location is reset before each test now.
1910
1911         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1912         (WTR::InjectedBundle::beginTesting):
1913
1914 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
1915
1916         Fix build of WTR with Qt on Windows
1917         https://bugs.webkit.org/show_bug.cgi?id=96249
1918
1919         Reviewed by Kenneth Rohde Christiansen.
1920
1921         Windows loves to define min and max as macros, which beautifully
1922         clashes in many places where min and max are used as variable or method
1923         names. It can be convinced not to do this when min and max are already
1924         define as macros (expanding to themselves). We have this kind of
1925         workaround in config.h files all over WebKit and as it turns out when
1926         building WTR with Qt on Windows we do end up with such a clash. Therefore
1927         we need the same workaround.
1928
1929         * WebKitTestRunner/config.h:
1930
1931 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1932
1933         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
1934         https://bugs.webkit.org/show_bug.cgi?id=95936
1935
1936         Reviewed by Kenneth Rohde Christiansen.
1937
1938         Enable interactive form validation setting in WebKitTestRunner as
1939         we are currently doing in DumpRenderTree. This is needed for some
1940         tests to pass.
1941
1942         * WebKitTestRunner/TestController.cpp:
1943         (WTR::TestController::resetStateToConsistentValues):
1944
1945 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
1946
1947         Clean up the code in XvfbDriver
1948         https://bugs.webkit.org/show_bug.cgi?id=96202
1949
1950         Reviewed by Philippe Normand.
1951
1952         Changes:
1953         - Remove unneeded imports,
1954         - assign the _lock_file member variable when the display number is determined,
1955         - no need for parentheses around a single string format argument,
1956         - use FileSystem.exists method when checking if lock file is present as it
1957         makes the intention much more clearer.
1958
1959         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1960         (XvfbDriver._start):
1961         (XvfbDriver.stop):
1962
1963 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
1964
1965         Make the String initialization on the function side of String::number()
1966         https://bugs.webkit.org/show_bug.cgi?id=95940
1967
1968         Reviewed by Benjamin Poulain.
1969
1970         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1971         (testBoundaries):
1972         (testNumbers):
1973
1974 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
1975
1976         [WK2] expose element rect for color input type
1977         https://bugs.webkit.org/show_bug.cgi?id=91664
1978
1979         Reviewed by Simon Hausmann.
1980
1981         Update the QML logic in MiniBrowser to take advantage of this.
1982         The picker size is now hardcoded and we try to place it below the
1983         input element if possible.
1984
1985         * MiniBrowser/qt/qml/ColorChooser.qml:
1986
1987 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
1988
1989         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
1990         https://bugs.webkit.org/show_bug.cgi?id=95329
1991
1992         Reviewed by Kenneth Rohde Christiansen.
1993
1994         Explicitely disable TabToLinks setting in WebKitTestRunner.
1995         Tests override the "WebKitTabToLinksPreferenceKey" preference
1996         to enable it.
1997
1998         * WebKitTestRunner/TestController.cpp:
1999         (WTR::TestController::resetStateToConsistentValues):
2000
2001 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2002
2003         webkit.py gdb pretty printer can't print CString
2004         https://bugs.webkit.org/show_bug.cgi?id=96068
2005
2006         Reviewed by Tony Chang.
2007
2008         Update WTFCStringPrinter to follow r126191.
2009
2010         * gdb/webkit.py:
2011         (WTFCStringPrinter.to_string):
2012
2013 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2014
2015         Rename the ustring() accessor to string()
2016         https://bugs.webkit.org/show_bug.cgi?id=95919
2017
2018         Reviewed by Geoffrey Garen.
2019
2020         Update EFL's DRT.
2021
2022         Fix some string conversion that have been made useless
2023         with recent changes.
2024
2025         * DumpRenderTree/efl/EventSender.cpp:
2026         (keyPadNameFromJSValue):
2027         (keyNameFromJSValue):
2028         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2029         (TestRunner::queueLoad):
2030         (TestRunner::addOriginAccessWhitelistEntry):
2031         (TestRunner::removeOriginAccessWhitelistEntry):
2032         (TestRunner::setUserStyleSheetLocation):
2033         (TestRunner::setValueForUser):
2034         (TestRunner::elementDoesAutoCompleteForElementWithId):
2035         (TestRunner::execCommand):
2036         (TestRunner::findString):
2037         (TestRunner::isCommandEnabled):
2038         (TestRunner::clearApplicationCacheForOrigin):
2039         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2040         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2041         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2042         (toInt):
2043         (TestRunner::overridePreference):
2044         (TestRunner::addUserScript):
2045         (TestRunner::addUserStyleSheet):
2046         (TestRunner::evaluateInWebInspector):
2047         (TestRunner::evaluateScriptInIsolatedWorld):
2048         (TestRunner::setTextDirection):
2049         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2050         (LoadItem::invoke):
2051         (LoadHTMLStringItem::invoke):
2052         (ScriptItem::invoke):
2053
2054 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2055
2056         Extend third-party storage blocking API to optionally allow blocking all storage
2057         https://bugs.webkit.org/show_bug.cgi?id=95915
2058
2059         Reviewed by Brady Eidson.
2060
2061         Modified API test to use new revised API.
2062
2063         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2064         (TestWebKitAPI::TEST):
2065
2066 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2067
2068         AX: WebCore accessibility roles should be cross-platform
2069         https://bugs.webkit.org/show_bug.cgi?id=94870
2070
2071         Reviewed by Chris Fleizach.
2072
2073         Add debug strings to Chromium for new accessibility roles.
2074
2075         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2076         (roleToString):
2077
2078 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2079
2080         AX: Chromium needs access to canvasHasFallbackContent
2081         https://bugs.webkit.org/show_bug.cgi?id=96124
2082
2083         Reviewed by Chris Fleizach.
2084
2085         Distinguish between canvas roles with and without fallback
2086         content on Chromium.
2087
2088         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2089         (getRole):
2090
2091 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2092
2093         Handle non-existant TestExpectations files gracefully
2094         https://bugs.webkit.org/show_bug.cgi?id=96149
2095
2096         Reviewed by Eric Seidel.
2097
2098         Even when we get rid of Skipped files, we shouldn't have each port
2099         require a TestExpectations file for each platform if it doesn't
2100         need one.
2101
2102         * Scripts/webkitpy/layout_tests/port/base.py:
2103         (Port.expectations_dict):
2104         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2105         (PortTest.test_nonexistant_expectations):
2106
2107 2012-09-07  Tony Chang  <tony@chromium.org>
2108
2109         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2110         https://bugs.webkit.org/show_bug.cgi?id=96136
2111
2112         Reviewed by Ojan Vafai.
2113
2114         When we renamed the file to TestExpectations, it was no longer considered a text file so
2115         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2116         from the port object, so I've removed that from the check. I'm not sure what it was
2117         supposed to do.
2118
2119         * Scripts/webkitpy/style/checker.py:
2120         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2121         * Scripts/webkitpy/style/checkers/test_expectations.py:
2122         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2123         (TestExpectationsChecker.check): Remove overrides param.
2124         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2125         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2126
2127 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2128
2129         [EFL] Use same default minimum logical font size in DRT and WTR
2130         https://bugs.webkit.org/show_bug.cgi?id=96116
2131
2132         Reviewed by Martin Robinson.
2133
2134         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2135         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2136         logical font size to 9 to match the value used in WTR.
2137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2138         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2139         logical font size to 9 (default value in WK2)
2140
2141 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2142
2143         MediaStream API: add RTCPeerConnection::createAnswer
2144         https://bugs.webkit.org/show_bug.cgi?id=96092
2145
2146         Reviewed by Adam Barth.
2147
2148         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2149
2150         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2151         (MockWebRTCPeerConnectionHandler::createOffer):
2152         (MockWebRTCPeerConnectionHandler::createAnswer):
2153         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2154         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2155         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2156         (MockWebRTCPeerConnectionHandler):
2157
2158 2012-09-07  Dean Jackson  <dino@apple.com>
2159
2160         Unreviewed changes to watchlist.
2161
2162         - Add new WebGL and Filters definitions
2163         - Add myself to OpenGL bugs
2164
2165         * Scripts/webkitpy/common/config/watchlist:
2166
2167 2012-09-07  Peter Beverloo  <peter@chromium.org>
2168
2169         Actually trigger the Android Tester
2170         https://bugs.webkit.org/show_bug.cgi?id=96118
2171
2172         Reviewed by Adam Barth.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/config.json:
2175
2176 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2177
2178         New time input needs accessibility
2179         https://bugs.webkit.org/show_bug.cgi?id=96032
2180
2181         Reviewed by Chris Fleizach.
2182
2183         Add support for valueDescription for testing.
2184
2185         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2186         (getValueDescription):
2187         (AccessibilityUIElement::AccessibilityUIElement):
2188         (AccessibilityUIElement::valueDescriptionGetterCallback):
2189         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2190         (AccessibilityUIElement):
2191
2192 2012-09-07  Peter Beverloo  <peter@chromium.org>
2193
2194         Add the google-android-tests build slave to the master's config
2195         https://bugs.webkit.org/show_bug.cgi?id=96113
2196
2197         Reviewed by Csaba Osztrogonác.
2198
2199         * BuildSlaveSupport/build.webkit.org-config/config.json:
2200
2201 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2202
2203         [WK2] [EFL] Set theme for WebKit2 API test runner
2204         https://bugs.webkit.org/show_bug.cgi?id=96100
2205
2206         Reviewed by Kenneth Rohde Christiansen.
2207
2208         Set the theme generated by the build for the WebKit2 API test runner.
2209
2210         * TestWebKitAPI/PlatformEfl.cmake:
2211         * TestWebKitAPI/efl/PlatformWebView.cpp:
2212         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2213
2214 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2215
2216         Unreviewed. Add Gábor Ballabás as contributor.
2217
2218         * Scripts/webkitpy/common/config/committers.py:
2219
2220 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2221
2222         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2223         https://bugs.webkit.org/show_bug.cgi?id=96078
2224
2225         Reviewed by Tor Arne Vestbø.
2226
2227         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2228
2229         * qmake/mkspecs/features/default_pre.prf:
2230
2231 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2232
2233         [EFL] Add TestExpectations file for efl-wk1
2234         https://bugs.webkit.org/show_bug.cgi?id=96019
2235
2236         Reviewed by Gyuyoung Kim.
2237
2238         Update TestExpectations cascading for EFL port
2239         so that we use efl-wk1 -> efl search paths
2240         for WebKit1 EFL.
2241
2242         * Scripts/webkitpy/layout_tests/port/efl.py:
2243         (EflPort._search_paths):
2244
2245 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2246
2247         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2248         https://bugs.webkit.org/show_bug.cgi?id=95097
2249
2250         Reviewed by Dirk Pranke.
2251
2252         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2253         terminating the process does not always work as expected, leading to timeouts
2254         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2255         as it's not removed by the killed Xvfb process.
2256
2257         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2258         is tested in different circumstances - whether pixel tests are enabled or not,
2259         with an arbitrary worker number or with an Xorg process already running on the system.
2260         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2261         and then set to None.
2262
2263         * BuildSlaveSupport/kill-old-processes:
2264         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2265         is left running, potentially clogging up a display at a certain position.
2266         * Scripts/webkitpy/common/system/executive_mock.py:
2267         (MockExecutive.__init__):
2268         The _running_pids is now a dictionary with process names as keys and pids
2269         as values.
2270         (MockExecutive.check_running_pid):
2271         Check whether the passed-in pid is in the _running_pids dictionary's values.
2272         (MockExecutive):
2273         (MockExecutive.running_pids):
2274         This method returns the list of all the process pids of which the name passes
2275         through the process_name_filter.
2276         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2277         Use the Executive object of the port's host to check for running pids and open
2278         new subprocesses or kill them throughout the class.
2279         (XvfbDriver._start):
2280         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2281         start the server process after it's created.
2282         (XvfbDriver.stop):
2283         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2284         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2285         (XvfbDriverTest):
2286         (XvfbDriverTest.make_driver):
2287         (XvfbDriverTest.assertDriverStartSuccessful):
2288         (XvfbDriverTest.test_start_no_pixel_tests):
2289         (XvfbDriverTest.test_start_pixel_tests):
2290         (XvfbDriverTest.test_start_arbitrary_worker_number):
2291         (XvfbDriverTest.test_start_existing_xorg_process):
2292         (XvfbDriverTest.test_stop):
2293         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2294
2295 2012-09-06  Peter Beverloo  <peter@chromium.org>
2296
2297         Introduce the Chromium Android Release (Tests) bot
2298         https://bugs.webkit.org/show_bug.cgi?id=95980
2299
2300         Reviewed by Adam Barth.
2301
2302         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2303         which will be running layout tests on actual Android devices. Right now,
2304         four Galaxy Nexus phones are attached.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/config.json:
2307
2308 2012-09-06  James Robinson  <jamesr@chromium.org>
2309
2310         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2311         https://bugs.webkit.org/show_bug.cgi?id=96007
2312
2313         Reviewed by Adrienne Walker.
2314
2315         Fixes initialization / settings code to use WebCompositorSupport.
2316
2317         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2318         (main):
2319         * DumpRenderTree/chromium/TestShell.cpp:
2320         (TestShell::initialize):
2321         (TestShell::setPerTilePaintingEnabled):
2322
2323 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2324
2325         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2326         https://bugs.webkit.org/show_bug.cgi?id=95995
2327
2328         Reviewed by Kenneth Rohde Christiansen.
2329
2330         Provide proper implementation for PlatformWebView::windowFrame()
2331         in EFL's WebKitTestRunner.
2332
2333         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2334         (WTR::PlatformWebView::windowFrame):
2335
2336 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2337
2338         Fix WTF.Lrint on 32-bit platforms
2339         https://bugs.webkit.org/show_bug.cgi?id=96003
2340
2341         Reviewed by Benjamin Poulain.
2342
2343         Fixed failing WTF.Lrint test on 32-bit platforms.
2344
2345         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2346         (TestWebKitAPI::TEST):
2347
2348 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2349
2350         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2351         https://bugs.webkit.org/show_bug.cgi?id=95839
2352
2353         Reviewed by Adam Barth.
2354
2355         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2356         up the task definitions a bit. There was no need to have them in the header file.
2357
2358         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2359         (RTCSessionDescriptionRequestSuccededTask):
2360         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2361         (RTCSessionDescriptionRequestFailedTask):
2362         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2363         (RTCVoidRequestTask):
2364         (RTCVoidRequestTask::RTCVoidRequestTask):
2365         (MockWebRTCPeerConnectionHandler::createOffer):
2366         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2367         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2368         (MockWebRTCPeerConnectionHandler::localDescription):
2369         (MockWebRTCPeerConnectionHandler::remoteDescription):
2370         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2371         (MockWebRTCPeerConnectionHandler):
2372
2373 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2374
2375         [Qt] Fix build on Mac OS X 10.6
2376         https://bugs.webkit.org/show_bug.cgi?id=95200
2377
2378         Reviewed by Tor Arne Vestbø.
2379
2380         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2381         10.7 and newer.
2382
2383         * qmake/mkspecs/features/features.prf:
2384
2385 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2386
2387         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2388         https://bugs.webkit.org/show_bug.cgi?id=95973
2389
2390         Reviewed by Kenneth Rohde Christiansen.
2391
2392         Correctly map "addSelectionKey" to "Control" modifier
2393         in WKTR's EventSender on other OSes than Mac OS X,
2394         instead of mapping it to the "Meta" modifier.
2395
2396         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2397         (WTR::parseModifier):
2398
2399 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2400
2401         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2402         https://bugs.webkit.org/show_bug.cgi?id=95710
2403
2404         Reviewed by Dirk Pranke.
2405
2406         The stdout / stderr output can be None so make sure
2407         we won't raise an exception in this case.
2408
2409         * Scripts/webkitpy/layout_tests/port/driver.py:
2410         (Driver.run_test):
2411
2412 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2413
2414         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2415         https://bugs.webkit.org/show_bug.cgi?id=95849
2416
2417         Reviewed by Kenneth Rohde Christiansen.
2418
2419         Sanitize URLs passed by the user as program
2420         argument or typed in the URL bar in order to
2421         be more tolerant.
2422
2423         * EWebLauncher/CMakeLists.txt:
2424         * EWebLauncher/main.c:
2425         (main):
2426         * EWebLauncher/url_bar.c:
2427         (_url_bar_url_get_with_protocol):
2428         (on_urlbar_key_down):
2429         * EWebLauncher/url_utils.c: Added.
2430         (has_scheme):
2431         (url_from_user_input): Add utility function to construct a
2432         URL from user input.
2433         * EWebLauncher/url_utils.h: Added.
2434         * MiniBrowser/efl/CMakeLists.txt:
2435         * MiniBrowser/efl/main.c:
2436         (main):
2437
2438 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2439
2440         [Qt] Various small Windows / MSVC build fixes
2441         https://bugs.webkit.org/show_bug.cgi?id=95934
2442
2443         Reviewed by Kenneth Rohde Christiansen.
2444
2445         setFocus takes a boolean as argument: Don't try to implicitly convert
2446         an enum to a boolean, MSVC doesn't like that. The intent here is to
2447         enable focus, so just pass true.
2448
2449         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2450         (WTR::PlatformWebView::focus):
2451
2452 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2453
2454         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2455         https://bugs.webkit.org/show_bug.cgi?id=95965
2456
2457         Reviewed by Tor Arne Vestbø.
2458
2459         Add ANGLE as a static library module to the Qt WebKit build system.
2460
2461         * qmake/mkspecs/features/default_post.prf:
2462         * qmake/mkspecs/modules/angle.prf: Added.
2463
2464 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2465
2466         [WK2] Make [Qt]ViewportHandler cross platform
2467         https://bugs.webkit.org/show_bug.cgi?id=91257
2468
2469         Reviewed by Kenneth Rohde Christiansen.
2470
2471         Remove initial scale from viewport info item since it is
2472         set to -1 after applied thus it does not hold any valuable
2473         information.
2474
2475         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2476
2477 2012-09-05  Tony Chang  <tony@chromium.org>
2478
2479         [chromium] Remove dependency on webkit_user_agent
2480         https://bugs.webkit.org/show_bug.cgi?id=95886
2481
2482         Reviewed by Adam Barth.
2483
2484         The code isn't used by DumpRenderTree.
2485
2486         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2487
2488 2012-09-05  Rick Byers  <rbyers@chromium.org>
2489
2490         Update chromium DumpRenderTree for new WebGestureEvent fields
2491         https://bugs.webkit.org/show_bug.cgi?id=95573
2492
2493         Reviewed by James Robinson.
2494
2495         Update EventSender to write gesture details into the appropriate
2496         type-specific WebGestureEvent fields.
2497         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2498         (EventSender::gestureEvent):
2499         (EventSender::gestureFlingStart):
2500
2501 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2502
2503         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2504         https://bugs.webkit.org/show_bug.cgi?id=95789
2505
2506         Reviewed by Ojan Vafai.
2507
2508         Fix miscalculation in log message.
2509
2510         * Scripts/webkitpy/layout_tests/views/printing.py:
2511         (Printer.print_found):
2512
2513 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2514
2515         Unreviewed, rolling out r127612, r127660, and r127664.
2516         http://trac.webkit.org/changeset/127612
2517         http://trac.webkit.org/changeset/127660
2518         http://trac.webkit.org/changeset/127664
2519         https://bugs.webkit.org/show_bug.cgi?id=95920
2520
2521         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2522         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2523         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2524         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2525         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2526         (MockWebRTCPeerConnectionHandler::createOffer):
2527         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2528         (MockWebRTCPeerConnectionHandler):
2529         (SuccessCallbackTask):
2530         (FailureCallbackTask):
2531
2532 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2533
2534         Ignore-metrics includes scroll offsets.
2535         https://bugs.webkit.org/show_bug.cgi?id=95845
2536
2537         Reviewed by Dirk Pranke.
2538
2539         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2540
2541         * Scripts/old-run-webkit-tests:
2542         (stripMetrics):
2543         * Scripts/webkitpy/layout_tests/port/driver.py:
2544         (DriverOutput):
2545
2546 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2547
2548         Unreviewed test fix.
2549
2550         Including a plugin source file into the build that was added in r127595.
2551
2552         * GNUmakefile.am:
2553
2554 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2555
2556         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2557         https://bugs.webkit.org/show_bug.cgi?id=95839
2558
2559         Reviewed by Adam Barth.
2560
2561         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2562         up the task definitions a bit. There was no need to have them in the header file.
2563
2564         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2565         (RTCSessionDescriptionRequestSuccededTask):
2566         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2567         (RTCSessionDescriptionRequestFailedTask):
2568         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2569         (RTCVoidRequestTask):
2570         (RTCVoidRequestTask::RTCVoidRequestTask):
2571         (MockWebRTCPeerConnectionHandler::createOffer):
2572         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2573         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2574         (MockWebRTCPeerConnectionHandler::localDescription):
2575         (MockWebRTCPeerConnectionHandler::remoteDescription):
2576         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2577         (MockWebRTCPeerConnectionHandler):
2578
2579 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2580
2581         [EFL] Remove '+=' usage in String
2582         https://bugs.webkit.org/show_bug.cgi?id=95808
2583
2584         Reviewed by Benjamin Poulain.
2585
2586         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2587
2588         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2589         (descriptionSuitableForTestResult):
2590
2591 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2592
2593         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2594         https://bugs.webkit.org/show_bug.cgi?id=95842
2595
2596         Reviewed by Kenneth Rohde Christiansen.
2597
2598         Provide proper implementation for TestRunner::pathToLocalResource()
2599         in EFL WKTR, identical to the one for DumpRenderTree.
2600
2601         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2602         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2603         are found my WebKitTestRunner.
2604
2605         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2606         (WTR::TestRunner::pathToLocalResource):
2607
2608 2012-09-05  Brady Eidson  <beidson@apple.com>
2609
2610         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2611         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2612
2613         Reviewed by Andy Estes.
2614
2615         Add a plug-in that always fails to initialize:
2616         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2617         (NPPNewFails):
2618         (NPPNewFails::NPPNewFails):
2619         (NPPNewFails::NPP_New):
2620
2621         Add it to all the project files:
2622         * DumpRenderTree/DumpRenderTree.gypi:
2623         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2624         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2626         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2627
2628 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2629
2630         [Qt] Fix makefile race condition between derived sources and target
2631
2632         r121966 removed too much of the old qmake logic, including the rule
2633         that ensured that qmake_all would not trigger dual runs of qmake --
2634         one of the derived sources -qmake-all rule, and one for making the
2635         derived sources.
2636
2637         We now follow a similar pattern as before, by introducing a custom
2638         target that explicitly depends on the derived sources' qmake-all before
2639         doing a manual run of make. That ensures a single qmake run for the derived
2640         sources.
2641
2642         https://bugs.webkit.org/show_bug.cgi?id=93847
2643
2644         Reviewed by Csaba Osztrogonác.
2645
2646         * qmake/mkspecs/features/functions.prf:
2647
2648 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2649
2650         WKTR doesn't implement dumpWillCacheResponse()
2651         https://bugs.webkit.org/show_bug.cgi?id=94607
2652
2653         Reviewed by Kenneth Rohde Christiansen.
2654
2655         Define shouldCacheResponse() callback in resource
2656         load client and provide implementation for
2657         dumpWillCacheResponse() in WebKitTestRunner.
2658
2659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2660         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2661         (WTR::InjectedBundlePage::InjectedBundlePage):
2662         (WTR::InjectedBundlePage::shouldCacheResponse):
2663         (WTR):
2664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2665         (InjectedBundlePage):
2666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2667         (WTR::TestRunner::TestRunner):
2668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2669         (WTR::TestRunner::dumpWillCacheResponse):
2670         (WTR::TestRunner::shouldDumpWillCacheResponse):
2671         (TestRunner):
2672
2673 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2674
2675         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2676         https://bugs.webkit.org/show_bug.cgi?id=92735
2677
2678         Reviewed by Hajime Morita.
2679
2680         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2681
2682         * DumpRenderTree/TestRunner.cpp:
2683         (TestRunner::staticFunctions):
2684         * DumpRenderTree/TestRunner.h:
2685         (TestRunner):
2686         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2687         (TestRunner::addUserStyleSheet):
2688         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2689         (DRTTestRunner::DRTTestRunner):
2690         (DRTTestRunner::hasCustomPageSizeStyle):
2691         * DumpRenderTree/chromium/DRTTestRunner.h:
2692         (DRTTestRunner):
2693         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2694         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2695         * DumpRenderTree/mac/TestRunnerMac.mm:
2696         * DumpRenderTree/qt/TestRunnerQt.cpp:
2697         (TestRunner::evaluateScriptInIsolatedWorld):
2698         * DumpRenderTree/qt/TestRunnerQt.h:
2699         (TestRunner):
2700         * DumpRenderTree/win/TestRunnerWin.cpp:
2701         * DumpRenderTree/wx/TestRunnerWx.cpp:
2702         (TestRunner::abortModal):
2703         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2704         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2705         (WTR):
2706         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2707         (TestRunner):
2708
2709 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2710
2711         [Qt] Automate the use of AllInOne files in the Qt build
2712         https://bugs.webkit.org/show_bug.cgi?id=95837
2713
2714         Reviewed by Tor Arne Vestbø.
2715
2716         New feature file that implements the all-in-one file automation by
2717         adding the requested all-in-one files to SOURCES and removing the files
2718         it includes from SOURCES.
2719
2720         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2721
2722 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2723
2724         Have NRWT log more output when crash logs are missing
2725         https://bugs.webkit.org/show_bug.cgi?id=95814
2726
2727         Reviewed by Dan Bernstein.
2728
2729         Log the stderr and stdout of the test, in order to provide slightly more
2730         context when the WebProcess times out while running tests.
2731
2732         * Scripts/webkitpy/layout_tests/port/driver.py:
2733         (Driver.run_test):
2734
2735 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2736
2737         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2738         https://bugs.webkit.org/show_bug.cgi?id=95770
2739
2740         Reviewed by Adam Barth.
2741
2742         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2743         (ChromiumAndroidDriver.__init__):
2744         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2745         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2746         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2747         (ChromiumAndroidDriver._push_executable):
2748         (ChromiumAndroidDriver._push_fonts):
2749         (ChromiumAndroidDriver._push_test_resources):
2750         (ChromiumAndroidDriver._run_adb_command):
2751         (ChromiumAndroidDriver._get_last_stacktrace):
2752         (ChromiumAndroidDriver._get_crash_log):
2753         (ChromiumAndroidDriver._start):
2754         (ChromiumAndroidDriver._start_once):
2755         (ChromiumAndroidDriver._start_once.deadlock_detector):
2756         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2757         (ChromiumAndroidDriverTest.test_get_crash_log):
2758
2759 2012-09-04  Satish Sampath  <satish@chromium.org>
2760
2761         Run git commands within the checkout directory
2762         https://bugs.webkit.org/show_bug.cgi?id=95742
2763
2764         Reviewed by Eric Seidel.
2765
2766         git commands run from scm/git.py are sometimes run with cwd set to the
2767         checkout_root and other times with whatever directory was the default cwd.
2768         Instead all these should run with the checkout root set as the cwd
2769         (except where we explicitly need a different path)
2770
2771         * Scripts/webkitpy/common/checkout/scm/git.py:
2772         (Git._run_git):
2773         (Git.find_checkout_root):
2774         (Git.discard_local_commits):
2775         (Git.local_commits):
2776         (Git.working_directory_is_clean):
2777         (Git.clean_working_directory):
2778         (Git.add_list):
2779         (Git.delete_list):
2780         (Git.exists):
2781         (Git._current_branch):
2782         (Git._changes_files_for_commit):
2783         (Git.revisions_changing_file):
2784         (Git.svn_revision):
2785         (Git._run_git_svn_find_rev):
2786         (Git.contents_at_revision):
2787         (Git.diff_for_file):
2788         (Git.show_head):
2789         (Git.committer_email_for_revision):
2790         (Git.apply_reverse_diff):
2791         (Git.revert_files):
2792         (Git.commit_with_message):
2793         (Git._commit_on_branch):
2794         (Git.svn_commit_log):
2795         (Git.last_svn_commit_log):
2796         (Git.svn_blame):
2797         (Git._branch_ref_exists):
2798         (Git.delete_branch):
2799         (Git.remote_merge_base):
2800         (Git.commit_locally_with_message):
2801         (Git.push_local_commits_to_server):
2802         (Git.commit_ids_from_commitish_arguments):
2803         (Git.commit_message_for_local_commit):
2804         (Git.files_changed_summary_for_commit):
2805
2806 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2807
2808         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
2809         https://bugs.webkit.org/show_bug.cgi?id=95734
2810
2811         Reviewed by Adam Barth.
2812
2813         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2814         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2815         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2816         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2817         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2818         (MockWebRTCPeerConnectionHandler::createOffer):
2819         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2820         (MockWebRTCPeerConnectionHandler):
2821         (MockWebRTCPeerConnectionHandler::taskList):
2822         (SuccessCallbackTask):
2823         (FailureCallbackTask):
2824
2825 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2826
2827         [Chromium-Android] Output time and thread info in crash log
2828         https://bugs.webkit.org/show_bug.cgi?id=95768
2829
2830         Reviewed by Adam Barth.
2831
2832         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2833         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
2834
2835 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2836
2837         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
2838         https://bugs.webkit.org/show_bug.cgi?id=95721
2839
2840         Reviewed by Adam Barth.
2841
2842         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2843         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
2844         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
2845         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2846         (MockWebMediaStreamCenter):
2847
2848 2012-09-04  Tony Chang  <tony@chromium.org>
2849
2850         Elide test names when running new-run-webkit-tests
2851         https://bugs.webkit.org/show_bug.cgi?id=95626
2852
2853         Reviewed by Dirk Pranke.
2854
2855         When the test name exceeds the number of terminal columns, it leaves
2856         text on the screen. Avoid this by eliding the test name when running
2857         tests. This is similar to what ninja does when compiling.
2858
2859         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2860         (MeteredStream):
2861         (MeteredStream.number_of_columns): Helper method to get number of
2862         terminal columns. Won't work on Win32 python, but meh.
2863         * Scripts/webkitpy/layout_tests/views/printing.py:
2864         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
2865         because stderr appears to be ascii only.
2866         (Printer.print_started_test): Route through _test_status_line.
2867         (Printer.print_finished_test): Route through _test_status_line.
2868         (Printer._print_test_trace): Route through _test_status_line.
2869         (Printer._print_baseline): Route through _test_status_line.
2870         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2871         (test_test_status_line): Test for _test_status_line.
2872
2873 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
2874
2875         [GTK] Print API missing documentation when generating gtkdoc
2876         https://bugs.webkit.org/show_bug.cgi?id=95703
2877
2878         Reviewed by Carlos Garcia Campos.
2879
2880         Print out API missing documentation when generating gtkdoc. This makes it
2881         easier to fix documentation errors.
2882
2883         * gtk/generate-gtkdoc:
2884         (print_missing_api): Added.
2885         (generate_doc): Inline the rebase step, since it now reports an error
2886         when you try to rebase without generating documentation first.
2887         * gtk/gtkdoc.py:
2888         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
2889         generating documentation first to enable a small cleanup at the caller.
2890         (GTKDoc.api_missing_documentation): Added.
2891
2892 2012-09-04  Vincent Scheib  <scheib@chromium.org>
2893
2894         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
2895         https://bugs.webkit.org/show_bug.cgi?id=95628
2896
2897         Reviewed by James Robinson.
2898
2899         Future tests need the ability to respond asynchronously that
2900         pointer lock requests have been accepted or rejected. This patch
2901         adds the following:
2902             testRunner.setPointerLockWillRespondAsynchronously();
2903             testRunner.didAcquirePointerLock();
2904             testRunner.didNotAcquirePointerLock();
2905
2906         Tested in existing test:
2907             pointerlockchange-pointerlockerror-events.html
2908
2909         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2910         (DRTTestRunner::DRTTestRunner):
2911         (DRTTestRunner::didAcquirePointerLock):
2912         (DRTTestRunner::didNotAcquirePointerLock):
2913         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
2914         * DumpRenderTree/chromium/DRTTestRunner.h:
2915         (DRTTestRunner):
2916         * DumpRenderTree/chromium/WebViewHost.cpp:
2917         (WebViewHost::requestPointerLock):
2918         (WebViewHost::didAcquirePointerLock):
2919         (WebViewHost::didNotAcquirePointerLock):
2920         * DumpRenderTree/chromium/WebViewHost.h:
2921         (WebViewHost):
2922         (WebViewHost::setPointerLockWillRespondAsynchronously):
2923
2924 2012-09-04  Ojan Vafai  <ojan@chromium.org>
2925
2926         Move content shell bots to their own builder group
2927         https://bugs.webkit.org/show_bug.cgi?id=95765
2928
2929         Reviewed by Adam Barth.
2930
2931         In their current state of instability, they add too much noise. Once they get more stable,
2932         we can add them back to the regular group or just have them replace the other bots.
2933
2934         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
2935
2936         * TestResultServer/static-dashboards/builders.js:
2937         (isWebkitTestRunner):
2938         (isChromiumContentShellTestRunner):
2939         (isChromiumWebkitTipOfTreeTestRunner):
2940         (loadBuildersList):
2941
2942 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
2943
2944         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
2945         https://bugs.webkit.org/show_bug.cgi?id=95689
2946
2947         Reviewed by Kenneth Rohde Christiansen.
2948
2949         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
2950         So, there are bugs that key events are always generated in url bar although
2951         the user clicked the web view.
2952
2953         This patch recovers the focus of the web view when left button is pressed and
2954         adds for MiniBrowser to toggle the focus when middle button is pressed
2955         like EWebLauncher already did.
2956
2957         * EWebLauncher/main.c:
2958         (on_mouse_down):
2959         * MiniBrowser/efl/main.c:
2960         (on_mouse_down):
2961         (browserCreate):
2962
2963 2012-09-03  Tao Bai  <michaelbai@chromium.org>
2964
2965         Added ANDROID_GDBSERVER definition for Ant
2966         https://bugs.webkit.org/show_bug.cgi?id=95265
2967
2968         Reviewed by Adam Barth.
2969
2970         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2971         is only used for finding the gdbserver.
2972
2973         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2974         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2975
2976 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
2977
2978         MediaStream API: Add Ice-related functionality to RTCPeerConnection
2979         https://bugs.webkit.org/show_bug.cgi?id=95565
2980
2981         Reviewed by Adam Barth.
2982
2983         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2984         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2985         (MockWebRTCPeerConnectionHandler::updateICE):
2986         (MockWebRTCPeerConnectionHandler::addICECandidate):
2987         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2988         (MockWebRTCPeerConnectionHandler):
2989
2990 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
2991
2992         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
2993         https://bugs.webkit.org/show_bug.cgi?id=95670
2994
2995         Reviewed by Kenneth Rohde Christiansen.
2996
2997         Fix layout issues related to the URL bar in Minibrowser
2998         and EWebLauncher when the window is resized.
2999
3000         The URL bar was not resized accordingly and the Web
3001         page was moved behing the URL bar, hiding part of it.
3002
3003         * EWebLauncher/main.c:
3004         (on_ecore_evas_resize):
3005         (closeWindow):
3006         * EWebLauncher/url_bar.c:
3007         (url_bar_width_set):
3008         (url_bar_add):
3009         * EWebLauncher/url_bar.h:
3010         * MiniBrowser/efl/main.c:
3011         (on_ecore_evas_resize):
3012         (main):
3013
3014 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3015
3016         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3017         https://bugs.webkit.org/show_bug.cgi?id=95605
3018
3019         Reviewed by Dirk Pranke.
3020
3021         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3022
3023         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3024         (ChromiumAndroidPort.check_sys_deps):
3025         (ChromiumAndroidPort.expectations_files):
3026         (ChromiumAndroidPort.clean_up_test_run):
3027
3028 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3029
3030         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3031         https://bugs.webkit.org/show_bug.cgi?id=95180
3032
3033         Reviewed by Chris Fleizach.
3034
3035         The bug that was fixed stood in the way of fully implementing stringValue().
3036         Testing that the bug is fixed requires stringValue() to be fully implemented
3037         and object replacement characters to be printable.
3038
3039         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3040         (replaceCharactersForResults): New method which turns object replacement
3041         characters into "<obj>" so that the characters can be properly shown in
3042         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3043         accessible text of a single object in the accessible tree doesn't mess up
3044         the readibility of the results.
3045         (AccessibilityUIElement::stringValue): Remove the code that immediately
3046         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3047         replaceCharactersForResults() prior to returning the accessible string
3048         value.
3049
3050 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3051
3052         MediaStream API: Add MediaStream management to RTCPeerConnection
3053         https://bugs.webkit.org/show_bug.cgi?id=95543
3054
3055         Reviewed by Adam Barth.
3056
3057         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3058
3059         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3060         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3061         (MockWebRTCPeerConnectionHandler::addStream):
3062         (MockWebRTCPeerConnectionHandler::removeStream):
3063         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3064         (MockWebRTCPeerConnectionHandler):
3065
3066 2012-08-31  Tony Chang  <tony@chromium.org>
3067
3068         Remove ENABLE_CSS3_FLEXBOX compile time flag
3069         https://bugs.webkit.org/show_bug.cgi?id=95382
3070
3071         Reviewed by Ojan Vafai.
3072
3073         Everyone is already enabling this by default and the spec has stablized.
3074
3075         * Scripts/webkitperl/FeatureList.pm:
3076         * qmake/mkspecs/features/features.pri:
3077
3078 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3079
3080         objc_msgSend and IMP should be cast appropriately before using
3081         https://bugs.webkit.org/show_bug.cgi?id=95242
3082
3083         Reviewed by Benjamin Poulain.
3084
3085         Fix for older compilers. Pass id as the return type to the template
3086         instead of relying on default type.
3087
3088         * DumpRenderTree/mac/DumpRenderTree.mm:
3089         (drt_NSFontManager_availableFontFamilies):
3090         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3091         (WTR::wtr_NSFontManager_availableFontFamilies):
3092
3093 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3094
3095         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3096         https://bugs.webkit.org/show_bug.cgi?id=89616
3097
3098         Reviewed by Eric Seidel.
3099
3100         Add the new 'executive' optional function argument to the SCM.in_working_directory
3101         class method. This way we get to reuse an Executive instance which is necessary in testing
3102         when we're operating with a mock version of the object.
3103
3104         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3105         the SCMDetector with the generator's FileSystem and Executive instances.
3106
3107         * Scripts/webkitpy/common/checkout/scm/detection.py:
3108         (SCMDetector.detect_scm_system):
3109         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3110         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3111         Executive output and test it against expected output.
3112         * Scripts/webkitpy/common/checkout/scm/git.py:
3113         (Git.in_working_directory):
3114         * Scripts/webkitpy/common/checkout/scm/scm.py:
3115         (SCM.in_working_directory):
3116         * Scripts/webkitpy/common/checkout/scm/svn.py:
3117         (SVN.in_working_directory):
3118         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3119         (JSONResultsGeneratorBase.__init__):
3120         (JSONResultsGeneratorBase._get_svn_revision):
3121
3122 2012-08-31  Jon Lee  <jonlee@apple.com>
3123
3124         [Tests] Add basic tests to http/tests/notifications
3125         https://bugs.webkit.org/show_bug.cgi?id=95493
3126         <rdar://problem/12209303>
3127
3128         Reviewed by Alexey Proskuryakov.
3129
3130         Add permission request support for WTR.
3131
3132         * WebKitTestRunner/TestController.cpp:
3133         (WTR::TestController::initialize):
3134         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3135         * WebKitTestRunner/TestController.h:
3136         (TestController):
3137
3138 2012-08-31  Jon Lee  <jonlee@apple.com>
3139
3140         [DRT] Make simulating a web click on a notification a queued task
3141         https://bugs.webkit.org/show_bug.cgi?id=95546
3142         <rdar://problem/12214170>
3143
3144         Reviewed by Alexey Proskuryakov.
3145
3146         Making the web click happen asynchronously better mimics user interaction with the platform.
3147
3148         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3149         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3150         not set.
3151         * DumpRenderTree/mac/DumpRenderTree.mm:
3152         (dump): Assert that the flag is not set.
3153         * DumpRenderTree/mac/TestRunnerMac.mm:
3154         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3155         notification. In the case where the block gets executed after the flag has been unset, we avoid
3156         performing the click.
3157
3158 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3159
3160         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3161         https://bugs.webkit.org/show_bug.cgi?id=95575
3162
3163         Reviewed by Csaba Osztrogonác.
3164
3165         Output 100% difference in the case of differing image dimensions so
3166         the test harness knows that we won't produce any output further.
3167         This matches the behavior of other ports.
3168
3169         * DumpRenderTree/qt/ImageDiff.cpp:
3170         (main):
3171
3172 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3173
3174         Unreviewed, rolling out r127261.
3175         http://trac.webkit.org/changeset/127261
3176         https://bugs.webkit.org/show_bug.cgi?id=95572
3177
3178         This patch depends on other build fixes (see blockers of bug
3179         95466) which should land first (Requested by milian on
3180         #webkit).
3181
3182         * qmake/mkspecs/features/features.prf:
3183
3184 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3185
3186         [Qt] Support WebKit2/QML on QNX
3187         https://bugs.webkit.org/show_bug.cgi?id=95466
3188
3189         Reviewed by Noam Rosenthal.
3190
3191         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3192         this should finally work now.
3193
3194         * qmake/mkspecs/features/features.prf:
3195
3196 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3197
3198         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3199         https://bugs.webkit.org/show_bug.cgi?id=95400
3200
3201         Reviewed by Dirk Pranke.
3202
3203         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3204
3205         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3206         (ChromiumAndroidPort.skipped_layout_tests):
3207
3208 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3209
3210         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3211         https://bugs.webkit.org/show_bug.cgi?id=95499
3212
3213         Unreviewed. One more fix to avoid trying to run the empty string.
3214
3215         * Scripts/webkitdirs.pm:
3216         (buildAutotoolsProject):
3217
3218 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3219
3220         Unreviewed, rolling out r127171.
3221         http://trac.webkit.org/changeset/127171
3222         https://bugs.webkit.org/show_bug.cgi?id=95505
3223
3224         testRunner does not need dumpWebNotificationCallbacks().
3225         (Requested by jonlee on #webkit).
3226
3227         * DumpRenderTree/TestRunner.cpp:
3228         (TestRunner::TestRunner):
3229         (TestRunner::staticFunctions):
3230         * DumpRenderTree/TestRunner.h:
3231         (TestRunner):
3232         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3233         (-[MockWebNotificationProvider webView:didShowNotification:]):
3234         (-[MockWebNotificationProvider webView:didClickNotification:]):
3235         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3236         * DumpRenderTree/mac/UIDelegate.mm:
3237         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3238
3239 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3240
3241         objc_msgSend and IMP should be cast appropriately before using
3242         https://bugs.webkit.org/show_bug.cgi?id=95242
3243
3244         Reviewed by Benjamin Poulain.
3245
3246         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3247         to a function pointer with right types when calling objc_msgSend and an
3248         IMP method directly.
3249
3250         * DumpRenderTree/mac/DumpRenderTree.mm:
3251         (drt_NSFontManager_availableFontFamilies):
3252         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3253         (WTR::wtr_NSFontManager_availableFontFamilies):
3254
3255 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3256
3257         Replace JSC::UString by WTF::String
3258         https://bugs.webkit.org/show_bug.cgi?id=95271
3259
3260         Reviewed by Geoffrey Garen.
3261
3262         Get rid of UString.
3263
3264         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3265         * gdb/webkit.py:
3266         (WTFStringPrinter.to_string):
3267         (JSCIdentifierPrinter.to_string):
3268         (JSCJSStringPrinter.to_string):
3269         (add_pretty_printers):
3270
3271 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3272
3273         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3274         https://bugs.webkit.org/show_bug.cgi?id=95495
3275
3276         Reviewed by Ojan Vafai.
3277
3278         This is a follow-on to bug 95370 that adds in support for
3279         platform/wk2/TestExpectations and
3280         platform/{mac,win}-$version/TestExpectations.
3281
3282         * Scripts/webkitpy/layout_tests/port/apple.py:
3283         (ApplePort.expectations_files):
3284         * Scripts/webkitpy/layout_tests/port/base.py:
3285         (Port._skipped_file_search_paths):
3286         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3287         (MacTest.test_expectations_files):
3288         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3289         (MockDRTPortTest.make_port):
3290         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3291         (WinPortTest.test_expectations_files):
3292
3293 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3294
3295         executive.run_in_parallel() hangs if given nothing to do
3296         https://bugs.webkit.org/show_bug.cgi?id=95387
3297
3298         Reviewed by Ojan Vafai.
3299
3300         Check to make sure that Executive.run_in_parallel() requires
3301         a non-empty list of commands to execute; passing an empty list
3302         seems surely like a programming error.
3303
3304         * Scripts/webkitpy/common/system/executive.py:
3305         (Executive.run_in_parallel):
3306         * Scripts/webkitpy/common/system/executive_unittest.py:
3307         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3308
3309 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3310
3311         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3312         https://bugs.webkit.org/show_bug.cgi?id=94746
3313
3314         Reviewed by Ojan Vafai.
3315
3316         Add an assertion to diff_image() to check that we are passing
3317         tolerance=0 explicitly when diffing ref test results.
3318
3319         * Scripts/webkitpy/layout_tests/port/test.py:
3320         (TestPort.diff_image):
3321
3322 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3323
3324         NRWT should look in mac-wk2 for a TestExpecations file
3325         https://bugs.webkit.org/show_bug.cgi?id=95370
3326
3327         Reviewed by Ojan Vafai.
3328
3329         Adds support for mac-wk2 and win-wk2 to expectations_files()
3330         for the apple mac and apple win ports.
3331         
3332         * Scripts/webkitpy/layout_tests/port/apple.py:
3333         (ApplePort.expectations_files):
3334         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3335         (MacTest.test_expectations_files):
3336         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3337         (WinTest.test_expectations_files):
3338         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3339         (PortTestCase.test_expectations_files):
3340
3341 2012-08-30  Jon Lee  <jonlee@apple.com>
3342
3343         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3344         https://bugs.webkit.org/show_bug.cgi?id=95232
3345         <rdar://problem/12190776>
3346
3347         Reviewed by Alexey Proskuryakov.
3348
3349         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3350
3351         * DumpRenderTree/TestRunner.cpp:
3352         (TestRunner::TestRunner):
3353         (dumpWebNotificationCallbacksCallback):
3354         (TestRunner::staticFunctions):
3355         * DumpRenderTree/TestRunner.h:
3356         (TestRunner):
3357         (TestRunner::dumpWebNotificationCallbacks):
3358         (TestRunner::setDumpWebNotificationCallbacks):
3359         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3360         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3361         (-[MockWebNotificationProvider webView:didShowNotification:]):
3362         (-[MockWebNotificationProvider webView:didClickNotification:]):
3363         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3364         * DumpRenderTree/mac/UIDelegate.mm:
3365         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3366
3367 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3368
3369         MediaStream API: Introduce MediaConstraints
3370         https://bugs.webkit.org/show_bug.cgi?id=95198
3371
3372         Reviewed by Adam Barth.
3373
3374         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3375
3376         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3377         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3378         (isSupportedConstraint):
3379         (isValidConstraint):
3380         (MockWebRTCPeerConnectionHandler::initialize):
3381         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3382         (MockWebRTCPeerConnectionHandler):
3383
3384 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3385
3386         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3387         https://bugs.webkit.org/show_bug.cgi?id=95454
3388
3389         Reviewed by Kenneth Rohde Christiansen.
3390
3391         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3392
3393         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3394         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3395
3396 2012-08-30  Leo Yang  <leoyang@rim.com>
3397
3398         Update my email address.
3399
3400         Not reviewed.
3401
3402         * Scripts/webkitpy/common/config/committers.py:
3403
3404 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3405
3406         [NRWT] Add support for recognizing arbitrary process names in crash lines
3407         https://bugs.webkit.org/show_bug.cgi?id=95435
3408
3409         Reviewed by Adam Barth.
3410
3411         When running layout tests in the chromium port using the content shell,
3412         we want to be able to report sub-process crashes as well.
3413
3414         * Scripts/webkitpy/layout_tests/port/driver.py:
3415         (Driver._check_for_driver_crash):
3416         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3417         (DriverTest.test_check_for_driver_crash):
3418
3419 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3420
3421         Random test-webkitpy failures on the buildbot
3422         https://bugs.webkit.org/show_bug.cgi?id=95096
3423
3424         Reviewed by Dirk Pranke.
3425
3426         Suppress occasional errors when running test-webkitpy on GTK builders
3427         by running these tests serially. The 64-bit Release builder is especially
3428         prone to these as it can run up to 24 tests in parallel.
3429
3430         Despite the tests not being run in parallel, the testing only lasts a handful
3431         of seconds more, so this is a worthy trade-off to avoid unnecessary
3432         false-alarm redness on the GTK builders.
3433
3434         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3435         (RunPythonTests.start):
3436
3437 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3438
3439         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3440         https://bugs.webkit.org/show_bug.cgi?id=95380
3441
3442         Reviewed by Michael Saboff.
3443
3444         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3445         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3446         the crash.
3447
3448 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3449
3450         AX: Canvas should have a distinct role
3451         https://bugs.webkit.org/show_bug.cgi?id=95248
3452
3453         Reviewed by Chris Fleizach.
3454
3455         Add support for canvas accessibility role.
3456
3457         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3458         (roleToString):
3459
3460 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3461
3462         [Gtk] Process Gtk 3.4 smooth scroll events properly
3463         https://bugs.webkit.org/show_bug.cgi?id=88070
3464
3465         Added continousMouseScrollBy support in WebKitTestRunner, and added
3466         implementation for gtk, and stub for Qt, mac and EFL.
3467
3468         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3469         scroll for emulating multi-tick mouseScrollBy events.
3470
3471         Reviewed by Martin Robinson.
3472
3473         * DumpRenderTree/gtk/EventSender.cpp:
3474         (mouseScrollByCallback):
3475         (continuousMouseScrollByCallback):
3476         * WebKitTestRunner/EventSenderProxy.h:
3477         (EventSenderProxy):
3478         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3479         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3480         (WTR::EventSendingController::mouseScrollBy):
3481         (WTR):
3482         (WTR::EventSendingController::continuousMouseScrollBy):
3483         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3484         (EventSendingController):
3485         * WebKitTestRunner/TestController.cpp:
3486         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3487         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3488         (WTR):
3489         (WTR::EventSenderProxy::mouseScrollBy):
3490         (WTR::EventSenderProxy::continuousMouseScrollBy):
3491         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3492         (WTR):
3493         (WTR::EventSenderProxy::continuousMouseScrollBy):
3494         * WebKitTestRunner/mac/EventSenderProxy.mm:
3495         (WTR::EventSenderProxy::continuousScrollBy):
3496         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3497         (WTR::EventSenderProxy::continuousMouseScrollBy):
3498         (WTR):
3499
3500 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3501
3502         [chromium] Support high DIP pixel tests with DumpRenderTree
3503         https://bugs.webkit.org/show_bug.cgi?id=94935
3504
3505         Reviewed by James Robinson.
3506
3507         Adding device scale factor into the drt image dumping code
3508
3509         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3510         (DRTTestRunner::reset):
3511         (DRTTestRunner::setBackingScaleFactor):
3512         * DumpRenderTree/chromium/WebViewHost.cpp:
3513         (WebViewHost::setDeviceScaleFactor):
3514         (WebViewHost::paintInvalidatedRegion):
3515         (WebViewHost::canvas):
3516         * DumpRenderTree/chromium/WebViewHost.h:
3517         (WebViewHost):
3518
3519 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3520
3521         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3522         https://bugs.webkit.org/show_bug.cgi?id=95177
3523
3524         Reviewed by Dirk Pranke.
3525
3526         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3527
3528         * Scripts/webkitpy/common/checkout/scm/git.py:
3529
3530 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3531
3532         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3533         https://bugs.webkit.org/show_bug.cgi?id=95222
3534
3535         Reviewed by Adam Barth.
3536
3537         The code we had to remove REBASELINE lines from the
3538         TestExpectations files did not handle multiple files (in a
3539         cascade) correctly; we weren't limiting lines to a particular
3540         file correctly in without_rebaseline_modifier(). This patch
3541         fixes that and corrects the tests (which weren't correct and
3542         didn't cover things very well).
3543
3544         Note also that the webkit-patch rebaseline-commands are still
3545         using the include_overrides=False option in a couple places;
3546         this is never correct or needed at this point. This patch fixes
3547         the usage for webkit-patch rebaseline-expectations, but I still
3548         need to fix rebaseline-test-internal, which I will do in a
3549         separate patch (see bug 95268).
3550
3551         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3552         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3553         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3554         (RebaseliningTest.assertRemove):
3555         (RebaseliningTest.test_remove):
3556         * Scripts/webkitpy/tool/commands/rebaseline.py:
3557         (RebaselineExpectations._update_expectations_files):
3558
3559 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3560
3561         webkit-patch rebaseline-expectations hangs
3562         https://bugs.webkit.org/show_bug.cgi?id=95243
3563
3564         Reviewed by Tony Chang.
3565
3566         Don't try to run no commands in parallel; report an error
3567         instead that we didn't find any tests to rebaseline.
3568
3569         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3570
3571         * Scripts/webkitpy/tool/commands/rebaseline.py:
3572         (RebaselineExpectations.execute):
3573         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3574         (_assert_command):
3575         (test_rebaseline_expectations_noop):
3576
3577 2012-08-29  Brady Eidson  <beidson@apple.com>
3578
3579         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3580         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3581
3582         Reviewed by Sam Weinig.
3583
3584         Add a test plug-in that calls back into the page with info on the NPWindow passed
3585         in to NPP_SetWindow.
3586
3587         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3588         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3589         (LogNPPSetWindow):
3590         (LogNPPSetWindow::LogNPPSetWindow):
3591         (LogNPPSetWindow::NPP_SetWindow):
3592
3593 2012-08-29  Jon Lee  <jonlee@apple.com>
3594
3595         [Mac] Basic DRT support for web notifications
3596         https://bugs.webkit.org/show_bug.cgi?id=79492
3597         <rdar://problem/10357639>
3598
3599         Reviewed by Alexey Proskuryakov.
3600
3601         This patch implements the stubs for web notification support on DRT. Assume that when
3602         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3603         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3604
3605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3606         * DumpRenderTree/mac/DumpRenderTree.mm:
3607         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3608         web view.
3609         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3610
3611         * DumpRenderTree/mac/TestRunnerMac.mm:
3612         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3613         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3614         (TestRunner::removeAllWebNotificationPermissions):
3615         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3616         simulate the click. This is similar to how WTR performs the click.
3617         * DumpRenderTree/mac/UIDelegate.mm:
3618         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3619         user allows web notifications.
3620
3621         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3622         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3623         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3624         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3625         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
3626         (-[MockWebNotificationProvider registerWebView:]):
3627         (-[MockWebNotificationProvider unregisterWebView:]):
3628         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
3629         notification did show.
3630         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
3631         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
3632         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
3633         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
3634         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
3635         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
3636         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
3637         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
3638         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
3639         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
3640         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
3641
3642 2012-08-29  Rob Buis  <rbuis@rim.com>
3643
3644         [BlackBerry] Adjust wtf include header style
3645         https://bugs.webkit.org/show_bug.cgi?id=95368
3646
3647         Reviewed by Yong Li.
3648
3649         Switch to #include <wtf/...> like the other ports.
3650
3651         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3652         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
3653         * DumpRenderTree/blackberry/PNGImageEncoder.h:
3654         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3655         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
3656         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3657
3658 2012-08-29  Roger Fong  <roger_fong@apple.com>
3659
3660         Update cygwin-downloader.zip to match modified downloader script.
3661         https://bugs.webkit.org/show_bug.cgi?id=76936
3662
3663         Rubber Stamped by Jon Honeycutt.
3664
3665         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
3666         Updating zip to reflect changes.
3667
3668         * CygwinDownloader/cygwin-downloader.zip:
3669
3670 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3671
3672         Stylechecker warns about comparison to zero when comparing to 0.5
3673         https://bugs.webkit.org/show_bug.cgi?id=94913
3674
3675         Reviewed by Dirk Pranke.
3676
3677         According to the python documentation, \W is the character group with all
3678         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
3679         to [^\w]. We need to exclude the dot "." as well, so that floating point
3680         values do not trigger this warning. Adding a unit test that shows the problem.
3681
3682         * Scripts/webkitpy/style/checkers/cpp.py:
3683         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
3684         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3685         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
3686
3687 2012-08-29  Jon Lee  <jonlee@apple.com>
3688
3689         WTR build fixes.
3690
3691         * WebKitTestRunner/CMakeLists.txt:
3692         * WebKitTestRunner/GNUmakefile.am:
3693         * WebKitTestRunner/Target.pri:
3694         * WebKitTestRunner/WebNotificationProvider.cpp:
3695         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
3696         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3697
3698 2012-08-29  Jon Lee  <jonlee@apple.com>
3699
3700         [WK2] Basic WTR support for web notifications
3701         https://bugs.webkit.org/show_bug.cgi?id=95154
3702         <rdar://problem/12184492>
3703
3704         Reviewed by Alexey Proskuryakov.
3705
3706         Implement WTR support, without platform event output (bug 95233).
3707
3708         Legacy APIs will not be supported, since many of the tests are skipped
3709         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
3710         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
3711         the tests to http/tests/notifications.
3712
3713         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
3714         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
3715         be invoked from the UIProcess.
3716
3717         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3718         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3719         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
3720         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
3721         notification's internal ID.
3722         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3724         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
3725         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
3726         (WTR::TestRunner::removeAllWebNotificationPermissions):
3727         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
3728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3729
3730         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
3731         class.
3732         * WebKitTestRunner/TestInvocation.cpp:
3733         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
3734         TestInvocation forwards that request to the TestController.
3735         * WebKitTestRunner/TestController.cpp:
3736         (WTR::TestController::initialize): Set the provider.
3737         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
3738         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
3739         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
3740
3741         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
3742         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
3743         * WebKitTestRunner/WebNotificationProvider.h: Added.
3744         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
3745         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
3746         the notification got shown.
3747         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
3748         got closed.
3749         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
3750         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
3751         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
3752         permissions. For testing purposes, we always want this set to be empty.
3753         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
3754         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
3755
3756         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
3757
3758 2012-08-29  Kamil Blank  <k.blank@samsung.com>
3759
3760         [EFL] Add setting API for allow universal/file access from file URLs.
3761         https://bugs.webkit.org/show_bug.cgi?id=83121
3762
3763         Reviewed by Eric Seidel.
3764
3765         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
3766
3767         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3768         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3769         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3770         (TestRunner::setAllowUniversalAccessFromFileURLs):
3771         (TestRunner::setAllowFileAccessFromFileURLs):
3772
3773 2012-08-29  Jon Lee  <jonlee@apple.com>
3774
3775         Update TestRunner API for web notifications
3776         https://bugs.webkit.org/show_bug.cgi?id=95093
3777         <rdar://problem/12179649>
3778
3779         Reviewed by Alexey Proskuryakov.
3780
3781         As it turns out the patch for this accidentally got squashed into the commit for
3782         bug 95099 (r126909). This amendment patch adds some comments about the renaming
3783         of the older TestRunner API for web notifications.
3784
3785         * DumpRenderTree/TestRunner.h:
3786         (TestRunner):
3787
3788 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3789
3790         Unreviewed, rolling out r126972.
3791         http://trac.webkit.org/changeset/126972
3792         https://bugs.webkit.org/show_bug.cgi?id=95349
3793
3794         accessibility/canvas-description-and-role.html has been
3795         failing consistently on several bots and Dominic needs some
3796         time to investigate why (Requested by jchaffraix on #webkit).
3797
3798         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3799         (roleToString):
3800
3801 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
3802
3803         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
3804         https://bugs.webkit.org/show_bug.cgi?id=84707
3805
3806         Reviewed by Gustavo Noronha Silva.
3807
3808         Most of the warnings have been fixed now that FindCairo.cmake and
3809         FindGLIB.cmake have been rewritten. The remaining one, related to
3810         FindFontconfig.cmake, shows up when building on a 64-bit
3811         Debian-based systems.
3812
3813         jhbuild installs libraries into lib64/ by default on 64-bit Linux
3814         installations, while CMake does not look for libraries in lib64/
3815         when /etc/debian_version exists on the system. The FIND_LIBRARY()
3816         would then sometimes end up using the system installation instead of
3817         the jhbuild one, causing mismatches and, when pkg-config is not used
3818         at all, failing to find libraries altogether.
3819
3820         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
3821         when use_lib64 is set to force CMake to look into lib64/ regardless
3822         of the presence of /etc/debian_version.
3823
3824 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3825
3826         The 2d.imageData.object.round canvas test is failing
3827         https://bugs.webkit.org/show_bug.cgi?id=40272
3828
3829         Reviewed by Benjamin Poulain.
3830
3831         Updating patch to address Benjamin's review comments.
3832         Adding a WTF test to test lrint implementation.
3833
3834         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
3835         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
3836         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
3837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
3838         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
3839         (TestWebKitAPI):
3840         (TestWebKitAPI::TEST):
3841         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
3842
3843 2012-08-29  Florin Malita  <fmalita@chromium.org>
3844
3845         Unreviewed, updating Kelly Norton's email address at his request.
3846
3847         * Scripts/webkitpy/common/config/committers.py:
3848
3849 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3850
3851         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
3852         https://bugs.webkit.org/show_bug.cgi?id=93723
3853
3854         Reviewed by Dirk Pranke.
3855
3856         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3857         (TestExpectationParser.expectation_for_skipped_test):
3858         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3859         (SkippedTests.test_skipped_entry_dont_exist):
3860
3861 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3862
3863         Unreviewed, rolling out r120113.
3864         http://trac.webkit.org/changeset/120113
3865         https://bugs.webkit.org/show_bug.cgi?id=95320
3866
3867         Wrong fix for the problem, experimentally rolling it out for
3868         bug 95237. (Requested by rakuco on #webkit).
3869
3870         * efl/jhbuildrc:
3871
3872 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3873
3874         AX: Canvas should have a distinct role
3875         https://bugs.webkit.org/show_bug.cgi?id=95248
3876
3877         Reviewed by Chris Fleizach.
3878
3879         Add support for canvas accessibility role.
3880
3881         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3882         (roleToString):
3883
3884 2012-08-28  Eric Seidel  <eric@webkit.org>
3885
3886         cr-ews bot doesn't set CWD correctly when zipping layout test results
3887         https://bugs.webkit.org/show_bug.cgi?id=91265
3888
3889         Reviewed by Kenneth Russell.
3890
3891         This should make the zips slightly less cumbersome to deal with.
3892
3893         * Scripts/webkitpy/common/system/workspace.py:
3894         (Workspace.create_zip):
3895         * Scripts/webkitpy/common/system/workspace_unittest.py:
3896         (WorkspaceTest.test_create_zip):
3897         (WorkspaceTest.test_create_zip_exception):
3898
3899 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
3900
3901         Fix the Commiters script
3902
3903         Unreviewed.
3904
3905         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
3906
3907         * Scripts/webkitpy/common/config/committers.py:
3908
3909 2012-08-28  Roger Fong  <roger_fong@apple.com>
3910
3911         Unreviewed. Adding myself to committers list.
3912
3913         * Scripts/webkitpy/common/config/committers.py:
3914
3915 2012-08-28  Roger Fong  <roger_fong@apple.com>
3916
3917         Add minires to list of required cygwin install packages.
3918         https://bugs.webkit.org/show_bug.cgi?id=76936
3919
3920         Reviewed by Tim Horton.
3921
3922         * CygwinDownloader/cygwin-downloader.py:
3923
3924 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
3925
3926         [Chromium-Android] Upstream layout test expectations (Part 2)
3927         https://bugs.webkit.org/show_bug.cgi?id=95212
3928
3929         Reviewed by Adam Barth.
3930
3931         - Now run both gpu path and non-gpu path of 2d canvas layout tests
3932         because both are used in chromium-android.
3933
3934         - Exclude all webgl tests because webgl is not enabled yet.
3935
3936         - Removed 'win' from the baseline fallback list. This was a mistake.
3937
3938         - Moved some small directories to TestExpectations from skipped_layout_tests().
3939
3940         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3941         (ChromiumAndroidPort):
3942         (ChromiumAndroidPort.skipped_layout_tests):
3943
3944 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
3945
3946         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
3947         https://bugs.webkit.org/show_bug.cgi?id=95185
3948
3949         Reviewed by Chris Fleizach.
3950
3951         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3952         (AccessibilityUIElement::titleUIElement): Implemented
3953         Gets the ATK_RELATION_LABELLED_BY target.
3954         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
3955         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
3956         bug 95180 is fixed.
3957
3958 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
3959
3960         AX: Crash due to object getting deleted inside updateBackingStore
3961         https://bugs.webkit.org/show_bug.cgi?id=94619
3962
3963         Reviewed by Chris Fleizach.
3964
3965         Change isValid to !isDetached after deleting isValid from
3966         chromium WebAccessibilityObject as being redundant.
3967
3968         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3969         (AccessibilityUIElement::isValidGetterCallback):
3970
3971 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3972
3973         Unreviewed, rolling out r126914.
3974         http://trac.webkit.org/changeset/126914
3975         https://bugs.webkit.org/show_bug.cgi?id=95239
3976
3977         it breaks everything and fixes nothing (Requested by pizlo on
3978         #webkit).
3979
3980         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3981         (MockWebSpeechInputController::addMockRecognitionResult):
3982         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3983         (NotificationPresenter::simulateClick):
3984         (NotificationPresenter::show):
3985         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3986         (CppBoundClass::~CppBoundClass):
3987         (CppBoundClass::invoke):
3988         (CppBoundClass::getProperty):
3989         (CppBoundClass::setProperty):
3990         (CppBoundClass::bindCallback):
3991         (CppBoundClass::bindProperty):
3992         * DumpRenderTree/chromium/WebPreferences.cpp:
3993         (applyFontMap):
3994         * DumpRenderTree/chromium/WebViewHost.cpp:
3995         (WebViewHost::printResourceDescription):
3996         * DumpRenderTree/mac/TestRunnerMac.mm:
3997         (worldIDForWorld):
3998         (TestRunner::evaluateScriptInIsolatedWorld):
3999         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4000         (AccessibilityController::~AccessibilityController):
4001         (AccessibilityController::winNotificationReceived):
4002         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4003         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4004         * DumpRenderTree/win/TestRunnerWin.cpp:
4005         (worldIDForWorld):
4006         (TestRunner::evaluateScriptInIsolatedWorld):
4007         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4008         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4009         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4010         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4011         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4012         (WTR::TestRunner::worldIDForWorld):
4013         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4014
4015 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4016
4017         Rename first/second to key/value in HashMap iterators
4018         https://bugs.webkit.org/show_bug.cgi?id=82784
4019
4020         Reviewed by Eric Seidel.
4021
4022         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4023         (MockWebSpeechInputController::addMockRecognitionResult):
4024         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4025         (NotificationPresenter::simulateClick):
4026         (NotificationPresenter::show):
4027         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4028         (CppBoundClass::~CppBoundClass):
4029         (CppBoundClass::invoke):
4030         (CppBoundClass::getProperty):
4031         (CppBoundClass::setProperty):
4032         (CppBoundClass::bindCallback):
4033         (CppBoundClass::bindProperty):
4034         * DumpRenderTree/chromium/WebPreferences.cpp:
4035         (applyFontMap):
4036         * DumpRenderTree/chromium/WebViewHost.cpp:
4037         (WebViewHost::printResourceDescription):
4038         * DumpRenderTree/mac/TestRunnerMac.mm:
4039         (worldIDForWorld):
4040         (TestRunner::evaluateScriptInIsolatedWorld):
4041         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4042         (AccessibilityController::~AccessibilityController):
4043         (AccessibilityController::winNotificationReceived):
4044         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4045         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4046         * DumpRenderTree/win/TestRunnerWin.cpp:
4047         (worldIDForWorld):
4048         (TestRunner::evaluateScriptInIsolatedWorld):
4049         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4050         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4051         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4052         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4053         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4054         (WTR::TestRunner::worldIDForWorld):
4055         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4056
4057 2012-08-27  Jon Lee  <jonlee@apple.com>
4058
4059         Update TestRunner API for web notifications
4060         https://bugs.webkit.org/show_bug.cgi?id=95093
4061         <rdar://problem/12179649>
4062
4063         Reviewed by Jessie Berlin.
4064
4065         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
4066
4067         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
4068         This first patch renames the TestRunner calls to use the term "web notifications" instead of
4069         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
4070         additional calls that will be used in the tests that test the standard API.
4071
4072         * DumpRenderTree/TestRunner.h:
4073         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
4074         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
4075         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
4076         (TestRunner::TestRunner):
4077         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
4078         (simulateLegacyWebNotificationClickCallback): Renamed.
4079         (grantWebNotificationPermissionCallback): Renamed.
4080         (denyWebNotificationPermissionCallback): Added.
4081         (removeAllWebNotificationPermissionsCallback): Added.
4082         (simulateWebNotificationClickCallback): Added.
4083         (TestRunner::staticFunctions):
4084         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
4085
4086         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4087         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
4088         (DRTTestRunner::grantWebNotificationPermission):
4089         (DRTTestRunner::denyWebNotificationPermission): Stub.
4090         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
4091         (DRTTestRunner::simulateWebNotificationClick): Stub.
4092         (DRTTestRunner::simulateLegacyWebNotificationClick):
4093         * DumpRenderTree/chromium/DRTTestRunner.h:
4094         (DRTTestRunner):
4095
4096         Added stubs.
4097         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4098         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4099         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4100         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
4101         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
4102         * DumpRenderTree/win/TestRunnerWin.cpp:
4103
4104 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
4105
4106         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
4107         https://bugs.webkit.org/show_bug.cgi?id=94700
4108
4109         Reviewed by Eric Seidel.
4110
4111         Interrupting download with a timeout would be a possible solution.
4112         I imported the socket module and used the setdefaulttimeout() method.
4113         Fixing it is important, because EWS bots need to be restarted regularly
4114         because of this bug.
4115
4116         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4117         (Bugzilla._get_browser):
4118         (Bugzilla.setdefaulttimeout):
4119
4120 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
4121
4122         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
4123         https://bugs.webkit.org/show_bug.cgi?id=95194
4124
4125         Reviewed by Simon Hausmann.
4126
4127         * Scripts/webkitpy/layout_tests/port/qt.py:
4128         (QtPort.setup_environ_for_server):
4129
4130 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
4131
4132         [watchlist] Unreviewed, subscribe to Qt bugs.
4133
4134         * Scripts/webkitpy/common/config/watchlist:
4135
4136 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
4137
4138         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
4139         https://bugs.webkit.org/show_bug.cgi?id=95054
4140
4141         Reviewed by Eric Seidel.
4142
4143         Enable CSS_IMAGE_SET for the Qt build.
4144
4145         * qmake/mkspecs/features/features.pri:
4146
4147 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
4148
4149         [Qt] Enable CSS sticky position
4150         https://bugs.webkit.org/show_bug.cgi?id=95172
4151
4152         Reviewed by Simon Hausmann.
4153
4154         * qmake/mkspecs/features/features.pri:
4155
4156 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
4157
4158         [GTK] Memory cache should be cleared in between test runs
4159         https://bugs.webkit.org/show_bug.cgi?id=95105
4160
4161         Reviewed by Martin Robinson.
4162
4163         Call the new DumpRenderTreeSupportGtk helper method after every test
4164         to clear the memory cache.
4165
4166         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4167         (runTest):
4168
4169 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
4170
4171         Unreviewed, rolling out r126836.
4172         http://trac.webkit.org/changeset/126836
4173         https://bugs.webkit.org/show_bug.cgi?id=95163
4174
4175         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
4176         #webkit).
4177
4178         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4179         (MockWebSpeechInputController::addMockRecognitionResult):
4180         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4181         (NotificationPresenter::simulateClick):
4182         (NotificationPresenter::show):
4183         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4184         (CppBoundClass::~CppBoundClass):
4185         (CppBoundClass::invoke):
4186         (CppBoundClass::getProperty):
4187         (CppBoundClass::setProperty):
4188         (CppBoundClass::bindCallback):
4189         (CppBoundClass::bindProperty):
4190         * DumpRenderTree/chromium/WebPreferences.cpp:
4191         (applyFontMap):
4192         * DumpRenderTree/chromium/WebViewHost.cpp:
4193         (WebViewHost::printResourceDescription):
4194         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4195         (AccessibilityController::~AccessibilityController):
4196         (AccessibilityController::winNotificationReceived):
4197         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4198         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4199         * DumpRenderTree/win/TestRunnerWin.cpp:
4200         (worldIDForWorld):
4201         (TestRunner::evaluateScriptInIsolatedWorld):
4202         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4203         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4204         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4205         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4207         (WTR::TestRunner::worldIDForWorld):
4208         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4209
4210 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4211
4212         Rename first/second to key/value in HashMap iterators
4213         https://bugs.webkit.org/show_bug.cgi?id=82784
4214
4215         Reviewed by Eric Seidel.
4216
4217         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4218         (MockWebSpeechInputController::addMockRecognitionResult):
4219         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4220         (NotificationPresenter::simulateClick):
4221         (NotificationPresenter::show):
4222         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4223         (CppBoundClass::~CppBoundClass):
4224         (CppBoundClass::invoke):
4225         (CppBoundClass::getProperty):
4226         (CppBoundClass::setProperty):
4227         (CppBoundClass::bindCallback):
4228         (CppBoundClass::bindProperty):
4229         * DumpRenderTree/chromium/WebPreferences.cpp:
4230         (applyFontMap):
4231         * DumpRenderTree/chromium/WebViewHost.cpp:
4232         (WebViewHost::printResourceDescription):
4233         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4234         (AccessibilityController::~AccessibilityController):
4235         (AccessibilityController::winNotificationReceived):
4236         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4237         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4238         * DumpRenderTree/win/TestRunnerWin.cpp:
4239         (worldIDForWorld):
4240         (TestRunner::evaluateScriptInIsolatedWorld):
4241         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4242         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4243         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4244         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4246         (WTR::TestRunner::worldIDForWorld):
4247         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4248
4249 2012-08-24  James Robinson  <jamesr@chromium.org>
4250
4251         WebGL should not flip textures on presentation if contents are unchanged
4252         https://bugs.webkit.org/show_bug.cgi?id=94961
4253
4254         Reviewed by Kenneth Russell.
4255
4256         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
4257
4258         * Scripts/webkitpy/layout_tests/port/chromium.py:
4259         (ChromiumPort.virtual_test_suites):
4260
4261 2012-08-27  Gavin Peters  <gavinp@chromium.org>
4262
4263         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
4264         https://bugs.webkit.org/show_bug.cgi?id=95104
4265
4266         Reviewed by Adam Barth.
4267
4268         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
4269
4270         * Scripts/webkitpy/common/net/omahaproxy.py:
4271         (OmahaProxy):
4272         (OmahaProxy.get_revisions):
4273         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
4274         (OmahaProxyTest):
4275         (OmahaProxyTest.test_get_revisions):
4276
4277 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4278
4279         [EFL][WK2] Free Url_Bar on program exit
4280         https://bugs.webkit.org/show_bug.cgi?id=95086
4281
4282         Reviewed by Eric Seidel.
4283
4284         Fix a memory leak by freeing the Url_Bar on program exit.
4285
4286         * MiniBrowser/efl/main.c:
4287         (main): Call url_bar_del() to free the Url_Bar.
4288
4289 2012-08-27  James Robinson  <jamesr@chromium.org>
4290
4291         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
4292         https://bugs.webkit.org/show_bug.cgi?id=95115
4293
4294         Reviewed by Adam Barth.
4295
4296         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
4297         code if the unit tests crash.
4298
4299         * Scripts/run-chromium-webkit-unit-tests:
4300
4301 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
4302
4303         Add ECMAScript Number to String conversion to WTF::String
4304         https://bugs.webkit.org/show_bug.cgi?id=95016
4305
4306         Reviewed by Geoffrey Garen.