[iPad] Should open popover when the spacebar is pressed
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Daniel Bates  <dabates@apple.com>
2
3         [iPad] Should open popover when the spacebar is pressed
4         https://bugs.webkit.org/show_bug.cgi?id=196360
5         <rdar://problem/49389129>
6
7         Reviewed by Brent Fulgham.
8
9         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::isShowingPopover const): Added.
13         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
14         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
15         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
16         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
17         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
18         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
19         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
20         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
21         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
22         (WTR::UIScriptController::isShowingPopover const): Added.
23         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
24         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
25         * TestRunnerShared/UIScriptContext/UIScriptController.h:
26         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
27         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
28         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
29         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
30         (-[TestRunnerWKWebView _willPresentPopover]): Added.
31         (-[TestRunnerWKWebView _didDismissPopover]): Added.
32         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
33         (WTR::UIScriptController::isShowingPopover const): Added.
34         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
35         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
36
37 2019-04-09  Alex Christensen  <achristensen@webkit.org>
38
39         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
40         https://bugs.webkit.org/show_bug.cgi?id=196665
41         <rdar://45115669>
42
43         Reviewed by Geoff Garen.
44
45         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
46         (goBack):
47         (+[SimpleLookupContext sharedLookupContext]):
48         (-[SimpleLookupContext lookUpURL:completionHandler:]):
49         (TEST):
50         (+[Simple3LookupContext sharedLookupContext]): Deleted.
51         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
52
53 2019-04-09  John Wilander  <wilander@apple.com>
54
55         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
56         https://bugs.webkit.org/show_bug.cgi?id=196558
57         <rdar://problem/47650245>
58
59         Reviewed by Youenn Fablet.
60
61         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
62         (TestWebKitAPI::TEST):
63             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
64
65 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
66
67         [CMake] Apple builds should use ICU_INCLUDE_DIRS
68         https://bugs.webkit.org/show_bug.cgi?id=196720
69
70         Reviewed by Konstantin Tokarev.
71
72         * TestWebKitAPI/PlatformMac.cmake:
73
74 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
75
76         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
77         https://bugs.webkit.org/show_bug.cgi?id=196694
78         <rdar://problem/48388734>
79
80         Rubber-stamped by Aakash Jain.
81
82         * Scripts/webkitpy/port/image_diff.py:
83         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
84         * Scripts/webkitpy/port/server_process.py:
85         (ServerProcess.has_available_stdout): Check if stdout has data in it.
86         (ServerProcess._wait_for_data_and_update_buffers_using_select):
87         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
88         * Scripts/webkitpy/port/server_process_mock.py:
89         (MockServerProcess.has_available_stdout):
90         * Scripts/webkitpy/port/server_process_unittest.py:
91         (TestServerProcess.serial_test_basic):
92
93 2019-04-09  Jer Noble  <jer.noble@apple.com>
94
95         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
96         https://bugs.webkit.org/show_bug.cgi?id=196097
97
98         Reviewed by Eric Carlson.
99
100         Drive-by bug fix: allow tests to play audio without a user gesture by default.
101
102         * DumpRenderTree/mac/DumpRenderTree.mm:
103         (resetWebPreferencesToConsistentValues):
104         * WebKitTestRunner/TestController.cpp:
105         (WTR::TestController::resetPreferencesToConsistentValues):
106
107 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
108
109         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
110         https://bugs.webkit.org/show_bug.cgi?id=196690
111
112         Reviewed by Michael Catanzaro.
113
114         * QueueStatusServer/config/queues.py:
115         * Scripts/webkitpy/common/config/ews.json:
116         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
117         (test_ews_name):
118
119 2019-04-09  Chris Dumez  <cdumez@apple.com>
120
121         Loads using loadHTMLString() cause flashing when process-swapping
122         https://bugs.webkit.org/show_bug.cgi?id=196714
123         <rdar://problem/49637354>
124
125         Reviewed by Antti Koivisto.
126
127         Add API test coverage.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
130
131 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
132
133         Unreviewed. Fix ATK accessibility tests after r244059.
134
135         We are failing to load the injected bundle due to undefined symbol
136         AccessibilityUIElement::replaceTextInRange().
137
138         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
139         (WTR::AccessibilityUIElement::replaceTextInRange):
140
141 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
142
143         AX: Support API: accessibilityReplaceRange:withText
144         https://bugs.webkit.org/show_bug.cgi?id=196636
145
146         Unreviewed build fix for Windows port.
147
148         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
149         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
150
151 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
152
153         [CMake][WinCairo] Separate copied headers into different directories
154         https://bugs.webkit.org/show_bug.cgi?id=196655
155
156         Reviewed by Michael Catanzaro.
157
158         * DumpRenderTree/CMakeLists.txt:
159         * MiniBrowser/win/CMakeLists.txt:
160         * TestWebKitAPI/CMakeLists.txt:
161         * TestWebKitAPI/PlatformWin.cmake:
162
163 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
164
165         Log stack-trace for run-webkit-tests when interrupted
166         https://bugs.webkit.org/show_bug.cgi?id=176393
167         <rdar://problem/34262310>
168
169         Reviewed by Lucas Forschler.
170
171         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
172         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
173         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
174         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
175         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
177         (main): Set handlers to log stack trace on interruption.
178
179 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
180
181         AX: Support API: accessibilityReplaceRange:withText
182         https://bugs.webkit.org/show_bug.cgi?id=196636
183
184         Unreviewed build fix for Windows port.
185
186         * DumpRenderTree/AccessibilityUIElement.cpp:
187         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
188
189 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews-build] Scripts using Buildbot API have CORS error
192         https://bugs.webkit.org/show_bug.cgi?id=196709
193
194         Reviewed by Alexey Proskuryakov.
195
196         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
197
198 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
199
200         AX: Support API: accessibilityReplaceRange:withText
201         https://bugs.webkit.org/show_bug.cgi?id=196636
202
203         Reviewed by Daniel Bates.
204
205         * DumpRenderTree/AccessibilityUIElement.cpp:
206         (replaceTextInRangeCallback):
207         (AccessibilityUIElement::replaceTextInRange):
208         (AccessibilityUIElement::getJSClass):
209         * DumpRenderTree/AccessibilityUIElement.h:
210         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
211         (AccessibilityUIElement::replaceTextInRange):
212         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
213         (AccessibilityUIElement::replaceTextInRange):
214         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
215         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
216         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
217         (WTR::AccessibilityUIElement::replaceTextInRange):
218         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
219         (WTR::AccessibilityUIElement::replaceTextInRange):
220
221 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
222
223         [iOS] Do not allow starting selection drags when selection views are not visible
224         https://bugs.webkit.org/show_bug.cgi?id=196686
225         <rdar://problem/49399192>
226
227         Reviewed by Tim Horton.
228
229         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
230         also add some new API tests to cover scenarios where the web view is not first responder.
231
232         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
233         (TestWebKitAPI::TEST):
234         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
235
236         Add a switch to optionally make the web view first responder when starting the simulated drag.
237
238         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
239         (-[DragAndDropSimulator initWithWebView:]):
240         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
241
242 2019-04-08  Justin Fan  <justin_fan@apple.com>
243
244         [Web GPU] Fix Web GPU experimental feature on iOS
245         https://bugs.webkit.org/show_bug.cgi?id=196632
246
247         Reviewed by Myles C. Maxfield.
248
249         Properly make Web GPU available on iOS 11+.
250
251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
252
253 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
254
255         [ews-build] Do not upload archive when Compile Fails
256         https://bugs.webkit.org/show_bug.cgi?id=196674
257
258         Reviewed by Alexey Proskuryakov.
259
260         * BuildSlaveSupport/ews-build/factories.py:
261         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
262         * BuildSlaveSupport/ews-build/steps.py:
263         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
264         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
265         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
266
267 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
268
269         Enable DFG on MIPS
270         https://bugs.webkit.org/show_bug.cgi?id=196689
271
272         Reviewed by Žan Doberšek.
273
274         Since the bytecode change, we enabled the baseline JIT on mips in
275         r240432, but DFG is still missing. With this change, all tests are
276         passing on a ci20 board.
277
278         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
279
280 2019-04-08  Philippe Normand  <pnormand@igalia.com>
281
282         [Flatpak] Second run update-webkitwpe-flatpak fails
283         https://bugs.webkit.org/show_bug.cgi?id=192702
284
285         Reviewed by Carlos Garcia Campos.
286
287         * flatpak/flatpakutils.py:
288         (FlatpakObject.flatpak): Fix typo.
289         (FlatpakPackage.install): When installing, also update to the configured remote commit.
290         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
291
292 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
293
294         [GTK][WPE] outlook.live.com displays old-fashioned UI
295         https://bugs.webkit.org/show_bug.cgi?id=196642
296
297         Reviewed by Carlos Garcia Campos.
298
299         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
300         (TestWebKitAPI::TEST): New Mac platform quirk test.
301
302 2019-04-07  Commit Queue  <commit-queue@webkit.org>
303
304         Unreviewed, rolling out r243956.
305         https://bugs.webkit.org/show_bug.cgi?id=196688
306
307         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
308         by aakashjain on #webkit).
309
310         Reverted changeset:
311
312         "Clicking "Go Back" from a safe browsing warning from an
313         iframe should navigate the WKWebView back to the previous
314         page"
315         https://bugs.webkit.org/show_bug.cgi?id=196665
316         https://trac.webkit.org/changeset/243956
317
318 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
319
320         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
321         https://bugs.webkit.org/show_bug.cgi?id=196669
322
323         Reviewed by Geoffrey Garen.
324
325         Added three new unit tests for WeakHashSet.
326
327         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
328         (WTF_WeakPtr.WeakHashSetConstObjects):
329         (WTF_WeakPtr.WeakHashSetComputesEmpty):
330         (WTF_WeakPtr.WeakHashSetComputeSize):
331
332 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
333
334         Hide next and previous form control buttons when WKWebView is editable
335         https://bugs.webkit.org/show_bug.cgi?id=196672
336         <rdar://problem/35625321>
337
338         Reviewed by Tim Horton.
339
340         Add a new API test.
341
342         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
343         (-[TestWKWebView lastTrailingBarButtonGroup]):
344         (TestWebKitAPI::TEST):
345         * TestWebKitAPI/ios/UIKitSPI.h:
346
347 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
348
349         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
350         https://bugs.webkit.org/show_bug.cgi?id=196077
351         <rdar://problem/49108202>
352
353         Reviewed by Chris Dumez.
354
355         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
356         on new web view.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
359
360 2019-04-05  Saam Barati  <sbarati@apple.com>
361
362         Make compare-results understand MotionMark
363         https://bugs.webkit.org/show_bug.cgi?id=196666
364
365         Reviewed by Yusuke Suzuki.
366
367         * Scripts/compare-results:
368         (PLT5Results):
369         (detectMotionMark):
370         (detectMotionMark1_1):
371         (motionMarkResults):
372         (motionMark1_1Results):
373         (detectBenchmark):
374         (biggerIsBetter):
375         (main):
376
377 2019-04-05  Alex Christensen  <achristensen@webkit.org>
378
379         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
380         https://bugs.webkit.org/show_bug.cgi?id=196665
381         <rdar://45115669>
382
383         Reviewed by Geoff Garen.
384
385         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
386         (goBack):
387         (+[SimpleLookupContext sharedLookupContext]):
388         (-[SimpleLookupContext lookUpURL:completionHandler:]):
389         (TEST):
390         (+[Simple3LookupContext sharedLookupContext]): Deleted.
391         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
392
393 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews-build] Add configuration and architecture for windows builders
396         https://bugs.webkit.org/show_bug.cgi?id=196660
397
398         Reviewed by Lucas Forschler.
399
400         * BuildSlaveSupport/ews-build/config.json:
401
402 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
403
404         webkitpy: Don't run subsequent rounds if interrupted
405         https://bugs.webkit.org/show_bug.cgi?id=196646
406
407         Reviewed by Aakash Jain.
408
409         * Scripts/webkitpy/layout_tests/controllers/manager.py:
410         (Manager.run): Bail out if interrupted.
411
412 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
413
414         Test sessionStorage in PSON private browsing mode
415         https://bugs.webkit.org/show_bug.cgi?id=196561
416
417         Reviewed by Alex Christensen.
418
419         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
420
421 2019-04-05  Commit Queue  <commit-queue@webkit.org>
422
423         Unreviewed, rolling out r243833.
424         https://bugs.webkit.org/show_bug.cgi?id=196645
425
426         This change breaks build of WPE and GTK ports (Requested by
427         annulen on #webkit).
428
429         Reverted changeset:
430
431         "[CMake][WTF] Mirror XCode header directories"
432         https://bugs.webkit.org/show_bug.cgi?id=191662
433         https://trac.webkit.org/changeset/243833
434
435 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
436
437         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
438         https://bugs.webkit.org/show_bug.cgi?id=196635
439
440         Reviewed by Antti Koivisto.
441         
442         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
443         for a test to enable async frame scrolling via:
444             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
445         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
446         
447         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
448
449         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
450         (WTR::InjectedBundle::beginTesting):
451         * WebKitTestRunner/TestController.cpp:
452         (WTR::TestController::resetPreferencesToConsistentValues):
453
454 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
455
456         Use a correct LC_RPATH when building with ASan
457         https://bugs.webkit.org/show_bug.cgi?id=196576
458
459         Reviewed by David Kilzer.
460
461         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
462         so that ../Frameworks is checked. This is simpler and more reliable than updating
463         each SPC service xcconfig.
464
465 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
466
467         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
468         https://bugs.webkit.org/show_bug.cgi?id=196629
469
470         Reviewed by Lucas Forschler.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
473
474 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
475
476         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
477         https://bugs.webkit.org/show_bug.cgi?id=196618
478
479         Reviewed by Lucas Forschler.
480
481         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
482         (StatusBubble): Added QUEUE_TRIGGERS.
483         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
484         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
485         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
486         its parent(builder).
487
488 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-app] Status-bubble steps are sometimes displayed in reverse order
491         https://bugs.webkit.org/show_bug.cgi?id=196625
492
493         Reviewed by Lucas Forschler.
494
495         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
496         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
497
498 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
499
500         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
501         https://bugs.webkit.org/show_bug.cgi?id=196630
502
503         Reviewed by Wenson Hsieh.
504
505         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
506
507 2019-04-04  Youenn Fablet  <youenn@apple.com>
508
509         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
510         https://bugs.webkit.org/show_bug.cgi?id=196543
511
512         Reviewed by Alex Christensen.
513
514         * WebKitTestRunner/TestController.cpp:
515         (WTR::TestController::generatePageConfiguration):
516
517 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-app] Status bubble should not display skipped buildbot steps
520         https://bugs.webkit.org/show_bug.cgi?id=196584
521
522         Reviewed by Lucas Forschler.
523
524         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
525
526 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
527
528         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
529         https://bugs.webkit.org/show_bug.cgi?id=196620
530
531         Reviewed by Lucas Forschler.
532
533         * BuildSlaveSupport/ews-app/ews/config.py:
534
535 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
536
537         [Win] DumpRenderTreeWatchDog.py is not checked into source
538         https://bugs.webkit.org/show_bug.cgi?id=196567
539         <rdar://problem/49525901>
540
541         Reviewed by Lucas Forschler.
542
543         This script is used on Win EWS bots to terminate hanging DRT processes.
544
545         * EWSTools/dumprendertreewatchdog.py: Added.
546
547 2019-04-04  Chris Dumez  <cdumez@apple.com>
548
549         Unreviewed, roll out r243858 which made tests time out.
550
551         Disable new API tests on Windows instead.
552
553         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
554         (TestWebKitAPI::TEST):
555
556 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         [ATK] Cleanup WebPageAccessibilityObjectAtk
559         https://bugs.webkit.org/show_bug.cgi?id=196537
560
561         Reviewed by Michael Catanzaro.
562
563         Also consider files under atk directories as exceptions for GObject conventions.
564
565         * Scripts/webkitpy/style/checkers/cpp.py:
566         (check_identifier_name_in_declaration):
567
568 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
569
570         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
571         https://bugs.webkit.org/show_bug.cgi?id=196588
572         <rdar://problem/49365787>
573
574         Unreviewed build fix for Windows port.
575
576         error C3861: 'kill': identifier not found
577
578         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
579         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
580
581 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
582
583         [ews-build] Cancel build and similar operations should have authentication
584         https://bugs.webkit.org/show_bug.cgi?id=196520
585
586         Reviewed by Dewei Zhu.
587
588         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
589         environment variables.
590
591 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
592
593         [ews-build] Do not trigger queues which are not in production yet
594         https://bugs.webkit.org/show_bug.cgi?id=196581
595
596         Reviewed by Dewei Zhu.
597
598         * BuildSlaveSupport/ews-build/config.json:
599
600 2019-04-03  Chris Dumez  <cdumez@apple.com>
601
602         Unreviewed, fix typo in the name of API test added in r243848.
603
604         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
605         (TestWebKitAPI::TEST):
606
607 2019-04-03  Chris Dumez  <cdumez@apple.com>
608
609         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
610         https://bugs.webkit.org/show_bug.cgi?id=196588
611         <rdar://problem/49365787>
612
613         Reviewed by Ryosuke Niwa.
614
615         Add API test coverage.
616
617         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
618         (TestWebKitAPI::nullJavaScriptCallback):
619         (TestWebKitAPI::didCrashCheckFrames):
620         (TestWebKitAPI::TEST):
621
622 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
623
624         run-webkit-tests: Upload test results (new results database)
625         https://bugs.webkit.org/show_bug.cgi?id=196577
626         <rdar://problem/34841155>
627
628         Reviewed by Lucas Forschler.
629
630         * Scripts/webkitpy/layout_tests/controllers/manager.py:
631         (Manager.run): Upload results after each device shard, since the configuration will be
632         different for each device.
633         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
634         uploaded to a results database.
635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
636         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
637
638 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
639
640         -apple-trailing-word is needed for browser detection
641         https://bugs.webkit.org/show_bug.cgi?id=196575
642
643         Unreviewed.
644
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646
647 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
648
649         [CMake][WTF] Mirror XCode header directories
650         https://bugs.webkit.org/show_bug.cgi?id=191662
651
652         Reviewed by Konstantin Tokarev.
653
654         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
655         builds.
656
657         * CMakeLists.txt:
658         * DumpRenderTree/CMakeLists.txt:
659         * DumpRenderTree/PlatformWin.cmake:
660         * MiniBrowser/win/CMakeLists.txt:
661         * TestWebKitAPI/CMakeLists.txt:
662         * TestWebKitAPI/PlatformWin.cmake:
663         * WebKitTestRunner/PlatformGTK.cmake:
664         * WebKitTestRunner/PlatformWin.cmake:
665
666 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
667
668         [ews-app] Status bubble should not display certain infrastructure status messages
669         https://bugs.webkit.org/show_bug.cgi?id=196550
670
671         Reviewed by Lucas Forschler.
672
673         Do not display the steps which are un-needed for end-user. This information is still avaiable
674         if the user click on the bubble and look at the Buildbot build.
675         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
676         (StatusBubble._steps_messages):
677         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
678
679 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
680
681         [ews-build] Use https for sending data to ews-app
682         https://bugs.webkit.org/show_bug.cgi?id=196492
683
684         Reviewed by Lucas Forschler.
685
686         * BuildSlaveSupport/ews-build/events.py:
687
688 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
689
690         Remove support for -apple-trailing-word
691         https://bugs.webkit.org/show_bug.cgi?id=196525
692
693         Reviewed by Zalan Bujtas.
694
695         This CSS property is nonstandard and not used.
696
697         * Scripts/webkitperl/FeatureList.pm:
698         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
699
700 2019-04-03  Youenn Fablet  <youenn@apple.com>
701
702         Add a test for DOMCache on multiple browsing in case of private browsing
703         https://bugs.webkit.org/show_bug.cgi?id=196524
704
705         Reviewed by Alex Christensen.
706
707         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
708         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
709
710 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
711
712         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
713         https://bugs.webkit.org/show_bug.cgi?id=196540
714
715         Reviewed by Aakash Jain.
716
717         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
718
719 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
720
721         Add plumbing for a compatibility mode preference in WebKit
722         https://bugs.webkit.org/show_bug.cgi?id=196005
723
724         Reviewed by Tim Horton.
725
726         Add new API tests.
727
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
730
731 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
732
733         [WPE][GTK] Update libsrtp dependency package for Debian
734         https://bugs.webkit.org/show_bug.cgi?id=196528
735
736         Reviewed by Frédéric Wang.
737
738         * gtk/install-dependencies:
739         * wpe/install-dependencies:
740
741 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
742
743         [WK2] Add support for Window's beforeprint / afterprint events
744         https://bugs.webkit.org/show_bug.cgi?id=196478
745         <rdar://problem/49535124>
746
747         Unreviewed build fix for MSVC.
748
749         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
750
751         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
752
753         * WebKitTestRunner/TestController.cpp:
754         (WTR::printFrame): Use int and float literals.
755
756 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
757
758         [ews-build] Reassign bots to queues
759
760         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
761
762 2019-04-02  Chris Dumez  <cdumez@apple.com>
763
764         [WK2] Add support for Window's beforeprint / afterprint events
765         https://bugs.webkit.org/show_bug.cgi?id=196478
766
767         Reviewed by Alex Christensen.
768
769         Add minimal implementation for printFrame in WebKitTestRunner.
770
771         * WebKitTestRunner/TestController.cpp:
772         (WTR::printFrame):
773         (WTR::TestController::createOtherPage):
774         (WTR::TestController::createWebViewWithOptions):
775
776 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
777
778         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
779         https://bugs.webkit.org/show_bug.cgi?id=196491
780
781         Reviewed by Lucas Forschler.
782
783         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
784
785 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
786
787         [ews-build] Configure buildbot try credentials in environment variables
788         https://bugs.webkit.org/show_bug.cgi?id=196501
789
790         Reviewed by Lucas Forschler.
791
792         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
793         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
794         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
795
796 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
797
798         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
799         https://bugs.webkit.org/show_bug.cgi?id=196496
800         <rdar://problem/49521634>
801
802         Reviewed by Chris Dumez.
803
804         Add new API tests (see WebKit ChangeLog for more detail).
805
806         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
807         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
808         (TEST):
809
810 2019-04-02  David Kilzer  <ddkilzer@apple.com>
811
812         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
813         <https://webkit.org/b/196499>
814
815         Reviewed by Alexey Proskuryakov.
816
817         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
818         ENABLE_ADDRESS_SANITIZER.
819
820 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
821
822         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
823         https://bugs.webkit.org/show_bug.cgi?id=182757
824
825         Reviewed by Don Olmstead.
826
827         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
828         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
829
830 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
831
832         run-api-tests: Upload test results
833         https://bugs.webkit.org/show_bug.cgi?id=196323
834         <rdar://problem/49356714>
835
836         Reviewed by Lucas Forschler.
837
838         * Scripts/webkitpy/api_tests/manager.py:
839         (Manager):
840         (Manager.run): Upload results to a results database.
841         * Scripts/webkitpy/api_tests/run_api_tests.py:
842         (parse_args): Add upload arguments.
843         * Scripts/webkitpy/port/base.py:
844         (Port):
845         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
846         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
847         with commits from any other associated repositories.
848         * Scripts/webkitpy/port/device.py:
849         (Device):
850         (Device.build_version): Access build_versoin of underlying platform device.
851         * Scripts/webkitpy/port/ios_simulator_unittest.py:
852         (IOSSimulatorTest):
853         (IOSSimulatorTest.test_configuration_for_upload):
854         * Scripts/webkitpy/port/device_port.py:
855         (DevicePort):
856         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
857         the same as the machine uploading results.
858         * Scripts/webkitpy/port/mac.py:
859         (MacPort):
860         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
861         * Scripts/webkitpy/port/mac_unittest.py:
862         (MacTest):
863         (MacTest.test_configuration_for_upload):
864         * Scripts/webkitpy/xcode/simulated_device.py:
865         (SimulatedDeviceManager._create_device_with_runtime):
866         (SimulatedDevice.__init__): Create simulated device with a build_version.
867         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
868         (test_existing_simulator):
869
870 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
871
872         Remove extra newline characters (Follow-up fix to r243707)
873
874         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
875
876 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
877
878         [ews-app] Use API_KEY to accept results data
879         https://bugs.webkit.org/show_bug.cgi?id=196461
880
881         Reviewed by Dewei Zhu.
882
883         * BuildSlaveSupport/ews-app/ews/views/results.py:
884         (Results.post): Validate EWS_API_KEY before accepting any data.
885         * BuildSlaveSupport/ews-build/events.py:
886         (Events.sendData): Send EWS_API_KEY if available along with event data.
887
888 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
889
890         Unable to copy and paste a PDF from Notes into Mail compose body
891         https://bugs.webkit.org/show_bug.cgi?id=196442
892         <rdar://problem/48573098>
893
894         Reviewed by Tim Horton.
895
896         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
897         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
898         to be specified on the item providers.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
901         (TestWebKitAPI::mapItemForTesting):
902         (TestWebKitAPI::contactItemForTesting):
903
904 2019-04-01  Tim Horton  <timothy_horton@apple.com>
905
906         Make UIWKDocumentContext rects per-character instead of per-word
907         https://bugs.webkit.org/show_bug.cgi?id=196459
908
909         Reviewed by Wenson Hsieh.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
912         (TEST):
913         Adjust test results due to switching to per-character rects.
914
915 2019-04-01  Chris Dumez  <cdumez@apple.com>
916
917         UIProcess crash when a prewarmed process is terminated
918         https://bugs.webkit.org/show_bug.cgi?id=196451
919         <rdar://problem/49245471>
920
921         Reviewed by Geoffrey Garen.
922
923         Add API test coverage.
924
925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
926         (TEST):
927
928 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
929
930         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
931         https://bugs.webkit.org/show_bug.cgi?id=196449
932
933         Reviewed by Lucas Forschler.
934
935         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
936         (StatusBubble.get_os_details): Method to get OS and Xcode details.
937         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
938         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
939
940 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
941
942         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
943         https://bugs.webkit.org/show_bug.cgi?id=196444
944
945         Reviewed by Lucas Forschler.
946
947         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
948
949 2019-04-01  Alex Christensen  <achristensen@webkit.org>
950
951         Add SPI to canonicalize NSURLs with WTF::URL
952         https://bugs.webkit.org/show_bug.cgi?id=196415
953         <rdar://problem/44980271>
954
955         Reviewed by Darin Adler.
956
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
958         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
959         (TestWebKitAPI::TEST):
960
961 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
962
963         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
964         https://bugs.webkit.org/show_bug.cgi?id=196441
965
966         Reviewed by Carlos Garcia Campos.
967
968         Don't cache the wpe_view_backend object that might not exist yet at the
969         time of EventSenderProxy constructor invocation, but instead retrieve
970         that object whenever it's required for event dispatching. This should
971         avoid crashes in this constructor now that it's invoked before any
972         PlatformWindow has been set up (as changed in r243496).
973
974         * WebKitTestRunner/EventSenderProxy.h:
975         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
976         (WTR::viewBackend):
977         (WTR::EventSenderProxy::EventSenderProxy):
978         (WTR::EventSenderProxy::mouseDown):
979         (WTR::EventSenderProxy::mouseUp):
980         (WTR::EventSenderProxy::mouseMoveTo):
981         (WTR::EventSenderProxy::mouseScrollBy):
982         (WTR::EventSenderProxy::keyDown):
983         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
984
985 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
986
987         [Win][WebKit] MiniBrowser should support high DPI display
988         https://bugs.webkit.org/show_bug.cgi?id=196391
989
990         Reviewed by Alex Christensen.
991
992         * MiniBrowser/win/WebKitBrowserWindow.cpp:
993         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
994         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
995         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
996
997 2019-03-31  Sam Weinig  <weinig@apple.com>
998
999         Remove more i386 specific configurations
1000         https://bugs.webkit.org/show_bug.cgi?id=196430
1001
1002         Reviewed by Alexey Proskuryakov.
1003
1004         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1005         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1006
1007 2019-03-31  Andy Estes  <aestes@apple.com>
1008
1009         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1010         https://bugs.webkit.org/show_bug.cgi?id=196433
1011         <rdar://problem/49293305>
1012
1013         Reviewed by Tim Horton.
1014
1015         Enhanced API test coverage to include all navigation response policy decisions in both
1016         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1017
1018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1019         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1022         (readFile):
1023         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1024         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1025         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1026         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1027         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1028         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1029         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1030         (-[QuickLookDelegate _downloadDidStart:]):
1031         (-[QuickLookDelegate _download:didReceiveResponse:]):
1032         (-[QuickLookDelegate _download:didReceiveData:]):
1033         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1034         (-[QuickLookDelegate _downloadDidFinish:]):
1035         (-[QuickLookDelegate _download:didFailWithError:]):
1036         (-[QuickLookDelegate _downloadDidCancel:]):
1037         (-[QuickLookDelegate verifyDownload]):
1038         (runTest):
1039         (runTestDecideBeforeLoading):
1040         (runTestDecideAfterLoading):
1041         (TEST):
1042         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1043         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1044         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1045         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1046         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1047         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1048         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1049         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1050         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1051         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1052         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1053         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1054         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1055         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1056
1057 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1058
1059         [CMake] add testdfg as target with build-jsc
1060         https://bugs.webkit.org/show_bug.cgi?id=196393
1061
1062         Reviewed by Saam Barati.
1063
1064         Added testdfg as one of the targets to build when
1065         using CMake.
1066
1067         * Scripts/build-jsc:
1068
1069 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1070
1071         Delete WebMetal implementation in favor of WebGPU
1072         https://bugs.webkit.org/show_bug.cgi?id=195418
1073
1074         Reviewed by Dean Jackson.
1075
1076         * DumpRenderTree/mac/DumpRenderTree.mm:
1077         (enableExperimentalFeatures):
1078         (resetWebPreferencesToConsistentValues):
1079         * Scripts/webkitperl/FeatureList.pm:
1080         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1082         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1083         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1084         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1085         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1086         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1087         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1088         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1089         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1090         (WTR::InjectedBundle::beginTesting):
1091         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1092         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1094
1095 2019-03-29  Chris Dumez  <cdumez@apple.com>
1096
1097         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1098         https://bugs.webkit.org/show_bug.cgi?id=196405
1099         <rdar://problem/49428130>
1100
1101         Reviewed by Wenson Hsieh.
1102
1103         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1104         the popover presentation methods to be no-ops. Use this in the new test added in
1105         r243523 so that we do not swizzle those methods for all tests. This is needed because
1106         those WatchOS tests rely on the popover getting presented and interactive.
1107
1108         * WebKitTestRunner/TestController.cpp:
1109         (WTR::updateTestOptionsFromTestHeader):
1110         * WebKitTestRunner/TestController.h:
1111         * WebKitTestRunner/TestOptions.h:
1112         (WTR::TestOptions::hasSameInitializationOptions const):
1113         * WebKitTestRunner/ios/TestControllerIOS.mm:
1114         (WTR::TestController::platformInitialize):
1115         (WTR::TestController::platformResetStateToConsistentValues):
1116
1117 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1118
1119         [Curl] Add Server Trust Evaluation Support.
1120         https://bugs.webkit.org/show_bug.cgi?id=191646
1121
1122         Reviewed by Fujii Hironori.
1123
1124         Implemented MiniBrowser UI for asking if user trusts the server.
1125
1126         * MiniBrowser/win/Common.cpp:
1127         (askServerTrustEvaluation):
1128         (replaceString):
1129         * MiniBrowser/win/Common.h:
1130         * MiniBrowser/win/MiniBrowserLib.rc:
1131         * MiniBrowser/win/MiniBrowserLibResource.h:
1132         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1133         (createPEMString):
1134         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1135         (WebKitBrowserWindow::canTrustServerCertificate):
1136         * MiniBrowser/win/WebKitBrowserWindow.h:
1137
1138 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1139
1140         Implement ResizeObserver.
1141         https://bugs.webkit.org/show_bug.cgi?id=157743
1142
1143         Reviewed by Simon Fraser.
1144
1145         Support resizeObserverEnabled webPreferences.
1146
1147         * DumpRenderTree/TestOptions.cpp:
1148         (TestOptions::TestOptions):
1149         * DumpRenderTree/TestOptions.h:
1150         * DumpRenderTree/mac/DumpRenderTree.mm:
1151         (setWebPreferencesForTestOptions):
1152         * DumpRenderTree/win/DumpRenderTree.cpp:
1153         (enableExperimentalFeatures):
1154         * Scripts/webkitperl/FeatureList.pm:
1155         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1156
1157 2019-03-28  John Wilander  <wilander@apple.com>
1158
1159         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1160         https://bugs.webkit.org/show_bug.cgi?id=196281
1161         <rdar://problem/48938748>
1162
1163         Reviewed by Alex Christensen.
1164
1165         This patch adds the function isStatisticsHasLocalStorage() to the
1166         TestRunner. With it, the page can query the WebsiteDataStore in the
1167         UI process to make sure that it sees LocalStorage.
1168
1169         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1171         (WTR::TestRunner::isStatisticsHasLocalStorage):
1172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1173         * WebKitTestRunner/TestController.cpp:
1174         (WTR::TestController::isStatisticsHasLocalStorage):
1175         * WebKitTestRunner/TestController.h:
1176         * WebKitTestRunner/TestInvocation.cpp:
1177         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1178
1179 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1180
1181         API::Data::createWithoutCopying should do a null check before calling CFRelease
1182         https://bugs.webkit.org/show_bug.cgi?id=196276
1183         <rdar://problem/48059859>
1184
1185         Reviewed by Alex Christensen.
1186
1187         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1188
1189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1190         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1191         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1192         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1193         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1194         (TestWebKitAPI::TEST):
1195
1196 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1197
1198         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1199         https://bugs.webkit.org/show_bug.cgi?id=186276
1200
1201         Reviewed by Carlos Garcia Campos.
1202
1203         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1204         (webViewLoadChanged):
1205         (testWebResourceGetDataError):
1206         (testWebResourceGetDataEmpty):
1207         (beforeAll):
1208         (webViewloadChanged): Deleted.
1209
1210 2019-03-27  Andy Estes  <aestes@apple.com>
1211
1212         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1213         https://bugs.webkit.org/show_bug.cgi?id=196317
1214
1215         Reviewed by Dan Bernstein.
1216
1217         package-root copies built products into a staging directory using ditto(1), which does not
1218         follow symbolic links as it traverses a directory. Now that the files in
1219         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1220         itself, these become broken links when ditto'd into the staging directory.
1221
1222         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1223
1224         * Scripts/package-root:
1225
1226 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1227
1228         [ews-app] Update display text of Submit for ews analysis
1229         https://bugs.webkit.org/show_bug.cgi?id=196309
1230
1231         Reviewed by Dewei Zhu.
1232
1233         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1234
1235 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1236
1237         run-webkit-tests should check for leaks in WebKit processes
1238         <https://webkit.org/b/193772>
1239         <rdar://problem/46526680>
1240
1241         Reviewed by Ryosuke Niwa.
1242
1243         This works by doing the following:
1244         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1245           The list of child processes are returned one per line:
1246           process.name: pid
1247         - Run the "#LIST CHILD PROCESSES" command just before the
1248           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1249           processes on the ServerProcess object.
1250         - When the `--leaks` switch is handled, run check_for_leaks() on
1251           each child process after the main test harness.
1252
1253         * DumpRenderTree/mac/DumpRenderTree.mm:
1254         (handleControlCommand):
1255         - Use strncmp() instead of strcmp().
1256         - Add support for handling "#LIST CHILD PROCESSES" command.
1257
1258         * Scripts/webkitpy/port/base.py:
1259         (Port.check_for_leaks):
1260         * Scripts/webkitpy/port/darwin.py:
1261         (DarwinPort.check_for_leaks):
1262         - Rename redundant 'process_pid' argument to 'process_id'.
1263
1264         * Scripts/webkitpy/port/driver.py:
1265         (Driver.do_post_tests_work):
1266         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1267           longer the only command this sends to WebKitTestRunner.
1268         - If the `--leaks` switch is present, send the
1269           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1270           result using Port.set_webkit_processes().
1271         (Driver._parse_child_processes_output):
1272         - Add helper method to parse list of child process names and
1273           process IDs returned from WebKitTestRunner.
1274
1275         * Scripts/webkitpy/port/ios_device.py:
1276         (IOSDevicePort.check_for_leaks):
1277         - Rename redundant 'process_pid' argument to 'process_id'.
1278
1279         * Scripts/webkitpy/port/leakdetector.py:
1280         (LeakDetector._parse_leaks_output):
1281         - Return early if there is no leaks_output.
1282         (LeakDetector.check_for_leaks):
1283         - Rename redundant 'process_pid' argument to 'process_id'.
1284
1285         * Scripts/webkitpy/port/server_process.py:
1286         (ServerProcess.__init__):
1287         (ServerProcess.child_processes):
1288         (ServerProcess.set_child_processes):
1289         - Add instance variable to Port to store list of child process
1290           names and process IDs returned from WebKitTestRunner.
1291         (ServerProcess._start):
1292         - Clear self._child_processes.
1293         (ServerProcess.stop):
1294         - If self._child_processes is set, call
1295           self._port.check_for_leaks() for each child process.
1296
1297         * Scripts/webkitpy/port/server_process_unittest.py:
1298         (TrivialMockPort.check_for_leaks):
1299         - Rename redundant 'process_pid' argument to 'process_id'.
1300
1301         * Scripts/webkitpy/port/simulator_process.py:
1302         (SimulatorProcess.stop):
1303         - If self._child_processes is set, call
1304           self._port.check_for_leaks() for each child process.
1305
1306         * Scripts/webkitpy/port/watch_device.py:
1307         (WatchDevicePort.check_for_leaks):
1308         - Rename redundant 'process_pid' argument to 'process_id'.
1309
1310         * WebKitTestRunner/TestController.cpp:
1311         (WTR::TestController::dumpResponse):
1312         - Extract method from findAndDumpWorldLeaks() so that it may be
1313           reused by findAndDumpWebKitProcessIdentifiers().
1314         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1315         - Add method to output process name and process ID of both the
1316           WebContent and Networking processes.
1317         (WTR::TestController::findAndDumpWorldLeaks):
1318         - Fix missing newline in output when there were no abandoned
1319           documents.
1320         - Call dumpResponse() for extracted code.
1321         (WTR::TestController::handleControlCommand):
1322         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1323         - Use strncmp() instead of strcmp().
1324         - Call findAndDumpWebKitProcessIdentifiers() when
1325           "#LIST CHILD PROCESSES" command is sent.
1326         * WebKitTestRunner/TestController.h:
1327         (WTR::TestController::dumpResponse):
1328         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1329         - Declare methods.
1330
1331 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1332
1333         Unreviewed. Add GLib API test cases after r243434.
1334
1335         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1336         (testWebViewActiveURI):
1337         (serverCallback):
1338         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1339         (sendRequestCallback):
1340
1341 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         Geolocation request not complete when watch request was started in a different web process
1344         https://bugs.webkit.org/show_bug.cgi?id=195996
1345
1346         Reviewed by Alex Christensen.
1347
1348         Add a test case.
1349
1350         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1351         (TestWebKitAPI::runJavaScriptAlert):
1352         (TestWebKitAPI::TEST):
1353
1354 2019-03-26  Keith Rollin  <krollin@apple.com>
1355
1356         Update the way generate-xcfilelists returns strings from functions
1357         https://bugs.webkit.org/show_bug.cgi?id=195975
1358         <rdar://problem/49040807>
1359
1360         Reviewed by Dean Jackson.
1361
1362         There are places where generate-xcfilelists executes assignments with
1363         statements like:
1364
1365             FOO=$(some_function)
1366
1367         where "some_function" return a string by echoing it. E.g.
1368
1369             some_function()
1370             {
1371                 echo "Hello, World"
1372             }
1373
1374         This is a common idiom, but it has a problem if "some_function" needs
1375         to call "exit" in an attempt to halt the entire script right then and
1376         there. Since "some_function" is called inside of $(), it's being
1377         executed in a sub-shell. Calling exit in that sub-shell simply exits
1378         that shell; it doesn't not exit the outer shell in which the main part
1379         of the script is still running. As such, the main script keeps
1380         executing when the intent was for the script to halt.
1381
1382         The solution to this is to use a different idiom for returning
1383         strings. The one we now is to pass in the name of the variable to
1384         receive the string result:
1385
1386             some_function()
1387             {
1388                 variable_name=$1
1389                 eval $variable_name ="Hello, World"
1390             }
1391
1392         The call site now looks like
1393
1394             some_function FOO
1395
1396         Because there's no invocation of a sub-shell, some_function can now
1397         call "exit" if it wants to, and the entire script will exit at that
1398         point.
1399
1400         * Scripts/generate-xcfilelists:
1401
1402 2019-03-26  Chris Dumez  <cdumez@apple.com>
1403
1404         Add basic layout test coverage for File Picker on iOS
1405         https://bugs.webkit.org/show_bug.cgi?id=196265
1406
1407         Reviewed by Wenson Hsieh.
1408
1409         Add layout test infrastructure to test the file picker on iOS.
1410
1411         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1412         (WTR::UIScriptController::dismissFilePicker):
1413         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1414         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1415         (WTR::UIScriptController::dismissFilePicker):
1416         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1417         * WebKitTestRunner/TestController.cpp:
1418         (WTR::TestController::createWebViewWithOptions):
1419         (WTR::updateTestOptionsFromTestHeader):
1420         * WebKitTestRunner/TestOptions.h:
1421         (WTR::TestOptions::hasSameInitializationOptions const):
1422         * WebKitTestRunner/ios/TestControllerIOS.mm:
1423         (overridePresentViewController):
1424         (WTR::TestController::platformInitialize):
1425         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1426         (WTR::UIScriptController::dismissFilePicker):
1427
1428 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1429
1430         Implement async paste method on UIWKInteractionViewProtocol
1431         https://bugs.webkit.org/show_bug.cgi?id=196267
1432         <rdar://problem/49236346>
1433
1434         Reviewed by Tim Horton.
1435
1436         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1437         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1438         are now a part of all iOS 12 internal SDKs.
1439
1440         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1441
1442         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1443         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1444
1445         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1446         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1447         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1448         * TestWebKitAPI/ios/UIKitSPI.h:
1449
1450 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1451
1452         [ews-build] Use PostgreSQL for ews.webkit.org database
1453         https://bugs.webkit.org/show_bug.cgi?id=196270
1454
1455         Reviewed by Lucas Forschler.
1456
1457         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1458
1459 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1460
1461         [ews] Reset simctl states on reboot
1462         https://bugs.webkit.org/show_bug.cgi?id=196260
1463
1464         Rubber-stamped by Aakash Jain.
1465
1466         * EWSTools/start-queue-mac.sh:
1467
1468 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1469
1470         [ews-build] Use PostgreSQL for ews-build database
1471         https://bugs.webkit.org/show_bug.cgi?id=196229
1472
1473         Reviewed by Lucas Forschler.
1474
1475         * BuildSlaveSupport/ews-build/master.cfg:
1476
1477 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1478
1479         [ews-build] Get master_hostname dynamically in master.cfg
1480         https://bugs.webkit.org/show_bug.cgi?id=196255
1481
1482         Reviewed by Lucas Forschler.
1483
1484         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1485         send events data in test mode.
1486
1487 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1488
1489         [ews-app] Set db_constraint to False for Foreign Keys
1490         https://bugs.webkit.org/show_bug.cgi?id=196252
1491
1492         Reviewed by Lucas Forschler.
1493
1494         * BuildSlaveSupport/ews-app/ews/models/build.py:
1495         * BuildSlaveSupport/ews-app/ews/models/step.py:
1496
1497 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1498
1499         [ews-build] is_test_mode_enabled should default to True
1500         https://bugs.webkit.org/show_bug.cgi?id=196248
1501
1502         Reviewed by Lucas Forschler.
1503
1504         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1505
1506 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1507
1508         [ews-app] Add webkitperl to ENABLED_QUEUES
1509         https://bugs.webkit.org/show_bug.cgi?id=196253
1510
1511         Reviewed by Lucas Forschler.
1512
1513         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1514
1515 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1516
1517         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1518         https://bugs.webkit.org/show_bug.cgi?id=196211
1519         rdar://problem/49110552
1520
1521         Reviewed by Tim Horton.
1522
1523         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1524         Make sure that EventSenderProxy always exists when running tests. We used to create
1525         it when resetting before the first test, which is a bit too late.
1526
1527         * WebKitTestRunner/TestController.h:
1528         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1529         (WTR::TestController::platformCreateWebView):
1530         (WTR::TestController::platformCreateOtherPage):
1531         (WTR::TestController::finishCreatingPlatformWebView):
1532         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1533         (WTR::PlatformWebView::PlatformWebView):
1534         Moved some code that made NSWindow use NSEvent during web view creation. We may
1535         need to move more if some other case us found, but this is enough for now.
1536
1537 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1538
1539         Unreviewed. Fix typo in GLib geolocation API after r243285.
1540
1541         gelocation -> geolocation.
1542
1543         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1544         (testGeolocationManagerWatchPosition):
1545
1546 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1547
1548         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1549         https://bugs.webkit.org/show_bug.cgi?id=196213
1550
1551         Reviewed by Geoff Garen.
1552
1553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1554         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1555         (credentialWithIdentityAndKeychainPath):
1556         (-[ChallengeDelegate webView:didFinishNavigation:]):
1557         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1558         (TestWebKitAPI::TEST):
1559
1560 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1561
1562         Expected shouldn't assume its contained types are copyable
1563         https://bugs.webkit.org/show_bug.cgi?id=195986
1564
1565         Reviewed by JF Bastien.
1566
1567         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1568         (TestWebKitAPI::NonCopyable::operator== const):
1569         (TestWebKitAPI::NonCopyable::operator!= const):
1570         (TestWebKitAPI::TEST):
1571
1572 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1573
1574         Remove some now-unnecessary dynamic class lookup
1575         https://bugs.webkit.org/show_bug.cgi?id=196237
1576
1577         Reviewed by Simon Fraser.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1580         (makeRequest):
1581         (TEST):
1582
1583 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1584
1585         Unreviewed, rolling out r243450.
1586
1587         AppleWin and WinCairo port builds get broken.
1588
1589         Reverted changeset:
1590
1591         "Add test for fix of #196095"
1592         https://bugs.webkit.org/show_bug.cgi?id=196097
1593         https://trac.webkit.org/changeset/243450
1594
1595 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1596
1597         Unreviewed, rolling out r243465.
1598         https://bugs.webkit.org/show_bug.cgi?id=196226
1599
1600         the test doesn't build (Requested by thorton on #webkit).
1601
1602         Reverted changeset:
1603
1604         "Do not terminate the NetworkProcess if a third party
1605         application sends a NSCredential with a SecIdentityRef"
1606         https://bugs.webkit.org/show_bug.cgi?id=196213
1607         https://trac.webkit.org/changeset/243465
1608
1609 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1610
1611         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1612         https://bugs.webkit.org/show_bug.cgi?id=196213
1613
1614         Reviewed by Geoff Garen.
1615
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1618         (credentialWithIdentityAndKeychainPath):
1619         (-[ChallengeDelegate webView:didFinishNavigation:]):
1620         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1621         (TestWebKitAPI::TEST):
1622
1623 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1624
1625         [ews-build] Gracefully handle missing patch_id in events
1626         https://bugs.webkit.org/show_bug.cgi?id=196216
1627
1628         Reviewed by Lucas Forschler.
1629
1630         * BuildSlaveSupport/ews-build/events.py:
1631
1632 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-build] use lz4 compression for improving buildbot performance
1635         https://bugs.webkit.org/show_bug.cgi?id=196155
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-build/master.cfg:
1640
1641 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         Pull some API testing helper methods out of TestWKWebView
1644         https://bugs.webkit.org/show_bug.cgi?id=196212
1645
1646         Reviewed by Tim Horton.
1647
1648         Refactor some more API testing utility methods, so that they can be used in
1649         tests that do not use TestWKWebView.
1650
1651         * TestWebKitAPI/cocoa/TestWKWebView.h:
1652         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1653         (-[WKWebView loadTestPageNamed:]):
1654         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1655         (-[WKWebView synchronouslyLoadHTMLString:]):
1656         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1657         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1658         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1659         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1660         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1661
1662 2019-03-25  Jer Noble  <jer.noble@apple.com>
1663
1664         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1665         https://bugs.webkit.org/show_bug.cgi?id=196097
1666
1667         Reviewed by Eric Carlson.
1668
1669         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1670
1671         * DumpRenderTree/mac/DumpRenderTree.mm:
1672         (resetWebPreferencesToConsistentValues):
1673         * WebKitTestRunner/TestController.cpp:
1674         (WTR::TestController::resetPreferencesToConsistentValues):
1675
1676 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         Pull IPadUserInterfaceSwizzler out into a separate header file
1679         https://bugs.webkit.org/show_bug.cgi?id=196193
1680
1681         Reviewed by Anders Carlsson.
1682
1683         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1684         be used in other API tests.
1685
1686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1687         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1688         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1689         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1690         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1691         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1692         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1693
1694 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1695
1696         Remove NavigatorContentUtils in WebCore/Modules
1697         https://bugs.webkit.org/show_bug.cgi?id=196070
1698
1699         Reviewed by Alex Christensen.
1700
1701         NavigatorContentUtils was to support the custom scheme spec [1].
1702         However, in WebKit side, no port has supported the feature in
1703         WebKit layer after EFL port was removed. So there has been the
1704         only IDL implementation of the NavigatorContentUtils in WebCore.
1705         So we don't need to keep the implementation in WebCore anymore.
1706
1707         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1708
1709         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1710
1711 2019-03-24  Andy Estes  <aestes@apple.com>
1712
1713         [watchOS] Remove unused Proximity Networking code
1714         https://bugs.webkit.org/show_bug.cgi?id=196188
1715
1716         Reviewed by Tim Horton.
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1719         (TEST):
1720
1721 2019-03-23  Keith Miller  <keith_miller@apple.com>
1722
1723         Refactor clz/ctz and fix getLSBSet.
1724         https://bugs.webkit.org/show_bug.cgi?id=196162
1725
1726         Reviewed by Saam Barati.
1727
1728         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1729
1730         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1731         (TestWebKitAPI::TEST):
1732
1733 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1734
1735         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1736         https://bugs.webkit.org/show_bug.cgi?id=196143
1737
1738         Reviewed by Michael Catanzaro.
1739
1740         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1741         directories.
1742
1743         * Scripts/webkitpy/style/checkers/cpp.py:
1744         (check_identifier_name_in_declaration):
1745         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1746         (WebKitStyleTest.test_names):
1747
1748 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1749
1750         [Flatpak] Manifest expanding fails for qt WPE extension
1751         https://bugs.webkit.org/show_bug.cgi?id=196148
1752
1753         Reviewed by Alex Christensen.
1754
1755         * flatpak/flatpakutils.py:
1756         (expand_submodules_recurse): The last recurse manifest expand
1757         iteration might lead to a single module so take it into account
1758         and don't try to recurse further.
1759
1760 2019-03-22  Chris Dumez  <cdumez@apple.com>
1761
1762         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1763         https://bugs.webkit.org/show_bug.cgi?id=195348
1764         <rdar://problem/48622090>
1765
1766         Reviewed by Alex Christensen.
1767
1768         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1769         to NO when test.options().shouldIgnoreMetaViewport is false.
1770
1771         * WebKitTestRunner/ios/TestControllerIOS.mm:
1772         (WTR::TestController::platformConfigureViewForTest):
1773
1774 2019-03-22  Chris Dumez  <cdumez@apple.com>
1775
1776         Prewarmed processes should be usable with any website data store
1777         https://bugs.webkit.org/show_bug.cgi?id=196104
1778
1779         Reviewed by Alex Christensen.
1780
1781         Add API test coverage.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1784         (runInitialWarmedProcessUsedTest):
1785         (TEST):
1786
1787 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1788
1789         Back out local changes to Alex's Subversion working directory
1790
1791         They were accidentally committed.
1792
1793         * Scripts/webkitpy/common/system/abstractexecutive.py:
1794         (AbstractExecutive.wait_newest):
1795         * Scripts/webkitpy/common/system/executive.py:
1796         (Executive.running_pids):
1797         * Scripts/webkitpy/common/system/executive_mock.py:
1798         (MockExecutive.running_pids):
1799         * Scripts/webkitpy/common/system/executive_unittest.py:
1800         (ExecutiveTest.serial_test_running_pids):
1801         * Scripts/webkitpy/port/darwin.py:
1802         (DarwinPort.check_for_leaks):
1803         * Scripts/webkitpy/port/leakdetector.py:
1804         (LeakDetector.check_for_leaks):
1805         - This was the hack attached to Bug 193772.
1806
1807         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1808         (+[WebKitTestRunnerEvent mouseLocation]):
1809         - This works around a crash on an internal build.
1810
1811 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1812
1813         Fix the build after r243354
1814         https://bugs.webkit.org/show_bug.cgi?id=196138
1815         <rdar://problem/49145951>
1816
1817         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1818         (TEST):
1819         * TestWebKitAPI/ios/UIKitSPI.h:
1820
1821 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1822
1823         Adopt UIWKDocumentContext
1824         https://bugs.webkit.org/show_bug.cgi?id=196040
1825         <rdar://problem/48642440>
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1830         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1831         (makeRequest):
1832         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1833         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1834         (applyStyle):
1835         (TEST):
1836         Add tests for UIWKDocumentContext.
1837
1838         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1839         (TEST):
1840         (recursiveFindWKContentView): Deleted.
1841         * TestWebKitAPI/cocoa/TestWKWebView.h:
1842         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1843         (recursiveFindWKContentView):
1844         (-[TestWKWebView wkContentView]):
1845         * TestWebKitAPI/ios/UIKitSPI.h:
1846         Share the WKContentView finding code between tests.
1847
1848 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1849
1850         [iOS WK2] Turn on async overflow scrolling by default
1851         https://bugs.webkit.org/show_bug.cgi?id=196011
1852         rdar://problem/48453859
1853
1854         Reviewed by Antti Koivisto.
1855         
1856         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1857         since so many basic layout tests have different results when compositing is triggered for
1858         overflow.
1859         
1860         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1861
1862         * WebKitTestRunner/TestController.cpp:
1863         (WTR::TestController::resetPreferencesToConsistentValues):
1864
1865 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1866
1867         [ews-build] Retry API test in case of failures
1868         https://bugs.webkit.org/show_bug.cgi?id=196004
1869
1870         Reviewed by Lucas Forschler.
1871
1872         * BuildSlaveSupport/ews-build/steps.py:
1873         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1874         (CompileWebKitToT.doStepIf): Ditto.
1875         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1876         (ReRunAPITests): Re-run API tests.
1877         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1878         (RunAPITestsWithoutPatch): Run API tests without patch.
1879         (RunAPITestsWithoutPatch.doStepIf):
1880         (RunAPITestsWithoutPatch.hideStepIf):
1881         (RunAPITestsWithoutPatch.evaluateCommand):
1882         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1883         (AnalyzeAPITestsResults.start):
1884         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1885         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1886         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1887         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1888
1889 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1890
1891         [ews-build] Update queues configurations
1892         https://bugs.webkit.org/show_bug.cgi?id=196074
1893
1894         Reviewed by Dewei Zhu.
1895
1896         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1897         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1898
1899 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1900
1901         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1902         https://bugs.webkit.org/show_bug.cgi?id=195680
1903         <rdar://problem/48903534>
1904
1905         Unreviewed infrastructure fix.
1906
1907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1908         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1909
1910 2019-03-21  Andy Estes  <aestes@apple.com>
1911
1912         [iOS] Apple Pay should be available in documents with no user agent scripts
1913         https://bugs.webkit.org/show_bug.cgi?id=196061
1914         <rdar://problem/48649391>
1915
1916         Reviewed by Brady Eidson.
1917
1918         Added API tests and related infrastructure.
1919
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1922         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1923         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1924         (TestWebKitAPI::TEST):
1925         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1926         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1927         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1928         * TestWebKitAPI/cocoa/TestProtocol.mm:
1929         (-[TestProtocol startLoading]):
1930         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1931         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1932         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1933         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1934
1935 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1936
1937         REGRESSSION (r243297): webkitpy tests broken
1938         https://bugs.webkit.org/show_bug.cgi?id=196108
1939
1940         Reviewed by Aakash Jain.
1941
1942         r243297 updated contributors.json, which broke a few unit tests.
1943
1944         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1945         (IRCCommandTest.test_whois):
1946         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1947
1948 2019-03-21  Chris Dumez  <cdumez@apple.com>
1949
1950         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1951         https://bugs.webkit.org/show_bug.cgi?id=196041
1952         <rdar://problem/49083230>
1953
1954         Reviewed by Alex Christensen.
1955
1956         Add API test coverage.
1957
1958         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1959         (TEST):
1960
1961 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1962
1963         Add SPI to inform applications of WKContentRuleList actions
1964         https://bugs.webkit.org/show_bug.cgi?id=195965
1965         <rdar://problem/42664365>
1966
1967         Reviewed by Geoff Garen.
1968
1969         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1970         (TestWebKitAPI::allActionsForResourceLoad):
1971         (TestWebKitAPI::testRequest):
1972         (TestWebKitAPI::TEST_F):
1973         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1974         (Notification::description):
1975         (Notification::operator== const):
1976         (toVector):
1977         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1978         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1979         (makeContentRuleList):
1980         (TEST):
1981         (makeWarnContentRuleList): Deleted.
1982
1983 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1984
1985         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1986         https://bugs.webkit.org/show_bug.cgi?id=196088
1987
1988         Reviewed by Brian Burg.
1989
1990         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1991         Support checks when only one platform is specified. Also deprecate macosx() and
1992         force the use of macos() instead.
1993
1994         * Scripts/webkitpy/style/checkers/cpp.py:
1995         (check_min_versions_of_wk_api_available):
1996         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1997         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1998
1999 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2000
2001         Update status inactive committers' status to 'contributor'.
2002
2003         * Scripts/webkitpy/common/config/contributors.json:
2004
2005 2019-03-21  Xan Lopez  <xan@igalia.com>
2006
2007         [JSC][x86] Drop support for x87 floating point
2008         https://bugs.webkit.org/show_bug.cgi?id=194853
2009
2010         Reviewed by Don Olmstead.
2011
2012         Force SSE2 on x86/32bit builds.
2013
2014         * Scripts/webkitdirs.pm:
2015         (generateBuildSystemFromCMakeProject):
2016
2017 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2020         https://bugs.webkit.org/show_bug.cgi?id=196073
2021
2022         Reviewed by Michael Catanzaro.
2023
2024         Add test cases to check functions and constructors with no arguments but receiving user data.
2025
2026         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2027         (checkUserData):
2028         (testJSCFunction):
2029         (fooCreateWithUserData):
2030         (testJSCClass):
2031
2032 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2033
2034         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2035
2036         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2037
2038         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2039
2040 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2041
2042         [GTK][WPE] Add API to provide geolocation information
2043         https://bugs.webkit.org/show_bug.cgi?id=195940
2044
2045         Reviewed by Michael Catanzaro.
2046
2047         Add a new test to check the new API.
2048
2049         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2050         (testGeolocationManagerCurrentPosition):
2051         (testGeolocationManagerWatchPosition):
2052         (beforeAll):
2053         (afterAll):
2054         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2055         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2056         (beforeAll): Ditto.
2057         * TestWebKitAPI/glib/CMakeLists.txt:
2058
2059 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2060
2061         [GLib] Returning G_TYPE_OBJECT from a method does not work
2062         https://bugs.webkit.org/show_bug.cgi?id=195574
2063
2064         Reviewed by Michael Catanzaro.
2065
2066         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2067
2068         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2069         (getGFile):
2070         (getParent):
2071         (createGString):
2072         (getGString):
2073         (getGStringCopyWillRaise):
2074         (getGStringCopy):
2075         (getGStringStr):
2076         (getGStringLen):
2077         (freeGString):
2078         (testJSCClass):
2079
2080 2019-03-20  Saam Barati  <sbarati@apple.com>
2081
2082         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2083         https://bugs.webkit.org/show_bug.cgi?id=195721
2084
2085         Reviewed by Filip Pizlo.
2086
2087         * Scripts/run-javascriptcore-tests:
2088
2089 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2090
2091         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2092         https://bugs.webkit.org/show_bug.cgi?id=196049
2093
2094         Reviewed by Tim Horton.
2095
2096         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2097         overflow scrolling in general, so rename it.
2098
2099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2100
2101 2019-03-20  Daniel Bates  <dabates@apple.com>
2102
2103         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2104         https://bugs.webkit.org/show_bug.cgi?id=196031
2105         <rdar://problem/49078172>
2106
2107         Reviewed by Tim Horton.
2108
2109         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2110         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2111         same code path used when the Done button is pressed to dismiss the <select> picker.
2112
2113         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2114         (TestWebKitAPI::TEST):
2115
2116 2019-03-20  Chris Dumez  <cdumez@apple.com>
2117
2118         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2119         https://bugs.webkit.org/show_bug.cgi?id=196029
2120         <rdar://problem/48954651>
2121
2122         Reviewed by Tim Horton.
2123
2124         Add API test coverage.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2127
2128 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-build] Improve failure summary string for ApplyPatch step
2131         https://bugs.webkit.org/show_bug.cgi?id=195995
2132
2133         Reviewed by Alexey Proskuryakov.
2134
2135         * BuildSlaveSupport/ews-build/steps.py:
2136         (ApplyPatch.getResultSummary): Override getResultSummary.
2137
2138 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2139
2140         AX: Implement support for new meter ARIA role
2141         https://bugs.webkit.org/show_bug.cgi?id=195966
2142
2143         Reviewed by Chris Fleizach.
2144
2145         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2146         to AXLevelIndicator.
2147
2148         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2149
2150 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2151
2152         [WebAuthN] Implement FIDO AppID extension
2153         https://bugs.webkit.org/show_bug.cgi?id=143491
2154         <rdar://problem/48298273>
2155
2156         Reviewed by Brent Fulgham.
2157
2158         Add a test that covers the new flag of convertToU2fSignCommand.
2159
2160         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2163         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2164         (TestWebKitAPI::TEST):
2165
2166 2019-03-19  Keith Rollin  <krollin@apple.com>
2167
2168         Add support for more platforms to generate-xcfilelists
2169         https://bugs.webkit.org/show_bug.cgi?id=195977
2170
2171         Reviewed by Alexey Proskuryakov.
2172
2173         generate-xcfilelists incorrectly complains when involved with building
2174         WebKit for iphonesimulator:
2175
2176             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2177             …
2178             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2179
2180         Address this by teaching generate-xcfilelists about more platforms.
2181
2182         * Scripts/generate-xcfilelists:
2183
2184 2019-03-19  John Wilander  <wilander@apple.com>
2185
2186         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2187         https://bugs.webkit.org/show_bug.cgi?id=195923
2188         <rdar://problem/49001272>
2189
2190         Reviewed by Alex Christensen.
2191
2192         This patch does the following to the TestRunner:
2193         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2194         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2195         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2196
2197         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2199         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2201         * WebKitTestRunner/TestController.cpp:
2202         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2203         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2204         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2205         * WebKitTestRunner/TestController.h:
2206         * WebKitTestRunner/TestInvocation.cpp:
2207         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2208
2209 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2210
2211         [CMake] Support more clang and gcc sanitizers
2212         https://bugs.webkit.org/show_bug.cgi?id=195956
2213
2214         Reviewed by Michael Catanzaro.
2215
2216         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2217
2218 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2219
2220         [ews-build] Improve summary for PrintConfiguration step
2221         https://bugs.webkit.org/show_bug.cgi?id=195945
2222
2223         Reviewed by Lucas Forschler.
2224
2225         * BuildSlaveSupport/ews-build/steps.py:
2226         (PrintConfiguration.getResultSummary): Override getResultSummary.
2227
2228 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2229
2230         [ews-build] Improve summary for CheckOutSource step
2231         https://bugs.webkit.org/show_bug.cgi?id=195963
2232
2233         Reviewed by Lucas Forschler.
2234
2235         * BuildSlaveSupport/ews-build/steps.py:
2236         (CheckOutSource.getResultSummary):
2237
2238 2019-03-19  Daniel Bates  <dabates@apple.com>
2239
2240         [iOS] Focus not preserved when switching between tabs
2241         https://bugs.webkit.org/show_bug.cgi?id=195820
2242         <rdar://problem/43614450>
2243
2244         Reviewed by Brent Fulgham.
2245
2246         Add tests to ensure that we restore focus when resigning and becoming first responder.
2247
2248         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2249         (TestWebKitAPI::TEST):
2250
2251 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2252
2253         Make WTFLogChannelState and WTFLogLevel enum classes
2254         https://bugs.webkit.org/show_bug.cgi?id=195904
2255
2256         Reviewed by Eric Carlson.
2257
2258         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2259         (TestWebKitAPI::TEST_F):
2260
2261 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2262
2263         [GStreamer][EME] Backported mssdemux protection data crash fix
2264         https://bugs.webkit.org/show_bug.cgi?id=195918
2265
2266         Reviewed by Philippe Normand.
2267
2268         * gstreamer/jhbuild.modules:
2269         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2270
2271 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2272
2273         Unreviewed, rolling out r243132.
2274
2275         Broke GTK build
2276
2277         Reverted changeset:
2278
2279         "Make WTFLogChannelState and WTFLogLevel enum classes"
2280         https://bugs.webkit.org/show_bug.cgi?id=195904
2281         https://trac.webkit.org/changeset/243132
2282
2283 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2284
2285         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2286
2287         * Scripts/webkitdirs.pm:
2288         (builtDylibPathForName): Adjust the shared library name that's changed
2289         with the API version bump in r243073.
2290
2291 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2292
2293         Make WTFLogChannelState and WTFLogLevel enum classes
2294         https://bugs.webkit.org/show_bug.cgi?id=195904
2295
2296         Reviewed by Eric Carlson.
2297
2298         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2299         (TestWebKitAPI::TEST_F):
2300
2301 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2302
2303         Disable flaky test added in r2431100
2304         https://webkit.org/b/195785
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2307         (TestWebKitAPI::TEST):
2308         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2309
2310 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2311
2312         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2313         https://bugs.webkit.org/show_bug.cgi?id=195916
2314
2315         Reviewed by Tim Horton.
2316
2317         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2318         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2319
2320 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2321
2322         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2323
2324         * Scripts/webkitpy/common/config/contributors.json:
2325
2326 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2327
2328         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2329         https://bugs.webkit.org/show_bug.cgi?id=195785
2330
2331         Reviewed by Geoffrey Garen.
2332
2333         * TestWebKitAPI/TCPServer.cpp: Added.
2334         (TestWebKitAPI::TCPServer::TCPServer):
2335         (TestWebKitAPI::TCPServer::~TCPServer):
2336         (TestWebKitAPI::TCPServer::socketBindListen):
2337         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2338         * TestWebKitAPI/TCPServer.h: Added.
2339         (TestWebKitAPI::TCPServer::port const):
2340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2341         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2342         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2343         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2344         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2345         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2346         (TestWebKitAPI::respondSlowly):
2347         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2348         (TestWebKitAPI::downloadAtRate):
2349         (TestWebKitAPI::TEST):
2350
2351 2019-03-18  Saam Barati  <sbarati@apple.com>
2352
2353         Add a plan file for JetStream 2
2354         https://bugs.webkit.org/show_bug.cgi?id=190734
2355
2356         Reviewed by Mark Lam.
2357
2358         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2359
2360 2019-03-18  Chris Dumez  <cdumez@apple.com>
2361
2362         Delay WebProcess launch until a load is triggered in a Web view
2363         https://bugs.webkit.org/show_bug.cgi?id=195758
2364         <rdar://problem/48126013>
2365
2366         Reviewed by Geoff Garen.
2367
2368         Add API test coverage. Also update some existing API tests to not expect
2369         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2370
2371         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2372         (TestWebKitAPI::TEST):
2373         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2374         (TestWebKitAPI::TEST):
2375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2376         (TEST):
2377         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2378         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2379         (TEST):
2380         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2381         (TEST):
2382         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2383
2384 2019-03-18  Xan Lopez  <xan@igalia.com>
2385
2386         [CMake] Prevent potential warning when determining $architecture
2387         https://bugs.webkit.org/show_bug.cgi?id=195891
2388
2389         Reviewed by Michael Catanzaro.
2390
2391         It's possible for generateBuildSystemForCMakeProject to be called
2392         before determineArchitecture() is ever called. This will make the
2393         first eq check with $architecture to be bogus (and print a
2394         warning). Change that to an eq check with architecture(), which
2395         implicitly calls determineArchitecture() if needed, and change all
2396         the other similar cases in the method in the same way to prevent
2397         future bugs like this one.
2398
2399         * Scripts/webkitdirs.pm:
2400         (generateBuildSystemFromCMakeProject):
2401
2402 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2403
2404         [WPE] Tarballs generated with “make dist” cannot build documentation
2405         https://bugs.webkit.org/show_bug.cgi?id=195885
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2410
2411 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2412
2413         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2414         https://bugs.webkit.org/show_bug.cgi?id=195883
2415
2416         Reviewed by Carlos Garcia Campos.
2417
2418         * gtkdoc/gtkdoc.py:
2419         (GTKDoc._run_command): When commands fail to run, include the full command line for
2420         the program invocation and the output it has generated on the standard error stream.
2421
2422 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2423
2424         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2425         https://bugs.webkit.org/show_bug.cgi?id=195786
2426
2427         Reviewed by Philippe Normand.
2428
2429         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2430         * wpe/jhbuild.modules: Ditto.
2431
2432 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2433
2434         [ews-build] Don't run clean builds on EWS builders
2435         https://bugs.webkit.org/show_bug.cgi?id=195851
2436
2437         Reviewed by Geoffrey Garen.
2438
2439         * BuildSlaveSupport/ews-build/factories.py:
2440
2441 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2442
2443         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2444         https://bugs.webkit.org/show_bug.cgi?id=195849
2445
2446         Reviewed by Chris Dumez.
2447
2448         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2451         (runWebsiteDataStoreCustomPaths):
2452
2453 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2454
2455         webkitpy: Upload test results
2456         https://bugs.webkit.org/show_bug.cgi?id=195755
2457         <rdar://problem/48896182>
2458
2459         Reviewed by Aakash Jain.
2460
2461         Establish a new format for uploading results that is not tied to layout tests, apply
2462         that format to webkitpy tests.
2463
2464         * Scripts/webkitpy/common/checkout/scm/git.py:
2465         (Git.native_branch): Return what branch the current checkout is on.
2466         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2467         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2468         * Scripts/webkitpy/common/checkout/scm/svn.py:
2469         (SVN.native_branch): Ditto.
2470         * Scripts/webkitpy/common/system/platforminfo.py:
2471         (PlatformInfo.build_version): Return a build version for Mac.
2472         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2473         (MockPlatformInfo.__init__):
2474         (MockPlatformInfo.build_version):
2475         * Scripts/webkitpy/results: Added.
2476         * Scripts/webkitpy/results/__init__.py: Added.
2477         * Scripts/webkitpy/results/options.py: Added.
2478         (upload_options): OptParse list for upload options.
2479         * Scripts/webkitpy/results/upload.py: Added.
2480         (Upload): Class which enforces the upload format expected by the results server.
2481         (Upload.Expectations):
2482         (Upload.create_configuration):
2483         (Upload.create_commit):
2484         (Upload.create_details):
2485         (Upload.create_run_stats):
2486         (Upload.create_test_result):
2487         (Upload.__init__):
2488         (Upload.Encoder): Encode Upload object as json.
2489         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2490         * Scripts/webkitpy/results/upload_unittest.py: Added.
2491         * Scripts/webkitpy/test/main.py:
2492         (Tester._parse_args): Add upload arguments.
2493         (Tester._run_tests): Allow results to be uploaded.
2494         * Scripts/webkitpy/test/runner.py:
2495         (Runner.__init__): Record which tests were run, rather than just counting them.
2496         (Runner.handle):
2497         * Scripts/webkitpy/test/runner_unittest.py:
2498         (RunnerTest.test_run):
2499         * Scripts/webkitpy/thirdparty/__init__.py:
2500         (AutoinstallImportHook.find_module): Add requests auto-install.
2501         (AutoinstallImportHook._install_requests):
2502         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2503         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2504
2505 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2506
2507         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2508         https://bugs.webkit.org/show_bug.cgi?id=195810
2509
2510         Reviewed by Tim Horton.
2511
2512         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2513         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2514         ending certain layout tests.
2515
2516         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2517         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2518         (-[TestRunnerWKWebView dealloc]):
2519         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2520
2521         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2522         helper method when destroying the web view, and when resetting state between tests.
2523
2524         * WebKitTestRunner/ios/TestControllerIOS.mm:
2525         (WTR::TestController::platformResetStateToConsistentValues):
2526
2527         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2528
2529 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2530
2531         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2532         https://bugs.webkit.org/show_bug.cgi?id=190350
2533         <rdar://problem/45089503>
2534
2535         Reviewed by Geoffrey Garen.
2536
2537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2538         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2539         (TEST):
2540         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2541         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2542         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2543         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2544         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2545         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2546         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2547         (runTest):
2548         (createDirectories):
2549         (TEST):
2550         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2551         (TEST):
2552         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2553         (TEST):
2554
2555 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2556
2557         Add support to WebPage for getting the contents as an attributed string.
2558         https://bugs.webkit.org/show_bug.cgi?id=195636
2559         rdar://problem/45055697
2560
2561         Reviewed by Tim Horton.
2562
2563         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2564         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2565
2566 2019-03-15  Chris Dumez  <cdumez@apple.com>
2567
2568         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2569         https://bugs.webkit.org/show_bug.cgi?id=195747
2570
2571         Reviewed by Geoff Garen.
2572
2573         Add API test coverage.
2574
2575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2576
2577 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2578
2579         Unreviewed, rolling out r242952.
2580
2581         Causing API failures on iOS Simulator
2582
2583         Reverted changeset:
2584
2585         "[PSON] Make sure the WebProcessCache is leverage when
2586         relaunching a process after termination"
2587         https://bugs.webkit.org/show_bug.cgi?id=195747
2588         https://trac.webkit.org/changeset/242952
2589
2590 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2591
2592         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2593         https://bugs.webkit.org/show_bug.cgi?id=195740
2594
2595         Reviewed by Ross Kirsling.
2596
2597         window.open doesn't work for WebKitBrowserWindow because it is not
2598         implemented yet.
2599
2600         1. Implemented createNewPage callback of WKPageUIClient.
2601         2. Changed MainWindow to take a BrowserWindow factory function
2602           instead of BrowserWindowType to be flexible to create
2603           BrowserWindow with extra settings.
2604         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2605           because it is not relevant with MainWindow anymore.
2606
2607         * MiniBrowser/win/Common.cpp:
2608         (parseCommandLine):
2609         * MiniBrowser/win/Common.h:
2610         (CommandLineOptions::CommandLineOptions):
2611         * MiniBrowser/win/MainWindow.cpp:
2612         (MainWindow::MainWindow):
2613         (MainWindow::create):
2614         (MainWindow::init):
2615         (MainWindow::WndProc):
2616         * MiniBrowser/win/MainWindow.h:
2617         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2618         (PrintWebUIDelegate::createWebViewWithRequest):
2619         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2620         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2621         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2622         (WebKitBrowserWindow::updateProxySettings):
2623         (WebKitBrowserWindow::createNewPage):
2624         * MiniBrowser/win/WebKitBrowserWindow.h:
2625         * MiniBrowser/win/WinMain.cpp:
2626         (wWinMain):
2627
2628 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2629
2630         Make it possible to test scrolling tree layer manipulation more easily
2631         https://bugs.webkit.org/show_bug.cgi?id=195780
2632
2633         Reviewed by Tim Horton.
2634         
2635         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2636         cuts off communication of scrolling tree scrolls back to the web process
2637         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2638         allows tests to trigger scrolls which run the scrolling tree layer positioning
2639         logic, but never get another commit from the web process that might mask
2640         scrolling tree bugs.
2641         
2642         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2643         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2644         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2645
2646         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2647         (WTR::UIScriptController::scrollUpdatesDisabled const):
2648         (WTR::UIScriptController::setScrollUpdatesDisabled):
2649         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2650         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2651         (WTR::UIScriptController::scrollUpdatesDisabled const):
2652         (WTR::UIScriptController::setScrollUpdatesDisabled):
2653         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2654         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2655         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2656         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2657         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2658         * WebKitTestRunner/ios/TestControllerIOS.mm:
2659         (WTR::TestController::platformResetStateToConsistentValues):
2660         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2661         (WTR::UIScriptController::scrollUpdatesDisabled const):
2662         (WTR::UIScriptController::setScrollUpdatesDisabled):
2663
2664 2019-03-14  Youenn Fablet  <youenn@apple.com>
2665
2666         Move IDB storage in private browsing mode to NetworkProcess
2667         https://bugs.webkit.org/show_bug.cgi?id=195602
2668
2669         Reviewed by Brady Eidson.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2672         (TEST):
2673
2674 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-build] Make descriptionDone messages more readable
2677         https://bugs.webkit.org/show_bug.cgi?id=195760
2678
2679         Reviewed by Lucas Forschler.
2680
2681         * BuildSlaveSupport/ews-build/steps.py:
2682         * BuildSlaveSupport/ews-build/steps_unittest.py:
2683
2684 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2685
2686         [ews-build] Generate status-bubble hover-over messages
2687         https://bugs.webkit.org/show_bug.cgi?id=195680
2688
2689         Reviewed by Lucas Forschler.
2690
2691         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2692         (StatusBubble):
2693         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2694         on hover-over.
2695         (StatusBubble._iso_time):
2696         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2697         hover-over message.
2698         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2699
2700 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2701
2702         [ews-app] Gracefully handle the case when state_string is None
2703         https://bugs.webkit.org/show_bug.cgi?id=195753
2704
2705         Reviewed by Lucas Forschler.
2706
2707         * BuildSlaveSupport/ews-app/ews/models/build.py:
2708         * BuildSlaveSupport/ews-app/ews/models/step.py:
2709
2710 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2711
2712         [ews-app] Status bubble display pending for currently running build step
2713         https://bugs.webkit.org/show_bug.cgi?id=195744
2714
2715         Reviewed by Lucas Forschler.
2716
2717         * BuildSlaveSupport/ews-build/events.py:
2718         (Events.stepStarted): If state_string is pending, replace it with step name.
2719
2720 2019-03-14  Chris Dumez  <cdumez@apple.com>
2721
2722         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2723         https://bugs.webkit.org/show_bug.cgi?id=195750
2724
2725         Reviewed by Geoffrey Garen.
2726
2727         Add API test coverage.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2730         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2731         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2732         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2733
2734 2019-03-14  Chris Dumez  <cdumez@apple.com>
2735
2736         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2737         https://bugs.webkit.org/show_bug.cgi?id=195747
2738
2739         Reviewed by Geoff Garen.
2740
2741         Add API test coverage.
2742
2743         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2744
2745 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2746
2747         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2748         https://bugs.webkit.org/show_bug.cgi?id=195725
2749         <rdar://problem/48545062>
2750
2751         Reviewed by Tim Horton.
2752
2753         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2754         handler is nil.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2757         (TestWebKitAPI::TEST):
2758
2759 2019-03-13  Sam Weinig  <sam@webkit.org>
2760
2761         Add utility function to allow easy reverse range-based iteration of a container
2762         https://bugs.webkit.org/show_bug.cgi?id=195542
2763
2764         Reviewed by Antti Koivisto.
2765
2766         * TestWebKitAPI/CMakeLists.txt:
2767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2768         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2769         (TestWebKitAPI::TEST):
2770         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2771
2772 2019-03-13  Chris Dumez  <cdumez@apple.com>
2773
2774         Use a ServiceWorker process per registrable domain
2775         https://bugs.webkit.org/show_bug.cgi?id=195649
2776
2777         Reviewed by Youenn Fablet.
2778
2779         Update API test coverage.
2780
2781         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2782
2783 2019-03-13  Chris Dumez  <cdumez@apple.com>
2784
2785         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2786         https://bugs.webkit.org/show_bug.cgi?id=195684
2787         <rdar://problem/48294714>
2788
2789         Reviewed by Antti Koivisto.
2790
2791         Add API test coverage.
2792
2793         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2794
2795 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2796
2797         [ews-app] Remove unused patch view
2798         https://bugs.webkit.org/show_bug.cgi?id=195669
2799
2800         Reviewed by Lucas Forschler.
2801
2802         * BuildSlaveSupport/ews-app/ews/urls.py:
2803         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2804
2805 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-app] Use Buildbot result code variables
2808         https://bugs.webkit.org/show_bug.cgi?id=195668
2809
2810         Reviewed by Alexey Proskuryakov.
2811
2812         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2813         (Buildbot): Added Buildbot result code variables.
2814         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2815         (StatusBubble._build_bubble): Used Buildbot result code variables.
2816
2817 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2818
2819         [Flatpak] Expand submodule recursively
2820         https://bugs.webkit.org/show_bug.cgi?id=195672
2821
2822         Building WPE with flatpak was impossible without that as it was raising an exception.
2823         Also update wpebackend-fdo to match what is built in jhbuild
2824
2825         Reviewed by Philippe Normand.
2826
2827         * flatpak/flatpakutils.py:
2828         (expand_submodules_recurse):
2829         (expand_manifest):
2830         * flatpak/org.webkit.WPEModules.yaml:
2831
2832 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2833
2834         [ews-app] status bubble should be hidden for certain builds
2835         https://bugs.webkit.org/show_bug.cgi?id=194597
2836
2837         Reviewed by Dewei Zhu.
2838
2839         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2840         (StatusBubble._build_bubble):
2841         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2842         because the patch didn't have relevant changes.
2843         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2844         in production yet.
2845
2846 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2847
2848         [Win] Fix a slew of simple clang-cl warnings.
2849         https://bugs.webkit.org/show_bug.cgi?id=195652
2850
2851         Reviewed by Don Olmstead.
2852
2853         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2854         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2855
2856 2019-03-12  Justin Fan  <justin_fan@apple.com>
2857
2858         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2859         https://bugs.webkit.org/show_bug.cgi?id=195518
2860         <rdar://problem/46322356>
2861
2862         Reviewed by Myles C. Maxfield.
2863
2864         * DumpRenderTree/DerivedSources-input.xcfilelist:
2865         * DumpRenderTree/DerivedSources-output.xcfilelist:
2866
2867 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2868
2869         Unreviewed, rolling out r242825.
2870         https://bugs.webkit.org/show_bug.cgi?id=195648
2871
2872         "Broke webkitpy tests with my change to
2873         lldb_dump_class_layout.py" (Requested by rmorisset on
2874         #webkit).
2875
2876         Reverted changeset:
2877
2878         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2879         classes with suspicious padding"
2880         https://bugs.webkit.org/show_bug.cgi?id=195573
2881         https://trac.webkit.org/changeset/242825
2882
2883 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2884
2885         [ews-build] Show status bubbles while the patch is waiting in queue
2886         https://bugs.webkit.org/show_bug.cgi?id=195618
2887
2888         Reviewed by Lucas Forschler.
2889
2890         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2891         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2892         enabled in initial deployment.
2893         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2894         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2895         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2896         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2897         (StatusBubble._build_bubbles_for_patch):
2898
2899 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2900
2901         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2902         https://bugs.webkit.org/show_bug.cgi?id=195573
2903
2904         Reviewed by Simon Fraser.
2905
2906         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2907
2908         * Scripts/dump-class-layout:
2909         (main):
2910         * lldb/lldb_dump_class_layout.py:
2911         (ClassLayout.__init__):
2912         (ClassLayout._compute_padding_recursive):
2913         (LLDBDebuggerInstance.dump_layout_for_classname):
2914         (LLDBDebuggerInstance):
2915         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2916         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2917
2918 2019-03-12  Chris Dumez  <cdumez@apple.com>
2919
2920         Device Orientation access permission should be denied unless explicitly granted by the client
2921         https://bugs.webkit.org/show_bug.cgi?id=195625
2922
2923         Reviewed by Youenn Fablet.
2924
2925         add API test coverage.
2926
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2929         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2930         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2931         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2932         (runDeviceOrientationTest):
2933         (TEST):
2934         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2935         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2936
2937 2019-03-12  Jer Noble  <jer.noble@apple.com>
2938
2939         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2940         https://bugs.webkit.org/show_bug.cgi?id=195137
2941         <rdar://problem/48810307>
2942
2943         Reviewed by Eric Carlson.
2944
2945         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2946         (TestWebKitAPI::TEST):
2947
2948 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2949
2950         [ews-build] Change urls from uat to production
2951         https://bugs.webkit.org/show_bug.cgi?id=195566
2952
2953         Reviewed by Lucas Forschler.
2954
2955         * BuildSlaveSupport/ews-app/ews/config.py:
2956         * BuildSlaveSupport/ews-build/events.py:
2957         * BuildSlaveSupport/ews-build/steps.py:
2958
2959 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2960
2961         [ews-build] change max_builds for local-worker to 1
2962         https://bugs.webkit.org/show_bug.cgi?id=195568
2963
2964         Reviewed by Lucas Forschler.
2965
2966         * BuildSlaveSupport/ews-build/loadConfig.py:
2967
2968 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2969
2970         Fix the build
2971
2972         * TestRunnerShared/spi/PencilKitTestSPI.h:
2973         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2974
2975 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2976
2977         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2978         https://bugs.webkit.org/show_bug.cgi?id=194131
2979
2980         Reviewed by Michael Catanzaro.
2981
2982         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2983         (uriChanged):
2984         (testUnfinishedSubresourceLoad):
2985         (serverCallback):
2986         (beforeAll):
2987
2988 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2989
2990         WTF::Expected should use std::addressof instead of operator&
2991         https://bugs.webkit.org/show_bug.cgi?id=195604
2992
2993         Reviewed by Myles Maxfield.
2994
2995         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2996         (TestWebKitAPI::Unique::Unique):
2997         (TestWebKitAPI::Unique::operator&):
2998         (TestWebKitAPI::TEST):
2999
3000 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3001
3002         Add Optional to Forward.h.
3003         https://bugs.webkit.org/show_bug.cgi?id=195586
3004
3005         Reviewed by Darin Adler.
3006
3007         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3008         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3009         Remove unnecessary includes from headers.
3010
3011 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3012
3013         Add testing API to hit-test and scroll overflow scrollers
3014         https://bugs.webkit.org/show_bug.cgi?id=195278
3015
3016         Reviewed by Antti Koivisto.
3017         
3018         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3019         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3020         
3021         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3022
3023         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3024         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3025         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3026         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3027         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3028         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3029         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3030         (WTR::enclosingScrollViewIncludingSelf):
3031         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3032
3033 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3034
3035         API test WebKit.RequestTextInputContext fails on iOS
3036         https://bugs.webkit.org/show_bug.cgi?id=195585
3037
3038         Reviewed by Wenson Hsieh and Simon Fraser.
3039
3040         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3041         (applyStyle):
3042         (TEST):
3043         Add a viewport, so that the coordinates match up on iOS.
3044         Scroll by moving the UIScrollView's contentOffset.
3045
3046 2019-03-11  Chris Dumez  <cdumez@apple.com>
3047
3048         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3049         https://bugs.webkit.org/show_bug.cgi?id=195506
3050         <rdar://problem/48733477>
3051
3052         Reviewed by Alex Christensen.
3053
3054         Add API test coverage.
3055
3056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3057
3058 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3059
3060         Adding myself to contributors.json
3061
3062         Unreviewed, addming myself to contributors.json .
3063
3064         * Scripts/webkitpy/common/config/contributors.json:
3065
3066 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3067
3068         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3069         https://bugs.webkit.org/show_bug.cgi?id=195511
3070         <rdar://problem/44873269>
3071
3072         Reviewed by Darin Adler.
3073
3074         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3075         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3076         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3077         (TEST_F):
3078
3079 2019-03-11  Chris Dumez  <cdumez@apple.com>
3080
3081         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3082         https://bugs.webkit.org/show_bug.cgi?id=195561
3083
3084         Reviewed by Youenn Fablet.
3085
3086         Make sure the JS in the test requests for permission to receive device orientation events.
3087
3088         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3089
3090 2019-03-11  Youenn Fablet  <youenn@apple.com>
3091
3092         Allow storage quota increase by default in WTR
3093         https://bugs.webkit.org/show_bug.cgi?id=195541
3094
3095         Reviewed by Geoffrey Garen.
3096
3097         Allow storage quota increase by default in WTR.
3098         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3099         Use this for tests that explicitly need cache increase.
3100
3101         Instead of increasing quota by 2, make sure the next request is
3102         granted by adding all given parameters.
3103
3104         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3105         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3106         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3107         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3109         * WebKitTestRunner/TestController.cpp:
3110         (WTR::TestController::setAllowStorageQuotaIncrease):
3111         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3112         * WebKitTestRunner/TestController.h:
3113         * WebKitTestRunner/TestInvocation.cpp:
3114         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3115         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3116         (WTR::TestController::cocoaResetStateToConsistentValues):
3117         (WTR::TestController::setAllowStorageQuotaIncrease):
3118         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3119         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3120         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3121
3122 2019-03-11  Xan Lopez  <xan@igalia.com>
3123
3124         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3125         https://bugs.webkit.org/show_bug.cgi?id=194147
3126
3127         Reviewed by Michael Saboff.
3128
3129         To make --32-bit work correctly on Linux/64bit we need to:
3130
3131         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3132         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3133         unfortunately CMake only allows us to do this during
3134         crosscompilation, which is overkill here.
3135         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3136         pkg-config detection module uses the x86 .pc files instead of the
3137         x86_64 ones.
3138         - Set the -m32 flags for the compiler.
3139
3140         * Scripts/webkitdirs.pm:
3141         (generateBuildSystemFromCMakeProject):
3142
3143 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3144
3145         Add MotionMark-1.1 plan file for run-benchmark script.
3146         https://bugs.webkit.org/show_bug.cgi?id=195481
3147
3148         Rubber-stamped by Darin Adler.
3149
3150         Run-benchmark script should support MontionMark-1.1.
3151
3152         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3153
3154 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-app] Add support for submit-to-ews url
3157         https://bugs.webkit.org/show_bug.cgi?id=195477
3158
3159         Reviewed by Lucas Forschler.
3160
3161         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3162         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3163         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3164         * BuildSlaveSupport/ews-app/ews/urls.py:
3165         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3166
3167 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3168
3169         Unreviewed, rolling out r242688, r242643, r242624.
3170
3171         Caused multiple layout test failures and crashes on iOS and macOS.
3172
3173         Reverted changeset:
3174
3175         "requestAnimationFrame should execute before the next frame"
3176         https://bugs.webkit.org/show_bug.cgi?id=177484
3177         https://trac.webkit.org/changeset/242624/webkit
3178
3179         * Tracing/SystemTracePoints.plist:
3180
3181 2019-03-11  John Wilander  <wilander@apple.com>
3182
3183         Resource Load Statistics: Make it possible exclude localhost from classification
3184         https://bugs.webkit.org/show_bug.cgi?id=195474
3185         <rdar://problem/47520577>
3186
3187         Reviewed by Brent Fulgham.
3188
3189         This patch allows for localhost to be excluded from classification and
3190         treatment as a prevalent resource.
3191
3192         The WebKit Tools change adds a new function called
3193         testRunner.setStatisticsIsRunningTest() which can be used to control this
3194         behavior.
3195
3196         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3197         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3198         (WTR::TestRunner::setStatisticsIsRunningTest):
3199         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3200         * WebKitTestRunner/TestController.cpp:
3201         (WTR::TestController::setStatisticsIsRunningTest):
3202         * WebKitTestRunner/TestController.h:
3203         * WebKitTestRunner/TestInvocation.cpp:
3204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3205
3206 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3207
3208         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3209         https://bugs.webkit.org/show_bug.cgi?id=195560
3210
3211         Reviewed by Lucas Forschler.
3212
3213         * BuildSlaveSupport/ews-build/master.cfg:
3214
3215 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3216
3217         Unreviewed, rolling out r242698.
3218
3219         API test crashes on bots.
3220
3221         Reverted changeset:
3222
3223         "Add a WKContentRuleList variant that uses copied memory
3224         instead of mmap'd shared memory for class A containerized
3225         apps"
3226         https://bugs.webkit.org/show_bug.cgi?id=195511
3227         https://trac.webkit.org/changeset/242698
3228
3229 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3230
3231         [WPE] Enable web process sandbox
3232         https://bugs.webkit.org/show_bug.cgi?id=195169
3233
3234         Reviewed by Daniel Bates.
3235
3236         * wpe/install-dependencies:
3237         * wpe/jhbuild.modules:
3238
3239 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3240
3241         [ews-app] Use port 17000 for worker communication
3242         https://bugs.webkit.org/show_bug.cgi?id=195558
3243
3244         Reviewed by Lucas Forschler.
3245
3246         * BuildSlaveSupport/ews-build/master.cfg:
3247
3248 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3249
3250         [ews-build] unit-tests fail when passwords.json is missing
3251         https://bugs.webkit.org/show_bug.cgi?id=195557
3252
3253         Reviewed by Lucas Forschler.
3254
3255         * BuildSlaveSupport/ews-build/loadConfig.py:
3256         (loadBuilderConfig):
3257         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3258         (ConfigDotJSONTest.test_configuration):
3259         * BuildSlaveSupport/ews-build/master.cfg:
3260
3261 2019-03-11  Truitt Savell  <tsavell@apple.com>
3262
3263         Unreviewed, rolling out r242702.
3264
3265         Broke High Sierra builders.
3266
3267         Reverted changeset:
3268
3269         "Add utility function to allow easy reverse range-based
3270         iteration of a container"
3271         https://bugs.webkit.org/show_bug.cgi?id=195542
3272         https://trac.webkit.org/changeset/242702
3273
3274 2019-03-11  Sam Weinig  <sam@webkit.org>
3275
3276         Add utility function to allow easy reverse range-based iteration of a container
3277         https://bugs.webkit.org/show_bug.cgi?id=195542
3278
3279         Reviewed by Antti Koivisto.
3280
3281         * TestWebKitAPI/CMakeLists.txt:
3282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3283         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3284         (TestWebKitAPI::TEST):
3285         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3286
3287 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3288
3289         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3290         https://bugs.webkit.org/show_bug.cgi?id=195511
3291         <rdar://problem/44873269>
3292
3293         Reviewed by Darin Adler.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3296         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3297         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3298         (TEST_F):
3299
3300 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3301
3302         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3303         https://bugs.webkit.org/show_bug.cgi?id=195499
3304
3305         Reviewed by Darin Adler.
3306
3307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3308         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3309         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3310         (-[WKWebView synchronouslyFocusTextInputContext:]):
3311         (applyStyle):
3312         (applyIframe):
3313         (TEST):
3314         Add some tests for this SPI.
3315
3316 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3317
3318         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3319         https://bugs.webkit.org/show_bug.cgi?id=181151
3320
3321         Reviewed by Don Olmstead.
3322
3323         * TestWebKitAPI/CMakeLists.txt:
3324         * TestWebKitAPI/PlatformWin.cmake:
3325         Enable TestWTF RunLoop tests in all platforms.
3326
3327         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3328         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3329         (TestWebKitAPI::DerivedOneShotTimer::fired):
3330         (TestWebKitAPI::TEST):
3331         Only a few platforms support nested RunLoop.
3332
3333         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3334         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3335
3336 2019-03-10  David Quesada  <david_quesada@apple.com>
3337
3338         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3339         https://bugs.webkit.org/show_bug.cgi?id=152480
3340
3341         Reviewed by Chris Dumez.
3342
3343         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3344         there are no additional references to the process pool besides the one held by
3345         the download, waits for the download to finish (in the sense that the
3346         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3347         measure, also check that the process pool has been deallocated at the end of the
3348         test. The test wouldn't be meaningful if the process pool were still alive.
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3351         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3352         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3353             The download will be canceled because the delegate does not implement the
3354             method to decide the download's destination, so this is where we know the
3355             DownloadProxyMap is done with the DownloadProxy.
3356         (TEST):
3357
3358 2019-03-08  Chris Dumez  <cdumez@apple.com>
3359
3360         Add support for Device Orientation / Motion permission API
3361         https://bugs.webkit.org/show_bug.cgi?id=195329
3362         <rdar://problem/47645367>
3363
3364         Reviewed by Geoffrey Garen.
3365
3366         Add test infrastructure to help test the Device Orientation / Motion permission API.
3367
3368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3370         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3372         * WebKitTestRunner/TestController.cpp:
3373         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3374         (WTR::TestController::createWebViewWithOptions):
3375         (WTR::TestController::resetStateToConsistentValues):
3376         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3377         * WebKitTestRunner/TestController.h:
3378         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3379         * WebKitTestRunner/TestInvocation.cpp:
3380         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3381
3382 2019-03-08  Saam barati  <sbarati@apple.com>
3383
3384         Add a compare-results script to compare benchmark results
3385         https://bugs.webkit.org/show_bug.cgi?id=195486
3386         <rdar://problem/48723397>
3387
3388         Reviewed by Geoffrey Garen.
3389
3390         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3391         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3392         to extend it to learn about our other benchmarks.
3393
3394         * Scripts/compare-results: Added.
3395         (readJSONFile):
3396         (detectJetStream2):
3397         (JetStream2Results):
3398         (detectSpeedometer2):
3399         (Speedometer2Results):
3400         (detectPLT5):
3401         (PLT5Results):
3402         (detectBenchmark):
3403         (biggerIsBetter):
3404         (ttest):
3405         (getOptions):
3406         (main):
3407
3408 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3409
3410         Ensure old tab state is cleared between iterations of run-benchmark
3411         https://bugs.webkit.org/show_bug.cgi?id=195393
3412         <rdar://problem/46885583>
3413
3414         Reviewed by Dewei Zhu.
3415
3416         a) ensure the default to restore state is not set
3417         b) terminate Safari correctly
3418         c) Set the system default to ignore Persistent State in Safari
3419
3420         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3421         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3422         (OSXBrowserDriver.prepare_env): 
3423         (OSXBrowserDriver.restore_env):
3424         (OSXBrowserDriver.close_browsers):
3425         (OSXBrowserDriver._terminate_processes):
3426         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3427         (OSXChromeDriver):
3428         (OSXChromeCanaryDriver):
3429         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3430         (OSXFirefoxDriver):
3431         (OSXFirefoxNightlyDriver):
3432         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3433         (OSXSafariDriver):
3434         (OSXSafariDriver.prepare_env):
3435
3436 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3437
3438         [GTK] Several InputMethodFilter tests are failing
3439         https://bugs.webkit.org/show_bug.cgi?id=195408
3440
3441         Reviewed by Carlos Garcia Campos.
3442
3443         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3444         Regressed in r241751.
3445         Hexadecimal values of keycodes are expressed now in upper letters.
3446         Composited characters should be cast to UTF8 strings.
3447
3448         (TestWebKitAPI::TEST):
3449
3450 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3451
3452         [GTK] Make Tools/gtkdoc python3 compatible
3453         https://bugs.webkit.org/show_bug.cgi?id=195359
3454
3455         Reviewed by Carlos Garcia Campos.
3456
3457         * gtkdoc/generate-gtkdoc:
3458         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3459         work with Python 2 and 3.
3460         (get_gtkdoc_module_paths):
3461         The iteritems() was removed in Python 3, so let's use items() that's
3462         available in Python 2 and 3.
3463         (get_generator_for_config):
3464         * gtkdoc/gtkdoc.py:
3465         (GTKDoc._run_command):
3466         The sys.stdout.write() is expecting str in Python 3 and not bytes
3467         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3468         for passing the bytes there.
3469
3470 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3471
3472         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3473         https://bugs.webkit.org/show_bug.cgi?id=195346
3474         <rdar://problem/48667048>
3475
3476         Unreviewed build fix for clang-cl.
3477
3478         * DumpRenderTree/win/DumpRenderTree.cpp:
3479         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3480
3481 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3482
3483         requestAnimationFrame should execute before the next frame
3484         https://bugs.webkit.org/show_bug.cgi?id=177484
3485
3486         Reviewed by Simon Fraser.
3487
3488         Add trace points for the page RenderingUpdate.
3489
3490         * Tracing/SystemTracePoints.plist:
3491
3492 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3493
3494         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3495         https://bugs.webkit.org/show_bug.cgi?id=195353
3496         <rdar://problem/48626394>
3497
3498         Reviewed by Simon Fraser.
3499
3500         * WebKitTestRunner/ios/TestControllerIOS.mm:
3501         (WTR::TestController::platformResetPreferencesToConsistentValues):
3502
3503 2019-03-07  John Wilander  <wilander@apple.com>
3504
3505         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3506         https://bugs.webkit.org/show_bug.cgi?id=195383
3507         <rdar://problem/48570136>
3508
3509         Reviewed by Brent Fulgham.
3510
3511         This patch adds test infrastructure to purge only script-accessible cookies,
3512         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3513
3514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3516         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3517         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3518         * WebKitTestRunner/TestController.cpp:
3519         (WTR::TestController::statisticsDeleteCookiesForHost):
3520         * WebKitTestRunner/TestController.h:
3521         * WebKitTestRunner/TestInvocation.cpp:
3522         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3523
3524 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3525
3526         Unreviewed, rolling out r242354.
3527         https://bugs.webkit.org/show_bug.cgi?id=195402
3528
3529         breaks layout tests in all configurations (Requested by
3530         zdobersek on #webkit).
3531
3532         Reverted changeset:
3533
3534         "[WPE] Enable web process sandbox"
3535         https://bugs.webkit.org/show_bug.cgi?id=195169
3536         https://trac.webkit.org/changeset/242354
3537
3538 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3539
3540         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3541         https://bugs.webkit.org/show_bug.cgi?id=195346
3542
3543         Reviewed by Fujii Hironori.
3544
3545         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3546         (TestWebKitAPI::TEST):
3547         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3548
3549         * DumpRenderTree/win/DumpRenderTree.cpp:
3550         (findFontFallback):
3551         (addFontFallbackIfPresent):
3552         (removeFontFallbackIfPresent):
3553         (main):
3554         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3555         (TestWebKitAPI::Util::moduleDirectory):
3556         (TestWebKitAPI::Util::createInjectedBundlePath):
3557         Use wchar helpers as needed.
3558
3559 2019-03-06  Rob Buis  <rbuis@igalia.com>
3560
3561         Consider supporting the `referrerpolicy` attribute.
3562         https://bugs.webkit.org/show_bug.cgi?id=179053
3563
3564         Reviewed by Darin Adler.
3565
3566         Add a runtime flag for referrerpolicy attribute.
3567
3568         * DumpRenderTree/mac/DumpRenderTree.mm:
3569         (enableExperimentalFeatures):
3570
3571 2019-03-05  Daniel Bates  <dabates@apple.com>
3572
3573         Update expected API test result following r242379
3574         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3575
3576         Update expected x-coordinate of selection rect now that the left padding of
3577         a textarea is sized in ems (so dependent on the font size) just like the left
3578         padding of a text field.
3579
3580         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3581         (TestWebKitAPI::TEST):
3582
3583 2019-03-05  David Quesada  <david_quesada@apple.com>
3584
3585         [WK2] It should be possible to follow links with 'download' attributes
3586         https://bugs.webkit.org/show_bug.cgi?id=195145
3587         rdar://problem/48462642
3588
3589         Reviewed by Alex Christensen.
3590
3591         Add a unit test to verify that activating links with 'download' attributes now
3592         navigates to the linked resource, rather than starts downloading it. Add another
3593         to verify that it is still possible to explicitly download the link via the
3594         'Download' navigation action policy.
3595
3596         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3597         (-[DownloadAttributeTestDelegate init]):
3598         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3599         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3600         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3601         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3602         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3603         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3604         (TEST):
3605         * WebKitTestRunner/TestController.cpp:
3606         (WTR::TestController::decidePolicyForNavigationAction):
3607         * WebKitTestRunner/TestController.h:
3608
3609 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3610
3611         [Curl] Implement Cookie Accept Policy.
3612         https://bugs.webkit.org/show_bug.cgi?id=191645
3613
3614         Reviewed by Fujii Hironori.
3615
3616         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3617         (TestWebKitAPI::Curl::TEST_F):
3618
3619 2019-03-05  Youenn Fablet  <youenn@apple.com>
3620
3621         Rename requestCacheStorageSpace to requestStorageSpace
3622         https://bugs.webkit.org/show_bug.cgi?id=195282
3623
3624         Reviewed by Chris Dumez.
3625
3626         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3627         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3628         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3629
3630 2019-03-05  Brady Eidson  <beidson@apple.com>
3631
3632         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3633         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3634
3635         Reviewed by Tim Horton.
3636
3637         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3638         different directory into that same WKWebView should work.
3639
3640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3641         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3642
3643 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3644
3645         Add WeakHashSet
3646         https://bugs.webkit.org/show_bug.cgi?id=195152
3647
3648         Reviewed by Antti Koivisto.
3649
3650         Added tests for WeakHashSet.
3651
3652         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3653         (TestWebKitAPI::Base::Base): Moved.
3654         (TestWebKitAPI::Derived::foo): Moved.
3655         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3656         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3657         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3658         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3659
3660 2019-03-04  Chris Dumez  <cdumez@apple.com>
3661
3662         Do not share WebProcesses between private and regular sessions
3663         https://bugs.webkit.org/show_bug.cgi?id=195189
3664         <rdar://problem/48421064>
3665
3666         Reviewed by Alex Christensen.
3667
3668         Add API test coverage.
3669
3670         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3671         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3672
3673 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3674
3675         [WPE] Enable web process sandbox
3676         https://bugs.webkit.org/show_bug.cgi?id=195169
3677
3678         Reviewed by Daniel Bates.
3679
3680         * wpe/install-dependencies:
3681         * wpe/jhbuild.modules:
3682
3683 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3684
3685         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3686         https://bugs.webkit.org/show_bug.cgi?id=195206
3687
3688         Reviewed by Žan Doberšek.
3689
3690         Add a new test case.
3691
3692         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3693         (testJSCClass):
3694
3695 2019-03-04  Charlie Turner  <cturner@igalia.com>
3696
3697         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3698         https://bugs.webkit.org/show_bug.cgi?id=194898
3699
3700         Reviewed by Žan Doberšek.
3701
3702         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3703         a GCC extension that permits arithmetic on void* pointer. Inline
3704         the macro until this issue is fixed upstream.
3705
3706 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3707
3708         Rid the world of WK_API_ENABLED
3709         https://bugs.webkit.org/show_bug.cgi?id=195263
3710
3711         Reviewed by Dan Bernstein.
3712
3713         List of changed files elided because it's useless.
3714
3715 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3716
3717         Unreviewed follow-up to r242292.
3718
3719         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3720
3721         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3722         (TestWebKitAPI::testStrip): Renamed from strip.
3723         (TestWebKitAPI::TEST):
3724
3725 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3726
3727         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3728
3729         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3730         and bug #194272 for details.
3731
3732         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3733
3734 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3735
3736         Remove some more unused 32-bit code
3737         https://bugs.webkit.org/show_bug.cgi?id=195255
3738
3739         Reviewed by Darin Adler.
3740
3741         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3742         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3743         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3744         (NPP_New):
3745         (NPP_HandleEvent):
3746         (handleEventCarbon): Deleted.
3747
3748 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3749
3750         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3751
3752         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3753         (TestWebKitAPI::TEST):
3754
3755 2019-03-01  Darin Adler  <darin@apple.com>
3756
3757         Finish removing String::format
3758         https://bugs.webkit.org/show_bug.cgi?id=194893
3759
3760         Reviewed by Daniel Bates.
3761 '
3762         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3763
3764 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3765
3766         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3767         https://bugs.webkit.org/show_bug.cgi?id=195229
3768         <rdar://problem/48520362>
3769
3770         Reviewed by Chris Dumez.
3771
3772         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3773         (TEST):
3774
3775 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3776
3777         Add a system trace scope for event region building
3778         https://bugs.webkit.org/show_bug.cgi?id=195226
3779
3780         Reviewed by Jon Lee.
3781
3782         This trace scope measures the time spend converting element rects into Region objects,
3783         which can be large on some pages.
3784
3785         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3786
3787         * Tracing/SystemTracePoints.plist:
3788
3789 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3790
3791         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3792         https://bugs.webkit.org/show_bug.cgi?id=194612
3793
3794         Reviewed by Alex Christensen.
3795
3796         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3797         Just test the new string-processing function and don't touch the actual environment.
3798         (Test cases are all as before, but based on operator== instead of strcmp.)
3799
3800 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3801
3802         [ews-app] Update primary keys for handling multiple Buildbot instances
3803         https://bugs.webkit.org/show_bug.cgi?id=195120
3804
3805         Reviewed by Stephanie Lewis.
3806
3807         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3808         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3809         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3810
3811         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3812         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3813         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3814         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3815         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3816         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3817
3818 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3819
3820         [WinCairo] Enable service worker
3821         https://bugs.webkit.org/show_bug.cgi?id=188318
3822
3823         Reviewed by Youenn Fablet.
3824
3825         * DumpRenderTree/DumpRenderTreePrefix.h:
3826         * TestWebKitAPI/PlatformWin.cmake:
3827         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3828         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3829         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3830
3831 2019-03-01  Justin Fan  <justin_fan@apple.com>
3832
3833         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3834         https://bugs.webkit.org/show_bug.cgi?id=195191
3835
3836         Rubber-stamped by Dean Jackson.
3837
3838         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3839
3840         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3841
3842 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3843
3844         Unreviewed, fix lldb webkitpy tests
3845         https://bugs.webkit.org/show_bug.cgi?id=194375
3846
3847         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3848
3849         * lldb/lldb_webkit.py:
3850         (WTFStringImplProvider.is_8bit):
3851
3852 2019-02-28  David Quesada  <david_quesada@apple.com>
3853
3854         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3855         https://bugs.webkit.org/show_bug.cgi?id=195121
3856         rdar://problem/48450302
3857
3858         Reviewed by Alex Christensen.
3859
3860         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3861         configurations where the 'download' attribute is absent, blank, or populated
3862         with a filename, and where the anchor element is same-origin or cross-origin
3863         (meaning the 'download' attribute shouldn't be honored).
3864
3865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3866         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3867         (-[NavigationActionTestDelegate init]):
3868         (-[NavigationActionTestDelegate navigationAction]):
3869         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3870         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3871         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3872         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3873         (TEST):
3874
3875 2019-02-28  Antoine Quint  <graouts@apple.com>
3876
3877         Enable the Pointer Events runtime flag by default
3878         https://bugs.webkit.org/show_bug.cgi?id=195156
3879
3880         Reviewed by Dean Jackson.
3881
3882         * DumpRenderTree/mac/DumpRenderTree.mm:
3883         (enableExperimentalFeatures):
3884
3885 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3886
3887         Several PasteImage API tests are flaky
3888         https://bugs.webkit.org/show_bug.cgi?id=195160
3889
3890         Reviewed by Tim Horton.
3891
3892         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3893         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3894         listening for a "load" event after image load is already complete.
3895
3896         To address this, make these tests first register a "load" event handler, then run script to insert an image
3897         element into the document, and finally wait until the load event is observed before checking image size.
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3900
3901 2019-02-28  Chris Dumez  <cdumez@apple.com>
3902
3903         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3904         https://bugs.webkit.org/show_bug.cgi?id=195107
3905
3906         Reviewed by Alex Christensen.
3907
3908         Give some time for the zoom level to get restored.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911
3912 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3913
3914         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3915         https://bugs.webkit.org/show_bug.cgi?id=194958
3916
3917         Reviewed by Geoffrey Garen.
3918
3919         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3920         (TEST):
3921
3922 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3923
3924         [ews-app] Update method to save build to handle builder_display_name
3925         https://bugs.webkit.org/show_bug.cgi?id=195047
3926
3927         Reviewed by Dewei Zhu.
3928
3929         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3930         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3931
3932 2019-02-28  Justin Fan  <justin_fan@apple.com>
3933
3934         [Web GPU] Enable Web GPU only on 64-bit
3935         https://bugs.webkit.org/show_bug.cgi?id=195139
3936
3937         Because Metal is only supported on 64 bit apps.
3938
3939         Unreviewed build fix.
3940
3941         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3942
3943 2019-02-27  Youenn Fablet  <youenn@apple.com>
3944
3945         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3946         https://bugs.webkit.org/show_bug.cgi?id=194959
3947
3948         Reviewed by Chris Dumez.
3949
3950         Spin loop until getting the condition to remove flakiness.
3951
3952         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3953
3954 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3955
3956         [ews-build] Buildbot should include builder_display_name in the build events
3957         https://bugs.webkit.org/show_bug.cgi?id=195045
3958
3959         Reviewed by Dewei Zhu.
3960
3961         * BuildSlaveSupport/ews-build/events.py:
3962         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3963         buildername to builder_name to be consistent in naming style.
3964         (Events.buildFinished): Ditto.
3965
3966 2019-02-27  Chris Dumez  <cdumez@apple.com>
3967
3968         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3969         https://bugs.webkit.org/show_bug.cgi?id=194480
3970
3971         Reviewed by Brady Eidson.
3972
3973         Update existing API test to make it more likely to reproduce the issue.
3974
3975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3976
3977 2019-02-27  Brady Eidson  <beidson@apple.com>
3978
3979         Universal links from Google search results pages don't open the app.
3980         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3981
3982         Reviewed by Geoffrey Garen.
3983
3984         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3985         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3986         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3987         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3988
3989 2019-02-27  Chris Dumez  <cdumez@apple.com>
3990
3991         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3992         https://bugs.webkit.org/show_bug.cgi?id=195102
3993
3994         Reviewed by Geoffrey Garen.
3995
3996         If the number of processes is not yet what we expect, wait a bit and check again to give
3997         processes some time to exit.
3998
3999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4000
4001 2019-02-27  Chris Dumez  <cdumez@apple.com>
4002
4003         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4004         https://bugs.webkit.org/show_bug.cgi?id=194545
4005
4006         Reviewed by Brady Eidson.
4007
4008         Make sure the test navigates forward and then back only once. Previously, navigating
4009         back would trigger a navigation again in a timer.
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4012
4013 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4014
4015         High Sierra Debug JSC test queue should use faster hardware
4016         https://bugs.webkit.org/show_bug.cgi?id=194603
4017
4018         Rubber-stamped by Alexey Proskuryakov.
4019
4020         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4021
4022         * BuildSlaveSupport/build.webkit.org-config/config.json:
4023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4024         (BubbleQueueServer):
4025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4026         (WebKitBuildbot):
4027         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4028         * QueueStatusServer/config/queues.py:
4029         * Scripts/webkitpy/common/config/ews.json:
4030         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4031         (test_ews_name):
4032
4033 2019-02-27  John Wilander  <wilander@apple.com>
4034
4035         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4036         https://bugs.webkit.org/show_bug.cgi?id=195071
4037         <rdar://problem/48417690>
4038
4039         Reviewed by Alex Christensen and Brent Fulgham.
4040
4041         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4042         (TestWebKitAPI::createURL):
4043             Convenience function.
4044         (TestWebKitAPI::TEST):
4045             WebCore::AdClickAttribution now takes a URL when creating Source and
4046             Destination.
4047         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4048         (TestWebKitAPI::TEST):
4049             WebCore::AdClickAttribution now takes a URL when creating Source and
4050             Destination.
4051
4052 2019-02-27  Antoine Quint  <graouts@apple.com>
4053
4054         Support Pointer Events on macOS
4055         https://bugs.webkit.org/show_bug.cgi?id=195008
4056         <rdar://problem/47454419>
4057
4058         Reviewed by Dean Jackson.
4059
4060         * DumpRenderTree/mac/DumpRenderTree.mm:
4061         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4062         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4063
4064 2019-02-26  Mark Lam  <mark.lam@apple.com>
4065
4066         Remove remaining poisoning code.
4067         https://bugs.webkit.org/show_bug.cgi?id=194138
4068
4069         Reviewed by Saam Barati.
4070
4071         * TestWebKitAPI/CMakeLists.txt:
4072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4073         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4074         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4075         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4076         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4077         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4078         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4079
4080 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4081
4082         Move ephemeral local storage from WebProcess to UIProcess
4083         https://bugs.webkit.org/show_bug.cgi?id=195074
4084         <rdar://problem/47937975>
4085
4086         Reviewed by Geoff Garen.
4087
4088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4089
4090 2019-02-20  Jer Noble  <jer.noble@apple.com>
4091
4092         [Cocoa] Media elements will restart network buffering just before suspending
4093         https://bugs.webkit.org/show_bug.cgi?id=193691
4094
4095         Reviewed by Eric Carlson.
4096
4097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4098         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4099         (TEST):
4100
4101 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4102
4103         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4104         https://bugs.webkit.org/show_bug.cgi?id=191652
4105
4106         Reviewed by Alex Christensen.
4107
4108         Fix WinCairo MiniBrowser behavior of authentication dialog.
4109
4110         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4111         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4112
4113 2019-02-26  Youenn Fablet  <youenn@apple.com>
4114
4115         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4116         https://bugs.webkit.org/show_bug.cgi?id=195028
4117         <rdar://problem/48243733>
4118
4119         Reviewed by Eric Carlson.
4120
4121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4122
4123 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4124
4125         [WPE] Add API for webview background color configuration
4126         https://bugs.webkit.org/show_bug.cgi?id=192305
4127
4128         Reviewed by Michael Catanzaro.
4129
4130         * MiniBrowser/wpe/main.cpp:
4131         (main): Add a new option to configure the webview background
4132         color. Example: --bg-color=transparent.
4133         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4134         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4135         (beforeAll): Ditto.
4136
4137 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4138
4139         scalableNativeWebpageParameters() is not preserved on new page navigation.
4140         https://bugs.webkit.org/show_bug.cgi?id=194892
4141         <rdar://problem/47538280>
4142
4143         Reviewed by Wenson Hsieh.
4144         
4145         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4146
4147         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4148         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4149         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4150         (WTR::UIScriptController::allowsViewportShrinkToFit):
4151         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4153         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4154         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4155         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4156         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4157
4158 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4159
4160         [ews-app] Add model for handling multiple Buildbot instances
4161         https://bugs.webkit.org/show_bug.cgi?id=194863
4162
4163         Reviewed by Stephanie Lewis.
4164
4165         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4166
4167 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4168
4169         [ews-app] Remove BuilderMapping table
4170         https://bugs.webkit.org/show_bug.cgi?id=194961
4171
4172         Reviewed by Stephanie Lewis.
4173
4174         Store builder name directly in build table, instead of having a separate
4175         table for it.
4176
4177         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4178         * BuildSlaveSupport/ews-app/ews/models/build.py:
4179         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4181
4182 2019-02-25  John Wilander  <wilander@apple.com>
4183
4184         Introduce and adopt new class RegistrableDomain for eTLD+1
4185         https://bugs.webkit.org/show_bug.cgi?id=194791
4186         <rdar://problem/48179240>
4187
4188         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4189
4190         This patch adds an API test and replaces two instances of
4191         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4192
4193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4194         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4195         (TestWebKitAPI::TEST):
4196             Changed two strings to make sure the registrable domains are still considered
4197             invalid and pass the test.
4198         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4199         (TestWebKitAPI::TEST):
4200         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4201         (WTR::InjectedBundle::didReceiveMessageToPage):
4202
4203 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4204
4205         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4206         https://bugs.webkit.org/show_bug.cgi?id=195001
4207
4208         Reviewed by Carlos Garcia Campos.
4209
4210         API version 1.0 always includes the functionality previously guarded with
4211         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4212         unconditionally.
4213
4214         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4215         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4216         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4217         (WebViewTest::showInWindow): Ditto.
4218         (WebViewTest::hideView): Ditto.
4219         * wpe/backends/HeadlessViewBackend.cpp:
4220         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4221         * wpe/backends/ViewBackend.cpp:
4222         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4223         * wpe/backends/WindowViewBackend.cpp:
4224         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4225         WPE_BACKEND_CHECK_VERSION().
4226         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4227
4228 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4229
4230         [Flatpak] Add support for flatpak > 1.1.2
4231         https://bugs.webkit.org/show_bug.cgi?id=194088
4232
4233         Flatpak 1.2 is now out so we need to support that
4234         version now.
4235
4236         Reviewed by Michael Catanzaro.
4237
4238         * flatpak/flatpakutils.py:
4239         (check_flatpak):
4240         (FlatpakPackages.__init__):
4241         (FlatpakPackages.__detect_packages):
4242         (FlatpakPackages.__detect_packages.in):
4243         (FlatpakRepos.update):
4244
4245 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4246
4247         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4248         https://bugs.webkit.org/show_bug.cgi?id=194998
4249
4250         Reviewed by Carlos Garcia Campos.
4251
4252         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4253         to a Git checkout and using the latest commit containing various fixes
4254         and improvements.
4255
4256 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4257
4258         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4259         https://bugs.webkit.org/show_bug.cgi?id=194981
4260
4261         Reviewed by Žan Doberšek.
4262
4263         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4264         (TestWebKitAPI::TEST):
4265
4266 2019-02-23  Keith Miller  <keith_miller@apple.com>
4267
4268         Add new mac target numbers
4269         https://bugs.webkit.org/show_bug.cgi?id=194955
4270
4271         Reviewed by Tim Horton.
4272
4273         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4274         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4275         * MiniBrowser/Configurations/Base.xcconfig:
4276         * TestWebKitAPI/Configurations/Base.xcconfig:
4277         * WebKitTestRunner/Configurations/Base.xcconfig:
4278
4279 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4280
4281         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4282         https://bugs.webkit.org/show_bug.cgi?id=194846
4283
4284         Reviewed by Don Olmstead.
4285
4286         Added _search_paths() and _port_specific_expectations_files() for
4287         WinCairoPort.
4288
4289         * Scripts/webkitpy/port/win.py:
4290         (WinCairoPort.default_baseline_search_path):
4291         (WinCairoPort):
4292         (WinCairoPort._port_specific_expectations_files):
4293         (WinCairoPort._search_paths):
4294
4295 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4296
4297         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4298         https://bugs.webkit.org/show_bug.cgi?id=194963
4299
4300         Reviewed by Dean Jackson.
4301
4302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4303         Do a `contains` check instead of `equals`, because in debug builds we
4304         put the GraphicsLayer pointer in a prefix.
4305
4306 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4307
4308         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4309         https://bugs.webkit.org/show_bug.cgi?id=194873
4310         <rdar://problem/46701974>
4311
4312         Reviewed by Tim Horton.
4313
4314         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4315
4316         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4317         (WTR::UIScriptController::menuRect const):
4318         (WTR::UIScriptController::isShowingMenu const):
4319         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4320         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4321         (WTR::UIScriptController::menuRect const):
4322
4323         Add a function to query the bounds of the callout menu in content coordinates.
4324
4325         (WTR::UIScriptController::isShowingMenu const):
4326
4327         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4328
4329         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4330         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4331         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4332         (WTR::UIScriptController::rectForMenuAction const):
4333         (WTR::UIScriptController::menuRect const):
4334         (WTR::UIScriptController::isShowingMenu const):
4335         (WTR::findViewInHierarchyOfType): Deleted.
4336
4337 2019-02-22  Chris Dumez  <cdumez@apple.com>
4338
4339         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4340         https://bugs.webkit.org/show_bug.cgi?id=194954
4341         <rdar://problem/48127957>
4342
4343         Reviewed by Alex Christensen.
4344
4345         Add API test coverage.
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4348         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4349         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4350         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4351
4352 2019-02-22  Chris Dumez  <cdumez@apple.com>
4353
4354         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4355         https://bugs.webkit.org/show_bug.cgi?id=194924
4356         <rdar://problem/48216125>
4357
4358         Reviewed by Geoffrey Garen.
4359
4360         Add API test coverage.
4361
4362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4363
4364 2019-02-22  Chris Dumez  <cdumez@apple.com>
4365
4366         Unreviewed, disable API test added in r241928 on iOS.