WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
2
3         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
4         https://bugs.webkit.org/show_bug.cgi?id=57570
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
9         and dump the information expected by the test cases.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13         (WTR::InjectedBundle::beginTesting): Explicitly set the default
14         database quota.
15         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
16         (WTR::securityOriginToStr): New convenience function to convert
17         a security origin to the string expected in test results.
18         (WTR):
19         (WTR::InjectedBundlePage::InjectedBundlePage):
20         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
21         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
22         refactoring to share code with didExceedDatabaseQuota.
23         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
24         (InjectedBundlePage):
25         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
26         (WTR::TestRunner::TestRunner):
27         * WebKitTestRunner/InjectedBundle/TestRunner.h:
28         (WTR::TestRunner::dumpDatabaseCallbacks):
29         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
30         (TestRunner):
31
32 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
33
34         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
35
36         Rubber-stamped by Simon Hausmann.
37
38         * qmake/mkspecs/features/default_post.prf:
39
40 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
41
42         [Qt] Remove old cruft from the qmake build system
43
44         Rubber-stamped by Simon Hausmann.
45
46         * DumpRenderTree/qt/DumpRenderTree.pro:
47         * qmake/mkspecs/features/default_post.prf:
48
49 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
50
51         [Qt] Enable force_static_libs_as_shared for development
52
53         Not enabled for buildbots or production-builds (part of Qt5)
54
55         Reviewed by Simon Hausmann.
56
57         * qmake/mkspecs/features/default_post.prf:
58
59 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
60
61         [Qt] Make force_static_libs_as_shared work on Mac OS
62
63         We had to move a few LIBS += around that were in the wrong place,
64         and not caught when everything was just linked into the final
65         QtWebKit library.
66
67         Reviewed by Simon Hausmann.
68
69         * qmake/mkspecs/features/default_post.prf:
70         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
71
72 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
73
74         [Qt] Fix build of WTR on Windows
75
76         Reviewed by Tor Arne Vestbø.
77
78         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
79         With qmake's unix makefile generator as well as with the MingW generator,
80         the directory where the pro file lives (WTR/) is automatically added to
81         the include search path, but not so with MSVC. Instead of relying on qmake's
82         implicit feature here, add WTR/ explicitly to the include search path.
83
84         * WebKitTestRunner/Target.pri:
85
86 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
87
88         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
89         https://bugs.webkit.org/show_bug.cgi?id=42691
90
91         Reviewed by Kenneth Rohde Christiansen.
92
93         Add implementation for testrunner.setStopProvisionalFrameLoads()
94         in WebKitTestRunner.
95
96         Original patch by Alexey Proskuryakov.
97
98         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
99         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
100         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
101         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
102         (WTR::TestRunner::TestRunner):
103         * WebKitTestRunner/InjectedBundle/TestRunner.h:
104         (TestRunner):
105         (WTR::TestRunner::setStopProvisionalFrameLoads):
106         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
107
108 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
109
110         [Qt] Fix handling of debug/release/debug_and_release/build_all
111
112         We now pick up the defaults from Qt, in default_pre (CONFIG already
113         contains the appropriate values for debug and release). We then let
114         the command line arguments to qmake, or the project files themselves,
115         override the configuration, and finally we sanitize the configuration
116         in default_post.
117
118         Reviewed by Simon Hausmann.
119
120         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
121         * Scripts/webkitdirs.pm:
122         (buildQMakeProjects):
123         * qmake/mkspecs/features/default_post.prf:
124         * qmake/mkspecs/features/default_pre.prf:
125         * qmake/mkspecs/features/mac/default_pre.prf:
126
127 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
128
129         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
130         https://bugs.webkit.org/show_bug.cgi?id=42687
131
132         Reviewed by Kenneth Rohde Christiansen.
133
134         Implement testRunner.setTabKeyCyclesThroughElements for
135         WebKitTestRunner.
136
137         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
138         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
139         (WTR::InjectedBundle::beginTesting):
140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
141         (WTR::TestRunner::setTabKeyCyclesThroughElements):
142         (WTR):
143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
144         (TestRunner):
145
146 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
147
148         EventSendingController::keyDown does not support non-array modifier arguments
149         https://bugs.webkit.org/show_bug.cgi?id=96727
150
151         Reviewed by Kenneth Rohde Christiansen.
152
153         Add support for handling a string as modifier argument to
154         EventSendingController::keyDown.
155
156         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
157         (WTR::parseModifierArray):
158
159 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
160
161         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
162         https://bugs.webkit.org/show_bug.cgi?id=42546
163
164         Reviewed by Kenneth Rohde Christiansen.
165
166         Exported TestRunner::setCustomPolicyDelegate() method.
167         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
168
169         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
171         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
172
173 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
174
175         [GTK] Clear application cache between tests in DumpRenderTree
176         https://bugs.webkit.org/show_bug.cgi?id=96543
177
178         Reviewed by Philippe Normand.
179
180         Call the new DumpRenderTreeSupportGtk method to clear application cache
181         after each test in DumpRenderTree.
182
183         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
184         as well. It's now being set in XvfbDriver._start so that each driver is assigned
185         a cache directory that's constructed out of the driver's name and its worker
186         number. These directories are located in the layout tests results directory.
187         At least on the builders this ensures a driver-specific empty cache directory
188         with each test run.
189
190         * DumpRenderTree/gtk/DumpRenderTree.cpp:
191         (runTest):
192         * Scripts/webkitpy/layout_tests/port/gtk.py:
193         (GtkPort.setup_environ_for_server):
194         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
195         (XvfbDriver._start):
196
197 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
198
199         [Qt] Fix linking on Windows
200
201         Reviewed by Tor Arne Vestbø.
202
203         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
204         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
205         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
206         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
207
208         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
209         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
210         after the module. Therefore QT did never contain webkit anymore and we always passed
211         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
212
213         This patch introduces a creating_module configuration that is used to
214         scope the qt/pkgconfig sanitization.
215
216         * qmake/mkspecs/features/default_post.prf:
217
218 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
219
220         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
221         https://bugs.webkit.org/show_bug.cgi?id=96740
222
223         Reviewed by Kenneth Rohde Christiansen.
224
225         Dump information expected by the test cases about the following
226         frame load callbacks:
227         "didDisplayInsecureContentForFrame"
228         "didRunInsecureContentForFrame"
229         "didDetectXSSForFrame"
230
231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
232         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
233         as expected by test results by calling pathSuitableForTestResult() instead
234         of printing raw URL.
235         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
236         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
237         (WTR::InjectedBundlePage::didDetectXSSForFrame):
238
239 2012-09-14  Peter Beverloo  <peter@chromium.org>
240
241         The runtime/unsigned category should be valid in the cpp style-checker.
242         https://bugs.webkit.org/show_bug.cgi?id=96748
243
244         Reviewed by Csaba Osztrogonác.
245
246         This is causing the webkitpy tests to fail because it's not listed in the
247         category array. Furthermore, change an "int" to "long" because it's
248         throwing a double error in one of the earlier asserts.
249
250         * Scripts/webkitpy/style/checkers/cpp.py:
251         (CppChecker):
252         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
253         (WebKitStyleTest.test_names):
254
255 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
256
257         Evas_Object* is a ref'ed structure, so tread it as such
258         https://bugs.webkit.org/show_bug.cgi?id=96659
259
260         Reviewed by Adam Barth.
261
262         Replace OwnPtr<Evas_Object> with RefPtr.
263
264         * DumpRenderTree/efl/ImageDiff.cpp:
265         (calculateDifference):
266         (printImageDifferences):
267         (readImageFromStdin):
268         (main):
269
270 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
271
272         Unreviewed, rolling out r128507.
273         http://trac.webkit.org/changeset/128507
274         https://bugs.webkit.org/show_bug.cgi?id=96659
275
276         Revert. r128507 makes too many crashes in EFL layout test bots.
277
278         * DumpRenderTree/efl/ImageDiff.cpp:
279         (calculateDifference):
280         (printImageDifferences):
281         (readImageFromStdin):
282         (main):
283
284 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
285
286         Make compile with both OS(WINCE) and PLATFORM(QT) support
287         https://bugs.webkit.org/show_bug.cgi?id=95536
288
289         Reviewed by Simon Hausmann.
290
291         Fix wince support in qmake files
292
293         * Tools.pro:
294         * qmake/mkspecs/features/configure.prf:
295         * qmake/mkspecs/features/default_post.prf:
296         * qmake/mkspecs/features/features.prf:
297         * qmake/mkspecs/features/functions.prf:
298
299 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
300
301         [WK2] Add color picker API support for WebKit2
302         https://bugs.webkit.org/show_bug.cgi?id=95058
303
304         Reviewed by Gyuyoung Kim.
305
306         Initialization code for color picker callbacks in UI client.
307
308         * MiniBrowser/mac/BrowserWindowController.m:
309         (-[BrowserWindowController awakeFromNib]):
310         * MiniBrowser/win/BrowserView.cpp:
311         (BrowserView::create):
312         * WebKitTestRunner/TestController.cpp:
313         (WTR::TestController::createOtherPage):
314         (WTR::TestController::initialize):
315
316 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
317
318         Upgrade yutak to reviewer
319         https://bugs.webkit.org/show_bug.cgi?id=96721
320
321         Reviewed by Kent Tamura.
322
323         * Scripts/webkitpy/common/config/committers.py:
324
325 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
326
327         Make the style checker report usage of "unsigned int"
328         https://bugs.webkit.org/show_bug.cgi?id=96693
329
330         Reviewed by Dirk Pranke.
331
332         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
333
334         * Scripts/webkitpy/style/checkers/cpp.py:
335         (check_language):
336
337 2012-09-13  Philip Rogers  <pdr@google.com>
338
339         Add gender-neutral form of webkit-patch land-cowboy
340         https://bugs.webkit.org/show_bug.cgi?id=96709
341
342         Reviewed by Adam Barth.
343
344         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
345
346         * Scripts/webkitpy/tool/commands/download.py:
347         (LandCowhand):
348
349 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
350
351         [EFL] Remove some parameters in browserCreate()
352         https://bugs.webkit.org/show_bug.cgi?id=96499
353
354         Reviewed by Kenneth Rohde Christiansen.
355
356         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
357         And I have moved some parameters into User_Arguments.
358
359         * EWebLauncher/main.c:
360         (_User_Arguments):
361         (_ELauncher):
362         (on_key_down):
363         (browserCreate):
364         (findThemePath):
365         (parseUserArguments):
366         (main):
367
368 2012-09-13  Mark Lam  <mark.lam@apple.com>
369
370         Unreviewed. Adding myself to the committers list.
371
372         * Scripts/webkitpy/common/config/committers.py:
373
374 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
375
376         run-perf-tests output cryptic error when the config file is missing.
377         https://bugs.webkit.org/show_bug.cgi?id=96453
378
379         Reviewed by Tony Chang.
380
381         Add a special error message when a configuration file is missing.
382
383         Also update the help message of --source-json-path to signify the fact it specifies
384         the configuration file on performance tests bots.
385
386         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
387         (PerfTestsRunner._parse_args):
388         (PerfTestsRunner._generate_and_show_results):
389         (PerfTestsRunner._merge_slave_config_json):
390         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
391         (_test_run_with_json_output): Make upload to fail by default and assert the result
392         in the function so that we can return logs instead.
393         (_test_run_with_json_output.mock_upload_json):
394         (test_run_with_json_output):
395         (test_run_with_description):
396         (test_run_respects_no_results):
397         (test_run_with_slave_config_json):
398         (test_run_with_bad_slave_config_json):
399         (test_run_with_multiple_repositories):
400
401 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
402
403         Evas_Object* is a ref'ed structure, so tread it as such
404         https://bugs.webkit.org/show_bug.cgi?id=96659
405
406         Reviewed by Adam Barth.
407
408         Replace OwnPtr<Evas_Object> with RefPtr.
409
410         * DumpRenderTree/efl/ImageDiff.cpp:
411         (calculateDifference):
412         (printImageDifferences):
413         (readImageFromStdin):
414         (main):
415
416 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
417
418         One more unreviewed trivial fix after r128399.
419
420         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
421
422 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
423
424         Unreviewed trivial fix after r128399.
425
426         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
427         (getLatestSVNRevision):
428         (waitForSVNRevision):
429
430 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
431
432         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
433         https://bugs.webkit.org/show_bug.cgi?id=96366
434
435         Reviewed by Anders Carlsson.
436
437         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
438         by calling shouldClose() on the FrameLoader.
439
440         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
442         (WTR::TestRunner::callShouldCloseOnWebView):
443         (WTR):
444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
445         (TestRunner):
446
447 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
448
449         Unreviewed, rolling out r128453.
450         http://trac.webkit.org/changeset/128453
451         https://bugs.webkit.org/show_bug.cgi?id=96681
452
453         Having tests use the same appcache directory leads to timeouts
454         (Requested by zdobersek on #webkit).
455
456         * DumpRenderTree/gtk/DumpRenderTree.cpp:
457         (runTest):
458         * Scripts/webkitpy/layout_tests/port/gtk.py:
459         (GtkPort.setup_environ_for_server):
460
461 2012-09-13  James Robinson  <jamesr@chromium.org>
462
463         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
464         https://bugs.webkit.org/show_bug.cgi?id=96678
465
466         Reviewed by Dirk Pranke.
467
468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
469         (.):
470
471 2012-09-13  Rob Buis  <rbuis@rim.com>
472
473         Unreviewed changes to watchlist.
474
475         - Add myself to BlackBerry bugs
476
477         * Scripts/webkitpy/common/config/watchlist:
478
479 2012-09-13  Stephen Chenney  <schenney@chromium.org>
480
481         Add an SVG entry to the watchlist
482
483         Unreviewed config change.
484
485         * Scripts/webkitpy/common/config/watchlist:
486         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
487         - Added myself and pdr as watchers
488
489 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
490
491         [Qt] Make WebKit2 work on Windows with Qt 5
492         https://bugs.webkit.org/show_bug.cgi?id=76776
493
494         Reviewed by Tor Arne Vestbø.
495
496         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
497         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
498         that for the GL TextureMapper (it's only built when that feature is set).
499
500         * qmake/mkspecs/features/configure.prf:
501
502 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
503
504         [Qt] Ensure that QT is finalized before loading qt_module.prf
505
506         As qt_module.prf does dependency tracking based on the content of the
507         QT variable. The intermediate WebKit modules modify the variable in
508         their .pri files, so we have to ensure we've loaded all the modules
509         before loading qt_module.
510
511         Reviewed by Tor Arne Vestbø.
512         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
513
514         * qmake/mkspecs/features/default_post.prf:
515         * qmake/mkspecs/features/webkit_modules.prf: Added.
516
517 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
518
519         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
520         https://bugs.webkit.org/show_bug.cgi?id=96633
521
522         Reviewed by Csaba Osztrogonác.
523
524         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
525         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
526         It's the usual problem and the usual solution is to rename one of the conflicting files.
527         This patch chooses to rename DRT instead of WTR and MBR.
528
529         Fixed include order at the same time to match style guide.
530
531         * DumpRenderTree/qt/DumpRenderTree.pro:
532         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
533         (messageHandler):
534         (isOption):
535         (takeOptionValue):
536         (printUsage):
537         (main):
538
539 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
540
541         The Script run-launcher should support -2 in combination with --efl
542         https://bugs.webkit.org/show_bug.cgi?id=96639
543
544         Reviewed by Simon Hausmann.
545
546         Support running the MiniBrowser then supplied -2 as argument.
547
548         * Scripts/run-launcher:
549
550 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
551
552         Unreviewed, add my Intel email address to the list.
553
554         * Scripts/webkitpy/common/config/committers.py:
555
556 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
557
558         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
559
560         Reviewed by Ossy.
561
562         * qmake/mkspecs/features/default_post.prf:
563
564 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
565
566         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
567         https://bugs.webkit.org/show_bug.cgi?id=82294
568
569         Reviewed by Gyuyoung Kim.
570
571         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
572
573         * DumpRenderTree/efl/TestRunnerEfl.cpp:
574         (TestRunner::layerTreeAsText):
575
576 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
577
578         [GTK] Clear application cache between tests in DumpRenderTree
579         https://bugs.webkit.org/show_bug.cgi?id=96543
580
581         Reviewed by Philippe Normand.
582
583         Call the new DumpRenderTreeSupportGtk method to clear application cache
584         after each test.
585
586         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
587         as well. Currently it points to a subdirectory in the layout tests results
588         directory. At least on the builders this ensures an empty cache directory
589         with each test run.
590
591         * DumpRenderTree/gtk/DumpRenderTree.cpp:
592         (runTest):
593         * Scripts/webkitpy/layout_tests/port/gtk.py:
594         (GtkPort.setup_environ_for_server):
595
596 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
597
598         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
599
600         Unless it's actually a dependency of the public QtWebKit API.
601
602         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
603         files with their _PRIVATE equivivalent, but that's likely to break when
604         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
605         clean up the variables in default_post.
606
607         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
608         longer needed, as it was a workaround for the intermediate libraries ending
609         up in the prl file. And, since CONFIG -= staticlib was there to support
610         the explicitlib option, we can remove that too (as well as the exception
611         for gprof, since it would be empty). If gprof needs tweaks to always link
612         statically they should go in gprof.prf.
613
614         Reviewed by Simon Hausmann.
615
616         * qmake/mkspecs/features/default_post.prf:
617         * qmake/mkspecs/features/functions.prf:
618
619 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
620
621         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
622         https://bugs.webkit.org/show_bug.cgi?id=96632
623
624         Reviewed by Carlos Garcia Campos.
625
626         Fix this by using atk_object_get_n_accessible_children instead of
627         calling getChildren() from childCount.
628
629         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
630         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
631         loop by using atk_object_get_n_accessible_children().
632
633 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
634
635         [Qt][Win] Enable USE(3D_GRAPHICS)
636         https://bugs.webkit.org/show_bug.cgi?id=90879
637
638         Reviewed by Kenneth Rohde Christiansen.
639
640         Enable it on Windows as well as on QNX (bug fixed).
641
642         * qmake/mkspecs/features/features.prf:
643
644 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
645
646         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
647         https://bugs.webkit.org/show_bug.cgi?id=96359
648
649         Reviewed by Tor Arne Vestbø.
650
651         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
652         lexer. The only viable alternative I could find on Windows that provides
653         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
654         so let's use that one instead.
655
656         * Scripts/webkitdirs.pm:
657         (checkRequiredSystemConfig):
658         * qmake/mkspecs/features/default_pre.prf:
659
660 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
661
662         [Qt] Add configuration for production builds
663         https://bugs.webkit.org/show_bug.cgi?id=96607
664
665         Reviewed by Kenneth Rohde Christiansen.
666
667         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
668         and enable all-in-one-files optimizations.
669
670         * qmake/mkspecs/features/production_build.prf: Added.
671
672 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
673
674         [Qt] GStreamer detection does not work when cross-compiling
675         https://bugs.webkit.org/show_bug.cgi?id=96608
676
677         Reviewed by Kenneth Rohde Christiansen.
678
679         When cross-compiling it is not safe to just use system(pkg-config),
680         because there is a high probability that it will find packages in the
681         host system instead of in the target one. Instead use qmake's new
682         packagesExist() function that takes care of this delicate aspect of
683         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
684         PKG_CONFIG_LIBDIR accordingly.
685
686         * qmake/mkspecs/features/features.prf:
687
688 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
689
690         [WK2][WTR] More efficient string handling in InjectedBundlePage
691         https://bugs.webkit.org/show_bug.cgi?id=96609
692
693         Reviewed by Kenneth Rohde Christiansen.
694
695         Update StringBuilder usage in InjectedBundlePage to follow
696         the latest recommandations for efficient string handling:
697         http://trac.webkit.org/wiki/EfficientStrings
698
699         This involves using appendLiteral() or appendNumber()
700         instead of append() whenever possible.
701
702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
703         (WTR::dumpPath):
704         (WTR::rangeToStr):
705         (WTR::styleDecToStr):
706         (WTR::frameToStr):
707         (WTR::dumpResourceURL):
708         (WTR):
709         (WTR::dumpFrameDescriptionSuitableForTestResult):
710         (WTR::dumpRequestDescriptionSuitableForTestResult):
711         (WTR::dumpResponseDescriptionSuitableForTestResult):
712         (WTR::dumpErrorDescriptionSuitableForTestResult):
713         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
714         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
715         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
716         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
717         (WTR::InjectedBundlePage::didCommitLoadForFrame):
718         (WTR::InjectedBundlePage::didFinishProgress):
719         (WTR::dumpFrameScrollPosition):
720         (WTR::dumpFrameText):
721         (WTR::dumpDescendantFramesText):
722         (WTR::InjectedBundlePage::didFinishLoadForFrame):
723         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
724         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
725         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
726         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
727         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
728         (WTR::InjectedBundlePage::willSendRequestForFrame):
729         (WTR::InjectedBundlePage::didReceiveResponseForResource):
730         (WTR::InjectedBundlePage::didFinishLoadForResource):
731         (WTR::InjectedBundlePage::didFailLoadForResource):
732         (WTR::InjectedBundlePage::shouldCacheResponse):
733         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
734         (WTR::InjectedBundlePage::willAddMessageToConsole):
735         (WTR::InjectedBundlePage::willSetStatusbarText):
736         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
737         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
738         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
739         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
740         (WTR::InjectedBundlePage::shouldBeginEditing):
741         (WTR::InjectedBundlePage::shouldEndEditing):
742         (WTR::InjectedBundlePage::shouldInsertNode):
743         (WTR::InjectedBundlePage::shouldInsertText):
744         (WTR::InjectedBundlePage::shouldDeleteRange):
745         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
746         (WTR::InjectedBundlePage::shouldApplyStyle):
747         (WTR::InjectedBundlePage::didBeginEditing):
748         (WTR::InjectedBundlePage::didEndEditing):
749         (WTR::InjectedBundlePage::didChange):
750         (WTR::InjectedBundlePage::didChangeSelection):
751         (WTR::InjectedBundlePage::supportsFullScreen):
752         (WTR::InjectedBundlePage::enterFullScreenForElement):
753         (WTR::InjectedBundlePage::exitFullScreenForElement):
754         (WTR::InjectedBundlePage::beganEnterFullScreen):
755         (WTR::InjectedBundlePage::beganExitFullScreen):
756         (WTR::InjectedBundlePage::closeFullScreen):
757         (WTR::dumpBackForwardListItem):
758         (WTR::InjectedBundlePage::dumpBackForwardList):
759
760 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
761
762         [Qt][WK2] Memory leaks in Qt's TestRunner
763         https://bugs.webkit.org/show_bug.cgi?id=96603
764
765         Reviewed by Csaba Osztrogonác.
766
767         Fix memory leaks in Qt's TestRunner code by adopting WKString
768         created with WKStringCreateWithUTF8CString().
769
770         * WebKitTestRunner/qt/TestControllerQt.cpp:
771         (WTR::TestController::initializeInjectedBundlePath):
772         (WTR::TestController::initializeTestPluginDirectory):
773
774 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
775
776         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
777         https://bugs.webkit.org/show_bug.cgi?id=96506
778
779         Reviewed by Dirk Pranke.
780
781         Lower the timeout value to 6 seconds for release configuration and 12 seconds
782         for debug configuration. These are the same values the Chromium port uses.
783
784         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
785         the layout tests under WebKit2 generally) requires more attention and gardening
786         than what the current effort produces.
787
788         The unit test is updated as well to test these changes.
789
790         * Scripts/webkitpy/layout_tests/port/gtk.py:
791         (GtkPort.default_timeout_ms):
792         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
793         (GtkPortTest.test_default_timeout_ms):
794         (GtkPortTest.assertLinesEqual):
795
796 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
797
798         Add SVN mirror handling feature to build.webkit.org
799         https://bugs.webkit.org/show_bug.cgi?id=85887
800
801         Reviewed by Dirk Pranke.
802
803         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
804         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
805         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
806         (ConfigureBuild.start):
807         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
808         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
809         (Factory.__init__):
810         (BuildFactory.__init__):
811         (TestFactory.__init__):
812         (BuildAndTestFactory.__init__):
813         (BuildAndPerfTestFactory.__init__):
814         (BuildAndPerfTestWebKit2Factory.__init__):
815         (DownloadAndPerfTestFactory.__init__):
816         (DownloadAndPerfTestWebKit2Factory.__init__):
817         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
818         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
819         (SVNMirrorTest):
820         (SVNMirrorTest.setUp): Load config.json once at startup.
821         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
822         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
823         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
824         (getLatestSVNRevision): Get the latest SVN revison from the given server.
825         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
826                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
827
828 2012-09-12  Kangil Han  <kangil.han@samsung.com>
829
830         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
831         https://bugs.webkit.org/show_bug.cgi?id=81606
832
833         Reviewed by Tim Horton.
834
835         6 seconds is harsh for some jquery test cases.
836         Therefore, adjust the value to match DumpRenderTree.
837
838         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
839         (WTR):
840
841 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
842
843         [EFL] Support download attribute feature
844         https://bugs.webkit.org/show_bug.cgi?id=96462
845
846         Reviewed by Gyuyoung Kim.
847
848         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
849         and add "download,request" callback to the DumpRenderTree for EFL.
850
851         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
852         (DumpRenderTreeChrome::createView):
853         (DumpRenderTreeChrome::onDownloadRequest):
854         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
855         (DumpRenderTreeChrome):
856         * Scripts/webkitperl/FeatureList.pm:
857
858 2012-09-12  Stephanie Lewis  <slewis@apple.com>
859
860         Reduce parallism on the wk2 testers.
861         https://bugs.webkit.org/show_bug.cgi?id=95906
862
863         Reviewed by Dirk Pranke.
864
865         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
866         resource contention.  Reducing the number of processes alleviates the issue.  
867
868         Starting by reducing 25%.
869
870         * Scripts/webkitpy/layout_tests/port/mac.py:
871         (MacPort.default_child_processes):
872
873 2012-09-12  Brady Eidson  <beidson@apple.com>
874
875         Assert in NetscapePlugin::destroy() with async plugin init
876         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
877
878         Reviewed by Anders Carlsson.
879
880         Expose NPN_Invoke to plug-in tests:
881         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
882         (PluginTest::NPN_Invoke):
883         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
884         (PluginTest):
885
886         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
887         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
888         (InvokeDestroysPluginWithinNPP_New):
889         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
890         (InvokeDestroysPluginWithinNPP_New::NPP_New):
891         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
892
893 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
894
895         refactor TestExpectations tokenization slightly in preparation for the new syntax
896         https://bugs.webkit.org/show_bug.cgi?id=96564
897
898         Reviewed by Ojan Vafai.
899
900         This change changes how we will tokenize/lex the
901         TestExpectations files, in preparation for supporting both the
902         old syntax and the new one. This change by itself should be a
903         no-op.
904
905         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
906         (TestExpectationParser._tokenize_line):
907         (TestExpectationParser):
908         (TestExpectationParser._tokenize_line_using_old_format):
909         (TestExpectationParser._tokenize_line_using_new_format):
910
911 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
912
913         remove unused testexpectations editing code from webkitpy, garden-o-matic
914         https://bugs.webkit.org/show_bug.cgi?id=96562
915
916         Reviewed by Adam Barth.
917
918         This code was prototyped but never fully realized. Removing
919         until it reanimates :).
920
921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
923         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
924         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
925         * Scripts/webkitpy/tool/servers/gardeningserver.py:
926         (BuildCoverageExtrapolator.extrapolate_test_configurations):
927         (GardeningHTTPRequestHandler._run_webkit_patch):
928         (GardeningHTTPRequestHandler.ping):
929         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
930         (BuildCoverageExtrapolatorTest.test_extrapolate):
931         (GardeningServerTest.test_rebaseline_new_port):
932
933 2012-09-12  Lucas Forschler  <lforschler@apple.com>
934
935         Remove unused bot, apple-xserve-1.
936         https://bugs.webkit.org/show_bug.cgi?id=96570
937         
938         Reviewed by Stephanie Lewis.
939
940         * BuildSlaveSupport/build.webkit.org-config/config.json:
941
942 2012-09-12  Xan Lopez  <xlopez@igalia.com>
943
944         [GTK] We attempt to rebase documentation even if it's not present
945         https://bugs.webkit.org/show_bug.cgi?id=96553
946
947         Reviewed by Martin Robinson.
948
949         Do not make the documentation rebase step fatal. This allows make
950         install to succeed when there's no documentation generated.
951
952         * gtk/generate-gtkdoc:
953
954 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
955
956         Respect WEBKITOUTPUTDIR when running EFL tests
957         https://bugs.webkit.org/show_bug.cgi?id=96528
958
959         Reviewed by Dirk Pranke.
960
961         Expose user set WEBKITOUTPUTDIR to the web process.
962
963         * Scripts/webkitpy/layout_tests/port/driver.py:
964         (Driver._start): Add WEBKITOUTPUTDIR to the environment
965         of the web process and its potential jhbuild wrapper.
966
967 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
968
969         webkitdirs: fix uname version handling for cygwin
970         https://bugs.webkit.org/show_bug.cgi?id=96436
971
972         Reviewed by Jon Honeycutt.
973
974         Newer versions of cygwin embed an additional version string
975         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
976         Update the code to handle that.
977
978         * Scripts/webkitdirs.pm:
979         (setupAppleWinEnv):
980
981 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
982
983         Regression(r128338): Broke Windows build
984         https://bugs.webkit.org/show_bug.cgi?id=96537
985
986         Unreviewed build fix.
987
988         Fix Apple-Win build by allocating array dynamically
989         since its size is not constant.
990
991         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
992         (WTR::stringArrayToJS):
993
994 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
995
996         [chromium] Add a virtual test suite for fast/hidpi
997         https://bugs.webkit.org/show_bug.cgi?id=90192
998
999         Reviewed by Dirk Pranke.
1000
1001         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1002         on the hardware accelerated path as the software path.
1003
1004         * DumpRenderTree/chromium/WebPreferences.cpp:
1005         (WebPreferences::applyTo):
1006         * Scripts/webkitpy/layout_tests/port/chromium.py:
1007         (ChromiumPort.virtual_test_suites):
1008
1009 2012-09-12  Adam Klein  <adamk@chromium.org>
1010
1011         [chromium] Add content_browsertests to the flakiness dashboard
1012         https://bugs.webkit.org/show_bug.cgi?id=96535
1013
1014         Reviewed by Ojan Vafai.
1015
1016         * TestResultServer/static-dashboards/dashboard_base.js:
1017
1018 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1019
1020         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1021         https://bugs.webkit.org/show_bug.cgi?id=96496
1022
1023         Reviewed by Kenneth Rohde Christiansen.
1024
1025         Add implementation for originsWithApplicationCache to
1026         WebKitTestRunner.
1027
1028         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1029         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1030         (WTR::stringArrayToJS):
1031         (WTR):
1032         (WTR::TestRunner::originsWithApplicationCache):
1033         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1034         (TestRunner):
1035
1036 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1037
1038         Fix Qt/Windows build with Python3
1039         https://bugs.webkit.org/show_bug.cgi?id=96473
1040
1041         Reviewed by Csaba Osztrogonác.
1042
1043         In Python 3 print is a real function, so we must use parentheses around
1044         the function parameters. This is backwards compatible with Python 2.
1045
1046         * Scripts/generate-win32-export-forwards:
1047
1048 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1049
1050         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1051
1052         As pointed out by Kevin, we should inject the "set PATH=..." statement
1053         to add the GnuWin32 directory only if that directory actually exists.
1054
1055         * qmake/mkspecs/features/default_post.prf:
1056
1057 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1058
1059         [EFL] [WK2] Memory leaks in TestControllerEfl
1060         https://bugs.webkit.org/show_bug.cgi?id=96525
1061
1062         Reviewed by Kenneth Rohde Christiansen.
1063
1064         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1065         of WKString created with WKStringCreateWithUTF8CString().
1066
1067         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1068         (WTR::TestController::initializeInjectedBundlePath):
1069         (WTR::TestController::initializeTestPluginDirectory):
1070
1071 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1072
1073         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1074         https://bugs.webkit.org/show_bug.cgi?id=96374
1075
1076         Reviewed by Kenneth Rohde Christiansen.
1077
1078         Implement support for dumpApplicationCacheDelegateCallbacks
1079         and disallowIncreaseForApplicationCacheQuota in
1080         WebKitTestRunner and properly dump the information
1081         expected by the tests.
1082
1083         If the application cache quota is reached for a given
1084         security origin, WebKitTestRunner will reset the quota
1085         to its default value, unless intructed not to via
1086         disallowIncreaseForApplicationCacheQuota().
1087
1088         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1089         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1090         (WTR::InjectedBundlePage::InjectedBundlePage):
1091         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1092         (WTR):
1093         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1094         (InjectedBundlePage):
1095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1096         (WTR::TestRunner::TestRunner):
1097         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1098         (WTR):
1099         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1100         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1101         (TestRunner):
1102         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1103         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1104
1105 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1106
1107         [chromium] remove deprecated and unused sets import from chromium_android driver
1108         https://bugs.webkit.org/show_bug.cgi?id=96485
1109
1110         Reviewed by Dirk Pranke.
1111
1112         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1113
1114 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1115
1116         Flakiness dashboard doesn't recognize new Chromium Android test builder
1117         https://bugs.webkit.org/show_bug.cgi?id=96523
1118
1119         Reviewed by Ojan Vafai.
1120
1121         Properly return 'ANDROID' as the Chromium platform for Android builders.
1122
1123         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1124         (chromiumPlatform):
1125         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1126         (test):
1127
1128 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1129
1130         [Qt] Build on Windows requires bison/flex in PATH
1131         https://bugs.webkit.org/show_bug.cgi?id=96358
1132
1133         Reviewed by Tor Arne Vestbø.
1134
1135         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1136         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1137         a separate installation of various GNU tools is required as the operating system doesn't come with
1138         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1139         the gnuwin32 directory of the qt5.git top-level repository.
1140
1141         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1142
1143         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1144         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1145         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1146         updated with the new tool.
1147
1148         * Scripts/webkitdirs.pm:
1149         (checkRequiredSystemConfig):
1150         * qmake/mkspecs/features/default_post.prf:
1151
1152 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1153
1154         [Qt] Update build-jsc after r128174
1155
1156         Reviewed by Ossy.
1157
1158         * Scripts/build-jsc:
1159
1160 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1161
1162         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1163
1164         By hard-coding the names of the targets we defined we ended up just
1165         redefining the previous target when using addStrictSubdirOrderBetween
1166         more than once in a single project file.
1167
1168         We now embed the two base targets into the target names.
1169
1170         Reviewed by Simon Hausmann.
1171
1172         * qmake/mkspecs/features/functions.prf:
1173
1174 2012-09-12  Philippe Liard  <pliard@google.com>
1175
1176         Depend on {base,net} GYP targets rather than {base,net}_java.
1177         https://bugs.webkit.org/show_bug.cgi?id=95690
1178
1179         Reviewed by Adam Barth.
1180
1181         {base,net}_java became 'private' targets on the Chromium side that
1182         clients should not depend on (see
1183         https://chromiumcodereview.appspot.com/10913083/).
1184         This removes a bunch of trailing white spaces additionally in
1185         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1186
1187         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1188         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1189
1190 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1191
1192         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1193         https://bugs.webkit.org/show_bug.cgi?id=96494
1194
1195         Reviewed by Tor Arne Vestbø.
1196
1197         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1198         plugin process feature if we don't have NPAPI.
1199
1200         * qmake/mkspecs/features/features.prf:
1201
1202 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1203
1204         Unreviewed, rolling out r128280.
1205         http://trac.webkit.org/changeset/128280
1206         https://bugs.webkit.org/show_bug.cgi?id=96498
1207
1208         it broke compilation on windows debug bot (Requested by loislo
1209         on #webkit).
1210
1211         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1213         (WTR::InjectedBundlePage::InjectedBundlePage):
1214         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1215         (InjectedBundlePage):
1216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1217         (WTR::TestRunner::TestRunner):
1218         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1219         (TestRunner):
1220
1221 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1222
1223         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1224         https://bugs.webkit.org/show_bug.cgi?id=96488
1225
1226         Reviewed by Tor Arne Vestbø.
1227
1228         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1229         because there are no such targets. We want the generated sources to be independent from release
1230         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1231         redirect to the same general-purpose target (first) of creating the derived sources.
1232
1233         * qmake/mkspecs/features/default_post.prf:
1234
1235 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1236
1237         [EFL] Make DumpRenderTree smarter at finding the fonts
1238         http://webkit.org/b/96281
1239
1240         Reviewed by Gyuyoung Kim.
1241
1242         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1243         Use CString consistently.
1244
1245         * DumpRenderTree/efl/FontManagement.cpp:
1246         (buildPath):
1247         (getCoreFontFiles):
1248         (addFontDirectory):
1249         (addFontFiles):
1250         (getCustomBuildDir):
1251         (getPlatformFontsPath):
1252         (addFontsToEnvironment):
1253
1254 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1255
1256         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1257         https://bugs.webkit.org/show_bug.cgi?id=96374
1258
1259         Reviewed by Kenneth Rohde Christiansen.
1260
1261         Implement support for dumpApplicationCacheDelegateCallbacks
1262         and disallowIncreaseForApplicationCacheQuota in
1263         WebKitTestRunner and properly dump the information
1264         expected by the tests.
1265
1266         If the application cache quota is reached for a given
1267         security origin, WebKitTestRunner will reset the quota
1268         to its default value, unless intructed not to via
1269         disallowIncreaseForApplicationCacheQuota().
1270
1271         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1273         (WTR::InjectedBundlePage::InjectedBundlePage):
1274         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1275         (WTR):
1276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1277         (InjectedBundlePage):
1278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1279         (WTR::TestRunner::TestRunner):
1280         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1281         (WTR):
1282         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1283         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1284         (TestRunner):
1285         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1286         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1287
1288 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1289
1290         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1291         https://bugs.webkit.org/show_bug.cgi?id=96388
1292
1293         Reviewed by Kenneth Rohde Christiansen.
1294
1295         Exported TestRunner.workerThreadCount as readonly attribute.
1296
1297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1299         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1300         (WTR):
1301         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1302         (TestRunner):
1303
1304 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1305
1306         [chromium] Consume a user gesture when creating a new view.
1307         https://bugs.webkit.org/show_bug.cgi?id=96373
1308
1309         Reviewed by Adam Barth.
1310
1311         * DumpRenderTree/chromium/WebViewHost.cpp:
1312         (WebViewHost::createView):
1313
1314 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1315
1316         [WK2][WTR] Some of TestRunner special options are not reset before testing
1317         https://bugs.webkit.org/show_bug.cgi?id=96384
1318
1319         Reviewed by Kenneth Rohde Christiansen.
1320
1321         Now values of the following special options are reset:
1322         void setAcceptsEditing(in boolean value);
1323         void setCloseRemainingWindowsWhenComplete(in boolean value);
1324         void setXSSAuditorEnabled(in boolean value);
1325         void setAllowFileAccessFromFileURLs(in boolean value);
1326         void setPluginsEnabled(in boolean value);
1327         void setPopupBlockingEnabled(in boolean value);
1328
1329         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1330         (WTR::InjectedBundle::beginTesting):
1331
1332 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1333
1334         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1335         https://bugs.webkit.org/show_bug.cgi?id=96273
1336
1337         Reviewed by Gyuyoung Kim.
1338
1339         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1340         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1341
1342         * WebKitTestRunner/CMakeLists.txt:
1343
1344 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1345
1346         [chromium] rename webkit_resources
1347         https://bugs.webkit.org/show_bug.cgi?id=95874
1348
1349         Reviewed by James Robinson.
1350
1351         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1352
1353 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1354
1355         [chromium] don't include content shell builders in the garden-o-matic view
1356         https://bugs.webkit.org/show_bug.cgi?id=96418
1357
1358         Reviewed by James Robinson.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1361
1362 2012-09-11  Adam Klein  <adamk@chromium.org>
1363
1364         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1365         https://bugs.webkit.org/show_bug.cgi?id=96411
1366
1367         Reviewed by Adam Barth.
1368
1369         Previously only the exact string "warning" was treated as a warning
1370         result. This patch treats any string with "warning" as a substring
1371         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1372
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1374         (.):
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1376
1377 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1378
1379         Restore original value of mock scrollbars enabled in InternalSettings
1380         https://bugs.webkit.org/show_bug.cgi?id=87680
1381
1382         Reviewed by Adam Barth.
1383
1384         Added backup support for mock scrollbars state in
1385         InternalSettings::Backup, and removed support for these
1386         from Qt's DumpRenderTree.
1387
1388         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1389         (WebCore::WebPage::resetSettings):
1390         * DumpRenderTree/qt/TestRunnerQt.cpp:
1391         (TestRunner::setFrameFlatteningEnabled):
1392         * DumpRenderTree/qt/TestRunnerQt.h:
1393         (TestRunner):
1394
1395 2012-09-11  Dan Bernstein  <mitz@apple.com>
1396
1397         Fixed a bug where kill-old-processes failed to kill clang++.
1398
1399         Rubber-stamped by Alexey Proskuryakov.
1400
1401         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1402         where it is passed as a regular expression to killall.
1403
1404 2012-09-11  Philippe Liard  <pliard@google.com>
1405
1406         Make sure that md5sum is not setup on non-Chromium Android platforms.
1407         https://bugs.webkit.org/show_bug.cgi?id=96393
1408
1409         Reviewed by Adam Barth.
1410
1411         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1412         which is also invoked on non-Chromium Android platforms. The following patch
1413         moves this logic to _startup_test() which is guaranteed to be invoked
1414         only on Android.
1415
1416         This also updates the prompt unit test in chromium_android_unittest.py.
1417
1418         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1419         (ChromiumAndroidDriver.__init__):
1420         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1421         (ChromiumAndroidDriver._setup_test):
1422
1423 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1424
1425         [EFL] Rewrite the EFL-related Find modules
1426         https://bugs.webkit.org/show_bug.cgi?id=95237
1427
1428         Reviewed by Kenneth Rohde Christiansen.
1429
1430         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1431         property and include all the Enlightenment Foundation Libraries
1432         required by the target.
1433         * EWebLauncher/CMakeLists.txt: Ditto.
1434         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1435         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1436         now that they are not added implicitly.
1437         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1438         property.
1439         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1440         property and include all the Enlightenment Foundation Libraries
1441         required by the target.
1442
1443 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1444
1445         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1446         https://bugs.webkit.org/show_bug.cgi?id=96379
1447
1448         Reviewed by Kenneth Rohde Christiansen.
1449
1450         Add implementation for setApplicationCacheOriginQuota
1451         to WebKitTestRunner.
1452
1453         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1455         (WTR::TestRunner::setApplicationCacheOriginQuota):
1456         (WTR):
1457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1458         (TestRunner):
1459
1460 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1461
1462         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1463         https://bugs.webkit.org/show_bug.cgi?id=91988
1464
1465         Reviewed by Kenneth Rohde Christiansen.
1466
1467         Regular key events generated by Qt for the tab key fill both
1468         keyCode and keyText, so we should do the same for our fake events.
1469
1470         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1471         (WTR::EventSenderProxy::keyDown):
1472
1473 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1474
1475         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1476         https://bugs.webkit.org/show_bug.cgi?id=96269
1477
1478         Reviewed by Kenneth Rohde Christiansen.
1479
1480         Exported missing testRunner.setSpatialNavigationEnabled() method.
1481
1482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1484         (WTR::InjectedBundle::beginTesting):
1485         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1486         (WTR::TestRunner::setSpatialNavigationEnabled):
1487         (WTR):
1488         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1489         (TestRunner):
1490
1491 2012-09-11  Philippe Liard  <pliard@chromium.org>
1492
1493         Support LayoutTests on non-rooted devices for Chromium Android.
1494         https://bugs.webkit.org/show_bug.cgi?id=95346
1495
1496         Reviewed by Dirk Pranke.
1497
1498         We were requiring root permissions to sync resource files with the
1499         device by comparing host and device files' timestamp after we
1500         synchronized the device and host clocks.
1501         We now rely on md5sum provided by Chromium to handle data files
1502         synchronization.
1503
1504         * Scripts/webkitpy/layout_tests/port/chromium.py:
1505         (ChromiumPort._check_driver_build_up_to_date):
1506         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1507         (ChromiumAndroidDriver.__init__):
1508         (ChromiumAndroidDriver._setup_test):
1509         (ChromiumAndroidDriver._push_executable):
1510         (ChromiumAndroidDriver._push_test_resources):
1511         (ChromiumAndroidDriver._read_prompt):
1512
1513 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1514
1515         [Qt] Fix output paths on Windows
1516
1517         Reviewed by Tor Arne Vestbø.
1518
1519         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1520         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1521         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1522         incorrect here and instead for the calculation we should use forward slashes.
1523
1524         * qmake/mkspecs/features/default_pre.prf:
1525
1526 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1527
1528         [Qt] Fix passing of defines from the build system
1529
1530         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1531         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1532         will add it's own defaults if the features are not defined.
1533
1534         At some point we might want to run a configure-test to inspect what
1535         Platform.h will do, so we can sync up the build system's view of
1536         the feature-defines with the compile-time situation.
1537
1538         Reviewed by Simon Hausmann.
1539
1540         * qmake/mkspecs/features/functions.prf:
1541
1542 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1543
1544         [Qt] Fix --qt option to build-webkit
1545
1546         Reviewed by Ossy.
1547
1548         * Scripts/webkitdirs.pm:
1549         (buildQMakeProjects):
1550
1551 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1552
1553         [Qt] Add a configure step to the Qt build system
1554
1555         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1556         the build-webkit script is still supported, and will add slightly more
1557         logic to the build, such as detecting the need for clean or incremental
1558         builds.
1559
1560         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1561         all things related to configuring the build, such as use/have/enable flags,
1562         and these are translated to defines in default_post. Project files should
1563         no longer check contains(DEFINES,...) to detect features, but use the new
1564         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1565         options have been translated into WEBKIT_CONFIG options as well, and can
1566         be checked using build?().
1567
1568         Reviewed by Simon Hausmann.
1569
1570         * DumpRenderTree/qt/DumpRenderTree.pro:
1571         * MiniBrowser/qt/MiniBrowser.pro:
1572         * QtTestBrowser/QtTestBrowser.pro:
1573         * Scripts/build-webkit:
1574         * Scripts/webkitdirs.pm:
1575         (qtFeatureDefaults):
1576         (buildQMakeProjects):
1577         * Tools.pro:
1578         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1579         * WebKitTestRunner/InjectedBundle/Target.pri:
1580         * WebKitTestRunner/Target.pri:
1581         * qmake/.qmake.cache: Added.
1582         * qmake/configure.pri: Removed.
1583         * qmake/configure.pro: Removed.
1584         * qmake/dump-features: Added.
1585         * qmake/mkspecs/features/configure.prf: Added.
1586         * qmake/mkspecs/features/default_post.prf:
1587         * qmake/mkspecs/features/default_pre.prf:
1588         * qmake/mkspecs/features/features.prf:
1589         * qmake/mkspecs/features/features.pri:
1590         * qmake/mkspecs/features/functions.prf:
1591         * qmake/mkspecs/features/gprof.prf:
1592         * qmake/mkspecs/features/mac/default_pre.prf:
1593         * qmake/mkspecs/features/win32/default_pre.prf:
1594
1595 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1596
1597         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1598         https://bugs.webkit.org/show_bug.cgi?id=96372
1599
1600         Reviewed by Kenneth Rohde Christiansen.
1601
1602         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1603
1604         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1606         (WTR::TestRunner::clearApplicationCacheForOrigin):
1607         (WTR):
1608         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1609         (TestRunner):
1610
1611 2012-09-11  Peter Beverloo  <peter@chromium.org>
1612
1613         Don't ignore .pak files when making an archive for Android
1614         https://bugs.webkit.org/show_bug.cgi?id=96375
1615
1616         Reviewed by Jochen Eisinger.
1617
1618         The .pak files do need to be pushed to the device, which is currently
1619         preventing the layout test runner from correctly pushing all files.
1620
1621         * BuildSlaveSupport/built-product-archive:
1622         (archiveBuiltProduct):
1623
1624 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1625
1626         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1627         https://bugs.webkit.org/show_bug.cgi?id=96256
1628
1629         Reviewed by Kenneth Rohde Christiansen.
1630
1631         Exported TestRunner::setMinimumTimerInterval() method.
1632
1633         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1634         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1635         (WTR::InjectedBundle::beginTesting):
1636         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1637         (WTR::TestRunner::setMinimumTimerInterval):
1638         (WTR):
1639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1640         (TestRunner):
1641
1642 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1643
1644         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1645         https://bugs.webkit.org/show_bug.cgi?id=96097
1646
1647         Reviewed by Adam Barth.
1648
1649         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1650         (MockWebRTCPeerConnectionHandler::addStream):
1651         (MockWebRTCPeerConnectionHandler::removeStream):
1652
1653 2012-09-11  Peter Beverloo  <peter@chromium.org>
1654
1655         Recognize the "--chromium-android" argument in run-webkit-tests
1656         https://bugs.webkit.org/show_bug.cgi?id=96369
1657
1658         Reviewed by Jochen Eisinger.
1659
1660         Chromium for the Android platform cannot determine the platform based on
1661         the host itself, so we'll use the --chromium-android argument as the build
1662         master passes to run-webkit-tests. Make sure the layout test runner
1663         can pick the right port when doing so.
1664
1665         * Scripts/run-webkit-tests:
1666         * Scripts/webkitpy/layout_tests/port/factory.py:
1667         (port_options):
1668
1669 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1670
1671         [QT] Fix build with newer qmake from Qt 5
1672
1673         Rubber-stamped by Tor Arne Vestbø.
1674
1675         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1676         it with the use of QT_HOST_DATA/mkspecs.
1677         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1678
1679         * Scripts/webkitdirs.pm:
1680         (builtDylibPathForName):
1681         (qtMakeCommand):
1682
1683 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1684
1685         [Qt] Remove Qt 4 syncqt, no longer needed
1686
1687         Reviewed by Simon Hausmann.
1688
1689         * qmake/syncqt-4.8: Removed.
1690
1691 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1692
1693         [Qt][WK2] Fix the build with recent Qt5
1694         https://bugs.webkit.org/show_bug.cgi?id=96283
1695
1696         Reviewed by Simon Hausmann.
1697
1698         We should not use deprecated Qt API because doing that results
1699         in build failure since all the deprecated API was disabled
1700         in qtbase (https://codereview.qt-project.org/#change,24890).
1701
1702         * DumpRenderTree/qt/main.cpp:
1703         (main):
1704         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1705         (MiniBrowserApplication::notify):
1706         * MiniBrowser/qt/raw/View.cpp:
1707         (View::exposeEvent):
1708         (main):
1709
1710 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1711
1712         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1713         https://bugs.webkit.org/show_bug.cgi?id=87188
1714
1715         Reviewed by Kenneth Rohde Christiansen.
1716
1717         Add implementation for applicationCacheDiskUsageForOrigin()
1718         in WebKitTestRunner.
1719
1720         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1722         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1723         (WTR):
1724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1725         (TestRunner):
1726
1727 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1728
1729         Properly expose <legend> elements to ATs
1730         https://bugs.webkit.org/show_bug.cgi?id=84137
1731
1732         Reviewed by Chris Fleizach.
1733
1734         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1735         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1736         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1737
1738         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1739         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1740
1741 2012-09-10  Jer Noble  <jer.noble@apple.com>
1742
1743         Unreviewed; rolling out r128081.
1744         http://trac.webkit.org/changeset/128081
1745         https://bugs.webkit.org/show_bug.cgi?id=96134
1746
1747         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1748
1749         * DumpRenderTree/TestRunner.cpp:
1750         (TestRunner::TestRunner):
1751         (TestRunner::staticFunctions):
1752         * DumpRenderTree/TestRunner.h:
1753         (TestRunner):
1754         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1755         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1756         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1757         (WTR::InjectedBundlePage::InjectedBundlePage):
1758         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1759         (InjectedBundlePage):
1760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1761         (WTR::TestRunner::TestRunner):
1762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1763         (TestRunner):
1764
1765 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1766
1767         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1768         https://bugs.webkit.org/show_bug.cgi?id=96205
1769
1770         Reviewed by Tony Chang.
1771
1772         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1773         internally, which means that it would support only 1 TestExpectations file per port. This
1774         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1775         and efl-wk1 -> efl).
1776
1777         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1778         instead so that all the ports TestExpectations are recognized. The ports are also
1779         constructed twice, with "webkit_test_runner" option set to True and False so that we
1780         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1781
1782         * Scripts/webkitpy/style/checkers/test_expectations.py:
1783         (TestExpectationsChecker._determine_port_from_expectations_path):
1784         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1785         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1786
1787 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1788
1789         [WTR] Generated source files should include config.h
1790         https://bugs.webkit.org/show_bug.cgi?id=96254
1791
1792         Reviewed by Benjamin Poulain.
1793
1794         Current coding style has encouraged to include config.h at the first position,
1795         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1796         this rule.
1797         Therefore, this patch added it.
1798
1799         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1800         (_generateImplementationFile):
1801
1802 2012-09-10  Rick Byers  <rbyers@chromium.org>
1803
1804         Add handling of new GestureTapCancel in DRT
1805         
1806         https://bugs.webkit.org/show_bug.cgi?id=96183
1807
1808         Reviewed by Adam Barth.
1809
1810         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1811         (TestWebPlugin::handleInputEvent):
1812
1813 2012-09-10  Brady Eidson  <beidson@apple.com>
1814
1815         Javascript in foreground tabs should not wait synchronously for plug-ins to load
1816         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
1817
1818         Reviewed by Geoff Garen.
1819
1820         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
1821
1822         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
1823         (PluginObject):
1824         (SlowNPPNew::PluginObject::PluginObject):
1825         (SlowNPPNew::PluginObject::~PluginObject):
1826         (SlowNPPNew::PluginObject::hasProperty):
1827         (SlowNPPNew::PluginObject::getProperty):
1828         (SlowNPPNew::NPP_GetValue):
1829         (SlowNPPNew):
1830
1831 2012-09-10  Tim Horton  <timothy_horton@apple.com>
1832
1833         WKTR often reports an unresponsive WebProcess on Mac bots
1834         https://bugs.webkit.org/show_bug.cgi?id=95906
1835
1836         Reviewed by Dan Bernstein.
1837
1838         Attempt to work around resource contention issues by increasing the NRWT
1839         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
1840
1841         * Scripts/webkitpy/layout_tests/port/base.py:
1842         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
1845
1846 2012-09-07  Jer Noble  <jer.noble@apple.com>
1847
1848         <audio> and <video> should send Do Not Track when appropriate
1849         https://bugs.webkit.org/show_bug.cgi?id=96134
1850
1851         Reviewed by Eric Carlson.
1852
1853         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
1854         WTR. Add FrameLoaderClient client methods for retrieving that value.
1855
1856         * DumpRenderTree/TestRunner.cpp:
1857         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
1858         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
1859         * DumpRenderTree/TestRunner.h:
1860         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
1861         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1862         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1863         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
1864             Pass the question on to the TestRunner.
1865         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1866         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1867         (WTR::InjectedBundlePage::InjectedBundlePage):
1868             Add the setShouldSendDoNotTrackHTTPHeader client function.
1869         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
1870             Pass the question on to the TestRunner.
1871         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1873         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1874         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1875         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
1876
1877 2012-09-10  Ojan Vafai  <ojan@chromium.org>
1878
1879         Make EFL bots work on the flakiness dashboard
1880         https://bugs.webkit.org/show_bug.cgi?id=96164
1881
1882         Reviewed by Tony Chang.
1883
1884         Also, update outdated unittests that had started failing.
1885
1886         * TestResultServer/static-dashboards/builders.js:
1887         (isWebkitTestRunner):
1888         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1889         (nonChromiumPlatform):
1890         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1891         (test):
1892
1893 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
1894
1895         [chromium] MediaStream API: Remove the Descriptor postfix
1896         https://bugs.webkit.org/show_bug.cgi?id=96268
1897
1898         Reviewed by Adam Barth.
1899
1900         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
1901         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
1902
1903         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1904         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1905         (MockWebRTCPeerConnectionHandler::createOffer):
1906         (MockWebRTCPeerConnectionHandler::createAnswer):
1907         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1908         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1909         (MockWebRTCPeerConnectionHandler::localDescription):
1910         (MockWebRTCPeerConnectionHandler::remoteDescription):
1911         (MockWebRTCPeerConnectionHandler::addICECandidate):
1912         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1913         (MockWebRTCPeerConnectionHandler):
1914
1915 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1916
1917         [Gtk] failure to build jhbuild dependencies with cups 1.6
1918         https://bugs.webkit.org/show_bug.cgi?id=95991
1919
1920         Reviewed by Gustavo Noronha Silva.
1921
1922         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
1923         building with cups >= 1.6 [GNOME #670373].
1924
1925         * gtk/jhbuild.modules:
1926
1927 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1928
1929         [EFL][DRT] Encoding issue in printed console messages
1930         https://bugs.webkit.org/show_bug.cgi?id=96263
1931
1932         Reviewed by Kenneth Rohde Christiansen.
1933
1934         Correctly handle CONSOLE messages that contain non-ascii
1935         characters in EFL's DRT. We need to use String::fromUTF8()
1936         to construct a WTF::String from a raw string.
1937
1938         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1939         (onConsoleMessage):
1940
1941 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1942
1943         [WK2][WTR] User style sheet location should be reset before each test
1944         https://bugs.webkit.org/show_bug.cgi?id=96262
1945
1946         Reviewed by Kenneth Rohde Christiansen.
1947
1948         User style sheet location is reset before each test now.
1949
1950         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1951         (WTR::InjectedBundle::beginTesting):
1952
1953 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
1954
1955         Fix build of WTR with Qt on Windows
1956         https://bugs.webkit.org/show_bug.cgi?id=96249
1957
1958         Reviewed by Kenneth Rohde Christiansen.
1959
1960         Windows loves to define min and max as macros, which beautifully
1961         clashes in many places where min and max are used as variable or method
1962         names. It can be convinced not to do this when min and max are already
1963         define as macros (expanding to themselves). We have this kind of
1964         workaround in config.h files all over WebKit and as it turns out when
1965         building WTR with Qt on Windows we do end up with such a clash. Therefore
1966         we need the same workaround.
1967
1968         * WebKitTestRunner/config.h:
1969
1970 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1971
1972         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
1973         https://bugs.webkit.org/show_bug.cgi?id=95936
1974
1975         Reviewed by Kenneth Rohde Christiansen.
1976
1977         Enable interactive form validation setting in WebKitTestRunner as
1978         we are currently doing in DumpRenderTree. This is needed for some
1979         tests to pass.
1980
1981         * WebKitTestRunner/TestController.cpp:
1982         (WTR::TestController::resetStateToConsistentValues):
1983
1984 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
1985
1986         Clean up the code in XvfbDriver
1987         https://bugs.webkit.org/show_bug.cgi?id=96202
1988
1989         Reviewed by Philippe Normand.
1990
1991         Changes:
1992         - Remove unneeded imports,
1993         - assign the _lock_file member variable when the display number is determined,
1994         - no need for parentheses around a single string format argument,
1995         - use FileSystem.exists method when checking if lock file is present as it
1996         makes the intention much more clearer.
1997
1998         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1999         (XvfbDriver._start):
2000         (XvfbDriver.stop):
2001
2002 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2003
2004         Make the String initialization on the function side of String::number()
2005         https://bugs.webkit.org/show_bug.cgi?id=95940
2006
2007         Reviewed by Benjamin Poulain.
2008
2009         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2010         (testBoundaries):
2011         (testNumbers):
2012
2013 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2014
2015         [WK2] expose element rect for color input type
2016         https://bugs.webkit.org/show_bug.cgi?id=91664
2017
2018         Reviewed by Simon Hausmann.
2019
2020         Update the QML logic in MiniBrowser to take advantage of this.
2021         The picker size is now hardcoded and we try to place it below the
2022         input element if possible.
2023
2024         * MiniBrowser/qt/qml/ColorChooser.qml:
2025
2026 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2027
2028         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2029         https://bugs.webkit.org/show_bug.cgi?id=95329
2030
2031         Reviewed by Kenneth Rohde Christiansen.
2032
2033         Explicitely disable TabToLinks setting in WebKitTestRunner.
2034         Tests override the "WebKitTabToLinksPreferenceKey" preference
2035         to enable it.
2036
2037         * WebKitTestRunner/TestController.cpp:
2038         (WTR::TestController::resetStateToConsistentValues):
2039
2040 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2041
2042         webkit.py gdb pretty printer can't print CString
2043         https://bugs.webkit.org/show_bug.cgi?id=96068
2044
2045         Reviewed by Tony Chang.
2046
2047         Update WTFCStringPrinter to follow r126191.
2048
2049         * gdb/webkit.py:
2050         (WTFCStringPrinter.to_string):
2051
2052 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2053
2054         Rename the ustring() accessor to string()
2055         https://bugs.webkit.org/show_bug.cgi?id=95919
2056
2057         Reviewed by Geoffrey Garen.
2058
2059         Update EFL's DRT.
2060
2061         Fix some string conversion that have been made useless
2062         with recent changes.
2063
2064         * DumpRenderTree/efl/EventSender.cpp:
2065         (keyPadNameFromJSValue):
2066         (keyNameFromJSValue):
2067         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2068         (TestRunner::queueLoad):
2069         (TestRunner::addOriginAccessWhitelistEntry):
2070         (TestRunner::removeOriginAccessWhitelistEntry):
2071         (TestRunner::setUserStyleSheetLocation):
2072         (TestRunner::setValueForUser):
2073         (TestRunner::elementDoesAutoCompleteForElementWithId):
2074         (TestRunner::execCommand):
2075         (TestRunner::findString):
2076         (TestRunner::isCommandEnabled):
2077         (TestRunner::clearApplicationCacheForOrigin):
2078         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2079         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2080         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2081         (toInt):
2082         (TestRunner::overridePreference):
2083         (TestRunner::addUserScript):
2084         (TestRunner::addUserStyleSheet):
2085         (TestRunner::evaluateInWebInspector):
2086         (TestRunner::evaluateScriptInIsolatedWorld):
2087         (TestRunner::setTextDirection):
2088         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2089         (LoadItem::invoke):
2090         (LoadHTMLStringItem::invoke):
2091         (ScriptItem::invoke):
2092
2093 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2094
2095         Extend third-party storage blocking API to optionally allow blocking all storage
2096         https://bugs.webkit.org/show_bug.cgi?id=95915
2097
2098         Reviewed by Brady Eidson.
2099
2100         Modified API test to use new revised API.
2101
2102         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2103         (TestWebKitAPI::TEST):
2104
2105 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2106
2107         AX: WebCore accessibility roles should be cross-platform
2108         https://bugs.webkit.org/show_bug.cgi?id=94870
2109
2110         Reviewed by Chris Fleizach.
2111
2112         Add debug strings to Chromium for new accessibility roles.
2113
2114         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2115         (roleToString):
2116
2117 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2118
2119         AX: Chromium needs access to canvasHasFallbackContent
2120         https://bugs.webkit.org/show_bug.cgi?id=96124
2121
2122         Reviewed by Chris Fleizach.
2123
2124         Distinguish between canvas roles with and without fallback
2125         content on Chromium.
2126
2127         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2128         (getRole):
2129
2130 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2131
2132         Handle non-existant TestExpectations files gracefully
2133         https://bugs.webkit.org/show_bug.cgi?id=96149
2134
2135         Reviewed by Eric Seidel.
2136
2137         Even when we get rid of Skipped files, we shouldn't have each port
2138         require a TestExpectations file for each platform if it doesn't
2139         need one.
2140
2141         * Scripts/webkitpy/layout_tests/port/base.py:
2142         (Port.expectations_dict):
2143         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2144         (PortTest.test_nonexistant_expectations):
2145
2146 2012-09-07  Tony Chang  <tony@chromium.org>
2147
2148         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2149         https://bugs.webkit.org/show_bug.cgi?id=96136
2150
2151         Reviewed by Ojan Vafai.
2152
2153         When we renamed the file to TestExpectations, it was no longer considered a text file so
2154         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2155         from the port object, so I've removed that from the check. I'm not sure what it was
2156         supposed to do.
2157
2158         * Scripts/webkitpy/style/checker.py:
2159         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2160         * Scripts/webkitpy/style/checkers/test_expectations.py:
2161         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2162         (TestExpectationsChecker.check): Remove overrides param.
2163         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2164         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2165
2166 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2167
2168         [EFL] Use same default minimum logical font size in DRT and WTR
2169         https://bugs.webkit.org/show_bug.cgi?id=96116
2170
2171         Reviewed by Martin Robinson.
2172
2173         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2174         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2175         logical font size to 9 to match the value used in WTR.
2176         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2177         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2178         logical font size to 9 (default value in WK2)
2179
2180 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2181
2182         MediaStream API: add RTCPeerConnection::createAnswer
2183         https://bugs.webkit.org/show_bug.cgi?id=96092
2184
2185         Reviewed by Adam Barth.
2186
2187         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2188
2189         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2190         (MockWebRTCPeerConnectionHandler::createOffer):
2191         (MockWebRTCPeerConnectionHandler::createAnswer):
2192         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2193         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2194         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2195         (MockWebRTCPeerConnectionHandler):
2196
2197 2012-09-07  Dean Jackson  <dino@apple.com>
2198
2199         Unreviewed changes to watchlist.
2200
2201         - Add new WebGL and Filters definitions
2202         - Add myself to OpenGL bugs
2203
2204         * Scripts/webkitpy/common/config/watchlist:
2205
2206 2012-09-07  Peter Beverloo  <peter@chromium.org>
2207
2208         Actually trigger the Android Tester
2209         https://bugs.webkit.org/show_bug.cgi?id=96118
2210
2211         Reviewed by Adam Barth.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/config.json:
2214
2215 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2216
2217         New time input needs accessibility
2218         https://bugs.webkit.org/show_bug.cgi?id=96032
2219
2220         Reviewed by Chris Fleizach.
2221
2222         Add support for valueDescription for testing.
2223
2224         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2225         (getValueDescription):
2226         (AccessibilityUIElement::AccessibilityUIElement):
2227         (AccessibilityUIElement::valueDescriptionGetterCallback):
2228         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2229         (AccessibilityUIElement):
2230
2231 2012-09-07  Peter Beverloo  <peter@chromium.org>
2232
2233         Add the google-android-tests build slave to the master's config
2234         https://bugs.webkit.org/show_bug.cgi?id=96113
2235
2236         Reviewed by Csaba Osztrogonác.
2237
2238         * BuildSlaveSupport/build.webkit.org-config/config.json:
2239
2240 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2241
2242         [WK2] [EFL] Set theme for WebKit2 API test runner
2243         https://bugs.webkit.org/show_bug.cgi?id=96100
2244
2245         Reviewed by Kenneth Rohde Christiansen.
2246
2247         Set the theme generated by the build for the WebKit2 API test runner.
2248
2249         * TestWebKitAPI/PlatformEfl.cmake:
2250         * TestWebKitAPI/efl/PlatformWebView.cpp:
2251         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2252
2253 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         Unreviewed. Add Gábor Ballabás as contributor.
2256
2257         * Scripts/webkitpy/common/config/committers.py:
2258
2259 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2260
2261         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2262         https://bugs.webkit.org/show_bug.cgi?id=96078
2263
2264         Reviewed by Tor Arne Vestbø.
2265
2266         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2267
2268         * qmake/mkspecs/features/default_pre.prf:
2269
2270 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2271
2272         [EFL] Add TestExpectations file for efl-wk1
2273         https://bugs.webkit.org/show_bug.cgi?id=96019
2274
2275         Reviewed by Gyuyoung Kim.
2276
2277         Update TestExpectations cascading for EFL port
2278         so that we use efl-wk1 -> efl search paths
2279         for WebKit1 EFL.
2280
2281         * Scripts/webkitpy/layout_tests/port/efl.py:
2282         (EflPort._search_paths):
2283
2284 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2285
2286         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2287         https://bugs.webkit.org/show_bug.cgi?id=95097
2288
2289         Reviewed by Dirk Pranke.
2290
2291         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2292         terminating the process does not always work as expected, leading to timeouts
2293         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2294         as it's not removed by the killed Xvfb process.
2295
2296         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2297         is tested in different circumstances - whether pixel tests are enabled or not,
2298         with an arbitrary worker number or with an Xorg process already running on the system.
2299         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2300         and then set to None.
2301
2302         * BuildSlaveSupport/kill-old-processes:
2303         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2304         is left running, potentially clogging up a display at a certain position.
2305         * Scripts/webkitpy/common/system/executive_mock.py:
2306         (MockExecutive.__init__):
2307         The _running_pids is now a dictionary with process names as keys and pids
2308         as values.
2309         (MockExecutive.check_running_pid):
2310         Check whether the passed-in pid is in the _running_pids dictionary's values.
2311         (MockExecutive):
2312         (MockExecutive.running_pids):
2313         This method returns the list of all the process pids of which the name passes
2314         through the process_name_filter.
2315         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2316         Use the Executive object of the port's host to check for running pids and open
2317         new subprocesses or kill them throughout the class.
2318         (XvfbDriver._start):
2319         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2320         start the server process after it's created.
2321         (XvfbDriver.stop):
2322         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2323         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2324         (XvfbDriverTest):
2325         (XvfbDriverTest.make_driver):
2326         (XvfbDriverTest.assertDriverStartSuccessful):
2327         (XvfbDriverTest.test_start_no_pixel_tests):
2328         (XvfbDriverTest.test_start_pixel_tests):
2329         (XvfbDriverTest.test_start_arbitrary_worker_number):
2330         (XvfbDriverTest.test_start_existing_xorg_process):
2331         (XvfbDriverTest.test_stop):
2332         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2333
2334 2012-09-06  Peter Beverloo  <peter@chromium.org>
2335
2336         Introduce the Chromium Android Release (Tests) bot
2337         https://bugs.webkit.org/show_bug.cgi?id=95980
2338
2339         Reviewed by Adam Barth.
2340
2341         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2342         which will be running layout tests on actual Android devices. Right now,
2343         four Galaxy Nexus phones are attached.
2344
2345         * BuildSlaveSupport/build.webkit.org-config/config.json:
2346
2347 2012-09-06  James Robinson  <jamesr@chromium.org>
2348
2349         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2350         https://bugs.webkit.org/show_bug.cgi?id=96007
2351
2352         Reviewed by Adrienne Walker.
2353
2354         Fixes initialization / settings code to use WebCompositorSupport.
2355
2356         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2357         (main):
2358         * DumpRenderTree/chromium/TestShell.cpp:
2359         (TestShell::initialize):
2360         (TestShell::setPerTilePaintingEnabled):
2361
2362 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2363
2364         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2365         https://bugs.webkit.org/show_bug.cgi?id=95995
2366
2367         Reviewed by Kenneth Rohde Christiansen.
2368
2369         Provide proper implementation for PlatformWebView::windowFrame()
2370         in EFL's WebKitTestRunner.
2371
2372         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2373         (WTR::PlatformWebView::windowFrame):
2374
2375 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2376
2377         Fix WTF.Lrint on 32-bit platforms
2378         https://bugs.webkit.org/show_bug.cgi?id=96003
2379
2380         Reviewed by Benjamin Poulain.
2381
2382         Fixed failing WTF.Lrint test on 32-bit platforms.
2383
2384         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2385         (TestWebKitAPI::TEST):
2386
2387 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2388
2389         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2390         https://bugs.webkit.org/show_bug.cgi?id=95839
2391
2392         Reviewed by Adam Barth.
2393
2394         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2395         up the task definitions a bit. There was no need to have them in the header file.
2396
2397         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2398         (RTCSessionDescriptionRequestSuccededTask):
2399         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2400         (RTCSessionDescriptionRequestFailedTask):
2401         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2402         (RTCVoidRequestTask):
2403         (RTCVoidRequestTask::RTCVoidRequestTask):
2404         (MockWebRTCPeerConnectionHandler::createOffer):
2405         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2406         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2407         (MockWebRTCPeerConnectionHandler::localDescription):
2408         (MockWebRTCPeerConnectionHandler::remoteDescription):
2409         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2410         (MockWebRTCPeerConnectionHandler):
2411
2412 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2413
2414         [Qt] Fix build on Mac OS X 10.6
2415         https://bugs.webkit.org/show_bug.cgi?id=95200
2416
2417         Reviewed by Tor Arne Vestbø.
2418
2419         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2420         10.7 and newer.
2421
2422         * qmake/mkspecs/features/features.prf:
2423
2424 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2425
2426         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2427         https://bugs.webkit.org/show_bug.cgi?id=95973
2428
2429         Reviewed by Kenneth Rohde Christiansen.
2430
2431         Correctly map "addSelectionKey" to "Control" modifier
2432         in WKTR's EventSender on other OSes than Mac OS X,
2433         instead of mapping it to the "Meta" modifier.
2434
2435         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2436         (WTR::parseModifier):
2437
2438 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2439
2440         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2441         https://bugs.webkit.org/show_bug.cgi?id=95710
2442
2443         Reviewed by Dirk Pranke.
2444
2445         The stdout / stderr output can be None so make sure
2446         we won't raise an exception in this case.
2447
2448         * Scripts/webkitpy/layout_tests/port/driver.py:
2449         (Driver.run_test):
2450
2451 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2452
2453         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2454         https://bugs.webkit.org/show_bug.cgi?id=95849
2455
2456         Reviewed by Kenneth Rohde Christiansen.
2457
2458         Sanitize URLs passed by the user as program
2459         argument or typed in the URL bar in order to
2460         be more tolerant.
2461
2462         * EWebLauncher/CMakeLists.txt:
2463         * EWebLauncher/main.c:
2464         (main):
2465         * EWebLauncher/url_bar.c:
2466         (_url_bar_url_get_with_protocol):
2467         (on_urlbar_key_down):
2468         * EWebLauncher/url_utils.c: Added.
2469         (has_scheme):
2470         (url_from_user_input): Add utility function to construct a
2471         URL from user input.
2472         * EWebLauncher/url_utils.h: Added.
2473         * MiniBrowser/efl/CMakeLists.txt:
2474         * MiniBrowser/efl/main.c:
2475         (main):
2476
2477 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2478
2479         [Qt] Various small Windows / MSVC build fixes
2480         https://bugs.webkit.org/show_bug.cgi?id=95934
2481
2482         Reviewed by Kenneth Rohde Christiansen.
2483
2484         setFocus takes a boolean as argument: Don't try to implicitly convert
2485         an enum to a boolean, MSVC doesn't like that. The intent here is to
2486         enable focus, so just pass true.
2487
2488         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2489         (WTR::PlatformWebView::focus):
2490
2491 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2492
2493         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2494         https://bugs.webkit.org/show_bug.cgi?id=95965
2495
2496         Reviewed by Tor Arne Vestbø.
2497
2498         Add ANGLE as a static library module to the Qt WebKit build system.
2499
2500         * qmake/mkspecs/features/default_post.prf:
2501         * qmake/mkspecs/modules/angle.prf: Added.
2502
2503 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2504
2505         [WK2] Make [Qt]ViewportHandler cross platform
2506         https://bugs.webkit.org/show_bug.cgi?id=91257
2507
2508         Reviewed by Kenneth Rohde Christiansen.
2509
2510         Remove initial scale from viewport info item since it is
2511         set to -1 after applied thus it does not hold any valuable
2512         information.
2513
2514         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2515
2516 2012-09-05  Tony Chang  <tony@chromium.org>
2517
2518         [chromium] Remove dependency on webkit_user_agent
2519         https://bugs.webkit.org/show_bug.cgi?id=95886
2520
2521         Reviewed by Adam Barth.
2522
2523         The code isn't used by DumpRenderTree.
2524
2525         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2526
2527 2012-09-05  Rick Byers  <rbyers@chromium.org>
2528
2529         Update chromium DumpRenderTree for new WebGestureEvent fields
2530         https://bugs.webkit.org/show_bug.cgi?id=95573
2531
2532         Reviewed by James Robinson.
2533
2534         Update EventSender to write gesture details into the appropriate
2535         type-specific WebGestureEvent fields.
2536         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2537         (EventSender::gestureEvent):
2538         (EventSender::gestureFlingStart):
2539
2540 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2541
2542         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2543         https://bugs.webkit.org/show_bug.cgi?id=95789
2544
2545         Reviewed by Ojan Vafai.
2546
2547         Fix miscalculation in log message.
2548
2549         * Scripts/webkitpy/layout_tests/views/printing.py:
2550         (Printer.print_found):
2551
2552 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2553
2554         Unreviewed, rolling out r127612, r127660, and r127664.
2555         http://trac.webkit.org/changeset/127612
2556         http://trac.webkit.org/changeset/127660
2557         http://trac.webkit.org/changeset/127664
2558         https://bugs.webkit.org/show_bug.cgi?id=95920
2559
2560         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2561         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2562         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2563         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2564         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2565         (MockWebRTCPeerConnectionHandler::createOffer):
2566         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2567         (MockWebRTCPeerConnectionHandler):
2568         (SuccessCallbackTask):
2569         (FailureCallbackTask):
2570
2571 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2572
2573         Ignore-metrics includes scroll offsets.
2574         https://bugs.webkit.org/show_bug.cgi?id=95845
2575
2576         Reviewed by Dirk Pranke.
2577
2578         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2579
2580         * Scripts/old-run-webkit-tests:
2581         (stripMetrics):
2582         * Scripts/webkitpy/layout_tests/port/driver.py:
2583         (DriverOutput):
2584
2585 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2586
2587         Unreviewed test fix.
2588
2589         Including a plugin source file into the build that was added in r127595.
2590
2591         * GNUmakefile.am:
2592
2593 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2594
2595         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2596         https://bugs.webkit.org/show_bug.cgi?id=95839
2597
2598         Reviewed by Adam Barth.
2599
2600         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2601         up the task definitions a bit. There was no need to have them in the header file.
2602
2603         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2604         (RTCSessionDescriptionRequestSuccededTask):
2605         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2606         (RTCSessionDescriptionRequestFailedTask):
2607         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2608         (RTCVoidRequestTask):
2609         (RTCVoidRequestTask::RTCVoidRequestTask):
2610         (MockWebRTCPeerConnectionHandler::createOffer):
2611         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2612         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2613         (MockWebRTCPeerConnectionHandler::localDescription):
2614         (MockWebRTCPeerConnectionHandler::remoteDescription):
2615         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2616         (MockWebRTCPeerConnectionHandler):
2617
2618 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2619
2620         [EFL] Remove '+=' usage in String
2621         https://bugs.webkit.org/show_bug.cgi?id=95808
2622
2623         Reviewed by Benjamin Poulain.
2624
2625         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2626
2627         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2628         (descriptionSuitableForTestResult):
2629
2630 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2631
2632         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2633         https://bugs.webkit.org/show_bug.cgi?id=95842
2634
2635         Reviewed by Kenneth Rohde Christiansen.
2636
2637         Provide proper implementation for TestRunner::pathToLocalResource()
2638         in EFL WKTR, identical to the one for DumpRenderTree.
2639
2640         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2641         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2642         are found my WebKitTestRunner.
2643
2644         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2645         (WTR::TestRunner::pathToLocalResource):
2646
2647 2012-09-05  Brady Eidson  <beidson@apple.com>
2648
2649         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2650         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2651
2652         Reviewed by Andy Estes.
2653
2654         Add a plug-in that always fails to initialize:
2655         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2656         (NPPNewFails):
2657         (NPPNewFails::NPPNewFails):
2658         (NPPNewFails::NPP_New):
2659
2660         Add it to all the project files:
2661         * DumpRenderTree/DumpRenderTree.gypi:
2662         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2663         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2664         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2665         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2666
2667 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2668
2669         [Qt] Fix makefile race condition between derived sources and target
2670
2671         r121966 removed too much of the old qmake logic, including the rule
2672         that ensured that qmake_all would not trigger dual runs of qmake --
2673         one of the derived sources -qmake-all rule, and one for making the
2674         derived sources.
2675
2676         We now follow a similar pattern as before, by introducing a custom
2677         target that explicitly depends on the derived sources' qmake-all before
2678         doing a manual run of make. That ensures a single qmake run for the derived
2679         sources.
2680
2681         https://bugs.webkit.org/show_bug.cgi?id=93847
2682
2683         Reviewed by Csaba Osztrogonác.
2684
2685         * qmake/mkspecs/features/functions.prf:
2686
2687 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2688
2689         WKTR doesn't implement dumpWillCacheResponse()
2690         https://bugs.webkit.org/show_bug.cgi?id=94607
2691
2692         Reviewed by Kenneth Rohde Christiansen.
2693
2694         Define shouldCacheResponse() callback in resource
2695         load client and provide implementation for
2696         dumpWillCacheResponse() in WebKitTestRunner.
2697
2698         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2700         (WTR::InjectedBundlePage::InjectedBundlePage):
2701         (WTR::InjectedBundlePage::shouldCacheResponse):
2702         (WTR):
2703         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2704         (InjectedBundlePage):
2705         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2706         (WTR::TestRunner::TestRunner):
2707         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2708         (WTR::TestRunner::dumpWillCacheResponse):
2709         (WTR::TestRunner::shouldDumpWillCacheResponse):
2710         (TestRunner):
2711
2712 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2713
2714         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2715         https://bugs.webkit.org/show_bug.cgi?id=92735
2716
2717         Reviewed by Hajime Morita.
2718
2719         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2720
2721         * DumpRenderTree/TestRunner.cpp:
2722         (TestRunner::staticFunctions):
2723         * DumpRenderTree/TestRunner.h:
2724         (TestRunner):
2725         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2726         (TestRunner::addUserStyleSheet):
2727         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2728         (DRTTestRunner::DRTTestRunner):
2729         (DRTTestRunner::hasCustomPageSizeStyle):
2730         * DumpRenderTree/chromium/DRTTestRunner.h:
2731         (DRTTestRunner):
2732         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2733         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2734         * DumpRenderTree/mac/TestRunnerMac.mm:
2735         * DumpRenderTree/qt/TestRunnerQt.cpp:
2736         (TestRunner::evaluateScriptInIsolatedWorld):
2737         * DumpRenderTree/qt/TestRunnerQt.h:
2738         (TestRunner):
2739         * DumpRenderTree/win/TestRunnerWin.cpp:
2740         * DumpRenderTree/wx/TestRunnerWx.cpp:
2741         (TestRunner::abortModal):
2742         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2743         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2744         (WTR):
2745         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2746         (TestRunner):
2747
2748 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2749
2750         [Qt] Automate the use of AllInOne files in the Qt build
2751         https://bugs.webkit.org/show_bug.cgi?id=95837
2752
2753         Reviewed by Tor Arne Vestbø.
2754
2755         New feature file that implements the all-in-one file automation by
2756         adding the requested all-in-one files to SOURCES and removing the files
2757         it includes from SOURCES.
2758
2759         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2760
2761 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2762
2763         Have NRWT log more output when crash logs are missing
2764         https://bugs.webkit.org/show_bug.cgi?id=95814
2765
2766         Reviewed by Dan Bernstein.
2767
2768         Log the stderr and stdout of the test, in order to provide slightly more
2769         context when the WebProcess times out while running tests.
2770
2771         * Scripts/webkitpy/layout_tests/port/driver.py:
2772         (Driver.run_test):
2773
2774 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2775
2776         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2777         https://bugs.webkit.org/show_bug.cgi?id=95770
2778
2779         Reviewed by Adam Barth.
2780
2781         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2782         (ChromiumAndroidDriver.__init__):
2783         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2784         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2785         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2786         (ChromiumAndroidDriver._push_executable):
2787         (ChromiumAndroidDriver._push_fonts):
2788         (ChromiumAndroidDriver._push_test_resources):
2789         (ChromiumAndroidDriver._run_adb_command):
2790         (ChromiumAndroidDriver._get_last_stacktrace):
2791         (ChromiumAndroidDriver._get_crash_log):
2792         (ChromiumAndroidDriver._start):
2793         (ChromiumAndroidDriver._start_once):
2794         (ChromiumAndroidDriver._start_once.deadlock_detector):
2795         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2796         (ChromiumAndroidDriverTest.test_get_crash_log):
2797
2798 2012-09-04  Satish Sampath  <satish@chromium.org>
2799
2800         Run git commands within the checkout directory
2801         https://bugs.webkit.org/show_bug.cgi?id=95742
2802
2803         Reviewed by Eric Seidel.
2804
2805         git commands run from scm/git.py are sometimes run with cwd set to the
2806         checkout_root and other times with whatever directory was the default cwd.
2807         Instead all these should run with the checkout root set as the cwd
2808         (except where we explicitly need a different path)
2809
2810         * Scripts/webkitpy/common/checkout/scm/git.py:
2811         (Git._run_git):
2812         (Git.find_checkout_root):
2813         (Git.discard_local_commits):
2814         (Git.local_commits):
2815         (Git.working_directory_is_clean):
2816         (Git.clean_working_directory):
2817         (Git.add_list):
2818         (Git.delete_list):
2819         (Git.exists):
2820         (Git._current_branch):
2821         (Git._changes_files_for_commit):
2822         (Git.revisions_changing_file):
2823         (Git.svn_revision):
2824         (Git._run_git_svn_find_rev):
2825         (Git.contents_at_revision):
2826         (Git.diff_for_file):
2827         (Git.show_head):
2828         (Git.committer_email_for_revision):
2829         (Git.apply_reverse_diff):
2830         (Git.revert_files):
2831         (Git.commit_with_message):
2832         (Git._commit_on_branch):
2833         (Git.svn_commit_log):
2834         (Git.last_svn_commit_log):
2835         (Git.svn_blame):
2836         (Git._branch_ref_exists):
2837         (Git.delete_branch):
2838         (Git.remote_merge_base):
2839         (Git.commit_locally_with_message):
2840         (Git.push_local_commits_to_server):
2841         (Git.commit_ids_from_commitish_arguments):
2842         (Git.commit_message_for_local_commit):
2843         (Git.files_changed_summary_for_commit):
2844
2845 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2846
2847         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
2848         https://bugs.webkit.org/show_bug.cgi?id=95734
2849
2850         Reviewed by Adam Barth.
2851
2852         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2853         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2854         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2855         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2856         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2857         (MockWebRTCPeerConnectionHandler::createOffer):
2858         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2859         (MockWebRTCPeerConnectionHandler):
2860         (MockWebRTCPeerConnectionHandler::taskList):
2861         (SuccessCallbackTask):
2862         (FailureCallbackTask):
2863
2864 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2865
2866         [Chromium-Android] Output time and thread info in crash log
2867         https://bugs.webkit.org/show_bug.cgi?id=95768
2868
2869         Reviewed by Adam Barth.
2870
2871         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2872         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
2873
2874 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2875
2876         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
2877         https://bugs.webkit.org/show_bug.cgi?id=95721
2878
2879         Reviewed by Adam Barth.
2880
2881         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2882         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
2883         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
2884         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2885         (MockWebMediaStreamCenter):
2886
2887 2012-09-04  Tony Chang  <tony@chromium.org>
2888
2889         Elide test names when running new-run-webkit-tests
2890         https://bugs.webkit.org/show_bug.cgi?id=95626
2891
2892         Reviewed by Dirk Pranke.
2893
2894         When the test name exceeds the number of terminal columns, it leaves
2895         text on the screen. Avoid this by eliding the test name when running
2896         tests. This is similar to what ninja does when compiling.
2897
2898         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2899         (MeteredStream):
2900         (MeteredStream.number_of_columns): Helper method to get number of
2901         terminal columns. Won't work on Win32 python, but meh.
2902         * Scripts/webkitpy/layout_tests/views/printing.py:
2903         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
2904         because stderr appears to be ascii only.
2905         (Printer.print_started_test): Route through _test_status_line.
2906         (Printer.print_finished_test): Route through _test_status_line.
2907         (Printer._print_test_trace): Route through _test_status_line.
2908         (Printer._print_baseline): Route through _test_status_line.
2909         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2910         (test_test_status_line): Test for _test_status_line.
2911
2912 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
2913
2914         [GTK] Print API missing documentation when generating gtkdoc
2915         https://bugs.webkit.org/show_bug.cgi?id=95703
2916
2917         Reviewed by Carlos Garcia Campos.
2918
2919         Print out API missing documentation when generating gtkdoc. This makes it
2920         easier to fix documentation errors.
2921
2922         * gtk/generate-gtkdoc:
2923         (print_missing_api): Added.
2924         (generate_doc): Inline the rebase step, since it now reports an error
2925         when you try to rebase without generating documentation first.
2926         * gtk/gtkdoc.py:
2927         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
2928         generating documentation first to enable a small cleanup at the caller.
2929         (GTKDoc.api_missing_documentation): Added.
2930
2931 2012-09-04  Vincent Scheib  <scheib@chromium.org>
2932
2933         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
2934         https://bugs.webkit.org/show_bug.cgi?id=95628
2935
2936         Reviewed by James Robinson.
2937
2938         Future tests need the ability to respond asynchronously that
2939         pointer lock requests have been accepted or rejected. This patch
2940         adds the following:
2941             testRunner.setPointerLockWillRespondAsynchronously();
2942             testRunner.didAcquirePointerLock();
2943             testRunner.didNotAcquirePointerLock();
2944
2945         Tested in existing test:
2946             pointerlockchange-pointerlockerror-events.html
2947
2948         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2949         (DRTTestRunner::DRTTestRunner):
2950         (DRTTestRunner::didAcquirePointerLock):
2951         (DRTTestRunner::didNotAcquirePointerLock):
2952         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
2953         * DumpRenderTree/chromium/DRTTestRunner.h:
2954         (DRTTestRunner):
2955         * DumpRenderTree/chromium/WebViewHost.cpp:
2956         (WebViewHost::requestPointerLock):
2957         (WebViewHost::didAcquirePointerLock):
2958         (WebViewHost::didNotAcquirePointerLock):
2959         * DumpRenderTree/chromium/WebViewHost.h:
2960         (WebViewHost):
2961         (WebViewHost::setPointerLockWillRespondAsynchronously):
2962
2963 2012-09-04  Ojan Vafai  <ojan@chromium.org>
2964
2965         Move content shell bots to their own builder group
2966         https://bugs.webkit.org/show_bug.cgi?id=95765
2967
2968         Reviewed by Adam Barth.
2969
2970         In their current state of instability, they add too much noise. Once they get more stable,
2971         we can add them back to the regular group or just have them replace the other bots.
2972
2973         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
2974
2975         * TestResultServer/static-dashboards/builders.js:
2976         (isWebkitTestRunner):
2977         (isChromiumContentShellTestRunner):
2978         (isChromiumWebkitTipOfTreeTestRunner):
2979         (loadBuildersList):
2980
2981 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
2982
2983         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
2984         https://bugs.webkit.org/show_bug.cgi?id=95689
2985
2986         Reviewed by Kenneth Rohde Christiansen.
2987
2988         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
2989         So, there are bugs that key events are always generated in url bar although
2990         the user clicked the web view.
2991
2992         This patch recovers the focus of the web view when left button is pressed and
2993         adds for MiniBrowser to toggle the focus when middle button is pressed
2994         like EWebLauncher already did.
2995
2996         * EWebLauncher/main.c:
2997         (on_mouse_down):
2998         * MiniBrowser/efl/main.c:
2999         (on_mouse_down):
3000         (browserCreate):
3001
3002 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3003
3004         Added ANDROID_GDBSERVER definition for Ant
3005         https://bugs.webkit.org/show_bug.cgi?id=95265
3006
3007         Reviewed by Adam Barth.
3008
3009         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3010         is only used for finding the gdbserver.
3011
3012         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3013         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3014
3015 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3016
3017         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3018         https://bugs.webkit.org/show_bug.cgi?id=95565
3019
3020         Reviewed by Adam Barth.
3021
3022         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3023         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3024         (MockWebRTCPeerConnectionHandler::updateICE):
3025         (MockWebRTCPeerConnectionHandler::addICECandidate):
3026         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3027         (MockWebRTCPeerConnectionHandler):
3028
3029 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3030
3031         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3032         https://bugs.webkit.org/show_bug.cgi?id=95670
3033
3034         Reviewed by Kenneth Rohde Christiansen.
3035
3036         Fix layout issues related to the URL bar in Minibrowser
3037         and EWebLauncher when the window is resized.
3038
3039         The URL bar was not resized accordingly and the Web
3040         page was moved behing the URL bar, hiding part of it.
3041
3042         * EWebLauncher/main.c:
3043         (on_ecore_evas_resize):
3044         (closeWindow):
3045         * EWebLauncher/url_bar.c:
3046         (url_bar_width_set):
3047         (url_bar_add):
3048         * EWebLauncher/url_bar.h:
3049         * MiniBrowser/efl/main.c:
3050         (on_ecore_evas_resize):
3051         (main):
3052
3053 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3054
3055         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3056         https://bugs.webkit.org/show_bug.cgi?id=95605
3057
3058         Reviewed by Dirk Pranke.
3059
3060         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3061
3062         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3063         (ChromiumAndroidPort.check_sys_deps):
3064         (ChromiumAndroidPort.expectations_files):
3065         (ChromiumAndroidPort.clean_up_test_run):
3066
3067 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3068
3069         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3070         https://bugs.webkit.org/show_bug.cgi?id=95180
3071
3072         Reviewed by Chris Fleizach.
3073
3074         The bug that was fixed stood in the way of fully implementing stringValue().
3075         Testing that the bug is fixed requires stringValue() to be fully implemented
3076         and object replacement characters to be printable.
3077
3078         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3079         (replaceCharactersForResults): New method which turns object replacement
3080         characters into "<obj>" so that the characters can be properly shown in
3081         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3082         accessible text of a single object in the accessible tree doesn't mess up
3083         the readibility of the results.
3084         (AccessibilityUIElement::stringValue): Remove the code that immediately
3085         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3086         replaceCharactersForResults() prior to returning the accessible string
3087         value.
3088
3089 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3090
3091         MediaStream API: Add MediaStream management to RTCPeerConnection
3092         https://bugs.webkit.org/show_bug.cgi?id=95543
3093
3094         Reviewed by Adam Barth.
3095
3096         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3097
3098         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3099         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3100         (MockWebRTCPeerConnectionHandler::addStream):
3101         (MockWebRTCPeerConnectionHandler::removeStream):
3102         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3103         (MockWebRTCPeerConnectionHandler):
3104
3105 2012-08-31  Tony Chang  <tony@chromium.org>
3106
3107         Remove ENABLE_CSS3_FLEXBOX compile time flag
3108         https://bugs.webkit.org/show_bug.cgi?id=95382
3109
3110         Reviewed by Ojan Vafai.
3111
3112         Everyone is already enabling this by default and the spec has stablized.
3113
3114         * Scripts/webkitperl/FeatureList.pm:
3115         * qmake/mkspecs/features/features.pri:
3116
3117 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3118
3119         objc_msgSend and IMP should be cast appropriately before using
3120         https://bugs.webkit.org/show_bug.cgi?id=95242
3121
3122         Reviewed by Benjamin Poulain.
3123
3124         Fix for older compilers. Pass id as the return type to the template
3125         instead of relying on default type.
3126
3127         * DumpRenderTree/mac/DumpRenderTree.mm:
3128         (drt_NSFontManager_availableFontFamilies):
3129         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3130         (WTR::wtr_NSFontManager_availableFontFamilies):
3131
3132 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3133
3134         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3135         https://bugs.webkit.org/show_bug.cgi?id=89616
3136
3137         Reviewed by Eric Seidel.
3138
3139         Add the new 'executive' optional function argument to the SCM.in_working_directory
3140         class method. This way we get to reuse an Executive instance which is necessary in testing
3141         when we're operating with a mock version of the object.
3142
3143         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3144         the SCMDetector with the generator's FileSystem and Executive instances.
3145
3146         * Scripts/webkitpy/common/checkout/scm/detection.py:
3147         (SCMDetector.detect_scm_system):
3148         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3149         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3150         Executive output and test it against expected output.
3151         * Scripts/webkitpy/common/checkout/scm/git.py:
3152         (Git.in_working_directory):
3153         * Scripts/webkitpy/common/checkout/scm/scm.py:
3154         (SCM.in_working_directory):
3155         * Scripts/webkitpy/common/checkout/scm/svn.py:
3156         (SVN.in_working_directory):
3157         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3158         (JSONResultsGeneratorBase.__init__):
3159         (JSONResultsGeneratorBase._get_svn_revision):
3160
3161 2012-08-31  Jon Lee  <jonlee@apple.com>
3162
3163         [Tests] Add basic tests to http/tests/notifications
3164         https://bugs.webkit.org/show_bug.cgi?id=95493
3165         <rdar://problem/12209303>
3166
3167         Reviewed by Alexey Proskuryakov.
3168
3169         Add permission request support for WTR.
3170
3171         * WebKitTestRunner/TestController.cpp:
3172         (WTR::TestController::initialize):
3173         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3174         * WebKitTestRunner/TestController.h:
3175         (TestController):
3176
3177 2012-08-31  Jon Lee  <jonlee@apple.com>
3178
3179         [DRT] Make simulating a web click on a notification a queued task
3180         https://bugs.webkit.org/show_bug.cgi?id=95546
3181         <rdar://problem/12214170>
3182
3183         Reviewed by Alexey Proskuryakov.
3184
3185         Making the web click happen asynchronously better mimics user interaction with the platform.
3186
3187         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3188         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3189         not set.
3190         * DumpRenderTree/mac/DumpRenderTree.mm:
3191         (dump): Assert that the flag is not set.
3192         * DumpRenderTree/mac/TestRunnerMac.mm:
3193         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3194         notification. In the case where the block gets executed after the flag has been unset, we avoid
3195         performing the click.
3196
3197 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3198
3199         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3200         https://bugs.webkit.org/show_bug.cgi?id=95575
3201
3202         Reviewed by Csaba Osztrogonác.
3203
3204         Output 100% difference in the case of differing image dimensions so
3205         the test harness knows that we won't produce any output further.
3206         This matches the behavior of other ports.
3207
3208         * DumpRenderTree/qt/ImageDiff.cpp:
3209         (main):
3210
3211 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3212
3213         Unreviewed, rolling out r127261.
3214         http://trac.webkit.org/changeset/127261
3215         https://bugs.webkit.org/show_bug.cgi?id=95572
3216
3217         This patch depends on other build fixes (see blockers of bug
3218         95466) which should land first (Requested by milian on
3219         #webkit).
3220
3221         * qmake/mkspecs/features/features.prf:
3222
3223 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3224
3225         [Qt] Support WebKit2/QML on QNX
3226         https://bugs.webkit.org/show_bug.cgi?id=95466
3227
3228         Reviewed by Noam Rosenthal.
3229
3230         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3231         this should finally work now.
3232
3233         * qmake/mkspecs/features/features.prf:
3234
3235 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3236
3237         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3238         https://bugs.webkit.org/show_bug.cgi?id=95400
3239
3240         Reviewed by Dirk Pranke.
3241
3242         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3243
3244         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3245         (ChromiumAndroidPort.skipped_layout_tests):
3246
3247 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3248
3249         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3250         https://bugs.webkit.org/show_bug.cgi?id=95499
3251
3252         Unreviewed. One more fix to avoid trying to run the empty string.
3253
3254         * Scripts/webkitdirs.pm:
3255         (buildAutotoolsProject):
3256
3257 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3258
3259         Unreviewed, rolling out r127171.
3260         http://trac.webkit.org/changeset/127171
3261         https://bugs.webkit.org/show_bug.cgi?id=95505
3262
3263         testRunner does not need dumpWebNotificationCallbacks().
3264         (Requested by jonlee on #webkit).
3265
3266         * DumpRenderTree/TestRunner.cpp:
3267         (TestRunner::TestRunner):
3268         (TestRunner::staticFunctions):
3269         * DumpRenderTree/TestRunner.h:
3270         (TestRunner):
3271         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3272         (-[MockWebNotificationProvider webView:didShowNotification:]):
3273         (-[MockWebNotificationProvider webView:didClickNotification:]):
3274         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3275         * DumpRenderTree/mac/UIDelegate.mm:
3276         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3277
3278 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3279
3280         objc_msgSend and IMP should be cast appropriately before using
3281         https://bugs.webkit.org/show_bug.cgi?id=95242
3282
3283         Reviewed by Benjamin Poulain.
3284
3285         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3286         to a function pointer with right types when calling objc_msgSend and an
3287         IMP method directly.
3288
3289         * DumpRenderTree/mac/DumpRenderTree.mm:
3290         (drt_NSFontManager_availableFontFamilies):
3291         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3292         (WTR::wtr_NSFontManager_availableFontFamilies):
3293
3294 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3295
3296         Replace JSC::UString by WTF::String
3297         https://bugs.webkit.org/show_bug.cgi?id=95271
3298
3299         Reviewed by Geoffrey Garen.
3300
3301         Get rid of UString.
3302
3303         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3304         * gdb/webkit.py:
3305         (WTFStringPrinter.to_string):
3306         (JSCIdentifierPrinter.to_string):
3307         (JSCJSStringPrinter.to_string):
3308         (add_pretty_printers):
3309
3310 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3311
3312         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3313         https://bugs.webkit.org/show_bug.cgi?id=95495
3314
3315         Reviewed by Ojan Vafai.
3316
3317         This is a follow-on to bug 95370 that adds in support for
3318         platform/wk2/TestExpectations and
3319         platform/{mac,win}-$version/TestExpectations.
3320
3321         * Scripts/webkitpy/layout_tests/port/apple.py:
3322         (ApplePort.expectations_files):
3323         * Scripts/webkitpy/layout_tests/port/base.py:
3324         (Port._skipped_file_search_paths):
3325         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3326         (MacTest.test_expectations_files):
3327         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3328         (MockDRTPortTest.make_port):
3329         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3330         (WinPortTest.test_expectations_files):
3331
3332 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3333
3334         executive.run_in_parallel() hangs if given nothing to do
3335         https://bugs.webkit.org/show_bug.cgi?id=95387
3336
3337         Reviewed by Ojan Vafai.
3338
3339         Check to make sure that Executive.run_in_parallel() requires
3340         a non-empty list of commands to execute; passing an empty list
3341         seems surely like a programming error.
3342
3343         * Scripts/webkitpy/common/system/executive.py:
3344         (Executive.run_in_parallel):
3345         * Scripts/webkitpy/common/system/executive_unittest.py:
3346         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3347
3348 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3349
3350         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3351         https://bugs.webkit.org/show_bug.cgi?id=94746
3352
3353         Reviewed by Ojan Vafai.
3354
3355         Add an assertion to diff_image() to check that we are passing
3356         tolerance=0 explicitly when diffing ref test results.
3357
3358         * Scripts/webkitpy/layout_tests/port/test.py:
3359         (TestPort.diff_image):
3360
3361 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3362
3363         NRWT should look in mac-wk2 for a TestExpecations file
3364         https://bugs.webkit.org/show_bug.cgi?id=95370
3365
3366         Reviewed by Ojan Vafai.
3367
3368         Adds support for mac-wk2 and win-wk2 to expectations_files()
3369         for the apple mac and apple win ports.
3370         
3371         * Scripts/webkitpy/layout_tests/port/apple.py:
3372         (ApplePort.expectations_files):
3373         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3374         (MacTest.test_expectations_files):
3375         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3376         (WinTest.test_expectations_files):
3377         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3378         (PortTestCase.test_expectations_files):
3379
3380 2012-08-30  Jon Lee  <jonlee@apple.com>
3381
3382         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3383         https://bugs.webkit.org/show_bug.cgi?id=95232
3384         <rdar://problem/12190776>
3385
3386         Reviewed by Alexey Proskuryakov.
3387
3388         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3389
3390         * DumpRenderTree/TestRunner.cpp:
3391         (TestRunner::TestRunner):
3392         (dumpWebNotificationCallbacksCallback):
3393         (TestRunner::staticFunctions):
3394         * DumpRenderTree/TestRunner.h:
3395         (TestRunner):
3396         (TestRunner::dumpWebNotificationCallbacks):
3397         (TestRunner::setDumpWebNotificationCallbacks):
3398         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3399         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3400         (-[MockWebNotificationProvider webView:didShowNotification:]):
3401         (-[MockWebNotificationProvider webView:didClickNotification:]):
3402         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3403         * DumpRenderTree/mac/UIDelegate.mm:
3404         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3405
3406 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3407
3408         MediaStream API: Introduce MediaConstraints
3409         https://bugs.webkit.org/show_bug.cgi?id=95198
3410
3411         Reviewed by Adam Barth.
3412
3413         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3414
3415         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3416         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3417         (isSupportedConstraint):
3418         (isValidConstraint):
3419         (MockWebRTCPeerConnectionHandler::initialize):
3420         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3421         (MockWebRTCPeerConnectionHandler):
3422
3423 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3424
3425         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3426         https://bugs.webkit.org/show_bug.cgi?id=95454
3427
3428         Reviewed by Kenneth Rohde Christiansen.
3429
3430         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3431
3432         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3433         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3434
3435 2012-08-30  Leo Yang  <leoyang@rim.com>
3436
3437         Update my email address.
3438
3439         Not reviewed.
3440
3441         * Scripts/webkitpy/common/config/committers.py:
3442
3443 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3444
3445         [NRWT] Add support for recognizing arbitrary process names in crash lines
3446         https://bugs.webkit.org/show_bug.cgi?id=95435
3447
3448         Reviewed by Adam Barth.
3449
3450         When running layout tests in the chromium port using the content shell,
3451         we want to be able to report sub-process crashes as well.
3452
3453         * Scripts/webkitpy/layout_tests/port/driver.py:
3454         (Driver._check_for_driver_crash):
3455         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3456         (DriverTest.test_check_for_driver_crash):
3457
3458 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3459
3460         Random test-webkitpy failures on the buildbot
3461         https://bugs.webkit.org/show_bug.cgi?id=95096
3462
3463         Reviewed by Dirk Pranke.
3464
3465         Suppress occasional errors when running test-webkitpy on GTK builders
3466         by running these tests serially. The 64-bit Release builder is especially
3467         prone to these as it can run up to 24 tests in parallel.
3468
3469         Despite the tests not being run in parallel, the testing only lasts a handful
3470         of seconds more, so this is a worthy trade-off to avoid unnecessary
3471         false-alarm redness on the GTK builders.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3474         (RunPythonTests.start):
3475
3476 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3477
3478         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3479         https://bugs.webkit.org/show_bug.cgi?id=95380
3480
3481         Reviewed by Michael Saboff.
3482
3483         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3484         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3485         the crash.
3486
3487 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3488
3489         AX: Canvas should have a distinct role
3490         https://bugs.webkit.org/show_bug.cgi?id=95248
3491
3492         Reviewed by Chris Fleizach.
3493
3494         Add support for canvas accessibility role.
3495
3496         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3497         (roleToString):
3498
3499 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3500
3501         [Gtk] Process Gtk 3.4 smooth scroll events properly
3502         https://bugs.webkit.org/show_bug.cgi?id=88070
3503
3504         Added continousMouseScrollBy support in WebKitTestRunner, and added
3505         implementation for gtk, and stub for Qt, mac and EFL.
3506
3507         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3508         scroll for emulating multi-tick mouseScrollBy events.
3509
3510         Reviewed by Martin Robinson.
3511
3512         * DumpRenderTree/gtk/EventSender.cpp:
3513         (mouseScrollByCallback):
3514         (continuousMouseScrollByCallback):
3515         * WebKitTestRunner/EventSenderProxy.h:
3516         (EventSenderProxy):
3517         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3518         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3519         (WTR::EventSendingController::mouseScrollBy):
3520         (WTR):
3521         (WTR::EventSendingController::continuousMouseScrollBy):
3522         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3523         (EventSendingController):
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3526         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3527         (WTR):
3528         (WTR::EventSenderProxy::mouseScrollBy):
3529         (WTR::EventSenderProxy::continuousMouseScrollBy):
3530         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3531         (WTR):
3532         (WTR::EventSenderProxy::continuousMouseScrollBy):
3533         * WebKitTestRunner/mac/EventSenderProxy.mm:
3534         (WTR::EventSenderProxy::continuousScrollBy):
3535         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3536         (WTR::EventSenderProxy::continuousMouseScrollBy):
3537         (WTR):
3538
3539 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3540
3541         [chromium] Support high DIP pixel tests with DumpRenderTree
3542         https://bugs.webkit.org/show_bug.cgi?id=94935
3543
3544         Reviewed by James Robinson.
3545
3546         Adding device scale factor into the drt image dumping code
3547
3548         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3549         (DRTTestRunner::reset):
3550         (DRTTestRunner::setBackingScaleFactor):
3551         * DumpRenderTree/chromium/WebViewHost.cpp:
3552         (WebViewHost::setDeviceScaleFactor):
3553         (WebViewHost::paintInvalidatedRegion):
3554         (WebViewHost::canvas):
3555         * DumpRenderTree/chromium/WebViewHost.h:
3556         (WebViewHost):
3557
3558 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3559
3560         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3561         https://bugs.webkit.org/show_bug.cgi?id=95177
3562
3563         Reviewed by Dirk Pranke.
3564
3565         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3566
3567         * Scripts/webkitpy/common/checkout/scm/git.py:
3568
3569 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3570
3571         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3572         https://bugs.webkit.org/show_bug.cgi?id=95222
3573
3574         Reviewed by Adam Barth.
3575
3576         The code we had to remove REBASELINE lines from the
3577         TestExpectations files did not handle multiple files (in a
3578         cascade) correctly; we weren't limiting lines to a particular
3579         file correctly in without_rebaseline_modifier(). This patch
3580         fixes that and corrects the tests (which weren't correct and
3581         didn't cover things very well).
3582
3583         Note also that the webkit-patch rebaseline-commands are still
3584         using the include_overrides=False option in a couple places;
3585         this is never correct or needed at this point. This patch fixes
3586         the usage for webkit-patch rebaseline-expectations, but I still
3587         need to fix rebaseline-test-internal, which I will do in a
3588         separate patch (see bug 95268).
3589
3590         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3591         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3592         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3593         (RebaseliningTest.assertRemove):
3594         (RebaseliningTest.test_remove):
3595         * Scripts/webkitpy/tool/commands/rebaseline.py:
3596         (RebaselineExpectations._update_expectations_files):
3597
3598 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3599
3600         webkit-patch rebaseline-expectations hangs
3601         https://bugs.webkit.org/show_bug.cgi?id=95243
3602
3603         Reviewed by Tony Chang.
3604
3605         Don't try to run no commands in parallel; report an error
3606         instead that we didn't find any tests to rebaseline.
3607
3608         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3609
3610         * Scripts/webkitpy/tool/commands/rebaseline.py:
3611         (RebaselineExpectations.execute):
3612         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3613         (_assert_command):
3614         (test_rebaseline_expectations_noop):
3615
3616 2012-08-29  Brady Eidson  <beidson@apple.com>
3617
3618         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3619         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3620
3621         Reviewed by Sam Weinig.
3622
3623         Add a test plug-in that calls back into the page with info on the NPWindow passed
3624         in to NPP_SetWindow.
3625
3626         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3627         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3628         (LogNPPSetWindow):
3629         (LogNPPSetWindow::LogNPPSetWindow):
3630         (LogNPPSetWindow::NPP_SetWindow):
3631
3632 2012-08-29  Jon Lee  <jonlee@apple.com>
3633
3634         [Mac] Basic DRT support for web notifications
3635         https://bugs.webkit.org/show_bug.cgi?id=79492
3636         <rdar://problem/10357639>
3637
3638         Reviewed by Alexey Proskuryakov.
3639
3640         This patch implements the stubs for web notification support on DRT. Assume that when
3641         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3642         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3643
3644         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3645         * DumpRenderTree/mac/DumpRenderTree.mm:
3646         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3647         web view.
3648         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3649
3650         * DumpRenderTree/mac/TestRunnerMac.mm:
3651         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3652         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3653         (TestRunner::removeAllWebNotificationPermissions):
3654         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3655         simulate the click. This is similar to how WTR performs the click.
3656         * DumpRenderTree/mac/UIDelegate.mm:
3657         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3658         user allows web notifications.
3659
3660         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3661         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3662         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3663         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3664         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
3665         (-[MockWebNotificationProvider registerWebView:]):
3666         (-[MockWebNotificationProvider unregisterWebView:]):
3667         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
3668         notification did show.
3669         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
3670         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
3671         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
3672         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
3673         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
3674         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
3675         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
3676         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
3677         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
3678         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
3679         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
3680
3681 2012-08-29  Rob Buis  <rbuis@rim.com>
3682
3683         [BlackBerry] Adjust wtf include header style
3684         https://bugs.webkit.org/show_bug.cgi?id=95368
3685
3686         Reviewed by Yong Li.
3687
3688         Switch to #include <wtf/...> like the other ports.
3689
3690         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3691         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
3692         * DumpRenderTree/blackberry/PNGImageEncoder.h:
3693         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3694         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
3695         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3696
3697 2012-08-29  Roger Fong  <roger_fong@apple.com>
3698
3699         Update cygwin-downloader.zip to match modified downloader script.
3700         https://bugs.webkit.org/show_bug.cgi?id=76936
3701
3702         Rubber Stamped by Jon Honeycutt.
3703
3704         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
3705         Updating zip to reflect changes.
3706
3707         * CygwinDownloader/cygwin-downloader.zip:
3708
3709 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3710
3711         Stylechecker warns about comparison to zero when comparing to 0.5
3712         https://bugs.webkit.org/show_bug.cgi?id=94913
3713
3714         Reviewed by Dirk Pranke.
3715
3716         According to the python documentation, \W is the character group with all
3717         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
3718         to [^\w]. We need to exclude the dot "." as well, so that floating point
3719         values do not trigger this warning. Adding a unit test that shows the problem.
3720
3721         * Scripts/webkitpy/style/checkers/cpp.py:
3722         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
3723         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3724         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
3725
3726 2012-08-29  Jon Lee  <jonlee@apple.com>
3727
3728         WTR build fixes.
3729
3730         * WebKitTestRunner/CMakeLists.txt:
3731         * WebKitTestRunner/GNUmakefile.am:
3732         * WebKitTestRunner/Target.pri:
3733         * WebKitTestRunner/WebNotificationProvider.cpp:
3734         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
3735         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3736
3737 2012-08-29  Jon Lee  <jonlee@apple.com>
3738
3739         [WK2] Basic WTR support for web notifications
3740         https://bugs.webkit.org/show_bug.cgi?id=95154
3741         <rdar://problem/12184492>
3742
3743         Reviewed by Alexey Proskuryakov.
3744
3745         Implement WTR support, without platform event output (bug 95233).
3746
3747         Legacy APIs will not be supported, since many of the tests are skipped
3748         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
3749         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
3750         the tests to http/tests/notifications.
3751
3752         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
3753         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
3754         be invoked from the UIProcess.
3755
3756         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3757         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3758         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
3759         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
3760         notification's internal ID.
3761         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3763         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
3764         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
3765         (WTR::TestRunner::removeAllWebNotificationPermissions):
3766         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
3767         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3768
3769         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
3770         class.
3771         * WebKitTestRunner/TestInvocation.cpp:
3772         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
3773         TestInvocation forwards that request to the TestController.
3774         * WebKitTestRunner/TestController.cpp:
3775         (WTR::TestController::initialize): Set the provider.
3776         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
3777         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
3778         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
3779
3780         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
3781         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
3782         * WebKitTestRunner/WebNotificationProvider.h: Added.
3783         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
3784         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
3785         the notification got shown.
3786         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
3787         got closed.
3788         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
3789         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
3790         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
3791         permissions. For testing purposes, we always want this set to be empty.
3792         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
3793         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
3794
3795         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
3796
3797 2012-08-29  Kamil Blank  <k.blank@samsung.com>
3798
3799         [EFL] Add setting API for allow universal/file access from file URLs.
3800         https://bugs.webkit.org/show_bug.cgi?id=83121
3801
3802         Reviewed by Eric Seidel.
3803
3804         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
3805
3806         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3807         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3808         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3809         (TestRunner::setAllowUniversalAccessFromFileURLs):
3810         (TestRunner::setAllowFileAccessFromFileURLs):
3811
3812 2012-08-29  Jon Lee  <jonlee@apple.com>
3813
3814         Update TestRunner API for web notifications
3815         https://bugs.webkit.org/show_bug.cgi?id=95093
3816         <rdar://problem/12179649>
3817
3818         Reviewed by Alexey Proskuryakov.
3819
3820         As it turns out the patch for this accidentally got squashed into the commit for
3821         bug 95099 (r126909). This amendment patch adds some comments about the renaming
3822         of the older TestRunner API for web notifications.
3823
3824         * DumpRenderTree/TestRunner.h:
3825         (TestRunner):
3826
3827 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3828
3829         Unreviewed, rolling out r126972.
3830         http://trac.webkit.org/changeset/126972
3831         https://bugs.webkit.org/show_bug.cgi?id=95349
3832
3833         accessibility/canvas-description-and-role.html has been
3834         failing consistently on several bots and Dominic needs some
3835         time to investigate why (Requested by jchaffraix on #webkit).
3836
3837         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3838         (roleToString):
3839
3840 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
3841
3842         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
3843         https://bugs.webkit.org/show_bug.cgi?id=84707
3844
3845         Reviewed by Gustavo Noronha Silva.
3846
3847         Most of the warnings have been fixed now that FindCairo.cmake and
3848         FindGLIB.cmake have been rewritten. The remaining one, related to
3849         FindFontconfig.cmake, shows up when building on a 64-bit
3850         Debian-based systems.
3851
3852         jhbuild installs libraries into lib64/ by default on 64-bit Linux
3853         installations, while CMake does not look for libraries in lib64/
3854         when /etc/debian_version exists on the system. The FIND_LIBRARY()
3855         would then sometimes end up using the system installation instead of
3856         the jhbuild one, causing mismatches and, when pkg-config is not used
3857         at all, failing to find libraries altogether.
3858
3859         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
3860         when use_lib64 is set to force CMake to look into lib64/ regardless
3861         of the presence of /etc/debian_version.
3862
3863 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3864
3865         The 2d.imageData.object.round canvas test is failing
3866         https://bugs.webkit.org/show_bug.cgi?id=40272
3867
3868         Reviewed by Benjamin Poulain.
3869
3870         Updating patch to address Benjamin's review comments.
3871         Adding a WTF test to test lrint implementation.
3872
3873         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
3874         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
3875         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
3876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
3877         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
3878         (TestWebKitAPI):
3879         (TestWebKitAPI::TEST):
3880         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
3881
3882 2012-08-29  Florin Malita  <fmalita@chromium.org>
3883
3884         Unreviewed, updating Kelly Norton's email address at his request.
3885
3886         * Scripts/webkitpy/common/config/committers.py:
3887
3888 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3889
3890         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
3891         https://bugs.webkit.org/show_bug.cgi?id=93723
3892
3893         Reviewed by Dirk Pranke.
3894
3895         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3896         (TestExpectationParser.expectation_for_skipped_test):
3897         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3898         (SkippedTests.test_skipped_entry_dont_exist):
3899
3900 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3901
3902         Unreviewed, rolling out r120113.
3903         http://trac.webkit.org/changeset/120113
3904         https://bugs.webkit.org/show_bug.cgi?id=95320
3905
3906         Wrong fix for the problem, experimentally rolling it out for
3907         bug 95237. (Requested by rakuco on #webkit).
3908
3909         * efl/jhbuildrc:
3910
3911 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3912
3913         AX: Canvas should have a distinct role
3914         https://bugs.webkit.org/show_bug.cgi?id=95248
3915
3916         Reviewed by Chris Fleizach.
3917
3918         Add support for canvas accessibility role.
3919
3920         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3921         (roleToString):
3922
3923 2012-08-28  Eric Seidel  <eric@webkit.org>
3924
3925         cr-ews bot doesn't set CWD correctly when zipping layout test results
3926         https://bugs.webkit.org/show_bug.cgi?id=91265
3927
3928         Reviewed by Kenneth Russell.
3929
3930         This should make the zips slightly less cumbersome to deal with.
3931
3932         * Scripts/webkitpy/common/system/workspace.py:
3933         (Workspace.create_zip):
3934         * Scripts/webkitpy/common/system/workspace_unittest.py:
3935         (WorkspaceTest.test_create_zip):
3936         (WorkspaceTest.test_create_zip_exception):
3937
3938 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
3939
3940         Fix the Commiters script
3941
3942         Unreviewed.
3943
3944         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
3945
3946         * Scripts/webkitpy/common/config/committers.py:
3947
3948 2012-08-28  Roger Fong  <roger_fong@apple.com>
3949
3950         Unreviewed. Adding myself to committers list.
3951
3952         * Scripts/webkitpy/common/config/committers.py:
3953
3954 2012-08-28  Roger Fong  <roger_fong@apple.com>
3955
3956         Add minires to list of required cygwin install packages.
3957         https://bugs.webkit.org/show_bug.cgi?id=76936
3958
3959         Reviewed by Tim Horton.
3960
3961         * CygwinDownloader/cygwin-downloader.py:
3962
3963 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
3964
3965         [Chromium-Android] Upstream layout test expectations (Part 2)
3966         https://bugs.webkit.org/show_bug.cgi?id=95212
3967
3968         Reviewed by Adam Barth.
3969
3970         - Now run both gpu path and non-gpu path of 2d canvas layout tests
3971         because both are used in chromium-android.
3972
3973         - Exclude all webgl tests because webgl is not enabled yet.
3974
3975         - Removed 'win' from the baseline fallback list. This was a mistake.
3976
3977         - Moved some small directories to TestExpectations from skipped_layout_tests().
3978
3979         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3980         (ChromiumAndroidPort):
3981         (ChromiumAndroidPort.skipped_layout_tests):
3982
3983 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
3984
3985         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
3986         https://bugs.webkit.org/show_bug.cgi?id=95185
3987
3988         Reviewed by Chris Fleizach.
3989
3990         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3991         (AccessibilityUIElement::titleUIElement): Implemented
3992         Gets the ATK_RELATION_LABELLED_BY target.
3993         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
3994         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
3995         bug 95180 is fixed.
3996
3997 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
3998
3999         AX: Crash due to object getting deleted inside updateBackingStore
4000         https://bugs.webkit.org/show_bug.cgi?id=94619
4001
4002         Reviewed by Chris Fleizach.
4003
4004         Change isValid to !isDetached after deleting isValid from
4005         chromium WebAccessibilityObject as being redundant.
4006
4007         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4008         (AccessibilityUIElement::isValidGetterCallback):
4009
4010 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
4011
4012         Unreviewed, rolling out r126914.
4013         http://trac.webkit.org/changeset/126914
4014         https://bugs.webkit.org/show_bug.cgi?id=95239
4015
4016         it breaks everything and fixes nothing (Requested by pizlo on
4017         #webkit).
4018
4019         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4020         (MockWebSpeechInputController::addMockRecognitionResult):
4021         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4022         (NotificationPresenter::simulateClick):
4023         (NotificationPresenter::show):
4024         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4025         (CppBoundClass::~CppBoundClass):
4026         (CppBoundClass::invoke):
4027         (CppBoundClass::getProperty):
4028         (CppBoundClass::setProperty):
4029         (CppBoundClass::bindCallback):
4030         (CppBoundClass::bindProperty):
4031         * DumpRenderTree/chromium/WebPreferences.cpp:
4032         (applyFontMap):
4033         * DumpRenderTree/chromium/WebViewHost.cpp:
4034         (WebViewHost::printResourceDescription):
4035         * DumpRenderTree/mac/TestRunnerMac.mm:
4036         (worldIDForWorld):
4037         (TestRunner::evaluateScriptInIsolatedWorld):
4038         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4039         (AccessibilityController::~AccessibilityController):
4040         (AccessibilityController::winNotificationReceived):
4041         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4042         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4043         * DumpRenderTree/win/TestRunnerWin.cpp:
4044         (worldIDForWorld):
4045         (TestRunner::evaluateScriptInIsolatedWorld):
4046         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4047         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4048         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4049         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4051         (WTR::TestRunner::worldIDForWorld):
4052         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4053
4054 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4055
4056         Rename first/second to key/value in HashMap iterators
4057         https://bugs.webkit.org/show_bug.cgi?id=82784
4058
4059         Reviewed by Eric Seidel.
4060
4061         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4062         (MockWebSpeechInputController::addMockRecognitionResult):
4063         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4064         (NotificationPresenter::simulateClick):
4065         (NotificationPresenter::show):
4066         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4067         (CppBoundClass::~CppBoundClass):
4068         (CppBoundClass::invoke):
4069         (CppBoundClass::getProperty):
4070         (CppBoundClass::setProperty):
4071         (CppBoundClass::bindCallback):
4072         (CppBoundClass::bindProperty):
4073         * DumpRenderTree/chromium/WebPreferences.cpp:
4074         (applyFontMap):
4075         * DumpRenderTree/chromium/WebViewHost.cpp:
4076         (WebViewHost::printResourceDescription):
4077         * DumpRenderTree/mac/TestRunnerMac.mm:
4078         (worldIDForWorld):
4079         (TestRunner::evaluateScriptInIsolatedWorld):
4080         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4081         (AccessibilityController::~AccessibilityController):
4082         (AccessibilityController::winNotificationReceived):
4083         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4084         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4085         * DumpRenderTree/win/TestRunnerWin.cpp:
4086         (worldIDForWorld):
4087         (TestRunner::evaluateScriptInIsolatedWorld):
4088         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4089         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4090         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4091         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4092         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4093         (WTR::TestRunner::worldIDForWorld):
4094         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4095
4096 2012-08-27  Jon Lee  <jonlee@apple.com>
4097
4098         Update TestRunner API for web notifications
4099         https://bugs.webkit.org/show_bug.cgi?id=95093
4100         <rdar://problem/12179649>
4101
4102         Reviewed by Jessie Berlin.
4103
4104         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
4105
4106         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
4107         This first patch renames the TestRunner calls to use the term "web notifications" instead of
4108         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
4109         additional calls that will be used in the tests that test the standard API.
4110
4111         * DumpRenderTree/TestRunner.h:
4112         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
4113         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
4114         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
4115         (TestRunner::TestRunner):
4116         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
4117         (simulateLegacyWebNotificationClickCallback): Renamed.
4118         (grantWebNotificationPermissionCallback): Renamed.
4119         (denyWebNotificationPermissionCallback): Added.
4120         (removeAllWebNotificationPermissionsCallback): Added.
4121         (simulateWebNotificationClickCallback): Added.
4122         (TestRunner::staticFunctions):
4123         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
4124
4125         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4126         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
4127         (DRTTestRunner::grantWebNotificationPermission):
4128         (DRTTestRunner::denyWebNotificationPermission): Stub.
4129         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
4130         (DRTTestRunner::simulateWebNotificationClick): Stub.
4131         (DRTTestRunner::simulateLegacyWebNotificationClick):
4132         * DumpRenderTree/chromium/DRTTestRunner.h:
4133         (DRTTestRunner):
4134
4135         Added stubs.
4136         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4137         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4138         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4139         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
4140         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
4141         * DumpRenderTree/win/TestRunnerWin.cpp:
4142
4143 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
4144
4145         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
4146         https://bugs.webkit.org/show_bug.cgi?id=94700
4147
4148         Reviewed by Eric Seidel.
4149
4150         Interrupting download with a timeout would be a possible solution.
4151         I imported the socket module and used the setdefaulttimeout() method.
4152         Fixing it is important, because EWS bots need to be restarted regularly
4153         because of this bug.
4154
4155         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4156         (Bugzilla._get_browser):
4157         (Bugzilla.setdefaulttimeout):
4158
4159 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
4160
4161         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
4162         https://bugs.webkit.org/show_bug.cgi?id=95194
4163
4164         Reviewed by Simon Hausmann.
4165
4166         * Scripts/webkitpy/layout_tests/port/qt.py:
4167         (QtPort.setup_environ_for_server):
4168
4169 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
4170
4171         [watchlist] Unreviewed, subscribe to Qt bugs.
4172
4173         * Scripts/webkitpy/common/config/watchlist:
4174
4175 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
4176
4177         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
4178         https://bugs.webkit.org/show_bug.cgi?id=95054
4179
4180         Reviewed by Eric Seidel.
4181
4182         Enable CSS_IMAGE_SET for the Qt build.
4183
4184         * qmake/mkspecs/features/features.pri:
4185
4186 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
4187
4188         [Qt] Enable CSS sticky position
4189         https://bugs.webkit.org/show_bug.cgi?id=95172
4190
4191         Reviewed by Simon Hausmann.
4192
4193         * qmake/mkspecs/features/features.pri:
4194
4195 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
4196
4197         [GTK] Memory cache should be cleared in between test runs
4198         https://bugs.webkit.org/show_bug.cgi?id=95105
4199
4200         Reviewed by Martin Robinson.
4201
4202         Call the new DumpRenderTreeSupportGtk helper method after every test
4203         to clear the memory cache.
4204
4205         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4206         (runTest):
4207
4208 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
4209
4210         Unreviewed, rolling out r126836.
4211         http://trac.webkit.org/changeset/126836
4212         https://bugs.webkit.org/show_bug.cgi?id=95163
4213
4214         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
4215         #webkit).
4216
4217         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4218         (MockWebSpeechInputController::addMockRecognitionResult):
4219         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4220         (NotificationPresenter::simulateClick):
4221         (NotificationPresenter::show):
4222         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4223         (CppBoundClass::~CppBoundClass):
4224         (CppBoundClass::invoke):
4225         (CppBoundClass::getProperty):
4226         (CppBoundClass::setProperty):
4227         (CppBoundClass::bindCallback):
4228         (CppBoundClass::bindProperty):
4229         * DumpRenderTree/chromium/WebPreferences.cpp:
4230         (applyFontMap):
4231         * DumpRenderTree/chromium/WebViewHost.cpp:
4232         (WebViewHost::printResourceDescription):
4233         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4234         (AccessibilityController::~AccessibilityController):
4235         (AccessibilityController::winNotificationReceived):
4236         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4237         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4238         * DumpRenderTree/win/TestRunnerWin.cpp:
4239         (worldIDForWorld):
4240         (TestRunner::evaluateScriptInIsolatedWorld):
4241         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4242         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4243         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4244         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4246         (WTR::TestRunner::worldIDForWorld):
4247         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4248
4249 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4250
4251         Rename first/second to key/value in HashMap iterators
4252         https://bugs.webkit.org/show_bug.cgi?id=82784
4253
4254         Reviewed by Eric Seidel.
4255
4256         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4257         (MockWebSpeechInputController::addMockRecognitionResult):
4258         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4259         (NotificationPresenter::simulateClick):
4260         (NotificationPresenter::show):
4261         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4262         (CppBoundClass::~CppBoundClass):
4263         (CppBoundClass::invoke):
4264         (CppBoundClass::getProperty):
4265         (CppBoundClass::setProperty):
4266         (CppBoundClass::bindCallback):
4267         (CppBoundClass::bindProperty):
4268         * DumpRenderTree/chromium/WebPreferences.cpp:
4269         (applyFontMap):
4270         * DumpRenderTree/chromium/WebViewHost.cpp:
4271         (WebViewHost::printResourceDescription):
4272         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4273         (AccessibilityController::~AccessibilityController):
4274         (AccessibilityController::winNotificationReceived):
4275         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4276         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4277         * DumpRenderTree/win/TestRunnerWin.cpp:
4278         (worldIDForWorld):
4279         (TestRunner::evaluateScriptInIsolatedWorld):
4280         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4281         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4282         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4283         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4284         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4285         (WTR::TestRunner::worldIDForWorld):
4286         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4287
4288 2012-08-24  James Robinson  <jamesr@chromium.org>
4289
4290         WebGL should not flip textures on presentation if contents are unchanged
4291         https://bugs.webkit.org/show_bug.cgi?id=94961
4292
4293         Reviewed by Kenneth Russell.
4294
4295         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
4296
4297         * Scripts/webkitpy/layout_tests/port/chromium.py:
4298         (ChromiumPort.virtual_test_suites):
4299
4300 2012-08-27  Gavin Peters  <gavinp@chromium.org>
4301
4302         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
4303         https://bugs.webkit.org/show_bug.cgi?id=95104
4304
4305         Reviewed by Adam Barth.