webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
4         https://bugs.webkit.org/show_bug.cgi?id=194418
5
6         Reviewed by Lucas Forschler.
7
8         Do not include errors trying when finding crashlogs at the end of
9         a run-webkit-tests run since we don't process those errors.
10
11         * Scripts/webkitpy/port/darwin.py:
12         (DarwinPort._look_for_all_crash_logs_in_log_dir):
13         * Scripts/webkitpy/port/ios_device.py:
14         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
15         * Scripts/webkitpy/port/watch_device.py:
16         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
17
18 2019-02-08  Beth Dakin  <bdakin@apple.com>
19
20         Add afterScreenUpdates to WKSnapshotConfiguration
21         https://bugs.webkit.org/show_bug.cgi?id=194362
22         -and corresponding-
23         <rdar://problem/40655528> Please add an "after screen updates" property to 
24         WKSnapshotConfiguration (to solve blank snapshots)
25
26         Reviewed by Tim Horton.
27
28         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
29         (TEST):
30
31 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
32
33         clampTo(): do not convert the input to double when dealing with integers
34         https://bugs.webkit.org/show_bug.cgi?id=194263
35         <rdar://problem/47692312>
36
37         Reviewed by Darin Adler.
38
39         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
40         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
41         (TestWebKitAPI::testClampFloatingPointToInteger):
42         (TestWebKitAPI::testClampSameSignIntegers):
43         (TestWebKitAPI::testClampUnsignedToSigned):
44         (TestWebKitAPI::testClampSignedToUnsigned):
45
46 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
47
48         webkitpy: Respect --dedicated-simulators flag
49         https://bugs.webkit.org/show_bug.cgi?id=194416
50         <rdar://problem/47894722>
51
52         Reviewed by Lucas Forschler.
53
54         * Scripts/webkitpy/port/device_port.py:
55         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
56         available devices can be safely ignored.
57
58 2019-02-07  Keith Rollin  <krollin@apple.com>
59
60         Remove extra copy of 100x100-red.tga
61         https://bugs.webkit.org/show_bug.cgi?id=194371
62         <rdar://problem/47873465>
63
64         Reviewed by Said Abou-Hallawa.
65
66         In order to help it pass its tests, Bug 194190 added a second copy of
67         the file 100x100-red.tga. However, it turns out that this additional
68         file wasn't actually needed, and that that sole previous copy was
69         sufficient. At the same time, this second copy -- which was copied to
70         the same location in the build output as the first copy -- now caused
71         XCBuild to complain because there were two production rules for the
72         same output file. Address this by removing the newly-added extra copy.
73
74         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
75         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
76
77 2019-02-07  Alex Christensen  <achristensen@webkit.org>
78
79         Deprecate WKBundlePageSetDefersLoading
80         https://bugs.webkit.org/show_bug.cgi?id=191394
81
82         Reviewed by Dean Jackson.
83
84         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
85         (WTR::TestRunner::setDefersLoading):
86
87 2019-02-07  Zalan Bujtas  <zalan@apple.com>
88
89         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
90         https://bugs.webkit.org/show_bug.cgi?id=194391
91
92         Reviewed by Antti Koivisto.
93
94         * LayoutReloaded/misc/LFC-passing-tests.txt:
95
96 2019-02-06  Keith Rollin  <krollin@apple.com>
97
98         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
99         https://bugs.webkit.org/show_bug.cgi?id=193975
100         <rdar://problem/47643306>
101
102         Reviewed by Tim Horton.
103
104         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
105         the Info.plist file into the bundle. This step is not necessary as the
106         implicit "bundle up all the build products into a framework" build
107         phase does this already. Having the Copy Bundle Resources phase do
108         this causes a conflict under XCBuild, which objects to two build
109         phases producing the same file (Info.plist). Address this by removing
110         Info.plist from the Copy Bundle Resources phase.
111
112         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
113
114 2019-02-06  Keith Rollin  <krollin@apple.com>
115
116         Really enable the automatic checking and regenerations of .xcfilelists during builds
117         https://bugs.webkit.org/show_bug.cgi?id=194357
118         <rdar://problem/47861231>
119
120         Reviewed by Chris Dumez.
121
122         Bug 194124 was supposed to enable the automatic checking and
123         regenerating of .xcfilelist files during the build. While related
124         changes were included in that patch, the change to actually enable the
125         operation somehow was omitted. This patch actually enables the
126         operation. The check-xcfilelist.sh scripts now check
127         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
128         from the checking.
129
130         * DumpRenderTree/Scripts/check-xcfilelists.sh:
131         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
132
133 2019-02-06  David Kilzer  <ddkilzer@apple.com>
134
135         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
136         <https://webkit.org/b/194286>
137         <rdar://problem/47815558>
138
139         Reviewed by Alexey Proskuryakov.
140
141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
142         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
143         WKRetainPtr<> to avoid leaking the WKDataRef.
144
145 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
146
147         Unreviewed, fix a typo
148
149         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
150
151 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
152
153         [GTK][WPE] force libpsl build to use ICU in jhbuild
154         https://bugs.webkit.org/show_bug.cgi?id=194288
155
156         Reviewed by Carlos Garcia Campos.
157
158         * gtk/jhbuild.modules:
159         Require ICU for libpsl build in jhbuild, like done in WPE.
160
161 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
162
163         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
164         https://bugs.webkit.org/show_bug.cgi?id=194209
165
166         Reviewed by Carlos Garcia Campos.
167
168         Enhance TestCookieManager to ensure this doesn't happen again.
169
170         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
171         (testCookieManagerPersistentStorage):
172         (beforeAll):
173
174 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
175
176         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
177         https://bugs.webkit.org/show_bug.cgi?id=194324
178
179         Reviewed by Andy Estes.
180
181         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
182         part of the name is already implicit, since this is in testing code in TestOptions.
183
184         * WebKitTestRunner/TestController.cpp:
185         (WTR::TestController::generateContextConfiguration const):
186         (WTR::updateTestOptionsFromTestHeader):
187         * WebKitTestRunner/TestOptions.h:
188         (WTR::TestOptions::hasSameInitializationOptions const):
189
190 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
191
192         [ews-build] Allow * as platform for builders and workers
193         https://bugs.webkit.org/show_bug.cgi?id=188533
194
195         Reviewed by Lucas Forschler.
196
197         * BuildSlaveSupport/ews-build/loadConfig.py:
198         (checkWorkersAndBuildersForConsistency):
199
200 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
201
202         [ews-build] Add few bots to config.json
203         https://bugs.webkit.org/show_bug.cgi?id=194304
204
205         Reviewed by Lucas Forschler.
206
207         * BuildSlaveSupport/ews-build/config.json:
208
209 2019-02-05  Keith Rollin  <krollin@apple.com>
210
211         Enable the automatic checking and regenerations of .xcfilelists during builds
212         https://bugs.webkit.org/show_bug.cgi?id=194124
213         <rdar://problem/47721277>
214
215         Reviewed by Tim Horton.
216
217         Bug 193790 add a facility for checking -- during build time -- that
218         any needed .xcfilelist files are up-to-date and for updating them if
219         they are not. This facility was initially opt-in by setting
220         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
221         the process seemed robust. Its now time to enable this facility and
222         make it opt-out. If there is a need to disable this facility, set and
223         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
224         running `make` or `build-webkit`, or before running Xcode from the
225         command line.
226
227         Additionally, remove the step that generates a list of source files
228         going into the UnifiedSources build step. It's only necessarily to
229         specify Sources.txt and SourcesCocoa.txt as inputs.
230
231         * Scripts/generate-xcfilelists:
232
233 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
234
235         [GTK][WPE] force libpsl build to use ICU in jhbuild
236         https://bugs.webkit.org/show_bug.cgi?id=194288
237
238         Reviewed by Philippe Normand.
239
240         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
241         This can cause build failures if libidn is detected but libunistring is not available.
242
243         Make sure that ICU is used for runtime and builtin PSL data.
244
245         * gtk/jhbuild.modules:
246         * wpe/jhbuild.modules:
247
248 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
249
250         [ews-app] Modified timestamp should be updated on updating data
251         https://bugs.webkit.org/show_bug.cgi?id=194295
252
253         Reviewed by Lucas Forschler.
254
255         * BuildSlaveSupport/ews-app/ews/models/build.py:
256         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
257         * BuildSlaveSupport/ews-app/ews/models/step.py:
258
259 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
260
261         Unreviewed, rolling out r240742.
262
263         Causes crashes on iOS simulator.
264
265         Reverted changeset:
266
267         "[iOS] Keyups for non-modifier keys identified as "Dead" when
268         not focused in a content-editable element"
269         https://bugs.webkit.org/show_bug.cgi?id=192824
270         https://trac.webkit.org/changeset/240742
271
272 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
273
274         run-webkit-tests emits message "...running None" when running tests
275         https://bugs.webkit.org/show_bug.cgi?id=194133
276         <rdar://problem/47724738>
277
278         Reviewed by Lucas Forschler.
279
280         * Scripts/webkitpy/xcode/device_type.py:
281         (DeviceType.__str__): Use both version mapping tables and use just the variant
282         name if no version name is available.
283         * Scripts/webkitpy/xcode/device_type_unittest.py:
284         (DeviceTypeTest):
285         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
286         an associated named.
287
288 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
289
290         [WPE] require python3-setuptools for meson build in jhbuild
291         https://bugs.webkit.org/show_bug.cgi?id=194287
292
293         Reviewed by Philippe Normand.
294
295         python3-setuptools is needed to build meson in jhbuild.
296         It is already required by the GTK port.
297
298         * wpe/install-dependencies:
299
300 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
301
302         [ews-app] Add method to save BuilderMapping to database
303         https://bugs.webkit.org/show_bug.cgi?id=194264
304
305         Reviewed by Lucas Forschler.
306
307         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
308         (BuilderMapping.__str__):
309         (BuilderMapping):
310         (BuilderMapping.save_mapping):
311         (BuilderMapping.update_mapping):
312         (BuilderMapping.get_existing_mapping):
313         (BuilderMapping.is_valid_mapping):
314
315 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-app] Add timestamp fields for BuilderMappings
318         https://bugs.webkit.org/show_bug.cgi?id=194266
319
320         Reviewed by Lucas Forschler.
321
322         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
323         (BuilderMapping):
324
325 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
326
327         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
328         https://bugs.webkit.org/show_bug.cgi?id=174816
329
330         Reviewed by Michael Catanzaro.
331
332         Add tests for webkit_uri_for_display().
333
334         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
335         (testURIForDisplayUnaffected):
336         (testURIForDisplayAffected):
337         (beforeAll):
338         (afterAll):
339         * TestWebKitAPI/glib/CMakeLists.txt:
340
341 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
342
343         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
344         https://bugs.webkit.org/show_bug.cgi?id=194158
345         <rdar://problem/47737268>
346
347         Rubber-stamped by Aakash Jain.
348
349         * Scripts/webkitpy/port/device_port.py:
350         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
351
352 2019-02-04  Said Abou-Hallawa  <said@apple.com>
353
354         [CG] Enable setAdditionalSupportedImageTypes for WK1
355         https://bugs.webkit.org/show_bug.cgi?id=194190
356
357         Reviewed by Tim Horton.
358
359         Add a test similar to the one under WebKit Cocoa but make it create a
360         WebView instead of a WKWebView.
361
362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
363         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
364         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
365         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
366         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
367         (TestWebKitAPI::runTest):
368         (TestWebKitAPI::TEST):
369
370 2019-02-04  Zalan Bujtas  <zalan@apple.com>
371
372         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
373         https://bugs.webkit.org/show_bug.cgi?id=194168
374
375         Reviewed by Simon Fraser.
376
377         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
381         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
382         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
383         (TEST):
384         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
385         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
386
387 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
388
389         REGRESSION (r237269): webkit-patch what-broke is broken 
390         https://bugs.webkit.org/show_bug.cgi?id=193025
391
392         Reviewed by Aakash Jain.
393
394         * Scripts/webkitpy/common/host.py:
395         (Host.buildbot):
396         (Host.bugzilla): Renamed to 'buildbot'.
397
398 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
399
400         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
401         https://bugs.webkit.org/show_bug.cgi?id=194207
402
403         Reviewed by Tim Horton.
404
405         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
406         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
407         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
408         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
409         start and delete forwards to remove the original attachment.
410
411         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
412         (TestWebKitAPI::TEST):
413
414 2019-02-04  Youenn Fablet  <youenn@apple.com>
415
416         Capture state should be managed consistently when doing process swapping
417         https://bugs.webkit.org/show_bug.cgi?id=194122
418         <rdar://problem/47609293>
419
420         Reviewed by Eric Carlson.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
423         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
424         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
425         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
426         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
427         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
428         (WTR::TestRunner::isDoingMediaCapture const):
429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
430         * WebKitTestRunner/TestController.cpp:
431         (WTR::TestController::isDoingMediaCapture const):
432         * WebKitTestRunner/TestController.h:
433         * WebKitTestRunner/TestInvocation.cpp:
434         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
435         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
436         (WTR::TestController::isDoingMediaCapture const):
437
438 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
439
440         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
441         https://bugs.webkit.org/show_bug.cgi?id=194142
442
443         Reviewed by Ross Kirsling.
444
445         There three 'separator' variables in TestController.cpp. Renamed
446         it 'pathSeparator', and unified them.
447
448         * WebKitTestRunner/TestController.cpp:
449         (WTR::TestController::generateContextConfiguration const):
450         (WTR::createTestURL):
451         (WTR::TestController::platformAdjustContext):
452
453 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
454
455         Make setNeedsLayout on the root more explicitly about triggering its side-effects
456         https://bugs.webkit.org/show_bug.cgi?id=194198
457
458         Reviewed by Antti Koivisto.
459
460         No need to set the banner heights on navigation now, since Page stores them.
461
462         * MiniBrowser/mac/WK2BrowserWindowController.m:
463         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
464
465 2019-02-03  John Wilander  <wilander@apple.com>
466
467         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
468         https://bugs.webkit.org/show_bug.cgi?id=194104
469         <rdar://problem/47649991>
470
471         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
472
473         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
474         (TestWebKitAPI::TEST):
475             Changed numeric types from unsigned short to uint32_t.
476
477 2019-02-02  David Kilzer  <ddkilzer@apple.com>
478
479         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
480         <https://webkit.org/b/194178>
481         <rdar://problem/47753473>
482
483         Reviewed by Alexey Proskuryakov.
484
485         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
486         (WTR::uninstallFakeHelvetica): Pass nullptr into
487         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
488
489 2019-02-02  Zalan Bujtas  <zalan@apple.com>
490
491         [LFC] Initialize ICB's style with fixed width/height.
492         https://bugs.webkit.org/show_bug.cgi?id=194188
493
494         Reviewed by Antti Koivisto.
495
496         * LayoutReloaded/misc/LFC-passing-tests.txt:
497
498 2019-02-02  Zalan Bujtas  <zalan@apple.com>
499
500         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
501         https://bugs.webkit.org/show_bug.cgi?id=194185
502
503         Reviewed by Antti Koivisto.
504
505         * LayoutReloaded/misc/LFC-passing-tests.txt:
506
507 2018-12-16  Darin Adler  <darin@apple.com>
508
509         Convert additional String::format clients to alternative approaches
510         https://bugs.webkit.org/show_bug.cgi?id=192746
511
512         Reviewed by Alexey Proskuryakov.
513
514         * WebKitTestRunner/TestController.cpp:
515         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
516         as an intermediate in code that ultimately constructs a WTF::String.
517         (WTR::userMediaOriginHash): Use makeString.
518         (WTR::TestController::didNavigateWithNavigationData): More of the same.
519         (WTR::TestController::didPerformClientRedirect): Ditto.
520         (WTR::TestController::didPerformServerRedirect): Ditto.
521         (WTR::TestController::didUpdateHistoryTitle): Ditto.
522
523 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
524
525         [ews-build] Add unit test to verify builder keys
526         https://bugs.webkit.org/show_bug.cgi?id=194152
527
528         Reviewed by Lucas Forschler.
529
530         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
531         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
532
533 2019-02-01  Zalan Bujtas  <zalan@apple.com>
534
535         [LFC] Expand tests coverage (12 new tests -> 787)
536
537         Unreviewed test gardening.
538
539         * LayoutReloaded/misc/LFC-passing-tests.txt:
540
541 2019-02-01  Zalan Bujtas  <zalan@apple.com>
542
543         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
544         https://bugs.webkit.org/show_bug.cgi?id=194163
545
546         Reviewed by Simon Fraser.
547
548         775
549
550         * LayoutReloaded/misc/LFC-passing-tests.txt:
551
552 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
553
554         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
555         https://bugs.webkit.org/show_bug.cgi?id=194140
556         <rdar://problem/47728098>
557
558         Reviewed by Tim Horton.
559
560         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
561         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
562         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
563
564         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
565         test to induce an IPC deadlock when presenting a modal alert during touch start.
566
567         * WebKitTestRunner/InjectedBundle/TestRunner.h:
568         * WebKitTestRunner/TestController.cpp:
569         (WTR::runJavaScriptAlert):
570
571         Add a client callback function for running JavaScript alerts.
572
573         (WTR::TestController::createOtherPage):
574         (WTR::TestController::generateContextConfiguration const):
575
576         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
577         the fix in this patch.
578
579         (WTR::TestController::createWebViewWithOptions):
580
581         Plumb TestOptions to generateContextConfiguration.
582
583         (WTR::TestController::resetPreferencesToConsistentValues):
584         (WTR::TestController::resetStateToConsistentValues):
585         (WTR::updateTestOptionsFromTestHeader):
586         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
587         (WTR::TestController::handleJavaScriptAlert):
588         * WebKitTestRunner/TestController.h:
589         * WebKitTestRunner/TestInvocation.cpp:
590         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
591         * WebKitTestRunner/TestOptions.h:
592         (WTR::TestOptions::hasSameInitializationOptions const):
593
594 2019-02-01  Chris Dumez  <cdumez@apple.com>
595
596         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
597         https://bugs.webkit.org/show_bug.cgi?id=193740
598         <rdar://problem/47527267>
599
600         Reviewed by Alex Christensen.
601
602         Add API test coverage.
603
604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
605
606 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
607
608         [ews-app] Add display name field to BuilderMapping model
609         https://bugs.webkit.org/show_bug.cgi?id=194153
610
611         Reviewed by Lucas Forschler.
612
613         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
614         (BuilderMapping):
615
616 2019-02-01  Youenn Fablet  <youenn@apple.com>
617
618         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
619         https://bugs.webkit.org/show_bug.cgi?id=194155
620
621         Reviewed by Eric Carlson.
622
623         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
624         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
625         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
626
627 2019-02-01  Zalan Bujtas  <zalan@apple.com>
628
629         [LFC] Adjust replaced element's intrinsic ratio
630         https://bugs.webkit.org/show_bug.cgi?id=194154
631
632         Reviewed by Antti Koivisto.
633
634         761
635
636         * LayoutReloaded/misc/LFC-passing-tests.txt:
637
638 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
639
640         [WPE] Show test results in minibrowser
641         https://bugs.webkit.org/show_bug.cgi?id=194150
642
643         Reviewed by Žan Doberšek.
644
645         * Scripts/webkitpy/port/wpe.py:
646         (WPEPort.show_results_html_file):
647
648 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
649
650         [WPE] MiniBrowser: add ky bindings for back/forward navigation
651         https://bugs.webkit.org/show_bug.cgi?id=194151
652
653         Reviewed by Žan Doberšek.
654
655         ALT + <- go back
656         ALT + -> go forward
657
658         * MiniBrowser/wpe/main.cpp:
659         (main):
660
661 2019-02-01  Zalan Bujtas  <zalan@apple.com>
662
663         [LFC] Set intrinsic size on Layout::Replaced
664         https://bugs.webkit.org/show_bug.cgi?id=194139
665
666         Reviewed by Antti Koivisto.
667
668         744
669
670         * LayoutReloaded/misc/LFC-passing-tests.txt:
671
672 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
673
674         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
675         https://bugs.webkit.org/show_bug.cgi?id=194146
676
677         Reviewed by Xabier Rodriguez-Calvar.
678
679         It allows to open relative paths.
680
681         * MiniBrowser/wpe/main.cpp:
682         (main):
683
684 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
685
686         Update flakiness dashboard configuration after recent queue changes
687         https://bugs.webkit.org/show_bug.cgi?id=194127
688
689         Rubber-stamped by Aakash Jain.
690
691         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
692
693         * TestResultServer/static-dashboards/builders.jsonp:
694
695 2019-01-31  Youenn Fablet  <youenn@apple.com>
696
697         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
698         https://bugs.webkit.org/show_bug.cgi?id=194106
699         <rdar://problem/47676333>
700
701         Reviewed by Ryosuke Niwa.
702
703         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
704         (TestWebKitAPI::didFinishNavigation):
705         (TestWebKitAPI::TEST):
706         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
707
708 2019-01-31  Chris Dumez  <cdumez@apple.com>
709
710         Page zoom level is lost after a process swap or a crash
711         https://bugs.webkit.org/show_bug.cgi?id=194105
712         <rdar://problem/47610781>
713
714         Reviewed by Alex Christensen.
715
716         Add API test coverage.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
719         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
720
721 2019-01-31  Alex Christensen  <achristensen@webkit.org>
722
723         Revert r238819 which is unneeded and caused a performance regression.
724         https://bugs.webkit.org/show_bug.cgi?id=192272
725         <rdar://problem/46664625>
726
727         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
728         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
729         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
730
731 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
732
733         Formalize WebKitAdditions mechanism of LoadOptimizer
734         https://bugs.webkit.org/show_bug.cgi?id=193886
735         <rdar://problem/47696809>
736
737         Reviewed by Brent Fulgham.
738
739         * MiniBrowser/MiniBrowser.entitlements:
740         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
741
742 2019-01-31  Zalan Bujtas  <zalan@apple.com>
743
744         [LFC] Margin before/after/start/end initial value is 0 and not auto.
745         https://bugs.webkit.org/show_bug.cgi?id=194090
746
747         Reviewed by Antti Koivisto.
748
749         * LayoutReloaded/misc/LFC-passing-tests.txt:
750
751 2019-01-31  Zalan Bujtas  <zalan@apple.com>
752
753         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
754         https://bugs.webkit.org/show_bug.cgi?id=194074
755
756         Reviewed by Antti Koivisto.
757
758         * LayoutReloaded/misc/LFC-passing-tests.txt:
759
760 2019-01-31  Zalan Bujtas  <zalan@apple.com>
761
762         [LFC][BFC] Add support for block level replaced box.
763         https://bugs.webkit.org/show_bug.cgi?id=194071
764
765         Reviewed by Antti Koivisto.
766
767         * LayoutReloaded/misc/LFC-passing-tests.txt:
768
769 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
770
771         Fix WebKitTestRunner's testPath with Windows full paths
772         https://bugs.webkit.org/show_bug.cgi?id=194012
773
774         Reviewed by Alex Christensen.
775
776         updateTestOptionsFromTestHeader failed to open test files because
777         testPath returned wrong file paths. It returned a path "/C:/..."
778         if a URL "file:///C:/..." was given.
779
780         * WebKitTestRunner/TestController.cpp:
781         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
782
783 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
784
785         [WPE] Bump font related dependencies to match the GTK+ port
786         https://bugs.webkit.org/show_bug.cgi?id=194017
787
788         Reviewed by Žan Doberšek.
789
790         * wpe/jhbuild.modules:
791         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
792         * wpe/patches/icudata-stdlibs.patch: Added.
793
794 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
795
796         Enable swipe tests on iOS
797         https://bugs.webkit.org/show_bug.cgi?id=194076
798
799         Reviewed by Geoffrey Garen.
800
801         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
802         it causes a debug assertion failure in runUIScript.
803
804         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
805         (WTR::UIScriptController::beginBackSwipe):
806         (WTR::UIScriptController::completeBackSwipe):
807
808 2019-01-30  Keith Rollin  <krollin@apple.com>
809
810         Use correct printf format specifier
811         https://bugs.webkit.org/show_bug.cgi?id=194062
812         <rdar://problem/47686167>
813
814         Reviewed by Alexey Proskuryakov.
815
816         LayoutTestSpellChecker.mm is trying to format a variable of type
817         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
818         actually an unsigned long long. Fix this by formatting with %llu.
819
820         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
821         (-[LayoutTestTextCheckingResult description]):
822
823 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
824
825         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
826         https://bugs.webkit.org/show_bug.cgi?id=193979
827
828         Reviewed by Wenson Hsieh.
829
830         Fix the test for iOS. Make the test work with iOS UA string.
831
832         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
833
834 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
835
836         Replace High Sierra LLINT CLoop bot due to hardware failure
837         https://bugs.webkit.org/show_bug.cgi?id=194066
838
839         Reviewed by Aakash Jain.
840
841         * BuildSlaveSupport/build.webkit.org-config/config.json:
842
843 2019-01-30  Keith Rollin  <krollin@apple.com>
844
845         [NSDragItem init] is unavailable
846         https://bugs.webkit.org/show_bug.cgi?id=194059
847         <rdar://problem/47685715>
848
849         Reviewed by Wenson Hsieh.
850
851         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
852         DumpRenderTree and TestWebKitAPI, which both try to create an
853         NSDragItem in a manner that invokes this method. Address this by using
854         -initWithPasteboardWriter instead.
855
856         Note that the parameter passed to initWithPasteboardWriter is likely
857         incorrect. In both cases, the object passed does not conform to
858         NSPasteboardWriting. However, with this fix, we're no worse off than
859         before, and can now perform builds with newer compilers and SDKs until
860         a real fix can be crafted. That work is tracked in
861         https://bugs.webkit.org/show_bug.cgi?id=194060
862
863         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
864         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
865         * TestWebKitAPI/mac/TestDraggingInfo.mm:
866         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
867
868 2019-01-30  Daniel Bates  <dabates@apple.com>
869
870         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
871         https://bugs.webkit.org/show_bug.cgi?id=192824
872         <rdar://problem/47100332>
873
874         Reviewed by Wenson Hsieh.
875
876         Fix a bug where the wrong usage code was used for F13 thru F24.
877
878         * WebKitTestRunner/ios/HIDEventGenerator.mm:
879         (keyCodeForDOMFunctionKey):
880
881 2019-01-30  Chris Dumez  <cdumez@apple.com>
882
883         Regression(PSON) Load hang can occur on history navigation
884         https://bugs.webkit.org/show_bug.cgi?id=194030
885         <rdar://problem/47656939>
886
887         Reviewed by Antti Koivisto.
888
889         Add API test coverage.
890
891         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
892
893 2019-01-30  Zalan Bujtas  <zalan@apple.com>
894
895         [LFC] Expand tests coverage.
896
897         Unreviewed test gardening.
898
899         * LayoutReloaded/misc/LFC-passing-tests.txt:
900
901 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
902
903         [Flatpak] Add openjpeg support
904         https://bugs.webkit.org/show_bug.cgi?id=194019
905
906         Reviewed by Michael Catanzaro.
907
908         * flatpak/org.webkit.CommonModules.yaml:
909
910 2019-01-30  Commit Queue  <commit-queue@webkit.org>
911
912         Unreviewed, rolling out r240708.
913         https://bugs.webkit.org/show_bug.cgi?id=194022
914
915         It broke WPE build (Requested by KaL on #webkit).
916
917         Reverted changeset:
918
919         "[WPE] Bump font related dependencies to match the GTK+ port"
920         https://bugs.webkit.org/show_bug.cgi?id=194017
921         https://trac.webkit.org/changeset/240708
922
923 2019-01-30  Zalan Bujtas  <zalan@apple.com>
924
925         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
926         https://bugs.webkit.org/show_bug.cgi?id=194001
927
928         Reviewed by Antti Koivisto.
929
930         * LayoutReloaded/misc/LFC-passing-tests.txt:
931
932 2019-01-30  Zalan Bujtas  <zalan@apple.com>
933
934         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
935         https://bugs.webkit.org/show_bug.cgi?id=194020
936
937         Reviewed by Antti Koivisto.
938
939         * LayoutReloaded/misc/LFC-passing-tests.txt:
940
941 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
942
943         AX: Support color well on iOS
944         https://bugs.webkit.org/show_bug.cgi?id=194010
945
946         Reviewed by Joanmarie Diggs.
947
948         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
949         (WTR::AccessibilityUIElement::stringAttributeValue):
950
951 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
952
953         [WPE] Bump font related dependencies to match the GTK+ port
954         https://bugs.webkit.org/show_bug.cgi?id=194017
955
956         Reviewed by Žan Doberšek.
957
958         * wpe/jhbuild.modules:
959         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
960         * wpe/patches/icudata-stdlibs.patch: Added.
961
962 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
963
964         [Mac] Update window scale API usage
965         https://bugs.webkit.org/show_bug.cgi?id=193991
966         rdar://problem/47614795
967
968         Reviewed by Tim Horton.
969
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (changeWindowScaleIfNeeded):
972         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
973         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
974         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
975
976 2019-01-29  Chris Dumez  <cdumez@apple.com>
977
978         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
979         https://bugs.webkit.org/show_bug.cgi?id=193977
980         <rdar://problem/47643716>
981
982         Reviewed by Geoff Garen.
983
984         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
985         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
986         to the previous provisional committing *before* we make the last load. 
987
988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
989
990 2019-01-29  Youenn Fablet  <youenn@apple.com>
991
992         Adopt new SPI to evaluate server certificate trust
993         https://bugs.webkit.org/show_bug.cgi?id=193355
994
995         Reviewed by Alex Christensen.
996
997         Add infrastructure to handle HTTPS server trust evaluation testing.
998
999         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1001         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1002         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1003         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1005         * WebKitTestRunner/TestController.cpp:
1006         (WTR::TestController::resetPreferencesToConsistentValues):
1007         (WTR::TestController::didReceiveAuthenticationChallenge):
1008         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1009         * WebKitTestRunner/TestController.h:
1010         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1011         * WebKitTestRunner/TestInvocation.cpp:
1012         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1013         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1014         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1015
1016 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1017
1018         [ews-build] Add build step to print bot Configuration
1019         https://bugs.webkit.org/show_bug.cgi?id=193887
1020
1021         Reviewed by Lucas Forschler.
1022
1023         * BuildSlaveSupport/ews-build/steps.py:
1024         (PrintConfiguration): Build step to print configuration.
1025         * BuildSlaveSupport/ews-build/factories.py:
1026
1027 2019-01-29  Chris Dumez  <cdumez@apple.com>
1028
1029         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1030         https://bugs.webkit.org/show_bug.cgi?id=193967
1031         <rdar://problem/47635348>
1032
1033         Reviewed by Alex Christensen.
1034
1035         Add API test coverage.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1038         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1039
1040 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1041
1042         [ews-app] Handle incoming results data
1043         https://bugs.webkit.org/show_bug.cgi?id=193973
1044
1045         Reviewed by Lucas Forschler.
1046
1047         * BuildSlaveSupport/ews-app/ews/views/results.py:
1048
1049 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1050
1051         [ews-app] Make the results url generic
1052         https://bugs.webkit.org/show_bug.cgi?id=193928
1053
1054         Reviewed by Lucas Forschler.
1055
1056         * BuildSlaveSupport/ews-app/ews/urls.py:
1057
1058 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1059
1060         [ews-build] Configure buildbot to send events to ews-app
1061         https://bugs.webkit.org/show_bug.cgi?id=193968
1062
1063         Reviewed by Lucas Forschler.
1064
1065         * BuildSlaveSupport/ews-build/events.py: Added.
1066         * BuildSlaveSupport/ews-build/master.cfg:
1067
1068 2019-01-29  Keith Rollin  <krollin@apple.com>
1069
1070         Add .xcfilelists to Run Script build phases
1071         https://bugs.webkit.org/show_bug.cgi?id=193792
1072         <rdar://problem/47201785>
1073
1074         Reviewed by Alex Christensen.
1075
1076         As part of supporting XCBuild, update the necessary Run Script build
1077         phases in their Xcode projects to refer to their associated
1078         .xcfilelist files.
1079
1080         Note that the addition of these files bumps the Xcode project version
1081         number to something that's Xcode 10 compatible. This change means that
1082         older versions of the Xcode IDE can't read these projects. Nor can it
1083         fully load workspaces that refer to these projects (the updated
1084         projects are shown as non-expandable placeholders). `xcodebuild` can
1085         still build these projects; it's just that the IDE can't open them.
1086
1087         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1088         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1089
1090 2019-01-29  John Wilander  <wilander@apple.com>
1091
1092         Add data abstraction and validation for Ad Click Attribution
1093         https://bugs.webkit.org/show_bug.cgi?id=193916
1094         <rdar://problem/47603481>
1095
1096         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1097
1098         Ad click attribution has two steps. First, the storage of an ad
1099         campaign ID for a click that takes the user to a destination
1100         site. Second, a conversion on the destination site that can be
1101         attributed to the ad click.
1102
1103         This patch adds a class that represents a request for ad click
1104         attribution. Validation makes sure that the bits of entropy
1105         reported through this mechanism is limited.
1106
1107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1108         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1109         (TestWebKitAPI::TEST):
1110
1111 2019-01-29  Chris Dumez  <cdumez@apple.com>
1112
1113         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1114         https://bugs.webkit.org/show_bug.cgi?id=193932
1115         <rdar://problem/47598947>
1116
1117         Reviewed by Brady Eidson.
1118
1119         Add API test coverage.
1120
1121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1122
1123 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1124
1125         Adding new passing LFC tests.
1126
1127         Unreviewed test gardening.
1128
1129         * LayoutReloaded/misc/LFC-passing-tests.txt:
1130
1131 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1132
1133         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1134         https://bugs.webkit.org/show_bug.cgi?id=193964
1135
1136         Reviewed by Antti Koivisto.
1137
1138         * LayoutReloaded/misc/LFC-passing-tests.txt:
1139
1140 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1141
1142         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1143         https://bugs.webkit.org/show_bug.cgi?id=193954
1144
1145         Reviewed by Antti Koivisto.
1146
1147         * LayoutReloaded/misc/LFC-passing-tests.txt:
1148
1149 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1150
1151         WebDriver: add support for running subtests
1152         https://bugs.webkit.org/show_bug.cgi?id=193904
1153
1154         Reviewed by Michael Catanzaro.
1155
1156         pytest already supports it by passing test.py::subtest, so we can do the same.
1157
1158         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1159         (get_item_name): Made this global.
1160         (CollectRecorder.__init__): Receive the parameter to ignore.
1161         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1162         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1163         (collect): Add parameter to ignore.
1164         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1165         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1166         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1167         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1168         (WebDriverTestRunnerSelenium.run): Ditto.
1169         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1170         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1171         (WebDriverTestRunnerW3C.run): Ditto.
1172
1173 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1174
1175         User agent string override for navigator.userAgent should be site specific quirks
1176         https://bugs.webkit.org/show_bug.cgi?id=193950
1177
1178         Reviewed by Brent Fulgham.
1179
1180         Updated per the _WKWebsitePolicies rename.
1181
1182         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1183         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1184
1185 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1186
1187         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1188         https://bugs.webkit.org/show_bug.cgi?id=193941
1189
1190         Reviewed by Alex Christensen.
1191
1192         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1193         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1194         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1195         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1196         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1197         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1198         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1199         * TestWebKitAPI/Tests/WTF/Time.cpp:
1200         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1201         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1202         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1203         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1204
1205 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1206
1207         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1208
1209         * Scripts/webkitpy/common/config/contributors.json:
1210
1211 2019-01-28  Andy Estes  <aestes@apple.com>
1212
1213         [watchOS] Enable Parental Controls content filtering
1214         https://bugs.webkit.org/show_bug.cgi?id=193939
1215         <rdar://problem/46641912>
1216
1217         Reviewed by Ryosuke Niwa.
1218
1219         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1220
1221 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1222
1223         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1224         <https://webkit.org/b/193884>
1225
1226         Reviewed by Jiewen Tan.
1227
1228         * Scripts/webkitpy/style/checkers/cpp.py:
1229         (check_language): Add LocalAuthentication to
1230         `frameworks_with_soft_links`.
1231
1232 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1233
1234         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1235         https://bugs.webkit.org/show_bug.cgi?id=193891
1236
1237         Reviewed by Ross Kirsling.
1238
1239         There were three problems in window sizes of WebView and the host window.
1240         1. The sizes of pixel image output were incorrect.
1241         2. The host window is going to appear after window.resize was invoked.
1242         3. window.resize resized only the host window, not WebView.
1243
1244         This change solves them with a following approach.
1245         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1246         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1247            as well as DumpRenderTree in order to match the client area and the window area.
1248         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1249         d. PlatformWebView::setWindowFrame changes both window sizes.
1250         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1251
1252         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1253         (WTR::PlatformWebView::PlatformWebView): Create the host window
1254         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1255         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1256         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1257
1258 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1259
1260         [ews-app] Add method to save Step data to database
1261         https://bugs.webkit.org/show_bug.cgi?id=193890
1262
1263         Reviewed by Lucas Forschler.
1264
1265         * BuildSlaveSupport/ews-app/ews/models/step.py:
1266         (Step.save_step): Method to save step data.
1267         (Step.update_step): Method to update step data.
1268         (Step.get_existing_step): Method to fetch existing step from database.
1269         (Step.is_valid_result): Method to validate valid step result.
1270
1271 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1272
1273         [ews-app] Add method to save Build data to database
1274         https://bugs.webkit.org/show_bug.cgi?id=193735
1275
1276         Reviewed by Lucas Forschler.
1277
1278         * BuildSlaveSupport/ews-app/ews/models/build.py:
1279         (Build.save_build): Method to save build information to database.
1280         (Build.get_existing_build): Method to fetch existing build from database.
1281         (Build.is_valid_result): Method to validate build result.
1282         * BuildSlaveSupport/ews-app/ews/common/util.py:
1283         (is_valid_int_id): Method to validate valid id.
1284
1285 2019-01-28  Chris Dumez  <cdumez@apple.com>
1286
1287         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1288         https://bugs.webkit.org/show_bug.cgi?id=193915
1289         <rdar://problem/47560907>
1290
1291         Reviewed by Alex Christensen.
1292
1293         Add API test coverage.
1294
1295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1296
1297 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1298
1299         [ews-app] Rename id variables
1300         https://bugs.webkit.org/show_bug.cgi?id=193883
1301
1302         Reviewed by Lucas Forschler.
1303
1304         * BuildSlaveSupport/ews-app/ews/models/build.py:
1305         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1306         * BuildSlaveSupport/ews-app/ews/models/step.py:
1307         * BuildSlaveSupport/ews-app/ews/urls.py:
1308         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1309         * BuildSlaveSupport/ews-app/ews/views/results.py:
1310         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1311
1312 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1313
1314         [ews-app] Allow certain fields to be empty
1315         https://bugs.webkit.org/show_bug.cgi?id=193892
1316
1317         Reviewed by Lucas Forschler.
1318
1319         * BuildSlaveSupport/ews-app/ews/models/build.py:
1320         * BuildSlaveSupport/ews-app/ews/models/step.py:
1321
1322 2019-01-28  Rob Buis  <rbuis@igalia.com>
1323
1324         Update MIME type parser
1325         https://bugs.webkit.org/show_bug.cgi?id=180526
1326
1327         Reviewed by Frédéric Wang.
1328
1329         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1330         (TestWebKitAPI::TEST):
1331
1332 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1333
1334         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1335         https://bugs.webkit.org/show_bug.cgi?id=193896
1336
1337         Reviewed by Antti Koivisto.
1338
1339         * LayoutReloaded/misc/LFC-passing-tests.txt:
1340
1341 2018-12-15  Darin Adler  <darin@apple.com>
1342
1343         Replace many uses of String::format with more type-safe alternatives
1344         https://bugs.webkit.org/show_bug.cgi?id=192742
1345
1346         Reviewed by Mark Lam.
1347
1348         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1349         (WTR::cacheTestRunnerCallback): Use makeString.
1350         * WebKitTestRunner/TestController.cpp:
1351         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1352         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1353
1354 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1355
1356         Use a load optimizer for some sites
1357         https://bugs.webkit.org/show_bug.cgi?id=193881
1358         <rdar://problem/46325455>
1359
1360         Reviewed by Brent Fulgham.
1361
1362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1363         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1364
1365 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1366
1367         AX: Introduce a static accessibility tree
1368         https://bugs.webkit.org/show_bug.cgi?id=193348
1369         <rdar://problem/47203295>
1370
1371         Reviewed by Ryosuke Niwa.
1372
1373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1374
1375 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1376
1377         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1378         https://bugs.webkit.org/show_bug.cgi?id=193867
1379
1380         Reviewed by Antti Koivisto.
1381
1382         * LayoutReloaded/misc/LFC-passing-tests.txt:
1383
1384 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1385
1386         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1387         https://bugs.webkit.org/show_bug.cgi?id=193865
1388
1389         Reviewed by Antti Koivisto.
1390
1391         * LayoutReloaded/misc/LFC-passing-tests.txt:
1392
1393 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1394
1395         Need a mechanism to override navigator.userAgent
1396         https://bugs.webkit.org/show_bug.cgi?id=193762
1397         <rdar://problem/47504939>
1398
1399         Reviewed by Brent Fulgham.
1400
1401         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1404         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1405         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1406
1407 2019-01-25  Dean Jackson  <dino@apple.com>
1408
1409         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1410         https://bugs.webkit.org/show_bug.cgi?id=193831
1411         <rdar://problem/47399263>
1412
1413         Reviewed by Chris Dumez.
1414
1415         Two new tests that exercise cross-origin and same-origin System
1416         Previews.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1419
1420 2019-01-25  Keith Rollin  <krollin@apple.com>
1421
1422         Update Xcode projects with "Check .xcfilelists" build phase
1423         https://bugs.webkit.org/show_bug.cgi?id=193790
1424         <rdar://problem/47201374>
1425
1426         Reviewed by Alex Christensen.
1427
1428         Support for XCBuild includes specifying inputs and outputs to various
1429         Run Script build phases. These inputs and outputs are specified as
1430         .xcfilelist files. Once created, these .xcfilelist files need to be
1431         kept up-to-date. In order to check that they are up-to-date or not,
1432         add an Xcode build step that invokes an external script that performs
1433         the checking. If the .xcfilelists are found to be out-of-date, update
1434         them, halt the build, and instruct the developer to restart the build
1435         with up-to-date files.
1436
1437         At this time, the checking and regenerating is performed only if the
1438         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1439         who want to use this facility can set this variable and test out the
1440         checking/regenerating. Once it seems like there are no egregious
1441         issues that upset a developer's workflow, we'll unconditionally enable
1442         this facility.
1443
1444         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1445         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1446         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1447         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1448
1449 2019-01-25  Keith Rollin  <krollin@apple.com>
1450
1451         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1452         https://bugs.webkit.org/show_bug.cgi?id=193781
1453         <rdar://problem/47201153>
1454
1455         Reviewed by Alex Christensen.
1456
1457         Part of generating the .xcfilelists used as part of adopting XCBuild
1458         includes running `make DerivedSources.make` from a standalone script.
1459         It’s important for this invocation to have the same environment as
1460         when the actual build invokes `make DerivedSources.make`. If the
1461         environments are different, then the two invocations will provide
1462         different results. In order to get the same environment in the
1463         standalone script, have the script launch xcodebuild targeting the
1464         "Apply Configuration to XCFileLists" build target, which will then
1465         re-invoke our standalone script. The script is now running again, this
1466         time in an environment with all workspace, project, target, xcconfig
1467         and other environment variables established.
1468
1469         The "Apply Configuration to XCFileLists" build target accomplishes
1470         this task via a small embedded shell script that consists only of:
1471
1472             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1473
1474         The process that invokes "Apply Configuration to XCFileLists" first
1475         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1476         evaluated and exports it into the shell environment. When xcodebuild
1477         is invoked, it inherits the value of this variable and can `eval` the
1478         contents of that variable. Our external standalone script can then set
1479         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1480         of command-line parameters needed to restart itself in the appropriate
1481         state.
1482
1483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1484         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1485
1486 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1487
1488         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1489         https://bugs.webkit.org/show_bug.cgi?id=193802
1490         <rdar://problem/46010580>
1491
1492         Reviewed by Andy Estes.
1493
1494         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1495         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1496         (TEST):
1497
1498 2019-01-25  Daniel Bates  <dabates@apple.com>
1499
1500         [iOS] uiController.keyDown() does not translate Control modified key
1501         https://bugs.webkit.org/show_bug.cgi?id=192898
1502
1503         Reviewed by Wenson Hsieh.
1504
1505         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1506         key translation, as applicable. Among other cases, key translation occurs when performing
1507         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1508         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1509         human pressing down and releasing key(s) using a hardware keyboard.
1510
1511         * WebKitTestRunner/ios/HIDEventGenerator.h:
1512         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1513         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1514
1515         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1516         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1517         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1518         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1519         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1520         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1521         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1522         (-[HIDEventGenerator longPress:completionBlock:]):
1523         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1524         Update code for above renaming.
1525
1526         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1527         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1528
1529         (-[HIDEventGenerator keyDown:]): Added.
1530         (-[HIDEventGenerator keyUp:]): Added.
1531         (-[HIDEventGenerator keyPress:completionBlock:]):
1532         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1533         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1534         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1535         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1536         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1537         (WTR::parseModifier): Deleted.
1538
1539 2019-01-25  Keith Rollin  <krollin@apple.com>
1540
1541         Complete the implementation of generate-xcfilelists
1542         https://bugs.webkit.org/show_bug.cgi?id=193782
1543
1544         Reviewed by Alex Christensen.
1545
1546         A preliminary version of generate-xcfilelists was added in r238008.
1547         This patch updates that script in order to:
1548
1549         - Support checking of .xcfilelists
1550         - Perform better execution of `make DerivedSources.make` by
1551           relaunching generate-xcfilelists under xcodebuild
1552         - Support incremental generation and checking of .xcfilelists
1553         - Support supplementary .xcfilelists files from WebKitAdditions
1554         - Support being wrapped by parallel version of generate-xcfilelists in
1555           Internal that adds support for (re)generating WebKit projects in
1556           that repo.
1557         - Support builds that have been performed in WebKitBuild as well as
1558           ~/Library/Developer/code/DerivedData
1559         - Increase robustness and debugging facilities.
1560
1561         * Scripts/generate-xcfilelists:
1562
1563 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1564
1565         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1566         https://bugs.webkit.org/show_bug.cgi?id=193297
1567         <rdar://problem/47158841>
1568
1569         Unreviewed test case fix.
1570
1571         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1572         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1573
1574         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1575         (TEST):
1576
1577 2019-01-25  Keith Rollin  <krollin@apple.com>
1578
1579         Update existing .xcfilelists
1580         https://bugs.webkit.org/show_bug.cgi?id=193791
1581         <rdar://problem/47201706>
1582
1583         Reviewed by Alex Christensen.
1584
1585         Many .xcfilelist files were added in r238824 in order to support
1586         XCBuild. Update these with recent changes to the set of build files
1587         and with the current generate-xcfilelist script.
1588
1589         * DumpRenderTree/DerivedSources-input.xcfilelist:
1590         * DumpRenderTree/DerivedSources-output.xcfilelist:
1591         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1592         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1593
1594 2019-01-25  Keith Rollin  <krollin@apple.com>
1595
1596         Fix missing dependencies in extract-dependencies-from-makefile
1597         https://bugs.webkit.org/show_bug.cgi?id=193783
1598         <rdar://problem/47201571>
1599
1600         Reviewed by Alex Christensen.
1601
1602         The extract-dependencies-from-makefile script generates .xcfilelists
1603         for XCBuild by invoking a makefile in --debug mode, parsing the
1604         dependency information in the output, and extracting information
1605         regarding targets and dependents. However, the way `make` emits this
1606         dependency information is not rigorous, and so we need to determine
1607         what lines to look for and parse by trial and error. This approach
1608         didn't coriginally atch all the information we needed to collect, so
1609         update the script to look for the additional lines we now know to look
1610         for.
1611
1612         * Scripts/extract-dependencies-from-makefile:
1613         (Parser):
1614         (Parser.addTarget):
1615         (Parser.addPrereq):
1616         (Parser.doParse):
1617
1618 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1619
1620         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1621         https://bugs.webkit.org/show_bug.cgi?id=193297
1622         <rdar://problem/47158841>
1623
1624         Reviewed by Alex Christensen.
1625
1626         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1627             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1629         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1630         activating the message used to trigger the callback when it is set.
1631
1632 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1633
1634         WKWebView.goBack should reload if there is a safe browsing warning
1635         https://bugs.webkit.org/show_bug.cgi?id=193805
1636         <rdar://problem/46908216>
1637
1638         Reviewed by Geoff Garen.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1641         (+[Simple3LookupContext sharedLookupContext]):
1642         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1643         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1644         (TEST):
1645
1646 2019-01-25  Chris Dumez  <cdumez@apple.com>
1647
1648         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1649         https://bugs.webkit.org/show_bug.cgi?id=193788
1650         <rdar://problem/47531231>
1651
1652         Reviewed by Alex Christensen.
1653
1654         Add API test coverage.
1655
1656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1657         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1658
1659 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1660
1661         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1662         https://bugs.webkit.org/show_bug.cgi?id=193771
1663
1664         Unreviewed infrastructure fix.
1665
1666         * Scripts/webkitpy/port/darwin.py:
1667         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1668
1669 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1670
1671         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1672
1673 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1674
1675         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1676
1677         * Scripts/webkitpy/common/config/contributors.json:
1678
1679 2019-01-25  Chris Dumez  <cdumez@apple.com>
1680
1681         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1682         https://bugs.webkit.org/show_bug.cgi?id=193779
1683         <rdar://problem/46170903>
1684
1685         Reviewed by Antti Koivisto.
1686
1687         Add API test that quickly navigates forward to a previous process without waiting for it to
1688         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1689         the process' previous page when reconnecting the it for the forward navigation.
1690
1691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1692
1693 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1694
1695         Need a way for JavaScript (or bundle) code to participate in undo
1696         https://bugs.webkit.org/show_bug.cgi?id=190009
1697         <rdar://problem/44807048>
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1702         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1703
1704         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1705         (WTR::UIScriptController::lastUndoLabel const):
1706         (WTR::UIScriptController::firstRedoLabel const):
1707         (WTR::UIScriptController::platformUndoManager const):
1708         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1709         (WTR::UIScriptController::lastUndoLabel const):
1710         (WTR::UIScriptController::firstRedoLabel const):
1711         (WTR::UIScriptController::platformUndoManager const):
1712         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1713         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1714         (WTR::UIScriptController::lastUndoLabel const):
1715         (WTR::UIScriptController::firstRedoLabel const):
1716         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1717         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1718         (WTR::UIScriptController::lastUndoLabel const):
1719         (WTR::UIScriptController::firstRedoLabel const):
1720         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1721         (WTR::UIScriptController::platformUndoManager const):
1722         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1723         (WTR::UIScriptController::platformUndoManager const):
1724
1725 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1726
1727         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1728         https://bugs.webkit.org/show_bug.cgi?id=193824
1729
1730         Reviewed by Antti Koivisto.
1731
1732         * LayoutReloaded/misc/LFC-passing-tests.txt:
1733
1734 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1735
1736         Update macOS JSC bot configurations
1737         https://bugs.webkit.org/show_bug.cgi?id=193739
1738
1739         Reviewed by Alexey Proskuryakov.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1743         (BubbleQueueServer): Move JSC EWS to Mojave section.
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1745         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1746         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1747
1748 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1749
1750         [Win][WebKitTestRunner] Implement EventSenderProxy
1751         https://bugs.webkit.org/show_bug.cgi?id=193755
1752
1753         Reviewed by Don Olmstead.
1754
1755         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1756         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1757         (WTR::EventSenderProxy::dispatchMessage):
1758         (WTR::EventSenderProxy::EventSenderProxy):
1759         (WTR::EventSenderProxy::mouseDown):
1760         (WTR::EventSenderProxy::mouseUp):
1761         (WTR::EventSenderProxy::mouseMoveTo):
1762         (WTR::EventSenderProxy::mouseScrollBy):
1763         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1764
1765 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1766
1767         Unreviewed fix for API test failure after r240437.
1768
1769         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1770
1771         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1772
1773 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1774
1775         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1776         https://bugs.webkit.org/show_bug.cgi?id=193787
1777         <rdar://problem/47497634>
1778
1779         Reviewed by Alexey Proskuryakov.
1780
1781         * Scripts/webkitdirs.pm:
1782         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1783
1784 2019-01-24  Truitt Savell  <tsavell@apple.com>
1785
1786         Unreviewed, rolling out r240446.
1787
1788         Casued 5 API failures
1789
1790         Reverted changeset:
1791
1792         "Activate the WebResourceLoadStatisticsStore in the
1793         NetworkProcess and deactivate it in the UIProcess."
1794         https://bugs.webkit.org/show_bug.cgi?id=193297
1795         https://trac.webkit.org/changeset/240446
1796
1797 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1798
1799         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1800         https://bugs.webkit.org/show_bug.cgi?id=193741
1801         <rdar://problem/47135030>
1802
1803         Reviewed by Antti Koivisto and Simon Fraser.
1804
1805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1807         (TestWebKitAPI::TEST):
1808
1809 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1810
1811         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1812         https://bugs.webkit.org/show_bug.cgi?id=193297
1813         <rdar://problem/47158841>
1814
1815         Reviewed by Alex Christensen.
1816
1817         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1818         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1819         activating the message used to trigger the callback when it is set.
1820
1821 2019-01-24  John Wilander  <wilander@apple.com>
1822
1823         Add Ad Click Attribution as an internal/experimental feature
1824         https://bugs.webkit.org/show_bug.cgi?id=193685
1825         <rdar://problem/47450399>
1826
1827         Reviewed by Brent Fulgham.
1828
1829         Added test option adClickAttributionEnabled.
1830
1831         * DumpRenderTree/TestOptions.cpp:
1832         (TestOptions::TestOptions):
1833         * DumpRenderTree/TestOptions.h:
1834         * DumpRenderTree/mac/DumpRenderTree.mm:
1835         (setWebPreferencesForTestOptions):
1836
1837 2019-01-24  Antti Koivisto  <antti@apple.com>
1838
1839         [PSON] Flash on back navigation on Mac
1840         https://bugs.webkit.org/show_bug.cgi?id=193716
1841         <rdar://problem/47148458>
1842
1843         Reviewed by Chris Dumez.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1846
1847         Closing of the previous page is delayed so waiting for didFinishNavigation is
1848         not sufficient to guarantee we have received all the messages. Wait for them.
1849
1850 2019-01-24  Chris Dumez  <cdumez@apple.com>
1851
1852         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1853         https://bugs.webkit.org/show_bug.cgi?id=193761
1854         <rdar://problem/47456405>
1855
1856         Reviewed by Alex Christensen.
1857
1858         Add API test coverage.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1861
1862 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1863
1864         webkitpy: Missing PID in crashlog name should not be fatal
1865         https://bugs.webkit.org/show_bug.cgi?id=193771
1866
1867         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1868         of raising an exception.
1869
1870         Reviewed by Lucas Forschler.
1871
1872         * Scripts/webkitpy/port/darwin.py:
1873         (DarwinPort._merge_crash_logs):
1874
1875 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1876
1877         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1878         https://bugs.webkit.org/show_bug.cgi?id=193746
1879
1880         Reviewed by Youenn Fablet.
1881
1882         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1883         so we'd best just not call it.
1884
1885         * Scripts/webkitpy/w3c/test_exporter.py:
1886         (WebPlatformTestExporter.create_branch_with_patch):
1887
1888 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1889
1890         Move FileSystem to WTF
1891         https://bugs.webkit.org/show_bug.cgi?id=193602
1892
1893         Reviewed by Yusuke Suzuki.
1894
1895         * DumpRenderTree/win/DumpRenderTree.cpp:
1896         * TestWebKitAPI/CMakeLists.txt:
1897         * TestWebKitAPI/PlatformGTK.cmake:
1898         * TestWebKitAPI/PlatformJSCOnly.cmake:
1899         * TestWebKitAPI/PlatformPlayStation.cmake:
1900         * TestWebKitAPI/PlatformWPE.cmake:
1901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1902         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1903         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1904         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1905         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1906         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1907         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1908         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1909         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1910         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1911
1912 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1913
1914         [WPE] Remove hard dependency on subprocess32 for the API tests
1915
1916         Rubber-stamped by Carlos Garcia Campos.
1917
1918         * glib/api_test_runner.py:
1919         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1920         its presence only when running WPEQt tests.
1921
1922 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         [GLIB] Expose JavaScriptCore options in GLib public API
1925         https://bugs.webkit.org/show_bug.cgi?id=188742
1926
1927         Reviewed by Michael Catanzaro.
1928
1929         Add a test for the new API.
1930
1931         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1932         (testsJSCOptions):
1933         (main):
1934
1935 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1936
1937         [GTK][WPE] Support JPEG 2000 images
1938         https://bugs.webkit.org/show_bug.cgi?id=186272
1939
1940         Reviewed by Žan Doberšek.
1941
1942         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1943
1944         * gtk/jhbuild.modules:
1945         * wpe/jhbuild.modules:
1946
1947 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1948
1949         check-webkit-style should warn when using soft-linking macros in a header
1950         <https://webkit.org/b/193750>
1951
1952         Reviewed by Darin Adler.
1953
1954         * Scripts/webkitpy/style/checkers/cpp.py:
1955         (check_language): Add softlink/header check by refactoring the
1956         softlink/framework check.
1957         (CppChecker): Enable softlink/header check by default.
1958         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1959         (CppStyleTest.test_softlink_framework): Rename from
1960         CppStyleTest.test_softlink() and change test framework name in
1961         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1962         files. Set file_name for macros that only appear in headers.
1963         (CppStyleTest.test_softlink_header): Add tests for using
1964         soft-link macros in headers.
1965
1966 2019-01-23  Chris Dumez  <cdumez@apple.com>
1967
1968         Deprecate API to limit the maximum number of WebProcesses
1969         https://bugs.webkit.org/show_bug.cgi?id=193725
1970         <rdar://problem/47464879>
1971
1972         Reviewed by Geoff Garen.
1973
1974         Update existing API tests to stop using deprecated API.
1975
1976         * MiniBrowser/mac/AppDelegate.m:
1977         (defaultConfiguration):
1978         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1979         (TestWebKitAPI::TEST):
1980         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1981         (TestWebKitAPI::TEST):
1982         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1983         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1984         (TEST):
1985         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1986         (TEST):
1987
1988 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-app] Rename ews model buildermappings to buildermapping
1991         https://bugs.webkit.org/show_bug.cgi?id=193729
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1996         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1997         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1998
1999 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews-app] Rename ews model steps to step
2002         https://bugs.webkit.org/show_bug.cgi?id=193697
2003
2004         Reviewed by Lucas Forschler.
2005
2006         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2007         (Step): Renamed Steps to Step.
2008
2009 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2010
2011         Clean up IndexedDB files between tests
2012         https://bugs.webkit.org/show_bug.cgi?id=192796
2013         <rdar://problem/46824999>
2014
2015         Reviewed by Geoffrey Garen.
2016
2017         * DumpRenderTree/mac/DumpRenderTree.mm:
2018         (runTest):
2019         * WebKitTestRunner/TestController.cpp:
2020         (WTR::TestController::resetStateToConsistentValues):
2021         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2022         (WTR::RemoveAllIndexedDatabasesCallback):
2023         (WTR::TestController::ClearIndexedDatabases):
2024         * WebKitTestRunner/TestController.h:
2025         * WebKitTestRunner/TestInvocation.cpp:
2026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2027
2028 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2029
2030         [ews-app] Rename ews model Builds to Build
2031         https://bugs.webkit.org/show_bug.cgi?id=193695
2032
2033         Reviewed by Lucas Forschler.
2034
2035         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2036         (Build): Renamed Builds to Build.
2037
2038 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2039
2040         webkitpy: Wait longer when launching WebKitTestRunner
2041         https://bugs.webkit.org/show_bug.cgi?id=193734
2042
2043         Reviewed by Aakash Jain.
2044
2045         * Scripts/webkitpy/port/simulator_process.py:
2046         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2047
2048 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2049
2050         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2051         https://bugs.webkit.org/show_bug.cgi?id=193182
2052         <rdar://problem/47452154>
2053
2054         Reviewed by Tim Horton.
2055
2056         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2057         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2058         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2059
2060         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2061         preventing later tests from recognizing gestures.
2062
2063         * WebKitTestRunner/ios/TestControllerIOS.mm:
2064         (WTR::TestController::platformResetStateToConsistentValues):
2065
2066         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2067
2068 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2069
2070         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2071         https://bugs.webkit.org/show_bug.cgi?id=193722
2072         <rdar://problem/47481475>
2073
2074         Reviewed by Lucas Forschler.
2075
2076         iPhone and iPad ports should both use the iOS config.
2077
2078         * Scripts/webkitpy/port/ios_simulator.py:
2079         (IPhoneSimulatorPort.__init__):
2080         (IPadSimulatorPort.__init__):
2081
2082 2019-01-23  Rob Buis  <rbuis@igalia.com>
2083
2084         Update MIME type parser
2085         https://bugs.webkit.org/show_bug.cgi?id=180526
2086
2087         Reviewed by Frédéric Wang.
2088
2089         Add unit tests for both parse modes of ParsedContentType.
2090
2091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2092         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2093         (TestWebKitAPI::TEST):
2094
2095 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-app] fetch loop should not stop on network issues
2098         https://bugs.webkit.org/show_bug.cgi?id=193666
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2103         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2104
2105 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2106
2107         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2108         https://bugs.webkit.org/show_bug.cgi?id=189165
2109         <rdar://problem/47433765>
2110
2111         Reviewed by Tim Horton.
2112
2113         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2114         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2115         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2116         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2117         would make its way to the UI process by the time the layer tree commit is finished.
2118
2119         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2120         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2121         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2122         will fail because it asks for -_autofillContext too early.
2123
2124         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2125         is handled in the UI process.
2126
2127         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2128
2129         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2130         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2131         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2132         input session.
2133
2134         (-[AutofillTestView textInputHasAutofillContext]):
2135
2136         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2137
2138         * TestWebKitAPI/cocoa/TestWKWebView.h:
2139         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2140         (nextInputSessionChangeCount):
2141
2142         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2143         This includes changing the focused element from one to another.
2144
2145         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2146         (-[TestWKWebView didStartFormControlInteraction]):
2147         (-[TestWKWebView didEndFormControlInteraction]):
2148         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2149
2150         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2151         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2152         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2153         that doesn't require an input session to one that doesn't.
2154
2155 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2156
2157         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2158         <https://webkit.org/b/193676>
2159
2160         Reviewed by Alexey Proskuryakov.
2161
2162         * Scripts/webkitpy/style/checkers/cpp.py:
2163         (check_member_initialization_list):
2164         - Don't report missing whitespace around colon if the colon at
2165           the start of the line is formatted correctly.
2166         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2167         (WebKitStyleTest.test_member_initialization_list):
2168         - Add a test for a missing permutation of existing tests.
2169         - Add a test this false-positive.
2170         - Add blank lines between subtests to make them easier to read.
2171
2172 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2173
2174         [build.webkit.org] Unit-test failure after r237113
2175         https://bugs.webkit.org/show_bug.cgi?id=193669
2176
2177         Reviewed by Michael Catanzaro.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2180         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2181         multiple or zero flags.
2182
2183 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2184
2185         Cache bytecode to disk
2186         https://bugs.webkit.org/show_bug.cgi?id=192782
2187         <rdar://problem/46084932>
2188
2189         Reviewed by Keith Miller.
2190
2191         Add test helper to execute bytecode-cache tests: it executes each test
2192         twice, the first with JSC_diskCachePath set to a temporary directory
2193         and second with JSC_forceDiskCache=true (in addition to the cache path)
2194         to guarantee that only the disk cache is being used and no new
2195         UnlinkedCodeBlocks are being created.
2196
2197         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2198         * Scripts/run-jsc-stress-tests:
2199
2200 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2201
2202         [css-logical] Implement flow-relative margin, padding and border shorthands
2203         https://bugs.webkit.org/show_bug.cgi?id=188697
2204
2205         Reviewed by Simon Fraser and Antti Koivisto.
2206
2207         * DumpRenderTree/TestOptions.cpp:
2208         (TestOptions::TestOptions):
2209         * DumpRenderTree/TestOptions.h:
2210         * DumpRenderTree/mac/DumpRenderTree.mm:
2211         (setWebPreferencesForTestOptions):
2212         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2213
2214         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2215         (JSONCSSPropertiesChecker.check_codegen_properties):
2216         Allow CSS property definitions to have a 'runtime-flag' parameter which
2217         disables the property when the specified runtime flag is disabled.
2218
2219 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2220
2221         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2222         https://bugs.webkit.org/show_bug.cgi?id=193643
2223
2224         Reviewed by Michael Catanzaro.
2225
2226         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2227         * wpe/jhbuild.modules: Ditto.
2228
2229 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2230
2231         [LFC][Floats] Take float top position into account when computing containing block height.
2232         https://bugs.webkit.org/show_bug.cgi?id=193655
2233
2234         Reviewed by Antti Koivisto.
2235
2236         * LayoutReloaded/misc/LFC-passing-tests.txt:
2237
2238 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2239
2240         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2241         <https://webkit.org/b/193645>
2242         <rdar://problem/47421574>
2243
2244         Reviewed by Alex Christensen.
2245
2246         - Now checks for local soft-linking of all frameworks that have
2247           their own *SoftLinking.{cpp,h,mm} files.
2248         - Changes softlink/uikit warning to softlink/framework.
2249
2250         * Scripts/webkitpy/style/checkers/cpp.py:
2251         (check_language):
2252         (CppChecker):
2253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2254         (CppStyleTest):
2255
2256 2019-01-20  Saam Barati  <sbarati@apple.com>
2257
2258         Rollout r240210: It broke tests on iOS
2259         https://bugs.webkit.org/show_bug.cgi?id=193640
2260
2261         Unreviewed.
2262
2263         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2264         * Scripts/run-jsc-stress-tests:
2265
2266 2019-01-20  chris fleizach  <cfleizach@apple.com>
2267
2268         AX: Support returning relative frames for accessibility
2269         https://bugs.webkit.org/show_bug.cgi?id=193414
2270         <rdar://problem/47268501>
2271
2272         Reviewed by Zalan Bujtas.
2273
2274         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2275         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2276         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2277         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2278         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2279         (WTR::attributesOfElement):
2280         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2281
2282 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2283
2284         Unreviewed, add my new email address
2285
2286         * Scripts/webkitpy/common/config/contributors.json:
2287
2288 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2289
2290         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2291         https://bugs.webkit.org/show_bug.cgi?id=193617
2292
2293         Reviewed by Antti Koivisto.
2294
2295         * LayoutReloaded/misc/LFC-passing-tests.txt:
2296
2297 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2298
2299         Unreviewed, rolling out r240209.
2300
2301         Broke GTK/WPE injected bundle
2302
2303         Reverted changeset:
2304
2305         "AX: Support returning relative frames for accessibility"
2306         https://bugs.webkit.org/show_bug.cgi?id=193414
2307         https://trac.webkit.org/changeset/240209
2308
2309 2019-01-12  Dan Bernstein  <mitz@apple.com>
2310
2311         [Cocoa] Avoid importing directly from subumbrella frameworks
2312         https://bugs.webkit.org/show_bug.cgi?id=186016
2313         <rdar://problem/40591038>
2314
2315         Reviewed by Sam Weinig.
2316
2317         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2318           LaunchServices header.
2319         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2320           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2321         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2322           when using SDKs earlier than 10.13.
2323         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2324           and OTHER_CPLUSPLUSFLAGS.
2325         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2326           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2327         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2328           LaunchServices header.
2329
2330 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2331
2332         Cache bytecode to disk
2333         https://bugs.webkit.org/show_bug.cgi?id=192782
2334         <rdar://problem/46084932>
2335
2336         Reviewed by Keith Miller.
2337
2338         Add test helper to execute bytecode-cache tests: it executes each test
2339         twice, the first with JSC_diskCachePath set to a temporary directory
2340         and second with JSC_forceDiskCache=true (in addition to the cache path)
2341         to guarantee that only the disk cache is being used and no new
2342         UnlinkedCodeBlocks are being created.
2343
2344         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2345         * Scripts/run-jsc-stress-tests:
2346
2347 2019-01-20  chris fleizach  <cfleizach@apple.com>
2348
2349         AX: Support returning relative frames for accessibility
2350         https://bugs.webkit.org/show_bug.cgi?id=193414
2351         <rdar://problem/47268501>
2352
2353         Reviewed by Zalan Bujtas.
2354
2355         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2356         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2357         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2358         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2359         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2360         (WTR::attributesOfElement):
2361         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2362
2363 2019-01-20  Antoine Quint  <graouts@apple.com>
2364
2365         Add a POINTER_EVENTS feature flag
2366         https://bugs.webkit.org/show_bug.cgi?id=193577
2367         <rdar://problem/47408511>
2368
2369         Unreviewed. Also enable Pointer Events for iosmac.
2370
2371         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2372
2373 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2374
2375         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2376         https://bugs.webkit.org/show_bug.cgi?id=193613
2377
2378         Reviewed by Antti Koivisto.
2379
2380         * LayoutReloaded/misc/LFC-passing-tests.txt:
2381
2382 2019-01-19  Antoine Quint  <graouts@apple.com>
2383
2384         Add a POINTER_EVENTS feature flag
2385         https://bugs.webkit.org/show_bug.cgi?id=193577
2386
2387         Reviewed by Dean Jackson.
2388
2389         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2390
2391 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2392
2393         Disable the run-jsc-stress-test remote host key check [second round].
2394         https://bugs.webkit.org/show_bug.cgi?id=192988
2395
2396         Reviewed by Dewei Zhu.
2397
2398         * Scripts/run-jsc-stress-tests:
2399
2400 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2401
2402         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2403         https://bugs.webkit.org/show_bug.cgi?id=193597
2404
2405         Reviewed by Lucas Forschler.
2406
2407         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2408
2409 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2412         https://bugs.webkit.org/show_bug.cgi?id=193595
2413
2414         Reviewed by Lucas Forschler.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2417         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2418         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2419
2420 2019-01-18  Chris Dumez  <cdumez@apple.com>
2421
2422         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2423         https://bugs.webkit.org/show_bug.cgi?id=193588
2424         <rdar://problem/47131566>
2425
2426         Reviewed by Alex Christensen.
2427
2428         Add layout test coverage.
2429
2430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2431
2432 2019-01-18  Jer Noble  <jer.noble@apple.com>
2433
2434         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2435         https://bugs.webkit.org/show_bug.cgi?id=189553
2436
2437         Reviewed by Tim Horton.
2438
2439         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2440
2441         * ContentExtensionTester/Configurations/Base.xcconfig:
2442         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2443         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2444         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2445         * ImageDiff/cg/Configurations/Base.xcconfig:
2446         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2447         * MiniBrowser/Configurations/Base.xcconfig:
2448         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2449         * MobileMiniBrowser/Configurations/Base.xcconfig:
2450         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2451         * Scripts/webkitpy/style/checker.py:
2452         (_all_categories):
2453         (FileType):
2454         (CheckerDispatcher._file_type):
2455         (CheckerDispatcher._create_checker):
2456         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2457         (SDKVariantChecker):
2458         (SDKVariantChecker.__init__):
2459         (SDKVariantChecker.check):
2460         * TestWebKitAPI/Configurations/Base.xcconfig:
2461         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2462         * WebEditingTester/Configurations/Base.xcconfig:
2463         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2464         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2465         * WebKitTestRunner/Configurations/Base.xcconfig:
2466         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2467         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2468         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2469
2470 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2471
2472         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2473         <https://webkit.org/b/193568>
2474         <rdar://problem/47381130>
2475
2476         Reviewed by Alex Christensen.
2477
2478         Make sure no one re-introduces UIKit soft-linking by adding a
2479         style rule.
2480
2481         * Scripts/webkitpy/style/checkers/cpp.py:
2482         (check_language): Add softlink/uikit check.
2483         (CppChecker): Enable softlink/uikit check.
2484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2485         (CppStyleTest): Add test for softlink/uikit.
2486
2487 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2488
2489         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2490         https://bugs.webkit.org/show_bug.cgi?id=193584
2491
2492         Change "-dev" to "-devel".
2493
2494         Reviewed by Michael Catanzaro.
2495
2496         * gtk/install-dependencies:
2497
2498 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2499
2500         webkitpy: Add iPhone and iPad ports
2501         https://bugs.webkit.org/show_bug.cgi?id=193537
2502         <rdar://problem/47353390>
2503
2504         Reviewed by Lucas Forschler.
2505
2506         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2507         ports. Note that this separation is optional, the --ios-simulator command remains.
2508
2509         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2510         (RunTest.test_device_type_test_division): Drive-by fix.
2511         (RunTest.test_device_type_specific_listing): Ditto.
2512         (RunTest.test_ipad_test_division):
2513         (RunTest):
2514         (RunTest.test_ipad_listing):
2515         * Scripts/webkitpy/port/factory.py:
2516         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2517         (PortFactory):
2518         * Scripts/webkitpy/port/ios_simulator.py:
2519         (IPhoneSimulatorPort):
2520         (IPadSimulatorPort):
2521
2522 2019-01-18  Chris Dumez  <cdumez@apple.com>
2523
2524         Regression(PSON) Scroll position is not always restored properly when navigating back
2525         https://bugs.webkit.org/show_bug.cgi?id=193578
2526         <rdar://problem/47386331>
2527
2528         Reviewed by Tim Horton.
2529
2530         Add API test coverage.
2531
2532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2533
2534 2019-01-18  Youenn Fablet  <youenn@apple.com>
2535
2536         Add a new SPI to request for cache storage quota increase
2537         https://bugs.webkit.org/show_bug.cgi?id=193323
2538
2539         Reviewed by Alex Christensen.
2540
2541         Implement WebsiteDataStore quota delegate to handle quota requests.
2542         By default, do not update quota.
2543         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2544
2545         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2546         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2547         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2548         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2549         * WebKitTestRunner/TestController.cpp:
2550         (WTR::TestController::allowCacheStorageQuotaIncrease):
2551         * WebKitTestRunner/TestController.h:
2552         * WebKitTestRunner/TestInvocation.cpp:
2553         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2554         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2555         (-[CacheStorageQuotaManager init]):
2556         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2557         (WTR::initializeWebViewConfiguration):
2558         (WTR::TestController::cocoaResetStateToConsistentValues):
2559         (WTR::TestController::allowCacheStorageQuotaIncrease):
2560
2561 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2562
2563         [ews-build] Pass owner to the triggered builds
2564         https://bugs.webkit.org/show_bug.cgi?id=193574
2565
2566         Reviewed by Lucas Forschler.
2567
2568         * BuildSlaveSupport/ews-build/factories.py:
2569         (BuildFactory.propertiesToPassToTriggers):
2570
2571 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2572
2573         [ews-app] Send patch author as a build property
2574         https://bugs.webkit.org/show_bug.cgi?id=193560
2575
2576         Reviewed by Lucas Forschler.
2577
2578         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2579         (BugzillaPatchFetcher.fetch):
2580
2581 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2582
2583         webkitpy: Implement device type specific expected results (Follow-up fix)
2584         https://bugs.webkit.org/show_bug.cgi?id=192162
2585         <rdar://problem/46345449>
2586
2587         Unreviewed infrastructure fix.
2588
2589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2590         (Manager.run): Don't boot a device if no tests are available to run on it.
2591
2592 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2593
2594         webkitpy: Implement device type specific expected results (Follow-up fix)
2595         https://bugs.webkit.org/show_bug.cgi?id=192162
2596         <rdar://problem/46345449>
2597
2598         Unreviewed infrastructure fix.
2599
2600         * Scripts/webkitpy/api_tests/manager.py:
2601         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2602
2603 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2604
2605         webkitpy: Implement device type specific expected results (Part 2)
2606         https://bugs.webkit.org/show_bug.cgi?id=192162
2607         <rdar://problem/46345449>
2608
2609         Rubber-stamped by Aakash Jain.
2610
2611         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2612         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2613         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2614
2615         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2616         (LayoutTestFinder.find_tests): Pass device_type through.
2617         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2618         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2619         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2620         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2621         (Manager._collect_tests): Pass device type to test finder.
2622         (Manager._needs_web_platform_test):
2623         (Manager._prepare_lists): Index _expectations by device type.
2624         (Manager._test_input_for_file):
2625         (Manager._test_is_slow): Ditto.
2626         (Manager._test_should_dump_jsconsolelog_in_stderr):
2627         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2628         (Manager._get_test_inputs):
2629         (Manager._update_worker_count):
2630         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2631         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2632         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2633         the one which runs the test.
2634         (Manager._run_test_subset):
2635         (Manager._run_tests): Index _expectations by current_device_type.
2636         (Manager._print_expectation_line_for_test): Ditto.
2637         (Manager._print_expectations_for_subset): Ditto.
2638         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2639         Unlike run, this function will behave the same regardless of what devices are available.
2640         (Manager._custom_device_for_test): Deleted.
2641         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2642         (ManagerTest.test_uses_custom_device): Deleted.
2643         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2644         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2645         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2646         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2647         all of the expectations.
2648         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2649         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2650         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2651         (TestExpectations.__init__): Allow device_type to be passed through.
2652         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2653         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2654         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2655         (summarize_results):
2656         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2657         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2658         a test ran with, one must check all expectations to find the first non-skip expectation.
2659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2660         (RunTest.test_device_type_test_division):
2661         (RunTest):
2662         (RunTest.test_device_type_specific_listing):
2663         * Scripts/webkitpy/port/base.py:
2664         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2665         (Port.supported_device_types): The result of this function will change based on what devices are available.
2666         * Scripts/webkitpy/port/device_port.py:
2667         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2668         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2669         can be used.
2670         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2671         any, or the DEFAULT_DEVICE_TYPES of the port.
2672         * Scripts/webkitpy/port/ios.py:
2673         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2674         * Scripts/webkitpy/port/ios_simulator.py:
2675         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2676         * Scripts/webkitpy/port/watch.py:
2677         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2678         * Scripts/webkitpy/port/watch_simulator.py:
2679         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2680         * Scripts/webkitpy/xcode/device_type.py:
2681         (DeviceType):
2682         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2683
2684 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2685
2686         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2687         https://bugs.webkit.org/show_bug.cgi?id=193575
2688
2689         Reviewed by Michael Catanzaro.
2690
2691         Allow the script to run without explicit port argument because
2692         it's specific to the WPE port anyway.
2693
2694         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2695         and simplify the rest of the code accordingly.
2696
2697 2019-01-18  Charlie Turner  <cturner@igalia.com>
2698
2699         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2700         https://bugs.webkit.org/show_bug.cgi?id=192229
2701
2702         Reviewed by Xabier Rodriguez-Calvar.
2703
2704         * MiniBrowser/wpe/main.cpp:
2705         (main): Enable encrypted-media by default.
2706
2707 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2708
2709         [Flatpak] Missing KeyboardInterrupt exception handler
2710         https://bugs.webkit.org/show_bug.cgi?id=193570
2711
2712         Reviewed by Michael Catanzaro.
2713
2714         * flatpak/flatpakutils.py:
2715         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2716
2717 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2718
2719         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2720         https://bugs.webkit.org/show_bug.cgi?id=193564
2721
2722         Reviewed by Antti Koivisto.
2723
2724         * LayoutReloaded/misc/LFC-passing-tests.txt:
2725
2726 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2727
2728         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2729         https://bugs.webkit.org/show_bug.cgi?id=193562
2730
2731         Reviewed by Antti Koivisto.
2732
2733         * LayoutReloaded/misc/LFC-passing-tests.txt:
2734
2735 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2736
2737         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2738         https://bugs.webkit.org/show_bug.cgi?id=193555
2739
2740         Reviewed by Antti Koivisto.
2741
2742         * LayoutReloaded/misc/LFC-passing-tests.txt:
2743
2744 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2745
2746         [WPE] Add Qt extension
2747         https://bugs.webkit.org/show_bug.cgi?id=191464
2748
2749         Reviewed by Carlos Garcia Campos.
2750
2751         MiniBrowser and API tests for the WPE Qt API. To run the
2752         MiniBrowser a new script is introduced. Example invocation:
2753
2754         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2755
2756         Also note-worthy is the introduction of the python2-subprocess32
2757         dependency to run the GLib API tests.
2758
2759         * MiniBrowser/wpe/CMakeLists.txt:
2760         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2761         * MiniBrowser/wpe/qt/main.cpp: Added.
2762         (main):
2763         * MiniBrowser/wpe/qt/main.qml: Added.
2764         * MiniBrowser/wpe/qt/qml.qrc: Added.
2765         * Scripts/run-gtk-tests:
2766         (GtkTestRunner.is_google_test):
2767         (GtkTestRunner):
2768         (GtkTestRunner.is_qt_test):
2769         * Scripts/run-qt-wpe-minibrowser: Added.
2770         * Scripts/run-wpe-tests:
2771         (WPETestRunner):
2772         (WPETestRunner.is_google_test):
2773         (WPETestRunner.is_qt_test):
2774         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2775         (TestLoad::main):
2776         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2777         (TestLoadHtml::main):
2778         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2779         (TestLoadRequest::main):
2780         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2781         (TestRunJavaScript::main):
2782         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2783         (waitForSignal):
2784         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2785         (LoadSpy::LoadSpy):
2786         (LoadSpy::~LoadSpy):
2787         (LoadSpy::onLoadingChanged):
2788         (LoadStartedCatcher::LoadStartedCatcher):
2789         (LoadStartedCatcher::~LoadStartedCatcher):
2790         (LoadStartedCatcher::onLoadingChanged):
2791         (waitForLoadSucceeded):
2792         (waitForLoadFailed):
2793         * TestWebKitAPI/glib/CMakeLists.txt:
2794         * flatpak/flatpakutils.py:
2795         (WebkitFlatpak.load_from_args):
2796         (WebkitFlatpak.__init__):
2797         (WebkitFlatpak.clean_args):
2798         (WebkitFlatpak.run_in_sandbox):
2799         * flatpak/org.webkit.CommonModules.yaml:
2800         * flatpak/org.webkit.WPE.yaml:
2801         * flatpak/org.webkit.WPEModules.yaml:
2802         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2803         * flatpak/org.webkit.WebKit.yaml:
2804         * glib/api_test_runner.py:
2805         (TestRunner._run_test_qt):
2806         (TestRunner.is_qt_test):
2807         (TestRunner._run_test):
2808
2809 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2810
2811         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2812         https://bugs.webkit.org/show_bug.cgi?id=193494
2813         <rdar://problem/46859627>
2814
2815         Reviewed by Simon Fraser and Tim Horton.
2816
2817         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2818         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2819
2820         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2821         (WTR::UIScriptController::contentOffsetX const):
2822         (WTR::UIScriptController::contentOffsetY const):
2823         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2824         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2825         (WTR::UIScriptController::contentOffsetX const):
2826         (WTR::UIScriptController::contentOffsetY const):
2827         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2828
2829         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2830
2831         * WebKitTestRunner/TestController.cpp:
2832         (WTR::updateTestOptionsFromTestHeader):
2833         * WebKitTestRunner/TestOptions.h:
2834         (WTR::TestOptions::hasSameInitializationOptions const):
2835         * WebKitTestRunner/ios/TestControllerIOS.mm:
2836         (WTR::TestController::platformResetStateToConsistentValues):
2837         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2838         (WTR::UIScriptController::contentOffsetX const):
2839         (WTR::UIScriptController::contentOffsetY const):
2840
2841 2019-01-17  Truitt Savell  <tsavell@apple.com>
2842
2843         Unreviewed, rolling out r240124.
2844
2845         This commit broke an internal build.
2846
2847         Reverted changeset:
2848
2849         "SDK_VARIANT build destinations should be separate from non-
2850         SDK_VARIANT builds"
2851         https://bugs.webkit.org/show_bug.cgi?id=189553
2852         https://trac.webkit.org/changeset/240124
2853
2854 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2855
2856         Fix string concatenation API test after r239920
2857         https://bugs.webkit.org/show_bug.cgi?id=193551
2858         <rdar://problem/47359304>
2859
2860         Reviewed by Youenn Fablet.
2861
2862         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2863         (TestWebKitAPI::TEST):
2864         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2865         in WebKit's build configuration like it apparently is on Linux.
2866
2867 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] validate-patch should handle the case when bug_id is None
2870         https://bugs.webkit.org/show_bug.cgi?id=193547
2871
2872         Reviewed by Lucas Forschler.
2873
2874         * BuildSlaveSupport/ews-build/steps.py:
2875         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2876         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2877
2878 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2879
2880         [ews-build] Add patch author information in build
2881         https://bugs.webkit.org/show_bug.cgi?id=193465
2882
2883         Reviewed by Lucas Forschler.
2884
2885         * BuildSlaveSupport/ews-build/steps.py:
2886         (ValidatePatch._is_patch_obsolete):
2887
2888 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-build] Pass bug_id to the triggered builds
2891         https://bugs.webkit.org/show_bug.cgi?id=193548
2892
2893         Reviewed by Lucas Forschler.
2894
2895         * BuildSlaveSupport/ews-build/factories.py:
2896         (BuildFactory.propertiesToPassToTriggers):
2897
2898 2019-01-17  Jer Noble  <jer.noble@apple.com>
2899
2900         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2901         https://bugs.webkit.org/show_bug.cgi?id=189553
2902
2903         Reviewed by Tim Horton.
2904
2905         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2906
2907         * ContentExtensionTester/Configurations/Base.xcconfig:
2908         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2909         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2910         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2911         * ImageDiff/cg/Configurations/Base.xcconfig:
2912         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2913         * MiniBrowser/Configurations/Base.xcconfig:
2914         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2915         * MobileMiniBrowser/Configurations/Base.xcconfig:
2916         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2917         * Scripts/webkitpy/style/checker.py:
2918         (_all_categories):
2919         (FileType):
2920         (CheckerDispatcher._file_type):
2921         (CheckerDispatcher._create_checker):
2922         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2923         (SDKVariantChecker):
2924         (SDKVariantChecker.__init__):
2925         (SDKVariantChecker.check):
2926         * TestWebKitAPI/Configurations/Base.xcconfig:
2927         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2928         * WebEditingTester/Configurations/Base.xcconfig:
2929         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2930         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2931         * WebKitTestRunner/Configurations/Base.xcconfig:
2932         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2933         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2934         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2935
2936 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2937
2938         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2939         https://bugs.webkit.org/show_bug.cgi?id=193534
2940
2941         Reviewed by Antti Koivisto.
2942
2943         * LayoutReloaded/misc/LFC-passing-tests.txt:
2944
2945 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2946
2947         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2948         https://bugs.webkit.org/show_bug.cgi?id=193528
2949
2950         Reviewed by Antti Koivisto.
2951
2952         * LayoutReloaded/misc/LFC-passing-tests.txt:
2953
2954 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2955
2956         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2957         https://bugs.webkit.org/show_bug.cgi?id=193520
2958
2959         Reviewed by Antti Koivisto.
2960
2961         * LayoutReloaded/misc/LFC-passing-tests.txt:
2962
2963 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2964
2965         [ews-build] unapply-patch step should not update source
2966         https://bugs.webkit.org/show_bug.cgi?id=193234
2967
2968         Reviewed by Lucas Forschler.
2969
2970         * BuildSlaveSupport/ews-build/steps.py:
2971         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2972         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2973
2974 2019-01-16  Youenn Fablet  <youenn@apple.com>
2975
2976         Add a new SPI for controlling getUserMedia
2977         https://bugs.webkit.org/show_bug.cgi?id=192793
2978
2979         Reviewed by Eric Carlson.
2980
2981         * MiniBrowser/mac/WK2BrowserWindowController.m:
2982         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2983         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2984         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2985         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2986         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2987         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2988         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2989         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2990         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2991         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2992         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2993         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2994         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2995         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2996
2997 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2998
2999         [LFC][BFC] Inflow non-replaced used width should not be negative.
3000         https://bugs.webkit.org/show_bug.cgi?id=193495
3001
3002         Reviewed by Antti Koivisto.
3003
3004         * LayoutReloaded/misc/LFC-passing-tests.txt:
3005
3006 2019-01-16  Chris Dumez  <cdumez@apple.com>
3007
3008         Regression(PSON) View becomes blank after click a cross-site download link
3009         https://bugs.webkit.org/show_bug.cgi?id=193361
3010         <rdar://problem/47099573>
3011
3012         Reviewed by Geoffrey Garen.
3013
3014         Add API test coverage.
3015
3016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3017         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3018
3019 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3020
3021         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3022         https://bugs.webkit.org/show_bug.cgi?id=193470
3023
3024         Reviewed by Antti Koivisto.
3025
3026         * LayoutReloaded/misc/LFC-passing-tests.txt:
3027
3028 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3029
3030         [LFC] Adjust margin box verification.
3031         https://bugs.webkit.org/show_bug.cgi?id=193482
3032
3033         Reviewed by Antti Koivisto.
3034
3035         * LayoutReloaded/misc/LFC-passing-tests.txt:
3036
3037 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3038
3039         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3040         https://bugs.webkit.org/show_bug.cgi?id=193451
3041
3042         Reviewed by Geoffrey Garen.
3043
3044         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3045         (TEST):
3046         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3047         (runWebsiteDataStoreCustomPaths):
3048
3049 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3050
3051         webkitpy: Support boolean simctl isAvailable
3052         https://bugs.webkit.org/show_bug.cgi?id=193472
3053         <rdar://problem/47296150>
3054
3055         Reviewed by Ryosuke Niwa.
3056
3057         * Scripts/webkitpy/xcode/simulated_device.py:
3058         (SimulatedDeviceManager._create_runtimes):
3059         (SimulatedDeviceManager._create_device_with_runtime):
3060
3061 2019-01-15  Chris Dumez  <cdumez@apple.com>
3062
3063         Unreviewed, rolling out r239993, r239995, r239997, and
3064         r239999.
3065
3066         Caused assertions under
3067         ViewGestureController::disconnectFromProcess()
3068
3069         Reverted changesets:
3070
3071         "Regression(PSON) View becomes blank after click a cross-site
3072         download link"
3073         https://bugs.webkit.org/show_bug.cgi?id=193361
3074         https://trac.webkit.org/changeset/239993
3075
3076         "Unreviewed iOS build fix after r239993."
3077         https://trac.webkit.org/changeset/239995
3078
3079         "Fix iOS build after r239993"
3080         https://bugs.webkit.org/show_bug.cgi?id=193361
3081         https://trac.webkit.org/changeset/239997
3082
3083         "Unreviewed, revert part of r239997 as it is not needed to fix
3084         the build."
3085         https://trac.webkit.org/changeset/239999
3086
3087 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3088
3089         Cannot tab out of WKWebView on macOS
3090         https://bugs.webkit.org/show_bug.cgi?id=161448
3091         <rdar://problem/28100085>
3092
3093         Reviewed by Dean Jackson.
3094
3095         Add a test that tabbing into and out of WKWebView works correctly.
3096
3097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3098         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3099         (WebKit2_CommandBackForwardTest::SetUp):
3100         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3101         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3102         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3103         (-[FocusableView canBecomeKeyView]):
3104         (TEST):
3105         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3106         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3107         (-[OffscreenWindow initWithSize:]):
3108         (-[OffscreenWindow isKeyWindow]):
3109         (-[OffscreenWindow isVisible]):
3110         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3111         (TestWebKitAPI::PlatformWebView::initialize):
3112         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3113         (-[ActiveOffscreenWindow isVisible]): Deleted.
3114         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3115
3116 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3117
3118         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3119         https://bugs.webkit.org/show_bug.cgi?id=193459
3120
3121         Reviewed by Mark Lam.
3122
3123         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3124         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3125
3126 2019-01-15  Chris Dumez  <cdumez@apple.com>
3127
3128         Regression(PSON) View becomes blank after click a cross-site download link
3129         https://bugs.webkit.org/show_bug.cgi?id=193361
3130         <rdar://problem/47099573>
3131
3132         Reviewed by Geoff Garen.
3133
3134         Add API test coverage.
3135
3136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3137         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3138
3139 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3140
3141         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3142         https://bugs.webkit.org/show_bug.cgi?id=193448
3143
3144         Reviewed by Antti Koivisto.
3145
3146         * LayoutReloaded/misc/LFC-passing-tests.txt:
3147
3148 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3149
3150         webkitpy: Implement device type specific expected results (Part 1)
3151         https://bugs.webkit.org/show_bug.cgi?id=192162
3152
3153         Reviewed by Lucas Forschler.
3154
3155         Device type specific expected results covers two related ideas. The first (covered by this change)
3156         is where to search for -expected.* files. The second is which tests to run based on the
3157         TestExpectations.txt file.
3158
3159         After this change, the baseline search path will be determined by the type of device running a
3160         test. Device type will be passed into any function which picks a file based on the baseline search
3161         path.
3162
3163         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3164         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3165         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3166         (Manager.run): Print baseline search path for each round of devices.
3167         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3168         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3169         (SingleTestRunner._expected_driver_output): Ditto.
3170         (SingleTestRunner._driver_input): Ditto.
3171         * Scripts/webkitpy/layout_tests/views/printing.py:
3172         (Printer.print_config): Move printing of baseline search path to a separate function.
3173         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3174         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3175         (Testprinter.test_print_config):
3176         (Testprinter.test_print_baseline_search_path):
3177         * Scripts/webkitpy/port/base.py:
3178         (Port.baseline_search_path): Pass device_type through.
3179         (Port._expected_baselines_for_suffixes): Ditto.
3180         (Port.expected_baselines): Ditto.
3181         (Port.expected_filename): Ditto.
3182         (Port.expected_checksum): Ditto.
3183         (Port.expected_image): Ditto.
3184         (Port.expected_audio): Ditto.
3185         (Port.expected_text): Ditto.
3186         (Port.reference_files): Ditto.
3187         (Port.tests): Ditto.
3188         (Port._expanded_paths): Ditto.
3189         (Port.skipped_layout_tests): Ditto.
3190         (Port.expectations_dict): Ditto.
3191         (Port._port_specific_expectations_files): Ditto.
3192         (Port.expectations_files): Ditto.
3193         (Port.test_search_path): Ditto.
3194         (Port._tests_for_other_platforms): Ditto.
3195         * Scripts/webkitpy/port/base_unittest.py:
3196         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3197         (PortTest.test_nonexistant_expectations): Ditto.
3198         (test_ref_tests_platform_directory): Ditto.
3199         * Scripts/webkitpy/port/darwin.py:
3200         (DarwinPort._port_specific_expectations_files): Accept device_type.
3201         * Scripts/webkitpy/port/driver.py:
3202         (DriverProxy):
3203         (DriverProxy.host): Expose _target_host for device_type information.
3204         * Scripts/webkitpy/port/gtk.py:
3205         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3206         * Scripts/webkitpy/port/ios.py:
3207         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3208         * Scripts/webkitpy/port/mac.py:
3209         (MacPort. default_baseline_search_path): Ditto.
3210         * Scripts/webkitpy/port/port_testcase.py:
3211         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3212         * Scripts/webkitpy/port/test.py:
3213         * Scripts/webkitpy/port/watch.py:
3214         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3215         * Scripts/webkitpy/port/win.py:
3216         (WinPort.test_search_path): Accept, but do not use, device_type.
3217         * Scripts/webkitpy/port/wpe.py:
3218         (WPEPort._port_specific_expectations_files): Ditto.
3219         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3220         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3221
3222 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3223
3224         [LFC] Use the containing block's padding box to position out-of-flow elements.
3225         https://bugs.webkit.org/show_bug.cgi?id=193431
3226
3227         Reviewed by Antti Koivisto.
3228
3229         * LayoutReloaded/misc/LFC-passing-tests.txt:
3230
3231 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3232
3233         Move a test implementation file that got misplaced in the Xcode project
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236
3237 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3238
3239         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3240         r239913, and r239914.
3241         https://bugs.webkit.org/show_bug.cgi?id=193407
3242
3243         These revisions caused an internal failure (Requested by
3244         Truitt on #webkit).
3245
3246         Reverted changesets:
3247
3248         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3249         https://bugs.webkit.org/show_bug.cgi?id=186016
3250         https://trac.webkit.org/changeset/239901
3251
3252         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3253         https://trac.webkit.org/changeset/239909
3254
3255         "Tried to fix the build."
3256         https://trac.webkit.org/changeset/239910
3257
3258         "Fixed iOS builds after r239910."
3259         https://trac.webkit.org/changeset/239912
3260
3261         "More build fixing."
3262         https://trac.webkit.org/changeset/239913
3263
3264         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3265         https://trac.webkit.org/changeset/239914
3266
3267 2019-01-14  Mark Lam  <mark.lam@apple.com>
3268
3269         Re-enable ability to build --cloop builds.
3270         https://bugs.webkit.org/show_bug.cgi?id=192955
3271         <rdar://problem/46882363>
3272
3273         Reviewed by Saam barati and Keith Miller.
3274
3275         The --cloop build option was being ignored this whole time since r236381.
3276         This patch makes it possible to build CLoop builds again.
3277
3278         * Scripts/build-jsc:
3279         * Scripts/webkitperl/FeatureList.pm:
3280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3281
3282 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3283
3284         webkitpy: Expose device_type from host-like objects
3285         https://bugs.webkit.org/show_bug.cgi?id=193406
3286         <rdar://problem/47262305>
3287
3288         Reviewed by Lucas Forschler.
3289
3290         Devices should expose device_type. As a result, all host objects should
3291         provide a device_type property, even if they do not yet define a device_type.
3292
3293         * Scripts/webkitpy/common/system/systemhost.py:
3294         (SystemHost):
3295         (SystemHost.device_type):
3296         * Scripts/webkitpy/common/system/systemhost_mock.py:
3297         (MockSystemHost):
3298         (MockSystemHost.device_type):
3299         * Scripts/webkitpy/port/device.py:
3300         (Device):
3301         (Device.device_type):
3302         * Scripts/webkitpy/xcode/simulated_device.py:
3303         (SimulatedDeviceManager._find_exisiting_device_for_request):
3304         (SimulatedDeviceManager._disambiguate_device_type):
3305         (SimulatedDeviceManager._does_fulfill_request):
3306         (SimulatedDeviceManager.device_count_for_type):
3307         (SimulatedDeviceManager.initialize_devices):
3308         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3309         (test_available_devices):
3310         (test_swapping_devices):
3311
3312 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3313
3314         webkitpy: Support alternate simctl device list output (Follow-up fix)
3315         https://bugs.webkit.org/show_bug.cgi?id=193362
3316         <rdar://problem/47122965>
3317
3318         Rubber-stamped by Lucas Forschler.
3319
3320         * Scripts/webkitpy/xcode/simulated_device.py:
3321         (SimulatedDeviceManager.populate_available_devices):
3322
3323 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3324
3325         [iOS] Expose SPI to access the current sentence boundary and selection state
3326         https://bugs.webkit.org/show_bug.cgi?id=193398
3327         <rdar://problem/45893108>
3328
3329         Reviewed by Dean Jackson.
3330
3331         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3332         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3333         expected.
3334
3335         * TestWebKitAPI/EditingTestHarness.h:
3336         * TestWebKitAPI/EditingTestHarness.mm:
3337         (-[EditingTestHarness moveBackward]):
3338         (-[EditingTestHarness moveForward]):
3339         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3340
3341         Add a couple of new helper methods on EditingTestHarness.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3344         (-[SelectionChangeObserver initWithWebView:]):
3345         (-[SelectionChangeObserver webView]):
3346         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3347         (-[SelectionChangeObserver currentSelectionAttributes]):
3348
3349 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3350
3351         [LFC][BFC] Add basic box-sizing support.
3352         https://bugs.webkit.org/show_bug.cgi?id=193392
3353
3354         Reviewed by Antti Koivisto.
3355
3356         * LayoutReloaded/misc/LFC-passing-tests.txt:
3357
3358 2019-01-14  Charlie Turner  <cturner@igalia.com>
3359
3360         [WPE] API test gardening
3361         https://bugs.webkit.org/show_bug.cgi?id=193319
3362
3363         Reviewed by Michael Catanzaro.
3364
3365         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3366         passing tests.
3367
3368 2019-01-14  Charlie Turner  <cturner@igalia.com>
3369
3370         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3371         https://bugs.webkit.org/show_bug.cgi?id=192977
3372
3373         Reviewed by Carlos Garcia Campos.
3374
3375         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3376         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3377         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3378         (TestWebKitAPI::GStreamerTest::SetUp):
3379         (TestWebKitAPI::GStreamerTest::TearDown):
3380         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3381         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3382         (TestWebKitAPI::TEST_F):
3383
3384 2019-01-14  Charlie Turner  <cturner@igalia.com>
3385
3386         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3387         https://bugs.webkit.org/show_bug.cgi?id=193332
3388
3389         Reviewed by Michael Catanzaro.
3390
3391         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3392         defined as a char16_t, which changed in ICU 59, the
3393         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3394         unsigned short. This test is relying on the behaviour that
3395         UChar=unsigned short, which doesn't hold across platforms and ICU
3396         library versions. The full fix would be a special syntax for
3397         literal characters so that these ambiguities do not arise. That
3398         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3399         (TestWebKitAPI::TEST):
3400
3401 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3402
3403         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3404
3405         * Scripts/make-dist:
3406         (Distcheck.configure):
3407
3408 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3409
3410         [ews-build] Update macOS queue configurations
3411         https://bugs.webkit.org/show_bug.cgi?id=193365
3412         <rdar://problem/47221073>
3413
3414         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3415
3416         * BuildSlaveSupport/ews-build/config.json:
3417
3418 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3419
3420         [LFC] Adjust assert for statically positioned fixed elements
3421         https://bugs.webkit.org/show_bug.cgi?id=193385
3422
3423         Reviewed by Antti Koivisto.
3424
3425         * LayoutReloaded/misc/LFC-passing-tests.txt:
3426
3427 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3428
3429         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3430         https://bugs.webkit.org/show_bug.cgi?id=193387
3431
3432         Reviewed by Carlos Garcia Campos.
3433
3434         * MiniBrowser/wpe/main.cpp:
3435         (main):
3436
3437 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3438
3439         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3440         https://bugs.webkit.org/show_bug.cgi?id=191655
3441         rdar://problem/46074680
3442
3443         Reviewed by Megan Gardner.
3444
3445         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3446         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3447
3448 2019-01-12  Dan Bernstein  <mitz@apple.com>
3449
3450         [Cocoa] Avoid importing directly from subumbrella frameworks
3451         https://bugs.webkit.org/show_bug.cgi?id=186016
3452         <rdar://problem/40591038>
3453
3454         Reviewed by Sam Weinig.
3455
3456         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3457           LaunchServices header.
3458         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3459           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3460         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3461           when using SDKs earlier than 10.13.
3462         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3463           and OTHER_CPLUSPLUSFLAGS.
3464         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3465           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3466         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3467           LaunchServices header.
3468
3469 2019-01-11  John Wilander  <wilander@apple.com>
3470
3471         Compile out Web API Statistics Collection
3472         https://bugs.webkit.org/show_bug.cgi?id=193370
3473         <rdar://problem/45388584>
3474
3475         Reviewed by Brent Fulgham.
3476
3477         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3478             Defined ENABLE_WEB_API_STATISTICS, off by default.
3479
3480 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3481
3482         [WPE] Add gtk-doc
3483         https://bugs.webkit.org/show_bug.cgi?id=178900
3484
3485         Reviewed by Michael Catanzaro.
3486
3487         Add Tools/gtkdoc to manifest.txt.in files.
3488         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3489
3490         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3491         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3492
3493 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3494
3495         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3496         https://bugs.webkit.org/show_bug.cgi?id=193364
3497         <rdar://problem/47214117>
3498
3499         Reviewed by Tim Horton.
3500
3501         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3502         precise, whereas dragging near the middle of the textarea does.
3503
3504         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3505         (TestWebKitAPI::TEST):
3506
3507 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3508
3509         webkitpy: Support alternate simctl device list output
3510         https://bugs.webkit.org/show_bug.cgi?id=193362
3511         <rdar://problem/47122965>
3512
3513         Reviewed by Lucas Forschler.
3514
3515         * Scripts/webkitpy/xcode/simulated_device.py:
3516         (SimulatedDeviceManager.populate_available_devices):
3517
3518 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3519
3520         [ews-build] Update macOS queue configurations
3521         https://bugs.webkit.org/show_bug.cgi?id=193365
3522
3523         Reviewed by Lucas Forschler.
3524
3525         * BuildSlaveSupport/ews-build/config.json:
3526
3527 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3528
3529         webkitpy: Incorporate device type into baseline search path
3530         https://bugs.webkit.org/show_bug.cgi?id=193356
3531         <rdar://problem/47215515>
3532
3533         Reviewed by Lucas Forschler.
3534
3535         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3536
3537         * Scripts/webkitpy/port/base.py:
3538         (Port.default_baseline_search_path): Allow device type to be passed in.
3539         * Scripts/webkitpy/port/gtk.py:
3540         (GtkPort.default_baseline_search_path): Ignore device type.
3541         * Scripts/webkitpy/port/ios.py:
3542         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3543         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3544         * Scripts/webkitpy/port/ios_device_unittest.py:
3545         (IOSDeviceTest):
3546         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3547         (IOSSimulatorTest):
3548         * Scripts/webkitpy/port/mac.py:
3549         (MacPort.default_baseline_search_path): Ignore device type.
3550         * Scripts/webkitpy/port/watch.py:
3551         (WatchPort.default_baseline_search_path): Ditto.
3552         * Scripts/webkitpy/port/win.py:
3553         (WinPort.default_baseline_search_path): Ditto.
3554         (WinCairoPort.default_baseline_search_path): Ditto.
3555         * Scripts/webkitpy/port/wpe.py:
3556         (WPEPort.default_baseline_search_path): Ditto.
3557
3558 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3559
3560         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3561         https://bugs.webkit.org/show_bug.cgi?id=193352
3562         <rdar://problem/47210736>
3563
3564         Reviewed by Lucas Forschler.
3565
3566         * Scripts/webkitpy/layout_tests/views/printing.py:
3567         (Printer.print_config): Print list on only baseline search paths which exist. 
3568         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3569         (Testprinter.test_print_config):
3570
3571 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3572
3573         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3574         https://bugs.webkit.org/show_bug.cgi?id=193340
3575
3576         Reviewed by David Kilzer.
3577
3578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3579         (WTR::InjectedBundle::didReceiveMessageToPage):
3580         Pull the strings out into a WKRetainPtr.
3581
3582         * WebKitTestRunner/WebNotificationProvider.cpp:
3583         (WTR::WebNotificationProvider::closeWebNotification):
3584         Adopt the created value into the WKRetainPtr.
3585
3586         * WebKitTestRunner/mac/TestControllerMac.mm:
3587         (WTR::generateWhitelist):
3588         Immediately adopt a created value to avoid potential mistakes.
3589
3590 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3591
3592         Enable DFG on ARM/Linux again
3593         https://bugs.webkit.org/show_bug.cgi?id=192496
3594
3595         Reviewed by Yusuke Suzuki.
3596
3597         After changing the bytecode format DFG was disabled on all 32-bit
3598         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3599         on ARM by default.
3600
3601         * Scripts/run-jsc-stress-tests:
3602
3603 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3604
3605         Unreviewed, fix #ifdef in API test added in r239851.
3606         https://bugs.webkit.org/show_bug.cgi?id=193327
3607         rdar://problem/47093222
3608
3609         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3610
3611 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3612
3613         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3614         https://bugs.webkit.org/show_bug.cgi?id=193109
3615         <rdar://problem/44807048>
3616
3617         Reviewed by Ryosuke Niwa.
3618
3619         Introduce and respect a test option to enable the UndoManager API.
3620
3621         * WebKitTestRunner/TestController.cpp:
3622         (WTR::updateTestOptionsFromTestHeader):
3623         * WebKitTestRunner/TestOptions.h:
3624         (WTR::TestOptions::hasSameInitializationOptions const):
3625         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3626         (WTR::TestController::platformCreateWebView):
3627
3628 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3629
3630         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3631         https://bugs.webkit.org/show_bug.cgi?id=193346
3632
3633         Reviewed by Antti Koivisto.
3634
3635         * LayoutReloaded/misc/LFC-passing-tests.txt:
3636
3637 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3638
3639         Unreviewed, fix typo that breaks dashboard link.
3640
3641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3642         (WebKitBuildbot):
3643
3644 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3645
3646         Update macOS queue configurations
3647         https://bugs.webkit.org/show_bug.cgi?id=193329
3648
3649         Reviewed by Alexey Proskuryakov.
3650
3651         * BuildSlaveSupport/build.webkit.org-config/config.json:
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3653         (BubbleQueueServer):
3654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3656         (WebKitBuildbot):
3657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3658         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3659         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3660
3661 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3662
3663         MiniBrowser should be able to navigate to about:blank
3664         https://bugs.webkit.org/show_bug.cgi?id=193345
3665
3666         Reviewed by Simon Fraser.
3667
3668         * MiniBrowser/mac/BrowserWindowController.m:
3669         (-[BrowserWindowController addProtocolIfNecessary:]):
3670         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3671
3672         * MiniBrowser/mac/WK1BrowserWindowController.m:
3673         (-[WK1BrowserWindowController fetch:]):
3674         * MiniBrowser/mac/WK2BrowserWindowController.m:
3675         (-[WK2BrowserWindowController fetch:]):
3676         Clean up the code that uses this to match style.
3677
3678 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3679
3680         Remove MiniBrowser custom "Process Swap" menu item which does not work
3681         https://bugs.webkit.org/show_bug.cgi?id=193344
3682
3683         Reviewed by Simon Fraser.
3684
3685         There is a menu item under the Experimental menu that does work.
3686
3687         * MiniBrowser/mac/AppDelegate.m:
3688         (defaultConfiguration):
3689         * MiniBrowser/mac/SettingsController.h:
3690         * MiniBrowser/mac/SettingsController.m:
3691         (-[SettingsController _populateMenu]):
3692         (-[SettingsController validateMenuItem:]):
3693         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3694         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3695
3696 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3697
3698         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3699         https://bugs.webkit.org/show_bug.cgi?id=193327
3700         rdar://problem/47093222
3701
3702         Reviewed by Tim Horton.
3703
3704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3705         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3706         (TestWebKitAPI::didFinishNavigation):
3707         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3708         (TestWebKitAPI::TEST):
3709         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3710         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3711         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3712         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3713         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3714
3715 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3716
3717         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3718         https://bugs.webkit.org/show_bug.cgi?id=193338
3719         <rdar://problem/46664774>
3720
3721         Reviewed by David Kilzer.
3722
3723         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3724         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3725
3726 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3727
3728         Unreviewed, rolling out r239825.
3729         https://bugs.webkit.org/show_bug.cgi?id=193330
3730
3731         Broke tests on armv7/linux bots (Requested by guijemont on
3732         #webkit).
3733
3734         Reverted changeset:
3735
3736         "Enable DFG on ARM/Linux again"
3737         https://bugs.webkit.org/show_bug.cgi?id=192496
3738         https://trac.webkit.org/changeset/239825
3739
3740 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3741
3742         Disable the run-jsc-stress-test remote host key check.
3743         https://bugs.webkit.org/show_bug.cgi?id=192988
3744
3745         Reviewed by Alexey Proskuryakov.
3746
3747         * Scripts/run-jsc-stress-tests:
3748
3749 2019-01-10  John Wilander  <wilander@apple.com>
3750
3751         Override the session configuration for cookieAcceptPolicy
3752         https://bugs.webkit.org/show_bug.cgi?id=190925
3753         <rdar://problem/45497382>
3754
3755         Reviewed by Alexey Proskuryakov and Alex Christensen.
3756
3757         Test infrastructure for setting a first-party-only cookie policy.
3758
3759         * DumpRenderTree/TestRunner.cpp:
3760         (setOnlyAcceptFirstPartyCookiesCallback):
3761         (TestRunner::staticFunctions):
3762         * DumpRenderTree/TestRunner.h:
3763         * DumpRenderTree/mac/TestRunnerMac.mm:
3764         (TestRunner::setOnlyAcceptFirstPartyCookies):
3765         * DumpRenderTree/win/TestRunnerWin.cpp:
3766         (TestRunner::setOnlyAcceptFirstPartyCookies):
3767         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3769         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3770         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3771         * WebKitTestRunner/TestInvocation.cpp:
3772         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3773
3774 2019-01-09  Matt Rajca  <mrajca@apple.com>
3775
3776         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3777         https://bugs.webkit.org/show_bug.cgi?id=193301
3778
3779         Reviewed by Jer Noble.
3780         
3781         Added API tests.
3782
3783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3784         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3785         (TEST):
3786         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3787
3788 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3789
3790         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3791         https://bugs.webkit.org/show_bug.cgi?id=193310
3792
3793         Reviewed by Antti Koivisto.
3794
3795         * LayoutReloaded/misc/LFC-passing-tests.txt:
3796
3797 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3798
3799         Enable DFG on ARM/Linux again
3800         https://bugs.webkit.org/show_bug.cgi?id=192496
3801
3802         Reviewed by Yusuke Suzuki.
3803
3804         After changing the bytecode format DFG was disabled on all 32-bit
3805         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3806         on ARM by default.
3807
3808         * Scripts/run-jsc-stress-tests:
3809
3810 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3811
3812         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3813         https://bugs.webkit.org/show_bug.cgi?id=193271
3814
3815         Reviewed by Brent Fulgham.
3816
3817         BSTR is a special data structure created by SysAllocString, not a
3818         wchar_t null-terminated string.
3819
3820         * DumpRenderTree/win/TestRunnerWin.cpp:
3821         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3822         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3823         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3824         BSTR from wide string literals.
3825
3826 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3827
3828         Tweak wording for build/version_check style checker error
3829         https://bugs.webkit.org/show_bug.cgi?id=193256
3830
3831         Reviewed by Tim Horton.
3832
3833         * Scripts/webkitpy/style/checkers/cpp.py:
3834         (check_os_version_checks):
3835         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3836         (WebKitStyleTest.test_os_version_checks):
3837
3838 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3839
3840         [ews-build] Add link to bug along with bug title
3841         https://bugs.webkit.org/show_bug.cgi?id=193293
3842
3843         Reviewed by Lucas Forschler.
3844
3845         * BuildSlaveSupport/ews-build/steps.py:
3846         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3847         (ConfigureBuild.add_bug_id_url): Deleted.
3848         (ConfigureBuild.getBugURL): Deleted.
3849
3850 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3851
3852         [ews-build] Use https for ews-build server
3853         https://bugs.webkit.org/show_bug.cgi?id=193193
3854
3855         Reviewed by Lucas Forschler.
3856
3857         * BuildSlaveSupport/ews-build/steps.py:
3858
3859 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3860
3861         [ews-build] Parse and display number of style failures
3862         https://bugs.webkit.org/show_bug.cgi?id=193280
3863
3864         Reviewed by Lucas Forschler.
3865
3866         * BuildSlaveSupport/ews-build/steps.py:
3867         (CheckStyle): Use TestWithFailureCount as base class.
3868         (CheckStyle.countFailures): Count the number of style failures.
3869
3870 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3871
3872         [ews-build] use patch_id instead of ewspatchid
3873         https://bugs.webkit.org/show_bug.cgi?id=193235
3874
3875         Reviewed by Lucas Forschler.
3876
3877         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3878         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3879         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3880
3881 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3882
3883         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3884         https://bugs.webkit.org/show_bug.cgi?id=192625
3885
3886         Reviewed by Antti Koivisto.
3887
3888         * LayoutReloaded/misc/LFC-passing-tests.txt:
3889
3890 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3891
3892         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3893         https://bugs.webkit.org/show_bug.cgi?id=192841
3894
3895         Reviewed by Carlos Garcia Campos.
3896
3897         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3898         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3899         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3900
3901         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3902
3903         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3904         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3905         (WebKitWebEditorTest::testSelectionChanged):
3906         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3907         (WebKitFrameTest::testMainFrame):
3908         (WebKitFrameTest::testURI):
3909         (WebKitFrameTest::testJavaScriptContext):
3910         (WebKitFrameTest::testJavaScriptValues):
3911         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3912         (testWebViewAuthenticationRequest):
3913         (testWebViewAuthenticationLoadCancelled):
3914         (testWebViewAuthenticationFailure):
3915         (testWebViewAuthenticationStorage):
3916         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3917         (testWebViewAuthenticationProxy):
3918         (testWebViewAuthenticationProxyHTTPS):
3919         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3920         (testAutomationSessionRequestSession):
3921         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3922         (testBackForwardListNavigation):
3923         (testWebKitWebViewSessionState):
3924         (testWebKitWebViewSessionStateWithFormData):
3925         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3926         (ConsoleMessageTest::consoleMessageReceivedCallback):
3927         (testWebKitConsoleMessageConsoleAPI):
3928         (testWebKitConsoleMessageJavaScriptException):
3929         (testWebKitConsoleMessageNetworkError):
3930         (testWebKitConsoleMessageSecurityError):
3931         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3932         (testCookieManagerAcceptPolicy):
3933         (testCookieManagerCookiesChanged):
3934         (testCookieManagerPersistentStorage):
3935         (testCookieManagerPersistentStorageDeleteAll):
3936         (testCookieManagerEphemeral):
3937         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3938         (testWebKitDOMElementAutoFill):
3939         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3940         (downloadLocalFileSuccessfully):
3941         (createFileAtDestination):
3942         (testDownloadOverwriteDestinationDisallowed):
3943         (testDownloadLocalFileError):
3944         (testDownloadRemoteFile):
3945         (testDownloadRemoteFileError):
3946         (testWebViewDownloadURI):
3947         (testPolicyResponseDownload):
3948         (testPolicyResponseDownloadCancel):
3949         (testDownloadMIMEType):
3950         (contextMenuCallback):
3951         (testContextMenuDownloadActions):
3952         (testBlobDownload):
3953         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3954         (testWebKitWebEditorSelectionChanged):
3955         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3956         (testWebKitFrameMainFrame):
3957         (testWebKitFrameURI):
3958         (testWebKitFrameJavaScriptContext):
3959         (testWebKitFrameJavaScriptValues):
3960         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3961         (LoadStopTrackingTest::loadFailed):
3962         (testWebViewTitle):
3963         (testURIRequestHTTPHeaders):
3964         (testURIRequestHTTPMethod):
3965         (testURIResponseHTTPHeaders):
3966         (testRedirectToDataURI):
3967         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3968         (testProcessPerWebView):
3969         (testWebProcessLimit):
3970         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3971         (testWebViewResources):
3972         (testWebResourceLoading):
3973         (testWebResourceSuggestedFilename):
3974         (testWebResourceGetData):
3975         (testWebResourceGetDataError):
3976         (testWebViewResourcesHistoryCache):
3977         (testWebResourceSendRequest):
3978         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3979         (testSSL):
3980         (testInsecureContent):
3981         (testTLSErrorsPolicy):
3982         (testTLSErrorsRedirect):
3983         (testTLSErrorsHTTPAuth):
3984         (testLoadFailedWithTLSErrors):
3985         (testSubresourceLoadFailedWithTLSErrors):
3986         (httpsServerCallback):
3987         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3988         (testWebViewCreateNavigationData):
3989         (testWebViewJavaScriptDialogs):
3990         (testWebViewWindowProperties):
3991         (testWebViewMouseTarget):
3992         (testWebViewFileChooserRequest):
3993         (testWebViewColorChooserRequest):
3994         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3995         (testWebExtensionGetTitle):
3996         (testDocumentLoadedSignal):
3997         (testWebKitWebViewProcessCrashed):
3998         (testWebExtensionWindowObjectCleared):
3999         (testWebExtensionIsolatedWorld):
4000         (permissionRequestCallback):
4001         (didAssociateFormControlsCallback):
4002         (testWebExtensionFormControlsAssociated):
4003         (FormSubmissionTest::FormSubmissionTest):
4004         (FormSubmissionTest::testFormSubmissionResult):
4005         (testWebExtensionFormSubmissionSteps):
4006         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4007         (testNotInitialized):
4008         (testClearDatabase):
4009         (testPrivateBrowsing):
4010         (testGetFavicon):
4011         (testWebViewFavicon):
4012         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4013         (testFindControllerTextFound):
4014         (testFindControllerTextNotFound):
4015         (testFindControllerMatchCount):
4016         (testFindControllerMaxMatchCount):
4017         (testFindControllerNext):
4018         (testFindControllerPrevious):
4019         (testFindControllerCountedMatches):
4020         (testFindControllerOptions):
4021         (testFindControllerHide):
4022         (testFindControllerInstance):
4023         (testFindControllerGetters):
4024         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4025         (testNavigationPolicy):
4026         (testResponsePolicy):
4027         (testNewWindowPolicy):
4028         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4029         (testSecurityOriginBasicConstructor):
4030         (testSecurityOriginURIConstructor):
4031         (testSecurityOriginDefaultPort):
4032         (testSecurityOriginFileURI):
4033         (testOpaqueSecurityOrigin):
4034         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4035         (testWebKitSettings):
4036         (testWebKitSettingsNewWithSettings):
4037         (testWebKitSettingsUserAgent):
4038         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4039         (testWebViewNewWithUserContentManager):
4040         (isStyleSheetInjectedForURLAtPath):
4041         (isScriptInjectedForURLAtPath):
4042         (testUserContentManagerInjectedStyleSheet):
4043         (testUserContentManagerInjectedScript):
4044         (UserScriptMessageTest::scriptMessageReceived):
4045         (UserScriptMessageTest::waitUntilMessageReceived):
4046         (UserScriptMessageTest::runJavaScriptFinished):
4047         (testUserContentManagerScriptMessageReceived):
4048         (testUserContentManagerScriptMessageInWorldReceived):
4049         (testUserContentManagerScriptMessageFromDOMBindings):
4050         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4051         (testWebContextDefault):
4052         (testWebContextEphemeral):
4053         (testWebContextGetPlugins):
4054         (testWebContextURIScheme):
4055         (testWebContextSpellChecker):
4056         (testWebContextLanguages):
4057         (consoleMessageReceivedCallback):
4058         (testWebContextSecurityFileXHR):
4059         (ProxyTest::ProxyTest):
4060         (testWebContextProxySettings):
4061         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4062         (testWebViewWebContext):
4063         (testWebViewWebBackend):
4064         (testWebViewEphemeral):
4065         (testWebViewCustomCharset):
4066         (testWebViewSettings):
4067         (testWebViewRunJavaScript):
4068         (testWebViewCanShowMIMEType):
4069         (testWebViewSubmitForm):
4070         (testWebViewSave):
4071         (testWebViewPageVisibility):
4072         (testWebViewSnapshot):
4073         (testWebViewNotification):
4074         (testWebViewNotificationInitialPermissionAllowed):
4075         (testWebViewNotificationInitialPermissionDisallowed):
4076         (testWebViewIsPlayingAudio):
4077         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4078         (WebsiteDataTest::WebsiteDataTest):
4079         (WebsiteDataTest::remove):
4080         (WebsiteDataTest::clear):
4081         (testWebsiteDataConfiguration):
4082         (testWebsiteDataEphemeral):
4083         (testWebsiteDataCache):
4084         (testWebsiteDataStorage):
4085         (testWebsiteDataDatabases):
4086         (testWebsiteDataAppcache):
4087         (testWebsiteDataCookies):
4088         (testWebsiteDataDeviceIdHashSalt):
4089         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4090         (emitDocumentLoaded):
4091         (emitURIChanged):
4092         (sendRequestCallback):
4093         (contextMenuCallback):
4094         (consoleMessageSentCallback):
4095         (emitFormControlsAssociated):
4096         (formControlsAssociatedCallback):
4097         (emitFormSubmissionEvent):
4098         (willSubmitFormCallback):
4099         (windowObjectCleared):
4100         (methodCallCallback):
4101         (registerGResource):
4102         (webkit_web_extension_initialize_with_user_data):
4103         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4104         (checkLeaks):
4105         (WebProcessTest::create):
4106         (runTest):
4107         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4108         (AutocleanupsTest::testWebProcessAutocleanups):
4109         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4110         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4111         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4112         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4113         (WebKitDOMDOMWindowTest::testSignals):
4114         (WebKitDOMDOMWindowTest::testDispatchEvent):
4115         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4116         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4117         (WebKitDOMNodeFilterTest::testTreeWalker):
4118         (WebKitDOMNodeFilterTest::testNodeIterator):
4119         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4120         (WebKitDOMNodeTest::testHierarchyNavigation):
4121         (WebKitDOMNodeTest::testInsertion):
4122         (WebKitDOMNodeTest::testTagNamesNodeList):
4123         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4124         (WebKitDOMNodeTest::testDOMCache):
4125         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4126         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4127         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4128         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4129         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4130         (testUIProcessAutocleanups):
4131         (testWebProcessAutocleanups):
4132         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4133         (testContextMenuPopulateMenu):
4134         (testContextMenuDismissed):
4135         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4136         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4137         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4138         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4139         (testWebKitDOMDOMWindowSignals):
4140         (testWebKitDOMDOMWindowDispatchEvent):
4141         (testWebKitDOMDOMWindowGetComputedStyle):
4142         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4143         (testWebKitDOMNodeHierarchyNavigation):
4144         (testWebKitDOMNodeInsertion):
4145         (testWebKitDOMNodeTagNamesNodeList):
4146         (testWebKitDOMNodeTagNamesHTMLCollection):
4147         (testWebKitDOMObjectCache):
4148         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4149         (testWebKitDOMNodeFilterTreeWalker):
4150         (testWebKitDOMNodeFilterNodeIterator):
4151         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4152         (testWebKitDOMXPathNSResolverNative):
4153         (testWebKitDOMXPathNSResolverCustom):
4154         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4155         (testInspectorDefault):
4156         (testInspectorManualAttachDetach):
4157         (testInspectorCustomContainerDestroyed):
4158         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4159         (startTestServer):
4160         (testInspectorServerPageList):
4161         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4162         (OptionMenuTest::showOptionMenuCallback):
4163         (OptionMenuTest::menuCloseCallback):
4164         (OptionMenuTest::close):
4165         (OptionMenuTest::activateItem):
4166         (OptionMenuTest::selectItem):
4167         (testOptionMenuSimple):
4168         (testOptionMenuGroups):
4169         (testOptionMenuActivate):
4170         (testOptionMenuSelect):
4171         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4172         (testPrintOperationPrintSettings):
4173         (webViewPrintCallback):
4174         (testPrintOperationPrint):
4175         (testPrintCustomWidget):
4176         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4177         (checkAtspiAccessible):
4178         (testAtspiBasicHierarchy):
4179         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4180         (testWebKitCheckVersion):
4181         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4182         (testWebViewEditorCutCopyPasteNonEditable):
4183         (testWebViewEditorCutCopyPasteEditable):
4184         (testWebViewEditorSelectAllNonEditable):
4185         (testWebViewEditorSelectAllEditable):
4186         (loadContentsAndTryToCutSelection):
4187         (testWebViewEditorNonEditable):
4188         (testWebViewEditorEditable):
4189         (testWebViewEditorEditorStateTypingAttributes):
4190         (testWebViewEditorInsertImage):
4191         (testWebViewEditorCreateLink):
4192         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4193         (loadChangedCallback):
4194         (loadFailedCallback):
4195         (loadFailedWithTLSErrorsCallback):
4196         (LoadTrackingTest::LoadTrackingTest):
4197         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4198         (registerGResource):
4199         (removeNonEmptyDirectory):
4200         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4201         (Test::adoptView):
4202         (Test::~Test):
4203         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4204         (WebKitTestBus::getOrCreateConnection):
4205         (WebKitTestBus::createProxy):
4206         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4207         (WebKitTestServer::getWebSocketURIForPath const):
4208         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4209         (WebViewTest::initializeWebView):
4210         (WebViewTest::loadURI):
4211         (WebViewTest::loadHtml):
4212         (WebViewTest::loadPlainText):
4213         (WebViewTest::loadBytes):
4214         (WebViewTest::loadRequest):
4215         (WebViewTest::loadAlternateHTML):
4216         (WebViewTest::goBack):
4217         (WebViewTest::goForward):
4218         (WebViewTest::goToBackForwardListItem):
4219         (resourceGetDataCallback):
4220         (WebViewTest::mainResourceData):
4221         (WebViewTest::javascriptResultToCString):
4222         (WebViewTest::javascriptResultToNumber):
4223         (WebViewTest::javascriptResultToBoolean):
4224         (WebViewTest::javascriptResultIsNull):
4225         (WebViewTest::javascriptResultIsUndefined):
4226         (onSnapshotReady):
4227         (WebViewTest::runWebProcessTest):
4228         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4229         (WebViewTest::platformInitializeWebView):
4230         (WebViewTest::showInWindow):
4231         (WebViewTest::showInWindowAndWaitUntilMapped):
4232         (WebViewTest::mouseMoveTo):
4233         (WebViewTest::emitPopupMenuSignal):
4234         (WebViewTest::keyStroke):
4235         (WebViewTest::doMouseButtonEvent):
4236
4237 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4238
4239         [WPE] API tests can't run in flatpak environment
4240         https://bugs.webkit.org/show_bug.cgi?id=193242
4241
4242         Reviewed by Michael Catanzaro.
4243
4244         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4245         flatpakutils so that it knows which port it's dealing with.
4246         * glib/common.py: Remove build_dir globals so that subsequent
4247         calls actually take args into account.
4248         (library_build_path):
4249         (binary_build_path):
4250
4251 2019-01-08  Dean Jackson  <dino@apple.com>
4252
4253         Blob references for System Previews don't get a correct file extension
4254         https://bugs.webkit.org/show_bug.cgi?id=193268
4255         <rdar://problem/47133037>
4256
4257         Reviewed by Tim Horton.
4258
4259         New test that a Blob download of a USDZ file gets named correctly.
4260
4261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4262         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4263         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4264         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4265         (TEST):
4266         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4267
4268 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4269
4270         [WebAuthN] Support U2F HID Authenticators on macOS
4271         https://bugs.webkit.org/show_bug.cgi?id=191535
4272         <rdar://problem/47102027>
4273
4274         Reviewed by Brent Fulgham.
4275
4276         This patch:
4277         1) adds support for U2F mocking mechanism;
4278         2) updates tests to reflect U2fCommandConstructor changes.
4279
4280         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4281         (TestWebKitAPI::TEST):
4282         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4284         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4285
4286 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4287
4288         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4289         https://bugs.webkit.org/show_bug.cgi?id=193229
4290         <rdar://problem/46717097>
4291
4292         Reviewed by Tim Horton.
4293
4294         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4295         prevents a drag from starting.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4298         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4299
4300         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4301
4302 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4303   
4304         Layout test will generate a perf metric file to results dir.
4305         https://bugs.webkit.org/show_bug.cgi?id=192030
4306         <rdar://problem/32779516>
4307
4308         Reviewed by Aakash Jain.
4309
4310         Layout test running time will be collected to a perf metric file.
4311         For now, instead of outputing running time of all tests (which is huge),
4312         we aggregate them by test directories which are at most two level deep. 
4313
4314         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4315         (Manager._end_test_run):
4316         (Manager._output_perf_metrics):
4317         (Manager._print_expectation_line_for_test):
4318         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4319         (add_test_perf_metric):
4320         (test_perf_metrics):
4321         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4322         (JSONGeneratorTest.test_test_timings_trie):
4323         (JSONGeneratorTest):