Unreviewed, rolling out r212169.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-15  Alex Christensen  <achristensen@webkit.org>
2
3         Unreviewed, rolling out r212169.
4
5         Broke iOS WebInspector
6
7         Reverted changeset:
8
9         "WebInspector: refactor RemoteInspector to move cocoa specific
10         code to their own files"
11         https://bugs.webkit.org/show_bug.cgi?id=166681
12         http://trac.webkit.org/changeset/212169
13
14 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
15
16         webkitpy: Fix DarwinPort._get_crash_log()
17         https://bugs.webkit.org/show_bug.cgi?id=168372
18         <rdar://problem/30535156>
19
20         Reviewed by Daniel Bates.
21
22         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
23         DarwinPort should return the expected return value for _get_crash_log.
24
25         * Scripts/webkitpy/port/darwin.py:
26         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
27
28 2017-02-15  Chris Dumez  <cdumez@apple.com>
29
30         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
31         https://bugs.webkit.org/show_bug.cgi?id=168291
32         <rdar://problem/30508593>
33
34         Reviewed by Tim Horton.
35
36         Drop overridePreference() implementation in iOS's UIScriptController
37         as it was only used for the minimum font size setting and this setting
38         is not exposed on iOS.
39
40         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
41         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
42         (WTR::UIScriptController::overridePreference):
43         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
44
45 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
46
47         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
48         https://bugs.webkit.org/show_bug.cgi?id=168329
49         <rdar://problem/30518832>
50
51         Reviewed by Daniel Bates.
52
53         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
54         never change given the same input arguments.  Memoize function for efficiency.
55
56         * Scripts/webkitpy/port/darwin.py: Add memoized import.
57         (DarwinPort):
58         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
59         
60
61 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
62
63         webkitpy: Remove unused import from darwin.py
64         https://bugs.webkit.org/show_bug.cgi?id=168371
65
66         Reviewed by Alex Christensen.
67
68         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
69
70 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
73         https://bugs.webkit.org/show_bug.cgi?id=168364
74
75         Reviewed by Michael Catanzaro.
76
77         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
78         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
79         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
80
81         Fixes: http/tests/security/credentials-from-different-domains.html
82                http/tests/xmlhttprequest/cross-origin-no-authorization.html
83
84         * gtk/jhbuild.modules:
85         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
86         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
87
88 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
89
90         [GTK] Update cookie manager API to properly work with ephemeral sessions
91         https://bugs.webkit.org/show_bug.cgi?id=168230
92
93         Reviewed by Michael Catanzaro.
94
95         Update unit tests and add new cases for the new API.
96
97         * MiniBrowser/gtk/main.c:
98         (gotWebsiteDataCallback):
99         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
100         (testCookieManagerEphemeral):
101         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
102         (testWebContextEphemeral):
103         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
104         (testWebViewEphemeral):
105         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
106         (serverCallback):
107         (testWebsiteDataEphemeral):
108         (testWebsiteDataCookies):
109         (beforeAll):
110
111 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
112
113         [WK2] Support data interaction on links
114         https://bugs.webkit.org/show_bug.cgi?id=168331
115         <rdar://problem/30200837>
116
117         Reviewed by Tim Horton.
118
119         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
120         editable area results in the link URL being inserted.
121
122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
123         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
124         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
125         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
126         (TestWebKitAPI::TEST):
127
128 2017-02-14  Jason Rinn  <jrinn@apple.com>
129
130         Add a test for new WebKit Cocoa API, _getContentsAsString.
131         https://bugs.webkit.org/show_bug.cgi?id=168147
132         <rdar://problem/30502539>
133
134         Reviewed by Tim Horton.
135
136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
137         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
138         (TEST):
139
140 2017-02-14  Matt Rajca  <mrajca@apple.com>
141
142         Website policies: iframes should respect the autoplay policy of the top-level document
143         https://bugs.webkit.org/show_bug.cgi?id=168333
144
145         Reviewed by Alex Christensen.
146
147         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
148         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
149         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
150         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
151         (TEST):
152
153 2017-02-14  Chris Dumez  <cdumez@apple.com>
154
155         HTML Form Validation bubble should take minimum font size setting into consideration
156         https://bugs.webkit.org/show_bug.cgi?id=168271
157         <rdar://problem/29869869>
158
159         Reviewed by Simon Fraser.
160
161         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
162         font size of the validation bubble.
163
164         Add an overridePreference() method to UIScriptController. This is currently
165         used to override the value of the minimumFontSize setting. testRunner's
166         overridePreference() is not usable on WK2 because it does not update the
167         value of the preference on the UIProcess side.
168
169         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
170         (WTR::UIScriptController::overridePreference):
171         * DumpRenderTree/mac/UIScriptControllerMac.mm:
172         (WTR::UIScriptController::overridePreference):
173         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
174         * TestRunnerShared/UIScriptContext/UIScriptController.h:
175         * WebKitTestRunner/TestController.cpp:
176         (WTR::TestController::resetPreferencesToConsistentValues):
177         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
178         (WTR::UIScriptController::overridePreference):
179         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
180         (WTR::UIScriptController::contentsOfUserInterfaceItem):
181         (WTR::UIScriptController::overridePreference):
182
183 2017-02-14  Florian Bruhin  <git@the-compiler.org>
184
185         Use a set instead of a list for tests when parsing expectations
186         https://bugs.webkit.org/show_bug.cgi?id=168304
187
188         In _collect_matching_tests, a lot of membership tests are done on a giant list
189         of strings. By making it a set instead, we can make those much faster, and
190         there's no reason for it to be a list.
191
192         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
193         to 3s on my machine.
194
195         Reviewed by Ryosuke Niwa.
196
197         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
198         (TestExpectationParser.__init__):
199         (TestExpectationParser._collect_matching_tests):
200
201 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
202
203         Unreviewed build-fix after r212297.
204
205         * Scripts/webkitpy/port/simulator_process.py:
206         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
207
208 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
209
210         [CMake] build-webkit should allow building with the default cmake configuration
211         https://bugs.webkit.org/show_bug.cgi?id=168323
212
213         Reviewed by Michael Catanzaro.
214
215         Add a --default-cmake-features switch that makes the script pass
216         no value for any of the features defined by build-webkit, that
217         way the default values from the port cmake config will be used.
218
219         * Scripts/build-webkit:
220         (cMakeArgsFromFeatures):
221
222 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
223
224         Unreviewed build-fix after r212297.
225
226         * Scripts/webkitpy/port/simulator_process.py:
227         (SimulatorProcess.stop): Handle case where there is no process to kill.
228
229 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
230
231         [CMake] build-webkit should print the cmake command executed
232         https://bugs.webkit.org/show_bug.cgi?id=168318
233
234         Reviewed by Michael Catanzaro.
235
236         Run the cmake commands to configure or start the build through
237         a wrapper that prints the command before executing it.
238
239         * Scripts/webkitdirs.pm:
240         (systemVerbose):
241         (generateBuildSystemFromCMakeProject):
242         (buildCMakeGeneratedProject):
243         (cleanCMakeGeneratedProject):
244
245 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
246
247         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
248         https://bugs.webkit.org/show_bug.cgi?id=168150
249
250         Reviewed by Alexey Proskuryakov.
251
252         * Scripts/webkitpy/port/simulator_process.py:
253         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
254         (SimulatorProcess._kill): Move closing of app into stop().
255         * Scripts/webkitpy/xcode/simulator.py:
256         (Device.launch_app):
257         (Device.terminate_app): Deleted.
258
259 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
260
261         REGRESSION(r212192): [GTK] Broke downloads API tests
262         https://bugs.webkit.org/show_bug.cgi?id=168193
263
264         Unreviewed. Update test expectations after r212192.
265
266         The suggested filename now includes a file extensions if the MIME type is known.
267
268         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
269         (testDownloadRemoteFile):
270         (testDownloadMIMEType):
271
272 2017-02-14  Commit Queue  <commit-queue@webkit.org>
273
274         Unreviewed, rolling out r212237.
275         https://bugs.webkit.org/show_bug.cgi?id=168298
276
277         This was a wrong fix (Requested by rniwa on #webkit).
278
279         Reverted changeset:
280
281         "Nwtr unexpectedly passes mismatch ref test if the hashes
282         doesn't match but no diff"
283         https://bugs.webkit.org/show_bug.cgi?id=168221
284         http://trac.webkit.org/changeset/212237
285
286 2017-02-13  Alex Christensen  <achristensen@webkit.org>
287
288         URLs with an invalid IPv4 address should be invalid
289         https://bugs.webkit.org/show_bug.cgi?id=168260
290
291         Reviewed by Tim Horton.
292
293         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
294         (TestWebKitAPI::TEST_F):
295         Update tests to reflect new correct behavior.
296
297 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
298
299         [WinCairo] Add Build Slave
300         https://bugs.webkit.org/show_bug.cgi?id=168263
301
302         Reviewed by Lucas Forschler.
303
304         * BuildSlaveSupport/build.webkit.org-config/config.json:
305
306 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
307
308         Fix the build after r212254
309
310         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
311         (-[DataInteractionSimulator _currentLocation]):
312
313 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
314
315         [WK2] Add test infrastructure and unit tests for data interaction
316         https://bugs.webkit.org/show_bug.cgi?id=168159
317         <rdar://problem/30477634>
318
319         Reviewed by Tim Horton.
320
321         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
322         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
323         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
324         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
325         gesture has already been recognized) at regular intervals over the course of the test.
326
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
329         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
330         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
331
332         New test pages for data interaction.
333
334         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
335         (TestWebKitAPI::runTestsExpectingToObserveEvents):
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/cocoa/TestWKWebView.mm:
338         (-[TestWKWebView stringByEvaluatingJavaScript:]):
339         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
340         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
341         (-[MockLongPressGestureRecognizer initWithWindow:]):
342         (-[MockLongPressGestureRecognizer locationInView:]):
343         (-[MockLongPressGestureRecognizer state]):
344         (-[MockLongPressGestureRecognizer numberOfTouches]):
345         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
346         (-[DataInteractionSimulator dealloc]):
347         (-[DataInteractionSimulator run]):
348
349         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
350         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
351         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
352
353         (-[DataInteractionSimulator _advanceProgress]):
354
355         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
356         completed, and calls _finishDataInteraction when progress is at 1.
357
358         (-[DataInteractionSimulator _finishDataInteraction]):
359         (-[DataInteractionSimulator _currentLocation]):
360         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
361         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
362         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
363         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
364         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
365
366 2017-02-13  Alex Christensen  <achristensen@webkit.org>
367
368         Percent should be allowed in non-special URL hosts
369         https://bugs.webkit.org/show_bug.cgi?id=168255
370
371         Reviewed by Tim Horton.
372
373         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
374         (TestWebKitAPI::TEST_F):
375
376 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
377
378         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
379         https://bugs.webkit.org/show_bug.cgi?id=168221
380
381         Reviewed by Ryosuke Niwa.
382
383         There is a logic error in comparing mismatch ref test images. In
384         mismatch ref tests, it should be failed if two images has no diff.
385         But, if the hashes are different, nwtr unexpectedly pass the
386         mismatch ref test.
387
388         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
389         (SingleTestRunner._compare_output_with_reference): Fail the
390         mismatch ref test if hashes of two images are equal. Invoke
391         ImageDiff if the hashes don't match.
392
393 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
394
395         Update custom line breaking iterators to the latest version of Unicode
396         https://bugs.webkit.org/show_bug.cgi?id=168182
397
398         Reviewed by Zalan Bujtas.
399
400         Treat the system's ICU as the source of truth to compare breaking positions against.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
404         (generateJavaScriptForTest):
405         (breakingLocationsFromICU):
406         (testAFewStrings):
407         (TEST):
408         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
409         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
410
411 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
412
413         [GTK] Several failing WebViewEditor API tests
414         https://bugs.webkit.org/show_bug.cgi?id=161608
415
416         Reviewed by Carlos Garcia Campos.
417
418         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
419         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
420         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
421         except the first one, which is still broken due to unrelated bug #151654.
422
423         * Scripts/run-gtk-tests:
424         (TestRunner):
425         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
426
427 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
428
429         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
430
431         * Scripts/run-gtk-tests:
432         (TestRunner):
433
434 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
435
436         Unreviewed, skip flaky form-controls-associated-signal test
437
438         * Scripts/run-gtk-tests:
439         (TestRunner):
440
441 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
442
443         [GTK] Handle caps lock indicator in event modifiers
444         https://bugs.webkit.org/show_bug.cgi?id=168186
445
446         Reviewed by Michael Catanzaro.
447
448         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
449         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
450
451 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
452
453         MiniBrowser WK1 fails to update URL for within-page navigations
454         https://bugs.webkit.org/show_bug.cgi?id=168173
455
456         Reviewed by Tim Horton.
457         
458         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
459         anchors updates the URL field.
460
461         * MiniBrowser/mac/WK1BrowserWindowController.m:
462         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
463
464 2017-02-10  John Wilander  <wilander@apple.com>
465
466         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
467         https://bugs.webkit.org/show_bug.cgi?id=167474
468         <rdar://problem/24681808>
469         <rdar://problem/24703286>
470         <rdar://problem/30290270>
471
472         This patch adds test infrastructure to allow testing 
473         of the various rules in place for data records removal.
474
475         Reviewed by Andy Estes.
476
477         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
478         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
479         (WTR::InjectedBundle::didReceiveMessageToPage):
480             Callback mechanism to tell pages that a website data store
481             scan has happened.
482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
483         (WTR::TestRunner::setStatisticsPrevalentResource):
484         (WTR::TestRunner::isStatisticsPrevalentResource):
485         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
486         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
487         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
488         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
489         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
490         (WTR::TestRunner::statisticsFireDataModificationHandler):
491         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
492         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
493         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
494         (WTR::TestRunner::statisticsResetToConsistentState):
495         * WebKitTestRunner/InjectedBundle/TestRunner.h:
496         * WebKitTestRunner/TestController.cpp:
497         (WTR::TestController::setStatisticsPrevalentResource):
498         (WTR::TestController::isStatisticsPrevalentResource):
499         (WTR::TestController::setStatisticsHasHadUserInteraction):
500         (WTR::TestController::isStatisticsHasHadUserInteraction):
501         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
502         (WTR::TestController::statisticsFireDataModificationHandler):
503         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
504         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
505         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
506         (WTR::TestController::statisticsResetToConsistentState):
507         * WebKitTestRunner/TestController.h:
508             These are all configuration and test functions.
509         * WebKitTestRunner/TestInvocation.cpp:
510         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
511
512 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
513
514         REGRESSION(r182916) run-perf-tests never timeouts
515         https://bugs.webkit.org/show_bug.cgi?id=167626
516
517         Reviewed by Ryosuke Niwa.
518
519         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
520         was beeing ignored because the driver was created with no_timeout=True
521         unconditionally.
522         This adds a new parameter --no-timeout (disabled by default), that
523         allows to use the driver with the expected timeout values.
524         It also passes --no-timeout to DRT/WTR to ensure that timeouts
525         are always controlled by the Python Driver.
526
527         * Scripts/webkitpy/performance_tests/perftest.py:
528         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
529         (PerfTest.run): Disabling timeout should be done when the Driver is created.
530         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
531         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
532         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
533         (_run_tests_set): Pass the no-timeout parameter.
534         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
535         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
536         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
537         (MainTest.test_parse_args): Test that the argument no-timeout.
538
539 2017-02-10  Daniel Bates  <dabates@apple.com>
540
541         Detach frame from document when entering page cache
542         https://bugs.webkit.org/show_bug.cgi?id=166774
543         <rdar://problem/29904368>
544
545         Reviewed by Chris Dumez.
546
547         * DumpRenderTree/mac/DumpRenderTree.mm:
548         (resetWebPreferencesToConsistentValues):
549         * DumpRenderTree/win/DumpRenderTree.cpp:
550         (resetWebPreferencesToConsistentValues):
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::TestController::resetPreferencesToConsistentValues):
553
554 2017-02-10  Tim Horton  <timothy_horton@apple.com>
555
556         Infinite UI process hang under ensurePositionInformationIsUpToDate
557         https://bugs.webkit.org/show_bug.cgi?id=168154
558         <rdar://problem/30428673>
559
560         Reviewed by Simon Fraser.
561
562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
563         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
564         (recursiveFindHighlightLongPressRecognizer):
565         (TEST):
566         Add a somewhat nasty test that does an async interaction information update, but
567         kills the Web process before it arrives, and then does a sync interaction
568         information update, which will wait for the oustanding async interaction
569         information update if we still think it's coming. Before the patch, this
570         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
571
572 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
573
574         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
575         https://bugs.webkit.org/show_bug.cgi?id=168127
576         rdar://problem/30467120
577
578         Reviewed by Tim Horton.
579
580         Reparent the web view before we try to fetch it via:
581             [[[window contentView] subviews] objectAtIndex:0];
582         which would throw an exception if the test unparented it.
583
584         * DumpRenderTree/mac/DumpRenderTree.mm:
585         (resetWebViewToConsistentStateBeforeTesting):
586         (runTest):
587
588 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
589
590         [Resource Timing] Enable Resource Timing by default in Tests
591         https://bugs.webkit.org/show_bug.cgi?id=168145
592
593         Reviewed by Ryosuke Niwa.
594
595         * DumpRenderTree/mac/DumpRenderTree.mm:
596         (resetWebPreferencesToConsistentValues):
597         * DumpRenderTree/win/DumpRenderTree.cpp:
598         (resetWebPreferencesToConsistentValues):
599         * WebKitTestRunner/TestController.cpp:
600         (WTR::TestController::resetPreferencesToConsistentValues):
601
602 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
603
604         Removing LayoutTestRelay
605         https://bugs.webkit.org/show_bug.cgi?id=165927
606
607         Reviewed by Daniel Bates.
608         Part 2
609
610         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
611         simulators through simctl (iOS 10 and later), use this functionality instead.
612
613         * BuildSlaveSupport/built-product-archive:
614         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
615         Added a FIXME that we will need to implement similar archiving machinery once we build
616         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
617         * BuildSlaveSupport/kill-old-processes:
618         (main): Remove LayoutTestRelay from list of processes.
619         * LayoutTestRelay: Removed LayoutTestRelay.
620         * Makefile:
621         * Scripts/build-layouttestrelay: Removed.
622         * Scripts/build-webkit: Removed LayoutTestRelay references.
623
624 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
625
626         [WebCrypto] Add WebCryptoAPI to watchlist
627         https://bugs.webkit.org/show_bug.cgi?id=168138
628
629         Reviewed by Youenn Fablet.
630
631         * Scripts/webkitpy/common/config/watchlist:
632
633 2017-02-10  Brady Eidson  <beidson@apple.com>
634
635         Replace all WebKit Library Version checks in WK2 with SDK version checks.
636         https://bugs.webkit.org/show_bug.cgi?id=168124
637
638         Reviewed by Geoffrey Garen.
639
640         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
641         
642         * MiniBrowser/mac/main.m:
643         (main):
644         * MobileMiniBrowser/MobileMiniBrowser/main.m:
645         (main):
646         * TestWebKitAPI/ios/mainIOS.mm:
647         (main):
648         * TestWebKitAPI/mac/mainMac.mm:
649         (main):
650         * WebKitTestRunner/ios/mainIOS.mm:
651         (main):
652         * WebKitTestRunner/mac/main.mm:
653         (setDefaultsToConsistentValuesForTesting):
654
655 2017-02-10  Alex Christensen  <achristensen@webkit.org>
656
657         Fix El Capitan build.
658
659         * Scripts/build-webkit:
660         Don't build libwebrtc anywhere for now.
661
662 2017-02-10  Andy Estes  <aestes@apple.com>
663
664         Move two MiniBrowserBundle settings out of the .pbxproj
665         https://bugs.webkit.org/show_bug.cgi?id=168106
666
667         Reviewed by Tim Horton.
668
669         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
670         the project file. This removes the project file override.
671
672         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
673
674         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
675         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
676
677 2017-02-10  Alex Christensen  <achristensen@webkit.org>
678
679         Fix 32-and-64-bit build on El Capitan.
680
681         * Scripts/build-webkit:
682         Somebody's building with something like this:
683         build-webkit ARCHS="i386 x86_64"
684         We want this to also not build libwebrtc for now.
685
686 2017-02-10  Alex Christensen  <achristensen@webkit.org>
687
688         Fix 32-bit build on El Capitan.
689
690         * Scripts/build-webkit:
691         The bot uses ARCHS=i386 instead of --32-bit.
692         This is a hack, but it should fix the bot until I can do a better fix in the morning.
693
694 2017-02-10  Alex Christensen  <achristensen@webkit.org>
695
696         Fix 32-bit build on El Capitan.
697
698         * Scripts/build-webkit:
699         Don't build i386 libwebrtc.
700
701 2017-02-09  Alex Christensen  <achristensen@webkit.org>
702
703         Unreviewed, rolling out r212040.
704
705         Broke build.  I'm not surprised
706
707         Reverted changeset:
708
709         "[WebRTC][Mac] Activate libwebrtc"
710         https://bugs.webkit.org/show_bug.cgi?id=167293
711         http://trac.webkit.org/changeset/212040
712
713 2017-02-09  Alex Christensen  <achristensen@webkit.org>
714
715         Build libwebrtc on bots without using it yet
716         https://bugs.webkit.org/show_bug.cgi?id=168062
717
718         Reviewed by Brent Fulgham.
719
720         * Scripts/build-webkit:
721
722 2017-02-09  Alex Christensen  <achristensen@webkit.org>
723
724         Don't build libwebrtc.
725
726         * Scripts/build-webkit:
727         Not ready yet.  It broke El Capitan and iOS.
728
729 2017-02-09  Alex Christensen  <achristensen@webkit.org>
730
731         Build libwebrtc on bots without using it yet
732         https://bugs.webkit.org/show_bug.cgi?id=168062
733
734         Reviewed by Brent Fulgham.
735
736         * Scripts/build-webkit:
737
738 2017-02-09  Alex Christensen  <achristensen@webkit.org>
739
740         Rename isAppleMacWebKit to isAppleCocoaWebKit
741         https://bugs.webkit.org/show_bug.cgi?id=168075
742
743         Reviewed by Geoffrey Garen.
744
745         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
746
747         * Scripts/build-api-tests:
748         * Scripts/build-dumprendertree:
749         * Scripts/build-jsc:
750         (buildMyProject):
751         * Scripts/build-layouttestrelay:
752         * Scripts/build-webkit:
753         * Scripts/build-webkittestrunner:
754         * Scripts/run-api-tests:
755         (isSupportedPlatform):
756         (runTest):
757         (listAllTests):
758         (prepareEnvironmentForRunningTestTool):
759         * Scripts/run-content-extension-tester:
760         * Scripts/run-javascriptcore-tests:
761         * Scripts/run-minibrowser:
762         * Scripts/show-pretty-diff:
763         * Scripts/webkitdirs.pm:
764         (determineBaseProductDir):
765         (determineArchitecture):
766         (determinePassedArchitecture):
767         (safariPath):
768         (builtDylibPathForName):
769         (checkFrameworks):
770         (isAppleWebKit):
771         (isAppleCocoaWebKit):
772         (determineNmPath):
773         (launcherName):
774         (wrapperPrefixIfNeeded):
775         (isCMakeBuild):
776         (mobileSafariBundle):
777         (debugSafari):
778         (runSafari):
779         (runMiniBrowser):
780         (debugMiniBrowser):
781         (runWebKitTestRunner):
782         (debugWebKitTestRunner):
783         (isAppleMacWebKit): Deleted.
784         * Scripts/webkitperl/FeatureList.pm:
785
786 2017-02-09  Alex Christensen  <achristensen@webkit.org>
787
788         Revert r211991
789         https://bugs.webkit.org/show_bug.cgi?id=168062
790
791         * Scripts/build-webkit:
792         Not quite ready yet.
793
794 2017-02-09  Alex Christensen  <achristensen@webkit.org>
795
796         Build libwebrtc on bots without using it yet
797         https://bugs.webkit.org/show_bug.cgi?id=168062
798
799         Reviewed by Brent Fulgham.
800
801         * Scripts/build-webkit:
802         Build libwebrtc on Mac when we build ANGLE.
803
804 2017-02-09  Youenn Fablet  <youenn@apple.com>
805
806         Improve W3C importer command line options
807         https://bugs.webkit.org/show_bug.cgi?id=167448
808
809         Reviewed by Ryosuke Niwa.
810
811         Making the list of test paths to import the main arguments of the script.
812         Allow passing the source directory to import as a -s option.
813         Adding a warning when given test paths are skipped by default in ImportExpectations.
814
815         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
816         Link conversion rules do not change when imported tests are downloaded by the script.
817
818         * Scripts/webkitpy/w3c/test_importer.py:
819         (main):
820         (parse_args):
821         (TestImporter.__init__):
822         (TestImporter.do_import):
823         (TestImporter):
824         (TestImporter.check_imported_expectations):
825
826 2017-02-08  Chris Dumez  <cdumez@apple.com>
827
828         Update web-platform-tests resources
829         https://bugs.webkit.org/show_bug.cgi?id=168026
830
831         Reviewed by Youenn Fablet.
832
833         Stop copying testharness.js from resources/ to web-platform-tests/resources.
834
835         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
836         (WebPlatformTestServer._copy_webkit_test_files):
837
838 2017-02-08  Andy Estes  <aestes@apple.com>
839
840         Custom protocols should not continue loading after a network process crash
841         https://bugs.webkit.org/show_bug.cgi?id=168028
842         <rdar://problem/27607520>
843
844         Reviewed by Brady Eidson.
845
846         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
847         (processGroup):
848         (-[CloseWhileStartingProtocol startLoading]):
849         (-[CloseWhileStartingProtocol stopLoading]):
850         (TestWebKitAPI::runTest):
851         (TestWebKitAPI::TEST):
852
853 2017-02-08  Dan Bernstein  <mitz@apple.com>
854
855         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
856         https://bugs.webkit.org/show_bug.cgi?id=168031
857
858         Reviewed by Tim Horton.
859
860         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
861         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
862         (TEST):
863         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
864         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
865
866 2017-02-08  Chris Dumez  <cdumez@apple.com>
867
868         Use smaller tiles in windows that are not active to facilitate App Napping
869         https://bugs.webkit.org/show_bug.cgi?id=167997
870         <rdar://problem/30358835>
871
872         Reviewed by Simon Fraser.
873
874         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
875         (WTR::PlatformWebView::setWindowIsKey):
876         Actually update windowIsKey state of NSWindow so the WebView
877         properly updates its activity state.
878
879 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
880
881         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
882         https://bugs.webkit.org/show_bug.cgi?id=167942
883         <rdar://problem/30315079>
884
885         Reviewed by Tim Horton.
886
887         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
888         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
889         contenteditable in these cases.
890
891         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
892         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
893         performDragOperation:) directly.
894
895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
896         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
897         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
898         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
899         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
900         (-[DragSource draggingSourceOperationMaskForLocal:]):
901         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
902         (-[DragInfo lastMousePosition]):
903         (-[DragInfo setLastMousePosition:]):
904         (-[DragInfo draggingDestinationWindow]):
905         (-[DragInfo draggingSourceOperationMask]):
906         (-[DragInfo draggingLocation]):
907         (-[DragInfo draggedImageLocation]):
908         (-[DragInfo draggedImage]):
909         (-[DragInfo draggingPasteboard]):
910         (-[DragInfo draggingSource]):
911         (-[DragInfo draggingSequenceNumber]):
912         (-[DragInfo slideDraggedImageTo:]):
913         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
914         (-[DragInfo draggingFormation]):
915         (-[DragInfo setDraggingFormation:]):
916         (-[DragInfo animatesToDestination]):
917         (-[DragInfo setAnimatesToDestination:]):
918         (-[DragInfo numberOfValidItemsForDrop]):
919         (-[DragInfo setNumberOfValidItemsForDrop:]):
920         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
921         (-[DragInfo springLoadingHighlight]):
922         (-[DragInfo resetSpringLoading]):
923         (TestWebKitAPI::getTestImage):
924         (TestWebKitAPI::webViewAfterPerformingDragOperation):
925         (TestWebKitAPI::TEST):
926         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
927
928 2017-02-08  Jer Noble  <jer.noble@apple.com>
929
930         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
931         https://bugs.webkit.org/show_bug.cgi?id=168007
932
933         Reviewed by Alex Christensen.
934
935         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
936         (didFinishLoadForFrame):
937         (TestWebKitAPI::TEST):
938
939 2017-02-08  Commit Queue  <commit-queue@webkit.org>
940
941         Unreviewed, rolling out r211873.
942         https://bugs.webkit.org/show_bug.cgi?id=168001
943
944         It's in jhbuild for consistent layout tests (Requested by
945         mcatanzaro on #webkit).
946
947         Reverted changeset:
948
949         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
950         https://bugs.webkit.org/show_bug.cgi?id=167993
951         http://trac.webkit.org/changeset/211873
952
953 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
954
955         [GTK] Add icu packages to Tools/gtk/install-dependencies
956         https://bugs.webkit.org/show_bug.cgi?id=167993
957
958         Reviewed by Michael Catanzaro.
959
960         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
961         depending in the GNU/Linux distribution)
962
963 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
964
965         Update flakiness dashboard configuration.
966         https://bugs.webkit.org/show_bug.cgi?id=167957
967
968         Reviewed by Alexey Proskuryakov.
969
970         * TestResultServer/static-dashboards/builders.jsonp:
971
972 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
973
974         Replace a bot that has an incorrect configuration.
975         https://bugs.webkit.org/show_bug.cgi?id=167747
976
977         Rubber-stamped by Alexey Proskuryakov.
978
979         * BuildSlaveSupport/build.webkit.org-config/config.json:
980
981 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
982
983         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
984         https://bugs.webkit.org/show_bug.cgi?id=167927
985
986         Reviewed by Brent Fulgham.
987
988         Enable ComplexTextController API tests on the Win and GTK ports.
989
990         * TestWebKitAPI/PlatformGTK.cmake:
991         * TestWebKitAPI/PlatformWin.cmake:
992
993 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
994
995         File index appended to previous file in svn-create-patch with SVN 1.9
996         https://bugs.webkit.org/show_bug.cgi?id=167903
997         <rdar://problem/30387395>
998
999         Reviewed by Daniel Bates.
1000
1001         * Scripts/VCSUtils.pm:
1002         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1003         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1004         trailing newline character from the expected result before comparing it to the actual result.
1005
1006 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1007
1008         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1009         https://bugs.webkit.org/show_bug.cgi?id=167936
1010
1011         Reviewed by Michael Catanzaro.
1012
1013         * Scripts/webkitdirs.pm:
1014         (determineArchitecture):
1015         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1016         since r195083.
1017
1018 2017-02-07  Youenn Fablet  <youenn@apple.com>
1019
1020         Use a JSON file to define which WPT files/folders to import
1021         https://bugs.webkit.org/show_bug.cgi?id=167923
1022
1023         Reviewed by Alex Christensen.
1024
1025         * Scripts/webkitpy/w3c/test_downloader.py:
1026         (TestDownloader.__init__):
1027         (TestDownloader._init_paths_from_expectations):
1028         * Scripts/webkitpy/w3c/test_importer.py:
1029         (parse_args):
1030         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1031
1032 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1033
1034         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1035         https://bugs.webkit.org/show_bug.cgi?id=167916
1036
1037         Reviewed by Carlos Garcia Campos.
1038
1039         URL of mesa-11.0.6.tar.xz has been moved.
1040
1041         * gtk/jhbuild.modules: Fix the module path.
1042
1043 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1044
1045         Static Analyzer: Address some leaks in MiniBrowser
1046         https://bugs.webkit.org/show_bug.cgi?id=167897
1047
1048         Reviewed by Alexey Proskuryakov.
1049
1050         * MiniBrowser/mac/BrowserWindowController.m:
1051         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1052         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1053         (-[ExtensionManagerWindowController add:]):
1054         (-[ExtensionManagerWindowController remove:]):
1055         * MiniBrowser/mac/SettingsController.m:
1056         (-[SettingsController _populateMenu]):
1057         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1058         Address obvious leaks caught by the static analyzer.
1059
1060 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1061
1062         Migrate ComplexTextController to use platform-independent types
1063         https://bugs.webkit.org/show_bug.cgi?id=167833
1064
1065         Reviewed by Brent Fulgham.
1066
1067         Migrate tests away from platform-dependent types.
1068
1069         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1070         (TestWebKitAPI::TEST_F):
1071
1072 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1073
1074         Correct File Path Handling in SecurityOrigin and FileSystem
1075         https://bugs.webkit.org/show_bug.cgi?id=167894
1076         <rdar://problem/30380080>
1077
1078         Reviewed by Alexey Proskuryakov.
1079
1080         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1081         and perform same-volume checks using filesystem-compatible paths.        
1082         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1083         filesystem paths, and perform validation of same-volume checks.
1084         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1085         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1086         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1087         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1088
1089 2017-02-06  Jer Noble  <jer.noble@apple.com>
1090
1091         Playback stalls when a SourceBuffer append causes frame eviction
1092         https://bugs.webkit.org/show_bug.cgi?id=167834
1093
1094         Reviewed by Eric Carlson.
1095
1096         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1097         for the WTF::MediaTime class.
1098
1099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1100         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1103         (WTF::operator<<):
1104         (TestWebKitAPI::TestSample::create):
1105         (TestWebKitAPI::TestSample::TestSample):
1106         (TestWebKitAPI::TEST_F):
1107
1108 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1109
1110         Change capitalization in platform name after r211735.
1111
1112         Unreviewed dashboard fix.
1113
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1115         (WebKitBuildbot):
1116
1117 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1118
1119         Move the Leaks bot to Sierra
1120         https://bugs.webkit.org/show_bug.cgi?id=167886
1121
1122         Reviewed by Daniel Bates.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/config.json:
1125         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1127         (LeaksViewer._displayURLPrompt):
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1129         (WebKitBuildbot):
1130
1131 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1132
1133         Prevent app crash on launch during simctl install workaround
1134         https://bugs.webkit.org/show_bug.cgi?id=167685
1135
1136         Reviewed by Daniel Bates.
1137
1138         * Scripts/webkitpy/port/simulator_process.py:
1139         (SimulatorProcess.__init__): Pass environment to install.
1140         * Scripts/webkitpy/xcode/simulator.py:
1141         (Device.install_app): Accept environment, pass environment to launch.
1142
1143 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1144
1145         Rebase API tests after r211638
1146         https://bugs.webkit.org/show_bug.cgi?id=167779
1147
1148         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1149         (TestWebKitAPI::TEST_F):
1150         URLs with non-special schemes and characters like % in the host now fail to parse,
1151         more like their special counterparts and according to spec.
1152
1153 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1154
1155         Unreviewed trivial fix after r211697.
1156         https://bugs.webkit.org/show_bug.cgi?id=167863
1157
1158         * Scripts/run-javascriptcore-tests:
1159         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1160
1161 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1162
1163         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1164         https://bugs.webkit.org/show_bug.cgi?id=167850
1165
1166         Reviewed by Tim Horton.
1167
1168         * DumpRenderTree/TestRunner.cpp:
1169         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1170
1171 2017-02-04  Andreas Kling  <akling@apple.com>
1172
1173         Plug some leaks in TestController and UIScriptContext.
1174         <https://webkit.org/b/167839>
1175
1176         Reviewed by Alexey Proskuryakov.
1177
1178         Fix a couple of the leaks seen on the leaks bot.
1179
1180         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1181         (UIScriptContext::runUIScript):
1182         * WebKitTestRunner/TestController.cpp:
1183         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1184         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1185
1186 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1187
1188         WK1 mouse events are missing movementX and movementY for pointerlock.
1189         https://bugs.webkit.org/show_bug.cgi?id=167775
1190         rdar://problem/30343810
1191
1192         Reviewed by Alexey Proskuryakov.
1193
1194         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1195
1196         * DumpRenderTree/mac/EventSendingController.mm:
1197         (-[EventSendingController mouseMoveToX:Y:]):
1198         * WebKitTestRunner/mac/EventSenderProxy.mm:
1199         (WTR::EventSenderProxy::mouseMoveTo):
1200
1201 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1202
1203         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1204         https://bugs.webkit.org/show_bug.cgi?id=167774
1205
1206         Reviewed by Tim Horton.
1207
1208         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1209         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1210         web process are async, so the callback fires after the web process gets the new state.
1211
1212         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1213         (WTR::UIScriptController::removeViewFromWindow):
1214         (WTR::UIScriptController::addViewToWindow):
1215         * DumpRenderTree/mac/DumpRenderTree.mm:
1216         (createWebViewAndOffscreenWindow):
1217         (resetWebViewToConsistentStateBeforeTesting):
1218         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1219         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1220         (WTR::UIScriptController::removeViewFromWindow):
1221         (WTR::UIScriptController::addViewToWindow):
1222         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1223         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1224         (WTR::UIScriptController::removeViewFromWindow):
1225         (WTR::UIScriptController::addViewToWindow):
1226         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1227         * WebKitTestRunner/PlatformWebView.h:
1228         * WebKitTestRunner/TestController.cpp:
1229         (WTR::TestController::resetStateToConsistentValues):
1230         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1231         (WTR::PlatformWebView::removeFromWindow):
1232         (WTR::PlatformWebView::addToWindow):
1233         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1234         (WTR::UIScriptController::removeViewFromWindow):
1235         (WTR::UIScriptController::addViewToWindow):
1236         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1237         (WTR::PlatformWebView::removeFromWindow):
1238         (WTR::PlatformWebView::addToWindow):
1239         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1240         (WTR::UIScriptController::removeViewFromWindow):
1241         (WTR::UIScriptController::addViewToWindow):
1242
1243 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1244
1245         Remove check for SkipSafariExecutableEntitlementChecks
1246         https://bugs.webkit.org/show_bug.cgi?id=167762
1247
1248         Reviewed by Dan Bernstein.
1249
1250         Follow-up fix: don't break internal behavior.
1251
1252         * Scripts/webkitdirs.pm:
1253         (safariPath):
1254         (executableHasEntitlements): Deleted.
1255         (safariPathFromSafariBundle): Deleted.
1256         (installedSafariPath): Deleted.
1257
1258 2017-02-03  Daniel Bates  <dabates@apple.com>
1259
1260         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1261         https://bugs.webkit.org/show_bug.cgi?id=167810
1262         <rdar://problem/30102568>
1263
1264         Reviewed by Anders Carlsson.
1265
1266         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1267
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1269         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1270         (TEST):
1271         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1272         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1273         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1274         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1275
1276 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1277
1278         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1279         https://bugs.webkit.org/show_bug.cgi?id=167773
1280         <rdar://problem/30221102>
1281
1282         Reviewed by Ryosuke Niwa.
1283
1284         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1285         (TestWebKitAPI::TEST_F):
1286
1287 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1288
1289         Remove check for SkipSafariExecutableEntitlementChecks
1290         https://bugs.webkit.org/show_bug.cgi?id=167762
1291         rdar://problem/22480673
1292
1293         Reviewed by Dan Bernstein.
1294
1295         * Scripts/webkitdirs.pm:
1296         (safariPathFromSafariBundle):
1297         (skipSafariExecutableEntitlementChecks): Deleted.
1298
1299 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1300
1301         Undefined subroutine in svn-create-patch
1302         https://bugs.webkit.org/show_bug.cgi?id=167742
1303
1304         Unreviewed build-fix after r211543.
1305
1306         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1307
1308 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1309
1310         Unreviewed. Fix jhbuild dependencies build.
1311
1312         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1313         Patch updated.
1314
1315 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1316
1317         [EME][GStreamer] Fixed decryptor selection
1318         https://bugs.webkit.org/show_bug.cgi?id=167588
1319
1320         Reviewed by Žan Doberšek.
1321
1322         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1323
1324         * gtk/jhbuild.modules: Added patches to gstreamer and
1325         gst-plugins-good packages.
1326         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1327         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1328
1329 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1330
1331         Make run-benchmark script supports 'config' key in test plan.
1332         https://bugs.webkit.org/show_bug.cgi?id=167715
1333
1334         Reviewed by Ryosuke Niwa.
1335
1336         Add support for 'config' key in test paln.
1337         'config' key is a dictionary that specifies environment configurations while test is running.
1338         Specifies orientation to be portrait in MotionMark benchmark.
1339
1340         * Scripts/webkitpy/benchmark_runner/README.md:
1341         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1342         (BenchmarkRunner.__init__):
1343         (BenchmarkRunner._run_benchmark):
1344         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1345         (BrowserDriver.prepare_env):
1346         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1347         (LinuxBrowserDriver.prepare_env):
1348         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1349         (OSXBrowserDriver.prepare_env):
1350         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1351         (OSXSafariDriver.prepare_env):
1352         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1353
1354 2017-02-01  Daniel Bates  <dabates@apple.com>
1355
1356         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1357         https://bugs.webkit.org/show_bug.cgi?id=167169
1358
1359         Reviewed by David Kilzer.
1360
1361         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1362         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1363         header from the output of "svn diff" on a file that was copied or moved.
1364
1365         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1366         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1367         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1368         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1369         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1370         of a file with only a property change also does not contain any chunk range lines. Therefore
1371         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1372         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1373         we should directly test for the presence of a leading SVN diff header with an empty body and
1374         remove such lines from the diff.
1375
1376         * Scripts/VCSUtils.pm:
1377         (fixSVNPatchForAdditionWithHistory): Added.
1378         * Scripts/svn-create-patch:
1379         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1380         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1381         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1382
1383 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1384
1385         [Mac] Update CARingBuffer class
1386         https://bugs.webkit.org/show_bug.cgi?id=167656
1387
1388         Reviewed by Jer Noble.
1389
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1392         (TestWebKitAPI::CARingBufferTest::SetUp):
1393         (TestWebKitAPI::CARingBufferTest::setup):
1394         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1395         (TestWebKitAPI::CARingBufferTest::description):
1396         (TestWebKitAPI::CARingBufferTest::bufferList):
1397         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1398         (TestWebKitAPI::CARingBufferTest::capacity):
1399         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1400         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1401         (TestWebKitAPI::TEST_F):
1402         (TestWebKitAPI::MixingTest::run):
1403
1404 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1405
1406         [Mac] TestWebKitAPI includes system frameworks incorrectly
1407         https://bugs.webkit.org/show_bug.cgi?id=167703
1408         rdar://problem/30301498
1409
1410         Reviewed by Ryosuke Niwa.
1411
1412         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1413         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1414
1415         Also, reduced the number of subframework search paths, looks like we only need one now.
1416
1417         * TestWebKitAPI/Configurations/Base.xcconfig:
1418
1419 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1420
1421         Correct "filesHaveSameVolume" predicate
1422         https://bugs.webkit.org/show_bug.cgi?id=167696
1423         <rdar://problem/30298722>
1424
1425         Reviewed by David Kilzer.
1426
1427         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1428         percent-escaped path inputs.
1429
1430         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1431         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1432         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1433         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1434         (TestWebKitAPI::TEST_F):
1435
1436 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1437
1438         Unreviewed. Fix coding style in MiniBrowser
1439
1440         * MiniBrowser/gtk/BrowserWindow.c:
1441         (editingCommandCallback):
1442         (insertImageCommandCallback):
1443         (insertLinkCommandCallback):
1444
1445 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1446
1447         [GTK] Add an API to add a custom tab into the print dialog
1448         https://bugs.webkit.org/show_bug.cgi?id=151998
1449
1450         Reviewed by Carlos Garcia Campos.
1451
1452         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1453         that is testing a newly added API.
1454
1455         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1456         (testPrintCustomWidget):
1457         (beforeAll):
1458
1459 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1460
1461         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1462         https://bugs.webkit.org/show_bug.cgi?id=166529
1463
1464         Reviewed by Xabier Rodriguez-Calvar.
1465
1466         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1467         New patch version accepted in GStreamer upstream.
1468
1469 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1470
1471         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1472         https://bugs.webkit.org/show_bug.cgi?id=167498
1473
1474         Reviewed by Carlos Garcia Campos.
1475
1476         Depending on the distro version you can need either libxfont1-dev
1477         or libfont-dev to build with jhbuild.
1478
1479         * gtk/install-dependencies:
1480
1481 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1482
1483         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1484         https://bugs.webkit.org/show_bug.cgi?id=167594
1485
1486         Unreviewed test gardening.
1487
1488         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1489
1490         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1491         (TEST):
1492
1493 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1494
1495         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1496         https://bugs.webkit.org/show_bug.cgi?id=167676
1497
1498         Reviewed by Saam Barati.
1499
1500         * Scripts/run-javascriptcore-tests:
1501         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1502
1503 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1504
1505         Make Dump Render Tree not crash
1506         https://bugs.webkit.org/show_bug.cgi?id=167667
1507
1508         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1509         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1510         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1511         This does not fix any tests, it just fixes the crash.
1512         
1513         Reviewed by Simon Fraser.
1514
1515         * DumpRenderTree/TestRunner.cpp:
1516         (TestRunner::callUIScriptCallback):
1517
1518 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1519
1520         Workaround for simctl install failing to report install failure
1521         https://bugs.webkit.org/show_bug.cgi?id=167654
1522
1523         Reviewed by Daniel Bates.
1524
1525         simctl install will sometimes report success even though install has failed.
1526         To workaround this bug, we attempt an app launch after install to ensure
1527         install has succeeded.
1528
1529         * Scripts/webkitpy/xcode/simulator.py:
1530         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1531         (Device.launch_app): Correct comment.
1532
1533 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1534
1535         Unreviewed webkitpy fix after r211405.
1536
1537         * Scripts/webkitpy/xcode/simulator.py:
1538         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1539
1540 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1541
1542         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1543
1544         * gtk/manifest.txt.in:
1545
1546 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1547
1548         AX: enable search predication for iOS
1549         https://bugs.webkit.org/show_bug.cgi?id=167558
1550         <rdar://problem/30251367>
1551
1552         Reviewed by Joanmarie Diggs.
1553
1554         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1555         (AccessibilityUIElement::uiElementForSearchPredicate):
1556         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1557         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1558         (searchPredicateParameterizedAttributeForSearchCriteria):
1559         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1560         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1561         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1562         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1563         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1564         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1565         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1566         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1567         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1568         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1569         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1570
1571 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1572
1573         Workaround for simctl launch bug
1574         https://bugs.webkit.org/show_bug.cgi?id=167613
1575
1576         Reviewed by Daniel Bates.
1577
1578         simctl launch will sometimes fail because of a race condition when many
1579         simulators are being run simultaneously. These failures will always have
1580         an exit code of 1. This change attempts to launch an app multiple times
1581         before reporting a failure to workaround this bug.
1582
1583         * Scripts/webkitpy/xcode/simulator.py:
1584         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1585
1586 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1587
1588         Commit queue fails to look at real name aliases for the reviewer
1589         https://bugs.webkit.org/show_bug.cgi?id=167422
1590
1591         Reviewed by Joseph Pecoraro.
1592
1593         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1594         (test_has_valid_reviewer): Added tests.
1595
1596         * Scripts/webkitpy/common/config/committers.py:
1597         (CommitterList._name_to_contributor_map):
1598         Made _name_to_contributor_map include alias names.
1599
1600         * Scripts/webkitpy/common/config/committers_unittest.py:
1601         (CommittersTest.test_contributors_by_fuzzy_match):
1602         Removed subtests that are now obsolete, as these matches are strict. It is not
1603         obvious if distance based fuzzy matching for names is useful at all, but we can
1604         look into that some other time.
1605
1606 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1607
1608         QueueStatusServer should have an explicit timeout for _fetch_url
1609         https://bugs.webkit.org/show_bug.cgi?id=167467
1610
1611         Reviewed by Alexey Proskuryakov.
1612
1613         * Scripts/webkitpy/common/net/statusserver.py:
1614         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1615
1616 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1617
1618         Add support for Trac instances that host multiple projects.
1619         https://bugs.webkit.org/show_bug.cgi?id=167524
1620
1621         Reviewed by Alexey Proskuryakov.
1622
1623         When multiple projects are hosted on a single Trac instance, the current
1624         behavior will retrieve changesets from all tracked projects.
1625         This patch teaches Trac.js to get project-specific changesets from Trac.
1626         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1627         when querying the Trac timeline.
1628
1629         To tell Trac to be aware of multi-project instances we leverage the 
1630         `options` parameter when creating a new instance: 
1631
1632             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1633
1634         If this option is not provided, the original behaviour will prevail.
1635         Additionally, add corresponding tests.
1636
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1638         (Trac): Reason about new optional parameter 'projectIdentifier'.
1639         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1640         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1641         replace default parameter `changeset=on` with `repo-projectname=on`.
1642         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1644         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1646         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1647         Add the following tests:
1648             test("revisionURL")
1649             test("revisionURL with Trac Identifier")
1650             test("_xmlTimelineURL")
1651             test("_xmlTimelineURL with Trac Identifier")
1652         (this.view._latestProductiveIteration): Fix missing ';'.
1653
1654 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1655
1656         Correct spacing regression on inter-element complex path shaping on some fonts
1657         https://bugs.webkit.org/show_bug.cgi?id=166013
1658
1659         Reviewed by Simon Fraser.
1660
1661         Unskip existing tests and make some new tests:
1662         - Testing complex text with no origins
1663         - Testing initial expansions
1664         - Testing the sign of vertical advances
1665
1666         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1667         (TestWebKitAPI::TEST_F):
1668
1669 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1670
1671         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1672         https://bugs.webkit.org/show_bug.cgi?id=167596
1673
1674         Reviewed by Daniel Bates.
1675
1676         We avoid needing a thin directory by invoking the zip program with
1677         the list of directories from the build directory to be zipped,
1678         and by using the zip feature to exclude files matching a pattern.
1679
1680         * BuildSlaveSupport/built-product-archive:
1681         (copyBuildFiles):
1682         (createZipFromList):
1683         (archiveBuiltProduct):
1684
1685 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1686
1687         Use simctl instead of LayoutTestRelay
1688         https://bugs.webkit.org/show_bug.cgi?id=165927
1689
1690         Reviewed by Daniel Bates.
1691
1692         Part 1
1693
1694         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1695         simulators through simctl (iOS 10 and later), use this functionality instead.
1696
1697         * Scripts/webkitpy/port/base.py:
1698         (Port.__init__): Added _test_runner_process_constructor.
1699         * Scripts/webkitpy/port/darwin.py:
1700         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1701         * Scripts/webkitpy/port/driver.py:
1702         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1703         (IOSSimulatorDriver): Deleted.
1704         * Scripts/webkitpy/port/driver_unittest.py:
1705         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1706         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1707         (DriverTest.test_start_actually_starts): Ditto.
1708         * Scripts/webkitpy/port/ios.py:
1709         (IOSSimulatorPort): Remove relay_name.
1710         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1711         (IOSSimulatorPort._create_simulators): Formatting change.
1712         (IOSSimulatorPort.relay_path): Deleted.
1713         (IOSSimulatorPort._check_relay): Deleted.
1714         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1715         (IOSSimulatorPort._build_relay): Deleted.
1716         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1717         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1718         * Scripts/webkitpy/port/ios_unittest.py:
1719         (iosTest.test_32bit): Update test.
1720         (iosTest.test_64bit): Update test.
1721         * Scripts/webkitpy/port/server_process.py:
1722         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1723         (ServerProcess._set_file_nonblocking): Added to share common code.
1724         * Scripts/webkitpy/port/server_process_mock.py:
1725         (MockServerProcess.__init__): Added argument worker_number.
1726         * Scripts/webkitpy/port/simulator_process.py: Added.
1727         (SimulatorProcess): Added.
1728         (SimulatorProcess.Popen): Added.
1729         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1730         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1731         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1732         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1733         (SimulatorProcess._reset): Added. Unlink fifos.
1734         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1735         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1736         * Scripts/webkitpy/xcode/simulator.py:
1737         (Device.__init__): Accept host to run install/launch/terminate.
1738         (Device.install_app): Install app to target Device.
1739         (Device.launch_app): Launch app on target Device.
1740         (Device.terminate_app): Shutdown app on target Device.
1741         (Simulator._parse_devices): Pass host to Device.
1742
1743 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1744
1745         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1746         https://bugs.webkit.org/show_bug.cgi?id=167411
1747
1748         Reviewed by Michael Catanzaro.
1749
1750         Disable the ARM iwMMXt fast path for pixman, because it triggers
1751         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1752
1753         * gtk/jhbuild.modules:
1754
1755 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1756
1757         [GTK] Add API to handle the accelerated compositing policy
1758         https://bugs.webkit.org/show_bug.cgi?id=167509
1759
1760         Reviewed by Michael Catanzaro.
1761
1762         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1763         as a special case. Also add test cases to the get/set API.
1764
1765         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1766         (hardwareAccelerationPolicyToString):
1767         (stringToHardwareAccelerationPolicy):
1768         (cellRendererChanged):
1769         (browserSettingsDialogConstructed):
1770         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1771         (testWebKitSettings):
1772
1773 2017-01-29  Andy Estes  <aestes@apple.com>
1774
1775         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1776         https://bugs.webkit.org/show_bug.cgi?id=167563
1777         <rdar://problem/30253207>
1778
1779         Reviewed by Andreas Kling.
1780
1781         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1782         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1783         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1784         (runTest):
1785         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1786         (TEST):
1787
1788 2017-01-29  Dan Bernstein  <mitz@apple.com>
1789
1790         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1791         https://bugs.webkit.org/show_bug.cgi?id=167565
1792
1793         Reviewed by Sam Weinig.
1794
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1797         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1798         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1799         (TEST):
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1801         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1802         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1803         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1804
1805 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1806
1807         Add Link Preload as an off-by-default experimental feature menu item.
1808         https://bugs.webkit.org/show_bug.cgi?id=167201
1809
1810         Reviewed by Ryosuke Niwa.
1811
1812         * DumpRenderTree/mac/DumpRenderTree.mm:
1813         (resetWebPreferencesToConsistentValues):
1814         * DumpRenderTree/win/DumpRenderTree.cpp:
1815         (resetWebPreferencesToConsistentValues):
1816
1817 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1818
1819         Add User Timing Experimental Feature
1820         https://bugs.webkit.org/show_bug.cgi?id=167542
1821         <rdar://problem/22746307>
1822
1823         Reviewed by Ryosuke Niwa.
1824
1825         * DumpRenderTree/mac/DumpRenderTree.mm:
1826         (enableExperimentalFeatures):
1827         (resetWebPreferencesToConsistentValues):
1828         * DumpRenderTree/win/DumpRenderTree.cpp:
1829         (enableExperimentalFeatures):
1830
1831 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1832
1833         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1834         https://bugs.webkit.org/show_bug.cgi?id=167519
1835
1836         Reviewed by Ryosuke Niwa.
1837
1838         * QueueStatusServer/templates/statusbubble.html:
1839         To measure the bubbleContainer's width, it must not be wrapping based
1840         on its parent container. So when measuring the width temporarily set
1841         the parent to a very large width so as to not artificially wrap us.
1842         Restore the parent's width after measuring.
1843
1844 2017-01-27  Andy Estes  <aestes@apple.com>
1845
1846         [iOS] Add a test for _WKNSFileManagerExtras
1847         https://bugs.webkit.org/show_bug.cgi?id=167478
1848
1849         Reviewed by Andreas Kling.
1850
1851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1853         (expectAttributes):
1854         (TEST):
1855
1856 2017-01-27  Keith Miller  <keith_miller@apple.com>
1857
1858         run-benchmarks should make sure it passes the test url to the right application
1859         https://bugs.webkit.org/show_bug.cgi?id=167533
1860
1861         Reviewed by Joseph Pecoraro.
1862
1863         This fixes an issue when trying to run-benchmark script with the
1864         system default browser set to STP. Previously, it would run
1865         the test in STP rather than the provided build. Now, it should run
1866         in the provided build.
1867
1868         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1869         (OSXSafariDriver.launch_url):
1870
1871 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1872
1873         [Cocoa] Prepare ComplexTextController for unit testing
1874         https://bugs.webkit.org/show_bug.cgi?id=167493
1875
1876         Reviewed by Simon Fraser.
1877
1878         Addressing post-review comments from Simon Fraser.
1879
1880         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1881         (TestWebKitAPI::TEST_F):
1882
1883 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1884
1885         [Cocoa] Prepare ComplexTextController for unit testing
1886         https://bugs.webkit.org/show_bug.cgi?id=167493
1887
1888         Reviewed by Dean Jackson.
1889
1890         Create four unit tests.
1891
1892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1893         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1894         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1895         (TestWebKitAPI::TEST_F):
1896
1897 2017-01-26  Chris Dumez  <cdumez@apple.com>
1898
1899         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1900         https://bugs.webkit.org/show_bug.cgi?id=167421
1901         <rdar://problem/30188490>
1902
1903         Reviewed by Darin Adler.
1904
1905         Add a new setting allowing layout tests to enable PageCache in a window
1906         that has an opener, for convenience.
1907
1908         * DumpRenderTree/mac/DumpRenderTree.mm:
1909         (resetWebPreferencesToConsistentValues):
1910         * DumpRenderTree/win/DumpRenderTree.cpp:
1911         (resetWebPreferencesToConsistentValues):
1912         * WebKitTestRunner/TestController.cpp:
1913         (WTR::TestController::resetPreferencesToConsistentValues):
1914
1915 2017-01-26  Keith Miller  <keith_miller@apple.com>
1916
1917         classInfo should take a VM so it is not materialized from the object on each call
1918         https://bugs.webkit.org/show_bug.cgi?id=167424
1919
1920         Rubber Stamped by Michael Saboff.
1921
1922         Previously, classInfo() would get the VM from the target's
1923         MarkedBlock.  Most callers already have a VM on hand, so it is
1924         wasteful to compute the VM from the marked block every time. This
1925         patch refactors some of the most common callers of classInfo(),
1926         jsDynamicCast and inherits to take a VM as well.
1927
1928         * DumpRenderTree/TestRunner.cpp:
1929         (setAudioResultCallback):
1930
1931 2017-01-26  Jer Noble  <jer.noble@apple.com>
1932
1933         Autoplay muted videos stop playback of any streaming app in the background
1934         https://bugs.webkit.org/show_bug.cgi?id=163993
1935         <rdar://problem/29020431>
1936
1937         Reviewed by Eric Carlson.
1938
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1940         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1943
1944 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1945
1946         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1947         https://bugs.webkit.org/show_bug.cgi?id=167466
1948
1949         Unreviewed test gardening.
1950
1951         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1952         (TEST):
1953
1954 2017-01-26  Matt Rajca  <mrajca@apple.com>
1955
1956         Notify clients when the user plays media otherwise prevented from autoplaying
1957         https://bugs.webkit.org/show_bug.cgi?id=167390
1958
1959         Reviewed by Alex Christensen.
1960
1961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1962         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1963         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1964         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1965         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1966         (TEST):
1967         * TestWebKitAPI/cocoa/TestWKWebView.h:
1968         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1969         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1970         (-[TestWKWebView waitForLoad]):
1971         (-[TestWKWebView mouseUpAtPoint:]):
1972         * WebKitTestRunner/TestController.cpp:
1973         (WTR::TestController::createOtherPage):
1974         (WTR::TestController::createWebViewWithOptions):
1975
1976 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1977
1978         Crash when setting custom scale factor.
1979         https://bugs.webkit.org/show_bug.cgi?id=167369
1980
1981         Reviewed by Sam Weinig.
1982
1983         Added API test.
1984
1985         * TestWebKitAPI/PlatformWin.cmake:
1986         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1987         (TestWebKitAPI::WebKitCreateInstance):
1988         (TestWebKitAPI::ScaleWebView::SetUp):
1989         (TestWebKitAPI::ScaleWebView::TearDown):
1990         (TestWebKitAPI::TEST_F):
1991
1992 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1993
1994         run-benchmark nests MotionMark results by the suite name twice
1995         https://bugs.webkit.org/show_bug.cgi?id=164948
1996
1997         Reviewed by Said Abou-Hallawa.
1998
1999         Use a single level MotionMark now that this is the name of the benchmark,
2000         and we no longer have tests that aren't part of the MotionMark suite.
2001
2002         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2003
2004 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2005
2006         Unreviewed, rolling out r211193.
2007
2008         This change broke internal builds.
2009
2010         Reverted changeset:
2011
2012         "Notify clients when the user plays media otherwise prevented
2013         from autoplaying"
2014         https://bugs.webkit.org/show_bug.cgi?id=167390
2015         http://trac.webkit.org/changeset/211193
2016
2017 2017-01-25  Matt Rajca  <mrajca@apple.com>
2018
2019         Notify clients when the user plays media otherwise prevented from autoplaying
2020         https://bugs.webkit.org/show_bug.cgi?id=167390
2021
2022         Reviewed by Alex Christensen.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2026         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2027         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2028         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2029         (TEST):
2030         * TestWebKitAPI/cocoa/TestWKWebView.h:
2031         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2032         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2033         (-[TestWKWebView waitForLoad]):
2034         (-[TestWKWebView mouseUpAtPoint:]):
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::TestController::createOtherPage):
2037         (WTR::TestController::createWebViewWithOptions):
2038
2039 2017-01-25  Matt Rajca  <mrajca@apple.com>
2040
2041         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2042         https://bugs.webkit.org/show_bug.cgi?id=167385
2043
2044         Reviewed by Alex Christensen.
2045
2046         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2047         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2048         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2049         (TEST): Allow inline (rather than full screen) media playback on iOS.
2050
2051 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2054         https://bugs.webkit.org/show_bug.cgi?id=167414
2055
2056         Reviewed by Michael Catanzaro.
2057
2058         Add a test case to check ephemeral web views don't write favicons to the database.
2059
2060         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2061         (ephemeralViewLoadChanged):
2062         (testPrivateBrowsing):
2063         (testFaviconDatabase):
2064
2065 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2066
2067         [GTK] Add a private browsing mode to MiniBrowser
2068         https://bugs.webkit.org/show_bug.cgi?id=167413
2069
2070         Reviewed by Michael Catanzaro.
2071
2072         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2073         private windows, even on non-private instances.
2074
2075         * MiniBrowser/gtk/BrowserWindow.c:
2076         (webViewTitleChanged): Add [Private] to title window for private windows.
2077         (webViewCreate): Pass web context to browser_window_new.
2078         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2079         (browserWindowFinalize): Disconnect web context signal handlers.
2080         (browser_window_init): Add shortcut for opening private window.
2081         (browser_window_new): It now receives the context and connect to download-started here.
2082         (browser_window_get_web_context): Return the context.
2083         * MiniBrowser/gtk/BrowserWindow.h:
2084         * MiniBrowser/gtk/main.c:
2085         (createBrowserTab): Create the web view for the window web context.
2086         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2087         (aboutDataHandleRequest): Ditto.
2088         (aboutURISchemeRequestCallback): Ditto.
2089         (main): Create ephemeral web context if private command line option is used.
2090
2091 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2092
2093         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2094         https://bugs.webkit.org/show_bug.cgi?id=167409
2095
2096         Reviewed by Antti Koivisto.
2097
2098         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2099         as well as tests for the newly added matchingElementInFlatTree.
2100
2101         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2102         (TestWebKitAPI::runJavaScriptAlert):
2103         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2104         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2105         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2106
2107 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2110         https://bugs.webkit.org/show_bug.cgi?id=167370
2111
2112         Reviewed by Michael Catanzaro.
2113
2114         Add several test cases of ephemeral web views.
2115
2116         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2117         (testWebViewAuthenticationStorage):
2118         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2119         (ephemeralViewloadChanged):
2120         (testCookieManagerEphemeral):
2121         (beforeAll):
2122         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2123         (testWebKitSettings):
2124         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2125         (testWebContextEphemeral):
2126         (ephemeralViewloadChanged):
2127         (testWebContextProxySettings):
2128         (beforeAll):
2129         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2130         (ephemeralViewloadChanged):
2131         (testWebViewEphemeral):
2132         (beforeAll):
2133         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2134         (ephemeralViewloadChanged):
2135         (testWebsiteDataEphemeral):
2136         (beforeAll):
2137
2138 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2139
2140         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2141         https://bugs.webkit.org/show_bug.cgi?id=167402
2142
2143         Reviewed by Ryosuke Niwa.
2144
2145         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2146         (TestWebKitAPI::TEST):
2147
2148 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2149
2150         Add simple line layout toggle to MiniBrowser
2151         https://bugs.webkit.org/show_bug.cgi?id=167405
2152
2153         Reviewed by Andreas Kling.
2154
2155         * MiniBrowser/mac/SettingsController.h:
2156         * MiniBrowser/mac/SettingsController.m:
2157         (-[SettingsController _populateMenu]):
2158         (-[SettingsController validateMenuItem:]):
2159         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2160         (-[SettingsController simpleLineLayoutEnabled]):
2161         * MiniBrowser/mac/WK1BrowserWindowController.m:
2162         (-[WK1BrowserWindowController didChangeSettings]):
2163         * MiniBrowser/mac/WK2BrowserWindowController.m:
2164         (-[WK2BrowserWindowController didChangeSettings]):
2165
2166 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2167
2168         WKR does not include my nick when commit-queue lands my patch
2169         https://bugs.webkit.org/show_bug.cgi?id=167388
2170
2171         Reviewed by Ryosuke Niwa.
2172
2173         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2174         (NewCommitBot._summarize_commit_log):
2175         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2176         Perform nickname insertion before grabbing "Patch by" details.
2177         This way we can include the nickname with the full name.
2178
2179 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2180
2181         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2182         https://bugs.webkit.org/show_bug.cgi?id=167394
2183
2184         Reviewed by Ryosuke Niwa.
2185
2186         * Scripts/webkitperl/FeatureList.pm:
2187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2188
2189 2017-01-24  Youenn Fablet  <youenn@apple.com>
2190
2191         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2192         https://bugs.webkit.org/show_bug.cgi?id=167353
2193
2194         Reviewed by Alex Christensen.
2195
2196         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2197         (CMakeGenerator.initialize_targets):
2198
2199 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2200
2201         WKR should not confuse Miguel Gomez with Andres Gomez
2202         https://bugs.webkit.org/show_bug.cgi?id=167389
2203
2204         Reviewed by Lucas Forschler.
2205
2206         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2207         "mAndres Gomez". Fix this.
2208
2209         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2210         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2211         space on each side of the email address, so expect both spaces to be there before
2212         considering the email for replacement.
2213         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2214
2215 2017-01-24  Matt Rajca  <mrajca@apple.com>
2216
2217         Pass down website autoplay policies to media elements
2218         https://bugs.webkit.org/show_bug.cgi?id=167355
2219
2220         Reviewed by Alex Christensen.
2221
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2223         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2224         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2225         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2226         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2227         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2228         (TEST):
2229
2230 2017-01-24  Nan Wang  <n_wang@apple.com>
2231
2232         AX: Speak Selection does not work in an iframe
2233         https://bugs.webkit.org/show_bug.cgi?id=166794
2234         <rdar://problem/29913013>
2235
2236         Reviewed by Chris Fleizach.
2237
2238         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2239         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2240         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2241         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2242         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2243         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2244         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2245         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2246         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2247         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2248         (-[TestRunnerWKWebView dealloc]):
2249         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2250         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2252         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2253         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2254
2255 2017-01-24  Daniel Bates  <dabates@apple.com>
2256
2257         StringView.split() should use an iterator design pattern instead of allocating a Vector
2258         https://bugs.webkit.org/show_bug.cgi?id=163225
2259
2260         Reviewed by Darin Adler.
2261
2262         Add unit tests for StringView.split().
2263
2264         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2265         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2266         used in the StringView.split() unit tests.
2267         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2268         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2269         object to a Vector of String objects.
2270         (TestWebKitAPI::TEST): Added the following tests:
2271             - WTF.StringViewSplitEmptyAndNullStrings
2272             - WTF.StringViewSplitBasic
2273             - WTF.StringViewSplitWithConsecutiveSeparators
2274
2275 2017-01-23  Anders Carlsson  <andersca@apple.com>
2276
2277         The Score Esports crashes on launch
2278         https://bugs.webkit.org/show_bug.cgi?id=167338
2279         rdar://problem/29948645
2280
2281         Reviewed by Dan Bernstein.
2282
2283         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2284         (TestWebKitAPI::TEST):
2285         Add a test.
2286
2287 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2288
2289         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2290         https://bugs.webkit.org/show_bug.cgi?id=146589
2291
2292         Reviewed by Michael Catanzaro.
2293
2294         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2295         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2296
2297         * MiniBrowser/gtk/BrowserWindow.c:
2298         (webViewDecidePolicy):
2299         (newTabCallback):
2300         * MiniBrowser/gtk/main.c:
2301         (createBrowserTab):
2302         (aboutDataRequestFree):
2303         (aboutDataRequestNew):
2304         (aboutDataRequestForView):
2305         (websiteDataRemovedCallback):
2306         (websiteDataClearedCallback):
2307         (aboutDataScriptMessageReceivedCallback):
2308         (domainListFree):
2309         (aboutDataFillTable):
2310         (gotWebsiteDataCallback):
2311         (aboutDataHandleRequest):
2312         (aboutURISchemeRequestCallback):
2313         (main):
2314         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2315         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2316         (serverCallback):
2317         (beforeAll):
2318         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2319         (serverCallback):
2320         (WebsiteDataTest::WebsiteDataTest):
2321         (WebsiteDataTest::~WebsiteDataTest):
2322         (WebsiteDataTest::fetch):
2323         (WebsiteDataTest::remove):
2324         (WebsiteDataTest::clear):
2325         (testWebsiteDataConfiguration):
2326         (testWebsiteDataCache):
2327         (testWebsiteDataStorage):
2328         (testWebsiteDataDatabases):
2329         (testWebsiteDataAppcache):
2330         (beforeAll):
2331         (afterAll):
2332
2333 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2334
2335         Unreviewed, rolling out r211062.
2336         https://bugs.webkit.org/show_bug.cgi?id=167354
2337
2338         broke API tests (Requested by alexchristensen on #webkit).
2339
2340         Reverted changeset:
2341
2342         "Pass down website autoplay policies to media elements"
2343         https://bugs.webkit.org/show_bug.cgi?id=167132
2344         http://trac.webkit.org/changeset/211062
2345
2346 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2347
2348         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2349         https://bugs.webkit.org/show_bug.cgi?id=167330
2350
2351         Reviewed by Tim Horton.
2352
2353         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2354         (TestWebKitAPI::TEST_F):
2355
2356 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2357
2358         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2359         https://bugs.webkit.org/show_bug.cgi?id=167317
2360
2361         Reviewed by Sam Weinig.
2362
2363         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2364         (TestWebKitAPI::TEST_F):
2365
2366 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2367
2368         svn-create-patch should emit properties when files are moved or copied
2369         https://bugs.webkit.org/show_bug.cgi?id=167264
2370
2371         Reviewed by Daniel Bates.
2372
2373         * Scripts/svn-create-patch:
2374         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2375
2376 2017-01-23  Youenn Fablet  <youenn@apple.com>
2377
2378         [WebRTC] Filter libwebrtc link flags
2379         https://bugs.webkit.org/show_bug.cgi?id=167287
2380
2381         Reviewed by Alex Christensen.
2382
2383         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2384         (CMakeGenerator._compute_link_flags):
2385         (CMakeGenerator._compute_link_flags.keep_flag):
2386         (CMakeGenerator._generate_compile_target_options):
2387
2388 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2389
2390         [WebRTC] Make VP8 optional in libwebrtc
2391         https://bugs.webkit.org/show_bug.cgi?id=167257
2392
2393         Reviewed by Darin Adler.
2394
2395         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2396         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2397
2398 2017-01-23  Jer Noble  <jer.noble@apple.com>
2399
2400         Video details does not apear and missing scrubber in Control Center
2401         https://bugs.webkit.org/show_bug.cgi?id=167233
2402
2403         Reviewed by Alex Christensen.
2404
2405         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2406         NowPlayingControlTests for iOS.
2407
2408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2409         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2410         (-[NowPlayingTestWebView setWindowVisible:]):
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2415         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2416         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2417         (SOFT_LINK_CLASS):
2418         (-[TestMessageHandler addMessage:withHandler:]):
2419         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2420         (__simulated_forceClickAssociatedEventsMask):
2421         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2422         (-[TestWKWebViewHostWindow isKeyWindow]):
2423         (-[TestWKWebViewHostWindow makeKeyWindow]):
2424         (-[TestWKWebViewHostWindow resignKeyWindow]):
2425         (-[TestWKWebView initWithFrame:]):
2426         (-[TestWKWebView initWithFrame:configuration:]):
2427         (-[TestWKWebView _setUpTestWindow:]):
2428         (-[TestWKWebView performAfterReceivingMessage:action:]):
2429         (-[TestWKWebView loadTestPageNamed:]):
2430         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2431         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2432         (-[TestWKWebView waitForMessage:]):
2433         (-[TestWKWebView performAfterLoading:]):
2434         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2435         (-[TestWKWebView typeCharacter:]):
2436
2437 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2438
2439         Unreviewed. Bring back gtk-doc error messages after r209981.
2440
2441         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2442         impossible to know what's wrong.
2443
2444         * gtk/gtkdoc.py:
2445         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2446
2447 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2448
2449         [WebRTC] Update build system to make G711 optional in libwebrtc
2450         https://bugs.webkit.org/show_bug.cgi?id=167256
2451
2452         Reviewed by Alex Christensen.
2453
2454         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2455         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2456
2457 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2458
2459         Cleanup RuntimeEnabledFeatures
2460         https://bugs.webkit.org/show_bug.cgi?id=167228
2461
2462         Reviewed by Simon Fraser.
2463
2464         * DumpRenderTree/mac/DumpRenderTree.mm:
2465         (enableExperimentalFeatures):
2466         (resetWebPreferencesToConsistentValues):
2467         (setWebPreferencesForTestOptions):
2468         (resetWebViewToConsistentStateBeforeTesting):
2469         * DumpRenderTree/win/DumpRenderTree.cpp:
2470         (enableExperimentalFeatures):
2471         (resetWebPreferencesToConsistentValues):
2472         More closely match WebKitTestRunner initialization of preferences
2473         for experimental features.
2474
2475 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2476
2477         Build Fix for Windows DumpRenderTree after r210976
2478         https://bugs.webkit.org/show_bug.cgi?id=167115
2479
2480         * DumpRenderTree/win/DumpRenderTree.cpp:
2481         (resetWebPreferencesToConsistentValues):
2482
2483 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2484
2485         Remove outdated ENABLE(CSP_NEXT) build flag
2486         https://bugs.webkit.org/show_bug.cgi?id=167252
2487
2488         Reviewed by Brent Fulgham.
2489
2490         * Scripts/webkitperl/FeatureList.pm:
2491         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2492
2493 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2494
2495         Build Fix for Windows DumpRenderTree after r210976
2496
2497         * DumpRenderTree/win/DumpRenderTree.cpp:
2498         (resetWebPreferencesToConsistentValues):
2499
2500 2017-01-20  Antoine Quint  <graouts@apple.com>
2501
2502         Web Animations should be off by default and enabled as an experimental feature
2503         https://bugs.webkit.org/show_bug.cgi?id=167115
2504         <rdar://problem/30048963>
2505
2506         Reviewed by Joseph Pecoraro.
2507
2508         Turn Web Animations on in DRT.
2509
2510         * DumpRenderTree/mac/DumpRenderTree.mm:
2511         (resetWebPreferencesToConsistentValues):
2512         * DumpRenderTree/win/DumpRenderTree.cpp:
2513         (resetWebPreferencesToConsistentValues):
2514
2515 2017-01-20  Youenn Fablet  <youenn@apple.com>
2516
2517         [WebRTC] Add libwebrtc build infrastructure
2518         https://bugs.webkit.org/show_bug.cgi?id=167207
2519
2520         Reviewed by Alex Christensen.
2521
2522         Adding a script doing the libwebrtc project json to CMake file conversion.
2523
2524         * Scripts/generate-libwebrtc-cmake: Added.
2525         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2526         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2527
2528 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2529
2530         Mini Browser: Show tooltip for Experimental Features
2531         https://bugs.webkit.org/show_bug.cgi?id=167225
2532
2533         Reviewed by Alex Christensen.
2534
2535         * MiniBrowser/mac/SettingsController.m:
2536         (-[SettingsController _populateMenu]):
2537         Include the full details string as a tooltip.
2538
2539 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2540
2541         [Win] Test output results should not be written twice.
2542         https://bugs.webkit.org/show_bug.cgi?id=167197
2543
2544         Reviewed by Brent Fulgham.
2545
2546         Prevent test output from being written twice by returning early from
2547         the dump() function, if it already has been called.
2548         This patch also adds a missing newline to a test output line. 
2549         
2550         * DumpRenderTree/win/DumpRenderTree.cpp:
2551         (dump):
2552
2553 2017-01-20  Antoine Quint  <graouts@apple.com>
2554
2555         [Modern Media Controls] Turn modern media controls on by default
2556         https://bugs.webkit.org/show_bug.cgi?id=165668
2557
2558         Reviewed by Dean Jackson.
2559
2560         Enabled modern media controls by default in test runners.
2561
2562         * DumpRenderTree/TestOptions.h:
2563         * WebKitTestRunner/TestOptions.h:
2564
2565 2017-01-19  Chris Dumez  <cdumez@apple.com>
2566
2567         iterable<> should be enabled on WK1
2568         https://bugs.webkit.org/show_bug.cgi?id=167221
2569         <rdar://problem/30108531>
2570
2571         Reviewed by Youenn Fablet.
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (resetWebPreferencesToConsistentValues):
2575         * DumpRenderTree/win/DumpRenderTree.cpp:
2576         (resetWebPreferencesToConsistentValues):
2577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2578         (WTR::InjectedBundle::beginTesting):
2579         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2580         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2581         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2582
2583 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2584
2585         Ensure status server logs go to log file
2586         https://bugs.webkit.org/show_bug.cgi?id=167210
2587
2588         Reviewed by Alexey Proskuryakov.
2589
2590         * Scripts/webkitpy/common/net/statusserver.py:
2591         (StatusServer.next_work_item): Change log level from debug to info in
2592         order to facilitate deubgging issues.
2593         (StatusServer.update_work_items): Same.
2594
2595 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2596
2597         Additional selection tests and interpolation fix
2598         https://bugs.webkit.org/show_bug.cgi?id=167171
2599
2600         Reviewed by Simon Fraser.
2601
2602         We weren't adding the final event when interpolating event streams.
2603
2604         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2605         (-[HIDEventGenerator interpolatedEvents:]):
2606
2607 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2608
2609         [Cocoa] Variation fonts are erroneously disabled on iOS
2610         https://bugs.webkit.org/show_bug.cgi?id=167172
2611
2612         Reviewed by Simon Fraser.
2613
2614         OpenSource builders don't seem to understand sdk=embedded*.
2615
2616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2617
2618 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2619
2620         Unreviewed. Fix GTK+ unit tests failing since r210531.
2621
2622         Avoid using paths to files that don't actually exist.
2623
2624         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2625         (testWebKitConsoleMessageNetworkError):
2626         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2627         (testContextMenuDefaultMenu):
2628         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2629         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2630         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2631
2632 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2633
2634         [GTK] Provide API to set proxy settings
2635         https://bugs.webkit.org/show_bug.cgi?id=128674
2636
2637         Reviewed by Michael Catanzaro.
2638
2639         Add tests for new proxy settings API.
2640
2641         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2642         (serverCallback):
2643         (ProxyTest::ProxyTest):
2644         (ProxyTest::~ProxyTest):
2645         (ProxyTest::loadURIAndGetMainResourceData):
2646         (ProxyTest::proxyServerPortAsString):
2647         (testWebContextProxySettings):
2648         (beforeAll):
2649
2650 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2651
2652         Add back my old email address so old commits will still match it.
2653
2654         * Scripts/webkitpy/common/config/contributors.json:
2655
2656 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2657
2658         Remove my old email address from contributors.json and watchlist.
2659
2660         * Scripts/validate-committer-lists:
2661         (CommitterListFromGit): Change the mapping to the correct email.
2662         * Scripts/webkitpy/common/config/contributors.json:
2663         * Scripts/webkitpy/common/config/watchlist:
2664
2665 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2666
2667         Unreviewed, rolling out r210848.
2668
2669         This change introduced media-related LayoutTest failures and
2670         crashes on macOS.
2671
2672         Reverted changeset:
2673
2674         "[Modern Media Controls] Turn modern media controls on by
2675         default"
2676         https://bugs.webkit.org/show_bug.cgi?id=165668
2677         http://trac.webkit.org/changeset/210848
2678
2679 2017-01-18  Andreas Kling  <akling@apple.com>
2680
2681         Document::securityOrigin() should return a reference.
2682         <https://webkit.org/b/167124>
2683
2684         Reviewed by Sam Weinig.
2685
2686         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2687         (TestWebKitAPI::TEST_F):
2688
2689 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2690
2691         [Win] Clipboard tests are flaky.
2692         https://bugs.webkit.org/show_bug.cgi?id=167088
2693
2694         Reviewed by Brent Fulgham.
2695
2696         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2697         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2698
2699         * DumpRenderTree/win/DumpRenderTree.cpp:
2700         (main):
2701
2702 2017-01-18  Antoine Quint  <graouts@apple.com>
2703
2704         [Modern Media Controls] Turn modern media controls on by default
2705         https://bugs.webkit.org/show_bug.cgi?id=165668
2706
2707         Reviewed by Dean Jackson.
2708
2709         Enabled modern media controls by default in test runners. 
2710
2711         * DumpRenderTree/TestOptions.h:
2712         * WebKitTestRunner/TestOptions.h:
2713
2714 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2715
2716         Unreviewed, rolling out r210834
2717         https://bugs.webkit.org/show_bug.cgi?id=165668
2718
2719         It introduced dozens of test timeouts.
2720
2721         Reverted changeset:
2722         "[Modern Media Controls] Turn modern media controls on by default"
2723         https://bugs.webkit.org/show_bug.cgi?id=165668
2724         http://trac.webkit.org/changeset/210834
2725
2726 2017-01-17  Antoine Quint  <graouts@apple.com>
2727
2728         [Modern Media Controls] Turn modern media controls on by default
2729         https://bugs.webkit.org/show_bug.cgi?id=165668
2730
2731         Reviewed by Dean Jackson.
2732
2733         Enabled modern media controls by default in test runners. 
2734
2735         * DumpRenderTree/TestOptions.h:
2736         * WebKitTestRunner/TestOptions.h:
2737
2738 2017-01-17  Chris Dumez  <cdumez@apple.com>
2739
2740         Document title changed twice when setting document.title
2741         https://bugs.webkit.org/show_bug.cgi?id=167065
2742
2743         Reviewed by Darin Adler.
2744
2745         Add WebKit2GTK API test that was written by Michael Catanzaro.
2746
2747         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2748         (testWebViewTitleChange):
2749         (beforeAll):
2750
2751 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2752
2753         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2754         https://bugs.webkit.org/show_bug.cgi?id=116551
2755         <rdar://problem/13949830>
2756
2757         Reviewed by Alex Christensen.
2758
2759         * Scripts/webkitperl/FeatureList.pm:
2760         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2761         that is part of the existing WEB_TIMING feature.
2762
2763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2764
2765 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2766
2767         'webkit-patch post' no longer works with moved/copied files
2768         https://bugs.webkit.org/show_bug.cgi?id=166914
2769         <rdar://problem/29979707>
2770
2771         Reviewed by Daniel Bates.
2772
2773         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2774         file outputs only the "Index:" line with an empty body.  This workaround
2775         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2776         public email list tracking this bug is below.
2777         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2778         
2779
2780         * Scripts/svn-create-patch:
2781         (generateDiff): Ignore an "Index:" line with an empty body.
2782
2783 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2784
2785         Remove the REQUEST_ANIMATION_FRAME flag
2786         https://bugs.webkit.org/show_bug.cgi?id=156980
2787         <rdar://problem/25906849>
2788
2789         Reviewed by Simon Fraser.
2790
2791         * Scripts/webkitperl/FeatureList.pm:
2792         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2793
2794 2017-01-15  Sam Weinig  <sam@webkit.org>
2795
2796         Add the ability to use numbers in makeString()
2797         https://bugs.webkit.org/show_bug.cgi?id=167087
2798
2799         Reviewed by Darin Adler.
2800
2801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2802         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2803         Add tests for StringConcatenate, focusing on new numeric additions.
2804
2805 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2806
2807         Unreviewed, remove stale comment.
2808
2809         This test was fixed by r163173.
2810
2811         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2812
2813 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2814
2815         Annotate large string tests with largeHeap
2816         https://bugs.webkit.org/show_bug.cgi?id=167054
2817
2818         Reviewed by Filip Pizlo.
2819
2820         * Scripts/run-javascriptcore-tests:
2821         * Scripts/run-jsc-stress-tests:
2822
2823 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2824
2825         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2826         https://bugs.webkit.org/show_bug.cgi?id=167043
2827
2828         Reviewed by Darin Adler.
2829
2830         * Scripts/webkitperl/FeatureList.pm:
2831
2832 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2833
2834         Remove ENABLE(DETAILS_ELEMENT) guards
2835         https://bugs.webkit.org/show_bug.cgi?id=167042
2836
2837         Reviewed by Alex Christensen.
2838
2839         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2840
2841 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2842
2843         26 MotionMark performance tests failing
2844         https://bugs.webkit.org/show_bug.cgi?id=166854
2845
2846         Reviewed by Ryosuke Niwa.
2847
2848         Unrelated change. This is the last place that we need to rename Animometer
2849         to MotionMark.
2850
2851         * Scripts/webkitpy/common/config/watchlist:
2852
2853 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2854
2855         run-jsc-benchmarks' echo should have -e option
2856         https://bugs.webkit.org/show_bug.cgi?id=167009
2857
2858         Reviewed by Sam Weinig.
2859
2860         echo requires `-e` option to use escape sequence.
2861         Without it, in some environment (in my Fedora 25), the escape sequence is not
2862         recognized and just dumped as `\c` etc.
2863
2864         * Scripts/run-jsc-benchmarks:
2865
2866 2017-01-12  Chris Dumez  <cdumez@apple.com>
2867
2868         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2869         https://bugs.webkit.org/show_bug.cgi?id=166995
2870
2871         Reviewed by Jer Noble.
2872
2873         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2874         as some people are having trouble building without it.
2875
2876         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2877
2878 2017-01-12  Sam Weinig  <sam@webkit.org>
2879
2880         Add the ability to filter the set of bindings tests you want to run
2881         https://bugs.webkit.org/show_bug.cgi?id=166977
2882
2883         Reviewed by Tim Horton.
2884
2885         Allows doing things like:
2886             run-bindings-tests TestObj* TestCEReactions*
2887         
2888         to run only those tests that match the patterns.
2889
2890         * Scripts/run-bindings-tests:
2891         (main):
2892         Switch to using optparse and pass the remaining args as the filters.
2893
2894         * Scripts/webkitpy/bindings/main.py:
2895         (BindingsTests.__init__):
2896         Store the pattens.
2897
2898         (BindingsTests.test_matches_patterns):
2899         Add helper predicate to determine if a test should be run. When no
2900         patterns are present, all tests should run.
2901
2902         (BindingsTests.run_tests):
2903         Filter tests using the passed in patterns.
2904
2905 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2906
2907         Followup fix after r210503.
2908         https://bugs.webkit.org/show_bug.cgi?id=166887
2909
2910         Reviewed by Alex Christensen.
2911
2912         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2913         duplicated file handle on Windows. This patch fixes the remaining call sites.
2914
2915         * DumpRenderTree/PixelDumpSupport.cpp:
2916         * DumpRenderTree/TestRunner.cpp:
2917         (TestRunner::waitToDumpWatchdogTimerFired):
2918         * DumpRenderTree/TestRunner.h:
2919         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2920         * DumpRenderTree/win/DumpRenderTree.cpp:
2921         * DumpRenderTree/win/DumpRenderTreeWin.h:
2922         * DumpRenderTree/win/TestRunnerWin.cpp:
2923         (TestRunner::setSpellCheckerLoggingEnabled):
2924
2925 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2926
2927         Add committer status for Megan
2928         https://bugs.webkit.org/show_bug.cgi?id=166954
2929
2930         Reviewed by Tim Horton.
2931
2932         Add committer status for Megan Gardner
2933
2934         * Scripts/webkitpy/common/config/contributors.json:
2935
2936 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2937
2938         Unreviewed test fix after r210599.
2939
2940         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2941         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2942
2943 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2944
2945         Unreviewed build fix after r210599.
2946
2947         Add missing files.
2948
2949         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2950         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2951
2952 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2953
2954         File scheme should not allow access of a resource on a different volume.
2955         https://bugs.webkit.org/show_bug.cgi?id=158552
2956         <rdar://problem/15307582>
2957
2958         Reviewed by Alex Christensen.
2959
2960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2961         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2962         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2963
2964 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2965
2966         Unreviewed, rolling out r210571.
2967
2968         This change broke the 32-bit macOS build and caused LayoutTest
2969         failures.
2970
2971         Reverted changeset:
2972
2973         "File scheme should not allow access of a resource on a
2974         different volume."
2975         https://bugs.webkit.org/show_bug.cgi?id=158552
2976         http://trac.webkit.org/changeset/210571
2977
2978 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2979
2980         [GTK] install-dependencies script misses gdb
2981         https://bugs.webkit.org/show_bug.cgi?id=166917
2982
2983         Reviewed by Michael Catanzaro.
2984
2985         gdb is needed for generating the crash logs.
2986
2987         * gtk/install-dependencies:
2988
2989 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2990
2991         [GTK] No way for applications to set notification permissions without waiting for permission request
2992         https://bugs.webkit.org/show_bug.cgi?id=163366
2993
2994         Reviewed by Carlos Garcia Campos.
2995
2996         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2997         (testWebViewNotification):
2998         (setInitialNotificationPermissionsAllowedCallback):
2999         (setInitialNotificationPermissionsDisallowedCallback):
3000         (testWebViewNotificationInitialPermissionAllowed):
3001         (testWebViewNotificationInitialPermissionDisallowed):
3002         (beforeAll):
3003         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3004         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3005         (WebViewTest::WebViewTest):
3006         (WebViewTest::initializeWebView):
3007         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3008
3009 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3010
3011         MobileMiniBrowser tests don't work by default
3012         https://bugs.webkit.org/show_bug.cgi?id=166910
3013
3014         Reviewed by Alex Christensen.
3015
3016         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3017         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3018
3019 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3020
3021         File scheme should not allow access of a resource on a different volume.
3022         https://bugs.webkit.org/show_bug.cgi?id=158552
3023         <rdar://problem/15307582>
3024
3025         Reviewed by Alex Christensen.
3026
3027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3028         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3029         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3030
3031 2017-01-10  Mark Lam  <mark.lam@apple.com>
3032
3033         Reverting run-jsc-stress-tests' $buildType to use string values.
3034         https://bugs.webkit.org/show_bug.cgi?id=166912
3035
3036         Rubber stamped by Filip Pizlo.
3037
3038         This is so that we can test for it in the tests e.g.
3039         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3040
3041         * Scripts/run-jsc-stress-tests:
3042
3043 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3044
3045         Temporarily add back the file removed in r210463 to unbreak internal bots.
3046
3047         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3048
3049 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3050
3051         svn-apply failed to apply a patch (deleting file with svn property)
3052         https://bugs.webkit.org/show_bug.cgi?id=165953
3053
3054         Reviewed by Daniel Bates.
3055
3056         * Scripts/VCSUtils.pm:
3057         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3058         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3059
3060 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3061
3062         Update flakiness dashboard configuration.
3063         https://bugs.webkit.org/show_bug.cgi?id=166869
3064
3065         Reviewed by Alexey Proskuryakov.
3066
3067         * TestResultServer/static-dashboards/builders.jsonp:
3068         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3069
3070 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3071
3072         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3073         https://bugs.webkit.org/show_bug.cgi?id=165232
3074
3075         Unreviewed follow-up patch after r210539 and r210523.
3076
3077         Instead of using that environment variable, the argument
3078         --display-server=xorg should be passed now.
3079
3080         The GTK+ performance bot was the only bot using this, and is
3081         already passing --display-server=xorg after r210539.
3082
3083         * Scripts/webkitpy/port/gtk.py:
3084         (GtkPort._driver_class):
3085
3086 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3087
3088         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3089         https://bugs.webkit.org/show_bug.cgi?id=166872
3090
3091         Reviewed by Michael Catanzaro.
3092
3093         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3094         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3095         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3096         The step RunWebKitTests already has support for it.
3097
3098         * BuildSlaveSupport/build.webkit.org-config/config.json:
3099         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3100         (RunGtkAPITests.start):
3101         (RunAndUploadPerfTests.start):
3102         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3103
3104 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3105
3106         Unreviewed, rolling out r210531.
3107
3108         This change broke the 32-bit macOS build and caused LayoutTest
3109         failures.
3110
3111         Reverted changeset:
3112
3113         "File scheme should not allow access of a resource on a
3114         different volume."
3115         https://bugs.webkit.org/show_bug.cgi?id=158552
3116         http://trac.webkit.org/changeset/210531
3117
3118 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3119
3120         File scheme should not allow access of a resource on a different volume.
3121         https://bugs.webkit.org/show_bug.cgi?id=158552
3122         <rdar://problem/15307582>
3123
3124         Reviewed by Alex Christensen.
3125
3126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3127         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3128         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3129
3130 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3131
3132         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3133         https://bugs.webkit.org/show_bug.cgi?id=165232
3134
3135         Reviewed by Michael Catanzaro.
3136
3137         Add a new WaylandDriver to run the tests in the user current wayland session.
3138
3139         Also merge all the configuration options for selecting the display server inside one
3140         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3141
3142         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3143
3144         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3145         (TestRunner._create_driver):
3146         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3147         (parse_args):
3148         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3149         (PerfTestsRunner._parse_args):
3150         * Scripts/webkitpy/port/gtk.py:
3151         (GtkPort.__init__):
3152         (GtkPort._driver_class):
3153         (GtkPort._search_paths):
3154         * Scripts/webkitpy/port/waylanddriver.py: Added.
3155         (WaylandDriver):
3156         (WaylandDriver.check_driver):
3157         (WaylandDriver._setup_environ_for_test):
3158         (WaylandDriver._start):
3159
3160 2017-01-09  Andy Estes  <aestes@apple.com>
3161
3162         [QuickLook] Add a layout test for webkit.org/b/135651
3163         https://bugs.webkit.org/show_bug.cgi?id=166855
3164
3165         Reviewed by Andreas Kling.
3166
3167         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3168         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3169         errors with code WebKitErrorCannotShowURL.
3170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3171         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3172         not specific to WebKit2 error codes.
3173
3174 2017-01-09  Antoine Quint  <graouts@apple.com>
3175
3176         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3177         https://bugs.webkit.org/show_bug.cgi?id=166837
3178
3179         Reviewed by Alex Christensen.
3180
3181         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3182         the provided value when trying to determine the path to the test file. Failing
3183         that, we use the computed URL or the raw path provided to cover all cases.
3184         
3185         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3186         by applying this patch and seeing the number test failures dramatically reduced
3187         with WK1 due to the option to turn modern media controls off for older media controls
3188         tests.
3189
3190         * DumpRenderTree/DumpRenderTree.h:
3191         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3192         (parseInputLine):
3193         * DumpRenderTree/TestOptions.h:
3194         * DumpRenderTree/TestOptions.mm:
3195         (TestOptions::TestOptions):
3196         * DumpRenderTree/mac/DumpRenderTree.mm:
3197         (runTest):
3198
3199 2017-01-09  Milan Crha  <mcrha@redhat.com>
3200
3201         prepare-ChangeLog: Correct help string for --style option
3202         https://bugs.webkit.org/show_bug.cgi?id=166725
3203
3204         Reviewed by Alexey Proskuryakov.
3205
3206         * Scripts/prepare-ChangeLog:
3207         (main):
3208
3209 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=166839
3212         Add php7 support for macOS.
3213         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3214
3215         Reviewed by Alexey Proskuryakov.
3216
3217         * Scripts/webkitpy/port/base.py:
3218         (Port._is_darwin_php_version_7):
3219         (Port._debian_php_version):
3220         (Port):
3221         (Port._darwin_php_version):
3222         (Port._apache_config_file_name_for_platform):
3223
3224 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3225
3226         [GTK] Should support key and code properties on keyboard events
3227         https://bugs.webkit.org/show_bug.cgi?id=166759
3228
3229         Reviewed by Carlos Garcia Campos.
3230
3231         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3232         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3233         on tests.
3234
3235 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3236
3237         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3238         https://bugs.webkit.org/show_bug.cgi?id=166760
3239
3240         Reviewed by Darin Adler.
3241
3242         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3243         We can work around that by duplicating and redirecting stdout.
3244
3245         * DumpRenderTree/PixelDumpSupport.cpp:
3246         (dumpWebViewAsPixelsAndCompareWithExpected):
3247         (printPNG):
3248         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3249         (logEventProc):
3250         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3251         (DRTDesktopNotificationPresenter::showDesktopNotification):
3252         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3253         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3254         * DumpRenderTree/win/DumpRenderTree.cpp:
3255         (dumpFrameScrollPosition):
3256         (dumpHistoryItem):
3257         (dumpBackForwardList):
3258         (dump):
3259         (runTest):
3260         (main):
3261         * DumpRenderTree/win/DumpRenderTreeWin.h:
3262         * DumpRenderTree/win/EditingDelegate.cpp:
3263         (EditingDelegate::shouldBeginEditingInDOMRange):
3264         (EditingDelegate::shouldEndEditingInDOMRange):
3265         (EditingDelegate::shouldInsertNode):
3266         (EditingDelegate::shouldInsertText):
3267         (EditingDelegate::shouldDeleteDOMRange):
3268         (EditingDelegate::shouldChangeSelectedDOMRange):
3269         (EditingDelegate::shouldApplyStyle):
3270         (EditingDelegate::shouldChangeTypingStyle):
3271         (EditingDelegate::doPlatformCommand):
3272         (EditingDelegate::webViewDidBeginEditing):
3273         (EditingDelegate::webViewDidChange):
3274         (EditingDelegate::webViewDidEndEditing):
3275         (EditingDelegate::webViewDidChangeTypingStyle):
3276         (EditingDelegate::webViewDidChangeSelection):
3277         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3278         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3279         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3280         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3281         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3282         (FrameLoadDelegate::didCommitLoadForFrame):
3283         (FrameLoadDelegate::didReceiveTitle):
3284         (FrameLoadDelegate::didFinishLoadForFrame):
3285         (FrameLoadDelegate::didFailLoadWithError):
3286         (FrameLoadDelegate::willPerformClientRedirectToURL):
3287         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3288         (FrameLoadDelegate::windowScriptObjectAvailable):
3289         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3290         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3291         (FrameLoadDelegate::didDisplayInsecureContent):
3292         (FrameLoadDelegate::didRunInsecureContent):
3293         (FrameLoadDelegate::webViewProgressFinishedNotification):
3294         * DumpRenderTree/win/HistoryDelegate.cpp:
3295         (HistoryDelegate::didNavigateWithNavigationData):
3296         (HistoryDelegate::didPerformClientRedirectFromURL):
3297         (HistoryDelegate::didPerformServerRedirectFromURL):
3298         (HistoryDelegate::updateHistoryTitle):
3299         (HistoryDelegate::populateVisitedLinksForWebView):
3300         * DumpRenderTree/win/PolicyDelegate.cpp:
3301         (PolicyDelegate::decidePolicyForNavigationAction):
3302         (PolicyDelegate::unableToImplementPolicyWithError):
3303         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3304         (ResourceLoadDelegate::willSendRequest):
3305         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3306         (ResourceLoadDelegate::didReceiveResponse):
3307         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3308         (ResourceLoadDelegate::didFailLoadingWithError):
3309         * DumpRenderTree/win/TestRunnerWin.cpp:
3310         (TestRunner::addDisallowedURL):
3311         (TestRunner::originsWithApplicationCache):
3312         (TestRunner::setStorageDatabaseIdleInterval):
3313         (TestRunner::closeIdleLocalStorageDatabases):
3314         (TestRunner::copyDecodedHostName):
3315         (TestRunner::copyEncodedHostName):
3316         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3317         (TestRunner::isGeolocationProviderActive):
3318         (TestRunner::pathToLocalResource):
3319         (TestRunner::setMockDeviceOrientation):
3320         (TestRunner::setMockGeolocationPosition):
3321         (TestRunner::setMockGeolocationPositionUnavailableError):
3322         (TestRunner::setSpatialNavigationEnabled):
3323         (TestRunner::setAutomaticLinkDetectionEnabled):
3324         (TestRunner::isCommandEnabled):
3325         (TestRunner::authenticateSession):
3326         (TestRunner::addChromeInputField):
3327         (TestRunner::removeChromeInputField):
3328         (TestRunner::focusWebView):
3329         (TestRunner::grantWebNotificationPermission):
3330         (TestRunner::denyWebNotificationPermission):
3331         (TestRunner::removeAllWebNotificationPermissions):
3332         (TestRunner::simulateWebNotificationClick):
3333         (TestRunner::imageCountInGeneralPasteboard):
3334         * DumpRenderTree/win/UIDelegate.cpp:
3335         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3336         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3337         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3338         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3339         (UIDelegate::webViewAddMessageToConsole):
3340         (UIDelegate::exceededDatabaseQuota):
3341         (UIDelegate::setStatusText):
3342         (UIDelegate::didPressMissingPluginButton):
3343
3344 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3345
3346         Add a setting to create editable MiniBrowser windows by default
3347         https://bugs.webkit.org/show_bug.cgi?id=166806
3348
3349         Reviewed by Beth Dakin.
3350
3351         * MiniBrowser/mac/AppDelegate.m:
3352         (-[BrowserAppDelegate createBrowserWindowController:]):
3353         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3354         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3355         * MiniBrowser/mac/SettingsController.h:
3356         * MiniBrowser/mac/SettingsController.m:
3357         (-[SettingsController _populateMenu]):
3358         (-[SettingsController validateMenuItem:]):
3359         (-[SettingsController toggleCreateEditorByDefault:]):
3360         (-[SettingsController createEditorByDefault]):
3361         Add a setting and update the key equivalents accordingly.
3362         Also make sure to make the right kind of window on launch.
3363
3364 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3365
3366         Fix the 32-bit build.
3367
3368         * MiniBrowser/mac/BrowserWindowController.h:
3369         * MiniBrowser/mac/BrowserWindowController.m:
3370
3371 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3372
3373         Fix the 32-bit build.
3374
3375         * MiniBrowser/mac/BrowserWindowController.m:
3376
3377 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3378
3379         Make it possible to drop HTML files on the MiniBrowser icon
3380         https://bugs.webkit.org/show_bug.cgi?id=166802
3381
3382         Reviewed by Simon Fraser.
3383
3384         * MiniBrowser/mac/AppDelegate.m:
3385         (-[BrowserAppDelegate application:openFile:]):
3386         * MiniBrowser/mac/Info.plist:
3387         If you're using an editable window, the usual trick of dropping on the
3388         window doesn't work anymore (it makes an <attachment> instead).
3389
3390 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3391
3392         MiniBrowser window gets smaller each time it is instantiated
3393         https://bugs.webkit.org/show_bug.cgi?id=166807
3394
3395         Reviewed by Andy Estes.
3396
3397         * MiniBrowser/mac/BrowserWindowController.m:
3398         (-[BrowserWindowController windowDidLoad]):
3399         * MiniBrowser/mac/BrowserWindow.xib:
3400         Turn on full-window content view support with IB, instead of waiting
3401         until after the views have been loaded. This seems to resolve the
3402         longstanding ever-shrinking-window problem.
3403
3404 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3405
3406         Add indent/outdent items to MiniBrowser's new format menu
3407         https://bugs.webkit.org/show_bug.cgi?id=166805
3408
3409         Reviewed by Dan Bernstein.
3410
3411         * MiniBrowser/mac/MainMenu.xib:
3412
3413 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3414
3415         Add a stock Format menu to MiniBrowser
3416         https://bugs.webkit.org/show_bug.cgi?id=166804
3417
3418         Reviewed by Andy Estes.
3419
3420         * MiniBrowser/mac/MainMenu.xib:
3421         Many of the features automatically work with editable web views.
3422         However, this seems to expose a bug where none of the font-related features
3423         (Cmd-B, for example) work until the first time the font panel is shown,
3424         per process, which will need to be investigated separately.
3425
3426 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3427
3428         Remove unused applicationWillTerminate methods from MiniBrowser
3429         https://bugs.webkit.org/show_bug.cgi?id=166803
3430
3431         Reviewed by Andy Estes.
3432
3433         * MiniBrowser/mac/AppDelegate.m:
3434         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3435         * MiniBrowser/mac/BrowserWindowController.h:
3436         * MiniBrowser/mac/BrowserWindowController.m:
3437         (-[BrowserWindowController applicationTerminating]): Deleted.
3438         * MiniBrowser/mac/WK1BrowserWindowController.m:
3439         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3440         * MiniBrowser/mac/WK2BrowserWindowController.m:
3441         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3442
3443 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3444
3445         Add the ability to create empty contentEditable windows in MiniBrowser
3446         https://bugs.webkit.org/show_bug.cgi?id=166801
3447
3448         Reviewed by Wenson Hsieh.
3449
3450         * MiniBrowser/mac/AppDelegate.h:
3451         * MiniBrowser/mac/AppDelegate.m:
3452         (-[BrowserAppDelegate createBrowserWindowController:]):
3453         (-[BrowserAppDelegate newWindow:]):
3454         (-[BrowserAppDelegate newEditorWindow:]):
3455         (-[BrowserAppDelegate openDocument:]):
3456         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3457         * MiniBrowser/mac/BrowserWindowController.h:
3458         * MiniBrowser/mac/BrowserWindowController.m:
3459         (-[BrowserWindowController loadHTMLString:]):
3460         (-[BrowserWindowController toggleEditable:]):
3461         * MiniBrowser/mac/MainMenu.xib:
3462         * MiniBrowser/mac/WK1BrowserWindowController.m:
3463         (-[WK1BrowserWindowController awakeFromNib]):
3464         (-[WK1BrowserWindowController loadHTMLString:]):
3465         (-[WK1BrowserWindowController validateMenuItem:]):
3466         (-[WK1BrowserWindowController setEditable:]):
3467         (-[WK1BrowserWindowController updateTitle:]):
3468         * MiniBrowser/mac/WK2BrowserWindowController.m:
3469         (-[WK2BrowserWindowController awakeFromNib]):
3470         (-[WK2BrowserWindowController validateMenuItem:]):
3471         (-[WK2BrowserWindowController setEditable:]):
3472         (-[WK2BrowserWindowController updateTitle:]):
3473         (-[WK2BrowserWindowController loadHTMLString:]):
3474         Merge more functionality from WebEditingTester.
3475         Add two menu items for creating empty editable WebKit1/2 windows.
3476         Add a menu item to the Edit menu to toggle editability on any window.
3477
3478 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3479
3480         Implement find-in-page in MiniBrowser
3481         https://bugs.webkit.org/show_bug.cgi?id=166799
3482
3483         Reviewed by Andy Estes.
3484
3485         * MiniBrowser/mac/BrowserWindow.xib:
3486         * MiniBrowser/mac/BrowserWindowController.h:
3487         * MiniBrowser/mac/BrowserWindowController.m:
3488         (-[BrowserWindowController find:]): Deleted.
3489         * MiniBrowser/mac/MainMenu.xib:
3490         * MiniBrowser/mac/WK1BrowserWindowController.m:
3491         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3492         (-[WK1BrowserWindowController find:]): Deleted.
3493         * MiniBrowser/mac/WK2BrowserWindowController.m:
3494         (-[WK2BrowserWindowController awakeFromNib]):
3495         (-[WK2BrowserWindowController dealloc]):
3496         (-[WK2BrowserWindowController validateMenuItem:]):
3497         (-[WK2BrowserWindowController performTextFinderAction:]):
3498         (-[WK2BrowserWindowController findBarView]):
3499         (-[WK2BrowserWindowController setFindBarView:]):
3500         (-[WK2BrowserWindowController isFindBarVisible]):
3501         (-[WK2BrowserWindowController setFindBarVisible:]):
3502         (-[WK2BrowserWindowController contentView]):
3503         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3504         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3505         (-[WK2BrowserWindowController find:]): Deleted.
3506         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3507         protocol. At first glance, it's pretty broken, but vaguely works.
3508
3509 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3510
3511         Share the implementation of MiniBrowser view hiding functionality
3512         https://bugs.webkit.org/show_bug.cgi?id=166800
3513
3514         Reviewed by Andy Estes.
3515
3516         * MiniBrowser/mac/BrowserWindowController.m:
3517         (-[BrowserWindowController showHideWebView:]):
3518         (-[BrowserWindowController removeReinsertWebView:]):
3519         * MiniBrowser/mac/WK1BrowserWindowController.m:
3520         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3521         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3522         * MiniBrowser/mac/WK2BrowserWindowController.m:
3523         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3524         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3525         Move the implementation of these two things to the shared superclass,
3526         since they don't depend on WebKit-specific things.
3527         Also, there was no reason to retain the (WK)WebView while it was unparented,
3528         as the BrowserWindowController maintains a reference the entire time.
3529
3530 2017-01-06  Andy Estes  <aestes@apple.com>
3531
3532         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3533         https://bugs.webkit.org/show_bug.cgi?id=166789
3534
3535         Reviewed by Alex Christensen.
3536
3537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3538         * DumpRenderTree/PlatformMac.cmake:
3539         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3540         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3541         * DumpRenderTree/mac/DumpRenderTree.mm:
3542         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3543         createXMLStringFromWebArchiveData().
3544         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3545         * WebKitTestRunner/Configurations/Base.xcconfig:
3546         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3548         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3549         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3550         createXMLStringFromWebArchiveData().
3551         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3552         * WebKitTestRunner/PlatformMac.cmake:
3553         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3554         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3555
3556 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3557
3558         Minor cleanups to IndentOutdentCommand and related code
3559         https://bugs.webkit.org/show_bug.cgi?id=166791
3560
3561         Reviewed by Simon Fraser.
3562
3563         * WebEditingTester/EditingOperations.m:
3564         (editingOperations):
3565         Add the outdent operation to WebEditingTester.
3566
3567 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3568
3569         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3570         https://bugs.webkit.org/show_bug.cgi?id=166785
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3575         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3576
3577 2017-01-06  Antoine Quint  <graouts@apple.com>
3578
3579         Support webkit-test-runner key-value pairs in http tests
3580         https://bugs.webkit.org/show_bug.cgi?id=149812
3581
3582         Reviewed by Alex Christensen.
3583
3584         We pass the absolute path for a test through to WKTR so that we can parse
3585         tests that are running as URLs for webkit-test-runner options.
3586
3587         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3588         (parseInputLine):
3589
3590         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3591
3592         * Scripts/webkitpy/port/driver.py:
3593         (Driver._command_from_driver_input):
3594
3595         Pass the absolute path to the file through the CLI.
3596
3597         * WebKitTestRunner/TestController.cpp:
3598         (WTR::updateTestOptionsFromTestHeader):
3599         (WTR::TestController::testOptionsForTest):
3600         (WTR::parseInputLine):
3601         (WTR::TestController::runTest):
3602         * WebKitTestRunner/TestController.h:
3603
3604 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3605
3606         Warning about unconnectable outlets when opening a MiniBrowser window
3607         https://bugs.webkit.org/show_bug.cgi?id=166756
3608
3609         Reviewed by Dan Bernstein.
3610
3611         * MiniBrowser/mac/BrowserWindow.xib:
3612         When launching MiniBrowser, it says:
3613         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3614             (MBToolbarItem): missing setter or instance variable
3615         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3616             (NSButtonCell): missing setter or instance variable.
3617
3618         It looks like someone added the connection from the share button
3619         to the BrowserWindowController three times; only one of the connections
3620         is valid. Remove the other two.
3621
3622 2017-01-05  Keith Rollin  <krollin@apple.com>
3623
3624         Add WebCore::URL::protocolHostAndPort
3625         https://bugs.webkit.org/show_bug.cgi?id=166426
3626
3627         Reviewed by Alex Christensen.
3628
3629         Add test for protocolHostAndPort.
3630
3631         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3632         (TestWebKitAPI::TEST_F):
3633
3634 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3635
3636         [Win] Archive test result is failing.
3637         https://bugs.webkit.org/show_bug.cgi?id=166720
3638
3639         Reviewed by Alex Christensen.
3640
3641         Deleting the layout test result folder is sometimes failing
3642         on Windows. This is not a critical error.
3643
3644         * BuildSlaveSupport/test-result-archive:
3645         (archiveTestResults):
3646
3647 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3648
3649         [GTK] Minibrowser: Add printing support
3650         https://bugs.webkit.org/show_bug.cgi?id=165298
3651
3652         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3653         an error during the print, it's printed on the console.
3654
3655         Reviewed by Michael Catanzaro.
3656
3657         * MiniBrowser/gtk/BrowserWindow.c:
3658         (webKitPrintOperationFailedCallback):
3659         (printPage):
3660         (browser_window_init):
3661
3662 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3663
3664         [css-grid] Fix crash clamping grid lines
3665         https://bugs.webkit.org/show_bug.cgi?id=166637
3666
3667         Reviewed by Darin Adler.
3668
3669         Creates new unit test to verify that the maximum tracks limit
3670         is used in GridPosition too.
3671
3672         * TestWebKitAPI/PlatformEfl.cmake:
3673         * TestWebKitAPI/PlatformGTK.cmake:
3674         * TestWebKitAPI/PlatformWin.cmake:
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3676         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3677         (TestWebKitAPI::TEST):
3678
3679 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3680
3681         Move editing history scripts to WebCore PrivateHeaders
3682         https://bugs.webkit.org/show_bug.cgi?id=166709
3683         <rdar://problem/29876612>
3684
3685         Reviewed by Dan Bernstein.
3686
3687         Update references to editing script files in WebCore that were moved.
3688
3689         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3690
3691 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3692
3693         Unreviewed, build fix after r210313 part 2
3694         https://bugs.webkit.org/show_bug.cgi?id=166676
3695
3696         Add 'U' suffix.
3697
3698         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3699         (TestWebKitAPI::TEST):
3700         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3701         (TestWebKitAPI::TEST):
3702
3703 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3704
3705         Limit thread name appropriately
3706         https://bugs.webkit.org/show_bug.cgi?id=166676
3707
3708         Reviewed by Sam Weinig.
3709
3710         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3711         (TestWebKitAPI::TEST):
3712         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3713         (TestWebKitAPI::TEST):
3714
3715 2017-01-04  Andy Estes  <aestes@apple.com>
3716
3717         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3718         https://bugs.webkit.org/show_bug.cgi?id=166696
3719
3720         Reviewed by Tim Horton.
3721
3722         * TestWebKitAPI/PlatformGTK.cmake:
3723         * TestWebKitAPI/PlatformWin.cmake:
3724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3725         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3726         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3727         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3728         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3729         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3730         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3731
3732 2017-01-03  Brian Burg  <bburg@apple.com>
3733
3734         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3735         https://bugs.webkit.org/show_bug.cgi?id=166003
3736         <rdar://problem/28718990>
3737
3738         Reviewed by Joseph Pecoraro.
3739
3740         Teach run-inspector-generator-tests to generate test output using the platform name
3741         derived from the directory that the test is in. For example, tests in the /generic/
3742         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3743
3744         * Scripts/webkitpy/inspector/main.py:
3745         (InspectorGeneratorTests.generate_from_json):
3746         (InspectorGeneratorTests.run_tests):
3747         (InspectorGeneratorTests.main):
3748
3749 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3750
3751         Unreviewed cmake buildfix after r210266.
3752
3753         * DumpRenderTree/PlatformMac.cmake:
3754
3755 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3756
3757         Provide a setting for clients to always prefer low-power WebGL
3758         https://bugs.webkit.org/show_bug.cgi?id=166675
3759         <rdar://problem/29834093>
3760
3761         Reviewed by Dan Bernstein.
3762
3763         * MiniBrowser/mac/Info.plist:
3764         Have MiniBrowser claim to be a modern app that supports
3765         automatic graphics switching. WebKit needs to support automatic
3766         graphics switching, so our test app might as well. Without this
3767         Info.plist parameter, this change has no effect, and bringing up
3768         a WebGL context still brings up the discrete GPU (also true of the
3769         existing web-exposed preferLowPowerToHighPerformance API).
3770
3771 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3772
3773         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3774         https://bugs.webkit.org/show_bug.cgi?id=166645
3775
3776         Reviewed by Carlos Garcia Campos.
3777
3778         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3779         (TestWebKitAPI::TEST):
3780
3781 2017-01-03  Andy Estes  <aestes@apple.com>
3782
3783         Place all the Cocoa WebCore API tests in the same directory
3784         https://bugs.webkit.org/show_bug.cgi?id=166673
3785
3786         Reviewed by Michael Catanzaro.
3787
3788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3789         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3790         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3791         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3792
3793 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3794
3795         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3796         https://bugs.webkit.org/show_bug.cgi?id=166450
3797         <rdar://problem/29447824>
3798
3799         Reviewed by Darin Adler.
3800
3801         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3802         * DumpRenderTree/TestRunner.cpp:
3803         (TestRunner::staticFunctions):
3804         * DumpRenderTree/mac/TestRunnerMac.mm:
3805         (setSpellCheckerLoggingEnabledCallback):
3806         * DumpRenderTree/win/TestRunnerWin.cpp:
3807         (setSpellCheckerLoggingEnabledCallback):
3808         * DumpRenderTree/mac/DumpRenderTree.mm:
3809         (resetWebViewToConsistentStateBeforeTesting):
3810         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3811         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3812         (stringForCorrectionResponse):
3813         (drt_NSSpellChecker_recordResponseToCorrection):
3814         (swizzleNSSpellCheckerMethodsIfNeeded):
3815         (setSpellCheckerLoggingEnabled):
3816         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3817         set to true, logs to stdout (which ends up in the test result) whenever
3818         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3819         is called, and then calls the original method. It is reset to false between tests.
3820
3821 2017-01-03  Sam Weinig  <sam@webkit.org>
3822
3823         Make WTF::Expected support Ref template parameters
3824         https://bugs.webkit.org/show_bug.cgi?id=166662
3825
3826         Reviewed by Alex Christensen.
3827
3828         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3829         (TestWebKitAPI::TEST):
3830         Add tests for using Ref with Expected.
3831
3832 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3833
3834         [GTK] Expose WebKitSecurityOrigin API
3835         https://bugs.webkit.org/show_bug.cgi?id=166632
3836
3837         Reviewed by Carlos Garcia Campos.
3838
3839         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3840         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3841         (testSecurityOriginBasicConstructor):
3842         (testSecurityOriginURIConstructor):
3843         (testSecurityOriginDefaultPort):
3844         (testSecurityOriginFileURI):
3845         (testSecurityOriginDataURI):
3846         (beforeAll):
3847         (afterAll):
3848
3849 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3850
3851         [GTK] HTTP auth layout tests are flaky
3852         https://bugs.webkit.org/show_bug.cgi?id=158919
3853
3854         Reviewed by Michael Catanzaro.
3855
3856         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3857         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3858         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3859         missing valac in the bots.
3860
3861 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3862
3863         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3864         https://bugs.webkit.org/show_bug.cgi?id=165797
3865
3866         Reviewed by Michael Catanzaro.
3867
3868         Move directory ruleset after all exclude rules of Source rulset.
3869
3870         * gtk/manifest.txt.in:
3871
3872 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3873
3874         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3875         https://bugs.webkit.org/show_bug.cgi?id=166636
3876
3877         Reviewed by Darin Adler.
3878
3879         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3880         (TestWebKitAPI::TEST):
3881
3882 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3883
3884         [GTK] WebCore/CSSParser unit test is not being built
3885         https://bugs.webkit.org/show_bug.cgi?id=166492
3886
3887         Reviewed by Michael Catanzaro.
3888
3889         This test was introduced in r175930, but we were not building
3890         it on GTK+ port since r176015.
3891         This patch marks the test to be built again on GTK+.
3892         JFTR, the test is passing right now.
3893
3894         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3895         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3896
3897 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3898
3899         AX: Expose block quote level to iOS API
3900         https://bugs.webkit.org/show_bug.cgi?id=166629
3901         <rdar://problem/29834793>
3902
3903         Reviewed by Darin Adler.
3904
3905         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3906         (AccessibilityUIElement::numberAttributeValue):
3907         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3908         (WTR::AccessibilityUIElement::numberAttributeValue):
3909
3910 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3911
3912         SecurityOrigin::create triplet constructor does not canonicalize port
3913         https://bugs.webkit.org/show_bug.cgi?id=166624
3914
3915         Reviewed by Daniel Bates.
3916
3917         * TestWebKitAPI/PlatformGTK.cmake:
3918         * TestWebKitAPI/PlatformWin.cmake:
3919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3920         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3921         (TestWebKitAPI::SecurityOriginTest::SetUp):
3922         (TestWebKitAPI::TEST_F):
3923
3924 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3925
3926         [GTK] Improve user agent construction
3927         https://bugs.webkit.org/show_bug.cgi?id=142074
3928
3929         Reviewed by Carlos Garcia Campos.
3930
3931         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3932         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3933         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3934         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3935         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3936         (TestWebKitAPI::TEST):
3937
3938 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3939
3940         [GTK] Improve user agent construction
3941         https://bugs.webkit.org/show_bug.cgi?id=142074
3942
3943         Reviewed by Carlos Garcia Campos.
3944
3945         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3946         (TestWebKitAPI::TEST):
3947
3948 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3949
3950         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3951         https://bugs.webkit.org/show_bug.cgi?id=166472
3952         rdar://problem/29675551
3953
3954         Reviewed by Tim Horton.
3955
3956         These changes are necessary to allow the mouse to leave the WTR window while
3957         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3958         (which DRT does); we'd always go through mouseMoved, which hits an early return
3959         in WebViewImpl::mouseMoved() when the point is outside the view.
3960
3961         * WebKitTestRunner/mac/EventSenderProxy.mm:
3962         (WTR::EventSenderProxy::mouseMoveTo):
3963
3964 2016-12-23  Andy Estes  <aestes@apple.com>
3965
3966         [iOS] Fix some crashing webarchive tests
3967         https://bugs.webkit.org/show_bug.cgi?id=166470
3968
3969         Reviewed by Andreas Kling.
3970
3971         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3972         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3973         so this change uses that on both platforms.
3974
3975         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3976         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3977         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3978         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3979         * WebKitTestRunner/PlatformMac.cmake:
3980         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3981         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3982
3983 2016-12-22  Saam Barati  <sbarati@apple.com>
3984
3985         WebAssembly: Silence the output of the spec-tests
3986         https://bugs.webkit.org/show_bug.cgi?id=166417
3987
3988         Reviewed by Mark Lam.
3989
3990         * Scripts/run-jsc-stress-tests:
3991
3992 2016-12-22  Zhuo Li  <zachli@apple.com>
3993
3994         [Cocoa] SPI for setloadsImagesAutomatically.
3995         https://bugs.webkit.org/show_bug.cgi?id=166401.
3996
3997         Reviewed by Darin Adler.
3998
3999         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
4000         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
4001         _loadsImagesAutomatically returns YES.
4002
4003 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4004
4005         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
4006         https://bugs.webkit.org/show_bug.cgi?id=161328
4007         <rdar://problem/28475977>
4008
4009         Reviewed by Darin Adler.
4010
4011         Running a test that scales the viewport and listens to a didEndZooming callback (such as
4012         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
4013         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
4014         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
4015         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
4016         load, should prevent this from happening, but from reading documentation and code inspection, this is not
4017         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
4018         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
4019         we finish running a test and before we load the next test.
4020
4021         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
4022         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
4023         previous test started zooming and then finished before zooming completed. Since this happens before the next
4024         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
4025
4026         * WebKitTestRunner/ios/TestControllerIOS.mm:
4027         (WTR::TestController::platformResetStateToConsistentValues):
4028
4029 2016-12-22  Jer Noble  <jer.noble@apple.com>
4030
4031         Muted media element playback should not interrupt other audio playback
4032         https://bugs.webkit.org/show_bug.cgi?id=166347
4033
4034         Reviewed by Eric Carlson.
4035
4036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4037         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
4038         (TestWebKitAPI::TEST):
4039         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
4040
4041 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
4042
4043         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
4044         https://bugs.webkit.org/show_bug.cgi?id=166346
4045
4046         Reviewed by Carlos Garcia Campos.
4047
4048         Enable WebRTC by default to simplify testing.
4049
4050         * MiniBrowser/gtk/main.c:
4051         (main):
4052
4053 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
4054
4055         REGRESSION: API test failure: WKWebView.LocalStorageClear
4056         https://bugs.webkit.org/show_bug.cgi?id=166032
4057         <rdar://problem/29758423>
4058
4059         Reviewed by Simon Fraser.
4060
4061         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
4062         to ensure that the view is destroyed before the callback fires.
4063
4064         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
4065         (TEST):
4066
4067 2016-12-21  Saam Barati  <sbarati@apple.com>
4068
4069         WebAssembly: Import spec tests
4070         https://bugs.webkit.org/show_bug.cgi?id=166395
4071
4072         Rubber stamped by Keith Miller.
4073
4074         * Scripts/run-jsc-stress-tests:
4075
4076 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
4077
4078         REGRESSION: API test failure: _WKDownload.OriginatingWebView
4079         https://bugs.webkit.org/show_bug.cgi?id=166033
4080         <rdar://problem/29758428>
4081
4082         Reviewed by Simon Fraser.
4083
4084         Add an @autoreleasepool around the code that allocates the WKWebView, 
4085         so that it can be destroyed by removing the last reference in _downloadDidStart.
4086
4087         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4088         (TEST):
4089
4090 2016-12-21  Daniel Bates  <dabates@apple.com>
4091
4092         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
4093         https://bugs.webkit.org/show_bug.cgi?id=166356
4094
4095         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
4096         as a means to allow a test to explicit allow an embedding client to open a new windows
4097         such that the default behavior is for the embedding client to forbid such an action.
4098         The test plugins/get-url-with-blank-target.html assumes this default behavior though
4099         it is currently skipped on WebKit2 because questions were raised in the patch for
4100         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
4101         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
4102         this test.
4103
4104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4105         (WTR::TestRunner::setCanOpenWindows):
4106
4107 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
4108
4109         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
4110         https://bugs.webkit.org/show_bug.cgi?id=166031
4111
4112         Reviewed by Tim Horton.
4113         
4114         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
4115         to ensure that the view is destroyed before the callback fires.
4116
4117         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
4118
4119 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
4120
4121         Throw Exception when test doesn't clean up HID Events properly
4122         https://bugs.webkit.org/show_bug.cgi?id=166271
4123
4124         Reviewed by Simon Fraser.
4125
4126         Add in a check when UIScriptController is deleted to make sure that the HID event
4127         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
4128         the program to crash without any good information. Crashes are race-y, and will still
4129         happen with malformed test, but the information will be much more helpful. 
4130
4131         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4132         (WTR::UIScriptController::checkForClean):
4133         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
4134         (UIScriptContext::~UIScriptContext):
4135         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4136         (WTR::UIScriptController::checkForClean):
4137         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4138         * WebKitTestRunner/ios/HIDEventGenerator.h:
4139         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4140         (-[HIDEventGenerator checkHIDCallbacksClear]):
4141         * WebKitTestRunner/ios/TestControllerIOS.mm:
4142         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4143         (WTR::UIScriptController::checkForClean):
4144
4145 2016-12-20  Andy Estes  <aestes@apple.com>
4146
4147         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
4148         https://bugs.webkit.org/show_bug.cgi?id=165992
4149
4150         Reviewed by Brady Eidson.
4151
4152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4153         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
4154         (expectException):
4155         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4156         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4157         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4158         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
4159         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
4160         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
4161         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
4162         (TEST):
4163         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
4164
4165 2016-12-20  Dean Jackson  <dino@apple.com>
4166
4167         Remove INDIE_UI
4168         https://bugs.webkit.org/show_bug.cgi?id=165881
4169         <rdar://problem/29672532>
4170
4171         Reviewed by Simon Fraser.
4172
4173         The Indie UI work has been discontinued.
4174
4175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4176
4177 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4178
4179         [ES6] Enable ES6 Modules
4180         https://bugs.webkit.org/show_bug.cgi?id=165849
4181
4182         Reviewed by Geoffrey Garen.
4183
4184         * DumpRenderTree/mac/DumpRenderTree.mm:
4185         (resetWebPreferencesToConsistentValues):
4186         * DumpRenderTree/win/DumpRenderTree.cpp:
4187         (resetWebPreferencesToConsistentValues):
4188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4189         (WTR::InjectedBundle::beginTesting):
4190         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4191         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
4192         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4193
4194 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
4195
4196         Repurpose bots and clean up dashboard.
4197         https://bugs.webkit.org/show_bug.cgi?id=166045
4198
4199         Reviewed by Lucas Forschler.
4200
4201         * BuildSlaveSupport/build.webkit.org-config/config.json:
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4203         (BubbleQueueServer):
4204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4206         (WebKitBuildbot):
4207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4208         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
4209
4210 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4211
4212         [CMake] TestWebKitAPIBase links to itself
4213         https://bugs.webkit.org/show_bug.cgi?id=165985
4214
4215         Reviewed by Alex Christensen.
4216
4217         Fix CMake warning about a target linking to itself, which makes no sense.
4218
4219         * TestWebKitAPI/CMakeLists.txt:
4220
4221 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4222
4223         [GTK] GtkDoc build should be quieter
4224         https://bugs.webkit.org/show_bug.cgi?id=165994
4225
4226         Reviewed by Carlos Garcia Campos.
4227
4228         Make it not print by default.
4229
4230         * gtk/generate-gtkdoc:
4231         (get_generator_for_config):
4232         (generate_doc):
4233         * gtk/gtkdoc.py:
4234         (GTKDoc._run_command):
4235         (GTKDoc._copy_doc_files_to_output_dir):
4236
4237 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
4238
4239         Expose a way for MiniBrowser to simulate header and footer banners
4240         https://bugs.webkit.org/show_bug.cgi?id=166005
4241
4242         Reviewed by Wenson Hsieh.
4243         
4244         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
4245         banners. This only works in WebKit2.
4246         
4247         We need to reset these on each navigation, since newly created FrameViews
4248         don't re-fetch the header and footer height stored on Page.
4249         
4250         Also fix the signature of webView:didFinishNavigation: to follow API changes,
4251         as well as fixing webViewWebContentProcessDidTerminate:
4252
4253         * MiniBrowser/mac/SettingsController.h:
4254         * MiniBrowser/mac/SettingsController.m:
4255         (-[SettingsController _populateMenu]):
4256         (-[SettingsController validateMenuItem:]):
4257         (-[SettingsController toggleReserveSpaceForBanners:]):
4258         (-[SettingsController isSpaceReservedForBanners]):
4259         * MiniBrowser/mac/WK2BrowserWindowController.m:
4260         (-[WK2BrowserWindowController didChangeSettings]):
4261         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
4262         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
4263         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
4264         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
4265
4266 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
4267
4268         Fix iOS test results after r209967.
4269         
4270         Subtracting out the status bar height was erroneously happening for all tests,
4271         not just for flexible viewport tests.
4272         
4273         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
4274
4275         * WebKitTestRunner/PlatformWebView.h:
4276         * WebKitTestRunner/TestController.cpp:
4277         (WTR::TestController::resetStateToConsistentValues):
4278         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4279         (WTR::PlatformWebView::resizeTo):
4280         (WTR::PlatformWebView::setWindowFrame):
4281         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4282         (WTR::PlatformWebView::resizeTo):
4283         (WTR::PlatformWebView::setWindowFrame):
4284         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4285         (WTR::PlatformWebView::resizeTo):
4286         (WTR::PlatformWebView::setWindowFrame):
4287         * WebKitTestRunner/ios/TestControllerIOS.mm:
4288         (WTR::TestController::platformConfigureViewForTest):
4289         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4290         (WTR::PlatformWebView::resizeTo):
4291         (WTR::PlatformWebView::setWindowFrame):
4292
4293 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
4294
4295         [EFL] bump EFL version to 1.18.4
4296         https://bugs.webkit.org/show_bug.cgi?id=166004
4297
4298         Reviewed by Gyuyoung Kim.
4299
4300         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
4301
4302 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4303
4304         Visual viewports: bottom fixed elements disappear behind the keyboard
4305         https://bugs.webkit.org/show_bug.cgi?id=165983
4306         <rdar://problem/29409852>
4307
4308         Reviewed by Simon Fraser.
4309
4310         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4311         the keyboard when it is up.
4312
4313         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4314         (WTR::UIScriptController::inputViewBounds):
4315         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4316         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4317       &nb