run-webkit-tests: Upload test results (new results database)
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2
3         run-webkit-tests: Upload test results (new results database)
4         https://bugs.webkit.org/show_bug.cgi?id=196577
5         <rdar://problem/34841155>
6
7         Reviewed by Lucas Forschler.
8
9         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10         (Manager.run): Upload results after each device shard, since the configuration will be
11         different for each device.
12         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
13         uploaded to a results database.
14         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
16
17 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
18
19         -apple-trailing-word is needed for browser detection
20         https://bugs.webkit.org/show_bug.cgi?id=196575
21
22         Unreviewed.
23
24         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25
26 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
27
28         [CMake][WTF] Mirror XCode header directories
29         https://bugs.webkit.org/show_bug.cgi?id=191662
30
31         Reviewed by Konstantin Tokarev.
32
33         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
34         builds.
35
36         * CMakeLists.txt:
37         * DumpRenderTree/CMakeLists.txt:
38         * DumpRenderTree/PlatformWin.cmake:
39         * MiniBrowser/win/CMakeLists.txt:
40         * TestWebKitAPI/CMakeLists.txt:
41         * TestWebKitAPI/PlatformWin.cmake:
42         * WebKitTestRunner/PlatformGTK.cmake:
43         * WebKitTestRunner/PlatformWin.cmake:
44
45 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
46
47         [ews-app] Status bubble should not display certain infrastructure status messages
48         https://bugs.webkit.org/show_bug.cgi?id=196550
49
50         Reviewed by Lucas Forschler.
51
52         Do not display the steps which are un-needed for end-user. This information is still avaiable
53         if the user click on the bubble and look at the Buildbot build.
54         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
55         (StatusBubble._steps_messages):
56         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
57
58 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
59
60         [ews-build] Use https for sending data to ews-app
61         https://bugs.webkit.org/show_bug.cgi?id=196492
62
63         Reviewed by Lucas Forschler.
64
65         * BuildSlaveSupport/ews-build/events.py:
66
67 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
68
69         Remove support for -apple-trailing-word
70         https://bugs.webkit.org/show_bug.cgi?id=196525
71
72         Reviewed by Zalan Bujtas.
73
74         This CSS property is nonstandard and not used.
75
76         * Scripts/webkitperl/FeatureList.pm:
77         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
78
79 2019-04-03  Youenn Fablet  <youenn@apple.com>
80
81         Add a test for DOMCache on multiple browsing in case of private browsing
82         https://bugs.webkit.org/show_bug.cgi?id=196524
83
84         Reviewed by Alex Christensen.
85
86         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
87         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
88
89 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
90
91         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
92         https://bugs.webkit.org/show_bug.cgi?id=196540
93
94         Reviewed by Aakash Jain.
95
96         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
97
98 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
99
100         Add plumbing for a compatibility mode preference in WebKit
101         https://bugs.webkit.org/show_bug.cgi?id=196005
102
103         Reviewed by Tim Horton.
104
105         Add new API tests.
106
107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
108         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
109
110 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
111
112         [WPE][GTK] Update libsrtp dependency package for Debian
113         https://bugs.webkit.org/show_bug.cgi?id=196528
114
115         Reviewed by Frédéric Wang.
116
117         * gtk/install-dependencies:
118         * wpe/install-dependencies:
119
120 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
121
122         [WK2] Add support for Window's beforeprint / afterprint events
123         https://bugs.webkit.org/show_bug.cgi?id=196478
124         <rdar://problem/49535124>
125
126         Unreviewed build fix for MSVC.
127
128         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
129
130         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
131
132         * WebKitTestRunner/TestController.cpp:
133         (WTR::printFrame): Use int and float literals.
134
135 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
136
137         [ews-build] Reassign bots to queues
138
139         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
140
141 2019-04-02  Chris Dumez  <cdumez@apple.com>
142
143         [WK2] Add support for Window's beforeprint / afterprint events
144         https://bugs.webkit.org/show_bug.cgi?id=196478
145
146         Reviewed by Alex Christensen.
147
148         Add minimal implementation for printFrame in WebKitTestRunner.
149
150         * WebKitTestRunner/TestController.cpp:
151         (WTR::printFrame):
152         (WTR::TestController::createOtherPage):
153         (WTR::TestController::createWebViewWithOptions):
154
155 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
158         https://bugs.webkit.org/show_bug.cgi?id=196491
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
163
164 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
165
166         [ews-build] Configure buildbot try credentials in environment variables
167         https://bugs.webkit.org/show_bug.cgi?id=196501
168
169         Reviewed by Lucas Forschler.
170
171         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
172         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
173         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
174
175 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
176
177         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
178         https://bugs.webkit.org/show_bug.cgi?id=196496
179         <rdar://problem/49521634>
180
181         Reviewed by Chris Dumez.
182
183         Add new API tests (see WebKit ChangeLog for more detail).
184
185         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
186         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
187         (TEST):
188
189 2019-04-02  David Kilzer  <ddkilzer@apple.com>
190
191         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
192         <https://webkit.org/b/196499>
193
194         Reviewed by Alexey Proskuryakov.
195
196         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
197         ENABLE_ADDRESS_SANITIZER.
198
199 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
200
201         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
202         https://bugs.webkit.org/show_bug.cgi?id=182757
203
204         Reviewed by Don Olmstead.
205
206         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
207         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
208
209 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
210
211         run-api-tests: Upload test results
212         https://bugs.webkit.org/show_bug.cgi?id=196323
213         <rdar://problem/49356714>
214
215         Reviewed by Lucas Forschler.
216
217         * Scripts/webkitpy/api_tests/manager.py:
218         (Manager):
219         (Manager.run): Upload results to a results database.
220         * Scripts/webkitpy/api_tests/run_api_tests.py:
221         (parse_args): Add upload arguments.
222         * Scripts/webkitpy/port/base.py:
223         (Port):
224         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
225         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
226         with commits from any other associated repositories.
227         * Scripts/webkitpy/port/device.py:
228         (Device):
229         (Device.build_version): Access build_versoin of underlying platform device.
230         * Scripts/webkitpy/port/ios_simulator_unittest.py:
231         (IOSSimulatorTest):
232         (IOSSimulatorTest.test_configuration_for_upload):
233         * Scripts/webkitpy/port/device_port.py:
234         (DevicePort):
235         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
236         the same as the machine uploading results.
237         * Scripts/webkitpy/port/mac.py:
238         (MacPort):
239         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
240         * Scripts/webkitpy/port/mac_unittest.py:
241         (MacTest):
242         (MacTest.test_configuration_for_upload):
243         * Scripts/webkitpy/xcode/simulated_device.py:
244         (SimulatedDeviceManager._create_device_with_runtime):
245         (SimulatedDevice.__init__): Create simulated device with a build_version.
246         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
247         (test_existing_simulator):
248
249 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
250
251         Remove extra newline characters (Follow-up fix to r243707)
252
253         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
254
255 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
256
257         [ews-app] Use API_KEY to accept results data
258         https://bugs.webkit.org/show_bug.cgi?id=196461
259
260         Reviewed by Dewei Zhu.
261
262         * BuildSlaveSupport/ews-app/ews/views/results.py:
263         (Results.post): Validate EWS_API_KEY before accepting any data.
264         * BuildSlaveSupport/ews-build/events.py:
265         (Events.sendData): Send EWS_API_KEY if available along with event data.
266
267 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
268
269         Unable to copy and paste a PDF from Notes into Mail compose body
270         https://bugs.webkit.org/show_bug.cgi?id=196442
271         <rdar://problem/48573098>
272
273         Reviewed by Tim Horton.
274
275         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
276         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
277         to be specified on the item providers.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
280         (TestWebKitAPI::mapItemForTesting):
281         (TestWebKitAPI::contactItemForTesting):
282
283 2019-04-01  Tim Horton  <timothy_horton@apple.com>
284
285         Make UIWKDocumentContext rects per-character instead of per-word
286         https://bugs.webkit.org/show_bug.cgi?id=196459
287
288         Reviewed by Wenson Hsieh.
289
290         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
291         (TEST):
292         Adjust test results due to switching to per-character rects.
293
294 2019-04-01  Chris Dumez  <cdumez@apple.com>
295
296         UIProcess crash when a prewarmed process is terminated
297         https://bugs.webkit.org/show_bug.cgi?id=196451
298         <rdar://problem/49245471>
299
300         Reviewed by Geoffrey Garen.
301
302         Add API test coverage.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
305         (TEST):
306
307 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
308
309         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
310         https://bugs.webkit.org/show_bug.cgi?id=196449
311
312         Reviewed by Lucas Forschler.
313
314         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
315         (StatusBubble.get_os_details): Method to get OS and Xcode details.
316         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
317         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
318
319 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
320
321         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
322         https://bugs.webkit.org/show_bug.cgi?id=196444
323
324         Reviewed by Lucas Forschler.
325
326         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
327
328 2019-04-01  Alex Christensen  <achristensen@webkit.org>
329
330         Add SPI to canonicalize NSURLs with WTF::URL
331         https://bugs.webkit.org/show_bug.cgi?id=196415
332         <rdar://problem/44980271>
333
334         Reviewed by Darin Adler.
335
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
337         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
338         (TestWebKitAPI::TEST):
339
340 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
341
342         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
343         https://bugs.webkit.org/show_bug.cgi?id=196441
344
345         Reviewed by Carlos Garcia Campos.
346
347         Don't cache the wpe_view_backend object that might not exist yet at the
348         time of EventSenderProxy constructor invocation, but instead retrieve
349         that object whenever it's required for event dispatching. This should
350         avoid crashes in this constructor now that it's invoked before any
351         PlatformWindow has been set up (as changed in r243496).
352
353         * WebKitTestRunner/EventSenderProxy.h:
354         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
355         (WTR::viewBackend):
356         (WTR::EventSenderProxy::EventSenderProxy):
357         (WTR::EventSenderProxy::mouseDown):
358         (WTR::EventSenderProxy::mouseUp):
359         (WTR::EventSenderProxy::mouseMoveTo):
360         (WTR::EventSenderProxy::mouseScrollBy):
361         (WTR::EventSenderProxy::keyDown):
362         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
363
364 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
365
366         [Win][WebKit] MiniBrowser should support high DPI display
367         https://bugs.webkit.org/show_bug.cgi?id=196391
368
369         Reviewed by Alex Christensen.
370
371         * MiniBrowser/win/WebKitBrowserWindow.cpp:
372         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
373         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
374         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
375
376 2019-03-31  Sam Weinig  <weinig@apple.com>
377
378         Remove more i386 specific configurations
379         https://bugs.webkit.org/show_bug.cgi?id=196430
380
381         Reviewed by Alexey Proskuryakov.
382
383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
384         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
385
386 2019-03-31  Andy Estes  <aestes@apple.com>
387
388         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
389         https://bugs.webkit.org/show_bug.cgi?id=196433
390         <rdar://problem/49293305>
391
392         Reviewed by Tim Horton.
393
394         Enhanced API test coverage to include all navigation response policy decisions in both
395         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
401         (readFile):
402         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
403         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
404         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
405         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
406         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
407         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
408         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
409         (-[QuickLookDelegate _downloadDidStart:]):
410         (-[QuickLookDelegate _download:didReceiveResponse:]):
411         (-[QuickLookDelegate _download:didReceiveData:]):
412         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
413         (-[QuickLookDelegate _downloadDidFinish:]):
414         (-[QuickLookDelegate _download:didFailWithError:]):
415         (-[QuickLookDelegate _downloadDidCancel:]):
416         (-[QuickLookDelegate verifyDownload]):
417         (runTest):
418         (runTestDecideBeforeLoading):
419         (runTestDecideAfterLoading):
420         (TEST):
421         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
422         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
423         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
424         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
425         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
426         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
427         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
428         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
429         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
430         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
431         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
432         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
433         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
434         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
435
436 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
437
438         [CMake] add testdfg as target with build-jsc
439         https://bugs.webkit.org/show_bug.cgi?id=196393
440
441         Reviewed by Saam Barati.
442
443         Added testdfg as one of the targets to build when
444         using CMake.
445
446         * Scripts/build-jsc:
447
448 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
449
450         Delete WebMetal implementation in favor of WebGPU
451         https://bugs.webkit.org/show_bug.cgi?id=195418
452
453         Reviewed by Dean Jackson.
454
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         (enableExperimentalFeatures):
457         (resetWebPreferencesToConsistentValues):
458         * Scripts/webkitperl/FeatureList.pm:
459         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
461         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
462         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
463         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
464         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
465         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
466         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
467         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
469         (WTR::InjectedBundle::beginTesting):
470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
471         (WTR::TestRunner::setWebMetalEnabled): Deleted.
472         * WebKitTestRunner/InjectedBundle/TestRunner.h:
473
474 2019-03-29  Chris Dumez  <cdumez@apple.com>
475
476         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
477         https://bugs.webkit.org/show_bug.cgi?id=196405
478         <rdar://problem/49428130>
479
480         Reviewed by Wenson Hsieh.
481
482         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
483         the popover presentation methods to be no-ops. Use this in the new test added in
484         r243523 so that we do not swizzle those methods for all tests. This is needed because
485         those WatchOS tests rely on the popover getting presented and interactive.
486
487         * WebKitTestRunner/TestController.cpp:
488         (WTR::updateTestOptionsFromTestHeader):
489         * WebKitTestRunner/TestController.h:
490         * WebKitTestRunner/TestOptions.h:
491         (WTR::TestOptions::hasSameInitializationOptions const):
492         * WebKitTestRunner/ios/TestControllerIOS.mm:
493         (WTR::TestController::platformInitialize):
494         (WTR::TestController::platformResetStateToConsistentValues):
495
496 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
497
498         [Curl] Add Server Trust Evaluation Support.
499         https://bugs.webkit.org/show_bug.cgi?id=191646
500
501         Reviewed by Fujii Hironori.
502
503         Implemented MiniBrowser UI for asking if user trusts the server.
504
505         * MiniBrowser/win/Common.cpp:
506         (askServerTrustEvaluation):
507         (replaceString):
508         * MiniBrowser/win/Common.h:
509         * MiniBrowser/win/MiniBrowserLib.rc:
510         * MiniBrowser/win/MiniBrowserLibResource.h:
511         * MiniBrowser/win/WebKitBrowserWindow.cpp:
512         (createPEMString):
513         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
514         (WebKitBrowserWindow::canTrustServerCertificate):
515         * MiniBrowser/win/WebKitBrowserWindow.h:
516
517 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
518
519         Implement ResizeObserver.
520         https://bugs.webkit.org/show_bug.cgi?id=157743
521
522         Reviewed by Simon Fraser.
523
524         Support resizeObserverEnabled webPreferences.
525
526         * DumpRenderTree/TestOptions.cpp:
527         (TestOptions::TestOptions):
528         * DumpRenderTree/TestOptions.h:
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (setWebPreferencesForTestOptions):
531         * DumpRenderTree/win/DumpRenderTree.cpp:
532         (enableExperimentalFeatures):
533         * Scripts/webkitperl/FeatureList.pm:
534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
535
536 2019-03-28  John Wilander  <wilander@apple.com>
537
538         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
539         https://bugs.webkit.org/show_bug.cgi?id=196281
540         <rdar://problem/48938748>
541
542         Reviewed by Alex Christensen.
543
544         This patch adds the function isStatisticsHasLocalStorage() to the
545         TestRunner. With it, the page can query the WebsiteDataStore in the
546         UI process to make sure that it sees LocalStorage.
547
548         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
549         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
550         (WTR::TestRunner::isStatisticsHasLocalStorage):
551         * WebKitTestRunner/InjectedBundle/TestRunner.h:
552         * WebKitTestRunner/TestController.cpp:
553         (WTR::TestController::isStatisticsHasLocalStorage):
554         * WebKitTestRunner/TestController.h:
555         * WebKitTestRunner/TestInvocation.cpp:
556         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
557
558 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
559
560         API::Data::createWithoutCopying should do a null check before calling CFRelease
561         https://bugs.webkit.org/show_bug.cgi?id=196276
562         <rdar://problem/48059859>
563
564         Reviewed by Alex Christensen.
565
566         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
567
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
570         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
571         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
572         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
573         (TestWebKitAPI::TEST):
574
575 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
576
577         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
578         https://bugs.webkit.org/show_bug.cgi?id=186276
579
580         Reviewed by Carlos Garcia Campos.
581
582         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
583         (webViewLoadChanged):
584         (testWebResourceGetDataError):
585         (testWebResourceGetDataEmpty):
586         (beforeAll):
587         (webViewloadChanged): Deleted.
588
589 2019-03-27  Andy Estes  <aestes@apple.com>
590
591         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
592         https://bugs.webkit.org/show_bug.cgi?id=196317
593
594         Reviewed by Dan Bernstein.
595
596         package-root copies built products into a staging directory using ditto(1), which does not
597         follow symbolic links as it traverses a directory. Now that the files in
598         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
599         itself, these become broken links when ditto'd into the staging directory.
600
601         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
602
603         * Scripts/package-root:
604
605 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
606
607         [ews-app] Update display text of Submit for ews analysis
608         https://bugs.webkit.org/show_bug.cgi?id=196309
609
610         Reviewed by Dewei Zhu.
611
612         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
613
614 2019-03-27  David Kilzer  <ddkilzer@apple.com>
615
616         run-webkit-tests should check for leaks in WebKit processes
617         <https://webkit.org/b/193772>
618         <rdar://problem/46526680>
619
620         Reviewed by Ryosuke Niwa.
621
622         This works by doing the following:
623         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
624           The list of child processes are returned one per line:
625           process.name: pid
626         - Run the "#LIST CHILD PROCESSES" command just before the
627           "#CHECK FOR WORLD LEAKS" command, and store the list of child
628           processes on the ServerProcess object.
629         - When the `--leaks` switch is handled, run check_for_leaks() on
630           each child process after the main test harness.
631
632         * DumpRenderTree/mac/DumpRenderTree.mm:
633         (handleControlCommand):
634         - Use strncmp() instead of strcmp().
635         - Add support for handling "#LIST CHILD PROCESSES" command.
636
637         * Scripts/webkitpy/port/base.py:
638         (Port.check_for_leaks):
639         * Scripts/webkitpy/port/darwin.py:
640         (DarwinPort.check_for_leaks):
641         - Rename redundant 'process_pid' argument to 'process_id'.
642
643         * Scripts/webkitpy/port/driver.py:
644         (Driver.do_post_tests_work):
645         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
646           longer the only command this sends to WebKitTestRunner.
647         - If the `--leaks` switch is present, send the
648           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
649           result using Port.set_webkit_processes().
650         (Driver._parse_child_processes_output):
651         - Add helper method to parse list of child process names and
652           process IDs returned from WebKitTestRunner.
653
654         * Scripts/webkitpy/port/ios_device.py:
655         (IOSDevicePort.check_for_leaks):
656         - Rename redundant 'process_pid' argument to 'process_id'.
657
658         * Scripts/webkitpy/port/leakdetector.py:
659         (LeakDetector._parse_leaks_output):
660         - Return early if there is no leaks_output.
661         (LeakDetector.check_for_leaks):
662         - Rename redundant 'process_pid' argument to 'process_id'.
663
664         * Scripts/webkitpy/port/server_process.py:
665         (ServerProcess.__init__):
666         (ServerProcess.child_processes):
667         (ServerProcess.set_child_processes):
668         - Add instance variable to Port to store list of child process
669           names and process IDs returned from WebKitTestRunner.
670         (ServerProcess._start):
671         - Clear self._child_processes.
672         (ServerProcess.stop):
673         - If self._child_processes is set, call
674           self._port.check_for_leaks() for each child process.
675
676         * Scripts/webkitpy/port/server_process_unittest.py:
677         (TrivialMockPort.check_for_leaks):
678         - Rename redundant 'process_pid' argument to 'process_id'.
679
680         * Scripts/webkitpy/port/simulator_process.py:
681         (SimulatorProcess.stop):
682         - If self._child_processes is set, call
683           self._port.check_for_leaks() for each child process.
684
685         * Scripts/webkitpy/port/watch_device.py:
686         (WatchDevicePort.check_for_leaks):
687         - Rename redundant 'process_pid' argument to 'process_id'.
688
689         * WebKitTestRunner/TestController.cpp:
690         (WTR::TestController::dumpResponse):
691         - Extract method from findAndDumpWorldLeaks() so that it may be
692           reused by findAndDumpWebKitProcessIdentifiers().
693         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
694         - Add method to output process name and process ID of both the
695           WebContent and Networking processes.
696         (WTR::TestController::findAndDumpWorldLeaks):
697         - Fix missing newline in output when there were no abandoned
698           documents.
699         - Call dumpResponse() for extracted code.
700         (WTR::TestController::handleControlCommand):
701         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
702         - Use strncmp() instead of strcmp().
703         - Call findAndDumpWebKitProcessIdentifiers() when
704           "#LIST CHILD PROCESSES" command is sent.
705         * WebKitTestRunner/TestController.h:
706         (WTR::TestController::dumpResponse):
707         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
708         - Declare methods.
709
710 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         Unreviewed. Add GLib API test cases after r243434.
713
714         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
715         (testWebViewActiveURI):
716         (serverCallback):
717         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
718         (sendRequestCallback):
719
720 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
721
722         Geolocation request not complete when watch request was started in a different web process
723         https://bugs.webkit.org/show_bug.cgi?id=195996
724
725         Reviewed by Alex Christensen.
726
727         Add a test case.
728
729         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
730         (TestWebKitAPI::runJavaScriptAlert):
731         (TestWebKitAPI::TEST):
732
733 2019-03-26  Keith Rollin  <krollin@apple.com>
734
735         Update the way generate-xcfilelists returns strings from functions
736         https://bugs.webkit.org/show_bug.cgi?id=195975
737         <rdar://problem/49040807>
738
739         Reviewed by Dean Jackson.
740
741         There are places where generate-xcfilelists executes assignments with
742         statements like:
743
744             FOO=$(some_function)
745
746         where "some_function" return a string by echoing it. E.g.
747
748             some_function()
749             {
750                 echo "Hello, World"
751             }
752
753         This is a common idiom, but it has a problem if "some_function" needs
754         to call "exit" in an attempt to halt the entire script right then and
755         there. Since "some_function" is called inside of $(), it's being
756         executed in a sub-shell. Calling exit in that sub-shell simply exits
757         that shell; it doesn't not exit the outer shell in which the main part
758         of the script is still running. As such, the main script keeps
759         executing when the intent was for the script to halt.
760
761         The solution to this is to use a different idiom for returning
762         strings. The one we now is to pass in the name of the variable to
763         receive the string result:
764
765             some_function()
766             {
767                 variable_name=$1
768                 eval $variable_name ="Hello, World"
769             }
770
771         The call site now looks like
772
773             some_function FOO
774
775         Because there's no invocation of a sub-shell, some_function can now
776         call "exit" if it wants to, and the entire script will exit at that
777         point.
778
779         * Scripts/generate-xcfilelists:
780
781 2019-03-26  Chris Dumez  <cdumez@apple.com>
782
783         Add basic layout test coverage for File Picker on iOS
784         https://bugs.webkit.org/show_bug.cgi?id=196265
785
786         Reviewed by Wenson Hsieh.
787
788         Add layout test infrastructure to test the file picker on iOS.
789
790         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
791         (WTR::UIScriptController::dismissFilePicker):
792         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
793         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
794         (WTR::UIScriptController::dismissFilePicker):
795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
796         * WebKitTestRunner/TestController.cpp:
797         (WTR::TestController::createWebViewWithOptions):
798         (WTR::updateTestOptionsFromTestHeader):
799         * WebKitTestRunner/TestOptions.h:
800         (WTR::TestOptions::hasSameInitializationOptions const):
801         * WebKitTestRunner/ios/TestControllerIOS.mm:
802         (overridePresentViewController):
803         (WTR::TestController::platformInitialize):
804         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
805         (WTR::UIScriptController::dismissFilePicker):
806
807 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
808
809         Implement async paste method on UIWKInteractionViewProtocol
810         https://bugs.webkit.org/show_bug.cgi?id=196267
811         <rdar://problem/49236346>
812
813         Reviewed by Tim Horton.
814
815         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
816         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
817         are now a part of all iOS 12 internal SDKs.
818
819         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
820
821         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
822         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
823
824         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
825         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
826         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
827         * TestWebKitAPI/ios/UIKitSPI.h:
828
829 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
830
831         [ews-build] Use PostgreSQL for ews.webkit.org database
832         https://bugs.webkit.org/show_bug.cgi?id=196270
833
834         Reviewed by Lucas Forschler.
835
836         * BuildSlaveSupport/ews-app/ews-app/settings.py:
837
838 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
839
840         [ews] Reset simctl states on reboot
841         https://bugs.webkit.org/show_bug.cgi?id=196260
842
843         Rubber-stamped by Aakash Jain.
844
845         * EWSTools/start-queue-mac.sh:
846
847 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
848
849         [ews-build] Use PostgreSQL for ews-build database
850         https://bugs.webkit.org/show_bug.cgi?id=196229
851
852         Reviewed by Lucas Forschler.
853
854         * BuildSlaveSupport/ews-build/master.cfg:
855
856 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
857
858         [ews-build] Get master_hostname dynamically in master.cfg
859         https://bugs.webkit.org/show_bug.cgi?id=196255
860
861         Reviewed by Lucas Forschler.
862
863         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
864         send events data in test mode.
865
866 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
867
868         [ews-app] Set db_constraint to False for Foreign Keys
869         https://bugs.webkit.org/show_bug.cgi?id=196252
870
871         Reviewed by Lucas Forschler.
872
873         * BuildSlaveSupport/ews-app/ews/models/build.py:
874         * BuildSlaveSupport/ews-app/ews/models/step.py:
875
876 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
877
878         [ews-build] is_test_mode_enabled should default to True
879         https://bugs.webkit.org/show_bug.cgi?id=196248
880
881         Reviewed by Lucas Forschler.
882
883         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
884
885 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
886
887         [ews-app] Add webkitperl to ENABLED_QUEUES
888         https://bugs.webkit.org/show_bug.cgi?id=196253
889
890         Reviewed by Lucas Forschler.
891
892         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
893
894 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
895
896         Address NSWindow sometimes using WebKitTestRunnerEvent too early
897         https://bugs.webkit.org/show_bug.cgi?id=196211
898         rdar://problem/49110552
899
900         Reviewed by Tim Horton.
901
902         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
903         Make sure that EventSenderProxy always exists when running tests. We used to create
904         it when resetting before the first test, which is a bit too late.
905
906         * WebKitTestRunner/TestController.h:
907         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
908         (WTR::TestController::platformCreateWebView):
909         (WTR::TestController::platformCreateOtherPage):
910         (WTR::TestController::finishCreatingPlatformWebView):
911         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
912         (WTR::PlatformWebView::PlatformWebView):
913         Moved some code that made NSWindow use NSEvent during web view creation. We may
914         need to move more if some other case us found, but this is enough for now.
915
916 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
917
918         Unreviewed. Fix typo in GLib geolocation API after r243285.
919
920         gelocation -> geolocation.
921
922         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
923         (testGeolocationManagerWatchPosition):
924
925 2019-03-25  Alex Christensen  <achristensen@webkit.org>
926
927         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
928         https://bugs.webkit.org/show_bug.cgi?id=196213
929
930         Reviewed by Geoff Garen.
931
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
934         (credentialWithIdentityAndKeychainPath):
935         (-[ChallengeDelegate webView:didFinishNavigation:]):
936         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
937         (TestWebKitAPI::TEST):
938
939 2019-03-25  Alex Christensen  <achristensen@webkit.org>
940
941         Expected shouldn't assume its contained types are copyable
942         https://bugs.webkit.org/show_bug.cgi?id=195986
943
944         Reviewed by JF Bastien.
945
946         * TestWebKitAPI/Tests/WTF/Expected.cpp:
947         (TestWebKitAPI::NonCopyable::operator== const):
948         (TestWebKitAPI::NonCopyable::operator!= const):
949         (TestWebKitAPI::TEST):
950
951 2019-03-25  Tim Horton  <timothy_horton@apple.com>
952
953         Remove some now-unnecessary dynamic class lookup
954         https://bugs.webkit.org/show_bug.cgi?id=196237
955
956         Reviewed by Simon Fraser.
957
958         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
959         (makeRequest):
960         (TEST):
961
962 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
963
964         Unreviewed, rolling out r243450.
965
966         AppleWin and WinCairo port builds get broken.
967
968         Reverted changeset:
969
970         "Add test for fix of #196095"
971         https://bugs.webkit.org/show_bug.cgi?id=196097
972         https://trac.webkit.org/changeset/243450
973
974 2019-03-25  Commit Queue  <commit-queue@webkit.org>
975
976         Unreviewed, rolling out r243465.
977         https://bugs.webkit.org/show_bug.cgi?id=196226
978
979         the test doesn't build (Requested by thorton on #webkit).
980
981         Reverted changeset:
982
983         "Do not terminate the NetworkProcess if a third party
984         application sends a NSCredential with a SecIdentityRef"
985         https://bugs.webkit.org/show_bug.cgi?id=196213
986         https://trac.webkit.org/changeset/243465
987
988 2019-03-25  Alex Christensen  <achristensen@webkit.org>
989
990         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
991         https://bugs.webkit.org/show_bug.cgi?id=196213
992
993         Reviewed by Geoff Garen.
994
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
997         (credentialWithIdentityAndKeychainPath):
998         (-[ChallengeDelegate webView:didFinishNavigation:]):
999         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1000         (TestWebKitAPI::TEST):
1001
1002 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1003
1004         [ews-build] Gracefully handle missing patch_id in events
1005         https://bugs.webkit.org/show_bug.cgi?id=196216
1006
1007         Reviewed by Lucas Forschler.
1008
1009         * BuildSlaveSupport/ews-build/events.py:
1010
1011 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1012
1013         [ews-build] use lz4 compression for improving buildbot performance
1014         https://bugs.webkit.org/show_bug.cgi?id=196155
1015
1016         Reviewed by Lucas Forschler.
1017
1018         * BuildSlaveSupport/ews-build/master.cfg:
1019
1020 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1021
1022         Pull some API testing helper methods out of TestWKWebView
1023         https://bugs.webkit.org/show_bug.cgi?id=196212
1024
1025         Reviewed by Tim Horton.
1026
1027         Refactor some more API testing utility methods, so that they can be used in
1028         tests that do not use TestWKWebView.
1029
1030         * TestWebKitAPI/cocoa/TestWKWebView.h:
1031         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1032         (-[WKWebView loadTestPageNamed:]):
1033         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1034         (-[WKWebView synchronouslyLoadHTMLString:]):
1035         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1036         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1037         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1038         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1039         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1040
1041 2019-03-25  Jer Noble  <jer.noble@apple.com>
1042
1043         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1044         https://bugs.webkit.org/show_bug.cgi?id=196097
1045
1046         Reviewed by Eric Carlson.
1047
1048         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1049
1050         * DumpRenderTree/mac/DumpRenderTree.mm:
1051         (resetWebPreferencesToConsistentValues):
1052         * WebKitTestRunner/TestController.cpp:
1053         (WTR::TestController::resetPreferencesToConsistentValues):
1054
1055 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1056
1057         Pull IPadUserInterfaceSwizzler out into a separate header file
1058         https://bugs.webkit.org/show_bug.cgi?id=196193
1059
1060         Reviewed by Anders Carlsson.
1061
1062         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1063         be used in other API tests.
1064
1065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1066         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1067         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1068         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1069         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1070         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1071         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1072
1073 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1074
1075         Remove NavigatorContentUtils in WebCore/Modules
1076         https://bugs.webkit.org/show_bug.cgi?id=196070
1077
1078         Reviewed by Alex Christensen.
1079
1080         NavigatorContentUtils was to support the custom scheme spec [1].
1081         However, in WebKit side, no port has supported the feature in
1082         WebKit layer after EFL port was removed. So there has been the
1083         only IDL implementation of the NavigatorContentUtils in WebCore.
1084         So we don't need to keep the implementation in WebCore anymore.
1085
1086         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1087
1088         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1089
1090 2019-03-24  Andy Estes  <aestes@apple.com>
1091
1092         [watchOS] Remove unused Proximity Networking code
1093         https://bugs.webkit.org/show_bug.cgi?id=196188
1094
1095         Reviewed by Tim Horton.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1098         (TEST):
1099
1100 2019-03-23  Keith Miller  <keith_miller@apple.com>
1101
1102         Refactor clz/ctz and fix getLSBSet.
1103         https://bugs.webkit.org/show_bug.cgi?id=196162
1104
1105         Reviewed by Saam Barati.
1106
1107         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1108
1109         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1110         (TestWebKitAPI::TEST):
1111
1112 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1115         https://bugs.webkit.org/show_bug.cgi?id=196143
1116
1117         Reviewed by Michael Catanzaro.
1118
1119         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1120         directories.
1121
1122         * Scripts/webkitpy/style/checkers/cpp.py:
1123         (check_identifier_name_in_declaration):
1124         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1125         (WebKitStyleTest.test_names):
1126
1127 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1128
1129         [Flatpak] Manifest expanding fails for qt WPE extension
1130         https://bugs.webkit.org/show_bug.cgi?id=196148
1131
1132         Reviewed by Alex Christensen.
1133
1134         * flatpak/flatpakutils.py:
1135         (expand_submodules_recurse): The last recurse manifest expand
1136         iteration might lead to a single module so take it into account
1137         and don't try to recurse further.
1138
1139 2019-03-22  Chris Dumez  <cdumez@apple.com>
1140
1141         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1142         https://bugs.webkit.org/show_bug.cgi?id=195348
1143         <rdar://problem/48622090>
1144
1145         Reviewed by Alex Christensen.
1146
1147         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1148         to NO when test.options().shouldIgnoreMetaViewport is false.
1149
1150         * WebKitTestRunner/ios/TestControllerIOS.mm:
1151         (WTR::TestController::platformConfigureViewForTest):
1152
1153 2019-03-22  Chris Dumez  <cdumez@apple.com>
1154
1155         Prewarmed processes should be usable with any website data store
1156         https://bugs.webkit.org/show_bug.cgi?id=196104
1157
1158         Reviewed by Alex Christensen.
1159
1160         Add API test coverage.
1161
1162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1163         (runInitialWarmedProcessUsedTest):
1164         (TEST):
1165
1166 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1167
1168         Back out local changes to Alex's Subversion working directory
1169
1170         They were accidentally committed.
1171
1172         * Scripts/webkitpy/common/system/abstractexecutive.py:
1173         (AbstractExecutive.wait_newest):
1174         * Scripts/webkitpy/common/system/executive.py:
1175         (Executive.running_pids):
1176         * Scripts/webkitpy/common/system/executive_mock.py:
1177         (MockExecutive.running_pids):
1178         * Scripts/webkitpy/common/system/executive_unittest.py:
1179         (ExecutiveTest.serial_test_running_pids):
1180         * Scripts/webkitpy/port/darwin.py:
1181         (DarwinPort.check_for_leaks):
1182         * Scripts/webkitpy/port/leakdetector.py:
1183         (LeakDetector.check_for_leaks):
1184         - This was the hack attached to Bug 193772.
1185
1186         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1187         (+[WebKitTestRunnerEvent mouseLocation]):
1188         - This works around a crash on an internal build.
1189
1190 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1191
1192         Fix the build after r243354
1193         https://bugs.webkit.org/show_bug.cgi?id=196138
1194         <rdar://problem/49145951>
1195
1196         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1197         (TEST):
1198         * TestWebKitAPI/ios/UIKitSPI.h:
1199
1200 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1201
1202         Adopt UIWKDocumentContext
1203         https://bugs.webkit.org/show_bug.cgi?id=196040
1204         <rdar://problem/48642440>
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1209         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1210         (makeRequest):
1211         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1212         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1213         (applyStyle):
1214         (TEST):
1215         Add tests for UIWKDocumentContext.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1218         (TEST):
1219         (recursiveFindWKContentView): Deleted.
1220         * TestWebKitAPI/cocoa/TestWKWebView.h:
1221         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1222         (recursiveFindWKContentView):
1223         (-[TestWKWebView wkContentView]):
1224         * TestWebKitAPI/ios/UIKitSPI.h:
1225         Share the WKContentView finding code between tests.
1226
1227 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1228
1229         [iOS WK2] Turn on async overflow scrolling by default
1230         https://bugs.webkit.org/show_bug.cgi?id=196011
1231         rdar://problem/48453859
1232
1233         Reviewed by Antti Koivisto.
1234         
1235         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1236         since so many basic layout tests have different results when compositing is triggered for
1237         overflow.
1238         
1239         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1240
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::TestController::resetPreferencesToConsistentValues):
1243
1244 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1245
1246         [ews-build] Retry API test in case of failures
1247         https://bugs.webkit.org/show_bug.cgi?id=196004
1248
1249         Reviewed by Lucas Forschler.
1250
1251         * BuildSlaveSupport/ews-build/steps.py:
1252         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1253         (CompileWebKitToT.doStepIf): Ditto.
1254         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1255         (ReRunAPITests): Re-run API tests.
1256         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1257         (RunAPITestsWithoutPatch): Run API tests without patch.
1258         (RunAPITestsWithoutPatch.doStepIf):
1259         (RunAPITestsWithoutPatch.hideStepIf):
1260         (RunAPITestsWithoutPatch.evaluateCommand):
1261         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1262         (AnalyzeAPITestsResults.start):
1263         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1264         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1265         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1266         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1267
1268 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1269
1270         [ews-build] Update queues configurations
1271         https://bugs.webkit.org/show_bug.cgi?id=196074
1272
1273         Reviewed by Dewei Zhu.
1274
1275         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1276         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1277
1278 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1279
1280         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1281         https://bugs.webkit.org/show_bug.cgi?id=195680
1282         <rdar://problem/48903534>
1283
1284         Unreviewed infrastructure fix.
1285
1286         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1287         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1288
1289 2019-03-21  Andy Estes  <aestes@apple.com>
1290
1291         [iOS] Apple Pay should be available in documents with no user agent scripts
1292         https://bugs.webkit.org/show_bug.cgi?id=196061
1293         <rdar://problem/48649391>
1294
1295         Reviewed by Brady Eidson.
1296
1297         Added API tests and related infrastructure.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1301         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1302         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1303         (TestWebKitAPI::TEST):
1304         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1305         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1306         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1307         * TestWebKitAPI/cocoa/TestProtocol.mm:
1308         (-[TestProtocol startLoading]):
1309         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1310         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1311         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1312         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1313
1314 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1315
1316         REGRESSSION (r243297): webkitpy tests broken
1317         https://bugs.webkit.org/show_bug.cgi?id=196108
1318
1319         Reviewed by Aakash Jain.
1320
1321         r243297 updated contributors.json, which broke a few unit tests.
1322
1323         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1324         (IRCCommandTest.test_whois):
1325         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1326
1327 2019-03-21  Chris Dumez  <cdumez@apple.com>
1328
1329         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1330         https://bugs.webkit.org/show_bug.cgi?id=196041
1331         <rdar://problem/49083230>
1332
1333         Reviewed by Alex Christensen.
1334
1335         Add API test coverage.
1336
1337         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1338         (TEST):
1339
1340 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1341
1342         Add SPI to inform applications of WKContentRuleList actions
1343         https://bugs.webkit.org/show_bug.cgi?id=195965
1344         <rdar://problem/42664365>
1345
1346         Reviewed by Geoff Garen.
1347
1348         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1349         (TestWebKitAPI::allActionsForResourceLoad):
1350         (TestWebKitAPI::testRequest):
1351         (TestWebKitAPI::TEST_F):
1352         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1353         (Notification::description):
1354         (Notification::operator== const):
1355         (toVector):
1356         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1357         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1358         (makeContentRuleList):
1359         (TEST):
1360         (makeWarnContentRuleList): Deleted.
1361
1362 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1363
1364         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1365         https://bugs.webkit.org/show_bug.cgi?id=196088
1366
1367         Reviewed by Brian Burg.
1368
1369         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1370         Support checks when only one platform is specified. Also deprecate macosx() and
1371         force the use of macos() instead.
1372
1373         * Scripts/webkitpy/style/checkers/cpp.py:
1374         (check_min_versions_of_wk_api_available):
1375         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1376         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1377
1378 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1379
1380         Update status inactive committers' status to 'contributor'.
1381
1382         * Scripts/webkitpy/common/config/contributors.json:
1383
1384 2019-03-21  Xan Lopez  <xan@igalia.com>
1385
1386         [JSC][x86] Drop support for x87 floating point
1387         https://bugs.webkit.org/show_bug.cgi?id=194853
1388
1389         Reviewed by Don Olmstead.
1390
1391         Force SSE2 on x86/32bit builds.
1392
1393         * Scripts/webkitdirs.pm:
1394         (generateBuildSystemFromCMakeProject):
1395
1396 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1397
1398         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1399         https://bugs.webkit.org/show_bug.cgi?id=196073
1400
1401         Reviewed by Michael Catanzaro.
1402
1403         Add test cases to check functions and constructors with no arguments but receiving user data.
1404
1405         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1406         (checkUserData):
1407         (testJSCFunction):
1408         (fooCreateWithUserData):
1409         (testJSCClass):
1410
1411 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1412
1413         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1414
1415         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1416
1417         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1418
1419 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1420
1421         [GTK][WPE] Add API to provide geolocation information
1422         https://bugs.webkit.org/show_bug.cgi?id=195940
1423
1424         Reviewed by Michael Catanzaro.
1425
1426         Add a new test to check the new API.
1427
1428         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1429         (testGeolocationManagerCurrentPosition):
1430         (testGeolocationManagerWatchPosition):
1431         (beforeAll):
1432         (afterAll):
1433         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1434         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1435         (beforeAll): Ditto.
1436         * TestWebKitAPI/glib/CMakeLists.txt:
1437
1438 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1439
1440         [GLib] Returning G_TYPE_OBJECT from a method does not work
1441         https://bugs.webkit.org/show_bug.cgi?id=195574
1442
1443         Reviewed by Michael Catanzaro.
1444
1445         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1446
1447         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1448         (getGFile):
1449         (getParent):
1450         (createGString):
1451         (getGString):
1452         (getGStringCopyWillRaise):
1453         (getGStringCopy):
1454         (getGStringStr):
1455         (getGStringLen):
1456         (freeGString):
1457         (testJSCClass):
1458
1459 2019-03-20  Saam Barati  <sbarati@apple.com>
1460
1461         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1462         https://bugs.webkit.org/show_bug.cgi?id=195721
1463
1464         Reviewed by Filip Pizlo.
1465
1466         * Scripts/run-javascriptcore-tests:
1467
1468 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1469
1470         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1471         https://bugs.webkit.org/show_bug.cgi?id=196049
1472
1473         Reviewed by Tim Horton.
1474
1475         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1476         overflow scrolling in general, so rename it.
1477
1478         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1479
1480 2019-03-20  Daniel Bates  <dabates@apple.com>
1481
1482         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1483         https://bugs.webkit.org/show_bug.cgi?id=196031
1484         <rdar://problem/49078172>
1485
1486         Reviewed by Tim Horton.
1487
1488         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1489         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1490         same code path used when the Done button is pressed to dismiss the <select> picker.
1491
1492         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1493         (TestWebKitAPI::TEST):
1494
1495 2019-03-20  Chris Dumez  <cdumez@apple.com>
1496
1497         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1498         https://bugs.webkit.org/show_bug.cgi?id=196029
1499         <rdar://problem/48954651>
1500
1501         Reviewed by Tim Horton.
1502
1503         Add API test coverage.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1506
1507 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1508
1509         [ews-build] Improve failure summary string for ApplyPatch step
1510         https://bugs.webkit.org/show_bug.cgi?id=195995
1511
1512         Reviewed by Alexey Proskuryakov.
1513
1514         * BuildSlaveSupport/ews-build/steps.py:
1515         (ApplyPatch.getResultSummary): Override getResultSummary.
1516
1517 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1518
1519         AX: Implement support for new meter ARIA role
1520         https://bugs.webkit.org/show_bug.cgi?id=195966
1521
1522         Reviewed by Chris Fleizach.
1523
1524         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1525         to AXLevelIndicator.
1526
1527         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1528
1529 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1530
1531         [WebAuthN] Implement FIDO AppID extension
1532         https://bugs.webkit.org/show_bug.cgi?id=143491
1533         <rdar://problem/48298273>
1534
1535         Reviewed by Brent Fulgham.
1536
1537         Add a test that covers the new flag of convertToU2fSignCommand.
1538
1539         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1542         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1543         (TestWebKitAPI::TEST):
1544
1545 2019-03-19  Keith Rollin  <krollin@apple.com>
1546
1547         Add support for more platforms to generate-xcfilelists
1548         https://bugs.webkit.org/show_bug.cgi?id=195977
1549
1550         Reviewed by Alexey Proskuryakov.
1551
1552         generate-xcfilelists incorrectly complains when involved with building
1553         WebKit for iphonesimulator:
1554
1555             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1556             …
1557             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1558
1559         Address this by teaching generate-xcfilelists about more platforms.
1560
1561         * Scripts/generate-xcfilelists:
1562
1563 2019-03-19  John Wilander  <wilander@apple.com>
1564
1565         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1566         https://bugs.webkit.org/show_bug.cgi?id=195923
1567         <rdar://problem/49001272>
1568
1569         Reviewed by Alex Christensen.
1570
1571         This patch does the following to the TestRunner:
1572         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1573         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1574         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1575
1576         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1578         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1580         * WebKitTestRunner/TestController.cpp:
1581         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1582         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1583         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1584         * WebKitTestRunner/TestController.h:
1585         * WebKitTestRunner/TestInvocation.cpp:
1586         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1587
1588 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1589
1590         [CMake] Support more clang and gcc sanitizers
1591         https://bugs.webkit.org/show_bug.cgi?id=195956
1592
1593         Reviewed by Michael Catanzaro.
1594
1595         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1596
1597 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1598
1599         [ews-build] Improve summary for PrintConfiguration step
1600         https://bugs.webkit.org/show_bug.cgi?id=195945
1601
1602         Reviewed by Lucas Forschler.
1603
1604         * BuildSlaveSupport/ews-build/steps.py:
1605         (PrintConfiguration.getResultSummary): Override getResultSummary.
1606
1607 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1608
1609         [ews-build] Improve summary for CheckOutSource step
1610         https://bugs.webkit.org/show_bug.cgi?id=195963
1611
1612         Reviewed by Lucas Forschler.
1613
1614         * BuildSlaveSupport/ews-build/steps.py:
1615         (CheckOutSource.getResultSummary):
1616
1617 2019-03-19  Daniel Bates  <dabates@apple.com>
1618
1619         [iOS] Focus not preserved when switching between tabs
1620         https://bugs.webkit.org/show_bug.cgi?id=195820
1621         <rdar://problem/43614450>
1622
1623         Reviewed by Brent Fulgham.
1624
1625         Add tests to ensure that we restore focus when resigning and becoming first responder.
1626
1627         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1628         (TestWebKitAPI::TEST):
1629
1630 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1631
1632         Make WTFLogChannelState and WTFLogLevel enum classes
1633         https://bugs.webkit.org/show_bug.cgi?id=195904
1634
1635         Reviewed by Eric Carlson.
1636
1637         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1638         (TestWebKitAPI::TEST_F):
1639
1640 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1641
1642         [GStreamer][EME] Backported mssdemux protection data crash fix
1643         https://bugs.webkit.org/show_bug.cgi?id=195918
1644
1645         Reviewed by Philippe Normand.
1646
1647         * gstreamer/jhbuild.modules:
1648         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1649
1650 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1651
1652         Unreviewed, rolling out r243132.
1653
1654         Broke GTK build
1655
1656         Reverted changeset:
1657
1658         "Make WTFLogChannelState and WTFLogLevel enum classes"
1659         https://bugs.webkit.org/show_bug.cgi?id=195904
1660         https://trac.webkit.org/changeset/243132
1661
1662 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1663
1664         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1665
1666         * Scripts/webkitdirs.pm:
1667         (builtDylibPathForName): Adjust the shared library name that's changed
1668         with the API version bump in r243073.
1669
1670 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1671
1672         Make WTFLogChannelState and WTFLogLevel enum classes
1673         https://bugs.webkit.org/show_bug.cgi?id=195904
1674
1675         Reviewed by Eric Carlson.
1676
1677         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1678         (TestWebKitAPI::TEST_F):
1679
1680 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1681
1682         Disable flaky test added in r2431100
1683         https://webkit.org/b/195785
1684
1685         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1686         (TestWebKitAPI::TEST):
1687         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1688
1689 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1690
1691         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1692         https://bugs.webkit.org/show_bug.cgi?id=195916
1693
1694         Reviewed by Tim Horton.
1695
1696         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1697         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1698
1699 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1700
1701         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1702
1703         * Scripts/webkitpy/common/config/contributors.json:
1704
1705 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1706
1707         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1708         https://bugs.webkit.org/show_bug.cgi?id=195785
1709
1710         Reviewed by Geoffrey Garen.
1711
1712         * TestWebKitAPI/TCPServer.cpp: Added.
1713         (TestWebKitAPI::TCPServer::TCPServer):
1714         (TestWebKitAPI::TCPServer::~TCPServer):
1715         (TestWebKitAPI::TCPServer::socketBindListen):
1716         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1717         * TestWebKitAPI/TCPServer.h: Added.
1718         (TestWebKitAPI::TCPServer::port const):
1719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1720         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1721         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1722         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1723         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1724         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1725         (TestWebKitAPI::respondSlowly):
1726         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1727         (TestWebKitAPI::downloadAtRate):
1728         (TestWebKitAPI::TEST):
1729
1730 2019-03-18  Saam Barati  <sbarati@apple.com>
1731
1732         Add a plan file for JetStream 2
1733         https://bugs.webkit.org/show_bug.cgi?id=190734
1734
1735         Reviewed by Mark Lam.
1736
1737         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1738
1739 2019-03-18  Chris Dumez  <cdumez@apple.com>
1740
1741         Delay WebProcess launch until a load is triggered in a Web view
1742         https://bugs.webkit.org/show_bug.cgi?id=195758
1743         <rdar://problem/48126013>
1744
1745         Reviewed by Geoff Garen.
1746
1747         Add API test coverage. Also update some existing API tests to not expect
1748         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1749
1750         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1751         (TestWebKitAPI::TEST):
1752         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1755         (TEST):
1756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1757         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1758         (TEST):
1759         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1760         (TEST):
1761         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1762
1763 2019-03-18  Xan Lopez  <xan@igalia.com>
1764
1765         [CMake] Prevent potential warning when determining $architecture
1766         https://bugs.webkit.org/show_bug.cgi?id=195891
1767
1768         Reviewed by Michael Catanzaro.
1769
1770         It's possible for generateBuildSystemForCMakeProject to be called
1771         before determineArchitecture() is ever called. This will make the
1772         first eq check with $architecture to be bogus (and print a
1773         warning). Change that to an eq check with architecture(), which
1774         implicitly calls determineArchitecture() if needed, and change all
1775         the other similar cases in the method in the same way to prevent
1776         future bugs like this one.
1777
1778         * Scripts/webkitdirs.pm:
1779         (generateBuildSystemFromCMakeProject):
1780
1781 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1782
1783         [WPE] Tarballs generated with “make dist” cannot build documentation
1784         https://bugs.webkit.org/show_bug.cgi?id=195885
1785
1786         Reviewed by Carlos Garcia Campos.
1787
1788         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1789
1790 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1791
1792         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1793         https://bugs.webkit.org/show_bug.cgi?id=195883
1794
1795         Reviewed by Carlos Garcia Campos.
1796
1797         * gtkdoc/gtkdoc.py:
1798         (GTKDoc._run_command): When commands fail to run, include the full command line for
1799         the program invocation and the output it has generated on the standard error stream.
1800
1801 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1802
1803         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1804         https://bugs.webkit.org/show_bug.cgi?id=195786
1805
1806         Reviewed by Philippe Normand.
1807
1808         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1809         * wpe/jhbuild.modules: Ditto.
1810
1811 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1812
1813         [ews-build] Don't run clean builds on EWS builders
1814         https://bugs.webkit.org/show_bug.cgi?id=195851
1815
1816         Reviewed by Geoffrey Garen.
1817
1818         * BuildSlaveSupport/ews-build/factories.py:
1819
1820 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1821
1822         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1823         https://bugs.webkit.org/show_bug.cgi?id=195849
1824
1825         Reviewed by Chris Dumez.
1826
1827         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1830         (runWebsiteDataStoreCustomPaths):
1831
1832 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1833
1834         webkitpy: Upload test results
1835         https://bugs.webkit.org/show_bug.cgi?id=195755
1836         <rdar://problem/48896182>
1837
1838         Reviewed by Aakash Jain.
1839
1840         Establish a new format for uploading results that is not tied to layout tests, apply
1841         that format to webkitpy tests.
1842
1843         * Scripts/webkitpy/common/checkout/scm/git.py:
1844         (Git.native_branch): Return what branch the current checkout is on.
1845         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1846         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1847         * Scripts/webkitpy/common/checkout/scm/svn.py:
1848         (SVN.native_branch): Ditto.
1849         * Scripts/webkitpy/common/system/platforminfo.py:
1850         (PlatformInfo.build_version): Return a build version for Mac.
1851         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1852         (MockPlatformInfo.__init__):
1853         (MockPlatformInfo.build_version):
1854         * Scripts/webkitpy/results: Added.
1855         * Scripts/webkitpy/results/__init__.py: Added.
1856         * Scripts/webkitpy/results/options.py: Added.
1857         (upload_options): OptParse list for upload options.
1858         * Scripts/webkitpy/results/upload.py: Added.
1859         (Upload): Class which enforces the upload format expected by the results server.
1860         (Upload.Expectations):
1861         (Upload.create_configuration):
1862         (Upload.create_commit):
1863         (Upload.create_details):
1864         (Upload.create_run_stats):
1865         (Upload.create_test_result):
1866         (Upload.__init__):
1867         (Upload.Encoder): Encode Upload object as json.
1868         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1869         * Scripts/webkitpy/results/upload_unittest.py: Added.
1870         * Scripts/webkitpy/test/main.py:
1871         (Tester._parse_args): Add upload arguments.
1872         (Tester._run_tests): Allow results to be uploaded.
1873         * Scripts/webkitpy/test/runner.py:
1874         (Runner.__init__): Record which tests were run, rather than just counting them.
1875         (Runner.handle):
1876         * Scripts/webkitpy/test/runner_unittest.py:
1877         (RunnerTest.test_run):
1878         * Scripts/webkitpy/thirdparty/__init__.py:
1879         (AutoinstallImportHook.find_module): Add requests auto-install.
1880         (AutoinstallImportHook._install_requests):
1881         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1882         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1883
1884 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1885
1886         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1887         https://bugs.webkit.org/show_bug.cgi?id=195810
1888
1889         Reviewed by Tim Horton.
1890
1891         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1892         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1893         ending certain layout tests.
1894
1895         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1896         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1897         (-[TestRunnerWKWebView dealloc]):
1898         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1899
1900         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1901         helper method when destroying the web view, and when resetting state between tests.
1902
1903         * WebKitTestRunner/ios/TestControllerIOS.mm:
1904         (WTR::TestController::platformResetStateToConsistentValues):
1905
1906         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1907
1908 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1909
1910         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1911         https://bugs.webkit.org/show_bug.cgi?id=190350
1912         <rdar://problem/45089503>
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1917         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1918         (TEST):
1919         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1920         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1921         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1922         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1923         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1924         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1925         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1926         (runTest):
1927         (createDirectories):
1928         (TEST):
1929         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1930         (TEST):
1931         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1932         (TEST):
1933
1934 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1935
1936         Add support to WebPage for getting the contents as an attributed string.
1937         https://bugs.webkit.org/show_bug.cgi?id=195636
1938         rdar://problem/45055697
1939
1940         Reviewed by Tim Horton.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1943         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1944
1945 2019-03-15  Chris Dumez  <cdumez@apple.com>
1946
1947         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1948         https://bugs.webkit.org/show_bug.cgi?id=195747
1949
1950         Reviewed by Geoff Garen.
1951
1952         Add API test coverage.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1955
1956 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1957
1958         Unreviewed, rolling out r242952.
1959
1960         Causing API failures on iOS Simulator
1961
1962         Reverted changeset:
1963
1964         "[PSON] Make sure the WebProcessCache is leverage when
1965         relaunching a process after termination"
1966         https://bugs.webkit.org/show_bug.cgi?id=195747
1967         https://trac.webkit.org/changeset/242952
1968
1969 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1970
1971         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1972         https://bugs.webkit.org/show_bug.cgi?id=195740
1973
1974         Reviewed by Ross Kirsling.
1975
1976         window.open doesn't work for WebKitBrowserWindow because it is not
1977         implemented yet.
1978
1979         1. Implemented createNewPage callback of WKPageUIClient.
1980         2. Changed MainWindow to take a BrowserWindow factory function
1981           instead of BrowserWindowType to be flexible to create
1982           BrowserWindow with extra settings.
1983         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1984           because it is not relevant with MainWindow anymore.
1985
1986         * MiniBrowser/win/Common.cpp:
1987         (parseCommandLine):
1988         * MiniBrowser/win/Common.h:
1989         (CommandLineOptions::CommandLineOptions):
1990         * MiniBrowser/win/MainWindow.cpp:
1991         (MainWindow::MainWindow):
1992         (MainWindow::create):
1993         (MainWindow::init):
1994         (MainWindow::WndProc):
1995         * MiniBrowser/win/MainWindow.h:
1996         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1997         (PrintWebUIDelegate::createWebViewWithRequest):
1998         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1999         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2000         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2001         (WebKitBrowserWindow::updateProxySettings):
2002         (WebKitBrowserWindow::createNewPage):
2003         * MiniBrowser/win/WebKitBrowserWindow.h:
2004         * MiniBrowser/win/WinMain.cpp:
2005         (wWinMain):
2006
2007 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2008
2009         Make it possible to test scrolling tree layer manipulation more easily
2010         https://bugs.webkit.org/show_bug.cgi?id=195780
2011
2012         Reviewed by Tim Horton.
2013         
2014         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2015         cuts off communication of scrolling tree scrolls back to the web process
2016         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2017         allows tests to trigger scrolls which run the scrolling tree layer positioning
2018         logic, but never get another commit from the web process that might mask
2019         scrolling tree bugs.
2020         
2021         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2022         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2023         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2024
2025         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2026         (WTR::UIScriptController::scrollUpdatesDisabled const):
2027         (WTR::UIScriptController::setScrollUpdatesDisabled):
2028         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2029         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2030         (WTR::UIScriptController::scrollUpdatesDisabled const):
2031         (WTR::UIScriptController::setScrollUpdatesDisabled):
2032         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2034         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2035         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2036         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2037         * WebKitTestRunner/ios/TestControllerIOS.mm:
2038         (WTR::TestController::platformResetStateToConsistentValues):
2039         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2040         (WTR::UIScriptController::scrollUpdatesDisabled const):
2041         (WTR::UIScriptController::setScrollUpdatesDisabled):
2042
2043 2019-03-14  Youenn Fablet  <youenn@apple.com>
2044
2045         Move IDB storage in private browsing mode to NetworkProcess
2046         https://bugs.webkit.org/show_bug.cgi?id=195602
2047
2048         Reviewed by Brady Eidson.
2049
2050         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2051         (TEST):
2052
2053 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2054
2055         [ews-build] Make descriptionDone messages more readable
2056         https://bugs.webkit.org/show_bug.cgi?id=195760
2057
2058         Reviewed by Lucas Forschler.
2059
2060         * BuildSlaveSupport/ews-build/steps.py:
2061         * BuildSlaveSupport/ews-build/steps_unittest.py:
2062
2063 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-build] Generate status-bubble hover-over messages
2066         https://bugs.webkit.org/show_bug.cgi?id=195680
2067
2068         Reviewed by Lucas Forschler.
2069
2070         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2071         (StatusBubble):
2072         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2073         on hover-over.
2074         (StatusBubble._iso_time):
2075         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2076         hover-over message.
2077         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2078
2079 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2080
2081         [ews-app] Gracefully handle the case when state_string is None
2082         https://bugs.webkit.org/show_bug.cgi?id=195753
2083
2084         Reviewed by Lucas Forschler.
2085
2086         * BuildSlaveSupport/ews-app/ews/models/build.py:
2087         * BuildSlaveSupport/ews-app/ews/models/step.py:
2088
2089 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2090
2091         [ews-app] Status bubble display pending for currently running build step
2092         https://bugs.webkit.org/show_bug.cgi?id=195744
2093
2094         Reviewed by Lucas Forschler.
2095
2096         * BuildSlaveSupport/ews-build/events.py:
2097         (Events.stepStarted): If state_string is pending, replace it with step name.
2098
2099 2019-03-14  Chris Dumez  <cdumez@apple.com>
2100
2101         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2102         https://bugs.webkit.org/show_bug.cgi?id=195750
2103
2104         Reviewed by Geoffrey Garen.
2105
2106         Add API test coverage.
2107
2108         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2109         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2110         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2111         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2112
2113 2019-03-14  Chris Dumez  <cdumez@apple.com>
2114
2115         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2116         https://bugs.webkit.org/show_bug.cgi?id=195747
2117
2118         Reviewed by Geoff Garen.
2119
2120         Add API test coverage.
2121
2122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2123
2124 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2125
2126         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2127         https://bugs.webkit.org/show_bug.cgi?id=195725
2128         <rdar://problem/48545062>
2129
2130         Reviewed by Tim Horton.
2131
2132         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2133         handler is nil.
2134
2135         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2136         (TestWebKitAPI::TEST):
2137
2138 2019-03-13  Sam Weinig  <sam@webkit.org>
2139
2140         Add utility function to allow easy reverse range-based iteration of a container
2141         https://bugs.webkit.org/show_bug.cgi?id=195542
2142
2143         Reviewed by Antti Koivisto.
2144
2145         * TestWebKitAPI/CMakeLists.txt:
2146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2147         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2148         (TestWebKitAPI::TEST):
2149         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2150
2151 2019-03-13  Chris Dumez  <cdumez@apple.com>
2152
2153         Use a ServiceWorker process per registrable domain
2154         https://bugs.webkit.org/show_bug.cgi?id=195649
2155
2156         Reviewed by Youenn Fablet.
2157
2158         Update API test coverage.
2159
2160         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2161
2162 2019-03-13  Chris Dumez  <cdumez@apple.com>
2163
2164         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2165         https://bugs.webkit.org/show_bug.cgi?id=195684
2166         <rdar://problem/48294714>
2167
2168         Reviewed by Antti Koivisto.
2169
2170         Add API test coverage.
2171
2172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2173
2174 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2175
2176         [ews-app] Remove unused patch view
2177         https://bugs.webkit.org/show_bug.cgi?id=195669
2178
2179         Reviewed by Lucas Forschler.
2180
2181         * BuildSlaveSupport/ews-app/ews/urls.py:
2182         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2183
2184 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2185
2186         [ews-app] Use Buildbot result code variables
2187         https://bugs.webkit.org/show_bug.cgi?id=195668
2188
2189         Reviewed by Alexey Proskuryakov.
2190
2191         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2192         (Buildbot): Added Buildbot result code variables.
2193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2194         (StatusBubble._build_bubble): Used Buildbot result code variables.
2195
2196 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2197
2198         [Flatpak] Expand submodule recursively
2199         https://bugs.webkit.org/show_bug.cgi?id=195672
2200
2201         Building WPE with flatpak was impossible without that as it was raising an exception.
2202         Also update wpebackend-fdo to match what is built in jhbuild
2203
2204         Reviewed by Philippe Normand.
2205
2206         * flatpak/flatpakutils.py:
2207         (expand_submodules_recurse):
2208         (expand_manifest):
2209         * flatpak/org.webkit.WPEModules.yaml:
2210
2211 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2212
2213         [ews-app] status bubble should be hidden for certain builds
2214         https://bugs.webkit.org/show_bug.cgi?id=194597
2215
2216         Reviewed by Dewei Zhu.
2217
2218         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2219         (StatusBubble._build_bubble):
2220         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2221         because the patch didn't have relevant changes.
2222         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2223         in production yet.
2224
2225 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2226
2227         [Win] Fix a slew of simple clang-cl warnings.
2228         https://bugs.webkit.org/show_bug.cgi?id=195652
2229
2230         Reviewed by Don Olmstead.
2231
2232         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2233         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2234
2235 2019-03-12  Justin Fan  <justin_fan@apple.com>
2236
2237         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2238         https://bugs.webkit.org/show_bug.cgi?id=195518
2239         <rdar://problem/46322356>
2240
2241         Reviewed by Myles C. Maxfield.
2242
2243         * DumpRenderTree/DerivedSources-input.xcfilelist:
2244         * DumpRenderTree/DerivedSources-output.xcfilelist:
2245
2246 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2247
2248         Unreviewed, rolling out r242825.
2249         https://bugs.webkit.org/show_bug.cgi?id=195648
2250
2251         "Broke webkitpy tests with my change to
2252         lldb_dump_class_layout.py" (Requested by rmorisset on
2253         #webkit).
2254
2255         Reverted changeset:
2256
2257         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2258         classes with suspicious padding"
2259         https://bugs.webkit.org/show_bug.cgi?id=195573
2260         https://trac.webkit.org/changeset/242825
2261
2262 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2263
2264         [ews-build] Show status bubbles while the patch is waiting in queue
2265         https://bugs.webkit.org/show_bug.cgi?id=195618
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2270         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2271         enabled in initial deployment.
2272         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2273         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2274         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2275         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2276         (StatusBubble._build_bubbles_for_patch):
2277
2278 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2279
2280         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2281         https://bugs.webkit.org/show_bug.cgi?id=195573
2282
2283         Reviewed by Simon Fraser.
2284
2285         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2286
2287         * Scripts/dump-class-layout:
2288         (main):
2289         * lldb/lldb_dump_class_layout.py:
2290         (ClassLayout.__init__):
2291         (ClassLayout._compute_padding_recursive):
2292         (LLDBDebuggerInstance.dump_layout_for_classname):
2293         (LLDBDebuggerInstance):
2294         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2295         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2296
2297 2019-03-12  Chris Dumez  <cdumez@apple.com>
2298
2299         Device Orientation access permission should be denied unless explicitly granted by the client
2300         https://bugs.webkit.org/show_bug.cgi?id=195625
2301
2302         Reviewed by Youenn Fablet.
2303
2304         add API test coverage.
2305
2306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2307         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2308         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2309         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2310         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2311         (runDeviceOrientationTest):
2312         (TEST):
2313         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2314         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2315
2316 2019-03-12  Jer Noble  <jer.noble@apple.com>
2317
2318         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2319         https://bugs.webkit.org/show_bug.cgi?id=195137
2320         <rdar://problem/48810307>
2321
2322         Reviewed by Eric Carlson.
2323
2324         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2325         (TestWebKitAPI::TEST):
2326
2327 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2328
2329         [ews-build] Change urls from uat to production
2330         https://bugs.webkit.org/show_bug.cgi?id=195566
2331
2332         Reviewed by Lucas Forschler.
2333
2334         * BuildSlaveSupport/ews-app/ews/config.py:
2335         * BuildSlaveSupport/ews-build/events.py:
2336         * BuildSlaveSupport/ews-build/steps.py:
2337
2338 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2339
2340         [ews-build] change max_builds for local-worker to 1
2341         https://bugs.webkit.org/show_bug.cgi?id=195568
2342
2343         Reviewed by Lucas Forschler.
2344
2345         * BuildSlaveSupport/ews-build/loadConfig.py:
2346
2347 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2348
2349         Fix the build
2350
2351         * TestRunnerShared/spi/PencilKitTestSPI.h:
2352         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2353
2354 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2355
2356         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2357         https://bugs.webkit.org/show_bug.cgi?id=194131
2358
2359         Reviewed by Michael Catanzaro.
2360
2361         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2362         (uriChanged):
2363         (testUnfinishedSubresourceLoad):
2364         (serverCallback):
2365         (beforeAll):
2366
2367 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2368
2369         WTF::Expected should use std::addressof instead of operator&
2370         https://bugs.webkit.org/show_bug.cgi?id=195604
2371
2372         Reviewed by Myles Maxfield.
2373
2374         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2375         (TestWebKitAPI::Unique::Unique):
2376         (TestWebKitAPI::Unique::operator&):
2377         (TestWebKitAPI::TEST):
2378
2379 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2380
2381         Add Optional to Forward.h.
2382         https://bugs.webkit.org/show_bug.cgi?id=195586
2383
2384         Reviewed by Darin Adler.
2385
2386         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2387         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2388         Remove unnecessary includes from headers.
2389
2390 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2391
2392         Add testing API to hit-test and scroll overflow scrollers
2393         https://bugs.webkit.org/show_bug.cgi?id=195278
2394
2395         Reviewed by Antti Koivisto.
2396         
2397         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2398         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2399         
2400         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2401
2402         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2403         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2404         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2405         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2406         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2407         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2409         (WTR::enclosingScrollViewIncludingSelf):
2410         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2411
2412 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2413
2414         API test WebKit.RequestTextInputContext fails on iOS
2415         https://bugs.webkit.org/show_bug.cgi?id=195585
2416
2417         Reviewed by Wenson Hsieh and Simon Fraser.
2418
2419         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2420         (applyStyle):
2421         (TEST):
2422         Add a viewport, so that the coordinates match up on iOS.
2423         Scroll by moving the UIScrollView's contentOffset.
2424
2425 2019-03-11  Chris Dumez  <cdumez@apple.com>
2426
2427         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2428         https://bugs.webkit.org/show_bug.cgi?id=195506
2429         <rdar://problem/48733477>
2430
2431         Reviewed by Alex Christensen.
2432
2433         Add API test coverage.
2434
2435         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2436
2437 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2438
2439         Adding myself to contributors.json
2440
2441         Unreviewed, addming myself to contributors.json .
2442
2443         * Scripts/webkitpy/common/config/contributors.json:
2444
2445 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2446
2447         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2448         https://bugs.webkit.org/show_bug.cgi?id=195511
2449         <rdar://problem/44873269>
2450
2451         Reviewed by Darin Adler.
2452
2453         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2454         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2455         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2456         (TEST_F):
2457
2458 2019-03-11  Chris Dumez  <cdumez@apple.com>
2459
2460         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2461         https://bugs.webkit.org/show_bug.cgi?id=195561
2462
2463         Reviewed by Youenn Fablet.
2464
2465         Make sure the JS in the test requests for permission to receive device orientation events.
2466
2467         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2468
2469 2019-03-11  Youenn Fablet  <youenn@apple.com>
2470
2471         Allow storage quota increase by default in WTR
2472         https://bugs.webkit.org/show_bug.cgi?id=195541
2473
2474         Reviewed by Geoffrey Garen.
2475
2476         Allow storage quota increase by default in WTR.
2477         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2478         Use this for tests that explicitly need cache increase.
2479
2480         Instead of increasing quota by 2, make sure the next request is
2481         granted by adding all given parameters.
2482
2483         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2484         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2485         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2486         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2488         * WebKitTestRunner/TestController.cpp:
2489         (WTR::TestController::setAllowStorageQuotaIncrease):
2490         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2491         * WebKitTestRunner/TestController.h:
2492         * WebKitTestRunner/TestInvocation.cpp:
2493         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2494         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2495         (WTR::TestController::cocoaResetStateToConsistentValues):
2496         (WTR::TestController::setAllowStorageQuotaIncrease):
2497         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2498         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2499         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2500
2501 2019-03-11  Xan Lopez  <xan@igalia.com>
2502
2503         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2504         https://bugs.webkit.org/show_bug.cgi?id=194147
2505
2506         Reviewed by Michael Saboff.
2507
2508         To make --32-bit work correctly on Linux/64bit we need to:
2509
2510         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2511         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2512         unfortunately CMake only allows us to do this during
2513         crosscompilation, which is overkill here.
2514         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2515         pkg-config detection module uses the x86 .pc files instead of the
2516         x86_64 ones.
2517         - Set the -m32 flags for the compiler.
2518
2519         * Scripts/webkitdirs.pm:
2520         (generateBuildSystemFromCMakeProject):
2521
2522 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2523
2524         Add MotionMark-1.1 plan file for run-benchmark script.
2525         https://bugs.webkit.org/show_bug.cgi?id=195481
2526
2527         Rubber-stamped by Darin Adler.
2528
2529         Run-benchmark script should support MontionMark-1.1.
2530
2531         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2532
2533 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2534
2535         [ews-app] Add support for submit-to-ews url
2536         https://bugs.webkit.org/show_bug.cgi?id=195477
2537
2538         Reviewed by Lucas Forschler.
2539
2540         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2541         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2542         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2543         * BuildSlaveSupport/ews-app/ews/urls.py:
2544         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2545
2546 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2547
2548         Unreviewed, rolling out r242688, r242643, r242624.
2549
2550         Caused multiple layout test failures and crashes on iOS and macOS.
2551
2552         Reverted changeset:
2553
2554         "requestAnimationFrame should execute before the next frame"
2555         https://bugs.webkit.org/show_bug.cgi?id=177484
2556         https://trac.webkit.org/changeset/242624/webkit
2557
2558         * Tracing/SystemTracePoints.plist:
2559
2560 2019-03-11  John Wilander  <wilander@apple.com>
2561
2562         Resource Load Statistics: Make it possible exclude localhost from classification
2563         https://bugs.webkit.org/show_bug.cgi?id=195474
2564         <rdar://problem/47520577>
2565
2566         Reviewed by Brent Fulgham.
2567
2568         This patch allows for localhost to be excluded from classification and
2569         treatment as a prevalent resource.
2570
2571         The WebKit Tools change adds a new function called
2572         testRunner.setStatisticsIsRunningTest() which can be used to control this
2573         behavior.
2574
2575         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2577         (WTR::TestRunner::setStatisticsIsRunningTest):
2578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2579         * WebKitTestRunner/TestController.cpp:
2580         (WTR::TestController::setStatisticsIsRunningTest):
2581         * WebKitTestRunner/TestController.h:
2582         * WebKitTestRunner/TestInvocation.cpp:
2583         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2584
2585 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2586
2587         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2588         https://bugs.webkit.org/show_bug.cgi?id=195560
2589
2590         Reviewed by Lucas Forschler.
2591
2592         * BuildSlaveSupport/ews-build/master.cfg:
2593
2594 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2595
2596         Unreviewed, rolling out r242698.
2597
2598         API test crashes on bots.
2599
2600         Reverted changeset:
2601
2602         "Add a WKContentRuleList variant that uses copied memory
2603         instead of mmap'd shared memory for class A containerized
2604         apps"
2605         https://bugs.webkit.org/show_bug.cgi?id=195511
2606         https://trac.webkit.org/changeset/242698
2607
2608 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2609
2610         [WPE] Enable web process sandbox
2611         https://bugs.webkit.org/show_bug.cgi?id=195169
2612
2613         Reviewed by Daniel Bates.
2614
2615         * wpe/install-dependencies:
2616         * wpe/jhbuild.modules:
2617
2618 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2619
2620         [ews-app] Use port 17000 for worker communication
2621         https://bugs.webkit.org/show_bug.cgi?id=195558
2622
2623         Reviewed by Lucas Forschler.
2624
2625         * BuildSlaveSupport/ews-build/master.cfg:
2626
2627 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2628
2629         [ews-build] unit-tests fail when passwords.json is missing
2630         https://bugs.webkit.org/show_bug.cgi?id=195557
2631
2632         Reviewed by Lucas Forschler.
2633
2634         * BuildSlaveSupport/ews-build/loadConfig.py:
2635         (loadBuilderConfig):
2636         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2637         (ConfigDotJSONTest.test_configuration):
2638         * BuildSlaveSupport/ews-build/master.cfg:
2639
2640 2019-03-11  Truitt Savell  <tsavell@apple.com>
2641
2642         Unreviewed, rolling out r242702.
2643
2644         Broke High Sierra builders.
2645
2646         Reverted changeset:
2647
2648         "Add utility function to allow easy reverse range-based
2649         iteration of a container"
2650         https://bugs.webkit.org/show_bug.cgi?id=195542
2651         https://trac.webkit.org/changeset/242702
2652
2653 2019-03-11  Sam Weinig  <sam@webkit.org>
2654
2655         Add utility function to allow easy reverse range-based iteration of a container
2656         https://bugs.webkit.org/show_bug.cgi?id=195542
2657
2658         Reviewed by Antti Koivisto.
2659
2660         * TestWebKitAPI/CMakeLists.txt:
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2663         (TestWebKitAPI::TEST):
2664         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2665
2666 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2667
2668         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2669         https://bugs.webkit.org/show_bug.cgi?id=195511
2670         <rdar://problem/44873269>
2671
2672         Reviewed by Darin Adler.
2673
2674         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2675         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2676         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2677         (TEST_F):
2678
2679 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2680
2681         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2682         https://bugs.webkit.org/show_bug.cgi?id=195499
2683
2684         Reviewed by Darin Adler.
2685
2686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2687         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2688         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2689         (-[WKWebView synchronouslyFocusTextInputContext:]):
2690         (applyStyle):
2691         (applyIframe):
2692         (TEST):
2693         Add some tests for this SPI.
2694
2695 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2696
2697         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2698         https://bugs.webkit.org/show_bug.cgi?id=181151
2699
2700         Reviewed by Don Olmstead.
2701
2702         * TestWebKitAPI/CMakeLists.txt:
2703         * TestWebKitAPI/PlatformWin.cmake:
2704         Enable TestWTF RunLoop tests in all platforms.
2705
2706         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2707         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2708         (TestWebKitAPI::DerivedOneShotTimer::fired):
2709         (TestWebKitAPI::TEST):
2710         Only a few platforms support nested RunLoop.
2711
2712         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2713         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2714
2715 2019-03-10  David Quesada  <david_quesada@apple.com>
2716
2717         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2718         https://bugs.webkit.org/show_bug.cgi?id=152480
2719
2720         Reviewed by Chris Dumez.
2721
2722         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2723         there are no additional references to the process pool besides the one held by
2724         the download, waits for the download to finish (in the sense that the
2725         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2726         measure, also check that the process pool has been deallocated at the end of the
2727         test. The test wouldn't be meaningful if the process pool were still alive.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2730         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2731         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2732             The download will be canceled because the delegate does not implement the
2733             method to decide the download's destination, so this is where we know the
2734             DownloadProxyMap is done with the DownloadProxy.
2735         (TEST):
2736
2737 2019-03-08  Chris Dumez  <cdumez@apple.com>
2738
2739         Add support for Device Orientation / Motion permission API
2740         https://bugs.webkit.org/show_bug.cgi?id=195329
2741         <rdar://problem/47645367>
2742
2743         Reviewed by Geoffrey Garen.
2744
2745         Add test infrastructure to help test the Device Orientation / Motion permission API.
2746
2747         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2749         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2750         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2751         * WebKitTestRunner/TestController.cpp:
2752         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2753         (WTR::TestController::createWebViewWithOptions):
2754         (WTR::TestController::resetStateToConsistentValues):
2755         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2756         * WebKitTestRunner/TestController.h:
2757         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2758         * WebKitTestRunner/TestInvocation.cpp:
2759         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2760
2761 2019-03-08  Saam barati  <sbarati@apple.com>
2762
2763         Add a compare-results script to compare benchmark results
2764         https://bugs.webkit.org/show_bug.cgi?id=195486
2765         <rdar://problem/48723397>
2766
2767         Reviewed by Geoffrey Garen.
2768
2769         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2770         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2771         to extend it to learn about our other benchmarks.
2772
2773         * Scripts/compare-results: Added.
2774         (readJSONFile):
2775         (detectJetStream2):
2776         (JetStream2Results):
2777         (detectSpeedometer2):
2778         (Speedometer2Results):
2779         (detectPLT5):
2780         (PLT5Results):
2781         (detectBenchmark):
2782         (biggerIsBetter):
2783         (ttest):
2784         (getOptions):
2785         (main):
2786
2787 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2788
2789         Ensure old tab state is cleared between iterations of run-benchmark
2790         https://bugs.webkit.org/show_bug.cgi?id=195393
2791         <rdar://problem/46885583>
2792
2793         Reviewed by Dewei Zhu.
2794
2795         a) ensure the default to restore state is not set
2796         b) terminate Safari correctly
2797         c) Set the system default to ignore Persistent State in Safari
2798
2799         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2800         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2801         (OSXBrowserDriver.prepare_env): 
2802         (OSXBrowserDriver.restore_env):
2803         (OSXBrowserDriver.close_browsers):
2804         (OSXBrowserDriver._terminate_processes):
2805         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2806         (OSXChromeDriver):
2807         (OSXChromeCanaryDriver):
2808         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2809         (OSXFirefoxDriver):
2810         (OSXFirefoxNightlyDriver):
2811         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2812         (OSXSafariDriver):
2813         (OSXSafariDriver.prepare_env):
2814
2815 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2816
2817         [GTK] Several InputMethodFilter tests are failing
2818         https://bugs.webkit.org/show_bug.cgi?id=195408
2819
2820         Reviewed by Carlos Garcia Campos.
2821
2822         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2823         Regressed in r241751.
2824         Hexadecimal values of keycodes are expressed now in upper letters.
2825         Composited characters should be cast to UTF8 strings.
2826
2827         (TestWebKitAPI::TEST):
2828
2829 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2830
2831         [GTK] Make Tools/gtkdoc python3 compatible
2832         https://bugs.webkit.org/show_bug.cgi?id=195359
2833
2834         Reviewed by Carlos Garcia Campos.
2835
2836         * gtkdoc/generate-gtkdoc:
2837         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2838         work with Python 2 and 3.
2839         (get_gtkdoc_module_paths):
2840         The iteritems() was removed in Python 3, so let's use items() that's
2841         available in Python 2 and 3.
2842         (get_generator_for_config):
2843         * gtkdoc/gtkdoc.py:
2844         (GTKDoc._run_command):
2845         The sys.stdout.write() is expecting str in Python 3 and not bytes
2846         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2847         for passing the bytes there.
2848
2849 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2850
2851         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2852         https://bugs.webkit.org/show_bug.cgi?id=195346
2853         <rdar://problem/48667048>
2854
2855         Unreviewed build fix for clang-cl.
2856
2857         * DumpRenderTree/win/DumpRenderTree.cpp:
2858         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2859
2860 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2861
2862         requestAnimationFrame should execute before the next frame
2863         https://bugs.webkit.org/show_bug.cgi?id=177484
2864
2865         Reviewed by Simon Fraser.
2866
2867         Add trace points for the page RenderingUpdate.
2868
2869         * Tracing/SystemTracePoints.plist:
2870
2871 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2872
2873         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2874         https://bugs.webkit.org/show_bug.cgi?id=195353
2875         <rdar://problem/48626394>
2876
2877         Reviewed by Simon Fraser.
2878
2879         * WebKitTestRunner/ios/TestControllerIOS.mm:
2880         (WTR::TestController::platformResetPreferencesToConsistentValues):
2881
2882 2019-03-07  John Wilander  <wilander@apple.com>
2883
2884         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2885         https://bugs.webkit.org/show_bug.cgi?id=195383
2886         <rdar://problem/48570136>
2887
2888         Reviewed by Brent Fulgham.
2889
2890         This patch adds test infrastructure to purge only script-accessible cookies,
2891         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2892
2893         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2895         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2896         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::TestController::statisticsDeleteCookiesForHost):
2899         * WebKitTestRunner/TestController.h:
2900         * WebKitTestRunner/TestInvocation.cpp:
2901         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2902
2903 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2904
2905         Unreviewed, rolling out r242354.
2906         https://bugs.webkit.org/show_bug.cgi?id=195402
2907
2908         breaks layout tests in all configurations (Requested by
2909         zdobersek on #webkit).
2910
2911         Reverted changeset:
2912
2913         "[WPE] Enable web process sandbox"
2914         https://bugs.webkit.org/show_bug.cgi?id=195169
2915         https://trac.webkit.org/changeset/242354
2916
2917 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2918
2919         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2920         https://bugs.webkit.org/show_bug.cgi?id=195346
2921
2922         Reviewed by Fujii Hironori.
2923
2924         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2925         (TestWebKitAPI::TEST):
2926         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2927
2928         * DumpRenderTree/win/DumpRenderTree.cpp:
2929         (findFontFallback):
2930         (addFontFallbackIfPresent):
2931         (removeFontFallbackIfPresent):
2932         (main):
2933         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2934         (TestWebKitAPI::Util::moduleDirectory):
2935         (TestWebKitAPI::Util::createInjectedBundlePath):
2936         Use wchar helpers as needed.
2937
2938 2019-03-06  Rob Buis  <rbuis@igalia.com>
2939
2940         Consider supporting the `referrerpolicy` attribute.
2941         https://bugs.webkit.org/show_bug.cgi?id=179053
2942
2943         Reviewed by Darin Adler.
2944
2945         Add a runtime flag for referrerpolicy attribute.
2946
2947         * DumpRenderTree/mac/DumpRenderTree.mm:
2948         (enableExperimentalFeatures):
2949
2950 2019-03-05  Daniel Bates  <dabates@apple.com>
2951
2952         Update expected API test result following r242379
2953         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2954
2955         Update expected x-coordinate of selection rect now that the left padding of
2956         a textarea is sized in ems (so dependent on the font size) just like the left
2957         padding of a text field.
2958
2959         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2960         (TestWebKitAPI::TEST):
2961
2962 2019-03-05  David Quesada  <david_quesada@apple.com>
2963
2964         [WK2] It should be possible to follow links with 'download' attributes
2965         https://bugs.webkit.org/show_bug.cgi?id=195145
2966         rdar://problem/48462642
2967
2968         Reviewed by Alex Christensen.
2969
2970         Add a unit test to verify that activating links with 'download' attributes now
2971         navigates to the linked resource, rather than starts downloading it. Add another
2972         to verify that it is still possible to explicitly download the link via the
2973         'Download' navigation action policy.
2974
2975         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2976         (-[DownloadAttributeTestDelegate init]):
2977         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2978         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2979         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2980         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2981         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2982         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2983         (TEST):
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::TestController::decidePolicyForNavigationAction):
2986         * WebKitTestRunner/TestController.h:
2987
2988 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2989
2990         [Curl] Implement Cookie Accept Policy.
2991         https://bugs.webkit.org/show_bug.cgi?id=191645
2992
2993         Reviewed by Fujii Hironori.
2994
2995         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2996         (TestWebKitAPI::Curl::TEST_F):
2997
2998 2019-03-05  Youenn Fablet  <youenn@apple.com>
2999
3000         Rename requestCacheStorageSpace to requestStorageSpace
3001         https://bugs.webkit.org/show_bug.cgi?id=195282
3002
3003         Reviewed by Chris Dumez.
3004
3005         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3006         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3007         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3008
3009 2019-03-05  Brady Eidson  <beidson@apple.com>
3010
3011         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3012         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3013
3014         Reviewed by Tim Horton.
3015
3016         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3017         different directory into that same WKWebView should work.
3018
3019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3020         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3021
3022 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3023
3024         Add WeakHashSet
3025         https://bugs.webkit.org/show_bug.cgi?id=195152
3026
3027         Reviewed by Antti Koivisto.
3028
3029         Added tests for WeakHashSet.
3030
3031         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3032         (TestWebKitAPI::Base::Base): Moved.
3033         (TestWebKitAPI::Derived::foo): Moved.
3034         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3035         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3036         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3037         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3038
3039 2019-03-04  Chris Dumez  <cdumez@apple.com>
3040
3041         Do not share WebProcesses between private and regular sessions
3042         https://bugs.webkit.org/show_bug.cgi?id=195189
3043         <rdar://problem/48421064>
3044
3045         Reviewed by Alex Christensen.
3046
3047         Add API test coverage.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3050         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3051
3052 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3053
3054         [WPE] Enable web process sandbox
3055         https://bugs.webkit.org/show_bug.cgi?id=195169
3056
3057         Reviewed by Daniel Bates.
3058
3059         * wpe/install-dependencies:
3060         * wpe/jhbuild.modules:
3061
3062 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3063
3064         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3065         https://bugs.webkit.org/show_bug.cgi?id=195206
3066
3067         Reviewed by Žan Doberšek.
3068
3069         Add a new test case.
3070
3071         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3072         (testJSCClass):
3073
3074 2019-03-04  Charlie Turner  <cturner@igalia.com>
3075
3076         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3077         https://bugs.webkit.org/show_bug.cgi?id=194898
3078
3079         Reviewed by Žan Doberšek.
3080
3081         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3082         a GCC extension that permits arithmetic on void* pointer. Inline
3083         the macro until this issue is fixed upstream.
3084
3085 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3086
3087         Rid the world of WK_API_ENABLED
3088         https://bugs.webkit.org/show_bug.cgi?id=195263
3089
3090         Reviewed by Dan Bernstein.
3091
3092         List of changed files elided because it's useless.
3093
3094 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3095
3096         Unreviewed follow-up to r242292.
3097
3098         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3099
3100         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3101         (TestWebKitAPI::testStrip): Renamed from strip.
3102         (TestWebKitAPI::TEST):
3103
3104 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3105
3106         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3107
3108         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3109         and bug #194272 for details.
3110
3111         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3112
3113 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3114
3115         Remove some more unused 32-bit code
3116         https://bugs.webkit.org/show_bug.cgi?id=195255
3117
3118         Reviewed by Darin Adler.
3119
3120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3121         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3122         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3123         (NPP_New):
3124         (NPP_HandleEvent):
3125         (handleEventCarbon): Deleted.
3126
3127 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3128
3129         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3130
3131         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3132         (TestWebKitAPI::TEST):
3133
3134 2019-03-01  Darin Adler  <darin@apple.com>
3135
3136         Finish removing String::format
3137         https://bugs.webkit.org/show_bug.cgi?id=194893
3138
3139         Reviewed by Daniel Bates.
3140 '
3141         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3142
3143 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3144
3145         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3146         https://bugs.webkit.org/show_bug.cgi?id=195229
3147         <rdar://problem/48520362>
3148
3149         Reviewed by Chris Dumez.
3150
3151         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3152         (TEST):
3153
3154 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3155
3156         Add a system trace scope for event region building
3157         https://bugs.webkit.org/show_bug.cgi?id=195226
3158
3159         Reviewed by Jon Lee.
3160
3161         This trace scope measures the time spend converting element rects into Region objects,
3162         which can be large on some pages.
3163
3164         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3165
3166         * Tracing/SystemTracePoints.plist:
3167
3168 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3169
3170         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3171         https://bugs.webkit.org/show_bug.cgi?id=194612
3172
3173         Reviewed by Alex Christensen.
3174
3175         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3176         Just test the new string-processing function and don't touch the actual environment.
3177         (Test cases are all as before, but based on operator== instead of strcmp.)
3178
3179 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3180
3181         [ews-app] Update primary keys for handling multiple Buildbot instances
3182         https://bugs.webkit.org/show_bug.cgi?id=195120
3183
3184         Reviewed by Stephanie Lewis.
3185
3186         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3187         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3188         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3189
3190         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3191         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3192         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3193         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3194         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3195         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3196
3197 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3198
3199         [WinCairo] Enable service worker
3200         https://bugs.webkit.org/show_bug.cgi?id=188318
3201
3202         Reviewed by Youenn Fablet.
3203
3204         * DumpRenderTree/DumpRenderTreePrefix.h:
3205         * TestWebKitAPI/PlatformWin.cmake:
3206         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3207         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3208         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3209
3210 2019-03-01  Justin Fan  <justin_fan@apple.com>
3211
3212         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3213         https://bugs.webkit.org/show_bug.cgi?id=195191
3214
3215         Rubber-stamped by Dean Jackson.
3216
3217         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3218
3219         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3220
3221 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3222
3223         Unreviewed, fix lldb webkitpy tests
3224         https://bugs.webkit.org/show_bug.cgi?id=194375
3225
3226         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3227
3228         * lldb/lldb_webkit.py:
3229         (WTFStringImplProvider.is_8bit):
3230
3231 2019-02-28  David Quesada  <david_quesada@apple.com>
3232
3233         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3234         https://bugs.webkit.org/show_bug.cgi?id=195121
3235         rdar://problem/48450302
3236
3237         Reviewed by Alex Christensen.
3238
3239         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3240         configurations where the 'download' attribute is absent, blank, or populated
3241         with a filename, and where the anchor element is same-origin or cross-origin
3242         (meaning the 'download' attribute shouldn't be honored).
3243
3244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3245         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3246         (-[NavigationActionTestDelegate init]):
3247         (-[NavigationActionTestDelegate navigationAction]):
3248         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3249         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3250         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3251         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3252         (TEST):
3253
3254 2019-02-28  Antoine Quint  <graouts@apple.com>
3255
3256         Enable the Pointer Events runtime flag by default
3257         https://bugs.webkit.org/show_bug.cgi?id=195156
3258
3259         Reviewed by Dean Jackson.
3260
3261         * DumpRenderTree/mac/DumpRenderTree.mm:
3262         (enableExperimentalFeatures):
3263
3264 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3265
3266         Several PasteImage API tests are flaky
3267         https://bugs.webkit.org/show_bug.cgi?id=195160
3268
3269         Reviewed by Tim Horton.
3270
3271         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3272         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3273         listening for a "load" event after image load is already complete.
3274
3275         To address this, make these tests first register a "load" event handler, then run script to insert an image
3276         element into the document, and finally wait until the load event is observed before checking image size.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3279
3280 2019-02-28  Chris Dumez  <cdumez@apple.com>
3281
3282         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3283         https://bugs.webkit.org/show_bug.cgi?id=195107
3284
3285         Reviewed by Alex Christensen.
3286
3287         Give some time for the zoom level to get restored.
3288
3289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3290
3291 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3292
3293         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3294         https://bugs.webkit.org/show_bug.cgi?id=194958
3295
3296         Reviewed by Geoffrey Garen.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3299         (TEST):
3300
3301 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3302
3303         [ews-app] Update method to save build to handle builder_display_name
3304         https://bugs.webkit.org/show_bug.cgi?id=195047
3305
3306         Reviewed by Dewei Zhu.
3307
3308         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3309         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3310
3311 2019-02-28  Justin Fan  <justin_fan@apple.com>
3312
3313         [Web GPU] Enable Web GPU only on 64-bit
3314         https://bugs.webkit.org/show_bug.cgi?id=195139
3315
3316         Because Metal is only supported on 64 bit apps.
3317
3318         Unreviewed build fix.
3319
3320         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3321
3322 2019-02-27  Youenn Fablet  <youenn@apple.com>
3323
3324         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3325         https://bugs.webkit.org/show_bug.cgi?id=194959
3326
3327         Reviewed by Chris Dumez.
3328
3329         Spin loop until getting the condition to remove flakiness.
3330
3331         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3332
3333 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3334
3335         [ews-build] Buildbot should include builder_display_name in the build events
3336         https://bugs.webkit.org/show_bug.cgi?id=195045
3337
3338         Reviewed by Dewei Zhu.
3339
3340         * BuildSlaveSupport/ews-build/events.py:
3341         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3342         buildername to builder_name to be consistent in naming style.
3343         (Events.buildFinished): Ditto.
3344
3345 2019-02-27  Chris Dumez  <cdumez@apple.com>
3346
3347         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3348         https://bugs.webkit.org/show_bug.cgi?id=194480
3349
3350         Reviewed by Brady Eidson.
3351
3352         Update existing API test to make it more likely to reproduce the issue.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3355
3356 2019-02-27  Brady Eidson  <beidson@apple.com>
3357
3358         Universal links from Google search results pages don't open the app.
3359         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3360
3361         Reviewed by Geoffrey Garen.
3362
3363         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3364         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3365         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3366         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3367
3368 2019-02-27  Chris Dumez  <cdumez@apple.com>
3369
3370         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3371         https://bugs.webkit.org/show_bug.cgi?id=195102
3372
3373         Reviewed by Geoffrey Garen.
3374
3375         If the number of processes is not yet what we expect, wait a bit and check again to give
3376         processes some time to exit.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3379
3380 2019-02-27  Chris Dumez  <cdumez@apple.com>
3381
3382         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3383         https://bugs.webkit.org/show_bug.cgi?id=194545
3384
3385         Reviewed by Brady Eidson.
3386
3387         Make sure the test navigates forward and then back only once. Previously, navigating
3388         back would trigger a navigation again in a timer.
3389
3390         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3391
3392 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3393
3394         High Sierra Debug JSC test queue should use faster hardware
3395         https://bugs.webkit.org/show_bug.cgi?id=194603
3396
3397         Rubber-stamped by Alexey Proskuryakov.
3398
3399         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3400
3401         * BuildSlaveSupport/build.webkit.org-config/config.json:
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3403         (BubbleQueueServer):
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3405         (WebKitBuildbot):
3406         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3407         * QueueStatusServer/config/queues.py:
3408         * Scripts/webkitpy/common/config/ews.json:
3409         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3410         (test_ews_name):
3411
3412 2019-02-27  John Wilander  <wilander@apple.com>
3413
3414         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3415         https://bugs.webkit.org/show_bug.cgi?id=195071
3416         <rdar://problem/48417690>
3417
3418         Reviewed by Alex Christensen and Brent Fulgham.
3419
3420         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3421         (TestWebKitAPI::createURL):
3422             Convenience function.
3423         (TestWebKitAPI::TEST):
3424             WebCore::AdClickAttribution now takes a URL when creating Source and
3425             Destination.
3426         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3427         (TestWebKitAPI::TEST):
3428             WebCore::AdClickAttribution now takes a URL when creating Source and
3429             Destination.
3430
3431 2019-02-27  Antoine Quint  <graouts@apple.com>
3432
3433         Support Pointer Events on macOS
3434         https://bugs.webkit.org/show_bug.cgi?id=195008
3435         <rdar://problem/47454419>
3436
3437         Reviewed by Dean Jackson.
3438
3439         * DumpRenderTree/mac/DumpRenderTree.mm:
3440         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3442
3443 2019-02-26  Mark Lam  <mark.lam@apple.com>
3444
3445         Remove remaining poisoning code.
3446         https://bugs.webkit.org/show_bug.cgi?id=194138
3447
3448         Reviewed by Saam Barati.
3449
3450         * TestWebKitAPI/CMakeLists.txt:
3451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3452         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3453         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3454         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3455         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3456         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3457         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3458
3459 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3460
3461         Move ephemeral local storage from WebProcess to UIProcess
3462         https://bugs.webkit.org/show_bug.cgi?id=195074
3463         <rdar://problem/47937975>
3464
3465         Reviewed by Geoff Garen.
3466
3467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3468
3469 2019-02-20  Jer Noble  <jer.noble@apple.com>
3470
3471         [Cocoa] Media elements will restart network buffering just before suspending
3472         https://bugs.webkit.org/show_bug.cgi?id=193691
3473
3474         Reviewed by Eric Carlson.
3475
3476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3478         (TEST):
3479
3480 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3481
3482         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3483         https://bugs.webkit.org/show_bug.cgi?id=191652
3484
3485         Reviewed by Alex Christensen.
3486
3487         Fix WinCairo MiniBrowser behavior of authentication dialog.
3488
3489         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3490         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3491
3492 2019-02-26  Youenn Fablet  <youenn@apple.com>
3493
3494         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3495         https://bugs.webkit.org/show_bug.cgi?id=195028
3496         <rdar://problem/48243733>
3497
3498         Reviewed by Eric Carlson.
3499
3500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3501
3502 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3503
3504         [WPE] Add API for webview background color configuration
3505         https://bugs.webkit.org/show_bug.cgi?id=192305
3506
3507         Reviewed by Michael Catanzaro.
3508
3509         * MiniBrowser/wpe/main.cpp:
3510         (main): Add a new option to configure the webview background
3511         color. Example: --bg-color=transparent.
3512         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3513         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3514         (beforeAll): Ditto.
3515
3516 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3517
3518         scalableNativeWebpageParameters() is not preserved on new page navigation.
3519         https://bugs.webkit.org/show_bug.cgi?id=194892
3520         <rdar://problem/47538280>
3521
3522         Reviewed by Wenson Hsieh.
3523         
3524         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3525
3526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3527         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3528         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3529         (WTR::UIScriptController::allowsViewportShrinkToFit):
3530         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3531         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3532         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3533         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3534         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3535         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3536
3537 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3538
3539         [ews-app] Add model for handling multiple Buildbot instances
3540         https://bugs.webkit.org/show_bug.cgi?id=194863
3541
3542         Reviewed by Stephanie Lewis.
3543
3544         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3545
3546 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3547
3548         [ews-app] Remove BuilderMapping table
3549         https://bugs.webkit.org/show_bug.cgi?id=194961
3550
3551         Reviewed by Stephanie Lewis.
3552
3553         Store builder name directly in build table, instead of having a separate
3554         table for it.
3555
3556         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3557         * BuildSlaveSupport/ews-app/ews/models/build.py:
3558         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3559         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3560
3561 2019-02-25  John Wilander  <wilander@apple.com>
3562
3563         Introduce and adopt new class RegistrableDomain for eTLD+1
3564         https://bugs.webkit.org/show_bug.cgi?id=194791
3565         <rdar://problem/48179240>
3566
3567         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3568
3569         This patch adds an API test and replaces two instances of
3570         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3571
3572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3573         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3574         (TestWebKitAPI::TEST):
3575             Changed two strings to make sure the registrable domains are still considered
3576             invalid and pass the test.
3577         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3578         (TestWebKitAPI::TEST):
3579         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3580         (WTR::InjectedBundle::didReceiveMessageToPage):
3581
3582 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3583
3584         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3585         https://bugs.webkit.org/show_bug.cgi?id=195001
3586
3587         Reviewed by Carlos Garcia Campos.
3588
3589         API version 1.0 always includes the functionality previously guarded with
3590         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3591         unconditionally.
3592
3593         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3594         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3595         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3596         (WebViewTest::showInWindow): Ditto.
3597         (WebViewTest::hideView): Ditto.
3598         * wpe/backends/HeadlessViewBackend.cpp:
3599         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3600         * wpe/backends/ViewBackend.cpp:
3601         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3602         * wpe/backends/WindowViewBackend.cpp:
3603         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3604         WPE_BACKEND_CHECK_VERSION().
3605         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3606
3607 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3608
3609         [Flatpak] Add support for flatpak > 1.1.2
3610         https://bugs.webkit.org/show_bug.cgi?id=194088
3611
3612         Flatpak 1.2 is now out so we need to support that
3613         version now.
3614
3615         Reviewed by Michael Catanzaro.
3616
3617         * flatpak/flatpakutils.py:
3618         (check_flatpak):
3619         (FlatpakPackages.__init__):
3620         (FlatpakPackages.__detect_packages):
3621         (FlatpakPackages.__detect_packages.in):
3622         (FlatpakRepos.update):
3623
3624 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3625
3626         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3627         https://bugs.webkit.org/show_bug.cgi?id=194998
3628
3629         Reviewed by Carlos Garcia Campos.
3630
3631         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3632         to a Git checkout and using the latest commit containing various fixes
3633         and improvements.
3634
3635 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3636
3637         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3638         https://bugs.webkit.org/show_bug.cgi?id=194981
3639
3640         Reviewed by Žan Doberšek.
3641
3642         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3643         (TestWebKitAPI::TEST):
3644
3645 2019-02-23  Keith Miller  <keith_miller@apple.com>
3646
3647         Add new mac target numbers
3648         https://bugs.webkit.org/show_bug.cgi?id=194955
3649
3650         Reviewed by Tim Horton.
3651
3652         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3653         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3654         * MiniBrowser/Configurations/Base.xcconfig:
3655         * TestWebKitAPI/Configurations/Base.xcconfig:
3656         * WebKitTestRunner/Configurations/Base.xcconfig:
3657
3658 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3659
3660         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3661         https://bugs.webkit.org/show_bug.cgi?id=194846
3662
3663         Reviewed by Don Olmstead.
3664
3665         Added _search_paths() and _port_specific_expectations_files() for
3666         WinCairoPort.
3667
3668         * Scripts/webkitpy/port/win.py:
3669         (WinCairoPort.default_baseline_search_path):
3670         (WinCairoPort):
3671         (WinCairoPort._port_specific_expectations_files):
3672         (WinCairoPort._search_paths):
3673
3674 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3675
3676         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3677         https://bugs.webkit.org/show_bug.cgi?id=194963
3678
3679         Reviewed by Dean Jackson.
3680
3681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3682         Do a `contains` check instead of `equals`, because in debug builds we
3683         put the GraphicsLayer pointer in a prefix.
3684
3685 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3686
3687         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3688         https://bugs.webkit.org/show_bug.cgi?id=194873
3689         <rdar://problem/46701974>
3690
3691         Reviewed by Tim Horton.
3692
3693         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3694
3695         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3696         (WTR::UIScriptController::menuRect const):
3697         (WTR::UIScriptController::isShowingMenu const):
3698         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3699         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3700         (WTR::UIScriptController::menuRect const):
3701
3702         Add a function to query the bounds of the callout menu in content coordinates.
3703
3704         (WTR::UIScriptController::isShowingMenu const):
3705
3706         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3707
3708         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3709         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3710         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3711         (WTR::UIScriptController::rectForMenuAction const):
3712         (WTR::UIScriptController::menuRect const):
3713         (WTR::UIScriptController::isShowingMenu const):
3714         (WTR::findViewInHierarchyOfType): Deleted.
3715
3716 2019-02-22  Chris Dumez  <cdumez@apple.com>
3717
3718         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3719         https://bugs.webkit.org/show_bug.cgi?id=194954
3720         <rdar://problem/48127957>
3721
3722         Reviewed by Alex Christensen.
3723
3724         Add API test coverage.
3725
3726         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3727         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3728         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3729         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3730
3731 2019-02-22  Chris Dumez  <cdumez@apple.com>
3732
3733         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3734         https://bugs.webkit.org/show_bug.cgi?id=194924
3735         <rdar://problem/48216125>
3736
3737         Reviewed by Geoffrey Garen.
3738
3739         Add API test coverage.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3742
3743 2019-02-22  Chris Dumez  <cdumez@apple.com>
3744
3745         Unreviewed, disable API test added in r241928 on iOS.
3746
3747         The cache is not enabled on devices with less than 3GB of RAM.
3748
3749         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3750
3751 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3752
3753         Hardcode Visual Viewports on everywhere except iOS WK1
3754         https://bugs.webkit.org/show_bug.cgi?id=194928
3755
3756         Reviewed by Zalan Bujtas.
3757
3758         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3759         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3760         set it to false. The setting has shipped for several years and there's no need to turn
3761         it off now.
3762
3763         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3764         Visual Viewports are not enabled.
3765         
3766         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3767         that only runs in WK2
3768
3769         * MiniBrowser/mac/SettingsController.h:
3770         * MiniBrowser/mac/SettingsController.m:
3771         (-[SettingsController init]):
3772         (-[SettingsController _populateMenu]):
3773         (-[SettingsController validateMenuItem:]):
3774         (-[SettingsController visualViewportEnabled]): Deleted.
3775         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3776         * MiniBrowser/mac/WK1BrowserWindowController.m:
3777         (-[WK1BrowserWindowController didChangeSettings]):
3778         * MiniBrowser/mac/WK2BrowserWindowController.m:
3779         (-[WK2BrowserWindowController didChangeSettings]):
3780
3781 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3782
3783         Discard cached processes when clearing website data store
3784         https://bugs.webkit.org/show_bug.cgi?id=194894
3785
3786         Reviewed by Chris Dumez.
3787
3788         Added a test case.
3789
3790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3791         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3792
3793 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3794
3795         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3796         https://bugs.webkit.org/show_bug.cgi?id=194914
3797         <rdar://problem/47586889>
3798
3799         Reviewed by Geoffrey Garen.
3800
3801         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3802         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3803         (TEST):
3804         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3805
3806 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3807
3808         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3809         <https://webkit.org/b/194761>
3810
3811         Reviewed by Myles Maxfield.
3812
3813         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3814         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3815         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3816         to use ARC-compliant cast.
3817         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3818         ARC-compliant cast.
3819         (WTR::installFakeHelvetica): Log `error` to console if
3820         CTFontManagerRegisterFontsForURL() fails, but only on supported
3821         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3822         Call CFRelease() on `error` to fix the leak.  Update to use
3823         ARC-compliant cast.
3824         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3825         cast.
3826
3827 2019-02-21  Chris Dumez  <cdumez@apple.com>
3828
3829         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3830         https://bugs.webkit.org/show_bug.cgi?id=194481
3831
3832         Reviewed by Alex Christensen.
3833
3834         Give the processes a chance to shutdown and wait until we reached the expected number
3835         of processes.
3836
3837         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3838
3839 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3840
3841         Fix the macOS build
3842
3843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3844
3845 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3846
3847         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3850         I am a backwards.
3851
3852 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3853
3854         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3855
3856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3857         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3858         We could force on UI-side compositing, but I feel like the test might be more
3859         valuable exercising the normal path on each platform (though the original
3860         bug was also UI-side specific). Though we can't validate that the overlay
3861         layer was installed successfully, there are layout tests that do that.
3862
3863 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3864
3865         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3866         https://bugs.webkit.org/show_bug.cgi?id=194845
3867         <rdar://problem/47944579>
3868
3869         Reviewed by Antti Koivisto.
3870
3871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3873
3874 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3875
3876         [LFC][Floats] Add support for placing formatting roots in-between floats.
3877         https://bugs.webkit.org/show_bug.cgi?id=194902
3878
3879         Reviewed by Antti Koivisto.
3880
3881         * LayoutReloaded/misc/LFC-passing-tests.txt:
3882
3883 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3884
3885         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3886         https://bugs.webkit.org/show_bug.cgi?id=194901
3887
3888         Unreviewed build fix.
3889
3890         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3891         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3892         WPEBackend-fdo-0.1 as library name.
3893
3894 2019-02-21  Rob Buis  <rbuis@igalia.com>
3895
3896         Update MIME type parser
3897         https://bugs.webkit.org/show_bug.cgi?id=180526
3898
3899         Reviewed by Darin Adler.
3900
3901         Add tests involving leading and trailing whitespace, non-token
3902         characters and quoted strings.
3903
3904         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3905         (TestWebKitAPI::TEST):
3906
3907 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3908
3909         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3910         https://bugs.webkit.org/show_bug.cgi?id=194884
3911
3912         Reviewed by Michael Catanzaro.
3913
3914         * PlatformWin.cmake:
3915
3916 2019-02-20  Chris Dumez  <cdumez@apple.com>
3917
3918         Add API test for <rdar://problem/47471222>
3919         https://bugs.webkit.org/show_bug.cgi?id=194847
3920
3921         Reviewed by Alex Christensen.
3922
3923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3924
3925 2019-02-20  Chris Dumez  <cdumez@apple.com>
3926
3927         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3928         https://bugs.webkit.org/show_bug.cgi?id=194872
3929         <rdar://problem/47924500>
3930
3931         Reviewed by Alex Christensen.
3932
3933         Add API test coverage.
3934
3935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3936
3937 2019-02-20  Jer Noble  <jer.noble@apple.com>
3938
3939         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3940         https://bugs.webkit.org/show_bug.cgi?id=191332
3941
3942         Reviewed by Dean Jackson.
3943
3944         * Scripts/git-is-in-range: Added.
3945
3946 2019-02-20  Andy Estes  <aestes@apple.com>
3947
3948         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3949         https://bugs.webkit.org/show_bug.cgi?id=194869
3950
3951         Rubber-stamped by Jer Noble.
3952
3953         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3954         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3955         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3956         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3958         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3959
3960 2019-02-20  Chris Dumez  <cdumez@apple.com>
3961
3962         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3963         https://bugs.webkit.org/show_bug.cgi?id=194857
3964         <rdar://problem/47759323>
3965
3966         Reviewed by Alex Christensen.
3967
3968         Add API test coverage.
3969
3970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3971
3972 2019-02-20  Chris Dumez  <cdumez@apple.com>
3973
3974         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3975         https://bugs.webkit.org/show_bug.cgi?id=194829
3976         <rdar://problem/47889906>
3977
3978         Reviewed by Alexey Proskuryakov.
3979
3980         Every time the TestOptions were changing we were creating both a new Web view and
3981         a new WKContext, which would start a new Network process. In most cases, we only
3982         need to contruct a new Web view and we do can keep reusing the same WKContext.
3983         This patch implements this optimization and thus avoids spinning a lot of new
3984         Network processes while running the layout tests.
3985
3986         * WebKitTestRunner/TestController.cpp:
3987         (WTR::TestController::generateContextConfiguration const):
3988         (WTR::TestController::generatePageConfiguration):
3989         (WTR::TestController::createWebViewWithOptions):
3990         (WTR::TestController::resetPreferencesToConsistentValues):
3991         (WTR::updateTestOptionsFromTestHeader):
3992         * WebKitTestRunner/TestController.h:
3993         * WebKitTestRunner/TestOptions.h:
3994         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3995         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3996         (WTR::TestOptions::hasSameInitializationOptions const):
3997         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3998         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3999         (WTR::TestController::platformAddTestOptions const):
4000
4001 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4002
4003         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4004         https://bugs.webkit.org/show_bug.cgi?id=167941
4005
4006         Reviewed by Carlos Garcia Campos.
4007
4008         * MiniBrowser/gtk/main.c:
4009         (filterSavedCallback): Added.
4010         (main): Support loading a JSON rule set file for content filtering.
4011         * MiniBrowser/wpe/main.cpp:
4012         (filterSavedCallback): Added.
4013         (main): Support loading a JSON rule set file for content filtering.
4014         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4015         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4016         (WTF::derefGPtr): Ditto.
4017         (testEmptyStore):
4018         (testSaveInvalidFilter):
4019         (testSaveLoadFilter):
4020         (testSavedFilterIdentifierMatch):
4021         (testRemoveFilter):
4022         (testSaveMultipleFilters):
4023         (testSaveFilterFromFile):
4024         (testFilterPersistence):
4025         (beforeAll):
4026         (afterAll):
4027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4028         (removeOldInjectedContentAndResetLists): Also reset content filters.
4029         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4030         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4031         the element affected by the style sheet.
4032         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4033         and returns it to be used by tests.
4034         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4035         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4036         (serverCallback): Add support for serving a CSS style sheet for testing.
4037         (beforeAll): Add call to testUserContentManagerContentFilter().
4038         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4039
4040 2019-02-19  Keith Rollin  <krollin@apple.com>
4041
4042         Add timing information to build output
4043         https://bugs.webkit.org/show_bug.cgi?id=194839
4044         <rdar://problem/48219609>
4045
4046         Reviewed by Alexey Proskuryakov.
4047
4048         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4049         emit each project's build time to its output. E.g.,
4050
4051             ** BUILD SUCCEEDED ** [0.132 sec]
4052
4053         * Scripts/webkitdirs.pm:
4054         (XcodeOptions):
4055
4056 2019-02-19  Truitt Savell  <tsavell@apple.com>
4057
4058         Unreviewed, rolling out r241784.
4059
4060         Broke all OpenSource builds.
4061
4062         Reverted changeset:
4063
4064         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4065         instances view"
4066         https://bugs.webkit.org/show_bug.cgi?id=172848
4067         https://trac.webkit.org/changeset/241784
4068
4069 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4070
4071         [LFC][Floats] Remove redundant intersecting logic
4072         https://bugs.webkit.org/show_bug.cgi?id=194804
4073
4074         Reviewed by Antti Koivisto.
4075
4076         * LayoutReloaded/misc/LFC-passing-tests.txt:
4077
4078 2019-02-19  Dean Jackson  <dino@apple.com>
4079
4080         Clean-up output from generate-xcfilelists so it can be filtered
4081         https://bugs.webkit.org/show_bug.cgi?id=194795
4082
4083         Reviewed by Joseph Pecoraro (and Keith Rollin).
4084
4085         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4086         make a slight tweak to filter-build-webkit so such lines are marked
4087         as plain.
4088
4089         * Scripts/filter-build-webkit:
4090         * Scripts/generate-xcfilelists:
4091
4092 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4093
4094         pytest is not correctly auto-installed
4095         https://bugs.webkit.org/show_bug.cgi?id=194707
4096
4097         Reviewed by Carlos Garcia Campos.
4098
4099         * Scripts/webkitpy/thirdparty/__init__.py:
4100         (AutoinstallImportHook._install_pytest):
4101
4102 2019-02-18  Chris Dumez  <cdumez@apple.com>
4103
4104         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4105         https://bugs.webkit.org/show_bug.cgi?id=194797
4106         <rdar://problem/48055151>
4107
4108         Reviewed by Geoffrey Garen.
4109
4110         Add API test coverage.
4111
4112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4113
4114 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4115
4116         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4117         https://bugs.webkit.org/show_bug.cgi?id=194670
4118         <rdar://problem/39066529>
4119
4120         Reviewed by Tim Horton.
4121
4122         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4123         pasted in an editable area as attachment elements.
4124
4125         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4126         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4127         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4129         (TestWebKitAPI::TEST):
4130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4131         (WTR::InjectedBundlePage::InjectedBundlePage):
4132
4133 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4134
4135         Fix API test after r241728
4136        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4137
4138         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4139         (TEST):
4140         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4141
4142 2019-02-18  Daniel Bates  <dabates@apple.com>
4143
4144         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4145         https://bugs.webkit.org/show_bug.cgi?id=192824
4146         <rdar://problem/47100332>
4147
4148         Reviewed by Wenson Hsieh.
4149
4150         Fix a bug where the wrong usage code was used for F13 thru F24.
4151
4152         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4153         (keyCodeForDOMFunctionKey):
4154
4155 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4156
4157         Bytecode cache should a have a boot-specific validation
4158         https://bugs.webkit.org/show_bug.cgi?id=194769
4159         <rdar://problem/48149509>
4160
4161         Reviewed by Keith Miller.
4162
4163         Add test for WTF::bootSessionUUIDString()
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4167         (TEST):
4168
4169 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4170
4171         Disable safe browsing in WKWebView and remove its WKPreferences API
4172         https://bugs.webkit.org/show_bug.cgi?id=194723
4173         <rdar://problem/48122993>
4174
4175         Reviewed by Geoffrey Garen.
4176
4177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4178         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4179         (TEST):
4180         (safeBrowsingView):
4181         Make tests use SPI instead of API.
4182
4183 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4184
4185         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4186         https://bugs.webkit.org/show_bug.cgi?id=194586
4187
4188         Reviewed by Ross Kirsling.
4189
4190         * DumpRenderTree/win/DumpRenderTree.cpp:
4191         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4192         * Scripts/webkitpy/port/driver.py:
4193         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4194
4195 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4196
4197         Unreviewed, rolling out r241620.
4198
4199         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4200         (Requested by ddkilzer on #webkit.)
4201
4202         Reverted changeset:
4203
4204         "[WTF] Add environment variable helpers"
4205         https://bugs.webkit.org/show_bug.cgi?id=192405
4206         https://trac.webkit.org/changeset/241620
4207
4208 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4209
4210         [LFC] RenderImage's default intrinsic size is 0.
4211         https://bugs.webkit.org/show_bug.cgi?id=194745
4212
4213         Reviewed by Antti Koivisto.
4214
4215         * LayoutReloaded/misc/LFC-passing-tests.txt:
4216
4217 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4218
4219         [LFC][BFC] Add support for block replaced intrinsic width.
4220         https://bugs.webkit.org/show_bug.cgi?id=194705
4221
4222         Reviewed by Simon Fraser.
4223
4224         * LayoutReloaded/misc/LFC-passing-tests.txt:
4225
4226 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4227
4228         [LFC] Apply min/max width constraints to preferred width computation
4229         https://bugs.webkit.org/show_bug.cgi?id=194739
4230
4231         Reviewed by Simon Fraser.
4232
4233         * LayoutReloaded/misc/LFC-passing-tests.txt:
4234
4235 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4236
4237         [WTF] Add environment variable helpers
4238         https://bugs.webkit.org/show_bug.cgi?id=192405
4239
4240         Reviewed by Michael Catanzaro.
4241
4242         * DumpRenderTree/mac/DumpRenderTree.mm:
4243         (libraryPathForDumpRenderTree):
4244         * DumpRenderTree/win/DumpRenderTree.cpp:
4245         (libraryPathForDumpRenderTree):
4246         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4247         (setUpIOSLayoutTestCommunication):
4248         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4249         (beforeAll):
4250         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4251         (main):
4252         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4253         (WebKitTestBus::run):
4254         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4255         (WTR::getOutputDir):
4256         (WTR::initializeFontConfigSetting):
4257         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4258         (WTR::InjectedBundle::platformInitialize):
4259         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4260         (WTR::topLevelPath):
4261         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4262         (WTR::topLevelPath):
4263         (WTR::getOutputDir):
4264         (WTR::activateFonts):
4265         * WebKitTestRunner/TestController.cpp:
4266         (WTR::TestController::libraryPathForTesting):
4267         (WTR::TestController::generateContextConfiguration const):
4268         (WTR::TestController::generatePageConfiguration):
4269         (WTR::TestController::decideDestinationWithSuggestedFilename):
4270         (WTR::TestController::platformAdjustContext):
4271         * WebKitTestRunner/TestController.h:
4272         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4273         (WTR::TestController::cocoaPlatformInitialize):
4274         (WTR::TestController::platformAdjustContext):
4275         * WebKitTestRunner/gtk/main.cpp:
4276         (main):
4277         * WebKitTestRunner/mac/TestControllerMac.mm:
4278         (WTR::TestController::configureContentExtensionForTest):
4279         * WebKitTestRunner/wpe/main.cpp:
4280         (main):
4281         Utilize WTF::Environment where possible.
4282
4283 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4284
4285         [iOS] WKWebView callout bar is missing Change Writing Direction item
4286         https://bugs.webkit.org/show_bug.cgi?id=190015
4287         <rdar://problem/44810366>
4288
4289         Reviewed by Tim Horton.
4290
4291         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4292         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4293
4294         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4295         (TestWebKitAPI::TEST):
4296
4297 2019-02-15  Chris Dumez  <cdumez@apple.com>
4298
4299         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4300         https://bugs.webkit.org/show_bug.cgi?id=194717
4301         <rdar://problem/47884404>
4302
4303         Reviewed by Brady Eidson.
4304
4305         Add API test coverage.
4306
4307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4308
4309 2019-02-15  Youenn Fablet  <youenn@apple.com>
4310
4311         Make navigator.mediaDevices SecureContext
4312         https://bugs.webkit.org/show_bug.cgi?id=194666
4313
4314         Reviewed by Eric Carlson.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4317         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4318         (TEST_F):
4319
4320 2019-02-15  Brian Burg  <bburg@apple.com>
4321
4322         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4323         https://bugs.webkit.org/show_bug.cgi?id=194411
4324         <rdar://problem/47787614>
4325
4326         Reviewed by Joseph Pecoraro.
4327
4328         Remove unnecessary soft linking macro usage.
4329
4330         * DumpRenderTree/mac/TestRunnerMac.mm:
4331         (TestRunner::inspectorTestStubURL):
4332         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4333         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4334         (WTR::TestRunner::inspectorTestStubURL):
4335
4336 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4337
4338         Unreviewed, rolling out r241559 and r241566.
4339         https://bugs.webkit.org/show_bug.cgi?id=194710
4340
4341         Causes layout test crashes under GuardMalloc (Requested by
4342         ryanhaddad on #webkit).
4343
4344         Reverted changesets:
4345
4346         "[WTF] Add environment variable helpers"
4347         https://bugs.webkit.org/show_bug.cgi?id=192405
4348         https://trac.webkit.org/changeset/241559
4349
4350         "Unreviewed build fix for WinCairo Debug after r241559."
4351         https://trac.webkit.org/changeset/241566
4352
4353 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4354
4355         [LFC] Out-of-flow box is never a float box
4356         https://bugs.webkit.org/show_bug.cgi?id=194704
4357
4358         Reviewed by Antti Koivisto.
4359
4360         * LayoutReloaded/misc/LFC-passing-tests.txt:
4361
4362 2019-02-10  Darin Adler  <darin@apple.com>