[WPE] Forward libepoxy cflags
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-10  Charlie Turner  <cturner@igalia.com>
2
3         [WPE] Forward libepoxy cflags
4         https://bugs.webkit.org/show_bug.cgi?id=197784
5
6         Reviewed by Žan Doberšek.
7
8         Patch by Zan Dobersek.
9
10         * wpe/backends/CMakeLists.txt: This is required to keep
11         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
12         up trying to include X11 headers even when they're not present in the
13         environment.
14
15 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
16
17         Fix a bunch of compiler warnings
18         https://bugs.webkit.org/show_bug.cgi?id=197785
19
20         Reviewed by Don Olmstead.
21
22         Add preprocessor guards to avoid -Wunused-function warnings.
23
24         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
25         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
26         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
27
28 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
29
30         [WPE][GTK] Add webkit_frame_get_id() API
31         https://bugs.webkit.org/show_bug.cgi?id=197270
32
33         Reviewed by Carlos Garcia Campos.
34
35         This was hard, but I added a test to verify that two different WebKitFrames of the same
36         WebKitWebPage return two different frame IDs.
37
38         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
39         (WebKitFrameTest::willSubmitFormCallback):
40         (WebKitFrameTest::testSubframe):
41         (registerTests):
42         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
43         (testWebKitFrameSubframe):
44         (beforeAll):
45         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
46         (willSubmitFormCallback):
47         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
48         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
49
50 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
51
52         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
53         https://bugs.webkit.org/show_bug.cgi?id=197271
54
55         Reviewed by Youenn Fablet.
56
57         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
58         (formControlsAssociatedForFrameCallback):
59         (pageCreatedCallback):
60         (formControlsAssociatedCallback): Deleted.
61
62 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
63
64         [Flatpak] Use the safe PyYAML loader if available
65         https://bugs.webkit.org/show_bug.cgi?id=197771
66
67         Reviewed by Philippe Normand.
68
69         * flatpak/flatpakutils.py:
70         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
71         still used as fallback when the former is not provided by the module.
72
73 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
74
75         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
76         https://bugs.webkit.org/show_bug.cgi?id=197734
77
78         Reviewed by Don Olmstead.
79
80         * Scripts/webkitpy/port/win.py:
81         (WinCairoPort._search_paths): Add 'wk2' and
82         additional_platform_directory to paths as well as other ports do.
83
84 2019-05-09  Daniel Bates  <dabates@apple.com>
85
86         [iOS] Numpad comma key has incorrect keyIdentifier property
87         https://bugs.webkit.org/show_bug.cgi?id=197753
88         <rdar://problem/50636274>
89
90         Reviewed by Brent Fulgham.
91
92         Recognize "numpadComma" and return the appropriate HID usage code.
93
94         * WebKitTestRunner/ios/HIDEventGenerator.mm:
95         (hidUsageCodeForCharacter):
96
97 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
98
99         Refine AudioSession route sharing policy
100         https://bugs.webkit.org/show_bug.cgi?id=197742
101         <rdar://problem/50590818>
102
103         Reviewed by Darin Adler.
104
105         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
106         (TestWebKitAPI::TEST):
107
108 2019-05-09  Alex Christensen  <achristensen@webkit.org>
109
110         Remove unnecessary test SPI after r244883
111         https://bugs.webkit.org/show_bug.cgi?id=197575
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
116         (TEST):
117         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
118         (TestWebKitAPI::TEST):
119
120 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
121
122         [ews-app] Add migrations file to repository
123         https://bugs.webkit.org/show_bug.cgi?id=197729
124
125         Reviewed by Jonathan Bedard.
126
127         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
128
129 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
130
131         [ews-build] Fix formatting issues and typos
132         https://bugs.webkit.org/show_bug.cgi?id=197737
133
134         Reviewed by Jonathan Bedard.
135
136         * BuildSlaveSupport/ews-build/steps.py:
137         (CompileWebKit.evaluateCommand): Removed extra empty line.
138         * BuildSlaveSupport/ews-build/steps_unittest.py:
139         (TestRunWebKitPerlTests): Fixed typo.
140         * BuildSlaveSupport/ews-app/ews/models/step.py:
141         (Step.save_step): Changed log level to info so that it is logged in production.
142
143 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
144
145         [ews-app] Production and Development env should configure DEBUG appropriately
146         https://bugs.webkit.org/show_bug.cgi?id=197700
147
148         Reviewed by Jonathan Bedard.
149
150         * BuildSlaveSupport/ews-app/ews-app/settings.py:
151
152 2019-05-09  Xan López  <xan@igalia.com>
153
154         [CMake] Detect SSE2 at compile time
155         https://bugs.webkit.org/show_bug.cgi?id=196488
156
157         Reviewed by Carlos Garcia Campos.
158
159         * Scripts/webkitdirs.pm:
160         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
161         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
162
163 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
164
165         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
166         https://bugs.webkit.org/show_bug.cgi?id=197697
167
168         Reviewed by Žan Doberšek.
169
170         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
171         * wpe/jhbuild.modules: Ditto.
172
173 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
174
175         Update ANGLE
176         https://bugs.webkit.org/show_bug.cgi?id=197676
177
178         Reviewed by Alex Christensen.
179
180         * TestWebKitAPI/PlatformWin.cmake:
181         Remove unnecessary library linkage.
182
183 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
184
185         [Win] build-webkit should be ready for Visual Studio 2019
186         https://bugs.webkit.org/show_bug.cgi?id=196622
187
188         Reviewed by Ross Kirsling.
189
190         1. Accommodated to the new msbuild.exe location of VS 2019.
191         2. Removed the hard coded "Visual Studio 15" generator.
192
193         build-webkit is going to choose a Visual Studio generator version
194         matching with the latest installed VS. If you invoke vcvars.bat
195         before build-webkit, it chooses the corresponding Visual Studio
196         generator version by cheking 'VisualStudioVersion' env var which
197         is set by vcvars.bat.
198
199         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
200         (msBuildPath): When looking for MSBuild, look in
201         "MSBuild\Current\bin" (the new expected location) and fallback
202         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
203         first location.
204         (msBuildInstallDir): Renamed to msBuildPath.
205         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
206         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
207
208 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
209
210         [PlayStation] Update port options
211         https://bugs.webkit.org/show_bug.cgi?id=197723
212
213         Reviewed by Ross Kirsling.
214
215         ICU headers were missing from TestWTF.
216
217         * TestWebKitAPI/PlatformPlayStation.cmake:
218
219 2019-05-08  Alex Christensen  <achristensen@webkit.org>
220
221         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
222         https://bugs.webkit.org/show_bug.cgi?id=197712
223         <rdar://problem/50429770>
224
225         Reviewed by Tim Horton.
226
227         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
228         (TestWebKitAPI::TEST):
229
230 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
231
232         Change my status to be a WebKit reviewer.
233
234         * Scripts/webkitpy/common/config/contributors.json:
235
236 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
237
238         Unreviewed, rolling out r244952.
239
240         Caused inspector to appear blank.
241
242         Reverted changeset:
243
244         "Web Inspector: Provide UIString descriptions to improve
245         localizations"
246         https://bugs.webkit.org/show_bug.cgi?id=195132
247         https://trac.webkit.org/changeset/244952
248
249 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
252         https://bugs.webkit.org/show_bug.cgi?id=197685
253
254         Reviewed by Alex Christensen.
255
256         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
257         completion. See LayoutTests/ChangeLog for more details.
258
259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
260         (WTR::UIScriptController::platformClearAllCallbacks):
261
262 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
263
264         Unreviewed. Add myself as a committer.
265
266         * Scripts/webkitpy/common/config/contributors.json:
267
268 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
269
270         Unreviewed, rolling out r245038.
271
272         Breaks internal builds.
273
274         Reverted changeset:
275
276         "Add SPI to set a list of hosts to which to send custom header
277         fields cross-origin"
278         https://bugs.webkit.org/show_bug.cgi?id=197397
279         https://trac.webkit.org/changeset/245038
280
281 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
282
283         Unreviewed. Add myself as a committer.
284
285         * Scripts/webkitpy/common/config/contributors.json:
286
287 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
288
289         Define media buffering policy
290         https://bugs.webkit.org/show_bug.cgi?id=196979
291         <rdar://problem/28383861>
292
293         Reviewed by Jer Noble.
294
295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
296         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
297         (waitUntilBufferingPolicyIsEqualTo):
298         (TEST):
299
300 2019-05-07  Alex Christensen  <achristensen@webkit.org>
301
302         Add SPI to set a list of hosts to which to send custom header fields cross-origin
303         https://bugs.webkit.org/show_bug.cgi?id=197397
304
305         Reviewed by Geoff Garen.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
308         (TEST):
309         (expectLegacyHeaders):
310         (expectHeaders):
311         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
312         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
313         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
314
315 2019-05-07  Keith Rollin  <krollin@apple.com>
316
317         Add option to build-webkit to control whether or not XCBuild is used
318         https://bugs.webkit.org/show_bug.cgi?id=197668
319         <rdar://problem/50549728>
320
321         Reviewed by Tim Horton.
322
323         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
324         Also update build-webkit and the makefiles with the foundation for
325         automatically using XCBuild when the conditions allow it. This latter
326         facility is currently turned off until Xcode fully supports building
327         WebKit with XCBuild.
328
329         * Scripts/build-webkit:
330         * Scripts/webkitdirs.pm:
331         (XcodeOptions):
332         (canUseXCBuild):
333
334 2019-05-07  Andy Estes  <aestes@apple.com>
335
336         run-bindings-tests should test global scope constructor generation
337         https://bugs.webkit.org/show_bug.cgi?id=197669
338
339         Reviewed by Alex Christensen.
340
341         * Scripts/webkitpy/bindings/main.py:
342         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
343         invoking preprocess-idls.pl.
344
345 2019-05-07  Youenn Fablet  <youenn@apple.com>
346
347         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
348         https://bugs.webkit.org/show_bug.cgi?id=195997
349         <rdar://problem/50509884>
350
351         Reviewed by Chris Dumez.
352
353         Spin test until successful.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
356
357 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
358
359         [Flatpak] webkit-build fails due to missing GTK2 in build environment
360         https://bugs.webkit.org/show_bug.cgi?id=197352
361
362         Reviewed by Philippe Normand.
363
364         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
365         to build it ourselves on top in order to be able to build the GTK 2.x plugin
366         process.
367
368         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
369
370 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
371
372         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
373         https://bugs.webkit.org/show_bug.cgi?id=197644
374         <rdar://problem/50526364>
375
376         Reviewed by Tim Horton.
377
378         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
379
380         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
381         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
382         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
383         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
384
385 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
386
387         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
388         https://bugs.webkit.org/show_bug.cgi?id=197651
389
390         Reviewed by Žan Doberšek.
391
392         This is required since the process creation was delayed until something is loaded in the view.
393
394         * MiniBrowser/gtk/BrowserWindow.c:
395         (browser_window_get_or_create_web_view_for_automation):
396         * MiniBrowser/wpe/main.cpp:
397         (main):
398
399 2019-05-06  Tim Horton  <timothy_horton@apple.com>
400
401         _overrideViewportWithArguments does not work when called before loading
402         https://bugs.webkit.org/show_bug.cgi?id=197638
403         <rdar://problem/50505111>
404
405         Reviewed by Wenson Hsieh.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
408         (TEST):
409
410 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
411
412         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
413         https://bugs.webkit.org/show_bug.cgi?id=197510
414
415         Reviewed by Alex Christensen.
416
417         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
418         (TestWebKitAPI::TEST):
419
420 2019-05-06  Keith Rollin  <krollin@apple.com>
421
422         Temporarily disable generate-xcfilelists
423         https://bugs.webkit.org/show_bug.cgi?id=197619
424         <rdar://problem/50507392>
425
426         Reviewed by Alex Christensen.
427
428         We need to perform a significant update to the generate-xcfilelist
429         scripts. This work involves coordinated work with another facility. If
430         the work does not occur in tandem, the build will be broken. To avoid
431         this, disable the invoking of the scripts during the transition. The
432         checking will be restored once the new scripts are in place.
433
434         * DumpRenderTree/Scripts/check-xcfilelists.sh:
435         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
436
437 2019-05-04  Alex Christensen  <achristensen@webkit.org>
438
439         Revert r244953 and r244954 because they broke internal builds.
440         https://bugs.webkit.org/show_bug.cgi?id=197534
441
442         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
443         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
444         * DumpRenderTree/mac/DumpRenderTree.mm:
445         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
446         * DumpRenderTree/mac/TestRunnerMac.mm:
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
449         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
450         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
451         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
452         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
453         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
454         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
455         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
456         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
457         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
458         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
459         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
460         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
461         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
462         * TestWebKitAPI/cocoa/TestWKWebView.mm:
463         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
464         * TestWebKitAPI/ios/UIKitSPI.h: Added.
465         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
466         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
467         * WebKitTestRunner/ios/HIDEventGenerator.h:
468         * WebKitTestRunner/ios/HIDEventGenerator.mm:
469         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
470         * WebKitTestRunner/ios/TestControllerIOS.mm:
471         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
472         * WebKitTestRunner/ios/mainIOS.mm:
473
474 2019-05-04  Alex Christensen  <achristensen@webkit.org>
475
476         Merge the three UIKitSPI.h files into a single one in PAL
477         https://bugs.webkit.org/show_bug.cgi?id=197534
478
479         Reviewed by Darin Adler.
480
481         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
482         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
483         * DumpRenderTree/mac/DumpRenderTree.mm:
484         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
485         * DumpRenderTree/mac/TestRunnerMac.mm:
486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
487         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
488         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
489         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
490         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
491         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
492         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
493         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
494         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
495         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
496         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
497         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
498         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
499         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
500         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
501         * TestWebKitAPI/cocoa/TestWKWebView.mm:
502         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
503         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
504         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
505         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
506         * WebKitTestRunner/ios/HIDEventGenerator.h:
507         * WebKitTestRunner/ios/HIDEventGenerator.mm:
508         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
509         * WebKitTestRunner/ios/TestControllerIOS.mm:
510         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
511         * WebKitTestRunner/ios/mainIOS.mm:
512
513 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
514
515         Web Inspector: Provide UIString descriptions to improve localizations
516         https://bugs.webkit.org/show_bug.cgi?id=195132
517         <rdar://problem/48457817>
518
519         Reviewed by Devin Rousso.
520
521         Allow WI.UIString to take:
522         - WI.UIString(string, key, comment)
523         - WI.UIString(string, comment)
524         - WI.UIString(string)
525
526         * Scripts/extract-localizable-js-strings:
527
528 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
531         https://bugs.webkit.org/show_bug.cgi?id=197579
532
533         Reviewed by Tim Horton.
534
535         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
536         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
537         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
538         ensure that the the focused element has been blurred.
539
540         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
541
542 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
543
544         Add a tool to block spammer accounts
545         https://bugs.webkit.org/show_bug.cgi?id=197537
546
547         Reviewed by Darin Adler.
548
549         Usage: block-spammers email1 email2 ...
550
551         The tool finds and hides all bugs and comments from this account. Before any work
552         is done, these bugs and comments are displayed for confirmation.
553
554         * Scripts/block-spammers: Added.
555         (get_bugzilla_token):
556         (invalidate_bugzilla_token):
557         (get_user_info):
558         (get_user_info_self):
559         (can_use_this_tool):
560         (disable_user):
561         (get_bugs_created_by_user):
562         (get_bugs_commented_on_by_user):
563         (get_comments):
564         (hide_bug):
565         (hide_comments):
566         (ask_yes_no):
567         (sanitized_string):
568         (main):
569
570 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
571
572         run-apit-tests: Add --iterations and --repeat-each
573         https://bugs.webkit.org/show_bug.cgi?id=197563
574
575         Reviewed by Aakash Jain.
576
577         * Scripts/webkitpy/api_tests/manager.py:
578         (Manager.run): Add --iterations and --repeat-each/
579         * Scripts/webkitpy/api_tests/run_api_tests.py:
580         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
581
582 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
583
584         New EWS: Clicking on white bubble navigates to page with only bubbles
585         https://bugs.webkit.org/show_bug.cgi?id=197520
586
587         Reviewed by Lucas Forschler.
588
589         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
590
591 2019-05-03  Daniel Bates  <dabates@apple.com>
592
593         [lldb-webkit] Support adding pretty-printing for qualified types
594         https://bugs.webkit.org/show_bug.cgi?id=197518
595
596         Reviewed by Darin Adler.
597
598         Remove all "::"s from the name of the specified type when computing the name for the Python classes
599         that will provide summary and synthetic details as LLDB is not happy about registering such classes
600         when they contain :: in their name.
601
602         * lldb/lldb_webkit.py:
603         (addSummaryAndSyntheticFormattersForRawBitmaskType):
604
605 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
606
607         New EWS: patches on recently added queues listed as #1 for older bugs
608         https://bugs.webkit.org/show_bug.cgi?id=197496
609
610         Reviewed by Lucas Forschler.
611
612         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
613         (StatusBubble._build_bubble):
614         (StatusBubble._queue_position):
615
616 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
617
618         webkit-patch --no-review upload does not submit patch to New EWS
619         https://bugs.webkit.org/show_bug.cgi?id=197519
620         <rdar://problem/50424887>
621
622         Reviewed by Lucas Forschler.
623
624         * Scripts/webkitpy/tool/steps/submittoews.py:
625         (SubmitToEWS.run): Submit to both old and new EWS.
626         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
627         * Scripts/webkitpy/common/net/ewsserver.py: Added.
628         (EWSServer._server_url): Method to return server url.
629         (EWSServer._post_patch_to_ews): Method to post patch to ews.
630         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
631         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
632         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
633         * Scripts/webkitpy/common/net/statusserver_mock.py:
634         (MockStatusServer.submit_to_ews): Updated the log text.
635         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
636         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
637         * Scripts/webkitpy/tool/main.py:
638         (WebKitPatch.__init__): Initialize ews_server. 
639         * Scripts/webkitpy/tool/mocktool.py:
640         (MockTool.__init__): Ditto.
641
642 2019-05-03  Chris Dumez  <cdumez@apple.com>
643
644         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
645         https://bugs.webkit.org/show_bug.cgi?id=197574
646         <rdar://problem/50453181>
647
648         Reviewed by Tim Horton.
649
650         Add API test coverage.
651
652         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
653         (TEST):
654
655 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
656
657         [JSC] Generator CodeBlock generation should be idempotent
658         https://bugs.webkit.org/show_bug.cgi?id=197552
659
660         Reviewed by Keith Miller.
661
662         * Scripts/run-javascriptcore-tests:
663         (runJSCStressTests):
664         * Scripts/run-jsc-stress-tests:
665
666 2019-05-03  Commit Queue  <commit-queue@webkit.org>
667
668         Unreviewed, rolling out r244881.
669         https://bugs.webkit.org/show_bug.cgi?id=197559
670
671         Breaks compilation of jsconly on linux, breaking compilation
672         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
673         guijemont on #webkit).
674
675         Reverted changeset:
676
677         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
678         WEBKIT_COPY_FILES"
679         https://bugs.webkit.org/show_bug.cgi?id=197174
680         https://trac.webkit.org/changeset/244881
681
682 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
683
684         Unreviewed WPE build fix after r244898.
685
686         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
687         (WTR::TestController::abortModal): Add the missing (no-op) definition.
688
689 2019-05-02  Alex Christensen  <achristensen@webkit.org>
690
691         Mark U+01C0 as a homograph of U+006C
692         https://bugs.webkit.org/show_bug.cgi?id=197526
693         <rdar://problem/50301904>
694
695         Reviewed by Tim Horton.
696
697         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
698         (TestWebKitAPI::TEST):
699
700 2019-05-02  Chris Dumez  <cdumez@apple.com>
701
702         Add test coverage for <rdar://problem/49731231>
703         https://bugs.webkit.org/show_bug.cgi?id=196730
704         <rdar://problem/49731231>
705
706         Reviewed by Ryosuke Niwa.
707
708         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
709         to match DumpRenderTree.
710
711         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
713         (WTR::TestRunner::abortModal):
714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::TestController::runModal):
717         * WebKitTestRunner/TestController.h:
718         * WebKitTestRunner/TestInvocation.cpp:
719         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
720         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
721         (WTR::TestController::abortModal):
722         * WebKitTestRunner/ios/TestControllerIOS.mm:
723         (WTR::TestController::abortModal):
724         * WebKitTestRunner/mac/TestControllerMac.mm:
725         (WTR::TestController::abortModal):
726         * WebKitTestRunner/win/TestControllerWin.cpp:
727         (WTR::TestController::abortModal):
728
729 2019-05-02  Christopher Reid  <chris.reid@sony.com>
730
731         [CMake] Add support for LTO builds
732         https://bugs.webkit.org/show_bug.cgi?id=188986
733
734         Reviewed by Don Olmstead.
735
736         Add support to configure --lto-mode with cmake builds.
737
738         * Scripts/build-webkit:
739         * Scripts/webkitdirs.pm:
740         (generateBuildSystemFromCMakeProject):
741
742 2019-05-02  John Wilander  <wilander@apple.com>
743
744         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
745         https://bugs.webkit.org/show_bug.cgi?id=197521
746         <rdar://problem/49651503>
747
748         Reviewed by Brent Fulgham.
749
750         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
751         (TestWebKitAPI::TEST):
752            Added a test for host strings with leading dots since they are
753            often used for the domain attribute in cookies.
754
755 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
756
757         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
758         https://bugs.webkit.org/show_bug.cgi?id=197510
759
760         Reviewed by Alex Christensen.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
763         (TestWebKitAPI::TEST):
764
765 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
766
767         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
768         https://bugs.webkit.org/show_bug.cgi?id=197174
769
770         Reviewed by Alex Christensen.
771
772         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
773
774         * TestWebKitAPI/PlatformGTK.cmake:
775         * TestWebKitAPI/PlatformWPE.cmake:
776
777 2019-05-02  Alex Christensen  <achristensen@webkit.org>
778
779         Build fix for internal branch.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
782         RetainPtr.h was not explicitly included.
783
784 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
785
786         webkitpy: Ignore errors when shutting down an already shutdown simulator
787         <https://bugs.webkit.org/show_bug.cgi?id=197514>
788         <rdar://problem/50390247>
789
790         Reviewed by Lucas Forschler.
791
792         * Scripts/webkitpy/xcode/simulated_device.py:
793         (SimulatedDevice._shut_down):
794
795 2019-05-02  Frederic Wang  <fwang@igalia.com>
796
797         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
798         https://bugs.webkit.org/show_bug.cgi?id=196142
799
800         This patch introduces some experimental runtime flag to let users
801         disable MathML features that are removed from MathML Core [1]. For now,
802         these features are only disabled on GTK and WPE ports.
803
804         [1] https://mathml-refresh.github.io/mathml-core/
805
806         Reviewed by Rob Buis.
807
808         * DumpRenderTree/TestOptions.cpp:
809         (TestOptions::TestOptions):
810         * DumpRenderTree/TestOptions.h:
811         * DumpRenderTree/mac/DumpRenderTree.mm:
812         (setWebPreferencesForTestOptions):
813
814 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
815
816         TestWebKitAPI config.h should be aware of what suite is being built
817         https://bugs.webkit.org/show_bug.cgi?id=196583
818
819         Reviewed by Konstantin Tokarev.
820
821         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
822         benefit the macro defines BUILDING_* for the executable which allows the includes
823         of the config.h to be tailored to the test suite being built. Because of that the
824         dependencies of the Test* executable are specific to the test suite which may
825         speed up the build.
826
827         Some source files were including "PlatformUtilities.h" which includes WebKit headers
828         when "Utilities.h" is what was needed.
829
830         * TestWebKitAPI/CMakeLists.txt:
831         * TestWebKitAPI/PlatformGTK.cmake:
832         * TestWebKitAPI/PlatformJSCOnly.cmake:
833         * TestWebKitAPI/PlatformMac.cmake:
834         * TestWebKitAPI/PlatformPlayStation.cmake:
835         * TestWebKitAPI/PlatformUtilities.h:
836         * TestWebKitAPI/PlatformWPE.cmake:
837         * TestWebKitAPI/PlatformWin.cmake:
838         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
839         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
840         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
841         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
842         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
843         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
844         * TestWebKitAPI/config.h:
845
846 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
847
848         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
849         https://bugs.webkit.org/show_bug.cgi?id=181950
850         <rdar://problem/43357371>
851
852         Reviewed by Brent Fulgham.
853
854         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
855         (TestWebKitAPI::TEST_F):
856
857 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
858
859         Remove webkitpy and bindings EWS queues from dashboard
860         https://bugs.webkit.org/show_bug.cgi?id=197475
861
862         Reviewed by Alexey Proskuryakov.
863
864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
865
866 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
867
868         Remove webkitpy and bindings test queues from old EWS
869         https://bugs.webkit.org/show_bug.cgi?id=197468
870
871         Reviewed by Alexey Proskuryakov.
872
873         * QueueStatusServer/config/queues.py:
874
875 2019-04-30  Tim Horton  <timothy_horton@apple.com>
876
877         Fix the WebKitTestRunner build
878         https://bugs.webkit.org/show_bug.cgi?id=197449
879         <rdar://problem/50334169>
880
881         Reviewed by Alexey Proskuryakov.
882
883         * WebKitTestRunner/mac/EventSenderProxy.mm:
884         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
885         (WTR::EventSenderProxy::mouseForceChanged):
886         Use some SPI instead of IPI.
887
888 2019-04-30  Chris Dumez  <cdumez@apple.com>
889
890         Regression(PSON) URL scheme handlers can no longer respond asynchronously
891         https://bugs.webkit.org/show_bug.cgi?id=197426
892         <rdar://problem/50256169>
893
894         Reviewed by Brady Eidson.
895
896         Add API test coverage.
897
898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
899         (-[PSONScheme setShouldRespondAsynchronously:]):
900         (-[PSONScheme webView:startURLSchemeTask:]):
901         (-[PSONScheme webView:stopURLSchemeTask:]):
902
903 2019-04-30  Chris Dumez  <cdumez@apple.com>
904
905         Unreviewed, rolling out r244802.
906
907         Caused an API test failure
908
909         Reverted changeset:
910
911         "Regression(PSON) URL scheme handlers can no longer respond
912         asynchronously"
913         https://bugs.webkit.org/show_bug.cgi?id=197426
914         https://trac.webkit.org/changeset/244802
915
916 2019-04-30  Chris Dumez  <cdumez@apple.com>
917
918         Regression(PSON) URL scheme handlers can no longer respond asynchronously
919         https://bugs.webkit.org/show_bug.cgi?id=197426
920         <rdar://problem/50256169>
921
922         Reviewed by Brady Eidson.
923
924         Add API test coverage.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
927         (-[PSONScheme setShouldRespondAsynchronously:]):
928         (-[PSONScheme webView:startURLSchemeTask:]):
929         (-[PSONScheme webView:stopURLSchemeTask:]):
930
931 2019-04-30  Chris Dumez  <cdumez@apple.com>
932
933         Only use a related page's process if that page has not been closed yet
934         https://bugs.webkit.org/show_bug.cgi?id=197393
935         <rdar://problem/50302423>
936
937         Reviewed by Tim Horton.
938
939         Add API test coverage.
940
941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
942
943 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
944
945         [ews-build] Enable Bindings tests queue on new EWS
946         https://bugs.webkit.org/show_bug.cgi?id=197424
947
948         Reviewed by Lucas Forschler.
949
950         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
951         (StatusBubble):
952         * BuildSlaveSupport/ews-build/config.json:
953
954 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
955
956         [ews-build] Configure ews151 for running various tests
957         https://bugs.webkit.org/show_bug.cgi?id=197419
958
959         Reviewed by Lucas Forschler.
960
961         * BuildSlaveSupport/ews-build/config.json:
962
963 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-build] Parse and display bindings test failures
966         https://bugs.webkit.org/show_bug.cgi?id=197423
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-build/steps.py:
971         (RunBindingsTests.__init__): Set timeout of 5 minutes.
972         (RunBindingsTests.start): Initialize log_observer for json output.
973         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
974         (RunBindingsTests._addToLog): Method to add message to log.
975         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
976
977 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
978
979         Unreviewed. Add myself as a committer.
980
981         * Scripts/webkitpy/common/config/contributors.json:
982
983 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
984
985         [ews-build] Enable webkitpy queue on new EWS
986         https://bugs.webkit.org/show_bug.cgi?id=197396
987
988         Reviewed by Lucas Forschler.
989
990         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
991         (StatusBubble):
992         * BuildSlaveSupport/ews-build/config.json:
993
994 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
995
996         [ews-build] Parse and display webkitpy failures
997         https://bugs.webkit.org/show_bug.cgi?id=197395
998
999         Reviewed by Lucas Forschler.
1000
1001         * BuildSlaveSupport/ews-build/steps.py:
1002         (RunWebKitPyTests.start): Initialize log_observer for json output.
1003         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1004         (RunWebKitPyTests._addToLog): Method to add message to log.
1005         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1006
1007 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1008
1009         <rdar://problem/50299396> Fix internal High Sierra build
1010         https://bugs.webkit.org/show_bug.cgi?id=197388
1011
1012         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1013         * MiniBrowser/Configurations/Base.xcconfig:
1014         * MobileMiniBrowser/Configurations/Base.xcconfig:
1015         * TestWebKitAPI/Configurations/Base.xcconfig:
1016         * WebKitTestRunner/Configurations/Base.xcconfig:
1017
1018 2019-04-29  Youenn Fablet  <youenn@apple.com>
1019
1020         Remove spurious GVA printf logging
1021         https://bugs.webkit.org/show_bug.cgi?id=197368
1022         <rdar://problem/35975256>
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         * Scripts/webkitpy/port/mac.py:
1027         (MacPort.logging_patterns_to_strip):
1028
1029 2019-04-29  Youenn Fablet  <youenn@apple.com>
1030
1031         getDisplayMedia should be called on user gesture
1032         https://bugs.webkit.org/show_bug.cgi?id=197356
1033         <rdar://problem/50296074>
1034
1035         Reviewed by Eric Carlson.
1036
1037         Update test configuration to inject internals
1038         so that we can use it to simulate a user click to call getDisplayMedia.
1039
1040         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1041         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1042         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1043
1044 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1045
1046         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1047         https://bugs.webkit.org/show_bug.cgi?id=197339
1048
1049         Reviewed by Dewei Zhu.
1050
1051         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1052         test run for setup steps that are too expensive to do every iteration.
1053
1054         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1055         (BenchmarkRunner._run_benchmark):
1056         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1057         (BrowserDriver):
1058         (BrowserDriver.prepare_initial_env):
1059         (BrowserDriver.restore_env_after_all_testing):
1060         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1061         (LinuxBrowserDriver.prepare_initial_env):
1062         (LinuxBrowserDriver.restore_env_after_all_testing):
1063         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1064         (OSXBrowserDriver.prepare_initial_env):
1065         (OSXBrowserDriver.restore_env_after_all_testing):
1066
1067 2019-04-28  Andy Estes  <aestes@apple.com>
1068
1069         Fix the watchOS engineering build.
1070
1071         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1072         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1073
1074 2019-04-27  Chris Dumez  <cdumez@apple.com>
1075
1076         [WKTR] Move test timeout handling to the UIProcess
1077         https://bugs.webkit.org/show_bug.cgi?id=197333
1078
1079         Reviewed by Darin Adler.
1080
1081         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1082         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1083         every WebContent process in the case of swapping.
1084
1085         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1086         would lead to crashes when firing the timer.
1087
1088         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1089         (WTR::InjectedBundle::didReceiveMessageToPage):
1090         (WTR::InjectedBundle::done):
1091         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1092         (WTR::InjectedBundle::shouldDumpPixels const):
1093         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1094         (WTR::TestRunner::TestRunner):
1095         (WTR::TestRunner::waitUntilDone):
1096         (WTR::TestRunner::setWaitUntilDone):
1097         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1098         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1099         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1100         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1101         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1102         * WebKitTestRunner/TestInvocation.cpp:
1103         (WTR::TestInvocation::TestInvocation):
1104         (WTR::TestInvocation::createTestSettingsDictionary):
1105         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1106         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1107         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1108         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1109         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1110         (WTR::TestInvocation::setWaitUntilDone):
1111         (WTR::TestInvocation::done):
1112         * WebKitTestRunner/TestInvocation.h:
1113
1114 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1115
1116         [JSC] linkPolymorphicCall now does GC
1117         https://bugs.webkit.org/show_bug.cgi?id=197306
1118
1119         Reviewed by Saam Barati.
1120
1121         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1122         To add this test, we add `runWithoutBaseOption`.
1123
1124         * Scripts/run-jsc-stress-tests:
1125
1126 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1127
1128         Update inactive reviewers' status to 'contributor'.
1129
1130         Accidentally skipped one at first.
1131
1132         * Scripts/webkitpy/common/config/contributors.json:
1133
1134 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1135
1136         Update inactive reviewers' status to 'contributor'.
1137
1138         * Scripts/webkitpy/common/config/contributors.json: The change.
1139
1140         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1141         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1142         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1143         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1144         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1145         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1146         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1147         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1148         Sadly, regression tests operate on a crazy mix of mock and live data for
1149         contributors.json. It would be a substantial project to mock all code paths,
1150         so changing the tests instead.
1151
1152 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1153
1154         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1155         https://bugs.webkit.org/show_bug.cgi?id=197171
1156         <rdar://problem/47454979>
1157
1158         Reviewed by Youenn Fablet.
1159
1160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1161         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1162         (TestWebKitAPI::TEST):
1163
1164 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1165
1166         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1167         <https://webkit.org/b/197314>
1168         <rdar://problem/50245252>
1169
1170         Reviewed by Simon Fraser.
1171
1172         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1173         (WTR::UIScriptController::lastUndoLabel const):
1174         (WTR::UIScriptController::firstRedoLabel const):
1175         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1176
1177         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1178         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1179         - Call -autorelease to fix leak of NSDictionary.
1180
1181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1182         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1183         (WTR::UIScriptController::selectFormPopoverTitle const):
1184         (WTR::UIScriptController::textContentType const):
1185         (WTR::UIScriptController::formInputLabel const):
1186         (WTR::UIScriptController::scrollingTreeAsText const):
1187         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1188
1189 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1190
1191         webkitpy: Running a single test will always use the default device
1192         https://bugs.webkit.org/show_bug.cgi?id=195472
1193         <rdar://problem/48724825>
1194
1195         Reviewed by Lucas Forschler.
1196
1197         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1198         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1199         requested will be run regardless of what shard they are in.
1200
1201         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1202         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1203         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1204         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1205         on the default device type.
1206         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1207         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1208         (RunTest.test_run_part): Ditto.
1209
1210 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1211
1212         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1213         https://bugs.webkit.org/show_bug.cgi?id=197165
1214
1215         Reviewed by Youenn Fablet.
1216
1217         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1218
1219 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1220
1221         Replace iOS build queue hardware
1222         https://bugs.webkit.org/show_bug.cgi?id=197312
1223
1224         Reviewed by Aakash Jain.
1225
1226         * BuildSlaveSupport/build.webkit.org-config/config.json:
1227         Use newer hardware that supports macOS Mojave.
1228
1229 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1230
1231         check-webkit-style complains the first block in while loop.
1232         https://bugs.webkit.org/show_bug.cgi?id=197307
1233
1234         The style checker shouldn't complain about an open brace on
1235         its own line if the last non-whitespace character on the previous
1236         non-blank line is another open brace, because it's likely to
1237         indicate the begining of a nested code block.
1238
1239         Reviewed by Alex Christensen.
1240
1241         * Scripts/webkitpy/style/checkers/cpp.py:
1242         (check_braces):
1243         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1244         (WebKitStyleTest.test_braces):
1245
1246 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1247
1248         Stop IDB transactions to release locked database files when network process is ready to suspend
1249         https://bugs.webkit.org/show_bug.cgi?id=196372
1250         <rdar://problem/48930116>
1251
1252         Reviewed by Brady Eidson.
1253
1254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1255         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1256         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1257         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1258         (runTestAndCheckResult):
1259         (keepNetworkProcessActive):
1260         (TEST):
1261
1262 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1263
1264         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1265         https://bugs.webkit.org/show_bug.cgi?id=188357
1266         <rdar://problem/42986633>
1267
1268         Reviewed by Dean Jackson.
1269
1270         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1271         tests would fall into low memory mode and have different behavior.
1272         
1273         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1274         to Internals, so it's shared by DRT and WTR.
1275         
1276         We no longer need the WK2 C SPI glue.
1277
1278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1279         (WTR::InjectedBundlePage::prepare):
1280
1281 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1282
1283         webkitpy: Including skipped tests in the final count
1284         https://bugs.webkit.org/show_bug.cgi?id=197298
1285         <rdar://problem/49705424>
1286
1287         Reviewed by Lucas Forschler.
1288
1289         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1290         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1291
1292 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1293
1294         Disable date and time inputs on iOSMac.
1295         https://bugs.webkit.org/show_bug.cgi?id=197287
1296         rdar://problem/46794376
1297
1298         Reviewed by Wenson Hsieh.
1299
1300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1301
1302 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1303
1304         Fix test-webkitpy after r244653
1305         https://bugs.webkit.org/show_bug.cgi?id=197131
1306
1307         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1308         Also use C++17.
1309
1310 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1311
1312         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1313         https://bugs.webkit.org/show_bug.cgi?id=196991
1314         <rdar://problem/45507423>
1315
1316         Reviewed by Alex Christensen.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1319         (-[NavigationTestDelegate init]):
1320         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1321         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1322         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1323         (TestWebKitAPI::TEST):
1324         (TEST): Deleted.
1325
1326 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1327
1328         Revert some code accidentally committed with r244653
1329         https://bugs.webkit.org/show_bug.cgi?id=197131
1330
1331         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1332         (TestWebKitAPI::TEST):
1333
1334 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1335
1336         Start using C++17
1337         https://bugs.webkit.org/show_bug.cgi?id=197131
1338
1339         Reviewed by Darin Adler.
1340
1341         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1342         * MiniBrowser/Configurations/Base.xcconfig:
1343         * MobileMiniBrowser/Configurations/Base.xcconfig:
1344         * TestWebKitAPI/Configurations/Base.xcconfig:
1345         * WebKitTestRunner/Configurations/Base.xcconfig:
1346
1347 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1348
1349         Unreviewed, rolling out r244627.
1350         https://bugs.webkit.org/show_bug.cgi?id=197282
1351
1352         Causing internal build failures (Requested by ShawnRoberts on
1353         #webkit).
1354
1355         Reverted changeset:
1356
1357         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1358         https://bugs.webkit.org/show_bug.cgi?id=197171
1359         https://trac.webkit.org/changeset/244627
1360
1361 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1362
1363         [GTK] Hardcoded text color in input fields
1364         https://bugs.webkit.org/show_bug.cgi?id=126907
1365
1366         Reviewed by Michael Catanzaro.
1367
1368         Add dark-mode command line option to MiniBrowser.
1369
1370         * MiniBrowser/gtk/main.c:
1371         (main):
1372
1373 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1374
1375         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1376         https://bugs.webkit.org/show_bug.cgi?id=196948
1377         <rdar://problem/49927131>
1378
1379         Reviewed by Tim Horton.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1382         (TEST):
1383         The expected order of incoming events is
1384         1. didInvalidateIntrinsicContentSize
1385         2. didFirstLayout
1386         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1387         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1388         (and remember, all we care about is ordering).
1389
1390 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1391
1392         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1393         https://bugs.webkit.org/show_bug.cgi?id=197171
1394         <rdar://problem/47454979>
1395
1396         Reviewed by Youenn Fablet.
1397
1398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1399         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1400         (TestWebKitAPI::TEST):
1401
1402 2019-04-24  Brady Eidson  <beidson@apple.com>
1403
1404         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1405         https://bugs.webkit.org/show_bug.cgi?id=191362
1406
1407         Reviewed by Alex Christensen.
1408
1409         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1410           from an XHR to a custom protocol.
1411
1412 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1413
1414         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1415         https://bugs.webkit.org/show_bug.cgi?id=197273
1416
1417         Reviewed by Dean Jackson.
1418
1419         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1420         so that WebCoreTestSupport::resetInternalsObject() is always run.
1421
1422         * DumpRenderTree/mac/DumpRenderTree.mm:
1423         (resetWebViewToConsistentStateBeforeTesting):
1424         (runTest):
1425
1426 2019-04-24  John Wilander  <wilander@apple.com>
1427
1428         Age out unconverted Ad Click Attributions after one week.
1429         https://bugs.webkit.org/show_bug.cgi?id=197238
1430         <rdar://problem/50177349>
1431
1432         Reviewed by Chris Dumez.
1433
1434         This patch adds infrastructure to allow tests to expire all unconverted
1435         attributions early.
1436
1437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1438         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1439         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1441         * WebKitTestRunner/TestController.cpp:
1442         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1443         * WebKitTestRunner/TestController.h:
1444         * WebKitTestRunner/TestInvocation.cpp:
1445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1446
1447 2019-04-24  Chris Dumez  <cdumez@apple.com>
1448
1449         Fix flaky crashes in a couple of PSON API tests
1450         https://bugs.webkit.org/show_bug.cgi?id=197239
1451
1452         Reviewed by Tim Horton.
1453
1454         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1457
1458 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1459
1460         Make it possible to control the renderTreeAsText output by setting options on testRunner
1461         https://bugs.webkit.org/show_bug.cgi?id=197133
1462
1463         Reviewed by Sam Weinig.
1464
1465         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1466         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1467         these flags through the various framework layers.
1468
1469         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1470
1471         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1472         and hand-code DumpRenderTree bindings.
1473
1474         Some cleanup of the TestRunners, using member initializers.
1475
1476         * DumpRenderTree/TestRunner.cpp:
1477         (TestRunner::TestRunner):
1478         (setRenderTreeDumpOptionsCallback):
1479         (TestRunner::staticFunctions):
1480         (TestRunner::setRenderTreeDumpOptions):
1481         * DumpRenderTree/TestRunner.h:
1482         (TestRunner::renderTreeDumpOptions const):
1483         * DumpRenderTree/mac/DumpRenderTree.mm:
1484         (dump):
1485         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1486         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1487         (WTR::InjectedBundlePage::dump):
1488         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1489         (WTR::TestRunner::TestRunner):
1490         (WTR::TestRunner::setRenderTreeDumpOptions):
1491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1492         (WTR::TestRunner::renderTreeDumpOptions const):
1493
1494 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1495
1496         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1497         https://bugs.webkit.org/show_bug.cgi?id=197078
1498         <rdar://problem/49564348>
1499
1500         Reviewed by Geoff Garen.
1501
1502         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1503         (TEST_F):
1504         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1505         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1506         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1507
1508 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1509
1510         Add unit test for r239322
1511         https://bugs.webkit.org/show_bug.cgi?id=197236
1512
1513         Reviewed by Chris Dumez.
1514
1515         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1516         May as well add the test infrastructure which was needed before and will be needed in the future.
1517
1518         * TestWebKitAPI/TCPServer.cpp:
1519         (TestWebKitAPI::TCPServer::TCPServer):
1520         * TestWebKitAPI/TCPServer.h:
1521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1522         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1523         (TestWebKitAPI::TEST):
1524         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1525         (TestWebKitAPI::downloadAtRate):
1526         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1527         (TEST):
1528         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1529         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1530         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1533         (TEST):
1534
1535 2019-04-24  Chris Dumez  <cdumez@apple.com>
1536
1537         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1538         https://bugs.webkit.org/show_bug.cgi?id=197214
1539         <rdar://problem/49237544>
1540
1541         Reviewed by Alex Christensen.
1542
1543         Extend API test coverage.
1544
1545         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1546         (TEST):
1547
1548 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1549
1550         [Build][GStreamer] Update to 1.16.0
1551         https://bugs.webkit.org/show_bug.cgi?id=197157
1552
1553         Reviewed by Xabier Rodriguez-Calvar.
1554
1555         The upstreamed patches were removed and a new one was added for a
1556         regression detected in the scaletempo GStreamer element. The GNOME
1557         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1558         on the way, as it is the preferred build system now in GStreamer
1559         1.16.
1560
1561         * flatpak/files/httpd-autogen.sh:
1562         * flatpak/flatpakutils.py:
1563         (FlatpakPackage.install):
1564         (WebkitFlatpak.run_in_sandbox):
1565         * flatpak/org.webkit.CommonModules.yaml:
1566         * flatpak/org.webkit.WebKit.yaml:
1567         * gstreamer/jhbuild.modules:
1568         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1569         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1570         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1571         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1572         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1573         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1574         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1575         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1576         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1577         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1578         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1579         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1580         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1581         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1582         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1583         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1584         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1585         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1586         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1587         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1588         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1589         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1590
1591 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1592
1593         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1594         https://bugs.webkit.org/show_bug.cgi?id=197156
1595
1596         Reviewed by Michael Catanzaro.
1597
1598         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1599         support was added.
1600
1601         * MiniBrowser/gtk/BrowserTab.c:
1602         (browser_tab_set_background_color): Set the passed in color as web view background color.
1603         * MiniBrowser/gtk/BrowserTab.h:
1604         * MiniBrowser/gtk/BrowserWindow.c:
1605         (browser_window_init): Initialize backgroundColor.
1606         (browser_window_append_view): Call browser_tab_set_background_color().
1607         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1608         are added.
1609         * MiniBrowser/gtk/main.c:
1610         (main): Call browser_window_set_background_color() before creating the tabs.
1611
1612 2019-04-23  John Wilander  <wilander@apple.com>
1613
1614         Move Ad Click Attribution from internal feature to experimental feature
1615         https://bugs.webkit.org/show_bug.cgi?id=197218
1616         <rdar://problem/47651691>
1617
1618         Reviewed by Brent Fulgham.
1619
1620         * DumpRenderTree/TestOptions.cpp:
1621         (TestOptions::TestOptions):
1622
1623 2019-04-23  Andy Estes  <aestes@apple.com>
1624
1625         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1626         https://bugs.webkit.org/show_bug.cgi?id=196749
1627         <rdar://problem/35773454>
1628
1629         Reviewed by Daniel Bates.
1630
1631         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1632
1633         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1634         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1635         (-[QuickLookDelegate webView:didFinishNavigation:]):
1636         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1637         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1638         (runTest):
1639         (runTestDecideBeforeLoading):
1640         (runTestDecideAfterLoading):
1641         (TEST):
1642
1643 2019-04-23  John Wilander  <wilander@apple.com>
1644
1645         Remove Ad Click Attribution data when removing website data
1646         https://bugs.webkit.org/show_bug.cgi?id=197215
1647         <rdar://problem/47668988>
1648
1649         Reviewed by Chris Dumez.
1650
1651         This patch adds test infrastructure to delete Ad Click Attribution data
1652         through WebsiteDataStore::removeData().
1653
1654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1656         (WTR::TestRunner::clearAdClickAttribution):
1657         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1658         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1659         * WebKitTestRunner/TestController.cpp:
1660         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1661         * WebKitTestRunner/TestController.h:
1662         * WebKitTestRunner/TestInvocation.cpp:
1663         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1664
1665 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1666
1667         webkitpy: Kill unresponsive worker processes
1668         https://bugs.webkit.org/show_bug.cgi?id=197205
1669         <rdar://problem/50104388>
1670
1671         Reviewed by Lucas Forschler.
1672
1673         * Scripts/webkitpy/common/message_pool.py:
1674         (_MessagePool.__init__): Add close timeout.
1675         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1676
1677 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1678
1679         Add unit tests for WKWebView.serverTrust
1680         https://bugs.webkit.org/show_bug.cgi?id=197202
1681
1682         Reviewed by Youenn Fablet
1683
1684         * TestWebKitAPI/TCPServer.cpp:
1685         (TestWebKitAPI::deleter<BIO>::operator()):
1686         (TestWebKitAPI::deleter<SSL>::operator()):
1687         (TestWebKitAPI::deleter<X509>::operator()):
1688         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1689         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1690         (TestWebKitAPI::TCPServer::TCPServer):
1691         (TestWebKitAPI::TCPServer::listenForConnections):
1692         * TestWebKitAPI/TCPServer.h:
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1695         (TestWebKitAPI::TEST):
1696         (verifyCertificateAndPublicKey):
1697         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1698         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1699         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1700         (TestWebKitAPI::downloadAtRate):
1701         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1702         (TEST):
1703         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1704         (TEST):
1705
1706 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1707
1708         Unreviewed, rolling out r244556.
1709         https://bugs.webkit.org/show_bug.cgi?id=197212
1710
1711         Causing build failures on multiple builders (Requested by
1712         ShawnRoberts on #webkit).
1713
1714         Reverted changeset:
1715
1716         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1717         https://bugs.webkit.org/show_bug.cgi?id=197171
1718         https://trac.webkit.org/changeset/244556
1719
1720 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1721
1722         Fix iOS build.
1723         https://bugs.webkit.org/show_bug.cgi?id=195537
1724
1725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1726         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1727         AdoptWK constructor is private now.  Use adoptWK instead.
1728
1729 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1730
1731         Accessibility text search and selection API enhancements.
1732         https://bugs.webkit.org/show_bug.cgi?id=197095
1733         <rdar://problem/48181791>
1734
1735         Reviewed by Chris Fleizach.
1736
1737         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1738
1739         * DumpRenderTree/AccessibilityTextMarker.h:
1740         * DumpRenderTree/AccessibilityUIElement.cpp:
1741         (searchTextWithCriteriaCallback):
1742         (AccessibilityUIElement::getJSClass):
1743         * DumpRenderTree/AccessibilityUIElement.h:
1744         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1745         (convertVectorToObjectArray):
1746         (convertNSArrayToVector):
1747         (searchTextParameterizedAttributeForCriteria):
1748         (AccessibilityUIElement::getLinkedUIElements):
1749         (AccessibilityUIElement::getDocumentLinks):
1750         (AccessibilityUIElement::getChildren):
1751         (AccessibilityUIElement::getChildrenWithRange):
1752         (AccessibilityUIElement::rowHeaders const):
1753         (AccessibilityUIElement::columnHeaders const):
1754         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1755         (AccessibilityUIElement::searchTextWithCriteria):
1756         (AccessibilityUIElement::attributesOfColumnHeaders):
1757         (AccessibilityUIElement::attributesOfRowHeaders):
1758         (AccessibilityUIElement::attributesOfColumns):
1759         (AccessibilityUIElement::attributesOfRows):
1760         (AccessibilityUIElement::attributesOfVisibleCells):
1761         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1762         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1763         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1764         (WTR::convertVectorToObjectArray):
1765         (WTR::convertNSArrayToVector):
1766         (WTR::searchTextParameterizedAttributeForCriteria):
1767         (WTR::AccessibilityUIElement::getLinkedUIElements):
1768         (WTR::AccessibilityUIElement::getDocumentLinks):
1769         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1770         (WTR::AccessibilityUIElement::getChildren):
1771         (WTR::AccessibilityUIElement::getChildrenWithRange):
1772         (WTR::AccessibilityUIElement::rowHeaders const):
1773         (WTR::AccessibilityUIElement::columnHeaders const):
1774         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1775         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1776         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1777         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1778         (WTR::AccessibilityUIElement::attributesOfColumns):
1779         (WTR::AccessibilityUIElement::attributesOfRows):
1780         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1781         (WTR::convertElementsToObjectArray): Deleted.
1782
1783 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1784
1785         Multiple File Input Icon Set Regardless of File List
1786         https://bugs.webkit.org/show_bug.cgi?id=195537
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1791         display string in iOS file inputs
1792
1793         * DumpRenderTree/TestRunner.cpp:
1794         (SetOpenPanelFilesMediaIconCallback):
1795         (TestRunner::staticFunctions):
1796         (TestRunner::setOpenPanelFilesMediaIcon):
1797         * DumpRenderTree/TestRunner.h:
1798         (TestRunner::openPanelFilesMediaIcon const):
1799         * DumpRenderTree/mac/UIDelegate.mm:
1800         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1804         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1805         * WebKitTestRunner/TestController.cpp:
1806         (WTR::runOpenPanel):
1807         (WTR::TestController::resetStateToConsistentValues):
1808         * WebKitTestRunner/TestController.h:
1809         (WTR::TestController::openPanelFileURLsMediaIcon const):
1810         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1811         * WebKitTestRunner/TestInvocation.cpp:
1812         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1813
1814 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1815
1816         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1817         https://bugs.webkit.org/show_bug.cgi?id=197171
1818         <rdar://problem/47454979>
1819
1820         Reviewed by Youenn Fablet.
1821
1822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1823         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1824         (TestWebKitAPI::TEST):
1825
1826 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-build] Add unit tests for UnApplyPatchIfRequired
1829         https://bugs.webkit.org/show_bug.cgi?id=197197
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * BuildSlaveSupport/ews-build/steps_unittest.py:
1834         (TestUnApplyPatchIfRequired):
1835         (TestUnApplyPatchIfRequired.test_success):
1836         (TestUnApplyPatchIfRequired.test_failure):
1837         (TestUnApplyPatchIfRequired.test_skip):
1838
1839 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews-build] Add unit tests for CleanWorkingDirectory
1842         https://bugs.webkit.org/show_bug.cgi?id=197195
1843
1844         Reviewed by Lucas Forschler.
1845
1846         * BuildSlaveSupport/ews-build/steps_unittest.py:
1847         (TestCleanWorkingDirectory):
1848         (TestCleanWorkingDirectory.test_success):
1849         (TestCleanWorkingDirectory.test_failure):
1850
1851 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1852
1853         [ews-build] Use explicit imports instead of wildcard imports
1854         https://bugs.webkit.org/show_bug.cgi?id=197194
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * BuildSlaveSupport/ews-build/factories.py:
1859         * BuildSlaveSupport/ews-build/loadConfig.py:
1860         * BuildSlaveSupport/ews-build/steps_unittest.py:
1861
1862 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-build] Add unit tests for DownloadBuiltProduct
1865         https://bugs.webkit.org/show_bug.cgi?id=197193
1866
1867         Reviewed by Lucas Forschler.
1868
1869         * BuildSlaveSupport/ews-build/steps_unittest.py:
1870         (TestDownloadBuiltProduct):
1871         (TestDownloadBuiltProduct.setUp):
1872         (TestDownloadBuiltProduct.tearDown):
1873         (TestDownloadBuiltProduct.test_success):
1874         (TestDownloadBuiltProduct.test_failure):
1875
1876 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-app] Exception while loading status-bubble when no build step has started
1879         https://bugs.webkit.org/show_bug.cgi?id=196676
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1884         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1885
1886 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1887
1888         [PlayStation] Support running of JSC tests on remote playstation devices
1889         https://bugs.webkit.org/show_bug.cgi?id=197170
1890
1891         Reviewed by Ross Kirsling.
1892
1893         Script changes
1894
1895         * Scripts/run-javascriptcore-tests:
1896         (runJSCStressTests): Pass arguments for playstation to
1897         run-jsc-stress-tests
1898         * Scripts/run-jsc-stress-tests:
1899         Handle $hostOS=="playstation" for determineArchitecture, turning
1900         off $isFTLPlatform and runProfiler and defaulting test writer.
1901         * Scripts/webkitdirs.pm:
1902         (jscPath): PlayStation WebKit executables have .elf extension
1903         (executableProductDir): PlayStation builds on Windows hosts but
1904         uses bin directory rather than bin64/bin32 for executable output
1905         location.
1906         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1907
1908 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1909
1910         [CMake][Win] Use target oriented design for WebKit
1911         https://bugs.webkit.org/show_bug.cgi?id=197173
1912
1913         Reviewed by Alex Christensen.
1914
1915         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1916         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1917
1918 2019-04-23  Chris Dumez  <cdumez@apple.com>
1919
1920         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1921         https://bugs.webkit.org/show_bug.cgi?id=197097
1922         <rdar://problem/50048318>
1923
1924         Reviewed by Alex Christensen.
1925
1926         Add API test coverage.
1927
1928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1929         (-[PSONScheme webView:startURLSchemeTask:]):
1930
1931 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [ATK] Implement AtkComponentIface scroll_to methods
1934         https://bugs.webkit.org/show_bug.cgi?id=196856
1935
1936         Reviewed by Michael Catanzaro.
1937
1938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1939         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1940         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1941         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1942
1943 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1944
1945         [ews-build] Improve summary for UploadBuiltProduct step
1946         https://bugs.webkit.org/show_bug.cgi?id=197182
1947
1948         Reviewed by Lucas Forschler.
1949
1950         * BuildSlaveSupport/ews-build/steps.py:
1951         (UploadBuiltProduct): Added descriptionDone.
1952         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1953         * BuildSlaveSupport/ews-build/steps_unittest.py:
1954         (TestUploadBuiltProduct.test_success): Updated unit-test.
1955         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1956
1957 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews-build] Trigger queues only after uploading the archive
1960         https://bugs.webkit.org/show_bug.cgi?id=197180
1961
1962         Reviewed by Lucas Forschler.
1963
1964         * BuildSlaveSupport/ews-build/factories.py:
1965         (Factory.__init__):
1966         (BuildFactory.__init__): Remove trigger step from factories.
1967         (BuildFactory.propertiesToPassToTriggers): Deleted.
1968         * BuildSlaveSupport/ews-build/steps.py:
1969         (ConfigureBuild.__init__): Confiure triggers property.
1970         (Trigger): Step to trigger other queues.
1971         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1972         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1973
1974 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1975
1976         Deprecate WKContextCreateWithInjectedBundlePath
1977         https://bugs.webkit.org/show_bug.cgi?id=197169
1978
1979         Reviewed by Youenn Fablet.
1980
1981         * TestWebKitAPI/PlatformUtilities.cpp:
1982         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1983         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1984
1985 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1986
1987         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1988         https://bugs.webkit.org/show_bug.cgi?id=197093
1989         <rdar://problem/49708268>
1990
1991         Reviewed by Chris Dumez.
1992
1993         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1994         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1995         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1996         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1997         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1998
1999         * TestWebKitAPI/TCPServer.cpp:
2000         (TestWebKitAPI::TCPServer::TCPServer):
2001         (TestWebKitAPI::TCPServer::~TCPServer):
2002         (TestWebKitAPI::TCPServer::socketBindListen):
2003         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2004         * TestWebKitAPI/TCPServer.h:
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2007         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2008         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2009         (respondWithChallengeThenOK):
2010         (TestWebKitAPI::TEST):
2011         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2012         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2013         (TEST):
2014
2015 2019-04-22  Chris Dumez  <cdumez@apple.com>
2016
2017         Delayed WebProcessLaunch may break the _relatedWebView SPI
2018         https://bugs.webkit.org/show_bug.cgi?id=197160
2019
2020         Reviewed by Alex Christensen.
2021
2022         Add API test coverage.
2023
2024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2025
2026 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2027
2028         Use curl to download packages for webkitpy autoinstaller
2029         https://bugs.webkit.org/show_bug.cgi?id=197164
2030
2031         Reviewed by Darin Adler.
2032
2033         * Scripts/webkitpy/common/system/autoinstall.py:
2034         (AutoInstaller._download): Use curl(1) to download packages necessary for
2035         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2036         errors which are not present when using curl(1).
2037
2038 2019-04-22  Chris Dumez  <cdumez@apple.com>
2039
2040         Unreviewed, rolling out r244502.
2041
2042         Caused crashes on the bots
2043
2044         Reverted changeset:
2045
2046         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2047         https://bugs.webkit.org/show_bug.cgi?id=197160
2048         https://trac.webkit.org/changeset/244502
2049
2050 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2051
2052         Unreviewed, rolling out r244437.
2053
2054         Still breaks internal tests.
2055
2056         Reverted changeset:
2057
2058         "InjectedBundle parameters often need initialization function
2059         called before unarchiving"
2060         https://bugs.webkit.org/show_bug.cgi?id=189709
2061         https://trac.webkit.org/changeset/244437
2062
2063 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-build] Use singular verb in failure description in case of single api test failure
2066         https://bugs.webkit.org/show_bug.cgi?id=197013
2067
2068         Reviewed by Lucas Forschler.
2069
2070         * BuildSlaveSupport/ews-build/steps.py:
2071         (AnalyzeAPITestsResults.analyzeResults):
2072
2073 2019-04-22  Chris Dumez  <cdumez@apple.com>
2074
2075         Delayed WebProcessLaunch may break the _relatedWebView SPI
2076         https://bugs.webkit.org/show_bug.cgi?id=197160
2077
2078         Reviewed by Alex Christensen.
2079
2080         Add API test coverage.
2081
2082         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2083
2084 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2085
2086         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2087         https://bugs.webkit.org/show_bug.cgi?id=194630
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         Return early from getAttributeSet() is passed in accessible is nullptr.
2092
2093         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2094
2095 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2096
2097         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2098         https://bugs.webkit.org/show_bug.cgi?id=197145
2099         <rdar://problem/50078170>
2100
2101         Reviewed by Darin Adler.
2102
2103         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2104         focus, or showing the font manager.
2105
2106         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2109         (TEST):
2110         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2111         (TestWebKitAPI::TEST):
2112
2113 2019-04-21  Brian Burg  <bburg@apple.com>
2114
2115         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2116         https://bugs.webkit.org/show_bug.cgi?id=197125
2117         <rdar://problem/50061468>
2118
2119         Reviewed by Darin Adler.
2120
2121         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2122         using this class rather than making our own ./wpt serve invocation.
2123
2124         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2125         (WebDriverW3CWebServer):
2126         (WebDriverW3CWebServer.document_root): Expose this to clients.
2127         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2128
2129         (WebDriverW3CWebServer.__enter__):
2130         (WebDriverW3CWebServer.__exit__):
2131         Make it possible to use the web server with a 'with' statement.
2132
2133 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2134
2135         [CMake][Win] Use target oriented design for WebKitLegacy
2136         https://bugs.webkit.org/show_bug.cgi?id=197112
2137
2138         Reviewed by Konstantin Tokarev.
2139
2140         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2141
2142         * DumpRenderTree/CMakeLists.txt:
2143         * DumpRenderTree/PlatformWin.cmake:
2144         * DumpRenderTree/win/EventSender.cpp:
2145
2146 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2147
2148         Update text for old EWS submit button
2149         https://bugs.webkit.org/show_bug.cgi?id=197140
2150
2151         Reviewed by Alexey Proskuryakov.
2152
2153         * QueueStatusServer/templates/statusbubble.html:
2154
2155 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2156
2157         [ews-app] New EWS should poll bugzilla more frequently
2158         https://bugs.webkit.org/show_bug.cgi?id=197138
2159
2160         Reviewed by Alexey Proskuryakov.
2161
2162         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2163         (FetchLoop.__init__):
2164
2165 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2166
2167         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2168         https://bugs.webkit.org/show_bug.cgi?id=197139
2169
2170         Reviewed by Alexey Proskuryakov.
2171
2172         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2173         * QueueStatusServer/templates/statusbubble.html:
2174
2175 2019-04-20  Chris Dumez  <cdumez@apple.com>
2176
2177         Unreviewed, fix iOS build with recent SDKs.
2178
2179         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2180
2181 2019-04-19  Keith Miller  <keith_miller@apple.com>
2182
2183         Add script to merge run_benchmark jsons
2184         https://bugs.webkit.org/show_bug.cgi?id=197107
2185
2186         Reviewed by Michael Saboff.
2187
2188         The script basically recursively decends through all json objects until it gets
2189         to an array or JSON primitive and concats or takes the first value, respectively.
2190
2191         This patch also adds +x bits to the compare-results script so it
2192         can be run directly from the command line. I had to add a new line so that svn
2193         will accept the change... yay svn!
2194
2195         * Scripts/compare-results:
2196         * Scripts/merge-result-jsons: Added.
2197         (readJSONFile):
2198         (deepAppend):
2199         (mergeJSONs):
2200         (main):
2201
2202 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2203
2204         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2205         https://bugs.webkit.org/show_bug.cgi?id=197079
2206
2207         Reviewed by Darin Adler.
2208
2209         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2210
2211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2212         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2213
2214 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2215
2216         Unreviewed, rolling out r244434.
2217         https://bugs.webkit.org/show_bug.cgi?id=197089
2218
2219         caused 1 API test failure (Requested by zalan on #webkit).
2220
2221         Reverted changeset:
2222
2223         "Regression (r244291): Broken API Test
2224         AutoLayoutRenderingProgressRelativeOrdering"
2225         https://bugs.webkit.org/show_bug.cgi?id=196948
2226         https://trac.webkit.org/changeset/244434
2227
2228 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2229
2230         Add new compatibility mode API on WKNavigation
2231         https://bugs.webkit.org/show_bug.cgi?id=197069
2232         <rdar://problem/50025800>
2233
2234         Reviewed by Tim Horton.
2235
2236         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2237
2238         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2239         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2240         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2241
2242 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2243
2244         [CMake] Make WebCore headers copies
2245         https://bugs.webkit.org/show_bug.cgi?id=182512
2246         <rdar://problem/37510435>
2247
2248         Reviewed by Alex Christensen.
2249
2250         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2251         ports.
2252
2253         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2254         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2255
2256         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2257         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2258         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2259         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2260         * TestWebKitAPI/CMakeLists.txt:
2261         * TestWebKitAPI/PlatformWin.cmake:
2262         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2263         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2264         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2265
2266 2019-04-18  Jer Noble  <jer.noble@apple.com>
2267
2268         Add support for parsing FairPlayStreaming PSSH boxes.
2269         https://bugs.webkit.org/show_bug.cgi?id=197064
2270
2271         Reviewed by Eric Carlson.
2272
2273         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2274         (TestWebKitAPI::TEST):
2275
2276 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2277
2278         InjectedBundle parameters often need initialization function called before unarchiving
2279         https://bugs.webkit.org/show_bug.cgi?id=189709
2280         <rdar://problem/44573653>
2281
2282         Reviewed by Ryosuke Niwa.
2283
2284         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2285         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2286
2287 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2288
2289         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2290         https://bugs.webkit.org/show_bug.cgi?id=196948
2291         <rdar://problem/49927131>
2292
2293         Reviewed by Tim Horton.
2294
2295         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2296         (TEST): 
2297         The expected order of incoming events is
2298         1. didInvalidateIntrinsicContentSize
2299         2. didFirstLayout
2300         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2301         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2302         (and remember, all we care about is ordering).
2303
2304 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2305
2306         Unreviewed, rolling out r244299.
2307
2308         Breaks internal tests.
2309
2310         Reverted changeset:
2311
2312         "InjectedBundle parameters often need initialization function
2313         called before unarchiving"
2314         https://bugs.webkit.org/show_bug.cgi?id=189709
2315         https://trac.webkit.org/changeset/244299
2316
2317 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2318
2319         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2320         https://bugs.webkit.org/show_bug.cgi?id=197053
2321
2322         Reviewed by Saam Barati.
2323
2324         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2325         (TestWebKitAPI::TEST):
2326
2327 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2328
2329         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2330         https://bugs.webkit.org/show_bug.cgi?id=197028
2331         <rdar://problem/49985290>
2332
2333         Reviewed by Wenson Hsieh.
2334
2335         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2336         (TEST):
2337         Liberal application of waitForNextPresentationUpdate works around a race
2338         where if the page rapidly changes its viewport arguments (or an API client
2339         rapidly changes its viewport arguments), we'd get stuck thinking that the
2340         user had intentionally zoomed the page, and stop resetting the initial scale.
2341         This deserves a separate bug, but no need to keep the test failing while
2342         we think about it.
2343
2344 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2345
2346         REGRESSION (r241988): Switching tabs is slow
2347         https://bugs.webkit.org/show_bug.cgi?id=197037
2348         <rdar://problem/49951473>
2349
2350         Reviewed by Simon Fraser.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2354         (TEST):
2355         * TestWebKitAPI/cocoa/TestWKWebView.h:
2356         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2357         (-[TestWKWebView addToTestWindow]):
2358         Add a test that hangs without this fix.
2359
2360 2019-04-17  Truitt Savell  <tsavell@apple.com>
2361
2362         Unreviewed, rolling out r244400.
2363
2364         Caused testing to exit early with assertionon Debug WK2
2365
2366         Reverted changeset:
2367
2368         "UI↔Web deadlock when printing with a JavaScript alert
2369         visible"
2370         https://bugs.webkit.org/show_bug.cgi?id=196839
2371         https://trac.webkit.org/changeset/244400
2372
2373 2019-04-17  Brady Eidson  <beidson@apple.com>
2374
2375         Link clicks in PDFs shouldn't send referrer headers.
2376         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2377
2378         Reviewed by Tim Horton.
2379
2380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2381         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2382         (putPDFBytesCallback):
2383         (emptyReleaseInfoCallback):
2384         (createPDFWithLinkToURL):
2385         (TEST):
2386
2387 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2388
2389         UI↔Web deadlock when printing with a JavaScript alert visible
2390         https://bugs.webkit.org/show_bug.cgi?id=196839
2391         <rdar://problem/49157642>
2392
2393         Reviewed by Andy Estes.
2394
2395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2396         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2397         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2398         (TEST):
2399
2400 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2401
2402         WKRetainPtr's adoption constructor should be private
2403         https://bugs.webkit.org/show_bug.cgi?id=197019
2404
2405         Reviewed by Tim Horton.
2406
2407         * DumpRenderTree/mac/DumpRenderTree.mm:
2408         (dumpFramesAsText):
2409         * TestWebKitAPI/InjectedBundleController.cpp:
2410         (TestWebKitAPI::InjectedBundleController::initialize):
2411         * TestWebKitAPI/PlatformUtilities.cpp:
2412         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2413         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2414         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2415         (TestWebKitAPI::Util::toWK):
2416         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2417         (TestWebKitAPI::TEST):
2418         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2419         (TestWebKitAPI::TEST):
2420         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2421         (TestWebKitAPI::TEST):
2422         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2423         (TestWebKitAPI::TEST):
2424         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2425         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2426         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2427         (TestWebKitAPI::TEST):
2428         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2429         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2430         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2431         (TestWebKitAPI::TEST):
2432         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2433         (TestWebKitAPI::TEST):
2434         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2435         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2436         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2437         (TestWebKitAPI::TEST):
2438         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2439         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2440         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2441         (TestWebKitAPI::TEST):
2442         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2443         (TestWebKitAPI::TEST):
2444         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2445         (TestWebKitAPI::TEST):
2446         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2447         (TestWebKitAPI::TEST):
2448         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2449         (TestWebKitAPI::TEST):
2450         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2451         (TestWebKitAPI::TEST):
2452         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2453         (TestWebKitAPI::TEST):
2454         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2455         (TestWebKitAPI::TEST):
2456         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2457         (TestWebKitAPI::TEST):
2458         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2459         (TestWebKitAPI::TEST):
2460         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2461         (TestWebKitAPI::TEST):
2462         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2463         (TestWebKitAPI::TEST):
2464         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2465         (TestWebKitAPI::TEST):
2466         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2467         (TestWebKitAPI::TEST):
2468         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2469         (TestWebKitAPI::TEST):
2470         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2471         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2472         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2473         (TestWebKitAPI::TEST):
2474         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2475         (TestWebKitAPI::TEST):
2476         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2477         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2478         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2479         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2480         (TestWebKitAPI::TEST):
2481         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2482         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2483         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2484         (TestWebKitAPI::TEST):
2485         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2486         (TestWebKitAPI::TEST):
2487         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2488         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2489         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2490         (TestWebKitAPI::TEST):
2491         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2492         (TestWebKitAPI::loadAlternateHTMLString):
2493         (TestWebKitAPI::TEST):
2494         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2495         (TestWebKitAPI::TEST):
2496         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2497         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2498         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2499         (TestWebKitAPI::buildAndPerformTest):
2500         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2501         (TestWebKitAPI::TEST):
2502         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2503         (TestWebKitAPI::TEST):
2504         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2505         (TestWebKitAPI::TEST):
2506         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2511         (TestWebKitAPI::TEST):
2512         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2515         (TestWebKitAPI::TEST):
2516         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2521         (TestWebKitAPI::TEST):
2522         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2523         (TestWebKitAPI::TEST):
2524         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2525         (TestWebKitAPI::TEST):
2526         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2527         (TestWebKitAPI::TEST):
2528         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2531         (TestWebKitAPI::TEST):
2532         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2533         (TestWebKitAPI::TEST):
2534         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2535         (TestWebKitAPI::TEST):
2536         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2537         (TestWebKitAPI::TEST):
2538         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2541         (TestWebKitAPI::TEST):
2542         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2543         (TestWebKitAPI::TEST):
2544         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2545         (TestWebKitAPI::TEST):
2546         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2547         (TestWebKitAPI::TEST):
2548         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2549         (TestWebKitAPI::TEST):
2550         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2551         (TestWebKitAPI::TEST):
2552         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2553         (TestWebKitAPI::TEST):
2554         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2557         (TestWebKitAPI::TEST):
2558         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2559         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2560         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2561         (TestWebKitAPI::TEST):
2562         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2563         (TestWebKitAPI::TEST):
2564         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2565         (TestWebKitAPI::TEST):
2566         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2567         (TestWebKitAPI::TEST):
2568         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2569         (TestWebKitAPI::TEST):
2570         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2571         (TestWebKitAPI::TEST):
2572         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2573         (TestWebKitAPI::TEST):
2574         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2575         (TestWebKitAPI::TEST):
2576         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2577         (TestWebKitAPI::TEST):
2578         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2579         (TestWebKitAPI::TEST):
2580         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2582         (TEST):
2583         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2584         (TEST):
2585         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2586         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2587         (TEST):
2588         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2591         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2592         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2593         (WTR::getMenuItemTitleCallback):
2594         (WTR::createMouseMessageBody):
2595         (WTR::EventSendingController::mouseDown):
2596         (WTR::EventSendingController::mouseUp):
2597         (WTR::EventSendingController::mouseMoveTo):
2598         (WTR::EventSendingController::mouseForceClick):
2599         (WTR::EventSendingController::startAndCancelMouseForceClick):
2600         (WTR::EventSendingController::mouseForceDown):
2601         (WTR::EventSendingController::mouseForceUp):
2602         (WTR::EventSendingController::mouseForceChanged):
2603         (WTR::EventSendingController::leapForward):
2604         (WTR::EventSendingController::scheduleAsynchronousClick):
2605         (WTR::createKeyDownMessageBody):
2606         (WTR::EventSendingController::keyDown):
2607         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2608         (WTR::EventSendingController::mouseScrollBy):
2609         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2610         (WTR::EventSendingController::continuousMouseScrollBy):
2611         (WTR::EventSendingController::addTouchPoint):
2612         (WTR::EventSendingController::updateTouchPoint):
2613         (WTR::EventSendingController::setTouchModifier):
2614         (WTR::EventSendingController::setTouchPointRadius):
2615         (WTR::EventSendingController::touchStart):
2616         (WTR::EventSendingController::touchMove):
2617         (WTR::EventSendingController::touchEnd):
2618         (WTR::EventSendingController::touchCancel):
2619         (WTR::EventSendingController::clearTouchPoints):
2620         (WTR::EventSendingController::releaseTouchPoint):
2621         (WTR::EventSendingController::cancelTouchPoint):
2622         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2623         (WTR::InjectedBundle::didCreatePage):
2624         (WTR::InjectedBundle::didReceiveMessage):
2625         (WTR::InjectedBundle::didReceiveMessageToPage):
2626         (WTR::InjectedBundle::booleanForKey):
2627         (WTR::InjectedBundle::done):
2628         (WTR::InjectedBundle::dumpToStdErr):
2629         (WTR::InjectedBundle::outputText):
2630         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2631         (WTR::InjectedBundle::postAddChromeInputField):
2632         (WTR::InjectedBundle::postRemoveChromeInputField):
2633         (WTR::InjectedBundle::postFocusWebView):
2634         (WTR::InjectedBundle::postSetBackingScaleFactor):
2635         (WTR::InjectedBundle::postSetWindowIsKey):
2636         (WTR::InjectedBundle::postSetViewSize):
2637         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2638         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2639         (WTR::InjectedBundle::setGeolocationPermission):
2640         (WTR::InjectedBundle::setMockGeolocationPosition):
2641         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2642         (WTR::InjectedBundle::isGeolocationProviderActive const):
2643         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2644         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2645         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2646         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2647         (WTR::InjectedBundle::setCustomPolicyDelegate):
2648         (WTR::InjectedBundle::setHidden):
2649         (WTR::InjectedBundle::setCacheModel):
2650         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2651         (WTR::InjectedBundle::processWorkQueue):
2652         (WTR::InjectedBundle::queueBackNavigation):
2653         (WTR::InjectedBundle::queueForwardNavigation):
2654         (WTR::InjectedBundle::queueLoad):
2655         (WTR::InjectedBundle::queueLoadHTMLString):
2656         (WTR::InjectedBundle::queueReload):
2657         (WTR::InjectedBundle::queueLoadingScript):
2658         (WTR::InjectedBundle::queueNonLoadingScript):
2659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2660         (WTR::frameToStr):
2661         (WTR::InjectedBundlePage::InjectedBundlePage):
2662         (WTR::dumpFrameDescriptionSuitableForTestResult):
2663         (WTR::dumpFrameScrollPosition):
2664         (WTR::dumpDescendantFrameScrollPositions):
2665         (WTR::dumpFrameText):
2666         (WTR::dumpDescendantFramesText):
2667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2668         (WTR::TestRunner::shouldDumpPixels const):
2669         (WTR::TestRunner::setDumpPixels):
2670         (WTR::TestRunner::whatToDump const):
2671         (WTR::TestRunner::setWhatToDump):
2672         (WTR::TestRunner::setWaitUntilDone):
2673         (WTR::TestRunner::shouldWaitUntilDone const):
2674         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2675         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2676         (WTR::TestRunner::clearAllDatabases):
2677         (WTR::TestRunner::setIDBPerOriginQuota):
2678         (WTR::TestRunner::originsWithApplicationCache):
2679         (WTR::TestRunner::setCanOpenWindows):
2680         (WTR::TestRunner::setXSSAuditorEnabled):
2681         (WTR::TestRunner::setMediaDevicesEnabled):
2682         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2683         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2684         (WTR::TestRunner::setCustomUserAgent):
2685         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2686         (WTR::TestRunner::setModernMediaControlsEnabled):
2687         (WTR::TestRunner::setWebGL2Enabled):
2688         (WTR::TestRunner::setWritableStreamAPIEnabled):
2689         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2690         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2691         (WTR::TestRunner::setAllowsAnySSLCertificate):
2692         (WTR::TestRunner::setPluginsEnabled):
2693         (WTR::TestRunner::setValueForUser):
2694         (WTR::TestRunner::setAudioResult):
2695         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2696         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2697         (WTR::TestRunner::setAlwaysAcceptCookies):
2698         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2699         (WTR::TestRunner::isDoingMediaCapture const):
2700         (WTR::TestRunner::queueLoad):
2701         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2702         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2703         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2704         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2705         (WTR::TestRunner::setAuthenticationUsername):
2706         (WTR::TestRunner::setAuthenticationPassword):
2707         (WTR::TestRunner::secureEventInputIsEnabled const):
2708         (WTR::TestRunner::setBlockAllPlugins):
2709         (WTR::TestRunner::setPluginSupportedMode):
2710         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2711         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2712         (WTR::TestRunner::setNavigationGesturesEnabled):
2713         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2714         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2715         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2716         (WTR::TestRunner::terminateNetworkProcess):
2717         (WTR::TestRunner::terminateServiceWorkerProcess):
2718         (WTR::TestRunner::runUIScript):
2719         (WTR::TestRunner::setStatisticsDebugMode):
2720         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2721         (WTR::TestRunner::setStatisticsLastSeen):
2722         (WTR::TestRunner::setStatisticsPrevalentResource):
2723         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2724         (WTR::TestRunner::dumpResourceLoadStatistics):
2725         (WTR::TestRunner::isStatisticsPrevalentResource):
2726         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2727         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2728         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2729         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2730         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2731         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2732         (WTR::TestRunner::setStatisticsGrandfathered):
2733         (WTR::TestRunner::isStatisticsGrandfathered):
2734         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2735         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2736         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2737         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2738         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2739         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2740         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2741         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2742         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2743         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2744         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2745         (WTR::TestRunner::statisticsSubmitTelemetry):
2746         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2747         (WTR::TestRunner::setStatisticsIsRunningTest):
2748         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2749         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2750         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2751         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2752         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2753         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2754         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2755         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2756         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2757         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2758         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2759         (WTR::TestRunner::statisticsResetToConsistentState):
2760         (WTR::TestRunner::setStorageAccessAPIEnabled):
2761         (WTR::TestRunner::getAllStorageAccessEntries):
2762         (WTR::TestRunner::addMockMediaDevice):
2763         (WTR::TestRunner::clearMockMediaDevices):
2764         (WTR::TestRunner::removeMockMediaDevice):
2765         (WTR::TestRunner::resetMockMediaDevices):
2766         (WTR::TestRunner::connectMockGamepad):
2767         (WTR::TestRunner::disconnectMockGamepad):
2768         (WTR::TestRunner::setMockGamepadDetails):
2769         (WTR::TestRunner::setMockGamepadAxisValue):
2770         (WTR::TestRunner::setMockGamepadButtonValue):
2771         (WTR::TestRunner::removeAllSessionCredentials):
2772         (WTR::TestRunner::clearDOMCache):
2773         (WTR::TestRunner::clearDOMCaches):
2774         (WTR::TestRunner::hasDOMCache):
2775         (WTR::TestRunner::domCacheSize):
2776         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2777         (WTR::TestRunner::getApplicationManifestThen):
2778         (WTR::TestRunner::injectUserScript):
2779         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2780         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2781         (WTR::TestRunner::addTestKeyToKeychain):
2782         (WTR::TestRunner::cleanUpKeychain):
2783         (WTR::TestRunner::keyExistsInKeychain):
2784         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2785         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2786         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2787         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2788         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2789         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2790         * WebKitTestRunner/TestController.cpp:
2791         (WTR::TestController::initialize):
2792         (WTR::parseStringTestHeaderValueAsRelativePath):
2793         (WTR::updateTestOptionsFromTestHeader):
2794         (WTR::TestController::runTest):
2795         (WTR::TestController::didReceiveLiveDocumentsList):
2796         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2797         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2798         (WTR::TestController::didFinishNavigation):
2799         (WTR::TestController::didReceiveAuthenticationChallenge):
2800         * WebKitTestRunner/TestInvocation.cpp:
2801         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2802         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2803         (WTR::TestInvocation::uiScriptDidComplete):
2804         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2805         * WebKitTestRunner/WebNotificationProvider.cpp:
2806         (WTR::WebNotificationProvider::closeWebNotification):
2807         * WebKitTestRunner/WorkQueueManager.cpp:
2808         (WTR::ScriptItem::ScriptItem):
2809         (WTR::WorkQueueManager::queueLoad):
2810         (WTR::WorkQueueManager::queueLoadHTMLString):
2811
2812 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2813
2814         Add a comment to make my test from r244139 less mysterious.
2815         https://bugs.webkit.org/show_bug.cgi?id=196744
2816
2817         As suggested by Darin Adler.
2818
2819         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2820         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2821
2822 2019-04-17  Chris Dumez  <cdumez@apple.com>
2823
2824         Remember device orientation permission for the duration of the browsing session
2825         https://bugs.webkit.org/show_bug.cgi?id=196992
2826         <rdar://problem/49946067>
2827
2828         Reviewed by Alex Christensen.
2829
2830         Add API test coverage.
2831
2832         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2833         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2834         (TEST):
2835
2836 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2837
2838         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2839         https://bugs.webkit.org/show_bug.cgi?id=196675
2840
2841         Reviewed by Lucas Forschler.
2842
2843         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2844         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2845
2846 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2847
2848         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2849         https://bugs.webkit.org/show_bug.cgi?id=196919
2850         <rdar://problem/41630459>
2851
2852         Reviewed by Tim Horton.
2853
2854         Add iOS support for several new testing hooks. See below for more detail.
2855
2856         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2857         (WTR::UIScriptController::isDismissingMenu const):
2858
2859         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2860         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2861         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2862
2863         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2864         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2865         (WTR::UIScriptController::isDismissingMenu const):
2866         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2867         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2869         (WTR::InjectedBundle::didReceiveMessageToPage):
2870         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2871         (WTR::TestRunner::setAllowedMenuActions):
2872
2873         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2874         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2875         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2876         against the name of the custom action.
2877
2878         (WTR::TestRunner::installCustomMenuAction):
2879
2880         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2881         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2882         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2883         triggered.
2884
2885         (WTR::TestRunner::performCustomMenuAction):
2886
2887         Invoked when the custom menu action is triggered.
2888
2889         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2890         * WebKitTestRunner/TestController.cpp:
2891         (WTR::TestController::installCustomMenuAction):
2892         (WTR::TestController::setAllowedMenuActions):
2893         * WebKitTestRunner/TestController.h:
2894         * WebKitTestRunner/TestInvocation.cpp:
2895         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2896         (WTR::TestInvocation::performCustomMenuAction):
2897
2898         Add plumbing to call back into the injected bundle when performing the custom action.
2899
2900         * WebKitTestRunner/TestInvocation.h:
2901         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2902         (WTR::TestController::installCustomMenuAction):
2903         (WTR::TestController::setAllowedMenuActions):
2904         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2905         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2906         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2907         (-[TestRunnerWKWebView becomeFirstResponder]):
2908         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2909
2910         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2911         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2912         in the Mail app on iOS.
2913
2914         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2915         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2916         (-[TestRunnerWKWebView resetCustomMenuAction]):
2917         (-[TestRunnerWKWebView performCustomAction:]):
2918         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2919         (-[TestRunnerWKWebView _willHideMenu]):
2920         (-[TestRunnerWKWebView _didHideMenu]):
2921         * WebKitTestRunner/ios/TestControllerIOS.mm:
2922         (WTR::TestController::platformResetStateToConsistentValues):
2923
2924         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2925         if specified.
2926
2927         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2928         (WTR::UIScriptController::isDismissingMenu const):
2929
2930 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2931
2932         Allow sharing from imageSheet on an image document
2933         https://bugs.webkit.org/show_bug.cgi?id=196891
2934         <rdar://problem/25377386>
2935
2936         Reviewed by Tim Horton.
2937
2938         Test to make sure that the correct imageURL is extracted from an image element.
2939
2940         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2941         (TestWebKitAPI::TEST):
2942
2943 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2944
2945         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2946         https://bugs.webkit.org/show_bug.cgi?id=196995
2947
2948         Reviewed by Brady Eidson.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2951         (TEST):
2952
2953 2019-04-16  Chris Dumez  <cdumez@apple.com>
2954
2955         URL set by document.open() is not communicated to the UIProcess
2956         https://bugs.webkit.org/show_bug.cgi?id=196941
2957         <rdar://problem/49237544>
2958
2959         Reviewed by Geoff Garen.
2960
2961         Add API test coverage.
2962
2963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2964         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2965         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2966         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2967         (TEST):
2968
2969 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2970
2971         Unreviewed, rolling out r244321.
2972         https://bugs.webkit.org/show_bug.cgi?id=196968
2973
2974         Causing all WK2 Debug builds to exit early after Assertion
2975         failures. (Requested by ShawnRoberts on #webkit).
2976
2977         Reverted changeset:
2978
2979         "URL set by document.open() is not communicated to the
2980         UIProcess"
2981         https://bugs.webkit.org/show_bug.cgi?id=196941
2982         https://trac.webkit.org/changeset/244321
2983
2984 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2985
2986         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2987         https://bugs.webkit.org/show_bug.cgi?id=196948
2988
2989         Reviewed by Zalan Bujtas.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2992         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2993
2994 2019-04-15  Chris Dumez  <cdumez@apple.com>
2995
2996         URL set by document.open() is not communicated to the UIProcess
2997         https://bugs.webkit.org/show_bug.cgi?id=196941
2998         <rdar://problem/49237544>
2999
3000         Reviewed by Geoffrey Garen.
3001
3002         Add API test coverage.
3003
3004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3005         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3006         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3007         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3008         (TEST):
3009
3010 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3011
3012         Using Tools/Scripts/clean-webkit should not install requests
3013         https://bugs.webkit.org/show_bug.cgi?id=196940
3014
3015         Reviewed by Lucas Forschler.
3016
3017         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3018         existing, depending on the path autoinstalled is run through.
3019         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3020         needed.
3021         (Port.configuration_for_upload):
3022         (Port.commits_for_upload):
3023
3024 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3025
3026         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3027         https://bugs.webkit.org/show_bug.cgi?id=196773
3028
3029         Reviewed by Jer Noble.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3032         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3033         (TEST):
3034
3035 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3036
3037         ews-build should clearly indicate flaky test failures
3038         https://bugs.webkit.org/show_bug.cgi?id=196947
3039
3040         Reviewed by Lucas Forschler.
3041
3042         * BuildSlaveSupport/ews-build/steps.py:
3043         (AnalyzeAPITestsResults.analyzeResults):
3044
3045 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3046
3047         InjectedBundle parameters often need initialization function called before unarchiving
3048         https://bugs.webkit.org/show_bug.cgi?id=189709
3049         <rdar://problem/44573653>
3050
3051         Reviewed by Ryosuke Niwa.
3052
3053         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3054         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3055
3056 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3057
3058         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3059         https://bugs.webkit.org/show_bug.cgi?id=196681
3060
3061         Reviewed by Darin Adler.
3062
3063         Added tests.
3064
3065         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3066         (WTF_HashSet.RemoveIf):
3067         (WTF_HashSet.RemoveIfShrinkToBestSize):
3068
3069 2019-04-15  John Wilander  <wilander@apple.com>
3070
3071         Send delayed Ad Click Attribution conversion requests to the click source
3072         https://bugs.webkit.org/show_bug.cgi?id=196838
3073         <rdar://problem/47650157>
3074
3075         Reviewed by Chris Dumez and Youenn Fablet.
3076
3077         This patch adds test infrastructure to override the default behavior in
3078         WebKit::NetworkAdClickAttribution.
3079
3080         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3081         (TestWebKitAPI::TEST):
3082         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3083         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3084         (WTR::TestRunner::dumpAdClickAttribution):
3085         (WTR::TestRunner::clearAdClickAttribution):
3086         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3087         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3089         * WebKitTestRunner/TestController.cpp:
3090         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3091         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3092         * WebKitTestRunner/TestController.h:
3093         * WebKitTestRunner/TestInvocation.cpp:
3094         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3095
3096 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3097
3098         [ews-app] status-bubble should display position in queue
3099         https://bugs.webkit.org/show_bug.cgi?id=196607
3100
3101         Reviewed by Lucas Forschler.
3102
3103         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3104         (StatusBubble._build_bubble):
3105         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3106
3107 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3108
3109         [ews-build] Do not run clean build by default on EWS builders
3110         https://bugs.webkit.org/show_bug.cgi?id=196897
3111
3112         Reviewed by Lucas Forschler.
3113
3114         * BuildSlaveSupport/ews-build/steps.py:
3115         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3116         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3117         untracked directories like WebKitBuild).
3118         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3119         untracked files/directories (like WebKitBuild).
3120
3121 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3122
3123         TestRunner::notifyDone() should be safely reentrant
3124         https://bugs.webkit.org/show_bug.cgi?id=196898
3125
3126         Reviewed by Darin Adler.
3127
3128         It is currently possible that TestRunner::notifyDone() will call itself, since
3129         notifyDone() will force a repaint, which can start executing JavaScript, which
3130         may call notifyDone() again. This can lead to test failures and flakiness.
3131         Fix this by setting the m_waitToDump flag before calling the dump() method.
3132
3133         * DumpRenderTree/mac/TestRunnerMac.mm:
3134         (TestRunner::notifyDone):
3135         (TestRunner::forceImmediateCompletion):
3136         * DumpRenderTree/win/TestRunnerWin.cpp:
3137         (TestRunner::notifyDone):
3138         (TestRunner::forceImmediateCompletion):
3139
3140 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3141
3142         [GTK][WPE] Add enable-media websetting
3143         https://bugs.webkit.org/show_bug.cgi?id=196863
3144
3145         Reviewed by Michael Catanzaro.
3146
3147         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3148         (testWebKitSettings): Add test for the enable-media web-setting.
3149
3150 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3153         https://bugs.webkit.org/show_bug.cgi?id=196905
3154         <rdar://problem/49886096>
3155
3156         Reviewed by Tim Horton.
3157
3158         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3159         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3160         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3161         delay timer, we end up with this sequence of events in the problematic (failure) case:
3162
3163         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3164             ...IPC from UI to web process...
3165         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3166             ...IPC from web to UI process...
3167         (c) [UI]    Invoke completion handler for script #1
3168         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3169             ...IPC from UI to web process...
3170         (e) [Web]   Evaluate script #2 in the web process
3171         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3172
3173         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3174         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3175         #2 is run in step (e).
3176
3177         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3178         the UI process by waiting on a script message posted by the web process, after attachment updates are
3179         dispatched.
3180
3181         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3182         (TestWebKitAPI::TEST):
3183
3184 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3185
3186         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3187         https://bugs.webkit.org/show_bug.cgi?id=196909
3188
3189         Reviewed by Wenson Hsieh.
3190
3191         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3192         (TestWebKitAPI::TEST):
3193
3194 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3195
3196         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3197         https://bugs.webkit.org/show_bug.cgi?id=196880
3198
3199         Reviewed by Yusuke Suzuki.
3200
3201         Add a new function for bytecode cache tests that does not forceDiskCache
3202         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3203         test added in this patch, since the code is invalid and therefore won't be
3204         cached. It should also be useful for tests that evaluate dynamically
3205         generated code.
3206
3207         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3208         * Scripts/run-jsc-stress-tests:
3209
3210 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3211
3212         Update AudioSession route sharing policy
3213         https://bugs.webkit.org/show_bug.cgi?id=196776
3214         <rdar://problem/46501611>
3215
3216         Reviewed by Jer Noble.
3217
3218         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3219         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3220         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3221         (TestWebKitAPI::TEST):
3222
3223 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3224
3225         [iOS] Software keyboard is shown too frequently on some websites
3226         https://bugs.webkit.org/show_bug.cgi?id=195856
3227         <rdar://problem/49191395>
3228
3229         Reviewed by Darin Adler.
3230
3231         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3232
3233         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3234         (WTR::UIScriptController::setHardwareKeyboardAttached):
3235         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3236         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3237         (WTR::UIScriptController::setHardwareKeyboardAttached):
3238         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3239         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3240
3241         Additionally link against GraphicsServices in WebKitTestRunner.
3242
3243         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3244         (WTR::TestController::platformResetStateToConsistentValues):
3245         (WTR::UIScriptController::setHardwareKeyboardAttached):
3246
3247 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3248
3249         [GTK][WPE] Fix pacman install-dependencies packages
3250         https://bugs.webkit.org/show_bug.cgi?id=196817
3251
3252         Reviewed by Žan Doberšek.
3253         
3254         python3-setuptools is called python-setuptools
3255         ruby-highline is only available on AUR
3256         libv4l-devel is incorporated in v4l-utils
3257
3258         * gtk/install-dependencies:
3259         * wpe/install-dependencies:
3260
3261 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3262
3263         [GTK] REGRESSION(r243860): Many tests failing
3264         https://bugs.webkit.org/show_bug.cgi?id=196791
3265
3266         Reviewed by Joanmarie Diggs.
3267
3268         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3269         multiple documents and check that accessibility hierarchy is updated after a navigation.
3270
3271         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3272         (loadChangedCallback):
3273         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3274         (AccessibilityTest::AccessibilityTest):
3275         (AccessibilityTest::~AccessibilityTest):
3276         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3277         (AccessibilityTest::findTestServerApplication):
3278         (AccessibilityTest::findDocumentWeb):
3279         (AccessibilityTest::findRootObject):
3280         (AccessibilityTest::waitUntilChildrenRemoved):
3281         (AccessibilityTest::ensureProxy):
3282         (testAtspiBasicHierarchy):
3283         (beforeAll):
3284         (afterAll):
3285
3286 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3287
3288         [ews-build] Handle bug titles with unicode characters
3289         https://bugs.webkit.org/show_bug.cgi?id=196802
3290
3291         Reviewed by Dewei Zhu.
3292
3293         * BuildSlaveSupport/ews-build/steps.py:
3294         (ValidatePatch._is_bug_closed):
3295
3296 2019-04-11  Michael Saboff  <msaboff@apple.com>
3297
3298         Improve the Inline Cache Stats code
3299         https://bugs.webkit.org/show_bug.cgi?id=196836
3300
3301         Reviewed by Saam Barati.
3302
3303         Added a new script to consolidate and arrange the output of --useICStats option.
3304
3305         This script merges the output from every group into one large table and sorts it from most common to
3306         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3307         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3308         Put together, this is useful to see what property accesses are not getting cached.
3309
3310         * Scripts/ic-stats.py: Added.
3311         (ICStats):
3312         (ICStats.__init__):
3313         (ICStats.parse):
3314         (ICStats.dumpStats):
3315         (usage):
3316
3317 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3318
3319         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3320         https://bugs.webkit.org/show_bug.cgi?id=196809
3321         <rdar://49800762>
3322
3323         Reviewed by Brady Eidson.
3324
3325         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3326         (TEST):
3327
3328 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3329
3330         requestAnimationFrame should execute before the next frame
3331         https://bugs.webkit.org/show_bug.cgi?id=177484
3332
3333         Reviewed by Simon Fraser.
3334
3335         Add trace points for the page RenderingUpdate.
3336
3337         * Tracing/SystemTracePoints.plist:
3338
3339 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3340
3341         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3342         https://bugs.webkit.org/show_bug.cgi?id=196760
3343
3344         Reviewed by Don Olmstead.
3345
3346         vswhere.exe has been bundled since Visual Studio 2017 version
3347         15.2. We shouldn't download vswhere.exe.
3348
3349         * Scripts/build-jsc: Do not call update-vswhere.py.
3350         * Scripts/build-webkit: Ditto.
3351         * Scripts/update-vswhere.py: Removed.
3352         * Scripts/webkitdirs.pm:
3353         (requireModulesForVSWhere): Deleted.
3354         (pickCurrentVisualStudioInstallation): Deleted.
3355         (visualStudioInstallDirVSWhere): Return the latest installed VS
3356         installation path by using the bundled vswhere.exe.
3357         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3358         (visualStudioInstallDirFallback): Removed.
3359
3360 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3361
3362         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3363         https://bugs.webkit.org/show_bug.cgi?id=196780
3364
3365         Reviewed by Alexey Proskuryakov.
3366
3367         * BuildSlaveSupport/ews-build/steps.py:
3368         * BuildSlaveSupport/ews-build/steps_unittest.py:
3369
3370 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3371
3372         Add SPI WKNavigationResponse._downloadAttribute
3373         https://bugs.webkit.org/show_bug.cgi?id=196755
3374         <rdar://49587365>
3375
3376         Reviewed by Brady Eidson.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3379         (-[NavigationResponseTestDelegate navigationResponse]):
3380         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3381         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3382         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3383         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3384         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3385         (readRequest):
3386         (writeResponse):
3387         (TEST):
3388
3389 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3390
3391         Add modern API for overriding the page's specified viewport configuration
3392         https://bugs.webkit.org/show_bug.cgi?id=167734
3393         <rdar://problem/30331795>
3394
3395         Reviewed by Simon Fraser.
3396
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3399
3400 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3401
3402         Add support for incremental bytecode cache updates
3403         https://bugs.webkit.org/show_bug.cgi?id=195000
3404
3405         Reviewed by Filip Pizlo.
3406
3407         Exit when the initial run to generate bytecode fails.
3408
3409         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3410
3411 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3412
3413         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3414         https://bugs.webkit.org/show_bug.cgi?id=196744
3415         <rdar://49415309>
3416
3417         Reviewed by Chris Dumez.
3418
3419         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3420         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3421
3422 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3423
3424         Add a way to opt into modern compatibility mode in layout tests
3425         https://bugs.webkit.org/show_bug.cgi?id=196770
3426         <rdar://problem/49777550>
3427
3428         Reviewed by Antoine Quint.
3429
3430         Add a new test option to enable modern compatibility mode in layout tests.
3431
3432         * WebKitTestRunner/TestController.cpp:
3433         (WTR::updateTestOptionsFromTestHeader):
3434         * WebKitTestRunner/TestController.h:
3435         * WebKitTestRunner/TestOptions.h:
3436         (WTR::TestOptions::hasSameInitializationOptions const):
3437         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3438         (WTR::TestController::platformCreateWebView):
3439         (WTR::TestController::enableModernCompatibilityMode):
3440
3441 2019-04-10  Andy Estes  <aestes@apple.com>
3442
3443         Try to fix the 32-bit watchOS build.
3444
3445         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3446         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3447
3448 2019-04-10  Antoine Quint  <graouts@apple.com>
3449
3450         Enable Pointer Events on watchOS
3451         https://bugs.webkit.org/show_bug.cgi?id=196771
3452         <rdar://problem/49040909>
3453
3454         Reviewed by Dean Jackson.
3455
3456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3457
3458 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3459
3460         Unreviewed. Fix WPE accessibility tests after r244059.
3461
3462         We are failing to load the injected bundle due to undefined symbol
3463         AccessibilityUIElement::replaceTextInRange().
3464
3465         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3466         (WTR::AccessibilityUIElement::replaceTextInRange):
3467
3468 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3469
3470         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3471         https://bugs.webkit.org/show_bug.cgi?id=196727
3472
3473         Reviewed by Fujii Hironori.
3474
3475         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3476         (WebKitBrowserWindow::create):
3477
3478 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3479
3480         [ews-build] Add unit tests for PrintConfiguration
3481         https://bugs.webkit.org/show_bug.cgi?id=196752
3482
3483         Reviewed by Dewei Zhu.
3484
3485         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3486
3487 2019-04-09  Keith Rollin  <krollin@apple.com>
3488
3489         Unreviewed build maintenance -- update .xcfilelists.
3490
3491         * DumpRenderTree/DerivedSources-input.xcfilelist:
3492         * DumpRenderTree/DerivedSources-output.xcfilelist:
3493
3494 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3495
3496         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3497         https://bugs.webkit.org/show_bug.cgi?id=196743
3498         <rdar://problem/43897551>
3499
3500         Reviewed by Tim Horton.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3503         (TEST):
3504
3505 2019-04-09  Youenn Fablet  <youenn@apple.com>
3506
3507         Close service worker database on network process suspension
3508         https://bugs.webkit.org/show_bug.cgi?id=196623
3509         <rdar://problem/48930869>
3510
3511         Reviewed by Alex Christensen.
3512
3513         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3514
3515 2019-04-09  Daniel Bates  <dabates@apple.com>
3516
3517         [iPad] Should open popover when the spacebar is pressed
3518         https://bugs.webkit.org/show_bug.cgi?id=196360
3519         <rdar://problem/49389129>
3520
3521         Reviewed by Brent Fulgham.
3522
3523         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3524
3525         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3526         (WTR::UIScriptController::isShowingPopover const): Added.
3527         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3528         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3529         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3530         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3531         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3532         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3533         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3534         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3535         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3536         (WTR::UIScriptController::isShowingPopover const): Added.
3537         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3538         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3539         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3540         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3541         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3542         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3543         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3544         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3545         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3546         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3547         (WTR::UIScriptController::isShowingPopover const): Added.
3548         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3549         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3550
3551 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3552
3553         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3554         https://bugs.webkit.org/show_bug.cgi?id=196665
3555         <rdar://45115669>
3556
3557         Reviewed by Geoff Garen.
3558
3559         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3560         (goBack):
3561         (+[SimpleLookupContext sharedLookupContext]):
3562         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3563         (TEST):
3564         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3565         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3566
3567 2019-04-09  John Wilander  <wilander@apple.com>
3568
3569         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3570         https://bugs.webkit.org/show_bug.cgi?id=196558
3571         <rdar://problem/47650245>
3572
3573         Reviewed by Youenn Fablet.
3574
3575         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3576         (TestWebKitAPI::TEST):
3577             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3578
3579 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3580
3581         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3582         https://bugs.webkit.org/show_bug.cgi?id=196720
3583
3584         Reviewed by Konstantin Tokarev.
3585
3586         * TestWebKitAPI/PlatformMac.cmake:
3587
3588 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3589
3590         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3591         https://bugs.webkit.org/show_bug.cgi?id=196694
3592         <rdar://problem/48388734>
3593
3594         Rubber-stamped by Aakash Jain.
3595
3596         * Scripts/webkitpy/port/image_diff.py:
3597         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3598         * Scripts/webkitpy/port/server_process.py:
3599         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3600         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3601         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3602         * Scripts/webkitpy/port/server_process_mock.py:
3603         (MockServerProcess.has_available_stdout):
3604         * Scripts/webkitpy/port/server_process_unittest.py:
3605         (TestServerProcess.serial_test_basic):
3606
3607 2019-04-09  Jer Noble  <jer.noble@apple.com>
3608
3609         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3610         https://bugs.webkit.org/show_bug.cgi?id=196097
3611
3612         Reviewed by Eric Carlson.
3613
3614         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3615
3616         * DumpRenderTree/mac/DumpRenderTree.mm:
3617         (resetWebPreferencesToConsistentValues):
3618         * WebKitTestRunner/TestController.cpp:
3619         (WTR::TestController::resetPreferencesToConsistentValues):
3620
3621 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3622
3623         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3624         https://bugs.webkit.org/show_bug.cgi?id=196690
3625
3626         Reviewed by Michael Catanzaro.
3627
3628         * QueueStatusServer/config/queues.py:
3629         * Scripts/webkitpy/common/config/ews.json:
3630         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3631         (test_ews_name):
3632
3633 2019-04-09  Chris Dumez  <cdumez@apple.com>
3634
3635         Loads using loadHTMLString() cause flashing when process-swapping
3636         https://bugs.webkit.org/show_bug.cgi?id=196714
3637         <rdar://problem/49637354>
3638
3639         Reviewed by Antti Koivisto.
3640
3641         Add API test coverage.
3642
3643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3644
3645 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3646
3647         Unreviewed. Fix ATK accessibility tests after r244059.
3648
3649         We are failing to load the injected bundle due to undefined symbol
3650         AccessibilityUIElement::replaceTextInRange().
3651
3652         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3653         (WTR::AccessibilityUIElement::replaceTextInRange):
3654
3655 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3656
3657         AX: Support API: accessibilityReplaceRange:withText
3658         https://bugs.webkit.org/show_bug.cgi?id=196636
3659
3660         Unreviewed build fix for Windows port.
3661
3662         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3663         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3664
3665 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3666
3667         [CMake][WinCairo] Separate copied headers into different directories
3668         https://bugs.webkit.org/show_bug.cgi?id=196655
3669
3670         Reviewed by Michael Catanzaro.
3671
3672         * DumpRenderTree/CMakeLists.txt:
3673         * MiniBrowser/win/CMakeLists.txt:
3674         * TestWebKitAPI/CMakeLists.txt:
3675         * TestWebKitAPI/PlatformWin.cmake:
3676
3677 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3678
3679         Log stack-trace for run-webkit-tests when interrupted
3680         https://bugs.webkit.org/show_bug.cgi?id=176393
3681         <rdar://problem/34262310>
3682
3683         Reviewed by Lucas Forschler.
3684
3685         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3686         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3687         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3688         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3689         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3690         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3691         (main): Set handlers to log stack trace on interruption.
3692
3693 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3694
3695         AX: Support API: accessibilityReplaceRange:withText
3696         https://bugs.webkit.org/show_bug.cgi?id=196636
3697
3698         Unreviewed build fix for Windows port.
3699
3700         * DumpRenderTree/AccessibilityUIElement.cpp:
3701         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3702
3703 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3704
3705         [ews-build] Scripts using Buildbot API have CORS error
3706         https://bugs.webkit.org/show_bug.cgi?id=196709
3707
3708         Reviewed by Alexey Proskuryakov.
3709
3710         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3711
3712 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3713
3714         AX: Support API: accessibilityReplaceRange:withText
3715         https://bugs.webkit.org/show_bug.cgi?id=196636
3716
3717         Reviewed by Daniel Bates.
3718
3719         * DumpRenderTree/AccessibilityUIElement.cpp:
3720         (replaceTextInRangeCallback):
3721         (AccessibilityUIElement::replaceTextInRange):
3722         (AccessibilityUIElement::getJSClass):
3723         * DumpRenderTree/AccessibilityUIElement.h:
3724         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3725         (AccessibilityUIElement::replaceTextInRange):
3726         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3727         (AccessibilityUIElement::replaceTextInRange):
3728         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3729         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3730         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3731         (WTR::AccessibilityUIElement::replaceTextInRange):
3732         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3733         (WTR::AccessibilityUIElement::replaceTextInRange):
3734
3735 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3736
3737         [iOS] Do not allow starting selection drags when selection views are not visible
3738         https://bugs.webkit.org/show_bug.cgi?id=196686
3739         <rdar://problem/49399192>
3740
3741         Reviewed by Tim Horton.
3742
3743         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3744         also add some new API tests to cover scenarios where the web view is not first responder.
3745
3746         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3747         (TestWebKitAPI::TEST):
3748         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3749
3750         Add a switch to optionally make the web view first responder when starting the simulated drag.
3751
3752         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3753         (-[DragAndDropSimulator initWithWebView:]):
3754         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3755
3756 2019-04-08  Justin Fan  <justin_fan@apple.com>
3757
3758         [Web GPU] Fix Web GPU experimental feature on iOS
3759         https://bugs.webkit.org/show_bug.cgi?id=196632
3760
3761         Reviewed by Myles C. Maxfield.
3762
3763         Properly make Web GPU available on iOS 11+.
3764
3765         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3766
3767 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3768
3769         [ews-build] Do not upload archive when Compile Fails
3770         https://bugs.webkit.org/show_bug.cgi?id=196674
3771
3772         Reviewed by Alexey Proskuryakov.
3773
3774         * BuildSlaveSupport/ews-build/factories.py:
3775         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3776         * BuildSlaveSupport/ews-build/steps.py:
3777         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3778         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3779         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3780
3781 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3782
3783         Enable DFG on MIPS
3784         https://bugs.webkit.org/show_bug.cgi?id=196689
3785
3786         Reviewed by Žan Doberšek.
3787
3788         Since the bytecode change, we enabled the baseline JIT on mips in
3789         r240432, but DFG is still missing. With this change, all tests are
3790         passing on a ci20 board.
3791
3792         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3793
3794 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3795
3796         [Flatpak] Second run update-webkitwpe-flatpak fails
3797         https://bugs.webkit.org/show_bug.cgi?id=192702
3798
3799         Reviewed by Carlos Garcia Campos.
3800
3801         * flatpak/flatpakutils.py:
3802         (FlatpakObject.flatpak): Fix typo.
3803         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3804         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3805
3806 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3807
3808         [GTK][WPE] outlook.live.com displays old-fashioned UI
3809         https://bugs.webkit.org/show_bug.cgi?id=196642
3810
3811         Reviewed by Carlos Garcia Campos.
3812
3813         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3814         (TestWebKitAPI::TEST): New Mac platform quirk test.
3815
3816 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3817
3818         Unreviewed, rolling out r243956.
3819         https://bugs.webkit.org/show_bug.cgi?id=196688
3820
3821         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3822         by aakashjain on #webkit).
3823
3824         Reverted changeset:
3825
3826         "Clicking "Go Back" from a safe browsing warning from an
3827         iframe should navigate the WKWebView back to the previous
3828         page"
3829         https://bugs.webkit.org/show_bug.cgi?id=196665
3830         https://trac.webkit.org/changeset/243956
3831
3832 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3833
3834         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3835         https://bugs.webkit.org/show_bug.cgi?id=196669
3836
3837         Reviewed by Geoffrey Garen.
3838
3839         Added three new unit tests for WeakHashSet.
3840
3841         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3842         (WTF_WeakPtr.WeakHashSetConstObjects):
3843         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3844         (WTF_WeakPtr.WeakHashSetComputeSize):
3845
3846 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3847
3848         Hide next and previous form control buttons when WKWebView is editable
3849         https://bugs.webkit.org/show_bug.cgi?id=196672
3850         <rdar://problem/35625321>
3851
3852         Reviewed by Tim Horton.
3853
3854         Add a new API test.
3855
3856         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3857         (-[TestWKWebView lastTrailingBarButtonGroup]):
3858         (TestWebKitAPI::TEST):
3859         * TestWebKitAPI/ios/UIKitSPI.h:
3860
3861 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3862
3863         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3864         https://bugs.webkit.org/show_bug.cgi?id=196077
3865         <rdar://problem/49108202>
3866
3867         Reviewed by Chris Dumez.
3868
3869         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3870         on new web view.
3871
3872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3873
3874 2019-04-05  Saam Barati  <sbarati@apple.com>
3875
3876         Make compare-results understand MotionMark
3877         https://bugs.webkit.org/show_bug.cgi?id=196666
3878
3879         Reviewed by Yusuke Suzuki.
3880
3881         * Scripts/compare-results:
3882         (PLT5Results):
3883         (detectMotionMark):
3884         (detectMotionMark1_1):
3885         (motionMarkResults):
3886         (motionMark1_1Results):
3887         (detectBenchmark):
3888         (biggerIsBetter):
3889         (main):
3890
3891 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3892
3893         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3894         https://bugs.webkit.org/show_bug.cgi?id=196665
3895         <rdar://45115669>
3896
3897         Reviewed by Geoff Garen.
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3900         (goBack):
3901         (+[SimpleLookupContext sharedLookupContext]):
3902         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3903         (TEST):
3904         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3905         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3906
3907 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3908
3909         [ews-build] Add configuration and architecture for windows builders
3910         https://bugs.webkit.org/show_bug.cgi?id=196660
3911
3912         Reviewed by Lucas Forschler.
3913
3914         * BuildSlaveSupport/ews-build/config.json:
3915
3916 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3917
3918         webkitpy: Don't run subsequent rounds if interrupted
3919         https://bugs.webkit.org/show_bug.cgi?id=196646
3920
3921         Reviewed by Aakash Jain.
3922
3923         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3924         (Manager.run): Bail out if interrupted.
3925
3926 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3927
3928         Test sessionStorage in PSON private browsing mode
3929         https://bugs.webkit.org/show_bug.cgi?id=196561
3930
3931         Reviewed by Alex Christensen.
3932
3933         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3934
3935 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3936
3937         Unreviewed, rolling out r243833.
3938         https://bugs.webkit.org/show_bug.cgi?id=196645
3939
3940         This change breaks build of WPE and GTK ports (Requested by
3941         annulen on #webkit).
3942
3943         Reverted changeset:
3944
3945         "[CMake][WTF] Mirror XCode header directories"
3946         https://bugs.webkit.org/show_bug.cgi?id=191662
3947         https://trac.webkit.org/changeset/243833
3948
3949 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3950
3951         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3952         https://bugs.webkit.org/show_bug.cgi?id=196635
3953
3954         Reviewed by Antti Koivisto.
3955         
3956         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3957         for a test to enable async frame scrolling via:
3958             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3959         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3960         
3961         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3962
3963         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3964         (WTR::InjectedBundle::beginTesting):
3965         * WebKitTestRunner/TestController.cpp:
3966         (WTR::TestController::resetPreferencesToConsistentValues):
3967
3968 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3969
3970         Use a correct LC_RPATH when building with ASan
3971         https://bugs.webkit.org/show_bug.cgi?id=196576
3972
3973         Reviewed by David Kilzer.
3974
3975         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3976         so that ../Frameworks is checked. This is simpler and more reliable than updating
3977         each SPC service xcconfig.
3978
3979 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3980
3981         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3982         https://bugs.webkit.org/show_bug.cgi?id=196629
3983
3984         Reviewed by Lucas Forschler.
3985
3986         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3987
3988 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3989
3990         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3991         https://bugs.webkit.org/show_bug.cgi?id=196618
3992
3993         Reviewed by Lucas Forschler.
3994
3995         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3996         (StatusBubble): Added QUEUE_TRIGGERS.
3997         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3998         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3999         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
4000         its parent(builder).
4001
4002 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4003
4004         [ews-app] Status-bubble steps are sometimes displayed in reverse order
4005         https://bugs.webkit.org/show_bug.cgi?id=196625
4006
4007         Reviewed by Lucas Forschler.
4008
4009         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4010         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
4011
4012 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4013
4014         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4015         https://bugs.webkit.org/show_bug.cgi?id=196630
4016
4017         Reviewed by Wenson Hsieh.
4018
4019         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4020
4021 2019-04-04  Youenn Fablet  <youenn@apple.com>
4022
4023         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
4024         https://bugs.webkit.org/show_bug.cgi?id=196543
4025
4026         Reviewed by Alex Christensen.
4027
4028         * WebKitTestRunner/TestController.cpp:
4029         (WTR::TestController::generatePageConfiguration):
4030
4031 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4032
4033         [ews-app] Status bubble should not display skipped buildbot steps
4034         https://bugs.webkit.org/show_bug.cgi?id=196584
4035
4036         Reviewed by Lucas Forschler.
4037
4038         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4039
4040 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
4041
4042         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
4043         https://bugs.webkit.org/show_bug.cgi?id=196620
4044
4045         Reviewed by Lucas Forschler.
4046
4047         * BuildSlaveSupport/ews-app/ews/config.py:
4048
4049 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
4050
4051         [Win] DumpRenderTreeWatchDog.py is not checked into source
4052         https://bugs.webkit.org/show_bug.cgi?id=196567
4053         <rdar://problem/49525901>
4054
4055         Reviewed by Lucas Forschler.
4056
4057         This script is used on Win EWS bots to terminate hanging DRT processes.
4058
4059         * EWSTools/dumprendertreewatchdog.py: Added.
4060
4061 2019-04-04  Chris Dumez  <cdumez@apple.com>
4062
4063         Unreviewed, roll out r243858 which made tests time out.
4064
4065         Disable new API tests on Windows instead.
4066
4067         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4068         (TestWebKitAPI::TEST):
4069
4070 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4071
4072         [ATK] Cleanup WebPageAccessibilityObjectAtk
4073         https://bugs.webkit.org/show_bug.cgi?id=196537
4074
4075         Reviewed by Michael Catanzaro.
4076
4077         Also consider files under atk directories as exceptions for GObject conventions.
4078
4079         * Scripts/webkitpy/style/checkers/cpp.py:
4080         (check_identifier_name_in_declaration):
4081
4082 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
4083
4084         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4085         https://bugs.webkit.org/show_bug.cgi?id=196588
4086         <rdar://problem/49365787>
4087
4088         Unreviewed build fix for Windows port.
4089
4090         error C3861: 'kill': identifier not found
4091
4092         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4093         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
4094
4095 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4096
4097         [ews-build] Cancel build and similar operations should have authentication
4098         https://bugs.webkit.org/show_bug.cgi?id=196520
4099
4100         Reviewed by Dewei Zhu.
4101
4102         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
4103         environment variables.
4104
4105 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4106
4107         [ews-build] Do not trigger queues which are not in production yet
4108         https://bugs.webkit.org/show_bug.cgi?id=196581
4109
4110         Reviewed by Dewei Zhu.
4111
4112         * BuildSlaveSupport/ews-build/config.json:
4113
4114 2019-04-03  Chris Dumez  <cdumez@apple.com>
4115
4116         Unreviewed, fix typo in the name of API test added in r243848.
4117
4118         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4119         (TestWebKitAPI::TEST):
4120
4121 2019-04-03  Chris Dumez  <cdumez@apple.com>
4122
4123         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
4124         https://bugs.webkit.org/show_bug.cgi?id=196588
4125         <rdar://problem/49365787>
4126
4127         Reviewed by Ryosuke Niwa.
4128
4129         Add API test coverage.
4130
4131         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4132         (TestWebKitAPI::nullJavaScriptCallback):
4133         (TestWebKitAPI::didCrashCheckFrames):
4134         (TestWebKitAPI::TEST):
4135
4136 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4137
4138         run-webkit-tests: Upload test results (new results database)
4139         https://bugs.webkit.org/show_bug.cgi?id=196577
4140         <rdar://problem/34841155>
4141
4142         Reviewed by Lucas Forschler.
4143
4144         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4145         (Manager.run): Upload results after each device shard, since the configuration will be
4146         different for each device.
4147         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
4148         uploaded to a results database.
4149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4150         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
4151
4152 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4153
4154         -apple-trailing-word is needed for browser detection
4155         https://bugs.webkit.org/show_bug.cgi?id=196575
4156
4157         Unreviewed.
4158
4159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4160
4161 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
4162
4163         [CMake][WTF] Mirror XCode header directories
4164         https://bugs.webkit.org/show_bug.cgi?id=191662
4165
4166         Reviewed by Konstantin Tokarev.
4167
4168         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
4169         builds.
4170
4171         * CMakeLists.txt:
4172         * DumpRenderTree/CMakeLists.txt:
4173         * DumpRenderTree/PlatformWin.cmake:
4174         * MiniBrowser/win/CMakeLists.txt:
4175         * TestWebKitAPI/CMakeLists.txt:
4176         * TestWebKitAPI/PlatformWin.cmake:
4177         * WebKitTestRunner/PlatformGTK.cmake:
4178         * WebKitTestRunner/PlatformWin.cmake:
4179
4180 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4181
4182         [ews-app] Status bubble should not display certain infrastructure status messages
4183         https://bugs.webkit.org/show_bug.cgi?id=196550
4184
4185         Reviewed by Lucas Forschler.
4186
4187         Do not display the steps which are un-needed for end-user. This information is still avaiable
4188         if the user click on the bubble and look at the Buildbot build.
4189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4190         (StatusBubble._steps_messages):
4191         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
4192
4193 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
4194
4195         [ews-build] Use https for sending data to ews-app
4196         https://bugs.webkit.org/show_bug.cgi?id=196492
4197
4198         Reviewed by Lucas Forschler.
4199
4200         * BuildSlaveSupport/ews-build/events.py:
4201
4202 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
4203
4204         Remove support for -apple-trailing-word
4205         https://bugs.webkit.org/show_bug.cgi?id=196525
4206
4207         Reviewed by Zalan Bujtas.
4208
4209         This CSS property is nonstandard and not used.
4210
4211         * Scripts/webkitperl/FeatureList.pm:
4212         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4213
4214 2019-04-03  Youenn Fablet  <youenn@apple.com>
4215
4216         Add a test for DOMCache on multiple browsing in case of private browsing
4217         https://bugs.webkit.org/show_bug.cgi?id=196524
4218
4219         Reviewed by Alex Christensen.
4220
4221         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4222         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
4223
4224 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
4225
4226         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
4227         https://bugs.webkit.org/show_bug.cgi?id=196540
4228
4229         Reviewed by Aakash Jain.
4230
4231         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
4232
4233 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4234
4235         Add plumbing for a compatibility mode preference in WebKit
4236         https://bugs.webkit.org/show_bug.cgi?id=196005
4237
4238         Reviewed by Tim Horton.
4239
4240         Add new API tests.
4241
4242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4243         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
4244
4245 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
4246
4247         [WPE][GTK] Update libsrtp dependency package for Debian
4248         https://bugs.webkit.org/show_bug.cgi?id=196528
4249
4250         Reviewed by Frédéric Wang.
4251
4252         * gtk/install-dependencies:
4253         * wpe/install-dependencies:
4254
4255 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
4256
4257         [WK2] Add support for Window's beforeprint / afterprint events
4258         https://bugs.webkit.org/show_bug.cgi?id=196478
4259         <rdar://problem/49535124>
4260
4261         Unreviewed build fix for MSVC.
4262
4263         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
4264
4265         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
4266
4267         * WebKitTestRunner/TestController.cpp:
4268         (WTR::printFrame): Use int and float literals.
4269
4270 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4271
4272         [ews-build] Reassign bots to queues
4273
4274         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
4275
4276 2019-04-02  Chris Dumez  <cdumez@apple.com>
4277
4278         [WK2] Add support for Window's beforeprint / afterprint events
4279         https://bugs.webkit.org/show_bug.cgi?id=196478
4280
4281         Reviewed by Alex Christensen.
4282
4283         Add minimal implementation for printFrame in WebKitTestRunner.
4284
4285         * WebKitTestRunner/TestController.cpp:
4286         (WTR::printFrame):
4287         (WTR::TestController::createOtherPage):
4288         (WTR::TestController::createWebViewWithOptions):
4289
4290 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4291
4292         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
4293         https://bugs.webkit.org/show_bug.cgi?id=196491
4294
4295         Reviewed by Lucas Forschler.
4296
4297         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4298
4299 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4300
4301         [ews-build] Configure buildbot try credentials in environment variables
4302         https://bugs.webkit.org/show_bug.cgi?id=196501
4303
4304         Reviewed by Lucas Forschler.
4305
4306         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
4307         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
4308         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
4309
4310 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4311
4312         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
4313         https://bugs.webkit.org/show_bug.cgi?id=196496
4314         <rdar://problem/49521634>
4315
4316         Reviewed by Chris Dumez.
4317
4318         Add new API tests (see WebKit ChangeLog for more detail).
4319
4320         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4321         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4322         (TEST):
4323
4324 2019-04-02  David Kilzer  <ddkilzer@apple.com>
4325
4326         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
4327         <https://webkit.org/b/196499>
4328
4329         Reviewed by Alexey Proskuryakov.
4330
4331         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to