[CMake] Apple builds should use ICU_INCLUDE_DIRS
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake] Apple builds should use ICU_INCLUDE_DIRS
4         https://bugs.webkit.org/show_bug.cgi?id=196720
5
6         Reviewed by Konstantin Tokarev.
7
8         * TestWebKitAPI/PlatformMac.cmake:
9
10 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
11
12         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
13         https://bugs.webkit.org/show_bug.cgi?id=196694
14         <rdar://problem/48388734>
15
16         Rubber-stamped by Aakash Jain.
17
18         * Scripts/webkitpy/port/image_diff.py:
19         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
20         * Scripts/webkitpy/port/server_process.py:
21         (ServerProcess.has_available_stdout): Check if stdout has data in it.
22         (ServerProcess._wait_for_data_and_update_buffers_using_select):
23         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
24         * Scripts/webkitpy/port/server_process_mock.py:
25         (MockServerProcess.has_available_stdout):
26         * Scripts/webkitpy/port/server_process_unittest.py:
27         (TestServerProcess.serial_test_basic):
28
29 2019-04-09  Jer Noble  <jer.noble@apple.com>
30
31         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
32         https://bugs.webkit.org/show_bug.cgi?id=196097
33
34         Reviewed by Eric Carlson.
35
36         Drive-by bug fix: allow tests to play audio without a user gesture by default.
37
38         * DumpRenderTree/mac/DumpRenderTree.mm:
39         (resetWebPreferencesToConsistentValues):
40         * WebKitTestRunner/TestController.cpp:
41         (WTR::TestController::resetPreferencesToConsistentValues):
42
43 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
44
45         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
46         https://bugs.webkit.org/show_bug.cgi?id=196690
47
48         Reviewed by Michael Catanzaro.
49
50         * QueueStatusServer/config/queues.py:
51         * Scripts/webkitpy/common/config/ews.json:
52         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
53         (test_ews_name):
54
55 2019-04-09  Chris Dumez  <cdumez@apple.com>
56
57         Loads using loadHTMLString() cause flashing when process-swapping
58         https://bugs.webkit.org/show_bug.cgi?id=196714
59         <rdar://problem/49637354>
60
61         Reviewed by Antti Koivisto.
62
63         Add API test coverage.
64
65         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
66
67 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         Unreviewed. Fix ATK accessibility tests after r244059.
70
71         We are failing to load the injected bundle due to undefined symbol
72         AccessibilityUIElement::replaceTextInRange().
73
74         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
75         (WTR::AccessibilityUIElement::replaceTextInRange):
76
77 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
78
79         AX: Support API: accessibilityReplaceRange:withText
80         https://bugs.webkit.org/show_bug.cgi?id=196636
81
82         Unreviewed build fix for Windows port.
83
84         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
85         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
86
87 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
88
89         [CMake][WinCairo] Separate copied headers into different directories
90         https://bugs.webkit.org/show_bug.cgi?id=196655
91
92         Reviewed by Michael Catanzaro.
93
94         * DumpRenderTree/CMakeLists.txt:
95         * MiniBrowser/win/CMakeLists.txt:
96         * TestWebKitAPI/CMakeLists.txt:
97         * TestWebKitAPI/PlatformWin.cmake:
98
99 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
100
101         Log stack-trace for run-webkit-tests when interrupted
102         https://bugs.webkit.org/show_bug.cgi?id=176393
103         <rdar://problem/34262310>
104
105         Reviewed by Lucas Forschler.
106
107         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
108         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
109         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
110         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
111         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
113         (main): Set handlers to log stack trace on interruption.
114
115 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
116
117         AX: Support API: accessibilityReplaceRange:withText
118         https://bugs.webkit.org/show_bug.cgi?id=196636
119
120         Unreviewed build fix for Windows port.
121
122         * DumpRenderTree/AccessibilityUIElement.cpp:
123         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
124
125 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
126
127         [ews-build] Scripts using Buildbot API have CORS error
128         https://bugs.webkit.org/show_bug.cgi?id=196709
129
130         Reviewed by Alexey Proskuryakov.
131
132         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
133
134 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
135
136         AX: Support API: accessibilityReplaceRange:withText
137         https://bugs.webkit.org/show_bug.cgi?id=196636
138
139         Reviewed by Daniel Bates.
140
141         * DumpRenderTree/AccessibilityUIElement.cpp:
142         (replaceTextInRangeCallback):
143         (AccessibilityUIElement::replaceTextInRange):
144         (AccessibilityUIElement::getJSClass):
145         * DumpRenderTree/AccessibilityUIElement.h:
146         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
147         (AccessibilityUIElement::replaceTextInRange):
148         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
149         (AccessibilityUIElement::replaceTextInRange):
150         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
151         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
152         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
153         (WTR::AccessibilityUIElement::replaceTextInRange):
154         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
155         (WTR::AccessibilityUIElement::replaceTextInRange):
156
157 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
158
159         [iOS] Do not allow starting selection drags when selection views are not visible
160         https://bugs.webkit.org/show_bug.cgi?id=196686
161         <rdar://problem/49399192>
162
163         Reviewed by Tim Horton.
164
165         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
166         also add some new API tests to cover scenarios where the web view is not first responder.
167
168         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
171
172         Add a switch to optionally make the web view first responder when starting the simulated drag.
173
174         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
175         (-[DragAndDropSimulator initWithWebView:]):
176         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
177
178 2019-04-08  Justin Fan  <justin_fan@apple.com>
179
180         [Web GPU] Fix Web GPU experimental feature on iOS
181         https://bugs.webkit.org/show_bug.cgi?id=196632
182
183         Reviewed by Myles C. Maxfield.
184
185         Properly make Web GPU available on iOS 11+.
186
187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
188
189 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews-build] Do not upload archive when Compile Fails
192         https://bugs.webkit.org/show_bug.cgi?id=196674
193
194         Reviewed by Alexey Proskuryakov.
195
196         * BuildSlaveSupport/ews-build/factories.py:
197         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
198         * BuildSlaveSupport/ews-build/steps.py:
199         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
200         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
201         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
202
203 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
204
205         Enable DFG on MIPS
206         https://bugs.webkit.org/show_bug.cgi?id=196689
207
208         Reviewed by Žan Doberšek.
209
210         Since the bytecode change, we enabled the baseline JIT on mips in
211         r240432, but DFG is still missing. With this change, all tests are
212         passing on a ci20 board.
213
214         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
215
216 2019-04-08  Philippe Normand  <pnormand@igalia.com>
217
218         [Flatpak] Second run update-webkitwpe-flatpak fails
219         https://bugs.webkit.org/show_bug.cgi?id=192702
220
221         Reviewed by Carlos Garcia Campos.
222
223         * flatpak/flatpakutils.py:
224         (FlatpakObject.flatpak): Fix typo.
225         (FlatpakPackage.install): When installing, also update to the configured remote commit.
226         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
227
228 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
229
230         [GTK][WPE] outlook.live.com displays old-fashioned UI
231         https://bugs.webkit.org/show_bug.cgi?id=196642
232
233         Reviewed by Carlos Garcia Campos.
234
235         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
236         (TestWebKitAPI::TEST): New Mac platform quirk test.
237
238 2019-04-07  Commit Queue  <commit-queue@webkit.org>
239
240         Unreviewed, rolling out r243956.
241         https://bugs.webkit.org/show_bug.cgi?id=196688
242
243         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
244         by aakashjain on #webkit).
245
246         Reverted changeset:
247
248         "Clicking "Go Back" from a safe browsing warning from an
249         iframe should navigate the WKWebView back to the previous
250         page"
251         https://bugs.webkit.org/show_bug.cgi?id=196665
252         https://trac.webkit.org/changeset/243956
253
254 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
255
256         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
257         https://bugs.webkit.org/show_bug.cgi?id=196669
258
259         Reviewed by Geoffrey Garen.
260
261         Added three new unit tests for WeakHashSet.
262
263         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
264         (WTF_WeakPtr.WeakHashSetConstObjects):
265         (WTF_WeakPtr.WeakHashSetComputesEmpty):
266         (WTF_WeakPtr.WeakHashSetComputeSize):
267
268 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
269
270         Hide next and previous form control buttons when WKWebView is editable
271         https://bugs.webkit.org/show_bug.cgi?id=196672
272         <rdar://problem/35625321>
273
274         Reviewed by Tim Horton.
275
276         Add a new API test.
277
278         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
279         (-[TestWKWebView lastTrailingBarButtonGroup]):
280         (TestWebKitAPI::TEST):
281         * TestWebKitAPI/ios/UIKitSPI.h:
282
283 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
284
285         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
286         https://bugs.webkit.org/show_bug.cgi?id=196077
287         <rdar://problem/49108202>
288
289         Reviewed by Chris Dumez.
290
291         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
292         on new web view.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
295
296 2019-04-05  Saam Barati  <sbarati@apple.com>
297
298         Make compare-results understand MotionMark
299         https://bugs.webkit.org/show_bug.cgi?id=196666
300
301         Reviewed by Yusuke Suzuki.
302
303         * Scripts/compare-results:
304         (PLT5Results):
305         (detectMotionMark):
306         (detectMotionMark1_1):
307         (motionMarkResults):
308         (motionMark1_1Results):
309         (detectBenchmark):
310         (biggerIsBetter):
311         (main):
312
313 2019-04-05  Alex Christensen  <achristensen@webkit.org>
314
315         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
316         https://bugs.webkit.org/show_bug.cgi?id=196665
317         <rdar://45115669>
318
319         Reviewed by Geoff Garen.
320
321         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
322         (goBack):
323         (+[SimpleLookupContext sharedLookupContext]):
324         (-[SimpleLookupContext lookUpURL:completionHandler:]):
325         (TEST):
326         (+[Simple3LookupContext sharedLookupContext]): Deleted.
327         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
328
329 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-build] Add configuration and architecture for windows builders
332         https://bugs.webkit.org/show_bug.cgi?id=196660
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-build/config.json:
337
338 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
339
340         webkitpy: Don't run subsequent rounds if interrupted
341         https://bugs.webkit.org/show_bug.cgi?id=196646
342
343         Reviewed by Aakash Jain.
344
345         * Scripts/webkitpy/layout_tests/controllers/manager.py:
346         (Manager.run): Bail out if interrupted.
347
348 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
349
350         Test sessionStorage in PSON private browsing mode
351         https://bugs.webkit.org/show_bug.cgi?id=196561
352
353         Reviewed by Alex Christensen.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
356
357 2019-04-05  Commit Queue  <commit-queue@webkit.org>
358
359         Unreviewed, rolling out r243833.
360         https://bugs.webkit.org/show_bug.cgi?id=196645
361
362         This change breaks build of WPE and GTK ports (Requested by
363         annulen on #webkit).
364
365         Reverted changeset:
366
367         "[CMake][WTF] Mirror XCode header directories"
368         https://bugs.webkit.org/show_bug.cgi?id=191662
369         https://trac.webkit.org/changeset/243833
370
371 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
372
373         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
374         https://bugs.webkit.org/show_bug.cgi?id=196635
375
376         Reviewed by Antti Koivisto.
377         
378         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
379         for a test to enable async frame scrolling via:
380             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
381         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
382         
383         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
384
385         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
386         (WTR::InjectedBundle::beginTesting):
387         * WebKitTestRunner/TestController.cpp:
388         (WTR::TestController::resetPreferencesToConsistentValues):
389
390 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
391
392         Use a correct LC_RPATH when building with ASan
393         https://bugs.webkit.org/show_bug.cgi?id=196576
394
395         Reviewed by David Kilzer.
396
397         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
398         so that ../Frameworks is checked. This is simpler and more reliable than updating
399         each SPC service xcconfig.
400
401 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
402
403         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
404         https://bugs.webkit.org/show_bug.cgi?id=196629
405
406         Reviewed by Lucas Forschler.
407
408         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
409
410 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
411
412         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
413         https://bugs.webkit.org/show_bug.cgi?id=196618
414
415         Reviewed by Lucas Forschler.
416
417         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
418         (StatusBubble): Added QUEUE_TRIGGERS.
419         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
420         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
421         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
422         its parent(builder).
423
424 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
425
426         [ews-app] Status-bubble steps are sometimes displayed in reverse order
427         https://bugs.webkit.org/show_bug.cgi?id=196625
428
429         Reviewed by Lucas Forschler.
430
431         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
432         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
433
434 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
435
436         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
437         https://bugs.webkit.org/show_bug.cgi?id=196630
438
439         Reviewed by Wenson Hsieh.
440
441         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
442
443 2019-04-04  Youenn Fablet  <youenn@apple.com>
444
445         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
446         https://bugs.webkit.org/show_bug.cgi?id=196543
447
448         Reviewed by Alex Christensen.
449
450         * WebKitTestRunner/TestController.cpp:
451         (WTR::TestController::generatePageConfiguration):
452
453 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-app] Status bubble should not display skipped buildbot steps
456         https://bugs.webkit.org/show_bug.cgi?id=196584
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
461
462 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
463
464         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
465         https://bugs.webkit.org/show_bug.cgi?id=196620
466
467         Reviewed by Lucas Forschler.
468
469         * BuildSlaveSupport/ews-app/ews/config.py:
470
471 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
472
473         [Win] DumpRenderTreeWatchDog.py is not checked into source
474         https://bugs.webkit.org/show_bug.cgi?id=196567
475         <rdar://problem/49525901>
476
477         Reviewed by Lucas Forschler.
478
479         This script is used on Win EWS bots to terminate hanging DRT processes.
480
481         * EWSTools/dumprendertreewatchdog.py: Added.
482
483 2019-04-04  Chris Dumez  <cdumez@apple.com>
484
485         Unreviewed, roll out r243858 which made tests time out.
486
487         Disable new API tests on Windows instead.
488
489         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
490         (TestWebKitAPI::TEST):
491
492 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
493
494         [ATK] Cleanup WebPageAccessibilityObjectAtk
495         https://bugs.webkit.org/show_bug.cgi?id=196537
496
497         Reviewed by Michael Catanzaro.
498
499         Also consider files under atk directories as exceptions for GObject conventions.
500
501         * Scripts/webkitpy/style/checkers/cpp.py:
502         (check_identifier_name_in_declaration):
503
504 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
505
506         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
507         https://bugs.webkit.org/show_bug.cgi?id=196588
508         <rdar://problem/49365787>
509
510         Unreviewed build fix for Windows port.
511
512         error C3861: 'kill': identifier not found
513
514         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
515         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
516
517 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-build] Cancel build and similar operations should have authentication
520         https://bugs.webkit.org/show_bug.cgi?id=196520
521
522         Reviewed by Dewei Zhu.
523
524         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
525         environment variables.
526
527 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-build] Do not trigger queues which are not in production yet
530         https://bugs.webkit.org/show_bug.cgi?id=196581
531
532         Reviewed by Dewei Zhu.
533
534         * BuildSlaveSupport/ews-build/config.json:
535
536 2019-04-03  Chris Dumez  <cdumez@apple.com>
537
538         Unreviewed, fix typo in the name of API test added in r243848.
539
540         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
541         (TestWebKitAPI::TEST):
542
543 2019-04-03  Chris Dumez  <cdumez@apple.com>
544
545         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
546         https://bugs.webkit.org/show_bug.cgi?id=196588
547         <rdar://problem/49365787>
548
549         Reviewed by Ryosuke Niwa.
550
551         Add API test coverage.
552
553         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
554         (TestWebKitAPI::nullJavaScriptCallback):
555         (TestWebKitAPI::didCrashCheckFrames):
556         (TestWebKitAPI::TEST):
557
558 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
559
560         run-webkit-tests: Upload test results (new results database)
561         https://bugs.webkit.org/show_bug.cgi?id=196577
562         <rdar://problem/34841155>
563
564         Reviewed by Lucas Forschler.
565
566         * Scripts/webkitpy/layout_tests/controllers/manager.py:
567         (Manager.run): Upload results after each device shard, since the configuration will be
568         different for each device.
569         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
570         uploaded to a results database.
571         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
572         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
573
574 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
575
576         -apple-trailing-word is needed for browser detection
577         https://bugs.webkit.org/show_bug.cgi?id=196575
578
579         Unreviewed.
580
581         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
582
583 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
584
585         [CMake][WTF] Mirror XCode header directories
586         https://bugs.webkit.org/show_bug.cgi?id=191662
587
588         Reviewed by Konstantin Tokarev.
589
590         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
591         builds.
592
593         * CMakeLists.txt:
594         * DumpRenderTree/CMakeLists.txt:
595         * DumpRenderTree/PlatformWin.cmake:
596         * MiniBrowser/win/CMakeLists.txt:
597         * TestWebKitAPI/CMakeLists.txt:
598         * TestWebKitAPI/PlatformWin.cmake:
599         * WebKitTestRunner/PlatformGTK.cmake:
600         * WebKitTestRunner/PlatformWin.cmake:
601
602 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
603
604         [ews-app] Status bubble should not display certain infrastructure status messages
605         https://bugs.webkit.org/show_bug.cgi?id=196550
606
607         Reviewed by Lucas Forschler.
608
609         Do not display the steps which are un-needed for end-user. This information is still avaiable
610         if the user click on the bubble and look at the Buildbot build.
611         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
612         (StatusBubble._steps_messages):
613         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
614
615 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
616
617         [ews-build] Use https for sending data to ews-app
618         https://bugs.webkit.org/show_bug.cgi?id=196492
619
620         Reviewed by Lucas Forschler.
621
622         * BuildSlaveSupport/ews-build/events.py:
623
624 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
625
626         Remove support for -apple-trailing-word
627         https://bugs.webkit.org/show_bug.cgi?id=196525
628
629         Reviewed by Zalan Bujtas.
630
631         This CSS property is nonstandard and not used.
632
633         * Scripts/webkitperl/FeatureList.pm:
634         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
635
636 2019-04-03  Youenn Fablet  <youenn@apple.com>
637
638         Add a test for DOMCache on multiple browsing in case of private browsing
639         https://bugs.webkit.org/show_bug.cgi?id=196524
640
641         Reviewed by Alex Christensen.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
644         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
645
646 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
647
648         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
649         https://bugs.webkit.org/show_bug.cgi?id=196540
650
651         Reviewed by Aakash Jain.
652
653         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
654
655 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
656
657         Add plumbing for a compatibility mode preference in WebKit
658         https://bugs.webkit.org/show_bug.cgi?id=196005
659
660         Reviewed by Tim Horton.
661
662         Add new API tests.
663
664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
665         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
666
667 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
668
669         [WPE][GTK] Update libsrtp dependency package for Debian
670         https://bugs.webkit.org/show_bug.cgi?id=196528
671
672         Reviewed by Frédéric Wang.
673
674         * gtk/install-dependencies:
675         * wpe/install-dependencies:
676
677 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
678
679         [WK2] Add support for Window's beforeprint / afterprint events
680         https://bugs.webkit.org/show_bug.cgi?id=196478
681         <rdar://problem/49535124>
682
683         Unreviewed build fix for MSVC.
684
685         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
686
687         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
688
689         * WebKitTestRunner/TestController.cpp:
690         (WTR::printFrame): Use int and float literals.
691
692 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
693
694         [ews-build] Reassign bots to queues
695
696         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
697
698 2019-04-02  Chris Dumez  <cdumez@apple.com>
699
700         [WK2] Add support for Window's beforeprint / afterprint events
701         https://bugs.webkit.org/show_bug.cgi?id=196478
702
703         Reviewed by Alex Christensen.
704
705         Add minimal implementation for printFrame in WebKitTestRunner.
706
707         * WebKitTestRunner/TestController.cpp:
708         (WTR::printFrame):
709         (WTR::TestController::createOtherPage):
710         (WTR::TestController::createWebViewWithOptions):
711
712 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
713
714         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
715         https://bugs.webkit.org/show_bug.cgi?id=196491
716
717         Reviewed by Lucas Forschler.
718
719         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
720
721 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
722
723         [ews-build] Configure buildbot try credentials in environment variables
724         https://bugs.webkit.org/show_bug.cgi?id=196501
725
726         Reviewed by Lucas Forschler.
727
728         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
729         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
730         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
731
732 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
733
734         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
735         https://bugs.webkit.org/show_bug.cgi?id=196496
736         <rdar://problem/49521634>
737
738         Reviewed by Chris Dumez.
739
740         Add new API tests (see WebKit ChangeLog for more detail).
741
742         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
743         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
744         (TEST):
745
746 2019-04-02  David Kilzer  <ddkilzer@apple.com>
747
748         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
749         <https://webkit.org/b/196499>
750
751         Reviewed by Alexey Proskuryakov.
752
753         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
754         ENABLE_ADDRESS_SANITIZER.
755
756 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
757
758         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
759         https://bugs.webkit.org/show_bug.cgi?id=182757
760
761         Reviewed by Don Olmstead.
762
763         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
764         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
765
766 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
767
768         run-api-tests: Upload test results
769         https://bugs.webkit.org/show_bug.cgi?id=196323
770         <rdar://problem/49356714>
771
772         Reviewed by Lucas Forschler.
773
774         * Scripts/webkitpy/api_tests/manager.py:
775         (Manager):
776         (Manager.run): Upload results to a results database.
777         * Scripts/webkitpy/api_tests/run_api_tests.py:
778         (parse_args): Add upload arguments.
779         * Scripts/webkitpy/port/base.py:
780         (Port):
781         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
782         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
783         with commits from any other associated repositories.
784         * Scripts/webkitpy/port/device.py:
785         (Device):
786         (Device.build_version): Access build_versoin of underlying platform device.
787         * Scripts/webkitpy/port/ios_simulator_unittest.py:
788         (IOSSimulatorTest):
789         (IOSSimulatorTest.test_configuration_for_upload):
790         * Scripts/webkitpy/port/device_port.py:
791         (DevicePort):
792         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
793         the same as the machine uploading results.
794         * Scripts/webkitpy/port/mac.py:
795         (MacPort):
796         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
797         * Scripts/webkitpy/port/mac_unittest.py:
798         (MacTest):
799         (MacTest.test_configuration_for_upload):
800         * Scripts/webkitpy/xcode/simulated_device.py:
801         (SimulatedDeviceManager._create_device_with_runtime):
802         (SimulatedDevice.__init__): Create simulated device with a build_version.
803         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
804         (test_existing_simulator):
805
806 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
807
808         Remove extra newline characters (Follow-up fix to r243707)
809
810         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
811
812 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
813
814         [ews-app] Use API_KEY to accept results data
815         https://bugs.webkit.org/show_bug.cgi?id=196461
816
817         Reviewed by Dewei Zhu.
818
819         * BuildSlaveSupport/ews-app/ews/views/results.py:
820         (Results.post): Validate EWS_API_KEY before accepting any data.
821         * BuildSlaveSupport/ews-build/events.py:
822         (Events.sendData): Send EWS_API_KEY if available along with event data.
823
824 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         Unable to copy and paste a PDF from Notes into Mail compose body
827         https://bugs.webkit.org/show_bug.cgi?id=196442
828         <rdar://problem/48573098>
829
830         Reviewed by Tim Horton.
831
832         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
833         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
834         to be specified on the item providers.
835
836         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
837         (TestWebKitAPI::mapItemForTesting):
838         (TestWebKitAPI::contactItemForTesting):
839
840 2019-04-01  Tim Horton  <timothy_horton@apple.com>
841
842         Make UIWKDocumentContext rects per-character instead of per-word
843         https://bugs.webkit.org/show_bug.cgi?id=196459
844
845         Reviewed by Wenson Hsieh.
846
847         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
848         (TEST):
849         Adjust test results due to switching to per-character rects.
850
851 2019-04-01  Chris Dumez  <cdumez@apple.com>
852
853         UIProcess crash when a prewarmed process is terminated
854         https://bugs.webkit.org/show_bug.cgi?id=196451
855         <rdar://problem/49245471>
856
857         Reviewed by Geoffrey Garen.
858
859         Add API test coverage.
860
861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
862         (TEST):
863
864 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
865
866         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
867         https://bugs.webkit.org/show_bug.cgi?id=196449
868
869         Reviewed by Lucas Forschler.
870
871         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
872         (StatusBubble.get_os_details): Method to get OS and Xcode details.
873         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
874         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
875
876 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
877
878         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
879         https://bugs.webkit.org/show_bug.cgi?id=196444
880
881         Reviewed by Lucas Forschler.
882
883         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
884
885 2019-04-01  Alex Christensen  <achristensen@webkit.org>
886
887         Add SPI to canonicalize NSURLs with WTF::URL
888         https://bugs.webkit.org/show_bug.cgi?id=196415
889         <rdar://problem/44980271>
890
891         Reviewed by Darin Adler.
892
893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
894         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
895         (TestWebKitAPI::TEST):
896
897 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
898
899         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
900         https://bugs.webkit.org/show_bug.cgi?id=196441
901
902         Reviewed by Carlos Garcia Campos.
903
904         Don't cache the wpe_view_backend object that might not exist yet at the
905         time of EventSenderProxy constructor invocation, but instead retrieve
906         that object whenever it's required for event dispatching. This should
907         avoid crashes in this constructor now that it's invoked before any
908         PlatformWindow has been set up (as changed in r243496).
909
910         * WebKitTestRunner/EventSenderProxy.h:
911         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
912         (WTR::viewBackend):
913         (WTR::EventSenderProxy::EventSenderProxy):
914         (WTR::EventSenderProxy::mouseDown):
915         (WTR::EventSenderProxy::mouseUp):
916         (WTR::EventSenderProxy::mouseMoveTo):
917         (WTR::EventSenderProxy::mouseScrollBy):
918         (WTR::EventSenderProxy::keyDown):
919         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
920
921 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
922
923         [Win][WebKit] MiniBrowser should support high DPI display
924         https://bugs.webkit.org/show_bug.cgi?id=196391
925
926         Reviewed by Alex Christensen.
927
928         * MiniBrowser/win/WebKitBrowserWindow.cpp:
929         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
930         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
931         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
932
933 2019-03-31  Sam Weinig  <weinig@apple.com>
934
935         Remove more i386 specific configurations
936         https://bugs.webkit.org/show_bug.cgi?id=196430
937
938         Reviewed by Alexey Proskuryakov.
939
940         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
941         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
942
943 2019-03-31  Andy Estes  <aestes@apple.com>
944
945         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
946         https://bugs.webkit.org/show_bug.cgi?id=196433
947         <rdar://problem/49293305>
948
949         Reviewed by Tim Horton.
950
951         Enhanced API test coverage to include all navigation response policy decisions in both
952         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
953
954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
955         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
958         (readFile):
959         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
960         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
961         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
962         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
963         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
964         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
965         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
966         (-[QuickLookDelegate _downloadDidStart:]):
967         (-[QuickLookDelegate _download:didReceiveResponse:]):
968         (-[QuickLookDelegate _download:didReceiveData:]):
969         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
970         (-[QuickLookDelegate _downloadDidFinish:]):
971         (-[QuickLookDelegate _download:didFailWithError:]):
972         (-[QuickLookDelegate _downloadDidCancel:]):
973         (-[QuickLookDelegate verifyDownload]):
974         (runTest):
975         (runTestDecideBeforeLoading):
976         (runTestDecideAfterLoading):
977         (TEST):
978         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
979         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
980         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
981         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
982         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
983         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
984         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
985         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
986         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
987         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
988         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
989         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
990         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
991         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
992
993 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
994
995         [CMake] add testdfg as target with build-jsc
996         https://bugs.webkit.org/show_bug.cgi?id=196393
997
998         Reviewed by Saam Barati.
999
1000         Added testdfg as one of the targets to build when
1001         using CMake.
1002
1003         * Scripts/build-jsc:
1004
1005 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1006
1007         Delete WebMetal implementation in favor of WebGPU
1008         https://bugs.webkit.org/show_bug.cgi?id=195418
1009
1010         Reviewed by Dean Jackson.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (enableExperimentalFeatures):
1014         (resetWebPreferencesToConsistentValues):
1015         * Scripts/webkitperl/FeatureList.pm:
1016         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1018         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1019         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1020         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1021         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1022         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1023         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1024         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1025         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1026         (WTR::InjectedBundle::beginTesting):
1027         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1028         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1029         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1030
1031 2019-03-29  Chris Dumez  <cdumez@apple.com>
1032
1033         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1034         https://bugs.webkit.org/show_bug.cgi?id=196405
1035         <rdar://problem/49428130>
1036
1037         Reviewed by Wenson Hsieh.
1038
1039         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1040         the popover presentation methods to be no-ops. Use this in the new test added in
1041         r243523 so that we do not swizzle those methods for all tests. This is needed because
1042         those WatchOS tests rely on the popover getting presented and interactive.
1043
1044         * WebKitTestRunner/TestController.cpp:
1045         (WTR::updateTestOptionsFromTestHeader):
1046         * WebKitTestRunner/TestController.h:
1047         * WebKitTestRunner/TestOptions.h:
1048         (WTR::TestOptions::hasSameInitializationOptions const):
1049         * WebKitTestRunner/ios/TestControllerIOS.mm:
1050         (WTR::TestController::platformInitialize):
1051         (WTR::TestController::platformResetStateToConsistentValues):
1052
1053 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1054
1055         [Curl] Add Server Trust Evaluation Support.
1056         https://bugs.webkit.org/show_bug.cgi?id=191646
1057
1058         Reviewed by Fujii Hironori.
1059
1060         Implemented MiniBrowser UI for asking if user trusts the server.
1061
1062         * MiniBrowser/win/Common.cpp:
1063         (askServerTrustEvaluation):
1064         (replaceString):
1065         * MiniBrowser/win/Common.h:
1066         * MiniBrowser/win/MiniBrowserLib.rc:
1067         * MiniBrowser/win/MiniBrowserLibResource.h:
1068         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1069         (createPEMString):
1070         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1071         (WebKitBrowserWindow::canTrustServerCertificate):
1072         * MiniBrowser/win/WebKitBrowserWindow.h:
1073
1074 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1075
1076         Implement ResizeObserver.
1077         https://bugs.webkit.org/show_bug.cgi?id=157743
1078
1079         Reviewed by Simon Fraser.
1080
1081         Support resizeObserverEnabled webPreferences.
1082
1083         * DumpRenderTree/TestOptions.cpp:
1084         (TestOptions::TestOptions):
1085         * DumpRenderTree/TestOptions.h:
1086         * DumpRenderTree/mac/DumpRenderTree.mm:
1087         (setWebPreferencesForTestOptions):
1088         * DumpRenderTree/win/DumpRenderTree.cpp:
1089         (enableExperimentalFeatures):
1090         * Scripts/webkitperl/FeatureList.pm:
1091         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1092
1093 2019-03-28  John Wilander  <wilander@apple.com>
1094
1095         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1096         https://bugs.webkit.org/show_bug.cgi?id=196281
1097         <rdar://problem/48938748>
1098
1099         Reviewed by Alex Christensen.
1100
1101         This patch adds the function isStatisticsHasLocalStorage() to the
1102         TestRunner. With it, the page can query the WebsiteDataStore in the
1103         UI process to make sure that it sees LocalStorage.
1104
1105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1107         (WTR::TestRunner::isStatisticsHasLocalStorage):
1108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1109         * WebKitTestRunner/TestController.cpp:
1110         (WTR::TestController::isStatisticsHasLocalStorage):
1111         * WebKitTestRunner/TestController.h:
1112         * WebKitTestRunner/TestInvocation.cpp:
1113         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1114
1115 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1116
1117         API::Data::createWithoutCopying should do a null check before calling CFRelease
1118         https://bugs.webkit.org/show_bug.cgi?id=196276
1119         <rdar://problem/48059859>
1120
1121         Reviewed by Alex Christensen.
1122
1123         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1124
1125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1126         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1127         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1128         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1129         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1130         (TestWebKitAPI::TEST):
1131
1132 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1133
1134         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1135         https://bugs.webkit.org/show_bug.cgi?id=186276
1136
1137         Reviewed by Carlos Garcia Campos.
1138
1139         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1140         (webViewLoadChanged):
1141         (testWebResourceGetDataError):
1142         (testWebResourceGetDataEmpty):
1143         (beforeAll):
1144         (webViewloadChanged): Deleted.
1145
1146 2019-03-27  Andy Estes  <aestes@apple.com>
1147
1148         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1149         https://bugs.webkit.org/show_bug.cgi?id=196317
1150
1151         Reviewed by Dan Bernstein.
1152
1153         package-root copies built products into a staging directory using ditto(1), which does not
1154         follow symbolic links as it traverses a directory. Now that the files in
1155         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1156         itself, these become broken links when ditto'd into the staging directory.
1157
1158         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1159
1160         * Scripts/package-root:
1161
1162 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1163
1164         [ews-app] Update display text of Submit for ews analysis
1165         https://bugs.webkit.org/show_bug.cgi?id=196309
1166
1167         Reviewed by Dewei Zhu.
1168
1169         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1170
1171 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1172
1173         run-webkit-tests should check for leaks in WebKit processes
1174         <https://webkit.org/b/193772>
1175         <rdar://problem/46526680>
1176
1177         Reviewed by Ryosuke Niwa.
1178
1179         This works by doing the following:
1180         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1181           The list of child processes are returned one per line:
1182           process.name: pid
1183         - Run the "#LIST CHILD PROCESSES" command just before the
1184           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1185           processes on the ServerProcess object.
1186         - When the `--leaks` switch is handled, run check_for_leaks() on
1187           each child process after the main test harness.
1188
1189         * DumpRenderTree/mac/DumpRenderTree.mm:
1190         (handleControlCommand):
1191         - Use strncmp() instead of strcmp().
1192         - Add support for handling "#LIST CHILD PROCESSES" command.
1193
1194         * Scripts/webkitpy/port/base.py:
1195         (Port.check_for_leaks):
1196         * Scripts/webkitpy/port/darwin.py:
1197         (DarwinPort.check_for_leaks):
1198         - Rename redundant 'process_pid' argument to 'process_id'.
1199
1200         * Scripts/webkitpy/port/driver.py:
1201         (Driver.do_post_tests_work):
1202         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1203           longer the only command this sends to WebKitTestRunner.
1204         - If the `--leaks` switch is present, send the
1205           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1206           result using Port.set_webkit_processes().
1207         (Driver._parse_child_processes_output):
1208         - Add helper method to parse list of child process names and
1209           process IDs returned from WebKitTestRunner.
1210
1211         * Scripts/webkitpy/port/ios_device.py:
1212         (IOSDevicePort.check_for_leaks):
1213         - Rename redundant 'process_pid' argument to 'process_id'.
1214
1215         * Scripts/webkitpy/port/leakdetector.py:
1216         (LeakDetector._parse_leaks_output):
1217         - Return early if there is no leaks_output.
1218         (LeakDetector.check_for_leaks):
1219         - Rename redundant 'process_pid' argument to 'process_id'.
1220
1221         * Scripts/webkitpy/port/server_process.py:
1222         (ServerProcess.__init__):
1223         (ServerProcess.child_processes):
1224         (ServerProcess.set_child_processes):
1225         - Add instance variable to Port to store list of child process
1226           names and process IDs returned from WebKitTestRunner.
1227         (ServerProcess._start):
1228         - Clear self._child_processes.
1229         (ServerProcess.stop):
1230         - If self._child_processes is set, call
1231           self._port.check_for_leaks() for each child process.
1232
1233         * Scripts/webkitpy/port/server_process_unittest.py:
1234         (TrivialMockPort.check_for_leaks):
1235         - Rename redundant 'process_pid' argument to 'process_id'.
1236
1237         * Scripts/webkitpy/port/simulator_process.py:
1238         (SimulatorProcess.stop):
1239         - If self._child_processes is set, call
1240           self._port.check_for_leaks() for each child process.
1241
1242         * Scripts/webkitpy/port/watch_device.py:
1243         (WatchDevicePort.check_for_leaks):
1244         - Rename redundant 'process_pid' argument to 'process_id'.
1245
1246         * WebKitTestRunner/TestController.cpp:
1247         (WTR::TestController::dumpResponse):
1248         - Extract method from findAndDumpWorldLeaks() so that it may be
1249           reused by findAndDumpWebKitProcessIdentifiers().
1250         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1251         - Add method to output process name and process ID of both the
1252           WebContent and Networking processes.
1253         (WTR::TestController::findAndDumpWorldLeaks):
1254         - Fix missing newline in output when there were no abandoned
1255           documents.
1256         - Call dumpResponse() for extracted code.
1257         (WTR::TestController::handleControlCommand):
1258         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1259         - Use strncmp() instead of strcmp().
1260         - Call findAndDumpWebKitProcessIdentifiers() when
1261           "#LIST CHILD PROCESSES" command is sent.
1262         * WebKitTestRunner/TestController.h:
1263         (WTR::TestController::dumpResponse):
1264         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1265         - Declare methods.
1266
1267 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1268
1269         Unreviewed. Add GLib API test cases after r243434.
1270
1271         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1272         (testWebViewActiveURI):
1273         (serverCallback):
1274         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1275         (sendRequestCallback):
1276
1277 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1278
1279         Geolocation request not complete when watch request was started in a different web process
1280         https://bugs.webkit.org/show_bug.cgi?id=195996
1281
1282         Reviewed by Alex Christensen.
1283
1284         Add a test case.
1285
1286         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1287         (TestWebKitAPI::runJavaScriptAlert):
1288         (TestWebKitAPI::TEST):
1289
1290 2019-03-26  Keith Rollin  <krollin@apple.com>
1291
1292         Update the way generate-xcfilelists returns strings from functions
1293         https://bugs.webkit.org/show_bug.cgi?id=195975
1294         <rdar://problem/49040807>
1295
1296         Reviewed by Dean Jackson.
1297
1298         There are places where generate-xcfilelists executes assignments with
1299         statements like:
1300
1301             FOO=$(some_function)
1302
1303         where "some_function" return a string by echoing it. E.g.
1304
1305             some_function()
1306             {
1307                 echo "Hello, World"
1308             }
1309
1310         This is a common idiom, but it has a problem if "some_function" needs
1311         to call "exit" in an attempt to halt the entire script right then and
1312         there. Since "some_function" is called inside of $(), it's being
1313         executed in a sub-shell. Calling exit in that sub-shell simply exits
1314         that shell; it doesn't not exit the outer shell in which the main part
1315         of the script is still running. As such, the main script keeps
1316         executing when the intent was for the script to halt.
1317
1318         The solution to this is to use a different idiom for returning
1319         strings. The one we now is to pass in the name of the variable to
1320         receive the string result:
1321
1322             some_function()
1323             {
1324                 variable_name=$1
1325                 eval $variable_name ="Hello, World"
1326             }
1327
1328         The call site now looks like
1329
1330             some_function FOO
1331
1332         Because there's no invocation of a sub-shell, some_function can now
1333         call "exit" if it wants to, and the entire script will exit at that
1334         point.
1335
1336         * Scripts/generate-xcfilelists:
1337
1338 2019-03-26  Chris Dumez  <cdumez@apple.com>
1339
1340         Add basic layout test coverage for File Picker on iOS
1341         https://bugs.webkit.org/show_bug.cgi?id=196265
1342
1343         Reviewed by Wenson Hsieh.
1344
1345         Add layout test infrastructure to test the file picker on iOS.
1346
1347         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1348         (WTR::UIScriptController::dismissFilePicker):
1349         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1350         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1351         (WTR::UIScriptController::dismissFilePicker):
1352         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1353         * WebKitTestRunner/TestController.cpp:
1354         (WTR::TestController::createWebViewWithOptions):
1355         (WTR::updateTestOptionsFromTestHeader):
1356         * WebKitTestRunner/TestOptions.h:
1357         (WTR::TestOptions::hasSameInitializationOptions const):
1358         * WebKitTestRunner/ios/TestControllerIOS.mm:
1359         (overridePresentViewController):
1360         (WTR::TestController::platformInitialize):
1361         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1362         (WTR::UIScriptController::dismissFilePicker):
1363
1364 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1365
1366         Implement async paste method on UIWKInteractionViewProtocol
1367         https://bugs.webkit.org/show_bug.cgi?id=196267
1368         <rdar://problem/49236346>
1369
1370         Reviewed by Tim Horton.
1371
1372         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1373         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1374         are now a part of all iOS 12 internal SDKs.
1375
1376         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1377
1378         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1379         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1380
1381         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1382         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1383         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1384         * TestWebKitAPI/ios/UIKitSPI.h:
1385
1386 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1387
1388         [ews-build] Use PostgreSQL for ews.webkit.org database
1389         https://bugs.webkit.org/show_bug.cgi?id=196270
1390
1391         Reviewed by Lucas Forschler.
1392
1393         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1394
1395 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1396
1397         [ews] Reset simctl states on reboot
1398         https://bugs.webkit.org/show_bug.cgi?id=196260
1399
1400         Rubber-stamped by Aakash Jain.
1401
1402         * EWSTools/start-queue-mac.sh:
1403
1404 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1405
1406         [ews-build] Use PostgreSQL for ews-build database
1407         https://bugs.webkit.org/show_bug.cgi?id=196229
1408
1409         Reviewed by Lucas Forschler.
1410
1411         * BuildSlaveSupport/ews-build/master.cfg:
1412
1413 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1414
1415         [ews-build] Get master_hostname dynamically in master.cfg
1416         https://bugs.webkit.org/show_bug.cgi?id=196255
1417
1418         Reviewed by Lucas Forschler.
1419
1420         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1421         send events data in test mode.
1422
1423 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1424
1425         [ews-app] Set db_constraint to False for Foreign Keys
1426         https://bugs.webkit.org/show_bug.cgi?id=196252
1427
1428         Reviewed by Lucas Forschler.
1429
1430         * BuildSlaveSupport/ews-app/ews/models/build.py:
1431         * BuildSlaveSupport/ews-app/ews/models/step.py:
1432
1433 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews-build] is_test_mode_enabled should default to True
1436         https://bugs.webkit.org/show_bug.cgi?id=196248
1437
1438         Reviewed by Lucas Forschler.
1439
1440         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1441
1442 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1443
1444         [ews-app] Add webkitperl to ENABLED_QUEUES
1445         https://bugs.webkit.org/show_bug.cgi?id=196253
1446
1447         Reviewed by Lucas Forschler.
1448
1449         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1450
1451 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1452
1453         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1454         https://bugs.webkit.org/show_bug.cgi?id=196211
1455         rdar://problem/49110552
1456
1457         Reviewed by Tim Horton.
1458
1459         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1460         Make sure that EventSenderProxy always exists when running tests. We used to create
1461         it when resetting before the first test, which is a bit too late.
1462
1463         * WebKitTestRunner/TestController.h:
1464         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1465         (WTR::TestController::platformCreateWebView):
1466         (WTR::TestController::platformCreateOtherPage):
1467         (WTR::TestController::finishCreatingPlatformWebView):
1468         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1469         (WTR::PlatformWebView::PlatformWebView):
1470         Moved some code that made NSWindow use NSEvent during web view creation. We may
1471         need to move more if some other case us found, but this is enough for now.
1472
1473 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1474
1475         Unreviewed. Fix typo in GLib geolocation API after r243285.
1476
1477         gelocation -> geolocation.
1478
1479         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1480         (testGeolocationManagerWatchPosition):
1481
1482 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1483
1484         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1485         https://bugs.webkit.org/show_bug.cgi?id=196213
1486
1487         Reviewed by Geoff Garen.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1491         (credentialWithIdentityAndKeychainPath):
1492         (-[ChallengeDelegate webView:didFinishNavigation:]):
1493         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1494         (TestWebKitAPI::TEST):
1495
1496 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1497
1498         Expected shouldn't assume its contained types are copyable
1499         https://bugs.webkit.org/show_bug.cgi?id=195986
1500
1501         Reviewed by JF Bastien.
1502
1503         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1504         (TestWebKitAPI::NonCopyable::operator== const):
1505         (TestWebKitAPI::NonCopyable::operator!= const):
1506         (TestWebKitAPI::TEST):
1507
1508 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1509
1510         Remove some now-unnecessary dynamic class lookup
1511         https://bugs.webkit.org/show_bug.cgi?id=196237
1512
1513         Reviewed by Simon Fraser.
1514
1515         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1516         (makeRequest):
1517         (TEST):
1518
1519 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1520
1521         Unreviewed, rolling out r243450.
1522
1523         AppleWin and WinCairo port builds get broken.
1524
1525         Reverted changeset:
1526
1527         "Add test for fix of #196095"
1528         https://bugs.webkit.org/show_bug.cgi?id=196097
1529         https://trac.webkit.org/changeset/243450
1530
1531 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1532
1533         Unreviewed, rolling out r243465.
1534         https://bugs.webkit.org/show_bug.cgi?id=196226
1535
1536         the test doesn't build (Requested by thorton on #webkit).
1537
1538         Reverted changeset:
1539
1540         "Do not terminate the NetworkProcess if a third party
1541         application sends a NSCredential with a SecIdentityRef"
1542         https://bugs.webkit.org/show_bug.cgi?id=196213
1543         https://trac.webkit.org/changeset/243465
1544
1545 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1546
1547         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1548         https://bugs.webkit.org/show_bug.cgi?id=196213
1549
1550         Reviewed by Geoff Garen.
1551
1552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1553         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1554         (credentialWithIdentityAndKeychainPath):
1555         (-[ChallengeDelegate webView:didFinishNavigation:]):
1556         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1557         (TestWebKitAPI::TEST):
1558
1559 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1560
1561         [ews-build] Gracefully handle missing patch_id in events
1562         https://bugs.webkit.org/show_bug.cgi?id=196216
1563
1564         Reviewed by Lucas Forschler.
1565
1566         * BuildSlaveSupport/ews-build/events.py:
1567
1568 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1569
1570         [ews-build] use lz4 compression for improving buildbot performance
1571         https://bugs.webkit.org/show_bug.cgi?id=196155
1572
1573         Reviewed by Lucas Forschler.
1574
1575         * BuildSlaveSupport/ews-build/master.cfg:
1576
1577 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1578
1579         Pull some API testing helper methods out of TestWKWebView
1580         https://bugs.webkit.org/show_bug.cgi?id=196212
1581
1582         Reviewed by Tim Horton.
1583
1584         Refactor some more API testing utility methods, so that they can be used in
1585         tests that do not use TestWKWebView.
1586
1587         * TestWebKitAPI/cocoa/TestWKWebView.h:
1588         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1589         (-[WKWebView loadTestPageNamed:]):
1590         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1591         (-[WKWebView synchronouslyLoadHTMLString:]):
1592         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1593         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1594         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1595         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1596         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1597
1598 2019-03-25  Jer Noble  <jer.noble@apple.com>
1599
1600         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1601         https://bugs.webkit.org/show_bug.cgi?id=196097
1602
1603         Reviewed by Eric Carlson.
1604
1605         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1606
1607         * DumpRenderTree/mac/DumpRenderTree.mm:
1608         (resetWebPreferencesToConsistentValues):
1609         * WebKitTestRunner/TestController.cpp:
1610         (WTR::TestController::resetPreferencesToConsistentValues):
1611
1612 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1613
1614         Pull IPadUserInterfaceSwizzler out into a separate header file
1615         https://bugs.webkit.org/show_bug.cgi?id=196193
1616
1617         Reviewed by Anders Carlsson.
1618
1619         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1620         be used in other API tests.
1621
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1624         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1625         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1626         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1627         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1628         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1629
1630 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1631
1632         Remove NavigatorContentUtils in WebCore/Modules
1633         https://bugs.webkit.org/show_bug.cgi?id=196070
1634
1635         Reviewed by Alex Christensen.
1636
1637         NavigatorContentUtils was to support the custom scheme spec [1].
1638         However, in WebKit side, no port has supported the feature in
1639         WebKit layer after EFL port was removed. So there has been the
1640         only IDL implementation of the NavigatorContentUtils in WebCore.
1641         So we don't need to keep the implementation in WebCore anymore.
1642
1643         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1644
1645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1646
1647 2019-03-24  Andy Estes  <aestes@apple.com>
1648
1649         [watchOS] Remove unused Proximity Networking code
1650         https://bugs.webkit.org/show_bug.cgi?id=196188
1651
1652         Reviewed by Tim Horton.
1653
1654         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1655         (TEST):
1656
1657 2019-03-23  Keith Miller  <keith_miller@apple.com>
1658
1659         Refactor clz/ctz and fix getLSBSet.
1660         https://bugs.webkit.org/show_bug.cgi?id=196162
1661
1662         Reviewed by Saam Barati.
1663
1664         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1665
1666         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1667         (TestWebKitAPI::TEST):
1668
1669 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1670
1671         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1672         https://bugs.webkit.org/show_bug.cgi?id=196143
1673
1674         Reviewed by Michael Catanzaro.
1675
1676         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1677         directories.
1678
1679         * Scripts/webkitpy/style/checkers/cpp.py:
1680         (check_identifier_name_in_declaration):
1681         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1682         (WebKitStyleTest.test_names):
1683
1684 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1685
1686         [Flatpak] Manifest expanding fails for qt WPE extension
1687         https://bugs.webkit.org/show_bug.cgi?id=196148
1688
1689         Reviewed by Alex Christensen.
1690
1691         * flatpak/flatpakutils.py:
1692         (expand_submodules_recurse): The last recurse manifest expand
1693         iteration might lead to a single module so take it into account
1694         and don't try to recurse further.
1695
1696 2019-03-22  Chris Dumez  <cdumez@apple.com>
1697
1698         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1699         https://bugs.webkit.org/show_bug.cgi?id=195348
1700         <rdar://problem/48622090>
1701
1702         Reviewed by Alex Christensen.
1703
1704         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1705         to NO when test.options().shouldIgnoreMetaViewport is false.
1706
1707         * WebKitTestRunner/ios/TestControllerIOS.mm:
1708         (WTR::TestController::platformConfigureViewForTest):
1709
1710 2019-03-22  Chris Dumez  <cdumez@apple.com>
1711
1712         Prewarmed processes should be usable with any website data store
1713         https://bugs.webkit.org/show_bug.cgi?id=196104
1714
1715         Reviewed by Alex Christensen.
1716
1717         Add API test coverage.
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1720         (runInitialWarmedProcessUsedTest):
1721         (TEST):
1722
1723 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1724
1725         Back out local changes to Alex's Subversion working directory
1726
1727         They were accidentally committed.
1728
1729         * Scripts/webkitpy/common/system/abstractexecutive.py:
1730         (AbstractExecutive.wait_newest):
1731         * Scripts/webkitpy/common/system/executive.py:
1732         (Executive.running_pids):
1733         * Scripts/webkitpy/common/system/executive_mock.py:
1734         (MockExecutive.running_pids):
1735         * Scripts/webkitpy/common/system/executive_unittest.py:
1736         (ExecutiveTest.serial_test_running_pids):
1737         * Scripts/webkitpy/port/darwin.py:
1738         (DarwinPort.check_for_leaks):
1739         * Scripts/webkitpy/port/leakdetector.py:
1740         (LeakDetector.check_for_leaks):
1741         - This was the hack attached to Bug 193772.
1742
1743         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1744         (+[WebKitTestRunnerEvent mouseLocation]):
1745         - This works around a crash on an internal build.
1746
1747 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1748
1749         Fix the build after r243354
1750         https://bugs.webkit.org/show_bug.cgi?id=196138
1751         <rdar://problem/49145951>
1752
1753         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1754         (TEST):
1755         * TestWebKitAPI/ios/UIKitSPI.h:
1756
1757 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1758
1759         Adopt UIWKDocumentContext
1760         https://bugs.webkit.org/show_bug.cgi?id=196040
1761         <rdar://problem/48642440>
1762
1763         Reviewed by Ryosuke Niwa.
1764
1765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1766         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1767         (makeRequest):
1768         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1769         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1770         (applyStyle):
1771         (TEST):
1772         Add tests for UIWKDocumentContext.
1773
1774         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1775         (TEST):
1776         (recursiveFindWKContentView): Deleted.
1777         * TestWebKitAPI/cocoa/TestWKWebView.h:
1778         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1779         (recursiveFindWKContentView):
1780         (-[TestWKWebView wkContentView]):
1781         * TestWebKitAPI/ios/UIKitSPI.h:
1782         Share the WKContentView finding code between tests.
1783
1784 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1785
1786         [iOS WK2] Turn on async overflow scrolling by default
1787         https://bugs.webkit.org/show_bug.cgi?id=196011
1788         rdar://problem/48453859
1789
1790         Reviewed by Antti Koivisto.
1791         
1792         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1793         since so many basic layout tests have different results when compositing is triggered for
1794         overflow.
1795         
1796         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1797
1798         * WebKitTestRunner/TestController.cpp:
1799         (WTR::TestController::resetPreferencesToConsistentValues):
1800
1801 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1802
1803         [ews-build] Retry API test in case of failures
1804         https://bugs.webkit.org/show_bug.cgi?id=196004
1805
1806         Reviewed by Lucas Forschler.
1807
1808         * BuildSlaveSupport/ews-build/steps.py:
1809         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1810         (CompileWebKitToT.doStepIf): Ditto.
1811         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1812         (ReRunAPITests): Re-run API tests.
1813         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1814         (RunAPITestsWithoutPatch): Run API tests without patch.
1815         (RunAPITestsWithoutPatch.doStepIf):
1816         (RunAPITestsWithoutPatch.hideStepIf):
1817         (RunAPITestsWithoutPatch.evaluateCommand):
1818         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1819         (AnalyzeAPITestsResults.start):
1820         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1821         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1822         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1823         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1824
1825 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1826
1827         [ews-build] Update queues configurations
1828         https://bugs.webkit.org/show_bug.cgi?id=196074
1829
1830         Reviewed by Dewei Zhu.
1831
1832         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1833         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1834
1835 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1836
1837         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1838         https://bugs.webkit.org/show_bug.cgi?id=195680
1839         <rdar://problem/48903534>
1840
1841         Unreviewed infrastructure fix.
1842
1843         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1844         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1845
1846 2019-03-21  Andy Estes  <aestes@apple.com>
1847
1848         [iOS] Apple Pay should be available in documents with no user agent scripts
1849         https://bugs.webkit.org/show_bug.cgi?id=196061
1850         <rdar://problem/48649391>
1851
1852         Reviewed by Brady Eidson.
1853
1854         Added API tests and related infrastructure.
1855
1856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1857         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1858         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1859         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1860         (TestWebKitAPI::TEST):
1861         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1862         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1863         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1864         * TestWebKitAPI/cocoa/TestProtocol.mm:
1865         (-[TestProtocol startLoading]):
1866         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1867         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1868         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1869         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1870
1871 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1872
1873         REGRESSSION (r243297): webkitpy tests broken
1874         https://bugs.webkit.org/show_bug.cgi?id=196108
1875
1876         Reviewed by Aakash Jain.
1877
1878         r243297 updated contributors.json, which broke a few unit tests.
1879
1880         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1881         (IRCCommandTest.test_whois):
1882         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1883
1884 2019-03-21  Chris Dumez  <cdumez@apple.com>
1885
1886         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1887         https://bugs.webkit.org/show_bug.cgi?id=196041
1888         <rdar://problem/49083230>
1889
1890         Reviewed by Alex Christensen.
1891
1892         Add API test coverage.
1893
1894         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1895         (TEST):
1896
1897 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1898
1899         Add SPI to inform applications of WKContentRuleList actions
1900         https://bugs.webkit.org/show_bug.cgi?id=195965
1901         <rdar://problem/42664365>
1902
1903         Reviewed by Geoff Garen.
1904
1905         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1906         (TestWebKitAPI::allActionsForResourceLoad):
1907         (TestWebKitAPI::testRequest):
1908         (TestWebKitAPI::TEST_F):
1909         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1910         (Notification::description):
1911         (Notification::operator== const):
1912         (toVector):
1913         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1914         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1915         (makeContentRuleList):
1916         (TEST):
1917         (makeWarnContentRuleList): Deleted.
1918
1919 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1920
1921         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1922         https://bugs.webkit.org/show_bug.cgi?id=196088
1923
1924         Reviewed by Brian Burg.
1925
1926         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1927         Support checks when only one platform is specified. Also deprecate macosx() and
1928         force the use of macos() instead.
1929
1930         * Scripts/webkitpy/style/checkers/cpp.py:
1931         (check_min_versions_of_wk_api_available):
1932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1933         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1934
1935 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1936
1937         Update status inactive committers' status to 'contributor'.
1938
1939         * Scripts/webkitpy/common/config/contributors.json:
1940
1941 2019-03-21  Xan Lopez  <xan@igalia.com>
1942
1943         [JSC][x86] Drop support for x87 floating point
1944         https://bugs.webkit.org/show_bug.cgi?id=194853
1945
1946         Reviewed by Don Olmstead.
1947
1948         Force SSE2 on x86/32bit builds.
1949
1950         * Scripts/webkitdirs.pm:
1951         (generateBuildSystemFromCMakeProject):
1952
1953 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1954
1955         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1956         https://bugs.webkit.org/show_bug.cgi?id=196073
1957
1958         Reviewed by Michael Catanzaro.
1959
1960         Add test cases to check functions and constructors with no arguments but receiving user data.
1961
1962         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1963         (checkUserData):
1964         (testJSCFunction):
1965         (fooCreateWithUserData):
1966         (testJSCClass):
1967
1968 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1969
1970         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1971
1972         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1973
1974         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1975
1976 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1977
1978         [GTK][WPE] Add API to provide geolocation information
1979         https://bugs.webkit.org/show_bug.cgi?id=195940
1980
1981         Reviewed by Michael Catanzaro.
1982
1983         Add a new test to check the new API.
1984
1985         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1986         (testGeolocationManagerCurrentPosition):
1987         (testGeolocationManagerWatchPosition):
1988         (beforeAll):
1989         (afterAll):
1990         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1991         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1992         (beforeAll): Ditto.
1993         * TestWebKitAPI/glib/CMakeLists.txt:
1994
1995 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1996
1997         [GLib] Returning G_TYPE_OBJECT from a method does not work
1998         https://bugs.webkit.org/show_bug.cgi?id=195574
1999
2000         Reviewed by Michael Catanzaro.
2001
2002         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2003
2004         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2005         (getGFile):
2006         (getParent):
2007         (createGString):
2008         (getGString):
2009         (getGStringCopyWillRaise):
2010         (getGStringCopy):
2011         (getGStringStr):
2012         (getGStringLen):
2013         (freeGString):
2014         (testJSCClass):
2015
2016 2019-03-20  Saam Barati  <sbarati@apple.com>
2017
2018         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2019         https://bugs.webkit.org/show_bug.cgi?id=195721
2020
2021         Reviewed by Filip Pizlo.
2022
2023         * Scripts/run-javascriptcore-tests:
2024
2025 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2026
2027         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2028         https://bugs.webkit.org/show_bug.cgi?id=196049
2029
2030         Reviewed by Tim Horton.
2031
2032         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2033         overflow scrolling in general, so rename it.
2034
2035         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2036
2037 2019-03-20  Daniel Bates  <dabates@apple.com>
2038
2039         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2040         https://bugs.webkit.org/show_bug.cgi?id=196031
2041         <rdar://problem/49078172>
2042
2043         Reviewed by Tim Horton.
2044
2045         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2046         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2047         same code path used when the Done button is pressed to dismiss the <select> picker.
2048
2049         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2050         (TestWebKitAPI::TEST):
2051
2052 2019-03-20  Chris Dumez  <cdumez@apple.com>
2053
2054         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2055         https://bugs.webkit.org/show_bug.cgi?id=196029
2056         <rdar://problem/48954651>
2057
2058         Reviewed by Tim Horton.
2059
2060         Add API test coverage.
2061
2062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2063
2064 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2065
2066         [ews-build] Improve failure summary string for ApplyPatch step
2067         https://bugs.webkit.org/show_bug.cgi?id=195995
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         * BuildSlaveSupport/ews-build/steps.py:
2072         (ApplyPatch.getResultSummary): Override getResultSummary.
2073
2074 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2075
2076         AX: Implement support for new meter ARIA role
2077         https://bugs.webkit.org/show_bug.cgi?id=195966
2078
2079         Reviewed by Chris Fleizach.
2080
2081         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2082         to AXLevelIndicator.
2083
2084         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2085
2086 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2087
2088         [WebAuthN] Implement FIDO AppID extension
2089         https://bugs.webkit.org/show_bug.cgi?id=143491
2090         <rdar://problem/48298273>
2091
2092         Reviewed by Brent Fulgham.
2093
2094         Add a test that covers the new flag of convertToU2fSignCommand.
2095
2096         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2097         (TestWebKitAPI::TEST):
2098         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2099         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2100         (TestWebKitAPI::TEST):
2101
2102 2019-03-19  Keith Rollin  <krollin@apple.com>
2103
2104         Add support for more platforms to generate-xcfilelists
2105         https://bugs.webkit.org/show_bug.cgi?id=195977
2106
2107         Reviewed by Alexey Proskuryakov.
2108
2109         generate-xcfilelists incorrectly complains when involved with building
2110         WebKit for iphonesimulator:
2111
2112             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2113             …
2114             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2115
2116         Address this by teaching generate-xcfilelists about more platforms.
2117
2118         * Scripts/generate-xcfilelists:
2119
2120 2019-03-19  John Wilander  <wilander@apple.com>
2121
2122         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2123         https://bugs.webkit.org/show_bug.cgi?id=195923
2124         <rdar://problem/49001272>
2125
2126         Reviewed by Alex Christensen.
2127
2128         This patch does the following to the TestRunner:
2129         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2130         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2131         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2132
2133         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2135         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2137         * WebKitTestRunner/TestController.cpp:
2138         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2139         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2140         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2141         * WebKitTestRunner/TestController.h:
2142         * WebKitTestRunner/TestInvocation.cpp:
2143         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2144
2145 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2146
2147         [CMake] Support more clang and gcc sanitizers
2148         https://bugs.webkit.org/show_bug.cgi?id=195956
2149
2150         Reviewed by Michael Catanzaro.
2151
2152         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2153
2154 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-build] Improve summary for PrintConfiguration step
2157         https://bugs.webkit.org/show_bug.cgi?id=195945
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-build/steps.py:
2162         (PrintConfiguration.getResultSummary): Override getResultSummary.
2163
2164 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2165
2166         [ews-build] Improve summary for CheckOutSource step
2167         https://bugs.webkit.org/show_bug.cgi?id=195963
2168
2169         Reviewed by Lucas Forschler.
2170
2171         * BuildSlaveSupport/ews-build/steps.py:
2172         (CheckOutSource.getResultSummary):
2173
2174 2019-03-19  Daniel Bates  <dabates@apple.com>
2175
2176         [iOS] Focus not preserved when switching between tabs
2177         https://bugs.webkit.org/show_bug.cgi?id=195820
2178         <rdar://problem/43614450>
2179
2180         Reviewed by Brent Fulgham.
2181
2182         Add tests to ensure that we restore focus when resigning and becoming first responder.
2183
2184         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2185         (TestWebKitAPI::TEST):
2186
2187 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2188
2189         Make WTFLogChannelState and WTFLogLevel enum classes
2190         https://bugs.webkit.org/show_bug.cgi?id=195904
2191
2192         Reviewed by Eric Carlson.
2193
2194         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2195         (TestWebKitAPI::TEST_F):
2196
2197 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2198
2199         [GStreamer][EME] Backported mssdemux protection data crash fix
2200         https://bugs.webkit.org/show_bug.cgi?id=195918
2201
2202         Reviewed by Philippe Normand.
2203
2204         * gstreamer/jhbuild.modules:
2205         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2206
2207 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2208
2209         Unreviewed, rolling out r243132.
2210
2211         Broke GTK build
2212
2213         Reverted changeset:
2214
2215         "Make WTFLogChannelState and WTFLogLevel enum classes"
2216         https://bugs.webkit.org/show_bug.cgi?id=195904
2217         https://trac.webkit.org/changeset/243132
2218
2219 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2220
2221         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2222
2223         * Scripts/webkitdirs.pm:
2224         (builtDylibPathForName): Adjust the shared library name that's changed
2225         with the API version bump in r243073.
2226
2227 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2228
2229         Make WTFLogChannelState and WTFLogLevel enum classes
2230         https://bugs.webkit.org/show_bug.cgi?id=195904
2231
2232         Reviewed by Eric Carlson.
2233
2234         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2235         (TestWebKitAPI::TEST_F):
2236
2237 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2238
2239         Disable flaky test added in r2431100
2240         https://webkit.org/b/195785
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2243         (TestWebKitAPI::TEST):
2244         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2245
2246 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2247
2248         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2249         https://bugs.webkit.org/show_bug.cgi?id=195916
2250
2251         Reviewed by Tim Horton.
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2254         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2255
2256 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2257
2258         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2259
2260         * Scripts/webkitpy/common/config/contributors.json:
2261
2262 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2263
2264         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2265         https://bugs.webkit.org/show_bug.cgi?id=195785
2266
2267         Reviewed by Geoffrey Garen.
2268
2269         * TestWebKitAPI/TCPServer.cpp: Added.
2270         (TestWebKitAPI::TCPServer::TCPServer):
2271         (TestWebKitAPI::TCPServer::~TCPServer):
2272         (TestWebKitAPI::TCPServer::socketBindListen):
2273         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2274         * TestWebKitAPI/TCPServer.h: Added.
2275         (TestWebKitAPI::TCPServer::port const):
2276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2277         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2278         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2279         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2280         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2281         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2282         (TestWebKitAPI::respondSlowly):
2283         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2284         (TestWebKitAPI::downloadAtRate):
2285         (TestWebKitAPI::TEST):
2286
2287 2019-03-18  Saam Barati  <sbarati@apple.com>
2288
2289         Add a plan file for JetStream 2
2290         https://bugs.webkit.org/show_bug.cgi?id=190734
2291
2292         Reviewed by Mark Lam.
2293
2294         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2295
2296 2019-03-18  Chris Dumez  <cdumez@apple.com>
2297
2298         Delay WebProcess launch until a load is triggered in a Web view
2299         https://bugs.webkit.org/show_bug.cgi?id=195758
2300         <rdar://problem/48126013>
2301
2302         Reviewed by Geoff Garen.
2303
2304         Add API test coverage. Also update some existing API tests to not expect
2305         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2306
2307         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2308         (TestWebKitAPI::TEST):
2309         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2310         (TestWebKitAPI::TEST):
2311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2312         (TEST):
2313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2314         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2315         (TEST):
2316         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2317         (TEST):
2318         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2319
2320 2019-03-18  Xan Lopez  <xan@igalia.com>
2321
2322         [CMake] Prevent potential warning when determining $architecture
2323         https://bugs.webkit.org/show_bug.cgi?id=195891
2324
2325         Reviewed by Michael Catanzaro.
2326
2327         It's possible for generateBuildSystemForCMakeProject to be called
2328         before determineArchitecture() is ever called. This will make the
2329         first eq check with $architecture to be bogus (and print a
2330         warning). Change that to an eq check with architecture(), which
2331         implicitly calls determineArchitecture() if needed, and change all
2332         the other similar cases in the method in the same way to prevent
2333         future bugs like this one.
2334
2335         * Scripts/webkitdirs.pm:
2336         (generateBuildSystemFromCMakeProject):
2337
2338 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2339
2340         [WPE] Tarballs generated with “make dist” cannot build documentation
2341         https://bugs.webkit.org/show_bug.cgi?id=195885
2342
2343         Reviewed by Carlos Garcia Campos.
2344
2345         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2346
2347 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2348
2349         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2350         https://bugs.webkit.org/show_bug.cgi?id=195883
2351
2352         Reviewed by Carlos Garcia Campos.
2353
2354         * gtkdoc/gtkdoc.py:
2355         (GTKDoc._run_command): When commands fail to run, include the full command line for
2356         the program invocation and the output it has generated on the standard error stream.
2357
2358 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2359
2360         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2361         https://bugs.webkit.org/show_bug.cgi?id=195786
2362
2363         Reviewed by Philippe Normand.
2364
2365         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2366         * wpe/jhbuild.modules: Ditto.
2367
2368 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2369
2370         [ews-build] Don't run clean builds on EWS builders
2371         https://bugs.webkit.org/show_bug.cgi?id=195851
2372
2373         Reviewed by Geoffrey Garen.
2374
2375         * BuildSlaveSupport/ews-build/factories.py:
2376
2377 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2378
2379         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2380         https://bugs.webkit.org/show_bug.cgi?id=195849
2381
2382         Reviewed by Chris Dumez.
2383
2384         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2385
2386         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2387         (runWebsiteDataStoreCustomPaths):
2388
2389 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2390
2391         webkitpy: Upload test results
2392         https://bugs.webkit.org/show_bug.cgi?id=195755
2393         <rdar://problem/48896182>
2394
2395         Reviewed by Aakash Jain.
2396
2397         Establish a new format for uploading results that is not tied to layout tests, apply
2398         that format to webkitpy tests.
2399
2400         * Scripts/webkitpy/common/checkout/scm/git.py:
2401         (Git.native_branch): Return what branch the current checkout is on.
2402         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2403         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2404         * Scripts/webkitpy/common/checkout/scm/svn.py:
2405         (SVN.native_branch): Ditto.
2406         * Scripts/webkitpy/common/system/platforminfo.py:
2407         (PlatformInfo.build_version): Return a build version for Mac.
2408         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2409         (MockPlatformInfo.__init__):
2410         (MockPlatformInfo.build_version):
2411         * Scripts/webkitpy/results: Added.
2412         * Scripts/webkitpy/results/__init__.py: Added.
2413         * Scripts/webkitpy/results/options.py: Added.
2414         (upload_options): OptParse list for upload options.
2415         * Scripts/webkitpy/results/upload.py: Added.
2416         (Upload): Class which enforces the upload format expected by the results server.
2417         (Upload.Expectations):
2418         (Upload.create_configuration):
2419         (Upload.create_commit):
2420         (Upload.create_details):
2421         (Upload.create_run_stats):
2422         (Upload.create_test_result):
2423         (Upload.__init__):
2424         (Upload.Encoder): Encode Upload object as json.
2425         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2426         * Scripts/webkitpy/results/upload_unittest.py: Added.
2427         * Scripts/webkitpy/test/main.py:
2428         (Tester._parse_args): Add upload arguments.
2429         (Tester._run_tests): Allow results to be uploaded.
2430         * Scripts/webkitpy/test/runner.py:
2431         (Runner.__init__): Record which tests were run, rather than just counting them.
2432         (Runner.handle):
2433         * Scripts/webkitpy/test/runner_unittest.py:
2434         (RunnerTest.test_run):
2435         * Scripts/webkitpy/thirdparty/__init__.py:
2436         (AutoinstallImportHook.find_module): Add requests auto-install.
2437         (AutoinstallImportHook._install_requests):
2438         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2439         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2440
2441 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2442
2443         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2444         https://bugs.webkit.org/show_bug.cgi?id=195810
2445
2446         Reviewed by Tim Horton.
2447
2448         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2449         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2450         ending certain layout tests.
2451
2452         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2453         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2454         (-[TestRunnerWKWebView dealloc]):
2455         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2456
2457         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2458         helper method when destroying the web view, and when resetting state between tests.
2459
2460         * WebKitTestRunner/ios/TestControllerIOS.mm:
2461         (WTR::TestController::platformResetStateToConsistentValues):
2462
2463         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2464
2465 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2466
2467         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2468         https://bugs.webkit.org/show_bug.cgi?id=190350
2469         <rdar://problem/45089503>
2470
2471         Reviewed by Geoffrey Garen.
2472
2473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2474         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2475         (TEST):
2476         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2477         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2478         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2479         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2480         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2481         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2482         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2483         (runTest):
2484         (createDirectories):
2485         (TEST):
2486         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2487         (TEST):
2488         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2489         (TEST):
2490
2491 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2492
2493         Add support to WebPage for getting the contents as an attributed string.
2494         https://bugs.webkit.org/show_bug.cgi?id=195636
2495         rdar://problem/45055697
2496
2497         Reviewed by Tim Horton.
2498
2499         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2500         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2501
2502 2019-03-15  Chris Dumez  <cdumez@apple.com>
2503
2504         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2505         https://bugs.webkit.org/show_bug.cgi?id=195747
2506
2507         Reviewed by Geoff Garen.
2508
2509         Add API test coverage.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2512
2513 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2514
2515         Unreviewed, rolling out r242952.
2516
2517         Causing API failures on iOS Simulator
2518
2519         Reverted changeset:
2520
2521         "[PSON] Make sure the WebProcessCache is leverage when
2522         relaunching a process after termination"
2523         https://bugs.webkit.org/show_bug.cgi?id=195747
2524         https://trac.webkit.org/changeset/242952
2525
2526 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2527
2528         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2529         https://bugs.webkit.org/show_bug.cgi?id=195740
2530
2531         Reviewed by Ross Kirsling.
2532
2533         window.open doesn't work for WebKitBrowserWindow because it is not
2534         implemented yet.
2535
2536         1. Implemented createNewPage callback of WKPageUIClient.
2537         2. Changed MainWindow to take a BrowserWindow factory function
2538           instead of BrowserWindowType to be flexible to create
2539           BrowserWindow with extra settings.
2540         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2541           because it is not relevant with MainWindow anymore.
2542
2543         * MiniBrowser/win/Common.cpp:
2544         (parseCommandLine):
2545         * MiniBrowser/win/Common.h:
2546         (CommandLineOptions::CommandLineOptions):
2547         * MiniBrowser/win/MainWindow.cpp:
2548         (MainWindow::MainWindow):
2549         (MainWindow::create):
2550         (MainWindow::init):
2551         (MainWindow::WndProc):
2552         * MiniBrowser/win/MainWindow.h:
2553         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2554         (PrintWebUIDelegate::createWebViewWithRequest):
2555         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2556         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2557         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2558         (WebKitBrowserWindow::updateProxySettings):
2559         (WebKitBrowserWindow::createNewPage):
2560         * MiniBrowser/win/WebKitBrowserWindow.h:
2561         * MiniBrowser/win/WinMain.cpp:
2562         (wWinMain):
2563
2564 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2565
2566         Make it possible to test scrolling tree layer manipulation more easily
2567         https://bugs.webkit.org/show_bug.cgi?id=195780
2568
2569         Reviewed by Tim Horton.
2570         
2571         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2572         cuts off communication of scrolling tree scrolls back to the web process
2573         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2574         allows tests to trigger scrolls which run the scrolling tree layer positioning
2575         logic, but never get another commit from the web process that might mask
2576         scrolling tree bugs.
2577         
2578         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2579         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2580         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2581
2582         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2583         (WTR::UIScriptController::scrollUpdatesDisabled const):
2584         (WTR::UIScriptController::setScrollUpdatesDisabled):
2585         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2586         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2587         (WTR::UIScriptController::scrollUpdatesDisabled const):
2588         (WTR::UIScriptController::setScrollUpdatesDisabled):
2589         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2590         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2591         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2592         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2593         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2594         * WebKitTestRunner/ios/TestControllerIOS.mm:
2595         (WTR::TestController::platformResetStateToConsistentValues):
2596         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2597         (WTR::UIScriptController::scrollUpdatesDisabled const):
2598         (WTR::UIScriptController::setScrollUpdatesDisabled):
2599
2600 2019-03-14  Youenn Fablet  <youenn@apple.com>
2601
2602         Move IDB storage in private browsing mode to NetworkProcess
2603         https://bugs.webkit.org/show_bug.cgi?id=195602
2604
2605         Reviewed by Brady Eidson.
2606
2607         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2608         (TEST):
2609
2610 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2611
2612         [ews-build] Make descriptionDone messages more readable
2613         https://bugs.webkit.org/show_bug.cgi?id=195760
2614
2615         Reviewed by Lucas Forschler.
2616
2617         * BuildSlaveSupport/ews-build/steps.py:
2618         * BuildSlaveSupport/ews-build/steps_unittest.py:
2619
2620 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2621
2622         [ews-build] Generate status-bubble hover-over messages
2623         https://bugs.webkit.org/show_bug.cgi?id=195680
2624
2625         Reviewed by Lucas Forschler.
2626
2627         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2628         (StatusBubble):
2629         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2630         on hover-over.
2631         (StatusBubble._iso_time):
2632         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2633         hover-over message.
2634         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2635
2636 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2637
2638         [ews-app] Gracefully handle the case when state_string is None
2639         https://bugs.webkit.org/show_bug.cgi?id=195753
2640
2641         Reviewed by Lucas Forschler.
2642
2643         * BuildSlaveSupport/ews-app/ews/models/build.py:
2644         * BuildSlaveSupport/ews-app/ews/models/step.py:
2645
2646 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2647
2648         [ews-app] Status bubble display pending for currently running build step
2649         https://bugs.webkit.org/show_bug.cgi?id=195744
2650
2651         Reviewed by Lucas Forschler.
2652
2653         * BuildSlaveSupport/ews-build/events.py:
2654         (Events.stepStarted): If state_string is pending, replace it with step name.
2655
2656 2019-03-14  Chris Dumez  <cdumez@apple.com>
2657
2658         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2659         https://bugs.webkit.org/show_bug.cgi?id=195750
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         Add API test coverage.
2664
2665         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2666         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2667         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2668         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2669
2670 2019-03-14  Chris Dumez  <cdumez@apple.com>
2671
2672         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2673         https://bugs.webkit.org/show_bug.cgi?id=195747
2674
2675         Reviewed by Geoff Garen.
2676
2677         Add API test coverage.
2678
2679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2680
2681 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2682
2683         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2684         https://bugs.webkit.org/show_bug.cgi?id=195725
2685         <rdar://problem/48545062>
2686
2687         Reviewed by Tim Horton.
2688
2689         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2690         handler is nil.
2691
2692         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2693         (TestWebKitAPI::TEST):
2694
2695 2019-03-13  Sam Weinig  <sam@webkit.org>
2696
2697         Add utility function to allow easy reverse range-based iteration of a container
2698         https://bugs.webkit.org/show_bug.cgi?id=195542
2699
2700         Reviewed by Antti Koivisto.
2701
2702         * TestWebKitAPI/CMakeLists.txt:
2703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2704         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2705         (TestWebKitAPI::TEST):
2706         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2707
2708 2019-03-13  Chris Dumez  <cdumez@apple.com>
2709
2710         Use a ServiceWorker process per registrable domain
2711         https://bugs.webkit.org/show_bug.cgi?id=195649
2712
2713         Reviewed by Youenn Fablet.
2714
2715         Update API test coverage.
2716
2717         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2718
2719 2019-03-13  Chris Dumez  <cdumez@apple.com>
2720
2721         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2722         https://bugs.webkit.org/show_bug.cgi?id=195684
2723         <rdar://problem/48294714>
2724
2725         Reviewed by Antti Koivisto.
2726
2727         Add API test coverage.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2730
2731 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-app] Remove unused patch view
2734         https://bugs.webkit.org/show_bug.cgi?id=195669
2735
2736         Reviewed by Lucas Forschler.
2737
2738         * BuildSlaveSupport/ews-app/ews/urls.py:
2739         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2740
2741 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2742
2743         [ews-app] Use Buildbot result code variables
2744         https://bugs.webkit.org/show_bug.cgi?id=195668
2745
2746         Reviewed by Alexey Proskuryakov.
2747
2748         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2749         (Buildbot): Added Buildbot result code variables.
2750         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2751         (StatusBubble._build_bubble): Used Buildbot result code variables.
2752
2753 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2754
2755         [Flatpak] Expand submodule recursively
2756         https://bugs.webkit.org/show_bug.cgi?id=195672
2757
2758         Building WPE with flatpak was impossible without that as it was raising an exception.
2759         Also update wpebackend-fdo to match what is built in jhbuild
2760
2761         Reviewed by Philippe Normand.
2762
2763         * flatpak/flatpakutils.py:
2764         (expand_submodules_recurse):
2765         (expand_manifest):
2766         * flatpak/org.webkit.WPEModules.yaml:
2767
2768 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2769
2770         [ews-app] status bubble should be hidden for certain builds
2771         https://bugs.webkit.org/show_bug.cgi?id=194597
2772
2773         Reviewed by Dewei Zhu.
2774
2775         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2776         (StatusBubble._build_bubble):
2777         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2778         because the patch didn't have relevant changes.
2779         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2780         in production yet.
2781
2782 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2783
2784         [Win] Fix a slew of simple clang-cl warnings.
2785         https://bugs.webkit.org/show_bug.cgi?id=195652
2786
2787         Reviewed by Don Olmstead.
2788
2789         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2790         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2791
2792 2019-03-12  Justin Fan  <justin_fan@apple.com>
2793
2794         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2795         https://bugs.webkit.org/show_bug.cgi?id=195518
2796         <rdar://problem/46322356>
2797
2798         Reviewed by Myles C. Maxfield.
2799
2800         * DumpRenderTree/DerivedSources-input.xcfilelist:
2801         * DumpRenderTree/DerivedSources-output.xcfilelist:
2802
2803 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2804
2805         Unreviewed, rolling out r242825.
2806         https://bugs.webkit.org/show_bug.cgi?id=195648
2807
2808         "Broke webkitpy tests with my change to
2809         lldb_dump_class_layout.py" (Requested by rmorisset on
2810         #webkit).
2811
2812         Reverted changeset:
2813
2814         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2815         classes with suspicious padding"
2816         https://bugs.webkit.org/show_bug.cgi?id=195573
2817         https://trac.webkit.org/changeset/242825
2818
2819 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] Show status bubbles while the patch is waiting in queue
2822         https://bugs.webkit.org/show_bug.cgi?id=195618
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2827         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2828         enabled in initial deployment.
2829         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2830         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2831         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2832         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2833         (StatusBubble._build_bubbles_for_patch):
2834
2835 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2836
2837         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2838         https://bugs.webkit.org/show_bug.cgi?id=195573
2839
2840         Reviewed by Simon Fraser.
2841
2842         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2843
2844         * Scripts/dump-class-layout:
2845         (main):
2846         * lldb/lldb_dump_class_layout.py:
2847         (ClassLayout.__init__):
2848         (ClassLayout._compute_padding_recursive):
2849         (LLDBDebuggerInstance.dump_layout_for_classname):
2850         (LLDBDebuggerInstance):
2851         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2852         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2853
2854 2019-03-12  Chris Dumez  <cdumez@apple.com>
2855
2856         Device Orientation access permission should be denied unless explicitly granted by the client
2857         https://bugs.webkit.org/show_bug.cgi?id=195625
2858
2859         Reviewed by Youenn Fablet.
2860
2861         add API test coverage.
2862
2863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2864         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2865         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2866         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2867         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2868         (runDeviceOrientationTest):
2869         (TEST):
2870         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2871         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2872
2873 2019-03-12  Jer Noble  <jer.noble@apple.com>
2874
2875         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2876         https://bugs.webkit.org/show_bug.cgi?id=195137
2877         <rdar://problem/48810307>
2878
2879         Reviewed by Eric Carlson.
2880
2881         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2882         (TestWebKitAPI::TEST):
2883
2884 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2885
2886         [ews-build] Change urls from uat to production
2887         https://bugs.webkit.org/show_bug.cgi?id=195566
2888
2889         Reviewed by Lucas Forschler.
2890
2891         * BuildSlaveSupport/ews-app/ews/config.py:
2892         * BuildSlaveSupport/ews-build/events.py:
2893         * BuildSlaveSupport/ews-build/steps.py:
2894
2895 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2896
2897         [ews-build] change max_builds for local-worker to 1
2898         https://bugs.webkit.org/show_bug.cgi?id=195568
2899
2900         Reviewed by Lucas Forschler.
2901
2902         * BuildSlaveSupport/ews-build/loadConfig.py:
2903
2904 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2905
2906         Fix the build
2907
2908         * TestRunnerShared/spi/PencilKitTestSPI.h:
2909         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2910
2911 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2912
2913         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2914         https://bugs.webkit.org/show_bug.cgi?id=194131
2915
2916         Reviewed by Michael Catanzaro.
2917
2918         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2919         (uriChanged):
2920         (testUnfinishedSubresourceLoad):
2921         (serverCallback):
2922         (beforeAll):
2923
2924 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2925
2926         WTF::Expected should use std::addressof instead of operator&
2927         https://bugs.webkit.org/show_bug.cgi?id=195604
2928
2929         Reviewed by Myles Maxfield.
2930
2931         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2932         (TestWebKitAPI::Unique::Unique):
2933         (TestWebKitAPI::Unique::operator&):
2934         (TestWebKitAPI::TEST):
2935
2936 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2937
2938         Add Optional to Forward.h.
2939         https://bugs.webkit.org/show_bug.cgi?id=195586
2940
2941         Reviewed by Darin Adler.
2942
2943         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2944         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2945         Remove unnecessary includes from headers.
2946
2947 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2948
2949         Add testing API to hit-test and scroll overflow scrollers
2950         https://bugs.webkit.org/show_bug.cgi?id=195278
2951
2952         Reviewed by Antti Koivisto.
2953         
2954         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2955         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2956         
2957         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2958
2959         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2960         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2961         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2962         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2963         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2964         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2965         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2966         (WTR::enclosingScrollViewIncludingSelf):
2967         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2968
2969 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2970
2971         API test WebKit.RequestTextInputContext fails on iOS
2972         https://bugs.webkit.org/show_bug.cgi?id=195585
2973
2974         Reviewed by Wenson Hsieh and Simon Fraser.
2975
2976         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2977         (applyStyle):
2978         (TEST):
2979         Add a viewport, so that the coordinates match up on iOS.
2980         Scroll by moving the UIScrollView's contentOffset.
2981
2982 2019-03-11  Chris Dumez  <cdumez@apple.com>
2983
2984         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2985         https://bugs.webkit.org/show_bug.cgi?id=195506
2986         <rdar://problem/48733477>
2987
2988         Reviewed by Alex Christensen.
2989
2990         Add API test coverage.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2993
2994 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2995
2996         Adding myself to contributors.json
2997
2998         Unreviewed, addming myself to contributors.json .
2999
3000         * Scripts/webkitpy/common/config/contributors.json:
3001
3002 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3003
3004         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3005         https://bugs.webkit.org/show_bug.cgi?id=195511
3006         <rdar://problem/44873269>
3007
3008         Reviewed by Darin Adler.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3011         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3012         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3013         (TEST_F):
3014
3015 2019-03-11  Chris Dumez  <cdumez@apple.com>
3016
3017         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3018         https://bugs.webkit.org/show_bug.cgi?id=195561
3019
3020         Reviewed by Youenn Fablet.
3021
3022         Make sure the JS in the test requests for permission to receive device orientation events.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3025
3026 2019-03-11  Youenn Fablet  <youenn@apple.com>
3027
3028         Allow storage quota increase by default in WTR
3029         https://bugs.webkit.org/show_bug.cgi?id=195541
3030
3031         Reviewed by Geoffrey Garen.
3032
3033         Allow storage quota increase by default in WTR.
3034         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3035         Use this for tests that explicitly need cache increase.
3036
3037         Instead of increasing quota by 2, make sure the next request is
3038         granted by adding all given parameters.
3039
3040         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3041         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3042         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3043         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3045         * WebKitTestRunner/TestController.cpp:
3046         (WTR::TestController::setAllowStorageQuotaIncrease):
3047         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3048         * WebKitTestRunner/TestController.h:
3049         * WebKitTestRunner/TestInvocation.cpp:
3050         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3051         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3052         (WTR::TestController::cocoaResetStateToConsistentValues):
3053         (WTR::TestController::setAllowStorageQuotaIncrease):
3054         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3055         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3056         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3057
3058 2019-03-11  Xan Lopez  <xan@igalia.com>
3059
3060         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3061         https://bugs.webkit.org/show_bug.cgi?id=194147
3062
3063         Reviewed by Michael Saboff.
3064
3065         To make --32-bit work correctly on Linux/64bit we need to:
3066
3067         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3068         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3069         unfortunately CMake only allows us to do this during
3070         crosscompilation, which is overkill here.
3071         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3072         pkg-config detection module uses the x86 .pc files instead of the
3073         x86_64 ones.
3074         - Set the -m32 flags for the compiler.
3075
3076         * Scripts/webkitdirs.pm:
3077         (generateBuildSystemFromCMakeProject):
3078
3079 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3080
3081         Add MotionMark-1.1 plan file for run-benchmark script.
3082         https://bugs.webkit.org/show_bug.cgi?id=195481
3083
3084         Rubber-stamped by Darin Adler.
3085
3086         Run-benchmark script should support MontionMark-1.1.
3087
3088         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3089
3090 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3091
3092         [ews-app] Add support for submit-to-ews url
3093         https://bugs.webkit.org/show_bug.cgi?id=195477
3094
3095         Reviewed by Lucas Forschler.
3096
3097         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3098         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3099         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3100         * BuildSlaveSupport/ews-app/ews/urls.py:
3101         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3102
3103 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3104
3105         Unreviewed, rolling out r242688, r242643, r242624.
3106
3107         Caused multiple layout test failures and crashes on iOS and macOS.
3108
3109         Reverted changeset:
3110
3111         "requestAnimationFrame should execute before the next frame"
3112         https://bugs.webkit.org/show_bug.cgi?id=177484
3113         https://trac.webkit.org/changeset/242624/webkit
3114
3115         * Tracing/SystemTracePoints.plist:
3116
3117 2019-03-11  John Wilander  <wilander@apple.com>
3118
3119         Resource Load Statistics: Make it possible exclude localhost from classification
3120         https://bugs.webkit.org/show_bug.cgi?id=195474
3121         <rdar://problem/47520577>
3122
3123         Reviewed by Brent Fulgham.
3124
3125         This patch allows for localhost to be excluded from classification and
3126         treatment as a prevalent resource.
3127
3128         The WebKit Tools change adds a new function called
3129         testRunner.setStatisticsIsRunningTest() which can be used to control this
3130         behavior.
3131
3132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3134         (WTR::TestRunner::setStatisticsIsRunningTest):
3135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3136         * WebKitTestRunner/TestController.cpp:
3137         (WTR::TestController::setStatisticsIsRunningTest):
3138         * WebKitTestRunner/TestController.h:
3139         * WebKitTestRunner/TestInvocation.cpp:
3140         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3141
3142 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3143
3144         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3145         https://bugs.webkit.org/show_bug.cgi?id=195560
3146
3147         Reviewed by Lucas Forschler.
3148
3149         * BuildSlaveSupport/ews-build/master.cfg:
3150
3151 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3152
3153         Unreviewed, rolling out r242698.
3154
3155         API test crashes on bots.
3156
3157         Reverted changeset:
3158
3159         "Add a WKContentRuleList variant that uses copied memory
3160         instead of mmap'd shared memory for class A containerized
3161         apps"
3162         https://bugs.webkit.org/show_bug.cgi?id=195511
3163         https://trac.webkit.org/changeset/242698
3164
3165 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3166
3167         [WPE] Enable web process sandbox
3168         https://bugs.webkit.org/show_bug.cgi?id=195169
3169
3170         Reviewed by Daniel Bates.
3171
3172         * wpe/install-dependencies:
3173         * wpe/jhbuild.modules:
3174
3175 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-app] Use port 17000 for worker communication
3178         https://bugs.webkit.org/show_bug.cgi?id=195558
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-build/master.cfg:
3183
3184 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3185
3186         [ews-build] unit-tests fail when passwords.json is missing
3187         https://bugs.webkit.org/show_bug.cgi?id=195557
3188
3189         Reviewed by Lucas Forschler.
3190
3191         * BuildSlaveSupport/ews-build/loadConfig.py:
3192         (loadBuilderConfig):
3193         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3194         (ConfigDotJSONTest.test_configuration):
3195         * BuildSlaveSupport/ews-build/master.cfg:
3196
3197 2019-03-11  Truitt Savell  <tsavell@apple.com>
3198
3199         Unreviewed, rolling out r242702.
3200
3201         Broke High Sierra builders.
3202
3203         Reverted changeset:
3204
3205         "Add utility function to allow easy reverse range-based
3206         iteration of a container"
3207         https://bugs.webkit.org/show_bug.cgi?id=195542
3208         https://trac.webkit.org/changeset/242702
3209
3210 2019-03-11  Sam Weinig  <sam@webkit.org>
3211
3212         Add utility function to allow easy reverse range-based iteration of a container
3213         https://bugs.webkit.org/show_bug.cgi?id=195542
3214
3215         Reviewed by Antti Koivisto.
3216
3217         * TestWebKitAPI/CMakeLists.txt:
3218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3219         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3220         (TestWebKitAPI::TEST):
3221         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3222
3223 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3224
3225         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3226         https://bugs.webkit.org/show_bug.cgi?id=195511
3227         <rdar://problem/44873269>
3228
3229         Reviewed by Darin Adler.
3230
3231         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3232         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3233         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3234         (TEST_F):
3235
3236 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3237
3238         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3239         https://bugs.webkit.org/show_bug.cgi?id=195499
3240
3241         Reviewed by Darin Adler.
3242
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3245         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3246         (-[WKWebView synchronouslyFocusTextInputContext:]):
3247         (applyStyle):
3248         (applyIframe):
3249         (TEST):
3250         Add some tests for this SPI.
3251
3252 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3253
3254         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3255         https://bugs.webkit.org/show_bug.cgi?id=181151
3256
3257         Reviewed by Don Olmstead.
3258
3259         * TestWebKitAPI/CMakeLists.txt:
3260         * TestWebKitAPI/PlatformWin.cmake:
3261         Enable TestWTF RunLoop tests in all platforms.
3262
3263         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3264         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3265         (TestWebKitAPI::DerivedOneShotTimer::fired):
3266         (TestWebKitAPI::TEST):
3267         Only a few platforms support nested RunLoop.
3268
3269         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3270         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3271
3272 2019-03-10  David Quesada  <david_quesada@apple.com>
3273
3274         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3275         https://bugs.webkit.org/show_bug.cgi?id=152480
3276
3277         Reviewed by Chris Dumez.
3278
3279         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3280         there are no additional references to the process pool besides the one held by
3281         the download, waits for the download to finish (in the sense that the
3282         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3283         measure, also check that the process pool has been deallocated at the end of the
3284         test. The test wouldn't be meaningful if the process pool were still alive.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3287         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3288         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3289             The download will be canceled because the delegate does not implement the
3290             method to decide the download's destination, so this is where we know the
3291             DownloadProxyMap is done with the DownloadProxy.
3292         (TEST):
3293
3294 2019-03-08  Chris Dumez  <cdumez@apple.com>
3295
3296         Add support for Device Orientation / Motion permission API
3297         https://bugs.webkit.org/show_bug.cgi?id=195329
3298         <rdar://problem/47645367>
3299
3300         Reviewed by Geoffrey Garen.
3301
3302         Add test infrastructure to help test the Device Orientation / Motion permission API.
3303
3304         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3305         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3306         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3307         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3308         * WebKitTestRunner/TestController.cpp:
3309         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3310         (WTR::TestController::createWebViewWithOptions):
3311         (WTR::TestController::resetStateToConsistentValues):
3312         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3313         * WebKitTestRunner/TestController.h:
3314         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3315         * WebKitTestRunner/TestInvocation.cpp:
3316         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3317
3318 2019-03-08  Saam barati  <sbarati@apple.com>
3319
3320         Add a compare-results script to compare benchmark results
3321         https://bugs.webkit.org/show_bug.cgi?id=195486
3322         <rdar://problem/48723397>
3323
3324         Reviewed by Geoffrey Garen.
3325
3326         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3327         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3328         to extend it to learn about our other benchmarks.
3329
3330         * Scripts/compare-results: Added.
3331         (readJSONFile):
3332         (detectJetStream2):
3333         (JetStream2Results):
3334         (detectSpeedometer2):
3335         (Speedometer2Results):
3336         (detectPLT5):
3337         (PLT5Results):
3338         (detectBenchmark):
3339         (biggerIsBetter):
3340         (ttest):
3341         (getOptions):
3342         (main):
3343
3344 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3345
3346         Ensure old tab state is cleared between iterations of run-benchmark
3347         https://bugs.webkit.org/show_bug.cgi?id=195393
3348         <rdar://problem/46885583>
3349
3350         Reviewed by Dewei Zhu.
3351
3352         a) ensure the default to restore state is not set
3353         b) terminate Safari correctly
3354         c) Set the system default to ignore Persistent State in Safari
3355
3356         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3357         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3358         (OSXBrowserDriver.prepare_env): 
3359         (OSXBrowserDriver.restore_env):
3360         (OSXBrowserDriver.close_browsers):
3361         (OSXBrowserDriver._terminate_processes):
3362         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3363         (OSXChromeDriver):
3364         (OSXChromeCanaryDriver):
3365         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3366         (OSXFirefoxDriver):
3367         (OSXFirefoxNightlyDriver):
3368         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3369         (OSXSafariDriver):
3370         (OSXSafariDriver.prepare_env):
3371
3372 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3373
3374         [GTK] Several InputMethodFilter tests are failing
3375         https://bugs.webkit.org/show_bug.cgi?id=195408
3376
3377         Reviewed by Carlos Garcia Campos.
3378
3379         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3380         Regressed in r241751.
3381         Hexadecimal values of keycodes are expressed now in upper letters.
3382         Composited characters should be cast to UTF8 strings.
3383
3384         (TestWebKitAPI::TEST):
3385
3386 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3387
3388         [GTK] Make Tools/gtkdoc python3 compatible
3389         https://bugs.webkit.org/show_bug.cgi?id=195359
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         * gtkdoc/generate-gtkdoc:
3394         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3395         work with Python 2 and 3.
3396         (get_gtkdoc_module_paths):
3397         The iteritems() was removed in Python 3, so let's use items() that's
3398         available in Python 2 and 3.
3399         (get_generator_for_config):
3400         * gtkdoc/gtkdoc.py:
3401         (GTKDoc._run_command):
3402         The sys.stdout.write() is expecting str in Python 3 and not bytes
3403         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3404         for passing the bytes there.
3405
3406 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3407
3408         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3409         https://bugs.webkit.org/show_bug.cgi?id=195346
3410         <rdar://problem/48667048>
3411
3412         Unreviewed build fix for clang-cl.
3413
3414         * DumpRenderTree/win/DumpRenderTree.cpp:
3415         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3416
3417 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3418
3419         requestAnimationFrame should execute before the next frame
3420         https://bugs.webkit.org/show_bug.cgi?id=177484
3421
3422         Reviewed by Simon Fraser.
3423
3424         Add trace points for the page RenderingUpdate.
3425
3426         * Tracing/SystemTracePoints.plist:
3427
3428 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3429
3430         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3431         https://bugs.webkit.org/show_bug.cgi?id=195353
3432         <rdar://problem/48626394>
3433
3434         Reviewed by Simon Fraser.
3435
3436         * WebKitTestRunner/ios/TestControllerIOS.mm:
3437         (WTR::TestController::platformResetPreferencesToConsistentValues):
3438
3439 2019-03-07  John Wilander  <wilander@apple.com>
3440
3441         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3442         https://bugs.webkit.org/show_bug.cgi?id=195383
3443         <rdar://problem/48570136>
3444
3445         Reviewed by Brent Fulgham.
3446
3447         This patch adds test infrastructure to purge only script-accessible cookies,
3448         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3449
3450         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3451         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3452         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3453         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::statisticsDeleteCookiesForHost):
3456         * WebKitTestRunner/TestController.h:
3457         * WebKitTestRunner/TestInvocation.cpp:
3458         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3459
3460 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3461
3462         Unreviewed, rolling out r242354.
3463         https://bugs.webkit.org/show_bug.cgi?id=195402
3464
3465         breaks layout tests in all configurations (Requested by
3466         zdobersek on #webkit).
3467
3468         Reverted changeset:
3469
3470         "[WPE] Enable web process sandbox"
3471         https://bugs.webkit.org/show_bug.cgi?id=195169
3472         https://trac.webkit.org/changeset/242354
3473
3474 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3475
3476         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3477         https://bugs.webkit.org/show_bug.cgi?id=195346
3478
3479         Reviewed by Fujii Hironori.
3480
3481         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3482         (TestWebKitAPI::TEST):
3483         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3484
3485         * DumpRenderTree/win/DumpRenderTree.cpp:
3486         (findFontFallback):
3487         (addFontFallbackIfPresent):
3488         (removeFontFallbackIfPresent):
3489         (main):
3490         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3491         (TestWebKitAPI::Util::moduleDirectory):
3492         (TestWebKitAPI::Util::createInjectedBundlePath):
3493         Use wchar helpers as needed.
3494
3495 2019-03-06  Rob Buis  <rbuis@igalia.com>
3496
3497         Consider supporting the `referrerpolicy` attribute.
3498         https://bugs.webkit.org/show_bug.cgi?id=179053
3499
3500         Reviewed by Darin Adler.
3501
3502         Add a runtime flag for referrerpolicy attribute.
3503
3504         * DumpRenderTree/mac/DumpRenderTree.mm:
3505         (enableExperimentalFeatures):
3506
3507 2019-03-05  Daniel Bates  <dabates@apple.com>
3508
3509         Update expected API test result following r242379
3510         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3511
3512         Update expected x-coordinate of selection rect now that the left padding of
3513         a textarea is sized in ems (so dependent on the font size) just like the left
3514         padding of a text field.
3515
3516         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3517         (TestWebKitAPI::TEST):
3518
3519 2019-03-05  David Quesada  <david_quesada@apple.com>
3520
3521         [WK2] It should be possible to follow links with 'download' attributes
3522         https://bugs.webkit.org/show_bug.cgi?id=195145
3523         rdar://problem/48462642
3524
3525         Reviewed by Alex Christensen.
3526
3527         Add a unit test to verify that activating links with 'download' attributes now
3528         navigates to the linked resource, rather than starts downloading it. Add another
3529         to verify that it is still possible to explicitly download the link via the
3530         'Download' navigation action policy.
3531
3532         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3533         (-[DownloadAttributeTestDelegate init]):
3534         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3535         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3536         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3537         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3538         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3539         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3540         (TEST):
3541         * WebKitTestRunner/TestController.cpp:
3542         (WTR::TestController::decidePolicyForNavigationAction):
3543         * WebKitTestRunner/TestController.h:
3544
3545 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3546
3547         [Curl] Implement Cookie Accept Policy.
3548         https://bugs.webkit.org/show_bug.cgi?id=191645
3549
3550         Reviewed by Fujii Hironori.
3551
3552         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3553         (TestWebKitAPI::Curl::TEST_F):
3554
3555 2019-03-05  Youenn Fablet  <youenn@apple.com>
3556
3557         Rename requestCacheStorageSpace to requestStorageSpace
3558         https://bugs.webkit.org/show_bug.cgi?id=195282
3559
3560         Reviewed by Chris Dumez.
3561
3562         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3563         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3564         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3565
3566 2019-03-05  Brady Eidson  <beidson@apple.com>
3567
3568         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3569         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3570
3571         Reviewed by Tim Horton.
3572
3573         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3574         different directory into that same WKWebView should work.
3575
3576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3577         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3578
3579 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3580
3581         Add WeakHashSet
3582         https://bugs.webkit.org/show_bug.cgi?id=195152
3583
3584         Reviewed by Antti Koivisto.
3585
3586         Added tests for WeakHashSet.
3587
3588         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3589         (TestWebKitAPI::Base::Base): Moved.
3590         (TestWebKitAPI::Derived::foo): Moved.
3591         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3592         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3593         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3594         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3595
3596 2019-03-04  Chris Dumez  <cdumez@apple.com>
3597
3598         Do not share WebProcesses between private and regular sessions
3599         https://bugs.webkit.org/show_bug.cgi?id=195189
3600         <rdar://problem/48421064>
3601
3602         Reviewed by Alex Christensen.
3603
3604         Add API test coverage.
3605
3606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3607         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3608
3609 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3610
3611         [WPE] Enable web process sandbox
3612         https://bugs.webkit.org/show_bug.cgi?id=195169
3613
3614         Reviewed by Daniel Bates.
3615
3616         * wpe/install-dependencies:
3617         * wpe/jhbuild.modules:
3618
3619 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3620
3621         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3622         https://bugs.webkit.org/show_bug.cgi?id=195206
3623
3624         Reviewed by Žan Doberšek.
3625
3626         Add a new test case.
3627
3628         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3629         (testJSCClass):
3630
3631 2019-03-04  Charlie Turner  <cturner@igalia.com>
3632
3633         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3634         https://bugs.webkit.org/show_bug.cgi?id=194898
3635
3636         Reviewed by Žan Doberšek.
3637
3638         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3639         a GCC extension that permits arithmetic on void* pointer. Inline
3640         the macro until this issue is fixed upstream.
3641
3642 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3643
3644         Rid the world of WK_API_ENABLED
3645         https://bugs.webkit.org/show_bug.cgi?id=195263
3646
3647         Reviewed by Dan Bernstein.
3648
3649         List of changed files elided because it's useless.
3650
3651 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3652
3653         Unreviewed follow-up to r242292.
3654
3655         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3656
3657         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3658         (TestWebKitAPI::testStrip): Renamed from strip.
3659         (TestWebKitAPI::TEST):
3660
3661 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3662
3663         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3664
3665         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3666         and bug #194272 for details.
3667
3668         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3669
3670 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3671
3672         Remove some more unused 32-bit code
3673         https://bugs.webkit.org/show_bug.cgi?id=195255
3674
3675         Reviewed by Darin Adler.
3676
3677         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3678         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3679         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3680         (NPP_New):
3681         (NPP_HandleEvent):
3682         (handleEventCarbon): Deleted.
3683
3684 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3685
3686         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3687
3688         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3689         (TestWebKitAPI::TEST):
3690
3691 2019-03-01  Darin Adler  <darin@apple.com>
3692
3693         Finish removing String::format
3694         https://bugs.webkit.org/show_bug.cgi?id=194893
3695
3696         Reviewed by Daniel Bates.
3697 '
3698         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3699
3700 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3701
3702         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3703         https://bugs.webkit.org/show_bug.cgi?id=195229
3704         <rdar://problem/48520362>
3705
3706         Reviewed by Chris Dumez.
3707
3708         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3709         (TEST):
3710
3711 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3712
3713         Add a system trace scope for event region building
3714         https://bugs.webkit.org/show_bug.cgi?id=195226
3715
3716         Reviewed by Jon Lee.
3717
3718         This trace scope measures the time spend converting element rects into Region objects,
3719         which can be large on some pages.
3720
3721         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3722
3723         * Tracing/SystemTracePoints.plist:
3724
3725 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3726
3727         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3728         https://bugs.webkit.org/show_bug.cgi?id=194612
3729
3730         Reviewed by Alex Christensen.
3731
3732         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3733         Just test the new string-processing function and don't touch the actual environment.
3734         (Test cases are all as before, but based on operator== instead of strcmp.)
3735
3736 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3737
3738         [ews-app] Update primary keys for handling multiple Buildbot instances
3739         https://bugs.webkit.org/show_bug.cgi?id=195120
3740
3741         Reviewed by Stephanie Lewis.
3742
3743         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3744         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3745         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3746
3747         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3748         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3749         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3750         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3751         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3752         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3753
3754 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3755
3756         [WinCairo] Enable service worker
3757         https://bugs.webkit.org/show_bug.cgi?id=188318
3758
3759         Reviewed by Youenn Fablet.
3760
3761         * DumpRenderTree/DumpRenderTreePrefix.h:
3762         * TestWebKitAPI/PlatformWin.cmake:
3763         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3764         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3765         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3766
3767 2019-03-01  Justin Fan  <justin_fan@apple.com>
3768
3769         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3770         https://bugs.webkit.org/show_bug.cgi?id=195191
3771
3772         Rubber-stamped by Dean Jackson.
3773
3774         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3775
3776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3777
3778 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3779
3780         Unreviewed, fix lldb webkitpy tests
3781         https://bugs.webkit.org/show_bug.cgi?id=194375
3782
3783         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3784
3785         * lldb/lldb_webkit.py:
3786         (WTFStringImplProvider.is_8bit):
3787
3788 2019-02-28  David Quesada  <david_quesada@apple.com>
3789
3790         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3791         https://bugs.webkit.org/show_bug.cgi?id=195121
3792         rdar://problem/48450302
3793
3794         Reviewed by Alex Christensen.
3795
3796         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3797         configurations where the 'download' attribute is absent, blank, or populated
3798         with a filename, and where the anchor element is same-origin or cross-origin
3799         (meaning the 'download' attribute shouldn't be honored).
3800
3801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3802         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3803         (-[NavigationActionTestDelegate init]):
3804         (-[NavigationActionTestDelegate navigationAction]):
3805         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3806         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3807         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3808         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3809         (TEST):
3810
3811 2019-02-28  Antoine Quint  <graouts@apple.com>
3812
3813         Enable the Pointer Events runtime flag by default
3814         https://bugs.webkit.org/show_bug.cgi?id=195156
3815
3816         Reviewed by Dean Jackson.
3817
3818         * DumpRenderTree/mac/DumpRenderTree.mm:
3819         (enableExperimentalFeatures):
3820
3821 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3822
3823         Several PasteImage API tests are flaky
3824         https://bugs.webkit.org/show_bug.cgi?id=195160
3825
3826         Reviewed by Tim Horton.
3827
3828         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3829         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3830         listening for a "load" event after image load is already complete.
3831
3832         To address this, make these tests first register a "load" event handler, then run script to insert an image
3833         element into the document, and finally wait until the load event is observed before checking image size.
3834
3835         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3836
3837 2019-02-28  Chris Dumez  <cdumez@apple.com>
3838
3839         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3840         https://bugs.webkit.org/show_bug.cgi?id=195107
3841
3842         Reviewed by Alex Christensen.
3843
3844         Give some time for the zoom level to get restored.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3847
3848 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3849
3850         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3851         https://bugs.webkit.org/show_bug.cgi?id=194958
3852
3853         Reviewed by Geoffrey Garen.
3854
3855         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3856         (TEST):
3857
3858 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3859
3860         [ews-app] Update method to save build to handle builder_display_name
3861         https://bugs.webkit.org/show_bug.cgi?id=195047
3862
3863         Reviewed by Dewei Zhu.
3864
3865         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3866         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3867
3868 2019-02-28  Justin Fan  <justin_fan@apple.com>
3869
3870         [Web GPU] Enable Web GPU only on 64-bit
3871         https://bugs.webkit.org/show_bug.cgi?id=195139
3872
3873         Because Metal is only supported on 64 bit apps.
3874
3875         Unreviewed build fix.
3876
3877         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3878
3879 2019-02-27  Youenn Fablet  <youenn@apple.com>
3880
3881         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3882         https://bugs.webkit.org/show_bug.cgi?id=194959
3883
3884         Reviewed by Chris Dumez.
3885
3886         Spin loop until getting the condition to remove flakiness.
3887
3888         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3889
3890 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3891
3892         [ews-build] Buildbot should include builder_display_name in the build events
3893         https://bugs.webkit.org/show_bug.cgi?id=195045
3894
3895         Reviewed by Dewei Zhu.
3896
3897         * BuildSlaveSupport/ews-build/events.py:
3898         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3899         buildername to builder_name to be consistent in naming style.
3900         (Events.buildFinished): Ditto.
3901
3902 2019-02-27  Chris Dumez  <cdumez@apple.com>
3903
3904         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3905         https://bugs.webkit.org/show_bug.cgi?id=194480
3906
3907         Reviewed by Brady Eidson.
3908
3909         Update existing API test to make it more likely to reproduce the issue.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3912
3913 2019-02-27  Brady Eidson  <beidson@apple.com>
3914
3915         Universal links from Google search results pages don't open the app.
3916         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3917
3918         Reviewed by Geoffrey Garen.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3921         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3922         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3923         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3924
3925 2019-02-27  Chris Dumez  <cdumez@apple.com>
3926
3927         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3928         https://bugs.webkit.org/show_bug.cgi?id=195102
3929
3930         Reviewed by Geoffrey Garen.
3931
3932         If the number of processes is not yet what we expect, wait a bit and check again to give
3933         processes some time to exit.
3934
3935         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3936
3937 2019-02-27  Chris Dumez  <cdumez@apple.com>
3938
3939         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3940         https://bugs.webkit.org/show_bug.cgi?id=194545
3941
3942         Reviewed by Brady Eidson.
3943
3944         Make sure the test navigates forward and then back only once. Previously, navigating
3945         back would trigger a navigation again in a timer.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3948
3949 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3950
3951         High Sierra Debug JSC test queue should use faster hardware
3952         https://bugs.webkit.org/show_bug.cgi?id=194603
3953
3954         Rubber-stamped by Alexey Proskuryakov.
3955
3956         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3957
3958         * BuildSlaveSupport/build.webkit.org-config/config.json:
3959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3960         (BubbleQueueServer):
3961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3962         (WebKitBuildbot):
3963         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3964         * QueueStatusServer/config/queues.py:
3965         * Scripts/webkitpy/common/config/ews.json:
3966         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3967         (test_ews_name):
3968
3969 2019-02-27  John Wilander  <wilander@apple.com>
3970
3971         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3972         https://bugs.webkit.org/show_bug.cgi?id=195071
3973         <rdar://problem/48417690>
3974
3975         Reviewed by Alex Christensen and Brent Fulgham.
3976
3977         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3978         (TestWebKitAPI::createURL):
3979             Convenience function.
3980         (TestWebKitAPI::TEST):
3981             WebCore::AdClickAttribution now takes a URL when creating Source and
3982             Destination.
3983         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3984         (TestWebKitAPI::TEST):
3985             WebCore::AdClickAttribution now takes a URL when creating Source and
3986             Destination.
3987
3988 2019-02-27  Antoine Quint  <graouts@apple.com>
3989
3990         Support Pointer Events on macOS
3991         https://bugs.webkit.org/show_bug.cgi?id=195008
3992         <rdar://problem/47454419>
3993
3994         Reviewed by Dean Jackson.
3995
3996         * DumpRenderTree/mac/DumpRenderTree.mm:
3997         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3998         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3999
4000 2019-02-26  Mark Lam  <mark.lam@apple.com>
4001
4002         Remove remaining poisoning code.
4003         https://bugs.webkit.org/show_bug.cgi?id=194138
4004
4005         Reviewed by Saam Barati.
4006
4007         * TestWebKitAPI/CMakeLists.txt:
4008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4009         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4010         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4011         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4012         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4013         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4014         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4015
4016 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4017
4018         Move ephemeral local storage from WebProcess to UIProcess
4019         https://bugs.webkit.org/show_bug.cgi?id=195074
4020         <rdar://problem/47937975>
4021
4022         Reviewed by Geoff Garen.
4023
4024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4025
4026 2019-02-20  Jer Noble  <jer.noble@apple.com>
4027
4028         [Cocoa] Media elements will restart network buffering just before suspending
4029         https://bugs.webkit.org/show_bug.cgi?id=193691
4030
4031         Reviewed by Eric Carlson.
4032
4033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4035         (TEST):
4036
4037 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4038
4039         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4040         https://bugs.webkit.org/show_bug.cgi?id=191652
4041
4042         Reviewed by Alex Christensen.
4043
4044         Fix WinCairo MiniBrowser behavior of authentication dialog.
4045
4046         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4047         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4048
4049 2019-02-26  Youenn Fablet  <youenn@apple.com>
4050
4051         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4052         https://bugs.webkit.org/show_bug.cgi?id=195028
4053         <rdar://problem/48243733>
4054
4055         Reviewed by Eric Carlson.
4056
4057         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4058
4059 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4060
4061         [WPE] Add API for webview background color configuration
4062         https://bugs.webkit.org/show_bug.cgi?id=192305
4063
4064         Reviewed by Michael Catanzaro.
4065
4066         * MiniBrowser/wpe/main.cpp:
4067         (main): Add a new option to configure the webview background
4068         color. Example: --bg-color=transparent.
4069         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4070         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4071         (beforeAll): Ditto.
4072
4073 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4074
4075         scalableNativeWebpageParameters() is not preserved on new page navigation.
4076         https://bugs.webkit.org/show_bug.cgi?id=194892
4077         <rdar://problem/47538280>
4078
4079         Reviewed by Wenson Hsieh.
4080         
4081         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4082
4083         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4084         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4085         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4086         (WTR::UIScriptController::allowsViewportShrinkToFit):
4087         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4088         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4089         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4090         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4091         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4092         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4093
4094 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4095
4096         [ews-app] Add model for handling multiple Buildbot instances
4097         https://bugs.webkit.org/show_bug.cgi?id=194863
4098
4099         Reviewed by Stephanie Lewis.
4100
4101         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4102
4103 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4104
4105         [ews-app] Remove BuilderMapping table
4106         https://bugs.webkit.org/show_bug.cgi?id=194961
4107
4108         Reviewed by Stephanie Lewis.
4109
4110         Store builder name directly in build table, instead of having a separate
4111         table for it.
4112
4113         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4114         * BuildSlaveSupport/ews-app/ews/models/build.py:
4115         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4116         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4117
4118 2019-02-25  John Wilander  <wilander@apple.com>
4119
4120         Introduce and adopt new class RegistrableDomain for eTLD+1
4121         https://bugs.webkit.org/show_bug.cgi?id=194791
4122         <rdar://problem/48179240>
4123
4124         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4125
4126         This patch adds an API test and replaces two instances of
4127         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4128
4129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4130         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4131         (TestWebKitAPI::TEST):
4132             Changed two strings to make sure the registrable domains are still considered
4133             invalid and pass the test.
4134         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4135         (TestWebKitAPI::TEST):
4136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4137         (WTR::InjectedBundle::didReceiveMessageToPage):
4138
4139 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4140
4141         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4142         https://bugs.webkit.org/show_bug.cgi?id=195001
4143
4144         Reviewed by Carlos Garcia Campos.
4145
4146         API version 1.0 always includes the functionality previously guarded with
4147         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4148         unconditionally.
4149
4150         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4151         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4152         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4153         (WebViewTest::showInWindow): Ditto.
4154         (WebViewTest::hideView): Ditto.
4155         * wpe/backends/HeadlessViewBackend.cpp:
4156         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4157         * wpe/backends/ViewBackend.cpp:
4158         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4159         * wpe/backends/WindowViewBackend.cpp:
4160         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4161         WPE_BACKEND_CHECK_VERSION().
4162         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4163
4164 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4165
4166         [Flatpak] Add support for flatpak > 1.1.2
4167         https://bugs.webkit.org/show_bug.cgi?id=194088
4168
4169         Flatpak 1.2 is now out so we need to support that
4170         version now.
4171
4172         Reviewed by Michael Catanzaro.
4173
4174         * flatpak/flatpakutils.py:
4175         (check_flatpak):
4176         (FlatpakPackages.__init__):
4177         (FlatpakPackages.__detect_packages):
4178         (FlatpakPackages.__detect_packages.in):
4179         (FlatpakRepos.update):
4180
4181 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4182
4183         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4184         https://bugs.webkit.org/show_bug.cgi?id=194998
4185
4186         Reviewed by Carlos Garcia Campos.
4187
4188         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4189         to a Git checkout and using the latest commit containing various fixes
4190         and improvements.
4191
4192 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4193
4194         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4195         https://bugs.webkit.org/show_bug.cgi?id=194981
4196
4197         Reviewed by Žan Doberšek.
4198
4199         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4200         (TestWebKitAPI::TEST):
4201
4202 2019-02-23  Keith Miller  <keith_miller@apple.com>
4203
4204         Add new mac target numbers
4205         https://bugs.webkit.org/show_bug.cgi?id=194955
4206
4207         Reviewed by Tim Horton.
4208
4209         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4210         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4211         * MiniBrowser/Configurations/Base.xcconfig:
4212         * TestWebKitAPI/Configurations/Base.xcconfig:
4213         * WebKitTestRunner/Configurations/Base.xcconfig:
4214
4215 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4216
4217         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4218         https://bugs.webkit.org/show_bug.cgi?id=194846
4219
4220         Reviewed by Don Olmstead.
4221
4222         Added _search_paths() and _port_specific_expectations_files() for
4223         WinCairoPort.
4224
4225         * Scripts/webkitpy/port/win.py:
4226         (WinCairoPort.default_baseline_search_path):
4227         (WinCairoPort):
4228         (WinCairoPort._port_specific_expectations_files):
4229         (WinCairoPort._search_paths):
4230
4231 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4232
4233         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4234         https://bugs.webkit.org/show_bug.cgi?id=194963
4235
4236         Reviewed by Dean Jackson.
4237
4238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4239         Do a `contains` check instead of `equals`, because in debug builds we
4240         put the GraphicsLayer pointer in a prefix.
4241
4242 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4243
4244         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4245         https://bugs.webkit.org/show_bug.cgi?id=194873
4246         <rdar://problem/46701974>
4247
4248         Reviewed by Tim Horton.
4249
4250         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4251
4252         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4253         (WTR::UIScriptController::menuRect const):
4254         (WTR::UIScriptController::isShowingMenu const):
4255         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4256         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4257         (WTR::UIScriptController::menuRect const):
4258
4259         Add a function to query the bounds of the callout menu in content coordinates.
4260
4261         (WTR::UIScriptController::isShowingMenu const):
4262
4263         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4264
4265         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4266         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4267         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4268         (WTR::UIScriptController::rectForMenuAction const):
4269         (WTR::UIScriptController::menuRect const):
4270         (WTR::UIScriptController::isShowingMenu const):
4271         (WTR::findViewInHierarchyOfType): Deleted.
4272
4273 2019-02-22  Chris Dumez  <cdumez@apple.com>
4274
4275         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4276         https://bugs.webkit.org/show_bug.cgi?id=194954
4277         <rdar://problem/48127957>
4278
4279         Reviewed by Alex Christensen.
4280
4281         Add API test coverage.
4282
4283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4284         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4285         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4286         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4287
4288 2019-02-22  Chris Dumez  <cdumez@apple.com>
4289
4290         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4291         https://bugs.webkit.org/show_bug.cgi?id=194924
4292         <rdar://problem/48216125>
4293
4294         Reviewed by Geoffrey Garen.
4295
4296         Add API test coverage.
4297
4298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4299
4300 2019-02-22  Chris Dumez  <cdumez@apple.com>
4301
4302         Unreviewed, disable API test added in r241928 on iOS.
4303
4304         The cache is not enabled on devices with less than 3GB of RAM.
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4307
4308 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4309
4310         Hardcode Visual Viewports on everywhere except iOS WK1
4311         https://bugs.webkit.org/show_bug.cgi?id=194928
4312
4313         Reviewed by Zalan Bujtas.
4314
4315         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4316         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4317         set it to false. The setting has shipped for several years and there's no need to turn
4318         it off now.
4319
4320         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4321         Visual Viewports are not enabled.
4322         
4323         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4324         that only runs in WK2
4325
4326         * MiniBrowser/mac/SettingsController.h:
4327         * MiniBrowser/mac/SettingsController.m:
4328         (-[SettingsController init]):
4329         (-[SettingsController _populateMenu]):
4330         (-[SettingsController validateMenuItem:]):
4331         (-[SettingsController visualViewportEnabled]): Deleted.
4332         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4333         * MiniBrowser/mac/WK1BrowserWindowController.m:
4334         (-[WK1BrowserWindowController didChangeSettings]):
4335         * MiniBrowser/mac/WK2BrowserWindowController.m:
4336         (-[WK2BrowserWindowController didChangeSettings]):
4337
4338 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4339
4340         Discard cached processes when clearing website data store
4341         https://bugs.webkit.org/show_bug.cgi?id=194894
4342
4343         Reviewed by Chris Dumez.
4344
4345         Added a test case.
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4348         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4349
4350 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4351
4352         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4353         https://bugs.webkit.org/show_bug.cgi?id=194914
4354         <rdar://problem/47586889>
4355
4356         Reviewed by Geoffrey Garen.
4357
4358         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4359         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4360         (TEST):
4361         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4362
4363 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4364
4365         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4366         <https://webkit.org/b/194761>
4367
4368         Reviewed by Myles Maxfield.