scalableNativeWebpageParameters() is not preserved on new page navigation.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2
3         scalableNativeWebpageParameters() is not preserved on new page navigation.
4         https://bugs.webkit.org/show_bug.cgi?id=194892
5         <rdar://problem/47538280>
6
7         Reviewed by Wenson Hsieh.
8         
9         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
13         * DumpRenderTree/mac/UIScriptControllerMac.mm:
14         (WTR::UIScriptController::allowsViewportShrinkToFit):
15         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
16         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
17         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
18         * TestRunnerShared/UIScriptContext/UIScriptController.h:
19         * WebKitTestRunner/UIScriptControllerCocoa.mm:
20         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
21
22 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
23
24         [ews-app] Add model for handling multiple Buildbot instances
25         https://bugs.webkit.org/show_bug.cgi?id=194863
26
27         Reviewed by Stephanie Lewis.
28
29         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
30
31 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
32
33         [ews-app] Remove BuilderMapping table
34         https://bugs.webkit.org/show_bug.cgi?id=194961
35
36         Reviewed by Stephanie Lewis.
37
38         Store builder name directly in build table, instead of having a separate
39         table for it.
40
41         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
42         * BuildSlaveSupport/ews-app/ews/models/build.py:
43         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
44         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
45
46 2019-02-25  John Wilander  <wilander@apple.com>
47
48         Introduce and adopt new class RegistrableDomain for eTLD+1
49         https://bugs.webkit.org/show_bug.cgi?id=194791
50         <rdar://problem/48179240>
51
52         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
53
54         This patch adds an API test and replaces two instances of
55         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
59         (TestWebKitAPI::TEST):
60             Changed two strings to make sure the registrable domains are still considered
61             invalid and pass the test.
62         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
63         (TestWebKitAPI::TEST):
64         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
65         (WTR::InjectedBundle::didReceiveMessageToPage):
66
67 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
68
69         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
70         https://bugs.webkit.org/show_bug.cgi?id=195001
71
72         Reviewed by Carlos Garcia Campos.
73
74         API version 1.0 always includes the functionality previously guarded with
75         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
76         unconditionally.
77
78         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
79         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
80         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
81         (WebViewTest::showInWindow): Ditto.
82         (WebViewTest::hideView): Ditto.
83         * wpe/backends/HeadlessViewBackend.cpp:
84         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
85         * wpe/backends/ViewBackend.cpp:
86         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
87         * wpe/backends/WindowViewBackend.cpp:
88         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
89         WPE_BACKEND_CHECK_VERSION().
90         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
91
92 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
93
94         [Flatpak] Add support for flatpak > 1.1.2
95         https://bugs.webkit.org/show_bug.cgi?id=194088
96
97         Flatpak 1.2 is now out so we need to support that
98         version now.
99
100         Reviewed by Michael Catanzaro.
101
102         * flatpak/flatpakutils.py:
103         (check_flatpak):
104         (FlatpakPackages.__init__):
105         (FlatpakPackages.__detect_packages):
106         (FlatpakPackages.__detect_packages.in):
107         (FlatpakRepos.update):
108
109 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
110
111         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
112         https://bugs.webkit.org/show_bug.cgi?id=194998
113
114         Reviewed by Carlos Garcia Campos.
115
116         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
117         to a Git checkout and using the latest commit containing various fixes
118         and improvements.
119
120 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
121
122         [WPE][GTK] Remove user agent quirk for washingtonpost.com
123         https://bugs.webkit.org/show_bug.cgi?id=194981
124
125         Reviewed by Žan Doberšek.
126
127         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
128         (TestWebKitAPI::TEST):
129
130 2019-02-23  Keith Miller  <keith_miller@apple.com>
131
132         Add new mac target numbers
133         https://bugs.webkit.org/show_bug.cgi?id=194955
134
135         Reviewed by Tim Horton.
136
137         * DumpRenderTree/mac/Configurations/Base.xcconfig:
138         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
139         * MiniBrowser/Configurations/Base.xcconfig:
140         * TestWebKitAPI/Configurations/Base.xcconfig:
141         * WebKitTestRunner/Configurations/Base.xcconfig:
142
143 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
144
145         [WinCairo] Enable wk1/wk2 suffix for platform search path.
146         https://bugs.webkit.org/show_bug.cgi?id=194846
147
148         Reviewed by Don Olmstead.
149
150         Added _search_paths() and _port_specific_expectations_files() for
151         WinCairoPort.
152
153         * Scripts/webkitpy/port/win.py:
154         (WinCairoPort.default_baseline_search_path):
155         (WinCairoPort):
156         (WinCairoPort._port_specific_expectations_files):
157         (WinCairoPort._search_paths):
158
159 2019-02-22  Tim Horton  <timothy_horton@apple.com>
160
161         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
162         https://bugs.webkit.org/show_bug.cgi?id=194963
163
164         Reviewed by Dean Jackson.
165
166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
167         Do a `contains` check instead of `equals`, because in debug builds we
168         put the GraphicsLayer pointer in a prefix.
169
170 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
171
172         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
173         https://bugs.webkit.org/show_bug.cgi?id=194873
174         <rdar://problem/46701974>
175
176         Reviewed by Tim Horton.
177
178         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
179
180         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
181         (WTR::UIScriptController::menuRect const):
182         (WTR::UIScriptController::isShowingMenu const):
183         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
184         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
185         (WTR::UIScriptController::menuRect const):
186
187         Add a function to query the bounds of the callout menu in content coordinates.
188
189         (WTR::UIScriptController::isShowingMenu const):
190
191         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
192
193         * TestRunnerShared/UIScriptContext/UIScriptController.h:
194         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
195         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
196         (WTR::UIScriptController::rectForMenuAction const):
197         (WTR::UIScriptController::menuRect const):
198         (WTR::UIScriptController::isShowingMenu const):
199         (WTR::findViewInHierarchyOfType): Deleted.
200
201 2019-02-22  Chris Dumez  <cdumez@apple.com>
202
203         Regression(PSON) Unable to preview password-protected documents on iCloud.com
204         https://bugs.webkit.org/show_bug.cgi?id=194954
205         <rdar://problem/48127957>
206
207         Reviewed by Alex Christensen.
208
209         Add API test coverage.
210
211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
212         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
213         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
214         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
215
216 2019-02-22  Chris Dumez  <cdumez@apple.com>
217
218         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
219         https://bugs.webkit.org/show_bug.cgi?id=194924
220         <rdar://problem/48216125>
221
222         Reviewed by Geoffrey Garen.
223
224         Add API test coverage.
225
226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
227
228 2019-02-22  Chris Dumez  <cdumez@apple.com>
229
230         Unreviewed, disable API test added in r241928 on iOS.
231
232         The cache is not enabled on devices with less than 3GB of RAM.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
235
236 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
237
238         Hardcode Visual Viewports on everywhere except iOS WK1
239         https://bugs.webkit.org/show_bug.cgi?id=194928
240
241         Reviewed by Zalan Bujtas.
242
243         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
244         change the default value of the Setting to 'true', and hardcode WebView on iOS to
245         set it to false. The setting has shipped for several years and there's no need to turn
246         it off now.
247
248         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
249         Visual Viewports are not enabled.
250         
251         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
252         that only runs in WK2
253
254         * MiniBrowser/mac/SettingsController.h:
255         * MiniBrowser/mac/SettingsController.m:
256         (-[SettingsController init]):
257         (-[SettingsController _populateMenu]):
258         (-[SettingsController validateMenuItem:]):
259         (-[SettingsController visualViewportEnabled]): Deleted.
260         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
261         * MiniBrowser/mac/WK1BrowserWindowController.m:
262         (-[WK1BrowserWindowController didChangeSettings]):
263         * MiniBrowser/mac/WK2BrowserWindowController.m:
264         (-[WK2BrowserWindowController didChangeSettings]):
265
266 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
267
268         Discard cached processes when clearing website data store
269         https://bugs.webkit.org/show_bug.cgi?id=194894
270
271         Reviewed by Chris Dumez.
272
273         Added a test case.
274
275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
276         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
277
278 2019-02-21  Alex Christensen  <achristensen@webkit.org>
279
280         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
281         https://bugs.webkit.org/show_bug.cgi?id=194914
282         <rdar://problem/47586889>
283
284         Reviewed by Geoffrey Garen.
285
286         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
287         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
288         (TEST):
289         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
290
291 2019-02-21  David Kilzer  <ddkilzer@apple.com>
292
293         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
294         <https://webkit.org/b/194761>
295
296         Reviewed by Myles Maxfield.
297
298         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
299         (WTR::activateSystemCoreWebFonts): Log `error` to console if
300         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
301         to use ARC-compliant cast.
302         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
303         ARC-compliant cast.
304         (WTR::installFakeHelvetica): Log `error` to console if
305         CTFontManagerRegisterFontsForURL() fails, but only on supported
306         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
307         Call CFRelease() on `error` to fix the leak.  Update to use
308         ARC-compliant cast.
309         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
310         cast.
311
312 2019-02-21  Chris Dumez  <cdumez@apple.com>
313
314         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
315         https://bugs.webkit.org/show_bug.cgi?id=194481
316
317         Reviewed by Alex Christensen.
318
319         Give the processes a chance to shutdown and wait until we reached the expected number
320         of processes.
321
322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
323
324 2019-02-21  Tim Horton  <timothy_horton@apple.com>
325
326         Fix the macOS build
327
328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
329
330 2019-02-21  Tim Horton  <timothy_horton@apple.com>
331
332         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
333
334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
335         I am a backwards.
336
337 2019-02-21  Tim Horton  <timothy_horton@apple.com>
338
339         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
340
341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
342         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
343         We could force on UI-side compositing, but I feel like the test might be more
344         valuable exercising the normal path on each platform (though the original
345         bug was also UI-side specific). Though we can't validate that the overlay
346         layer was installed successfully, there are layout tests that do that.
347
348 2019-02-21  Tim Horton  <timothy_horton@apple.com>
349
350         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
351         https://bugs.webkit.org/show_bug.cgi?id=194845
352         <rdar://problem/47944579>
353
354         Reviewed by Antti Koivisto.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
358
359 2019-02-21  Zalan Bujtas  <zalan@apple.com>
360
361         [LFC][Floats] Add support for placing formatting roots in-between floats.
362         https://bugs.webkit.org/show_bug.cgi?id=194902
363
364         Reviewed by Antti Koivisto.
365
366         * LayoutReloaded/misc/LFC-passing-tests.txt:
367
368 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
369
370         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
371         https://bugs.webkit.org/show_bug.cgi?id=194901
372
373         Unreviewed build fix.
374
375         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
376         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
377         WPEBackend-fdo-0.1 as library name.
378
379 2019-02-21  Rob Buis  <rbuis@igalia.com>
380
381         Update MIME type parser
382         https://bugs.webkit.org/show_bug.cgi?id=180526
383
384         Reviewed by Darin Adler.
385
386         Add tests involving leading and trailing whitespace, non-token
387         characters and quoted strings.
388
389         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
390         (TestWebKitAPI::TEST):
391
392 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
393
394         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
395         https://bugs.webkit.org/show_bug.cgi?id=194884
396
397         Reviewed by Michael Catanzaro.
398
399         * PlatformWin.cmake:
400
401 2019-02-20  Chris Dumez  <cdumez@apple.com>
402
403         Add API test for <rdar://problem/47471222>
404         https://bugs.webkit.org/show_bug.cgi?id=194847
405
406         Reviewed by Alex Christensen.
407
408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
409
410 2019-02-20  Chris Dumez  <cdumez@apple.com>
411
412         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
413         https://bugs.webkit.org/show_bug.cgi?id=194872
414         <rdar://problem/47924500>
415
416         Reviewed by Alex Christensen.
417
418         Add API test coverage.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
421
422 2019-02-20  Jer Noble  <jer.noble@apple.com>
423
424         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
425         https://bugs.webkit.org/show_bug.cgi?id=191332
426
427         Reviewed by Dean Jackson.
428
429         * Scripts/git-is-in-range: Added.
430
431 2019-02-20  Andy Estes  <aestes@apple.com>
432
433         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
434         https://bugs.webkit.org/show_bug.cgi?id=194869
435
436         Rubber-stamped by Jer Noble.
437
438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
439         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
440         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
441         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
444
445 2019-02-20  Chris Dumez  <cdumez@apple.com>
446
447         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
448         https://bugs.webkit.org/show_bug.cgi?id=194857
449         <rdar://problem/47759323>
450
451         Reviewed by Alex Christensen.
452
453         Add API test coverage.
454
455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
456
457 2019-02-20  Chris Dumez  <cdumez@apple.com>
458
459         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
460         https://bugs.webkit.org/show_bug.cgi?id=194829
461         <rdar://problem/47889906>
462
463         Reviewed by Alexey Proskuryakov.
464
465         Every time the TestOptions were changing we were creating both a new Web view and
466         a new WKContext, which would start a new Network process. In most cases, we only
467         need to contruct a new Web view and we do can keep reusing the same WKContext.
468         This patch implements this optimization and thus avoids spinning a lot of new
469         Network processes while running the layout tests.
470
471         * WebKitTestRunner/TestController.cpp:
472         (WTR::TestController::generateContextConfiguration const):
473         (WTR::TestController::generatePageConfiguration):
474         (WTR::TestController::createWebViewWithOptions):
475         (WTR::TestController::resetPreferencesToConsistentValues):
476         (WTR::updateTestOptionsFromTestHeader):
477         * WebKitTestRunner/TestController.h:
478         * WebKitTestRunner/TestOptions.h:
479         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
480         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
481         (WTR::TestOptions::hasSameInitializationOptions const):
482         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
483         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
484         (WTR::TestController::platformAddTestOptions const):
485
486 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
487
488         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
489         https://bugs.webkit.org/show_bug.cgi?id=167941
490
491         Reviewed by Carlos Garcia Campos.
492
493         * MiniBrowser/gtk/main.c:
494         (filterSavedCallback): Added.
495         (main): Support loading a JSON rule set file for content filtering.
496         * MiniBrowser/wpe/main.cpp:
497         (filterSavedCallback): Added.
498         (main): Support loading a JSON rule set file for content filtering.
499         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
500         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
501         (WTF::derefGPtr): Ditto.
502         (testEmptyStore):
503         (testSaveInvalidFilter):
504         (testSaveLoadFilter):
505         (testSavedFilterIdentifierMatch):
506         (testRemoveFilter):
507         (testSaveMultipleFilters):
508         (testSaveFilterFromFile):
509         (testFilterPersistence):
510         (beforeAll):
511         (afterAll):
512         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
513         (removeOldInjectedContentAndResetLists): Also reset content filters.
514         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
515         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
516         the element affected by the style sheet.
517         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
518         and returns it to be used by tests.
519         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
520         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
521         (serverCallback): Add support for serving a CSS style sheet for testing.
522         (beforeAll): Add call to testUserContentManagerContentFilter().
523         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
524
525 2019-02-19  Keith Rollin  <krollin@apple.com>
526
527         Add timing information to build output
528         https://bugs.webkit.org/show_bug.cgi?id=194839
529         <rdar://problem/48219609>
530
531         Reviewed by Alexey Proskuryakov.
532
533         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
534         emit each project's build time to its output. E.g.,
535
536             ** BUILD SUCCEEDED ** [0.132 sec]
537
538         * Scripts/webkitdirs.pm:
539         (XcodeOptions):
540
541 2019-02-19  Truitt Savell  <tsavell@apple.com>
542
543         Unreviewed, rolling out r241784.
544
545         Broke all OpenSource builds.
546
547         Reverted changeset:
548
549         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
550         instances view"
551         https://bugs.webkit.org/show_bug.cgi?id=172848
552         https://trac.webkit.org/changeset/241784
553
554 2019-02-19  Zalan Bujtas  <zalan@apple.com>
555
556         [LFC][Floats] Remove redundant intersecting logic
557         https://bugs.webkit.org/show_bug.cgi?id=194804
558
559         Reviewed by Antti Koivisto.
560
561         * LayoutReloaded/misc/LFC-passing-tests.txt:
562
563 2019-02-19  Dean Jackson  <dino@apple.com>
564
565         Clean-up output from generate-xcfilelists so it can be filtered
566         https://bugs.webkit.org/show_bug.cgi?id=194795
567
568         Reviewed by Joseph Pecoraro (and Keith Rollin).
569
570         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
571         make a slight tweak to filter-build-webkit so such lines are marked
572         as plain.
573
574         * Scripts/filter-build-webkit:
575         * Scripts/generate-xcfilelists:
576
577 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
578
579         pytest is not correctly auto-installed
580         https://bugs.webkit.org/show_bug.cgi?id=194707
581
582         Reviewed by Carlos Garcia Campos.
583
584         * Scripts/webkitpy/thirdparty/__init__.py:
585         (AutoinstallImportHook._install_pytest):
586
587 2019-02-18  Chris Dumez  <cdumez@apple.com>
588
589         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
590         https://bugs.webkit.org/show_bug.cgi?id=194797
591         <rdar://problem/48055151>
592
593         Reviewed by Geoffrey Garen.
594
595         Add API test coverage.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
598
599 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
602         https://bugs.webkit.org/show_bug.cgi?id=194670
603         <rdar://problem/39066529>
604
605         Reviewed by Tim Horton.
606
607         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
608         pasted in an editable area as attachment elements.
609
610         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
611         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
612         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
613         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
614         (TestWebKitAPI::TEST):
615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
616         (WTR::InjectedBundlePage::InjectedBundlePage):
617
618 2019-02-18  Alex Christensen  <achristensen@webkit.org>
619
620         Fix API test after r241728
621        ​https://bugs.webkit.org/show_bug.cgi?id=194723
622
623         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
624         (TEST):
625         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
626
627 2019-02-18  Daniel Bates  <dabates@apple.com>
628
629         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
630         https://bugs.webkit.org/show_bug.cgi?id=192824
631         <rdar://problem/47100332>
632
633         Reviewed by Wenson Hsieh.
634
635         Fix a bug where the wrong usage code was used for F13 thru F24.
636
637         * WebKitTestRunner/ios/HIDEventGenerator.mm:
638         (keyCodeForDOMFunctionKey):
639
640 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
641
642         Bytecode cache should a have a boot-specific validation
643         https://bugs.webkit.org/show_bug.cgi?id=194769
644         <rdar://problem/48149509>
645
646         Reviewed by Keith Miller.
647
648         Add test for WTF::bootSessionUUIDString()
649
650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
651         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
652         (TEST):
653
654 2019-02-18  Alex Christensen  <achristensen@webkit.org>
655
656         Disable safe browsing in WKWebView and remove its WKPreferences API
657         https://bugs.webkit.org/show_bug.cgi?id=194723
658         <rdar://problem/48122993>
659
660         Reviewed by Geoffrey Garen.
661
662         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
663         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
664         (TEST):
665         (safeBrowsingView):
666         Make tests use SPI instead of API.
667
668 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
669
670         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
671         https://bugs.webkit.org/show_bug.cgi?id=194586
672
673         Reviewed by Ross Kirsling.
674
675         * DumpRenderTree/win/DumpRenderTree.cpp:
676         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
677         * Scripts/webkitpy/port/driver.py:
678         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
679
680 2019-02-17  David Kilzer  <ddkilzer@apple.com>
681
682         Unreviewed, rolling out r241620.
683
684         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
685         (Requested by ddkilzer on #webkit.)
686
687         Reverted changeset:
688
689         "[WTF] Add environment variable helpers"
690         https://bugs.webkit.org/show_bug.cgi?id=192405
691         https://trac.webkit.org/changeset/241620
692
693 2019-02-16  Zalan Bujtas  <zalan@apple.com>
694
695         [LFC] RenderImage's default intrinsic size is 0.
696         https://bugs.webkit.org/show_bug.cgi?id=194745
697
698         Reviewed by Antti Koivisto.
699
700         * LayoutReloaded/misc/LFC-passing-tests.txt:
701
702 2019-02-16  Zalan Bujtas  <zalan@apple.com>
703
704         [LFC][BFC] Add support for block replaced intrinsic width.
705         https://bugs.webkit.org/show_bug.cgi?id=194705
706
707         Reviewed by Simon Fraser.
708
709         * LayoutReloaded/misc/LFC-passing-tests.txt:
710
711 2019-02-16  Zalan Bujtas  <zalan@apple.com>
712
713         [LFC] Apply min/max width constraints to preferred width computation
714         https://bugs.webkit.org/show_bug.cgi?id=194739
715
716         Reviewed by Simon Fraser.
717
718         * LayoutReloaded/misc/LFC-passing-tests.txt:
719
720 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
721
722         [WTF] Add environment variable helpers
723         https://bugs.webkit.org/show_bug.cgi?id=192405
724
725         Reviewed by Michael Catanzaro.
726
727         * DumpRenderTree/mac/DumpRenderTree.mm:
728         (libraryPathForDumpRenderTree):
729         * DumpRenderTree/win/DumpRenderTree.cpp:
730         (libraryPathForDumpRenderTree):
731         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
732         (setUpIOSLayoutTestCommunication):
733         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
734         (beforeAll):
735         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
736         (main):
737         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
738         (WebKitTestBus::run):
739         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
740         (WTR::getOutputDir):
741         (WTR::initializeFontConfigSetting):
742         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
743         (WTR::InjectedBundle::platformInitialize):
744         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
745         (WTR::topLevelPath):
746         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
747         (WTR::topLevelPath):
748         (WTR::getOutputDir):
749         (WTR::activateFonts):
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::TestController::libraryPathForTesting):
752         (WTR::TestController::generateContextConfiguration const):
753         (WTR::TestController::generatePageConfiguration):
754         (WTR::TestController::decideDestinationWithSuggestedFilename):
755         (WTR::TestController::platformAdjustContext):
756         * WebKitTestRunner/TestController.h:
757         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
758         (WTR::TestController::cocoaPlatformInitialize):
759         (WTR::TestController::platformAdjustContext):
760         * WebKitTestRunner/gtk/main.cpp:
761         (main):
762         * WebKitTestRunner/mac/TestControllerMac.mm:
763         (WTR::TestController::configureContentExtensionForTest):
764         * WebKitTestRunner/wpe/main.cpp:
765         (main):
766         Utilize WTF::Environment where possible.
767
768 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
769
770         [iOS] WKWebView callout bar is missing Change Writing Direction item
771         https://bugs.webkit.org/show_bug.cgi?id=190015
772         <rdar://problem/44810366>
773
774         Reviewed by Tim Horton.
775
776         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
777         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
780         (TestWebKitAPI::TEST):
781
782 2019-02-15  Chris Dumez  <cdumez@apple.com>
783
784         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
785         https://bugs.webkit.org/show_bug.cgi?id=194717
786         <rdar://problem/47884404>
787
788         Reviewed by Brady Eidson.
789
790         Add API test coverage.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
793
794 2019-02-15  Youenn Fablet  <youenn@apple.com>
795
796         Make navigator.mediaDevices SecureContext
797         https://bugs.webkit.org/show_bug.cgi?id=194666
798
799         Reviewed by Eric Carlson.
800
801         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
802         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
803         (TEST_F):
804
805 2019-02-15  Brian Burg  <bburg@apple.com>
806
807         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
808         https://bugs.webkit.org/show_bug.cgi?id=194411
809         <rdar://problem/47787614>
810
811         Reviewed by Joseph Pecoraro.
812
813         Remove unnecessary soft linking macro usage.
814
815         * DumpRenderTree/mac/TestRunnerMac.mm:
816         (TestRunner::inspectorTestStubURL):
817         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
818         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
819         (WTR::TestRunner::inspectorTestStubURL):
820
821 2019-02-15  Commit Queue  <commit-queue@webkit.org>
822
823         Unreviewed, rolling out r241559 and r241566.
824         https://bugs.webkit.org/show_bug.cgi?id=194710
825
826         Causes layout test crashes under GuardMalloc (Requested by
827         ryanhaddad on #webkit).
828
829         Reverted changesets:
830
831         "[WTF] Add environment variable helpers"
832         https://bugs.webkit.org/show_bug.cgi?id=192405
833         https://trac.webkit.org/changeset/241559
834
835         "Unreviewed build fix for WinCairo Debug after r241559."
836         https://trac.webkit.org/changeset/241566
837
838 2019-02-15  Zalan Bujtas  <zalan@apple.com>
839
840         [LFC] Out-of-flow box is never a float box
841         https://bugs.webkit.org/show_bug.cgi?id=194704
842
843         Reviewed by Antti Koivisto.
844
845         * LayoutReloaded/misc/LFC-passing-tests.txt:
846
847 2019-02-10  Darin Adler  <darin@apple.com>
848
849         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
850         https://bugs.webkit.org/show_bug.cgi?id=194487
851
852         Reviewed by Daniel Bates.
853
854         * DumpRenderTree/win/DumpRenderTree.cpp:
855         (applicationId): Use makeString instead of String::format.
856         (main): Ditto.
857         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
858         (TestWebKitAPI::Util::createURLForResource): Ditto.
859         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
860         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
861
862         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
863         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
864         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
865         (WTR::createStringWithAttributes): Use appendLiteral.
866         (WTR::AccessibilityUIElement::helpText const): Ditto.
867         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
868         directly instead of using String::format.
869         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
870         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
871
872 2019-02-15  Truitt Savell  <tsavell@apple.com>
873
874         Unreviewed, rolling out r241564.
875
876         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
877
878         Reverted changeset:
879
880         "[Mac] WebInspectorUI.framework does not need to be soft-
881         linked anymore"
882         https://bugs.webkit.org/show_bug.cgi?id=194411
883         https://trac.webkit.org/changeset/241564
884
885 2019-02-15  Saam barati  <sbarati@apple.com>
886
887         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
888         https://bugs.webkit.org/show_bug.cgi?id=194036
889
890         Reviewed by Yusuke Suzuki.
891
892         * Scripts/run-jsc-stress-tests:
893
894 2019-02-14  Tim Horton  <timothy_horton@apple.com>
895
896         Fix the build.
897
898         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
899         (WTR::UIScriptController::drawSquareInEditableImage):
900         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
901         (TestWebKitAPI::drawSquareInEditableImage):
902
903 2019-02-14  Tim Horton  <timothy_horton@apple.com>
904
905         Fix the build.
906
907         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
908         (WTR::UIScriptController::drawSquareInEditableImage):
909         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
910         (TestWebKitAPI::drawSquareInEditableImage):
911
912 2019-02-14  Brian Burg  <bburg@apple.com>
913
914         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
915         https://bugs.webkit.org/show_bug.cgi?id=194411
916         <rdar://problem/47787614>
917
918         Reviewed by Joseph Pecoraro.
919
920         Remove unnecessary soft linking macro usage.
921
922         * DumpRenderTree/mac/TestRunnerMac.mm:
923         (TestRunner::inspectorTestStubURL):
924         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
925         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
926         (WTR::TestRunner::inspectorTestStubURL):
927
928 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
929
930         [ews-app] status bubble should fetch builder name info from BuilderMapping table
931         https://bugs.webkit.org/show_bug.cgi?id=194599
932
933         Reviewed by Lucas Forschler.
934
935         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
936         (StatusBubble._build_bubble):
937
938 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
939
940         [ews-app] Set Foreign Key in Django build model
941         https://bugs.webkit.org/show_bug.cgi?id=194667
942
943         Reviewed by Lucas Forschler.
944
945         * BuildSlaveSupport/ews-app/ews/models/build.py:
946         (Build):
947
948 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
949
950         [WTF] Add environment variable helpers
951         https://bugs.webkit.org/show_bug.cgi?id=192405
952
953         Reviewed by Michael Catanzaro.
954
955         * DumpRenderTree/mac/DumpRenderTree.mm:
956         (libraryPathForDumpRenderTree):
957         * DumpRenderTree/win/DumpRenderTree.cpp:
958         (libraryPathForDumpRenderTree):
959         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
960         (setUpIOSLayoutTestCommunication):
961         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
962         (TestWebKitAPI::strip):
963         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
964         (beforeAll):
965         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
966         (main):
967         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
968         (WebKitTestBus::run):
969         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
970         (WTR::getOutputDir):
971         (WTR::initializeFontConfigSetting):
972         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
973         (WTR::InjectedBundle::platformInitialize):
974         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
975         (WTR::topLevelPath):
976         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
977         (WTR::topLevelPath):
978         (WTR::getOutputDir):
979         (WTR::activateFonts):
980         * WebKitTestRunner/TestController.cpp:
981         (WTR::TestController::libraryPathForTesting):
982         (WTR::TestController::generateContextConfiguration const):
983         (WTR::TestController::generatePageConfiguration):
984         (WTR::TestController::decideDestinationWithSuggestedFilename):
985         (WTR::TestController::platformAdjustContext):
986         * WebKitTestRunner/TestController.h:
987         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
988         (WTR::TestController::cocoaPlatformInitialize):
989         (WTR::TestController::platformAdjustContext):
990         * WebKitTestRunner/gtk/main.cpp:
991         (main):
992         * WebKitTestRunner/mac/TestControllerMac.mm:
993         (WTR::TestController::configureContentExtensionForTest):
994         * WebKitTestRunner/wpe/main.cpp:
995         (main):
996         Utilize WTF::Environment where possible.
997
998 2019-02-14  Chris Dumez  <cdumez@apple.com>
999
1000         [PSON] Introduce a WebContent Process cache
1001         https://bugs.webkit.org/show_bug.cgi?id=194594
1002         <rdar://problem/46793397>
1003
1004         Reviewed by Geoff Garen.
1005
1006         Update API tests to turn on the WebContent Process cache.
1007
1008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1009
1010 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1011
1012         Unreviewed, build fix after r241480
1013
1014         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1015         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1016         (-[DragAndDropSimulator initWithWebView:]):
1017
1018 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1019
1020         AX: ARIA Reflection was disabled in error
1021         https://bugs.webkit.org/show_bug.cgi?id=194647
1022         <rdar://problem/48068336>
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         Remove test override now that this feature should be enabled by default.
1027
1028         * WebKitTestRunner/TestController.cpp:
1029         (WTR::TestController::resetPreferencesToConsistentValues):
1030
1031 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1032
1033         Unreviewed, rolling out r241486.
1034         https://bugs.webkit.org/show_bug.cgi?id=194655
1035
1036         causing API failures in builds (Requested by ShawnRoberts on
1037         #webkit).
1038
1039         Reverted changeset:
1040
1041         "[Cocoa] Media elements will restart network buffering just
1042         before suspending"
1043         https://bugs.webkit.org/show_bug.cgi?id=193691
1044         https://trac.webkit.org/changeset/241486
1045
1046 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1047
1048         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1049         https://bugs.webkit.org/show_bug.cgi?id=194622
1050
1051         Reviewed by Antti Koivisto.
1052
1053         * LayoutReloaded/misc/LFC-passing-tests.txt:
1054
1055 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1056
1057         [LFC] Shrink-to-fit-width should be constrained by min/max width
1058         https://bugs.webkit.org/show_bug.cgi?id=194653
1059
1060         Reviewed by Antti Koivisto.
1061
1062         * LayoutReloaded/misc/LFC-passing-tests.txt:
1063
1064 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1067         https://bugs.webkit.org/show_bug.cgi?id=194641
1068
1069         Reviewed by Geoffrey Garen.
1070
1071         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1072         so that the test would fail without this fix.
1073
1074         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1075         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1076
1077 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-app] Change log level for a log statement
1080
1081         Unreviewed minor fix.
1082
1083         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1084         (Patch.save_patch):
1085
1086 2019-02-13  Jer Noble  <jer.noble@apple.com>
1087
1088         [Cocoa] Media elements will restart network buffering just before suspending
1089         https://bugs.webkit.org/show_bug.cgi?id=193691
1090
1091         Reviewed by Eric Carlson.
1092
1093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1095         (TEST):
1096
1097 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1098
1099         [ews-app] Fetch builder id to name mapping
1100         https://bugs.webkit.org/show_bug.cgi?id=194355
1101
1102         Reviewed by Lucas Forschler.
1103
1104         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1105         (Buildbot.get_builder_id_to_name_mapping):
1106         (Buildbot._get_display_name_from_builder_name):
1107
1108 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1109
1110         Further restricting webarchive loads
1111         https://bugs.webkit.org/show_bug.cgi?id=194567
1112         <rdar://problem/47610130>
1113
1114         Reviewed by Youenn Fablet.
1115
1116         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1117         navigations on drop.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1121         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1122         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1123         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1124         (TestWebKitAPI::TEST):
1125         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1126         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1127         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1128         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1129         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1130         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1131         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1132
1133 2019-02-13  John Wilander  <wilander@apple.com>
1134
1135         Store Ad Click Attribution requests in the network process
1136         https://bugs.webkit.org/show_bug.cgi?id=194510
1137         <rdar://problem/47650118>
1138
1139         Reviewed by Alex Christensen and Daniel Bates.
1140
1141         This patch adds two TestRunner functions:
1142         - dumpAdClickAttribution()
1143         - clearAdClickAttribution()
1144
1145         They call into the network process to dump and clear Ad Click
1146         Attribution state, respectively.
1147
1148         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1149         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1150         (WTR::TestRunner::dumpAdClickAttribution):
1151         (WTR::TestRunner::clearAdClickAttribution):
1152         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1153         * WebKitTestRunner/TestController.cpp:
1154         (WTR::TestController::resetStateToConsistentValues):
1155         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1156         (WTR::adClickAttributionStringResultCallback):
1157         (WTR::TestController::dumpAdClickAttribution):
1158         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1159         (WTR::adClickAttributionVoidCallback):
1160         (WTR::TestController::clearAdClickAttribution):
1161         * WebKitTestRunner/TestController.h:
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::TestInvocation::dumpResults):
1164         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1165         (WTR::TestInvocation::dumpAdClickAttribution):
1166         * WebKitTestRunner/TestInvocation.h:
1167
1168 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-app] Generate status-bubble
1171         https://bugs.webkit.org/show_bug.cgi?id=194572
1172
1173         Reviewed by Lucas Forschler.
1174
1175         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1176         (StatusBubble._build_bubble):
1177         (StatusBubble._should_show_bubble_for):
1178         (StatusBubble._build_bubbles_for_patch):
1179
1180 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-app] Add status bubble html template
1183         https://bugs.webkit.org/show_bug.cgi?id=194571
1184
1185         Reviewed by Lucas Forschler.
1186
1187         * BuildSlaveSupport/ews-app/ews/templates: Added.
1188         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1189
1190 2019-02-12  Chris Dumez  <cdumez@apple.com>
1191
1192         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1193         https://bugs.webkit.org/show_bug.cgi?id=194568
1194         <rdar://problem/47944490>
1195
1196         Reviewed by Ryosuke Niwa.
1197
1198         Add API test coverage.
1199
1200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1201         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1202
1203 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1204
1205         webkitpy: Remove bug_dummy from parsed test expectations
1206         https://bugs.webkit.org/show_bug.cgi?id=194562
1207         <rdar://problem/47853999>
1208
1209         Reviewed by Lucas Forschler.
1210
1211         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1212         (TestExpectationParser):
1213         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1214         skipped tests.
1215         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1216
1217 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1218
1219         [ews-app] Add method to fetch patch
1220         https://bugs.webkit.org/show_bug.cgi?id=194518
1221
1222         Reviewed by Lucas Forschler.
1223
1224         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1225         (Patch.get_patch):
1226
1227 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1228
1229         [LFC] Expand tests coverage (60 new tests -> 860)
1230
1231         Unreviewed test gardening (run-singly, --child-processes=1).
1232
1233         * LayoutReloaded/misc/LFC-passing-tests.txt:
1234
1235 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1236
1237         Allow pages to trigger programmatic paste from script on iOS
1238         https://bugs.webkit.org/show_bug.cgi?id=194271
1239         <rdar://problem/47808810>
1240
1241         Reviewed by Tim Horton.
1242
1243         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1244
1245         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1246         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1247         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1248         (WTR::UIScriptController::rectForMenuAction const):
1249
1250         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1251         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1252         for when the menu is shown or hidden.
1253
1254         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1255         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1256         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1257         (WTR::UIScriptController::setDidShowMenuCallback):
1258         (WTR::UIScriptController::didShowMenuCallback const):
1259         (WTR::UIScriptController::setDidHideMenuCallback):
1260         (WTR::UIScriptController::didHideMenuCallback const):
1261         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1262         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1263         (WTR::UIScriptController::rectForMenuAction const):
1264         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1265         * WebKitTestRunner/TestController.cpp:
1266         (WTR::TestController::resetPreferencesToConsistentValues):
1267         (WTR::updateTestOptionsFromTestHeader):
1268         * WebKitTestRunner/TestOptions.h:
1269
1270         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1271         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1272
1273         (WTR::TestOptions::hasSameInitializationOptions const):
1274         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1275         (WTR::UIScriptController::calendarType const):
1276         (WTR::UIScriptController::platformUndoManager const):
1277         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1278         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1279         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1280         (-[TestRunnerWKWebView dealloc]):
1281         (-[TestRunnerWKWebView _didShowMenu]):
1282         (-[TestRunnerWKWebView _didHideMenu]):
1283
1284         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1285
1286         * WebKitTestRunner/ios/TestControllerIOS.mm:
1287         (WTR::handleMenuWillHideNotification):
1288         (WTR::handleMenuDidHideNotification):
1289         (WTR::TestController::platformInitialize):
1290         (WTR::TestController::platformDestroy):
1291         (WTR::TestController::platformResetStateToConsistentValues):
1292
1293         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1294         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1295
1296         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1297         (WTR::forEachViewInHierarchy):
1298         (WTR::findViewInHierarchyOfType):
1299
1300         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1301         functions that dig through a given view's hierarchy in search of a view of a given class.
1302
1303         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1304         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1305         (WTR::UIScriptController::selectionCaretViewRect const):
1306         (WTR::UIScriptController::selectionRangeViewRects const):
1307         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1308         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1309
1310         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1311
1312         (WTR::UIScriptController::rectForMenuAction const):
1313
1314         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1315         callout bar) whose label matches the given string.
1316
1317         (WTR::UIScriptController::platformContentView const):
1318
1319         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1320         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1321         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1322
1323         (WTR::UIScriptController::platformUndoManager const): Deleted.
1324         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1325         (WTR::UIScriptController::platformContentView const):
1326         (WTR::UIScriptController::platformUndoManager const): Deleted.
1327
1328 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1329
1330         webkitpy: No option to only show unexpected failures in results.html for iPad
1331         https://bugs.webkit.org/show_bug.cgi?id=194554
1332         <rdar://problem/47922442>
1333
1334         Rubber-stamped by Aakash Jain.
1335
1336         Just because a TestExpecations file does not exist for a specific platform does not mean that
1337         TestExpecations are not being used, given that platforms inherit test expectations.
1338
1339         * Scripts/webkitpy/port/base.py:
1340         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1341         * Scripts/webkitpy/port/base_unittest.py:
1342         (PortTest.test_uses_test_expectations_file):
1343
1344 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1345
1346         Remove setDefersLoading infrastructure from WebKit2
1347         https://bugs.webkit.org/show_bug.cgi?id=194506
1348
1349         Reviewed by Brady Eidson.
1350
1351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1353         (WTR::TestRunner::setDefersLoading): Deleted.
1354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1355
1356 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1357
1358         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1359         https://bugs.webkit.org/show_bug.cgi?id=194522
1360         <rdar://problem/47789393>
1361
1362         Reviewed by Chris Dumez.
1363
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1366         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1368
1369 2019-02-12  Andy Estes  <aestes@apple.com>
1370
1371         [iOSMac] Enable Parental Controls Content Filtering
1372         https://bugs.webkit.org/show_bug.cgi?id=194521
1373         <rdar://39732376>
1374
1375         Reviewed by Tim Horton.
1376
1377         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1378
1379 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1380
1381         [LFC][IFC] Add intrinsic width support for float boxes.
1382         https://bugs.webkit.org/show_bug.cgi?id=194528
1383
1384         Reviewed by Antti Koivisto.
1385
1386         Expand tests coverage (2 new tests -> 800).
1387         (This is the correct test ordering --runs-singly --child-processes=1)
1388
1389         * LayoutReloaded/misc/LFC-passing-tests.txt:
1390
1391 2019-02-12  Rob Buis  <rbuis@igalia.com>
1392
1393         Implement serializing in MIME type parser
1394         https://bugs.webkit.org/show_bug.cgi?id=193909
1395
1396         Reviewed by Darin Adler.
1397
1398         Add various tests involving upper case, non-ASCII, control/null characters,
1399         various HTTP whitespace, single quotes and an unpaired surrogate.
1400
1401         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1402         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1403         (TestWebKitAPI::serializeIfValid):
1404         (TestWebKitAPI::TEST):
1405
1406 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1407
1408         [Cocoa] Ask platform for generic font family mappings
1409         https://bugs.webkit.org/show_bug.cgi?id=187723
1410         <rdar://problem/41892438>
1411
1412         Reviewed by Brent Fulgham.
1413
1414         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1415
1416         * DumpRenderTree/mac/DumpRenderTree.mm:
1417         (allowedFontFamilySet):
1418         * WebKitTestRunner/mac/TestControllerMac.mm:
1419         (WTR::allowedFontFamilySet):
1420
1421 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1422
1423         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1424         https://bugs.webkit.org/show_bug.cgi?id=193622
1425
1426         Reviewed by Michael Catanzaro.
1427
1428         This adds support for loading content extension rule sets from the JSON files which
1429         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1430         of WKTR for this could be removed, but that is left for a follow-up patch with
1431         cleanups.
1432
1433         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1436         avoid having the null-terminator copied into the result.
1437         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1438         part of the preparations to run a test.
1439         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1440         (WTR::contentExtensionStoreCallback): Added.
1441         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1442         used for content extensions test.
1443         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1444         extensions and compiling the JSON rule set for tests involving content extensions.
1445         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1446         testing and disables content extensions.
1447         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1448         resetContentExtensions().
1449         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1450         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1451         configureContentExtensionForTest(), and userContentController().
1452
1453 2019-02-11  Daniel Bates  <dabates@apple.com>
1454
1455         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1456         https://bugs.webkit.org/show_bug.cgi?id=191446
1457         <rdar://problem/45929460>
1458
1459         Reviewed by Tim Horton.
1460
1461         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1462
1463         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1464         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1465         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1466         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1467         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1468         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1469         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1470         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1471         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1472         (WTR::arrayLength):
1473         (WTR::parseModifierArray):
1474         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1475         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1476         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1477         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1478
1479 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1480
1481         Unreviewed, rolling out r241272 and r241276.
1482         https://bugs.webkit.org/show_bug.cgi?id=194514
1483
1484         Broke the Apple Internal build and the fix requires human
1485         intervention :( (Requested by dydz on #webkit).
1486
1487         Reverted changesets:
1488
1489         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1490         https://bugs.webkit.org/show_bug.cgi?id=191446
1491         https://trac.webkit.org/changeset/241272
1492
1493         "Fix internal iOS build after r241272"
1494         https://bugs.webkit.org/show_bug.cgi?id=191446
1495         https://trac.webkit.org/changeset/241276
1496
1497 2019-02-11  Truitt Savell  <tsavell@apple.com>
1498
1499         Unreviewed, rolling out r241269.
1500
1501         Caused 5 layout tests crashes on Mac WK1
1502
1503         Reverted changeset:
1504
1505         "DumpRenderTree should report unknown options"
1506         https://bugs.webkit.org/show_bug.cgi?id=191303
1507         https://trac.webkit.org/changeset/241269
1508
1509 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1510
1511         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1512         https://bugs.webkit.org/show_bug.cgi?id=194313
1513
1514         Reviewed by Tim Horton.
1515
1516         Add a helper to determine whether the web view is presenting modal UI.
1517
1518         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1519         (WTR::UIScriptController::isPresentingModally const):
1520         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1522         (WTR::UIScriptController::isPresentingModally const):
1523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1524         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1525         (WTR::UIScriptController::calendarType const): Deleted.
1526         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1527         (WTR::UIScriptController::isPresentingModally const):
1528         (WTR::UIScriptController::calendarType const):
1529         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1530         (WTR::UIScriptController::calendarType const):
1531
1532 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1533
1534         GCHeapInspector: Show the retained sizes in more places
1535         https://bugs.webkit.org/show_bug.cgi?id=194464
1536
1537         Reviewed by Simon Fraser.
1538
1539         * GCHeapInspector/gc-heap-inspector.html:
1540         * GCHeapInspector/script/interface.js:
1541         (HeapInspectorUtils.humanReadableSize):
1542         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1543         (HeapInspectorUtils.spanForNode.span.span):
1544         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1545         (HeapSnapshotInspector.prototype.buildRoots):
1546
1547 2019-02-11  Daniel Bates  <dabates@apple.com>
1548
1549         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1550         https://bugs.webkit.org/show_bug.cgi?id=191446
1551         <rdar://problem/45929460>
1552
1553         Reviewed by Tim Horton.
1554
1555         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1556
1557         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1558         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1559         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1560         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1561         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1562         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1563         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1564         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1565         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1566         (WTR::arrayLength):
1567         (WTR::parseModifierArray):
1568         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1569         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1570         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1571         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1572
1573 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1574
1575         DumpRenderTree should report unknown options
1576         https://bugs.webkit.org/show_bug.cgi?id=191303
1577
1578         Reviewed by Frédéric Wang.
1579
1580         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1581         to report unknown options.
1582         Added and assigned test options which are currently used in tests.
1583
1584         * DumpRenderTree/TestOptions.cpp:
1585         (TestOptions::TestOptions):
1586
1587 2019-02-11  Truitt Savell  <tsavell@apple.com>
1588
1589         Unreviewed, rolling out r241229.
1590
1591         Revision broke internal builds for watchOS.
1592
1593         Reverted changeset:
1594
1595         "[Cocoa] Ask platform for generic font family mappings"
1596         https://bugs.webkit.org/show_bug.cgi?id=187723
1597         https://trac.webkit.org/changeset/241229
1598
1599 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1600
1601         [WinCairo][MiniBrowser] Basic authentication always fails.
1602         https://bugs.webkit.org/show_bug.cgi?id=194496
1603
1604         Reviewed by Don Olmstead.
1605
1606         * MiniBrowser/win/DialogHelper.h:
1607         (Dialog::getText):
1608
1609 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1610
1611         [GStreamer] GstMappedBuffer testsuite build fails
1612         https://bugs.webkit.org/show_bug.cgi?id=194495
1613
1614         Reviewed by Carlos Garcia Campos.
1615
1616         Fix the build by explicitely adding the gstreamer1.0-audio include
1617         directories to the include path.
1618
1619         * TestWebKitAPI/PlatformGTK.cmake:
1620         * TestWebKitAPI/PlatformWPE.cmake:
1621
1622 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1623
1624         [GTK][WPE] Add enable-javascript-markup setting
1625         https://bugs.webkit.org/show_bug.cgi?id=193439
1626
1627         Reviewed by Michael Catanzaro.
1628
1629         Add test cases to check the new setting.
1630
1631         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1632         (testWebKitSettings):
1633         (testWebKitSettingsJavaScriptMarkup):
1634         (beforeAll):
1635
1636 2019-02-10  Darin Adler  <darin@apple.com>
1637
1638         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1639         https://bugs.webkit.org/show_bug.cgi?id=194485
1640
1641         Reviewed by Daniel Bates.
1642
1643         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1644
1645 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1646
1647         Add more tests for clampTo<>()
1648         https://bugs.webkit.org/show_bug.cgi?id=194462
1649
1650         Reviewed by Geoffrey Garen.
1651
1652         Darin suggested to test the very last floating point number
1653         at the boundaries when truncating to integer.
1654         I added test for max/min and max-1/min-1.
1655
1656         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1657         (TestWebKitAPI::TEST):
1658
1659 2019-02-09  Darin Adler  <darin@apple.com>
1660
1661         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1662         https://bugs.webkit.org/show_bug.cgi?id=194021
1663
1664         Reviewed by Geoffrey Garen.
1665
1666         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1667         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1668         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1669
1670 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1671
1672         [LFC][IFC] Add intrinsic width support for basic inline containers
1673         https://bugs.webkit.org/show_bug.cgi?id=194473
1674
1675         Reviewed by Antti Koivisto.
1676
1677         Expand tests coverage (11 new tests -> 798)
1678
1679         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1680
1681 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1682
1683         Fix MiniBrowser's entitlements
1684         https://bugs.webkit.org/show_bug.cgi?id=192431
1685
1686         Reviewed by Joseph Pecoraro.
1687
1688         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1689         files, making it impossible to load any extension.
1690
1691         * MiniBrowser/MiniBrowser.entitlements:
1692
1693 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1694
1695         [Cocoa] Ask platform for generic font family mappings
1696         https://bugs.webkit.org/show_bug.cgi?id=187723
1697         <rdar://problem/41892438>
1698
1699         Reviewed by Brent Fulgham.
1700
1701         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1702
1703         * DumpRenderTree/mac/DumpRenderTree.mm:
1704         (allowedFontFamilySet):
1705         * WebKitTestRunner/mac/TestControllerMac.mm:
1706         (WTR::allowedFontFamilySet):
1707
1708 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1709
1710         [GTK] Implement back/forward touchpad gesture
1711         https://bugs.webkit.org/show_bug.cgi?id=193919
1712
1713         Reviewed by Michael Catanzaro.
1714
1715         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1716         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1717
1718 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1719
1720         Add SPI to use networking daemon instead of XPC service
1721         https://bugs.webkit.org/show_bug.cgi?id=194427
1722
1723         Reviewed by Geoffrey Garen
1724
1725         * MiniBrowser/MiniBrowser.entitlements:
1726
1727 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-build] Ensure that every builder in config.json has short name
1730         https://bugs.webkit.org/show_bug.cgi?id=194461
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/ews-build/loadConfig.py:
1735         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1736
1737 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1738
1739         [ews-build] Add short name to config.json
1740         https://bugs.webkit.org/show_bug.cgi?id=194456
1741
1742         Reviewed by Lucas Forschler.
1743
1744         * BuildSlaveSupport/ews-build/config.json: Added short name.
1745         * BuildSlaveSupport/ews-build/loadConfig.py:
1746         (loadBuilderConfig): Set the short name as the builder description.
1747
1748 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1749
1750         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1751         https://bugs.webkit.org/show_bug.cgi?id=194418
1752
1753         Reviewed by Lucas Forschler.
1754
1755         Do not include errors trying when finding crashlogs at the end of
1756         a run-webkit-tests run since we don't process those errors.
1757
1758         * Scripts/webkitpy/port/darwin.py:
1759         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1760         * Scripts/webkitpy/port/ios_device.py:
1761         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1762         * Scripts/webkitpy/port/watch_device.py:
1763         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1764
1765 2019-02-08  Beth Dakin  <bdakin@apple.com>
1766
1767         Add afterScreenUpdates to WKSnapshotConfiguration
1768         https://bugs.webkit.org/show_bug.cgi?id=194362
1769         -and corresponding-
1770         <rdar://problem/40655528> Please add an "after screen updates" property to 
1771         WKSnapshotConfiguration (to solve blank snapshots)
1772
1773         Reviewed by Tim Horton.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1776         (TEST):
1777
1778 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1779
1780         clampTo(): do not convert the input to double when dealing with integers
1781         https://bugs.webkit.org/show_bug.cgi?id=194263
1782         <rdar://problem/47692312>
1783
1784         Reviewed by Darin Adler.
1785
1786         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1787         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1788         (TestWebKitAPI::testClampFloatingPointToInteger):
1789         (TestWebKitAPI::testClampSameSignIntegers):
1790         (TestWebKitAPI::testClampUnsignedToSigned):
1791         (TestWebKitAPI::testClampSignedToUnsigned):
1792
1793 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1794
1795         webkitpy: Respect --dedicated-simulators flag
1796         https://bugs.webkit.org/show_bug.cgi?id=194416
1797         <rdar://problem/47894722>
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * Scripts/webkitpy/port/device_port.py:
1802         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1803         available devices can be safely ignored.
1804
1805 2019-02-07  Keith Rollin  <krollin@apple.com>
1806
1807         Remove extra copy of 100x100-red.tga
1808         https://bugs.webkit.org/show_bug.cgi?id=194371
1809         <rdar://problem/47873465>
1810
1811         Reviewed by Said Abou-Hallawa.
1812
1813         In order to help it pass its tests, Bug 194190 added a second copy of
1814         the file 100x100-red.tga. However, it turns out that this additional
1815         file wasn't actually needed, and that that sole previous copy was
1816         sufficient. At the same time, this second copy -- which was copied to
1817         the same location in the build output as the first copy -- now caused
1818         XCBuild to complain because there were two production rules for the
1819         same output file. Address this by removing the newly-added extra copy.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1823
1824 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1825
1826         Deprecate WKBundlePageSetDefersLoading
1827         https://bugs.webkit.org/show_bug.cgi?id=191394
1828
1829         Reviewed by Dean Jackson.
1830
1831         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1832         (WTR::TestRunner::setDefersLoading):
1833
1834 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1835
1836         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1837         https://bugs.webkit.org/show_bug.cgi?id=194391
1838
1839         Reviewed by Antti Koivisto.
1840
1841         * LayoutReloaded/misc/LFC-passing-tests.txt:
1842
1843 2019-02-06  Keith Rollin  <krollin@apple.com>
1844
1845         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1846         https://bugs.webkit.org/show_bug.cgi?id=193975
1847         <rdar://problem/47643306>
1848
1849         Reviewed by Tim Horton.
1850
1851         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1852         the Info.plist file into the bundle. This step is not necessary as the
1853         implicit "bundle up all the build products into a framework" build
1854         phase does this already. Having the Copy Bundle Resources phase do
1855         this causes a conflict under XCBuild, which objects to two build
1856         phases producing the same file (Info.plist). Address this by removing
1857         Info.plist from the Copy Bundle Resources phase.
1858
1859         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1860
1861 2019-02-06  Keith Rollin  <krollin@apple.com>
1862
1863         Really enable the automatic checking and regenerations of .xcfilelists during builds
1864         https://bugs.webkit.org/show_bug.cgi?id=194357
1865         <rdar://problem/47861231>
1866
1867         Reviewed by Chris Dumez.
1868
1869         Bug 194124 was supposed to enable the automatic checking and
1870         regenerating of .xcfilelist files during the build. While related
1871         changes were included in that patch, the change to actually enable the
1872         operation somehow was omitted. This patch actually enables the
1873         operation. The check-xcfilelist.sh scripts now check
1874         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1875         from the checking.
1876
1877         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1878         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1879
1880 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1881
1882         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1883         <https://webkit.org/b/194286>
1884         <rdar://problem/47815558>
1885
1886         Reviewed by Alexey Proskuryakov.
1887
1888         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1889         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1890         WKRetainPtr<> to avoid leaking the WKDataRef.
1891
1892 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1893
1894         Unreviewed, fix a typo
1895
1896         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1897
1898 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1899
1900         [GTK][WPE] force libpsl build to use ICU in jhbuild
1901         https://bugs.webkit.org/show_bug.cgi?id=194288
1902
1903         Reviewed by Carlos Garcia Campos.
1904
1905         * gtk/jhbuild.modules:
1906         Require ICU for libpsl build in jhbuild, like done in WPE.
1907
1908 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1909
1910         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1911         https://bugs.webkit.org/show_bug.cgi?id=194209
1912
1913         Reviewed by Carlos Garcia Campos.
1914
1915         Enhance TestCookieManager to ensure this doesn't happen again.
1916
1917         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1918         (testCookieManagerPersistentStorage):
1919         (beforeAll):
1920
1921 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1922
1923         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1924         https://bugs.webkit.org/show_bug.cgi?id=194324
1925
1926         Reviewed by Andy Estes.
1927
1928         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1929         part of the name is already implicit, since this is in testing code in TestOptions.
1930
1931         * WebKitTestRunner/TestController.cpp:
1932         (WTR::TestController::generateContextConfiguration const):
1933         (WTR::updateTestOptionsFromTestHeader):
1934         * WebKitTestRunner/TestOptions.h:
1935         (WTR::TestOptions::hasSameInitializationOptions const):
1936
1937 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-build] Allow * as platform for builders and workers
1940         https://bugs.webkit.org/show_bug.cgi?id=188533
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * BuildSlaveSupport/ews-build/loadConfig.py:
1945         (checkWorkersAndBuildersForConsistency):
1946
1947 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews-build] Add few bots to config.json
1950         https://bugs.webkit.org/show_bug.cgi?id=194304
1951
1952         Reviewed by Lucas Forschler.
1953
1954         * BuildSlaveSupport/ews-build/config.json:
1955
1956 2019-02-05  Keith Rollin  <krollin@apple.com>
1957
1958         Enable the automatic checking and regenerations of .xcfilelists during builds
1959         https://bugs.webkit.org/show_bug.cgi?id=194124
1960         <rdar://problem/47721277>
1961
1962         Reviewed by Tim Horton.
1963
1964         Bug 193790 add a facility for checking -- during build time -- that
1965         any needed .xcfilelist files are up-to-date and for updating them if
1966         they are not. This facility was initially opt-in by setting
1967         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1968         the process seemed robust. Its now time to enable this facility and
1969         make it opt-out. If there is a need to disable this facility, set and
1970         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1971         running `make` or `build-webkit`, or before running Xcode from the
1972         command line.
1973
1974         Additionally, remove the step that generates a list of source files
1975         going into the UnifiedSources build step. It's only necessarily to
1976         specify Sources.txt and SourcesCocoa.txt as inputs.
1977
1978         * Scripts/generate-xcfilelists:
1979
1980 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1981
1982         [GTK][WPE] force libpsl build to use ICU in jhbuild
1983         https://bugs.webkit.org/show_bug.cgi?id=194288
1984
1985         Reviewed by Philippe Normand.
1986
1987         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1988         This can cause build failures if libidn is detected but libunistring is not available.
1989
1990         Make sure that ICU is used for runtime and builtin PSL data.
1991
1992         * gtk/jhbuild.modules:
1993         * wpe/jhbuild.modules:
1994
1995 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1996
1997         [ews-app] Modified timestamp should be updated on updating data
1998         https://bugs.webkit.org/show_bug.cgi?id=194295
1999
2000         Reviewed by Lucas Forschler.
2001
2002         * BuildSlaveSupport/ews-app/ews/models/build.py:
2003         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2004         * BuildSlaveSupport/ews-app/ews/models/step.py:
2005
2006 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2007
2008         Unreviewed, rolling out r240742.
2009
2010         Causes crashes on iOS simulator.
2011
2012         Reverted changeset:
2013
2014         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2015         not focused in a content-editable element"
2016         https://bugs.webkit.org/show_bug.cgi?id=192824
2017         https://trac.webkit.org/changeset/240742
2018
2019 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2020
2021         run-webkit-tests emits message "...running None" when running tests
2022         https://bugs.webkit.org/show_bug.cgi?id=194133
2023         <rdar://problem/47724738>
2024
2025         Reviewed by Lucas Forschler.
2026
2027         * Scripts/webkitpy/xcode/device_type.py:
2028         (DeviceType.__str__): Use both version mapping tables and use just the variant
2029         name if no version name is available.
2030         * Scripts/webkitpy/xcode/device_type_unittest.py:
2031         (DeviceTypeTest):
2032         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2033         an associated named.
2034
2035 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2036
2037         [WPE] require python3-setuptools for meson build in jhbuild
2038         https://bugs.webkit.org/show_bug.cgi?id=194287
2039
2040         Reviewed by Philippe Normand.
2041
2042         python3-setuptools is needed to build meson in jhbuild.
2043         It is already required by the GTK port.
2044
2045         * wpe/install-dependencies:
2046
2047 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2048
2049         [ews-app] Add method to save BuilderMapping to database
2050         https://bugs.webkit.org/show_bug.cgi?id=194264
2051
2052         Reviewed by Lucas Forschler.
2053
2054         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2055         (BuilderMapping.__str__):
2056         (BuilderMapping):
2057         (BuilderMapping.save_mapping):
2058         (BuilderMapping.update_mapping):
2059         (BuilderMapping.get_existing_mapping):
2060         (BuilderMapping.is_valid_mapping):
2061
2062 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [ews-app] Add timestamp fields for BuilderMappings
2065         https://bugs.webkit.org/show_bug.cgi?id=194266
2066
2067         Reviewed by Lucas Forschler.
2068
2069         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2070         (BuilderMapping):
2071
2072 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2073
2074         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2075         https://bugs.webkit.org/show_bug.cgi?id=174816
2076
2077         Reviewed by Michael Catanzaro.
2078
2079         Add tests for webkit_uri_for_display().
2080
2081         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2082         (testURIForDisplayUnaffected):
2083         (testURIForDisplayAffected):
2084         (beforeAll):
2085         (afterAll):
2086         * TestWebKitAPI/glib/CMakeLists.txt:
2087
2088 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2089
2090         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2091         https://bugs.webkit.org/show_bug.cgi?id=194158
2092         <rdar://problem/47737268>
2093
2094         Rubber-stamped by Aakash Jain.
2095
2096         * Scripts/webkitpy/port/device_port.py:
2097         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2098
2099 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2100
2101         [CG] Enable setAdditionalSupportedImageTypes for WK1
2102         https://bugs.webkit.org/show_bug.cgi?id=194190
2103
2104         Reviewed by Tim Horton.
2105
2106         Add a test similar to the one under WebKit Cocoa but make it create a
2107         WebView instead of a WKWebView.
2108
2109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2110         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2111         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2112         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2113         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2114         (TestWebKitAPI::runTest):
2115         (TestWebKitAPI::TEST):
2116
2117 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2118
2119         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2120         https://bugs.webkit.org/show_bug.cgi?id=194168
2121
2122         Reviewed by Simon Fraser.
2123
2124         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2128         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2129         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2130         (TEST):
2131         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2132         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2133
2134 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2135
2136         REGRESSION (r237269): webkit-patch what-broke is broken 
2137         https://bugs.webkit.org/show_bug.cgi?id=193025
2138
2139         Reviewed by Aakash Jain.
2140
2141         * Scripts/webkitpy/common/host.py:
2142         (Host.buildbot):
2143         (Host.bugzilla): Renamed to 'buildbot'.
2144
2145 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2146
2147         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2148         https://bugs.webkit.org/show_bug.cgi?id=194207
2149
2150         Reviewed by Tim Horton.
2151
2152         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2153         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2154         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2155         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2156         start and delete forwards to remove the original attachment.
2157
2158         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2159         (TestWebKitAPI::TEST):
2160
2161 2019-02-04  Youenn Fablet  <youenn@apple.com>
2162
2163         Capture state should be managed consistently when doing process swapping
2164         https://bugs.webkit.org/show_bug.cgi?id=194122
2165         <rdar://problem/47609293>
2166
2167         Reviewed by Eric Carlson.
2168
2169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2170         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2171         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2172         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2173         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2175         (WTR::TestRunner::isDoingMediaCapture const):
2176         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2177         * WebKitTestRunner/TestController.cpp:
2178         (WTR::TestController::isDoingMediaCapture const):
2179         * WebKitTestRunner/TestController.h:
2180         * WebKitTestRunner/TestInvocation.cpp:
2181         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2182         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2183         (WTR::TestController::isDoingMediaCapture const):
2184
2185 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2186
2187         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2188         https://bugs.webkit.org/show_bug.cgi?id=194142
2189
2190         Reviewed by Ross Kirsling.
2191
2192         There three 'separator' variables in TestController.cpp. Renamed
2193         it 'pathSeparator', and unified them.
2194
2195         * WebKitTestRunner/TestController.cpp:
2196         (WTR::TestController::generateContextConfiguration const):
2197         (WTR::createTestURL):
2198         (WTR::TestController::platformAdjustContext):
2199
2200 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2201
2202         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2203         https://bugs.webkit.org/show_bug.cgi?id=194198
2204
2205         Reviewed by Antti Koivisto.
2206
2207         No need to set the banner heights on navigation now, since Page stores them.
2208
2209         * MiniBrowser/mac/WK2BrowserWindowController.m:
2210         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2211
2212 2019-02-03  John Wilander  <wilander@apple.com>
2213
2214         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2215         https://bugs.webkit.org/show_bug.cgi?id=194104
2216         <rdar://problem/47649991>
2217
2218         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2219
2220         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2221         (TestWebKitAPI::TEST):
2222             Changed numeric types from unsigned short to uint32_t.
2223
2224 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2225
2226         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2227         <https://webkit.org/b/194178>
2228         <rdar://problem/47753473>
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2233         (WTR::uninstallFakeHelvetica): Pass nullptr into
2234         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2235
2236 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2237
2238         [LFC] Initialize ICB's style with fixed width/height.
2239         https://bugs.webkit.org/show_bug.cgi?id=194188
2240
2241         Reviewed by Antti Koivisto.
2242
2243         * LayoutReloaded/misc/LFC-passing-tests.txt:
2244
2245 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2246
2247         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2248         https://bugs.webkit.org/show_bug.cgi?id=194185
2249
2250         Reviewed by Antti Koivisto.
2251
2252         * LayoutReloaded/misc/LFC-passing-tests.txt:
2253
2254 2018-12-16  Darin Adler  <darin@apple.com>
2255
2256         Convert additional String::format clients to alternative approaches
2257         https://bugs.webkit.org/show_bug.cgi?id=192746
2258
2259         Reviewed by Alexey Proskuryakov.
2260
2261         * WebKitTestRunner/TestController.cpp:
2262         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2263         as an intermediate in code that ultimately constructs a WTF::String.
2264         (WTR::userMediaOriginHash): Use makeString.
2265         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2266         (WTR::TestController::didPerformClientRedirect): Ditto.
2267         (WTR::TestController::didPerformServerRedirect): Ditto.
2268         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2269
2270 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-build] Add unit test to verify builder keys
2273         https://bugs.webkit.org/show_bug.cgi?id=194152
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2278         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2279
2280 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2281
2282         [LFC] Expand tests coverage (12 new tests -> 787)
2283
2284         Unreviewed test gardening.
2285
2286         * LayoutReloaded/misc/LFC-passing-tests.txt:
2287
2288 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2289
2290         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2291         https://bugs.webkit.org/show_bug.cgi?id=194163
2292
2293         Reviewed by Simon Fraser.
2294
2295         775
2296
2297         * LayoutReloaded/misc/LFC-passing-tests.txt:
2298
2299 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2300
2301         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2302         https://bugs.webkit.org/show_bug.cgi?id=194140
2303         <rdar://problem/47728098>
2304
2305         Reviewed by Tim Horton.
2306
2307         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2309         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2310
2311         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2312         test to induce an IPC deadlock when presenting a modal alert during touch start.
2313
2314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::runJavaScriptAlert):
2317
2318         Add a client callback function for running JavaScript alerts.
2319
2320         (WTR::TestController::createOtherPage):
2321         (WTR::TestController::generateContextConfiguration const):
2322
2323         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2324         the fix in this patch.
2325
2326         (WTR::TestController::createWebViewWithOptions):
2327
2328         Plumb TestOptions to generateContextConfiguration.
2329
2330         (WTR::TestController::resetPreferencesToConsistentValues):
2331         (WTR::TestController::resetStateToConsistentValues):
2332         (WTR::updateTestOptionsFromTestHeader):
2333         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2334         (WTR::TestController::handleJavaScriptAlert):
2335         * WebKitTestRunner/TestController.h:
2336         * WebKitTestRunner/TestInvocation.cpp:
2337         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2338         * WebKitTestRunner/TestOptions.h:
2339         (WTR::TestOptions::hasSameInitializationOptions const):
2340
2341 2019-02-01  Chris Dumez  <cdumez@apple.com>
2342
2343         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2344         https://bugs.webkit.org/show_bug.cgi?id=193740
2345         <rdar://problem/47527267>
2346
2347         Reviewed by Alex Christensen.
2348
2349         Add API test coverage.
2350
2351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2352
2353 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2354
2355         [ews-app] Add display name field to BuilderMapping model
2356         https://bugs.webkit.org/show_bug.cgi?id=194153
2357
2358         Reviewed by Lucas Forschler.
2359
2360         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2361         (BuilderMapping):
2362
2363 2019-02-01  Youenn Fablet  <youenn@apple.com>
2364
2365         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2366         https://bugs.webkit.org/show_bug.cgi?id=194155
2367
2368         Reviewed by Eric Carlson.
2369
2370         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2371         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2372         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2373
2374 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2375
2376         [LFC] Adjust replaced element's intrinsic ratio
2377         https://bugs.webkit.org/show_bug.cgi?id=194154
2378
2379         Reviewed by Antti Koivisto.
2380
2381         761
2382
2383         * LayoutReloaded/misc/LFC-passing-tests.txt:
2384
2385 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2386
2387         [WPE] Show test results in minibrowser
2388         https://bugs.webkit.org/show_bug.cgi?id=194150
2389
2390         Reviewed by Žan Doberšek.
2391
2392         * Scripts/webkitpy/port/wpe.py:
2393         (WPEPort.show_results_html_file):
2394
2395 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2396
2397         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2398         https://bugs.webkit.org/show_bug.cgi?id=194151
2399
2400         Reviewed by Žan Doberšek.
2401
2402         ALT + <- go back
2403         ALT + -> go forward
2404
2405         * MiniBrowser/wpe/main.cpp:
2406         (main):
2407
2408 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2409
2410         [LFC] Set intrinsic size on Layout::Replaced
2411         https://bugs.webkit.org/show_bug.cgi?id=194139
2412
2413         Reviewed by Antti Koivisto.
2414
2415         744
2416
2417         * LayoutReloaded/misc/LFC-passing-tests.txt:
2418
2419 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2420
2421         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2422         https://bugs.webkit.org/show_bug.cgi?id=194146
2423
2424         Reviewed by Xabier Rodriguez-Calvar.
2425
2426         It allows to open relative paths.
2427
2428         * MiniBrowser/wpe/main.cpp:
2429         (main):
2430
2431 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2432
2433         Update flakiness dashboard configuration after recent queue changes
2434         https://bugs.webkit.org/show_bug.cgi?id=194127
2435
2436         Rubber-stamped by Aakash Jain.
2437
2438         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2439
2440         * TestResultServer/static-dashboards/builders.jsonp:
2441
2442 2019-01-31  Youenn Fablet  <youenn@apple.com>
2443
2444         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2445         https://bugs.webkit.org/show_bug.cgi?id=194106
2446         <rdar://problem/47676333>
2447
2448         Reviewed by Ryosuke Niwa.
2449
2450         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2451         (TestWebKitAPI::didFinishNavigation):
2452         (TestWebKitAPI::TEST):
2453         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2454
2455 2019-01-31  Chris Dumez  <cdumez@apple.com>
2456
2457         Page zoom level is lost after a process swap or a crash
2458         https://bugs.webkit.org/show_bug.cgi?id=194105
2459         <rdar://problem/47610781>
2460
2461         Reviewed by Alex Christensen.
2462
2463         Add API test coverage.
2464
2465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2466         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2467
2468 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2469
2470         Revert r238819 which is unneeded and caused a performance regression.
2471         https://bugs.webkit.org/show_bug.cgi?id=192272
2472         <rdar://problem/46664625>
2473
2474         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2475         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2476         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2477
2478 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2479
2480         Formalize WebKitAdditions mechanism of LoadOptimizer
2481         https://bugs.webkit.org/show_bug.cgi?id=193886
2482         <rdar://problem/47696809>
2483
2484         Reviewed by Brent Fulgham.
2485
2486         * MiniBrowser/MiniBrowser.entitlements:
2487         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2488
2489 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2490
2491         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2492         https://bugs.webkit.org/show_bug.cgi?id=194090
2493
2494         Reviewed by Antti Koivisto.
2495
2496         * LayoutReloaded/misc/LFC-passing-tests.txt:
2497
2498 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2499
2500         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2501         https://bugs.webkit.org/show_bug.cgi?id=194074
2502
2503         Reviewed by Antti Koivisto.
2504
2505         * LayoutReloaded/misc/LFC-passing-tests.txt:
2506
2507 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2508
2509         [LFC][BFC] Add support for block level replaced box.
2510         https://bugs.webkit.org/show_bug.cgi?id=194071
2511
2512         Reviewed by Antti Koivisto.
2513
2514         * LayoutReloaded/misc/LFC-passing-tests.txt:
2515
2516 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2517
2518         Fix WebKitTestRunner's testPath with Windows full paths
2519         https://bugs.webkit.org/show_bug.cgi?id=194012
2520
2521         Reviewed by Alex Christensen.
2522
2523         updateTestOptionsFromTestHeader failed to open test files because
2524         testPath returned wrong file paths. It returned a path "/C:/..."
2525         if a URL "file:///C:/..." was given.
2526
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2529
2530 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2531
2532         [WPE] Bump font related dependencies to match the GTK+ port
2533         https://bugs.webkit.org/show_bug.cgi?id=194017
2534
2535         Reviewed by Žan Doberšek.
2536
2537         * wpe/jhbuild.modules:
2538         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2539         * wpe/patches/icudata-stdlibs.patch: Added.
2540
2541 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2542
2543         Enable swipe tests on iOS
2544         https://bugs.webkit.org/show_bug.cgi?id=194076
2545
2546         Reviewed by Geoffrey Garen.
2547
2548         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2549         it causes a debug assertion failure in runUIScript.
2550
2551         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2552         (WTR::UIScriptController::beginBackSwipe):
2553         (WTR::UIScriptController::completeBackSwipe):
2554
2555 2019-01-30  Keith Rollin  <krollin@apple.com>
2556
2557         Use correct printf format specifier
2558         https://bugs.webkit.org/show_bug.cgi?id=194062
2559         <rdar://problem/47686167>
2560
2561         Reviewed by Alexey Proskuryakov.
2562
2563         LayoutTestSpellChecker.mm is trying to format a variable of type
2564         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2565         actually an unsigned long long. Fix this by formatting with %llu.
2566
2567         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2568         (-[LayoutTestTextCheckingResult description]):
2569
2570 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2573         https://bugs.webkit.org/show_bug.cgi?id=193979
2574
2575         Reviewed by Wenson Hsieh.
2576
2577         Fix the test for iOS. Make the test work with iOS UA string.
2578
2579         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2580
2581 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2582
2583         Replace High Sierra LLINT CLoop bot due to hardware failure
2584         https://bugs.webkit.org/show_bug.cgi?id=194066
2585
2586         Reviewed by Aakash Jain.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/config.json:
2589
2590 2019-01-30  Keith Rollin  <krollin@apple.com>
2591
2592         [NSDragItem init] is unavailable
2593         https://bugs.webkit.org/show_bug.cgi?id=194059
2594         <rdar://problem/47685715>
2595
2596         Reviewed by Wenson Hsieh.
2597
2598         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2599         DumpRenderTree and TestWebKitAPI, which both try to create an
2600         NSDragItem in a manner that invokes this method. Address this by using
2601         -initWithPasteboardWriter instead.
2602
2603         Note that the parameter passed to initWithPasteboardWriter is likely
2604         incorrect. In both cases, the object passed does not conform to
2605         NSPasteboardWriting. However, with this fix, we're no worse off than
2606         before, and can now perform builds with newer compilers and SDKs until
2607         a real fix can be crafted. That work is tracked in
2608         https://bugs.webkit.org/show_bug.cgi?id=194060
2609
2610         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2611         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2612         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2613         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2614
2615 2019-01-30  Daniel Bates  <dabates@apple.com>
2616
2617         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2618         https://bugs.webkit.org/show_bug.cgi?id=192824
2619         <rdar://problem/47100332>
2620
2621         Reviewed by Wenson Hsieh.
2622
2623         Fix a bug where the wrong usage code was used for F13 thru F24.
2624
2625         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2626         (keyCodeForDOMFunctionKey):
2627
2628 2019-01-30  Chris Dumez  <cdumez@apple.com>
2629
2630         Regression(PSON) Load hang can occur on history navigation
2631         https://bugs.webkit.org/show_bug.cgi?id=194030
2632         <rdar://problem/47656939>
2633
2634         Reviewed by Antti Koivisto.
2635
2636         Add API test coverage.
2637
2638         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2639
2640 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2641
2642         [LFC] Expand tests coverage.
2643
2644         Unreviewed test gardening.
2645
2646         * LayoutReloaded/misc/LFC-passing-tests.txt:
2647
2648 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2649
2650         [Flatpak] Add openjpeg support
2651         https://bugs.webkit.org/show_bug.cgi?id=194019
2652
2653         Reviewed by Michael Catanzaro.
2654
2655         * flatpak/org.webkit.CommonModules.yaml:
2656
2657 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2658
2659         Unreviewed, rolling out r240708.
2660         https://bugs.webkit.org/show_bug.cgi?id=194022
2661
2662         It broke WPE build (Requested by KaL on #webkit).
2663
2664         Reverted changeset:
2665
2666         "[WPE] Bump font related dependencies to match the GTK+ port"
2667         https://bugs.webkit.org/show_bug.cgi?id=194017
2668         https://trac.webkit.org/changeset/240708
2669
2670 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2671
2672         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2673         https://bugs.webkit.org/show_bug.cgi?id=194001
2674
2675         Reviewed by Antti Koivisto.
2676
2677         * LayoutReloaded/misc/LFC-passing-tests.txt:
2678
2679 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2680
2681         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2682         https://bugs.webkit.org/show_bug.cgi?id=194020
2683
2684         Reviewed by Antti Koivisto.
2685
2686         * LayoutReloaded/misc/LFC-passing-tests.txt:
2687
2688 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2689
2690         AX: Support color well on iOS
2691         https://bugs.webkit.org/show_bug.cgi?id=194010
2692
2693         Reviewed by Joanmarie Diggs.
2694
2695         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2696         (WTR::AccessibilityUIElement::stringAttributeValue):
2697
2698 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2699
2700         [WPE] Bump font related dependencies to match the GTK+ port
2701         https://bugs.webkit.org/show_bug.cgi?id=194017
2702
2703         Reviewed by Žan Doberšek.
2704
2705         * wpe/jhbuild.modules:
2706         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2707         * wpe/patches/icudata-stdlibs.patch: Added.
2708
2709 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2710
2711         [Mac] Update window scale API usage
2712         https://bugs.webkit.org/show_bug.cgi?id=193991
2713         rdar://problem/47614795
2714
2715         Reviewed by Tim Horton.
2716
2717         * DumpRenderTree/mac/DumpRenderTree.mm:
2718         (changeWindowScaleIfNeeded):
2719         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2720         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2721         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2722
2723 2019-01-29  Chris Dumez  <cdumez@apple.com>
2724
2725         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2726         https://bugs.webkit.org/show_bug.cgi?id=193977
2727         <rdar://problem/47643716>
2728
2729         Reviewed by Geoff Garen.
2730
2731         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2732         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2733         to the previous provisional committing *before* we make the last load. 
2734
2735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2736
2737 2019-01-29  Youenn Fablet  <youenn@apple.com>
2738
2739         Adopt new SPI to evaluate server certificate trust
2740         https://bugs.webkit.org/show_bug.cgi?id=193355
2741
2742         Reviewed by Alex Christensen.
2743
2744         Add infrastructure to handle HTTPS server trust evaluation testing.
2745
2746         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2747         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2748         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2749         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2750         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2752         * WebKitTestRunner/TestController.cpp:
2753         (WTR::TestController::resetPreferencesToConsistentValues):
2754         (WTR::TestController::didReceiveAuthenticationChallenge):
2755         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2756         * WebKitTestRunner/TestController.h:
2757         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2758         * WebKitTestRunner/TestInvocation.cpp:
2759         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2760         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2761         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2762
2763 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2764
2765         [ews-build] Add build step to print bot Configuration
2766         https://bugs.webkit.org/show_bug.cgi?id=193887
2767
2768         Reviewed by Lucas Forschler.
2769
2770         * BuildSlaveSupport/ews-build/steps.py:
2771         (PrintConfiguration): Build step to print configuration.
2772         * BuildSlaveSupport/ews-build/factories.py:
2773
2774 2019-01-29  Chris Dumez  <cdumez@apple.com>
2775
2776         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2777         https://bugs.webkit.org/show_bug.cgi?id=193967
2778         <rdar://problem/47635348>
2779
2780         Reviewed by Alex Christensen.
2781
2782         Add API test coverage.
2783
2784         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2785         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2786
2787 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2788
2789         [ews-app] Handle incoming results data
2790         https://bugs.webkit.org/show_bug.cgi?id=193973
2791
2792         Reviewed by Lucas Forschler.
2793
2794         * BuildSlaveSupport/ews-app/ews/views/results.py:
2795
2796 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2797
2798         [ews-app] Make the results url generic
2799         https://bugs.webkit.org/show_bug.cgi?id=193928
2800
2801         Reviewed by Lucas Forschler.
2802
2803         * BuildSlaveSupport/ews-app/ews/urls.py:
2804
2805 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-build] Configure buildbot to send events to ews-app
2808         https://bugs.webkit.org/show_bug.cgi?id=193968
2809
2810         Reviewed by Lucas Forschler.
2811
2812         * BuildSlaveSupport/ews-build/events.py: Added.
2813         * BuildSlaveSupport/ews-build/master.cfg:
2814
2815 2019-01-29  Keith Rollin  <krollin@apple.com>
2816
2817         Add .xcfilelists to Run Script build phases
2818         https://bugs.webkit.org/show_bug.cgi?id=193792
2819         <rdar://problem/47201785>
2820
2821         Reviewed by Alex Christensen.
2822
2823         As part of supporting XCBuild, update the necessary Run Script build
2824         phases in their Xcode projects to refer to their associated
2825         .xcfilelist files.
2826
2827         Note that the addition of these files bumps the Xcode project version
2828         number to something that's Xcode 10 compatible. This change means that
2829         older versions of the Xcode IDE can't read these projects. Nor can it
2830         fully load workspaces that refer to these projects (the updated
2831         projects are shown as non-expandable placeholders). `xcodebuild` can
2832         still build these projects; it's just that the IDE can't open them.
2833
2834         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2835         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2836
2837 2019-01-29  John Wilander  <wilander@apple.com>
2838
2839         Add data abstraction and validation for Ad Click Attribution
2840         https://bugs.webkit.org/show_bug.cgi?id=193916
2841         <rdar://problem/47603481>
2842
2843         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2844
2845         Ad click attribution has two steps. First, the storage of an ad
2846         campaign ID for a click that takes the user to a destination
2847         site. Second, a conversion on the destination site that can be
2848         attributed to the ad click.
2849
2850         This patch adds a class that represents a request for ad click
2851         attribution. Validation makes sure that the bits of entropy
2852         reported through this mechanism is limited.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2856         (TestWebKitAPI::TEST):
2857
2858 2019-01-29  Chris Dumez  <cdumez@apple.com>
2859
2860         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2861         https://bugs.webkit.org/show_bug.cgi?id=193932
2862         <rdar://problem/47598947>
2863
2864         Reviewed by Brady Eidson.
2865
2866         Add API test coverage.
2867
2868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2869
2870 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2871
2872         Adding new passing LFC tests.
2873
2874         Unreviewed test gardening.
2875
2876         * LayoutReloaded/misc/LFC-passing-tests.txt:
2877
2878 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2879
2880         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2881         https://bugs.webkit.org/show_bug.cgi?id=193964
2882
2883         Reviewed by Antti Koivisto.
2884
2885         * LayoutReloaded/misc/LFC-passing-tests.txt:
2886
2887 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2888
2889         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2890         https://bugs.webkit.org/show_bug.cgi?id=193954
2891
2892         Reviewed by Antti Koivisto.
2893
2894         * LayoutReloaded/misc/LFC-passing-tests.txt:
2895
2896 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2897
2898         WebDriver: add support for running subtests
2899         https://bugs.webkit.org/show_bug.cgi?id=193904
2900
2901         Reviewed by Michael Catanzaro.
2902
2903         pytest already supports it by passing test.py::subtest, so we can do the same.
2904
2905         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2906         (get_item_name): Made this global.
2907         (CollectRecorder.__init__): Receive the parameter to ignore.
2908         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2909         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2910         (collect): Add parameter to ignore.
2911         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2912         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2913         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2914         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2915         (WebDriverTestRunnerSelenium.run): Ditto.
2916         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2917         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2918         (WebDriverTestRunnerW3C.run): Ditto.
2919
2920 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2921
2922         User agent string override for navigator.userAgent should be site specific quirks
2923         https://bugs.webkit.org/show_bug.cgi?id=193950
2924
2925         Reviewed by Brent Fulgham.
2926
2927         Updated per the _WKWebsitePolicies rename.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2930         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2931
2932 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2933
2934         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2935         https://bugs.webkit.org/show_bug.cgi?id=193941
2936
2937         Reviewed by Alex Christensen.
2938
2939         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2940         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2941         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2942         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2943         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2944         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2945         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2946         * TestWebKitAPI/Tests/WTF/Time.cpp:
2947         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2948         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2949         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2950         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2951
2952 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2953
2954         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2955
2956         * Scripts/webkitpy/common/config/contributors.json:
2957
2958 2019-01-28  Andy Estes  <aestes@apple.com>
2959
2960         [watchOS] Enable Parental Controls content filtering
2961         https://bugs.webkit.org/show_bug.cgi?id=193939
2962         <rdar://problem/46641912>
2963
2964         Reviewed by Ryosuke Niwa.
2965
2966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2967
2968 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2969
2970         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2971         <https://webkit.org/b/193884>
2972
2973         Reviewed by Jiewen Tan.
2974
2975         * Scripts/webkitpy/style/checkers/cpp.py:
2976         (check_language): Add LocalAuthentication to
2977         `frameworks_with_soft_links`.
2978
2979 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2980
2981         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2982         https://bugs.webkit.org/show_bug.cgi?id=193891
2983
2984         Reviewed by Ross Kirsling.
2985
2986         There were three problems in window sizes of WebView and the host window.
2987         1. The sizes of pixel image output were incorrect.
2988         2. The host window is going to appear after window.resize was invoked.
2989         3. window.resize resized only the host window, not WebView.
2990
2991         This change solves them with a following approach.
2992         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2993         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2994            as well as DumpRenderTree in order to match the client area and the window area.
2995         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2996         d. PlatformWebView::setWindowFrame changes both window sizes.
2997         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2998
2999         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3000         (WTR::PlatformWebView::PlatformWebView): Create the host window
3001         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3002         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3003         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3004
3005 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-app] Add method to save Step data to database
3008         https://bugs.webkit.org/show_bug.cgi?id=193890
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-app/ews/models/step.py:
3013         (Step.save_step): Method to save step data.
3014         (Step.update_step): Method to update step data.
3015         (Step.get_existing_step): Method to fetch existing step from database.
3016         (Step.is_valid_result): Method to validate valid step result.
3017
3018 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3019
3020         [ews-app] Add method to save Build data to database
3021         https://bugs.webkit.org/show_bug.cgi?id=193735
3022
3023         Reviewed by Lucas Forschler.
3024
3025         * BuildSlaveSupport/ews-app/ews/models/build.py:
3026         (Build.save_build): Method to save build information to database.
3027         (Build.get_existing_build): Method to fetch existing build from database.
3028         (Build.is_valid_result): Method to validate build result.
3029         * BuildSlaveSupport/ews-app/ews/common/util.py:
3030         (is_valid_int_id): Method to validate valid id.
3031
3032 2019-01-28  Chris Dumez  <cdumez@apple.com>
3033
3034         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3035         https://bugs.webkit.org/show_bug.cgi?id=193915
3036         <rdar://problem/47560907>
3037
3038         Reviewed by Alex Christensen.
3039
3040         Add API test coverage.
3041
3042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3043
3044 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3045
3046         [ews-app] Rename id variables
3047         https://bugs.webkit.org/show_bug.cgi?id=193883
3048
3049         Reviewed by Lucas Forschler.
3050
3051         * BuildSlaveSupport/ews-app/ews/models/build.py:
3052         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3053         * BuildSlaveSupport/ews-app/ews/models/step.py:
3054         * BuildSlaveSupport/ews-app/ews/urls.py:
3055         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3056         * BuildSlaveSupport/ews-app/ews/views/results.py:
3057         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3058
3059 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-app] Allow certain fields to be empty
3062         https://bugs.webkit.org/show_bug.cgi?id=193892
3063
3064         Reviewed by Lucas Forschler.
3065
3066         * BuildSlaveSupport/ews-app/ews/models/build.py:
3067         * BuildSlaveSupport/ews-app/ews/models/step.py:
3068
3069 2019-01-28  Rob Buis  <rbuis@igalia.com>
3070
3071         Update MIME type parser
3072         https://bugs.webkit.org/show_bug.cgi?id=180526
3073
3074         Reviewed by Frédéric Wang.
3075
3076         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3077         (TestWebKitAPI::TEST):
3078
3079 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3080
3081         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3082         https://bugs.webkit.org/show_bug.cgi?id=193896
3083
3084         Reviewed by Antti Koivisto.
3085
3086         * LayoutReloaded/misc/LFC-passing-tests.txt:
3087
3088 2018-12-15  Darin Adler  <darin@apple.com>
3089
3090         Replace many uses of String::format with more type-safe alternatives
3091         https://bugs.webkit.org/show_bug.cgi?id=192742
3092
3093         Reviewed by Mark Lam.
3094
3095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3096         (WTR::cacheTestRunnerCallback): Use makeString.
3097         * WebKitTestRunner/TestController.cpp:
3098         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3099         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3100
3101 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3102
3103         Use a load optimizer for some sites
3104         https://bugs.webkit.org/show_bug.cgi?id=193881
3105         <rdar://problem/46325455>
3106
3107         Reviewed by Brent Fulgham.
3108
3109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3110         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3111
3112 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3113
3114         AX: Introduce a static accessibility tree
3115         https://bugs.webkit.org/show_bug.cgi?id=193348
3116         <rdar://problem/47203295>
3117
3118         Reviewed by Ryosuke Niwa.
3119
3120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3121
3122 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3123
3124         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3125         https://bugs.webkit.org/show_bug.cgi?id=193867
3126
3127         Reviewed by Antti Koivisto.
3128
3129         * LayoutReloaded/misc/LFC-passing-tests.txt:
3130
3131 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3132
3133         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3134         https://bugs.webkit.org/show_bug.cgi?id=193865
3135
3136         Reviewed by Antti Koivisto.
3137
3138         * LayoutReloaded/misc/LFC-passing-tests.txt:
3139
3140 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3141
3142         Need a mechanism to override navigator.userAgent
3143         https://bugs.webkit.org/show_bug.cgi?id=193762
3144         <rdar://problem/47504939>
3145
3146         Reviewed by Brent Fulgham.
3147
3148         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3151         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3152         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3153
3154 2019-01-25  Dean Jackson  <dino@apple.com>
3155
3156         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3157         https://bugs.webkit.org/show_bug.cgi?id=193831
3158         <rdar://problem/47399263>
3159
3160         Reviewed by Chris Dumez.
3161
3162         Two new tests that exercise cross-origin and same-origin System
3163         Previews.
3164
3165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3166
3167 2019-01-25  Keith Rollin  <krollin@apple.com>
3168
3169         Update Xcode projects with "Check .xcfilelists" build phase
3170         https://bugs.webkit.org/show_bug.cgi?id=193790
3171         <rdar://problem/47201374>
3172
3173         Reviewed by Alex Christensen.
3174
3175         Support for XCBuild includes specifying inputs and outputs to various
3176         Run Script build phases. These inputs and outputs are specified as
3177         .xcfilelist files. Once created, these .xcfilelist files need to be
3178         kept up-to-date. In order to check that they are up-to-date or not,
3179         add an Xcode build step that invokes an external script that performs
3180         the checking. If the .xcfilelists are found to be out-of-date, update
3181         them, halt the build, and instruct the developer to restart the build
3182         with up-to-date files.
3183
3184         At this time, the checking and regenerating is performed only if the
3185         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3186         who want to use this facility can set this variable and test out the
3187         checking/regenerating. Once it seems like there are no egregious
3188         issues that upset a developer's workflow, we'll unconditionally enable
3189         this facility.
3190
3191         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3192         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3193         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3194         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3195
3196 2019-01-25  Keith Rollin  <krollin@apple.com>
3197
3198         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3199         https://bugs.webkit.org/show_bug.cgi?id=193781
3200         <rdar://problem/47201153>
3201
3202         Reviewed by Alex Christensen.
3203
3204         Part of generating the .xcfilelists used as part of adopting XCBuild
3205         includes running `make DerivedSources.make` from a standalone script.
3206         It’s important for this invocation to have the same environment as
3207         when the actual build invokes `make DerivedSources.make`. If the
3208         environments are different, then the two invocations will provide
3209         different results. In order to get the same environment in the
3210         standalone script, have the script launch xcodebuild targeting the
3211         "Apply Configuration to XCFileLists" build target, which will then
3212         re-invoke our standalone script. The script is now running again, this
3213         time in an environment with all workspace, project, target, xcconfig
3214         and other environment variables established.
3215
3216         The "Apply Configuration to XCFileLists" build target accomplishes
3217         this task via a small embedded shell script that consists only of:
3218
3219             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3220
3221         The process that invokes "Apply Configuration to XCFileLists" first
3222         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3223         evaluated and exports it into the shell environment. When xcodebuild
3224         is invoked, it inherits the value of this variable and can `eval` the
3225         contents of that variable. Our external standalone script can then set
3226         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3227         of command-line parameters needed to restart itself in the appropriate
3228         state.
3229
3230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3231         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3232
3233 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3234
3235         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3236         https://bugs.webkit.org/show_bug.cgi?id=193802
3237         <rdar://problem/46010580>
3238
3239         Reviewed by Andy Estes.
3240
3241         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3242         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3243         (TEST):
3244
3245 2019-01-25  Daniel Bates  <dabates@apple.com>
3246
3247         [iOS] uiController.keyDown() does not translate Control modified key
3248         https://bugs.webkit.org/show_bug.cgi?id=192898
3249
3250         Reviewed by Wenson Hsieh.
3251
3252         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3253         key translation, as applicable. Among other cases, key translation occurs when performing
3254         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3255         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3256         human pressing down and releasing key(s) using a hardware keyboard.
3257
3258         * WebKitTestRunner/ios/HIDEventGenerator.h:
3259         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3260         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3261
3262         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3263         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3264         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3265         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3266         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3267         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3268         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3269         (-[HIDEventGenerator longPress:completionBlock:]):
3270         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3271         Update code for above renaming.
3272
3273         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3274         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3275
3276         (-[HIDEventGenerator keyDown:]): Added.
3277         (-[HIDEventGenerator keyUp:]): Added.
3278         (-[HIDEventGenerator keyPress:completionBlock:]):
3279         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3280         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3282         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3283         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3284         (WTR::parseModifier): Deleted.
3285
3286 2019-01-25  Keith Rollin  <krollin@apple.com>
3287
3288         Complete the implementation of generate-xcfilelists
3289         https://bugs.webkit.org/show_bug.cgi?id=193782
3290
3291         Reviewed by Alex Christensen.
3292
3293         A preliminary version of generate-xcfilelists was added in r238008.
3294         This patch updates that script in order to:
3295
3296         - Support checking of .xcfilelists
3297         - Perform better execution of `make DerivedSources.make` by
3298           relaunching generate-xcfilelists under xcodebuild
3299         - Support incremental generation and checking of .xcfilelists
3300         - Support supplementary .xcfilelists files from WebKitAdditions
3301         - Support being wrapped by parallel version of generate-xcfilelists in
3302           Internal that adds support for (re)generating WebKit projects in
3303           that repo.
3304         - Support builds that have been performed in WebKitBuild as well as
3305           ~/Library/Developer/code/DerivedData
3306         - Increase robustness and debugging facilities.
3307
3308         * Scripts/generate-xcfilelists:
3309
3310 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3311
3312         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3313         https://bugs.webkit.org/show_bug.cgi?id=193297
3314         <rdar://problem/47158841>
3315
3316         Unreviewed test case fix.
3317
3318         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3319         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3320
3321         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3322         (TEST):
3323
3324 2019-01-25  Keith Rollin  <krollin@apple.com>
3325
3326         Update existing .xcfilelists
3327         https://bugs.webkit.org/show_bug.cgi?id=193791
3328         <rdar://problem/47201706>
3329
3330         Reviewed by Alex Christensen.
3331
3332         Many .xcfilelist files were added in r238824 in order to support
3333         XCBuild. Update these with recent changes to the set of build files
3334         and with the current generate-xcfilelist script.
3335
3336         * DumpRenderTree/DerivedSources-input.xcfilelist:
3337         * DumpRenderTree/DerivedSources-output.xcfilelist:
3338         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3339         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3340
3341 2019-01-25  Keith Rollin  <krollin@apple.com>
3342
3343         Fix missing dependencies in extract-dependencies-from-makefile
3344         https://bugs.webkit.org/show_bug.cgi?id=193783
3345         <rdar://problem/47201571>
3346
3347         Reviewed by Alex Christensen.
3348
3349         The extract-dependencies-from-makefile script generates .xcfilelists
3350         for XCBuild by invoking a makefile in --debug mode, parsing the
3351         dependency information in the output, and extracting information
3352         regarding targets and dependents. However, the way `make` emits this
3353         dependency information is not rigorous, and so we need to determine
3354         what lines to look for and parse by trial and error. This approach
3355         didn't coriginally atch all the information we needed to collect, so
3356         update the script to look for the additional lines we now know to look
3357         for.
3358
3359         * Scripts/extract-dependencies-from-makefile:
3360         (Parser):
3361         (Parser.addTarget):
3362         (Parser.addPrereq):
3363         (Parser.doParse):
3364
3365 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3366
3367         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3368         https://bugs.webkit.org/show_bug.cgi?id=193297
3369         <rdar://problem/47158841>
3370
3371         Reviewed by Alex Christensen.
3372
3373         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3374             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3375         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3376         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3377         activating the message used to trigger the callback when it is set.
3378
3379 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3380
3381         WKWebView.goBack should reload if there is a safe browsing warning
3382         https://bugs.webkit.org/show_bug.cgi?id=193805
3383         <rdar://problem/46908216>
3384
3385         Reviewed by Geoff Garen.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3388         (+[Simple3LookupContext sharedLookupContext]):
3389         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3390         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3391         (TEST):
3392
3393 2019-01-25  Chris Dumez  <cdumez@apple.com>
3394
3395         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3396         https://bugs.webkit.org/show_bug.cgi?id=193788
3397         <rdar://problem/47531231>
3398
3399         Reviewed by Alex Christensen.
3400
3401         Add API test coverage.
3402
3403         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3404         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3405
3406 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3407
3408         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3409         https://bugs.webkit.org/show_bug.cgi?id=193771
3410
3411         Unreviewed infrastructure fix.
3412
3413         * Scripts/webkitpy/port/darwin.py:
3414         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3415
3416 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3417
3418         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3419
3420 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3421
3422         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3423
3424         * Scripts/webkitpy/common/config/contributors.json:
3425
3426 2019-01-25  Chris Dumez  <cdumez@apple.com>
3427
3428         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3429         https://bugs.webkit.org/show_bug.cgi?id=193779
3430         <rdar://problem/46170903>
3431
3432         Reviewed by Antti Koivisto.
3433
3434         Add API test that quickly navigates forward to a previous process without waiting for it to
3435         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3436         the process' previous page when reconnecting the it for the forward navigation.
3437
3438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3439
3440 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3441
3442         Need a way for JavaScript (or bundle) code to participate in undo
3443         https://bugs.webkit.org/show_bug.cgi?id=190009
3444         <rdar://problem/44807048>
3445
3446         Reviewed by Ryosuke Niwa.
3447
3448         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3449         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3450
3451         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3452         (WTR::UIScriptController::lastUndoLabel const):
3453         (WTR::UIScriptController::firstRedoLabel const):
3454         (WTR::UIScriptController::platformUndoManager const):
3455         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3456         (WTR::UIScriptController::lastUndoLabel const):
3457         (WTR::UIScriptController::firstRedoLabel const):
3458         (WTR::UIScriptController::platformUndoManager const):
3459         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3460         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3461         (WTR::UIScriptController::lastUndoLabel const):
3462         (WTR::UIScriptController::firstRedoLabel const):
3463         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3464         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3465         (WTR::UIScriptController::lastUndoLabel const):
3466         (WTR::UIScriptController::firstRedoLabel const):
3467         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3468         (WTR::UIScriptController::platformUndoManager const):
3469         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3470         (WTR::UIScriptController::platformUndoManager const):
3471
3472 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3473
3474         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3475         https://bugs.webkit.org/show_bug.cgi?id=193824
3476
3477         Reviewed by Antti Koivisto.
3478
3479         * LayoutReloaded/misc/LFC-passing-tests.txt:
3480
3481 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3482
3483         Update macOS JSC bot configurations
3484         https://bugs.webkit.org/show_bug.cgi?id=193739
3485
3486         Reviewed by Alexey Proskuryakov.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3490         (BubbleQueueServer): Move JSC EWS to Mojave section.
3491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3492         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3493         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3494
3495 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3496
3497         [Win][WebKitTestRunner] Implement EventSenderProxy
3498         https://bugs.webkit.org/show_bug.cgi?id=193755
3499
3500         Reviewed by Don Olmstead.
3501
3502         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3503         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3504         (WTR::EventSenderProxy::dispatchMessage):
3505         (WTR::EventSenderProxy::EventSenderProxy):
3506         (WTR::EventSenderProxy::mouseDown):
3507         (WTR::EventSenderProxy::mouseUp):
3508         (WTR::EventSenderProxy::mouseMoveTo):
3509         (WTR::EventSenderProxy::mouseScrollBy):
3510         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3511
3512 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3513
3514         Unreviewed fix for API test failure after r240437.
3515
3516         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3517
3518         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3519
3520 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3521
3522         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3523         https://bugs.webkit.org/show_bug.cgi?id=193787
3524         <rdar://problem/47497634>
3525
3526         Reviewed by Alexey Proskuryakov.
3527
3528         * Scripts/webkitdirs.pm:
3529         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3530
3531 2019-01-24  Truitt Savell  <tsavell@apple.com>
3532
3533         Unreviewed, rolling out r240446.
3534
3535         Casued 5 API failures
3536
3537         Reverted changeset:
3538
3539         "Activate the WebResourceLoadStatisticsStore in the
3540         NetworkProcess and deactivate it in the UIProcess."
3541         https://bugs.webkit.org/show_bug.cgi?id=193297
3542         https://trac.webkit.org/changeset/240446
3543
3544 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3545
3546         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3547         https://bugs.webkit.org/show_bug.cgi?id=193741
3548         <rdar://problem/47135030>
3549
3550         Reviewed by Antti Koivisto and Simon Fraser.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3554         (TestWebKitAPI::TEST):
3555
3556 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3557
3558         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3559         https://bugs.webkit.org/show_bug.cgi?id=193297
3560         <rdar://problem/47158841>
3561
3562         Reviewed by Alex Christensen.
3563
3564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3565         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3566         activating the message used to trigger the callback when it is set.
3567
3568 2019-01-24  John Wilander  <wilander@apple.com>
3569
3570         Add Ad Click Attribution as an internal/experimental feature
3571         https://bugs.webkit.org/show_bug.cgi?id=193685
3572         <rdar://problem/47450399>
3573
3574         Reviewed by Brent Fulgham.
3575
3576         Added test option adClickAttributionEnabled.
3577
3578         * DumpRenderTree/TestOptions.cpp:
3579         (TestOptions::TestOptions):
3580         * DumpRenderTree/TestOptions.h:
3581         * DumpRenderTree/mac/DumpRenderTree.mm:
3582         (setWebPreferencesForTestOptions):
3583
3584 2019-01-24  Antti Koivisto  <antti@apple.com>
3585
3586         [PSON] Flash on back navigation on Mac
3587         https://bugs.webkit.org/show_bug.cgi?id=193716
3588         <rdar://problem/47148458>
3589
3590         Reviewed by Chris Dumez.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3593
3594         Closing of the previous page is delayed so waiting for didFinishNavigation is
3595         not sufficient to guarantee we have received all the messages. Wait for them.
3596
3597 2019-01-24  Chris Dumez  <cdumez@apple.com>
3598
3599         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3600         https://bugs.webkit.org/show_bug.cgi?id=193761
3601         <rdar://problem/47456405>
3602
3603         Reviewed by Alex Christensen.
3604
3605         Add API test coverage.
3606
3607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3608
3609 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3610
3611         webkitpy: Missing PID in crashlog name should not be fatal
3612         https://bugs.webkit.org/show_bug.cgi?id=193771
3613
3614         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3615         of raising an exception.
3616
3617         Reviewed by Lucas Forschler.
3618
3619         * Scripts/webkitpy/port/darwin.py:
3620         (DarwinPort._merge_crash_logs):
3621
3622 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3623
3624         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3625         https://bugs.webkit.org/show_bug.cgi?id=193746
3626
3627         Reviewed by Youenn Fablet.
3628
3629         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3630         so we'd best just not call it.
3631
3632         * Scripts/webkitpy/w3c/test_exporter.py:
3633         (WebPlatformTestExporter.create_branch_with_patch):
3634
3635 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3636
3637         Move FileSystem to WTF
3638         https://bugs.webkit.org/show_bug.cgi?id=193602
3639
3640         Reviewed by Yusuke Suzuki.
3641
3642         * DumpRenderTree/win/DumpRenderTree.cpp:
3643         * TestWebKitAPI/CMakeLists.txt:
3644         * TestWebKitAPI/PlatformGTK.cmake:
3645         * TestWebKitAPI/PlatformJSCOnly.cmake:
3646         * TestWebKitAPI/PlatformPlayStation.cmake:
3647         * TestWebKitAPI/PlatformWPE.cmake:
3648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3649         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3650         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3651         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3652         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3653         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3654         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3655         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3656         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3657         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3658
3659 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3660
3661         [WPE] Remove hard dependency on subprocess32 for the API tests
3662
3663         Rubber-stamped by Carlos Garcia Campos.
3664
3665         * glib/api_test_runner.py:
3666         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3667         its presence only when running WPEQt tests.
3668
3669 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3670
3671         [GLIB] Expose JavaScriptCore options in GLib public API
3672         https://bugs.webkit.org/show_bug.cgi?id=188742
3673
3674         Reviewed by Michael Catanzaro.
3675
3676         Add a test for the new API.
3677
3678         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3679         (testsJSCOptions):
3680         (main):
3681
3682 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3683
3684         [GTK][WPE] Support JPEG 2000 images
3685         https://bugs.webkit.org/show_bug.cgi?id=186272
3686
3687         Reviewed by Žan Doberšek.
3688
3689         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3690
3691         * gtk/jhbuild.modules:
3692         * wpe/jhbuild.modules:
3693
3694 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3695
3696         check-webkit-style should warn when using soft-linking macros in a header
3697         <https://webkit.org/b/193750>
3698
3699         Reviewed by Darin Adler.
3700
3701         * Scripts/webkitpy/style/checkers/cpp.py:
3702         (check_language): Add softlink/header check by refactoring the
3703         softlink/framework check.
3704         (CppChecker): Enable softlink/header check by default.
3705         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3706         (CppStyleTest.test_softlink_framework): Rename from
3707         CppStyleTest.test_softlink() and change test framework name in
3708         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3709         files. Set file_name for macros that only appear in headers.
3710         (CppStyleTest.test_softlink_header): Add tests for using
3711         soft-link macros in headers.
3712
3713 2019-01-23  Chris Dumez  <cdumez@apple.com>
3714
3715         Deprecate API to limit the maximum number of WebProcesses
3716         https://bugs.webkit.org/show_bug.cgi?id=193725
3717         <rdar://problem/47464879>
3718
3719         Reviewed by Geoff Garen.
3720
3721         Update existing API tests to stop using deprecated API.
3722
3723         * MiniBrowser/mac/AppDelegate.m:
3724         (defaultConfiguration):
3725         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3726         (TestWebKitAPI::TEST):
3727         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3728         (TestWebKitAPI::TEST):
3729         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3730         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3731         (TEST):
3732         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3733         (TEST):
3734
3735 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3736
3737         [ews-app] Rename ews model buildermappings to buildermapping
3738         https://bugs.webkit.org/show_bug.cgi?id=193729
3739
3740         Reviewed by Lucas Forschler.
3741
3742         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3743         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3744         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3745
3746 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3747
3748         [ews-app] Rename ews model steps to step
3749         https://bugs.webkit.org/show_bug.cgi?id=193697
3750
3751         Reviewed by Lucas Forschler.
3752
3753         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3754         (Step): Renamed Steps to Step.
3755
3756 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3757
3758         Clean up IndexedDB files between tests
3759         https://bugs.webkit.org/show_bug.cgi?id=192796
3760         <rdar://problem/46824999>
3761
3762         Reviewed by Geoffrey Garen.
3763
3764         * DumpRenderTree/mac/DumpRenderTree.mm:
3765         (runTest):
3766         * WebKitTestRunner/TestController.cpp:
3767         (WTR::TestController::resetStateToConsistentValues):
3768         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3769         (WTR::RemoveAllIndexedDatabasesCallback):
3770         (WTR::TestController::ClearIndexedDatabases):
3771         * WebKitTestRunner/TestController.h:
3772         * WebKitTestRunner/TestInvocation.cpp:
3773         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3774
3775 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3776
3777         [ews-app] Rename ews model Builds to Build
3778         https://bugs.webkit.org/show_bug.cgi?id=193695
3779
3780         Reviewed by Lucas Forschler.
3781
3782         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3783         (Build): Renamed Builds to Build.
3784
3785 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3786
3787         webkitpy: Wait longer when launching WebKitTestRunner
3788         https://bugs.webkit.org/show_bug.cgi?id=193734
3789
3790         Reviewed by Aakash Jain.
3791
3792         * Scripts/webkitpy/port/simulator_process.py:
3793         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3794
3795 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3796
3797         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3798         https://bugs.webkit.org/show_bug.cgi?id=193182
3799         <rdar://problem/47452154>
3800
3801         Reviewed by Tim Horton.
3802
3803         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3804         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3805         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3806
3807         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3808         preventing later tests from recognizing gestures.
3809
3810         * WebKitTestRunner/ios/TestControllerIOS.mm:
3811         (WTR::TestController::platformResetStateToConsistentValues):
3812
3813         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3814
3815 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3816
3817         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3818         https://bugs.webkit.org/show_bug.cgi?id=193722
3819         <rdar://problem/47481475>
3820
3821         Reviewed by Lucas Forschler.
3822
3823         iPhone and iPad ports should both use the iOS config.
3824
3825         * Scripts/webkitpy/port/ios_simulator.py:
3826         (IPhoneSimulatorPort.__init__):
3827         (IPadSimulatorPort.__init__):
3828
3829 2019-01-23  Rob Buis  <rbuis@igalia.com>
3830
3831         Update MIME type parser
3832         https://bugs.webkit.org/show_bug.cgi?id=180526
3833
3834         Reviewed by Frédéric Wang.
3835
3836         Add unit tests for both parse modes of ParsedContentType.
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3840         (TestWebKitAPI::TEST):
3841
3842 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3843
3844         [ews-app] fetch loop should not stop on network issues
3845         https://bugs.webkit.org/show_bug.cgi?id=193666
3846
3847         Reviewed by Lucas Forschler.
3848
3849         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3850         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3851
3852 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3853
3854         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3855         https://bugs.webkit.org/show_bug.cgi?id=189165
3856         <rdar://problem/47433765>
3857
3858         Reviewed by Tim Horton.
3859
3860         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3861         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3862         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3863         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3864         would make its way to the UI process by the time the layer tree commit is finished.
3865
3866         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3867         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3868         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3869         will fail because it asks for -_autofillContext too early.
3870
3871         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3872         is handled in the UI process.
3873
3874         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3875
3876         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3877         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3878         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3879         input session.
3880
3881         (-[AutofillTestView textInputHasAutofillContext]):
3882
3883         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3884
3885         * TestWebKitAPI/cocoa/TestWKWebView.h:
3886         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3887         (nextInputSessionChangeCount):
3888
3889         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3890         This includes changing the focused element from one to another.
3891
3892         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3893         (-[TestWKWebView didStartFormControlInteraction]):
3894         (-[TestWKWebView didEndFormControlInteraction]):
3895         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3896
3897         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3898         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3899         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3900         that doesn't require an input session to one that doesn't.
3901
3902 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3903
3904         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3905         <https://webkit.org/b/193676>
3906
3907         Reviewed by Alexey Proskuryakov.
3908
3909         * Scripts/webkitpy/style/checkers/cpp.py:
3910         (check_member_initialization_list):
3911         - Don't report missing whitespace around colon if the colon at
3912           the start of the line is formatted correctly.
3913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3914         (WebKitStyleTest.test_member_initialization_list):
3915         - Add a test for a missing permutation of existing tests.
3916         - Add a test this false-positive.
3917         - Add blank lines between subtests to make them easier to read.
3918
3919 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3920
3921         [build.webkit.org] Unit-test failure after r237113
3922         https://bugs.webkit.org/show_bug.cgi?id=193669
3923
3924         Reviewed by Michael Catanzaro.
3925
3926         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3927         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3928         multiple or zero flags.
3929
3930 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3931
3932         Cache bytecode to disk
3933         https://bugs.webkit.org/show_bug.cgi?id=192782
3934         <rdar://problem/46084932>
3935
3936         Reviewed by Keith Miller.
3937
3938         Add test helper to execute bytecode-cache tests: it executes each test
3939         twice, the first with JSC_diskCachePath set to a temporary directory
3940         and second with JSC_forceDiskCache=true (in addition to the cache path)
3941         to guarantee that only the disk cache is being used and no new
3942         UnlinkedCodeBlocks are being created.
3943
3944         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3945         * Scripts/run-jsc-stress-tests:
3946
3947 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3948
3949         [css-logical] Implement flow-relative margin, padding and border shorthands
3950         https://bugs.webkit.org/show_bug.cgi?id=188697
3951
3952         Reviewed by Simon Fraser and Antti Koivisto.
3953
3954         * DumpRenderTree/TestOptions.cpp:
3955         (TestOptions::TestOptions):
3956         * DumpRenderTree/TestOptions.h:
3957         * DumpRenderTree/mac/DumpRenderTree.mm:
3958         (setWebPreferencesForTestOptions):
3959         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3960
3961         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3962         (JSONCSSPropertiesChecker.check_codegen_properties):
3963         Allow CSS property definitions to have a 'runtime-flag' parameter which
3964         disables the property when the specified runtime flag is disabled.
3965
3966 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3967
3968         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3969         https://bugs.webkit.org/show_bug.cgi?id=193643
3970
3971         Reviewed by Michael Catanzaro.
3972
3973         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3974         * wpe/jhbuild.modules: Ditto.
3975
3976 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3977
3978         [LFC][Floats] Take float top position into account when computing containing block height.
3979         https://bugs.webkit.org/show_bug.cgi?id=193655
3980
3981         Reviewed by Antti Koivisto.
3982
3983         * LayoutReloaded/misc/LFC-passing-tests.txt:
3984
3985 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3986
3987         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3988         <https://webkit.org/b/193645>
3989         <rdar://problem/47421574>
3990
3991         Reviewed by Alex Christensen.
3992
3993         - Now checks for local soft-linking of all frameworks that have
3994           their own *SoftLinking.{cpp,h,mm} files.
3995         - Changes softlink/uikit warning to softlink/framework.
3996
3997         * Scripts/webkitpy/style/checkers/cpp.py:
3998         (check_language):
3999         (CppChecker):
4000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4001         (CppStyleTest):
4002
4003 2019-01-20  Saam Barati  <sbarati@apple.com>
4004
4005         Rollout r240210: It broke tests on iOS
4006         https://bugs.webkit.org/show_bug.cgi?id=193640
4007
4008         Unreviewed.
4009
4010         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
4011         * Scripts/run-jsc-stress-tests:
4012
4013 2019-01-20  chris fleizach  <cfleizach@apple.com>
4014
4015         AX: Support returning relative frames for accessibility
4016         https://bugs.webkit.org/show_bug.cgi?id=193414
4017         <rdar://problem/47268501>
4018
4019         Reviewed by Zalan Bujtas.
4020
4021         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4022         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4023         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4024         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4025         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4026         (WTR::attributesOfElement):
4027         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4028
4029 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
4030
4031         Unreviewed, add my new email address
4032
4033         * Scripts/webkitpy/common/config/contributors.json:
4034
4035 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4036
4037         [LFC][BFC] <body>'s overflow property value is propagated to viewport
4038         https://bugs.webkit.org/show_bug.cgi?id=193617
4039
4040         Reviewed by Antti Koivisto.
4041
4042         * LayoutReloaded/misc/LFC-passing-tests.txt:
4043
4044 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
4045
4046         Unreviewed, rolling out r240209.
4047
4048         Broke GTK/WPE injected bundle
4049
4050         Reverted changeset:
4051
4052         "AX: Support returning relative frames for accessibility"
4053         https://bugs.webkit.org/show_bug.cgi?id=193414
4054         https://trac.webkit.org/changeset/240209
4055
4056 2019-01-12  Dan Bernstein  <mitz@apple.com>
4057
4058         [Cocoa] Avoid importing directly from subumbrella frameworks
4059         https://bugs.webkit.org/show_bug.cgi?id=186016
4060         <rdar://problem/40591038>
4061
4062         Reviewed by Sam Weinig.
4063
4064         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4065           LaunchServices header.
4066         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4067           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4068         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4069           when using SDKs earlier than 10.13.
4070         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4071           and OTHER_CPLUSPLUSFLAGS.
4072         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4073           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4074         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4075           LaunchServices header.
4076
4077 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
4078
4079         Cache bytecode to disk
4080         https://bugs.webkit.org/show_bug.cgi?id=192782
4081         <rdar://problem/46084932>
4082
4083         Reviewed by Keith Miller.
4084
4085         Add test helper to execute bytecode-cache tests: it executes each test
4086         twice, the first with JSC_diskCachePath set to a temporary directory
4087         and second with JSC_forceDiskCache=true (in addition to the cache path)
4088         to guarantee that only the disk cache is being used and no new
4089         UnlinkedCodeBlocks are being created.
4090
4091         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
4092         * Scripts/run-jsc-stress-tests:
4093
4094 2019-01-20  chris fleizach  <cfleizach@apple.com>
4095
4096         AX: Support returning relative frames for accessibility
4097         https://bugs.webkit.org/show_bug.cgi?id=193414
4098         <rdar://problem/47268501>
4099
4100         Reviewed by Zalan Bujtas.
4101
4102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4103         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4104         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4105         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4106         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4107         (WTR::attributesOfElement):
4108         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
4109
4110 2019-01-20  Antoine Quint  <graouts@apple.com>
4111
4112         Add a POINTER_EVENTS feature flag
4113         https://bugs.webkit.org/show_bug.cgi?id=193577
4114         <rdar://problem/47408511>
4115
4116         Unreviewed. Also enable Pointer Events for iosmac.
4117
4118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4119
4120 2019-01-19  Zalan Bujtas  <zalan@apple.com>
4121
4122         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
4123         https://bugs.webkit.org/show_bug.cgi?id=193613
4124
4125         Reviewed by Antti Koivisto.
4126
4127         * LayoutReloaded/misc/LFC-passing-tests.txt:
4128
4129 2019-01-19  Antoine Quint  <graouts@apple.com>
4130
4131         Add a POINTER_EVENTS feature flag
4132         https://bugs.webkit.org/show_bug.cgi?id=193577
4133
4134         Reviewed by Dean Jackson.
4135
4136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4137
4138 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
4139
4140         Disable the run-jsc-stress-test remote host key check [second round].
4141         https://bugs.webkit.org/show_bug.cgi?id=192988
4142
4143         Reviewed by Dewei Zhu.
4144
4145         * Scripts/run-jsc-stress-tests:
4146
4147 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4148
4149         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
4150         https://bugs.webkit.org/show_bug.cgi?id=193597
4151
4152         Reviewed by Lucas Forschler.
4153
4154         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4155
4156 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4157
4158         [build.webkit.org] api tests failures are incorrectly named as unit test failures
4159         https://bugs.webkit.org/show_bug.cgi?id=193595
4160
4161         Reviewed by Lucas Forschler.
4162
4163         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
4164         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
4165         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
4166
4167 2019-01-18  Chris Dumez  <cdumez@apple.com>
4168
4169         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
4170         https://bugs.webkit.org/show_bug.cgi?id=193588
4171         <rdar://problem/47131566>
4172
4173         Reviewed by Alex Christensen.
4174
4175         Add layout test coverage.
4176
4177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4178
4179 2019-01-18  Jer Noble  <jer.noble@apple.com>
4180
4181         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4182         https://bugs.webkit.org/show_bug.cgi?id=189553
4183
4184         Reviewed by Tim Horton.
4185
4186         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4187
4188         * ContentExtensionTester/Configurations/Base.xcconfig:
4189         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4190         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4191         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4192         * ImageDiff/cg/Configurations/Base.xcconfig:
4193         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4194         * MiniBrowser/Configurations/Base.xcconfig:
4195         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4196         * MobileMiniBrowser/Configurations/Base.xcconfig:
4197         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4198         * Scripts/webkitpy/style/checker.py:
4199         (_all_categories):
4200         (FileType):
4201         (CheckerDispatcher._file_type):
4202         (CheckerDispatcher._create_checker):
4203         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4204         (SDKVariantChecker):
4205         (SDKVariantChecker.__init__):
4206         (SDKVariantChecker.check):
4207         * TestWebKitAPI/Configurations/Base.xcconfig:
4208         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4209         * WebEditingTester/Configurations/Base.xcconfig:
4210         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4211         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4212         * WebKitTestRunner/Configurations/Base.xcconfig:
4213         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4214         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4215         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4216
4217 2019-01-18  David Kilzer  <ddkilzer@apple.com>
4218
4219         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4220         <https://webkit.org/b/193568>
4221         <rdar://problem/47381130>
4222
4223         Reviewed by Alex Christensen.
4224
4225         Make sure no one re-introduces UIKit soft-linking by adding a
4226         style rule.
4227
4228         * Scripts/webkitpy/style/checkers/cpp.py:
4229         (check_language): Add softlink/uikit check.
4230         (CppChecker): Enable softlink/uikit check.
4231         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4232         (CppStyleTest): Add test for softlink/uikit.
4233
4234 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
4235
4236         [GTK] install-dependencies tool looks for libunistring-dev for dnf
4237         https://bugs.webkit.org/show_bug.cgi?id=193584
4238
4239         Change "-dev" to "-devel".
4240
4241         Reviewed by Michael Catanzaro.
4242
4243         * gtk/install-dependencies:
4244
4245 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4246
4247         webkitpy: Add iPhone and iPad ports
4248         https://bugs.webkit.org/show_bug.cgi?id=193537
4249         <rdar://problem/47353390>
4250
4251         Reviewed by Lucas Forschler.
4252
4253         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
4254         ports. Note that this separation is optional, the --ios-simulator command remains.
4255
4256         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4257         (RunTest.test_device_type_test_division): Drive-by fix.
4258         (RunTest.test_device_type_specific_listing): Ditto.
4259         (RunTest.test_ipad_test_division):
4260         (RunTest):
4261         (RunTest.test_ipad_listing):
4262         * Scripts/webkitpy/port/factory.py:
4263         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
4264         (PortFactory):
4265         * Scripts/webkitpy/port/ios_simulator.py:
4266         (IPhoneSimulatorPort):
4267         (IPadSimulatorPort):
4268
4269 2019-01-18  Chris Dumez  <cdumez@apple.com>
4270
4271         Regression(PSON) Scroll position is not always restored properly when navigating back
4272         https://bugs.webkit.org/show_bug.cgi?id=193578
4273         <rdar://problem/47386331>
4274
4275         Reviewed by Tim Horton.
4276
4277         Add API test coverage.
4278
4279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4280
4281 2019-01-18  Youenn Fablet  <youenn@apple.com>
4282
4283         Add a new SPI to request for cache storage quota increase
4284         https://bugs.webkit.org/show_bug.cgi?id=193323
4285
4286         Reviewed by Alex Christensen.
4287
4288         Implement WebsiteDataStore quota delegate to handle quota requests.
4289         By default, do not update quota.
4290         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
4291
4292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4294         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
4295         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4296         * WebKitTestRunner/TestController.cpp:
4297         (WTR::TestController::allowCacheStorageQuotaIncrease):
4298         * WebKitTestRunner/TestController.h:
4299         * WebKitTestRunner/TestInvocation.cpp:
4300         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4301         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4302         (-[CacheStorageQuotaManager init]):
4303         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4304         (WTR::initializeWebViewConfiguration):
4305         (WTR::TestController::cocoaResetStateToConsistentValues):
4306         (WTR::TestController::allowCacheStorageQuotaIncrease):
4307
4308 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4309
4310         [ews-build] Pass owner to the triggered builds
4311         https://bugs.webkit.org/show_bug.cgi?id=193574
4312
4313         Reviewed by Lucas Forschler.
4314
4315         * BuildSlaveSupport/ews-build/factories.py:
4316         (BuildFactory.propertiesToPassToTriggers):
4317
4318 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4319
4320         [ews-app] Send patch author as a build property
4321         https://bugs.webkit.org/show_bug.cgi?id=193560
4322
4323         Reviewed by Lucas Forschler.
4324
4325         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4326         (BugzillaPatchFetcher.fetch):
4327
4328 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4329
4330         webkitpy: Implement device type specific expected results (Follow-up fix)
4331         https://bugs.webkit.org/show_bug.cgi?id=192162
4332         <rdar://problem/46345449>
4333
4334         Unreviewed infrastructure fix.
4335
4336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4337         (Manager.run): Don't boot a device if no tests are available to run on it.
4338
4339 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4340
4341         webkitpy: Implement device type specific expected results (Follow-up fix)
4342         https://bugs.webkit.org/show_bug.cgi?id=192162
4343         <rdar://problem/46345449>
4344
4345         Unreviewed infrastructure fix.
4346
4347         * Scripts/webkitpy/api_tests/manager.py:
4348         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
4349
4350 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4351
4352         webkitpy: Implement device type specific expected results (Part 2)
4353         https://bugs.webkit.org/show_bug.cgi?id=192162
4354         <rdar://problem/46345449>
4355
4356         Rubber-stamped by Aakash Jain.
4357