[EFL][WK2] Skip failing unit tests
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2
3         [EFL][WK2] Skip failing unit tests
4         https://bugs.webkit.org/show_bug.cgi?id=132979
5
6         Reviewed by Daniel Bates.
7
8         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
9
10 2014-05-15  David Kilzer  <ddkilzer@apple.com>
11
12         [iOS] Support TestWebKitAPI in the iOS Simulator
13         <http://webkit.org/b/129535>
14         <rdar://problem/16203529>
15
16         Reviewed by Daniel Bates.
17
18         * Scripts/run-api-tests:
19         (runTest):
20         (listAllTests):
21         - Extract common arguments into local variable.
22         - Use xcrun to find the sim tool in order to invoke
23         TestWebKitAPI properly in the iOS Simulator. 
24
25         * Scripts/webkitdirs.pm:
26         (argumentsForConfiguration): Set --device or --sim as
27         appropriate to fix buildTestTool() in run-api-tests.
28
29 2014-05-15  Tim Horton  <timothy_horton@apple.com>
30
31         Fix a logging typo in copy-webkitlibraries-to-product-directory
32
33         Reviewed by Dean Jackson.
34
35         * Scripts/copy-webkitlibraries-to-product-directory:
36
37 2014-05-15  David Kilzer  <ddkilzer@apple.com>
38
39         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
40         <http://webkit.org/b/132959>
41
42         Reviewed by Dan Bernstein.
43
44         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
45         Cocoa directory to project and move URLExtras.mm into it.
46         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
47
48 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
49
50         [GTK] Compile all installed resources as GResources
51         https://bugs.webkit.org/show_bug.cgi?id=131099
52
53         Reviewed by Philippe Normand.
54
55         * Scripts/webkitpy/port/gtk.py:
56         (GtkPort.setup_environ_for_server): Removed now unneeded
57         AUDIO_RESOURCES_PATH env var.
58
59 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
60
61         Remove CSS_STICKY_POSITION guards
62         https://bugs.webkit.org/show_bug.cgi?id=132676
63
64         Reviewed by Simon Fraser.
65
66         * Scripts/webkitperl/FeatureList.pm:
67
68 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
69
70         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
71         https://bugs.webkit.org/show_bug.cgi?id=132686
72
73         Reviewed by Philippe Normand.
74
75         Bring back InputMethodFilter test to the build and compile it into
76         a single binary TestWebCore with the other WebCore tests. Also
77         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
78
79         * Scripts/run-gtk-tests:
80         (TestRunner): Remove WebCoreGtk from the list of test directories.
81         * TestWebKitAPI/PlatformGTK.cmake:
82         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
83
84 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
85
86         [EFL] Make XVFBDriver optional
87         https://bugs.webkit.org/show_bug.cgi?id=131036
88
89         Reviewed by Gyuyoung Kim.
90
91         * Scripts/webkitpy/port/efl.py:
92         (EflPort._driver_class):
93
94 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
95
96         Flakiness dashboard contains outdated list of bots on builders.jsonp
97         https://bugs.webkit.org/show_bug.cgi?id=132874
98
99         Reviewed by Darin Adler.
100
101         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
102         file by changing to the directory Tools/TestResultServer and executing
103         the script generate_builders_json.py
104
105 2014-05-11  Anders Carlsson  <andersca@apple.com>
106
107         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
108         https://bugs.webkit.org/show_bug.cgi?id=132809
109
110         Reviewed by Dan Bernstein.
111
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::TestController::initialize):
114         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
115
116 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
117
118         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
119         https://bugs.webkit.org/show_bug.cgi?id=132739
120
121         Reviewed Anders Carlsson.
122
123         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
124         the JSC unit tests.
125         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
126
127 2014-05-11  Anders Carlsson  <andersca@apple.com>
128
129         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
130         https://bugs.webkit.org/show_bug.cgi?id=132806
131
132         Reviewed by Beth Dakin.
133
134         Migrate to WKContextConfiguration.
135
136         * WebKitTestRunner/TestController.cpp:
137         (WTR::TestController::initialize):
138
139 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
140
141         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
142         https://bugs.webkit.org/show_bug.cgi?id=132685
143
144         Reviewed by Martin Robinson.
145
146         Use a single TestWebKit2 binary for all WebKit2 C API tests.
147
148         * TestWebKitAPI/PlatformGTK.cmake:
149
150 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
151
152         [iOS] Switch geolocation to an explicit authorization query model
153         https://bugs.webkit.org/show_bug.cgi?id=132717
154
155         Reviewed by Sam Weinig.
156
157         * DumpRenderTree/mac/MockGeolocationProvider.mm:
158         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
159         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
160
161 2014-05-09  David Farler  <dfarler@apple.com>
162
163         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
164         https://bugs.webkit.org/show_bug.cgi?id=132718
165
166         Reviewed by David Kilzer.
167
168         The simulator may not be able to look up runtimes by SDK paths
169         and instead will map SDK versions to runtimes instead. In
170         com.apple.iphonesimulator.startSession notifications,
171         'runtimeIdentifier' (SDK version string) is preferred over
172         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
173         when creating a new DRT or WKTR simulator session.
174
175         IPhoneSimulatorNotification.pm filters out keys for this
176         notification's userInfo with a hard-coded list. There's no harm
177         in including extra key-value pairs in an NSNotification userInfo
178         dictionary anyway and the simulator may again change its
179         userInfo schema for this notification.
180
181         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
182         (postStartSessionNotification):
183         * Scripts/old-run-webkit-tests:
184         (installAndLaunchDumpToolAppUsingNotification):
185
186 2014-05-09  Anders Carlsson  <andersca@apple.com>
187
188         Another build fix.
189
190         * Scripts/build-webkit:
191         WebKit2 should always be built for OS X and iOS.
192
193 2014-05-09  Anders Carlsson  <andersca@apple.com>
194
195         Follow-up build fix.
196
197         * Scripts/build-webkit:
198         WebKit2 should no longer be built before WebKit.
199
200 2014-05-09  Anders Carlsson  <andersca@apple.com>
201
202         Rename WebKit2.framework to WebKit.framework
203         https://bugs.webkit.org/show_bug.cgi?id=132743
204         <rdar://problem/15920046>
205
206         Reviewed by Dan Bernstein.
207
208         * Scripts/check-for-inappropriate-files-in-framework:
209         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
210         Change WebKit2 to WebKit.
211
212         * Scripts/check-for-webkit-framework-include-consistency:
213         Change WebKit to WebKitLegacy.
214
215 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
216
217         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
218         https://bugs.webkit.org/show_bug.cgi?id=132732
219
220         Reviewed by Alexey Proskuryakov.
221
222         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
223
224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
225         (EWS): Remove GTK+ WK1 EWS.
226
227 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
228
229         Add new u-szeged contributors.
230
231         Reviewed by Csaba Osztrogonác.
232
233         * Scripts/webkitpy/common/config/contributors.json:
234
235 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
238         https://bugs.webkit.org/show_bug.cgi?id=132736
239
240         Reviewed by Philippe Normand.
241
242         There are two problems, the path returned by common.library_build_path() is wrong when
243         common.binary_build_path() has previously been called, and the test is still looking for
244         the .la instead of .so
245
246         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
247         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
248         of .la as extension of the injected bundle library.
249         * gtk/common.py:
250         (binary_build_path): Remove unused global variable and add a new
251         one for binary_build_dir instead of sharing the same global
252         variable for library_build_path and binary_build_path.
253
254 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
255
256         [EFL] Enable MEDIA_STREAM for EFL port
257         https://bugs.webkit.org/show_bug.cgi?id=132648
258
259         Reviewed by Gyuyoung Kim.
260
261         Script modified to enable MEDIA_STREAM for EFL build.
262
263         * Scripts/webkitperl/FeatureList.pm: 
264
265 2014-05-08  David Farler  <dfarler@apple.com>
266
267         old-run-webkit-tests: update strings for simulator devices and app name
268         https://bugs.webkit.org/show_bug.cgi?id=132687
269
270         Reviewed by Darin Adler.
271
272         iPhone Retina (4-inch) -> iPhone 5
273         iPhone Retina (4-inch 64-bit) -> iPhone 5s
274
275         * Scripts/old-run-webkit-tests:
276         (installAndLaunchDumpToolAppUsingNotification):
277         (openIPhoneSimulator):
278         (quitIPhoneSimulator):
279         quit iOS Simulator, not iPhone Simulator.
280
281 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
282
283         REGRESSION(r168471): Update the builder names on the scheduler list.
284         https://bugs.webkit.org/show_bug.cgi?id=132699
285
286         Reviewed by Martin Robinson.
287
288         On r168471 I missed to update the builder names for the GTK build
289         bots on the AnyBranchScheduler type scheduler list of bots.
290
291         * BuildSlaveSupport/build.webkit.org-config/config.json:
292
293 2014-05-08  Brady Eidson  <beidson@apple.com>
294
295         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
296         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
297
298         Reviewed by Tim Horton.
299
300         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
301         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
302
303 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
304
305         REGRESSION(r168471): Duplicate builddirs broke the build master.
306         https://bugs.webkit.org/show_bug.cgi?id=132688
307
308         Reviewed by Carlos Garcia Campos.
309
310         Rename the builddirs of the new GTK bots introduced on r168471 to
311         be unique. Otherwise the master will break.
312
313         * BuildSlaveSupport/build.webkit.org-config/config.json:
314
315 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
318         https://bugs.webkit.org/show_bug.cgi?id=132674
319
320         Reviewed by Philippe Normand.
321
322         Only ignore mkdir failure when exception is raised because the
323         file already exists and it's a directory.
324
325         * gtk/webkitdom.py:
326         (write_doc_files):
327
328 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
329
330         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
331         https://bugs.webkit.org/show_bug.cgi?id=131358
332
333         Reviewed by Carlos Garcia Campos.
334
335         Current 64-bit GTK build bots (Release and Debug) not only test
336         the build, but run all tests. Split each one of the bots in
337         BuildOnly and TestWebKit2.
338
339         This will allow us to have a better overview of the status of
340         the GTK port.
341
342         Original patch from Sergio Villar Senin <svillar@igalia.com>
343
344         * BuildSlaveSupport/build.webkit.org-config/config.json:
345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
347         (WebKitBuildbot):
348         * Scripts/webkitpy/port/builders.py:
349         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
350         (TestRebaselineTest.test_baseline_directory):
351         * TestResultServer/static-dashboards/builders.jsonp:
352         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
353         (resetGlobals):
354         * TestResultServer/static-dashboards/loader_unittests.js:
355
356 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
357
358         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
359         https://bugs.webkit.org/show_bug.cgi?id=126022
360
361         Reviewed by Benjamin Poulain.
362
363         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
364
365         Added an unit test case to check if scroll position and scale are restored properly.
366
367         * TestWebKitAPI/PlatformEfl.cmake:
368         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
369         (TestWebKitAPI::didFinishLoadForFrame):
370         (TestWebKitAPI::didChangeContentsPosition):
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
373         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
374
375 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
376
377         WebKit1 is flashy when compositing layers come and go
378         https://bugs.webkit.org/show_bug.cgi?id=132655
379         <rdar://problem/16830981&16788846>
380
381         Reviewed by Sam Weinig.
382         
383         Revert the change from r166117.
384
385         * DumpRenderTree/mac/DumpRenderTree.mm:
386         (updateDisplay):
387
388 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
389
390         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
391         https://bugs.webkit.org/show_bug.cgi?id=132622
392
393         Reviewed by Mario Sanchez Prada.
394
395         * DumpRenderTree/AccessibilityUIElement.cpp:
396         (selectTextWithCriteriaCallback):
397         (isEqualCallback):
398         * DumpRenderTree/AccessibilityUIElement.h:
399         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
400         (AccessibilityUIElement::selectTextWithCriteria):
401         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
402         (AccessibilityUIElement::selectTextWithCriteria):
403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
404         (selectTextParameterizedAttributeForCriteria):
405         (AccessibilityUIElement::selectTextWithCriteria):
406         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
407         (AccessibilityUIElement::selectTextWithCriteria):
408         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
409         (WTR::AccessibilityUIElement::selectTextWithCriteria):
410         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
411         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
412         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
413         (WTR::AccessibilityUIElement::selectTextWithCriteria):
414         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
415         (WTR::AccessibilityUIElement::selectTextWithCriteria):
416         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
417         (WTR::selectTextParameterizedAttributeForCriteria):
418         (WTR::AccessibilityUIElement::selectTextWithCriteria):
419
420 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
421
422         [SOUP] TLSErrors do not cause page load to fail when not ignored
423         https://bugs.webkit.org/show_bug.cgi?id=121548
424
425         Reviewed by Sergio Villar Senin.
426
427         Add unit tests to check that the load fails with TLS errors in
428         case of a redirection.
429
430         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
431         (testTLSErrorsRedirect):
432         (httpsServerCallback):
433         (beforeAll):
434
435 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
436
437         [CSS Grid Layout] Remove runtime feature
438         https://bugs.webkit.org/show_bug.cgi?id=132382
439
440         Reviewed by Benjamin Poulain.
441
442         Remove cssGridLayoutEnabled setting usage.
443
444         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
445         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
446         * DumpRenderTree/efl/TestRunnerEfl.cpp:
447         (TestRunner::overridePreference):
448         * DumpRenderTree/mac/DumpRenderTree.mm:
449         (resetWebPreferencesToConsistentValues):
450
451 2014-05-06  David Kilzer  <ddkilzer@apple.com>
452
453         Add Makefile targets for copying static libraries (LLVM and WKSI)
454         <http://webkit.org/b/132619>
455
456         Reviewed by Mark Rowe.
457
458         * Scripts/copy-webkitlibraries-to-product-directory: Set a
459         sensible default for product directory if not specified on
460         either the command-line or in the environment (by Xcode) by
461         calling productDir() in webkitdirs.pm.
462
463 2014-05-06  Brady Eidson  <beidson@apple.com>
464
465         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
466         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
467
468         Reviewed by Sam Weinig.
469
470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
471
472         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
473         (TestWebKitAPI::itemURLLastComponentIsString):
474         (TestWebKitAPI::didFinishLoadForFrame):
475         (TestWebKitAPI::willGoToBackForwardListItem):
476         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
477         (TestWebKitAPI::setPageLoaderClient):
478         (TestWebKitAPI::TEST):
479         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
480         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
481
482         * WebKitTestRunner/TestController.cpp:
483         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
484
485 2014-05-06  Darin Adler  <darin@apple.com>
486
487         Try to fix iOS build.
488
489         * DumpRenderTree/mac/TestRunnerMac.mm:
490         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
491         Updated since I changed testRunner into a pointer instead of a reference.
492         Updated argument names to avoid conflict with field names.
493         (-[APITestDelegateIPhone run]): Ditto.
494         (-[APITestDelegateIPhone _cleanUp]): Ditto.
495
496 2014-05-06  Commit Queue  <commit-queue@webkit.org>
497
498         Unreviewed, rolling out r168304.
499         https://bugs.webkit.org/show_bug.cgi?id=132607
500
501         Broke the build (Requested by KaL on #webkit).
502
503         Reverted changeset:
504
505         "[GTK][CMake] Unable to do make install"
506         https://bugs.webkit.org/show_bug.cgi?id=130188
507         http://trac.webkit.org/changeset/168304
508
509 2014-05-04  Darin Adler  <darin@apple.com>
510
511         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
512         https://bugs.webkit.org/show_bug.cgi?id=80222
513
514         Reviewed by Alexey Proskuryakov.
515
516         * DumpRenderTree/mac/TestRunnerMac.mm:
517         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
518         do more work here so we don't use RetainPtr local variables.
519         (-[APITestDelegateIPhone dealloc]): Added.
520         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
521         created. Updated for changes to member names and types.
522         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
523         updated for changes to member names and types. Changed to two word spelling.
524         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
525         name of _cleanUp method.
526         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
527         Ditto.
528         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
529
530 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
531
532         Clean up Image Document and tweak the layout and viewport
533         https://bugs.webkit.org/show_bug.cgi?id=132552
534
535         Reviewed by Anders Carlsson.
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (resetWebPreferencesToConsistentValues):
539         Update the default settings to have something consistent with WebKit2.
540
541 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
542
543         [GTK][CMake] Unable to do make install
544         https://bugs.webkit.org/show_bug.cgi?id=130188
545
546         Reviewed by Carlos Garcia Campos.
547
548         * Scripts/webkitdirs.pm:
549         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
550         will give an early signal that a change has broken the documentation.
551
552 2014-05-05  Pratik Solanki  <psolanki@apple.com>
553
554         Update framework locations in package-root
555         https://bugs.webkit.org/show_bug.cgi?id=132571
556
557         Reviewed by Simon Fraser.
558
559         * Scripts/package-root:
560
561 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
562
563         [EFL][WK2] Refactor favicon database APIs
564         https://bugs.webkit.org/show_bug.cgi?id=132519
565
566         Reviewed by Gyuyoung Kim.
567
568         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
569         (update_view_favicon):
570         (on_icon_changed_cb):
571         (window_free):
572         (on_url_changed):
573         (window_create):
574         (on_view_favicon_changed): Deleted.
575
576 2014-05-02  Mark Rowe  <mrowe@apple.com>
577
578         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
579
580         Reviewed by Dan Bernstein.
581
582         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
583         when determining which LLVM archive to extract.
584
585 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
586
587         Add Jeremy as a committer.
588         https://bugs.webkit.org/show_bug.cgi?id=132492
589
590         Reviewed by Jer Noble.
591
592         Add myself as a committer.
593
594         * Scripts/webkitpy/common/config/contributors.json:
595
596 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
597
598         Add Jeremy as a committer.
599         https://bugs.webkit.org/show_bug.cgi?id=132492
600
601         Reviewed by Jer Noble.
602
603         Add Jeremy Jones to the committers file.
604
605         * Scripts/webkitpy/common/config/contributors.json:
606
607 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
608
609         Hard to figure out how to run a single test with run-api-tests
610         https://bugs.webkit.org/show_bug.cgi?id=116332
611
612         Reviewed by Alexey Proskuryakov.
613
614         * Scripts/run-api-tests: add two examples to the help message.
615
616 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
617
618         Fix several memory leaks found by code inspection
619         https://bugs.webkit.org/show_bug.cgi?id=132472
620
621         Reviewed by Geoffrey Garen.
622         
623         Fix memory leaks.
624
625         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
626         (TestWebKitAPI::TEST):
627         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
628         (WTR::InjectedBundlePage::willSendRequestForFrame):
629         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
630         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
631
632 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
633
634         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
635         https://bugs.webkit.org/show_bug.cgi?id=132446
636
637         Reviewed by Mark Hahnenberg.
638         
639         Test the FTL by default now that it's enabled by default.
640
641         * Scripts/run-javascriptcore-tests:
642
643 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
644
645         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
646         https://bugs.webkit.org/show_bug.cgi?id=132240
647
648         Reviewed by Anders Carlsson.
649
650         Removed ewk_view_setting_tiled_backingstore related code.
651
652         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
653         (DumpRenderTreeChrome::createView):
654         (shouldUseTiledBackingStore): Deleted.
655         * EWebLauncher/main.c:
656         (windowCreate):
657         (parseUserArguments):
658
659 2014-05-01  Anders Carlsson  <andersca@apple.com>
660
661         window.testRunner.keepWebHistory() should update the UI process state
662         https://bugs.webkit.org/show_bug.cgi?id=132440
663
664         Reviewed by Dan Bernstein.
665
666         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
667         (WTR::InjectedBundle::postSetAddsVisitedLinks):
668         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
669         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
670         (WTR::TestRunner::keepWebHistory):
671         * WebKitTestRunner/TestInvocation.cpp:
672         (WTR::TestInvocation::invoke):
673         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
674
675 2014-05-01  David Kilzer  <ddkilzer@apple.com>
676
677         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
678         <http://webkit.org/b/132432>
679
680         Reviewed by Tim Horton.
681
682         * Scripts/webkitperl/FeatureList.pm: Remove support for
683         --plugin-proxy-for-video switch.
684
685 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
686
687         Kernel sysctl interface hw.activecpu don't exists on Linux.
688         https://bugs.webkit.org/show_bug.cgi?id=132286
689
690         Reviewed by Filip Pizlo.
691
692         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
693         calling sysctl over hw.activecpu
694
695 2014-04-30  Anders Carlsson  <andersca@apple.com>
696
697         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
698         https://bugs.webkit.org/show_bug.cgi?id=132399
699         <rdar://problem/15920046>
700
701         Reviewed by Dan Bernstein.
702
703         * Scripts/check-for-webkit-framework-include-consistency:
704         Allos WAK headers in WebKitLegacy as well as WebKit.
705
706         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
707         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
708         Update header imports.
709
710 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
711
712         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
713         https://bugs.webkit.org/show_bug.cgi?id=131954
714
715         Reviewed by Darin Adler.
716         
717         WebKitTestRunner was adding application-specific information to crash reports
718         to log the test path, but only in the web process. Fix it to also do this
719         for the UI process, for both iOS and OS X.
720         
721         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
722         both iOS and OS X.
723         
724         Factored crash reprorter-related code into CrashReporterInfo, and call it from
725         a new TestController::platformWillRunTest() function on Mac and iOS.
726         
727         Also remove Xcode-added unit test junk from the project.
728
729         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
730         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
731         * WebKitTestRunner/TestController.cpp:
732         (WTR::TestController::runTest):
733         * WebKitTestRunner/TestController.h:
734         * WebKitTestRunner/TestInvocation.cpp:
735         (WTR::TestInvocation::url):
736         * WebKitTestRunner/TestInvocation.h:
737         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
738         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
739         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
740         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
741         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
742         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
743         (WTR::testPathFromURL):
744         (WTR::setCrashReportApplicationSpecificInformationToURL):
745         * WebKitTestRunner/efl/TestControllerEfl.cpp:
746         (WTR::TestController::platformWillRunTest):
747         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
748         (WTR::TestController::platformWillRunTest):
749         * WebKitTestRunner/ios/TestControllerIOS.mm:
750         (WTR::TestController::platformWillRunTest):
751         (WTR::TestController::setHidden):
752         * WebKitTestRunner/mac/TestControllerMac.mm:
753         (WTR::TestController::platformWillRunTest):
754
755 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
756
757         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
758
759         Reviewed by Tim Horton.
760
761         * DumpRenderTree/mac/DumpRenderTree.mm:
762         (resetWebPreferencesToConsistentValues):
763         (prepareConsistentTestingEnvironment):
764
765 2014-04-30  Anders Carlsson  <andersca@apple.com>
766
767         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
768         https://bugs.webkit.org/show_bug.cgi?id=132397
769
770         Reviewed by Dan Bernstein.
771
772         * Scripts/check-for-inappropriate-macros-in-external-headers:
773
774 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
775
776         [GTK] Make it easier to run CMake for downstreams
777         https://bugs.webkit.org/show_bug.cgi?id=132370
778
779         Reviewed by Carlos Garcia Campos.
780
781         * Scripts/webkitdirs.pm:
782         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
783         the GTK+ port.
784
785 2014-04-29  Stephanie Lewis  <slewis@apple.com>
786
787         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
788         
789         Rubber stamped by Jessie Berlin.
790
791         JSON.pm was removed from our tools setup.
792
793         * Scripts/generate-coverage-data:
794
795 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
796
797         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
798         https://bugs.webkit.org/show_bug.cgi?id=112840
799
800         Rubber stamped by Geoffrey Garen.
801
802         * Scripts/build-jsc: Enable it on Mac.
803         * Scripts/build-webkit: Enable it on Mac.
804         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
805
806 2014-04-28  Sam Weinig  <sam@webkit.org>
807
808         REGRESSION (r167751): svn-create-patch is very slow
809         https://bugs.webkit.org/show_bug.cgi?id=132300
810
811         Reviewed by Alexey Proskuryakov.
812
813         * Scripts/svn-create-patch:
814         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
815         by calling `svn-create-patch --style`.
816
817 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
818
819         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
820         https://bugs.webkit.org/show_bug.cgi?id=132190
821
822         Reviewed by Gustavo Noronha Silva.
823
824         * Scripts/webkitdirs.pm:
825         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
826             if ninja is in the path.
827         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
828             to the previous ninja generator if not.
829
830 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
831
832         check-webkit-style should understand --git-index
833         https://bugs.webkit.org/show_bug.cgi?id=125364
834
835         Reviewed by Csaba Osztrogonác.
836
837         * Scripts/webkitpy/common/checkout/scm/git.py:
838         (Git.create_patch): The command now supports the --cached option.
839         * Scripts/webkitpy/style/main.py:
840         (CheckWebKitStyle.main): Passing the --git-index option.
841         * Scripts/webkitpy/style/optparser.py:
842         (CommandOptionValues.__init__): The git-index option is switched off by default.
843         (CommandOptionValues.__eq__): Equality check for the new option.
844         (ArgumentParser._create_option_parser):Adding the --git-index option
845         (ArgumentParser.parse):
846         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
847         (CommandOptionValuesTest.test_init): 
848         (CommandOptionValuesTest.test_eq):
849
850 2014-04-28  Michael Saboff  <msaboff@apple.com>
851
852         Crash in platform/mac/accessibility/table-visible-rows.html
853         https://bugs.webkit.org/show_bug.cgi?id=132146
854
855         Reviewed by Filip Pizlo.
856
857         Instead of creating a local JSValueRef array on the stack and passing that to
858         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
859         values using the JSObjectSetPropertyAtIndex() API.
860
861         * DumpRenderTree/AccessibilityUIElement.cpp:
862         (elementsForRangeCallback):
863         (convertElementsToObjectArray):
864         * DumpRenderTree/mac/TestRunnerMac.mm:
865         (originsArrayToJS):
866         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
867         (WTR::EventSendingController::contextClick):
868         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
869         (WTR::stringArrayToJS):
870         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
871         (WTR::convertElementsToObjectArray):
872
873 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
874
875         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
876         "no-cjit" runs force the old-school threshold.
877
878         Rubber stamped by Mark Hahnenberg.
879
880         * Scripts/run-jsc-stress-tests:
881
882 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
883
884         [GTK] install-dependencies should also install ruby-json and ruby-highline
885         https://bugs.webkit.org/show_bug.cgi?id=132292
886
887         Reviewed by Philippe Normand.
888
889         * gtk/install-dependencies: Install ruby json and highline packages.
890
891 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
892
893         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
894         https://bugs.webkit.org/show_bug.cgi?id=132176
895
896         Reviewed by Gyuyoung Kim.
897
898         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
899         and turn off indexedDB feature until the sqlite implementation is introduced.
900
901         * Scripts/webkitperl/FeatureList.pm:
902
903 2014-04-25  James Craig  <jcraig@apple.com>
904
905         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
906         https://bugs.webkit.org/show_bug.cgi?id=132209
907
908         Reviewed by Daniel Bates.
909
910         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
911         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
912
913         * Scripts/prepare-ChangeLog:
914         (main): 
915
916 2014-04-25  Michael Saboff  <msaboff@apple.com>
917
918         Crash in platform/mac/accessibility/table-visible-rows.html
919         https://bugs.webkit.org/show_bug.cgi?id=132146
920
921         Reviewed by Mark Lam.
922
923         Changed to use a local JSValueRef array temporary instead of a
924         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
925         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
926         the temporary values could be collected.
927
928         * DumpRenderTree/AccessibilityUIElement.cpp:
929         (convertElementsToObjectArray):
930         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
931         (WTR::EventSendingController::contextClick):
932         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
933         (WTR::convertElementsToObjectArray):
934
935 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
936
937         Unreviewed GTK gardening
938
939         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
940         (TestRunner):
941
942 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
943
944         prepare-ChangeLog reports as deleted methods that has not been removed.
945         https://bugs.webkit.org/show_bug.cgi?id=131733
946
947         Reviewed by Ryosuke Niwa.
948
949         * Scripts/prepare-ChangeLog:
950         (originalFile): Set merge base to origin/master by default.
951
952 2014-04-23  James Craig  <jcraig@apple.com>
953
954         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
955         https://bugs.webkit.org/show_bug.cgi?id=131115
956
957         Reviewed by Daniel Bates.
958
959         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
960
961         * Scripts/commit-log-editor: Added --no-style.
962         * Scripts/prepare-ChangeLog: Primary patch.
963         (main): Primary patch.
964         (createPatchCommand): Added --no-style.
965         * Scripts/svn-create-patch: Primary patch.
966         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
967         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
968         (SVN.create_patch): Added --no-style.
969
970 2014-04-23  Anders Carlsson  <andersca@apple.com>
971
972         Try to fix iOS build.
973
974         * DumpRenderTree/mac/DumpRenderTree.mm:
975
976 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
977
978         Eliminate internals.setMockScrollbarsEnabled()
979         https://bugs.webkit.org/show_bug.cgi?id=132085
980
981         Reviewed by Tim Horton.
982
983         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
984         No need to reset the preference, there is no way it can change.
985
986 2014-04-23  James Craig  <jcraig@apple.com>
987
988         Unreviewed. Moving myself from Contributors to Committers list.
989
990         * Scripts/webkitpy/common/config/contributors.json:
991
992 2014-04-23  Tim Horton  <timothy_horton@apple.com>
993
994         Mock scrollbars don't always work in DumpRenderTree
995         https://bugs.webkit.org/show_bug.cgi?id=132082
996
997         Reviewed by Alexey Proskuryakov.
998
999         * DumpRenderTree/mac/DumpRenderTree.mm:
1000         (prepareConsistentTestingEnvironment):
1001         Set the mock scrollbar setting before creating the WebView, as this setting
1002         cannot be dynamically changed, so any scrollbars that are created during
1003         WebView initialization and are not replaced before snapshotting will end
1004         up being platform scrollbars instead of mock ones.
1005         WebKitTestRunner already sets this preference before creating WKViews,
1006         so we're just matching its behavior.
1007
1008 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] ShadowRoot API was removed in r164131
1011         https://bugs.webkit.org/show_bug.cgi?id=132059
1012
1013         Reviewed by Gustavo Noronha Silva.
1014
1015         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1016         the API docs.
1017
1018         * gtk/webkitdom.py:
1019         (WebKitDOMDocGenerator):
1020
1021 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1022
1023         [GTK] run-webkit-tests script is failing to invoke run-launcher
1024         https://bugs.webkit.org/show_bug.cgi?id=132051
1025
1026         Reviewed by Philippe Normand.
1027
1028         After the WK1 support was dropped, if run-webkit-tests is executed
1029         without --no-show-results parameter, the launcher is being called
1030         using a -2 parameter that is it causing the run-launcher to break.
1031
1032         * Scripts/webkitpy/port/gtk.py:
1033         (GtkPort.show_results_html_file):
1034
1035 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1036
1037         DumpRenderTree generates black snapshots on some platforms
1038         https://bugs.webkit.org/show_bug.cgi?id=132029
1039         <rdar://problem/16679363>
1040
1041         Reviewed by Simon Fraser.
1042
1043         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1044         (createBitmapContextFromWebView):
1045         DRT checks with the WebView to determine whether it can use the window's
1046         backing store directly or (because of compositing) needs to take a WindowServer
1047         snapshot. However, on some platforms and in some situations, the window can
1048         be layer backed without the WebView necessarily currently being composited.
1049         We should check with the window in addition to the WebView before going
1050         ahead and using its backing store.
1051
1052 2014-04-22  Tim Horton  <timothy_horton@apple.com>
1053
1054         DumpRenderTree generates white snapshots on some platforms
1055         https://bugs.webkit.org/show_bug.cgi?id=132026
1056         <rdar://problem/16679363>
1057
1058         Reviewed by Simon Fraser.
1059
1060         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1061         Link DRT against QuartzCore.
1062
1063         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1064         (createBitmapContextFromWebView):
1065         Force CoreAnimation to synchronously update layers in a more explicit
1066         way that doesn't depend on AppKit behavior. This is very similar to what
1067         WebKitTestRunner does (indirectly) during its force repaint.
1068
1069 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
1070
1071         [Win] Support Python 2.7 in Cygwin
1072         https://bugs.webkit.org/show_bug.cgi?id=132023
1073
1074         Reviewed by Michael Saboff.
1075
1076         * Scripts/webkitdirs.pm:
1077         (checkInstalledTools): Remove check for Python 2.7, since
1078         it now works properly.
1079
1080 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
1081
1082         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1083         https://bugs.webkit.org/show_bug.cgi?id=130867
1084         <rdar://problem/16432456> 
1085
1086         Reviewed by Mark Hahnenberg.
1087
1088         * Scripts/build-webkit:
1089         * Scripts/copy-webkitlibraries-to-product-directory:
1090
1091 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
1092
1093         [GTK] Fails to build documentation when output is redirected
1094         https://bugs.webkit.org/show_bug.cgi?id=131178
1095
1096         Reviewed by Martin Robinson.
1097
1098         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
1099         explicitly to avoid encoding issues when they are redirected.
1100
1101 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
1102
1103         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
1104         https://bugs.webkit.org/show_bug.cgi?id=131911
1105
1106         Reviewed by Martin Robinson.
1107
1108         common.get_build_path returns release path even though Debug configuration
1109         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
1110
1111         * gtk/ycm_extra_conf.py:
1112         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
1113         (FlagsForFile):
1114
1115 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
1116
1117         Unreviewed build fix.
1118
1119         * DumpRenderTree/mac/EventSendingController.mm:
1120         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1121         Correct a typo that prevented tests from working properly.
1122
1123 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
1124
1125         [GTK] Should have the ability to output composited contents during layout testing
1126         https://bugs.webkit.org/show_bug.cgi?id=131864
1127
1128         Reviewed by Philippe Normand.
1129
1130         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1131         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
1132         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
1133         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1134         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
1135
1136 2014-04-21  Sam Weinig  <sam@webkit.org>
1137
1138         Attempt to fix the tests.
1139
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1141         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1142         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
1143
1144 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
1145
1146         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
1147         being the same as a "quick run", which is meant for genuinely slow tests).
1148
1149         * Scripts/run-jsc-stress-tests:
1150
1151 2014-04-21  Darin Adler  <darin@apple.com>
1152
1153         Add HashSet::takeAny
1154         https://bugs.webkit.org/show_bug.cgi?id=131928
1155
1156         Reviewed by Benjamin Poulain.
1157
1158         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
1159
1160 2014-04-20  Dan Bernstein  <mitz@apple.com>
1161
1162         Fixed a test timing out after r167572.
1163
1164         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1165         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
1166         -webView:didFinishLoadingNavigation:.
1167
1168 2014-04-20  Commit Queue  <commit-queue@webkit.org>
1169
1170         Unreviewed, rolling out r167510.
1171         https://bugs.webkit.org/show_bug.cgi?id=131915
1172
1173         broke GTK Debug bot (Requested by philn on #webkit).
1174
1175         Reverted changeset:
1176
1177         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
1178         it when running layout tests"
1179         https://bugs.webkit.org/show_bug.cgi?id=131472
1180         http://trac.webkit.org/changeset/167510
1181
1182 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
1183
1184         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1185         https://bugs.webkit.org/show_bug.cgi?id=131472
1186
1187         Reviewed by Philippe Normand.
1188
1189         * Scripts/webkitpy/port/gtk.py:
1190         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1191         when running WebKitTestRunner with run-webkit-tests.
1192         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1193         installed.
1194         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1195         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1196         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1197         deal.
1198
1199 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
1200
1201         DownloadDecideDestinationCrash API test uses an incorrect value for path
1202         https://bugs.webkit.org/show_bug.cgi?id=131845
1203         <rdar://problem/15925560>
1204
1205         Reviewed by Enrica Casucci.
1206
1207         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1208         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1209
1210 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
1211
1212         [Mac] AttributedStringTest API tests fail with async text input
1213         https://bugs.webkit.org/show_bug.cgi?id=131833
1214
1215         Reviewed by Enrica Casucci.
1216
1217         Don't run sync NSTextInputClient tests where we don't implement these calls.
1218
1219         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1220         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1221         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
1222         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1223         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
1224         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
1225         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
1226
1227 2014-04-18  Philippe Normand  <pnormand@igalia.com>
1228
1229         Remove NETWORK_INFO support
1230         https://bugs.webkit.org/show_bug.cgi?id=131841
1231
1232         Reviewed by Gyuyoung Kim.
1233
1234         * Scripts/webkitperl/FeatureList.pm:
1235
1236 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
1237
1238         [GTK] YouCompleteMe doesn't work for cmake build system.
1239         https://bugs.webkit.org/show_bug.cgi?id=131591
1240
1241         Reviewed by Martin Robinson.
1242
1243         Add cmake build system support for YouCompleteMe. It should work regardless of
1244         using make or ninja. In addition, autotools related code is removed since it's
1245         not used anymore in WebKit.
1246
1247         * Scripts/webkitdirs.pm:
1248         (generateBuildSystemFromCMakeProject):
1249         * gtk/ycm_extra_conf.py:
1250         (transform_relative_paths_to_absolute_paths):
1251         (FlagsForFile):
1252
1253 2014-04-17  Anders Carlsson  <andersca@apple.com>
1254
1255         Fix build.
1256
1257         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1258         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1259         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1260
1261 2014-04-17  Anders Carlsson  <andersca@apple.com>
1262
1263         Remove unused API enums
1264         https://bugs.webkit.org/show_bug.cgi?id=131836
1265
1266         Reviewed by Tim Horton.
1267
1268         * MiniBrowser/mac/WK2BrowserWindowController.m:
1269         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1270
1271 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
1272
1273         [Win] A few final cleanups to the DataObject classes.
1274         https://bugs.webkit.org/show_bug.cgi?id=131784
1275
1276         Reviewed by Anders Carlsson.
1277
1278         * DumpRenderTree/win/DRTDataObject.cpp:
1279         (DRTDataObject::clearData): Use 'last()' method.
1280         * DumpRenderTree/win/UIDelegate.cpp:
1281         (DRTUndoStack::pop): Use 'takeLast()' method.
1282
1283 2014-04-17  Andres Gomez  <agomez@igalia.com>
1284
1285         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1286         https://bugs.webkit.org/show_bug.cgi?id=131365
1287
1288         Reviewed by Brent Fulgham.
1289
1290         The cygwin installer is now downloading the wanted versions for
1291         the local installation given to the setup wizard.
1292
1293         * CygwinDownloader/cygwin-downloader.py:
1294         * CygwinDownloader/cygwin-downloader.zip:
1295
1296 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1297
1298         [GTK] Make run-webkit-tests always use WKTR
1299         https://bugs.webkit.org/show_bug.cgi?id=131737
1300
1301         Reviewed by Darin Adler.
1302
1303         Now that the GTK+ port only has support for WebKit2, instruct
1304         run-webkit-tests to always use WKTR. This avoids needing to pass
1305         flag "-2" every time.
1306
1307         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1308         (_set_up_derived_options): Always set webkit_test_runner when
1309         the platform is GTK+.
1310
1311 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1312
1313         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1314         https://bugs.webkit.org/show_bug.cgi?id=131760
1315
1316         Reviewed by Philippe Normand.
1317
1318         * gtk/install-dependencies: Install ninja-build when it's available.
1319
1320 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1321
1322         [Win] run-javascriptcore-tests fails to run.
1323         https://bugs.webkit.org/show_bug.cgi?id=131761
1324
1325         Reviewed by Brent Fulgham.
1326
1327         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1328
1329 2014-04-16  Andres Gomez  <agomez@igalia.com>
1330
1331         [Win] Pass default parameters to cygwin setup wizard
1332         https://bugs.webkit.org/show_bug.cgi?id=131361
1333
1334         Reviewed by Brent Fulgham.
1335
1336         Added some parameters to the cygwin setup wizard so the user
1337         doesn't really have to do any interaction.
1338
1339         * CygwinDownloader/cygwin-downloader.py:
1340         * CygwinDownloader/cygwin-downloader.zip:
1341
1342 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1343
1344         [Win] Eliminate use of deleteAllValues in Windows Files
1345         https://bugs.webkit.org/show_bug.cgi?id=131631
1346
1347         Reviewed by Darin Adler.
1348
1349         Switch to std::unique_ptr for memory lifetime. Get rid of
1350         deleteAllValues now that it is no longer needed. Use ranged
1351         for loops where possible.
1352
1353         * DumpRenderTree/win/DRTDataObject.cpp:
1354         (WCEnumFormatEtc::WCEnumFormatEtc):
1355         (DRTDataObject::~DRTDataObject):
1356         (DRTDataObject::GetData):
1357         (DRTDataObject::QueryGetData):
1358         (DRTDataObject::SetData):
1359         (DRTDataObject::clearData):
1360         * DumpRenderTree/win/DRTDataObject.h:
1361         * DumpRenderTree/win/UIDelegate.cpp:
1362         (DRTUndoObject::DRTUndoObject):
1363         (DRTUndoObject::~DRTUndoObject):
1364         (DRTUndoStack::~DRTUndoStack):
1365         (DRTUndoStack::clear):
1366         (DRTUndoStack::pop):
1367         (DRTUndoManager::DRTUndoManager):
1368         (DRTUndoManager::redo):
1369         (DRTUndoManager::undo):
1370         (UIDelegate::UIDelegate):
1371         (UIDelegate::resetUndoManager):
1372         * DumpRenderTree/win/UIDelegate.h:
1373
1374 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1375
1376         [GTK] Unreviewed GTK gardening.
1377
1378         Update list of skipped unit tests:
1379
1380           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1381
1382           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1383           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1384
1385         * Scripts/run-gtk-tests:
1386         (TestRunner):
1387
1388 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1389
1390         check-webkit-style doesn't check code style in .mm or .m files
1391         https://bugs.webkit.org/show_bug.cgi?id=131708
1392
1393         Reviewed by Darin Adler.
1394
1395         * Scripts/webkitpy/style/checker.py:
1396         * Scripts/webkitpy/style/checker_unittest.py:
1397         (CheckerDispatcherDispatchTest.test_cpp_paths):
1398         (CheckerDispatcherDispatchTest.test_text_paths):
1399         Check .mm and .m files as C++.
1400
1401         * Scripts/webkitpy/style/checkers/cpp.py:
1402         (check_spacing):
1403         Add an override for our ordinary "missing spaces around =" for @synthesize,
1404         which should look like "@synthesize propertyName=_varName;"
1405
1406         Add an override for "missing space before {" for blocks' "^{".
1407
1408         Don't follow the "extra space before [" rule for Objective-C, because
1409         it breaks this rule in a multitude of ways because of method calls.
1410
1411         (check_braces):
1412         Don't complain about { not being on the end of the previous line if
1413         the previous line starts with "- (" or "+ (", which would indicate a
1414         Objective-C method definition.
1415
1416 2014-04-16  Darin Adler  <darin@apple.com>
1417
1418         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1419         https://bugs.webkit.org/show_bug.cgi?id=131735
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1424         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1425         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1426         way, but gtest works better this way.
1427
1428 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1429
1430         [EFL] Fix problems with the pixel dump.
1431         https://bugs.webkit.org/show_bug.cgi?id=131265
1432
1433         Reviewed by Gyuyoung Kim.
1434
1435         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1436         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1437         which causes that nothing is drawn.
1438
1439         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1440         One of new functions is AcceleratedCompositingContext::extractImageData(),
1441         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1442         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1443
1444         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1445         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1446
1447 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1448
1449         Update LLVM export scrpt to handle the build directory being different from the
1450         source directory.
1451
1452         Rubber stamped by Geoffrey Garen.
1453
1454         * Scripts/export-llvm-build:
1455
1456 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1457
1458         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1459         https://bugs.webkit.org/show_bug.cgi?id=131695
1460
1461         Reviewed by Antti Koivisto.
1462
1463         Updated.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1466
1467 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1468
1469         [GTK] Reduce the binary size by compressing the text based web inspector resources
1470         https://bugs.webkit.org/show_bug.cgi?id=121545
1471
1472         Reviewed by Gustavo Noronha Silva.
1473
1474         Compress text based files when compiling inspector resources. It
1475         reduces the binary size in 3MB.
1476
1477         * gtk/generate-inspector-gresource-manifest.py:
1478         (find_all_files_in_directory):
1479         (is_compressible):
1480
1481 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1482
1483         Remove Gtk WebKit1 tester.
1484
1485         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1486         results over and over as fast as it could.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1489         (WebKitBuildbot):
1490
1491 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1492
1493         Wrong link for webkitpy tests results in dashboard popover
1494         https://bugs.webkit.org/show_bug.cgi?id=131664
1495
1496         Reviewed by Timothy Hatcher.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1499         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1500         Use a correct link.
1501
1502 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1503
1504         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1505
1506         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1507
1508         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1509         (CommitMessageForThisCommitTest):
1510
1511 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1512
1513         Fix commit-log-editor bug revealed by r165447
1514         https://bugs.webkit.org/show_bug.cgi?id=130676
1515
1516         Reviewed by Csaba Osztrogonác.
1517
1518         * Scripts/commit-log-editor:
1519         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1520         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1521         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1522         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1523
1524 2014-04-13  Darin Adler  <darin@apple.com>
1525
1526         userVisibleString should not try to "encode" host names
1527         https://bugs.webkit.org/show_bug.cgi?id=131587
1528         rdar://problem/14686849
1529
1530         Reviewed by Alexey Proskuryakov.
1531
1532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1533
1534         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1535         Coverage is tiny at this point; we could add a lot more cases!
1536
1537 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1538
1539         Use #include instead of #import
1540         https://bugs.webkit.org/show_bug.cgi?id=131604
1541
1542         Reviewed by Darin Adler.
1543
1544         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1545
1546         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1547
1548 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1549
1550         Make slow-stress tests run faster by running fewer VM variants.
1551
1552         Rubber stamped by Geoffrey Garen.
1553
1554         * Scripts/run-javascriptcore-tests:
1555         * Scripts/run-jsc-stress-tests:
1556
1557 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1558
1559         [CMake] Add missing WTF unit tests
1560         https://bugs.webkit.org/show_bug.cgi?id=131459
1561
1562         Reviewed by Martin Robinson.
1563
1564         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1565         that should be compiled into the TestWTF binary.
1566
1567 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1568
1569         [Gtk] run-launcher doesn't work by default
1570         https://bugs.webkit.org/show_bug.cgi?id=131494
1571
1572         Reviewed by Philippe Normand.
1573
1574         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1575         * Scripts/webkitdirs.pm:
1576         (launcherName): Same.
1577         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1578         * gtk/common.py:
1579         (get_build_path.is_valid_build_directory): Same.
1580         * gtk/manifest.txt: Same.
1581
1582 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1583
1584         Unreviewed, rolling out r167046.
1585         https://bugs.webkit.org/show_bug.cgi?id=131479
1586
1587         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1588         on #webkit).
1589
1590         Reverted changeset:
1591
1592         "Remove "System Font" from whitelisted DRT fonts and char
1593         width calculations"
1594         https://bugs.webkit.org/show_bug.cgi?id=131411
1595         http://trac.webkit.org/changeset/167046
1596
1597 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1598
1599         Remove "System Font" from whitelisted DRT fonts and char width calculations
1600         https://bugs.webkit.org/show_bug.cgi?id=131411
1601
1602         Reviewed by Tim Horton.
1603
1604         Covered by existing tests.
1605
1606         * DumpRenderTree/mac/DumpRenderTree.mm:
1607         (allowedFontFamilySet):
1608
1609 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1610
1611         systemHiddenFontFamilySet in DRT is unnecessary
1612         https://bugs.webkit.org/show_bug.cgi?id=131414
1613
1614         Reviewed by Tim Horton.
1615
1616         It doesn't seem to affect test results on my machine.
1617
1618         * DumpRenderTree/mac/DumpRenderTree.mm:
1619         (drt_NSFontManager_availableFonts):
1620         (systemHiddenFontFamilySet): Deleted.
1621
1622 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1623
1624         [Win] Unreviewed test fix: Don't double-release BSTR.
1625
1626         * DumpRenderTree/win/DumpRenderTree.cpp:
1627         (dump): Remove unneeded call to SysFreeString now that we are
1628         using _bstr_t for this variable.
1629
1630 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1631
1632         [Win] Various DumpRenderTree Fixes.
1633         https://bugs.webkit.org/show_bug.cgi?id=131446.
1634
1635         Reviewed by Tim Horton.
1636
1637         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1638         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1639         (AccessibilityUIElement::description): Ditto.
1640         (AccessibilityUIElement::helpText): Ditto.
1641         (AccessibilityUIElement::intValue): Ditto.
1642         (AccessibilityUIElement::isPressActionSupported): Ditto.
1643         (AccessibilityUIElement::accessibilityValue): Ditto.
1644         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1645         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1646         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1647         (DRTDesktopNotificationPresenter::Release): Ditto.
1648         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1649         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1650         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1651         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1652         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1653         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1654         * DumpRenderTree/win/DumpRenderTree.cpp:
1655         (dumpFrameScrollPosition): Ditto.
1656         (dumpFramesAsText): Ditto.
1657         (compareHistoryItems): Ditto.
1658         (dumpHistoryItem): Ditto.
1659         (dump): Ditto.
1660         (resetDefaultsToConsistentValues): Ditto.
1661         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1662         (runTest): Ditto.
1663         (createWebViewAndOffscreenWindow): Ditto.
1664         * DumpRenderTree/win/EditingDelegate.cpp:
1665         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1666         (EditingDelegate::AddRef): Ditto.
1667         (EditingDelegate::Release): Ditto.
1668         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1669         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1670         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1671         (EditingDelegate::shouldInsertNode): Ditto.
1672         (EditingDelegate::shouldInsertText): Ditto.
1673         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1674         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1675         (EditingDelegate::shouldApplyStyle): Ditto.
1676         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1677         (EditingDelegate::doPlatformCommand): Ditto.
1678         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1679         (EditingDelegate::webViewDidChange): Ditto.
1680         (EditingDelegate::webViewDidEndEditing): Ditto.
1681         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1682         (EditingDelegate::webViewDidChangeSelection): Ditto.
1683         (EditingDelegate::checkSpellingOfString): Ditto.
1684         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1685         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1686         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1687         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1688         (FrameLoadDelegate::AddRef): Ditto.
1689         (FrameLoadDelegate::Release): Ditto.
1690         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1691         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1692         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1693         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1694         (FrameLoadDelegate::didReceiveTitle): Ditto.
1695         (FrameLoadDelegate::didChangeIcons): Ditto.
1696         (delegatesWithDelayedWork): Ditto.
1697         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1698         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1699         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1700         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1701         (FrameLoadDelegate::willCloseFrame): Ditto.
1702         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1703         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1704         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1705         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1706         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1707         * DumpRenderTree/win/FrameLoadDelegate.h:
1708         * DumpRenderTree/win/HistoryDelegate.cpp:
1709         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1710         (HistoryDelegate::updateHistoryTitle): Ditto.
1711         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1712         * DumpRenderTree/win/PolicyDelegate.cpp:
1713         (dumpPath):
1714         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1715         (PolicyDelegate::AddRef): Ditto.
1716         (PolicyDelegate::Release): Ditto.
1717         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1718         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1719         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1720         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1721         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1722         (ResourceLoadDelegate::AddRef): Ditto.
1723         (ResourceLoadDelegate::Release): Ditto.
1724         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1725         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1726         (ResourceLoadDelegate::willSendRequest): Ditto.
1727         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1728         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1729         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1730         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1731         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1732         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1733         (TestRunner::setUserStyleSheetLocation): Ditto.
1734         (TestRunner::execCommand): Ditto.
1735         (TestRunner::overridePreference): Ditto.
1736         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1737         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1738         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1739         (TextInputController::insertText): Ditto.
1740         * DumpRenderTree/win/UIDelegate.cpp:
1741         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1742         (UIDelegate::AddRef): Ditto.
1743         (UIDelegate::Release): Ditto.
1744         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1745         (UIDelegate::trackCustomPopupMenu): Ditto.
1746         (UIDelegate::registerUndoWithTarget): Ditto.
1747         (UIDelegate::removeAllActionsWithTarget): Ditto.
1748         (UIDelegate::setActionTitle): Ditto.
1749         (UIDelegate::undo): Ditto.
1750         (UIDelegate::redo): Ditto.
1751         (UIDelegate::canUndo): Ditto.
1752         (UIDelegate::canRedo): Ditto.
1753         (UIDelegate::printFrame): Ditto.
1754         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1755         (UIDelegate::webViewHeaderHeight): Ditto.
1756         (UIDelegate::webViewFooterHeight): Ditto.
1757         (UIDelegate::drawHeaderInRect): Ditto.
1758         (UIDelegate::drawFooterInRect): Ditto.
1759         (UIDelegate::webViewPrintingMarginRect): Ditto.
1760         (UIDelegate::canRunModal): Ditto.
1761         (UIDelegate::createModalDialog): Ditto.
1762         (UIDelegate::runModal): Ditto.
1763         (UIDelegate::isMenuBarVisible): Ditto.
1764         (UIDelegate::setMenuBarVisible): Ditto.
1765         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1766         (UIDelegate::paintCustomScrollbar): Ditto.
1767         (UIDelegate::paintCustomScrollCorner): Ditto.
1768         (UIDelegate::setFrame): Ditto.
1769         (UIDelegate::webViewFrame): Ditto.
1770         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1771         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1772         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1773         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1774         (UIDelegate::webViewAddMessageToConsole): Ditto.
1775         (UIDelegate::doDragDrop): Ditto.
1776         (UIDelegate::webViewGetDlgCode): Ditto.
1777         (UIDelegate::createWebViewWithRequest): Ditto.
1778         (UIDelegate::webViewClose): Ditto.
1779         (UIDelegate::webViewFocus): Ditto.
1780         (UIDelegate::webViewUnfocus): Ditto.
1781         (UIDelegate::webViewPainted): Ditto.
1782         (UIDelegate::exceededDatabaseQuota): Ditto.
1783         (UIDelegate::embeddedViewWithArguments): Ditto.
1784         (UIDelegate::webViewClosing): Ditto.
1785         (UIDelegate::webViewSetCursor): Ditto.
1786         (UIDelegate::webViewDidInvalidate): Ditto.
1787         (UIDelegate::setStatusText): Ditto.
1788         (UIDelegate::desktopNotificationsDelegate): Ditto.
1789         (UIDelegate::drawBackground): Ditto.
1790         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1791         (UIDelegate::didPressMissingPluginButton): Ditto.
1792         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1793         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1794         (LoadHTMLStringItem::invoke): Ditto.
1795         (ScriptItem::invoke): Ditto.
1796
1797 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1798
1799         Stylechecker: False positive on inline asm code.
1800         https://bugs.webkit.org/show_bug.cgi?id=130570
1801
1802         Reviewed by Csaba Osztrogonác.
1803
1804         Disable stylechecking in asm blocks.
1805
1806         * Scripts/webkitpy/style/checkers/cpp.py:
1807         (process_line):
1808         (_InlineASMState):
1809         (_InlineASMState.__init__):
1810         (_InlineASMState.process_line):
1811         (_InlineASMState.isInside):
1812         (_process_lines):
1813         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1814         (WebKitStyleTest.test_member_initialization_list):
1815
1816 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1817
1818         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1819         https://bugs.webkit.org/show_bug.cgi?id=131029
1820
1821         Reviewed by Philippe Normand.
1822
1823         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1824         tests and remove the getWebKit1TestResoucesDir() method.
1825
1826         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1827         (testDownloadLocalFile): Use Test::getResourcesDir().
1828         (testDownloadLocalFileError): Ditto.
1829         (serverCallback): Ditto.
1830         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1831         (serverCallback): Ditto.
1832         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1833         (httpServerCallback): Ditto.
1834         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1835         (serverCallback): Ditto.
1836         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1837         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1838         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1839         (Test::getWebKit1TestResoucesDir): Deleted.
1840
1841 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1842
1843         [WK2] HTTP authentication regression tests fail
1844         https://bugs.webkit.org/show_bug.cgi?id=81627
1845         <rdar://problem/11079296>
1846
1847         Reviewed by Anders Carlsson.
1848
1849         * WebKitTestRunner/TestController.h:
1850         * WebKitTestRunner/TestController.cpp:
1851         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1852         to pageLoaderClient structure.
1853         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1854         for password based authentication (we do get server trust challenges on some tests,
1855         which WKTR can't handle).
1856         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1857         calls won't be made, at least on CFNetwork based platforms.
1858         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1859         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1860         make sense to associate auth requests with individual resources - there can be
1861         multiple resources loading at once from the same protection space, so WebKit1 API
1862         that had a resource identifier was inherently racy.
1863
1864 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1865
1866         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1867         https://bugs.webkit.org/show_bug.cgi?id=131427
1868
1869         Reviewed by Gyuyoung Kim.
1870
1871         Since r166973, font path was changed.
1872
1873         * DumpRenderTree/PlatformEfl.cmake:
1874         * WebKitTestRunner/PlatformEfl.cmake:
1875
1876 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1877
1878         Fix the build-jsc build
1879         https://bugs.webkit.org/show_bug.cgi?id=131410
1880
1881         Reviewed by Michael Saboff.
1882
1883         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1884         WTF depends on it.
1885
1886 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1887
1888         [GTK] Remove WebKit1 unit tests
1889         https://bugs.webkit.org/show_bug.cgi?id=131359
1890
1891         Reviewed by Anders Carlsson.
1892
1893         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1894         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1895         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1896
1897         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1898         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1899         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1900         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1901         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1902         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1903         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1904         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1905         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1906         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1907         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1908         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1909         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1910         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1911         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1912         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1913         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1914         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1915         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1916         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1917         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1918         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1919         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1920         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1921         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1922         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1923         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1924         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1925         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1926         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1927         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1928         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1929         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1930         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1931         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1932         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1933         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1934         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1935
1936 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1937
1938         Unreviewed gardening (Take 2): Prevent users from attempting
1939         to build with known invalid cURL. 
1940
1941         * Scripts/webkitdirs.pm:
1942         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1943         7.33.0 (the known good version).
1944
1945 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1946
1947         [GTK] Remove DumpRenderTree and GtkLauncher
1948         https://bugs.webkit.org/show_bug.cgi?id=131373
1949
1950         Reviewed by Andreas Kling.
1951
1952         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1953         no longer necessary now that WebKit1 GTK+ will be removed.
1954
1955         * CMakeLists.txt:
1956         * DumpRenderTree/PlatformGTK.cmake: Removed.
1957         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1958         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1959         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1960         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1961         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1962         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1963         * DumpRenderTree/gtk/EventSender.h: Removed.
1964         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1965         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1966         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1967         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1968         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1969         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1970         * DumpRenderTree/gtk/TextInputController.h: Removed.
1971         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1972         * GtkLauncher/CMakeLists.txt: Removed.
1973         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1974         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1975         * GtkLauncher/main.c: Removed.
1976         * GtkLauncher/simple.svg: Removed.
1977         * GtkLauncher/text.html: Removed.
1978         * WebKitTestRunner/PlatformGTK.cmake:
1979         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1980         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1981         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1982
1983 2014-04-08  Mark Rowe  <mrowe@apple.com>
1984
1985         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1986         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1987
1988         Reviewed by Alexey Proskuryakov.
1989
1990         * Scripts/webkitdirs.pm:
1991         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1992         (execMacWebKitAppForDebugging): Ditto.
1993
1994 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1995
1996         Build bmalloc on iOS too
1997         https://bugs.webkit.org/show_bug.cgi?id=131381
1998
1999         Reviewed by Andreas Kling.
2000
2001         * Scripts/build-webkit:
2002
2003 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2004
2005         Unreviewed gardening: Prevent users from attempting
2006         to build with known invalid cURL.
2007
2008         * Scripts/webkitdirs.pm:
2009         (checkInstalledTools): Block build attempts with bad
2010         Cygwin tool set.
2011
2012 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2013
2014         Build bmalloc on Mac
2015         https://bugs.webkit.org/show_bug.cgi?id=131333
2016
2017         Reviewed by Mark Rowe.
2018
2019         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2020         (Note: Just testing Mac is not good enough because in this
2021         script 'Mac' means 'Mac or iOS'.)
2022
2023 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2024
2025         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2026         https://bugs.webkit.org/show_bug.cgi?id=130951
2027
2028         Reviewed by Geoffrey Garen.
2029
2030         * Scripts/run-javascriptcore-tests:
2031
2032 2014-04-06  Darin Adler  <darin@apple.com>
2033
2034         Rework CSS calc logic, fixing some reference count mistakes in Length
2035         https://bugs.webkit.org/show_bug.cgi?id=131280
2036
2037         Reviewed by Andreas Kling.
2038
2039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
2040         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
2041
2042 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
2043
2044         Enable WEB_REPLAY for PLATFORM(MAC)
2045         https://bugs.webkit.org/show_bug.cgi?id=130700
2046
2047         Reviewed by Timothy Hatcher.
2048
2049         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
2050
2051 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2052
2053         [CMake] Include X11's include dirs in TestNetscapePlugin
2054         https://bugs.webkit.org/show_bug.cgi?id=131270
2055
2056         Reviewed by Martin Robinson.
2057
2058         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
2059         TestNetscapePlugin includes WebCore code that includes X headers.
2060
2061 2014-04-05  David Kilzer  <ddkilzer@apple.com>
2062
2063         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
2064         <http://webkit.org/b/130986>
2065
2066         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
2067         prefix to TileCache class names in exception list.
2068
2069 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2070
2071         [GTK] kill-old-processes should kill dbus-daemon processes
2072         https://bugs.webkit.org/show_bug.cgi?id=127352
2073
2074         Reviewed by Martin Robinson.
2075
2076         * BuildSlaveSupport/kill-old-processes:
2077         (main):
2078
2079 2014-04-04  Andres Gomez  <agomez@igalia.com>
2080
2081         [Win] Update obsolete packages in cygwin
2082         https://bugs.webkit.org/show_bug.cgi?id=126264
2083
2084         Reviewed by Brent Fulgham.
2085
2086         Removed "apache" and "minires" as the first has been replaced by
2087         "lighttpd" and the second is now integrated into
2088         "cygwin". Replaced the transitional and now obsolete "gcc" package
2089         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
2090         since the newer version available is "2.7.3" which breaks the
2091         build due to some funniness with environment variable handling.
2092
2093         * CygwinDownloader/cygwin-downloader.py:
2094         * CygwinDownloader/cygwin-downloader.zip:
2095
2096 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
2097
2098         check-webkit-style: Improve warnings on Objective-C @property syntax
2099         https://bugs.webkit.org/show_bug.cgi?id=131200
2100
2101         Reviewed by Dan Bernstein.
2102
2103         * Scripts/webkitpy/style/checkers/cpp.py:
2104         (check_spacing):
2105         (CppChecker):
2106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2107         (CppStyleTest.test_spacing_in_objective_c_properties):
2108
2109 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2110
2111         Unreviewed. Moving my name to commiter section
2112
2113         * Scripts/webkitpy/common/config/contributors.json:
2114
2115 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
2116
2117         Unreviewed. Add myself as a committer.
2118
2119         * Scripts/webkitpy/common/config/contributors.json:
2120
2121 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
2122
2123         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
2124         https://bugs.webkit.org/show_bug.cgi?id=130391
2125
2126         Reviewed by Gyuyoung Kim.
2127
2128         Change the implementation of the zoom functionality from ewk_view_scale_set
2129         to ewk_view_page_zoom_set.
2130
2131         * MiniBrowser/efl/main.c:
2132
2133 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2134
2135         [webkitpy] perf profiler does not understand --call-graph argument
2136         https://bugs.webkit.org/show_bug.cgi?id=131132
2137
2138         Reviewed by Ryosuke Niwa.
2139
2140         New versions of perf profiler have changed the argument from --call-graph to -g.
2141
2142         * Scripts/webkitpy/common/system/profiler.py:
2143         (Perf.wrapper_arguments): Use -g instead of --call-graph.
2144         * Scripts/webkitpy/port/driver_unittest.py:
2145         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
2146
2147 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2148
2149         Add EFL WK2 performance bot to build.webkit.org
2150         https://bugs.webkit.org/show_bug.cgi?id=131034
2151
2152         Fix after r166707, use "Perf" instead of "perf" for consistency.
2153
2154         Reviewed by Csaba Osztrogonác.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/config.json:
2157
2158 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2159
2160         Add EFL WK2 performance bot to build.webkit.org
2161         https://bugs.webkit.org/show_bug.cgi?id=131034
2162
2163         Reviewed by Csaba Osztrogonác.
2164
2165         * BuildSlaveSupport/build.webkit.org-config/config.json:
2166
2167 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
2168
2169         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
2170         https://bugs.webkit.org/show_bug.cgi?id=131151
2171
2172         Reviewed by Gyuyoung Kim.
2173
2174         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
2175         (TouchEventInfo::TouchEventInfo):
2176         (sendTouchEvent):
2177         (addTouchPointCallback):
2178         (updateTouchPointCallback):
2179         (cancelTouchPointCallback):
2180         (releaseTouchPointCallback):
2181
2182 2014-04-02  David Kilzer  <ddkilzer@apple.com>
2183
2184         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
2185         <http://webkit.org/b/131045>
2186
2187         Reviewed by Daniel Bates.
2188
2189         * Scripts/filter-build-webkit:
2190         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
2191         of clang, plus debug data for all DVTAssertions.
2192
2193 2014-04-01  Dean Jackson  <dino@apple.com>
2194
2195         Load Media Controls js/css from bundle
2196         https://bugs.webkit.org/show_bug.cgi?id=131086
2197
2198         Reviewed by Eric Carlson.
2199
2200         We're now putting CSS files into the bundle, so remove the test for them.
2201
2202         * Scripts/check-for-inappropriate-files-in-framework:
2203
2204 2014-04-02  Martin Hock  <mhock@apple.com>
2205
2206         Unify private browsing with sessions.
2207         https://bugs.webkit.org/show_bug.cgi?id=130099
2208
2209         Reviewed by Alexey Proskuryakov.
2210
2211         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
2212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2213         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2214         (TestWebKitAPI::didNavigateWithNavigationData):
2215         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2216         (TestWebKitAPI::TEST):
2217
2218         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
2219         (TestWebKitAPI::didNavigateWithoutNavigationData):
2220         (TestWebKitAPI::didNavigateWithNavigationData):
2221         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2222         (TestWebKitAPI::TEST):
2223
2224 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
2225
2226         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
2227         https://bugs.webkit.org/show_bug.cgi?id=130343
2228
2229         Reviewed by Gustavo Noronha Silva.
2230
2231         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
2232         of directories on the command line and look for all appropriate files in those directories for the
2233         GResource archive. Also make archive paths relative to those directories.
2234         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
2235         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
2236
2237 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2238
2239         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
2240         https://bugs.webkit.org/show_bug.cgi?id=131106
2241
2242         Reviewed by Csaba Osztrogonác.
2243
2244         * Scripts/webkitpy/tool/commands/download.py:
2245         (AbstractRolloutPrepCommand._prepare_state):
2246         * Scripts/webkitpy/tool/commands/download_unittest.py:
2247         (test_prepare_rollout):
2248         (test_create_rollout):
2249         (test_create_rollout_resolved):
2250         (test_rollout):
2251
2252 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
2253
2254         [EFL] Add option to use separate web process for new window in MiniBrowser
2255         https://bugs.webkit.org/show_bug.cgi?id=130190
2256
2257         Reviewed by Gyuyoung Kim.
2258
2259         New created window (CTRL + n) will be open in separated web process.
2260         This option is enabled by adding a flag (S/separate-process) with launching
2261         MiniBrowser.
2262
2263         * MiniBrowser/efl/main.c:
2264         (elm_main):
2265
2266 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [GTK] Move NEWS file to a new location
2269         https://bugs.webkit.org/show_bug.cgi?id=130901
2270
2271         Reviewed by Brent Fulgham.
2272
2273         * gtk/manifest.txt: Update the NEWS file path.
2274
2275 2014-04-01  Anders Carlsson  <andersca@apple.com>
2276
2277         Fix build.
2278
2279         * MiniBrowser/mac/WK2BrowserWindowController.m:
2280         (-[WK2BrowserWindowController awakeFromNib]):
2281         (-[WK2BrowserWindowController dealloc]):
2282         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2283
2284 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2285
2286         Unreviewed test gardening.
2287
2288         * Scripts/webkitpy/port/base_unittest.py:
2289         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2290
2291 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2292
2293         [CSS Exclusions] Remove exclusions parsing support
2294         https://bugs.webkit.org/show_bug.cgi?id=131046
2295
2296         Reviewed by David Hyatt.
2297
2298         * Scripts/webkitperl/FeatureList.pm:
2299
2300 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2301
2302         [GTK] Remove last reference to GTK+ WK1 EWS
2303         https://bugs.webkit.org/show_bug.cgi?id=131058
2304
2305         Reviewed by Martin Robinson.
2306
2307         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2308
2309         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2310
2311 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2312
2313         Add a 32bit JSC builder/tester.
2314         https://bugs.webkit.org/show_bug.cgi?id=131054
2315         
2316         Reviewed by Michael Saboff.
2317
2318         * BuildSlaveSupport/build.webkit.org-config/config.json:
2319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2320         (Compile32bitJSC):
2321         (Run32bitJSCTests):
2322         (Run32bitJSCTests.countFailures):
2323         (BuildAndTest32bitJSCFactory):
2324         (BuildAndTest32bitJSCFactory.__init__):
2325
2326 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2327
2328         [GTK] No longer build WebKit1 gtkdoc
2329         https://bugs.webkit.org/show_bug.cgi?id=130970
2330
2331         Reviewed by Anders Carlsson.
2332
2333         * gtk/common.py:
2334         (gtk_version_of_pkg_config_file): Deleted.
2335         * gtk/generate-gtkdoc:
2336         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2337         was only applicable for WebKit1.
2338         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2339
2340 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2341
2342         [GTK] Running minibrowser with url crashes in debug build
2343         https://bugs.webkit.org/show_bug.cgi?id=130492
2344
2345         Reviewed by Martin Robinson.
2346
2347         Update "uri-scheme" test not to use invalid URIs in it, so we
2348         don't get a mistmatch when comparing the original URI stored in
2349         the test class with the one returned by the WebKitWebView.
2350
2351         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2352         (testWebContextURIScheme): Update the test.
2353
2354 2014-04-01  Mihai Tica  <mitica@adobe.com>
2355
2356         Unreviewed: Add myself as a commiter to the contributors list.
2357
2358         * Scripts/webkitpy/common/config/contributors.json:
2359
2360 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2361
2362         [EFL][WK2] Extract the control of page background out of color_set
2363         https://bugs.webkit.org/show_bug.cgi?id=127539
2364
2365         Reviewed by Gyuyoung Kim.
2366
2367         Added an option(C) to change background color.
2368
2369         * MiniBrowser/efl/main.c:
2370         (window_create):
2371         (elm_main):
2372
2373 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2374
2375         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2376
2377         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2378
2379 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2380
2381         Unreviewed test correction after r166530.
2382
2383         * DumpRenderTree/mac/DumpRenderTree.mm:
2384         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2385         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2386
2387 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2388
2389         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2390         https://bugs.webkit.org/show_bug.cgi?id=130987
2391
2392         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2393         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2394
2395         Reviewed by Martin Robinson.
2396
2397         * BuildSlaveSupport/build.webkit.org-config/config.json:
2398
2399 2014-03-31  Dean Jackson  <dino@apple.com>
2400
2401         Remove WEB_ANIMATIONS
2402         https://bugs.webkit.org/show_bug.cgi?id=130989
2403
2404         Reviewed by Simon Fraser.
2405
2406         Remove this feature flag until we plan to implement.
2407
2408         * Scripts/webkitperl/FeatureList.pm:
2409
2410 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2411
2412         Reduced Latched Scroll Test Flakiness
2413         https://bugs.webkit.org/show_bug.cgi?id=130983
2414
2415         Reviewed by Darin Adler.
2416
2417         * DumpRenderTree/mac/DumpRenderTree.mm:
2418         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2419         * DumpRenderTree/mac/EventSendingController.mm:
2420         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2421         with high resolution flags turned on.
2422         * WebKitTestRunner/mac/EventSenderProxy.mm:
2423         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2424
2425 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2426
2427         run-webkit-tests should have a --no-timeout option
2428         https://bugs.webkit.org/show_bug.cgi?id=128286
2429
2430         Reviewed by Joseph Pecoraro.
2431
2432         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2433         (Worker._run_test): Renaming _run_test_with_timeout()
2434         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2435         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2436         (Worker._run_test_in_this_thread):
2437         (Worker._run_test_with_timeout): Deleted.
2438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2439         (parse_args): Added the --no-timeout option
2440
2441 2014-03-31  Samuel White  <samuel_white@apple.com>
2442
2443         AX: Need ability to get line range for text marker.
2444         https://bugs.webkit.org/show_bug.cgi?id=130906
2445
2446         Reviewed by Chris Fleizach.
2447
2448         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2449
2450         * DumpRenderTree/AccessibilityUIElement.cpp:
2451         (lineTextMarkerRangeForTextMarkerCallback):
2452         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2453         (AccessibilityUIElement::getJSClass):
2454         * DumpRenderTree/AccessibilityUIElement.h:
2455         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2456         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2457         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2458         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2459         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2460         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2461         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2462         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2463         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2464         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2465         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2466         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2467
2468 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2469
2470         More validation for FTL inline caches
2471         https://bugs.webkit.org/show_bug.cgi?id=130948
2472
2473         Reviewed by Geoffrey Garen.
2474
2475         * Scripts/run-jsc-stress-tests:
2476
2477 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2478
2479         [GTK] Do not run WebKit1 unit tests by default
2480         https://bugs.webkit.org/show_bug.cgi?id=130968
2481
2482         Reviewed by Martin Robinson.
2483
2484         * Scripts/run-gtk-tests:
2485         (TestRunner):
2486
2487 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2488
2489         [GTK] Remove scripts code only applicable to autotools
2490         https://bugs.webkit.org/show_bug.cgi?id=130841
2491
2492         Reviewed by Anders Carlsson.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2495         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2496         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2497         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2498         * gtk/find-make-dist-errors: Removed.
2499         * gtk/generate-feature-defines-files: Removed.
2500         * gtk/manifest.txt: No longer need to consider autotools files.
2501
2502 2014-03-30  Andy Estes  <aestes@apple.com>
2503
2504         Fix two failing layout tests on Mountain Lion after r166466.
2505
2506         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2507         (-[DownloadDelegate _downloadDidStart:]):
2508
2509 2014-03-30  Andy Estes  <aestes@apple.com>
2510
2511         [Cocoa] Add an originatingWebView property to _WKDownload
2512         https://bugs.webkit.org/show_bug.cgi?id=130945
2513
2514         Reviewed by Anders Carlsson.
2515
2516         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2517         (-[DownloadDelegate _downloadDidStart:]):
2518         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2519         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2520         (TEST):
2521
2522 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2523
2524         Land the stackmap register liveness glue with the uses of the liveness disabled
2525         https://bugs.webkit.org/show_bug.cgi?id=130924
2526
2527         Reviewed by Oliver Hunt.
2528
2529         * Scripts/run-jsc-stress-tests:
2530
2531 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2532
2533         Update WebKit1.StringTruncator for Mountain Lion.
2534
2535         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2536         due to different font metrics on 10.8.
2537
2538 2014-03-28  Darin Adler  <darin@apple.com>
2539
2540         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2541         https://bugs.webkit.org/show_bug.cgi?id=130889
2542
2543         Reviewed by Alexey Proskuryakov.
2544
2545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2546         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2547         WebStringTruncator methods; should be good for a start. These are dependent on the
2548         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2549
2550 2014-03-28  Martin Hock  <mhock@apple.com>
2551
2552         Unreviewed. Add myself as a committer.
2553
2554         * Scripts/webkitpy/common/config/contributors.json:
2555
2556 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2557
2558         Remove WebKit1 GTK+ bots
2559         https://bugs.webkit.org/show_bug.cgi?id=130904
2560
2561         Reviewed by Anders Carlsson.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2564         all bots are testing WebKit2 only.
2565         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2566         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2567         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2568         * Scripts/webkitpy/port/builders.py: Ditto.
2569         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2570         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2571
2572 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2573
2574         Remove Brian Burg's apple.com email address.
2575
2576         * Scripts/webkitpy/common/config/contributors.json:
2577
2578 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2579
2580         bisect-builds should print Trac 'changeset' URL if only one build is detected
2581         <http://webkit.org/b/130903>
2582
2583         Reviewed by Dan Bernstein.
2584
2585         * Scripts/bisect-builds:
2586         (printTracLink): Print a direct link to the Trac 'changeset'
2587         URL if there is only one revision in the range.
2588
2589 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2590
2591         [EFL] Bump glib version from 2.36 to 2.38 
2592         https://bugs.webkit.org/show_bug.cgi?id=130886
2593
2594         Reviewed by Csaba Osztrogonác.
2595
2596         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2597         we need to bump glib version up to 2.38 as gtk port.
2598
2599         * efl/jhbuild.modules:
2600
2601 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2602
2603         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2604
2605         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2606         the globalhistory directory.
2607
2608         Reviewed by Sam Weinig.
2609
2610         * WebKitTestRunner/TestController.cpp:
2611         (WTR::TestController::TestController):
2612         (WTR::TestController::initialize): Set the history client.
2613         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2614         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2615         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2616         and we don't yet have API to access the data in question.
2617         (WTR::TestController::didPerformClientRedirect):
2618         (WTR::TestController::didPerformServerRedirect):
2619         (WTR::TestController::didUpdateHistoryTitle):
2620         * WebKitTestRunner/TestController.h:
2621         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2622         * WebKitTestRunner/TestInvocation.cpp:
2623         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2624         (WTR::TestInvocation::invoke):
2625
2626 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2627
2628         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2629
2630         * Scripts/build-webkit:
2631         * Scripts/copy-webkitlibraries-to-product-directory:
2632
2633 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2634
2635         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2636         https://bugs.webkit.org/show_bug.cgi?id=130867
2637         <rdar://problem/16432456> 
2638
2639         Reviewed by Mark Hahnenberg.
2640
2641         * Scripts/build-webkit:
2642         * Scripts/copy-webkitlibraries-to-product-directory:
2643
2644 2014-03-26  Andy Estes  <aestes@apple.com>
2645
2646         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2647         https://bugs.webkit.org/show_bug.cgi?id=130805
2648
2649         Reviewed by Dan Bernstein.
2650
2651         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2652         (-[DownloadDelegate _download:didReceiveResponse:]):
2653         (-[DownloadDelegate _downloadDidFinish:]):
2654         (runTest):
2655         (TEST):
2656         (-[FailingDownloadDelegate _downloadDidFinish:]):
2657         (-[FailingDownloadDelegate _download:didFailWithError:]):
2658         (-[FailingDownloadDelegate _downloadDidCancel:]):
2659         (-[CancelledDownloadDelegate _downloadDidStart:]):
2660         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2661         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2662         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2663         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2664         (-[DownloadDelegate sourceURL]): Deleted.
2665         (runTestWithNavigationDelegate): Deleted.
2666
2667 2014-03-26  Anders Carlsson  <andersca@apple.com>
2668
2669         Change MiniBrowser to hold on to window controllers instead of windows
2670         https://bugs.webkit.org/show_bug.cgi?id=130797
2671
2672         Reviewed by Oliver Hunt.
2673
2674         * MiniBrowser/mac/AppDelegate.h:
2675         * MiniBrowser/mac/AppDelegate.m:
2676         (-[BrowserAppDelegate init]):
2677         (-[BrowserAppDelegate newWindow:]):
2678         (-[BrowserAppDelegate browserWindowWillClose:]):
2679         (-[BrowserAppDelegate applicationWillTerminate:]):
2680         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2681
2682 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2683
2684         Unreviewed, rolling out r166264.
2685         https://bugs.webkit.org/show_bug.cgi?id=130785
2686
2687         Broke some window.opener tests for WK2 Mavericks (Requested by
2688         brrian__ on #webkit).
2689
2690         Reverted changeset:
2691
2692         "Web Replay: resource unique identifiers should be unique-per-
2693         frame, not globally"
2694         https://bugs.webkit.org/show_bug.cgi?id=130632
2695         http://trac.webkit.org/changeset/166264
2696
2697 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2698
2699         [CSS Shapes] Remove shape-inside support
2700         https://bugs.webkit.org/show_bug.cgi?id=130698
2701
2702         Reviewed by David Hyatt.
2703
2704         * Scripts/webkitperl/FeatureList.pm:
2705
2706 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2707
2708         Unreviewed. Add myself as a committer.
2709
2710         * Scripts/webkitpy/common/config/contributors.json:
2711
2712 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2713
2714         run-launcher is Perl script so use elsif and not elif
2715         https://bugs.webkit.org/show_bug.cgi?id=130771
2716
2717         Reviewed by Carlos Garcia Campos.
2718
2719         * Scripts/run-launcher:
2720
2721 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2722
2723         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2724         https://bugs.webkit.org/show_bug.cgi?id=130575
2725
2726         Reviewed by Mario Sanchez Prada.
2727
2728         Change ATK version to 2.11.92. Adjust current implementation.
2729
2730         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2731         (AccessibilityUIElement::intValue):
2732         (AccessibilityUIElement::minValue):
2733         (AccessibilityUIElement::maxValue):
2734         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2735         (WTR::AccessibilityUIElement::intValue):
2736         (WTR::AccessibilityUIElement::minValue):
2737         (WTR::AccessibilityUIElement::maxValue):
2738         * efl/jhbuild.modules:
2739         * gtk/jhbuild.modules:
2740
2741 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2742
2743         [GTK] The gnumake package is no longer needed in jhbuild
2744         https://bugs.webkit.org/show_bug.cgi?id=130121
2745
2746         Reviewed by Martin Robinson.
2747
2748         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2749         for a debug build cmake/system-gnumake worked just fine for me.
2750
2751         * gtk/jhbuild.modules: Removed gnumake.
2752         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2753         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2754
2755 2014-03-25  Andy Estes  <aestes@apple.com>
2756
2757         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2758
2759         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2760         (-[DownloadDelegate _download:didReceiveData:]):
2761         (-[DownloadDelegate _downloadDidFinish:]):
2762
2763 2014-03-25  Brian Burg  <bburg@apple.com>
2764
2765         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2766         https://bugs.webkit.org/show_bug.cgi?id=130623
2767
2768         Reviewed by Timothy Hatcher.
2769
2770         The resource loader callback dumping routines assumed that resource identifiers
2771         were globally unique. Its map of resource identifiers to URLs must also track the
2772         frame associated with the resource.
2773
2774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2775         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2776         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2777         stable as long as the frame is valid.
2778         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2779         (WTR::InjectedBundlePage::willSendRequestForFrame):
2780         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2781         (WTR::InjectedBundlePage::didFinishLoadForResource):
2782         (WTR::InjectedBundlePage::didFailLoadForResource):
2783
2784 2014-03-25  Andy Estes  <aestes@apple.com>
2785
2786         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2787
2788         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2789         (-[DownloadDelegate _download:didReceiveResponse:]):
2790         (-[DownloadDelegate _download:didReceiveData:]):
2791
2792 2014-03-25  Andy Estes  <aestes@apple.com>
2793
2794         Add some debug logging to an API test that's failing on Mountain Lion.
2795
2796         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2797         (-[DownloadDelegate _download:didReceiveResponse:]):
2798         (-[DownloadDelegate _downloadDidFinish:]):
2799
2800 2014-03-25  Anders Carlsson  <andersca@apple.com>
2801
2802         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2803         https://bugs.webkit.org/show_bug.cgi?id=130732
2804
2805         Reviewed by Tim Horton.
2806
2807         * MiniBrowser/mac/WK2BrowserWindowController.m:
2808         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2809
2810 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2811
2812         [GTK] Remove the autotools build
2813         https://bugs.webkit.org/show_bug.cgi?id=130717
2814
2815         Reviewed by Anders Carlsson.
2816
2817         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2818         * GNUmakefile.am: Removed.
2819         * GtkLauncher/GNUmakefile.am: Removed.
2820         * GtkLauncher/main.c: Remove references to the autotools configure file.
2821         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2822         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2823         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2824         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2825         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2826         * Scripts/build-webkit: No longer handle autotools.
2827         * Scripts/run-gtk-tests: Ditto.
2828         (TestRunner._setup_testing_environment):
2829         * Scripts/run-launcher: Ditto.
2830         * Scripts/webkitdirs.pm: Ditto.
2831         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2832         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2833         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2834         * Scripts/webkitpy/style/checker.py:
2835         * TestWebKitAPI/GNUmakefile.am: Removed.
2836         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2837         * WebKitTestRunner/GNUmakefile.am: Removed.
2838         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2839         * gtk/GNUmakefile.am: Removed.
2840         * gtk/common.py: Remove checks for the autotools build.
2841         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2842
2843 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2844
2845         prepare-ChangeLog throws false positive warnings for modified files.
2846         https://bugs.webkit.org/show_bug.cgi?id=130687
2847
2848         Reviewed by Darin Adler.
2849
2850         * Scripts/prepare-ChangeLog:
2851         (originalFile): Ignore git commit paremeter.
2852         We don't need this to get the unmodified file.
2853         (extractLineRangeBeforeChange):
2854         Simplify the if statement. Follow-up after r166189.
2855
2856 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2857
2858         [EFL] Add ARM64 build support
2859         https://bugs.webkit.org/show_bug.cgi?id=130506
2860
2861         Rubber stamped by Gyuyoung Kim.
2862
2863         * Scripts/webkitdirs.pm:
2864         (isARM): Detect aarch64 as ARM.
2865
2866 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2867
2868         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2869         https://bugs.webkit.org/show_bug.cgi?id=130137
2870
2871         Reviewed by Csaba Osztrogonác.
2872
2873         * Scripts/webkitpy/common/checkout/changelog.py:
2874         (ChangeLogEntry._parse_bug_description):
2875         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2876         (test_parse_log_entries_from_changelog):
2877         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2878         (CheckoutTest.test_commit_info_for_revision):
2879
2880 2014-03-24  Andy Estes  <aestes@apple.com>
2881
2882         Fix the iOS build of TestWebKitAPI.
2883
2884         * TestWebKitAPI/Configurations/Base.xcconfig:
2885         * TestWebKitAPI/PlatformUtilities.h:
2886
2887 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2888
2889         Fix prepare-ChangeLog after r166156.
2890         https://bugs.webkit.org/show_bug.cgi?id=130674
2891
2892         Reviewed by Darin Adler.
2893
2894         * Scripts/prepare-ChangeLog:
2895         (generateFunctionLists):
2896         (extractLineRangeBeforeChange):
2897
2898 2014-03-24  Andy Estes  <aestes@apple.com>
2899
2900         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2901         https://bugs.webkit.org/show_bug.cgi?id=129322
2902
2903         Reviewed by Anders Carlsson.
2904
2905         Add an API test suite for _WKDownload.
2906
2907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2908         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2909         (-[DownloadDelegate initWithSourceURL:]):
2910         (-[DownloadDelegate sourceURL]):
2911         (-[DownloadDelegate _downloadDidStart:]):
2912         (-[DownloadDelegate _download:didReceiveResponse:]):
2913         (-[DownloadDelegate _download:didReceiveData:]):
2914         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2915         (-[DownloadDelegate _downloadDidFinish:]):
2916         (TEST):
2917         (runTestWithNavigationDelegate):
2918         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2919         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2920
2921 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2922
2923         filter-build-webkit: reduce unfiltered output
2924         https://bugs.webkit.org/show_bug.cgi?id=130485
2925
2926         Reviewed by Brent Fulgham.
2927
2928         * Scripts/filter-build-webkit:
2929         (shouldIgnoreLine):
2930
2931 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2932
2933         prepare-ChangeLog should list functions that have been removed too.
2934         https://bugs.webkit.org/show_bug.cgi?id=130508
2935
2936         Reviewed by Darin Adler.
2937
2938         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2939         We have to read the functions and the line ranges of them from the source
2940         before the change, then search for overlaps between them and the changed
2941         line ranges from diff.
2942
2943         * Scripts/prepare-ChangeLog:
2944         (originalFile): Get original source command.
2945         (generateFunctionLists): Collect deleted functions too.
2946         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2947         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2948         deleted functions ranges too.
2949         (extractLineRange): Renamed to extractLineRangeAfterChange.
2950
2951 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2952
2953         Move all EFL typedefs into EflTypedefs.h.
2954         https://bugs.webkit.org/show_bug.cgi?id=130511
2955
2956         Reviewed by Gyuyoung Kim.
2957
2958         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2959         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2960         * WebKitTestRunner/PlatformWebView.h: Ditto.
2961
2962 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2963
2964         Don't flush compositing layers within FrameView::willPaintContents()
2965         https://bugs.webkit.org/show_bug.cgi?id=130627
2966         <rdar://problem/16368869>
2967
2968         Reviewed by Sam Weinig.
2969         
2970         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2971         does not flush.
2972         
2973         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2974         into an explicit function called before dumping. 
2975         
2976         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2977         are flushed to CA. They will be pushed to the window by snapshotting.
2978
2979         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2980         Fix weird path to IOKit.framework.
2981         * DumpRenderTree/mac/DumpRenderTree.mm:
2982         (updateDisplay):
2983         (dump):
2984         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2985         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2986         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2987
2988 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2989
2990         fix-blink-patch: tool to fix up renamed directory paths in Blink
2991         <http://webkit.org/b/130609>
2992
2993         Reviewed by Ryosuke Niwa.
2994
2995         Usage: cat blink.patch | fix-blink-patch | svn-apply
2996
2997         * Scripts/fix-blink-patch: Added.
2998
2999 2014-03-21  Darin Adler  <darin@apple.com>
3000
3001         Remove use of deprecatedCharacters in WebKit API tests
3002         https://bugs.webkit.org/show_bug.cgi?id=130602
3003
3004         Reviewed by Antti Koivisto.
3005
3006         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3007         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3008         (TestWebKitAPI::expectEmpty): Use characters8.
3009         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3010
3011         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3012         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3013         the deprecatedCharacters function itself, which we are about to delete.
3014
3015 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3016
3017         [webkitpy] Fix has_valid_reviewer()
3018         https://bugs.webkit.org/show_bug.cgi?id=130589
3019
3020         Reviewed by Csaba Osztrogonác.
3021
3022         * Scripts/webkitpy/common/checkout/changelog.py:
3023         (ChangeLogEntry.has_valid_reviewer):
3024         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3025         (test_has_valid_reviewer):
3026         * Scripts/webkitpy/common/config/committers.py:
3027         (CommitterList._reviewer_only):
3028         (CommitterList.committer_by_name):
3029         (CommitterList.reviewer_by_email):
3030         (CommitterList):
3031         (CommitterList.reviewer_by_name):
3032
3033 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3034
3035         Add cache support for jhbuild
3036         https://bugs.webkit.org/show_bug.cgi?id=130588
3037
3038         Reviewed by Csaba Osztrogonác.
3039
3040         * jhbuild/jhbuildrc_common.py:
3041         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
3042
3043 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3044
3045         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
3046         https://bugs.webkit.org/show_bug.cgi?id=130504
3047
3048         Reviewed by Martin Robinson.
3049
3050         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
3051         CMake if not specified.
3052         * Scripts/webkitdirs.pm:
3053         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
3054         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
3055
3056 2014-03-21  Andreas Kling  <akling@apple.com>
3057
3058         RetainPtr API test should use CFArray instead of CFString for testing.
3059         <rdar://problem/16384899>
3060
3061         Unreviewed bot fix.
3062
3063         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3064         (TestWebKitAPI::TEST):
3065         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3066         (TestWebKitAPI::TEST):
3067
3068 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
3069
3070         Move to using std::unique_ptr for EFL objects.
3071         https://bugs.webkit.org/show_bug.cgi?id=129853
3072
3073         Reviewed by Gyuyoung Kim.
3074
3075         EflUniquePtr is a template alias of std::unique_ptr
3076         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
3077         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
3078
3079         * DumpRenderTree/efl/DumpRenderTree.cpp:
3080         (main):
3081         * ImageDiff/efl/ImageDiff.cpp:
3082         (initEfl):
3083         (main):
3084
3085 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
3086
3087         Unreviewed buildfix after r165983 for non Cocoa platforms
3088
3089         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
3090
3091         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
3092         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3093         * WebKitTestRunner/TestController.cpp:
3094
3095 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
3096
3097         [GTK][CMake] Add support for building with Clang
3098         https://bugs.webkit.org/show_bug.cgi?id=130260
3099
3100         Reviewed by Martin Robinson.
3101
3102         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
3103         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
3104         included GTest framework headers.
3105         * gtk/generate-gtkdoc:
3106         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
3107         in case of using Clang since that is now set by the CMake rule.
3108
3109 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
3110
3111         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
3112         https://bugs.webkit.org/show_bug.cgi?id=130476
3113
3114         Reviewed by Anders Carlsson.
3115         
3116         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
3117
3118         * MiniBrowser/mac/WK1BrowserWindowController.m:
3119         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3120         Remove log.
3121         * MiniBrowser/mac/WK2BrowserWindowController.m:
3122         (-[WK2BrowserWindowController awakeFromNib]):
3123         (-[WK2BrowserWindowController validateMenuItem:]):
3124         (-[WK2BrowserWindowController reload:]):
3125         Hook up reload.
3126         (-[WK2BrowserWindowController toggleZoomMode:]):
3127         (-[WK2BrowserWindowController resetZoom:]):
3128         (-[WK2BrowserWindowController canResetZoom]):
3129         (-[WK2BrowserWindowController currentZoomFactor]):
3130         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3131         (-[WK2BrowserWindowController canZoomIn]):
3132         (-[WK2BrowserWindowController canZoomOut]):
3133
3134 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
3135
3136         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3137         https://bugs.webkit.org/show_bug.cgi?id=130463
3138
3139         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
3140
3141 2014-03-18  Samuel White  <samuel_white@apple.com>
3142
3143         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
3144         https://bugs.webkit.org/show_bug.cgi?id=130250
3145
3146         Reviewed by Chris Fleizach.
3147
3148         Added ability to toggle enhanced accessibility on and off to support tests that require it.
3149
3150         * DumpRenderTree/AccessibilityController.cpp:
3151         (enableEnhancedAccessibilityCallback):
3152         (getEnhancedAccessibilityEnabledCallback):
3153         (AccessibilityController::getJSClass):
3154         * DumpRenderTree/AccessibilityController.h:
3155         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3156         (AccessibilityController::enableEnhancedAccessibility):
3157         (AccessibilityController::enhancedAccessibilityEnabled):
3158         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3159         (AccessibilityController::enableEnhancedAccessibility):
3160         (AccessibilityController::enhancedAccessibilityEnabled):
3161         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3162         (AccessibilityController::enableEnhancedAccessibility):
3163         (AccessibilityController::enhancedAccessibilityEnabled):
3164         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3165         (AccessibilityController::enableEnhancedAccessibility):
3166         (AccessibilityController::enhancedAccessibilityEnabled):
3167         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3168         (WTR::AccessibilityController::enableEnhancedAccessibility):
3169         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
3170         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3171         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3172
3173 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
3174
3175         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
3176         yet).
3177
3178         * Scripts/webkitpy/common/config/contributors.json:
3179
3180 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3181
3182         Web Inspector: Remove stale ReportMemoryUsagePlugin
3183         https://bugs.webkit.org/show_bug.cgi?id=130405
3184
3185         Reviewed by Andreas Kling.
3186
3187         This clang plugin looks like it was used for the old Inspector memory
3188         instrumentation that was removed. So the tool can be removed.
3189
3190         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
3191         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
3192         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
3193         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
3194
3195 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3196
3197         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
3198         https://bugs.webkit.org/show_bug.cgi?id=130220
3199
3200         Reviewed by Csaba Osztrogonác.
3201
3202         * Scripts/webkitpy/common/checkout/changelog.py:
3203         (ChangeLog.set_reviewer):
3204         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3205         (test_set_reviewer):
3206
3207 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
3208
3209         More FTL enabling.
3210
3211         Rubber stamped by Dan Bernstein.
3212
3213         * Tools/Scripts/build-webkit:
3214
3215 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3216
3217         Renable pagination mode in WK2 MiniBrowser
3218         https://bugs.webkit.org/show_bug.cgi?id=130374
3219
3220         Reviewed by Anders Carlsson.
3221         
3222         Put the implementation of togglePaginationMode: back, and correctly
3223         enable the menu item.
3224
3225         * MiniBrowser/mac/WK2BrowserWindowController.m:
3226         (-[WK2BrowserWindowController validateMenuItem:]):
3227         (-[WK2BrowserWindowController isPaginated]):
3228         (-[WK2BrowserWindowController togglePaginationMode:]):
3229
3230 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3231
3232         Add --reset option to Tools/Scripts/set-webkit-configuration script
3233         https://bugs.webkit.org/show_bug.cgi?id=130401
3234
3235         Reviewed by Csaba Osztrogonác.
3236
3237         * Scripts/set-webkit-configuration:
3238
3239 2014-03-18  Alberto Garcia  <berto@igalia.com>
3240
3241         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
3242         https://bugs.webkit.org/show_bug.cgi?id=130388
3243
3244         Reviewed by Sergio Villar Senin.
3245
3246         * Scripts/webkitdirs.pm:
3247         (shouldRemoveCMakeCache): make sure that the build directory
3248         exists before attempting to create a file in it.
3249
3250 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
3251
3252         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
3253         https://bugs.webkit.org/show_bug.cgi?id=130336
3254
3255         Reviewed by Gyuyoung Kim.
3256
3257         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
3258         requires a space between literal and string macro [-Wliteral-suffix]'
3259         warning treated as error.
3260
3261         This patch applies a solution from r162448 to the EFL port.
3262
3263         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3264         * efl/jhbuild.modules: Added appropriate patch section.
3265
3266 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3267
3268         webkitpy test rebaseline.
3269
3270         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3271         (MainTest.test_default_args):
3272
3273 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
3274
3275         --profile should imply --test-runner-count=1 in run-perf-tests
3276         https://bugs.webkit.org/show_bug.cgi?id=130375
3277
3278         Reviewed by Benjamin Poulain.
3279
3280         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3281
3282         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3283         (PerfTestsRunner._parse_args): Use -1 as the default value.
3284         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3285         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3286         should be 1.
3287
3288 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3289
3290         Address some style nits.
3291
3292         * MiniBrowser/mac/WK2BrowserWindowController.m:
3293
3294 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3295
3296         Add transparent window support back into MiniBrowser
3297         https://bugs.webkit.org/show_bug.cgi?id=130363
3298
3299         Reviewed by Anders Carlsson.
3300         
3301         Re-enable transparent window support for WK2.
3302
3303         * MiniBrowser/mac/WK2BrowserWindowController.m:
3304         (-[WK2BrowserWindowController validateMenuItem:]):
3305         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3306
3307 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3308
3309         Fix the 32-bit build; make the open panel make a WK1 window.
3310
3311         * MiniBrowser/mac/AppDelegate.m:
3312         (-[BrowserAppDelegate openDocument:]):
3313
3314 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3315
3316         Convert MiniBrowser to use WKWebView API
3317         https://bugs.webkit.org/show_bug.cgi?id=130061
3318
3319         Reviewed by Anders Carlsson.
3320         
3321         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3322         as possible.
3323         
3324         Some functionality was removed temporarily:
3325             - text zoom, page zoom
3326             - reload
3327             - pagination mode
3328             - transparent window
3329             - dumping source
3330             - window.open support
3331             - beforeUnload panel
3332             - find in page
3333
3334         * MiniBrowser/mac/AppDelegate.h:
3335         * MiniBrowser/mac/AppDelegate.m:
3336         (-[BrowserAppDelegate init]):
3337         (-[BrowserAppDelegate newWindow:]):
3338         (-[BrowserAppDelegate applicationWillTerminate:]):
3339         (-[BrowserAppDelegate openDocument:]):
3340         * MiniBrowser/mac/WK2BrowserWindowController.h:
3341         * MiniBrowser/mac/WK2BrowserWindowController.m:
3342         (-[WK2BrowserWindowController awakeFromNib]):
3343         (-[WK2BrowserWindowController dealloc]):
3344         (-[WK2BrowserWindowController fetch:]):
3345         (-[WK2BrowserWindowController validateMenuItem:]):
3346         (-[WK2BrowserWindowController reload:]):
3347         (-[WK2BrowserWindowController goBack:]):
3348         (-[WK2BrowserWindowController goForward:]):
3349         (-[WK2BrowserWindowController toggleZoomMode:]):
3350         (-[WK2BrowserWindowController resetZoom:]):
3351         (-[WK2BrowserWindowController canResetZoom]):
3352         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3353         (-[WK2BrowserWindowController togglePaginationMode:]):
3354         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3355         (-[WK2BrowserWindowController windowShouldClose:]):
3356         (-[WK2BrowserWindowController applicationTerminating]):
3357         (-[WK2BrowserWindowController currentZoomFactor]):
3358         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3359         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3360         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3361         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3362         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3363         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3364         (-[WK2BrowserWindowController find:]):
3365         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3366         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3367         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3368         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3369         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3370         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3371         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3372         * WebKitTestRunner/PlatformWebView.h:
3373         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3374         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3375
3376 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3377
3378         Use RunLoop objects through references instead of pointers
3379         https://bugs.webkit.org/show_bug.cgi?id=130313
3380
3381         Reviewed by Andreas Kling.
3382
3383         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3384         return RunLoop reference instead of a pointer.
3385
3386         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3387         (loadedCallback):
3388         (clickedCallback):
3389
3390 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3391
3392         sort-export-file --help doesn't work (missing 'use')
3393         https://bugs.webkit.org/show_bug.cgi?id=130338
3394
3395         Reviewed by Anders Carlsson.
3396
3397         * Scripts/sort-export-file:
3398         Add a missing 'use', and fix a typo in an error message.
3399
3400 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3401
3402         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3403         https://bugs.webkit.org/show_bug.cgi?id=130155
3404
3405         Reviewed by Philippe Normand.
3406
3407         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3408
3409 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3410
3411         [GTK] MiniBrowser fails to load injected bundle lib
3412         https://bugs.webkit.org/show_bug.cgi?id=130332
3413
3414         Reviewed by Anders Carlsson.
3415
3416         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3417
3418         * MiniBrowser/gtk/main.c:
3419         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3420         process is spawn.
3421
3422 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3423
3424         [EFL] Enable TOUCH_SLIDER macro
3425         https://bugs.webkit.org/show_bug.cgi?id=130185
3426
3427         Reviewed by Gyuyoung Kim.
3428
3429         * Scripts/webkitperl/FeatureList.pm:
3430
3431 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3432
3433         [GTK][CMake] Build with -fno-rtti
3434         https://bugs.webkit.org/show_bug.cgi?id=130261
3435
3436         Reviewed by Martin Robinson.
3437
3438         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3439         defined to 0 to prevent typeid use in included GTest headers.
3440
3441 2014-03-16  Brian Burg  <bburg@apple.com>
3442
3443         Web Inspector: vended backend commands file should be generated as part of the build
3444         https://bugs.webkit.org/show_bug.cgi?id=130110
3445
3446         Reviewed by Timothy Hatcher.
3447
3448         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3449
3450 2014-03-16  Diego Pino García  <dpino@igalia.com>
3451
3452         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3453         https://bugs.webkit.org/show_bug.cgi?id=128999
3454
3455         Reviewed by Philippe Normand.
3456
3457         * MiniBrowser/gtk/BrowserWindow.c:
3458         (reloadPage):
3459         (reloadPageIgnoringCache):
3460         (browser_window_init):
3461
3462 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3463
3464         [GTK] Improve ninja detection in webkitdirs.pm
3465         https://bugs.webkit.org/show_bug.cgi?id=129902
3466
3467         Reviewed by Daniel Bates.
3468
3469         * Scripts/webkitdirs.pm:
3470         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3471         us to look for ninja-build as well.
3472
3473 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3474
3475         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3476         https://bugs.webkit.org/show_bug.cgi?id=130276
3477         <rdar://problem/16266927>
3478         
3479         Reviewed by Simon Fraser.
3480
3481         * BuildSlaveSupport/build-launcher-app:
3482         * BuildSlaveSupport/build-launcher-dmg:
3483         * DumpRenderTree/DumpRenderTree.h:
3484         * DumpRenderTree/DumpRenderTreePrefix.h:
3485         * DumpRenderTree/GCController.cpp:
3486         * DumpRenderTree/GCController.h:
3487         * DumpRenderTree/JavaScriptThreading.cpp:
3488         * DumpRenderTree/JavaScriptThreading.h:
3489         * DumpRenderTree/PixelDumpSupport.cpp:
3490         * DumpRenderTree/PixelDumpSupport.h:
3491         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3492         * DumpRenderTree/TestRunner.cpp:
3493         * DumpRenderTree/TestRunner.h:
3494         * DumpRenderTree/WorkQueue.cpp:
3495         * DumpRenderTree/WorkQueue.h:
3496         * DumpRenderTree/WorkQueueItem.h:
3497         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3498         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3499         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3500         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3501         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3502         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3503         * DumpRenderTree/efl/EditingCallbacks.cpp:
3504         * DumpRenderTree/efl/EditingCallbacks.h:
3505         * DumpRenderTree/efl/EventSender.cpp:
3506         * DumpRenderTree/efl/EventSender.h:
3507         * DumpRenderTree/efl/GCControllerEfl.cpp:
3508         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3509         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3510         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3511         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3512         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3513         * DumpRenderTree/gtk/EditingCallbacks.h:
3514         * DumpRenderTree/gtk/EventSender.cpp:
3515         * DumpRenderTree/gtk/EventSender.h:
3516         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3517         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3518         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3519         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3520         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3521         * DumpRenderTree/gtk/TextInputController.cpp:
3522         * DumpRenderTree/gtk/TextInputController.h:
3523         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3524         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3525         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3526         * DumpRenderTree/mac/AppleScriptController.h:
3527         * DumpRenderTree/mac/AppleScriptController.m:
3528         * DumpRenderTree/mac/CheckedMalloc.cpp:
3529         * DumpRenderTree/mac/CheckedMalloc.h:
3530         * DumpRenderTree/mac/DumpRenderTree.mm:
3531         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3532         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3533         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3534         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3535         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3536         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3537         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3538         * DumpRenderTree/mac/EditingDelegate.h:
3539         * DumpRenderTree/mac/EditingDelegate.mm:
3540         * DumpRenderTree/mac/EventSendingController.h:
3541         * DumpRenderTree/mac/EventSendingController.mm:
3542         * DumpRenderTree/mac/FrameLoadDelegate.h:
3543         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3544         * DumpRenderTree/mac/GCControllerMac.mm:
3545         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3546         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3547         * DumpRenderTree/mac/NavigationController.h:
3548         * DumpRenderTree/mac/NavigationController.m:
3549         * DumpRenderTree/mac/ObjCController.h:
3550         * DumpRenderTree/mac/ObjCController.m:
3551         * DumpRenderTree/mac/ObjCPlugin.h:
3552         * DumpRenderTree/mac/ObjCPlugin.m:
3553         * DumpRenderTree/mac/ObjCPluginFunction.h:
3554         * DumpRenderTree/mac/ObjCPluginFunction.m:
3555         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3556         * DumpRenderTree/mac/PolicyDelegate.h:
3557         * DumpRenderTree/mac/PolicyDelegate.mm:
3558         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3559         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3560         * DumpRenderTree/mac/TestRunnerMac.mm:
3561         * DumpRenderTree/mac/TextInputController.h:
3562         * DumpRenderTree/mac/TextInputController.m:
3563         * DumpRenderTree/mac/UIDelegate.h:
3564         * DumpRenderTree/mac/UIDelegate.mm:
3565         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3566         * DumpRenderTree/win/DRTDataObject.cpp:
3567         * DumpRenderTree/win/DRTDataObject.h:
3568         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3569         * DumpRenderTree/win/DRTDropSource.cpp:
3570         * DumpRenderTree/win/DRTDropSource.h:
3571         * DumpRenderTree/win/DraggingInfo.h:
3572         * DumpRenderTree/win/DumpRenderTree.cpp:
3573         * DumpRenderTree/win/DumpRenderTreeWin.h:
3574         * DumpRenderTree/win/EditingDelegate.cpp:
3575         * DumpRenderTree/win/EditingDelegate.h:
3576         * DumpRenderTree/win/EventSender.cpp:
3577         * DumpRenderTree/win/EventSender.h:
3578         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3579         * DumpRenderTree/win/FrameLoadDelegate.h:
3580         * DumpRenderTree/win/GCControllerWin.cpp:
3581         * DumpRenderTree/win/HistoryDelegate.cpp:
3582         * DumpRenderTree/win/HistoryDelegate.h:
3583         * DumpRenderTree/win/MD5.cpp:
3584         * DumpRenderTree/win/MD5.h:
3585         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3586         * DumpRenderTree/win/PolicyDelegate.cpp:
3587         * DumpRenderTree/win/PolicyDelegate.h:
3588         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3589         * DumpRenderTree/win/ResourceLoadDelegate.h:
3590         * DumpRenderTree/win/TestRunnerWin.cpp:
3591         * DumpRenderTree/win/TextInputController.cpp:
3592         * DumpRenderTree/win/TextInputController.h:
3593         * DumpRenderTree/win/TextInputControllerWin.cpp:
3594         * DumpRenderTree/win/UIDelegate.cpp:
3595         * DumpRenderTree/win/UIDelegate.h:
3596         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3597         * EWebLauncher/main.c:
3598         * GtkLauncher/main.c:
3599         * ImageDiff/efl/ImageDiff.cpp:
3600         * ImageDiff/gtk/ImageDiff.cpp:
3601         * MiniBrowser/gtk/main.c:
3602         * Scripts/SpacingHeuristics.pm:
3603         * Scripts/VCSUtils.pm:
3604         * Scripts/bisect-builds:
3605         * Scripts/build-dumprendertree:
3606         * Scripts/build-jsc:
3607         * Scripts/build-webkit:
3608         * Scripts/check-dom-results:
3609         * Scripts/check-for-exit-time-destructors:
3610         * Scripts/check-for-global-initializers:
3611         * Scripts/commit-log-editor:
3612         * Scripts/compare-timing-files:
3613         * Scripts/debug-minibrowser:
3614         * Scripts/debug-safari:
3615         * Scripts/do-file-rename:
3616         * Scripts/find-extra-includes:
3617         * Scripts/generate-coverage-data:
3618         * Scripts/make-script-test-wrappers:
3619         * Scripts/malloc-tree:
3620         * Scripts/old-run-webkit-tests:
3621         * Scripts/parse-malloc-history:
3622         * Scripts/report-include-statistics:
3623         * Scripts/resolve-ChangeLogs:
3624         * Scripts/run-bindings-tests:
3625         * Scripts/run-iexploder-tests:
3626         * Scripts/run-javascriptcore-tests:
3627         * Scripts/run-jsc:
3628         * Scripts/run-launcher:
3629         * Scripts/run-leaks:
3630         * Scripts/run-mangleme-tests:
3631         * Scripts/run-minibrowser:
3632         * Scripts/run-pageloadtest:
3633         * Scripts/run-regexp-tests:
3634         * Scripts/run-safari:
3635         * Scripts/run-sunspider:
3636         * Scripts/run-webkit-app:
3637         * Scripts/sampstat:
3638         * Scripts/set-webkit-configuration:
3639         * Scripts/sort-Xcode-project-file:
3640         * Scripts/sort-export-file:
3641         * Scripts/split-file-by-class:
3642         * Scripts/sunspider-compare-results:
3643         * Scripts/svn-apply:
3644         * Scripts/svn-create-patch:
3645         * Scripts/svn-unapply:
3646         * Scripts/test-webkit-scripts:
3647         * Scripts/update-javascriptcore-test-results:
3648         * Scripts/update-webkit:
3649         * Scripts/update-webkit-auxiliary-libs:
3650         * Scripts/update-webkit-dependency:
3651         * Scripts/update-webkit-localizable-strings:
3652         * Scripts/update-webkit-support-libs:
3653         * Scripts/update-webkit-wincairo-libs:
3654         * Scripts/webkit-build-directory:
3655         * Scripts/webkitdirs.pm:
3656         (installedSafariPath):
3657         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3658         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3659         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3660         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3661         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3662         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3663         * Scripts/webkitperl/features.pm:
3664         * Scripts/webkitperl/httpd.pm:
3665         * Scripts/webkitpy/bindings/main.py:
3666         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3667         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3668         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3669         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3670         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3671         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3672         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3673         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3674         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3675         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3676         * WebKitTestRunner/PixelDumpSupport.cpp:
3677         * WebKitTestRunner/PixelDumpSupport.h:
3678         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3679         * WinLauncher/WinLauncher.cpp:
3680         * WinLauncher/WinLauncher.h:
3681         * WinLauncher/stdafx.cpp:
3682         * WinLauncher/stdafx.h:
3683
3684 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3685
3686         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3687         https://bugs.webkit.org/show_bug.cgi?id=130265
3688
3689         Reviewed by Michael Saboff.
3690
3691         * Scripts/build-webkit:
3692         * Scripts/copy-webkitlibraries-to-product-directory:
3693
3694 2014-03-14  Landry Breuil  <landry@openbsd.org>
3695
3696         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3697         Also allow to set MAKE in the environment.
3698         https://bugs.webkit.org/show_bug.cgi?id=129991
3699
3700         Reviewed by Andreas Kling.
3701
3702         * Scripts/webkitdirs.pm:
3703         (determineArchitecture):
3704         (determineNumberOfCPUs):
3705         (isBSD):
3706         (buildAutotoolsProject):
3707         * Scripts/webkitpy/common/system/platforminfo.py:
3708         (PlatformInfo.__init__):
3709         (PlatformInfo.is_openbsd):
3710         (PlatformInfo):
3711         (PlatformInfo.is_netbsd):
3712         (PlatformInfo._determine_os_name):
3713
3714 2014-03-14  Dean Jackson  <dino@apple.com>
3715
3716         Remove libWebKitSystemInterfaceLion.a
3717         https://bugs.webkit.org/show_bug.cgi?id=130254
3718
3719         Reviewed by Geoffrey Garen and Andreas Kling.
3720
3721         No need to copy the Lion libraries into the build.
3722
3723         * Scripts/copy-webkitlibraries-to-product-directory:
3724
3725 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3726
3727         [EFL][MiniBrowser] Revise help messages of command line parameters
3728         https://bugs.webkit.org/show_bug.cgi?id=130222
3729
3730         Reviewed by Csaba Osztrogonác.
3731
3732         Correct the default value description and make help messages to be consistent.
3733
3734         * MiniBrowser/efl/main.c:
3735
3736 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3737
3738         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3739         https://bugs.webkit.org/show_bug.cgi?id=129612
3740
3741         Reviewed by Darin Adler.
3742
3743         For new code use static NeverDestroyed<T> instead.
3744
3745         * DumpRenderTree/JavaScriptThreading.cpp:
3746         (javaScriptThreadsMutex):
3747         (javaScriptThreads):
3748         * DumpRenderTree/efl/EventSender.cpp:
3749         (touchPointList):
3750         (delayedEventQueue):
3751         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3752         (delegatesWithDelayedWork):
3753         * Scripts/check-for-exit-time-destructors:
3754         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3755         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3756         (testsMap):
3757
3758 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3759
3760         [EFL][WK2] Fix compilation warning in Minibrowser
3761         https://bugs.webkit.org/show_bug.cgi?id=130132
3762
3763         Reviewed by Csaba Osztrogonác.
3764
3765         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3766
3767         * MiniBrowser/efl/main.c:
3768         (on_download_request):
3769
3770 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3771
3772         FTL should support IsBlah
3773         https://bugs.webkit.org/show_bug.cgi?id=130202
3774
3775         Reviewed by Geoffrey Garen.
3776         
3777         Running existing JSRegress tests with noInline gives us coverage for these
3778         changes. Chances are, this will also give coverage for other interesting things
3779         as well.
3780
3781         * Scripts/run-jsc-stress-tests:
3782
3783 2014-03-12  Brian Burg  <bburg@apple.com>
3784
3785         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3786         https://bugs.webkit.org/show_bug.cgi?id=129744
3787
3788         Reviewed by Timothy Hatcher.
3789
3790         * DumpRenderTree/TestRunner.cpp:
3791         (evaluateInWebInspectorCallback):
3792         * DumpRenderTree/TestRunner.h:
3793         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3794         (TestRunner::evaluateInWebInspector):
3795         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3796         (TestRunner::evaluateInWebInspector):
3797         * DumpRenderTree/mac/TestRunnerMac.mm:
3798         (TestRunner::evaluateInWebInspector):
3799         * DumpRenderTree/win/TestRunnerWin.cpp:
3800         (TestRunner::evaluateInWebInspector):
3801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3803         (WTR::TestRunner::evaluateInWebInspector):
3804         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3805
3806 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3807
3808         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3809         https://bugs.webkit.org/show_bug.cgi?id=130129
3810
3811         Reviewed by Csaba Osztrogonác.
3812
3813         * Scripts/webkitdirs.pm:
3814         (canUseNinja): Redirecting stderr to /dev/null
3815
3816 2014-03-13  Andres Gomez  <agomez@igalia.com>
3817
3818         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3819         https://bugs.webkit.org/show_bug.cgi?id=130092
3820
3821         Reviewed by Csaba Osztrogonác.
3822
3823         Added "python-dev" as dependency for deb based distros. It is
3824         already present for rpm based distros. This dependency will allow
3825         libxml2 to generate its python bindings, needed by gtk-doc.
3826
3827         * gtk/install-dependencies:
3828
3829 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3830
3831         Unreviewed. Fix GTK+ cmake build after r165488.
3832
3833         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3834
3835 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3836
3837         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3838         https://bugs.webkit.org/show_bug.cgi?id=130014
3839
3840         Reviewed by Martin Robinson.
3841
3842         Include cmake or autotools config header.
3843
3844         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3845         * MiniBrowser/gtk/BrowserSearchBar.c:
3846         * MiniBrowser/gtk/BrowserWindow.c:
3847         * MiniBrowser/gtk/main.c:
3848
3849 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3850
3851         Unreviewed, rolling out r165471.
3852         https://bugs.webkit.org/show_bug.cgi?id=130139
3853
3854         Didn't really fix the issue and broke another bot (Requested
3855         by mrobinson on #webkit).
3856
3857         Reverted changeset:
3858
3859         "[CMake] Newer versions of CMake cannot find older versions of
3860         Freetype"
3861         https://bugs.webkit.org/show_bug.cgi?id=130107
3862         http://trac.webkit.org/changeset/165471
3863
3864 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3865
3866         It should be possible to build WebKit with FTL on iOS
3867         https://bugs.webkit.org/show_bug.cgi?id=130116
3868
3869         Reviewed by Dan Bernstein.
3870
3871         * Scripts/build-webkit:
3872         * Scripts/copy-webkitlibraries-to-product-directory:
3873
3874 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3875
3876         [Win] Remove use of QTSDK
3877         https://bugs.webkit.org/show_bug.cgi?id=130049
3878
3879         Reviewed by Darin Adler.
3880
3881         * DumpRenderTree/win/DumpRenderTree.cpp:
3882         (initialize): Remove QuickTime code.
3883         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3884         building QTMovieWin.
3885
3886 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3887
3888         [GTK][CMAKE] Too verbose build output
3889         https://bugs.webkit.org/show_bug.cgi?id=130076
3890
3891         Reviewed by Carlos Garcia Campos.
3892
3893         Instead of building with cmake --build which isn't smart about pretty printing and
3894         colors, we build with a script which calls the proper build command.
3895
3896         * Scripts/webkitdirs.pm:
3897         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3898         the CMake configuration pass.
3899
3900 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3901
3902         [CMake] Newer versions of CMake cannot find older versions of Freetype
3903         https://bugs.webkit.org/show_bug.cgi?id=130107
3904
3905         Reviewed by Gustavo Noronha Silva.
3906
3907         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3908         to CMake during jhbuild initialization.
3909
3910 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3911
3912         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3913         https://bugs.webkit.org/show_bug.cgi?id=129961
3914
3915         Reviewed by Simon Fraser.
3916
3917         Now scaled content can go through the window capturing mechanism too for compositing content.
3918         AppleMagnifiedMode is redundant.
3919
3920         * DumpRenderTree/mac/DumpRenderTree.mm:
3921         (setDefaultsToConsistentValuesForTesting):
3922         (runTest):
3923         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3924         (createBitmapContextFromWebView):
3925         * WebKitTestRunner/PlatformWebView.h:
3926         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3927         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3928         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3929         (WTR::PlatformWebView::didInitializeClients):
3930         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3931         (WTR::PlatformWebView::forceWindowFramesChanged):
3932         * WebKitTestRunner/mac/main.mm:
3933         (setDefaultsToConsistentValuesForTesting):
3934
3935 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3936
3937         Unreviewed. Add myself as a committer.
3938
3939         * Scripts/webkitpy/common/config/contributors.json:
3940
3941 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3942
3943         Unreviewed build fix on the EFL port when used lower version of ATK
3944
3945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3946         (WTR::AccessibilityUIElement::y): Fixed typo.
3947
3948 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3949
3950         Some images are blank in the rebaseline server UI
3951         https://bugs.webkit.org/show_bug.cgi?id=130104
3952
3953         Reviewed by Tim Horton.
3954
3955         Let the server check for images in the 'retries' directory
3956         if it can't find an image otherwise.
3957
3958         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3959         (RebaselineHTTPRequestHandler.test_result):
3960
3961 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3962
3963         [GTK][CMake] --update-gtk has no effect
3964         https://bugs.webkit.org/show_bug.cgi?id=130088
3965
3966         Reviewed by Philippe Normand.
3967
3968         * Scripts/webkitdirs.pm:
3969         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3970         as an argument.
3971
3972 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3973
3974         Add "System Font" to the list of whitelisted DRT fonts
3975         https://bugs.webkit.org/show_bug.cgi?id=130046
3976
3977         Reviewed by Darin Adler.
3978
3979         * DumpRenderTree/mac/DumpRenderTree.mm:
3980         (allowedFontFamilySet):
3981         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3982
3983 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3984
3985         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3986         https://bugs.webkit.org/show_bug.cgi?id=130064
3987
3988         Reviewed by Philippe Normand.
3989
3990         * efl/jhbuildrc: Remove duplicated code.
3991         * gtk/jhbuildrc: Remove duplicated code.
3992         * jhbuild/jhbuildrc_common.py:
3993         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3994         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3995         and is apparently necessary for GTK+.
3996
3997 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3998
3999         check-webkit-style failed to complain about missing braces
4000         https://bugs.webkit.org/show_bug.cgi?id=34189
4001
4002         Reviewed by Ryosuke Niwa.
4003
4004         * Scripts/webkitpy/style/checkers/cpp.py:
4005         (check_braces):
4006         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4007         (WebKitStyleTest.test_braces):
4008
4009 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
4010
4011         Remove Qt cruft from style checker.
4012         https://bugs.webkit.org/show_bug.cgi?id=130085
4013
4014         Reviewed by Csaba Osztrogonác.
4015
4016         There is no 'foreach' keyword in c++. That was a Qt feature
4017         added in: http://trac.webkit.org/changeset/46113
4018         Qt was removed from WebKit, so we should remove the checks
4019         of this keyword from check-webkit-style scripts.
4020
4021         * Scripts/webkitpy/style/checkers/cpp.py:
4022         (check_spacing_for_function_call):
4023         (check_spacing):
4024         (check_braces):
4025         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4026         (CppStyleTest.test_mismatching_spaces_in_parens):
4027         (CppStyleTest.test_spacing_for_fncall):
4028         (WebKitStyleTest.test_braces):
4029
4030 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
4031
4032         [GTK] update-webkitgtk-libs needs itstool
4033         https://bugs.webkit.org/show_bug.cgi?id=130082
4034
4035         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
4036         itstool is a dependency of building gtk-doc from version 1.19, so it should
4037         be added to Tools/gtk/install-dependencies script, too.
4038
4039         Reviewed by Philippe Normand.
4040
4041         * gtk/install-dependencies:
4042
4043 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4044
4045         webkitbot rollout ChangeLogs should be nicer
4046         https://bugs.webkit.org/show_bug.cgi?id=122654
4047
4048         Reviewed by Csaba Osztrogonác.
4049
4050         Added bug urls and descriptions of rolled out patches to the rollout changelog
4051         if they are present in the original changelog. Additionally removed the list of
4052         changed files and functions.
4053
4054         * Scripts/webkitpy/common/checkout/changelog.py:
4055         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
4056         * Scripts/webkitpy/common/checkout/checkout.py:
4057         (Checkout._changelog_data_for_revision): Store bug description.
4058         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4059         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4060         (CheckoutTest.test_commit_info_for_revision):
4061         * Scripts/webkitpy/common/checkout/commitinfo.py:
4062         (CommitInfo.bug_description): Added.
4063         (CommitInfo.to_json):
4064         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4065         (CommitInfoTest.test_commit_info_creation):
4066         * Scripts/webkitpy/tool/commands/download.py:
4067         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
4068         out patches for creating rollout changelog.
4069         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
4070         caused the regression is stored in state["bug_blocked"] now.
4071         * Scripts/webkitpy/tool/commands/download_unittest.py:
4072         (test_prepare_rollout):
4073         (test_create_rollout_multiple_revision):
4074         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4075         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
4076         rolled out patches to the changelog.
4077         (PrepareChangeLogForRevert.run):
4078         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
4079         (UpdateChangeLogsForRevertTest):
4080         (test_message_for_revert):
4081         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4082         (ReopenBugAfterRollout.run):
4083
4084 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
4085
4086         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
4087         https://bugs.webkit.org/show_bug.cgi?id=130021
4088
4089         Reviewed by Mario Sanchez Prada.
4090
4091         Replace deprecated functions to use new API from ATK 2.11.90.
4092
4093         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4094         (AccessibilityUIElement::x):
4095         (AccessibilityUIElement::y):
4096         (AccessibilityUIElement::width):
4097         (AccessibilityUIElement::height):
4098         (AccessibilityUIElement::clickPointX):
4099         (AccessibilityUIElement::clickPointY):
4100         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4101         (WTR::AccessibilityUIElement::x):
4102         (WTR::AccessibilityUIElement::y):
4103         (WTR::AccessibilityUIElement::width):
4104         (WTR::AccessibilityUIElement::height):
4105         (WTR::AccessibilityUIElement::clickPointX):
4106         (WTR::AccessibilityUIElement::clickPointY):
4107
4108 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
4109
4110         [ATK] Expose aria-posinset and aria-setsize through object attributes
4111         https://bugs.webkit.org/show_bug.cgi?id=130011
4112
4113         Reviewed by Chris Fleizach.
4114
4115         Added missing implementation of numberAttributeValue both to WKTR and DRT.
4116
4117         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4118         (AccessibilityUIElement::numberAttributeValue):
4119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4120         (WTR::AccessibilityUIElement::numberAttributeValue):
4121
4122 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4123
4124         [Win] Unreviewed build fix.
4125
4126         Some bad Windows code was committed at some point that prevents the Apple Windows port
4127         from finding its runtime dependencies reliably.
4128
4129         * win/DLLLauncher/DLLLauncherMain.cpp:
4130         (appleApplicationSupportDirectory): Restored this function.
4131         (modifyPath): Update to use appleApplicationSupportDirectory function.
4132
4133 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
4134
4135         Let the user define the full address of the performance-site-server for uploading results
4136         https://bugs.webkit.org/show_bug.cgi?id=129819
4137
4138         Reviewed by Ryosuke Niwa.
4139
4140         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
4141         can be confusing. It's more straightforward, if you need to define explicitly the server's full
4142         address along with the protocol, when you're using this parameter. I added HTTPS as the default
4143         protocol for now, in order to avoid breaking the perf bots.
4144
4145         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4146         (_upload_json):
4147         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4148         (MainTest.test_upload_json):
4149
4150 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
4151
4152         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
4153         https://bugs.webkit.org/show_bug.cgi?id=130023
4154
4155         Reviewed by Dean Jackson.
4156
4157         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
4158         /SAFESEH flag to DLL launcher process.
4159
4160 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4161
4162         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
4163         https://bugs.webkit.org/show_bug.cgi?id=129980
4164
4165         Reviewed by Carlos Garcia Campos.
4166
4167         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
4168
4169 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
4170
4171         [GTK] Remove the WebView source-mode WebKit1 test
4172         https://bugs.webkit.org/show_bug.cgi?id=129976
4173
4174         Reviewed by Carlos Garcia Campos.
4175
4176         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
4177
4178 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
4179
4180         Unreviewed build fix for GTKbuild after the switch to CMake
4181
4182         * gtk/common.py:
4183         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
4184         test-only bot doesn't have any build files.
4185
4186 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4187
4188         [GTK] built-product-archive does not handle GTK+ CMake build
4189         https://bugs.webkit.org/show_bug.cgi?id=129941
4190
4191         * BuildSlaveSupport/built-product-archive:
4192         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
4193         the CMake build.
4194
4195 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
4196
4197         [GTK] Include CMake into install-dependencies script
4198         https://bugs.webkit.org/show_bug.cgi?id=129909
4199
4200         Reviewed by Martin Robinson.
4201
4202         As since r165267 buid-webkit uses CMake by default, the dependency
4203         with 'cmake' package should be introduced.
4204
4205         * gtk/install-dependencies: Ditto.
4206
4207 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4208
4209         REGRESSION(165267): Broke a webkitpy unit tests
4210         https://bugs.webkit.org/show_bug.cgi?id=129904
4211
4212         Reviewed by Jon Honeycutt.
4213
4214         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
4215         (GtkPort._is_cmake_build):
4216
4217 2014-03-07  Andres Gomez  <agomez@igalia.com>
4218
4219         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
4220         https://bugs.webkit.org/show_bug.cgi?id=129893
4221
4222         Reviewed by Martin Robinson.
4223
4224         Added "git-svn" as dependency for deb based distros and,
4225         additionally, "subversion" for rpm based distros.
4226
4227         * gtk/install-dependencies:
4228
4229 2014-03-07  Roger Fong  <roger_fong@apple.com>
4230
4231         Remove dummy setSystemWebGLLoadPolicy client method.
4232         https://bugs.webkit.org/show_bug.cgi?id=129873.
4233
4234         Reviewed by Dean Jackson.
4235
4236         * WebKitTestRunner/TestController.cpp:
4237         (WTR::TestController::createWebViewWithOptions):
4238
4239 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
4240
4241         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
4242         https://bugs.webkit.org/show_bug.cgi?id=129886
4243
4244         Reviewed by Mark Lam.
4245
4246         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
4247         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
4248         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
4249         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
4250         make it through when in non-verbose mode.
4251
4252 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
4253
4254         [GTK] buid-webkit should use CMake by default
4255         https://bugs.webkit.org/show_bug.cgi?id=129855
4256
4257         Reviewed by Carlos Garcia Campos.
4258
4259         Make the CMake build the default GTK+ build when using build-webkit. This will
4260         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
4261         so that we have --gtk and --gtkautotools.
4262
4263         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
4264         * Scripts/webkitpy/port/gtk.py: Ditto.
4265
4266 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
4267
4268         [CMake] [GTK] Build with ninja when it is available
4269         https://bugs.webkit.org/show_bug.cgi?id=129805
4270
4271         Reviewed by Philippe Normand.
4272
4273         * Scripts/webkitdirs.pm:
4274         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
4275         if it's available on the system.
4276         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
4277         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
4278
4279 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
4280
4281         If the FTL is build-time enabled then it should be run-time enabled.
4282
4283         Rubber stamped by Geoffrey Garen.
4284
4285         * Scripts/run-jsc-stress-tests:
4286
4287 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
4288
4289         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
4290         https://bugs.webkit.org/show_bug.cgi?id=129837
4291
4292         Reviewed by Michael Saboff.
4293
4294         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
4295         The fix is to use find instead of ls like we do in shell-runner.sh.
4296
4297         * Scripts/run-jsc-stress-tests:
4298
4299 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
4300
4301         filter-build-webkit should not strip .o
4302         https://bugs.webkit.org/show_bug.cgi?id=129614
4303
4304         Reviewed by Dean Jackson.
4305
4306         This makes it much easier to jump from the failing output at
4307         the end back up to the compile errors earlier in the output.
4308
4309         * Scripts/filter-build-webkit:
4310
4311 2014-03-06  Anders Carlsson  <andersca@apple.com>
4312
4313         Build WebKit2 before building WebKit
4314         https://bugs.webkit.org/show_bug.cgi?id=129831
4315         <rdar://problem/15920020>
4316
4317         Reviewed by Dan Bernstein.
4318
4319         * Scripts/build-webkit:
4320         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4321
4322 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4323
4324         make-3.82 fails to build on ARM/Linux
4325         https://bugs.webkit.org/show_bug.cgi?id=107926
4326
4327         Reviewed by Martin Robinson.
4328
4329         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4330         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4331         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4332         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4333
4334         * gtk/patches/make-3.82-arg-list-length.patch:
4335