Unreviewed trivial fix after r211697.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Unreviewed trivial fix after r211697.
4         https://bugs.webkit.org/show_bug.cgi?id=167863
5
6         * Scripts/run-javascriptcore-tests:
7         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
8
9 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
10
11         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
12         https://bugs.webkit.org/show_bug.cgi?id=167850
13
14         Reviewed by Tim Horton.
15
16         * DumpRenderTree/TestRunner.cpp:
17         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
18
19 2017-02-04  Andreas Kling  <akling@apple.com>
20
21         Plug some leaks in TestController and UIScriptContext.
22         <https://webkit.org/b/167839>
23
24         Reviewed by Alexey Proskuryakov.
25
26         Fix a couple of the leaks seen on the leaks bot.
27
28         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
29         (UIScriptContext::runUIScript):
30         * WebKitTestRunner/TestController.cpp:
31         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
32         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
33
34 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
35
36         WK1 mouse events are missing movementX and movementY for pointerlock.
37         https://bugs.webkit.org/show_bug.cgi?id=167775
38         rdar://problem/30343810
39
40         Reviewed by Alexey Proskuryakov.
41
42         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
43
44         * DumpRenderTree/mac/EventSendingController.mm:
45         (-[EventSendingController mouseMoveToX:Y:]):
46         * WebKitTestRunner/mac/EventSenderProxy.mm:
47         (WTR::EventSenderProxy::mouseMoveTo):
48
49 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
50
51         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
52         https://bugs.webkit.org/show_bug.cgi?id=167774
53
54         Reviewed by Tim Horton.
55
56         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
57         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
58         web process are async, so the callback fires after the web process gets the new state.
59
60         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
61         (WTR::UIScriptController::removeViewFromWindow):
62         (WTR::UIScriptController::addViewToWindow):
63         * DumpRenderTree/mac/DumpRenderTree.mm:
64         (createWebViewAndOffscreenWindow):
65         (resetWebViewToConsistentStateBeforeTesting):
66         * DumpRenderTree/mac/DumpRenderTreeMac.h:
67         * DumpRenderTree/mac/UIScriptControllerMac.mm:
68         (WTR::UIScriptController::removeViewFromWindow):
69         (WTR::UIScriptController::addViewToWindow):
70         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
71         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
72         (WTR::UIScriptController::removeViewFromWindow):
73         (WTR::UIScriptController::addViewToWindow):
74         * TestRunnerShared/UIScriptContext/UIScriptController.h:
75         * WebKitTestRunner/PlatformWebView.h:
76         * WebKitTestRunner/TestController.cpp:
77         (WTR::TestController::resetStateToConsistentValues):
78         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
79         (WTR::PlatformWebView::removeFromWindow):
80         (WTR::PlatformWebView::addToWindow):
81         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
82         (WTR::UIScriptController::removeViewFromWindow):
83         (WTR::UIScriptController::addViewToWindow):
84         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
85         (WTR::PlatformWebView::removeFromWindow):
86         (WTR::PlatformWebView::addToWindow):
87         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
88         (WTR::UIScriptController::removeViewFromWindow):
89         (WTR::UIScriptController::addViewToWindow):
90
91 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
92
93         Remove check for SkipSafariExecutableEntitlementChecks
94         https://bugs.webkit.org/show_bug.cgi?id=167762
95
96         Reviewed by Dan Bernstein.
97
98         Follow-up fix: don't break internal behavior.
99
100         * Scripts/webkitdirs.pm:
101         (safariPath):
102         (executableHasEntitlements): Deleted.
103         (safariPathFromSafariBundle): Deleted.
104         (installedSafariPath): Deleted.
105
106 2017-02-03  Daniel Bates  <dabates@apple.com>
107
108         [Mac][WK2] Add SPI to override the Content Security Policy of a page
109         https://bugs.webkit.org/show_bug.cgi?id=167810
110         <rdar://problem/30102568>
111
112         Reviewed by Anders Carlsson.
113
114         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
115
116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
117         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
118         (TEST):
119         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
120         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
121         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
122         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
123
124 2017-02-02  Alex Christensen  <achristensen@webkit.org>
125
126         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
127         https://bugs.webkit.org/show_bug.cgi?id=167773
128         <rdar://problem/30221102>
129
130         Reviewed by Ryosuke Niwa.
131
132         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
133         (TestWebKitAPI::TEST_F):
134
135 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
136
137         Remove check for SkipSafariExecutableEntitlementChecks
138         https://bugs.webkit.org/show_bug.cgi?id=167762
139         rdar://problem/22480673
140
141         Reviewed by Dan Bernstein.
142
143         * Scripts/webkitdirs.pm:
144         (safariPathFromSafariBundle):
145         (skipSafariExecutableEntitlementChecks): Deleted.
146
147 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
148
149         Undefined subroutine in svn-create-patch
150         https://bugs.webkit.org/show_bug.cgi?id=167742
151
152         Unreviewed build-fix after r211543.
153
154         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
155
156 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
157
158         Unreviewed. Fix jhbuild dependencies build.
159
160         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
161         Patch updated.
162
163 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
164
165         [EME][GStreamer] Fixed decryptor selection
166         https://bugs.webkit.org/show_bug.cgi?id=167588
167
168         Reviewed by Žan Doberšek.
169
170         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
171
172         * gtk/jhbuild.modules: Added patches to gstreamer and
173         gst-plugins-good packages.
174         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
175         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
176
177 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
178
179         Make run-benchmark script supports 'config' key in test plan.
180         https://bugs.webkit.org/show_bug.cgi?id=167715
181
182         Reviewed by Ryosuke Niwa.
183
184         Add support for 'config' key in test paln.
185         'config' key is a dictionary that specifies environment configurations while test is running.
186         Specifies orientation to be portrait in MotionMark benchmark.
187
188         * Scripts/webkitpy/benchmark_runner/README.md:
189         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
190         (BenchmarkRunner.__init__):
191         (BenchmarkRunner._run_benchmark):
192         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
193         (BrowserDriver.prepare_env):
194         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
195         (LinuxBrowserDriver.prepare_env):
196         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
197         (OSXBrowserDriver.prepare_env):
198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
199         (OSXSafariDriver.prepare_env):
200         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
201
202 2017-02-01  Daniel Bates  <dabates@apple.com>
203
204         REGRESSION (r210820): svn-create-patch does not emit property change only diff
205         https://bugs.webkit.org/show_bug.cgi?id=167169
206
207         Reviewed by David Kilzer.
208
209         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
210         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
211         header from the output of "svn diff" on a file that was copied or moved.
212
213         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
214         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
215         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
216         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
217         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
218         of a file with only a property change also does not contain any chunk range lines. Therefore
219         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
220         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
221         we should directly test for the presence of a leading SVN diff header with an empty body and
222         remove such lines from the diff.
223
224         * Scripts/VCSUtils.pm:
225         (fixSVNPatchForAdditionWithHistory): Added.
226         * Scripts/svn-create-patch:
227         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
228         we have a non empty patch for an added file with history (i.e. a copied or moved file).
229         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
230
231 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
232
233         [Mac] Update CARingBuffer class
234         https://bugs.webkit.org/show_bug.cgi?id=167656
235
236         Reviewed by Jer Noble.
237
238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
239         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
240         (TestWebKitAPI::CARingBufferTest::SetUp):
241         (TestWebKitAPI::CARingBufferTest::setup):
242         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
243         (TestWebKitAPI::CARingBufferTest::description):
244         (TestWebKitAPI::CARingBufferTest::bufferList):
245         (TestWebKitAPI::CARingBufferTest::ringBuffer):
246         (TestWebKitAPI::CARingBufferTest::capacity):
247         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
248         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
249         (TestWebKitAPI::TEST_F):
250         (TestWebKitAPI::MixingTest::run):
251
252 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
253
254         [Mac] TestWebKitAPI includes system frameworks incorrectly
255         https://bugs.webkit.org/show_bug.cgi?id=167703
256         rdar://problem/30301498
257
258         Reviewed by Ryosuke Niwa.
259
260         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
261         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
262
263         Also, reduced the number of subframework search paths, looks like we only need one now.
264
265         * TestWebKitAPI/Configurations/Base.xcconfig:
266
267 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
268
269         Correct "filesHaveSameVolume" predicate
270         https://bugs.webkit.org/show_bug.cgi?id=167696
271         <rdar://problem/30298722>
272
273         Reviewed by David Kilzer.
274
275         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
276         percent-escaped path inputs.
277
278         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
279         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
280         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
281         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
282         (TestWebKitAPI::TEST_F):
283
284 2017-02-01  Tomas Popela  <tpopela@redhat.com>
285
286         Unreviewed. Fix coding style in MiniBrowser
287
288         * MiniBrowser/gtk/BrowserWindow.c:
289         (editingCommandCallback):
290         (insertImageCommandCallback):
291         (insertLinkCommandCallback):
292
293 2017-02-01  Tomas Popela  <tpopela@redhat.com>
294
295         [GTK] Add an API to add a custom tab into the print dialog
296         https://bugs.webkit.org/show_bug.cgi?id=151998
297
298         Reviewed by Carlos Garcia Campos.
299
300         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
301         that is testing a newly added API.
302
303         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
304         (testPrintCustomWidget):
305         (beforeAll):
306
307 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
308
309         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
310         https://bugs.webkit.org/show_bug.cgi?id=166529
311
312         Reviewed by Xabier Rodriguez-Calvar.
313
314         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
315         New patch version accepted in GStreamer upstream.
316
317 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
318
319         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
320         https://bugs.webkit.org/show_bug.cgi?id=167498
321
322         Reviewed by Carlos Garcia Campos.
323
324         Depending on the distro version you can need either libxfont1-dev
325         or libfont-dev to build with jhbuild.
326
327         * gtk/install-dependencies:
328
329 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
330
331         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
332         https://bugs.webkit.org/show_bug.cgi?id=167594
333
334         Unreviewed test gardening.
335
336         Disabling this test while we investigate the cause of a timeout on ios-simulator.
337
338         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
339         (TEST):
340
341 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
342
343         Move slow-running microbenchmarks out of JSTests/microbenchmarks
344         https://bugs.webkit.org/show_bug.cgi?id=167676
345
346         Reviewed by Saam Barati.
347
348         * Scripts/run-javascriptcore-tests:
349         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
350
351 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
352
353         Make Dump Render Tree not crash
354         https://bugs.webkit.org/show_bug.cgi?id=167667
355
356         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
357         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
358         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
359         This does not fix any tests, it just fixes the crash.
360         
361         Reviewed by Simon Fraser.
362
363         * DumpRenderTree/TestRunner.cpp:
364         (TestRunner::callUIScriptCallback):
365
366 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
367
368         Workaround for simctl install failing to report install failure
369         https://bugs.webkit.org/show_bug.cgi?id=167654
370
371         Reviewed by Daniel Bates.
372
373         simctl install will sometimes report success even though install has failed.
374         To workaround this bug, we attempt an app launch after install to ensure
375         install has succeeded.
376
377         * Scripts/webkitpy/xcode/simulator.py:
378         (Device.install_app): Attempt app launch after install, retry install if launch fails.
379         (Device.launch_app): Correct comment.
380
381 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
382
383         Unreviewed webkitpy fix after r211405.
384
385         * Scripts/webkitpy/xcode/simulator.py:
386         (Device.launch_app): Remove @staticmethod on _log_debug_error.
387
388 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
389
390         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
391
392         * gtk/manifest.txt.in:
393
394 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
395
396         AX: enable search predication for iOS
397         https://bugs.webkit.org/show_bug.cgi?id=167558
398         <rdar://problem/30251367>
399
400         Reviewed by Joanmarie Diggs.
401
402         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
403         (AccessibilityUIElement::uiElementForSearchPredicate):
404         * DumpRenderTree/mac/AccessibilityCommonMac.h:
405         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
406         (searchPredicateParameterizedAttributeForSearchCriteria):
407         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
408         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
409         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
410         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
411         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
412         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
413         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
414         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
415         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
416         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
417         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
418
419 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
420
421         Workaround for simctl launch bug
422         https://bugs.webkit.org/show_bug.cgi?id=167613
423
424         Reviewed by Daniel Bates.
425
426         simctl launch will sometimes fail because of a race condition when many
427         simulators are being run simultaneously. These failures will always have
428         an exit code of 1. This change attempts to launch an app multiple times
429         before reporting a failure to workaround this bug.
430
431         * Scripts/webkitpy/xcode/simulator.py:
432         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
433
434 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
435
436         Commit queue fails to look at real name aliases for the reviewer
437         https://bugs.webkit.org/show_bug.cgi?id=167422
438
439         Reviewed by Joseph Pecoraro.
440
441         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
442         (test_has_valid_reviewer): Added tests.
443
444         * Scripts/webkitpy/common/config/committers.py:
445         (CommitterList._name_to_contributor_map):
446         Made _name_to_contributor_map include alias names.
447
448         * Scripts/webkitpy/common/config/committers_unittest.py:
449         (CommittersTest.test_contributors_by_fuzzy_match):
450         Removed subtests that are now obsolete, as these matches are strict. It is not
451         obvious if distance based fuzzy matching for names is useful at all, but we can
452         look into that some other time.
453
454 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
455
456         QueueStatusServer should have an explicit timeout for _fetch_url
457         https://bugs.webkit.org/show_bug.cgi?id=167467
458
459         Reviewed by Alexey Proskuryakov.
460
461         * Scripts/webkitpy/common/net/statusserver.py:
462         (StatusServer._fetch_url): Add an explicit timeout of 300s.
463
464 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
465
466         Add support for Trac instances that host multiple projects.
467         https://bugs.webkit.org/show_bug.cgi?id=167524
468
469         Reviewed by Alexey Proskuryakov.
470
471         When multiple projects are hosted on a single Trac instance, the current
472         behavior will retrieve changesets from all tracked projects.
473         This patch teaches Trac.js to get project-specific changesets from Trac.
474         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
475         when querying the Trac timeline.
476
477         To tell Trac to be aware of multi-project instances we leverage the 
478         `options` parameter when creating a new instance: 
479
480             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
481
482         If this option is not provided, the original behaviour will prevail.
483         Additionally, add corresponding tests.
484
485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
486         (Trac): Reason about new optional parameter 'projectIdentifier'.
487         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
488         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
489         replace default parameter `changeset=on` with `repo-projectname=on`.
490         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
492         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
494         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
495         Add the following tests:
496             test("revisionURL")
497             test("revisionURL with Trac Identifier")
498             test("_xmlTimelineURL")
499             test("_xmlTimelineURL with Trac Identifier")
500         (this.view._latestProductiveIteration): Fix missing ';'.
501
502 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
503
504         Correct spacing regression on inter-element complex path shaping on some fonts
505         https://bugs.webkit.org/show_bug.cgi?id=166013
506
507         Reviewed by Simon Fraser.
508
509         Unskip existing tests and make some new tests:
510         - Testing complex text with no origins
511         - Testing initial expansions
512         - Testing the sign of vertical advances
513
514         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
515         (TestWebKitAPI::TEST_F):
516
517 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
518
519         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
520         https://bugs.webkit.org/show_bug.cgi?id=167596
521
522         Reviewed by Daniel Bates.
523
524         We avoid needing a thin directory by invoking the zip program with
525         the list of directories from the build directory to be zipped,
526         and by using the zip feature to exclude files matching a pattern.
527
528         * BuildSlaveSupport/built-product-archive:
529         (copyBuildFiles):
530         (createZipFromList):
531         (archiveBuiltProduct):
532
533 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
534
535         Use simctl instead of LayoutTestRelay
536         https://bugs.webkit.org/show_bug.cgi?id=165927
537
538         Reviewed by Daniel Bates.
539
540         Part 1
541
542         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
543         simulators through simctl (iOS 10 and later), use this functionality instead.
544
545         * Scripts/webkitpy/port/base.py:
546         (Port.__init__): Added _test_runner_process_constructor.
547         * Scripts/webkitpy/port/darwin.py:
548         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
549         * Scripts/webkitpy/port/driver.py:
550         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
551         (IOSSimulatorDriver): Deleted.
552         * Scripts/webkitpy/port/driver_unittest.py:
553         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
554         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
555         (DriverTest.test_start_actually_starts): Ditto.
556         * Scripts/webkitpy/port/ios.py:
557         (IOSSimulatorPort): Remove relay_name.
558         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
559         (IOSSimulatorPort._create_simulators): Formatting change.
560         (IOSSimulatorPort.relay_path): Deleted.
561         (IOSSimulatorPort._check_relay): Deleted.
562         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
563         (IOSSimulatorPort._build_relay): Deleted.
564         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
565         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
566         * Scripts/webkitpy/port/ios_unittest.py:
567         (iosTest.test_32bit): Update test.
568         (iosTest.test_64bit): Update test.
569         * Scripts/webkitpy/port/server_process.py:
570         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
571         (ServerProcess._set_file_nonblocking): Added to share common code.
572         * Scripts/webkitpy/port/server_process_mock.py:
573         (MockServerProcess.__init__): Added argument worker_number.
574         * Scripts/webkitpy/port/simulator_process.py: Added.
575         (SimulatorProcess): Added.
576         (SimulatorProcess.Popen): Added.
577         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
578         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
579         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
580         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
581         (SimulatorProcess._reset): Added. Unlink fifos.
582         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
583         (SimulatorProcess._kill): Added. Shutdown app on simulator.
584         * Scripts/webkitpy/xcode/simulator.py:
585         (Device.__init__): Accept host to run install/launch/terminate.
586         (Device.install_app): Install app to target Device.
587         (Device.launch_app): Launch app on target Device.
588         (Device.terminate_app): Shutdown app on target Device.
589         (Simulator._parse_devices): Pass host to Device.
590
591 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
592
593         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
594         https://bugs.webkit.org/show_bug.cgi?id=167411
595
596         Reviewed by Michael Catanzaro.
597
598         Disable the ARM iwMMXt fast path for pixman, because it triggers
599         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
600
601         * gtk/jhbuild.modules:
602
603 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [GTK] Add API to handle the accelerated compositing policy
606         https://bugs.webkit.org/show_bug.cgi?id=167509
607
608         Reviewed by Michael Catanzaro.
609
610         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
611         as a special case. Also add test cases to the get/set API.
612
613         * MiniBrowser/gtk/BrowserSettingsDialog.c:
614         (hardwareAccelerationPolicyToString):
615         (stringToHardwareAccelerationPolicy):
616         (cellRendererChanged):
617         (browserSettingsDialogConstructed):
618         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
619         (testWebKitSettings):
620
621 2017-01-29  Andy Estes  <aestes@apple.com>
622
623         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
624         https://bugs.webkit.org/show_bug.cgi?id=167563
625         <rdar://problem/30253207>
626
627         Reviewed by Andreas Kling.
628
629         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
630         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
631         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
632         (runTest):
633         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
634         (TEST):
635
636 2017-01-29  Dan Bernstein  <mitz@apple.com>
637
638         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
639         https://bugs.webkit.org/show_bug.cgi?id=167565
640
641         Reviewed by Sam Weinig.
642
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
645         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
646         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
647         (TEST):
648         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
649         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
650         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
651         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
652
653 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
654
655         Add Link Preload as an off-by-default experimental feature menu item.
656         https://bugs.webkit.org/show_bug.cgi?id=167201
657
658         Reviewed by Ryosuke Niwa.
659
660         * DumpRenderTree/mac/DumpRenderTree.mm:
661         (resetWebPreferencesToConsistentValues):
662         * DumpRenderTree/win/DumpRenderTree.cpp:
663         (resetWebPreferencesToConsistentValues):
664
665 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
666
667         Add User Timing Experimental Feature
668         https://bugs.webkit.org/show_bug.cgi?id=167542
669         <rdar://problem/22746307>
670
671         Reviewed by Ryosuke Niwa.
672
673         * DumpRenderTree/mac/DumpRenderTree.mm:
674         (enableExperimentalFeatures):
675         (resetWebPreferencesToConsistentValues):
676         * DumpRenderTree/win/DumpRenderTree.cpp:
677         (enableExperimentalFeatures):
678
679 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
680
681         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
682         https://bugs.webkit.org/show_bug.cgi?id=167519
683
684         Reviewed by Ryosuke Niwa.
685
686         * QueueStatusServer/templates/statusbubble.html:
687         To measure the bubbleContainer's width, it must not be wrapping based
688         on its parent container. So when measuring the width temporarily set
689         the parent to a very large width so as to not artificially wrap us.
690         Restore the parent's width after measuring.
691
692 2017-01-27  Andy Estes  <aestes@apple.com>
693
694         [iOS] Add a test for _WKNSFileManagerExtras
695         https://bugs.webkit.org/show_bug.cgi?id=167478
696
697         Reviewed by Andreas Kling.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
701         (expectAttributes):
702         (TEST):
703
704 2017-01-27  Keith Miller  <keith_miller@apple.com>
705
706         run-benchmarks should make sure it passes the test url to the right application
707         https://bugs.webkit.org/show_bug.cgi?id=167533
708
709         Reviewed by Joseph Pecoraro.
710
711         This fixes an issue when trying to run-benchmark script with the
712         system default browser set to STP. Previously, it would run
713         the test in STP rather than the provided build. Now, it should run
714         in the provided build.
715
716         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
717         (OSXSafariDriver.launch_url):
718
719 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
720
721         [Cocoa] Prepare ComplexTextController for unit testing
722         https://bugs.webkit.org/show_bug.cgi?id=167493
723
724         Reviewed by Simon Fraser.
725
726         Addressing post-review comments from Simon Fraser.
727
728         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
729         (TestWebKitAPI::TEST_F):
730
731 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
732
733         [Cocoa] Prepare ComplexTextController for unit testing
734         https://bugs.webkit.org/show_bug.cgi?id=167493
735
736         Reviewed by Dean Jackson.
737
738         Create four unit tests.
739
740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
741         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
742         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
743         (TestWebKitAPI::TEST_F):
744
745 2017-01-26  Chris Dumez  <cdumez@apple.com>
746
747         Crash when navigating back to a page in PacheCache when one of its frames has been removed
748         https://bugs.webkit.org/show_bug.cgi?id=167421
749         <rdar://problem/30188490>
750
751         Reviewed by Darin Adler.
752
753         Add a new setting allowing layout tests to enable PageCache in a window
754         that has an opener, for convenience.
755
756         * DumpRenderTree/mac/DumpRenderTree.mm:
757         (resetWebPreferencesToConsistentValues):
758         * DumpRenderTree/win/DumpRenderTree.cpp:
759         (resetWebPreferencesToConsistentValues):
760         * WebKitTestRunner/TestController.cpp:
761         (WTR::TestController::resetPreferencesToConsistentValues):
762
763 2017-01-26  Keith Miller  <keith_miller@apple.com>
764
765         classInfo should take a VM so it is not materialized from the object on each call
766         https://bugs.webkit.org/show_bug.cgi?id=167424
767
768         Rubber Stamped by Michael Saboff.
769
770         Previously, classInfo() would get the VM from the target's
771         MarkedBlock.  Most callers already have a VM on hand, so it is
772         wasteful to compute the VM from the marked block every time. This
773         patch refactors some of the most common callers of classInfo(),
774         jsDynamicCast and inherits to take a VM as well.
775
776         * DumpRenderTree/TestRunner.cpp:
777         (setAudioResultCallback):
778
779 2017-01-26  Jer Noble  <jer.noble@apple.com>
780
781         Autoplay muted videos stop playback of any streaming app in the background
782         https://bugs.webkit.org/show_bug.cgi?id=163993
783         <rdar://problem/29020431>
784
785         Reviewed by Eric Carlson.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
789         (TestWebKitAPI::TEST):
790         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
791
792 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
793
794         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
795         https://bugs.webkit.org/show_bug.cgi?id=167466
796
797         Unreviewed test gardening.
798
799         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
800         (TEST):
801
802 2017-01-26  Matt Rajca  <mrajca@apple.com>
803
804         Notify clients when the user plays media otherwise prevented from autoplaying
805         https://bugs.webkit.org/show_bug.cgi?id=167390
806
807         Reviewed by Alex Christensen.
808
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
811         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
812         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
813         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
814         (TEST):
815         * TestWebKitAPI/cocoa/TestWKWebView.h:
816         * TestWebKitAPI/cocoa/TestWKWebView.mm:
817         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
818         (-[TestWKWebView waitForLoad]):
819         (-[TestWKWebView mouseUpAtPoint:]):
820         * WebKitTestRunner/TestController.cpp:
821         (WTR::TestController::createOtherPage):
822         (WTR::TestController::createWebViewWithOptions):
823
824 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
825
826         Crash when setting custom scale factor.
827         https://bugs.webkit.org/show_bug.cgi?id=167369
828
829         Reviewed by Sam Weinig.
830
831         Added API test.
832
833         * TestWebKitAPI/PlatformWin.cmake:
834         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
835         (TestWebKitAPI::WebKitCreateInstance):
836         (TestWebKitAPI::ScaleWebView::SetUp):
837         (TestWebKitAPI::ScaleWebView::TearDown):
838         (TestWebKitAPI::TEST_F):
839
840 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
841
842         run-benchmark nests MotionMark results by the suite name twice
843         https://bugs.webkit.org/show_bug.cgi?id=164948
844
845         Reviewed by Said Abou-Hallawa.
846
847         Use a single level MotionMark now that this is the name of the benchmark,
848         and we no longer have tests that aren't part of the MotionMark suite.
849
850         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
851
852 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
853
854         Unreviewed, rolling out r211193.
855
856         This change broke internal builds.
857
858         Reverted changeset:
859
860         "Notify clients when the user plays media otherwise prevented
861         from autoplaying"
862         https://bugs.webkit.org/show_bug.cgi?id=167390
863         http://trac.webkit.org/changeset/211193
864
865 2017-01-25  Matt Rajca  <mrajca@apple.com>
866
867         Notify clients when the user plays media otherwise prevented from autoplaying
868         https://bugs.webkit.org/show_bug.cgi?id=167390
869
870         Reviewed by Alex Christensen.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
874         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
875         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
876         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
877         (TEST):
878         * TestWebKitAPI/cocoa/TestWKWebView.h:
879         * TestWebKitAPI/cocoa/TestWKWebView.mm:
880         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
881         (-[TestWKWebView waitForLoad]):
882         (-[TestWKWebView mouseUpAtPoint:]):
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::createOtherPage):
885         (WTR::TestController::createWebViewWithOptions):
886
887 2017-01-25  Matt Rajca  <mrajca@apple.com>
888
889         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
890         https://bugs.webkit.org/show_bug.cgi?id=167385
891
892         Reviewed by Alex Christensen.
893
894         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
895         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
896         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
897         (TEST): Allow inline (rather than full screen) media playback on iOS.
898
899 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
900
901         [GTK] Icon Database should be in private browsing mode for ephemeral web views
902         https://bugs.webkit.org/show_bug.cgi?id=167414
903
904         Reviewed by Michael Catanzaro.
905
906         Add a test case to check ephemeral web views don't write favicons to the database.
907
908         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
909         (ephemeralViewLoadChanged):
910         (testPrivateBrowsing):
911         (testFaviconDatabase):
912
913 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
914
915         [GTK] Add a private browsing mode to MiniBrowser
916         https://bugs.webkit.org/show_bug.cgi?id=167413
917
918         Reviewed by Michael Catanzaro.
919
920         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
921         private windows, even on non-private instances.
922
923         * MiniBrowser/gtk/BrowserWindow.c:
924         (webViewTitleChanged): Add [Private] to title window for private windows.
925         (webViewCreate): Pass web context to browser_window_new.
926         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
927         (browserWindowFinalize): Disconnect web context signal handlers.
928         (browser_window_init): Add shortcut for opening private window.
929         (browser_window_new): It now receives the context and connect to download-started here.
930         (browser_window_get_web_context): Return the context.
931         * MiniBrowser/gtk/BrowserWindow.h:
932         * MiniBrowser/gtk/main.c:
933         (createBrowserTab): Create the web view for the window web context.
934         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
935         (aboutDataHandleRequest): Ditto.
936         (aboutURISchemeRequestCallback): Ditto.
937         (main): Create ephemeral web context if private command line option is used.
938
939 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
940
941         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
942         https://bugs.webkit.org/show_bug.cgi?id=167409
943
944         Reviewed by Antti Koivisto.
945
946         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
947         as well as tests for the newly added matchingElementInFlatTree.
948
949         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
950         (TestWebKitAPI::runJavaScriptAlert):
951         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
952         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
953         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
954
955 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
956
957         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
958         https://bugs.webkit.org/show_bug.cgi?id=167370
959
960         Reviewed by Michael Catanzaro.
961
962         Add several test cases of ephemeral web views.
963
964         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
965         (testWebViewAuthenticationStorage):
966         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
967         (ephemeralViewloadChanged):
968         (testCookieManagerEphemeral):
969         (beforeAll):
970         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
971         (testWebKitSettings):
972         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
973         (testWebContextEphemeral):
974         (ephemeralViewloadChanged):
975         (testWebContextProxySettings):
976         (beforeAll):
977         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
978         (ephemeralViewloadChanged):
979         (testWebViewEphemeral):
980         (beforeAll):
981         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
982         (ephemeralViewloadChanged):
983         (testWebsiteDataEphemeral):
984         (beforeAll):
985
986 2017-01-24  Alex Christensen  <achristensen@webkit.org>
987
988         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
989         https://bugs.webkit.org/show_bug.cgi?id=167402
990
991         Reviewed by Ryosuke Niwa.
992
993         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
994         (TestWebKitAPI::TEST):
995
996 2017-01-24  Zalan Bujtas  <zalan@apple.com>
997
998         Add simple line layout toggle to MiniBrowser
999         https://bugs.webkit.org/show_bug.cgi?id=167405
1000
1001         Reviewed by Andreas Kling.
1002
1003         * MiniBrowser/mac/SettingsController.h:
1004         * MiniBrowser/mac/SettingsController.m:
1005         (-[SettingsController _populateMenu]):
1006         (-[SettingsController validateMenuItem:]):
1007         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1008         (-[SettingsController simpleLineLayoutEnabled]):
1009         * MiniBrowser/mac/WK1BrowserWindowController.m:
1010         (-[WK1BrowserWindowController didChangeSettings]):
1011         * MiniBrowser/mac/WK2BrowserWindowController.m:
1012         (-[WK2BrowserWindowController didChangeSettings]):
1013
1014 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1015
1016         WKR does not include my nick when commit-queue lands my patch
1017         https://bugs.webkit.org/show_bug.cgi?id=167388
1018
1019         Reviewed by Ryosuke Niwa.
1020
1021         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1022         (NewCommitBot._summarize_commit_log):
1023         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1024         Perform nickname insertion before grabbing "Patch by" details.
1025         This way we can include the nickname with the full name.
1026
1027 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1028
1029         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1030         https://bugs.webkit.org/show_bug.cgi?id=167394
1031
1032         Reviewed by Ryosuke Niwa.
1033
1034         * Scripts/webkitperl/FeatureList.pm:
1035         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1036
1037 2017-01-24  Youenn Fablet  <youenn@apple.com>
1038
1039         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1040         https://bugs.webkit.org/show_bug.cgi?id=167353
1041
1042         Reviewed by Alex Christensen.
1043
1044         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1045         (CMakeGenerator.initialize_targets):
1046
1047 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1048
1049         WKR should not confuse Miguel Gomez with Andres Gomez
1050         https://bugs.webkit.org/show_bug.cgi?id=167389
1051
1052         Reviewed by Lucas Forschler.
1053
1054         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1055         "mAndres Gomez". Fix this.
1056
1057         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1058         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1059         space on each side of the email address, so expect both spaces to be there before
1060         considering the email for replacement.
1061         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1062
1063 2017-01-24  Matt Rajca  <mrajca@apple.com>
1064
1065         Pass down website autoplay policies to media elements
1066         https://bugs.webkit.org/show_bug.cgi?id=167355
1067
1068         Reviewed by Alex Christensen.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1072         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1073         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1074         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1075         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1076         (TEST):
1077
1078 2017-01-24  Nan Wang  <n_wang@apple.com>
1079
1080         AX: Speak Selection does not work in an iframe
1081         https://bugs.webkit.org/show_bug.cgi?id=166794
1082         <rdar://problem/29913013>
1083
1084         Reviewed by Chris Fleizach.
1085
1086         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1087         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1088         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1089         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1090         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1091         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1092         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1093         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1094         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1095         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1096         (-[TestRunnerWKWebView dealloc]):
1097         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1098         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1099         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1100         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1101         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1102
1103 2017-01-24  Daniel Bates  <dabates@apple.com>
1104
1105         StringView.split() should use an iterator design pattern instead of allocating a Vector
1106         https://bugs.webkit.org/show_bug.cgi?id=163225
1107
1108         Reviewed by Darin Adler.
1109
1110         Add unit tests for StringView.split().
1111
1112         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1113         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1114         used in the StringView.split() unit tests.
1115         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1116         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1117         object to a Vector of String objects.
1118         (TestWebKitAPI::TEST): Added the following tests:
1119             - WTF.StringViewSplitEmptyAndNullStrings
1120             - WTF.StringViewSplitBasic
1121             - WTF.StringViewSplitWithConsecutiveSeparators
1122
1123 2017-01-23  Anders Carlsson  <andersca@apple.com>
1124
1125         The Score Esports crashes on launch
1126         https://bugs.webkit.org/show_bug.cgi?id=167338
1127         rdar://problem/29948645
1128
1129         Reviewed by Dan Bernstein.
1130
1131         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1132         (TestWebKitAPI::TEST):
1133         Add a test.
1134
1135 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1136
1137         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1138         https://bugs.webkit.org/show_bug.cgi?id=146589
1139
1140         Reviewed by Michael Catanzaro.
1141
1142         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1143         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1144
1145         * MiniBrowser/gtk/BrowserWindow.c:
1146         (webViewDecidePolicy):
1147         (newTabCallback):
1148         * MiniBrowser/gtk/main.c:
1149         (createBrowserTab):
1150         (aboutDataRequestFree):
1151         (aboutDataRequestNew):
1152         (aboutDataRequestForView):
1153         (websiteDataRemovedCallback):
1154         (websiteDataClearedCallback):
1155         (aboutDataScriptMessageReceivedCallback):
1156         (domainListFree):
1157         (aboutDataFillTable):
1158         (gotWebsiteDataCallback):
1159         (aboutDataHandleRequest):
1160         (aboutURISchemeRequestCallback):
1161         (main):
1162         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1163         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1164         (serverCallback):
1165         (beforeAll):
1166         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1167         (serverCallback):
1168         (WebsiteDataTest::WebsiteDataTest):
1169         (WebsiteDataTest::~WebsiteDataTest):
1170         (WebsiteDataTest::fetch):
1171         (WebsiteDataTest::remove):
1172         (WebsiteDataTest::clear):
1173         (testWebsiteDataConfiguration):
1174         (testWebsiteDataCache):
1175         (testWebsiteDataStorage):
1176         (testWebsiteDataDatabases):
1177         (testWebsiteDataAppcache):
1178         (beforeAll):
1179         (afterAll):
1180
1181 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1182
1183         Unreviewed, rolling out r211062.
1184         https://bugs.webkit.org/show_bug.cgi?id=167354
1185
1186         broke API tests (Requested by alexchristensen on #webkit).
1187
1188         Reverted changeset:
1189
1190         "Pass down website autoplay policies to media elements"
1191         https://bugs.webkit.org/show_bug.cgi?id=167132
1192         http://trac.webkit.org/changeset/211062
1193
1194 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1195
1196         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1197         https://bugs.webkit.org/show_bug.cgi?id=167330
1198
1199         Reviewed by Tim Horton.
1200
1201         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1202         (TestWebKitAPI::TEST_F):
1203
1204 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1205
1206         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1207         https://bugs.webkit.org/show_bug.cgi?id=167317
1208
1209         Reviewed by Sam Weinig.
1210
1211         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1212         (TestWebKitAPI::TEST_F):
1213
1214 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1215
1216         svn-create-patch should emit properties when files are moved or copied
1217         https://bugs.webkit.org/show_bug.cgi?id=167264
1218
1219         Reviewed by Daniel Bates.
1220
1221         * Scripts/svn-create-patch:
1222         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1223
1224 2017-01-23  Youenn Fablet  <youenn@apple.com>
1225
1226         [WebRTC] Filter libwebrtc link flags
1227         https://bugs.webkit.org/show_bug.cgi?id=167287
1228
1229         Reviewed by Alex Christensen.
1230
1231         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1232         (CMakeGenerator._compute_link_flags):
1233         (CMakeGenerator._compute_link_flags.keep_flag):
1234         (CMakeGenerator._generate_compile_target_options):
1235
1236 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1237
1238         [WebRTC] Make VP8 optional in libwebrtc
1239         https://bugs.webkit.org/show_bug.cgi?id=167257
1240
1241         Reviewed by Darin Adler.
1242
1243         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1244         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1245
1246 2017-01-23  Jer Noble  <jer.noble@apple.com>
1247
1248         Video details does not apear and missing scrubber in Control Center
1249         https://bugs.webkit.org/show_bug.cgi?id=167233
1250
1251         Reviewed by Alex Christensen.
1252
1253         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1254         NowPlayingControlTests for iOS.
1255
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1257         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1258         (-[NowPlayingTestWebView setWindowVisible:]):
1259         (TestWebKitAPI::TEST):
1260         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1261         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1262         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1263         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1264         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1265         (SOFT_LINK_CLASS):
1266         (-[TestMessageHandler addMessage:withHandler:]):
1267         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1268         (__simulated_forceClickAssociatedEventsMask):
1269         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1270         (-[TestWKWebViewHostWindow isKeyWindow]):
1271         (-[TestWKWebViewHostWindow makeKeyWindow]):
1272         (-[TestWKWebViewHostWindow resignKeyWindow]):
1273         (-[TestWKWebView initWithFrame:]):
1274         (-[TestWKWebView initWithFrame:configuration:]):
1275         (-[TestWKWebView _setUpTestWindow:]):
1276         (-[TestWKWebView performAfterReceivingMessage:action:]):
1277         (-[TestWKWebView loadTestPageNamed:]):
1278         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1279         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1280         (-[TestWKWebView waitForMessage:]):
1281         (-[TestWKWebView performAfterLoading:]):
1282         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1283         (-[TestWKWebView typeCharacter:]):
1284
1285 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1286
1287         Unreviewed. Bring back gtk-doc error messages after r209981.
1288
1289         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1290         impossible to know what's wrong.
1291
1292         * gtk/gtkdoc.py:
1293         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1294
1295 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1296
1297         [WebRTC] Update build system to make G711 optional in libwebrtc
1298         https://bugs.webkit.org/show_bug.cgi?id=167256
1299
1300         Reviewed by Alex Christensen.
1301
1302         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1303         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1304
1305 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1306
1307         Cleanup RuntimeEnabledFeatures
1308         https://bugs.webkit.org/show_bug.cgi?id=167228
1309
1310         Reviewed by Simon Fraser.
1311
1312         * DumpRenderTree/mac/DumpRenderTree.mm:
1313         (enableExperimentalFeatures):
1314         (resetWebPreferencesToConsistentValues):
1315         (setWebPreferencesForTestOptions):
1316         (resetWebViewToConsistentStateBeforeTesting):
1317         * DumpRenderTree/win/DumpRenderTree.cpp:
1318         (enableExperimentalFeatures):
1319         (resetWebPreferencesToConsistentValues):
1320         More closely match WebKitTestRunner initialization of preferences
1321         for experimental features.
1322
1323 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1324
1325         Build Fix for Windows DumpRenderTree after r210976
1326         https://bugs.webkit.org/show_bug.cgi?id=167115
1327
1328         * DumpRenderTree/win/DumpRenderTree.cpp:
1329         (resetWebPreferencesToConsistentValues):
1330
1331 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1332
1333         Remove outdated ENABLE(CSP_NEXT) build flag
1334         https://bugs.webkit.org/show_bug.cgi?id=167252
1335
1336         Reviewed by Brent Fulgham.
1337
1338         * Scripts/webkitperl/FeatureList.pm:
1339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1340
1341 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1342
1343         Build Fix for Windows DumpRenderTree after r210976
1344
1345         * DumpRenderTree/win/DumpRenderTree.cpp:
1346         (resetWebPreferencesToConsistentValues):
1347
1348 2017-01-20  Antoine Quint  <graouts@apple.com>
1349
1350         Web Animations should be off by default and enabled as an experimental feature
1351         https://bugs.webkit.org/show_bug.cgi?id=167115
1352         <rdar://problem/30048963>
1353
1354         Reviewed by Joseph Pecoraro.
1355
1356         Turn Web Animations on in DRT.
1357
1358         * DumpRenderTree/mac/DumpRenderTree.mm:
1359         (resetWebPreferencesToConsistentValues):
1360         * DumpRenderTree/win/DumpRenderTree.cpp:
1361         (resetWebPreferencesToConsistentValues):
1362
1363 2017-01-20  Youenn Fablet  <youenn@apple.com>
1364
1365         [WebRTC] Add libwebrtc build infrastructure
1366         https://bugs.webkit.org/show_bug.cgi?id=167207
1367
1368         Reviewed by Alex Christensen.
1369
1370         Adding a script doing the libwebrtc project json to CMake file conversion.
1371
1372         * Scripts/generate-libwebrtc-cmake: Added.
1373         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1374         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1375
1376 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1377
1378         Mini Browser: Show tooltip for Experimental Features
1379         https://bugs.webkit.org/show_bug.cgi?id=167225
1380
1381         Reviewed by Alex Christensen.
1382
1383         * MiniBrowser/mac/SettingsController.m:
1384         (-[SettingsController _populateMenu]):
1385         Include the full details string as a tooltip.
1386
1387 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1388
1389         [Win] Test output results should not be written twice.
1390         https://bugs.webkit.org/show_bug.cgi?id=167197
1391
1392         Reviewed by Brent Fulgham.
1393
1394         Prevent test output from being written twice by returning early from
1395         the dump() function, if it already has been called.
1396         This patch also adds a missing newline to a test output line. 
1397         
1398         * DumpRenderTree/win/DumpRenderTree.cpp:
1399         (dump):
1400
1401 2017-01-20  Antoine Quint  <graouts@apple.com>
1402
1403         [Modern Media Controls] Turn modern media controls on by default
1404         https://bugs.webkit.org/show_bug.cgi?id=165668
1405
1406         Reviewed by Dean Jackson.
1407
1408         Enabled modern media controls by default in test runners.
1409
1410         * DumpRenderTree/TestOptions.h:
1411         * WebKitTestRunner/TestOptions.h:
1412
1413 2017-01-19  Chris Dumez  <cdumez@apple.com>
1414
1415         iterable<> should be enabled on WK1
1416         https://bugs.webkit.org/show_bug.cgi?id=167221
1417         <rdar://problem/30108531>
1418
1419         Reviewed by Youenn Fablet.
1420
1421         * DumpRenderTree/mac/DumpRenderTree.mm:
1422         (resetWebPreferencesToConsistentValues):
1423         * DumpRenderTree/win/DumpRenderTree.cpp:
1424         (resetWebPreferencesToConsistentValues):
1425         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1426         (WTR::InjectedBundle::beginTesting):
1427         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1428         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1430
1431 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1432
1433         Ensure status server logs go to log file
1434         https://bugs.webkit.org/show_bug.cgi?id=167210
1435
1436         Reviewed by Alexey Proskuryakov.
1437
1438         * Scripts/webkitpy/common/net/statusserver.py:
1439         (StatusServer.next_work_item): Change log level from debug to info in
1440         order to facilitate deubgging issues.
1441         (StatusServer.update_work_items): Same.
1442
1443 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1444
1445         Additional selection tests and interpolation fix
1446         https://bugs.webkit.org/show_bug.cgi?id=167171
1447
1448         Reviewed by Simon Fraser.
1449
1450         We weren't adding the final event when interpolating event streams.
1451
1452         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1453         (-[HIDEventGenerator interpolatedEvents:]):
1454
1455 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1456
1457         [Cocoa] Variation fonts are erroneously disabled on iOS
1458         https://bugs.webkit.org/show_bug.cgi?id=167172
1459
1460         Reviewed by Simon Fraser.
1461
1462         OpenSource builders don't seem to understand sdk=embedded*.
1463
1464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1465
1466 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1467
1468         Unreviewed. Fix GTK+ unit tests failing since r210531.
1469
1470         Avoid using paths to files that don't actually exist.
1471
1472         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1473         (testWebKitConsoleMessageNetworkError):
1474         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1475         (testContextMenuDefaultMenu):
1476         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1477         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1478         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1479
1480 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1481
1482         [GTK] Provide API to set proxy settings
1483         https://bugs.webkit.org/show_bug.cgi?id=128674
1484
1485         Reviewed by Michael Catanzaro.
1486
1487         Add tests for new proxy settings API.
1488
1489         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1490         (serverCallback):
1491         (ProxyTest::ProxyTest):
1492         (ProxyTest::~ProxyTest):
1493         (ProxyTest::loadURIAndGetMainResourceData):
1494         (ProxyTest::proxyServerPortAsString):
1495         (testWebContextProxySettings):
1496         (beforeAll):
1497
1498 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1499
1500         Add back my old email address so old commits will still match it.
1501
1502         * Scripts/webkitpy/common/config/contributors.json:
1503
1504 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1505
1506         Remove my old email address from contributors.json and watchlist.
1507
1508         * Scripts/validate-committer-lists:
1509         (CommitterListFromGit): Change the mapping to the correct email.
1510         * Scripts/webkitpy/common/config/contributors.json:
1511         * Scripts/webkitpy/common/config/watchlist:
1512
1513 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1514
1515         Unreviewed, rolling out r210848.
1516
1517         This change introduced media-related LayoutTest failures and
1518         crashes on macOS.
1519
1520         Reverted changeset:
1521
1522         "[Modern Media Controls] Turn modern media controls on by
1523         default"
1524         https://bugs.webkit.org/show_bug.cgi?id=165668
1525         http://trac.webkit.org/changeset/210848
1526
1527 2017-01-18  Andreas Kling  <akling@apple.com>
1528
1529         Document::securityOrigin() should return a reference.
1530         <https://webkit.org/b/167124>
1531
1532         Reviewed by Sam Weinig.
1533
1534         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1535         (TestWebKitAPI::TEST_F):
1536
1537 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1538
1539         [Win] Clipboard tests are flaky.
1540         https://bugs.webkit.org/show_bug.cgi?id=167088
1541
1542         Reviewed by Brent Fulgham.
1543
1544         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1545         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1546
1547         * DumpRenderTree/win/DumpRenderTree.cpp:
1548         (main):
1549
1550 2017-01-18  Antoine Quint  <graouts@apple.com>
1551
1552         [Modern Media Controls] Turn modern media controls on by default
1553         https://bugs.webkit.org/show_bug.cgi?id=165668
1554
1555         Reviewed by Dean Jackson.
1556
1557         Enabled modern media controls by default in test runners. 
1558
1559         * DumpRenderTree/TestOptions.h:
1560         * WebKitTestRunner/TestOptions.h:
1561
1562 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1563
1564         Unreviewed, rolling out r210834
1565         https://bugs.webkit.org/show_bug.cgi?id=165668
1566
1567         It introduced dozens of test timeouts.
1568
1569         Reverted changeset:
1570         "[Modern Media Controls] Turn modern media controls on by default"
1571         https://bugs.webkit.org/show_bug.cgi?id=165668
1572         http://trac.webkit.org/changeset/210834
1573
1574 2017-01-17  Antoine Quint  <graouts@apple.com>
1575
1576         [Modern Media Controls] Turn modern media controls on by default
1577         https://bugs.webkit.org/show_bug.cgi?id=165668
1578
1579         Reviewed by Dean Jackson.
1580
1581         Enabled modern media controls by default in test runners. 
1582
1583         * DumpRenderTree/TestOptions.h:
1584         * WebKitTestRunner/TestOptions.h:
1585
1586 2017-01-17  Chris Dumez  <cdumez@apple.com>
1587
1588         Document title changed twice when setting document.title
1589         https://bugs.webkit.org/show_bug.cgi?id=167065
1590
1591         Reviewed by Darin Adler.
1592
1593         Add WebKit2GTK API test that was written by Michael Catanzaro.
1594
1595         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1596         (testWebViewTitleChange):
1597         (beforeAll):
1598
1599 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1600
1601         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1602         https://bugs.webkit.org/show_bug.cgi?id=116551
1603         <rdar://problem/13949830>
1604
1605         Reviewed by Alex Christensen.
1606
1607         * Scripts/webkitperl/FeatureList.pm:
1608         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1609         that is part of the existing WEB_TIMING feature.
1610
1611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1612
1613 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1614
1615         'webkit-patch post' no longer works with moved/copied files
1616         https://bugs.webkit.org/show_bug.cgi?id=166914
1617         <rdar://problem/29979707>
1618
1619         Reviewed by Daniel Bates.
1620
1621         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1622         file outputs only the "Index:" line with an empty body.  This workaround
1623         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1624         public email list tracking this bug is below.
1625         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1626         
1627
1628         * Scripts/svn-create-patch:
1629         (generateDiff): Ignore an "Index:" line with an empty body.
1630
1631 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1632
1633         Remove the REQUEST_ANIMATION_FRAME flag
1634         https://bugs.webkit.org/show_bug.cgi?id=156980
1635         <rdar://problem/25906849>
1636
1637         Reviewed by Simon Fraser.
1638
1639         * Scripts/webkitperl/FeatureList.pm:
1640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1641
1642 2017-01-15  Sam Weinig  <sam@webkit.org>
1643
1644         Add the ability to use numbers in makeString()
1645         https://bugs.webkit.org/show_bug.cgi?id=167087
1646
1647         Reviewed by Darin Adler.
1648
1649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1650         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1651         Add tests for StringConcatenate, focusing on new numeric additions.
1652
1653 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1654
1655         Unreviewed, remove stale comment.
1656
1657         This test was fixed by r163173.
1658
1659         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1660
1661 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1662
1663         Annotate large string tests with largeHeap
1664         https://bugs.webkit.org/show_bug.cgi?id=167054
1665
1666         Reviewed by Filip Pizlo.
1667
1668         * Scripts/run-javascriptcore-tests:
1669         * Scripts/run-jsc-stress-tests:
1670
1671 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1672
1673         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1674         https://bugs.webkit.org/show_bug.cgi?id=167043
1675
1676         Reviewed by Darin Adler.
1677
1678         * Scripts/webkitperl/FeatureList.pm:
1679
1680 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1681
1682         Remove ENABLE(DETAILS_ELEMENT) guards
1683         https://bugs.webkit.org/show_bug.cgi?id=167042
1684
1685         Reviewed by Alex Christensen.
1686
1687         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1688
1689 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1690
1691         26 MotionMark performance tests failing
1692         https://bugs.webkit.org/show_bug.cgi?id=166854
1693
1694         Reviewed by Ryosuke Niwa.
1695
1696         Unrelated change. This is the last place that we need to rename Animometer
1697         to MotionMark.
1698
1699         * Scripts/webkitpy/common/config/watchlist:
1700
1701 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1702
1703         run-jsc-benchmarks' echo should have -e option
1704         https://bugs.webkit.org/show_bug.cgi?id=167009
1705
1706         Reviewed by Sam Weinig.
1707
1708         echo requires `-e` option to use escape sequence.
1709         Without it, in some environment (in my Fedora 25), the escape sequence is not
1710         recognized and just dumped as `\c` etc.
1711
1712         * Scripts/run-jsc-benchmarks:
1713
1714 2017-01-12  Chris Dumez  <cdumez@apple.com>
1715
1716         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1717         https://bugs.webkit.org/show_bug.cgi?id=166995
1718
1719         Reviewed by Jer Noble.
1720
1721         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1722         as some people are having trouble building without it.
1723
1724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1725
1726 2017-01-12  Sam Weinig  <sam@webkit.org>
1727
1728         Add the ability to filter the set of bindings tests you want to run
1729         https://bugs.webkit.org/show_bug.cgi?id=166977
1730
1731         Reviewed by Tim Horton.
1732
1733         Allows doing things like:
1734             run-bindings-tests TestObj* TestCEReactions*
1735         
1736         to run only those tests that match the patterns.
1737
1738         * Scripts/run-bindings-tests:
1739         (main):
1740         Switch to using optparse and pass the remaining args as the filters.
1741
1742         * Scripts/webkitpy/bindings/main.py:
1743         (BindingsTests.__init__):
1744         Store the pattens.
1745
1746         (BindingsTests.test_matches_patterns):
1747         Add helper predicate to determine if a test should be run. When no
1748         patterns are present, all tests should run.
1749
1750         (BindingsTests.run_tests):
1751         Filter tests using the passed in patterns.
1752
1753 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1754
1755         Followup fix after r210503.
1756         https://bugs.webkit.org/show_bug.cgi?id=166887
1757
1758         Reviewed by Alex Christensen.
1759
1760         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1761         duplicated file handle on Windows. This patch fixes the remaining call sites.
1762
1763         * DumpRenderTree/PixelDumpSupport.cpp:
1764         * DumpRenderTree/TestRunner.cpp:
1765         (TestRunner::waitToDumpWatchdogTimerFired):
1766         * DumpRenderTree/TestRunner.h:
1767         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1768         * DumpRenderTree/win/DumpRenderTree.cpp:
1769         * DumpRenderTree/win/DumpRenderTreeWin.h:
1770         * DumpRenderTree/win/TestRunnerWin.cpp:
1771         (TestRunner::setSpellCheckerLoggingEnabled):
1772
1773 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1774
1775         Add committer status for Megan
1776         https://bugs.webkit.org/show_bug.cgi?id=166954
1777
1778         Reviewed by Tim Horton.
1779
1780         Add committer status for Megan Gardner
1781
1782         * Scripts/webkitpy/common/config/contributors.json:
1783
1784 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1785
1786         Unreviewed test fix after r210599.
1787
1788         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1789         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1790
1791 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1792
1793         Unreviewed build fix after r210599.
1794
1795         Add missing files.
1796
1797         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1798         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1799
1800 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1801
1802         File scheme should not allow access of a resource on a different volume.
1803         https://bugs.webkit.org/show_bug.cgi?id=158552
1804         <rdar://problem/15307582>
1805
1806         Reviewed by Alex Christensen.
1807
1808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1809         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1810         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1811
1812 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1813
1814         Unreviewed, rolling out r210571.
1815
1816         This change broke the 32-bit macOS build and caused LayoutTest
1817         failures.
1818
1819         Reverted changeset:
1820
1821         "File scheme should not allow access of a resource on a
1822         different volume."
1823         https://bugs.webkit.org/show_bug.cgi?id=158552
1824         http://trac.webkit.org/changeset/210571
1825
1826 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1827
1828         [GTK] install-dependencies script misses gdb
1829         https://bugs.webkit.org/show_bug.cgi?id=166917
1830
1831         Reviewed by Michael Catanzaro.
1832
1833         gdb is needed for generating the crash logs.
1834
1835         * gtk/install-dependencies:
1836
1837 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1838
1839         [GTK] No way for applications to set notification permissions without waiting for permission request
1840         https://bugs.webkit.org/show_bug.cgi?id=163366
1841
1842         Reviewed by Carlos Garcia Campos.
1843
1844         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1845         (testWebViewNotification):
1846         (setInitialNotificationPermissionsAllowedCallback):
1847         (setInitialNotificationPermissionsDisallowedCallback):
1848         (testWebViewNotificationInitialPermissionAllowed):
1849         (testWebViewNotificationInitialPermissionDisallowed):
1850         (beforeAll):
1851         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1852         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1853         (WebViewTest::WebViewTest):
1854         (WebViewTest::initializeWebView):
1855         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1856
1857 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1858
1859         MobileMiniBrowser tests don't work by default
1860         https://bugs.webkit.org/show_bug.cgi?id=166910
1861
1862         Reviewed by Alex Christensen.
1863
1864         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1865         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1866
1867 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1868
1869         File scheme should not allow access of a resource on a different volume.
1870         https://bugs.webkit.org/show_bug.cgi?id=158552
1871         <rdar://problem/15307582>
1872
1873         Reviewed by Alex Christensen.
1874
1875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1876         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1877         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1878
1879 2017-01-10  Mark Lam  <mark.lam@apple.com>
1880
1881         Reverting run-jsc-stress-tests' $buildType to use string values.
1882         https://bugs.webkit.org/show_bug.cgi?id=166912
1883
1884         Rubber stamped by Filip Pizlo.
1885
1886         This is so that we can test for it in the tests e.g.
1887         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1888
1889         * Scripts/run-jsc-stress-tests:
1890
1891 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1892
1893         Temporarily add back the file removed in r210463 to unbreak internal bots.
1894
1895         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1896
1897 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1898
1899         svn-apply failed to apply a patch (deleting file with svn property)
1900         https://bugs.webkit.org/show_bug.cgi?id=165953
1901
1902         Reviewed by Daniel Bates.
1903
1904         * Scripts/VCSUtils.pm:
1905         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1906         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1907
1908 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1909
1910         Update flakiness dashboard configuration.
1911         https://bugs.webkit.org/show_bug.cgi?id=166869
1912
1913         Reviewed by Alexey Proskuryakov.
1914
1915         * TestResultServer/static-dashboards/builders.jsonp:
1916         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1917
1918 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1919
1920         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1921         https://bugs.webkit.org/show_bug.cgi?id=165232
1922
1923         Unreviewed follow-up patch after r210539 and r210523.
1924
1925         Instead of using that environment variable, the argument
1926         --display-server=xorg should be passed now.
1927
1928         The GTK+ performance bot was the only bot using this, and is
1929         already passing --display-server=xorg after r210539.
1930
1931         * Scripts/webkitpy/port/gtk.py:
1932         (GtkPort._driver_class):
1933
1934 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1935
1936         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1937         https://bugs.webkit.org/show_bug.cgi?id=166872
1938
1939         Reviewed by Michael Catanzaro.
1940
1941         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1942         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1943         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1944         The step RunWebKitTests already has support for it.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/config.json:
1947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1948         (RunGtkAPITests.start):
1949         (RunAndUploadPerfTests.start):
1950         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1951
1952 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1953
1954         Unreviewed, rolling out r210531.
1955
1956         This change broke the 32-bit macOS build and caused LayoutTest
1957         failures.
1958
1959         Reverted changeset:
1960
1961         "File scheme should not allow access of a resource on a
1962         different volume."
1963         https://bugs.webkit.org/show_bug.cgi?id=158552
1964         http://trac.webkit.org/changeset/210531
1965
1966 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1967
1968         File scheme should not allow access of a resource on a different volume.
1969         https://bugs.webkit.org/show_bug.cgi?id=158552
1970         <rdar://problem/15307582>
1971
1972         Reviewed by Alex Christensen.
1973
1974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1975         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1976         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1977
1978 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1979
1980         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1981         https://bugs.webkit.org/show_bug.cgi?id=165232
1982
1983         Reviewed by Michael Catanzaro.
1984
1985         Add a new WaylandDriver to run the tests in the user current wayland session.
1986
1987         Also merge all the configuration options for selecting the display server inside one
1988         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1989
1990         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1991
1992         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1993         (TestRunner._create_driver):
1994         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1995         (parse_args):
1996         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1997         (PerfTestsRunner._parse_args):
1998         * Scripts/webkitpy/port/gtk.py:
1999         (GtkPort.__init__):
2000         (GtkPort._driver_class):
2001         (GtkPort._search_paths):
2002         * Scripts/webkitpy/port/waylanddriver.py: Added.
2003         (WaylandDriver):
2004         (WaylandDriver.check_driver):
2005         (WaylandDriver._setup_environ_for_test):
2006         (WaylandDriver._start):
2007
2008 2017-01-09  Andy Estes  <aestes@apple.com>
2009
2010         [QuickLook] Add a layout test for webkit.org/b/135651
2011         https://bugs.webkit.org/show_bug.cgi?id=166855
2012
2013         Reviewed by Andreas Kling.
2014
2015         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2016         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2017         errors with code WebKitErrorCannotShowURL.
2018         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2019         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2020         not specific to WebKit2 error codes.
2021
2022 2017-01-09  Antoine Quint  <graouts@apple.com>
2023
2024         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2025         https://bugs.webkit.org/show_bug.cgi?id=166837
2026
2027         Reviewed by Alex Christensen.
2028
2029         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2030         the provided value when trying to determine the path to the test file. Failing
2031         that, we use the computed URL or the raw path provided to cover all cases.
2032         
2033         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2034         by applying this patch and seeing the number test failures dramatically reduced
2035         with WK1 due to the option to turn modern media controls off for older media controls
2036         tests.
2037
2038         * DumpRenderTree/DumpRenderTree.h:
2039         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2040         (parseInputLine):
2041         * DumpRenderTree/TestOptions.h:
2042         * DumpRenderTree/TestOptions.mm:
2043         (TestOptions::TestOptions):
2044         * DumpRenderTree/mac/DumpRenderTree.mm:
2045         (runTest):
2046
2047 2017-01-09  Milan Crha  <mcrha@redhat.com>
2048
2049         prepare-ChangeLog: Correct help string for --style option
2050         https://bugs.webkit.org/show_bug.cgi?id=166725
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         * Scripts/prepare-ChangeLog:
2055         (main):
2056
2057 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2058
2059         https://bugs.webkit.org/show_bug.cgi?id=166839
2060         Add php7 support for macOS.
2061         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2062
2063         Reviewed by Alexey Proskuryakov.
2064
2065         * Scripts/webkitpy/port/base.py:
2066         (Port._is_darwin_php_version_7):
2067         (Port._debian_php_version):
2068         (Port):
2069         (Port._darwin_php_version):
2070         (Port._apache_config_file_name_for_platform):
2071
2072 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2073
2074         [GTK] Should support key and code properties on keyboard events
2075         https://bugs.webkit.org/show_bug.cgi?id=166759
2076
2077         Reviewed by Carlos Garcia Campos.
2078
2079         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2080         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2081         on tests.
2082
2083 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2084
2085         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2086         https://bugs.webkit.org/show_bug.cgi?id=166760
2087
2088         Reviewed by Darin Adler.
2089
2090         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2091         We can work around that by duplicating and redirecting stdout.
2092
2093         * DumpRenderTree/PixelDumpSupport.cpp:
2094         (dumpWebViewAsPixelsAndCompareWithExpected):
2095         (printPNG):
2096         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2097         (logEventProc):
2098         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2099         (DRTDesktopNotificationPresenter::showDesktopNotification):
2100         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2101         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2102         * DumpRenderTree/win/DumpRenderTree.cpp:
2103         (dumpFrameScrollPosition):
2104         (dumpHistoryItem):
2105         (dumpBackForwardList):
2106         (dump):
2107         (runTest):
2108         (main):
2109         * DumpRenderTree/win/DumpRenderTreeWin.h:
2110         * DumpRenderTree/win/EditingDelegate.cpp:
2111         (EditingDelegate::shouldBeginEditingInDOMRange):
2112         (EditingDelegate::shouldEndEditingInDOMRange):
2113         (EditingDelegate::shouldInsertNode):
2114         (EditingDelegate::shouldInsertText):
2115         (EditingDelegate::shouldDeleteDOMRange):
2116         (EditingDelegate::shouldChangeSelectedDOMRange):
2117         (EditingDelegate::shouldApplyStyle):
2118         (EditingDelegate::shouldChangeTypingStyle):
2119         (EditingDelegate::doPlatformCommand):
2120         (EditingDelegate::webViewDidBeginEditing):
2121         (EditingDelegate::webViewDidChange):
2122         (EditingDelegate::webViewDidEndEditing):
2123         (EditingDelegate::webViewDidChangeTypingStyle):
2124         (EditingDelegate::webViewDidChangeSelection):
2125         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2126         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2127         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2128         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2129         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2130         (FrameLoadDelegate::didCommitLoadForFrame):
2131         (FrameLoadDelegate::didReceiveTitle):
2132         (FrameLoadDelegate::didFinishLoadForFrame):
2133         (FrameLoadDelegate::didFailLoadWithError):
2134         (FrameLoadDelegate::willPerformClientRedirectToURL):
2135         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2136         (FrameLoadDelegate::windowScriptObjectAvailable):
2137         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2138         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2139         (FrameLoadDelegate::didDisplayInsecureContent):
2140         (FrameLoadDelegate::didRunInsecureContent):
2141         (FrameLoadDelegate::webViewProgressFinishedNotification):
2142         * DumpRenderTree/win/HistoryDelegate.cpp:
2143         (HistoryDelegate::didNavigateWithNavigationData):
2144         (HistoryDelegate::didPerformClientRedirectFromURL):
2145         (HistoryDelegate::didPerformServerRedirectFromURL):
2146         (HistoryDelegate::updateHistoryTitle):
2147         (HistoryDelegate::populateVisitedLinksForWebView):
2148         * DumpRenderTree/win/PolicyDelegate.cpp:
2149         (PolicyDelegate::decidePolicyForNavigationAction):
2150         (PolicyDelegate::unableToImplementPolicyWithError):
2151         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2152         (ResourceLoadDelegate::willSendRequest):
2153         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2154         (ResourceLoadDelegate::didReceiveResponse):
2155         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2156         (ResourceLoadDelegate::didFailLoadingWithError):
2157         * DumpRenderTree/win/TestRunnerWin.cpp:
2158         (TestRunner::addDisallowedURL):
2159         (TestRunner::originsWithApplicationCache):
2160         (TestRunner::setStorageDatabaseIdleInterval):
2161         (TestRunner::closeIdleLocalStorageDatabases):
2162         (TestRunner::copyDecodedHostName):
2163         (TestRunner::copyEncodedHostName):
2164         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2165         (TestRunner::isGeolocationProviderActive):
2166         (TestRunner::pathToLocalResource):
2167         (TestRunner::setMockDeviceOrientation):
2168         (TestRunner::setMockGeolocationPosition):
2169         (TestRunner::setMockGeolocationPositionUnavailableError):
2170         (TestRunner::setSpatialNavigationEnabled):
2171         (TestRunner::setAutomaticLinkDetectionEnabled):
2172         (TestRunner::isCommandEnabled):
2173         (TestRunner::authenticateSession):
2174         (TestRunner::addChromeInputField):
2175         (TestRunner::removeChromeInputField):
2176         (TestRunner::focusWebView):
2177         (TestRunner::grantWebNotificationPermission):
2178         (TestRunner::denyWebNotificationPermission):
2179         (TestRunner::removeAllWebNotificationPermissions):
2180         (TestRunner::simulateWebNotificationClick):
2181         (TestRunner::imageCountInGeneralPasteboard):
2182         * DumpRenderTree/win/UIDelegate.cpp:
2183         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2184         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2185         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2186         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2187         (UIDelegate::webViewAddMessageToConsole):
2188         (UIDelegate::exceededDatabaseQuota):
2189         (UIDelegate::setStatusText):
2190         (UIDelegate::didPressMissingPluginButton):
2191
2192 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2193
2194         Add a setting to create editable MiniBrowser windows by default
2195         https://bugs.webkit.org/show_bug.cgi?id=166806
2196
2197         Reviewed by Beth Dakin.
2198
2199         * MiniBrowser/mac/AppDelegate.m:
2200         (-[BrowserAppDelegate createBrowserWindowController:]):
2201         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2202         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2203         * MiniBrowser/mac/SettingsController.h:
2204         * MiniBrowser/mac/SettingsController.m:
2205         (-[SettingsController _populateMenu]):
2206         (-[SettingsController validateMenuItem:]):
2207         (-[SettingsController toggleCreateEditorByDefault:]):
2208         (-[SettingsController createEditorByDefault]):
2209         Add a setting and update the key equivalents accordingly.
2210         Also make sure to make the right kind of window on launch.
2211
2212 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2213
2214         Fix the 32-bit build.
2215
2216         * MiniBrowser/mac/BrowserWindowController.h:
2217         * MiniBrowser/mac/BrowserWindowController.m:
2218
2219 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2220
2221         Fix the 32-bit build.
2222
2223         * MiniBrowser/mac/BrowserWindowController.m:
2224
2225 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2226
2227         Make it possible to drop HTML files on the MiniBrowser icon
2228         https://bugs.webkit.org/show_bug.cgi?id=166802
2229
2230         Reviewed by Simon Fraser.
2231
2232         * MiniBrowser/mac/AppDelegate.m:
2233         (-[BrowserAppDelegate application:openFile:]):
2234         * MiniBrowser/mac/Info.plist:
2235         If you're using an editable window, the usual trick of dropping on the
2236         window doesn't work anymore (it makes an <attachment> instead).
2237
2238 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2239
2240         MiniBrowser window gets smaller each time it is instantiated
2241         https://bugs.webkit.org/show_bug.cgi?id=166807
2242
2243         Reviewed by Andy Estes.
2244
2245         * MiniBrowser/mac/BrowserWindowController.m:
2246         (-[BrowserWindowController windowDidLoad]):
2247         * MiniBrowser/mac/BrowserWindow.xib:
2248         Turn on full-window content view support with IB, instead of waiting
2249         until after the views have been loaded. This seems to resolve the
2250         longstanding ever-shrinking-window problem.
2251
2252 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2253
2254         Add indent/outdent items to MiniBrowser's new format menu
2255         https://bugs.webkit.org/show_bug.cgi?id=166805
2256
2257         Reviewed by Dan Bernstein.
2258
2259         * MiniBrowser/mac/MainMenu.xib:
2260
2261 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2262
2263         Add a stock Format menu to MiniBrowser
2264         https://bugs.webkit.org/show_bug.cgi?id=166804
2265
2266         Reviewed by Andy Estes.
2267
2268         * MiniBrowser/mac/MainMenu.xib:
2269         Many of the features automatically work with editable web views.
2270         However, this seems to expose a bug where none of the font-related features
2271         (Cmd-B, for example) work until the first time the font panel is shown,
2272         per process, which will need to be investigated separately.
2273
2274 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2275
2276         Remove unused applicationWillTerminate methods from MiniBrowser
2277         https://bugs.webkit.org/show_bug.cgi?id=166803
2278
2279         Reviewed by Andy Estes.
2280
2281         * MiniBrowser/mac/AppDelegate.m:
2282         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2283         * MiniBrowser/mac/BrowserWindowController.h:
2284         * MiniBrowser/mac/BrowserWindowController.m:
2285         (-[BrowserWindowController applicationTerminating]): Deleted.
2286         * MiniBrowser/mac/WK1BrowserWindowController.m:
2287         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2288         * MiniBrowser/mac/WK2BrowserWindowController.m:
2289         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2290
2291 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2292
2293         Add the ability to create empty contentEditable windows in MiniBrowser
2294         https://bugs.webkit.org/show_bug.cgi?id=166801
2295
2296         Reviewed by Wenson Hsieh.
2297
2298         * MiniBrowser/mac/AppDelegate.h:
2299         * MiniBrowser/mac/AppDelegate.m:
2300         (-[BrowserAppDelegate createBrowserWindowController:]):
2301         (-[BrowserAppDelegate newWindow:]):
2302         (-[BrowserAppDelegate newEditorWindow:]):
2303         (-[BrowserAppDelegate openDocument:]):
2304         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2305         * MiniBrowser/mac/BrowserWindowController.h:
2306         * MiniBrowser/mac/BrowserWindowController.m:
2307         (-[BrowserWindowController loadHTMLString:]):
2308         (-[BrowserWindowController toggleEditable:]):
2309         * MiniBrowser/mac/MainMenu.xib:
2310         * MiniBrowser/mac/WK1BrowserWindowController.m:
2311         (-[WK1BrowserWindowController awakeFromNib]):
2312         (-[WK1BrowserWindowController loadHTMLString:]):
2313         (-[WK1BrowserWindowController validateMenuItem:]):
2314         (-[WK1BrowserWindowController setEditable:]):
2315         (-[WK1BrowserWindowController updateTitle:]):
2316         * MiniBrowser/mac/WK2BrowserWindowController.m:
2317         (-[WK2BrowserWindowController awakeFromNib]):
2318         (-[WK2BrowserWindowController validateMenuItem:]):
2319         (-[WK2BrowserWindowController setEditable:]):
2320         (-[WK2BrowserWindowController updateTitle:]):
2321         (-[WK2BrowserWindowController loadHTMLString:]):
2322         Merge more functionality from WebEditingTester.
2323         Add two menu items for creating empty editable WebKit1/2 windows.
2324         Add a menu item to the Edit menu to toggle editability on any window.
2325
2326 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2327
2328         Implement find-in-page in MiniBrowser
2329         https://bugs.webkit.org/show_bug.cgi?id=166799
2330
2331         Reviewed by Andy Estes.
2332
2333         * MiniBrowser/mac/BrowserWindow.xib:
2334         * MiniBrowser/mac/BrowserWindowController.h:
2335         * MiniBrowser/mac/BrowserWindowController.m:
2336         (-[BrowserWindowController find:]): Deleted.
2337         * MiniBrowser/mac/MainMenu.xib:
2338         * MiniBrowser/mac/WK1BrowserWindowController.m:
2339         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2340         (-[WK1BrowserWindowController find:]): Deleted.
2341         * MiniBrowser/mac/WK2BrowserWindowController.m:
2342         (-[WK2BrowserWindowController awakeFromNib]):
2343         (-[WK2BrowserWindowController dealloc]):
2344         (-[WK2BrowserWindowController validateMenuItem:]):
2345         (-[WK2BrowserWindowController performTextFinderAction:]):
2346         (-[WK2BrowserWindowController findBarView]):
2347         (-[WK2BrowserWindowController setFindBarView:]):
2348         (-[WK2BrowserWindowController isFindBarVisible]):
2349         (-[WK2BrowserWindowController setFindBarVisible:]):
2350         (-[WK2BrowserWindowController contentView]):
2351         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2352         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2353         (-[WK2BrowserWindowController find:]): Deleted.
2354         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2355         protocol. At first glance, it's pretty broken, but vaguely works.
2356
2357 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2358
2359         Share the implementation of MiniBrowser view hiding functionality
2360         https://bugs.webkit.org/show_bug.cgi?id=166800
2361
2362         Reviewed by Andy Estes.
2363
2364         * MiniBrowser/mac/BrowserWindowController.m:
2365         (-[BrowserWindowController showHideWebView:]):
2366         (-[BrowserWindowController removeReinsertWebView:]):
2367         * MiniBrowser/mac/WK1BrowserWindowController.m:
2368         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2369         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2370         * MiniBrowser/mac/WK2BrowserWindowController.m:
2371         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2372         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2373         Move the implementation of these two things to the shared superclass,
2374         since they don't depend on WebKit-specific things.
2375         Also, there was no reason to retain the (WK)WebView while it was unparented,
2376         as the BrowserWindowController maintains a reference the entire time.
2377
2378 2017-01-06  Andy Estes  <aestes@apple.com>
2379
2380         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2381         https://bugs.webkit.org/show_bug.cgi?id=166789
2382
2383         Reviewed by Alex Christensen.
2384
2385         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2386         * DumpRenderTree/PlatformMac.cmake:
2387         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2388         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2389         * DumpRenderTree/mac/DumpRenderTree.mm:
2390         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2391         createXMLStringFromWebArchiveData().
2392         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2393         * WebKitTestRunner/Configurations/Base.xcconfig:
2394         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2395         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2396         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2397         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2398         createXMLStringFromWebArchiveData().
2399         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2400         * WebKitTestRunner/PlatformMac.cmake:
2401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2402         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2403
2404 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2405
2406         Minor cleanups to IndentOutdentCommand and related code
2407         https://bugs.webkit.org/show_bug.cgi?id=166791
2408
2409         Reviewed by Simon Fraser.
2410
2411         * WebEditingTester/EditingOperations.m:
2412         (editingOperations):
2413         Add the outdent operation to WebEditingTester.
2414
2415 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2416
2417         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2418         https://bugs.webkit.org/show_bug.cgi?id=166785
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2423         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2424
2425 2017-01-06  Antoine Quint  <graouts@apple.com>
2426
2427         Support webkit-test-runner key-value pairs in http tests
2428         https://bugs.webkit.org/show_bug.cgi?id=149812
2429
2430         Reviewed by Alex Christensen.
2431
2432         We pass the absolute path for a test through to WKTR so that we can parse
2433         tests that are running as URLs for webkit-test-runner options.
2434
2435         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2436         (parseInputLine):
2437
2438         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2439
2440         * Scripts/webkitpy/port/driver.py:
2441         (Driver._command_from_driver_input):
2442
2443         Pass the absolute path to the file through the CLI.
2444
2445         * WebKitTestRunner/TestController.cpp:
2446         (WTR::updateTestOptionsFromTestHeader):
2447         (WTR::TestController::testOptionsForTest):
2448         (WTR::parseInputLine):
2449         (WTR::TestController::runTest):
2450         * WebKitTestRunner/TestController.h:
2451
2452 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2453
2454         Warning about unconnectable outlets when opening a MiniBrowser window
2455         https://bugs.webkit.org/show_bug.cgi?id=166756
2456
2457         Reviewed by Dan Bernstein.
2458
2459         * MiniBrowser/mac/BrowserWindow.xib:
2460         When launching MiniBrowser, it says:
2461         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2462             (MBToolbarItem): missing setter or instance variable
2463         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2464             (NSButtonCell): missing setter or instance variable.
2465
2466         It looks like someone added the connection from the share button
2467         to the BrowserWindowController three times; only one of the connections
2468         is valid. Remove the other two.
2469
2470 2017-01-05  Keith Rollin  <krollin@apple.com>
2471
2472         Add WebCore::URL::protocolHostAndPort
2473         https://bugs.webkit.org/show_bug.cgi?id=166426
2474
2475         Reviewed by Alex Christensen.
2476
2477         Add test for protocolHostAndPort.
2478
2479         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2480         (TestWebKitAPI::TEST_F):
2481
2482 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2483
2484         [Win] Archive test result is failing.
2485         https://bugs.webkit.org/show_bug.cgi?id=166720
2486
2487         Reviewed by Alex Christensen.
2488
2489         Deleting the layout test result folder is sometimes failing
2490         on Windows. This is not a critical error.
2491
2492         * BuildSlaveSupport/test-result-archive:
2493         (archiveTestResults):
2494
2495 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2496
2497         [GTK] Minibrowser: Add printing support
2498         https://bugs.webkit.org/show_bug.cgi?id=165298
2499
2500         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2501         an error during the print, it's printed on the console.
2502
2503         Reviewed by Michael Catanzaro.
2504
2505         * MiniBrowser/gtk/BrowserWindow.c:
2506         (webKitPrintOperationFailedCallback):
2507         (printPage):
2508         (browser_window_init):
2509
2510 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2511
2512         [css-grid] Fix crash clamping grid lines
2513         https://bugs.webkit.org/show_bug.cgi?id=166637
2514
2515         Reviewed by Darin Adler.
2516
2517         Creates new unit test to verify that the maximum tracks limit
2518         is used in GridPosition too.
2519
2520         * TestWebKitAPI/PlatformEfl.cmake:
2521         * TestWebKitAPI/PlatformGTK.cmake:
2522         * TestWebKitAPI/PlatformWin.cmake:
2523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2524         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2525         (TestWebKitAPI::TEST):
2526
2527 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2528
2529         Move editing history scripts to WebCore PrivateHeaders
2530         https://bugs.webkit.org/show_bug.cgi?id=166709
2531         <rdar://problem/29876612>
2532
2533         Reviewed by Dan Bernstein.
2534
2535         Update references to editing script files in WebCore that were moved.
2536
2537         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2538
2539 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2540
2541         Unreviewed, build fix after r210313 part 2
2542         https://bugs.webkit.org/show_bug.cgi?id=166676
2543
2544         Add 'U' suffix.
2545
2546         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2547         (TestWebKitAPI::TEST):
2548         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2549         (TestWebKitAPI::TEST):
2550
2551 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2552
2553         Limit thread name appropriately
2554         https://bugs.webkit.org/show_bug.cgi?id=166676
2555
2556         Reviewed by Sam Weinig.
2557
2558         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2559         (TestWebKitAPI::TEST):
2560         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2561         (TestWebKitAPI::TEST):
2562
2563 2017-01-04  Andy Estes  <aestes@apple.com>
2564
2565         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2566         https://bugs.webkit.org/show_bug.cgi?id=166696
2567
2568         Reviewed by Tim Horton.
2569
2570         * TestWebKitAPI/PlatformGTK.cmake:
2571         * TestWebKitAPI/PlatformWin.cmake:
2572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2573         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2574         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2575         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2576         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2577         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2578         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2579
2580 2017-01-03  Brian Burg  <bburg@apple.com>
2581
2582         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2583         https://bugs.webkit.org/show_bug.cgi?id=166003
2584         <rdar://problem/28718990>
2585
2586         Reviewed by Joseph Pecoraro.
2587
2588         Teach run-inspector-generator-tests to generate test output using the platform name
2589         derived from the directory that the test is in. For example, tests in the /generic/
2590         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2591
2592         * Scripts/webkitpy/inspector/main.py:
2593         (InspectorGeneratorTests.generate_from_json):
2594         (InspectorGeneratorTests.run_tests):
2595         (InspectorGeneratorTests.main):
2596
2597 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2598
2599         Unreviewed cmake buildfix after r210266.
2600
2601         * DumpRenderTree/PlatformMac.cmake:
2602
2603 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2604
2605         Provide a setting for clients to always prefer low-power WebGL
2606         https://bugs.webkit.org/show_bug.cgi?id=166675
2607         <rdar://problem/29834093>
2608
2609         Reviewed by Dan Bernstein.
2610
2611         * MiniBrowser/mac/Info.plist:
2612         Have MiniBrowser claim to be a modern app that supports
2613         automatic graphics switching. WebKit needs to support automatic
2614         graphics switching, so our test app might as well. Without this
2615         Info.plist parameter, this change has no effect, and bringing up
2616         a WebGL context still brings up the discrete GPU (also true of the
2617         existing web-exposed preferLowPowerToHighPerformance API).
2618
2619 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2620
2621         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2622         https://bugs.webkit.org/show_bug.cgi?id=166645
2623
2624         Reviewed by Carlos Garcia Campos.
2625
2626         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2627         (TestWebKitAPI::TEST):
2628
2629 2017-01-03  Andy Estes  <aestes@apple.com>
2630
2631         Place all the Cocoa WebCore API tests in the same directory
2632         https://bugs.webkit.org/show_bug.cgi?id=166673
2633
2634         Reviewed by Michael Catanzaro.
2635
2636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2637         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2638         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2639         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2640
2641 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2642
2643         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2644         https://bugs.webkit.org/show_bug.cgi?id=166450
2645         <rdar://problem/29447824>
2646
2647         Reviewed by Darin Adler.
2648
2649         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2650         * DumpRenderTree/TestRunner.cpp:
2651         (TestRunner::staticFunctions):
2652         * DumpRenderTree/mac/TestRunnerMac.mm:
2653         (setSpellCheckerLoggingEnabledCallback):
2654         * DumpRenderTree/win/TestRunnerWin.cpp:
2655         (setSpellCheckerLoggingEnabledCallback):
2656         * DumpRenderTree/mac/DumpRenderTree.mm:
2657         (resetWebViewToConsistentStateBeforeTesting):
2658         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2659         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2660         (stringForCorrectionResponse):
2661         (drt_NSSpellChecker_recordResponseToCorrection):
2662         (swizzleNSSpellCheckerMethodsIfNeeded):
2663         (setSpellCheckerLoggingEnabled):
2664         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2665         set to true, logs to stdout (which ends up in the test result) whenever
2666         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2667         is called, and then calls the original method. It is reset to false between tests.
2668
2669 2017-01-03  Sam Weinig  <sam@webkit.org>
2670
2671         Make WTF::Expected support Ref template parameters
2672         https://bugs.webkit.org/show_bug.cgi?id=166662
2673
2674         Reviewed by Alex Christensen.
2675
2676         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2677         (TestWebKitAPI::TEST):
2678         Add tests for using Ref with Expected.
2679
2680 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2681
2682         [GTK] Expose WebKitSecurityOrigin API
2683         https://bugs.webkit.org/show_bug.cgi?id=166632
2684
2685         Reviewed by Carlos Garcia Campos.
2686
2687         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2688         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2689         (testSecurityOriginBasicConstructor):
2690         (testSecurityOriginURIConstructor):
2691         (testSecurityOriginDefaultPort):
2692         (testSecurityOriginFileURI):
2693         (testSecurityOriginDataURI):
2694         (beforeAll):
2695         (afterAll):
2696
2697 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2698
2699         [GTK] HTTP auth layout tests are flaky
2700         https://bugs.webkit.org/show_bug.cgi?id=158919
2701
2702         Reviewed by Michael Catanzaro.
2703
2704         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2705         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2706         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2707         missing valac in the bots.
2708
2709 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2710
2711         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2712         https://bugs.webkit.org/show_bug.cgi?id=165797
2713
2714         Reviewed by Michael Catanzaro.
2715
2716         Move directory ruleset after all exclude rules of Source rulset.
2717
2718         * gtk/manifest.txt.in:
2719
2720 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2721
2722         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2723         https://bugs.webkit.org/show_bug.cgi?id=166636
2724
2725         Reviewed by Darin Adler.
2726
2727         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2728         (TestWebKitAPI::TEST):
2729
2730 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2731
2732         [GTK] WebCore/CSSParser unit test is not being built
2733         https://bugs.webkit.org/show_bug.cgi?id=166492
2734
2735         Reviewed by Michael Catanzaro.
2736
2737         This test was introduced in r175930, but we were not building
2738         it on GTK+ port since r176015.
2739         This patch marks the test to be built again on GTK+.
2740         JFTR, the test is passing right now.
2741
2742         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2743         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2744
2745 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2746
2747         AX: Expose block quote level to iOS API
2748         https://bugs.webkit.org/show_bug.cgi?id=166629
2749         <rdar://problem/29834793>
2750
2751         Reviewed by Darin Adler.
2752
2753         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2754         (AccessibilityUIElement::numberAttributeValue):
2755         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2756         (WTR::AccessibilityUIElement::numberAttributeValue):
2757
2758 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2759
2760         SecurityOrigin::create triplet constructor does not canonicalize port
2761         https://bugs.webkit.org/show_bug.cgi?id=166624
2762
2763         Reviewed by Daniel Bates.
2764
2765         * TestWebKitAPI/PlatformGTK.cmake:
2766         * TestWebKitAPI/PlatformWin.cmake:
2767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2768         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2769         (TestWebKitAPI::SecurityOriginTest::SetUp):
2770         (TestWebKitAPI::TEST_F):
2771
2772 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2773
2774         [GTK] Improve user agent construction
2775         https://bugs.webkit.org/show_bug.cgi?id=142074
2776
2777         Reviewed by Carlos Garcia Campos.
2778
2779         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2780         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2781         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2782         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2783         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2784         (TestWebKitAPI::TEST):
2785
2786 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2787
2788         [GTK] Improve user agent construction
2789         https://bugs.webkit.org/show_bug.cgi?id=142074
2790
2791         Reviewed by Carlos Garcia Campos.
2792
2793         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2794         (TestWebKitAPI::TEST):
2795
2796 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2797
2798         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2799         https://bugs.webkit.org/show_bug.cgi?id=166472
2800         rdar://problem/29675551
2801
2802         Reviewed by Tim Horton.
2803
2804         These changes are necessary to allow the mouse to leave the WTR window while
2805         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2806         (which DRT does); we'd always go through mouseMoved, which hits an early return
2807         in WebViewImpl::mouseMoved() when the point is outside the view.
2808
2809         * WebKitTestRunner/mac/EventSenderProxy.mm:
2810         (WTR::EventSenderProxy::mouseMoveTo):
2811
2812 2016-12-23  Andy Estes  <aestes@apple.com>
2813
2814         [iOS] Fix some crashing webarchive tests
2815         https://bugs.webkit.org/show_bug.cgi?id=166470
2816
2817         Reviewed by Andreas Kling.
2818
2819         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2820         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2821         so this change uses that on both platforms.
2822
2823         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2824         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2825         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2826         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2827         * WebKitTestRunner/PlatformMac.cmake:
2828         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2829         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2830
2831 2016-12-22  Saam Barati  <sbarati@apple.com>
2832
2833         WebAssembly: Silence the output of the spec-tests
2834         https://bugs.webkit.org/show_bug.cgi?id=166417
2835
2836         Reviewed by Mark Lam.
2837
2838         * Scripts/run-jsc-stress-tests:
2839
2840 2016-12-22  Zhuo Li  <zachli@apple.com>
2841
2842         [Cocoa] SPI for setloadsImagesAutomatically.
2843         https://bugs.webkit.org/show_bug.cgi?id=166401.
2844
2845         Reviewed by Darin Adler.
2846
2847         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2848         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2849         _loadsImagesAutomatically returns YES.
2850
2851 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2852
2853         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2854         https://bugs.webkit.org/show_bug.cgi?id=161328
2855         <rdar://problem/28475977>
2856
2857         Reviewed by Darin Adler.
2858
2859         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2860         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2861         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2862         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2863         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2864         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2865         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2866         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2867         we finish running a test and before we load the next test.
2868
2869         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2870         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2871         previous test started zooming and then finished before zooming completed. Since this happens before the next
2872         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2873
2874         * WebKitTestRunner/ios/TestControllerIOS.mm:
2875         (WTR::TestController::platformResetStateToConsistentValues):
2876
2877 2016-12-22  Jer Noble  <jer.noble@apple.com>
2878
2879         Muted media element playback should not interrupt other audio playback
2880         https://bugs.webkit.org/show_bug.cgi?id=166347
2881
2882         Reviewed by Eric Carlson.
2883
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2885         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2886         (TestWebKitAPI::TEST):
2887         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2888
2889 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2890
2891         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2892         https://bugs.webkit.org/show_bug.cgi?id=166346
2893
2894         Reviewed by Carlos Garcia Campos.
2895
2896         Enable WebRTC by default to simplify testing.
2897
2898         * MiniBrowser/gtk/main.c:
2899         (main):
2900
2901 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2902
2903         REGRESSION: API test failure: WKWebView.LocalStorageClear
2904         https://bugs.webkit.org/show_bug.cgi?id=166032
2905         <rdar://problem/29758423>
2906
2907         Reviewed by Simon Fraser.
2908
2909         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2910         to ensure that the view is destroyed before the callback fires.
2911
2912         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2913         (TEST):
2914
2915 2016-12-21  Saam Barati  <sbarati@apple.com>
2916
2917         WebAssembly: Import spec tests
2918         https://bugs.webkit.org/show_bug.cgi?id=166395
2919
2920         Rubber stamped by Keith Miller.
2921
2922         * Scripts/run-jsc-stress-tests:
2923
2924 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2925
2926         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2927         https://bugs.webkit.org/show_bug.cgi?id=166033
2928         <rdar://problem/29758428>
2929
2930         Reviewed by Simon Fraser.
2931
2932         Add an @autoreleasepool around the code that allocates the WKWebView, 
2933         so that it can be destroyed by removing the last reference in _downloadDidStart.
2934
2935         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2936         (TEST):
2937
2938 2016-12-21  Daniel Bates  <dabates@apple.com>
2939
2940         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2941         https://bugs.webkit.org/show_bug.cgi?id=166356
2942
2943         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2944         as a means to allow a test to explicit allow an embedding client to open a new windows
2945         such that the default behavior is for the embedding client to forbid such an action.
2946         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2947         it is currently skipped on WebKit2 because questions were raised in the patch for
2948         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2949         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2950         this test.
2951
2952         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2953         (WTR::TestRunner::setCanOpenWindows):
2954
2955 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2956
2957         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2958         https://bugs.webkit.org/show_bug.cgi?id=166031
2959
2960         Reviewed by Tim Horton.
2961         
2962         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2963         to ensure that the view is destroyed before the callback fires.
2964
2965         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2966
2967 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2968
2969         Throw Exception when test doesn't clean up HID Events properly
2970         https://bugs.webkit.org/show_bug.cgi?id=166271
2971
2972         Reviewed by Simon Fraser.
2973
2974         Add in a check when UIScriptController is deleted to make sure that the HID event
2975         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2976         the program to crash without any good information. Crashes are race-y, and will still
2977         happen with malformed test, but the information will be much more helpful. 
2978
2979         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2980         (WTR::UIScriptController::checkForClean):
2981         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2982         (UIScriptContext::~UIScriptContext):
2983         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2984         (WTR::UIScriptController::checkForClean):
2985         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2986         * WebKitTestRunner/ios/HIDEventGenerator.h:
2987         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2988         (-[HIDEventGenerator checkHIDCallbacksClear]):
2989         * WebKitTestRunner/ios/TestControllerIOS.mm:
2990         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2991         (WTR::UIScriptController::checkForClean):
2992
2993 2016-12-20  Andy Estes  <aestes@apple.com>
2994
2995         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2996         https://bugs.webkit.org/show_bug.cgi?id=165992
2997
2998         Reviewed by Brady Eidson.
2999
3000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3001         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3002         (expectException):
3003         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3004         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3005         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3006         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3007         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3008         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3009         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3010         (TEST):
3011         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3012
3013 2016-12-20  Dean Jackson  <dino@apple.com>
3014
3015         Remove INDIE_UI
3016         https://bugs.webkit.org/show_bug.cgi?id=165881
3017         <rdar://problem/29672532>
3018
3019         Reviewed by Simon Fraser.
3020
3021         The Indie UI work has been discontinued.
3022
3023         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3024
3025 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3026
3027         [ES6] Enable ES6 Modules
3028         https://bugs.webkit.org/show_bug.cgi?id=165849
3029
3030         Reviewed by Geoffrey Garen.
3031
3032         * DumpRenderTree/mac/DumpRenderTree.mm:
3033         (resetWebPreferencesToConsistentValues):
3034         * DumpRenderTree/win/DumpRenderTree.cpp:
3035         (resetWebPreferencesToConsistentValues):
3036         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3037         (WTR::InjectedBundle::beginTesting):
3038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3039         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3040         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3041
3042 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3043
3044         Repurpose bots and clean up dashboard.
3045         https://bugs.webkit.org/show_bug.cgi?id=166045
3046
3047         Reviewed by Lucas Forschler.
3048
3049         * BuildSlaveSupport/build.webkit.org-config/config.json:
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3051         (BubbleQueueServer):
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3054         (WebKitBuildbot):
3055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3056         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3057
3058 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3059
3060         [CMake] TestWebKitAPIBase links to itself
3061         https://bugs.webkit.org/show_bug.cgi?id=165985
3062
3063         Reviewed by Alex Christensen.
3064
3065         Fix CMake warning about a target linking to itself, which makes no sense.
3066
3067         * TestWebKitAPI/CMakeLists.txt:
3068
3069 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3070
3071         [GTK] GtkDoc build should be quieter
3072         https://bugs.webkit.org/show_bug.cgi?id=165994
3073
3074         Reviewed by Carlos Garcia Campos.
3075
3076         Make it not print by default.
3077
3078         * gtk/generate-gtkdoc:
3079         (get_generator_for_config):
3080         (generate_doc):
3081         * gtk/gtkdoc.py:
3082         (GTKDoc._run_command):
3083         (GTKDoc._copy_doc_files_to_output_dir):
3084
3085 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3086
3087         Expose a way for MiniBrowser to simulate header and footer banners
3088         https://bugs.webkit.org/show_bug.cgi?id=166005
3089
3090         Reviewed by Wenson Hsieh.
3091         
3092         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3093         banners. This only works in WebKit2.
3094         
3095         We need to reset these on each navigation, since newly created FrameViews
3096         don't re-fetch the header and footer height stored on Page.
3097         
3098         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3099         as well as fixing webViewWebContentProcessDidTerminate:
3100
3101         * MiniBrowser/mac/SettingsController.h:
3102         * MiniBrowser/mac/SettingsController.m:
3103         (-[SettingsController _populateMenu]):
3104         (-[SettingsController validateMenuItem:]):
3105         (-[SettingsController toggleReserveSpaceForBanners:]):
3106         (-[SettingsController isSpaceReservedForBanners]):
3107         * MiniBrowser/mac/WK2BrowserWindowController.m:
3108         (-[WK2BrowserWindowController didChangeSettings]):
3109         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3110         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3111         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3112         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3113
3114 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3115
3116         Fix iOS test results after r209967.
3117         
3118         Subtracting out the status bar height was erroneously happening for all tests,
3119         not just for flexible viewport tests.
3120         
3121         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3122
3123         * WebKitTestRunner/PlatformWebView.h:
3124         * WebKitTestRunner/TestController.cpp:
3125         (WTR::TestController::resetStateToConsistentValues):
3126         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3127         (WTR::PlatformWebView::resizeTo):
3128         (WTR::PlatformWebView::setWindowFrame):
3129         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3130         (WTR::PlatformWebView::resizeTo):
3131         (WTR::PlatformWebView::setWindowFrame):
3132         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3133         (WTR::PlatformWebView::resizeTo):
3134         (WTR::PlatformWebView::setWindowFrame):
3135         * WebKitTestRunner/ios/TestControllerIOS.mm:
3136         (WTR::TestController::platformConfigureViewForTest):
3137         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3138         (WTR::PlatformWebView::resizeTo):
3139         (WTR::PlatformWebView::setWindowFrame):
3140
3141 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3142
3143         [EFL] bump EFL version to 1.18.4
3144         https://bugs.webkit.org/show_bug.cgi?id=166004
3145
3146         Reviewed by Gyuyoung Kim.
3147
3148         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3149
3150 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         Visual viewports: bottom fixed elements disappear behind the keyboard
3153         https://bugs.webkit.org/show_bug.cgi?id=165983
3154         <rdar://problem/29409852>
3155
3156         Reviewed by Simon Fraser.
3157
3158         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3159         the keyboard when it is up.
3160
3161         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3162         (WTR::UIScriptController::inputViewBounds):
3163         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3164         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3165         (WTR::UIScriptController::inputViewBounds):
3166         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3167         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3168         (WTR::viewRectForWindowRect):
3169
3170         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3171         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3172         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3173
3174         (WTR::PlatformWebView::PlatformWebView):
3175         (WTR::PlatformWebView::setWindowFrame):
3176         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3177         (WTR::UIScriptController::inputViewBounds):
3178
3179 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3180
3181         Deleting a character converted from pinyin after an image causes a Safari crash
3182         https://bugs.webkit.org/show_bug.cgi?id=165839
3183         <rdar://problem/27951933>
3184
3185         Reviewed by Wenson Hsieh.
3186
3187         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3188         while the proposed range contains an image. This should not cause a WebProcess to crash
3189         or send an invalid message to the UIProcess.
3190
3191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3192         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3193         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3194         (TestWebKitAPI::didFinishLoadForFrame):
3195         (TestWebKitAPI::processDidCrash):
3196         (TestWebKitAPI::invalidMessageFunction):
3197         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3198
3199 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3200
3201         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3202         https://bugs.webkit.org/show_bug.cgi?id=165767
3203         <rdar://problem/29602382>
3204
3205         Reviewed by Simon Fraser.
3206
3207         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3208         WebKit2 ChangeLog for more details.
3209
3210         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3211         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3212         (WTR::UIScriptController::textSelectionCaretRect):
3213         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3214         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3215         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3216         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3217         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3218         (WTR::UIScriptController::textSelectionCaretRect):
3219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3220         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3221         (-[TestRunnerWKWebView _setStableStateOverride:]):
3222
3223         Force the WKWebView to update its visible content rects when changing the stable state override.
3224
3225         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3226         (WTR::toNSDictionary):
3227         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3228         (WTR::UIScriptController::selectionRangeViewRects):
3229         (WTR::UIScriptController::textSelectionCaretRect):
3230         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3231         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3232
3233 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3234
3235         Arguments called in wrong order
3236         https://bugs.webkit.org/show_bug.cgi?id=165923
3237
3238         Reviewed by Simon Fraser.
3239
3240         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3241         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3242
3243         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3244         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3245         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3246
3247 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3248
3249         [EFL] Disable non-srcdir builds for failing libraries
3250         https://bugs.webkit.org/show_bug.cgi?id=165896
3251
3252         Reviewed by Gyuyoung Kim.
3253
3254         * efl/jhbuild.modules: Set non srcdir builds to no
3255
3256 2016-12-15  Daniel Bates  <dabates@apple.com>
3257
3258         check-style should not complain about code in icu directories
3259         https://bugs.webkit.org/show_bug.cgi?id=53929
3260
3261         Reviewed by Darin Adler.
3262
3263         Skip style checking of imported ICU headers to avoid a deluge of style issues
3264         as they do not conform to the WebKit Code Style guideline. We want to preserve
3265         the formatting of these headers so as to make it straightforward to merge
3266         changes to them, if necessary.
3267
3268         * Scripts/webkitpy/style/checker.py:
3269
3270 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3271
3272         Move JSC testers from Yosemite to Sierra
3273         https://bugs.webkit.org/show_bug.cgi?id=165925
3274
3275         Reviewed by Lucas Forschler.
3276
3277         * BuildSlaveSupport/build.webkit.org-config/config.json:
3278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3279         (WebKitBuildbot):
3280
3281 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3282
3283         Add coordinate space to event streams and streamline tests
3284         https://bugs.webkit.org/show_bug.cgi?id=165119
3285
3286         Reviewed by Simon Fraser.
3287
3288         Update event streams to allow for both content and global coordinate space.
3289         Update example script to more accurately show all the available options.
3290
3291         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3292         * WebKitTestRunner/ios/HIDEventGenerator.h:
3293         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3294         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3295         (WTR::convertCoordinates):
3296         (WTR::UIScriptController::sendEventStream):
3297
3298 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3299
3300         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3301         https://bugs.webkit.org/show_bug.cgi?id=165855
3302
3303         Reviewed by Philippe Normand.
3304
3305         GStreamer's autogen.sh enables gtk-doc always so we end up building
3306         docs even if we disable them. Use the configure script instead, since
3307         we build from packages and these include it already.
3308
3309         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3310         upstream gstreamer packages.
3311
3312 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3313
3314         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3315         https://bugs.webkit.org/show_bug.cgi?id=165885
3316         <rdar://problem/29476917>
3317
3318         Reviewed by Darin Adler.
3319
3320         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3321         (TestWebKitAPI::utf16String): Deleted.
3322         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3323         (TestWebKitAPI::TEST_F):
3324         * TestWebKitAPI/WTFStringUtilities.h:
3325         (utf16String):
3326         Moved from URLParser to share with other tests.
3327
3328 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3329
3330         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3331         https://bugs.webkit.org/show_bug.cgi?id=165843
3332
3333         Reviewed by Antti Koivisto.
3334
3335         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3336         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3337         and DumpRenderTree's runUIScript would hit an assertion :(
3338
3339         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3340         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3341         (WTR::TestRunner::isWebKit2):
3342
3343 2016-12-14  Brady Eidson  <beidson@apple.com>
3344
3345         IndexedDB 2.0: Massively speedup IDBIndex.get().
3346         https://bugs.webkit.org/show_bug.cgi?id=165802
3347
3348         Reviewed by Alex Christensen.
3349
3350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3351         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3352         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3353         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3354         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3355
3356 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3357
3358         [GTK][EFL] Update the JHBuild version.
3359         https://bugs.webkit.org/show_bug.cgi?id=165838
3360
3361         Reviewed by Michael Catanzaro.
3362
3363         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3364         usage of the JHBUILD_MIRROR feature with git repositories.
3365
3366 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3367
3368         [GTK] Yasm is needed for building the JHBuild after r208940
3369         https://bugs.webkit.org/show_bug.cgi?id=165837
3370
3371         Reviewed by Alejandro G. Castro.
3372
3373         * gtk/install-dependencies: Yasm is needed for building libvpx.
3374
3375 2016-12-14  Youenn Fablet  <youenn@apple.com>
3376
3377         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3378         https://bugs.webkit.org/show_bug.cgi?id=161310
3379
3380         Reviewed by Ryosuke Niwa.
3381
3382         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3383         When set, WTR and DRT output JS console log in the stderr and not the test output.
3384         This allows removing potentially flaky information while still being able to read it for investigation.
3385
3386         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3387
3388         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3389         This test should have this option when fetch API will start logging resource loader errors.
3390
3391         * DumpRenderTree/DumpRenderTree.h:
3392         (TestCommand::TestCommand): Deleted.
3393         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3394         (parseInputLine):
3395         * DumpRenderTree/TestRunner.h:
3396         (TestRunner::setDumpJSConsoleLogInStdErr):
3397         (TestRunner::dumpJSConsoleLogInStdErr):
3398         * DumpRenderTree/mac/DumpRenderTree.mm:
3399         (runTest):
3400         * DumpRenderTree/mac/UIDelegate.mm:
3401         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3402         * DumpRenderTree/win/DumpRenderTree.cpp:
3403         (runTest):
3404         * DumpRenderTree/win/UIDelegate.cpp:
3405         (UIDelegate::webViewAddMessageToConsole):
3406         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3407         (TestExpectationParser._tokenize_line):
3408         * Scripts/webkitpy/port/driver.py:
3409         (Driver._command_from_driver_input):
3410         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3411         (WTR::InjectedBundle::didReceiveMessageToPage):
3412         (WTR::InjectedBundle::dumpToStdErr):
3413         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3414         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3416         (WTR::InjectedBundlePage::willAddMessageToConsole):
3417         * WebKitTestRunner/TestController.cpp:
3418         (WTR::parseInputLine):
3419         (WTR::TestController::runTest):
3420         (WTR::TestCommand::TestCommand): Deleted.
3421         * WebKitTestRunner/TestInvocation.cpp:
3422         (WTR::TestInvocation::invoke):
3423         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3424         * WebKitTestRunner/TestInvocation.h:
3425         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3426
3427
3428 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3429
3430         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3431         https://bugs.webkit.org/show_bug.cgi?id=164022
3432
3433         Reviewed by Xabier Rodriguez-Calvar.
3434
3435         * Scripts/webkitperl/FeatureList.pm:
3436           Re-enable MEDIA_SOURCE for the GTK+ port.
3437
3438 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3439
3440         Fix CMake build.
3441
3442         * DumpRenderTree/PlatformMac.cmake:
3443         Define NS_RETURNS_RETAINED as nothing for now.
3444
3445 2016-12-13  Jer Noble  <jer.noble@apple.com>
3446
3447         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3448         https://bugs.webkit.org/show_bug.cgi?id=165697
3449
3450         Reviewed by Tim Horton.
3451
3452         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3453         (TestWebKitAPI::TEST):
3454
3455 2016-12-13  Andy Estes  <aestes@apple.com>
3456
3457         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3458         https://bugs.webkit.org/show_bug.cgi?id=165785
3459         <rdar://problem/26929398>
3460
3461         Reviewed by Darin Adler.
3462
3463         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3464         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3465         expectations for the text, range, and action.
3466         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3467         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3468         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3469         text in the web view did not change.
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3471         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3472         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3473         parameter.
3474         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3475         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3476         and returned the value of _editingDelegateShouldInsertText.
3477         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3478         -shouldInsertText:replacingRange:givenAction:.
3479
3480 2016-12-13  Chris Dumez  <cdumez@apple.com>
3481
3482         Unreviewed, rolling out r209544.
3483
3484         Looks like r209489 did not cause the performance regression
3485         after all
3486
3487         Reverted changeset:
3488
3489         "Unreviewed, rolling out r209489."
3490         https://bugs.webkit.org/show_bug.cgi?id=165550
3491         http://trac.webkit.org/changeset/209544
3492
3493 2016-12-12  Sam Weinig  <sam@webkit.org>
3494
3495         [WebIDL] Remove use of Dictionary in ApplePaySession
3496         https://bugs.webkit.org/show_bug.cgi?id=165787
3497
3498         Reviewed by Anders Carlsson.
3499
3500         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3501         (WTR::initializeWebViewConfiguration):
3502         (WTR::TestController::platformCreateWebView):
3503         Enable ApplePay for the tests (where supported).
3504
3505 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3506
3507         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3508         https://bugs.webkit.org/show_bug.cgi?id=165251
3509
3510         Reviewed by Youenn Fablet.
3511
3512         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3513         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3514         the preferences have been set.
3515
3516 2016-12-08  Antti Koivisto  <antti@apple.com>
3517
3518         Enable network cache speculative revalidation in MiniBrowser
3519         https://bugs.webkit.org/show_bug.cgi?id=165616
3520
3521         Reviewed by Darin Adler.
3522
3523         Match Safari. Also add a menu item to disable it.
3524
3525         * MiniBrowser/mac/AppDelegate.m:
3526         (defaultConfiguration):
3527         * MiniBrowser/mac/SettingsController.h:
3528         * MiniBrowser/mac/SettingsController.m:
3529         (-[SettingsController _populateMenu]):
3530         (-[SettingsController validateMenuItem:]):
3531         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3532         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3533
3534 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3535
3536         ChangeLogs become readonly after resolving a conflict
3537         https://bugs.webkit.org/show_bug.cgi?id=165440
3538         rdar://problem/29491002
3539
3540         Reviewed by Darin Adler.
3541
3542         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3543         moving the file.
3544
3545 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3546
3547         Re-enable collectContinuously since it doesn't crash anymore
3548
3549         Rubber stamped by Michael Saboff.
3550
3551         * Scripts/run-jsc-stress-tests:
3552
3553 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3554
3555         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3556         https://bugs.webkit.org/show_bug.cgi?id=165686
3557
3558         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3559         so that right config.h comes first in include path.
3560
3561 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3562
3563         [CSS Parser] Make sure content extensions initialize AtomicString
3564         https://bugs.webkit.org/show_bug.cgi?id=165737
3565
3566         Reviewed by Darin Adler.
3567
3568         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3569         (TestWebKitAPI::makeBackend):
3570
3571 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3572
3573         [CSS Parser] Remove the old CSS Parser
3574         https://bugs.webkit.org/show_bug.cgi?id=165645
3575
3576         Reviewed by Daniel Bates.
3577
3578         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3579         (TestWebKitAPI::TEST):
3580
3581 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3582
3583         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3584         https://bugs.webkit.org/show_bug.cgi?id=165686
3585
3586         Reviewed by Michael Catanzaro.
3587
3588         This change reduces duplication of include path lists between modules,
3589         and reduces future need for fixes like r209605 (broken build because of
3590         WebCore header suddenly becoming used in WebKit2).
3591
3592         * DumpRenderTree/CMakeLists.txt:
3593         * DumpRenderTree/PlatformMac.cmake:
3594         * ImageDiff/CMakeLists.txt:
3595         * MiniBrowser/gtk/CMakeLists.txt:
3596         * MiniBrowser/mac/CMakeLists.txt:
3597         * MiniBrowser/win/CMakeLists.txt:
3598         * TestWebKitAPI/CMakeLists.txt:
3599         * TestWebKitAPI/PlatformEfl.cmake:
3600         * TestWebKitAPI/PlatformJSCOnly.cmake:
3601         * TestWebKitAPI/PlatformMac.cmake:
3602         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3603         * WebKitTestRunner/CMakeLists.txt:
3604         * WebKitTestRunner/PlatformGTK.cmake:
3605         * WebKitTestRunner/PlatformMac.cmake:
3606
3607 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3608
3609         Unreviewed buildfix after r209630.
3610
3611         * Scripts/build-jsc: Remove building the non-existing testWASM.
3612
3613 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3614
3615         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3616         https://bugs.webkit.org/show_bug.cgi?id=165251
3617
3618         Reviewed by Dean Jackson.
3619
3620         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3621
3622         * DumpRenderTree/mac/DumpRenderTree.mm:
3623         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3624
3625         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3626         (WTR::InjectedBundle::beginTesting): Ditto.
3627
3628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3629         (WTR::TestRunner::setMediaStreamEnabled): New.
3630         (WTR::TestRunner::setPeerConnectionEnabled): New.
3631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3632
3633 2016-12-09  Brady Eidson  <beidson@apple.com> 
3634  
3635         Re-landing:
3636         Add _WKIconLoadingDelegate SPI. 
3637         https://bugs.webkit.org/show_bug.cgi?id=164894 
3638  
3639         Reviewed by Alex Christensen. 
3640         
3641         Add MiniBrowser support for this new SPI, configurable with a setting. 
3642  
3643         * MiniBrowser/mac/SettingsController.h: 
3644         * MiniBrowser/mac/SettingsController.m: 
3645         (-[SettingsController _populateMenu]): 
3646         (-[SettingsController validateMenuItem:]): 
3647         (-[SettingsController loadsAllSiteIcons]): 
3648         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3649         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3650         (-[WK2BrowserWindowController awakeFromNib]): 
3651         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3652
3653 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3654
3655         Fix the 32-bit build.
3656
3657         Unreviewed build fix.
3658
3659         * MiniBrowser/mac/SettingsController.h:
3660
3661 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3662
3663         Fedora also needs a PHP7 config file alternative
3664         https://bugs.webkit.org/show_bug.cgi?id=165606
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         * Scripts/webkitpy/port/base.py:
3669         (Port._is_fedora_php_version_7): check for the php7 library.
3670         (Port._fedora_php_version): get the appropriate filename for Fedora.
3671         (Port._apache_config_file_name_for_platform):
3672
3673 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3674
3675         Complete the revert of r208865.
3676         https://bugs.webkit.org/show_bug.cgi?id=164894
3677
3678         Unreviewed build fix.
3679
3680         * MiniBrowser/mac/SettingsController.h:
3681         * MiniBrowser/mac/SettingsController.m:
3682         (-[SettingsController _populateMenu]):
3683         (-[SettingsController validateMenuItem:]):
3684         (-[SettingsController loadsAllSiteIcons]): Deleted.
3685         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3686         * MiniBrowser/mac/WK2BrowserWindowController.m:
3687         (-[WK2BrowserWindowController awakeFromNib]):
3688         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3689
3690 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3691
3692         [GTK] Force GDK backend to x11 when running with XvfbDriver
3693         https://bugs.webkit.org/show_bug.cgi?id=165612
3694
3695         Reviewed by Michael Catanzaro.
3696
3697         When the developer is running a Wayland session, GDK may get confused
3698         and try to use its Wayland backend (which is higher priority) instead.
3699         This ensures it will use the appropriate backend when running under
3700         Xvfb.
3701
3702         * Scripts/webkitpy/port/gtk.py:
3703         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3704         force GDK_BACKEND to x11.
3705
3706 2016-12-08  Keith Miller  <keith_miller@apple.com>
3707
3708         Add 64-bit signed LEB decode method
3709         https://bugs.webkit.org/show_bug.cgi?id=165630
3710
3711         Reviewed by Ryosuke Niwa.
3712
3713         Add tests for LEB int64 and uint64 decode since I guess
3714         I forgot to add tests before.
3715
3716         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3717         (TestWebKitAPI::testUInt32LEBDecode):
3718         (TestWebKitAPI::TEST):
3719         (TestWebKitAPI::testUInt64LEBDecode):
3720         (TestWebKitAPI::testInt32LEBDecode):
3721         (TestWebKitAPI::testInt64LEBDecode):
3722         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3723
3724 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3725
3726         Make it easy to enable --force-collectContinuously
3727         https://bugs.webkit.org/show_bug.cgi?id=165638
3728
3729         Reviewed by Keith Miller.
3730
3731         * Scripts/run-javascriptcore-tests:
3732         (runJSCStressTests):
3733
3734 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3735
3736         Disable the collectContinuously mode until I investigate failures.
3737
3738         Rubber stamped by Keith Miller.
3739         
3740         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3741         while I investigate.
3742
3743         * Scripts/run-jsc-stress-tests:
3744
3745 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3746
3747         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3748         https://bugs.webkit.org/show_bug.cgi?id=165621
3749
3750         Reviewed by Dan Bernstein.
3751
3752         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3753         (TestWebKitAPI::TEST_F):
3754
3755 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3756
3757         Concurrent GC should be stable enough to land enabled
3758         https://bugs.webkit.org/show_bug.cgi?id=164990
3759
3760         Reviewed by Geoffrey Garen.
3761         
3762         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3763         
3764         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3765         safe for debug. It might be too slow for debug.
3766
3767         * Scripts/run-jsc-stress-tests:
3768
3769 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3770
3771         Add SPI for sending WebsiteSettings to WebProcess during navigation
3772         https://bugs.webkit.org/show_bug.cgi?id=165517
3773         <rdar://29341068>
3774
3775         Reviewed by Anders Carlsson.
3776
3777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3778         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3779         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3780         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3781         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3782         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3783         (TEST):
3784
3785 2016-12-08  Chris Dumez  <cdumez@apple.com>
3786
3787         Unreviewed, rolling out r209489.
3788
3789         Likely caused large regressions on JetStream, Sunspider and
3790         Speedometer
3791
3792         Reverted changeset:
3793
3794         "Add system trace points for JavaScript VM entry/exit"
3795         https://bugs.webkit.org/show_bug.cgi?id=165550
3796         http://trac.webkit.org/changeset/209489
3797
3798 2016-12-08  Keith Miller  <keith_miller@apple.com>
3799
3800         Move LEB tests to API tests
3801         https://bugs.webkit.org/show_bug.cgi?id=165586
3802
3803         Reviewed by Saam Barati.
3804
3805         Move the tests from testWasm.cpp and make them functions
3806         rather than macros.
3807
3808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3809         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3810         (TestWebKitAPI::testUnsignedLEBDecode):
3811         (TestWebKitAPI::TEST):
3812         (TestWebKitAPI::testInt32LEBDecode):
3813
3814 2016-12-08  Chris Dumez  <cdumez@apple.com>
3815
3816         Support running the layout tests offline
3817         https://bugs.webkit.org/show_bug.cgi?id=165534
3818
3819         Reviewed by Ryosuke Niwa.
3820
3821         * Scripts/webkitpy/common/system/autoinstall.py:
3822         (AutoInstaller._download_to_stream):
3823         getcode() returns None for file URLs so handle this.
3824
3825         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3826         (WebPlatformTestServer._install_modules):
3827         Deal with local path in the json file and resolve them into file URLs
3828         before using AutoInstall.
3829
3830 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3831
3832         Fix CMake build.
3833
3834         * DumpRenderTree/PlatformMac.cmake:
3835         Remove CheckedMalloc.cpp after r209516.
3836
3837 2016-12-07  Mark Lam  <mark.lam@apple.com>
3838
3839         DumpRenderTree should stop using CheckedMalloc.
3840         https://bugs.webkit.org/show_bug.cgi?id=165563
3841         <rdar://problem/28945820>
3842
3843         Reviewed by Geoffrey Garen.
3844
3845         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3846            in CheckedMalloc.
3847         2. bmalloc does not honor the settings of CheckedMalloc.
3848
3849         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3850         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3851         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3852         with WKTR.
3853
3854         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3855         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3856         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3857         * DumpRenderTree/mac/DumpRenderTree.mm:
3858         (prepareConsistentTestingEnvironment):
3859
3860 2016-12-07  Dean Jackson  <dino@apple.com>
3861
3862         Remove runtime toggle for pointer-lock
3863         https://bugs.webkit.org/show_bug.cgi?id=165577
3864         <rdar://problems/29566996>
3865
3866         Reviewed by Jon Lee.
3867
3868         Remove any runtime calls to check if pointer-lock is enabled. It's
3869         either compiled in or out.
3870
3871         * DumpRenderTree/mac/DumpRenderTree.mm:
3872         (resetWebPreferencesToConsistentValues):
3873         * WebKitTestRunner/TestController.cpp:
3874         (WTR::TestController::resetPreferencesToConsistentValues):
3875
3876 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3877
3878         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3879         https://bugs.webkit.org/show_bug.cgi?id=165476
3880
3881         Reviewed by Brady Eidson.
3882         
3883         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3884         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3885         is reset and recreated when a web page exits and is reloaded.
3886
3887         * TestWebKitAPI/PlatformGTK.cmake:
3888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3889         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3890         (TestWebKitAPI::checkUserMediaPermissionCallback):
3891         (TestWebKitAPI::TEST):
3892         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3893
3894 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3895
3896         One esc to exit fullscreen and pointer lock
3897         https://bugs.webkit.org/show_bug.cgi?id=165416
3898         rdar://problem/29430711
3899
3900         Reviewed by Jer Noble.
3901
3902         Implement WKPageUIClientV8 for pointer lock support.
3903         Add "escape" key support in EventSenderProxy.
3904
3905         * WebKitTestRunner/TestController.cpp:
3906         (WTR::requestPointerLock):
3907         (WTR::TestController::createOtherPage):
3908         (WTR::TestController::createWebViewWithOptions):
3909         * WebKitTestRunner/mac/EventSenderProxy.mm:
3910         (WTR::EventSenderProxy::keyDown):
3911
3912 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3913
3914         Add system trace points for JavaScript VM entry/exit
3915         https://bugs.webkit.org/show_bug.cgi?id=165550
3916
3917         Reviewed by Tim Horton.
3918
3919         Add trace points for entry/exit into/out of the JS VM.
3920
3921         * Tracing/SystemTracePoints.plist:
3922
3923 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3924
3925         [GTK] Cannot build GTK+ with CUPS 2.* versions
3926         https://bugs.webkit.org/show_bug.cgi?id=163591
3927
3928         Reviewed by Michael Catanzaro.
3929
3930         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3931         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3932         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3933         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3934         causes many printing test failures. So, I propose to fix the configuration issue by
3935         applying the change to the configure file directly. By doing this, we don't need to
3936         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3937
3938         * gtk/jhbuild.modules:
3939         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3940
3941 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3942
3943         Fix use of enum in a WK2 C SPI header.
3944         rdar://problem/28725583
3945
3946         Followup to correctly prefix the enum values.
3947
3948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3949         (WTR::InjectedBundlePage::prepare):
3950
3951 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3952
3953         Fix use of enum in a WK2 C SPI header.
3954         rdar://problem/28725583
3955
3956         Reviewed by Dan Bernstein.
3957
3958         Use correct enum style for a C SPI header and fix the callers.
3959
3960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3961         (WTR::InjectedBundlePage::prepare):
3962
3963 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3964
3965         Add a new project for recording and playing back editing commands in editable web content
3966         https://bugs.webkit.org/show_bug.cgi?id=165114
3967         <rdar://problem/29408135>
3968
3969         Reviewed by Beth Dakin.
3970
3971         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3972         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3973         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3974         then be dragged into the playback test harness.
3975
3976         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3977         steps:
3978
3979         1. Load the capture harness and perform test-specific editing on the web view.
3980         2. Let originalState be a dump of the DOM at this point in time.
3981         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3982         4. Rewind all editing to the beginning.
3983         5. Playback all editing to the end.
3984         6. Dump the state of the DOM. This should be identical to originalState.
3985
3986         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3987         * EditingHistory/EditingHistory/Info.plist: Added.
3988         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3989         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3990         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3991         * EditingHistory/EditingHistory/TestRunner.h: Added.
3992         * EditingHistory/EditingHistory/TestRunner.m: Added.
3993         (injectedMessageEventHandlerScript):
3994         (-[TestRunner init]):
3995         (-[TestRunner deleteBackwards:]):
3996         (-[TestRunner typeString:]):
3997         (-[TestRunner bodyElementSubtree]):
3998         (-[TestRunner bodyTextContent]):
3999         (-[TestRunner editingHistoryJSON]):
4000         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
4001         (-[TestRunner numberOfUpdates]):
4002         (-[TestRunner jumpToUpdateIndex:]):
4003         (-[TestRunner expectEvents:afterPerforming:]):
4004         (-[TestRunner loadCaptureTestHarness]):
4005         (-[TestRunner setTextObfuscationEnabled:]):
4006         (-[TestRunner isDoneWaitingForPendingEvents]):
4007         (-[TestRunner userContentController:didReceiveScriptMessage:]):
4008
4009         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
4010         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
4011
4012         * EditingHistory/EditingHistory/TestUtil.h: Added.
4013         * EditingHistory/EditingHistory/TestUtil.m: Added.
4014         (waitUntilWithTimeout):
4015         (waitUntil):
4016
4017         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
4018
4019         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
4020         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
4021         (-[WKWebView loadPageFromBundleNamed:]):
4022         (-[WKWebView typeCharacter:]):
4023         (-[WKWebView keyPressWithCharacters:keyCode:]):
4024         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
4025
4026         Provides utilities for simulating interaction in a web view.
4027
4028         * EditingHistory/EditingHistory/main.m: Added.
4029         (main):
4030         * EditingHistory/EditingHistoryTests/Info.plist: Added.
4031         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
4032         (-[RewindAndPlaybackTests setUp]):
4033         (-[RewindAndPlaybackTests tearDown]):
4034         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
4035         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
4036         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
4037         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
4038         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
4039
4040 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4041
4042         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
4043         https://bugs.webkit.org/show_bug.cgi?id=165525
4044
4045         Reviewed by Carlos Garcia Campos.
4046
4047         * gtk/jhbuild.modules: gst-plugins-good should depend on the
4048         libvpx package built within jhbuild.
4049
4050 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4051
4052         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
4053         https://bugs.webkit.org/show_bug.cgi?id=165520
4054
4055         Reviewed by Carlos Garcia Campos.
4056
4057         * gtk/jhbuild.modules: Added missing dependency on openh264 in
4058         gst-plugins-bad, along with 2 upstream patches fixing the build
4059         against OpenSSL 1.1.0.
4060         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4061         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4062
4063 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
4064
4065         Correct SDKROOT values in xcconfig files
4066         https://bugs.webkit.org/show_bug.cgi?id=165487
4067         rdar://problem/29539209
4068
4069         Reviewed by Dan Bernstein.
4070
4071         Fix suggested by Dan Bernstein.
4072
4073         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
4074         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4075         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4076         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4077         * WebEditingTester/Configurations/DebugRelease.xcconfig:
4078         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4079
4080 2016-12-06  Daniel Bates  <dabates@apple.com>
4081
4082         WebKitTestRunner: Plugins are disabled in new windows
4083         https://bugs.webkit.org/show_bug.cgi?id=165410
4084
4085         Reviewed by Alex Christensen.
4086
4087         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
4088         a new window and loads a plugin will fail. We should enable plugins in all windows by
4089         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4090
4091         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4092         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4093         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4094
4095         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4096         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4097         WKBundleSetPluginsEnabled().
4098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4099         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
4100         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
4101
4102 2016-12-05  Dean Jackson  <dino@apple.com>
4103
4104         pointer lock needs to be feature detectable
4105         https://bugs.webkit.org/show_bug.cgi?id=165426
4106         <rdar://problem/29486715>
4107
4108         Reviewed by Antoine Quint.
4109
4110         Expose the comment line to turn on/off pointer lock.
4111
4112         * DumpRenderTree/TestOptions.h:
4113         * DumpRenderTree/TestOptions.mm:
4114         (TestOptions::TestOptions):
4115         * DumpRenderTree/mac/DumpRenderTree.mm:
4116         (resetWebPreferencesToConsistentValues):
4117         * WebKitTestRunner/TestController.cpp:
4118         (WTR::TestController::resetPreferencesToConsistentValues):
4119         (WTR::updateTestOptionsFromTestHeader):
4120         * WebKitTestRunner/TestOptions.h:
4121         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4122         (WTR::PlatformWebView::viewSupportsOptions):
4123         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4124         (WTR::PlatformWebView::viewSupportsOptions):
4125
4126 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
4127
4128         Make it possible to use an existing simulator instance for one-off testing
4129         https://bugs.webkit.org/show_bug.cgi?id=164568
4130         <rdar://problem/29189133>
4131
4132         Reviewed by Daniel Bates.
4133
4134         With this patch, if a simulator is currently running on the machine and
4135         '--dedicated-simulators' is not passed into the application, only one simulator
4136         instance will be used, and this instance will be the existing instance.
4137         If no simulator is running or '--dedicated-simulators' is passed to the script,
4138         previous behavior will be used.
4139
4140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4141         (parse_args):
4142         * Scripts/webkitpy/port/ios.py:
4143         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4144         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4145         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4146         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4147         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
4148         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
4149         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
4150         * Scripts/webkitpy/xcode/simulator.py:
4151         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
4152         (Simulator.current_device): Get currently running device.
4153
4154 2016-12-05  Dan Bernstein  <mitz@apple.com>
4155
4156         Disable a crashing test on iOS.
4157
4158         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4159
4160 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4161
4162         Fix a build break on EFL since r209303.
4163
4164         Unreviewed build fix.
4165
4166         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
4167
4168 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4169
4170         Refactor SymbolImpl layout
4171         https://bugs.webkit.org/show_bug.cgi?id=165247
4172
4173         Reviewed by Darin Adler.
4174
4175         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4176         (TestWebKitAPI::TEST):
4177
4178 2016-12-03  Dan Bernstein  <mitz@apple.com>
4179
4180         Fixed the build after r209307.
4181
4182         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4183         (TEST):
4184
4185 2016-12-03  Dan Bernstein  <mitz@apple.com>
4186
4187         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
4188         https://bugs.webkit.org/show_bug.cgi?id=165276
4189         <rdar://problem/29467040>
4190
4191         Reviewed by Darin Adler.
4192
4193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4194         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
4195         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
4196         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
4197         (TEST):
4198         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
4199         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4200         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
4201         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
4202         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
4203         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
4204
4205 2016-12-02  Andy Estes  <aestes@apple.com>
4206
4207         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
4208         https://bugs.webkit.org/show_bug.cgi?id=164492
4209
4210         Reviewed by Dan Bernstein.
4211
4212         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
4213         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
4214         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
4215         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
4216         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
4217         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
4218         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
4219         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
4220         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4221         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4222         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4223         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4224         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
4225         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4226         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
4227         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4228         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4229         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4230         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4231         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4232         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4233         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4234         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4235         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
4236         value ${PRODUCT_BUNDLE_IDENTIFIER}.
4237         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4238         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4239         com.apple.WebKitTestRunner.InjectedBundle.
4240         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
4241         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4242         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4243         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
4244         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
4245         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
4246         ${PRODUCT_BUNDLE_IDENTIFIER}.
4247
4248 2016-12-02  Brady Eidson  <beidson@apple.com>
4249
4250         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
4251         https://bugs.webkit.org/show_bug.cgi?id=165330
4252
4253         Reviewed by Alex Christensen.
4254
4255         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
4256
4257         Problem is that doesn't reliably destroy the view.
4258         We should explicitly kill the process instead.
4259
4260         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
4261         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
4262
4263         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4264         (TEST):
4265
4266 2016-12-02  Commit Queue  <commit-queue@webkit.org>
4267
4268         Unreviewed, rolling out r209136.
4269         https://bugs.webkit.org/show_bug.cgi?id=165337
4270
4271         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
4272
4273         Reverted changeset:
4274
4275         "Make it possible to use an existing simulator instance for
4276         one-off testing"
4277         https://bugs.webkit.org/show_bug.cgi?id=164568
4278         http://trac.webkit.org/changeset/209136
4279
4280 2016-12-02  Chris Dumez  <cdumez@apple.com>
4281
4282         [Mac][WK1] Implement new HTML interactive form validation user interface
4283         https://bugs.webkit.org/show_bug.cgi?id=164483
4284
4285         Reviewed by Simon Fraser.
4286
4287         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
4288         on Mac DRT as this is needed by the HTML form validation layout tests.
4289
4290         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4291         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4292
4293 2016-12-02  Brady Eidson  <beidson@apple.com>
4294
4295         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
4296         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
4297
4298         Reviewed by Alexey Proskuryakov.
4299
4300