REGRESSION (r146518): WebKit2APITests/TestInspector is failing
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
2
3         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
4         https://bugs.webkit.org/show_bug.cgi?id=113281
5
6         Reviewed by Darin Adler.
7
8         * Scripts/run-gtk-tests:
9         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
10
11 2013-04-09  Glenn Adams  <glenn@skynav.com>
12
13         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
14
15         Unreviewed.
16
17         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
18         (RunTest.test_build_check):
19
20 2013-04-09  Glenn Adams  <glenn@skynav.com>
21
22         [webkitpy] Remove chromium ports.
23         https://bugs.webkit.org/show_bug.cgi?id=114326
24
25         Reviewed by Dirk Pranke.
26
27         As a side effect, also:
28
29         - remove chromium builders from webkitpy.layout_tests.port.builders
30         - remove chromium builders from rebaseline
31         - rewrite chromium dependent tests in rebaseline_unittest
32         - remove chromium platform from garden-o-matic
33         - select apple platform as default platform in garden-o-matic
34         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
35
36         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
37         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
38         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
39         (BaselineOptimizerTest.test_move_baselines):
40         (BaselineOptimizerTest.test_efl):
41         (BaselineOptimizerTest.test_no_add_mac_future):
42         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
43         (BaselineOptimizerTest.test_common_directory_includes_root):
44         (BaselineOptimizerTest.test_complex_shadowing):
45         (BaselineOptimizerTest.test_virtual_ports_filtered):
46         * Scripts/webkitpy/layout_tests/port/builders.py:
47         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
48         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
49         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
50         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
51         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
52         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
53         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
54         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
55         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
56         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
57         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
58         * Scripts/webkitpy/layout_tests/port/factory.py:
59         (platform_options):
60         (PortFactory):
61         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
62         (FactoryTest.test_qt):
63         (FactoryTest.test_get_from_builder_name):
64         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
65         (RunTest.test_build_check):
66         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
67         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
68         * Scripts/webkitpy/tool/commands/rebaseline.py:
69         (Rebaseline._builders_to_pull_from):
70         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
71         (_BaseTestCase):
72         (_BaseTestCase.setUp):
73         (TestRebaselineTest.setUp):
74         (TestRebaselineTest.test_baseline_directory):
75         (test_rebaseline_updates_expectations_file):
76         (test_rebaseline_does_not_include_overrides):
77         (test_rebaseline_test):
78         (test_rebaseline_test_and_print_scm_changes):
79         (test_rebaseline_and_copy_test):
80         (test_rebaseline_and_copy_test_no_existing_result):
81         (test_rebaseline_and_copy_test_with_lion_result):
82         (test_rebaseline_and_copy_no_overwrite_test):
83         (TestRebaselineExpectations.test_rebaseline_expectations):
84
85 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
86
87         newcommitbot (WKR) requires a subversion checkout
88         https://bugs.webkit.org/show_bug.cgi?id=114309
89
90         Reviewed by Benjamin Poulain.
91
92         Directly talk to the subversion server instead of relying on a local checkout.
93         This allows us to run WKR off of a git clone.
94
95         * Scripts/webkitpy/tool/commands/newcommitbot.py:
96         (NewCommitBot.next_work_item):
97         (NewCommitBot.process_work_item):
98
99 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
100
101         webkitbot refers to sheriffbot in help
102         https://bugs.webkit.org/show_bug.cgi?id=114307
103
104         Reviewed by Benjamin Poulain.
105
106         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
107
108         * Scripts/webkitpy/tool/bot/irc_command.py:
109         (Help):
110         (Help.execute):
111         (RollChromiumDEPS.execute):
112         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
113         (IRCBotTest.test_help):
114         * Scripts/webkitpy/tool/bot/sheriff.py:
115         (Sheriff.name):
116
117 2013-04-06  Roger Fong  <roger_fong@apple.com>
118
119         Kill old processes between runs on WinEWS bots.
120         Temporarily disable tests to let bots catch up again.
121
122         * EWSTools/start-queue-win.sh:
123         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
124         (WinEWS):
125
126 2013-04-09  Glenn Adams  <glenn@skynav.com>
127
128         [webkitpy] Remove chromium deprecated port support.
129         https://bugs.webkit.org/show_bug.cgi?id=114228
130
131         Reviewed by Ryosuke Niwa.
132
133         * Scripts/webkitpy/common/config/ports.py:
134         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
135         (ChromiumPort): Removed.
136         (ChromiumAndroidPort): Removed.
137         (ChromiumXVFBPort): Removed.
138         * Scripts/webkitpy/common/config/ports_unittest.py:
139         (DeprecatedPortTest.test_chromium_port): Removed.
140         (DeprecatedPortTest.test_chromium_android_port): Removed.
141         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
142         * Scripts/webkitpy/tool/steps/update_unittest.py:
143         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
144         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
145
146 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
147
148         AX: The bounding paths should be made available through accessibility
149         https://bugs.webkit.org/show_bug.cgi?id=113817
150
151         Reviewed by David Kilzer.
152
153         Add a pathDescription property for testing so that it's possible
154         to verify that a path is being returned correctly.
155
156         * DumpRenderTree/AccessibilityUIElement.cpp:
157         (getPathDescriptionCallback):
158         (AccessibilityUIElement::pathDescription):
159         (AccessibilityUIElement::getJSClass):
160         * DumpRenderTree/AccessibilityUIElement.h:
161         (AccessibilityUIElement):
162         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
163         (_CGPathEnumerationIteration):
164         (AccessibilityUIElement::pathDescription):
165         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
166         (AccessibilityUIElement::pathDescription):
167         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
168         (WTR::AccessibilityUIElement::pathDescription):
169         (WTR):
170         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
171         (AccessibilityUIElement):
172         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
173         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
174         (WTR::AccessibilityUIElement::pathDescription):
175         (WTR):
176
177 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
178
179         [EFL] Declare TEST_THEME_DIR in a single place.
180         https://bugs.webkit.org/show_bug.cgi?id=114285
181
182         Reviewed by Anders Carlsson.
183
184         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
185
186         * DumpRenderTree/efl/CMakeLists.txt:
187         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
188         (DumpRenderTreeChrome::createView):
189         (DumpRenderTreeChrome::createInspectorView):
190         (DumpRenderTreeChrome::initialize):
191         (DumpRenderTreeChrome::onDownloadRequest):
192         * EWebLauncher/CMakeLists.txt:
193         * EWebLauncher/main.c:
194         (findThemePath):
195         * EWebLauncher/url_bar.c:
196         (url_bar_add):
197         * MiniBrowser/efl/CMakeLists.txt:
198         * MiniBrowser/efl/main.c:
199         (window_create):
200         * TestWebKitAPI/PlatformEfl.cmake:
201         * TestWebKitAPI/efl/PlatformWebView.cpp:
202         (TestWebKitAPI::PlatformWebView::PlatformWebView):
203         * WebKitTestRunner/PlatformEfl.cmake:
204         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
205         (WTR::PlatformWebView::PlatformWebView):
206
207 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
208
209         [GTK][AC] upversion of clutter and its dependecy
210         https://bugs.webkit.org/show_bug.cgi?id=114016
211
212         Reviewed by Gustavo Noronha Silva.
213
214         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
215
216         * gtk/jhbuild-optional.modules:
217
218 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
219
220         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
221         https://bugs.webkit.org/show_bug.cgi?id=89875
222
223         Reviewed by Maciej Stachowiak.
224
225         Add unit tests to verify if the handling of the open, openat, creat syscall
226         is being done right. We check if the Read/Write/ReadAndWrite permissions
227         are respected, if the canonical path is being resolved and if
228         the permissions are falling back to the topmost parent directory with a
229         policy set when the directory being opened has no policy.
230
231         We also test if any attempt of blocking SIGSYS is silently ignored.
232         SIGSYS cannot be blocked because in it's handler is where we hook
233         syscalls to the broker process.
234
235         Also added libseccomp to EFL's jhbuild to make the life of developers
236         willing to help easier.
237
238         * Scripts/webkitperl/FeatureList.pm:
239         * TestWebKitAPI/PlatformEfl.cmake:
240         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
241         (TestWebKitAPI):
242         (SeccompEnvironment):
243         (TestWebKitAPI::SeccompEnvironment::SetUp):
244         (TestWebKitAPI::SeccompEnvironment::TearDown):
245         (TestWebKitAPI::dummyHandler):
246         (TestWebKitAPI::TEST):
247         (TestWebKitAPI::stressTest):
248         * efl/jhbuild.modules:
249         * qmake/mkspecs/features/features.pri:
250
251 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
252
253         REGRESSION: Autocorrection doesn't work in DumpRenderTree
254         https://bugs.webkit.org/show_bug.cgi?id=113846
255
256         Reviewed by Alexey Proskuryakov.
257
258         The problem was that we were replacing NSSpellCheck's dictionary with our own
259         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
260
261         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
262         and "would" respectively in DumpRenderTree.
263
264         * DumpRenderTree/mac/DumpRenderTree.mm:
265         (resetDefaultsToConsistentValues):
266
267 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
268
269         Remove the gyp files for Tools
270         https://bugs.webkit.org/show_bug.cgi?id=114248
271
272         Reviewed by Ryosuke Niwa.
273
274         * DumpRenderTree/DumpRenderTree.gyp: Removed.
275         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
276         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
277         * DumpRenderTree/DumpRenderTree.gypi: Removed.
278         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
279         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
280         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
281         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
282
283 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
284
285         WKR (new-commit-bot) is too slow
286         https://bugs.webkit.org/show_bug.cgi?id=110087
287
288         Reviewed by Geoffrey Garen.
289
290         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
291         Just run "svn log -r <revision>" instead to cut down the delay.
292
293         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
294
295         * Scripts/webkitpy/tool/commands/newcommitbot.py:
296         (NewCommitBot):
297         (NewCommitBot.next_work_item):
298         (NewCommitBot._is_empty_log):
299         (NewCommitBot._update_checkout):
300
301 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
302
303         Build fix. Can't remove appendCustomBuildFlags.
304
305         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
306         (appendCustomBuildFlags):
307
308 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
309
310         Remove Chromium builders from build.webkit.org
311         https://bugs.webkit.org/show_bug.cgi?id=113990
312
313         Reviewed by Benjamin Poulain.
314
315         Removed.
316
317         * BuildSlaveSupport/build.webkit.org-config/config.json:
318         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
319         (InstallGtkDependencies):
320         (RunUnitTests.start):
321         (RunWebKit2Tests.start):
322         (Factory.__init__):
323         (unitTestsSupported):
324         (TestFactory.__init__):
325         (BuildAndTestFactory.__init__):
326         (BuildAndPerfTestFactory.__init__):
327         (BuildAndPerfTestWebKit2Factory.__init__):
328         (DownloadAndPerfTestFactory.__init__):
329         (loadBuilderConfig):
330         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
331
332 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
333
334         Remove HTML Notification
335         https://bugs.webkit.org/show_bug.cgi?id=114231
336
337         Reviewed by Ryosuke Niwa.
338
339         * qmake/mkspecs/features/features.pri:
340
341 2013-04-08  Glenn Adams  <glenn@skynav.com>
342
343         Remove chromium EWS support, and fix broken test.
344         https://bugs.webkit.org/show_bug.cgi?id=114221
345
346         Reviewed by Ryosuke Niwa.
347
348         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
349         (AbstractChromiumEWS): Removed.
350         (ChromiumLinuxEWS): Removed.
351         (ChromiumLinuxDebugEWS): Removed.
352         (ChromiumWindowsEWS): Removed.
353         (ChromiumAndroidEWS): Removed.
354         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
355         (EarlyWarningSystemTest): Fix misspelled class name.
356         (test_ewses): Fix entry point name to ensure test is run.
357
358 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
359
360         [WIN] Remove WebKit2 source code
361         https://bugs.webkit.org/show_bug.cgi?id=114096
362
363         Reviewed by Anders Carlsson.
364
365         Remove the windows specific parts of the MiniBrowser.
366
367         * MiniBrowser/MiniBrowser.vcproj: Removed.
368         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
369         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
370         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
371         * MiniBrowser/win/BrowserView.cpp: Removed.
372         * MiniBrowser/win/BrowserView.h: Removed.
373         * MiniBrowser/win/BrowserWindow.cpp: Removed.
374         * MiniBrowser/win/BrowserWindow.h: Removed.
375         * MiniBrowser/win/MiniBrowser.cpp: Removed.
376         * MiniBrowser/win/MiniBrowser.h: Removed.
377         * MiniBrowser/win/MiniBrowser.rc: Removed.
378         * MiniBrowser/win/main.cpp: Removed.
379         * MiniBrowser/win/resource.h: Removed.
380         * MiniBrowser/win/stdafx.cpp: Removed.
381         * MiniBrowser/win/stdafx.h: Removed.
382
383 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
384
385         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
386
387         * Scripts/webkitpy/common/config/irc.py:
388
389 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
390
391         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
392         https://bugs.webkit.org/show_bug.cgi?id=113139
393
394         Reviewed by Anders Carlsson.
395
396         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
397         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
398         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
399         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
400         (ToStringAndValueOfObject):
401         (ToStringAndValueOfObject::ToStringAndValueOfObject):
402         (ScriptableObject):
403         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
404         (ToStringAndValueOfObject::ScriptableObject::invoke):
405         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
406         (ToStringAndValueOfObject::NPP_GetValue):
407         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
408         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
409         * GNUmakefile.am:
410
411 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
412
413         [GTK] Bump gnome-themes-standard to 3.6.0
414         https://bugs.webkit.org/show_bug.cgi?id=114155
415
416         Reviewed by Martin Robinson.
417
418         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
419         dependency of gnome-themes-standard accordingly.
420
421 2013-04-08  David Levin  <levin@chromium.org>
422
423         Remove my watchlist entries.
424         https://bugs.webkit.org/show_bug.cgi?id=114180
425
426         Reviewed by Adam Barth.
427
428         * Scripts/webkitpy/common/config/committers.py:
429         * Scripts/webkitpy/common/config/watchlist:
430
431 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
432
433         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
434         https://bugs.webkit.org/show_bug.cgi?id=114161
435
436         Reviewed by Gyuyoung Kim.
437
438         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
439         as it is crashing due to Bug 111074.
440
441         * TestWebKitAPI/PlatformEfl.cmake:
442
443 2013-04-07  David Kilzer  <ddkilzer@apple.com>
444
445         Remove the rest of SVG_DOM_OBJC_BINDINGS
446         <http://webkit.org/b/114112>
447
448         Reviewed by Geoffrey Garen.
449
450         * Scripts/webkitperl/FeatureList.pm:
451         - Remove --svg-dom-objc-bindings switch.
452         * qmake/mkspecs/features/features.pri:
453         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
454
455 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
456
457         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
458         https://bugs.webkit.org/show_bug.cgi?id=114089
459
460         Reviewed by Chris Fleizach.
461
462         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
463         * DumpRenderTree/AccessibilityController.cpp:
464         * DumpRenderTree/AccessibilityUIElement.cpp:
465         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
466         (DumpRenderTreeChrome::DumpRenderTreeChrome):
467         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
468         (DumpRenderTreeChrome):
469
470 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
471
472         Build fix after r147857, remove remaining USE(JSC) guards.
473
474         Unreviewed.
475
476         * DumpRenderTree/config.h:
477         * TestWebKitAPI/config.h:
478         * WebKitTestRunner/config.h:
479
480 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
481
482         Rename sheriffbot to webkitbot
483         https://bugs.webkit.org/show_bug.cgi?id=114109
484
485         Reviewed by Benjamin Poulain.
486
487         Renamed since sheriffbot will be used in Blink.
488
489         * Scripts/webkitpy/tool/commands/sheriffbot.py:
490         (SheriffBot):
491         (SheriffBot.begin_work_queue):
492
493 2013-04-06  Oliver Hunt  <oliver@apple.com>
494
495         Unify the many and varied stack trace mechanisms, and make the result sane.
496         https://bugs.webkit.org/show_bug.cgi?id=114072
497
498         Reviewed by Filip Pizlo.
499
500         The commandline jsc executable no longer requires arguments, so
501         I've made run-jsc work without them.
502
503         * Scripts/run-jsc:
504
505 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
506
507         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
508         https://bugs.webkit.org/show_bug.cgi?id=114086
509
510         Reviewed by Tim Horton.
511
512         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
513
514 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
515
516         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
517         https://bugs.webkit.org/show_bug.cgi?id=114083
518
519         Reviewed by Ryosuke Niwa.
520
521         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
522         in TestWebKitAPI and WebKitTestRunner.
523
524         * TestWebKitAPI/config.h:
525         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
526         (TestWebKitAPI::InjectedBundleController::platformInitialize):
527         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
528         (WTR::InjectedBundle::platformInitialize):
529
530 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
531
532         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
533         https://bugs.webkit.org/show_bug.cgi?id=114094
534
535         Reviewed by Anders Carlsson.
536
537         * Scripts/run-jsc:
538
539 2013-04-05  Ojan Vafai  <ojan@chromium.org>
540
541         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
542         https://bugs.webkit.org/show_bug.cgi?id=114080
543
544         Reviewed by Ryosuke Niwa.
545
546         This way, the WebKit and Blink dashboard code can change as appropriate without
547         needing to consider the other project's needs. This still doesn't update the
548         buildbots to upload to the new location, or the dashboard code to pull the
549         results.json files from the new location, but it at least allows for changing the
550         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
551
552         * TestResultServer/app.yaml:
553
554 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
555
556         Re-enable testing on the commit queue
557         https://bugs.webkit.org/show_bug.cgi?id=114078
558
559         Reviewed by Darin Adler.
560
561         Re-enabled the feature and the associated tests.
562
563         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
564         (CommitQueueTask.run):
565         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
566         (CommitQueueTaskTest._run_through_task):
567         * Scripts/webkitpy/tool/commands/queues_unittest.py:
568         (CommitQueueTest._mock_test_result):
569
570 2013-04-05  Oliver Hunt  <oliver@apple.com>
571
572         Unify the many and varied stack trace mechanisms, and make the result sane.
573         https://bugs.webkit.org/show_bug.cgi?id=114072
574
575         Reviewed by Filip Pizlo.
576
577         The commandline jsc executable no longer requires arguments, so
578         I've made run-jsc work without them.
579
580         * Scripts/run-jsc:
581
582 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
583
584         AX: Make SVG Group containers accessible elements
585         https://bugs.webkit.org/show_bug.cgi?id=113939
586
587         Reviewed by Simon Fraser.
588
589         Implement axController.elementAtPoint for iOS.
590         Implement a correct version of clickPoint for iOS.
591
592         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
593         (AccessibilityController::elementAtPoint):
594         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
595         (AccessibilityUIElement::clickPointX):
596         (AccessibilityUIElement::clickPointY):
597
598 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
599
600         Unreviewed, rolling out r147773 and r147774.
601         http://trac.webkit.org/changeset/147773
602         http://trac.webkit.org/changeset/147774
603         https://bugs.webkit.org/show_bug.cgi?id=114056
604
605         Causing some exceptions on AppEngine I don't understand
606         (Requested by rniwa on #webkit).
607
608         * QueueStatusServer/config/queues.py:
609         * QueueStatusServer/model/queues.py:
610         (Queue.short_name):
611         (Queue.display_name):
612         * QueueStatusServer/model/queues_unittest.py:
613         (QueueTest.test_short_name):
614         (QueueTest.test_display_name):
615         (QueueTest.test_name_with_underscores):
616
617 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
618
619         Fixed run-bindings-tests by removing V8
620         https://bugs.webkit.org/show_bug.cgi?id=114053
621
622         Reviewed by Benjamin Poulain.
623
624         * Scripts/run-bindings-tests:
625         (main):
626
627 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
628
629         Build fix.
630
631         * QueueStatusServer/model/queues.py:
632         (Queue.short_name):
633         (Queue.display_name):
634
635 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
636
637         Remove Chromium EWS bots from the queue status server
638         https://bugs.webkit.org/show_bug.cgi?id=113988
639
640         Reviewed by Benjamin Poulain.
641
642         Removed Chromium EWS bots.
643
644         * QueueStatusServer/config/queues.py:
645         * QueueStatusServer/model/queues.py:
646         (Queue.short_name):
647         (Queue.display_name):
648         * QueueStatusServer/model/queues_unittest.py:
649         (QueueTest.test_short_name):
650         (QueueTest.test_display_name):
651         (QueueTest.test_name_with_underscores):
652
653 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
654
655         [EFL] Enable indexed database
656         https://bugs.webkit.org/show_bug.cgi?id=107248
657
658         Reviewed by Alexis Menard.
659
660         * Scripts/webkitperl/FeatureList.pm:
661
662 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
663
664         Remove vestiges of Chromium bits from watchlists.
665         https://bugs.webkit.org/show_bug.cgi?id=114047
666
667         Reviewed by Ryosuke Niwa.
668
669         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
670
671 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
672
673         Add James Craig to the contributors list.
674
675         * Scripts/webkitpy/common/config/committers.py:
676
677 2013-04-04  Kent Tamura  <tkent@chromium.org>
678
679         Remove ChromiumPublicApi pattern, and cc/message rules for it.
680
681         * Scripts/webkitpy/common/config/watchlist:
682
683 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
684
685         Temporarily disable the Python unittests broken by the commit queue not running layout tests
686         https://bugs.webkit.org/show_bug.cgi?id=113997
687
688         Reviewed by Ryosuke Niwa.
689
690         Disable the tests until Ryosuke gets the time and hardware to have
691         a testing commit-queue.
692
693         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
694         (CommitQueueTaskTest):
695         * Scripts/webkitpy/tool/commands/queues_unittest.py:
696         (CommitQueueTest):
697
698 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
699
700         Remove Chromium builders from build.webkit.org
701         https://bugs.webkit.org/show_bug.cgi?id=113990
702
703         Reviewed by Benjamin Poulain.
704
705         Land the part to disable triggering of Chromium builders first so that we may start
706         deleting more Chromium code that breaks the update step.
707
708         * BuildSlaveSupport/build.webkit.org-config/config.json:
709
710 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
711
712         Remove Chromium's DumpRenderTree
713         https://bugs.webkit.org/show_bug.cgi?id=113989
714
715         Reviewed by Kent Tamura.
716
717         On second thought, let's not go to Camelot. It is a silly place.
718
719         * DumpRenderTree/mac/DumpRenderTree.mm:
720         (resetDefaultsToConsistentValues):
721
722 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
723
724         Nixed the defunct chromium folder from DumpRenderTree
725         https://bugs.webkit.org/show_bug.cgi?id=113993
726
727         Reviewed by Ryosuke Niwa.
728
729         * DumpRenderTree/chromium: Removed.
730         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
731         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
732         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
733         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
734         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
735         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
736         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
737         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
738         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
739         * DumpRenderTree/chromium/MockPlatform.h: Removed.
740         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
741         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
742         * DumpRenderTree/chromium/Task.cpp: Removed.
743         * DumpRenderTree/chromium/Task.h: Removed.
744         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
745         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
746         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
747         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
748         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
749         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
750         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
751         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
752         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
753         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
754         * DumpRenderTree/chromium/TestRunner: Removed.
755         * DumpRenderTree/chromium/TestRunner/public: Removed.
756         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
757         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
758         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
759         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
760         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
761         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
762         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
763         * DumpRenderTree/chromium/TestRunner/src: Removed.
764         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
765         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
766         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
767         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
768         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
769         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
770         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
771         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
772         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
773         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
774         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
775         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
776         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
777         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
778         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
779         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
780         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
781         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
782         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
783         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
784         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
785         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
786         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
787         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
788         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
789         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
790         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
791         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
792         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
793         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
794         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
795         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
796         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
797         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
798         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
799         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
800         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
801         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
802         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
803         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
804         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
805         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
806         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
807         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
808         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
809         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
810         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
811         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
812         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
813         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
814         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
815         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
816         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
817         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
818         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
819         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
820         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
821         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
822         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
823         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
824         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
825         * DumpRenderTree/chromium/TestShell.cpp: Removed.
826         * DumpRenderTree/chromium/TestShell.h: Removed.
827         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
828         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
829         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
830         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
831         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
832         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
833         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
834         * DumpRenderTree/chromium/WebViewHost.h: Removed.
835         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
836         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
837         * DumpRenderTree/chromium/config.h: Removed.
838         * DumpRenderTree/chromium/fonts.conf: Removed.
839
840 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
841
842         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
843
844         Rubber stamped by Benjamin Poulain.
845
846         * RebaselineQueueServer: Removed.
847         * RebaselineQueueServer/app.yaml: Removed.
848         * RebaselineQueueServer/handlers: Removed.
849         * RebaselineQueueServer/handlers/__init__.py: Removed.
850         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
851         * RebaselineQueueServer/handlers/pages.py: Removed.
852         * RebaselineQueueServer/index.yaml: Removed.
853         * RebaselineQueueServer/main.py: Removed.
854         * RebaselineQueueServer/model: Removed.
855         * RebaselineQueueServer/model/__init__.py: Removed.
856         * RebaselineQueueServer/model/queueentry.py: Removed.
857         * RebaselineQueueServer/static: Removed.
858         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
859         * RebaselineQueueServer/static/styles.css: Removed.
860         * RebaselineQueueServer/templates: Removed.
861         * RebaselineQueueServer/templates/builder-picker.html: Removed.
862         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
863         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
864         * RebaselineQueueServer/templates/home.html: Removed.
865
866 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
867
868         Fix setup-commit-queue and temporarily disable testing on commit-queue
869         https://bugs.webkit.org/show_bug.cgi?id=113979
870
871         Reviewed by Benjamin Poulain.
872
873         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
874         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
875
876         * EWSTools/setup-commit-queue.sh:
877         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
878         (CommitQueueTask.run):
879
880 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
881
882         temporarily make flakiness dashboard work again webkit.org bots
883         https://bugs.webkit.org/show_bug.cgi?id=113972
884
885         Reviewed by Ojan Vafai.
886
887         This patch disables the chromium.org layout test bots TestExpectations
888         parsing temporarily until we can work out the right way to split into
889         two instances for webkit.org and chromium.org and figure out which
890         code to delete where :).
891
892         * TestResultServer/static-dashboards/flakiness_dashboard.js:
893
894 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Fix webkitpy tests after r147678.
897
898         * Scripts/webkitpy/tool/commands/queues_unittest.py:
899         (CommitQueueTest.test_commit_queue):
900         (test_manual_reject_during_processing):
901
902 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
903
904         The commit queue should use Mac MountainLion port
905         https://bugs.webkit.org/show_bug.cgi?id=113971
906
907         Reviewed by Lucas Forschler.
908
909         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
910         * Scripts/webkitpy/tool/commands/queues.py:
911         (CommitQueue):
912
913 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
914
915         turn off running tests on chromium linux EWS bots
916         https://bugs.webkit.org/show_bug.cgi?id=113959
917
918         Reviewed by Geoffrey Garen.
919
920         Now that the Chromium port is no longer being maintained
921         there's little point in running the tests. Soon we should
922         just shut this bot off altogether.
923
924         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
925         (ChromiumLinuxEWS):
926
927 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
928
929         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
930
931         * Scripts/webkitpy/common/config/watchlist:
932
933 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
934
935         Indentation fix to get webkit-patch working again after r147625
936
937         Unreviewed.
938
939         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
940         (MacEWS):
941         (MacWK2EWS):
942
943 2013-04-04  Lucas Forschler  <lforschler@apple.com>
944
945         Turn tests back on for Mac WK1/WK2 EWS.
946         
947         Unreviewed.
948         
949         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
950         (MacEWS):
951         (MacWK2EWS):
952
953 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
954
955         [GTK][WK2] MiniBrowser custom URI scheme support
956         https://bugs.webkit.org/show_bug.cgi?id=112419
957
958         Reviewed by Carlos Garcia Campos.
959
960         Add support for about URIs in MiniBrowser. An example about page is show
961         with URI "about:minibrowser", the rest of the cases it will show a
962         proper message explaining that the about page didn't exist.
963
964         Internally it uses "minibrowser-about" prefix instead of "about", but
965         from the user point of view it works with "about" prefix.
966
967         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
968         (getInternalURI): Method to convert URIs from "about" prefix to
969         "minibrowser-about".
970         (getExternalURI): Opposite method.
971         (webViewURIChanged): Use "about" prefix to show the URI to users.
972         (webViewEnterFullScreen): Ditto.
973         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
974         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
975         (aboutURISchemeRequestCallback): Callback to manage about calls.
976         (main): Register the URI scheme to manage about URIs.
977
978 2013-04-03  Roger Fong  <roger_fong@apple.com>
979
980         Re-enable WinEWS tests.
981
982         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
983         (WinEWS):
984
985 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
986
987         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
988         https://bugs.webkit.org/show_bug.cgi?id=113883
989
990         Reviewed by Martin Robinson.
991
992         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
993         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
994         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
995
996 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
997
998         [GTK] Include Pango in jhbuild-optional.modules
999         https://bugs.webkit.org/show_bug.cgi?id=113878
1000
1001         Reviewed by Martin Robinson.
1002
1003         Since r147547 Pango 1.32.0 is required. Including the module in the
1004         JHBuild optional moduleset.
1005
1006         * gtk/jhbuild-optional.modules: Add Pango module.
1007
1008 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1009
1010         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1011         https://bugs.webkit.org/show_bug.cgi?id=113864
1012
1013         Moving setDefersLoading from TestRunnerQt to TestRunner
1014         requires access to the non-Qt TestRunner.
1015         As long as we instantiate both TestRunner and TestRunnerQt,
1016         we need a separate getter for the non-Qt TestRunner instance.
1017
1018         Reviewed by Simon Hausmann.
1019
1020         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1021         (WebPage::resetSettings):
1022         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1023         (DumpRenderTree::jscTestRunner):
1024         * DumpRenderTree/qt/TestRunnerQt.cpp:
1025         (TestRunner::setDefersLoading):
1026             Moving setDefersLoading from TestRunnerQt
1027             to TestRunner.
1028         * DumpRenderTree/qt/TestRunnerQt.h:
1029         (TestRunnerQt):
1030
1031 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1032
1033         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1034         https://bugs.webkit.org/show_bug.cgi?id=104779
1035
1036         Reviewed by Carlos Garcia Campos.
1037
1038         * Scripts/run-gtk-tests:
1039         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1040         passing in current trunk.
1041
1042 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1043
1044         Fix HAVE(QTTESTSUPPORT) logic
1045
1046         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1047         resulting in HAVE(QTTESTSUPPORT) never being true.
1048         Move that logic down in sanitizeFeatures.
1049
1050         Rubber-stamped by Tor Arne Vestbø.
1051
1052         * qmake/mkspecs/features/features.prf:
1053
1054 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1055
1056         [GTK] Bump required versions of some dependencies
1057         https://bugs.webkit.org/show_bug.cgi?id=113282
1058
1059         Reviewed by Martin Robinson.
1060
1061         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1062
1063 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1064
1065         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1066         https://bugs.webkit.org/show_bug.cgi?id=113809
1067
1068         Reviewed by Philippe Normand.
1069
1070         Newer Linux kernels have removed some deprecated macros from v4l2
1071         headers, causing gst-plugins-good's build to break. We don't need it
1072         right now, so just disable it.
1073
1074         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1075
1076 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1077
1078         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1079         https://bugs.webkit.org/show_bug.cgi?id=113535
1080
1081         Reviewed by Simon Hausmann.
1082
1083         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1084
1085         * qmake/mkspecs/features/features.prf:
1086
1087 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1088
1089         [Qt] Move logic of simple forwarding functions to TestRunner.
1090         https://bugs.webkit.org/show_bug.cgi?id=113863
1091
1092         Reviewed by Simon Hausmann.
1093
1094         * DumpRenderTree/qt/TestRunnerQt.cpp:
1095         (TestRunner::setTextDirection):
1096         (TestRunner::goBack):
1097         (TestRunner::evaluateScriptInIsolatedWorld):
1098         (TestRunner::addUserStyleSheet):
1099         * DumpRenderTree/qt/TestRunnerQt.h:
1100         (TestRunnerQt):
1101
1102 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1103
1104         [Qt] Disable media support using QuickTime if deployment target != SDK
1105
1106         We link to a single libWebKitSystemInterface static lib, so unless the
1107         deployment target matches the SDK let's not pretend like we'll be able
1108         to run on anything lower than the SDK version.
1109
1110         Reviewed by Simon Hausmann.
1111
1112         * qmake/mkspecs/features/features.prf:
1113
1114 2013-04-02  James Craig  <james@cookiecrook.com>
1115
1116         AXRoleDescripton for DL is "list"; should be "description list"
1117         https://bugs.webkit.org/show_bug.cgi?id=111665
1118
1119         Reviewed by Chris Fleizach.
1120
1121         Defining the role and description strings.
1122
1123         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1124
1125 2013-04-02  Roger Fong  <roger_fong@apple.com>
1126
1127         Unreviewed. Disable running tests on Win EWS queue.
1128
1129         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1130         (WinEWS):
1131
1132 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1133
1134         Disable running tests on the MAC WK2 EWS queue.
1135         
1136         Unreviewed.
1137         
1138         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1139         (MacWK2EWS):
1140
1141 2013-04-02  Julie Parent  <jparent@chromium.org>
1142
1143         Dashboard refactor: Move dashboard specific history related features to History.
1144         https://bugs.webkit.org/show_bug.cgi?id=113717
1145
1146         Reviewed by Ojan Vafai.
1147         
1148         Each dashboard now creates its own History object, with a custom
1149         configuration. This changes from just overriding global functions
1150         to passing in callbacks for generatePage, handleValidHashParameter,
1151         and handleQueryParameterChange. Same with passing in defaultStateValues
1152         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1153         variables.
1154         
1155         All functions related to these features are now (mostly) private
1156         function on History. 
1157         
1158         Loader no longer needs a loadingComplete callback, since it can just
1159         initialize the history object itself.
1160
1161         * TestResultServer/static-dashboards/aggregate_results.js:
1162         (handleValidHashParameter):
1163         * TestResultServer/static-dashboards/dashboard_base.js:
1164         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1165         (generatePage):
1166         (.switch.return):
1167         (handleQueryParameterChange):
1168         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1169         (resetGlobals):
1170         * TestResultServer/static-dashboards/history.js:
1171         (.):
1172         * TestResultServer/static-dashboards/loader.js:
1173         (.):
1174         * TestResultServer/static-dashboards/loader_unittests.js:
1175         * TestResultServer/static-dashboards/timeline_explorer.js:
1176         (generatePage):
1177         (initCurrentBuilderTestResults):
1178         * TestResultServer/static-dashboards/treemap.js:
1179         (generatePage):
1180         (.switch.return):
1181         (handleQueryParameterChange):
1182
1183 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1184
1185         Unreviewed, rolling out r147401.
1186         http://trac.webkit.org/changeset/147401
1187         https://bugs.webkit.org/show_bug.cgi?id=113767
1188
1189         The patch makes it extremely hard to set up the dependencies
1190         properly on the GTK builders (Requested by zdobersek on
1191         #webkit).
1192
1193         * gtk/jhbuild.modules:
1194
1195 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1196
1197         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1198         https://bugs.webkit.org/show_bug.cgi?id=113382
1199
1200         Reviewed by Gyuyoung Kim.
1201
1202         Do not show the empty tooltip box if the text is null.
1203
1204         * MiniBrowser/efl/main.c:
1205         (popup_menu_populate):
1206
1207 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         [GTK] Bump required versions of some dependencies
1210         https://bugs.webkit.org/show_bug.cgi?id=113282
1211
1212         Reviewed by Martin Robinson.
1213
1214         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1215
1216 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1217
1218         Unreviewed, rolling out r147319.
1219         http://trac.webkit.org/changeset/147319
1220         https://bugs.webkit.org/show_bug.cgi?id=113707
1221
1222         The unit test is still failing on the buildbot (Requested by
1223         zdobersek on #webkit).
1224
1225         * Scripts/run-gtk-tests:
1226         (TestRunner):
1227
1228 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1229
1230         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1231         https://bugs.webkit.org/show_bug.cgi?id=104779
1232
1233         Reviewed by Carlos Garcia Campos.
1234
1235         * Scripts/run-gtk-tests:
1236         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1237         passing in current trunk.
1238
1239 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1240
1241         Unreviewed, rolling out r147289.
1242         http://trac.webkit.org/changeset/147289
1243         https://bugs.webkit.org/show_bug.cgi?id=113678
1244
1245         broke Win7 (dbg) build (Requested by shinyak|gardener on
1246         #webkit).
1247
1248         * DumpRenderTree/DumpRenderTree.gypi:
1249         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1250         (WebTestRunner):
1251         (WebUserMediaClientMock):
1252         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1253         (WebTestRunner::WebUserMediaClientMock::taskList):
1254         * Scripts/webkitpy/style/checkers/cpp.py:
1255         (check_function_definition):
1256
1257 2013-03-31  Adam Barth  <abarth@webkit.org>
1258
1259         configure-svn-config.sh fails
1260         https://codereview.chromium.org/13392007/
1261
1262         Reviewed by Eric Seidel.
1263
1264         This script was trying to use "svn checkout" to dowload a file from
1265         svn.webkit.org, but "svn checkout" only works with directories.
1266         Instead, we should use "svn export".
1267
1268         * EWSTools/configure-svn-config.sh:
1269
1270 2013-03-31  Wei Jia  <wjia@chromium.org>
1271
1272         Allow WebUserMediaClientMock to be used by client
1273         https://bugs.webkit.org/show_bug.cgi?id=113633
1274
1275         Reviewed by Adam Barth.
1276
1277         Export WebUserMediaClientMock.
1278         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1279
1280         * DumpRenderTree/DumpRenderTree.gypi:
1281         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1282         (WebUserMediaClientMock):
1283         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1284         * Scripts/webkitpy/style/checkers/cpp.py:
1285         (check_function_definition):
1286
1287 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1288
1289         Expose FeatureObserver data to WebKit clients
1290         https://bugs.webkit.org/show_bug.cgi?id=113613
1291
1292         Reviewed by Sam Weinig.
1293
1294         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1295         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1296
1297 2013-03-29  Greg Hughes  <ghughes@apple.com>
1298
1299         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1300         https://bugs.webkit.org/show_bug.cgi?id=112276
1301
1302         Reviewed by Chris Fleizach.
1303
1304         Added support to test accessibility search predicates with multiple keys.  
1305
1306         * DumpRenderTree/AccessibilityUIElement.cpp:
1307         (uiElementForSearchPredicateCallback):
1308         * DumpRenderTree/AccessibilityUIElement.h:
1309         (AccessibilityUIElement):
1310         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1311         (AccessibilityUIElement::uiElementForSearchPredicate):
1312         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1313         (AccessibilityUIElement::uiElementForSearchPredicate):
1314         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1315         (AccessibilityUIElement::uiElementForSearchPredicate):
1316         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1317         (AccessibilityUIElement::uiElementForSearchPredicate):
1318         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1319         (AccessibilityUIElement::uiElementForSearchPredicate):
1320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1321         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1322         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1323         (AccessibilityUIElement):
1324         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1325         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1326         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1327         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1328         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1329
1330 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1331
1332         Fix a typo in r147147 to fix Mac EWS.
1333
1334         * Scripts/webkitpy/tool/commands/queues.py:
1335         (PatchProcessingQueue._new_port_name_from_old):
1336
1337 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1338
1339         [EFL] Build break with latest EFL libraries after r146265
1340         https://bugs.webkit.org/show_bug.cgi?id=113558
1341
1342         Unreviewed build fix.
1343
1344         * TestWebKitAPI/PlatformWebView.h:
1345         * WebKitTestRunner/PlatformWebView.h:
1346
1347 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1348
1349         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1350
1351         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1352         in libgcrypt build.
1353
1354 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1355
1356         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1357
1358         Unreviewed.
1359
1360         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1361         (MacEWS):
1362
1363 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1364
1365         Use the right OS name on Mac EWS instead of mac-future.
1366
1367         Rubber-stamped by Dirk Pranke.
1368
1369         * Scripts/webkitpy/tool/commands/queues.py:
1370         (PatchProcessingQueue._new_port_name_from_old):
1371         (PatchProcessingQueue.begin_work_queue):
1372         (PatchProcessingQueue._upload_results_archive_for_patch):
1373
1374 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1375
1376         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1377         https://bugs.webkit.org/show_bug.cgi?id=112546
1378
1379         Reviewed by Martin Robinson.
1380
1381         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1382         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1383
1384 2013-03-28  Ming Xie  <mxie@blackberry.com>
1385
1386         [BlackBerry] Committer Email Updates
1387         https://bugs.webkit.org/show_bug.cgi?id=113435
1388
1389         Reviewed by Rob Buis.
1390
1391         Add the @blackberry.com email address for all our BlackBerry
1392         WebKit committers. This is the first step for our email address
1393         migration.
1394
1395         * Scripts/webkitpy/common/config/committers.py:
1396
1397 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1398
1399         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1400         https://bugs.webkit.org/show_bug.cgi?id=113508
1401
1402         Reviewed by Martin Robinson.
1403
1404         Prevent the GStreamer plugin scanner to load system-wide
1405         plugins. Only the ones built in JHBuild should be loaded and used
1406         at runtime.
1407
1408         * efl/jhbuildrc:
1409         * gtk/jhbuildrc:
1410
1411 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1412
1413         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1414         https://bugs.webkit.org/show_bug.cgi?id=113386
1415
1416         Reviewed by Carlos Garcia Campos.
1417
1418         * Scripts/webkitdirs.pm:
1419         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1420         version to 3.0. Reflect this change so the builtDylibPathForName
1421         function doesn't fail to report the library as found.
1422
1423 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1424
1425         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1426         https://bugs.webkit.org/show_bug.cgi?id=113484
1427
1428         Unreviewed build fix.
1429
1430         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1431
1432         * TestWebKitAPI/CMakeLists.txt:
1433         * WebKitTestRunner/CMakeLists.txt:
1434
1435 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1436
1437         Revision for the internal jhbuild is too old
1438         https://bugs.webkit.org/show_bug.cgi?id=113324
1439
1440         Reviewed by Martin Robinson.
1441
1442         Update the minimum required version to a point where jhbuild won't
1443         fail installing packages when trying to remove a symlink to a directory.
1444
1445         * jhbuild/jhbuild-wrapper: Updated revision.
1446
1447 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1448
1449         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1450         https://bugs.webkit.org/show_bug.cgi?id=113203
1451
1452         Reviewed by Philippe Normand.
1453
1454         We build our libsoup without GNOME support. gst-plugins-good does separate
1455         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1456         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1457         build failures as the headers of those diverge. We do not use souphttpsrc, so
1458         disable it when building gst-plugins-good.
1459
1460         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1461
1462 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1463
1464         Build fix after r146852. Please another reference to the Lion leaks builder.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/config.json:
1467
1468 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1469
1470         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1471         https://bugs.webkit.org/show_bug.cgi?id=113421
1472
1473         Reviewed by Dirk Pranke.
1474
1475         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1476         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1477         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1478         in the GTK-specific TestExpectations files.
1479
1480         To avoid this only enable the warnings only when not using WKTR.
1481
1482         * Scripts/webkitpy/layout_tests/port/gtk.py:
1483         (GtkPort.warn_if_bug_missing_in_test_expectations):
1484
1485 2013-03-27  Antti Koivisto  <antti@apple.com>
1486
1487         Fix Zalan's email.
1488
1489         * Scripts/webkitpy/common/config/committers.py:
1490
1491 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1492
1493         master.cfg cleanup
1494         https://bugs.webkit.org/show_bug.cgi?id=113195
1495
1496         Reviewed by Ryosuke Niwa.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/config.json:
1499         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1500
1501 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1502
1503         master.cfg fine-tuning for Qt Mountain Lion Release bot
1504         https://bugs.webkit.org/show_bug.cgi?id=113191
1505
1506         Reviewed by Ryosuke Niwa.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/config.json:
1509           - Rename the slave due to its location change.
1510           - Update the platform of the slave.
1511         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1512         (RunQtAPITests): Enable running WK2 API tests on Qt.
1513         (RunQtAPITests.start):
1514         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1515         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1516
1517 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1518
1519         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1520         https://bugs.webkit.org/show_bug.cgi?id=113403
1521
1522         Reviewed by Kenneth Rohde Christiansen.
1523
1524         As of Evas 1.7.5, when Wayland is detected on the system, support for
1525         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1526         The code, however, seems to depend on a few other flags which must be
1527         explicitly enabled.
1528
1529         If those additional GL-related options are passed, we end up
1530         having issues on the WebKit side, so disable Wayland support for
1531         now.
1532
1533         * efl/jhbuild.modules:
1534
1535 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1536
1537         Unreviewed, rolling out r146864.
1538         http://trac.webkit.org/changeset/146864
1539         https://bugs.webkit.org/show_bug.cgi?id=113391
1540
1541         causes crashes on Wk2 EFL release bot (Requested by drott on
1542         #webkit).
1543
1544         * Scripts/webkitperl/FeatureList.pm:
1545
1546 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1547
1548         [jhbuild] Correctly specify an alternate number of make jobs.
1549         https://bugs.webkit.org/show_bug.cgi?id=113396
1550
1551         Reviewed by Philippe Normand.
1552
1553         So far, we were using the `MAKEFLAGS' environment variable to pass the
1554         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1555         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1556
1557         We now behave more closely to the rest of the WebKit tools by first
1558         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1559         not set, just letting jhbuild itself figure out how many jobs to use.
1560
1561         * efl/jhbuildrc:
1562         * gtk/jhbuildrc:
1563
1564 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1565
1566         [Qt] Remove Qt specific WorkQueueItem definitions.
1567         https://bugs.webkit.org/show_bug.cgi?id=112891
1568
1569         This patch is preparation work for removing
1570         WorkQueue related code from TestRunnerQt and
1571         replacing it with generic TestRunner code.
1572
1573         Reviewed by Benjamin Poulain.
1574
1575         * DumpRenderTree/qt/TestRunnerQt.cpp:
1576         (TestRunnerQt::queueBackNavigation):
1577         (TestRunnerQt::queueForwardNavigation):
1578         (TestRunnerQt::queueLoadHTMLString):
1579         (TestRunnerQt::queueReload):
1580         (TestRunnerQt::queueLoadingScript):
1581         (TestRunnerQt::queueNonLoadingScript):
1582         (TestRunner::queueLoad):
1583         * DumpRenderTree/qt/TestRunnerQt.h:
1584         (TestRunnerQt):
1585         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1586         (LoadItem::invoke):
1587         (LoadHTMLStringItem::invoke):
1588         (LoadAlternateHTMLStringItem::invoke):
1589         (ReloadItem::invoke):
1590         (ScriptItem::invoke):
1591         (BackForwardItem::invoke):
1592         * DumpRenderTree/qt/WorkQueueItemQt.h:
1593         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1594         (LoadAlternateHTMLStringItem):
1595
1596 2013-03-26  Julie Parent  <jparent@chromium.org>
1597
1598         Flakiness dashboard: simplify logic around which tests to show.
1599         https://bugs.webkit.org/show_bug.cgi?id=113250
1600
1601         Reviewed by Ojan Vafai.
1602         
1603         The different filters for showing results are only used for layout
1604         tests, otherwise, we show everything.
1605         
1606         Change the defaults to false (what layout tests used), and only
1607         look at the values when viewing layout tests.
1608
1609         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1610         (htmlForTestsWithExpectationsButNoFailures):
1611         (shouldHideTest):
1612
1613 2013-03-26  Isaac Levy  <ilevy@google.com>
1614
1615         Update bots on test-results.appspot
1616         https://bugs.webkit.org/show_bug.cgi?id=113333
1617
1618         Reviewed by Ojan Vafai.
1619
1620         * TestResultServer/static-dashboards/builders.jsonp:
1621
1622 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1623
1624         Unreviewed GTK gardening.
1625
1626         * Scripts/run-gtk-tests:
1627         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1628
1629 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1630
1631         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1632         https://bugs.webkit.org/show_bug.cgi?id=113287
1633
1634         Reviewed by Jocelyn Turcotte.
1635
1636         * Scripts/run-qtwebkit-tests:
1637         (Options.__init__):
1638
1639 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1640
1641         [EFL] Enable IndexedDB by default
1642         https://bugs.webkit.org/show_bug.cgi?id=107248
1643
1644         Reviewed by Laszlo Gombos.
1645
1646         * Scripts/webkitperl/FeatureList.pm:
1647         Enable IndexedDB by default on EFL.
1648
1649 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1650
1651         Sheriffbot should explain rollout failures in a human readable form.
1652         https://bugs.webkit.org/show_bug.cgi?id=107092
1653
1654         Reviewed by Ryosuke Niwa.
1655
1656         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1657
1658         * Scripts/webkitpy/tool/bot/irc_command.py:
1659         (Rollout._check_diff_failure):
1660         (Rollout.execute):
1661         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1662         (IRCCommandTest.test_rollout):
1663
1664 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1665
1666         Unreviewed GTK gardening.
1667
1668         * Scripts/run-gtk-tests:
1669         (TestRunner): Skipping a failing unit test after r146518.
1670
1671 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1672
1673         Remove Lion leaks builder
1674         https://bugs.webkit.org/show_bug.cgi?id=113252
1675
1676         Reviewed by Andreas Kling.
1677
1678         Removed.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/config.json:
1681
1682 2013-03-25  Kent Tamura  <tkent@chromium.org>
1683
1684         Rename ENABLE_INPUT_TYPE_DATETIME
1685         https://bugs.webkit.org/show_bug.cgi?id=113254
1686
1687         Reviewed by Kentaro Hara.
1688
1689         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1690         Actually I'd like to remove the code, but we shouldn't remove it yet
1691         because we shipped products with it on some platforms.
1692
1693         * Scripts/webkitperl/FeatureList.pm:
1694         * qmake/mkspecs/features/features.pri:
1695
1696 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1697
1698         Remove one more line that was intended to be removed in r146657.
1699
1700         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1701         (summarize_results):
1702
1703 2013-03-25  Roger Fong  <roger_fong@apple.com>
1704
1705         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1706         Re-enable WinEWS tests.
1707
1708         * Scripts/webkitpy/common/config/ports.py:
1709         (WinPort.run_bindings_tests_command):
1710         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1711         (WinEWS):
1712
1713 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1714
1715         Unreviewed, rolling out r146793.
1716         http://trac.webkit.org/changeset/146793
1717         https://bugs.webkit.org/show_bug.cgi?id=113248
1718
1719         Fix did not work (Requested by rfong on #webkit).
1720
1721         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1722         (WinEWS):
1723
1724 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         REGRESSION(r146657): Test failures reported incorrectly
1727         https://bugs.webkit.org/show_bug.cgi?id=113223
1728
1729         Reviewed by Dirk Pranke.
1730
1731         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1732
1733         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1734         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1735
1736         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1737         (Manager.run):
1738
1739         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1740         (RunDetails.__init__):
1741         (summarize_results): Remove the line I intended to remove in r146657.
1742
1743         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1744         (logging_run): Return details instead of the exit code.
1745         (run_and_capture): Ditto.
1746
1747         (RunTest.test_full_results_html):
1748         (RunTest.test_hung_thread):
1749         (RunTest.test_no_tests_found):
1750         (RunTest.test_no_tests_found_2):
1751         (RunTest.test_repeat_each_iterations_num_tests):
1752         (RunTest.test_run_singly_actually_runs_tests):
1753         (RunTest.test_test_list):
1754         (RunTest.test_missing_and_unexpected_results):
1755         (RunTest.test_pixel_test_directories):
1756         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1757         (RunTest.test_crash_with_stderr):
1758         (RunTest.test_no_image_failure_with_image_diff):
1759         (RunTest.test_crash_log):
1760         (RunTest.test_exit_after_n_failures_upload):
1761         (RunTest.test_results_directory_absolute):
1762         (RunTest.test_results_directory_relative):
1763         (RunTest.test_retrying_and_flaky_tests):
1764         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1765         (RunTest.test_retrying_uses_retries_directory):
1766         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1767         (RunTest.test_output_diffs):
1768         (EndToEndTest.test_reftest_with_two_notrefs):
1769         (RebaselineTest.test_reset_results):
1770         (RebaselineTest.test_missing_results):
1771         (RebaselineTest.test_new_baseline):
1772
1773         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1774         (BuildBotPrinter.print_results):
1775         (BuildBotPrinter.print_unexpected_results):
1776         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1777         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1778
1779 2013-03-25  Julie Parent  <jparent@chromium.org>
1780
1781         Dashboard refactor: Move cross dashboard history related code into history.js.
1782         https://bugs.webkit.org/show_bug.cgi?id=113104
1783
1784         Reviewed by Ojan Vafai.
1785
1786         All functions relating to cross dashboard behavior move from being
1787         globals to methods on the history.History object. Names stay the same,
1788         except many are made private, ones that should have been constants now
1789         are, and the long standing TODO to change "currentState" to 
1790         dashboardSpecificState is done.
1791         
1792         We now create a global history object in dashboard_base, as an 
1793         intermediate measure.  Once the dashboard specific code is
1794         added to history, each DB will need to create its own, and this
1795         global will be eliminated.
1796         
1797         * TestResultServer/static-dashboards/aggregate_results.js:
1798         (handleValidHashParameter):
1799         (htmlForBuilder):
1800         (rawValuesHTML):
1801         * TestResultServer/static-dashboards/dashboard_base.js:
1802         (parseDashboardSpecificParameters):
1803         (defaultValue):
1804         (currentBuilderGroupCategory):
1805         (currentBuilderGroupName):
1806         (handleLocationChange):
1807         (expectationsMap):
1808         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1809         (generatePage):
1810         (.switch.return):
1811         (platformAndBuildType):
1812         (individualTests):
1813         (substringList):
1814         (processMissingAndExtraExpectations):
1815         (pathToFailureLog):
1816         (showPopupForBuild):
1817         (htmlForTestsWithExpectationsButNoFailures):
1818         (shouldHideTest):
1819         (isCrossBuilderView):
1820         (tableHeaders):
1821         (htmlForSingleTestRow):
1822         (htmlForTableColumnHeader):
1823         (generatePageForExpectationsUpdate):
1824         (handleUpdate):
1825         (nextUpdate):
1826         (setUpdateIndex):
1827         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1828         (.appendExpectationsItem):
1829         (loadExpectations):
1830         (.dummyNode.onload):
1831         (loadExpectationsLayoutTests):
1832         (appendExpectations):
1833         (htmlForNavBar):
1834         (checkBoxToToggleState):
1835         (linkHTMLToToggleState):
1836         (generatePageForBuilder):
1837         (isInvalidKeyForCrossBuilderView):
1838         (handleQueryParameterChange):
1839         (showLegend):
1840         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1841         (resetGlobals):
1842         (test):
1843         * TestResultServer/static-dashboards/history.js:
1844         (.):
1845         * TestResultServer/static-dashboards/history_unittests.js:
1846         * TestResultServer/static-dashboards/loader.js:
1847         (.):
1848         * TestResultServer/static-dashboards/loader_unittests.js:
1849         * TestResultServer/static-dashboards/timeline_explorer.js:
1850         (generatePage):
1851         (initCurrentBuilderTestResults):
1852         (selectBuild):
1853         (showResultsDelta):
1854         * TestResultServer/static-dashboards/treemap.js:
1855         (generatePage):
1856         (.switch.return):
1857         (handleFocus):
1858         * TestResultServer/static-dashboards/ui.js:
1859
1860 2013-03-25  Roger Fong  <roger_fong@apple.com>
1861
1862         Unreviewed. Enable WinEWS tests again.
1863
1864         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1865         (WinEWS):
1866
1867 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1868
1869         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1870         https://bugs.webkit.org/show_bug.cgi?id=112166
1871
1872         HarfBuzz 0.9.14 merged my patch for icu detection without
1873         pkg-config files, as needed by for example Ubuntu 12.04.
1874         This obsoletes our local workaround. Removed it for GTK and EFL.
1875
1876         Reviewed by Martin Robinson.
1877
1878         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1879         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1880         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1881         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1882
1883 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1884
1885         Unreviewed.  Move self from contributor to committer list.
1886
1887         * Scripts/webkitpy/common/config/committers.py:
1888
1889 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1890
1891         EWS should use a human readable port name when uploading layout test archives
1892         https://bugs.webkit.org/show_bug.cgi?id=113099
1893
1894         Reviewed by Dirk Pranke.
1895
1896         Use new port's object's name() method to report human readable port names.
1897         This will also help us resolving the bug to apply layout test results posted by EWS.
1898
1899         * Scripts/webkitpy/tool/bot/botinfo.py:
1900         (BotInfo.__init__): Take port's name.
1901         (BotInfo.summary_text):
1902
1903         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1904         (BotInfoTest.test_summary_text):
1905
1906         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1907         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1908
1909         * Scripts/webkitpy/tool/commands/queues.py:
1910         (PatchProcessingQueue.__init__): Initialize self._port.
1911         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1912         and use that for the attachment filename and the comment posted.
1913
1914         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1915         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1916         "mac-snowleopard" as expected for TestPort.
1917
1918 2013-03-22  Roger Fong  <roger_fong@apple.com>
1919
1920         Unreviewed. Turn off EWS test on Win again.
1921         The battle continues.
1922
1923         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1924         (WinEWS):
1925
1926 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1927
1928         NRWT: Enable pixel tests when retrying tests
1929         https://bugs.webkit.org/show_bug.cgi?id=112898
1930
1931         Reviewed by Dirk Pranke.
1932
1933         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1934         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1935         if we've forced pixel tests in the retry.
1936         (Manager._run_tests):
1937         (Manager._clean_up_run): Fixed the capitalizations.
1938         (Manager._force_pixel_tests_if_needed): Added.
1939
1940         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1941         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1942         'image_diff_percent' if it doesn't already exist.
1943
1944         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1945         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1946         treat this as a regular regression instead of a flakiness.
1947
1948         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1949         run had image diffs.
1950
1951         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1952         (summarized_results):
1953
1954         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1955         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1956         Also removed some dead code.
1957
1958         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1959         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1960         is set and pixel_tests_enabled is set to false.
1961         (EndToEndTest.test_reftest_with_two_notrefs):
1962
1963 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1964
1965         Make it possible to run layout tests on Retina MBP
1966         https://bugs.webkit.org/show_bug.cgi?id=93673
1967
1968         Reviewed by Ryosuke Niwa.
1969
1970         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1971         windows on 2x machines still run at 1x.
1972
1973         * DumpRenderTree/mac/DumpRenderTree.mm:
1974         (createWebViewAndOffscreenWindow):
1975         Reset the window resolution to 1x on creation.
1976         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1977         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1978         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1979         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1980         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1981         (WTR::PlatformWebView::PlatformWebView):
1982         Add NSWindow details, reset the window resolution to 1x on creation.
1983
1984 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1985
1986         Leak bots shouldn't build
1987         https://bugs.webkit.org/show_bug.cgi?id=112774
1988
1989         Reviewed by Simon Fraser.
1990
1991         Since leak bots use regular debug builds, there is no need to build on these bots.
1992         Simply downloading builds will dramatically improve the cycle time of these bots.
1993
1994         * BuildSlaveSupport/build.webkit.org-config/config.json:
1995         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1996         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1997         TestFactory instead of BuildAndTestFactory.
1998
1999 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2000
2001         [Qt] Fix the TestWebKitAPI build
2002         https://bugs.webkit.org/show_bug.cgi?id=113044
2003
2004         Reviewed by Tor Arne Vestbø.
2005
2006         The generate-forwarding-headers script would only be run
2007         after the targets in InjectedBundle.pri since the second
2008         addStrictSubdirOrderBetween call in
2009         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2010         the derived_sources -> injected_bundle order in SUBDIRS.
2011
2012         Fix it by only moving the dependent target at the end of
2013         SUBDIRS, don't touch its dependency.
2014
2015         * qmake/mkspecs/features/functions.prf:
2016
2017 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2018
2019         [EFL][WK2] View is not focused when fullscreen mode toggled
2020         https://bugs.webkit.org/show_bug.cgi?id=113009
2021
2022         Reviewed by Laszlo Gombos.
2023
2024         Set focus on view when fullscreen mode enabled/disabled
2025         by FullScreen API.
2026
2027         * MiniBrowser/efl/main.c:
2028         (on_fullscreen_accept):
2029         (on_fullscreen_deny):
2030
2031 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2032
2033         nrwt is no longer saving retry results in the retries/ subdirectory
2034         https://bugs.webkit.org/show_bug.cgi?id=112995
2035
2036         Reviewed by Ojan Vafai.
2037
2038         I think this has been broken a long time, unfortunately. This
2039         patch should fix that.
2040
2041         In order to do so, I had to pass the directory to use from
2042         the Worker object through the SingleTestWriter to the
2043         TestResultWriter. While I was plumbing that through, I rationalized
2044         the order of the parameter arguments a bit ...
2045
2046         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2047         (Worker._run_single_test):
2048         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2049         (run_single_test):
2050         (SingleTestRunner.__init__):
2051         (SingleTestRunner._run_compare_test):
2052         (SingleTestRunner._run_rebaseline):
2053         (SingleTestRunner._run_reftest):
2054         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2055         (write_test_result):
2056         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2057         (TestResultWriterTest.test_reftest_diff_image):
2058         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2059         (RunTest.test_retrying_uses_retries_directory):
2060
2061 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2062
2063         JSC profiler should have an at-a-glance report of the success of DFG optimization
2064         https://bugs.webkit.org/show_bug.cgi?id=112988
2065
2066         Reviewed by Geoffrey Garen.
2067
2068         * Scripts/display-profiler-output:
2069
2070 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2071
2072         [chromium] Linux ASAN WebKit canary is running out of memory
2073         https://bugs.webkit.org/show_bug.cgi?id=112978
2074
2075         Reviewed by Tony Chang.
2076
2077         Running the AddressSanitizer on a crash takes a lot of
2078         memory, so we should serialize access to it to avoid running
2079         out of memory on a machine.
2080
2081         * Scripts/webkitpy/layout_tests/port/chromium.py:
2082         (ChromiumPort._get_crash_log):
2083         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2084         (HttpLock.__init__):
2085         (HttpLock.wait_for_httpd_lock):
2086
2087 2013-03-21  Min Qin  <qinmin@chromium.org>
2088
2089         Cleanup android media layout test code
2090         https://bugs.webkit.org/show_bug.cgi?id=112944
2091
2092         Reviewed by Adam Barth.
2093
2094         Chromium change: https://codereview.chromium.org/12892010/
2095         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2096         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2097         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2098         Instead, we should switch to use content shell for layout tests.
2099
2100         * DumpRenderTree/chromium/TestShell.cpp:
2101         (TestShell::resetTestController):
2102
2103 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2104
2105         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2106         https://bugs.webkit.org/show_bug.cgi?id=112953
2107
2108         Reviewed by Tony Chang.
2109
2110         When I created the DumpRenderTree_resources target in r144863 I
2111         forgot to declare the needed dependencies on the other resource
2112         targets. Due to a quirk of ordering, this appears to have been fine
2113         w/ ninja but not w/ Xcode (which is still being used on the chromium
2114         mac valgrind bots). Declaring the dependencies fixes the build
2115         failures.
2116
2117         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2118
2119 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2120
2121         [WinCairo] Correct assert in Empty BitmapImage Test.
2122         https://bugs.webkit.org/show_bug.cgi?id=112934
2123
2124         Reviewed by Tim Horton.
2125
2126         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2127         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2128         to avoid ref counting assertion when leaving test scope.
2129
2130 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2131
2132         [GTK] generate-feature-defines-files is incompatible with Python3
2133         https://bugs.webkit.org/show_bug.cgi?id=112956
2134
2135         Reviewed by Martin Robinson.
2136
2137         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2138         method on the dictionary objects when iterating through said dictionaries.
2139
2140         * gtk/generate-feature-defines-files:
2141         (write_feature_defines_header):
2142         (write_flattened_feature_defines_file):
2143
2144 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2145
2146         kill-old-processes spits out error messages on Mac
2147         https://bugs.webkit.org/show_bug.cgi?id=112878
2148
2149         Reviewed by Jessie Berlin.
2150
2151         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2152         included in the list of options grep --help shows.
2153
2154         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2155
2156         * BuildSlaveSupport/kill-old-processes:
2157         (main):
2158
2159 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2160
2161         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2162         https://bugs.webkit.org/show_bug.cgi?id=112597
2163
2164         Reviewed by Xan Lopez.
2165
2166         These were introduced for the Chromium port in r105295. We need
2167         dummy implementations in order to compile the BlackBerry port.
2168
2169         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2170         (AccessibilityUIElement::scrollToMakeVisible):
2171         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2172         (AccessibilityUIElement::scrollToGlobalPoint):
2173
2174 2013-03-21  Roger Fong  <roger_fong@apple.com>
2175
2176         Re-enable WinEWS tests following r146376.
2177
2178         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2179         (WinEWS):
2180
2181 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2182
2183         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2184
2185         * Scripts/webkitpy/common/config/committers.py:
2186
2187 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2188
2189         [GTK] Missing atk in install-dependencies script
2190         https://bugs.webkit.org/show_bug.cgi?id=112272
2191
2192         Reviewed by Gustavo Noronha Silva.
2193
2194         * gtk/install-dependencies: Add missing atk dependency.
2195
2196 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2197
2198         [GTK] Missing backslash in install-dependencies script
2199         https://bugs.webkit.org/show_bug.cgi?id=112907
2200
2201         Reviewed by Philippe Normand.
2202
2203         * gtk/install-dependencies: Add missing backslash to dependencies
2204         list.
2205
2206 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         EWS bots have stopped uploading results to bugzilla
2209         https://bugs.webkit.org/show_bug.cgi?id=101091
2210
2211         Reviewed by Adam Barth.
2212
2213         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2214         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2215         this relative file path resoled to a file inside a non-existent directory for "zip".
2216
2217         Fixed the bug by resolving both test results directory and zip archive paths in
2218         LayoutTestResultsReader.archive.
2219
2220         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2221         in the future.
2222
2223         * Scripts/webkitpy/common/system/filesystem_mock.py:
2224         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2225
2226         * Scripts/webkitpy/common/system/workspace.py:
2227         (Workspace.create_zip): Log the source path when "zip" failed.
2228
2229         * Scripts/webkitpy/common/system/workspace_mock.py:
2230         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2231
2232         * Scripts/webkitpy/common/system/workspace_unittest.py:
2233         (WorkspaceTest.test_create_zip_exception): Test that.
2234
2235         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2236         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2237         This is the actual bug fix.
2238
2239         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2240         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2241
2242 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2243
2244         [chromium] move WebThemeEngine implementations to TestRunner library
2245         https://bugs.webkit.org/show_bug.cgi?id=112751
2246
2247         Reviewed by Adam Barth.
2248
2249         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2250         * DumpRenderTree/DumpRenderTree.gypi:
2251         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2252         (WebKit):
2253         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2254         (WebTestRunner::TestInterfaces::themeEngine):
2255         (WebTestRunner):
2256         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2257         (WebKit):
2258         (TestInterfaces):
2259         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2260         (WebTestRunner::WebTestInterfaces::themeEngine):
2261         (WebTestRunner):
2262         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2263         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2264         (WebTestRunner):
2265         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2266         (WebTestRunner::WebTestThemeControlWin::box):
2267         (WebTestRunner::WebTestThemeControlWin::line):
2268         (WebTestRunner::WebTestThemeControlWin::triangle):
2269         (WebTestRunner::WebTestThemeControlWin::roundRect):
2270         (WebTestRunner::WebTestThemeControlWin::oval):
2271         (WebTestRunner::WebTestThemeControlWin::circle):
2272         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2273         (WebTestRunner::WebTestThemeControlWin::markState):
2274         (WebTestRunner::WebTestThemeControlWin::draw):
2275         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2276         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2277         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2278         (WebTestRunner):
2279         (WebTestThemeControlWin):
2280         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2281         (WebTestRunner):
2282         (WebTestThemeEngineMac):
2283         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2284         (+[FakeActiveWindow alwaysActiveWindow]):
2285         (+[FakeActiveWindow alwaysInactiveWindow]):
2286         (-[FakeActiveWindow initWithActiveControls:]):
2287         (-[FakeActiveWindow _hasActiveControls]):
2288         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2289         (WebTestRunner):
2290         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2291         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2292         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2293         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2294         (WebTestRunner):
2295         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2296         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2297         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2298         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2299         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2300         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2301         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2302         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2303         (WebTestRunner::WebTestThemeEngineWin::getSize):
2304         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2305         (WebTestRunner):
2306         (WebTestThemeEngineWin):
2307         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2308         * DumpRenderTree/chromium/TestShell.cpp:
2309         (TestShell::initialize):
2310         * DumpRenderTree/chromium/TestShell.h:
2311         (WebKit):
2312         * DumpRenderTree/chromium/TestShellMac.mm:
2313         (platformInit):
2314         * DumpRenderTree/chromium/TestShellWin.cpp:
2315         (platformInit):
2316         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2317
2318 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2319
2320         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2321
2322         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2323         New property sheet that does not link against CoreFoundation and
2324         CFNetwork.
2325         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2326         Use new TestWebKitAPICommonWinCairo property sheet.
2327         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2328         Ditto.
2329
2330 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2331
2332         [WinCairo] Unreviewed build fix for VS2010.
2333
2334         Had to add WinCairo-specific property sheets to deal with some
2335         library and path differences with the main Apple port.
2336
2337         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2338         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2339         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2340         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2341         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2342         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2343
2344 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2345
2346         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2347         https://bugs.webkit.org/show_bug.cgi?id=112849
2348
2349         Reviewed by Sam Weinig.
2350
2351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2353         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2354
2355 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2356
2357         [WinCairo] Build WebKit Tools under VS2010
2358         https://bugs.webkit.org/show_bug.cgi?id=112821
2359
2360         Reviewed by Tim Horton.
2361
2362         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2363         Add WinCairo-specific build target.
2364         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2365         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2366         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2367         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2368         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2369         Add WinCairo-specific build target.
2370         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2371         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2372         Add WinCairo-specific build target.
2373         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2374         WinCairo-specific build target.
2375         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2376         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2377         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2378         specific build target.
2379         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2380         WinCairo-specific build target.
2381         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2382         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2383         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2384
2385 2013-03-20  Roger Fong  <roger_fong@apple.com>
2386
2387         API test gardening AppleWin port.
2388
2389         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2390
2391         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2392         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2393
2394 2013-03-20  Roger Fong  <roger_fong@apple.com>
2395
2396         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2397
2398         * EWSTools/start-queue-win.sh:
2399
2400 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2401
2402         Unreviewed, add myself to committers.py.
2403
2404 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2405
2406         Unreviewed. Adding another email for me.
2407
2408         * Scripts/webkitpy/common/config/committers.py:
2409
2410 2013-03-20  Justin Novosad  <junov@google.com>
2411
2412         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2413         https://bugs.webkit.org/show_bug.cgi?id=112605
2414
2415         Reviewed by James Robinson.
2416
2417         Deleting all the code that was used for propagating and supporting
2418         the Chromium setting for disabling deferred 2d canvas rendering.
2419
2420         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2421         (main):
2422         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2423         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2424         (WebTestRunner::WebPreferences::reset):
2425         (WebTestRunner::WebPreferences::applyTo):
2426         * DumpRenderTree/chromium/TestShell.cpp:
2427         (TestShell::TestShell):
2428         (TestShell::resetWebSettings):
2429         (TestShell::runFileTest):
2430         * DumpRenderTree/chromium/TestShell.h:
2431         (TestShell):
2432
2433 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2434
2435         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2436         https://bugs.webkit.org/show_bug.cgi?id=112699.
2437
2438         Reviewed by Adam Barth.
2439
2440         * Scripts/webkitpy/layout_tests/port/qt.py:
2441         (QtPort._search_paths):
2442         (QtPort._port_specific_expectations_files):
2443         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2444         (QtPortTest):
2445         (QtPortTest._assert_search_path):
2446         (QtPortTest._assert_expectations_files):
2447
2448 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2449
2450         [Qt] Enable kerning by default
2451         https://bugs.webkit.org/show_bug.cgi?id=112704
2452
2453         Reviewed by Jocelyn Turcotte.
2454
2455         Disable kerning by default, since some reference test expectations
2456         expect kerning to be default off.
2457
2458         * DumpRenderTree/qt/TestRunnerQt.cpp:
2459         (TestRunnerQt::reset):
2460         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2461         (WTR::activateFonts):
2462
2463 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2464
2465         [Qt] Remove empty function stubs from TestRunnerQt.
2466         https://bugs.webkit.org/show_bug.cgi?id=112799
2467
2468         We are reducing the code in TestRunnerQt step by step,
2469         in order to finally replace all of it with the generic
2470         TestRunner implementation.
2471         This patch removes several simple function stubs that
2472         currently do not implement any actual functionality.
2473
2474         Reviewed by Kenneth Rohde Christiansen.
2475
2476         * DumpRenderTree/qt/TestRunnerQt.cpp:
2477         * DumpRenderTree/qt/TestRunnerQt.h:
2478         (TestRunnerQt):
2479
2480 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2481
2482         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2483         https://bugs.webkit.org/show_bug.cgi?id=112687
2484
2485         Reviewed by Kenneth Rohde Christiansen.
2486
2487         Hide the SearchBar by default on window creation.
2488
2489         * MiniBrowser/efl/main.c:
2490         (window_create):
2491
2492 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2493
2494         Unreviewed, rolling out r146304.
2495         http://trac.webkit.org/changeset/146304
2496         https://bugs.webkit.org/show_bug.cgi?id=112788
2497
2498         to many expectations to update (Requested by antonm on
2499         #webkit).
2500
2501         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2502         * DumpRenderTree/DumpRenderTree.gypi:
2503         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2504         (WebKit):
2505         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2506         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2507         (TestInterfaces):
2508         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2509         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2510         * DumpRenderTree/chromium/TestShell.cpp:
2511         (TestShell::initialize):
2512         * DumpRenderTree/chromium/TestShell.h:
2513         (WebKit):
2514         * DumpRenderTree/chromium/TestShellMac.mm:
2515         (platformInit):
2516         * DumpRenderTree/chromium/TestShellWin.cpp:
2517         (platformInit):
2518         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2519         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2520         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2521         (WebThemeControlDRTWin::box):
2522         (WebThemeControlDRTWin::line):
2523         (WebThemeControlDRTWin::triangle):
2524         (WebThemeControlDRTWin::roundRect):
2525         (WebThemeControlDRTWin::oval):
2526         (WebThemeControlDRTWin::circle):
2527         (WebThemeControlDRTWin::nestedBoxes):
2528         (WebThemeControlDRTWin::markState):
2529         (WebThemeControlDRTWin::draw):
2530         (WebThemeControlDRTWin::drawTextField):
2531         (WebThemeControlDRTWin::drawProgressBar):
2532         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2533         (WebThemeControlDRTWin):
2534         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2535         (WebThemeEngineDRTMac):
2536         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2537         (+[FakeActiveWindow alwaysActiveWindow]):
2538         (+[FakeActiveWindow alwaysInactiveWindow]):
2539         (-[FakeActiveWindow initWithActiveControls:]):
2540         (-[FakeActiveWindow _hasActiveControls]):
2541         (WebThemeEngineDRTMac::paintScrollbarThumb):
2542         (stateToHIEnableState):
2543         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2544         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2545         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2546         (webRectToSkIRect):
2547         (drawControl):
2548         (drawTextField):
2549         (drawProgressBar):
2550         (WebThemeEngineDRTWin::paintButton):
2551         (WebThemeEngineDRTWin::paintMenuList):
2552         (WebThemeEngineDRTWin::paintScrollbarArrow):
2553         (WebThemeEngineDRTWin::paintScrollbarThumb):
2554         (WebThemeEngineDRTWin::paintScrollbarTrack):
2555         (WebThemeEngineDRTWin::paintSpinButton):
2556         (WebThemeEngineDRTWin::paintTextField):
2557         (WebThemeEngineDRTWin::paintTrackbar):
2558         (WebThemeEngineDRTWin::paintProgressBar):
2559         (WebThemeEngineDRTWin::getSize):
2560         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2561         (WebThemeEngineDRTWin):
2562         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2563
2564 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2565
2566         [Qt] Support -webkit-font-smoothing
2567         https://bugs.webkit.org/show_bug.cgi?id=106009
2568
2569         Reviewed by Jocelyn Turcotte.
2570
2571         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2572
2573         * DumpRenderTree/qt/TestRunnerQt.cpp:
2574         (TestRunnerQt::reset):
2575
2576 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2577
2578         [GTK] accessibility/aria-scrollbar-role.html is failing
2579         https://bugs.webkit.org/show_bug.cgi?id=98358
2580
2581         Reviewed by Martin Robinson.
2582
2583         Adds support for checking accessibility object's orientation.
2584         Orientation is checked by retrieving proper state of accessibility object.
2585
2586         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2587         (checkElementState):
2588         (AccessibilityUIElement::orientation):
2589         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2590         (WTR::AccessibilityUIElement::orientation):
2591
2592 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2593
2594         [chromium] move WebThemeEngine implementations to TestRunner library
2595         https://bugs.webkit.org/show_bug.cgi?id=112751
2596
2597         Reviewed by Adam Barth.
2598
2599         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2600         * DumpRenderTree/DumpRenderTree.gypi:
2601         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2602         (WebKit):
2603         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2604         (WebTestRunner::TestInterfaces::themeEngine):
2605         (WebTestRunner):
2606         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2607         (WebKit):
2608         (TestInterfaces):
2609         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2610         (WebTestRunner::WebTestInterfaces::themeEngine):
2611         (WebTestRunner):
2612         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2613         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2614         (WebTestRunner):
2615         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2616         (WebTestRunner::WebTestThemeControlWin::box):
2617         (WebTestRunner::WebTestThemeControlWin::line):
2618         (WebTestRunner::WebTestThemeControlWin::triangle):
2619         (WebTestRunner::WebTestThemeControlWin::roundRect):
2620         (WebTestRunner::WebTestThemeControlWin::oval):
2621         (WebTestRunner::WebTestThemeControlWin::circle):
2622         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2623         (WebTestRunner::WebTestThemeControlWin::markState):
2624         (WebTestRunner::WebTestThemeControlWin::draw):
2625         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2626         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2627         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2628         (WebTestRunner):
2629         (WebTestThemeControlWin):
2630         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2631         (WebTestRunner):
2632         (WebTestThemeEngineMac):
2633         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2634         (+[FakeActiveWindow alwaysActiveWindow]):
2635         (+[FakeActiveWindow alwaysInactiveWindow]):
2636         (-[FakeActiveWindow initWithActiveControls:]):
2637         (-[FakeActiveWindow _hasActiveControls]):
2638         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2639         (WebTestRunner):
2640         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2641         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2642         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2643         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2644         (WebTestRunner):
2645         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2646         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2647         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2648         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2649         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2650         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2651         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2652         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2653         (WebTestRunner::WebTestThemeEngineWin::getSize):
2654         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2655         (WebTestRunner):
2656         (WebTestThemeEngineWin):
2657         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2658         * DumpRenderTree/chromium/TestShell.cpp:
2659         (TestShell::initialize):
2660         * DumpRenderTree/chromium/TestShell.h:
2661         (WebKit):
2662         * DumpRenderTree/chromium/TestShellMac.mm:
2663         (platformInit):
2664         * DumpRenderTree/chromium/TestShellWin.cpp:
2665         (platformInit):
2666         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2667
2668 2013-03-19  Tony Chang  <tony@chromium.org>
2669
2670         Move testRunner.setTouchDragDropEnabled to internals.settings
2671         https://bugs.webkit.org/show_bug.cgi?id=112739
2672
2673         Reviewed by Adam Barth.
2674
2675         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2676         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2677         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2678         (TestRunner): Remove unnecessary code.
2679         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2680         (WebTestRunner::WebPreferences::reset):
2681         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2682
2683 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2684
2685         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2686         https://bugs.webkit.org/show_bug.cgi?id=112754
2687
2688         Reviewed by Darin Fisher.
2689
2690         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2691         now that it's always defined.
2692
2693         * DumpRenderTree/chromium/WebViewHost.cpp:
2694         * DumpRenderTree/chromium/WebViewHost.h:
2695         (WebViewHost):
2696
2697 2013-03-19  Kenneth Russell  <kbr@google.com>
2698
2699         Unreviewed, rolling out r146290.
2700         http://trac.webkit.org/changeset/146290
2701         https://bugs.webkit.org/show_bug.cgi?id=112751
2702
2703         Broke Chromium Mac build.
2704
2705         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2706         * DumpRenderTree/DumpRenderTree.gypi:
2707         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2708         (WebKit):
2709         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2710         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2711         (TestInterfaces):
2712         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2713         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2714         * DumpRenderTree/chromium/TestShell.cpp:
2715         (TestShell::initialize):
2716         * DumpRenderTree/chromium/TestShell.h:
2717         (WebKit):
2718         * DumpRenderTree/chromium/TestShellMac.mm:
2719         (platformInit):
2720         * DumpRenderTree/chromium/TestShellWin.cpp:
2721         (platformInit):
2722         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2723         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2724         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2725         (WebThemeControlDRTWin::box):
2726         (WebThemeControlDRTWin::line):
2727         (WebThemeControlDRTWin::triangle):
2728         (WebThemeControlDRTWin::roundRect):
2729         (WebThemeControlDRTWin::oval):
2730         (WebThemeControlDRTWin::circle):
2731         (WebThemeControlDRTWin::nestedBoxes):
2732         (WebThemeControlDRTWin::markState):
2733         (WebThemeControlDRTWin::draw):
2734         (WebThemeControlDRTWin::drawTextField):
2735         (WebThemeControlDRTWin::drawProgressBar):
2736         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2737         (WebThemeControlDRTWin):
2738         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2739         (WebThemeEngineDRTMac):
2740         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2741         (+[FakeActiveWindow alwaysActiveWindow]):
2742         (+[FakeActiveWindow alwaysInactiveWindow]):
2743         (-[FakeActiveWindow initWithActiveControls:]):
2744         (-[FakeActiveWindow _hasActiveControls]):
2745         (WebThemeEngineDRTMac::paintScrollbarThumb):
2746         (stateToHIEnableState):
2747         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2748         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2749         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2750         (webRectToSkIRect):
2751         (drawControl):
2752         (drawTextField):
2753         (drawProgressBar):
2754         (WebThemeEngineDRTWin::paintButton):
2755         (WebThemeEngineDRTWin::paintMenuList):
2756         (WebThemeEngineDRTWin::paintScrollbarArrow):
2757         (WebThemeEngineDRTWin::paintScrollbarThumb):
2758         (WebThemeEngineDRTWin::paintScrollbarTrack):
2759         (WebThemeEngineDRTWin::paintSpinButton):
2760         (WebThemeEngineDRTWin::paintTextField):
2761         (WebThemeEngineDRTWin::paintTrackbar):
2762         (WebThemeEngineDRTWin::paintProgressBar):
2763         (WebThemeEngineDRTWin::getSize):
2764         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2765         (WebThemeEngineDRTWin):
2766         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2767
2768 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2769
2770         [EFL] canvas-fallback-content.html is failing
2771         https://bugs.webkit.org/show_bug.cgi?id=111998
2772
2773         Reviewed by Chris Fleizach.
2774
2775         Adds support for getting platform name.
2776
2777         * DumpRenderTree/TestRunner.cpp:
2778         (TestRunner::staticValues):
2779         * DumpRenderTree/TestRunner.h:
2780         (TestRunner):
2781         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2782         (TestRunner::platformName):
2783
2784 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2785
2786         [chromium] move WebThemeEngine implementations to TestRunner library
2787         https://bugs.webkit.org/show_bug.cgi?id=112751
2788
2789         Reviewed by Adam Barth.
2790
2791         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2792         * DumpRenderTree/DumpRenderTree.gypi:
2793         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2794         (WebKit):
2795         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2796         (WebTestRunner::TestInterfaces::themeEngine):
2797         (WebTestRunner):
2798         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2799         (WebKit):
2800         (TestInterfaces):
2801         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2802         (WebTestRunner::WebTestInterfaces::themeEngine):
2803         (WebTestRunner):
2804         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2805         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2806         (WebTestRunner):
2807         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2808         (WebTestRunner::WebTestThemeControlWin::box):
2809         (WebTestRunner::WebTestThemeControlWin::line):
2810         (WebTestRunner::WebTestThemeControlWin::triangle):
2811         (WebTestRunner::WebTestThemeControlWin::roundRect):
2812         (WebTestRunner::WebTestThemeControlWin::oval):
2813         (WebTestRunner::WebTestThemeControlWin::circle):
2814         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2815         (WebTestRunner::WebTestThemeControlWin::markState):
2816         (WebTestRunner::WebTestThemeControlWin::draw):
2817         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2818         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2819         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2820         (WebTestRunner):
2821         (WebTestThemeControlWin):
2822         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2823         (WebTestRunner):
2824         (WebTestThemeEngineMac):
2825         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2826         (+[FakeActiveWindow alwaysActiveWindow]):
2827         (+[FakeActiveWindow alwaysInactiveWindow]):
2828         (-[FakeActiveWindow initWithActiveControls:]):
2829         (-[FakeActiveWindow _hasActiveControls]):
2830         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2831         (WebTestRunner):
2832         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2833         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2834         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2835         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2836         (WebTestRunner):
2837         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2838         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2839         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2840         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2841         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2842         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2843         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2844         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2845         (WebTestRunner::WebTestThemeEngineWin::getSize):
2846         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2847         (WebTestRunner):
2848         (WebTestThemeEngineWin):
2849         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2850         * DumpRenderTree/chromium/TestShell.cpp:
2851         (TestShell::initialize):
2852         * DumpRenderTree/chromium/TestShell.h:
2853         (WebKit):
2854         * DumpRenderTree/chromium/TestShellMac.mm:
2855         (platformInit):
2856         * DumpRenderTree/chromium/TestShellWin.cpp:
2857         (platformInit):
2858         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2859
2860 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2861
2862         [EFL][WK2] Separate WebView further from EwkView
2863         https://bugs.webkit.org/show_bug.cgi?id=111591
2864
2865         Reviewed by Caio Marcelo de Oliveira Filho.
2866
2867         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2868         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2869         since we can afford it having EWKViewGetWKView() private API to access WKView.
2870
2871         * TestWebKitAPI/PlatformWebView.h:
2872         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2873         (TestWebKitAPI::TEST):
2874         * TestWebKitAPI/efl/PlatformWebView.cpp:
2875         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2876         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2877         (TestWebKitAPI::PlatformWebView::resizeTo):
2878         (TestWebKitAPI::PlatformWebView::page):
2879         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2880         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2881         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2882         * WebKitTestRunner/PlatformWebView.h:
2883         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2884         (WTR::EventSenderProxy::dispatchEvent):
2885         (WTR::EventSenderProxy::keyDown):
2886         (WTR::EventSenderProxy::sendTouchEvent):
2887         (WTR::EventSenderProxy::setTouchModifier):
2888         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2889         (WTR::PlatformWebView::PlatformWebView):
2890         (WTR::PlatformWebView::~PlatformWebView):
2891         (WTR::PlatformWebView::resizeTo):
2892         (WTR::PlatformWebView::page):
2893         (WTR::PlatformWebView::focus):
2894         (WTR::PlatformWebView::windowSnapshotImage):
2895
2896 2013-03-19  Roger Fong  <roger_fong@apple.com>
2897
2898         Changes to VS2010 project files should only trigger builds on Windows bots.
2899         https://bugs.webkit.org/show_bug.cgi?id=112731
2900
2901         Reviewed by Timothy Horton.
2902
2903         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2904         (_should_file_trigger_build):
2905
2906 2013-03-19  Roger Fong  <roger_fong@apple.com>
2907
2908         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2909
2910         * Scripts/webkitpy/tool/steps/runtests.py:
2911         (RunTests.run):
2912         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2913         (RunTestsTest.test_webkit_run_unit_tests):
2914
2915 2013-03-19  Julie Parent  <jparent@chromium.org>
2916
2917         Dashboards: Introduce history namespace and unit tests.
2918         https://bugs.webkit.org/show_bug.cgi?id=112645
2919
2920         Reviewed by Ojan Vafai.
2921         
2922         Laying the framework for introducing the new history object and
2923         namespace.  This moves only static functions into the history
2924         namespace, and moves corresponding unit tests into seperate
2925         unit test file.
2926
2927         * TestResultServer/static-dashboards/aggregate_results.html:
2928         * TestResultServer/static-dashboards/dashboard_base.js:
2929         (parseCrossDashboardParameters):
2930         (parseDashboardSpecificParameters):
2931         (parseParameters):
2932         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2933         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2934         (.switch.return):
2935         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2936         * TestResultServer/static-dashboards/history.js: Added.
2937         * TestResultServer/static-dashboards/history_unittests.js: Added.
2938         * TestResultServer/static-dashboards/loader.js:
2939         (.):
2940         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2941         * TestResultServer/static-dashboards/run-unittests.html:
2942         * TestResultServer/static-dashboards/timeline_explorer.html:
2943         * TestResultServer/static-dashboards/timeline_explorer.js:
2944         * TestResultServer/static-dashboards/treemap.html:
2945         * TestResultServer/static-dashboards/treemap.js:
2946         (.switch.return):
2947         * TestResultServer/static-dashboards/ui.js:
2948
2949 2013-03-19  Daniel Bates  <dbates@webkit.org>
2950
2951         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2952         https://bugs.webkit.org/show_bug.cgi?id=112732
2953
2954         Reviewed by Eric Seidel.
2955
2956         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2957         of an existing file cannot be applied.
2958
2959         In particular, svn-{apply, unapply} compensate for differences in line endings
2960         by converting the line endings in a diff to match the line endings in the target
2961         file. The diff(1) command precedes the last line of a diff that adds a newline
2962         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2963         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2964         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2965         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2966         the newline characters in this special character sequence to match the line endings
2967         in the target file.
2968
2969         * Scripts/VCSUtils.pm:
2970         (parseDiff):
2971         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2972         Added tests:
2973             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2974             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2975             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2976             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2977         (escapeNewLineCharacters): Added.
2978         (toMacLineEndings): Added.
2979
2980 2013-03-19  James Robinson  <jamesr@chromium.org>
2981
2982         [chromium] Remove compositor settings that don't go through WebKit
2983         https://bugs.webkit.org/show_bug.cgi?id=112718
2984
2985         Reviewed by Adam Barth.
2986
2987         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2988         (main):
2989         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2990         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2991         (WebTestRunner::WebPreferences::reset):
2992         (WebTestRunner::WebPreferences::applyTo):
2993         * DumpRenderTree/chromium/TestShell.cpp:
2994         (TestShell::TestShell):
2995         (TestShell::resetWebSettings):
2996         * DumpRenderTree/chromium/TestShell.h:
2997         (TestShell):
2998
2999 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3000
3001         Unreviewed, rolling out r146101.
3002         https://bugs.webkit.org/show_bug.cgi?id=111884
3003
3004         re-enable custom freetype on asan; this needs to be on
3005         now that the bot is running lucid.
3006
3007         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3008
3009 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3010
3011         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3012         https://bugs.webkit.org/show_bug.cgi?id=112365
3013
3014         Reviewed by Benjamin Poulain.
3015
3016         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3017         harcoding it in wtf/Platform.h
3018
3019         * Scripts/webkitperl/FeatureList.pm:
3020
3021 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3022
3023         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3024         https://bugs.webkit.org/show_bug.cgi?id=94782
3025
3026         Based on patch by Csaba Osztrogonác.
3027         Reviewed by Jocelyn Turcotte.
3028
3029         The diff image is generated with bright red indicating errors, but letting the base image
3030         shine through so the context of the error-pixel can be identified.
3031
3032         * DumpRenderTree/qt/ImageDiff.cpp:
3033         (main):
3034
3035 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3036
3037         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3038
3039         Rubber-stamped by Csaba Osztrogonác.
3040
3041         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3042         since the latter might not cover the former.
3043
3044         * QtTestBrowser/launcherwindow.cpp:
3045         (LauncherWindow::print):
3046
3047 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3048
3049         Style tweeks to default.css.
3050         
3051         Rubber-stamped by David Kilzer.
3052         
3053         Give visited links a different color to other links, so you can
3054         see which builds you've viewed.
3055         
3056         Make the <small> text less tiny.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3059         (small):
3060         (a:link,a:visited,a:active):
3061         (a:visited):
3062
3063 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3066         https://bugs.webkit.org/show_bug.cgi?id=112494
3067
3068         Reviewed by Dirk Pranke.
3069
3070         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3071         Also merged two pairs of methods to cleanup the code.
3072
3073         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3074         (PerfTestsRunner.run): Merged _upload_and_show_results.
3075         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3076
3077 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3078
3079         [chromium] build xdisplaycheck when building DRT
3080         https://bugs.webkit.org/show_bug.cgi?id=112636
3081
3082         Reviewed by Tony Chang.
3083
3084         It appears that we need xdisplaycheck to be built in order for
3085         Xvfb to be started correctly on the bots, and DRT was missing
3086         a dependency on it. This may be the cause of the ASAN bot not
3087         starting up properly (it only builds DRT).
3088
3089         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3090
3091 2013-03-18  David Levin  <levin@chromium.org>
3092
3093         Implement icon change notification dump for Chromium's test shell.
3094         https://bugs.webkit.org/show_bug.cgi?id=112614
3095
3096         This was previously implemented for some other platforms in r58111
3097         and r116547.
3098
3099         In r122806, fast/dom/icon-url-property.html stopped using it, but
3100         it is useful for tests, so I plan to re-add it to that test again.
3101
3102         Reviewed by Jochen Eisinger.
3103
3104         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3105         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3106          icon change notifications from WebKit may be logged in test output.
3107         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3108         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3109         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3110         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3111         (WebTestRunner):
3112         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3113         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3114         (TestRunner):
3115         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3116         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3117         (WebTestRunner):
3118         * DumpRenderTree/chromium/WebViewHost.cpp:
3119         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3120         * DumpRenderTree/chromium/WebViewHost.h:
3121         (WebViewHost):
3122
3123 2013-03-18  Julie Parent  <jparent@chromium.org>
3124
3125         Cleanup: Move js for treemap and aggregate_results into own js files.
3126         https://bugs.webkit.org/show_bug.cgi?id=112618
3127
3128         Reviewed by Dirk Pranke.
3129         
3130         No functional changes, just moving the code into separate js file
3131         rather than inlined in the html, so we can test it, make it more
3132         modular, etc.  Other dashboard types are already done this way.
3133
3134         * TestResultServer/static-dashboards/aggregate_results.html:
3135         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3136         (generatePage):
3137         (handleValidHashParameter):
3138         (htmlForBuilder):
3139         (rawValuesHTML):
3140         (chartHTML):
3141         (filteredValues):
3142         (chart):
3143         (htmlForRevisionRows):
3144         (wrapHTMLInTable):
3145         (htmlForSummaryTable):
3146         (valuesPerExpectation):
3147         (htmlForTestType):
3148         (htmlForTableRow):
3149         (extendedEncode):
3150         * TestResultServer/static-dashboards/treemap.html:
3151         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3152         (humanReadableTime):
3153         (convertToWebTreemapFormat):
3154         (reverseSortByAverage):
3155         (generatePage):
3156         (focusPath):
3157         (.switch.return):
3158         (handleQueryParameterChange):
3159         (extractName):
3160         (fullName):
3161         (handleFocus.):
3162         (handleFocus):
3163
3164 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3165
3166         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3167         https://bugs.webkit.org/show_bug.cgi?id=112622
3168
3169         Reviewed by Dirk Pranke.
3170
3171         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3172         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3173
3174 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3175
3176         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3177         https://bugs.webkit.org/show_bug.cgi?id=112619
3178
3179         Reviewed by Dirk Pranke.
3180
3181         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3182         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3183
3184         * Scripts/webkitpy/layout_tests/port/gtk.py:
3185         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3186         Port._webkit_baseline_path method.
3187         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3188         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3189         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3190         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3191         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3192         that are expected based on the builder name.
3193
3194 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3195
3196         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3197         https://bugs.webkit.org/show_bug.cgi?id=112571
3198
3199         Reviewed by Adam Barth.
3200
3201         Update function declarations for new WebFileSystemType enum. (All
3202         changes are behind an #ifdef so we can sync required changes in embedders.)
3203
3204         * DumpRenderTree/chromium/WebViewHost.cpp:
3205         (WebViewHost::openFileSystem):
3206         (WebViewHost::deleteFileSystem):
3207         * DumpRenderTree/chromium/WebViewHost.h:
3208         (WebViewHost):
3209
3210 2013-03-18  Julie Parent  <jparent@chromium.org>
3211
3212         Cleanup: Move timeline_exporer js out of html file into js.
3213         https://bugs.webkit.org/show_bug.cgi?id=112188
3214
3215         Reviewed by Dirk Pranke.
3216         
3217         Moves the javascript out of the html file and into a new js file.
3218         This follows the format of flakiness_dashboard.{html|js}.
3219         
3220         Also moves code from dashboard_base that is used only by this one
3221         dashboard, and makes it private to the dashboard.
3222
3223         * TestResultServer/static-dashboards/dashboard_base.js:
3224         * TestResultServer/static-dashboards/timeline_explorer.html:
3225         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3226         (generatePage):
3227         (initCurrentBuilderTestResults):
3228         (shouldShowWebKitRevisionsOnly):
3229         (updateTimelineForBuilder.):
3230         (updateTimelineForBuilder):
3231         (selectBuild):
3232         (updateBuildIndicator):
3233         (.addRow):
3234         (.addNumberRow):
3235         (.inspectorNode.getElementsByTagName.0.onclick):
3236         (.inspectorNode.getElementsByTagName.1.onclick):
3237         (.inspectorNode.getElementsByTagName.2.onclick):
3238         (updateBuildInspector):
3239         (showResultsDelta):
3240         (decompressResults.addFlakyDelta):
3241         (decompressResults):
3242
3243 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3244
3245         Unreviewed, rolling out r145272.
3246         http://trac.webkit.org/changeset/145272
3247         https://bugs.webkit.org/show_bug.cgi?id=111884
3248
3249         Turns out the ASAN build is still broken; possibly there's
3250         something still setting LD_LIBRARY_PATH, or possibly there's
3251         something else wrong. In the meantime, we need it to work again.
3252
3253         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3254
3255 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3256
3257         delete-stale-build-files is too aggressive
3258         https://bugs.webkit.org/show_bug.cgi?id=112595
3259
3260         Reviewed by Tim Horton.
3261
3262         It appears that whitelisting file extensions to keep is not a good idea.
3263         Blacklist files to delete instead, and only delete .o files for now.
3264         We can add more file extensions as needed.
3265
3266         * BuildSlaveSupport/delete-stale-build-files:
3267
3268 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3269
3270         Disable accessibility notifications after each test
3271         https://bugs.webkit.org/show_bug.cgi?id=112579
3272
3273         Reviewed by Tim Horton.
3274         
3275         In WebKitTestRunner, if any tests triggered accessibility notifications,
3276         the global notification handler would thereafter be active, and fire
3277         notifications for all subsequent tests.
3278         
3279         Fix by implementing AccessibilityController::resetToConsistentState() for
3280         Mac, and using it to clear the global notification handler.
3281
3282         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3283         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3284         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3285         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3286         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3287         (e.g. because of -autorelease).
3288         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3289         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3290         if there is one.
3291         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3292         Add -stopObserving
3293         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3294         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3295         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3296         center.
3297
3298 2013-03-18  Dana Jansens  <danakj@chromium.org>
3299
3300         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3301         https://bugs.webkit.org/show_bug.cgi?id=112392
3302
3303         Reviewed by James Robinson.
3304
3305         Removes the command line flag option from DRT.
3306
3307         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3308         (main):
3309
3310 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3311
3312         [GTK] plugins/plugin-clip-subframe.html is failing
3313         https://bugs.webkit.org/show_bug.cgi?id=112570
3314
3315         Reviewed by Martin Robinson.
3316
3317         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3318
3319 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3320
3321         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3322         https://bugs.webkit.org/show_bug.cgi?id=112442
3323
3324         Reviewed by Gustavo Noronha Silva.
3325
3326         * GtkLauncher/main.c:
3327         (reloadCb):
3328         (createToolbar):
3329         (createWindow):
3330
3331 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3332
3333         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3334         https://bugs.webkit.org/show_bug.cgi?id=112205
3335
3336         Disable this API test until Geoff can fix it.
3337
3338         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3339         (TestWebKitAPI::TEST):
3340
3341 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3342
3343         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3344         https://bugs.webkit.org/show_bug.cgi?id=112478
3345
3346         Reviewed by Tony Chang.
3347
3348         There is nothing that ensures that the log messages from the plugin
3349         come in before the layout test finished loading.
3350
3351         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3352         (PassDifferentNPPStruct::NPP_SetWindow):
3353         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3354         (NPP_SetWindow):
3355
3356 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3357
3358         Have the mac port support per_test_timeout in webkitpy
3359         https://bugs.webkit.org/show_bug.cgi?id=112466
3360
3361         Reviewed by Dirk Pranke.
3362         
3363         Both WTR and DRT handle --timeout arguments, so we can
3364         have the scripts pass the timeout values down to the tools.
3365
3366         * Scripts/webkitpy/layout_tests/port/mac.py:
3367         (MacPort.supports_per_test_timeout):
3368
3369 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3370
3371         Remove setAsynchronousSpellCheckingEnabled from test runners
3372         https://bugs.webkit.org/show_bug.cgi?id=112362
3373
3374         Reviewed by Tony Chang.
3375
3376         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3377         in internals.settings, so all ports can share it.
3378
3379         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3380         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3381         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3382         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3383         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3384         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3385         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3386         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3387         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3388         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3389         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3390         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3391
3392 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3393
3394         Fix the stupid unit tests.
3395
3396         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3397         (test_sample_process):
3398
3399 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3400
3401         Collect samples for unresponsive web processes
3402         https://bugs.webkit.org/show_bug.cgi?id=112409
3403
3404         Reviewed by Tim Horton.
3405         
3406         When we detect that a subprocess was unresponsive, run the 'sample'
3407         tool on that process, for the Mac port.
3408         
3409         The sample will be linked to from the results.html page, next
3410         to the crash log link.
3411
3412         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3413         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3414         look for samples on disk.
3415         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3416         (TestResultWriter):
3417         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3418         -sample.txt files, and have it copy their contents to a new file
3419         next to the test that spawned them (as we do for crash logs).
3420         * Scripts/webkitpy/layout_tests/port/base.py:
3421         (Port.look_for_new_samples): Base class does nothing for sampling.
3422         * Scripts/webkitpy/layout_tests/port/driver.py:
3423         (Driver._check_for_driver_crash): Kick off a sample if we detected
3424         that the subprocess was unresponsive.
3425         * Scripts/webkitpy/layout_tests/port/mac.py:
3426         (MacPort.sample_file_path): Utility to generate the file path
3427         to the generated sample files at the top level of layout-test-results.
3428         (MacPort.look_for_new_crash_logs): Fix typo
3429         (MacPort.look_for_new_samples): New function to find sample files.
3430         (MacPort.sample_process): Use the utility function to get the file path.
3431
3432 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3433
3434         [Qt] Remove simple getters and setters from TestRunnerQt
3435         https://bugs.webkit.org/show_bug.cgi?id=112343
3436
3437         Reviewed by Benjamin Poulain.
3438
3439         The removed functions and boolean members
3440         are being replaced by the implementations in the
3441         generic TestRunner.h.
3442
3443         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3444         (DumpRenderTree::dumpFrameScrollPosition):
3445         (DumpRenderTree::dumpFramesAsText):
3446         (DumpRenderTree::dump):
3447         (DumpRenderTree::titleChanged):
3448         (DumpRenderTree::dumpDatabaseQuota):
3449         (DumpRenderTree::dumpApplicationCacheQuota):
3450         (DumpRenderTree::statusBarMessage):
3451         (DumpRenderTree::createWindow):
3452         * DumpRenderTree/qt/TestRunnerQt.cpp:
3453         (TestRunnerQt::reset):
3454         * DumpRenderTree/qt/TestRunnerQt.h:
3455         (TestRunnerQt):
3456
3457 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3458
3459         Update the link on build.webkit.org to refer to perf.webkit.org
3460         https://bugs.webkit.org/show_bug.cgi?id=112416
3461
3462         Reviewed by Philip Rogers.
3463
3464         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3467
3468 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3469
3470         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3471         https://bugs.webkit.org/show_bug.cgi?id=112394
3472
3473         Reviewed by Philippe Normand.
3474
3475         * GtkLauncher/main.c:
3476         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3477
3478 2013-03-14  Andreas Kling  <akling@apple.com>
3479
3480         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3481         <http://webkit.org/b/111815>
3482         <rdar://problem/13380145>
3483
3484         Reviewed by Anders Carlsson.
3485
3486         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3487         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3488         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3489
3490         * WebKitTestRunner/PlatformWebView.h:
3491         (PlatformWebView):
3492         * WebKitTestRunner/TestController.cpp:
3493         (WTR::TestController::createOtherPage):
3494         (WTR::TestController::createWebViewWithOptions):
3495         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3496         (WTR::PlatformWebView::didInitializeClients):
3497
3498 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3499
3500         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3501         https://bugs.webkit.org/show_bug.cgi?id=112122
3502
3503         Reviewed by Kenneth Rohde Christiansen.
3504
3505         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3506
3507         * MiniBrowser/efl/main.c:
3508         (_Browser_Window):
3509         (search_box_show):
3510         (search_box_hide):
3511         (on_key_down):
3512         (on_url_changed):
3513         (on_search_field_aborted):
3514         (on_search_field_activated):
3515         (on_search_field_clicked):
3516         (on_search_backward_button_clicked):
3517         (on_search_forward_button_clicked):
3518         (window_create):
3519
3520 2013-03-14  Julie Parent  <jparent@chromium.org>
3521
3522         Cleanup: Remove g_resourceLoader.
3523         https://bugs.webkit.org/show_bug.cgi?id=112305
3524
3525         Reviewed by Dirk Pranke.
3526         
3527         Removing another global.
3528         
3529         Now, each dashboard creates its own loader, rather than having
3530         a general global one.
3531         
3532         Remove usage of g_resourceLoader.isLoadingComplete from 
3533         handleLocationChange by ensuring that handleLocationChange is
3534         never called before the loader is done.  It was called in two
3535         places before: 1 was from the callback when the loader is done,
3536         so that was obviously true, and the other was from onhashchange,
3537         where it would just return rather than running.  Instead, lets
3538         only register the onhashchange handler once the loader is
3539         setup, so the check is no longer necessary.
3540         
3541         Remove isLoadingComplete since it is now unused.
3542         
3543         Callback for loader is now initializeHistory, rather than just
3544         handleLocationChange which will set up the hashchange handler now.
3545         This will all eventually be moving to a new History object.
3546
3547         * TestResultServer/static-dashboards/aggregate_results.html:
3548         * TestResultServer/static-dashboards/dashboard_base.js:
3549         (handleLocationChange):
3550         (intializeHistory):
3551         (decompressResults):
3552         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3553         (generatePage):
3554         * TestResultServer/static-dashboards/loader.js:
3555         (.):
3556         * TestResultServer/static-dashboards/loader_unittests.js:
3557         * TestResultServer/static-dashboards/timeline_explorer.html:
3558         * TestResultServer/static-dashboards/treemap.html:
3559
3560 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3561
3562         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3563         https://bugs.webkit.org/show_bug.cgi?id=109404
3564
3565         Reviewed by Tony Chang.
3566
3567         Removes all the code related to smartInsertDeleteEnabled and
3568         selectTrailingWhitespaceEnabled settings as they will be managed from
3569         internals from now on.
3570
3571         * DumpRenderTree/TestRunner.cpp:
3572         (TestRunner::staticFunctions):
3573         * DumpRenderTree/TestRunner.h:
3574         (TestRunner):
3575         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3576         (WebKit):
3577         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3578         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3579         (DumpRenderTree):
3580         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3581         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3582         (WebTestRunner::WebTestProxy::didStopLoading):
3583         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3584         (WebTestRunner::TestRunner::TestRunner):
3585         (WebTestRunner::TestRunner::reset):
3586         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3587         (TestRunner):
3588         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3589         (WebTestRunner::WebPreferences::applyTo): Set default values for
3590         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3591         Chromium DRT default values are different from Chromium browser.
3592         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3593         * DumpRenderTree/chromium/WebViewHost.cpp:
3594         * DumpRenderTree/chromium/WebViewHost.h:
3595         (WebViewHost):
3596         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3597         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3598         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3599         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3600         (resetDefaultsToConsistentValues):
3601         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3602         * DumpRenderTree/mac/DumpRenderTree.mm:
3603         (resetWebViewToConsistentStateBeforeTesting):
3604         * DumpRenderTree/mac/TestRunnerMac.mm:
3605         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3606         (WebCore::WebPage::resetSettings):
3607         * DumpRenderTree/qt/TestRunnerQt.cpp:
3608         * DumpRenderTree/qt/TestRunnerQt.h:
3609         (TestRunnerQt):
3610         * DumpRenderTree/win/DumpRenderTree.cpp:
3611         (resetWebViewToConsistentStateBeforeTesting):
3612         * DumpRenderTree/win/TestRunnerWin.cpp:
3613         * DumpRenderTree/wx/TestRunnerWx.cpp:
3614
3615 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3616
3617         [Qt] Disable DRT on Windows
3618
3619         Reviewed by Jocelyn Turcotte.
3620
3621         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3622
3623         * qmake/mkspecs/features/configure.prf:
3624
3625 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3626
3627         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3628         https://bugs.webkit.org/show_bug.cgi?id=110728
3629
3630         Reviewed by Gyuyoung Kim.
3631
3632         Use the page group to create the view object.
3633
3634         * MiniBrowser/efl/main.c:
3635         (window_create):
3636
3637 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3638
3639         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3640
3641         Reviewed by Tor Arne Vestbø.
3642
3643         The mock versions of these web facing features should be instantiated when
3644         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3645         such as QtLocation are actually needed.
3646
3647         This patch decouples enabling device orientation/motion and geolocation from
3648         the underlying Qt modules and makes them available in developer builds
3649         (!production_build) and backed by mock backends when running in drt.
3650
3651         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3652         developers the web facing features are always enabled (although requests will
3653         time out) and the mock backends are enabled inside DRT, allowing for the layout
3654         tests to run with less dependencies.
3655
3656         In addition this also enables the mock device motion client, which was
3657         previously never instantiated.
3658
3659         * qmake/mkspecs/features/features.prf:
3660
3661 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3662
3663         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3664         https://bugs.webkit.org/show_bug.cgi?id=112340
3665
3666         Reviewed by Simon Hausmann.
3667
3668         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3669         (DumpRenderTree::dump):
3670             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3671         (DumpRenderTree::dumpApplicationCacheQuota):
3672         * DumpRenderTree/qt/TestRunnerQt.cpp:
3673         (TestRunnerQt::reset):
3674         * DumpRenderTree/qt/TestRunnerQt.h:
3675         (TestRunnerQt):
3676
3677 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3678
3679         [Qt] Port DRT to use TestRunner::dumpAsText()
3680         https://bugs.webkit.org/show_bug.cgi?id=112260
3681
3682         Reviewed by Benjamin Poulain.
3683
3684         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3685         (WebCore::DumpRenderTree::open):
3686         (WebCore::methodNameStringForFailedTest):
3687             Change parameter from type TestRunnerQt* to TestRunner*.
3688         (WebCore::DumpRenderTree::dump):
3689             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3690             Instead we should rely on TestRunner::generatePixelResults().
3691         * DumpRenderTree/qt/TestRunnerQt.cpp:
3692         (TestRunnerQt::reset):
3693         * DumpRenderTree/qt/TestRunnerQt.h:
3694         (TestRunnerQt):
3695
3696 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3697
3698         Implement FontLoader interface
3699         https://bugs.webkit.org/show_bug.cgi?id=98395
3700
3701         Reviewed by Eric Seidel.
3702
3703         Enable FontLoadEvents runtime flag for TestShell.
3704
3705         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3706         (WebTestRunner::TestInterfaces::TestInterfaces):
3707
3708 2013-03-13  Julie Parent  <jparent@chromium.org>
3709
3710         CLeanup: remove unnecessary call to parseParameters.
3711         https://bugs.webkit.org/show_bug.cgi?id=112309
3712
3713         Reviewed by Ojan Vafai.
3714         
3715         We call parseCrossDashboardParameters when the dashboard initially
3716         loads to set the state required for loadBuildersList, and then we
3717         call it again once we are fully done with loading, so there is no
3718         reason to call it in the middle of the loading process here.
3719
3720         * TestResultServer/static-dashboards/loader.js:
3721         (.):
3722
3723 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3724
3725         Unreviewed. Now I'm a reviewer :)
3726
3727         * Scripts/webkitpy/common/config/committers.py:
3728
3729 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3730
3731         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3732         https://bugs.webkit.org/show_bug.cgi?id=112277
3733
3734         Reviewed by Adam Barth.
3735
3736         * Scripts/webkitperl/FeatureList.pm:
3737         * qmake/mkspecs/features/features.pri:
3738
3739 2013-03-13  Adam Barth  <abarth@webkit.org>
3740
3741         run-perf-tests should support content_shell
3742         https://bugs.webkit.org/show_bug.cgi?id=112291
3743
3744         Reviewed by Eric Seidel.
3745
3746         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3747         (PerfTestsRunner._parse_args):
3748
3749 2013-03-13  Oliver Hunt  <oliver@apple.com>
3750
3751         Simplify Checked<> multiplication
3752         https://bugs.webkit.org/show_bug.cgi?id=112286
3753
3754         Reviewed by James Robinson.
3755
3756         Add tests for multiplication by zero and max to ensure we don't
3757         mess them up should we ever make changes to Checked<> in future.
3758
3759         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3760         (TestWebKitAPI):
3761
3762 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3763
3764         [Qt] Unreviewed prospective Windows build fix
3765
3766         Do the usual thing, include the moc generated code in the .cpp file instead
3767         of compiling it standalone, to ensure that config.h is included, too, and
3768         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3769
3770         * DumpRenderTree/qt/EventSenderQt.cpp:
3771
3772 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3773
3774         [Qt] Port TestRunner::findString to shared interface
3775         https://bugs.webkit.org/show_bug.cgi?id=112147
3776
3777         Reviewed by Jocelyn Turcotte.
3778
3779         This patch also removes DumpRenderTree and some other helper classes from
3780         the WebCore namespace, to which they do not really belong.
3781
3782         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3783         (main):
3784         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3785         (DumpRenderTree::DumpRenderTree):
3786         (DumpRenderTree::~DumpRenderTree):
3787         (DumpRenderTree::instance):
3788         (DumpRenderTree::setShouldTimeout):
3789         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3790         (DumpRenderTree):
3791         * DumpRenderTree/qt/EventSenderQt.cpp:
3792         (EventSender::contextClick):
3793         (EventSender::sendEvent):
3794         (EventSender::postEvent):
3795         * DumpRenderTree/qt/EventSenderQt.h:
3796         (EventSender::isGraphicsBased):
3797         * DumpRenderTree/qt/TestRunnerQt.cpp:
3798         (TestRunnerQt::TestRunnerQt):
3799         (TestRunner::findString):
3800         (TestRunnerQt::setMockDeviceOrientation):
3801         (TestRunnerQt::setGeolocationPermission):
3802         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3803         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3804         (TestRunnerQt::setMockGeolocationPosition):
3805         * DumpRenderTree/qt/TestRunnerQt.h:
3806         (TestRunnerQt):
3807
3808 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3809
3810         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3811         https://bugs.webkit.org/show_bug.cgi?id=112129
3812
3813         Reviewed by Adam Barth.
3814
3815         Following Chromium
3816         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3817         this is being renamed to better explain what it does.
3818
3819         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3820
3821 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3822
3823         [Qt] Unreviewed trivial typo fix
3824
3825         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3826         TextRunner.h. Thanks Zeno :)
3827
3828 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3829
3830         [Qt] Prepare DRT for transition to shared TestRunner interface
3831         https://bugs.webkit.org/show_bug.cgi?id=112144
3832
3833         Reviewed by Benjamin Poulain.
3834
3835         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3836         the JSC C API based one.
3837
3838         This is impplemented by instantiating the QObject based testRunner in
3839         the global object, then instantiating the JSC C based TestRunner
3840         separately and placing it "behind" the QObject based testRunner through
3841         injection of the individual functions through proxies. (prototype
3842         chaining doesn't work due to the this object and Function.prototype.bind
3843         doesn't work due to the native function)
3844
3845         This allows for porting over method by method by removing the method
3846         from the QObject TestRunnerQt and implementing it in the JSC C based
3847         TestRunner.
3848
3849         In order for this to link and run dummy implementations of all the
3850         necessary TestRunner functions are provided.
3851
3852         * DumpRenderTree/qt/DumpRenderTree.pro:
3853         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3854         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3855         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3856         (WebCore::DumpRenderTree::initJSObjects):
3857         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3858         (DumpRenderTree):
3859         * DumpRenderTree/qt/TestRunnerQt.cpp:
3860         (TestRunner::~TestRunner):
3861         (TestRunner::addDisallowedURL):
3862         (TestRunner::queueLoad):
3863         (TestRunner::removeAllVisitedLinks):
3864         (TestRunner::setAcceptsEditing):
3865         (TestRunner::simulateLegacyWebNotificationClick):
3866         (TestRunner::setWindowIsKey):
3867         (TestRunner::setAlwaysAcceptCookies):
3868         (TestRunner::addOriginAccessWhitelistEntry):
3869         (TestRunner::setWebViewEditable):
3870         (TestRunner::clearAllApplicationCaches):
3871         (TestRunner::setTextDirection):
3872         (TestRunner::notifyDone):
3873         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3874         (TestRunner::overridePreference):
3875         (TestRunner::pathToLocalResource):
3876         (TestRunner::removeAllWebNotificationPermissions):
3877         (TestRunner::simulateWebNotificationClick):
3878         (TestRunner::closeIdleLocalStorageDatabases):
3879         (TestRunner::focusWebView):
3880         (TestRunner::setBackingScaleFactor):
3881         (TestRunner::removeChromeInputField):
3882         (TestRunner::addChromeInputField):
3883         (TestRunner::originsWithLocalStorage):
3884         (TestRunner::deleteAllLocalStorage):
3885         (TestRunner::deleteLocalStorageForOrigin):
3886         (TestRunner::observeStorageTrackerNotifications):
3887         (TestRunner::syncLocalStorage):
3888         (TestRunner::windowCount):
3889         (TestRunner::setWaitToDump):
3890         (TestRunner::waitForPolicyDelegate):
3891         (TestRunner::webHistoryItemCount):
3892         (TestRunner::showWebInspector):
3893         (TestRunner::closeWebInspector):
3894         (TestRunner::evaluateInWebInspector):
3895         (TestRunner::setSerializeHTTPLoads):
3896         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3897         (TestRunner::setCustomPolicyDelegate):
3898         (TestRunner::setDatabaseQuota):
3899         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3900         (TestRunner::resetPageVisibility):
3901         (TestRunner::keepWebHistory):
3902         (TestRunner::goBack):
3903         (TestRunner::originsWithApplicationCache):
3904         (TestRunner::applicationCacheDiskUsageForOrigin):
3905         (TestRunner::display):
3906         (TestRunner::dispatchPendingLoadRequests):
3907         (TestRunner::clearPersistentUserStyleSheet):
3908         (TestRunner::callShouldCloseOnWebView):
3909         (TestRunner::copyDecodedHostName):
3910         (TestRunner::clearBackForwardList):
3911         (TestRunner::clearAllDatabases):
3912         (TestRunner::clearApplicationCacheForOrigin):
3913         (TestRunner::apiTestGoToCurrentBackForwardItem):
3914         (TestRunner::authenticateSession):
3915         (TestRunner::abortModal):
3916         (TestRunner::setStorageDatabaseIdleInterval):
3917         (TestRunner::setAsynchronousSpellCheckingEnabled):
3918         (TestRunner::setXSSAuditorEnabled):
3919         (TestRunner::setSpatialNavigationEnabled):
3920         (TestRunner::setScrollbarPolicy):
3921         (TestRunner::setJavaScriptCanAccessClipboard):
3922         (TestRunner::setAutomaticLinkDetectionEnabled):
3923         (TestRunner::setUserStyleSheetEnabled):
3924         (TestRunner::setUserStyleSheetLocation):
3925         (TestRunner::setUseDashboardCompatibilityMode):
3926         (TestRunner::setTabKeyCyclesThroughElements):
3927         (TestRunner::setSmartInsertDeleteEnabled):
3928         (TestRunner::setSelectTrailingWhitespaceEnabled):
3929         (TestRunner::setPrivateBrowsingEnabled):
3930         (TestRunner::setPluginsEnabled):
3931         (TestRunner::setPopupBlockingEnabled):
3932         (TestRunner::setMockSpeechInputDumpRect):
3933         (TestRunner::setPersistentUserStyleSheetLocation):
3934         (TestRunner::setMockGeolocationPosition):
3935         (TestRunner::setMockGeolocationPositionUnavailableError):
3936         (TestRunner::setMockDeviceOrientation):
3937         (TestRunner::setMainFrameIsFirstResponder):
3938         (TestRunner::setIconDatabaseEnabled):
3939         (TestRunner::setGeolocationPermission):
3940         (TestRunner::setDefersLoading):
3941         (TestRunner::setCacheModel):
3942         (TestRunner::setAuthorAndUserStylesEnabled):
3943         (TestRunner::setAllowFileAccessFromFileURLs):
3944         (TestRunner::setAppCacheMaximumSize):
3945         (TestRunner::setAllowUniversalAccessFromFileURLs):
3946         (TestRunner::setApplicationCacheOriginQuota):
3947         (TestRunner::denyWebNotificationPermission):
3948         (TestRunner::grantWebNotificationPermission):
3949         (TestRunner::setValueForUser):
3950         (TestRunner::setViewModeMediaFeature):
3951         (TestRunner::setPageVisibility):
3952         (TestRunner::addMockSpeechInputResult):
3953         (TestRunner::removeOriginAccessWhitelistEntry):
3954         (TestRunner::addUserScript):
3955         (TestRunner::isCommandEnabled):
3956         (TestRunner::evaluateScriptInIsolatedWorld):
3957         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3958         (TestRunner::copyEncodedHostName):
3959         (TestRunner::addUserStyleSheet):
3960         (TestRunner::findString):
3961         (TestRunner::execCommand):
3962         (TestRunner::localStorageDiskUsageForOrigin):
3963
3964 2013-03-12  Julie Parent  <jparent@chromium.org>
3965
3966         Cleanup: Move flatten-trie to loader.
3967         https://bugs.webkit.org/show_bug.cgi?id=112196
3968
3969         Reviewed by Dirk Pranke.
3970
3971         flatten-trie is used only by the loader, so move it there and make it
3972         private, rather than global in dashbaord_base. Moved the corresponding
3973         unit test from flakiness_dashboard_unittests to loader_unittests.
3974         
3975         * TestResultServer/static-dashboards/dashboard_base.js:
3976         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3977         * TestResultServer/static-dashboards/loader.js:
3978         (.):
3979         * TestResultServer/static-dashboards/loader_unittests.js:
3980
3981 2013-03-12  Oliver Hunt  <oliver@apple.com>
3982
3983         Unbreak api tests
3984
3985         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3986         (TestWebKitAPI):
3987
3988 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3989
3990         Unreviewed, disabling tests for Win EWS.
3991
3992         win-ews obviously cannot keep up with running tests, it's >300 behind.
3993         Probably doesn't help that its (likely) running tests serially.
3994
3995         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3996         (WinEWS):
3997
3998 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3999
4000         Add a --build-directory argument to delete-stale-build-files
4001         https://bugs.webkit.org/show_bug.cgi?id=112198
4002
4003         Reviewed by Ryosuke Niwa.
4004
4005         * BuildSlaveSupport/delete-stale-build-files:
4006         (main): Add --build-directory argument.
4007
4008 2013-03-12  Oliver Hunt  <oliver@apple.com>
4009
4010         Appease MSVC
4011
4012         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4013         (TestWebKitAPI):
4014
4015 2013-03-12  Oliver Hunt  <oliver@apple.com>
4016
4017         Add more Checked<> tests
4018         https://bugs.webkit.org/show_bug.cgi?id=112190
4019
4020         Reviewed by Geoffrey Garen.
4021
4022         Tests!
4023
4024         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4025         (TestWebKitAPI):
4026
4027 2013-03-12  Julie Parent  <jparent@chromium.org>
4028
4029         Cleanup: Move loading complete function into callback, rather than global.
4030         https://bugs.webkit.org/show_bug.cgi?id=112167
4031
4032         Reviewed by Dirk Pranke.
4033         
4034         Stop calling global functions, pass in proper handler to Loader
4035         constructor. Note that the callback is optional, as tests, and
4036         some potential dashboards, do not need one.
4037
4038         * TestResultServer/static-dashboards/dashboard_base.js:
4039         * TestResultServer/static-dashboards/loader.js:
4040         (.):
4041         * TestResultServer/static-dashboards/loader_unittests.js:
4042
4043 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4044
4045         [EFL][WK2] Add popup menu support to MiniBrowser
4046         https://bugs.webkit.org/show_bug.cgi?id=108934
4047
4048         Reviewed by Kenneth Rohde Christiansen.
4049
4050         Implement popup menu support in MiniBrowser by handling popup_menu_show
4051         and popup_menu_hide smart functions on the view and using the Ewk popup
4052         menu API.
4053
4054         * MiniBrowser/efl/main.c:
4055         (_Browser_Window):
4056         (on_popup_menu_discarded):
4057         (on_popup_menu_item_clicked):
4058         (popup_menu_populate):
4059         (on_popup_menu_show):
4060         (on_popup_menu_hide):
4061         (window_create): Use calloc() instead of malloc() to allocate memory for
4062         Browser_Window. This makes sure all the structs members are initialized
4063         to 0 (such as the new elm_popup_menu pointer).
4064
4065 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4066
4067         [GTK] Set up the libPlatformGtk.la library
4068         https://bugs.webkit.org/show_bug.cgi?id=111738
4069
4070         Reviewed by Martin Robinson.
4071
4072         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4073         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
4074         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4075
4076 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4077
4078         [GTK] Enable Web Audio in development builds
4079         https://bugs.webkit.org/show_bug.cgi?id=111831
4080
4081         Reviewed by Philippe Normand.
4082
4083         Web Audio is already quite well supported on the GTK port but still has a few issues
4084         that must be addressed before it is enabled by default. Despite that it should be enabled
4085         in development builds just so we are up-to-date with future feature infrastructure changes.
4086         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4087         that's an obvious goal before enabling the feature in release builds.
4088
4089         * Scripts/webkitperl/FeatureList.pm:
4090
4091 2013-03-11  Andreas Kling  <akling@apple.com>
4092
4093         [Mac][WK1] Add support for alert() in MiniBrowser.
4094         <http://webkit.org/b/112090>
4095
4096         Reviewed by Anders Carlsson.
4097
4098         * MiniBrowser/mac/WK1BrowserWindowController.m:
4099         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4100
4101 2013-03-11  Julie Parent  <jparent@chromium.org>
4102
4103         Dashboard cleanup: Create ui.Errors
4104         https://bugs.webkit.org/show_bug.cgi?id=111785
4105
4106         Reviewed by Ojan Vafai.
4107         
4108         Create ui.Errors for handling errors the dashboards
4109         encounter. Loader now has a Error object that it can add to,
4110         and individual dashboards can show errors when desired.
4111         Currently, only flakiness_db shows errors, but this is 
4112         generic and there is no reason why other dbs wouldn't want to
4113         show errors.
4114
4115         * TestResultServer/static-dashboards/dashboard_base.js:
4116         (resourceLoadingComplete):
4117         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4118         (generatePage):
4119         * TestResultServer/static-dashboards/loader.js:
4120         (.):
4121         * TestResultServer/static-dashboards/ui.js:
4122         (.):
4123
4124 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4125
4126         Some StringHasher tests are broken because of missing null termination
4127         https://bugs.webkit.org/show_bug.cgi?id=111284
4128
4129         Reviewed by Darin Adler.
4130
4131         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4132         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4133         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4134         the bug caught by it is now fixed.
4135
4136 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4137
4138         Unreviewed, rolling out r145200.
4139         http://trac.webkit.org/changeset/145200
4140         https://bugs.webkit.org/show_bug.cgi?id=112063
4141
4142         Broke a couple of unit tests (Requested by zdobersek on
4143         #webkit).
4144
4145         * Scripts/webkitperl/FeatureList.pm:
4146
4147 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4148
4149         [GTK] WebKit2-only build fails
4150         https://bugs.webkit.org/show_bug.cgi?id=112033
4151
4152         Reviewed by Gustavo Noronha Silva.
4153
4154         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4155         generic part, WebKit1-specific part and WebKit2-specific part.
4156         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4157         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4158         directly.
4159
4160 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4161
4162         Adding myself to the committers list.
4163
4164         Unreviewed.
4165
4166         * Scripts/webkitpy/common/config/committers.py:
4167
4168 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4169
4170         [BlackBerry] Disable MathML support
4171         https://bugs.webkit.org/show_bug.cgi?id=111929
4172
4173         Reviewed by Rob Buis.
4174
4175         * Scripts/webkitperl/FeatureList.pm:
4176
4177 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4178
4179         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4180         https://bugs.webkit.org/show_bug.cgi?id=111970
4181
4182         Reviewed by Chris Fleizach.
4183
4184         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4185         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4186         undefined symbol.
4187
4188         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4189         (WTR::AccessibilityUIElement::supportedActions):
4190         (WTR):
4191
4192 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4193
4194         [chromium] Android apk targets should depend directly on Java library targets
4195         https://bugs.webkit.org/show_bug.cgi?id=111746
4196
4197         Reviewed by Eric Seidel.
4198
4199         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4200         Make DumpRenderTree_apk depend directly on base_java and net_java.
4201         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4202         Make TestWebKitAPI_apk depend directly on base_java.
4203
4204 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4205
4206         [chromium] remove obsolete user gesture methods from WebFrame
4207         https://bugs.webkit.org/show_bug.cgi?id=111696
4208
4209         Reviewed by Adam Barth.
4210
4211         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4212         (WebTestRunner::TestPlugin::handleInputEvent):
4213         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4214
4215 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
4216
4217         Unreviewed, add myself to commiters.py.
4218
4219         * Scripts/webkitpy/common/config/committers.py:
4220
4221 2013-03-08  Julie Parent  <jparent@chromium.org>
4222
4223         Cleanup: Remove dead code.
4224         https://bugs.webkit.org/show_bug.cgi?id=111900
4225
4226         Reviewed by Dirk Pranke.
4227         
4228         Treemap overrides a global function that used to be in 
4229         dashboard_base, but was removed months ago in
4230         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
4231         no caller. 
4232
4233         * TestResultServer/static-dashboards/treemap.html:
4234
4235 2013-03-08  Harald Alvestrand  <hta@chromium.org>
4236
4237         Implemented new API for RTCStatsReport object.
4238         https://bugs.webkit.org/show_bug.cgi?id=110333
4239
4240         Reviewed by Adam Barth.
4241
4242         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4243         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4244
4245 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
4246
4247         [chromium] use custom freetype on linux asan builds again
4248         https://bugs.webkit.org/show_bug.cgi?id=111884
4249
4250         Reviewed by Tony Chang.
4251
4252         We no longer need the workaround after chromium r186540.
4253
4254         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4255
4256 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
4257
4258         Warning about the user not having edit rights on Bugzilla is confusing new contributors
4259         https://bugs.webkit.org/show_bug.cgi?id=111798
4260
4261         Reviewed by Dirk Pranke.
4262
4263         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
4264
4265         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4266
4267 2013-03-08  James Robinson  <jamesr@chromium.org>
4268
4269         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
4270         https://bugs.webkit.org/show_bug.cgi?id=111632
4271
4272         Reviewed by Adrienne Walker.
4273
4274         * DumpRenderTree/chromium/WebViewHost.cpp:
4275         (WebViewHost::initializeLayerTreeView):
4276         * DumpRenderTree/chromium/WebViewHost.h:
4277         (WebViewHost):
4278
4279 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
4280
4281         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
4282         https://bugs.webkit.org/show_bug.cgi?id=111297
4283
4284         Reviewed by Kenneth Rohde Christiansen.
4285
4286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4287         (WTR::TestRunner::setViewModeMediaFeature):
4288
4289 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
4290
4291         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
4292         https://bugs.webkit.org/show_bug.cgi?id=111814