Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2
3         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
4         https://bugs.webkit.org/show_bug.cgi?id=196948
5
6         Reviewed by Zalan Bujtas.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
9         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
10
11 2019-04-15  Chris Dumez  <cdumez@apple.com>
12
13         URL set by document.open() is not communicated to the UIProcess
14         https://bugs.webkit.org/show_bug.cgi?id=196941
15         <rdar://problem/49237544>
16
17         Reviewed by Geoffrey Garen.
18
19         Add API test coverage.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
23         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
24         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
25         (TEST):
26
27 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
28
29         Using Tools/Scripts/clean-webkit should not install requests
30         https://bugs.webkit.org/show_bug.cgi?id=196940
31
32         Reviewed by Lucas Forschler.
33
34         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
35         existing, depending on the path autoinstalled is run through.
36         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
37         needed.
38         (Port.configuration_for_upload):
39         (Port.commits_for_upload):
40
41 2019-04-15  Alex Christensen  <achristensen@webkit.org>
42
43         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
44         https://bugs.webkit.org/show_bug.cgi?id=196773
45
46         Reviewed by Jer Noble.
47
48         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
49         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
50         (TEST):
51
52 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
53
54         ews-build should clearly indicate flaky test failures
55         https://bugs.webkit.org/show_bug.cgi?id=196947
56
57         Reviewed by Lucas Forschler.
58
59         * BuildSlaveSupport/ews-build/steps.py:
60         (AnalyzeAPITestsResults.analyzeResults):
61
62 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
63
64         InjectedBundle parameters often need initialization function called before unarchiving
65         https://bugs.webkit.org/show_bug.cgi?id=189709
66         <rdar://problem/44573653>
67
68         Reviewed by Ryosuke Niwa.
69
70         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
71         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
72
73 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
74
75         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
76         https://bugs.webkit.org/show_bug.cgi?id=196681
77
78         Reviewed by Darin Adler.
79
80         Added tests.
81
82         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
83         (WTF_HashSet.RemoveIf):
84         (WTF_HashSet.RemoveIfShrinkToBestSize):
85
86 2019-04-15  John Wilander  <wilander@apple.com>
87
88         Send delayed Ad Click Attribution conversion requests to the click source
89         https://bugs.webkit.org/show_bug.cgi?id=196838
90         <rdar://problem/47650157>
91
92         Reviewed by Chris Dumez and Youenn Fablet.
93
94         This patch adds test infrastructure to override the default behavior in
95         WebKit::NetworkAdClickAttribution.
96
97         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
98         (TestWebKitAPI::TEST):
99         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
101         (WTR::TestRunner::dumpAdClickAttribution):
102         (WTR::TestRunner::clearAdClickAttribution):
103         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
104         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
106         * WebKitTestRunner/TestController.cpp:
107         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
108         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
109         * WebKitTestRunner/TestController.h:
110         * WebKitTestRunner/TestInvocation.cpp:
111         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
112
113 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
114
115         [ews-app] status-bubble should display position in queue
116         https://bugs.webkit.org/show_bug.cgi?id=196607
117
118         Reviewed by Lucas Forschler.
119
120         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
121         (StatusBubble._build_bubble):
122         (StatusBubble._queue_position): Method to calculate patch's position in queue.
123
124 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
125
126         [ews-build] Do not run clean build by default on EWS builders
127         https://bugs.webkit.org/show_bug.cgi?id=196897
128
129         Reviewed by Lucas Forschler.
130
131         * BuildSlaveSupport/ews-build/steps.py:
132         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
133         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
134         untracked directories like WebKitBuild).
135         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
136         untracked files/directories (like WebKitBuild).
137
138 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
139
140         TestRunner::notifyDone() should be safely reentrant
141         https://bugs.webkit.org/show_bug.cgi?id=196898
142
143         Reviewed by Darin Adler.
144
145         It is currently possible that TestRunner::notifyDone() will call itself, since
146         notifyDone() will force a repaint, which can start executing JavaScript, which
147         may call notifyDone() again. This can lead to test failures and flakiness.
148         Fix this by setting the m_waitToDump flag before calling the dump() method.
149
150         * DumpRenderTree/mac/TestRunnerMac.mm:
151         (TestRunner::notifyDone):
152         (TestRunner::forceImmediateCompletion):
153         * DumpRenderTree/win/TestRunnerWin.cpp:
154         (TestRunner::notifyDone):
155         (TestRunner::forceImmediateCompletion):
156
157 2019-04-15  Philippe Normand  <pnormand@igalia.com>
158
159         [GTK][WPE] Add enable-media websetting
160         https://bugs.webkit.org/show_bug.cgi?id=196863
161
162         Reviewed by Michael Catanzaro.
163
164         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
165         (testWebKitSettings): Add test for the enable-media web-setting.
166
167 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
168
169         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
170         https://bugs.webkit.org/show_bug.cgi?id=196905
171         <rdar://problem/49886096>
172
173         Reviewed by Tim Horton.
174
175         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
176         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
177         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
178         delay timer, we end up with this sequence of events in the problematic (failure) case:
179
180         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
181             ...IPC from UI to web process...
182         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
183             ...IPC from web to UI process...
184         (c) [UI]    Invoke completion handler for script #1
185         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
186             ...IPC from UI to web process...
187         (e) [Web]   Evaluate script #2 in the web process
188         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
189
190         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
191         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
192         #2 is run in step (e).
193
194         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
195         the UI process by waiting on a script message posted by the web process, after attachment updates are
196         dispatched.
197
198         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
199         (TestWebKitAPI::TEST):
200
201 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
202
203         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
204         https://bugs.webkit.org/show_bug.cgi?id=196909
205
206         Reviewed by Wenson Hsieh.
207
208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
209         (TestWebKitAPI::TEST):
210
211 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
212
213         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
214         https://bugs.webkit.org/show_bug.cgi?id=196880
215
216         Reviewed by Yusuke Suzuki.
217
218         Add a new function for bytecode cache tests that does not forceDiskCache
219         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
220         test added in this patch, since the code is invalid and therefore won't be
221         cached. It should also be useful for tests that evaluate dynamically
222         generated code.
223
224         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
225         * Scripts/run-jsc-stress-tests:
226
227 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
228
229         Update AudioSession route sharing policy
230         https://bugs.webkit.org/show_bug.cgi?id=196776
231         <rdar://problem/46501611>
232
233         Reviewed by Jer Noble.
234
235         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
236         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
237         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
238         (TestWebKitAPI::TEST):
239
240 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
241
242         [iOS] Software keyboard is shown too frequently on some websites
243         https://bugs.webkit.org/show_bug.cgi?id=195856
244         <rdar://problem/49191395>
245
246         Reviewed by Darin Adler.
247
248         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
249
250         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
251         (WTR::UIScriptController::setHardwareKeyboardAttached):
252         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
253         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
254         (WTR::UIScriptController::setHardwareKeyboardAttached):
255         * TestRunnerShared/UIScriptContext/UIScriptController.h:
256         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
257
258         Additionally link against GraphicsServices in WebKitTestRunner.
259
260         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
261         (WTR::TestController::platformResetStateToConsistentValues):
262         (WTR::UIScriptController::setHardwareKeyboardAttached):
263
264 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
265
266         [GTK][WPE] Fix pacman install-dependencies packages
267         https://bugs.webkit.org/show_bug.cgi?id=196817
268
269         Reviewed by Žan Doberšek.
270         
271         python3-setuptools is called python-setuptools
272         ruby-highline is only available on AUR
273         libv4l-devel is incorporated in v4l-utils
274
275         * gtk/install-dependencies:
276         * wpe/install-dependencies:
277
278 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
279
280         [GTK] REGRESSION(r243860): Many tests failing
281         https://bugs.webkit.org/show_bug.cgi?id=196791
282
283         Reviewed by Joanmarie Diggs.
284
285         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
286         multiple documents and check that accessibility hierarchy is updated after a navigation.
287
288         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
289         (loadChangedCallback):
290         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
291         (AccessibilityTest::AccessibilityTest):
292         (AccessibilityTest::~AccessibilityTest):
293         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
294         (AccessibilityTest::findTestServerApplication):
295         (AccessibilityTest::findDocumentWeb):
296         (AccessibilityTest::findRootObject):
297         (AccessibilityTest::waitUntilChildrenRemoved):
298         (AccessibilityTest::ensureProxy):
299         (testAtspiBasicHierarchy):
300         (beforeAll):
301         (afterAll):
302
303 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
304
305         [ews-build] Handle bug titles with unicode characters
306         https://bugs.webkit.org/show_bug.cgi?id=196802
307
308         Reviewed by Dewei Zhu.
309
310         * BuildSlaveSupport/ews-build/steps.py:
311         (ValidatePatch._is_bug_closed):
312
313 2019-04-11  Michael Saboff  <msaboff@apple.com>
314
315         Improve the Inline Cache Stats code
316         https://bugs.webkit.org/show_bug.cgi?id=196836
317
318         Reviewed by Saam Barati.
319
320         Added a new script to consolidate and arrange the output of --useICStats option.
321
322         This script merges the output from every group into one large table and sorts it from most common to
323         least common.  It also counts the slow path GetById and PutById variants and then calculates the
324         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
325         Put together, this is useful to see what property accesses are not getting cached.
326
327         * Scripts/ic-stats.py: Added.
328         (ICStats):
329         (ICStats.__init__):
330         (ICStats.parse):
331         (ICStats.dumpStats):
332         (usage):
333
334 2019-04-10  Alex Christensen  <achristensen@webkit.org>
335
336         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
337         https://bugs.webkit.org/show_bug.cgi?id=196809
338         <rdar://49800762>
339
340         Reviewed by Brady Eidson.
341
342         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
343         (TEST):
344
345 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
346
347         requestAnimationFrame should execute before the next frame
348         https://bugs.webkit.org/show_bug.cgi?id=177484
349
350         Reviewed by Simon Fraser.
351
352         Add trace points for the page RenderingUpdate.
353
354         * Tracing/SystemTracePoints.plist:
355
356 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
357
358         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
359         https://bugs.webkit.org/show_bug.cgi?id=196760
360
361         Reviewed by Don Olmstead.
362
363         vswhere.exe has been bundled since Visual Studio 2017 version
364         15.2. We shouldn't download vswhere.exe.
365
366         * Scripts/build-jsc: Do not call update-vswhere.py.
367         * Scripts/build-webkit: Ditto.
368         * Scripts/update-vswhere.py: Removed.
369         * Scripts/webkitdirs.pm:
370         (requireModulesForVSWhere): Deleted.
371         (pickCurrentVisualStudioInstallation): Deleted.
372         (visualStudioInstallDirVSWhere): Return the latest installed VS
373         installation path by using the bundled vswhere.exe.
374         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
375         (visualStudioInstallDirFallback): Removed.
376
377 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
378
379         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
380         https://bugs.webkit.org/show_bug.cgi?id=196780
381
382         Reviewed by Alexey Proskuryakov.
383
384         * BuildSlaveSupport/ews-build/steps.py:
385         * BuildSlaveSupport/ews-build/steps_unittest.py:
386
387 2019-04-10  Alex Christensen  <achristensen@webkit.org>
388
389         Add SPI WKNavigationResponse._downloadAttribute
390         https://bugs.webkit.org/show_bug.cgi?id=196755
391         <rdar://49587365>
392
393         Reviewed by Brady Eidson.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
396         (-[NavigationResponseTestDelegate navigationResponse]):
397         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
398         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
399         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
400         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
401         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
402         (readRequest):
403         (writeResponse):
404         (TEST):
405
406 2019-04-10  Tim Horton  <timothy_horton@apple.com>
407
408         Add modern API for overriding the page's specified viewport configuration
409         https://bugs.webkit.org/show_bug.cgi?id=167734
410         <rdar://problem/30331795>
411
412         Reviewed by Simon Fraser.
413
414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
415         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
416
417 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
418
419         Add support for incremental bytecode cache updates
420         https://bugs.webkit.org/show_bug.cgi?id=195000
421
422         Reviewed by Filip Pizlo.
423
424         Exit when the initial run to generate bytecode fails.
425
426         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
427
428 2019-04-10  Alex Christensen  <achristensen@webkit.org>
429
430         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
431         https://bugs.webkit.org/show_bug.cgi?id=196744
432         <rdar://49415309>
433
434         Reviewed by Chris Dumez.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
437         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
438
439 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
440
441         Add a way to opt into modern compatibility mode in layout tests
442         https://bugs.webkit.org/show_bug.cgi?id=196770
443         <rdar://problem/49777550>
444
445         Reviewed by Antoine Quint.
446
447         Add a new test option to enable modern compatibility mode in layout tests.
448
449         * WebKitTestRunner/TestController.cpp:
450         (WTR::updateTestOptionsFromTestHeader):
451         * WebKitTestRunner/TestController.h:
452         * WebKitTestRunner/TestOptions.h:
453         (WTR::TestOptions::hasSameInitializationOptions const):
454         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
455         (WTR::TestController::platformCreateWebView):
456         (WTR::TestController::enableModernCompatibilityMode):
457
458 2019-04-10  Andy Estes  <aestes@apple.com>
459
460         Try to fix the 32-bit watchOS build.
461
462         * TestWebKitAPI/cocoa/TestWKWebView.mm:
463         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
464
465 2019-04-10  Antoine Quint  <graouts@apple.com>
466
467         Enable Pointer Events on watchOS
468         https://bugs.webkit.org/show_bug.cgi?id=196771
469         <rdar://problem/49040909>
470
471         Reviewed by Dean Jackson.
472
473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
474
475 2019-04-10  Philippe Normand  <pnormand@igalia.com>
476
477         Unreviewed. Fix WPE accessibility tests after r244059.
478
479         We are failing to load the injected bundle due to undefined symbol
480         AccessibilityUIElement::replaceTextInRange().
481
482         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
483         (WTR::AccessibilityUIElement::replaceTextInRange):
484
485 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
486
487         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
488         https://bugs.webkit.org/show_bug.cgi?id=196727
489
490         Reviewed by Fujii Hironori.
491
492         * MiniBrowser/win/WebKitBrowserWindow.cpp:
493         (WebKitBrowserWindow::create):
494
495 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
496
497         [ews-build] Add unit tests for PrintConfiguration
498         https://bugs.webkit.org/show_bug.cgi?id=196752
499
500         Reviewed by Dewei Zhu.
501
502         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
503
504 2019-04-09  Keith Rollin  <krollin@apple.com>
505
506         Unreviewed build maintenance -- update .xcfilelists.
507
508         * DumpRenderTree/DerivedSources-input.xcfilelist:
509         * DumpRenderTree/DerivedSources-output.xcfilelist:
510
511 2019-04-09  Zalan Bujtas  <zalan@apple.com>
512
513         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
514         https://bugs.webkit.org/show_bug.cgi?id=196743
515         <rdar://problem/43897551>
516
517         Reviewed by Tim Horton.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
520         (TEST):
521
522 2019-04-09  Youenn Fablet  <youenn@apple.com>
523
524         Close service worker database on network process suspension
525         https://bugs.webkit.org/show_bug.cgi?id=196623
526         <rdar://problem/48930869>
527
528         Reviewed by Alex Christensen.
529
530         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
531
532 2019-04-09  Daniel Bates  <dabates@apple.com>
533
534         [iPad] Should open popover when the spacebar is pressed
535         https://bugs.webkit.org/show_bug.cgi?id=196360
536         <rdar://problem/49389129>
537
538         Reviewed by Brent Fulgham.
539
540         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
541
542         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
543         (WTR::UIScriptController::isShowingPopover const): Added.
544         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
545         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
546         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
547         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
548         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
549         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
550         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
551         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
552         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
553         (WTR::UIScriptController::isShowingPopover const): Added.
554         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
555         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
556         * TestRunnerShared/UIScriptContext/UIScriptController.h:
557         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
558         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
559         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
560         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
561         (-[TestRunnerWKWebView _willPresentPopover]): Added.
562         (-[TestRunnerWKWebView _didDismissPopover]): Added.
563         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
564         (WTR::UIScriptController::isShowingPopover const): Added.
565         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
566         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
567
568 2019-04-09  Alex Christensen  <achristensen@webkit.org>
569
570         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
571         https://bugs.webkit.org/show_bug.cgi?id=196665
572         <rdar://45115669>
573
574         Reviewed by Geoff Garen.
575
576         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
577         (goBack):
578         (+[SimpleLookupContext sharedLookupContext]):
579         (-[SimpleLookupContext lookUpURL:completionHandler:]):
580         (TEST):
581         (+[Simple3LookupContext sharedLookupContext]): Deleted.
582         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
583
584 2019-04-09  John Wilander  <wilander@apple.com>
585
586         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
587         https://bugs.webkit.org/show_bug.cgi?id=196558
588         <rdar://problem/47650245>
589
590         Reviewed by Youenn Fablet.
591
592         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
593         (TestWebKitAPI::TEST):
594             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
595
596 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
597
598         [CMake] Apple builds should use ICU_INCLUDE_DIRS
599         https://bugs.webkit.org/show_bug.cgi?id=196720
600
601         Reviewed by Konstantin Tokarev.
602
603         * TestWebKitAPI/PlatformMac.cmake:
604
605 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
606
607         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
608         https://bugs.webkit.org/show_bug.cgi?id=196694
609         <rdar://problem/48388734>
610
611         Rubber-stamped by Aakash Jain.
612
613         * Scripts/webkitpy/port/image_diff.py:
614         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
615         * Scripts/webkitpy/port/server_process.py:
616         (ServerProcess.has_available_stdout): Check if stdout has data in it.
617         (ServerProcess._wait_for_data_and_update_buffers_using_select):
618         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
619         * Scripts/webkitpy/port/server_process_mock.py:
620         (MockServerProcess.has_available_stdout):
621         * Scripts/webkitpy/port/server_process_unittest.py:
622         (TestServerProcess.serial_test_basic):
623
624 2019-04-09  Jer Noble  <jer.noble@apple.com>
625
626         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
627         https://bugs.webkit.org/show_bug.cgi?id=196097
628
629         Reviewed by Eric Carlson.
630
631         Drive-by bug fix: allow tests to play audio without a user gesture by default.
632
633         * DumpRenderTree/mac/DumpRenderTree.mm:
634         (resetWebPreferencesToConsistentValues):
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::TestController::resetPreferencesToConsistentValues):
637
638 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
639
640         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
641         https://bugs.webkit.org/show_bug.cgi?id=196690
642
643         Reviewed by Michael Catanzaro.
644
645         * QueueStatusServer/config/queues.py:
646         * Scripts/webkitpy/common/config/ews.json:
647         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
648         (test_ews_name):
649
650 2019-04-09  Chris Dumez  <cdumez@apple.com>
651
652         Loads using loadHTMLString() cause flashing when process-swapping
653         https://bugs.webkit.org/show_bug.cgi?id=196714
654         <rdar://problem/49637354>
655
656         Reviewed by Antti Koivisto.
657
658         Add API test coverage.
659
660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
661
662 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
663
664         Unreviewed. Fix ATK accessibility tests after r244059.
665
666         We are failing to load the injected bundle due to undefined symbol
667         AccessibilityUIElement::replaceTextInRange().
668
669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
670         (WTR::AccessibilityUIElement::replaceTextInRange):
671
672 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
673
674         AX: Support API: accessibilityReplaceRange:withText
675         https://bugs.webkit.org/show_bug.cgi?id=196636
676
677         Unreviewed build fix for Windows port.
678
679         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
680         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
681
682 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
683
684         [CMake][WinCairo] Separate copied headers into different directories
685         https://bugs.webkit.org/show_bug.cgi?id=196655
686
687         Reviewed by Michael Catanzaro.
688
689         * DumpRenderTree/CMakeLists.txt:
690         * MiniBrowser/win/CMakeLists.txt:
691         * TestWebKitAPI/CMakeLists.txt:
692         * TestWebKitAPI/PlatformWin.cmake:
693
694 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
695
696         Log stack-trace for run-webkit-tests when interrupted
697         https://bugs.webkit.org/show_bug.cgi?id=176393
698         <rdar://problem/34262310>
699
700         Reviewed by Lucas Forschler.
701
702         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
703         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
704         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
705         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
706         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
707         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
708         (main): Set handlers to log stack trace on interruption.
709
710 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
711
712         AX: Support API: accessibilityReplaceRange:withText
713         https://bugs.webkit.org/show_bug.cgi?id=196636
714
715         Unreviewed build fix for Windows port.
716
717         * DumpRenderTree/AccessibilityUIElement.cpp:
718         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
719
720 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
721
722         [ews-build] Scripts using Buildbot API have CORS error
723         https://bugs.webkit.org/show_bug.cgi?id=196709
724
725         Reviewed by Alexey Proskuryakov.
726
727         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
728
729 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
730
731         AX: Support API: accessibilityReplaceRange:withText
732         https://bugs.webkit.org/show_bug.cgi?id=196636
733
734         Reviewed by Daniel Bates.
735
736         * DumpRenderTree/AccessibilityUIElement.cpp:
737         (replaceTextInRangeCallback):
738         (AccessibilityUIElement::replaceTextInRange):
739         (AccessibilityUIElement::getJSClass):
740         * DumpRenderTree/AccessibilityUIElement.h:
741         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
742         (AccessibilityUIElement::replaceTextInRange):
743         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
744         (AccessibilityUIElement::replaceTextInRange):
745         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
746         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
747         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
748         (WTR::AccessibilityUIElement::replaceTextInRange):
749         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
750         (WTR::AccessibilityUIElement::replaceTextInRange):
751
752 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
753
754         [iOS] Do not allow starting selection drags when selection views are not visible
755         https://bugs.webkit.org/show_bug.cgi?id=196686
756         <rdar://problem/49399192>
757
758         Reviewed by Tim Horton.
759
760         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
761         also add some new API tests to cover scenarios where the web view is not first responder.
762
763         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
764         (TestWebKitAPI::TEST):
765         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
766
767         Add a switch to optionally make the web view first responder when starting the simulated drag.
768
769         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
770         (-[DragAndDropSimulator initWithWebView:]):
771         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
772
773 2019-04-08  Justin Fan  <justin_fan@apple.com>
774
775         [Web GPU] Fix Web GPU experimental feature on iOS
776         https://bugs.webkit.org/show_bug.cgi?id=196632
777
778         Reviewed by Myles C. Maxfield.
779
780         Properly make Web GPU available on iOS 11+.
781
782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
783
784 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-build] Do not upload archive when Compile Fails
787         https://bugs.webkit.org/show_bug.cgi?id=196674
788
789         Reviewed by Alexey Proskuryakov.
790
791         * BuildSlaveSupport/ews-build/factories.py:
792         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
793         * BuildSlaveSupport/ews-build/steps.py:
794         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
795         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
796         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
797
798 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
799
800         Enable DFG on MIPS
801         https://bugs.webkit.org/show_bug.cgi?id=196689
802
803         Reviewed by Žan Doberšek.
804
805         Since the bytecode change, we enabled the baseline JIT on mips in
806         r240432, but DFG is still missing. With this change, all tests are
807         passing on a ci20 board.
808
809         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
810
811 2019-04-08  Philippe Normand  <pnormand@igalia.com>
812
813         [Flatpak] Second run update-webkitwpe-flatpak fails
814         https://bugs.webkit.org/show_bug.cgi?id=192702
815
816         Reviewed by Carlos Garcia Campos.
817
818         * flatpak/flatpakutils.py:
819         (FlatpakObject.flatpak): Fix typo.
820         (FlatpakPackage.install): When installing, also update to the configured remote commit.
821         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
822
823 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
824
825         [GTK][WPE] outlook.live.com displays old-fashioned UI
826         https://bugs.webkit.org/show_bug.cgi?id=196642
827
828         Reviewed by Carlos Garcia Campos.
829
830         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
831         (TestWebKitAPI::TEST): New Mac platform quirk test.
832
833 2019-04-07  Commit Queue  <commit-queue@webkit.org>
834
835         Unreviewed, rolling out r243956.
836         https://bugs.webkit.org/show_bug.cgi?id=196688
837
838         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
839         by aakashjain on #webkit).
840
841         Reverted changeset:
842
843         "Clicking "Go Back" from a safe browsing warning from an
844         iframe should navigate the WKWebView back to the previous
845         page"
846         https://bugs.webkit.org/show_bug.cgi?id=196665
847         https://trac.webkit.org/changeset/243956
848
849 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
850
851         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
852         https://bugs.webkit.org/show_bug.cgi?id=196669
853
854         Reviewed by Geoffrey Garen.
855
856         Added three new unit tests for WeakHashSet.
857
858         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
859         (WTF_WeakPtr.WeakHashSetConstObjects):
860         (WTF_WeakPtr.WeakHashSetComputesEmpty):
861         (WTF_WeakPtr.WeakHashSetComputeSize):
862
863 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
864
865         Hide next and previous form control buttons when WKWebView is editable
866         https://bugs.webkit.org/show_bug.cgi?id=196672
867         <rdar://problem/35625321>
868
869         Reviewed by Tim Horton.
870
871         Add a new API test.
872
873         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
874         (-[TestWKWebView lastTrailingBarButtonGroup]):
875         (TestWebKitAPI::TEST):
876         * TestWebKitAPI/ios/UIKitSPI.h:
877
878 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
879
880         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
881         https://bugs.webkit.org/show_bug.cgi?id=196077
882         <rdar://problem/49108202>
883
884         Reviewed by Chris Dumez.
885
886         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
887         on new web view.
888
889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
890
891 2019-04-05  Saam Barati  <sbarati@apple.com>
892
893         Make compare-results understand MotionMark
894         https://bugs.webkit.org/show_bug.cgi?id=196666
895
896         Reviewed by Yusuke Suzuki.
897
898         * Scripts/compare-results:
899         (PLT5Results):
900         (detectMotionMark):
901         (detectMotionMark1_1):
902         (motionMarkResults):
903         (motionMark1_1Results):
904         (detectBenchmark):
905         (biggerIsBetter):
906         (main):
907
908 2019-04-05  Alex Christensen  <achristensen@webkit.org>
909
910         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
911         https://bugs.webkit.org/show_bug.cgi?id=196665
912         <rdar://45115669>
913
914         Reviewed by Geoff Garen.
915
916         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
917         (goBack):
918         (+[SimpleLookupContext sharedLookupContext]):
919         (-[SimpleLookupContext lookUpURL:completionHandler:]):
920         (TEST):
921         (+[Simple3LookupContext sharedLookupContext]): Deleted.
922         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
923
924 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
925
926         [ews-build] Add configuration and architecture for windows builders
927         https://bugs.webkit.org/show_bug.cgi?id=196660
928
929         Reviewed by Lucas Forschler.
930
931         * BuildSlaveSupport/ews-build/config.json:
932
933 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
934
935         webkitpy: Don't run subsequent rounds if interrupted
936         https://bugs.webkit.org/show_bug.cgi?id=196646
937
938         Reviewed by Aakash Jain.
939
940         * Scripts/webkitpy/layout_tests/controllers/manager.py:
941         (Manager.run): Bail out if interrupted.
942
943 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
944
945         Test sessionStorage in PSON private browsing mode
946         https://bugs.webkit.org/show_bug.cgi?id=196561
947
948         Reviewed by Alex Christensen.
949
950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
951
952 2019-04-05  Commit Queue  <commit-queue@webkit.org>
953
954         Unreviewed, rolling out r243833.
955         https://bugs.webkit.org/show_bug.cgi?id=196645
956
957         This change breaks build of WPE and GTK ports (Requested by
958         annulen on #webkit).
959
960         Reverted changeset:
961
962         "[CMake][WTF] Mirror XCode header directories"
963         https://bugs.webkit.org/show_bug.cgi?id=191662
964         https://trac.webkit.org/changeset/243833
965
966 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
967
968         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
969         https://bugs.webkit.org/show_bug.cgi?id=196635
970
971         Reviewed by Antti Koivisto.
972         
973         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
974         for a test to enable async frame scrolling via:
975             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
976         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
977         
978         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
979
980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
981         (WTR::InjectedBundle::beginTesting):
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::resetPreferencesToConsistentValues):
984
985 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
986
987         Use a correct LC_RPATH when building with ASan
988         https://bugs.webkit.org/show_bug.cgi?id=196576
989
990         Reviewed by David Kilzer.
991
992         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
993         so that ../Frameworks is checked. This is simpler and more reliable than updating
994         each SPC service xcconfig.
995
996 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
997
998         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
999         https://bugs.webkit.org/show_bug.cgi?id=196629
1000
1001         Reviewed by Lucas Forschler.
1002
1003         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1004
1005 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1006
1007         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1008         https://bugs.webkit.org/show_bug.cgi?id=196618
1009
1010         Reviewed by Lucas Forschler.
1011
1012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1013         (StatusBubble): Added QUEUE_TRIGGERS.
1014         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1015         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1016         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1017         its parent(builder).
1018
1019 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1020
1021         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1022         https://bugs.webkit.org/show_bug.cgi?id=196625
1023
1024         Reviewed by Lucas Forschler.
1025
1026         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1027         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1028
1029 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1030
1031         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1032         https://bugs.webkit.org/show_bug.cgi?id=196630
1033
1034         Reviewed by Wenson Hsieh.
1035
1036         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1037
1038 2019-04-04  Youenn Fablet  <youenn@apple.com>
1039
1040         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1041         https://bugs.webkit.org/show_bug.cgi?id=196543
1042
1043         Reviewed by Alex Christensen.
1044
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::generatePageConfiguration):
1047
1048 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-app] Status bubble should not display skipped buildbot steps
1051         https://bugs.webkit.org/show_bug.cgi?id=196584
1052
1053         Reviewed by Lucas Forschler.
1054
1055         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1056
1057 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1058
1059         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1060         https://bugs.webkit.org/show_bug.cgi?id=196620
1061
1062         Reviewed by Lucas Forschler.
1063
1064         * BuildSlaveSupport/ews-app/ews/config.py:
1065
1066 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1067
1068         [Win] DumpRenderTreeWatchDog.py is not checked into source
1069         https://bugs.webkit.org/show_bug.cgi?id=196567
1070         <rdar://problem/49525901>
1071
1072         Reviewed by Lucas Forschler.
1073
1074         This script is used on Win EWS bots to terminate hanging DRT processes.
1075
1076         * EWSTools/dumprendertreewatchdog.py: Added.
1077
1078 2019-04-04  Chris Dumez  <cdumez@apple.com>
1079
1080         Unreviewed, roll out r243858 which made tests time out.
1081
1082         Disable new API tests on Windows instead.
1083
1084         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1085         (TestWebKitAPI::TEST):
1086
1087 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1088
1089         [ATK] Cleanup WebPageAccessibilityObjectAtk
1090         https://bugs.webkit.org/show_bug.cgi?id=196537
1091
1092         Reviewed by Michael Catanzaro.
1093
1094         Also consider files under atk directories as exceptions for GObject conventions.
1095
1096         * Scripts/webkitpy/style/checkers/cpp.py:
1097         (check_identifier_name_in_declaration):
1098
1099 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1100
1101         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1102         https://bugs.webkit.org/show_bug.cgi?id=196588
1103         <rdar://problem/49365787>
1104
1105         Unreviewed build fix for Windows port.
1106
1107         error C3861: 'kill': identifier not found
1108
1109         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1110         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1111
1112 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-build] Cancel build and similar operations should have authentication
1115         https://bugs.webkit.org/show_bug.cgi?id=196520
1116
1117         Reviewed by Dewei Zhu.
1118
1119         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1120         environment variables.
1121
1122 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1123
1124         [ews-build] Do not trigger queues which are not in production yet
1125         https://bugs.webkit.org/show_bug.cgi?id=196581
1126
1127         Reviewed by Dewei Zhu.
1128
1129         * BuildSlaveSupport/ews-build/config.json:
1130
1131 2019-04-03  Chris Dumez  <cdumez@apple.com>
1132
1133         Unreviewed, fix typo in the name of API test added in r243848.
1134
1135         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1136         (TestWebKitAPI::TEST):
1137
1138 2019-04-03  Chris Dumez  <cdumez@apple.com>
1139
1140         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1141         https://bugs.webkit.org/show_bug.cgi?id=196588
1142         <rdar://problem/49365787>
1143
1144         Reviewed by Ryosuke Niwa.
1145
1146         Add API test coverage.
1147
1148         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1149         (TestWebKitAPI::nullJavaScriptCallback):
1150         (TestWebKitAPI::didCrashCheckFrames):
1151         (TestWebKitAPI::TEST):
1152
1153 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1154
1155         run-webkit-tests: Upload test results (new results database)
1156         https://bugs.webkit.org/show_bug.cgi?id=196577
1157         <rdar://problem/34841155>
1158
1159         Reviewed by Lucas Forschler.
1160
1161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1162         (Manager.run): Upload results after each device shard, since the configuration will be
1163         different for each device.
1164         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1165         uploaded to a results database.
1166         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1167         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1168
1169 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1170
1171         -apple-trailing-word is needed for browser detection
1172         https://bugs.webkit.org/show_bug.cgi?id=196575
1173
1174         Unreviewed.
1175
1176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1177
1178 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1179
1180         [CMake][WTF] Mirror XCode header directories
1181         https://bugs.webkit.org/show_bug.cgi?id=191662
1182
1183         Reviewed by Konstantin Tokarev.
1184
1185         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1186         builds.
1187
1188         * CMakeLists.txt:
1189         * DumpRenderTree/CMakeLists.txt:
1190         * DumpRenderTree/PlatformWin.cmake:
1191         * MiniBrowser/win/CMakeLists.txt:
1192         * TestWebKitAPI/CMakeLists.txt:
1193         * TestWebKitAPI/PlatformWin.cmake:
1194         * WebKitTestRunner/PlatformGTK.cmake:
1195         * WebKitTestRunner/PlatformWin.cmake:
1196
1197 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1198
1199         [ews-app] Status bubble should not display certain infrastructure status messages
1200         https://bugs.webkit.org/show_bug.cgi?id=196550
1201
1202         Reviewed by Lucas Forschler.
1203
1204         Do not display the steps which are un-needed for end-user. This information is still avaiable
1205         if the user click on the bubble and look at the Buildbot build.
1206         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1207         (StatusBubble._steps_messages):
1208         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1209
1210 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-build] Use https for sending data to ews-app
1213         https://bugs.webkit.org/show_bug.cgi?id=196492
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-build/events.py:
1218
1219 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1220
1221         Remove support for -apple-trailing-word
1222         https://bugs.webkit.org/show_bug.cgi?id=196525
1223
1224         Reviewed by Zalan Bujtas.
1225
1226         This CSS property is nonstandard and not used.
1227
1228         * Scripts/webkitperl/FeatureList.pm:
1229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1230
1231 2019-04-03  Youenn Fablet  <youenn@apple.com>
1232
1233         Add a test for DOMCache on multiple browsing in case of private browsing
1234         https://bugs.webkit.org/show_bug.cgi?id=196524
1235
1236         Reviewed by Alex Christensen.
1237
1238         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1239         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1240
1241 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1242
1243         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1244         https://bugs.webkit.org/show_bug.cgi?id=196540
1245
1246         Reviewed by Aakash Jain.
1247
1248         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1249
1250 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1251
1252         Add plumbing for a compatibility mode preference in WebKit
1253         https://bugs.webkit.org/show_bug.cgi?id=196005
1254
1255         Reviewed by Tim Horton.
1256
1257         Add new API tests.
1258
1259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1260         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1261
1262 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1263
1264         [WPE][GTK] Update libsrtp dependency package for Debian
1265         https://bugs.webkit.org/show_bug.cgi?id=196528
1266
1267         Reviewed by Frédéric Wang.
1268
1269         * gtk/install-dependencies:
1270         * wpe/install-dependencies:
1271
1272 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1273
1274         [WK2] Add support for Window's beforeprint / afterprint events
1275         https://bugs.webkit.org/show_bug.cgi?id=196478
1276         <rdar://problem/49535124>
1277
1278         Unreviewed build fix for MSVC.
1279
1280         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1281
1282         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1283
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::printFrame): Use int and float literals.
1286
1287 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1288
1289         [ews-build] Reassign bots to queues
1290
1291         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1292
1293 2019-04-02  Chris Dumez  <cdumez@apple.com>
1294
1295         [WK2] Add support for Window's beforeprint / afterprint events
1296         https://bugs.webkit.org/show_bug.cgi?id=196478
1297
1298         Reviewed by Alex Christensen.
1299
1300         Add minimal implementation for printFrame in WebKitTestRunner.
1301
1302         * WebKitTestRunner/TestController.cpp:
1303         (WTR::printFrame):
1304         (WTR::TestController::createOtherPage):
1305         (WTR::TestController::createWebViewWithOptions):
1306
1307 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1308
1309         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1310         https://bugs.webkit.org/show_bug.cgi?id=196491
1311
1312         Reviewed by Lucas Forschler.
1313
1314         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1315
1316 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1317
1318         [ews-build] Configure buildbot try credentials in environment variables
1319         https://bugs.webkit.org/show_bug.cgi?id=196501
1320
1321         Reviewed by Lucas Forschler.
1322
1323         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1324         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1325         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1326
1327 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1328
1329         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1330         https://bugs.webkit.org/show_bug.cgi?id=196496
1331         <rdar://problem/49521634>
1332
1333         Reviewed by Chris Dumez.
1334
1335         Add new API tests (see WebKit ChangeLog for more detail).
1336
1337         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1338         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1339         (TEST):
1340
1341 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1342
1343         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1344         <https://webkit.org/b/196499>
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1349         ENABLE_ADDRESS_SANITIZER.
1350
1351 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1352
1353         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1354         https://bugs.webkit.org/show_bug.cgi?id=182757
1355
1356         Reviewed by Don Olmstead.
1357
1358         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1359         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1360
1361 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1362
1363         run-api-tests: Upload test results
1364         https://bugs.webkit.org/show_bug.cgi?id=196323
1365         <rdar://problem/49356714>
1366
1367         Reviewed by Lucas Forschler.
1368
1369         * Scripts/webkitpy/api_tests/manager.py:
1370         (Manager):
1371         (Manager.run): Upload results to a results database.
1372         * Scripts/webkitpy/api_tests/run_api_tests.py:
1373         (parse_args): Add upload arguments.
1374         * Scripts/webkitpy/port/base.py:
1375         (Port):
1376         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1377         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1378         with commits from any other associated repositories.
1379         * Scripts/webkitpy/port/device.py:
1380         (Device):
1381         (Device.build_version): Access build_versoin of underlying platform device.
1382         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1383         (IOSSimulatorTest):
1384         (IOSSimulatorTest.test_configuration_for_upload):
1385         * Scripts/webkitpy/port/device_port.py:
1386         (DevicePort):
1387         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1388         the same as the machine uploading results.
1389         * Scripts/webkitpy/port/mac.py:
1390         (MacPort):
1391         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1392         * Scripts/webkitpy/port/mac_unittest.py:
1393         (MacTest):
1394         (MacTest.test_configuration_for_upload):
1395         * Scripts/webkitpy/xcode/simulated_device.py:
1396         (SimulatedDeviceManager._create_device_with_runtime):
1397         (SimulatedDevice.__init__): Create simulated device with a build_version.
1398         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1399         (test_existing_simulator):
1400
1401 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1402
1403         Remove extra newline characters (Follow-up fix to r243707)
1404
1405         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1406
1407 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1408
1409         [ews-app] Use API_KEY to accept results data
1410         https://bugs.webkit.org/show_bug.cgi?id=196461
1411
1412         Reviewed by Dewei Zhu.
1413
1414         * BuildSlaveSupport/ews-app/ews/views/results.py:
1415         (Results.post): Validate EWS_API_KEY before accepting any data.
1416         * BuildSlaveSupport/ews-build/events.py:
1417         (Events.sendData): Send EWS_API_KEY if available along with event data.
1418
1419 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1420
1421         Unable to copy and paste a PDF from Notes into Mail compose body
1422         https://bugs.webkit.org/show_bug.cgi?id=196442
1423         <rdar://problem/48573098>
1424
1425         Reviewed by Tim Horton.
1426
1427         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1428         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1429         to be specified on the item providers.
1430
1431         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1432         (TestWebKitAPI::mapItemForTesting):
1433         (TestWebKitAPI::contactItemForTesting):
1434
1435 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1436
1437         Make UIWKDocumentContext rects per-character instead of per-word
1438         https://bugs.webkit.org/show_bug.cgi?id=196459
1439
1440         Reviewed by Wenson Hsieh.
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1443         (TEST):
1444         Adjust test results due to switching to per-character rects.
1445
1446 2019-04-01  Chris Dumez  <cdumez@apple.com>
1447
1448         UIProcess crash when a prewarmed process is terminated
1449         https://bugs.webkit.org/show_bug.cgi?id=196451
1450         <rdar://problem/49245471>
1451
1452         Reviewed by Geoffrey Garen.
1453
1454         Add API test coverage.
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1457         (TEST):
1458
1459 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1460
1461         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1462         https://bugs.webkit.org/show_bug.cgi?id=196449
1463
1464         Reviewed by Lucas Forschler.
1465
1466         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1467         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1468         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1469         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1470
1471 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1472
1473         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1474         https://bugs.webkit.org/show_bug.cgi?id=196444
1475
1476         Reviewed by Lucas Forschler.
1477
1478         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1479
1480 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1481
1482         Add SPI to canonicalize NSURLs with WTF::URL
1483         https://bugs.webkit.org/show_bug.cgi?id=196415
1484         <rdar://problem/44980271>
1485
1486         Reviewed by Darin Adler.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1490         (TestWebKitAPI::TEST):
1491
1492 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1493
1494         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1495         https://bugs.webkit.org/show_bug.cgi?id=196441
1496
1497         Reviewed by Carlos Garcia Campos.
1498
1499         Don't cache the wpe_view_backend object that might not exist yet at the
1500         time of EventSenderProxy constructor invocation, but instead retrieve
1501         that object whenever it's required for event dispatching. This should
1502         avoid crashes in this constructor now that it's invoked before any
1503         PlatformWindow has been set up (as changed in r243496).
1504
1505         * WebKitTestRunner/EventSenderProxy.h:
1506         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1507         (WTR::viewBackend):
1508         (WTR::EventSenderProxy::EventSenderProxy):
1509         (WTR::EventSenderProxy::mouseDown):
1510         (WTR::EventSenderProxy::mouseUp):
1511         (WTR::EventSenderProxy::mouseMoveTo):
1512         (WTR::EventSenderProxy::mouseScrollBy):
1513         (WTR::EventSenderProxy::keyDown):
1514         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1515
1516 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1517
1518         [Win][WebKit] MiniBrowser should support high DPI display
1519         https://bugs.webkit.org/show_bug.cgi?id=196391
1520
1521         Reviewed by Alex Christensen.
1522
1523         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1524         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1525         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1526         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1527
1528 2019-03-31  Sam Weinig  <weinig@apple.com>
1529
1530         Remove more i386 specific configurations
1531         https://bugs.webkit.org/show_bug.cgi?id=196430
1532
1533         Reviewed by Alexey Proskuryakov.
1534
1535         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1536         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1537
1538 2019-03-31  Andy Estes  <aestes@apple.com>
1539
1540         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1541         https://bugs.webkit.org/show_bug.cgi?id=196433
1542         <rdar://problem/49293305>
1543
1544         Reviewed by Tim Horton.
1545
1546         Enhanced API test coverage to include all navigation response policy decisions in both
1547         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1548
1549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1550         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1551         (TestWebKitAPI::TEST):
1552         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1553         (readFile):
1554         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1555         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1556         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1557         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1558         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1559         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1560         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1561         (-[QuickLookDelegate _downloadDidStart:]):
1562         (-[QuickLookDelegate _download:didReceiveResponse:]):
1563         (-[QuickLookDelegate _download:didReceiveData:]):
1564         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1565         (-[QuickLookDelegate _downloadDidFinish:]):
1566         (-[QuickLookDelegate _download:didFailWithError:]):
1567         (-[QuickLookDelegate _downloadDidCancel:]):
1568         (-[QuickLookDelegate verifyDownload]):
1569         (runTest):
1570         (runTestDecideBeforeLoading):
1571         (runTestDecideAfterLoading):
1572         (TEST):
1573         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1574         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1575         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1576         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1577         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1578         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1579         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1580         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1581         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1582         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1583         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1584         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1585         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1586         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1587
1588 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1589
1590         [CMake] add testdfg as target with build-jsc
1591         https://bugs.webkit.org/show_bug.cgi?id=196393
1592
1593         Reviewed by Saam Barati.
1594
1595         Added testdfg as one of the targets to build when
1596         using CMake.
1597
1598         * Scripts/build-jsc:
1599
1600 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1601
1602         Delete WebMetal implementation in favor of WebGPU
1603         https://bugs.webkit.org/show_bug.cgi?id=195418
1604
1605         Reviewed by Dean Jackson.
1606
1607         * DumpRenderTree/mac/DumpRenderTree.mm:
1608         (enableExperimentalFeatures):
1609         (resetWebPreferencesToConsistentValues):
1610         * Scripts/webkitperl/FeatureList.pm:
1611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1614         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1615         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1616         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1617         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1618         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1619         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1620         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1621         (WTR::InjectedBundle::beginTesting):
1622         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1623         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1624         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1625
1626 2019-03-29  Chris Dumez  <cdumez@apple.com>
1627
1628         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1629         https://bugs.webkit.org/show_bug.cgi?id=196405
1630         <rdar://problem/49428130>
1631
1632         Reviewed by Wenson Hsieh.
1633
1634         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1635         the popover presentation methods to be no-ops. Use this in the new test added in
1636         r243523 so that we do not swizzle those methods for all tests. This is needed because
1637         those WatchOS tests rely on the popover getting presented and interactive.
1638
1639         * WebKitTestRunner/TestController.cpp:
1640         (WTR::updateTestOptionsFromTestHeader):
1641         * WebKitTestRunner/TestController.h:
1642         * WebKitTestRunner/TestOptions.h:
1643         (WTR::TestOptions::hasSameInitializationOptions const):
1644         * WebKitTestRunner/ios/TestControllerIOS.mm:
1645         (WTR::TestController::platformInitialize):
1646         (WTR::TestController::platformResetStateToConsistentValues):
1647
1648 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1649
1650         [Curl] Add Server Trust Evaluation Support.
1651         https://bugs.webkit.org/show_bug.cgi?id=191646
1652
1653         Reviewed by Fujii Hironori.
1654
1655         Implemented MiniBrowser UI for asking if user trusts the server.
1656
1657         * MiniBrowser/win/Common.cpp:
1658         (askServerTrustEvaluation):
1659         (replaceString):
1660         * MiniBrowser/win/Common.h:
1661         * MiniBrowser/win/MiniBrowserLib.rc:
1662         * MiniBrowser/win/MiniBrowserLibResource.h:
1663         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1664         (createPEMString):
1665         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1666         (WebKitBrowserWindow::canTrustServerCertificate):
1667         * MiniBrowser/win/WebKitBrowserWindow.h:
1668
1669 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1670
1671         Implement ResizeObserver.
1672         https://bugs.webkit.org/show_bug.cgi?id=157743
1673
1674         Reviewed by Simon Fraser.
1675
1676         Support resizeObserverEnabled webPreferences.
1677
1678         * DumpRenderTree/TestOptions.cpp:
1679         (TestOptions::TestOptions):
1680         * DumpRenderTree/TestOptions.h:
1681         * DumpRenderTree/mac/DumpRenderTree.mm:
1682         (setWebPreferencesForTestOptions):
1683         * DumpRenderTree/win/DumpRenderTree.cpp:
1684         (enableExperimentalFeatures):
1685         * Scripts/webkitperl/FeatureList.pm:
1686         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1687
1688 2019-03-28  John Wilander  <wilander@apple.com>
1689
1690         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1691         https://bugs.webkit.org/show_bug.cgi?id=196281
1692         <rdar://problem/48938748>
1693
1694         Reviewed by Alex Christensen.
1695
1696         This patch adds the function isStatisticsHasLocalStorage() to the
1697         TestRunner. With it, the page can query the WebsiteDataStore in the
1698         UI process to make sure that it sees LocalStorage.
1699
1700         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1701         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1702         (WTR::TestRunner::isStatisticsHasLocalStorage):
1703         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1704         * WebKitTestRunner/TestController.cpp:
1705         (WTR::TestController::isStatisticsHasLocalStorage):
1706         * WebKitTestRunner/TestController.h:
1707         * WebKitTestRunner/TestInvocation.cpp:
1708         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1709
1710 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1711
1712         API::Data::createWithoutCopying should do a null check before calling CFRelease
1713         https://bugs.webkit.org/show_bug.cgi?id=196276
1714         <rdar://problem/48059859>
1715
1716         Reviewed by Alex Christensen.
1717
1718         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1719
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1722         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1723         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1724         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1725         (TestWebKitAPI::TEST):
1726
1727 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1728
1729         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1730         https://bugs.webkit.org/show_bug.cgi?id=186276
1731
1732         Reviewed by Carlos Garcia Campos.
1733
1734         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1735         (webViewLoadChanged):
1736         (testWebResourceGetDataError):
1737         (testWebResourceGetDataEmpty):
1738         (beforeAll):
1739         (webViewloadChanged): Deleted.
1740
1741 2019-03-27  Andy Estes  <aestes@apple.com>
1742
1743         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1744         https://bugs.webkit.org/show_bug.cgi?id=196317
1745
1746         Reviewed by Dan Bernstein.
1747
1748         package-root copies built products into a staging directory using ditto(1), which does not
1749         follow symbolic links as it traverses a directory. Now that the files in
1750         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1751         itself, these become broken links when ditto'd into the staging directory.
1752
1753         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1754
1755         * Scripts/package-root:
1756
1757 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews-app] Update display text of Submit for ews analysis
1760         https://bugs.webkit.org/show_bug.cgi?id=196309
1761
1762         Reviewed by Dewei Zhu.
1763
1764         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1765
1766 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1767
1768         run-webkit-tests should check for leaks in WebKit processes
1769         <https://webkit.org/b/193772>
1770         <rdar://problem/46526680>
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         This works by doing the following:
1775         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1776           The list of child processes are returned one per line:
1777           process.name: pid
1778         - Run the "#LIST CHILD PROCESSES" command just before the
1779           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1780           processes on the ServerProcess object.
1781         - When the `--leaks` switch is handled, run check_for_leaks() on
1782           each child process after the main test harness.
1783
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (handleControlCommand):
1786         - Use strncmp() instead of strcmp().
1787         - Add support for handling "#LIST CHILD PROCESSES" command.
1788
1789         * Scripts/webkitpy/port/base.py:
1790         (Port.check_for_leaks):
1791         * Scripts/webkitpy/port/darwin.py:
1792         (DarwinPort.check_for_leaks):
1793         - Rename redundant 'process_pid' argument to 'process_id'.
1794
1795         * Scripts/webkitpy/port/driver.py:
1796         (Driver.do_post_tests_work):
1797         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1798           longer the only command this sends to WebKitTestRunner.
1799         - If the `--leaks` switch is present, send the
1800           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1801           result using Port.set_webkit_processes().
1802         (Driver._parse_child_processes_output):
1803         - Add helper method to parse list of child process names and
1804           process IDs returned from WebKitTestRunner.
1805
1806         * Scripts/webkitpy/port/ios_device.py:
1807         (IOSDevicePort.check_for_leaks):
1808         - Rename redundant 'process_pid' argument to 'process_id'.
1809
1810         * Scripts/webkitpy/port/leakdetector.py:
1811         (LeakDetector._parse_leaks_output):
1812         - Return early if there is no leaks_output.
1813         (LeakDetector.check_for_leaks):
1814         - Rename redundant 'process_pid' argument to 'process_id'.
1815
1816         * Scripts/webkitpy/port/server_process.py:
1817         (ServerProcess.__init__):
1818         (ServerProcess.child_processes):
1819         (ServerProcess.set_child_processes):
1820         - Add instance variable to Port to store list of child process
1821           names and process IDs returned from WebKitTestRunner.
1822         (ServerProcess._start):
1823         - Clear self._child_processes.
1824         (ServerProcess.stop):
1825         - If self._child_processes is set, call
1826           self._port.check_for_leaks() for each child process.
1827
1828         * Scripts/webkitpy/port/server_process_unittest.py:
1829         (TrivialMockPort.check_for_leaks):
1830         - Rename redundant 'process_pid' argument to 'process_id'.
1831
1832         * Scripts/webkitpy/port/simulator_process.py:
1833         (SimulatorProcess.stop):
1834         - If self._child_processes is set, call
1835           self._port.check_for_leaks() for each child process.
1836
1837         * Scripts/webkitpy/port/watch_device.py:
1838         (WatchDevicePort.check_for_leaks):
1839         - Rename redundant 'process_pid' argument to 'process_id'.
1840
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::dumpResponse):
1843         - Extract method from findAndDumpWorldLeaks() so that it may be
1844           reused by findAndDumpWebKitProcessIdentifiers().
1845         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1846         - Add method to output process name and process ID of both the
1847           WebContent and Networking processes.
1848         (WTR::TestController::findAndDumpWorldLeaks):
1849         - Fix missing newline in output when there were no abandoned
1850           documents.
1851         - Call dumpResponse() for extracted code.
1852         (WTR::TestController::handleControlCommand):
1853         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1854         - Use strncmp() instead of strcmp().
1855         - Call findAndDumpWebKitProcessIdentifiers() when
1856           "#LIST CHILD PROCESSES" command is sent.
1857         * WebKitTestRunner/TestController.h:
1858         (WTR::TestController::dumpResponse):
1859         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1860         - Declare methods.
1861
1862 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         Unreviewed. Add GLib API test cases after r243434.
1865
1866         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1867         (testWebViewActiveURI):
1868         (serverCallback):
1869         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1870         (sendRequestCallback):
1871
1872 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1873
1874         Geolocation request not complete when watch request was started in a different web process
1875         https://bugs.webkit.org/show_bug.cgi?id=195996
1876
1877         Reviewed by Alex Christensen.
1878
1879         Add a test case.
1880
1881         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1882         (TestWebKitAPI::runJavaScriptAlert):
1883         (TestWebKitAPI::TEST):
1884
1885 2019-03-26  Keith Rollin  <krollin@apple.com>
1886
1887         Update the way generate-xcfilelists returns strings from functions
1888         https://bugs.webkit.org/show_bug.cgi?id=195975
1889         <rdar://problem/49040807>
1890
1891         Reviewed by Dean Jackson.
1892
1893         There are places where generate-xcfilelists executes assignments with
1894         statements like:
1895
1896             FOO=$(some_function)
1897
1898         where "some_function" return a string by echoing it. E.g.
1899
1900             some_function()
1901             {
1902                 echo "Hello, World"
1903             }
1904
1905         This is a common idiom, but it has a problem if "some_function" needs
1906         to call "exit" in an attempt to halt the entire script right then and
1907         there. Since "some_function" is called inside of $(), it's being
1908         executed in a sub-shell. Calling exit in that sub-shell simply exits
1909         that shell; it doesn't not exit the outer shell in which the main part
1910         of the script is still running. As such, the main script keeps
1911         executing when the intent was for the script to halt.
1912
1913         The solution to this is to use a different idiom for returning
1914         strings. The one we now is to pass in the name of the variable to
1915         receive the string result:
1916
1917             some_function()
1918             {
1919                 variable_name=$1
1920                 eval $variable_name ="Hello, World"
1921             }
1922
1923         The call site now looks like
1924
1925             some_function FOO
1926
1927         Because there's no invocation of a sub-shell, some_function can now
1928         call "exit" if it wants to, and the entire script will exit at that
1929         point.
1930
1931         * Scripts/generate-xcfilelists:
1932
1933 2019-03-26  Chris Dumez  <cdumez@apple.com>
1934
1935         Add basic layout test coverage for File Picker on iOS
1936         https://bugs.webkit.org/show_bug.cgi?id=196265
1937
1938         Reviewed by Wenson Hsieh.
1939
1940         Add layout test infrastructure to test the file picker on iOS.
1941
1942         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1943         (WTR::UIScriptController::dismissFilePicker):
1944         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1945         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1946         (WTR::UIScriptController::dismissFilePicker):
1947         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1948         * WebKitTestRunner/TestController.cpp:
1949         (WTR::TestController::createWebViewWithOptions):
1950         (WTR::updateTestOptionsFromTestHeader):
1951         * WebKitTestRunner/TestOptions.h:
1952         (WTR::TestOptions::hasSameInitializationOptions const):
1953         * WebKitTestRunner/ios/TestControllerIOS.mm:
1954         (overridePresentViewController):
1955         (WTR::TestController::platformInitialize):
1956         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1957         (WTR::UIScriptController::dismissFilePicker):
1958
1959 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1960
1961         Implement async paste method on UIWKInteractionViewProtocol
1962         https://bugs.webkit.org/show_bug.cgi?id=196267
1963         <rdar://problem/49236346>
1964
1965         Reviewed by Tim Horton.
1966
1967         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1968         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1969         are now a part of all iOS 12 internal SDKs.
1970
1971         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1972
1973         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1974         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1975
1976         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1977         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1978         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1979         * TestWebKitAPI/ios/UIKitSPI.h:
1980
1981 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1982
1983         [ews-build] Use PostgreSQL for ews.webkit.org database
1984         https://bugs.webkit.org/show_bug.cgi?id=196270
1985
1986         Reviewed by Lucas Forschler.
1987
1988         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1989
1990 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1991
1992         [ews] Reset simctl states on reboot
1993         https://bugs.webkit.org/show_bug.cgi?id=196260
1994
1995         Rubber-stamped by Aakash Jain.
1996
1997         * EWSTools/start-queue-mac.sh:
1998
1999 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews-build] Use PostgreSQL for ews-build database
2002         https://bugs.webkit.org/show_bug.cgi?id=196229
2003
2004         Reviewed by Lucas Forschler.
2005
2006         * BuildSlaveSupport/ews-build/master.cfg:
2007
2008 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2009
2010         [ews-build] Get master_hostname dynamically in master.cfg
2011         https://bugs.webkit.org/show_bug.cgi?id=196255
2012
2013         Reviewed by Lucas Forschler.
2014
2015         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2016         send events data in test mode.
2017
2018 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-app] Set db_constraint to False for Foreign Keys
2021         https://bugs.webkit.org/show_bug.cgi?id=196252
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/ews-app/ews/models/build.py:
2026         * BuildSlaveSupport/ews-app/ews/models/step.py:
2027
2028 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2029
2030         [ews-build] is_test_mode_enabled should default to True
2031         https://bugs.webkit.org/show_bug.cgi?id=196248
2032
2033         Reviewed by Lucas Forschler.
2034
2035         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2036
2037 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2038
2039         [ews-app] Add webkitperl to ENABLED_QUEUES
2040         https://bugs.webkit.org/show_bug.cgi?id=196253
2041
2042         Reviewed by Lucas Forschler.
2043
2044         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2045
2046 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2047
2048         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2049         https://bugs.webkit.org/show_bug.cgi?id=196211
2050         rdar://problem/49110552
2051
2052         Reviewed by Tim Horton.
2053
2054         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2055         Make sure that EventSenderProxy always exists when running tests. We used to create
2056         it when resetting before the first test, which is a bit too late.
2057
2058         * WebKitTestRunner/TestController.h:
2059         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2060         (WTR::TestController::platformCreateWebView):
2061         (WTR::TestController::platformCreateOtherPage):
2062         (WTR::TestController::finishCreatingPlatformWebView):
2063         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2064         (WTR::PlatformWebView::PlatformWebView):
2065         Moved some code that made NSWindow use NSEvent during web view creation. We may
2066         need to move more if some other case us found, but this is enough for now.
2067
2068 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         Unreviewed. Fix typo in GLib geolocation API after r243285.
2071
2072         gelocation -> geolocation.
2073
2074         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2075         (testGeolocationManagerWatchPosition):
2076
2077 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2078
2079         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2080         https://bugs.webkit.org/show_bug.cgi?id=196213
2081
2082         Reviewed by Geoff Garen.
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2085         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2086         (credentialWithIdentityAndKeychainPath):
2087         (-[ChallengeDelegate webView:didFinishNavigation:]):
2088         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2089         (TestWebKitAPI::TEST):
2090
2091 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2092
2093         Expected shouldn't assume its contained types are copyable
2094         https://bugs.webkit.org/show_bug.cgi?id=195986
2095
2096         Reviewed by JF Bastien.
2097
2098         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2099         (TestWebKitAPI::NonCopyable::operator== const):
2100         (TestWebKitAPI::NonCopyable::operator!= const):
2101         (TestWebKitAPI::TEST):
2102
2103 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2104
2105         Remove some now-unnecessary dynamic class lookup
2106         https://bugs.webkit.org/show_bug.cgi?id=196237
2107
2108         Reviewed by Simon Fraser.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2111         (makeRequest):
2112         (TEST):
2113
2114 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2115
2116         Unreviewed, rolling out r243450.
2117
2118         AppleWin and WinCairo port builds get broken.
2119
2120         Reverted changeset:
2121
2122         "Add test for fix of #196095"
2123         https://bugs.webkit.org/show_bug.cgi?id=196097
2124         https://trac.webkit.org/changeset/243450
2125
2126 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2127
2128         Unreviewed, rolling out r243465.
2129         https://bugs.webkit.org/show_bug.cgi?id=196226
2130
2131         the test doesn't build (Requested by thorton on #webkit).
2132
2133         Reverted changeset:
2134
2135         "Do not terminate the NetworkProcess if a third party
2136         application sends a NSCredential with a SecIdentityRef"
2137         https://bugs.webkit.org/show_bug.cgi?id=196213
2138         https://trac.webkit.org/changeset/243465
2139
2140 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2141
2142         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2143         https://bugs.webkit.org/show_bug.cgi?id=196213
2144
2145         Reviewed by Geoff Garen.
2146
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2149         (credentialWithIdentityAndKeychainPath):
2150         (-[ChallengeDelegate webView:didFinishNavigation:]):
2151         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2152         (TestWebKitAPI::TEST):
2153
2154 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-build] Gracefully handle missing patch_id in events
2157         https://bugs.webkit.org/show_bug.cgi?id=196216
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-build/events.py:
2162
2163 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2164
2165         [ews-build] use lz4 compression for improving buildbot performance
2166         https://bugs.webkit.org/show_bug.cgi?id=196155
2167
2168         Reviewed by Lucas Forschler.
2169
2170         * BuildSlaveSupport/ews-build/master.cfg:
2171
2172 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2173
2174         Pull some API testing helper methods out of TestWKWebView
2175         https://bugs.webkit.org/show_bug.cgi?id=196212
2176
2177         Reviewed by Tim Horton.
2178
2179         Refactor some more API testing utility methods, so that they can be used in
2180         tests that do not use TestWKWebView.
2181
2182         * TestWebKitAPI/cocoa/TestWKWebView.h:
2183         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2184         (-[WKWebView loadTestPageNamed:]):
2185         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2186         (-[WKWebView synchronouslyLoadHTMLString:]):
2187         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2188         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2189         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2190         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2191         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2192
2193 2019-03-25  Jer Noble  <jer.noble@apple.com>
2194
2195         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2196         https://bugs.webkit.org/show_bug.cgi?id=196097
2197
2198         Reviewed by Eric Carlson.
2199
2200         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2201
2202         * DumpRenderTree/mac/DumpRenderTree.mm:
2203         (resetWebPreferencesToConsistentValues):
2204         * WebKitTestRunner/TestController.cpp:
2205         (WTR::TestController::resetPreferencesToConsistentValues):
2206
2207 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2208
2209         Pull IPadUserInterfaceSwizzler out into a separate header file
2210         https://bugs.webkit.org/show_bug.cgi?id=196193
2211
2212         Reviewed by Anders Carlsson.
2213
2214         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2215         be used in other API tests.
2216
2217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2218         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2219         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2220         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2221         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2222         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2223         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2224
2225 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2226
2227         Remove NavigatorContentUtils in WebCore/Modules
2228         https://bugs.webkit.org/show_bug.cgi?id=196070
2229
2230         Reviewed by Alex Christensen.
2231
2232         NavigatorContentUtils was to support the custom scheme spec [1].
2233         However, in WebKit side, no port has supported the feature in
2234         WebKit layer after EFL port was removed. So there has been the
2235         only IDL implementation of the NavigatorContentUtils in WebCore.
2236         So we don't need to keep the implementation in WebCore anymore.
2237
2238         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2239
2240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2241
2242 2019-03-24  Andy Estes  <aestes@apple.com>
2243
2244         [watchOS] Remove unused Proximity Networking code
2245         https://bugs.webkit.org/show_bug.cgi?id=196188
2246
2247         Reviewed by Tim Horton.
2248
2249         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2250         (TEST):
2251
2252 2019-03-23  Keith Miller  <keith_miller@apple.com>
2253
2254         Refactor clz/ctz and fix getLSBSet.
2255         https://bugs.webkit.org/show_bug.cgi?id=196162
2256
2257         Reviewed by Saam Barati.
2258
2259         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2260
2261         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2262         (TestWebKitAPI::TEST):
2263
2264 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2265
2266         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2267         https://bugs.webkit.org/show_bug.cgi?id=196143
2268
2269         Reviewed by Michael Catanzaro.
2270
2271         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2272         directories.
2273
2274         * Scripts/webkitpy/style/checkers/cpp.py:
2275         (check_identifier_name_in_declaration):
2276         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2277         (WebKitStyleTest.test_names):
2278
2279 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2280
2281         [Flatpak] Manifest expanding fails for qt WPE extension
2282         https://bugs.webkit.org/show_bug.cgi?id=196148
2283
2284         Reviewed by Alex Christensen.
2285
2286         * flatpak/flatpakutils.py:
2287         (expand_submodules_recurse): The last recurse manifest expand
2288         iteration might lead to a single module so take it into account
2289         and don't try to recurse further.
2290
2291 2019-03-22  Chris Dumez  <cdumez@apple.com>
2292
2293         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2294         https://bugs.webkit.org/show_bug.cgi?id=195348
2295         <rdar://problem/48622090>
2296
2297         Reviewed by Alex Christensen.
2298
2299         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2300         to NO when test.options().shouldIgnoreMetaViewport is false.
2301
2302         * WebKitTestRunner/ios/TestControllerIOS.mm:
2303         (WTR::TestController::platformConfigureViewForTest):
2304
2305 2019-03-22  Chris Dumez  <cdumez@apple.com>
2306
2307         Prewarmed processes should be usable with any website data store
2308         https://bugs.webkit.org/show_bug.cgi?id=196104
2309
2310         Reviewed by Alex Christensen.
2311
2312         Add API test coverage.
2313
2314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2315         (runInitialWarmedProcessUsedTest):
2316         (TEST):
2317
2318 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2319
2320         Back out local changes to Alex's Subversion working directory
2321
2322         They were accidentally committed.
2323
2324         * Scripts/webkitpy/common/system/abstractexecutive.py:
2325         (AbstractExecutive.wait_newest):
2326         * Scripts/webkitpy/common/system/executive.py:
2327         (Executive.running_pids):
2328         * Scripts/webkitpy/common/system/executive_mock.py:
2329         (MockExecutive.running_pids):
2330         * Scripts/webkitpy/common/system/executive_unittest.py:
2331         (ExecutiveTest.serial_test_running_pids):
2332         * Scripts/webkitpy/port/darwin.py:
2333         (DarwinPort.check_for_leaks):
2334         * Scripts/webkitpy/port/leakdetector.py:
2335         (LeakDetector.check_for_leaks):
2336         - This was the hack attached to Bug 193772.
2337
2338         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2339         (+[WebKitTestRunnerEvent mouseLocation]):
2340         - This works around a crash on an internal build.
2341
2342 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2343
2344         Fix the build after r243354
2345         https://bugs.webkit.org/show_bug.cgi?id=196138
2346         <rdar://problem/49145951>
2347
2348         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2349         (TEST):
2350         * TestWebKitAPI/ios/UIKitSPI.h:
2351
2352 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2353
2354         Adopt UIWKDocumentContext
2355         https://bugs.webkit.org/show_bug.cgi?id=196040
2356         <rdar://problem/48642440>
2357
2358         Reviewed by Ryosuke Niwa.
2359
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2362         (makeRequest):
2363         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2364         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2365         (applyStyle):
2366         (TEST):
2367         Add tests for UIWKDocumentContext.
2368
2369         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2370         (TEST):
2371         (recursiveFindWKContentView): Deleted.
2372         * TestWebKitAPI/cocoa/TestWKWebView.h:
2373         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2374         (recursiveFindWKContentView):
2375         (-[TestWKWebView wkContentView]):
2376         * TestWebKitAPI/ios/UIKitSPI.h:
2377         Share the WKContentView finding code between tests.
2378
2379 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2380
2381         [iOS WK2] Turn on async overflow scrolling by default
2382         https://bugs.webkit.org/show_bug.cgi?id=196011
2383         rdar://problem/48453859
2384
2385         Reviewed by Antti Koivisto.
2386         
2387         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2388         since so many basic layout tests have different results when compositing is triggered for
2389         overflow.
2390         
2391         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2392
2393         * WebKitTestRunner/TestController.cpp:
2394         (WTR::TestController::resetPreferencesToConsistentValues):
2395
2396 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-build] Retry API test in case of failures
2399         https://bugs.webkit.org/show_bug.cgi?id=196004
2400
2401         Reviewed by Lucas Forschler.
2402
2403         * BuildSlaveSupport/ews-build/steps.py:
2404         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2405         (CompileWebKitToT.doStepIf): Ditto.
2406         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2407         (ReRunAPITests): Re-run API tests.
2408         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2409         (RunAPITestsWithoutPatch): Run API tests without patch.
2410         (RunAPITestsWithoutPatch.doStepIf):
2411         (RunAPITestsWithoutPatch.hideStepIf):
2412         (RunAPITestsWithoutPatch.evaluateCommand):
2413         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2414         (AnalyzeAPITestsResults.start):
2415         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2416         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2417         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2418         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2419
2420 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2421
2422         [ews-build] Update queues configurations
2423         https://bugs.webkit.org/show_bug.cgi?id=196074
2424
2425         Reviewed by Dewei Zhu.
2426
2427         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2428         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2429
2430 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2431
2432         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2433         https://bugs.webkit.org/show_bug.cgi?id=195680
2434         <rdar://problem/48903534>
2435
2436         Unreviewed infrastructure fix.
2437
2438         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2439         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2440
2441 2019-03-21  Andy Estes  <aestes@apple.com>
2442
2443         [iOS] Apple Pay should be available in documents with no user agent scripts
2444         https://bugs.webkit.org/show_bug.cgi?id=196061
2445         <rdar://problem/48649391>
2446
2447         Reviewed by Brady Eidson.
2448
2449         Added API tests and related infrastructure.
2450
2451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2452         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2453         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2454         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2455         (TestWebKitAPI::TEST):
2456         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2457         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2458         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2459         * TestWebKitAPI/cocoa/TestProtocol.mm:
2460         (-[TestProtocol startLoading]):
2461         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2462         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2463         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2464         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2465
2466 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2467
2468         REGRESSSION (r243297): webkitpy tests broken
2469         https://bugs.webkit.org/show_bug.cgi?id=196108
2470
2471         Reviewed by Aakash Jain.
2472
2473         r243297 updated contributors.json, which broke a few unit tests.
2474
2475         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2476         (IRCCommandTest.test_whois):
2477         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2478
2479 2019-03-21  Chris Dumez  <cdumez@apple.com>
2480
2481         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2482         https://bugs.webkit.org/show_bug.cgi?id=196041
2483         <rdar://problem/49083230>
2484
2485         Reviewed by Alex Christensen.
2486
2487         Add API test coverage.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2490         (TEST):
2491
2492 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2493
2494         Add SPI to inform applications of WKContentRuleList actions
2495         https://bugs.webkit.org/show_bug.cgi?id=195965
2496         <rdar://problem/42664365>
2497
2498         Reviewed by Geoff Garen.
2499
2500         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2501         (TestWebKitAPI::allActionsForResourceLoad):
2502         (TestWebKitAPI::testRequest):
2503         (TestWebKitAPI::TEST_F):
2504         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2505         (Notification::description):
2506         (Notification::operator== const):
2507         (toVector):
2508         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2509         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2510         (makeContentRuleList):
2511         (TEST):
2512         (makeWarnContentRuleList): Deleted.
2513
2514 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2515
2516         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2517         https://bugs.webkit.org/show_bug.cgi?id=196088
2518
2519         Reviewed by Brian Burg.
2520
2521         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2522         Support checks when only one platform is specified. Also deprecate macosx() and
2523         force the use of macos() instead.
2524
2525         * Scripts/webkitpy/style/checkers/cpp.py:
2526         (check_min_versions_of_wk_api_available):
2527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2528         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2529
2530 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2531
2532         Update status inactive committers' status to 'contributor'.
2533
2534         * Scripts/webkitpy/common/config/contributors.json:
2535
2536 2019-03-21  Xan Lopez  <xan@igalia.com>
2537
2538         [JSC][x86] Drop support for x87 floating point
2539         https://bugs.webkit.org/show_bug.cgi?id=194853
2540
2541         Reviewed by Don Olmstead.
2542
2543         Force SSE2 on x86/32bit builds.
2544
2545         * Scripts/webkitdirs.pm:
2546         (generateBuildSystemFromCMakeProject):
2547
2548 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2549
2550         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2551         https://bugs.webkit.org/show_bug.cgi?id=196073
2552
2553         Reviewed by Michael Catanzaro.
2554
2555         Add test cases to check functions and constructors with no arguments but receiving user data.
2556
2557         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2558         (checkUserData):
2559         (testJSCFunction):
2560         (fooCreateWithUserData):
2561         (testJSCClass):
2562
2563 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2564
2565         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2566
2567         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2568
2569         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2570
2571 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2572
2573         [GTK][WPE] Add API to provide geolocation information
2574         https://bugs.webkit.org/show_bug.cgi?id=195940
2575
2576         Reviewed by Michael Catanzaro.
2577
2578         Add a new test to check the new API.
2579
2580         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2581         (testGeolocationManagerCurrentPosition):
2582         (testGeolocationManagerWatchPosition):
2583         (beforeAll):
2584         (afterAll):
2585         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2586         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2587         (beforeAll): Ditto.
2588         * TestWebKitAPI/glib/CMakeLists.txt:
2589
2590 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         [GLib] Returning G_TYPE_OBJECT from a method does not work
2593         https://bugs.webkit.org/show_bug.cgi?id=195574
2594
2595         Reviewed by Michael Catanzaro.
2596
2597         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2598
2599         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2600         (getGFile):
2601         (getParent):
2602         (createGString):
2603         (getGString):
2604         (getGStringCopyWillRaise):
2605         (getGStringCopy):
2606         (getGStringStr):
2607         (getGStringLen):
2608         (freeGString):
2609         (testJSCClass):
2610
2611 2019-03-20  Saam Barati  <sbarati@apple.com>
2612
2613         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2614         https://bugs.webkit.org/show_bug.cgi?id=195721
2615
2616         Reviewed by Filip Pizlo.
2617
2618         * Scripts/run-javascriptcore-tests:
2619
2620 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2621
2622         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2623         https://bugs.webkit.org/show_bug.cgi?id=196049
2624
2625         Reviewed by Tim Horton.
2626
2627         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2628         overflow scrolling in general, so rename it.
2629
2630         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2631
2632 2019-03-20  Daniel Bates  <dabates@apple.com>
2633
2634         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2635         https://bugs.webkit.org/show_bug.cgi?id=196031
2636         <rdar://problem/49078172>
2637
2638         Reviewed by Tim Horton.
2639
2640         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2641         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2642         same code path used when the Done button is pressed to dismiss the <select> picker.
2643
2644         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2645         (TestWebKitAPI::TEST):
2646
2647 2019-03-20  Chris Dumez  <cdumez@apple.com>
2648
2649         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2650         https://bugs.webkit.org/show_bug.cgi?id=196029
2651         <rdar://problem/48954651>
2652
2653         Reviewed by Tim Horton.
2654
2655         Add API test coverage.
2656
2657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2658
2659 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2660
2661         [ews-build] Improve failure summary string for ApplyPatch step
2662         https://bugs.webkit.org/show_bug.cgi?id=195995
2663
2664         Reviewed by Alexey Proskuryakov.
2665
2666         * BuildSlaveSupport/ews-build/steps.py:
2667         (ApplyPatch.getResultSummary): Override getResultSummary.
2668
2669 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2670
2671         AX: Implement support for new meter ARIA role
2672         https://bugs.webkit.org/show_bug.cgi?id=195966
2673
2674         Reviewed by Chris Fleizach.
2675
2676         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2677         to AXLevelIndicator.
2678
2679         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2680
2681 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2682
2683         [WebAuthN] Implement FIDO AppID extension
2684         https://bugs.webkit.org/show_bug.cgi?id=143491
2685         <rdar://problem/48298273>
2686
2687         Reviewed by Brent Fulgham.
2688
2689         Add a test that covers the new flag of convertToU2fSignCommand.
2690
2691         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2692         (TestWebKitAPI::TEST):
2693         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2694         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2695         (TestWebKitAPI::TEST):
2696
2697 2019-03-19  Keith Rollin  <krollin@apple.com>
2698
2699         Add support for more platforms to generate-xcfilelists
2700         https://bugs.webkit.org/show_bug.cgi?id=195977
2701
2702         Reviewed by Alexey Proskuryakov.
2703
2704         generate-xcfilelists incorrectly complains when involved with building
2705         WebKit for iphonesimulator:
2706
2707             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2708             …
2709             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2710
2711         Address this by teaching generate-xcfilelists about more platforms.
2712
2713         * Scripts/generate-xcfilelists:
2714
2715 2019-03-19  John Wilander  <wilander@apple.com>
2716
2717         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2718         https://bugs.webkit.org/show_bug.cgi?id=195923
2719         <rdar://problem/49001272>
2720
2721         Reviewed by Alex Christensen.
2722
2723         This patch does the following to the TestRunner:
2724         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2725         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2726         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2727
2728         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2729         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2730         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2731         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2732         * WebKitTestRunner/TestController.cpp:
2733         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2734         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2735         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2736         * WebKitTestRunner/TestController.h:
2737         * WebKitTestRunner/TestInvocation.cpp:
2738         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2739
2740 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2741
2742         [CMake] Support more clang and gcc sanitizers
2743         https://bugs.webkit.org/show_bug.cgi?id=195956
2744
2745         Reviewed by Michael Catanzaro.
2746
2747         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2748
2749 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews-build] Improve summary for PrintConfiguration step
2752         https://bugs.webkit.org/show_bug.cgi?id=195945
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-build/steps.py:
2757         (PrintConfiguration.getResultSummary): Override getResultSummary.
2758
2759 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2760
2761         [ews-build] Improve summary for CheckOutSource step
2762         https://bugs.webkit.org/show_bug.cgi?id=195963
2763
2764         Reviewed by Lucas Forschler.
2765
2766         * BuildSlaveSupport/ews-build/steps.py:
2767         (CheckOutSource.getResultSummary):
2768
2769 2019-03-19  Daniel Bates  <dabates@apple.com>
2770
2771         [iOS] Focus not preserved when switching between tabs
2772         https://bugs.webkit.org/show_bug.cgi?id=195820
2773         <rdar://problem/43614450>
2774
2775         Reviewed by Brent Fulgham.
2776
2777         Add tests to ensure that we restore focus when resigning and becoming first responder.
2778
2779         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2780         (TestWebKitAPI::TEST):
2781
2782 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2783
2784         Make WTFLogChannelState and WTFLogLevel enum classes
2785         https://bugs.webkit.org/show_bug.cgi?id=195904
2786
2787         Reviewed by Eric Carlson.
2788
2789         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2790         (TestWebKitAPI::TEST_F):
2791
2792 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2793
2794         [GStreamer][EME] Backported mssdemux protection data crash fix
2795         https://bugs.webkit.org/show_bug.cgi?id=195918
2796
2797         Reviewed by Philippe Normand.
2798
2799         * gstreamer/jhbuild.modules:
2800         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2801
2802 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2803
2804         Unreviewed, rolling out r243132.
2805
2806         Broke GTK build
2807
2808         Reverted changeset:
2809
2810         "Make WTFLogChannelState and WTFLogLevel enum classes"
2811         https://bugs.webkit.org/show_bug.cgi?id=195904
2812         https://trac.webkit.org/changeset/243132
2813
2814 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2815
2816         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2817
2818         * Scripts/webkitdirs.pm:
2819         (builtDylibPathForName): Adjust the shared library name that's changed
2820         with the API version bump in r243073.
2821
2822 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2823
2824         Make WTFLogChannelState and WTFLogLevel enum classes
2825         https://bugs.webkit.org/show_bug.cgi?id=195904
2826
2827         Reviewed by Eric Carlson.
2828
2829         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2830         (TestWebKitAPI::TEST_F):
2831
2832 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2833
2834         Disable flaky test added in r2431100
2835         https://webkit.org/b/195785
2836
2837         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2838         (TestWebKitAPI::TEST):
2839         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2840
2841 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2842
2843         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2844         https://bugs.webkit.org/show_bug.cgi?id=195916
2845
2846         Reviewed by Tim Horton.
2847
2848         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2849         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2850
2851 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2852
2853         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2854
2855         * Scripts/webkitpy/common/config/contributors.json:
2856
2857 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2858
2859         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2860         https://bugs.webkit.org/show_bug.cgi?id=195785
2861
2862         Reviewed by Geoffrey Garen.
2863
2864         * TestWebKitAPI/TCPServer.cpp: Added.
2865         (TestWebKitAPI::TCPServer::TCPServer):
2866         (TestWebKitAPI::TCPServer::~TCPServer):
2867         (TestWebKitAPI::TCPServer::socketBindListen):
2868         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2869         * TestWebKitAPI/TCPServer.h: Added.
2870         (TestWebKitAPI::TCPServer::port const):
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2873         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2874         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2875         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2876         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2877         (TestWebKitAPI::respondSlowly):
2878         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2879         (TestWebKitAPI::downloadAtRate):
2880         (TestWebKitAPI::TEST):
2881
2882 2019-03-18  Saam Barati  <sbarati@apple.com>
2883
2884         Add a plan file for JetStream 2
2885         https://bugs.webkit.org/show_bug.cgi?id=190734
2886
2887         Reviewed by Mark Lam.
2888
2889         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2890
2891 2019-03-18  Chris Dumez  <cdumez@apple.com>
2892
2893         Delay WebProcess launch until a load is triggered in a Web view
2894         https://bugs.webkit.org/show_bug.cgi?id=195758
2895         <rdar://problem/48126013>
2896
2897         Reviewed by Geoff Garen.
2898
2899         Add API test coverage. Also update some existing API tests to not expect
2900         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2901
2902         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2903         (TestWebKitAPI::TEST):
2904         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2905         (TestWebKitAPI::TEST):
2906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2907         (TEST):
2908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2909         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2910         (TEST):
2911         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2912         (TEST):
2913         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2914
2915 2019-03-18  Xan Lopez  <xan@igalia.com>
2916
2917         [CMake] Prevent potential warning when determining $architecture
2918         https://bugs.webkit.org/show_bug.cgi?id=195891
2919
2920         Reviewed by Michael Catanzaro.
2921
2922         It's possible for generateBuildSystemForCMakeProject to be called
2923         before determineArchitecture() is ever called. This will make the
2924         first eq check with $architecture to be bogus (and print a
2925         warning). Change that to an eq check with architecture(), which
2926         implicitly calls determineArchitecture() if needed, and change all
2927         the other similar cases in the method in the same way to prevent
2928         future bugs like this one.
2929
2930         * Scripts/webkitdirs.pm:
2931         (generateBuildSystemFromCMakeProject):
2932
2933 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2934
2935         [WPE] Tarballs generated with “make dist” cannot build documentation
2936         https://bugs.webkit.org/show_bug.cgi?id=195885
2937
2938         Reviewed by Carlos Garcia Campos.
2939
2940         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2941
2942 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2943
2944         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2945         https://bugs.webkit.org/show_bug.cgi?id=195883
2946
2947         Reviewed by Carlos Garcia Campos.
2948
2949         * gtkdoc/gtkdoc.py:
2950         (GTKDoc._run_command): When commands fail to run, include the full command line for
2951         the program invocation and the output it has generated on the standard error stream.
2952
2953 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2954
2955         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2956         https://bugs.webkit.org/show_bug.cgi?id=195786
2957
2958         Reviewed by Philippe Normand.
2959
2960         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2961         * wpe/jhbuild.modules: Ditto.
2962
2963 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2964
2965         [ews-build] Don't run clean builds on EWS builders
2966         https://bugs.webkit.org/show_bug.cgi?id=195851
2967
2968         Reviewed by Geoffrey Garen.
2969
2970         * BuildSlaveSupport/ews-build/factories.py:
2971
2972 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2973
2974         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2975         https://bugs.webkit.org/show_bug.cgi?id=195849
2976
2977         Reviewed by Chris Dumez.
2978
2979         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2982         (runWebsiteDataStoreCustomPaths):
2983
2984 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2985
2986         webkitpy: Upload test results
2987         https://bugs.webkit.org/show_bug.cgi?id=195755
2988         <rdar://problem/48896182>
2989
2990         Reviewed by Aakash Jain.
2991
2992         Establish a new format for uploading results that is not tied to layout tests, apply
2993         that format to webkitpy tests.
2994
2995         * Scripts/webkitpy/common/checkout/scm/git.py:
2996         (Git.native_branch): Return what branch the current checkout is on.
2997         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2998         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2999         * Scripts/webkitpy/common/checkout/scm/svn.py:
3000         (SVN.native_branch): Ditto.
3001         * Scripts/webkitpy/common/system/platforminfo.py:
3002         (PlatformInfo.build_version): Return a build version for Mac.
3003         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3004         (MockPlatformInfo.__init__):
3005         (MockPlatformInfo.build_version):
3006         * Scripts/webkitpy/results: Added.
3007         * Scripts/webkitpy/results/__init__.py: Added.
3008         * Scripts/webkitpy/results/options.py: Added.
3009         (upload_options): OptParse list for upload options.
3010         * Scripts/webkitpy/results/upload.py: Added.
3011         (Upload): Class which enforces the upload format expected by the results server.
3012         (Upload.Expectations):
3013         (Upload.create_configuration):
3014         (Upload.create_commit):
3015         (Upload.create_details):
3016         (Upload.create_run_stats):
3017         (Upload.create_test_result):
3018         (Upload.__init__):
3019         (Upload.Encoder): Encode Upload object as json.
3020         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3021         * Scripts/webkitpy/results/upload_unittest.py: Added.
3022         * Scripts/webkitpy/test/main.py:
3023         (Tester._parse_args): Add upload arguments.
3024         (Tester._run_tests): Allow results to be uploaded.
3025         * Scripts/webkitpy/test/runner.py:
3026         (Runner.__init__): Record which tests were run, rather than just counting them.
3027         (Runner.handle):
3028         * Scripts/webkitpy/test/runner_unittest.py:
3029         (RunnerTest.test_run):
3030         * Scripts/webkitpy/thirdparty/__init__.py:
3031         (AutoinstallImportHook.find_module): Add requests auto-install.
3032         (AutoinstallImportHook._install_requests):
3033         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3034         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3035
3036 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3037
3038         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3039         https://bugs.webkit.org/show_bug.cgi?id=195810
3040
3041         Reviewed by Tim Horton.
3042
3043         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3044         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3045         ending certain layout tests.
3046
3047         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3048         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3049         (-[TestRunnerWKWebView dealloc]):
3050         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3051
3052         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3053         helper method when destroying the web view, and when resetting state between tests.
3054
3055         * WebKitTestRunner/ios/TestControllerIOS.mm:
3056         (WTR::TestController::platformResetStateToConsistentValues):
3057
3058         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3059
3060 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3061
3062         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3063         https://bugs.webkit.org/show_bug.cgi?id=190350
3064         <rdar://problem/45089503>
3065
3066         Reviewed by Geoffrey Garen.
3067
3068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3069         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3070         (TEST):
3071         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3072         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3073         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3074         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3075         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3076         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3077         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3078         (runTest):
3079         (createDirectories):
3080         (TEST):
3081         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3082         (TEST):
3083         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3084         (TEST):
3085
3086 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3087
3088         Add support to WebPage for getting the contents as an attributed string.
3089         https://bugs.webkit.org/show_bug.cgi?id=195636
3090         rdar://problem/45055697
3091
3092         Reviewed by Tim Horton.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3095         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3096
3097 2019-03-15  Chris Dumez  <cdumez@apple.com>
3098
3099         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3100         https://bugs.webkit.org/show_bug.cgi?id=195747
3101
3102         Reviewed by Geoff Garen.
3103
3104         Add API test coverage.
3105
3106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3107
3108 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3109
3110         Unreviewed, rolling out r242952.
3111
3112         Causing API failures on iOS Simulator
3113
3114         Reverted changeset:
3115
3116         "[PSON] Make sure the WebProcessCache is leverage when
3117         relaunching a process after termination"
3118         https://bugs.webkit.org/show_bug.cgi?id=195747
3119         https://trac.webkit.org/changeset/242952
3120
3121 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3122
3123         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3124         https://bugs.webkit.org/show_bug.cgi?id=195740
3125
3126         Reviewed by Ross Kirsling.
3127
3128         window.open doesn't work for WebKitBrowserWindow because it is not
3129         implemented yet.
3130
3131         1. Implemented createNewPage callback of WKPageUIClient.
3132         2. Changed MainWindow to take a BrowserWindow factory function
3133           instead of BrowserWindowType to be flexible to create
3134           BrowserWindow with extra settings.
3135         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3136           because it is not relevant with MainWindow anymore.
3137
3138         * MiniBrowser/win/Common.cpp:
3139         (parseCommandLine):
3140         * MiniBrowser/win/Common.h:
3141         (CommandLineOptions::CommandLineOptions):
3142         * MiniBrowser/win/MainWindow.cpp:
3143         (MainWindow::MainWindow):
3144         (MainWindow::create):
3145         (MainWindow::init):
3146         (MainWindow::WndProc):
3147         * MiniBrowser/win/MainWindow.h:
3148         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3149         (PrintWebUIDelegate::createWebViewWithRequest):
3150         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3151         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3152         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3153         (WebKitBrowserWindow::updateProxySettings):
3154         (WebKitBrowserWindow::createNewPage):
3155         * MiniBrowser/win/WebKitBrowserWindow.h:
3156         * MiniBrowser/win/WinMain.cpp:
3157         (wWinMain):
3158
3159 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3160
3161         Make it possible to test scrolling tree layer manipulation more easily
3162         https://bugs.webkit.org/show_bug.cgi?id=195780
3163
3164         Reviewed by Tim Horton.
3165         
3166         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3167         cuts off communication of scrolling tree scrolls back to the web process
3168         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3169         allows tests to trigger scrolls which run the scrolling tree layer positioning
3170         logic, but never get another commit from the web process that might mask
3171         scrolling tree bugs.
3172         
3173         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3174         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3175         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3176
3177         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3178         (WTR::UIScriptController::scrollUpdatesDisabled const):
3179         (WTR::UIScriptController::setScrollUpdatesDisabled):
3180         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3181         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3182         (WTR::UIScriptController::scrollUpdatesDisabled const):
3183         (WTR::UIScriptController::setScrollUpdatesDisabled):
3184         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3187         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3188         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3189         * WebKitTestRunner/ios/TestControllerIOS.mm:
3190         (WTR::TestController::platformResetStateToConsistentValues):
3191         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3192         (WTR::UIScriptController::scrollUpdatesDisabled const):
3193         (WTR::UIScriptController::setScrollUpdatesDisabled):
3194
3195 2019-03-14  Youenn Fablet  <youenn@apple.com>
3196
3197         Move IDB storage in private browsing mode to NetworkProcess
3198         https://bugs.webkit.org/show_bug.cgi?id=195602
3199
3200         Reviewed by Brady Eidson.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3203         (TEST):
3204
3205 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3206
3207         [ews-build] Make descriptionDone messages more readable
3208         https://bugs.webkit.org/show_bug.cgi?id=195760
3209
3210         Reviewed by Lucas Forschler.
3211
3212         * BuildSlaveSupport/ews-build/steps.py:
3213         * BuildSlaveSupport/ews-build/steps_unittest.py:
3214
3215 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3216
3217         [ews-build] Generate status-bubble hover-over messages
3218         https://bugs.webkit.org/show_bug.cgi?id=195680
3219
3220         Reviewed by Lucas Forschler.
3221
3222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3223         (StatusBubble):
3224         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3225         on hover-over.
3226         (StatusBubble._iso_time):
3227         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3228         hover-over message.
3229         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3230
3231 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3232
3233         [ews-app] Gracefully handle the case when state_string is None
3234         https://bugs.webkit.org/show_bug.cgi?id=195753
3235
3236         Reviewed by Lucas Forschler.
3237
3238         * BuildSlaveSupport/ews-app/ews/models/build.py:
3239         * BuildSlaveSupport/ews-app/ews/models/step.py:
3240
3241 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3242
3243         [ews-app] Status bubble display pending for currently running build step
3244         https://bugs.webkit.org/show_bug.cgi?id=195744
3245
3246         Reviewed by Lucas Forschler.
3247
3248         * BuildSlaveSupport/ews-build/events.py:
3249         (Events.stepStarted): If state_string is pending, replace it with step name.
3250
3251 2019-03-14  Chris Dumez  <cdumez@apple.com>
3252
3253         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3254         https://bugs.webkit.org/show_bug.cgi?id=195750
3255
3256         Reviewed by Geoffrey Garen.
3257
3258         Add API test coverage.
3259
3260         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3261         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3262         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3263         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3264
3265 2019-03-14  Chris Dumez  <cdumez@apple.com>
3266
3267         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3268         https://bugs.webkit.org/show_bug.cgi?id=195747
3269
3270         Reviewed by Geoff Garen.
3271
3272         Add API test coverage.
3273
3274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3275
3276 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3277
3278         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3279         https://bugs.webkit.org/show_bug.cgi?id=195725
3280         <rdar://problem/48545062>
3281
3282         Reviewed by Tim Horton.
3283
3284         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3285         handler is nil.
3286
3287         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3288         (TestWebKitAPI::TEST):
3289
3290 2019-03-13  Sam Weinig  <sam@webkit.org>
3291
3292         Add utility function to allow easy reverse range-based iteration of a container
3293         https://bugs.webkit.org/show_bug.cgi?id=195542
3294
3295         Reviewed by Antti Koivisto.
3296
3297         * TestWebKitAPI/CMakeLists.txt:
3298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3299         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3300         (TestWebKitAPI::TEST):
3301         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3302
3303 2019-03-13  Chris Dumez  <cdumez@apple.com>
3304
3305         Use a ServiceWorker process per registrable domain
3306         https://bugs.webkit.org/show_bug.cgi?id=195649
3307
3308         Reviewed by Youenn Fablet.
3309
3310         Update API test coverage.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3313
3314 2019-03-13  Chris Dumez  <cdumez@apple.com>
3315
3316         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3317         https://bugs.webkit.org/show_bug.cgi?id=195684
3318         <rdar://problem/48294714>
3319
3320         Reviewed by Antti Koivisto.
3321
3322         Add API test coverage.
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3325
3326 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3327
3328         [ews-app] Remove unused patch view
3329         https://bugs.webkit.org/show_bug.cgi?id=195669
3330
3331         Reviewed by Lucas Forschler.
3332
3333         * BuildSlaveSupport/ews-app/ews/urls.py:
3334         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3335
3336 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3337
3338         [ews-app] Use Buildbot result code variables
3339         https://bugs.webkit.org/show_bug.cgi?id=195668
3340
3341         Reviewed by Alexey Proskuryakov.
3342
3343         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3344         (Buildbot): Added Buildbot result code variables.
3345         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3346         (StatusBubble._build_bubble): Used Buildbot result code variables.
3347
3348 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3349
3350         [Flatpak] Expand submodule recursively
3351         https://bugs.webkit.org/show_bug.cgi?id=195672
3352
3353         Building WPE with flatpak was impossible without that as it was raising an exception.
3354         Also update wpebackend-fdo to match what is built in jhbuild
3355
3356         Reviewed by Philippe Normand.
3357
3358         * flatpak/flatpakutils.py:
3359         (expand_submodules_recurse):
3360         (expand_manifest):
3361         * flatpak/org.webkit.WPEModules.yaml:
3362
3363 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [ews-app] status bubble should be hidden for certain builds
3366         https://bugs.webkit.org/show_bug.cgi?id=194597
3367
3368         Reviewed by Dewei Zhu.
3369
3370         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3371         (StatusBubble._build_bubble):
3372         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3373         because the patch didn't have relevant changes.
3374         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3375         in production yet.
3376
3377 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3378
3379         [Win] Fix a slew of simple clang-cl warnings.
3380         https://bugs.webkit.org/show_bug.cgi?id=195652
3381
3382         Reviewed by Don Olmstead.
3383
3384         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3385         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3386
3387 2019-03-12  Justin Fan  <justin_fan@apple.com>
3388
3389         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3390         https://bugs.webkit.org/show_bug.cgi?id=195518
3391         <rdar://problem/46322356>
3392
3393         Reviewed by Myles C. Maxfield.
3394
3395         * DumpRenderTree/DerivedSources-input.xcfilelist:
3396         * DumpRenderTree/DerivedSources-output.xcfilelist:
3397
3398 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3399
3400         Unreviewed, rolling out r242825.
3401         https://bugs.webkit.org/show_bug.cgi?id=195648
3402
3403         "Broke webkitpy tests with my change to
3404         lldb_dump_class_layout.py" (Requested by rmorisset on
3405         #webkit).
3406
3407         Reverted changeset:
3408
3409         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3410         classes with suspicious padding"
3411         https://bugs.webkit.org/show_bug.cgi?id=195573
3412         https://trac.webkit.org/changeset/242825
3413
3414 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3415
3416         [ews-build] Show status bubbles while the patch is waiting in queue
3417         https://bugs.webkit.org/show_bug.cgi?id=195618
3418
3419         Reviewed by Lucas Forschler.
3420
3421         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3422         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3423         enabled in initial deployment.
3424         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3425         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3426         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3427         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3428         (StatusBubble._build_bubbles_for_patch):
3429
3430 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3431
3432         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3433         https://bugs.webkit.org/show_bug.cgi?id=195573
3434
3435         Reviewed by Simon Fraser.
3436
3437         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3438
3439         * Scripts/dump-class-layout:
3440         (main):
3441         * lldb/lldb_dump_class_layout.py:
3442         (ClassLayout.__init__):
3443         (ClassLayout._compute_padding_recursive):
3444         (LLDBDebuggerInstance.dump_layout_for_classname):
3445         (LLDBDebuggerInstance):
3446         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3447         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3448
3449 2019-03-12  Chris Dumez  <cdumez@apple.com>
3450
3451         Device Orientation access permission should be denied unless explicitly granted by the client
3452         https://bugs.webkit.org/show_bug.cgi?id=195625
3453
3454         Reviewed by Youenn Fablet.
3455
3456         add API test coverage.
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3460         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3461         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3462         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3463         (runDeviceOrientationTest):
3464         (TEST):
3465         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3466         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3467
3468 2019-03-12  Jer Noble  <jer.noble@apple.com>
3469
3470         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3471         https://bugs.webkit.org/show_bug.cgi?id=195137
3472         <rdar://problem/48810307>
3473
3474         Reviewed by Eric Carlson.
3475
3476         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3477         (TestWebKitAPI::TEST):
3478
3479 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3480
3481         [ews-build] Change urls from uat to production
3482         https://bugs.webkit.org/show_bug.cgi?id=195566
3483
3484         Reviewed by Lucas Forschler.
3485
3486         * BuildSlaveSupport/ews-app/ews/config.py:
3487         * BuildSlaveSupport/ews-build/events.py:
3488         * BuildSlaveSupport/ews-build/steps.py:
3489
3490 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-build] change max_builds for local-worker to 1
3493         https://bugs.webkit.org/show_bug.cgi?id=195568
3494
3495         Reviewed by Lucas Forschler.
3496
3497         * BuildSlaveSupport/ews-build/loadConfig.py:
3498
3499 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3500
3501         Fix the build
3502
3503         * TestRunnerShared/spi/PencilKitTestSPI.h:
3504         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3505
3506 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3507
3508         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3509         https://bugs.webkit.org/show_bug.cgi?id=194131
3510
3511         Reviewed by Michael Catanzaro.
3512
3513         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3514         (uriChanged):
3515         (testUnfinishedSubresourceLoad):
3516         (serverCallback):
3517         (beforeAll):
3518
3519 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3520
3521         WTF::Expected should use std::addressof instead of operator&
3522         https://bugs.webkit.org/show_bug.cgi?id=195604
3523
3524         Reviewed by Myles Maxfield.
3525
3526         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3527         (TestWebKitAPI::Unique::Unique):
3528         (TestWebKitAPI::Unique::operator&):
3529         (TestWebKitAPI::TEST):
3530
3531 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3532
3533         Add Optional to Forward.h.
3534         https://bugs.webkit.org/show_bug.cgi?id=195586
3535
3536         Reviewed by Darin Adler.
3537
3538         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3539         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3540         Remove unnecessary includes from headers.
3541
3542 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3543
3544         Add testing API to hit-test and scroll overflow scrollers
3545         https://bugs.webkit.org/show_bug.cgi?id=195278
3546
3547         Reviewed by Antti Koivisto.
3548         
3549         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3550         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3551         
3552         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3553
3554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3555         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3556         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3557         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3558         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3559         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3560         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3561         (WTR::enclosingScrollViewIncludingSelf):
3562         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3563
3564 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3565
3566         API test WebKit.RequestTextInputContext fails on iOS
3567         https://bugs.webkit.org/show_bug.cgi?id=195585
3568
3569         Reviewed by Wenson Hsieh and Simon Fraser.
3570
3571         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3572         (applyStyle):
3573         (TEST):
3574         Add a viewport, so that the coordinates match up on iOS.
3575         Scroll by moving the UIScrollView's contentOffset.
3576
3577 2019-03-11  Chris Dumez  <cdumez@apple.com>
3578
3579         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3580         https://bugs.webkit.org/show_bug.cgi?id=195506
3581         <rdar://problem/48733477>
3582
3583         Reviewed by Alex Christensen.
3584
3585         Add API test coverage.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3588
3589 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3590
3591         Adding myself to contributors.json
3592
3593         Unreviewed, addming myself to contributors.json .
3594
3595         * Scripts/webkitpy/common/config/contributors.json:
3596
3597 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3598
3599         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3600         https://bugs.webkit.org/show_bug.cgi?id=195511
3601         <rdar://problem/44873269>
3602
3603         Reviewed by Darin Adler.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3606         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3607         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3608         (TEST_F):
3609
3610 2019-03-11  Chris Dumez  <cdumez@apple.com>
3611
3612         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3613         https://bugs.webkit.org/show_bug.cgi?id=195561
3614
3615         Reviewed by Youenn Fablet.
3616
3617         Make sure the JS in the test requests for permission to receive device orientation events.
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3620
3621 2019-03-11  Youenn Fablet  <youenn@apple.com>
3622
3623         Allow storage quota increase by default in WTR
3624         https://bugs.webkit.org/show_bug.cgi?id=195541
3625
3626         Reviewed by Geoffrey Garen.
3627
3628         Allow storage quota increase by default in WTR.
3629         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3630         Use this for tests that explicitly need cache increase.
3631
3632         Instead of increasing quota by 2, make sure the next request is
3633         granted by adding all given parameters.
3634
3635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3636         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3637         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3638         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3640         * WebKitTestRunner/TestController.cpp:
3641         (WTR::TestController::setAllowStorageQuotaIncrease):
3642         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3643         * WebKitTestRunner/TestController.h:
3644         * WebKitTestRunner/TestInvocation.cpp:
3645         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3646         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3647         (WTR::TestController::cocoaResetStateToConsistentValues):
3648         (WTR::TestController::setAllowStorageQuotaIncrease):
3649         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3650         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3651         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3652
3653 2019-03-11  Xan Lopez  <xan@igalia.com>
3654
3655         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3656         https://bugs.webkit.org/show_bug.cgi?id=194147
3657
3658         Reviewed by Michael Saboff.
3659
3660         To make --32-bit work correctly on Linux/64bit we need to:
3661
3662         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3663         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3664         unfortunately CMake only allows us to do this during
3665         crosscompilation, which is overkill here.
3666         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3667         pkg-config detection module uses the x86 .pc files instead of the
3668         x86_64 ones.
3669         - Set the -m32 flags for the compiler.
3670
3671         * Scripts/webkitdirs.pm:
3672         (generateBuildSystemFromCMakeProject):
3673
3674 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3675
3676         Add MotionMark-1.1 plan file for run-benchmark script.
3677         https://bugs.webkit.org/show_bug.cgi?id=195481
3678
3679         Rubber-stamped by Darin Adler.
3680
3681         Run-benchmark script should support MontionMark-1.1.
3682
3683         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3684
3685 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3686
3687         [ews-app] Add support for submit-to-ews url
3688         https://bugs.webkit.org/show_bug.cgi?id=195477
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3693         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3694         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3695         * BuildSlaveSupport/ews-app/ews/urls.py:
3696         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3697
3698 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3699
3700         Unreviewed, rolling out r242688, r242643, r242624.
3701
3702         Caused multiple layout test failures and crashes on iOS and macOS.
3703
3704         Reverted changeset:
3705
3706         "requestAnimationFrame should execute before the next frame"
3707         https://bugs.webkit.org/show_bug.cgi?id=177484
3708         https://trac.webkit.org/changeset/242624/webkit
3709
3710         * Tracing/SystemTracePoints.plist:
3711
3712 2019-03-11  John Wilander  <wilander@apple.com>
3713
3714         Resource Load Statistics: Make it possible exclude localhost from classification
3715         https://bugs.webkit.org/show_bug.cgi?id=195474
3716         <rdar://problem/47520577>
3717
3718         Reviewed by Brent Fulgham.
3719
3720         This patch allows for localhost to be excluded from classification and
3721         treatment as a prevalent resource.
3722
3723         The WebKit Tools change adds a new function called
3724         testRunner.setStatisticsIsRunningTest() which can be used to control this
3725         behavior.
3726
3727         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3729         (WTR::TestRunner::setStatisticsIsRunningTest):
3730         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3731         * WebKitTestRunner/TestController.cpp:
3732         (WTR::TestController::setStatisticsIsRunningTest):
3733         * WebKitTestRunner/TestController.h:
3734         * WebKitTestRunner/TestInvocation.cpp:
3735         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3736
3737 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3738
3739         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3740         https://bugs.webkit.org/show_bug.cgi?id=195560
3741
3742         Reviewed by Lucas Forschler.
3743
3744         * BuildSlaveSupport/ews-build/master.cfg:
3745
3746 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3747
3748         Unreviewed, rolling out r242698.
3749
3750         API test crashes on bots.
3751
3752         Reverted changeset:
3753
3754         "Add a WKContentRuleList variant that uses copied memory
3755         instead of mmap'd shared memory for class A containerized
3756         apps"
3757         https://bugs.webkit.org/show_bug.cgi?id=195511
3758         https://trac.webkit.org/changeset/242698
3759
3760 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3761
3762         [WPE] Enable web process sandbox
3763         https://bugs.webkit.org/show_bug.cgi?id=195169
3764
3765         Reviewed by Daniel Bates.
3766
3767         * wpe/install-dependencies:
3768         * wpe/jhbuild.modules:
3769
3770 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3771
3772         [ews-app] Use port 17000 for worker communication
3773         https://bugs.webkit.org/show_bug.cgi?id=195558
3774
3775         Reviewed by Lucas Forschler.
3776
3777         * BuildSlaveSupport/ews-build/master.cfg:
3778
3779 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3780
3781         [ews-build] unit-tests fail when passwords.json is missing
3782         https://bugs.webkit.org/show_bug.cgi?id=195557
3783
3784         Reviewed by Lucas Forschler.
3785
3786         * BuildSlaveSupport/ews-build/loadConfig.py:
3787         (loadBuilderConfig):
3788         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3789         (ConfigDotJSONTest.test_configuration):
3790         * BuildSlaveSupport/ews-build/master.cfg:
3791
3792 2019-03-11  Truitt Savell  <tsavell@apple.com>
3793
3794         Unreviewed, rolling out r242702.
3795
3796         Broke High Sierra builders.
3797
3798         Reverted changeset:
3799
3800         "Add utility function to allow easy reverse range-based
3801         iteration of a container"
3802         https://bugs.webkit.org/show_bug.cgi?id=195542
3803         https://trac.webkit.org/changeset/242702
3804
3805 2019-03-11  Sam Weinig  <sam@webkit.org>
3806
3807         Add utility function to allow easy reverse range-based iteration of a container
3808         https://bugs.webkit.org/show_bug.cgi?id=195542
3809
3810         Reviewed by Antti Koivisto.
3811
3812         * TestWebKitAPI/CMakeLists.txt:
3813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3814         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3815         (TestWebKitAPI::TEST):
3816         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3817
3818 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3819
3820         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3821         https://bugs.webkit.org/show_bug.cgi?id=195511
3822         <rdar://problem/44873269>
3823
3824         Reviewed by Darin Adler.
3825
3826         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3827         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3828         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3829         (TEST_F):
3830
3831 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3832
3833         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3834         https://bugs.webkit.org/show_bug.cgi?id=195499
3835
3836         Reviewed by Darin Adler.
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3840         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3841         (-[WKWebView synchronouslyFocusTextInputContext:]):
3842         (applyStyle):
3843         (applyIframe):
3844         (TEST):
3845         Add some tests for this SPI.
3846
3847 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3848
3849         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3850         https://bugs.webkit.org/show_bug.cgi?id=181151
3851
3852         Reviewed by Don Olmstead.
3853
3854         * TestWebKitAPI/CMakeLists.txt:
3855         * TestWebKitAPI/PlatformWin.cmake:
3856         Enable TestWTF RunLoop tests in all platforms.
3857
3858         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3859         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3860         (TestWebKitAPI::DerivedOneShotTimer::fired):
3861         (TestWebKitAPI::TEST):
3862         Only a few platforms support nested RunLoop.
3863
3864         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3865         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3866
3867 2019-03-10  David Quesada  <david_quesada@apple.com>
3868
3869         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3870         https://bugs.webkit.org/show_bug.cgi?id=152480
3871
3872         Reviewed by Chris Dumez.
3873
3874         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3875         there are no additional references to the process pool besides the one held by
3876         the download, waits for the download to finish (in the sense that the
3877         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3878         measure, also check that the process pool has been deallocated at the end of the
3879         test. The test wouldn't be meaningful if the process pool were still alive.
3880
3881         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3882         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3883         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3884             The download will be canceled because the delegate does not implement the
3885             method to decide the download's destination, so this is where we know the
3886             DownloadProxyMap is done with the DownloadProxy.
3887         (TEST):
3888
3889 2019-03-08  Chris Dumez  <cdumez@apple.com>
3890
3891         Add support for Device Orientation / Motion permission API
3892         https://bugs.webkit.org/show_bug.cgi?id=195329
3893         <rdar://problem/47645367>
3894
3895         Reviewed by Geoffrey Garen.
3896
3897         Add test infrastructure to help test the Device Orientation / Motion permission API.
3898
3899         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3901         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3903         * WebKitTestRunner/TestController.cpp:
3904         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3905         (WTR::TestController::createWebViewWithOptions):
3906         (WTR::TestController::resetStateToConsistentValues):
3907         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3908         * WebKitTestRunner/TestController.h:
3909         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3910         * WebKitTestRunner/TestInvocation.cpp:
3911         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3912
3913 2019-03-08  Saam barati  <sbarati@apple.com>
3914
3915         Add a compare-results script to compare benchmark results
3916         https://bugs.webkit.org/show_bug.cgi?id=195486
3917         <rdar://problem/48723397>
3918
3919         Reviewed by Geoffrey Garen.
3920
3921         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3922         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3923         to extend it to learn about our other benchmarks.
3924
3925         * Scripts/compare-results: Added.
3926         (readJSONFile):
3927         (detectJetStream2):
3928         (JetStream2Results):
3929         (detectSpeedometer2):
3930         (Speedometer2Results):
3931         (detectPLT5):
3932         (PLT5Results):
3933         (detectBenchmark):
3934         (biggerIsBetter):
3935         (ttest):
3936         (getOptions):
3937         (main):
3938
3939 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3940
3941         Ensure old tab state is cleared between iterations of run-benchmark
3942         https://bugs.webkit.org/show_bug.cgi?id=195393
3943         <rdar://problem/46885583>
3944
3945         Reviewed by Dewei Zhu.
3946
3947         a) ensure the default to restore state is not set
3948         b) terminate Safari correctly
3949         c) Set the system default to ignore Persistent State in Safari
3950
3951         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3952         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3953         (OSXBrowserDriver.prepare_env): 
3954         (OSXBrowserDriver.restore_env):
3955         (OSXBrowserDriver.close_browsers):
3956         (OSXBrowserDriver._terminate_processes):
3957         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3958         (OSXChromeDriver):
3959         (OSXChromeCanaryDriver):
3960         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3961         (OSXFirefoxDriver):
3962         (OSXFirefoxNightlyDriver):
3963         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3964         (OSXSafariDriver):
3965         (OSXSafariDriver.prepare_env):
3966
3967 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3968
3969         [GTK] Several InputMethodFilter tests are failing
3970         https://bugs.webkit.org/show_bug.cgi?id=195408
3971
3972         Reviewed by Carlos Garcia Campos.
3973
3974         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3975         Regressed in r241751.
3976         Hexadecimal values of keycodes are expressed now in upper letters.
3977         Composited characters should be cast to UTF8 strings.
3978
3979         (TestWebKitAPI::TEST):
3980
3981 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3982
3983         [GTK] Make Tools/gtkdoc python3 compatible
3984         https://bugs.webkit.org/show_bug.cgi?id=195359
3985
3986         Reviewed by Carlos Garcia Campos.
3987
3988         * gtkdoc/generate-gtkdoc:
3989         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3990         work with Python 2 and 3.
3991         (get_gtkdoc_module_paths):
3992         The iteritems() was removed in Python 3, so let's use items() that's
3993         available in Python 2 and 3.
3994         (get_generator_for_config):
3995         * gtkdoc/gtkdoc.py:
3996         (GTKDoc._run_command):
3997         The sys.stdout.write() is expecting str in Python 3 and not bytes
3998         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3999         for passing the bytes there.
4000
4001 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4002
4003         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4004         https://bugs.webkit.org/show_bug.cgi?id=195346
4005         <rdar://problem/48667048>
4006
4007         Unreviewed build fix for clang-cl.
4008
4009         * DumpRenderTree/win/DumpRenderTree.cpp:
4010         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
4011
4012 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
4013
4014         requestAnimationFrame should execute before the next frame
4015         https://bugs.webkit.org/show_bug.cgi?id=177484
4016
4017         Reviewed by Simon Fraser.
4018
4019         Add trace points for the page RenderingUpdate.
4020
4021         * Tracing/SystemTracePoints.plist:
4022
4023 2019-03-07  Zalan Bujtas  <zalan@apple.com>
4024
4025         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
4026         https://bugs.webkit.org/show_bug.cgi?id=195353
4027         <rdar://problem/48626394>
4028
4029         Reviewed by Simon Fraser.
4030
4031         * WebKitTestRunner/ios/TestControllerIOS.mm:
4032         (WTR::TestController::platformResetPreferencesToConsistentValues):
4033
4034 2019-03-07  John Wilander  <wilander@apple.com>
4035
4036         Resource Load Statistics: Make it possible to purge only script-accessible cookies
4037         https://bugs.webkit.org/show_bug.cgi?id=195383
4038         <rdar://problem/48570136>
4039
4040         Reviewed by Brent Fulgham.
4041
4042         This patch adds test infrastructure to purge only script-accessible cookies,
4043         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4044
4045         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4046         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4047         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4048         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4049         * WebKitTestRunner/TestController.cpp:
4050         (WTR::TestController::statisticsDeleteCookiesForHost):
4051         * WebKitTestRunner/TestController.h:
4052         * WebKitTestRunner/TestInvocation.cpp:
4053         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4054
4055 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4056
4057         Unreviewed, rolling out r242354.
4058         https://bugs.webkit.org/show_bug.cgi?id=195402
4059
4060         breaks layout tests in all configurations (Requested by
4061         zdobersek on #webkit).
4062
4063         Reverted changeset:
4064
4065         "[WPE] Enable web process sandbox"
4066         https://bugs.webkit.org/show_bug.cgi?id=195169
4067         https://trac.webkit.org/changeset/242354
4068
4069 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4070
4071         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4072         https://bugs.webkit.org/show_bug.cgi?id=195346
4073
4074         Reviewed by Fujii Hironori.
4075
4076         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4077         (TestWebKitAPI::TEST):
4078         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4079
4080         * DumpRenderTree/win/DumpRenderTree.cpp:
4081         (findFontFallback):
4082         (addFontFallbackIfPresent):
4083         (removeFontFallbackIfPresent):
4084         (main):
4085         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4086         (TestWebKitAPI::Util::moduleDirectory):
4087         (TestWebKitAPI::Util::createInjectedBundlePath):
4088         Use wchar helpers as needed.
4089
4090 2019-03-06  Rob Buis  <rbuis@igalia.com>
4091
4092         Consider supporting the `referrerpolicy` attribute.
4093         https://bugs.webkit.org/show_bug.cgi?id=179053
4094
4095         Reviewed by Darin Adler.
4096
4097         Add a runtime flag for referrerpolicy attribute.
4098
4099         * DumpRenderTree/mac/DumpRenderTree.mm:
4100         (enableExperimentalFeatures):
4101
4102 2019-03-05  Daniel Bates  <dabates@apple.com>
4103
4104         Update expected API test result following r242379
4105         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4106
4107         Update expected x-coordinate of selection rect now that the left padding of
4108         a textarea is sized in ems (so dependent on the font size) just like the left
4109         padding of a text field.
4110
4111         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4112         (TestWebKitAPI::TEST):
4113
4114 2019-03-05  David Quesada  <david_quesada@apple.com>
4115
4116         [WK2] It should be possible to follow links with 'download' attributes
4117         https://bugs.webkit.org/show_bug.cgi?id=195145
4118         rdar://problem/48462642
4119
4120         Reviewed by Alex Christensen.
4121
4122         Add a unit test to verify that activating links with 'download' attributes now
4123         navigates to the linked resource, rather than starts downloading it. Add another
4124         to verify that it is still possible to explicitly download the link via the
4125         'Download' navigation action policy.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4128         (-[DownloadAttributeTestDelegate init]):
4129         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4130         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4131         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4132         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4133         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4134         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4135         (TEST):
4136         * WebKitTestRunner/TestController.cpp:
4137         (WTR::TestController::decidePolicyForNavigationAction):
4138         * WebKitTestRunner/TestController.h:
4139
4140 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4141
4142         [Curl] Implement Cookie Accept Policy.
4143         https://bugs.webkit.org/show_bug.cgi?id=191645
4144
4145         Reviewed by Fujii Hironori.
4146
4147         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4148         (TestWebKitAPI::Curl::TEST_F):
4149
4150 2019-03-05  Youenn Fablet  <youenn@apple.com>
4151
4152         Rename requestCacheStorageSpace to requestStorageSpace
4153         https://bugs.webkit.org/show_bug.cgi?id=195282
4154
4155         Reviewed by Chris Dumez.
4156
4157         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4158         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4159         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4160
4161 2019-03-05  Brady Eidson  <beidson@apple.com>
4162
4163         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4164         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4165
4166         Reviewed by Tim Horton.
4167
4168         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4169         different directory into that same WKWebView should work.
4170
4171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4172         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4173
4174 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4175
4176         Add WeakHashSet
4177         https://bugs.webkit.org/show_bug.cgi?id=195152
4178
4179         Reviewed by Antti Koivisto.
4180
4181         Added tests for WeakHashSet.
4182
4183         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4184         (TestWebKitAPI::Base::Base): Moved.
4185         (TestWebKitAPI::Derived::foo): Moved.
4186         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4187         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4188         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4189         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4190
4191 2019-03-04  Chris Dumez  <cdumez@apple.com>
4192
4193         Do not share WebProcesses between private and regular sessions
4194         https://bugs.webkit.org/show_bug.cgi?id=195189
4195         <rdar://problem/48421064>
4196
4197         Reviewed by Alex Christensen.
4198
4199         Add API test coverage.
4200
4201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4202         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4203
4204 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4205
4206         [WPE] Enable web process sandbox
4207         https://bugs.webkit.org/show_bug.cgi?id=195169
4208
4209         Reviewed by Daniel Bates.
4210
4211         * wpe/install-dependencies:
4212         * wpe/jhbuild.modules:
4213
4214 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4215
4216         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4217         https://bugs.webkit.org/show_bug.cgi?id=195206
4218
4219         Reviewed by Žan Doberšek.
4220
4221         Add a new test case.
4222
4223         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4224         (testJSCClass):
4225
4226 2019-03-04  Charlie Turner  <cturner@igalia.com>
4227
4228         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4229         https://bugs.webkit.org/show_bug.cgi?id=194898
4230
4231         Reviewed by Žan Doberšek.
4232
4233         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4234         a GCC extension that permits arithmetic on void* pointer. Inline
4235         the macro until this issue is fixed upstream.
4236
4237 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4238
4239         Rid the world of WK_API_ENABLED
4240         https://bugs.webkit.org/show_bug.cgi?id=195263
4241
4242         Reviewed by Dan Bernstein.
4243
4244         List of changed files elided because it's useless.
4245
4246 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4247
4248         Unreviewed follow-up to r242292.
4249
4250         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4251
4252         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4253         (TestWebKitAPI::testStrip): Renamed from strip.
4254         (TestWebKitAPI::TEST):
4255
4256 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4257
4258         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4259
4260         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4261         and bug #194272 for details.
4262
4263         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4264
4265 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4266
4267         Remove some more unused 32-bit code
4268         https://bugs.webkit.org/show_bug.cgi?id=195255
4269
4270         Reviewed by Darin Adler.
4271
4272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4273         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4274         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4275         (NPP_New):
4276         (NPP_HandleEvent):
4277         (handleEventCarbon): Deleted.
4278
4279 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4280
4281         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4282
4283         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4284         (TestWebKitAPI::TEST):
4285
4286 2019-03-01  Darin Adler  <darin@apple.com>
4287
4288         Finish removing String::format
4289         https://bugs.webkit.org/show_bug.cgi?id=194893
4290
4291         Reviewed by Daniel Bates.
4292 '
4293         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4294
4295 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4296
4297         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4298         https://bugs.webkit.org/show_bug.cgi?id=195229
4299         <rdar://problem/48520362>
4300
4301         Reviewed by Chris Dumez.
4302
4303         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4304         (TEST):
4305
4306 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4307
4308         Add a system trace scope for event region building
4309         https://bugs.webkit.org/show_bug.cgi?id=195226
4310
4311         Reviewed by Jon Lee.
4312
4313         This trace scope measures the time spend converting element rects into Region objects,
4314         which can be large on some pages.
4315
4316         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4317
4318         * Tracing/SystemTracePoints.plist:
4319
4320 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4321
4322         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4323         https://bugs.webkit.org/show_bug.cgi?id=194612
4324
4325         Reviewed by Alex Christensen.
4326
4327         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4328         Just test the new string-processing function and don't touch the actual environment.
4329         (Test cases are all as before, but based on operator== instead of strcmp.)
4330
4331 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4332
4333         [ews-app] Update primary keys for handling multiple Buildbot instances
4334         https://bugs.webkit.org/show_bug.cgi?id=195120
4335
4336         Reviewed by Stephanie Lewis.
4337
4338         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4339         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4340         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4341
4342         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4343         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4344         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4345         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4346         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4347         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4348
4349 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4350
4351         [WinCairo] Enable service worker
4352         https://bugs.webkit.org/show_bug.cgi?id=188318
4353
4354         Reviewed by Youenn Fablet.
4355
4356         * DumpRenderTree/DumpRenderTreePrefix.h:
4357         * TestWebKitAPI/PlatformWin.cmake:
4358         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4359         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4360         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4361
4362 2019-03-01  Justin Fan  <justin_fan@apple.com>