[iOS] Do not allow starting selection drags when selection views are not visible
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] Do not allow starting selection drags when selection views are not visible
4         https://bugs.webkit.org/show_bug.cgi?id=196686
5         <rdar://problem/49399192>
6
7         Reviewed by Tim Horton.
8
9         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
10         also add some new API tests to cover scenarios where the web view is not first responder.
11
12         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
15
16         Add a switch to optionally make the web view first responder when starting the simulated drag.
17
18         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
19         (-[DragAndDropSimulator initWithWebView:]):
20         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
21
22 2019-04-08  Justin Fan  <justin_fan@apple.com>
23
24         [Web GPU] Fix Web GPU experimental feature on iOS
25         https://bugs.webkit.org/show_bug.cgi?id=196632
26
27         Reviewed by Myles C. Maxfield.
28
29         Properly make Web GPU available on iOS 11+.
30
31         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
32
33 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
34
35         [ews-build] Do not upload archive when Compile Fails
36         https://bugs.webkit.org/show_bug.cgi?id=196674
37
38         Reviewed by Alexey Proskuryakov.
39
40         * BuildSlaveSupport/ews-build/factories.py:
41         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
42         * BuildSlaveSupport/ews-build/steps.py:
43         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
44         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
45         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
46
47 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
48
49         Enable DFG on MIPS
50         https://bugs.webkit.org/show_bug.cgi?id=196689
51
52         Reviewed by Žan Doberšek.
53
54         Since the bytecode change, we enabled the baseline JIT on mips in
55         r240432, but DFG is still missing. With this change, all tests are
56         passing on a ci20 board.
57
58         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
59
60 2019-04-08  Philippe Normand  <pnormand@igalia.com>
61
62         [Flatpak] Second run update-webkitwpe-flatpak fails
63         https://bugs.webkit.org/show_bug.cgi?id=192702
64
65         Reviewed by Carlos Garcia Campos.
66
67         * flatpak/flatpakutils.py:
68         (FlatpakObject.flatpak): Fix typo.
69         (FlatpakPackage.install): When installing, also update to the configured remote commit.
70         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
71
72 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
73
74         [GTK][WPE] outlook.live.com displays old-fashioned UI
75         https://bugs.webkit.org/show_bug.cgi?id=196642
76
77         Reviewed by Carlos Garcia Campos.
78
79         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
80         (TestWebKitAPI::TEST): New Mac platform quirk test.
81
82 2019-04-07  Commit Queue  <commit-queue@webkit.org>
83
84         Unreviewed, rolling out r243956.
85         https://bugs.webkit.org/show_bug.cgi?id=196688
86
87         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
88         by aakashjain on #webkit).
89
90         Reverted changeset:
91
92         "Clicking "Go Back" from a safe browsing warning from an
93         iframe should navigate the WKWebView back to the previous
94         page"
95         https://bugs.webkit.org/show_bug.cgi?id=196665
96         https://trac.webkit.org/changeset/243956
97
98 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
99
100         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
101         https://bugs.webkit.org/show_bug.cgi?id=196669
102
103         Reviewed by Geoffrey Garen.
104
105         Added three new unit tests for WeakHashSet.
106
107         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
108         (WTF_WeakPtr.WeakHashSetConstObjects):
109         (WTF_WeakPtr.WeakHashSetComputesEmpty):
110         (WTF_WeakPtr.WeakHashSetComputeSize):
111
112 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
113
114         Hide next and previous form control buttons when WKWebView is editable
115         https://bugs.webkit.org/show_bug.cgi?id=196672
116         <rdar://problem/35625321>
117
118         Reviewed by Tim Horton.
119
120         Add a new API test.
121
122         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
123         (-[TestWKWebView lastTrailingBarButtonGroup]):
124         (TestWebKitAPI::TEST):
125         * TestWebKitAPI/ios/UIKitSPI.h:
126
127 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
128
129         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
130         https://bugs.webkit.org/show_bug.cgi?id=196077
131         <rdar://problem/49108202>
132
133         Reviewed by Chris Dumez.
134
135         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
136         on new web view.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
139
140 2019-04-05  Saam Barati  <sbarati@apple.com>
141
142         Make compare-results understand MotionMark
143         https://bugs.webkit.org/show_bug.cgi?id=196666
144
145         Reviewed by Yusuke Suzuki.
146
147         * Scripts/compare-results:
148         (PLT5Results):
149         (detectMotionMark):
150         (detectMotionMark1_1):
151         (motionMarkResults):
152         (motionMark1_1Results):
153         (detectBenchmark):
154         (biggerIsBetter):
155         (main):
156
157 2019-04-05  Alex Christensen  <achristensen@webkit.org>
158
159         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
160         https://bugs.webkit.org/show_bug.cgi?id=196665
161         <rdar://45115669>
162
163         Reviewed by Geoff Garen.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
166         (goBack):
167         (+[SimpleLookupContext sharedLookupContext]):
168         (-[SimpleLookupContext lookUpURL:completionHandler:]):
169         (TEST):
170         (+[Simple3LookupContext sharedLookupContext]): Deleted.
171         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
172
173 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-build] Add configuration and architecture for windows builders
176         https://bugs.webkit.org/show_bug.cgi?id=196660
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-build/config.json:
181
182 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
183
184         webkitpy: Don't run subsequent rounds if interrupted
185         https://bugs.webkit.org/show_bug.cgi?id=196646
186
187         Reviewed by Aakash Jain.
188
189         * Scripts/webkitpy/layout_tests/controllers/manager.py:
190         (Manager.run): Bail out if interrupted.
191
192 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
193
194         Test sessionStorage in PSON private browsing mode
195         https://bugs.webkit.org/show_bug.cgi?id=196561
196
197         Reviewed by Alex Christensen.
198
199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
200
201 2019-04-05  Commit Queue  <commit-queue@webkit.org>
202
203         Unreviewed, rolling out r243833.
204         https://bugs.webkit.org/show_bug.cgi?id=196645
205
206         This change breaks build of WPE and GTK ports (Requested by
207         annulen on #webkit).
208
209         Reverted changeset:
210
211         "[CMake][WTF] Mirror XCode header directories"
212         https://bugs.webkit.org/show_bug.cgi?id=191662
213         https://trac.webkit.org/changeset/243833
214
215 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
216
217         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
218         https://bugs.webkit.org/show_bug.cgi?id=196635
219
220         Reviewed by Antti Koivisto.
221         
222         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
223         for a test to enable async frame scrolling via:
224             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
225         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
226         
227         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
228
229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
230         (WTR::InjectedBundle::beginTesting):
231         * WebKitTestRunner/TestController.cpp:
232         (WTR::TestController::resetPreferencesToConsistentValues):
233
234 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
235
236         Use a correct LC_RPATH when building with ASan
237         https://bugs.webkit.org/show_bug.cgi?id=196576
238
239         Reviewed by David Kilzer.
240
241         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
242         so that ../Frameworks is checked. This is simpler and more reliable than updating
243         each SPC service xcconfig.
244
245 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
246
247         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
248         https://bugs.webkit.org/show_bug.cgi?id=196629
249
250         Reviewed by Lucas Forschler.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
253
254 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
255
256         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
257         https://bugs.webkit.org/show_bug.cgi?id=196618
258
259         Reviewed by Lucas Forschler.
260
261         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
262         (StatusBubble): Added QUEUE_TRIGGERS.
263         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
264         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
265         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
266         its parent(builder).
267
268 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
269
270         [ews-app] Status-bubble steps are sometimes displayed in reverse order
271         https://bugs.webkit.org/show_bug.cgi?id=196625
272
273         Reviewed by Lucas Forschler.
274
275         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
276         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
277
278 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
279
280         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
281         https://bugs.webkit.org/show_bug.cgi?id=196630
282
283         Reviewed by Wenson Hsieh.
284
285         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
286
287 2019-04-04  Youenn Fablet  <youenn@apple.com>
288
289         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
290         https://bugs.webkit.org/show_bug.cgi?id=196543
291
292         Reviewed by Alex Christensen.
293
294         * WebKitTestRunner/TestController.cpp:
295         (WTR::TestController::generatePageConfiguration):
296
297 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
298
299         [ews-app] Status bubble should not display skipped buildbot steps
300         https://bugs.webkit.org/show_bug.cgi?id=196584
301
302         Reviewed by Lucas Forschler.
303
304         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
305
306 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
307
308         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
309         https://bugs.webkit.org/show_bug.cgi?id=196620
310
311         Reviewed by Lucas Forschler.
312
313         * BuildSlaveSupport/ews-app/ews/config.py:
314
315 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
316
317         [Win] DumpRenderTreeWatchDog.py is not checked into source
318         https://bugs.webkit.org/show_bug.cgi?id=196567
319         <rdar://problem/49525901>
320
321         Reviewed by Lucas Forschler.
322
323         This script is used on Win EWS bots to terminate hanging DRT processes.
324
325         * EWSTools/dumprendertreewatchdog.py: Added.
326
327 2019-04-04  Chris Dumez  <cdumez@apple.com>
328
329         Unreviewed, roll out r243858 which made tests time out.
330
331         Disable new API tests on Windows instead.
332
333         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
334         (TestWebKitAPI::TEST):
335
336 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
337
338         [ATK] Cleanup WebPageAccessibilityObjectAtk
339         https://bugs.webkit.org/show_bug.cgi?id=196537
340
341         Reviewed by Michael Catanzaro.
342
343         Also consider files under atk directories as exceptions for GObject conventions.
344
345         * Scripts/webkitpy/style/checkers/cpp.py:
346         (check_identifier_name_in_declaration):
347
348 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
349
350         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
351         https://bugs.webkit.org/show_bug.cgi?id=196588
352         <rdar://problem/49365787>
353
354         Unreviewed build fix for Windows port.
355
356         error C3861: 'kill': identifier not found
357
358         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
359         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
360
361 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
362
363         [ews-build] Cancel build and similar operations should have authentication
364         https://bugs.webkit.org/show_bug.cgi?id=196520
365
366         Reviewed by Dewei Zhu.
367
368         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
369         environment variables.
370
371 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
372
373         [ews-build] Do not trigger queues which are not in production yet
374         https://bugs.webkit.org/show_bug.cgi?id=196581
375
376         Reviewed by Dewei Zhu.
377
378         * BuildSlaveSupport/ews-build/config.json:
379
380 2019-04-03  Chris Dumez  <cdumez@apple.com>
381
382         Unreviewed, fix typo in the name of API test added in r243848.
383
384         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
385         (TestWebKitAPI::TEST):
386
387 2019-04-03  Chris Dumez  <cdumez@apple.com>
388
389         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
390         https://bugs.webkit.org/show_bug.cgi?id=196588
391         <rdar://problem/49365787>
392
393         Reviewed by Ryosuke Niwa.
394
395         Add API test coverage.
396
397         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
398         (TestWebKitAPI::nullJavaScriptCallback):
399         (TestWebKitAPI::didCrashCheckFrames):
400         (TestWebKitAPI::TEST):
401
402 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
403
404         run-webkit-tests: Upload test results (new results database)
405         https://bugs.webkit.org/show_bug.cgi?id=196577
406         <rdar://problem/34841155>
407
408         Reviewed by Lucas Forschler.
409
410         * Scripts/webkitpy/layout_tests/controllers/manager.py:
411         (Manager.run): Upload results after each device shard, since the configuration will be
412         different for each device.
413         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
414         uploaded to a results database.
415         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
416         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
417
418 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
419
420         -apple-trailing-word is needed for browser detection
421         https://bugs.webkit.org/show_bug.cgi?id=196575
422
423         Unreviewed.
424
425         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
426
427 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
428
429         [CMake][WTF] Mirror XCode header directories
430         https://bugs.webkit.org/show_bug.cgi?id=191662
431
432         Reviewed by Konstantin Tokarev.
433
434         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
435         builds.
436
437         * CMakeLists.txt:
438         * DumpRenderTree/CMakeLists.txt:
439         * DumpRenderTree/PlatformWin.cmake:
440         * MiniBrowser/win/CMakeLists.txt:
441         * TestWebKitAPI/CMakeLists.txt:
442         * TestWebKitAPI/PlatformWin.cmake:
443         * WebKitTestRunner/PlatformGTK.cmake:
444         * WebKitTestRunner/PlatformWin.cmake:
445
446 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
447
448         [ews-app] Status bubble should not display certain infrastructure status messages
449         https://bugs.webkit.org/show_bug.cgi?id=196550
450
451         Reviewed by Lucas Forschler.
452
453         Do not display the steps which are un-needed for end-user. This information is still avaiable
454         if the user click on the bubble and look at the Buildbot build.
455         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
456         (StatusBubble._steps_messages):
457         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
458
459 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews-build] Use https for sending data to ews-app
462         https://bugs.webkit.org/show_bug.cgi?id=196492
463
464         Reviewed by Lucas Forschler.
465
466         * BuildSlaveSupport/ews-build/events.py:
467
468 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
469
470         Remove support for -apple-trailing-word
471         https://bugs.webkit.org/show_bug.cgi?id=196525
472
473         Reviewed by Zalan Bujtas.
474
475         This CSS property is nonstandard and not used.
476
477         * Scripts/webkitperl/FeatureList.pm:
478         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
479
480 2019-04-03  Youenn Fablet  <youenn@apple.com>
481
482         Add a test for DOMCache on multiple browsing in case of private browsing
483         https://bugs.webkit.org/show_bug.cgi?id=196524
484
485         Reviewed by Alex Christensen.
486
487         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
488         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
489
490 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
491
492         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
493         https://bugs.webkit.org/show_bug.cgi?id=196540
494
495         Reviewed by Aakash Jain.
496
497         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
498
499 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
500
501         Add plumbing for a compatibility mode preference in WebKit
502         https://bugs.webkit.org/show_bug.cgi?id=196005
503
504         Reviewed by Tim Horton.
505
506         Add new API tests.
507
508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
509         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
510
511 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
512
513         [WPE][GTK] Update libsrtp dependency package for Debian
514         https://bugs.webkit.org/show_bug.cgi?id=196528
515
516         Reviewed by Frédéric Wang.
517
518         * gtk/install-dependencies:
519         * wpe/install-dependencies:
520
521 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
522
523         [WK2] Add support for Window's beforeprint / afterprint events
524         https://bugs.webkit.org/show_bug.cgi?id=196478
525         <rdar://problem/49535124>
526
527         Unreviewed build fix for MSVC.
528
529         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
530
531         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
532
533         * WebKitTestRunner/TestController.cpp:
534         (WTR::printFrame): Use int and float literals.
535
536 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-build] Reassign bots to queues
539
540         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
541
542 2019-04-02  Chris Dumez  <cdumez@apple.com>
543
544         [WK2] Add support for Window's beforeprint / afterprint events
545         https://bugs.webkit.org/show_bug.cgi?id=196478
546
547         Reviewed by Alex Christensen.
548
549         Add minimal implementation for printFrame in WebKitTestRunner.
550
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::printFrame):
553         (WTR::TestController::createOtherPage):
554         (WTR::TestController::createWebViewWithOptions):
555
556 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
557
558         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
559         https://bugs.webkit.org/show_bug.cgi?id=196491
560
561         Reviewed by Lucas Forschler.
562
563         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
564
565 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
566
567         [ews-build] Configure buildbot try credentials in environment variables
568         https://bugs.webkit.org/show_bug.cgi?id=196501
569
570         Reviewed by Lucas Forschler.
571
572         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
573         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
574         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
575
576 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
577
578         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
579         https://bugs.webkit.org/show_bug.cgi?id=196496
580         <rdar://problem/49521634>
581
582         Reviewed by Chris Dumez.
583
584         Add new API tests (see WebKit ChangeLog for more detail).
585
586         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
587         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
588         (TEST):
589
590 2019-04-02  David Kilzer  <ddkilzer@apple.com>
591
592         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
593         <https://webkit.org/b/196499>
594
595         Reviewed by Alexey Proskuryakov.
596
597         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
598         ENABLE_ADDRESS_SANITIZER.
599
600 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
601
602         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
603         https://bugs.webkit.org/show_bug.cgi?id=182757
604
605         Reviewed by Don Olmstead.
606
607         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
608         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
609
610 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
611
612         run-api-tests: Upload test results
613         https://bugs.webkit.org/show_bug.cgi?id=196323
614         <rdar://problem/49356714>
615
616         Reviewed by Lucas Forschler.
617
618         * Scripts/webkitpy/api_tests/manager.py:
619         (Manager):
620         (Manager.run): Upload results to a results database.
621         * Scripts/webkitpy/api_tests/run_api_tests.py:
622         (parse_args): Add upload arguments.
623         * Scripts/webkitpy/port/base.py:
624         (Port):
625         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
626         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
627         with commits from any other associated repositories.
628         * Scripts/webkitpy/port/device.py:
629         (Device):
630         (Device.build_version): Access build_versoin of underlying platform device.
631         * Scripts/webkitpy/port/ios_simulator_unittest.py:
632         (IOSSimulatorTest):
633         (IOSSimulatorTest.test_configuration_for_upload):
634         * Scripts/webkitpy/port/device_port.py:
635         (DevicePort):
636         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
637         the same as the machine uploading results.
638         * Scripts/webkitpy/port/mac.py:
639         (MacPort):
640         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
641         * Scripts/webkitpy/port/mac_unittest.py:
642         (MacTest):
643         (MacTest.test_configuration_for_upload):
644         * Scripts/webkitpy/xcode/simulated_device.py:
645         (SimulatedDeviceManager._create_device_with_runtime):
646         (SimulatedDevice.__init__): Create simulated device with a build_version.
647         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
648         (test_existing_simulator):
649
650 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
651
652         Remove extra newline characters (Follow-up fix to r243707)
653
654         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
655
656 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews-app] Use API_KEY to accept results data
659         https://bugs.webkit.org/show_bug.cgi?id=196461
660
661         Reviewed by Dewei Zhu.
662
663         * BuildSlaveSupport/ews-app/ews/views/results.py:
664         (Results.post): Validate EWS_API_KEY before accepting any data.
665         * BuildSlaveSupport/ews-build/events.py:
666         (Events.sendData): Send EWS_API_KEY if available along with event data.
667
668 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
669
670         Unable to copy and paste a PDF from Notes into Mail compose body
671         https://bugs.webkit.org/show_bug.cgi?id=196442
672         <rdar://problem/48573098>
673
674         Reviewed by Tim Horton.
675
676         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
677         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
678         to be specified on the item providers.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
681         (TestWebKitAPI::mapItemForTesting):
682         (TestWebKitAPI::contactItemForTesting):
683
684 2019-04-01  Tim Horton  <timothy_horton@apple.com>
685
686         Make UIWKDocumentContext rects per-character instead of per-word
687         https://bugs.webkit.org/show_bug.cgi?id=196459
688
689         Reviewed by Wenson Hsieh.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
692         (TEST):
693         Adjust test results due to switching to per-character rects.
694
695 2019-04-01  Chris Dumez  <cdumez@apple.com>
696
697         UIProcess crash when a prewarmed process is terminated
698         https://bugs.webkit.org/show_bug.cgi?id=196451
699         <rdar://problem/49245471>
700
701         Reviewed by Geoffrey Garen.
702
703         Add API test coverage.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
706         (TEST):
707
708 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
709
710         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
711         https://bugs.webkit.org/show_bug.cgi?id=196449
712
713         Reviewed by Lucas Forschler.
714
715         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
716         (StatusBubble.get_os_details): Method to get OS and Xcode details.
717         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
718         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
719
720 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
721
722         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
723         https://bugs.webkit.org/show_bug.cgi?id=196444
724
725         Reviewed by Lucas Forschler.
726
727         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
728
729 2019-04-01  Alex Christensen  <achristensen@webkit.org>
730
731         Add SPI to canonicalize NSURLs with WTF::URL
732         https://bugs.webkit.org/show_bug.cgi?id=196415
733         <rdar://problem/44980271>
734
735         Reviewed by Darin Adler.
736
737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
738         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
739         (TestWebKitAPI::TEST):
740
741 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
742
743         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
744         https://bugs.webkit.org/show_bug.cgi?id=196441
745
746         Reviewed by Carlos Garcia Campos.
747
748         Don't cache the wpe_view_backend object that might not exist yet at the
749         time of EventSenderProxy constructor invocation, but instead retrieve
750         that object whenever it's required for event dispatching. This should
751         avoid crashes in this constructor now that it's invoked before any
752         PlatformWindow has been set up (as changed in r243496).
753
754         * WebKitTestRunner/EventSenderProxy.h:
755         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
756         (WTR::viewBackend):
757         (WTR::EventSenderProxy::EventSenderProxy):
758         (WTR::EventSenderProxy::mouseDown):
759         (WTR::EventSenderProxy::mouseUp):
760         (WTR::EventSenderProxy::mouseMoveTo):
761         (WTR::EventSenderProxy::mouseScrollBy):
762         (WTR::EventSenderProxy::keyDown):
763         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
764
765 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
766
767         [Win][WebKit] MiniBrowser should support high DPI display
768         https://bugs.webkit.org/show_bug.cgi?id=196391
769
770         Reviewed by Alex Christensen.
771
772         * MiniBrowser/win/WebKitBrowserWindow.cpp:
773         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
774         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
775         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
776
777 2019-03-31  Sam Weinig  <weinig@apple.com>
778
779         Remove more i386 specific configurations
780         https://bugs.webkit.org/show_bug.cgi?id=196430
781
782         Reviewed by Alexey Proskuryakov.
783
784         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
785         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
786
787 2019-03-31  Andy Estes  <aestes@apple.com>
788
789         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
790         https://bugs.webkit.org/show_bug.cgi?id=196433
791         <rdar://problem/49293305>
792
793         Reviewed by Tim Horton.
794
795         Enhanced API test coverage to include all navigation response policy decisions in both
796         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
799         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
800         (TestWebKitAPI::TEST):
801         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
802         (readFile):
803         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
804         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
805         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
806         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
807         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
808         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
809         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
810         (-[QuickLookDelegate _downloadDidStart:]):
811         (-[QuickLookDelegate _download:didReceiveResponse:]):
812         (-[QuickLookDelegate _download:didReceiveData:]):
813         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
814         (-[QuickLookDelegate _downloadDidFinish:]):
815         (-[QuickLookDelegate _download:didFailWithError:]):
816         (-[QuickLookDelegate _downloadDidCancel:]):
817         (-[QuickLookDelegate verifyDownload]):
818         (runTest):
819         (runTestDecideBeforeLoading):
820         (runTestDecideAfterLoading):
821         (TEST):
822         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
823         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
824         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
825         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
826         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
827         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
828         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
829         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
830         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
831         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
832         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
833         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
834         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
835         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
836
837 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
838
839         [CMake] add testdfg as target with build-jsc
840         https://bugs.webkit.org/show_bug.cgi?id=196393
841
842         Reviewed by Saam Barati.
843
844         Added testdfg as one of the targets to build when
845         using CMake.
846
847         * Scripts/build-jsc:
848
849 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
850
851         Delete WebMetal implementation in favor of WebGPU
852         https://bugs.webkit.org/show_bug.cgi?id=195418
853
854         Reviewed by Dean Jackson.
855
856         * DumpRenderTree/mac/DumpRenderTree.mm:
857         (enableExperimentalFeatures):
858         (resetWebPreferencesToConsistentValues):
859         * Scripts/webkitperl/FeatureList.pm:
860         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
862         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
863         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
864         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
865         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
866         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
867         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
868         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
869         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
870         (WTR::InjectedBundle::beginTesting):
871         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
872         (WTR::TestRunner::setWebMetalEnabled): Deleted.
873         * WebKitTestRunner/InjectedBundle/TestRunner.h:
874
875 2019-03-29  Chris Dumez  <cdumez@apple.com>
876
877         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
878         https://bugs.webkit.org/show_bug.cgi?id=196405
879         <rdar://problem/49428130>
880
881         Reviewed by Wenson Hsieh.
882
883         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
884         the popover presentation methods to be no-ops. Use this in the new test added in
885         r243523 so that we do not swizzle those methods for all tests. This is needed because
886         those WatchOS tests rely on the popover getting presented and interactive.
887
888         * WebKitTestRunner/TestController.cpp:
889         (WTR::updateTestOptionsFromTestHeader):
890         * WebKitTestRunner/TestController.h:
891         * WebKitTestRunner/TestOptions.h:
892         (WTR::TestOptions::hasSameInitializationOptions const):
893         * WebKitTestRunner/ios/TestControllerIOS.mm:
894         (WTR::TestController::platformInitialize):
895         (WTR::TestController::platformResetStateToConsistentValues):
896
897 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
898
899         [Curl] Add Server Trust Evaluation Support.
900         https://bugs.webkit.org/show_bug.cgi?id=191646
901
902         Reviewed by Fujii Hironori.
903
904         Implemented MiniBrowser UI for asking if user trusts the server.
905
906         * MiniBrowser/win/Common.cpp:
907         (askServerTrustEvaluation):
908         (replaceString):
909         * MiniBrowser/win/Common.h:
910         * MiniBrowser/win/MiniBrowserLib.rc:
911         * MiniBrowser/win/MiniBrowserLibResource.h:
912         * MiniBrowser/win/WebKitBrowserWindow.cpp:
913         (createPEMString):
914         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
915         (WebKitBrowserWindow::canTrustServerCertificate):
916         * MiniBrowser/win/WebKitBrowserWindow.h:
917
918 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
919
920         Implement ResizeObserver.
921         https://bugs.webkit.org/show_bug.cgi?id=157743
922
923         Reviewed by Simon Fraser.
924
925         Support resizeObserverEnabled webPreferences.
926
927         * DumpRenderTree/TestOptions.cpp:
928         (TestOptions::TestOptions):
929         * DumpRenderTree/TestOptions.h:
930         * DumpRenderTree/mac/DumpRenderTree.mm:
931         (setWebPreferencesForTestOptions):
932         * DumpRenderTree/win/DumpRenderTree.cpp:
933         (enableExperimentalFeatures):
934         * Scripts/webkitperl/FeatureList.pm:
935         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
936
937 2019-03-28  John Wilander  <wilander@apple.com>
938
939         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
940         https://bugs.webkit.org/show_bug.cgi?id=196281
941         <rdar://problem/48938748>
942
943         Reviewed by Alex Christensen.
944
945         This patch adds the function isStatisticsHasLocalStorage() to the
946         TestRunner. With it, the page can query the WebsiteDataStore in the
947         UI process to make sure that it sees LocalStorage.
948
949         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
950         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
951         (WTR::TestRunner::isStatisticsHasLocalStorage):
952         * WebKitTestRunner/InjectedBundle/TestRunner.h:
953         * WebKitTestRunner/TestController.cpp:
954         (WTR::TestController::isStatisticsHasLocalStorage):
955         * WebKitTestRunner/TestController.h:
956         * WebKitTestRunner/TestInvocation.cpp:
957         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
958
959 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
960
961         API::Data::createWithoutCopying should do a null check before calling CFRelease
962         https://bugs.webkit.org/show_bug.cgi?id=196276
963         <rdar://problem/48059859>
964
965         Reviewed by Alex Christensen.
966
967         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
968
969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
970         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
971         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
972         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
973         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
974         (TestWebKitAPI::TEST):
975
976 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
977
978         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
979         https://bugs.webkit.org/show_bug.cgi?id=186276
980
981         Reviewed by Carlos Garcia Campos.
982
983         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
984         (webViewLoadChanged):
985         (testWebResourceGetDataError):
986         (testWebResourceGetDataEmpty):
987         (beforeAll):
988         (webViewloadChanged): Deleted.
989
990 2019-03-27  Andy Estes  <aestes@apple.com>
991
992         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
993         https://bugs.webkit.org/show_bug.cgi?id=196317
994
995         Reviewed by Dan Bernstein.
996
997         package-root copies built products into a staging directory using ditto(1), which does not
998         follow symbolic links as it traverses a directory. Now that the files in
999         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1000         itself, these become broken links when ditto'd into the staging directory.
1001
1002         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1003
1004         * Scripts/package-root:
1005
1006 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-app] Update display text of Submit for ews analysis
1009         https://bugs.webkit.org/show_bug.cgi?id=196309
1010
1011         Reviewed by Dewei Zhu.
1012
1013         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1014
1015 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1016
1017         run-webkit-tests should check for leaks in WebKit processes
1018         <https://webkit.org/b/193772>
1019         <rdar://problem/46526680>
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         This works by doing the following:
1024         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1025           The list of child processes are returned one per line:
1026           process.name: pid
1027         - Run the "#LIST CHILD PROCESSES" command just before the
1028           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1029           processes on the ServerProcess object.
1030         - When the `--leaks` switch is handled, run check_for_leaks() on
1031           each child process after the main test harness.
1032
1033         * DumpRenderTree/mac/DumpRenderTree.mm:
1034         (handleControlCommand):
1035         - Use strncmp() instead of strcmp().
1036         - Add support for handling "#LIST CHILD PROCESSES" command.
1037
1038         * Scripts/webkitpy/port/base.py:
1039         (Port.check_for_leaks):
1040         * Scripts/webkitpy/port/darwin.py:
1041         (DarwinPort.check_for_leaks):
1042         - Rename redundant 'process_pid' argument to 'process_id'.
1043
1044         * Scripts/webkitpy/port/driver.py:
1045         (Driver.do_post_tests_work):
1046         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1047           longer the only command this sends to WebKitTestRunner.
1048         - If the `--leaks` switch is present, send the
1049           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1050           result using Port.set_webkit_processes().
1051         (Driver._parse_child_processes_output):
1052         - Add helper method to parse list of child process names and
1053           process IDs returned from WebKitTestRunner.
1054
1055         * Scripts/webkitpy/port/ios_device.py:
1056         (IOSDevicePort.check_for_leaks):
1057         - Rename redundant 'process_pid' argument to 'process_id'.
1058
1059         * Scripts/webkitpy/port/leakdetector.py:
1060         (LeakDetector._parse_leaks_output):
1061         - Return early if there is no leaks_output.
1062         (LeakDetector.check_for_leaks):
1063         - Rename redundant 'process_pid' argument to 'process_id'.
1064
1065         * Scripts/webkitpy/port/server_process.py:
1066         (ServerProcess.__init__):
1067         (ServerProcess.child_processes):
1068         (ServerProcess.set_child_processes):
1069         - Add instance variable to Port to store list of child process
1070           names and process IDs returned from WebKitTestRunner.
1071         (ServerProcess._start):
1072         - Clear self._child_processes.
1073         (ServerProcess.stop):
1074         - If self._child_processes is set, call
1075           self._port.check_for_leaks() for each child process.
1076
1077         * Scripts/webkitpy/port/server_process_unittest.py:
1078         (TrivialMockPort.check_for_leaks):
1079         - Rename redundant 'process_pid' argument to 'process_id'.
1080
1081         * Scripts/webkitpy/port/simulator_process.py:
1082         (SimulatorProcess.stop):
1083         - If self._child_processes is set, call
1084           self._port.check_for_leaks() for each child process.
1085
1086         * Scripts/webkitpy/port/watch_device.py:
1087         (WatchDevicePort.check_for_leaks):
1088         - Rename redundant 'process_pid' argument to 'process_id'.
1089
1090         * WebKitTestRunner/TestController.cpp:
1091         (WTR::TestController::dumpResponse):
1092         - Extract method from findAndDumpWorldLeaks() so that it may be
1093           reused by findAndDumpWebKitProcessIdentifiers().
1094         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1095         - Add method to output process name and process ID of both the
1096           WebContent and Networking processes.
1097         (WTR::TestController::findAndDumpWorldLeaks):
1098         - Fix missing newline in output when there were no abandoned
1099           documents.
1100         - Call dumpResponse() for extracted code.
1101         (WTR::TestController::handleControlCommand):
1102         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1103         - Use strncmp() instead of strcmp().
1104         - Call findAndDumpWebKitProcessIdentifiers() when
1105           "#LIST CHILD PROCESSES" command is sent.
1106         * WebKitTestRunner/TestController.h:
1107         (WTR::TestController::dumpResponse):
1108         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1109         - Declare methods.
1110
1111 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1112
1113         Unreviewed. Add GLib API test cases after r243434.
1114
1115         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1116         (testWebViewActiveURI):
1117         (serverCallback):
1118         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1119         (sendRequestCallback):
1120
1121 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1122
1123         Geolocation request not complete when watch request was started in a different web process
1124         https://bugs.webkit.org/show_bug.cgi?id=195996
1125
1126         Reviewed by Alex Christensen.
1127
1128         Add a test case.
1129
1130         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1131         (TestWebKitAPI::runJavaScriptAlert):
1132         (TestWebKitAPI::TEST):
1133
1134 2019-03-26  Keith Rollin  <krollin@apple.com>
1135
1136         Update the way generate-xcfilelists returns strings from functions
1137         https://bugs.webkit.org/show_bug.cgi?id=195975
1138         <rdar://problem/49040807>
1139
1140         Reviewed by Dean Jackson.
1141
1142         There are places where generate-xcfilelists executes assignments with
1143         statements like:
1144
1145             FOO=$(some_function)
1146
1147         where "some_function" return a string by echoing it. E.g.
1148
1149             some_function()
1150             {
1151                 echo "Hello, World"
1152             }
1153
1154         This is a common idiom, but it has a problem if "some_function" needs
1155         to call "exit" in an attempt to halt the entire script right then and
1156         there. Since "some_function" is called inside of $(), it's being
1157         executed in a sub-shell. Calling exit in that sub-shell simply exits
1158         that shell; it doesn't not exit the outer shell in which the main part
1159         of the script is still running. As such, the main script keeps
1160         executing when the intent was for the script to halt.
1161
1162         The solution to this is to use a different idiom for returning
1163         strings. The one we now is to pass in the name of the variable to
1164         receive the string result:
1165
1166             some_function()
1167             {
1168                 variable_name=$1
1169                 eval $variable_name ="Hello, World"
1170             }
1171
1172         The call site now looks like
1173
1174             some_function FOO
1175
1176         Because there's no invocation of a sub-shell, some_function can now
1177         call "exit" if it wants to, and the entire script will exit at that
1178         point.
1179
1180         * Scripts/generate-xcfilelists:
1181
1182 2019-03-26  Chris Dumez  <cdumez@apple.com>
1183
1184         Add basic layout test coverage for File Picker on iOS
1185         https://bugs.webkit.org/show_bug.cgi?id=196265
1186
1187         Reviewed by Wenson Hsieh.
1188
1189         Add layout test infrastructure to test the file picker on iOS.
1190
1191         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1192         (WTR::UIScriptController::dismissFilePicker):
1193         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1194         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1195         (WTR::UIScriptController::dismissFilePicker):
1196         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1197         * WebKitTestRunner/TestController.cpp:
1198         (WTR::TestController::createWebViewWithOptions):
1199         (WTR::updateTestOptionsFromTestHeader):
1200         * WebKitTestRunner/TestOptions.h:
1201         (WTR::TestOptions::hasSameInitializationOptions const):
1202         * WebKitTestRunner/ios/TestControllerIOS.mm:
1203         (overridePresentViewController):
1204         (WTR::TestController::platformInitialize):
1205         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1206         (WTR::UIScriptController::dismissFilePicker):
1207
1208 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1209
1210         Implement async paste method on UIWKInteractionViewProtocol
1211         https://bugs.webkit.org/show_bug.cgi?id=196267
1212         <rdar://problem/49236346>
1213
1214         Reviewed by Tim Horton.
1215
1216         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1217         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1218         are now a part of all iOS 12 internal SDKs.
1219
1220         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1221
1222         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1223         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1224
1225         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1226         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1227         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1228         * TestWebKitAPI/ios/UIKitSPI.h:
1229
1230 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1231
1232         [ews-build] Use PostgreSQL for ews.webkit.org database
1233         https://bugs.webkit.org/show_bug.cgi?id=196270
1234
1235         Reviewed by Lucas Forschler.
1236
1237         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1238
1239 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1240
1241         [ews] Reset simctl states on reboot
1242         https://bugs.webkit.org/show_bug.cgi?id=196260
1243
1244         Rubber-stamped by Aakash Jain.
1245
1246         * EWSTools/start-queue-mac.sh:
1247
1248 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1249
1250         [ews-build] Use PostgreSQL for ews-build database
1251         https://bugs.webkit.org/show_bug.cgi?id=196229
1252
1253         Reviewed by Lucas Forschler.
1254
1255         * BuildSlaveSupport/ews-build/master.cfg:
1256
1257 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1258
1259         [ews-build] Get master_hostname dynamically in master.cfg
1260         https://bugs.webkit.org/show_bug.cgi?id=196255
1261
1262         Reviewed by Lucas Forschler.
1263
1264         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1265         send events data in test mode.
1266
1267 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-app] Set db_constraint to False for Foreign Keys
1270         https://bugs.webkit.org/show_bug.cgi?id=196252
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-app/ews/models/build.py:
1275         * BuildSlaveSupport/ews-app/ews/models/step.py:
1276
1277 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews-build] is_test_mode_enabled should default to True
1280         https://bugs.webkit.org/show_bug.cgi?id=196248
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1285
1286 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1287
1288         [ews-app] Add webkitperl to ENABLED_QUEUES
1289         https://bugs.webkit.org/show_bug.cgi?id=196253
1290
1291         Reviewed by Lucas Forschler.
1292
1293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1294
1295 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1296
1297         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1298         https://bugs.webkit.org/show_bug.cgi?id=196211
1299         rdar://problem/49110552
1300
1301         Reviewed by Tim Horton.
1302
1303         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1304         Make sure that EventSenderProxy always exists when running tests. We used to create
1305         it when resetting before the first test, which is a bit too late.
1306
1307         * WebKitTestRunner/TestController.h:
1308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1309         (WTR::TestController::platformCreateWebView):
1310         (WTR::TestController::platformCreateOtherPage):
1311         (WTR::TestController::finishCreatingPlatformWebView):
1312         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1313         (WTR::PlatformWebView::PlatformWebView):
1314         Moved some code that made NSWindow use NSEvent during web view creation. We may
1315         need to move more if some other case us found, but this is enough for now.
1316
1317 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1318
1319         Unreviewed. Fix typo in GLib geolocation API after r243285.
1320
1321         gelocation -> geolocation.
1322
1323         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1324         (testGeolocationManagerWatchPosition):
1325
1326 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1327
1328         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1329         https://bugs.webkit.org/show_bug.cgi?id=196213
1330
1331         Reviewed by Geoff Garen.
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1335         (credentialWithIdentityAndKeychainPath):
1336         (-[ChallengeDelegate webView:didFinishNavigation:]):
1337         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1338         (TestWebKitAPI::TEST):
1339
1340 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1341
1342         Expected shouldn't assume its contained types are copyable
1343         https://bugs.webkit.org/show_bug.cgi?id=195986
1344
1345         Reviewed by JF Bastien.
1346
1347         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1348         (TestWebKitAPI::NonCopyable::operator== const):
1349         (TestWebKitAPI::NonCopyable::operator!= const):
1350         (TestWebKitAPI::TEST):
1351
1352 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1353
1354         Remove some now-unnecessary dynamic class lookup
1355         https://bugs.webkit.org/show_bug.cgi?id=196237
1356
1357         Reviewed by Simon Fraser.
1358
1359         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1360         (makeRequest):
1361         (TEST):
1362
1363 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1364
1365         Unreviewed, rolling out r243450.
1366
1367         AppleWin and WinCairo port builds get broken.
1368
1369         Reverted changeset:
1370
1371         "Add test for fix of #196095"
1372         https://bugs.webkit.org/show_bug.cgi?id=196097
1373         https://trac.webkit.org/changeset/243450
1374
1375 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1376
1377         Unreviewed, rolling out r243465.
1378         https://bugs.webkit.org/show_bug.cgi?id=196226
1379
1380         the test doesn't build (Requested by thorton on #webkit).
1381
1382         Reverted changeset:
1383
1384         "Do not terminate the NetworkProcess if a third party
1385         application sends a NSCredential with a SecIdentityRef"
1386         https://bugs.webkit.org/show_bug.cgi?id=196213
1387         https://trac.webkit.org/changeset/243465
1388
1389 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1390
1391         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1392         https://bugs.webkit.org/show_bug.cgi?id=196213
1393
1394         Reviewed by Geoff Garen.
1395
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1398         (credentialWithIdentityAndKeychainPath):
1399         (-[ChallengeDelegate webView:didFinishNavigation:]):
1400         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1401         (TestWebKitAPI::TEST):
1402
1403 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1404
1405         [ews-build] Gracefully handle missing patch_id in events
1406         https://bugs.webkit.org/show_bug.cgi?id=196216
1407
1408         Reviewed by Lucas Forschler.
1409
1410         * BuildSlaveSupport/ews-build/events.py:
1411
1412 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1413
1414         [ews-build] use lz4 compression for improving buildbot performance
1415         https://bugs.webkit.org/show_bug.cgi?id=196155
1416
1417         Reviewed by Lucas Forschler.
1418
1419         * BuildSlaveSupport/ews-build/master.cfg:
1420
1421 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1422
1423         Pull some API testing helper methods out of TestWKWebView
1424         https://bugs.webkit.org/show_bug.cgi?id=196212
1425
1426         Reviewed by Tim Horton.
1427
1428         Refactor some more API testing utility methods, so that they can be used in
1429         tests that do not use TestWKWebView.
1430
1431         * TestWebKitAPI/cocoa/TestWKWebView.h:
1432         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1433         (-[WKWebView loadTestPageNamed:]):
1434         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1435         (-[WKWebView synchronouslyLoadHTMLString:]):
1436         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1437         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1438         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1439         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1440         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1441
1442 2019-03-25  Jer Noble  <jer.noble@apple.com>
1443
1444         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1445         https://bugs.webkit.org/show_bug.cgi?id=196097
1446
1447         Reviewed by Eric Carlson.
1448
1449         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1450
1451         * DumpRenderTree/mac/DumpRenderTree.mm:
1452         (resetWebPreferencesToConsistentValues):
1453         * WebKitTestRunner/TestController.cpp:
1454         (WTR::TestController::resetPreferencesToConsistentValues):
1455
1456 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1457
1458         Pull IPadUserInterfaceSwizzler out into a separate header file
1459         https://bugs.webkit.org/show_bug.cgi?id=196193
1460
1461         Reviewed by Anders Carlsson.
1462
1463         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1464         be used in other API tests.
1465
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1468         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1469         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1470         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1471         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1472         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1473
1474 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1475
1476         Remove NavigatorContentUtils in WebCore/Modules
1477         https://bugs.webkit.org/show_bug.cgi?id=196070
1478
1479         Reviewed by Alex Christensen.
1480
1481         NavigatorContentUtils was to support the custom scheme spec [1].
1482         However, in WebKit side, no port has supported the feature in
1483         WebKit layer after EFL port was removed. So there has been the
1484         only IDL implementation of the NavigatorContentUtils in WebCore.
1485         So we don't need to keep the implementation in WebCore anymore.
1486
1487         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1488
1489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1490
1491 2019-03-24  Andy Estes  <aestes@apple.com>
1492
1493         [watchOS] Remove unused Proximity Networking code
1494         https://bugs.webkit.org/show_bug.cgi?id=196188
1495
1496         Reviewed by Tim Horton.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1499         (TEST):
1500
1501 2019-03-23  Keith Miller  <keith_miller@apple.com>
1502
1503         Refactor clz/ctz and fix getLSBSet.
1504         https://bugs.webkit.org/show_bug.cgi?id=196162
1505
1506         Reviewed by Saam Barati.
1507
1508         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1509
1510         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1511         (TestWebKitAPI::TEST):
1512
1513 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1516         https://bugs.webkit.org/show_bug.cgi?id=196143
1517
1518         Reviewed by Michael Catanzaro.
1519
1520         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1521         directories.
1522
1523         * Scripts/webkitpy/style/checkers/cpp.py:
1524         (check_identifier_name_in_declaration):
1525         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1526         (WebKitStyleTest.test_names):
1527
1528 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1529
1530         [Flatpak] Manifest expanding fails for qt WPE extension
1531         https://bugs.webkit.org/show_bug.cgi?id=196148
1532
1533         Reviewed by Alex Christensen.
1534
1535         * flatpak/flatpakutils.py:
1536         (expand_submodules_recurse): The last recurse manifest expand
1537         iteration might lead to a single module so take it into account
1538         and don't try to recurse further.
1539
1540 2019-03-22  Chris Dumez  <cdumez@apple.com>
1541
1542         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1543         https://bugs.webkit.org/show_bug.cgi?id=195348
1544         <rdar://problem/48622090>
1545
1546         Reviewed by Alex Christensen.
1547
1548         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1549         to NO when test.options().shouldIgnoreMetaViewport is false.
1550
1551         * WebKitTestRunner/ios/TestControllerIOS.mm:
1552         (WTR::TestController::platformConfigureViewForTest):
1553
1554 2019-03-22  Chris Dumez  <cdumez@apple.com>
1555
1556         Prewarmed processes should be usable with any website data store
1557         https://bugs.webkit.org/show_bug.cgi?id=196104
1558
1559         Reviewed by Alex Christensen.
1560
1561         Add API test coverage.
1562
1563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1564         (runInitialWarmedProcessUsedTest):
1565         (TEST):
1566
1567 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1568
1569         Back out local changes to Alex's Subversion working directory
1570
1571         They were accidentally committed.
1572
1573         * Scripts/webkitpy/common/system/abstractexecutive.py:
1574         (AbstractExecutive.wait_newest):
1575         * Scripts/webkitpy/common/system/executive.py:
1576         (Executive.running_pids):
1577         * Scripts/webkitpy/common/system/executive_mock.py:
1578         (MockExecutive.running_pids):
1579         * Scripts/webkitpy/common/system/executive_unittest.py:
1580         (ExecutiveTest.serial_test_running_pids):
1581         * Scripts/webkitpy/port/darwin.py:
1582         (DarwinPort.check_for_leaks):
1583         * Scripts/webkitpy/port/leakdetector.py:
1584         (LeakDetector.check_for_leaks):
1585         - This was the hack attached to Bug 193772.
1586
1587         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1588         (+[WebKitTestRunnerEvent mouseLocation]):
1589         - This works around a crash on an internal build.
1590
1591 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1592
1593         Fix the build after r243354
1594         https://bugs.webkit.org/show_bug.cgi?id=196138
1595         <rdar://problem/49145951>
1596
1597         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1598         (TEST):
1599         * TestWebKitAPI/ios/UIKitSPI.h:
1600
1601 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1602
1603         Adopt UIWKDocumentContext
1604         https://bugs.webkit.org/show_bug.cgi?id=196040
1605         <rdar://problem/48642440>
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1610         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1611         (makeRequest):
1612         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1613         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1614         (applyStyle):
1615         (TEST):
1616         Add tests for UIWKDocumentContext.
1617
1618         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1619         (TEST):
1620         (recursiveFindWKContentView): Deleted.
1621         * TestWebKitAPI/cocoa/TestWKWebView.h:
1622         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1623         (recursiveFindWKContentView):
1624         (-[TestWKWebView wkContentView]):
1625         * TestWebKitAPI/ios/UIKitSPI.h:
1626         Share the WKContentView finding code between tests.
1627
1628 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1629
1630         [iOS WK2] Turn on async overflow scrolling by default
1631         https://bugs.webkit.org/show_bug.cgi?id=196011
1632         rdar://problem/48453859
1633
1634         Reviewed by Antti Koivisto.
1635         
1636         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1637         since so many basic layout tests have different results when compositing is triggered for
1638         overflow.
1639         
1640         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1641
1642         * WebKitTestRunner/TestController.cpp:
1643         (WTR::TestController::resetPreferencesToConsistentValues):
1644
1645 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1646
1647         [ews-build] Retry API test in case of failures
1648         https://bugs.webkit.org/show_bug.cgi?id=196004
1649
1650         Reviewed by Lucas Forschler.
1651
1652         * BuildSlaveSupport/ews-build/steps.py:
1653         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1654         (CompileWebKitToT.doStepIf): Ditto.
1655         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1656         (ReRunAPITests): Re-run API tests.
1657         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1658         (RunAPITestsWithoutPatch): Run API tests without patch.
1659         (RunAPITestsWithoutPatch.doStepIf):
1660         (RunAPITestsWithoutPatch.hideStepIf):
1661         (RunAPITestsWithoutPatch.evaluateCommand):
1662         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1663         (AnalyzeAPITestsResults.start):
1664         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1665         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1666         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1667         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1668
1669 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1670
1671         [ews-build] Update queues configurations
1672         https://bugs.webkit.org/show_bug.cgi?id=196074
1673
1674         Reviewed by Dewei Zhu.
1675
1676         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1677         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1678
1679 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1680
1681         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1682         https://bugs.webkit.org/show_bug.cgi?id=195680
1683         <rdar://problem/48903534>
1684
1685         Unreviewed infrastructure fix.
1686
1687         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1688         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1689
1690 2019-03-21  Andy Estes  <aestes@apple.com>
1691
1692         [iOS] Apple Pay should be available in documents with no user agent scripts
1693         https://bugs.webkit.org/show_bug.cgi?id=196061
1694         <rdar://problem/48649391>
1695
1696         Reviewed by Brady Eidson.
1697
1698         Added API tests and related infrastructure.
1699
1700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1701         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1702         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1703         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1706         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1707         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1708         * TestWebKitAPI/cocoa/TestProtocol.mm:
1709         (-[TestProtocol startLoading]):
1710         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1711         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1712         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1713         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1714
1715 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1716
1717         REGRESSSION (r243297): webkitpy tests broken
1718         https://bugs.webkit.org/show_bug.cgi?id=196108
1719
1720         Reviewed by Aakash Jain.
1721
1722         r243297 updated contributors.json, which broke a few unit tests.
1723
1724         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1725         (IRCCommandTest.test_whois):
1726         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1727
1728 2019-03-21  Chris Dumez  <cdumez@apple.com>
1729
1730         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1731         https://bugs.webkit.org/show_bug.cgi?id=196041
1732         <rdar://problem/49083230>
1733
1734         Reviewed by Alex Christensen.
1735
1736         Add API test coverage.
1737
1738         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1739         (TEST):
1740
1741 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1742
1743         Add SPI to inform applications of WKContentRuleList actions
1744         https://bugs.webkit.org/show_bug.cgi?id=195965
1745         <rdar://problem/42664365>
1746
1747         Reviewed by Geoff Garen.
1748
1749         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1750         (TestWebKitAPI::allActionsForResourceLoad):
1751         (TestWebKitAPI::testRequest):
1752         (TestWebKitAPI::TEST_F):
1753         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1754         (Notification::description):
1755         (Notification::operator== const):
1756         (toVector):
1757         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1758         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1759         (makeContentRuleList):
1760         (TEST):
1761         (makeWarnContentRuleList): Deleted.
1762
1763 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1764
1765         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1766         https://bugs.webkit.org/show_bug.cgi?id=196088
1767
1768         Reviewed by Brian Burg.
1769
1770         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1771         Support checks when only one platform is specified. Also deprecate macosx() and
1772         force the use of macos() instead.
1773
1774         * Scripts/webkitpy/style/checkers/cpp.py:
1775         (check_min_versions_of_wk_api_available):
1776         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1777         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1778
1779 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1780
1781         Update status inactive committers' status to 'contributor'.
1782
1783         * Scripts/webkitpy/common/config/contributors.json:
1784
1785 2019-03-21  Xan Lopez  <xan@igalia.com>
1786
1787         [JSC][x86] Drop support for x87 floating point
1788         https://bugs.webkit.org/show_bug.cgi?id=194853
1789
1790         Reviewed by Don Olmstead.
1791
1792         Force SSE2 on x86/32bit builds.
1793
1794         * Scripts/webkitdirs.pm:
1795         (generateBuildSystemFromCMakeProject):
1796
1797 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1798
1799         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1800         https://bugs.webkit.org/show_bug.cgi?id=196073
1801
1802         Reviewed by Michael Catanzaro.
1803
1804         Add test cases to check functions and constructors with no arguments but receiving user data.
1805
1806         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1807         (checkUserData):
1808         (testJSCFunction):
1809         (fooCreateWithUserData):
1810         (testJSCClass):
1811
1812 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1813
1814         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1815
1816         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1817
1818         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1819
1820 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1821
1822         [GTK][WPE] Add API to provide geolocation information
1823         https://bugs.webkit.org/show_bug.cgi?id=195940
1824
1825         Reviewed by Michael Catanzaro.
1826
1827         Add a new test to check the new API.
1828
1829         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1830         (testGeolocationManagerCurrentPosition):
1831         (testGeolocationManagerWatchPosition):
1832         (beforeAll):
1833         (afterAll):
1834         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1835         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1836         (beforeAll): Ditto.
1837         * TestWebKitAPI/glib/CMakeLists.txt:
1838
1839 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1840
1841         [GLib] Returning G_TYPE_OBJECT from a method does not work
1842         https://bugs.webkit.org/show_bug.cgi?id=195574
1843
1844         Reviewed by Michael Catanzaro.
1845
1846         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1847
1848         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1849         (getGFile):
1850         (getParent):
1851         (createGString):
1852         (getGString):
1853         (getGStringCopyWillRaise):
1854         (getGStringCopy):
1855         (getGStringStr):
1856         (getGStringLen):
1857         (freeGString):
1858         (testJSCClass):
1859
1860 2019-03-20  Saam Barati  <sbarati@apple.com>
1861
1862         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1863         https://bugs.webkit.org/show_bug.cgi?id=195721
1864
1865         Reviewed by Filip Pizlo.
1866
1867         * Scripts/run-javascriptcore-tests:
1868
1869 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1870
1871         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1872         https://bugs.webkit.org/show_bug.cgi?id=196049
1873
1874         Reviewed by Tim Horton.
1875
1876         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1877         overflow scrolling in general, so rename it.
1878
1879         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1880
1881 2019-03-20  Daniel Bates  <dabates@apple.com>
1882
1883         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1884         https://bugs.webkit.org/show_bug.cgi?id=196031
1885         <rdar://problem/49078172>
1886
1887         Reviewed by Tim Horton.
1888
1889         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1890         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1891         same code path used when the Done button is pressed to dismiss the <select> picker.
1892
1893         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1894         (TestWebKitAPI::TEST):
1895
1896 2019-03-20  Chris Dumez  <cdumez@apple.com>
1897
1898         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1899         https://bugs.webkit.org/show_bug.cgi?id=196029
1900         <rdar://problem/48954651>
1901
1902         Reviewed by Tim Horton.
1903
1904         Add API test coverage.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1907
1908 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1909
1910         [ews-build] Improve failure summary string for ApplyPatch step
1911         https://bugs.webkit.org/show_bug.cgi?id=195995
1912
1913         Reviewed by Alexey Proskuryakov.
1914
1915         * BuildSlaveSupport/ews-build/steps.py:
1916         (ApplyPatch.getResultSummary): Override getResultSummary.
1917
1918 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1919
1920         AX: Implement support for new meter ARIA role
1921         https://bugs.webkit.org/show_bug.cgi?id=195966
1922
1923         Reviewed by Chris Fleizach.
1924
1925         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1926         to AXLevelIndicator.
1927
1928         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1929
1930 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1931
1932         [WebAuthN] Implement FIDO AppID extension
1933         https://bugs.webkit.org/show_bug.cgi?id=143491
1934         <rdar://problem/48298273>
1935
1936         Reviewed by Brent Fulgham.
1937
1938         Add a test that covers the new flag of convertToU2fSignCommand.
1939
1940         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1943         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1944         (TestWebKitAPI::TEST):
1945
1946 2019-03-19  Keith Rollin  <krollin@apple.com>
1947
1948         Add support for more platforms to generate-xcfilelists
1949         https://bugs.webkit.org/show_bug.cgi?id=195977
1950
1951         Reviewed by Alexey Proskuryakov.
1952
1953         generate-xcfilelists incorrectly complains when involved with building
1954         WebKit for iphonesimulator:
1955
1956             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1957             …
1958             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1959
1960         Address this by teaching generate-xcfilelists about more platforms.
1961
1962         * Scripts/generate-xcfilelists:
1963
1964 2019-03-19  John Wilander  <wilander@apple.com>
1965
1966         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1967         https://bugs.webkit.org/show_bug.cgi?id=195923
1968         <rdar://problem/49001272>
1969
1970         Reviewed by Alex Christensen.
1971
1972         This patch does the following to the TestRunner:
1973         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1974         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1975         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1976
1977         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1978         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1979         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1980         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1981         * WebKitTestRunner/TestController.cpp:
1982         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1983         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1984         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1985         * WebKitTestRunner/TestController.h:
1986         * WebKitTestRunner/TestInvocation.cpp:
1987         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1988
1989 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1990
1991         [CMake] Support more clang and gcc sanitizers
1992         https://bugs.webkit.org/show_bug.cgi?id=195956
1993
1994         Reviewed by Michael Catanzaro.
1995
1996         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1997
1998 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Improve summary for PrintConfiguration step
2001         https://bugs.webkit.org/show_bug.cgi?id=195945
2002
2003         Reviewed by Lucas Forschler.
2004
2005         * BuildSlaveSupport/ews-build/steps.py:
2006         (PrintConfiguration.getResultSummary): Override getResultSummary.
2007
2008 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2009
2010         [ews-build] Improve summary for CheckOutSource step
2011         https://bugs.webkit.org/show_bug.cgi?id=195963
2012
2013         Reviewed by Lucas Forschler.
2014
2015         * BuildSlaveSupport/ews-build/steps.py:
2016         (CheckOutSource.getResultSummary):
2017
2018 2019-03-19  Daniel Bates  <dabates@apple.com>
2019
2020         [iOS] Focus not preserved when switching between tabs
2021         https://bugs.webkit.org/show_bug.cgi?id=195820
2022         <rdar://problem/43614450>
2023
2024         Reviewed by Brent Fulgham.
2025
2026         Add tests to ensure that we restore focus when resigning and becoming first responder.
2027
2028         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2029         (TestWebKitAPI::TEST):
2030
2031 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2032
2033         Make WTFLogChannelState and WTFLogLevel enum classes
2034         https://bugs.webkit.org/show_bug.cgi?id=195904
2035
2036         Reviewed by Eric Carlson.
2037
2038         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2039         (TestWebKitAPI::TEST_F):
2040
2041 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2042
2043         [GStreamer][EME] Backported mssdemux protection data crash fix
2044         https://bugs.webkit.org/show_bug.cgi?id=195918
2045
2046         Reviewed by Philippe Normand.
2047
2048         * gstreamer/jhbuild.modules:
2049         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2050
2051 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2052
2053         Unreviewed, rolling out r243132.
2054
2055         Broke GTK build
2056
2057         Reverted changeset:
2058
2059         "Make WTFLogChannelState and WTFLogLevel enum classes"
2060         https://bugs.webkit.org/show_bug.cgi?id=195904
2061         https://trac.webkit.org/changeset/243132
2062
2063 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2064
2065         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2066
2067         * Scripts/webkitdirs.pm:
2068         (builtDylibPathForName): Adjust the shared library name that's changed
2069         with the API version bump in r243073.
2070
2071 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2072
2073         Make WTFLogChannelState and WTFLogLevel enum classes
2074         https://bugs.webkit.org/show_bug.cgi?id=195904
2075
2076         Reviewed by Eric Carlson.
2077
2078         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2079         (TestWebKitAPI::TEST_F):
2080
2081 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2082
2083         Disable flaky test added in r2431100
2084         https://webkit.org/b/195785
2085
2086         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2087         (TestWebKitAPI::TEST):
2088         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2089
2090 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2091
2092         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2093         https://bugs.webkit.org/show_bug.cgi?id=195916
2094
2095         Reviewed by Tim Horton.
2096
2097         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2098         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2099
2100 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2101
2102         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2103
2104         * Scripts/webkitpy/common/config/contributors.json:
2105
2106 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2107
2108         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2109         https://bugs.webkit.org/show_bug.cgi?id=195785
2110
2111         Reviewed by Geoffrey Garen.
2112
2113         * TestWebKitAPI/TCPServer.cpp: Added.
2114         (TestWebKitAPI::TCPServer::TCPServer):
2115         (TestWebKitAPI::TCPServer::~TCPServer):
2116         (TestWebKitAPI::TCPServer::socketBindListen):
2117         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2118         * TestWebKitAPI/TCPServer.h: Added.
2119         (TestWebKitAPI::TCPServer::port const):
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2121         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2122         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2123         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2124         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2125         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2126         (TestWebKitAPI::respondSlowly):
2127         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2128         (TestWebKitAPI::downloadAtRate):
2129         (TestWebKitAPI::TEST):
2130
2131 2019-03-18  Saam Barati  <sbarati@apple.com>
2132
2133         Add a plan file for JetStream 2
2134         https://bugs.webkit.org/show_bug.cgi?id=190734
2135
2136         Reviewed by Mark Lam.
2137
2138         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2139
2140 2019-03-18  Chris Dumez  <cdumez@apple.com>
2141
2142         Delay WebProcess launch until a load is triggered in a Web view
2143         https://bugs.webkit.org/show_bug.cgi?id=195758
2144         <rdar://problem/48126013>
2145
2146         Reviewed by Geoff Garen.
2147
2148         Add API test coverage. Also update some existing API tests to not expect
2149         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2150
2151         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2156         (TEST):
2157         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2158         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2159         (TEST):
2160         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2161         (TEST):
2162         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2163
2164 2019-03-18  Xan Lopez  <xan@igalia.com>
2165
2166         [CMake] Prevent potential warning when determining $architecture
2167         https://bugs.webkit.org/show_bug.cgi?id=195891
2168
2169         Reviewed by Michael Catanzaro.
2170
2171         It's possible for generateBuildSystemForCMakeProject to be called
2172         before determineArchitecture() is ever called. This will make the
2173         first eq check with $architecture to be bogus (and print a
2174         warning). Change that to an eq check with architecture(), which
2175         implicitly calls determineArchitecture() if needed, and change all
2176         the other similar cases in the method in the same way to prevent
2177         future bugs like this one.
2178
2179         * Scripts/webkitdirs.pm:
2180         (generateBuildSystemFromCMakeProject):
2181
2182 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2183
2184         [WPE] Tarballs generated with “make dist” cannot build documentation
2185         https://bugs.webkit.org/show_bug.cgi?id=195885
2186
2187         Reviewed by Carlos Garcia Campos.
2188
2189         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2190
2191 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2192
2193         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2194         https://bugs.webkit.org/show_bug.cgi?id=195883
2195
2196         Reviewed by Carlos Garcia Campos.
2197
2198         * gtkdoc/gtkdoc.py:
2199         (GTKDoc._run_command): When commands fail to run, include the full command line for
2200         the program invocation and the output it has generated on the standard error stream.
2201
2202 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2203
2204         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2205         https://bugs.webkit.org/show_bug.cgi?id=195786
2206
2207         Reviewed by Philippe Normand.
2208
2209         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2210         * wpe/jhbuild.modules: Ditto.
2211
2212 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2213
2214         [ews-build] Don't run clean builds on EWS builders
2215         https://bugs.webkit.org/show_bug.cgi?id=195851
2216
2217         Reviewed by Geoffrey Garen.
2218
2219         * BuildSlaveSupport/ews-build/factories.py:
2220
2221 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2222
2223         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2224         https://bugs.webkit.org/show_bug.cgi?id=195849
2225
2226         Reviewed by Chris Dumez.
2227
2228         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2229
2230         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2231         (runWebsiteDataStoreCustomPaths):
2232
2233 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2234
2235         webkitpy: Upload test results
2236         https://bugs.webkit.org/show_bug.cgi?id=195755
2237         <rdar://problem/48896182>
2238
2239         Reviewed by Aakash Jain.
2240
2241         Establish a new format for uploading results that is not tied to layout tests, apply
2242         that format to webkitpy tests.
2243
2244         * Scripts/webkitpy/common/checkout/scm/git.py:
2245         (Git.native_branch): Return what branch the current checkout is on.
2246         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2247         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2248         * Scripts/webkitpy/common/checkout/scm/svn.py:
2249         (SVN.native_branch): Ditto.
2250         * Scripts/webkitpy/common/system/platforminfo.py:
2251         (PlatformInfo.build_version): Return a build version for Mac.
2252         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2253         (MockPlatformInfo.__init__):
2254         (MockPlatformInfo.build_version):
2255         * Scripts/webkitpy/results: Added.
2256         * Scripts/webkitpy/results/__init__.py: Added.
2257         * Scripts/webkitpy/results/options.py: Added.
2258         (upload_options): OptParse list for upload options.
2259         * Scripts/webkitpy/results/upload.py: Added.
2260         (Upload): Class which enforces the upload format expected by the results server.
2261         (Upload.Expectations):
2262         (Upload.create_configuration):
2263         (Upload.create_commit):
2264         (Upload.create_details):
2265         (Upload.create_run_stats):
2266         (Upload.create_test_result):
2267         (Upload.__init__):
2268         (Upload.Encoder): Encode Upload object as json.
2269         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2270         * Scripts/webkitpy/results/upload_unittest.py: Added.
2271         * Scripts/webkitpy/test/main.py:
2272         (Tester._parse_args): Add upload arguments.
2273         (Tester._run_tests): Allow results to be uploaded.
2274         * Scripts/webkitpy/test/runner.py:
2275         (Runner.__init__): Record which tests were run, rather than just counting them.
2276         (Runner.handle):
2277         * Scripts/webkitpy/test/runner_unittest.py:
2278         (RunnerTest.test_run):
2279         * Scripts/webkitpy/thirdparty/__init__.py:
2280         (AutoinstallImportHook.find_module): Add requests auto-install.
2281         (AutoinstallImportHook._install_requests):
2282         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2283         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2284
2285 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2286
2287         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2288         https://bugs.webkit.org/show_bug.cgi?id=195810
2289
2290         Reviewed by Tim Horton.
2291
2292         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2293         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2294         ending certain layout tests.
2295
2296         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2297         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2298         (-[TestRunnerWKWebView dealloc]):
2299         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2300
2301         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2302         helper method when destroying the web view, and when resetting state between tests.
2303
2304         * WebKitTestRunner/ios/TestControllerIOS.mm:
2305         (WTR::TestController::platformResetStateToConsistentValues):
2306
2307         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2308
2309 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2310
2311         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2312         https://bugs.webkit.org/show_bug.cgi?id=190350
2313         <rdar://problem/45089503>
2314
2315         Reviewed by Geoffrey Garen.
2316
2317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2318         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2319         (TEST):
2320         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2321         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2322         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2323         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2324         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2325         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2326         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2327         (runTest):
2328         (createDirectories):
2329         (TEST):
2330         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2331         (TEST):
2332         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2333         (TEST):
2334
2335 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2336
2337         Add support to WebPage for getting the contents as an attributed string.
2338         https://bugs.webkit.org/show_bug.cgi?id=195636
2339         rdar://problem/45055697
2340
2341         Reviewed by Tim Horton.
2342
2343         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2344         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2345
2346 2019-03-15  Chris Dumez  <cdumez@apple.com>
2347
2348         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2349         https://bugs.webkit.org/show_bug.cgi?id=195747
2350
2351         Reviewed by Geoff Garen.
2352
2353         Add API test coverage.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2356
2357 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2358
2359         Unreviewed, rolling out r242952.
2360
2361         Causing API failures on iOS Simulator
2362
2363         Reverted changeset:
2364
2365         "[PSON] Make sure the WebProcessCache is leverage when
2366         relaunching a process after termination"
2367         https://bugs.webkit.org/show_bug.cgi?id=195747
2368         https://trac.webkit.org/changeset/242952
2369
2370 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2371
2372         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2373         https://bugs.webkit.org/show_bug.cgi?id=195740
2374
2375         Reviewed by Ross Kirsling.
2376
2377         window.open doesn't work for WebKitBrowserWindow because it is not
2378         implemented yet.
2379
2380         1. Implemented createNewPage callback of WKPageUIClient.
2381         2. Changed MainWindow to take a BrowserWindow factory function
2382           instead of BrowserWindowType to be flexible to create
2383           BrowserWindow with extra settings.
2384         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2385           because it is not relevant with MainWindow anymore.
2386
2387         * MiniBrowser/win/Common.cpp:
2388         (parseCommandLine):
2389         * MiniBrowser/win/Common.h:
2390         (CommandLineOptions::CommandLineOptions):
2391         * MiniBrowser/win/MainWindow.cpp:
2392         (MainWindow::MainWindow):
2393         (MainWindow::create):
2394         (MainWindow::init):
2395         (MainWindow::WndProc):
2396         * MiniBrowser/win/MainWindow.h:
2397         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2398         (PrintWebUIDelegate::createWebViewWithRequest):
2399         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2400         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2401         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2402         (WebKitBrowserWindow::updateProxySettings):
2403         (WebKitBrowserWindow::createNewPage):
2404         * MiniBrowser/win/WebKitBrowserWindow.h:
2405         * MiniBrowser/win/WinMain.cpp:
2406         (wWinMain):
2407
2408 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2409
2410         Make it possible to test scrolling tree layer manipulation more easily
2411         https://bugs.webkit.org/show_bug.cgi?id=195780
2412
2413         Reviewed by Tim Horton.
2414         
2415         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2416         cuts off communication of scrolling tree scrolls back to the web process
2417         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2418         allows tests to trigger scrolls which run the scrolling tree layer positioning
2419         logic, but never get another commit from the web process that might mask
2420         scrolling tree bugs.
2421         
2422         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2423         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2424         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2425
2426         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2427         (WTR::UIScriptController::scrollUpdatesDisabled const):
2428         (WTR::UIScriptController::setScrollUpdatesDisabled):
2429         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2430         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2431         (WTR::UIScriptController::scrollUpdatesDisabled const):
2432         (WTR::UIScriptController::setScrollUpdatesDisabled):
2433         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2434         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2435         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2436         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2437         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2438         * WebKitTestRunner/ios/TestControllerIOS.mm:
2439         (WTR::TestController::platformResetStateToConsistentValues):
2440         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2441         (WTR::UIScriptController::scrollUpdatesDisabled const):
2442         (WTR::UIScriptController::setScrollUpdatesDisabled):
2443
2444 2019-03-14  Youenn Fablet  <youenn@apple.com>
2445
2446         Move IDB storage in private browsing mode to NetworkProcess
2447         https://bugs.webkit.org/show_bug.cgi?id=195602
2448
2449         Reviewed by Brady Eidson.
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2452         (TEST):
2453
2454 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2455
2456         [ews-build] Make descriptionDone messages more readable
2457         https://bugs.webkit.org/show_bug.cgi?id=195760
2458
2459         Reviewed by Lucas Forschler.
2460
2461         * BuildSlaveSupport/ews-build/steps.py:
2462         * BuildSlaveSupport/ews-build/steps_unittest.py:
2463
2464 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2465
2466         [ews-build] Generate status-bubble hover-over messages
2467         https://bugs.webkit.org/show_bug.cgi?id=195680
2468
2469         Reviewed by Lucas Forschler.
2470
2471         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2472         (StatusBubble):
2473         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2474         on hover-over.
2475         (StatusBubble._iso_time):
2476         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2477         hover-over message.
2478         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2479
2480 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2481
2482         [ews-app] Gracefully handle the case when state_string is None
2483         https://bugs.webkit.org/show_bug.cgi?id=195753
2484
2485         Reviewed by Lucas Forschler.
2486
2487         * BuildSlaveSupport/ews-app/ews/models/build.py:
2488         * BuildSlaveSupport/ews-app/ews/models/step.py:
2489
2490 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2491
2492         [ews-app] Status bubble display pending for currently running build step
2493         https://bugs.webkit.org/show_bug.cgi?id=195744
2494
2495         Reviewed by Lucas Forschler.
2496
2497         * BuildSlaveSupport/ews-build/events.py:
2498         (Events.stepStarted): If state_string is pending, replace it with step name.
2499
2500 2019-03-14  Chris Dumez  <cdumez@apple.com>
2501
2502         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2503         https://bugs.webkit.org/show_bug.cgi?id=195750
2504
2505         Reviewed by Geoffrey Garen.
2506
2507         Add API test coverage.
2508
2509         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2510         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2511         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2512         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2513
2514 2019-03-14  Chris Dumez  <cdumez@apple.com>
2515
2516         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2517         https://bugs.webkit.org/show_bug.cgi?id=195747
2518
2519         Reviewed by Geoff Garen.
2520
2521         Add API test coverage.
2522
2523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2524
2525 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2526
2527         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2528         https://bugs.webkit.org/show_bug.cgi?id=195725
2529         <rdar://problem/48545062>
2530
2531         Reviewed by Tim Horton.
2532
2533         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2534         handler is nil.
2535
2536         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2537         (TestWebKitAPI::TEST):
2538
2539 2019-03-13  Sam Weinig  <sam@webkit.org>
2540
2541         Add utility function to allow easy reverse range-based iteration of a container
2542         https://bugs.webkit.org/show_bug.cgi?id=195542
2543
2544         Reviewed by Antti Koivisto.
2545
2546         * TestWebKitAPI/CMakeLists.txt:
2547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2548         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2549         (TestWebKitAPI::TEST):
2550         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2551
2552 2019-03-13  Chris Dumez  <cdumez@apple.com>
2553
2554         Use a ServiceWorker process per registrable domain
2555         https://bugs.webkit.org/show_bug.cgi?id=195649
2556
2557         Reviewed by Youenn Fablet.
2558
2559         Update API test coverage.
2560
2561         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2562
2563 2019-03-13  Chris Dumez  <cdumez@apple.com>
2564
2565         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2566         https://bugs.webkit.org/show_bug.cgi?id=195684
2567         <rdar://problem/48294714>
2568
2569         Reviewed by Antti Koivisto.
2570
2571         Add API test coverage.
2572
2573         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2574
2575 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2576
2577         [ews-app] Remove unused patch view
2578         https://bugs.webkit.org/show_bug.cgi?id=195669
2579
2580         Reviewed by Lucas Forschler.
2581
2582         * BuildSlaveSupport/ews-app/ews/urls.py:
2583         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2584
2585 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2586
2587         [ews-app] Use Buildbot result code variables
2588         https://bugs.webkit.org/show_bug.cgi?id=195668
2589
2590         Reviewed by Alexey Proskuryakov.
2591
2592         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2593         (Buildbot): Added Buildbot result code variables.
2594         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2595         (StatusBubble._build_bubble): Used Buildbot result code variables.
2596
2597 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2598
2599         [Flatpak] Expand submodule recursively
2600         https://bugs.webkit.org/show_bug.cgi?id=195672
2601
2602         Building WPE with flatpak was impossible without that as it was raising an exception.
2603         Also update wpebackend-fdo to match what is built in jhbuild
2604
2605         Reviewed by Philippe Normand.
2606
2607         * flatpak/flatpakutils.py:
2608         (expand_submodules_recurse):
2609         (expand_manifest):
2610         * flatpak/org.webkit.WPEModules.yaml:
2611
2612 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-app] status bubble should be hidden for certain builds
2615         https://bugs.webkit.org/show_bug.cgi?id=194597
2616
2617         Reviewed by Dewei Zhu.
2618
2619         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2620         (StatusBubble._build_bubble):
2621         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2622         because the patch didn't have relevant changes.
2623         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2624         in production yet.
2625
2626 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2627
2628         [Win] Fix a slew of simple clang-cl warnings.
2629         https://bugs.webkit.org/show_bug.cgi?id=195652
2630
2631         Reviewed by Don Olmstead.
2632
2633         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2634         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2635
2636 2019-03-12  Justin Fan  <justin_fan@apple.com>
2637
2638         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2639         https://bugs.webkit.org/show_bug.cgi?id=195518
2640         <rdar://problem/46322356>
2641
2642         Reviewed by Myles C. Maxfield.
2643
2644         * DumpRenderTree/DerivedSources-input.xcfilelist:
2645         * DumpRenderTree/DerivedSources-output.xcfilelist:
2646
2647 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2648
2649         Unreviewed, rolling out r242825.
2650         https://bugs.webkit.org/show_bug.cgi?id=195648
2651
2652         "Broke webkitpy tests with my change to
2653         lldb_dump_class_layout.py" (Requested by rmorisset on
2654         #webkit).
2655
2656         Reverted changeset:
2657
2658         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2659         classes with suspicious padding"
2660         https://bugs.webkit.org/show_bug.cgi?id=195573
2661         https://trac.webkit.org/changeset/242825
2662
2663 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2664
2665         [ews-build] Show status bubbles while the patch is waiting in queue
2666         https://bugs.webkit.org/show_bug.cgi?id=195618
2667
2668         Reviewed by Lucas Forschler.
2669
2670         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2671         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2672         enabled in initial deployment.
2673         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2674         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2675         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2676         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2677         (StatusBubble._build_bubbles_for_patch):
2678
2679 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2680
2681         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2682         https://bugs.webkit.org/show_bug.cgi?id=195573
2683
2684         Reviewed by Simon Fraser.
2685
2686         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2687
2688         * Scripts/dump-class-layout:
2689         (main):
2690         * lldb/lldb_dump_class_layout.py:
2691         (ClassLayout.__init__):
2692         (ClassLayout._compute_padding_recursive):
2693         (LLDBDebuggerInstance.dump_layout_for_classname):
2694         (LLDBDebuggerInstance):
2695         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2696         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2697
2698 2019-03-12  Chris Dumez  <cdumez@apple.com>
2699
2700         Device Orientation access permission should be denied unless explicitly granted by the client
2701         https://bugs.webkit.org/show_bug.cgi?id=195625
2702
2703         Reviewed by Youenn Fablet.
2704
2705         add API test coverage.
2706
2707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2708         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2709         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2710         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2711         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2712         (runDeviceOrientationTest):
2713         (TEST):
2714         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2715         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2716
2717 2019-03-12  Jer Noble  <jer.noble@apple.com>
2718
2719         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2720         https://bugs.webkit.org/show_bug.cgi?id=195137
2721         <rdar://problem/48810307>
2722
2723         Reviewed by Eric Carlson.
2724
2725         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2726         (TestWebKitAPI::TEST):
2727
2728 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2729
2730         [ews-build] Change urls from uat to production
2731         https://bugs.webkit.org/show_bug.cgi?id=195566
2732
2733         Reviewed by Lucas Forschler.
2734
2735         * BuildSlaveSupport/ews-app/ews/config.py:
2736         * BuildSlaveSupport/ews-build/events.py:
2737         * BuildSlaveSupport/ews-build/steps.py:
2738
2739 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2740
2741         [ews-build] change max_builds for local-worker to 1
2742         https://bugs.webkit.org/show_bug.cgi?id=195568
2743
2744         Reviewed by Lucas Forschler.
2745
2746         * BuildSlaveSupport/ews-build/loadConfig.py:
2747
2748 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2749
2750         Fix the build
2751
2752         * TestRunnerShared/spi/PencilKitTestSPI.h:
2753         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2754
2755 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2756
2757         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2758         https://bugs.webkit.org/show_bug.cgi?id=194131
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2763         (uriChanged):
2764         (testUnfinishedSubresourceLoad):
2765         (serverCallback):
2766         (beforeAll):
2767
2768 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2769
2770         WTF::Expected should use std::addressof instead of operator&
2771         https://bugs.webkit.org/show_bug.cgi?id=195604
2772
2773         Reviewed by Myles Maxfield.
2774
2775         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2776         (TestWebKitAPI::Unique::Unique):
2777         (TestWebKitAPI::Unique::operator&):
2778         (TestWebKitAPI::TEST):
2779
2780 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2781
2782         Add Optional to Forward.h.
2783         https://bugs.webkit.org/show_bug.cgi?id=195586
2784
2785         Reviewed by Darin Adler.
2786
2787         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2788         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2789         Remove unnecessary includes from headers.
2790
2791 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2792
2793         Add testing API to hit-test and scroll overflow scrollers
2794         https://bugs.webkit.org/show_bug.cgi?id=195278
2795
2796         Reviewed by Antti Koivisto.
2797         
2798         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2799         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2800         
2801         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2802
2803         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2804         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2805         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2806         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2807         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2808         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2809         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2810         (WTR::enclosingScrollViewIncludingSelf):
2811         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2812
2813 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2814
2815         API test WebKit.RequestTextInputContext fails on iOS
2816         https://bugs.webkit.org/show_bug.cgi?id=195585
2817
2818         Reviewed by Wenson Hsieh and Simon Fraser.
2819
2820         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2821         (applyStyle):
2822         (TEST):
2823         Add a viewport, so that the coordinates match up on iOS.
2824         Scroll by moving the UIScrollView's contentOffset.
2825
2826 2019-03-11  Chris Dumez  <cdumez@apple.com>
2827
2828         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2829         https://bugs.webkit.org/show_bug.cgi?id=195506
2830         <rdar://problem/48733477>
2831
2832         Reviewed by Alex Christensen.
2833
2834         Add API test coverage.
2835
2836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2837
2838 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2839
2840         Adding myself to contributors.json
2841
2842         Unreviewed, addming myself to contributors.json .
2843
2844         * Scripts/webkitpy/common/config/contributors.json:
2845
2846 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2847
2848         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2849         https://bugs.webkit.org/show_bug.cgi?id=195511
2850         <rdar://problem/44873269>
2851
2852         Reviewed by Darin Adler.
2853
2854         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2855         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2856         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2857         (TEST_F):
2858
2859 2019-03-11  Chris Dumez  <cdumez@apple.com>
2860
2861         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2862         https://bugs.webkit.org/show_bug.cgi?id=195561
2863
2864         Reviewed by Youenn Fablet.
2865
2866         Make sure the JS in the test requests for permission to receive device orientation events.
2867
2868         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2869
2870 2019-03-11  Youenn Fablet  <youenn@apple.com>
2871
2872         Allow storage quota increase by default in WTR
2873         https://bugs.webkit.org/show_bug.cgi?id=195541
2874
2875         Reviewed by Geoffrey Garen.
2876
2877         Allow storage quota increase by default in WTR.
2878         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2879         Use this for tests that explicitly need cache increase.
2880
2881         Instead of increasing quota by 2, make sure the next request is
2882         granted by adding all given parameters.
2883
2884         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2885         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2886         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2887         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2888         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2889         * WebKitTestRunner/TestController.cpp:
2890         (WTR::TestController::setAllowStorageQuotaIncrease):
2891         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2892         * WebKitTestRunner/TestController.h:
2893         * WebKitTestRunner/TestInvocation.cpp:
2894         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2895         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2896         (WTR::TestController::cocoaResetStateToConsistentValues):
2897         (WTR::TestController::setAllowStorageQuotaIncrease):
2898         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2899         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2900         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2901
2902 2019-03-11  Xan Lopez  <xan@igalia.com>
2903
2904         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2905         https://bugs.webkit.org/show_bug.cgi?id=194147
2906
2907         Reviewed by Michael Saboff.
2908
2909         To make --32-bit work correctly on Linux/64bit we need to:
2910
2911         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2912         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2913         unfortunately CMake only allows us to do this during
2914         crosscompilation, which is overkill here.
2915         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2916         pkg-config detection module uses the x86 .pc files instead of the
2917         x86_64 ones.
2918         - Set the -m32 flags for the compiler.
2919
2920         * Scripts/webkitdirs.pm:
2921         (generateBuildSystemFromCMakeProject):
2922
2923 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2924
2925         Add MotionMark-1.1 plan file for run-benchmark script.
2926         https://bugs.webkit.org/show_bug.cgi?id=195481
2927
2928         Rubber-stamped by Darin Adler.
2929
2930         Run-benchmark script should support MontionMark-1.1.
2931
2932         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2933
2934 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2935
2936         [ews-app] Add support for submit-to-ews url
2937         https://bugs.webkit.org/show_bug.cgi?id=195477
2938
2939         Reviewed by Lucas Forschler.
2940
2941         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2942         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2943         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2944         * BuildSlaveSupport/ews-app/ews/urls.py:
2945         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2946
2947 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2948
2949         Unreviewed, rolling out r242688, r242643, r242624.
2950
2951         Caused multiple layout test failures and crashes on iOS and macOS.
2952
2953         Reverted changeset:
2954
2955         "requestAnimationFrame should execute before the next frame"
2956         https://bugs.webkit.org/show_bug.cgi?id=177484
2957         https://trac.webkit.org/changeset/242624/webkit
2958
2959         * Tracing/SystemTracePoints.plist:
2960
2961 2019-03-11  John Wilander  <wilander@apple.com>
2962
2963         Resource Load Statistics: Make it possible exclude localhost from classification
2964         https://bugs.webkit.org/show_bug.cgi?id=195474
2965         <rdar://problem/47520577>
2966
2967         Reviewed by Brent Fulgham.
2968
2969         This patch allows for localhost to be excluded from classification and
2970         treatment as a prevalent resource.
2971
2972         The WebKit Tools change adds a new function called
2973         testRunner.setStatisticsIsRunningTest() which can be used to control this
2974         behavior.
2975
2976         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2977         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2978         (WTR::TestRunner::setStatisticsIsRunningTest):
2979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2980         * WebKitTestRunner/TestController.cpp:
2981         (WTR::TestController::setStatisticsIsRunningTest):
2982         * WebKitTestRunner/TestController.h:
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2985
2986 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2987
2988         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2989         https://bugs.webkit.org/show_bug.cgi?id=195560
2990
2991         Reviewed by Lucas Forschler.
2992
2993         * BuildSlaveSupport/ews-build/master.cfg:
2994
2995 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2996
2997         Unreviewed, rolling out r242698.
2998
2999         API test crashes on bots.
3000
3001         Reverted changeset:
3002
3003         "Add a WKContentRuleList variant that uses copied memory
3004         instead of mmap'd shared memory for class A containerized
3005         apps"
3006         https://bugs.webkit.org/show_bug.cgi?id=195511
3007         https://trac.webkit.org/changeset/242698
3008
3009 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3010
3011         [WPE] Enable web process sandbox
3012         https://bugs.webkit.org/show_bug.cgi?id=195169
3013
3014         Reviewed by Daniel Bates.
3015
3016         * wpe/install-dependencies:
3017         * wpe/jhbuild.modules:
3018
3019 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-app] Use port 17000 for worker communication
3022         https://bugs.webkit.org/show_bug.cgi?id=195558
3023
3024         Reviewed by Lucas Forschler.
3025
3026         * BuildSlaveSupport/ews-build/master.cfg:
3027
3028 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-build] unit-tests fail when passwords.json is missing
3031         https://bugs.webkit.org/show_bug.cgi?id=195557
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-build/loadConfig.py:
3036         (loadBuilderConfig):
3037         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3038         (ConfigDotJSONTest.test_configuration):
3039         * BuildSlaveSupport/ews-build/master.cfg:
3040
3041 2019-03-11  Truitt Savell  <tsavell@apple.com>
3042
3043         Unreviewed, rolling out r242702.
3044
3045         Broke High Sierra builders.
3046
3047         Reverted changeset:
3048
3049         "Add utility function to allow easy reverse range-based
3050         iteration of a container"
3051         https://bugs.webkit.org/show_bug.cgi?id=195542
3052         https://trac.webkit.org/changeset/242702
3053
3054 2019-03-11  Sam Weinig  <sam@webkit.org>
3055
3056         Add utility function to allow easy reverse range-based iteration of a container
3057         https://bugs.webkit.org/show_bug.cgi?id=195542
3058
3059         Reviewed by Antti Koivisto.
3060
3061         * TestWebKitAPI/CMakeLists.txt:
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3064         (TestWebKitAPI::TEST):
3065         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3066
3067 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3068
3069         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3070         https://bugs.webkit.org/show_bug.cgi?id=195511
3071         <rdar://problem/44873269>
3072
3073         Reviewed by Darin Adler.
3074
3075         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3076         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3077         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3078         (TEST_F):
3079
3080 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3081
3082         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3083         https://bugs.webkit.org/show_bug.cgi?id=195499
3084
3085         Reviewed by Darin Adler.
3086
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3089         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3090         (-[WKWebView synchronouslyFocusTextInputContext:]):
3091         (applyStyle):
3092         (applyIframe):
3093         (TEST):
3094         Add some tests for this SPI.
3095
3096 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3097
3098         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3099         https://bugs.webkit.org/show_bug.cgi?id=181151
3100
3101         Reviewed by Don Olmstead.
3102
3103         * TestWebKitAPI/CMakeLists.txt:
3104         * TestWebKitAPI/PlatformWin.cmake:
3105         Enable TestWTF RunLoop tests in all platforms.
3106
3107         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3108         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3109         (TestWebKitAPI::DerivedOneShotTimer::fired):
3110         (TestWebKitAPI::TEST):
3111         Only a few platforms support nested RunLoop.
3112
3113         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3114         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3115
3116 2019-03-10  David Quesada  <david_quesada@apple.com>
3117
3118         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3119         https://bugs.webkit.org/show_bug.cgi?id=152480
3120
3121         Reviewed by Chris Dumez.
3122
3123         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3124         there are no additional references to the process pool besides the one held by
3125         the download, waits for the download to finish (in the sense that the
3126         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3127         measure, also check that the process pool has been deallocated at the end of the
3128         test. The test wouldn't be meaningful if the process pool were still alive.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3131         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3132         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3133             The download will be canceled because the delegate does not implement the
3134             method to decide the download's destination, so this is where we know the
3135             DownloadProxyMap is done with the DownloadProxy.
3136         (TEST):
3137
3138 2019-03-08  Chris Dumez  <cdumez@apple.com>
3139
3140         Add support for Device Orientation / Motion permission API
3141         https://bugs.webkit.org/show_bug.cgi?id=195329
3142         <rdar://problem/47645367>
3143
3144         Reviewed by Geoffrey Garen.
3145
3146         Add test infrastructure to help test the Device Orientation / Motion permission API.
3147
3148         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3149         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3150         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3151         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3152         * WebKitTestRunner/TestController.cpp:
3153         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3154         (WTR::TestController::createWebViewWithOptions):
3155         (WTR::TestController::resetStateToConsistentValues):
3156         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3157         * WebKitTestRunner/TestController.h:
3158         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3159         * WebKitTestRunner/TestInvocation.cpp:
3160         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3161
3162 2019-03-08  Saam barati  <sbarati@apple.com>
3163
3164         Add a compare-results script to compare benchmark results
3165         https://bugs.webkit.org/show_bug.cgi?id=195486
3166         <rdar://problem/48723397>
3167
3168         Reviewed by Geoffrey Garen.
3169
3170         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3171         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3172         to extend it to learn about our other benchmarks.
3173
3174         * Scripts/compare-results: Added.
3175         (readJSONFile):
3176         (detectJetStream2):
3177         (JetStream2Results):
3178         (detectSpeedometer2):
3179         (Speedometer2Results):
3180         (detectPLT5):
3181         (PLT5Results):
3182         (detectBenchmark):
3183         (biggerIsBetter):
3184         (ttest):
3185         (getOptions):
3186         (main):
3187
3188 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3189
3190         Ensure old tab state is cleared between iterations of run-benchmark
3191         https://bugs.webkit.org/show_bug.cgi?id=195393
3192         <rdar://problem/46885583>
3193
3194         Reviewed by Dewei Zhu.
3195
3196         a) ensure the default to restore state is not set
3197         b) terminate Safari correctly
3198         c) Set the system default to ignore Persistent State in Safari
3199
3200         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3201         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3202         (OSXBrowserDriver.prepare_env): 
3203         (OSXBrowserDriver.restore_env):
3204         (OSXBrowserDriver.close_browsers):
3205         (OSXBrowserDriver._terminate_processes):
3206         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3207         (OSXChromeDriver):
3208         (OSXChromeCanaryDriver):
3209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3210         (OSXFirefoxDriver):
3211         (OSXFirefoxNightlyDriver):
3212         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3213         (OSXSafariDriver):
3214         (OSXSafariDriver.prepare_env):
3215
3216 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3217
3218         [GTK] Several InputMethodFilter tests are failing
3219         https://bugs.webkit.org/show_bug.cgi?id=195408
3220
3221         Reviewed by Carlos Garcia Campos.
3222
3223         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3224         Regressed in r241751.
3225         Hexadecimal values of keycodes are expressed now in upper letters.
3226         Composited characters should be cast to UTF8 strings.
3227
3228         (TestWebKitAPI::TEST):
3229
3230 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3231
3232         [GTK] Make Tools/gtkdoc python3 compatible
3233         https://bugs.webkit.org/show_bug.cgi?id=195359
3234
3235         Reviewed by Carlos Garcia Campos.
3236
3237         * gtkdoc/generate-gtkdoc:
3238         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3239         work with Python 2 and 3.
3240         (get_gtkdoc_module_paths):
3241         The iteritems() was removed in Python 3, so let's use items() that's
3242         available in Python 2 and 3.
3243         (get_generator_for_config):
3244         * gtkdoc/gtkdoc.py:
3245         (GTKDoc._run_command):
3246         The sys.stdout.write() is expecting str in Python 3 and not bytes
3247         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3248         for passing the bytes there.
3249
3250 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3251
3252         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3253         https://bugs.webkit.org/show_bug.cgi?id=195346
3254         <rdar://problem/48667048>
3255
3256         Unreviewed build fix for clang-cl.
3257
3258         * DumpRenderTree/win/DumpRenderTree.cpp:
3259         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3260
3261 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3262
3263         requestAnimationFrame should execute before the next frame
3264         https://bugs.webkit.org/show_bug.cgi?id=177484
3265
3266         Reviewed by Simon Fraser.
3267
3268         Add trace points for the page RenderingUpdate.
3269
3270         * Tracing/SystemTracePoints.plist:
3271
3272 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3273
3274         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3275         https://bugs.webkit.org/show_bug.cgi?id=195353
3276         <rdar://problem/48626394>
3277
3278         Reviewed by Simon Fraser.
3279
3280         * WebKitTestRunner/ios/TestControllerIOS.mm:
3281         (WTR::TestController::platformResetPreferencesToConsistentValues):
3282
3283 2019-03-07  John Wilander  <wilander@apple.com>
3284
3285         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3286         https://bugs.webkit.org/show_bug.cgi?id=195383
3287         <rdar://problem/48570136>
3288
3289         Reviewed by Brent Fulgham.
3290
3291         This patch adds test infrastructure to purge only script-accessible cookies,
3292         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3293
3294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3296         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3298         * WebKitTestRunner/TestController.cpp:
3299         (WTR::TestController::statisticsDeleteCookiesForHost):
3300         * WebKitTestRunner/TestController.h:
3301         * WebKitTestRunner/TestInvocation.cpp:
3302         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3303
3304 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3305
3306         Unreviewed, rolling out r242354.
3307         https://bugs.webkit.org/show_bug.cgi?id=195402
3308
3309         breaks layout tests in all configurations (Requested by
3310         zdobersek on #webkit).
3311
3312         Reverted changeset:
3313
3314         "[WPE] Enable web process sandbox"
3315         https://bugs.webkit.org/show_bug.cgi?id=195169
3316         https://trac.webkit.org/changeset/242354
3317
3318 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3319
3320         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3321         https://bugs.webkit.org/show_bug.cgi?id=195346
3322
3323         Reviewed by Fujii Hironori.
3324
3325         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3326         (TestWebKitAPI::TEST):
3327         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3328
3329         * DumpRenderTree/win/DumpRenderTree.cpp:
3330         (findFontFallback):
3331         (addFontFallbackIfPresent):
3332         (removeFontFallbackIfPresent):
3333         (main):
3334         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3335         (TestWebKitAPI::Util::moduleDirectory):
3336         (TestWebKitAPI::Util::createInjectedBundlePath):
3337         Use wchar helpers as needed.
3338
3339 2019-03-06  Rob Buis  <rbuis@igalia.com>
3340
3341         Consider supporting the `referrerpolicy` attribute.
3342         https://bugs.webkit.org/show_bug.cgi?id=179053
3343
3344         Reviewed by Darin Adler.
3345
3346         Add a runtime flag for referrerpolicy attribute.
3347
3348         * DumpRenderTree/mac/DumpRenderTree.mm:
3349         (enableExperimentalFeatures):
3350
3351 2019-03-05  Daniel Bates  <dabates@apple.com>
3352
3353         Update expected API test result following r242379
3354         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3355
3356         Update expected x-coordinate of selection rect now that the left padding of
3357         a textarea is sized in ems (so dependent on the font size) just like the left
3358         padding of a text field.
3359
3360         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3361         (TestWebKitAPI::TEST):
3362
3363 2019-03-05  David Quesada  <david_quesada@apple.com>
3364
3365         [WK2] It should be possible to follow links with 'download' attributes
3366         https://bugs.webkit.org/show_bug.cgi?id=195145
3367         rdar://problem/48462642
3368
3369         Reviewed by Alex Christensen.
3370
3371         Add a unit test to verify that activating links with 'download' attributes now
3372         navigates to the linked resource, rather than starts downloading it. Add another
3373         to verify that it is still possible to explicitly download the link via the
3374         'Download' navigation action policy.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3377         (-[DownloadAttributeTestDelegate init]):
3378         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3379         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3380         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3381         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3382         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3383         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3384         (TEST):
3385         * WebKitTestRunner/TestController.cpp:
3386         (WTR::TestController::decidePolicyForNavigationAction):
3387         * WebKitTestRunner/TestController.h:
3388
3389 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3390
3391         [Curl] Implement Cookie Accept Policy.
3392         https://bugs.webkit.org/show_bug.cgi?id=191645
3393
3394         Reviewed by Fujii Hironori.
3395
3396         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3397         (TestWebKitAPI::Curl::TEST_F):
3398
3399 2019-03-05  Youenn Fablet  <youenn@apple.com>
3400
3401         Rename requestCacheStorageSpace to requestStorageSpace
3402         https://bugs.webkit.org/show_bug.cgi?id=195282
3403
3404         Reviewed by Chris Dumez.
3405
3406         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3407         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3408         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3409
3410 2019-03-05  Brady Eidson  <beidson@apple.com>
3411
3412         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3413         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3414
3415         Reviewed by Tim Horton.
3416
3417         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3418         different directory into that same WKWebView should work.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3422
3423 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3424
3425         Add WeakHashSet
3426         https://bugs.webkit.org/show_bug.cgi?id=195152
3427
3428         Reviewed by Antti Koivisto.
3429
3430         Added tests for WeakHashSet.
3431
3432         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3433         (TestWebKitAPI::Base::Base): Moved.
3434         (TestWebKitAPI::Derived::foo): Moved.
3435         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3436         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3437         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3438         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3439
3440 2019-03-04  Chris Dumez  <cdumez@apple.com>
3441
3442         Do not share WebProcesses between private and regular sessions
3443         https://bugs.webkit.org/show_bug.cgi?id=195189
3444         <rdar://problem/48421064>
3445
3446         Reviewed by Alex Christensen.
3447
3448         Add API test coverage.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3451         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3452
3453 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3454
3455         [WPE] Enable web process sandbox
3456         https://bugs.webkit.org/show_bug.cgi?id=195169
3457
3458         Reviewed by Daniel Bates.
3459
3460         * wpe/install-dependencies:
3461         * wpe/jhbuild.modules:
3462
3463 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3464
3465         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3466         https://bugs.webkit.org/show_bug.cgi?id=195206
3467
3468         Reviewed by Žan Doberšek.
3469
3470         Add a new test case.
3471
3472         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3473         (testJSCClass):
3474
3475 2019-03-04  Charlie Turner  <cturner@igalia.com>
3476
3477         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3478         https://bugs.webkit.org/show_bug.cgi?id=194898
3479
3480         Reviewed by Žan Doberšek.
3481
3482         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3483         a GCC extension that permits arithmetic on void* pointer. Inline
3484         the macro until this issue is fixed upstream.
3485
3486 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3487
3488         Rid the world of WK_API_ENABLED
3489         https://bugs.webkit.org/show_bug.cgi?id=195263
3490
3491         Reviewed by Dan Bernstein.
3492
3493         List of changed files elided because it's useless.
3494
3495 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3496
3497         Unreviewed follow-up to r242292.
3498
3499         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3500
3501         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3502         (TestWebKitAPI::testStrip): Renamed from strip.
3503         (TestWebKitAPI::TEST):
3504
3505 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3506
3507         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3508
3509         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3510         and bug #194272 for details.
3511
3512         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3513
3514 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3515
3516         Remove some more unused 32-bit code
3517         https://bugs.webkit.org/show_bug.cgi?id=195255
3518
3519         Reviewed by Darin Adler.
3520
3521         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3522         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3523         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3524         (NPP_New):
3525         (NPP_HandleEvent):
3526         (handleEventCarbon): Deleted.
3527
3528 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3529
3530         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3531
3532         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3533         (TestWebKitAPI::TEST):
3534
3535 2019-03-01  Darin Adler  <darin@apple.com>
3536
3537         Finish removing String::format
3538         https://bugs.webkit.org/show_bug.cgi?id=194893
3539
3540         Reviewed by Daniel Bates.
3541 '
3542         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3543
3544 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3545
3546         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3547         https://bugs.webkit.org/show_bug.cgi?id=195229
3548         <rdar://problem/48520362>
3549
3550         Reviewed by Chris Dumez.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3553         (TEST):
3554
3555 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3556
3557         Add a system trace scope for event region building
3558         https://bugs.webkit.org/show_bug.cgi?id=195226
3559
3560         Reviewed by Jon Lee.
3561
3562         This trace scope measures the time spend converting element rects into Region objects,
3563         which can be large on some pages.
3564
3565         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3566
3567         * Tracing/SystemTracePoints.plist:
3568
3569 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3570
3571         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3572         https://bugs.webkit.org/show_bug.cgi?id=194612
3573
3574         Reviewed by Alex Christensen.
3575
3576         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3577         Just test the new string-processing function and don't touch the actual environment.
3578         (Test cases are all as before, but based on operator== instead of strcmp.)
3579
3580 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3581
3582         [ews-app] Update primary keys for handling multiple Buildbot instances
3583         https://bugs.webkit.org/show_bug.cgi?id=195120
3584
3585         Reviewed by Stephanie Lewis.
3586
3587         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3588         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3589         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3590
3591         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3592         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3593         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3594         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3595         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3596         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3597
3598 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3599
3600         [WinCairo] Enable service worker
3601         https://bugs.webkit.org/show_bug.cgi?id=188318
3602
3603         Reviewed by Youenn Fablet.
3604
3605         * DumpRenderTree/DumpRenderTreePrefix.h:
3606         * TestWebKitAPI/PlatformWin.cmake:
3607         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3608         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3609         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3610
3611 2019-03-01  Justin Fan  <justin_fan@apple.com>
3612
3613         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3614         https://bugs.webkit.org/show_bug.cgi?id=195191
3615
3616         Rubber-stamped by Dean Jackson.
3617
3618         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3619
3620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3621
3622 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3623
3624         Unreviewed, fix lldb webkitpy tests
3625         https://bugs.webkit.org/show_bug.cgi?id=194375
3626
3627         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3628
3629         * lldb/lldb_webkit.py:
3630         (WTFStringImplProvider.is_8bit):
3631
3632 2019-02-28  David Quesada  <david_quesada@apple.com>
3633
3634         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3635         https://bugs.webkit.org/show_bug.cgi?id=195121
3636         rdar://problem/48450302
3637
3638         Reviewed by Alex Christensen.
3639
3640         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3641         configurations where the 'download' attribute is absent, blank, or populated
3642         with a filename, and where the anchor element is same-origin or cross-origin
3643         (meaning the 'download' attribute shouldn't be honored).
3644
3645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3646         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3647         (-[NavigationActionTestDelegate init]):
3648         (-[NavigationActionTestDelegate navigationAction]):
3649         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3650         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3651         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3652         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3653         (TEST):
3654
3655 2019-02-28  Antoine Quint  <graouts@apple.com>
3656
3657         Enable the Pointer Events runtime flag by default
3658         https://bugs.webkit.org/show_bug.cgi?id=195156
3659
3660         Reviewed by Dean Jackson.
3661
3662         * DumpRenderTree/mac/DumpRenderTree.mm:
3663         (enableExperimentalFeatures):
3664
3665 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         Several PasteImage API tests are flaky
3668         https://bugs.webkit.org/show_bug.cgi?id=195160
3669
3670         Reviewed by Tim Horton.
3671
3672         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3673         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3674         listening for a "load" event after image load is already complete.
3675
3676         To address this, make these tests first register a "load" event handler, then run script to insert an image
3677         element into the document, and finally wait until the load event is observed before checking image size.
3678
3679         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3680
3681 2019-02-28  Chris Dumez  <cdumez@apple.com>
3682
3683         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3684         https://bugs.webkit.org/show_bug.cgi?id=195107
3685
3686         Reviewed by Alex Christensen.
3687
3688         Give some time for the zoom level to get restored.
3689
3690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3691
3692 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3693
3694         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3695         https://bugs.webkit.org/show_bug.cgi?id=194958
3696
3697         Reviewed by Geoffrey Garen.
3698
3699         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3700         (TEST):
3701
3702 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3703
3704         [ews-app] Update method to save build to handle builder_display_name
3705         https://bugs.webkit.org/show_bug.cgi?id=195047
3706
3707         Reviewed by Dewei Zhu.
3708
3709         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3710         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3711
3712 2019-02-28  Justin Fan  <justin_fan@apple.com>
3713
3714         [Web GPU] Enable Web GPU only on 64-bit
3715         https://bugs.webkit.org/show_bug.cgi?id=195139
3716
3717         Because Metal is only supported on 64 bit apps.
3718
3719         Unreviewed build fix.
3720
3721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3722
3723 2019-02-27  Youenn Fablet  <youenn@apple.com>
3724
3725         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3726         https://bugs.webkit.org/show_bug.cgi?id=194959
3727
3728         Reviewed by Chris Dumez.
3729
3730         Spin loop until getting the condition to remove flakiness.
3731
3732         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3733
3734 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3735
3736         [ews-build] Buildbot should include builder_display_name in the build events
3737         https://bugs.webkit.org/show_bug.cgi?id=195045
3738
3739         Reviewed by Dewei Zhu.
3740
3741         * BuildSlaveSupport/ews-build/events.py:
3742         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3743         buildername to builder_name to be consistent in naming style.
3744         (Events.buildFinished): Ditto.
3745
3746 2019-02-27  Chris Dumez  <cdumez@apple.com>
3747
3748         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3749         https://bugs.webkit.org/show_bug.cgi?id=194480
3750
3751         Reviewed by Brady Eidson.
3752
3753         Update existing API test to make it more likely to reproduce the issue.
3754
3755         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3756
3757 2019-02-27  Brady Eidson  <beidson@apple.com>
3758
3759         Universal links from Google search results pages don't open the app.
3760         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3761
3762         Reviewed by Geoffrey Garen.
3763
3764         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3765         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3766         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3767         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3768
3769 2019-02-27  Chris Dumez  <cdumez@apple.com>
3770
3771         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3772         https://bugs.webkit.org/show_bug.cgi?id=195102
3773
3774         Reviewed by Geoffrey Garen.
3775
3776         If the number of processes is not yet what we expect, wait a bit and check again to give
3777         processes some time to exit.
3778
3779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3780
3781 2019-02-27  Chris Dumez  <cdumez@apple.com>
3782
3783         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3784         https://bugs.webkit.org/show_bug.cgi?id=194545
3785
3786         Reviewed by Brady Eidson.
3787
3788         Make sure the test navigates forward and then back only once. Previously, navigating
3789         back would trigger a navigation again in a timer.
3790
3791         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3792
3793 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3794
3795         High Sierra Debug JSC test queue should use faster hardware
3796         https://bugs.webkit.org/show_bug.cgi?id=194603
3797
3798         Rubber-stamped by Alexey Proskuryakov.
3799
3800         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3801
3802         * BuildSlaveSupport/build.webkit.org-config/config.json:
3803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3804         (BubbleQueueServer):
3805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3806         (WebKitBuildbot):
3807         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3808         * QueueStatusServer/config/queues.py:
3809         * Scripts/webkitpy/common/config/ews.json:
3810         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3811         (test_ews_name):
3812
3813 2019-02-27  John Wilander  <wilander@apple.com>
3814
3815         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3816         https://bugs.webkit.org/show_bug.cgi?id=195071
3817         <rdar://problem/48417690>
3818
3819         Reviewed by Alex Christensen and Brent Fulgham.
3820
3821         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3822         (TestWebKitAPI::createURL):
3823             Convenience function.
3824         (TestWebKitAPI::TEST):
3825             WebCore::AdClickAttribution now takes a URL when creating Source and
3826             Destination.
3827         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3828         (TestWebKitAPI::TEST):
3829             WebCore::AdClickAttribution now takes a URL when creating Source and
3830             Destination.
3831
3832 2019-02-27  Antoine Quint  <graouts@apple.com>
3833
3834         Support Pointer Events on macOS
3835         https://bugs.webkit.org/show_bug.cgi?id=195008
3836         <rdar://problem/47454419>
3837
3838         Reviewed by Dean Jackson.
3839
3840         * DumpRenderTree/mac/DumpRenderTree.mm:
3841         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3842         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3843
3844 2019-02-26  Mark Lam  <mark.lam@apple.com>
3845
3846         Remove remaining poisoning code.
3847         https://bugs.webkit.org/show_bug.cgi?id=194138
3848
3849         Reviewed by Saam Barati.
3850
3851         * TestWebKitAPI/CMakeLists.txt:
3852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3853         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3854         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3855         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3856         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3857         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3858         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3859
3860 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3861
3862         Move ephemeral local storage from WebProcess to UIProcess
3863         https://bugs.webkit.org/show_bug.cgi?id=195074
3864         <rdar://problem/47937975>
3865
3866         Reviewed by Geoff Garen.
3867
3868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3869
3870 2019-02-20  Jer Noble  <jer.noble@apple.com>
3871
3872         [Cocoa] Media elements will restart network buffering just before suspending
3873         https://bugs.webkit.org/show_bug.cgi?id=193691
3874
3875         Reviewed by Eric Carlson.
3876
3877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3879         (TEST):
3880
3881 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3882
3883         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3884         https://bugs.webkit.org/show_bug.cgi?id=191652
3885
3886         Reviewed by Alex Christensen.
3887
3888         Fix WinCairo MiniBrowser behavior of authentication dialog.
3889
3890         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3891         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3892
3893 2019-02-26  Youenn Fablet  <youenn@apple.com>
3894
3895         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3896         https://bugs.webkit.org/show_bug.cgi?id=195028
3897         <rdar://problem/48243733>
3898
3899         Reviewed by Eric Carlson.
3900
3901         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3902
3903 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3904
3905         [WPE] Add API for webview background color configuration
3906         https://bugs.webkit.org/show_bug.cgi?id=192305
3907
3908         Reviewed by Michael Catanzaro.
3909
3910         * MiniBrowser/wpe/main.cpp:
3911         (main): Add a new option to configure the webview background
3912         color. Example: --bg-color=transparent.
3913         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3914         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3915         (beforeAll): Ditto.
3916
3917 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3918
3919         scalableNativeWebpageParameters() is not preserved on new page navigation.
3920         https://bugs.webkit.org/show_bug.cgi?id=194892
3921         <rdar://problem/47538280>
3922
3923         Reviewed by Wenson Hsieh.
3924         
3925         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3926
3927         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3928         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3929         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3930         (WTR::UIScriptController::allowsViewportShrinkToFit):
3931         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3932         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3933         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3934         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3935         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3936         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3937
3938 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3939
3940         [ews-app] Add model for handling multiple Buildbot instances
3941         https://bugs.webkit.org/show_bug.cgi?id=194863
3942
3943         Reviewed by Stephanie Lewis.
3944
3945         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3946
3947 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3948
3949         [ews-app] Remove BuilderMapping table
3950         https://bugs.webkit.org/show_bug.cgi?id=194961
3951
3952         Reviewed by Stephanie Lewis.
3953
3954         Store builder name directly in build table, instead of having a separate
3955         table for it.
3956
3957         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3958         * BuildSlaveSupport/ews-app/ews/models/build.py:
3959         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3960         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3961
3962 2019-02-25  John Wilander  <wilander@apple.com>
3963
3964         Introduce and adopt new class RegistrableDomain for eTLD+1
3965         https://bugs.webkit.org/show_bug.cgi?id=194791
3966         <rdar://problem/48179240>
3967
3968         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3969
3970         This patch adds an API test and replaces two instances of
3971         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3972
3973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3974         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3975         (TestWebKitAPI::TEST):
3976             Changed two strings to make sure the registrable domains are still considered
3977             invalid and pass the test.
3978         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3979         (TestWebKitAPI::TEST):
3980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3981         (WTR::InjectedBundle::didReceiveMessageToPage):
3982
3983 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3984
3985         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3986         https://bugs.webkit.org/show_bug.cgi?id=195001
3987
3988         Reviewed by Carlos Garcia Campos.
3989
3990         API version 1.0 always includes the functionality previously guarded with
3991         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3992         unconditionally.
3993
3994         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3995         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3996         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3997         (WebViewTest::showInWindow): Ditto.
3998         (WebViewTest::hideView): Ditto.
3999         * wpe/backends/HeadlessViewBackend.cpp:
4000         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4001         * wpe/backends/ViewBackend.cpp:
4002         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4003         * wpe/backends/WindowViewBackend.cpp:
4004         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4005         WPE_BACKEND_CHECK_VERSION().
4006         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4007
4008 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4009
4010         [Flatpak] Add support for flatpak > 1.1.2
4011         https://bugs.webkit.org/show_bug.cgi?id=194088
4012
4013         Flatpak 1.2 is now out so we need to support that
4014         version now.
4015
4016         Reviewed by Michael Catanzaro.
4017
4018         * flatpak/flatpakutils.py:
4019         (check_flatpak):
4020         (FlatpakPackages.__init__):
4021         (FlatpakPackages.__detect_packages):
4022         (FlatpakPackages.__detect_packages.in):
4023         (FlatpakRepos.update):
4024
4025 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4026
4027         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4028         https://bugs.webkit.org/show_bug.cgi?id=194998
4029
4030         Reviewed by Carlos Garcia Campos.
4031
4032         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4033         to a Git checkout and using the latest commit containing various fixes
4034         and improvements.
4035
4036 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4037
4038         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4039         https://bugs.webkit.org/show_bug.cgi?id=194981
4040
4041         Reviewed by Žan Doberšek.
4042
4043         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4044         (TestWebKitAPI::TEST):
4045
4046 2019-02-23  Keith Miller  <keith_miller@apple.com>
4047
4048         Add new mac target numbers
4049         https://bugs.webkit.org/show_bug.cgi?id=194955
4050
4051         Reviewed by Tim Horton.
4052
4053         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4054         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4055         * MiniBrowser/Configurations/Base.xcconfig:
4056         * TestWebKitAPI/Configurations/Base.xcconfig:
4057         * WebKitTestRunner/Configurations/Base.xcconfig:
4058
4059 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4060
4061         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4062         https://bugs.webkit.org/show_bug.cgi?id=194846
4063
4064         Reviewed by Don Olmstead.
4065
4066         Added _search_paths() and _port_specific_expectations_files() for
4067         WinCairoPort.
4068
4069         * Scripts/webkitpy/port/win.py:
4070         (WinCairoPort.default_baseline_search_path):
4071         (WinCairoPort):
4072         (WinCairoPort._port_specific_expectations_files):
4073         (WinCairoPort._search_paths):
4074
4075 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4076
4077         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4078         https://bugs.webkit.org/show_bug.cgi?id=194963
4079
4080         Reviewed by Dean Jackson.
4081
4082         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4083         Do a `contains` check instead of `equals`, because in debug builds we
4084         put the GraphicsLayer pointer in a prefix.
4085
4086 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4087
4088         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4089         https://bugs.webkit.org/show_bug.cgi?id=194873
4090         <rdar://problem/46701974>
4091
4092         Reviewed by Tim Horton.
4093
4094         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4095
4096         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4097         (WTR::UIScriptController::menuRect const):
4098         (WTR::UIScriptController::isShowingMenu const):
4099         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4100         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4101         (WTR::UIScriptController::menuRect const):
4102
4103         Add a function to query the bounds of the callout menu in content coordinates.
4104
4105         (WTR::UIScriptController::isShowingMenu const):
4106
4107         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4108
4109         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4110         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4111         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4112         (WTR::UIScriptController::rectForMenuAction const):
4113         (WTR::UIScriptController::menuRect const):
4114         (WTR::UIScriptController::isShowingMenu const):
4115         (WTR::findViewInHierarchyOfType): Deleted.
4116
4117 2019-02-22  Chris Dumez  <cdumez@apple.com>
4118
4119         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4120         https://bugs.webkit.org/show_bug.cgi?id=194954
4121         <rdar://problem/48127957>
4122
4123         Reviewed by Alex Christensen.
4124
4125         Add API test coverage.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4128         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4129         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4130         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4131
4132 2019-02-22  Chris Dumez  <cdumez@apple.com>
4133
4134         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4135         https://bugs.webkit.org/show_bug.cgi?id=194924
4136         <rdar://problem/48216125>
4137
4138         Reviewed by Geoffrey Garen.
4139
4140         Add API test coverage.
4141
4142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4143
4144 2019-02-22  Chris Dumez  <cdumez@apple.com>
4145
4146         Unreviewed, disable API test added in r241928 on iOS.
4147
4148         The cache is not enabled on devices with less than 3GB of RAM.
4149
4150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4151
4152 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4153
4154         Hardcode Visual Viewports on everywhere except iOS WK1
4155         https://bugs.webkit.org/show_bug.cgi?id=194928
4156
4157         Reviewed by Zalan Bujtas.
4158
4159         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4160         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4161         set it to false. The setting has shipped for several years and there's no need to turn
4162         it off now.
4163
4164         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4165         Visual Viewports are not enabled.
4166         
4167         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4168         that only runs in WK2
4169
4170         * MiniBrowser/mac/SettingsController.h:
4171         * MiniBrowser/mac/SettingsController.m:
4172         (-[SettingsController init]):
4173         (-[SettingsController _populateMenu]):
4174         (-[SettingsController validateMenuItem:]):
4175         (-[SettingsController visualViewportEnabled]): Deleted.
4176         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4177         * MiniBrowser/mac/WK1BrowserWindowController.m:
4178         (-[WK1BrowserWindowController didChangeSettings]):
4179         * MiniBrowser/mac/WK2BrowserWindowController.m:
4180         (-[WK2BrowserWindowController didChangeSettings]):
4181
4182 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4183
4184         Discard cached processes when clearing website data store
4185         https://bugs.webkit.org/show_bug.cgi?id=194894
4186
4187         Reviewed by Chris Dumez.
4188
4189         Added a test case.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4192         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4193
4194 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4195
4196         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4197         https://bugs.webkit.org/show_bug.cgi?id=194914
4198         <rdar://problem/47586889>
4199
4200         Reviewed by Geoffrey Garen.
4201
4202         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4203         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4204         (TEST):
4205         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4206
4207 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4208
4209         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4210         <https://webkit.org/b/194761>
4211
4212         Reviewed by Myles Maxfield.
4213
4214         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4215         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4216         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4217         to use ARC-compliant cast.
4218         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4219         ARC-compliant cast.
4220         (WTR::installFakeHelvetica): Log `error` to console if
4221         CTFontManagerRegisterFontsForURL() fails, but only on supported
4222         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4223         Call CFRelease() on `error` to fix the leak.  Update to use
4224         ARC-compliant cast.
4225         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4226         cast.
4227
4228 2019-02-21  Chris Dumez  <cdumez@apple.com>
4229
4230         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4231         https://bugs.webkit.org/show_bug.cgi?id=194481
4232
4233         Reviewed by Alex Christensen.
4234
4235         Give the processes a chance to shutdown and wait until we reached the expected number
4236         of processes.
4237
4238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4239
4240 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4241
4242         Fix the macOS build
4243
4244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4245
4246 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4247
4248         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4249
4250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4251         I am a backwards.
4252
4253 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4254
4255         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4256
4257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4258         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4259         We could force on UI-side compositing, but I feel like the test might be more
4260         valuable exercising the normal path on each platform (though the original
4261         bug was also UI-side specific). Though we can't validate that the overlay
4262         layer was installed successfully, there are layout tests that do that.
4263
4264 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4265
4266         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4267         https://bugs.webkit.org/show_bug.cgi?id=194845
4268         <rdar://problem/47944579>
4269
4270         Reviewed by Antti Koivisto.
4271
4272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4274
4275 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4276
4277         [LFC][Floats] Add support for placing formatting roots in-between floats.
4278         https://bugs.webkit.org/show_bug.cgi?id=194902
4279
4280         Reviewed by Antti Koivisto.
4281
4282         * LayoutReloaded/misc/LFC-passing-tests.txt:
4283
4284 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4285
4286         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4287         https://bugs.webkit.org/show_bug.cgi?id=194901
4288
4289         Unreviewed build fix.
4290
4291         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4292         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4293         WPEBackend-fdo-0.1 as library name.
4294
4295 2019-02-21  Rob Buis  <rbuis@igalia.com>
4296
4297         Update MIME type parser
4298         https://bugs.webkit.org/show_bug.cgi?id=180526
4299
4300         Reviewed by Darin Adler.
4301
4302         Add tests involving leading and trailing whitespace, non-token
4303         characters and quoted strings.
4304
4305         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4306         (TestWebKitAPI::TEST):
4307
4308 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4309
4310         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4311         https://bugs.webkit.org/show_bug.cgi?id=194884
4312
4313         Reviewed by Michael Catanzaro.
4314
4315         * PlatformWin.cmake:
4316
4317 2019-02-20  Chris Dumez  <cdumez@apple.com>
4318
4319         Add API test for <rdar://problem/47471222>
4320         https://bugs.webkit.org/show_bug.cgi?id=194847
4321
4322         Reviewed by Alex Christensen.
4323
4324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4325
4326 2019-02-20  Chris Dumez  <cdumez@apple.com>
4327
4328         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4329         https://bugs.webkit.org/show_bug.cgi?id=194872
4330         <rdar://problem/47924500>
4331
4332         Reviewed by Alex Christensen.
4333
4334         Add API test coverage.
4335
4336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4337
4338 2019-02-20  Jer Noble  <jer.noble@apple.com>
4339
4340         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4341         https://bugs.webkit.org/show_bug.cgi?id=191332
4342
4343         Reviewed by Dean Jackson.
4344
4345         * Scripts/git-is-in-range: Added.
4346
4347 2019-02-20  Andy Estes  <aestes@apple.com>
4348
4349         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4350         https://bugs.webkit.org/show_bug.cgi?id=194869
4351
4352         Rubber-stamped by Jer Noble.
4353
4354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4355         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4356         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4357         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4359         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4360
4361 2019-02-20  Chris Dumez  <cdumez@apple.com>
4362
4363         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4364         https://bugs.webkit.org/show_bug.cgi?id=194857
4365         <rdar://problem/47759323>
4366
4367         Reviewed by Alex Christensen.
4368
4369         Add API test coverage.
4370
4371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: