[iOS] Crash during font loading when injected bundle cancels load
[WebKit-https.git] / Tools / ChangeLog
1 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         [iOS] Crash during font loading when injected bundle cancels load
4         https://bugs.webkit.org/show_bug.cgi?id=155001
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
10         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
11         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
12         (-[Myles webView:didFinishNavigation:]):
13         (TEST):
14         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
15         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
16         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
17
18 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
19
20         [check-webkit-style] Added checks for redundant virtual specifiers.
21         https://bugs.webkit.org/show_bug.cgi?id=155017
22
23         Reviewed by Darin Adler.
24
25         Added 3 new checks related to virtual, override, and final specifiers:
26
27         1. When "override" is present, "virtual" is redundant.
28         2. When "final" is present, "virtual" is redundant.
29         3. When "final" is present, "override" is redundant.
30
31         * Scripts/webkitpy/style/checkers/cpp.py:
32         (_FunctionState.begin):
33         (_FunctionState.is_virtual):
34         (_check_parameter_name_against_text):
35         (_error_redundant_specifier):
36         (check_function_definition):
37         (CppChecker):
38         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
39         (FunctionDetectionTest.perform_function_detection):
40         (FunctionDetectionTest.test_basic_function_detection):
41         (FunctionDetectionTest.test_function_declaration_detection):
42         (FunctionDetectionTest.test_pure_function_detection):
43         (FunctionDetectionTest.test_override_and_final_function_detection):
44         (FunctionDetectionTest.test_non_functions):
45         (FunctionDetectionTest.test_parameter_list):
46
47 2016-03-03  Darin Adler  <darin@apple.com>
48
49         Followup to:
50         Remove "virtual" from all lines that have both "virtual" and "override".
51         https://bugs.webkit.org/show_bug.cgi?id=155005
52
53         Reviewed by Geoffrey Garen.
54
55         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
56         use either override or final, not both, and to remove virtual from all lines that
57         have both virtual and final.
58
59 2016-03-03  Darin Adler  <darin@apple.com>
60
61         Remove "virtual" from all lines that have both "virtual" and "override".
62         https://bugs.webkit.org/show_bug.cgi?id=155005
63
64         Reviewed by Geoffrey Garen.
65
66         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
67
68 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
69
70         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
71         https://bugs.webkit.org/show_bug.cgi?id=154595
72
73         Unreviewed fix after r197505.
74
75         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
76         (RunBenchmarkTests.start):
77
78 2016-03-03  Daniel Bates  <dabates@apple.com>
79
80         Add unit tests for WTF::OptionSet
81         https://bugs.webkit.org/show_bug.cgi?id=154925
82         <rdar://problem/24964211>
83
84         Reviewed by Darin Adler.
85
86         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
87
88         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
89         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
90         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
91         (TestWebKitAPI::TEST):
92
93 2016-03-03  Commit Queue  <commit-queue@webkit.org>
94
95         Unreviewed, rolling out r197442.
96         https://bugs.webkit.org/show_bug.cgi?id=154967
97
98         Broke tests, and also uses a wrong approach (Requested by ap
99         on #webkit).
100
101         Reverted changeset:
102
103         "Disable FTL JIT testing on 32-bit JSC tester bots"
104         https://bugs.webkit.org/show_bug.cgi?id=154858
105         http://trac.webkit.org/changeset/197442
106
107 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
108
109         [GTK] Run the run-benchmark script on the performance bot.
110         https://bugs.webkit.org/show_bug.cgi?id=154595
111
112         Reviewed by Carlos Garcia Campos.
113
114         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
115         (RunBenchmarkTests):
116         (RunBenchmarkTests.start):
117         (RunBenchmarkTests.getText):
118         (RunBenchmarkTests.getText2):
119         (BuildAndPerfTestFactory.__init__):
120         (DownloadAndPerfTestFactory.__init__):
121         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
122         (RunBenchmarkTest):
123         (RunBenchmarkTest.assertResults):
124         (RunBenchmarkTest.test_success):
125         (RunBenchmarkTest.test_tests_failed):
126         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
127         (BenchmarkRunner._run_benchmark):
128         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
129         (GTKMiniBrowserDriver.close_browsers):
130         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
131         (parse_args):
132         (start):
133         (main):
134
135 2016-03-03  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
136
137         [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
138         https://bugs.webkit.org/show_bug.cgi?id=154960
139
140         Reviewed by Csaba Osztrogonác.
141
142         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
143         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
144
145 2016-03-03  Frederic Wang  <fwang@igalia.com>
146
147         [jhbuild] Remove LLVM dependency.
148         https://bugs.webkit.org/show_bug.cgi?id=153274
149
150         Reviewed by Carlos Garcia Campos.
151
152         * gtk/jhbuild.modules:
153
154 2016-03-02  Alejandro G. Castro  <alex@igalia.com>
155
156         Unreviewed build fix for media-stream after r197114.
157
158         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
159         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
160
161 2016-03-01  Csaba Osztrogonác  <ossy@webkit.org>
162
163         Disable FTL JIT testing on 32-bit JSC tester bots
164         https://bugs.webkit.org/show_bug.cgi?id=154858
165
166         Reviewed by Saam Barati.
167
168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
169         (Run32bitJSCTests):
170
171 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
172
173         Fix iOS EWS.
174         https://bugs.webkit.org/show_bug.cgi?id=154880
175
176         Reviewed by Alexey Proskuryakov.
177
178         * Scripts/copy-webkitlibraries-to-product-directory:
179
180 2016-02-29  Chris Dumez  <cdumez@apple.com>
181
182         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
183         https://bugs.webkit.org/show_bug.cgi?id=154845
184
185         Reviewed by Ryosuke Niwa.
186
187         Update API tests accordingly.
188
189         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
190         (TestWebKitAPI::testParseHTMLInteger):
191         (TestWebKitAPI::parseHTMLIntegerFails):
192         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
193         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
194         (TestWebKitAPI::TEST): Deleted.
195
196 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
197
198         Remove the experimental feature of antialiased font dilation
199         https://bugs.webkit.org/show_bug.cgi?id=154843
200
201         Reviewed by Zalan Bujtas.
202
203         Remove the "antialiased font dilation" code path, and related prefs.
204
205         * DumpRenderTree/mac/DumpRenderTree.mm:
206         (resetWebPreferencesToConsistentValues): Deleted.
207         * WebKitTestRunner/TestController.cpp:
208         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
209
210 2016-02-29  Brady Eidson  <beidson@apple.com>
211
212         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
213
214         Unreviewed.
215
216         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
217         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
218         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
219         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
220           so we should always wait for it and make sure we got it.
221
222 2016-02-29  Brady Eidson  <beidson@apple.com>
223
224         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
225         https://bugs.webkit.org/show_bug.cgi?id=154837
226
227         Reviewed by Alex Christensen.
228
229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
230         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
231         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
232         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
233
234 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
235
236         [GTK][jhbuild] GLib build fails with GCC 6.0
237         https://bugs.webkit.org/show_bug.cgi?id=154825
238
239         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
240
241         Reviewed by Csaba Osztrogonác.
242
243         * gtk/jhbuild.modules: Apply upstream path.
244         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
245
246 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
247
248         We've been running Octane/regexp all wrong in run-jsc-benchmarks
249         https://bugs.webkit.org/show_bug.cgi?id=154827
250
251         Reviewed by Andreas Kling.
252
253         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
254         it without warmup. This patches fixes this by making this script run it with warmup.
255
256         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
257         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
258
259         It discovered this bug because for each Octane test that I want to debug, I usually make
260         a standalone .js file that contains the whole test along with a miniharness - usually
261         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
262         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
263         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
264         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
265         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
266
267         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
268         run on some of these very large functions in the regexp benchmark. I don't think we can
269         do anything about that, and I'd argue that the speed-up we see after the compilation is
270         done suggests that it was worth it.
271
272         * Scripts/run-jsc-benchmarks:
273
274 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
275
276         RefCounter<T>::Event -> RefCounterEvent
277         https://bugs.webkit.org/show_bug.cgi?id=154767
278
279         Reviewed by Darin Adler.
280
281         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
282         to be specific to a particular typeof RefCounter. Move the enum class up to
283         the top level & rename to RefCounterEvent.
284
285         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
286         (TestWebKitAPI::TEST):
287
288 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
289
290         Remove more LLVM related cruft
291         https://bugs.webkit.org/show_bug.cgi?id=154821
292
293         Reviewed by Darin Adler.
294
295         * Scripts/build-jsc:
296         * Scripts/build-webkit:
297         * Scripts/copy-webkitlibraries-to-product-directory:
298         * Scripts/export-llvm-build: Removed.
299         * Scripts/run-jsc-stress-tests:
300
301 2016-02-28  Sam Weinig  <sam@webkit.org>
302
303         Reimplement WKPageGroup in terms of WKUserContentController
304         https://bugs.webkit.org/show_bug.cgi?id=154804
305
306         Reviewed by Dan Bernstein.
307
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
310
311 2016-02-28  Sam Weinig  <sam@webkit.org>
312
313         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
314         https://bugs.webkit.org/show_bug.cgi?id=154798
315
316         Reviewed by Dan Bernstein.
317
318         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
319         Add tests for removing _WKUserStyleSheets and WKUserScripts
320
321 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
322
323         Silence leaks under TextCodecICU::registerCodecs
324         https://bugs.webkit.org/show_bug.cgi?id=154737
325
326         Reviewed by Darin Adler.
327
328         * Scripts/webkitpy/port/leakdetector.py:
329         (LeakDetector._callstacks_to_exclude_from_leaks):
330
331 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
332
333         [GTK] Fix incorrect cast
334
335         Unreviewed.
336
337         * MiniBrowser/gtk/main.c:
338         (createBrowserWindow):
339
340 2016-02-26  Chris Dumez  <cdumez@apple.com>
341
342         Fix the behavior of reflecting IDL attributes of type unsigned long
343         https://bugs.webkit.org/show_bug.cgi?id=154771
344
345         Reviewed by Ryosuke Niwa.
346
347         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
348         implementation:
349         - "-0" is parsed as 0.
350         - Range boundaries are now [0; 2147483647].
351
352         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
353         (TestWebKitAPI::TEST):
354
355 2016-02-26  Brady Eidson  <beidson@apple.com>
356
357         Modern IDB: New database versions are never committed to SQLite.
358         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
359         
360         Modern IDB: If a database handle is not open, files are not actually deleted from disk
361         https://bugs.webkit.org/show_bug.cgi?id=154756
362
363         Reviewed by Alex Christensen.
364
365         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
369         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
370         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
371         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
372         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
373         (TEST):
374
375 2016-02-26  Commit Queue  <commit-queue@webkit.org>
376
377         Unreviewed, rolling out r197216.
378         https://bugs.webkit.org/show_bug.cgi?id=154766
379
380         Test simply needs updated result (Requested by litherum on
381         #webkit).
382
383         Reverted changeset:
384
385         "Unreviewed, rolling out r197158."
386         https://bugs.webkit.org/show_bug.cgi?id=154758
387         http://trac.webkit.org/changeset/197216
388
389 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
390
391         [iOS Simulator] Reftests don't work
392         https://bugs.webkit.org/show_bug.cgi?id=154764
393
394         Reviewed by Daniel Bates.
395
396         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
397         Use simctl instead of sim.
398
399 2016-02-26  Chris Dumez  <cdumez@apple.com>
400
401         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
402         https://bugs.webkit.org/show_bug.cgi?id=154714
403
404         Reviewed by Darin Adler.
405
406         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
407         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
408         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
409
410         * TestWebKitAPI/PlatformEfl.cmake:
411         * TestWebKitAPI/PlatformGTK.cmake:
412         * TestWebKitAPI/PlatformWin.cmake:
413         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
414         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
416         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
417         (TestWebKitAPI::testParseHTMLInteger):
418         (TestWebKitAPI::parseHTMLIntegerFails):
419         (TestWebKitAPI::TEST):
420         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
421         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
422
423 2016-02-26  Commit Queue  <commit-queue@webkit.org>
424
425         Unreviewed, rolling out r197158.
426         https://bugs.webkit.org/show_bug.cgi?id=154758
427
428         This change did not fix the failing test (Requested by
429         ryanhaddad on #webkit).
430
431         Reverted changeset:
432
433         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
434         surrogate.html is flakey"
435         https://bugs.webkit.org/show_bug.cgi?id=154709
436         http://trac.webkit.org/changeset/197158
437
438 2016-02-26  Anders Carlsson  <andersca@apple.com>
439
440         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
441         https://bugs.webkit.org/show_bug.cgi?id=154750
442         rdar://problem/23861395
443
444         Reviewed by Tim Horton.
445
446         * MiniBrowser/mac/WK2BrowserWindowController.m:
447         (-[WK2BrowserWindowController fetchWebsiteData:]):
448         Use the new WKWebsiteDataStore SPI to compute data sizes.
449
450 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
451
452         RefCounter value changed callback should be called on all changes (not just zero edge).
453         https://bugs.webkit.org/show_bug.cgi?id=154699
454
455         Reviewed by Geoff Garen.
456
457         RefCounter currently only triggers a callback when the count goes from zero
458         to non-zero and vice-versa. Change that, to be useful to more clients.
459
460         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
461         (TestWebKitAPI::TEST):
462             - Updated for change in RefCounter callback siganture & behaviour.
463
464 2016-02-25  Sam Weinig  <sam@webkit.org>
465
466         Allow WKUserScripts to be run in isolated worlds
467         https://bugs.webkit.org/show_bug.cgi?id=154701
468
469         Reviewed by Anders Carlsson.
470
471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
472         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
473         (-[SimpleDelegate webView:didFinishNavigation:]):
474         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
475         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
476         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
477         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
478         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
479         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
480
481 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
482
483         W3C test importer should have an option to clean the destination directory
484         https://bugs.webkit.org/show_bug.cgi?id=152685
485
486         Reviewed by Darin Adler.
487
488         Adding --clean-dest-dir option to W3C test importer.
489         When this option is set, all files in the destination directory will be deleted
490         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
491         Dangling test expectations are removed after tests import.'
492
493         Adding unit test and minor refactoring for the other tests.
494
495         * Scripts/webkitpy/w3c/test_importer.py:
496         (parse_args): Add '--clean-dest-dir' option.
497         (TestImporter.do_import):
498         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
499         (TestImporter):
500         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
501         (TestImporter.clean_destination_directory):
502         (TestImporter.remove_dangling_expectations):
503         * Scripts/webkitpy/w3c/test_importer_unittest.py:
504         (TestImporterTest._parse_options):
505         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
506         (TestImporterTest.test_import_dir_with_no_tests):
507         (TestImporterTest.test_import_dir_with_empty_init_py):
508         (test_clean_directory_option):
509
510 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
511
512         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
513         https://bugs.webkit.org/show_bug.cgi?id=154709
514         <rdar://problem/24483596>
515
516         Reviewed by Dan Bernstein.
517
518         Force auto-activation rules to a consistent state.
519
520         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
521         (WTR::InjectedBundle::platformInitialize):
522
523 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
524
525         Unreivewed build fix for r197150.
526
527         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
528
529 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
530
531         Restrict information passed with navigation action which is triggered by untrusted event
532         https://bugs.webkit.org/show_bug.cgi?id=154571
533         <rdar://problem/15967937>
534
535         Reviewed by Andy Estes.
536
537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
538         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
539         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
540         (TestWebKitAPI::TEST):
541         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
542         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
543
544 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
545
546         Should template RefCounter instead of RefCounter::Token
547         https://bugs.webkit.org/show_bug.cgi?id=154691
548
549         Reviewed by Anders Carlsson.
550
551         Mechanical update per RefCounter interface change.
552
553         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
554         (TestWebKitAPI::TEST):
555
556 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
557
558         Unreviewed: Add Aleksandr Skachkov as a commiter
559
560         * Scripts/webkitpy/common/config/contributors.json:
561
562 2016-02-25  Sam Weinig  <sam@webkit.org>
563
564         HashMap::ensure() should return an AddResult like all the other add-like functions
565         https://bugs.webkit.org/show_bug.cgi?id=154680
566
567         Reviewed by Anders Carlsson.
568
569         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
570         (TestWebKitAPI::TEST):
571         Update tests to use/test the new AddResult result.
572
573 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
574
575         Enable MallocScribble when detecting leaks
576         https://bugs.webkit.org/show_bug.cgi?id=154679
577
578         Reviewed by Geoffrey Garen.
579
580         * Scripts/webkitpy/port/ios.py:
581         (IOSSimulatorPort.setup_environ_for_server):
582         * Scripts/webkitpy/port/mac.py:
583         (MacPort.setup_environ_for_server):
584         * Scripts/webkitpy/port/mac_unittest.py:
585         (MacTest.test_setup_environ_for_server):
586
587 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
588
589         Unreviewed, fix iOS builds after r197114.
590
591         * WebKitTestRunner/TestController.cpp:
592         (WTR::createCanonicalUUIDString):
593         (WTR::TestController::saltForOrigin):
594
595 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
596
597         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
598         https://bugs.webkit.org/show_bug.cgi?id=153163
599         <rdar://problem/24334526>
600
601         Reviewed by Tim Horton.
602
603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
604         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
605         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
606
607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
608         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
610
611         * WebKitTestRunner/TestController.cpp:
612         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
613         (WTR::checkUserMediaPermissionForOrigin): Ditto.
614         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
615         (WTR::originUserVisibleName): Return a String.
616         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
617         (WTR::TestController::saltForOrigin): Return salt for an origin.
618         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
619         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
620         (WTR::TestController::handleUserMediaPermissionRequest):
621         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
622         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
623         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
624         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
625         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
626         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
627         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
628         * WebKitTestRunner/TestController.h:
629
630         * WebKitTestRunner/TestInvocation.cpp:
631         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
632
633 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
634
635         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
636         https://bugs.webkit.org/show_bug.cgi?id=151688
637
638         Reviewed by Dean Jackson.
639
640         Enables the WEB_ANIMATIONS compiler switch by default.
641
642         * Scripts/webkitperl/FeatureList.pm:
643
644 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
645
646         W3C importer should generate all web-platform-tests submodules descriptions
647         https://bugs.webkit.org/show_bug.cgi?id=154587
648
649         Reviewed by Darin Adler.
650
651         Updated submodules description format (removing submodule name as it is the last string of the path really).
652         Added git subroutines.
653
654         * Scripts/webkitpy/common/checkout/scm/git.py:
655         (Git.origin_url):
656         (Git):
657         (Git.init_submodules):
658         (Git.submodules_status):
659         (Git.deinit_submodules):
660         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
661         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
662         * Scripts/webkitpy/w3c/test_downloader.py:
663         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
664         * Scripts/webkitpy/w3c/test_importer_unittest.py:
665         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
666
667 2016-02-23  Dan Bernstein  <mitz@apple.com>
668
669         [Xcode] Linker errors display mangled names, but no longer should
670         https://bugs.webkit.org/show_bug.cgi?id=154632
671
672         Reviewed by Sam Weinig.
673
674         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
675         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
676         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
677         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
678         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
679         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
680         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
681
682 2016-02-23  Anders Carlsson  <andersca@apple.com>
683
684         WKWebView should implement NSCoding
685         https://bugs.webkit.org/show_bug.cgi?id=137160
686
687         Reviewed by Dan Bernstein.
688
689         Add tests.
690
691         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
692         (TEST):
693
694 2016-02-23  Anders Carlsson  <andersca@apple.com>
695
696         WKProcessPool should conform to NSCoding
697         https://bugs.webkit.org/show_bug.cgi?id=154608
698
699         Reviewed by Sam Weinig.
700
701         Add tests.
702
703         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
704         (TEST):
705
706 2016-02-23  Anders Carlsson  <andersca@apple.com>
707
708         WKWebsiteDataStore should conform to NSCoding
709         https://bugs.webkit.org/show_bug.cgi?id=154605
710
711         Reviewed by Dan Bernstein.
712
713         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
714         (TEST):
715
716 2016-02-23  Anders Carlsson  <andersca@apple.com>
717
718         WKWebViewConfiguration should conform to NSCoding
719         https://bugs.webkit.org/show_bug.cgi?id=154602
720
721         Reviewed by Beth Dakin.
722
723         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
724         (TEST):
725
726 2016-02-23  Anders Carlsson  <andersca@apple.com>
727
728         WKPreferences should conform to NSCoding
729         https://bugs.webkit.org/show_bug.cgi?id=154597
730
731         Reviewed by Sam Weinig.
732
733         Test encoding and decoding WKPreferences.
734
735         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
736         (encodeAndDecode):
737         (TEST):
738
739 2016-02-23  Anders Carlsson  <andersca@apple.com>
740
741         Fix build.
742
743         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
744         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
745
746 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
747
748         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
749         https://bugs.webkit.org/show_bug.cgi?id=153993
750
751         Reviewed by Carlos Garcia Campos.
752
753         * MiniBrowser/gtk/main.c:
754         (createBrowserWindow): Support --geometry argument for MiniBrowser.
755         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
756         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
757         The base class has to be loaded first, otherwise any subclase referencing it will give import error.
758         In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
759         By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
760         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
761         (BrowserDriverFactory.create):
762         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
763         (GTKBrowserDriver):
764         (GTKBrowserDriver.prepare_env):
765         (GTKBrowserDriver.restore_env):
766         (GTKBrowserDriver.close_browsers):
767         (GTKBrowserDriver._launch_process):
768         (GTKBrowserDriver._terminate_processes):
769         (GTKBrowserDriver._screen_size):
770         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
771         (GTKMiniBrowserDriver):
772         (GTKMiniBrowserDriver.prepare_env):
773         (GTKMiniBrowserDriver.launch_url):
774         (GTKMiniBrowserDriver.close_browsers):
775         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
776         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
777         (SimpleHTTPServerDriver):
778         (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
779         Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
780         * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
781         (load_subclasses):
782
783 2016-02-23  Alejandro G. Castro  <alex@igalia.com>
784
785         [GTK] Missing configuration patch for openh264 compilation
786         https://bugs.webkit.org/show_bug.cgi?id=154455
787
788         This patch is required for the openh264 compilation with the
789         jhbuild-webrtc.modules. The code was implemented by Alessandro
790         Decina.
791
792         Reviewed by Philippe Normand.
793
794         * gtk/patches/openh264-configure.patch: Added.
795
796 2016-02-20  Olivier Blin  <olivier.blin@softathome.com>
797
798         [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
799         https://bugs.webkit.org/show_bug.cgi?id=154479
800
801         Reviewed by Michael Catanzaro.
802
803         * WebKitTestRunner/CMakeLists.txt:
804
805 2016-02-19  Konstantin Tokarev  <annulen@yandex.ru>
806
807         [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
808         https://bugs.webkit.org/show_bug.cgi?id=154467
809
810         Reviewed by Michael Catanzaro.
811
812         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
813         (beforeAll):
814         (afterAll):
815
816 2016-02-19  Brady Eidson  <beidson@apple.com>
817
818         Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
819         https://bugs.webkit.org/show_bug.cgi?id=154428
820
821         Reviewed by Jer Noble.
822
823         * WebKitTestRunner/TestController.cpp:
824         (WTR::TestController::generatePageConfiguration):
825         (WTR::TestController::databaseProcessName):
826         (WTR::TestController::databaseProcessDidCrash):
827         * WebKitTestRunner/TestController.h:
828
829 2016-02-18  Philippe Normand  <pnormand@igalia.com>
830
831         [GStreamer] Bump internal jhbuild versions to 1.6.3
832         https://bugs.webkit.org/show_bug.cgi?id=149594
833
834         Reviewed by Michael Catanzaro.
835
836         * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
837         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
838         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
839         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
840
841 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
842
843         Extend HashCountedSet with a method to efficiently set the count of an entry
844         https://bugs.webkit.org/show_bug.cgi?id=154352
845
846         Reviewed by Geoffrey Garen.
847
848         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
850         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
851
852 2016-02-18  Commit Queue  <commit-queue@webkit.org>
853
854         Unreviewed, rolling out r196791.
855         https://bugs.webkit.org/show_bug.cgi?id=154438
856
857         broke windows build (Requested by alexchristensen on #webkit).
858
859         Reverted changeset:
860
861         "Extend HashCountedSet with a method to efficiently set the
862         count of an entry"
863         https://bugs.webkit.org/show_bug.cgi?id=154352
864         http://trac.webkit.org/changeset/196791
865
866 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
867
868         Extend HashCountedSet with a method to efficiently set the count of an entry
869         https://bugs.webkit.org/show_bug.cgi?id=154352
870
871         Reviewed by Geoffrey Garen.
872
873         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
875         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
876
877 2016-02-18  Anders Carlsson  <andersca@apple.com>
878
879         Get rid of the --target-web-process and --use-web-process-xpc-service options.
880
881         Rubber-stamped by Dan Bernstein.
882
883         We now always use XPC, and --target-web-process is no longer supported.
884
885         * Scripts/webkitdirs.pm:
886         (execMacWebKitAppForDebugging):
887         (shouldTargetWebProcess): Deleted.
888         (determineShouldTargetWebProcess): Deleted.
889         (shouldUseXPCServiceForWebProcess): Deleted.
890         (determineShouldUseXPCServiceForWebProcess): Deleted.
891         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
892         (argumentsForRunAndDebugMacWebKitApp): Deleted.
893
894 2016-02-18  Ryan Haddad  <ryanhaddad@apple.com>
895
896         Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
897         https://bugs.webkit.org/show_bug.cgi?id=153997
898
899         Reviewed by Filip Pizlo.
900
901         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
902
903 2016-02-18  Jer Noble  <jer.noble@apple.com>
904
905         run-webkit-httpd should use webkitpy to run httpd.
906         https://bugs.webkit.org/show_bug.cgi?id=154271
907
908         Reviewed by Alexey Proskuryakov.
909
910         Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
911         options to match the current run-webkit-httpd (optional) behavior.
912
913         * Scripts/run-webkit-httpd:
914         (parse_args):
915         (main):
916         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
917         (LayoutTestApacheHttpd.__init__):
918         * Scripts/webkitpy/layout_tests/servers/http_server.py:
919         (Lighttpd._prepare_config):
920         * Scripts/webkitpy/port/base.py:
921         (Port.to.start_http_server):
922
923 2016-02-18  Filip Pizlo  <fpizlo@apple.com>
924
925         Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
926         https://bugs.webkit.org/show_bug.cgi?id=154383
927
928         Reviewed by Saam Barati.
929
930         * Scripts/run-jsc-stress-tests:
931
932 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
933
934         Remove LLVM dependencies from WebKit
935         https://bugs.webkit.org/show_bug.cgi?id=154323
936
937         Reviewed by Antti Koivisto and Benjamin Poulain.
938
939         * Scripts/copy-webkitlibraries-to-product-directory:
940         (isContentOfFileEqualToString):
941         (fileContains): Deleted.
942         (buildLLVM): Deleted.
943         (symlinkLLVMLibrariesIfNeeded): Deleted.
944
945 2016-02-16  Sam Weinig  <sam@webkit.org>
946
947         Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
948         https://bugs.webkit.org/show_bug.cgi?id=134857
949
950         Reviewed by Geoffrey Garen.
951
952         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
953         Add tests for HashMap::ensure.
954
955 2016-02-17  Nan Wang  <n_wang@apple.com>
956
957         AX: Implement sentence related text marker functions using TextIterator
958         https://bugs.webkit.org/show_bug.cgi?id=154312
959
960         Reviewed by Chris Fleizach.
961
962         * DumpRenderTree/AccessibilityUIElement.cpp:
963         (nextParagraphEndTextMarkerForTextMarkerCallback):
964         (sentenceTextMarkerRangeForTextMarkerCallback):
965         (previousSentenceStartTextMarkerForTextMarkerCallback):
966         (nextSentenceEndTextMarkerForTextMarkerCallback):
967         (setSelectedVisibleTextRangeCallback):
968         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
969         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
970         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
971         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
972         (AccessibilityUIElement::getJSClass):
973         * DumpRenderTree/AccessibilityUIElement.h:
974         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
975         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
976         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
977         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
978         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
979         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
980         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
981         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
982         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
983         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
984         (AccessibilityUIElement::supportedActions):
985         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
986         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
987         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
988         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
989         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
990         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
991         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
992         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
993         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
994         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
995         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
996         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
997         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
998         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
999         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1000         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1001         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1002         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1003         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1004         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1005         (WTR::_convertMathMultiscriptPairsToString):
1006
1007 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
1008
1009         [Mac] Gather some rudimentary statistics during resource load 
1010         https://bugs.webkit.org/show_bug.cgi?id=153575
1011         <rdar://problem/24075254>
1012
1013         Reviewed by Brady Eidson.
1014
1015         * MiniBrowser/mac/SettingsController.h:
1016         * MiniBrowser/mac/SettingsController.m:
1017         (-[SettingsController _populateMenu]): Add menu item for new debug flag.
1018         (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
1019         (-[SettingsController resourceLoadStatisticsEnabled]): Added.
1020         * MiniBrowser/mac/WK1BrowserWindowController.m:
1021         (-[WK1BrowserWindowController didChangeSettings]): React to changes in
1022         users's desire to track resource load statistics.
1023
1024 2016-02-15  Csaba Osztrogonác  <ossy@webkit.org>
1025
1026         [EFL] Update Tools/efl/install-dependencies
1027         https://bugs.webkit.org/show_bug.cgi?id=154239
1028
1029         Reviewed by Michael Catanzaro.
1030
1031         * efl/install-dependencies:
1032
1033 2016-02-15  Alex Christensen  <achristensen@webkit.org>
1034
1035         Fix internal Windows build of projects built after WebKit
1036         https://bugs.webkit.org/show_bug.cgi?id=154249
1037         rdar://problem/24644805
1038
1039         Reviewed by Chris Dumez.
1040
1041         * DumpRenderTree/PlatformWin.cmake:
1042         * MiniBrowser/win/CMakeLists.txt:
1043         Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
1044         more like projects built internally after WebKit.  They should only need to use what
1045         is in ForwardingHeaders/WebKit.
1046
1047 2016-02-12  Nan Wang  <n_wang@apple.com>
1048
1049         AX: Implement paragraph related text marker functions using TextIterator
1050         https://bugs.webkit.org/show_bug.cgi?id=154098
1051         <rdar://problem/24269675>
1052
1053         Reviewed by Chris Fleizach.
1054
1055         * DumpRenderTree/AccessibilityUIElement.cpp:
1056         (nextWordEndTextMarkerForTextMarkerCallback):
1057         (paragraphTextMarkerRangeForTextMarkerCallback):
1058         (previousParagraphStartTextMarkerForTextMarkerCallback):
1059         (nextParagraphEndTextMarkerForTextMarkerCallback):
1060         (setSelectedVisibleTextRangeCallback):
1061         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1062         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1063         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1064         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1065         (AccessibilityUIElement::getJSClass):
1066         * DumpRenderTree/AccessibilityUIElement.h:
1067         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1068         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1069         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1070         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1071         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1073         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1074         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1075         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1076         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1077         (AccessibilityUIElement::supportedActions):
1078         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1079         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1080         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1081         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1082         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1083         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1084         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1087         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1088         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1089         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1090         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1091         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1092         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1093         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1094         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1095         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1096         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1097         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1098         (WTR::_convertMathMultiscriptPairsToString):
1099
1100 2016-02-12  Jason Marcell  <jmarcell@apple.com>
1101
1102         Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
1103         https://bugs.webkit.org/show_bug.cgi?id=154180
1104
1105         Reviewed by Alexey Proskuryakov.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
1108         repository.
1109
1110 2016-02-12  Jer Noble  <jer.noble@apple.com>
1111
1112         [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
1113         https://bugs.webkit.org/show_bug.cgi?id=154136
1114
1115         Reviewed by Alex Christensen.
1116
1117         Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
1118
1119         Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
1120         to GCC_PREPROCESSOR_DEFINES.
1121
1122         * TestWebKitAPI/Configurations/Base.xcconfig:
1123         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1124         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1125         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
1126         (TestWebKitAPI::TEST_F):
1127
1128 2016-02-11  Dana Burkart  <dburkart@apple.com>
1129
1130         Large logs can bring down the webkit master
1131         https://bugs.webkit.org/show_bug.cgi?id=122112
1132
1133         Reviewed by Lucas Forschler.
1134
1135         Implement the suggested fix of throwing away stdout / stderr.
1136
1137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1138         (RunWebKit1LeakTests):
1139
1140 2016-02-10  Jason Marcell  <jmarcell@apple.com>
1141
1142         Remove calls to parseInt in order to work with non-integer revisions
1143         https://bugs.webkit.org/show_bug.cgi?id=153820
1144
1145         Reviewed by Daniel Bates.
1146
1147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1148         (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
1149         revisions.
1150         (BuildbotIteration.prototype._parseData): Ditto.
1151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1152         (BuildbotQueue.prototype.update): Ditto.
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
1154         (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1156         (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
1157         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
1158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
1159
1160 2016-02-10  Jason Marcell  <jmarcell@apple.com>
1161
1162         Teach dashboard code to compare non-integer revisions
1163         https://bugs.webkit.org/show_bug.cgi?id=152345
1164
1165         Reviewed by Daniel Bates.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1168         (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1170         (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
1171         revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
1172         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
1173         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
1174         revisions. Also uses new Trac.nextRevision method to calculate a revision range.
1175         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1177         (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
1178         methods.
1179         (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
1180         (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
1181         (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
1182         (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
1183         (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
1185
1186 2016-02-09  Nan Wang  <n_wang@apple.com>
1187
1188         AX: Implement word related text marker functions using TextIterator
1189         https://bugs.webkit.org/show_bug.cgi?id=153939
1190         <rdar://problem/24269605>
1191
1192         Reviewed by Chris Fleizach.
1193
1194         * DumpRenderTree/AccessibilityUIElement.cpp:
1195         (endTextMarkerCallback):
1196         (leftWordTextMarkerRangeForTextMarkerCallback):
1197         (rightWordTextMarkerRangeForTextMarkerCallback):
1198         (previousWordStartTextMarkerForTextMarkerCallback):
1199         (nextWordEndTextMarkerForTextMarkerCallback):
1200         (setSelectedVisibleTextRangeCallback):
1201         (AccessibilityUIElement::setSelectedVisibleTextRange):
1202         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1203         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1204         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1205         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1206         (AccessibilityUIElement::getJSClass):
1207         * DumpRenderTree/AccessibilityUIElement.h:
1208         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1209         (AccessibilityUIElement::setSelectedVisibleTextRange):
1210         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1211         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1212         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1213         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1214         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1215         (AccessibilityUIElement::setSelectedVisibleTextRange):
1216         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1217         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1218         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1219         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1220         (AccessibilityUIElement::supportedActions):
1221         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1222         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1223         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1224         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1225         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1226         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1227         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1228         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1229         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1230         (WTR::AccessibilityUIElement::endTextMarker):
1231         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1232         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1233         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1234         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1235         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1236         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1237         (WTR::AccessibilityUIElement::endTextMarker):
1238         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1239         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1240         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1241         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1242         (WTR::_convertMathMultiscriptPairsToString):
1243
1244 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1245
1246         [EFL] Remove eail related cruft after r195725
1247         https://bugs.webkit.org/show_bug.cgi?id=154030
1248
1249         Reviewed by Alex Christensen.
1250
1251         * efl/jhbuildrc:
1252
1253 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1254
1255         [EFL] Remove LLVM related cruft after r196077
1256         https://bugs.webkit.org/show_bug.cgi?id=154031
1257
1258         Reviewed by Alex Christensen.
1259
1260         * efl/jhbuild.modules:
1261         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
1262         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
1263         * efl/patches/llvm-version-arm64.patch: Removed.
1264
1265 2016-02-05  Aakash Jain  <aakash_jain@apple.com>
1266
1267         tests fail if display sleeps while run-webkit-tests is running
1268         https://bugs.webkit.org/show_bug.cgi?id=153919
1269
1270         Reviewed by Alexey Proskuryakov.
1271
1272         * DumpRenderTree/mac/LayoutTestHelper.m:
1273         (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
1274         (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
1275         (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
1276
1277 2016-02-05  Alex Christensen  <achristensen@webkit.org>
1278
1279         Fix iOS API tests after r196082
1280         https://bugs.webkit.org/show_bug.cgi?id=153900
1281
1282         Reviewed by Jer Noble.
1283
1284         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1285         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1286         [WebView initialize] doesn't call JSC::initializeThreading on iOS.
1287
1288 2016-02-04  Jason Marcell  <jmarcell@apple.com>
1289
1290         The status message for passing combined builder queues should say "all builds succeeded" when expanded.
1291         https://bugs.webkit.org/show_bug.cgi?id=153882
1292
1293         Reviewed by Alexey Proskuryakov.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1296         (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
1297         when expanded.
1298
1299 2016-02-03  Filip Pizlo  <fpizlo@apple.com>
1300
1301         run-jsc-stress-tests should be better at telling you details about test failures
1302         https://bugs.webkit.org/show_bug.cgi?id=153845
1303
1304         Reviewed by Geoffrey Garen.
1305
1306         Here's an example of the contents of results/resultsByFamily, one of the new files that this
1307         generates, for some local testing I'm doing.  Notice how it groups families of tests together.
1308
1309         You won't see this unless you cat results/resultsByFamily.
1310
1311         regress.yaml/Regress/radar-24289839.js:
1312             regress.yaml/Regress/radar-24289839.js.default: PASS
1313             regress.yaml/Regress/radar-24289839.js.ftl: PASS
1314             regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
1315             regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
1316         
1317         regress.yaml/Regress/radar-24290639.js:
1318             regress.yaml/Regress/radar-24290639.js.default: PASS
1319             regress.yaml/Regress/radar-24290639.js.ftl: PASS
1320             regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
1321             regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
1322         
1323         regress.yaml/Regress/radar-24290670.js: FAILED
1324         
1325         * Scripts/run-jsc-stress-tests:
1326
1327 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
1330         https://bugs.webkit.org/show_bug.cgi?id=153835
1331
1332         Reviewed by Martin Robinson.
1333
1334         WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
1335         the context menu event is not handled, but we are using the
1336         returned value without null checking it.
1337
1338         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1339         (WTR::EventSendingController::contextClick):
1340
1341 2016-02-03  Jason Marcell  <jmarcell@apple.com>
1342
1343         Format revisions for display according to repository type
1344         https://bugs.webkit.org/show_bug.cgi?id=153818
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1349         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
1350         to repository type.
1351         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1352         (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
1354         _formatRevisionForDisplay function.
1355
1356 2016-02-03  Aakash Jain  <aakash_jain@apple.com>
1357
1358         Logs/CoreSimulator filling up OS disk on WebKit testers
1359         https://bugs.webkit.org/show_bug.cgi?id=153853
1360         <rdar://problem/24496003>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         * Scripts/webkitpy/port/ios.py:
1365         (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
1366
1367 2016-02-03  Brian Burg  <bburg@apple.com>
1368
1369         git-add-reviewer should work when run from a subdirectory within the repository
1370         https://bugs.webkit.org/show_bug.cgi?id=153842
1371
1372         Reviewed by David Kilzer.
1373
1374         There are two problems that needed to be fixed:
1375
1376          - We can't assume .git is in $PWD/.git
1377          - We can't specify absolute paths to `git commit`
1378
1379         Fix these problems using the helpers in VCSUtils that were added to
1380         fix this same issue for prepare-changeCogs.
1381
1382         * Scripts/VCSUtils.pm: Export gitDirectory()
1383         * Scripts/git-add-reviewer:
1384         (nonInteractive): Cache gitDirectory() result.
1385         (addReviewer):
1386         (commit):
1387         (changeLogsForCommit): Make paths relative.
1388
1389 2016-02-03  Jer Noble  <jer.noble@apple.com>
1390
1391         Yet another Yosemite build fix.
1392
1393         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1394
1395 2016-02-03  Jer Noble  <jer.noble@apple.com>
1396
1397         iOS build fix after Yosemite build fix broke iOS build.
1398
1399         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1400
1401 2016-02-03  Jer Noble  <jer.noble@apple.com>
1402
1403         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
1404
1405         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1406
1407 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
1408
1409         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
1410         https://bugs.webkit.org/show_bug.cgi?id=153827
1411
1412         Reviewed by Michael Catanzaro.
1413
1414         When an array is passed to subroutines as argument in perl,
1415         a list containing its element is returned from the array.
1416         Currently @$ arguments are being passed, then it is going to be one list
1417         including all the elements not only from @ but also from $.
1418         As a result, --cmakeargs option's value is included in @cmakeArgs
1419         at generateBuildSystemFromCMakeProject subroutine,
1420         so $additionalCMakeArgs doesn't needed anymore.
1421
1422         * Scripts/webkitdirs.pm:
1423         (generateBuildSystemFromCMakeProject):
1424
1425 2016-02-03  Jer Noble  <jer.noble@apple.com>
1426
1427         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
1428         https://bugs.webkit.org/show_bug.cgi?id=153669
1429
1430         Reviewed by Alex Christensen.
1431
1432         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
1433         calling appropriate NSURLSessionDelegate callbacks.
1434
1435         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
1436         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
1437         inconsistencies when calling, e.g., inline methods.
1438
1439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
1440         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1442         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
1443         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
1444         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
1445         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
1446         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
1447         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1448         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
1449         (TestWebKitAPI::TEST_F):
1450
1451 2016-02-03  Konstantin Tokarev  <annulen@yandex.ru>
1452
1453         [webkitdirs] Clarify logic behind is{PortName} functions.
1454         https://bugs.webkit.org/show_bug.cgi?id=153554
1455
1456         Reviewed by Michael Catanzaro.
1457
1458         * Scripts/webkitdirs.pm:
1459         (prohibitUnknownPort): This function makes determinePortName()
1460         failure fatal.
1461         (determinePortName): Added new function which decides which port are
1462         we building based on command line switches and platform defaults.
1463         (portName): Added getter for determined $portName.
1464         (isEfl): Modified to use portName().
1465         (isGtk): Ditto.
1466         (isWinCairo): Ditto.
1467         (isAppleMacWebKit): Ditto.
1468         (isAppleWinWebKit): Ditto.
1469         (isIOSWebKit): Ditto.
1470         (cmakeBasedPortName): Return portName() with capitalized first letter.
1471         (determineIsEfl): Deleted.
1472         (determineIsGtk): Deleted.
1473         (determineIsWinCairo): Deleted.
1474
1475         * Scripts/build-jsc: Call prohibitUnknownPort().
1476         * Scripts/run-minibrowser: Ditto.
1477         * Scripts/webkitperl/FeatureList.pm: Ditto.
1478         * Scripts/update-webkit: Call determinePortName() instead of
1479         determineIsWinCairo().
1480
1481 2016-02-02  Dan Bernstein  <mitz@apple.com>
1482
1483         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
1484         https://bugs.webkit.org/show_bug.cgi?id=153683
1485
1486         Reviewed by Darin Adler.
1487
1488         * Scripts/webkitpy/port/driver.py:
1489         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
1490           used by any code in the Web Content process. If that ever changed, we should send it over
1491           as a bundle parameter.
1492
1493         * Scripts/webkitpy/port/ios.py:
1494         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
1495
1496         * Scripts/webkitpy/port/mac.py:
1497         (MacPort.setup_environ_for_server): Ditto.
1498
1499         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1500         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
1501           environment. This is early enough that libxml2 has not been initialized yet.
1502
1503         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1504         (WTR::InjectedBundle::platformInitialize): Ditto.
1505
1506 2016-02-02  Dan Bernstein  <mitz@apple.com>
1507
1508         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
1509         https://bugs.webkit.org/show_bug.cgi?id=153683
1510
1511         Reviewed by Alexey Proskuryakov.
1512
1513         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
1514
1515         * Scripts/webkitpy/port/driver.py:
1516         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
1517         * Scripts/webkitpy/port/ios.py:
1518         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
1519         * Scripts/webkitpy/port/mac.py:
1520         (MacPort.setup_environ_for_server): Ditto.
1521
1522 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1523
1524         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
1525         https://bugs.webkit.org/show_bug.cgi?id=153009
1526
1527         Reviewed by Gyuyoung Kim.
1528
1529         On mobile, virtual keyboard represented by ecore_imf module appears on
1530         the top of application layer usually covering bottom part of the screen.
1531         If the web page contains the editable content on the bottom of the page
1532         it will be overlapped by keyboard which prevents user from seeing the
1533         typed text.
1534
1535         Pack MiniBrowser layout into conformant widget to allow EFL to guess
1536         the space that will be required by the keyboard, finally resizing it
1537         to the desired size. As a result, webview gets resized and scrolled
1538         into focused elements which makes the editable elements visible while
1539         typing.
1540
1541         More details about elm_conformant widger can be found at:
1542         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
1543         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
1544
1545         * MiniBrowser/efl/main.c:
1546         (window_create): pack a box into conformant widget.
1547
1548 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
1549
1550         [GTK][EFL] Upgrade OpenWebRTC dependency
1551         https://bugs.webkit.org/show_bug.cgi?id=153489
1552
1553         Reviewed by Philippe Normand.
1554
1555         * Scripts/run-gtk-tests:
1556         (TestRunner): Avoid running the mediastream API test.
1557         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
1558         default for gtk and efl.
1559         * gtk/jhbuild-webrtc.modules: Added modules files with
1560         dependencies required to compile and test the mediastream.
1561
1562 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1563
1564         Add code to parse the git branches out of the Trac RSS feed
1565         https://bugs.webkit.org/show_bug.cgi?id=153624
1566
1567         Reviewed by Daniel Bates.
1568
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1570         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
1571         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
1572         "branches" and updated the code to work with an array instead of a string.
1573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1574         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
1575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
1576         fixture that contains XML with a Git branch.
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
1578         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
1579
1580 2016-02-01  Brady Eidson  <beidson@apple.com>
1581
1582         Add command line flag to DRT to output the number of tests completed in server mode.
1583         https://bugs.webkit.org/show_bug.cgi?id=153750
1584
1585         Reviewed by Darin Adler.
1586
1587         * DumpRenderTree/mac/DumpRenderTree.mm:
1588         (initializeGlobalsFromCommandLineOptions):
1589         (runTestingServerLoop):
1590
1591 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1592
1593         Improvements to botwatcher's dashboard unit tests.
1594         https://bugs.webkit.org/show_bug.cgi?id=153621
1595
1596         Reviewed by Darin Adler.
1597
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1599         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1601         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
1602         _popoverLinesForCommitRange have to traverse commits from different branches.
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
1604         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
1605         _revisionContentWithPopoverForIteration.
1606
1607 2016-02-01  Jason Marcell  <jmarcell@apple.com>
1608
1609         Refactor to add event listeners and start periodic updates for all trac instances.
1610         https://bugs.webkit.org/show_bug.cgi?id=153609
1611
1612         Reviewed by Darin Adler.
1613
1614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1615         (BuildbotQueueView): Adding event listeners for all trac instances.
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
1617         for all trac instances.
1618
1619 2016-01-31  Darin Adler  <darin@apple.com>
1620
1621         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
1622         https://bugs.webkit.org/show_bug.cgi?id=153639
1623
1624         Reviewed by Filip Pizlo.
1625
1626         * Scripts/do-webcore-rename: Use script to do this rename.
1627
1628 2016-01-30  Commit Queue  <commit-queue@webkit.org>
1629
1630         Unreviewed, rolling out r195911.
1631         https://bugs.webkit.org/show_bug.cgi?id=153723
1632
1633         Caused frequent assertion failures on bots (Requested by ap on
1634         #webkit).
1635
1636         Reverted changeset:
1637
1638         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
1639         https://bugs.webkit.org/show_bug.cgi?id=153639
1640         http://trac.webkit.org/changeset/195911
1641
1642 2016-01-30  Darin Adler  <darin@apple.com>
1643
1644         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
1645         https://bugs.webkit.org/show_bug.cgi?id=153639
1646
1647         Reviewed by Filip Pizlo.
1648
1649         * Scripts/do-webcore-rename: Use script to do this rename.
1650
1651 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1652
1653         TouchList should be retargeted
1654         https://bugs.webkit.org/show_bug.cgi?id=149592
1655
1656         Reviewed by Antti Koivisto.
1657
1658         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
1659         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
1660
1661         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1662         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1663         (WTR::UIScriptController::touchDownAtPoint): Added.
1664         (WTR::UIScriptController::liftUpAtPoint): Added.
1665         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1666         * WebKitTestRunner/ios/HIDEventGenerator.h:
1667         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1668         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
1669         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
1670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1671         (WTR::UIScriptController::touchDownAtPoint): Added.
1672         (WTR::UIScriptController::liftUpAtPoint): Added.
1673
1674 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1675
1676         Enable SamplingProfiler on POSIX environment
1677         https://bugs.webkit.org/show_bug.cgi?id=153584
1678
1679         Reviewed by Michael Saboff.
1680
1681         * Scripts/run-jsc-stress-tests:
1682
1683 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
1684
1685         update-webkit-dependency fails to fetch updates through firewall on Windows
1686         https://bugs.webkit.org/show_bug.cgi?id=153619
1687
1688         Reviewed by Myles C. Maxfield.
1689
1690         On Windows, when a firewall is present we need to read proxy settings
1691         from environment variables.
1692
1693         This patch relies on the following environment variables being set:
1694         HTTP_PROXY
1695         HTTPS_PROXY
1696
1697         * Scripts/update-webkit-dependency:
1698
1699 2016-01-28  Dan Bernstein  <mitz@apple.com>
1700
1701         [Cocoa] Use the non-Development variants of XPC services for development
1702         https://bugs.webkit.org/show_bug.cgi?id=152545
1703
1704         Reviewed by Darin Adler.
1705
1706         * Scripts/webkitdirs.pm:
1707         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
1708
1709         * Scripts/webkitpy/port/driver.py:
1710         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
1711           set in the XPC services as well.
1712
1713         * Scripts/webkitpy/port/ios.py:
1714         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
1715           Guard Malloc are enabled in XPC services as well.
1716
1717         * Scripts/webkitpy/port/mac.py:
1718         (MacPort.setup_environ_for_server): Ditto.
1719
1720 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1721
1722         Unreviewed buildfix after r195743.
1723
1724         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1725         (WTR::AccessibilityUIElement::isPressActionSupported):
1726
1727 2016-01-12  Jer Noble  <jer.noble@apple.com>
1728
1729         Custom protocol loading through AVFoundation does not support byte-range requests.
1730         https://bugs.webkit.org/show_bug.cgi?id=152919
1731         <rdar://problem/23664657>
1732
1733         Reviewed by Alex Christensen.
1734
1735         Add tests for new ParsedContntRange class.
1736
1737         * TestWebKitAPI/PlatformWin.cmake:
1738         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1739         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1741         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
1742         (TestWebKitAPI::TEST):
1743
1744 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1745
1746         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
1747         https://bugs.webkit.org/show_bug.cgi?id=153594
1748
1749         Reviewed by Alex Christensen.
1750
1751         * Scripts/webkitdirs.pm:
1752         (determineNumberOfCPUs):
1753         (jscPath):
1754         (checkFrameworks):
1755         (setupCygwinEnv):
1756         (wrapperPrefixIfNeeded):
1757         (cmakeGeneratedBuildfile):
1758         (generateBuildSystemFromCMakeProject):
1759         * Scripts/webkitperl/features.pm:
1760         (libraryContainsSymbol):
1761
1762 2016-01-28  Chris Dumez  <cdumez@apple.com>
1763
1764         Unreviewed, rolling out r195742.
1765
1766         Broke EWS
1767
1768         Reverted changeset:
1769
1770         "[webkitdirs] Clarify logic behind is{PortName} functions."
1771         https://bugs.webkit.org/show_bug.cgi?id=153554
1772         http://trac.webkit.org/changeset/195742
1773
1774 2016-01-28  Darin Adler  <darin@apple.com>
1775
1776         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
1777         https://bugs.webkit.org/show_bug.cgi?id=153411
1778
1779         Reviewed by Ryosuke Niwa.
1780
1781         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
1782         have removed the function instead.
1783
1784         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1785         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
1786         added overloads for const char*.
1787
1788         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1789         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
1790         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1791         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1792         (WTR::testPathFromURL): Ditto.
1793
1794 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1795
1796         [webkitdirs] Clarify logic behind is{PortName} functions.
1797         https://bugs.webkit.org/show_bug.cgi?id=153554
1798
1799         Reviewed by Darin Adler.
1800
1801         * Scripts/webkitdirs.pm:
1802         (determinePortName): Added new function which decides which port are
1803         we building based on command line switches and platform defaults.
1804         (portName): Added getter for determined $portName.
1805         (isEfl): Modified to use portName().
1806         (isGtk): Ditto.
1807         (isWinCairo): Ditto.
1808         (isAppleMacWebKit): Ditto.
1809         (isAppleWinWebKit): Ditto.
1810         (isIOSWebKit): Ditto.
1811         (cmakeBasedPortName): Code replaced with portName() call.
1812         (determineIsEfl): Deleted.
1813         (determineIsGtk): Deleted.
1814         (determineIsWinCairo): Deleted.
1815
1816 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
1817
1818         [webkitdirs] Don't pass cmakeBasedPortName around.
1819         https://bugs.webkit.org/show_bug.cgi?id=153589
1820
1821         Reviewed by Darin Adler.
1822
1823         It should be local function of webkitdirs.pm instead.
1824
1825         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
1826         buildCMakeProjectOrExit().
1827         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
1828         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
1829         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
1830         generateBuildSystemFromCMakeProject().
1831         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
1832         (generateBuildSystemFromCMakeProject): Removed $port argument as we
1833         can get it from cmakeBasedPortName().
1834         (buildCMakeProjectOrExit): Ditto.
1835
1836 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
1837
1838         [GStreamer] Clean up includes and headers related with GStreamerGL
1839         https://bugs.webkit.org/show_bug.cgi?id=153590
1840
1841         Reviewed by Philippe Normand.
1842
1843         * Scripts/webkitpy/style/checker.py: Skips
1844         include_order check for MediaPlayerPrivateGStreamerBase.cpp
1845         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
1846
1847 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
1848
1849         [EFL] Remove unused accessibility related code
1850         https://bugs.webkit.org/show_bug.cgi?id=153543
1851
1852         Reviewed by Darin Adler.
1853
1854         Removed reference to EAIL library.
1855         It not going to be support anymore. There have been changes in
1856         EFL/Elementary in terms of the accessibility and we should
1857         follow those.
1858
1859         * efl/jhbuild-optional.modules:
1860
1861 2016-01-27  Daniel Bates  <dabates@apple.com>
1862
1863         Remove WebKitSystemInterface for iOS SDK < 9
1864         https://bugs.webkit.org/show_bug.cgi?id=153570
1865
1866         Reviewed by Andy Estes.
1867
1868         * Scripts/copy-webkitlibraries-to-product-directory:
1869
1870 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1871
1872         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
1873         https://bugs.webkit.org/show_bug.cgi?id=153330
1874
1875         Reviewed by Daniel Bates.
1876
1877         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1878         "branchName" implies that the variable or property in question is simply a string. We fixed some
1879         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
1880         spotted in BuildbotQueueView.js.
1881
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1883         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
1884         Changed branchName to branch.name in call to commitsOnBranch.
1885         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
1886         _popoverLinesForCommitRange.
1887         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
1888         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
1890         fix.
1891
1892 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
1893
1894         Add API to access closed shadowRoot in InjectedBundle
1895         https://bugs.webkit.org/show_bug.cgi?id=153533
1896
1897         Reviewed by Antti Koivisto.
1898
1899         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
1900
1901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1902         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
1903         (TestWebKitAPI::runJavaScriptAlert):
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
1906         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
1907         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
1908
1909 2016-01-27  Jason Marcell  <jmarcell@apple.com>
1910
1911         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
1912         https://bugs.webkit.org/show_bug.cgi?id=153332
1913
1914         Reviewed by Alexey Proskuryakov.
1915
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1917         (Trac.prototype._xmlTimelineURL): Uses new function.
1918         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
1919         logic for parsing git hashes.
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
1921         Trac._parseRevisionFromURL.
1922
1923 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1924
1925         Remove Mavericks from the flakiness dashboard
1926         https://bugs.webkit.org/show_bug.cgi?id=153521
1927
1928         Reviewed by Dan Bernstein.
1929
1930         * TestResultServer/static-dashboards/builders.jsonp:
1931         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1932
1933 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
1934
1935         Remove ENABLE_CURRENTSRC
1936         https://bugs.webkit.org/show_bug.cgi?id=153545
1937
1938         Reviewed by Simon Fraser.
1939
1940         * Scripts/webkitperl/FeatureList.pm:
1941
1942 2016-01-26  Jason Marcell  <jmarcell@apple.com>
1943
1944         Sort incoming commits via date instead of revision number.
1945         https://bugs.webkit.org/show_bug.cgi?id=153467
1946
1947         Reviewed by Alexey Proskuryakov.
1948
1949         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
1950         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1953         (Trac.prototype._loaded): Sort via date instead of revision number.
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1955         (MockTrac): Fix up the mock data to look more like real-world data.
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
1957         Fake RSS feed that adds three more commits.
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
1959         Trac._loaded().
1960
1961 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
1962
1963         Add a test for WebKit::stringMatchesWildcardString.
1964         https://bugs.webkit.org/show_bug.cgi?id=153090
1965
1966         Reviewed by Darin Adler.
1967
1968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1969         Add the file to the project.
1970
1971         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
1972         (TestWebKitAPI::TEST):
1973         Test that a string matches another string that may contain wildcard characters.
1974
1975 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1976
1977         [webkitdirs] Removed check for bison, gperf, and flex.
1978         https://bugs.webkit.org/show_bug.cgi?id=153496
1979
1980         Reviewed by Alex Christensen.
1981
1982         This prerequisites are checked in WebKitCommon.cmake and don't
1983         have to be in $PATH.
1984
1985         * Scripts/webkitdirs.pm:
1986         (checkRequiredSystemConfig):
1987
1988 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
1989
1990         [webkitdirs] isCMakeBuild should be true by default
1991         https://bugs.webkit.org/show_bug.cgi?id=153497
1992
1993         Reviewed by Michael Catanzaro.
1994
1995         * Scripts/webkitdirs.pm:
1996         (isCMakeBuild):
1997
1998 2016-01-26  Daniel Bates  <dabates@apple.com>
1999
2000         Add WebKitSystemInterface for iOS 9.2
2001         https://bugs.webkit.org/show_bug.cgi?id=153355
2002
2003         Rubber-stamped by David Kilzer.
2004
2005         * Scripts/copy-webkitlibraries-to-product-directory:
2006
2007 2016-01-26  Daniel Bates  <dabates@apple.com>
2008
2009         WebKitTestRunner: Credential cache is not cleared between tests
2010         https://bugs.webkit.org/show_bug.cgi?id=153407
2011         <rdar://problem/24280834>
2012
2013         Reviewed by Alexey Proskuryakov.
2014
2015         * WebKitTestRunner/TestController.cpp:
2016         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
2017         to clear cached credentials.
2018
2019 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2020
2021         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
2022         https://bugs.webkit.org/show_bug.cgi?id=153483
2023
2024         Reviewed by Csaba Osztrogonác.
2025
2026         * BuildSlaveSupport/kill-old-processes:
2027         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
2028
2029 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
2030
2031         Give the layout test results file a <title> showing the date and time the tests were run
2032         https://bugs.webkit.org/show_bug.cgi?id=153187
2033
2034         Reviewed by Darin Adler.
2035         
2036         Include a 'date' property in the JSON with the date and time the tests completed.
2037
2038         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2039         (summarize_results):
2040
2041 2016-01-25  Commit Queue  <commit-queue@webkit.org>
2042
2043         Unreviewed, rolling out r195543.
2044         https://bugs.webkit.org/show_bug.cgi?id=153451
2045
2046         regressed performance of test bots by ~6% (Requested by dydz
2047         on #webkit).
2048
2049         Reverted changeset:
2050
2051         "WebKitTestRunner: Credential cache is not cleared between
2052         tests"
2053         https://bugs.webkit.org/show_bug.cgi?id=153407
2054         http://trac.webkit.org/changeset/195543
2055
2056 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
2057
2058         Failing to upload to flakiness dashboard should not be a hard error
2059         https://bugs.webkit.org/show_bug.cgi?id=153444
2060         <rdar://problem/22146294>
2061
2062         Reviewed by Alexey Proskuryakov.
2063
2064         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2065         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
2066
2067 2016-01-25  Daniel Bates  <dabates@apple.com>
2068
2069         WebKitTestRunner: Credential cache is not cleared between tests
2070         https://bugs.webkit.org/show_bug.cgi?id=153407
2071         <rdar://problem/24280834>
2072
2073         Reviewed by Brady Eidson.
2074
2075         * WebKitTestRunner/TestController.cpp:
2076         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
2077         to clear cached credentials.
2078
2079 2016-01-24  Dan Bernstein  <mitz@apple.com>
2080
2081         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
2082
2083         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
2084
2085 2016-01-22  Enrica Casucci  <enrica@apple.com>
2086
2087         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
2088
2089         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2090         (WTR::TestController::platformCreateWebView):
2091
2092 2016-01-22  Tim Horton  <timothy_horton@apple.com>
2093
2094         Add a test for iOS arrow-key repeat
2095         https://bugs.webkit.org/show_bug.cgi?id=152857
2096         <rdar://problem/24017380>
2097
2098         Reviewed by Darin Adler.
2099
2100         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2101         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2102         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
2103         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
2104         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2105         * WebKitTestRunner/ios/HIDEventGenerator.h:
2106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2107         (-[HIDEventGenerator keyPress:completionBlock:]):
2108         (-[HIDEventGenerator keyDown:completionBlock:]):
2109         (-[HIDEventGenerator keyUp:completionBlock:]):
2110         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2111         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2112         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
2113         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
2114         Make it possible to independently send keyUp/keyDown, instead of just paired.
2115
2116 2016-01-22  Tim Horton  <timothy_horton@apple.com>
2117
2118         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
2119         https://bugs.webkit.org/show_bug.cgi?id=153193
2120         <rdar://problem/24222034>
2121
2122         Reviewed by Darin Adler.
2123
2124         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2125         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
2126         (TEST):
2127         Add a test that exhibits the problems we're fixing here.
2128         Before, it would both log and assert in debug, and crash in release.
2129         Now it runs happily to completion.
2130
2131 2016-01-22  Enrica Casucci  <enrica@apple.com>
2132
2133         Add support for testing data detection.
2134         https://bugs.webkit.org/show_bug.cgi?id=153360
2135
2136         Reviewed by Tim Horton.
2137
2138         Adding a new testing option (useDataDetection) to turn on
2139         data detection when running the a test.
2140
2141         * WebKitTestRunner/TestController.cpp:
2142         (WTR::updateTestOptionsFromTestHeader):
2143         * WebKitTestRunner/TestOptions.h:
2144         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2145         (WTR::TestController::platformCreateWebView):
2146
2147 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
2148
2149         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
2150         https://bugs.webkit.org/show_bug.cgi?id=153334
2151
2152         Reviewed by Zalan Bujtas.
2153         
2154         Evaluating expressions in the LayoutUnit summary provider seems to cause
2155         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
2156         denominator to 64.
2157
2158         * lldb/lldb_webkit.py:
2159         (WebCoreLayoutUnitProvider.to_string):
2160
2161 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
2162
2163         display-profiler-output should be able to display code blocks sorted by machine counts
2164         https://bugs.webkit.org/show_bug.cgi?id=153298
2165
2166         Reviewed by Oliver Hunt.
2167
2168         * Scripts/display-profiler-output:
2169
2170 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
2171
2172         Ensure to use compatible liborc version with wanted gstreamer version
2173         https://bugs.webkit.org/show_bug.cgi?id=153276
2174
2175         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
2176         The user may have a very recent liborc installed on his system.
2177
2178         Reviewed by Philippe Normand.
2179
2180         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
2181         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
2182
2183 2016-01-21  Nan Wang  <n_wang@apple.com>
2184
2185         AX: [IOS] Implement next/previous text marker functions using TextIterator
2186         https://bugs.webkit.org/show_bug.cgi?id=153292
2187         <rdar://problem/24268243>
2188
2189         Reviewed by Chris Fleizach.
2190
2191         Made text marker tests available on iOS.
2192
2193         * DumpRenderTree/AccessibilityTextMarker.h:
2194         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2195         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
2196         (AccessibilityTextMarker::AccessibilityTextMarker):
2197         (AccessibilityTextMarker::~AccessibilityTextMarker):
2198         (AccessibilityTextMarker::isEqual):
2199         (AccessibilityTextMarker::platformTextMarker):
2200         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2201         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2202         (AccessibilityTextMarkerRange::isEqual):
2203         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2204         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2205         (AccessibilityUIElement::pathDescription):
2206         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2207         (AccessibilityUIElement::textMarkerRangeForElement):
2208         (AccessibilityUIElement::selectedTextMarkerRange):
2209         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2210         (AccessibilityUIElement::textMarkerRangeLength):
2211         (AccessibilityUIElement::textMarkerRangeForMarkers):
2212         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2213         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2214         (AccessibilityUIElement::accessibilityElementForTextMarker):
2215         (AccessibilityUIElement::endTextMarkerForBounds):
2216         (AccessibilityUIElement::startTextMarkerForBounds):
2217         (AccessibilityUIElement::textMarkerForPoint):
2218         (AccessibilityUIElement::previousTextMarker):
2219         (AccessibilityUIElement::nextTextMarker):
2220         (AccessibilityUIElement::stringForTextMarkerRange):
2221         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2222         (AccessibilityUIElement::indexForTextMarker):
2223         (AccessibilityUIElement::isTextMarkerValid):
2224         (AccessibilityUIElement::textMarkerForIndex):
2225         (AccessibilityUIElement::startTextMarker):
2226         (AccessibilityUIElement::endTextMarker):
2227         (AccessibilityUIElement::setSelectedVisibleTextRange):
2228         (AccessibilityUIElement::getLinkedUIElements):
2229         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2230         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2231         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2232         (AccessibilityUIElement::removeSelection):
2233         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2234         (AccessibilityUIElement::setSelectedVisibleTextRange):
2235         (AccessibilityUIElement::supportedActions):
2236         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2237         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2238         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2239         (WTR::AccessibilityUIElement::previousTextMarker):
2240         (WTR::AccessibilityUIElement::nextTextMarker):
2241         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2242         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2243         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2244         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2245         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2246         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2247         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2248
2249 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
2250
2251         Unreviewed, revert accidental unreviewed commit.
2252
2253         * Scripts/display-profiler-output:
2254
2255 2016-01-20  Jason Marcell  <jmarcell@apple.com>
2256
2257         Refactor compareIterations to remove duplicate code.
2258         https://bugs.webkit.org/show_bug.cgi?id=152913
2259
2260         Reviewed by Daniel Bates.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2263         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
2264         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
2266         the same behavior before and after refactor.
2267
2268 2016-01-20  Dana Burkart  <dburkart@apple.com>
2269
2270         Botwatcher's dashboard should show an 'X' when the build is broken
2271         https://bugs.webkit.org/show_bug.cgi?id=152507
2272
2273         Reviewed by David Kilzer.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2276         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
2277         (BuildbotStaticAnalyzerQueueView.prototype.update):
2278
2279 2016-01-19  Jason Marcell  <jmarcell@apple.com>
2280
2281         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
2282         https://bugs.webkit.org/show_bug.cgi?id=153262
2283
2284         Reviewed by Alexey Proskuryakov.
2285
2286         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
2287         such cases this revisionContentForIteration method does not have any content to return, thus the
2288         assertion fails.
2289
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2291         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
2292
2293 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         [GTK] Runtime critical warnings when loading a URL after a session restore
2296         https://bugs.webkit.org/show_bug.cgi?id=153233
2297
2298         Reviewed by Michael Catanzaro.
2299
2300         Add new test case.
2301
2302         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2303         (viewLoadChanged):
2304         (testWebKitWebViewNavigationAfterSessionRestore):
2305         (beforeAll):
2306
2307 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2308
2309         [GTK] Remove jhbuild-optional.modules
2310         https://bugs.webkit.org/show_bug.cgi?id=152964
2311
2312         Reviewed by Alex Christensen.
2313
2314         * gtk/jhbuild-optional.modules: Removed.
2315         * gtk/jhbuild.modules:
2316
2317 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2318
2319         [GTK] Add support to load/save session in MiniBrowser
2320         https://bugs.webkit.org/show_bug.cgi?id=153201
2321
2322         Reviewed by Michael Catanzaro.
2323
2324         It makes it easier to test the new WebView session API.
2325
2326         * MiniBrowser/gtk/BrowserWindow.c:
2327         (browserWindowFinalize): Free the session file path.
2328         (browserWindowSaveSession): Save the current WebView session if
2329         there's a session file path.
2330         (browserWindowDeleteEvent): Call browserWindowSaveSession().
2331         (browser_window_load_session): Try to load the session from the
2332         given file path, otherwise fall back to homepage and keep the
2333         session file to save the session on window close.
2334         * MiniBrowser/gtk/BrowserWindow.h:
2335         * MiniBrowser/gtk/main.c:
2336         (createBrowserWindow): Pass the given session file path when
2337         shouldLoadSession is TRUE.
2338         (main): Only allow to restore/save session when MiniBrowser is
2339         launched without URL arguments.
2340
2341 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2342
2343         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
2344
2345         Geolocation is no longer allowed for unique origins after r195075.
2346
2347         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2348         (testWebViewGeolocationPermissionRequests):
2349
2350 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2351
2352         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
2353         https://bugs.webkit.org/show_bug.cgi?id=153216
2354
2355         Reviewed by Michael Catanzaro.
2356
2357         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
2358         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
2359
2360 2016-01-18  Nan Wang  <n_wang@apple.com>
2361
2362         AX: [Mac] Implement next/previous text marker functions using TextIterator
2363         https://bugs.webkit.org/show_bug.cgi?id=152728
2364
2365         Reviewed by Chris Fleizach.
2366
2367         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2368         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2369
2370 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
2371
2372         [cmake] Add testair to the build system
2373         https://bugs.webkit.org/show_bug.cgi?id=153126
2374
2375         Reviewed by Michael Catanzaro.
2376
2377         * Scripts/build-jsc:
2378
2379 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2380
2381         Remove TextRun::allowsRoundingHacks()
2382         https://bugs.webkit.org/show_bug.cgi?id=153185
2383
2384         Reviewed by Simon Fraser.
2385
2386         * DumpRenderTree/mac/DumpRenderTree.mm:
2387         (resetWebViewToConsistentStateBeforeTesting): Deleted.
2388
2389 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
2390
2391         [webkitdirs] Avoid list form of open because it broke WinCairo
2392         https://bugs.webkit.org/show_bug.cgi?id=153106
2393
2394         Reviewed by Alex Christensen.
2395
2396         * Scripts/webkitdirs.pm:
2397         (determineArchitecture):
2398
2399 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
2400
2401         Add kdebug_trace signposts for a few WebCore operations
2402         https://bugs.webkit.org/show_bug.cgi?id=153136
2403         rdar://problem/24208487
2404
2405         Reviewed by Sam Weinig.
2406         
2407         Plist used by kdebug_trace() viewing tools.
2408
2409         * Tracing/SystemTracePoints.plist: Added.
2410
2411 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
2412
2413         [webkitdirs] Replaced grep invocation with perl code
2414         https://bugs.webkit.org/show_bug.cgi?id=153106
2415
2416         Reviewed by Alex Christensen.
2417
2418         * Scripts/webkitdirs.pm:
2419         (determineArchitecture):
2420
2421 2016-01-14  Brian Burg  <bburg@apple.com>
2422
2423         prepare-changelog does not read paths containing spaces properly
2424         https://bugs.webkit.org/show_bug.cgi?id=137982
2425
2426         Reviewed by Joseph Pecoraro.
2427
2428         Escape whitespace in filenames before passing the file path to other functions.
2429
2430         * Scripts/prepare-ChangeLog:
2431         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
2432
2433 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2434
2435         Standardize the usage of "branch" vs. "branchName".
2436         https://bugs.webkit.org/show_bug.cgi?id=152982
2437
2438         Reviewed by Daniel Bates.
2439
2440         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
2441         "branchName" implies that the variable or property in question is simply a string.
2442
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2444         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
2445         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
2446         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2448         (Trac.prototype.commitsOnBranch): Change branch to branchName.
2449         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2451         (MockTrac): Ditto.
2452
2453 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2454
2455         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
2456         https://bugs.webkit.org/show_bug.cgi?id=152910
2457
2458         Reviewed by Daniel Bates.
2459
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
2461         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
2463         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
2464         the need to talk to a real Buildbot server.
2465         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
2466         without the need to talk to a real Buildbot server.
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
2468         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
2469         server.
2470         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
2471         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
2472         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
2473         trying to talk to Trac.
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
2475         QUnit unit tests.
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
2477
2478 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2479
2480         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
2481         https://bugs.webkit.org/show_bug.cgi?id=132599
2482
2483         Reviewed by Michael Catanzaro.
2484
2485         Check if cmake Ninja generators are installed.
2486
2487         * Scripts/webkitdirs.pm:
2488         (canUseNinjaGenerator):
2489         (canUseEclipseNinjaGenerator):
2490         (generateBuildSystemFromCMakeProject):
2491         (canUseEclipse): Deleted.
2492
2493 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
2494
2495         [Cocoa] Testing with font family name "System Font" is unused
2496         https://bugs.webkit.org/show_bug.cgi?id=153073
2497         <rdar://problem/24091683>
2498
2499         Reviewed by Brent Fulgham.
2500
2501         * DumpRenderTree/mac/DumpRenderTree.mm:
2502         (allowedFontFamilySet): Deleted.
2503         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2504         (WTR::allowedFontFamilySet): Deleted.
2505         * WebKitTestRunner/mac/TestControllerMac.mm:
2506         (WTR::allowedFontFamilySet): Deleted.
2507
2508 2016-01-13  Daniel Bates  <dabates@apple.com>
2509
2510         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
2511         https://bugs.webkit.org/show_bug.cgi?id=152871
2512
2513         Reviewed by Brent Fulgham.
2514
2515         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
2516         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
2517
2518         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
2519
2520 2016-01-08  Andy Estes  <aestes@apple.com>
2521
2522         [Content Filtering] Lazily load platform frameworks
2523         https://bugs.webkit.org/show_bug.cgi?id=152881
2524         rdar://problem/23270886
2525
2526         Reviewed by Brady Eidson.
2527
2528         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
2529         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
2530         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
2531         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
2532         is loaded after an HTTPS request.
2533
2534         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
2535         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
2536         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
2537         also re-enabled on iOS after mistakenly being disabled by r188892.
2538
2539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2540         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2541         (TestWebKitAPI::TEST):
2542         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
2543         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
2544         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2545         (TEST):
2546         (downloadTest):
2547         (-[LazilyLoadPlatformFrameworksController init]):
2548         (-[LazilyLoadPlatformFrameworksController webView]):
2549         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2550         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
2551         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2552         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2553         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
2554         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
2555         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2556         (TestWebKitAPI::TEST):
2557         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2558         (TestWebKitAPI::TEST): Deleted.
2559         * TestWebKitAPI/cocoa/TestProtocol.h:
2560         * TestWebKitAPI/cocoa/TestProtocol.mm:
2561         (+[TestProtocol registerWithScheme:]):
2562         (+[TestProtocol unregister]):
2563
2564 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
2565
2566         Fix the Sunpider converage in slow device.
2567         https://bugs.webkit.org/show_bug.cgi?id=152938
2568         <rdar://problem/22511411>
2569
2570         Reviewed by Ryosuke Niwa.
2571
2572         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
2573
2574         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
2575
2576 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2577
2578         Add a build flag for custom element
2579         https://bugs.webkit.org/show_bug.cgi?id=153005
2580
2581         Reviewed by Alex Christensen.
2582
2583         Added --custom-elements option to enable custom elements support.
2584
2585         * Scripts/webkitperl/FeatureList.pm:
2586
2587 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
2588
2589         [JSC] Add a help message when run-jsc-stress-tests fails
2590         https://bugs.webkit.org/show_bug.cgi?id=153014
2591
2592         Reviewed by Csaba Osztrogonác.
2593
2594         * Scripts/run-jsc-stress-tests:
2595
2596 2016-01-11  Saam barati  <sbarati@apple.com>
2597
2598         run-jsc-stress-tests should try to figure out a JSC path
2599         https://bugs.webkit.org/show_bug.cgi?id=152971
2600
2601         Reviewed by Yusuke Suzuki.
2602
2603         This patch now allows run-jsc-stress-tests to be run
2604         without a "--jsc <jsc-path>" argument. It tries
2605         to take its best guess at a <jsc-path> automagically.
2606         
2607         This makes it much easier to just run run-jsc-stress-tests
2608         with a directory or a yaml file as an argument.
2609         You now just do this:
2610         `run-jsc-stress-tests <path-to-yaml>`
2611         or
2612         `run-jsc-stress-tests <path-to-directory-of-js-files>`
2613         
2614         I wrote this patch because I'd often find myself hacking the 
2615         run-javascriptcore-tests file just to run a particular subset of tests.
2616         Because I always forget the arguments to run-jsc-stress-tests (which means
2617         I always forgot to provide a --jsc argument), I always found it easier to 
2618         just hack on that file instead of calling run-jsc-stress-tests directly.
2619         No longer is this true!
2620
2621         * Scripts/run-jsc-stress-tests:
2622
2623 2016-01-09  Andy Estes  <aestes@apple.com>
2624
2625         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
2626         https://bugs.webkit.org/show_bug.cgi?id=152950
2627         rdar://problem/24066652
2628
2629         Reviewed by Tim Horton.
2630
2631         Added an API test.
2632
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
2635         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
2636         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
2637         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
2638         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
2639         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
2640         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
2641         (TEST):
2642
2643 2016-01-11  Commit Queue  <commit-queue@webkit.org>
2644
2645         Unreviewed, rolling out r194866.
2646         https://bugs.webkit.org/show_bug.cgi?id=152986
2647
2648         This change broke the mac build (Requested by ryanhaddad on
2649         #webkit).
2650
2651         Reverted changeset:
2652
2653         "[Cocoa] Add SPI to opt out a URL scheme from the memory
2654         cache"
2655         https://bugs.webkit.org/show_bug.cgi?id=152950
2656         http://trac.webkit.org/changeset/194866
2657
2658 2016-01-11  Andy Estes  <aestes@apple.com>
2659
2660         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
2661         https://bugs.webkit.org/show_bug.cgi?id=152950
2662         rdar://problem/24066652
2663
2664         Reviewed by Tim Horton.
2665
2666         Added an API test.
2667
2668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2669         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
2670         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
2671         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
2672         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
2673         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
2674         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
2675         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
2676         (TEST):
2677
2678 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
2679
2680         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
2681         https://bugs.webkit.org/show_bug.cgi?id=152959
2682
2683         Reviewed by Brent Fulgham.
2684
2685         * Scripts/webkitdirs.pm:
2686         (determineArchitecture):
2687
2688 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2689
2690         [GTK] W3C CSS2.1 anonymous table tests are failing
2691         https://bugs.webkit.org/show_bug.cgi?id=152455
2692
2693         Reviewed by Mario Sanchez Prada.
2694
2695         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
2696         tests. Add upstream patches to fix detection of XHTML files.
2697
2698         * gtk/jhbuild.modules:
2699         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
2700         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
2701
2702 2016-01-10  Saam barati  <sbarati@apple.com>
2703
2704         Implement a sampling profiler
2705         https://bugs.webkit.org/show_bug.cgi?id=151713
2706
2707         Reviewed by Filip Pizlo.
2708
2709         * Scripts/run-jsc-stress-tests:
2710
2711 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
2712
2713         [webkitdirs] Try arch and uname commands on non-windows OS
2714         https://bugs.webkit.org/show_bug.cgi?id=152958
2715
2716         Reviewed by Michael Catanzaro.
2717
2718         Right now, determineArchitecture()  uses `arch` and `uname -m`
2719         commands to determine architecture in case of condition (isGtk() ||
2720         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
2721         instead, because this code is applicable to any non-windows OS WebKit
2722         supports (even Haiku which once was supported is moderately
2723         POSIX-compliant and has uname command).
2724
2725         * Scripts/webkitdirs.pm:
2726         (determineArchitecture):
2727
2728 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
2729
2730         run-webkit-tests mis-counts totals when there are other crashes
2731         https://bugs.webkit.org/show_bug.cgi?id=152894
2732         <rdar://problem/24098697>
2733
2734         Reviewed by Alexey Proskuryakov.
2735
2736         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2737         (TestRunResults.add): Do not update result counters for other crashes.
2738
2739 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2740
2741         webkit-patch build-and-test should have an option to iterate over new tests
2742         https://bugs.webkit.org/show_bug.cgi?id=143093
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
2747         It allows running run-webkit-tests on modified or new paths in LayoutTests.
2748         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
2749         It implements the translation of -expected.* paths to their related tests.
2750         It also implements the removal of skipped tests.
2751
2752         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2753         (LayoutTestFinder.find_touched_tests):
2754         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
2755         (MockPort):
2756         (MockPort.__init__):
2757         (MockPort.tests):
2758         (LayoutTestFinderTests):
2759         (LayoutTestFinderTests.touched_files):
2760         (LayoutTestFinderTests.test_touched_test):
2761         (LayoutTestFinderTests.test_expected_touched_test):
2762         (LayoutTestFinderTests.test_platform_expected_touched_test):
2763         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
2764         (LayoutTestFinderTests.test_touched_but_skipped_test):
2765         * Scripts/webkitpy/port/base.py:
2766         (Port.potential_test_names_from_expected_file):
2767         * Scripts/webkitpy/tool/commands/download_unittest.py:
2768         (DownloadCommandsTest._default_options):
2769         * Scripts/webkitpy/tool/steps/options.py:
2770         (Options):
2771         * Scripts/webkitpy/tool/steps/runtests.py:
2772         (RunTests.options):
2773         (RunTests.run):
2774         (RunTests):
2775         (RunTests._new_or_modified_tests):
2776         (RunTests._run_webkit_tests):
2777         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2778         (RunTestsTest.test_webkit_run_unit_tests):
2779         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2780         (StepsTest._step_options):
2781
2782 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
2783
2784         prepare-ChangeLog should include radar number
2785         https://bugs.webkit.org/show_bug.cgi?id=152839
2786         <rdar://problem/24093563>
2787
2788         Reviewed by Daniel Bates.
2789
2790         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
2791         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
2792         in the ChangeLog description after the bug URL.
2793
2794         * Scripts/prepare-ChangeLog:
2795         (main): Update signatures.
2796         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
2797         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
2798         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
2799         (generateNewChangeLogs): Include radar URL if we found one.
2800
2801         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
2802         Tests for the radar URL extraction.
2803
2804 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
2805
2806         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
2807         https://bugs.webkit.org/show_bug.cgi?id=152390
2808         <rdar://problem/23948321>
2809
2810         Reviewed by Simon Fraser.
2811
2812         Fix two use-after-frees.
2813
2814         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
2815         but we may have already progressed to another test by the time the callback fires,
2816         having destroyed the TestInvocation.
2817         2. UIScriptController is a RefCounted object, but it has a raw pointer to
2818         UIScriptContext which has the same lifetime as a TestInvocation.
2819         As a result, completion blocks of UIScriptController actions would use a destroyed
2820         TestInvocation.
2821
2822         * WebKitTestRunner/TestInvocation.cpp:
2823         (WTR::TestInvocation::~TestInvocation):
2824         (WTR::TestInvocation::url):
2825         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2826         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2827         (WTR::TestInvocation::runUISideScript):
2828         * WebKitTestRunner/TestInvocation.h:
2829         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2830         (UIScriptContext::UIScriptContext):
2831         (UIScriptContext::~UIScriptContext):
2832         (UIScriptContext::runUIScript):
2833         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2834         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2835         (WTR::UIScriptController::UIScriptController):
2836         (WTR::UIScriptController::contextDestroyed):
2837         (WTR::UIScriptController::makeWindowObject):
2838         (WTR::UIScriptController::setWillBeginZoomingCallback):
2839         (WTR::UIScriptController::willBeginZoomingCallback):
2840         (WTR::UIScriptController::setDidEndZoomingCallback):
2841         (WTR::UIScriptController::didEndZoomingCallback):
2842         (WTR::UIScriptController::setDidEndScrollingCallback):
2843         (WTR::UIScriptController::didEndScrollingCallback):
2844         (WTR::UIScriptController::setDidShowKeyboardCallback):
2845         (WTR::UIScriptController::didShowKeyboardCallback):
2846         (WTR::UIScriptController::setDidHideKeyboardCallback):
2847         (WTR::UIScriptController::didHideKeyboardCallback):
2848         (WTR::UIScriptController::uiScriptComplete):
2849         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2850         (WTR::UIScriptController::create):
2851         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2852         (WTR::UIScriptController::doAsyncTask):
2853         (WTR::UIScriptController::zoomToScale):
2854         (WTR::UIScriptController::singleTapAtPoint):
2855         (WTR::UIScriptController::doubleTapAtPoint):
2856         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2857         (WTR::UIScriptController::contentVisibleRect):
2858         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2859         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2860         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2861         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2862         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
2863         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2864         (WTR::UIScriptController::doAsyncTask):
2865
2866 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2867
2868         [buildbot] clean-build script should remove untracked files and revert local changes too
2869         https://bugs.webkit.org/show_bug.cgi?id=142400
2870
2871         Reviewed by Ryosuke Niwa.
2872
2873         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2874         A helper routine SCM.discard_untracked_files is added for that purpose.
2875
2876         * BuildSlaveSupport/clean-build:
2877         (main): Making call to Scripts/clean-webkit
2878         * Scripts/clean-webkit: Added.
2879         (main): Revert changes and delete untracked files.
2880         * Scripts/webkitpy/common/checkout/scm/scm.py:
2881         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2882         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2883         (SCMTest._shared_test_discard_untracked_files):
2884         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2885
2886 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
2887
2888         Add a setting and preferences to enable display-list drawing. Does nothing yet.
2889         https://bugs.webkit.org/show_bug.cgi?id=152807
2890
2891         Reviewed by Zalan Bujtas.
2892         
2893         Add an item to the Settings menu to toggle display-list drawing.
2894
2895         * MiniBrowser/mac/SettingsController.h:
2896         * MiniBrowser/mac/SettingsController.m:
2897         (-[SettingsController _populateMenu]):
2898         (-[SettingsController validateMenuItem:]):
2899         (-[SettingsController toggleDisplayListDrawingEnabled:]):
2900         (-[SettingsController displayListDrawingEnabled]):
2901         * MiniBrowser/mac/WK2BrowserWindowController.m:
2902         (-[WK2BrowserWindowController didChangeSettings]):
2903
2904 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2905
2906         Python SCM should be able to retrieve untracked files - Add GIT support
2907         https://bugs.webkit.org/show_bug.cgi?id=143135
2908
2909         Reviewed by Michael Catanzaro.
2910
2911         * Scripts/webkitpy/common/checkout/scm/git.py:
2912         (Git.untracked_files): Adding support for git.
2913         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2914         (GitTest.setUp):
2915         (GitTest.test_untracked_files): Adding test.
2916
2917 2016-01-05  Mark Lam  <mark.lam@apple.com>
2918
2919         Rename badly named JSC_timeout env var to JSCTEST_timeout.
2920         https://bugs.webkit.org/show_bug.cgi?id=152748
2921
2922         Reviewed by Geoffrey Garen.
2923
2924         Now that we validate JSC options, the badly named JSC_timeout env var causes the
2925         bots to have a bad time.
2926
2927         * Scripts/run-javascriptcore-tests:
2928         * Scripts/run-jsc-stress-tests:
2929
2930 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2931
2932         [GTK] Allow to save and restore session
2933         https://bugs.webkit.org/show_bug.cgi?id=115600
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         Add test case to check the new session API.
2938
2939         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2940         (testWebKitWebViewSessionState):
2941         (testWebKitWebViewSessionStateWithFormData):
2942         (beforeAll):
2943
2944 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2945
2946         [EFL] Bump EFL version to 1.16.1
2947         https://bugs.webkit.org/show_bug.cgi?id=152688
2948
2949         Reviewed by Gyuyoung Kim.
2950
2951         * efl/jhbuild.modules:
2952
2953 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
2954
2955         error running layout tests on iOS simulator on latest build
2956         https://bugs.webkit.org/show_bug.cgi?id=152719
2957         <rdar://problem/24009549>
2958
2959         Reviewed by Alexey Proskuryakov.
2960
2961         * Scripts/webkitpy/xcode/simulator.py:
2962         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
2963           before running simctl spawn command.
2964
2965 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2966
2967         Unreviewed, move Frédéric Wang to committers list
2968
2969         He seems to be on the contributors list by accident. He has been landing his own commits for
2970         about two years now.
2971
2972         * Scripts/webkitpy/common/config/contributors.json:
2973
2974 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2975
2976         Unreviewed, move Sebastian Dröge to committers list harder
2977
2978         He accidentally added himself to the reviewers list because the file is confusing. Then I
2979         accidentially moved him to the contributors list because the file is confusing, even though
2980         I knew the contributors list existed in this file and was attempting to add him to the
2981         committers list. Really move him to the committers list now.
2982
2983         * Scripts/webkitpy/common/config/contributors.json:
2984
2985 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2986
2987         Python SCM should be able to retrieve untracked files - Add SVN support
2988         https://bugs.webkit.org/show_bug.cgi?id=152546
2989
2990         Reviewed by Michael Catanzaro.
2991
2992         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2993         (test_untracked_files): Activating test for SVN.
2994         * Scripts/webkitpy/common/checkout/scm/svn.py:
2995         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
2996
2997 2015-12-31  Andy Estes  <aestes@apple.com>
2998
2999         Replace WTF::move with WTFMove
3000         https://bugs.webkit.org/show_bug.cgi?id=152601
3001
3002         Reviewed by Brady Eidson.
3003
3004         * DumpRenderTree/TestRunner.h:
3005         (TestRunner::setAllowedHosts):
3006         * DumpRenderTree/win/DRTDataObject.cpp:
3007         (DRTDataObject::SetData):
3008         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3009         (TestWebKitAPI::TEST):
3010         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3011         (TestWebKitAPI::TEST):
3012         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3013         (TestWebKitAPI::TEST):
3014         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3015         (TestWebKitAPI::TEST):
3016         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3017         (TestWebKitAPI::passWithRef):
3018         (TestWebKitAPI::TEST):
3019         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3020         (TestWebKitAPI::TEST):
3021         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3022         (TestWebKitAPI::TEST):
3023         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3024         (TestWebKitAPI::TEST):
3025         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3026         (TestWebKitAPI::TEST):
3027         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3028         (TestWebKitAPI::createTestValue):
3029         (TestWebKitAPI::TEST):
3030         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3031         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3032         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3033         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3034         (TestWebKitAPI::createNFAs):
3035         (TestWebKitAPI::TEST_F):
3036         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
3037         (TestWebKitAPI::combine):
3038         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
3039         (TestWebKitAPI::createNFAs):
3040         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
3041         (TEST):
3042         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3043         (WebProcessTest::add):
3044
3045 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
3046
3047         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
3048         https://bugs.webkit.org/show_bug.cgi?id=152634
3049
3050         Reviewed by Carlos Garcia Campos.
3051
3052         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3053         (testLoadFromGResource): Added test.
3054         (beforeAll):
3055         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3056         (registerGResource): Added.
3057         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
3058         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
3059         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
3060
3061 2015-12-31  David Kilzer  <ddkilzer@apple.com>
3062
3063         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
3064         <https://bugs.webkit.org/show_bug.cgi?id=152601>
3065
3066         Ignore unknown pragmas on older clangs.  Fixes the following
3067         build failure:
3068
3069             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
3070             #pragma clang diagnostic ignored "-Wself-move"
3071                                              ^
3072             1 error generated.
3073
3074         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3075         (TestWebKitAPI::TEST):
3076         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3077         (TestWebKitAPI::TEST):
3078
3079 2015-12-31  Andy Estes  <aestes@apple.com>
3080
3081         Update the style checker to advise using WTFMove() instead of WTF::move()
3082         https://bugs.webkit.org/show_bug.cgi?id=152601
3083
3084         Reviewed by Daniel Bates.
3085
3086         * Scripts/webkitpy/style/checkers/cpp.py:
3087         (check_wtf_move):
3088         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3089         (WebKitStyleTest.test_wtf_move):
3090
3091 2015-12-31  Andy Estes  <aestes@apple.com>
3092
3093         Fix warnings uncovered by migrating to WTF_MOVE
3094         https://bugs.webkit.org/show_bug.cgi?id=152601
3095
3096         Reviewed by Daniel Bates.
3097
3098         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
3099         self-move, even if doing so would trigger a warning.
3100
3101         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3102         (TestWebKitAPI::TEST):
3103         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3104         (TestWebKitAPI::TEST):
3105
3106 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
3107
3108         [GTK] The install-dependencies script has a syntax error
3109         https://bugs.webkit.org/show_bug.cgi?id=152613
3110
3111         Reviewed by Michael Catanzaro.
3112
3113         * gtk/install-dependencies: Add the missing 'then.'
3114
3115 2015-12-30  Philippe Normand  <pnormand@igalia.com>
3116
3117         [Mac][GTK] Jhbuild support for OSX
3118         https://bugs.webkit.org/show_bug.cgi?id=150799
3119
3120         Reviewed by Michael Catanzaro.
3121
3122         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
3123         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
3124         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
3125         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
3126
3127 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3128
3129         Unreviewed, move Sebastian Dröge to committers list
3130
3131         He accidentally added himself to the reviewers list because the file is confusing.
3132
3133         * Scripts/webkitpy/common/config/contributors.json:
3134
3135 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
3136
3137         Remove the unused #define _USE_MATH_DEFINES
3138         https://bugs.webkit.org/show_bug.cgi?id=152034
3139
3140         Reviewed by Tim Horton.
3141         
3142         Update this test to use piDouble from MathExtras.h, and
3143         std::numeric_limits<>.
3144
3145         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3146
3147 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3148
3149         Python SCM should be able to retrieve untracked files - Generic changes
3150         https://bugs.webkit.org/show_bug.cgi?id=152536
3151
3152         Reviewed by Brent Fulgham.
3153
3154         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3155         No support is yet added to GIT and SVN specific implementations.
3156
3157         * Scripts/webkitpy/common/checkout/scm/scm.py:
3158         (SCM.untracked_files):
3159         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3160         (SCMTest._shared_test_untracked_files):
3161
3162 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
3163
3164         SVN checkout used by RunBenchmark should be non-interactive
3165         https://bugs.webkit.org/show_bug.cgi?id=152542
3166
3167         Reviewed by Ryosuke Niwa.
3168
3169         RunBenchmark should not require user interaction while running.
3170
3171         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3172         (BenchmarkBuilder._checkout_with_subversion):
3173
3174 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3175
3176         Web Inspector: add support for running protocol-test.js tests on Windows
3177         https://bugs.webkit.org/show_bug.cgi?id=148037
3178         <rdar://problem/22292237>
3179
3180         Reviewed by Simon Fraser.
3181
3182         * DumpRenderTree/win/TestRunnerWin.cpp:
3183         (TestRunner::inspectorTestStubURL): Provide implementation.
3184
3185 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
3186
3187         [MediaStream] MediaDeviceInfo.label must be empty in some situations
3188         https://bugs.webkit.org/show_bug.cgi?id=152000
3189
3190         Reviewed by Brent Fulgham.
3191
3192         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3193         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3194         (WTR::InjectedBundle::setUserMediaPermission):
3195         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
3196         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3197
3198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3199         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
3200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3201
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::TestController::setUserMediaPermissionForOrigin):
3204         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
3205         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
3206           persistent permission for origin, that can be done from script now.
3207         * WebKitTestRunner/TestController.h:
3208
3209         * WebKitTestRunner/TestInvocation.cpp:
3210         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
3211           SetUserMediaPermissionForOrigin.
3212
3213 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3214
3215         [Win] Unreviewed build fix: Recognize Windows 10 variants.
3216
3217         * Scripts/webkitpy/common/system/platforminfo.py:
3218         (PlatformInfo._determine_win_version):
3219
3220 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
3221
3222         Content blockers should be able to promote http to https
3223         https://bugs.webkit.org/show_bug.cgi?id=148966
3224
3225         Reviewed by Benjamin Poulain.
3226
3227         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3228         (WebCore::ContentExtensions::operator<<):
3229         (TestWebKitAPI::TEST_F):
3230
3231 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
3232
3233         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
3234         https://bugs.webkit.org/show_bug.cgi?id=152516
3235
3236         Reviewed by Gyuyoung Kim.
3237
3238         * MiniBrowser/efl/main.c:
3239
3240 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
3241
3242         Unreviewed: Add John Wilander as a contributor.
3243
3244         * Scripts/webkitpy/common/config/contributors.json:
3245
3246 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
3247
3248         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
3249         https://bugs.webkit.org/show_bug.cgi?id=152482
3250
3251         Reviewed by Brent Fulgham.
3252
3253         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
3254         for the same property. On WK2, the element returned will not be valid, but is still present and
3255         that can lead to looping.
3256
3257         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3258         (AccessibilityUIElement::horizontalScrollbar):
3259         (AccessibilityUIElement::verticalScrollbar):
3260         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3261         (WTR::AccessibilityUIElement::horizontalScrollbar):
3262         (WTR::AccessibilityUIElement::verticalScrollbar):
3263
3264 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3265
3266         Unreviewed.
3267
3268         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
3269
3270 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
3271
3272         [EFL] test_ewk2_context failed after r192808
3273         https://bugs.webkit.org/show_bug.cgi?id=151846
3274
3275         Reviewed by Gyuyoung Kim.
3276
3277         Used the added ewk_context_web_process_count_limit_set api
3278         instead of the deprecated ewk_context_process_model_set.
3279
3280         * MiniBrowser/efl/main.c:
3281         (elm_main):
3282
3283 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3284
3285         Unreviewed, move myself to reviewer list.
3286
3287         * Scripts/webkitpy/common/config/contributors.json:
3288
3289 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
3290
3291         Unreviewed, add myself to the committers list.
3292
3293         * Scripts/webkitpy/common/config/contributors.json:
3294
3295 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3296
3297         [GTK] jquery.min.js violates DFSG
3298         https://bugs.webkit.org/show_bug.cgi?id=152428
3299
3300         Reviewed by Joseph Pecoraro.
3301
3302         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
3303         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
3304
3305         * gtk/manifest.txt.in:
3306
3307 2015-12-19  Dan Bernstein  <mitz@apple.com>
3308
3309         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
3310         https://bugs.webkit.org/show_bug.cgi?id=152462
3311
3312         Reviewed by Alexey Proskuryakov.
3313
3314         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
3315           OS X 10.9:
3316
3317         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3318         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3319         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3320         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3321         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3322
3323         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
3324           never getting compiled:
3325
3326         * DumpRenderTree/mac/TextInputController.m:
3327         * MiniBrowser/mac/BrowserWindowController.m:
3328         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3329         * WebKitTestRunner/mac/EventSenderProxy.mm:
3330
3331 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
3332
3333         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
3334
3335         This is to make it easy to CC it on Bugzilla.
3336
3337         * Scripts/webkitpy/common/config/contributors.json:
3338
3339 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
3340
3341         Pasteboard get messed up after running kill-old-processes
3342         https://bugs.webkit.org/show_bug.cgi?id=152426
3343
3344         Reviewed by Alexey Proskuryakov.
3345
3346         * BuildSlaveSupport/kill-old-processes:
3347         (main): Do not kill pasteboard anymore.
3348
3349 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
3350
3351         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
3352         https://bugs.webkit.org/show_bug.cgi?id=152157
3353         <rdar://problem/23851817>
3354
3355         Reviewed by Alexey Proskuryakov.
3356
3357         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3358         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
3359         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3360         (Manager._get_test_inputs): Common method to calculate test_inputs.
3361         (Manager._update_worker_count): Calculate and update required number of workers.
3362
3363 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
3364
3365         run-webkit-tests fails to delete Simulator device during cleanup
3366         https://bugs.webkit.org/show_bug.cgi?id=152363
3367
3368         Reviewed by Alexey Proskuryakov.
3369
3370         * Scripts/webkitpy/xcode/simulator.py:
3371         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
3372
3373 2015-12-16  Tim Horton  <timothy_horton@apple.com>
3374
3375         [mac-wk2] fast/events force click tests crashing
3376         https://bugs.webkit.org/show_bug.cgi?id=152339
3377
3378         Reviewed by Beth Dakin.
3379
3380         * WebKitTestRunner/mac/EventSenderProxy.mm:
3381         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3382         Set the NSEvent's _type member in addition to overriding -type,
3383         because there are assertions in touch event handling code that depend on it.
3384
3385 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3386
3387         Enforce temporarily bots to sync WebKit and WPT testharness.js
3388         https://bugs.webkit.org/show_bug.cgi?id=152334
3389
3390         Reviewed by Darin Adler.
3391
3392         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3393         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
3394
3395 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3396
3397         [Fetch API] Add fetch API compile time flag
3398         https://bugs.webkit.org/show_bug.cgi?id=152254
3399
3400         Reviewed by Darin Adler.
3401
3402         * Scripts/webkitperl/FeatureList.pm:
3403
3404 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3405
3406         Unreviewed.
3407
3408         Added files that have impact in building Streams API to the watchlist.
3409
3410         * Scripts/webkitpy/common/config/watchlist:
3411
3412 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3413
3414         Unreviewed.
3415
3416         Added imported tests to Streams API watchlist.
3417
3418         * Scripts/webkitpy/common/config/watchlist:
3419
3420 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3421
3422         Remove default copy of wpt testharness.js when launching wpt server
3423         https://bugs.webkit.org/show_bug.cgi?id=152298
3424
3425         Reviewed by Darin Adler.
3426
3427         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3428         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
3429
3430 2015-12-15  David Kilzer  <ddkilzer@apple.com>
3431
3432         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
3433         <http://webkit.org/b/152314>
3434
3435         Reviewed by Daniel Bates.
3436
3437         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
3438         code path to exit immediately when calling main().
3439         Unfortunately, DumpRenderTreeMain.mm was used for both
3440         DumpRenderTree command-line binary and DumpRenderTree.app, which
3441         meant that the app would exit immediately with no error code
3442         when run!
3443
3444         The workaround is to introduce a separate source file called
3445         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
3446         already does.
3447
3448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
3449         DumpRenderTreeAppMain.mm to the project.  Make it the only
3450         compiled source for the DumpRenderTree.app target.
3451         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
3452         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
3453         case someone tries mistakenly to use the app.
3454         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3455         Link to JavaScriptCore.framework on iOS for the assert.
3456         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3457         Link to JavaScriptCore.framework on OS X for the assert.  Remove
3458         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
3459         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
3460         (main): Add assert for iOS so that a crash occurs if someone
3461         tries to run the wrong command.
3462
3463 2015-12-14  Tim Horton  <timothy_horton@apple.com>
3464
3465         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
3466         https://bugs.webkit.org/show_bug.cgi?id=152266
3467         <rdar://problem/22092676>
3468
3469         Reviewed by Simon Fraser.
3470
3471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3472         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
3473         Add a test that crashed before this change, and doesn't crash after.
3474
3475 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
3476
3477         AX: iOS: Text field variations do not have the correct traits
3478         https://bugs.webkit.org/show_bug.cgi?id=152237
3479
3480         Reviewed by Mario Sanchez Prada.
3481
3482         Add iOS calls for determing if an object is a search field or a text area.
3483
3484         * DumpRenderTree/AccessibilityUIElement.cpp:
3485         (getIsSearchFieldCallback):
3486         (getIsTextAreaCallback):
3487         (stringForSelectionCallback):
3488         (AccessibilityUIElement::getJSClass):
3489         * DumpRenderTree/AccessibilityUIElement.h:
3490         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3491         (AccessibilityUIElement::identifier):
3492         (AccessibilityUIElement::isTextArea):
3493         (AccessibilityUIElement::isSearchField):
3494         (AccessibilityUIElement::traits):
3495         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3496         (WTR::AccessibilityUIElement::scrollPageRight):
3497         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
3498         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
3499         (WTR::AccessibilityUIElement::isSearchField):
3500         (WTR::AccessibilityUIElement::isTextArea):
3501         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3502         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3503         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3504         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
3505         (WTR::AccessibilityUIElement::isTextArea):
3506         (WTR::AccessibilityUIElement::isSearchField):
3507         (WTR::AccessibilityUIElement::rowCount):
3508
3509 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3510
3511         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
3512         https://bugs.webkit.org/show_bug.cgi?id=152252
3513
3514         Reviewed by Sergio Villar Senin.
3515
3516         * gtk/install-dependencies: Add libtool-bin to the list of packages required
3517         for building the JHBuild on Debian systems.
3518
3519 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
3520
3521         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
3522         https://bugs.webkit.org/show_bug.cgi?id=152156
3523
3524         Reviewed by Dan Bernstein.
3525
3526         Our frameworks should appropriately prefix all ObjC classes,
3527         not just external symbols.
3528
3529         * Scripts/check-for-inappropriate-objc-class-names:
3530         Remove the -g switch to check all ObjC class names.
3531
3532 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
3533
3534         [MediaStream] Expose media capture devices persistent permissions to WebCore
3535         https://bugs.webkit.org/show_bug.cgi?id=152087
3536
3537         Add support for the new user media permission checker page UI client method.
3538
3539         Reviewed by Chris Dumez.
3540
3541         * WebKitTestRunner/TestController.cpp:
3542         (WTR::decidePolicyForUserMediaPermissionRequest):
3543         (WTR::checkUserMediaPermissionForOrigin):
3544         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
3545         (WTR::TestController::createWebViewWithOptions): Ditto.
3546         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
3547         (WTR::originUserVisibleName): New, create a string for the origin.
3548         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
3549           according to the state of the origin permission map.
3550         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
3551           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
3552         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
3553           origin permission map.
3554         * WebKitTestRunner/TestController.h:
3555
3556 2015-12-10  Alex Christensen  <achristensen@webkit.org>
3557
3558         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
3559         https://bugs.webkit.org/show_bug.cgi?id=152022
3560         rdar://problem/23763584
3561
3562         Reviewed by Darin Adler.
3563
3564         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3565         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3566         (WTR::InjectedBundlePage::willSendRequestForFrame):
3567         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3568         (WTR::TestRunner::setWillSendRequestReturnsNull):
3569         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
3570         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
3571         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
3572         (WTR::TestRunner::willSendRequestHTTPBody):
3573         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
3574
3575 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
3576
3577         Remove additional simulator checks before running layout-tests
3578         https://bugs.webkit.org/show_bug.cgi?id=152146
3579
3580         Reviewed by Darin Adler.
3581
3582         * Scripts/webkitpy/port/ios.py:
3583         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
3584         * Scripts/webkitpy/xcode/simulator.py:
3585         (Simulator._boot_and_shutdown_simulator_device): Deleted.
3586         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
3587
3588 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
3589
3590         Run atleast one simulator even if max process limit is low
3591         https://bugs.webkit.org/show_bug.cgi?id=152081
3592         <rdar://problem/23819694>
3593
3594         Reviewed by Alexey Proskuryakov.
3595
3596 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
3597
3598         [GTK] Crash in WebProcess when loading large content with custom URI schemes
3599         https://bugs.webkit.org/show_bug.cgi?id=144262
3600
3601         Reviewed by Carlos Garcia Campos.
3602
3603         Added new unit test to check the additional scenarios we now
3604         handle for custom URI schemes.
3605
3606         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3607         (generateHTMLContent): New helper function to generate big enough content.
3608         (testWebContextURIScheme): New unit test.
3609
3610 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
3611
3612         [EFL] Fix unhandled web process message when launching MiniBrowser
3613         https://bugs.webkit.org/show_bug.cgi?id=152048
3614
3615         Reviewed by Gyuyoung Kim.
3616
3617         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3618         (TestWebKitAPI::TEST):
3619
3620 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3621
3622         [GTK] Add API to handle beforeunload events
3623         https://bugs.webkit.org/show_bug.cgi?id=139090
3624
3625         Reviewed by Gustavo Noronha Silva.
3626
3627         * MiniBrowser/gtk/BrowserWindow.c:
3628         (browserWindowConstructed):
3629         (browserWindowDeleteEvent):
3630         (browser_window_class_init):
3631         Handle delete-event to prevent the window from being closed when
3632         the page has beforeunload handlers. Use
3633         webkit_web_view_try_close() when the window is requested to be
3634         closed.
3635         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3636         (testWebViewJavaScriptDialogs):
3637         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
3638         script dialog type.
3639
3640 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
3641
3642         Refactored initialization code in LoadTrackingTest.
3643
3644         Rubber-stamped by Carlos Garcia Campos.
3645
3646         Small refactoring to make sure that the state of a LoadTrackingTest
3647         gets properly reset before loading new web content.
3648
3649         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3650         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3651         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
3652         functions and reset the remaining local variables.
3653         (LoadTrackingTest::loadURI): Call reset();
3654         (LoadTrackingTest::loadHtml): Ditto.
3655         (LoadTrackingTest::loadPlainText): Ditto.
3656         (LoadTrackingTest::loadBytes): Ditto.
3657         (LoadTrackingTest::loadRequest): Ditto.
3658         (LoadTrackingTest::reload): Ditto.
3659         (LoadTrackingTest::goBack): Ditto.
3660         (LoadTrackingTest::goForward): Ditto.
3661
3662 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3663
3664         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
3665         https://bugs.webkit.org/show_bug.cgi?id=151942
3666
3667         Reviewed by Darin Adler.
3668
3669         * MiniBrowser/efl/main.c:
3670         (window_create): Enable offline web application cache feature on MiniBrowser.
3671         (elm_main):
3672
3673 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
3674
3675         https://bugs.webkit.org/show_bug.cgi?id=151243
3676         <rdar://problem/22955197>
3677
3678         Reviewed by Alexey Proskuryakov.
3679
3680         * LayoutTestRelay/LayoutTestRelay/main.m:
3681         (getTestingSimDevice): Use separate testing device for each worker.
3682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3683         (Manager.run): Perform cleanup even if setup fails.
3684         * Scripts/webkitpy/port/ios.py:
3685         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
3686         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
3687         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
3688         (IOSSimulatorPort._quit_ios_simulator): Same
3689         (IOSSimulatorPort.clean_up_test_run): Same
3690         (IOSSimulatorPort.check_sys_deps): Same
3691         (IOSSimulatorPort.testing_device): Same
3692         (IOSSimulatorPort.reset_preferences): Same
3693         (IOSSimulatorPort.get_simulator_path): Return simulator path.
3694         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
3695         * Scripts/webkitpy/xcode/simulator.py:
3696         (Device.delete): Delete the simulator device.
3697         (Simulator.delete_device): Same
3698         (Simulator.wait_until_device_is_booted): Wait for device booting.
3699
3700 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
3701
3702         [EFL] Add API to provide preferences before creating ewk_view
3703         https://bugs.webkit.org/show_bug.cgi?id=151587
3704
3705         Reviewed by Gyuyoung Kim.
3706
3707         * MiniBrowser/efl/main.c:
3708         (on_key_down):
3709         (quit):
3710         (window_create):
3711         Moved settings related code to configuration() not to update settings
3712         whenever ewk_view is created.
3713         (configuration):
3714         (elm_main):
3715
3716 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3717
3718         Unreviewed. Fix GTK+ API tests after r193639.
3719
3720         The new jhbuild version needs some more variables ot be present in
3721         the builtin dict, even if they are set to None.
3722
3723         * jhbuild/jhbuildutils.py:
3724         (enter_jhbuild_environment_if_available):
3725
3726 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
3727
3728         [GTK] Notify WebCore when notification is clicked
3729         https://bugs.webkit.org/show_bug.cgi?id=151951
3730
3731         Reviewed by Carlos Garcia Campos.
3732
3733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3734         (testWebViewNotification): test the new API.
3735
3736 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3737
3738         'jhbuild build' should fail immediately when building any module fails
3739         https://bugs.webkit.org/show_bug.cgi?id=145697
3740
3741         Reviewed by Carlos Garcia Campos.
3742
3743         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
3744         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
3745         Everything is placed under lib instead of lib64 now.
3746         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
3747         --exit-on-error when running 'jhbuild build'.
3748         * jhbuild/jhbuildrc_common.py:
3749         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
3750         jhbuild should be able to handle these for us without breaking things....
3751
3752 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3753
3754         Add support to import w3c tests from a repository with a different root that the main repo dir
3755         https://bugs.webkit.org/show_bug.cgi?id=151751
3756
3757         Reviewed by Ryosuke Niwa and Youenn Fablet.
3758
3759         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
3760         in a different directory than the repository root.
3761
3762         This patch introduces a new parameter tests_directory that we will use as root directory to search for
3763         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
3764         requires having the copy_path lists including tuples of origin and destination directories.
3765
3766         * Scripts/webkitpy/w3c/test_downloader.py:
3767         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
3768         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
3769         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3770         (TestImporterTest.test_tests_directory): Test.
3771
3772 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3773
3774         Mock TestRepositories in W3C importer tests
3775         https://bugs.webkit.org/show_bug.cgi?id=151938
3776
3777         Reviewed by Youenn Fablet.
3778
3779         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
3780         is because the test repository method reading the file was using the filesystem directly instead of taking the
3781         host one. This patch changes that.
3782
3783         * Scripts/webkitpy/w3c/test_downloader.py:
3784         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
3785         default one.
3786         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
3787         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3788         (TestImporterTest.test_harnesslinks_conversion):
3789         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
3790
3791 2015-12-07  David Kilzer  <ddkilzer@apple.com>
3792
3793         TestNetscapePlugIn: Address review comment on 193607
3794         <http://webkit.org/b/151881>
3795
3796         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3797         (testSetStatus): Initializing std::unique_ptr<char[]> with
3798         nullptr is redundant.
3799
3800 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3801
3802         [GTK] Add webkit_uri_request_get_http_method
3803         https://bugs.webkit.org/show_bug.cgi?id=151601
3804
3805         Reviewed by Martin Robinson.
3806
3807         Add test case to check HTTP method of WebKitURIRequest.
3808
3809         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3810         (testURIRequestHTTPMethod):
3811         (serverCallback):
3812         (beforeAll):
3813         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3814         (sendRequestCallback):
3815
3816 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3817
3818         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
3819         https://bugs.webkit.org/show_bug.cgi?id=79918
3820
3821         Reviewed by Gustavo Noronha Silva.
3822
3823         Add unit tests to check the different console messages.
3824
3825         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3826         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
3827         (ConsoleMessageTest::ConsoleMessage::operator==):
3828         (ConsoleMessageTest::consoleMessageReceivedCallback):
3829         (ConsoleMessageTest::ConsoleMessageTest):
3830         (ConsoleMessageTest::~ConsoleMessageTest):
3831         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
3832         (testWebKitConsoleMessageConsoleAPI):
3833         (testWebKitConsoleMessageJavaScriptException):
3834         (testWebKitConsoleMessageNetworkError):
3835         (testWebKitConsoleMessageSecurityError):
3836         (beforeAll):
3837         (afterAll):
3838         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3839         (consoleMessageSentCallback):
3840         (pageCreatedCallback):
3841
3842 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
3843
3844         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
3845         https://bugs.webkit.org/show_bug.cgi?id=151934
3846
3847         Reviewed by Csaba Osztrogonác.
3848
3849         * MiniBrowser/efl/main.c:
3850         (on_window_deletion): Revert the changes of r192767.
3851
3852 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3853
3854         [GTK] update-webkitgtk-libs cannot build mesa
3855         https://bugs.webkit.org/show_bug.cgi?id=151535
3856
3857         Reviewed by Martin Robinson.
3858
3859         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
3860         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
3861         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
3862         does not have a stable API and we cannot expect mesa to be buildable unless we control the
3863         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
3864         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
3865
3866         * gtk/jhbuild.modules:
3867
3868 2015-12-07  Philippe Normand  <pnormand@igalia.com>
3869
3870         [GTK][Mac] libWebExtensionTest link error
3871         https://bugs.webkit.org/show_bug.cgi?id=150802
3872
3873         Reviewed by Carlos Garcia Campos.
3874
3875         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
3876
3877 2015-12-06  David Kilzer  <ddkilzer@apple.com>
3878
3879         TestNetscapePlugIn: Fix leaks found by static analyzer
3880         <http://webkit.org/b/151881>
3881
3882         Reviewed by Darin Adler.
3883
3884         Fixes the following leaks found by the static analyzer:
3885             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
3886                     return false;
3887                            ^~~~~
3888             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
3889                     return false;
3890                            ^~~~~
3891             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
3892                     return false;
3893                            ^~~~~
3894
3895         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3896         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
3897         early return if allocation fails.
3898         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
3899         Make sure to call fclose() on filehandle, even for an early
3900         return.
3901         (testSetStatus): Switch to using std::unique_ptr<char[]>.
3902
3903 2015-12-05  David Kilzer  <ddkilzer@apple.com>
3904
3905         prepare-ChangeLog: Fix some warning messages when using svn
3906         <http://webkit.org/b/151914>
3907
3908         Reviewed by Daniel Bates.
3909
3910         * Scripts/prepare-ChangeLog:
3911         (generateFunctionLists): Simplify logic so that we never call
3912         normalizePath() with an undefined value.
3913         (attributeCommand): Quote $subPath for the shell so that we
3914         don't try to run "svn propget" on invalid paths.
3915
3916 2015-12-04  David Kilzer  <ddkilzer@apple.com>
3917
3918         TestNetscapePlugIn: Fix remaining static analyzer warnings
3919         <http://webkit.org/b/151888>
3920
3921         Reviewed by Alexey Proskuryakov.
3922
3923         Fixes the following static analyzer warnings:
3924             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
3925                     CRASH();
3926                     ^~~~~~~
3927             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
3928                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
3929                 ^~~~~~~~~~~~~~~~
3930             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
3931                 return obj->pluginTest->NPP_SetWindow(window);
3932                        ^~~~~~~~~~~~~~~
3933             2 warnings generated.
3934
3935         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3936         (CRASH): Use __builtin_trap() for gcc/clang.
3937         (NPP_SetWindow): Add early return if obj is nullptr.
3938
3939 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3940
3941         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
3942         https://bugs.webkit.org/show_bug.cgi?id=151797
3943
3944         Reviewed by Martin Robinson.
3945
3946         Since we switched to use the network process to run the unit tests
3947         the test /webkit2/WebKitWebResource/get-data sometimes fails and
3948         sometimes passes. We are now also getting the notification for the
3949         css image. Since we wait for 3 resources, sometimes the css image
3950         is loaded before and then checkResourceData is called for it, but
3951         not handled. When the css image is the last one loaded the test
3952         passes. So, we just need to wait for the 4 resources.
3953
3954         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3955         (testWebResourceGetData):
3956
3957 2015-12-03  David Kilzer  <ddkilzer@apple.com>
3958
3959         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
3960         <http://webkit.org/b/151845>
3961
3962         Reviewed by Simon Fraser.
3963
3964         Fixes the following static analyzer warning:
3965             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
3966                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
3967                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3968
3969         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3970         (createBitmapContext): Free 'buffer' after using it in logging
3971         to fix the use-after-free.  Assign a value of nullptr to buffer
3972         so we don't return with it set to a freed address.
3973
3974 2015-12-03  Jer Noble  <jer.noble@apple.com>
3975
3976         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
3977         https://bugs.webkit.org/show_bug.cgi?id=151830
3978
3979         Reviewed by Anders Carlsson.
3980
3981         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
3982
3983         * DumpRenderTree/mac/DumpRenderTree.mm:
3984         (resetWebPreferencesToConsistentValues):
3985         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3986         (WTR::initializeWebViewConfiguration):
3987
3988 2015-12-03  Anders Carlsson  <andersca@apple.com>
3989
3990         Remove Objective-C GC support
3991         https://bugs.webkit.org/show_bug.cgi?id=151819
3992         rdar://problem/23746991
3993
3994         Reviewed by Dan Bernstein.
3995
3996         * asan/asan.xcconfig:
3997
3998 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3999
4000         Allow nil for unspecified benchmark pathes
4001         https://bugs.webkit.org/show_bug.cgi?id=151784
4002
4003         Reviewed by Filip Pizlo.
4004
4005         `Pathname.new(nil)` will raise an error.
4006         Only generate Pathname if the benchmark path is specified.
4007
4008         * Scripts/run-jsc-benchmarks:
4009
4010 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
4011
4012         [Win] Run non-http tests without Cygwin
4013         https://bugs.webkit.org/show_bug.cgi?id=151721
4014
4015         Reviewed by Andy Estes.
4016
4017         Support native 32-bit and 64-bit Python (and Perl) builds
4018         for running tests:
4019
4020         1. Use "startswith('win')", rather than "== 'win32'" to support
4021         various Windows build types.
4022         2. Supply full path for some native Windows utilities, since the
4023         path environment does not always have the specified, and they are
4024         guaranteed to exist in those specific locations.
4025         3. Make sure native Windows Python test runs pass proper environment
4026         variables to run programs.
4027         4. Append 'exe' suffix when running Windows executables.
4028         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
4029         command doesn't exist.
4030         
4031         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
4032         the current Perl executable, rather than requiring a new path search.
4033         * Scripts/webkitpy/common/find_files_unittest.py:
4034         (TestWinNormalize.test_win): Use startswith('win').
4035         * Scripts/webkitpy/common/prettypatch_unittest.py:
4036         (test_pretty_diff_encodings): Ditto.
4037         * Scripts/webkitpy/common/system/executive.py:
4038         (Executive._should_close_fds): Ditto.
4039         (Executive.shell_command_for_script): Use startswith('win').
4040         (Executive.kill_process): Use full path to killall executable.
4041         (Executive.check_running_pid): Use startswith('win').
4042         (Executive.running_pids): Ditto.
4043         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
4044         running under native Windows Python.
4045         (Executive._child_process_encoding): Use startswith('win').
4046         (Executive._should_encode_child_process_arguments): Ditto.
4047         (Executive.popen): Recognize proper script engine on Windows, since it
4048         does not support the shebang syntax.
4049         (Executive.run_in_parallel): Use startswith('win').
4050         * Scripts/webkitpy/common/system/executive_unittest.py:
4051         (never_ending_command): Ditto.
4052         (ExecutiveTest.test_run_command_with_unicode): Ditto.
4053         (ExecutiveTest.serial_test_kill_process): Ditto.
4054         (ExecutiveTest.serial_test_kill_all): Ditto.
4055         (ExecutiveTest.serial_test_check_running_pid): Ditto.
4056         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
4057         (main): Ditto.
4058         * Scripts/webkitpy/common/system/file_lock.py:
4059         (FileLock._create_lock): Ditto.
4060         (FileLock._remove_lock): Ditto.
4061         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4062         (RealFileSystemTest.test_chdir): Ditto.
4063         (RealFileSystemTest.test_chdir__notexists): Ditto.
4064         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
4065         * Scripts/webkitpy/common/system/path_unittest.py:
4066         (AbspathTest.test_abspath_to_uri_win): Ditto.
4067         * Scripts/webkitpy/common/system/platforminfo.py:
4068         (PlatformInfo._determine_os_name): Ditto.
4069         * Scripts/webkitpy/common/system/user.py: Ditto.
4070         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4071         (ManagerTest.integration_test_needs_servers): Ditto.
4072         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4073         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
4074         driver letters.
4075         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
4076         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
4077         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
4078         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4079         (HttpServerBase._check_that_all_ports_are_available): Ditto.
4080         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4081         (TestHttpServer.test_start_cmd): Ditto.
4082         * Scripts/webkitpy/port/base.py:
4083         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
4084         and 'SYSTEMROOT' in environment passed to test runners.
4085         (Port._apache_config_file_name_for_platform): Use startswith('win').
4086         (Port._build_path): Ditto.
4087         (Port._path_to_driver): Include 'exe' suffix when running under native
4088         Windows.
4089         * Scripts/webkitpy/port/driver.py:
4090         (Driver._setup_environ_for_driver): Explicitly make some environment
4091         variables strings.
4092         * Scripts/webkitpy/port/server_process.py:
4093         (ServerProcess.__init__): Use startswith('win').
4094         * Scripts/webkitpy/port/win.py:
4095         (WinPort): Use the win32 registry utilities on Windows, and appropriate
4096         registry key formats.
4097         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
4098         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
4099         and regtool on Cygwin.
4100         (WinPort.write_registry_value): Ditto.
4101         (WinPort.setup_crash_log_saving): Ditto.
4102         (WinPort.restore_crash_log_saving): Ditto.
4103         (WinPort.prevent_error_dialogs): Ditto.
4104         (WinPort.allow_error_dialogs): Ditto.
4105         (WinPort.find_system_pid): Revise to use Windows management
4106         infrastructure on native Windows, continue using 'ps' on Cygwin.
4107         (WinPort.read_registry_string): Deleted.
4108         (WinPort.write_registry_string): Deleted.
4109         * Scripts/webkitpy/test/main.py:
4110         (main): Use startswith('win').
4111         (Tester._parse_args): Ditto.
4112
4113 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
4114
4115         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
4116         https://bugs.webkit.org/show_bug.cgi?id=150792
4117
4118         Reviewed by Saam Barati.
4119
4120         * Scripts/webkitperl/FeatureList.pm:
4121
4122 2015-12-01  Commit Queue  <commit-queue@webkit.org>
4123
4124         Unreviewed, rolling out r192914.
4125         https://bugs.webkit.org/show_bug.cgi?id=151734
4126
4127         JSC tests for this change are failing on 32 and 64-bit bots
4128         (Requested by ryanhaddad on #webkit).
4129
4130         Reverted changeset:
4131
4132         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
4133         enable this feature"
4134         https://bugs.webkit.org/show_bug.cgi?id=150792
4135         http://trac.webkit.org/changeset/192914
4136
4137 2015-12-01  David Kilzer  <ddkilzer@apple.com>
4138
4139         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
4140         <http://webkit.org/b/151726>
4141
4142         Reviewed by Simon Fraser.
4143
4144         * WebKitTestRunner/mac/EventSenderProxy.mm:
4145         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
4146         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
4147
4148 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
4149
4150         Give String and AtomicString an existingHash() function
4151         https://bugs.webkit.org/show_bug.cgi?id=151717
4152
4153         Reviewed by Andreas Kling.
4154
4155         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
4156         (TestWebKitAPI::TEST):
4157         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4158         (TestWebKitAPI::TEST):
4159
4160 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
4161
4162         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
4163         https://bugs.webkit.org/show_bug.cgi?id=150792
4164
4165         Reviewed by Saam Barati.
4166
4167         * Scripts/webkitperl/FeatureList.pm:
4168
4169 2015-12-01  Sam Weinig  <sam@webkit.org>
4170
4171         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
4172         <rdar://problem/23320863>
4173         https://bugs.webkit.org/show_bug.cgi?id=151708
4174
4175         Reviewed by Anders Carlsson.
4176
4177         * WebKitTestRunner/TestController.cpp:
4178         (WTR::TestController::createOtherPage):
4179         (WTR::TestController::createWebViewWithOptions):
4180         Update for new WKPageUIClient.
4181
4182 2015-12-01  Anders Carlsson  <andersca@apple.com>
4183
4184         Remove WebKit2.framework
4185         https://bugs.webkit.org/show_bug.cgi?id=151715
4186
4187         Reviewed by Dan Bernstein.
4188
4189         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
4190         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
4191         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
4192         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
4193         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
4194         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
4195         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
4196
4197 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
4198
4199         Unreviewed common typo fix "occurance" => "occurrence".
4200
4201         * Scripts/webkitpy/tool/commands/queries.py:
4202         (FindFlakyTests._print_statistics):
4203
4204 2015-11-30  Alex Christensen  <achristensen@webkit.org>
4205
4206         Make ProcessModel always MultipleSecondaryProcesses
4207         https://bugs.webkit.org/show_bug.cgi?id=151662
4208
4209         Reviewed by Antti Koivisto.
4210
4211         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4212         (TestWebKitAPI::TEST):
4213         * WebKitTestRunner/TestController.cpp:
4214         (WTR::TestController::generatePageConfiguration):
4215
4216 2015-11-30  Alex Christensen  <achristensen@webkit.org>
4217
4218         Make usesNetworkProcess always true
4219         https://bugs.webkit.org/show_bug.cgi?id=151580
4220
4221         Reviewed by Darin Adler.
4222
4223         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4224         (TestWebKitAPI::TEST):
4225         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
4226         (TestWebKitAPI::TEST):
4227         * WebKitTestRunner/TestController.cpp:
4228         (WTR::TestController::generatePageConfiguration):
4229
4230 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4231
4232         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
4233
4234         Add a way to skip unit tests only for Debug or Release builds and
4235         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
4236
4237         * Scripts/run-gtk-tests:
4238         (SkippedTest):
4239         (SkippedTest.__init__):
4240         (SkippedTest.__str__):
4241         (SkippedTest.skip_entire_suite):
4242         (SkippedTest.skip_for_build_type):
4243         (TestRunner):
4244         (TestRunner.__init__):
4245
4246 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4247
4248         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
4249
4250         It's an assert hit because we are reloading a view loaded with
4251         HTML data which is not supported. Use loadURI instead.
4252
4253         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4254         (testWebViewCustomCharset):
4255
4256 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4257
4258         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
4259         https://bugs.webkit.org/show_bug.cgi?id=151633
4260
4261         Reviewed by Csaba Osztrogonác.
4262
4263         * TestWebKitAPI/PlatformGTK.cmake:
4264         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
4265
4266 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4267
4268         [GTK] Remove the remaining uses of GMainLoopSource
4269         https://bugs.webkit.org/show_bug.cgi?id=151632
4270