[GTK] jquery.min.js violates DFSG
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [GTK] jquery.min.js violates DFSG
4         https://bugs.webkit.org/show_bug.cgi?id=152428
5
6         Reviewed by Joseph Pecoraro.
7
8         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
9         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
10
11         * gtk/manifest.txt.in:
12
13 2015-12-19  Dan Bernstein  <mitz@apple.com>
14
15         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
16         https://bugs.webkit.org/show_bug.cgi?id=152462
17
18         Reviewed by Alexey Proskuryakov.
19
20         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
21           OS X 10.9:
22
23         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
24         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
25         * MiniBrowser/Configurations/DebugRelease.xcconfig:
26         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
27         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
28
29         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
30           never getting compiled:
31
32         * DumpRenderTree/mac/TextInputController.m:
33         * MiniBrowser/mac/BrowserWindowController.m:
34         * TestWebKitAPI/Tests/mac/AttributedString.mm:
35         * WebKitTestRunner/mac/EventSenderProxy.mm:
36
37 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
38
39         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
40
41         This is to make it easy to CC it on Bugzilla.
42
43         * Scripts/webkitpy/common/config/contributors.json:
44
45 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
46
47         Pasteboard get messed up after running kill-old-processes
48         https://bugs.webkit.org/show_bug.cgi?id=152426
49
50         Reviewed by Alexey Proskuryakov.
51
52         * BuildSlaveSupport/kill-old-processes:
53         (main): Do not kill pasteboard anymore.
54
55 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
56
57         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
58         https://bugs.webkit.org/show_bug.cgi?id=152157
59         <rdar://problem/23851817>
60
61         Reviewed by Alexey Proskuryakov.
62
63         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
64         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
65         * Scripts/webkitpy/layout_tests/controllers/manager.py:
66         (Manager._get_test_inputs): Common method to calculate test_inputs.
67         (Manager._update_worker_count): Calculate and update required number of workers.
68
69 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
70
71         run-webkit-tests fails to delete Simulator device during cleanup
72         https://bugs.webkit.org/show_bug.cgi?id=152363
73
74         Reviewed by Alexey Proskuryakov.
75
76         * Scripts/webkitpy/xcode/simulator.py:
77         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
78
79 2015-12-16  Tim Horton  <timothy_horton@apple.com>
80
81         [mac-wk2] fast/events force click tests crashing
82         https://bugs.webkit.org/show_bug.cgi?id=152339
83
84         Reviewed by Beth Dakin.
85
86         * WebKitTestRunner/mac/EventSenderProxy.mm:
87         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
88         Set the NSEvent's _type member in addition to overriding -type,
89         because there are assertions in touch event handling code that depend on it.
90
91 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
92
93         Enforce temporarily bots to sync WebKit and WPT testharness.js
94         https://bugs.webkit.org/show_bug.cgi?id=152334
95
96         Reviewed by Darin Adler.
97
98         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
99         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
100
101 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
102
103         [Fetch API] Add fetch API compile time flag
104         https://bugs.webkit.org/show_bug.cgi?id=152254
105
106         Reviewed by Darin Adler.
107
108         * Scripts/webkitperl/FeatureList.pm:
109
110 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
111
112         Unreviewed.
113
114         Added files that have impact in building Streams API to the watchlist.
115
116         * Scripts/webkitpy/common/config/watchlist:
117
118 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
119
120         Unreviewed.
121
122         Added imported tests to Streams API watchlist.
123
124         * Scripts/webkitpy/common/config/watchlist:
125
126 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
127
128         Remove default copy of wpt testharness.js when launching wpt server
129         https://bugs.webkit.org/show_bug.cgi?id=152298
130
131         Reviewed by Darin Adler.
132
133         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
134         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
135
136 2015-12-15  David Kilzer  <ddkilzer@apple.com>
137
138         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
139         <http://webkit.org/b/152314>
140
141         Reviewed by Daniel Bates.
142
143         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
144         code path to exit immediately when calling main().
145         Unfortunately, DumpRenderTreeMain.mm was used for both
146         DumpRenderTree command-line binary and DumpRenderTree.app, which
147         meant that the app would exit immediately with no error code
148         when run!
149
150         The workaround is to introduce a separate source file called
151         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
152         already does.
153
154         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
155         DumpRenderTreeAppMain.mm to the project.  Make it the only
156         compiled source for the DumpRenderTree.app target.
157         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
158         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
159         case someone tries mistakenly to use the app.
160         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
161         Link to JavaScriptCore.framework on iOS for the assert.
162         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
163         Link to JavaScriptCore.framework on OS X for the assert.  Remove
164         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
165         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
166         (main): Add assert for iOS so that a crash occurs if someone
167         tries to run the wrong command.
168
169 2015-12-14  Tim Horton  <timothy_horton@apple.com>
170
171         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
172         https://bugs.webkit.org/show_bug.cgi?id=152266
173         <rdar://problem/22092676>
174
175         Reviewed by Simon Fraser.
176
177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
178         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
179         Add a test that crashed before this change, and doesn't crash after.
180
181 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
182
183         AX: iOS: Text field variations do not have the correct traits
184         https://bugs.webkit.org/show_bug.cgi?id=152237
185
186         Reviewed by Mario Sanchez Prada.
187
188         Add iOS calls for determing if an object is a search field or a text area.
189
190         * DumpRenderTree/AccessibilityUIElement.cpp:
191         (getIsSearchFieldCallback):
192         (getIsTextAreaCallback):
193         (stringForSelectionCallback):
194         (AccessibilityUIElement::getJSClass):
195         * DumpRenderTree/AccessibilityUIElement.h:
196         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
197         (AccessibilityUIElement::identifier):
198         (AccessibilityUIElement::isTextArea):
199         (AccessibilityUIElement::isSearchField):
200         (AccessibilityUIElement::traits):
201         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
202         (WTR::AccessibilityUIElement::scrollPageRight):
203         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
204         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
205         (WTR::AccessibilityUIElement::isSearchField):
206         (WTR::AccessibilityUIElement::isTextArea):
207         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
208         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
209         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
210         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
211         (WTR::AccessibilityUIElement::isTextArea):
212         (WTR::AccessibilityUIElement::isSearchField):
213         (WTR::AccessibilityUIElement::rowCount):
214
215 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
216
217         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
218         https://bugs.webkit.org/show_bug.cgi?id=152252
219
220         Reviewed by Sergio Villar Senin.
221
222         * gtk/install-dependencies: Add libtool-bin to the list of packages required
223         for building the JHBuild on Debian systems.
224
225 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
226
227         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
228         https://bugs.webkit.org/show_bug.cgi?id=152156
229
230         Reviewed by Dan Bernstein.
231
232         Our frameworks should appropriately prefix all ObjC classes,
233         not just external symbols.
234
235         * Scripts/check-for-inappropriate-objc-class-names:
236         Remove the -g switch to check all ObjC class names.
237
238 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
239
240         [MediaStream] Expose media capture devices persistent permissions to WebCore
241         https://bugs.webkit.org/show_bug.cgi?id=152087
242
243         Add support for the new user media permission checker page UI client method.
244
245         Reviewed by Chris Dumez.
246
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::decidePolicyForUserMediaPermissionRequest):
249         (WTR::checkUserMediaPermissionForOrigin):
250         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
251         (WTR::TestController::createWebViewWithOptions): Ditto.
252         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
253         (WTR::originUserVisibleName): New, create a string for the origin.
254         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
255           according to the state of the origin permission map.
256         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
257           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
258         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
259           origin permission map.
260         * WebKitTestRunner/TestController.h:
261
262 2015-12-10  Alex Christensen  <achristensen@webkit.org>
263
264         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
265         https://bugs.webkit.org/show_bug.cgi?id=152022
266         rdar://problem/23763584
267
268         Reviewed by Darin Adler.
269
270         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
271         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
272         (WTR::InjectedBundlePage::willSendRequestForFrame):
273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
274         (WTR::TestRunner::setWillSendRequestReturnsNull):
275         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
276         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
277         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
278         (WTR::TestRunner::willSendRequestHTTPBody):
279         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
280
281 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
282
283         Remove additional simulator checks before running layout-tests
284         https://bugs.webkit.org/show_bug.cgi?id=152146
285
286         Reviewed by Darin Adler.
287
288         * Scripts/webkitpy/port/ios.py:
289         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
290         * Scripts/webkitpy/xcode/simulator.py:
291         (Simulator._boot_and_shutdown_simulator_device): Deleted.
292         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
293
294 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
295
296         Run atleast one simulator even if max process limit is low
297         https://bugs.webkit.org/show_bug.cgi?id=152081
298         <rdar://problem/23819694>
299
300         Reviewed by Alexey Proskuryakov.
301
302 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
303
304         [GTK] Crash in WebProcess when loading large content with custom URI schemes
305         https://bugs.webkit.org/show_bug.cgi?id=144262
306
307         Reviewed by Carlos Garcia Campos.
308
309         Added new unit test to check the additional scenarios we now
310         handle for custom URI schemes.
311
312         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
313         (generateHTMLContent): New helper function to generate big enough content.
314         (testWebContextURIScheme): New unit test.
315
316 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
317
318         [EFL] Fix unhandled web process message when launching MiniBrowser
319         https://bugs.webkit.org/show_bug.cgi?id=152048
320
321         Reviewed by Gyuyoung Kim.
322
323         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
324         (TestWebKitAPI::TEST):
325
326 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
327
328         [GTK] Add API to handle beforeunload events
329         https://bugs.webkit.org/show_bug.cgi?id=139090
330
331         Reviewed by Gustavo Noronha Silva.
332
333         * MiniBrowser/gtk/BrowserWindow.c:
334         (browserWindowConstructed):
335         (browserWindowDeleteEvent):
336         (browser_window_class_init):
337         Handle delete-event to prevent the window from being closed when
338         the page has beforeunload handlers. Use
339         webkit_web_view_try_close() when the window is requested to be
340         closed.
341         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
342         (testWebViewJavaScriptDialogs):
343         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
344         script dialog type.
345
346 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
347
348         Refactored initialization code in LoadTrackingTest.
349
350         Rubber-stamped by Carlos Garcia Campos.
351
352         Small refactoring to make sure that the state of a LoadTrackingTest
353         gets properly reset before loading new web content.
354
355         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
356         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
357         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
358         functions and reset the remaining local variables.
359         (LoadTrackingTest::loadURI): Call reset();
360         (LoadTrackingTest::loadHtml): Ditto.
361         (LoadTrackingTest::loadPlainText): Ditto.
362         (LoadTrackingTest::loadBytes): Ditto.
363         (LoadTrackingTest::loadRequest): Ditto.
364         (LoadTrackingTest::reload): Ditto.
365         (LoadTrackingTest::goBack): Ditto.
366         (LoadTrackingTest::goForward): Ditto.
367
368 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
369
370         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
371         https://bugs.webkit.org/show_bug.cgi?id=151942
372
373         Reviewed by Darin Adler.
374
375         * MiniBrowser/efl/main.c:
376         (window_create): Enable offline web application cache feature on MiniBrowser.
377         (elm_main):
378
379 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
380
381         https://bugs.webkit.org/show_bug.cgi?id=151243
382         <rdar://problem/22955197>
383
384         Reviewed by Alexey Proskuryakov.
385
386         * LayoutTestRelay/LayoutTestRelay/main.m:
387         (getTestingSimDevice): Use separate testing device for each worker.
388         * Scripts/webkitpy/layout_tests/controllers/manager.py:
389         (Manager.run): Perform cleanup even if setup fails.
390         * Scripts/webkitpy/port/ios.py:
391         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
392         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
393         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
394         (IOSSimulatorPort._quit_ios_simulator): Same
395         (IOSSimulatorPort.clean_up_test_run): Same
396         (IOSSimulatorPort.check_sys_deps): Same
397         (IOSSimulatorPort.testing_device): Same
398         (IOSSimulatorPort.reset_preferences): Same
399         (IOSSimulatorPort.get_simulator_path): Return simulator path.
400         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
401         * Scripts/webkitpy/xcode/simulator.py:
402         (Device.delete): Delete the simulator device.
403         (Simulator.delete_device): Same
404         (Simulator.wait_until_device_is_booted): Wait for device booting.
405
406 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
407
408         [EFL] Add API to provide preferences before creating ewk_view
409         https://bugs.webkit.org/show_bug.cgi?id=151587
410
411         Reviewed by Gyuyoung Kim.
412
413         * MiniBrowser/efl/main.c:
414         (on_key_down):
415         (quit):
416         (window_create):
417         Moved settings related code to configuration() not to update settings
418         whenever ewk_view is created.
419         (configuration):
420         (elm_main):
421
422 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
423
424         Unreviewed. Fix GTK+ API tests after r193639.
425
426         The new jhbuild version needs some more variables ot be present in
427         the builtin dict, even if they are set to None.
428
429         * jhbuild/jhbuildutils.py:
430         (enter_jhbuild_environment_if_available):
431
432 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
433
434         [GTK] Notify WebCore when notification is clicked
435         https://bugs.webkit.org/show_bug.cgi?id=151951
436
437         Reviewed by Carlos Garcia Campos.
438
439         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
440         (testWebViewNotification): test the new API.
441
442 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
443
444         'jhbuild build' should fail immediately when building any module fails
445         https://bugs.webkit.org/show_bug.cgi?id=145697
446
447         Reviewed by Carlos Garcia Campos.
448
449         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
450         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
451         Everything is placed under lib instead of lib64 now.
452         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
453         --exit-on-error when running 'jhbuild build'.
454         * jhbuild/jhbuildrc_common.py:
455         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
456         jhbuild should be able to handle these for us without breaking things....
457
458 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
459
460         Add support to import w3c tests from a repository with a different root that the main repo dir
461         https://bugs.webkit.org/show_bug.cgi?id=151751
462
463         Reviewed by Ryosuke Niwa and Youenn Fablet.
464
465         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
466         in a different directory than the repository root.
467
468         This patch introduces a new parameter tests_directory that we will use as root directory to search for
469         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
470         requires having the copy_path lists including tuples of origin and destination directories.
471
472         * Scripts/webkitpy/w3c/test_downloader.py:
473         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
474         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
475         * Scripts/webkitpy/w3c/test_importer_unittest.py:
476         (TestImporterTest.test_tests_directory): Test.
477
478 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
479
480         Mock TestRepositories in W3C importer tests
481         https://bugs.webkit.org/show_bug.cgi?id=151938
482
483         Reviewed by Youenn Fablet.
484
485         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
486         is because the test repository method reading the file was using the filesystem directly instead of taking the
487         host one. This patch changes that.
488
489         * Scripts/webkitpy/w3c/test_downloader.py:
490         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
491         default one.
492         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
493         * Scripts/webkitpy/w3c/test_importer_unittest.py:
494         (TestImporterTest.test_harnesslinks_conversion):
495         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
496
497 2015-12-07  David Kilzer  <ddkilzer@apple.com>
498
499         TestNetscapePlugIn: Address review comment on 193607
500         <http://webkit.org/b/151881>
501
502         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
503         (testSetStatus): Initializing std::unique_ptr<char[]> with
504         nullptr is redundant.
505
506 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
507
508         [GTK] Add webkit_uri_request_get_http_method
509         https://bugs.webkit.org/show_bug.cgi?id=151601
510
511         Reviewed by Martin Robinson.
512
513         Add test case to check HTTP method of WebKitURIRequest.
514
515         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
516         (testURIRequestHTTPMethod):
517         (serverCallback):
518         (beforeAll):
519         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
520         (sendRequestCallback):
521
522 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
523
524         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
525         https://bugs.webkit.org/show_bug.cgi?id=79918
526
527         Reviewed by Gustavo Noronha Silva.
528
529         Add unit tests to check the different console messages.
530
531         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
532         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
533         (ConsoleMessageTest::ConsoleMessage::operator==):
534         (ConsoleMessageTest::consoleMessageReceivedCallback):
535         (ConsoleMessageTest::ConsoleMessageTest):
536         (ConsoleMessageTest::~ConsoleMessageTest):
537         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
538         (testWebKitConsoleMessageConsoleAPI):
539         (testWebKitConsoleMessageJavaScriptException):
540         (testWebKitConsoleMessageNetworkError):
541         (testWebKitConsoleMessageSecurityError):
542         (beforeAll):
543         (afterAll):
544         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
545         (consoleMessageSentCallback):
546         (pageCreatedCallback):
547
548 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
549
550         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
551         https://bugs.webkit.org/show_bug.cgi?id=151934
552
553         Reviewed by Csaba Osztrogonác.
554
555         * MiniBrowser/efl/main.c:
556         (on_window_deletion): Revert the changes of r192767.
557
558 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
559
560         [GTK] update-webkitgtk-libs cannot build mesa
561         https://bugs.webkit.org/show_bug.cgi?id=151535
562
563         Reviewed by Martin Robinson.
564
565         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
566         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
567         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
568         does not have a stable API and we cannot expect mesa to be buildable unless we control the
569         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
570         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
571
572         * gtk/jhbuild.modules:
573
574 2015-12-07  Philippe Normand  <pnormand@igalia.com>
575
576         [GTK][Mac] libWebExtensionTest link error
577         https://bugs.webkit.org/show_bug.cgi?id=150802
578
579         Reviewed by Carlos Garcia Campos.
580
581         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
582
583 2015-12-06  David Kilzer  <ddkilzer@apple.com>
584
585         TestNetscapePlugIn: Fix leaks found by static analyzer
586         <http://webkit.org/b/151881>
587
588         Reviewed by Darin Adler.
589
590         Fixes the following leaks found by the static analyzer:
591             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
592                     return false;
593                            ^~~~~
594             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
595                     return false;
596                            ^~~~~
597             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
598                     return false;
599                            ^~~~~
600
601         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
602         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
603         early return if allocation fails.
604         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
605         Make sure to call fclose() on filehandle, even for an early
606         return.
607         (testSetStatus): Switch to using std::unique_ptr<char[]>.
608
609 2015-12-05  David Kilzer  <ddkilzer@apple.com>
610
611         prepare-ChangeLog: Fix some warning messages when using svn
612         <http://webkit.org/b/151914>
613
614         Reviewed by Daniel Bates.
615
616         * Scripts/prepare-ChangeLog:
617         (generateFunctionLists): Simplify logic so that we never call
618         normalizePath() with an undefined value.
619         (attributeCommand): Quote $subPath for the shell so that we
620         don't try to run "svn propget" on invalid paths.
621
622 2015-12-04  David Kilzer  <ddkilzer@apple.com>
623
624         TestNetscapePlugIn: Fix remaining static analyzer warnings
625         <http://webkit.org/b/151888>
626
627         Reviewed by Alexey Proskuryakov.
628
629         Fixes the following static analyzer warnings:
630             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
631                     CRASH();
632                     ^~~~~~~
633             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
634                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
635                 ^~~~~~~~~~~~~~~~
636             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
637                 return obj->pluginTest->NPP_SetWindow(window);
638                        ^~~~~~~~~~~~~~~
639             2 warnings generated.
640
641         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
642         (CRASH): Use __builtin_trap() for gcc/clang.
643         (NPP_SetWindow): Add early return if obj is nullptr.
644
645 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
646
647         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
648         https://bugs.webkit.org/show_bug.cgi?id=151797
649
650         Reviewed by Martin Robinson.
651
652         Since we switched to use the network process to run the unit tests
653         the test /webkit2/WebKitWebResource/get-data sometimes fails and
654         sometimes passes. We are now also getting the notification for the
655         css image. Since we wait for 3 resources, sometimes the css image
656         is loaded before and then checkResourceData is called for it, but
657         not handled. When the css image is the last one loaded the test
658         passes. So, we just need to wait for the 4 resources.
659
660         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
661         (testWebResourceGetData):
662
663 2015-12-03  David Kilzer  <ddkilzer@apple.com>
664
665         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
666         <http://webkit.org/b/151845>
667
668         Reviewed by Simon Fraser.
669
670         Fixes the following static analyzer warning:
671             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
672                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
673                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
674
675         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
676         (createBitmapContext): Free 'buffer' after using it in logging
677         to fix the use-after-free.  Assign a value of nullptr to buffer
678         so we don't return with it set to a freed address.
679
680 2015-12-03  Jer Noble  <jer.noble@apple.com>
681
682         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
683         https://bugs.webkit.org/show_bug.cgi?id=151830
684
685         Reviewed by Anders Carlsson.
686
687         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
688
689         * DumpRenderTree/mac/DumpRenderTree.mm:
690         (resetWebPreferencesToConsistentValues):
691         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
692         (WTR::initializeWebViewConfiguration):
693
694 2015-12-03  Anders Carlsson  <andersca@apple.com>
695
696         Remove Objective-C GC support
697         https://bugs.webkit.org/show_bug.cgi?id=151819
698         rdar://problem/23746991
699
700         Reviewed by Dan Bernstein.
701
702         * asan/asan.xcconfig:
703
704 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
705
706         Allow nil for unspecified benchmark pathes
707         https://bugs.webkit.org/show_bug.cgi?id=151784
708
709         Reviewed by Filip Pizlo.
710
711         `Pathname.new(nil)` will raise an error.
712         Only generate Pathname if the benchmark path is specified.
713
714         * Scripts/run-jsc-benchmarks:
715
716 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
717
718         [Win] Run non-http tests without Cygwin
719         https://bugs.webkit.org/show_bug.cgi?id=151721
720
721         Reviewed by Andy Estes.
722
723         Support native 32-bit and 64-bit Python (and Perl) builds
724         for running tests:
725
726         1. Use "startswith('win')", rather than "== 'win32'" to support
727         various Windows build types.
728         2. Supply full path for some native Windows utilities, since the
729         path environment does not always have the specified, and they are
730         guaranteed to exist in those specific locations.
731         3. Make sure native Windows Python test runs pass proper environment
732         variables to run programs.
733         4. Append 'exe' suffix when running Windows executables.
734         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
735         command doesn't exist.
736         
737         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
738         the current Perl executable, rather than requiring a new path search.
739         * Scripts/webkitpy/common/find_files_unittest.py:
740         (TestWinNormalize.test_win): Use startswith('win').
741         * Scripts/webkitpy/common/prettypatch_unittest.py:
742         (test_pretty_diff_encodings): Ditto.
743         * Scripts/webkitpy/common/system/executive.py:
744         (Executive._should_close_fds): Ditto.
745         (Executive.shell_command_for_script): Use startswith('win').
746         (Executive.kill_process): Use full path to killall executable.
747         (Executive.check_running_pid): Use startswith('win').
748         (Executive.running_pids): Ditto.
749         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
750         running under native Windows Python.
751         (Executive._child_process_encoding): Use startswith('win').
752         (Executive._should_encode_child_process_arguments): Ditto.
753         (Executive.popen): Recognize proper script engine on Windows, since it
754         does not support the shebang syntax.
755         (Executive.run_in_parallel): Use startswith('win').
756         * Scripts/webkitpy/common/system/executive_unittest.py:
757         (never_ending_command): Ditto.
758         (ExecutiveTest.test_run_command_with_unicode): Ditto.
759         (ExecutiveTest.serial_test_kill_process): Ditto.
760         (ExecutiveTest.serial_test_kill_all): Ditto.
761         (ExecutiveTest.serial_test_check_running_pid): Ditto.
762         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
763         (main): Ditto.
764         * Scripts/webkitpy/common/system/file_lock.py:
765         (FileLock._create_lock): Ditto.
766         (FileLock._remove_lock): Ditto.
767         * Scripts/webkitpy/common/system/filesystem_unittest.py:
768         (RealFileSystemTest.test_chdir): Ditto.
769         (RealFileSystemTest.test_chdir__notexists): Ditto.
770         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
771         * Scripts/webkitpy/common/system/path_unittest.py:
772         (AbspathTest.test_abspath_to_uri_win): Ditto.
773         * Scripts/webkitpy/common/system/platforminfo.py:
774         (PlatformInfo._determine_os_name): Ditto.
775         * Scripts/webkitpy/common/system/user.py: Ditto.
776         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
777         (ManagerTest.integration_test_needs_servers): Ditto.
778         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
779         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
780         driver letters.
781         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
782         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
783         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
784         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
785         (HttpServerBase._check_that_all_ports_are_available): Ditto.
786         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
787         (TestHttpServer.test_start_cmd): Ditto.
788         * Scripts/webkitpy/port/base.py:
789         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
790         and 'SYSTEMROOT' in environment passed to test runners.
791         (Port._apache_config_file_name_for_platform): Use startswith('win').
792         (Port._build_path): Ditto.
793         (Port._path_to_driver): Include 'exe' suffix when running under native
794         Windows.
795         * Scripts/webkitpy/port/driver.py:
796         (Driver._setup_environ_for_driver): Explicitly make some environment
797         variables strings.
798         * Scripts/webkitpy/port/server_process.py:
799         (ServerProcess.__init__): Use startswith('win').
800         * Scripts/webkitpy/port/win.py:
801         (WinPort): Use the win32 registry utilities on Windows, and appropriate
802         registry key formats.
803         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
804         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
805         and regtool on Cygwin.
806         (WinPort.write_registry_value): Ditto.
807         (WinPort.setup_crash_log_saving): Ditto.
808         (WinPort.restore_crash_log_saving): Ditto.
809         (WinPort.prevent_error_dialogs): Ditto.
810         (WinPort.allow_error_dialogs): Ditto.
811         (WinPort.find_system_pid): Revise to use Windows management
812         infrastructure on native Windows, continue using 'ps' on Cygwin.
813         (WinPort.read_registry_string): Deleted.
814         (WinPort.write_registry_string): Deleted.
815         * Scripts/webkitpy/test/main.py:
816         (main): Use startswith('win').
817         (Tester._parse_args): Ditto.
818
819 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
820
821         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
822         https://bugs.webkit.org/show_bug.cgi?id=150792
823
824         Reviewed by Saam Barati.
825
826         * Scripts/webkitperl/FeatureList.pm:
827
828 2015-12-01  Commit Queue  <commit-queue@webkit.org>
829
830         Unreviewed, rolling out r192914.
831         https://bugs.webkit.org/show_bug.cgi?id=151734
832
833         JSC tests for this change are failing on 32 and 64-bit bots
834         (Requested by ryanhaddad on #webkit).
835
836         Reverted changeset:
837
838         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
839         enable this feature"
840         https://bugs.webkit.org/show_bug.cgi?id=150792
841         http://trac.webkit.org/changeset/192914
842
843 2015-12-01  David Kilzer  <ddkilzer@apple.com>
844
845         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
846         <http://webkit.org/b/151726>
847
848         Reviewed by Simon Fraser.
849
850         * WebKitTestRunner/mac/EventSenderProxy.mm:
851         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
852         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
853
854 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
855
856         Give String and AtomicString an existingHash() function
857         https://bugs.webkit.org/show_bug.cgi?id=151717
858
859         Reviewed by Andreas Kling.
860
861         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
862         (TestWebKitAPI::TEST):
863         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
864         (TestWebKitAPI::TEST):
865
866 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
867
868         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
869         https://bugs.webkit.org/show_bug.cgi?id=150792
870
871         Reviewed by Saam Barati.
872
873         * Scripts/webkitperl/FeatureList.pm:
874
875 2015-12-01  Sam Weinig  <sam@webkit.org>
876
877         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
878         <rdar://problem/23320863>
879         https://bugs.webkit.org/show_bug.cgi?id=151708
880
881         Reviewed by Anders Carlsson.
882
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::createOtherPage):
885         (WTR::TestController::createWebViewWithOptions):
886         Update for new WKPageUIClient.
887
888 2015-12-01  Anders Carlsson  <andersca@apple.com>
889
890         Remove WebKit2.framework
891         https://bugs.webkit.org/show_bug.cgi?id=151715
892
893         Reviewed by Dan Bernstein.
894
895         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
896         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
897         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
898         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
899         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
900         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
901         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
902
903 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
904
905         Unreviewed common typo fix "occurance" => "occurrence".
906
907         * Scripts/webkitpy/tool/commands/queries.py:
908         (FindFlakyTests._print_statistics):
909
910 2015-11-30  Alex Christensen  <achristensen@webkit.org>
911
912         Make ProcessModel always MultipleSecondaryProcesses
913         https://bugs.webkit.org/show_bug.cgi?id=151662
914
915         Reviewed by Antti Koivisto.
916
917         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
918         (TestWebKitAPI::TEST):
919         * WebKitTestRunner/TestController.cpp:
920         (WTR::TestController::generatePageConfiguration):
921
922 2015-11-30  Alex Christensen  <achristensen@webkit.org>
923
924         Make usesNetworkProcess always true
925         https://bugs.webkit.org/show_bug.cgi?id=151580
926
927         Reviewed by Darin Adler.
928
929         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
930         (TestWebKitAPI::TEST):
931         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
932         (TestWebKitAPI::TEST):
933         * WebKitTestRunner/TestController.cpp:
934         (WTR::TestController::generatePageConfiguration):
935
936 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
939
940         Add a way to skip unit tests only for Debug or Release builds and
941         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
942
943         * Scripts/run-gtk-tests:
944         (SkippedTest):
945         (SkippedTest.__init__):
946         (SkippedTest.__str__):
947         (SkippedTest.skip_entire_suite):
948         (SkippedTest.skip_for_build_type):
949         (TestRunner):
950         (TestRunner.__init__):
951
952 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
953
954         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
955
956         It's an assert hit because we are reloading a view loaded with
957         HTML data which is not supported. Use loadURI instead.
958
959         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
960         (testWebViewCustomCharset):
961
962 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
963
964         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
965         https://bugs.webkit.org/show_bug.cgi?id=151633
966
967         Reviewed by Csaba Osztrogonác.
968
969         * TestWebKitAPI/PlatformGTK.cmake:
970         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
971
972 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
973
974         [GTK] Remove the remaining uses of GMainLoopSource
975         https://bugs.webkit.org/show_bug.cgi?id=151632
976
977         Reviewed by Žan Doberšek.
978
979         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
980         (testWebViewSyncRequestOnMaxConns):
981         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
982         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
983         (WTR::TestRunner::TestRunner):
984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
985         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
986         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
987         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
988         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
989         (WTR::timeoutSource):
990         (WTR::TestController::notifyDone):
991         (WTR::TestController::platformRunUntil):
992
993 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
994
995         [cmake] Add testb3 to the build system
996         https://bugs.webkit.org/show_bug.cgi?id=151619
997
998         Reviewed by Gyuyoung Kim.
999
1000         * Scripts/build-jsc:
1001
1002 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1003
1004         [jhbuild] Fix pixman build with clang
1005         https://bugs.webkit.org/show_bug.cgi?id=151441
1006
1007         Reviewed by Carlos Garcia Campos.
1008
1009         * efl/jhbuild.modules:
1010         * gtk/jhbuild.modules:
1011
1012 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1013
1014         Extract prependToEnvironmentVariableList
1015         <http://webkit.org/b/151536>
1016
1017         Reviewed by Daniel Bates.
1018
1019         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1020                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1021
1022         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1023         and prependToEnvironmentVariableList.
1024         (appendToEnvironmentVariableList): Simplify variable name.
1025         Switch to use $Config{path_sep}.
1026         (prependToEnvironmentVariableList): Add new method.
1027         (setupMacWebKitEnvironment): Switch to use
1028         prependToEnvironmentVariableList().
1029         (setupIOSWebKitEnvironment): Ditto.
1030
1031         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1032         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1033
1034 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1035
1036         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1037         https://bugs.webkit.org/show_bug.cgi?id=151567
1038
1039         Reviewed by Darin Adler.
1040
1041         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1042         (on_window_deletion):
1043
1044 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1045
1046         [GTK] Use the network process unconditionally
1047         https://bugs.webkit.org/show_bug.cgi?id=151541
1048
1049         Reviewed by Alex Christensen.
1050
1051         Fix TestInspectorServer test. Do not assume we already have the
1052         title we want when the page has been loaded, since the title is
1053         changed afterwards. So, check if the title has already been set,
1054         and if not wait for it.
1055
1056         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1057         (openRemoteDebuggingSession):
1058
1059 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1060
1061         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1062         https://bugs.webkit.org/show_bug.cgi?id=151532
1063
1064         Reviewed by Benjamin Poulain.
1065
1066         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1067         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1068         (TestWebKitAPI::TEST):
1069         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1070         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1071         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1072         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1073         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1074         so it was calling a function on a test object that had gone out of scope.
1075         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1076         but that will become the default soon and that call will be removed.
1077
1078 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1079
1080         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1081         <http://webkit.org/b/151542>
1082
1083         Reviewed by Daniel Bates.
1084
1085         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1086         (base_url): Use the Port object (already passed in) to give us
1087         the path to the LayoutTests directory, which already checks for a
1088         --layout-tests-directory command-line switch.
1089         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1090         argument since we can get this from the Port object already
1091         passed in via Port.results_directory().  Also switch to use
1092         Port.layout_tests_dir() to get the LayoutTests directory.
1093
1094         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1095         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1096         Add test case for custom LayoutTests directory.
1097         (TestWebPlatformTestServer.test_previously_spawned_instance):
1098         Update Port object to set mock results directory as if it was
1099         set on the command-line.  Remove unneeded argument from
1100         WebPlatformTestServer constructor.
1101         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1102
1103         * Scripts/webkitpy/port/base.py:
1104         (Port.to.start_web_platform_test_server): Remove unneeded
1105         argument from WebPlatformTestServer constuctor.
1106
1107 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1108
1109         [GTK] Some unit tests fail when using the network process
1110         https://bugs.webkit.org/show_bug.cgi?id=151490
1111
1112         Reviewed by Martin Robinson.
1113
1114         Run the soup server in a separate thread in TestResources test to
1115         avoid deadlocks.
1116
1117         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1118         /webkit2/WebKitWebResource/get-data when using the network process.
1119
1120         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1121         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1122         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1123         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1124         present, create a WorkQueue to run the server.
1125         (WebKitTestServer::run): Run the server in the work queue if it
1126         has been created.
1127         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1128         type into server options as flags.
1129
1130 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         [GTK] ImageDiff should normalize the diff image
1133         https://bugs.webkit.org/show_bug.cgi?id=151261
1134
1135         Reviewed by Sergio Villar Senin.
1136
1137         * ImageDiff/gtk/ImageDiff.cpp:
1138         (readPixbufFromStdin): Fix memory leak.
1139         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1140         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1141
1142 == Rolled over to ChangeLog-2015-11-21 ==