Unreviewed, reorder my emails to fix autocomplete in bugzilla
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2
3         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2019-01-28  Andy Estes  <aestes@apple.com>
8
9         [watchOS] Enable Parental Controls content filtering
10         https://bugs.webkit.org/show_bug.cgi?id=193939
11         <rdar://problem/46641912>
12
13         Reviewed by Ryosuke Niwa.
14
15         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
16
17 2019-01-28  David Kilzer  <ddkilzer@apple.com>
18
19         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
20         <https://webkit.org/b/193884>
21
22         Reviewed by Jiewen Tan.
23
24         * Scripts/webkitpy/style/checkers/cpp.py:
25         (check_language): Add LocalAuthentication to
26         `frameworks_with_soft_links`.
27
28 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
29
30         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
31         https://bugs.webkit.org/show_bug.cgi?id=193891
32
33         Reviewed by Ross Kirsling.
34
35         There were three problems in window sizes of WebView and the host window.
36         1. The sizes of pixel image output were incorrect.
37         2. The host window is going to appear after window.resize was invoked.
38         3. window.resize resized only the host window, not WebView.
39
40         This change solves them with a following approach.
41         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
42         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
43            as well as DumpRenderTree in order to match the client area and the window area.
44         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
45         d. PlatformWebView::setWindowFrame changes both window sizes.
46         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
47
48         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
49         (WTR::PlatformWebView::PlatformWebView): Create the host window
50         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
51         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
52         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
53
54 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
55
56         [ews-app] Add method to save Step data to database
57         https://bugs.webkit.org/show_bug.cgi?id=193890
58
59         Reviewed by Lucas Forschler.
60
61         * BuildSlaveSupport/ews-app/ews/models/step.py:
62         (Step.save_step): Method to save step data.
63         (Step.update_step): Method to update step data.
64         (Step.get_existing_step): Method to fetch existing step from database.
65         (Step.is_valid_result): Method to validate valid step result.
66
67 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
68
69         [ews-app] Add method to save Build data to database
70         https://bugs.webkit.org/show_bug.cgi?id=193735
71
72         Reviewed by Lucas Forschler.
73
74         * BuildSlaveSupport/ews-app/ews/models/build.py:
75         (Build.save_build): Method to save build information to database.
76         (Build.get_existing_build): Method to fetch existing build from database.
77         (Build.is_valid_result): Method to validate build result.
78         * BuildSlaveSupport/ews-app/ews/common/util.py:
79         (is_valid_int_id): Method to validate valid id.
80
81 2019-01-28  Chris Dumez  <cdumez@apple.com>
82
83         Regression(PSON) Crash under WebPageProxy::didStartProgress()
84         https://bugs.webkit.org/show_bug.cgi?id=193915
85         <rdar://problem/47560907>
86
87         Reviewed by Alex Christensen.
88
89         Add API test coverage.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
92
93 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
94
95         [ews-app] Rename id variables
96         https://bugs.webkit.org/show_bug.cgi?id=193883
97
98         Reviewed by Lucas Forschler.
99
100         * BuildSlaveSupport/ews-app/ews/models/build.py:
101         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
102         * BuildSlaveSupport/ews-app/ews/models/step.py:
103         * BuildSlaveSupport/ews-app/ews/urls.py:
104         * BuildSlaveSupport/ews-app/ews/views/patch.py:
105         * BuildSlaveSupport/ews-app/ews/views/results.py:
106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
107
108 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
109
110         [ews-app] Allow certain fields to be empty
111         https://bugs.webkit.org/show_bug.cgi?id=193892
112
113         Reviewed by Lucas Forschler.
114
115         * BuildSlaveSupport/ews-app/ews/models/build.py:
116         * BuildSlaveSupport/ews-app/ews/models/step.py:
117
118 2019-01-28  Rob Buis  <rbuis@igalia.com>
119
120         Update MIME type parser
121         https://bugs.webkit.org/show_bug.cgi?id=180526
122
123         Reviewed by Frédéric Wang.
124
125         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
126         (TestWebKitAPI::TEST):
127
128 2019-01-28  Zalan Bujtas  <zalan@apple.com>
129
130         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
131         https://bugs.webkit.org/show_bug.cgi?id=193896
132
133         Reviewed by Antti Koivisto.
134
135         * LayoutReloaded/misc/LFC-passing-tests.txt:
136
137 2018-12-15  Darin Adler  <darin@apple.com>
138
139         Replace many uses of String::format with more type-safe alternatives
140         https://bugs.webkit.org/show_bug.cgi?id=192742
141
142         Reviewed by Mark Lam.
143
144         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
145         (WTR::cacheTestRunnerCallback): Use makeString.
146         * WebKitTestRunner/TestController.cpp:
147         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
148         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
149
150 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
151
152         Use a load optimizer for some sites
153         https://bugs.webkit.org/show_bug.cgi?id=193881
154         <rdar://problem/46325455>
155
156         Reviewed by Brent Fulgham.
157
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
160
161 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
162
163         AX: Introduce a static accessibility tree
164         https://bugs.webkit.org/show_bug.cgi?id=193348
165         <rdar://problem/47203295>
166
167         Reviewed by Ryosuke Niwa.
168
169         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
170
171 2019-01-26  Zalan Bujtas  <zalan@apple.com>
172
173         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
174         https://bugs.webkit.org/show_bug.cgi?id=193867
175
176         Reviewed by Antti Koivisto.
177
178         * LayoutReloaded/misc/LFC-passing-tests.txt:
179
180 2019-01-26  Zalan Bujtas  <zalan@apple.com>
181
182         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
183         https://bugs.webkit.org/show_bug.cgi?id=193865
184
185         Reviewed by Antti Koivisto.
186
187         * LayoutReloaded/misc/LFC-passing-tests.txt:
188
189 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
190
191         Need a mechanism to override navigator.userAgent
192         https://bugs.webkit.org/show_bug.cgi?id=193762
193         <rdar://problem/47504939>
194
195         Reviewed by Brent Fulgham.
196
197         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
198
199         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
200         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
201         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
202
203 2019-01-25  Dean Jackson  <dino@apple.com>
204
205         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
206         https://bugs.webkit.org/show_bug.cgi?id=193831
207         <rdar://problem/47399263>
208
209         Reviewed by Chris Dumez.
210
211         Two new tests that exercise cross-origin and same-origin System
212         Previews.
213
214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
215
216 2019-01-25  Keith Rollin  <krollin@apple.com>
217
218         Update Xcode projects with "Check .xcfilelists" build phase
219         https://bugs.webkit.org/show_bug.cgi?id=193790
220         <rdar://problem/47201374>
221
222         Reviewed by Alex Christensen.
223
224         Support for XCBuild includes specifying inputs and outputs to various
225         Run Script build phases. These inputs and outputs are specified as
226         .xcfilelist files. Once created, these .xcfilelist files need to be
227         kept up-to-date. In order to check that they are up-to-date or not,
228         add an Xcode build step that invokes an external script that performs
229         the checking. If the .xcfilelists are found to be out-of-date, update
230         them, halt the build, and instruct the developer to restart the build
231         with up-to-date files.
232
233         At this time, the checking and regenerating is performed only if the
234         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
235         who want to use this facility can set this variable and test out the
236         checking/regenerating. Once it seems like there are no egregious
237         issues that upset a developer's workflow, we'll unconditionally enable
238         this facility.
239
240         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
241         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
242         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
243         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
244
245 2019-01-25  Keith Rollin  <krollin@apple.com>
246
247         Update Xcode projects with "Apply Configuration to XCFileLists" build target
248         https://bugs.webkit.org/show_bug.cgi?id=193781
249         <rdar://problem/47201153>
250
251         Reviewed by Alex Christensen.
252
253         Part of generating the .xcfilelists used as part of adopting XCBuild
254         includes running `make DerivedSources.make` from a standalone script.
255         It’s important for this invocation to have the same environment as
256         when the actual build invokes `make DerivedSources.make`. If the
257         environments are different, then the two invocations will provide
258         different results. In order to get the same environment in the
259         standalone script, have the script launch xcodebuild targeting the
260         "Apply Configuration to XCFileLists" build target, which will then
261         re-invoke our standalone script. The script is now running again, this
262         time in an environment with all workspace, project, target, xcconfig
263         and other environment variables established.
264
265         The "Apply Configuration to XCFileLists" build target accomplishes
266         this task via a small embedded shell script that consists only of:
267
268             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
269
270         The process that invokes "Apply Configuration to XCFileLists" first
271         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
272         evaluated and exports it into the shell environment. When xcodebuild
273         is invoked, it inherits the value of this variable and can `eval` the
274         contents of that variable. Our external standalone script can then set
275         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
276         of command-line parameters needed to restart itself in the appropriate
277         state.
278
279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
280         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
281
282 2019-01-25  Alex Christensen  <achristensen@webkit.org>
283
284         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
285         https://bugs.webkit.org/show_bug.cgi?id=193802
286         <rdar://problem/46010580>
287
288         Reviewed by Andy Estes.
289
290         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
291         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
292         (TEST):
293
294 2019-01-25  Daniel Bates  <dabates@apple.com>
295
296         [iOS] uiController.keyDown() does not translate Control modified key
297         https://bugs.webkit.org/show_bug.cgi?id=192898
298
299         Reviewed by Wenson Hsieh.
300
301         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
302         key translation, as applicable. Among other cases, key translation occurs when performing
303         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
304         also makes the behavior of uiController.keyDown() more closely match the behavior of a
305         human pressing down and releasing key(s) using a hardware keyboard.
306
307         * WebKitTestRunner/ios/HIDEventGenerator.h:
308         * WebKitTestRunner/ios/HIDEventGenerator.mm:
309         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
310
311         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
312         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
313         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
314         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
315         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
316         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
317         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
318         (-[HIDEventGenerator longPress:completionBlock:]):
319         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
320         Update code for above renaming.
321
322         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
323         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
324
325         (-[HIDEventGenerator keyDown:]): Added.
326         (-[HIDEventGenerator keyUp:]): Added.
327         (-[HIDEventGenerator keyPress:completionBlock:]):
328         (-[HIDEventGenerator eventDispatchThreadEntry:]):
329         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
330         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
331         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
332         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
333         (WTR::parseModifier): Deleted.
334
335 2019-01-25  Keith Rollin  <krollin@apple.com>
336
337         Complete the implementation of generate-xcfilelists
338         https://bugs.webkit.org/show_bug.cgi?id=193782
339
340         Reviewed by Alex Christensen.
341
342         A preliminary version of generate-xcfilelists was added in r238008.
343         This patch updates that script in order to:
344
345         - Support checking of .xcfilelists
346         - Perform better execution of `make DerivedSources.make` by
347           relaunching generate-xcfilelists under xcodebuild
348         - Support incremental generation and checking of .xcfilelists
349         - Support supplementary .xcfilelists files from WebKitAdditions
350         - Support being wrapped by parallel version of generate-xcfilelists in
351           Internal that adds support for (re)generating WebKit projects in
352           that repo.
353         - Support builds that have been performed in WebKitBuild as well as
354           ~/Library/Developer/code/DerivedData
355         - Increase robustness and debugging facilities.
356
357         * Scripts/generate-xcfilelists:
358
359 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
360
361         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
362         https://bugs.webkit.org/show_bug.cgi?id=193297
363         <rdar://problem/47158841>
364
365         Unreviewed test case fix.
366
367         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
368         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
371         (TEST):
372
373 2019-01-25  Keith Rollin  <krollin@apple.com>
374
375         Update existing .xcfilelists
376         https://bugs.webkit.org/show_bug.cgi?id=193791
377         <rdar://problem/47201706>
378
379         Reviewed by Alex Christensen.
380
381         Many .xcfilelist files were added in r238824 in order to support
382         XCBuild. Update these with recent changes to the set of build files
383         and with the current generate-xcfilelist script.
384
385         * DumpRenderTree/DerivedSources-input.xcfilelist:
386         * DumpRenderTree/DerivedSources-output.xcfilelist:
387         * WebKitTestRunner/DerivedSources-input.xcfilelist:
388         * WebKitTestRunner/DerivedSources-output.xcfilelist:
389
390 2019-01-25  Keith Rollin  <krollin@apple.com>
391
392         Fix missing dependencies in extract-dependencies-from-makefile
393         https://bugs.webkit.org/show_bug.cgi?id=193783
394         <rdar://problem/47201571>
395
396         Reviewed by Alex Christensen.
397
398         The extract-dependencies-from-makefile script generates .xcfilelists
399         for XCBuild by invoking a makefile in --debug mode, parsing the
400         dependency information in the output, and extracting information
401         regarding targets and dependents. However, the way `make` emits this
402         dependency information is not rigorous, and so we need to determine
403         what lines to look for and parse by trial and error. This approach
404         didn't coriginally atch all the information we needed to collect, so
405         update the script to look for the additional lines we now know to look
406         for.
407
408         * Scripts/extract-dependencies-from-makefile:
409         (Parser):
410         (Parser.addTarget):
411         (Parser.addPrereq):
412         (Parser.doParse):
413
414 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
415
416         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
417         https://bugs.webkit.org/show_bug.cgi?id=193297
418         <rdar://problem/47158841>
419
420         Reviewed by Alex Christensen.
421
422         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
423             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
424         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
425         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
426         activating the message used to trigger the callback when it is set.
427
428 2019-01-25  Alex Christensen  <achristensen@webkit.org>
429
430         WKWebView.goBack should reload if there is a safe browsing warning
431         https://bugs.webkit.org/show_bug.cgi?id=193805
432         <rdar://problem/46908216>
433
434         Reviewed by Geoff Garen.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
437         (+[Simple3LookupContext sharedLookupContext]):
438         (-[Simple3LookupContext lookUpURL:completionHandler:]):
439         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
440         (TEST):
441
442 2019-01-25  Chris Dumez  <cdumez@apple.com>
443
444         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
445         https://bugs.webkit.org/show_bug.cgi?id=193788
446         <rdar://problem/47531231>
447
448         Reviewed by Alex Christensen.
449
450         Add API test coverage.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
453         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
454
455 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
456
457         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
458         https://bugs.webkit.org/show_bug.cgi?id=193771
459
460         Unreviewed infrastructure fix.
461
462         * Scripts/webkitpy/port/darwin.py:
463         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
464
465 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
466
467         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
468
469 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
470
471         Add contributors.json entries for Ling Ho and for a new bot watchers group.
472
473         * Scripts/webkitpy/common/config/contributors.json:
474
475 2019-01-25  Chris Dumez  <cdumez@apple.com>
476
477         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
478         https://bugs.webkit.org/show_bug.cgi?id=193779
479         <rdar://problem/46170903>
480
481         Reviewed by Antti Koivisto.
482
483         Add API test that quickly navigates forward to a previous process without waiting for it to
484         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
485         the process' previous page when reconnecting the it for the forward navigation.
486
487         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
488
489 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
490
491         Need a way for JavaScript (or bundle) code to participate in undo
492         https://bugs.webkit.org/show_bug.cgi?id=190009
493         <rdar://problem/44807048>
494
495         Reviewed by Ryosuke Niwa.
496
497         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
498         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
499
500         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
501         (WTR::UIScriptController::lastUndoLabel const):
502         (WTR::UIScriptController::firstRedoLabel const):
503         (WTR::UIScriptController::platformUndoManager const):
504         * DumpRenderTree/mac/UIScriptControllerMac.mm:
505         (WTR::UIScriptController::lastUndoLabel const):
506         (WTR::UIScriptController::firstRedoLabel const):
507         (WTR::UIScriptController::platformUndoManager const):
508         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
509         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
510         (WTR::UIScriptController::lastUndoLabel const):
511         (WTR::UIScriptController::firstRedoLabel const):
512         * TestRunnerShared/UIScriptContext/UIScriptController.h:
513         * WebKitTestRunner/UIScriptControllerCocoa.mm:
514         (WTR::UIScriptController::lastUndoLabel const):
515         (WTR::UIScriptController::firstRedoLabel const):
516         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
517         (WTR::UIScriptController::platformUndoManager const):
518         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
519         (WTR::UIScriptController::platformUndoManager const):
520
521 2019-01-25  Zalan Bujtas  <zalan@apple.com>
522
523         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
524         https://bugs.webkit.org/show_bug.cgi?id=193824
525
526         Reviewed by Antti Koivisto.
527
528         * LayoutReloaded/misc/LFC-passing-tests.txt:
529
530 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
531
532         Update macOS JSC bot configurations
533         https://bugs.webkit.org/show_bug.cgi?id=193739
534
535         Reviewed by Alexey Proskuryakov.
536
537         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
539         (BubbleQueueServer): Move JSC EWS to Mojave section.
540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
541         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
542         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
543
544 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
545
546         [Win][WebKitTestRunner] Implement EventSenderProxy
547         https://bugs.webkit.org/show_bug.cgi?id=193755
548
549         Reviewed by Don Olmstead.
550
551         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
552         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
553         (WTR::EventSenderProxy::dispatchMessage):
554         (WTR::EventSenderProxy::EventSenderProxy):
555         (WTR::EventSenderProxy::mouseDown):
556         (WTR::EventSenderProxy::mouseUp):
557         (WTR::EventSenderProxy::mouseMoveTo):
558         (WTR::EventSenderProxy::mouseScrollBy):
559         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
560
561 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
562
563         Unreviewed fix for API test failure after r240437.
564
565         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
566
567         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
568
569 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
570
571         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
572         https://bugs.webkit.org/show_bug.cgi?id=193787
573         <rdar://problem/47497634>
574
575         Reviewed by Alexey Proskuryakov.
576
577         * Scripts/webkitdirs.pm:
578         (iosSimulatorApplicationsPath): Pick from available runtime directories.
579
580 2019-01-24  Truitt Savell  <tsavell@apple.com>
581
582         Unreviewed, rolling out r240446.
583
584         Casued 5 API failures
585
586         Reverted changeset:
587
588         "Activate the WebResourceLoadStatisticsStore in the
589         NetworkProcess and deactivate it in the UIProcess."
590         https://bugs.webkit.org/show_bug.cgi?id=193297
591         https://trac.webkit.org/changeset/240446
592
593 2019-01-24  Zalan Bujtas  <zalan@apple.com>
594
595         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
596         https://bugs.webkit.org/show_bug.cgi?id=193741
597         <rdar://problem/47135030>
598
599         Reviewed by Antti Koivisto and Simon Fraser.
600
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
603         (TestWebKitAPI::TEST):
604
605 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
606
607         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
608         https://bugs.webkit.org/show_bug.cgi?id=193297
609         <rdar://problem/47158841>
610
611         Reviewed by Alex Christensen.
612
613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
614         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
615         activating the message used to trigger the callback when it is set.
616
617 2019-01-24  John Wilander  <wilander@apple.com>
618
619         Add Ad Click Attribution as an internal/experimental feature
620         https://bugs.webkit.org/show_bug.cgi?id=193685
621         <rdar://problem/47450399>
622
623         Reviewed by Brent Fulgham.
624
625         Added test option adClickAttributionEnabled.
626
627         * DumpRenderTree/TestOptions.cpp:
628         (TestOptions::TestOptions):
629         * DumpRenderTree/TestOptions.h:
630         * DumpRenderTree/mac/DumpRenderTree.mm:
631         (setWebPreferencesForTestOptions):
632
633 2019-01-24  Antti Koivisto  <antti@apple.com>
634
635         [PSON] Flash on back navigation on Mac
636         https://bugs.webkit.org/show_bug.cgi?id=193716
637         <rdar://problem/47148458>
638
639         Reviewed by Chris Dumez.
640
641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
642
643         Closing of the previous page is delayed so waiting for didFinishNavigation is
644         not sufficient to guarantee we have received all the messages. Wait for them.
645
646 2019-01-24  Chris Dumez  <cdumez@apple.com>
647
648         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
649         https://bugs.webkit.org/show_bug.cgi?id=193761
650         <rdar://problem/47456405>
651
652         Reviewed by Alex Christensen.
653
654         Add API test coverage.
655
656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
657
658 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
659
660         webkitpy: Missing PID in crashlog name should not be fatal
661         https://bugs.webkit.org/show_bug.cgi?id=193771
662
663         If we can't determine the PID of a crashlog, just ignore the crashlog instead
664         of raising an exception.
665
666         Reviewed by Lucas Forschler.
667
668         * Scripts/webkitpy/port/darwin.py:
669         (DarwinPort._merge_crash_logs):
670
671 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
672
673         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
674         https://bugs.webkit.org/show_bug.cgi?id=193746
675
676         Reviewed by Youenn Fablet.
677
678         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
679         so we'd best just not call it.
680
681         * Scripts/webkitpy/w3c/test_exporter.py:
682         (WebPlatformTestExporter.create_branch_with_patch):
683
684 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
685
686         Move FileSystem to WTF
687         https://bugs.webkit.org/show_bug.cgi?id=193602
688
689         Reviewed by Yusuke Suzuki.
690
691         * DumpRenderTree/win/DumpRenderTree.cpp:
692         * TestWebKitAPI/CMakeLists.txt:
693         * TestWebKitAPI/PlatformGTK.cmake:
694         * TestWebKitAPI/PlatformJSCOnly.cmake:
695         * TestWebKitAPI/PlatformPlayStation.cmake:
696         * TestWebKitAPI/PlatformWPE.cmake:
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
699         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
700         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
701         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
702         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
703         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
704         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
705         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
706         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
707
708 2019-01-24  Philippe Normand  <pnormand@igalia.com>
709
710         [WPE] Remove hard dependency on subprocess32 for the API tests
711
712         Rubber-stamped by Carlos Garcia Campos.
713
714         * glib/api_test_runner.py:
715         (TestRunner._run_test_qt): Lazily import subprocess32 and check
716         its presence only when running WPEQt tests.
717
718 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
719
720         [GLIB] Expose JavaScriptCore options in GLib public API
721         https://bugs.webkit.org/show_bug.cgi?id=188742
722
723         Reviewed by Michael Catanzaro.
724
725         Add a test for the new API.
726
727         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
728         (testsJSCOptions):
729         (main):
730
731 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
732
733         [GTK][WPE] Support JPEG 2000 images
734         https://bugs.webkit.org/show_bug.cgi?id=186272
735
736         Reviewed by Žan Doberšek.
737
738         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
739
740         * gtk/jhbuild.modules:
741         * wpe/jhbuild.modules:
742
743 2019-01-23  David Kilzer  <ddkilzer@apple.com>
744
745         check-webkit-style should warn when using soft-linking macros in a header
746         <https://webkit.org/b/193750>
747
748         Reviewed by Darin Adler.
749
750         * Scripts/webkitpy/style/checkers/cpp.py:
751         (check_language): Add softlink/header check by refactoring the
752         softlink/framework check.
753         (CppChecker): Enable softlink/header check by default.
754         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
755         (CppStyleTest.test_softlink_framework): Rename from
756         CppStyleTest.test_softlink() and change test framework name in
757         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
758         files. Set file_name for macros that only appear in headers.
759         (CppStyleTest.test_softlink_header): Add tests for using
760         soft-link macros in headers.
761
762 2019-01-23  Chris Dumez  <cdumez@apple.com>
763
764         Deprecate API to limit the maximum number of WebProcesses
765         https://bugs.webkit.org/show_bug.cgi?id=193725
766         <rdar://problem/47464879>
767
768         Reviewed by Geoff Garen.
769
770         Update existing API tests to stop using deprecated API.
771
772         * MiniBrowser/mac/AppDelegate.m:
773         (defaultConfiguration):
774         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
775         (TestWebKitAPI::TEST):
776         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
777         (TestWebKitAPI::TEST):
778         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
779         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
780         (TEST):
781         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
782         (TEST):
783
784 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-app] Rename ews model buildermappings to buildermapping
787         https://bugs.webkit.org/show_bug.cgi?id=193729
788
789         Reviewed by Lucas Forschler.
790
791         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
792         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
793         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
794
795 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-app] Rename ews model steps to step
798         https://bugs.webkit.org/show_bug.cgi?id=193697
799
800         Reviewed by Lucas Forschler.
801
802         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
803         (Step): Renamed Steps to Step.
804
805 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
806
807         Clean up IndexedDB files between tests
808         https://bugs.webkit.org/show_bug.cgi?id=192796
809         <rdar://problem/46824999>
810
811         Reviewed by Geoffrey Garen.
812
813         * DumpRenderTree/mac/DumpRenderTree.mm:
814         (runTest):
815         * WebKitTestRunner/TestController.cpp:
816         (WTR::TestController::resetStateToConsistentValues):
817         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
818         (WTR::RemoveAllIndexedDatabasesCallback):
819         (WTR::TestController::ClearIndexedDatabases):
820         * WebKitTestRunner/TestController.h:
821         * WebKitTestRunner/TestInvocation.cpp:
822         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
823
824 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
825
826         [ews-app] Rename ews model Builds to Build
827         https://bugs.webkit.org/show_bug.cgi?id=193695
828
829         Reviewed by Lucas Forschler.
830
831         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
832         (Build): Renamed Builds to Build.
833
834 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
835
836         webkitpy: Wait longer when launching WebKitTestRunner
837         https://bugs.webkit.org/show_bug.cgi?id=193734
838
839         Reviewed by Aakash Jain.
840
841         * Scripts/webkitpy/port/simulator_process.py:
842         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
843
844 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
847         https://bugs.webkit.org/show_bug.cgi?id=193182
848         <rdar://problem/47452154>
849
850         Reviewed by Tim Horton.
851
852         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
853         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
854         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
855
856         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
857         preventing later tests from recognizing gestures.
858
859         * WebKitTestRunner/ios/TestControllerIOS.mm:
860         (WTR::TestController::platformResetStateToConsistentValues):
861
862         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
863
864 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
865
866         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
867         https://bugs.webkit.org/show_bug.cgi?id=193722
868         <rdar://problem/47481475>
869
870         Reviewed by Lucas Forschler.
871
872         iPhone and iPad ports should both use the iOS config.
873
874         * Scripts/webkitpy/port/ios_simulator.py:
875         (IPhoneSimulatorPort.__init__):
876         (IPadSimulatorPort.__init__):
877
878 2019-01-23  Rob Buis  <rbuis@igalia.com>
879
880         Update MIME type parser
881         https://bugs.webkit.org/show_bug.cgi?id=180526
882
883         Reviewed by Frédéric Wang.
884
885         Add unit tests for both parse modes of ParsedContentType.
886
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
889         (TestWebKitAPI::TEST):
890
891 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-app] fetch loop should not stop on network issues
894         https://bugs.webkit.org/show_bug.cgi?id=193666
895
896         Reviewed by Lucas Forschler.
897
898         * BuildSlaveSupport/ews-app/ews/fetcher.py:
899         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
900
901 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
902
903         [iOS] Multiple WKWebViewAutofillTests are flaky failures
904         https://bugs.webkit.org/show_bug.cgi?id=189165
905         <rdar://problem/47433765>
906
907         Reviewed by Tim Horton.
908
909         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
910         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
911         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
912         process in sufficient to ensure that any previous action that blurred the focused element in the web process
913         would make its way to the UI process by the time the layer tree commit is finished.
914
915         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
916         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
917         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
918         will fail because it asks for -_autofillContext too early.
919
920         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
921         is handled in the UI process.
922
923         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
924
925         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
926         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
927         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
928         input session.
929
930         (-[AutofillTestView textInputHasAutofillContext]):
931
932         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
933
934         * TestWebKitAPI/cocoa/TestWKWebView.h:
935         * TestWebKitAPI/cocoa/TestWKWebView.mm:
936         (nextInputSessionChangeCount):
937
938         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
939         This includes changing the focused element from one to another.
940
941         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
942         (-[TestWKWebView didStartFormControlInteraction]):
943         (-[TestWKWebView didEndFormControlInteraction]):
944         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
945
946         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
947         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
948         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
949         that doesn't require an input session to one that doesn't.
950
951 2019-01-22  David Kilzer  <ddkilzer@apple.com>
952
953         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
954         <https://webkit.org/b/193676>
955
956         Reviewed by Alexey Proskuryakov.
957
958         * Scripts/webkitpy/style/checkers/cpp.py:
959         (check_member_initialization_list):
960         - Don't report missing whitespace around colon if the colon at
961           the start of the line is formatted correctly.
962         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
963         (WebKitStyleTest.test_member_initialization_list):
964         - Add a test for a missing permutation of existing tests.
965         - Add a test this false-positive.
966         - Add blank lines between subtests to make them easier to read.
967
968 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
969
970         [build.webkit.org] Unit-test failure after r237113
971         https://bugs.webkit.org/show_bug.cgi?id=193669
972
973         Reviewed by Michael Catanzaro.
974
975         * BuildSlaveSupport/build.webkit.org-config/factories.py:
976         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
977         multiple or zero flags.
978
979 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
980
981         Cache bytecode to disk
982         https://bugs.webkit.org/show_bug.cgi?id=192782
983         <rdar://problem/46084932>
984
985         Reviewed by Keith Miller.
986
987         Add test helper to execute bytecode-cache tests: it executes each test
988         twice, the first with JSC_diskCachePath set to a temporary directory
989         and second with JSC_forceDiskCache=true (in addition to the cache path)
990         to guarantee that only the disk cache is being used and no new
991         UnlinkedCodeBlocks are being created.
992
993         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
994         * Scripts/run-jsc-stress-tests:
995
996 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
997
998         [css-logical] Implement flow-relative margin, padding and border shorthands
999         https://bugs.webkit.org/show_bug.cgi?id=188697
1000
1001         Reviewed by Simon Fraser and Antti Koivisto.
1002
1003         * DumpRenderTree/TestOptions.cpp:
1004         (TestOptions::TestOptions):
1005         * DumpRenderTree/TestOptions.h:
1006         * DumpRenderTree/mac/DumpRenderTree.mm:
1007         (setWebPreferencesForTestOptions):
1008         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1009
1010         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1011         (JSONCSSPropertiesChecker.check_codegen_properties):
1012         Allow CSS property definitions to have a 'runtime-flag' parameter which
1013         disables the property when the specified runtime flag is disabled.
1014
1015 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1016
1017         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1018         https://bugs.webkit.org/show_bug.cgi?id=193643
1019
1020         Reviewed by Michael Catanzaro.
1021
1022         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1023         * wpe/jhbuild.modules: Ditto.
1024
1025 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1026
1027         [LFC][Floats] Take float top position into account when computing containing block height.
1028         https://bugs.webkit.org/show_bug.cgi?id=193655
1029
1030         Reviewed by Antti Koivisto.
1031
1032         * LayoutReloaded/misc/LFC-passing-tests.txt:
1033
1034 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1035
1036         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1037         <https://webkit.org/b/193645>
1038         <rdar://problem/47421574>
1039
1040         Reviewed by Alex Christensen.
1041
1042         - Now checks for local soft-linking of all frameworks that have
1043           their own *SoftLinking.{cpp,h,mm} files.
1044         - Changes softlink/uikit warning to softlink/framework.
1045
1046         * Scripts/webkitpy/style/checkers/cpp.py:
1047         (check_language):
1048         (CppChecker):
1049         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1050         (CppStyleTest):
1051
1052 2019-01-20  Saam Barati  <sbarati@apple.com>
1053
1054         Rollout r240210: It broke tests on iOS
1055         https://bugs.webkit.org/show_bug.cgi?id=193640
1056
1057         Unreviewed.
1058
1059         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1060         * Scripts/run-jsc-stress-tests:
1061
1062 2019-01-20  chris fleizach  <cfleizach@apple.com>
1063
1064         AX: Support returning relative frames for accessibility
1065         https://bugs.webkit.org/show_bug.cgi?id=193414
1066         <rdar://problem/47268501>
1067
1068         Reviewed by Zalan Bujtas.
1069
1070         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1071         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1072         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1073         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1074         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1075         (WTR::attributesOfElement):
1076         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1077
1078 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1079
1080         Unreviewed, add my new email address
1081
1082         * Scripts/webkitpy/common/config/contributors.json:
1083
1084 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1085
1086         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1087         https://bugs.webkit.org/show_bug.cgi?id=193617
1088
1089         Reviewed by Antti Koivisto.
1090
1091         * LayoutReloaded/misc/LFC-passing-tests.txt:
1092
1093 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1094
1095         Unreviewed, rolling out r240209.
1096
1097         Broke GTK/WPE injected bundle
1098
1099         Reverted changeset:
1100
1101         "AX: Support returning relative frames for accessibility"
1102         https://bugs.webkit.org/show_bug.cgi?id=193414
1103         https://trac.webkit.org/changeset/240209
1104
1105 2019-01-12  Dan Bernstein  <mitz@apple.com>
1106
1107         [Cocoa] Avoid importing directly from subumbrella frameworks
1108         https://bugs.webkit.org/show_bug.cgi?id=186016
1109         <rdar://problem/40591038>
1110
1111         Reviewed by Sam Weinig.
1112
1113         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1114           LaunchServices header.
1115         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1116           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1117         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1118           when using SDKs earlier than 10.13.
1119         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1120           and OTHER_CPLUSPLUSFLAGS.
1121         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1122           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1123         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1124           LaunchServices header.
1125
1126 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1127
1128         Cache bytecode to disk
1129         https://bugs.webkit.org/show_bug.cgi?id=192782
1130         <rdar://problem/46084932>
1131
1132         Reviewed by Keith Miller.
1133
1134         Add test helper to execute bytecode-cache tests: it executes each test
1135         twice, the first with JSC_diskCachePath set to a temporary directory
1136         and second with JSC_forceDiskCache=true (in addition to the cache path)
1137         to guarantee that only the disk cache is being used and no new
1138         UnlinkedCodeBlocks are being created.
1139
1140         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1141         * Scripts/run-jsc-stress-tests:
1142
1143 2019-01-20  chris fleizach  <cfleizach@apple.com>
1144
1145         AX: Support returning relative frames for accessibility
1146         https://bugs.webkit.org/show_bug.cgi?id=193414
1147         <rdar://problem/47268501>
1148
1149         Reviewed by Zalan Bujtas.
1150
1151         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1152         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1153         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1154         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1155         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1156         (WTR::attributesOfElement):
1157         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1158
1159 2019-01-20  Antoine Quint  <graouts@apple.com>
1160
1161         Add a POINTER_EVENTS feature flag
1162         https://bugs.webkit.org/show_bug.cgi?id=193577
1163         <rdar://problem/47408511>
1164
1165         Unreviewed. Also enable Pointer Events for iosmac.
1166
1167         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1168
1169 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1170
1171         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1172         https://bugs.webkit.org/show_bug.cgi?id=193613
1173
1174         Reviewed by Antti Koivisto.
1175
1176         * LayoutReloaded/misc/LFC-passing-tests.txt:
1177
1178 2019-01-19  Antoine Quint  <graouts@apple.com>
1179
1180         Add a POINTER_EVENTS feature flag
1181         https://bugs.webkit.org/show_bug.cgi?id=193577
1182
1183         Reviewed by Dean Jackson.
1184
1185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1186
1187 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1188
1189         Disable the run-jsc-stress-test remote host key check [second round].
1190         https://bugs.webkit.org/show_bug.cgi?id=192988
1191
1192         Reviewed by Dewei Zhu.
1193
1194         * Scripts/run-jsc-stress-tests:
1195
1196 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1199         https://bugs.webkit.org/show_bug.cgi?id=193597
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1204
1205 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1206
1207         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1208         https://bugs.webkit.org/show_bug.cgi?id=193595
1209
1210         Reviewed by Lucas Forschler.
1211
1212         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1213         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1214         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1215
1216 2019-01-18  Chris Dumez  <cdumez@apple.com>
1217
1218         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1219         https://bugs.webkit.org/show_bug.cgi?id=193588
1220         <rdar://problem/47131566>
1221
1222         Reviewed by Alex Christensen.
1223
1224         Add layout test coverage.
1225
1226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1227
1228 2019-01-18  Jer Noble  <jer.noble@apple.com>
1229
1230         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1231         https://bugs.webkit.org/show_bug.cgi?id=189553
1232
1233         Reviewed by Tim Horton.
1234
1235         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1236
1237         * ContentExtensionTester/Configurations/Base.xcconfig:
1238         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1239         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1240         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1241         * ImageDiff/cg/Configurations/Base.xcconfig:
1242         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1243         * MiniBrowser/Configurations/Base.xcconfig:
1244         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1245         * MobileMiniBrowser/Configurations/Base.xcconfig:
1246         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1247         * Scripts/webkitpy/style/checker.py:
1248         (_all_categories):
1249         (FileType):
1250         (CheckerDispatcher._file_type):
1251         (CheckerDispatcher._create_checker):
1252         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1253         (SDKVariantChecker):
1254         (SDKVariantChecker.__init__):
1255         (SDKVariantChecker.check):
1256         * TestWebKitAPI/Configurations/Base.xcconfig:
1257         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1258         * WebEditingTester/Configurations/Base.xcconfig:
1259         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1260         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1261         * WebKitTestRunner/Configurations/Base.xcconfig:
1262         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1263         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1264         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1265
1266 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1267
1268         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1269         <https://webkit.org/b/193568>
1270         <rdar://problem/47381130>
1271
1272         Reviewed by Alex Christensen.
1273
1274         Make sure no one re-introduces UIKit soft-linking by adding a
1275         style rule.
1276
1277         * Scripts/webkitpy/style/checkers/cpp.py:
1278         (check_language): Add softlink/uikit check.
1279         (CppChecker): Enable softlink/uikit check.
1280         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1281         (CppStyleTest): Add test for softlink/uikit.
1282
1283 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1284
1285         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1286         https://bugs.webkit.org/show_bug.cgi?id=193584
1287
1288         Change "-dev" to "-devel".
1289
1290         Reviewed by Michael Catanzaro.
1291
1292         * gtk/install-dependencies:
1293
1294 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1295
1296         webkitpy: Add iPhone and iPad ports
1297         https://bugs.webkit.org/show_bug.cgi?id=193537
1298         <rdar://problem/47353390>
1299
1300         Reviewed by Lucas Forschler.
1301
1302         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1303         ports. Note that this separation is optional, the --ios-simulator command remains.
1304
1305         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1306         (RunTest.test_device_type_test_division): Drive-by fix.
1307         (RunTest.test_device_type_specific_listing): Ditto.
1308         (RunTest.test_ipad_test_division):
1309         (RunTest):
1310         (RunTest.test_ipad_listing):
1311         * Scripts/webkitpy/port/factory.py:
1312         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1313         (PortFactory):
1314         * Scripts/webkitpy/port/ios_simulator.py:
1315         (IPhoneSimulatorPort):
1316         (IPadSimulatorPort):
1317
1318 2019-01-18  Chris Dumez  <cdumez@apple.com>
1319
1320         Regression(PSON) Scroll position is not always restored properly when navigating back
1321         https://bugs.webkit.org/show_bug.cgi?id=193578
1322         <rdar://problem/47386331>
1323
1324         Reviewed by Tim Horton.
1325
1326         Add API test coverage.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1329
1330 2019-01-18  Youenn Fablet  <youenn@apple.com>
1331
1332         Add a new SPI to request for cache storage quota increase
1333         https://bugs.webkit.org/show_bug.cgi?id=193323
1334
1335         Reviewed by Alex Christensen.
1336
1337         Implement WebsiteDataStore quota delegate to handle quota requests.
1338         By default, do not update quota.
1339         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1340
1341         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1343         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1344         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1345         * WebKitTestRunner/TestController.cpp:
1346         (WTR::TestController::allowCacheStorageQuotaIncrease):
1347         * WebKitTestRunner/TestController.h:
1348         * WebKitTestRunner/TestInvocation.cpp:
1349         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1350         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1351         (-[CacheStorageQuotaManager init]):
1352         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1353         (WTR::initializeWebViewConfiguration):
1354         (WTR::TestController::cocoaResetStateToConsistentValues):
1355         (WTR::TestController::allowCacheStorageQuotaIncrease):
1356
1357 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-build] Pass owner to the triggered builds
1360         https://bugs.webkit.org/show_bug.cgi?id=193574
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-build/factories.py:
1365         (BuildFactory.propertiesToPassToTriggers):
1366
1367 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1368
1369         [ews-app] Send patch author as a build property
1370         https://bugs.webkit.org/show_bug.cgi?id=193560
1371
1372         Reviewed by Lucas Forschler.
1373
1374         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1375         (BugzillaPatchFetcher.fetch):
1376
1377 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1378
1379         webkitpy: Implement device type specific expected results (Follow-up fix)
1380         https://bugs.webkit.org/show_bug.cgi?id=192162
1381         <rdar://problem/46345449>
1382
1383         Unreviewed infrastructure fix.
1384
1385         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1386         (Manager.run): Don't boot a device if no tests are available to run on it.
1387
1388 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1389
1390         webkitpy: Implement device type specific expected results (Follow-up fix)
1391         https://bugs.webkit.org/show_bug.cgi?id=192162
1392         <rdar://problem/46345449>
1393
1394         Unreviewed infrastructure fix.
1395
1396         * Scripts/webkitpy/api_tests/manager.py:
1397         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1398
1399 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1400
1401         webkitpy: Implement device type specific expected results (Part 2)
1402         https://bugs.webkit.org/show_bug.cgi?id=192162
1403         <rdar://problem/46345449>
1404
1405         Rubber-stamped by Aakash Jain.
1406
1407         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1408         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1409         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1410
1411         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1412         (LayoutTestFinder.find_tests): Pass device_type through.
1413         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1414         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1415         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1416         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1417         (Manager._collect_tests): Pass device type to test finder.
1418         (Manager._needs_web_platform_test):
1419         (Manager._prepare_lists): Index _expectations by device type.
1420         (Manager._test_input_for_file):
1421         (Manager._test_is_slow): Ditto.
1422         (Manager._test_should_dump_jsconsolelog_in_stderr):
1423         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1424         (Manager._get_test_inputs):
1425         (Manager._update_worker_count):
1426         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1427         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1428         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1429         the one which runs the test.
1430         (Manager._run_test_subset):
1431         (Manager._run_tests): Index _expectations by current_device_type.
1432         (Manager._print_expectation_line_for_test): Ditto.
1433         (Manager._print_expectations_for_subset): Ditto.
1434         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1435         Unlike run, this function will behave the same regardless of what devices are available.
1436         (Manager._custom_device_for_test): Deleted.
1437         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1438         (ManagerTest.test_uses_custom_device): Deleted.
1439         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1440         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1441         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1442         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1443         all of the expectations.
1444         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1445         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1446         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1447         (TestExpectations.__init__): Allow device_type to be passed through.
1448         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1449         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1450         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1451         (summarize_results):
1452         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1453         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1454         a test ran with, one must check all expectations to find the first non-skip expectation.
1455         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1456         (RunTest.test_device_type_test_division):
1457         (RunTest):
1458         (RunTest.test_device_type_specific_listing):
1459         * Scripts/webkitpy/port/base.py:
1460         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1461         (Port.supported_device_types): The result of this function will change based on what devices are available.
1462         * Scripts/webkitpy/port/device_port.py:
1463         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1464         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1465         can be used.
1466         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1467         any, or the DEFAULT_DEVICE_TYPES of the port.
1468         * Scripts/webkitpy/port/ios.py:
1469         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1470         * Scripts/webkitpy/port/ios_simulator.py:
1471         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1472         * Scripts/webkitpy/port/watch.py:
1473         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1474         * Scripts/webkitpy/port/watch_simulator.py:
1475         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1476         * Scripts/webkitpy/xcode/device_type.py:
1477         (DeviceType):
1478         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1479
1480 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1481
1482         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1483         https://bugs.webkit.org/show_bug.cgi?id=193575
1484
1485         Reviewed by Michael Catanzaro.
1486
1487         Allow the script to run without explicit port argument because
1488         it's specific to the WPE port anyway.
1489
1490         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1491         and simplify the rest of the code accordingly.
1492
1493 2019-01-18  Charlie Turner  <cturner@igalia.com>
1494
1495         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1496         https://bugs.webkit.org/show_bug.cgi?id=192229
1497
1498         Reviewed by Xabier Rodriguez-Calvar.
1499
1500         * MiniBrowser/wpe/main.cpp:
1501         (main): Enable encrypted-media by default.
1502
1503 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1504
1505         [Flatpak] Missing KeyboardInterrupt exception handler
1506         https://bugs.webkit.org/show_bug.cgi?id=193570
1507
1508         Reviewed by Michael Catanzaro.
1509
1510         * flatpak/flatpakutils.py:
1511         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1512
1513 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1514
1515         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1516         https://bugs.webkit.org/show_bug.cgi?id=193564
1517
1518         Reviewed by Antti Koivisto.
1519
1520         * LayoutReloaded/misc/LFC-passing-tests.txt:
1521
1522 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1523
1524         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1525         https://bugs.webkit.org/show_bug.cgi?id=193562
1526
1527         Reviewed by Antti Koivisto.
1528
1529         * LayoutReloaded/misc/LFC-passing-tests.txt:
1530
1531 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1532
1533         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1534         https://bugs.webkit.org/show_bug.cgi?id=193555
1535
1536         Reviewed by Antti Koivisto.
1537
1538         * LayoutReloaded/misc/LFC-passing-tests.txt:
1539
1540 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1541
1542         [WPE] Add Qt extension
1543         https://bugs.webkit.org/show_bug.cgi?id=191464
1544
1545         Reviewed by Carlos Garcia Campos.
1546
1547         MiniBrowser and API tests for the WPE Qt API. To run the
1548         MiniBrowser a new script is introduced. Example invocation:
1549
1550         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1551
1552         Also note-worthy is the introduction of the python2-subprocess32
1553         dependency to run the GLib API tests.
1554
1555         * MiniBrowser/wpe/CMakeLists.txt:
1556         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1557         * MiniBrowser/wpe/qt/main.cpp: Added.
1558         (main):
1559         * MiniBrowser/wpe/qt/main.qml: Added.
1560         * MiniBrowser/wpe/qt/qml.qrc: Added.
1561         * Scripts/run-gtk-tests:
1562         (GtkTestRunner.is_google_test):
1563         (GtkTestRunner):
1564         (GtkTestRunner.is_qt_test):
1565         * Scripts/run-qt-wpe-minibrowser: Added.
1566         * Scripts/run-wpe-tests:
1567         (WPETestRunner):
1568         (WPETestRunner.is_google_test):
1569         (WPETestRunner.is_qt_test):
1570         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1571         (TestLoad::main):
1572         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1573         (TestLoadHtml::main):
1574         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1575         (TestLoadRequest::main):
1576         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1577         (TestRunJavaScript::main):
1578         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1579         (waitForSignal):
1580         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1581         (LoadSpy::LoadSpy):
1582         (LoadSpy::~LoadSpy):
1583         (LoadSpy::onLoadingChanged):
1584         (LoadStartedCatcher::LoadStartedCatcher):
1585         (LoadStartedCatcher::~LoadStartedCatcher):
1586         (LoadStartedCatcher::onLoadingChanged):
1587         (waitForLoadSucceeded):
1588         (waitForLoadFailed):
1589         * TestWebKitAPI/glib/CMakeLists.txt:
1590         * flatpak/flatpakutils.py:
1591         (WebkitFlatpak.load_from_args):
1592         (WebkitFlatpak.__init__):
1593         (WebkitFlatpak.clean_args):
1594         (WebkitFlatpak.run_in_sandbox):
1595         * flatpak/org.webkit.CommonModules.yaml:
1596         * flatpak/org.webkit.WPE.yaml:
1597         * flatpak/org.webkit.WPEModules.yaml:
1598         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1599         * flatpak/org.webkit.WebKit.yaml:
1600         * glib/api_test_runner.py:
1601         (TestRunner._run_test_qt):
1602         (TestRunner.is_qt_test):
1603         (TestRunner._run_test):
1604
1605 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1606
1607         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1608         https://bugs.webkit.org/show_bug.cgi?id=193494
1609         <rdar://problem/46859627>
1610
1611         Reviewed by Simon Fraser and Tim Horton.
1612
1613         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1614         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1615
1616         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1617         (WTR::UIScriptController::contentOffsetX const):
1618         (WTR::UIScriptController::contentOffsetY const):
1619         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1620         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1621         (WTR::UIScriptController::contentOffsetX const):
1622         (WTR::UIScriptController::contentOffsetY const):
1623         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1624
1625         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1626
1627         * WebKitTestRunner/TestController.cpp:
1628         (WTR::updateTestOptionsFromTestHeader):
1629         * WebKitTestRunner/TestOptions.h:
1630         (WTR::TestOptions::hasSameInitializationOptions const):
1631         * WebKitTestRunner/ios/TestControllerIOS.mm:
1632         (WTR::TestController::platformResetStateToConsistentValues):
1633         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1634         (WTR::UIScriptController::contentOffsetX const):
1635         (WTR::UIScriptController::contentOffsetY const):
1636
1637 2019-01-17  Truitt Savell  <tsavell@apple.com>
1638
1639         Unreviewed, rolling out r240124.
1640
1641         This commit broke an internal build.
1642
1643         Reverted changeset:
1644
1645         "SDK_VARIANT build destinations should be separate from non-
1646         SDK_VARIANT builds"
1647         https://bugs.webkit.org/show_bug.cgi?id=189553
1648         https://trac.webkit.org/changeset/240124
1649
1650 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1651
1652         Fix string concatenation API test after r239920
1653         https://bugs.webkit.org/show_bug.cgi?id=193551
1654         <rdar://problem/47359304>
1655
1656         Reviewed by Youenn Fablet.
1657
1658         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1659         (TestWebKitAPI::TEST):
1660         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1661         in WebKit's build configuration like it apparently is on Linux.
1662
1663 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1664
1665         [ews-build] validate-patch should handle the case when bug_id is None
1666         https://bugs.webkit.org/show_bug.cgi?id=193547
1667
1668         Reviewed by Lucas Forschler.
1669
1670         * BuildSlaveSupport/ews-build/steps.py:
1671         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1672         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1673
1674 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1675
1676         [ews-build] Add patch author information in build
1677         https://bugs.webkit.org/show_bug.cgi?id=193465
1678
1679         Reviewed by Lucas Forschler.
1680
1681         * BuildSlaveSupport/ews-build/steps.py:
1682         (ValidatePatch._is_patch_obsolete):
1683
1684 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1685
1686         [ews-build] Pass bug_id to the triggered builds
1687         https://bugs.webkit.org/show_bug.cgi?id=193548
1688
1689         Reviewed by Lucas Forschler.
1690
1691         * BuildSlaveSupport/ews-build/factories.py:
1692         (BuildFactory.propertiesToPassToTriggers):
1693
1694 2019-01-17  Jer Noble  <jer.noble@apple.com>
1695
1696         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1697         https://bugs.webkit.org/show_bug.cgi?id=189553
1698
1699         Reviewed by Tim Horton.
1700
1701         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1702
1703         * ContentExtensionTester/Configurations/Base.xcconfig:
1704         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1705         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1706         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1707         * ImageDiff/cg/Configurations/Base.xcconfig:
1708         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1709         * MiniBrowser/Configurations/Base.xcconfig:
1710         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1711         * MobileMiniBrowser/Configurations/Base.xcconfig:
1712         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1713         * Scripts/webkitpy/style/checker.py:
1714         (_all_categories):
1715         (FileType):
1716         (CheckerDispatcher._file_type):
1717         (CheckerDispatcher._create_checker):
1718         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1719         (SDKVariantChecker):
1720         (SDKVariantChecker.__init__):
1721         (SDKVariantChecker.check):
1722         * TestWebKitAPI/Configurations/Base.xcconfig:
1723         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1724         * WebEditingTester/Configurations/Base.xcconfig:
1725         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1726         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1727         * WebKitTestRunner/Configurations/Base.xcconfig:
1728         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1729         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1730         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1731
1732 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1733
1734         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1735         https://bugs.webkit.org/show_bug.cgi?id=193534
1736
1737         Reviewed by Antti Koivisto.
1738
1739         * LayoutReloaded/misc/LFC-passing-tests.txt:
1740
1741 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1742
1743         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1744         https://bugs.webkit.org/show_bug.cgi?id=193528
1745
1746         Reviewed by Antti Koivisto.
1747
1748         * LayoutReloaded/misc/LFC-passing-tests.txt:
1749
1750 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1751
1752         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1753         https://bugs.webkit.org/show_bug.cgi?id=193520
1754
1755         Reviewed by Antti Koivisto.
1756
1757         * LayoutReloaded/misc/LFC-passing-tests.txt:
1758
1759 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1760
1761         [ews-build] unapply-patch step should not update source
1762         https://bugs.webkit.org/show_bug.cgi?id=193234
1763
1764         Reviewed by Lucas Forschler.
1765
1766         * BuildSlaveSupport/ews-build/steps.py:
1767         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1768         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1769
1770 2019-01-16  Youenn Fablet  <youenn@apple.com>
1771
1772         Add a new SPI for controlling getUserMedia
1773         https://bugs.webkit.org/show_bug.cgi?id=192793
1774
1775         Reviewed by Eric Carlson.
1776
1777         * MiniBrowser/mac/WK2BrowserWindowController.m:
1778         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1779         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1780         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1781         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1782         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1783         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1784         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1785         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1786         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1787         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1788         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1789         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1790         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1791         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1792
1793 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1794
1795         [LFC][BFC] Inflow non-replaced used width should not be negative.
1796         https://bugs.webkit.org/show_bug.cgi?id=193495
1797
1798         Reviewed by Antti Koivisto.
1799
1800         * LayoutReloaded/misc/LFC-passing-tests.txt:
1801
1802 2019-01-16  Chris Dumez  <cdumez@apple.com>
1803
1804         Regression(PSON) View becomes blank after click a cross-site download link
1805         https://bugs.webkit.org/show_bug.cgi?id=193361
1806         <rdar://problem/47099573>
1807
1808         Reviewed by Geoffrey Garen.
1809
1810         Add API test coverage.
1811
1812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1813         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1814
1815 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1816
1817         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1818         https://bugs.webkit.org/show_bug.cgi?id=193470
1819
1820         Reviewed by Antti Koivisto.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1825
1826         [LFC] Adjust margin box verification.
1827         https://bugs.webkit.org/show_bug.cgi?id=193482
1828
1829         Reviewed by Antti Koivisto.
1830
1831         * LayoutReloaded/misc/LFC-passing-tests.txt:
1832
1833 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1834
1835         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1836         https://bugs.webkit.org/show_bug.cgi?id=193451
1837
1838         Reviewed by Geoffrey Garen.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1841         (TEST):
1842         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1843         (runWebsiteDataStoreCustomPaths):
1844
1845 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1846
1847         webkitpy: Support boolean simctl isAvailable
1848         https://bugs.webkit.org/show_bug.cgi?id=193472
1849         <rdar://problem/47296150>
1850
1851         Reviewed by Ryosuke Niwa.
1852
1853         * Scripts/webkitpy/xcode/simulated_device.py:
1854         (SimulatedDeviceManager._create_runtimes):
1855         (SimulatedDeviceManager._create_device_with_runtime):
1856
1857 2019-01-15  Chris Dumez  <cdumez@apple.com>
1858
1859         Unreviewed, rolling out r239993, r239995, r239997, and
1860         r239999.
1861
1862         Caused assertions under
1863         ViewGestureController::disconnectFromProcess()
1864
1865         Reverted changesets:
1866
1867         "Regression(PSON) View becomes blank after click a cross-site
1868         download link"
1869         https://bugs.webkit.org/show_bug.cgi?id=193361
1870         https://trac.webkit.org/changeset/239993
1871
1872         "Unreviewed iOS build fix after r239993."
1873         https://trac.webkit.org/changeset/239995
1874
1875         "Fix iOS build after r239993"
1876         https://bugs.webkit.org/show_bug.cgi?id=193361
1877         https://trac.webkit.org/changeset/239997
1878
1879         "Unreviewed, revert part of r239997 as it is not needed to fix
1880         the build."
1881         https://trac.webkit.org/changeset/239999
1882
1883 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1884
1885         Cannot tab out of WKWebView on macOS
1886         https://bugs.webkit.org/show_bug.cgi?id=161448
1887         <rdar://problem/28100085>
1888
1889         Reviewed by Dean Jackson.
1890
1891         Add a test that tabbing into and out of WKWebView works correctly.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1895         (WebKit2_CommandBackForwardTest::SetUp):
1896         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1897         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1898         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1899         (-[FocusableView canBecomeKeyView]):
1900         (TEST):
1901         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1902         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1903         (-[OffscreenWindow initWithSize:]):
1904         (-[OffscreenWindow isKeyWindow]):
1905         (-[OffscreenWindow isVisible]):
1906         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1907         (TestWebKitAPI::PlatformWebView::initialize):
1908         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1909         (-[ActiveOffscreenWindow isVisible]): Deleted.
1910         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1911
1912 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1913
1914         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1915         https://bugs.webkit.org/show_bug.cgi?id=193459
1916
1917         Reviewed by Mark Lam.
1918
1919         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1920         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1921
1922 2019-01-15  Chris Dumez  <cdumez@apple.com>
1923
1924         Regression(PSON) View becomes blank after click a cross-site download link
1925         https://bugs.webkit.org/show_bug.cgi?id=193361
1926         <rdar://problem/47099573>
1927
1928         Reviewed by Geoff Garen.
1929
1930         Add API test coverage.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1933         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1934
1935 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1936
1937         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1938         https://bugs.webkit.org/show_bug.cgi?id=193448
1939
1940         Reviewed by Antti Koivisto.
1941
1942         * LayoutReloaded/misc/LFC-passing-tests.txt:
1943
1944 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1945
1946         webkitpy: Implement device type specific expected results (Part 1)
1947         https://bugs.webkit.org/show_bug.cgi?id=192162
1948
1949         Reviewed by Lucas Forschler.
1950
1951         Device type specific expected results covers two related ideas. The first (covered by this change)
1952         is where to search for -expected.* files. The second is which tests to run based on the
1953         TestExpectations.txt file.
1954
1955         After this change, the baseline search path will be determined by the type of device running a
1956         test. Device type will be passed into any function which picks a file based on the baseline search
1957         path.
1958
1959         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1960         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1961         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1962         (Manager.run): Print baseline search path for each round of devices.
1963         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1964         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1965         (SingleTestRunner._expected_driver_output): Ditto.
1966         (SingleTestRunner._driver_input): Ditto.
1967         * Scripts/webkitpy/layout_tests/views/printing.py:
1968         (Printer.print_config): Move printing of baseline search path to a separate function.
1969         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1970         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1971         (Testprinter.test_print_config):
1972         (Testprinter.test_print_baseline_search_path):
1973         * Scripts/webkitpy/port/base.py:
1974         (Port.baseline_search_path): Pass device_type through.
1975         (Port._expected_baselines_for_suffixes): Ditto.
1976         (Port.expected_baselines): Ditto.
1977         (Port.expected_filename): Ditto.
1978         (Port.expected_checksum): Ditto.
1979         (Port.expected_image): Ditto.
1980         (Port.expected_audio): Ditto.
1981         (Port.expected_text): Ditto.
1982         (Port.reference_files): Ditto.
1983         (Port.tests): Ditto.
1984         (Port._expanded_paths): Ditto.
1985         (Port.skipped_layout_tests): Ditto.
1986         (Port.expectations_dict): Ditto.
1987         (Port._port_specific_expectations_files): Ditto.
1988         (Port.expectations_files): Ditto.
1989         (Port.test_search_path): Ditto.
1990         (Port._tests_for_other_platforms): Ditto.
1991         * Scripts/webkitpy/port/base_unittest.py:
1992         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1993         (PortTest.test_nonexistant_expectations): Ditto.
1994         (test_ref_tests_platform_directory): Ditto.
1995         * Scripts/webkitpy/port/darwin.py:
1996         (DarwinPort._port_specific_expectations_files): Accept device_type.
1997         * Scripts/webkitpy/port/driver.py:
1998         (DriverProxy):
1999         (DriverProxy.host): Expose _target_host for device_type information.
2000         * Scripts/webkitpy/port/gtk.py:
2001         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2002         * Scripts/webkitpy/port/ios.py:
2003         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2004         * Scripts/webkitpy/port/mac.py:
2005         (MacPort. default_baseline_search_path): Ditto.
2006         * Scripts/webkitpy/port/port_testcase.py:
2007         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2008         * Scripts/webkitpy/port/test.py:
2009         * Scripts/webkitpy/port/watch.py:
2010         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2011         * Scripts/webkitpy/port/win.py:
2012         (WinPort.test_search_path): Accept, but do not use, device_type.
2013         * Scripts/webkitpy/port/wpe.py:
2014         (WPEPort._port_specific_expectations_files): Ditto.
2015         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2016         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2017
2018 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2019
2020         [LFC] Use the containing block's padding box to position out-of-flow elements.
2021         https://bugs.webkit.org/show_bug.cgi?id=193431
2022
2023         Reviewed by Antti Koivisto.
2024
2025         * LayoutReloaded/misc/LFC-passing-tests.txt:
2026
2027 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2028
2029         Move a test implementation file that got misplaced in the Xcode project
2030
2031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2032
2033 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2034
2035         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2036         r239913, and r239914.
2037         https://bugs.webkit.org/show_bug.cgi?id=193407
2038
2039         These revisions caused an internal failure (Requested by
2040         Truitt on #webkit).
2041
2042         Reverted changesets:
2043
2044         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2045         https://bugs.webkit.org/show_bug.cgi?id=186016
2046         https://trac.webkit.org/changeset/239901
2047
2048         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2049         https://trac.webkit.org/changeset/239909
2050
2051         "Tried to fix the build."
2052         https://trac.webkit.org/changeset/239910
2053
2054         "Fixed iOS builds after r239910."
2055         https://trac.webkit.org/changeset/239912
2056
2057         "More build fixing."
2058         https://trac.webkit.org/changeset/239913
2059
2060         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2061         https://trac.webkit.org/changeset/239914
2062
2063 2019-01-14  Mark Lam  <mark.lam@apple.com>
2064
2065         Re-enable ability to build --cloop builds.
2066         https://bugs.webkit.org/show_bug.cgi?id=192955
2067         <rdar://problem/46882363>
2068
2069         Reviewed by Saam barati and Keith Miller.
2070
2071         The --cloop build option was being ignored this whole time since r236381.
2072         This patch makes it possible to build CLoop builds again.
2073
2074         * Scripts/build-jsc:
2075         * Scripts/webkitperl/FeatureList.pm:
2076         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2077
2078 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2079
2080         webkitpy: Expose device_type from host-like objects
2081         https://bugs.webkit.org/show_bug.cgi?id=193406
2082         <rdar://problem/47262305>
2083
2084         Reviewed by Lucas Forschler.
2085
2086         Devices should expose device_type. As a result, all host objects should
2087         provide a device_type property, even if they do not yet define a device_type.
2088
2089         * Scripts/webkitpy/common/system/systemhost.py:
2090         (SystemHost):
2091         (SystemHost.device_type):
2092         * Scripts/webkitpy/common/system/systemhost_mock.py:
2093         (MockSystemHost):
2094         (MockSystemHost.device_type):
2095         * Scripts/webkitpy/port/device.py:
2096         (Device):
2097         (Device.device_type):
2098         * Scripts/webkitpy/xcode/simulated_device.py:
2099         (SimulatedDeviceManager._find_exisiting_device_for_request):
2100         (SimulatedDeviceManager._disambiguate_device_type):
2101         (SimulatedDeviceManager._does_fulfill_request):
2102         (SimulatedDeviceManager.device_count_for_type):
2103         (SimulatedDeviceManager.initialize_devices):
2104         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2105         (test_available_devices):
2106         (test_swapping_devices):
2107
2108 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2109
2110         webkitpy: Support alternate simctl device list output (Follow-up fix)
2111         https://bugs.webkit.org/show_bug.cgi?id=193362
2112         <rdar://problem/47122965>
2113
2114         Rubber-stamped by Lucas Forschler.
2115
2116         * Scripts/webkitpy/xcode/simulated_device.py:
2117         (SimulatedDeviceManager.populate_available_devices):
2118
2119 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2120
2121         [iOS] Expose SPI to access the current sentence boundary and selection state
2122         https://bugs.webkit.org/show_bug.cgi?id=193398
2123         <rdar://problem/45893108>
2124
2125         Reviewed by Dean Jackson.
2126
2127         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2128         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2129         expected.
2130
2131         * TestWebKitAPI/EditingTestHarness.h:
2132         * TestWebKitAPI/EditingTestHarness.mm:
2133         (-[EditingTestHarness moveBackward]):
2134         (-[EditingTestHarness moveForward]):
2135         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2136
2137         Add a couple of new helper methods on EditingTestHarness.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2140         (-[SelectionChangeObserver initWithWebView:]):
2141         (-[SelectionChangeObserver webView]):
2142         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2143         (-[SelectionChangeObserver currentSelectionAttributes]):
2144
2145 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2146
2147         [LFC][BFC] Add basic box-sizing support.
2148         https://bugs.webkit.org/show_bug.cgi?id=193392
2149
2150         Reviewed by Antti Koivisto.
2151
2152         * LayoutReloaded/misc/LFC-passing-tests.txt:
2153
2154 2019-01-14  Charlie Turner  <cturner@igalia.com>
2155
2156         [WPE] API test gardening
2157         https://bugs.webkit.org/show_bug.cgi?id=193319
2158
2159         Reviewed by Michael Catanzaro.
2160
2161         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2162         passing tests.
2163
2164 2019-01-14  Charlie Turner  <cturner@igalia.com>
2165
2166         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2167         https://bugs.webkit.org/show_bug.cgi?id=192977
2168
2169         Reviewed by Carlos Garcia Campos.
2170
2171         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2172         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2173         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2174         (TestWebKitAPI::GStreamerTest::SetUp):
2175         (TestWebKitAPI::GStreamerTest::TearDown):
2176         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2177         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2178         (TestWebKitAPI::TEST_F):
2179
2180 2019-01-14  Charlie Turner  <cturner@igalia.com>
2181
2182         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2183         https://bugs.webkit.org/show_bug.cgi?id=193332
2184
2185         Reviewed by Michael Catanzaro.
2186
2187         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2188         defined as a char16_t, which changed in ICU 59, the
2189         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2190         unsigned short. This test is relying on the behaviour that
2191         UChar=unsigned short, which doesn't hold across platforms and ICU
2192         library versions. The full fix would be a special syntax for
2193         literal characters so that these ambiguities do not arise. That
2194         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2195         (TestWebKitAPI::TEST):
2196
2197 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2198
2199         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2200
2201         * Scripts/make-dist:
2202         (Distcheck.configure):
2203
2204 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2205
2206         [ews-build] Update macOS queue configurations
2207         https://bugs.webkit.org/show_bug.cgi?id=193365
2208         <rdar://problem/47221073>
2209
2210         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2211
2212         * BuildSlaveSupport/ews-build/config.json:
2213
2214 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2215
2216         [LFC] Adjust assert for statically positioned fixed elements
2217         https://bugs.webkit.org/show_bug.cgi?id=193385
2218
2219         Reviewed by Antti Koivisto.
2220
2221         * LayoutReloaded/misc/LFC-passing-tests.txt:
2222
2223 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2224
2225         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2226         https://bugs.webkit.org/show_bug.cgi?id=193387
2227
2228         Reviewed by Carlos Garcia Campos.
2229
2230         * MiniBrowser/wpe/main.cpp:
2231         (main):
2232
2233 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2234
2235         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2236         https://bugs.webkit.org/show_bug.cgi?id=191655
2237         rdar://problem/46074680
2238
2239         Reviewed by Megan Gardner.
2240
2241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2242         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2243
2244 2019-01-12  Dan Bernstein  <mitz@apple.com>
2245
2246         [Cocoa] Avoid importing directly from subumbrella frameworks
2247         https://bugs.webkit.org/show_bug.cgi?id=186016
2248         <rdar://problem/40591038>
2249
2250         Reviewed by Sam Weinig.
2251
2252         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2253           LaunchServices header.
2254         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2255           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2256         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2257           when using SDKs earlier than 10.13.
2258         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2259           and OTHER_CPLUSPLUSFLAGS.
2260         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2261           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2262         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2263           LaunchServices header.
2264
2265 2019-01-11  John Wilander  <wilander@apple.com>
2266
2267         Compile out Web API Statistics Collection
2268         https://bugs.webkit.org/show_bug.cgi?id=193370
2269         <rdar://problem/45388584>
2270
2271         Reviewed by Brent Fulgham.
2272
2273         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2274             Defined ENABLE_WEB_API_STATISTICS, off by default.
2275
2276 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2277
2278         [WPE] Add gtk-doc
2279         https://bugs.webkit.org/show_bug.cgi?id=178900
2280
2281         Reviewed by Michael Catanzaro.
2282
2283         Add Tools/gtkdoc to manifest.txt.in files.
2284         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2285
2286         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2287         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2288
2289 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2290
2291         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2292         https://bugs.webkit.org/show_bug.cgi?id=193364
2293         <rdar://problem/47214117>
2294
2295         Reviewed by Tim Horton.
2296
2297         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2298         precise, whereas dragging near the middle of the textarea does.
2299
2300         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2301         (TestWebKitAPI::TEST):
2302
2303 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2304
2305         webkitpy: Support alternate simctl device list output
2306         https://bugs.webkit.org/show_bug.cgi?id=193362
2307         <rdar://problem/47122965>
2308
2309         Reviewed by Lucas Forschler.
2310
2311         * Scripts/webkitpy/xcode/simulated_device.py:
2312         (SimulatedDeviceManager.populate_available_devices):
2313
2314 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2315
2316         [ews-build] Update macOS queue configurations
2317         https://bugs.webkit.org/show_bug.cgi?id=193365
2318
2319         Reviewed by Lucas Forschler.
2320
2321         * BuildSlaveSupport/ews-build/config.json:
2322
2323 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2324
2325         webkitpy: Incorporate device type into baseline search path
2326         https://bugs.webkit.org/show_bug.cgi?id=193356
2327         <rdar://problem/47215515>
2328
2329         Reviewed by Lucas Forschler.
2330
2331         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2332
2333         * Scripts/webkitpy/port/base.py:
2334         (Port.default_baseline_search_path): Allow device type to be passed in.
2335         * Scripts/webkitpy/port/gtk.py:
2336         (GtkPort.default_baseline_search_path): Ignore device type.
2337         * Scripts/webkitpy/port/ios.py:
2338         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2339         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2340         * Scripts/webkitpy/port/ios_device_unittest.py:
2341         (IOSDeviceTest):
2342         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2343         (IOSSimulatorTest):
2344         * Scripts/webkitpy/port/mac.py:
2345         (MacPort.default_baseline_search_path): Ignore device type.
2346         * Scripts/webkitpy/port/watch.py:
2347         (WatchPort.default_baseline_search_path): Ditto.
2348         * Scripts/webkitpy/port/win.py:
2349         (WinPort.default_baseline_search_path): Ditto.
2350         (WinCairoPort.default_baseline_search_path): Ditto.
2351         * Scripts/webkitpy/port/wpe.py:
2352         (WPEPort.default_baseline_search_path): Ditto.
2353
2354 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2355
2356         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2357         https://bugs.webkit.org/show_bug.cgi?id=193352
2358         <rdar://problem/47210736>
2359
2360         Reviewed by Lucas Forschler.
2361
2362         * Scripts/webkitpy/layout_tests/views/printing.py:
2363         (Printer.print_config): Print list on only baseline search paths which exist. 
2364         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2365         (Testprinter.test_print_config):
2366
2367 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2368
2369         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2370         https://bugs.webkit.org/show_bug.cgi?id=193340
2371
2372         Reviewed by David Kilzer.
2373
2374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2375         (WTR::InjectedBundle::didReceiveMessageToPage):
2376         Pull the strings out into a WKRetainPtr.
2377
2378         * WebKitTestRunner/WebNotificationProvider.cpp:
2379         (WTR::WebNotificationProvider::closeWebNotification):
2380         Adopt the created value into the WKRetainPtr.
2381
2382         * WebKitTestRunner/mac/TestControllerMac.mm:
2383         (WTR::generateWhitelist):
2384         Immediately adopt a created value to avoid potential mistakes.
2385
2386 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2387
2388         Enable DFG on ARM/Linux again
2389         https://bugs.webkit.org/show_bug.cgi?id=192496
2390
2391         Reviewed by Yusuke Suzuki.
2392
2393         After changing the bytecode format DFG was disabled on all 32-bit
2394         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2395         on ARM by default.
2396
2397         * Scripts/run-jsc-stress-tests:
2398
2399 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2400
2401         Unreviewed, fix #ifdef in API test added in r239851.
2402         https://bugs.webkit.org/show_bug.cgi?id=193327
2403         rdar://problem/47093222
2404
2405         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2406
2407 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2408
2409         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2410         https://bugs.webkit.org/show_bug.cgi?id=193109
2411         <rdar://problem/44807048>
2412
2413         Reviewed by Ryosuke Niwa.
2414
2415         Introduce and respect a test option to enable the UndoManager API.
2416
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::updateTestOptionsFromTestHeader):
2419         * WebKitTestRunner/TestOptions.h:
2420         (WTR::TestOptions::hasSameInitializationOptions const):
2421         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2422         (WTR::TestController::platformCreateWebView):
2423
2424 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2425
2426         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2427         https://bugs.webkit.org/show_bug.cgi?id=193346
2428
2429         Reviewed by Antti Koivisto.
2430
2431         * LayoutReloaded/misc/LFC-passing-tests.txt:
2432
2433 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2434
2435         Unreviewed, fix typo that breaks dashboard link.
2436
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2438         (WebKitBuildbot):
2439
2440 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2441
2442         Update macOS queue configurations
2443         https://bugs.webkit.org/show_bug.cgi?id=193329
2444
2445         Reviewed by Alexey Proskuryakov.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/config.json:
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2449         (BubbleQueueServer):
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2452         (WebKitBuildbot):
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2454         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2455         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2456
2457 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2458
2459         MiniBrowser should be able to navigate to about:blank
2460         https://bugs.webkit.org/show_bug.cgi?id=193345
2461
2462         Reviewed by Simon Fraser.
2463
2464         * MiniBrowser/mac/BrowserWindowController.m:
2465         (-[BrowserWindowController addProtocolIfNecessary:]):
2466         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2467
2468         * MiniBrowser/mac/WK1BrowserWindowController.m:
2469         (-[WK1BrowserWindowController fetch:]):
2470         * MiniBrowser/mac/WK2BrowserWindowController.m:
2471         (-[WK2BrowserWindowController fetch:]):
2472         Clean up the code that uses this to match style.
2473
2474 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2475
2476         Remove MiniBrowser custom "Process Swap" menu item which does not work
2477         https://bugs.webkit.org/show_bug.cgi?id=193344
2478
2479         Reviewed by Simon Fraser.
2480
2481         There is a menu item under the Experimental menu that does work.
2482
2483         * MiniBrowser/mac/AppDelegate.m:
2484         (defaultConfiguration):
2485         * MiniBrowser/mac/SettingsController.h:
2486         * MiniBrowser/mac/SettingsController.m:
2487         (-[SettingsController _populateMenu]):
2488         (-[SettingsController validateMenuItem:]):
2489         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2490         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2491
2492 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2493
2494         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2495         https://bugs.webkit.org/show_bug.cgi?id=193327
2496         rdar://problem/47093222
2497
2498         Reviewed by Tim Horton.
2499
2500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2501         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2502         (TestWebKitAPI::didFinishNavigation):
2503         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2504         (TestWebKitAPI::TEST):
2505         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2506         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2507         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2508         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2509         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2510
2511 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2512
2513         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2514         https://bugs.webkit.org/show_bug.cgi?id=193338
2515         <rdar://problem/46664774>
2516
2517         Reviewed by David Kilzer.
2518
2519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2520         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2521
2522 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2523
2524         Unreviewed, rolling out r239825.
2525         https://bugs.webkit.org/show_bug.cgi?id=193330
2526
2527         Broke tests on armv7/linux bots (Requested by guijemont on
2528         #webkit).
2529
2530         Reverted changeset:
2531
2532         "Enable DFG on ARM/Linux again"
2533         https://bugs.webkit.org/show_bug.cgi?id=192496
2534         https://trac.webkit.org/changeset/239825
2535
2536 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2537
2538         Disable the run-jsc-stress-test remote host key check.
2539         https://bugs.webkit.org/show_bug.cgi?id=192988
2540
2541         Reviewed by Alexey Proskuryakov.
2542
2543         * Scripts/run-jsc-stress-tests:
2544
2545 2019-01-10  John Wilander  <wilander@apple.com>
2546
2547         Override the session configuration for cookieAcceptPolicy
2548         https://bugs.webkit.org/show_bug.cgi?id=190925
2549         <rdar://problem/45497382>
2550
2551         Reviewed by Alexey Proskuryakov and Alex Christensen.
2552
2553         Test infrastructure for setting a first-party-only cookie policy.
2554
2555         * DumpRenderTree/TestRunner.cpp:
2556         (setOnlyAcceptFirstPartyCookiesCallback):
2557         (TestRunner::staticFunctions):
2558         * DumpRenderTree/TestRunner.h:
2559         * DumpRenderTree/mac/TestRunnerMac.mm:
2560         (TestRunner::setOnlyAcceptFirstPartyCookies):
2561         * DumpRenderTree/win/TestRunnerWin.cpp:
2562         (TestRunner::setOnlyAcceptFirstPartyCookies):
2563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2565         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2567         * WebKitTestRunner/TestInvocation.cpp:
2568         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2569
2570 2019-01-09  Matt Rajca  <mrajca@apple.com>
2571
2572         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2573         https://bugs.webkit.org/show_bug.cgi?id=193301
2574
2575         Reviewed by Jer Noble.
2576         
2577         Added API tests.
2578
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2581         (TEST):
2582         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2583
2584 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2585
2586         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2587         https://bugs.webkit.org/show_bug.cgi?id=193310
2588
2589         Reviewed by Antti Koivisto.
2590
2591         * LayoutReloaded/misc/LFC-passing-tests.txt:
2592
2593 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2594
2595         Enable DFG on ARM/Linux again
2596         https://bugs.webkit.org/show_bug.cgi?id=192496
2597
2598         Reviewed by Yusuke Suzuki.
2599
2600         After changing the bytecode format DFG was disabled on all 32-bit
2601         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2602         on ARM by default.
2603
2604         * Scripts/run-jsc-stress-tests:
2605
2606 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2607
2608         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2609         https://bugs.webkit.org/show_bug.cgi?id=193271
2610
2611         Reviewed by Brent Fulgham.
2612
2613         BSTR is a special data structure created by SysAllocString, not a
2614         wchar_t null-terminated string.
2615
2616         * DumpRenderTree/win/TestRunnerWin.cpp:
2617         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2618         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2619         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2620         BSTR from wide string literals.
2621
2622 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2623
2624         Tweak wording for build/version_check style checker error
2625         https://bugs.webkit.org/show_bug.cgi?id=193256
2626
2627         Reviewed by Tim Horton.
2628
2629         * Scripts/webkitpy/style/checkers/cpp.py:
2630         (check_os_version_checks):
2631         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2632         (WebKitStyleTest.test_os_version_checks):
2633
2634 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2635
2636         [ews-build] Add link to bug along with bug title
2637         https://bugs.webkit.org/show_bug.cgi?id=193293
2638
2639         Reviewed by Lucas Forschler.
2640
2641         * BuildSlaveSupport/ews-build/steps.py:
2642         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2643         (ConfigureBuild.add_bug_id_url): Deleted.
2644         (ConfigureBuild.getBugURL): Deleted.
2645
2646 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2647
2648         [ews-build] Use https for ews-build server
2649         https://bugs.webkit.org/show_bug.cgi?id=193193
2650
2651         Reviewed by Lucas Forschler.
2652
2653         * BuildSlaveSupport/ews-build/steps.py:
2654
2655 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2656
2657         [ews-build] Parse and display number of style failures
2658         https://bugs.webkit.org/show_bug.cgi?id=193280
2659
2660         Reviewed by Lucas Forschler.
2661
2662         * BuildSlaveSupport/ews-build/steps.py:
2663         (CheckStyle): Use TestWithFailureCount as base class.
2664         (CheckStyle.countFailures): Count the number of style failures.
2665
2666 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-build] use patch_id instead of ewspatchid
2669         https://bugs.webkit.org/show_bug.cgi?id=193235
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2674         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2675         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2676
2677 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2678
2679         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2680         https://bugs.webkit.org/show_bug.cgi?id=192625
2681
2682         Reviewed by Antti Koivisto.
2683
2684         * LayoutReloaded/misc/LFC-passing-tests.txt:
2685
2686 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2687
2688         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2689         https://bugs.webkit.org/show_bug.cgi?id=192841
2690
2691         Reviewed by Carlos Garcia Campos.
2692
2693         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2694         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2695         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2696
2697         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2698
2699         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2700         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2701         (WebKitWebEditorTest::testSelectionChanged):
2702         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2703         (WebKitFrameTest::testMainFrame):
2704         (WebKitFrameTest::testURI):
2705         (WebKitFrameTest::testJavaScriptContext):
2706         (WebKitFrameTest::testJavaScriptValues):
2707         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2708         (testWebViewAuthenticationRequest):
2709         (testWebViewAuthenticationLoadCancelled):
2710         (testWebViewAuthenticationFailure):
2711         (testWebViewAuthenticationStorage):
2712         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2713         (testWebViewAuthenticationProxy):
2714         (testWebViewAuthenticationProxyHTTPS):
2715         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2716         (testAutomationSessionRequestSession):
2717         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2718         (testBackForwardListNavigation):
2719         (testWebKitWebViewSessionState):
2720         (testWebKitWebViewSessionStateWithFormData):
2721         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2722         (ConsoleMessageTest::consoleMessageReceivedCallback):
2723         (testWebKitConsoleMessageConsoleAPI):
2724         (testWebKitConsoleMessageJavaScriptException):
2725         (testWebKitConsoleMessageNetworkError):
2726         (testWebKitConsoleMessageSecurityError):
2727         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2728         (testCookieManagerAcceptPolicy):
2729         (testCookieManagerCookiesChanged):
2730         (testCookieManagerPersistentStorage):
2731         (testCookieManagerPersistentStorageDeleteAll):
2732         (testCookieManagerEphemeral):
2733         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2734         (testWebKitDOMElementAutoFill):
2735         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2736         (downloadLocalFileSuccessfully):
2737         (createFileAtDestination):
2738         (testDownloadOverwriteDestinationDisallowed):
2739         (testDownloadLocalFileError):
2740         (testDownloadRemoteFile):
2741         (testDownloadRemoteFileError):
2742         (testWebViewDownloadURI):
2743         (testPolicyResponseDownload):
2744         (testPolicyResponseDownloadCancel):
2745         (testDownloadMIMEType):
2746         (contextMenuCallback):
2747         (testContextMenuDownloadActions):
2748         (testBlobDownload):
2749         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2750         (testWebKitWebEditorSelectionChanged):
2751         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2752         (testWebKitFrameMainFrame):
2753         (testWebKitFrameURI):
2754         (testWebKitFrameJavaScriptContext):
2755         (testWebKitFrameJavaScriptValues):
2756         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2757         (LoadStopTrackingTest::loadFailed):
2758         (testWebViewTitle):
2759         (testURIRequestHTTPHeaders):
2760         (testURIRequestHTTPMethod):
2761         (testURIResponseHTTPHeaders):
2762         (testRedirectToDataURI):
2763         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2764         (testProcessPerWebView):
2765         (testWebProcessLimit):
2766         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2767         (testWebViewResources):
2768         (testWebResourceLoading):
2769         (testWebResourceSuggestedFilename):
2770         (testWebResourceGetData):
2771         (testWebResourceGetDataError):
2772         (testWebViewResourcesHistoryCache):
2773         (testWebResourceSendRequest):
2774         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2775         (testSSL):
2776         (testInsecureContent):
2777         (testTLSErrorsPolicy):
2778         (testTLSErrorsRedirect):
2779         (testTLSErrorsHTTPAuth):
2780         (testLoadFailedWithTLSErrors):
2781         (testSubresourceLoadFailedWithTLSErrors):
2782         (httpsServerCallback):
2783         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2784         (testWebViewCreateNavigationData):
2785         (testWebViewJavaScriptDialogs):
2786         (testWebViewWindowProperties):
2787         (testWebViewMouseTarget):
2788         (testWebViewFileChooserRequest):
2789         (testWebViewColorChooserRequest):
2790         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2791         (testWebExtensionGetTitle):
2792         (testDocumentLoadedSignal):
2793         (testWebKitWebViewProcessCrashed):
2794         (testWebExtensionWindowObjectCleared):
2795         (testWebExtensionIsolatedWorld):
2796         (permissionRequestCallback):
2797         (didAssociateFormControlsCallback):
2798         (testWebExtensionFormControlsAssociated):
2799         (FormSubmissionTest::FormSubmissionTest):
2800         (FormSubmissionTest::testFormSubmissionResult):
2801         (testWebExtensionFormSubmissionSteps):
2802         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2803         (testNotInitialized):
2804         (testClearDatabase):
2805         (testPrivateBrowsing):
2806         (testGetFavicon):
2807         (testWebViewFavicon):
2808         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2809         (testFindControllerTextFound):
2810         (testFindControllerTextNotFound):
2811         (testFindControllerMatchCount):
2812         (testFindControllerMaxMatchCount):
2813         (testFindControllerNext):
2814         (testFindControllerPrevious):
2815         (testFindControllerCountedMatches):
2816         (testFindControllerOptions):
2817         (testFindControllerHide):
2818         (testFindControllerInstance):
2819         (testFindControllerGetters):
2820         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2821         (testNavigationPolicy):
2822         (testResponsePolicy):
2823         (testNewWindowPolicy):
2824         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2825         (testSecurityOriginBasicConstructor):
2826         (testSecurityOriginURIConstructor):
2827         (testSecurityOriginDefaultPort):
2828         (testSecurityOriginFileURI):
2829         (testOpaqueSecurityOrigin):
2830         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2831         (testWebKitSettings):
2832         (testWebKitSettingsNewWithSettings):
2833         (testWebKitSettingsUserAgent):
2834         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2835         (testWebViewNewWithUserContentManager):
2836         (isStyleSheetInjectedForURLAtPath):
2837         (isScriptInjectedForURLAtPath):
2838         (testUserContentManagerInjectedStyleSheet):
2839         (testUserContentManagerInjectedScript):
2840         (UserScriptMessageTest::scriptMessageReceived):
2841         (UserScriptMessageTest::waitUntilMessageReceived):
2842         (UserScriptMessageTest::runJavaScriptFinished):
2843         (testUserContentManagerScriptMessageReceived):
2844         (testUserContentManagerScriptMessageInWorldReceived):
2845         (testUserContentManagerScriptMessageFromDOMBindings):
2846         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2847         (testWebContextDefault):
2848         (testWebContextEphemeral):
2849         (testWebContextGetPlugins):
2850         (testWebContextURIScheme):
2851         (testWebContextSpellChecker):
2852         (testWebContextLanguages):
2853         (consoleMessageReceivedCallback):
2854         (testWebContextSecurityFileXHR):
2855         (ProxyTest::ProxyTest):
2856         (testWebContextProxySettings):
2857         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2858         (testWebViewWebContext):
2859         (testWebViewWebBackend):
2860         (testWebViewEphemeral):
2861         (testWebViewCustomCharset):
2862         (testWebViewSettings):
2863         (testWebViewRunJavaScript):
2864         (testWebViewCanShowMIMEType):
2865         (testWebViewSubmitForm):
2866         (testWebViewSave):
2867         (testWebViewPageVisibility):
2868         (testWebViewSnapshot):
2869         (testWebViewNotification):
2870         (testWebViewNotificationInitialPermissionAllowed):
2871         (testWebViewNotificationInitialPermissionDisallowed):
2872         (testWebViewIsPlayingAudio):
2873         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2874         (WebsiteDataTest::WebsiteDataTest):
2875         (WebsiteDataTest::remove):
2876         (WebsiteDataTest::clear):
2877         (testWebsiteDataConfiguration):
2878         (testWebsiteDataEphemeral):
2879         (testWebsiteDataCache):
2880         (testWebsiteDataStorage):
2881         (testWebsiteDataDatabases):
2882         (testWebsiteDataAppcache):
2883         (testWebsiteDataCookies):
2884         (testWebsiteDataDeviceIdHashSalt):
2885         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2886         (emitDocumentLoaded):
2887         (emitURIChanged):
2888         (sendRequestCallback):
2889         (contextMenuCallback):
2890         (consoleMessageSentCallback):
2891         (emitFormControlsAssociated):
2892         (formControlsAssociatedCallback):
2893         (emitFormSubmissionEvent):
2894         (willSubmitFormCallback):
2895         (windowObjectCleared):
2896         (methodCallCallback):
2897         (registerGResource):
2898         (webkit_web_extension_initialize_with_user_data):
2899         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2900         (checkLeaks):
2901         (WebProcessTest::create):
2902         (runTest):
2903         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2904         (AutocleanupsTest::testWebProcessAutocleanups):
2905         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2906         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2907         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2908         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2909         (WebKitDOMDOMWindowTest::testSignals):
2910         (WebKitDOMDOMWindowTest::testDispatchEvent):
2911         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2912         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2913         (WebKitDOMNodeFilterTest::testTreeWalker):
2914         (WebKitDOMNodeFilterTest::testNodeIterator):
2915         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2916         (WebKitDOMNodeTest::testHierarchyNavigation):
2917         (WebKitDOMNodeTest::testInsertion):
2918         (WebKitDOMNodeTest::testTagNamesNodeList):
2919         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2920         (WebKitDOMNodeTest::testDOMCache):
2921         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2922         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2923         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2924         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2925         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2926         (testUIProcessAutocleanups):
2927         (testWebProcessAutocleanups):
2928         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2929         (testContextMenuPopulateMenu):
2930         (testContextMenuDismissed):
2931         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2932         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2933         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2934         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2935         (testWebKitDOMDOMWindowSignals):
2936         (testWebKitDOMDOMWindowDispatchEvent):
2937         (testWebKitDOMDOMWindowGetComputedStyle):
2938         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2939         (testWebKitDOMNodeHierarchyNavigation):
2940         (testWebKitDOMNodeInsertion):
2941         (testWebKitDOMNodeTagNamesNodeList):
2942         (testWebKitDOMNodeTagNamesHTMLCollection):
2943         (testWebKitDOMObjectCache):
2944         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2945         (testWebKitDOMNodeFilterTreeWalker):
2946         (testWebKitDOMNodeFilterNodeIterator):
2947         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2948         (testWebKitDOMXPathNSResolverNative):
2949         (testWebKitDOMXPathNSResolverCustom):
2950         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2951         (testInspectorDefault):
2952         (testInspectorManualAttachDetach):
2953         (testInspectorCustomContainerDestroyed):
2954         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2955         (startTestServer):
2956         (testInspectorServerPageList):
2957         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2958         (OptionMenuTest::showOptionMenuCallback):
2959         (OptionMenuTest::menuCloseCallback):
2960         (OptionMenuTest::close):
2961         (OptionMenuTest::activateItem):
2962         (OptionMenuTest::selectItem):
2963         (testOptionMenuSimple):
2964         (testOptionMenuGroups):
2965         (testOptionMenuActivate):
2966         (testOptionMenuSelect):
2967         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2968         (testPrintOperationPrintSettings):
2969         (webViewPrintCallback):
2970         (testPrintOperationPrint):
2971         (testPrintCustomWidget):
2972         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2973         (checkAtspiAccessible):
2974         (testAtspiBasicHierarchy):
2975         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2976         (testWebKitCheckVersion):
2977         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2978         (testWebViewEditorCutCopyPasteNonEditable):
2979         (testWebViewEditorCutCopyPasteEditable):
2980         (testWebViewEditorSelectAllNonEditable):
2981         (testWebViewEditorSelectAllEditable):
2982         (loadContentsAndTryToCutSelection):
2983         (testWebViewEditorNonEditable):
2984         (testWebViewEditorEditable):
2985         (testWebViewEditorEditorStateTypingAttributes):
2986         (testWebViewEditorInsertImage):
2987         (testWebViewEditorCreateLink):
2988         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2989         (loadChangedCallback):
2990         (loadFailedCallback):
2991         (loadFailedWithTLSErrorsCallback):
2992         (LoadTrackingTest::LoadTrackingTest):
2993         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2994         (registerGResource):
2995         (removeNonEmptyDirectory):
2996         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2997         (Test::adoptView):
2998         (Test::~Test):
2999         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3000         (WebKitTestBus::getOrCreateConnection):
3001         (WebKitTestBus::createProxy):
3002         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3003         (WebKitTestServer::getWebSocketURIForPath const):
3004         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3005         (WebViewTest::initializeWebView):
3006         (WebViewTest::loadURI):
3007         (WebViewTest::loadHtml):
3008         (WebViewTest::loadPlainText):
3009         (WebViewTest::loadBytes):
3010         (WebViewTest::loadRequest):
3011         (WebViewTest::loadAlternateHTML):
3012         (WebViewTest::goBack):
3013         (WebViewTest::goForward):
3014         (WebViewTest::goToBackForwardListItem):
3015         (resourceGetDataCallback):
3016         (WebViewTest::mainResourceData):
3017         (WebViewTest::javascriptResultToCString):
3018         (WebViewTest::javascriptResultToNumber):
3019         (WebViewTest::javascriptResultToBoolean):
3020         (WebViewTest::javascriptResultIsNull):
3021         (WebViewTest::javascriptResultIsUndefined):
3022         (onSnapshotReady):
3023         (WebViewTest::runWebProcessTest):
3024         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3025         (WebViewTest::platformInitializeWebView):
3026         (WebViewTest::showInWindow):
3027         (WebViewTest::showInWindowAndWaitUntilMapped):
3028         (WebViewTest::mouseMoveTo):
3029         (WebViewTest::emitPopupMenuSignal):
3030         (WebViewTest::keyStroke):
3031         (WebViewTest::doMouseButtonEvent):
3032
3033 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3034
3035         [WPE] API tests can't run in flatpak environment
3036         https://bugs.webkit.org/show_bug.cgi?id=193242
3037
3038         Reviewed by Michael Catanzaro.
3039
3040         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3041         flatpakutils so that it knows which port it's dealing with.
3042         * glib/common.py: Remove build_dir globals so that subsequent
3043         calls actually take args into account.
3044         (library_build_path):
3045         (binary_build_path):
3046
3047 2019-01-08  Dean Jackson  <dino@apple.com>
3048
3049         Blob references for System Previews don't get a correct file extension
3050         https://bugs.webkit.org/show_bug.cgi?id=193268
3051         <rdar://problem/47133037>
3052
3053         Reviewed by Tim Horton.
3054
3055         New test that a Blob download of a USDZ file gets named correctly.
3056
3057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3058         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3059         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3060         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3061         (TEST):
3062         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3063
3064 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3065
3066         [WebAuthN] Support U2F HID Authenticators on macOS
3067         https://bugs.webkit.org/show_bug.cgi?id=191535
3068         <rdar://problem/47102027>
3069
3070         Reviewed by Brent Fulgham.
3071
3072         This patch:
3073         1) adds support for U2F mocking mechanism;
3074         2) updates tests to reflect U2fCommandConstructor changes.
3075
3076         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3077         (TestWebKitAPI::TEST):
3078         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3080         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3081
3082 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3083
3084         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3085         https://bugs.webkit.org/show_bug.cgi?id=193229
3086         <rdar://problem/46717097>
3087
3088         Reviewed by Tim Horton.
3089
3090         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3091         prevents a drag from starting.
3092
3093         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3094         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3095
3096         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3097
3098 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3099   
3100         Layout test will generate a perf metric file to results dir.
3101         https://bugs.webkit.org/show_bug.cgi?id=192030
3102         <rdar://problem/32779516>
3103
3104         Reviewed by Aakash Jain.
3105
3106         Layout test running time will be collected to a perf metric file.
3107         For now, instead of outputing running time of all tests (which is huge),
3108         we aggregate them by test directories which are at most two level deep. 
3109
3110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3111         (Manager._end_test_run):
3112         (Manager._output_perf_metrics):
3113         (Manager._print_expectation_line_for_test):
3114         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3115         (add_test_perf_metric):
3116         (test_perf_metrics):
3117         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3118         (JSONGeneratorTest.test_test_timings_trie):
3119         (JSONGeneratorTest):
3120         (JSONGeneratorTest.test_test_perf_metrics):
3121         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3122         (RebaselineTest.test_reset_results):
3123         (RebaselineTest.test_missing_results):
3124         (RebaselineTest.test_new_baseline):
3125
3126 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3127
3128         [WPE][GTK] Add php-json to install-dependencies
3129         https://bugs.webkit.org/show_bug.cgi?id=193233
3130
3131         Reviewed by Michael Catanzaro.
3132
3133         * gtk/install-dependencies:
3134         * wpe/install-dependencies:
3135
3136 2019-01-08  Chris Dumez  <cdumez@apple.com>
3137
3138         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3139         https://bugs.webkit.org/show_bug.cgi?id=193224
3140         <rdar://problem/47097726>
3141
3142         Reviewed by Alex Christensen.
3143
3144         Add API test coverage.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3147
3148 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3149
3150         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3151         <https://webkit.org/b/193222>
3152         <rdar://problem/46862309>
3153
3154         Reviewed by Joseph Pecoraro.
3155
3156         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3157         (WTR::executeCallback): Fix camel case of variable name.
3158         (WTR::EventSendingController::callAfterScrollingCompletes): If
3159         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3160         false, make sure to release the ScrollCompletionCallbackData
3161         object.  This fixes the leak.
3162
3163 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3164
3165         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3166         https://bugs.webkit.org/show_bug.cgi?id=193044
3167
3168         Reviewed by Daniel Bates.
3169
3170         WinCairo EWS bots are using Windows Perl. Binary files should be
3171         opened as binary mode.
3172
3173         * Scripts/svn-apply:
3174         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3175
3176 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3177
3178         [CMake] Add ENABLE_CSS_TYPED_OM option
3179         https://bugs.webkit.org/show_bug.cgi?id=193216
3180
3181         Reviewed by Michael Catanzaro.
3182
3183         * Scripts/webkitperl/FeatureList.pm:
3184
3185 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3186
3187         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3188         <https://webkit.org/b/193056>
3189
3190         Reviewed by Alex Christensen.
3191
3192         * Scripts/webkitpy/style/checker.py:
3193         - Ignore use of new runtime/retainptr check in
3194           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3195           contains tests to ensure RetainPtr<NSObject *> is compatible
3196           with RetainPtr<NSObject>.
3197
3198         * Scripts/webkitpy/style/checkers/cpp.py:
3199         (check_language):
3200         (CppChecker):
3201         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3202           was used instead of a single regex so that angle brackets
3203           could be matched up when checking the type contained within
3204           the RetainPtr<> type.
3205
3206         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3207         (CppStyleTest):
3208         - Add unit test for new runtime/retainptr check.
3209
3210         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3211         * TestWebKitAPI/EditingTestHarness.h:
3212         - Remove '*' from RetainPtr<> type.
3213
3214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3215         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3216           regressed in r201938.
3217
3218         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3219         (TestWebKitAPI::TEST):
3220         - Update tests to match RetainPtr.mm tests (except for the
3221           `*SimilarNSType` tests since there is no CF equivalent of
3222           RetainPtr<NSString> and RetainPtr<NSString *>).
3223
3224         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3225         (TestWebKitAPI::TEST):
3226         - Update tests to:
3227           - Not conflict by name with equivalent CF tests in
3228             RetainPtr.cpp.
3229           - Add test cases for RetainPtr<NSObject>,
3230             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3231           - Add `*SimilarNSType` tests for converting between
3232             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3233           - Change `0` to `nil` as appropriate.
3234           - Re-alphabetize the tests by name.
3235           - Add Optional<RetainPtr<>> tests.
3236           - Add retainPtr() tests.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3239         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3240         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3241         (TEST):
3242         - Remove '*' from RetainPtr<> type.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3245         (TEST(WebKit, JITEnabled)):
3246         - Add missing WTFMove().  Apparently a temporary was being
3247           created before in the argument list due to mismatched
3248           RetainPtr<> types.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3251         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3252         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3253         (TestWebKitAPI::TEST):
3254         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3255         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3256         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3257         (WTR::resourcesDirectoryURL):
3258         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3259         (WTR::InjectedBundle::platformInitialize):
3260         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3261         - Remove '*' from RetainPtr<> type.
3262
3263 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3264
3265         A MediaTime timescale must never be zero
3266         https://bugs.webkit.org/show_bug.cgi?id=193156
3267         <rdar://problem/32504501>
3268
3269         Reviewed by Jer Noble.
3270
3271         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3272         (TestWebKitAPI::TEST): Add tests for zero timescale.
3273
3274 2019-01-07  Youenn Fablet  <youenn@apple.com>
3275
3276         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3277         https://bugs.webkit.org/show_bug.cgi?id=193175
3278
3279         Reviewed by Chris Dumez.
3280
3281         Updated API test as we bumped the SW schema to version 4.
3282
3283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3284         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3285         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3286         (TEST):
3287
3288 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3289
3290         [Win][Clang] Fix compilation warnings of MiniBrowser
3291         https://bugs.webkit.org/show_bug.cgi?id=193029
3292
3293         Reviewed by Ross Kirsling.
3294
3295         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3296         and m_URLBarFont. Reorder member variables to fix -Wreorder
3297         warning.
3298         * MiniBrowser/win/PageLoadTestClient.cpp:
3299         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3300         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3301         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3302         m_currentURLIndex.
3303         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3304         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3305         navigationClient with '{ }' to fix the missing field warning.
3306         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3307         (initDocStruct): Changed the argument type docname to const.
3308
3309 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3310
3311         [WebAuthN] Import U2F command/response converters from Chromium
3312         https://bugs.webkit.org/show_bug.cgi?id=193150
3313         <rdar://problem/47054028>
3314
3315         Reviewed by Brent Fulgham.
3316
3317         Adds API tests.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3321         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3322         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3323         (TestWebKitAPI::getTestAttestationObjectBytes):
3324         (TestWebKitAPI::getTestSignResponse):
3325         (TestWebKitAPI::getTestU2fRegisterResponse):
3326         (TestWebKitAPI::TEST):
3327         (TestWebKitAPI::convertToVector): Deleted.
3328         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3329         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3330         (TestWebKitAPI::constructMakeCredentialRequest):
3331         (TestWebKitAPI::constructGetAssertionRequest):
3332         (TestWebKitAPI::TEST):
3333
3334 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3335
3336         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3337         https://bugs.webkit.org/show_bug.cgi?id=193136
3338
3339         Reviewed by Michael Catanzaro.
3340
3341         * gtk/install-dependencies:
3342         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3343         they are needed by update-webkitgtk-libs.
3344
3345 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3346
3347         Unreviewed follow-up fix to r239650
3348         https://bugs.webkit.org/show_bug.cgi?id=193140
3349         <rdar://problem/47063037>
3350
3351         Typecast patch_id to string.
3352
3353         * BuildSlaveSupport/ews-build/steps.py:
3354         (ValidatePatch._is_patch_obsolete):
3355
3356 2019-01-04  Daniel Bates  <dabates@apple.com>
3357
3358         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3359         https://bugs.webkit.org/show_bug.cgi?id=193024
3360
3361         Reviewed by Jer Noble.
3362
3363         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3364         for the bitmask type WebEventFlags as an example.
3365
3366         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3367         that can be used to register summary and synthetic child formatters for a bitmask type.
3368         For example, consider the following enum and bitmask typedefs:
3369
3370         typedef enum {
3371             A = 1 << 0,
3372             B = 1 << 1,
3373             C = 1 << 2,
3374         } SpecialFlagValues;
3375         typedef unsigned SpecialFlags;
3376
3377         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3378         __lldb_init_module():
3379
3380             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3381                     1 << 0: "A",
3382                     1 << 1: "B",
3383                     1 << 2: "C",
3384             })
3385
3386         * lldb/lldb_webkit.py:
3387         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3388         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3389         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3390         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3391         A convenience function to dynamically creaste a synthetic formatter class and summary
3392         string function for the specified bitmask type and enumerator value to name map. This
3393         function register the dynamically created class and function with LLDB.
3394
3395         (__lldb_init_module):
3396         (FlagEnumerationProvider):
3397         (FlagEnumerationProvider._enumerator_value_to_name_map):
3398         (FlagEnumerationProvider._bitmask):
3399         (FlagEnumerationProvider._update):
3400         (FlagEnumerationProvider.has_children):
3401         (FlagEnumerationProvider.num_children):
3402         (FlagEnumerationProvider.get_child_index):
3403         (FlagEnumerationProvider.get_child_at_index):
3404         (FlagEnumerationProvider.update):
3405         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3406
3407         (WTFOptionSetProvider):
3408         (WTFOptionSetProvider._enumerator_value_to_name_map):
3409         (WTFOptionSetProvider._bitmask):
3410         (WTFOptionSetProvider._update):
3411         Write in terms of the base class.
3412
3413         (RawBitmaskProviderBase):
3414         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3415         (RawBitmaskProviderBase._bitmask):
3416         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3417         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3418         {
3419             1 << 0: "A",
3420             1 << 1: "B",
3421             1 << 2: "C",
3422         }
3423         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3424         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3425
3426         (WTFOptionSetProvider.has_children): Deleted.
3427         (WTFOptionSetProvider.num_children): Deleted.
3428         (WTFOptionSetProvider.get_child_index): Deleted.
3429         (WTFOptionSetProvider.get_child_at_index): Deleted.
3430         (WTFOptionSetProvider.update): Deleted.
3431
3432 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3433
3434         [ews-build] Add build step to validate the patch before processing it
3435         https://bugs.webkit.org/show_bug.cgi?id=193140
3436
3437         Reviewed by Lucas Forschler.
3438
3439         * BuildSlaveSupport/ews-build/factories.py:
3440         (Factory.__init__): Added ValidatePatch step.
3441         * BuildSlaveSupport/ews-build/steps.py:
3442         (ValidatePatch):
3443         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3444         (ValidatePatch.get_patch_json): Get patch json data.
3445         (ValidatePatch.get_bug_json): Get bug json data.
3446         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3447         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3448         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3449         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3450         (ValidatePatch.skip_build): Skip the build.
3451         (ValidatePatch.start):
3452
3453 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3454
3455         Progress towards fixing Mac CMake build
3456         https://bugs.webkit.org/show_bug.cgi?id=193105
3457
3458         Reviewed by Don Olmstead.
3459
3460         * TestWebKitAPI/PlatformMac.cmake:
3461
3462 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3463
3464         Fix API test after r239631
3465         https://bugs.webkit.org/show_bug.cgi?id=193118
3466
3467         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3468         (TestWebKitAPI::TEST):
3469         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3470         Do the same thing via the API to fix the test.
3471
3472 2019-01-04  Jer Noble  <jer.noble@apple.com>
3473
3474         [WebKitLegacy] Media playback pauses on scroll
3475         https://bugs.webkit.org/show_bug.cgi?id=192829
3476
3477         Reviewed by Eric Carlson.
3478
3479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3481         (TestWebKitAPI::TEST):
3482         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3483         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3484         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3485         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3486         (TestWebKitAPI::TEST):
3487
3488 2019-01-04  Chris Dumez  <cdumez@apple.com>
3489
3490         Add support for toggling device orientation API support per site
3491         https://bugs.webkit.org/show_bug.cgi?id=193143
3492         <rdar://problem/46605724>
3493
3494         Reviewed by Alex Christensen.
3495
3496         Add API test coverage.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3499         (-[DataMappingSchemeHandler setTaskHandler:]):
3500         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3501         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3502         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3503         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3504
3505 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3506
3507         [ews-build] use svn-apply script to apply the patches
3508         https://bugs.webkit.org/show_bug.cgi?id=193138
3509
3510         Reviewed by Lucas Forschler.
3511
3512         * BuildSlaveSupport/ews-build/factories.py:
3513         (Factory.__init__): Add the ApplyPatch step.
3514         * BuildSlaveSupport/ews-build/steps.py:
3515         (CheckOutSource): Added step name.
3516         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3517         (ApplyPatch): Build step to apply patch using svn-apply script.
3518         (UnApplyPatchIfRequired):
3519         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3520
3521 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3522
3523         Deprecate WKContextCreate
3524         https://bugs.webkit.org/show_bug.cgi?id=193118
3525
3526         Reviewed by Brady Eidson.
3527
3528         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3529         (WebKitBrowserWindow::WebKitBrowserWindow):
3530         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3531         (TestWebKitAPI::TEST):
3532         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3533         (TestWebKitAPI::TEST):
3534         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3535         (TestWebKitAPI::TEST):
3536         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3537         (TestWebKitAPI::TEST):
3538         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3539         (TestWebKitAPI::TEST):
3540         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3541         (TestWebKitAPI::TEST):
3542         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3545         (TestWebKitAPI::TEST):
3546         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3547         (TestWebKitAPI::TEST):
3548         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3549         (TestWebKitAPI::TEST):
3550         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3551         (TestWebKitAPI::TEST):
3552         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3553         (TestWebKitAPI::TEST):
3554         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3559         (TestWebKitAPI::TEST):
3560         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3561         (TestWebKitAPI::TEST):
3562         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3563         (TestWebKitAPI::TEST):
3564         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3565         (TestWebKitAPI::TEST):
3566         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3567         (TestWebKitAPI::loadAlternateHTMLString):
3568         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3569         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3570         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3571         (TestWebKitAPI::buildAndPerformTest):
3572         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3573         (TestWebKitAPI::TEST):
3574         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3577         (TestWebKitAPI::TEST):
3578         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3579         (TestWebKitAPI::TEST):
3580         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3583         (TestWebKitAPI::TEST):
3584         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3587         (TestWebKitAPI::TEST):
3588         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3591         (TestWebKitAPI::TEST):
3592         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3595         (TestWebKitAPI::TEST):
3596         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3597         (TestWebKitAPI::TEST):
3598         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3601         (TestWebKitAPI::TEST):
3602         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3603         (TestWebKitAPI::TEST):
3604         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3605         (TestWebKitAPI::TEST):
3606         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3607         (TestWebKitAPI::TEST):
3608         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3609         (TestWebKitAPI::TEST):
3610         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3611         (TestWebKitAPI::TEST):
3612         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3615         (TestWebKitAPI::TEST):
3616         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3617         (TestWebKitAPI::TEST):
3618         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3619         (TestWebKitAPI::TEST):
3620         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3625         (WebKit2_CommandBackForwardTestWKView::SetUp):
3626         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3629         (TestWebKitAPI::TEST):
3630         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3631         (TestWebKitAPI::TEST):
3632         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3633         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3634
3635 2019-01-03  Matt Rajca  <mrajca@apple.com>
3636
3637         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3638         https://bugs.webkit.org/show_bug.cgi?id=193128
3639         rdar://34554231
3640
3641         Reviewed by Jer Noble.
3642
3643         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3644         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3645         event along with a flag that indicates whether or not autoplay was actually prevented.
3646
3647         Tests: existing API tests were updated to reflect the new names. New API tests
3648         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3652         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3653         (TEST):
3654         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3655         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3656
3657 2019-01-04  Chris Dumez  <cdumez@apple.com>
3658
3659         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3660         https://bugs.webkit.org/show_bug.cgi?id=193120
3661
3662         Reviewed by Alex Christensen.
3663
3664         Add API test coverage.
3665
3666         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3667
3668 2019-01-04  Chris Dumez  <cdumez@apple.com>
3669
3670         Crash under WebProcessPool::addSuspendedPage()
3671         https://bugs.webkit.org/show_bug.cgi?id=193110
3672
3673         Reviewed by Youenn Fablet.
3674
3675         Add API test coverage.
3676
3677         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3678
3679 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3680
3681         [ews-build] Check patch relevance before applying the patch
3682         https://bugs.webkit.org/show_bug.cgi?id=193102
3683
3684         Reviewed by Lucas Forschler.
3685
3686         * BuildSlaveSupport/ews-build/factories.py:
3687         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3688
3689 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3690
3691         [ews-build] Check patch relevance step should print patch id
3692         https://bugs.webkit.org/show_bug.cgi?id=193137
3693
3694         Reviewed by Lucas Forschler.
3695
3696         * BuildSlaveSupport/ews-build/steps.py:
3697         (CheckPatchRelevance.start): Update the status to include patch id.
3698
3699 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3700
3701         webkitpy: Increase simulator teardown timeout
3702         https://bugs.webkit.org/show_bug.cgi?id=193141
3703         <rdar://problem/46174217>
3704
3705         Rubber-stamped by Aakash Jain.
3706
3707         * Scripts/webkitpy/xcode/simulated_device.py:
3708         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3709
3710 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3711
3712         test262-runner misbehaves when test file YAML has a trailing space
3713         https://bugs.webkit.org/show_bug.cgi?id=193053
3714
3715         Reviewed by Yusuke Suzuki.
3716
3717         * Scripts/test262/Runner.pm:
3718         (parseData):
3719         Accept trailing space when parsing a test file's YAML block.
3720
3721 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3722
3723         UserMedia test should use WKPageNavigationClient
3724         https://bugs.webkit.org/show_bug.cgi?id=192913
3725
3726         Reviewed by Youenn Fablet.
3727
3728         The test currently uses the deprecated WKPageLoaderClient. It should use
3729         WKPageNavigationClient instead, which provides the same callback under a similar name.
3730
3731         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3732         (TestWebKitAPI::TEST):
3733
3734 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3735
3736         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3737         https://bugs.webkit.org/show_bug.cgi?id=192944
3738
3739         Reviewed by Tim Horton.
3740
3741         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3742         (TestWebKitAPI::TEST):
3743
3744 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3745
3746         Add support for using the current text selection as the find string on iOS
3747         https://bugs.webkit.org/show_bug.cgi?id=193034
3748         <rdar://problem/45138739>
3749
3750         Reviewed by Tim Horton.
3751
3752         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3753         _setStringForFind) works as expected.
3754
3755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3756         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3757
3758 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3759
3760         [ews-build] Use git on OpenSource EWS bots
3761         https://bugs.webkit.org/show_bug.cgi?id=193092
3762
3763         Reviewed by Lucas Forschler.
3764
3765         * BuildSlaveSupport/ews-build/steps.py:
3766         (CheckOutSource): Use git instead of svn.
3767         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3768
3769 2019-01-02  Daniel Bates  <dabates@apple.com>
3770
3771         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3772         https://bugs.webkit.org/show_bug.cgi?id=193023
3773
3774         Reviewed by Simon Fraser.
3775
3776         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3777         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3778         enumerator values. We should just remove this code.
3779
3780         * lldb/lldb_webkit.py:
3781         (WTFOptionSetProvider.has_children):
3782         (WTFOptionSetProvider.num_children):
3783         (WTFOptionSetProvider.get_child_index):
3784         (WTFOptionSetProvider.get_child_at_index):
3785
3786 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3787
3788         .ycm_extra_conf.py should handle XXXInlines.h
3789         https://bugs.webkit.org/show_bug.cgi?id=193055
3790
3791         Reviewed by Carlos Garcia Campos.
3792
3793         compile_commands.json database only records flags and options for cpp source files.
3794         So, when we open headers, this database does not have any information for that.
3795         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3796         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3797         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3798         we attempt to find XXX.cpp and use the configuration if it exists.
3799
3800         * gtk/ycm_extra_conf.py:
3801         (getImplementationFilename):
3802         (FlagsForFile):
3803
3804 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3805
3806         Unreviewed. Support PHP 7.3 in Debian.
3807
3808         Add 7.3 to the list of php versions supported in Debian.
3809
3810         * Scripts/webkitpy/port/base.py:
3811         (Port._debian_php_version):
3812
3813 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3814
3815         Resurrect Mac CMake build
3816         https://bugs.webkit.org/show_bug.cgi?id=192658
3817
3818         Reviewed by Yusuke Suzuki.
3819
3820         * DumpRenderTree/PlatformMac.cmake:
3821         * MiniBrowser/mac/CMakeLists.txt:
3822         * TestWebKitAPI/PlatformMac.cmake:
3823
3824 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3825
3826         [Tools] Remove references to Bison and Flex
3827         https://bugs.webkit.org/show_bug.cgi?id=193033
3828
3829         Reviewed by Michael Catanzaro.
3830
3831         The Bison and Flex tools are not needed anymore since r209883.
3832
3833         * CygwinDownloader/cygwin-downloader.py:
3834         * EWSTools/ubuntu-ews-packages:
3835         * Scripts/filter-build-webkit:
3836         (shouldIgnoreLine):
3837         * gtk/install-dependencies:
3838         * wpe/install-dependencies:
3839
3840 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3841
3842         WebDriver: warn about non existing tests when parsing expectations
3843         https://bugs.webkit.org/show_bug.cgi?id=192979
3844
3845         Reviewed by Michael Catanzaro.
3846
3847         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3848         renamed.
3849
3850         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3851         (WebDriverTestRunner.__init__):
3852
3853 2018-12-21  Chris Dumez  <cdumez@apple.com>
3854
3855         navigator.userAgent in service workers does not reflect customUserAgent set by client
3856         https://bugs.webkit.org/show_bug.cgi?id=192951
3857
3858         Reviewed by Youenn Fablet.
3859
3860         Extend API test coverage.
3861
3862         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3863         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3864         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3865         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3866         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3867
3868 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3869
3870         [WebAuthN] userPresence should always be true
3871         https://bugs.webkit.org/show_bug.cgi?id=192835
3872         <rdar://problem/46538788>
3873
3874         Reviewed by Brent Fulgham.
3875
3876         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3877         (TestWebKitAPI::TEST):
3878
3879 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3880
3881         Add support to run-benchmark to use non-default copies of the browser apps
3882         https://bugs.webkit.org/show_bug.cgi?id=192905
3883         rdar://problem/46845840
3884
3885         Reviewed by Dewei Zhu.
3886         
3887         Add support for a --browser-path argument to run-benchmark, which allows you to use
3888         a custom app bundle for a given browser (only implemented for Safari at present).
3889
3890         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3891         (BenchmarkRunner.__init__):
3892         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3893         (BrowserDriver.__init__):
3894         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3895         (BrowserDriverFactory.create):
3896         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3897         (OSXBrowserDriver._launch_process):
3898         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3899         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3900         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3901         (OSXChromeCanaryDriver.launch_url):
3902         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3903         (OSXFirefoxNightlyDriver.launch_url):
3904         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3905         (OSXSafariDriver.__init__):
3906         (OSXSafariDriver.launch_url):
3907         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3908         (parse_args):
3909         (run_benchmark_plan):
3910         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3911         (WebServerBenchmarkRunner.__init__):
3912         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3913         (FakeBenchmarkRunner.__init__):
3914
3915 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3916
3917         [WebAuthN] Import an APDU coder from Chromium
3918         https://bugs.webkit.org/show_bug.cgi?id=192949
3919         <rdar://problem/46879933>
3920
3921         Reviewed by Brent Fulgham.
3922
3923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3924         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3925         (TestWebKitAPI::TEST):
3926
3927 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3928
3929         Setting the file wrapper and content type of an attachment to a PDF should update its image
3930         https://bugs.webkit.org/show_bug.cgi?id=192984
3931         <rdar://problem/46798028>
3932
3933         Reviewed by Tim Horton.
3934
3935         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3936         PDF data correctly updates the image element.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3939
3940 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3941
3942         Add JSCOnly to bot dashboard
3943         https://bugs.webkit.org/show_bug.cgi?id=192964
3944
3945         Reviewed by Alexey Proskuryakov.
3946
3947         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3948         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3949         useful if they were not so secret, so add them.
3950
3951         There appear to be no build-only bots, so the first column is blank. And of course there are
3952         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3953         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3954         and there's plenty of room in the final column for all the bots.
3955
3956         I had a hard time picking a logo to use, because the JavaScript language does not have an
3957         official logo. But I believe I've found one that will be satisfactory.
3958
3959         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3960
3961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3964         (BubbleQueueServer):
3965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3967         (WebKitBuildbot):
3968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3969         (table.queue-grid tr.platform.linux-jsconly img.logo):
3970
3971 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3972
3973         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3974         https://bugs.webkit.org/show_bug.cgi?id=192821
3975
3976         Reviewed by Chris Dumez.
3977
3978         * DumpRenderTree/mac/DumpRenderTree.mm:
3979         (createWebViewAndOffscreenWindow):
3980         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3981
3982 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3983
3984         [Win][Clang] Fix compilation warnings of DumpRenderTree
3985         https://bugs.webkit.org/show_bug.cgi?id=192924
3986
3987         Reviewed by Alex Christensen.
3988
3989         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3990         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3991         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3992         * DumpRenderTree/win/DumpRenderTree.cpp:
3993         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3994         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3995         object to the argument of setDefaultTextEncodingName instead of a
3996         const string literal.
3997         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3998         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3999         (setCacheFolder): Deleted.
4000         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
4001         * DumpRenderTree/win/EditingDelegate.cpp:
4002         (dump): Use %d for int.
4003         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
4004         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4005         (BSTRFromString): Deleted unused function.
4006         * DumpRenderTree/win/TestRunnerWin.cpp:
4007         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4008         the arguemnt of setQuota instead of const string literal.
4009         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4010         (jsStringRefToWString): Deleted unused function.
4011
4012 2018-12-20  Chris Dumez  <cdumez@apple.com>
4013
4014         Add API test coverage for customUserAgent client setting and service workers
4015         https://bugs.webkit.org/show_bug.cgi?id=192952
4016
4017         Reviewed by Alex Christensen.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4020         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4021         (-[SWSchemes webView:startURLSchemeTask:]):
4022         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4023         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4024
4025 2018-12-20  Chris Dumez  <cdumez@apple.com>
4026
4027         Use Optional::hasValue() instead of Optional::has_value()
4028         https://bugs.webkit.org/show_bug.cgi?id=192948
4029
4030         Reviewed by Tim Horton.
4031
4032         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4033         (TestWebKitAPI::TEST):
4034         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4035         (TestWebKitAPI::TEST):
4036         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4037         (TestWebKitAPI::TEST_F):
4038
4039 2018-12-20  Chris Dumez  <cdumez@apple.com>
4040
4041         Add style script rule to check for uses of std::optional<>
4042         https://bugs.webkit.org/show_bug.cgi?id=192931
4043
4044         Reviewed by Tim Horton.
4045
4046         * Scripts/webkitpy/style/checkers/cpp.py:
4047         (check_wtf_optional):
4048         (check_style):
4049
4050 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4051
4052         [WebAuthN] Add a runtime flag for local authenticator
4053         https://bugs.webkit.org/show_bug.cgi?id=192792
4054         <rdar://problem/46798738>
4055
4056         Reviewed by Brent Fulgham.
4057
4058         * DumpRenderTree/TestOptions.cpp:
4059         (TestOptions::TestOptions):
4060         * DumpRenderTree/TestOptions.h:
4061         * DumpRenderTree/mac/DumpRenderTree.mm:
4062         (enableExperimentalFeatures):
4063         (setWebPreferencesForTestOptions):
4064         * WebKitTestRunner/TestController.cpp:
4065         (WTR::TestController::resetPreferencesToConsistentValues):
4066         (WTR::updateTestOptionsFromTestHeader):
4067         * WebKitTestRunner/TestOptions.h:
4068         (WTR::TestOptions::hasSameInitializationOptions const):
4069
4070 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4071
4072         webkitpy: Autoinstall package URLs have changed
4073         https://bugs.webkit.org/show_bug.cgi?id=192909
4074         <rdar://problem/46860359>
4075
4076         Rubber-stamped by Alexey Proskuryakov.
4077
4078         PyPi urls have been moved around, we need to update our auto-installed packages.
4079
4080         We should check for Selenium before asking PyPi for the latest version.
4081
4082         * Scripts/webkitpy/thirdparty/__init__.py:
4083         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4084         (AutoinstallImportHook._install_keyring): Ditto.
4085         (AutoinstallImportHook._install_pep8): Ditto.
4086         (AutoinstallImportHook._install_mozlog): Ditto.
4087         (AutoinstallImportHook._install_mozprocess): Ditto.
4088         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4089         (AutoinstallImportHook._install_pytest): Ditto.
4090         (AutoinstallImportHook._install_pylint): Ditto.
4091         (AutoinstallImportHook._install_buildbot): Ditto.
4092         (AutoinstallImportHook._install_coverage): Ditto.
4093         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4094         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4095         for new Selenium if the installed version isn't sufficient.
4096         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4097
4098 2018-12-20  Chris Dumez  <cdumez@apple.com>
4099
4100         Use Optional::valueOr() instead of Optional::value_or()
4101         https://bugs.webkit.org/show_bug.cgi?id=192933
4102
4103         Reviewed by Geoffrey Garen.
4104
4105         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4106         (TestWebKitAPI::checkURL):
4107         (TestWebKitAPI::checkRelativeURL):
4108         (TestWebKitAPI::checkURLDifferences):
4109         (TestWebKitAPI::checkRelativeURLDifferences):
4110         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4111         (TestWebKitAPI::checkURL):
4112
4113 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4114
4115         Unreviewed, rolling out r239417.
4116
4117         Introduced two API test failures on macOS.
4118
4119         Reverted changeset:
4120
4121         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4122         occlusion changes"
4123         https://bugs.webkit.org/show_bug.cgi?id=192821
4124         https://trac.webkit.org/changeset/239417
4125
4126 2018-12-20  Devin Rousso  <drousso@apple.com>
4127
4128         Web Inspector: UIString should take an optional key and description to aid localization
4129         https://bugs.webkit.org/show_bug.cgi?id=153962
4130         <rdar://problem/24542505>
4131
4132         Reviewed by Brian Burg.
4133
4134         * Scripts/extract-localizable-js-strings:
4135
4136 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4137
4138         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4139         https://bugs.webkit.org/show_bug.cgi?id=192923
4140         <rdar://problem/46859068>
4141
4142         Reviewed by Wenson Hsieh.
4143
4144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4145         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4146         Add a test ensuring that both parented and unparented WKWebViews can
4147         retrieve main resource data when loading a PDF.
4148
4149 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4150
4151         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4152         https://bugs.webkit.org/show_bug.cgi?id=192852
4153
4154         Reviewed by Michael Catanzaro.
4155
4156         EmojiOne font was replaced by Noto Color Emoji.
4157
4158         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4159         * gtk/jhbuild.modules:
4160         * wpe/jhbuild.modules:
4161
4162 2018-12-19  Chris Dumez  <cdumez@apple.com>
4163
4164         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4165         https://bugs.webkit.org/show_bug.cgi?id=192728
4166         <rdar://problem/46746779>
4167
4168         Reviewed by Geoff Garen.
4169
4170         * DumpRenderTree/*:
4171         * MiniBrowser/*:
4172         * TestRunnerShared/*:
4173         * TestWebKitAPI/*:
4174         * WebGPUAPIStructure/*:
4175         * WebKitTestRunner/*:
4176
4177 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4178
4179         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4180         https://bugs.webkit.org/show_bug.cgi?id=192821
4181
4182         Reviewed by Chris Dumez.
4183
4184         * DumpRenderTree/mac/DumpRenderTree.mm:
4185         (createWebViewAndOffscreenWindow):
4186
4187 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4188
4189         Navigations away from the SafeBrowsing interstitial show a flash of old content
4190         https://bugs.webkit.org/show_bug.cgi?id=192676
4191
4192         Reviewed by Chris Dumez.
4193
4194         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4195         (safeBrowsingView):
4196         (TEST):
4197         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4198
4199 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4200
4201         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4202         https://bugs.webkit.org/show_bug.cgi?id=192855
4203
4204         Reviewed by Michael Catanzaro.
4205
4206         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4207         (WTR::TestController::notifyDone): Use the WPE implementation.
4208         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4209         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4210         (WTR::TestController::platformRunUntil): Honor the condition flag.
4211
4212 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4213
4214         Allow clients to set the navigator platform
4215         https://bugs.webkit.org/show_bug.cgi?id=192735
4216
4217         Reviewed by Tim Horton.
4218
4219         Add a test for setting a custom navigator platform.
4220
4221         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4222         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4223         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
4224
4225 2018-12-19  Truitt Savell  <tsavell@apple.com>
4226
4227         Unreviewed, rolling out r239358.
4228
4229         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
4230         crash on Debug bots
4231
4232         Reverted changeset:
4233
4234         "Clean up IndexedDB files between tests"
4235         https://bugs.webkit.org/show_bug.cgi?id=192796
4236         https://trac.webkit.org/changeset/239358
4237
4238 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4239
4240         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
4241         https://bugs.webkit.org/show_bug.cgi?id=192842
4242         <rdar://problem/46823586>
4243
4244         Reviewed by Tim Horton.
4245
4246         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
4247         item provider when dragging a rich text selection.
4248
4249         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4250
4251 2018-12-18  David Quesada  <david_quesada@apple.com>
4252
4253         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
4254         https://bugs.webkit.org/show_bug.cgi?id=192810
4255         <rdar://problem/46812536>
4256
4257         Reviewed by Alex Christensen.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4260         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4261             After releasing our reference to the web view, wait until the next turn of the runloop
4262             before checking that the originatingWebView has been zeroed, since the web view might
4263             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
4264             testing general memory management of WKWebViews, only that _WKDownload does not retain
4265             its web view via the 'originatingWebView' property.
4266
4267 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
4268
4269         Clean up IndexedDB files between tests
4270         https://bugs.webkit.org/show_bug.cgi?id=192796
4271
4272         Reviewed by Geoffrey Garen.
4273
4274         * DumpRenderTree/mac/DumpRenderTree.mm:
4275         (runTest):
4276         * WebKitTestRunner/TestController.cpp:
4277         (WTR::TestController::resetStateToConsistentValues):
4278         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4279         (WTR::RemoveAllIndexedDatabasesCallback):
4280         (WTR::TestController::ClearIndexedDatabases):
4281         * WebKitTestRunner/TestController.h:
4282
4283 2018-12-18  Alex Christensen  <achristensen@webkit.org>
4284
4285         Fix API test introduced in r239339 on iOS.