get rebaselining tools to kinda work with the skia overrides file
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
2
3         get rebaselining tools to kinda work with the skia overrides file
4         https://bugs.webkit.org/show_bug.cgi?id=88456
5
6         Reviewed by Ryosuke Niwa.
7
8         Update rebaseline-expectations so that we read in the overrides
9         when looking for tests to rebaseline, but don't read in the
10         overrides when we are writing the expectations file back out.
11         This prevents the overrides from getting written into the main
12         file. This is kind of a hack but will have to do until we
13         support multiple expectations files properly.
14
15         * Scripts/webkitpy/tool/commands/rebaseline.py:
16         (RebaselineExpectations._expectations):
17         (RebaselineExpectations._update_expectations_file):
18         (RebaselineExpectations._tests_to_rebaseline):
19         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20         (test_overrides_are_included_correctly):
21
22 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
23
24         webkitpy: two manager_worker_broker_unittest tests are broken
25         https://bugs.webkit.org/show_bug.cgi?id=88445
26
27         Reviewed by Ojan Vafai.
28
29         These tests were never updated when we removed the
30         --worker-model argument, and we were passing 'inline' instead of
31         1 (for the number of workers) :(. As a result we were creating
32         multiprocessing queues unnecessarily and that was failing on cygwin.
33
34         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
35         (InterfaceTest.test_managerconnection_is_abstract):
36         (InterfaceTest.test_workerconnection_is_abstract):
37
38 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
39
40         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
41         https://bugs.webkit.org/show_bug.cgi?id=87406
42
43         Reviewed by Dirk Pranke.
44
45         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
46         (TestExpectations.__init__):
47         * Scripts/webkitpy/tool/commands/rebaseline.py:
48         (RebaselineTest._update_expectations_file):
49         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
50         (test_rebaseline_does_not_include_overrides):
51
52 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
53
54         webkitpy: perf tests unit tests fail on chromium win
55         https://bugs.webkit.org/show_bug.cgi?id=88279
56
57         Reviewed by Ryosuke Niwa.
58
59         I'm seeing weird failures running the unit tests in my win32
60         checkout, and we don't really expect webpagereplay to work on
61         win32 anyway, so I'm skipping the import of that module for now
62         and adding a warning.
63
64         * Scripts/run-perf-tests:
65         * Scripts/webkitpy/performance_tests/perftest.py:
66
67 2012-06-06  Yong Li <yoli@rim.com>
68
69         Unreviewed. Update my email address in committers.py.
70
71         * Scripts/webkitpy/common/config/committers.py:
72
73 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
74
75         Add Robert Kroeger  to commiters.py
76         https://bugs.webkit.org/show_bug.cgi?id=88415
77
78         Unreviewed.
79
80         * Scripts/webkitpy/common/config/committers.py:
81
82 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
83
84         [EFL][DRT] http/tests/globalhistory testcases do not pass
85         https://bugs.webkit.org/show_bug.cgi?id=82579
86
87         Reviewed by Csaba Osztrogonác.
88
89         DRT has provided callbacks for ewk_view "global history delegate" signals.
90
91         * DumpRenderTree/efl/DumpRenderTree.cpp:
92         (isGlobalHistoryTest): Aux function to ident global history testcase.
93         (createLayoutTestController):
94         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
95         (DumpRenderTreeChrome::createView):
96         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
97         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
98         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
99         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
100         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
101         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
102         (DumpRenderTreeChrome):
103
104 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
105
106         [Qt] run-qtwebkit-tests hangs with -j1
107         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
108         This could happen due to an uncancelled timer after results were returned. This timer was
109         started only if --timeout was set.
110         https://bugs.webkit.org/show_bug.cgi?id=85475
111
112         Reviewed by Csaba Osztrogonác.
113
114         * Scripts/run-qtwebkit-tests:
115         (run_test):
116
117 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
118
119         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
120         https://bugs.webkit.org/show_bug.cgi?id=88327
121
122         Reviewed by Kenneth Rohde Christiansen.
123
124         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
125         * MiniBrowser/qt/icons/contents_width.png: Added.
126         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
127         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
128
129 2012-06-05  Jon Lee  <jonlee@apple.com>
130
131         Buildbot fix.
132
133         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
134         in the function. Store in a local variable.
135         (loadBuilderConfig):
136
137 2012-06-05  Jon Lee  <jonlee@apple.com>
138
139         Buildbot fix.
140
141         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
142         (loadBuilderConfig):
143
144 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
145
146         webkitpy: clean up win-specific path handling and tests
147         https://bugs.webkit.org/show_bug.cgi?id=88281
148
149         Reviewed by Adam Barth.
150
151         There was a bunch of inconsistent logic for handling path
152         conversions for win32 and cygwin paths due to us sometimes
153         looking at sys.platform and sometimes using mock hosts. This
154         patch cleans everything up so that we are required to pass
155         PlatformInfo objects to the path module and stop trying to do
156         different things when running on cygwin or win32 hosts (except
157         in the path_unittest module itself).
158
159         This may slightly reduce test coverage for the win32 code paths
160         but will be a lot easier to follow and maintain.
161
162         * Scripts/webkitpy/common/system/path.py:
163         (abspath_to_uri):
164         (_convert_path):
165         * Scripts/webkitpy/common/system/path_unittest.py:
166         (AbspathTest.platforminfo):
167         (AbspathTest.test_abspath_to_uri_cygwin):
168         (AbspathTest.test_abspath_to_uri_unixy):
169         (AbspathTest.test_abspath_to_uri_win):
170         (AbspathTest.test_abspath_to_uri_escaping_unixy):
171         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
172         (AbspathTest.test_stop_cygpath_subprocess):
173         * Scripts/webkitpy/common/system/platforminfo.py:
174         (PlatformInfo.__init__):
175         (PlatformInfo.is_cygwin):
176         * Scripts/webkitpy/common/system/platforminfo_mock.py:
177         (MockPlatformInfo.is_cygwin):
178         * Scripts/webkitpy/layout_tests/port/base.py:
179         (Port.to.show_results_html_file):
180         * Scripts/webkitpy/layout_tests/port/driver.py:
181         (Driver.test_to_uri):
182         (Driver.uri_to_test):
183         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
184         (DriverTest.test_test_to_uri):
185         (DriverTest.test_uri_to_test):
186         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
187         (MockDRTPortTest.make_port):
188         (MockDRTTest.input_line):
189         (MockChromiumDRTTest.test_pixeltest__fails):
190         * Scripts/webkitpy/layout_tests/port/test.py:
191         * Scripts/webkitpy/layout_tests/port/win.py:
192         (WinPort.show_results_html_file):
193         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
194         (MainTest.test_unexpected_failures):
195         (MainTest.test_results_directory_absolute):
196         (MainTest.test_results_directory_default):
197         (MainTest.test_results_directory_relative):
198
199 2012-06-05  Jon Lee  <jonlee@apple.com>
200
201         Workaround buildbot bug when merging build requests.
202         https://bugs.webkit.org/show_bug.cgi?id=88158
203
204         Reviewed by Mark Rowe.
205
206         For expediency, we still want testers to pick the latest build to test, but to ensure
207         that the builders are reporting the correct revision number, we should let the building bots
208         run as they normally would. That is, the builder picks the oldest revision, and merges
209         subsequent requests. Because merged requests get appended to the list of changes for a given
210         build, the last change in that list is also the latest change. When we used pickLatestBuild
211         for the builders, this was not the case (it would always report the penultimate change).
212
213         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
214
215         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
216         for all Apple builders.
217         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
218         the latest build to run.
219         (loadBuilderConfig):
220
221 2012-06-05  Jessie Berlin  <jberlin@apple.com>
222
223         [Win] DumpRenderTree should call resetInternalsObject
224         https://bugs.webkit.org/show_bug.cgi?id=88346
225
226         Reviewed by Simon Fraser.
227
228         Invoke it on Windows in the same place it is invoked on Mac.
229
230         * DumpRenderTree/win/DumpRenderTree.cpp:
231         (resetWebViewToConsistentStateBeforeTesting):
232
233 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
234
235         [GTK] Fix two more memory leaks in DRT
236         https://bugs.webkit.org/show_bug.cgi?id=88255
237
238         Reviewed by Martin Robinson.
239
240         Fixed memory leaks in GTK's DRT code.
241
242         * DumpRenderTree/gtk/DumpRenderTree.cpp:
243         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
244         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
245         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
246         (createBitmapContextFromWebView): Free the cairo surface.
247
248 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
249
250         [Qt] Building when a top directory is named Source
251         https://bugs.webkit.org/show_bug.cgi?id=77727
252
253         Reviewed by Tor Arne Vestbø.
254
255         Change regex to only replace the last instance of OUT_PWD.
256
257         * qmake/mkspecs/features/default_pre.prf:
258
259 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
260
261         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
262         https://bugs.webkit.org/show_bug.cgi?id=73176
263
264         Reviewed by Adam Barth.
265
266         Two more APIs are added in Custom Scheme Handler specification.
267         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
268         One is 'isProtocolHandlerRegistered' to query whether the specific URL
269         is registered or not.
270         The other is 'unregisterProtocolHandler' to remove the registered URL.
271
272         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
273
274 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
275
276         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
277         https://bugs.webkit.org/show_bug.cgi?id=83879
278
279         Reviewed by Carlos Garcia Campos.
280
281         Make minibrowser connect to the new 'permission requests' signal
282         to allow users handle the Geolocation permission requests.
283
284         * MiniBrowser/gtk/BrowserWindow.c:
285         (geolocationRequestDialogCallback): Callback for the dialog asking
286         the user for allowing or not geolocation permission requests.
287         (webViewDecidePermissionRequest): Launch a dialog to ask the user
288         whether to allow or deny geolocation permission requests.
289         (browserWindowConstructed): Connect to 'permission-request' signal.
290
291 2012-06-04  Chase Phillips  <cmp@google.com>
292
293         Make a builder group support+expect multiple loads.
294         https://bugs.webkit.org/show_bug.cgi?id=88260
295
296         Change BuilderGroup to allow expecting multiple
297         loads.  This allows merging results for a given set
298         of builders into one group.
299
300         Add a test that verifies that the group count
301         increments correctly based on successful and failed
302         list loads.
303
304         Reviewed by Ojan Vafai.
305
306         * TestResultServer/static-dashboards/builders.js:
307         (BuilderGroup):
308         (BuilderGroup.prototype.setbuilder):
309         (BuilderGroup.prototype.append):
310         (BuilderGroup.prototype.loaded):
311         (requestBuilderList.xhr.onload):
312         (requestBuilderList.xhr.onerror):
313         (onErrorLoadingBuilderList):
314         (loadBuildersList):
315         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
316         (test):
317         * TestResultServer/static-dashboards/run-unittests.html:
318
319 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
320
321         Python test fix attempt for Chromium Windows.
322
323         * Scripts/webkitpy/layout_tests/port/driver.py:
324         (Driver.uri_to_test):
325
326 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
327
328         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
329         https://bugs.webkit.org/show_bug.cgi?id=88243
330
331         Reviewed by Adam Barth.
332
333         * qmake/mkspecs/features/features.prf:
334
335 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
336
337         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
338         https://bugs.webkit.org/show_bug.cgi?id=88280
339
340         Unreviewed, build fix.
341
342         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
343         (TestServerProcess.test_basic):
344
345 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
346
347         test-webkitpy is hanging under cygwin
348         https://bugs.webkit.org/show_bug.cgi?id=88269
349
350         Reviewed by Ryosuke Niwa.
351
352         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
353         so we need to skip any tests that use it.
354
355         * Scripts/webkitpy/common/system/executive.py:
356         (Executive.run_in_parallel):
357         * Scripts/webkitpy/common/system/executive_unittest.py:
358         (ExecutiveTest.test_run_in_parallel):
359
360 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
361
362         test-webkitpy is failing on win32 after r115054
363         https://bugs.webkit.org/show_bug.cgi?id=88264
364
365         Reviewed by Ryosuke Niwa.
366
367         The failing http_server test was improperly suppressed (the
368         tuple was missing a comma, and so wasn't a tuple at all, just a
369         string) and so we were skipping *all* tests on win32. The right
370         way to skip a single test is to disable it inside the test
371         itself.
372
373         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
374         (TestHttpServer.test_start_cmd):
375         * Scripts/webkitpy/test/test_finder.py:
376         (TestFinder._default_names):
377         * Scripts/webkitpy/test/main.py:
378         (Tester.run): Add error message if we don't find any tests to run.
379         * Scripts/webkitpy/test/main_unittest.py:
380             
381
382 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
383
384         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
385         https://bugs.webkit.org/show_bug.cgi?id=88215
386
387         Reviewed by Martin Robinson.
388
389         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
390         for newly allocated strings.
391
392         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
393         (attributeSetToString):
394         (AccessibilityUIElement::allAttributes):
395
396 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
397
398         [GTK] Memory leaks in DumpRenderTree.cpp
399         https://bugs.webkit.org/show_bug.cgi?id=88213
400
401         Reviewed by Martin Robinson.
402
403         Fixed memory leaks in DumpRenderTree.
404
405         * DumpRenderTree/gtk/DumpRenderTree.cpp:
406         (appendString): Accepts const gchar* as the second argument.
407         (dumpFramesAsText): Free the string returned by g_strdup_printf().
408         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
409
410 2012-06-04  David Dorwin  <ddorwin@chromium.org>
411
412         Enable Chromium media player to instantiate a plugin
413         https://bugs.webkit.org/show_bug.cgi?id=87399
414
415         Reviewed by Kent Tamura.
416
417         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
418
419         * DumpRenderTree/chromium/WebViewHost.cpp:
420         (WebViewHost::createPopupMenu):
421
422 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
423
424         [GTK][WK2] Implement geolocation provider for the GTK port
425         https://bugs.webkit.org/show_bug.cgi?id=83877
426
427         Reviewed by Carlos Garcia Campos.
428
429         * gtk/generate-gtkdoc:
430         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
431
432 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
433
434         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
435         https://bugs.webkit.org/show_bug.cgi?id=87668
436
437         Reviewed by Ryosuke Niwa.
438
439         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
440         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
441         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
442
443         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
444         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
445
446 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
447
448         [EFL] Refactor ewk_view_context_paint code.
449         https://bugs.webkit.org/show_bug.cgi?id=85588
450
451         Reviewed by Hajime Morita.
452
453         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
454
455 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
456
457         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
458         https://bugs.webkit.org/show_bug.cgi?id=87869
459
460         Reviewed by Andreas Kling.
461
462         Replace %lld by PRId64 macro to print an int64_t value and silent a
463         compilation warning on 64-Bit.
464
465         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
466         (onExceededApplicationCacheQuota):
467
468 2012-06-03  Varun Jain  <varunjain@google.com>
469
470         [chromium] Add new gesture type (two finger tap) that triggers context menu.
471         https://bugs.webkit.org/show_bug.cgi?id=88173
472
473         Reviewed by Adam Barth.
474
475         * DumpRenderTree/chromium/EventSender.cpp:
476         (EventSender::EventSender):
477         (EventSender::gestureTwoFingerTap):
478         (EventSender::gestureEvent):
479         * DumpRenderTree/chromium/EventSender.h:
480         (EventSender):
481
482 2012-06-02  Zeno Albisser  <zeno@webkit.org>
483
484         Fix and enable WebGL for WebKit2 on Qt.
485         https://bugs.webkit.org/show_bug.cgi?id=86214
486
487         Enable WebGL by default for Qt MiniBrowser.
488
489         Reviewed by Noam Rosenthal.
490
491         * MiniBrowser/qt/qml/BrowserWindow.qml:
492
493 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
494
495         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
496         https://bugs.webkit.org/show_bug.cgi?id=88164
497
498         Reviewed by Kentaro Hara.
499
500         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
501         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
502
503         * Scripts/VCSUtils.pm:
504         (adjustPathForRecentRenamings):
505         (fixChangeLogPatch):
506
507 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
508
509         Rename test_expectations.txt to TestExpectations
510         https://bugs.webkit.org/show_bug.cgi?id=86690
511
512         Reviewed by Dirk Pranke.
513
514         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
515         We can the code to read test_expectations.txt once we've successfully transitioned.
516
517         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
518         (TestExpectationParser._check_path_does_not_exist):
519         (TestExpectationParser._tokenize):
520         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
521         * Scripts/webkitpy/layout_tests/port/base.py:
522         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
523         test_expectations.txt if one exists and the path to TestExpectations otherwise.
524         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
525         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
526         virtual.
527         * Scripts/webkitpy/layout_tests/port/chromium.py:
528         (ChromiumPort.path_from_chromium_base):
529         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
530         (ChromiumAndroidPort.test_expectations):
531         * Scripts/webkitpy/layout_tests/port/test.py:
532         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
533         (TestPort.__init__):
534         * Scripts/webkitpy/layout_tests/port/webkit.py:
535         (WebKitPort.baseline_search_path):
536         (WebKitPort.test_expectations):
537         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
538         tests to base as a follow up.
539         (WebKitPortTest.test_path_to_test_expectations_file):
540         (test_test_expectations):
541         (test_legacy_test_expectations):
542         * Scripts/webkitpy/style/checker.py:
543         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
544         with one for TestExpectations.
545         * Scripts/webkitpy/style/checkers/test_expectations.py:
546         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
547         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
548         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
549         test_expectations.txt.
550         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
551         (TestExpectationsTestCase.assert_lines_lint):
552         * Scripts/webkitpy/tool/commands/queries.py:
553         (PrintExpectations.__init__):
554         * Scripts/webkitpy/tool/commands/rebaseline.py:
555         (RebaselineExpectations):
556         * Scripts/webkitpy/tool/steps/commit.py:
557         (Commit._check_test_expectations):
558         * Scripts/webkitpy/tool/steps/commit_unittest.py:
559         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
560         (CommitTest.test_check_test_expectations): For TestExpectations.
561         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
562         * TestResultServer/static-dashboards/dashboard_base.js:
563         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
564         Error only when neither exists.
565         * TestResultServer/static-dashboards/flakiness_dashboard.js:
566         (processMissingAndExtraExpectations):
567         (htmlForTestsWithExpectationsButNoFailures):
568         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
569
570 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
571
572         Remove dependency from ImageDiff to WTF
573         https://bugs.webkit.org/show_bug.cgi?id=88147
574
575         Reviewed by Adam Barth.
576
577         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
578
579 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
580
581         NRWT seems to leak (more?) temp dirs
582         https://bugs.webkit.org/show_bug.cgi?id=88126
583
584         Re-land r119297 with chromium fix (weren't calling the
585         super() method if not in --test-shell mode in start().
586         Add unit tests to chromium_unittest as well to check.
587
588         * Scripts/webkitpy/layout_tests/port/chromium.py:
589         (ChromiumDriver.start):
590         * Scripts/webkitpy/layout_tests/port/webkit.py:
591         (WebKitDriver.__del__):
592         (WebKitDriver._start):
593         (WebKitDriver.run_test):
594         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
595         (WebKitDriverTest.test_check_for_driver_crash):
596         (WebKitDriverTest.test_stop_cleans_up_properly):
597         (WebKitDriverTest):
598         (WebKitDriverTest.test_two_starts_cleans_up_properly):
599         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
600         (ChromiumDriverTest.test_stop_cleans_up_properly):
601         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
602
603 2012-06-01  Tim Horton  <timothy_horton@apple.com>
604
605         Lots of "failed download-built-product" on Apple bots
606         https://bugs.webkit.org/show_bug.cgi?id=88158
607
608         Reviewed by Jessie Berlin.
609         
610         Disable mergeRequests on all Apple builders. This is a speculative fix.
611
612         * BuildSlaveSupport/build.webkit.org-config/config.json:
613
614 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
615
616         Unreviewed, rolling out r119297.
617         http://trac.webkit.org/changeset/119297
618         https://bugs.webkit.org/show_bug.cgi?id=88156
619
620         May have broken Chromium bots (Requested by rniwa on #webkit).
621
622         * Scripts/webkitpy/layout_tests/port/webkit.py:
623         (WebKitDriver.__del__):
624         (WebKitDriver.run_test):
625         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
626         (WebKitDriverTest.test_check_for_driver_crash):
627         (WebKitDriverTest.test_stop_cleans_up_properly):
628
629 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
630
631         nrwt seems to leak tmpdirs
632         https://bugs.webkit.org/show_bug.cgi?id=88126
633
634         Reviewed by Ojan Vafai.
635
636         Fix leak possibly introduced in r118979 - we now will
637         make sure we clean up any stale temp directories during the
638         start routine and attempt to clean up again in __del__. It
639         turns out that asserting in __del__ logs a message but is
640         caught by the runtime, so it's mostly useless.
641
642         * Scripts/webkitpy/layout_tests/port/webkit.py:
643         (WebKitDriver.__del__):
644         (WebKitDriver._start):
645         (WebKitDriver.run_test):
646         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
647         (WebKitDriverTest.test_check_for_driver_crash):
648         (WebKitDriverTest.test_stop_cleans_up_properly):
649         (WebKitDriverTest):
650         (WebKitDriverTest.test_two_starts_cleans_up_properly):
651
652 2012-06-01  Michael Saboff  <msaboff@apple.com>
653
654         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
655         https://bugs.webkit.org/show_bug.cgi?id=88109
656
657         Reviewed by Geoffrey Garen.
658
659         Additional test case.
660
661         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
662         (TestWebKitAPI::TEST):
663
664 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
665
666         [Qt] Use -Werror only in developer builds
667
668         Rubber-stamped by Tor Arne Vestbø.
669
670         In production builds -Werror with custom toolchains and wierd system
671         headers, -Werror is of no use and just creates confusion. So use it
672         only if Qt is configured with -developer-build.
673
674         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
675         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
676         only if qt_developer_build is set.
677
678 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
679
680         [watchlist] Add myself to loader and v8 bindings changes
681         https://bugs.webkit.org/show_bug.cgi?id=88112
682
683         Reviewed by Adam Barth.
684
685         * Scripts/webkitpy/common/config/watchlist:
686
687 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
688
689         Adding Jacky Jiang to committers.py
690         https://bugs.webkit.org/show_bug.cgi?id=88122
691
692         Reviewed by Rob Buis.
693
694         Adding myself to committers.py as a Committer.
695
696         * Scripts/webkitpy/common/config/committers.py:
697
698 2012-06-01  Jessie Berlin  <jberlin@apple.com>
699
700         Fix Windows build.
701
702         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
703
704 2012-06-01  Jessie Berlin  <jberlin@apple.com>
705
706         Windows WK2 MouseMoveAfterCrash API test failing
707         https://bugs.webkit.org/show_bug.cgi?id=69982
708
709         Disable the test on Windows to get the bots greener.
710
711         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
712         (TestWebKitAPI::TEST):
713
714 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
715
716         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
717         https://bugs.webkit.org/show_bug.cgi?id=86866
718
719         Reviewed by Adam Barth.
720
721         Catch new "intent,service,register" signal on the frame and print out
722         information about the Web Intent service in EFL's DumpRenderTree.
723
724         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
725         (DumpRenderTreeChrome::createView):
726         (DumpRenderTreeChrome::onFrameCreated):
727         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
728         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
729         (DumpRenderTreeChrome):
730
731 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
732
733         The ChangeLog parser cannot handle reviewers with initials in their name
734         https://bugs.webkit.org/show_bug.cgi?id=87864
735
736         Reviewed by Ryosuke Niwa.
737
738         Add support in the ChangeLog parser for reviewer names that have
739         initials in them.
740
741         * Scripts/webkitpy/common/checkout/changelog.py:
742         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
743         in the replacement string. This allows for matching the word characters before a
744         period, without totally throwing them away.
745         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
746         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
747         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
748
749 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
750
751         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
752         https://bugs.webkit.org/show_bug.cgi?id=86865
753
754         Reviewed by Adam Barth.
755
756         Add deliverWebIntent method to LayoutTestController and provide
757         implementation for EFL port.
758
759         * DumpRenderTree/LayoutTestController.cpp:
760         (deliverWebIntentCallback):
761         (LayoutTestController::staticFunctions):
762         * DumpRenderTree/LayoutTestController.h:
763         (LayoutTestController):
764         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
765         (LayoutTestController::deliverWebIntent):
766         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
767         (LayoutTestController::deliverWebIntent):
768         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
769         (LayoutTestController::deliverWebIntent):
770         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
771         (LayoutTestController::deliverWebIntent):
772         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
773         (LayoutTestController::deliverWebIntent):
774         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
775         (LayoutTestController::deliverWebIntent):
776
777 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
778
779         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
780
781         Reviewed by Simon Hausmann.
782
783         * Tools.pro:
784
785 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
786
787         Add public page loading performance tests using web-page-replay
788         https://bugs.webkit.org/show_bug.cgi?id=84008
789
790         Reviewed by Dirk Pranke.
791
792         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
793         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
794         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
795
796         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
797         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
798         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
799         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
800
801         * Scripts/webkitpy/layout_tests/port/driver.py:
802         (Driver.is_external_http_test): Added.
803         * Scripts/webkitpy/layout_tests/port/webkit.py:
804         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
805         * Scripts/webkitpy/performance_tests/perftest.py:
806         (PerfTest.__init__): Takes port.
807         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
808         (PerfTest):
809         (PerfTest.run): Calls run_single.
810         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
811         (ChromiumStylePerfTest.__init__):
812         (PageLoadingPerfTest.__init__):
813         (PageLoadingPerfTest.run):
814         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
815         (ReplayServer.__init__):
816         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
817         but it caused a dead lock on some web pages.
818         (ReplayServer.stop):
819         (ReplayServer.__del__):
820         (ReplayPerfTest):
821         (ReplayPerfTest.__init__):
822         (ReplayPerfTest._start_replay_server):
823         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
824         The subsequent runs of the same test will just use test.wpr.
825         (ReplayPerfTest.run_single):
826         (PerfTestFactory):
827         (PerfTestFactory.create_perf_test):
828         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
829         (MainTest.test_parse_output):
830         (MainTest.test_parse_output_with_failing_line):
831         (TestPageLoadingPerfTest.test_run):
832         (TestPageLoadingPerfTest.test_run_with_bad_output):
833         (TestReplayPerfTest):
834         (TestReplayPerfTest.ReplayTestPort):
835         (TestReplayPerfTest.ReplayTestPort.__init__):
836         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
837         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
838         (TestReplayPerfTest.ReplayTestPort._driver_class):
839         (TestReplayPerfTest.MockReplayServer):
840         (TestReplayPerfTest.MockReplayServer.__init__):
841         (TestReplayPerfTest.MockReplayServer.stop):
842         (TestReplayPerfTest._add_file):
843         (TestReplayPerfTest._setup_test):
844         (TestReplayPerfTest.test_run_single):
845         (TestReplayPerfTest.test_run_single.run_test):
846         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
847         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
848         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
849         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
850         (TestReplayPerfTest.test_prepare):
851         (TestReplayPerfTest.test_prepare.run_test):
852         (TestReplayPerfTest.test_prepare_calls_run_single):
853         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
854         (TestPerfTestFactory.test_regular_test):
855         (TestPerfTestFactory.test_inspector_test):
856         (TestPerfTestFactory.test_page_loading_test):
857         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
858         (PerfTestsRunner):
859         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
860         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
861         (PerfTestsRunner._collect_tests._is_test_file):
862         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
863         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
864         (create_runner):
865         (run_test):
866         (_tests_for_runner):
867         (test_run_test_set):
868         (test_run_test_set_kills_drt_per_run):
869         (test_run_test_pause_before_testing):
870         (test_run_test_set_for_parser_tests):
871         (test_run_test_set_with_json_output):
872         (test_run_test_set_with_json_source):
873         (test_run_test_set_with_multiple_repositories):
874         (test_run_with_upload_json):
875         (test_upload_json):
876         (test_upload_json.MockFileUploader.upload_single_text_file):
877         (_add_file):
878         (test_collect_tests):
879         (test_collect_tests_with_multile_files):
880         (test_collect_tests_with_multile_files.add_file):
881         (test_collect_tests_with_skipped_list):
882         (test_collect_tests_with_page_load_svg):
883         (test_collect_tests_should_ignore_replay_tests_by_default):
884         (test_collect_tests_with_replay_tests):
885         (test_parse_args):
886         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
887         (AutoinstallImportHook.find_module):
888         (AutoinstallImportHook._install_webpagereplay):
889
890 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
891
892         Support building the Android port of chromium with Ninja
893         https://bugs.webkit.org/show_bug.cgi?id=87545
894
895         Reviewed by Adam Barth.
896
897         Ensures that shared libraries are looked up in a generator-agnostic
898         way and that output is placed in the correct directory.
899
900         Depends on http://codereview.chromium.org/10386188/
901
902         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
903
904 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
905
906         [Chromium] Chromium DRT should be able to load external resources
907         https://bugs.webkit.org/show_bug.cgi?id=87893
908
909         Reviewed by Dirk Pranke.
910
911         Allow external resources to be loaded when the main frame's URL is also an external resource.
912         This change is analogous to r118231 for Mac port.
913
914         * DumpRenderTree/chromium/WebViewHost.cpp:
915         (blockRequest):
916         (isLocalhost):
917         (hostIsUsedBySomeTestsToGenerateError):
918         (WebViewHost::willSendRequest):
919
920 2012-05-31  Anders Carlsson  <andersca@apple.com>
921
922         Build fixes.
923
924         Disable the C++11 extensions warning.
925
926         * DumpRenderTree/mac/Configurations/Base.xcconfig:
927         * TestWebKitAPI/Configurations/Base.xcconfig:
928         * WebKitTestRunner/Configurations/Base.xcconfig:
929
930 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
931
932         [WK2] window.internals settings are not reset between tests
933         https://bugs.webkit.org/show_bug.cgi?id=87783
934
935         Reviewed by Mihai Parparita.
936
937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
938         (WTR::InjectedBundle::done): Call resetAfterTest().
939
940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
941         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
942         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
943         This needs to be done after a tets, because the code assumes that there is an object
944         with this name in global scope.
945
946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
947
948 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
949
950         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
951         https://bugs.webkit.org/show_bug.cgi?id=85006
952
953         Reviewed by Tor Arne Vestbø.
954
955         Added navigation_policy_decision implementation for DumpRenderTreeView.
956         Added LayoutTestController::setCustomPolicyDelegate implementation.
957         Modified LayoutTestController::waitForPolicyDelegate.
958
959         * DumpRenderTree/efl/DumpRenderTree.cpp:
960         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
961         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
962         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
963         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
964         (navigationTypeToString): aux function
965         (onNavigationPolicyDecision): navigation_policy_decision implementation
966         (drtViewAdd):
967         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
968         (LayoutTestController::setCustomPolicyDelegate):
969         (LayoutTestController::waitForPolicyDelegate):
970
971 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
972
973         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
974         https://bugs.webkit.org/show_bug.cgi?id=86195
975
976         Reviewed by Gustavo Noronha Silva.
977
978         Implement clearApplicationCacheForOrigin in EFL
979         LayoutTestController.
980
981         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
982         (LayoutTestController::clearApplicationCacheForOrigin):
983
984 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
985
986         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
987         https://bugs.webkit.org/show_bug.cgi?id=87955
988
989         Reviewed by Simon Hausmann.
990
991         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
992         * DumpRenderTree/qt/EventSenderQt.cpp:
993         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
994         * DumpRenderTree/qt/main.cpp:
995         * QtTestBrowser/cookiejar.cpp:
996         * QtTestBrowser/launcherwindow.cpp:
997         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
998         * qmake/mkspecs/features/default_post.prf:
999
1000 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1001
1002         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1003
1004         Rubber-stamped by Kenneth Rohde Christiansen.
1005
1006         * qmake/config.tests/libpng/libpng.pro:
1007
1008 2012-05-30  Peter Beverloo  <peter@chromium.org>
1009
1010         [Chromium] Automatically install 64-bit linker for Android
1011         https://bugs.webkit.org/show_bug.cgi?id=79780
1012
1013         Reviewed by Adam Barth.
1014
1015         Change the update-webkit-chromium script to check whether the 64-bit
1016         linker needs to be installed as part of the update process. The actual
1017         code for doing these checks and "installing" it has been added to the
1018         webkitdirs.pm script.
1019
1020         The linker itself is part of the third_party/aosp repository, which
1021         will be pulled in through the DEPS change.
1022
1023         * Scripts/update-webkit-chromium:
1024         * Scripts/webkitdirs.pm:
1025         (chromiumInstall64BitAndroidLinkerIfNeeded):
1026         (chromiumReplaceAndroidLinkerIfNeeded):
1027
1028 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1029
1030         https://bugs.webkit.org/show_bug.cgi?id=87803
1031         Layout tests often fail trying to stat nonexistent logs 
1032
1033         Reviewed by Dirk Pranke.
1034
1035         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1036         try/catch block around accessing the logs as a precaution.
1037
1038         * Scripts/webkitpy/common/system/crashlogs.py:
1039         (CrashLogs._find_newest_log_darwin):
1040
1041 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1042
1043         Add a LayoutTest for prerender remove after stop.
1044         https://bugs.webkit.org/show_bug.cgi?id=87860
1045
1046         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1047         can be tested by LayoutTests now.
1048
1049         Reviewed by Adam Barth.
1050
1051         * DumpRenderTree/DumpRenderTree.gypi:
1052         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1053         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1054         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1055         (MockWebPrerenderingSupport::add):
1056         (MockWebPrerenderingSupport::cancel):
1057         (MockWebPrerenderingSupport::abandon):
1058         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1059         (MockWebPrerenderingSupport):
1060         * DumpRenderTree/chromium/TestShell.cpp:
1061         (TestShell::initialize):
1062         * DumpRenderTree/chromium/TestShell.h:
1063         (TestShell):
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHost::willAddPrerender):
1066         (WebViewHost::setWebWidget):
1067         * DumpRenderTree/chromium/WebViewHost.h:
1068         (WebViewHost):
1069
1070 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=87717
1073         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1074
1075         Reviewed by Dirk Pranke.
1076
1077         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1078         If there isn't a crash log found for the process add a message saying
1079         the process was unresponsive.
1080
1081         * Scripts/webkitpy/layout_tests/port/webkit.py:
1082         (WebKitDriver.__init__):
1083         (WebKitDriver._check_for_driver_crash):
1084         (WebKitDriver.run_test):
1085         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1086         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1087         (WebKitDriverTest):
1088         (WebKitDriverTest.test_check_for_driver_crash):
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR):
1091         (WTR::TestController::runTest):
1092
1093 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1094
1095         https://bugs.webkit.org/show_bug.cgi?id=87714
1096         Mac crash logs can take a really long time to be written out.
1097
1098         Reviewed by Dirk Pranke.
1099
1100         Make a second pass looking for crash logs after the tests have completed running.
1101
1102         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1103         (use_trac_links_in_results_html):
1104         (Manager.run):
1105         * Scripts/webkitpy/layout_tests/port/base.py:
1106         (Port.repository_paths):
1107         (Port.look_for_new_crash_logs):
1108         * Scripts/webkitpy/layout_tests/port/mac.py:
1109         (MacPort.look_for_new_crash_logs):
1110         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1111         (test_get_crash_log):
1112         (test_look_for_new_crash_logs):
1113         (test_look_for_new_crash_logs.fake_time_cb):
1114
1115 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1116
1117         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1118
1119         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1120         (LayoutWebViewEventHandler::OnAlertEvent):
1121         (LayoutWebViewEventHandler::OnConfirmEvent):
1122         (LayoutWebViewEventHandler):
1123         (LayoutWebViewEventHandler::OnPromptEvent):
1124         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1125         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1126
1127 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1128
1129         Only give lint errors for -expected.png png files that lack a checksum
1130         https://bugs.webkit.org/show_bug.cgi?id=87875
1131
1132         Reviewed by Tony Chang.
1133
1134         We have other pngs in the tree, e.g. for the inspector, that legitimately
1135         lack a checksum.
1136
1137         * Scripts/webkitpy/style/checkers/png.py:
1138         (PNGChecker.check):
1139         * Scripts/webkitpy/style/checkers/png_unittest.py:
1140         (PNGCheckerTest.test_check):
1141
1142 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1143
1144         nrwt: seems to leak temp dirs
1145         https://bugs.webkit.org/show_bug.cgi?id=87795
1146
1147         Reviewed by Ojan Vafai.
1148
1149         There appears to be a bug where the chromium bots are creating
1150         temporary directories and not cleaning them up that started
1151         after the switch to WebKitDriver. It's possible that __del__
1152         wasn't getting called in a timely manner (or at all), and it's
1153         generally bad style to rely on __del__ being called, so this
1154         code changes things so that we create a temp dir in
1155         driver.start() and remove it in driver.stop(). We could be
1156         paranoid and leave the __del__ code in, but there doesn't seem
1157         to be much advantage to it. If there are bugs that result in
1158         drivers being started but not stopped, we have other problems.
1159
1160         * Scripts/webkitpy/common/system/filesystem_mock.py:
1161         (MockFileSystem.__init__):
1162         (MockFileSystem._mktemp):
1163         (MockFileSystem.mkdtemp):
1164         * Scripts/webkitpy/layout_tests/port/webkit.py:
1165         (WebKitDriver.__init__):
1166         (WebKitDriver._start):
1167         (WebKitDriver.stop):
1168         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1169         (WebKitDriverTest.test_check_for_driver_crash):
1170         (WebKitDriverTest):
1171         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1172         (WebKitDriverTest.test_stop_cleans_up_properly):
1173
1174 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1175
1176         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1177         https://bugs.webkit.org/show_bug.cgi?id=86841
1178
1179         Reviewed by Adam Barth.
1180
1181         Print the number of MessagePorts for each new intent in EFL's DRT.
1182         This output is expected by several Web Intents test cases.
1183
1184         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1185         (DumpRenderTreeChrome::onFrameIntentNew):
1186
1187 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1188
1189         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1190
1191         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1192
1193 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1194
1195         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1196         https://bugs.webkit.org/show_bug.cgi?id=87829
1197
1198         Reviewed by Adam Barth.
1199
1200         EFL's LayoutTestController now makes uses of the new helper method in
1201         DumpRenderTreeSupportEfl in order to send the intent response. This is
1202         now needed because the Ewk_Intent_Request postResult / postFailure
1203         methods were made private.
1204
1205         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1206         (LayoutTestController::sendWebIntentResponse):
1207
1208 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1209
1210         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1211         https://bugs.webkit.org/show_bug.cgi?id=86296
1212
1213         Reviewed by Tony Chang.
1214
1215         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1216         (cfHDropFormat):
1217         (cfFileNameWFormat):
1218         (cfUrlWFormat):
1219         (WCEnumFormatEtc):
1220         (WCEnumFormatEtc::WCEnumFormatEtc):
1221         (WCEnumFormatEtc::QueryInterface):
1222         (WCEnumFormatEtc::AddRef):
1223         (WCEnumFormatEtc::Release):
1224         (WCEnumFormatEtc::Next):
1225         (WCEnumFormatEtc::Skip):
1226         (WCEnumFormatEtc::Reset):
1227         (WCEnumFormatEtc::Clone):
1228         (DRTDataObject::createInstance):
1229         (DRTDataObject::DRTDataObject):
1230         (DRTDataObject::~DRTDataObject):
1231         (DRTDataObject::QueryInterface):
1232         (DRTDataObject::AddRef):
1233         (DRTDataObject::Release):
1234         (DRTDataObject::GetData):
1235         (DRTDataObject::GetDataHere):
1236         (DRTDataObject::QueryGetData):
1237         (DRTDataObject::GetCanonicalFormatEtc):
1238         (DRTDataObject::SetData):
1239         (DRTDataObject::CopyMedium):
1240         (DRTDataObject::EnumFormatEtc):
1241         (DRTDataObject::DAdvise):
1242         (DRTDataObject::DUnadvise):
1243         (DRTDataObject::EnumDAdvise):
1244         (DRTDataObject::clearData):
1245         * DumpRenderTree/win/DRTDataObject.h: Added.
1246         (DRTDataObject):
1247         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1248         (DRTDropSource::DRTDropSource):
1249         (DRTDropSource::~DRTDropSource):
1250         (DRTDropSource::QueryInterface):
1251         (DRTDropSource::AddRef):
1252         (DRTDropSource::Release):
1253         (DRTDropSource::createInstance):
1254         (DRTDropSource::QueryContinueDrag):
1255         (DRTDropSource::GiveFeedback):
1256         * DumpRenderTree/win/DRTDropSource.h: Added.
1257         (DRTDropSource):
1258         * DumpRenderTree/win/DumpRenderTree.vcproj:
1259         * DumpRenderTree/win/EventSender.cpp:
1260         (beginDragWithFilesCallback):
1261
1262 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1263
1264         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1265         https://bugs.webkit.org/show_bug.cgi?id=58593
1266
1267         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1268         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1269         public C API of the WebProcess.
1270
1271         Reviewed by Darin Adler.
1272
1273         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1274         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1275         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1276         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1277         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1278
1279 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1280
1281         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1282         https://bugs.webkit.org/show_bug.cgi?id=87848
1283
1284         Reviewed by Csaba Osztrogonác.
1285
1286         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1287         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1288         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1289
1290         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1291         (DumpRenderTreeChrome::extraViews):
1292         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1293         (DumpRenderTreeChrome):
1294
1295 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1296
1297         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1298         https://bugs.webkit.org/show_bug.cgi?id=87833
1299
1300         Reviewed by Tor Arne Vestbø.
1301
1302         Print "postProgressFinishedNotification" message if frame load finished 
1303         to unskip http/tests/loading/progress-finished-callback.html.
1304
1305         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1306         (DumpRenderTreeChrome::onFrameLoadFinished):
1307
1308 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1309
1310         [EFL][WK2] Fix WebKit2-EFL build
1311         https://bugs.webkit.org/show_bug.cgi?id=83693
1312
1313         Reviewed by Carlos Garcia Campos.
1314
1315         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1316
1317 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1318
1319         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1320         (They only used to check for Skipped in platform/qt-5.0-wk1)
1321         https://bugs.webkit.org/show_bug.cgi?id=87376
1322
1323         Reviewed by Csaba Osztrogonác.
1324
1325         * Scripts/old-run-webkit-tests:
1326         (buildPlatformResultHierarchy):
1327         * Scripts/webkitpy/layout_tests/port/qt.py:
1328         (QtPort.baseline_search_path):
1329
1330 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1331
1332         Add a linter error for pngs that lack an embedded checksum
1333         https://bugs.webkit.org/show_bug.cgi?id=87793
1334
1335         Reviewed by Dirk Pranke.
1336
1337         * Scripts/read-checksum-from-png:
1338         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1339         (read_checksum):
1340         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1341         (ReadChecksumFromPngTest):
1342         (ReadChecksumFromPngTest.test_read_checksum):
1343         * Scripts/webkitpy/layout_tests/port/base.py:
1344         * Scripts/webkitpy/style/checkers/png.py:
1345         (PNGChecker.check):
1346         * Scripts/webkitpy/style/checkers/png_unittest.py:
1347         (PNGCheckerTest.test_check):
1348
1349 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=87720
1352         WebProcess is often killed due to being unresponsive on the bots
1353
1354         Reviewed by Alexey Proskuryakov.
1355
1356         Blind attempt to improve flakiness on the bots by reducing the number
1357         of crashes due to an unresponsive process.  This helped on my personal machine
1358         under stress conditions.  I don't have enough cores to hit the problem
1359         under normal conditions.
1360
1361         * WebKitTestRunner/TestController.cpp:
1362         (WTR):
1363
1364 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1365
1366         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1367         https://bugs.webkit.org/show_bug.cgi?id=87779
1368
1369         Reviewed by Eric Seidel.
1370
1371         Update output to match the names in scm.py as per
1372         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1373
1374         * Scripts/webkitpy/tool/commands/rebaseline.py:
1375         (RebaselineTest.execute):
1376         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1377         (test_rebaseline_test_and_print_scm_changes):
1378         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1379         (GardeningServerTest.test_rebaselineall):
1380
1381 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1382
1383         https://bugs.webkit.org/show_bug.cgi?id=87711
1384
1385         Reviewed by Jessie Berlin.
1386
1387         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1388         are better maintained.
1389
1390         * BuildSlaveSupport/build.webkit.org-config/config.json:
1391
1392 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1393
1394         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1395         https://bugs.webkit.org/show_bug.cgi?id=87538
1396
1397         Reviewed by Ojan Vafai.
1398
1399         Invoking git and svn on one file at a time is kinda slow. We
1400         should batch the add and rm operations together.
1401
1402         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1403         (BaselineOptimizer._move_baselines):
1404
1405 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1406
1407         garden-o-matic should rebaseline baselines in parallel
1408         https://bugs.webkit.org/show_bug.cgi?id=87451
1409
1410         Reviewed by Ojan Vafai.
1411                                                                                
1412         This modifies garden-o-matic so that we will fetch all                  
1413         of the baselines in parallel from the bots, and then                    
1414         optimize the baselines serially (since that should be fairly            
1415         quick and we get into trouble if we optimize in parallel due            
1416         to concurrent access to the source control system).                     
1417
1418         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1419         so that the files that need to be modified in the SCM are returned to 
1420         garden-o-matic rather than actually added or removed. This is done so that
1421         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1422         concurrently). In order to safely return the files (as a JSON dict) I
1423         needed to shift all of the logging in rebaseline-test to use the logging
1424         module (and hence log to stderr).
1425
1426         I also had to stub out a line in chromium.py that would get confused if
1427         the skia overrides file didn't exist in a mock checkout.
1428
1429         * Scripts/webkitpy/common/system/executive.py:
1430         (Executive.popen):
1431         (Executive):
1432         (Executive.run_in_parallel):
1433         (_run_command_thunk):
1434         * Scripts/webkitpy/common/system/executive_mock.py:
1435         (MockExecutive.run_in_parallel):
1436         * Scripts/webkitpy/common/system/executive_unittest.py:
1437         (ExecutiveTest.test_run_in_parallel):
1438         * Scripts/webkitpy/layout_tests/port/chromium.py:
1439         (ChromiumPort._expectations_file_contents):
1440         * Scripts/webkitpy/tool/commands/rebaseline.py:
1441         (AbstractRebaseliningCommand.__init__):
1442         (RebaselineTest.__init__):
1443         (RebaselineTest._copy_existing_baseline):
1444         (RebaselineTest._save_baseline):
1445         (RebaselineTest):
1446         (RebaselineTest._add_to_scm):
1447         (RebaselineTest._rebaseline_test):
1448         (RebaselineTest.execute):
1449         (RebaselineExpectations._rebaseline_port):
1450         (RebaselineExpectations.execute):
1451         (Rebaseline._builder_to_pull_from):
1452         (Rebaseline.execute):
1453         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1454         (test_rebaseline_updates_expectations_file):
1455         (test_rebaseline_test):
1456         (test_rebaseline_test_and_print_scm_changes):
1457         (test_rebaseline_and_copy_test):
1458         (test_rebaseline_and_copy_test_no_existing_result):
1459         (test_rebaseline_and_copy_test_with_lion_result):
1460         (test_rebaseline_and_copy_no_overwrite_test):
1461         (test_rebaseline_expectations):
1462         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1463         (GardeningHTTPRequestHandler._rebaseline_commands):
1464         (GardeningHTTPRequestHandler):
1465         (GardeningHTTPRequestHandler._files_to_add):
1466         (GardeningHTTPRequestHandler._optimize_baselines):
1467         (GardeningHTTPRequestHandler.rebaselineall):
1468         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1469         (GardeningServerTest._post_to_path):
1470         (GardeningServerTest.test_rebaselineall):
1471         (GardeningServerTest.test_rebaselineall.run_command):
1472
1473 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1474
1475         Fix the type of dispatch_time() offset
1476
1477         Rubber-stamped by Joseph Pecoraro.
1478
1479         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1480
1481         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1482         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1483
1484 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1485
1486         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1487
1488         [BlackBerry] OpenGL content is not rendered on simulator
1489         https://bugs.webkit.org/show_bug.cgi?id=87721
1490
1491         Reviewed by George Staikos.
1492
1493         Fixed by enabling GLES2 support in simulator builds.
1494
1495         To experiment with building without OpenGL support, you can set the
1496         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1497
1498         PR #150695
1499
1500         * Scripts/webkitdirs.pm:
1501         (blackberryCMakeArguments):
1502
1503 2012-05-29  David Barr  <davidbarr@chromium.org>
1504
1505         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1506         https://bugs.webkit.org/show_bug.cgi?id=87685
1507
1508         Reviewed by Eric Seidel.
1509
1510         Add a configuration option for CSS image-resolution support, disabling it by default.
1511
1512         * Scripts/webkitperl/FeatureList.pm:
1513         * qmake/mkspecs/features/features.pri:
1514
1515 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1516
1517         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1518
1519         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1520             valid for C++/ObjC++ but not for C [enabled by default]"
1521
1522         Reviewed by Simon Hausmann.
1523
1524         * qmake/mkspecs/features/unix/default_post.prf:
1525
1526 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1527
1528         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1529
1530         https://bugs.webkit.org/show_bug.cgi?id=87133
1531
1532         We now base64-encode the page url in the image-provider url, so that any
1533         normalization done by QUrl will not mess up the page-url. The logic of
1534         creating and parsing the provider-url has been moved into the image
1535         provider, to keep it in one place.
1536
1537         We were also releasing icons (even ones we hadn't retained), which we can't
1538         do since we don't know when the icon url is no longer in use.
1539
1540         Reviewed-by Simon Hausmann.
1541
1542         * MiniBrowser/qt/icons/favicon.png:
1543         * MiniBrowser/qt/qml/BrowserWindow.qml:
1544
1545 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1546
1547         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1548         https://bugs.webkit.org/show_bug.cgi?id=87654
1549
1550         Reviewed by Csaba Osztrogonác.
1551
1552         Event sender provides strings for all the key events.
1553         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1554         a key event has empty string.
1555
1556         * DumpRenderTree/efl/EventSender.cpp:
1557         (KeyEventInfo::KeyEventInfo):
1558         (keyPadNameFromJSValue):
1559         (keyNameFromJSValue):
1560
1561 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1562
1563         [Qt] Cancel potential url-edit when going back/forward
1564
1565         Reviewed by Kenneth Rohde Christiansen.
1566
1567         * MiniBrowser/qt/qml/BrowserWindow.qml:
1568
1569 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1570
1571         [EFL] Compilation warning in DumpRenderTreeView.cpp
1572         https://bugs.webkit.org/show_bug.cgi?id=87636
1573
1574         Reviewed by Filip Pizlo.
1575
1576         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1577         specifier in printf. Also fix the return type for
1578         onExceededApplicationCacheQuota callback.
1579
1580         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1581         (onExceededApplicationCacheQuota):
1582
1583 2012-05-29  Hironori Bono  <hbono@chromium.org>
1584
1585         Adding Hironori Bono to committers.py.
1586         https://bugs.webkit.org/show_bug.cgi?id=87697
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1591
1592         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1593         https://bugs.webkit.org/show_bug.cgi?id=80135
1594
1595         Reviewed by Rob Buis.
1596
1597         Implemented interface function didReceiveAuthenticationChallenge in class
1598         DumpRenderTree.
1599
1600         Resubmit the patch reverted by r115104 after the digest infinite loop
1601         issue for BlackBerry porting get identified and fixed.
1602
1603         Internally reviewed by Joe Mason <jmason@rim.com>
1604
1605         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1606         (drtCredentialDescription):
1607         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1608         (WebKit):
1609         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1610         (WebCore):
1611         (DumpRenderTree):
1612
1613 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1614
1615         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1616         https://bugs.webkit.org/show_bug.cgi?id=42328
1617
1618         Reviewed by Eric Seidel.
1619
1620         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1621         move to windows.internals.settings.
1622
1623         * DumpRenderTree/LayoutTestController.cpp:
1624         (LayoutTestController::staticFunctions):
1625         * DumpRenderTree/LayoutTestController.h:
1626         (LayoutTestController):
1627         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1628         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1629         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1630         (DRTDevToolsAgent):
1631         * DumpRenderTree/chromium/LayoutTestController.cpp:
1632         (LayoutTestController::LayoutTestController):
1633         * DumpRenderTree/chromium/LayoutTestController.h:
1634         (LayoutTestController):
1635         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1636         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1637         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1638         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1639         * DumpRenderTree/mac/DumpRenderTree.mm:
1640         (resetWebViewToConsistentStateBeforeTesting):
1641         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1642         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1643         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1644         (LayoutTestController):
1645         * DumpRenderTree/win/DumpRenderTree.cpp:
1646         (resetWebViewToConsistentStateBeforeTesting):
1647         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1648         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1649         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1650         (LayoutTestController):
1651
1652 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1653
1654         Move allowRoundingHacks to Internals interface
1655         https://bugs.webkit.org/show_bug.cgi?id=87328
1656
1657         Reviewed by Hajime Morita.
1658
1659         Remove allowRoundingHacks functions, because it is able to work in the
1660         cross-port way through the Internals interface.
1661
1662         * DumpRenderTree/LayoutTestController.cpp:
1663         (LayoutTestController::staticFunctions):
1664         * DumpRenderTree/LayoutTestController.h:
1665         (LayoutTestController):
1666         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1667         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1668         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1669         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1670         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1671         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1672
1673 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1674
1675         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1676         https://bugs.webkit.org/show_bug.cgi?id=87616
1677
1678         Reviewed by Hajime Morita.
1679
1680         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1681         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1682         Patch just adds a #ifndef / #define check.
1683
1684         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1685         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1686
1687 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1688
1689         [EFL] Enable blob support for the EFL port
1690         https://bugs.webkit.org/show_bug.cgi?id=85363
1691
1692         Reviewed by Hajime Morita.
1693
1694         Enable Blob support by default for the EFL port.
1695
1696         * Scripts/webkitperl/FeatureList.pm:
1697
1698 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1699
1700         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1701         https://bugs.webkit.org/show_bug.cgi?id=87582
1702
1703         Reviewed by Darin Adler.
1704
1705         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1706         possible to test pages in a similar way as they are loaded in Browsers.
1707
1708         * DumpRenderTree/LayoutTestController.cpp:
1709         (LayoutTestController::LayoutTestController):
1710         (setUseDeferredFrameLoadingCallback):
1711         (LayoutTestController::staticFunctions):
1712         * DumpRenderTree/LayoutTestController.h:
1713         (LayoutTestController::useDeferredFrameLoading):
1714         (LayoutTestController::setUseDeferredFrameLoading):
1715         (LayoutTestController):
1716         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1717         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1718
1719 2012-05-27  David Barton  <dbarton@mathscribe.com>
1720
1721         [watchlist] Improve MathML rule
1722         https://bugs.webkit.org/show_bug.cgi?id=87592
1723
1724         Reviewed by Adam Barth.
1725
1726         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1727         but if this changed the rule would be slow. We protect against this, clarify the rule,
1728         and make it more similar to existing rules.
1729
1730         * Scripts/webkitpy/common/config/watchlist:
1731
1732 2012-05-27  David Barton  <dbarton@mathscribe.com>
1733
1734         [watchlist] Add myself & a rule for MathML
1735         https://bugs.webkit.org/show_bug.cgi?id=87586
1736
1737         Reviewed by Adam Barth.
1738
1739         * Scripts/webkitpy/common/config/watchlist:
1740
1741 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1742
1743         Use xcrun to find path to nm for Mac port
1744         <http://webkit.org/b/87588>
1745
1746         Reviewed by Dan Bernstein.
1747
1748         * Scripts/webkitpy/layout_tests/port/mac.py:
1749         (MacPort.nm_command): Add. Tries to find a path for the nm
1750         command using xcrun.  Falls back to returning 'nm'.
1751         * Scripts/webkitpy/layout_tests/port/webkit.py:
1752         (WebKitPort.nm_command): Add. Returns 'nm'.
1753         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1754
1755 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1756
1757         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1758
1759         Reviewed by Eric Seidel.
1760
1761         * DumpRenderTree/win/DumpRenderTree.vcproj:
1762         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1763         (FrameLoadDelegate::FrameLoadDelegate):
1764         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1765         * DumpRenderTree/win/FrameLoadDelegate.h:
1766         (FrameLoadDelegate):
1767         * DumpRenderTree/win/TextInputController.cpp: Added.
1768         (setMarkedTextCallback):
1769         (hasMarkedTextCallback):
1770         (unmarkTextCallback):
1771         (markedRangeCallback):
1772         (insertTextCallback):
1773         (firstRectForCharacterRangeCallback):
1774         (selectedRangeCallback):
1775         (TextInputController::makeWindowObject):
1776         (TextInputController::getJSClass):
1777         (TextInputController::staticValues):
1778         (TextInputController::staticFunctions):
1779         * DumpRenderTree/win/TextInputController.h: Added.
1780         (TextInputController):
1781         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1782         (TextInputController::setMarkedText):
1783         (TextInputController::hasMarkedText):
1784         (TextInputController::unmarkText):
1785         (TextInputController::markedRange):
1786         (TextInputController::insertText):
1787         (TextInputController::firstRectForCharacterRange):
1788         (TextInputController::selectedRange):
1789
1790 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1791
1792         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1793         https://bugs.webkit.org/show_bug.cgi?id=87528
1794
1795         Reviewed by Ojan Vafai.
1796
1797         launching git or svn for individual files can be slow; this
1798         change will hand multiple paths at once to git and svn so they
1799         can be added in a batch.
1800
1801         * Scripts/webkitpy/common/checkout/scm/git.py:
1802         (Git.add_list):
1803         (Git.delete_list):
1804         * Scripts/webkitpy/common/checkout/scm/scm.py:
1805         (SCM.add):
1806         (SCM):
1807         (SCM.add_list):
1808         (SCM.delete):
1809         (SCM.delete_list):
1810         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1811         (MockSCM.add):
1812         (MockSCM):
1813         (MockSCM.add_list):
1814         (MockSCM.delete):
1815         (MockSCM.delete_list):
1816         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1817         (_shared_test_exists):
1818         (_shared_test_added_files):
1819         (_test_delete_list):
1820         * Scripts/webkitpy/common/checkout/scm/svn.py:
1821         (SVN.add_list):
1822         (SVN.delete_list):
1823
1824 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1825
1826         [NRWT] Add unit testing for perf tests on locked shards
1827         https://bugs.webkit.org/show_bug.cgi?id=87489
1828
1829         Reviewed by Dirk Pranke.
1830
1831         Adding utests that makes sure that perf tests are running in locked
1832         shards and by passing --no-http won't break NRWT (r118421).
1833
1834         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1835         (ShardingTests):
1836         (ShardingTests.test_shard_by_dir):
1837         (ShardingTests.test_shard_every_file):
1838         (ShardingTests.test_shard_in_two):
1839         (ShardingTests.test_multiple_locked_shards):
1840         (LockCheckingManager):
1841         (LockCheckingManager.__init__):
1842         (LockCheckingManager.handle_finished_list):
1843         (ManagerTest.test_http_locking):
1844         (ManagerTest):
1845         (ManagerTest.test_perf_locking):
1846         * Scripts/webkitpy/layout_tests/port/test.py:
1847
1848 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1849
1850         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1851         https://bugs.webkit.org/show_bug.cgi?id=87511
1852
1853         Reviewed by Alexey Proskuryakov.
1854
1855         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1856
1857         * DumpRenderTree/win/EventSender.cpp:
1858         (keyDownCallback):
1859
1860 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1861
1862         Adding Ken Buchanan to committers.py
1863         https://bugs.webkit.org/show_bug.cgi?id=87443
1864
1865         Unreviewed.
1866
1867         Adding self to committers.py as a Committer.
1868
1869         * Scripts/webkitpy/common/config/committers.py:
1870
1871 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1872
1873         [Qt] Buildfix for newer Qt5
1874         https://bugs.webkit.org/show_bug.cgi?id=87257
1875
1876         Reviewed by Simon Hausmann.
1877
1878         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
1879
1880 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1881
1882         [Qt] Unreviewed fix after r118484.
1883
1884         Enable CSS_EXCLUSIONS and CSS_REGIONS.
1885         They were enabled uncoditinally before r118484.
1886
1887         * qmake/mkspecs/features/features.pri:
1888
1889 2012-05-24  Tim Horton  <timothy_horton@apple.com>
1890
1891         Add feature defines for web-facing parts of CSS Regions and Exclusions
1892         https://bugs.webkit.org/show_bug.cgi?id=87442
1893         <rdar://problem/10887709>
1894
1895         Reviewed by Dan Bernstein.
1896
1897         * Scripts/webkitperl/FeatureList.pm:
1898
1899 2012-05-24  Hironori Bono  <hbono@chromium.org>
1900
1901         Enable grammar checking on Chromium when we paste text (Take 2)
1902         https://bugs.webkit.org/show_bug.cgi?id=74393
1903
1904         Reviewed by Ryosuke Niwa.
1905
1906         This change enables grammar checking on Chromium and implements a mock grammar
1907         checker to fix a failing test.
1908
1909         * DumpRenderTree/DumpRenderTree.gypi:
1910         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1911         (MockGrammarCheck::checkGrammarOfString):
1912         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1913         (WebKit):
1914         (MockGrammarCheck):
1915         * DumpRenderTree/chromium/WebViewHost.cpp:
1916         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1917
1918 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1919
1920         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
1921         https://bugs.webkit.org/show_bug.cgi?id=86842
1922
1923         Reviewed by Antonio Gomes.
1924
1925         Add support for overriding the application cache support preference
1926         through EFL's LayoutTestController.
1927
1928         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1929         (LayoutTestController::overridePreference):
1930
1931 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1932
1933         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
1934         https://bugs.webkit.org/show_bug.cgi?id=85209
1935
1936         Reviewed by Antonio Gomes.
1937
1938         Set developer extras setting called twice on the test startup. Hence, removing
1939         an unnecessary extra call which set wrong value. 
1940
1941         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1942         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1943
1944 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1945
1946         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1947         https://bugs.webkit.org/show_bug.cgi?id=86916
1948
1949         Reviewed by Adam Barth.
1950
1951         Note that if release and debug are failing differently, debug
1952         will be ignored ...
1953
1954         Note: also change the use of a fake port name from
1955         "mock-port-name" to "test-mac-leopard" to make it more friendly
1956         to the port factory ("mock" actually is a real port).
1957
1958         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1959         (GardeningHTTPRequestHandler._builders_to_fetch_from):
1960         (GardeningHTTPRequestHandler.rebaselineall):
1961         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1962         (GardeningServerTest.test_rebaselineall):
1963         (GardeningServerTest.test_rebaseline_new_port):
1964
1965 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1966
1967         nrwt: fix baseline search path for official chrome builders
1968         https://bugs.webkit.org/show_bug.cgi?id=87432
1969
1970         Reviewed by Tony Chang.
1971
1972         The official chrome builders need to use the win7 and SL
1973         baseline paths, not the XP and Leopard paths. Linux is correct.
1974
1975         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1976         (GoogleChromeMacPort.determine_full_port_name):
1977         (GoogleChromeWinPort.determine_full_port_name):
1978         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1979         (TestGoogleChromePort._verify_baseline_search_path_startswith):
1980         (TestGoogleChromePort.test_get_google_chrome_port):
1981
1982 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1983
1984         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
1985         https://bugs.webkit.org/show_bug.cgi?id=86800
1986
1987         Reviewed by Dirk Pranke.
1988
1989         Don't launch a HTTP server with lock based only on the existence of
1990         locked shards since we now run perf on locked shards too.
1991
1992         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1993         (Manager._run_tests):
1994
1995 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
1996
1997         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1998         https://bugs.webkit.org/show_bug.cgi?id=87128
1999
2000         Reviewed by Dirk Pranke.
2001
2002         * Scripts/webkitpy/layout_tests/port/base.py:
2003         (Port.driver_name):
2004         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2005         (ChromiumLinuxPort._path_to_driver):
2006         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2007         (ChromiumPortTest.test_driver_name_option):
2008         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2009         (ChromiumWinPort._path_to_driver):
2010         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011         (parse_args):
2012
2013 2012-05-24  John Mellor  <johnme@chromium.org>
2014
2015         Font Boosting: Add compile flag and runtime setting
2016         https://bugs.webkit.org/show_bug.cgi?id=87394
2017
2018         Reviewed by Adam Barth.
2019
2020         Add ENABLE_FONT_BOOSTING.
2021
2022         * Scripts/webkitperl/FeatureList.pm:
2023         * qmake/mkspecs/features/features.pri:
2024
2025 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2026
2027         [EFL] [DRT] keyboard-related tests do not pass
2028         https://bugs.webkit.org/show_bug.cgi?id=85369
2029
2030         Reviewed by Gustavo Noronha Silva.
2031
2032         Add SHIFT modifier for capital letters as VK_ 
2033         codes do not distinguish between lows and caps and also to be consistent
2034         with other ports which send caps as lowercase letters with the shift key down.
2035
2036         * DumpRenderTree/efl/EventSender.cpp:
2037         (keyNameFromJSValue): 
2038
2039 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2040
2041         [WK2] Let the client give local files universal access on a case by case basis
2042         https://bugs.webkit.org/show_bug.cgi?id=87174
2043         <rdar://problem/11024330>
2044
2045         Reviewed by Maciej Stachowiak.
2046
2047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2048         Added initialization of a new structure member to prevent build failure.
2049
2050 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2051
2052         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2053         https://bugs.webkit.org/show_bug.cgi?id=87203
2054
2055         Reviewed by Andreas Kling.
2056
2057         Add the required changes to make
2058         fast/events/keydown-leftright-keys.html pass after r118001.
2059
2060         * DumpRenderTree/efl/EventSender.cpp:
2061         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2062         into the proper X11 keysym definitions.
2063
2064 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2065
2066         Unreviewed, rolling out r118352.
2067         http://trac.webkit.org/changeset/118352
2068         https://bugs.webkit.org/show_bug.cgi?id=87390
2069
2070         Caused 6 editing/spelling tests crash/fail on chromium in
2071         debug. (Requested by vsevik on #webkit).
2072
2073         * DumpRenderTree/DumpRenderTree.gypi:
2074         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2075         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2076         * DumpRenderTree/chromium/WebViewHost.cpp:
2077         (WebViewHost::finishLastTextCheck):
2078
2079 2012-05-24  Peter Beverloo  <peter@chromium.org>
2080
2081         Add John Mellor as a contributor
2082         https://bugs.webkit.org/show_bug.cgi?id=87389
2083
2084         Reviewed by Kenneth Rohde Christiansen.
2085
2086         John will be working on Font Boosting and is very involved with various
2087         web-facing subjects of Chrome for Android, such as viewport.
2088
2089         * Scripts/webkitpy/common/config/committers.py:
2090
2091 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2092
2093         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2094         https://bugs.webkit.org/show_bug.cgi?id=86840
2095
2096         Reviewed by Csaba Osztrogonác.
2097
2098         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2099         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2100         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2101         (LayoutTestController::setCacheModel): Implementation added.
2102
2103 2012-05-24  Hironori Bono  <hbono@chromium.org>
2104
2105         Enable grammar checking on Chromium when we paste text.
2106         https://bugs.webkit.org/show_bug.cgi?id=74393
2107
2108         Reviewed by Hajime Morita.
2109
2110         This change enables grammar checking on Chromium and implements a mock grammar
2111         checker to fix a failing test.
2112
2113         * DumpRenderTree/DumpRenderTree.gypi:
2114         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2115         (MockGrammarCheck::checkGrammarOfString):
2116         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2117         (WebKit):
2118         (MockGrammarCheck):
2119         * DumpRenderTree/chromium/WebViewHost.cpp:
2120         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2121
2122 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2123
2124         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2125
2126         * qmake/mkspecs/features/features.pri:
2127
2128 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2129
2130         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2131         https://bugs.webkit.org/show_bug.cgi?id=86867
2132
2133         Reviewed by Adam Barth.
2134
2135         Add implementation for sendWebIntentResponse() in EFL's
2136         LayoutTestController and add empty implementation for other ports.
2137
2138         * DumpRenderTree/LayoutTestController.cpp:
2139         (sendWebIntentResponseCallback):
2140         (LayoutTestController::staticFunctions):
2141         * DumpRenderTree/LayoutTestController.h:
2142         (LayoutTestController):
2143         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2144         (LayoutTestController::sendWebIntentResponse):
2145         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2146         (DumpRenderTreeChrome::currentIntentRequest):
2147         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2148         (DumpRenderTreeChrome::onFrameIntentNew):
2149         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2150         (DumpRenderTreeChrome):
2151         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2152         (LayoutTestController::sendWebIntentResponse):
2153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2154         (LayoutTestController::sendWebIntentResponse):
2155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2156         (LayoutTestController::sendWebIntentResponse):
2157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2158         (LayoutTestController::sendWebIntentResponse):
2159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2160         (LayoutTestController::sendWebIntentResponse):
2161
2162 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2163
2164         [EFL] The EFL port has no support for title directionality
2165         https://bugs.webkit.org/show_bug.cgi?id=86462
2166
2167         Reviewed by Gustavo Noronha Silva.
2168
2169         Update "title,changed" signal handlers in DRT and EWebLauncher to
2170         reflect the change from const char* to Ewk_Text_With_Direction* type
2171         for the title.
2172
2173         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2174         (DumpRenderTreeChrome::onTitleChanged):
2175         * EWebLauncher/main.c:
2176         (title_set):
2177         (on_title_changed):
2178         (on_key_down):
2179
2180 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2181
2182         Change EFL debug build name with more detail one
2183         https://bugs.webkit.org/show_bug.cgi?id=87254
2184
2185         Reviewed by Ryosuke Niwa.
2186
2187         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2188         In addition, remove efl-linux-debug triggerable since nobody uses it.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/config.json:
2191
2192 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2193
2194         [EFL][DRT] Fix WebCore library path and rebaseline result
2195         https://bugs.webkit.org/show_bug.cgi?id=86355
2196
2197         Reviewed by Dirk Pranke.
2198
2199         Currently EFL DRT uses wrong WebCore library path when running DRT.
2200         Therefore, this patch adjusted the path correctly.
2201
2202         * Scripts/webkitpy/layout_tests/port/efl.py:
2203         (EflPort._path_to_webcore_library):
2204
2205 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2206
2207         add back the ability to disable flexbox
2208         https://bugs.webkit.org/show_bug.cgi?id=87147
2209
2210         Reviewed by Tony Chang.
2211
2212         * Scripts/webkitperl/FeatureList.pm:
2213
2214 2012-05-23  Tony Chang  <tony@chromium.org>
2215
2216         Remove the Chromium Grid Layout bot from the waterfall
2217         https://bugs.webkit.org/show_bug.cgi?id=87311
2218
2219         Reviewed by Ryosuke Niwa.
2220
2221         I removed the compiler define in r117613, so we don't need a separate
2222         bot to compile/test this code.
2223
2224         * BuildSlaveSupport/build.webkit.org-config/config.json:
2225
2226 2012-05-23  Ian Vollick  <vollick@chromium.org>
2227
2228         Add vollick to list of contributors.
2229         https://bugs.webkit.org/show_bug.cgi?id=87305
2230
2231         Reviewed by Adam Barth.
2232
2233         * Scripts/webkitpy/common/config/committers.py:
2234
2235 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2236
2237         [Chromium-Android] Fix chromium_android_unittest
2238         https://bugs.webkit.org/show_bug.cgi?id=87196
2239
2240         Reviewed by Tony Chang.
2241
2242         Update unit tests after ChromiumAndroidPort supported apk based
2243         DumpRenderTree.
2244
2245         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2246         (ChromiumAndroidPortTest):
2247         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2248         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2249         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2250         (ChromiumAndroidDriverTest):
2251         (ChromiumAndroidDriverTest.setUp):
2252         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2253         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2254
2255 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2256
2257         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2258         https://bugs.webkit.org/show_bug.cgi?id=87303
2259
2260         Reviewed by Alexis Menard.
2261
2262         * Scripts/webkitpy/common/config/watchlist:
2263
2264 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2265
2266         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2267         https://bugs.webkit.org/show_bug.cgi?id=86916
2268
2269         Reviewed by Adam Barth.
2270
2271         This change pushes all of the logic for rebaselining a cluster
2272         of failures (a list of tests failing a list of suffixes on a
2273         list of bots) onto the server, so there is a single call from
2274         the web page; we will then be able to optimize the performance
2275         of the rebaselining better.
2276
2277         Also remove the 'optimizebaseline' entry point on garden-o-matic
2278         (and the client-side call) since we don't need it any more.
2279
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2282         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2283         (GardeningHTTPRequestHandler.rebaselineall):
2284         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2285
2286 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2287
2288         Mac DRT should be able to load external URLs for replay performance tests
2289         https://bugs.webkit.org/show_bug.cgi?id=86191
2290
2291         Reviewed by Alexey Proskuryakov.
2292
2293         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2294         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2295         "DumpRenderTree http://localhost:8000/".
2296
2297         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2298         (isLocalhost):
2299         (hostIsUsedBySomeTestsToGenerateError):
2300         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2301
2302 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2303
2304         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2305         debug symbols for easier debugging.
2306         https://bugs.webkit.org/show_bug.cgi?id=87151
2307
2308         Reviewed by Kevin Ollivier.
2309
2310         * waf/build/settings.py:
2311         (common_configure):
2312
2313 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         Unreviewed. Move myself to reviewers.
2316
2317         * Scripts/webkitpy/common/config/committers.py:
2318
2319 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2320
2321         [EFL] Implements the registerProtocolHandler method and option.
2322         https://bugs.webkit.org/show_bug.cgi?id=73638
2323
2324         Reviewed by Andreas Kling.
2325
2326         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2327
2328 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2329
2330         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2331         https://bugs.webkit.org/show_bug.cgi?id=87221
2332
2333         Reviewed by Martin Robinson.
2334
2335         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2336         rightShift key names into proper GDK key symbols.
2337
2338         * DumpRenderTree/gtk/EventSender.cpp:
2339         (createKeyPressEvent):
2340
2341 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2342
2343         [Qt] Make the web view's url property follow the active url
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=77554
2346
2347         Update  the location bar in the minibrowser to behave
2348         a bit more like normal browsers in terms of when the url will change
2349         and how active focus is handled.
2350
2351         Reviewed by Simon Hausmann.
2352
2353         * MiniBrowser/qt/qml/BrowserWindow.qml:
2354
2355 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2356
2357         [Qt] Remove references to $$QT_SOURCE_TREE
2358
2359         With a modularized Qt, it's ambigious. What we really want is qtbase,
2360         which qtcore is a proxy for (we assume it will always live in qtbase).
2361
2362         Reviewed by Tor Arne Vestbø.
2363
2364         * DumpRenderTree/qt/DumpRenderTree.pro:
2365
2366 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2367
2368         [Qt] Fix qmake conditional for c++-11 compat warnings
2369
2370         Reviewed by Tor Arne Vestbø.
2371
2372         * qmake/mkspecs/features/unix/default_post.prf:
2373
2374 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2375
2376         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2377         https://bugs.webkit.org/show_bug.cgi?id=85956
2378
2379         Reviewed by Gustavo Noronha Silva.
2380
2381         Catch new "load,provisional,failed" signal and print
2382         didFailProvisionalLoadWithError messages when LayoutTestController's
2383         dumpFrameLoadCallbacks() returns true. Also make sure the
2384         didFailLoadWithError message is not printed in case of provisional
2385         load failure.
2386
2387         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2388         (DumpRenderTreeChrome::createView):
2389         (DumpRenderTreeChrome::onFrameCreated):
2390         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2391         (DumpRenderTreeChrome::onFrameLoadError):
2392         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2393         (DumpRenderTreeChrome):
2394
2395 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2396
2397         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2398         https://bugs.webkit.org/show_bug.cgi?id=86366
2399
2400         Reviewed by Antonio Gomes.
2401
2402         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2403
2404         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2405         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2406
2407 2012-05-22  Darin Adler  <darin@apple.com>
2408
2409         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2410         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2411
2412 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2413
2414         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2415         https://bugs.webkit.org/show_bug.cgi?id=86922
2416
2417         Because we have new platformInit() in TestShellAndroid.cpp, and
2418         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2419         is split into TestShellPosix.cpp and TestShellX11.cpp.
2420
2421         Reviewed by Kent Tamura.
2422
2423         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2424         * DumpRenderTree/DumpRenderTree.gypi:
2425         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2426         (platformInit):
2427         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2428         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2429         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2430         (AlarmHandler):
2431         (TestShell::waitTestFinished):
2432         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2433         (openStartupDialog): from TestShellGtk.cpp
2434         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2435         (setupFontconfig):
2436         (platformInit):
2437
2438 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2439
2440         [EFL][DRT] Implement touch event
2441         https://bugs.webkit.org/show_bug.cgi?id=86720
2442
2443         Reviewed by Hajime Morita.
2444
2445         Currently EFL DRT doesn't support touch event.
2446         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2447
2448         * DumpRenderTree/efl/EventSender.cpp:
2449         (TouchEventInfo::TouchEventInfo):
2450         (TouchEventInfo):
2451         (touchPointList):
2452         (sendTouchEvent):
2453         (addTouchPointCallback):
2454         (touchStartCallback):
2455         (updateTouchPointCallback):
2456         (touchMoveCallback):
2457         (cancelTouchPointCallback):
2458         (touchCancelCallback):
2459         (releaseTouchPointCallback):
2460         (touchEndCallback):
2461         (clearTouchPointsCallback):
2462         (setTouchModifierCallback):
2463         * Scripts/webkitperl/FeatureList.pm:
2464
2465 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2466
2467         [Chromium-Android] Fix chromium_android_unittest
2468         https://bugs.webkit.org/show_bug.cgi?id=87196
2469
2470         Not reviewed.
2471         Temporarily disable chromium_android_unittest.
2472
2473         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2474         (ChromiumAndroidPortTest):
2475         (ChromiumAndroidDriverTest):
2476
2477 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2478
2479         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2480         https://bugs.webkit.org/show_bug.cgi?id=64313
2481
2482         Reviewed by Jon Honeycutt.
2483
2484         Add it.
2485
2486         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2487         Make sure to generate the binding.
2488
2489         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2490         (WTR::LayoutTestController::setDefersLoading):
2491         Call WKBundlePageSetDefersLoading.
2492         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2493
2494 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2495
2496         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2497         https://bugs.webkit.org/show_bug.cgi?id=86923
2498
2499         chromium_android.py is modified to support running DumpRenderTree as
2500         an apk, so that we can run the tests (e.g. video) requiring features
2501         implemented in Java on Android.
2502
2503         Reviewed by Adam Barth.
2504
2505         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2506         (ChromiumAndroidPort.__init__):
2507         (ChromiumAndroidPort.default_child_processes):
2508         (ChromiumAndroidPort.check_wdiff):
2509         (ChromiumAndroidPort.check_build):
2510         (ChromiumAndroidPort.start_helper):
2511         (ChromiumAndroidPort.skipped_layout_tests):
2512         (ChromiumAndroidPort):
2513         (ChromiumAndroidPort._path_to_driver):
2514         (ChromiumAndroidPort._get_crash_log):
2515         (ChromiumAndroidPort._push_executable):
2516         (ChromiumAndroidPort._run_adb_command):
2517         (ChromiumAndroidPort._get_last_stacktrace):
2518         (ChromiumAndroidPort._get_logcat):
2519         (ChromiumAndroidPort._setup_performance):
2520         (ChromiumAndroidDriver):
2521         (ChromiumAndroidDriver.__init__):
2522         (ChromiumAndroidDriver._command_wrapper):
2523         (ChromiumAndroidDriver.cmd_line):
2524         (ChromiumAndroidDriver._file_exists_on_device):
2525         (ChromiumAndroidDriver._deadlock_detector):
2526         (ChromiumAndroidDriver._start):
2527         (ChromiumAndroidDriver.run_test):
2528         (ChromiumAndroidDriver.stop):
2529         (ChromiumAndroidDriver._write_command_and_read_line):
2530         (ChromiumAndroidDriver._output_image):
2531         (ChromiumAndroidDriver._get_stderr):
2532
2533 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2534
2535         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2536
2537         Unreviewed gardening.
2538
2539         * Scripts/webkitpy/layout_tests/port/base.py:
2540         (Port.driver_name):
2541         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2542         (ChromiumLinuxPort._path_to_driver):
2543         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2544         (ChromiumPortTest.test_overrides_and_builder_names):
2545         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2546         (ChromiumWinPort._path_to_driver):
2547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2548         (parse_args):
2549
2550 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2551
2552         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2553         https://bugs.webkit.org/show_bug.cgi?id=87176
2554
2555         Reviewed by Tony Chang.
2556
2557         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2558         * DumpRenderTree/DumpRenderTree.gypi:
2559
2560 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2561
2562         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2563         https://bugs.webkit.org/show_bug.cgi?id=87128
2564
2565         Reviewed by Dirk Pranke.
2566
2567         * Scripts/webkitpy/layout_tests/port/base.py:
2568         (Port.driver_name):
2569         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2570         (ChromiumLinuxPort._path_to_driver):
2571         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2572         (ChromiumPortTest.test_driver_name_option):
2573         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2574         (ChromiumWinPort._path_to_driver):
2575         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2576         (parse_args):
2577
2578 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2579
2580         WTR fix after r118001.
2581
2582         Rubber-stamped by Alexey Proskuryakov.
2583
2584         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2585
2586         * WebKitTestRunner/mac/EventSenderProxy.mm:
2587         (WTR::EventSenderProxy::keyDown):
2588
2589 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2590
2591         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2592         https://bugs.webkit.org/show_bug.cgi?id=86684
2593
2594         Reviewed by Darin Fisher.
2595
2596         * DumpRenderTree/chromium/LayoutTestController.cpp:
2597         (LayoutTestController::numberOfPages):
2598         * DumpRenderTree/chromium/WebViewHost.cpp:
2599         (WebViewHost::printPage):
2600
2601 == Rolled over to ChangeLog-2012-05-22 ==