Use "wpt serve" to launch WPT server
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-23  Youenn Fablet  <youenn@apple.com>
2
3         Use "wpt serve" to launch WPT server
4         https://bugs.webkit.org/show_bug.cgi?id=188848
5
6         Reviewed by Ryosuke Niwa.
7
8         Use "wpt serve" provided by WPT instead of using our custom launcher.
9         This simplifies things and will avoid future breakage.
10         Further simplify web_platform_test_server.py by removing no longer needed actions.
11         - Do not copy files but use alias
12         - Do not kill main pid, which leaves subprocesses alive, use interrupt instead.
13         - Stop enumerating subprocess pids.
14
15         * Scripts/webkitpy/common/system/executive_mock.py:
16         (MockExecutive.interrupt):
17         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Removed.
18         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
19         (WebPlatformTestServer.__init__):
20         (WebPlatformTestServer.ports_to_forward):
21         (WebPlatformTestServer._prepare_config):
22         (WebPlatformTestServer._spawn_process):
23         (WebPlatformTestServer._stop_running_server):
24
25 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
26
27         run-api-tests: Add --webkit-only, --webcore-only and --webkit-legacy-only options to run WebKit, WebCore and WebKitLegacy tests 
28         https://bugs.webkit.org/show_bug.cgi?id=188262
29
30         Reviewed by Ryosuke Niwa.
31
32         * Scripts/webkitpy/api_tests/run_api_tests.py:
33         (parse_args):
34
35 2018-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
36
37         [Attachment Support] Support dragging attachment elements out as files on macOS
38         https://bugs.webkit.org/show_bug.cgi?id=181294
39         <rdar://problem/36298801>
40
41         Reviewed by Tim Horton.
42
43         Add DragAndDropSimulator support for intercepting calls to -beginDraggingSessionWithitems:event:source:. This
44         enables us to write API tests for macOS that exercise the attachment SPI in combination with dragging attachment
45         elements.
46
47         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
48         (-[TestWKWebView attachmentElementMidPoint]):
49
50         Add a helper method local to this test suite that grabs the midpoint (in client coordinates) or the first
51         attachment element in the document.
52
53         (TestWebKitAPI::TEST):
54
55         Add a new API test to verify that dragging an attachment element on macOS produces file providers which may be
56         used to write attachment data to a path on disk. Additionally, refactor an existing API test,
57         MoveAttachmentElementAsIconByDragging, so that it runs on both iOS and macOS, to test the ability to move
58         attachment elements around in a document by using drag and drop.
59
60         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
61         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
62         (-[DragAndDropTestWKWebView beginDraggingSessionWithItems:event:source:]):
63         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
64         (-[DragAndDropSimulator dealloc]):
65         (-[DragAndDropSimulator runFrom:to:]):
66         (-[DragAndDropSimulator beginDraggingSessionInWebView:withItems:source:]):
67
68         Begin a drag session and kick off the -continueDragSession loop. Unlike -performDragInWebView:…, which spins
69         the main runloop until dragging ends, this version returns execution to the web view and schedules dragging
70         updates asynchronously. This matches AppKit behavior.
71
72         (-[DragAndDropSimulator continueDragSession]):
73
74         Increment the dragging progress amount, send a drag update to the web view, and continue scheduling calls to
75         itself until the progress reaches 1.
76
77         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
78         (-[DragAndDropSimulator initializeDraggingInfo:dragImage:source:]):
79
80         Pull out common logic for creating a new TestDraggingInfo after starting a drag.
81
82         (-[DragAndDropSimulator insertedAttachments]):
83         (-[DragAndDropSimulator removedAttachments]):
84         (-[DragAndDropSimulator draggingSession]):
85         (-[DragAndDropSimulator receivePromisedFiles]):
86
87         Helper method to save promised files written to the pasteboard after a drag to the temporary directory. These
88         files are tracked by DragAndDropSimulator and automatically cleaned up after the test finishes.
89
90         (-[DragAndDropSimulator endDataTransfer]):
91
92         Add a method stub on macOS, so that MoveAttachmentElementAsIconByDragging can be made cross-platform.
93
94         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
95         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
96
97         Implement method stubs to keep track of inserted or removed attachments while simulating a drag.
98
99 2018-08-22  Aditya Keerthi  <akeerthi@apple.com>
100
101         [iOS] Add support for the inputmode attribute
102         https://bugs.webkit.org/show_bug.cgi?id=183621
103
104         Reviewed by Tim Horton.
105
106         Added an API test to verify that the correct UIKeyboardType is set depending on
107         the type, inputmode, and pattern specified for an input field.
108
109         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
110         (TestWebKitAPI::TEST):
111         * TestWebKitAPI/ios/UIKitSPI.h:
112
113 2018-08-22  Alex Christensen  <achristensen@webkit.org>
114
115         Fix API test on Sierra after r235139
116         https://bugs.webkit.org/show_bug.cgi?id=188810
117
118         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
119         (TEST):
120
121 2018-08-22  David Kilzer  <ddkilzer@apple.com>
122
123         Move files in WebCore project to match Xcode folder structure
124         <https://webkit.org/b/188851>
125
126         Reviewed by Tim Horton.
127
128         * Scripts/extract-localizable-strings:
129         * Scripts/update-webkit-localizable-strings:
130         - Update to match new location of extract-localizable-strings.pl.
131
132 2018-08-21  Alex Christensen  <achristensen@webkit.org>
133
134         Roll out r235139 and r235146
135         https://bugs.webkit.org/show_bug.cgi?id=188805
136
137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
138         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
139
140 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
141
142         [Attachment Support] Remove _WKAttachments and notify the UI client upon mainframe navigation
143         https://bugs.webkit.org/show_bug.cgi?id=188715
144         <rdar://problem/43541790>
145
146         Reviewed by Tim Horton.
147
148         Adds API tests to exercises cases where (1) the UI client is notified of attachment removal upon mainframe
149         navigation, and (2) the UI client is notified of attachment removal upon web content process termination.
150
151         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
152         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
153         (TestWebKitAPI::TEST):
154
155 2018-08-21  Alex Christensen  <achristensen@webkit.org>
156
157         Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
158         https://bugs.webkit.org/show_bug.cgi?id=188821
159
160         Reviewed by Simon Fraser.
161
162         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
163         (TestWebKitAPI::didLayout):
164         (TestWebKitAPI::TEST):
165
166 2018-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
167
168         [WHLSL] Call expressions shouldn't have type arguments
169         https://bugs.webkit.org/show_bug.cgi?id=188770
170
171         Reviewed by Filip Pizlo.
172
173         Call expressions only had type arguments for casts, becuase native types can have type arguments.
174         However, instead of putting those type arguments on the CallExpression, we should parse the casted
175         type as a real type and not as an identifier, which puts the type arguments in the TypeRef.
176
177         Test: casts
178
179         * WebGPUShadingLanguageRI/CallExpression.js:
180         (CallExpression):
181         (CallExpression.prototype.get name):
182         (CallExpression.resolve):
183         (CallExpression.prototype.get typeArguments): Deleted.
184         (CallExpression.prototype.becomeCast): Deleted.
185         * WebGPUShadingLanguageRI/NameResolver.js:
186         (NameResolver.prototype.visitCallExpression):
187         * WebGPUShadingLanguageRI/Parse.js:
188         (parseConstexpr):
189         (parseTypeDef):
190         (parseLeftOperatorCall):
191         (parseCallExpression.let.parseArguments):
192         (parsePossiblePrefix):
193         (parsePossibleRelationalEquality):
194         (parseLeftLogicalExpression):
195         (parseIfStatement):
196         (parseWhile):
197         (parseFor):
198         (parseDo):
199         * WebGPUShadingLanguageRI/RemoveTypeArguments.js:
200         * WebGPUShadingLanguageRI/Rewriter.js:
201         (Rewriter.prototype.visitCallExpression):
202
203 2018-08-21  Alex Christensen  <achristensen@webkit.org>
204
205         Translate WebKit.LimitTitleSize API test into ObjC
206         https://bugs.webkit.org/show_bug.cgi?id=188810
207
208         Reviewed by Andy Estes.
209
210         It uses WKPageLoaderClient.didReceiveTitleForFrame which has been replaced by KVO.
211         I'm translating the test into ObjC rather than introducing a new callback to WKPageNavigationClient.
212
213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
214         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp: Removed.
215         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
216         (TEST):
217         (-[LimitTitleSizeTestObserver observeValueForKeyPath:ofObject:change:context:]):
218         (TestWebKitAPI::TEST): Deleted.
219
220 2018-08-21  Alex Christensen  <achristensen@webkit.org>
221
222         Remove unused shouldKeepCurrentBackForwardListItemInList check
223         https://bugs.webkit.org/show_bug.cgi?id=188805
224
225         Reviewed by Andy Estes.
226
227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
229
230 2018-08-21  Alex Christensen  <achristensen@webkit.org>
231
232         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
233         https://bugs.webkit.org/show_bug.cgi?id=188813
234
235         Reviewed by Andy Estes.
236
237         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
238         (TestWebKitAPI::didLayout):
239         (TestWebKitAPI::setPageLoaderClient):
240         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
241         (TestWebKitAPI::didFinishNavigation):
242         (TestWebKitAPI::didLayout):
243         (TestWebKitAPI::setPageLoaderClient):
244         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
245         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
246         (TestWebKitAPI::didLayout):
247         (TestWebKitAPI::setPageLoaderClient):
248
249 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
252         https://bugs.webkit.org/show_bug.cgi?id=188496
253         <rdar://problem/43216836>
254
255         Reviewed by Tim Horton.
256
257         Adjusts existing attachment API tests. See below for more detail.
258
259         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
260         (-[TestWKWebView synchronouslyInsertAttachmentWithFileWrapper:contentType:]):
261         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
262         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
263         (-[_WKAttachment synchronouslySetFileWrapper:newContentType:error:]):
264
265         Move off of deprecated attachment SPI, and add new helper functions to synchronously insert a new attachment or
266         update an existing attachment with a file wrapper.
267
268         (-[_WKAttachment expectRequestedDataToBe:]):
269         (TestWebKitAPI::TEST):
270
271         Add a new test to verify that file-URL-backed NSFileWrappers can be used to insert and update attachment data.
272         Also augment an existing test to check that an attachment element which has been copied and pasted within the
273         same document has a different _WKAttachment wrapper object than its duplicate, but both _WKAttachments are
274         backed by the same NSFileWrapper that was originally used to insert the attachment.
275
276         Additionally, add another macOS test to verify that dropping promised files in an attachment-element-enabled
277         editable area inserts attachment elements into the document and notifies the UI client with the inserted
278         attachment data.
279
280         (-[_WKAttachment synchronouslyRequestInfo:]): Deleted.
281         (-[_WKAttachment synchronouslyRequestData:]): Deleted.
282         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
283         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
284
285         Move off of -_webView:didInsertAttachment:.
286
287         (-[DragAndDropSimulator _webView:didInsertAttachment:]): Deleted.
288
289 2018-08-21  David Kilzer  <ddkilzer@apple.com>
290
291         sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name
292         <https://webkit.org/b/188755>
293
294         Reviewed by Andy Estes.
295
296         * Scripts/sort-Xcode-project-file: Fix regular expression to
297         make `mainGroup` name optional.
298
299 2018-08-21  Andy VanWagoner  <andy@vanwagoner.family>
300
301         Unreviewed, add myself to committers list.
302
303         * Scripts/webkitpy/common/config/contributors.json:
304
305 2018-08-21  Antti Koivisto  <antti@apple.com>
306
307         Allow creating WeakPtrs to const objects
308         https://bugs.webkit.org/show_bug.cgi?id=188785
309
310         Reviewed by Geoffrey Garen.
311
312         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
313         (TestWebKitAPI::Base::weakPtrFactory const):
314         (TestWebKitAPI::TEST):
315         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
316
317 2018-08-21  Per Arne Vollan  <pvollan@apple.com>
318
319         [WebGL] Contexts are not updated when display configuration changed.
320         https://bugs.webkit.org/show_bug.cgi?id=188750
321
322         Reviewed by Brent Fulgham.
323
324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
326         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
328         * WebKitTestRunner/TestController.cpp:
329         (WTR::TestController::sendDisplayConfigurationChangedMessageForTesting):
330         * WebKitTestRunner/TestController.h:
331         * WebKitTestRunner/TestInvocation.cpp:
332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
333
334 2018-08-21  John Wilander  <wilander@apple.com>
335
336         Make ResourceLoadObserver::logWebSocketLoading() handle websockets in detached frames
337         https://bugs.webkit.org/show_bug.cgi?id=188757
338         <rdar://problem/38713390>
339
340         Reviewed by Alex Christensen.
341
342         These changes add the new WebKitTestRunner function
343         isStatisticsRegisteredAsSubresourceUnder().
344
345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
347         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
349         * WebKitTestRunner/TestController.cpp:
350         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
351         * WebKitTestRunner/TestController.h:
352         * WebKitTestRunner/TestInvocation.cpp:
353         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
354
355 2018-08-21  Alex Christensen  <achristensen@webkit.org>
356
357         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
358         https://bugs.webkit.org/show_bug.cgi?id=188797
359
360         Reviewed by Tim Horton.
361
362         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
363         (TestWebKitAPI::didFinishNavigation):
364         (TestWebKitAPI::TEST):
365         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
366         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
367         (TestWebKitAPI::didSameDocumentNavigation):
368         (TestWebKitAPI::TEST):
369         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
370         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
371         (TestWebKitAPI::didFailProvisionalNavigation):
372         (TestWebKitAPI::TEST):
373         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
374         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
375         (TestWebKitAPI::didStartProvisionalNavigation):
376         (TestWebKitAPI::didCommitNavigation):
377         (TestWebKitAPI::didFinishNavigation):
378         (TestWebKitAPI::TEST):
379         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
380         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
381         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
382         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
383         (TestWebKitAPI::didStartProvisionalNavigation):
384         (TestWebKitAPI::didCommitNavigation):
385         (TestWebKitAPI::didFinishNavigation):
386         (TestWebKitAPI::TEST):
387         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
388         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
389         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
390         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
391         (TestWebKitAPI::renderingProgressDidChange):
392         (TestWebKitAPI::TEST):
393         (TestWebKitAPI::didLayout): Deleted.
394         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
395         (TestWebKitAPI::didFinishNavigation):
396         (TestWebKitAPI::renderingProgressDidChange):
397         (TestWebKitAPI::setPageLoaderClient):
398         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
399         (TestWebKitAPI::didLayout): Deleted.
400         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
401         (TestWebKitAPI::State::State):
402         (TestWebKitAPI::didStartProvisionalNavigation):
403         (TestWebKitAPI::didCommitNavigation):
404         (TestWebKitAPI::didFinishNavigation):
405         (TestWebKitAPI::decidePolicyForNavigationAction):
406         (TestWebKitAPI::decidePolicyForResponse):
407         (TestWebKitAPI::TEST):
408         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
409         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
410         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
411         (TestWebKitAPI::decidePolicyForNewWindowAction): Deleted.
412         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
413         (TestWebKitAPI::didSameDocumentNavigation):
414         (TestWebKitAPI::TEST):
415         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
416         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
417         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
418         (TestWebKitAPI::TEST):
419         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
420         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
421         (TestWebKitAPI::didFinishLoad):
422         (TestWebKitAPI::TEST):
423         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp:
424         (TestWebKitAPI::didFinishNavigation):
425         (TestWebKitAPI::TEST):
426         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
427         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
428         (TestWebKitAPI::didFinishLoad):
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
431         (WebKit2_CommandBackForwardTestWKView::SetUp):
432         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame): Deleted.
433
434 2018-08-20  Alex Christensen  <achristensen@webkit.org>
435
436         Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
437         https://bugs.webkit.org/show_bug.cgi?id=188771
438
439         Reviewed by Tim Horton.
440
441         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
442         (TestWebKitAPI::didFinishNavigation):
443         (TestWebKitAPI::TEST):
444         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
445         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
446         (TestWebKitAPI::didFinishNavigation):
447         (TestWebKitAPI::TEST):
448         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
449         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
450         (TestWebKitAPI::didFinishNavigation):
451         (TestWebKitAPI::setPageLoaderClient):
452         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
453         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
454         (TestWebKitAPI::TEST):
455         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
456         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
457         (TestWebKitAPI::didFinishNavigation):
458         (TestWebKitAPI::setPageLoaderClient):
459         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
460         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
461         (TestWebKitAPI::didFinishNavigation):
462         (TestWebKitAPI::setClients):
463         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
464         * TestWebKitAPI/Tests/WebKit/Find.cpp:
465         (TestWebKitAPI::didFinishNavigation):
466         (TestWebKitAPI::TEST):
467         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
468         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
469         (TestWebKitAPI::didFinishNavigation):
470         (TestWebKitAPI::TEST):
471         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
472         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
473         (TestWebKitAPI::didFinishNavigation):
474         (TestWebKitAPI::TEST):
475         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
476         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
477         (TestWebKitAPI::didFinishNavigation):
478         (TestWebKitAPI::TEST):
479         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
480         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
481         (TestWebKitAPI::didFinishNavigation):
482         (TestWebKitAPI::TEST):
483         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
484         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
485         (TestWebKitAPI::didFinishNavigation):
486         (TestWebKitAPI::setPageLoaderClient):
487         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
488         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
489         (TestWebKitAPI::didFinishNavigation):
490         (TestWebKitAPI::TEST):
491         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
492         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp:
493         (TestWebKitAPI::didFinishLoadForFrame):
494         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
495         (TestWebKitAPI::didFinishNavigation):
496         (TestWebKitAPI::loadAlternateHTMLString):
497         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
498         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
499         (TestWebKitAPI::didFinishNavigation):
500         (TestWebKitAPI::TEST):
501         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
502         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
503         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
504         (TestWebKitAPI::didFinishLoad):
505         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
506         (TestWebKitAPI::didFinishNavigation):
507         (TestWebKitAPI::setPageLoaderClient):
508         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
509         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
510         (TestWebKitAPI::didFinishNavigation):
511         (TestWebKitAPI::setPageLoaderClient):
512         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
513         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
514         (TestWebKitAPI::didFinishLoadForFrame):
515         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
516         (TestWebKitAPI::TEST):
517         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
518         (TestWebKitAPI::TEST):
519         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
520         (TestWebKitAPI::didFinishLoad):
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
523         (TestWebKitAPI::didFinishNavigation):
524         (TestWebKitAPI::setPageLoaderClient):
525         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
526         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
527         (TestWebKitAPI::didFinishNavigation):
528         (TestWebKitAPI::setPageLoaderClient):
529         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
530         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
531         (TestWebKitAPI::didFinishNavigation):
532         (TestWebKitAPI::TEST):
533         (TestWebKitAPI::didFinishDocumentLoadForFrame): Deleted.
534         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
535         (TestWebKitAPI::didFinishNavigation):
536         (TestWebKitAPI::TEST):
537         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
538         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
539         (TestWebKitAPI::didFailProvisionalNavigation):
540         (TestWebKitAPI::TEST):
541         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
542         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
543         (TestWebKitAPI::didFinishNavigation):
544         (TestWebKitAPI::TEST):
545         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
546         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
547         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishNavigation):
548         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
549         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame): Deleted.
550         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
551         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishNavigation):
552         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
553         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame): Deleted.
554         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
555         (TestWebKitAPI::didFinishNavigation):
556         (TestWebKitAPI::setPageLoaderClient):
557         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
558         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
559         (TestWebKitAPI::didFinishNavigation):
560         (TestWebKitAPI::setPageLoaderClient):
561         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
562         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
563         (TestWebKitAPI::didFinishNavigation):
564         (TestWebKitAPI::setPageLoaderClient):
565         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
566         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
567         (TestWebKitAPI::didFinishNavigation):
568         (TestWebKitAPI::setUpClients):
569         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
570         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
571         (TestWebKitAPI::didFinishNavigation):
572         (TestWebKitAPI::setPageLoaderClient):
573         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
574         * TestWebKitAPI/Tests/WebKit/WebArchive.cpp:
575         (TestWebKitAPI::didFinishNavigation):
576         (TestWebKitAPI::TEST):
577         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
578         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
579         (TestWebKitAPI::didFinishNavigation):
580         (TestWebKitAPI::TEST):
581         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
582         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
583         (TestWebKitAPI::didFinishNavigation):
584         (TestWebKitAPI::TEST):
585         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
586         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
587         (TestWebKitAPI::didFinishNavigation):
588         (TestWebKitAPI::TEST):
589         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
590         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
591         (TestWebKitAPI::didFinishNavigation):
592         (TestWebKitAPI::TEST):
593         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
594         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
595         (TestWebKitAPI::didFinishNavigation):
596         (TestWebKitAPI::TEST):
597         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
598         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
599         (TestWebKitAPI::didFinishNavigation):
600         (TestWebKitAPI::TEST):
601         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
602         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
603         (didFinishNavigation):
604         (TestWebKitAPI::TEST):
605         (didFinishLoadForFrame): Deleted.
606         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
607         (didFinishNavigation):
608         (TestWebKitAPI::TEST):
609         (didFinishLoadForFrame): Deleted.
610         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
611         (TestWebKitAPI::didFinishNavigation):
612         (TestWebKitAPI::TEST):
613         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
614         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
615         (TestWebKitAPI::didFinishNavigation):
616         (TestWebKitAPI::setPageLoaderClient):
617         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
618
619 2018-08-21  Adrian Perez de Castro  <aperez@igalia.com>
620
621         [WPE] Update to use libwpe-1.0.0 and WPEBackend-fdo-1.0.0
622         https://bugs.webkit.org/show_bug.cgi?id=188782
623
624         Reviewed by Michael Catanzaro.
625
626         Make the build depend on wpe-0.2, and change the Flatpak and JHBuild development
627         environments to use version 1.0.0 of libwpe and WPEBackend-fdo.
628
629         * flatpak/org.webkit.WPE.yaml: Update to use libwpe and WPEBackend-fdo version 1.0.0 from
630         release tarballs, and removed the (now unneeded) Lua and LuaJIT modules.
631         * wpe/jhbuild.modules: Ditto.
632
633 2018-08-21  Michael Catanzaro  <mcatanzaro@igalia.com>
634
635         [Flatpak] Update to GNOME master runtime
636         https://bugs.webkit.org/show_bug.cgi?id=188731
637
638         Reviewed by Philippe Normand.
639
640         The 3.28 runtime is pretty stale at this point. We could wait a couple weeks for the 3.30
641         runtime, but I don't think there's any need to stick with the stable runtime when we have
642         the ability to pin to a particular version of the master runtime. There are also several
643         advantages to switching to the master runtime.
644
645         * flatpak/files/httpd-autogen.sh: Removed.
646         * flatpak/flatpakutils.py:
647         (WebkitFlatpak.clean_args):
648         * flatpak/org.webkit.GTK.yaml:
649         * flatpak/org.webkit.WebKit.yaml:
650         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
651         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
652
653 2018-08-20  Jonathan Bedard  <jbedard@apple.com>
654
655         WebKitTestRunner: Add watchOS entitlements
656         https://bugs.webkit.org/show_bug.cgi?id=188758
657
658         Reviewed by Tim Horton.
659
660         watchOS needs an additional entitlement to open up a socket for on-device testing.
661
662         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements: Added.
663         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
664         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
665
666 2018-08-20  Thomas Denney  <tdenney@apple.com>
667
668         [WHLSL] Remove generics from the interpreter
669         https://bugs.webkit.org/show_bug.cgi?id=187988
670
671         Reviewed by Myles C. Maxfield.
672
673         This patch completely removes generic and protocol support from WHLSL
674         whilst adding back any features that were originally implemented with
675         generics.
676
677         Many of the changes in this patch just remove occurrences of type
678         arguments and type parameters --- although there are some cases where
679         they have been deliberately left in --- as well as removing tests only
680         relevant to those features. These changes are not listed below.
681
682         * WebGPUShadingLanguageRI/All.js: Add/remove JS dependencies
683         * WebGPUShadingLanguageRI/AutoWrapper.js:
684         (AutoWrapper.prototype.visitConstexprTypeParameter): Deleted.
685         * WebGPUShadingLanguageRI/BuiltinVectorCasts.js: Added. The built-in
686         vectors have many constructors for different scalar and vector types.
687         These were originally implemented with generics.
688         * WebGPUShadingLanguageRI/BuiltinVectorEqualityOperator.js: Adds the
689         equality operator for built-in vectors, again this was removed with
690         generics.
691         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Added, as above.
692         Built-in vectors only support the getter and setter, and not the ander.
693         * WebGPUShadingLanguageRI/BuiltinVectorIndexGetter.js: Added.
694         * WebGPUShadingLanguageRI/BuiltinVectorIndexSetter.js: Added.
695         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Added.
696         * WebGPUShadingLanguageRI/CallExpression.js: Adds support for
697         instantiating functions which cannot be discovered earlier in
698         preparation because their types are absent (specifically support for the
699         operator &[] for array references and the length operator for array
700         references). Previously support for these was implemented with generics.
701         (CallExpression.resolve):
702         (CallExpression.prototype.resolve):
703         (CallExpression.prototype._resolveByInstantiation):
704         (CallExpression.prototype._resolveToOperatorAnderIndexer):
705         (CallExpression.prototype._resolveToOperatorLength):
706         (CallExpression.prototype.resolveToOverload):
707         (CallExpression.prototype.becomeCast):
708         (CallExpression.prototype.toString):
709         (CallExpression):
710         * WebGPUShadingLanguageRI/CallExpressionTypeArgumentResolver.js: Added.
711         We support syntax like vector<int, 2>(a, b) for constructing vectors;
712         this new preparation step resolves them to specific constructors.
713         * WebGPUShadingLanguageRI/CallFunction.js:
714         * WebGPUShadingLanguageRI/Checker.js:
715         * WebGPUShadingLanguageRI/ConstexprFolder.js:
716         * WebGPUShadingLanguageRI/CreateLiteralType.js:
717         * WebGPUShadingLanguageRI/ExpressionFinder.js:
718         * WebGPUShadingLanguageRI/FlattenProtocolExtends.js: Removed.
719         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
720         * WebGPUShadingLanguageRI/Func.js:
721         * WebGPUShadingLanguageRI/FuncDef.js:
722         * WebGPUShadingLanguageRI/FuncInstantiator.js: Deleted.
723         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed usage of type arguments.
724         * WebGPUShadingLanguageRI/Inline.js: Remove use of FuncInstantiator.
725         * WebGPUShadingLanguageRI/Inliner.js: Ditto.
726         * WebGPUShadingLanguageRI/Intrinsics.js:
727         * WebGPUShadingLanguageRI/Lexer.js:
728         * WebGPUShadingLanguageRI/LiteralTypeChecker.js:
729         * WebGPUShadingLanguageRI/NameContext.js:
730         (NameContext.prototype.add):
731         (NameContext.prototype.get let):
732         (NameContext.underlyingThings.prototype.else):
733         (NameContext.prototype.resolveFuncOverload):
734         * WebGPUShadingLanguageRI/NameFinder.js:
735         * WebGPUShadingLanguageRI/NameResolver.js:
736         (NameResolver.prototype.visitFunc):
737         (NameResolver.prototype.visitFuncDef):
738         (NameResolver.prototype.visitTypeDef):
739         (NameResolver.prototype.visitStructType):
740         (NameResolver.prototype.visitTypeRef):
741         (NameResolver.prototype.visitCallExpression):
742         (NameResolver.prototype.visitVectorType):
743         (NameResolver):
744         (NameResolver.prototype._visitTypeParametersAndBuildNameContext): Deleted.
745         (NameResolver.prototype.visitProtocolDecl): Deleted.
746         * WebGPUShadingLanguageRI/NativeFunc.js:
747         (NativeFunc):
748         * WebGPUShadingLanguageRI/NativeFuncInstance.js: Deleted.
749         * WebGPUShadingLanguageRI/NativeType.js:
750         (NativeType):
751         (NativeType.prototype.get name):
752         (NativeType.prototype.toString):
753         (NativeType.prototype.get typeParameters): Deleted.
754         (NativeType.prototype.instantiate): Deleted.
755         * WebGPUShadingLanguageRI/Node.js:
756         (Node.prototype.commit):
757         (Node):
758         (Node.prototype.substitute): Deleted.
759         (Node.prototype.substituteToUnification): Deleted.
760         * WebGPUShadingLanguageRI/OperatorAnderIndex.js: Added, previously
761         implemented with generics.
762         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Ditto.
763         * WebGPUShadingLanguageRI/OperatorBool.js: Ditto.
764         * WebGPUShadingLanguageRI/Parse.js: Removed everything related to
765         generics and protocols.
766         * WebGPUShadingLanguageRI/Prepare.js: Added new stages.
767         * WebGPUShadingLanguageRI/Program.js:
768         (Program):
769         (Program.prototype.get types):
770         (Program.prototype.add):
771         (Program.prototype.get protocols): Deleted.
772         * WebGPUShadingLanguageRI/ProtocolDecl.js: Removed.
773         * WebGPUShadingLanguageRI/ProtocolRef.js: Removed.
774         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js:
775         * WebGPUShadingLanguageRI/ResolveCallExpressionsWithTypeArguments.js: Added.
776         * WebGPUShadingLanguageRI/ResolveNames.js:
777         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
778         * WebGPUShadingLanguageRI/ResolveTypeDefs.js:
779         (resolveTypeDefsInProtocols): Deleted.
780         * WebGPUShadingLanguageRI/Rewriter.js: Changes for new classes.
781         * WebGPUShadingLanguageRI/SPIRV.html:
782         * WebGPUShadingLanguageRI/SPIRVCodegen.js:
783         * WebGPUShadingLanguageRI/StandardLibrary.js: Replace old generic features.
784         * WebGPUShadingLanguageRI/StatementCloner.js: Changes for new classes.
785         (StructLayoutBuilder):
786         * WebGPUShadingLanguageRI/StructType.js:
787         * WebGPUShadingLanguageRI/SwizzleOp.js:
788         (SwizzleOp):
789         (SwizzleOp.prototype.get baseTypeName):
790         (SwizzleOp.prototype.toString):
791         (SwizzleOp.functions.):
792         (SwizzleOp.functions):
793         (SwizzleOp.prototype.instantiateImplementation):
794         (SwizzleOp.allSwizzleOperators.): Deleted.
795         (SwizzleOp.allSwizzleOperators): Deleted.
796         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Added,
797         previously implemented with generics.
798         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Ditto.
799         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Ditto.
800         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Ditto.
801         * WebGPUShadingLanguageRI/SynthesizeOperatorBool.js: Ditto.
802         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
803         (synthesizeStructAccessors.setupImplementationData):
804         (synthesizeStructAccessors.createFieldType):
805         (synthesizeStructAccessors.createTypeRef):
806         (synthesizeStructAccessors.setupAnder):
807         (synthesizeStructAccessors):
808         (synthesizeStructAccessors.createTypeParameters): Deleted.
809         (synthesizeStructAccessors.): Deleted.
810         * WebGPUShadingLanguageRI/Test.html:
811         * WebGPUShadingLanguageRI/Test.js: Removed redundant tests and added new
812         tests for changed language features.
813         * WebGPUShadingLanguageRI/Type.js:
814         * WebGPUShadingLanguageRI/TypeDef.js:
815         * WebGPUShadingLanguageRI/TypeDefResolver.js:
816         * WebGPUShadingLanguageRI/TypeParameterRewriter.js: Removed.
817         * WebGPUShadingLanguageRI/TypeRef.js:
818         * WebGPUShadingLanguageRI/TypeVariable.js: Removed.
819         * WebGPUShadingLanguageRI/UnificationContext.js:
820         * WebGPUShadingLanguageRI/VectorType.js: Added.
821         * WebGPUShadingLanguageRI/Visitor.js: Changes for new classes.
822         * WebGPUShadingLanguageRI/WSL.md: Removed description of
823         generics/protocols.
824         * WebGPUShadingLanguageRI/WrapChecker.js:
825         (WrapChecker):
826         (WrapChecker.visitConstexprTypeParameter): Deleted.
827         (WrapChecker.prototype.visitFuncParameter): Deleted.
828         (WrapChecker.prototype.visitTypeVariable): Deleted.
829         * WebGPUShadingLanguageRI/index.html:
830
831 2018-08-20  Thomas Denney  <tdenney@apple.com>
832
833         Added Thomas Denney to contributors.json.
834         https://bugs.webkit.org/show_bug.cgi?id=188525
835
836         Reviewed by Myles C. Maxfield.
837
838         * Scripts/webkitpy/common/config/contributors.json:
839
840 2018-08-20  Bernhard M. Wiedemann  <bwiedemann@suse.de>
841
842         [GTK] Sort inspector GResource manifest to ensure reproducible builds
843         https://bugs.webkit.org/show_bug.cgi?id=188738
844
845         Reviewed by Michael Catanzaro.
846
847         * glib/generate-inspector-gresource-manifest.py:
848         (get_filenames): sort list of input files
849
850 2018-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
851
852         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
853         https://bugs.webkit.org/show_bug.cgi?id=184271
854         <rdar://problem/39256708>
855
856         Reviewed by Andy Estes.
857
858         This API test is failing when run against older macOS builds, where custom pasteboard
859         data is not enabled by default.
860
861         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
862         (TestWebKitAPI::TEST):
863
864 2018-08-20  Claudio Saavedra  <csaavedra@igalia.com>
865
866         Add WPE Debug configuration to the flakiness dashboard
867         https://bugs.webkit.org/show_bug.cgi?id=188743
868
869         Reviewed by Michael Catanzaro.
870
871         * TestResultServer/static-dashboards/builders.jsonp:
872         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
873
874 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
875
876         [GLIB] Add API to throw exceptions using printf formatted strings
877         https://bugs.webkit.org/show_bug.cgi?id=188698
878
879         Reviewed by Michael Catanzaro.
880
881         Add cases to test the new API.
882
883         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
884         (createFormattedError):
885         (createCustomFormattedError):
886         (testJSCExceptions):
887
888 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         [GLIB] Complete the JSCException API
891         https://bugs.webkit.org/show_bug.cgi?id=188695
892
893         Reviewed by Michael Catanzaro.
894
895         Add cases to test the new API.
896
897         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
898         (testJSCCheckSyntax):
899         (createCustomError):
900         (testJSCExceptions):
901
902 2018-08-18  Wenson Hsieh  <wenson_hsieh@apple.com>
903
904         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
905         https://bugs.webkit.org/show_bug.cgi?id=184271
906         <rdar://problem/39256708>
907
908         Reviewed by Ryosuke Niwa.
909
910         Add a new API test to verify that on both iOS and macOS, copied custom pasteboard data can only be pasted in a
911         matching origin. Additionally verify that on iOS, the web view is capable of performing the "paste:" selector.
912
913         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
914         (TestWebKitAPI::TEST):
915         (imagePath): Deleted.
916         (writeTypesAndDataToPasteboard): Deleted.
917         (setUpWebView): Deleted.
918         (markupString): Deleted.
919
920         Make this test file no longer exclusive to macOS.
921
922         * TestWebKitAPI/cocoa/TestWKWebView.h:
923         * TestWebKitAPI/cocoa/TestWKWebView.mm:
924         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]):
925
926         Tweak this helper to also take in a `baseURL`. Defaults to using the TestWebKitAPI bundle resource URL.
927
928         (-[TestWKWebView synchronouslyLoadHTMLString:]):
929
930 2018-08-17  Jonathan Bedard  <jbedard@apple.com>
931
932         Add back --wtf-only to run-api-tests
933         https://bugs.webkit.org/show_bug.cgi?id=187893
934         <rdar://problem/42483983>
935
936         Reviewed by Aakash Jain.
937
938         When doing WTF development, it is not necessary to build or run all of the API
939         tests. Generally, if a user has specified a specific binary (or binaries) that
940         they are interested in testing, it is not necessary to check all API test binaries.
941
942         * Scripts/webkitpy/api_tests/manager.py:
943         (Manager._collect_tests): Only use the binaries matching the program arguments
944         when collecting tests.
945         (Manager._binaries_for_arguments): Generate a list of binaries which match the
946         program arguments.
947         (Manager.run): Pass a list binaries to check.
948         * Scripts/webkitpy/api_tests/run_api_tests.py:
949         (parse_args):
950         * Scripts/webkitpy/port/base.py:
951         (Port.check_api_test_build): If the caller specifies which API test binaries it
952         requires, only check the ones specified.
953         (Port.path_to_api_test_binaries): Allow the caller to only build the WTF API tests.
954         (Port._build_api_tests): Allow the caller to only build the WTF API tests.
955         * Scripts/webkitpy/port/win.py:
956         (WinPort.path_to_api_test_binaries):
957
958 2018-08-17  Jer Noble  <jer.noble@apple.com>
959
960         REGRESSION (234743) Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio
961         https://bugs.webkit.org/show_bug.cgi?id=188470
962         <rdar://problem/43144969>
963
964         Reviewed by Alex Christensen.
965
966         On a loaded server, the WebContent process may send the "playing" message before the
967         UIProcess has a chance to register a listener for that message. Restructure the tests
968         so that the listener is registered before the page is loaded.
969
970         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
971         (PreferredAudioBufferSize::runPlayingTestWithPageNamed):
972         (TEST_F):
973
974 2018-08-16  Wenson Hsieh  <wenson_hsieh@apple.com>
975
976         [macOS] [WK2] Add infrastructure to test receiving file promises on drop
977         https://bugs.webkit.org/show_bug.cgi?id=188583
978
979         Reviewed by Andy Estes.
980
981         Enable testing file promise drop handling on the WebKit2 port of macOS by introducing a subclass of
982         NSFilePromiseReceiver and implementing `-enumerateDraggingItemsWithOptions:forView:…` on TestDraggingInfo (the
983         concrete NSDraggingInfo implementation used by DragAndDropSimulator) using the mock file receiver. Also
984         introduces 3 new macOS tests. See below for more details.
985
986         A large portion of this logic is ported over from DumpRenderTree testing infrastructure added in r229297. In a
987         future patch, we should introduce a way to write code common to both API tests, WebKitTestRunner and
988         DumpRenderTree, and make this code shared among all three testing harnesses.
989
990         Tests:  DragAndDropTests.DragImageElementIntoFileUpload
991                 DragAndDropTests.DragPromisedImageFileIntoFileUpload
992                 DragAndDropTests.DragImageFileIntoFileUpload
993
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
996         (TEST):
997
998         Drive-by fix: Replace NSMakePoint with CGPointMake.
999
1000         * TestWebKitAPI/Tests/WebKitCocoa/image-and-file-upload.html:
1001
1002         Add a new test page consisting of an image and a "file upload" area that updates exercises DataTransfer API to
1003         load the dropped image.
1004
1005         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1006         (waitForConditionWithLogging):
1007
1008         Add a helper function to wait for a condition to evaluate to true. To make failures more informative,
1009         additionally add a mechanism to log a warning message after a given timeout, if the condition has yet to be met.
1010
1011         (TEST):
1012
1013         Add new tests to exercise a few cases of file upload in WebKit, including: (1) dragging from an image element,
1014         (2) dragging files written to the pasteboard as promises, and (3) files written to the pasteboard as file URLs.
1015
1016         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1017
1018         Surface the new functionality provided by the file promise receiver mock via two new methods on
1019         DragAndDropSimulator to (1) write files as file promises to the pasteboard, and (2) write files as file paths
1020         directly to the pasteboard.
1021
1022         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1023         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
1024         (-[DragAndDropSimulator externalPromisedFiles]):
1025         (getFilePathsAndTypeIdentifiers):
1026         (-[DragAndDropSimulator writePromisedFiles:]):
1027         (-[DragAndDropSimulator writeFiles:]):
1028         * TestWebKitAPI/mac/TestDraggingInfo.h:
1029         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1030         (-[TestDraggingInfo initWithDragAndDropSimulator:]):
1031         (-[TestDraggingInfo filePromiseReceivers]):
1032         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1033
1034         Implement this by invoking the given block with a TestFilePromiseReceiver. While all other classes are
1035         unhandled by this testing code, WebKit only calls into this with [NSFilePromiseReceiver class], this is
1036         currently sufficient for testing purposes.
1037
1038         * TestWebKitAPI/mac/TestFilePromiseReceiver.h: Copied from Tools/TestWebKitAPI/mac/TestDraggingInfo.h.
1039         * TestWebKitAPI/mac/TestFilePromiseReceiver.mm: Added.
1040         (-[TestFilePromiseReceiver initWithPromisedTypeIdentifiers:dragAndDropSimulator:]):
1041         (-[TestFilePromiseReceiver fileTypes]):
1042         (-[TestFilePromiseReceiver fileNames]):
1043         (-[TestFilePromiseReceiver dealloc]):
1044         (-[TestFilePromiseReceiver draggingSource]):
1045         (-[TestFilePromiseReceiver setDraggingSource:]):
1046         (fileNameWithNumericSuffix):
1047         (copyFile):
1048
1049         Add a helper to copy a file into a destination directory. Used to implement the main functionality of our
1050         NSFilePromiseReceiver subclass, which copies the files specified by test code into the directory determined by
1051         WebKit.
1052
1053         (-[TestFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
1054
1055 2018-08-16  Alex Christensen  <achristensen@webkit.org>
1056
1057         Add entitlement to MiniBrowser to allow it to communicate with com.apple.Safari.SafeBrowsing.Service
1058         https://bugs.webkit.org/show_bug.cgi?id=188677
1059
1060         Reviewed by Tim Horton.
1061
1062         * MiniBrowser/MiniBrowser.entitlements:
1063         SSBLookupContext lookUpURL:completionHandler: fails to communicate with its service without this entitlement
1064         on released operating systems.  See <rdar://problem/42749777>
1065
1066 2018-08-16  Jer Noble  <jer.noble@apple.com>
1067
1068         Add option to run-api-tests to force running of DISABLED tests.
1069         https://bugs.webkit.org/show_bug.cgi?id=188674
1070
1071         Reviewed by Joseph Pecoraro.
1072
1073         * Scripts/webkitpy/api_tests/run_api_tests.py:
1074         (parse_args):
1075         * Scripts/webkitpy/api_tests/runner.py:
1076         (Runner.command_for_port):
1077         (_Worker._run_single_test):
1078
1079 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews-build] Separate queues for Builders and Testers - macOS High Sierra
1082         https://bugs.webkit.org/show_bug.cgi?id=188540
1083
1084         Reviewed by Lucas Forschler.
1085
1086         * BuildSlaveSupport/ews-build/config.json: Splitted few macOS queues into builders and testers. 
1087
1088 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-build] Add build steps ArchiveTestResults, UploadTestResults and ExtractTestResults
1091         https://bugs.webkit.org/show_bug.cgi?id=188666
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-build/steps.py:
1096         (ArchiveTestResults): Build step to Archive the test results.
1097         (UploadTestResults): Build step to upload the archive.
1098         (ExtractTestResults): Build step to unzip the archive on server and generate a link.
1099         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1100         (ExpectMasterShellCommand): Copied from other similar internal code.
1101
1102 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
1103
1104         [ews-build] Separate queues for Builders and Testers - macOS Sierra
1105         https://bugs.webkit.org/show_bug.cgi?id=188516
1106
1107         Reviewed by Lucas Forschler.
1108
1109         * BuildSlaveSupport/ews-build/config.json: Splitted macOS Sierra Release queues into builders and testers.
1110         * BuildSlaveSupport/ews-build/factories.py: Used appropriate base classes for builders and testers.
1111
1112 2018-08-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1113
1114         [Win][DumpRenderTree] Remove error message for duplicated tests.
1115         https://bugs.webkit.org/show_bug.cgi?id=188662
1116
1117         Reviewed by Per Arne Vollan.
1118
1119         This was added to track down an issue where the same tests appeared
1120         to be run multiple times. This turned out to not be the case.
1121         See https://bugs.webkit.org/show_bug.cgi?id=166760 .
1122
1123         * DumpRenderTree/win/DumpRenderTree.cpp:
1124         (runTest):
1125
1126 2018-08-16  Alex Christensen  <achristensen@webkit.org>
1127
1128         Re-introduce assertion removed in r234890
1129         https://bugs.webkit.org/show_bug.cgi?id=188611
1130
1131         Reviewed by Geoffrey Garen.
1132
1133         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1134         (TestWebKitAPI::TEST):
1135
1136 2018-08-16  Jer Noble  <jer.noble@apple.com>
1137
1138         Add Experimental Feature support for SourceBuffer.changeType()
1139         https://bugs.webkit.org/show_bug.cgi?id=188626
1140         <rdar://problem/43356021>
1141
1142         Reviewed by Eric Carlson.
1143
1144         * DumpRenderTree/mac/DumpRenderTree.mm:
1145         (enableExperimentalFeatures):
1146         (resetWebPreferencesToConsistentValues):
1147         * WebKitTestRunner/TestController.cpp:
1148         (WTR::TestController::resetPreferencesToConsistentValues):
1149
1150 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1151
1152         Support drag-and-drop for input[type=color]
1153         https://bugs.webkit.org/show_bug.cgi?id=188464
1154
1155         Reviewed by Wenson Hsieh.
1156
1157         Added five cross-platform API tests, to verify that dragging and dropping with
1158         color inputs changes the value of the drop target if and only if both inputs are
1159         enabled. Also tests that the change and input events are fired when changing the
1160         value of a color input through drag and drop. 
1161
1162         Additionally, added a macOS-specific test to verify that dropping an item with
1163         NSColorPboardType changes the value of the color input.
1164
1165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1166         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WebKitCocoa/color-drop.html: Added.
1169         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
1170         (TestWebKitAPI::TEST):
1171
1172 2018-08-16  Antti Koivisto  <antti@apple.com>
1173
1174         Use OptionSet for ActivityState::Flags
1175         https://bugs.webkit.org/show_bug.cgi?id=188554
1176
1177         Reviewed by Brent Fulgham.
1178
1179         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1180         (TestWebKitAPI::TEST):
1181
1182 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         [GTK] MiniBrowser: web view doesn't get the focus when new window is created
1185         https://bugs.webkit.org/show_bug.cgi?id=188546
1186
1187         Reviewed by Michael Catanzaro.
1188
1189         When a new window is created, the first widget of the windo is getting the focus, the toolbar in this case. We
1190         always want the WebView to grab the focus. In case of new empty tab, we want to the URL bar to be focused
1191         instead. This was causing failures in WebDriver tests that create a popup window with an input element that is
1192         filled with send keys command. The input element is marked as focused in the DOM, but the actual focused widget
1193         is the toolbar, so key events are sent to the toolbar instead of the web view.
1194
1195         * MiniBrowser/gtk/BrowserWindow.c:
1196         (webViewCreate):
1197         (newTabCallback):
1198         (openPrivateWindow):
1199         (browser_window_get_or_create_web_view_for_automation):
1200
1201 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Unreviewed. Fix WebDriver tests after r234839.
1204
1205         New pytest requires to autoinstall attrs too.
1206
1207         * Scripts/webkitpy/thirdparty/__init__.py:
1208         (AutoinstallImportHook._install_pytest):
1209
1210 2018-08-15  Ansh Shukla  <ansh_shukla@apple.com>
1211
1212         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
1213         https://bugs.webkit.org/show_bug.cgi?id=186870
1214         <rdar://problem/41314410>
1215
1216         Reviewed by Alex Christensen.
1217
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::toString):
1220         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
1221         (WTR::TestController::didReceiveAuthenticationChallenge):
1222
1223 2018-08-15  Ben Richards  <benton_richards@apple.com>
1224
1225         We should cache the compiled sandbox profile in a data vault
1226         https://bugs.webkit.org/show_bug.cgi?id=184991
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         Added trace points for sandbox initialization
1231
1232         * Tracing/SystemTracePoints.plist:
1233
1234 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
1235
1236         Unreviewed, rolling out r234870.
1237
1238         The test introduced with this change is a flaky failure.
1239
1240         Reverted changeset:
1241
1242         "NSURLAuthenticationMethodOAuth challenges are surfaced to
1243         clients in -didReceiveAuthenticationChallenge as
1244         NSURLAuthenticationMethodDefault"
1245         https://bugs.webkit.org/show_bug.cgi?id=186870
1246         https://trac.webkit.org/changeset/234870
1247
1248 2018-08-15  Jonathan Bedard  <jbedard@apple.com>
1249
1250         WebKitTestRunner should support watch devices
1251         https://bugs.webkit.org/show_bug.cgi?id=188570
1252
1253         Reviewed by Alex Christensen.
1254
1255         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1256
1257 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1258
1259         [Attachment SPI] Remove attachment display mode options
1260         https://bugs.webkit.org/show_bug.cgi?id=188596
1261
1262         Reviewed by Dan Bernstein.
1263
1264         Remove API tests and API test helpers for verifying the behavior of in-place media attachment elements.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1267         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
1268         (TestWebKitAPI::TEST):
1269         (testVideoData): Deleted.
1270         (displayOptionsWithMode): Deleted.
1271         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]): Deleted.
1272
1273 2018-08-14  Devin Rousso  <drousso@apple.com>
1274
1275         Unreviewed, change my emails.
1276
1277         * Scripts/webkitpy/common/config/contributors.json:
1278         * Scripts/webkitpy/common/config/watchlist:
1279
1280 2018-08-14  Saam barati  <sbarati@apple.com>
1281
1282         HashMap<Ref<P>, V> asserts when V is not zero for its empty value
1283         https://bugs.webkit.org/show_bug.cgi?id=188582
1284
1285         Reviewed by Sam Weinig.
1286
1287         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1288         (TestWebKitAPI::TEST):
1289
1290 2018-08-14  Zalan Bujtas  <zalan@apple.com>
1291
1292         [LFC][Floating] Add support for negative clearance.
1293         https://bugs.webkit.org/show_bug.cgi?id=188555
1294
1295         Reviewed by Simon Fraser.
1296
1297         * LayoutReloaded/misc/LFC-passing-tests.txt:
1298
1299 2018-08-14 Sihui Liu <sihui_liu@apple.com>
1300
1301         Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
1302         https://bugs.webkit.org/show_bug.cgi?id=188576
1303         <rdar://problem/43148977>
1304
1305         Reviewed by Alex Christensen.
1306
1307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1308         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Added.
1309         (TEST):
1310
1311 2018-08-14  Alex Christensen  <achristensen@webkit.org>
1312
1313         isValidCSSSelector is unsafe to be called from a non-main thread
1314         https://bugs.webkit.org/show_bug.cgi?id=188581
1315         <rdar://problem/40517358>
1316
1317         Reviewed by Sam Weinig.
1318
1319         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1320         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1321         (TestWebKitAPI::checkCompilerError):
1322
1323 2018-08-14  Ansh Shukla  <ansh_shukla@apple.com>
1324
1325         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
1326         https://bugs.webkit.org/show_bug.cgi?id=186870
1327         <rdar://problem/41314410>
1328
1329         Reviewed by Alex Christensen.
1330
1331         * WebKitTestRunner/TestController.cpp:
1332         (WTR::toString):
1333         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
1334         (WTR::TestController::didReceiveAuthenticationChallenge):
1335
1336 2018-08-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1337
1338         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
1339         https://bugs.webkit.org/show_bug.cgi?id=187973
1340
1341         Reviewed by Alex Christensen.
1342
1343         In LayoutTests, test names have been canonicalized in Unix style
1344         since Bug 63597, for example 'fast/css/001.html'. But Bug 179219,
1345         Bug 179572, Bug 180660, and Bug 181814 have changed to use
1346         os.path.seq instead of slash if Windows Python is used.
1347
1348         Revert parts of those changes. Change relative_test_filename to
1349         return a slash-separated test name as chromium_win.py used to do.
1350
1351         This change fixes all 41 test-webkitpy failures in WinCairo port.
1352
1353         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1354         (TestExpectationParser._parse_line): Do not convert test names with normpath.
1355         * Scripts/webkitpy/port/base.py:
1356         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
1357         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
1358         (Port.abspath_for_test): Replace self.TEST_PATH_SEPARATOR with self.host.filesystem.sep.
1359         * Scripts/webkitpy/port/driver.py:
1360         (Driver): Use '/' instead of os.sep.
1361         * Scripts/webkitpy/port/win.py:
1362         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
1363
1364 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
1365
1366         [ews-build] Add build step to run WK1 layout-test
1367         https://bugs.webkit.org/show_bug.cgi?id=188498
1368
1369         Reviewed by Lucas Forschler.
1370
1371         * BuildSlaveSupport/ews-build/steps.py:
1372         (RunWebKit1Tests): Class to run WebKit1Tests.
1373         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1374
1375 2018-08-14  Patrick Griffis  <pgriffis@igalia.com>
1376
1377         [Flatpak] Fix --cmakeargs
1378         https://bugs.webkit.org/show_bug.cgi?id=188567
1379
1380         Reviewed by Michael Catanzaro.
1381
1382         * flatpak/flatpakutils.py:
1383         (WebkitFlatpak.setup_dev_env):
1384
1385 2018-08-14  Darshan Kadu  <dkadu@igalia.com>
1386
1387         Enhancement request: Make export-w3c-test-changes add the PR to "See Also" links
1388         https://bugs.webkit.org/show_bug.cgi?id=186140
1389
1390         Reviewed by Youenn Fablet.
1391
1392         Added an optional parameter see_also to post_comment_to_bug function and used it for adding see_also variable's content in "See Also"
1393         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1394         (Bugzilla.post_comment_to_bug):
1395         Modified mock for see_also parameter
1396         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1397         (MockBugzilla.post_comment_to_bug):
1398         Made following unit tests to have see_also in bug comment
1399         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1400         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1401         (SheriffTest.test_post_blame_comment_on_bug):
1402         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1403         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1404         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1405         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1406         * Scripts/webkitpy/w3c/test_exporter.py:
1407         (WebPlatformTestExporter.make_pull_request):
1408         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1409         (TestExporterTest.MockBugzilla.post_comment_to_bug):
1410         (TestExporterTest.test_export):
1411
1412 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
1413
1414         [ews-build] Add support for max_builds parameter for workers
1415         https://bugs.webkit.org/show_bug.cgi?id=188531
1416
1417         Reviewed by Lucas Forschler.
1418
1419         * BuildSlaveSupport/ews-build/loadConfig.py:
1420         (loadBuilderConfig): Added support for max_builds.
1421
1422 2018-08-14  Zalan Bujtas  <zalan@apple.com>
1423
1424         [LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
1425         https://bugs.webkit.org/show_bug.cgi?id=188543
1426
1427         Reviewed by Antti Koivisto.
1428
1429         * LayoutReloaded/misc/LFC-passing-tests.txt:
1430
1431 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1432
1433         Unreviewed. Fix WebDriver tests after r234839.
1434
1435         New pytest requires to autoinstall more_itertools and six too.
1436
1437         * Scripts/webkitpy/thirdparty/__init__.py:
1438         (AutoinstallImportHook._install_pytest):
1439
1440 2018-08-14  Tomas Popela  <tpopela@redhat.com>
1441
1442         [GTK] Minibrowser: Add labels for buttons
1443         https://bugs.webkit.org/show_bug.cgi?id=188549
1444
1445         Reviewed by Carlos Garcia Campos.
1446
1447         So they are accessible easier (i.e. while testing WebKitGTK+ through Minibrowser in Dogtail).
1448
1449         * MiniBrowser/gtk/BrowserWindow.c:
1450         (webViewIsLoadingChanged):
1451         (browserWindowSetupEditorToolbar):
1452         (browser_window_init):
1453
1454 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1455
1456         Unreviewed. Fix WebDriver tests after r234839.
1457
1458         New pytest requires to autoinstall atomicwrites too.
1459
1460         * Scripts/webkitpy/thirdparty/__init__.py:
1461         (AutoinstallImportHook._install_pytest):
1462
1463 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1464
1465         Unreviewed. Fix WebDriver tests after r234839.
1466
1467         New pytest requires to autoinstall pluggy and funcsigs too.
1468
1469         * Scripts/webkitpy/thirdparty/__init__.py:
1470         (AutoinstallImportHook._install_pytest):
1471
1472 2018-08-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1473
1474         Unreviewed. Update W3C WebDriver imported tests.
1475
1476         Bump pytest version to 3.6.2.
1477
1478         * Scripts/webkitpy/thirdparty/__init__.py:
1479         (AutoinstallImportHook._install_pytest):
1480
1481 2018-08-13  Thomas Denney  <tdenney@apple.com>
1482
1483         Allow the substring 'me' in contributor names and email addresses
1484         https://bugs.webkit.org/show_bug.cgi?id=188538
1485
1486         Reviewed by Tim Horton.
1487
1488         A test didn't permit the string "me" in email addresses or names of contributors.
1489
1490         * Scripts/webkitpy/common/config/committers_unittest.py:
1491         (CommittersTest.test_contributors_by_fuzzy_match):
1492
1493 2018-08-13  Commit Queue  <commit-queue@webkit.org>
1494
1495         Unreviewed, rolling out r234812.
1496         https://bugs.webkit.org/show_bug.cgi?id=188536
1497
1498         broke the build (Requested by ThomasDenney on #webkit).
1499
1500         Reverted changeset:
1501
1502         "Added Thomas Denney to contributors.json."
1503         https://bugs.webkit.org/show_bug.cgi?id=188525
1504         https://trac.webkit.org/changeset/234812
1505
1506 2018-08-13  Sihui Liu  <sihui_liu@apple.com>
1507
1508         Avoid timeout resulted from calling waitUntilDone when test is not running
1509         https://bugs.webkit.org/show_bug.cgi?id=188389
1510
1511         Reviewed by Chris Dumez.
1512
1513         If test is not running, we should not set the waitUntilDone flag, or it may cause subsequent tests timeout.
1514
1515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1516         (WTR::TestRunner::waitUntilDone):
1517
1518 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1519
1520         [WK2] [macOS] Implement a mechanism to test drag and drop
1521         https://bugs.webkit.org/show_bug.cgi?id=181898
1522         <rdar://problem/39181698>
1523
1524         Reviewed by Simon Fraser.
1525
1526         Implements the currently stubbed DragAndDropSimulator on macOS, and introduces a new API test for r227266. See
1527         comments below for more detail.
1528
1529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1530         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
1531
1532         Introduce a file for cross-platform drag and drop tests, currently for iOS and macOS. Additionally add a test
1533         for r227266, which was fixed earlier this year but could not be tested due to a lack of testing mechanism on
1534         macOS in WebKit2.
1535
1536         (TEST):
1537         * TestWebKitAPI/Tests/WebKitCocoa/full-page-dropzone.html: Added.
1538
1539         Minor tweaks to this test page to add "dragover" and "drop" event handlers.
1540
1541         * TestWebKitAPI/Tests/WebKitCocoa/image-in-link-and-input.html:
1542         * TestWebKitAPI/Tests/WebKitCocoa/link-in-iframe-and-input.html: Added.
1543
1544         Add a new test page that includes a link embedded within an iframe below a plain text input.
1545
1546         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm: Added.
1547         (TEST):
1548         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm.
1549
1550         Move only existing WebKit2 macOS drag and drop test (DragAndDropPasteboardTests.NumberOfValidItemsForDrop) out
1551         of DragAndDropPasteboardTests.mm and into a new file, DragAndDropTestsMac.mm. Additionally, rename
1552         DragAndDropPasteboardTests to LegacyDragAndDropTests, since it now only contains two legacy WebView tests for
1553         drag and drop.
1554
1555         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1556         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1557         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1558         (-[DragSource draggingSourceOperationMaskForLocal:]):
1559         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1560         (-[DragInfo lastMousePosition]):
1561         (-[DragInfo setLastMousePosition:]):
1562         (-[DragInfo draggingDestinationWindow]):
1563         (-[DragInfo draggingSourceOperationMask]):
1564         (-[DragInfo draggingLocation]):
1565         (-[DragInfo draggedImageLocation]):
1566         (-[DragInfo draggedImage]):
1567         (-[DragInfo draggingPasteboard]):
1568         (-[DragInfo draggingSource]):
1569         (-[DragInfo draggingSequenceNumber]):
1570         (-[DragInfo slideDraggedImageTo:]):
1571         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1572         (-[DragInfo draggingFormation]):
1573         (-[DragInfo setDraggingFormation:]):
1574         (-[DragInfo animatesToDestination]):
1575         (-[DragInfo setAnimatesToDestination:]):
1576         (-[DragInfo numberOfValidItemsForDrop]):
1577         (-[DragInfo setNumberOfValidItemsForDrop:]):
1578         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1579         (-[DragInfo springLoadingHighlight]):
1580         (-[DragInfo resetSpringLoading]):
1581         (TestWebKitAPI::getTestImage):
1582         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1583         (TestWebKitAPI::TEST):
1584         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Removed.
1585         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1586
1587         Flesh out some of the DragAndDropSimulator API for macOS, exposing (among other things) the drag pasteboard,
1588         the current NSDraggingInfo, the initial location of the drag image, and the drag image itself.
1589
1590         * TestWebKitAPI/cocoa/TestWKWebView.h:
1591         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1592         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1593         (-[TestWKWebView mouseUpAtPoint:]):
1594         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
1595         (-[TestWKWebView sendClicksAtPoint:numberOfClicks:]):
1596         (-[TestWKWebView mouseEnterAtPoint:]):
1597         (-[TestWKWebView mouseExitAtPoint:]):
1598         (-[TestWKWebView mouseDragToPoint:]):
1599         (-[TestWKWebView _mouseEventWithType:atLocation:]):
1600         (-[TestWKWebView _mouseEventWithType:atLocation:flags:timestamp:clickCount:]):
1601
1602         Add TestWKWebView helpers to send MouseMove, MouseEnter and MouseDrag NSEvents to the web view. Additionally,
1603         rename parameter names to these helpers to make it more obvious that these locations are all in NSWindow
1604         coordinates.
1605
1606         (-[TestWKWebView typeCharacter:]):
1607
1608         Drive-by style fix: put this opening brace on the beginning of the next line.
1609
1610         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1611         (-[DragAndDropSimulator initWithWebViewFrame:]):
1612         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1613         (-[DragAndDropSimulator webView]):
1614
1615         Small iOS DragAndDropSimulator adjustments for new DragAndDropSimulator interfaces.
1616
1617         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1618         (-[DragAndDropTestWKWebView initWithFrame:configuration:simulator:]):
1619
1620         Introduce a WKWebView subclass for testing drag and drop that overrides `-dragImage:at:offset:…`, and instead
1621         allows DragAndDropSimulator to take over the drag.
1622
1623         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1624
1625         Override this entry point into drag and drop code, and instead call out to the DragAndDropSimulator to
1626         coordinate the drag.
1627
1628         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]):
1629
1630         Helper method to wait for the web process to finish handling all in-flight mouse events.
1631
1632         (defaultExternalDragImage):
1633
1634         Set this image as the default drag image when simulating an incoming drag session from outside of the web view.
1635
1636         (-[DragAndDropSimulator initWithWebViewFrame:]):
1637         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1638         (-[DragAndDropSimulator flipAboutXAxisInHostWindow:]):
1639
1640         Helper method to flip a given point about the X axis of the window.
1641
1642         (-[DragAndDropSimulator locationInViewForCurrentProgress]):
1643
1644         Map a progress value (between 0 and 1) to a drag location.
1645
1646         (-[DragAndDropSimulator initialProgressForMouseDrag]):
1647
1648         Determines the initial progress value when initiation a drag in web content. This is the initial progress
1649         required to ensure that the first mouse drag event exceeds the drag distance hysteresis and causes any drag
1650         (if applicable) to begin.
1651
1652         (-[DragAndDropSimulator runFrom:to:]):
1653         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
1654
1655         Helper to coordinate drag updates in both the cases where we're simulating a drag session entering from outside
1656         of the web view, and in the case where we've initiated a drag from the web view itself.
1657
1658         (-[DragAndDropSimulator webView]):
1659         (-[DragAndDropSimulator setExternalDragPasteboard:]):
1660         (-[DragAndDropSimulator externalDragPasteboard]):
1661
1662         Just like its iOS counterpart (setExternalItemProviders:), setting an external drag pasteboard on macOS puts the
1663         DragAndDropSimulator in a mode that simulates a drag coming in from outside the web view, using the given
1664         pasteboard.
1665
1666         (-[DragAndDropSimulator setExternalDragImage:]):
1667         (-[DragAndDropSimulator externalDragImage]):
1668
1669         May be optionally set when specifying an external drag pasteboard to specify the drag image used. If no external
1670         drag image is specified, falls back to the default image returned by `defaultExternalDragImage()`.
1671
1672         (-[DragAndDropSimulator draggingInfo]):
1673         (-[DragAndDropSimulator willEndDraggingHandler]):
1674         (-[DragAndDropSimulator setWillEndDraggingHandler:]):
1675
1676         Hook to allow tests to run logic right before performing the drop (if the current drag operation is not none) or
1677         ending the drag session without performing a drag operation.
1678
1679         (-[DragAndDropSimulator initWithWebView:]): Deleted.
1680         (-[DragAndDropSimulator dealloc]): Deleted.
1681         (-[DragAndDropSimulator phase]): Deleted.
1682         * TestWebKitAPI/mac/TestDraggingInfo.h: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
1683         * TestWebKitAPI/mac/TestDraggingInfo.mm: Added.
1684
1685         Mock object conforming to NSDraggingInfo that is passed to WKWebView when invoking -draggingUpdated:,
1686         -draggingEntered: and -draggingExited:.
1687
1688         (-[TestDraggingInfo draggingPasteboard]):
1689         (-[TestDraggingInfo setDraggingPasteboard:]):
1690         (-[TestDraggingInfo draggingSource]):
1691         (-[TestDraggingInfo setDraggingSource:]):
1692         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1693         (-[TestDraggingInfo draggingDestinationWindow]):
1694         (-[TestDraggingInfo draggedImage]):
1695         (-[TestDraggingInfo setDraggedImage:]):
1696         (-[TestDraggingInfo slideDraggedImageTo:]):
1697         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
1698         (-[TestDraggingInfo resetSpringLoading]):
1699
1700         Empty method stubs, to be implemented in the future as needed.
1701
1702 2018-08-13  Thomas Denney  <tdenney@apple.com>
1703
1704         Added Thomas Denney to contributors.json.
1705         https://bugs.webkit.org/show_bug.cgi?id=188525
1706
1707         Reviewed by Myles C. Maxfield.
1708
1709         * Scripts/webkitpy/common/config/contributors.json:
1710
1711 2018-08-13  Antti Koivisto  <antti@apple.com>
1712
1713         Meaning of OptionSet::contains is unclear when used with OptionSet argument
1714         https://bugs.webkit.org/show_bug.cgi?id=188501
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1719         (TestWebKitAPI::TEST):
1720
1721 2018-08-13  Commit Queue  <commit-queue@webkit.org>
1722
1723         Unreviewed, rolling out r234747.
1724         https://bugs.webkit.org/show_bug.cgi?id=188524
1725
1726         plugin processes crash on launch (Requested by smfr on
1727         #webkit).
1728
1729         Reverted changeset:
1730
1731         "We should cache the compiled sandbox profile in a data vault"
1732         https://bugs.webkit.org/show_bug.cgi?id=184991
1733         https://trac.webkit.org/changeset/234747
1734
1735 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1736
1737         [iOS] Dragging a non-editable text selection into a plain text input inserts HTML markup
1738         https://bugs.webkit.org/show_bug.cgi?id=188485
1739         <rdar://problem/43168784>
1740
1741         Reviewed by Tim Horton.
1742
1743         Add a new API test to verify that dropping selected non-editable rich text into a textarea inserts text as
1744         expected, rather than markup.
1745
1746         It's somewhat interesting to note that this particular use case isn't exercised by any existing tests; the
1747         closest test is DragAndDropTests.ContentEditableToTextarea, which drags a rich text selection from a
1748         contenteditable element to a text area. However, due to logic in `DragController::concludeEditDrag` that handles
1749         drag and drop across editable content differently than drag and drop from non-editable to editable content, the
1750         bug that is fixed here doesn't surface in that existing test.
1751
1752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1753         * TestWebKitAPI/Tests/WebKitCocoa/selected-text-and-textarea.html: Added.
1754         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1755         (TestWebKitAPI::TEST):
1756
1757 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1758
1759         Use a 1-byte enum class for TextDirection
1760         https://bugs.webkit.org/show_bug.cgi?id=188350
1761
1762         Reviewed by Simon Fraser.
1763
1764         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1765         (TestWebKitAPI::TEST_F):
1766         * TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:
1767         (WebCore::operator<<):
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1770         (TEST_F):
1771
1772 2018-08-13  Zalan Bujtas  <zalan@apple.com>
1773
1774         [LFC][Floating] Add basic clearance support
1775         https://bugs.webkit.org/show_bug.cgi?id=188492
1776
1777         Reviewed by Antti Koivisto.
1778
1779         * LayoutReloaded/misc/LFC-passing-tests.txt:
1780
1781 2018-08-12  Zalan Bujtas  <zalan@apple.com>
1782
1783         [LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
1784         https://bugs.webkit.org/show_bug.cgi?id=188487
1785
1786         Reviewed by Antti Koivisto.
1787
1788         * LayoutReloaded/misc/LFC-passing-tests.txt:
1789
1790 2018-08-11  Aakash Jain  <aakash_jain@apple.com>
1791
1792         [ews-build] Separate queues for Builders and Testers - iOS
1793         https://bugs.webkit.org/show_bug.cgi?id=188396
1794
1795         Reviewed by Lucas Forschler.
1796
1797         * BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
1798         Also added ews121 and ews122 to match with current EWS configuration.
1799         * BuildSlaveSupport/ews-build/factories.py:
1800         (TestsFactory): Base classes for various Test factories.
1801         (TestsFactory.getProduct): Download and extract the archive.
1802
1803 2018-08-10  Daniel Bates  <dabates@apple.com>
1804
1805         webkit-patch setup-git-clone should set Git core editor to commit-log-editor
1806         https://bugs.webkit.org/show_bug.cgi?id=188473
1807
1808         Reviewed by Ryosuke Niwa.
1809
1810         Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
1811         so that the Git commit message is generated from the ChangeLog for developers that manually
1812         generate their ChangeLog using prepare-ChangeLog.
1813
1814         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1815         (SetupGitClone.execute):
1816
1817 2018-08-10  Truitt Savell  <tsavell@apple.com>
1818
1819         Unreviewed, rolling out r234749.
1820
1821         Caused all perf tests to fail in Sierra
1822
1823         Reverted changeset:
1824
1825         "[webkitpy][Win] LayoutTests: test names should be Unix style,
1826         separated by slash not backslash"
1827         https://bugs.webkit.org/show_bug.cgi?id=187973
1828         https://trac.webkit.org/changeset/234749
1829
1830 2018-08-10  David Fenton  <david_fenton@apple.com>
1831
1832         Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
1833         https://bugs.webkit.org/show_bug.cgi?id=188470.
1834
1835         Unreviewed test gardening, disabling the tests.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1838         (TEST_F):
1839
1840 2018-08-10  Joseph Pecoraro  <pecoraro@apple.com>
1841
1842         Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
1843         https://bugs.webkit.org/show_bug.cgi?id=188458
1844
1845         Reviewed by Alex Christensen.
1846
1847         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1848         (TestExpectationParser):
1849         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1850
1851 2018-08-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1852
1853         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
1854         https://bugs.webkit.org/show_bug.cgi?id=187973
1855
1856         Reviewed by Alex Christensen.
1857
1858         In LayoutTests, test names have been canonicalized in Unix style
1859         since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
1860         Bug 179572, Bug 180660 and Bug 181814 have changed to use
1861         os.path.seq instead of slash if Windows Python is used.
1862
1863         Revert parts of those changes. Change relative_test_filename to
1864         return a slash sperated test name as well as chromium_win.py used
1865         to do.
1866
1867         This change fixes all 41 test-webkitpy failures in WinCairo port.
1868
1869         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1870         (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
1871         * Scripts/webkitpy/port/base.py:
1872         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
1873         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
1874         (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
1875         * Scripts/webkitpy/port/driver.py:
1876         (Driver): Use '/' instead of os.sep.
1877         * Scripts/webkitpy/port/win.py:
1878         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
1879
1880 2018-08-09  Thomas Denney  <tdenney@apple.com>
1881
1882         [WHLSL] Add individual test durations to output
1883         https://bugs.webkit.org/show_bug.cgi?id=188448
1884
1885         Reviewed by Myles C. Maxfield.
1886
1887         * WebGPUShadingLanguageRI/Test.js: Add timing output.
1888
1889 2018-08-09  Ben Richards  <benton_richards@apple.com>
1890
1891         We should cache the compiled sandbox profile in a data vault
1892         https://bugs.webkit.org/show_bug.cgi?id=184991
1893
1894         Reviewed by Ryosuke Niwa.
1895
1896         Added trace points for sandbox initialization
1897
1898         * Tracing/SystemTracePoints.plist:
1899
1900 2018-08-09  Jer Noble  <jer.noble@apple.com>
1901
1902         Video playback is using more power
1903         https://bugs.webkit.org/show_bug.cgi?id=188452
1904         <rdar://problem/42298937>
1905
1906         Reviewed by Eric Carlson.
1907
1908         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1909         (PreferredAudioBufferSize::createView):
1910         (PreferredAudioBufferSize::preferredAudioBufferSize const):
1911         (TEST_F):
1912
1913 2018-08-09  Alex Christensen  <achristensen@webkit.org>
1914
1915         REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
1916         https://bugs.webkit.org/show_bug.cgi?id=188453
1917         <rdar://problem/43102553>
1918
1919         Reviewed by Chris Dumez
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1922         (TEST):
1923         (+[NullLookupContext sharedLookupContext]):
1924         (TestWebKitAPI::TEST): Deleted.
1925
1926 2018-08-09  Alex Christensen  <achristensen@webkit.org>
1927
1928         WKURLSchemeHandler crashes when sent errors with sync XHR
1929         https://bugs.webkit.org/show_bug.cgi?id=188358
1930
1931         Reviewed by Chris Dumez.
1932
1933         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1934         (-[SyncErrorScheme webView:startURLSchemeTask:]):
1935         (-[SyncErrorScheme webView:stopURLSchemeTask:]):
1936         (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1937
1938 2018-08-09  Per Arne Vollan  <pvollan@apple.com>
1939
1940         REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
1941         https://bugs.webkit.org/show_bug.cgi?id=188397
1942
1943         Reviewed by Tim Horton.
1944
1945         After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
1946         user defaults related to scrollbars in the UI process as we do in the WebProcess.
1947
1948         * WebKitTestRunner/mac/main.mm:
1949         (setDefaultsToConsistentValuesForTesting):
1950
1951 2018-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1952
1953         [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
1954         https://bugs.webkit.org/show_bug.cgi?id=188439
1955
1956         Reviewed by Andy Estes and Megan Gardner.
1957
1958         Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
1959         macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
1960         DragAndDropTests.
1961
1962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1963         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
1966         (testIconImage):
1967         (testZIPArchive):
1968         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1969         (-[TestWKWebView editorContainsImageElement]):
1970         (-[TestWKWebView editorValue]):
1971         (makeCGRectValue):
1972         (checkCGRectIsEqualToCGRectWithLogging):
1973         (checkSelectionRectsWithLogging):
1974         (checkRichTextTypePrecedesPlainTextType):
1975         (checkFirstTypeIsPresentAndSecondTypeIsMissing):
1976         (checkTypeIdentifierIsRegisteredAtIndex):
1977         (checkEstimatedSize):
1978         (checkSuggestedNameAndEstimatedSize):
1979         (checkStringArraysAreEqual):
1980         (checkDragCaretRectIsContainedInRect):
1981         (checkJSONWithLogging):
1982         (testIconImageData):
1983         (runTestWithTemporaryTextFile):
1984         (runTestWithTemporaryFolder):
1985         (TestWebKitAPI::TEST):
1986         (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
1987         (TestWebKitAPI::testDragAndDropOntoTargetElements):
1988         (TestWebKitAPI::testIconImageData):
1989         * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
1990         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
1991         (-[WKWebView dropInteractionDelegate]):
1992         (-[WKWebView dragInteractionDelegate]):
1993         (-[WKWebView dropInteraction]):
1994         (-[WKWebView dragInteraction]):
1995         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1996         (-[MockDragDropSession allowsMoveOperation]):
1997         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1998         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1999         (-[MockDragDropSession canLoadObjectsOfClass:]):
2000         (-[MockDragDropSession canLoadObjectsOfClasses:]):
2001         (-[MockDragDropSession items]):
2002         (-[MockDragDropSession setItems:]):
2003         (-[MockDragDropSession addItems:]):
2004         (-[MockDragDropSession locationInView:]):
2005         (-[MockDropSession initWithProviders:location:window:allowMove:]):
2006         (-[MockDropSession isLocal]):
2007         (-[MockDropSession progress]):
2008         (-[MockDropSession setProgressIndicatorStyle:]):
2009         (-[MockDropSession progressIndicatorStyle]):
2010         (-[MockDropSession operationMask]):
2011         (-[MockDropSession localDragSession]):
2012         (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
2013         (-[MockDropSession canCreateItemsOfClass:]):
2014         (-[MockDropSession loadObjectsOfClass:completion:]):
2015         (-[MockDragSession initWithWindow:allowMove:]):
2016         (-[MockDragSession localOperationMask]):
2017         (-[MockDragSession externalOperationMask]):
2018         (-[MockDragSession session]):
2019         (-[MockDragSession localContext]):
2020         (-[MockDragSession setLocalContext:]):
2021         (dragAndDropEventNames):
2022         (-[DragAndDropSimulatorApplication _cancelAllTouches]):
2023         (-[DragAndDropSimulator initWithWebView:]):
2024         (-[DragAndDropSimulator dealloc]):
2025         (-[DragAndDropSimulator _resetSimulatedState]):
2026         (-[DragAndDropSimulator observedEventNames]):
2027         (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
2028         (-[DragAndDropSimulator runFrom:to:]):
2029         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2030         (-[DragAndDropSimulator finalSelectionRects]):
2031         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2032         (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
2033         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2034         (-[DragAndDropSimulator _advanceProgress]):
2035         (-[DragAndDropSimulator _currentLocation]):
2036         (-[DragAndDropSimulator _scheduleAdvanceProgress]):
2037         (-[DragAndDropSimulator sourceItemProviders]):
2038         (-[DragAndDropSimulator externalItemProviders]):
2039         (-[DragAndDropSimulator setExternalItemProviders:]):
2040         (-[DragAndDropSimulator phase]):
2041         (-[DragAndDropSimulator liftPreviews]):
2042         (-[DragAndDropSimulator lastKnownDragCaretRect]):
2043         (-[DragAndDropSimulator waitForInputSession]):
2044         (-[DragAndDropSimulator insertedAttachments]):
2045         (-[DragAndDropSimulator removedAttachments]):
2046         (-[DragAndDropSimulator endDataTransfer]):
2047         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2048         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2049         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2050         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2051         (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
2052         (-[DragAndDropSimulator _webView:didInsertAttachment:]):
2053         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
2054         (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
2055         (-[DragAndDropSimulator _webView:didStartInputSession:]):
2056         * TestWebKitAPI/ios/UIKitSPI.h:
2057         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
2058         (-[DragAndDropSimulator initWithWebView:]):
2059         (-[DragAndDropSimulator dealloc]):
2060         (-[DragAndDropSimulator runFrom:to:]):
2061         (-[DragAndDropSimulator insertedAttachments]):
2062         (-[DragAndDropSimulator removedAttachments]):
2063
2064 2018-08-09  Sihui Liu  <sihui_liu@apple.com>
2065
2066         REGRESSION (r232083): WKWebView loses first-party cookies on iOS
2067         https://bugs.webkit.org/show_bug.cgi?id=188443
2068         <rdar://problem/42991584>
2069
2070         Reviewed by Chris Dumez.
2071
2072         Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2075
2076 2018-08-09  Ross Kirsling  <ross.kirsling@sony.com>
2077
2078         Unreviewed follow-up fix for r234720.
2079
2080         * Scripts/webkitpy/bindings/main.py:
2081         (BindingsTests.close_and_remove):
2082         (BindingsTests.main):
2083         Return to the original approach, since this seems to be the simplest cross-platform solution.
2084
2085 2018-08-09  Ali Juma  <ajuma@chromium.org>
2086
2087         Import WPTs for IntersectionObserver
2088         https://bugs.webkit.org/show_bug.cgi?id=188416
2089
2090         Reviewed by Simon Fraser.
2091
2092         Enable IntersectionObserver in DumpRenderTree. 
2093
2094         * DumpRenderTree/mac/DumpRenderTree.mm:
2095         (enableExperimentalFeatures):
2096         (setWebPreferencesForTestOptions):
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::TestController::resetPreferencesToConsistentValues):
2099
2100 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
2101
2102         run-bindings-tests is not Win32-compatible
2103         https://bugs.webkit.org/show_bug.cgi?id=188424
2104
2105         Reviewed by Fujii Hironori.
2106
2107         * Scripts/webkitpy/bindings/main.py:
2108         (BindingsTests.main):
2109         Stop leaking file descriptors.
2110         (See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
2111
2112 2018-08-08  Alex Christensen  <achristensen@webkit.org>
2113
2114         Fix possible null dereference in WebBackForwardList::restoreFromState
2115         https://bugs.webkit.org/show_bug.cgi?id=188418
2116         <rdar://problem/42531726>
2117
2118         Reviewed by Chris Dumez.
2119
2120         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2121         (TestWebKitAPI::TEST):
2122
2123 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
2124
2125         run-builtins-generator-tests does not correctly handle CRLFs from stderr
2126         https://bugs.webkit.org/show_bug.cgi?id=188392
2127
2128         Reviewed by Fujii Hironori.
2129
2130         Background:
2131         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
2132
2133         * Scripts/webkitpy/common/system/executive.py:
2134         (Executive.run_command):
2135         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
2136
2137 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
2138
2139         Unreviewed, add myself to committers list.
2140
2141         * Scripts/webkitpy/common/config/contributors.json:
2142
2143 2018-08-08  Commit Queue  <commit-queue@webkit.org>
2144
2145         Unreviewed, rolling out r234314, r234320, and r234321.
2146         https://bugs.webkit.org/show_bug.cgi?id=188414
2147
2148         Caused email sign in issue (Requested by ryanhaddad on
2149         #webkit).
2150
2151         Reverted changesets:
2152
2153         "Remove unused WKNavigationDelegatePrivate
2154         decidePolicyForNavigationAction SPI"
2155         https://bugs.webkit.org/show_bug.cgi?id=188077
2156         https://trac.webkit.org/changeset/234314
2157
2158         "Fix API tests after r234314"
2159         https://bugs.webkit.org/show_bug.cgi?id=188077
2160         https://trac.webkit.org/changeset/234320
2161
2162         "Fix API tests after r234314"
2163         https://bugs.webkit.org/show_bug.cgi?id=188077
2164         https://trac.webkit.org/changeset/234321
2165
2166 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2167
2168         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
2169         https://bugs.webkit.org/show_bug.cgi?id=188401
2170         <rdar://problem/32542300>
2171
2172         Reviewed by Ryosuke Niwa.
2173
2174         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
2175         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
2176         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
2177         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
2178         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
2179         skip over one of the steps in the layout test, resulting in a text diff failure.
2180
2181         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
2182         as a part of resetting test controller state, before moving on to the next layout test.
2183
2184         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2186         (-[TestRunnerWKWebView didStartFormControlInteraction]):
2187         (-[TestRunnerWKWebView didEndFormControlInteraction]):
2188
2189         Use these hooks to keep track of whether the previous test is presenting any form input UI.
2190
2191         (-[TestRunnerWKWebView isInteractingWithFormControl]):
2192         * WebKitTestRunner/ios/TestControllerIOS.mm:
2193         (WTR::handleKeyboardWillHideNotification):
2194         (WTR::handleKeyboardDidHideNotification):
2195         (WTR::TestController::platformInitialize):
2196         (WTR::TestController::platformDestroy):
2197
2198         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
2199         of when the keyboard dismissal animation ends.
2200
2201         (WTR::TestController::platformResetStateToConsistentValues):
2202
2203         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
2204         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
2205         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
2206
2207 2018-08-05  Darin Adler  <darin@apple.com>
2208
2209         [Cocoa] More tweaks and refactoring to prepare for ARC
2210         https://bugs.webkit.org/show_bug.cgi?id=188245
2211
2212         Reviewed by Dan Bernstein.
2213
2214         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
2215         CFTypeRef instead of void*.
2216
2217         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2218         (createCoreAnimationLayer): Use CFBridgingRetain.
2219
2220         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2221         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
2222         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
2223         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
2224         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
2225         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
2226         (AccessibilityUIElement::indexForTextMarker): Ditto.
2227         (AccessibilityUIElement::textMarkerForIndex): Ditto.
2228         (AccessibilityUIElement::isTextMarkerValid): Ditto.
2229         (AccessibilityUIElement::previousTextMarker): Ditto.
2230         (AccessibilityUIElement::nextTextMarker): Ditto.
2231         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2232         (createJSStringRef): Ditto.
2233         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2234         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2235         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
2236         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
2237         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
2238         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
2239         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
2240         (AccessibilityUIElement::textMarkerForPoint): Ditto.
2241         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
2242         (AccessibilityUIElement::startTextMarker): Ditto.
2243         (AccessibilityUIElement::endTextMarker): Ditto.
2244         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
2245         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
2246         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
2247         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
2248         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
2249         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
2250         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
2251         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
2252         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
2253         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
2254         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (resetWebPreferencesToConsistentValues): Use bridging cast.
2258         (dumpFramesAsText): Ditto.
2259         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
2260         CFArray functions to iterate the array.
2261         (dump): Use bridging cast.
2262         (runTest): Ditto.
2263
2264         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2265         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
2266         (toUTI): Return a RetainPtr<CFStringRef>.
2267         (-[LocalPasteboard types]): Use the above and bridging casts.
2268         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
2269         (-[LocalPasteboard setData:forType:]): Ditto.
2270         (-[LocalPasteboard dataForType:]): Ditto.
2271         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
2272         instead of CFPropertyList.
2273         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
2274         CFStringCreateExternalRepresentation.
2275
2276         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
2277         instead of an Objective-C object pointer type.
2278         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2279         (-[MockGeolocationProvider registerWebView:]): Update for above.
2280         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
2281         (-[MockGeolocationProvider timerFired]): Ditto.
2282
2283         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
2284         HashMap and HashSet instead of an Objective-C object pointer type.
2285         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2286         (-[MockWebNotificationProvider registerWebView:]): Update for above.
2287         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
2288         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
2289         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
2290         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
2291
2292         * DumpRenderTree/mac/ObjCPlugin.m:
2293         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
2294
2295         * DumpRenderTree/mac/TestRunnerMac.mm:
2296         (TestRunner::addDisallowedURL): Use bridging cast.
2297         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
2298         (TestRunner::clearApplicationCacheForOrigin): Ditto.
2299         (originsArrayToJS): Ditto.
2300         (TestRunner::copyDecodedHostName): Ditto.
2301         (TestRunner::copyEncodedHostName): Ditto.
2302         (TestRunner::queueLoad): Ditto.
2303         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
2304         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
2305         (TestRunner::setUserStyleSheetLocation): Ditto.
2306         (TestRunner::setValueForUser): Ditto.
2307         (TestRunner::overridePreference): Ditto.
2308         (TestRunner::execCommand): Ditto.
2309         (TestRunner::findString): Ditto.
2310         (TestRunner::isCommandEnabled): Ditto.
2311         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
2312         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
2313         (TestRunner::addUserScript): Ditto.
2314         (TestRunner::addUserStyleSheet): Ditto.
2315         (TestRunner::evaluateInWebInspector): Ditto.
2316         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2317         (TestRunner::authenticateSession): Ditto.
2318         (TestRunner::grantWebNotificationPermission): Ditto.
2319         (TestRunner::denyWebNotificationPermission): Ditto.
2320         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2321         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
2322
2323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2324         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
2325         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
2326         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
2327         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
2328         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
2329         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
2330         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
2331         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
2332         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
2333         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
2334         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
2335         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
2336         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
2337         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
2338         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
2339         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
2340         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
2341         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
2342         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
2343         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
2344         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
2345         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
2346         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
2347         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
2348
2349         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
2350         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
2351
2352         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
2353         so we can use the type and know it inherits from NSWindow.
2354
2355         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
2356         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
2357         class into a separate file.
2358         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
2359         instead of have a second copy of the implementation.
2360
2361         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
2362         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
2363         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
2364
2365         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
2366         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
2367         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
2368         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
2369         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
2370         instead of CFPropertyList.
2371         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
2372         CFStringCreateExternalRepresentation.
2373
2374         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
2375         WebKitTestRunnerWindow here so it can be included by files that need to know
2376         what the type is and that it inherits from NSWindow.
2377
2378         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
2379         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
2380         messier implementation.
2381
2382 2018-08-07  Alex Christensen  <achristensen@webkit.org>
2383
2384         Add a test for using SafeBrowsing
2385         https://bugs.webkit.org/show_bug.cgi?id=188290
2386
2387         Reviewed by Chris Dumez.
2388
2389         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
2390         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
2394         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
2395         (TestWebKitAPI::TEST):
2396
2397 2018-08-07  Lucas Forschler  <lforschler@apple.com>
2398
2399         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
2400         https://bugs.webkit.org/show_bug.cgi?id=188235
2401
2402         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
2403
2404         * Scripts/webkitpy/common/checkout/changelog.py: 
2405         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
2406         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
2407         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2408         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
2409         * Scripts/webkitpy/tool/commands/upload.py:
2410         (Upload): Teach the upload step how to add radar information when creating a new bug.
2411         * Scripts/webkitpy/tool/steps/__init__.py:
2412         * Scripts/webkitpy/tool/steps/addradar.py: Added.
2413         (AddRadar):
2414         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
2415         * Scripts/webkitpy/tool/steps/createbug.py:
2416         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
2417
2418 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2419
2420         Post-review feedback after r234614.
2421         https://bugs.webkit.org/show_bug.cgi?id=188322
2422         <rdar://problem/42455270>
2423
2424         Reviewed by Sam Weinig.
2425
2426         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
2427
2428         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2429         (rounded):
2430
2431 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
2432
2433         [MiniBrowser][Win] Allow selection of recent user agents
2434         https://bugs.webkit.org/show_bug.cgi?id=188371
2435
2436         Reviewed by Fujii Hironori.
2437
2438         Updates the user agent spoofing strings to the latest released
2439         versions and adds Microsoft Edge's user agent.
2440
2441         Moves the menu item selection to the common base class, BrowserWindow
2442         to support user agent spoofing in a WebKitLegacyBrowserWindow and
2443         WebKitBrowserWindow.
2444
2445         * MiniBrowser/win/BrowserWindow.cpp: Added.
2446         (BrowserWindow::setUserAgent):
2447         * MiniBrowser/win/BrowserWindow.h:
2448         * MiniBrowser/win/CMakeLists.txt:
2449         * MiniBrowser/win/MainWindow.cpp:
2450         (MainWindow::toggleMenuItem):
2451         * MiniBrowser/win/MiniBrowserLib.rc:
2452         * MiniBrowser/win/MiniBrowserLibResource.h:
2453         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2454         * MiniBrowser/win/WebKitBrowserWindow.h:
2455         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2456         (WebKitLegacyBrowserWindow::setUserAgent):
2457         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2458
2459 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2460
2461         Unreviewed, add a new address to my configuration
2462
2463         * Scripts/webkitpy/common/config/contributors.json:
2464
2465 2018-08-06  David Quesada  <david_quesada@apple.com>
2466
2467         webkitdirs.pm should default to iPhone SE for 64-bit testing
2468         https://bugs.webkit.org/show_bug.cgi?id=188361
2469
2470         Reviewed by Daniel Bates.
2471
2472         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
2473
2474         * Scripts/webkitdirs.pm:
2475         (findOrCreateSimulatorForIOSDevice):
2476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2477         (parse_args):
2478             Update the help text for --device-type to reflect the new default device.
2479
2480 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2481
2482         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
2483         https://bugs.webkit.org/show_bug.cgi?id=188322
2484         <rdar://problem/42455270>
2485
2486         Reviewed by Tim Horton.
2487
2488         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
2489         was not in content view coordinates, unlike the x, y, and height.
2490
2491         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2492         (rounded):
2493         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
2494         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
2495         (TestWebKitAPI::TEST):
2496
2497 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
2498
2499         Unreviewed, rolling out r234569.
2500
2501         Breaks internal builds.
2502
2503         Reverted changeset:
2504
2505         "We should cache the compiled sandbox profile in a data vault"
2506         https://bugs.webkit.org/show_bug.cgi?id=184991
2507         https://trac.webkit.org/changeset/234569
2508
2509 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2510
2511         [Win][DLLLauncher] Remove --highDPI switch
2512         https://bugs.webkit.org/show_bug.cgi?id=188255
2513
2514         Reviewed by Yusuke Suzuki.
2515
2516         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
2517         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
2518         became useless since the change. Remove the switch.
2519
2520         This change fixes the issue all dump render tree tests are failing
2521         in WinCairo port if high DPI display is connected.
2522
2523         * MiniBrowser/win/Common.cpp:
2524         (parseCommandLine): Removed `--highDPI` switch.
2525         * win/DLLLauncher/DLLLauncherMain.cpp:
2526         (wWinMain): Do not call SetProcessDPIAware.
2527         (shouldUseHighDPI): Deleted.
2528
2529 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2530
2531         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
2532         https://bugs.webkit.org/show_bug.cgi?id=188335
2533         <rdar://problem/32542437> and <rdar://problem/32542433>
2534
2535         Reviewed by Tim Horton.
2536
2537         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
2538         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
2539         LayoutTests ChangeLog for more detail.
2540
2541         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2542         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2543         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2544         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2545         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2546         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
2547         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2548         * TestRunnerShared/spi/UIKitTestSPI.h:
2549
2550         Remove an internal class declaration that is now unnecessary.
2551
2552         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2553         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2554         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
2555
2556 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2557
2558         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
2559         https://bugs.webkit.org/show_bug.cgi?id=188322
2560         <rdar://problem/42455270>
2561
2562         Reviewed by Tim Horton.
2563
2564         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
2565         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
2566         selection views are hidden, and when first responder status is restored, both caret and range selection views
2567         are made visible again.
2568
2569         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2570         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2571         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2572         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2573         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2574         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2575         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2576         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2577         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2578         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
2579         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
2580         (webViewWithAutofocusedInput):
2581
2582         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
2583         immediately loading a web page with an autofocusing text field.
2584
2585         (TestWebKitAPI::TEST):
2586         * TestWebKitAPI/cocoa/TestWKWebView.h:
2587         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2588         (-[TestWKWebView caretViewRectInContentCoordinates]):
2589         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
2590         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2591         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2592         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2593
2594 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2595
2596         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
2597         https://bugs.webkit.org/show_bug.cgi?id=188334
2598         <rdar://problem/40630074>
2599
2600         Reviewed by Tim Horton.
2601
2602         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
2603         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
2604         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
2605         it to a completion block, and invoke the completion block to signal that the previous HID event has been
2606         processed.
2607
2608         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
2609         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
2610         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
2611         callback ID because the buffer was clamped to 8 bytes.
2612
2613         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
2614         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
2615         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
2616         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
2617         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
2618         be thrown.
2619
2620         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
2621
2622         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2623         (+[HIDEventGenerator nextEventCallbackID]):
2624         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2625
2626         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
2627
2628 2018-08-03  Ben Richards  <benton_richards@apple.com>
2629
2630         We should cache the compiled sandbox profile in a data vault
2631         https://bugs.webkit.org/show_bug.cgi?id=184991
2632
2633         Reviewed by Ryosuke Niwa.
2634
2635         Added trace points for sandbox initialization
2636
2637         * Tracing/SystemTracePoints.plist:
2638
2639 2018-08-03  David Fenton  <david_fenton@apple.com>
2640
2641         Unreviewed, rolling out r234517.
2642
2643         Caused API test failures on iOS
2644
2645         Reverted changeset:
2646
2647         "[Cocoa] setCookie API fails to set session cookies for
2648         defaultDataStore if processPool created but not used"
2649         https://bugs.webkit.org/show_bug.cgi?id=188209
2650         https://trac.webkit.org/changeset/234517
2651
2652 2018-08-03  Ben Richards  <benton_richards@apple.com>
2653
2654         Add configuration for automatic process pre-warming
2655         https://bugs.webkit.org/show_bug.cgi?id=187108
2656
2657         Reviewed by Ryosuke Niwa.
2658
2659         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
2660
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
2663         (TEST):
2664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2665         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
2666         (TEST):
2667
2668 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-build] Add build step to Check Patch Relevance
2671         https://bugs.webkit.org/show_bug.cgi?id=188295
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-build/steps.py:
2676         (CheckPatchRelevance): Added step to check patch relevance.
2677         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
2678         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
2679         (CheckPatchRelevance._addToLog): Add the log message.
2680         (CheckPatchRelevance.start):
2681         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
2682
2683 2018-08-03  Jer Noble  <jer.noble@apple.com>
2684
2685         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
2686         media element is paused. Updating the test to reflect the new policy.
2687
2688         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2689         (TestWebKitAPI::TEST):
2690
2691 2018-08-03  Zalan Bujtas  <zalan@apple.com>
2692
2693         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
2694         https://bugs.webkit.org/show_bug.cgi?id=188306
2695
2696         Reviewed by Antti Koivisto.
2697
2698         * LayoutReloaded/misc/LFC-passing-tests.txt:
2699
2700 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2701
2702         [WPE] Use the new key mapper API from WPEBackend
2703         https://bugs.webkit.org/show_bug.cgi?id=188216
2704
2705         Reviewed by Žan Doberšek.
2706
2707         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2708         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
2709         code.
2710         * wpe/backends/WindowViewBackend.cpp:
2711         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
2712         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
2713         (WPEToolingBackends::WindowViewBackend::modifiers const):
2714         * wpe/backends/WindowViewBackend.h:
2715
2716 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         [WPE] Implement MouseEvent.buttons
2719         https://bugs.webkit.org/show_bug.cgi?id=187998
2720
2721         Reviewed by Žan Doberšek.
2722
2723         Pass modifiers to mouse events.
2724
2725         * WebKitTestRunner/EventSenderProxy.h:
2726         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2727         (WTR::senderButtonToWPEButton):
2728         (WTR::modifierForButton):
2729         (WTR::EventSenderProxy::mouseDown):
2730         (WTR::EventSenderProxy::mouseUp):
2731         (WTR::EventSenderProxy::mouseMoveTo):
2732         (WTR::EventSenderProxy::mouseScrollBy):
2733         (WTR::wkEventModifiersToWPE):
2734         (WTR::wpeKeySymForKeyRef):
2735         (WTR::EventSenderProxy::keyDown):
2736         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2737         * wpe/backends/WindowViewBackend.cpp:
2738         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
2739         (WPEToolingBackends::WindowViewBackend::modifiers const):
2740         * wpe/backends/WindowViewBackend.h:
2741
2742 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2743
2744         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
2745         https://bugs.webkit.org/show_bug.cgi?id=188093
2746
2747         Reviewed by Žan Doberšek.
2748
2749         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
2750         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2751         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
2752         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
2753         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
2754         * wpe/backends/WindowViewBackend.cpp:
2755         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
2756         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
2757
2758 2018-08-02  Nan Wang  <n_wang@apple.com>
2759
2760         AX: [iOS] add support to return the attributed string under the element
2761         https://bugs.webkit.org/show_bug.cgi?id=188276
2762         <rdar://problem/42872357>
2763
2764         Reviewed by Chris Fleizach.
2765
2766         * DumpRenderTree/AccessibilityUIElement.cpp:
2767         (attributedStringForElementCallback):
2768         (AccessibilityUIElement::getJSClass):
2769         * DumpRenderTree/AccessibilityUIElement.h:
2770         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2771         (AccessibilityUIElement::attributedStringForElement):
2772         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2773         (WTR::AccessibilityUIElement::attributedStringForElement):
2774         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2775         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2776         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2777         (WTR::AccessibilityUIElement::attributedStringForElement):
2778
2779 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
2780
2781         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
2782         https://bugs.webkit.org/show_bug.cgi?id=175204
2783
2784         Unreviewed test gardening.
2785
2786         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2787
2788 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
2789
2790         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
2791         https://bugs.webkit.org/show_bug.cgi?id=188209
2792
2793         Reviewed by Geoffrey Garen.
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2796         (TEST):
2797
2798 2018-08-02  Dan Bernstein  <mitz@apple.com>
2799
2800         Fixed WebKit.AttrStyle timing out on build.webkit.org.
2801
2802         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
2803           access to one that doesn’t.
2804         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
2805         (TEST): Updated expected value.
2806
2807 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2808
2809         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
2810         https://bugs.webkit.org/show_bug.cgi?id=188251
2811         <rdar://problem/37842108>
2812
2813         Reviewed by Tim Horton.
2814
2815         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
2816         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
2817
2818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
2820         (TestWebKitAPI::TEST):
2821         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
2822
2823         Pull some logic used to force an input session to start out from an existing API test file
2824         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
2825         new keyboard input test.
2826
2827         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2828         (-[AutofillTestView initWithFrame:]):
2829         (TestWebKitAPI::TEST):
2830         (-[TestInputDelegate init]): Deleted.
2831         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
2832         * TestWebKitAPI/ios/UIKitSPI.h:
2833
2834         Add some UIKit SPI utilized by the new API test.
2835
2836 2018-08-01  Dan Bernstein  <mitz@apple.com>
2837
2838         Optionally expose Attr::style to JavaScript
2839         https://bugs.webkit.org/show_bug.cgi?id=188226
2840         <rdar://problem/42818113>
2841
2842         Reviewed by Darin Adler.
2843
2844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2845         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
2846         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
2847         (TEST):
2848
2849 2018-08-02  David Fenton  <david_fenton@apple.com>
2850
2851         Unreviewed, rolling out r234489.
2852
2853         Caused 50+ crashes and 60+ API failures on iOS
2854
2855         Reverted changeset:
2856
2857         "[WTF] Rename String::format to String::deprecatedFormat"
2858         https://bugs.webkit.org/show_bug.cgi?id=188191
2859         https://trac.webkit.org/changeset/234489
2860
2861 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
2862
2863         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
2864         https://bugs.webkit.org/show_bug.cgi?id=188244
2865
2866         Reviewed by Daniel Bates.
2867
2868         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
2869
2870         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
2871
2872 2018-08-01  Tomas Popela  <tpopela@redhat.com>
2873
2874         [WTF] Rename String::format to String::deprecatedFormat
2875         https://bugs.webkit.org/show_bug.cgi?id=188191
2876
2877         Reviewed by Darin Adler.
2878
2879         It should be replaced with string concatenation.
2880
2881         * DumpRenderTree/win/DumpRenderTree.cpp:
2882         (applicationId):
2883         (main):
2884         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2885         (TestWebKitAPI::Util::createURLForResource):
2886         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2887         (WTR::cacheTestRunnerCallback):
2888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2889         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2890         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2891         (WTR::AccessibilityUIElement::attributedStringForRange):
2892         (WTR::AccessibilityUIElement::url):
2893         (WTR::stringAtOffset):
2894         * WebKitTestRunner/TestController.cpp:
2895         (WTR::TestController::didReceiveAuthenticationChallenge):
2896         (WTR::TestController::downloadDidFail):
2897         (WTR::originUserVisibleName):
2898         (WTR::userMediaOriginHash):
2899         (WTR::TestController::didNavigateWithNavigationData):
2900         (WTR::TestController::didPerformClientRedirect):
2901         (WTR::TestController::didPerformServerRedirect):
2902         (WTR::TestController::didUpdateHistoryTitle):
2903
2904 2018-08-01  Nan Wang  <n_wang@apple.com>
2905
2906         AX: AOM: Add ARIA IDL Attribute Reflection
2907         https://bugs.webkit.org/show_bug.cgi?id=184676
2908         <rdar://problem/39476882>
2909
2910         Reviewed by Chris Fleizach.
2911
2912         * DumpRenderTree/mac/DumpRenderTree.mm:
2913         (enableExperimentalFeatures):
2914         * WebKitTestRunner/TestController.cpp:
2915         (WTR::TestController::resetPreferencesToConsistentValues):
2916
2917 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
2918
2919         Use iPhone SE as the default simulated device
2920         https://bugs.webkit.org/show_bug.cgi?id=188227
2921
2922         Reviewed by Aakash Jain.
2923
2924         * Scripts/webkitpy/port/ios_simulator.py:
2925         (IOSSimulatorPort):
2926
2927 2018-08-01  Commit Queue  <commit-queue@webkit.org>
2928
2929         Unreviewed, rolling out r234443 and r234445.
2930         https://bugs.webkit.org/show_bug.cgi?id=188224
2931
2932         Revision caused 3 api failures across all platforms.
2933         (Requested by Truitt on #webkit).
2934
2935         Reverted changesets:
2936
2937         "Add configuration for automatic process pre-warming"
2938         https://bugs.webkit.org/show_bug.cgi?id=187108
2939         https://trac.webkit.org/changeset/234443
2940
2941         "Add configuration for automatic process pre-warming"
2942         https://bugs.webkit.org/show_bug.cgi?id=187108
2943         https://trac.webkit.org/changeset/234445
2944
2945 2018-07-31  Ben Richards  <benton_richards@apple.com>
2946
2947         Add configuration for automatic process pre-warming
2948         https://bugs.webkit.org/show_bug.cgi?id=187108
2949
2950         Reviewed by Ryosuke Niwa.
2951
2952         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
2953
2954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2956         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
2957         (TEST):
2958
2959 2018-07-31  John Wilander  <wilander@apple.com>
2960
2961         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
2962         https://bugs.webkit.org/show_bug.cgi?id=188109
2963         <rdar://problem/42664391>
2964
2965         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
2966
2967         This patch removes cookie partitioning which reduces the model to just
2968         blocked cookies (in third-party contexts) and first-party cookie access.
2969
2970         Several of the changes are renaming to reflect that there are no more
2971         cookie partitions.
2972
2973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2974            Removed or renamed functions to reflect that there are no more
2975            partitioned cookies.
2976         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2977         (WTR::InjectedBundle::didReceiveMessageToPage):
2978         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2979         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2980         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
2981         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
2982         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
2983         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
2984         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
2985         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
2986         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
2987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2988         * WebKitTestRunner/TestController.cpp:
2989         (WTR::TestController::statisticsUpdateCookieBlocking):
2990         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
2991         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
2992         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
2993         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
2994         * WebKitTestRunner/TestController.h:
2995         * WebKitTestRunner/TestInvocation.cpp:
2996         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2997         (WTR::TestInvocation::didSetBlockCookiesForHost):
2998         (WTR::TestInvocation::didSetHasHadUserInteraction):
2999         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
3000         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
3001         * WebKitTestRunner/TestInvocation.h:
3002         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3003         (WTR::initializeWebViewConfiguration):
3004
3005 2018-07-31  Alex Christensen  <achristensen@webkit.org>
3006
3007         Build fix.  Remove unused variable.
3008
3009         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
3010         (TestWebKitAPI::TEST):
3011         transform was never used. It was introduced in r205871
3012         Apparently I'm the first one to build in a certain configuration that found it.
3013
3014 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3015
3016         server_process.py should print returncode in debug log if the process crashed
3017         https://bugs.webkit.org/show_bug.cgi?id=188160
3018
3019         Reviewed by Konstantin Tokarev.
3020
3021         * Scripts/webkitpy/port/server_process.py:
3022         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
3023
3024 2018-07-31  Tomas Popela  <tpopela@redhat.com>
3025
3026         [WTF] String::formatWithArguments() is unused
3027         https://bugs.webkit.org/show_bug.cgi?id=187955
3028
3029         Reviewed by Darin Adler.
3030
3031         Remove tests for WTF::String::formatWithArguments() as it's unused and
3032         we are removing it.
3033
3034         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3035
3036 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
3037
3038         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
3039
3040         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
3041         other builders.
3042
3043 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
3044
3045         [ews-build] Add support for API tests in OpenSource EWS
3046         https://bugs.webkit.org/show_bug.cgi?id=188156
3047
3048         Reviewed by Lucas Forschler.
3049
3050         * BuildSlaveSupport/ews-build/config.json:
3051         * BuildSlaveSupport/ews-build/factories.py:
3052         (BuildFactory.__init__): Added triggers parameter.
3053         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
3054         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
3055         (APITestsFactory): Factory for running API tests.
3056         * BuildSlaveSupport/ews-build/steps.py:
3057         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
3058         source of the property.
3059
3060 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
3061
3062         [ews-build] loadConfig should ensure that the triggers are valid
3063         https://bugs.webkit.org/show_bug.cgi?id=188134
3064
3065         Reviewed by Lucas Forschler.
3066
3067         * BuildSlaveSupport/ews-build/loadConfig.py:
3068         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
3069         (checkValidSchedulers): Ensures that the scheduler is not un-used.
3070         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3071
3072 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3073
3074         Unreviewed, fix typo in test expectations and mark another test as timing out
3075
3076         * TestWebKitAPI/glib/TestExpectations.json:
3077
3078 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3079
3080         More unreviewed GTK test gardening
3081
3082         * TestWebKitAPI/glib/TestExpectations.json:
3083
3084 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
3085
3086         Be more conservative with compositing layer creation when memory is low
3087         https://bugs.webkit.org/show_bug.cgi?id=187866
3088         rdar://problem/42366345
3089
3090         Reviewed by Zalan Bujtas.
3091         
3092         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
3093         compositing layers. We avoid compositing for these situations:
3094         1. Layers with 3D transforms which are affine (like translateZ(0)).
3095         2. Layers with will-change
3096         3. Layers for canvases (other than WebGL/WebGPU)
3097         
3098         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
3099         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
3100         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
3101         
3102         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
3103         flakily falling into a different mode, and so that we can impose the conservative
3104         mode for testing.
3105
3106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3107         (WTR::InjectedBundlePage::prepare):
3108
3109 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3110
3111         Unreviewed GTK test gardening
3112
3113         * TestWebKitAPI/glib/TestExpectations.json:
3114
3115 2018-07-27  Alex Christensen  <achristensen@webkit.org>
3116
3117         Fix API tests after r234314
3118         https://bugs.webkit.org/show_bug.cgi?id=188077
3119
3120         Make API tests use new delegate method.
3121
3122         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3123         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3124         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3125
3126 2018-07-27  Alex Christensen  <achristensen@webkit.org>
3127
3128         Fix API tests after r234314
3129         https://bugs.webkit.org/show_bug.cgi?id=188077
3130
3131         Make API tests use new delegate method.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3134         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3135         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3136         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3137         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3138         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3139         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3140         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3141         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3142         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3143         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3144
3145 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3146
3147         [INTL] Remove INTL sub-feature compile flags
3148         https://bugs.webkit.org/show_bug.cgi?id=188081
3149
3150         Reviewed by Michael Catanzaro.
3151
3152         * Scripts/webkitperl/FeatureList.pm:
3153         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3154
3155 2018-07-26  Chris Dumez  <cdumez@apple.com>
3156
3157         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
3158         https://bugs.webkit.org/show_bug.cgi?id=188078
3159         <rdar://problem/42562493>
3160
3161         Reviewed by Geoff Garen.
3162
3163         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
3164         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
3165
3166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3167         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
3168         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
3169         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
3170         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
3171         (TEST):
3172
3173 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
3174
3175         Add Aaron Chu as a committer to contributors.json
3176         https://bugs.webkit.org/show_bug.cgi?id=188066
3177
3178         Unreviwed. Added myself as committer.
3179
3180         * Scripts/webkitpy/common/config/contributors.json:
3181
3182 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
3183
3184         [ews-build] Add build step to run API Tests
3185         https://bugs.webkit.org/show_bug.cgi?id=188079
3186
3187         Reviewed by Lucas Forschler.
3188
3189         * BuildSlaveSupport/ews-build/steps.py:
3190         (TestWithFailureCount): Common class for various tests with failure count.
3191         (TestWithFailureCount.start): Configure Buildbot's logobserver.
3192         (TestWithFailureCount.commandComplete): Updates the failure count.
3193         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
3194         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
3195         (RunAPITests): Build step to run API tests.
3196         (RunAPITests.countFailures): Count the failures by parsing the output.
3197         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3198
3199 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
3200
3201         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
3202         https://bugs.webkit.org/show_bug.cgi?id=187963
3203
3204         Reviewed by Alex Christensen.
3205
3206         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3207         Add tests for String::split and String::splitAllowingEmptyEntries.
3208
3209         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::updateTestOptionsFromTestHeader):
3212         Update split/splitAllowingEmptyEntries usage.
3213
3214 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3215
3216         Unreviewed, rolling out r234181 and r234189.
3217         https://bugs.webkit.org/show_bug.cgi?id=188075
3218
3219         These are not needed right now (Requested by thorton on
3220         #webkit).
3221
3222         Reverted changesets:
3223
3224         "Enable Web Content Filtering on watchOS"
3225         https://bugs.webkit.org/show_bug.cgi?id=187979
3226         https://trac.webkit.org/changeset/234181
3227
3228         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3229         https://bugs.webkit.org/show_bug.cgi?id=187985
3230         https://trac.webkit.org/changeset/234189
3231
3232 2018-07-04  Darin Adler  <darin@apple.com>
3233
3234         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
3235         https://bugs.webkit.org/show_bug.cgi?id=187333
3236
3237         Reviewed by Sam Weinig.
3238
3239         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
3240         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
3241         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
3242         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
3243         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
3244
3245 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3246
3247         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
3248         https://bugs.webkit.org/show_bug.cgi?id=188031
3249
3250         Reviewed by Lucas Forschler.
3251
3252         * BuildSlaveSupport/ews-build/steps.py:
3253         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
3254         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
3255         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3256
3257 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3258
3259         [ews-build] Add build step UploadBuiltProduct
3260         https://bugs.webkit.org/show_bug.cgi?id=188016
3261
3262         Reviewed by Lucas Forschler.
3263
3264         * BuildSlaveSupport/ews-build/steps.py:
3265         (UploadBuiltProduct): Added build step UploadBuiltProduct.
3266         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
3267
3268 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3269
3270         [ews-build] Add build step ArchiveBuiltProduct
3271         https://bugs.webkit.org/show_bug.cgi?id=188014
3272
3273         Reviewed by Lucas Forschler.
3274
3275         * BuildSlaveSupport/ews-build/steps.py:
3276         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
3277         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3278
3279 2018-07-25  Chris Dumez  <cdumez@apple.com>
3280
3281         navigator.userAgent may return outdated value after webView.customUserAgent is set
3282         https://bugs.webkit.org/show_bug.cgi?id=188009
3283         <rdar://problem/42566456>
3284
3285         Reviewed by Alex Christensen.
3286
3287         Add API test coverage.
3288
3289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
3291         (TEST):
3292
3293 2018-07-25  Charlie Turner  <cturner@igalia.com>
3294
3295         [Flatpak] Pass more environment variables to sandbox
3296         https://bugs.webkit.org/show_bug.cgi?id=188002
3297
3298         Reviewed by Michael Catanzaro.
3299
3300         * flatpak/flatpakutils.py:
3301         (WebkitFlatpak.run_in_sandbox):
3302
3303 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
3304
3305         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
3306         https://bugs.webkit.org/show_bug.cgi?id=187997
3307
3308         Reviewed by Carlos Garcia Campos.
3309
3310         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
3311         the EGL-oriented API that simply serves EGLImageKHR objects instead of
3312         raw buffer resources. This allows us not to wrangle with creating and
3313         managing lifetime of the same EGLImageKHR by ourselves.
3314
3315         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
3316         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
3317         the exportable object. This means that for each frame we're served an
3318         EGLImageKHR object that is passed on to the displayBuffer()
3319         implementation.
3320
3321         HeadlessViewBackend now just manages the pending and committed image
3322         objects. Width and height values used during pixel data retrieval are
3323         gathered from the ViewBackend's size that was specified when
3324         constructed.
3325
3326         WindowViewBackend similarly only manages the committed image object,
3327         not having to create an equivalent EGLImageKHR object from the raw
3328         buffer resource anymore.
3329
3330         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
3331         classes are removed, and destructors for both classes are made virtual.
3332
3333         The WPEBackend-fdo version is bumped in order to have the EGL-specific
3334         export API available.
3335
3336         * flatpak/org.webkit.WPE.yaml:
3337         * wpe/backends/HeadlessViewBackend.cpp:
3338         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3339         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
3340         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3341         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
3342         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
3343         * wpe/backends/HeadlessViewBackend.h:
3344         * wpe/backends/ViewBackend.cpp:
3345         (WPEToolingBackends::ViewBackend::initialize):
3346         * wpe/backends/ViewBackend.h:
3347         * wpe/backends/WindowViewBackend.cpp:
3348         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3349         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
3350         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3351         * wpe/backends/WindowViewBackend.h:
3352         * wpe/jhbuild.modules:
3353
3354 2018-07-24  Thomas Denney  <tdenney@apple.com>
3355
3356         Remove support for the double type from WHLSL
3357         https://bugs.webkit.org/show_bug.cgi?id=187977
3358
3359         Reviewed by Myles C. Maxfield.
3360
3361         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3362         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
3363         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
3364         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
3365         * WebGPUShadingLanguageRI/Parse.js:
3366         (parseTerm): Removed parsing of double literals.
3367         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3368         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
3369         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
3370         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3371         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
3372         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3373
3374 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3375
3376         Enable Web Content Filtering on watchOS
3377         https://bugs.webkit.org/show_bug.cgi?id=187979
3378         <rdar://problem/42559346>
3379
3380         Reviewed by Wenson Hsieh.
3381
3382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3383
3384 2018-07-24  Daniel Bates  <dabates@apple.com>
3385
3386         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
3387         https://bugs.webkit.org/show_bug.cgi?id=187971
3388
3389         Reviewed by Saam Barati.
3390
3391         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
3392         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
3393         data type.
3394
3395         * TestWebKitAPI/CMakeLists.txt:
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
3398         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
3399         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
3400         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
3401         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
3402         (TestWebKitAPI::TEST):
3403         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
3404         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
3405         (TestWebKitAPI::TEST):
3406
3407 2018-07-24  Thomas Denney  <tdenney@apple.com>
3408         Minor changes to the WHLSL interpreter to support the new compiler
3409         https://bugs.webkit.org/show_bug.cgi?id=187728
3410
3411         Reviewed by Myles C. Maxfield.
3412
3413         This bug contains small changes that are make minor changes to the
3414         behaviour of the existing interpreter (the tests are unaffected and all
3415         still pass).
3416
3417         * WebGPUShadingLanguageRI/EnumType.js:
3418         (EnumType.prototype.get isEnum): Property added to EnumType and Type
3419         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
3420         * WebGPUShadingLanguageRI/Func.js:
3421         (Func.prototype.get isEntryPoint): Add boolean property
3422         * WebGPUShadingLanguageRI/FuncInstantiator.js:
3423         (FuncInstantiator.prototype.get instances): Public accessor for existing
3424         private field
3425         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
3426         that it directly wraps a Func instance (therefore the only interface
3427         change is to the constructor and the addition of the func accessor).
3428         This change allows the de-inlining of functions.
3429         (FunctionLikeBlock):
3430         (FunctionLikeBlock.prototype.get func):
3431         (FunctionLikeBlock.prototype.get returnType):
3432         (FunctionLikeBlock.prototype.get parameters):
3433         (FunctionLikeBlock.prototype.get body):
3434         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
3435         constructor
3436         (Inliner.prototype.visitCallExpression):
3437         (Inliner):
3438         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
3439         to native functions (with additional support in StandardLibrary.js).
3440         This reduces first-time compile-time from around 4s to around 0.1s.
3441         (Intrinsics):
3442         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
3443         comments completes correctly
3444         (Lexer.prototype.next):
3445         (Lexer):
3446         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
3447         property, which is based on the type of the lValue and the semantics of
3448         the language (the @ operator yields an array reference with the thread
3449         scope).
3450         (MakeArrayRefExpression):
3451         (MakeArrayRefExpression.prototype.get type):
3452         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
3453         implementationData to support swizzle operator change
3454         (NativeFunc.prototype.get implementationData):
3455         (NativeFunc.prototype.set implementationData):
3456         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
3457         constructor
3458         (Rewriter.prototype.visitFunctionLikeBlock):
3459         * WebGPUShadingLanguageRI/StandardLibrary.js:
3460         (_generateSwizzle): Deleted.
3461         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
3462         carrying metadata about swizzle operators so that they are implemented
3463         as native functions rather than generated at compile time.
3464         (SwizzleOp):
3465         (SwizzleOp.prototype.get outSize):
3466         (SwizzleOp.prototype.get components):
3467         (SwizzleOp.prototype.get inSize):
3468         (SwizzleOp.prototype.toString):
3469         (SwizzleOp.allSwizzleOperators.):
3470         (SwizzleOp.allSwizzleOperators):
3471         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
3472         (SwizzleOp.prototype.get outSize):
3473         (SwizzleOp.prototype.get components):
3474         (SwizzleOp.prototype.get inSize):
3475         (SwizzleOp.prototype.toString):
3476         (generateSwizzles):
3477         (_generateSwizzle): Deleted.
3478         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
3479         above.
3480         (Type.prototype.get isEnum):
3481
3482 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
3483
3484         Unreviewed, rolling out r234121.
3485
3486         Caused perf test failures.
3487
3488         Reverted changeset:
3489
3490         "We should cache the compiled sandbox profile in a data vault"
3491         https://bugs.webkit.org/show_bug.cgi?id=184991
3492         https://trac.webkit.org/changeset/234121
3493
3494 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
3495
3496         [Flatpak] Add openh264 as needed by WebRTC
3497         https://bugs.webkit.org/show_bug.cgi?id=187956
3498
3499         Reviewed by Philippe Normand.
3500
3501         * flatpak/org.webkit.WebKit.yaml:
3502
3503 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
3504
3505         WebCore::URL::hostIsIPAddress needs a Windows implementation
3506         https://bugs.webkit.org/show_bug.cgi?id=187859
3507
3508         Reviewed by Fujii Hironori.
3509
3510         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3511         Check for a few other ways an IP address could be invalid.
3512
3513 2018-07-24  Charlie Turner  <cturner@igalia.com>
3514
3515         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
3516         https://bugs.webkit.org/show_bug.cgi?id=187951
3517
3518         When running run-webkit-tests --wpe --debug, it was observed that
3519         both self.platform != 'wpe' and self.debug != True. This turned
3520         out to be because of the "args" argument consuming the remainder
3521         of future arguments that came after it. Since the first argument
3522         to load_from_args was the test script to run, it would end up
3523         never processing the other arguments supplied to the wrapper
3524         script.
3525
3526         Tested this by rebuilding GTK in debug mode, running the
3527         minibrowser with various extra options, and running some tests
3528         with various extra options.
3529
3530         Reviewed by Michael Catanzaro.
3531
3532         * flatpak/flatpakutils.py:
3533         (WebkitFlatpak.load_from_args):
3534
3535 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
3536
3537         [Flatpak] Remove now unnecessary 'hacks' for running tests
3538         https://bugs.webkit.org/show_bug.cgi?id=187608
3539
3540         Reviewed by Philippe Normand.
3541
3542         We used to need to not share X11 with the sandbox when running tests
3543         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
3544         sandbox (we mount it on `/run/host/tmp` now).
3545
3546         This has the advantage of making running the MiniBrowser to display test
3547         results working again.
3548
3549         * flatpak/flatpakutils.py:
3550         (WebkitFlatpak.clean_args):
3551         (WebkitFlatpak.run_in_sandbox):
3552         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
3553
3554 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
3555
3556         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
3557         https://bugs.webkit.org/show_bug.cgi?id=187581
3558
3559         Reviewed by Daniel Bates.
3560
3561         There are two failures in this test case:
3562         1. proc.poll() doesn't return 0.
3563         2. stderr is not output.
3564
3565         For failure #1, this is expected. the process should not exit at
3566         the time. proc.poll() should return None because the process is
3567         still alive.
3568
3569         This change added a new test to check proc.poll() becomes 0 after
3570         the process successfully exits.
3571
3572         For failure #2, stderr is not flushed even though stdout is
3573         flushed. This change uses '-u' command switch to force stdin,
3574         stdout and stderr to be totally unbuffered.
3575
3576         * Scripts/webkitpy/port/server_process_unittest.py:
3577         (TestServerProcess.test_basic): Added -u command switch. Do not
3578         flush stdout. Removed the special condition for Windows. Add a new
3579         test to check proc.poll() returns 0.
3580         (TestServerProcess.test_process_crashing): Added -u command
3581         switch. Do not flush stdout.
3582
3583 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
3584
3585         WTF::StringView::split should have an allowEmptyEntries flag
3586         https://bugs.webkit.org/show_bug.cgi?id=187864
3587
3588         Reviewed by Konstantin Tokarev.
3589
3590         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
3591
3592 2018-07-23  Ben Richards  <benton_richards@apple.com>
3593
3594         We should cache the compiled sandbox profile in a data vault
3595         https://bugs.webkit.org/show_bug.cgi?id=184991
3596
3597         Reviewed by Ryosuke Niwa.
3598
3599         Added trace points for sandbox initialization
3600
3601         * Tracing/SystemTracePoints.plist:
3602
3603 2018-07-23  Zalan Bujtas  <zalan@apple.com>
3604
3605         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
3606         https://bugs.webkit.org/show_bug.cgi?id=187924
3607         <rdar://problem/41745884>
3608
3609         Reviewed by Simon Fraser.
3610
3611         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
3612
3613         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3614         (createBitmapContextFromWebView):
3615
3616 2018-07-23  Chris Dumez  <cdumez@apple.com>
3617
3618         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
3619         https://bugs.webkit.org/show_bug.cgi?id=187910
3620         <rdar://problem/42356526>
3621
3622         Reviewed by Brent Fulgham.
3623
3624         Add API test coverage.
3625
3626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3627         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3628         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
3629         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
3630         (TEST):
3631         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
3632
3633 2018-07-23  Daniel Bates  <dabates@apple.com>
3634
3635         test-webkitpy should take configuration command line options
3636         https://bugs.webkit.org/show_bug.cgi?id=187872
3637
3638         Reviewed by David Kilzer.
3639
3640         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
3641         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
3642         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
3643
3644         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3645         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
3646         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
3647         * Scripts/webkitpy/test/main.py:
3648         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
3649         the specified configuration is None then we fall back to using the default configuration (as set
3650         by script set-webkit-configuration).
3651         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
3652         with a Debug configuration and a Release configuration, respectively
3653         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
3654         the command line options. It may be None if neither --debug nor --release were passed.
3655
3656 2018-07-23  Commit Queue  <commit-queue@webkit.org>
3657
3658         Unreviewed, rolling out r233030.
3659         https://bugs.webkit.org/show_bug.cgi?id=187904
3660
3661         Broke tarball builds (Requested by mcatanzaro on #webkit).
3662
3663         Reverted changeset:
3664
3665         "run-gtk-tests (glib/common.py) cannot determine build
3666         directory when webKitBranchBuild=true"
3667         https://bugs.webkit.org/show_bug.cgi?id=185643
3668         https://trac.webkit.org/changeset/233030
3669
3670 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
3671
3672         Fix lldb summarizers for HashMaps and HashSets
3673         https://bugs.webkit.org/show_bug.cgi?id=187883
3674
3675         Reviewed by Dan Bates.
3676         
3677         HashMap and HashSet summarizers were broken in various ways.
3678         
3679         The 'type summary add -x' regexp needs to match at the start and end of the string
3680         to avoid finding types nested inside other templates.
3681         
3682         The HashTable synthetic child code incorrectly used the type of the key, rather than
3683         the value when synthesizing children.
3684         
3685         Add HashMap and HashSet summarizers.
3686
3687         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
3688
3689         * lldb/lldbWebKitTester/main.cpp:
3690         (testSummaryProviders):
3691         * lldb/lldb_webkit.py:
3692         (__lldb_init_module):
3693         (__lldb_init_module.lldb_webkit):
3694         (WTFHashMap_SummaryProvider):
3695         (WTFHashSet_SummaryProvider):
3696         (WebCoreColorProvider._to_string_extended):
3697         (WebCoreURLProvider.to_string):
3698         (WTFHashMapProvider):
3699         (WTFHashMapProvider.__init__):
3700         (WTFHashMapProvider.tableSize):
3701         (WTFHashMapProvider.keyCount):
3702         (WTFHashSetProvider):
3703         (WTFHashSetProvider.__init__):
3704         (WTFHashSetProvider.tableSize):
3705         (WTFHashSetProvider.keyCount):
3706         (WTFHashTableProvider.tableSize):
3707         (WTFHashTableProvider):
3708         (WTFHashTableProvider.keyCount):
3709         (WTFHashTableProvider.get_child_at_index):
3710         (WTFHashTableProvider.update):
3711         * lldb/lldb_webkit_unittest.py:
3712         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3713         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3714         (TestSummaryProviders):
3715         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
3716         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
3717         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3718
3719 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
3720
3721         Add lldb formatters for WebCore geometry types
3722         https://bugs.webkit.org/show_bug.cgi?id=187884
3723
3724         Reviewed by Daniel Bates.
3725         
3726         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
3727         and LayoutRect.
3728         
3729         Testing is blocked by webkit.org/b/187872.
3730
3731         * lldb/lldbWebKitTester/main.cpp:
3732         (testSummaryProviders):
3733         * lldb/lldb_webkit.py:
3734         (__lldb_init_module.lldb_webkit):
3735         (__lldb_init_module):
3736         (WebCoreLayoutRect_SummaryProvider):
3737         (WebCoreIntSize_SummaryProvider):
3738         (WebCoreIntPoint_SummaryProvider):
3739         (WebCoreFloatSize_SummaryProvider):
3740         (WebCoreFloatPoint_SummaryProvider):
3741         (WebCoreIntRect_SummaryProvider):
3742         (WebCoreFloatRect_SummaryProvider):
3743         (WebCoreLayoutRectProvider):
3744         (WebCoreLayoutRectProvider.__init__):
3745         (WebCoreLayoutRectProvider.get_x):
3746         (WebCoreLayoutRectProvider.get_y):
3747         (WebCoreLayoutRectProvider.get_width):
3748         (WebCoreLayoutRectProvider.get_height):
3749         (WebCoreIntPointProvider):
3750         (WebCoreIntPointProvider.__init__):
3751         (WebCoreIntPointProvider.get_x):
3752         (WebCoreIntPointProvider.get_y):
3753         (WebCoreIntSizeProvider):
3754         (WebCoreIntSizeProvider.__init__):
3755         (WebCoreIntSizeProvider.get_width):
3756         (WebCoreIntSizeProvider.get_height):
3757         (WebCoreIntRectProvider):
3758         (WebCoreIntRectProvider.__init__):
3759         (WebCoreIntRectProvider.get_x):
3760         (WebCoreIntRectProvider.get_y):
3761         (WebCoreIntRectProvider.get_width):
3762         (WebCoreIntRectProvider.get_height):
3763         (WebCoreFloatPointProvider):
3764         (WebCoreFloatPointProvider.__init__):
3765         (WebCoreFloatPointProvider.get_x):
3766         (WebCoreFloatPointProvider.get_y):
3767         (WebCoreFloatSizeProvider):
3768         (WebCoreFloatSizeProvider.__init__):
3769         (WebCoreFloatSizeProvider.get_width):
3770         (WebCoreFloatSizeProvider.get_height):
3771         (WebCoreFloatRectProvider):
3772         (WebCoreFloatRectProvider.__init__):
3773         (WebCoreFloatRectProvider.get_x):
3774         (WebCoreFloatRectProvider.get_y):
3775         (WebCoreFloatRectProvider.get_width):
3776         (WebCoreFloatRectProvider.get_height):
3777
3778 2018-07-20  John Wilander  <wilander@apple.com>
3779
3780         Resource Load Statistics: Enable basic functionality in experimental debug mode
3781         https://bugs.webkit.org/show_bug.cgi?id=187835
3782         <rdar://problem/42408590>
3783
3784         Reviewed by Chris Dumez.
3785
3786         This patch makes the experimental ITP Debug Mode feature work, at least
3787         to a basic level. All of the changes to TestRunner are to support the
3788         layout tests for the functionality.
3789
3790         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3792         (WTR::InjectedBundle::didReceiveMessageToPage):
3793         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3794         (WTR::TestRunner::setStatisticsDebugMode):
3795         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
3796         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3797         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
3798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3799         * WebKitTestRunner/TestController.cpp:
3800         (WTR::TestController::setStatisticsDebugMode):
3801         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
3802         * WebKitTestRunner/TestController.h:
3803         * WebKitTestRunner/TestInvocation.cpp:
3804         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3805         (WTR::TestInvocation::didSetStatisticsDebugMode):
3806         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
3807         * WebKitTestRunner/TestInvocation.h:
3808
3809 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3810
3811         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3812         https://bugs.webkit.org/show_bug.cgi?id=187846
3813
3814         Reviewed by Simon Fraser.
3815
3816         Fixed the bug that testRunner.execCommand was using the second argument as the value.
3817
3818         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
3819         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
3820
3821         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3823         (WTR::TestRunner::execCommand):
3824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3825
3826 2018-07-20  Dean Jackson  <dino@apple.com>
3827
3828         Accidentally checked in the wrong version of these files.
3829
3830         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
3831         * lldb/lldbWebKitTester/main.cpp:
3832         (testSummaryProviders):
3833         * lldb/lldb_webkit_unittest.py:
3834         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3835         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
3836         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
3837         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
3838         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
3839         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
3840
3841 2018-07-20  Dean Jackson  <dino@apple.com>
3842
3843         Provide an lldb type summary for WebCore::Color
3844         https://bugs.webkit.org/show_bug.cgi?id=187776
3845
3846         Reviewed by Dan Bates.
3847
3848         This time without the tests because we don't want to build
3849         all of WebKit just for python tests.
3850
3851         * lldb/lldb_webkit.py: Add a Color summary provider.
3852         (__lldb_init_module):
3853         (WebCoreColor_SummaryProvider):
3854         (WebCoreColorProvider):
3855         (WebCoreColorProvider.__init__):
3856         (WebCoreColorProvider._is_extended):
3857         (WebCoreColorProvider._is_valid):
3858         (WebCoreColorProvider._is_semantic):
3859         (WebCoreColorProvider._to_string_extended):
3860         (WebCoreColorProvider.to_string):
3861
3862 2018-07-20  Brady Eidson  <beidson@apple.com>
3863
3864         Add WKNavigation/WKNavigationAction related SPI.
3865         https://bugs.webkit.org/show_bug.cgi?id=187826
3866
3867         Reviewed by Chris Dumez.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3870         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
3871         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3872         (TEST):
3873
3874 2018-07-20  Commit Queue  <commit-queue@webkit.org>
3875
3876         Unreviewed, rolling out r233943, r233988, r234004, and
3877         r234012.
3878         https://bugs.webkit.org/show_bug.cgi?id=187856
3879
3880         webkitpy tests are failing to build lldbWebKitTester
3881         (Requested by ryanhaddad on #webkit).
3882
3883         Reverted changesets:
3884
3885         "Provide an lldb type summary for WebCore::Color"
3886         https://bugs.webkit.org/show_bug.cgi?id=187776
3887         https://trac.webkit.org/changeset/233943
3888
3889         "Provide an lldb type summary for WebCore::Color"
3890         https://bugs.webkit.org/show_bug.cgi?id=187776
3891         https://trac.webkit.org/changeset/233988
3892
3893         "Provide an lldb type summary for WebCore::Color"
3894         https://bugs.webkit.org/show_bug.cgi?id=187776
3895         https://trac.webkit.org/changeset/234004
3896
3897         "Provide an lldb type summary for WebCore::Color"
3898         https://bugs.webkit.org/show_bug.cgi?id=187776
3899         https://trac.webkit.org/changeset/234012
3900
3901 2018-07-20  Philippe Normand  <pnormand@igalia.com>
3902
3903         [GTK][WPE] enable-media-capabilities websetting
3904         https://bugs.webkit.org/show_bug.cgi?id=187847
3905
3906         Reviewed by Carlos Garcia Campos.
3907
3908         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3909         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
3910
3911 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3912
3913         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
3914         https://bugs.webkit.org/show_bug.cgi?id=187798
3915
3916         Reviewed by Michael Catanzaro.
3917
3918         Update test cases to the new API and use a destroy function and vtable in the test case of calling
3919         jsc_context_evaluate_in_object() with a JSCClass.
3920
3921         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3922         (testJSCEvaluateInObject):
3923
3924 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
3925
3926         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
3927         https://bugs.webkit.org/show_bug.cgi?id=187712
3928
3929         Reviewed by Fujii Hironori.
3930
3931         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3932         Mark result of unsigned short test case as platform-specific,
3933         since Windows' behavior is actually *less* surprising here.
3934
3935 2018-07-19  Lucas Forschler  <lforschler@apple.com>
3936
3937         Teach the AWS Lambda to use the [minified]-platforms database
3938         https://bugs.webkit.org/show_bug.cgi?id=187817
3939         
3940         Reviewed by David Kilzer.
3941
3942         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
3943         (lambda_handler): Add support for the platforms.webkit.org database
3944         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
3945         (lambda_handler): Add support for the minified-platforms.webkit.org database
3946
3947 2018-07-19  Dean Jackson  <dino@apple.com>
3948
3949         Provide an lldb type summary for WebCore::Color
3950         https://bugs.webkit.org/show_bug.cgi?id=187776
3951
3952         Dan Bates helped me with this attempted fix. Fingers crossed!
3953
3954         * Scripts/build-lldbwebkittester:
3955
3956 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
3957
3958         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
3959         https://bugs.webkit.org/show_bug.cgi?id=187786
3960
3961         Reviewed by Fujii Hironori.
3962
3963         * Scripts/webkitdirs.pm:
3964         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
3965         for WinCairo builds.
3966
3967 2018-07-19  Dean Jackson  <dino@apple.com>
3968
3969         Provide an lldb type summary for WebCore::Color
3970         https://bugs.webkit.org/show_bug.cgi?id=187776
3971
3972         Another attempted build fix for Debug.
3973
3974         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3975         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
3976
3977 2018-07-19  Thomas Denney  <tdenney@apple.com>
3978
3979         [WHLSL] The interpreter doesn't support boolean short-circuiting
3980         https://bugs.webkit.org/show_bug.cgi?id=187779
3981
3982         Reviewed by Alex Christensen.
3983
3984         * WebGPUShadingLanguageRI/Evaluator.js:
3985         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
3986         * WebGPUShadingLanguageRI/Test.js:
3987         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
3988
3989 2018-07-19  Dean Jackson  <dino@apple.com>
3990
3991         Provide an lldb type summary for WebCore::Color
3992         https://bugs.webkit.org/show_bug.cgi?id=187776
3993
3994         Attempted build fix.
3995
3996         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3997
3998 2018-07-19  Brady Eidson  <beidson@apple.com>
3999
4000         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
4001         https://bugs.webkit.org/show_bug.cgi?id=187789
4002
4003         Reviewed by Andy Estes.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4006         (-[PSONNavigationDelegate init]):
4007         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4008
4009 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
4010
4011         [Flatpak] Let flatpak process handle SIGINT
4012         https://bugs.webkit.org/show_bug.cgi?id=187521
4013
4014         Reviewed by Philippe Normand.
4015
4016         Ensuring that flatpak process ends properly and that the sandbox is teard down.
4017         It also avoids showing usless backtrace to the end user and makes gdb
4018         much more usable.
4019
4020         Also make flatpakutils not verbose by default
4021
4022         * flatpak/flatpakutils.py:
4023         (disable_signals):
4024         (WebkitFlatpak.run_in_sandbox):
4025         (WebkitFlatpak.run_gdb):
4026
4027 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
4028
4029         Unreviewed. Fix contributors entry.
4030
4031         * Scripts/webkitpy/common/config/contributors.json:
4032
4033 2018-07-18  Dean Jackson  <dino@apple.com>
4034
4035         Provide an lldb type summary for WebCore::Color
4036         https://bugs.webkit.org/show_bug.cgi?id=187776
4037
4038         Reviewed by Dan Bates.
4039
4040         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
4041             to get to WebCore.
4042         * lldb/lldbWebKitTester/main.cpp:
4043         (testSummaryProviders): Create some Color objects for testing.
4044
4045         * lldb/lldb_webkit.py: Add a Color summary provider.
4046         (__lldb_init_module):
4047         (WebCoreColor_SummaryProvider):
4048         (WebCoreColorProvider):
4049         (WebCoreColorProvider.__init__):
4050         (WebCoreColorProvider._is_extended):
4051         (WebCoreColorProvider._is_valid):
4052         (WebCoreColorProvider._is_semantic):
4053         (WebCoreColorProvider._to_string_extended):
4054         (WebCoreColorProvider.to_string):
4055
4056         * lldb/lldb_webkit_unittest.py: Tests.
4057         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
4058         (TestSummaryProviders):
4059         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
4060         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
4061         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
4062         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
4063
4064 2018-07-18  Truitt Savell  <tsavell@apple.com>
4065
4066         Unreviewed, rolling out r233934.
4067
4068         Revision caused 5 webkitpy failures on Mac and broke webkitpy
4069         testing on iOS simulator
4070
4071         Reverted changeset:
4072
4073         "Provide an lldb type summary for WebCore::Color"
4074         https://bugs.webkit.org/show_bug.cgi?id=187776
4075         https://trac.webkit.org/changeset/233934
4076
4077 2018-07-18  Chris Dumez  <cdumez@apple.com>
4078
4079         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
4080         https://bugs.webkit.org/show_bug.cgi?id=187784
4081         <rdar://problem/42329230>
4082
4083         Reviewed by Brady Eidson.
4084
4085         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
4086         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
4087         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
4088
4089         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
4090         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
4091         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
4092         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
4093         result.
4094
4095         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4096         (WTR::InjectedBundle::shouldProcessWorkQueue const):
4097
4098 2018-07-18  Dean Jackson  <dino@apple.com>
4099
4100         Provide an lldb type summary for WebCore::Color
4101         https://bugs.webkit.org/show_bug.cgi?id=187776
4102
4103         Reviewed by Dan Bates.
4104
4105         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
4106             to get to WebCore.
4107         * lldb/lldbWebKitTester/main.cpp:
4108         (testSummaryProviders): Create some Color objects for testing.
4109
4110         * lldb/lldb_webkit.py: Add a Color summary provider.
4111         (__lldb_init_module):
4112         (WebCoreColor_SummaryProvider):
4113         (WebCoreColorProvider):
4114         (WebCoreColorProvider.__init__):
4115         (WebCoreColorProvider._is_extended):
4116         (WebCoreColorProvider._is_valid):
4117         (WebCoreColorProvider._is_semantic):
4118         (WebCoreColorProvider._to_string_extended):
4119         (WebCoreColorProvider.to_string):
4120
4121         * lldb/lldb_webkit_unittest.py: Tests.
4122         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
4123         (TestSummaryProviders):
4124         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
4125         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
4126         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
4127         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
4128
4129 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
4130
4131         Adding myself to contributors.json
4132
4133         Unreviewed contributors.json change.
4134
4135         * Scripts/webkitpy/common/config/contributors.json:
4136
4137 2018-07-18  Jer Noble  <jer.noble@apple.com>
4138
4139         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
4140         https://bugs.webkit.org/show_bug.cgi?id=187739
4141         <rdar://problem/42304518>
4142
4143         Reviewed by Tim Horton.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
4146         (TEST):
4147
4148 2018-07-18  Jer Noble  <jer.noble@apple.com>
4149
4150         PiP from Element Fullscreen should match AVKit's behavior
4151         https://bugs.webkit.org/show_bug.cgi?id=187623
4152         <rdar://problem/41212379>
4153
4154         Reviewed by Jon Lee.
4155
4156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4157         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
4158         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
4159         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
4160         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
4161         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
4162         (TestWebKitAPI::TEST):
4163
4164 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
4165
4166         [ews-build] Add build step to run layout-test
4167         https://bugs.webkit.org/show_bug.cgi?id=187674
4168
4169         Reviewed by Lucas Forschler.
4170
4171         * BuildSlaveSupport/ews-build/steps.py:
4172         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
4173         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4174         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
4175
4176 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4177
4178         Add SPI to defer running async script until after document load
4179         https://bugs.webkit.org/show_bug.cgi?id=187748
4180         <rdar://problem/42317378>
4181
4182         Reviewed by Ryosuke Niwa and Tim Horton.
4183
4184         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
4185         executed after the DOMContentLoaded event.
4186
4187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4188         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
4189         (TEST):
4190
4191 2018-07-18  Charlie Turner  <cturner@igalia.com>
4192
4193         [WPE] Update WPEBackend in flatpak
4194         https://bugs.webkit.org/show_bug.cgi?id=187753
4195
4196         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
4197         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
4198         in the version guard,
4199
4200         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
4201
4202         This doesn't work as intended, since the C preprocessor first expands
4203         all macro arguments in the #if expression before evaluating the
4204         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
4205         lead to a syntax error and some head scratching.