AX: Support API: accessibilityReplaceRange:withText
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         AX: Support API: accessibilityReplaceRange:withText
4         https://bugs.webkit.org/show_bug.cgi?id=196636
5
6         Unreviewed build fix for Windows port.
7
8         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
9         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
10
11 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
12
13         [CMake][WinCairo] Separate copied headers into different directories
14         https://bugs.webkit.org/show_bug.cgi?id=196655
15
16         Reviewed by Michael Catanzaro.
17
18         * DumpRenderTree/CMakeLists.txt:
19         * MiniBrowser/win/CMakeLists.txt:
20         * TestWebKitAPI/CMakeLists.txt:
21         * TestWebKitAPI/PlatformWin.cmake:
22
23 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
24
25         Log stack-trace for run-webkit-tests when interrupted
26         https://bugs.webkit.org/show_bug.cgi?id=176393
27         <rdar://problem/34262310>
28
29         Reviewed by Lucas Forschler.
30
31         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
32         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
33         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
34         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
35         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
36         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
37         (main): Set handlers to log stack trace on interruption.
38
39 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
40
41         AX: Support API: accessibilityReplaceRange:withText
42         https://bugs.webkit.org/show_bug.cgi?id=196636
43
44         Unreviewed build fix for Windows port.
45
46         * DumpRenderTree/AccessibilityUIElement.cpp:
47         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
48
49 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
50
51         [ews-build] Scripts using Buildbot API have CORS error
52         https://bugs.webkit.org/show_bug.cgi?id=196709
53
54         Reviewed by Alexey Proskuryakov.
55
56         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
57
58 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
59
60         AX: Support API: accessibilityReplaceRange:withText
61         https://bugs.webkit.org/show_bug.cgi?id=196636
62
63         Reviewed by Daniel Bates.
64
65         * DumpRenderTree/AccessibilityUIElement.cpp:
66         (replaceTextInRangeCallback):
67         (AccessibilityUIElement::replaceTextInRange):
68         (AccessibilityUIElement::getJSClass):
69         * DumpRenderTree/AccessibilityUIElement.h:
70         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
71         (AccessibilityUIElement::replaceTextInRange):
72         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
73         (AccessibilityUIElement::replaceTextInRange):
74         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
75         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
76         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
77         (WTR::AccessibilityUIElement::replaceTextInRange):
78         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
79         (WTR::AccessibilityUIElement::replaceTextInRange):
80
81 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         [iOS] Do not allow starting selection drags when selection views are not visible
84         https://bugs.webkit.org/show_bug.cgi?id=196686
85         <rdar://problem/49399192>
86
87         Reviewed by Tim Horton.
88
89         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
90         also add some new API tests to cover scenarios where the web view is not first responder.
91
92         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
93         (TestWebKitAPI::TEST):
94         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
95
96         Add a switch to optionally make the web view first responder when starting the simulated drag.
97
98         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
99         (-[DragAndDropSimulator initWithWebView:]):
100         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
101
102 2019-04-08  Justin Fan  <justin_fan@apple.com>
103
104         [Web GPU] Fix Web GPU experimental feature on iOS
105         https://bugs.webkit.org/show_bug.cgi?id=196632
106
107         Reviewed by Myles C. Maxfield.
108
109         Properly make Web GPU available on iOS 11+.
110
111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
112
113 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
114
115         [ews-build] Do not upload archive when Compile Fails
116         https://bugs.webkit.org/show_bug.cgi?id=196674
117
118         Reviewed by Alexey Proskuryakov.
119
120         * BuildSlaveSupport/ews-build/factories.py:
121         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
122         * BuildSlaveSupport/ews-build/steps.py:
123         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
124         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
125         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
126
127 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
128
129         Enable DFG on MIPS
130         https://bugs.webkit.org/show_bug.cgi?id=196689
131
132         Reviewed by Žan Doberšek.
133
134         Since the bytecode change, we enabled the baseline JIT on mips in
135         r240432, but DFG is still missing. With this change, all tests are
136         passing on a ci20 board.
137
138         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
139
140 2019-04-08  Philippe Normand  <pnormand@igalia.com>
141
142         [Flatpak] Second run update-webkitwpe-flatpak fails
143         https://bugs.webkit.org/show_bug.cgi?id=192702
144
145         Reviewed by Carlos Garcia Campos.
146
147         * flatpak/flatpakutils.py:
148         (FlatpakObject.flatpak): Fix typo.
149         (FlatpakPackage.install): When installing, also update to the configured remote commit.
150         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
151
152 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
153
154         [GTK][WPE] outlook.live.com displays old-fashioned UI
155         https://bugs.webkit.org/show_bug.cgi?id=196642
156
157         Reviewed by Carlos Garcia Campos.
158
159         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
160         (TestWebKitAPI::TEST): New Mac platform quirk test.
161
162 2019-04-07  Commit Queue  <commit-queue@webkit.org>
163
164         Unreviewed, rolling out r243956.
165         https://bugs.webkit.org/show_bug.cgi?id=196688
166
167         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
168         by aakashjain on #webkit).
169
170         Reverted changeset:
171
172         "Clicking "Go Back" from a safe browsing warning from an
173         iframe should navigate the WKWebView back to the previous
174         page"
175         https://bugs.webkit.org/show_bug.cgi?id=196665
176         https://trac.webkit.org/changeset/243956
177
178 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
179
180         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
181         https://bugs.webkit.org/show_bug.cgi?id=196669
182
183         Reviewed by Geoffrey Garen.
184
185         Added three new unit tests for WeakHashSet.
186
187         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
188         (WTF_WeakPtr.WeakHashSetConstObjects):
189         (WTF_WeakPtr.WeakHashSetComputesEmpty):
190         (WTF_WeakPtr.WeakHashSetComputeSize):
191
192 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
193
194         Hide next and previous form control buttons when WKWebView is editable
195         https://bugs.webkit.org/show_bug.cgi?id=196672
196         <rdar://problem/35625321>
197
198         Reviewed by Tim Horton.
199
200         Add a new API test.
201
202         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
203         (-[TestWKWebView lastTrailingBarButtonGroup]):
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/ios/UIKitSPI.h:
206
207 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
208
209         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
210         https://bugs.webkit.org/show_bug.cgi?id=196077
211         <rdar://problem/49108202>
212
213         Reviewed by Chris Dumez.
214
215         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
216         on new web view.
217
218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
219
220 2019-04-05  Saam Barati  <sbarati@apple.com>
221
222         Make compare-results understand MotionMark
223         https://bugs.webkit.org/show_bug.cgi?id=196666
224
225         Reviewed by Yusuke Suzuki.
226
227         * Scripts/compare-results:
228         (PLT5Results):
229         (detectMotionMark):
230         (detectMotionMark1_1):
231         (motionMarkResults):
232         (motionMark1_1Results):
233         (detectBenchmark):
234         (biggerIsBetter):
235         (main):
236
237 2019-04-05  Alex Christensen  <achristensen@webkit.org>
238
239         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
240         https://bugs.webkit.org/show_bug.cgi?id=196665
241         <rdar://45115669>
242
243         Reviewed by Geoff Garen.
244
245         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
246         (goBack):
247         (+[SimpleLookupContext sharedLookupContext]):
248         (-[SimpleLookupContext lookUpURL:completionHandler:]):
249         (TEST):
250         (+[Simple3LookupContext sharedLookupContext]): Deleted.
251         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
252
253 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
254
255         [ews-build] Add configuration and architecture for windows builders
256         https://bugs.webkit.org/show_bug.cgi?id=196660
257
258         Reviewed by Lucas Forschler.
259
260         * BuildSlaveSupport/ews-build/config.json:
261
262 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
263
264         webkitpy: Don't run subsequent rounds if interrupted
265         https://bugs.webkit.org/show_bug.cgi?id=196646
266
267         Reviewed by Aakash Jain.
268
269         * Scripts/webkitpy/layout_tests/controllers/manager.py:
270         (Manager.run): Bail out if interrupted.
271
272 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
273
274         Test sessionStorage in PSON private browsing mode
275         https://bugs.webkit.org/show_bug.cgi?id=196561
276
277         Reviewed by Alex Christensen.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
280
281 2019-04-05  Commit Queue  <commit-queue@webkit.org>
282
283         Unreviewed, rolling out r243833.
284         https://bugs.webkit.org/show_bug.cgi?id=196645
285
286         This change breaks build of WPE and GTK ports (Requested by
287         annulen on #webkit).
288
289         Reverted changeset:
290
291         "[CMake][WTF] Mirror XCode header directories"
292         https://bugs.webkit.org/show_bug.cgi?id=191662
293         https://trac.webkit.org/changeset/243833
294
295 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
296
297         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
298         https://bugs.webkit.org/show_bug.cgi?id=196635
299
300         Reviewed by Antti Koivisto.
301         
302         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
303         for a test to enable async frame scrolling via:
304             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
305         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
306         
307         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
308
309         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
310         (WTR::InjectedBundle::beginTesting):
311         * WebKitTestRunner/TestController.cpp:
312         (WTR::TestController::resetPreferencesToConsistentValues):
313
314 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
315
316         Use a correct LC_RPATH when building with ASan
317         https://bugs.webkit.org/show_bug.cgi?id=196576
318
319         Reviewed by David Kilzer.
320
321         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
322         so that ../Frameworks is checked. This is simpler and more reliable than updating
323         each SPC service xcconfig.
324
325 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
326
327         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
328         https://bugs.webkit.org/show_bug.cgi?id=196629
329
330         Reviewed by Lucas Forschler.
331
332         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
333
334 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
337         https://bugs.webkit.org/show_bug.cgi?id=196618
338
339         Reviewed by Lucas Forschler.
340
341         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
342         (StatusBubble): Added QUEUE_TRIGGERS.
343         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
344         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
345         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
346         its parent(builder).
347
348 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
349
350         [ews-app] Status-bubble steps are sometimes displayed in reverse order
351         https://bugs.webkit.org/show_bug.cgi?id=196625
352
353         Reviewed by Lucas Forschler.
354
355         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
356         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
357
358 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
359
360         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
361         https://bugs.webkit.org/show_bug.cgi?id=196630
362
363         Reviewed by Wenson Hsieh.
364
365         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
366
367 2019-04-04  Youenn Fablet  <youenn@apple.com>
368
369         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
370         https://bugs.webkit.org/show_bug.cgi?id=196543
371
372         Reviewed by Alex Christensen.
373
374         * WebKitTestRunner/TestController.cpp:
375         (WTR::TestController::generatePageConfiguration):
376
377 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
378
379         [ews-app] Status bubble should not display skipped buildbot steps
380         https://bugs.webkit.org/show_bug.cgi?id=196584
381
382         Reviewed by Lucas Forschler.
383
384         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
385
386 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
387
388         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
389         https://bugs.webkit.org/show_bug.cgi?id=196620
390
391         Reviewed by Lucas Forschler.
392
393         * BuildSlaveSupport/ews-app/ews/config.py:
394
395 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
396
397         [Win] DumpRenderTreeWatchDog.py is not checked into source
398         https://bugs.webkit.org/show_bug.cgi?id=196567
399         <rdar://problem/49525901>
400
401         Reviewed by Lucas Forschler.
402
403         This script is used on Win EWS bots to terminate hanging DRT processes.
404
405         * EWSTools/dumprendertreewatchdog.py: Added.
406
407 2019-04-04  Chris Dumez  <cdumez@apple.com>
408
409         Unreviewed, roll out r243858 which made tests time out.
410
411         Disable new API tests on Windows instead.
412
413         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
414         (TestWebKitAPI::TEST):
415
416 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
417
418         [ATK] Cleanup WebPageAccessibilityObjectAtk
419         https://bugs.webkit.org/show_bug.cgi?id=196537
420
421         Reviewed by Michael Catanzaro.
422
423         Also consider files under atk directories as exceptions for GObject conventions.
424
425         * Scripts/webkitpy/style/checkers/cpp.py:
426         (check_identifier_name_in_declaration):
427
428 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
429
430         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
431         https://bugs.webkit.org/show_bug.cgi?id=196588
432         <rdar://problem/49365787>
433
434         Unreviewed build fix for Windows port.
435
436         error C3861: 'kill': identifier not found
437
438         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
439         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
440
441 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-build] Cancel build and similar operations should have authentication
444         https://bugs.webkit.org/show_bug.cgi?id=196520
445
446         Reviewed by Dewei Zhu.
447
448         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
449         environment variables.
450
451 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Do not trigger queues which are not in production yet
454         https://bugs.webkit.org/show_bug.cgi?id=196581
455
456         Reviewed by Dewei Zhu.
457
458         * BuildSlaveSupport/ews-build/config.json:
459
460 2019-04-03  Chris Dumez  <cdumez@apple.com>
461
462         Unreviewed, fix typo in the name of API test added in r243848.
463
464         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
465         (TestWebKitAPI::TEST):
466
467 2019-04-03  Chris Dumez  <cdumez@apple.com>
468
469         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
470         https://bugs.webkit.org/show_bug.cgi?id=196588
471         <rdar://problem/49365787>
472
473         Reviewed by Ryosuke Niwa.
474
475         Add API test coverage.
476
477         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
478         (TestWebKitAPI::nullJavaScriptCallback):
479         (TestWebKitAPI::didCrashCheckFrames):
480         (TestWebKitAPI::TEST):
481
482 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
483
484         run-webkit-tests: Upload test results (new results database)
485         https://bugs.webkit.org/show_bug.cgi?id=196577
486         <rdar://problem/34841155>
487
488         Reviewed by Lucas Forschler.
489
490         * Scripts/webkitpy/layout_tests/controllers/manager.py:
491         (Manager.run): Upload results after each device shard, since the configuration will be
492         different for each device.
493         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
494         uploaded to a results database.
495         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
496         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
497
498 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
499
500         -apple-trailing-word is needed for browser detection
501         https://bugs.webkit.org/show_bug.cgi?id=196575
502
503         Unreviewed.
504
505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
506
507 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
508
509         [CMake][WTF] Mirror XCode header directories
510         https://bugs.webkit.org/show_bug.cgi?id=191662
511
512         Reviewed by Konstantin Tokarev.
513
514         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
515         builds.
516
517         * CMakeLists.txt:
518         * DumpRenderTree/CMakeLists.txt:
519         * DumpRenderTree/PlatformWin.cmake:
520         * MiniBrowser/win/CMakeLists.txt:
521         * TestWebKitAPI/CMakeLists.txt:
522         * TestWebKitAPI/PlatformWin.cmake:
523         * WebKitTestRunner/PlatformGTK.cmake:
524         * WebKitTestRunner/PlatformWin.cmake:
525
526 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
527
528         [ews-app] Status bubble should not display certain infrastructure status messages
529         https://bugs.webkit.org/show_bug.cgi?id=196550
530
531         Reviewed by Lucas Forschler.
532
533         Do not display the steps which are un-needed for end-user. This information is still avaiable
534         if the user click on the bubble and look at the Buildbot build.
535         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
536         (StatusBubble._steps_messages):
537         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
538
539 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
540
541         [ews-build] Use https for sending data to ews-app
542         https://bugs.webkit.org/show_bug.cgi?id=196492
543
544         Reviewed by Lucas Forschler.
545
546         * BuildSlaveSupport/ews-build/events.py:
547
548 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
549
550         Remove support for -apple-trailing-word
551         https://bugs.webkit.org/show_bug.cgi?id=196525
552
553         Reviewed by Zalan Bujtas.
554
555         This CSS property is nonstandard and not used.
556
557         * Scripts/webkitperl/FeatureList.pm:
558         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
559
560 2019-04-03  Youenn Fablet  <youenn@apple.com>
561
562         Add a test for DOMCache on multiple browsing in case of private browsing
563         https://bugs.webkit.org/show_bug.cgi?id=196524
564
565         Reviewed by Alex Christensen.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
568         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
569
570 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
571
572         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
573         https://bugs.webkit.org/show_bug.cgi?id=196540
574
575         Reviewed by Aakash Jain.
576
577         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
578
579 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
580
581         Add plumbing for a compatibility mode preference in WebKit
582         https://bugs.webkit.org/show_bug.cgi?id=196005
583
584         Reviewed by Tim Horton.
585
586         Add new API tests.
587
588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
589         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
590
591 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
592
593         [WPE][GTK] Update libsrtp dependency package for Debian
594         https://bugs.webkit.org/show_bug.cgi?id=196528
595
596         Reviewed by Frédéric Wang.
597
598         * gtk/install-dependencies:
599         * wpe/install-dependencies:
600
601 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
602
603         [WK2] Add support for Window's beforeprint / afterprint events
604         https://bugs.webkit.org/show_bug.cgi?id=196478
605         <rdar://problem/49535124>
606
607         Unreviewed build fix for MSVC.
608
609         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
610
611         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
612
613         * WebKitTestRunner/TestController.cpp:
614         (WTR::printFrame): Use int and float literals.
615
616 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
617
618         [ews-build] Reassign bots to queues
619
620         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
621
622 2019-04-02  Chris Dumez  <cdumez@apple.com>
623
624         [WK2] Add support for Window's beforeprint / afterprint events
625         https://bugs.webkit.org/show_bug.cgi?id=196478
626
627         Reviewed by Alex Christensen.
628
629         Add minimal implementation for printFrame in WebKitTestRunner.
630
631         * WebKitTestRunner/TestController.cpp:
632         (WTR::printFrame):
633         (WTR::TestController::createOtherPage):
634         (WTR::TestController::createWebViewWithOptions):
635
636 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
637
638         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
639         https://bugs.webkit.org/show_bug.cgi?id=196491
640
641         Reviewed by Lucas Forschler.
642
643         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
644
645 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
646
647         [ews-build] Configure buildbot try credentials in environment variables
648         https://bugs.webkit.org/show_bug.cgi?id=196501
649
650         Reviewed by Lucas Forschler.
651
652         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
653         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
654         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
655
656 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
657
658         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
659         https://bugs.webkit.org/show_bug.cgi?id=196496
660         <rdar://problem/49521634>
661
662         Reviewed by Chris Dumez.
663
664         Add new API tests (see WebKit ChangeLog for more detail).
665
666         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
667         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
668         (TEST):
669
670 2019-04-02  David Kilzer  <ddkilzer@apple.com>
671
672         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
673         <https://webkit.org/b/196499>
674
675         Reviewed by Alexey Proskuryakov.
676
677         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
678         ENABLE_ADDRESS_SANITIZER.
679
680 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
681
682         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
683         https://bugs.webkit.org/show_bug.cgi?id=182757
684
685         Reviewed by Don Olmstead.
686
687         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
688         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
689
690 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
691
692         run-api-tests: Upload test results
693         https://bugs.webkit.org/show_bug.cgi?id=196323
694         <rdar://problem/49356714>
695
696         Reviewed by Lucas Forschler.
697
698         * Scripts/webkitpy/api_tests/manager.py:
699         (Manager):
700         (Manager.run): Upload results to a results database.
701         * Scripts/webkitpy/api_tests/run_api_tests.py:
702         (parse_args): Add upload arguments.
703         * Scripts/webkitpy/port/base.py:
704         (Port):
705         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
706         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
707         with commits from any other associated repositories.
708         * Scripts/webkitpy/port/device.py:
709         (Device):
710         (Device.build_version): Access build_versoin of underlying platform device.
711         * Scripts/webkitpy/port/ios_simulator_unittest.py:
712         (IOSSimulatorTest):
713         (IOSSimulatorTest.test_configuration_for_upload):
714         * Scripts/webkitpy/port/device_port.py:
715         (DevicePort):
716         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
717         the same as the machine uploading results.
718         * Scripts/webkitpy/port/mac.py:
719         (MacPort):
720         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
721         * Scripts/webkitpy/port/mac_unittest.py:
722         (MacTest):
723         (MacTest.test_configuration_for_upload):
724         * Scripts/webkitpy/xcode/simulated_device.py:
725         (SimulatedDeviceManager._create_device_with_runtime):
726         (SimulatedDevice.__init__): Create simulated device with a build_version.
727         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
728         (test_existing_simulator):
729
730 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
731
732         Remove extra newline characters (Follow-up fix to r243707)
733
734         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
735
736 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
737
738         [ews-app] Use API_KEY to accept results data
739         https://bugs.webkit.org/show_bug.cgi?id=196461
740
741         Reviewed by Dewei Zhu.
742
743         * BuildSlaveSupport/ews-app/ews/views/results.py:
744         (Results.post): Validate EWS_API_KEY before accepting any data.
745         * BuildSlaveSupport/ews-build/events.py:
746         (Events.sendData): Send EWS_API_KEY if available along with event data.
747
748 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
749
750         Unable to copy and paste a PDF from Notes into Mail compose body
751         https://bugs.webkit.org/show_bug.cgi?id=196442
752         <rdar://problem/48573098>
753
754         Reviewed by Tim Horton.
755
756         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
757         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
758         to be specified on the item providers.
759
760         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
761         (TestWebKitAPI::mapItemForTesting):
762         (TestWebKitAPI::contactItemForTesting):
763
764 2019-04-01  Tim Horton  <timothy_horton@apple.com>
765
766         Make UIWKDocumentContext rects per-character instead of per-word
767         https://bugs.webkit.org/show_bug.cgi?id=196459
768
769         Reviewed by Wenson Hsieh.
770
771         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
772         (TEST):
773         Adjust test results due to switching to per-character rects.
774
775 2019-04-01  Chris Dumez  <cdumez@apple.com>
776
777         UIProcess crash when a prewarmed process is terminated
778         https://bugs.webkit.org/show_bug.cgi?id=196451
779         <rdar://problem/49245471>
780
781         Reviewed by Geoffrey Garen.
782
783         Add API test coverage.
784
785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
786         (TEST):
787
788 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
789
790         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
791         https://bugs.webkit.org/show_bug.cgi?id=196449
792
793         Reviewed by Lucas Forschler.
794
795         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
796         (StatusBubble.get_os_details): Method to get OS and Xcode details.
797         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
798         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
799
800 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
801
802         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
803         https://bugs.webkit.org/show_bug.cgi?id=196444
804
805         Reviewed by Lucas Forschler.
806
807         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
808
809 2019-04-01  Alex Christensen  <achristensen@webkit.org>
810
811         Add SPI to canonicalize NSURLs with WTF::URL
812         https://bugs.webkit.org/show_bug.cgi?id=196415
813         <rdar://problem/44980271>
814
815         Reviewed by Darin Adler.
816
817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
818         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
819         (TestWebKitAPI::TEST):
820
821 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
822
823         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
824         https://bugs.webkit.org/show_bug.cgi?id=196441
825
826         Reviewed by Carlos Garcia Campos.
827
828         Don't cache the wpe_view_backend object that might not exist yet at the
829         time of EventSenderProxy constructor invocation, but instead retrieve
830         that object whenever it's required for event dispatching. This should
831         avoid crashes in this constructor now that it's invoked before any
832         PlatformWindow has been set up (as changed in r243496).
833
834         * WebKitTestRunner/EventSenderProxy.h:
835         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
836         (WTR::viewBackend):
837         (WTR::EventSenderProxy::EventSenderProxy):
838         (WTR::EventSenderProxy::mouseDown):
839         (WTR::EventSenderProxy::mouseUp):
840         (WTR::EventSenderProxy::mouseMoveTo):
841         (WTR::EventSenderProxy::mouseScrollBy):
842         (WTR::EventSenderProxy::keyDown):
843         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
844
845 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
846
847         [Win][WebKit] MiniBrowser should support high DPI display
848         https://bugs.webkit.org/show_bug.cgi?id=196391
849
850         Reviewed by Alex Christensen.
851
852         * MiniBrowser/win/WebKitBrowserWindow.cpp:
853         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
854         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
855         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
856
857 2019-03-31  Sam Weinig  <weinig@apple.com>
858
859         Remove more i386 specific configurations
860         https://bugs.webkit.org/show_bug.cgi?id=196430
861
862         Reviewed by Alexey Proskuryakov.
863
864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
865         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
866
867 2019-03-31  Andy Estes  <aestes@apple.com>
868
869         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
870         https://bugs.webkit.org/show_bug.cgi?id=196433
871         <rdar://problem/49293305>
872
873         Reviewed by Tim Horton.
874
875         Enhanced API test coverage to include all navigation response policy decisions in both
876         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
877
878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
879         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
880         (TestWebKitAPI::TEST):
881         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
882         (readFile):
883         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
884         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
885         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
886         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
887         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
888         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
889         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
890         (-[QuickLookDelegate _downloadDidStart:]):
891         (-[QuickLookDelegate _download:didReceiveResponse:]):
892         (-[QuickLookDelegate _download:didReceiveData:]):
893         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
894         (-[QuickLookDelegate _downloadDidFinish:]):
895         (-[QuickLookDelegate _download:didFailWithError:]):
896         (-[QuickLookDelegate _downloadDidCancel:]):
897         (-[QuickLookDelegate verifyDownload]):
898         (runTest):
899         (runTestDecideBeforeLoading):
900         (runTestDecideAfterLoading):
901         (TEST):
902         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
903         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
904         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
905         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
906         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
907         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
908         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
909         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
910         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
911         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
912         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
913         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
914         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
915         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
916
917 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
918
919         [CMake] add testdfg as target with build-jsc
920         https://bugs.webkit.org/show_bug.cgi?id=196393
921
922         Reviewed by Saam Barati.
923
924         Added testdfg as one of the targets to build when
925         using CMake.
926
927         * Scripts/build-jsc:
928
929 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
930
931         Delete WebMetal implementation in favor of WebGPU
932         https://bugs.webkit.org/show_bug.cgi?id=195418
933
934         Reviewed by Dean Jackson.
935
936         * DumpRenderTree/mac/DumpRenderTree.mm:
937         (enableExperimentalFeatures):
938         (resetWebPreferencesToConsistentValues):
939         * Scripts/webkitperl/FeatureList.pm:
940         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
942         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
943         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
944         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
945         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
946         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
947         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
948         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
949         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
950         (WTR::InjectedBundle::beginTesting):
951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
952         (WTR::TestRunner::setWebMetalEnabled): Deleted.
953         * WebKitTestRunner/InjectedBundle/TestRunner.h:
954
955 2019-03-29  Chris Dumez  <cdumez@apple.com>
956
957         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
958         https://bugs.webkit.org/show_bug.cgi?id=196405
959         <rdar://problem/49428130>
960
961         Reviewed by Wenson Hsieh.
962
963         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
964         the popover presentation methods to be no-ops. Use this in the new test added in
965         r243523 so that we do not swizzle those methods for all tests. This is needed because
966         those WatchOS tests rely on the popover getting presented and interactive.
967
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::updateTestOptionsFromTestHeader):
970         * WebKitTestRunner/TestController.h:
971         * WebKitTestRunner/TestOptions.h:
972         (WTR::TestOptions::hasSameInitializationOptions const):
973         * WebKitTestRunner/ios/TestControllerIOS.mm:
974         (WTR::TestController::platformInitialize):
975         (WTR::TestController::platformResetStateToConsistentValues):
976
977 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
978
979         [Curl] Add Server Trust Evaluation Support.
980         https://bugs.webkit.org/show_bug.cgi?id=191646
981
982         Reviewed by Fujii Hironori.
983
984         Implemented MiniBrowser UI for asking if user trusts the server.
985
986         * MiniBrowser/win/Common.cpp:
987         (askServerTrustEvaluation):
988         (replaceString):
989         * MiniBrowser/win/Common.h:
990         * MiniBrowser/win/MiniBrowserLib.rc:
991         * MiniBrowser/win/MiniBrowserLibResource.h:
992         * MiniBrowser/win/WebKitBrowserWindow.cpp:
993         (createPEMString):
994         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
995         (WebKitBrowserWindow::canTrustServerCertificate):
996         * MiniBrowser/win/WebKitBrowserWindow.h:
997
998 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
999
1000         Implement ResizeObserver.
1001         https://bugs.webkit.org/show_bug.cgi?id=157743
1002
1003         Reviewed by Simon Fraser.
1004
1005         Support resizeObserverEnabled webPreferences.
1006
1007         * DumpRenderTree/TestOptions.cpp:
1008         (TestOptions::TestOptions):
1009         * DumpRenderTree/TestOptions.h:
1010         * DumpRenderTree/mac/DumpRenderTree.mm:
1011         (setWebPreferencesForTestOptions):
1012         * DumpRenderTree/win/DumpRenderTree.cpp:
1013         (enableExperimentalFeatures):
1014         * Scripts/webkitperl/FeatureList.pm:
1015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1016
1017 2019-03-28  John Wilander  <wilander@apple.com>
1018
1019         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1020         https://bugs.webkit.org/show_bug.cgi?id=196281
1021         <rdar://problem/48938748>
1022
1023         Reviewed by Alex Christensen.
1024
1025         This patch adds the function isStatisticsHasLocalStorage() to the
1026         TestRunner. With it, the page can query the WebsiteDataStore in the
1027         UI process to make sure that it sees LocalStorage.
1028
1029         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1030         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1031         (WTR::TestRunner::isStatisticsHasLocalStorage):
1032         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::TestController::isStatisticsHasLocalStorage):
1035         * WebKitTestRunner/TestController.h:
1036         * WebKitTestRunner/TestInvocation.cpp:
1037         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1038
1039 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1040
1041         API::Data::createWithoutCopying should do a null check before calling CFRelease
1042         https://bugs.webkit.org/show_bug.cgi?id=196276
1043         <rdar://problem/48059859>
1044
1045         Reviewed by Alex Christensen.
1046
1047         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1048
1049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1050         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1051         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1052         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1053         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1054         (TestWebKitAPI::TEST):
1055
1056 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1057
1058         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1059         https://bugs.webkit.org/show_bug.cgi?id=186276
1060
1061         Reviewed by Carlos Garcia Campos.
1062
1063         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1064         (webViewLoadChanged):
1065         (testWebResourceGetDataError):
1066         (testWebResourceGetDataEmpty):
1067         (beforeAll):
1068         (webViewloadChanged): Deleted.
1069
1070 2019-03-27  Andy Estes  <aestes@apple.com>
1071
1072         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1073         https://bugs.webkit.org/show_bug.cgi?id=196317
1074
1075         Reviewed by Dan Bernstein.
1076
1077         package-root copies built products into a staging directory using ditto(1), which does not
1078         follow symbolic links as it traverses a directory. Now that the files in
1079         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1080         itself, these become broken links when ditto'd into the staging directory.
1081
1082         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1083
1084         * Scripts/package-root:
1085
1086 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-app] Update display text of Submit for ews analysis
1089         https://bugs.webkit.org/show_bug.cgi?id=196309
1090
1091         Reviewed by Dewei Zhu.
1092
1093         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1094
1095 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1096
1097         run-webkit-tests should check for leaks in WebKit processes
1098         <https://webkit.org/b/193772>
1099         <rdar://problem/46526680>
1100
1101         Reviewed by Ryosuke Niwa.
1102
1103         This works by doing the following:
1104         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1105           The list of child processes are returned one per line:
1106           process.name: pid
1107         - Run the "#LIST CHILD PROCESSES" command just before the
1108           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1109           processes on the ServerProcess object.
1110         - When the `--leaks` switch is handled, run check_for_leaks() on
1111           each child process after the main test harness.
1112
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (handleControlCommand):
1115         - Use strncmp() instead of strcmp().
1116         - Add support for handling "#LIST CHILD PROCESSES" command.
1117
1118         * Scripts/webkitpy/port/base.py:
1119         (Port.check_for_leaks):
1120         * Scripts/webkitpy/port/darwin.py:
1121         (DarwinPort.check_for_leaks):
1122         - Rename redundant 'process_pid' argument to 'process_id'.
1123
1124         * Scripts/webkitpy/port/driver.py:
1125         (Driver.do_post_tests_work):
1126         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1127           longer the only command this sends to WebKitTestRunner.
1128         - If the `--leaks` switch is present, send the
1129           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1130           result using Port.set_webkit_processes().
1131         (Driver._parse_child_processes_output):
1132         - Add helper method to parse list of child process names and
1133           process IDs returned from WebKitTestRunner.
1134
1135         * Scripts/webkitpy/port/ios_device.py:
1136         (IOSDevicePort.check_for_leaks):
1137         - Rename redundant 'process_pid' argument to 'process_id'.
1138
1139         * Scripts/webkitpy/port/leakdetector.py:
1140         (LeakDetector._parse_leaks_output):
1141         - Return early if there is no leaks_output.
1142         (LeakDetector.check_for_leaks):
1143         - Rename redundant 'process_pid' argument to 'process_id'.
1144
1145         * Scripts/webkitpy/port/server_process.py:
1146         (ServerProcess.__init__):
1147         (ServerProcess.child_processes):
1148         (ServerProcess.set_child_processes):
1149         - Add instance variable to Port to store list of child process
1150           names and process IDs returned from WebKitTestRunner.
1151         (ServerProcess._start):
1152         - Clear self._child_processes.
1153         (ServerProcess.stop):
1154         - If self._child_processes is set, call
1155           self._port.check_for_leaks() for each child process.
1156
1157         * Scripts/webkitpy/port/server_process_unittest.py:
1158         (TrivialMockPort.check_for_leaks):
1159         - Rename redundant 'process_pid' argument to 'process_id'.
1160
1161         * Scripts/webkitpy/port/simulator_process.py:
1162         (SimulatorProcess.stop):
1163         - If self._child_processes is set, call
1164           self._port.check_for_leaks() for each child process.
1165
1166         * Scripts/webkitpy/port/watch_device.py:
1167         (WatchDevicePort.check_for_leaks):
1168         - Rename redundant 'process_pid' argument to 'process_id'.
1169
1170         * WebKitTestRunner/TestController.cpp:
1171         (WTR::TestController::dumpResponse):
1172         - Extract method from findAndDumpWorldLeaks() so that it may be
1173           reused by findAndDumpWebKitProcessIdentifiers().
1174         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1175         - Add method to output process name and process ID of both the
1176           WebContent and Networking processes.
1177         (WTR::TestController::findAndDumpWorldLeaks):
1178         - Fix missing newline in output when there were no abandoned
1179           documents.
1180         - Call dumpResponse() for extracted code.
1181         (WTR::TestController::handleControlCommand):
1182         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1183         - Use strncmp() instead of strcmp().
1184         - Call findAndDumpWebKitProcessIdentifiers() when
1185           "#LIST CHILD PROCESSES" command is sent.
1186         * WebKitTestRunner/TestController.h:
1187         (WTR::TestController::dumpResponse):
1188         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1189         - Declare methods.
1190
1191 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         Unreviewed. Add GLib API test cases after r243434.
1194
1195         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1196         (testWebViewActiveURI):
1197         (serverCallback):
1198         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1199         (sendRequestCallback):
1200
1201 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Geolocation request not complete when watch request was started in a different web process
1204         https://bugs.webkit.org/show_bug.cgi?id=195996
1205
1206         Reviewed by Alex Christensen.
1207
1208         Add a test case.
1209
1210         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1211         (TestWebKitAPI::runJavaScriptAlert):
1212         (TestWebKitAPI::TEST):
1213
1214 2019-03-26  Keith Rollin  <krollin@apple.com>
1215
1216         Update the way generate-xcfilelists returns strings from functions
1217         https://bugs.webkit.org/show_bug.cgi?id=195975
1218         <rdar://problem/49040807>
1219
1220         Reviewed by Dean Jackson.
1221
1222         There are places where generate-xcfilelists executes assignments with
1223         statements like:
1224
1225             FOO=$(some_function)
1226
1227         where "some_function" return a string by echoing it. E.g.
1228
1229             some_function()
1230             {
1231                 echo "Hello, World"
1232             }
1233
1234         This is a common idiom, but it has a problem if "some_function" needs
1235         to call "exit" in an attempt to halt the entire script right then and
1236         there. Since "some_function" is called inside of $(), it's being
1237         executed in a sub-shell. Calling exit in that sub-shell simply exits
1238         that shell; it doesn't not exit the outer shell in which the main part
1239         of the script is still running. As such, the main script keeps
1240         executing when the intent was for the script to halt.
1241
1242         The solution to this is to use a different idiom for returning
1243         strings. The one we now is to pass in the name of the variable to
1244         receive the string result:
1245
1246             some_function()
1247             {
1248                 variable_name=$1
1249                 eval $variable_name ="Hello, World"
1250             }
1251
1252         The call site now looks like
1253
1254             some_function FOO
1255
1256         Because there's no invocation of a sub-shell, some_function can now
1257         call "exit" if it wants to, and the entire script will exit at that
1258         point.
1259
1260         * Scripts/generate-xcfilelists:
1261
1262 2019-03-26  Chris Dumez  <cdumez@apple.com>
1263
1264         Add basic layout test coverage for File Picker on iOS
1265         https://bugs.webkit.org/show_bug.cgi?id=196265
1266
1267         Reviewed by Wenson Hsieh.
1268
1269         Add layout test infrastructure to test the file picker on iOS.
1270
1271         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1272         (WTR::UIScriptController::dismissFilePicker):
1273         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1274         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1275         (WTR::UIScriptController::dismissFilePicker):
1276         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1277         * WebKitTestRunner/TestController.cpp:
1278         (WTR::TestController::createWebViewWithOptions):
1279         (WTR::updateTestOptionsFromTestHeader):
1280         * WebKitTestRunner/TestOptions.h:
1281         (WTR::TestOptions::hasSameInitializationOptions const):
1282         * WebKitTestRunner/ios/TestControllerIOS.mm:
1283         (overridePresentViewController):
1284         (WTR::TestController::platformInitialize):
1285         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1286         (WTR::UIScriptController::dismissFilePicker):
1287
1288 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1289
1290         Implement async paste method on UIWKInteractionViewProtocol
1291         https://bugs.webkit.org/show_bug.cgi?id=196267
1292         <rdar://problem/49236346>
1293
1294         Reviewed by Tim Horton.
1295
1296         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1297         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1298         are now a part of all iOS 12 internal SDKs.
1299
1300         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1301
1302         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1303         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1304
1305         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1306         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1307         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1308         * TestWebKitAPI/ios/UIKitSPI.h:
1309
1310 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1311
1312         [ews-build] Use PostgreSQL for ews.webkit.org database
1313         https://bugs.webkit.org/show_bug.cgi?id=196270
1314
1315         Reviewed by Lucas Forschler.
1316
1317         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1318
1319 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1320
1321         [ews] Reset simctl states on reboot
1322         https://bugs.webkit.org/show_bug.cgi?id=196260
1323
1324         Rubber-stamped by Aakash Jain.
1325
1326         * EWSTools/start-queue-mac.sh:
1327
1328 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-build] Use PostgreSQL for ews-build database
1331         https://bugs.webkit.org/show_bug.cgi?id=196229
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-build/master.cfg:
1336
1337 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1338
1339         [ews-build] Get master_hostname dynamically in master.cfg
1340         https://bugs.webkit.org/show_bug.cgi?id=196255
1341
1342         Reviewed by Lucas Forschler.
1343
1344         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1345         send events data in test mode.
1346
1347 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1348
1349         [ews-app] Set db_constraint to False for Foreign Keys
1350         https://bugs.webkit.org/show_bug.cgi?id=196252
1351
1352         Reviewed by Lucas Forschler.
1353
1354         * BuildSlaveSupport/ews-app/ews/models/build.py:
1355         * BuildSlaveSupport/ews-app/ews/models/step.py:
1356
1357 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1358
1359         [ews-build] is_test_mode_enabled should default to True
1360         https://bugs.webkit.org/show_bug.cgi?id=196248
1361
1362         Reviewed by Lucas Forschler.
1363
1364         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1365
1366 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1367
1368         [ews-app] Add webkitperl to ENABLED_QUEUES
1369         https://bugs.webkit.org/show_bug.cgi?id=196253
1370
1371         Reviewed by Lucas Forschler.
1372
1373         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1374
1375 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1376
1377         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1378         https://bugs.webkit.org/show_bug.cgi?id=196211
1379         rdar://problem/49110552
1380
1381         Reviewed by Tim Horton.
1382
1383         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1384         Make sure that EventSenderProxy always exists when running tests. We used to create
1385         it when resetting before the first test, which is a bit too late.
1386
1387         * WebKitTestRunner/TestController.h:
1388         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1389         (WTR::TestController::platformCreateWebView):
1390         (WTR::TestController::platformCreateOtherPage):
1391         (WTR::TestController::finishCreatingPlatformWebView):
1392         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1393         (WTR::PlatformWebView::PlatformWebView):
1394         Moved some code that made NSWindow use NSEvent during web view creation. We may
1395         need to move more if some other case us found, but this is enough for now.
1396
1397 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1398
1399         Unreviewed. Fix typo in GLib geolocation API after r243285.
1400
1401         gelocation -> geolocation.
1402
1403         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1404         (testGeolocationManagerWatchPosition):
1405
1406 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1407
1408         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1409         https://bugs.webkit.org/show_bug.cgi?id=196213
1410
1411         Reviewed by Geoff Garen.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1415         (credentialWithIdentityAndKeychainPath):
1416         (-[ChallengeDelegate webView:didFinishNavigation:]):
1417         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1418         (TestWebKitAPI::TEST):
1419
1420 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1421
1422         Expected shouldn't assume its contained types are copyable
1423         https://bugs.webkit.org/show_bug.cgi?id=195986
1424
1425         Reviewed by JF Bastien.
1426
1427         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1428         (TestWebKitAPI::NonCopyable::operator== const):
1429         (TestWebKitAPI::NonCopyable::operator!= const):
1430         (TestWebKitAPI::TEST):
1431
1432 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1433
1434         Remove some now-unnecessary dynamic class lookup
1435         https://bugs.webkit.org/show_bug.cgi?id=196237
1436
1437         Reviewed by Simon Fraser.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1440         (makeRequest):
1441         (TEST):
1442
1443 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1444
1445         Unreviewed, rolling out r243450.
1446
1447         AppleWin and WinCairo port builds get broken.
1448
1449         Reverted changeset:
1450
1451         "Add test for fix of #196095"
1452         https://bugs.webkit.org/show_bug.cgi?id=196097
1453         https://trac.webkit.org/changeset/243450
1454
1455 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1456
1457         Unreviewed, rolling out r243465.
1458         https://bugs.webkit.org/show_bug.cgi?id=196226
1459
1460         the test doesn't build (Requested by thorton on #webkit).
1461
1462         Reverted changeset:
1463
1464         "Do not terminate the NetworkProcess if a third party
1465         application sends a NSCredential with a SecIdentityRef"
1466         https://bugs.webkit.org/show_bug.cgi?id=196213
1467         https://trac.webkit.org/changeset/243465
1468
1469 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1470
1471         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1472         https://bugs.webkit.org/show_bug.cgi?id=196213
1473
1474         Reviewed by Geoff Garen.
1475
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1478         (credentialWithIdentityAndKeychainPath):
1479         (-[ChallengeDelegate webView:didFinishNavigation:]):
1480         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1481         (TestWebKitAPI::TEST):
1482
1483 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1484
1485         [ews-build] Gracefully handle missing patch_id in events
1486         https://bugs.webkit.org/show_bug.cgi?id=196216
1487
1488         Reviewed by Lucas Forschler.
1489
1490         * BuildSlaveSupport/ews-build/events.py:
1491
1492 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1493
1494         [ews-build] use lz4 compression for improving buildbot performance
1495         https://bugs.webkit.org/show_bug.cgi?id=196155
1496
1497         Reviewed by Lucas Forschler.
1498
1499         * BuildSlaveSupport/ews-build/master.cfg:
1500
1501 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         Pull some API testing helper methods out of TestWKWebView
1504         https://bugs.webkit.org/show_bug.cgi?id=196212
1505
1506         Reviewed by Tim Horton.
1507
1508         Refactor some more API testing utility methods, so that they can be used in
1509         tests that do not use TestWKWebView.
1510
1511         * TestWebKitAPI/cocoa/TestWKWebView.h:
1512         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1513         (-[WKWebView loadTestPageNamed:]):
1514         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1515         (-[WKWebView synchronouslyLoadHTMLString:]):
1516         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1517         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1518         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1519         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1520         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1521
1522 2019-03-25  Jer Noble  <jer.noble@apple.com>
1523
1524         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1525         https://bugs.webkit.org/show_bug.cgi?id=196097
1526
1527         Reviewed by Eric Carlson.
1528
1529         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1530
1531         * DumpRenderTree/mac/DumpRenderTree.mm:
1532         (resetWebPreferencesToConsistentValues):
1533         * WebKitTestRunner/TestController.cpp:
1534         (WTR::TestController::resetPreferencesToConsistentValues):
1535
1536 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1537
1538         Pull IPadUserInterfaceSwizzler out into a separate header file
1539         https://bugs.webkit.org/show_bug.cgi?id=196193
1540
1541         Reviewed by Anders Carlsson.
1542
1543         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1544         be used in other API tests.
1545
1546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1547         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1548         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1549         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1550         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1551         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1552         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1553
1554 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1555
1556         Remove NavigatorContentUtils in WebCore/Modules
1557         https://bugs.webkit.org/show_bug.cgi?id=196070
1558
1559         Reviewed by Alex Christensen.
1560
1561         NavigatorContentUtils was to support the custom scheme spec [1].
1562         However, in WebKit side, no port has supported the feature in
1563         WebKit layer after EFL port was removed. So there has been the
1564         only IDL implementation of the NavigatorContentUtils in WebCore.
1565         So we don't need to keep the implementation in WebCore anymore.
1566
1567         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1568
1569         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1570
1571 2019-03-24  Andy Estes  <aestes@apple.com>
1572
1573         [watchOS] Remove unused Proximity Networking code
1574         https://bugs.webkit.org/show_bug.cgi?id=196188
1575
1576         Reviewed by Tim Horton.
1577
1578         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1579         (TEST):
1580
1581 2019-03-23  Keith Miller  <keith_miller@apple.com>
1582
1583         Refactor clz/ctz and fix getLSBSet.
1584         https://bugs.webkit.org/show_bug.cgi?id=196162
1585
1586         Reviewed by Saam Barati.
1587
1588         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1589
1590         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1591         (TestWebKitAPI::TEST):
1592
1593 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1596         https://bugs.webkit.org/show_bug.cgi?id=196143
1597
1598         Reviewed by Michael Catanzaro.
1599
1600         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1601         directories.
1602
1603         * Scripts/webkitpy/style/checkers/cpp.py:
1604         (check_identifier_name_in_declaration):
1605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1606         (WebKitStyleTest.test_names):
1607
1608 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1609
1610         [Flatpak] Manifest expanding fails for qt WPE extension
1611         https://bugs.webkit.org/show_bug.cgi?id=196148
1612
1613         Reviewed by Alex Christensen.
1614
1615         * flatpak/flatpakutils.py:
1616         (expand_submodules_recurse): The last recurse manifest expand
1617         iteration might lead to a single module so take it into account
1618         and don't try to recurse further.
1619
1620 2019-03-22  Chris Dumez  <cdumez@apple.com>
1621
1622         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1623         https://bugs.webkit.org/show_bug.cgi?id=195348
1624         <rdar://problem/48622090>
1625
1626         Reviewed by Alex Christensen.
1627
1628         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1629         to NO when test.options().shouldIgnoreMetaViewport is false.
1630
1631         * WebKitTestRunner/ios/TestControllerIOS.mm:
1632         (WTR::TestController::platformConfigureViewForTest):
1633
1634 2019-03-22  Chris Dumez  <cdumez@apple.com>
1635
1636         Prewarmed processes should be usable with any website data store
1637         https://bugs.webkit.org/show_bug.cgi?id=196104
1638
1639         Reviewed by Alex Christensen.
1640
1641         Add API test coverage.
1642
1643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1644         (runInitialWarmedProcessUsedTest):
1645         (TEST):
1646
1647 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1648
1649         Back out local changes to Alex's Subversion working directory
1650
1651         They were accidentally committed.
1652
1653         * Scripts/webkitpy/common/system/abstractexecutive.py:
1654         (AbstractExecutive.wait_newest):
1655         * Scripts/webkitpy/common/system/executive.py:
1656         (Executive.running_pids):
1657         * Scripts/webkitpy/common/system/executive_mock.py:
1658         (MockExecutive.running_pids):
1659         * Scripts/webkitpy/common/system/executive_unittest.py:
1660         (ExecutiveTest.serial_test_running_pids):
1661         * Scripts/webkitpy/port/darwin.py:
1662         (DarwinPort.check_for_leaks):
1663         * Scripts/webkitpy/port/leakdetector.py:
1664         (LeakDetector.check_for_leaks):
1665         - This was the hack attached to Bug 193772.
1666
1667         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1668         (+[WebKitTestRunnerEvent mouseLocation]):
1669         - This works around a crash on an internal build.
1670
1671 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1672
1673         Fix the build after r243354
1674         https://bugs.webkit.org/show_bug.cgi?id=196138
1675         <rdar://problem/49145951>
1676
1677         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1678         (TEST):
1679         * TestWebKitAPI/ios/UIKitSPI.h:
1680
1681 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1682
1683         Adopt UIWKDocumentContext
1684         https://bugs.webkit.org/show_bug.cgi?id=196040
1685         <rdar://problem/48642440>
1686
1687         Reviewed by Ryosuke Niwa.
1688
1689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1690         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1691         (makeRequest):
1692         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1693         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1694         (applyStyle):
1695         (TEST):
1696         Add tests for UIWKDocumentContext.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1699         (TEST):
1700         (recursiveFindWKContentView): Deleted.
1701         * TestWebKitAPI/cocoa/TestWKWebView.h:
1702         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1703         (recursiveFindWKContentView):
1704         (-[TestWKWebView wkContentView]):
1705         * TestWebKitAPI/ios/UIKitSPI.h:
1706         Share the WKContentView finding code between tests.
1707
1708 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1709
1710         [iOS WK2] Turn on async overflow scrolling by default
1711         https://bugs.webkit.org/show_bug.cgi?id=196011
1712         rdar://problem/48453859
1713
1714         Reviewed by Antti Koivisto.
1715         
1716         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1717         since so many basic layout tests have different results when compositing is triggered for
1718         overflow.
1719         
1720         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1721
1722         * WebKitTestRunner/TestController.cpp:
1723         (WTR::TestController::resetPreferencesToConsistentValues):
1724
1725 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1726
1727         [ews-build] Retry API test in case of failures
1728         https://bugs.webkit.org/show_bug.cgi?id=196004
1729
1730         Reviewed by Lucas Forschler.
1731
1732         * BuildSlaveSupport/ews-build/steps.py:
1733         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1734         (CompileWebKitToT.doStepIf): Ditto.
1735         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1736         (ReRunAPITests): Re-run API tests.
1737         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1738         (RunAPITestsWithoutPatch): Run API tests without patch.
1739         (RunAPITestsWithoutPatch.doStepIf):
1740         (RunAPITestsWithoutPatch.hideStepIf):
1741         (RunAPITestsWithoutPatch.evaluateCommand):
1742         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1743         (AnalyzeAPITestsResults.start):
1744         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1745         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1746         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1747         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1748
1749 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-build] Update queues configurations
1752         https://bugs.webkit.org/show_bug.cgi?id=196074
1753
1754         Reviewed by Dewei Zhu.
1755
1756         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1757         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1758
1759 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1760
1761         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1762         https://bugs.webkit.org/show_bug.cgi?id=195680
1763         <rdar://problem/48903534>
1764
1765         Unreviewed infrastructure fix.
1766
1767         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1768         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1769
1770 2019-03-21  Andy Estes  <aestes@apple.com>
1771
1772         [iOS] Apple Pay should be available in documents with no user agent scripts
1773         https://bugs.webkit.org/show_bug.cgi?id=196061
1774         <rdar://problem/48649391>
1775
1776         Reviewed by Brady Eidson.
1777
1778         Added API tests and related infrastructure.
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1782         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1783         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1786         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1787         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1788         * TestWebKitAPI/cocoa/TestProtocol.mm:
1789         (-[TestProtocol startLoading]):
1790         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1791         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1792         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1793         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1794
1795 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1796
1797         REGRESSSION (r243297): webkitpy tests broken
1798         https://bugs.webkit.org/show_bug.cgi?id=196108
1799
1800         Reviewed by Aakash Jain.
1801
1802         r243297 updated contributors.json, which broke a few unit tests.
1803
1804         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1805         (IRCCommandTest.test_whois):
1806         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1807
1808 2019-03-21  Chris Dumez  <cdumez@apple.com>
1809
1810         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1811         https://bugs.webkit.org/show_bug.cgi?id=196041
1812         <rdar://problem/49083230>
1813
1814         Reviewed by Alex Christensen.
1815
1816         Add API test coverage.
1817
1818         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1819         (TEST):
1820
1821 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1822
1823         Add SPI to inform applications of WKContentRuleList actions
1824         https://bugs.webkit.org/show_bug.cgi?id=195965
1825         <rdar://problem/42664365>
1826
1827         Reviewed by Geoff Garen.
1828
1829         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1830         (TestWebKitAPI::allActionsForResourceLoad):
1831         (TestWebKitAPI::testRequest):
1832         (TestWebKitAPI::TEST_F):
1833         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1834         (Notification::description):
1835         (Notification::operator== const):
1836         (toVector):
1837         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1838         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1839         (makeContentRuleList):
1840         (TEST):
1841         (makeWarnContentRuleList): Deleted.
1842
1843 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1844
1845         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1846         https://bugs.webkit.org/show_bug.cgi?id=196088
1847
1848         Reviewed by Brian Burg.
1849
1850         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1851         Support checks when only one platform is specified. Also deprecate macosx() and
1852         force the use of macos() instead.
1853
1854         * Scripts/webkitpy/style/checkers/cpp.py:
1855         (check_min_versions_of_wk_api_available):
1856         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1857         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1858
1859 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1860
1861         Update status inactive committers' status to 'contributor'.
1862
1863         * Scripts/webkitpy/common/config/contributors.json:
1864
1865 2019-03-21  Xan Lopez  <xan@igalia.com>
1866
1867         [JSC][x86] Drop support for x87 floating point
1868         https://bugs.webkit.org/show_bug.cgi?id=194853
1869
1870         Reviewed by Don Olmstead.
1871
1872         Force SSE2 on x86/32bit builds.
1873
1874         * Scripts/webkitdirs.pm:
1875         (generateBuildSystemFromCMakeProject):
1876
1877 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1878
1879         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1880         https://bugs.webkit.org/show_bug.cgi?id=196073
1881
1882         Reviewed by Michael Catanzaro.
1883
1884         Add test cases to check functions and constructors with no arguments but receiving user data.
1885
1886         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1887         (checkUserData):
1888         (testJSCFunction):
1889         (fooCreateWithUserData):
1890         (testJSCClass):
1891
1892 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1895
1896         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1897
1898         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1899
1900 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1901
1902         [GTK][WPE] Add API to provide geolocation information
1903         https://bugs.webkit.org/show_bug.cgi?id=195940
1904
1905         Reviewed by Michael Catanzaro.
1906
1907         Add a new test to check the new API.
1908
1909         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1910         (testGeolocationManagerCurrentPosition):
1911         (testGeolocationManagerWatchPosition):
1912         (beforeAll):
1913         (afterAll):
1914         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1915         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1916         (beforeAll): Ditto.
1917         * TestWebKitAPI/glib/CMakeLists.txt:
1918
1919 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1920
1921         [GLib] Returning G_TYPE_OBJECT from a method does not work
1922         https://bugs.webkit.org/show_bug.cgi?id=195574
1923
1924         Reviewed by Michael Catanzaro.
1925
1926         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1927
1928         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1929         (getGFile):
1930         (getParent):
1931         (createGString):
1932         (getGString):
1933         (getGStringCopyWillRaise):
1934         (getGStringCopy):
1935         (getGStringStr):
1936         (getGStringLen):
1937         (freeGString):
1938         (testJSCClass):
1939
1940 2019-03-20  Saam Barati  <sbarati@apple.com>
1941
1942         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1943         https://bugs.webkit.org/show_bug.cgi?id=195721
1944
1945         Reviewed by Filip Pizlo.
1946
1947         * Scripts/run-javascriptcore-tests:
1948
1949 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1950
1951         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1952         https://bugs.webkit.org/show_bug.cgi?id=196049
1953
1954         Reviewed by Tim Horton.
1955
1956         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1957         overflow scrolling in general, so rename it.
1958
1959         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1960
1961 2019-03-20  Daniel Bates  <dabates@apple.com>
1962
1963         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1964         https://bugs.webkit.org/show_bug.cgi?id=196031
1965         <rdar://problem/49078172>
1966
1967         Reviewed by Tim Horton.
1968
1969         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1970         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1971         same code path used when the Done button is pressed to dismiss the <select> picker.
1972
1973         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1974         (TestWebKitAPI::TEST):
1975
1976 2019-03-20  Chris Dumez  <cdumez@apple.com>
1977
1978         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1979         https://bugs.webkit.org/show_bug.cgi?id=196029
1980         <rdar://problem/48954651>
1981
1982         Reviewed by Tim Horton.
1983
1984         Add API test coverage.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1987
1988 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-build] Improve failure summary string for ApplyPatch step
1991         https://bugs.webkit.org/show_bug.cgi?id=195995
1992
1993         Reviewed by Alexey Proskuryakov.
1994
1995         * BuildSlaveSupport/ews-build/steps.py:
1996         (ApplyPatch.getResultSummary): Override getResultSummary.
1997
1998 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1999
2000         AX: Implement support for new meter ARIA role
2001         https://bugs.webkit.org/show_bug.cgi?id=195966
2002
2003         Reviewed by Chris Fleizach.
2004
2005         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2006         to AXLevelIndicator.
2007
2008         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2009
2010 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2011
2012         [WebAuthN] Implement FIDO AppID extension
2013         https://bugs.webkit.org/show_bug.cgi?id=143491
2014         <rdar://problem/48298273>
2015
2016         Reviewed by Brent Fulgham.
2017
2018         Add a test that covers the new flag of convertToU2fSignCommand.
2019
2020         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2021         (TestWebKitAPI::TEST):
2022         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2023         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2024         (TestWebKitAPI::TEST):
2025
2026 2019-03-19  Keith Rollin  <krollin@apple.com>
2027
2028         Add support for more platforms to generate-xcfilelists
2029         https://bugs.webkit.org/show_bug.cgi?id=195977
2030
2031         Reviewed by Alexey Proskuryakov.
2032
2033         generate-xcfilelists incorrectly complains when involved with building
2034         WebKit for iphonesimulator:
2035
2036             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2037             …
2038             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2039
2040         Address this by teaching generate-xcfilelists about more platforms.
2041
2042         * Scripts/generate-xcfilelists:
2043
2044 2019-03-19  John Wilander  <wilander@apple.com>
2045
2046         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2047         https://bugs.webkit.org/show_bug.cgi?id=195923
2048         <rdar://problem/49001272>
2049
2050         Reviewed by Alex Christensen.
2051
2052         This patch does the following to the TestRunner:
2053         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2054         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2055         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2056
2057         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2058         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2059         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2060         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2061         * WebKitTestRunner/TestController.cpp:
2062         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2063         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2064         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2065         * WebKitTestRunner/TestController.h:
2066         * WebKitTestRunner/TestInvocation.cpp:
2067         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2068
2069 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2070
2071         [CMake] Support more clang and gcc sanitizers
2072         https://bugs.webkit.org/show_bug.cgi?id=195956
2073
2074         Reviewed by Michael Catanzaro.
2075
2076         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2077
2078 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-build] Improve summary for PrintConfiguration step
2081         https://bugs.webkit.org/show_bug.cgi?id=195945
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-build/steps.py:
2086         (PrintConfiguration.getResultSummary): Override getResultSummary.
2087
2088 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2089
2090         [ews-build] Improve summary for CheckOutSource step
2091         https://bugs.webkit.org/show_bug.cgi?id=195963
2092
2093         Reviewed by Lucas Forschler.
2094
2095         * BuildSlaveSupport/ews-build/steps.py:
2096         (CheckOutSource.getResultSummary):
2097
2098 2019-03-19  Daniel Bates  <dabates@apple.com>
2099
2100         [iOS] Focus not preserved when switching between tabs
2101         https://bugs.webkit.org/show_bug.cgi?id=195820
2102         <rdar://problem/43614450>
2103
2104         Reviewed by Brent Fulgham.
2105
2106         Add tests to ensure that we restore focus when resigning and becoming first responder.
2107
2108         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2109         (TestWebKitAPI::TEST):
2110
2111 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2112
2113         Make WTFLogChannelState and WTFLogLevel enum classes
2114         https://bugs.webkit.org/show_bug.cgi?id=195904
2115
2116         Reviewed by Eric Carlson.
2117
2118         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2119         (TestWebKitAPI::TEST_F):
2120
2121 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2122
2123         [GStreamer][EME] Backported mssdemux protection data crash fix
2124         https://bugs.webkit.org/show_bug.cgi?id=195918
2125
2126         Reviewed by Philippe Normand.
2127
2128         * gstreamer/jhbuild.modules:
2129         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2130
2131 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2132
2133         Unreviewed, rolling out r243132.
2134
2135         Broke GTK build
2136
2137         Reverted changeset:
2138
2139         "Make WTFLogChannelState and WTFLogLevel enum classes"
2140         https://bugs.webkit.org/show_bug.cgi?id=195904
2141         https://trac.webkit.org/changeset/243132
2142
2143 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2144
2145         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2146
2147         * Scripts/webkitdirs.pm:
2148         (builtDylibPathForName): Adjust the shared library name that's changed
2149         with the API version bump in r243073.
2150
2151 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2152
2153         Make WTFLogChannelState and WTFLogLevel enum classes
2154         https://bugs.webkit.org/show_bug.cgi?id=195904
2155
2156         Reviewed by Eric Carlson.
2157
2158         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2159         (TestWebKitAPI::TEST_F):
2160
2161 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2162
2163         Disable flaky test added in r2431100
2164         https://webkit.org/b/195785
2165
2166         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2167         (TestWebKitAPI::TEST):
2168         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2169
2170 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2171
2172         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2173         https://bugs.webkit.org/show_bug.cgi?id=195916
2174
2175         Reviewed by Tim Horton.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2178         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2179
2180 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2181
2182         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2183
2184         * Scripts/webkitpy/common/config/contributors.json:
2185
2186 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2187
2188         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2189         https://bugs.webkit.org/show_bug.cgi?id=195785
2190
2191         Reviewed by Geoffrey Garen.
2192
2193         * TestWebKitAPI/TCPServer.cpp: Added.
2194         (TestWebKitAPI::TCPServer::TCPServer):
2195         (TestWebKitAPI::TCPServer::~TCPServer):
2196         (TestWebKitAPI::TCPServer::socketBindListen):
2197         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2198         * TestWebKitAPI/TCPServer.h: Added.
2199         (TestWebKitAPI::TCPServer::port const):
2200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2201         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2202         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2203         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2204         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2205         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2206         (TestWebKitAPI::respondSlowly):
2207         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2208         (TestWebKitAPI::downloadAtRate):
2209         (TestWebKitAPI::TEST):
2210
2211 2019-03-18  Saam Barati  <sbarati@apple.com>
2212
2213         Add a plan file for JetStream 2
2214         https://bugs.webkit.org/show_bug.cgi?id=190734
2215
2216         Reviewed by Mark Lam.
2217
2218         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2219
2220 2019-03-18  Chris Dumez  <cdumez@apple.com>
2221
2222         Delay WebProcess launch until a load is triggered in a Web view
2223         https://bugs.webkit.org/show_bug.cgi?id=195758
2224         <rdar://problem/48126013>
2225
2226         Reviewed by Geoff Garen.
2227
2228         Add API test coverage. Also update some existing API tests to not expect
2229         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2230
2231         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2232         (TestWebKitAPI::TEST):
2233         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2234         (TestWebKitAPI::TEST):
2235         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2236         (TEST):
2237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2238         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2239         (TEST):
2240         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2241         (TEST):
2242         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2243
2244 2019-03-18  Xan Lopez  <xan@igalia.com>
2245
2246         [CMake] Prevent potential warning when determining $architecture
2247         https://bugs.webkit.org/show_bug.cgi?id=195891
2248
2249         Reviewed by Michael Catanzaro.
2250
2251         It's possible for generateBuildSystemForCMakeProject to be called
2252         before determineArchitecture() is ever called. This will make the
2253         first eq check with $architecture to be bogus (and print a
2254         warning). Change that to an eq check with architecture(), which
2255         implicitly calls determineArchitecture() if needed, and change all
2256         the other similar cases in the method in the same way to prevent
2257         future bugs like this one.
2258
2259         * Scripts/webkitdirs.pm:
2260         (generateBuildSystemFromCMakeProject):
2261
2262 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2263
2264         [WPE] Tarballs generated with “make dist” cannot build documentation
2265         https://bugs.webkit.org/show_bug.cgi?id=195885
2266
2267         Reviewed by Carlos Garcia Campos.
2268
2269         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2270
2271 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2272
2273         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2274         https://bugs.webkit.org/show_bug.cgi?id=195883
2275
2276         Reviewed by Carlos Garcia Campos.
2277
2278         * gtkdoc/gtkdoc.py:
2279         (GTKDoc._run_command): When commands fail to run, include the full command line for
2280         the program invocation and the output it has generated on the standard error stream.
2281
2282 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2283
2284         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2285         https://bugs.webkit.org/show_bug.cgi?id=195786
2286
2287         Reviewed by Philippe Normand.
2288
2289         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2290         * wpe/jhbuild.modules: Ditto.
2291
2292 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-build] Don't run clean builds on EWS builders
2295         https://bugs.webkit.org/show_bug.cgi?id=195851
2296
2297         Reviewed by Geoffrey Garen.
2298
2299         * BuildSlaveSupport/ews-build/factories.py:
2300
2301 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2302
2303         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2304         https://bugs.webkit.org/show_bug.cgi?id=195849
2305
2306         Reviewed by Chris Dumez.
2307
2308         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2309
2310         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2311         (runWebsiteDataStoreCustomPaths):
2312
2313 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2314
2315         webkitpy: Upload test results
2316         https://bugs.webkit.org/show_bug.cgi?id=195755
2317         <rdar://problem/48896182>
2318
2319         Reviewed by Aakash Jain.
2320
2321         Establish a new format for uploading results that is not tied to layout tests, apply
2322         that format to webkitpy tests.
2323
2324         * Scripts/webkitpy/common/checkout/scm/git.py:
2325         (Git.native_branch): Return what branch the current checkout is on.
2326         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2327         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2328         * Scripts/webkitpy/common/checkout/scm/svn.py:
2329         (SVN.native_branch): Ditto.
2330         * Scripts/webkitpy/common/system/platforminfo.py:
2331         (PlatformInfo.build_version): Return a build version for Mac.
2332         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2333         (MockPlatformInfo.__init__):
2334         (MockPlatformInfo.build_version):
2335         * Scripts/webkitpy/results: Added.
2336         * Scripts/webkitpy/results/__init__.py: Added.
2337         * Scripts/webkitpy/results/options.py: Added.
2338         (upload_options): OptParse list for upload options.
2339         * Scripts/webkitpy/results/upload.py: Added.
2340         (Upload): Class which enforces the upload format expected by the results server.
2341         (Upload.Expectations):
2342         (Upload.create_configuration):
2343         (Upload.create_commit):
2344         (Upload.create_details):
2345         (Upload.create_run_stats):
2346         (Upload.create_test_result):
2347         (Upload.__init__):
2348         (Upload.Encoder): Encode Upload object as json.
2349         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2350         * Scripts/webkitpy/results/upload_unittest.py: Added.
2351         * Scripts/webkitpy/test/main.py:
2352         (Tester._parse_args): Add upload arguments.
2353         (Tester._run_tests): Allow results to be uploaded.
2354         * Scripts/webkitpy/test/runner.py:
2355         (Runner.__init__): Record which tests were run, rather than just counting them.
2356         (Runner.handle):
2357         * Scripts/webkitpy/test/runner_unittest.py:
2358         (RunnerTest.test_run):
2359         * Scripts/webkitpy/thirdparty/__init__.py:
2360         (AutoinstallImportHook.find_module): Add requests auto-install.
2361         (AutoinstallImportHook._install_requests):
2362         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2363         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2364
2365 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2366
2367         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2368         https://bugs.webkit.org/show_bug.cgi?id=195810
2369
2370         Reviewed by Tim Horton.
2371
2372         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2373         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2374         ending certain layout tests.
2375
2376         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2377         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2378         (-[TestRunnerWKWebView dealloc]):
2379         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2380
2381         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2382         helper method when destroying the web view, and when resetting state between tests.
2383
2384         * WebKitTestRunner/ios/TestControllerIOS.mm:
2385         (WTR::TestController::platformResetStateToConsistentValues):
2386
2387         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2388
2389 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2390
2391         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2392         https://bugs.webkit.org/show_bug.cgi?id=190350
2393         <rdar://problem/45089503>
2394
2395         Reviewed by Geoffrey Garen.
2396
2397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2398         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2399         (TEST):
2400         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2401         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2402         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2403         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2404         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2405         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2406         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2407         (runTest):
2408         (createDirectories):
2409         (TEST):
2410         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2411         (TEST):
2412         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2413         (TEST):
2414
2415 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2416
2417         Add support to WebPage for getting the contents as an attributed string.
2418         https://bugs.webkit.org/show_bug.cgi?id=195636
2419         rdar://problem/45055697
2420
2421         Reviewed by Tim Horton.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2424         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2425
2426 2019-03-15  Chris Dumez  <cdumez@apple.com>
2427
2428         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2429         https://bugs.webkit.org/show_bug.cgi?id=195747
2430
2431         Reviewed by Geoff Garen.
2432
2433         Add API test coverage.
2434
2435         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2436
2437 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2438
2439         Unreviewed, rolling out r242952.
2440
2441         Causing API failures on iOS Simulator
2442
2443         Reverted changeset:
2444
2445         "[PSON] Make sure the WebProcessCache is leverage when
2446         relaunching a process after termination"
2447         https://bugs.webkit.org/show_bug.cgi?id=195747
2448         https://trac.webkit.org/changeset/242952
2449
2450 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2451
2452         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2453         https://bugs.webkit.org/show_bug.cgi?id=195740
2454
2455         Reviewed by Ross Kirsling.
2456
2457         window.open doesn't work for WebKitBrowserWindow because it is not
2458         implemented yet.
2459
2460         1. Implemented createNewPage callback of WKPageUIClient.
2461         2. Changed MainWindow to take a BrowserWindow factory function
2462           instead of BrowserWindowType to be flexible to create
2463           BrowserWindow with extra settings.
2464         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2465           because it is not relevant with MainWindow anymore.
2466
2467         * MiniBrowser/win/Common.cpp:
2468         (parseCommandLine):
2469         * MiniBrowser/win/Common.h:
2470         (CommandLineOptions::CommandLineOptions):
2471         * MiniBrowser/win/MainWindow.cpp:
2472         (MainWindow::MainWindow):
2473         (MainWindow::create):
2474         (MainWindow::init):
2475         (MainWindow::WndProc):
2476         * MiniBrowser/win/MainWindow.h:
2477         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2478         (PrintWebUIDelegate::createWebViewWithRequest):
2479         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2480         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2481         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2482         (WebKitBrowserWindow::updateProxySettings):
2483         (WebKitBrowserWindow::createNewPage):
2484         * MiniBrowser/win/WebKitBrowserWindow.h:
2485         * MiniBrowser/win/WinMain.cpp:
2486         (wWinMain):
2487
2488 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2489
2490         Make it possible to test scrolling tree layer manipulation more easily
2491         https://bugs.webkit.org/show_bug.cgi?id=195780
2492
2493         Reviewed by Tim Horton.
2494         
2495         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2496         cuts off communication of scrolling tree scrolls back to the web process
2497         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2498         allows tests to trigger scrolls which run the scrolling tree layer positioning
2499         logic, but never get another commit from the web process that might mask
2500         scrolling tree bugs.
2501         
2502         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2503         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2504         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2505
2506         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2507         (WTR::UIScriptController::scrollUpdatesDisabled const):
2508         (WTR::UIScriptController::setScrollUpdatesDisabled):
2509         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2510         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2511         (WTR::UIScriptController::scrollUpdatesDisabled const):
2512         (WTR::UIScriptController::setScrollUpdatesDisabled):
2513         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2514         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2515         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2516         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2517         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2518         * WebKitTestRunner/ios/TestControllerIOS.mm:
2519         (WTR::TestController::platformResetStateToConsistentValues):
2520         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2521         (WTR::UIScriptController::scrollUpdatesDisabled const):
2522         (WTR::UIScriptController::setScrollUpdatesDisabled):
2523
2524 2019-03-14  Youenn Fablet  <youenn@apple.com>
2525
2526         Move IDB storage in private browsing mode to NetworkProcess
2527         https://bugs.webkit.org/show_bug.cgi?id=195602
2528
2529         Reviewed by Brady Eidson.
2530
2531         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2532         (TEST):
2533
2534 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2535
2536         [ews-build] Make descriptionDone messages more readable
2537         https://bugs.webkit.org/show_bug.cgi?id=195760
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * BuildSlaveSupport/ews-build/steps.py:
2542         * BuildSlaveSupport/ews-build/steps_unittest.py:
2543
2544 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2545
2546         [ews-build] Generate status-bubble hover-over messages
2547         https://bugs.webkit.org/show_bug.cgi?id=195680
2548
2549         Reviewed by Lucas Forschler.
2550
2551         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2552         (StatusBubble):
2553         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2554         on hover-over.
2555         (StatusBubble._iso_time):
2556         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2557         hover-over message.
2558         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2559
2560 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2561
2562         [ews-app] Gracefully handle the case when state_string is None
2563         https://bugs.webkit.org/show_bug.cgi?id=195753
2564
2565         Reviewed by Lucas Forschler.
2566
2567         * BuildSlaveSupport/ews-app/ews/models/build.py:
2568         * BuildSlaveSupport/ews-app/ews/models/step.py:
2569
2570 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2571
2572         [ews-app] Status bubble display pending for currently running build step
2573         https://bugs.webkit.org/show_bug.cgi?id=195744
2574
2575         Reviewed by Lucas Forschler.
2576
2577         * BuildSlaveSupport/ews-build/events.py:
2578         (Events.stepStarted): If state_string is pending, replace it with step name.
2579
2580 2019-03-14  Chris Dumez  <cdumez@apple.com>
2581
2582         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2583         https://bugs.webkit.org/show_bug.cgi?id=195750
2584
2585         Reviewed by Geoffrey Garen.
2586
2587         Add API test coverage.
2588
2589         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2590         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2591         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2592         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2593
2594 2019-03-14  Chris Dumez  <cdumez@apple.com>
2595
2596         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2597         https://bugs.webkit.org/show_bug.cgi?id=195747
2598
2599         Reviewed by Geoff Garen.
2600
2601         Add API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2604
2605 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2606
2607         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2608         https://bugs.webkit.org/show_bug.cgi?id=195725
2609         <rdar://problem/48545062>
2610
2611         Reviewed by Tim Horton.
2612
2613         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2614         handler is nil.
2615
2616         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2617         (TestWebKitAPI::TEST):
2618
2619 2019-03-13  Sam Weinig  <sam@webkit.org>
2620
2621         Add utility function to allow easy reverse range-based iteration of a container
2622         https://bugs.webkit.org/show_bug.cgi?id=195542
2623
2624         Reviewed by Antti Koivisto.
2625
2626         * TestWebKitAPI/CMakeLists.txt:
2627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2628         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2629         (TestWebKitAPI::TEST):
2630         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2631
2632 2019-03-13  Chris Dumez  <cdumez@apple.com>
2633
2634         Use a ServiceWorker process per registrable domain
2635         https://bugs.webkit.org/show_bug.cgi?id=195649
2636
2637         Reviewed by Youenn Fablet.
2638
2639         Update API test coverage.
2640
2641         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2642
2643 2019-03-13  Chris Dumez  <cdumez@apple.com>
2644
2645         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2646         https://bugs.webkit.org/show_bug.cgi?id=195684
2647         <rdar://problem/48294714>
2648
2649         Reviewed by Antti Koivisto.
2650
2651         Add API test coverage.
2652
2653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2654
2655 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2656
2657         [ews-app] Remove unused patch view
2658         https://bugs.webkit.org/show_bug.cgi?id=195669
2659
2660         Reviewed by Lucas Forschler.
2661
2662         * BuildSlaveSupport/ews-app/ews/urls.py:
2663         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2664
2665 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2666
2667         [ews-app] Use Buildbot result code variables
2668         https://bugs.webkit.org/show_bug.cgi?id=195668
2669
2670         Reviewed by Alexey Proskuryakov.
2671
2672         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2673         (Buildbot): Added Buildbot result code variables.
2674         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2675         (StatusBubble._build_bubble): Used Buildbot result code variables.
2676
2677 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2678
2679         [Flatpak] Expand submodule recursively
2680         https://bugs.webkit.org/show_bug.cgi?id=195672
2681
2682         Building WPE with flatpak was impossible without that as it was raising an exception.
2683         Also update wpebackend-fdo to match what is built in jhbuild
2684
2685         Reviewed by Philippe Normand.
2686
2687         * flatpak/flatpakutils.py:
2688         (expand_submodules_recurse):
2689         (expand_manifest):
2690         * flatpak/org.webkit.WPEModules.yaml:
2691
2692 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2693
2694         [ews-app] status bubble should be hidden for certain builds
2695         https://bugs.webkit.org/show_bug.cgi?id=194597
2696
2697         Reviewed by Dewei Zhu.
2698
2699         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2700         (StatusBubble._build_bubble):
2701         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2702         because the patch didn't have relevant changes.
2703         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2704         in production yet.
2705
2706 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2707
2708         [Win] Fix a slew of simple clang-cl warnings.
2709         https://bugs.webkit.org/show_bug.cgi?id=195652
2710
2711         Reviewed by Don Olmstead.
2712
2713         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2714         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2715
2716 2019-03-12  Justin Fan  <justin_fan@apple.com>
2717
2718         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2719         https://bugs.webkit.org/show_bug.cgi?id=195518
2720         <rdar://problem/46322356>
2721
2722         Reviewed by Myles C. Maxfield.
2723
2724         * DumpRenderTree/DerivedSources-input.xcfilelist:
2725         * DumpRenderTree/DerivedSources-output.xcfilelist:
2726
2727 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2728
2729         Unreviewed, rolling out r242825.
2730         https://bugs.webkit.org/show_bug.cgi?id=195648
2731
2732         "Broke webkitpy tests with my change to
2733         lldb_dump_class_layout.py" (Requested by rmorisset on
2734         #webkit).
2735
2736         Reverted changeset:
2737
2738         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2739         classes with suspicious padding"
2740         https://bugs.webkit.org/show_bug.cgi?id=195573
2741         https://trac.webkit.org/changeset/242825
2742
2743 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews-build] Show status bubbles while the patch is waiting in queue
2746         https://bugs.webkit.org/show_bug.cgi?id=195618
2747
2748         Reviewed by Lucas Forschler.
2749
2750         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2751         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2752         enabled in initial deployment.
2753         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2754         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2755         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2756         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2757         (StatusBubble._build_bubbles_for_patch):
2758
2759 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2760
2761         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2762         https://bugs.webkit.org/show_bug.cgi?id=195573
2763
2764         Reviewed by Simon Fraser.
2765
2766         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2767
2768         * Scripts/dump-class-layout:
2769         (main):
2770         * lldb/lldb_dump_class_layout.py:
2771         (ClassLayout.__init__):
2772         (ClassLayout._compute_padding_recursive):
2773         (LLDBDebuggerInstance.dump_layout_for_classname):
2774         (LLDBDebuggerInstance):
2775         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2776         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2777
2778 2019-03-12  Chris Dumez  <cdumez@apple.com>
2779
2780         Device Orientation access permission should be denied unless explicitly granted by the client
2781         https://bugs.webkit.org/show_bug.cgi?id=195625
2782
2783         Reviewed by Youenn Fablet.
2784
2785         add API test coverage.
2786
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2789         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2790         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2791         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2792         (runDeviceOrientationTest):
2793         (TEST):
2794         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2795         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2796
2797 2019-03-12  Jer Noble  <jer.noble@apple.com>
2798
2799         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2800         https://bugs.webkit.org/show_bug.cgi?id=195137
2801         <rdar://problem/48810307>
2802
2803         Reviewed by Eric Carlson.
2804
2805         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2806         (TestWebKitAPI::TEST):
2807
2808 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2809
2810         [ews-build] Change urls from uat to production
2811         https://bugs.webkit.org/show_bug.cgi?id=195566
2812
2813         Reviewed by Lucas Forschler.
2814
2815         * BuildSlaveSupport/ews-app/ews/config.py:
2816         * BuildSlaveSupport/ews-build/events.py:
2817         * BuildSlaveSupport/ews-build/steps.py:
2818
2819 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] change max_builds for local-worker to 1
2822         https://bugs.webkit.org/show_bug.cgi?id=195568
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/loadConfig.py:
2827
2828 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2829
2830         Fix the build
2831
2832         * TestRunnerShared/spi/PencilKitTestSPI.h:
2833         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2834
2835 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2836
2837         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2838         https://bugs.webkit.org/show_bug.cgi?id=194131
2839
2840         Reviewed by Michael Catanzaro.
2841
2842         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2843         (uriChanged):
2844         (testUnfinishedSubresourceLoad):
2845         (serverCallback):
2846         (beforeAll):
2847
2848 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2849
2850         WTF::Expected should use std::addressof instead of operator&
2851         https://bugs.webkit.org/show_bug.cgi?id=195604
2852
2853         Reviewed by Myles Maxfield.
2854
2855         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2856         (TestWebKitAPI::Unique::Unique):
2857         (TestWebKitAPI::Unique::operator&):
2858         (TestWebKitAPI::TEST):
2859
2860 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2861
2862         Add Optional to Forward.h.
2863         https://bugs.webkit.org/show_bug.cgi?id=195586
2864
2865         Reviewed by Darin Adler.
2866
2867         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2868         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2869         Remove unnecessary includes from headers.
2870
2871 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2872
2873         Add testing API to hit-test and scroll overflow scrollers
2874         https://bugs.webkit.org/show_bug.cgi?id=195278
2875
2876         Reviewed by Antti Koivisto.
2877         
2878         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2879         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2880         
2881         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2882
2883         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2884         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2885         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2886         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2887         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2888         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2889         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2890         (WTR::enclosingScrollViewIncludingSelf):
2891         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2892
2893 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2894
2895         API test WebKit.RequestTextInputContext fails on iOS
2896         https://bugs.webkit.org/show_bug.cgi?id=195585
2897
2898         Reviewed by Wenson Hsieh and Simon Fraser.
2899
2900         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2901         (applyStyle):
2902         (TEST):
2903         Add a viewport, so that the coordinates match up on iOS.
2904         Scroll by moving the UIScrollView's contentOffset.
2905
2906 2019-03-11  Chris Dumez  <cdumez@apple.com>
2907
2908         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2909         https://bugs.webkit.org/show_bug.cgi?id=195506
2910         <rdar://problem/48733477>
2911
2912         Reviewed by Alex Christensen.
2913
2914         Add API test coverage.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2917
2918 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2919
2920         Adding myself to contributors.json
2921
2922         Unreviewed, addming myself to contributors.json .
2923
2924         * Scripts/webkitpy/common/config/contributors.json:
2925
2926 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2927
2928         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2929         https://bugs.webkit.org/show_bug.cgi?id=195511
2930         <rdar://problem/44873269>
2931
2932         Reviewed by Darin Adler.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2935         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2936         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2937         (TEST_F):
2938
2939 2019-03-11  Chris Dumez  <cdumez@apple.com>
2940
2941         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2942         https://bugs.webkit.org/show_bug.cgi?id=195561
2943
2944         Reviewed by Youenn Fablet.
2945
2946         Make sure the JS in the test requests for permission to receive device orientation events.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2949
2950 2019-03-11  Youenn Fablet  <youenn@apple.com>
2951
2952         Allow storage quota increase by default in WTR
2953         https://bugs.webkit.org/show_bug.cgi?id=195541
2954
2955         Reviewed by Geoffrey Garen.
2956
2957         Allow storage quota increase by default in WTR.
2958         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2959         Use this for tests that explicitly need cache increase.
2960
2961         Instead of increasing quota by 2, make sure the next request is
2962         granted by adding all given parameters.
2963
2964         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2966         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2967         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2968         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2969         * WebKitTestRunner/TestController.cpp:
2970         (WTR::TestController::setAllowStorageQuotaIncrease):
2971         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2972         * WebKitTestRunner/TestController.h:
2973         * WebKitTestRunner/TestInvocation.cpp:
2974         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2975         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2976         (WTR::TestController::cocoaResetStateToConsistentValues):
2977         (WTR::TestController::setAllowStorageQuotaIncrease):
2978         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2979         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2980         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2981
2982 2019-03-11  Xan Lopez  <xan@igalia.com>
2983
2984         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2985         https://bugs.webkit.org/show_bug.cgi?id=194147
2986
2987         Reviewed by Michael Saboff.
2988
2989         To make --32-bit work correctly on Linux/64bit we need to:
2990
2991         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2992         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2993         unfortunately CMake only allows us to do this during
2994         crosscompilation, which is overkill here.
2995         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2996         pkg-config detection module uses the x86 .pc files instead of the
2997         x86_64 ones.
2998         - Set the -m32 flags for the compiler.
2999
3000         * Scripts/webkitdirs.pm:
3001         (generateBuildSystemFromCMakeProject):
3002
3003 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3004
3005         Add MotionMark-1.1 plan file for run-benchmark script.
3006         https://bugs.webkit.org/show_bug.cgi?id=195481
3007
3008         Rubber-stamped by Darin Adler.
3009
3010         Run-benchmark script should support MontionMark-1.1.
3011
3012         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3013
3014 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Add support for submit-to-ews url
3017         https://bugs.webkit.org/show_bug.cgi?id=195477
3018
3019         Reviewed by Lucas Forschler.
3020
3021         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3022         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3023         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3024         * BuildSlaveSupport/ews-app/ews/urls.py:
3025         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3026
3027 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3028
3029         Unreviewed, rolling out r242688, r242643, r242624.
3030
3031         Caused multiple layout test failures and crashes on iOS and macOS.
3032
3033         Reverted changeset:
3034
3035         "requestAnimationFrame should execute before the next frame"
3036         https://bugs.webkit.org/show_bug.cgi?id=177484
3037         https://trac.webkit.org/changeset/242624/webkit
3038
3039         * Tracing/SystemTracePoints.plist:
3040
3041 2019-03-11  John Wilander  <wilander@apple.com>
3042
3043         Resource Load Statistics: Make it possible exclude localhost from classification
3044         https://bugs.webkit.org/show_bug.cgi?id=195474
3045         <rdar://problem/47520577>
3046
3047         Reviewed by Brent Fulgham.
3048
3049         This patch allows for localhost to be excluded from classification and
3050         treatment as a prevalent resource.
3051
3052         The WebKit Tools change adds a new function called
3053         testRunner.setStatisticsIsRunningTest() which can be used to control this
3054         behavior.
3055
3056         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3057         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3058         (WTR::TestRunner::setStatisticsIsRunningTest):
3059         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3060         * WebKitTestRunner/TestController.cpp:
3061         (WTR::TestController::setStatisticsIsRunningTest):
3062         * WebKitTestRunner/TestController.h:
3063         * WebKitTestRunner/TestInvocation.cpp:
3064         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3065
3066 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3067
3068         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3069         https://bugs.webkit.org/show_bug.cgi?id=195560
3070
3071         Reviewed by Lucas Forschler.
3072
3073         * BuildSlaveSupport/ews-build/master.cfg:
3074
3075 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3076
3077         Unreviewed, rolling out r242698.
3078
3079         API test crashes on bots.
3080
3081         Reverted changeset:
3082
3083         "Add a WKContentRuleList variant that uses copied memory
3084         instead of mmap'd shared memory for class A containerized
3085         apps"
3086         https://bugs.webkit.org/show_bug.cgi?id=195511
3087         https://trac.webkit.org/changeset/242698
3088
3089 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         [WPE] Enable web process sandbox
3092         https://bugs.webkit.org/show_bug.cgi?id=195169
3093
3094         Reviewed by Daniel Bates.
3095
3096         * wpe/install-dependencies:
3097         * wpe/jhbuild.modules:
3098
3099 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3100
3101         [ews-app] Use port 17000 for worker communication
3102         https://bugs.webkit.org/show_bug.cgi?id=195558
3103
3104         Reviewed by Lucas Forschler.
3105
3106         * BuildSlaveSupport/ews-build/master.cfg:
3107
3108 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3109
3110         [ews-build] unit-tests fail when passwords.json is missing
3111         https://bugs.webkit.org/show_bug.cgi?id=195557
3112
3113         Reviewed by Lucas Forschler.
3114
3115         * BuildSlaveSupport/ews-build/loadConfig.py:
3116         (loadBuilderConfig):
3117         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3118         (ConfigDotJSONTest.test_configuration):
3119         * BuildSlaveSupport/ews-build/master.cfg:
3120
3121 2019-03-11  Truitt Savell  <tsavell@apple.com>
3122
3123         Unreviewed, rolling out r242702.
3124
3125         Broke High Sierra builders.
3126
3127         Reverted changeset:
3128
3129         "Add utility function to allow easy reverse range-based
3130         iteration of a container"
3131         https://bugs.webkit.org/show_bug.cgi?id=195542
3132         https://trac.webkit.org/changeset/242702
3133
3134 2019-03-11  Sam Weinig  <sam@webkit.org>
3135
3136         Add utility function to allow easy reverse range-based iteration of a container
3137         https://bugs.webkit.org/show_bug.cgi?id=195542
3138
3139         Reviewed by Antti Koivisto.
3140
3141         * TestWebKitAPI/CMakeLists.txt:
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3144         (TestWebKitAPI::TEST):
3145         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3146
3147 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3148
3149         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3150         https://bugs.webkit.org/show_bug.cgi?id=195511
3151         <rdar://problem/44873269>
3152
3153         Reviewed by Darin Adler.
3154
3155         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3156         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3157         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3158         (TEST_F):
3159
3160 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3161
3162         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3163         https://bugs.webkit.org/show_bug.cgi?id=195499
3164
3165         Reviewed by Darin Adler.
3166
3167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3168         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3169         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3170         (-[WKWebView synchronouslyFocusTextInputContext:]):
3171         (applyStyle):
3172         (applyIframe):
3173         (TEST):
3174         Add some tests for this SPI.
3175
3176 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3177
3178         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3179         https://bugs.webkit.org/show_bug.cgi?id=181151
3180
3181         Reviewed by Don Olmstead.
3182
3183         * TestWebKitAPI/CMakeLists.txt:
3184         * TestWebKitAPI/PlatformWin.cmake:
3185         Enable TestWTF RunLoop tests in all platforms.
3186
3187         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3188         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3189         (TestWebKitAPI::DerivedOneShotTimer::fired):
3190         (TestWebKitAPI::TEST):
3191         Only a few platforms support nested RunLoop.
3192
3193         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3194         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3195
3196 2019-03-10  David Quesada  <david_quesada@apple.com>
3197
3198         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3199         https://bugs.webkit.org/show_bug.cgi?id=152480
3200
3201         Reviewed by Chris Dumez.
3202
3203         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3204         there are no additional references to the process pool besides the one held by
3205         the download, waits for the download to finish (in the sense that the
3206         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3207         measure, also check that the process pool has been deallocated at the end of the
3208         test. The test wouldn't be meaningful if the process pool were still alive.
3209
3210         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3211         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3212         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3213             The download will be canceled because the delegate does not implement the
3214             method to decide the download's destination, so this is where we know the
3215             DownloadProxyMap is done with the DownloadProxy.
3216         (TEST):
3217
3218 2019-03-08  Chris Dumez  <cdumez@apple.com>
3219
3220         Add support for Device Orientation / Motion permission API
3221         https://bugs.webkit.org/show_bug.cgi?id=195329
3222         <rdar://problem/47645367>
3223
3224         Reviewed by Geoffrey Garen.
3225
3226         Add test infrastructure to help test the Device Orientation / Motion permission API.
3227
3228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3229         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3230         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3231         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3232         * WebKitTestRunner/TestController.cpp:
3233         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3234         (WTR::TestController::createWebViewWithOptions):
3235         (WTR::TestController::resetStateToConsistentValues):
3236         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3237         * WebKitTestRunner/TestController.h:
3238         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3239         * WebKitTestRunner/TestInvocation.cpp:
3240         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3241
3242 2019-03-08  Saam barati  <sbarati@apple.com>
3243
3244         Add a compare-results script to compare benchmark results
3245         https://bugs.webkit.org/show_bug.cgi?id=195486
3246         <rdar://problem/48723397>
3247
3248         Reviewed by Geoffrey Garen.
3249
3250         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3251         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3252         to extend it to learn about our other benchmarks.
3253
3254         * Scripts/compare-results: Added.
3255         (readJSONFile):
3256         (detectJetStream2):
3257         (JetStream2Results):
3258         (detectSpeedometer2):
3259         (Speedometer2Results):
3260         (detectPLT5):
3261         (PLT5Results):
3262         (detectBenchmark):
3263         (biggerIsBetter):
3264         (ttest):
3265         (getOptions):
3266         (main):
3267
3268 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3269
3270         Ensure old tab state is cleared between iterations of run-benchmark
3271         https://bugs.webkit.org/show_bug.cgi?id=195393
3272         <rdar://problem/46885583>
3273
3274         Reviewed by Dewei Zhu.
3275
3276         a) ensure the default to restore state is not set
3277         b) terminate Safari correctly
3278         c) Set the system default to ignore Persistent State in Safari
3279
3280         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3281         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3282         (OSXBrowserDriver.prepare_env): 
3283         (OSXBrowserDriver.restore_env):
3284         (OSXBrowserDriver.close_browsers):
3285         (OSXBrowserDriver._terminate_processes):
3286         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3287         (OSXChromeDriver):
3288         (OSXChromeCanaryDriver):
3289         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3290         (OSXFirefoxDriver):
3291         (OSXFirefoxNightlyDriver):
3292         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3293         (OSXSafariDriver):
3294         (OSXSafariDriver.prepare_env):
3295
3296 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3297
3298         [GTK] Several InputMethodFilter tests are failing
3299         https://bugs.webkit.org/show_bug.cgi?id=195408
3300
3301         Reviewed by Carlos Garcia Campos.
3302
3303         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3304         Regressed in r241751.
3305         Hexadecimal values of keycodes are expressed now in upper letters.
3306         Composited characters should be cast to UTF8 strings.
3307
3308         (TestWebKitAPI::TEST):
3309
3310 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3311
3312         [GTK] Make Tools/gtkdoc python3 compatible
3313         https://bugs.webkit.org/show_bug.cgi?id=195359
3314
3315         Reviewed by Carlos Garcia Campos.
3316
3317         * gtkdoc/generate-gtkdoc:
3318         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3319         work with Python 2 and 3.
3320         (get_gtkdoc_module_paths):
3321         The iteritems() was removed in Python 3, so let's use items() that's
3322         available in Python 2 and 3.
3323         (get_generator_for_config):
3324         * gtkdoc/gtkdoc.py:
3325         (GTKDoc._run_command):
3326         The sys.stdout.write() is expecting str in Python 3 and not bytes
3327         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3328         for passing the bytes there.
3329
3330 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3331
3332         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3333         https://bugs.webkit.org/show_bug.cgi?id=195346
3334         <rdar://problem/48667048>
3335
3336         Unreviewed build fix for clang-cl.
3337
3338         * DumpRenderTree/win/DumpRenderTree.cpp:
3339         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3340
3341 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3342
3343         requestAnimationFrame should execute before the next frame
3344         https://bugs.webkit.org/show_bug.cgi?id=177484
3345
3346         Reviewed by Simon Fraser.
3347
3348         Add trace points for the page RenderingUpdate.
3349
3350         * Tracing/SystemTracePoints.plist:
3351
3352 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3353
3354         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3355         https://bugs.webkit.org/show_bug.cgi?id=195353
3356         <rdar://problem/48626394>
3357
3358         Reviewed by Simon Fraser.
3359
3360         * WebKitTestRunner/ios/TestControllerIOS.mm:
3361         (WTR::TestController::platformResetPreferencesToConsistentValues):
3362
3363 2019-03-07  John Wilander  <wilander@apple.com>
3364
3365         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3366         https://bugs.webkit.org/show_bug.cgi?id=195383
3367         <rdar://problem/48570136>
3368
3369         Reviewed by Brent Fulgham.
3370
3371         This patch adds test infrastructure to purge only script-accessible cookies,
3372         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3373
3374         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3375         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3376         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3377         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3378         * WebKitTestRunner/TestController.cpp:
3379         (WTR::TestController::statisticsDeleteCookiesForHost):
3380         * WebKitTestRunner/TestController.h:
3381         * WebKitTestRunner/TestInvocation.cpp:
3382         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3383
3384 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3385
3386         Unreviewed, rolling out r242354.
3387         https://bugs.webkit.org/show_bug.cgi?id=195402
3388
3389         breaks layout tests in all configurations (Requested by
3390         zdobersek on #webkit).
3391
3392         Reverted changeset:
3393
3394         "[WPE] Enable web process sandbox"
3395         https://bugs.webkit.org/show_bug.cgi?id=195169
3396         https://trac.webkit.org/changeset/242354
3397
3398 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3399
3400         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3401         https://bugs.webkit.org/show_bug.cgi?id=195346
3402
3403         Reviewed by Fujii Hironori.
3404
3405         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3406         (TestWebKitAPI::TEST):
3407         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3408
3409         * DumpRenderTree/win/DumpRenderTree.cpp:
3410         (findFontFallback):
3411         (addFontFallbackIfPresent):
3412         (removeFontFallbackIfPresent):
3413         (main):
3414         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3415         (TestWebKitAPI::Util::moduleDirectory):
3416         (TestWebKitAPI::Util::createInjectedBundlePath):
3417         Use wchar helpers as needed.
3418
3419 2019-03-06  Rob Buis  <rbuis@igalia.com>
3420
3421         Consider supporting the `referrerpolicy` attribute.
3422         https://bugs.webkit.org/show_bug.cgi?id=179053
3423
3424         Reviewed by Darin Adler.
3425
3426         Add a runtime flag for referrerpolicy attribute.
3427
3428         * DumpRenderTree/mac/DumpRenderTree.mm:
3429         (enableExperimentalFeatures):
3430
3431 2019-03-05  Daniel Bates  <dabates@apple.com>
3432
3433         Update expected API test result following r242379
3434         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3435
3436         Update expected x-coordinate of selection rect now that the left padding of
3437         a textarea is sized in ems (so dependent on the font size) just like the left
3438         padding of a text field.
3439
3440         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3441         (TestWebKitAPI::TEST):
3442
3443 2019-03-05  David Quesada  <david_quesada@apple.com>
3444
3445         [WK2] It should be possible to follow links with 'download' attributes
3446         https://bugs.webkit.org/show_bug.cgi?id=195145
3447         rdar://problem/48462642
3448
3449         Reviewed by Alex Christensen.
3450
3451         Add a unit test to verify that activating links with 'download' attributes now
3452         navigates to the linked resource, rather than starts downloading it. Add another
3453         to verify that it is still possible to explicitly download the link via the
3454         'Download' navigation action policy.
3455
3456         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3457         (-[DownloadAttributeTestDelegate init]):
3458         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3459         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3460         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3461         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3462         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3463         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3464         (TEST):
3465         * WebKitTestRunner/TestController.cpp:
3466         (WTR::TestController::decidePolicyForNavigationAction):
3467         * WebKitTestRunner/TestController.h:
3468
3469 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3470
3471         [Curl] Implement Cookie Accept Policy.
3472         https://bugs.webkit.org/show_bug.cgi?id=191645
3473
3474         Reviewed by Fujii Hironori.
3475
3476         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3477         (TestWebKitAPI::Curl::TEST_F):
3478
3479 2019-03-05  Youenn Fablet  <youenn@apple.com>
3480
3481         Rename requestCacheStorageSpace to requestStorageSpace
3482         https://bugs.webkit.org/show_bug.cgi?id=195282
3483
3484         Reviewed by Chris Dumez.
3485
3486         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3487         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3488         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3489
3490 2019-03-05  Brady Eidson  <beidson@apple.com>
3491
3492         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3493         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3494
3495         Reviewed by Tim Horton.
3496
3497         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3498         different directory into that same WKWebView should work.
3499
3500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3501         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3502
3503 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3504
3505         Add WeakHashSet
3506         https://bugs.webkit.org/show_bug.cgi?id=195152
3507
3508         Reviewed by Antti Koivisto.
3509
3510         Added tests for WeakHashSet.
3511
3512         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3513         (TestWebKitAPI::Base::Base): Moved.
3514         (TestWebKitAPI::Derived::foo): Moved.
3515         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3516         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3517         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3518         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3519
3520 2019-03-04  Chris Dumez  <cdumez@apple.com>
3521
3522         Do not share WebProcesses between private and regular sessions
3523         https://bugs.webkit.org/show_bug.cgi?id=195189
3524         <rdar://problem/48421064>
3525
3526         Reviewed by Alex Christensen.
3527
3528         Add API test coverage.
3529
3530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3531         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3532
3533 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3534
3535         [WPE] Enable web process sandbox
3536         https://bugs.webkit.org/show_bug.cgi?id=195169
3537
3538         Reviewed by Daniel Bates.
3539
3540         * wpe/install-dependencies:
3541         * wpe/jhbuild.modules:
3542
3543 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3544
3545         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3546         https://bugs.webkit.org/show_bug.cgi?id=195206
3547
3548         Reviewed by Žan Doberšek.
3549
3550         Add a new test case.
3551
3552         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3553         (testJSCClass):
3554
3555 2019-03-04  Charlie Turner  <cturner@igalia.com>
3556
3557         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3558         https://bugs.webkit.org/show_bug.cgi?id=194898
3559
3560         Reviewed by Žan Doberšek.
3561
3562         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3563         a GCC extension that permits arithmetic on void* pointer. Inline
3564         the macro until this issue is fixed upstream.
3565
3566 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3567
3568         Rid the world of WK_API_ENABLED
3569         https://bugs.webkit.org/show_bug.cgi?id=195263
3570
3571         Reviewed by Dan Bernstein.
3572
3573         List of changed files elided because it's useless.
3574
3575 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3576
3577         Unreviewed follow-up to r242292.
3578
3579         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3580
3581         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3582         (TestWebKitAPI::testStrip): Renamed from strip.
3583         (TestWebKitAPI::TEST):
3584
3585 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3586
3587         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3588
3589         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3590         and bug #194272 for details.
3591
3592         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3593
3594 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3595
3596         Remove some more unused 32-bit code
3597         https://bugs.webkit.org/show_bug.cgi?id=195255
3598
3599         Reviewed by Darin Adler.
3600
3601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3602         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3603         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3604         (NPP_New):
3605         (NPP_HandleEvent):
3606         (handleEventCarbon): Deleted.
3607
3608 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3609
3610         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3611
3612         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3613         (TestWebKitAPI::TEST):
3614
3615 2019-03-01  Darin Adler  <darin@apple.com>
3616
3617         Finish removing String::format
3618         https://bugs.webkit.org/show_bug.cgi?id=194893
3619
3620         Reviewed by Daniel Bates.
3621 '
3622         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3623
3624 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3625
3626         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3627         https://bugs.webkit.org/show_bug.cgi?id=195229
3628         <rdar://problem/48520362>
3629
3630         Reviewed by Chris Dumez.
3631
3632         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3633         (TEST):
3634
3635 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3636
3637         Add a system trace scope for event region building
3638         https://bugs.webkit.org/show_bug.cgi?id=195226
3639
3640         Reviewed by Jon Lee.
3641
3642         This trace scope measures the time spend converting element rects into Region objects,
3643         which can be large on some pages.
3644
3645         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3646
3647         * Tracing/SystemTracePoints.plist:
3648
3649 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3650
3651         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3652         https://bugs.webkit.org/show_bug.cgi?id=194612
3653
3654         Reviewed by Alex Christensen.
3655
3656         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3657         Just test the new string-processing function and don't touch the actual environment.
3658         (Test cases are all as before, but based on operator== instead of strcmp.)
3659
3660 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3661
3662         [ews-app] Update primary keys for handling multiple Buildbot instances
3663         https://bugs.webkit.org/show_bug.cgi?id=195120
3664
3665         Reviewed by Stephanie Lewis.
3666
3667         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3668         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3669         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3670
3671         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3672         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3673         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3674         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3675         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3676         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3677
3678 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3679
3680         [WinCairo] Enable service worker
3681         https://bugs.webkit.org/show_bug.cgi?id=188318
3682
3683         Reviewed by Youenn Fablet.
3684
3685         * DumpRenderTree/DumpRenderTreePrefix.h:
3686         * TestWebKitAPI/PlatformWin.cmake:
3687         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3688         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3689         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3690
3691 2019-03-01  Justin Fan  <justin_fan@apple.com>
3692
3693         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3694         https://bugs.webkit.org/show_bug.cgi?id=195191
3695
3696         Rubber-stamped by Dean Jackson.
3697
3698         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3699
3700         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3701
3702 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3703
3704         Unreviewed, fix lldb webkitpy tests
3705         https://bugs.webkit.org/show_bug.cgi?id=194375
3706
3707         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3708
3709         * lldb/lldb_webkit.py:
3710         (WTFStringImplProvider.is_8bit):
3711
3712 2019-02-28  David Quesada  <david_quesada@apple.com>
3713
3714         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3715         https://bugs.webkit.org/show_bug.cgi?id=195121
3716         rdar://problem/48450302
3717
3718         Reviewed by Alex Christensen.
3719
3720         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3721         configurations where the 'download' attribute is absent, blank, or populated
3722         with a filename, and where the anchor element is same-origin or cross-origin
3723         (meaning the 'download' attribute shouldn't be honored).
3724
3725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3726         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3727         (-[NavigationActionTestDelegate init]):
3728         (-[NavigationActionTestDelegate navigationAction]):
3729         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3730         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3731         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3732         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3733         (TEST):
3734
3735 2019-02-28  Antoine Quint  <graouts@apple.com>
3736
3737         Enable the Pointer Events runtime flag by default
3738         https://bugs.webkit.org/show_bug.cgi?id=195156
3739
3740         Reviewed by Dean Jackson.
3741
3742         * DumpRenderTree/mac/DumpRenderTree.mm:
3743         (enableExperimentalFeatures):
3744
3745 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3746
3747         Several PasteImage API tests are flaky
3748         https://bugs.webkit.org/show_bug.cgi?id=195160
3749
3750         Reviewed by Tim Horton.
3751
3752         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3753         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3754         listening for a "load" event after image load is already complete.
3755
3756         To address this, make these tests first register a "load" event handler, then run script to insert an image
3757         element into the document, and finally wait until the load event is observed before checking image size.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3760
3761 2019-02-28  Chris Dumez  <cdumez@apple.com>
3762
3763         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3764         https://bugs.webkit.org/show_bug.cgi?id=195107
3765
3766         Reviewed by Alex Christensen.
3767
3768         Give some time for the zoom level to get restored.
3769
3770         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3771
3772 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3773
3774         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3775         https://bugs.webkit.org/show_bug.cgi?id=194958
3776
3777         Reviewed by Geoffrey Garen.
3778
3779         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3780         (TEST):
3781
3782 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3783
3784         [ews-app] Update method to save build to handle builder_display_name
3785         https://bugs.webkit.org/show_bug.cgi?id=195047
3786
3787         Reviewed by Dewei Zhu.
3788
3789         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3790         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3791
3792 2019-02-28  Justin Fan  <justin_fan@apple.com>
3793
3794         [Web GPU] Enable Web GPU only on 64-bit
3795         https://bugs.webkit.org/show_bug.cgi?id=195139
3796
3797         Because Metal is only supported on 64 bit apps.
3798
3799         Unreviewed build fix.
3800
3801         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3802
3803 2019-02-27  Youenn Fablet  <youenn@apple.com>
3804
3805         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3806         https://bugs.webkit.org/show_bug.cgi?id=194959
3807
3808         Reviewed by Chris Dumez.
3809
3810         Spin loop until getting the condition to remove flakiness.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3813
3814 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3815
3816         [ews-build] Buildbot should include builder_display_name in the build events
3817         https://bugs.webkit.org/show_bug.cgi?id=195045
3818
3819         Reviewed by Dewei Zhu.
3820
3821         * BuildSlaveSupport/ews-build/events.py:
3822         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3823         buildername to builder_name to be consistent in naming style.
3824         (Events.buildFinished): Ditto.
3825
3826 2019-02-27  Chris Dumez  <cdumez@apple.com>
3827
3828         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3829         https://bugs.webkit.org/show_bug.cgi?id=194480
3830
3831         Reviewed by Brady Eidson.
3832
3833         Update existing API test to make it more likely to reproduce the issue.
3834
3835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3836
3837 2019-02-27  Brady Eidson  <beidson@apple.com>
3838
3839         Universal links from Google search results pages don't open the app.
3840         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3841
3842         Reviewed by Geoffrey Garen.
3843
3844         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3845         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3846         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3847         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3848
3849 2019-02-27  Chris Dumez  <cdumez@apple.com>
3850
3851         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3852         https://bugs.webkit.org/show_bug.cgi?id=195102
3853
3854         Reviewed by Geoffrey Garen.
3855
3856         If the number of processes is not yet what we expect, wait a bit and check again to give
3857         processes some time to exit.
3858
3859         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3860
3861 2019-02-27  Chris Dumez  <cdumez@apple.com>
3862
3863         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3864         https://bugs.webkit.org/show_bug.cgi?id=194545
3865
3866         Reviewed by Brady Eidson.
3867
3868         Make sure the test navigates forward and then back only once. Previously, navigating
3869         back would trigger a navigation again in a timer.
3870
3871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3872
3873 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3874
3875         High Sierra Debug JSC test queue should use faster hardware
3876         https://bugs.webkit.org/show_bug.cgi?id=194603
3877
3878         Rubber-stamped by Alexey Proskuryakov.
3879
3880         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3881
3882         * BuildSlaveSupport/build.webkit.org-config/config.json:
3883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3884         (BubbleQueueServer):
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3886         (WebKitBuildbot):
3887         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3888         * QueueStatusServer/config/queues.py:
3889         * Scripts/webkitpy/common/config/ews.json:
3890         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3891         (test_ews_name):
3892
3893 2019-02-27  John Wilander  <wilander@apple.com>
3894
3895         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3896         https://bugs.webkit.org/show_bug.cgi?id=195071
3897         <rdar://problem/48417690>
3898
3899         Reviewed by Alex Christensen and Brent Fulgham.
3900
3901         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3902         (TestWebKitAPI::createURL):
3903             Convenience function.
3904         (TestWebKitAPI::TEST):
3905             WebCore::AdClickAttribution now takes a URL when creating Source and
3906             Destination.
3907         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3908         (TestWebKitAPI::TEST):
3909             WebCore::AdClickAttribution now takes a URL when creating Source and
3910             Destination.
3911
3912 2019-02-27  Antoine Quint  <graouts@apple.com>
3913
3914         Support Pointer Events on macOS
3915         https://bugs.webkit.org/show_bug.cgi?id=195008
3916         <rdar://problem/47454419>
3917
3918         Reviewed by Dean Jackson.
3919
3920         * DumpRenderTree/mac/DumpRenderTree.mm:
3921         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3922         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3923
3924 2019-02-26  Mark Lam  <mark.lam@apple.com>
3925
3926         Remove remaining poisoning code.
3927         https://bugs.webkit.org/show_bug.cgi?id=194138
3928
3929         Reviewed by Saam Barati.
3930
3931         * TestWebKitAPI/CMakeLists.txt:
3932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3933         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3934         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3935         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3936         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3937         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3938         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3939
3940 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3941
3942         Move ephemeral local storage from WebProcess to UIProcess
3943         https://bugs.webkit.org/show_bug.cgi?id=195074
3944         <rdar://problem/47937975>
3945
3946         Reviewed by Geoff Garen.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3949
3950 2019-02-20  Jer Noble  <jer.noble@apple.com>
3951
3952         [Cocoa] Media elements will restart network buffering just before suspending
3953         https://bugs.webkit.org/show_bug.cgi?id=193691
3954
3955         Reviewed by Eric Carlson.
3956
3957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3959         (TEST):
3960
3961 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3962
3963         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3964         https://bugs.webkit.org/show_bug.cgi?id=191652
3965
3966         Reviewed by Alex Christensen.
3967
3968         Fix WinCairo MiniBrowser behavior of authentication dialog.
3969
3970         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3971         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3972
3973 2019-02-26  Youenn Fablet  <youenn@apple.com>
3974
3975         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3976         https://bugs.webkit.org/show_bug.cgi?id=195028
3977         <rdar://problem/48243733>
3978
3979         Reviewed by Eric Carlson.
3980
3981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3982
3983 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3984
3985         [WPE] Add API for webview background color configuration
3986         https://bugs.webkit.org/show_bug.cgi?id=192305
3987
3988         Reviewed by Michael Catanzaro.
3989
3990         * MiniBrowser/wpe/main.cpp:
3991         (main): Add a new option to configure the webview background
3992         color. Example: --bg-color=transparent.
3993         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3994         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3995         (beforeAll): Ditto.
3996
3997 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3998
3999         scalableNativeWebpageParameters() is not preserved on new page navigation.
4000         https://bugs.webkit.org/show_bug.cgi?id=194892
4001         <rdar://problem/47538280>
4002
4003         Reviewed by Wenson Hsieh.
4004         
4005         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4006
4007         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4008         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4009         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4010         (WTR::UIScriptController::allowsViewportShrinkToFit):
4011         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4012         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4013         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4014         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4015         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4016         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4017
4018 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4019
4020         [ews-app] Add model for handling multiple Buildbot instances
4021         https://bugs.webkit.org/show_bug.cgi?id=194863
4022
4023         Reviewed by Stephanie Lewis.
4024
4025         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4026
4027 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4028
4029         [ews-app] Remove BuilderMapping table
4030         https://bugs.webkit.org/show_bug.cgi?id=194961
4031
4032         Reviewed by Stephanie Lewis.
4033
4034         Store builder name directly in build table, instead of having a separate
4035         table for it.
4036
4037         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4038         * BuildSlaveSupport/ews-app/ews/models/build.py:
4039         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4041
4042 2019-02-25  John Wilander  <wilander@apple.com>
4043
4044         Introduce and adopt new class RegistrableDomain for eTLD+1
4045         https://bugs.webkit.org/show_bug.cgi?id=194791
4046         <rdar://problem/48179240>
4047
4048         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4049
4050         This patch adds an API test and replaces two instances of
4051         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4052
4053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4054         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4055         (TestWebKitAPI::TEST):
4056             Changed two strings to make sure the registrable domains are still considered
4057             invalid and pass the test.
4058         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4059         (TestWebKitAPI::TEST):
4060         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4061         (WTR::InjectedBundle::didReceiveMessageToPage):
4062
4063 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4064
4065         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4066         https://bugs.webkit.org/show_bug.cgi?id=195001
4067
4068         Reviewed by Carlos Garcia Campos.
4069
4070         API version 1.0 always includes the functionality previously guarded with
4071         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4072         unconditionally.
4073
4074         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4075         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4076         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4077         (WebViewTest::showInWindow): Ditto.
4078         (WebViewTest::hideView): Ditto.
4079         * wpe/backends/HeadlessViewBackend.cpp:
4080         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4081         * wpe/backends/ViewBackend.cpp:
4082         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4083         * wpe/backends/WindowViewBackend.cpp:
4084         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4085         WPE_BACKEND_CHECK_VERSION().
4086         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4087
4088 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4089
4090         [Flatpak] Add support for flatpak > 1.1.2
4091         https://bugs.webkit.org/show_bug.cgi?id=194088
4092
4093         Flatpak 1.2 is now out so we need to support that
4094         version now.
4095
4096         Reviewed by Michael Catanzaro.
4097
4098         * flatpak/flatpakutils.py:
4099         (check_flatpak):
4100         (FlatpakPackages.__init__):
4101         (FlatpakPackages.__detect_packages):
4102         (FlatpakPackages.__detect_packages.in):
4103         (FlatpakRepos.update):
4104
4105 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4106
4107         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4108         https://bugs.webkit.org/show_bug.cgi?id=194998
4109
4110         Reviewed by Carlos Garcia Campos.
4111
4112         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4113         to a Git checkout and using the latest commit containing various fixes
4114         and improvements.
4115
4116 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4117
4118         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4119         https://bugs.webkit.org/show_bug.cgi?id=194981
4120
4121         Reviewed by Žan Doberšek.
4122
4123         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4124         (TestWebKitAPI::TEST):
4125
4126 2019-02-23  Keith Miller  <keith_miller@apple.com>
4127
4128         Add new mac target numbers
4129         https://bugs.webkit.org/show_bug.cgi?id=194955
4130
4131         Reviewed by Tim Horton.
4132
4133         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4134         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4135         * MiniBrowser/Configurations/Base.xcconfig:
4136         * TestWebKitAPI/Configurations/Base.xcconfig:
4137         * WebKitTestRunner/Configurations/Base.xcconfig:
4138
4139 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4140
4141         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4142         https://bugs.webkit.org/show_bug.cgi?id=194846
4143
4144         Reviewed by Don Olmstead.
4145
4146         Added _search_paths() and _port_specific_expectations_files() for
4147         WinCairoPort.
4148
4149         * Scripts/webkitpy/port/win.py:
4150         (WinCairoPort.default_baseline_search_path):
4151         (WinCairoPort):
4152         (WinCairoPort._port_specific_expectations_files):
4153         (WinCairoPort._search_paths):
4154
4155 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4156
4157         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4158         https://bugs.webkit.org/show_bug.cgi?id=194963
4159
4160         Reviewed by Dean Jackson.
4161
4162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4163         Do a `contains` check instead of `equals`, because in debug builds we
4164         put the GraphicsLayer pointer in a prefix.
4165
4166 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4167
4168         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4169         https://bugs.webkit.org/show_bug.cgi?id=194873
4170         <rdar://problem/46701974>
4171
4172         Reviewed by Tim Horton.
4173
4174         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4175
4176         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4177         (WTR::UIScriptController::menuRect const):
4178         (WTR::UIScriptController::isShowingMenu const):
4179         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4180         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4181         (WTR::UIScriptController::menuRect const):
4182
4183         Add a function to query the bounds of the callout menu in content coordinates.
4184
4185         (WTR::UIScriptController::isShowingMenu const):
4186
4187         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4188
4189         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4190         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4191         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4192         (WTR::UIScriptController::rectForMenuAction const):
4193         (WTR::UIScriptController::menuRect const):
4194         (WTR::UIScriptController::isShowingMenu const):
4195         (WTR::findViewInHierarchyOfType): Deleted.
4196
4197 2019-02-22  Chris Dumez  <cdumez@apple.com>
4198
4199         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4200         https://bugs.webkit.org/show_bug.cgi?id=194954
4201         <rdar://problem/48127957>
4202
4203         Reviewed by Alex Christensen.
4204
4205         Add API test coverage.
4206
4207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4208         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4209         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4210         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4211
4212 2019-02-22  Chris Dumez  <cdumez@apple.com>
4213
4214         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4215         https://bugs.webkit.org/show_bug.cgi?id=194924
4216         <rdar://problem/48216125>
4217
4218         Reviewed by Geoffrey Garen.
4219
4220         Add API test coverage.
4221
4222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4223
4224 2019-02-22  Chris Dumez  <cdumez@apple.com>
4225
4226         Unreviewed, disable API test added in r241928 on iOS.
4227
4228         The cache is not enabled on devices with less than 3GB of RAM.
4229
4230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4231
4232 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4233
4234         Hardcode Visual Viewports on everywhere except iOS WK1
4235         https://bugs.webkit.org/show_bug.cgi?id=194928
4236
4237         Reviewed by Zalan Bujtas.
4238
4239         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4240         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4241         set it to false. The setting has shipped for several years and there's no need to turn
4242         it off now.
4243
4244         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4245         Visual Viewports are not enabled.
4246         
4247         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4248         that only runs in WK2
4249
4250         * MiniBrowser/mac/SettingsController.h:
4251         * MiniBrowser/mac/SettingsController.m:
4252         (-[SettingsController init]):
4253         (-[SettingsController _populateMenu]):
4254         (-[SettingsController validateMenuItem:]):
4255         (-[SettingsController visualViewportEnabled]): Deleted.
4256         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4257         * MiniBrowser/mac/WK1BrowserWindowController.m:
4258         (-[WK1BrowserWindowController didChangeSettings]):
4259         * MiniBrowser/mac/WK2BrowserWindowController.m:
4260         (-[WK2BrowserWindowController didChangeSettings]):
4261
4262 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4263
4264         Discard cached processes when clearing website data store
4265         https://bugs.webkit.org/show_bug.cgi?id=194894
4266
4267         Reviewed by Chris Dumez.
4268
4269         Added a test case.
4270
4271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4272         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4273
4274 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4275
4276         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4277         https://bugs.webkit.org/show_bug.cgi?id=194914
4278         <rdar://problem/47586889>
4279
4280         Reviewed by Geoffrey Garen.
4281
4282         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4283         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4284         (TEST):
4285         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4286
4287 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4288
4289         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4290         <https://webkit.org/b/194761>
4291
4292         Reviewed by Myles Maxfield.
4293
4294         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4295         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4296         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4297         to use ARC-compliant cast.
4298         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4299         ARC-compliant cast.
4300         (WTR::installFakeHelvetica): Log `error` to console if
4301         CTFontManagerRegisterFontsForURL() fails, but only on supported
4302         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4303         Call CFRelease() on `error` to fix the leak.  Update to use
4304         ARC-compliant cast.
4305         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4306         cast.
4307
4308 2019-02-21  Chris Dumez  <cdumez@apple.com>
4309
4310         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4311         https://bugs.webkit.org/show_bug.cgi?id=194481
4312
4313         Reviewed by Alex Christensen.
4314
4315         Give the processes a chance to shutdown and wait until we reached the expected number
4316         of processes.
4317
4318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4319
4320 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4321
4322         Fix the macOS build
4323
4324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4325
4326 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4327
4328         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4329
4330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4331         I am a backwards.
4332
4333 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4334
4335         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4336
4337         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4338         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4339         We could force on UI-side compositing, but I feel like the test might be more
4340         valuable exercising the normal path on each platform (though the original
4341         bug was also UI-side specific). Though we can't validate that the overlay
4342         layer was installed successfully, there are layout tests that do that.
4343
4344 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4345
4346         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4347         https://bugs.webkit.org/show_bug.cgi?id=194845
4348         <rdar://problem/47944579>
4349
4350         Reviewed by Antti Koivisto.
4351
4352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4354
4355 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4356
4357         [LFC][Floats] Add support for placing formatting roots in-between floats.
4358         https://bugs.webkit.org/show_bug.cgi?id=194902
4359
4360         Reviewed by Antti Koivisto.
4361
4362         * LayoutReloaded/misc/LFC-passing-tests.txt:
4363
4364 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4365
4366         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests