WinLauncher should show loading errors
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2
3         WinLauncher should show loading errors
4         https://bugs.webkit.org/show_bug.cgi?id=80760
5
6         Reviewed by Brent Fulgham.
7
8         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
9         (WinLauncherWebHost::didFailProvisionalLoadWithError):
10         * WinLauncher/WinLauncher.h:
11         (WinLauncherWebHost::didFailProvisionalLoadWithError):
12         (WinLauncherWebHost):
13
14 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
15
16         [EFL][WK2] Add MiniBrowserEfl.
17         https://bugs.webkit.org/show_bug.cgi?id=61850
18
19         Reviewed by Chang Shu.
20
21         Implement MiniBrowser for EFL.
22
23         * CMakeLists.txt:
24         * MiniBrowser/efl/CMakeLists.txt: Added.
25         * MiniBrowser/efl/main.c: Added.
26         (_MiniBrowser):
27         (main_signal_exit):
28         (on_ecore_evas_resize):
29         (browserCreate):
30         (main):
31
32 2012-06-12  Helder Correia  <helder.correia@nokia.com>
33
34         Unreviewed. Update my email address in committers.py.
35
36         * Scripts/webkitpy/common/config/committers.py:
37
38 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
39
40         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
41         https://bugs.webkit.org/show_bug.cgi?id=84707
42
43         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
44         use_lib64 variable is preconfigured to True by jhbuild.
45
46         Reviewed by Dirk Pranke.
47
48         * efl/jhbuildrc:
49
50 2012-06-12  Dana Jansens  <danakj@chromium.org>
51
52         Add zlieber@chromium.org to contributors list
53         https://bugs.webkit.org/show_bug.cgi?id=88904
54
55         Unreviewed.
56
57         * Scripts/webkitpy/common/config/committers.py:
58
59 2012-06-12  Lucas Forschler  <lforschler@apple.com>
60
61         Rename Apple bots to a standard convention.
62         https://bugs.webkit.org/show_bug.cgi?id=88893
63         
64         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
65
66         Reviewed by Simon Fraser.
67
68         * BuildSlaveSupport/build.webkit.org-config/config.json:
69
70 2012-06-12  Mike West  <mkwst@chromium.org>
71
72         Make document.documentURI readonly from JavaScript
73         https://bugs.webkit.org/show_bug.cgi?id=65187
74
75         Reviewed by Alexey Proskuryakov.
76
77         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
78         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
79         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
80         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
81         (TestWebKitAPI):
82         (TestWebKitAPI::TEST):
83
84 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
85
86         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
87         https://bugs.webkit.org/show_bug.cgi?id=88715
88
89         Reviewed by Noam Rosenthal.
90
91         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
92
93         * Scripts/webkitperl/FeatureList.pm:
94
95 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
96
97         [Qt] Fix -Werror for the buildbots
98         https://bugs.webkit.org/show_bug.cgi?id=88223
99
100         Rubber-stamped by Tor Arne Vestbø.
101
102         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
103
104         * qmake/mkspecs/features/unix/default_post.prf:
105
106 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
107
108         [REGRESSION][WTR] Build fail with werror after r120054
109         https://bugs.webkit.org/show_bug.cgi?id=88862
110
111         Reviewed by Csaba Osztrogonác.
112
113         Some static helpers become unused after counterValueForElementById
114         has moved to Internals. Let's remove them.
115
116         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
117         (WTR):
118
119 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
120
121         [Qt] Slave losts cause build break on bots
122         https://bugs.webkit.org/show_bug.cgi?id=38980
123
124         Minor fix after r59261.
125
126         Reviewed by Tor Arne Vestbø.
127
128         * Scripts/build-webkit:
129         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
130
131 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
132
133         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
134         https://bugs.webkit.org/show_bug.cgi?id=84406
135
136         Reviewed by Hajime Morita.
137
138         Move the counterValueForElementById from LayoutTestCotroller to Internals and
139         remove the old platform specific implementations as it exclusively tests WebCore functionality.
140
141         * DumpRenderTree/LayoutTestController.cpp:
142         (LayoutTestController::staticFunctions):
143         * DumpRenderTree/LayoutTestController.h:
144         (LayoutTestController):
145         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
146         * DumpRenderTree/chromium/LayoutTestController.cpp:
147         (LayoutTestController::LayoutTestController):
148         (LayoutTestController::setPOSIXLocale):
149         * DumpRenderTree/chromium/LayoutTestController.h:
150         (LayoutTestController):
151         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
153         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
154         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
155         * DumpRenderTree/qt/LayoutTestControllerQt.h:
156         (LayoutTestController):
157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
158         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
159         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
160         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
161         (WTR):
162         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
163         (LayoutTestController):
164
165 2012-06-11  Hans Wennborg  <hans@chromium.org>
166
167         Speech JavaScript API: Make SpeechRecognitionError an Event
168         https://bugs.webkit.org/show_bug.cgi?id=88784
169
170         Reviewed by Adam Barth.
171
172         Make it possible to have MockWebSpeechRecognizer fire error events.
173
174         * DumpRenderTree/chromium/LayoutTestController.cpp:
175         (LayoutTestController::LayoutTestController):
176         (LayoutTestController::setMockSpeechRecognitionError):
177         * DumpRenderTree/chromium/LayoutTestController.h:
178         (LayoutTestController):
179         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
180         (WebKit):
181         (ErrorTask):
182         (WebKit::ErrorTask::ErrorTask):
183         (MockWebSpeechRecognizer::addMockResult):
184         (MockWebSpeechRecognizer::setError):
185         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
186         (MockWebSpeechRecognizer):
187
188 2012-06-11  Ojan Vafai  <ojan@chromium.org>
189
190         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
191         https://bugs.webkit.org/show_bug.cgi?id=88836
192
193         Reviewed by Dirk Pranke.
194
195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
197
198 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
199
200         [EFL] Remove CMakeCache.txt before building
201         https://bugs.webkit.org/show_bug.cgi?id=88717
202
203         Reviewed by Antonio Gomes.
204
205         Remove CMake cache file before every build to avoid using outdated
206         build flags when new features get enabled. This will avoid unexpected
207         failures on the bots due to outdated build flags.
208
209         * Scripts/webkitdirs.pm:
210         (generateBuildSystemFromCMakeProject):
211
212 2012-06-11  Vincent Scheib  <scheib@chromium.org>
213
214         Add new Pointer Lock spec attribute webkitPointerLockElement.
215         https://bugs.webkit.org/show_bug.cgi?id=88799
216
217         Reviewed by Dimitri Glazkov.
218
219         Part of a series of refactoring changes to update pointer lock API to
220         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
221
222         New attribute webkitPointerLockElement added. Follow up patches
223         will remove the previous isLocked attribute. Tests updated to use
224         the new attribute.
225
226         WebViewHost logic required modification to correctly repond to
227         a lock, unlock, pointerLockElement call series. Specifically,
228         unlocking must be queued after a lock command is issued always
229         as the lock state may not be set yet with a lock request in flight.
230
231         * DumpRenderTree/chromium/WebViewHost.cpp:
232         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
233         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
234
235 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
236
237         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
238         https://bugs.webkit.org/show_bug.cgi?id=88804
239
240         Reviewed by Tony Chang.
241
242         Protect box-decoration-break behind a feature flag enabled by default.
243
244         * Scripts/webkitperl/FeatureList.pm:
245         * qmake/mkspecs/features/features.pri:
246
247 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
248
249         [CMAKE][EFL] Remove duplicated executable output path
250         https://bugs.webkit.org/show_bug.cgi?id=88765
251
252         Reviewed by Daniel Bates.
253
254         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
255         need to define again because it is already defined in top-level CMake file.
256
257         * DumpRenderTree/efl/CMakeLists.txt:
258         * EWebLauncher/CMakeLists.txt:
259
260 2012-06-11  Ojan Vafai  <ojan@chromium.org>
261
262         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
263         https://bugs.webkit.org/show_bug.cgi?id=88816
264
265         Reviewed by Dirk Pranke.
266
267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
268         Expose a way to clear AsynchronousCaches.
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
271         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
272
273 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
274
275         nrwt exits early too frequently
276         https://bugs.webkit.org/show_bug.cgi?id=73843
277
278         Reviewed by Ryosuke Niwa.
279
280         Change the defaults for new-run-webkit-tests for both
281         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
282         to zero (i.e., we will never exit early by default).
283
284         If people want their buildbots to exit early it is their
285         responsibility to update their buildbot configs appropriately.
286
287         Note that we have tests that ensure that these flags work for
288         non-zero numbers, but we don't have tests that either test the
289         default or ensure that zero means "run all of the tests". I
290         think that's okay but can add tests if others disagree.
291
292         Also note that it looks like no changes on the build.webkit.org
293         master.cfg are necessary; all of the bots seem to be using the
294         RunWebKitTests wrapper which is already setting the flags. There
295         is a NewRunWebKitTests wrapper, but that looks to be unused; I
296         will delete that in a separate patch.
297
298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
299         (parse_args):
300
301 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
302
303         [EFL] [DRT] Reset CacheModel before running each test
304         https://bugs.webkit.org/show_bug.cgi?id=87534
305
306         Reviewed by Gustavo Noronha Silva.
307
308         Reset cache model to default before running each test to fix some
309         flaky tests on EFL build bots. Also fix case value in setCacheModel.
310
311         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
312         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
313         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
314         (LayoutTestController::setCacheModel):
315
316 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
317
318         [GTK] Memory leaks in DRT EventSender.cpp
319         https://bugs.webkit.org/show_bug.cgi?id=88774
320
321         Reviewed by Martin Robinson.
322
323         Fix a few possible memory leaks in EventSender code.
324
325         * DumpRenderTree/gtk/EventSender.cpp:
326         (contextClickCallback): Free the event returned by gdk_event_new().
327         (mouseDownCallback): Ditto.
328         (mouseUpCallback): Ditto.
329
330 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
331
332         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
333         https://bugs.webkit.org/show_bug.cgi?id=88661
334
335         Reviewed by Dirk Pranke.
336
337         Pass string length explicitly when creating String object from
338         non-null-terminated UChar* returned by characters().
339
340         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
341         (LayoutTestController::pathToLocalResource):
342
343 2012-06-11  David Dorwin  <ddorwin@chromium.org>
344
345         [chromium] Provide access to the WebPlugin created by the helper plugin widget
346         https://bugs.webkit.org/show_bug.cgi?id=88028
347
348         Reviewed by Adam Barth.
349
350         Added isPlaceholder() to WebPlugin.
351
352         * DumpRenderTree/chromium/TestWebPlugin.h:
353         (TestWebPlugin::isPlaceholder):
354
355 2012-06-11  Tony Chang  <tony@chromium.org>
356
357         rebaseline from garden-o-matic leaves N processes each time it is run
358         https://bugs.webkit.org/show_bug.cgi?id=88586
359
360         Reviewed by Dirk Pranke.
361
362         This appears to only be a problem on python 2.7. Maybe a bug causing
363         pools to not be garbage collected?
364
365         * Scripts/webkitpy/common/system/executive.py:
366         (Executive.run_in_parallel): close() and join() the process pool.
367         * Scripts/webkitpy/common/system/executive_unittest.py:
368         (ExecutiveTest.test_run_in_parallel):
369
370 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
371
372         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
373         https://bugs.webkit.org/show_bug.cgi?id=87841
374
375         Reviewed by Simon Hausmann.
376
377         * qmake/config.tests/libwebp/libwebp.cpp: Added.
378         (main):
379         * qmake/config.tests/libwebp/libwebp.pro: Added.
380         * qmake/sync.profile:
381
382 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
383
384         Expose layoutTestController as testRunner
385         https://bugs.webkit.org/show_bug.cgi?id=88210
386
387         Reviewed by Darin Adler.
388
389         * DumpRenderTree/LayoutTestController.cpp:
390         (LayoutTestController::makeWindowObject):
391         * DumpRenderTree/chromium/TestShell.cpp:
392         (TestShell::bindJSObjectsToWindow):
393         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
394         (WebCore::DumpRenderTree::initJSObjects):
395         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
396         (WTR::LayoutTestController::makeWindowObject):
397
398 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
399
400         [Chromium] Remove JavaScriptCore dependencies from gyp
401         https://bugs.webkit.org/show_bug.cgi?id=88510
402
403         Reviewed by Adam Barth.
404
405         Chromium doesn't support JSC any more and there doesn't seem to be
406         a strong interest in using GYP as the common build system in other
407         ports.
408
409         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
410         * Scripts/generate-project-files: Removed.
411
412 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
413
414         Add UNDO_MANAGER flag
415         https://bugs.webkit.org/show_bug.cgi?id=87908
416
417         Reviewed by Tony Chang.
418
419         * Scripts/webkitperl/FeatureList.pm:
420         * qmake/mkspecs/features/features.pri:
421
422 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
423
424         webkit-patch land-safely should set cq? if the patch author is not in committers.py
425         https://bugs.webkit.org/show_bug.cgi?id=88689
426
427         Reviewed by Dirk Pranke.
428
429         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
430         in committers.py or the contributor cannot commit. If anything, the contributor can still
431         set cq+ on thier patches manually so I don't think this will be an issue for people who
432         don't list their Bugzille email on committers.py.
433
434         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
435         (Bugzilla._commit_queue_flag):
436         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
437         (test_commit_queue_flag):
438         (test_commit_queue_flag.assert_commit_queue_flag):
439
440 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
441
442         remove obsolete NewRunWebKitTests buildbot master factory classes
443         https://bugs.webkit.org/show_bug.cgi?id=88693
444
445         Reviewed by Ryosuke Niwa.
446
447         I believe these aren't used any more ...
448
449         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
450         (RunWebKitTests.getText2):
451         (BuildAndTestLeaksFactory):
452
453 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
454
455         [Chromium-Android] Build DumpRenderTree with Android SDK
456         https://bugs.webkit.org/show_bug.cgi?id=88598
457
458         Change WebKit side of DRT related code according to some recent changes at chromium side.
459
460         Reviewed by Adam Barth.
461
462         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
463         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
464         (ChromiumAndroidPort.__init__):
465         (ChromiumAndroidPort._path_to_driver):
466
467 2012-06-08  Wei James  <james.wei@intel.com>
468
469         Add app_abi option for DumpRenderTree_apk
470         https://bugs.webkit.org/show_bug.cgi?id=88626
471
472         Reviewed by Adam Barth.
473
474         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
475
476 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
477
478         [GTK] Add API to get the library version to WebKit2 GTK+
479         https://bugs.webkit.org/show_bug.cgi?id=88426
480
481         Reviewed by Martin Robinson.
482
483         * gtk/generate-gtkdoc:
484         (get_webkit2_options): Add built sources to the list of files, but
485         ignore enum types and marshallers.
486
487 2012-06-07  Vincent Scheib  <scheib@chromium.org>
488
489         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
490         https://bugs.webkit.org/show_bug.cgi?id=88604
491
492         Reviewed by Kent Tamura.
493
494         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
495         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
496
497         * DumpRenderTree/chromium/WebViewHost.cpp:
498         (WebViewHost::requestPointerUnlock):
499
500 2012-06-08  Hans Wennborg  <hans@chromium.org>
501
502         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
503         https://bugs.webkit.org/show_bug.cgi?id=87976
504
505         Reviewed by Kent Tamura.
506
507         Provide a mock implementation of WebSpeechRecognizer for
508         DumpRenderTree. This will allow better testing of the API via layout
509         tests.
510
511         * DumpRenderTree/DumpRenderTree.gypi:
512         * DumpRenderTree/chromium/LayoutTestController.cpp:
513         (LayoutTestController::LayoutTestController):
514         (LayoutTestController::addMockSpeechRecognitionResult):
515         * DumpRenderTree/chromium/LayoutTestController.h:
516         (LayoutTestController):
517         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
518         (MockWebSpeechRecognizer::create):
519         (MockWebSpeechRecognizer::start):
520         (MockWebSpeechRecognizer::stop):
521         (MockWebSpeechRecognizer::abort):
522         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
523         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
524         (MockWebSpeechRecognizer::ResultTask::runIfValid):
525         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
526         (WebKit):
527         (MockWebSpeechRecognizer):
528         (MockWebSpeechRecognizer::addMockResult):
529         (MockWebSpeechRecognizer::taskList):
530         (ClientCallTask):
531         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
532         (ResultTask):
533         (MockWebSpeechRecognizer::ResultTask::ResultTask):
534         (NoMatchTask):
535         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
536         * DumpRenderTree/chromium/WebViewHost.cpp:
537         (WebViewHost::speechRecognizer):
538         * DumpRenderTree/chromium/WebViewHost.h:
539         (WebViewHost):
540         (WebViewHost::mockSpeechRecognizer):
541
542 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
543
544         check-webkit-style needs to be taught about <public/Foo.h>
545         https://bugs.webkit.org/show_bug.cgi?id=88524
546
547         Reviewed by David Levin.
548
549         * Scripts/webkitpy/style/checkers/cpp.py:
550         (_classify_include):
551         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
552         (OrderOfIncludesTest.test_public_primary_header):
553         (OrderOfIncludesTest.test_classify_include):
554
555 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
556
557         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
558         https://bugs.webkit.org/show_bug.cgi?id=67255
559
560         Reviewed by Dirk Pranke.
561
562         Implement pathToLocalResource to redirect file:///tmp URL's to
563         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
564         LayoutTests sub-directory of the WebKit source tree.
565
566         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
567         (LayoutTestController::pathToLocalResource):
568
569 2012-06-07  Tony Payne  <tpayne@chromium.org>
570
571         [chromium] Allow LayoutTests under new git workflow
572         https://bugs.webkit.org/show_bug.cgi?id=88575
573
574         On Windows, chromium indirects through git.bat. Adds the same hack that
575         is currently used for discovering svn.bat to support the new git
576         workflow.
577
578         Reviewed by Dirk Pranke.
579
580         * Scripts/webkitpy/common/checkout/scm/git.py:
581         (Git): Replaces all hard-coded references to 'git' with the class
582         variable executable_name.
583         (Git._check_git_architecture):
584         (Git.in_working_directory):
585         (Git.find_checkout_root):
586         (Git.read_git_config):
587         (Git.discard_local_commits):
588         (Git.local_commits):
589         (Git.working_directory_is_clean):
590         (Git.clean_working_directory):
591         (Git.status_command):
592         (Git.add_list):
593         (Git.delete_list):
594         (Git.exists):
595         (Git._current_branch):
596         (Git.changed_files):
597         (Git._changes_files_for_commit):
598         (Git.revisions_changing_file):
599         (Git.conflicted_files):
600         (Git.svn_revision):
601         (Git.create_patch):
602         (Git._run_git_svn_find_rev):
603         (Git.contents_at_revision):
604         (Git.diff_for_file):
605         (Git.show_head):
606         (Git.committer_email_for_revision):
607         (Git.apply_reverse_diff):
608         (Git.revert_files):
609         (Git.commit_with_message):
610         (Git._commit_on_branch):
611         (Git.svn_commit_log):
612         (Git.last_svn_commit_log):
613         (Git.svn_blame):
614         (Git._branch_ref_exists):
615         (Git.delete_branch):
616         (Git.remote_merge_base):
617         (Git.commit_locally_with_message):
618         (Git.push_local_commits_to_server):
619         (Git.commit_ids_from_commitish_arguments):
620         (Git.commit_message_for_local_commit):
621         (Git.files_changed_summary_for_commit):
622         * Scripts/webkitpy/common/host.py:
623         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
624         that duplicates the logic in the existing 'svn.bat' hack.
625
626 2012-06-07  Ojan Vafai  <ojan@chromium.org>
627
628         Style build architectures like build versions for non-layout test failures
629         https://bugs.webkit.org/show_bug.cgi?id=88590
630
631         Reviewed by Tony Chang.
632
633         Since we show the list of failing tests after the architecture, we want the
634         buildtype and architecture to be grouped together visually.
635
636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
637         (.effects a.failing-builder>span.architecture):
638
639 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
640
641         [Chromium] Remove header dependency of ImageDiff to WTF
642         https://bugs.webkit.org/show_bug.cgi?id=88422
643
644         Reviewed by Ryosuke Niwa.
645
646         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
647         * DumpRenderTree/chromium/ImageDiff.cpp:
648         (untestedCompareImages):
649
650 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
651
652         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
653         https://bugs.webkit.org/show_bug.cgi?id=88491
654
655         Reviewed by Dirk Pranke.
656
657         DRT should enable WebAudio when WebAudio feature is enabled,
658         so that the WebAudio feature could be tested by the Layouttest.
659
660         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
661         (LayoutTestController::overridePreference):
662
663 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
664
665         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
666         https://bugs.webkit.org/show_bug.cgi?id=88581
667
668         Reviewed by Ojan Vafai.
669
670         webkit-paptch rebaseline-expectations was ignoring what the
671         expected results for a test were and pulling down all the result
672         files from a bot. This could lead to us pulling down old,
673         incorrect .txt or .png files. With this patch we will now only
674         pull down expectations of the appropriate file types (so an
675         IMAGE failure will only pull the png and not the txt file).
676
677         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
678         (has_pixel_failures):
679         (suffixes_for_expectations):
680         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
681         (FunctionsTest.test_suffixes_for_expectations):
682         * Scripts/webkitpy/tool/commands/rebaseline.py:
683         (AbstractRebaseliningCommand.__init__):
684         (RebaselineExpectations._is_supported_port):
685         (RebaselineExpectations._update_expectations_file):
686         (RebaselineExpectations._tests_to_rebaseline):
687         (RebaselineExpectations._rebaseline_port):
688         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
689         (test_overrides_are_included_correctly):
690
691 2012-06-07  Ojan Vafai  <ojan@chromium.org>
692
693         Fix recent null pointer error regression in the flakiness dashboard
694         https://bugs.webkit.org/show_bug.cgi?id=88573
695
696         Reviewed by Dirk Pranke.
697
698         * TestResultServer/static-dashboards/builders.js:
699         (requestBuilderList):
700         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
701
702 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
703
704         Add Konrad Piascik to committers.py
705         https://bugs.webkit.org/show_bug.cgi?id=88560
706
707         Unreviewed.
708
709         * Scripts/webkitpy/common/config/committers.py:
710
711 2012-06-07  Tony Chang  <tony@chromium.org>
712
713         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
714         https://bugs.webkit.org/show_bug.cgi?id=77368
715
716         Reviewed by Ojan Vafai.
717
718         It doesn't look like we ever get a rect with width or height of 0.
719         I ran css1, css2.1, fast/forms, and tables without any crashes.
720
721         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
722         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
723
724 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
725
726         run-webkit-tests --lint-test-files gives an error when run on linux
727         https://bugs.webkit.org/show_bug.cgi?id=88551
728
729         Reviewed by Ojan Vafai.
730
731         We weren't mapping the expectations properly for the
732         google-chrome ports.
733
734         * Scripts/webkitpy/layout_tests/port/base.py:
735         (Port.path_to_test_expectations_file):
736         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
737         (TestGoogleChromePort.test_path_to_expectations):
738
739 2012-06-07  Daniel Erat  <derat@chromium.org>
740
741         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
742         https://bugs.webkit.org/show_bug.cgi?id=88263
743
744         Reviewed by Tony Chang.
745
746         * DumpRenderTree/chromium/LayoutTestController.cpp:
747         (LayoutTestController::LayoutTestController):
748         (LayoutTestController::reset):
749         (LayoutTestController::setTextSubpixelPositioning):
750         * DumpRenderTree/chromium/LayoutTestController.h:
751         (LayoutTestController):
752         * DumpRenderTree/chromium/fonts.conf:
753
754 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
755
756         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
757         https://bugs.webkit.org/show_bug.cgi?id=88060
758
759         Reviewed by Martin Robinson.
760
761         Spin the main loop before acquiring the pixel content. This ensures things
762         like late size allocations are finished before calling gtk_widget_draw,
763         avoiding assertions and subsequent empty pixel results.
764
765         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
766         (createBitmapContextFromWebView):
767
768 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
769
770         [Qt] Improve the visual of the viewport info box
771         https://bugs.webkit.org/show_bug.cgi?id=88410
772
773         Reviewed by Tor Arne Vestbø.
774
775         Improve the visual and make it possible to see the content more easy.
776
777         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
778
779 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
780
781         [EFL][WK2] Compile webkit1 and webkit2 by default.
782         https://bugs.webkit.org/show_bug.cgi?id=85041
783
784         Reviewed by Chang Shu.
785
786         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
787         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
788
789         * Scripts/build-webkit:
790
791 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
792
793         Unreviewed, rolling out r119662.
794         http://trac.webkit.org/changeset/119662
795         https://bugs.webkit.org/show_bug.cgi?id=88487
796
797         Broke builds (Requested by rniwa on #webkit).
798
799         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
800         * DumpRenderTree/chromium/ImageDiff.cpp:
801         (untestedCompareImages):
802
803 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
804
805         [Chromium] Remove header dependency of ImageDiff to WTF
806         https://bugs.webkit.org/show_bug.cgi?id=88422
807
808         Reviewed by Adam Barth.
809
810         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
811         * DumpRenderTree/chromium/ImageDiff.cpp:
812         (untestedCompareImages):
813
814 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
815
816         [WebKit] DeviceOrientation cleanup
817         https://bugs.webkit.org/show_bug.cgi?id=88406
818
819         Reviewed by Kent Tamura.
820
821         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
822
823         * DumpRenderTree/chromium/LayoutTestController.cpp:
824         (LayoutTestController::setMockDeviceOrientation):
825
826 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
827
828         webkitpy: add support for an ordered dict of test expectations
829         https://bugs.webkit.org/show_bug.cgi?id=87802
830
831         Reviewed by Ojan Vafai.
832
833         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
834         support a cascaded list of test expectations files. An easy way
835         to think of this is as an ordered dictionary of name -> contents
836         for files, where the name is usually a path on disk (I say
837         usually because we want to support other kinds of expectations
838         like the compile-time skips for unsupported features in
839         webkit.py, and we want to continue to support "in-memory" test
840         expectations that don't require a filesystem).
841
842         Conveniently there is an OrderedDict implementation in Python
843         2.7+ and it is available as a backport, so the first step in
844         adding this support is to use that implementation. Subsequent
845         patches will update the test_expectations.py module (and other
846         callers) to access the dict directly.
847
848         This patch just changes the base internal implementation and
849         provides wrappers for compatibility. The derived ports
850         (WebKitPort, TestPort, etc.) still need to be updated.
851
852         * Scripts/webkitpy/layout_tests/port/base.py:
853         (Port._expectations_dict):
854         (Port.test_expectations):
855         (Port):
856         (Port._expectations_overrides_dict):
857         (Port.test_expectations_overrides):
858         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
859         (PortTestCase.test_expectations_ordering):
860         (PortTestCase):
861         (PortTestCase.test_expectations_overrides_ordering):
862         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
863         (OrderedDict):
864         (OrderedDict.__init__):
865         (OrderedDict.clear):
866         (OrderedDict.__setitem__):
867         (OrderedDict.__delitem__):
868         (OrderedDict.__iter__):
869         (OrderedDict.__reversed__):
870         (OrderedDict.popitem):
871         (OrderedDict.__reduce__):
872         (OrderedDict.__repr__):
873         (OrderedDict.copy):
874         (OrderedDict.fromkeys):
875
876 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
877
878         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
879
880         * gtk/run-api-tests:
881         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
882
883 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
884
885         nrwt should look in 'out' for binaries on chromium win to support ninja
886         https://bugs.webkit.org/show_bug.cgi?id=88273
887
888         Reviewed by Tony Chang.
889
890         This patch standardizes the search algorithm the chromium ports
891         use to figure out which driver to run. We will look in a
892         chromium location before a webkit location (e.g., in
893         Source/WebKit/chromium/out before out/) and we will look in the
894         "legacy" directory (xcodebuild) before the directory ninja uses
895         (out).
896
897         Unfortunately due to the way the test code is set up testing the
898         properly requires some duplication of test code. I will fix that
899         in a followup patch.
900
901         * Scripts/webkitpy/layout_tests/port/chromium.py:
902         (ChromiumPort):
903         (ChromiumPort._static_build_path):
904         (ChromiumPort._build_path):
905         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
906         (ChromiumLinuxPort):
907         (ChromiumLinuxPort._determine_driver_path_statically):
908         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
909         (ChromiumLinuxPortTest.test_build_path):
910         (ChromiumLinuxPortTest):
911         (ChromiumLinuxPortTest.test_driver_name_option):
912         (ChromiumLinuxPortTest.path_to_image_diff):
913         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
914         (ChromiumMacPort):
915         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
916         (ChromiumMacPortTest.test_build_path):
917         (ChromiumMacPortTest):
918         (ChromiumMacPortTest.test_driver_name_option):
919         (ChromiumMacPortTest.path_to_image_diff):
920         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
921         (ChromiumPortTest.test_overrides_and_builder_names):
922         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
923         (ChromiumWinPort):
924         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
925         (ChromiumWinTest.test_build_path):
926         (ChromiumWinTest.test_operating_system):
927         (ChromiumWinTest):
928         (ChromiumWinTest.test_driver_name_option):
929         (ChromiumWinPortTest.path_to_image_diff):
930         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
931         (PortTestCase.assert_build_path):
932
933 2012-06-06  Jessie Berlin  <jberlin@apple.com>
934
935         Remove very red Windows WebKit2 testers
936         https://bugs.webkit.org/show_bug.cgi?id=88452
937
938         Reviewed by Steve Falkenburg.
939
940         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
941         need to focus on getting the WK1 testers green.
942
943         * BuildSlaveSupport/build.webkit.org-config/config.json:
944
945 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
946
947         get rebaselining tools to kinda work with the skia overrides file
948         https://bugs.webkit.org/show_bug.cgi?id=88456
949
950         Reviewed by Ryosuke Niwa.
951
952         Update rebaseline-expectations so that we read in the overrides
953         when looking for tests to rebaseline, but don't read in the
954         overrides when we are writing the expectations file back out.
955         This prevents the overrides from getting written into the main
956         file. This is kind of a hack but will have to do until we
957         support multiple expectations files properly.
958
959         * Scripts/webkitpy/tool/commands/rebaseline.py:
960         (RebaselineExpectations._expectations):
961         (RebaselineExpectations._update_expectations_file):
962         (RebaselineExpectations._tests_to_rebaseline):
963         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
964         (test_overrides_are_included_correctly):
965
966 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
967
968         webkitpy: two manager_worker_broker_unittest tests are broken
969         https://bugs.webkit.org/show_bug.cgi?id=88445
970
971         Reviewed by Ojan Vafai.
972
973         These tests were never updated when we removed the
974         --worker-model argument, and we were passing 'inline' instead of
975         1 (for the number of workers) :(. As a result we were creating
976         multiprocessing queues unnecessarily and that was failing on cygwin.
977
978         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
979         (InterfaceTest.test_managerconnection_is_abstract):
980         (InterfaceTest.test_workerconnection_is_abstract):
981
982 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
983
984         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
985         https://bugs.webkit.org/show_bug.cgi?id=87406
986
987         Reviewed by Dirk Pranke.
988
989         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
990         (TestExpectations.__init__):
991         * Scripts/webkitpy/tool/commands/rebaseline.py:
992         (RebaselineTest._update_expectations_file):
993         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
994         (test_rebaseline_does_not_include_overrides):
995
996 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
997
998         webkitpy: perf tests unit tests fail on chromium win
999         https://bugs.webkit.org/show_bug.cgi?id=88279
1000
1001         Reviewed by Ryosuke Niwa.
1002
1003         I'm seeing weird failures running the unit tests in my win32
1004         checkout, and we don't really expect webpagereplay to work on
1005         win32 anyway, so I'm skipping the import of that module for now
1006         and adding a warning.
1007
1008         * Scripts/run-perf-tests:
1009         * Scripts/webkitpy/performance_tests/perftest.py:
1010
1011 2012-06-06  Yong Li <yoli@rim.com>
1012
1013         Unreviewed. Update my email address in committers.py.
1014
1015         * Scripts/webkitpy/common/config/committers.py:
1016
1017 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
1018
1019         Add Robert Kroeger  to commiters.py
1020         https://bugs.webkit.org/show_bug.cgi?id=88415
1021
1022         Unreviewed.
1023
1024         * Scripts/webkitpy/common/config/committers.py:
1025
1026 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1027
1028         [EFL][DRT] http/tests/globalhistory testcases do not pass
1029         https://bugs.webkit.org/show_bug.cgi?id=82579
1030
1031         Reviewed by Csaba Osztrogonác.
1032
1033         DRT has provided callbacks for ewk_view "global history delegate" signals.
1034
1035         * DumpRenderTree/efl/DumpRenderTree.cpp:
1036         (isGlobalHistoryTest): Aux function to ident global history testcase.
1037         (createLayoutTestController):
1038         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1039         (DumpRenderTreeChrome::createView):
1040         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
1041         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
1042         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
1043         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
1044         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
1045         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1046         (DumpRenderTreeChrome):
1047
1048 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
1049
1050         [Qt] run-qtwebkit-tests hangs with -j1
1051         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
1052         This could happen due to an uncancelled timer after results were returned. This timer was
1053         started only if --timeout was set.
1054         https://bugs.webkit.org/show_bug.cgi?id=85475
1055
1056         Reviewed by Csaba Osztrogonác.
1057
1058         * Scripts/run-qtwebkit-tests:
1059         (run_test):
1060
1061 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
1062
1063         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
1064         https://bugs.webkit.org/show_bug.cgi?id=88327
1065
1066         Reviewed by Kenneth Rohde Christiansen.
1067
1068         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
1069         * MiniBrowser/qt/icons/contents_width.png: Added.
1070         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
1071         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
1072
1073 2012-06-05  Jon Lee  <jonlee@apple.com>
1074
1075         Buildbot fix.
1076
1077         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
1078         in the function. Store in a local variable.
1079         (loadBuilderConfig):
1080
1081 2012-06-05  Jon Lee  <jonlee@apple.com>
1082
1083         Buildbot fix.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1086         (loadBuilderConfig):
1087
1088 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1089
1090         webkitpy: clean up win-specific path handling and tests
1091         https://bugs.webkit.org/show_bug.cgi?id=88281
1092
1093         Reviewed by Adam Barth.
1094
1095         There was a bunch of inconsistent logic for handling path
1096         conversions for win32 and cygwin paths due to us sometimes
1097         looking at sys.platform and sometimes using mock hosts. This
1098         patch cleans everything up so that we are required to pass
1099         PlatformInfo objects to the path module and stop trying to do
1100         different things when running on cygwin or win32 hosts (except
1101         in the path_unittest module itself).
1102
1103         This may slightly reduce test coverage for the win32 code paths
1104         but will be a lot easier to follow and maintain.
1105
1106         * Scripts/webkitpy/common/system/path.py:
1107         (abspath_to_uri):
1108         (_convert_path):
1109         * Scripts/webkitpy/common/system/path_unittest.py:
1110         (AbspathTest.platforminfo):
1111         (AbspathTest.test_abspath_to_uri_cygwin):
1112         (AbspathTest.test_abspath_to_uri_unixy):
1113         (AbspathTest.test_abspath_to_uri_win):
1114         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1115         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1116         (AbspathTest.test_stop_cygpath_subprocess):
1117         * Scripts/webkitpy/common/system/platforminfo.py:
1118         (PlatformInfo.__init__):
1119         (PlatformInfo.is_cygwin):
1120         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1121         (MockPlatformInfo.is_cygwin):
1122         * Scripts/webkitpy/layout_tests/port/base.py:
1123         (Port.to.show_results_html_file):
1124         * Scripts/webkitpy/layout_tests/port/driver.py:
1125         (Driver.test_to_uri):
1126         (Driver.uri_to_test):
1127         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1128         (DriverTest.test_test_to_uri):
1129         (DriverTest.test_uri_to_test):
1130         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1131         (MockDRTPortTest.make_port):
1132         (MockDRTTest.input_line):
1133         (MockChromiumDRTTest.test_pixeltest__fails):
1134         * Scripts/webkitpy/layout_tests/port/test.py:
1135         * Scripts/webkitpy/layout_tests/port/win.py:
1136         (WinPort.show_results_html_file):
1137         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1138         (MainTest.test_unexpected_failures):
1139         (MainTest.test_results_directory_absolute):
1140         (MainTest.test_results_directory_default):
1141         (MainTest.test_results_directory_relative):
1142
1143 2012-06-05  Jon Lee  <jonlee@apple.com>
1144
1145         Workaround buildbot bug when merging build requests.
1146         https://bugs.webkit.org/show_bug.cgi?id=88158
1147
1148         Reviewed by Mark Rowe.
1149
1150         For expediency, we still want testers to pick the latest build to test, but to ensure
1151         that the builders are reporting the correct revision number, we should let the building bots
1152         run as they normally would. That is, the builder picks the oldest revision, and merges
1153         subsequent requests. Because merged requests get appended to the list of changes for a given
1154         build, the last change in that list is also the latest change. When we used pickLatestBuild
1155         for the builders, this was not the case (it would always report the penultimate change).
1156
1157         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1158
1159         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1160         for all Apple builders.
1161         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1162         the latest build to run.
1163         (loadBuilderConfig):
1164
1165 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1166
1167         [Win] DumpRenderTree should call resetInternalsObject
1168         https://bugs.webkit.org/show_bug.cgi?id=88346
1169
1170         Reviewed by Simon Fraser.
1171
1172         Invoke it on Windows in the same place it is invoked on Mac.
1173
1174         * DumpRenderTree/win/DumpRenderTree.cpp:
1175         (resetWebViewToConsistentStateBeforeTesting):
1176
1177 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1178
1179         [GTK] Fix two more memory leaks in DRT
1180         https://bugs.webkit.org/show_bug.cgi?id=88255
1181
1182         Reviewed by Martin Robinson.
1183
1184         Fixed memory leaks in GTK's DRT code.
1185
1186         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1187         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1188         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1189         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1190         (createBitmapContextFromWebView): Free the cairo surface.
1191
1192 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1193
1194         [Qt] Building when a top directory is named Source
1195         https://bugs.webkit.org/show_bug.cgi?id=77727
1196
1197         Reviewed by Tor Arne Vestbø.
1198
1199         Change regex to only replace the last instance of OUT_PWD.
1200
1201         * qmake/mkspecs/features/default_pre.prf:
1202
1203 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1204
1205         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1206         https://bugs.webkit.org/show_bug.cgi?id=73176
1207
1208         Reviewed by Adam Barth.
1209
1210         Two more APIs are added in Custom Scheme Handler specification.
1211         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1212         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1213         is registered or not.
1214         The other is 'unregisterProtocolHandler' to remove the registered URL.
1215
1216         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1217
1218 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1219
1220         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1221         https://bugs.webkit.org/show_bug.cgi?id=83879
1222
1223         Reviewed by Carlos Garcia Campos.
1224
1225         Make minibrowser connect to the new 'permission requests' signal
1226         to allow users handle the Geolocation permission requests.
1227
1228         * MiniBrowser/gtk/BrowserWindow.c:
1229         (geolocationRequestDialogCallback): Callback for the dialog asking
1230         the user for allowing or not geolocation permission requests.
1231         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1232         whether to allow or deny geolocation permission requests.
1233         (browserWindowConstructed): Connect to 'permission-request' signal.
1234
1235 2012-06-04  Chase Phillips  <cmp@google.com>
1236
1237         Make a builder group support+expect multiple loads.
1238         https://bugs.webkit.org/show_bug.cgi?id=88260
1239
1240         Change BuilderGroup to allow expecting multiple
1241         loads.  This allows merging results for a given set
1242         of builders into one group.
1243
1244         Add a test that verifies that the group count
1245         increments correctly based on successful and failed
1246         list loads.
1247
1248         Reviewed by Ojan Vafai.
1249
1250         * TestResultServer/static-dashboards/builders.js:
1251         (BuilderGroup):
1252         (BuilderGroup.prototype.setbuilder):
1253         (BuilderGroup.prototype.append):
1254         (BuilderGroup.prototype.loaded):
1255         (requestBuilderList.xhr.onload):
1256         (requestBuilderList.xhr.onerror):
1257         (onErrorLoadingBuilderList):
1258         (loadBuildersList):
1259         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1260         (test):
1261         * TestResultServer/static-dashboards/run-unittests.html:
1262
1263 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Python test fix attempt for Chromium Windows.
1266
1267         * Scripts/webkitpy/layout_tests/port/driver.py:
1268         (Driver.uri_to_test):
1269
1270 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1271
1272         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1273         https://bugs.webkit.org/show_bug.cgi?id=88243
1274
1275         Reviewed by Adam Barth.
1276
1277         * qmake/mkspecs/features/features.prf:
1278
1279 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1280
1281         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1282         https://bugs.webkit.org/show_bug.cgi?id=88280
1283
1284         Unreviewed, build fix.
1285
1286         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1287         (TestServerProcess.test_basic):
1288
1289 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1290
1291         test-webkitpy is hanging under cygwin
1292         https://bugs.webkit.org/show_bug.cgi?id=88269
1293
1294         Reviewed by Ryosuke Niwa.
1295
1296         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1297         so we need to skip any tests that use it.
1298
1299         * Scripts/webkitpy/common/system/executive.py:
1300         (Executive.run_in_parallel):
1301         * Scripts/webkitpy/common/system/executive_unittest.py:
1302         (ExecutiveTest.test_run_in_parallel):
1303
1304 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1305
1306         test-webkitpy is failing on win32 after r115054
1307         https://bugs.webkit.org/show_bug.cgi?id=88264
1308
1309         Reviewed by Ryosuke Niwa.
1310
1311         The failing http_server test was improperly suppressed (the
1312         tuple was missing a comma, and so wasn't a tuple at all, just a
1313         string) and so we were skipping *all* tests on win32. The right
1314         way to skip a single test is to disable it inside the test
1315         itself.
1316
1317         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1318         (TestHttpServer.test_start_cmd):
1319         * Scripts/webkitpy/test/test_finder.py:
1320         (TestFinder._default_names):
1321         * Scripts/webkitpy/test/main.py:
1322         (Tester.run): Add error message if we don't find any tests to run.
1323         * Scripts/webkitpy/test/main_unittest.py:
1324             
1325
1326 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1327
1328         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1329         https://bugs.webkit.org/show_bug.cgi?id=88215
1330
1331         Reviewed by Martin Robinson.
1332
1333         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1334         for newly allocated strings.
1335
1336         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1337         (attributeSetToString):
1338         (AccessibilityUIElement::allAttributes):
1339
1340 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1341
1342         [GTK] Memory leaks in DumpRenderTree.cpp
1343         https://bugs.webkit.org/show_bug.cgi?id=88213
1344
1345         Reviewed by Martin Robinson.
1346
1347         Fixed memory leaks in DumpRenderTree.
1348
1349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1350         (appendString): Accepts const gchar* as the second argument.
1351         (dumpFramesAsText): Free the string returned by g_strdup_printf().
1352         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
1353
1354 2012-06-04  David Dorwin  <ddorwin@chromium.org>
1355
1356         Enable Chromium media player to instantiate a plugin
1357         https://bugs.webkit.org/show_bug.cgi?id=87399
1358
1359         Reviewed by Kent Tamura.
1360
1361         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
1362
1363         * DumpRenderTree/chromium/WebViewHost.cpp:
1364         (WebViewHost::createPopupMenu):
1365
1366 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
1367
1368         [GTK][WK2] Implement geolocation provider for the GTK port
1369         https://bugs.webkit.org/show_bug.cgi?id=83877
1370
1371         Reviewed by Carlos Garcia Campos.
1372
1373         * gtk/generate-gtkdoc:
1374         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
1375
1376 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1377
1378         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
1379         https://bugs.webkit.org/show_bug.cgi?id=87668
1380
1381         Reviewed by Ryosuke Niwa.
1382
1383         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
1384         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
1385         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
1386
1387         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1388         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1389
1390 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
1391
1392         [EFL] Refactor ewk_view_context_paint code.
1393         https://bugs.webkit.org/show_bug.cgi?id=85588
1394
1395         Reviewed by Hajime Morita.
1396
1397         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
1398
1399 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
1400
1401         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
1402         https://bugs.webkit.org/show_bug.cgi?id=87869
1403
1404         Reviewed by Andreas Kling.
1405
1406         Replace %lld by PRId64 macro to print an int64_t value and silent a
1407         compilation warning on 64-Bit.
1408
1409         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1410         (onExceededApplicationCacheQuota):
1411
1412 2012-06-03  Varun Jain  <varunjain@google.com>
1413
1414         [chromium] Add new gesture type (two finger tap) that triggers context menu.
1415         https://bugs.webkit.org/show_bug.cgi?id=88173
1416
1417         Reviewed by Adam Barth.
1418
1419         * DumpRenderTree/chromium/EventSender.cpp:
1420         (EventSender::EventSender):
1421         (EventSender::gestureTwoFingerTap):
1422         (EventSender::gestureEvent):
1423         * DumpRenderTree/chromium/EventSender.h:
1424         (EventSender):
1425
1426 2012-06-02  Zeno Albisser  <zeno@webkit.org>
1427
1428         Fix and enable WebGL for WebKit2 on Qt.
1429         https://bugs.webkit.org/show_bug.cgi?id=86214
1430
1431         Enable WebGL by default for Qt MiniBrowser.
1432
1433         Reviewed by Noam Rosenthal.
1434
1435         * MiniBrowser/qt/qml/BrowserWindow.qml:
1436
1437 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1438
1439         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
1440         https://bugs.webkit.org/show_bug.cgi?id=88164
1441
1442         Reviewed by Kentaro Hara.
1443
1444         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
1445         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
1446
1447         * Scripts/VCSUtils.pm:
1448         (adjustPathForRecentRenamings):
1449         (fixChangeLogPatch):
1450
1451 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1452
1453         Rename test_expectations.txt to TestExpectations
1454         https://bugs.webkit.org/show_bug.cgi?id=86690
1455
1456         Reviewed by Dirk Pranke.
1457
1458         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
1459         We can the code to read test_expectations.txt once we've successfully transitioned.
1460
1461         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1462         (TestExpectationParser._check_path_does_not_exist):
1463         (TestExpectationParser._tokenize):
1464         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
1465         * Scripts/webkitpy/layout_tests/port/base.py:
1466         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
1467         test_expectations.txt if one exists and the path to TestExpectations otherwise.
1468         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1469         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
1470         virtual.
1471         * Scripts/webkitpy/layout_tests/port/chromium.py:
1472         (ChromiumPort.path_from_chromium_base):
1473         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1474         (ChromiumAndroidPort.test_expectations):
1475         * Scripts/webkitpy/layout_tests/port/test.py:
1476         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1477         (TestPort.__init__):
1478         * Scripts/webkitpy/layout_tests/port/webkit.py:
1479         (WebKitPort.baseline_search_path):
1480         (WebKitPort.test_expectations):
1481         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1482         tests to base as a follow up.
1483         (WebKitPortTest.test_path_to_test_expectations_file):
1484         (test_test_expectations):
1485         (test_legacy_test_expectations):
1486         * Scripts/webkitpy/style/checker.py:
1487         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1488         with one for TestExpectations.
1489         * Scripts/webkitpy/style/checkers/test_expectations.py:
1490         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1491         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1492         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1493         test_expectations.txt.
1494         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1495         (TestExpectationsTestCase.assert_lines_lint):
1496         * Scripts/webkitpy/tool/commands/queries.py:
1497         (PrintExpectations.__init__):
1498         * Scripts/webkitpy/tool/commands/rebaseline.py:
1499         (RebaselineExpectations):
1500         * Scripts/webkitpy/tool/steps/commit.py:
1501         (Commit._check_test_expectations):
1502         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1503         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1504         (CommitTest.test_check_test_expectations): For TestExpectations.
1505         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1506         * TestResultServer/static-dashboards/dashboard_base.js:
1507         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1508         Error only when neither exists.
1509         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1510         (processMissingAndExtraExpectations):
1511         (htmlForTestsWithExpectationsButNoFailures):
1512         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1513
1514 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1515
1516         Remove dependency from ImageDiff to WTF
1517         https://bugs.webkit.org/show_bug.cgi?id=88147
1518
1519         Reviewed by Adam Barth.
1520
1521         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1522
1523 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1524
1525         NRWT seems to leak (more?) temp dirs
1526         https://bugs.webkit.org/show_bug.cgi?id=88126
1527
1528         Re-land r119297 with chromium fix (weren't calling the
1529         super() method if not in --test-shell mode in start().
1530         Add unit tests to chromium_unittest as well to check.
1531
1532         * Scripts/webkitpy/layout_tests/port/chromium.py:
1533         (ChromiumDriver.start):
1534         * Scripts/webkitpy/layout_tests/port/webkit.py:
1535         (WebKitDriver.__del__):
1536         (WebKitDriver._start):
1537         (WebKitDriver.run_test):
1538         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1539         (WebKitDriverTest.test_check_for_driver_crash):
1540         (WebKitDriverTest.test_stop_cleans_up_properly):
1541         (WebKitDriverTest):
1542         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1543         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1544         (ChromiumDriverTest.test_stop_cleans_up_properly):
1545         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1546
1547 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1548
1549         Lots of "failed download-built-product" on Apple bots
1550         https://bugs.webkit.org/show_bug.cgi?id=88158
1551
1552         Reviewed by Jessie Berlin.
1553         
1554         Disable mergeRequests on all Apple builders. This is a speculative fix.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/config.json:
1557
1558 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1559
1560         Unreviewed, rolling out r119297.
1561         http://trac.webkit.org/changeset/119297
1562         https://bugs.webkit.org/show_bug.cgi?id=88156
1563
1564         May have broken Chromium bots (Requested by rniwa on #webkit).
1565
1566         * Scripts/webkitpy/layout_tests/port/webkit.py:
1567         (WebKitDriver.__del__):
1568         (WebKitDriver.run_test):
1569         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1570         (WebKitDriverTest.test_check_for_driver_crash):
1571         (WebKitDriverTest.test_stop_cleans_up_properly):
1572
1573 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1574
1575         nrwt seems to leak tmpdirs
1576         https://bugs.webkit.org/show_bug.cgi?id=88126
1577
1578         Reviewed by Ojan Vafai.
1579
1580         Fix leak possibly introduced in r118979 - we now will
1581         make sure we clean up any stale temp directories during the
1582         start routine and attempt to clean up again in __del__. It
1583         turns out that asserting in __del__ logs a message but is
1584         caught by the runtime, so it's mostly useless.
1585
1586         * Scripts/webkitpy/layout_tests/port/webkit.py:
1587         (WebKitDriver.__del__):
1588         (WebKitDriver._start):
1589         (WebKitDriver.run_test):
1590         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1591         (WebKitDriverTest.test_check_for_driver_crash):
1592         (WebKitDriverTest.test_stop_cleans_up_properly):
1593         (WebKitDriverTest):
1594         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1595
1596 2012-06-01  Michael Saboff  <msaboff@apple.com>
1597
1598         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1599         https://bugs.webkit.org/show_bug.cgi?id=88109
1600
1601         Reviewed by Geoffrey Garen.
1602
1603         Additional test case.
1604
1605         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1606         (TestWebKitAPI::TEST):
1607
1608 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1609
1610         [Qt] Use -Werror only in developer builds
1611
1612         Rubber-stamped by Tor Arne Vestbø.
1613
1614         In production builds -Werror with custom toolchains and wierd system
1615         headers, -Werror is of no use and just creates confusion. So use it
1616         only if Qt is configured with -developer-build.
1617
1618         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1619         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1620         only if qt_developer_build is set.
1621
1622 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1623
1624         [watchlist] Add myself to loader and v8 bindings changes
1625         https://bugs.webkit.org/show_bug.cgi?id=88112
1626
1627         Reviewed by Adam Barth.
1628
1629         * Scripts/webkitpy/common/config/watchlist:
1630
1631 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1632
1633         Adding Jacky Jiang to committers.py
1634         https://bugs.webkit.org/show_bug.cgi?id=88122
1635
1636         Reviewed by Rob Buis.
1637
1638         Adding myself to committers.py as a Committer.
1639
1640         * Scripts/webkitpy/common/config/committers.py:
1641
1642 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1643
1644         Fix Windows build.
1645
1646         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1647
1648 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1649
1650         Windows WK2 MouseMoveAfterCrash API test failing
1651         https://bugs.webkit.org/show_bug.cgi?id=69982
1652
1653         Disable the test on Windows to get the bots greener.
1654
1655         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1656         (TestWebKitAPI::TEST):
1657
1658 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1659
1660         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1661         https://bugs.webkit.org/show_bug.cgi?id=86866
1662
1663         Reviewed by Adam Barth.
1664
1665         Catch new "intent,service,register" signal on the frame and print out
1666         information about the Web Intent service in EFL's DumpRenderTree.
1667
1668         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1669         (DumpRenderTreeChrome::createView):
1670         (DumpRenderTreeChrome::onFrameCreated):
1671         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1672         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1673         (DumpRenderTreeChrome):
1674
1675 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1676
1677         The ChangeLog parser cannot handle reviewers with initials in their name
1678         https://bugs.webkit.org/show_bug.cgi?id=87864
1679
1680         Reviewed by Ryosuke Niwa.
1681
1682         Add support in the ChangeLog parser for reviewer names that have
1683         initials in them.
1684
1685         * Scripts/webkitpy/common/checkout/changelog.py:
1686         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1687         in the replacement string. This allows for matching the word characters before a
1688         period, without totally throwing them away.
1689         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1690         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1691         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1692
1693 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1694
1695         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1696         https://bugs.webkit.org/show_bug.cgi?id=86865
1697
1698         Reviewed by Adam Barth.
1699
1700         Add deliverWebIntent method to LayoutTestController and provide
1701         implementation for EFL port.
1702
1703         * DumpRenderTree/LayoutTestController.cpp:
1704         (deliverWebIntentCallback):
1705         (LayoutTestController::staticFunctions):
1706         * DumpRenderTree/LayoutTestController.h:
1707         (LayoutTestController):
1708         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1709         (LayoutTestController::deliverWebIntent):
1710         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1711         (LayoutTestController::deliverWebIntent):
1712         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1713         (LayoutTestController::deliverWebIntent):
1714         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1715         (LayoutTestController::deliverWebIntent):
1716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1717         (LayoutTestController::deliverWebIntent):
1718         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1719         (LayoutTestController::deliverWebIntent):
1720
1721 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1722
1723         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1724
1725         Reviewed by Simon Hausmann.
1726
1727         * Tools.pro:
1728
1729 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1730
1731         Add public page loading performance tests using web-page-replay
1732         https://bugs.webkit.org/show_bug.cgi?id=84008
1733
1734         Reviewed by Dirk Pranke.
1735
1736         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1737         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1738         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1739
1740         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1741         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1742         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1743         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1744
1745         * Scripts/webkitpy/layout_tests/port/driver.py:
1746         (Driver.is_external_http_test): Added.
1747         * Scripts/webkitpy/layout_tests/port/webkit.py:
1748         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1749         * Scripts/webkitpy/performance_tests/perftest.py:
1750         (PerfTest.__init__): Takes port.
1751         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1752         (PerfTest):
1753         (PerfTest.run): Calls run_single.
1754         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1755         (ChromiumStylePerfTest.__init__):
1756         (PageLoadingPerfTest.__init__):
1757         (PageLoadingPerfTest.run):
1758         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1759         (ReplayServer.__init__):
1760         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1761         but it caused a dead lock on some web pages.
1762         (ReplayServer.stop):
1763         (ReplayServer.__del__):
1764         (ReplayPerfTest):
1765         (ReplayPerfTest.__init__):
1766         (ReplayPerfTest._start_replay_server):
1767         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1768         The subsequent runs of the same test will just use test.wpr.
1769         (ReplayPerfTest.run_single):
1770         (PerfTestFactory):
1771         (PerfTestFactory.create_perf_test):
1772         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1773         (MainTest.test_parse_output):
1774         (MainTest.test_parse_output_with_failing_line):
1775         (TestPageLoadingPerfTest.test_run):
1776         (TestPageLoadingPerfTest.test_run_with_bad_output):
1777         (TestReplayPerfTest):
1778         (TestReplayPerfTest.ReplayTestPort):
1779         (TestReplayPerfTest.ReplayTestPort.__init__):
1780         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1781         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1782         (TestReplayPerfTest.ReplayTestPort._driver_class):
1783         (TestReplayPerfTest.MockReplayServer):
1784         (TestReplayPerfTest.MockReplayServer.__init__):
1785         (TestReplayPerfTest.MockReplayServer.stop):
1786         (TestReplayPerfTest._add_file):
1787         (TestReplayPerfTest._setup_test):
1788         (TestReplayPerfTest.test_run_single):
1789         (TestReplayPerfTest.test_run_single.run_test):
1790         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1791         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1792         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1793         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1794         (TestReplayPerfTest.test_prepare):
1795         (TestReplayPerfTest.test_prepare.run_test):
1796         (TestReplayPerfTest.test_prepare_calls_run_single):
1797         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1798         (TestPerfTestFactory.test_regular_test):
1799         (TestPerfTestFactory.test_inspector_test):
1800         (TestPerfTestFactory.test_page_loading_test):
1801         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1802         (PerfTestsRunner):
1803         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1804         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1805         (PerfTestsRunner._collect_tests._is_test_file):
1806         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1807         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1808         (create_runner):
1809         (run_test):
1810         (_tests_for_runner):
1811         (test_run_test_set):
1812         (test_run_test_set_kills_drt_per_run):
1813         (test_run_test_pause_before_testing):
1814         (test_run_test_set_for_parser_tests):
1815         (test_run_test_set_with_json_output):
1816         (test_run_test_set_with_json_source):
1817         (test_run_test_set_with_multiple_repositories):
1818         (test_run_with_upload_json):
1819         (test_upload_json):
1820         (test_upload_json.MockFileUploader.upload_single_text_file):
1821         (_add_file):
1822         (test_collect_tests):
1823         (test_collect_tests_with_multile_files):
1824         (test_collect_tests_with_multile_files.add_file):
1825         (test_collect_tests_with_skipped_list):
1826         (test_collect_tests_with_page_load_svg):
1827         (test_collect_tests_should_ignore_replay_tests_by_default):
1828         (test_collect_tests_with_replay_tests):
1829         (test_parse_args):
1830         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1831         (AutoinstallImportHook.find_module):
1832         (AutoinstallImportHook._install_webpagereplay):
1833
1834 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1835
1836         Support building the Android port of chromium with Ninja
1837         https://bugs.webkit.org/show_bug.cgi?id=87545
1838
1839         Reviewed by Adam Barth.
1840
1841         Ensures that shared libraries are looked up in a generator-agnostic
1842         way and that output is placed in the correct directory.
1843
1844         Depends on http://codereview.chromium.org/10386188/
1845
1846         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1847
1848 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1849
1850         [Chromium] Chromium DRT should be able to load external resources
1851         https://bugs.webkit.org/show_bug.cgi?id=87893
1852
1853         Reviewed by Dirk Pranke.
1854
1855         Allow external resources to be loaded when the main frame's URL is also an external resource.
1856         This change is analogous to r118231 for Mac port.
1857
1858         * DumpRenderTree/chromium/WebViewHost.cpp:
1859         (blockRequest):
1860         (isLocalhost):
1861         (hostIsUsedBySomeTestsToGenerateError):
1862         (WebViewHost::willSendRequest):
1863
1864 2012-05-31  Anders Carlsson  <andersca@apple.com>
1865
1866         Build fixes.
1867
1868         Disable the C++11 extensions warning.
1869
1870         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1871         * TestWebKitAPI/Configurations/Base.xcconfig:
1872         * WebKitTestRunner/Configurations/Base.xcconfig:
1873
1874 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1875
1876         [WK2] window.internals settings are not reset between tests
1877         https://bugs.webkit.org/show_bug.cgi?id=87783
1878
1879         Reviewed by Mihai Parparita.
1880
1881         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1882         (WTR::InjectedBundle::done): Call resetAfterTest().
1883
1884         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1885         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1886         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1887         This needs to be done after a tets, because the code assumes that there is an object
1888         with this name in global scope.
1889
1890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1891
1892 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1893
1894         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1895         https://bugs.webkit.org/show_bug.cgi?id=85006
1896
1897         Reviewed by Tor Arne Vestbø.
1898
1899         Added navigation_policy_decision implementation for DumpRenderTreeView.
1900         Added LayoutTestController::setCustomPolicyDelegate implementation.
1901         Modified LayoutTestController::waitForPolicyDelegate.
1902
1903         * DumpRenderTree/efl/DumpRenderTree.cpp:
1904         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1905         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1906         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1907         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1908         (navigationTypeToString): aux function
1909         (onNavigationPolicyDecision): navigation_policy_decision implementation
1910         (drtViewAdd):
1911         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1912         (LayoutTestController::setCustomPolicyDelegate):
1913         (LayoutTestController::waitForPolicyDelegate):
1914
1915 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1916
1917         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1918         https://bugs.webkit.org/show_bug.cgi?id=86195
1919
1920         Reviewed by Gustavo Noronha Silva.
1921
1922         Implement clearApplicationCacheForOrigin in EFL
1923         LayoutTestController.
1924
1925         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1926         (LayoutTestController::clearApplicationCacheForOrigin):
1927
1928 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1929
1930         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1931         https://bugs.webkit.org/show_bug.cgi?id=87955
1932
1933         Reviewed by Simon Hausmann.
1934
1935         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1936         * DumpRenderTree/qt/EventSenderQt.cpp:
1937         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1938         * DumpRenderTree/qt/main.cpp:
1939         * QtTestBrowser/cookiejar.cpp:
1940         * QtTestBrowser/launcherwindow.cpp:
1941         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1942         * qmake/mkspecs/features/default_post.prf:
1943
1944 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1945
1946         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1947
1948         Rubber-stamped by Kenneth Rohde Christiansen.
1949
1950         * qmake/config.tests/libpng/libpng.pro:
1951
1952 2012-05-30  Peter Beverloo  <peter@chromium.org>
1953
1954         [Chromium] Automatically install 64-bit linker for Android
1955         https://bugs.webkit.org/show_bug.cgi?id=79780
1956
1957         Reviewed by Adam Barth.
1958
1959         Change the update-webkit-chromium script to check whether the 64-bit
1960         linker needs to be installed as part of the update process. The actual
1961         code for doing these checks and "installing" it has been added to the
1962         webkitdirs.pm script.
1963
1964         The linker itself is part of the third_party/aosp repository, which
1965         will be pulled in through the DEPS change.
1966
1967         * Scripts/update-webkit-chromium:
1968         * Scripts/webkitdirs.pm:
1969         (chromiumInstall64BitAndroidLinkerIfNeeded):
1970         (chromiumReplaceAndroidLinkerIfNeeded):
1971
1972 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1973
1974         https://bugs.webkit.org/show_bug.cgi?id=87803
1975         Layout tests often fail trying to stat nonexistent logs 
1976
1977         Reviewed by Dirk Pranke.
1978
1979         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1980         try/catch block around accessing the logs as a precaution.
1981
1982         * Scripts/webkitpy/common/system/crashlogs.py:
1983         (CrashLogs._find_newest_log_darwin):
1984
1985 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1986
1987         Add a LayoutTest for prerender remove after stop.
1988         https://bugs.webkit.org/show_bug.cgi?id=87860
1989
1990         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1991         can be tested by LayoutTests now.
1992
1993         Reviewed by Adam Barth.
1994
1995         * DumpRenderTree/DumpRenderTree.gypi:
1996         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1997         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1998         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1999         (MockWebPrerenderingSupport::add):
2000         (MockWebPrerenderingSupport::cancel):
2001         (MockWebPrerenderingSupport::abandon):
2002         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
2003         (MockWebPrerenderingSupport):
2004         * DumpRenderTree/chromium/TestShell.cpp:
2005         (TestShell::initialize):
2006         * DumpRenderTree/chromium/TestShell.h:
2007         (TestShell):
2008         * DumpRenderTree/chromium/WebViewHost.cpp:
2009         (WebViewHost::willAddPrerender):
2010         (WebViewHost::setWebWidget):
2011         * DumpRenderTree/chromium/WebViewHost.h:
2012         (WebViewHost):
2013
2014 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=87717
2017         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
2018
2019         Reviewed by Dirk Pranke.
2020
2021         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
2022         If there isn't a crash log found for the process add a message saying
2023         the process was unresponsive.
2024
2025         * Scripts/webkitpy/layout_tests/port/webkit.py:
2026         (WebKitDriver.__init__):
2027         (WebKitDriver._check_for_driver_crash):
2028         (WebKitDriver.run_test):
2029         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2030         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2031         (WebKitDriverTest):
2032         (WebKitDriverTest.test_check_for_driver_crash):
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR):
2035         (WTR::TestController::runTest):
2036
2037 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2038
2039         https://bugs.webkit.org/show_bug.cgi?id=87714
2040         Mac crash logs can take a really long time to be written out.
2041
2042         Reviewed by Dirk Pranke.
2043
2044         Make a second pass looking for crash logs after the tests have completed running.
2045
2046         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2047         (use_trac_links_in_results_html):
2048         (Manager.run):
2049         * Scripts/webkitpy/layout_tests/port/base.py:
2050         (Port.repository_paths):
2051         (Port.look_for_new_crash_logs):
2052         * Scripts/webkitpy/layout_tests/port/mac.py:
2053         (MacPort.look_for_new_crash_logs):
2054         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2055         (test_get_crash_log):
2056         (test_look_for_new_crash_logs):
2057         (test_look_for_new_crash_logs.fake_time_cb):
2058
2059 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2060
2061         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
2062
2063         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2064         (LayoutWebViewEventHandler::OnAlertEvent):
2065         (LayoutWebViewEventHandler::OnConfirmEvent):
2066         (LayoutWebViewEventHandler):
2067         (LayoutWebViewEventHandler::OnPromptEvent):
2068         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2069         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2070
2071 2012-05-30  Ojan Vafai  <ojan@chromium.org>
2072
2073         Only give lint errors for -expected.png png files that lack a checksum
2074         https://bugs.webkit.org/show_bug.cgi?id=87875
2075
2076         Reviewed by Tony Chang.
2077
2078         We have other pngs in the tree, e.g. for the inspector, that legitimately
2079         lack a checksum.
2080
2081         * Scripts/webkitpy/style/checkers/png.py:
2082         (PNGChecker.check):
2083         * Scripts/webkitpy/style/checkers/png_unittest.py:
2084         (PNGCheckerTest.test_check):
2085
2086 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
2087
2088         nrwt: seems to leak temp dirs
2089         https://bugs.webkit.org/show_bug.cgi?id=87795
2090
2091         Reviewed by Ojan Vafai.
2092
2093         There appears to be a bug where the chromium bots are creating
2094         temporary directories and not cleaning them up that started
2095         after the switch to WebKitDriver. It's possible that __del__
2096         wasn't getting called in a timely manner (or at all), and it's
2097         generally bad style to rely on __del__ being called, so this
2098         code changes things so that we create a temp dir in
2099         driver.start() and remove it in driver.stop(). We could be
2100         paranoid and leave the __del__ code in, but there doesn't seem
2101         to be much advantage to it. If there are bugs that result in
2102         drivers being started but not stopped, we have other problems.
2103
2104         * Scripts/webkitpy/common/system/filesystem_mock.py:
2105         (MockFileSystem.__init__):
2106         (MockFileSystem._mktemp):
2107         (MockFileSystem.mkdtemp):
2108         * Scripts/webkitpy/layout_tests/port/webkit.py:
2109         (WebKitDriver.__init__):
2110         (WebKitDriver._start):
2111         (WebKitDriver.stop):
2112         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2113         (WebKitDriverTest.test_check_for_driver_crash):
2114         (WebKitDriverTest):
2115         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2116         (WebKitDriverTest.test_stop_cleans_up_properly):
2117
2118 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2119
2120         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2121         https://bugs.webkit.org/show_bug.cgi?id=86841
2122
2123         Reviewed by Adam Barth.
2124
2125         Print the number of MessagePorts for each new intent in EFL's DRT.
2126         This output is expected by several Web Intents test cases.
2127
2128         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2129         (DumpRenderTreeChrome::onFrameIntentNew):
2130
2131 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2132
2133         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2134
2135         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2136
2137 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2138
2139         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2140         https://bugs.webkit.org/show_bug.cgi?id=87829
2141
2142         Reviewed by Adam Barth.
2143
2144         EFL's LayoutTestController now makes uses of the new helper method in
2145         DumpRenderTreeSupportEfl in order to send the intent response. This is
2146         now needed because the Ewk_Intent_Request postResult / postFailure
2147         methods were made private.
2148
2149         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2150         (LayoutTestController::sendWebIntentResponse):
2151
2152 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2153
2154         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2155         https://bugs.webkit.org/show_bug.cgi?id=86296
2156
2157         Reviewed by Tony Chang.
2158
2159         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2160         (cfHDropFormat):
2161         (cfFileNameWFormat):
2162         (cfUrlWFormat):
2163         (WCEnumFormatEtc):
2164         (WCEnumFormatEtc::WCEnumFormatEtc):
2165         (WCEnumFormatEtc::QueryInterface):
2166         (WCEnumFormatEtc::AddRef):
2167         (WCEnumFormatEtc::Release):
2168         (WCEnumFormatEtc::Next):
2169         (WCEnumFormatEtc::Skip):
2170         (WCEnumFormatEtc::Reset):
2171         (WCEnumFormatEtc::Clone):
2172         (DRTDataObject::createInstance):
2173         (DRTDataObject::DRTDataObject):
2174         (DRTDataObject::~DRTDataObject):
2175         (DRTDataObject::QueryInterface):
2176         (DRTDataObject::AddRef):
2177         (DRTDataObject::Release):
2178         (DRTDataObject::GetData):
2179         (DRTDataObject::GetDataHere):
2180         (DRTDataObject::QueryGetData):
2181         (DRTDataObject::GetCanonicalFormatEtc):
2182         (DRTDataObject::SetData):
2183         (DRTDataObject::CopyMedium):
2184         (DRTDataObject::EnumFormatEtc):
2185         (DRTDataObject::DAdvise):
2186         (DRTDataObject::DUnadvise):
2187         (DRTDataObject::EnumDAdvise):
2188         (DRTDataObject::clearData):
2189         * DumpRenderTree/win/DRTDataObject.h: Added.
2190         (DRTDataObject):
2191         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2192         (DRTDropSource::DRTDropSource):
2193         (DRTDropSource::~DRTDropSource):
2194         (DRTDropSource::QueryInterface):
2195         (DRTDropSource::AddRef):
2196         (DRTDropSource::Release):
2197         (DRTDropSource::createInstance):
2198         (DRTDropSource::QueryContinueDrag):
2199         (DRTDropSource::GiveFeedback):
2200         * DumpRenderTree/win/DRTDropSource.h: Added.
2201         (DRTDropSource):
2202         * DumpRenderTree/win/DumpRenderTree.vcproj:
2203         * DumpRenderTree/win/EventSender.cpp:
2204         (beginDragWithFilesCallback):
2205
2206 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2207
2208         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2209         https://bugs.webkit.org/show_bug.cgi?id=58593
2210
2211         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2212         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2213         public C API of the WebProcess.
2214
2215         Reviewed by Darin Adler.
2216
2217         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2218         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2219         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2220         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2221         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2222
2223 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2224
2225         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2226         https://bugs.webkit.org/show_bug.cgi?id=87848
2227
2228         Reviewed by Csaba Osztrogonác.
2229
2230         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2231         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2232         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2233
2234         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2235         (DumpRenderTreeChrome::extraViews):
2236         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2237         (DumpRenderTreeChrome):
2238
2239 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2240
2241         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2242         https://bugs.webkit.org/show_bug.cgi?id=87833
2243
2244         Reviewed by Tor Arne Vestbø.
2245
2246         Print "postProgressFinishedNotification" message if frame load finished 
2247         to unskip http/tests/loading/progress-finished-callback.html.
2248
2249         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2250         (DumpRenderTreeChrome::onFrameLoadFinished):
2251
2252 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2253
2254         [EFL][WK2] Fix WebKit2-EFL build
2255         https://bugs.webkit.org/show_bug.cgi?id=83693
2256
2257         Reviewed by Carlos Garcia Campos.
2258
2259         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2260
2261 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2262
2263         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2264         (They only used to check for Skipped in platform/qt-5.0-wk1)
2265         https://bugs.webkit.org/show_bug.cgi?id=87376
2266
2267         Reviewed by Csaba Osztrogonác.
2268
2269         * Scripts/old-run-webkit-tests:
2270         (buildPlatformResultHierarchy):
2271         * Scripts/webkitpy/layout_tests/port/qt.py:
2272         (QtPort.baseline_search_path):
2273
2274 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2275
2276         Add a linter error for pngs that lack an embedded checksum
2277         https://bugs.webkit.org/show_bug.cgi?id=87793
2278
2279         Reviewed by Dirk Pranke.
2280
2281         * Scripts/read-checksum-from-png:
2282         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2283         (read_checksum):
2284         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2285         (ReadChecksumFromPngTest):
2286         (ReadChecksumFromPngTest.test_read_checksum):
2287         * Scripts/webkitpy/layout_tests/port/base.py:
2288         * Scripts/webkitpy/style/checkers/png.py:
2289         (PNGChecker.check):
2290         * Scripts/webkitpy/style/checkers/png_unittest.py:
2291         (PNGCheckerTest.test_check):
2292
2293 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=87720
2296         WebProcess is often killed due to being unresponsive on the bots
2297
2298         Reviewed by Alexey Proskuryakov.
2299
2300         Blind attempt to improve flakiness on the bots by reducing the number
2301         of crashes due to an unresponsive process.  This helped on my personal machine
2302         under stress conditions.  I don't have enough cores to hit the problem
2303         under normal conditions.
2304
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR):
2307
2308 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2309
2310         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2311         https://bugs.webkit.org/show_bug.cgi?id=87779
2312
2313         Reviewed by Eric Seidel.
2314
2315         Update output to match the names in scm.py as per
2316         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2317
2318         * Scripts/webkitpy/tool/commands/rebaseline.py:
2319         (RebaselineTest.execute):
2320         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2321         (test_rebaseline_test_and_print_scm_changes):
2322         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2323         (GardeningServerTest.test_rebaselineall):
2324
2325 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2326
2327         https://bugs.webkit.org/show_bug.cgi?id=87711
2328
2329         Reviewed by Jessie Berlin.
2330
2331         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2332         are better maintained.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/config.json:
2335
2336 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2337
2338         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2339         https://bugs.webkit.org/show_bug.cgi?id=87538
2340
2341         Reviewed by Ojan Vafai.
2342
2343         Invoking git and svn on one file at a time is kinda slow. We
2344         should batch the add and rm operations together.
2345
2346         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2347         (BaselineOptimizer._move_baselines):
2348
2349 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2350
2351         garden-o-matic should rebaseline baselines in parallel
2352         https://bugs.webkit.org/show_bug.cgi?id=87451
2353
2354         Reviewed by Ojan Vafai.
2355                                                                                
2356         This modifies garden-o-matic so that we will fetch all                  
2357         of the baselines in parallel from the bots, and then                    
2358         optimize the baselines serially (since that should be fairly            
2359         quick and we get into trouble if we optimize in parallel due            
2360         to concurrent access to the source control system).                     
2361
2362         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
2363         so that the files that need to be modified in the SCM are returned to 
2364         garden-o-matic rather than actually added or removed. This is done so that
2365         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
2366         concurrently). In order to safely return the files (as a JSON dict) I
2367         needed to shift all of the logging in rebaseline-test to use the logging
2368         module (and hence log to stderr).
2369
2370         I also had to stub out a line in chromium.py that would get confused if
2371         the skia overrides file didn't exist in a mock checkout.
2372
2373         * Scripts/webkitpy/common/system/executive.py:
2374         (Executive.popen):
2375         (Executive):
2376         (Executive.run_in_parallel):
2377         (_run_command_thunk):
2378         * Scripts/webkitpy/common/system/executive_mock.py:
2379         (MockExecutive.run_in_parallel):
2380         * Scripts/webkitpy/common/system/executive_unittest.py:
2381         (ExecutiveTest.test_run_in_parallel):
2382         * Scripts/webkitpy/layout_tests/port/chromium.py:
2383         (ChromiumPort._expectations_file_contents):
2384         * Scripts/webkitpy/tool/commands/rebaseline.py:
2385         (AbstractRebaseliningCommand.__init__):
2386         (RebaselineTest.__init__):
2387         (RebaselineTest._copy_existing_baseline):
2388         (RebaselineTest._save_baseline):
2389         (RebaselineTest):
2390         (RebaselineTest._add_to_scm):
2391         (RebaselineTest._rebaseline_test):
2392         (RebaselineTest.execute):
2393         (RebaselineExpectations._rebaseline_port):
2394         (RebaselineExpectations.execute):
2395         (Rebaseline._builder_to_pull_from):
2396         (Rebaseline.execute):
2397         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2398         (test_rebaseline_updates_expectations_file):
2399         (test_rebaseline_test):
2400         (test_rebaseline_test_and_print_scm_changes):
2401         (test_rebaseline_and_copy_test):
2402         (test_rebaseline_and_copy_test_no_existing_result):
2403         (test_rebaseline_and_copy_test_with_lion_result):
2404         (test_rebaseline_and_copy_no_overwrite_test):
2405         (test_rebaseline_expectations):
2406         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2407         (GardeningHTTPRequestHandler._rebaseline_commands):
2408         (GardeningHTTPRequestHandler):
2409         (GardeningHTTPRequestHandler._files_to_add):
2410         (GardeningHTTPRequestHandler._optimize_baselines):
2411         (GardeningHTTPRequestHandler.rebaselineall):
2412         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2413         (GardeningServerTest._post_to_path):
2414         (GardeningServerTest.test_rebaselineall):
2415         (GardeningServerTest.test_rebaselineall.run_command):
2416
2417 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
2418
2419         Fix the type of dispatch_time() offset
2420
2421         Rubber-stamped by Joseph Pecoraro.
2422
2423         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
2424
2425         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2426         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2427
2428 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2429
2430         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2431
2432         [BlackBerry] OpenGL content is not rendered on simulator
2433         https://bugs.webkit.org/show_bug.cgi?id=87721
2434
2435         Reviewed by George Staikos.
2436
2437         Fixed by enabling GLES2 support in simulator builds.
2438
2439         To experiment with building without OpenGL support, you can set the
2440         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
2441
2442         PR #150695
2443
2444         * Scripts/webkitdirs.pm:
2445         (blackberryCMakeArguments):
2446
2447 2012-05-29  David Barr  <davidbarr@chromium.org>
2448
2449         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
2450         https://bugs.webkit.org/show_bug.cgi?id=87685
2451
2452         Reviewed by Eric Seidel.
2453
2454         Add a configuration option for CSS image-resolution support, disabling it by default.
2455
2456         * Scripts/webkitperl/FeatureList.pm:
2457         * qmake/mkspecs/features/features.pri:
2458
2459 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2460
2461         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
2462
2463         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
2464             valid for C++/ObjC++ but not for C [enabled by default]"
2465
2466         Reviewed by Simon Hausmann.
2467
2468         * qmake/mkspecs/features/unix/default_post.prf:
2469
2470 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2471
2472         [Qt] Sync up favicon-implementation with WebView url changes in r118158
2473
2474         https://bugs.webkit.org/show_bug.cgi?id=87133
2475
2476         We now base64-encode the page url in the image-provider url, so that any
2477         normalization done by QUrl will not mess up the page-url. The logic of
2478         creating and parsing the provider-url has been moved into the image
2479         provider, to keep it in one place.
2480
2481         We were also releasing icons (even ones we hadn't retained), which we can't
2482         do since we don't know when the icon url is no longer in use.
2483
2484         Reviewed-by Simon Hausmann.
2485
2486         * MiniBrowser/qt/icons/favicon.png:
2487         * MiniBrowser/qt/qml/BrowserWindow.qml:
2488
2489 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2490
2491         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2492         https://bugs.webkit.org/show_bug.cgi?id=87654
2493
2494         Reviewed by Csaba Osztrogonác.
2495
2496         Event sender provides strings for all the key events.
2497         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2498         a key event has empty string.
2499
2500         * DumpRenderTree/efl/EventSender.cpp:
2501         (KeyEventInfo::KeyEventInfo):
2502         (keyPadNameFromJSValue):
2503         (keyNameFromJSValue):
2504
2505 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2506
2507         [Qt] Cancel potential url-edit when going back/forward
2508
2509         Reviewed by Kenneth Rohde Christiansen.
2510
2511         * MiniBrowser/qt/qml/BrowserWindow.qml:
2512
2513 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2514
2515         [EFL] Compilation warning in DumpRenderTreeView.cpp
2516         https://bugs.webkit.org/show_bug.cgi?id=87636
2517
2518         Reviewed by Filip Pizlo.
2519
2520         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2521         specifier in printf. Also fix the return type for
2522         onExceededApplicationCacheQuota callback.
2523
2524         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2525         (onExceededApplicationCacheQuota):
2526
2527 2012-05-29  Hironori Bono  <hbono@chromium.org>
2528
2529         Adding Hironori Bono to committers.py.
2530         https://bugs.webkit.org/show_bug.cgi?id=87697
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2535
2536         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2537         https://bugs.webkit.org/show_bug.cgi?id=80135
2538
2539         Reviewed by Rob Buis.
2540
2541         Implemented interface function didReceiveAuthenticationChallenge in class
2542         DumpRenderTree.
2543
2544         Resubmit the patch reverted by r115104 after the digest infinite loop
2545         issue for BlackBerry porting get identified and fixed.
2546
2547         Internally reviewed by Joe Mason <jmason@rim.com>
2548
2549         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2550         (drtCredentialDescription):
2551         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2552         (WebKit):
2553         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2554         (WebCore):
2555         (DumpRenderTree):
2556
2557 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2558
2559         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2560         https://bugs.webkit.org/show_bug.cgi?id=42328
2561
2562         Reviewed by Eric Seidel.
2563
2564         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2565         move to windows.internals.settings.
2566
2567         * DumpRenderTree/LayoutTestController.cpp:
2568         (LayoutTestController::staticFunctions):
2569         * DumpRenderTree/LayoutTestController.h:
2570         (LayoutTestController):
2571         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2572         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2573         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2574         (DRTDevToolsAgent):
2575         * DumpRenderTree/chromium/LayoutTestController.cpp:
2576         (LayoutTestController::LayoutTestController):
2577         * DumpRenderTree/chromium/LayoutTestController.h:
2578         (LayoutTestController):
2579         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2580         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2581         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2582         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2583         * DumpRenderTree/mac/DumpRenderTree.mm:
2584         (resetWebViewToConsistentStateBeforeTesting):
2585         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2586         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2587         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2588         (LayoutTestController):
2589         * DumpRenderTree/win/DumpRenderTree.cpp:
2590         (resetWebViewToConsistentStateBeforeTesting):
2591         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2592         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2593         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2594         (LayoutTestController):
2595
2596 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2597
2598         Move allowRoundingHacks to Internals interface
2599         https://bugs.webkit.org/show_bug.cgi?id=87328
2600
2601         Reviewed by Hajime Morita.
2602
2603         Remove allowRoundingHacks functions, because it is able to work in the
2604         cross-port way through the Internals interface.
2605
2606         * DumpRenderTree/LayoutTestController.cpp:
2607         (LayoutTestController::staticFunctions):
2608         * DumpRenderTree/LayoutTestController.h:
2609         (LayoutTestController):
2610         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2611         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2613         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2614         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2615         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2616
2617 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2618
2619         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2620         https://bugs.webkit.org/show_bug.cgi?id=87616
2621
2622         Reviewed by Hajime Morita.
2623
2624         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2625         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2626         Patch just adds a #ifndef / #define check.
2627
2628         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2629         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2630
2631 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2632
2633         [EFL] Enable blob support for the EFL port
2634         https://bugs.webkit.org/show_bug.cgi?id=85363
2635
2636         Reviewed by Hajime Morita.
2637
2638         Enable Blob support by default for the EFL port.
2639
2640         * Scripts/webkitperl/FeatureList.pm:
2641
2642 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2643
2644         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2645         https://bugs.webkit.org/show_bug.cgi?id=87582
2646
2647         Reviewed by Darin Adler.
2648
2649         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2650         possible to test pages in a similar way as they are loaded in Browsers.
2651
2652         * DumpRenderTree/LayoutTestController.cpp:
2653         (LayoutTestController::LayoutTestController):
2654         (setUseDeferredFrameLoadingCallback):
2655         (LayoutTestController::staticFunctions):
2656         * DumpRenderTree/LayoutTestController.h:
2657         (LayoutTestController::useDeferredFrameLoading):
2658         (LayoutTestController::setUseDeferredFrameLoading):
2659         (LayoutTestController):
2660         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2661         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2662
2663 2012-05-27  David Barton  <dbarton@mathscribe.com>
2664
2665         [watchlist] Improve MathML rule
2666         https://bugs.webkit.org/show_bug.cgi?id=87592
2667
2668         Reviewed by Adam Barth.
2669
2670         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2671         but if this changed the rule would be slow. We protect against this, clarify the rule,
2672         and make it more similar to existing rules.
2673
2674         * Scripts/webkitpy/common/config/watchlist:
2675
2676 2012-05-27  David Barton  <dbarton@mathscribe.com>
2677
2678         [watchlist] Add myself & a rule for MathML
2679         https://bugs.webkit.org/show_bug.cgi?id=87586
2680
2681         Reviewed by Adam Barth.
2682
2683         * Scripts/webkitpy/common/config/watchlist:
2684
2685 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2686
2687         Use xcrun to find path to nm for Mac port
2688         <http://webkit.org/b/87588>
2689
2690         Reviewed by Dan Bernstein.
2691
2692         * Scripts/webkitpy/layout_tests/port/mac.py:
2693         (MacPort.nm_command): Add. Tries to find a path for the nm
2694         command using xcrun.  Falls back to returning 'nm'.
2695         * Scripts/webkitpy/layout_tests/port/webkit.py:
2696         (WebKitPort.nm_command): Add. Returns 'nm'.
2697         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2698
2699 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2700
2701         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2702
2703         Reviewed by Eric Seidel.
2704
2705         * DumpRenderTree/win/DumpRenderTree.vcproj:
2706         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2707         (FrameLoadDelegate::FrameLoadDelegate):
2708         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2709         * DumpRenderTree/win/FrameLoadDelegate.h:
2710         (FrameLoadDelegate):
2711         * DumpRenderTree/win/TextInputController.cpp: Added.
2712         (setMarkedTextCallback):
2713         (hasMarkedTextCallback):
2714         (unmarkTextCallback):
2715         (markedRangeCallback):
2716         (insertTextCallback):
2717         (firstRectForCharacterRangeCallback):
2718         (selectedRangeCallback):
2719         (TextInputController::makeWindowObject):
2720         (TextInputController::getJSClass):
2721         (TextInputController::staticValues):
2722         (TextInputController::staticFunctions):
2723         * DumpRenderTree/win/TextInputController.h: Added.
2724         (TextInputController):
2725         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2726         (TextInputController::setMarkedText):
2727         (TextInputController::hasMarkedText):
2728         (TextInputController::unmarkText):
2729         (TextInputController::markedRange):
2730         (TextInputController::insertText):
2731         (TextInputController::firstRectForCharacterRange):
2732         (TextInputController::selectedRange):
2733
2734 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2735
2736         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2737         https://bugs.webkit.org/show_bug.cgi?id=87528
2738
2739         Reviewed by Ojan Vafai.
2740
2741         launching git or svn for individual files can be slow; this
2742         change will hand multiple paths at once to git and svn so they
2743         can be added in a batch.
2744
2745         * Scripts/webkitpy/common/checkout/scm/git.py:
2746         (Git.add_list):
2747         (Git.delete_list):
2748         * Scripts/webkitpy/common/checkout/scm/scm.py:
2749         (SCM.add):
2750         (SCM):
2751         (SCM.add_list):
2752         (SCM.delete):
2753         (SCM.delete_list):
2754         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2755         (MockSCM.add):
2756         (MockSCM):
2757         (MockSCM.add_list):
2758         (MockSCM.delete):
2759         (MockSCM.delete_list):
2760         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2761         (_shared_test_exists):
2762         (_shared_test_added_files):
2763         (_test_delete_list):
2764         * Scripts/webkitpy/common/checkout/scm/svn.py:
2765         (SVN.add_list):
2766         (SVN.delete_list):
2767
2768 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2769
2770         [NRWT] Add unit testing for perf tests on locked shards
2771         https://bugs.webkit.org/show_bug.cgi?id=87489
2772
2773         Reviewed by Dirk Pranke.
2774
2775         Adding utests that makes sure that perf tests are running in locked
2776         shards and by passing --no-http won't break NRWT (r118421).
2777
2778         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2779         (ShardingTests):
2780         (ShardingTests.test_shard_by_dir):
2781         (ShardingTests.test_shard_every_file):
2782         (ShardingTests.test_shard_in_two):
2783         (ShardingTests.test_multiple_locked_shards):
2784         (LockCheckingManager):
2785         (LockCheckingManager.__init__):
2786         (LockCheckingManager.handle_finished_list):
2787         (ManagerTest.test_http_locking):
2788         (ManagerTest):
2789         (ManagerTest.test_perf_locking):
2790         * Scripts/webkitpy/layout_tests/port/test.py:
2791
2792 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2793
2794         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2795         https://bugs.webkit.org/show_bug.cgi?id=87511
2796
2797         Reviewed by Alexey Proskuryakov.
2798
2799         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2800
2801         * DumpRenderTree/win/EventSender.cpp:
2802         (keyDownCallback):
2803
2804 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2805
2806         Adding Ken Buchanan to committers.py
2807         https://bugs.webkit.org/show_bug.cgi?id=87443
2808
2809         Unreviewed.
2810
2811         Adding self to committers.py as a Committer.
2812
2813         * Scripts/webkitpy/common/config/committers.py:
2814
2815 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2816
2817         [Qt] Buildfix for newer Qt5
2818         https://bugs.webkit.org/show_bug.cgi?id=87257
2819
2820         Reviewed by Simon Hausmann.
2821
2822         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2823
2824 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2825
2826         [Qt] Unreviewed fix after r118484.
2827
2828         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2829         They were enabled uncoditinally before r118484.
2830
2831         * qmake/mkspecs/features/features.pri:
2832
2833 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2834
2835         Add feature defines for web-facing parts of CSS Regions and Exclusions
2836         https://bugs.webkit.org/show_bug.cgi?id=87442
2837         <rdar://problem/10887709>
2838
2839         Reviewed by Dan Bernstein.
2840
2841         * Scripts/webkitperl/FeatureList.pm:
2842
2843 2012-05-24  Hironori Bono  <hbono@chromium.org>
2844
2845         Enable grammar checking on Chromium when we paste text (Take 2)
2846         https://bugs.webkit.org/show_bug.cgi?id=74393
2847
2848         Reviewed by Ryosuke Niwa.
2849
2850         This change enables grammar checking on Chromium and implements a mock grammar
2851         checker to fix a failing test.
2852
2853         * DumpRenderTree/DumpRenderTree.gypi:
2854         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2855         (MockGrammarCheck::checkGrammarOfString):
2856         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2857         (WebKit):
2858         (MockGrammarCheck):
2859         * DumpRenderTree/chromium/WebViewHost.cpp:
2860         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2861
2862 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2863
2864         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2865         https://bugs.webkit.org/show_bug.cgi?id=86842
2866
2867         Reviewed by Antonio Gomes.
2868
2869         Add support for overriding the application cache support preference
2870         through EFL's LayoutTestController.
2871
2872         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2873         (LayoutTestController::overridePreference):
2874
2875 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2876
2877         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2878         https://bugs.webkit.org/show_bug.cgi?id=85209
2879
2880         Reviewed by Antonio Gomes.
2881
2882         Set developer extras setting called twice on the test startup. Hence, removing
2883         an unnecessary extra call which set wrong value. 
2884
2885         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2886         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2887
2888 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2889
2890         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2891         https://bugs.webkit.org/show_bug.cgi?id=86916
2892
2893         Reviewed by Adam Barth.
2894
2895         Note that if release and debug are failing differently, debug
2896         will be ignored ...
2897
2898         Note: also change the use of a fake port name from
2899         "mock-port-name" to "test-mac-leopard" to make it more friendly
2900         to the port factory ("mock" actually is a real port).
2901
2902         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2903         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2904         (GardeningHTTPRequestHandler.rebaselineall):
2905         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2906         (GardeningServerTest.test_rebaselineall):
2907         (GardeningServerTest.test_rebaseline_new_port):
2908
2909 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2910
2911         nrwt: fix baseline search path for official chrome builders
2912         https://bugs.webkit.org/show_bug.cgi?id=87432
2913
2914         Reviewed by Tony Chang.
2915
2916         The official chrome builders need to use the win7 and SL
2917         baseline paths, not the XP and Leopard paths. Linux is correct.
2918
2919         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2920         (GoogleChromeMacPort.determine_full_port_name):
2921         (GoogleChromeWinPort.determine_full_port_name):
2922         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2923         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2924         (TestGoogleChromePort.test_get_google_chrome_port):
2925
2926 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2927
2928         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2929         https://bugs.webkit.org/show_bug.cgi?id=86800
2930
2931         Reviewed by Dirk Pranke.
2932
2933         Don't launch a HTTP server with lock based only on the existence of
2934         locked shards since we now run perf on locked shards too.
2935
2936         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2937         (Manager._run_tests):
2938
2939 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2940
2941         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2942         https://bugs.webkit.org/show_bug.cgi?id=87128
2943
2944         Reviewed by Dirk Pranke.
2945
2946         * Scripts/webkitpy/layout_tests/port/base.py:
2947         (Port.driver_name):
2948         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2949         (ChromiumLinuxPort._path_to_driver):
2950         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2951         (ChromiumPortTest.test_driver_name_option):
2952         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2953         (ChromiumWinPort._path_to_driver):
2954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2955         (parse_args):
2956
2957 2012-05-24  John Mellor  <johnme@chromium.org>
2958
2959         Font Boosting: Add compile flag and runtime setting
2960         https://bugs.webkit.org/show_bug.cgi?id=87394
2961
2962         Reviewed by Adam Barth.
2963
2964         Add ENABLE_FONT_BOOSTING.
2965
2966         * Scripts/webkitperl/FeatureList.pm:
2967         * qmake/mkspecs/features/features.pri:
2968
2969 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2970
2971         [EFL] [DRT] keyboard-related tests do not pass
2972         https://bugs.webkit.org/show_bug.cgi?id=85369
2973
2974         Reviewed by Gustavo Noronha Silva.
2975
2976         Add SHIFT modifier for capital letters as VK_ 
2977         codes do not distinguish between lows and caps and also to be consistent
2978         with other ports which send caps as lowercase letters with the shift key down.
2979
2980         * DumpRenderTree/efl/EventSender.cpp:
2981         (keyNameFromJSValue): 
2982
2983 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2984
2985         [WK2] Let the client give local files universal access on a case by case basis
2986         https://bugs.webkit.org/show_bug.cgi?id=87174
2987         <rdar://problem/11024330>
2988
2989         Reviewed by Maciej Stachowiak.
2990
2991         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2992         Added initialization of a new structure member to prevent build failure.
2993
2994 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2995
2996         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2997         https://bugs.webkit.org/show_bug.cgi?id=87203
2998
2999         Reviewed by Andreas Kling.
3000
3001         Add the required changes to make
3002         fast/events/keydown-leftright-keys.html pass after r118001.
3003
3004         * DumpRenderTree/efl/EventSender.cpp:
3005         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
3006         into the proper X11 keysym definitions.
3007
3008 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3009
3010         Unreviewed, rolling out r118352.
3011         http://trac.webkit.org/changeset/118352
3012         https://bugs.webkit.org/show_bug.cgi?id=87390
3013
3014         Caused 6 editing/spelling tests crash/fail on chromium in
3015         debug. (Requested by vsevik on #webkit).
3016
3017         * DumpRenderTree/DumpRenderTree.gypi:
3018         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
3019         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
3020         * DumpRenderTree/chromium/WebViewHost.cpp:
3021         (WebViewHost::finishLastTextCheck):
3022
3023 2012-05-24  Peter Beverloo  <peter@chromium.org>
3024
3025         Add John Mellor as a contributor
3026         https://bugs.webkit.org/show_bug.cgi?id=87389
3027
3028         Reviewed by Kenneth Rohde Christiansen.
3029
3030         John will be working on Font Boosting and is very involved with various
3031         web-facing subjects of Chrome for Android, such as viewport.
3032
3033         * Scripts/webkitpy/common/config/committers.py:
3034
3035 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3036
3037         [EFL][DRT] LayoutTestController's setCacheModel() implementation
3038         https://bugs.webkit.org/show_bug.cgi?id=86840
3039
3040         Reviewed by Csaba Osztrogonác.
3041
3042         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3043         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
3044         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3045         (LayoutTestController::setCacheModel): Implementation added.
3046
3047 2012-05-24  Hironori Bono  <hbono@chromium.org>
3048
3049         Enable grammar checking on Chromium when we paste text.
3050         https://bugs.webkit.org/show_bug.cgi?id=74393
3051
3052         Reviewed by Hajime Morita.
3053
3054         This change enables grammar checking on Chromium and implements a mock grammar
3055         checker to fix a failing test.
3056
3057         * DumpRenderTree/DumpRenderTree.gypi:
3058         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3059         (MockGrammarCheck::checkGrammarOfString):
3060         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3061         (WebKit):
3062         (MockGrammarCheck):
3063         * DumpRenderTree/chromium/WebViewHost.cpp:
3064         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3065
3066 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3067
3068         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
3069
3070         * qmake/mkspecs/features/features.pri:
3071
3072 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3073
3074         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
3075         https://bugs.webkit.org/show_bug.cgi?id=86867
3076
3077         Reviewed by Adam Barth.
3078
3079         Add implementation for sendWebIntentResponse() in EFL's
3080         LayoutTestController and add empty implementation for other ports.
3081
3082         * DumpRenderTree/LayoutTestController.cpp:
3083         (sendWebIntentResponseCallback):
3084         (LayoutTestController::staticFunctions):
3085         * DumpRenderTree/LayoutTestController.h:
3086         (LayoutTestController):
3087         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3088         (LayoutTestController::sendWebIntentResponse):
3089         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3090         (DumpRenderTreeChrome::currentIntentRequest):
3091         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3092         (DumpRenderTreeChrome::onFrameIntentNew):
3093         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3094         (DumpRenderTreeChrome):
3095         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3096         (LayoutTestController::sendWebIntentResponse):
3097         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3098         (LayoutTestController::sendWebIntentResponse):
3099         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3100         (LayoutTestController::sendWebIntentResponse):
3101         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3102         (LayoutTestController::sendWebIntentResponse):
3103         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3104         (LayoutTestController::sendWebIntentResponse):
3105
3106 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3107
3108         [EFL] The EFL port has no support for title directionality
3109         https://bugs.webkit.org/show_bug.cgi?id=86462
3110
3111         Reviewed by Gustavo Noronha Silva.
3112
3113         Update "title,changed" signal handlers in DRT and EWebLauncher to
3114         reflect the change from const char* to Ewk_Text_With_Direction* type
3115         for the title.
3116
3117         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3118         (DumpRenderTreeChrome::onTitleChanged):
3119         * EWebLauncher/main.c:
3120         (title_set):
3121         (on_title_changed):
3122         (on_key_down):
3123
3124 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3125
3126         Change EFL debug build name with more detail one
3127         https://bugs.webkit.org/show_bug.cgi?id=87254
3128
3129         Reviewed by Ryosuke Niwa.
3130
3131         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
3132         In addition, remove efl-linux-debug triggerable since nobody uses it.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/config.json:
3135
3136 2012-05-23  Kangil Han  <kangil.han@samsung.com>
3137
3138         [EFL][DRT] Fix WebCore library path and rebaseline result
3139         https://bugs.webkit.org/show_bug.cgi?id=86355
3140
3141         Reviewed by Dirk Pranke.
3142
3143         Currently EFL DRT uses wrong WebCore library path when running DRT.
3144         Therefore, this patch adjusted the path correctly.
3145
3146         * Scripts/webkitpy/layout_tests/port/efl.py:
3147         (EflPort._path_to_webcore_library):
3148
3149 2012-05-23  Ojan Vafai  <ojan@chromium.org>
3150
3151         add back the ability to disable flexbox
3152         https://bugs.webkit.org/show_bug.cgi?id=87147
3153
3154         Reviewed by Tony Chang.
3155
3156         * Scripts/webkitperl/FeatureList.pm:
3157
3158 2012-05-23  Tony Chang  <tony@chromium.org>
3159
3160         Remove the Chromium Grid Layout bot from the waterfall
3161         https://bugs.webkit.org/show_bug.cgi?id=87311
3162
3163         Reviewed by Ryosuke Niwa.
3164
3165         I removed the compiler define in r117613, so we don't need a separate
3166         bot to compile/test this code.
3167
3168         * BuildSlaveSupport/build.webkit.org-config/config.json:
3169
3170 2012-05-23  Ian Vollick  <vollick@chromium.org>
3171
3172         Add vollick to list of contributors.
3173         https://bugs.webkit.org/show_bug.cgi?id=87305
3174
3175         Reviewed by Adam Barth.
3176
3177         * Scripts/webkitpy/common/config/committers.py:
3178
3179 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3180
3181         [Chromium-Android] Fix chromium_android_unittest
3182         https://bugs.webkit.org/show_bug.cgi?id=87196
3183
3184         Reviewed by Tony Chang.
3185
3186         Update unit tests after ChromiumAndroidPort supported apk based
3187         DumpRenderTree.
3188
3189         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3190         (ChromiumAndroidPortTest):
3191         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
3192         (ChromiumAndroidPortTest.test_get_last_stacktrace):
3193         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
3194         (ChromiumAndroidDriverTest):
3195         (ChromiumAndroidDriverTest.setUp):
3196         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
3197         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
3198
3199 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3200
3201         [watchlist] Add myself and create a watch rule to catch Attribute related patches
3202         https://bugs.webkit.org/show_bug.cgi?id=87303
3203
3204         Reviewed by Alexis Menard.
3205
3206         * Scripts/webkitpy/common/config/watchlist:
3207
3208 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
3209
3210         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3211         https://bugs.webkit.org/show_bug.cgi?id=86916
3212
3213         Reviewed by Adam Barth.
3214
3215         This change pushes all of the logic for rebaselining a cluster
3216         of failures (a list of tests failing a list of suffixes on a
3217         list of bots) onto the server, so there is a single call from
3218         the web page; we will then be able to optimize the performance
3219         of the rebaselining better.
3220
3221         Also remove the 'optimizebaseline' entry point on garden-o-matic
3222         (and the client-side call) since we don't need it any more.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3226         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3227         (GardeningHTTPRequestHandler.rebaselineall):
3228         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3229
3230 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3231
3232         Mac DRT should be able to load external URLs for replay performance tests
3233         https://bugs.webkit.org/show_bug.cgi?id=86191
3234
3235         Reviewed by Alexey Proskuryakov.
3236
3237         Let external URL requests go through if the test file is not a local file or hosted at localhost.
3238         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
3239         "DumpRenderTree http://localhost:8000/".
3240
3241         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3242         (isLocalhost):
3243         (hostIsUsedBySomeTestsToGenerateError):
3244         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3245
3246 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
3247
3248         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
3249         debug symbols for easier debugging.
3250         https://bugs.webkit.org/show_bug.cgi?id=87151
3251
3252         Reviewed by Kevin Ollivier.
3253
3254         * waf/build/settings.py:
3255         (common_configure):
3256
3257 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3258
3259         Unreviewed. Move myself to reviewers.
3260
3261         * Scripts/webkitpy/common/config/committers.py:
3262
3263 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
3264
3265         [EFL] Implements the registerProtocolHandler method and option.
3266         https://bugs.webkit.org/show_bug.cgi?id=73638
3267
3268         Reviewed by Andreas Kling.
3269
3270         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
3271
3272 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
3273
3274         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
3275         https://bugs.webkit.org/show_bug.cgi?id=87221
3276
3277         Reviewed by Martin Robinson.
3278
3279         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
3280         rightShift key names into proper GDK key symbols.
3281
3282         * DumpRenderTree/gtk/EventSender.cpp:
3283         (createKeyPressEvent):
3284
3285 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3286
3287         [Qt] Make the web view's url property follow the active url
3288
3289         https://bugs.webkit.org/show_bug.cgi?id=77554
3290
3291         Update  the location bar in the minibrowser to behave
3292         a bit more like normal browsers in terms of when the url will change
3293         and how active focus is handled.
3294
3295         Reviewed by Simon Hausmann.
3296
3297         * MiniBrowser/qt/qml/BrowserWindow.qml:
3298
3299 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3300
3301         [Qt] Remove references to $$QT_SOURCE_TREE
3302
3303         With a modularized Qt, it's ambigious. What we really want is qtbase,
3304         which qtcore is a proxy for (we assume it will always live in qtbase).
3305
3306         Reviewed by Tor Arne Vestbø.
3307
3308         * DumpRenderTree/qt/DumpRenderTree.pro:
3309
3310 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3311
3312         [Qt] Fix qmake conditional for c++-11 compat warnings
3313
3314         Reviewed by Tor Arne Vestbø.
3315
3316         * qmake/mkspecs/features/unix/default_post.prf:
3317
3318 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3319
3320         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
3321         https://bugs.webkit.org/show_bug.cgi?id=85956
3322
3323         Reviewed by Gustavo Noronha Silva.
3324
3325         Catch new "load,provisional,failed" signal and print
3326         didFailProvisionalLoadWithError messages when LayoutTestController's
3327         dumpFrameLoadCallbacks() returns true. Also make sure the
3328         didFailLoadWithError message is not printed in case of provisional
3329         load failure.
3330
3331         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3332         (DumpRenderTreeChrome::createView):
3333         (DumpRenderTreeChrome::onFrameCreated):
3334         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
3335         (DumpRenderTreeChrome::onFrameLoadError):
3336         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3337         (DumpRenderTreeChrome):
3338
3339 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3340
3341         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
3342         https://bugs.webkit.org/show_bug.cgi?id=86366
3343
3344         Reviewed by Antonio Gomes.
3345
3346         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
3347
3348         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3349         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3350
3351 2012-05-22  Darin Adler  <darin@apple.com>
3352
3353         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
3354         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
3355
3356 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3357
3358         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
3359         https://bugs.webkit.org/show_bug.cgi?id=86922
3360
3361         Because we have new platformInit() in TestShellAndroid.cpp, and
3362         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
3363         is split into TestShellPosix.cpp and TestShellX11.cpp.
3364
3365         Reviewed by Kent Tamura.
3366
3367         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3368         * DumpRenderTree/DumpRenderTree.gypi:
3369         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
3370         (platformInit):
3371         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
3372         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
3373         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
3374         (AlarmHandler):
3375         (TestShell::waitTestFinished):
3376         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
3377         (openStartupDialog): from TestShellGtk.cpp
3378         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
3379         (setupFontconfig):
3380         (platformInit):
3381
3382 2012-05-22  Kangil Han  <kangil.han@samsung.com>
3383
3384         [EFL][DRT] Implement touch event
3385         https://bugs.webkit.org/show_bug.cgi?id=86720
3386
3387         Reviewed by Hajime Morita.
3388
3389         Currently EFL DRT doesn't support touch event.
3390         Therefore, this patch enabled it and implemented some eventSender function callbacks.
3391
3392         * DumpRenderTree/efl/EventSender.cpp:
3393         (TouchEventInfo::TouchEventInfo):
3394         (TouchEventInfo):
3395         (touchPointList):
3396         (sendTouchEvent):
3397         (addTouchPointCallback):
3398         (touchStartCallback):
3399         (updateTouchPointCallback):
3400         (touchMoveCallback):
3401         (cancelTouchPointCallback):
3402         (touchCancelCallback):
3403         (releaseTouchPointCallback):
3404         (touchEndCallback):
3405         (clearTouchPointsCallback):
3406         (setTouchModifierCallback):
3407         * Scripts/webkitperl/FeatureList.pm:
3408
3409 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3410
3411         [Chromium-Android] Fix chromium_android_unittest
3412         https://bugs.webkit.org/show_bug.cgi?id=87196
3413
3414         Not reviewed.
3415         Temporarily disable chromium_android_unittest.
3416
3417         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3418         (ChromiumAndroidPortTest):
3419         (ChromiumAndroidDriverTest):
3420
3421 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3422
3423         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
3424         https://bugs.webkit.org/show_bug.cgi?id=64313
3425
3426         Reviewed by Jon Honeycutt.
3427
3428         Add it.
3429
3430         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3431         Make sure to generate the binding.
3432
3433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3434         (WTR::LayoutTestController::setDefersLoading):
3435         Call WKBundlePageSetDefersLoading.
3436         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3437
3438 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3439
3440         [Chromium-Android] Run DumpRenderTree as an apk (python part)
3441         https://bugs.webkit.org/show_bug.cgi?id=86923
3442
3443         chromium_android.py is modified to support running DumpRenderTree as
3444         an apk, so that we can run the tests (e.g. video) requiring features
3445         implemented in Java on Android.
3446
3447         Reviewed by Adam Barth.
3448
3449         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3450         (ChromiumAndroidPort.__init__):
3451         (ChromiumAndroidPort.default_child_processes):
3452         (ChromiumAndroidPort.check_wdiff):
3453         (ChromiumAndroidPort.check_build):
3454         (ChromiumAndroidPort.start_helper):
3455         (ChromiumAndroidPort.skipped_layout_tests):
3456         (ChromiumAndroidPort):
3457         (ChromiumAndroidPort._path_to_driver):
3458         (ChromiumAndroidPort._get_crash_log):
3459         (ChromiumAndroidPort._push_executable):
3460         (ChromiumAndroidPort._run_adb_command):
3461         (ChromiumAndroidPort._get_last_stacktrace):
3462         (ChromiumAndroidPort._get_logcat):
3463         (ChromiumAndroidPort._setup_performance):
3464         (ChromiumAndroidDriver):
3465         (ChromiumAndroidDriver.__init__):
3466         (ChromiumAndroidDriver._command_wrapper):
3467         (ChromiumAndroidDriver.cmd_line):
3468         (ChromiumAndroidDriver._file_exists_on_device):
3469         (ChromiumAndroidDriver._deadlock_detector):
3470         (ChromiumAndroidDriver._start):
3471         (ChromiumAndroidDriver.run_test):
3472         (ChromiumAndroidDriver.stop):
3473         (ChromiumAndroidDriver._write_command_and_read_line):
3474         (ChromiumAndroidDriver._output_image):
3475         (ChromiumAndroidDriver._get_stderr):
3476
3477 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3478
3479         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3480
3481         Unreviewed gardening.
3482
3483         * Scripts/webkitpy/layout_tests/port/base.py:
3484         (Port.driver_name):
3485         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3486         (ChromiumLinuxPort._path_to_driver):
3487         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3488         (ChromiumPortTest.test_overrides_and_builder_names):
3489         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3490         (ChromiumWinPort._path_to_driver):
3491         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3492         (parse_args):
3493
3494 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3495
3496         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3497         https://bugs.webkit.org/show_bug.cgi?id=87176
3498
3499         Reviewed by Tony Chang.
3500
3501         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3502         * DumpRenderTree/DumpRenderTree.gypi:
3503
3504 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3505
3506         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3507         https://bugs.webkit.org/show_bug.cgi?id=87128
3508
3509         Reviewed by Dirk Pranke.
3510
3511         * Scripts/webkitpy/layout_tests/port/base.py:
3512         (Port.driver_name):
3513         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3514         (ChromiumLinuxPort._path_to_driver):
3515         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3516         (ChromiumPortTest.test_driver_name_option):
3517         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3518         (ChromiumWinPort._path_to_driver):
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3520         (parse_args):
3521
3522 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3523
3524         WTR fix after r118001.
3525
3526         Rubber-stamped by Alexey Proskuryakov.
3527
3528         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3529
3530         * WebKitTestRunner/mac/EventSenderProxy.mm:
3531         (WTR::EventSenderProxy::keyDown):
3532
3533 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3534
3535         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3536         https://bugs.webkit.org/show_bug.cgi?id=86684
3537
3538         Reviewed by Darin Fisher.
3539
3540         * DumpRenderTree/chromium/LayoutTestController.cpp:
3541         (LayoutTestController::numberOfPages):
3542         * DumpRenderTree/chromium/WebViewHost.cpp:
3543         (WebViewHost::printPage):
3544
3545 == Rolled over to ChangeLog-2012-05-22 ==