[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-07  Tony Chang  <tony@chromium.org>
2
3         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
4         https://bugs.webkit.org/show_bug.cgi?id=77368
5
6         Reviewed by Ojan Vafai.
7
8         It doesn't look like we ever get a rect with width or height of 0.
9         I ran css1, css2.1, fast/forms, and tables without any crashes.
10
11         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
12         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
13
14 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
15
16         run-webkit-tests --lint-test-files gives an error when run on linux
17         https://bugs.webkit.org/show_bug.cgi?id=88551
18
19         Reviewed by Ojan Vafai.
20
21         We weren't mapping the expectations properly for the
22         google-chrome ports.
23
24         * Scripts/webkitpy/layout_tests/port/base.py:
25         (Port.path_to_test_expectations_file):
26         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
27         (TestGoogleChromePort.test_path_to_expectations):
28
29 2012-06-07  Daniel Erat  <derat@chromium.org>
30
31         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
32         https://bugs.webkit.org/show_bug.cgi?id=88263
33
34         Reviewed by Tony Chang.
35
36         * DumpRenderTree/chromium/LayoutTestController.cpp:
37         (LayoutTestController::LayoutTestController):
38         (LayoutTestController::reset):
39         (LayoutTestController::setTextSubpixelPositioning):
40         * DumpRenderTree/chromium/LayoutTestController.h:
41         (LayoutTestController):
42         * DumpRenderTree/chromium/fonts.conf:
43
44 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
45
46         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
47         https://bugs.webkit.org/show_bug.cgi?id=88060
48
49         Reviewed by Martin Robinson.
50
51         Spin the main loop before acquiring the pixel content. This ensures things
52         like late size allocations are finished before calling gtk_widget_draw,
53         avoiding assertions and subsequent empty pixel results.
54
55         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
56         (createBitmapContextFromWebView):
57
58 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
59
60         [Qt] Improve the visual of the viewport info box
61         https://bugs.webkit.org/show_bug.cgi?id=88410
62
63         Reviewed by Tor Arne Vestbø.
64
65         Improve the visual and make it possible to see the content more easy.
66
67         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
68
69 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
70
71         [EFL][WK2] Compile webkit1 and webkit2 by default.
72         https://bugs.webkit.org/show_bug.cgi?id=85041
73
74         Reviewed by Chang Shu.
75
76         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
77         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
78
79         * Scripts/build-webkit:
80
81 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
82
83         Unreviewed, rolling out r119662.
84         http://trac.webkit.org/changeset/119662
85         https://bugs.webkit.org/show_bug.cgi?id=88487
86
87         Broke builds (Requested by rniwa on #webkit).
88
89         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
90         * DumpRenderTree/chromium/ImageDiff.cpp:
91         (untestedCompareImages):
92
93 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
94
95         [Chromium] Remove header dependency of ImageDiff to WTF
96         https://bugs.webkit.org/show_bug.cgi?id=88422
97
98         Reviewed by Adam Barth.
99
100         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
101         * DumpRenderTree/chromium/ImageDiff.cpp:
102         (untestedCompareImages):
103
104 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
105
106         [WebKit] DeviceOrientation cleanup
107         https://bugs.webkit.org/show_bug.cgi?id=88406
108
109         Reviewed by Kent Tamura.
110
111         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
112
113         * DumpRenderTree/chromium/LayoutTestController.cpp:
114         (LayoutTestController::setMockDeviceOrientation):
115
116 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
117
118         webkitpy: add support for an ordered dict of test expectations
119         https://bugs.webkit.org/show_bug.cgi?id=87802
120
121         Reviewed by Ojan Vafai.
122
123         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
124         support a cascaded list of test expectations files. An easy way
125         to think of this is as an ordered dictionary of name -> contents
126         for files, where the name is usually a path on disk (I say
127         usually because we want to support other kinds of expectations
128         like the compile-time skips for unsupported features in
129         webkit.py, and we want to continue to support "in-memory" test
130         expectations that don't require a filesystem).
131
132         Conveniently there is an OrderedDict implementation in Python
133         2.7+ and it is available as a backport, so the first step in
134         adding this support is to use that implementation. Subsequent
135         patches will update the test_expectations.py module (and other
136         callers) to access the dict directly.
137
138         This patch just changes the base internal implementation and
139         provides wrappers for compatibility. The derived ports
140         (WebKitPort, TestPort, etc.) still need to be updated.
141
142         * Scripts/webkitpy/layout_tests/port/base.py:
143         (Port._expectations_dict):
144         (Port.test_expectations):
145         (Port):
146         (Port._expectations_overrides_dict):
147         (Port.test_expectations_overrides):
148         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
149         (PortTestCase.test_expectations_ordering):
150         (PortTestCase):
151         (PortTestCase.test_expectations_overrides_ordering):
152         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
153         (OrderedDict):
154         (OrderedDict.__init__):
155         (OrderedDict.clear):
156         (OrderedDict.__setitem__):
157         (OrderedDict.__delitem__):
158         (OrderedDict.__iter__):
159         (OrderedDict.__reversed__):
160         (OrderedDict.popitem):
161         (OrderedDict.__reduce__):
162         (OrderedDict.__repr__):
163         (OrderedDict.copy):
164         (OrderedDict.fromkeys):
165
166 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
167
168         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
169
170         * gtk/run-api-tests:
171         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
172
173 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
174
175         nrwt should look in 'out' for binaries on chromium win to support ninja
176         https://bugs.webkit.org/show_bug.cgi?id=88273
177
178         Reviewed by Tony Chang.
179
180         This patch standardizes the search algorithm the chromium ports
181         use to figure out which driver to run. We will look in a
182         chromium location before a webkit location (e.g., in
183         Source/WebKit/chromium/out before out/) and we will look in the
184         "legacy" directory (xcodebuild) before the directory ninja uses
185         (out).
186
187         Unfortunately due to the way the test code is set up testing the
188         properly requires some duplication of test code. I will fix that
189         in a followup patch.
190
191         * Scripts/webkitpy/layout_tests/port/chromium.py:
192         (ChromiumPort):
193         (ChromiumPort._static_build_path):
194         (ChromiumPort._build_path):
195         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
196         (ChromiumLinuxPort):
197         (ChromiumLinuxPort._determine_driver_path_statically):
198         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
199         (ChromiumLinuxPortTest.test_build_path):
200         (ChromiumLinuxPortTest):
201         (ChromiumLinuxPortTest.test_driver_name_option):
202         (ChromiumLinuxPortTest.path_to_image_diff):
203         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
204         (ChromiumMacPort):
205         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
206         (ChromiumMacPortTest.test_build_path):
207         (ChromiumMacPortTest):
208         (ChromiumMacPortTest.test_driver_name_option):
209         (ChromiumMacPortTest.path_to_image_diff):
210         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
211         (ChromiumPortTest.test_overrides_and_builder_names):
212         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
213         (ChromiumWinPort):
214         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
215         (ChromiumWinTest.test_build_path):
216         (ChromiumWinTest.test_operating_system):
217         (ChromiumWinTest):
218         (ChromiumWinTest.test_driver_name_option):
219         (ChromiumWinPortTest.path_to_image_diff):
220         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
221         (PortTestCase.assert_build_path):
222
223 2012-06-06  Jessie Berlin  <jberlin@apple.com>
224
225         Remove very red Windows WebKit2 testers
226         https://bugs.webkit.org/show_bug.cgi?id=88452
227
228         Reviewed by Steve Falkenburg.
229
230         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
231         need to focus on getting the WK1 testers green.
232
233         * BuildSlaveSupport/build.webkit.org-config/config.json:
234
235 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
236
237         get rebaselining tools to kinda work with the skia overrides file
238         https://bugs.webkit.org/show_bug.cgi?id=88456
239
240         Reviewed by Ryosuke Niwa.
241
242         Update rebaseline-expectations so that we read in the overrides
243         when looking for tests to rebaseline, but don't read in the
244         overrides when we are writing the expectations file back out.
245         This prevents the overrides from getting written into the main
246         file. This is kind of a hack but will have to do until we
247         support multiple expectations files properly.
248
249         * Scripts/webkitpy/tool/commands/rebaseline.py:
250         (RebaselineExpectations._expectations):
251         (RebaselineExpectations._update_expectations_file):
252         (RebaselineExpectations._tests_to_rebaseline):
253         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
254         (test_overrides_are_included_correctly):
255
256 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
257
258         webkitpy: two manager_worker_broker_unittest tests are broken
259         https://bugs.webkit.org/show_bug.cgi?id=88445
260
261         Reviewed by Ojan Vafai.
262
263         These tests were never updated when we removed the
264         --worker-model argument, and we were passing 'inline' instead of
265         1 (for the number of workers) :(. As a result we were creating
266         multiprocessing queues unnecessarily and that was failing on cygwin.
267
268         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
269         (InterfaceTest.test_managerconnection_is_abstract):
270         (InterfaceTest.test_workerconnection_is_abstract):
271
272 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
273
274         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
275         https://bugs.webkit.org/show_bug.cgi?id=87406
276
277         Reviewed by Dirk Pranke.
278
279         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
280         (TestExpectations.__init__):
281         * Scripts/webkitpy/tool/commands/rebaseline.py:
282         (RebaselineTest._update_expectations_file):
283         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
284         (test_rebaseline_does_not_include_overrides):
285
286 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
287
288         webkitpy: perf tests unit tests fail on chromium win
289         https://bugs.webkit.org/show_bug.cgi?id=88279
290
291         Reviewed by Ryosuke Niwa.
292
293         I'm seeing weird failures running the unit tests in my win32
294         checkout, and we don't really expect webpagereplay to work on
295         win32 anyway, so I'm skipping the import of that module for now
296         and adding a warning.
297
298         * Scripts/run-perf-tests:
299         * Scripts/webkitpy/performance_tests/perftest.py:
300
301 2012-06-06  Yong Li <yoli@rim.com>
302
303         Unreviewed. Update my email address in committers.py.
304
305         * Scripts/webkitpy/common/config/committers.py:
306
307 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
308
309         Add Robert Kroeger  to commiters.py
310         https://bugs.webkit.org/show_bug.cgi?id=88415
311
312         Unreviewed.
313
314         * Scripts/webkitpy/common/config/committers.py:
315
316 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
317
318         [EFL][DRT] http/tests/globalhistory testcases do not pass
319         https://bugs.webkit.org/show_bug.cgi?id=82579
320
321         Reviewed by Csaba Osztrogonác.
322
323         DRT has provided callbacks for ewk_view "global history delegate" signals.
324
325         * DumpRenderTree/efl/DumpRenderTree.cpp:
326         (isGlobalHistoryTest): Aux function to ident global history testcase.
327         (createLayoutTestController):
328         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
329         (DumpRenderTreeChrome::createView):
330         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
331         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
332         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
333         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
334         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
335         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
336         (DumpRenderTreeChrome):
337
338 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
339
340         [Qt] run-qtwebkit-tests hangs with -j1
341         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
342         This could happen due to an uncancelled timer after results were returned. This timer was
343         started only if --timeout was set.
344         https://bugs.webkit.org/show_bug.cgi?id=85475
345
346         Reviewed by Csaba Osztrogonác.
347
348         * Scripts/run-qtwebkit-tests:
349         (run_test):
350
351 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
352
353         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
354         https://bugs.webkit.org/show_bug.cgi?id=88327
355
356         Reviewed by Kenneth Rohde Christiansen.
357
358         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
359         * MiniBrowser/qt/icons/contents_width.png: Added.
360         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
361         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
362
363 2012-06-05  Jon Lee  <jonlee@apple.com>
364
365         Buildbot fix.
366
367         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
368         in the function. Store in a local variable.
369         (loadBuilderConfig):
370
371 2012-06-05  Jon Lee  <jonlee@apple.com>
372
373         Buildbot fix.
374
375         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
376         (loadBuilderConfig):
377
378 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
379
380         webkitpy: clean up win-specific path handling and tests
381         https://bugs.webkit.org/show_bug.cgi?id=88281
382
383         Reviewed by Adam Barth.
384
385         There was a bunch of inconsistent logic for handling path
386         conversions for win32 and cygwin paths due to us sometimes
387         looking at sys.platform and sometimes using mock hosts. This
388         patch cleans everything up so that we are required to pass
389         PlatformInfo objects to the path module and stop trying to do
390         different things when running on cygwin or win32 hosts (except
391         in the path_unittest module itself).
392
393         This may slightly reduce test coverage for the win32 code paths
394         but will be a lot easier to follow and maintain.
395
396         * Scripts/webkitpy/common/system/path.py:
397         (abspath_to_uri):
398         (_convert_path):
399         * Scripts/webkitpy/common/system/path_unittest.py:
400         (AbspathTest.platforminfo):
401         (AbspathTest.test_abspath_to_uri_cygwin):
402         (AbspathTest.test_abspath_to_uri_unixy):
403         (AbspathTest.test_abspath_to_uri_win):
404         (AbspathTest.test_abspath_to_uri_escaping_unixy):
405         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
406         (AbspathTest.test_stop_cygpath_subprocess):
407         * Scripts/webkitpy/common/system/platforminfo.py:
408         (PlatformInfo.__init__):
409         (PlatformInfo.is_cygwin):
410         * Scripts/webkitpy/common/system/platforminfo_mock.py:
411         (MockPlatformInfo.is_cygwin):
412         * Scripts/webkitpy/layout_tests/port/base.py:
413         (Port.to.show_results_html_file):
414         * Scripts/webkitpy/layout_tests/port/driver.py:
415         (Driver.test_to_uri):
416         (Driver.uri_to_test):
417         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
418         (DriverTest.test_test_to_uri):
419         (DriverTest.test_uri_to_test):
420         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
421         (MockDRTPortTest.make_port):
422         (MockDRTTest.input_line):
423         (MockChromiumDRTTest.test_pixeltest__fails):
424         * Scripts/webkitpy/layout_tests/port/test.py:
425         * Scripts/webkitpy/layout_tests/port/win.py:
426         (WinPort.show_results_html_file):
427         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
428         (MainTest.test_unexpected_failures):
429         (MainTest.test_results_directory_absolute):
430         (MainTest.test_results_directory_default):
431         (MainTest.test_results_directory_relative):
432
433 2012-06-05  Jon Lee  <jonlee@apple.com>
434
435         Workaround buildbot bug when merging build requests.
436         https://bugs.webkit.org/show_bug.cgi?id=88158
437
438         Reviewed by Mark Rowe.
439
440         For expediency, we still want testers to pick the latest build to test, but to ensure
441         that the builders are reporting the correct revision number, we should let the building bots
442         run as they normally would. That is, the builder picks the oldest revision, and merges
443         subsequent requests. Because merged requests get appended to the list of changes for a given
444         build, the last change in that list is also the latest change. When we used pickLatestBuild
445         for the builders, this was not the case (it would always report the penultimate change).
446
447         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
448
449         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
450         for all Apple builders.
451         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
452         the latest build to run.
453         (loadBuilderConfig):
454
455 2012-06-05  Jessie Berlin  <jberlin@apple.com>
456
457         [Win] DumpRenderTree should call resetInternalsObject
458         https://bugs.webkit.org/show_bug.cgi?id=88346
459
460         Reviewed by Simon Fraser.
461
462         Invoke it on Windows in the same place it is invoked on Mac.
463
464         * DumpRenderTree/win/DumpRenderTree.cpp:
465         (resetWebViewToConsistentStateBeforeTesting):
466
467 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
468
469         [GTK] Fix two more memory leaks in DRT
470         https://bugs.webkit.org/show_bug.cgi?id=88255
471
472         Reviewed by Martin Robinson.
473
474         Fixed memory leaks in GTK's DRT code.
475
476         * DumpRenderTree/gtk/DumpRenderTree.cpp:
477         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
478         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
479         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
480         (createBitmapContextFromWebView): Free the cairo surface.
481
482 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
483
484         [Qt] Building when a top directory is named Source
485         https://bugs.webkit.org/show_bug.cgi?id=77727
486
487         Reviewed by Tor Arne Vestbø.
488
489         Change regex to only replace the last instance of OUT_PWD.
490
491         * qmake/mkspecs/features/default_pre.prf:
492
493 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
494
495         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
496         https://bugs.webkit.org/show_bug.cgi?id=73176
497
498         Reviewed by Adam Barth.
499
500         Two more APIs are added in Custom Scheme Handler specification.
501         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
502         One is 'isProtocolHandlerRegistered' to query whether the specific URL
503         is registered or not.
504         The other is 'unregisterProtocolHandler' to remove the registered URL.
505
506         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
507
508 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
509
510         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
511         https://bugs.webkit.org/show_bug.cgi?id=83879
512
513         Reviewed by Carlos Garcia Campos.
514
515         Make minibrowser connect to the new 'permission requests' signal
516         to allow users handle the Geolocation permission requests.
517
518         * MiniBrowser/gtk/BrowserWindow.c:
519         (geolocationRequestDialogCallback): Callback for the dialog asking
520         the user for allowing or not geolocation permission requests.
521         (webViewDecidePermissionRequest): Launch a dialog to ask the user
522         whether to allow or deny geolocation permission requests.
523         (browserWindowConstructed): Connect to 'permission-request' signal.
524
525 2012-06-04  Chase Phillips  <cmp@google.com>
526
527         Make a builder group support+expect multiple loads.
528         https://bugs.webkit.org/show_bug.cgi?id=88260
529
530         Change BuilderGroup to allow expecting multiple
531         loads.  This allows merging results for a given set
532         of builders into one group.
533
534         Add a test that verifies that the group count
535         increments correctly based on successful and failed
536         list loads.
537
538         Reviewed by Ojan Vafai.
539
540         * TestResultServer/static-dashboards/builders.js:
541         (BuilderGroup):
542         (BuilderGroup.prototype.setbuilder):
543         (BuilderGroup.prototype.append):
544         (BuilderGroup.prototype.loaded):
545         (requestBuilderList.xhr.onload):
546         (requestBuilderList.xhr.onerror):
547         (onErrorLoadingBuilderList):
548         (loadBuildersList):
549         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
550         (test):
551         * TestResultServer/static-dashboards/run-unittests.html:
552
553 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
554
555         Python test fix attempt for Chromium Windows.
556
557         * Scripts/webkitpy/layout_tests/port/driver.py:
558         (Driver.uri_to_test):
559
560 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
561
562         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
563         https://bugs.webkit.org/show_bug.cgi?id=88243
564
565         Reviewed by Adam Barth.
566
567         * qmake/mkspecs/features/features.prf:
568
569 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
570
571         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
572         https://bugs.webkit.org/show_bug.cgi?id=88280
573
574         Unreviewed, build fix.
575
576         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
577         (TestServerProcess.test_basic):
578
579 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
580
581         test-webkitpy is hanging under cygwin
582         https://bugs.webkit.org/show_bug.cgi?id=88269
583
584         Reviewed by Ryosuke Niwa.
585
586         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
587         so we need to skip any tests that use it.
588
589         * Scripts/webkitpy/common/system/executive.py:
590         (Executive.run_in_parallel):
591         * Scripts/webkitpy/common/system/executive_unittest.py:
592         (ExecutiveTest.test_run_in_parallel):
593
594 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
595
596         test-webkitpy is failing on win32 after r115054
597         https://bugs.webkit.org/show_bug.cgi?id=88264
598
599         Reviewed by Ryosuke Niwa.
600
601         The failing http_server test was improperly suppressed (the
602         tuple was missing a comma, and so wasn't a tuple at all, just a
603         string) and so we were skipping *all* tests on win32. The right
604         way to skip a single test is to disable it inside the test
605         itself.
606
607         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
608         (TestHttpServer.test_start_cmd):
609         * Scripts/webkitpy/test/test_finder.py:
610         (TestFinder._default_names):
611         * Scripts/webkitpy/test/main.py:
612         (Tester.run): Add error message if we don't find any tests to run.
613         * Scripts/webkitpy/test/main_unittest.py:
614             
615
616 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
617
618         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
619         https://bugs.webkit.org/show_bug.cgi?id=88215
620
621         Reviewed by Martin Robinson.
622
623         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
624         for newly allocated strings.
625
626         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
627         (attributeSetToString):
628         (AccessibilityUIElement::allAttributes):
629
630 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
631
632         [GTK] Memory leaks in DumpRenderTree.cpp
633         https://bugs.webkit.org/show_bug.cgi?id=88213
634
635         Reviewed by Martin Robinson.
636
637         Fixed memory leaks in DumpRenderTree.
638
639         * DumpRenderTree/gtk/DumpRenderTree.cpp:
640         (appendString): Accepts const gchar* as the second argument.
641         (dumpFramesAsText): Free the string returned by g_strdup_printf().
642         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
643
644 2012-06-04  David Dorwin  <ddorwin@chromium.org>
645
646         Enable Chromium media player to instantiate a plugin
647         https://bugs.webkit.org/show_bug.cgi?id=87399
648
649         Reviewed by Kent Tamura.
650
651         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
652
653         * DumpRenderTree/chromium/WebViewHost.cpp:
654         (WebViewHost::createPopupMenu):
655
656 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
657
658         [GTK][WK2] Implement geolocation provider for the GTK port
659         https://bugs.webkit.org/show_bug.cgi?id=83877
660
661         Reviewed by Carlos Garcia Campos.
662
663         * gtk/generate-gtkdoc:
664         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
665
666 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
667
668         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
669         https://bugs.webkit.org/show_bug.cgi?id=87668
670
671         Reviewed by Ryosuke Niwa.
672
673         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
674         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
675         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
676
677         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
678         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
679
680 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
681
682         [EFL] Refactor ewk_view_context_paint code.
683         https://bugs.webkit.org/show_bug.cgi?id=85588
684
685         Reviewed by Hajime Morita.
686
687         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
688
689 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
690
691         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
692         https://bugs.webkit.org/show_bug.cgi?id=87869
693
694         Reviewed by Andreas Kling.
695
696         Replace %lld by PRId64 macro to print an int64_t value and silent a
697         compilation warning on 64-Bit.
698
699         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
700         (onExceededApplicationCacheQuota):
701
702 2012-06-03  Varun Jain  <varunjain@google.com>
703
704         [chromium] Add new gesture type (two finger tap) that triggers context menu.
705         https://bugs.webkit.org/show_bug.cgi?id=88173
706
707         Reviewed by Adam Barth.
708
709         * DumpRenderTree/chromium/EventSender.cpp:
710         (EventSender::EventSender):
711         (EventSender::gestureTwoFingerTap):
712         (EventSender::gestureEvent):
713         * DumpRenderTree/chromium/EventSender.h:
714         (EventSender):
715
716 2012-06-02  Zeno Albisser  <zeno@webkit.org>
717
718         Fix and enable WebGL for WebKit2 on Qt.
719         https://bugs.webkit.org/show_bug.cgi?id=86214
720
721         Enable WebGL by default for Qt MiniBrowser.
722
723         Reviewed by Noam Rosenthal.
724
725         * MiniBrowser/qt/qml/BrowserWindow.qml:
726
727 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
728
729         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
730         https://bugs.webkit.org/show_bug.cgi?id=88164
731
732         Reviewed by Kentaro Hara.
733
734         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
735         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
736
737         * Scripts/VCSUtils.pm:
738         (adjustPathForRecentRenamings):
739         (fixChangeLogPatch):
740
741 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
742
743         Rename test_expectations.txt to TestExpectations
744         https://bugs.webkit.org/show_bug.cgi?id=86690
745
746         Reviewed by Dirk Pranke.
747
748         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
749         We can the code to read test_expectations.txt once we've successfully transitioned.
750
751         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
752         (TestExpectationParser._check_path_does_not_exist):
753         (TestExpectationParser._tokenize):
754         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
755         * Scripts/webkitpy/layout_tests/port/base.py:
756         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
757         test_expectations.txt if one exists and the path to TestExpectations otherwise.
758         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
759         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
760         virtual.
761         * Scripts/webkitpy/layout_tests/port/chromium.py:
762         (ChromiumPort.path_from_chromium_base):
763         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
764         (ChromiumAndroidPort.test_expectations):
765         * Scripts/webkitpy/layout_tests/port/test.py:
766         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
767         (TestPort.__init__):
768         * Scripts/webkitpy/layout_tests/port/webkit.py:
769         (WebKitPort.baseline_search_path):
770         (WebKitPort.test_expectations):
771         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
772         tests to base as a follow up.
773         (WebKitPortTest.test_path_to_test_expectations_file):
774         (test_test_expectations):
775         (test_legacy_test_expectations):
776         * Scripts/webkitpy/style/checker.py:
777         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
778         with one for TestExpectations.
779         * Scripts/webkitpy/style/checkers/test_expectations.py:
780         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
781         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
782         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
783         test_expectations.txt.
784         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
785         (TestExpectationsTestCase.assert_lines_lint):
786         * Scripts/webkitpy/tool/commands/queries.py:
787         (PrintExpectations.__init__):
788         * Scripts/webkitpy/tool/commands/rebaseline.py:
789         (RebaselineExpectations):
790         * Scripts/webkitpy/tool/steps/commit.py:
791         (Commit._check_test_expectations):
792         * Scripts/webkitpy/tool/steps/commit_unittest.py:
793         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
794         (CommitTest.test_check_test_expectations): For TestExpectations.
795         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
796         * TestResultServer/static-dashboards/dashboard_base.js:
797         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
798         Error only when neither exists.
799         * TestResultServer/static-dashboards/flakiness_dashboard.js:
800         (processMissingAndExtraExpectations):
801         (htmlForTestsWithExpectationsButNoFailures):
802         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
803
804 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
805
806         Remove dependency from ImageDiff to WTF
807         https://bugs.webkit.org/show_bug.cgi?id=88147
808
809         Reviewed by Adam Barth.
810
811         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
812
813 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
814
815         NRWT seems to leak (more?) temp dirs
816         https://bugs.webkit.org/show_bug.cgi?id=88126
817
818         Re-land r119297 with chromium fix (weren't calling the
819         super() method if not in --test-shell mode in start().
820         Add unit tests to chromium_unittest as well to check.
821
822         * Scripts/webkitpy/layout_tests/port/chromium.py:
823         (ChromiumDriver.start):
824         * Scripts/webkitpy/layout_tests/port/webkit.py:
825         (WebKitDriver.__del__):
826         (WebKitDriver._start):
827         (WebKitDriver.run_test):
828         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
829         (WebKitDriverTest.test_check_for_driver_crash):
830         (WebKitDriverTest.test_stop_cleans_up_properly):
831         (WebKitDriverTest):
832         (WebKitDriverTest.test_two_starts_cleans_up_properly):
833         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
834         (ChromiumDriverTest.test_stop_cleans_up_properly):
835         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
836
837 2012-06-01  Tim Horton  <timothy_horton@apple.com>
838
839         Lots of "failed download-built-product" on Apple bots
840         https://bugs.webkit.org/show_bug.cgi?id=88158
841
842         Reviewed by Jessie Berlin.
843         
844         Disable mergeRequests on all Apple builders. This is a speculative fix.
845
846         * BuildSlaveSupport/build.webkit.org-config/config.json:
847
848 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
849
850         Unreviewed, rolling out r119297.
851         http://trac.webkit.org/changeset/119297
852         https://bugs.webkit.org/show_bug.cgi?id=88156
853
854         May have broken Chromium bots (Requested by rniwa on #webkit).
855
856         * Scripts/webkitpy/layout_tests/port/webkit.py:
857         (WebKitDriver.__del__):
858         (WebKitDriver.run_test):
859         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
860         (WebKitDriverTest.test_check_for_driver_crash):
861         (WebKitDriverTest.test_stop_cleans_up_properly):
862
863 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
864
865         nrwt seems to leak tmpdirs
866         https://bugs.webkit.org/show_bug.cgi?id=88126
867
868         Reviewed by Ojan Vafai.
869
870         Fix leak possibly introduced in r118979 - we now will
871         make sure we clean up any stale temp directories during the
872         start routine and attempt to clean up again in __del__. It
873         turns out that asserting in __del__ logs a message but is
874         caught by the runtime, so it's mostly useless.
875
876         * Scripts/webkitpy/layout_tests/port/webkit.py:
877         (WebKitDriver.__del__):
878         (WebKitDriver._start):
879         (WebKitDriver.run_test):
880         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
881         (WebKitDriverTest.test_check_for_driver_crash):
882         (WebKitDriverTest.test_stop_cleans_up_properly):
883         (WebKitDriverTest):
884         (WebKitDriverTest.test_two_starts_cleans_up_properly):
885
886 2012-06-01  Michael Saboff  <msaboff@apple.com>
887
888         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
889         https://bugs.webkit.org/show_bug.cgi?id=88109
890
891         Reviewed by Geoffrey Garen.
892
893         Additional test case.
894
895         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
896         (TestWebKitAPI::TEST):
897
898 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
899
900         [Qt] Use -Werror only in developer builds
901
902         Rubber-stamped by Tor Arne Vestbø.
903
904         In production builds -Werror with custom toolchains and wierd system
905         headers, -Werror is of no use and just creates confusion. So use it
906         only if Qt is configured with -developer-build.
907
908         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
909         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
910         only if qt_developer_build is set.
911
912 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
913
914         [watchlist] Add myself to loader and v8 bindings changes
915         https://bugs.webkit.org/show_bug.cgi?id=88112
916
917         Reviewed by Adam Barth.
918
919         * Scripts/webkitpy/common/config/watchlist:
920
921 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
922
923         Adding Jacky Jiang to committers.py
924         https://bugs.webkit.org/show_bug.cgi?id=88122
925
926         Reviewed by Rob Buis.
927
928         Adding myself to committers.py as a Committer.
929
930         * Scripts/webkitpy/common/config/committers.py:
931
932 2012-06-01  Jessie Berlin  <jberlin@apple.com>
933
934         Fix Windows build.
935
936         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
937
938 2012-06-01  Jessie Berlin  <jberlin@apple.com>
939
940         Windows WK2 MouseMoveAfterCrash API test failing
941         https://bugs.webkit.org/show_bug.cgi?id=69982
942
943         Disable the test on Windows to get the bots greener.
944
945         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
946         (TestWebKitAPI::TEST):
947
948 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
949
950         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
951         https://bugs.webkit.org/show_bug.cgi?id=86866
952
953         Reviewed by Adam Barth.
954
955         Catch new "intent,service,register" signal on the frame and print out
956         information about the Web Intent service in EFL's DumpRenderTree.
957
958         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
959         (DumpRenderTreeChrome::createView):
960         (DumpRenderTreeChrome::onFrameCreated):
961         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
962         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
963         (DumpRenderTreeChrome):
964
965 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
966
967         The ChangeLog parser cannot handle reviewers with initials in their name
968         https://bugs.webkit.org/show_bug.cgi?id=87864
969
970         Reviewed by Ryosuke Niwa.
971
972         Add support in the ChangeLog parser for reviewer names that have
973         initials in them.
974
975         * Scripts/webkitpy/common/checkout/changelog.py:
976         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
977         in the replacement string. This allows for matching the word characters before a
978         period, without totally throwing them away.
979         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
980         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
981         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
982
983 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
984
985         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
986         https://bugs.webkit.org/show_bug.cgi?id=86865
987
988         Reviewed by Adam Barth.
989
990         Add deliverWebIntent method to LayoutTestController and provide
991         implementation for EFL port.
992
993         * DumpRenderTree/LayoutTestController.cpp:
994         (deliverWebIntentCallback):
995         (LayoutTestController::staticFunctions):
996         * DumpRenderTree/LayoutTestController.h:
997         (LayoutTestController):
998         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
999         (LayoutTestController::deliverWebIntent):
1000         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1001         (LayoutTestController::deliverWebIntent):
1002         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1003         (LayoutTestController::deliverWebIntent):
1004         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1005         (LayoutTestController::deliverWebIntent):
1006         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1007         (LayoutTestController::deliverWebIntent):
1008         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1009         (LayoutTestController::deliverWebIntent):
1010
1011 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1012
1013         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1014
1015         Reviewed by Simon Hausmann.
1016
1017         * Tools.pro:
1018
1019 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1020
1021         Add public page loading performance tests using web-page-replay
1022         https://bugs.webkit.org/show_bug.cgi?id=84008
1023
1024         Reviewed by Dirk Pranke.
1025
1026         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1027         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1028         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1029
1030         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1031         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1032         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1033         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1034
1035         * Scripts/webkitpy/layout_tests/port/driver.py:
1036         (Driver.is_external_http_test): Added.
1037         * Scripts/webkitpy/layout_tests/port/webkit.py:
1038         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1039         * Scripts/webkitpy/performance_tests/perftest.py:
1040         (PerfTest.__init__): Takes port.
1041         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1042         (PerfTest):
1043         (PerfTest.run): Calls run_single.
1044         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1045         (ChromiumStylePerfTest.__init__):
1046         (PageLoadingPerfTest.__init__):
1047         (PageLoadingPerfTest.run):
1048         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1049         (ReplayServer.__init__):
1050         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1051         but it caused a dead lock on some web pages.
1052         (ReplayServer.stop):
1053         (ReplayServer.__del__):
1054         (ReplayPerfTest):
1055         (ReplayPerfTest.__init__):
1056         (ReplayPerfTest._start_replay_server):
1057         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1058         The subsequent runs of the same test will just use test.wpr.
1059         (ReplayPerfTest.run_single):
1060         (PerfTestFactory):
1061         (PerfTestFactory.create_perf_test):
1062         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1063         (MainTest.test_parse_output):
1064         (MainTest.test_parse_output_with_failing_line):
1065         (TestPageLoadingPerfTest.test_run):
1066         (TestPageLoadingPerfTest.test_run_with_bad_output):
1067         (TestReplayPerfTest):
1068         (TestReplayPerfTest.ReplayTestPort):
1069         (TestReplayPerfTest.ReplayTestPort.__init__):
1070         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1071         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1072         (TestReplayPerfTest.ReplayTestPort._driver_class):
1073         (TestReplayPerfTest.MockReplayServer):
1074         (TestReplayPerfTest.MockReplayServer.__init__):
1075         (TestReplayPerfTest.MockReplayServer.stop):
1076         (TestReplayPerfTest._add_file):
1077         (TestReplayPerfTest._setup_test):
1078         (TestReplayPerfTest.test_run_single):
1079         (TestReplayPerfTest.test_run_single.run_test):
1080         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1081         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1082         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1083         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1084         (TestReplayPerfTest.test_prepare):
1085         (TestReplayPerfTest.test_prepare.run_test):
1086         (TestReplayPerfTest.test_prepare_calls_run_single):
1087         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1088         (TestPerfTestFactory.test_regular_test):
1089         (TestPerfTestFactory.test_inspector_test):
1090         (TestPerfTestFactory.test_page_loading_test):
1091         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1092         (PerfTestsRunner):
1093         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1094         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1095         (PerfTestsRunner._collect_tests._is_test_file):
1096         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1097         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1098         (create_runner):
1099         (run_test):
1100         (_tests_for_runner):
1101         (test_run_test_set):
1102         (test_run_test_set_kills_drt_per_run):
1103         (test_run_test_pause_before_testing):
1104         (test_run_test_set_for_parser_tests):
1105         (test_run_test_set_with_json_output):
1106         (test_run_test_set_with_json_source):
1107         (test_run_test_set_with_multiple_repositories):
1108         (test_run_with_upload_json):
1109         (test_upload_json):
1110         (test_upload_json.MockFileUploader.upload_single_text_file):
1111         (_add_file):
1112         (test_collect_tests):
1113         (test_collect_tests_with_multile_files):
1114         (test_collect_tests_with_multile_files.add_file):
1115         (test_collect_tests_with_skipped_list):
1116         (test_collect_tests_with_page_load_svg):
1117         (test_collect_tests_should_ignore_replay_tests_by_default):
1118         (test_collect_tests_with_replay_tests):
1119         (test_parse_args):
1120         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1121         (AutoinstallImportHook.find_module):
1122         (AutoinstallImportHook._install_webpagereplay):
1123
1124 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1125
1126         Support building the Android port of chromium with Ninja
1127         https://bugs.webkit.org/show_bug.cgi?id=87545
1128
1129         Reviewed by Adam Barth.
1130
1131         Ensures that shared libraries are looked up in a generator-agnostic
1132         way and that output is placed in the correct directory.
1133
1134         Depends on http://codereview.chromium.org/10386188/
1135
1136         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1137
1138 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1139
1140         [Chromium] Chromium DRT should be able to load external resources
1141         https://bugs.webkit.org/show_bug.cgi?id=87893
1142
1143         Reviewed by Dirk Pranke.
1144
1145         Allow external resources to be loaded when the main frame's URL is also an external resource.
1146         This change is analogous to r118231 for Mac port.
1147
1148         * DumpRenderTree/chromium/WebViewHost.cpp:
1149         (blockRequest):
1150         (isLocalhost):
1151         (hostIsUsedBySomeTestsToGenerateError):
1152         (WebViewHost::willSendRequest):
1153
1154 2012-05-31  Anders Carlsson  <andersca@apple.com>
1155
1156         Build fixes.
1157
1158         Disable the C++11 extensions warning.
1159
1160         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1161         * TestWebKitAPI/Configurations/Base.xcconfig:
1162         * WebKitTestRunner/Configurations/Base.xcconfig:
1163
1164 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1165
1166         [WK2] window.internals settings are not reset between tests
1167         https://bugs.webkit.org/show_bug.cgi?id=87783
1168
1169         Reviewed by Mihai Parparita.
1170
1171         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1172         (WTR::InjectedBundle::done): Call resetAfterTest().
1173
1174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1175         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1176         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1177         This needs to be done after a tets, because the code assumes that there is an object
1178         with this name in global scope.
1179
1180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1181
1182 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1183
1184         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1185         https://bugs.webkit.org/show_bug.cgi?id=85006
1186
1187         Reviewed by Tor Arne Vestbø.
1188
1189         Added navigation_policy_decision implementation for DumpRenderTreeView.
1190         Added LayoutTestController::setCustomPolicyDelegate implementation.
1191         Modified LayoutTestController::waitForPolicyDelegate.
1192
1193         * DumpRenderTree/efl/DumpRenderTree.cpp:
1194         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1195         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1196         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1197         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1198         (navigationTypeToString): aux function
1199         (onNavigationPolicyDecision): navigation_policy_decision implementation
1200         (drtViewAdd):
1201         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1202         (LayoutTestController::setCustomPolicyDelegate):
1203         (LayoutTestController::waitForPolicyDelegate):
1204
1205 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1206
1207         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1208         https://bugs.webkit.org/show_bug.cgi?id=86195
1209
1210         Reviewed by Gustavo Noronha Silva.
1211
1212         Implement clearApplicationCacheForOrigin in EFL
1213         LayoutTestController.
1214
1215         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1216         (LayoutTestController::clearApplicationCacheForOrigin):
1217
1218 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1219
1220         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1221         https://bugs.webkit.org/show_bug.cgi?id=87955
1222
1223         Reviewed by Simon Hausmann.
1224
1225         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1226         * DumpRenderTree/qt/EventSenderQt.cpp:
1227         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1228         * DumpRenderTree/qt/main.cpp:
1229         * QtTestBrowser/cookiejar.cpp:
1230         * QtTestBrowser/launcherwindow.cpp:
1231         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1232         * qmake/mkspecs/features/default_post.prf:
1233
1234 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1235
1236         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1237
1238         Rubber-stamped by Kenneth Rohde Christiansen.
1239
1240         * qmake/config.tests/libpng/libpng.pro:
1241
1242 2012-05-30  Peter Beverloo  <peter@chromium.org>
1243
1244         [Chromium] Automatically install 64-bit linker for Android
1245         https://bugs.webkit.org/show_bug.cgi?id=79780
1246
1247         Reviewed by Adam Barth.
1248
1249         Change the update-webkit-chromium script to check whether the 64-bit
1250         linker needs to be installed as part of the update process. The actual
1251         code for doing these checks and "installing" it has been added to the
1252         webkitdirs.pm script.
1253
1254         The linker itself is part of the third_party/aosp repository, which
1255         will be pulled in through the DEPS change.
1256
1257         * Scripts/update-webkit-chromium:
1258         * Scripts/webkitdirs.pm:
1259         (chromiumInstall64BitAndroidLinkerIfNeeded):
1260         (chromiumReplaceAndroidLinkerIfNeeded):
1261
1262 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1263
1264         https://bugs.webkit.org/show_bug.cgi?id=87803
1265         Layout tests often fail trying to stat nonexistent logs 
1266
1267         Reviewed by Dirk Pranke.
1268
1269         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1270         try/catch block around accessing the logs as a precaution.
1271
1272         * Scripts/webkitpy/common/system/crashlogs.py:
1273         (CrashLogs._find_newest_log_darwin):
1274
1275 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1276
1277         Add a LayoutTest for prerender remove after stop.
1278         https://bugs.webkit.org/show_bug.cgi?id=87860
1279
1280         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1281         can be tested by LayoutTests now.
1282
1283         Reviewed by Adam Barth.
1284
1285         * DumpRenderTree/DumpRenderTree.gypi:
1286         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1287         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1288         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1289         (MockWebPrerenderingSupport::add):
1290         (MockWebPrerenderingSupport::cancel):
1291         (MockWebPrerenderingSupport::abandon):
1292         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1293         (MockWebPrerenderingSupport):
1294         * DumpRenderTree/chromium/TestShell.cpp:
1295         (TestShell::initialize):
1296         * DumpRenderTree/chromium/TestShell.h:
1297         (TestShell):
1298         * DumpRenderTree/chromium/WebViewHost.cpp:
1299         (WebViewHost::willAddPrerender):
1300         (WebViewHost::setWebWidget):
1301         * DumpRenderTree/chromium/WebViewHost.h:
1302         (WebViewHost):
1303
1304 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1305
1306         https://bugs.webkit.org/show_bug.cgi?id=87717
1307         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1308
1309         Reviewed by Dirk Pranke.
1310
1311         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1312         If there isn't a crash log found for the process add a message saying
1313         the process was unresponsive.
1314
1315         * Scripts/webkitpy/layout_tests/port/webkit.py:
1316         (WebKitDriver.__init__):
1317         (WebKitDriver._check_for_driver_crash):
1318         (WebKitDriver.run_test):
1319         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1320         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1321         (WebKitDriverTest):
1322         (WebKitDriverTest.test_check_for_driver_crash):
1323         * WebKitTestRunner/TestController.cpp:
1324         (WTR):
1325         (WTR::TestController::runTest):
1326
1327 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1328
1329         https://bugs.webkit.org/show_bug.cgi?id=87714
1330         Mac crash logs can take a really long time to be written out.
1331
1332         Reviewed by Dirk Pranke.
1333
1334         Make a second pass looking for crash logs after the tests have completed running.
1335
1336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1337         (use_trac_links_in_results_html):
1338         (Manager.run):
1339         * Scripts/webkitpy/layout_tests/port/base.py:
1340         (Port.repository_paths):
1341         (Port.look_for_new_crash_logs):
1342         * Scripts/webkitpy/layout_tests/port/mac.py:
1343         (MacPort.look_for_new_crash_logs):
1344         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1345         (test_get_crash_log):
1346         (test_look_for_new_crash_logs):
1347         (test_look_for_new_crash_logs.fake_time_cb):
1348
1349 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1350
1351         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1352
1353         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1354         (LayoutWebViewEventHandler::OnAlertEvent):
1355         (LayoutWebViewEventHandler::OnConfirmEvent):
1356         (LayoutWebViewEventHandler):
1357         (LayoutWebViewEventHandler::OnPromptEvent):
1358         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1359         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1360
1361 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1362
1363         Only give lint errors for -expected.png png files that lack a checksum
1364         https://bugs.webkit.org/show_bug.cgi?id=87875
1365
1366         Reviewed by Tony Chang.
1367
1368         We have other pngs in the tree, e.g. for the inspector, that legitimately
1369         lack a checksum.
1370
1371         * Scripts/webkitpy/style/checkers/png.py:
1372         (PNGChecker.check):
1373         * Scripts/webkitpy/style/checkers/png_unittest.py:
1374         (PNGCheckerTest.test_check):
1375
1376 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1377
1378         nrwt: seems to leak temp dirs
1379         https://bugs.webkit.org/show_bug.cgi?id=87795
1380
1381         Reviewed by Ojan Vafai.
1382
1383         There appears to be a bug where the chromium bots are creating
1384         temporary directories and not cleaning them up that started
1385         after the switch to WebKitDriver. It's possible that __del__
1386         wasn't getting called in a timely manner (or at all), and it's
1387         generally bad style to rely on __del__ being called, so this
1388         code changes things so that we create a temp dir in
1389         driver.start() and remove it in driver.stop(). We could be
1390         paranoid and leave the __del__ code in, but there doesn't seem
1391         to be much advantage to it. If there are bugs that result in
1392         drivers being started but not stopped, we have other problems.
1393
1394         * Scripts/webkitpy/common/system/filesystem_mock.py:
1395         (MockFileSystem.__init__):
1396         (MockFileSystem._mktemp):
1397         (MockFileSystem.mkdtemp):
1398         * Scripts/webkitpy/layout_tests/port/webkit.py:
1399         (WebKitDriver.__init__):
1400         (WebKitDriver._start):
1401         (WebKitDriver.stop):
1402         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1403         (WebKitDriverTest.test_check_for_driver_crash):
1404         (WebKitDriverTest):
1405         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1406         (WebKitDriverTest.test_stop_cleans_up_properly):
1407
1408 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1409
1410         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1411         https://bugs.webkit.org/show_bug.cgi?id=86841
1412
1413         Reviewed by Adam Barth.
1414
1415         Print the number of MessagePorts for each new intent in EFL's DRT.
1416         This output is expected by several Web Intents test cases.
1417
1418         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1419         (DumpRenderTreeChrome::onFrameIntentNew):
1420
1421 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1422
1423         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1424
1425         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1426
1427 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1428
1429         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1430         https://bugs.webkit.org/show_bug.cgi?id=87829
1431
1432         Reviewed by Adam Barth.
1433
1434         EFL's LayoutTestController now makes uses of the new helper method in
1435         DumpRenderTreeSupportEfl in order to send the intent response. This is
1436         now needed because the Ewk_Intent_Request postResult / postFailure
1437         methods were made private.
1438
1439         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1440         (LayoutTestController::sendWebIntentResponse):
1441
1442 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1443
1444         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1445         https://bugs.webkit.org/show_bug.cgi?id=86296
1446
1447         Reviewed by Tony Chang.
1448
1449         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1450         (cfHDropFormat):
1451         (cfFileNameWFormat):
1452         (cfUrlWFormat):
1453         (WCEnumFormatEtc):
1454         (WCEnumFormatEtc::WCEnumFormatEtc):
1455         (WCEnumFormatEtc::QueryInterface):
1456         (WCEnumFormatEtc::AddRef):
1457         (WCEnumFormatEtc::Release):
1458         (WCEnumFormatEtc::Next):
1459         (WCEnumFormatEtc::Skip):
1460         (WCEnumFormatEtc::Reset):
1461         (WCEnumFormatEtc::Clone):
1462         (DRTDataObject::createInstance):
1463         (DRTDataObject::DRTDataObject):
1464         (DRTDataObject::~DRTDataObject):
1465         (DRTDataObject::QueryInterface):
1466         (DRTDataObject::AddRef):
1467         (DRTDataObject::Release):
1468         (DRTDataObject::GetData):
1469         (DRTDataObject::GetDataHere):
1470         (DRTDataObject::QueryGetData):
1471         (DRTDataObject::GetCanonicalFormatEtc):
1472         (DRTDataObject::SetData):
1473         (DRTDataObject::CopyMedium):
1474         (DRTDataObject::EnumFormatEtc):
1475         (DRTDataObject::DAdvise):
1476         (DRTDataObject::DUnadvise):
1477         (DRTDataObject::EnumDAdvise):
1478         (DRTDataObject::clearData):
1479         * DumpRenderTree/win/DRTDataObject.h: Added.
1480         (DRTDataObject):
1481         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1482         (DRTDropSource::DRTDropSource):
1483         (DRTDropSource::~DRTDropSource):
1484         (DRTDropSource::QueryInterface):
1485         (DRTDropSource::AddRef):
1486         (DRTDropSource::Release):
1487         (DRTDropSource::createInstance):
1488         (DRTDropSource::QueryContinueDrag):
1489         (DRTDropSource::GiveFeedback):
1490         * DumpRenderTree/win/DRTDropSource.h: Added.
1491         (DRTDropSource):
1492         * DumpRenderTree/win/DumpRenderTree.vcproj:
1493         * DumpRenderTree/win/EventSender.cpp:
1494         (beginDragWithFilesCallback):
1495
1496 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1497
1498         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1499         https://bugs.webkit.org/show_bug.cgi?id=58593
1500
1501         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1502         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1503         public C API of the WebProcess.
1504
1505         Reviewed by Darin Adler.
1506
1507         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1508         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1509         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1510         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1511         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1512
1513 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1514
1515         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1516         https://bugs.webkit.org/show_bug.cgi?id=87848
1517
1518         Reviewed by Csaba Osztrogonác.
1519
1520         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1521         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1522         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1523
1524         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1525         (DumpRenderTreeChrome::extraViews):
1526         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1527         (DumpRenderTreeChrome):
1528
1529 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1530
1531         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1532         https://bugs.webkit.org/show_bug.cgi?id=87833
1533
1534         Reviewed by Tor Arne Vestbø.
1535
1536         Print "postProgressFinishedNotification" message if frame load finished 
1537         to unskip http/tests/loading/progress-finished-callback.html.
1538
1539         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1540         (DumpRenderTreeChrome::onFrameLoadFinished):
1541
1542 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1543
1544         [EFL][WK2] Fix WebKit2-EFL build
1545         https://bugs.webkit.org/show_bug.cgi?id=83693
1546
1547         Reviewed by Carlos Garcia Campos.
1548
1549         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1550
1551 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1552
1553         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1554         (They only used to check for Skipped in platform/qt-5.0-wk1)
1555         https://bugs.webkit.org/show_bug.cgi?id=87376
1556
1557         Reviewed by Csaba Osztrogonác.
1558
1559         * Scripts/old-run-webkit-tests:
1560         (buildPlatformResultHierarchy):
1561         * Scripts/webkitpy/layout_tests/port/qt.py:
1562         (QtPort.baseline_search_path):
1563
1564 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1565
1566         Add a linter error for pngs that lack an embedded checksum
1567         https://bugs.webkit.org/show_bug.cgi?id=87793
1568
1569         Reviewed by Dirk Pranke.
1570
1571         * Scripts/read-checksum-from-png:
1572         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1573         (read_checksum):
1574         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1575         (ReadChecksumFromPngTest):
1576         (ReadChecksumFromPngTest.test_read_checksum):
1577         * Scripts/webkitpy/layout_tests/port/base.py:
1578         * Scripts/webkitpy/style/checkers/png.py:
1579         (PNGChecker.check):
1580         * Scripts/webkitpy/style/checkers/png_unittest.py:
1581         (PNGCheckerTest.test_check):
1582
1583 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=87720
1586         WebProcess is often killed due to being unresponsive on the bots
1587
1588         Reviewed by Alexey Proskuryakov.
1589
1590         Blind attempt to improve flakiness on the bots by reducing the number
1591         of crashes due to an unresponsive process.  This helped on my personal machine
1592         under stress conditions.  I don't have enough cores to hit the problem
1593         under normal conditions.
1594
1595         * WebKitTestRunner/TestController.cpp:
1596         (WTR):
1597
1598 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1599
1600         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1601         https://bugs.webkit.org/show_bug.cgi?id=87779
1602
1603         Reviewed by Eric Seidel.
1604
1605         Update output to match the names in scm.py as per
1606         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1607
1608         * Scripts/webkitpy/tool/commands/rebaseline.py:
1609         (RebaselineTest.execute):
1610         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1611         (test_rebaseline_test_and_print_scm_changes):
1612         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1613         (GardeningServerTest.test_rebaselineall):
1614
1615 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1616
1617         https://bugs.webkit.org/show_bug.cgi?id=87711
1618
1619         Reviewed by Jessie Berlin.
1620
1621         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1622         are better maintained.
1623
1624         * BuildSlaveSupport/build.webkit.org-config/config.json:
1625
1626 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1627
1628         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1629         https://bugs.webkit.org/show_bug.cgi?id=87538
1630
1631         Reviewed by Ojan Vafai.
1632
1633         Invoking git and svn on one file at a time is kinda slow. We
1634         should batch the add and rm operations together.
1635
1636         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1637         (BaselineOptimizer._move_baselines):
1638
1639 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1640
1641         garden-o-matic should rebaseline baselines in parallel
1642         https://bugs.webkit.org/show_bug.cgi?id=87451
1643
1644         Reviewed by Ojan Vafai.
1645                                                                                
1646         This modifies garden-o-matic so that we will fetch all                  
1647         of the baselines in parallel from the bots, and then                    
1648         optimize the baselines serially (since that should be fairly            
1649         quick and we get into trouble if we optimize in parallel due            
1650         to concurrent access to the source control system).                     
1651
1652         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1653         so that the files that need to be modified in the SCM are returned to 
1654         garden-o-matic rather than actually added or removed. This is done so that
1655         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1656         concurrently). In order to safely return the files (as a JSON dict) I
1657         needed to shift all of the logging in rebaseline-test to use the logging
1658         module (and hence log to stderr).
1659
1660         I also had to stub out a line in chromium.py that would get confused if
1661         the skia overrides file didn't exist in a mock checkout.
1662
1663         * Scripts/webkitpy/common/system/executive.py:
1664         (Executive.popen):
1665         (Executive):
1666         (Executive.run_in_parallel):
1667         (_run_command_thunk):
1668         * Scripts/webkitpy/common/system/executive_mock.py:
1669         (MockExecutive.run_in_parallel):
1670         * Scripts/webkitpy/common/system/executive_unittest.py:
1671         (ExecutiveTest.test_run_in_parallel):
1672         * Scripts/webkitpy/layout_tests/port/chromium.py:
1673         (ChromiumPort._expectations_file_contents):
1674         * Scripts/webkitpy/tool/commands/rebaseline.py:
1675         (AbstractRebaseliningCommand.__init__):
1676         (RebaselineTest.__init__):
1677         (RebaselineTest._copy_existing_baseline):
1678         (RebaselineTest._save_baseline):
1679         (RebaselineTest):
1680         (RebaselineTest._add_to_scm):
1681         (RebaselineTest._rebaseline_test):
1682         (RebaselineTest.execute):
1683         (RebaselineExpectations._rebaseline_port):
1684         (RebaselineExpectations.execute):
1685         (Rebaseline._builder_to_pull_from):
1686         (Rebaseline.execute):
1687         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1688         (test_rebaseline_updates_expectations_file):
1689         (test_rebaseline_test):
1690         (test_rebaseline_test_and_print_scm_changes):
1691         (test_rebaseline_and_copy_test):
1692         (test_rebaseline_and_copy_test_no_existing_result):
1693         (test_rebaseline_and_copy_test_with_lion_result):
1694         (test_rebaseline_and_copy_no_overwrite_test):
1695         (test_rebaseline_expectations):
1696         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1697         (GardeningHTTPRequestHandler._rebaseline_commands):
1698         (GardeningHTTPRequestHandler):
1699         (GardeningHTTPRequestHandler._files_to_add):
1700         (GardeningHTTPRequestHandler._optimize_baselines):
1701         (GardeningHTTPRequestHandler.rebaselineall):
1702         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1703         (GardeningServerTest._post_to_path):
1704         (GardeningServerTest.test_rebaselineall):
1705         (GardeningServerTest.test_rebaselineall.run_command):
1706
1707 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1708
1709         Fix the type of dispatch_time() offset
1710
1711         Rubber-stamped by Joseph Pecoraro.
1712
1713         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1714
1715         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1716         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1717
1718 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1719
1720         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1721
1722         [BlackBerry] OpenGL content is not rendered on simulator
1723         https://bugs.webkit.org/show_bug.cgi?id=87721
1724
1725         Reviewed by George Staikos.
1726
1727         Fixed by enabling GLES2 support in simulator builds.
1728
1729         To experiment with building without OpenGL support, you can set the
1730         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1731
1732         PR #150695
1733
1734         * Scripts/webkitdirs.pm:
1735         (blackberryCMakeArguments):
1736
1737 2012-05-29  David Barr  <davidbarr@chromium.org>
1738
1739         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1740         https://bugs.webkit.org/show_bug.cgi?id=87685
1741
1742         Reviewed by Eric Seidel.
1743
1744         Add a configuration option for CSS image-resolution support, disabling it by default.
1745
1746         * Scripts/webkitperl/FeatureList.pm:
1747         * qmake/mkspecs/features/features.pri:
1748
1749 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1750
1751         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1752
1753         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1754             valid for C++/ObjC++ but not for C [enabled by default]"
1755
1756         Reviewed by Simon Hausmann.
1757
1758         * qmake/mkspecs/features/unix/default_post.prf:
1759
1760 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1761
1762         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=87133
1765
1766         We now base64-encode the page url in the image-provider url, so that any
1767         normalization done by QUrl will not mess up the page-url. The logic of
1768         creating and parsing the provider-url has been moved into the image
1769         provider, to keep it in one place.
1770
1771         We were also releasing icons (even ones we hadn't retained), which we can't
1772         do since we don't know when the icon url is no longer in use.
1773
1774         Reviewed-by Simon Hausmann.
1775
1776         * MiniBrowser/qt/icons/favicon.png:
1777         * MiniBrowser/qt/qml/BrowserWindow.qml:
1778
1779 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1780
1781         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1782         https://bugs.webkit.org/show_bug.cgi?id=87654
1783
1784         Reviewed by Csaba Osztrogonác.
1785
1786         Event sender provides strings for all the key events.
1787         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1788         a key event has empty string.
1789
1790         * DumpRenderTree/efl/EventSender.cpp:
1791         (KeyEventInfo::KeyEventInfo):
1792         (keyPadNameFromJSValue):
1793         (keyNameFromJSValue):
1794
1795 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1796
1797         [Qt] Cancel potential url-edit when going back/forward
1798
1799         Reviewed by Kenneth Rohde Christiansen.
1800
1801         * MiniBrowser/qt/qml/BrowserWindow.qml:
1802
1803 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1804
1805         [EFL] Compilation warning in DumpRenderTreeView.cpp
1806         https://bugs.webkit.org/show_bug.cgi?id=87636
1807
1808         Reviewed by Filip Pizlo.
1809
1810         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1811         specifier in printf. Also fix the return type for
1812         onExceededApplicationCacheQuota callback.
1813
1814         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1815         (onExceededApplicationCacheQuota):
1816
1817 2012-05-29  Hironori Bono  <hbono@chromium.org>
1818
1819         Adding Hironori Bono to committers.py.
1820         https://bugs.webkit.org/show_bug.cgi?id=87697
1821
1822         * Scripts/webkitpy/common/config/committers.py:
1823
1824 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1825
1826         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1827         https://bugs.webkit.org/show_bug.cgi?id=80135
1828
1829         Reviewed by Rob Buis.
1830
1831         Implemented interface function didReceiveAuthenticationChallenge in class
1832         DumpRenderTree.
1833
1834         Resubmit the patch reverted by r115104 after the digest infinite loop
1835         issue for BlackBerry porting get identified and fixed.
1836
1837         Internally reviewed by Joe Mason <jmason@rim.com>
1838
1839         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1840         (drtCredentialDescription):
1841         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1842         (WebKit):
1843         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1844         (WebCore):
1845         (DumpRenderTree):
1846
1847 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1848
1849         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1850         https://bugs.webkit.org/show_bug.cgi?id=42328
1851
1852         Reviewed by Eric Seidel.
1853
1854         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1855         move to windows.internals.settings.
1856
1857         * DumpRenderTree/LayoutTestController.cpp:
1858         (LayoutTestController::staticFunctions):
1859         * DumpRenderTree/LayoutTestController.h:
1860         (LayoutTestController):
1861         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1862         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1863         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1864         (DRTDevToolsAgent):
1865         * DumpRenderTree/chromium/LayoutTestController.cpp:
1866         (LayoutTestController::LayoutTestController):
1867         * DumpRenderTree/chromium/LayoutTestController.h:
1868         (LayoutTestController):
1869         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1870         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1871         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1872         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1873         * DumpRenderTree/mac/DumpRenderTree.mm:
1874         (resetWebViewToConsistentStateBeforeTesting):
1875         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1876         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1877         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1878         (LayoutTestController):
1879         * DumpRenderTree/win/DumpRenderTree.cpp:
1880         (resetWebViewToConsistentStateBeforeTesting):
1881         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1882         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1883         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1884         (LayoutTestController):
1885
1886 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1887
1888         Move allowRoundingHacks to Internals interface
1889         https://bugs.webkit.org/show_bug.cgi?id=87328
1890
1891         Reviewed by Hajime Morita.
1892
1893         Remove allowRoundingHacks functions, because it is able to work in the
1894         cross-port way through the Internals interface.
1895
1896         * DumpRenderTree/LayoutTestController.cpp:
1897         (LayoutTestController::staticFunctions):
1898         * DumpRenderTree/LayoutTestController.h:
1899         (LayoutTestController):
1900         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1901         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1902         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1903         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1905         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1906
1907 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1908
1909         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1910         https://bugs.webkit.org/show_bug.cgi?id=87616
1911
1912         Reviewed by Hajime Morita.
1913
1914         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1915         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1916         Patch just adds a #ifndef / #define check.
1917
1918         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1919         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1920
1921 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1922
1923         [EFL] Enable blob support for the EFL port
1924         https://bugs.webkit.org/show_bug.cgi?id=85363
1925
1926         Reviewed by Hajime Morita.
1927
1928         Enable Blob support by default for the EFL port.
1929
1930         * Scripts/webkitperl/FeatureList.pm:
1931
1932 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1933
1934         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1935         https://bugs.webkit.org/show_bug.cgi?id=87582
1936
1937         Reviewed by Darin Adler.
1938
1939         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1940         possible to test pages in a similar way as they are loaded in Browsers.
1941
1942         * DumpRenderTree/LayoutTestController.cpp:
1943         (LayoutTestController::LayoutTestController):
1944         (setUseDeferredFrameLoadingCallback):
1945         (LayoutTestController::staticFunctions):
1946         * DumpRenderTree/LayoutTestController.h:
1947         (LayoutTestController::useDeferredFrameLoading):
1948         (LayoutTestController::setUseDeferredFrameLoading):
1949         (LayoutTestController):
1950         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1951         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1952
1953 2012-05-27  David Barton  <dbarton@mathscribe.com>
1954
1955         [watchlist] Improve MathML rule
1956         https://bugs.webkit.org/show_bug.cgi?id=87592
1957
1958         Reviewed by Adam Barth.
1959
1960         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1961         but if this changed the rule would be slow. We protect against this, clarify the rule,
1962         and make it more similar to existing rules.
1963
1964         * Scripts/webkitpy/common/config/watchlist:
1965
1966 2012-05-27  David Barton  <dbarton@mathscribe.com>
1967
1968         [watchlist] Add myself & a rule for MathML
1969         https://bugs.webkit.org/show_bug.cgi?id=87586
1970
1971         Reviewed by Adam Barth.
1972
1973         * Scripts/webkitpy/common/config/watchlist:
1974
1975 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1976
1977         Use xcrun to find path to nm for Mac port
1978         <http://webkit.org/b/87588>
1979
1980         Reviewed by Dan Bernstein.
1981
1982         * Scripts/webkitpy/layout_tests/port/mac.py:
1983         (MacPort.nm_command): Add. Tries to find a path for the nm
1984         command using xcrun.  Falls back to returning 'nm'.
1985         * Scripts/webkitpy/layout_tests/port/webkit.py:
1986         (WebKitPort.nm_command): Add. Returns 'nm'.
1987         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1988
1989 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1990
1991         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1992
1993         Reviewed by Eric Seidel.
1994
1995         * DumpRenderTree/win/DumpRenderTree.vcproj:
1996         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1997         (FrameLoadDelegate::FrameLoadDelegate):
1998         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1999         * DumpRenderTree/win/FrameLoadDelegate.h:
2000         (FrameLoadDelegate):
2001         * DumpRenderTree/win/TextInputController.cpp: Added.
2002         (setMarkedTextCallback):
2003         (hasMarkedTextCallback):
2004         (unmarkTextCallback):
2005         (markedRangeCallback):
2006         (insertTextCallback):
2007         (firstRectForCharacterRangeCallback):
2008         (selectedRangeCallback):
2009         (TextInputController::makeWindowObject):
2010         (TextInputController::getJSClass):
2011         (TextInputController::staticValues):
2012         (TextInputController::staticFunctions):
2013         * DumpRenderTree/win/TextInputController.h: Added.
2014         (TextInputController):
2015         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2016         (TextInputController::setMarkedText):
2017         (TextInputController::hasMarkedText):
2018         (TextInputController::unmarkText):
2019         (TextInputController::markedRange):
2020         (TextInputController::insertText):
2021         (TextInputController::firstRectForCharacterRange):
2022         (TextInputController::selectedRange):
2023
2024 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2025
2026         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2027         https://bugs.webkit.org/show_bug.cgi?id=87528
2028
2029         Reviewed by Ojan Vafai.
2030
2031         launching git or svn for individual files can be slow; this
2032         change will hand multiple paths at once to git and svn so they
2033         can be added in a batch.
2034
2035         * Scripts/webkitpy/common/checkout/scm/git.py:
2036         (Git.add_list):
2037         (Git.delete_list):
2038         * Scripts/webkitpy/common/checkout/scm/scm.py:
2039         (SCM.add):
2040         (SCM):
2041         (SCM.add_list):
2042         (SCM.delete):
2043         (SCM.delete_list):
2044         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2045         (MockSCM.add):
2046         (MockSCM):
2047         (MockSCM.add_list):
2048         (MockSCM.delete):
2049         (MockSCM.delete_list):
2050         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2051         (_shared_test_exists):
2052         (_shared_test_added_files):
2053         (_test_delete_list):
2054         * Scripts/webkitpy/common/checkout/scm/svn.py:
2055         (SVN.add_list):
2056         (SVN.delete_list):
2057
2058 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2059
2060         [NRWT] Add unit testing for perf tests on locked shards
2061         https://bugs.webkit.org/show_bug.cgi?id=87489
2062
2063         Reviewed by Dirk Pranke.
2064
2065         Adding utests that makes sure that perf tests are running in locked
2066         shards and by passing --no-http won't break NRWT (r118421).
2067
2068         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2069         (ShardingTests):
2070         (ShardingTests.test_shard_by_dir):
2071         (ShardingTests.test_shard_every_file):
2072         (ShardingTests.test_shard_in_two):
2073         (ShardingTests.test_multiple_locked_shards):
2074         (LockCheckingManager):
2075         (LockCheckingManager.__init__):
2076         (LockCheckingManager.handle_finished_list):
2077         (ManagerTest.test_http_locking):
2078         (ManagerTest):
2079         (ManagerTest.test_perf_locking):
2080         * Scripts/webkitpy/layout_tests/port/test.py:
2081
2082 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2083
2084         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2085         https://bugs.webkit.org/show_bug.cgi?id=87511
2086
2087         Reviewed by Alexey Proskuryakov.
2088
2089         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2090
2091         * DumpRenderTree/win/EventSender.cpp:
2092         (keyDownCallback):
2093
2094 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2095
2096         Adding Ken Buchanan to committers.py
2097         https://bugs.webkit.org/show_bug.cgi?id=87443
2098
2099         Unreviewed.
2100
2101         Adding self to committers.py as a Committer.
2102
2103         * Scripts/webkitpy/common/config/committers.py:
2104
2105 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2106
2107         [Qt] Buildfix for newer Qt5
2108         https://bugs.webkit.org/show_bug.cgi?id=87257
2109
2110         Reviewed by Simon Hausmann.
2111
2112         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2113
2114 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2115
2116         [Qt] Unreviewed fix after r118484.
2117
2118         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2119         They were enabled uncoditinally before r118484.
2120
2121         * qmake/mkspecs/features/features.pri:
2122
2123 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2124
2125         Add feature defines for web-facing parts of CSS Regions and Exclusions
2126         https://bugs.webkit.org/show_bug.cgi?id=87442
2127         <rdar://problem/10887709>
2128
2129         Reviewed by Dan Bernstein.
2130
2131         * Scripts/webkitperl/FeatureList.pm:
2132
2133 2012-05-24  Hironori Bono  <hbono@chromium.org>
2134
2135         Enable grammar checking on Chromium when we paste text (Take 2)
2136         https://bugs.webkit.org/show_bug.cgi?id=74393
2137
2138         Reviewed by Ryosuke Niwa.
2139
2140         This change enables grammar checking on Chromium and implements a mock grammar
2141         checker to fix a failing test.
2142
2143         * DumpRenderTree/DumpRenderTree.gypi:
2144         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2145         (MockGrammarCheck::checkGrammarOfString):
2146         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2147         (WebKit):
2148         (MockGrammarCheck):
2149         * DumpRenderTree/chromium/WebViewHost.cpp:
2150         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2151
2152 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2153
2154         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2155         https://bugs.webkit.org/show_bug.cgi?id=86842
2156
2157         Reviewed by Antonio Gomes.
2158
2159         Add support for overriding the application cache support preference
2160         through EFL's LayoutTestController.
2161
2162         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2163         (LayoutTestController::overridePreference):
2164
2165 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2166
2167         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2168         https://bugs.webkit.org/show_bug.cgi?id=85209
2169
2170         Reviewed by Antonio Gomes.
2171
2172         Set developer extras setting called twice on the test startup. Hence, removing
2173         an unnecessary extra call which set wrong value. 
2174
2175         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2176         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2177
2178 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2179
2180         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2181         https://bugs.webkit.org/show_bug.cgi?id=86916
2182
2183         Reviewed by Adam Barth.
2184
2185         Note that if release and debug are failing differently, debug
2186         will be ignored ...
2187
2188         Note: also change the use of a fake port name from
2189         "mock-port-name" to "test-mac-leopard" to make it more friendly
2190         to the port factory ("mock" actually is a real port).
2191
2192         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2193         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2194         (GardeningHTTPRequestHandler.rebaselineall):
2195         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2196         (GardeningServerTest.test_rebaselineall):
2197         (GardeningServerTest.test_rebaseline_new_port):
2198
2199 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2200
2201         nrwt: fix baseline search path for official chrome builders
2202         https://bugs.webkit.org/show_bug.cgi?id=87432
2203
2204         Reviewed by Tony Chang.
2205
2206         The official chrome builders need to use the win7 and SL
2207         baseline paths, not the XP and Leopard paths. Linux is correct.
2208
2209         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2210         (GoogleChromeMacPort.determine_full_port_name):
2211         (GoogleChromeWinPort.determine_full_port_name):
2212         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2213         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2214         (TestGoogleChromePort.test_get_google_chrome_port):
2215
2216 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2217
2218         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2219         https://bugs.webkit.org/show_bug.cgi?id=86800
2220
2221         Reviewed by Dirk Pranke.
2222
2223         Don't launch a HTTP server with lock based only on the existence of
2224         locked shards since we now run perf on locked shards too.
2225
2226         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2227         (Manager._run_tests):
2228
2229 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2230
2231         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2232         https://bugs.webkit.org/show_bug.cgi?id=87128
2233
2234         Reviewed by Dirk Pranke.
2235
2236         * Scripts/webkitpy/layout_tests/port/base.py:
2237         (Port.driver_name):
2238         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2239         (ChromiumLinuxPort._path_to_driver):
2240         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2241         (ChromiumPortTest.test_driver_name_option):
2242         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2243         (ChromiumWinPort._path_to_driver):
2244         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2245         (parse_args):
2246
2247 2012-05-24  John Mellor  <johnme@chromium.org>
2248
2249         Font Boosting: Add compile flag and runtime setting
2250         https://bugs.webkit.org/show_bug.cgi?id=87394
2251
2252         Reviewed by Adam Barth.
2253
2254         Add ENABLE_FONT_BOOSTING.
2255
2256         * Scripts/webkitperl/FeatureList.pm:
2257         * qmake/mkspecs/features/features.pri:
2258
2259 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2260
2261         [EFL] [DRT] keyboard-related tests do not pass
2262         https://bugs.webkit.org/show_bug.cgi?id=85369
2263
2264         Reviewed by Gustavo Noronha Silva.
2265
2266         Add SHIFT modifier for capital letters as VK_ 
2267         codes do not distinguish between lows and caps and also to be consistent
2268         with other ports which send caps as lowercase letters with the shift key down.
2269
2270         * DumpRenderTree/efl/EventSender.cpp:
2271         (keyNameFromJSValue): 
2272
2273 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2274
2275         [WK2] Let the client give local files universal access on a case by case basis
2276         https://bugs.webkit.org/show_bug.cgi?id=87174
2277         <rdar://problem/11024330>
2278
2279         Reviewed by Maciej Stachowiak.
2280
2281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2282         Added initialization of a new structure member to prevent build failure.
2283
2284 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2285
2286         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2287         https://bugs.webkit.org/show_bug.cgi?id=87203
2288
2289         Reviewed by Andreas Kling.
2290
2291         Add the required changes to make
2292         fast/events/keydown-leftright-keys.html pass after r118001.
2293
2294         * DumpRenderTree/efl/EventSender.cpp:
2295         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2296         into the proper X11 keysym definitions.
2297
2298 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2299
2300         Unreviewed, rolling out r118352.
2301         http://trac.webkit.org/changeset/118352
2302         https://bugs.webkit.org/show_bug.cgi?id=87390
2303
2304         Caused 6 editing/spelling tests crash/fail on chromium in
2305         debug. (Requested by vsevik on #webkit).
2306
2307         * DumpRenderTree/DumpRenderTree.gypi:
2308         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2309         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2310         * DumpRenderTree/chromium/WebViewHost.cpp:
2311         (WebViewHost::finishLastTextCheck):
2312
2313 2012-05-24  Peter Beverloo  <peter@chromium.org>
2314
2315         Add John Mellor as a contributor
2316         https://bugs.webkit.org/show_bug.cgi?id=87389
2317
2318         Reviewed by Kenneth Rohde Christiansen.
2319
2320         John will be working on Font Boosting and is very involved with various
2321         web-facing subjects of Chrome for Android, such as viewport.
2322
2323         * Scripts/webkitpy/common/config/committers.py:
2324
2325 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2326
2327         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2328         https://bugs.webkit.org/show_bug.cgi?id=86840
2329
2330         Reviewed by Csaba Osztrogonác.
2331
2332         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2333         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2334         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2335         (LayoutTestController::setCacheModel): Implementation added.
2336
2337 2012-05-24  Hironori Bono  <hbono@chromium.org>
2338
2339         Enable grammar checking on Chromium when we paste text.
2340         https://bugs.webkit.org/show_bug.cgi?id=74393
2341
2342         Reviewed by Hajime Morita.
2343
2344         This change enables grammar checking on Chromium and implements a mock grammar
2345         checker to fix a failing test.
2346
2347         * DumpRenderTree/DumpRenderTree.gypi:
2348         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2349         (MockGrammarCheck::checkGrammarOfString):
2350         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2351         (WebKit):
2352         (MockGrammarCheck):
2353         * DumpRenderTree/chromium/WebViewHost.cpp:
2354         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2355
2356 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2357
2358         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2359
2360         * qmake/mkspecs/features/features.pri:
2361
2362 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2363
2364         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2365         https://bugs.webkit.org/show_bug.cgi?id=86867
2366
2367         Reviewed by Adam Barth.
2368
2369         Add implementation for sendWebIntentResponse() in EFL's
2370         LayoutTestController and add empty implementation for other ports.
2371
2372         * DumpRenderTree/LayoutTestController.cpp:
2373         (sendWebIntentResponseCallback):
2374         (LayoutTestController::staticFunctions):
2375         * DumpRenderTree/LayoutTestController.h:
2376         (LayoutTestController):
2377         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2378         (LayoutTestController::sendWebIntentResponse):
2379         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2380         (DumpRenderTreeChrome::currentIntentRequest):
2381         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2382         (DumpRenderTreeChrome::onFrameIntentNew):
2383         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2384         (DumpRenderTreeChrome):
2385         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2386         (LayoutTestController::sendWebIntentResponse):
2387         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2388         (LayoutTestController::sendWebIntentResponse):
2389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2390         (LayoutTestController::sendWebIntentResponse):
2391         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2392         (LayoutTestController::sendWebIntentResponse):
2393         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2394         (LayoutTestController::sendWebIntentResponse):
2395
2396 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2397
2398         [EFL] The EFL port has no support for title directionality
2399         https://bugs.webkit.org/show_bug.cgi?id=86462
2400
2401         Reviewed by Gustavo Noronha Silva.
2402
2403         Update "title,changed" signal handlers in DRT and EWebLauncher to
2404         reflect the change from const char* to Ewk_Text_With_Direction* type
2405         for the title.
2406
2407         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2408         (DumpRenderTreeChrome::onTitleChanged):
2409         * EWebLauncher/main.c:
2410         (title_set):
2411         (on_title_changed):
2412         (on_key_down):
2413
2414 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2415
2416         Change EFL debug build name with more detail one
2417         https://bugs.webkit.org/show_bug.cgi?id=87254
2418
2419         Reviewed by Ryosuke Niwa.
2420
2421         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2422         In addition, remove efl-linux-debug triggerable since nobody uses it.
2423
2424         * BuildSlaveSupport/build.webkit.org-config/config.json:
2425
2426 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2427
2428         [EFL][DRT] Fix WebCore library path and rebaseline result
2429         https://bugs.webkit.org/show_bug.cgi?id=86355
2430
2431         Reviewed by Dirk Pranke.
2432
2433         Currently EFL DRT uses wrong WebCore library path when running DRT.
2434         Therefore, this patch adjusted the path correctly.
2435
2436         * Scripts/webkitpy/layout_tests/port/efl.py:
2437         (EflPort._path_to_webcore_library):
2438
2439 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2440
2441         add back the ability to disable flexbox
2442         https://bugs.webkit.org/show_bug.cgi?id=87147
2443
2444         Reviewed by Tony Chang.
2445
2446         * Scripts/webkitperl/FeatureList.pm:
2447
2448 2012-05-23  Tony Chang  <tony@chromium.org>
2449
2450         Remove the Chromium Grid Layout bot from the waterfall
2451         https://bugs.webkit.org/show_bug.cgi?id=87311
2452
2453         Reviewed by Ryosuke Niwa.
2454
2455         I removed the compiler define in r117613, so we don't need a separate
2456         bot to compile/test this code.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/config.json:
2459
2460 2012-05-23  Ian Vollick  <vollick@chromium.org>
2461
2462         Add vollick to list of contributors.
2463         https://bugs.webkit.org/show_bug.cgi?id=87305
2464
2465         Reviewed by Adam Barth.
2466
2467         * Scripts/webkitpy/common/config/committers.py:
2468
2469 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2470
2471         [Chromium-Android] Fix chromium_android_unittest
2472         https://bugs.webkit.org/show_bug.cgi?id=87196
2473
2474         Reviewed by Tony Chang.
2475
2476         Update unit tests after ChromiumAndroidPort supported apk based
2477         DumpRenderTree.
2478
2479         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2480         (ChromiumAndroidPortTest):
2481         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2482         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2483         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2484         (ChromiumAndroidDriverTest):
2485         (ChromiumAndroidDriverTest.setUp):
2486         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2487         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2488
2489 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2490
2491         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2492         https://bugs.webkit.org/show_bug.cgi?id=87303
2493
2494         Reviewed by Alexis Menard.
2495
2496         * Scripts/webkitpy/common/config/watchlist:
2497
2498 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2499
2500         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2501         https://bugs.webkit.org/show_bug.cgi?id=86916
2502
2503         Reviewed by Adam Barth.
2504
2505         This change pushes all of the logic for rebaselining a cluster
2506         of failures (a list of tests failing a list of suffixes on a
2507         list of bots) onto the server, so there is a single call from
2508         the web page; we will then be able to optimize the performance
2509         of the rebaselining better.
2510
2511         Also remove the 'optimizebaseline' entry point on garden-o-matic
2512         (and the client-side call) since we don't need it any more.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2516         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2517         (GardeningHTTPRequestHandler.rebaselineall):
2518         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2519
2520 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2521
2522         Mac DRT should be able to load external URLs for replay performance tests
2523         https://bugs.webkit.org/show_bug.cgi?id=86191
2524
2525         Reviewed by Alexey Proskuryakov.
2526
2527         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2528         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2529         "DumpRenderTree http://localhost:8000/".
2530
2531         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2532         (isLocalhost):
2533         (hostIsUsedBySomeTestsToGenerateError):
2534         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2535
2536 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2537
2538         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2539         debug symbols for easier debugging.
2540         https://bugs.webkit.org/show_bug.cgi?id=87151
2541
2542         Reviewed by Kevin Ollivier.
2543
2544         * waf/build/settings.py:
2545         (common_configure):
2546
2547 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2548
2549         Unreviewed. Move myself to reviewers.
2550
2551         * Scripts/webkitpy/common/config/committers.py:
2552
2553 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2554
2555         [EFL] Implements the registerProtocolHandler method and option.
2556         https://bugs.webkit.org/show_bug.cgi?id=73638
2557
2558         Reviewed by Andreas Kling.
2559
2560         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2561
2562 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2563
2564         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2565         https://bugs.webkit.org/show_bug.cgi?id=87221
2566
2567         Reviewed by Martin Robinson.
2568
2569         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2570         rightShift key names into proper GDK key symbols.
2571
2572         * DumpRenderTree/gtk/EventSender.cpp:
2573         (createKeyPressEvent):
2574
2575 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2576
2577         [Qt] Make the web view's url property follow the active url
2578
2579         https://bugs.webkit.org/show_bug.cgi?id=77554
2580
2581         Update  the location bar in the minibrowser to behave
2582         a bit more like normal browsers in terms of when the url will change
2583         and how active focus is handled.
2584
2585         Reviewed by Simon Hausmann.
2586
2587         * MiniBrowser/qt/qml/BrowserWindow.qml:
2588
2589 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2590
2591         [Qt] Remove references to $$QT_SOURCE_TREE
2592
2593         With a modularized Qt, it's ambigious. What we really want is qtbase,
2594         which qtcore is a proxy for (we assume it will always live in qtbase).
2595
2596         Reviewed by Tor Arne Vestbø.
2597
2598         * DumpRenderTree/qt/DumpRenderTree.pro:
2599
2600 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2601
2602         [Qt] Fix qmake conditional for c++-11 compat warnings
2603
2604         Reviewed by Tor Arne Vestbø.
2605
2606         * qmake/mkspecs/features/unix/default_post.prf:
2607
2608 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2609
2610         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2611         https://bugs.webkit.org/show_bug.cgi?id=85956
2612
2613         Reviewed by Gustavo Noronha Silva.
2614
2615         Catch new "load,provisional,failed" signal and print
2616         didFailProvisionalLoadWithError messages when LayoutTestController's
2617         dumpFrameLoadCallbacks() returns true. Also make sure the
2618         didFailLoadWithError message is not printed in case of provisional
2619         load failure.
2620
2621         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2622         (DumpRenderTreeChrome::createView):
2623         (DumpRenderTreeChrome::onFrameCreated):
2624         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2625         (DumpRenderTreeChrome::onFrameLoadError):
2626         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2627         (DumpRenderTreeChrome):
2628
2629 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2630
2631         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2632         https://bugs.webkit.org/show_bug.cgi?id=86366
2633
2634         Reviewed by Antonio Gomes.
2635
2636         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2637
2638         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2639         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2640
2641 2012-05-22  Darin Adler  <darin@apple.com>
2642
2643         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2644         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2645
2646 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2647
2648         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2649         https://bugs.webkit.org/show_bug.cgi?id=86922
2650
2651         Because we have new platformInit() in TestShellAndroid.cpp, and
2652         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2653         is split into TestShellPosix.cpp and TestShellX11.cpp.
2654
2655         Reviewed by Kent Tamura.
2656
2657         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2658         * DumpRenderTree/DumpRenderTree.gypi:
2659         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2660         (platformInit):
2661         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2662         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2663         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2664         (AlarmHandler):
2665         (TestShell::waitTestFinished):
2666         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2667         (openStartupDialog): from TestShellGtk.cpp
2668         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2669         (setupFontconfig):
2670         (platformInit):
2671
2672 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2673
2674         [EFL][DRT] Implement touch event
2675         https://bugs.webkit.org/show_bug.cgi?id=86720
2676
2677         Reviewed by Hajime Morita.
2678
2679         Currently EFL DRT doesn't support touch event.
2680         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2681
2682         * DumpRenderTree/efl/EventSender.cpp:
2683         (TouchEventInfo::TouchEventInfo):
2684         (TouchEventInfo):
2685         (touchPointList):
2686         (sendTouchEvent):
2687         (addTouchPointCallback):
2688         (touchStartCallback):
2689         (updateTouchPointCallback):
2690         (touchMoveCallback):
2691         (cancelTouchPointCallback):
2692         (touchCancelCallback):
2693         (releaseTouchPointCallback):
2694         (touchEndCallback):
2695         (clearTouchPointsCallback):
2696         (setTouchModifierCallback):
2697         * Scripts/webkitperl/FeatureList.pm:
2698
2699 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2700
2701         [Chromium-Android] Fix chromium_android_unittest
2702         https://bugs.webkit.org/show_bug.cgi?id=87196
2703
2704         Not reviewed.
2705         Temporarily disable chromium_android_unittest.
2706
2707         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2708         (ChromiumAndroidPortTest):
2709         (ChromiumAndroidDriverTest):
2710
2711 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2712
2713         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2714         https://bugs.webkit.org/show_bug.cgi?id=64313
2715
2716         Reviewed by Jon Honeycutt.
2717
2718         Add it.
2719
2720         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2721         Make sure to generate the binding.
2722
2723         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2724         (WTR::LayoutTestController::setDefersLoading):
2725         Call WKBundlePageSetDefersLoading.
2726         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2727
2728 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2729
2730         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2731         https://bugs.webkit.org/show_bug.cgi?id=86923
2732
2733         chromium_android.py is modified to support running DumpRenderTree as
2734         an apk, so that we can run the tests (e.g. video) requiring features
2735         implemented in Java on Android.
2736
2737         Reviewed by Adam Barth.
2738
2739         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2740         (ChromiumAndroidPort.__init__):
2741         (ChromiumAndroidPort.default_child_processes):
2742         (ChromiumAndroidPort.check_wdiff):
2743         (ChromiumAndroidPort.check_build):
2744         (ChromiumAndroidPort.start_helper):
2745         (ChromiumAndroidPort.skipped_layout_tests):
2746         (ChromiumAndroidPort):
2747         (ChromiumAndroidPort._path_to_driver):
2748         (ChromiumAndroidPort._get_crash_log):
2749         (ChromiumAndroidPort._push_executable):
2750         (ChromiumAndroidPort._run_adb_command):
2751         (ChromiumAndroidPort._get_last_stacktrace):
2752         (ChromiumAndroidPort._get_logcat):
2753         (ChromiumAndroidPort._setup_performance):
2754         (ChromiumAndroidDriver):
2755         (ChromiumAndroidDriver.__init__):
2756         (ChromiumAndroidDriver._command_wrapper):
2757         (ChromiumAndroidDriver.cmd_line):
2758         (ChromiumAndroidDriver._file_exists_on_device):
2759         (ChromiumAndroidDriver._deadlock_detector):
2760         (ChromiumAndroidDriver._start):
2761         (ChromiumAndroidDriver.run_test):
2762         (ChromiumAndroidDriver.stop):
2763         (ChromiumAndroidDriver._write_command_and_read_line):
2764         (ChromiumAndroidDriver._output_image):
2765         (ChromiumAndroidDriver._get_stderr):
2766
2767 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2768
2769         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2770
2771         Unreviewed gardening.
2772
2773         * Scripts/webkitpy/layout_tests/port/base.py:
2774         (Port.driver_name):
2775         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2776         (ChromiumLinuxPort._path_to_driver):
2777         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2778         (ChromiumPortTest.test_overrides_and_builder_names):
2779         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2780         (ChromiumWinPort._path_to_driver):
2781         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2782         (parse_args):
2783
2784 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2785
2786         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2787         https://bugs.webkit.org/show_bug.cgi?id=87176
2788
2789         Reviewed by Tony Chang.
2790
2791         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2792         * DumpRenderTree/DumpRenderTree.gypi:
2793
2794 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2795
2796         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2797         https://bugs.webkit.org/show_bug.cgi?id=87128
2798
2799         Reviewed by Dirk Pranke.
2800
2801         * Scripts/webkitpy/layout_tests/port/base.py:
2802         (Port.driver_name):
2803         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2804         (ChromiumLinuxPort._path_to_driver):
2805         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2806         (ChromiumPortTest.test_driver_name_option):
2807         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2808         (ChromiumWinPort._path_to_driver):
2809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2810         (parse_args):
2811
2812 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2813
2814         WTR fix after r118001.
2815
2816         Rubber-stamped by Alexey Proskuryakov.
2817
2818         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2819
2820         * WebKitTestRunner/mac/EventSenderProxy.mm:
2821         (WTR::EventSenderProxy::keyDown):
2822
2823 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2824
2825         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2826         https://bugs.webkit.org/show_bug.cgi?id=86684
2827
2828         Reviewed by Darin Fisher.
2829
2830         * DumpRenderTree/chromium/LayoutTestController.cpp:
2831         (LayoutTestController::numberOfPages):
2832         * DumpRenderTree/chromium/WebViewHost.cpp:
2833         (WebViewHost::printPage):
2834
2835 == Rolled over to ChangeLog-2012-05-22 ==