Remove empty directories from from svn.webkit.org repository
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-29  David Kilzer  <ddkilzer@apple.com>
2
3         Remove empty directories from from svn.webkit.org repository
4         <https://webkit.org/b/189081>
5
6         * DumpRenderTree/TestNetscapePlugIn/unix: Removed.
7         * WebKitTestRunner/UIScriptContext: Removed.
8
9 2018-08-29  Pablo Saavedra  <psaavedra@igalia.com>
10
11         [GTK][WPE] Add JSCOnly Release bot for Linux ARMv7 Thumb2 SoftFP
12         https://bugs.webkit.org/show_bug.cgi?id=189077
13
14         Reviewed by Michael Catanzaro.
15
16         Deployed new bot for WPE Release in Linux ARMv7 Thumb2 SoftFP
17         This bot (jsconly-linux-igalia-bot-5) will run the 'JSCOnly
18         Linux ARMv7 Thumb2 SoftFP Release' buildjob.
19
20         * BuildSlaveSupport/build.webkit.org-config/config.json:
21         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
22
23 2018-08-28  Daniel Bates  <dabates@apple.com>
24
25         lldb-webkit: KeyError thrown for OptionSet
26         https://bugs.webkit.org/show_bug.cgi?id=189062
27
28         Reviewed by Simon Fraser.
29
30         For some reason lldb(1) may not retrieve the enumerator names for an enum value
31         when it calls update() on the synthetic children provider. If this occurs then
32         bail out as we cannot compute what enumerators are in the set.
33
34         * lldb/lldb_webkit.py:
35         (WTFOptionSetProvider.update):
36
37 2018-08-28  Sihui Liu  <sihui_liu@apple.com>
38
39         Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
40         https://bugs.webkit.org/show_bug.cgi?id=189037
41
42         Reviewed by Chris Dumez.
43
44         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
45         (TEST):
46
47 2018-08-28  David Kilzer  <ddkilzer@apple.com>
48
49         Fix incorrect use of `sourceTree = "<group>";` for built products and frameworks in Xcode projects
50
51         Found by tidy-Xcode-project-file script (see Bug 188754).
52
53         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
54         (IOKit.framework): Use `sourceTree = "<absolute>";` to match
55         other frameworks in the project.
56         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
57         (WebKit.framework): Use `sourceTree = BUILT_PRODUCTS_DIR;` for
58         built product instead of relative build directory path.
59         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
60         (JavaScriptCore.framework): Ditto.
61         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
62         (libWTF.a): Use `sourceTree = BUILT_PRODUCTS_DIR;` for built
63         product.
64
65 2018-08-28  Alex Christensen  <achristensen@webkit.org>
66
67         Fix 32-bit Mac build.
68
69         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
70
71 2018-08-28  Alex Christensen  <achristensen@webkit.org>
72
73         REGRESSION (r235391): [iOS] TestWebKitAPI.WebKit.RestoreSessionStateWithoutNavigation is timing out
74         https://bugs.webkit.org/show_bug.cgi?id=189050
75
76         Reviewed by Tim Horton.
77
78         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
79         This test wasn't run on iOS before.  Let's re-introduce the WK_HAVE_C_SPI guard.
80
81 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         [iOS] WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging encounters an exception on iOS simulator
84         https://bugs.webkit.org/show_bug.cgi?id=189049
85
86         Reviewed by Tim Horton.
87
88         Wrap an NSURL in a RetainPtr to prevent it from being freed prematurely. It seems this broke when I changed the
89         load handler from an Objective-C block that captured `folderURL` to a C++ lambda that didn't retain `folderURL`.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
92         (simulateFolderDragWithURL):
93
94 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
95
96         [Attachment Support] Remove WebCore::AttachmentDisplayOptions and friends
97         https://bugs.webkit.org/show_bug.cgi?id=189004
98
99         Reviewed by Dan Bernstein.
100
101         Move off of deprecated attachment insertion SPI.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
104         (-[TestWKWebView synchronouslyInsertAttachmentWithFileWrapper:contentType:]):
105         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
106         (-[_WKAttachment synchronouslySetDisplayOptions:error:]): Deleted.
107
108 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
109
110         Teach WebKitTestRunner and DumpRenderTree about detecting world leaks
111         https://bugs.webkit.org/show_bug.cgi?id=188994
112
113         Reviewed by Tim Horton.
114         
115         This patch adds the notion of a "control command" in the protocol between webkitpy and 
116         WebKitTestRunner/DumpRenderTree. A command is simply an input string starting with a #
117         that is checked for before trying to parse the input as test URL. For now, just one
118         commmand is supported, which is "#CHECK FOR WORLD LEAKS".
119         
120         In response to the command, the tool dumps an output block in the usual pseudo-MIME-style,
121         with a trailing "#EOF". Future patches will add support to webkitpy to parse this output.
122         
123         DumpRenderTree stubs out the command, returning an empty block.
124         
125         WebKitTestRunner responds to the command by dumping the list of live documents, if it was
126         run with the --check-for-world-leaks option.
127         
128         When run with --check-for-world-leaks, WebKitTestRunner gets the list of live documents via
129         WKBundleGetLiveDocumentURLs() after every test (this allows it to detect the first test
130         that leaked a document), and keeps them in a map of document identifier to test and live document URL.
131         Then when it receives the "#CHECK FOR WORLD LEAKS" command, it calls into the bundle to
132         clear the page and memory caches, runs a GC, then posts a task (in the Document::postTaks() sense)
133         after which it requests the list of live documents for a final time, excluding any that are loaded
134         in live Frames (thus omitting the about:blank that will be loaded at this point). Documents in this
135         list are therefore leaked (or abandoned).
136         
137         Future patches will hook up webkitpy reporting for leaked documents.
138
139         * DumpRenderTree/mac/DumpRenderTree.mm:
140         (initializeGlobalsFromCommandLineOptions):
141         (handleControlCommand):
142         (runTestingServerLoop):
143         * DumpRenderTree/win/DumpRenderTree.cpp:
144         (handleControlCommand):
145         (main):
146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
147         (WTR::postGCTask):
148         (WTR::InjectedBundle::reportLiveDocuments):
149         (WTR::InjectedBundle::didReceiveMessageToPage):
150         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
151         * WebKitTestRunner/Options.cpp:
152         (WTR::handleOptionCheckForWorldLeaks):
153         (WTR::OptionsHandler::OptionsHandler):
154         * WebKitTestRunner/Options.h:
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::AsyncTask::run):
157         (WTR::AsyncTask::currentTask):
158         (WTR::TestController::initialize):
159         (WTR::TestController::ensureViewSupportsOptionsForTest):
160         (WTR::TestController::resetStateToConsistentValues):
161         (WTR::TestController::updateLiveDocumentsAfterTest):
162         (WTR::TestController::checkForWorldLeaks):
163         (WTR::TestController::findAndDumpWorldLeaks):
164         (WTR::TestController::willDestroyWebView):
165         (WTR::parseInputLine):
166         (WTR::TestController::waitForCompletion):
167         (WTR::TestController::handleControlCommand):
168         (WTR::TestController::runTestingServerLoop):
169         (WTR::TestController::run):
170         (WTR::TestController::didReceiveLiveDocumentsList):
171         (WTR::TestController::didReceiveMessageFromInjectedBundle):
172         * WebKitTestRunner/TestController.h:
173         (WTR::AsyncTask::AsyncTask):
174         (WTR::AsyncTask::taskComplete):
175         (WTR::TestController::AbandonedDocumentInfo::AbandonedDocumentInfo):
176         * WebKitTestRunner/TestInvocation.cpp:
177         (WTR::TestInvocation::invoke):
178         * WebKitTestRunner/TestOptions.h:
179         (WTR::TestOptions::hasSameInitializationOptions const):
180
181 2018-08-27  Alex Christensen  <achristensen@webkit.org>
182
183         Fix API test after r235398
184         https://bugs.webkit.org/show_bug.cgi?id=188997
185
186         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
187         (TestWebKitAPI::setPageLoaderClient):
188         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
189         willGoToBackForwardListItem is unused and unsupported.  Removing its check.
190
191 2018-08-27  Daniel Bates  <dabates@apple.com>
192
193         Partial revert of r235376
194         https://bugs.webkit.org/show_bug.cgi?id=189011
195
196         For now revert the unit tests added in r235376 as the following tests are failing on Apple Sierra
197         Debug and Apple High Sierra Debug bots:
198
199             lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_simple
200             lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple
201
202         Will investigate offline.
203
204         * lldb/lldbWebKitTester/main.cpp:
205         (testSummaryProviders):
206         * lldb/lldb_webkit_unittest.py:
207         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
208         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty): Deleted.
209         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple): Deleted.
210         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Deleted.
211         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple): Deleted.
212
213 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
214
215         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
216         https://bugs.webkit.org/show_bug.cgi?id=188931
217
218         Reviewed by Wenson Hsieh.
219
220         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
221
222 2018-08-27  Justin Fan  <justin_fan@apple.com>
223
224         Add Justin Fan to list of WebKit contributors
225         https://bugs.webkit.org/show_bug.cgi?id=184431
226
227         * Scripts/webkitpy/common/config/contributors.json:
228
229 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
230
231         Convert timeout values in WebKitTestRunner to WTF::Seconds
232         https://bugs.webkit.org/show_bug.cgi?id=188987
233
234         Reviewed by Ryosuke Niwa.
235         
236         Replace various 'int' timeout values with WTF::Seconds. The timeout argument
237         comes in as milliseconds, so convert on input. When sending messages to the InjectedBundle
238         using integers, convert to and from milliseconds.
239         
240         Also do some #pragma once, and initializer cleanup.
241
242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
243         (WTR::InjectedBundle::didReceiveMessageToPage):
244         (WTR::InjectedBundle::beginTesting):
245         (WTR::InjectedBundle::InjectedBundle): Deleted.
246         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
247         * WebKitTestRunner/InjectedBundle/TestRunner.h:
248         (WTR::TestRunner::timeout):
249         (WTR::TestRunner::setCustomTimeout):
250         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
251         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
252         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
253         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
254         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
255         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
256         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
257         * WebKitTestRunner/TestController.cpp:
258         (WTR::TestController::TestController):
259         (WTR::parseInputLine):
260         (WTR::TestController::runTest):
261         (WTR::TestController::runUntil):
262         (WTR::TestController::didReceiveMessageFromInjectedBundle):
263         * WebKitTestRunner/TestController.h:
264         * WebKitTestRunner/TestInvocation.cpp:
265         (WTR::TestInvocation::shortTimeout const):
266         (WTR::TestInvocation::createTestSettingsDictionary):
267         * WebKitTestRunner/TestInvocation.h:
268         * WebKitTestRunner/TestOptions.h:
269         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
270         (WTR::TestController::platformRunUntil):
271         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
272         (WTR::TestController::platformRunUntil):
273         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
274         (WTR::TestController::platformRunUntil):
275
276 2018-08-27  Simon Fraser  <simon.fraser@apple.com>
277
278         Convert timeout values in WebKitTestRunner to WTF::Seconds
279         https://bugs.webkit.org/show_bug.cgi?id=188987
280
281         Reviewed by Ryosuke Niwa.
282         
283         Replace various 'int' timeout values with WTF::Seconds. The timeout argument
284         comes in as milliseconds, so convert on input. When sending messages to the InjectedBundle
285         using integers, convert to and from milliseconds.
286         
287         Also do some #pragma once, and initializer cleanup.
288
289         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
290         (WTR::InjectedBundle::didReceiveMessageToPage):
291         (WTR::InjectedBundle::beginTesting):
292         (WTR::InjectedBundle::InjectedBundle): Deleted.
293         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
294         * WebKitTestRunner/InjectedBundle/TestRunner.h:
295         (WTR::TestRunner::timeout):
296         (WTR::TestRunner::setCustomTimeout):
297         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
298         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
299         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
300         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
301         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
302         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
303         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
304         * WebKitTestRunner/TestController.cpp:
305         (WTR::TestController::TestController):
306         (WTR::parseInputLine):
307         (WTR::TestController::runTest):
308         (WTR::TestController::runUntil):
309         (WTR::TestController::didReceiveMessageFromInjectedBundle):
310         * WebKitTestRunner/TestController.h:
311         * WebKitTestRunner/TestInvocation.cpp:
312         (WTR::TestInvocation::shortTimeout const):
313         (WTR::TestInvocation::createTestSettingsDictionary):
314         * WebKitTestRunner/TestInvocation.h:
315         * WebKitTestRunner/TestOptions.h:
316         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
317         (WTR::TestController::platformRunUntil):
318         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
319         (WTR::TestController::platformRunUntil):
320         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
321         (WTR::TestController::platformRunUntil):
322
323 2018-08-27  Alex Christensen  <achristensen@webkit.org>
324
325         REGRESSION(r234985/r234989) WKPageLoadHTMLString with a 16-bit String has the wrong encoding
326         https://bugs.webkit.org/show_bug.cgi?id=189002
327
328         Reviewed by Tim Horton.
329
330         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
331         (TestWebKitAPI::TEST_F):
332
333 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
334
335         [Cocoa] Exception (fileType 'dyn.agq8u' is not a valid UTI) raised when dragging an attachment whose file wrapper is a directory
336         https://bugs.webkit.org/show_bug.cgi?id=188903
337         <rdar://problem/43702993>
338
339         Reviewed by Tim Horton.
340
341         Add two API tests and adjust existing WKAttachment API tests. The new tests exercise the following scenarios, in
342         both iOS and macOS:
343         •       Dropping a folder as an attachment element, and then moving that attachment element in the document by
344                 dragging and dropping.
345         •       Using WKWebView SPI to insert a folder and a file with an unknown extension, and then using more
346                 _WKAttachment SPI to swap the attachments' backing file wrappers.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
349         (runTestWithTemporaryFolder):
350
351         Add a helper function to run a test with a new folder path, created in the temporary directory and populated
352         with some sample content. This folder is deleted after running the test.
353
354         (simulateFolderDragWithURL):
355
356         Add a helper function to prepare a given DragAndDropSimulator for simulating a dragged folder from a source
357         external to the web view.
358
359         (platformCopyRichTextWithMultipleAttachments):
360         (platformCopyRichTextWithImage):
361         (platformCopyPNG):
362         (TestWebKitAPI::TEST):
363
364         Add new API tests, and adjust existing tests to reflect new -setFileWrapper:…: behavior. Specifically,
365         ChangeAttachmentDataAndFileInformation previously required that changing a _WKAttachment's NSFileWrapper would
366         preserve the previous NSFileWrapper's preferred name if the new file wrapper does not have a preferred name, but
367         this quirk is no longer supported.
368
369         Also add a few bridging casts for the eventual transition of TestWebKitAPI to ARC.
370
371         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
372
373         Add a new hook to clear any external drag information on an existing DragAndDropSimulator. This is convenient
374         when using the same DragAndDropSimulator to perform multiple drags in a single test.
375
376         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
377         (-[DragAndDropSimulator clearExternalDragInformation]):
378         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
379         (-[DragAndDropSimulator clearExternalDragInformation]):
380
381 2018-08-27  Alex Christensen  <achristensen@webkit.org>
382
383         Translate 4 tests using WKPageLoaderClient to ObjC
384         https://bugs.webkit.org/show_bug.cgi?id=188827
385
386         Reviewed by Tim Horton.
387
388         They use processDidBecomeUnresponsive, didChangeBackForwardList, or willGoToBackForwardListItem.
389         Rather than introduce these to WKPageNavigationClient, I just translated the tests to use WKNavigationDelegate, which already have equivalent callbacks.
390         willGoToBackForwardListItem had userData from the InjectedBundle, but nobody was using it so I did not add that to the ObjC SPI, so I don't test that unused
391         bundle functionality any more.
392
393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
394         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp: Removed.
395         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
396         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp: Removed.
397         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp: Removed.
398         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
399         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp.
400         (-[ResponsivenessTimerDelegate webView:didFinishNavigation:]):
401         (-[ResponsivenessTimerDelegate _webViewWebProcessDidBecomeUnresponsive:]):
402         (TestWebKitAPI::TEST):
403         (): Deleted.
404         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
405         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
406         (TestWebKitAPI::setPageLoaderClient): Deleted.
407         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp.
408         (-[ResponsivenessDelegate webView:didFinishNavigation:]):
409         (-[ResponsivenessDelegate _webViewWebProcessDidBecomeUnresponsive:]):
410         (TestWebKitAPI::TEST):
411         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Deleted.
412         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
413         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
414         (TestWebKitAPI::setInjectedBundleClient): Deleted.
415         (TestWebKitAPI::setPageLoaderClient): Deleted.
416         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp.
417         (-[SessionStateDelegate webView:didFinishNavigation:]):
418         (-[SessionStateDelegate _webView:backForwardListItemAdded:removed:]):
419         (TestWebKitAPI::createSessionStateData):
420         (TestWebKitAPI::TEST):
421         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
422         (TestWebKitAPI::didChangeBackForwardListForPage): Deleted.
423         (TestWebKitAPI::setPageLoaderClient): Deleted.
424         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp.
425         (-[BackForwardClient webView:didFinishNavigation:]):
426         (-[BackForwardClient _webView:willGoToBackForwardListItem:inPageCache:]):
427         (TestWebKitAPI::TEST):
428         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
429         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
430         (TestWebKitAPI::setPageLoaderClient): Deleted.
431
432 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
433
434         [Cocoa] "video.html" appears at the top level of the TestWebKitAPI Xcode project
435         https://bugs.webkit.org/show_bug.cgi?id=188989
436
437         Reviewed by Andy Estes.
438
439         Move this into the Tests/WebKit/Resources group in the project.
440
441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
442
443 2018-08-27  Thomas Denney  <tdenney@apple.com>
444
445         Avoid an exception in the interactive interpreter
446         https://bugs.webkit.org/show_bug.cgi?id=188991
447
448         Reviewed by Myles C. Maxfield.
449
450         * WebGPUShadingLanguageRI/index.html: Corrects a typo in the name of a
451         local variable
452
453 2018-08-27  Thomas Denney  <tdenney@apple.com>
454
455         Allow new vector types to work with the interactive interpreter
456         https://bugs.webkit.org/show_bug.cgi?id=188988
457
458         Reviewed by Myles C. Maxfield.
459
460         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
461         (FlattenedStructOffsetGatherer.prototype.visitTypeRef): Do not
462         unncessarily visit the type arguments of a TypeRef, as by this point
463         there are none that are relevant.
464         * WebGPUShadingLanguageRI/Intrinsics.js:
465         (Intrinsics): Treat VectorType as a primitive type.
466
467 2018-08-27  Keith Rollin  <krollin@apple.com>
468
469         Build system support for LTO
470         https://bugs.webkit.org/show_bug.cgi?id=187785
471         <rdar://problem/42353132>
472
473         Reviewed by Dan Bernstein.
474
475         Add tools/scripts support for controlling LTO builds.
476
477         * Scripts/build-webkit: Add --lto-mode={none,thin,full}.
478         * Scripts/set-webkit-configuration: Add support for saving LTO
479         configuration to WebKitBuild/LTO.
480         * Scripts/webkitdirs.pm: Add support for reading configuration from
481         WebKitBuild/LTO and providing it to xcodebuild.
482         (determineLTOMode):
483         (ltoMode):
484         (XcodeOptions):
485
486 2018-08-27  Daniel Bates  <dabates@apple.com>
487
488         lldb-webkit: Pretty-print OptionSet
489         https://bugs.webkit.org/show_bug.cgi?id=188936
490
491         Reviewed by Simon Fraser.
492
493         Add LLDB formatters to pretty-print an OptionSet.
494
495         * lldb/lldbWebKitTester/main.cpp:
496         (testSummaryProviders):
497         * lldb/lldb_webkit.py:
498         (__lldb_init_module):
499         (__lldb_init_module.lldb_webkit):
500         (WTFOptionSet_SummaryProvider):
501         (WTFOptionSetProvider):
502         (WTFOptionSetProvider.__init__):
503         (WTFOptionSetProvider.has_children):
504         (WTFOptionSetProvider.num_children):
505         (WTFOptionSetProvider.get_child_index):
506         (WTFOptionSetProvider.get_child_at_index):
507         (WTFOptionSetProvider.update):
508         * lldb/lldb_webkit_unittest.py:
509         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
510         (TestSummaryProviders):
511         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
512         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
513         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
514         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
515
516 2018-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
517
518         [Attachment Support] [WK2] Images copied from Mail message view paste with the wrong file name in compose
519         https://bugs.webkit.org/show_bug.cgi?id=188957
520         <rdar://problem/43737715>
521
522         Reviewed by Darin Adler.
523
524         Add a new API test to verify that pasting a web archive containing several image elements with alt attributes
525         generates _WKAttachments whose names reflect those alt attributes.
526
527         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
528         (testGIFFileURL):
529         (testGIFData):
530         (TestWebKitAPI::TEST):
531
532 2018-08-27  Alex Christensen  <achristensen@webkit.org>
533
534         Unreviewed, rolling out r235367.
535
536         Broke iOS build.
537
538         Reverted changeset:
539
540         "Translate 4 tests using WKPageLoaderClient to ObjC"
541         https://bugs.webkit.org/show_bug.cgi?id=188827
542         https://trac.webkit.org/changeset/235367
543
544 2018-08-27  Alex Christensen  <achristensen@webkit.org>
545
546         Fix GTK build.
547
548         * TestWebKitAPI/CMakeLists.txt:
549
550 2018-08-27  Alex Christensen  <achristensen@webkit.org>
551
552         Fix iOS build.
553
554         * TestWebKitAPI/PlatformWebView.h:
555
556 2018-08-27  Alex Christensen  <achristensen@webkit.org>
557
558         Translate 4 tests using WKPageLoaderClient to ObjC
559         https://bugs.webkit.org/show_bug.cgi?id=188827
560
561         Reviewed by Tim Horton.
562
563         They use processDidBecomeUnresponsive, didChangeBackForwardList, or willGoToBackForwardListItem.
564         Rather than introduce these to WKPageNavigationClient, I just translated the tests to use WKNavigationDelegate, which already have equivalent callbacks.
565         willGoToBackForwardListItem had userData from the InjectedBundle, but nobody was using it so I did not add that to the ObjC SPI, so I don't test that unused
566         bundle functionality any more.
567
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp: Removed.
570         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
571         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp: Removed.
572         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp: Removed.
573         * TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
574         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimer.cpp.
575         (-[ResponsivenessTimerDelegate webView:didFinishNavigation:]):
576         (-[ResponsivenessTimerDelegate _webViewWebProcessDidBecomeUnresponsive:]):
577         (TestWebKitAPI::TEST):
578         (): Deleted.
579         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
580         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
581         (TestWebKitAPI::setPageLoaderClient): Deleted.
582         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ResponsivenessTimerDoesntFireEarly.cpp.
583         (-[ResponsivenessDelegate webView:didFinishNavigation:]):
584         (-[ResponsivenessDelegate _webViewWebProcessDidBecomeUnresponsive:]):
585         (TestWebKitAPI::TEST):
586         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Deleted.
587         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
588         (TestWebKitAPI::processDidBecomeUnresponsive): Deleted.
589         (TestWebKitAPI::setInjectedBundleClient): Deleted.
590         (TestWebKitAPI::setPageLoaderClient): Deleted.
591         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/RestoreSessionStateWithoutNavigation.cpp.
592         (-[SessionStateDelegate webView:didFinishNavigation:]):
593         (-[SessionStateDelegate _webView:backForwardListItemAdded:removed:]):
594         (TestWebKitAPI::createSessionStateData):
595         (TestWebKitAPI::TEST):
596         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
597         (TestWebKitAPI::didChangeBackForwardListForPage): Deleted.
598         (TestWebKitAPI::setPageLoaderClient): Deleted.
599         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit/ShouldGoToBackForwardListItem.cpp.
600         (-[BackForwardClient webView:didFinishNavigation:]):
601         (-[BackForwardClient _webView:willGoToBackForwardListItem:inPageCache:]):
602         (TestWebKitAPI::TEST):
603         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
604         (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
605         (TestWebKitAPI::setPageLoaderClient): Deleted.
606
607 2018-08-27  Keith Miller  <keith_miller@apple.com>
608
609         test262-runner -s --test-only should replace test results
610         https://bugs.webkit.org/show_bug.cgi?id=188450
611
612         Reviewed by Michael Saboff.
613
614         * Scripts/test262/Runner.pm:
615         (main):
616         (SetFailureForTest):
617         (UpdateResults):
618
619 2018-08-26  Sam Weinig  <sam@webkit.org>
620
621         Using _WKRemoteObjectInterface with a protocol that inherits from a non-NSObject protocol crashes
622         https://bugs.webkit.org/show_bug.cgi?id=188958
623
624         Reviewed by Anders Carlsson.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
627         Update test protocol to have inheritance.
628
629 2018-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
630
631         [Attachment Support] Dropping and pasting images should insert inline image elements with _WKAttachments
632         https://bugs.webkit.org/show_bug.cgi?id=188933
633         <rdar://problem/43699724>
634
635         Reviewed by Darin Adler.
636
637         Rebaseline existing API tests that involve dropping or pasting image files, and additionally write some new
638         tests. These new tests exercise the following cases:
639         •       Inserting and removing newlines before an inline image with an attachment element does not cause new
640                 _WKAttachments to be created and destroyed.
641         •       Pasting an image, cutting it, and then pasting it again propagates an attachment update to the UI
642                 process with the original _WKAttachment.
643         •       A pasted attachment in the document can be moved around by dragging, and doing so does not cause us to
644                 lose a _WKAttachment.
645
646         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
647         (-[TestWKWebView expectElementCount:tagName:]):
648         (TestWebKitAPI::TEST):
649
650         Add the new tests described above, and also adjust existing tests to check that images are dropped or pasted
651         as image elements, but still have associated attachment elements whose attachment identifiers (observed via
652         script) match that of the corresponding _WKAttachment's uniqueIdentifier in the UI process.
653
654         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
655         (-[DragAndDropSimulator runFrom:to:]):
656         (-[DragAndDropSimulator continueDragSession]):
657         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
658
659         Teach DragAndDropSimulator on macOS to wait until the drop has been handled by the web process before returning
660         execution to the caller. This ensures that tests which involve dropping promised files as attachments aren't
661         flaky, due to how the promised data is retrieved asynchronously when performing the drop.
662
663         (-[DragAndDropSimulator _webView:didPerformDragOperation:]):
664
665 2018-08-26  Lucas Forschler  <lforschler@apple.com>
666
667         Open svn.webkit.org for commits.
668
669 2018-08-24  Myles C. Maxfield  <mmaxfield@apple.com>
670
671         Unreviewed test fix after r235249
672         https://bugs.webkit.org/show_bug.cgi?id=178981
673
674         * WebGPUShadingLanguageRI/Test.js:
675
676 2018-08-24  Alex Christensen  <achristensen@webkit.org>
677
678         Introduce _WKInspector
679         https://bugs.webkit.org/show_bug.cgi?id=188923
680         <rdar://problem/34657861>
681
682         Reviewed by Brian Burg.
683
684         * MiniBrowser/mac/WK2BrowserWindowController.m:
685         (-[WK2BrowserWindowController validateMenuItem:]):
686         (-[WK2BrowserWindowController showHideWebInspector:]):
687
688 2018-08-24  Jonathan Bedard  <jbedard@apple.com>
689
690         Fix handling of iOS minor versions in default_baseline_search_path
691         https://bugs.webkit.org/show_bug.cgi?id=188902
692
693         Reviewed by Aakash Jain.
694
695         * Scripts/webkitpy/port/ios.py:
696         (IOSPort.default_baseline_search_path): When the major version matches the major version of the CURRENT_VERSION, treat
697         it as a the CURRENT_VERSION.
698
699 2018-08-24  Antti Koivisto  <antti@apple.com>
700
701         Allow creating WeakPtrs to const objects
702         https://bugs.webkit.org/show_bug.cgi?id=188785
703
704         Reviewed by Geoff Garen.
705
706         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
707         (TestWebKitAPI::Base::weakPtrFactory const):
708         (TestWebKitAPI::TEST):
709         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
710
711 2018-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
712
713         [GTK][WPE] Add API to inject/register user content in isolated worlds
714         https://bugs.webkit.org/show_bug.cgi?id=188883
715
716         Reviewed by Michael Catanzaro.
717
718         Add test cases for the new API.
719
720         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
721         (isStyleSheetInjectedForURLAtPath):
722         (isScriptInjectedForURLAtPath):
723         (testUserContentManagerInjectedStyleSheet):
724         (testUserContentManagerInjectedScript):
725         (UserScriptMessageTest::registerHandler):
726         (UserScriptMessageTest::unregisterHandler):
727         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
728         (testUserContentManagerScriptMessageInWorldReceived):
729         (beforeAll):
730
731 2018-08-23  Simon Fraser  <simon.fraser@apple.com>
732
733         Add support for dumping GC heap snapshots, and a viewer
734         https://bugs.webkit.org/show_bug.cgi?id=186416
735
736         Reviewed by Joseph Pecoraro.
737
738         Add a viewer for GC heap snapshots. A snapshot JSON file can be dragged into this
739         page for inspection (or set via the 'filename' URL parameter).
740
741         For now, this page shows all objects, all roots, and the shortest path from a root
742         to all HTMLDocuments and Windows.
743
744         * GCHeapInspector/gc-heap-inspector.html: Added.
745         * GCHeapInspector/heap-analysis/HeapSnapshot.js: Copied from Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshot.js.
746         * GCHeapInspector/script/interface.js: Added.
747
748 2018-08-23  Alex Christensen  <achristensen@webkit.org>
749
750         Add new _webViewRequestPointerLock SPI with a completionHandler
751         https://bugs.webkit.org/show_bug.cgi?id=188907
752         <rdar://problem/35871109>
753
754         Reviewed by Andy Estes.
755
756         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
757         (-[PointerLockDelegate _webViewRequestPointerLock:completionHandler:]):
758         (-[PointerLockDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
759         (TEST):
760
761 2018-08-23  David Fenton  <david_fenton@apple.com>
762
763         Unreviewed, rolling out r235129.
764
765         broke internal builds
766
767         Reverted changeset:
768
769         "Allow creating WeakPtrs to const objects"
770         https://bugs.webkit.org/show_bug.cgi?id=188785
771         https://trac.webkit.org/changeset/235129
772
773 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
774
775         API tests should output json results
776         https://bugs.webkit.org/show_bug.cgi?id=188869
777         <rdar://problem/43615652>
778
779         Reviewed by Aakash Jain.
780
781         JSON output for API tests is of the form:
782             {
783                 "Failed": [{"name": <test name>, "output": <test log>}],
784                 "Timedout": [...],
785                 "Skipped": [...],
786                 "Crashed": [...]
787             }
788         Tests which are successful are not displayed in the json output.
789
790         * Scripts/webkitpy/api_tests/manager.py:
791         (Manager.run): Print test results to provided file as a json dictionary.
792         * Scripts/webkitpy/api_tests/run_api_tests.py:
793         (run): Pass json option.
794         (parse_args): Add --json-output flag.
795
796 2018-08-23  Andy Estes  <aestes@apple.com>
797
798         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
799         https://bugs.webkit.org/show_bug.cgi?id=188829
800
801         Reviewed by Tim Horton.
802
803         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
804
805 2018-08-23  Myles C. Maxfield  <mmaxfield@apple.com>
806
807         [WSL] Ternary expressions appear to be unimplemented
808         https://bugs.webkit.org/show_bug.cgi?id=178981
809
810         Reviewed by Saam Barati.
811
812         Implement ternary statements. These can be both lvalues and rvalues. (a ? b : c ? d : e)
813         is parsed as (a ? b : (c ? d : e)).
814
815         * WebGPUShadingLanguageRI/All.js:
816         * WebGPUShadingLanguageRI/Checker.js:
817         (Checker.prototype.visitTernaryExpression):
818         * WebGPUShadingLanguageRI/Evaluator.js:
819         (Evaluator.prototype.visitTernaryExpression):
820         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js:
821         (NormalUsePropertyResolver.prototype.visitTernaryExpression):
822         (NormalUsePropertyResolver):
823         * WebGPUShadingLanguageRI/Parse.js:
824         (parsePossibleTernaryConditional):
825         * WebGPUShadingLanguageRI/PropertyResolver.js:
826         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder.prototype.visitTernaryExpression):
827         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder):
828         (PropertyResolver.prototype._visitRValuesWithinLValue):
829         * WebGPUShadingLanguageRI/Rewriter.js:
830         (Rewriter.prototype.visitTernaryExpression):
831         * WebGPUShadingLanguageRI/SPIRV.html:
832         * WebGPUShadingLanguageRI/Test.html:
833         * WebGPUShadingLanguageRI/Test.js:
834         * WebGPUShadingLanguageRI/Visitor.js:
835         (Visitor.prototype.visitProtocolDecl):
836         * WebGPUShadingLanguageRI/index.html:
837
838 2018-08-22  Ryosuke Niwa  <rniwa@webkit.org>
839
840         Assert in NetworkBlobRegistry::unregisterBlobURL after network process had terminated
841         https://bugs.webkit.org/show_bug.cgi?id=188880
842
843         Reviewed by Saam Barati.
844
845         Fixed the bug that testRunner's terminateNetworkProcess, terminateServiceWorkerProcess, and terminateStorageProcess
846         were asynchronously terminating respective processes. Do so synchronously so that we can deterministically
847         test WebKit's behavior in layout tests.
848
849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
850         (WTR::TestRunner::terminateNetworkProcess):
851         (WTR::TestRunner::terminateServiceWorkerProcess):
852         (WTR::TestRunner::terminateStorageProcess):
853         * WebKitTestRunner/TestInvocation.cpp:
854         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
855         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
856
857 2018-08-23  Myles C. Maxfield  <mmaxfield@apple.com>
858
859         [WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
860         https://bugs.webkit.org/show_bug.cgi?id=188773
861
862         Reviewed by Filip Pizlo.
863
864         Before this patch, it was impossible to represent "native typedef vector<float, 4>" because NativeTypes couldn't have
865         typeArguments.
866
867         Previously, the way to identify a type was strictly by name, which was represented by a string. Therefore, when something like
868         "vector<int, 3>" was parsed, it would produce a TypeRef with the name "vector" and typeArguments [TypeRef, IntLiteral]. Then,
869         there was a pass to convert the TypeRef to have the name "int3" and no typeArguments. After this transformation, each type could
870         be uniquely identified by name. That name was then matched to the string-only NativeType name.
871
872         This is okay for vectors and matrices, but it is unfortunate for textures (e.g. Texture2D<float4>) because they don't have any
873         natural string-only name. In addition, the canonicalization would have to be made aware of the fact that Texture2D<float4> is
874         the same as Texture2D<vector<float, 4>>. Similarly, an author may wish to typedef float4 to a different name.
875
876         It would be possible to mangle the names of the texture types to something unique, but then we lose information about the inner
877         type. For example, if we did this, Visitor wouldn't recurse into the float4 when encountering Texture2D<float4> because that
878         information would be lost. This could potentially make operations like programWithUnnecessaryThingsRemoved() more difficult to
879         implement in the future.
880
881         So, it would be better to have each type uniquely identified by (name, typeArguments). TypeRef will therefore also have
882         typeArguments which are used to determine which type it is referencing. After this analysis is done to determine what each
883         TypeRef is referencing, subsequent passes shouldn't care about the typeArguments and should only care about the .type field
884         which had been set - this was true even before this patch.
885
886         This means that NameContext has to aggregate types that accept typeArguments into arrays, where each array holds all the Types
887         that have the same name but different typeArguments. Then, when we need to match a TypeRef with a Type, we can ask the
888         NameContext for the appropriate array. This is the same way that function resolution works.
889
890         We can use Node.unify() to determine whether a TypeRef matches a NativeType. Eventually, this will go away, but for now, this is
891         an okay start. This works just about the same way that function overload resolution works. 
892
893         * WebGPUShadingLanguageRI/All.js:
894         * WebGPUShadingLanguageRI/CallExpression.js:
895         (CallExpression.prototype.resolve):
896         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Copied from Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js. After types
897         have been resolved, there should be no TypeRefs with name "vector" that don't have type arguments. This is just a sanity check.
898         (checkTypesWithArguments.TypeWithArgumentsChecker.prototype.visitTypeRef):
899         (checkTypesWithArguments.TypeWithArgumentsChecker):
900         (checkTypesWithArguments):
901         * WebGPUShadingLanguageRI/Checker.js:
902         (Checker.prototype.visitProgram): Program.types mirrors NameContext: it's a Map that maps strings to types. Because types with
903         typeArguments share names, this has to be updated to map strings to arrays for these types.
904         (Checker.prototype.visitTypeRef):
905         * WebGPUShadingLanguageRI/InferTypesForCall.js:
906         (inferTypesForCall): Don't know why this was here.
907         (inferTypesForTypeArguments): Same as inferTypesForCall, but this one is for matching type arguments.
908         * WebGPUShadingLanguageRI/Intrinsics.js: Adding the types. This patch also adds some scalar types like half, char, etc, but they
909         don't have any functions which accept them. Those will be tested in my next patch which adds math functions for these types. This
910         moves in the direction of matching the standard library in the spec.
911         (Intrinsics.cast):
912         (Intrinsics.bitwiseCast):
913         (Intrinsics.castToHalf):
914         (Intrinsics.):
915         (Intrinsics):
916         * WebGPUShadingLanguageRI/NameContext.js: Aggregate types with typeArguments into arrays.
917         (NameContext.prototype.add):
918         (NameContext.prototype.get let):
919         (NameContext.underlyingThings.prototype.else):
920         (NameContext.prototype.Symbol.iterator):
921         (NameContext):
922         * WebGPUShadingLanguageRI/NameResolver.js:
923         (NameResolver.prototype.visitTypeRef): Call TypeRef.resolve().
924         (NameResolver.prototype.visitCallExpression):
925         (NameResolver):
926         (NameResolver.prototype.visitVectorType): Deleted.
927         * WebGPUShadingLanguageRI/NativeType.js: NativeTypes can have type arguments now.
928         (NativeType):
929         (NativeType.prototype.get typeArguments):
930         (NativeType.prototype.toString):
931         (NativeType.create):
932         * WebGPUShadingLanguageRI/Prepare.js:
933         (let.prepare):
934         * WebGPUShadingLanguageRI/Program.js: Update to work with types aggregated into arrays.
935         (Program.prototype.add):
936         (Program.prototype.toString):
937         (Program):
938         * WebGPUShadingLanguageRI/RemoveTypeArguments.js: Removed.
939         * WebGPUShadingLanguageRI/ResolveNames.js: Update to work with types aggregated into arrays.
940         (resolveNamesInTypes):
941         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Resolve the type overload for types with typeArguments.
942         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Update to work with types aggregated into arrays.
943         (resolveTypeDefsInTypes):
944         * WebGPUShadingLanguageRI/Rewriter.js: TypeRefs and Native/Vector types can have typeArguments.
945         (Rewriter.prototype.visitTypeRef):
946         (Rewriter.prototype.visitVectorType):
947         (Rewriter):
948         * WebGPUShadingLanguageRI/SPIRV.html:
949         * WebGPUShadingLanguageRI/StandardLibrary.js: Matches Intrinsics.
950         (bool.operator):
951         * WebGPUShadingLanguageRI/StatementCloner.js: Native types can have typeArguments.
952         (StatementCloner.prototype.visitNativeType):
953         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Vector types need constructors too.
954         (synthesizeDefaultConstructorOperator.FindAllTypes.prototype.visitVectorType):
955         (synthesizeDefaultConstructorOperator.FindAllTypes):
956         (synthesizeDefaultConstructorOperator):
957         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: No reason to distinguish between wrapping and instantiating a TypeRef.
958         (synthesizeStructAccessors.createTypeRef):
959         * WebGPUShadingLanguageRI/Test.html:
960         * WebGPUShadingLanguageRI/Test.js:
961         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Copied from Tools/WebGPUShadingLanguageRI/ResolveTypeDefs.js.
962         (TypeOverloadResolutionFailure):
963         (TypeOverloadResolutionFailure.prototype.get type):
964         (TypeOverloadResolutionFailure.prototype.get reason):
965         (TypeOverloadResolutionFailure.prototype.toString):
966         * WebGPUShadingLanguageRI/TypeRef.js:
967         (TypeRef.wrap):
968         (TypeRef.prototype.resolve): Figure out which item in the possibleOverloads array matches this.
969         (TypeRef.prototype.toString):
970         (TypeRef):
971         (TypeRef.instantiate): Deleted.
972         * WebGPUShadingLanguageRI/UnificationContext.js: We need to give literals a chance to assume their preferred type. This
973         adds this facility back into the compiler (it was previously deleted).
974         (UnificationContext.prototype.verify):
975         * WebGPUShadingLanguageRI/VectorType.js: Vector types have type arguments.
976         (VectorType):
977         (VectorType.prototype.get elementType):
978         (VectorType.prototype.get numElements):
979         (VectorType.prototype.get numElementsValue):
980         (VectorType.prototype.toString):
981         * WebGPUShadingLanguageRI/Visitor.js: Iterate over the typeArguments.
982         (Visitor.prototype.visitTypeRef):
983         (Visitor.prototype.visitNativeType):
984         (Visitor.prototype.visitVectorType):
985         (Visitor):
986         * WebGPUShadingLanguageRI/index.html:
987
988 2018-08-23  Wenson Hsieh  <wenson_hsieh@apple.com>
989
990         [Attachment Support] Attachment elements don't appear in drag images on macOS
991         https://bugs.webkit.org/show_bug.cgi?id=188823
992         <rdar://problem/43616378>
993
994         Reviewed by Tim Horton.
995
996         Adjusts a couple of existing tests to additionally verify that the drag image generated when dragging an
997         attachment element in macOS is not completely transparent.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1000         (isCompletelyTransparent):
1001         (TestWebKitAPI::TEST):
1002
1003 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
1004
1005         Explain test name matching in run-api-tests help
1006         https://bugs.webkit.org/show_bug.cgi?id=188280
1007
1008         Reviewed by Ryosuke Niwa.
1009
1010         Improve the run-api-tests help message to explain how test
1011         name matching works.
1012
1013         * Scripts/webkitpy/api_tests/run_api_tests.py:
1014         (parse_args):
1015         * Scripts/webkitpy/port/base.py:
1016         (Port):
1017         (Port.path_to_api_test_binaries): Make binary names a globally accessible array.
1018         * Scripts/webkitpy/port/win.py:
1019         (WinPort):
1020         (WinPort.path_to_api_test_binaries): Ditto.
1021
1022 2018-08-23  Youenn Fablet  <youenn@apple.com>
1023
1024         Use "wpt serve" to launch WPT server
1025         https://bugs.webkit.org/show_bug.cgi?id=188848
1026
1027         Reviewed by Ryosuke Niwa.
1028
1029         Use "wpt serve" provided by WPT instead of using our custom launcher.
1030         This simplifies things and will avoid future breakage.
1031         Further simplify web_platform_test_server.py by removing no longer needed actions.
1032         - Do not copy files but use alias
1033         - Do not kill main pid, which leaves subprocesses alive, use interrupt instead.
1034         - Stop enumerating subprocess pids.
1035
1036         * Scripts/webkitpy/common/system/executive_mock.py:
1037         (MockExecutive.interrupt):
1038         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Removed.
1039         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1040         (WebPlatformTestServer.__init__):
1041         (WebPlatformTestServer.ports_to_forward):
1042         (WebPlatformTestServer._prepare_config):
1043         (WebPlatformTestServer._spawn_process):
1044         (WebPlatformTestServer._stop_running_server):
1045
1046 2018-08-23  Jonathan Bedard  <jbedard@apple.com>
1047
1048         run-api-tests: Add --webkit-only, --webcore-only and --webkit-legacy-only options to run WebKit, WebCore and WebKitLegacy tests 
1049         https://bugs.webkit.org/show_bug.cgi?id=188262
1050
1051         Reviewed by Ryosuke Niwa.
1052
1053         * Scripts/webkitpy/api_tests/run_api_tests.py:
1054         (parse_args):
1055
1056 2018-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         [Attachment Support] Support dragging attachment elements out as files on macOS
1059         https://bugs.webkit.org/show_bug.cgi?id=181294
1060         <rdar://problem/36298801>
1061
1062         Reviewed by Tim Horton.
1063
1064         Add DragAndDropSimulator support for intercepting calls to -beginDraggingSessionWithitems:event:source:. This
1065         enables us to write API tests for macOS that exercise the attachment SPI in combination with dragging attachment
1066         elements.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1069         (-[TestWKWebView attachmentElementMidPoint]):
1070
1071         Add a helper method local to this test suite that grabs the midpoint (in client coordinates) or the first
1072         attachment element in the document.
1073
1074         (TestWebKitAPI::TEST):
1075
1076         Add a new API test to verify that dragging an attachment element on macOS produces file providers which may be
1077         used to write attachment data to a path on disk. Additionally, refactor an existing API test,
1078         MoveAttachmentElementAsIconByDragging, so that it runs on both iOS and macOS, to test the ability to move
1079         attachment elements around in a document by using drag and drop.
1080
1081         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1082         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1083         (-[DragAndDropTestWKWebView beginDraggingSessionWithItems:event:source:]):
1084         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1085         (-[DragAndDropSimulator dealloc]):
1086         (-[DragAndDropSimulator runFrom:to:]):
1087         (-[DragAndDropSimulator beginDraggingSessionInWebView:withItems:source:]):
1088
1089         Begin a drag session and kick off the -continueDragSession loop. Unlike -performDragInWebView:…, which spins
1090         the main runloop until dragging ends, this version returns execution to the web view and schedules dragging
1091         updates asynchronously. This matches AppKit behavior.
1092
1093         (-[DragAndDropSimulator continueDragSession]):
1094
1095         Increment the dragging progress amount, send a drag update to the web view, and continue scheduling calls to
1096         itself until the progress reaches 1.
1097
1098         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
1099         (-[DragAndDropSimulator initializeDraggingInfo:dragImage:source:]):
1100
1101         Pull out common logic for creating a new TestDraggingInfo after starting a drag.
1102
1103         (-[DragAndDropSimulator insertedAttachments]):
1104         (-[DragAndDropSimulator removedAttachments]):
1105         (-[DragAndDropSimulator draggingSession]):
1106         (-[DragAndDropSimulator receivePromisedFiles]):
1107
1108         Helper method to save promised files written to the pasteboard after a drag to the temporary directory. These
1109         files are tracked by DragAndDropSimulator and automatically cleaned up after the test finishes.
1110
1111         (-[DragAndDropSimulator endDataTransfer]):
1112
1113         Add a method stub on macOS, so that MoveAttachmentElementAsIconByDragging can be made cross-platform.
1114
1115         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
1116         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
1117
1118         Implement method stubs to keep track of inserted or removed attachments while simulating a drag.
1119
1120 2018-08-22  Aditya Keerthi  <akeerthi@apple.com>
1121
1122         [iOS] Add support for the inputmode attribute
1123         https://bugs.webkit.org/show_bug.cgi?id=183621
1124
1125         Reviewed by Tim Horton.
1126
1127         Added an API test to verify that the correct UIKeyboardType is set depending on
1128         the type, inputmode, and pattern specified for an input field.
1129
1130         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1131         (TestWebKitAPI::TEST):
1132         * TestWebKitAPI/ios/UIKitSPI.h:
1133
1134 2018-08-22  Alex Christensen  <achristensen@webkit.org>
1135
1136         Fix API test on Sierra after r235139
1137         https://bugs.webkit.org/show_bug.cgi?id=188810
1138
1139         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
1140         (TEST):
1141
1142 2018-08-22  David Kilzer  <ddkilzer@apple.com>
1143
1144         Move files in WebCore project to match Xcode folder structure
1145         <https://webkit.org/b/188851>
1146
1147         Reviewed by Tim Horton.
1148
1149         * Scripts/extract-localizable-strings:
1150         * Scripts/update-webkit-localizable-strings:
1151         - Update to match new location of extract-localizable-strings.pl.
1152
1153 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1154
1155         Roll out r235139 and r235146
1156         https://bugs.webkit.org/show_bug.cgi?id=188805
1157
1158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1159         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1160
1161 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1162
1163         [Attachment Support] Remove _WKAttachments and notify the UI client upon mainframe navigation
1164         https://bugs.webkit.org/show_bug.cgi?id=188715
1165         <rdar://problem/43541790>
1166
1167         Reviewed by Tim Horton.
1168
1169         Adds API tests to exercises cases where (1) the UI client is notified of attachment removal upon mainframe
1170         navigation, and (2) the UI client is notified of attachment removal upon web content process termination.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1173         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
1174         (TestWebKitAPI::TEST):
1175
1176 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1177
1178         Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
1179         https://bugs.webkit.org/show_bug.cgi?id=188821
1180
1181         Reviewed by Simon Fraser.
1182
1183         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1184         (TestWebKitAPI::didLayout):
1185         (TestWebKitAPI::TEST):
1186
1187 2018-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
1188
1189         [WHLSL] Call expressions shouldn't have type arguments
1190         https://bugs.webkit.org/show_bug.cgi?id=188770
1191
1192         Reviewed by Filip Pizlo.
1193
1194         Call expressions only had type arguments for casts, becuase native types can have type arguments.
1195         However, instead of putting those type arguments on the CallExpression, we should parse the casted
1196         type as a real type and not as an identifier, which puts the type arguments in the TypeRef.
1197
1198         Test: casts
1199
1200         * WebGPUShadingLanguageRI/CallExpression.js:
1201         (CallExpression):
1202         (CallExpression.prototype.get name):
1203         (CallExpression.resolve):
1204         (CallExpression.prototype.get typeArguments): Deleted.
1205         (CallExpression.prototype.becomeCast): Deleted.
1206         * WebGPUShadingLanguageRI/NameResolver.js:
1207         (NameResolver.prototype.visitCallExpression):
1208         * WebGPUShadingLanguageRI/Parse.js:
1209         (parseConstexpr):
1210         (parseTypeDef):
1211         (parseLeftOperatorCall):
1212         (parseCallExpression.let.parseArguments):
1213         (parsePossiblePrefix):
1214         (parsePossibleRelationalEquality):
1215         (parseLeftLogicalExpression):
1216         (parseIfStatement):
1217         (parseWhile):
1218         (parseFor):
1219         (parseDo):
1220         * WebGPUShadingLanguageRI/RemoveTypeArguments.js:
1221         * WebGPUShadingLanguageRI/Rewriter.js:
1222         (Rewriter.prototype.visitCallExpression):
1223
1224 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1225
1226         Translate WebKit.LimitTitleSize API test into ObjC
1227         https://bugs.webkit.org/show_bug.cgi?id=188810
1228
1229         Reviewed by Andy Estes.
1230
1231         It uses WKPageLoaderClient.didReceiveTitleForFrame which has been replaced by KVO.
1232         I'm translating the test into ObjC rather than introducing a new callback to WKPageNavigationClient.
1233
1234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1235         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp: Removed.
1236         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
1237         (TEST):
1238         (-[LimitTitleSizeTestObserver observeValueForKeyPath:ofObject:change:context:]):
1239         (TestWebKitAPI::TEST): Deleted.
1240
1241 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1242
1243         Remove unused shouldKeepCurrentBackForwardListItemInList check
1244         https://bugs.webkit.org/show_bug.cgi?id=188805
1245
1246         Reviewed by Andy Estes.
1247
1248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1249         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
1250
1251 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1252
1253         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
1254         https://bugs.webkit.org/show_bug.cgi?id=188813
1255
1256         Reviewed by Andy Estes.
1257
1258         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1259         (TestWebKitAPI::didLayout):
1260         (TestWebKitAPI::setPageLoaderClient):
1261         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1262         (TestWebKitAPI::didFinishNavigation):
1263         (TestWebKitAPI::didLayout):
1264         (TestWebKitAPI::setPageLoaderClient):
1265         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1266         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1267         (TestWebKitAPI::didLayout):
1268         (TestWebKitAPI::setPageLoaderClient):
1269
1270 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1271
1272         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1273         https://bugs.webkit.org/show_bug.cgi?id=188496
1274         <rdar://problem/43216836>
1275
1276         Reviewed by Tim Horton.
1277
1278         Adjusts existing attachment API tests. See below for more detail.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1281         (-[TestWKWebView synchronouslyInsertAttachmentWithFileWrapper:contentType:]):
1282         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
1283         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
1284         (-[_WKAttachment synchronouslySetFileWrapper:newContentType:error:]):
1285
1286         Move off of deprecated attachment SPI, and add new helper functions to synchronously insert a new attachment or
1287         update an existing attachment with a file wrapper.
1288
1289         (-[_WKAttachment expectRequestedDataToBe:]):
1290         (TestWebKitAPI::TEST):
1291
1292         Add a new test to verify that file-URL-backed NSFileWrappers can be used to insert and update attachment data.
1293         Also augment an existing test to check that an attachment element which has been copied and pasted within the
1294         same document has a different _WKAttachment wrapper object than its duplicate, but both _WKAttachments are
1295         backed by the same NSFileWrapper that was originally used to insert the attachment.
1296
1297         Additionally, add another macOS test to verify that dropping promised files in an attachment-element-enabled
1298         editable area inserts attachment elements into the document and notifies the UI client with the inserted
1299         attachment data.
1300
1301         (-[_WKAttachment synchronouslyRequestInfo:]): Deleted.
1302         (-[_WKAttachment synchronouslyRequestData:]): Deleted.
1303         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1304         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
1305
1306         Move off of -_webView:didInsertAttachment:.
1307
1308         (-[DragAndDropSimulator _webView:didInsertAttachment:]): Deleted.
1309
1310 2018-08-21  David Kilzer  <ddkilzer@apple.com>
1311
1312         sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name
1313         <https://webkit.org/b/188755>
1314
1315         Reviewed by Andy Estes.
1316
1317         * Scripts/sort-Xcode-project-file: Fix regular expression to
1318         make `mainGroup` name optional.
1319
1320 2018-08-21  Andy VanWagoner  <andy@vanwagoner.family>
1321
1322         Unreviewed, add myself to committers list.
1323
1324         * Scripts/webkitpy/common/config/contributors.json:
1325
1326 2018-08-21  Antti Koivisto  <antti@apple.com>
1327
1328         Allow creating WeakPtrs to const objects
1329         https://bugs.webkit.org/show_bug.cgi?id=188785
1330
1331         Reviewed by Geoffrey Garen.
1332
1333         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1334         (TestWebKitAPI::Base::weakPtrFactory const):
1335         (TestWebKitAPI::TEST):
1336         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
1337
1338 2018-08-21  Per Arne Vollan  <pvollan@apple.com>
1339
1340         [WebGL] Contexts are not updated when display configuration changed.
1341         https://bugs.webkit.org/show_bug.cgi?id=188750
1342
1343         Reviewed by Brent Fulgham.
1344
1345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1349         * WebKitTestRunner/TestController.cpp:
1350         (WTR::TestController::sendDisplayConfigurationChangedMessageForTesting):
1351         * WebKitTestRunner/TestController.h:
1352         * WebKitTestRunner/TestInvocation.cpp:
1353         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1354
1355 2018-08-21  John Wilander  <wilander@apple.com>
1356
1357         Make ResourceLoadObserver::logWebSocketLoading() handle websockets in detached frames
1358         https://bugs.webkit.org/show_bug.cgi?id=188757
1359         <rdar://problem/38713390>
1360
1361         Reviewed by Alex Christensen.
1362
1363         These changes add the new WebKitTestRunner function
1364         isStatisticsRegisteredAsSubresourceUnder().
1365
1366         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1368         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1369         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1370         * WebKitTestRunner/TestController.cpp:
1371         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1372         * WebKitTestRunner/TestController.h:
1373         * WebKitTestRunner/TestInvocation.cpp:
1374         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1375
1376 2018-08-21  Alex Christensen  <achristensen@webkit.org>
1377
1378         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
1379         https://bugs.webkit.org/show_bug.cgi?id=188797
1380
1381         Reviewed by Tim Horton.
1382
1383         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
1384         (TestWebKitAPI::didFinishNavigation):
1385         (TestWebKitAPI::TEST):
1386         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1387         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1388         (TestWebKitAPI::didSameDocumentNavigation):
1389         (TestWebKitAPI::TEST):
1390         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1391         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1392         (TestWebKitAPI::didFailProvisionalNavigation):
1393         (TestWebKitAPI::TEST):
1394         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
1395         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1396         (TestWebKitAPI::didStartProvisionalNavigation):
1397         (TestWebKitAPI::didCommitNavigation):
1398         (TestWebKitAPI::didFinishNavigation):
1399         (TestWebKitAPI::TEST):
1400         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1401         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1402         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1403         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1404         (TestWebKitAPI::didStartProvisionalNavigation):
1405         (TestWebKitAPI::didCommitNavigation):
1406         (TestWebKitAPI::didFinishNavigation):
1407         (TestWebKitAPI::TEST):
1408         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1409         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1410         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1411         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1412         (TestWebKitAPI::renderingProgressDidChange):
1413         (TestWebKitAPI::TEST):
1414         (TestWebKitAPI::didLayout): Deleted.
1415         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1416         (TestWebKitAPI::didFinishNavigation):
1417         (TestWebKitAPI::renderingProgressDidChange):
1418         (TestWebKitAPI::setPageLoaderClient):
1419         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1420         (TestWebKitAPI::didLayout): Deleted.
1421         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1422         (TestWebKitAPI::State::State):
1423         (TestWebKitAPI::didStartProvisionalNavigation):
1424         (TestWebKitAPI::didCommitNavigation):
1425         (TestWebKitAPI::didFinishNavigation):
1426         (TestWebKitAPI::decidePolicyForNavigationAction):
1427         (TestWebKitAPI::decidePolicyForResponse):
1428         (TestWebKitAPI::TEST):
1429         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
1430         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
1431         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1432         (TestWebKitAPI::decidePolicyForNewWindowAction): Deleted.
1433         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1434         (TestWebKitAPI::didSameDocumentNavigation):
1435         (TestWebKitAPI::TEST):
1436         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1437         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1438         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1439         (TestWebKitAPI::TEST):
1440         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
1441         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1442         (TestWebKitAPI::didFinishLoad):
1443         (TestWebKitAPI::TEST):
1444         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp:
1445         (TestWebKitAPI::didFinishNavigation):
1446         (TestWebKitAPI::TEST):
1447         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1448         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1449         (TestWebKitAPI::didFinishLoad):
1450         (TestWebKitAPI::TEST):
1451         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1452         (WebKit2_CommandBackForwardTestWKView::SetUp):
1453         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame): Deleted.
1454
1455 2018-08-20  Alex Christensen  <achristensen@webkit.org>
1456
1457         Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
1458         https://bugs.webkit.org/show_bug.cgi?id=188771
1459
1460         Reviewed by Tim Horton.
1461
1462         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1463         (TestWebKitAPI::didFinishNavigation):
1464         (TestWebKitAPI::TEST):
1465         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1466         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1467         (TestWebKitAPI::didFinishNavigation):
1468         (TestWebKitAPI::TEST):
1469         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1470         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1471         (TestWebKitAPI::didFinishNavigation):
1472         (TestWebKitAPI::setPageLoaderClient):
1473         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1474         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1475         (TestWebKitAPI::TEST):
1476         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1477         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
1478         (TestWebKitAPI::didFinishNavigation):
1479         (TestWebKitAPI::setPageLoaderClient):
1480         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1481         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1482         (TestWebKitAPI::didFinishNavigation):
1483         (TestWebKitAPI::setClients):
1484         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1485         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1486         (TestWebKitAPI::didFinishNavigation):
1487         (TestWebKitAPI::TEST):
1488         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1489         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1490         (TestWebKitAPI::didFinishNavigation):
1491         (TestWebKitAPI::TEST):
1492         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1493         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1494         (TestWebKitAPI::didFinishNavigation):
1495         (TestWebKitAPI::TEST):
1496         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1497         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1498         (TestWebKitAPI::didFinishNavigation):
1499         (TestWebKitAPI::TEST):
1500         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1501         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1502         (TestWebKitAPI::didFinishNavigation):
1503         (TestWebKitAPI::TEST):
1504         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1505         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1506         (TestWebKitAPI::didFinishNavigation):
1507         (TestWebKitAPI::setPageLoaderClient):
1508         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1509         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1510         (TestWebKitAPI::didFinishNavigation):
1511         (TestWebKitAPI::TEST):
1512         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1513         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp:
1514         (TestWebKitAPI::didFinishLoadForFrame):
1515         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1516         (TestWebKitAPI::didFinishNavigation):
1517         (TestWebKitAPI::loadAlternateHTMLString):
1518         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1519         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1520         (TestWebKitAPI::didFinishNavigation):
1521         (TestWebKitAPI::TEST):
1522         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1523         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1524         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1525         (TestWebKitAPI::didFinishLoad):
1526         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1527         (TestWebKitAPI::didFinishNavigation):
1528         (TestWebKitAPI::setPageLoaderClient):
1529         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1530         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1531         (TestWebKitAPI::didFinishNavigation):
1532         (TestWebKitAPI::setPageLoaderClient):
1533         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1534         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1535         (TestWebKitAPI::didFinishLoadForFrame):
1536         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1537         (TestWebKitAPI::TEST):
1538         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1539         (TestWebKitAPI::TEST):
1540         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1541         (TestWebKitAPI::didFinishLoad):
1542         (TestWebKitAPI::TEST):
1543         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1544         (TestWebKitAPI::didFinishNavigation):
1545         (TestWebKitAPI::setPageLoaderClient):
1546         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1547         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1548         (TestWebKitAPI::didFinishNavigation):
1549         (TestWebKitAPI::setPageLoaderClient):
1550         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1551         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1552         (TestWebKitAPI::didFinishNavigation):
1553         (TestWebKitAPI::TEST):
1554         (TestWebKitAPI::didFinishDocumentLoadForFrame): Deleted.
1555         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1556         (TestWebKitAPI::didFinishNavigation):
1557         (TestWebKitAPI::TEST):
1558         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1559         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1560         (TestWebKitAPI::didFailProvisionalNavigation):
1561         (TestWebKitAPI::TEST):
1562         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
1563         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1564         (TestWebKitAPI::didFinishNavigation):
1565         (TestWebKitAPI::TEST):
1566         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1567         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1568         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishNavigation):
1569         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1570         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame): Deleted.
1571         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1572         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishNavigation):
1573         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1574         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame): Deleted.
1575         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
1576         (TestWebKitAPI::didFinishNavigation):
1577         (TestWebKitAPI::setPageLoaderClient):
1578         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1579         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1580         (TestWebKitAPI::didFinishNavigation):
1581         (TestWebKitAPI::setPageLoaderClient):
1582         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1583         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1584         (TestWebKitAPI::didFinishNavigation):
1585         (TestWebKitAPI::setPageLoaderClient):
1586         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1587         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1588         (TestWebKitAPI::didFinishNavigation):
1589         (TestWebKitAPI::setUpClients):
1590         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1591         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1592         (TestWebKitAPI::didFinishNavigation):
1593         (TestWebKitAPI::setPageLoaderClient):
1594         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1595         * TestWebKitAPI/Tests/WebKit/WebArchive.cpp:
1596         (TestWebKitAPI::didFinishNavigation):
1597         (TestWebKitAPI::TEST):
1598         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1599         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1600         (TestWebKitAPI::didFinishNavigation):
1601         (TestWebKitAPI::TEST):
1602         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1603         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1604         (TestWebKitAPI::didFinishNavigation):
1605         (TestWebKitAPI::TEST):
1606         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1607         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1608         (TestWebKitAPI::didFinishNavigation):
1609         (TestWebKitAPI::TEST):
1610         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1611         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1612         (TestWebKitAPI::didFinishNavigation):
1613         (TestWebKitAPI::TEST):
1614         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1615         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1616         (TestWebKitAPI::didFinishNavigation):
1617         (TestWebKitAPI::TEST):
1618         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1619         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1620         (TestWebKitAPI::didFinishNavigation):
1621         (TestWebKitAPI::TEST):
1622         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1623         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1624         (didFinishNavigation):
1625         (TestWebKitAPI::TEST):
1626         (didFinishLoadForFrame): Deleted.
1627         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1628         (didFinishNavigation):
1629         (TestWebKitAPI::TEST):
1630         (didFinishLoadForFrame): Deleted.
1631         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1632         (TestWebKitAPI::didFinishNavigation):
1633         (TestWebKitAPI::TEST):
1634         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1635         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1636         (TestWebKitAPI::didFinishNavigation):
1637         (TestWebKitAPI::setPageLoaderClient):
1638         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
1639
1640 2018-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1641
1642         [WPE] Update to use libwpe-1.0.0 and WPEBackend-fdo-1.0.0
1643         https://bugs.webkit.org/show_bug.cgi?id=188782
1644
1645         Reviewed by Michael Catanzaro.
1646
1647         Make the build depend on wpe-0.2, and change the Flatpak and JHBuild development
1648         environments to use version 1.0.0 of libwpe and WPEBackend-fdo.
1649
1650         * flatpak/org.webkit.WPE.yaml: Update to use libwpe and WPEBackend-fdo version 1.0.0 from
1651         release tarballs, and removed the (now unneeded) Lua and LuaJIT modules.
1652         * wpe/jhbuild.modules: Ditto.
1653
1654 2018-08-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1655
1656         [Flatpak] Update to GNOME master runtime
1657         https://bugs.webkit.org/show_bug.cgi?id=188731
1658
1659         Reviewed by Philippe Normand.
1660
1661         The 3.28 runtime is pretty stale at this point. We could wait a couple weeks for the 3.30
1662         runtime, but I don't think there's any need to stick with the stable runtime when we have
1663         the ability to pin to a particular version of the master runtime. There are also several
1664         advantages to switching to the master runtime.
1665
1666         * flatpak/files/httpd-autogen.sh: Removed.
1667         * flatpak/flatpakutils.py:
1668         (WebkitFlatpak.clean_args):
1669         * flatpak/org.webkit.GTK.yaml:
1670         * flatpak/org.webkit.WebKit.yaml:
1671         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1672         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1673
1674 2018-08-20  Jonathan Bedard  <jbedard@apple.com>
1675
1676         WebKitTestRunner: Add watchOS entitlements
1677         https://bugs.webkit.org/show_bug.cgi?id=188758
1678
1679         Reviewed by Tim Horton.
1680
1681         watchOS needs an additional entitlement to open up a socket for on-device testing.
1682
1683         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements: Added.
1684         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1686
1687 2018-08-20  Thomas Denney  <tdenney@apple.com>
1688
1689         [WHLSL] Remove generics from the interpreter
1690         https://bugs.webkit.org/show_bug.cgi?id=187988
1691
1692         Reviewed by Myles C. Maxfield.
1693
1694         This patch completely removes generic and protocol support from WHLSL
1695         whilst adding back any features that were originally implemented with
1696         generics.
1697
1698         Many of the changes in this patch just remove occurrences of type
1699         arguments and type parameters --- although there are some cases where
1700         they have been deliberately left in --- as well as removing tests only
1701         relevant to those features. These changes are not listed below.
1702
1703         * WebGPUShadingLanguageRI/All.js: Add/remove JS dependencies
1704         * WebGPUShadingLanguageRI/AutoWrapper.js:
1705         (AutoWrapper.prototype.visitConstexprTypeParameter): Deleted.
1706         * WebGPUShadingLanguageRI/BuiltinVectorCasts.js: Added. The built-in
1707         vectors have many constructors for different scalar and vector types.
1708         These were originally implemented with generics.
1709         * WebGPUShadingLanguageRI/BuiltinVectorEqualityOperator.js: Adds the
1710         equality operator for built-in vectors, again this was removed with
1711         generics.
1712         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Added, as above.
1713         Built-in vectors only support the getter and setter, and not the ander.
1714         * WebGPUShadingLanguageRI/BuiltinVectorIndexGetter.js: Added.
1715         * WebGPUShadingLanguageRI/BuiltinVectorIndexSetter.js: Added.
1716         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Added.
1717         * WebGPUShadingLanguageRI/CallExpression.js: Adds support for
1718         instantiating functions which cannot be discovered earlier in
1719         preparation because their types are absent (specifically support for the
1720         operator &[] for array references and the length operator for array
1721         references). Previously support for these was implemented with generics.
1722         (CallExpression.resolve):
1723         (CallExpression.prototype.resolve):
1724         (CallExpression.prototype._resolveByInstantiation):
1725         (CallExpression.prototype._resolveToOperatorAnderIndexer):
1726         (CallExpression.prototype._resolveToOperatorLength):
1727         (CallExpression.prototype.resolveToOverload):
1728         (CallExpression.prototype.becomeCast):
1729         (CallExpression.prototype.toString):
1730         (CallExpression):
1731         * WebGPUShadingLanguageRI/CallExpressionTypeArgumentResolver.js: Added.
1732         We support syntax like vector<int, 2>(a, b) for constructing vectors;
1733         this new preparation step resolves them to specific constructors.
1734         * WebGPUShadingLanguageRI/CallFunction.js:
1735         * WebGPUShadingLanguageRI/Checker.js:
1736         * WebGPUShadingLanguageRI/ConstexprFolder.js:
1737         * WebGPUShadingLanguageRI/CreateLiteralType.js:
1738         * WebGPUShadingLanguageRI/ExpressionFinder.js:
1739         * WebGPUShadingLanguageRI/FlattenProtocolExtends.js: Removed.
1740         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
1741         * WebGPUShadingLanguageRI/Func.js:
1742         * WebGPUShadingLanguageRI/FuncDef.js:
1743         * WebGPUShadingLanguageRI/FuncInstantiator.js: Deleted.
1744         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed usage of type arguments.
1745         * WebGPUShadingLanguageRI/Inline.js: Remove use of FuncInstantiator.
1746         * WebGPUShadingLanguageRI/Inliner.js: Ditto.
1747         * WebGPUShadingLanguageRI/Intrinsics.js:
1748         * WebGPUShadingLanguageRI/Lexer.js:
1749         * WebGPUShadingLanguageRI/LiteralTypeChecker.js:
1750         * WebGPUShadingLanguageRI/NameContext.js:
1751         (NameContext.prototype.add):
1752         (NameContext.prototype.get let):
1753         (NameContext.underlyingThings.prototype.else):
1754         (NameContext.prototype.resolveFuncOverload):
1755         * WebGPUShadingLanguageRI/NameFinder.js:
1756         * WebGPUShadingLanguageRI/NameResolver.js:
1757         (NameResolver.prototype.visitFunc):
1758         (NameResolver.prototype.visitFuncDef):
1759         (NameResolver.prototype.visitTypeDef):
1760         (NameResolver.prototype.visitStructType):
1761         (NameResolver.prototype.visitTypeRef):
1762         (NameResolver.prototype.visitCallExpression):
1763         (NameResolver.prototype.visitVectorType):
1764         (NameResolver):
1765         (NameResolver.prototype._visitTypeParametersAndBuildNameContext): Deleted.
1766         (NameResolver.prototype.visitProtocolDecl): Deleted.
1767         * WebGPUShadingLanguageRI/NativeFunc.js:
1768         (NativeFunc):
1769         * WebGPUShadingLanguageRI/NativeFuncInstance.js: Deleted.
1770         * WebGPUShadingLanguageRI/NativeType.js:
1771         (NativeType):
1772         (NativeType.prototype.get name):
1773         (NativeType.prototype.toString):
1774         (NativeType.prototype.get typeParameters): Deleted.
1775         (NativeType.prototype.instantiate): Deleted.
1776         * WebGPUShadingLanguageRI/Node.js:
1777         (Node.prototype.commit):
1778         (Node):
1779         (Node.prototype.substitute): Deleted.
1780         (Node.prototype.substituteToUnification): Deleted.
1781         * WebGPUShadingLanguageRI/OperatorAnderIndex.js: Added, previously
1782         implemented with generics.
1783         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Ditto.
1784         * WebGPUShadingLanguageRI/OperatorBool.js: Ditto.
1785         * WebGPUShadingLanguageRI/Parse.js: Removed everything related to
1786         generics and protocols.
1787         * WebGPUShadingLanguageRI/Prepare.js: Added new stages.
1788         * WebGPUShadingLanguageRI/Program.js:
1789         (Program):
1790         (Program.prototype.get types):
1791         (Program.prototype.add):
1792         (Program.prototype.get protocols): Deleted.
1793         * WebGPUShadingLanguageRI/ProtocolDecl.js: Removed.
1794         * WebGPUShadingLanguageRI/ProtocolRef.js: Removed.
1795         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js:
1796         * WebGPUShadingLanguageRI/ResolveCallExpressionsWithTypeArguments.js: Added.
1797         * WebGPUShadingLanguageRI/ResolveNames.js:
1798         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
1799         * WebGPUShadingLanguageRI/ResolveTypeDefs.js:
1800         (resolveTypeDefsInProtocols): Deleted.
1801         * WebGPUShadingLanguageRI/Rewriter.js: Changes for new classes.
1802         * WebGPUShadingLanguageRI/SPIRV.html:
1803         * WebGPUShadingLanguageRI/SPIRVCodegen.js:
1804         * WebGPUShadingLanguageRI/StandardLibrary.js: Replace old generic features.
1805         * WebGPUShadingLanguageRI/StatementCloner.js: Changes for new classes.
1806         (StructLayoutBuilder):
1807         * WebGPUShadingLanguageRI/StructType.js:
1808         * WebGPUShadingLanguageRI/SwizzleOp.js:
1809         (SwizzleOp):
1810         (SwizzleOp.prototype.get baseTypeName):
1811         (SwizzleOp.prototype.toString):
1812         (SwizzleOp.functions.):
1813         (SwizzleOp.functions):
1814         (SwizzleOp.prototype.instantiateImplementation):
1815         (SwizzleOp.allSwizzleOperators.): Deleted.
1816         (SwizzleOp.allSwizzleOperators): Deleted.
1817         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Added,
1818         previously implemented with generics.
1819         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Ditto.
1820         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Ditto.
1821         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Ditto.
1822         * WebGPUShadingLanguageRI/SynthesizeOperatorBool.js: Ditto.
1823         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1824         (synthesizeStructAccessors.setupImplementationData):
1825         (synthesizeStructAccessors.createFieldType):
1826         (synthesizeStructAccessors.createTypeRef):
1827         (synthesizeStructAccessors.setupAnder):
1828         (synthesizeStructAccessors):
1829         (synthesizeStructAccessors.createTypeParameters): Deleted.
1830         (synthesizeStructAccessors.): Deleted.
1831         * WebGPUShadingLanguageRI/Test.html:
1832         * WebGPUShadingLanguageRI/Test.js: Removed redundant tests and added new
1833         tests for changed language features.
1834         * WebGPUShadingLanguageRI/Type.js:
1835         * WebGPUShadingLanguageRI/TypeDef.js:
1836         * WebGPUShadingLanguageRI/TypeDefResolver.js:
1837         * WebGPUShadingLanguageRI/TypeParameterRewriter.js: Removed.
1838         * WebGPUShadingLanguageRI/TypeRef.js:
1839         * WebGPUShadingLanguageRI/TypeVariable.js: Removed.
1840         * WebGPUShadingLanguageRI/UnificationContext.js:
1841         * WebGPUShadingLanguageRI/VectorType.js: Added.
1842         * WebGPUShadingLanguageRI/Visitor.js: Changes for new classes.
1843         * WebGPUShadingLanguageRI/WSL.md: Removed description of
1844         generics/protocols.
1845         * WebGPUShadingLanguageRI/WrapChecker.js:
1846         (WrapChecker):
1847         (WrapChecker.visitConstexprTypeParameter): Deleted.
1848         (WrapChecker.prototype.visitFuncParameter): Deleted.
1849         (WrapChecker.prototype.visitTypeVariable): Deleted.
1850         * WebGPUShadingLanguageRI/index.html:
1851
1852 2018-08-20  Thomas Denney  <tdenney@apple.com>
1853
1854         Added Thomas Denney to contributors.json.
1855         https://bugs.webkit.org/show_bug.cgi?id=188525
1856
1857         Reviewed by Myles C. Maxfield.
1858
1859         * Scripts/webkitpy/common/config/contributors.json:
1860
1861 2018-08-20  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1862
1863         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1864         https://bugs.webkit.org/show_bug.cgi?id=188738
1865
1866         Reviewed by Michael Catanzaro.
1867
1868         * glib/generate-inspector-gresource-manifest.py:
1869         (get_filenames): sort list of input files
1870
1871 2018-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1872
1873         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
1874         https://bugs.webkit.org/show_bug.cgi?id=184271
1875         <rdar://problem/39256708>
1876
1877         Reviewed by Andy Estes.
1878
1879         This API test is failing when run against older macOS builds, where custom pasteboard
1880         data is not enabled by default.
1881
1882         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1883         (TestWebKitAPI::TEST):
1884
1885 2018-08-20  Claudio Saavedra  <csaavedra@igalia.com>
1886
1887         Add WPE Debug configuration to the flakiness dashboard
1888         https://bugs.webkit.org/show_bug.cgi?id=188743
1889
1890         Reviewed by Michael Catanzaro.
1891
1892         * TestResultServer/static-dashboards/builders.jsonp:
1893         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1894
1895 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1896
1897         [GLIB] Add API to throw exceptions using printf formatted strings
1898         https://bugs.webkit.org/show_bug.cgi?id=188698
1899
1900         Reviewed by Michael Catanzaro.
1901
1902         Add cases to test the new API.
1903
1904         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1905         (createFormattedError):
1906         (createCustomFormattedError):
1907         (testJSCExceptions):
1908
1909 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1910
1911         [GLIB] Complete the JSCException API
1912         https://bugs.webkit.org/show_bug.cgi?id=188695
1913
1914         Reviewed by Michael Catanzaro.
1915
1916         Add cases to test the new API.
1917
1918         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1919         (testJSCCheckSyntax):
1920         (createCustomError):
1921         (testJSCExceptions):
1922
1923 2018-08-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1924
1925         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
1926         https://bugs.webkit.org/show_bug.cgi?id=184271
1927         <rdar://problem/39256708>
1928
1929         Reviewed by Ryosuke Niwa.
1930
1931         Add a new API test to verify that on both iOS and macOS, copied custom pasteboard data can only be pasted in a
1932         matching origin. Additionally verify that on iOS, the web view is capable of performing the "paste:" selector.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1935         (TestWebKitAPI::TEST):
1936         (imagePath): Deleted.
1937         (writeTypesAndDataToPasteboard): Deleted.
1938         (setUpWebView): Deleted.
1939         (markupString): Deleted.
1940
1941         Make this test file no longer exclusive to macOS.
1942
1943         * TestWebKitAPI/cocoa/TestWKWebView.h:
1944         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1945         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]):
1946
1947         Tweak this helper to also take in a `baseURL`. Defaults to using the TestWebKitAPI bundle resource URL.
1948
1949         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1950
1951 2018-08-17  Jonathan Bedard  <jbedard@apple.com>
1952
1953         Add back --wtf-only to run-api-tests
1954         https://bugs.webkit.org/show_bug.cgi?id=187893
1955         <rdar://problem/42483983>
1956
1957         Reviewed by Aakash Jain.
1958
1959         When doing WTF development, it is not necessary to build or run all of the API
1960         tests. Generally, if a user has specified a specific binary (or binaries) that
1961         they are interested in testing, it is not necessary to check all API test binaries.
1962
1963         * Scripts/webkitpy/api_tests/manager.py:
1964         (Manager._collect_tests): Only use the binaries matching the program arguments
1965         when collecting tests.
1966         (Manager._binaries_for_arguments): Generate a list of binaries which match the
1967         program arguments.
1968         (Manager.run): Pass a list binaries to check.
1969         * Scripts/webkitpy/api_tests/run_api_tests.py:
1970         (parse_args):
1971         * Scripts/webkitpy/port/base.py:
1972         (Port.check_api_test_build): If the caller specifies which API test binaries it
1973         requires, only check the ones specified.
1974         (Port.path_to_api_test_binaries): Allow the caller to only build the WTF API tests.
1975         (Port._build_api_tests): Allow the caller to only build the WTF API tests.
1976         * Scripts/webkitpy/port/win.py:
1977         (WinPort.path_to_api_test_binaries):
1978
1979 2018-08-17  Jer Noble  <jer.noble@apple.com>
1980
1981         REGRESSION (234743) Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio
1982         https://bugs.webkit.org/show_bug.cgi?id=188470
1983         <rdar://problem/43144969>
1984
1985         Reviewed by Alex Christensen.
1986
1987         On a loaded server, the WebContent process may send the "playing" message before the
1988         UIProcess has a chance to register a listener for that message. Restructure the tests
1989         so that the listener is registered before the page is loaded.
1990
1991         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1992         (PreferredAudioBufferSize::runPlayingTestWithPageNamed):
1993         (TEST_F):
1994
1995 2018-08-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1996
1997         [macOS] [WK2] Add infrastructure to test receiving file promises on drop
1998         https://bugs.webkit.org/show_bug.cgi?id=188583
1999
2000         Reviewed by Andy Estes.
2001
2002         Enable testing file promise drop handling on the WebKit2 port of macOS by introducing a subclass of
2003         NSFilePromiseReceiver and implementing `-enumerateDraggingItemsWithOptions:forView:…` on TestDraggingInfo (the
2004         concrete NSDraggingInfo implementation used by DragAndDropSimulator) using the mock file receiver. Also
2005         introduces 3 new macOS tests. See below for more details.
2006
2007         A large portion of this logic is ported over from DumpRenderTree testing infrastructure added in r229297. In a
2008         future patch, we should introduce a way to write code common to both API tests, WebKitTestRunner and
2009         DumpRenderTree, and make this code shared among all three testing harnesses.
2010
2011         Tests:  DragAndDropTests.DragImageElementIntoFileUpload
2012                 DragAndDropTests.DragPromisedImageFileIntoFileUpload
2013                 DragAndDropTests.DragImageFileIntoFileUpload
2014
2015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2016         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2017         (TEST):
2018
2019         Drive-by fix: Replace NSMakePoint with CGPointMake.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/image-and-file-upload.html:
2022
2023         Add a new test page consisting of an image and a "file upload" area that updates exercises DataTransfer API to
2024         load the dropped image.
2025
2026         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2027         (waitForConditionWithLogging):
2028
2029         Add a helper function to wait for a condition to evaluate to true. To make failures more informative,
2030         additionally add a mechanism to log a warning message after a given timeout, if the condition has yet to be met.
2031
2032         (TEST):
2033
2034         Add new tests to exercise a few cases of file upload in WebKit, including: (1) dragging from an image element,
2035         (2) dragging files written to the pasteboard as promises, and (3) files written to the pasteboard as file URLs.
2036
2037         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2038
2039         Surface the new functionality provided by the file promise receiver mock via two new methods on
2040         DragAndDropSimulator to (1) write files as file promises to the pasteboard, and (2) write files as file paths
2041         directly to the pasteboard.
2042
2043         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2044         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
2045         (-[DragAndDropSimulator externalPromisedFiles]):
2046         (getFilePathsAndTypeIdentifiers):
2047         (-[DragAndDropSimulator writePromisedFiles:]):
2048         (-[DragAndDropSimulator writeFiles:]):
2049         * TestWebKitAPI/mac/TestDraggingInfo.h:
2050         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2051         (-[TestDraggingInfo initWithDragAndDropSimulator:]):
2052         (-[TestDraggingInfo filePromiseReceivers]):
2053         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2054
2055         Implement this by invoking the given block with a TestFilePromiseReceiver. While all other classes are
2056         unhandled by this testing code, WebKit only calls into this with [NSFilePromiseReceiver class], this is
2057         currently sufficient for testing purposes.
2058
2059         * TestWebKitAPI/mac/TestFilePromiseReceiver.h: Copied from Tools/TestWebKitAPI/mac/TestDraggingInfo.h.
2060         * TestWebKitAPI/mac/TestFilePromiseReceiver.mm: Added.
2061         (-[TestFilePromiseReceiver initWithPromisedTypeIdentifiers:dragAndDropSimulator:]):
2062         (-[TestFilePromiseReceiver fileTypes]):
2063         (-[TestFilePromiseReceiver fileNames]):
2064         (-[TestFilePromiseReceiver dealloc]):
2065         (-[TestFilePromiseReceiver draggingSource]):
2066         (-[TestFilePromiseReceiver setDraggingSource:]):
2067         (fileNameWithNumericSuffix):
2068         (copyFile):
2069
2070         Add a helper to copy a file into a destination directory. Used to implement the main functionality of our
2071         NSFilePromiseReceiver subclass, which copies the files specified by test code into the directory determined by
2072         WebKit.
2073
2074         (-[TestFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
2075
2076 2018-08-16  Alex Christensen  <achristensen@webkit.org>
2077
2078         Add entitlement to MiniBrowser to allow it to communicate with com.apple.Safari.SafeBrowsing.Service
2079         https://bugs.webkit.org/show_bug.cgi?id=188677
2080
2081         Reviewed by Tim Horton.
2082
2083         * MiniBrowser/MiniBrowser.entitlements:
2084         SSBLookupContext lookUpURL:completionHandler: fails to communicate with its service without this entitlement
2085         on released operating systems.  See <rdar://problem/42749777>
2086
2087 2018-08-16  Jer Noble  <jer.noble@apple.com>
2088
2089         Add option to run-api-tests to force running of DISABLED tests.
2090         https://bugs.webkit.org/show_bug.cgi?id=188674
2091
2092         Reviewed by Joseph Pecoraro.
2093
2094         * Scripts/webkitpy/api_tests/run_api_tests.py:
2095         (parse_args):
2096         * Scripts/webkitpy/api_tests/runner.py:
2097         (Runner.command_for_port):
2098         (_Worker._run_single_test):
2099
2100 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
2101
2102         [ews-build] Separate queues for Builders and Testers - macOS High Sierra
2103         https://bugs.webkit.org/show_bug.cgi?id=188540
2104
2105         Reviewed by Lucas Forschler.
2106
2107         * BuildSlaveSupport/ews-build/config.json: Splitted few macOS queues into builders and testers. 
2108
2109 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
2110
2111         [ews-build] Add build steps ArchiveTestResults, UploadTestResults and ExtractTestResults
2112         https://bugs.webkit.org/show_bug.cgi?id=188666
2113
2114         Reviewed by Lucas Forschler.
2115
2116         * BuildSlaveSupport/ews-build/steps.py:
2117         (ArchiveTestResults): Build step to Archive the test results.
2118         (UploadTestResults): Build step to upload the archive.
2119         (ExtractTestResults): Build step to unzip the archive on server and generate a link.
2120         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2121         (ExpectMasterShellCommand): Copied from other similar internal code.
2122
2123 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
2124
2125         [ews-build] Separate queues for Builders and Testers - macOS Sierra
2126         https://bugs.webkit.org/show_bug.cgi?id=188516
2127
2128         Reviewed by Lucas Forschler.
2129
2130         * BuildSlaveSupport/ews-build/config.json: Splitted macOS Sierra Release queues into builders and testers.
2131         * BuildSlaveSupport/ews-build/factories.py: Used appropriate base classes for builders and testers.
2132
2133 2018-08-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2134
2135         [Win][DumpRenderTree] Remove error message for duplicated tests.
2136         https://bugs.webkit.org/show_bug.cgi?id=188662
2137
2138         Reviewed by Per Arne Vollan.
2139
2140         This was added to track down an issue where the same tests appeared
2141         to be run multiple times. This turned out to not be the case.
2142         See https://bugs.webkit.org/show_bug.cgi?id=166760 .
2143
2144         * DumpRenderTree/win/DumpRenderTree.cpp:
2145         (runTest):
2146
2147 2018-08-16  Alex Christensen  <achristensen@webkit.org>
2148
2149         Re-introduce assertion removed in r234890
2150         https://bugs.webkit.org/show_bug.cgi?id=188611
2151
2152         Reviewed by Geoffrey Garen.
2153
2154         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2155         (TestWebKitAPI::TEST):
2156
2157 2018-08-16  Jer Noble  <jer.noble@apple.com>
2158
2159         Add Experimental Feature support for SourceBuffer.changeType()
2160         https://bugs.webkit.org/show_bug.cgi?id=188626
2161         <rdar://problem/43356021>
2162
2163         Reviewed by Eric Carlson.
2164
2165         * DumpRenderTree/mac/DumpRenderTree.mm:
2166         (enableExperimentalFeatures):
2167         (resetWebPreferencesToConsistentValues):
2168         * WebKitTestRunner/TestController.cpp:
2169         (WTR::TestController::resetPreferencesToConsistentValues):
2170
2171 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2172
2173         Support drag-and-drop for input[type=color]
2174         https://bugs.webkit.org/show_bug.cgi?id=188464
2175
2176         Reviewed by Wenson Hsieh.
2177
2178         Added five cross-platform API tests, to verify that dragging and dropping with
2179         color inputs changes the value of the drop target if and only if both inputs are
2180         enabled. Also tests that the change and input events are fired when changing the
2181         value of a color input through drag and drop. 
2182
2183         Additionally, added a macOS-specific test to verify that dropping an item with
2184         NSColorPboardType changes the value of the color input.
2185
2186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2187         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2188         (TestWebKitAPI::TEST):
2189         * TestWebKitAPI/Tests/WebKitCocoa/color-drop.html: Added.
2190         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2191         (TestWebKitAPI::TEST):
2192
2193 2018-08-16  Antti Koivisto  <antti@apple.com>
2194
2195         Use OptionSet for ActivityState::Flags
2196         https://bugs.webkit.org/show_bug.cgi?id=188554
2197
2198         Reviewed by Brent Fulgham.
2199
2200         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2201         (TestWebKitAPI::TEST):
2202
2203 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2204
2205         [GTK] MiniBrowser: web view doesn't get the focus when new window is created
2206         https://bugs.webkit.org/show_bug.cgi?id=188546
2207
2208         Reviewed by Michael Catanzaro.
2209
2210         When a new window is created, the first widget of the windo is getting the focus, the toolbar in this case. We
2211         always want the WebView to grab the focus. In case of new empty tab, we want to the URL bar to be focused
2212         instead. This was causing failures in WebDriver tests that create a popup window with an input element that is
2213         filled with send keys command. The input element is marked as focused in the DOM, but the actual focused widget
2214         is the toolbar, so key events are sent to the toolbar instead of the web view.
2215
2216         * MiniBrowser/gtk/BrowserWindow.c:
2217         (webViewCreate):
2218         (newTabCallback):
2219         (openPrivateWindow):
2220         (browser_window_get_or_create_web_view_for_automation):
2221
2222 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2223
2224         Unreviewed. Fix WebDriver tests after r234839.
2225
2226         New pytest requires to autoinstall attrs too.
2227
2228         * Scripts/webkitpy/thirdparty/__init__.py:
2229         (AutoinstallImportHook._install_pytest):
2230
2231 2018-08-15  Ansh Shukla  <ansh_shukla@apple.com>
2232
2233         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2234         https://bugs.webkit.org/show_bug.cgi?id=186870
2235         <rdar://problem/41314410>
2236
2237         Reviewed by Alex Christensen.
2238
2239         * WebKitTestRunner/TestController.cpp:
2240         (WTR::toString):
2241         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
2242         (WTR::TestController::didReceiveAuthenticationChallenge):
2243
2244 2018-08-15  Ben Richards  <benton_richards@apple.com>
2245
2246         We should cache the compiled sandbox profile in a data vault
2247         https://bugs.webkit.org/show_bug.cgi?id=184991
2248
2249         Reviewed by Ryosuke Niwa.
2250
2251         Added trace points for sandbox initialization
2252
2253         * Tracing/SystemTracePoints.plist:
2254
2255 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
2256
2257         Unreviewed, rolling out r234870.
2258
2259         The test introduced with this change is a flaky failure.
2260
2261         Reverted changeset:
2262
2263         "NSURLAuthenticationMethodOAuth challenges are surfaced to
2264         clients in -didReceiveAuthenticationChallenge as
2265         NSURLAuthenticationMethodDefault"
2266         https://bugs.webkit.org/show_bug.cgi?id=186870
2267         https://trac.webkit.org/changeset/234870
2268
2269 2018-08-15  Jonathan Bedard  <jbedard@apple.com>
2270
2271         WebKitTestRunner should support watch devices
2272         https://bugs.webkit.org/show_bug.cgi?id=188570
2273
2274         Reviewed by Alex Christensen.
2275
2276         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2277
2278 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2279
2280         [Attachment SPI] Remove attachment display mode options
2281         https://bugs.webkit.org/show_bug.cgi?id=188596
2282
2283         Reviewed by Dan Bernstein.
2284
2285         Remove API tests and API test helpers for verifying the behavior of in-place media attachment elements.
2286
2287         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2288         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
2289         (TestWebKitAPI::TEST):
2290         (testVideoData): Deleted.
2291         (displayOptionsWithMode): Deleted.
2292         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]): Deleted.
2293
2294 2018-08-14  Devin Rousso  <drousso@apple.com>
2295
2296         Unreviewed, change my emails.
2297
2298         * Scripts/webkitpy/common/config/contributors.json:
2299         * Scripts/webkitpy/common/config/watchlist:
2300
2301 2018-08-14  Saam barati  <sbarati@apple.com>
2302
2303         HashMap<Ref<P>, V> asserts when V is not zero for its empty value
2304         https://bugs.webkit.org/show_bug.cgi?id=188582
2305
2306         Reviewed by Sam Weinig.
2307
2308         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2309         (TestWebKitAPI::TEST):
2310
2311 2018-08-14  Zalan Bujtas  <zalan@apple.com>
2312
2313         [LFC][Floating] Add support for negative clearance.
2314         https://bugs.webkit.org/show_bug.cgi?id=188555
2315
2316         Reviewed by Simon Fraser.
2317
2318         * LayoutReloaded/misc/LFC-passing-tests.txt:
2319
2320 2018-08-14 Sihui Liu <sihui_liu@apple.com>
2321
2322         Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
2323         https://bugs.webkit.org/show_bug.cgi?id=188576
2324         <rdar://problem/43148977>
2325
2326         Reviewed by Alex Christensen.
2327
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Added.
2330         (TEST):
2331
2332 2018-08-14  Alex Christensen  <achristensen@webkit.org>
2333
2334         isValidCSSSelector is unsafe to be called from a non-main thread
2335         https://bugs.webkit.org/show_bug.cgi?id=188581
2336         <rdar://problem/40517358>
2337
2338         Reviewed by Sam Weinig.
2339
2340         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2341         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2342         (TestWebKitAPI::checkCompilerError):
2343
2344 2018-08-14  Ansh Shukla  <ansh_shukla@apple.com>
2345
2346         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2347         https://bugs.webkit.org/show_bug.cgi?id=186870
2348         <rdar://problem/41314410>
2349
2350         Reviewed by Alex Christensen.
2351
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::toString):
2354         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
2355         (WTR::TestController::didReceiveAuthenticationChallenge):
2356
2357 2018-08-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2358
2359         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
2360         https://bugs.webkit.org/show_bug.cgi?id=187973
2361
2362         Reviewed by Alex Christensen.
2363
2364         In LayoutTests, test names have been canonicalized in Unix style
2365         since Bug 63597, for example 'fast/css/001.html'. But Bug 179219,
2366         Bug 179572, Bug 180660, and Bug 181814 have changed to use
2367         os.path.seq instead of slash if Windows Python is used.
2368
2369         Revert parts of those changes. Change relative_test_filename to
2370         return a slash-separated test name as chromium_win.py used to do.
2371
2372         This change fixes all 41 test-webkitpy failures in WinCairo port.
2373
2374         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2375         (TestExpectationParser._parse_line): Do not convert test names with normpath.
2376         * Scripts/webkitpy/port/base.py:
2377         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
2378         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
2379         (Port.abspath_for_test): Replace self.TEST_PATH_SEPARATOR with self.host.filesystem.sep.
2380         * Scripts/webkitpy/port/driver.py:
2381         (Driver): Use '/' instead of os.sep.
2382         * Scripts/webkitpy/port/win.py:
2383         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
2384
2385 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
2386
2387         [ews-build] Add build step to run WK1 layout-test
2388         https://bugs.webkit.org/show_bug.cgi?id=188498
2389
2390         Reviewed by Lucas Forschler.
2391
2392         * BuildSlaveSupport/ews-build/steps.py:
2393         (RunWebKit1Tests): Class to run WebKit1Tests.
2394         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2395
2396 2018-08-14  Patrick Griffis  <pgriffis@igalia.com>
2397
2398         [Flatpak] Fix --cmakeargs
2399         https://bugs.webkit.org/show_bug.cgi?id=188567
2400
2401         Reviewed by Michael Catanzaro.
2402
2403         * flatpak/flatpakutils.py:
2404         (WebkitFlatpak.setup_dev_env):
2405
2406 2018-08-14  Darshan Kadu  <dkadu@igalia.com>
2407
2408         Enhancement request: Make export-w3c-test-changes add the PR to "See Also" links
2409         https://bugs.webkit.org/show_bug.cgi?id=186140
2410
2411         Reviewed by Youenn Fablet.
2412
2413         Added an optional parameter see_also to post_comment_to_bug function and used it for adding see_also variable's content in "See Also"
2414         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2415         (Bugzilla.post_comment_to_bug):
2416         Modified mock for see_also parameter
2417         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2418         (MockBugzilla.post_comment_to_bug):
2419         Made following unit tests to have see_also in bug comment
2420         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2421         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2422         (SheriffTest.test_post_blame_comment_on_bug):
2423         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2424         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2425         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2426         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2427         * Scripts/webkitpy/w3c/test_exporter.py:
2428         (WebPlatformTestExporter.make_pull_request):
2429         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2430         (TestExporterTest.MockBugzilla.post_comment_to_bug):
2431         (TestExporterTest.test_export):
2432
2433 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
2434
2435         [ews-build] Add support for max_builds parameter for workers
2436         https://bugs.webkit.org/show_bug.cgi?id=188531
2437
2438         Reviewed by Lucas Forschler.
2439
2440         * BuildSlaveSupport/ews-build/loadConfig.py:
2441         (loadBuilderConfig): Added support for max_builds.
2442
2443 2018-08-14  Zalan Bujtas  <zalan@apple.com>
2444
2445         [LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
2446         https://bugs.webkit.org/show_bug.cgi?id=188543
2447
2448         Reviewed by Antti Koivisto.
2449
2450         * LayoutReloaded/misc/LFC-passing-tests.txt:
2451
2452 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2453
2454         Unreviewed. Fix WebDriver tests after r234839.
2455
2456         New pytest requires to autoinstall more_itertools and six too.
2457
2458         * Scripts/webkitpy/thirdparty/__init__.py:
2459         (AutoinstallImportHook._install_pytest):
2460
2461 2018-08-14  Tomas Popela  <tpopela@redhat.com>
2462
2463         [GTK] Minibrowser: Add labels for buttons
2464         https://bugs.webkit.org/show_bug.cgi?id=188549
2465
2466         Reviewed by Carlos Garcia Campos.
2467
2468         So they are accessible easier (i.e. while testing WebKitGTK+ through Minibrowser in Dogtail).
2469
2470         * MiniBrowser/gtk/BrowserWindow.c:
2471         (webViewIsLoadingChanged):
2472         (browserWindowSetupEditorToolbar):
2473         (browser_window_init):
2474
2475 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2476
2477         Unreviewed. Fix WebDriver tests after r234839.
2478
2479         New pytest requires to autoinstall atomicwrites too.
2480
2481         * Scripts/webkitpy/thirdparty/__init__.py:
2482         (AutoinstallImportHook._install_pytest):
2483
2484 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2485
2486         Unreviewed. Fix WebDriver tests after r234839.
2487
2488         New pytest requires to autoinstall pluggy and funcsigs too.
2489
2490         * Scripts/webkitpy/thirdparty/__init__.py:
2491         (AutoinstallImportHook._install_pytest):
2492
2493 2018-08-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2494
2495         Unreviewed. Update W3C WebDriver imported tests.
2496
2497         Bump pytest version to 3.6.2.
2498
2499         * Scripts/webkitpy/thirdparty/__init__.py:
2500         (AutoinstallImportHook._install_pytest):
2501
2502 2018-08-13  Thomas Denney  <tdenney@apple.com>
2503
2504         Allow the substring 'me' in contributor names and email addresses
2505         https://bugs.webkit.org/show_bug.cgi?id=188538
2506
2507         Reviewed by Tim Horton.
2508
2509         A test didn't permit the string "me" in email addresses or names of contributors.
2510
2511         * Scripts/webkitpy/common/config/committers_unittest.py:
2512         (CommittersTest.test_contributors_by_fuzzy_match):
2513
2514 2018-08-13  Commit Queue  <commit-queue@webkit.org>
2515
2516         Unreviewed, rolling out r234812.
2517         https://bugs.webkit.org/show_bug.cgi?id=188536
2518
2519         broke the build (Requested by ThomasDenney on #webkit).
2520
2521         Reverted changeset:
2522
2523         "Added Thomas Denney to contributors.json."
2524         https://bugs.webkit.org/show_bug.cgi?id=188525
2525         https://trac.webkit.org/changeset/234812
2526
2527 2018-08-13  Sihui Liu  <sihui_liu@apple.com>
2528
2529         Avoid timeout resulted from calling waitUntilDone when test is not running
2530         https://bugs.webkit.org/show_bug.cgi?id=188389
2531
2532         Reviewed by Chris Dumez.
2533
2534         If test is not running, we should not set the waitUntilDone flag, or it may cause subsequent tests timeout.
2535
2536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2537         (WTR::TestRunner::waitUntilDone):
2538
2539 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2540
2541         [WK2] [macOS] Implement a mechanism to test drag and drop
2542         https://bugs.webkit.org/show_bug.cgi?id=181898
2543         <rdar://problem/39181698>
2544
2545         Reviewed by Simon Fraser.
2546
2547         Implements the currently stubbed DragAndDropSimulator on macOS, and introduces a new API test for r227266. See
2548         comments below for more detail.
2549
2550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2551         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
2552
2553         Introduce a file for cross-platform drag and drop tests, currently for iOS and macOS. Additionally add a test
2554         for r227266, which was fixed earlier this year but could not be tested due to a lack of testing mechanism on
2555         macOS in WebKit2.
2556
2557         (TEST):
2558         * TestWebKitAPI/Tests/WebKitCocoa/full-page-dropzone.html: Added.
2559
2560         Minor tweaks to this test page to add "dragover" and "drop" event handlers.
2561
2562         * TestWebKitAPI/Tests/WebKitCocoa/image-in-link-and-input.html:
2563         * TestWebKitAPI/Tests/WebKitCocoa/link-in-iframe-and-input.html: Added.
2564
2565         Add a new test page that includes a link embedded within an iframe below a plain text input.
2566
2567         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm: Added.
2568         (TEST):
2569         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm.
2570
2571         Move only existing WebKit2 macOS drag and drop test (DragAndDropPasteboardTests.NumberOfValidItemsForDrop) out
2572         of DragAndDropPasteboardTests.mm and into a new file, DragAndDropTestsMac.mm. Additionally, rename
2573         DragAndDropPasteboardTests to LegacyDragAndDropTests, since it now only contains two legacy WebView tests for
2574         drag and drop.
2575
2576         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
2577         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
2578         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
2579         (-[DragSource draggingSourceOperationMaskForLocal:]):
2580         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
2581         (-[DragInfo lastMousePosition]):
2582         (-[DragInfo setLastMousePosition:]):
2583         (-[DragInfo draggingDestinationWindow]):
2584         (-[DragInfo draggingSourceOperationMask]):
2585         (-[DragInfo draggingLocation]):
2586         (-[DragInfo draggedImageLocation]):
2587         (-[DragInfo draggedImage]):
2588         (-[DragInfo draggingPasteboard]):
2589         (-[DragInfo draggingSource]):
2590         (-[DragInfo draggingSequenceNumber]):
2591         (-[DragInfo slideDraggedImageTo:]):
2592         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
2593         (-[DragInfo draggingFormation]):
2594         (-[DragInfo setDraggingFormation:]):
2595         (-[DragInfo animatesToDestination]):
2596         (-[DragInfo setAnimatesToDestination:]):
2597         (-[DragInfo numberOfValidItemsForDrop]):
2598         (-[DragInfo setNumberOfValidItemsForDrop:]):
2599         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2600         (-[DragInfo springLoadingHighlight]):
2601         (-[DragInfo resetSpringLoading]):
2602         (TestWebKitAPI::getTestImage):
2603         (TestWebKitAPI::webViewAfterPerformingDragOperation):
2604         (TestWebKitAPI::TEST):
2605         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Removed.
2606         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2607
2608         Flesh out some of the DragAndDropSimulator API for macOS, exposing (among other things) the drag pasteboard,
2609         the current NSDraggingInfo, the initial location of the drag image, and the drag image itself.
2610
2611         * TestWebKitAPI/cocoa/TestWKWebView.h:
2612         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2613         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2614         (-[TestWKWebView mouseUpAtPoint:]):
2615         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
2616         (-[TestWKWebView sendClicksAtPoint:numberOfClicks:]):
2617         (-[TestWKWebView mouseEnterAtPoint:]):
2618         (-[TestWKWebView mouseExitAtPoint:]):
2619         (-[TestWKWebView mouseDragToPoint:]):
2620         (-[TestWKWebView _mouseEventWithType:atLocation:]):
2621         (-[TestWKWebView _mouseEventWithType:atLocation:flags:timestamp:clickCount:]):
2622
2623         Add TestWKWebView helpers to send MouseMove, MouseEnter and MouseDrag NSEvents to the web view. Additionally,
2624         rename parameter names to these helpers to make it more obvious that these locations are all in NSWindow
2625         coordinates.
2626
2627         (-[TestWKWebView typeCharacter:]):
2628
2629         Drive-by style fix: put this opening brace on the beginning of the next line.
2630
2631         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2632         (-[DragAndDropSimulator initWithWebViewFrame:]):
2633         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2634         (-[DragAndDropSimulator webView]):
2635
2636         Small iOS DragAndDropSimulator adjustments for new DragAndDropSimulator interfaces.
2637
2638         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2639         (-[DragAndDropTestWKWebView initWithFrame:configuration:simulator:]):
2640
2641         Introduce a WKWebView subclass for testing drag and drop that overrides `-dragImage:at:offset:…`, and instead
2642         allows DragAndDropSimulator to take over the drag.
2643
2644         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2645
2646         Override this entry point into drag and drop code, and instead call out to the DragAndDropSimulator to
2647         coordinate the drag.
2648
2649         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]):
2650
2651         Helper method to wait for the web process to finish handling all in-flight mouse events.
2652
2653         (defaultExternalDragImage):
2654
2655         Set this image as the default drag image when simulating an incoming drag session from outside of the web view.
2656
2657         (-[DragAndDropSimulator initWithWebViewFrame:]):
2658         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2659         (-[DragAndDropSimulator flipAboutXAxisInHostWindow:]):
2660
2661         Helper method to flip a given point about the X axis of the window.
2662
2663         (-[DragAndDropSimulator locationInViewForCurrentProgress]):
2664
2665         Map a progress value (between 0 and 1) to a drag location.
2666
2667         (-[DragAndDropSimulator initialProgressForMouseDrag]):
2668
2669         Determines the initial progress value when initiation a drag in web content. This is the initial progress
2670         required to ensure that the first mouse drag event exceeds the drag distance hysteresis and causes any drag
2671         (if applicable) to begin.
2672
2673         (-[DragAndDropSimulator runFrom:to:]):
2674         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
2675
2676         Helper to coordinate drag updates in both the cases where we're simulating a drag session entering from outside
2677         of the web view, and in the case where we've initiated a drag from the web view itself.
2678
2679         (-[DragAndDropSimulator webView]):
2680         (-[DragAndDropSimulator setExternalDragPasteboard:]):
2681         (-[DragAndDropSimulator externalDragPasteboard]):
2682
2683         Just like its iOS counterpart (setExternalItemProviders:), setting an external drag pasteboard on macOS puts the
2684         DragAndDropSimulator in a mode that simulates a drag coming in from outside the web view, using the given
2685         pasteboard.
2686
2687         (-[DragAndDropSimulator setExternalDragImage:]):
2688         (-[DragAndDropSimulator externalDragImage]):
2689
2690         May be optionally set when specifying an external drag pasteboard to specify the drag image used. If no external
2691         drag image is specified, falls back to the default image returned by `defaultExternalDragImage()`.
2692
2693         (-[DragAndDropSimulator draggingInfo]):
2694         (-[DragAndDropSimulator willEndDraggingHandler]):
2695         (-[DragAndDropSimulator setWillEndDraggingHandler:]):
2696
2697         Hook to allow tests to run logic right before performing the drop (if the current drag operation is not none) or
2698         ending the drag session without performing a drag operation.
2699
2700         (-[DragAndDropSimulator initWithWebView:]): Deleted.
2701         (-[DragAndDropSimulator dealloc]): Deleted.
2702         (-[DragAndDropSimulator phase]): Deleted.
2703         * TestWebKitAPI/mac/TestDraggingInfo.h: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
2704         * TestWebKitAPI/mac/TestDraggingInfo.mm: Added.
2705
2706         Mock object conforming to NSDraggingInfo that is passed to WKWebView when invoking -draggingUpdated:,
2707         -draggingEntered: and -draggingExited:.
2708
2709         (-[TestDraggingInfo draggingPasteboard]):
2710         (-[TestDraggingInfo setDraggingPasteboard:]):
2711         (-[TestDraggingInfo draggingSource]):
2712         (-[TestDraggingInfo setDraggingSource:]):
2713         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2714         (-[TestDraggingInfo draggingDestinationWindow]):
2715         (-[TestDraggingInfo draggedImage]):
2716         (-[TestDraggingInfo setDraggedImage:]):
2717         (-[TestDraggingInfo slideDraggedImageTo:]):
2718         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
2719         (-[TestDraggingInfo resetSpringLoading]):
2720
2721         Empty method stubs, to be implemented in the future as needed.
2722
2723 2018-08-13  Thomas Denney  <tdenney@apple.com>
2724
2725         Added Thomas Denney to contributors.json.
2726         https://bugs.webkit.org/show_bug.cgi?id=188525
2727
2728         Reviewed by Myles C. Maxfield.
2729
2730         * Scripts/webkitpy/common/config/contributors.json:
2731
2732 2018-08-13  Antti Koivisto  <antti@apple.com>
2733
2734         Meaning of OptionSet::contains is unclear when used with OptionSet argument
2735         https://bugs.webkit.org/show_bug.cgi?id=188501
2736
2737         Reviewed by Anders Carlsson.
2738
2739         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2740         (TestWebKitAPI::TEST):
2741
2742 2018-08-13  Commit Queue  <commit-queue@webkit.org>
2743
2744         Unreviewed, rolling out r234747.
2745         https://bugs.webkit.org/show_bug.cgi?id=188524
2746
2747         plugin processes crash on launch (Requested by smfr on
2748         #webkit).
2749
2750         Reverted changeset:
2751
2752         "We should cache the compiled sandbox profile in a data vault"
2753         https://bugs.webkit.org/show_bug.cgi?id=184991
2754         https://trac.webkit.org/changeset/234747
2755
2756 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2757
2758         [iOS] Dragging a non-editable text selection into a plain text input inserts HTML markup
2759         https://bugs.webkit.org/show_bug.cgi?id=188485
2760         <rdar://problem/43168784>
2761
2762         Reviewed by Tim Horton.
2763
2764         Add a new API test to verify that dropping selected non-editable rich text into a textarea inserts text as
2765         expected, rather than markup.
2766
2767         It's somewhat interesting to note that this particular use case isn't exercised by any existing tests; the
2768         closest test is DragAndDropTests.ContentEditableToTextarea, which drags a rich text selection from a
2769         contenteditable element to a text area. However, due to logic in `DragController::concludeEditDrag` that handles
2770         drag and drop across editable content differently than drag and drop from non-editable to editable content, the
2771         bug that is fixed here doesn't surface in that existing test.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         * TestWebKitAPI/Tests/WebKitCocoa/selected-text-and-textarea.html: Added.
2775         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2776         (TestWebKitAPI::TEST):
2777
2778 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2779
2780         Use a 1-byte enum class for TextDirection
2781         https://bugs.webkit.org/show_bug.cgi?id=188350
2782
2783         Reviewed by Simon Fraser.
2784
2785         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2786         (TestWebKitAPI::TEST_F):
2787         * TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:
2788         (WebCore::operator<<):
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2791         (TEST_F):
2792
2793 2018-08-13  Zalan Bujtas  <zalan@apple.com>
2794
2795         [LFC][Floating] Add basic clearance support
2796         https://bugs.webkit.org/show_bug.cgi?id=188492
2797
2798         Reviewed by Antti Koivisto.
2799
2800         * LayoutReloaded/misc/LFC-passing-tests.txt:
2801
2802 2018-08-12  Zalan Bujtas  <zalan@apple.com>
2803
2804         [LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
2805         https://bugs.webkit.org/show_bug.cgi?id=188487
2806
2807         Reviewed by Antti Koivisto.
2808
2809         * LayoutReloaded/misc/LFC-passing-tests.txt:
2810
2811 2018-08-11  Aakash Jain  <aakash_jain@apple.com>
2812
2813         [ews-build] Separate queues for Builders and Testers - iOS
2814         https://bugs.webkit.org/show_bug.cgi?id=188396
2815
2816         Reviewed by Lucas Forschler.
2817
2818         * BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
2819         Also added ews121 and ews122 to match with current EWS configuration.
2820         * BuildSlaveSupport/ews-build/factories.py:
2821         (TestsFactory): Base classes for various Test factories.
2822         (TestsFactory.getProduct): Download and extract the archive.
2823
2824 2018-08-10  Daniel Bates  <dabates@apple.com>
2825
2826         webkit-patch setup-git-clone should set Git core editor to commit-log-editor
2827         https://bugs.webkit.org/show_bug.cgi?id=188473
2828
2829         Reviewed by Ryosuke Niwa.
2830
2831         Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
2832         so that the Git commit message is generated from the ChangeLog for developers that manually
2833         generate their ChangeLog using prepare-ChangeLog.
2834
2835         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2836         (SetupGitClone.execute):
2837
2838 2018-08-10  Truitt Savell  <tsavell@apple.com>
2839
2840         Unreviewed, rolling out r234749.
2841
2842         Caused all perf tests to fail in Sierra
2843
2844         Reverted changeset:
2845
2846         "[webkitpy][Win] LayoutTests: test names should be Unix style,
2847         separated by slash not backslash"
2848         https://bugs.webkit.org/show_bug.cgi?id=187973
2849         https://trac.webkit.org/changeset/234749
2850
2851 2018-08-10  David Fenton  <david_fenton@apple.com>
2852
2853         Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
2854         https://bugs.webkit.org/show_bug.cgi?id=188470.
2855
2856         Unreviewed test gardening, disabling the tests.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2859         (TEST_F):
2860
2861 2018-08-10  Joseph Pecoraro  <pecoraro@apple.com>
2862
2863         Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
2864         https://bugs.webkit.org/show_bug.cgi?id=188458
2865
2866         Reviewed by Alex Christensen.
2867
2868         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2869         (TestExpectationParser):
2870         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2871
2872 2018-08-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2873
2874         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
2875         https://bugs.webkit.org/show_bug.cgi?id=187973
2876
2877         Reviewed by Alex Christensen.
2878
2879         In LayoutTests, test names have been canonicalized in Unix style
2880         since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
2881         Bug 179572, Bug 180660 and Bug 181814 have changed to use
2882         os.path.seq instead of slash if Windows Python is used.
2883
2884         Revert parts of those changes. Change relative_test_filename to
2885         return a slash sperated test name as well as chromium_win.py used
2886         to do.
2887
2888         This change fixes all 41 test-webkitpy failures in WinCairo port.
2889
2890         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2891         (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
2892         * Scripts/webkitpy/port/base.py:
2893         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
2894         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
2895         (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
2896         * Scripts/webkitpy/port/driver.py:
2897         (Driver): Use '/' instead of os.sep.
2898         * Scripts/webkitpy/port/win.py:
2899         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
2900
2901 2018-08-09  Thomas Denney  <tdenney@apple.com>
2902
2903         [WHLSL] Add individual test durations to output
2904         https://bugs.webkit.org/show_bug.cgi?id=188448
2905
2906         Reviewed by Myles C. Maxfield.
2907
2908         * WebGPUShadingLanguageRI/Test.js: Add timing output.
2909
2910 2018-08-09  Ben Richards  <benton_richards@apple.com>
2911
2912         We should cache the compiled sandbox profile in a data vault
2913         https://bugs.webkit.org/show_bug.cgi?id=184991
2914
2915         Reviewed by Ryosuke Niwa.
2916
2917         Added trace points for sandbox initialization
2918
2919         * Tracing/SystemTracePoints.plist:
2920
2921 2018-08-09  Jer Noble  <jer.noble@apple.com>
2922
2923         Video playback is using more power
2924         https://bugs.webkit.org/show_bug.cgi?id=188452
2925         <rdar://problem/42298937>
2926
2927         Reviewed by Eric Carlson.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2930         (PreferredAudioBufferSize::createView):
2931         (PreferredAudioBufferSize::preferredAudioBufferSize const):
2932         (TEST_F):
2933
2934 2018-08-09  Alex Christensen  <achristensen@webkit.org>
2935
2936         REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
2937         https://bugs.webkit.org/show_bug.cgi?id=188453
2938         <rdar://problem/43102553>
2939
2940         Reviewed by Chris Dumez
2941
2942         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2943         (TEST):
2944         (+[NullLookupContext sharedLookupContext]):
2945         (TestWebKitAPI::TEST): Deleted.
2946
2947 2018-08-09  Alex Christensen  <achristensen@webkit.org>
2948
2949         WKURLSchemeHandler crashes when sent errors with sync XHR
2950         https://bugs.webkit.org/show_bug.cgi?id=188358
2951
2952         Reviewed by Chris Dumez.
2953
2954         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2955         (-[SyncErrorScheme webView:startURLSchemeTask:]):
2956         (-[SyncErrorScheme webView:stopURLSchemeTask:]):
2957         (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2958
2959 2018-08-09  Per Arne Vollan  <pvollan@apple.com>
2960
2961         REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
2962         https://bugs.webkit.org/show_bug.cgi?id=188397
2963
2964         Reviewed by Tim Horton.
2965
2966         After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
2967         user defaults related to scrollbars in the UI process as we do in the WebProcess.
2968
2969         * WebKitTestRunner/mac/main.mm:
2970         (setDefaultsToConsistentValuesForTesting):
2971
2972 2018-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2973
2974         [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
2975         https://bugs.webkit.org/show_bug.cgi?id=188439
2976
2977         Reviewed by Andy Estes and Megan Gardner.
2978
2979         Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
2980         macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
2981         DragAndDropTests.
2982
2983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2984         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2985         (TestWebKitAPI::TEST):
2986         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
2987         (testIconImage):
2988         (testZIPArchive):
2989         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2990         (-[TestWKWebView editorContainsImageElement]):
2991         (-[TestWKWebView editorValue]):
2992         (makeCGRectValue):
2993         (checkCGRectIsEqualToCGRectWithLogging):
2994         (checkSelectionRectsWithLogging):
2995         (checkRichTextTypePrecedesPlainTextType):
2996         (checkFirstTypeIsPresentAndSecondTypeIsMissing):
2997         (checkTypeIdentifierIsRegisteredAtIndex):
2998         (checkEstimatedSize):
2999         (checkSuggestedNameAndEstimatedSize):
3000         (checkStringArraysAreEqual):
3001         (checkDragCaretRectIsContainedInRect):
3002         (checkJSONWithLogging):
3003         (testIconImageData):
3004         (runTestWithTemporaryTextFile):
3005         (runTestWithTemporaryFolder):
3006         (TestWebKitAPI::TEST):
3007         (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
3008         (TestWebKitAPI::testDragAndDropOntoTargetElements):
3009         (TestWebKitAPI::testIconImageData):
3010         * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
3011         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
3012         (-[WKWebView dropInteractionDelegate]):
3013         (-[WKWebView dragInteractionDelegate]):
3014         (-[WKWebView dropInteraction]):
3015         (-[WKWebView dragInteraction]):
3016         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
3017         (-[MockDragDropSession allowsMoveOperation]):
3018         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3019         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3020         (-[MockDragDropSession canLoadObjectsOfClass:]):
3021         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3022         (-[MockDragDropSession items]):
3023         (-[MockDragDropSession setItems:]):
3024         (-[MockDragDropSession addItems:]):
3025         (-[MockDragDropSession locationInView:]):
3026         (-[MockDropSession initWithProviders:location:window:allowMove:]):
3027         (-[MockDropSession isLocal]):
3028         (-[MockDropSession progress]):
3029         (-[MockDropSession setProgressIndicatorStyle:]):
3030         (-[MockDropSession progressIndicatorStyle]):
3031         (-[MockDropSession operationMask]):
3032         (-[MockDropSession localDragSession]):
3033         (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
3034         (-[MockDropSession canCreateItemsOfClass:]):
3035         (-[MockDropSession loadObjectsOfClass:completion:]):
3036         (-[MockDragSession initWithWindow:allowMove:]):
3037         (-[MockDragSession localOperationMask]):
3038         (-[MockDragSession externalOperationMask]):
3039         (-[MockDragSession session]):
3040         (-[MockDragSession localContext]):
3041         (-[MockDragSession setLocalContext:]):
3042         (dragAndDropEventNames):
3043         (-[DragAndDropSimulatorApplication _cancelAllTouches]):
3044         (-[DragAndDropSimulator initWithWebView:]):
3045         (-[DragAndDropSimulator dealloc]):
3046         (-[DragAndDropSimulator _resetSimulatedState]):
3047         (-[DragAndDropSimulator observedEventNames]):
3048         (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
3049         (-[DragAndDropSimulator runFrom:to:]):
3050         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3051         (-[DragAndDropSimulator finalSelectionRects]):
3052         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3053         (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
3054         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3055         (-[DragAndDropSimulator _advanceProgress]):
3056         (-[DragAndDropSimulator _currentLocation]):
3057         (-[DragAndDropSimulator _scheduleAdvanceProgress]):
3058         (-[DragAndDropSimulator sourceItemProviders]):
3059         (-[DragAndDropSimulator externalItemProviders]):
3060         (-[DragAndDropSimulator setExternalItemProviders:]):
3061         (-[DragAndDropSimulator phase]):
3062         (-[DragAndDropSimulator liftPreviews]):
3063         (-[DragAndDropSimulator lastKnownDragCaretRect]):
3064         (-[DragAndDropSimulator waitForInputSession]):
3065         (-[DragAndDropSimulator insertedAttachments]):
3066         (-[DragAndDropSimulator removedAttachments]):
3067         (-[DragAndDropSimulator endDataTransfer]):
3068         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
3069         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
3070         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
3071         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3072         (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
3073         (-[DragAndDropSimulator _webView:didInsertAttachment:]):
3074         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
3075         (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
3076         (-[DragAndDropSimulator _webView:didStartInputSession:]):
3077         * TestWebKitAPI/ios/UIKitSPI.h:
3078         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
3079         (-[DragAndDropSimulator initWithWebView:]):
3080         (-[DragAndDropSimulator dealloc]):
3081         (-[DragAndDropSimulator runFrom:to:]):
3082         (-[DragAndDropSimulator insertedAttachments]):
3083         (-[DragAndDropSimulator removedAttachments]):
3084
3085 2018-08-09  Sihui Liu  <sihui_liu@apple.com>
3086
3087         REGRESSION (r232083): WKWebView loses first-party cookies on iOS
3088         https://bugs.webkit.org/show_bug.cgi?id=188443
3089         <rdar://problem/42991584>
3090
3091         Reviewed by Chris Dumez.
3092
3093         Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
3094
3095         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3096
3097 2018-08-09  Ross Kirsling  <ross.kirsling@sony.com>
3098
3099         Unreviewed follow-up fix for r234720.
3100
3101         * Scripts/webkitpy/bindings/main.py:
3102         (BindingsTests.close_and_remove):
3103         (BindingsTests.main):
3104         Return to the original approach, since this seems to be the simplest cross-platform solution.
3105
3106 2018-08-09  Ali Juma  <ajuma@chromium.org>
3107
3108         Import WPTs for IntersectionObserver
3109         https://bugs.webkit.org/show_bug.cgi?id=188416
3110
3111         Reviewed by Simon Fraser.
3112
3113         Enable IntersectionObserver in DumpRenderTree. 
3114
3115         * DumpRenderTree/mac/DumpRenderTree.mm:
3116         (enableExperimentalFeatures):
3117         (setWebPreferencesForTestOptions):
3118         * WebKitTestRunner/TestController.cpp:
3119         (WTR::TestController::resetPreferencesToConsistentValues):
3120
3121 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
3122
3123         run-bindings-tests is not Win32-compatible
3124         https://bugs.webkit.org/show_bug.cgi?id=188424
3125
3126         Reviewed by Fujii Hironori.
3127
3128         * Scripts/webkitpy/bindings/main.py:
3129         (BindingsTests.main):
3130         Stop leaking file descriptors.
3131         (See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
3132
3133 2018-08-08  Alex Christensen  <achristensen@webkit.org>
3134
3135         Fix possible null dereference in WebBackForwardList::restoreFromState
3136         https://bugs.webkit.org/show_bug.cgi?id=188418
3137         <rdar://problem/42531726>
3138
3139         Reviewed by Chris Dumez.
3140
3141         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3142         (TestWebKitAPI::TEST):
3143
3144 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
3145
3146         run-builtins-generator-tests does not correctly handle CRLFs from stderr
3147         https://bugs.webkit.org/show_bug.cgi?id=188392
3148
3149         Reviewed by Fujii Hironori.
3150
3151         Background:
3152         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
3153
3154         * Scripts/webkitpy/common/system/executive.py:
3155         (Executive.run_command):
3156         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
3157
3158 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
3159
3160         Unreviewed, add myself to committers list.
3161
3162         * Scripts/webkitpy/common/config/contributors.json:
3163
3164 2018-08-08  Commit Queue  <commit-queue@webkit.org>
3165
3166         Unreviewed, rolling out r234314, r234320, and r234321.
3167         https://bugs.webkit.org/show_bug.cgi?id=188414
3168
3169         Caused email sign in issue (Requested by ryanhaddad on
3170         #webkit).
3171
3172         Reverted changesets:
3173
3174         "Remove unused WKNavigationDelegatePrivate
3175         decidePolicyForNavigationAction SPI"
3176         https://bugs.webkit.org/show_bug.cgi?id=188077
3177         https://trac.webkit.org/changeset/234314
3178
3179         "Fix API tests after r234314"
3180         https://bugs.webkit.org/show_bug.cgi?id=188077
3181         https://trac.webkit.org/changeset/234320
3182
3183         "Fix API tests after r234314"
3184         https://bugs.webkit.org/show_bug.cgi?id=188077
3185         https://trac.webkit.org/changeset/234321
3186
3187 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
3190         https://bugs.webkit.org/show_bug.cgi?id=188401
3191         <rdar://problem/32542300>
3192
3193         Reviewed by Ryosuke Niwa.
3194
3195         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
3196         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
3197         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
3198         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
3199         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
3200         skip over one of the steps in the layout test, resulting in a text diff failure.
3201
3202         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
3203         as a part of resetting test controller state, before moving on to the next layout test.
3204
3205         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3206         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3207         (-[TestRunnerWKWebView didStartFormControlInteraction]):
3208         (-[TestRunnerWKWebView didEndFormControlInteraction]):
3209
3210         Use these hooks to keep track of whether the previous test is presenting any form input UI.
3211
3212         (-[TestRunnerWKWebView isInteractingWithFormControl]):
3213         * WebKitTestRunner/ios/TestControllerIOS.mm:
3214         (WTR::handleKeyboardWillHideNotification):
3215         (WTR::handleKeyboardDidHideNotification):
3216         (WTR::TestController::platformInitialize):
3217         (WTR::TestController::platformDestroy):
3218
3219         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
3220         of when the keyboard dismissal animation ends.
3221
3222         (WTR::TestController::platformResetStateToConsistentValues):
3223
3224         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
3225         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
3226         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
3227
3228 2018-08-05  Darin Adler  <darin@apple.com>
3229
3230         [Cocoa] More tweaks and refactoring to prepare for ARC
3231         https://bugs.webkit.org/show_bug.cgi?id=188245
3232
3233         Reviewed by Dan Bernstein.
3234
3235         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
3236         CFTypeRef instead of void*.
3237
3238         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3239         (createCoreAnimationLayer): Use CFBridgingRetain.
3240
3241         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3242         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
3243         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
3244         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
3245         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
3246         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
3247         (AccessibilityUIElement::indexForTextMarker): Ditto.
3248         (AccessibilityUIElement::textMarkerForIndex): Ditto.
3249         (AccessibilityUIElement::isTextMarkerValid): Ditto.
3250         (AccessibilityUIElement::previousTextMarker): Ditto.
3251         (AccessibilityUIElement::nextTextMarker): Ditto.
3252         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
3253         (createJSStringRef): Ditto.
3254         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
3255         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
3256         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
3257         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
3258         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
3259         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
3260         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
3261         (AccessibilityUIElement::textMarkerForPoint): Ditto.
3262         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
3263         (AccessibilityUIElement::startTextMarker): Ditto.
3264         (AccessibilityUIElement::endTextMarker): Ditto.
3265         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
3266         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
3267         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
3268         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
3269         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
3270         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
3271         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
3272         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
3273         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
3274         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
3275         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
3276
3277         * DumpRenderTree/mac/DumpRenderTree.mm:
3278         (resetWebPreferencesToConsistentValues): Use bridging cast.
3279         (dumpFramesAsText): Ditto.
3280         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
3281         CFArray functions to iterate the array.
3282         (dump): Use bridging cast.
3283         (runTest): Ditto.
3284
3285         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3286         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
3287         (toUTI): Return a RetainPtr<CFStringRef>.
3288         (-[LocalPasteboard types]): Use the above and bridging casts.
3289         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
3290         (-[LocalPasteboard setData:forType:]): Ditto.
3291         (-[LocalPasteboard dataForType:]): Ditto.
3292         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
3293         instead of CFPropertyList.
3294         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
3295         CFStringCreateExternalRepresentation.
3296
3297         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
3298         instead of an Objective-C object pointer type.
3299         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3300         (-[MockGeolocationProvider registerWebView:]): Update for above.
3301         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
3302         (-[MockGeolocationProvider timerFired]): Ditto.
3303
3304         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
3305         HashMap and HashSet instead of an Objective-C object pointer type.
3306         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3307         (-[MockWebNotificationProvider registerWebView:]): Update for above.
3308         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
3309         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
3310         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
3311         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
3312
3313         * DumpRenderTree/mac/ObjCPlugin.m:
3314         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
3315
3316         * DumpRenderTree/mac/TestRunnerMac.mm:
3317         (TestRunner::addDisallowedURL): Use bridging cast.
3318         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
3319         (TestRunner::clearApplicationCacheForOrigin): Ditto.
3320         (originsArrayToJS): Ditto.
3321         (TestRunner::copyDecodedHostName): Ditto.
3322         (TestRunner::copyEncodedHostName): Ditto.
3323         (TestRunner::queueLoad): Ditto.
3324         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
3325         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
3326         (TestRunner::setUserStyleSheetLocation): Ditto.
3327         (TestRunner::setValueForUser): Ditto.
3328         (TestRunner::overridePreference): Ditto.
3329         (TestRunner::execCommand): Ditto.
3330         (TestRunner::findString): Ditto.
3331         (TestRunner::isCommandEnabled): Ditto.
3332         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
3333         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
3334         (TestRunner::addUserScript): Ditto.
3335         (TestRunner::addUserStyleSheet): Ditto.
3336         (TestRunner::evaluateInWebInspector): Ditto.
3337         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3338         (TestRunner::authenticateSession): Ditto.
3339         (TestRunner::grantWebNotificationPermission): Ditto.
3340         (TestRunner::denyWebNotificationPermission): Ditto.
3341         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3342         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
3343
3344         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3345         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
3346         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
3347         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
3348         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
3349         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
3350         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
3351         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
3352         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
3353         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
3354         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
3355         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
3356         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
3357         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
3358         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
3359         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
3360         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
3361         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
3362         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
3363         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
3364         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
3365         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
3366         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
3367         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
3368         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
3369
3370         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
3371         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
3372
3373         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
3374         so we can use the type and know it inherits from NSWindow.
3375
3376         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
3377         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
3378         class into a separate file.
3379         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
3380         instead of have a second copy of the implementation.
3381
3382         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
3383         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
3384         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
3385
3386         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
3387         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
3388         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
3389         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
3390         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
3391         instead of CFPropertyList.
3392         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
3393         CFStringCreateExternalRepresentation.
3394
3395         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
3396         WebKitTestRunnerWindow here so it can be included by files that need to know
3397         what the type is and that it inherits from NSWindow.
3398
3399         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
3400         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
3401         messier implementation.
3402
3403 2018-08-07  Alex Christensen  <achristensen@webkit.org>
3404
3405         Add a test for using SafeBrowsing
3406         https://bugs.webkit.org/show_bug.cgi?id=188290
3407
3408         Reviewed by Chris Dumez.
3409
3410         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
3411         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
3412
3413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3414         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
3415         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
3416         (TestWebKitAPI::TEST):
3417
3418 2018-08-07  Lucas Forschler  <lforschler@apple.com>
3419
3420         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
3421         https://bugs.webkit.org/show_bug.cgi?id=188235
3422
3423         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
3424
3425         * Scripts/webkitpy/common/checkout/changelog.py: 
3426         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
3427         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
3428         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3429         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
3430         * Scripts/webkitpy/tool/commands/upload.py:
3431         (Upload): Teach the upload step how to add radar information when creating a new bug.
3432         * Scripts/webkitpy/tool/steps/__init__.py:
3433         * Scripts/webkitpy/tool/steps/addradar.py: Added.
3434         (AddRadar):
3435         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
3436         * Scripts/webkitpy/tool/steps/createbug.py:
3437         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
3438
3439 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3440
3441         Post-review feedback after r234614.
3442         https://bugs.webkit.org/show_bug.cgi?id=188322
3443         <rdar://problem/42455270>
3444
3445         Reviewed by Sam Weinig.
3446
3447         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
3448
3449         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3450         (rounded):
3451
3452 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
3453
3454         [MiniBrowser][Win] Allow selection of recent user agents
3455         https://bugs.webkit.org/show_bug.cgi?id=188371
3456
3457         Reviewed by Fujii Hironori.
3458
3459         Updates the user agent spoofing strings to the latest released
3460         versions and adds Microsoft Edge's user agent.
3461
3462         Moves the menu item selection to the common base class, BrowserWindow
3463         to support user agent spoofing in a WebKitLegacyBrowserWindow and
3464         WebKitBrowserWindow.
3465
3466         * MiniBrowser/win/BrowserWindow.cpp: Added.
3467         (BrowserWindow::setUserAgent):
3468         * MiniBrowser/win/BrowserWindow.h:
3469         * MiniBrowser/win/CMakeLists.txt:
3470         * MiniBrowser/win/MainWindow.cpp:
3471         (MainWindow::toggleMenuItem):
3472         * MiniBrowser/win/MiniBrowserLib.rc:
3473         * MiniBrowser/win/MiniBrowserLibResource.h:
3474         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3475         * MiniBrowser/win/WebKitBrowserWindow.h:
3476         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3477         (WebKitLegacyBrowserWindow::setUserAgent):
3478         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3479
3480 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3481
3482         Unreviewed, add a new address to my configuration
3483
3484         * Scripts/webkitpy/common/config/contributors.json:
3485
3486 2018-08-06  David Quesada  <david_quesada@apple.com>
3487
3488         webkitdirs.pm should default to iPhone SE for 64-bit testing
3489         https://bugs.webkit.org/show_bug.cgi?id=188361
3490
3491         Reviewed by Daniel Bates.
3492
3493         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
3494
3495         * Scripts/webkitdirs.pm:
3496         (findOrCreateSimulatorForIOSDevice):
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3498         (parse_args):
3499             Update the help text for --device-type to reflect the new default device.
3500
3501 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3502
3503         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
3504         https://bugs.webkit.org/show_bug.cgi?id=188322
3505         <rdar://problem/42455270>
3506
3507         Reviewed by Tim Horton.
3508
3509         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
3510         was not in content view coordinates, unlike the x, y, and height.
3511
3512         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3513         (rounded):
3514         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
3515         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
3516         (TestWebKitAPI::TEST):
3517
3518 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
3519
3520         Unreviewed, rolling out r234569.
3521
3522         Breaks internal builds.
3523
3524         Reverted changeset:
3525
3526         "We should cache the compiled sandbox profile in a data vault"
3527         https://bugs.webkit.org/show_bug.cgi?id=184991
3528         https://trac.webkit.org/changeset/234569
3529
3530 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3531
3532         [Win][DLLLauncher] Remove --highDPI switch
3533         https://bugs.webkit.org/show_bug.cgi?id=188255
3534
3535         Reviewed by Yusuke Suzuki.
3536
3537         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
3538         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
3539         became useless since the change. Remove the switch.
3540
3541         This change fixes the issue all dump render tree tests are failing
3542         in WinCairo port if high DPI display is connected.
3543
3544         * MiniBrowser/win/Common.cpp:
3545         (parseCommandLine): Removed `--highDPI` switch.
3546         * win/DLLLauncher/DLLLauncherMain.cpp:
3547         (wWinMain): Do not call SetProcessDPIAware.
3548         (shouldUseHighDPI): Deleted.
3549
3550 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3551
3552         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
3553         https://bugs.webkit.org/show_bug.cgi?id=188335
3554         <rdar://problem/32542437> and <rdar://problem/32542433>
3555
3556         Reviewed by Tim Horton.
3557
3558         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
3559         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
3560         LayoutTests ChangeLog for more detail.
3561
3562         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3563         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3564         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3565         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3566         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3567         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
3568         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3569         * TestRunnerShared/spi/UIKitTestSPI.h:
3570
3571         Remove an internal class declaration that is now unnecessary.
3572
3573         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3574         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
3575         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
3576
3577 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3578
3579         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
3580         https://bugs.webkit.org/show_bug.cgi?id=188322
3581         <rdar://problem/42455270>
3582
3583         Reviewed by Tim Horton.
3584
3585         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
3586         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
3587         selection views are hidden, and when first responder status is restored, both caret and range selection views
3588         are made visible again.
3589
3590         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3591         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3592         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3593         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3594         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3595         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3596         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3597         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3598         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3599         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
3600         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
3601         (webViewWithAutofocusedInput):
3602
3603         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
3604         immediately loading a web page with an autofocusing text field.
3605
3606         (TestWebKitAPI::TEST):
3607         * TestWebKitAPI/cocoa/TestWKWebView.h:
3608         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3609         (-[TestWKWebView caretViewRectInContentCoordinates]):
3610         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
3611         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3612         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3613         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3614
3615 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3616
3617         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
3618         https://bugs.webkit.org/show_bug.cgi?id=188334
3619         <rdar://problem/40630074>
3620
3621         Reviewed by Tim Horton.
3622
3623         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
3624         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
3625         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
3626         it to a completion block, and invoke the completion block to signal that the previous HID event has been
3627         processed.
3628
3629         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
3630         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
3631         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
3632         callback ID because the buffer was clamped to 8 bytes.
3633
3634         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
3635         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
3636         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
3637         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
3638         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
3639         be thrown.
3640
3641         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
3642
3643         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3644         (+[HIDEventGenerator nextEventCallbackID]):
3645         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3646
3647         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
3648
3649 2018-08-03  Ben Richards  <benton_richards@apple.com>
3650
3651         We should cache the compiled sandbox profile in a data vault
3652         https://bugs.webkit.org/show_bug.cgi?id=184991
3653
3654         Reviewed by Ryosuke Niwa.
3655
3656         Added trace points for sandbox initialization
3657
3658         * Tracing/SystemTracePoints.plist:
3659
3660 2018-08-03  David Fenton  <david_fenton@apple.com>
3661
3662         Unreviewed, rolling out r234517.
3663
3664         Caused API test failures on iOS
3665
3666         Reverted changeset:
3667
3668         "[Cocoa] setCookie API fails to set session cookies for
3669         defaultDataStore if processPool created but not used"
3670         https://bugs.webkit.org/show_bug.cgi?id=188209
3671         https://trac.webkit.org/changeset/234517
3672
3673 2018-08-03  Ben Richards  <benton_richards@apple.com>
3674
3675         Add configuration for automatic process pre-warming
3676         https://bugs.webkit.org/show_bug.cgi?id=187108
3677
3678         Reviewed by Ryosuke Niwa.
3679
3680         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
3681
3682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3683         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
3684         (TEST):
3685         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3686         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
3687         (TEST):
3688
3689 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
3690
3691         [ews-build] Add build step to Check Patch Relevance
3692         https://bugs.webkit.org/show_bug.cgi?id=188295
3693
3694         Reviewed by Lucas Forschler.
3695
3696         * BuildSlaveSupport/ews-build/steps.py:
3697         (CheckPatchRelevance): Added step to check patch relevance.
3698         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
3699         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
3700         (CheckPatchRelevance._addToLog): Add the log message.
3701         (CheckPatchRelevance.start):
3702         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
3703
3704 2018-08-03  Jer Noble  <jer.noble@apple.com>
3705
3706         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
3707         media element is paused. Updating the test to reflect the new policy.
3708
3709         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3710         (TestWebKitAPI::TEST):
3711
3712 2018-08-03  Zalan Bujtas  <zalan@apple.com>
3713
3714         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
3715         https://bugs.webkit.org/show_bug.cgi?id=188306
3716
3717         Reviewed by Antti Koivisto.
3718
3719         * LayoutReloaded/misc/LFC-passing-tests.txt:
3720
3721 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3722
3723         [WPE] Use the new key mapper API from WPEBackend
3724         https://bugs.webkit.org/show_bug.cgi?id=188216
3725
3726         Reviewed by Žan Doberšek.
3727
3728         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3729         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
3730         code.
3731         * wpe/backends/WindowViewBackend.cpp:
3732         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3733         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
3734         (WPEToolingBackends::WindowViewBackend::modifiers const):
3735         * wpe/backends/WindowViewBackend.h:
3736
3737 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3738
3739         [WPE] Implement MouseEvent.buttons
3740         https://bugs.webkit.org/show_bug.cgi?id=187998
3741
3742         Reviewed by Žan Doberšek.
3743
3744         Pass modifiers to mouse events.
3745
3746         * WebKitTestRunner/EventSenderProxy.h:
3747         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3748         (WTR::senderButtonToWPEButton):
3749         (WTR::modifierForButton):
3750         (WTR::EventSenderProxy::mouseDown):
3751         (WTR::EventSenderProxy::mouseUp):
3752         (WTR::EventSenderProxy::mouseMoveTo):
3753         (WTR::EventSenderProxy::mouseScrollBy):
3754         (WTR::wkEventModifiersToWPE):
3755         (WTR::wpeKeySymForKeyRef):
3756         (WTR::EventSenderProxy::keyDown):
3757         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3758         * wpe/backends/WindowViewBackend.cpp:
3759         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
3760         (WPEToolingBackends::WindowViewBackend::modifiers const):
3761         * wpe/backends/WindowViewBackend.h:
3762
3763 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3764
3765         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
3766         https://bugs.webkit.org/show_bug.cgi?id=188093
3767
3768         Reviewed by Žan Doberšek.
3769
3770         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
3771         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3772         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
3773         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
3774         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
3775         * wpe/backends/WindowViewBackend.cpp:
3776         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
3777         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
3778
3779 2018-08-02  Nan Wang  <n_wang@apple.com>
3780
3781         AX: [iOS] add support to return the attributed string under the element
3782         https://bugs.webkit.org/show_bug.cgi?id=188276
3783         <rdar://problem/42872357>
3784
3785         Reviewed by Chris Fleizach.
3786
3787         * DumpRenderTree/AccessibilityUIElement.cpp:
3788         (attributedStringForElementCallback):
3789         (AccessibilityUIElement::getJSClass):
3790         * DumpRenderTree/AccessibilityUIElement.h:
3791         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3792         (AccessibilityUIElement::attributedStringForElement):
3793         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3794         (WTR::AccessibilityUIElement::attributedStringForElement):
3795         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3796         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3797         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3798         (WTR::AccessibilityUIElement::attributedStringForElement):
3799
3800 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
3801
3802         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
3803         https://bugs.webkit.org/show_bug.cgi?id=175204
3804
3805         Unreviewed test gardening.
3806
3807         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3808
3809 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
3810
3811         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
3812         https://bugs.webkit.org/show_bug.cgi?id=188209
3813
3814         Reviewed by Geoffrey Garen.
3815
3816         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3817         (TEST):
3818
3819 2018-08-02  Dan Bernstein  <mitz@apple.com>
3820
3821         Fixed WebKit.AttrStyle timing out on build.webkit.org.
3822
3823         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
3824           access to one that doesn’t.
3825         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
3826         (TEST): Updated expected value.
3827
3828 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3829
3830         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
3831         https://bugs.webkit.org/show_bug.cgi?id=188251
3832         <rdar://problem/37842108>
3833
3834         Reviewed by Tim Horton.
3835
3836         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
3837         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
3838
3839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3840         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
3841         (TestWebKitAPI::TEST):
3842         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
3843
3844         Pull some logic used to force an input session to start out from an existing API test file
3845         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
3846         new keyboard input test.
3847
3848         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3849         (-[AutofillTestView initWithFrame:]):
3850         (TestWebKitAPI::TEST):
3851         (-[TestInputDelegate init]): Deleted.
3852         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
3853         * TestWebKitAPI/ios/UIKitSPI.h:
3854
3855         Add some UIKit SPI utilized by the new API test.
3856
3857 2018-08-01  Dan Bernstein  <mitz@apple.com>
3858
3859         Optionally expose Attr::style to JavaScript
3860         https://bugs.webkit.org/show_bug.cgi?id=188226
3861         <rdar://problem/42818113>
3862
3863         Reviewed by Darin Adler.
3864
3865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3866         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
3867         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
3868         (TEST):
3869
3870 2018-08-02  David Fenton  <david_fenton@apple.com>
3871
3872         Unreviewed, rolling out r234489.
3873
3874         Caused 50+ crashes and 60+ API failures on iOS
3875
3876         Reverted changeset:
3877
3878         "[WTF] Rename String::format to String::deprecatedFormat"
3879         https://bugs.webkit.org/show_bug.cgi?id=188191
3880         https://trac.webkit.org/changeset/234489
3881
3882 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
3883
3884         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
3885         https://bugs.webkit.org/show_bug.cgi?id=188244
3886
3887         Reviewed by Daniel Bates.
3888
3889         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
3890
3891         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
3892
3893 2018-08-01  Tomas Popela  <tpopela@redhat.com>
3894
3895         [WTF] Rename String::format to String::deprecatedFormat
3896         https://bugs.webkit.org/show_bug.cgi?id=188191
3897
3898         Reviewed by Darin Adler.
3899
3900         It should be replaced with string concatenation.
3901
3902         * DumpRenderTree/win/DumpRenderTree.cpp:
3903         (applicationId):
3904         (main):
3905         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3906         (TestWebKitAPI::Util::createURLForResource):
3907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3908         (WTR::cacheTestRunnerCallback):
3909         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3910         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3911         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3912         (WTR::AccessibilityUIElement::attributedStringForRange):
3913         (WTR::AccessibilityUIElement::url):
3914         (WTR::stringAtOffset):
3915         * WebKitTestRunner/TestController.cpp:
3916         (WTR::TestController::didReceiveAuthenticationChallenge):
3917         (WTR::TestController::downloadDidFail):
3918         (WTR::originUserVisibleName):
3919         (WTR::userMediaOriginHash):
3920         (WTR::TestController::didNavigateWithNavigationData):
3921         (WTR::TestController::didPerformClientRedirect):
3922         (WTR::TestController::didPerformServerRedirect):
3923         (WTR::TestController::didUpdateHistoryTitle):
3924
3925 2018-08-01  Nan Wang  <n_wang@apple.com>
3926
3927         AX: AOM: Add ARIA IDL Attribute Reflection
3928         https://bugs.webkit.org/show_bug.cgi?id=184676
3929         <rdar://problem/39476882>
3930
3931         Reviewed by Chris Fleizach.
3932
3933         * DumpRenderTree/mac/DumpRenderTree.mm:
3934         (enableExperimentalFeatures):
3935         * WebKitTestRunner/TestController.cpp:
3936         (WTR::TestController::resetPreferencesToConsistentValues):
3937
3938 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
3939
3940         Use iPhone SE as the default simulated device
3941         https://bugs.webkit.org/show_bug.cgi?id=188227
3942
3943         Reviewed by Aakash Jain.
3944
3945         * Scripts/webkitpy/port/ios_simulator.py:
3946         (IOSSimulatorPort):
3947
3948 2018-08-01  Commit Queue  <commit-queue@webkit.org>
3949
3950         Unreviewed, rolling out r234443 and r234445.
3951         https://bugs.webkit.org/show_bug.cgi?id=188224
3952
3953         Revision caused 3 api failures across all platforms.
3954         (Requested by Truitt on #webkit).
3955
3956         Reverted changesets:
3957
3958         "Add configuration for automatic process pre-warming"
3959         https://bugs.webkit.org/show_bug.cgi?id=187108
3960         https://trac.webkit.org/changeset/234443
3961
3962         "Add configuration for automatic process pre-warming"
3963         https://bugs.webkit.org/show_bug.cgi?id=187108
3964         https://trac.webkit.org/changeset/234445
3965
3966 2018-07-31  Ben Richards  <benton_richards@apple.com>
3967
3968         Add configuration for automatic process pre-warming
3969         https://bugs.webkit.org/show_bug.cgi?id=187108
3970
3971         Reviewed by Ryosuke Niwa.
3972
3973         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
3974
3975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3977         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
3978         (TEST):
3979
3980 2018-07-31  John Wilander  <wilander@apple.com>
3981
3982         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
3983         https://bugs.webkit.org/show_bug.cgi?id=188109
3984         <rdar://problem/42664391>
3985
3986         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
3987
3988         This patch removes cookie partitioning which reduces the model to just
3989         blocked cookies (in third-party contexts) and first-party cookie access.
3990
3991         Several of the changes are renaming to reflect that there are no more
3992         cookie partitions.
3993
3994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3995            Removed or renamed functions to reflect that there are no more
3996            partitioned cookies.
3997         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3998         (WTR::InjectedBundle::didReceiveMessageToPage):
3999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4000         (WTR::TestRunner::statisticsUpdateCookieBlocking):
4001         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
4002         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
4003         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
4004         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
4005         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
4006         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
4007         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
4008         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4009         * WebKitTestRunner/TestController.cpp:
4010         (WTR::TestController::statisticsUpdateCookieBlocking):
4011         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
4012         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
4013         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
4014         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
4015         * WebKitTestRunner/TestController.h:
4016         * WebKitTestRunner/TestInvocation.cpp:
4017         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4018         (WTR::TestInvocation::didSetBlockCookiesForHost):
4019         (WTR::TestInvocation::didSetHasHadUserInteraction):
4020         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
4021         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
4022         * WebKitTestRunner/TestInvocation.h:
4023         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4024         (WTR::initializeWebViewConfiguration):
4025
4026 2018-07-31  Alex Christensen  <achristensen@webkit.org>
4027
4028         Build fix.  Remove unused variable.
4029
4030         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
4031         (TestWebKitAPI::TEST):
4032         transform was never used. It was introduced in r205871
4033         Apparently I'm the first one to build in a certain configuration that found it.
4034
4035 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4036
4037         server_process.py should print returncode in debug log if the process crashed
4038         https://bugs.webkit.org/show_bug.cgi?id=188160
4039
4040         Reviewed by Konstantin Tokarev.
4041
4042         * Scripts/webkitpy/port/server_process.py:
4043         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
4044
4045 2018-07-31  Tomas Popela  <tpopela@redhat.com>
4046
4047         [WTF] String::formatWithArguments() is unused
4048         https://bugs.webkit.org/show_bug.cgi?id=187955
4049
4050         Reviewed by Darin Adler.
4051
4052         Remove tests for WTF::String::formatWithArguments() as it's unused and
4053         we are removing it.
4054
4055         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4056
4057 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
4058
4059         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
4060
4061         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
4062         other builders.
4063
4064 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
4065
4066         [ews-build] Add support for API tests in OpenSource EWS
4067         https://bugs.webkit.org/show_bug.cgi?id=188156
4068
4069         Reviewed by Lucas Forschler.
4070
4071         * BuildSlaveSupport/ews-build/config.json:
4072         * BuildSlaveSupport/ews-build/factories.py:
4073         (BuildFactory.__init__): Added triggers parameter.
4074         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
4075         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
4076         (APITestsFactory): Factory for running API tests.
4077         * BuildSlaveSupport/ews-build/steps.py:
4078         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
4079         source of the property.
4080
4081 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
4082
4083         [ews-build] loadConfig should ensure that the triggers are valid
4084         https://bugs.webkit.org/show_bug.cgi?id=188134
4085
4086         Reviewed by Lucas Forschler.
4087
4088         * BuildSlaveSupport/ews-build/loadConfig.py:
4089         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
4090         (checkValidSchedulers): Ensures that the scheduler is not un-used.
4091         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
4092
4093 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4094
4095         Unreviewed, fix typo in test expectations and mark another test as timing out
4096
4097         * TestWebKitAPI/glib/TestExpectations.json:
4098
4099 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4100
4101         More unreviewed GTK test gardening
4102
4103         * TestWebKitAPI/glib/TestExpectations.json:
4104
4105 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
4106
4107         Be more conservative with compositing layer creation when memory is low
4108         https://bugs.webkit.org/show_bug.cgi?id=187866
4109         rdar://problem/42366345
4110
4111         Reviewed by Zalan Bujtas.
4112         
4113         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
4114         compositing layers. We avoid compositing for these situations:
4115         1. Layers with 3D transforms which are affine (like translateZ(0)).
4116         2. Layers with will-change
4117         3. Layers for canvases (other than WebGL/WebGPU)
4118         
4119         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
4120         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
4121         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
4122         
4123         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
4124         flakily falling into a different mode, and so that we can impose the conservative
4125         mode for testing.
4126
4127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4128         (WTR::InjectedBundlePage::prepare):
4129
4130 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4131
4132         Unreviewed GTK test gardening
4133
4134         * TestWebKitAPI/glib/TestExpectations.json:
4135
4136 2018-07-27  Alex Christensen  <achristensen@webkit.org>
4137
4138         Fix API tests after r234314
4139         https://bugs.webkit.org/show_bug.cgi?id=188077
4140
4141         Make API tests use new delegate method.
4142
4143         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4144         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4145         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4146
4147 2018-07-27  Alex Christensen  <achristensen@webkit.org>
4148
4149         Fix API tests after r234314
4150         https://bugs.webkit.org/show_bug.cgi?id=188077
4151
4152         Make API tests use new delegate method.
4153
4154         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4155         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4156         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4157         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4158         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4159         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4160         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4161         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
4162         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.