MiniBrowser WK1 fails to update URL for within-page navigations
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
2
3         MiniBrowser WK1 fails to update URL for within-page navigations
4         https://bugs.webkit.org/show_bug.cgi?id=168173
5
6         Reviewed by Tim Horton.
7         
8         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
9         anchors updates the URL field.
10
11         * MiniBrowser/mac/WK1BrowserWindowController.m:
12         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
13
14 2017-02-10  John Wilander  <wilander@apple.com>
15
16         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
17         https://bugs.webkit.org/show_bug.cgi?id=167474
18         <rdar://problem/24681808>
19         <rdar://problem/24703286>
20         <rdar://problem/30290270>
21
22         This patch adds test infrastructure to allow testing 
23         of the various rules in place for data records removal.
24
25         Reviewed by Andy Estes.
26
27         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
28         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
29         (WTR::InjectedBundle::didReceiveMessageToPage):
30             Callback mechanism to tell pages that a website data store
31             scan has happened.
32         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
33         (WTR::TestRunner::setStatisticsPrevalentResource):
34         (WTR::TestRunner::isStatisticsPrevalentResource):
35         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
36         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
37         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
38         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
39         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
40         (WTR::TestRunner::statisticsFireDataModificationHandler):
41         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
42         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
43         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
44         (WTR::TestRunner::statisticsResetToConsistentState):
45         * WebKitTestRunner/InjectedBundle/TestRunner.h:
46         * WebKitTestRunner/TestController.cpp:
47         (WTR::TestController::setStatisticsPrevalentResource):
48         (WTR::TestController::isStatisticsPrevalentResource):
49         (WTR::TestController::setStatisticsHasHadUserInteraction):
50         (WTR::TestController::isStatisticsHasHadUserInteraction):
51         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
52         (WTR::TestController::statisticsFireDataModificationHandler):
53         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
54         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
55         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
56         (WTR::TestController::statisticsResetToConsistentState):
57         * WebKitTestRunner/TestController.h:
58             These are all configuration and test functions.
59         * WebKitTestRunner/TestInvocation.cpp:
60         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
61
62 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
63
64         REGRESSION(r182916) run-perf-tests never timeouts
65         https://bugs.webkit.org/show_bug.cgi?id=167626
66
67         Reviewed by Ryosuke Niwa.
68
69         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
70         was beeing ignored because the driver was created with no_timeout=True
71         unconditionally.
72         This adds a new parameter --no-timeout (disabled by default), that
73         allows to use the driver with the expected timeout values.
74         It also passes --no-timeout to DRT/WTR to ensure that timeouts
75         are always controlled by the Python Driver.
76
77         * Scripts/webkitpy/performance_tests/perftest.py:
78         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
79         (PerfTest.run): Disabling timeout should be done when the Driver is created.
80         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
81         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
82         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
83         (_run_tests_set): Pass the no-timeout parameter.
84         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
85         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
86         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
87         (MainTest.test_parse_args): Test that the argument no-timeout.
88
89 2017-02-10  Daniel Bates  <dabates@apple.com>
90
91         Detach frame from document when entering page cache
92         https://bugs.webkit.org/show_bug.cgi?id=166774
93         <rdar://problem/29904368>
94
95         Reviewed by Chris Dumez.
96
97         * DumpRenderTree/mac/DumpRenderTree.mm:
98         (resetWebPreferencesToConsistentValues):
99         * DumpRenderTree/win/DumpRenderTree.cpp:
100         (resetWebPreferencesToConsistentValues):
101         * WebKitTestRunner/TestController.cpp:
102         (WTR::TestController::resetPreferencesToConsistentValues):
103
104 2017-02-10  Tim Horton  <timothy_horton@apple.com>
105
106         Infinite UI process hang under ensurePositionInformationIsUpToDate
107         https://bugs.webkit.org/show_bug.cgi?id=168154
108         <rdar://problem/30428673>
109
110         Reviewed by Simon Fraser.
111
112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
113         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
114         (recursiveFindHighlightLongPressRecognizer):
115         (TEST):
116         Add a somewhat nasty test that does an async interaction information update, but
117         kills the Web process before it arrives, and then does a sync interaction
118         information update, which will wait for the oustanding async interaction
119         information update if we still think it's coming. Before the patch, this
120         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
121
122 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
123
124         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
125         https://bugs.webkit.org/show_bug.cgi?id=168127
126         rdar://problem/30467120
127
128         Reviewed by Tim Horton.
129
130         Reparent the web view before we try to fetch it via:
131             [[[window contentView] subviews] objectAtIndex:0];
132         which would throw an exception if the test unparented it.
133
134         * DumpRenderTree/mac/DumpRenderTree.mm:
135         (resetWebViewToConsistentStateBeforeTesting):
136         (runTest):
137
138 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
139
140         [Resource Timing] Enable Resource Timing by default in Tests
141         https://bugs.webkit.org/show_bug.cgi?id=168145
142
143         Reviewed by Ryosuke Niwa.
144
145         * DumpRenderTree/mac/DumpRenderTree.mm:
146         (resetWebPreferencesToConsistentValues):
147         * DumpRenderTree/win/DumpRenderTree.cpp:
148         (resetWebPreferencesToConsistentValues):
149         * WebKitTestRunner/TestController.cpp:
150         (WTR::TestController::resetPreferencesToConsistentValues):
151
152 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
153
154         Removing LayoutTestRelay
155         https://bugs.webkit.org/show_bug.cgi?id=165927
156
157         Reviewed by Daniel Bates.
158         Part 2
159
160         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
161         simulators through simctl (iOS 10 and later), use this functionality instead.
162
163         * BuildSlaveSupport/built-product-archive:
164         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
165         Added a FIXME that we will need to implement similar archiving machinery once we build
166         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
167         * BuildSlaveSupport/kill-old-processes:
168         (main): Remove LayoutTestRelay from list of processes.
169         * LayoutTestRelay: Removed LayoutTestRelay.
170         * Makefile:
171         * Scripts/build-layouttestrelay: Removed.
172         * Scripts/build-webkit: Removed LayoutTestRelay references.
173
174 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
175
176         [WebCrypto] Add WebCryptoAPI to watchlist
177         https://bugs.webkit.org/show_bug.cgi?id=168138
178
179         Reviewed by Youenn Fablet.
180
181         * Scripts/webkitpy/common/config/watchlist:
182
183 2017-02-10  Brady Eidson  <beidson@apple.com>
184
185         Replace all WebKit Library Version checks in WK2 with SDK version checks.
186         https://bugs.webkit.org/show_bug.cgi?id=168124
187
188         Reviewed by Geoffrey Garen.
189
190         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
191         
192         * MiniBrowser/mac/main.m:
193         (main):
194         * MobileMiniBrowser/MobileMiniBrowser/main.m:
195         (main):
196         * TestWebKitAPI/ios/mainIOS.mm:
197         (main):
198         * TestWebKitAPI/mac/mainMac.mm:
199         (main):
200         * WebKitTestRunner/ios/mainIOS.mm:
201         (main):
202         * WebKitTestRunner/mac/main.mm:
203         (setDefaultsToConsistentValuesForTesting):
204
205 2017-02-10  Alex Christensen  <achristensen@webkit.org>
206
207         Fix El Capitan build.
208
209         * Scripts/build-webkit:
210         Don't build libwebrtc anywhere for now.
211
212 2017-02-10  Andy Estes  <aestes@apple.com>
213
214         Move two MiniBrowserBundle settings out of the .pbxproj
215         https://bugs.webkit.org/show_bug.cgi?id=168106
216
217         Reviewed by Tim Horton.
218
219         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
220         the project file. This removes the project file override.
221
222         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
223
224         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
225         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
226
227 2017-02-10  Alex Christensen  <achristensen@webkit.org>
228
229         Fix 32-and-64-bit build on El Capitan.
230
231         * Scripts/build-webkit:
232         Somebody's building with something like this:
233         build-webkit ARCHS="i386 x86_64"
234         We want this to also not build libwebrtc for now.
235
236 2017-02-10  Alex Christensen  <achristensen@webkit.org>
237
238         Fix 32-bit build on El Capitan.
239
240         * Scripts/build-webkit:
241         The bot uses ARCHS=i386 instead of --32-bit.
242         This is a hack, but it should fix the bot until I can do a better fix in the morning.
243
244 2017-02-10  Alex Christensen  <achristensen@webkit.org>
245
246         Fix 32-bit build on El Capitan.
247
248         * Scripts/build-webkit:
249         Don't build i386 libwebrtc.
250
251 2017-02-09  Alex Christensen  <achristensen@webkit.org>
252
253         Unreviewed, rolling out r212040.
254
255         Broke build.  I'm not surprised
256
257         Reverted changeset:
258
259         "[WebRTC][Mac] Activate libwebrtc"
260         https://bugs.webkit.org/show_bug.cgi?id=167293
261         http://trac.webkit.org/changeset/212040
262
263 2017-02-09  Alex Christensen  <achristensen@webkit.org>
264
265         Build libwebrtc on bots without using it yet
266         https://bugs.webkit.org/show_bug.cgi?id=168062
267
268         Reviewed by Brent Fulgham.
269
270         * Scripts/build-webkit:
271
272 2017-02-09  Alex Christensen  <achristensen@webkit.org>
273
274         Don't build libwebrtc.
275
276         * Scripts/build-webkit:
277         Not ready yet.  It broke El Capitan and iOS.
278
279 2017-02-09  Alex Christensen  <achristensen@webkit.org>
280
281         Build libwebrtc on bots without using it yet
282         https://bugs.webkit.org/show_bug.cgi?id=168062
283
284         Reviewed by Brent Fulgham.
285
286         * Scripts/build-webkit:
287
288 2017-02-09  Alex Christensen  <achristensen@webkit.org>
289
290         Rename isAppleMacWebKit to isAppleCocoaWebKit
291         https://bugs.webkit.org/show_bug.cgi?id=168075
292
293         Reviewed by Geoffrey Garen.
294
295         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
296
297         * Scripts/build-api-tests:
298         * Scripts/build-dumprendertree:
299         * Scripts/build-jsc:
300         (buildMyProject):
301         * Scripts/build-layouttestrelay:
302         * Scripts/build-webkit:
303         * Scripts/build-webkittestrunner:
304         * Scripts/run-api-tests:
305         (isSupportedPlatform):
306         (runTest):
307         (listAllTests):
308         (prepareEnvironmentForRunningTestTool):
309         * Scripts/run-content-extension-tester:
310         * Scripts/run-javascriptcore-tests:
311         * Scripts/run-minibrowser:
312         * Scripts/show-pretty-diff:
313         * Scripts/webkitdirs.pm:
314         (determineBaseProductDir):
315         (determineArchitecture):
316         (determinePassedArchitecture):
317         (safariPath):
318         (builtDylibPathForName):
319         (checkFrameworks):
320         (isAppleWebKit):
321         (isAppleCocoaWebKit):
322         (determineNmPath):
323         (launcherName):
324         (wrapperPrefixIfNeeded):
325         (isCMakeBuild):
326         (mobileSafariBundle):
327         (debugSafari):
328         (runSafari):
329         (runMiniBrowser):
330         (debugMiniBrowser):
331         (runWebKitTestRunner):
332         (debugWebKitTestRunner):
333         (isAppleMacWebKit): Deleted.
334         * Scripts/webkitperl/FeatureList.pm:
335
336 2017-02-09  Alex Christensen  <achristensen@webkit.org>
337
338         Revert r211991
339         https://bugs.webkit.org/show_bug.cgi?id=168062
340
341         * Scripts/build-webkit:
342         Not quite ready yet.
343
344 2017-02-09  Alex Christensen  <achristensen@webkit.org>
345
346         Build libwebrtc on bots without using it yet
347         https://bugs.webkit.org/show_bug.cgi?id=168062
348
349         Reviewed by Brent Fulgham.
350
351         * Scripts/build-webkit:
352         Build libwebrtc on Mac when we build ANGLE.
353
354 2017-02-09  Youenn Fablet  <youenn@apple.com>
355
356         Improve W3C importer command line options
357         https://bugs.webkit.org/show_bug.cgi?id=167448
358
359         Reviewed by Ryosuke Niwa.
360
361         Making the list of test paths to import the main arguments of the script.
362         Allow passing the source directory to import as a -s option.
363         Adding a warning when given test paths are skipped by default in ImportExpectations.
364
365         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
366         Link conversion rules do not change when imported tests are downloaded by the script.
367
368         * Scripts/webkitpy/w3c/test_importer.py:
369         (main):
370         (parse_args):
371         (TestImporter.__init__):
372         (TestImporter.do_import):
373         (TestImporter):
374         (TestImporter.check_imported_expectations):
375
376 2017-02-08  Chris Dumez  <cdumez@apple.com>
377
378         Update web-platform-tests resources
379         https://bugs.webkit.org/show_bug.cgi?id=168026
380
381         Reviewed by Youenn Fablet.
382
383         Stop copying testharness.js from resources/ to web-platform-tests/resources.
384
385         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
386         (WebPlatformTestServer._copy_webkit_test_files):
387
388 2017-02-08  Andy Estes  <aestes@apple.com>
389
390         Custom protocols should not continue loading after a network process crash
391         https://bugs.webkit.org/show_bug.cgi?id=168028
392         <rdar://problem/27607520>
393
394         Reviewed by Brady Eidson.
395
396         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
397         (processGroup):
398         (-[CloseWhileStartingProtocol startLoading]):
399         (-[CloseWhileStartingProtocol stopLoading]):
400         (TestWebKitAPI::runTest):
401         (TestWebKitAPI::TEST):
402
403 2017-02-08  Dan Bernstein  <mitz@apple.com>
404
405         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
406         https://bugs.webkit.org/show_bug.cgi?id=168031
407
408         Reviewed by Tim Horton.
409
410         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
411         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
412         (TEST):
413         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
414         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
415
416 2017-02-08  Chris Dumez  <cdumez@apple.com>
417
418         Use smaller tiles in windows that are not active to facilitate App Napping
419         https://bugs.webkit.org/show_bug.cgi?id=167997
420         <rdar://problem/30358835>
421
422         Reviewed by Simon Fraser.
423
424         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
425         (WTR::PlatformWebView::setWindowIsKey):
426         Actually update windowIsKey state of NSWindow so the WebView
427         properly updates its activity state.
428
429 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
432         https://bugs.webkit.org/show_bug.cgi?id=167942
433         <rdar://problem/30315079>
434
435         Reviewed by Tim Horton.
436
437         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
438         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
439         contenteditable in these cases.
440
441         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
442         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
443         performDragOperation:) directly.
444
445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
446         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
447         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
448         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
449         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
450         (-[DragSource draggingSourceOperationMaskForLocal:]):
451         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
452         (-[DragInfo lastMousePosition]):
453         (-[DragInfo setLastMousePosition:]):
454         (-[DragInfo draggingDestinationWindow]):
455         (-[DragInfo draggingSourceOperationMask]):
456         (-[DragInfo draggingLocation]):
457         (-[DragInfo draggedImageLocation]):
458         (-[DragInfo draggedImage]):
459         (-[DragInfo draggingPasteboard]):
460         (-[DragInfo draggingSource]):
461         (-[DragInfo draggingSequenceNumber]):
462         (-[DragInfo slideDraggedImageTo:]):
463         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
464         (-[DragInfo draggingFormation]):
465         (-[DragInfo setDraggingFormation:]):
466         (-[DragInfo animatesToDestination]):
467         (-[DragInfo setAnimatesToDestination:]):
468         (-[DragInfo numberOfValidItemsForDrop]):
469         (-[DragInfo setNumberOfValidItemsForDrop:]):
470         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
471         (-[DragInfo springLoadingHighlight]):
472         (-[DragInfo resetSpringLoading]):
473         (TestWebKitAPI::getTestImage):
474         (TestWebKitAPI::webViewAfterPerformingDragOperation):
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
477
478 2017-02-08  Jer Noble  <jer.noble@apple.com>
479
480         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
481         https://bugs.webkit.org/show_bug.cgi?id=168007
482
483         Reviewed by Alex Christensen.
484
485         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
486         (didFinishLoadForFrame):
487         (TestWebKitAPI::TEST):
488
489 2017-02-08  Commit Queue  <commit-queue@webkit.org>
490
491         Unreviewed, rolling out r211873.
492         https://bugs.webkit.org/show_bug.cgi?id=168001
493
494         It's in jhbuild for consistent layout tests (Requested by
495         mcatanzaro on #webkit).
496
497         Reverted changeset:
498
499         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
500         https://bugs.webkit.org/show_bug.cgi?id=167993
501         http://trac.webkit.org/changeset/211873
502
503 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
504
505         [GTK] Add icu packages to Tools/gtk/install-dependencies
506         https://bugs.webkit.org/show_bug.cgi?id=167993
507
508         Reviewed by Michael Catanzaro.
509
510         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
511         depending in the GNU/Linux distribution)
512
513 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
514
515         Update flakiness dashboard configuration.
516         https://bugs.webkit.org/show_bug.cgi?id=167957
517
518         Reviewed by Alexey Proskuryakov.
519
520         * TestResultServer/static-dashboards/builders.jsonp:
521
522 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
523
524         Replace a bot that has an incorrect configuration.
525         https://bugs.webkit.org/show_bug.cgi?id=167747
526
527         Rubber-stamped by Alexey Proskuryakov.
528
529         * BuildSlaveSupport/build.webkit.org-config/config.json:
530
531 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
532
533         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
534         https://bugs.webkit.org/show_bug.cgi?id=167927
535
536         Reviewed by Brent Fulgham.
537
538         Enable ComplexTextController API tests on the Win and GTK ports.
539
540         * TestWebKitAPI/PlatformGTK.cmake:
541         * TestWebKitAPI/PlatformWin.cmake:
542
543 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
544
545         File index appended to previous file in svn-create-patch with SVN 1.9
546         https://bugs.webkit.org/show_bug.cgi?id=167903
547         <rdar://problem/30387395>
548
549         Reviewed by Daniel Bates.
550
551         * Scripts/VCSUtils.pm:
552         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
553         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
554         trailing newline character from the expected result before comparing it to the actual result.
555
556 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
557
558         [webkitdirs] remove unused host_processor variable in determineArchitecture()
559         https://bugs.webkit.org/show_bug.cgi?id=167936
560
561         Reviewed by Michael Catanzaro.
562
563         * Scripts/webkitdirs.pm:
564         (determineArchitecture):
565         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
566         since r195083.
567
568 2017-02-07  Youenn Fablet  <youenn@apple.com>
569
570         Use a JSON file to define which WPT files/folders to import
571         https://bugs.webkit.org/show_bug.cgi?id=167923
572
573         Reviewed by Alex Christensen.
574
575         * Scripts/webkitpy/w3c/test_downloader.py:
576         (TestDownloader.__init__):
577         (TestDownloader._init_paths_from_expectations):
578         * Scripts/webkitpy/w3c/test_importer.py:
579         (parse_args):
580         * Scripts/webkitpy/w3c/test_importer_unittest.py:
581
582 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
583
584         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
585         https://bugs.webkit.org/show_bug.cgi?id=167916
586
587         Reviewed by Carlos Garcia Campos.
588
589         URL of mesa-11.0.6.tar.xz has been moved.
590
591         * gtk/jhbuild.modules: Fix the module path.
592
593 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
594
595         Static Analyzer: Address some leaks in MiniBrowser
596         https://bugs.webkit.org/show_bug.cgi?id=167897
597
598         Reviewed by Alexey Proskuryakov.
599
600         * MiniBrowser/mac/BrowserWindowController.m:
601         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
602         * MiniBrowser/mac/ExtensionManagerWindowController.m:
603         (-[ExtensionManagerWindowController add:]):
604         (-[ExtensionManagerWindowController remove:]):
605         * MiniBrowser/mac/SettingsController.m:
606         (-[SettingsController _populateMenu]):
607         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
608         Address obvious leaks caught by the static analyzer.
609
610 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
611
612         Migrate ComplexTextController to use platform-independent types
613         https://bugs.webkit.org/show_bug.cgi?id=167833
614
615         Reviewed by Brent Fulgham.
616
617         Migrate tests away from platform-dependent types.
618
619         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
620         (TestWebKitAPI::TEST_F):
621
622 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
623
624         Correct File Path Handling in SecurityOrigin and FileSystem
625         https://bugs.webkit.org/show_bug.cgi?id=167894
626         <rdar://problem/30380080>
627
628         Reviewed by Alexey Proskuryakov.
629
630         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
631         and perform same-volume checks using filesystem-compatible paths.        
632         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
633         filesystem paths, and perform validation of same-volume checks.
634         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
635         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
636         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
637         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
638
639 2017-02-06  Jer Noble  <jer.noble@apple.com>
640
641         Playback stalls when a SourceBuffer append causes frame eviction
642         https://bugs.webkit.org/show_bug.cgi?id=167834
643
644         Reviewed by Eric Carlson.
645
646         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
647         for the WTF::MediaTime class.
648
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
651         (TestWebKitAPI::TEST):
652         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
653         (WTF::operator<<):
654         (TestWebKitAPI::TestSample::create):
655         (TestWebKitAPI::TestSample::TestSample):
656         (TestWebKitAPI::TEST_F):
657
658 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
659
660         Change capitalization in platform name after r211735.
661
662         Unreviewed dashboard fix.
663
664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
665         (WebKitBuildbot):
666
667 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
668
669         Move the Leaks bot to Sierra
670         https://bugs.webkit.org/show_bug.cgi?id=167886
671
672         Reviewed by Daniel Bates.
673
674         * BuildSlaveSupport/build.webkit.org-config/config.json:
675         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
676         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
677         (LeaksViewer._displayURLPrompt):
678         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
679         (WebKitBuildbot):
680
681 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
682
683         Prevent app crash on launch during simctl install workaround
684         https://bugs.webkit.org/show_bug.cgi?id=167685
685
686         Reviewed by Daniel Bates.
687
688         * Scripts/webkitpy/port/simulator_process.py:
689         (SimulatorProcess.__init__): Pass environment to install.
690         * Scripts/webkitpy/xcode/simulator.py:
691         (Device.install_app): Accept environment, pass environment to launch.
692
693 2017-02-06  Alex Christensen  <achristensen@webkit.org>
694
695         Rebase API tests after r211638
696         https://bugs.webkit.org/show_bug.cgi?id=167779
697
698         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
699         (TestWebKitAPI::TEST_F):
700         URLs with non-special schemes and characters like % in the host now fail to parse,
701         more like their special counterparts and according to spec.
702
703 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
704
705         Unreviewed trivial fix after r211697.
706         https://bugs.webkit.org/show_bug.cgi?id=167863
707
708         * Scripts/run-javascriptcore-tests:
709         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
710
711 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
712
713         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
714         https://bugs.webkit.org/show_bug.cgi?id=167850
715
716         Reviewed by Tim Horton.
717
718         * DumpRenderTree/TestRunner.cpp:
719         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
720
721 2017-02-04  Andreas Kling  <akling@apple.com>
722
723         Plug some leaks in TestController and UIScriptContext.
724         <https://webkit.org/b/167839>
725
726         Reviewed by Alexey Proskuryakov.
727
728         Fix a couple of the leaks seen on the leaks bot.
729
730         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
731         (UIScriptContext::runUIScript):
732         * WebKitTestRunner/TestController.cpp:
733         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
734         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
735
736 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
737
738         WK1 mouse events are missing movementX and movementY for pointerlock.
739         https://bugs.webkit.org/show_bug.cgi?id=167775
740         rdar://problem/30343810
741
742         Reviewed by Alexey Proskuryakov.
743
744         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
745
746         * DumpRenderTree/mac/EventSendingController.mm:
747         (-[EventSendingController mouseMoveToX:Y:]):
748         * WebKitTestRunner/mac/EventSenderProxy.mm:
749         (WTR::EventSenderProxy::mouseMoveTo):
750
751 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
752
753         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
754         https://bugs.webkit.org/show_bug.cgi?id=167774
755
756         Reviewed by Tim Horton.
757
758         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
759         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
760         web process are async, so the callback fires after the web process gets the new state.
761
762         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
763         (WTR::UIScriptController::removeViewFromWindow):
764         (WTR::UIScriptController::addViewToWindow):
765         * DumpRenderTree/mac/DumpRenderTree.mm:
766         (createWebViewAndOffscreenWindow):
767         (resetWebViewToConsistentStateBeforeTesting):
768         * DumpRenderTree/mac/DumpRenderTreeMac.h:
769         * DumpRenderTree/mac/UIScriptControllerMac.mm:
770         (WTR::UIScriptController::removeViewFromWindow):
771         (WTR::UIScriptController::addViewToWindow):
772         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
773         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
774         (WTR::UIScriptController::removeViewFromWindow):
775         (WTR::UIScriptController::addViewToWindow):
776         * TestRunnerShared/UIScriptContext/UIScriptController.h:
777         * WebKitTestRunner/PlatformWebView.h:
778         * WebKitTestRunner/TestController.cpp:
779         (WTR::TestController::resetStateToConsistentValues):
780         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
781         (WTR::PlatformWebView::removeFromWindow):
782         (WTR::PlatformWebView::addToWindow):
783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
784         (WTR::UIScriptController::removeViewFromWindow):
785         (WTR::UIScriptController::addViewToWindow):
786         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
787         (WTR::PlatformWebView::removeFromWindow):
788         (WTR::PlatformWebView::addToWindow):
789         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
790         (WTR::UIScriptController::removeViewFromWindow):
791         (WTR::UIScriptController::addViewToWindow):
792
793 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
794
795         Remove check for SkipSafariExecutableEntitlementChecks
796         https://bugs.webkit.org/show_bug.cgi?id=167762
797
798         Reviewed by Dan Bernstein.
799
800         Follow-up fix: don't break internal behavior.
801
802         * Scripts/webkitdirs.pm:
803         (safariPath):
804         (executableHasEntitlements): Deleted.
805         (safariPathFromSafariBundle): Deleted.
806         (installedSafariPath): Deleted.
807
808 2017-02-03  Daniel Bates  <dabates@apple.com>
809
810         [Mac][WK2] Add SPI to override the Content Security Policy of a page
811         https://bugs.webkit.org/show_bug.cgi?id=167810
812         <rdar://problem/30102568>
813
814         Reviewed by Anders Carlsson.
815
816         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
817
818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
819         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
820         (TEST):
821         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
822         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
823         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
824         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
825
826 2017-02-02  Alex Christensen  <achristensen@webkit.org>
827
828         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
829         https://bugs.webkit.org/show_bug.cgi?id=167773
830         <rdar://problem/30221102>
831
832         Reviewed by Ryosuke Niwa.
833
834         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
835         (TestWebKitAPI::TEST_F):
836
837 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
838
839         Remove check for SkipSafariExecutableEntitlementChecks
840         https://bugs.webkit.org/show_bug.cgi?id=167762
841         rdar://problem/22480673
842
843         Reviewed by Dan Bernstein.
844
845         * Scripts/webkitdirs.pm:
846         (safariPathFromSafariBundle):
847         (skipSafariExecutableEntitlementChecks): Deleted.
848
849 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
850
851         Undefined subroutine in svn-create-patch
852         https://bugs.webkit.org/show_bug.cgi?id=167742
853
854         Unreviewed build-fix after r211543.
855
856         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
857
858 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
859
860         Unreviewed. Fix jhbuild dependencies build.
861
862         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
863         Patch updated.
864
865 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
866
867         [EME][GStreamer] Fixed decryptor selection
868         https://bugs.webkit.org/show_bug.cgi?id=167588
869
870         Reviewed by Žan Doberšek.
871
872         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
873
874         * gtk/jhbuild.modules: Added patches to gstreamer and
875         gst-plugins-good packages.
876         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
877         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
878
879 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
880
881         Make run-benchmark script supports 'config' key in test plan.
882         https://bugs.webkit.org/show_bug.cgi?id=167715
883
884         Reviewed by Ryosuke Niwa.
885
886         Add support for 'config' key in test paln.
887         'config' key is a dictionary that specifies environment configurations while test is running.
888         Specifies orientation to be portrait in MotionMark benchmark.
889
890         * Scripts/webkitpy/benchmark_runner/README.md:
891         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
892         (BenchmarkRunner.__init__):
893         (BenchmarkRunner._run_benchmark):
894         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
895         (BrowserDriver.prepare_env):
896         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
897         (LinuxBrowserDriver.prepare_env):
898         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
899         (OSXBrowserDriver.prepare_env):
900         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
901         (OSXSafariDriver.prepare_env):
902         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
903
904 2017-02-01  Daniel Bates  <dabates@apple.com>
905
906         REGRESSION (r210820): svn-create-patch does not emit property change only diff
907         https://bugs.webkit.org/show_bug.cgi?id=167169
908
909         Reviewed by David Kilzer.
910
911         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
912         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
913         header from the output of "svn diff" on a file that was copied or moved.
914
915         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
916         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
917         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
918         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
919         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
920         of a file with only a property change also does not contain any chunk range lines. Therefore
921         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
922         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
923         we should directly test for the presence of a leading SVN diff header with an empty body and
924         remove such lines from the diff.
925
926         * Scripts/VCSUtils.pm:
927         (fixSVNPatchForAdditionWithHistory): Added.
928         * Scripts/svn-create-patch:
929         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
930         we have a non empty patch for an added file with history (i.e. a copied or moved file).
931         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
932
933 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
934
935         [Mac] Update CARingBuffer class
936         https://bugs.webkit.org/show_bug.cgi?id=167656
937
938         Reviewed by Jer Noble.
939
940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
941         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
942         (TestWebKitAPI::CARingBufferTest::SetUp):
943         (TestWebKitAPI::CARingBufferTest::setup):
944         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
945         (TestWebKitAPI::CARingBufferTest::description):
946         (TestWebKitAPI::CARingBufferTest::bufferList):
947         (TestWebKitAPI::CARingBufferTest::ringBuffer):
948         (TestWebKitAPI::CARingBufferTest::capacity):
949         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
950         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
951         (TestWebKitAPI::TEST_F):
952         (TestWebKitAPI::MixingTest::run):
953
954 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
955
956         [Mac] TestWebKitAPI includes system frameworks incorrectly
957         https://bugs.webkit.org/show_bug.cgi?id=167703
958         rdar://problem/30301498
959
960         Reviewed by Ryosuke Niwa.
961
962         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
963         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
964
965         Also, reduced the number of subframework search paths, looks like we only need one now.
966
967         * TestWebKitAPI/Configurations/Base.xcconfig:
968
969 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
970
971         Correct "filesHaveSameVolume" predicate
972         https://bugs.webkit.org/show_bug.cgi?id=167696
973         <rdar://problem/30298722>
974
975         Reviewed by David Kilzer.
976
977         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
978         percent-escaped path inputs.
979
980         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
981         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
982         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
983         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
984         (TestWebKitAPI::TEST_F):
985
986 2017-02-01  Tomas Popela  <tpopela@redhat.com>
987
988         Unreviewed. Fix coding style in MiniBrowser
989
990         * MiniBrowser/gtk/BrowserWindow.c:
991         (editingCommandCallback):
992         (insertImageCommandCallback):
993         (insertLinkCommandCallback):
994
995 2017-02-01  Tomas Popela  <tpopela@redhat.com>
996
997         [GTK] Add an API to add a custom tab into the print dialog
998         https://bugs.webkit.org/show_bug.cgi?id=151998
999
1000         Reviewed by Carlos Garcia Campos.
1001
1002         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1003         that is testing a newly added API.
1004
1005         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1006         (testPrintCustomWidget):
1007         (beforeAll):
1008
1009 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1010
1011         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1012         https://bugs.webkit.org/show_bug.cgi?id=166529
1013
1014         Reviewed by Xabier Rodriguez-Calvar.
1015
1016         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1017         New patch version accepted in GStreamer upstream.
1018
1019 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1020
1021         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1022         https://bugs.webkit.org/show_bug.cgi?id=167498
1023
1024         Reviewed by Carlos Garcia Campos.
1025
1026         Depending on the distro version you can need either libxfont1-dev
1027         or libfont-dev to build with jhbuild.
1028
1029         * gtk/install-dependencies:
1030
1031 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1032
1033         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1034         https://bugs.webkit.org/show_bug.cgi?id=167594
1035
1036         Unreviewed test gardening.
1037
1038         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1039
1040         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1041         (TEST):
1042
1043 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1044
1045         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1046         https://bugs.webkit.org/show_bug.cgi?id=167676
1047
1048         Reviewed by Saam Barati.
1049
1050         * Scripts/run-javascriptcore-tests:
1051         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1052
1053 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1054
1055         Make Dump Render Tree not crash
1056         https://bugs.webkit.org/show_bug.cgi?id=167667
1057
1058         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1059         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1060         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1061         This does not fix any tests, it just fixes the crash.
1062         
1063         Reviewed by Simon Fraser.
1064
1065         * DumpRenderTree/TestRunner.cpp:
1066         (TestRunner::callUIScriptCallback):
1067
1068 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1069
1070         Workaround for simctl install failing to report install failure
1071         https://bugs.webkit.org/show_bug.cgi?id=167654
1072
1073         Reviewed by Daniel Bates.
1074
1075         simctl install will sometimes report success even though install has failed.
1076         To workaround this bug, we attempt an app launch after install to ensure
1077         install has succeeded.
1078
1079         * Scripts/webkitpy/xcode/simulator.py:
1080         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1081         (Device.launch_app): Correct comment.
1082
1083 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1084
1085         Unreviewed webkitpy fix after r211405.
1086
1087         * Scripts/webkitpy/xcode/simulator.py:
1088         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1089
1090 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1091
1092         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1093
1094         * gtk/manifest.txt.in:
1095
1096 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1097
1098         AX: enable search predication for iOS
1099         https://bugs.webkit.org/show_bug.cgi?id=167558
1100         <rdar://problem/30251367>
1101
1102         Reviewed by Joanmarie Diggs.
1103
1104         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1105         (AccessibilityUIElement::uiElementForSearchPredicate):
1106         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1107         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1108         (searchPredicateParameterizedAttributeForSearchCriteria):
1109         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1110         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1111         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1112         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1113         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1114         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1115         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1116         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1117         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1118         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1119         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1120
1121 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1122
1123         Workaround for simctl launch bug
1124         https://bugs.webkit.org/show_bug.cgi?id=167613
1125
1126         Reviewed by Daniel Bates.
1127
1128         simctl launch will sometimes fail because of a race condition when many
1129         simulators are being run simultaneously. These failures will always have
1130         an exit code of 1. This change attempts to launch an app multiple times
1131         before reporting a failure to workaround this bug.
1132
1133         * Scripts/webkitpy/xcode/simulator.py:
1134         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1135
1136 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1137
1138         Commit queue fails to look at real name aliases for the reviewer
1139         https://bugs.webkit.org/show_bug.cgi?id=167422
1140
1141         Reviewed by Joseph Pecoraro.
1142
1143         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1144         (test_has_valid_reviewer): Added tests.
1145
1146         * Scripts/webkitpy/common/config/committers.py:
1147         (CommitterList._name_to_contributor_map):
1148         Made _name_to_contributor_map include alias names.
1149
1150         * Scripts/webkitpy/common/config/committers_unittest.py:
1151         (CommittersTest.test_contributors_by_fuzzy_match):
1152         Removed subtests that are now obsolete, as these matches are strict. It is not
1153         obvious if distance based fuzzy matching for names is useful at all, but we can
1154         look into that some other time.
1155
1156 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1157
1158         QueueStatusServer should have an explicit timeout for _fetch_url
1159         https://bugs.webkit.org/show_bug.cgi?id=167467
1160
1161         Reviewed by Alexey Proskuryakov.
1162
1163         * Scripts/webkitpy/common/net/statusserver.py:
1164         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1165
1166 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1167
1168         Add support for Trac instances that host multiple projects.
1169         https://bugs.webkit.org/show_bug.cgi?id=167524
1170
1171         Reviewed by Alexey Proskuryakov.
1172
1173         When multiple projects are hosted on a single Trac instance, the current
1174         behavior will retrieve changesets from all tracked projects.
1175         This patch teaches Trac.js to get project-specific changesets from Trac.
1176         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1177         when querying the Trac timeline.
1178
1179         To tell Trac to be aware of multi-project instances we leverage the 
1180         `options` parameter when creating a new instance: 
1181
1182             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1183
1184         If this option is not provided, the original behaviour will prevail.
1185         Additionally, add corresponding tests.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1188         (Trac): Reason about new optional parameter 'projectIdentifier'.
1189         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1190         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1191         replace default parameter `changeset=on` with `repo-projectname=on`.
1192         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1194         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1196         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1197         Add the following tests:
1198             test("revisionURL")
1199             test("revisionURL with Trac Identifier")
1200             test("_xmlTimelineURL")
1201             test("_xmlTimelineURL with Trac Identifier")
1202         (this.view._latestProductiveIteration): Fix missing ';'.
1203
1204 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1205
1206         Correct spacing regression on inter-element complex path shaping on some fonts
1207         https://bugs.webkit.org/show_bug.cgi?id=166013
1208
1209         Reviewed by Simon Fraser.
1210
1211         Unskip existing tests and make some new tests:
1212         - Testing complex text with no origins
1213         - Testing initial expansions
1214         - Testing the sign of vertical advances
1215
1216         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1217         (TestWebKitAPI::TEST_F):
1218
1219 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1220
1221         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1222         https://bugs.webkit.org/show_bug.cgi?id=167596
1223
1224         Reviewed by Daniel Bates.
1225
1226         We avoid needing a thin directory by invoking the zip program with
1227         the list of directories from the build directory to be zipped,
1228         and by using the zip feature to exclude files matching a pattern.
1229
1230         * BuildSlaveSupport/built-product-archive:
1231         (copyBuildFiles):
1232         (createZipFromList):
1233         (archiveBuiltProduct):
1234
1235 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1236
1237         Use simctl instead of LayoutTestRelay
1238         https://bugs.webkit.org/show_bug.cgi?id=165927
1239
1240         Reviewed by Daniel Bates.
1241
1242         Part 1
1243
1244         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1245         simulators through simctl (iOS 10 and later), use this functionality instead.
1246
1247         * Scripts/webkitpy/port/base.py:
1248         (Port.__init__): Added _test_runner_process_constructor.
1249         * Scripts/webkitpy/port/darwin.py:
1250         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1251         * Scripts/webkitpy/port/driver.py:
1252         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1253         (IOSSimulatorDriver): Deleted.
1254         * Scripts/webkitpy/port/driver_unittest.py:
1255         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1256         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1257         (DriverTest.test_start_actually_starts): Ditto.
1258         * Scripts/webkitpy/port/ios.py:
1259         (IOSSimulatorPort): Remove relay_name.
1260         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1261         (IOSSimulatorPort._create_simulators): Formatting change.
1262         (IOSSimulatorPort.relay_path): Deleted.
1263         (IOSSimulatorPort._check_relay): Deleted.
1264         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1265         (IOSSimulatorPort._build_relay): Deleted.
1266         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1267         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1268         * Scripts/webkitpy/port/ios_unittest.py:
1269         (iosTest.test_32bit): Update test.
1270         (iosTest.test_64bit): Update test.
1271         * Scripts/webkitpy/port/server_process.py:
1272         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1273         (ServerProcess._set_file_nonblocking): Added to share common code.
1274         * Scripts/webkitpy/port/server_process_mock.py:
1275         (MockServerProcess.__init__): Added argument worker_number.
1276         * Scripts/webkitpy/port/simulator_process.py: Added.
1277         (SimulatorProcess): Added.
1278         (SimulatorProcess.Popen): Added.
1279         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1280         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1281         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1282         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1283         (SimulatorProcess._reset): Added. Unlink fifos.
1284         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1285         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1286         * Scripts/webkitpy/xcode/simulator.py:
1287         (Device.__init__): Accept host to run install/launch/terminate.
1288         (Device.install_app): Install app to target Device.
1289         (Device.launch_app): Launch app on target Device.
1290         (Device.terminate_app): Shutdown app on target Device.
1291         (Simulator._parse_devices): Pass host to Device.
1292
1293 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1294
1295         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1296         https://bugs.webkit.org/show_bug.cgi?id=167411
1297
1298         Reviewed by Michael Catanzaro.
1299
1300         Disable the ARM iwMMXt fast path for pixman, because it triggers
1301         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1302
1303         * gtk/jhbuild.modules:
1304
1305 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         [GTK] Add API to handle the accelerated compositing policy
1308         https://bugs.webkit.org/show_bug.cgi?id=167509
1309
1310         Reviewed by Michael Catanzaro.
1311
1312         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1313         as a special case. Also add test cases to the get/set API.
1314
1315         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1316         (hardwareAccelerationPolicyToString):
1317         (stringToHardwareAccelerationPolicy):
1318         (cellRendererChanged):
1319         (browserSettingsDialogConstructed):
1320         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1321         (testWebKitSettings):
1322
1323 2017-01-29  Andy Estes  <aestes@apple.com>
1324
1325         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1326         https://bugs.webkit.org/show_bug.cgi?id=167563
1327         <rdar://problem/30253207>
1328
1329         Reviewed by Andreas Kling.
1330
1331         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1332         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1333         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1334         (runTest):
1335         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1336         (TEST):
1337
1338 2017-01-29  Dan Bernstein  <mitz@apple.com>
1339
1340         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1341         https://bugs.webkit.org/show_bug.cgi?id=167565
1342
1343         Reviewed by Sam Weinig.
1344
1345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1346         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1347         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1348         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1349         (TEST):
1350         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1351         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1352         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1353         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1354
1355 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1356
1357         Add Link Preload as an off-by-default experimental feature menu item.
1358         https://bugs.webkit.org/show_bug.cgi?id=167201
1359
1360         Reviewed by Ryosuke Niwa.
1361
1362         * DumpRenderTree/mac/DumpRenderTree.mm:
1363         (resetWebPreferencesToConsistentValues):
1364         * DumpRenderTree/win/DumpRenderTree.cpp:
1365         (resetWebPreferencesToConsistentValues):
1366
1367 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1368
1369         Add User Timing Experimental Feature
1370         https://bugs.webkit.org/show_bug.cgi?id=167542
1371         <rdar://problem/22746307>
1372
1373         Reviewed by Ryosuke Niwa.
1374
1375         * DumpRenderTree/mac/DumpRenderTree.mm:
1376         (enableExperimentalFeatures):
1377         (resetWebPreferencesToConsistentValues):
1378         * DumpRenderTree/win/DumpRenderTree.cpp:
1379         (enableExperimentalFeatures):
1380
1381 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1382
1383         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1384         https://bugs.webkit.org/show_bug.cgi?id=167519
1385
1386         Reviewed by Ryosuke Niwa.
1387
1388         * QueueStatusServer/templates/statusbubble.html:
1389         To measure the bubbleContainer's width, it must not be wrapping based
1390         on its parent container. So when measuring the width temporarily set
1391         the parent to a very large width so as to not artificially wrap us.
1392         Restore the parent's width after measuring.
1393
1394 2017-01-27  Andy Estes  <aestes@apple.com>
1395
1396         [iOS] Add a test for _WKNSFileManagerExtras
1397         https://bugs.webkit.org/show_bug.cgi?id=167478
1398
1399         Reviewed by Andreas Kling.
1400
1401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1402         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1403         (expectAttributes):
1404         (TEST):
1405
1406 2017-01-27  Keith Miller  <keith_miller@apple.com>
1407
1408         run-benchmarks should make sure it passes the test url to the right application
1409         https://bugs.webkit.org/show_bug.cgi?id=167533
1410
1411         Reviewed by Joseph Pecoraro.
1412
1413         This fixes an issue when trying to run-benchmark script with the
1414         system default browser set to STP. Previously, it would run
1415         the test in STP rather than the provided build. Now, it should run
1416         in the provided build.
1417
1418         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1419         (OSXSafariDriver.launch_url):
1420
1421 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1422
1423         [Cocoa] Prepare ComplexTextController for unit testing
1424         https://bugs.webkit.org/show_bug.cgi?id=167493
1425
1426         Reviewed by Simon Fraser.
1427
1428         Addressing post-review comments from Simon Fraser.
1429
1430         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1431         (TestWebKitAPI::TEST_F):
1432
1433 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1434
1435         [Cocoa] Prepare ComplexTextController for unit testing
1436         https://bugs.webkit.org/show_bug.cgi?id=167493
1437
1438         Reviewed by Dean Jackson.
1439
1440         Create four unit tests.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1444         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1445         (TestWebKitAPI::TEST_F):
1446
1447 2017-01-26  Chris Dumez  <cdumez@apple.com>
1448
1449         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1450         https://bugs.webkit.org/show_bug.cgi?id=167421
1451         <rdar://problem/30188490>
1452
1453         Reviewed by Darin Adler.
1454
1455         Add a new setting allowing layout tests to enable PageCache in a window
1456         that has an opener, for convenience.
1457
1458         * DumpRenderTree/mac/DumpRenderTree.mm:
1459         (resetWebPreferencesToConsistentValues):
1460         * DumpRenderTree/win/DumpRenderTree.cpp:
1461         (resetWebPreferencesToConsistentValues):
1462         * WebKitTestRunner/TestController.cpp:
1463         (WTR::TestController::resetPreferencesToConsistentValues):
1464
1465 2017-01-26  Keith Miller  <keith_miller@apple.com>
1466
1467         classInfo should take a VM so it is not materialized from the object on each call
1468         https://bugs.webkit.org/show_bug.cgi?id=167424
1469
1470         Rubber Stamped by Michael Saboff.
1471
1472         Previously, classInfo() would get the VM from the target's
1473         MarkedBlock.  Most callers already have a VM on hand, so it is
1474         wasteful to compute the VM from the marked block every time. This
1475         patch refactors some of the most common callers of classInfo(),
1476         jsDynamicCast and inherits to take a VM as well.
1477
1478         * DumpRenderTree/TestRunner.cpp:
1479         (setAudioResultCallback):
1480
1481 2017-01-26  Jer Noble  <jer.noble@apple.com>
1482
1483         Autoplay muted videos stop playback of any streaming app in the background
1484         https://bugs.webkit.org/show_bug.cgi?id=163993
1485         <rdar://problem/29020431>
1486
1487         Reviewed by Eric Carlson.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1491         (TestWebKitAPI::TEST):
1492         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1493
1494 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1495
1496         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1497         https://bugs.webkit.org/show_bug.cgi?id=167466
1498
1499         Unreviewed test gardening.
1500
1501         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1502         (TEST):
1503
1504 2017-01-26  Matt Rajca  <mrajca@apple.com>
1505
1506         Notify clients when the user plays media otherwise prevented from autoplaying
1507         https://bugs.webkit.org/show_bug.cgi?id=167390
1508
1509         Reviewed by Alex Christensen.
1510
1511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1512         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1513         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1514         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1515         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1516         (TEST):
1517         * TestWebKitAPI/cocoa/TestWKWebView.h:
1518         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1519         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1520         (-[TestWKWebView waitForLoad]):
1521         (-[TestWKWebView mouseUpAtPoint:]):
1522         * WebKitTestRunner/TestController.cpp:
1523         (WTR::TestController::createOtherPage):
1524         (WTR::TestController::createWebViewWithOptions):
1525
1526 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1527
1528         Crash when setting custom scale factor.
1529         https://bugs.webkit.org/show_bug.cgi?id=167369
1530
1531         Reviewed by Sam Weinig.
1532
1533         Added API test.
1534
1535         * TestWebKitAPI/PlatformWin.cmake:
1536         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1537         (TestWebKitAPI::WebKitCreateInstance):
1538         (TestWebKitAPI::ScaleWebView::SetUp):
1539         (TestWebKitAPI::ScaleWebView::TearDown):
1540         (TestWebKitAPI::TEST_F):
1541
1542 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1543
1544         run-benchmark nests MotionMark results by the suite name twice
1545         https://bugs.webkit.org/show_bug.cgi?id=164948
1546
1547         Reviewed by Said Abou-Hallawa.
1548
1549         Use a single level MotionMark now that this is the name of the benchmark,
1550         and we no longer have tests that aren't part of the MotionMark suite.
1551
1552         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1553
1554 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1555
1556         Unreviewed, rolling out r211193.
1557
1558         This change broke internal builds.
1559
1560         Reverted changeset:
1561
1562         "Notify clients when the user plays media otherwise prevented
1563         from autoplaying"
1564         https://bugs.webkit.org/show_bug.cgi?id=167390
1565         http://trac.webkit.org/changeset/211193
1566
1567 2017-01-25  Matt Rajca  <mrajca@apple.com>
1568
1569         Notify clients when the user plays media otherwise prevented from autoplaying
1570         https://bugs.webkit.org/show_bug.cgi?id=167390
1571
1572         Reviewed by Alex Christensen.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1576         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1577         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1578         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1579         (TEST):
1580         * TestWebKitAPI/cocoa/TestWKWebView.h:
1581         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1582         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1583         (-[TestWKWebView waitForLoad]):
1584         (-[TestWKWebView mouseUpAtPoint:]):
1585         * WebKitTestRunner/TestController.cpp:
1586         (WTR::TestController::createOtherPage):
1587         (WTR::TestController::createWebViewWithOptions):
1588
1589 2017-01-25  Matt Rajca  <mrajca@apple.com>
1590
1591         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1592         https://bugs.webkit.org/show_bug.cgi?id=167385
1593
1594         Reviewed by Alex Christensen.
1595
1596         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1597         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1598         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1599         (TEST): Allow inline (rather than full screen) media playback on iOS.
1600
1601 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1602
1603         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1604         https://bugs.webkit.org/show_bug.cgi?id=167414
1605
1606         Reviewed by Michael Catanzaro.
1607
1608         Add a test case to check ephemeral web views don't write favicons to the database.
1609
1610         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1611         (ephemeralViewLoadChanged):
1612         (testPrivateBrowsing):
1613         (testFaviconDatabase):
1614
1615 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1616
1617         [GTK] Add a private browsing mode to MiniBrowser
1618         https://bugs.webkit.org/show_bug.cgi?id=167413
1619
1620         Reviewed by Michael Catanzaro.
1621
1622         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1623         private windows, even on non-private instances.
1624
1625         * MiniBrowser/gtk/BrowserWindow.c:
1626         (webViewTitleChanged): Add [Private] to title window for private windows.
1627         (webViewCreate): Pass web context to browser_window_new.
1628         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1629         (browserWindowFinalize): Disconnect web context signal handlers.
1630         (browser_window_init): Add shortcut for opening private window.
1631         (browser_window_new): It now receives the context and connect to download-started here.
1632         (browser_window_get_web_context): Return the context.
1633         * MiniBrowser/gtk/BrowserWindow.h:
1634         * MiniBrowser/gtk/main.c:
1635         (createBrowserTab): Create the web view for the window web context.
1636         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1637         (aboutDataHandleRequest): Ditto.
1638         (aboutURISchemeRequestCallback): Ditto.
1639         (main): Create ephemeral web context if private command line option is used.
1640
1641 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1642
1643         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1644         https://bugs.webkit.org/show_bug.cgi?id=167409
1645
1646         Reviewed by Antti Koivisto.
1647
1648         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1649         as well as tests for the newly added matchingElementInFlatTree.
1650
1651         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1652         (TestWebKitAPI::runJavaScriptAlert):
1653         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1654         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1655         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1656
1657 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1658
1659         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1660         https://bugs.webkit.org/show_bug.cgi?id=167370
1661
1662         Reviewed by Michael Catanzaro.
1663
1664         Add several test cases of ephemeral web views.
1665
1666         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1667         (testWebViewAuthenticationStorage):
1668         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1669         (ephemeralViewloadChanged):
1670         (testCookieManagerEphemeral):
1671         (beforeAll):
1672         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1673         (testWebKitSettings):
1674         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1675         (testWebContextEphemeral):
1676         (ephemeralViewloadChanged):
1677         (testWebContextProxySettings):
1678         (beforeAll):
1679         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1680         (ephemeralViewloadChanged):
1681         (testWebViewEphemeral):
1682         (beforeAll):
1683         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1684         (ephemeralViewloadChanged):
1685         (testWebsiteDataEphemeral):
1686         (beforeAll):
1687
1688 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1689
1690         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1691         https://bugs.webkit.org/show_bug.cgi?id=167402
1692
1693         Reviewed by Ryosuke Niwa.
1694
1695         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1696         (TestWebKitAPI::TEST):
1697
1698 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1699
1700         Add simple line layout toggle to MiniBrowser
1701         https://bugs.webkit.org/show_bug.cgi?id=167405
1702
1703         Reviewed by Andreas Kling.
1704
1705         * MiniBrowser/mac/SettingsController.h:
1706         * MiniBrowser/mac/SettingsController.m:
1707         (-[SettingsController _populateMenu]):
1708         (-[SettingsController validateMenuItem:]):
1709         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1710         (-[SettingsController simpleLineLayoutEnabled]):
1711         * MiniBrowser/mac/WK1BrowserWindowController.m:
1712         (-[WK1BrowserWindowController didChangeSettings]):
1713         * MiniBrowser/mac/WK2BrowserWindowController.m:
1714         (-[WK2BrowserWindowController didChangeSettings]):
1715
1716 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1717
1718         WKR does not include my nick when commit-queue lands my patch
1719         https://bugs.webkit.org/show_bug.cgi?id=167388
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1724         (NewCommitBot._summarize_commit_log):
1725         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1726         Perform nickname insertion before grabbing "Patch by" details.
1727         This way we can include the nickname with the full name.
1728
1729 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1730
1731         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1732         https://bugs.webkit.org/show_bug.cgi?id=167394
1733
1734         Reviewed by Ryosuke Niwa.
1735
1736         * Scripts/webkitperl/FeatureList.pm:
1737         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1738
1739 2017-01-24  Youenn Fablet  <youenn@apple.com>
1740
1741         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1742         https://bugs.webkit.org/show_bug.cgi?id=167353
1743
1744         Reviewed by Alex Christensen.
1745
1746         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1747         (CMakeGenerator.initialize_targets):
1748
1749 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1750
1751         WKR should not confuse Miguel Gomez with Andres Gomez
1752         https://bugs.webkit.org/show_bug.cgi?id=167389
1753
1754         Reviewed by Lucas Forschler.
1755
1756         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1757         "mAndres Gomez". Fix this.
1758
1759         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1760         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1761         space on each side of the email address, so expect both spaces to be there before
1762         considering the email for replacement.
1763         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1764
1765 2017-01-24  Matt Rajca  <mrajca@apple.com>
1766
1767         Pass down website autoplay policies to media elements
1768         https://bugs.webkit.org/show_bug.cgi?id=167355
1769
1770         Reviewed by Alex Christensen.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1774         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1775         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1777         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1778         (TEST):
1779
1780 2017-01-24  Nan Wang  <n_wang@apple.com>
1781
1782         AX: Speak Selection does not work in an iframe
1783         https://bugs.webkit.org/show_bug.cgi?id=166794
1784         <rdar://problem/29913013>
1785
1786         Reviewed by Chris Fleizach.
1787
1788         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1789         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1790         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1791         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1792         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1793         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1794         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1797         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1798         (-[TestRunnerWKWebView dealloc]):
1799         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1800         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1801         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1802         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1803         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1804
1805 2017-01-24  Daniel Bates  <dabates@apple.com>
1806
1807         StringView.split() should use an iterator design pattern instead of allocating a Vector
1808         https://bugs.webkit.org/show_bug.cgi?id=163225
1809
1810         Reviewed by Darin Adler.
1811
1812         Add unit tests for StringView.split().
1813
1814         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1815         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1816         used in the StringView.split() unit tests.
1817         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1818         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1819         object to a Vector of String objects.
1820         (TestWebKitAPI::TEST): Added the following tests:
1821             - WTF.StringViewSplitEmptyAndNullStrings
1822             - WTF.StringViewSplitBasic
1823             - WTF.StringViewSplitWithConsecutiveSeparators
1824
1825 2017-01-23  Anders Carlsson  <andersca@apple.com>
1826
1827         The Score Esports crashes on launch
1828         https://bugs.webkit.org/show_bug.cgi?id=167338
1829         rdar://problem/29948645
1830
1831         Reviewed by Dan Bernstein.
1832
1833         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1834         (TestWebKitAPI::TEST):
1835         Add a test.
1836
1837 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1838
1839         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1840         https://bugs.webkit.org/show_bug.cgi?id=146589
1841
1842         Reviewed by Michael Catanzaro.
1843
1844         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1845         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1846
1847         * MiniBrowser/gtk/BrowserWindow.c:
1848         (webViewDecidePolicy):
1849         (newTabCallback):
1850         * MiniBrowser/gtk/main.c:
1851         (createBrowserTab):
1852         (aboutDataRequestFree):
1853         (aboutDataRequestNew):
1854         (aboutDataRequestForView):
1855         (websiteDataRemovedCallback):
1856         (websiteDataClearedCallback):
1857         (aboutDataScriptMessageReceivedCallback):
1858         (domainListFree):
1859         (aboutDataFillTable):
1860         (gotWebsiteDataCallback):
1861         (aboutDataHandleRequest):
1862         (aboutURISchemeRequestCallback):
1863         (main):
1864         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1865         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1866         (serverCallback):
1867         (beforeAll):
1868         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1869         (serverCallback):
1870         (WebsiteDataTest::WebsiteDataTest):
1871         (WebsiteDataTest::~WebsiteDataTest):
1872         (WebsiteDataTest::fetch):
1873         (WebsiteDataTest::remove):
1874         (WebsiteDataTest::clear):
1875         (testWebsiteDataConfiguration):
1876         (testWebsiteDataCache):
1877         (testWebsiteDataStorage):
1878         (testWebsiteDataDatabases):
1879         (testWebsiteDataAppcache):
1880         (beforeAll):
1881         (afterAll):
1882
1883 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1884
1885         Unreviewed, rolling out r211062.
1886         https://bugs.webkit.org/show_bug.cgi?id=167354
1887
1888         broke API tests (Requested by alexchristensen on #webkit).
1889
1890         Reverted changeset:
1891
1892         "Pass down website autoplay policies to media elements"
1893         https://bugs.webkit.org/show_bug.cgi?id=167132
1894         http://trac.webkit.org/changeset/211062
1895
1896 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1897
1898         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1899         https://bugs.webkit.org/show_bug.cgi?id=167330
1900
1901         Reviewed by Tim Horton.
1902
1903         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1904         (TestWebKitAPI::TEST_F):
1905
1906 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1907
1908         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1909         https://bugs.webkit.org/show_bug.cgi?id=167317
1910
1911         Reviewed by Sam Weinig.
1912
1913         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1914         (TestWebKitAPI::TEST_F):
1915
1916 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1917
1918         svn-create-patch should emit properties when files are moved or copied
1919         https://bugs.webkit.org/show_bug.cgi?id=167264
1920
1921         Reviewed by Daniel Bates.
1922
1923         * Scripts/svn-create-patch:
1924         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1925
1926 2017-01-23  Youenn Fablet  <youenn@apple.com>
1927
1928         [WebRTC] Filter libwebrtc link flags
1929         https://bugs.webkit.org/show_bug.cgi?id=167287
1930
1931         Reviewed by Alex Christensen.
1932
1933         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1934         (CMakeGenerator._compute_link_flags):
1935         (CMakeGenerator._compute_link_flags.keep_flag):
1936         (CMakeGenerator._generate_compile_target_options):
1937
1938 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1939
1940         [WebRTC] Make VP8 optional in libwebrtc
1941         https://bugs.webkit.org/show_bug.cgi?id=167257
1942
1943         Reviewed by Darin Adler.
1944
1945         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1946         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1947
1948 2017-01-23  Jer Noble  <jer.noble@apple.com>
1949
1950         Video details does not apear and missing scrubber in Control Center
1951         https://bugs.webkit.org/show_bug.cgi?id=167233
1952
1953         Reviewed by Alex Christensen.
1954
1955         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1956         NowPlayingControlTests for iOS.
1957
1958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1959         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1960         (-[NowPlayingTestWebView setWindowVisible:]):
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1963         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1964         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1965         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1966         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1967         (SOFT_LINK_CLASS):
1968         (-[TestMessageHandler addMessage:withHandler:]):
1969         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1970         (__simulated_forceClickAssociatedEventsMask):
1971         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1972         (-[TestWKWebViewHostWindow isKeyWindow]):
1973         (-[TestWKWebViewHostWindow makeKeyWindow]):
1974         (-[TestWKWebViewHostWindow resignKeyWindow]):
1975         (-[TestWKWebView initWithFrame:]):
1976         (-[TestWKWebView initWithFrame:configuration:]):
1977         (-[TestWKWebView _setUpTestWindow:]):
1978         (-[TestWKWebView performAfterReceivingMessage:action:]):
1979         (-[TestWKWebView loadTestPageNamed:]):
1980         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1981         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1982         (-[TestWKWebView waitForMessage:]):
1983         (-[TestWKWebView performAfterLoading:]):
1984         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1985         (-[TestWKWebView typeCharacter:]):
1986
1987 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1988
1989         Unreviewed. Bring back gtk-doc error messages after r209981.
1990
1991         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1992         impossible to know what's wrong.
1993
1994         * gtk/gtkdoc.py:
1995         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1996
1997 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1998
1999         [WebRTC] Update build system to make G711 optional in libwebrtc
2000         https://bugs.webkit.org/show_bug.cgi?id=167256
2001
2002         Reviewed by Alex Christensen.
2003
2004         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2005         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2006
2007 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2008
2009         Cleanup RuntimeEnabledFeatures
2010         https://bugs.webkit.org/show_bug.cgi?id=167228
2011
2012         Reviewed by Simon Fraser.
2013
2014         * DumpRenderTree/mac/DumpRenderTree.mm:
2015         (enableExperimentalFeatures):
2016         (resetWebPreferencesToConsistentValues):
2017         (setWebPreferencesForTestOptions):
2018         (resetWebViewToConsistentStateBeforeTesting):
2019         * DumpRenderTree/win/DumpRenderTree.cpp:
2020         (enableExperimentalFeatures):
2021         (resetWebPreferencesToConsistentValues):
2022         More closely match WebKitTestRunner initialization of preferences
2023         for experimental features.
2024
2025 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2026
2027         Build Fix for Windows DumpRenderTree after r210976
2028         https://bugs.webkit.org/show_bug.cgi?id=167115
2029
2030         * DumpRenderTree/win/DumpRenderTree.cpp:
2031         (resetWebPreferencesToConsistentValues):
2032
2033 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2034
2035         Remove outdated ENABLE(CSP_NEXT) build flag
2036         https://bugs.webkit.org/show_bug.cgi?id=167252
2037
2038         Reviewed by Brent Fulgham.
2039
2040         * Scripts/webkitperl/FeatureList.pm:
2041         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2042
2043 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2044
2045         Build Fix for Windows DumpRenderTree after r210976
2046
2047         * DumpRenderTree/win/DumpRenderTree.cpp:
2048         (resetWebPreferencesToConsistentValues):
2049
2050 2017-01-20  Antoine Quint  <graouts@apple.com>
2051
2052         Web Animations should be off by default and enabled as an experimental feature
2053         https://bugs.webkit.org/show_bug.cgi?id=167115
2054         <rdar://problem/30048963>
2055
2056         Reviewed by Joseph Pecoraro.
2057
2058         Turn Web Animations on in DRT.
2059
2060         * DumpRenderTree/mac/DumpRenderTree.mm:
2061         (resetWebPreferencesToConsistentValues):
2062         * DumpRenderTree/win/DumpRenderTree.cpp:
2063         (resetWebPreferencesToConsistentValues):
2064
2065 2017-01-20  Youenn Fablet  <youenn@apple.com>
2066
2067         [WebRTC] Add libwebrtc build infrastructure
2068         https://bugs.webkit.org/show_bug.cgi?id=167207
2069
2070         Reviewed by Alex Christensen.
2071
2072         Adding a script doing the libwebrtc project json to CMake file conversion.
2073
2074         * Scripts/generate-libwebrtc-cmake: Added.
2075         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2076         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2077
2078 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2079
2080         Mini Browser: Show tooltip for Experimental Features
2081         https://bugs.webkit.org/show_bug.cgi?id=167225
2082
2083         Reviewed by Alex Christensen.
2084
2085         * MiniBrowser/mac/SettingsController.m:
2086         (-[SettingsController _populateMenu]):
2087         Include the full details string as a tooltip.
2088
2089 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2090
2091         [Win] Test output results should not be written twice.
2092         https://bugs.webkit.org/show_bug.cgi?id=167197
2093
2094         Reviewed by Brent Fulgham.
2095
2096         Prevent test output from being written twice by returning early from
2097         the dump() function, if it already has been called.
2098         This patch also adds a missing newline to a test output line. 
2099         
2100         * DumpRenderTree/win/DumpRenderTree.cpp:
2101         (dump):
2102
2103 2017-01-20  Antoine Quint  <graouts@apple.com>
2104
2105         [Modern Media Controls] Turn modern media controls on by default
2106         https://bugs.webkit.org/show_bug.cgi?id=165668
2107
2108         Reviewed by Dean Jackson.
2109
2110         Enabled modern media controls by default in test runners.
2111
2112         * DumpRenderTree/TestOptions.h:
2113         * WebKitTestRunner/TestOptions.h:
2114
2115 2017-01-19  Chris Dumez  <cdumez@apple.com>
2116
2117         iterable<> should be enabled on WK1
2118         https://bugs.webkit.org/show_bug.cgi?id=167221
2119         <rdar://problem/30108531>
2120
2121         Reviewed by Youenn Fablet.
2122
2123         * DumpRenderTree/mac/DumpRenderTree.mm:
2124         (resetWebPreferencesToConsistentValues):
2125         * DumpRenderTree/win/DumpRenderTree.cpp:
2126         (resetWebPreferencesToConsistentValues):
2127         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2128         (WTR::InjectedBundle::beginTesting):
2129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2130         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2131         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2132
2133 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2134
2135         Ensure status server logs go to log file
2136         https://bugs.webkit.org/show_bug.cgi?id=167210
2137
2138         Reviewed by Alexey Proskuryakov.
2139
2140         * Scripts/webkitpy/common/net/statusserver.py:
2141         (StatusServer.next_work_item): Change log level from debug to info in
2142         order to facilitate deubgging issues.
2143         (StatusServer.update_work_items): Same.
2144
2145 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2146
2147         Additional selection tests and interpolation fix
2148         https://bugs.webkit.org/show_bug.cgi?id=167171
2149
2150         Reviewed by Simon Fraser.
2151
2152         We weren't adding the final event when interpolating event streams.
2153
2154         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2155         (-[HIDEventGenerator interpolatedEvents:]):
2156
2157 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2158
2159         [Cocoa] Variation fonts are erroneously disabled on iOS
2160         https://bugs.webkit.org/show_bug.cgi?id=167172
2161
2162         Reviewed by Simon Fraser.
2163
2164         OpenSource builders don't seem to understand sdk=embedded*.
2165
2166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2167
2168 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2169
2170         Unreviewed. Fix GTK+ unit tests failing since r210531.
2171
2172         Avoid using paths to files that don't actually exist.
2173
2174         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2175         (testWebKitConsoleMessageNetworkError):
2176         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2177         (testContextMenuDefaultMenu):
2178         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2179         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2180         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2181
2182 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2183
2184         [GTK] Provide API to set proxy settings
2185         https://bugs.webkit.org/show_bug.cgi?id=128674
2186
2187         Reviewed by Michael Catanzaro.
2188
2189         Add tests for new proxy settings API.
2190
2191         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2192         (serverCallback):
2193         (ProxyTest::ProxyTest):
2194         (ProxyTest::~ProxyTest):
2195         (ProxyTest::loadURIAndGetMainResourceData):
2196         (ProxyTest::proxyServerPortAsString):
2197         (testWebContextProxySettings):
2198         (beforeAll):
2199
2200 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2201
2202         Add back my old email address so old commits will still match it.
2203
2204         * Scripts/webkitpy/common/config/contributors.json:
2205
2206 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2207
2208         Remove my old email address from contributors.json and watchlist.
2209
2210         * Scripts/validate-committer-lists:
2211         (CommitterListFromGit): Change the mapping to the correct email.
2212         * Scripts/webkitpy/common/config/contributors.json:
2213         * Scripts/webkitpy/common/config/watchlist:
2214
2215 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2216
2217         Unreviewed, rolling out r210848.
2218
2219         This change introduced media-related LayoutTest failures and
2220         crashes on macOS.
2221
2222         Reverted changeset:
2223
2224         "[Modern Media Controls] Turn modern media controls on by
2225         default"
2226         https://bugs.webkit.org/show_bug.cgi?id=165668
2227         http://trac.webkit.org/changeset/210848
2228
2229 2017-01-18  Andreas Kling  <akling@apple.com>
2230
2231         Document::securityOrigin() should return a reference.
2232         <https://webkit.org/b/167124>
2233
2234         Reviewed by Sam Weinig.
2235
2236         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2237         (TestWebKitAPI::TEST_F):
2238
2239 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2240
2241         [Win] Clipboard tests are flaky.
2242         https://bugs.webkit.org/show_bug.cgi?id=167088
2243
2244         Reviewed by Brent Fulgham.
2245
2246         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2247         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2248
2249         * DumpRenderTree/win/DumpRenderTree.cpp:
2250         (main):
2251
2252 2017-01-18  Antoine Quint  <graouts@apple.com>
2253
2254         [Modern Media Controls] Turn modern media controls on by default
2255         https://bugs.webkit.org/show_bug.cgi?id=165668
2256
2257         Reviewed by Dean Jackson.
2258
2259         Enabled modern media controls by default in test runners. 
2260
2261         * DumpRenderTree/TestOptions.h:
2262         * WebKitTestRunner/TestOptions.h:
2263
2264 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2265
2266         Unreviewed, rolling out r210834
2267         https://bugs.webkit.org/show_bug.cgi?id=165668
2268
2269         It introduced dozens of test timeouts.
2270
2271         Reverted changeset:
2272         "[Modern Media Controls] Turn modern media controls on by default"
2273         https://bugs.webkit.org/show_bug.cgi?id=165668
2274         http://trac.webkit.org/changeset/210834
2275
2276 2017-01-17  Antoine Quint  <graouts@apple.com>
2277
2278         [Modern Media Controls] Turn modern media controls on by default
2279         https://bugs.webkit.org/show_bug.cgi?id=165668
2280
2281         Reviewed by Dean Jackson.
2282
2283         Enabled modern media controls by default in test runners. 
2284
2285         * DumpRenderTree/TestOptions.h:
2286         * WebKitTestRunner/TestOptions.h:
2287
2288 2017-01-17  Chris Dumez  <cdumez@apple.com>
2289
2290         Document title changed twice when setting document.title
2291         https://bugs.webkit.org/show_bug.cgi?id=167065
2292
2293         Reviewed by Darin Adler.
2294
2295         Add WebKit2GTK API test that was written by Michael Catanzaro.
2296
2297         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2298         (testWebViewTitleChange):
2299         (beforeAll):
2300
2301 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2302
2303         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2304         https://bugs.webkit.org/show_bug.cgi?id=116551
2305         <rdar://problem/13949830>
2306
2307         Reviewed by Alex Christensen.
2308
2309         * Scripts/webkitperl/FeatureList.pm:
2310         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2311         that is part of the existing WEB_TIMING feature.
2312
2313         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2314
2315 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2316
2317         'webkit-patch post' no longer works with moved/copied files
2318         https://bugs.webkit.org/show_bug.cgi?id=166914
2319         <rdar://problem/29979707>
2320
2321         Reviewed by Daniel Bates.
2322
2323         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2324         file outputs only the "Index:" line with an empty body.  This workaround
2325         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2326         public email list tracking this bug is below.
2327         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2328         
2329
2330         * Scripts/svn-create-patch:
2331         (generateDiff): Ignore an "Index:" line with an empty body.
2332
2333 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2334
2335         Remove the REQUEST_ANIMATION_FRAME flag
2336         https://bugs.webkit.org/show_bug.cgi?id=156980
2337         <rdar://problem/25906849>
2338
2339         Reviewed by Simon Fraser.
2340
2341         * Scripts/webkitperl/FeatureList.pm:
2342         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2343
2344 2017-01-15  Sam Weinig  <sam@webkit.org>
2345
2346         Add the ability to use numbers in makeString()
2347         https://bugs.webkit.org/show_bug.cgi?id=167087
2348
2349         Reviewed by Darin Adler.
2350
2351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2352         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2353         Add tests for StringConcatenate, focusing on new numeric additions.
2354
2355 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2356
2357         Unreviewed, remove stale comment.
2358
2359         This test was fixed by r163173.
2360
2361         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2362
2363 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2364
2365         Annotate large string tests with largeHeap
2366         https://bugs.webkit.org/show_bug.cgi?id=167054
2367
2368         Reviewed by Filip Pizlo.
2369
2370         * Scripts/run-javascriptcore-tests:
2371         * Scripts/run-jsc-stress-tests:
2372
2373 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2374
2375         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2376         https://bugs.webkit.org/show_bug.cgi?id=167043
2377
2378         Reviewed by Darin Adler.
2379
2380         * Scripts/webkitperl/FeatureList.pm:
2381
2382 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2383
2384         Remove ENABLE(DETAILS_ELEMENT) guards
2385         https://bugs.webkit.org/show_bug.cgi?id=167042
2386
2387         Reviewed by Alex Christensen.
2388
2389         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2390
2391 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2392
2393         26 MotionMark performance tests failing
2394         https://bugs.webkit.org/show_bug.cgi?id=166854
2395
2396         Reviewed by Ryosuke Niwa.
2397
2398         Unrelated change. This is the last place that we need to rename Animometer
2399         to MotionMark.
2400
2401         * Scripts/webkitpy/common/config/watchlist:
2402
2403 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2404
2405         run-jsc-benchmarks' echo should have -e option
2406         https://bugs.webkit.org/show_bug.cgi?id=167009
2407
2408         Reviewed by Sam Weinig.
2409
2410         echo requires `-e` option to use escape sequence.
2411         Without it, in some environment (in my Fedora 25), the escape sequence is not
2412         recognized and just dumped as `\c` etc.
2413
2414         * Scripts/run-jsc-benchmarks:
2415
2416 2017-01-12  Chris Dumez  <cdumez@apple.com>
2417
2418         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2419         https://bugs.webkit.org/show_bug.cgi?id=166995
2420
2421         Reviewed by Jer Noble.
2422
2423         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2424         as some people are having trouble building without it.
2425
2426         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2427
2428 2017-01-12  Sam Weinig  <sam@webkit.org>
2429
2430         Add the ability to filter the set of bindings tests you want to run
2431         https://bugs.webkit.org/show_bug.cgi?id=166977
2432
2433         Reviewed by Tim Horton.
2434
2435         Allows doing things like:
2436             run-bindings-tests TestObj* TestCEReactions*
2437         
2438         to run only those tests that match the patterns.
2439
2440         * Scripts/run-bindings-tests:
2441         (main):
2442         Switch to using optparse and pass the remaining args as the filters.
2443
2444         * Scripts/webkitpy/bindings/main.py:
2445         (BindingsTests.__init__):
2446         Store the pattens.
2447
2448         (BindingsTests.test_matches_patterns):
2449         Add helper predicate to determine if a test should be run. When no
2450         patterns are present, all tests should run.
2451
2452         (BindingsTests.run_tests):
2453         Filter tests using the passed in patterns.
2454
2455 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2456
2457         Followup fix after r210503.
2458         https://bugs.webkit.org/show_bug.cgi?id=166887
2459
2460         Reviewed by Alex Christensen.
2461
2462         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2463         duplicated file handle on Windows. This patch fixes the remaining call sites.
2464
2465         * DumpRenderTree/PixelDumpSupport.cpp:
2466         * DumpRenderTree/TestRunner.cpp:
2467         (TestRunner::waitToDumpWatchdogTimerFired):
2468         * DumpRenderTree/TestRunner.h:
2469         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2470         * DumpRenderTree/win/DumpRenderTree.cpp:
2471         * DumpRenderTree/win/DumpRenderTreeWin.h:
2472         * DumpRenderTree/win/TestRunnerWin.cpp:
2473         (TestRunner::setSpellCheckerLoggingEnabled):
2474
2475 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2476
2477         Add committer status for Megan
2478         https://bugs.webkit.org/show_bug.cgi?id=166954
2479
2480         Reviewed by Tim Horton.
2481
2482         Add committer status for Megan Gardner
2483
2484         * Scripts/webkitpy/common/config/contributors.json:
2485
2486 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2487
2488         Unreviewed test fix after r210599.
2489
2490         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2491         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2492
2493 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2494
2495         Unreviewed build fix after r210599.
2496
2497         Add missing files.
2498
2499         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2500         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2501
2502 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2503
2504         File scheme should not allow access of a resource on a different volume.
2505         https://bugs.webkit.org/show_bug.cgi?id=158552
2506         <rdar://problem/15307582>
2507
2508         Reviewed by Alex Christensen.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2511         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2512         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2513
2514 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2515
2516         Unreviewed, rolling out r210571.
2517
2518         This change broke the 32-bit macOS build and caused LayoutTest
2519         failures.
2520
2521         Reverted changeset:
2522
2523         "File scheme should not allow access of a resource on a
2524         different volume."
2525         https://bugs.webkit.org/show_bug.cgi?id=158552
2526         http://trac.webkit.org/changeset/210571
2527
2528 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2529
2530         [GTK] install-dependencies script misses gdb
2531         https://bugs.webkit.org/show_bug.cgi?id=166917
2532
2533         Reviewed by Michael Catanzaro.
2534
2535         gdb is needed for generating the crash logs.
2536
2537         * gtk/install-dependencies:
2538
2539 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2540
2541         [GTK] No way for applications to set notification permissions without waiting for permission request
2542         https://bugs.webkit.org/show_bug.cgi?id=163366
2543
2544         Reviewed by Carlos Garcia Campos.
2545
2546         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2547         (testWebViewNotification):
2548         (setInitialNotificationPermissionsAllowedCallback):
2549         (setInitialNotificationPermissionsDisallowedCallback):
2550         (testWebViewNotificationInitialPermissionAllowed):
2551         (testWebViewNotificationInitialPermissionDisallowed):
2552         (beforeAll):
2553         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2554         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2555         (WebViewTest::WebViewTest):
2556         (WebViewTest::initializeWebView):
2557         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2558
2559 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2560
2561         MobileMiniBrowser tests don't work by default
2562         https://bugs.webkit.org/show_bug.cgi?id=166910
2563
2564         Reviewed by Alex Christensen.
2565
2566         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2567         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2568
2569 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2570
2571         File scheme should not allow access of a resource on a different volume.
2572         https://bugs.webkit.org/show_bug.cgi?id=158552
2573         <rdar://problem/15307582>
2574
2575         Reviewed by Alex Christensen.
2576
2577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2578         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2579         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2580
2581 2017-01-10  Mark Lam  <mark.lam@apple.com>
2582
2583         Reverting run-jsc-stress-tests' $buildType to use string values.
2584         https://bugs.webkit.org/show_bug.cgi?id=166912
2585
2586         Rubber stamped by Filip Pizlo.
2587
2588         This is so that we can test for it in the tests e.g.
2589         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2590
2591         * Scripts/run-jsc-stress-tests:
2592
2593 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2594
2595         Temporarily add back the file removed in r210463 to unbreak internal bots.
2596
2597         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2598
2599 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2600
2601         svn-apply failed to apply a patch (deleting file with svn property)
2602         https://bugs.webkit.org/show_bug.cgi?id=165953
2603
2604         Reviewed by Daniel Bates.
2605
2606         * Scripts/VCSUtils.pm:
2607         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2608         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2609
2610 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2611
2612         Update flakiness dashboard configuration.
2613         https://bugs.webkit.org/show_bug.cgi?id=166869
2614
2615         Reviewed by Alexey Proskuryakov.
2616
2617         * TestResultServer/static-dashboards/builders.jsonp:
2618         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2619
2620 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2621
2622         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2623         https://bugs.webkit.org/show_bug.cgi?id=165232
2624
2625         Unreviewed follow-up patch after r210539 and r210523.
2626
2627         Instead of using that environment variable, the argument
2628         --display-server=xorg should be passed now.
2629
2630         The GTK+ performance bot was the only bot using this, and is
2631         already passing --display-server=xorg after r210539.
2632
2633         * Scripts/webkitpy/port/gtk.py:
2634         (GtkPort._driver_class):
2635
2636 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2637
2638         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2639         https://bugs.webkit.org/show_bug.cgi?id=166872
2640
2641         Reviewed by Michael Catanzaro.
2642
2643         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2644         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2645         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2646         The step RunWebKitTests already has support for it.
2647
2648         * BuildSlaveSupport/build.webkit.org-config/config.json:
2649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2650         (RunGtkAPITests.start):
2651         (RunAndUploadPerfTests.start):
2652         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2653
2654 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2655
2656         Unreviewed, rolling out r210531.
2657
2658         This change broke the 32-bit macOS build and caused LayoutTest
2659         failures.
2660
2661         Reverted changeset:
2662
2663         "File scheme should not allow access of a resource on a
2664         different volume."
2665         https://bugs.webkit.org/show_bug.cgi?id=158552
2666         http://trac.webkit.org/changeset/210531
2667
2668 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2669
2670         File scheme should not allow access of a resource on a different volume.
2671         https://bugs.webkit.org/show_bug.cgi?id=158552
2672         <rdar://problem/15307582>
2673
2674         Reviewed by Alex Christensen.
2675
2676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2677         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2678         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2679
2680 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2681
2682         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2683         https://bugs.webkit.org/show_bug.cgi?id=165232
2684
2685         Reviewed by Michael Catanzaro.
2686
2687         Add a new WaylandDriver to run the tests in the user current wayland session.
2688
2689         Also merge all the configuration options for selecting the display server inside one
2690         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2691
2692         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2693
2694         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2695         (TestRunner._create_driver):
2696         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2697         (parse_args):
2698         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2699         (PerfTestsRunner._parse_args):
2700         * Scripts/webkitpy/port/gtk.py:
2701         (GtkPort.__init__):
2702         (GtkPort._driver_class):
2703         (GtkPort._search_paths):
2704         * Scripts/webkitpy/port/waylanddriver.py: Added.
2705         (WaylandDriver):
2706         (WaylandDriver.check_driver):
2707         (WaylandDriver._setup_environ_for_test):
2708         (WaylandDriver._start):
2709
2710 2017-01-09  Andy Estes  <aestes@apple.com>
2711
2712         [QuickLook] Add a layout test for webkit.org/b/135651
2713         https://bugs.webkit.org/show_bug.cgi?id=166855
2714
2715         Reviewed by Andreas Kling.
2716
2717         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2718         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2719         errors with code WebKitErrorCannotShowURL.
2720         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2721         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2722         not specific to WebKit2 error codes.
2723
2724 2017-01-09  Antoine Quint  <graouts@apple.com>
2725
2726         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2727         https://bugs.webkit.org/show_bug.cgi?id=166837
2728
2729         Reviewed by Alex Christensen.
2730
2731         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2732         the provided value when trying to determine the path to the test file. Failing
2733         that, we use the computed URL or the raw path provided to cover all cases.
2734         
2735         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2736         by applying this patch and seeing the number test failures dramatically reduced
2737         with WK1 due to the option to turn modern media controls off for older media controls
2738         tests.
2739
2740         * DumpRenderTree/DumpRenderTree.h:
2741         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2742         (parseInputLine):
2743         * DumpRenderTree/TestOptions.h:
2744         * DumpRenderTree/TestOptions.mm:
2745         (TestOptions::TestOptions):
2746         * DumpRenderTree/mac/DumpRenderTree.mm:
2747         (runTest):
2748
2749 2017-01-09  Milan Crha  <mcrha@redhat.com>
2750
2751         prepare-ChangeLog: Correct help string for --style option
2752         https://bugs.webkit.org/show_bug.cgi?id=166725
2753
2754         Reviewed by Alexey Proskuryakov.
2755
2756         * Scripts/prepare-ChangeLog:
2757         (main):
2758
2759 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=166839
2762         Add php7 support for macOS.
2763         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2764
2765         Reviewed by Alexey Proskuryakov.
2766
2767         * Scripts/webkitpy/port/base.py:
2768         (Port._is_darwin_php_version_7):
2769         (Port._debian_php_version):
2770         (Port):
2771         (Port._darwin_php_version):
2772         (Port._apache_config_file_name_for_platform):
2773
2774 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2775
2776         [GTK] Should support key and code properties on keyboard events
2777         https://bugs.webkit.org/show_bug.cgi?id=166759
2778
2779         Reviewed by Carlos Garcia Campos.
2780
2781         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2782         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2783         on tests.
2784
2785 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2786
2787         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2788         https://bugs.webkit.org/show_bug.cgi?id=166760
2789
2790         Reviewed by Darin Adler.
2791
2792         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2793         We can work around that by duplicating and redirecting stdout.
2794
2795         * DumpRenderTree/PixelDumpSupport.cpp:
2796         (dumpWebViewAsPixelsAndCompareWithExpected):
2797         (printPNG):
2798         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2799         (logEventProc):
2800         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2801         (DRTDesktopNotificationPresenter::showDesktopNotification):
2802         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2803         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2804         * DumpRenderTree/win/DumpRenderTree.cpp:
2805         (dumpFrameScrollPosition):
2806         (dumpHistoryItem):
2807         (dumpBackForwardList):
2808         (dump):
2809         (runTest):
2810         (main):
2811         * DumpRenderTree/win/DumpRenderTreeWin.h:
2812         * DumpRenderTree/win/EditingDelegate.cpp:
2813         (EditingDelegate::shouldBeginEditingInDOMRange):
2814         (EditingDelegate::shouldEndEditingInDOMRange):
2815         (EditingDelegate::shouldInsertNode):
2816         (EditingDelegate::shouldInsertText):
2817         (EditingDelegate::shouldDeleteDOMRange):
2818         (EditingDelegate::shouldChangeSelectedDOMRange):
2819         (EditingDelegate::shouldApplyStyle):
2820         (EditingDelegate::shouldChangeTypingStyle):
2821         (EditingDelegate::doPlatformCommand):
2822         (EditingDelegate::webViewDidBeginEditing):
2823         (EditingDelegate::webViewDidChange):
2824         (EditingDelegate::webViewDidEndEditing):
2825         (EditingDelegate::webViewDidChangeTypingStyle):
2826         (EditingDelegate::webViewDidChangeSelection):
2827         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2828         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2829         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2830         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2831         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2832         (FrameLoadDelegate::didCommitLoadForFrame):
2833         (FrameLoadDelegate::didReceiveTitle):
2834         (FrameLoadDelegate::didFinishLoadForFrame):
2835         (FrameLoadDelegate::didFailLoadWithError):
2836         (FrameLoadDelegate::willPerformClientRedirectToURL):
2837         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2838         (FrameLoadDelegate::windowScriptObjectAvailable):
2839         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2840         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2841         (FrameLoadDelegate::didDisplayInsecureContent):
2842         (FrameLoadDelegate::didRunInsecureContent):
2843         (FrameLoadDelegate::webViewProgressFinishedNotification):
2844         * DumpRenderTree/win/HistoryDelegate.cpp:
2845         (HistoryDelegate::didNavigateWithNavigationData):
2846         (HistoryDelegate::didPerformClientRedirectFromURL):
2847         (HistoryDelegate::didPerformServerRedirectFromURL):
2848         (HistoryDelegate::updateHistoryTitle):
2849         (HistoryDelegate::populateVisitedLinksForWebView):
2850         * DumpRenderTree/win/PolicyDelegate.cpp:
2851         (PolicyDelegate::decidePolicyForNavigationAction):
2852         (PolicyDelegate::unableToImplementPolicyWithError):
2853         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2854         (ResourceLoadDelegate::willSendRequest):
2855         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2856         (ResourceLoadDelegate::didReceiveResponse):
2857         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2858         (ResourceLoadDelegate::didFailLoadingWithError):
2859         * DumpRenderTree/win/TestRunnerWin.cpp:
2860         (TestRunner::addDisallowedURL):
2861         (TestRunner::originsWithApplicationCache):
2862         (TestRunner::setStorageDatabaseIdleInterval):
2863         (TestRunner::closeIdleLocalStorageDatabases):
2864         (TestRunner::copyDecodedHostName):
2865         (TestRunner::copyEncodedHostName):
2866         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2867         (TestRunner::isGeolocationProviderActive):
2868         (TestRunner::pathToLocalResource):
2869         (TestRunner::setMockDeviceOrientation):
2870         (TestRunner::setMockGeolocationPosition):
2871         (TestRunner::setMockGeolocationPositionUnavailableError):
2872         (TestRunner::setSpatialNavigationEnabled):
2873         (TestRunner::setAutomaticLinkDetectionEnabled):
2874         (TestRunner::isCommandEnabled):
2875         (TestRunner::authenticateSession):
2876         (TestRunner::addChromeInputField):
2877         (TestRunner::removeChromeInputField):
2878         (TestRunner::focusWebView):
2879         (TestRunner::grantWebNotificationPermission):
2880         (TestRunner::denyWebNotificationPermission):
2881         (TestRunner::removeAllWebNotificationPermissions):
2882         (TestRunner::simulateWebNotificationClick):
2883         (TestRunner::imageCountInGeneralPasteboard):
2884         * DumpRenderTree/win/UIDelegate.cpp:
2885         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2886         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2887         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2888         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2889         (UIDelegate::webViewAddMessageToConsole):
2890         (UIDelegate::exceededDatabaseQuota):
2891         (UIDelegate::setStatusText):
2892         (UIDelegate::didPressMissingPluginButton):
2893
2894 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2895
2896         Add a setting to create editable MiniBrowser windows by default
2897         https://bugs.webkit.org/show_bug.cgi?id=166806
2898
2899         Reviewed by Beth Dakin.
2900
2901         * MiniBrowser/mac/AppDelegate.m:
2902         (-[BrowserAppDelegate createBrowserWindowController:]):
2903         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2904         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2905         * MiniBrowser/mac/SettingsController.h:
2906         * MiniBrowser/mac/SettingsController.m:
2907         (-[SettingsController _populateMenu]):
2908         (-[SettingsController validateMenuItem:]):
2909         (-[SettingsController toggleCreateEditorByDefault:]):
2910         (-[SettingsController createEditorByDefault]):
2911         Add a setting and update the key equivalents accordingly.
2912         Also make sure to make the right kind of window on launch.
2913
2914 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2915
2916         Fix the 32-bit build.
2917
2918         * MiniBrowser/mac/BrowserWindowController.h:
2919         * MiniBrowser/mac/BrowserWindowController.m:
2920
2921 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2922
2923         Fix the 32-bit build.
2924
2925         * MiniBrowser/mac/BrowserWindowController.m:
2926
2927 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2928
2929         Make it possible to drop HTML files on the MiniBrowser icon
2930         https://bugs.webkit.org/show_bug.cgi?id=166802
2931
2932         Reviewed by Simon Fraser.
2933
2934         * MiniBrowser/mac/AppDelegate.m:
2935         (-[BrowserAppDelegate application:openFile:]):
2936         * MiniBrowser/mac/Info.plist:
2937         If you're using an editable window, the usual trick of dropping on the
2938         window doesn't work anymore (it makes an <attachment> instead).
2939
2940 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2941
2942         MiniBrowser window gets smaller each time it is instantiated
2943         https://bugs.webkit.org/show_bug.cgi?id=166807
2944
2945         Reviewed by Andy Estes.
2946
2947         * MiniBrowser/mac/BrowserWindowController.m:
2948         (-[BrowserWindowController windowDidLoad]):
2949         * MiniBrowser/mac/BrowserWindow.xib:
2950         Turn on full-window content view support with IB, instead of waiting
2951         until after the views have been loaded. This seems to resolve the
2952         longstanding ever-shrinking-window problem.
2953
2954 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2955
2956         Add indent/outdent items to MiniBrowser's new format menu
2957         https://bugs.webkit.org/show_bug.cgi?id=166805
2958
2959         Reviewed by Dan Bernstein.
2960
2961         * MiniBrowser/mac/MainMenu.xib:
2962
2963 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2964
2965         Add a stock Format menu to MiniBrowser
2966         https://bugs.webkit.org/show_bug.cgi?id=166804
2967
2968         Reviewed by Andy Estes.
2969
2970         * MiniBrowser/mac/MainMenu.xib:
2971         Many of the features automatically work with editable web views.
2972         However, this seems to expose a bug where none of the font-related features
2973         (Cmd-B, for example) work until the first time the font panel is shown,
2974         per process, which will need to be investigated separately.
2975
2976 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2977
2978         Remove unused applicationWillTerminate methods from MiniBrowser
2979         https://bugs.webkit.org/show_bug.cgi?id=166803
2980
2981         Reviewed by Andy Estes.
2982
2983         * MiniBrowser/mac/AppDelegate.m:
2984         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2985         * MiniBrowser/mac/BrowserWindowController.h:
2986         * MiniBrowser/mac/BrowserWindowController.m:
2987         (-[BrowserWindowController applicationTerminating]): Deleted.
2988         * MiniBrowser/mac/WK1BrowserWindowController.m:
2989         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2990         * MiniBrowser/mac/WK2BrowserWindowController.m:
2991         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2992
2993 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2994
2995         Add the ability to create empty contentEditable windows in MiniBrowser
2996         https://bugs.webkit.org/show_bug.cgi?id=166801
2997
2998         Reviewed by Wenson Hsieh.
2999
3000         * MiniBrowser/mac/AppDelegate.h:
3001         * MiniBrowser/mac/AppDelegate.m:
3002         (-[BrowserAppDelegate createBrowserWindowController:]):
3003         (-[BrowserAppDelegate newWindow:]):
3004         (-[BrowserAppDelegate newEditorWindow:]):
3005         (-[BrowserAppDelegate openDocument:]):
3006         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3007         * MiniBrowser/mac/BrowserWindowController.h:
3008         * MiniBrowser/mac/BrowserWindowController.m:
3009         (-[BrowserWindowController loadHTMLString:]):
3010         (-[BrowserWindowController toggleEditable:]):
3011         * MiniBrowser/mac/MainMenu.xib:
3012         * MiniBrowser/mac/WK1BrowserWindowController.m:
3013         (-[WK1BrowserWindowController awakeFromNib]):
3014         (-[WK1BrowserWindowController loadHTMLString:]):
3015         (-[WK1BrowserWindowController validateMenuItem:]):
3016         (-[WK1BrowserWindowController setEditable:]):
3017         (-[WK1BrowserWindowController updateTitle:]):
3018         * MiniBrowser/mac/WK2BrowserWindowController.m:
3019         (-[WK2BrowserWindowController awakeFromNib]):
3020         (-[WK2BrowserWindowController validateMenuItem:]):
3021         (-[WK2BrowserWindowController setEditable:]):
3022         (-[WK2BrowserWindowController updateTitle:]):
3023         (-[WK2BrowserWindowController loadHTMLString:]):
3024         Merge more functionality from WebEditingTester.
3025         Add two menu items for creating empty editable WebKit1/2 windows.
3026         Add a menu item to the Edit menu to toggle editability on any window.
3027
3028 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3029
3030         Implement find-in-page in MiniBrowser
3031         https://bugs.webkit.org/show_bug.cgi?id=166799
3032
3033         Reviewed by Andy Estes.
3034
3035         * MiniBrowser/mac/BrowserWindow.xib:
3036         * MiniBrowser/mac/BrowserWindowController.h:
3037         * MiniBrowser/mac/BrowserWindowController.m:
3038         (-[BrowserWindowController find:]): Deleted.
3039         * MiniBrowser/mac/MainMenu.xib:
3040         * MiniBrowser/mac/WK1BrowserWindowController.m:
3041         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3042         (-[WK1BrowserWindowController find:]): Deleted.
3043         * MiniBrowser/mac/WK2BrowserWindowController.m:
3044         (-[WK2BrowserWindowController awakeFromNib]):
3045         (-[WK2BrowserWindowController dealloc]):
3046         (-[WK2BrowserWindowController validateMenuItem:]):
3047         (-[WK2BrowserWindowController performTextFinderAction:]):
3048         (-[WK2BrowserWindowController findBarView]):
3049         (-[WK2BrowserWindowController setFindBarView:]):
3050         (-[WK2BrowserWindowController isFindBarVisible]):
3051         (-[WK2BrowserWindowController setFindBarVisible:]):
3052         (-[WK2BrowserWindowController contentView]):
3053         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3054         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3055         (-[WK2BrowserWindowController find:]): Deleted.
3056         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3057         protocol. At first glance, it's pretty broken, but vaguely works.
3058
3059 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3060
3061         Share the implementation of MiniBrowser view hiding functionality
3062         https://bugs.webkit.org/show_bug.cgi?id=166800
3063
3064         Reviewed by Andy Estes.
3065
3066         * MiniBrowser/mac/BrowserWindowController.m:
3067         (-[BrowserWindowController showHideWebView:]):
3068         (-[BrowserWindowController removeReinsertWebView:]):
3069         * MiniBrowser/mac/WK1BrowserWindowController.m:
3070         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3071         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3072         * MiniBrowser/mac/WK2BrowserWindowController.m:
3073         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3074         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3075         Move the implementation of these two things to the shared superclass,
3076         since they don't depend on WebKit-specific things.
3077         Also, there was no reason to retain the (WK)WebView while it was unparented,
3078         as the BrowserWindowController maintains a reference the entire time.
3079
3080 2017-01-06  Andy Estes  <aestes@apple.com>
3081
3082         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3083         https://bugs.webkit.org/show_bug.cgi?id=166789
3084
3085         Reviewed by Alex Christensen.
3086
3087         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3088         * DumpRenderTree/PlatformMac.cmake:
3089         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3090         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3091         * DumpRenderTree/mac/DumpRenderTree.mm:
3092         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3093         createXMLStringFromWebArchiveData().
3094         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3095         * WebKitTestRunner/Configurations/Base.xcconfig:
3096         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3097         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3098         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3099         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3100         createXMLStringFromWebArchiveData().
3101         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3102         * WebKitTestRunner/PlatformMac.cmake:
3103         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3104         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3105
3106 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3107
3108         Minor cleanups to IndentOutdentCommand and related code
3109         https://bugs.webkit.org/show_bug.cgi?id=166791
3110
3111         Reviewed by Simon Fraser.
3112
3113         * WebEditingTester/EditingOperations.m:
3114         (editingOperations):
3115         Add the outdent operation to WebEditingTester.
3116
3117 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3118
3119         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3120         https://bugs.webkit.org/show_bug.cgi?id=166785
3121
3122         Reviewed by Ryosuke Niwa.
3123
3124         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3125         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3126
3127 2017-01-06  Antoine Quint  <graouts@apple.com>
3128
3129         Support webkit-test-runner key-value pairs in http tests
3130         https://bugs.webkit.org/show_bug.cgi?id=149812
3131
3132         Reviewed by Alex Christensen.
3133
3134         We pass the absolute path for a test through to WKTR so that we can parse
3135         tests that are running as URLs for webkit-test-runner options.
3136
3137         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3138         (parseInputLine):
3139
3140         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3141
3142         * Scripts/webkitpy/port/driver.py:
3143         (Driver._command_from_driver_input):
3144
3145         Pass the absolute path to the file through the CLI.
3146
3147         * WebKitTestRunner/TestController.cpp:
3148         (WTR::updateTestOptionsFromTestHeader):
3149         (WTR::TestController::testOptionsForTest):
3150         (WTR::parseInputLine):
3151         (WTR::TestController::runTest):
3152         * WebKitTestRunner/TestController.h:
3153
3154 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3155
3156         Warning about unconnectable outlets when opening a MiniBrowser window
3157         https://bugs.webkit.org/show_bug.cgi?id=166756
3158
3159         Reviewed by Dan Bernstein.
3160
3161         * MiniBrowser/mac/BrowserWindow.xib:
3162         When launching MiniBrowser, it says:
3163         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3164             (MBToolbarItem): missing setter or instance variable
3165         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3166             (NSButtonCell): missing setter or instance variable.
3167
3168         It looks like someone added the connection from the share button
3169         to the BrowserWindowController three times; only one of the connections
3170         is valid. Remove the other two.
3171
3172 2017-01-05  Keith Rollin  <krollin@apple.com>
3173
3174         Add WebCore::URL::protocolHostAndPort
3175         https://bugs.webkit.org/show_bug.cgi?id=166426
3176
3177         Reviewed by Alex Christensen.
3178
3179         Add test for protocolHostAndPort.
3180
3181         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3182         (TestWebKitAPI::TEST_F):
3183
3184 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3185
3186         [Win] Archive test result is failing.
3187         https://bugs.webkit.org/show_bug.cgi?id=166720
3188
3189         Reviewed by Alex Christensen.
3190
3191         Deleting the layout test result folder is sometimes failing
3192         on Windows. This is not a critical error.
3193
3194         * BuildSlaveSupport/test-result-archive:
3195         (archiveTestResults):
3196
3197 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3198
3199         [GTK] Minibrowser: Add printing support
3200         https://bugs.webkit.org/show_bug.cgi?id=165298
3201
3202         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3203         an error during the print, it's printed on the console.
3204
3205         Reviewed by Michael Catanzaro.
3206
3207         * MiniBrowser/gtk/BrowserWindow.c:
3208         (webKitPrintOperationFailedCallback):
3209         (printPage):
3210         (browser_window_init):
3211
3212 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3213
3214         [css-grid] Fix crash clamping grid lines
3215         https://bugs.webkit.org/show_bug.cgi?id=166637
3216
3217         Reviewed by Darin Adler.
3218
3219         Creates new unit test to verify that the maximum tracks limit
3220         is used in GridPosition too.
3221
3222         * TestWebKitAPI/PlatformEfl.cmake:
3223         * TestWebKitAPI/PlatformGTK.cmake:
3224         * TestWebKitAPI/PlatformWin.cmake:
3225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3226         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3227         (TestWebKitAPI::TEST):
3228
3229 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3230
3231         Move editing history scripts to WebCore PrivateHeaders
3232         https://bugs.webkit.org/show_bug.cgi?id=166709
3233         <rdar://problem/29876612>
3234
3235         Reviewed by Dan Bernstein.
3236
3237         Update references to editing script files in WebCore that were moved.
3238
3239         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3240
3241 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3242
3243         Unreviewed, build fix after r210313 part 2
3244         https://bugs.webkit.org/show_bug.cgi?id=166676
3245
3246         Add 'U' suffix.
3247
3248         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3249         (TestWebKitAPI::TEST):
3250         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3251         (TestWebKitAPI::TEST):
3252
3253 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3254
3255         Limit thread name appropriately
3256         https://bugs.webkit.org/show_bug.cgi?id=166676
3257
3258         Reviewed by Sam Weinig.
3259
3260         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3261         (TestWebKitAPI::TEST):
3262         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3263         (TestWebKitAPI::TEST):
3264
3265 2017-01-04  Andy Estes  <aestes@apple.com>
3266
3267         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3268         https://bugs.webkit.org/show_bug.cgi?id=166696
3269
3270         Reviewed by Tim Horton.
3271
3272         * TestWebKitAPI/PlatformGTK.cmake:
3273         * TestWebKitAPI/PlatformWin.cmake:
3274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3275         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3276         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3277         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3278         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3279         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3280         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3281
3282 2017-01-03  Brian Burg  <bburg@apple.com>
3283
3284         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3285         https://bugs.webkit.org/show_bug.cgi?id=166003
3286         <rdar://problem/28718990>
3287
3288         Reviewed by Joseph Pecoraro.
3289
3290         Teach run-inspector-generator-tests to generate test output using the platform name
3291         derived from the directory that the test is in. For example, tests in the /generic/
3292         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3293
3294         * Scripts/webkitpy/inspector/main.py:
3295         (InspectorGeneratorTests.generate_from_json):
3296         (InspectorGeneratorTests.run_tests):
3297         (InspectorGeneratorTests.main):
3298
3299 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3300
3301         Unreviewed cmake buildfix after r210266.
3302
3303         * DumpRenderTree/PlatformMac.cmake:
3304
3305 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3306
3307         Provide a setting for clients to always prefer low-power WebGL
3308         https://bugs.webkit.org/show_bug.cgi?id=166675
3309         <rdar://problem/29834093>
3310
3311         Reviewed by Dan Bernstein.
3312
3313         * MiniBrowser/mac/Info.plist:
3314         Have MiniBrowser claim to be a modern app that supports
3315         automatic graphics switching. WebKit needs to support automatic
3316         graphics switching, so our test app might as well. Without this
3317         Info.plist parameter, this change has no effect, and bringing up
3318         a WebGL context still brings up the discrete GPU (also true of the
3319         existing web-exposed preferLowPowerToHighPerformance API).
3320
3321 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3322
3323         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3324         https://bugs.webkit.org/show_bug.cgi?id=166645
3325
3326         Reviewed by Carlos Garcia Campos.
3327
3328         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3329         (TestWebKitAPI::TEST):
3330
3331 2017-01-03  Andy Estes  <aestes@apple.com>
3332
3333         Place all the Cocoa WebCore API tests in the same directory
3334         https://bugs.webkit.org/show_bug.cgi?id=166673
3335
3336         Reviewed by Michael Catanzaro.
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3340         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3341         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3342
3343 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3344
3345         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3346         https://bugs.webkit.org/show_bug.cgi?id=166450
3347         <rdar://problem/29447824>
3348
3349         Reviewed by Darin Adler.
3350
3351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3352         * DumpRenderTree/TestRunner.cpp:
3353         (TestRunner::staticFunctions):
3354         * DumpRenderTree/mac/TestRunnerMac.mm:
3355         (setSpellCheckerLoggingEnabledCallback):
3356         * DumpRenderTree/win/TestRunnerWin.cpp:
3357         (setSpellCheckerLoggingEnabledCallback):
3358         * DumpRenderTree/mac/DumpRenderTree.mm:
3359         (resetWebViewToConsistentStateBeforeTesting):
3360         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3361         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3362         (stringForCorrectionResponse):
3363         (drt_NSSpellChecker_recordResponseToCorrection):
3364         (swizzleNSSpellCheckerMethodsIfNeeded):
3365         (setSpellCheckerLoggingEnabled):
3366         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3367         set to true, logs to stdout (which ends up in the test result) whenever
3368         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3369         is called, and then calls the original method. It is reset to false between tests.
3370
3371 2017-01-03  Sam Weinig  <sam@webkit.org>
3372
3373         Make WTF::Expected support Ref template parameters
3374         https://bugs.webkit.org/show_bug.cgi?id=166662
3375
3376         Reviewed by Alex Christensen.
3377
3378         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3379         (TestWebKitAPI::TEST):
3380         Add tests for using Ref with Expected.
3381
3382 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3383
3384         [GTK] Expose WebKitSecurityOrigin API
3385         https://bugs.webkit.org/show_bug.cgi?id=166632
3386
3387         Reviewed by Carlos Garcia Campos.
3388
3389         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3390         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3391         (testSecurityOriginBasicConstructor):
3392         (testSecurityOriginURIConstructor):
3393         (testSecurityOriginDefaultPort):
3394         (testSecurityOriginFileURI):
3395         (testSecurityOriginDataURI):
3396         (beforeAll):
3397         (afterAll):
3398
3399 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [GTK] HTTP auth layout tests are flaky
3402         https://bugs.webkit.org/show_bug.cgi?id=158919
3403
3404         Reviewed by Michael Catanzaro.
3405
3406         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3407         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3408         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3409         missing valac in the bots.
3410
3411 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3412
3413         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3414         https://bugs.webkit.org/show_bug.cgi?id=165797
3415
3416         Reviewed by Michael Catanzaro.
3417
3418         Move directory ruleset after all exclude rules of Source rulset.
3419
3420         * gtk/manifest.txt.in:
3421
3422 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3423
3424         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3425         https://bugs.webkit.org/show_bug.cgi?id=166636
3426
3427         Reviewed by Darin Adler.
3428
3429         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3430         (TestWebKitAPI::TEST):
3431
3432 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3433
3434         [GTK] WebCore/CSSParser unit test is not being built
3435         https://bugs.webkit.org/show_bug.cgi?id=166492
3436
3437         Reviewed by Michael Catanzaro.
3438
3439         This test was introduced in r175930, but we were not building
3440         it on GTK+ port since r176015.
3441         This patch marks the test to be built again on GTK+.
3442         JFTR, the test is passing right now.
3443
3444         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3445         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3446
3447 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3448
3449         AX: Expose block quote level to iOS API
3450         https://bugs.webkit.org/show_bug.cgi?id=166629
3451         <rdar://problem/29834793>
3452
3453         Reviewed by Darin Adler.
3454
3455         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3456         (AccessibilityUIElement::numberAttributeValue):
3457         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3458         (WTR::AccessibilityUIElement::numberAttributeValue):
3459
3460 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3461
3462         SecurityOrigin::create triplet constructor does not canonicalize port
3463         https://bugs.webkit.org/show_bug.cgi?id=166624
3464
3465         Reviewed by Daniel Bates.
3466
3467         * TestWebKitAPI/PlatformGTK.cmake:
3468         * TestWebKitAPI/PlatformWin.cmake:
3469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3471         (TestWebKitAPI::SecurityOriginTest::SetUp):
3472         (TestWebKitAPI::TEST_F):
3473
3474 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3475
3476         [GTK] Improve user agent construction
3477         https://bugs.webkit.org/show_bug.cgi?id=142074
3478
3479         Reviewed by Carlos Garcia Campos.
3480
3481         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3482         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3483         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3484         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3485         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3486         (TestWebKitAPI::TEST):
3487
3488 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3489
3490         [GTK] Improve user agent construction
3491         https://bugs.webkit.org/show_bug.cgi?id=142074
3492
3493         Reviewed by Carlos Garcia Campos.
3494
3495         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3496         (TestWebKitAPI::TEST):
3497
3498 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3499
3500         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3501         https://bugs.webkit.org/show_bug.cgi?id=166472
3502         rdar://problem/29675551
3503
3504         Reviewed by Tim Horton.
3505
3506         These changes are necessary to allow the mouse to leave the WTR window while
3507         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3508         (which DRT does); we'd always go through mouseMoved, which hits an early return
3509         in WebViewImpl::mouseMoved() when the point is outside the view.
3510
3511         * WebKitTestRunner/mac/EventSenderProxy.mm:
3512         (WTR::EventSenderProxy::mouseMoveTo):
3513
3514 2016-12-23  Andy Estes  <aestes@apple.com>
3515
3516         [iOS] Fix some crashing webarchive tests
3517         https://bugs.webkit.org/show_bug.cgi?id=166470
3518
3519         Reviewed by Andreas Kling.
3520
3521         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3522         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3523         so this change uses that on both platforms.
3524
3525         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3526         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3527         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3528         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3529         * WebKitTestRunner/PlatformMac.cmake:
3530         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3531         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3532
3533 2016-12-22  Saam Barati  <sbarati@apple.com>
3534
3535         WebAssembly: Silence the output of the spec-tests
3536         https://bugs.webkit.org/show_bug.cgi?id=166417
3537
3538         Reviewed by Mark Lam.
3539
3540         * Scripts/run-jsc-stress-tests:
3541
3542 2016-12-22  Zhuo Li  <zachli@apple.com>
3543
3544         [Cocoa] SPI for setloadsImagesAutomatically.
3545         https://bugs.webkit.org/show_bug.cgi?id=166401.
3546
3547         Reviewed by Darin Adler.
3548
3549         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3550         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3551         _loadsImagesAutomatically returns YES.
3552
3553 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3554
3555         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3556         https://bugs.webkit.org/show_bug.cgi?id=161328
3557         <rdar://problem/28475977>
3558
3559         Reviewed by Darin Adler.
3560
3561         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3562         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3563         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3564         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3565         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3566         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3567         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3568         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3569         we finish running a test and before we load the next test.
3570
3571         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3572         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3573         previous test started zooming and then finished before zooming completed. Since this happens before the next
3574         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3575
3576         * WebKitTestRunner/ios/TestControllerIOS.mm:
3577         (WTR::TestController::platformResetStateToConsistentValues):
3578
3579 2016-12-22  Jer Noble  <jer.noble@apple.com>
3580
3581         Muted media element playback should not interrupt other audio playback
3582         https://bugs.webkit.org/show_bug.cgi?id=166347
3583
3584         Reviewed by Eric Carlson.
3585
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3588         (TestWebKitAPI::TEST):
3589         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3590
3591 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3592
3593         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3594         https://bugs.webkit.org/show_bug.cgi?id=166346
3595
3596         Reviewed by Carlos Garcia Campos.
3597
3598         Enable WebRTC by default to simplify testing.
3599
3600         * MiniBrowser/gtk/main.c:
3601         (main):
3602
3603 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3604
3605         REGRESSION: API test failure: WKWebView.LocalStorageClear
3606         https://bugs.webkit.org/show_bug.cgi?id=166032
3607         <rdar://problem/29758423>
3608
3609         Reviewed by Simon Fraser.
3610
3611         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3612         to ensure that the view is destroyed before the callback fires.
3613
3614         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3615         (TEST):
3616
3617 2016-12-21  Saam Barati  <sbarati@apple.com>
3618
3619         WebAssembly: Import spec tests
3620         https://bugs.webkit.org/show_bug.cgi?id=166395
3621
3622         Rubber stamped by Keith Miller.
3623
3624         * Scripts/run-jsc-stress-tests:
3625
3626 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3627
3628         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3629         https://bugs.webkit.org/show_bug.cgi?id=166033
3630         <rdar://problem/29758428>
3631
3632         Reviewed by Simon Fraser.
3633
3634         Add an @autoreleasepool around the code that allocates the WKWebView, 
3635         so that it can be destroyed by removing the last reference in _downloadDidStart.
3636
3637         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3638         (TEST):
3639
3640 2016-12-21  Daniel Bates  <dabates@apple.com>
3641
3642         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3643         https://bugs.webkit.org/show_bug.cgi?id=166356
3644
3645         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3646         as a means to allow a test to explicit allow an embedding client to open a new windows
3647         such that the default behavior is for the embedding client to forbid such an action.
3648         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3649         it is currently skipped on WebKit2 because questions were raised in the patch for
3650         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3651         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3652         this test.
3653
3654         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3655         (WTR::TestRunner::setCanOpenWindows):
3656
3657 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3658
3659         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3660         https://bugs.webkit.org/show_bug.cgi?id=166031
3661
3662         Reviewed by Tim Horton.
3663         
3664         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3665         to ensure that the view is destroyed before the callback fires.
3666
3667         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3668
3669 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3670
3671         Throw Exception when test doesn't clean up HID Events properly
3672         https://bugs.webkit.org/show_bug.cgi?id=166271
3673
3674         Reviewed by Simon Fraser.
3675
3676         Add in a check when UIScriptController is deleted to make sure that the HID event
3677         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3678         the program to crash without any good information. Crashes are race-y, and will still
3679         happen with malformed test, but the information will be much more helpful. 
3680
3681         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3682         (WTR::UIScriptController::checkForClean):
3683         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3684         (UIScriptContext::~UIScriptContext):
3685         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3686         (WTR::UIScriptController::checkForClean):
3687         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3688         * WebKitTestRunner/ios/HIDEventGenerator.h:
3689         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3690         (-[HIDEventGenerator checkHIDCallbacksClear]):
3691         * WebKitTestRunner/ios/TestControllerIOS.mm:
3692         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3693         (WTR::UIScriptController::checkForClean):
3694
3695 2016-12-20  Andy Estes  <aestes@apple.com>
3696
3697         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3698         https://bugs.webkit.org/show_bug.cgi?id=165992
3699
3700         Reviewed by Brady Eidson.
3701
3702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3703         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3704         (expectException):
3705         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3706         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3707         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3708         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3709         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3710         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3711         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3712         (TEST):
3713         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3714
3715 2016-12-20  Dean Jackson  <dino@apple.com>
3716
3717         Remove INDIE_UI
3718         https://bugs.webkit.org/show_bug.cgi?id=165881
3719         <rdar://problem/29672532>
3720
3721         Reviewed by Simon Fraser.
3722
3723         The Indie UI work has been discontinued.
3724
3725         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3726
3727 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3728
3729         [ES6] Enable ES6 Modules
3730         https://bugs.webkit.org/show_bug.cgi?id=165849
3731
3732         Reviewed by Geoffrey Garen.
3733
3734         * DumpRenderTree/mac/DumpRenderTree.mm:
3735         (resetWebPreferencesToConsistentValues):
3736         * DumpRenderTree/win/DumpRenderTree.cpp:
3737         (resetWebPreferencesToConsistentValues):
3738         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3739         (WTR::InjectedBundle::beginTesting):
3740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3741         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3743
3744 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3745
3746         Repurpose bots and clean up dashboard.
3747         https://bugs.webkit.org/show_bug.cgi?id=166045
3748
3749         Reviewed by Lucas Forschler.
3750
3751         * BuildSlaveSupport/build.webkit.org-config/config.json:
3752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3753         (BubbleQueueServer):
3754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3756         (WebKitBuildbot):
3757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3758         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3759
3760 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3761
3762         [CMake] TestWebKitAPIBase links to itself
3763         https://bugs.webkit.org/show_bug.cgi?id=165985
3764
3765         Reviewed by Alex Christensen.
3766
3767         Fix CMake warning about a target linking to itself, which makes no sense.
3768
3769         * TestWebKitAPI/CMakeLists.txt:
3770
3771 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3772
3773         [GTK] GtkDoc build should be quieter
3774         https://bugs.webkit.org/show_bug.cgi?id=165994
3775
3776         Reviewed by Carlos Garcia Campos.
3777
3778         Make it not print by default.
3779
3780         * gtk/generate-gtkdoc:
3781         (get_generator_for_config):
3782         (generate_doc):
3783         * gtk/gtkdoc.py:
3784         (GTKDoc._run_command):
3785         (GTKDoc._copy_doc_files_to_output_dir):
3786
3787 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3788
3789         Expose a way for MiniBrowser to simulate header and footer banners
3790         https://bugs.webkit.org/show_bug.cgi?id=166005
3791
3792         Reviewed by Wenson Hsieh.
3793         
3794         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3795         banners. This only works in WebKit2.
3796         
3797         We need to reset these on each navigation, since newly created FrameViews
3798         don't re-fetch the header and footer height stored on Page.
3799         
3800         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3801         as well as fixing webViewWebContentProcessDidTerminate:
3802
3803         * MiniBrowser/mac/SettingsController.h:
3804         * MiniBrowser/mac/SettingsController.m:
3805         (-[SettingsController _populateMenu]):
3806         (-[SettingsController validateMenuItem:]):
3807         (-[SettingsController toggleReserveSpaceForBanners:]):
3808         (-[SettingsController isSpaceReservedForBanners]):
3809         * MiniBrowser/mac/WK2BrowserWindowController.m:
3810         (-[WK2BrowserWindowController didChangeSettings]):
3811         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3812         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3813         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3814         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3815
3816 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3817
3818         Fix iOS test results after r209967.
3819         
3820         Subtracting out the status bar height was erroneously happening for all tests,
3821         not just for flexible viewport tests.
3822         
3823         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3824
3825         * WebKitTestRunner/PlatformWebView.h:
3826         * WebKitTestRunner/TestController.cpp:
3827         (WTR::TestController::resetStateToConsistentValues):
3828         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3829         (WTR::PlatformWebView::resizeTo):
3830         (WTR::PlatformWebView::setWindowFrame):
3831         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3832         (WTR::PlatformWebView::resizeTo):
3833         (WTR::PlatformWebView::setWindowFrame):
3834         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3835         (WTR::PlatformWebView::resizeTo):
3836         (WTR::PlatformWebView::setWindowFrame):
3837         * WebKitTestRunner/ios/TestControllerIOS.mm:
3838         (WTR::TestController::platformConfigureViewForTest):
3839         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3840         (WTR::PlatformWebView::resizeTo):
3841         (WTR::PlatformWebView::setWindowFrame):
3842
3843 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3844
3845         [EFL] bump EFL version to 1.18.4
3846         https://bugs.webkit.org/show_bug.cgi?id=166004
3847
3848         Reviewed by Gyuyoung Kim.
3849
3850         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3851
3852 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3853
3854         Visual viewports: bottom fixed elements disappear behind the keyboard
3855         https://bugs.webkit.org/show_bug.cgi?id=165983
3856         <rdar://problem/29409852>
3857
3858         Reviewed by Simon Fraser.
3859
3860         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3861         the keyboard when it is up.
3862
3863         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3864         (WTR::UIScriptController::inputViewBounds):
3865         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3866         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3867         (WTR::UIScriptController::inputViewBounds):
3868         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3869         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3870         (WTR::viewRectForWindowRect):
3871
3872         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3873         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3874         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3875
3876         (WTR::PlatformWebView::PlatformWebView):
3877         (WTR::PlatformWebView::setWindowFrame):
3878         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3879         (WTR::UIScriptController::inputViewBounds):
3880
3881 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3882
3883         Deleting a character converted from pinyin after an image causes a Safari crash
3884         https://bugs.webkit.org/show_bug.cgi?id=165839
3885         <rdar://problem/27951933>
3886
3887         Reviewed by Wenson Hsieh.
3888
3889         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3890         while the proposed range contains an image. This should not cause a WebProcess to crash
3891         or send an invalid message to the UIProcess.
3892
3893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3894         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3895         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3896         (TestWebKitAPI::didFinishLoadForFrame):
3897         (TestWebKitAPI::processDidCrash):
3898         (TestWebKitAPI::invalidMessageFunction):
3899         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3900
3901 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3902
3903         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3904         https://bugs.webkit.org/show_bug.cgi?id=165767
3905         <rdar://problem/29602382>
3906
3907         Reviewed by Simon Fraser.
3908
3909         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3910         WebKit2 ChangeLog for more details.
3911
3912         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3913         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3914         (WTR::UIScriptController::textSelectionCaretRect):
3915         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3916         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3917         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3918         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3919         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3920         (WTR::UIScriptController::textSelectionCaretRect):
3921         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3922         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3923         (-[TestRunnerWKWebView _setStableStateOverride:]):
3924
3925         Force the WKWebView to update its visible content rects when changing the stable state override.
3926
3927         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3928         (WTR::toNSDictionary):
3929         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3930         (WTR::UIScriptController::selectionRangeViewRects):
3931         (WTR::UIScriptController::textSelectionCaretRect):
3932         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3933         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3934
3935 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3936
3937         Arguments called in wrong order
3938         https://bugs.webkit.org/show_bug.cgi?id=165923
3939
3940         Reviewed by Simon Fraser.
3941
3942         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3943         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3944
3945         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3946         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3947         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3948
3949 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3950
3951         [EFL] Disable non-srcdir builds for failing libraries
3952         https://bugs.webkit.org/show_bug.cgi?id=165896
3953
3954         Reviewed by Gyuyoung Kim.
3955
3956         * efl/jhbuild.modules: Set non srcdir builds to no
3957
3958 2016-12-15  Daniel Bates  <dabates@apple.com>
3959
3960         check-style should not complain about code in icu directories
3961         https://bugs.webkit.org/show_bug.cgi?id=53929
3962
3963         Reviewed by Darin Adler.
3964
3965         Skip style checking of imported ICU headers to avoid a deluge of style issues
3966         as they do not conform to the WebKit Code Style guideline. We want to preserve
3967         the formatting of these headers so as to make it straightforward to merge
3968         changes to them, if necessary.
3969
3970         * Scripts/webkitpy/style/checker.py:
3971
3972 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3973
3974         Move JSC testers from Yosemite to Sierra
3975         https://bugs.webkit.org/show_bug.cgi?id=165925
3976
3977         Reviewed by Lucas Forschler.
3978
3979         * BuildSlaveSupport/build.webkit.org-config/config.json:
3980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3981         (WebKitBuildbot):
3982
3983 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3984
3985         Add coordinate space to event streams and streamline tests
3986         https://bugs.webkit.org/show_bug.cgi?id=165119
3987
3988         Reviewed by Simon Fraser.
3989
3990         Update event streams to allow for both content and global coordinate space.
3991         Update example script to more accurately show all the available options.
3992
3993         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3994         * WebKitTestRunner/ios/HIDEventGenerator.h:
3995         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3996         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3997         (WTR::convertCoordinates):
3998         (WTR::UIScriptController::sendEventStream):
3999
4000 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4001
4002         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4003         https://bugs.webkit.org/show_bug.cgi?id=165855
4004
4005         Reviewed by Philippe Normand.
4006
4007         GStreamer's autogen.sh enables gtk-doc always so we end up building
4008         docs even if we disable them. Use the configure script instead, since
4009         we build from packages and these include it already.
4010
4011         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4012         upstream gstreamer packages.
4013
4014 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4015
4016         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4017         https://bugs.webkit.org/show_bug.cgi?id=165885
4018         <rdar://problem/29476917>
4019
4020         Reviewed by Darin Adler.
4021
4022         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4023         (TestWebKitAPI::utf16String): Deleted.
4024         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4025         (TestWebKitAPI::TEST_F):
4026         * TestWebKitAPI/WTFStringUtilities.h:
4027         (utf16String):
4028         Moved from URLParser to share with other tests.
4029
4030 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4031
4032         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4033         https://bugs.webkit.org/show_bug.cgi?id=165843
4034
4035         Reviewed by Antti Koivisto.
4036
4037         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4038         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4039         and DumpRenderTree's runUIScript would hit an assertion :(
4040
4041         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4042         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4043         (WTR::TestRunner::isWebKit2):
4044
4045 2016-12-14  Brady Eidson  <beidson@apple.com>
4046
4047         IndexedDB 2.0: Massively speedup IDBIndex.get().
4048         https://bugs.webkit.org/show_bug.cgi?id=165802
4049
4050         Reviewed by Alex Christensen.
4051
4052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4053         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4054         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4055         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4056         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4057
4058 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4059
4060         [GTK][EFL] Update the JHBuild version.
4061         https://bugs.webkit.org/show_bug.cgi?id=165838
4062
4063         Reviewed by Michael Catanzaro.
4064
4065         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4066         usage of the JHBUILD_MIRROR feature with git repositories.
4067
4068 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4069
4070         [GTK] Yasm is needed for building the JHBuild after r208940
4071         https://bugs.webkit.org/show_bug.cgi?id=165837
4072
4073         Reviewed by Alejandro G. Castro.
4074
4075         * gtk/install-dependencies: Yasm is needed for building libvpx.
4076
4077 2016-12-14  Youenn Fablet  <youenn@apple.com>
4078
4079         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4080         https://bugs.webkit.org/show_bug.cgi?id=161310
4081
4082         Reviewed by Ryosuke Niwa.
4083
4084         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4085         When set, WTR and DRT output JS console log in the stderr and not the test output.
4086         This allows removing potentially flaky information while still being able to read it for investigation.
4087
4088         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4089
4090         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4091         This test should have this option when fetch API will start logging resource loader errors.
4092
4093         * DumpRenderTree/DumpRenderTree.h:
4094         (TestCommand::TestCommand): Deleted.
4095         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4096         (parseInputLine):
4097         * DumpRenderTree/TestRunner.h:
4098         (TestRunner::setDumpJSConsoleLogInStdErr):
4099         (TestRunner::dumpJSConsoleLogInStdErr):
4100         * DumpRenderTree/mac/DumpRenderTree.mm:
4101         (runTest):
4102         * DumpRenderTree/mac/UIDelegate.mm:
4103         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4104         * DumpRenderTree/win/DumpRenderTree.cpp:
4105         (runTest):
4106         * DumpRenderTree/win/UIDelegate.cpp:
4107         (UIDelegate::webViewAddMessageToConsole):
4108         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4109         (TestExpectationParser._tokenize_line):
4110         * Scripts/webkitpy/port/driver.py:
4111         (Driver._command_from_driver_input):
4112         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4113         (WTR::InjectedBundle::didReceiveMessageToPage):
4114         (WTR::InjectedBundle::dumpToStdErr):
4115         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4116         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4118         (WTR::InjectedBundlePage::willAddMessageToConsole):
4119         * WebKitTestRunner/TestController.cpp:
4120         (WTR::parseInputLine):
4121         (WTR::TestController::runTest):
4122         (WTR::TestCommand::TestCommand): Deleted.
4123         * WebKitTestRunner/TestInvocation.cpp:
4124         (WTR::TestInvocation::invoke):
4125         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4126         * WebKitTestRunner/TestInvocation.h:
4127         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4128
4129
4130 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4131
4132         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4133         https://bugs.webkit.org/show_bug.cgi?id=164022
4134
4135         Reviewed by Xabier Rodriguez-Calvar.
4136
4137         * Scripts/webkitperl/FeatureList.pm:
4138           Re-enable MEDIA_SOURCE for the GTK+ port.
4139
4140 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4141
4142         Fix CMake build.
4143
4144         * DumpRenderTree/PlatformMac.cmake:
4145         Define NS_RETURNS_RETAINED as nothing for now.
4146
4147 2016-12-13  Jer Noble  <jer.noble@apple.com>
4148
4149         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4150         https://bugs.webkit.org/show_bug.cgi?id=165697
4151
4152         Reviewed by Tim Horton.
4153
4154         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4155         (TestWebKitAPI::TEST):
4156
4157 2016-12-13  Andy Estes  <aestes@apple.com>
4158
4159         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4160         https://bugs.webkit.org/show_bug.cgi?id=165785
4161         <rdar://problem/26929398>
4162
4163         Reviewed by Darin Adler.
4164
4165         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4166         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4167         expectations for the text, range, and action.
4168         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4169         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4170         plain-text string to the pasteboard, executed a paste action, and verified that the selected
4171         text in the web view did not change.
4172         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
4173         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
4174         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
4175         parameter.
4176         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
4177         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
4178         and returned the value of _editingDelegateShouldInsertText.
4179         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
4180         -shouldInsertText:replacingRange:givenAction:.
4181
4182 2016-12-13  Chris Dumez  <cdumez@apple.com>
4183
4184         Unreviewed, rolling out r209544.
4185
4186         Looks like r209489 did not cause the performance regression
4187         after all
4188
4189         Reverted changeset:
4190
4191         "Unreviewed, rolling out r209489."
4192         https://bugs.webkit.org/show_bug.cgi?id=165550
4193         http://trac.webkit.org/changeset/209544
4194
4195 2016-12-12  Sam Weinig  <sam@webkit.org>
4196
4197         [WebIDL] Remove use of Dictionary in ApplePaySession
4198         https://bugs.webkit.org/show_bug.cgi?id=165787
4199
4200         Reviewed by Anders Carlsson.
4201
4202         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4203         (WTR::initializeWebViewConfiguration):
4204         (WTR::TestController::platformCreateWebView):
4205         Enable ApplePay for the tests (where supported).
4206
4207 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
4208
4209         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4210         https://bugs.webkit.org/show_bug.cgi?id=165251
4211
4212         Reviewed by Youenn Fablet.
4213
4214         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
4215         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
4216         the preferences have been set.
4217
4218 2016-12-08  Antti Koivisto  <antti@apple.com>
4219
4220         Enable network cache speculative revalidation in MiniBrowser
4221         https://bugs.webkit.org/show_bug.cgi?id=165616
4222
4223         Reviewed by Darin Adler.
4224
4225         Match Safari. Also add a menu item to disable it.
4226
4227         * MiniBrowser/mac/AppDelegate.m:
4228         (defaultConfiguration):
4229         * MiniBrowser/mac/SettingsController.h:
4230         * MiniBrowser/mac/SettingsController.m:
4231         (-[SettingsController _populateMenu]):
4232         (-[SettingsController validateMenuItem:]):
4233         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
4234         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
4235
4236 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
4237
4238         ChangeLogs become readonly after resolving a conflict
4239         https://bugs.webkit.org/show_bug.cgi?id=165440
4240         rdar://problem/29491002
4241
4242         Reviewed by Darin Adler.
4243
4244         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
4245         moving the file.
4246
4247 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
4248
4249         Re-enable collectContinuously since it doesn't crash anymore
4250
4251         Rubber stamped by Michael Saboff.
4252
4253         * Scripts/run-jsc-stress-tests:
4254
4255 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
4256
4257         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4258         https://bugs.webkit.org/show_bug.cgi?id=165686
4259
4260         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
4261         so that right config.h comes first in include path.
4262
4263 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4264
4265         [CSS Parser] Make sure content extensions initialize AtomicString
4266         https://bugs.webkit.org/show_bug.cgi?id=165737
4267
4268         Reviewed by Darin Adler.
4269
4270         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4271         (TestWebKitAPI::makeBackend):
4272
4273 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4274
4275         [CSS Parser] Remove the old CSS Parser
4276         https://bugs.webkit.org/show_bug.cgi?id=165645
4277
4278         Reviewed by Daniel Bates.
4279
4280         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4281         (TestWebKitAPI::TEST):
4282
4283 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4284
4285         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4286         https://bugs.webkit.org/show_bug.cgi?id=165686
4287
4288         Reviewed by Michael Catanzaro.
4289
4290         This change reduces duplication of include path lists between modules,
4291         and reduces future need for fixes like r209605 (broken build because of
4292         WebCore header suddenly becoming used in WebKit2).
4293
4294         * DumpRenderTree/CMakeLists.txt:
4295         * DumpRenderTree/PlatformMac.cmake:
4296         * ImageDiff/CMakeLists.txt:
4297         * MiniBrowser/gtk/CMakeLists.txt:
4298         * MiniBrowser/mac/CMakeLists.txt:
4299         * MiniBrowser/win/CMakeLists.txt:
4300         * TestWebKitAPI/CMakeLists.txt:
4301         * TestWebKitAPI/PlatformEfl.cmake:
4302         * TestWebKitAPI/PlatformJSCOnly.cmake:
4303         * TestWebKitAPI/PlatformMac.cmake:
4304         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4305         * WebKitTestRunner/CMakeLists.txt:
4306         * WebKitTestRunner/PlatformGTK.cmake:
4307         * WebKitTestRunner/PlatformMac.cmake:
4308
4309 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4310
4311         Unreviewed buildfix after r209630.
4312
4313         * Scripts/build-jsc: Remove building the non-existing testWASM.
4314
4315 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4316