Remove unused TOUCH_ICON_LOADING feature flag
[WebKit-https.git] / Tools / ChangeLog
1 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2
3         Remove unused TOUCH_ICON_LOADING feature flag
4         https://bugs.webkit.org/show_bug.cgi?id=179873
5
6         Reviewed by Simon Fraser.
7
8         * Scripts/webkitperl/FeatureList.pm:
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2017-11-19  Tim Horton  <timothy_horton@apple.com>
12
13         Remove unused LEGACY_VENDOR_PREFIXES feature flag
14         https://bugs.webkit.org/show_bug.cgi?id=179872
15
16         Reviewed by Darin Adler.
17
18         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
19
20 2017-11-19  Yusuke Suzuki  <utatane.tea@gmail.com>
21
22         Unreviewed, rolling out r225016.
23
24         Break webkit-patch on Ubuntu and Debian Linux
25
26         Reverted changeset:
27
28         "webkitpy: Better name-version mapping (Part 1)"
29         https://bugs.webkit.org/show_bug.cgi?id=179621
30         https://trac.webkit.org/changeset/225016
31
32 2017-11-18  Jonathan Bedard  <jbedard@apple.com>
33
34         webkitpy: Better name-version mapping (Part 1)
35         https://bugs.webkit.org/show_bug.cgi?id=179621
36         <rdar://problem/35589585>
37
38         Reviewed by David Kilzer.
39
40         Mapping version numbers to version names should occur in a central location.
41         This has a few advantages. First, it makes iterating through versions easier.
42         Second, it allows for apple_additions to define an additional set of name
43         mappings. Lastly, it will allow, in a future patch, for us to track version
44         instead of version name, only mapping version to version name when required.
45
46         * Scripts/webkitpy/common/system/platforminfo.py:
47         (PlatformInfo.__init__):
48         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
49         mapping version to name.
50         (PlatformInfo._determine_linux_version): Deleted.
51         (PlatformInfo._determine_mac_version): Deleted.
52         (PlatformInfo._determine_win_version): Deleted.
53         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
54         (TestPlatformInfo.test_os_name_and_wrappers):
55         (TestPlatformInfo.test_os_version):
56         (TestPlatformInfo.test_display_name):
57         (TestPlatformInfo.test_total_bytes_memory):
58         * Scripts/webkitpy/common/version.py:
59         (Version.contained_in): Add partial version mapping.
60         * Scripts/webkitpy/common/version_name_map.py: Added.
61         (VersionNameMap): Holds a mapping of version name to version object.
62         (VersionNameMap.map): Don't re-create VersionNameMap every time.
63         (VersionNameMap.__init__): Initialize mapping, use platform to
64         define the default system platform.
65         (VersionNameMap._automap_to_major_version): Some operating systems, such
66         as iOS, have a naming scheme based on their major version and os name.
67         Automatically generate such mappings.
68         (VersionNameMap.to_name): Given a version object, platform name and
69         table, find the closest matching version name.
70         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
71         if a version string is included in the name.
72         (VersionNameMap.from_name): Return an os name and version given a version name.
73         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
74         (VersionMapTestCase):
75         (VersionMapTestCase.test_default_system_platform):
76         (VersionMapTestCase.test_mac_version_by_name):
77         (VersionMapTestCase.test_ios_version_by_name):
78         (VersionMapTestCase.test_mac_name_by_version):
79         (VersionMapTestCase.test_ios_name_by_version):
80         * Scripts/webkitpy/common/version_unittest.py:
81         (VersionTestCase.test_contained_in):
82
83 2017-11-17  John Wilander  <wilander@apple.com>
84
85         Storage Access API: UI process should update network process about granted access
86         https://bugs.webkit.org/show_bug.cgi?id=176943
87         <rdar://problem/34440612>
88
89         Reviewed by Alex Christensen.
90
91         This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
92         which enables testing of prevalent resources with user interaction outside the
93         24 hour window.
94
95         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
96         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
97         (WTR::TestRunner::setStorageAccessAPIEnabled):
98         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
99         * WebKitTestRunner/InjectedBundle/TestRunner.h:
100         * WebKitTestRunner/TestController.cpp:
101         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
102         * WebKitTestRunner/TestController.h:
103         * WebKitTestRunner/TestInvocation.cpp:
104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
105         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
106         (WTR::initializeWebViewConfiguration):
107         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
108
109 2017-11-17  Ryan Haddad  <ryanhaddad@apple.com>
110
111         Disable failing API tests for rdar://problem/35344202.
112
113         Unreviewed test gardening.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
116
117 2017-11-17  Joanmarie Diggs  <jdiggs@igalia.com>
118
119         AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
120         https://bugs.webkit.org/show_bug.cgi?id=179837
121
122         Reviewed by Chris Fleizach.
123
124         Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
125         and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
126         to getTableRowHeaders() and getTableColumnHeaders() respectively.
127
128         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
129         (WTR::AccessibilityUIElement::rowHeaders const):
130         (WTR::AccessibilityUIElement::columnHeaders const):
131         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
132         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
133
134 2017-11-16  Don Olmstead  <don.olmstead@sony.com>
135
136         [WinCairo] Update WinCairoRequirements
137         https://bugs.webkit.org/show_bug.cgi?id=179790
138
139         Reviewed by Alex Christensen.
140
141         * TestWebKitAPI/PlatformWin.cmake:
142
143 2017-11-16  Daniel Bates  <dabates@apple.com>
144
145         Add feature define for alternative presentation button element
146         https://bugs.webkit.org/show_bug.cgi?id=179692
147         Part of <rdar://problem/34917108>
148
149         Reviewed by Andy Estes.
150
151         Only enabled on Cocoa platforms by default.
152
153         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
154
155 2017-11-16  Per Arne Vollan  <pvollan@apple.com>
156
157         Win EWS bots should reboot after N webkit-patch iterations.
158         https://bugs.webkit.org/show_bug.cgi?id=177970
159
160         Reviewed by Brent Fulgham.
161
162         * EWSTools/start-queue-win.sh:
163
164 2017-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
165
166         [WPE] Add initial support for WebDriver
167         https://bugs.webkit.org/show_bug.cgi?id=179727
168
169         Reviewed by Michael Catanzaro.
170
171         Make it possible to run WebDriver tests with WPE.
172
173         * Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
174         * Scripts/webkitpy/port/wpe.py:
175         (WPEPort.__init__): Initialize _display_server from options.
176         (WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.
177         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
178         (WebDriver.browser_env): Add virtual method to get the environment that should be used.
179         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.
180         (WebDriverWPE):
181         (WebDriverWPE.__init__):
182         (WebDriverWPE.binary_path):
183         (WebDriverWPE.browser_name):
184         (WebDriverWPE.capabilities):
185         (WebDriverWPE.browser_env):
186         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
187         (WebDriverW3CExecutor.__init__): Update the environment with the one provided by the driver.
188         * wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.
189
190 2017-11-15  Alex Christensen  <achristensen@webkit.org>
191
192         WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
193         https://bugs.webkit.org/show_bug.cgi?id=179742
194         <rdar://problem/35519421>
195
196         Reviewed by Jer Noble.
197
198         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
199         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
200         (TestWebKitAPI::TEST):
201         Load more than one scheduled WebView to test work that typically takes more than 50 ms.
202
203 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
204
205         Unreviewed, rolling out r223781.
206
207         The test is now returning false, so the FIXME is not needed
208         anymore.
209
210         Reverted changeset:
211
212         "WebsiteDataStoreCustomPaths.mm is failing after r223718"
213         https://bugs.webkit.org/show_bug.cgi?id=178596
214         https://trac.webkit.org/changeset/223781
215
216 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
217
218         Unreviewed, rolling out r224863.
219
220         Introduced LayoutTest crashes on iOS Simulator.
221
222         Reverted changeset:
223
224         "Move JSONValues to WTF and convert uses of InspectorValues.h
225         to JSONValues.h"
226         https://bugs.webkit.org/show_bug.cgi?id=173793
227         https://trac.webkit.org/changeset/224863
228
229 2017-11-15  Michael Catanzaro  <mcatanzaro@igalia.com>
230
231         Remove GTK web inspector images
232         https://bugs.webkit.org/show_bug.cgi?id=179716
233
234         Reviewed by Carlos Garcia Campos.
235
236         * Scripts/webkitdirs.pm:
237         (shouldRemoveCMakeCache):
238         * glib/generate-inspector-gresource-manifest.py:
239         (get_filenames.should_ignore_resource):
240         * gtk/manifest.txt.in:
241         * wpe/manifest.txt.in:
242
243 2017-11-15  Jonathan Bedard  <jbedard@apple.com>
244
245         REGRESSION(r221877): 'future' handled incorrectly for mac
246         https://bugs.webkit.org/show_bug.cgi?id=179711
247         <rdar://problem/35546604>
248
249         Reviewed by Alex Christensen.
250
251         * Scripts/webkitpy/port/mac.py:
252         (MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
253         platform/<version> as the baseline search path.
254
255 2017-11-14  Nan Wang  <n_wang@apple.com>
256
257         AX: AOM: Implement AccessibleNode class and support label and role attributes
258         https://bugs.webkit.org/show_bug.cgi?id=179494
259
260         Reviewed by Ryosuke Niwa.
261
262         * DumpRenderTree/mac/DumpRenderTree.mm:
263         (enableExperimentalFeatures):
264         * WebKitTestRunner/TestController.cpp:
265         (WTR::TestController::resetPreferencesToConsistentValues):
266
267 2017-11-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
268
269         [Windows] Fix error while launching subprocess on Windows Python
270         https://bugs.webkit.org/show_bug.cgi?id=179637
271
272         Reviewed by Alex Christensen.
273
274         To pass environment variables to subprocess.popen on Windows Python 2,
275         the dict values must be str not unicode.
276         Also is_native_win() method is added to port.
277
278         * Scripts/webkitpy/common/system/platforminfo.py:
279         (PlatformInfo.is_native_win):
280         * Scripts/webkitpy/common/system/platforminfo_mock.py:
281         (MockPlatformInfo.is_native_win):
282         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
283         (TestPlatformInfo.test_os_name_and_wrappers):
284         * Scripts/webkitpy/port/server_process.py:
285         (ServerProcess.__init__):
286
287 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
288
289         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
290         https://bugs.webkit.org/show_bug.cgi?id=173793
291
292         Reviewed by Brian Burg.
293
294         * TestWebKitAPI/CMakeLists.txt:
295         * TestWebKitAPI/PlatformGTK.cmake:
296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
297         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
298         (TestWebKitAPI::TEST):
299
300 2017-11-14  Jonathan Bedard  <jbedard@apple.com>
301
302         webkitpy: Use more verbose version info from simctl
303         https://bugs.webkit.org/show_bug.cgi?id=179687
304         <rdar://problem/35539392>
305
306         Reviewed by Tim Horton.
307
308         * Scripts/webkitpy/xcode/simulator.py:
309         (Simulator): Address FIXME, use more verbose version.
310         (Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
311         string instead.
312         * Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
313         8.4.1, not iOS 8.4.
314
315 2017-11-14  Daniel Bates  <dabates@apple.com>
316
317         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
318         for feature defines
319
320         Following r195498 and r201917 the Visual Studio property files for feature defines have
321         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
322         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
323         files.
324
325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
326
327 2017-11-14  Jer Noble  <jer.noble@apple.com>
328
329         Enable Modern EME tests in DumpRenderTree
330         https://bugs.webkit.org/show_bug.cgi?id=179544
331
332         Reviewed by Alex Christensen.
333
334         * DumpRenderTree/mac/DumpRenderTree.mm:
335         (enableExperimentalFeatures):
336
337 2017-11-14  Commit Queue  <commit-queue@webkit.org>
338
339         Unreviewed, rolling out r224800.
340         https://bugs.webkit.org/show_bug.cgi?id=179684
341
342         "Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
343         (Requested by mlam on #webkit).
344
345         Reverted changeset:
346
347         "Pass --useDollarVM=true to all JSC tests."
348         https://bugs.webkit.org/show_bug.cgi?id=179647
349         https://trac.webkit.org/changeset/224800
350
351 2017-11-14  Antti Koivisto  <antti@apple.com>
352
353         Enable display:contents by default
354         https://bugs.webkit.org/show_bug.cgi?id=179655
355
356         Reviewed by Sam Weinig.
357
358         No need to enable this specifically for tests anymore.
359
360         * DumpRenderTree/mac/DumpRenderTree.mm:
361         (enableExperimentalFeatures):
362         * WebKitTestRunner/TestController.cpp:
363         (WTR::TestController::resetPreferencesToConsistentValues):
364
365 2017-11-14  Tim Horton  <timothy_horton@apple.com>
366
367         Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
368         https://bugs.webkit.org/show_bug.cgi?id=179646
369         <rdar://problem/35337288>
370
371         Reviewed by Simon Fraser.
372
373         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
374         (-[ActionSheetObserver _dataDetectionContextForWebView:]):
375         (TestWebKitAPI::TEST):
376         Add a test that ensures that a phone number with spaces in it
377         invokes a data detectors sheet, not a normal link sheet.
378
379 2017-11-14  Emilio Cobos Álvarez  <emilio@crisal.io>
380
381         Add committer status for Emilio Cobos Álvarez.
382         https://bugs.webkit.org/show_bug.cgi?id=179667
383
384         Unreviewed.
385
386         * Scripts/webkitpy/common/config/contributors.json:
387
388 2017-11-13  Mark Lam  <mark.lam@apple.com>
389
390         Pass --useDollarVM=true to all JSC tests.
391         https://bugs.webkit.org/show_bug.cgi?id=179647
392
393         Reviewed by Saam Barati.
394
395         * Scripts/run-jsc-stress-tests:
396
397 2017-11-13  Simon Fraser  <simon.fraser@apple.com>
398
399         When navigating back to a page, compositing layers may not use accelerated drawing
400         https://bugs.webkit.org/show_bug.cgi?id=178749
401         rdar://problem/35158946
402
403         Reviewed by Dean Jackson.
404
405         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
406         and use it to set the state of the web view.
407
408         * DumpRenderTree/TestOptions.h:
409         * DumpRenderTree/TestOptions.mm:
410         (TestOptions::TestOptions):
411         * DumpRenderTree/mac/DumpRenderTree.mm:
412         (setWebPreferencesForTestOptions):
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::TestController::resetPreferencesToConsistentValues):
415         (WTR::updateTestOptionsFromTestHeader):
416         * WebKitTestRunner/TestOptions.h:
417         (WTR::TestOptions::hasSameInitializationOptions const):
418
419 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
420
421         [Windows] Fix Python error for subprocess.popen with close_fds
422         https://bugs.webkit.org/show_bug.cgi?id=179553
423
424         Reviewed by Per Arne Vollan.
425
426         * Scripts/webkitpy/port/server_process.py:
427         (ServerProcess._start):
428         (ServerProcess._should_close_fds):
429
430 2017-11-13  Michael Catanzaro  <mcatanzaro@igalia.com>
431
432         [GTK] Require woff2 1.0.2 and drop direct brotli dependency
433         https://bugs.webkit.org/show_bug.cgi?id=179630
434
435         Reviewed by Frédéric Wang.
436
437         * gtk/jhbuild.modules:
438
439 2017-11-08  Keith Miller  <keith_miller@apple.com>
440
441         Async iteration should only fetch the next method once and add feature flag
442         https://bugs.webkit.org/show_bug.cgi?id=179451
443
444         Reviewed by Geoffrey Garen.
445
446         Add feature flag for Async iteration.
447
448         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
449
450 2017-11-13  Gabriel Ivascu  <givascu@igalia.com>
451
452         [GTK] Automatically adjust font size when gtk-xft-dpi changes
453         https://bugs.webkit.org/show_bug.cgi?id=142673
454
455         Reviewed by Michael Catanzaro.
456
457         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
458         (testWebKitSettings):
459
460 2017-11-13  Jonathan Bedard  <jbedard@apple.com>
461
462         check-webkit-style cannot construct valid iOS version without an iOS SDK
463         https://bugs.webkit.org/show_bug.cgi?id=179616
464         <rdar://problem/35507018>
465
466         Reviewed by David Kilzer.
467
468         Instead of throwing an exception when we ask for an unavailable SDK on Mac,
469         we should return None.
470
471         * Scripts/webkitpy/common/system/platforminfo.py:
472         (PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
473         have the requested SDK.
474
475 2017-11-13  Keith Miller  <keith_miller@apple.com>
476
477         Uninitialized variable in sort-Xcode-project-file
478         https://bugs.webkit.org/show_bug.cgi?id=179581
479
480         Reviewed by Simon Fraser.
481
482         Previously all the unified source files were named
483         UnifiedSource<some-number>.mm. This was changed to
484         UnifiedSource<some-number>-mm.mm to stop Xcode from creating
485         hashes for mm and cpp unified source files with the same
486         number. This broke the expectations in sort-Xcode-project-file.
487
488         * Scripts/sort-Xcode-project-file:
489         (sortChildrenByFileName):
490         (sortFilesByFileName):
491
492 2017-11-13  JF Bastien  <jfbastien@apple.com>
493
494         std::expected: fix and test move
495         https://bugs.webkit.org/show_bug.cgi?id=179617
496
497         Reviewed by Alex Christensen.
498
499         Test that unique_ptr can be moved around properly, both has a
500         value and an error (and in a <void, unique> specialization).
501
502         * TestWebKitAPI/Tests/WTF/Expected.cpp:
503         (TestWebKitAPI::snowflake::reset):
504         (TestWebKitAPI::snowflake::snowflake):
505         (TestWebKitAPI::snowflake::~snowflake):
506         (TestWebKitAPI::TEST):
507
508 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
509
510         [Windows] Make the port's normalize_test_name() method platform independent.
511         https://bugs.webkit.org/show_bug.cgi?id=179572
512
513         Reviewed by Alexey Proskuryakov.
514
515         * Scripts/webkitpy/port/base.py:
516         (Port.normalize_test_name):
517
518 2017-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
519
520         [Attachment Support] Implement SPI for clients to request data for a given attachment
521         https://bugs.webkit.org/show_bug.cgi?id=179586
522         <rdar://problem/35355720>
523
524         Reviewed by Darin Adler.
525
526         Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
527         result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
528         inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
529         the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
530         yields an empty NSData result.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
533         (-[NSData shortDescription]):
534         (-[_WKAttachment synchronouslyRequestData:]):
535         (-[_WKAttachment expectRequestedDataToBe:]):
536         (TestWebKitAPI::TEST):
537
538 2017-11-12  Gabriel Ivascu  <givascu@igalia.com>
539
540         [GTK] Add functionality to handle font sizes in points
541         https://bugs.webkit.org/show_bug.cgi?id=179285
542
543         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
544
545         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
546         (testWebKitSettings):
547
548 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
549
550         check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
551         https://bugs.webkit.org/show_bug.cgi?id=179522
552
553         Reviewed by Aakash Jain.
554
555         IOSSimulatorPort.ios_version should return a Version object.
556
557         * Scripts/webkitpy/port/ios_simulator.py:
558         (IOSSimulatorPort.ios_version): Return a Version object.
559
560 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
561
562         [Win] The way to detect Windows 10 is wrong
563         https://bugs.webkit.org/show_bug.cgi?id=179344
564
565         Reviewed by Alex Christensen.
566
567         * Scripts/webkitpy/common/system/platforminfo.py:
568         (PlatformInfo._determine_win_version):
569
570 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
571
572         [WinCairo] LayoutTests doesn't read TextExpectations files correctly
573         https://bugs.webkit.org/show_bug.cgi?id=179219
574
575         Reviewed by Alex Christensen.
576
577         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
578         (TestExpectationParser._parse_line):
579         * Scripts/webkitpy/port/apple.py:
580         (ApplePort.__init__):
581         (ApplePort._allowed_port_names):
582         (ApplePort):
583         (ApplePort._future_port_name):
584         (ApplePort._generate_all_test_configurations):
585         * Scripts/webkitpy/port/win.py:
586         (WinCairoPort.default_baseline_search_path):
587         (WinCairoPort):
588         (WinCairoPort._future_port_name):
589
590 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
591
592         [WinCairo] Treat 'future' version correctly
593         https://bugs.webkit.org/show_bug.cgi?id=179345
594
595         Reviewed by Alex Christensen.
596
597         * Scripts/webkitpy/port/win.py:
598         (WinCairoPort.default_baseline_search_path):
599
600 2017-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
601
602         Finish rolling out r224544
603
604         Rubber-stamped by Tim Horton.
605
606         Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
607         tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
608         style with a selected attachment element.
609
610         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
611         (TestWebKitAPI::TEST):
612
613 2017-11-10  Alex Christensen  <achristensen@webkit.org>
614
615         _WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
616         https://bugs.webkit.org/show_bug.cgi?id=179537
617         <rdar://problem/35275219>
618
619         Reviewed by Darin Adler.
620
621         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
622         (-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
623         (TestWebKitAPI::TEST):
624
625 2017-11-10  Jonathan Bedard  <jbedard@apple.com>
626
627         webkitpy: Remove find_system_pid from port classes
628         https://bugs.webkit.org/show_bug.cgi?id=179514
629         <rdar://problem/35456900>
630
631         Reviewed by David Kilzer.
632
633         Removing dead code.
634
635         * Scripts/webkitpy/port/base.py:
636         (Port.find_system_pid): Deleted.
637         * Scripts/webkitpy/port/server_process.py:
638         (ServerProcess._start):
639         * Scripts/webkitpy/port/win.py:
640         (WinPort.find_system_pid): Deleted.
641
642 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
643
644         fix style failures in webkitpy: multiple statements on one line (semicolon)
645         https://bugs.webkit.org/show_bug.cgi?id=179530
646
647         Reviewed by Alex Christensen.
648
649         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
650         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
651         * Scripts/webkitpy/tool/steps/runtests.py: Ditto.
652
653 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
654
655         fix style failures in webkitpy: expected 2 blank lines found 1
656         https://bugs.webkit.org/show_bug.cgi?id=179529
657
658         Reviewed by Alex Christensen.
659
660         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
661         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
662         * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
663         * Scripts/webkitpy/common/version.py: Ditto.
664         * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
665         * Scripts/webkitpy/port/mac_unittest.py: Ditto.
666         * Scripts/webkitpy/port/simulator_process.py: Ditto.
667
668 2017-11-10  Alex Christensen  <achristensen@webkit.org>
669
670         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
671         https://bugs.webkit.org/show_bug.cgi?id=179515
672
673         Reviewed by Andy Estes.
674
675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
676         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.
677         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
678         (TestWebKitAPI::TEST):
679
680 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
681
682         [webkitpy] Fix PlatformInfo._win_version since r224657
683         https://bugs.webkit.org/show_bug.cgi?id=179520
684
685         Reviewed by Aakash Jain.
686
687         There are two problems.
688
689         The return value of sys.getwindowsversion() doesn't match with
690         Version.__init__ expects. Truncate the 4th and 5th of it.
691
692         _win_version_tuple_from_cmd was deleted in r224657. But, it is
693         still needed for Cygwin Python.
694
695         * Scripts/webkitpy/common/system/platforminfo.py:
696         (PlatformInfo._win_version): Return [0:3] of getwindowsversion().
697         Call _win_version_from_cmd for Cygwin Python.
698         (PlatformInfo._win_version_from_cmd): Restored.
699
700 2017-11-10  Guillaume Emont  <guijemont@igalia.com>
701
702         build-jsc: build testmasm for all platforms using cmake
703         https://bugs.webkit.org/show_bug.cgi?id=179512
704
705         Reviewed by Michael Catanzaro.
706
707         * Scripts/build-jsc:
708
709 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
710
711         webkitpy: Unify version parsing code
712         https://bugs.webkit.org/show_bug.cgi?id=179426
713         <rdar://problem/35415191>
714
715         Unreviewed fix to r224657.
716
717         * Scripts/webkitpy/common/version.py:
718         (Version.__init__): Check if an object is iterable.
719
720 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
721
722         webkitpy: Unify version parsing code
723         https://bugs.webkit.org/show_bug.cgi?id=179426
724         <rdar://problem/35415191>
725
726         Reviewed by David Kilzer.
727
728         webkitpy needs to parse version strings or version lists frequently. Rather than
729         duplicate this code each time it's needed, unify it in a Version class.
730
731         * Scripts/webkitpy/common/system/platforminfo.py:
732         (PlatformInfo.__init__): Convert mac version string to version object and
733         use _win_version instead of _win_version_tuple.
734         (PlatformInfo.xcode_sdk_version): Convert SDK version string to Version object
735         before returning it.
736         (PlatformInfo.xcode_version): Return Version object instead of version string.
737         (PlatformInfo._determine_mac_version): Accept Version object instead of string,
738         eliminate parsing.
739         (PlatformInfo._determine_win_version): Accept Version object instead of tuple.
740         (PlatformInfo._win_version): Return Version object instead of tuple, have Version
741         object own version string parsing.
742         (PlatformInfo._win_version_tuple): Renamed to _win_version().
743         (PlatformInfo._win_version_tuple_from_cmd): Deleted.
744         * Scripts/webkitpy/common/system/platforminfo_mock.py:
745         (MockPlatformInfo.xcode_sdk_version): Return Version object instead of string.
746         (MockPlatformInfo.xcode_version): Dittio.
747         * Scripts/webkitpy/common/version.py: Added.
748         (Version): Version object.
749         (Version.__init__): Initialize the Version object with a string, integer,
750         tuple of integers, list of integers or another Version object.
751         (Version.__len__): Return 5 so that the Version object can be treated as
752         a list or tuple.
753         (Version.__getitem__): Get item in Version object by index or string.
754         (Version.__setitem__): Set item in Version object by index or string.
755         (Version.__str__): Convert version to printable string, omitting trailing 0's.
756         (Version.__cmp__): Compare two version strings, major taking precedence over
757         minor, minor taking precedence over build.
758         * Scripts/webkitpy/common/version_unittest.py: Added.
759         (VersionTestCase): Test behavior of Version object.
760         * Scripts/webkitpy/port/ios.py:
761         (IOSPort.default_baseline_search_path): ios_version now returns a Version object.
762         (IOSPort._is_valid_ios_version): Deleted.
763         (IOSPort.get_option): Deleted.
764         * Scripts/webkitpy/port/ios_device.py:
765         (IOSDevicePort.determine_full_port_name): Use Version object instead of owning parsing.
766         (IOSDevicePort.ios_version): Return Version object instead of string.
767         * Scripts/webkitpy/port/ios_simulator.py:
768         (IOSSimulatorPort.simulator_runtime): Use from_version instead of from_version_string.
769         (IOSSimulatorPort.ios_version): Return Version object instead of string.
770         (IOSSimulatorPort.use_multiple_simulator_apps): Use Version object instead of string.
771         * Scripts/webkitpy/xcode/simulator.py:
772         (Runtime.from_version): Accept Version object instead of string.
773         (Runtime.from_version_string): Replaced by from_version.
774         (Runtime.__repr__): When printing, a runtime's version will be a Version object instead
775         of a tuple.
776         (Simulator._parse_runtimes): Use Version object instead of tuple.
777         (Simulator._parse_devices): Ditto.
778         * Scripts/webkitpy/xcode/simulator_unittest.py: Use Version object instead of tuples.
779
780 2017-11-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
781
782         [WinCairo] Cannot find ImageDiff executable
783         https://bugs.webkit.org/show_bug.cgi?id=179508
784
785         Reviewed by Per Arne Vollan.
786
787         * Scripts/webkitpy/port/win.py:
788         (WinPort.is_cygwin):
789         (WinPort._path_to_image_diff):
790         (WinPort.find_system_pid):
791
792 2017-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
793
794         [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command
795         https://bugs.webkit.org/show_bug.cgi?id=179469
796
797         Reviewed by Per Arne Vollan.
798
799         WinCairo EWS bots haven't installed Cygwin.
800
801         * Scripts/svn-apply:
802         (scmCopy): Use 'copy' function instead of 'cp' command.
803
804 2017-11-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
805
806         [WPE] Update dyz (WPE MiniBrowser)
807         https://bugs.webkit.org/show_bug.cgi?id=179492
808
809         Reviewed by Michael Catanzaro.
810
811         Update it to the last version as of today.
812         This version not longer uses the C API.
813
814         * wpe/jhbuild.modules:
815
816 2017-11-09  Christopher Reid  <chris.reid@sony.com>
817
818         Use enum classes within FileSystem
819         https://bugs.webkit.org/show_bug.cgi?id=175172
820
821         Reviewed by Darin Adler.
822
823         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
824         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
825
826 2017-11-09  Brent Fulgham  <bfulgham@apple.com>
827
828         Test fix after r224609
829         https://bugs.webkit.org/show_bug.cgi?id=178565
830         <rdar://problem/11115901>
831
832         Unreviewed test fix after r224609.
833
834         Correct two test cases that attempt to push local file URLs in violation of our
835         same origin policies. The fix is to grant universal file access, as we do for similar
836         LayoutTests.
837
838         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
841         (TestWebKitAPI::TEST):
842
843 2017-11-09  Michael Catanzaro  <mcatanzaro@igalia.com>
844
845         Unreviewed, remove Dan from the soup network watchlist
846
847         Per his request. It's not Hotel California; we should probably let him leave.
848
849         * Scripts/webkitpy/common/config/watchlist:
850
851 2017-11-08  Don Olmstead  <don.olmstead@sony.com>
852
853         Add Windows powershell EWS script
854         https://bugs.webkit.org/show_bug.cgi?id=179453
855
856         Reviewed by Brent Fulgham.
857
858         * EWSTools/Start-Queue.ps1: Added.
859
860 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
861
862         HTMLMediaElement should not use element fullscreen on iOS
863         https://bugs.webkit.org/show_bug.cgi?id=179418
864         rdar://problem/35409277
865
866         Reviewed by Eric Carlson.
867
868         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
869
870         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
871
872 2017-11-08  Tim Horton  <timothy_horton@apple.com>
873
874         [ios-simulator] API test WebKit.BundleParameters is a flaky failure
875         https://bugs.webkit.org/show_bug.cgi?id=178363
876         <rdar://problem/35043144>
877
878         Reviewed by Brent Fulgham.
879
880         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
881         (TestWebKitAPI::TEST):
882         Add a test.
883
884 2017-11-08  Wenson Hsieh  <wenson_hsieh@apple.com>
885
886         [Attachment Support] Implement delegate hooks for attachment element insertion and removal
887         https://bugs.webkit.org/show_bug.cgi?id=179016
888         <rdar://problem/35250890>
889
890         Reviewed by Tim Horton.
891
892         See WebCore/ChangeLog for more details.
893
894         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
895         (-[AttachmentUpdateObserver init]):
896         (-[AttachmentUpdateObserver inserted]):
897         (-[AttachmentUpdateObserver removed]):
898         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]):
899         (-[AttachmentUpdateObserver _webView:didRemoveAttachment:]):
900         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
901         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::~ObserveAttachmentUpdatesForScope):
902         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::observer const):
903         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
904         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]):
905         (-[TestWKWebView expectUpdatesAfterCommand:withArgument:expectedRemovals:expectedInsertions:]):
906         (TestWebKitAPI::TEST):
907
908 2017-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
909
910         Web Inspector: use JSON::{Array,Object,Value} instead of Inspector{Array,Object,Value}
911         https://bugs.webkit.org/show_bug.cgi?id=173619
912
913         Reviewed by Brian Burg.
914
915         Update InspectorValue unit tests to use JSON namespace and add more basic tests to cover all the API.
916
917         * TestWebKitAPI/PlatformGTK.cmake:
918         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp:
919         (TestWebKitAPI::TEST):
920
921 2017-11-07  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         REGRESSION(r224179): [GTK] Several WebViewEditor tests are failing since r224179
924         https://bugs.webkit.org/show_bug.cgi?id=179366
925
926         Reviewed by Michael Catanzaro.
927
928         Use always a toplevel window for WebViewEditor tests instead of creating and destroying one only to flush editor
929         state.
930
931         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
932
933 2017-11-07  Carlos Garcia Campos  <cgarcia@igalia.com>
934
935         [GTK][WPE] Build inspector resources using copy-user-interface-resources.pl script
936         https://bugs.webkit.org/show_bug.cgi?id=179317
937
938         Reviewed by Michael Catanzaro.
939
940         Move generate-inspector-gresource-manifest.py to glib dir to be shared by GTK+ and WPE ports and update it to
941         receive an input directory instead of a list of patterns.
942         File::Copy::Recursive is required by copy-user-interface-resources.pl, so make sure it's installed.
943
944         * glib/generate-inspector-gresource-manifest.py: Renamed from Tools/gtk/generate-inspector-gresource-manifest.py.
945         (get_filenames):
946         (get_filenames.should_ignore_resource):
947         * gtk/install-dependencies:
948         * wpe/generate-inspector-gresource-manifest.py: Removed.
949         * wpe/install-dependencies:
950
951 2017-11-07  Don Olmstead  <don.olmstead@sony.com>
952
953         Fix webkitpy tests after rev 224549.
954
955         Unreviewed build fix.
956
957         * Scripts/webkitpy/common/config/ports.py:
958         (WinCairoPort.run_webkit_tests_command):
959         * Scripts/webkitpy/common/config/ports_unittest.py:
960         (DeprecatedPortTest.test_wincairo_port):
961
962 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
963
964         Enable webkitpy EWS bubbles
965         https://bugs.webkit.org/show_bug.cgi?id=178539
966
967         Reviewed by Alexey Proskuryakov.
968
969         * QueueStatusServer/config/queues.py: Added webkitpy EWS.
970
971 2017-11-07  Don Olmstead  <don.olmstead@sony.com>
972
973         Add a WinCairo EWS queue
974         https://bugs.webkit.org/show_bug.cgi?id=179390
975
976         Reviewed by Lucas Forschler.
977
978         * QueueStatusServer/config/queues.py:
979         * QueueStatusServer/model/queues.py:
980         * Scripts/webkitpy/common/config/ews.json:
981         * Scripts/webkitpy/common/config/ports.py:
982         * Scripts/webkitpy/common/config/ports_unittest.py:
983         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
984
985 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
986
987         fix check-webkit-style errors in webkitpy about not having two spaces before inline comment
988         https://bugs.webkit.org/show_bug.cgi?id=171506
989
990         Reviewed by Alexey Proskuryakov.
991
992         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
993         (SCMTest._shared_test_reverse_diff): Added two spaces before inline comment.
994         (test_create_patch_is_full_patch): Ditto.
995         * Scripts/webkitpy/common/thread/messagepump.py:
996         (MessagePump): Ditto.
997         * Scripts/webkitpy/layout_tests/servers/http_server.py:
998         (Lighttpd._prepare_config): Ditto.
999         * Scripts/webkitpy/style/checker.py: Ditto.
1000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1001         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Ditto.
1002
1003 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
1004
1005         Add support for webkitpy tests EWS
1006         https://bugs.webkit.org/show_bug.cgi?id=178480
1007
1008         Reviewed by Alexey Proskuryakov.
1009
1010         * Scripts/webkitpy/common/config/ews.json: Added webkitpy EWS.
1011         * Scripts/webkitpy/common/net/generictestresults.py: Renamed from Scripts/webkitpy/common/net/bindingstestresults.py.
1012         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Renamed from Scripts/webkitpy/common/net/bindingstestresults_unittest.py.
1013         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1014         (PatchAnalysisTask._test_patch): Do not retry webkitpy test since they are not flaky.
1015         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Updated import for BindingsTestResult.
1016         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py: Ditto.
1017         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Copied from Scripts/webkitpy/tool/bot/bindingstestresultsreader.py.
1018         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1019         (AbstractEarlyWarningSystem.begin_work_queue): Added webkitpy test result reader.
1020         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Updated unit-tests.
1021         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Run webkitpy EWS only for relevant changes.
1022         * Scripts/webkitpy/tool/steps/runtests.py:
1023         (RunTests.run): Run webkitpy tests when --group=webkitpy is passed.
1024         (RunTests._run_webkitpy_tests): Method to invoke webkitpy tests.
1025         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1026         (test_runtests_webkitpy): Added unit-test.
1027
1028 2017-11-07  Commit Queue  <commit-queue@webkit.org>
1029
1030         Unreviewed, rolling out r224512 and r224521.
1031         https://bugs.webkit.org/show_bug.cgi?id=179388
1032
1033         An API test added with this change is failing an assertion on
1034         the bots. (Requested by ryanhaddad on #webkit).
1035
1036         Reverted changesets:
1037
1038         "[Attachment Support] Implement delegate hooks for attachment
1039         element insertion and removal"
1040         https://bugs.webkit.org/show_bug.cgi?id=179016
1041         https://trac.webkit.org/changeset/224512
1042
1043         "Remove stray logging from a newly added API test"
1044         https://trac.webkit.org/changeset/224521
1045
1046 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1047
1048         Remove stray logging from a newly added API test
1049
1050         This was only for debugging purposes, and should have been removed before landing.
1051
1052         Rubber-stamped by Tim Horton.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1055         (TestWebKitAPI::TEST):
1056
1057 2017-11-06  Jonathan Bedard  <jbedard@apple.com>
1058
1059         Only build ImageDiff for mac
1060         https://bugs.webkit.org/show_bug.cgi?id=179349
1061         <rdar://problem/35376237>
1062
1063         Reviewed by Tim Horton.
1064
1065         * ImageDiff/Makefile:
1066
1067 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1068
1069         Unreviewed, fix the internal build after updating to a newer SDK
1070
1071         There shouldn't be any need to include and implement these method stubs anymore,
1072         even when building against the shipping iOS 11 SDK.
1073
1074         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1075         (-[MockDropSession session]): Deleted.
1076
1077 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         [Attachment Support] Implement delegate hooks for attachment element insertion and removal
1080         https://bugs.webkit.org/show_bug.cgi?id=179016
1081         <rdar://problem/35250890>
1082
1083         Reviewed by Tim Horton.
1084
1085         Introduces new API tests to check that various editing operations will or won't result in the new attachment
1086         insertion and removal delegate hooks being fired. Additionally refactors an existing test to verify that
1087         attachments insertion and removal is observable by the UI delegate.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1090         (-[AttachmentUpdateObserver init]):
1091         (-[AttachmentUpdateObserver inserted]):
1092         (-[AttachmentUpdateObserver removed]):
1093         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]):
1094         (-[AttachmentUpdateObserver _webView:didRemoveAttachment:]):
1095         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
1096         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::~ObserveAttachmentUpdatesForScope):
1097         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
1098
1099         Implement a testing mechanism to temporarily bind a UI delegate to a given WKWebView and listen for inserted or
1100         removed attachments over the course of a particular scope. The API tests use this mechanism to check that the UI
1101         delegate hooks added in this patch are invoked with the right attachments when performing edit commands.
1102
1103         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]):
1104         (-[TestWKWebView expectUpdatesAfterCommand:withArgument:expectedRemovals:expectedInsertions:]):
1105         (TestWebKitAPI::TEST):
1106
1107 2017-11-06  Christopher Reid  <chris.reid@sony.com>
1108
1109         Use enum classes within FileSystem
1110         https://bugs.webkit.org/show_bug.cgi?id=175172
1111
1112         Reviewed by Myles C. Maxfield.
1113
1114         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1115         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1116
1117 2017-11-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1118
1119         [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp
1120         https://bugs.webkit.org/show_bug.cgi?id=179039
1121
1122         Reviewed by Žan Doberšek.
1123
1124         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1125         (WTR::EventSenderProxy::updateTouchPoint):
1126         (WTR::EventSenderProxy::releaseTouchPoint):
1127
1128 2017-11-06  Robin Morisset  <rmorisset@apple.com>
1129
1130         Add a third benchmark to TailBench
1131         https://bugs.webkit.org/show_bug.cgi?id=178815
1132
1133         Reviewed by Saam Barati.
1134
1135         Add a new benchmark to TailBench: a BF interpreter written in a weird kinda functional style
1136
1137         * Scripts/run-jsc-benchmarks:
1138
1139 2017-11-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1140
1141         [GTK] Fix gtk-doc generation with gtk-doc master
1142         https://bugs.webkit.org/show_bug.cgi?id=179252
1143
1144         Reviewed by Carlos Garcia Campos.
1145
1146         gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
1147         particular, this means we can no longer rely on shell stuff in our run command that we use
1148         to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
1149         result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
1150         scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
1151         make documentation generation work again.
1152
1153         * gtk/gtkdoc.py:
1154         (GTKDoc._run_gtkdoc_scangobj):
1155
1156 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1157
1158         [Touch Bar Web API] Add support for menuitem tag
1159         https://bugs.webkit.org/show_bug.cgi?id=179020
1160
1161         Reviewed by Ryosuke Niwa.
1162
1163         Defines flags for the menu item test so that the element is recognized
1164         only while its test is being run.
1165
1166         * DumpRenderTree/TestOptions.h:
1167         * DumpRenderTree/TestOptions.mm:
1168         (TestOptions::TestOptions):
1169         * DumpRenderTree/mac/DumpRenderTree.mm:
1170         (setWebPreferencesForTestOptions):
1171         * WebKitTestRunner/TestController.cpp:
1172         (WTR::TestController::resetPreferencesToConsistentValues):
1173         (WTR::updateTestOptionsFromTestHeader):
1174         * WebKitTestRunner/TestOptions.h:
1175         (WTR::TestOptions::hasSameInitializationOptions const):
1176
1177 2017-11-03  Andy Estes  <aestes@apple.com>
1178
1179         [iOS] Append the platform name to the product directory on all embedded platforms
1180         https://bugs.webkit.org/show_bug.cgi?id=179271
1181
1182         Reviewed by Joseph Pecoraro.
1183
1184         * Scripts/webkitdirs.pm:
1185         (determineConfigurationProductDir):
1186
1187 2017-11-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1188
1189         [WinCairo] Add --wincairo option to run-webkit-tests
1190         https://bugs.webkit.org/show_bug.cgi?id=179217
1191
1192         Reviewed by Alex Christensen.
1193
1194         * Scripts/webkitpy/port/factory.py:
1195         (platform_options):
1196
1197 2017-11-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1198
1199         [WPE][GTK] Avoid duplicating code for dist and distcheck targets
1200         https://bugs.webkit.org/show_bug.cgi?id=179154
1201
1202         Reviewed by Carlos Garcia Campos.
1203
1204         Move the script out of Tools/gtk because it is already used by WPE. Also, drop the .py
1205         prefix because it is executable.
1206
1207         * Scripts/make-dist: Renamed from Tools/gtk/make-dist.py.
1208
1209 2017-11-03  Jonathan Bedard  <jbedard@apple.com>
1210
1211         TestController platformAdjustContext should use provided WKContext for Mac
1212         https://bugs.webkit.org/show_bug.cgi?id=179124
1213         <rdar://problem/35295176>
1214
1215         Reviewed by Darin Adler.
1216
1217         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1218         (WTR::initializeWebViewConfiguration): Use the provided WKContext, since that is
1219         a WebProcessPool, instead of creating a second one.
1220
1221 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1222
1223         Add a FileSystem namespace to FileSystem.cpp
1224         https://bugs.webkit.org/show_bug.cgi?id=179063
1225
1226         Reviewed by Darin Adler.
1227
1228         * DumpRenderTree/win/DumpRenderTree.cpp:
1229         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1230         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1231         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1232         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1233         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1234         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1235
1236 2017-11-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1237
1238         [WPE][JHBuild] Update WPEBackend and WPEBackend-mesa
1239         https://bugs.webkit.org/show_bug.cgi?id=179169
1240
1241         Reviewed by Michael Catanzaro.
1242
1243         Update WPEBackend and WPEBackend-mesa to last master as of today.
1244
1245         * wpe/jhbuild.modules:
1246
1247 2017-11-02  Frederic Wang  <fwang@igalia.com>
1248
1249         Add references to bug 179167 in FIXME comments
1250         https://bugs.webkit.org/show_bug.cgi?id=179168
1251
1252         Reviewed by Daniel Bates.
1253
1254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1255
1256 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1257
1258         Implement WKFullscreenWindowController for iOS.
1259         https://bugs.webkit.org/show_bug.cgi?id=178924
1260         rdar://problem/34697120
1261
1262         Reviewed by Simon Fraser.
1263
1264         Enable ENABLE_FULLSCREEN_API for iOS.
1265
1266         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1267
1268 2017-11-01  Simon Fraser  <simon.fraser@apple.com>
1269
1270         Misc display list and other cleanup
1271         https://bugs.webkit.org/show_bug.cgi?id=179150
1272
1273         Reviewed by Tim Horton.
1274
1275         Add system trace points for display list recording.
1276
1277         * Tracing/SystemTracePoints.plist:
1278
1279 2017-11-01  Stephan Szabo  <stephan.szabo@sony.com>
1280
1281         [Win] Detect Visual Studio 2017 location
1282         https://bugs.webkit.org/show_bug.cgi?id=175275
1283
1284         Reviewed by Yusuke Suzuki.
1285
1286         * Scripts/build-jsc:
1287         * Scripts/build-webkit:
1288         * Scripts/update-vswhere.py: Added.
1289         * Scripts/webkitdirs.pm:
1290         (requireModulesForVSWhere):
1291         (pickCurrentVisualStudioInstallation):
1292         (pickLegacyVisualStudioInstallation):
1293         (visualStudioInstallDir):
1294         (visualStudioInstallDirVSWhere):
1295         (visualStudioInstallDirLegacy):
1296         (visualStudioInstallDirFallback):
1297         (msBuildInstallDir):
1298         (visualStudioVersion):
1299         (visualStudioVersionFromInstallDir):
1300         (generateBuildSystemFromCMakeProject):
1301
1302 2017-11-01  Tim Horton  <timothy_horton@apple.com>
1303
1304         Fix the !USE(QUICKLOOK) build
1305         https://bugs.webkit.org/show_bug.cgi?id=179128
1306
1307         Reviewed by Wenson Hsieh.
1308
1309         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
1310
1311 2017-11-01  Frederic Wang  <fwang@igalia.com>
1312
1313         Make iOS Find UI reveal matches in scrollable elements
1314         https://bugs.webkit.org/show_bug.cgi?id=178789
1315
1316         Reviewed by Tim Horton.
1317
1318         This patch exposes WKWebView's findString function in order to test the fix for bug 178789.
1319
1320         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1321         (WTR::UIScriptController::findString): Dummy implementation of findString.
1322         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1323         (WTR::UIScriptController::findString): Ditto.
1324         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declare findString.
1325         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1326         (WTR::UIScriptController::findString): Dummy implementation of findString.
1327         * TestRunnerShared/UIScriptContext/UIScriptController.h: Declare findString.
1328         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1329         (WTR::UIScriptController::findString): Implement findString by forwarding the call to the
1330         web view.
1331         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1332         (WTR::UIScriptController::findString): Dummy implementation of findString.
1333
1334 2017-11-01  Alex Christensen  <achristensen@webkit.org>
1335
1336         Add a test for _WKInputDelegate.willSubmitFormValues
1337         https://bugs.webkit.org/show_bug.cgi?id=179086
1338
1339         Reviewed by Darin Adler.
1340
1341         Hidden input types are not included in this submission because FormSubmission::create ignores them
1342         because input.isTextField() returns false.  This is existing behavior that wasn't shown by a test.
1343         HTTPBodies are also not sent to WKURLSchemeHandlers.  This is existing behavior that wasn't shown by a test.
1344
1345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1346         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm: Added.
1347         (-[FormSubmissionDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
1348         (TEST):
1349
1350 2017-10-31  Ross Kirsling  <ross.kirsling@sony.com>
1351
1352         Web Inspector: Add Inspector menu items to Mac MiniBrowser
1353         https://bugs.webkit.org/show_bug.cgi?id=65218
1354
1355         Reviewed by Joseph Pecoraro.
1356
1357         Add Option-Command-I shortcut and corresponding Show/Close Web Inspector menu item to Mac MiniBrowser.
1358         Only works when browser window is focused, but at least WI can be opened without having to Inspect Element.
1359
1360         * MiniBrowser/mac/BrowserWindowController.h:
1361         * MiniBrowser/mac/BrowserWindowController.m:
1362         (-[BrowserWindowController showHideWebInspector:]):
1363         * MiniBrowser/mac/MainMenu.xib:
1364         * MiniBrowser/mac/WK1BrowserWindowController.m:
1365         (-[WK1BrowserWindowController validateMenuItem:]):
1366         (-[WK1BrowserWindowController showHideWebInspector:]):
1367         * MiniBrowser/mac/WK2BrowserWindowController.m:
1368         (-[WK2BrowserWindowController validateMenuItem:]):
1369         (-[WK2BrowserWindowController showHideWebInspector:]):
1370
1371 2017-10-31  Alex Christensen  <achristensen@webkit.org>
1372
1373         Use asynchronous ResourceHandleClient calls for WebKit1
1374         https://bugs.webkit.org/show_bug.cgi?id=160677
1375
1376         Reviewed by Brady Eidson.
1377
1378         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1379         (TestWebKitAPI::TEST):
1380         The HTML being loaded contains an iframe, so testing if the main resource has loaded doesn't necessarily mean all subresources are loaded.
1381         Wait until they are loaded before continuing the test.  This is a test of editing commands once the page has loaded, not a test of loading.
1382
1383 2017-10-31  Commit Queue  <commit-queue@webkit.org>
1384
1385         Unreviewed, rolling out r224143.
1386         https://bugs.webkit.org/show_bug.cgi?id=179091
1387
1388         The patch requires non-standard perl modules in macOS and
1389         breaks AWFY (Requested by yusukesuzuki on #webkit).
1390
1391         Reverted changeset:
1392
1393         "[Win] Detect Visual Studio 2017 location"
1394         https://bugs.webkit.org/show_bug.cgi?id=175275
1395         https://trac.webkit.org/changeset/224143
1396
1397 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1398
1399         Clean up some drag and drop feature flags
1400         https://bugs.webkit.org/show_bug.cgi?id=179082
1401
1402         Reviewed by Simon Fraser.
1403
1404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1405         * TestWebKitAPI/ios/UIKitSPI.h:
1406
1407 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1408
1409         Fix up some content filtering feature flags
1410         https://bugs.webkit.org/show_bug.cgi?id=179079
1411
1412         Reviewed by Simon Fraser.
1413
1414         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1415         * TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
1416         (-[MockContentFilterEnabler initWithCoder:]):
1417         (-[MockContentFilterEnabler dealloc]):
1418
1419 2017-10-31  Youenn Fablet  <youenn@apple.com>
1420
1421         rwt should allow service worker to load localhost HTTPS resources with any certificate
1422         https://bugs.webkit.org/show_bug.cgi?id=179018
1423
1424         Reviewed by Chris Dumez.
1425
1426         * WebKitTestRunner/TestController.cpp:
1427         (WTR::TestController::resetStateToConsistentValues): allowing any SSL certificate for service workers.
1428
1429 2017-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1430
1431         [Attachment Support] Implement WKWebView SPI for inserting attachment elements
1432         https://bugs.webkit.org/show_bug.cgi?id=179013
1433         <rdar://problem/35249668>
1434
1435         Reviewed by Tim Horton.
1436
1437         Adds a new API test suite to exercise attachment element insertion and manipulation.
1438
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1440         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: Added.
1441         (webViewForTestingAttachments):
1442         (testHTMLData):
1443         (testImageData):
1444         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]):
1445         (-[TestWKWebView valueOfAttribute:forQuerySelector:]):
1446         (TestWebKitAPI::TEST):
1447
1448 2017-10-31  Alex Christensen  <achristensen@webkit.org>
1449
1450         Fix custom header field setting with reloads and asynchronous navigation action policy decisions
1451         https://bugs.webkit.org/show_bug.cgi?id=179064
1452
1453         Reviewed by Tim Horton.
1454
1455         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1456         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1457         (TEST):
1458
1459 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1460
1461         WKBundlePageWillSendSubmitEventCallback is called with incorrect frame parameter
1462         https://bugs.webkit.org/show_bug.cgi?id=176719
1463
1464         Reviewed by Chris Dumez.
1465
1466         Test that WKBundlePageWillSendSubmitEventCallback is called with separate frame and
1467         sourceFrame parameters when the target frame of the form submission is not the source frame.
1468
1469         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1470         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1471         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent_Bundle.cpp:
1472         (TestWebKitAPI::willSendSubmitEvent):
1473         * TestWebKitAPI/Tests/WebKit/auto-submitting-form.html:
1474
1475 2017-10-30  Alex Christensen  <achristensen@webkit.org>
1476
1477         ASSERTION FAILED: internalValuesConsistent(m_url) in WebCore::URLParser::URLParser
1478         https://bugs.webkit.org/show_bug.cgi?id=178861
1479
1480         Reviewed by Tim Horton.
1481
1482         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1483         (TestWebKitAPI::TEST_F):
1484
1485 2017-10-30  Commit Queue  <commit-queue@webkit.org>
1486
1487         Unreviewed, rolling out r224078.
1488         https://bugs.webkit.org/show_bug.cgi?id=179026
1489
1490         MotionMark regression (Requested by shallawa on #webkit).
1491
1492         Reverted changeset:
1493
1494         "When navigating back to a page, compositing layers may not
1495         use accelerated drawing"
1496         https://bugs.webkit.org/show_bug.cgi?id=178749
1497         https://trac.webkit.org/changeset/224078
1498
1499 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1500
1501         [WPE] Fix build warnings
1502         https://bugs.webkit.org/show_bug.cgi?id=178899
1503
1504         Reviewed by Carlos Alberto Lopez Perez.
1505
1506         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1507         (testContextMenuDownloadActions):
1508         (testBlobDownload):
1509         (beforeAll):
1510         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1511         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1512         (testWebViewJavaScriptDialogs):
1513         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1514         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1515         * WebKitTestRunner/PlatformWPE.cmake:
1516         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1517         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1518         (WTR::threadDefaultContext): Deleted.
1519
1520 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1521
1522         [WPE] Upstream or stop using cairo-egl-device-create-for-egl-surface.patch
1523         https://bugs.webkit.org/show_bug.cgi?id=178898
1524
1525         Reviewed by Žan Doberšek.
1526
1527         This patch seems to be unused.
1528
1529         * wpe/jhbuild.modules:
1530         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Removed.
1531
1532 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1533
1534         [WPE] Build more files under WebCore as unified sources and get rid of WebCorePlatformWPE build target
1535         https://bugs.webkit.org/show_bug.cgi?id=178964
1536
1537         Reviewed by Carlos Alberto Lopez Perez.
1538
1539         * TestWebKitAPI/PlatformWPE.cmake:
1540
1541 2017-10-12  Frederic Wang  <fwang@igalia.com>
1542
1543         Remove support for running safari on the iOS simulator with Xcode < 9.0
1544         https://bugs.webkit.org/show_bug.cgi?id=178203
1545
1546         Reviewed by Alexey Proskuryakov.
1547
1548         This is a follow-up of r223234. We no longer support iOS WebKit development for Xcode < 9.0
1549         and do not have any iOS simulator builders in our infrastructure. Hence we can remove the
1550         special case to calculate the iOS simulator applications path for these old versions.
1551
1552         * Scripts/webkitdirs.pm:
1553         (iosSimulatorApplicationsPath): Remove special case for XCode < 9.0
1554
1555 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1556
1557         [WPE][GTK] Expose availability of certain editing commands in WebKitEditorState
1558         https://bugs.webkit.org/show_bug.cgi?id=168219
1559
1560         Reviewed by Ryosuke Niwa.
1561
1562         Test it.
1563
1564         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1565         (testWebViewEditorCutCopyPasteNonEditable):
1566         (testWebViewEditorCutCopyPasteEditable):
1567         (testWebViewEditorSelectAllNonEditable):
1568         (testWebViewEditorSelectAllEditable):
1569         (loadContentsAndTryToCutSelection):
1570         (testWebViewEditorNonEditable):
1571         (testWebViewEditorEditorStateTypingAttributes):
1572         (testWebViewEditorInsertImage):
1573         (testWebViewEditorCreateLink):
1574
1575 2017-10-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1576
1577         [WPE] Build gst-plugins-base without pango support
1578         https://bugs.webkit.org/show_bug.cgi?id=178918
1579
1580         Reviewed by Carlos Garcia Campos.
1581
1582         We need to build gst-plugins-base without pango support for WPE. Let's use JHBuild
1583         conditions so we can make platform-specific changes in the shared GStreamer moduleset.
1584
1585         * gstreamer/jhbuild.modules:
1586         * gtk/jhbuildrc:
1587         * wpe/jhbuildrc:
1588
1589 2017-10-27  Stephan Szabo  <stephan.szabo@sony.com>
1590
1591         [Win] Detect Visual Studio 2017 location
1592         https://bugs.webkit.org/show_bug.cgi?id=175275
1593
1594         Reviewed by Per Arne Vollan.
1595
1596         * Scripts/build-jsc:
1597         * Scripts/build-webkit:
1598         * Scripts/update-vswhere.py: Added.
1599         * Scripts/webkitdirs.pm:
1600         (pickCurrentVisualStudioInstallation):
1601         (pickLegacyVisualStudioInstallation):
1602         (visualStudioInstallDir):
1603         (visualStudioInstallDirVSWhere):
1604         (visualStudioInstallDirLegacy):
1605         (visualStudioInstallDirFallback):
1606         (msBuildInstallDir):
1607         (visualStudioVersion):
1608         (visualStudioVersionFromInstallDir):
1609         (generateBuildSystemFromCMakeProject):
1610
1611 2017-10-27  Devin Rousso  <webkit@devinrousso.com>
1612
1613         Create watchlist for files related WebInspector Recording
1614         https://bugs.webkit.org/show_bug.cgi?id=178965
1615
1616         Reviewed by Joseph Pecoraro.
1617
1618         * Scripts/webkitpy/common/config/watchlist:
1619
1620 2017-10-27  Jonathan Bedard  <jbedard@apple.com>
1621
1622         Windows and WebViews are retained after re-configure
1623         https://bugs.webkit.org/show_bug.cgi?id=178902
1624         <rdar://problem/35211518>
1625
1626         Reviewed by Alexey Proskuryakov.
1627
1628         The test runner effectively leaks windows every time a test changes configuration.
1629         We give each test it's own AutoreleasePool to fix this problem.
1630
1631         * WebKitTestRunner/TestController.cpp:
1632         (WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
1633         so that when a configuration changes, the old window and WebView are released.
1634
1635 2017-10-27  Eric Carlson  <eric.carlson@apple.com>
1636
1637         NowPlayingInfo should contain a unique identifier
1638         https://bugs.webkit.org/show_bug.cgi?id=178872
1639         <rdar://problem/34924012>
1640
1641         Unreviewed, fix a flakey test.
1642
1643         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1644         (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
1645         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.
1646
1647 2017-10-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1648
1649         autoinstall can't download from http://pypi.python.org
1650         https://bugs.webkit.org/show_bug.cgi?id=178925
1651
1652         Reviewed by Ryosuke Niwa.
1653
1654         The web server pypi.python.org rejects non secure http.
1655
1656         * Scripts/webkitpy/thirdparty/__init__.py:
1657         (AutoinstallImportHook._install_mechanize): Use https instead of http.
1658         (AutoinstallImportHook._install_pep8): Ditto.
1659         (AutoinstallImportHook._install_pylint): Ditto.
1660         (AutoinstallImportHook._install_buildbot): Ditto.
1661         (AutoinstallImportHook._install_coverage): Ditto.
1662
1663 2017-10-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1664
1665         [GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10
1666         https://bugs.webkit.org/show_bug.cgi?id=178854
1667
1668         Reviewed by Michael Catanzaro.
1669
1670         * Scripts/webkitpy/port/base.py:
1671         (Port._debian_php_version): Return "-php7.1" if libphp7.1.so found.
1672         (Port._is_debian_php_version_7): Deleted.
1673         * gtk/install-dependencies: Install libapache2-mod-php instead of libapache2-mod-php7.0.
1674         * wpe/install-dependencies: Ditto.
1675
1676 2017-10-25  Simon Fraser  <simon.fraser@apple.com>
1677
1678         When navigating back to a page, compositing layers may not use accelerated drawing
1679         https://bugs.webkit.org/show_bug.cgi?id=178749
1680         rdar://problem/35158946
1681
1682         Reviewed by Dean Jackson.
1683
1684         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
1685         and use it to set the state of the web view.
1686
1687         * DumpRenderTree/TestOptions.h:
1688         * DumpRenderTree/TestOptions.mm:
1689         (TestOptions::TestOptions):
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (setWebPreferencesForTestOptions):
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::TestController::resetPreferencesToConsistentValues):
1694         (WTR::updateTestOptionsFromTestHeader):
1695         * WebKitTestRunner/TestOptions.h:
1696         (WTR::TestOptions::hasSameInitializationOptions const):
1697
1698 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1699
1700         Move WKWebViewConfiguration validation to WKWebView construction
1701         https://bugs.webkit.org/show_bug.cgi?id=178840
1702
1703         Reviewed by Tim Horton.
1704
1705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1706         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm: Added.
1707         (TEST):
1708
1709 2017-10-26  Myles C. Maxfield  <mmaxfield@apple.com>
1710
1711         Demonstrate a possible structure of the WebGPU API
1712         https://bugs.webkit.org/show_bug.cgi?id=178874
1713
1714         Reviewed by Dean Jackson.
1715
1716         Over the past few weeks, we've been putting together an example showing that a WebGPU API
1717         which has implicit barriers can work on all three low-level graphics APIs. We've implemented
1718         it on top of Vulkan first, because this is the API which has the strictest requirements and
1719         is most difficult to use.
1720
1721         With this API, this is a valid WebGPU snippet:
1722
1723         auto device = WebGPU::Device::create(hInstance, hWnd);
1724         auto& commandQueue = device->getCommandQueue();
1725         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { }, nullptr);
1726         
1727         … later, in the draw() function …
1728         
1729         auto renderPass = commandQueue->createRenderPass(nullptr);
1730         renderPass->setRenderState(renderState);
1731         renderPass->setViewport(0, 0, width, height);
1732         renderPass->setScissorRect(0, 0, width, height);
1733         renderPass->draw(3);
1734         commandQueue->commitRenderPass(std::move(renderPass));
1735         commandQueue->present();
1736
1737         This snippet doesn’t hook up any vertex attributes or resources, which means the vertex
1738         shader has to say something like ({vec4(…), vec4(…), vec4(…)})[gl_VertexIndex]. It also
1739         passes in “nullptr” when creating the render pass, which means “render to the screen, rather
1740         than to a frame buffer.” You can also see that it doesn’t attach any resources to the draw
1741         call.
1742
1743         In Direct3D 12 and Vulkan, resources are bound in sets, rather than individually. For
1744         example, a set might contain two uniform buffers, a texture, and another uniform buffer. At
1745         draw time, you swap in whole sets of resources with a single call. A shader invocation can
1746         access a collection of sets. Because all shader resource accesses are indirected through
1747         these sets, the shape of these sets needs to be supplied at the time you compile the render
1748         state. Here is a snippet which bounds a single set which contains a uniform buffer and a
1749         texture:
1750
1751         auto buffer = device->getBuffer(bufferInitialContents);
1752         auto texture = device->getTexture(buffer width, height, WebGPU::PixelFormat::RGBA8, textureInitialContents);
1753         // One resource set, which holds a single uniform buffer object and a single texture
1754         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { { WebGPU::ResourceType::UniformBufferObject, WebGPU::ResourceType::Texture } }, nullptr);
1755         
1756         … later, in the draw() function …
1757         
1758         auto renderPass = commandQueue->createRenderPass(nullptr);
1759         renderPass->setRenderState(renderState);
1760         renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()), WebGPU::TextureReference(texture.get()) });
1761         …
1762         renderPass->draw(3);
1763         commandQueue->commitRenderPass(std::move(renderPass));
1764         commandQueue->present();
1765         
1766         The first argument to the setResources() call identifies which set to populate with the supplied resources.
1767
1768         One tenant of the low-level graphics APIs is that, if you’ve enabled double buffering (or
1769         triple buffering), the GPU is executing one frame at the same time you are recording the
1770         next frame. This often means that you need duplicate resources so the CPU and GPU don’t step
1771         on each other’s toes. However, platforms have platform-specific requirements about whether
1772         or not they can be double / triple buffered, and we don’t want to expose this to the Web for
1773         fear of badly-authored programs.
1774
1775         To solve this, resources are reference counted, and the return type of getBuffer() is an
1776         RAII type called BufferHolder which increments and decrements the reference count
1777         automatically. The reference count is also incremented and decremented when the GPU is using
1778         the resource in a Pass. When the reference count reaches 0, the resource isn’t destroyed;
1779         instead, it’s simply moved to a “free list” which getBuffer() may pull from. Therefore,
1780         applications don’t need to know whether the frame buffer is double buffered or triple
1781         buffered; they can just getBuffer() each frame, and the correct number of buffers will be
1782         created and recycled.
1783         
1784         {
1785             auto buffer = device->getBuffer(bufferSize); // These get recycled
1786             … populate the buffer …
1787             auto renderPass = commandQueue->createRenderPass(nullptr);
1788             renderPass->setRenderState(renderState);
1789             renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()) });
1790             …
1791             renderPass->draw(…);
1792             commandQueue->commitRenderPass(std::move(renderPass));
1793         }
1794         commandQueue->present();
1795
1796         In Direct3D and Vulkan, vertex buffers and index buffers are not part of the resource sets
1797         mentioned above. Instead, you tell the render state about the shape of the vertex and index
1798         buffers, and you swap them out independently in the draw loop. Metal and Vulkan have almost
1799         identical API to specify this shape of the vertex buffers, so I’ve mostly copied it. In this
1800         example, we have two vertex attributes, a vec2 and a vec3, which both come from the same
1801         buffer:
1802         
1803         // { Attribute format, offset within stride, buffer to pull from }
1804         std::vector<WebGPU::RenderState::VertexAttribute> vertexAttributes = { {WebGPU::RenderState::VertexFormat::Float2, 0, 0}, {WebGPU::RenderState::VertexFormat::Float3, sizeof(float) * 2, 0} };
1805         // A single vertex buffer, with a stride of 5 floats
1806         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { sizeof(float) * 5 }, vertexAttributes, resourceTypes, nullptr);
1807         
1808         … later, in the draw() function …
1809         
1810         auto renderPass = commandQueue->createRenderPass(nullptr);
1811         renderPass->setRenderState(renderState);
1812         renderPass->setVertexAttributeBuffers({ vertexBuffer.get() }); // The one vertex buffer which both attributes pull from
1813         renderPass->setResources(…);
1814         …
1815         renderPass->draw(…);
1816         commandQueue->commitRenderPass(std::move(renderPass));
1817         commandQueue->present();
1818
1819         You can also tell the RenderState about how many render targets you have and their formats,
1820         and then when you create the RenderPass, you specify the specific textures you want to
1821         render into.
1822
1823         std::vector<WebGPU::PixelFormat> colorPixelFormats = { WebGPU::PixelFormat::RGBA8, WebGPU::PixelFormat::RGBA8 }; // Two render targets, with these formats
1824         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", vertexBufferStrides, vertexAttributes, resourceTypes, &colorPixelFormats);
1825         
1826         … later, in the draw() function …
1827         
1828         std::vector<std::reference_wrapper<WebGPU::Texture>> destinationTextures = { texture1->get(), texture2->get() };
1829         auto renderPass = commandQueue->createRenderPass(&destinationTextures);
1830         renderPass->setRenderState(renderState);
1831         …
1832         renderPass->draw(…);
1833         commandQueue->commitRenderPass(std::move(renderPass));
1834         
1835         // Now, draw one of the textures to the screen. Note that no synchronization is necessary here!
1836         auto renderPass = commandQueue->createRenderPass(nullptr);
1837         renderPass->setRenderState(renderState2);
1838         renderPass->setResources(0, { WebGPU:: TextureReference(texture1.get()) });
1839         …
1840         renderPass->draw(…);
1841         commandQueue->commitRenderPass(std::move(renderPass));
1842         commandQueue->present();
1843
1844         Just like how in Metal has Render Encoders and Compute Encoders, WebGPU has RenderPasses
1845         and ComputePasses.
1846
1847         auto& computeState = device->getComputeState(computeShader, "main", resourceTypes);
1848         …
1849         auto computePass = commandQueue->createComputePass();
1850         computePass->setComputeState(computeState);
1851         computePass->setResources(0, resources);
1852         computePass->dispatch(width, height, depth);
1853         commandQueue->commitComputePass(std::move(computePass));
1854         
1855         // Now, draw the resources we just computed. Note that no synchronization is necessary here!
1856         auto renderPass = commandQueue->createRenderPass(nullptr);
1857         renderPass->setRenderState(renderState);
1858         renderPass->setResources(0, resources });
1859         …
1860         renderPass->draw(…);
1861         commandQueue->commitRenderPass(std::move(renderPass));
1862         commandQueue->present();
1863
1864         There are also two other types of passes: one that corresponds to a Metal blit encoder, and
1865         one that allows the CPU to change the contents of GPU buffers and textures. This last kind
1866         of pass is a little interesting: you can’t just change the contents of a buffer at any time
1867         you feel like it, because that resource might be in use by the GPU. Therefore, we need to do
1868         the same kind of synchronization that we already do at render pass boundaries.
1869
1870         In addition, both Vulkan and Direct3D have a concept of a memory heap. A resource might
1871         exist inside a heap which is fast, but invisible from the CPU, or in a heap which is slow,
1872         but visible by the CPU. Certain operations are not possible from some types of images (e.g.
1873         non-tiled textures may not be able to be sampled from). The usual way to get around this
1874         problem is to have two resources: a slow staging resource which the CPU can see, and a fast
1875         resource which the CPU can’t see. Uploading data is a two-pass algorithm, where the CPU
1876         memcpy()s into the slow staging resource, and then a blit command is enqueued on the GPU to
1877         copy the contents of the staging resource to the real resource. This requires that the
1878         upload have access to the commandQueue so it can possibly enqueue a blit between the staging
1879         and real resources. Therefore, a pass is the right level of abstraction for these facilities.
1880
1881         std::queue<boost::unique_future<std::vector<uint8_t>>> futureQueue; // Promises for data downloads from the GPU
1882         
1883         … later, in the draw() function …
1884         
1885         // See if any of the previously-enqueued downloads are finished
1886         while (!futureQueue.empty() && futureQueue.front(). has_value()) {
1887             std::vector<uint8_t>& data = futureQueue.front().get();
1888             // Use the downloaded data
1889             futureQueue.pop();
1890         }
1891         …
1892         auto hostAccessPass = commandQueue->createHostAccessPass();
1893         hostAccessPass->overwriteBuffer(buffer->get(), bufferContents); // Upload data to a resource
1894         
1895         futureQueue.emplace(hostAccessPass->getBufferContents(buffer->get()));
1896         commandQueue->commitHostAccessPass(std::move(hostAccessPass));
1897         
1898         You can also issue copy commands between resources entirely on the GPU:
1899         
1900         auto blitPass = commandQueue->createBlitPass();
1901         blitPass->copyTexture(source->get(), destination->get(), sourceX, sourceY, destinationX, destinationY, width, height);
1902         commandQueue->commitBlitPass(std::move(blitPass));
1903
1904         * Scripts/webkitpy/style/checker.py:
1905         * WebGPUAPIStructure/Example/Example.cpp: Added.
1906         (readFile):
1907         (drawWebGPU):
1908         (wWinMain):
1909         (MyRegisterClass):
1910         (InitInstance):
1911         (WndProc):
1912         * WebGPUAPIStructure/Example/Example.h: Added.
1913         * WebGPUAPIStructure/Example/Example.ico: Added.
1914         * WebGPUAPIStructure/Example/Example.rc: Added.
1915         * WebGPUAPIStructure/Example/Example.vcxproj: Added.
1916         * WebGPUAPIStructure/Example/Example.vcxproj.filters: Added.
1917         * WebGPUAPIStructure/Example/Example.vcxproj.user: Added.
1918         * WebGPUAPIStructure/Example/resource.h: Added.
1919         * WebGPUAPIStructure/Example/small.ico: Added.
1920         * WebGPUAPIStructure/Example/stdafx.cpp: Added.
1921         * WebGPUAPIStructure/Example/stdafx.h: Added.
1922         * WebGPUAPIStructure/Example/targetver.h: Added.
1923         * WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj: Added.
1924         * WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj.filters: Added.
1925         * WebGPUAPIStructure/WebGPU-Common/WebGPU.cpp: Added.
1926         (WebGPU::BufferHolder::BufferHolder):
1927         (WebGPU::BufferHolder::~BufferHolder):
1928         (WebGPU::TextureHolder::TextureHolder):
1929         (WebGPU::TextureHolder::~TextureHolder):
1930         (WebGPU::SamplerHolder::SamplerHolder):
1931         (WebGPU::SamplerHolder::~SamplerHolder):
1932         * WebGPUAPIStructure/WebGPU-Common/WebGPU.h: Added.
1933         (WebGPU::Queue::~Queue):
1934         (WebGPU::RenderState::~RenderState):
1935         (WebGPU::ComputeState::~ComputeState):
1936         (WebGPU::Buffer::~Buffer):
1937         (WebGPU::Texture::~Texture):
1938         (WebGPU::Sampler::~Sampler):
1939         (WebGPU::TextureReference::TextureReference):
1940         (WebGPU::TextureReference::get const):
1941         (WebGPU::SamplerReference::SamplerReference):
1942         (WebGPU::SamplerReference::get const):
1943         (WebGPU::UniformBufferObjectReference::UniformBufferObjectReference):
1944         (WebGPU::UniformBufferObjectReference::get const):
1945         (WebGPU::ShaderStorageBufferObjectReference::ShaderStorageBufferObjectReference):
1946         (WebGPU::ShaderStorageBufferObjectReference::get const):
1947         (WebGPU::RenderPass::~RenderPass):
1948         (WebGPU::ComputePass::~ComputePass):
1949         (WebGPU::BlitPass::~BlitPass):
1950         (WebGPU::HostAccessPass::~HostAccessPass):
1951         (WebGPU::BufferHolder::get):
1952         (WebGPU::TextureHolder::get):
1953         (WebGPU::SamplerHolder::get):
1954         (WebGPU::Device::~Device):
1955         * WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.cpp: Added.
1956         (WebGPU::BlitPassImpl::BlitPassImpl):
1957         (WebGPU::BlitPassImpl::copyTexture):
1958         * WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.h: Added.
1959         * WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.cpp: Added.
1960         (WebGPU::BufferImpl::BufferImpl):
1961         (WebGPU::BufferImpl::decrementReferenceCount):
1962         * WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.h: Added.
1963         (WebGPU::BufferImpl::getBuffer const):
1964         (WebGPU::BufferImpl::getDeviceMemory const):
1965         (WebGPU::BufferImpl::incrementReferenceCount):
1966         (WebGPU::BufferImpl::getLength const):
1967         * WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.cpp: Added.
1968         (WebGPU::ComputePassImpl::ComputePassImpl):
1969         (WebGPU::ComputePassImpl::setComputeState):
1970         (WebGPU::ComputePassImpl::setResources):
1971         (WebGPU::ComputePassImpl::dispatch):
1972         * WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.h: Added.
1973         * WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.cpp: Added.
1974         (WebGPU::ComputeStateImpl::ComputeStateImpl):
1975         * WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.h: Added.
1976         (WebGPU::ComputeStateImpl::getPipeline const):
1977         (WebGPU::ComputeStateImpl::getPipelineLayout const):
1978         (WebGPU::ComputeStateImpl::getDescriptorSetLayouts const):
1979         * WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.cpp: Added.
1980         (WebGPU::Device::create):
1981         (WebGPU::convertPixelFormat):
1982         (WebGPU::convertFormat):
1983         (WebGPU::debugReport):
1984         (WebGPU::DeviceImpl::DeviceImpl):
1985         (WebGPU::DeviceImpl::getCommandQueue):
1986         (WebGPU::DeviceImpl::prepareShader):
1987         (WebGPU::DeviceImpl::createPipelineLayout):
1988         (WebGPU::DeviceImpl::createCompatibleRenderPass):
1989         (WebGPU::convertVertexFormat):
1990         (WebGPU::DeviceImpl::getRenderState):
1991         (WebGPU::DeviceImpl::getComputeState):
1992         (WebGPU::DeviceImpl::getBuffer):
1993         (WebGPU::DeviceImpl::returnBuffer):
1994         (WebGPU::DeviceImpl::getTexture):
1995         (WebGPU::DeviceImpl::returnTexture):
1996         (WebGPU::DeviceImpl::getSampler):
1997         (WebGPU::DeviceImpl::returnSampler):
1998         (WebGPU::DeviceImpl::~DeviceImpl):
1999         * WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.h: Added.
2000         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::UniqueDebugReportCallbackEXT):
2001         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::operator=):
2002         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::~UniqueDebugReportCallbackEXT):
2003         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::destroy):
2004         (WebGPU::DeviceImpl::TextureParameters::operator== const):
2005         (WebGPU::DeviceImpl::TextureParametersHash::operator() const):
2006         * WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.cpp: Added.
2007         (WebGPU::HostAccessPassImpl::HostAccessPassImpl):
2008         (WebGPU::HostAccessPassImpl::overwriteBuffer):
2009         (WebGPU::HostAccessPassImpl::getBufferContents):
2010         (WebGPU::HostAccessPassImpl::execute):
2011         * WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.h: Added.
2012         (WebGPU::HostAccessPassImpl::getFinishedEvent const):
2013         * WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.cpp: Added.
2014         (WebGPU::PassImpl::PassImpl):
2015         (WebGPU::ResourceVisitor::operator()):
2016         (WebGPU::ResourceVisitor::getBindings const):
2017         (WebGPU::ResourceVisitor::releaseWriteDescriptorSets):
2018         (WebGPU::ResourceVisitor::getDescriptorImageInfos const):
2019         (WebGPU::ResourceVisitor::getDescriptorBufferInfos const):
2020         (WebGPU::ResourceVisitor::getBuffers const):
2021         (WebGPU::ResourceVisitor::getTextures const):
2022         (WebGPU::ResourceVisitor::getSamplers const):
2023         (WebGPU::ResourceVisitor::getImageCount const):
2024         (WebGPU::ResourceVisitor::getSamplerCount const):
2025         (WebGPU::ResourceVisitor::getUniformBufferCount const):
2026         (WebGPU::ResourceVisitor::getStorageBufferCount const):
2027         (WebGPU::PassImpl::setResources):
2028         (WebGPU::PassImpl::insertBuffer):
2029         (WebGPU::PassImpl::insertTexture):
2030         (WebGPU::PassImpl::insertSampler):
2031         * WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.h: Added.
2032         (WebGPU::PassImpl::getCommandBuffer const):
2033         (WebGPU::PassImpl::iterateBuffers):
2034         (WebGPU::PassImpl::iterateTextures):
2035         (WebGPU::PassImpl::ResourceReference::ResourceReference):
2036         (WebGPU::PassImpl::ResourceReference::~ResourceReference):
2037         (WebGPU::PassImpl::ResourceReference::operator=):
2038         (WebGPU::PassImpl::ResourceReference::operator== const):
2039         (WebGPU::PassImpl::ResourceReference::get const):
2040         (WebGPU::PassImpl::ResourceReference::release):
2041         (WebGPU::PassImpl::ResourceReferenceHash::operator() const):
2042         * WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp: Added.
2043         (WebGPU::QueueImpl::QueueImpl):
2044         (WebGPU::QueueImpl::prepareCurrentFrame):
2045         (WebGPU::QueueImpl::createSpecificRenderPass):
2046         (WebGPU::QueueImpl::createFramebuffer):
2047         (WebGPU::QueueImpl::createRenderPass):
2048         (WebGPU::QueueImpl::commitRenderPass):
2049         (WebGPU::QueueImpl::createComputePass):
2050         (WebGPU::QueueImpl::commitComputePass):
2051         (WebGPU::QueueImpl::createBlitPass):
2052         (WebGPU::QueueImpl::commitBlitPass):
2053         (WebGPU::QueueImpl::createHostAccessPass):
2054         (WebGPU::QueueImpl::commitHostAccessPass):
2055         (WebGPU::QueueImpl::present):
2056         (WebGPU::QueueImpl::commitPass):
2057         (WebGPU::QueueImpl::synchronizeResources):
2058         (WebGPU::QueueImpl::~QueueImpl):
2059         * WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.h: Added.
2060         * WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.cpp: Added.
2061         (WebGPU::RenderPassImpl::RenderPassImpl):
2062         (WebGPU::RenderPassImpl::setRenderState):
2063         (WebGPU::RenderPassImpl::setVertexAttributeBuffers):
2064         (WebGPU::RenderPassImpl::setResources):
2065         (WebGPU::RenderPassImpl::setViewport):
2066         (WebGPU::RenderPassImpl::setScissorRect):
2067         (WebGPU::RenderPassImpl::draw):
2068         * WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.h: Added.
2069         * WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.cpp: Added.
2070         (WebGPU::RenderStateImpl::RenderStateImpl):
2071         * WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.h: Added.
2072         (WebGPU::RenderStateImpl::getPipeline const):
2073         (WebGPU::RenderStateImpl::getPipelineLayout const):
2074         (WebGPU::RenderStateImpl::getDescriptorSetLayouts const):
2075         * WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.cpp: Added.
2076         (WebGPU::SamplerImpl::SamplerImpl):
2077         (WebGPU::SamplerImpl::decrementReferenceCount):
2078         * WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.h: Added.
2079         (WebGPU::SamplerImpl::getSampler):
2080         (WebGPU::SamplerImpl::incrementReferenceCount):
2081         (WebGPU::SamplerImpl::getFilter):
2082         (WebGPU::SamplerImpl::getMipmapMode):
2083         (WebGPU::SamplerImpl::getAddressMode):
2084         * WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.cpp: Added.
2085         (WebGPU::TextureImpl::TextureImpl):
2086         (WebGPU::TextureImpl::decrementReferenceCount):
2087         * WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.h: Added.
2088         (WebGPU::TextureImpl::getImage const):
2089         (WebGPU::TextureImpl::getImageView const):
2090         (WebGPU::TextureImpl::getFormat const):
2091         (WebGPU::TextureImpl::incrementReferenceCount):
2092         (WebGPU::TextureImpl::getWidth const):
2093         (WebGPU::TextureImpl::getHeight const):
2094         (WebGPU::TextureImpl::getTransferredToGPU const):
2095         (WebGPU::TextureImpl::setTransferredToGPU):
2096         * WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj: Added.
2097         * WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj.filters: Added.
2098         * WebGPUAPIStructure/WebGPU.sln: Added.
2099
2100 2017-10-26  Eric Carlson  <eric.carlson@apple.com>
2101
2102         NowPlayingInfo should contain a unique identifier
2103         https://bugs.webkit.org/show_bug.cgi?id=178872
2104
2105         Reviewed by Jer Noble.
2106
2107         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2108         (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Use completion handler.
2109         (TestWebKitAPI::TEST): Cleanup tests. Use new API.
2110         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]): Deleted.
2111
2112 2017-10-26  Eric Carlson  <eric.carlson@apple.com>
2113
2114         [MediaStream] Clear cached gUM prompt state
2115         https://bugs.webkit.org/show_bug.cgi?id=178754
2116         <rdar://problem/32742356>
2117
2118         Unreviewed, fix a flakey test.
2119
2120         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2121         (-[GetUserMediaRepromptTestView haveStream:]): New, check several times for expected state.
2122         (TestWebKitAPI::TEST): Don't assume stream state changes in the page immediately.
2123
2124 2017-10-26  Andy Estes  <aestes@apple.com>
2125
2126         [Payment Request] Enable Payment Request whenever Apple Pay is enabled
2127         https://bugs.webkit.org/show_bug.cgi?id=178880
2128
2129         Reviewed by Tim Horton.
2130
2131         * WebKitTestRunner/TestController.cpp:
2132         (WTR::TestController::resetPreferencesToConsistentValues):
2133
2134 2017-10-26  Joseph Pecoraro  <pecoraro@apple.com>
2135
2136         Add and update some watchlists
2137         https://bugs.webkit.org/show_bug.cgi?id=178304
2138
2139         Reviewed by Simon Fraser.
2140
2141         * Scripts/webkitpy/common/config/watchlist:
2142
2143 2017-10-26  Ryan Haddad  <ryanhaddad@apple.com>
2144
2145         Unreviewed, rolling out r223984.
2146
2147         Caused LayoutTest assertion failures.
2148
2149         Reverted changeset:
2150
2151         "When navigating back to a page, compositing layers may not
2152         use accelerated drawing"
2153         https://bugs.webkit.org/show_bug.cgi?id=178749
2154         https://trac.webkit.org/changeset/223984
2155
2156 2017-10-26  Christopher Reid  <chris.reid@sony.com>
2157
2158         Remove scopeguard from platform
2159         https://bugs.webkit.org/show_bug.cgi?id=178681
2160
2161         Reviewed by Brady Eidson.
2162
2163         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2164
2165 2017-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2166
2167         WebDriver: Add support to import and run W3C tests
2168         https://bugs.webkit.org/show_bug.cgi?id=177304
2169
2170         Reviewed by Brian Burg.
2171
2172         WPT has now several WebDriver tests, and new ones are going to be added to cover the whole spec. This patch
2173         adds the initial support for running W3C tests. The script import-w3c-webdriver-tests reuses parts of the W3C
2174         test downloader to download the tests and required tools from WPT repository into WebDriverTests
2175         directory. Tests can be run with run-webdriver-tests, a new script that works similar to other test runner
2176         scripts. For now it shows a summary at the end of the execution, there aren't expectations yet, since we are not
2177         ready to run those tests in the bots. Once we are ready to properly run the tests, we can add the expectations
2178         support and run the tests in the bots.
2179
2180         * Scripts/import-w3c-webdriver-tests: Added.
2181         * Scripts/run-webdriver-tests: Added.
2182         * Scripts/webkitpy/style/checker.py: Skip WebDriverTests directory since it only contains third-party python
2183         code.
2184         * Scripts/webkitpy/thirdparty/__init__.py: Add support to autodownload mozlog and mozprocess since they are
2185         required by the WebDriver tests.
2186         * Scripts/webkitpy/webdriver_tests/__init__.py: Added.
2187         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py: Added.
2188         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py: Added.
2189         * Scripts/webkitpy/webdriver_tests/webdriver_test_result.py: Added.
2190         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Added.
2191         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py: Added.
2192         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Added.
2193         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py: Added.
2194
2195 2017-10-25  Eric Carlson  <eric.carlson@apple.com>
2196
2197         [MediaStream] Clear cached gUM prompt state
2198         https://bugs.webkit.org/show_bug.cgi?id=178754
2199         <rdar://problem/32742356>
2200
2201         Reviewed by Youenn Fablet.
2202
2203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test
2204
2205         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm: Added.
2206         (-[GetUserMediaRepromptUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2207         (-[GetUserMediaRepromptUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2208         (TestWebKitAPI::TEST):
2209
2210         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2211
2212 2017-10-25  Ross Kirsling  <ross.kirsling@sony.com>
2213
2214         Add committer status for Ross Kirsling
2215         https://bugs.webkit.org/show_bug.cgi?id=178832
2216
2217         Unreviewed.
2218
2219         * Scripts/webkitpy/common/config/contributors.json:
2220
2221 2017-10-25  Simon Fraser  <simon.fraser@apple.com>
2222
2223         When navigating back to a page, compositing layers may not use accelerated drawing
2224         https://bugs.webkit.org/show_bug.cgi?id=178749
2225         rdar://problem/35158946
2226
2227         Reviewed by Dean Jackson.
2228
2229         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
2230         and use it to set the state of the web view.
2231
2232         * DumpRenderTree/TestOptions.h:
2233         * DumpRenderTree/TestOptions.mm:
2234         (TestOptions::TestOptions):
2235         * DumpRenderTree/mac/DumpRenderTree.mm:
2236         (setWebPreferencesForTestOptions):
2237         * WebKitTestRunner/TestController.cpp:
2238         (WTR::TestController::resetPreferencesToConsistentValues):
2239         (WTR::updateTestOptionsFromTestHeader):
2240         * WebKitTestRunner/TestOptions.h:
2241         (WTR::TestOptions::hasSameInitializationOptions const):
2242
2243 2017-10-25  Robin Morisset  <rmorisset@apple.com>
2244
2245         Support the TailBench9000 benchmark in run-jsc-benchmarks
2246         https://bugs.webkit.org/show_bug.cgi?id=178451
2247
2248         Reviewed by Saam Barati.
2249
2250         * Scripts/run-jsc-benchmarks:
2251
2252 2017-10-25  Adrian Perez de Castro  <aperez@igalia.com>
2253
2254         [WPE] Remove GLib API functions which use Cairo
2255         https://bugs.webkit.org/show_bug.cgi?id=178205
2256
2257         Reviewed by Michael Catanzaro.
2258
2259         Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
2260         page snapshots and favicons) which are not available in the WPE version of the GLib API.
2261
2262         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2263         (testNotInitialized):
2264         (testPrivateBrowsing):
2265         (testFaviconDatabase):
2266         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2267         (testFindControllerHide):
2268         (beforeAll):
2269         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2270         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2271
2272 2017-10-25  Zan Dobersek  <zdobersek@igalia.com>
2273
2274         Make SERVICE_WORKER feature buildable on GTK, WPE
2275         https://bugs.webkit.org/show_bug.cgi?id=178574
2276
2277         Reviewed by Carlos Garcia Campos.
2278
2279         * Scripts/webkitperl/FeatureList.pm: Add the --service-worker option
2280         that enables the SERVICE_WORKER feature flag. For now it's enabled
2281         on Apple's Cocoa ports (even when build-webkit isn't used for those
2282         builds, the flag is enabled here for consistency).
2283
2284 2017-10-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2285
2286         Unreviewed, fix name of Perl LibXML package on Fedora
2287         https://bugs.webkit.org/show_bug.cgi?id=178206
2288         <rdar://problem/35028586>
2289
2290         * gtk/install-dependencies:
2291         * wpe/install-dependencies:
2292
2293 2017-10-24  Alex Christensen  <achristensen@webkit.org>
2294
2295         Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
2296         https://bugs.webkit.org/show_bug.cgi?id=174267
2297
2298         Reviewed by Tim Horton.
2299
2300         * TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
2301         (TestWebKitAPI::runTest):
2302
2303 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2304
2305         Web Inspector: Enable WebKit logging configuration and display
2306         https://bugs.webkit.org/show_bug.cgi?id=177027
2307         <rdar://problem/33964767>
2308
2309         Reviewed by Joseph Pecoraro.
2310
2311         Allow new 'dumpJSConsoleLogInStdErr' test header to redirect log console output to stderr.
2312
2313         * DumpRenderTree/TestOptions.h:
2314         * DumpRenderTree/TestOptions.mm:
2315         (TestOptions::TestOptions):
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (runTest):
2318         * WebKitTestRunner/TestController.cpp:
2319         (WTR::updateTestOptionsFromTestHeader):
2320         (WTR::TestController::runTest):
2321         * WebKitTestRunner/TestOptions.h:
2322         (WTR::TestOptions::hasSameInitializationOptions const):
2323
2324 2017-10-24  Alex Christensen  <achristensen@webkit.org>
2325
2326         Apply custom header fields from WebsitePolicies to same-domain requests
2327         https://bugs.webkit.org/show_bug.cgi?id=178356
2328
2329         Reviewed by Brady Eidson.
2330
2331         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2332         (expectHeaders):
2333
2334 2017-10-24  Stephan Szabo  <stephan.szabo@sony.com>
2335
2336         [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
2337         https://bugs.webkit.org/show_bug.cgi?id=177279
2338
2339         Reviewed by Yusuke Suzuki.
2340
2341         * Scripts/build-jsc:
2342         * Scripts/run-jsc-stress-tests:
2343
2344 2017-10-23  Lucas Forschler  <lforschler@apple.com>
2345
2346         <rdar://problem/35045445>
2347         Update README to reference WebKit build archives, instead of 'nightly'
2348
2349         Reviewed by Aakash Jain.
2350
2351         * WebKitArchiveSupport/README:
2352
2353 2017-10-21  Tim Horton  <timothy_horton@apple.com>
2354
2355         Turn on ccache for Mac cmake builds by default
2356         https://bugs.webkit.org/show_bug.cgi?id=177059
2357
2358         Reviewed by Sam Weinig.
2359
2360         * ccache/ccache-clang:
2361         * ccache/ccache-wrapper: Added.
2362         Add a pass-through ccache wrapper to be used with CMake, in addition
2363         to the existing faux-clang wrappers.
2364
2365         * Scripts/build-webkit:
2366         Add --use-ccache and --no-use-ccache option, which will define
2367         WK_USE_CCACHE to YES or NO, respectively, which the underlying
2368         build systems respect. We do not define WK_USE_CCACHE if the option
2369         is not specified, because the underlying build systems have different
2370         default values.
2371
2372 2017-10-20  Aakash Jain  <aakash_jain@apple.com>
2373
2374         Do not run binding tests on multiple EWSes
2375         https://bugs.webkit.org/show_bug.cgi?id=178599
2376
2377         Reviewed by Alexey Proskuryakov. 
2378
2379         Remove old code which runs bindings tests and ignore it's result. We now have
2380         a dedicated bindings test EWS.
2381
2382         * Scripts/webkitpy/tool/steps/runtests.py:
2383         (RunTests.run): Removed bindings tests code.
2384         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
2385         (RunTestsTest.test_webkit_run_unit_tests): Ditto.
2386         * Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
2387         * Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.
2388
2389 2017-10-20  Youenn Fablet  <youenn@apple.com>
2390
2391         WebsiteDataStoreCustomPaths.mm is failing after r223718
2392         https://bugs.webkit.org/show_bug.cgi?id=178596
2393
2394         Unreviewed.
2395
2396         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2397         (TEST): Making default web site data store creation expected at the end of the test.
2398         We should probably not need need to create it.
2399         This should be fixed as a follow-up.
2400
2401 2017-10-20  Antoine Quint  <graouts@apple.com>
2402
2403         [Web Animations] Provide basic timeline and animation interfaces
2404         https://bugs.webkit.org/show_bug.cgi?id=178526
2405
2406         Reviewed by Dean Jackson.
2407
2408         Remove the WEB_ANIMATIONS compile-time flag.
2409
2410         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2411
2412 2017-10-20  Tomas Popela  <tpopela@redhat.com>
2413
2414         Missing some perl packages in install-dependencies
2415         https://bugs.webkit.org/show_bug.cgi?id=178571
2416
2417         Reviewed by Žan Doberšek.
2418
2419         Install per-version and perl-Time-HiRes so we can use build-webkit
2420         script. Also add missing backlashes.
2421
2422         * wpe/install-dependencies:
2423
2424 2017-10-20  Commit Queue  <commit-queue@webkit.org>
2425
2426         Unreviewed, rolling out r222709 and r223572.
2427         https://bugs.webkit.org/show_bug.cgi?id=178587
2428
2429         Still getting mac-wk2 EWS bots stuck (Requested by ap on
2430         #webkit).
2431
2432         Reverted changesets:
2433
2434         "Log stack-trace for run-webkit-tests when interrupted"
2435         https://bugs.webkit.org/show_bug.cgi?id=176393
2436         https://trac.webkit.org/changeset/222709
2437
2438         "webkitpy: Hang when workers write to the same stack trace
2439         file"
2440         https://bugs.webkit.org/show_bug.cgi?id=178402
2441         https://trac.webkit.org/changeset/223572
2442
2443 2017-10-19  Nan Wang  <n_wang@apple.com>
2444
2445         AX: Provide a way for Accessibility to cache the selection while retrieving rects for speak selection
2446         https://bugs.webkit.org/show_bug.cgi?id=176247
2447         <rdar://problem/34217143>
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2452         (TestWebKitAPI::TEST):
2453
2454 2017-10-19  Sam Weinig  <sam@webkit.org>
2455
2456         [Settings] Move global settings into their own file
2457         https://bugs.webkit.org/show_bug.cgi?id=178512
2458
2459         Reviewed by Darin Adler.
2460
2461         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2462         (TestWebKitAPI::TEST):
2463
2464 2017-10-19  Andy Estes  <aestes@apple.com>
2465
2466         [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
2467         https://bugs.webkit.org/show_bug.cgi?id=178181
2468         <rdar://problem/33660282>
2469
2470         Reviewed by Dan Bernstein.
2471
2472         * WebKitTestRunner/TestController.cpp:
2473         (WTR::TestController::databaseProcessName):
2474
2475 2017-10-19  Saam Barati  <sbarati@apple.com>
2476
2477         Turn poly proto back on by default and remove the option
2478         https://bugs.webkit.org/show_bug.cgi?id=178525
2479
2480         Reviewed by Mark Lam.
2481
2482         * Scripts/run-jsc-stress-tests:
2483
2484 2017-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2485
2486         Don't expose raw HTML in pasteboard to the web content
2487         https://bugs.webkit.org/show_bug.cgi?id=178422
2488
2489         Reviewed by Wenson Hsieh.
2490
2491         Added a test case for sanitizing web archive in the system pasteboard to strip privacy sensitive information
2492         such as local file paths and potentially harmful scripts like event handlers serialized by WebKit prior to r223462.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
2495         (PasteWebArchive.SanitizesHTML):
2496
2497 2017-10-18  Youenn Fablet  <youenn@apple.com>
2498
2499         TestController should clear all fetch caches when resetting its state
2500         https://bugs.webkit.org/show_bug.cgi?id=178486
2501
2502         Reviewed by Chris Dumez.
2503
2504         Adding clearDOMCaches test runner method.
2505         Using that method when resetting state.
2506
2507         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2508         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2509         (WTR::TestRunner::clearDOMCaches):
2510         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2511         * WebKitTestRunner/TestInvocation.cpp:
2512         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2513
2514 2017-10-18  Chelsea Pugh  <cpugh@apple.com>
2515
2516         [iOS] Use new class name from UIKit when checking UITextSuggestion type
2517         https://bugs.webkit.org/show_bug.cgi?id=178416
2518
2519         Reviewed by Tim Horton.
2520
2521         This updates our test using/mocking out UITextAutofillSuggestion instead of UIKeyboardLoginCredentialsSuggestion.
2522
2523         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2524         (-[UITextAutofillSuggestion initWithUsername:password:]): Copied from UIKit's implementation. This will serve as
2525         a mock of this method for builds not containingit.
2526         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Ditto.
2527         (TestWebKitAPI::TEST): Use +[UITextAutofillSuggestion autofillSuggestionWithUsername:password:] inline instead of
2528         helper function for creating a new suggestion.
2529         (newUIKeyboardLoginCredentialsSuggestion): Deleted.
2530
2531         * TestWebKitAPI/ios/UIKitSPI.h:
2532
2533 2017-10-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2534
2535         update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
2536         https://bugs.webkit.org/show_bug.cgi?id=178381
2537
2538         Reviewed by Alexey Proskuryakov.
2539
2540         The web server developer.apple.com seems to reject HTTP requests
2541         without Accept header field.
2542
2543         * Scripts/update-webkit-dependency: Add 'Accept' header field to requests.
2544
2545 2017-10-18  Aakash Jain  <aakash_jain@apple.com>
2546
2547         webkitpy tests should have --json-output option
2548         https://bugs.webkit.org/show_bug.cgi?id=178481
2549
2550         Reviewed by Alexey Proskuryakov.
2551
2552         * Scripts/webkitpy/test/main.py:
2553         (Tester._parse_args): Added json-output argument.
2554         (Tester._run_tests): Write output to json file.
2555
2556 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2557
2558         Unreviewed, rolling out r223291.
2559
2560         See WebCore ChangeLog for more detail.
2561
2562         Reverted changeset:
2563
2564         "Remove Editor::simplifyMarkup"
2565         https://bugs.webkit.org/show_bug.cgi?id=178271
2566         https://trac.webkit.org/changeset/223291
2567
2568 2017-10-18  Chris Dumez  <cdumez@apple.com>
2569
2570         Add an efficient data structure for WebCore to query if there is a Service Worker registered for a given origin
2571         https://bugs.webkit.org/show_bug.cgi?id=177876
2572         <rdar://problem/34813129>
2573
2574         Reviewed by Ryosuke Niwa.
2575
2576         Clear service worker registrations between test runs to avoid flakiness.
2577
2578         * WebKitTestRunner/TestController.cpp:
2579         (WTR::TestController::resetStateToConsistentValues):
2580
2581 2017-10-18  Zan Dobersek  <zdobersek@igalia.com>
2582
2583         Remove remnants of OpenWebRTC
2584         https://bugs.webkit.org/show_bug.cgi?id=178437
2585
2586         Reviewed by Alejandro G. Castro.
2587
2588         Drop OpenWebRTC packages from the GTK's Jhbuild modules file. Relevant
2589         patches are also removed.
2590
2591         * gtk/jhbuild.modules:
2592         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Removed.
2593         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Removed.
2594         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Removed.
2595         * gtk/patches/udpsrc-improve-timeouts.patch: Removed.
2596
2597 2017-10-17  Jonathan Bedard  <jbedard@apple.com>
2598
2599         webkitpy: Hang when workers write to the same stack trace file
2600         https://bugs.webkit.org/show_bug.cgi?id=178402
2601         <rdar://problem/35033432>
2602
2603         Reviewed by Aakash Jain.
2604
2605         Workers can hang if they all write to the same stack trace file when receiving
2606         a SIGTERM. Attach the pid to the stack trace file name so that each worker
2607         writes to a different file.
2608
2609         * Scripts/webkitpy/common/interupt_debugging.py:
2610         (log_stack_trace_on_term.handler): Name stack trace file path/<pid>-filename.
2611         (log_stack_trace_on_cntrl_c.handler): Ditto.
2612
2613 2017-10-17  John Wilander  <wilander@apple.com>
2614
2615         Add and remove cookie partition accordingly in intermediary redirect requests
2616         https://bugs.webkit.org/show_bug.cgi?id=178369
2617         <rdar://problem/34467603>
2618
2619         Reviewed by Brent Fulgham.
2620
2621         Adds the function statisticsNotifyObserver().
2622
2623         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2624         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2625         (WTR::InjectedBundle::statisticsNotifyObserver):
2626         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2627         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2628         (WTR::TestRunner::statisticsNotifyObserver):
2629         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2630
2631 2017-10-17  Youenn Fablet  <youenn@apple.com>
2632
2633         Cache API implementation should be able to compute storage size for WebKit client applications.
2634         https://bugs.webkit.org/show_bug.cgi?id=178350
2635
2636         Reviewed by Chris Dumez.
2637
2638         Adding support for a domCacheSize getter.
2639
2640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2642         (WTR::TestRunner::domCacheSize):
2643         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2644         * WebKitTestRunner/TestController.cpp:
2645         (WTR::FetchCacheSizeForOriginCallbackContext::FetchCacheSizeForOriginCallbackContext):
2646         (WTR::fetchCacheSizeForOriginCallback):
2647         (WTR::TestController::domCacheSize):
2648         * WebKitTestRunner/TestController.h:
2649         * WebKitTestRunner/TestInvocation.cpp:
2650         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2651
2652 2017-10-17  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2653
2654         [GStreamer][GTK][WPE] update-webkit-libs-jhbuild fails to detect changes in included moduleset files
2655         https://bugs.webkit.org/show_bug.cgi?id=178206
2656
2657         Reviewed by Michael Catanzaro.
2658
2659         The update-webkit-libs-jhbuild scripts computes MD5 sum of GTK/WPE jhbuild configuration files to check if it
2660         needs to rebuild the dependencies libraries. This patch fixes a bug when main GTK/WPE jhbuild modules
2661         configuration file includes additional files (for example GStreamer module). It parses jhbuild.modules file to
2662         check if additional files are included. If any, it computes MD5 sum for each of these included files.
2663
2664         * Scripts/update-webkit-libs-jhbuild:
2665         (getJhbuildIncludedFilePaths): New function that returns included files in jhbuild.modules
2666         (jhbuildConfigurationCheckFile): New function to check if MD5 sum file changes.
2667         (jhbuildConfigurationChanged): Add MD5 sum check for included files.
2668         (saveMd5File): New function to save MD5 sum of a file.
2669         (saveJhbuildMd5): Add saving included files MD5 sum.
2670         (deleteJhbuildMd5): Delete included files MD5 sum
2671         * gtk/install-dependencies: Add perl-libXML lib that is used to parse jhbuild file.
2672         * wpe/install-dependencies: Ditto.
2673
2674 2017-10-17  Tomas Popela  <tpopela@redhat.com>
2675
2676         Undefined WK_API_ENABLED warning when compiling COCOA content on WebKitGTK+
2677         https://bugs.webkit.org/show_bug.cgi?id=178208
2678
2679         Check whether we are on COCOA platform before checking for
2680         WK_API_ENABLED.
2681
2682         Reviewed by Ryosuke Niwa.
2683
2684         * WebKitTestRunner/TestController.cpp:
2685         (WTR::TestController::clearDOMCache):
2686
2687 2017-10-17  Keith Miller  <keith_miller@apple.com>
2688
2689         Change WebCore sources to work with unified source builds
2690         https://bugs.webkit.org/show_bug.cgi?id=178229
2691
2692         Rubber stamped by Tim Horton.
2693
2694         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2695
2696 2017-10-16  Christopher Reid  <chris.reid@sony.com>
2697
2698         [Win] Webkit should still be able to build when unable to check if libraries are up to date
2699         https://bugs.webkit.org/show_bug.cgi?id=178367
2700
2701         Adding a option to skip the check to see if windows libraries are up to date.
2702         This option is useful when testing modified libraries. This option also allows
2703         building webkit when GitHub blocks requests to verify the latest library version.
2704
2705
2706         Reviewed by Per Arne Vollan.
2707
2708         * Scripts/build-webkit:
2709
2710 2017-10-12  Matt Rajca  <mrajca@apple.com>
2711
2712         Add API support for quirk that lets an arbitrary click allow auto-play.
2713         https://bugs.webkit.org/show_bug.cgi?id=178227
2714
2715         Reviewed by Alex Christensen.
2716
2717         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2718         (TEST): Added API test.
2719
2720 2017-10-16  Maureen Daum  <mdaum@apple.com>
2721
2722         If an origin doesn't have databases in the Databases table we should still remove its information from disk in DatabaseTracker::deleteOrigin()
2723         https://bugs.webkit.org/show_bug.cgi?id=178281
2724         <rdar://problem/34576132>
2725
2726         Reviewed by Brent Fulgham.
2727
2728         Verify that if there is an entry in the Origins table but no entries in the Databases
2729         table that we still remove the directory for the origin, and that we remove the
2730         entry from the Origins table.
2731
2732         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2733         (TestWebKitAPI::TEST):
2734
2735 2017-10-15  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         Cannot access images included in the content pasted from Microsoft Word
2738         https://bugs.webkit.org/show_bug.cgi?id=124391
2739         <rdar://problem/26862741>
2740
2741         Reviewed by Antti Koivisto.
2742
2743         Added tests for sanitizing HTML contents for copy & paste and drag & drop.
2744
2745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2746         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm: Added.
2747         (readHTMLFromPasteboard): Added.
2748         (createWebViewWithCustomPasteboardDataEnabled): Added.
2749         (CopyHTML.Sanitizes): Added.
2750
2751         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2752         (createWebViewWithCustomPasteboardDataEnabled): Added to enable more tests on bots.
2753
2754         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2755         (writeRTFToPasteboard): Added.
2756         (createWebViewWithCustomPasteboardDataEnabled): Added.
2757         (createHelloWorldString): Added.
2758         (PasteRTF.ExposesHTMLTypeInDataTransfer): Added.
2759         (PasteRTFD.ExposesHTMLTypeInDataTransfer): Added.
2760         (PasteRTFD.ImageElementUsesBlobURLInHTML): Added.
2761
2762         * TestWebKitAPI/Tests/WebKitCocoa/copy-html.html: Added.
2763         * TestWebKitAPI/Tests/WebKitCocoa/paste-rtfd.html: Store the clipboardData contents for
2764         PasteRTF.ExposesHTMLTypeInDataTransfer and PasteRTFD.ExposesHTMLTypeInDataTransfer.
2765
2766         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2767         (DataInteractionTests.DataTransferSanitizeHTML):
2768
2769 2017-10-16  Youenn Fablet  <youenn@apple.com>
2770
2771         Activate Cache API by default
2772         https://bugs.webkit.org/show_bug.cgi?id=178186
2773
2774         Reviewed by Chris Dumez.
2775
2776         Removing explicit activation of cache api.
2777
2778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2779         (WTR::InjectedBundle::beginTesting):
2780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2781         (WTR::TestRunner::setCacheAPIEnabled): Deleted.
2782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2783
2784 2017-10-16  Ross Kirsling  <ross.kirsling@sony.com>
2785
2786         run-webkit-tests help text should mention arguments too
2787         https://bugs.webkit.org/show_bug.cgi?id=178352
2788
2789         Reviewed by Tim Horton.
2790
2791         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2792         (parse_args):
2793
2794 2017-10-16  Maureen Daum  <mdaum@apple.com>
2795
2796         If we fail to delete any database file, don't remove its information from the tracker database
2797         <rdar://problem/34576132> and https://bugs.webkit.org/show_bug.cgi?id=178251
2798
2799         Reviewed by Brady Eidson.
2800
2801         Add tests that verify we correctly delete databases and remove their information from
2802         the tracker database, even if the database doesn't exist. Verify that if we fail to
2803         delete a database, we don't remove its information from the tracker database.
2804
2805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2806         Move DatabaseTrackerTest.cpp to DatabaseTrackerTest.mm so that we can use the cocoa
2807         method for creating a temporary directory in the tests.
2808         * TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Removed.
2809         The existing test was copied to DatabaseTrackerTest.mm.
2810         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: Added.
2811         (TestWebKitAPI::TEST):
2812         (TestWebKitAPI::addToDatabasesTable):
2813         (TestWebKitAPI::removeDirectoryAndAllContents):
2814         (TestWebKitAPI::createFileAtPath):
2815
2816 2017-10-16  Ryan Haddad  <ryanhaddad@apple.com>
2817
2818         Unreviewed, rolling out r223422.
2819
2820         These tests are for a change that was rolled out in r223420
2821
2822         Reverted changeset:
2823
2824         "If we fail to delete any database file, don't remove its
2825         information from the tracker database"
2826         https://bugs.webkit.org/show_bug.cgi?id=178251
2827         https://trac.webkit.org/changeset/223422
2828
2829 2017-10-16  Maureen Daum  <mdaum@apple.com>
2830
2831         If we fail to delete any database file, don't remove its information from the tracker database
2832         <rdar://problem/34576132> and https://bugs.webkit.org/show_bug.cgi?id=178251
2833
2834         Reviewed by Brady Eidson.
2835
2836         Add tests that verify we correctly delete databases and remove their information from
2837         the tracker database, even if the database doesn't exist. Verify that if we fail to
2838         delete a database, we don't remove its information from the tracker database.
2839
2840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2841         Move DatabaseTrackerTest.cpp to DatabaseTrackerTest.mm so that we can use the cocoa
2842         method for creating a temporary directory in the tests.
2843         * TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Removed.
2844         The existing test was copied to DatabaseTrackerTest.mm.
2845         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: Added.
2846         (TestWebKitAPI::TEST):
2847         (TestWebKitAPI::addToDatabasesTable):
2848         (TestWebKitAPI::removeDirectoryAndAllContents):
2849         (TestWebKitAPI::createFileAtPath):
2850
2851 2017-10-16  David Kilzer  <ddkilzer@apple.com>
2852
2853         Add RELEASE_ASSERT_WITH_SECURITY_IMPLICATION() macro
2854         <https://webkit.org/b/178269>
2855
2856         Reviewed by Alex Christensen.
2857
2858         * Scripts/webkitpy/style/checkers/cpp.py:
2859         (check_language): Add checker to warn about using
2860         ASSERT_WITH_SECURITY_IMPLICATION().
2861         (CppChecker.categories): Add 'security/assertion' to list of
2862         enabled checkers.
2863         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2864         (CppStyleTest.test_debug_security_assertion): Add tests for
2865         new checker.
2866
2867 2017-10-16  Chris Dumez  <cdumez@apple.com>
2868
2869         Clicks on Link with download attribute causes all (other) links to trigger download when clicked
2870         https://bugs.webkit.org/show_bug.cgi?id=178267
2871         <rdar://problem/34985016>
2872
2873         Reviewed by Darin Adler.
2874
2875         Use PassThrough policy in WKTR's InjectedBundle's decidePolicyForNewWindowAction so that the
2876         request is sent to the UIProcess. This gets WKTR's closer to Safari behavior and helps
2877         reproduce the bug. Without this change, I would not be able to write a regression test for
2878         this bug that is very easily reproducible in Safari.
2879
2880         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2881         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
2882
2883 2017-10-16  Emilio Cobos Álvarez  <emilio@crisal.io>
2884
2885         Add Emilio Cobos Álvarez to the contributors list.
2886         https://bugs.webkit.org/show_bug.cgi?id=178334
2887
2888         Reviewed by Antti Koivisto.
2889
2890         * Scripts/webkitpy/common/config/contributors.json:
2891
2892 2017-10-07  Maciej Stachowiak  <mjs@apple.com>
2893
2894         Improve --help documentation and add --list-plans to show available benchmarks.
2895         https://bugs.webkit.org/show_bug.cgi?id=178059
2896
2897         Reviewed by Ryosuke Niwa.
2898
2899         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2900         (BenchmarkRunner.available_plans): New function that returns the list of available plans.
2901         (BenchmarkRunner.plan_directory): New method to centralize knowledge of where the plan files live.
2902         (BenchmarkRunner._find_plan_file): Updated to use BenchmarkRunner.plan_directory
2903
2904         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2905         
2906         (parse_args): Help cleanup: Reordered options to put more common
2907         ones at the top. Fixed wording. Added help for each
2908         option. Explained default for each option that has one.
2909
2910         New option: --list-plans which tells you the available benchmarks.
2911         
2912         Code cleanup: Removed use of dest where redundant, made variable
2913         names conforming to Python coding style.
2914         
2915         (run_benchmark_plan): Adapted for new variable names.
2916         (list_benchmark_plans): New helper for --list-plans option.
2917         (start): Account for --list-plans. Also use
2918         BechmarkRunner.available_plans and use
2919         BenchmarkRunner.plan_directory instead of duplicating
2920         code/knowledge here.
2921
2922 2017-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2923
2924         On ToT, event.dataTransfer.getData("text/uri-list") returns an empty string when dragging an image
2925         https://bugs.webkit.org/show_bug.cgi?id=178301
2926         <rdar://problem/34990050>
2927
2928         Reviewed by Darin Adler.
2929
2930         Fixes issues in DumpRenderTree's LocalPasteboard to ensure that drag-drop-href-as-url.html exposes files, and
2931         also adds a new iOS drag and drop API test.
2932
2933         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2934         (-[LocalPasteboard addTypes:owner:]):
2935         (-[LocalPasteboard setData:forType:]):
2936
2937         Fixes LocalPasteboard's implementation of changeCount to incremement when the pasteboard owner changes, rather
2938         than every time data is changed. This is consistent with NSPasteboard behavior.
2939
2940         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2941         (TestWebKitAPI::TEST):
2942
2943         Adds a new API test to verify that an image and HTTP URL written by the platform is correctly web exposed.
2944
2945 2017-10-15  Darin Adler  <darin@apple.com>
2946
2947         UTF-8 decoding produces one replacement character per byte; Encoding standard requires one replacement character per illegal sequence instead
2948         https://bugs.webkit.org/show_bug.cgi?id=178207
2949
2950         Reviewed by Sam Weinig.
2951
2952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added test.
2953         * TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Added.
2954         (TestWebKitAPI::decodeHexTestBytes): Decodes a string so we can write readable tests.
2955         (TestWebKitAPI::escapeNonPrintableASCIICharacters): Encodes a string so we can write readable tests.
2956         (TestWebKitAPI::TEST): Added some UTF-8 tests and UTF-8 invalid sequences tests.
2957         Would be smart to add more tests for other cases, exercising the fast ASCII loop for example, and
2958         other encodings.
2959
2960 2017-10-14  Adrian Perez de Castro  <aperez@igalia.com>
2961
2962         [WPE] JHBuild build directory DependenciesWPE/Build is not removed by update-webkit-libs-jhbuild
2963         https://bugs.webkit.org/show_bug.cgi?id=178212
2964
2965         Reviewed by Michael Catanzaro.
2966
2967         * Scripts/update-webkit-libs-jhbuild:
2968         (cleanJhbuild): The WPE JHBuild also uses a separate "Build" subdirectory, so do not skip
2969         cleaning it when "--wpe" is passed to the script.
2970
2971 2017-10-13  Adrian Perez de Castro  <aperez@igalia.com>
2972
2973         [WPE] Fontconfig fails build in JHBuild with “error: conflicting types for ‘FcObjectTypeHash’”
2974         https://bugs.webkit.org/show_bug.cgi?id=178283
2975
2976         Reviewed by Žan Doberšek.
2977
2978         * wpe/jhbuild.modules: Flag Fontconfig to be built inside the source directory, otherwise
2979         compilation fails. While at it, pass "--disable-docs" to cut a bit on build time.
2980
2981 2017-10-13  Youenn Fablet  <youenn@apple.com>
2982
2983         Implement listing origins for which CacheStorage is storing data
2984         https://bugs.webkit.org/show_bug.cgi?id=178236
2985
2986         Reviewed by Chris Dumez.
2987
2988         Adding hasDOMCache API for checking whether origin is storing data through Cache API.
2989
2990         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2991         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2992         (WTR::TestRunner::hasDOMCache):
2993         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2994         * WebKitTestRunner/TestController.cpp:
2995         (WTR::FetchCacheOriginsCallbackContext::FetchCacheOriginsCallbackContext):
2996         (WTR::fetchCacheOriginsCallback):
2997         (WTR::TestController::hasDOMCache):
2998         * WebKitTestRunner/TestController.h:
2999         * WebKitTestRunner/TestInvocation.cpp:
3000         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3001
3002 2017-10-13  Alex Christensen  <achristensen@webkit.org>
3003
3004         Remove Editor::simplifyMarkup
3005         https://bugs.webkit.org/show_bug.cgi?id=178271
3006
3007         Reviewed by Wenson Hsieh.
3008
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Removed.
3011
3012 2017-10-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3013
3014         [GLib] WebKitNavigationAction should tell whether it is a redirect
3015         https://bugs.webkit.org/show_bug.cgi?id=178178
3016
3017         Test that WebKitNavigationAction properly reports being a redirect.
3018
3019         Reviewed by Carlos Garcia Campos.
3020
3021         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3022         (testNavigationPolicy): test that loading /redirect leads to a redirect WebKitNavigationAction.
3023         (serverCallback): add a /redirect path to the server, which causes a redirect.
3024
3025 2017-10-13  Chris Dumez  <cdumez@apple.com>
3026
3027         Unreviewed, fix webkitpy failure after r223273
3028
3029         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3030         (TestImporterTest.test_harnesslinks_conversion):
3031
3032 2017-10-12  Chris Dumez  <cdumez@apple.com>
3033
3034         import-w3c-tests modifies test sources and sometimes causes them to fail
3035         https://bugs.webkit.org/show_bug.cgi?id=178234
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         Update import-w3c-tests to stop rewriting tests as this is causing some tests
3040         to fail unexpectedly.
3041
3042         * Scripts/webkitpy/w3c/test_importer.py:
3043         (TestImporter.import_tests):
3044
3045 2017-10-12  Youenn Fablet  <youenn@apple.com>
3046
3047         Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
3048         https://bugs.webkit.org/show_bug.cgi?id=178200
3049
3050         Reviewed by Chris Dumez.
3051
3052         Making clearDOMCache wait for removal completion to exit.
3053         This removes the risk to interact with the cache while deleting it which will end up be racy in tests.
3054
3055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3056         (WTR::TestRunner::clearDOMCache):
3057         * WebKitTestRunner/TestController.cpp:
3058         (WTR::ClearDOMCacheCallbackContext::ClearDOMCacheCallbackContext):
3059         (WTR::clearDOMCacheCallback):
3060         (WTR::TestController::clearDOMCache):
3061         * WebKitTestRunner/TestInvocation.cpp:
3062         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3063         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3064
3065 2017-10-12  John Wilander  <wilander@apple.com>
3066
3067         ResourceLoadObserver::logFrameNavigation() should use redirectResponse.url()
3068         https://bugs.webkit.org/show_bug.cgi?id=175257
3069         <rdar://problem/33359866>
3070
3071         Reviewed by Brent Fulgham.
3072
3073         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3074         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3075         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3076         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3077         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3080             Not implemented.
3081         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3082             Not implemented.
3083         * WebKitTestRunner/TestController.h:
3084         * WebKitTestRunner/TestInvocation.cpp:
3085         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3086         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3087         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3088             Implemented platform-specific.
3089         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3090             Implemented platform-specific.
3091
3092 2017-10-12  Andy Estes  <aestes@apple.com>
3093
3094         [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
3095         https://bugs.webkit.org/show_bug.cgi?id=178181
3096         <rdar://problem/33660282>
3097
3098         Reviewed by Dan Bernstein.
3099
3100         * WebKitTestRunner/TestController.cpp:
3101         (WTR::TestController::databaseProcessName):
3102
3103 2017-10-12  Myles C. Maxfield  <mmaxfield@apple.com>
3104
3105         Emit SPIR-V from WSL compiler (Part 1)
3106         https://bugs.webkit.org/show_bug.cgi?id=177998
3107
3108         Reviewed by Filip Pizlo.
3109
3110         This patch implements the first half of a SPIR-V codegen phase for WSL.
3111         This includes all the operations which aren't actually emitting the contents
3112         of functions themselves. For example, this includes things like representing
3113         WSL types with SPIR-V types, and declaring shaders' inputs and outputs. A
3114         future patch will actually emit the contents of functions.
3115
3116         There are two helper visitors here: SPIRVTypeAnalyzer which generates SPIR-V
3117         types from WSL types, and SPIRVPrimitiveVariableAnalyzer which identifies
3118         input and output variables from a shader (and assigns location values to
3119         each one).
3120
3121         This patch is currently pursuing the "logical mode" detailed in
3122         https://bugs.webkit.org/show_bug.cgi?id=176967. In this mode, each pointer and
3123         array reference operation can be statically traced to the variable or array it
3124         is operating on.
3125
3126         This has the interesting property where accessing a pointer inside an array is
3127         forbidden, because the array index may be computed at runtime, so the compiler
3128         can't know at compile time which variable the pointer operation will be
3129         accessing. However, this isn't true for structs; the program must statically
3130         state which struct member it is accessing. Therefore, pointers or array
3131         references must not transitively appear within an array, but they may appear
3132         within a struct. The same logic applies to array references; those get lowered
3133         to just two indexes in SPIR-V (a lower bound and an upper bound).
3134
3135         So, outside of an array, SPIR-V types don't need to include any pointers because
3136         any operation with the pointer doesn't need access to the runtime value of the
3137         pointer. Inside of an array, pointers are forbidden. Therefore, SPIR-V types
3138         will never include any pointers.
3139
3140         This means that, for example, WSL can represent a linked list in logical mode.
3141         However, a WSL program cannot iterate across the list, because that would require
3142         assigning to a pointer. So instead, a program using a linked list could only say
3143         something like "list.ptr->ptr->ptr->value".
3144
3145         * WebGPUShadingLanguageRI/LateChecker.js:
3146         (LateChecker.prototype._checkShaderType):
3147         * WebGPUShadingLanguageRI/SPIR-V.js:
3148         (SPIRV.OperandChecker.prototype._isStar):
3149         (SPIRV.OperandChecker.prototype.nextComparisonType):
3150         (SPIRV.OperandChecker.prototype.finalize):
3151         (SPIRV.OperandChecker):
3152         * WebGPUShadingLanguageRI/SPIRV.html:
3153         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Added.
3154         (findEntryPoints):
3155         (emitTypes.doEmitTypes):
3156         (emitTypes):
3157         (ConstantFinder.prototype.visitGenericLiteralType):
3158         (ConstantFinder):
3159         (generateSPIRV):
3160         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Added.
3161         (SPIRVTypeAnalyzer):
3162         (SPIRVTypeAnalyzer.prototype.get program):
3163         (SPIRVTypeAnalyzer.prototype.get typeMap):
3164         (SPIRVTypeAnalyzer.prototype.get currentId):
3165         (SPIRVTypeAnalyzer.prototype.get stack):
3166         (SPIRVTypeAnalyzer.prototype.visitTypeRef):
3167         (SPIRVTypeAnalyzer.prototype._encounterType):
3168         (SPIRVTypeAnalyzer.prototype.visitNullType):
3169         (SPIRVTypeAnalyzer.prototype.visitGenericLiteralType):
3170         (SPIRVTypeAnalyzer.prototype.visitNativeType):
3171         (SPIRVTypeAnalyzer.prototype.visitEnumType):
3172         (SPIRVTypeAnalyzer.prototype.visitPtrType):
3173         (SPIRVTypeAnalyzer.prototype.visitArrayRefType):
3174         (SPIRVTypeAnalyzer.prototype.visitArrayType):
3175         (SPIRVTypeAnalyzer.prototype.visitStructType):
3176         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Added.
3177         (SPIRVPrimitiveVariableAnalyzer):
3178         (SPIRVPrimitiveVariableAnalyzer.prototype.get program):
3179         (SPIRVPrimitiveVariableAnalyzer.prototype.get typeMap):
3180         (SPIRVPrimitiveVariableAnalyzer.prototype.get currentId):
3181         (SPIRVPrimitiveVariableAnalyzer.prototype.get currentLocation):
3182         (SPIRVPrimitiveVariableAnalyzer.prototype.get nameComponents):
3183         (SPIRVPrimitiveVariableAnalyzer.prototype.get result):
3184         (SPIRVPrimitiveVariableAnalyzer.prototype.visitTypeRef):
3185         (SPIRVPrimitiveVariableAnalyzer.prototype.visitNullType):
3186         (SPIRVPrimitiveVariableAnalyzer.prototype.visitGenericLiteralType):
3187         (SPIRVPrimitiveVariableAnalyzer.prototype.visitNativeType):
3188         (SPIRVPrimitiveVariableAnalyzer.prototype.visitEnumType):
3189         (SPIRVPrimitiveVariableAnalyzer.prototype.visitPtrType):
3190         (SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayRefType):
3191         (SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayType):
3192         (SPIRVPrimitiveVariableAnalyzer.prototype.visitStructType):
3193         * WebGPUShadingLanguageRI/WSL.md:
3194         * WebGPUShadingLanguageRI/index.html:
3195
3196 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
3197
3198         Enable gigacage on iOS
3199         https://bugs.webkit.org/show_bug.cgi?id=177586
3200
3201         Reviewed by JF Bastien.
3202         
3203         Add a mode to test disabling Gigacage.
3204
3205         * Scripts/run-jsc-stress-tests:
3206         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3207
3208 2017-10-11  Sam Weinig  <sam@webkit.org>
3209
3210         Remove out-parameter variants of copyToVector
3211         https://bugs.webkit.org/show_bug.cgi?id=178155
3212
3213         Reviewed by Tim Horton.
3214
3215         * DumpRenderTree/JavaScriptThreading.cpp:
3216         (stopJavaScriptThreads):
3217
3218 2017-10-12  Sam Weinig  <sam@webkit.org>
3219
3220         It should be possible to iterate just the values (and not the counts) of a HashCountedSet
3221         https://bugs.webkit.org/show_bug.cgi?id=178169
3222
3223         Reviewed by Daniel Bates.
3224
3225         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3226         (TestWebKitAPI::TEST):
3227         Add test for HashCountedSet's new values() range.
3228
3229 2017-10-11  Frederic Wang  <fwang@igalia.com>
3230
3231         run-safari --ios-simulator is no longer working with Xcode 9
3232         https://bugs.webkit.org/show_bug.cgi?id=177595
3233
3234         Reviewed by Daniel Bates.
3235
3236         In Xcode 9, the path of the simulator application is now in a new CoreSimulator subdirectory
3237         of the iphoneOS SDK platform. This patch updates webkitdirs.pm to use the new path in
3238         Xcode 9 or higher so that it is possible to run Safari on the iOS simulator again. It also
3239         does some minor code refactoring to improve code reuse.
3240
3241         * Scripts/configure-xcode-for-ios-development: Move sdkDirectory() and sdkPlatformDirectory()
3242         into webkitdirs.
3243         (sdkDirectory): Deleted.
3244         (sdkPlatformDirectory): Deleted.
3245         * Scripts/webkitdirs.pm: Expose new sdkDirectory() and sdkPlatformDirectory().
3246         (sdkDirectory): Moved from configure-xcode-for-ios-development.
3247         (sdkPlatformDirectory): Ditto.
3248         (XcodeSDKPath): Rely on sdkDirectory() to implement this function.
3249         (iosSimulatorApplicationsPath): In Xcode 9 or higher use the new path. It is calculated
3250         by relying on sdkPlatformDirectory().
3251
3252 2017-10-11  Dewei Zhu  <dewei_zhu@apple.com>
3253
3254         run-benchmark script should set '__XPC_DYLD_FRAMEWORK_PATH' while launching local-built Safari on Mac.
3255         https://bugs.webkit.org/show_bug.cgi?id=178199
3256
3257         Reviewed by Saam Barati.
3258
3259         '__XPC_DYLD_FRAMEWORK_PATH' should be set while launching Safari on run-benchmark script.
3260         'force_remove' function should support both file and directory.
3261
3262         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3263         (OSXSafariDriver.launch_url):
3264         * Scripts/webkitpy/benchmark_runner/utils.py:
3265         (force_remove):
3266
3267 2017-10-11  Saam Barati  <sbarati@apple.com>
3268
3269         Runtime disable poly proto because it may be a 3-4% Speedometer regression
3270         https://bugs.webkit.org/show_bug.cgi?id=178192
3271
3272         Reviewed by JF Bastien.
3273
3274         * Scripts/run-jsc-stress-tests:
3275
3276 2017-10-11  Youenn Fablet  <youenn@apple.com>
3277
3278         Add API to clean CacheStorage data
3279         https://bugs.webkit.org/show_bug.cgi?id=178034
3280
3281         Reviewed by Chris Dumez.
3282
3283         Adding internals API to trigger deleting all or origin-persistent cache storage persistent data. 
3284
3285         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3287         (WTR::TestRunner::clearDOMCache):
3288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3289         * WebKitTestRunner/TestController.cpp:
3290         (WTR::TestController::clearDOMCache):
3291         * WebKitTestRunner/TestController.h:
3292         * WebKitTestRunner/TestInvocation.cpp:
3293         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3294
3295 2017-10-11  Chris Dumez  <cdumez@apple.com>
3296
3297         [Geolocation] Expose Coordinates.floorLevel
3298         https://bugs.webkit.org/show_bug.cgi?id=178173
3299         <rdar://problem/34918936>
3300
3301         Reviewed by Ryosuke Niwa.
3302
3303         Add test infrastructure for testing Coordinates.floorLevel.
3304
3305         * DumpRenderTree/TestRunner.cpp:
3306         (setMockGeolocationPositionCallback):
3307         * DumpRenderTree/TestRunner.h:
3308         * DumpRenderTree/mac/TestRunnerMac.mm:
3309         (TestRunner::setMockGeolocationPosition):
3310         * DumpRenderTree/win/TestRunnerWin.cpp:
3311         (TestRunner::setMockGeolocationPosition):
3312         * WebKitTestRunner/GeolocationProviderMock.cpp:
3313         (WTR::GeolocationProviderMock::setPosition):
3314         * WebKitTestRunner/GeolocationProviderMock.h:
3315         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3316         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3317         (WTR::InjectedBundle::setMockGeolocationPosition):
3318         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3320         (WTR::TestRunner::setMockGeolocationPosition):
3321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3322         * WebKitTestRunner/TestController.cpp:
3323         (WTR::TestController::setMockGeolocationPosition):
3324         * WebKitTestRunner/TestController.h:
3325         * WebKitTestRunner/TestInvocation.cpp:
3326         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3327
3328 2017-10-11  Youenn Fablet  <youenn@apple.com>
3329
3330         Bump default cache storage quota to 20MB
3331         https://bugs.webkit.org/show_bug.cgi?id=178132
3332
3333         Reviewed by Alex Christensen.
3334
3335         * WebKitTestRunner/TestController.cpp:
3336         (WTR::TestController::generateContextConfiguration const):
3337         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3338         (WTR::initializeWebViewConfiguration): Setting quota to 400kb
3339
3340 2017-10-11  Commit Queue  <commit-queue@webkit.org>
3341
3342         Unreviewed, rolling out r223113 and r223121.
3343         https://bugs.webkit.org/show_bug.cgi?id=178182
3344
3345         Reintroduced 20% regression on Kraken (Requested by rniwa on
3346         #webkit).
3347
3348         Reverted changesets:
3349
3350         "Enable gigacage on iOS"
3351         https://bugs.webkit.org/show_bug.cgi?id=177586
3352         https://trac.webkit.org/changeset/223113
3353
3354         "Use one virtual allocation for all gigacages and their
3355         runways"
3356         https://bugs.webkit.org/show_bug.cgi?id=178050
3357         https://trac.webkit.org/changeset/223121
3358
3359 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
3360
3361         Sanitize URL in pasteboard for other applications and cross origin content
3362         https://bugs.webkit.org/show_bug.cgi?id=178060
3363         <rdar://problem/34874518>
3364
3365         Reviewed by Wenson Hsieh.
3366
3367         Added API tests for sanitizing URLs copied from web content, and that the original URL is exposed to the web content.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm: Added.
3371         (readURLFromPasteboard): A helper function.
3372         * TestWebKitAPI/Tests/WebKitCocoa/copy-url.html: Added.
3373         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3374         (DataInteractionTests.DataTransferGetDataWhenDroppingCustomData): Rebaselined. https://www.apple.com is no longer
3375         normalized to https://www.apple.com/ by NSURL / UIPasteboard as expected.
3376         (DataInteractionTests.DataTransferSetDataValidURL): Added.
3377         (DataInteractionTests.DataTransferSetDataUnescapedURL): Added.
3378         (DataInteractionTests.qDataTransferSetDataInvalidURL): Added.
3379
3380 2017-10-11  Chris Dumez  <cdumez@apple.com>
3381
3382         Modernize Geolocation code
3383         https://bugs.webkit.org/show_bug.cgi?id=178148
3384
3385         Reviewed by Ryosuke Niwa.
3386
3387         * DumpRenderTree/mac/TestRunnerMac.mm:
3388         (TestRunner::setMockGeolocationPosition):
3389
3390 2017-10-11  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3391
3392         [GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
3393         https://bugs.webkit.org/show_bug.cgi?id=176804
3394
3395         Reviewed by Michael Catanzaro.
3396
3397         Add patch to fix assert in qtdemux.
3398
3399         * gstreamer/jhbuild.modules:
3400         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added.
3401
3402 2017-10-11  Tomas Popela  <tpopela@redhat.com>
3403
3404         Use https for trac changeset and browser links
3405         https://bugs.webkit.org/show_bug.cgi?id=178167
3406
3407         Reviewed by Alexey Proskuryakov.
3408
3409         Switch the http://trac.webkit.org/changeset and
3410         http://trac.webkit.org/browser links that are printed by webkitpy to
3411         https. Also update the test expectations.
3412
3413         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3414         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3415         (CommitterValidatorTest.test_flag_permission_rejection_message):
3416         * Scripts/webkitpy/common/config/urls.py:
3417         (view_source_url):
3418         (view_revision_url):
3419         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
3420         (BugTest.test_commit_revision):
3421         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3422         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3423         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3424         (MainTest):
3425         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3426         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3427         (ChangeLogCheckerTest.test_missing_bug_number):
3428         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3429         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3430         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3431         (IRCBotTest.test_rollout):
3432         (IRCBotTest.test_revert):
3433         (IRCBotTest.test_multi_rollout):
3434         (IRCBotTest.test_rollout_with_r_in_svn_revision):
3435         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3436         (IRCBotTest.test_rollout_invalidate_reason):
3437         (test_multi_rollout_invalidate_reason):
3438         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3439         * Scripts/webkitpy/tool/commands/download_unittest.py:
3440         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3441         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3442         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3443         (SuggestNominations._count_commit):
3444         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3445         * Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
3446         (getTracUrl):
3447         (getSortedKeys):
3448         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3449         (CloseBugForLandDiffTest.test_empty_state):
3450         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3451         (CommitTest._test_check_test_expectations):
3452         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3453         (UpdateChangeLogsForRevertTest):
3454
3455 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
3456
3457         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
3458         https://bugs.webkit.org/show_bug.cgi?id=178154
3459
3460         Reviewed by Wenson Hsieh.
3461
3462         Fixed the bug that LocalPasteboard would fail to load the promise type if data is set after declaring types
3463         by delaying the call to provideDataForType until when dataForType is called.
3464
3465         Without this fix, fast/events/dropzone-002.html would start failing after enabling custom pasteboard data.
3466         With this fix, fast/events/dropzone-005.html also starts passing.
3467
3468         * DumpRenderTree/mac/DumpRenderTree.mm:
3469         (resetWebPreferencesToConsistentValues):
3470         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3471         (-[LocalPasteboard addTypes:owner:]):
3472         (-[LocalPasteboard dataForType:]):
3473         * WebKitTestRunner/TestController.cpp:
3474         (WTR::TestController::resetPreferencesToConsistentValues):
3475
3476 2017-10-10  Joanmarie Diggs  <jdiggs@igalia.com>
3477
3478         AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
3479         https://bugs.webkit.org/show_bug.cgi?id=178137
3480
3481         Reviewed by Chris Fleizach.
3482
3483         Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.
3484
3485         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3486
3487 2017-10-10  Jonathan Bedard  <jbedard@apple.com>
3488
3489         run-webkit-tests: upload test results to multiple servers
3490         https://bugs.webkit.org/show_bug.cgi?id=178012
3491         <rdar://problem/34856501>
3492
3493         Reviewed by Lucas Forschler.
3494
3495         Allowing uploading of results to multiple servers makes developing new results
3496         databases much easier, and does not complicate uploading logic.
3497
3498         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3499         (Manager.upload_results): Iterate through the list of results server hosts and
3500         send results to each one.
3501         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3502         (JSONLayoutResultsGenerator.__init__): Accept a list of test results servers.
3503         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3504         (JSONResultsGenerator.__init__): Accept a list of test results servers.
3505         (JSONResultsGenerator.get_json): Pick which server to download from by index.
3506         (JSONResultsGenerator.upload_json_files): Upload the JSON to each results server.
3507         (JSONResultsGenerator._get_archived_json_results): Pick which server to download from.
3508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3509         (parse_args): Allow multiple test-results-servers and results-server-hosts to be
3510         passed to run-webkit-tests. 
3511
3512 2017-10-09  Youenn Fablet  <youenn@apple.com>
3513
3514         Vector should be able to easily create from a list of movable only items
3515         https://bugs.webkit.org/show_bug.cgi?id=176432
3516
3517         Reviewed by Darin Adler.
3518
3519         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3520         (TestWebKitAPI::TEST):
3521
3522 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
3523
3524         Enable gigacage on iOS
3525         https://bugs.webkit.org/show_bug.cgi?id=177586
3526
3527         Reviewed by JF Bastien.
3528         
3529         Add a mode to test disabling Gigacage.
3530
3531         * Scripts/run-jsc-stress-tests:
3532         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3533
3534 2017-10-09  Commit Queue  <commit-queue@webkit.org>
3535
3536         Unreviewed, rolling out r223015 and r223025.
3537         https://bugs.webkit.org/show_bug.cgi?id=178093
3538
3539         Regressed Kraken on iOS by 20% (Requested by keith_mi_ on
3540         #webkit).
3541
3542         Reverted changesets:
3543
3544         "Enable gigacage on iOS"
3545         https://bugs.webkit.org/show_bug.cgi?id=177586
3546         http://trac.webkit.org/changeset/223015
3547
3548         "Unreviewed, disable Gigacage on ARM64 Linux"
3549         https://bugs.webkit.org/show_bug.cgi?id=177586
3550         http://trac.webkit.org/changeset/223025
3551
3552 2017-10-09  Sam Weinig  <sam@webkit.org>
3553
3554         Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector
3555         https://bugs.webkit.org/show_bug.cgi?id=178072
3556
3557         Reviewed by Darin Adler.
3558
3559         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3560         (TestWebKitAPI::TEST):
3561         
3562             Add tests for HashMap::keys() and HashMap::values() working with copyToVector.
3563
3564 2017-10-05  Frederic Wang  <fwang@igalia.com>
3565
3566         Remove WOFF2 from Source/ThirdParty.
3567         https://bugs.webkit.org/show_bug.cgi?id=177862
3568
3569         Reviewed by Michael Catanzaro.
3570
3571         * Scripts/webkitpy/style/checker.py: Remove woff2.
3572         * gtk/jhbuild.modules: Add new jhbuild module for woff2.
3573
3574 2017-10-08  Sam Weinig  <sam@webkit.org>
3575
3576         It should be possible to create a ListHashSet with a std::initializer_list.
3577         https://bugs.webkit.org/show_bug.cgi?id=178070
3578
3579         Reviewed by Darin Adler.
3580
3581         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3582         (TestWebKitAPI::TEST):
3583         Add a test for using std::initializer_list with ListHashSet.
3584
3585 2017-10-08  Sam Weinig  <sam@webkit.org>
3586
3587         There should be a version of copyToVector that returns a Vector, rather than using an out parameter
3588         https://bugs.webkit.org/show_bug.cgi?id=177732
3589
3590         Reviewed by Saam Barati.
3591
3592         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3593         (TestWebKitAPI::TEST):
3594         Add tests for the new copyToVector and copyToVectorOf functions.
3595
3596 2017-10-08  Darin Adler  <darin@apple.com>
3597
3598         Fix bugs related to setting reflected floating point DOM attributes
3599         https://bugs.webkit.org/show_bug.cgi?id=178061
3600
3601         Reviewed by Sam Weinig.
3602
3603         * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added a test of the
3604         AtomicString::number function, based on the test cases we already
3605         had for String::numberToStringECMAScript, and with some additional
3606         cases with powers of 10 that check handling of trailng zeroes.
3607
3608         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Added test cases to the
3609         existing tests of the String::numberToStringECMAScript function
3610         as above. Also added tests for String::number and for
3611         String::numberToStringFixedWidth. Also changed the tests to all use
3612         EXPECT instead of ASSERT macros since these are all non-fatal.
3613
3614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3615         (WTR::dumpFrameScrollPosition): Use StringBuilder::appendECMAScriptNumber
3616         instead of String::number.
3617
3618 2017-10-08  Dean Jackson  <dino@apple.com>
3619
3620         Make sort-Xcode-project file handle UnifiedSources
3621         https://bugs.webkit.org/show_bug.cgi?id=178042
3622
3623         Reviewed by Sam Weinig.
3624
3625         Sort the UnifiedSource(\d+) files by number rather
3626         than alphabetically.
3627
3628         * Scripts/sort-Xcode-project-file:
3629         (sortChildrenByFileName):
3630         (sortFilesByFileName):
3631
3632 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
3633
3634         Enable gigacage on iOS
3635         https://bugs.webkit.org/show_bug.cgi?id=177586
3636
3637         Reviewed by JF Bastien.
3638         
3639         Add a mode to test disabling Gigacage.
3640
3641         * Scripts/run-jsc-stress-tests:
3642         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3643
3644 2017-10-06  Aishwarya Nirmal  <anirmal@apple.com>
3645
3646         [iOS] Respect the "caret-color" CSS property when editing
3647         https://bugs.webkit.org/show_bug.cgi?id=177489
3648         <rdar://problem/34600419>
3649
3650         Reviewed by Tim Horton.
3651
3652         Adds test for iOS caret color support.
3653
3654         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3655         (TestWebKitAPI::TEST):
3656         * TestWebKitAPI/ios/UIKitSPI.h:
3657
3658 2017-10-06  Alex Christensen  <achristensen@webkit.org>
3659
3660         Add more infrastructure to apply custom header fields to same-origin requests
3661         https://bugs.webkit.org/show_bug.cgi?id=177629
3662
3663         Reviewed by Ryosuke Niwa.
3664
3665         * TestWebKitAPI/Tests/WebCore/HTTPHeaderField.cpp:
3666         (canonicalizeHTTPHeader):
3667         (shouldRemainUnchanged):
3668         (shouldBeInvalid):
3669         (shouldBecome):
3670         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3671         (TEST):
3672         (expectHeaders):
3673         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3674         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
3675         (-[CustomHeaderFieldsDelegate webView:stopURLSchemeTask:]):
3676
3677         Test main resource requests, subresource requests, and cross-origin requests.
3678
3679 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3680
3681         [iOS] Tweak support for classifying form controls (followup to r222487)
3682         https://bugs.webkit.org/show_bug.cgi?id=177917
3683         <rdar://problem/34820122>
3684
3685         Reviewed by Dean Jackson.
3686
3687         Minor cleanup around autofill API tests added in r222487. Additionally, augments some of these API tests to
3688         verify that after blurring the focused element, the content view no longer accepts autofill credentials (see
3689         WebKit ChangeLog for more details). Also augments tests to verify that the URL in the autofill context matches
3690         the document URL.
3691
3692         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3693
3694         Remove the USE(APPLE_INTERNAL_SDK) guard for these API tests.
3695
3696         (newUIKeyboardLoginCredentialsSuggestion):
3697
3698         Add a stub implementation of UIKeyboardLoginCredentialsSuggestion. This allows
3699         [UIKeyboardLoginCredentialsSuggestion new] to return a nonnull object, which allows these API tests to verify
3700         that the credential filling codepath works as intended without any additional UIKit changes. Currently, tests
3701         for the value of username and password fields are passing even though the fields are not being populated because
3702         the expected string values are null, and the observed value is an empty string. We instead check the literal
3703         string values here instead of credentialSuggestion's properties, so that tests verifying the behavior of
3704         -insertTextSuggestion: will require username and password inputs to be populated.
3705
3706         (-[TestInputDelegate _webView:focusShouldStartInputSession:]):
3707         (-[AutofillTestView initWithFrame:]):
3708         (-[AutofillTestView _autofillInputView]):
3709         (-[AutofillTestView textInputHasAutofillContext]):
3710         (TestWebKitAPI::TEST):
3711
3712         Add an additional API test to verify that programmatic focus without user interaction (and also without testing
3713         overrides) does not activate autofill.
3714
3715         (createUIKeyboardLoginCredentialsSuggestion): Deleted.
3716         (-[WKWebView _privateTextInput]): Deleted.
3717         * TestWebKitAPI/ios/UIKitSPI.h:
3718
3719         Minor gardening to remove iOS version >= 11 guards that are now unnecessary. Additionally, add some more private
3720         header imports (with corresponding interface definitions for building and running with the public SDK).
3721
3722 2017-10-06  Antti Koivisto  <antti@apple.com>
3723
3724         Minor WeakPtr improvements
3725         https://bugs.webkit.org/show_bug.cgi?id=177958
3726
3727         Reviewed by Sam Weinig.
3728
3729         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3730         (TestWebKitAPI::TEST):
3731         (TestWebKitAPI::Base::createWeakPtr): Deleted.
3732
3733 2017-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3734
3735         Unreviewed. Fix parsing of GTK unit tests output in bot configuration.
3736
3737         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3738         (RunGtkAPITests.commandComplete): Remove trailing ':' from the regular expression.
3739
3740 2017-10-06  Charles Turner  <cturner@igalia.com>
3741
3742         Disable bmalloc when running Valgrind
3743         https://bugs.webkit.org/show_bug.cgi?id=177923
3744
3745         Reviewed by Carlos Alberto Lopez Perez.
3746
3747         * Scripts/webkitpy/port/gtk.py:
3748         (GtkPort.setup_environ_for_server):
3749
3750 2017-10-06  Zan Dobersek  <zdobersek@igalia.com>
3751
3752         Implement TestController::platformContext() for WPE, returning the
3753         m_context pointer as the GTK+ port does. This fixes the crashes on
3754         the WPE testers.
3755
3756         Rubber-stamped by Carlos Garcia Campos.
3757
3758         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3759         (WTR::TestController::platformContext):
3760
3761 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3762
3763         [GTK][WPE] Add API to configure and enable resource load statistics
3764         https://bugs.webkit.org/show_bug.cgi?id=177943
3765
3766         Reviewed by Michael Catanzaro.
3767
3768         Add a command line option to enable intelligent tracking prevention to MiniBrowser and tests cases to check the
3769         new API.
3770
3771         * MiniBrowser/gtk/main.c:
3772         (main):
3773         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3774         (serverCallback):
3775         (testWebsiteDataConfiguration):
3776         (testWebsiteDataEphemeral):
3777         (testWebsiteDataResourceLoadStats):
3778         (beforeAll):
3779         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3780         (Test::Test):
3781         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3782         (directoryChangedCallback):
3783         (WebViewTest::waitUntilFileExists):
3784         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3785
3786 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3787
3788         [GTK][WPE] All resource load statistics tests added in r212183 crash in GTK bots, timeout in GTK and WPE bots since r219049
3789         https://bugs.webkit.org/show_bug.cgi?id=168171
3790
3791         Reviewed by Chris Dumez.
3792
3793         Implement all resource load statistics functions in TestController using the C API. Also enable the FileMonitor
3794         unit test. This test requires a platform implementation of Util::run(), so I've added UtilitiesGLib.cpp with an
3795         iplementation common to glib based ports using WTF RunLoop abstraction.
3796
3797         * TestWebKitAPI/PlatformGTK.cmake:
3798         * TestWebKitAPI/PlatformWPE.cmake:
3799         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3800         * TestWebKitAPI/glib/UtilitiesGLib.cpp: Copied from Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h.
3801         (TestWebKitAPI::Util::run):
3802         (TestWebKitAPI::Util::spinRunLoop):
3803         (TestWebKitAPI::Util::sleep):
3804         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3805         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
3806         * WebKitTestRunner/TestController.cpp:
3807         (WTR::TestController::platformAdjustContext):
3808         (WTR::TestController::setStatisticsLastSeen):
3809         (WTR::TestController::setStatisticsPrevalentResource):
3810         (WTR::ResourceStatisticsCallbackContext::ResourceStatisticsCallbackContext):
3811         (WTR::resourceStatisticsCallback):
3812         (WTR::TestController::isStatisticsPrevalentResource):
3813         (WTR::TestController::setStatisticsHasHadUserInteraction):
3814         (WTR::TestController::isStatisticsHasHadUserInteraction):
3815         (WTR::TestController::setStatisticsGrandfathered):
3816         (WTR::TestController::isStatisticsGrandfathered):
3817         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
3818         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
3819         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
3820         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3821         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
3822         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3823         (WTR::TestController::statisticsUpdateCookiePartitioning):
3824         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3825         (WTR::TestController::statisticsSubmitTelemetry):
3826         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3827         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3828         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3829         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3830         (WTR::TestController::setStatisticsGrandfatheringTime):
3831         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3832         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3833         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3834         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3835         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
3836         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
3837         (WTR::TestController::statisticsResetToConsistentState):
3838         * WebKitTestRunner/TestController.h:
3839
3840 2017-10-05  Jer Noble  <jer.noble@apple.com>
3841
3842         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
3843         https://bugs.webkit.org/show_bug.cgi?id=177261
3844
3845         Reviewed by Eric Carlson.
3846
3847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3848
3849 2017-10-05  Alex Christensen  <achristensen@webkit.org>
3850
3851         Add ObjC equivalent of WKPageNavigationClient.didChangeBackForwardList
3852         https://bugs.webkit.org/show_bug.cgi?id=177966
3853         <rdar://problem/22387135>
3854
3855         Reviewed by Tim Horton.
3856
3857         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3858         (-[ListItemDelegate _webView:backForwardListItemAdded:removed:]):
3859         (-[ListItemDelegate webView:didFinishNavigation:]):
3860         (TEST):
3861
3862 2017-10-04  Megan Gardner  <megan_gardner@apple.com>
3863
3864         check-webkit-style erroneously requires a space between the carrot and brace in obj-c blocks.
3865         https://bugs.webkit.org/show_bug.cgi?id=177897
3866
3867         Reviewed by Dan Bernstein and Jonathan Bedard.
3868
3869         Remove the check for a space between ^ and {, 
3870         as this is valid and expected Obj-C. Now check to make sure there is
3871         no space at all between ^ and {, and also that there is a space between
3872         the end of an argument list and the {.
3873
3874         * Scripts/webkitpy/style/checkers/cpp.py:
3875         (regex_for_lambdas_and_blocks):
3876
3877 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3878
3879         Unreviewed. Run WebKit2 C API tests in GTK+ bots again after the last WebKit2 -> WebKit rename.
3880
3881         * Scripts/run-gtk-tests:
3882         (TestRunner):
3883         (TestRunner._run_test):
3884
3885 2017-10-05  Darin Adler  <darin@apple.com>
3886
3887         Remove additional WebKitSystemInterface remnants
3888         https://bugs.webkit.org/show_bug.cgi?id=177948
3889
3890         Reviewed by Andy Estes.
3891
3892         * DumpRenderTree/PlatformMac.cmake: Removed code to link the
3893         WebKitSystemInterface library. Left in code that points to
3894         the WebKitLibraries directory, but maybe that can be removed by
3895         someone who is more certain it's no longer needed.
3896
3897         * Scripts/copy-webkitlibraries-to-product-directory: Removed code
3898         to copy and delete WebKitSystemInterface libraries and headers.
3899
3900         * WebKitTestRunner/PlatformMac.cmake: Removed code to link the
3901         WebKitSystemInterface library. Left in code that points to
3902         the WebKitLibraries directory, but maybe that can be removed by
3903         someone who is more certain it's no longer needed.
3904
3905 2017-10-05  Saam Barati  <sbarati@apple.com>
3906
3907         Unreviewed. Try to make debug type profiler tests stop timing out.
3908
3909         * Scripts/run-jsc-stress-tests:
3910
3911 2017-10-03  Frederic Wang  <fwang@igalia.com>
3912
3913         Remove Brotli from Source/ThirdParty
3914         https://bugs.webkit.org/show_bug.cgi?id=177804
3915
3916         Reviewed by Michael Catanzaro.
3917
3918         * gtk/jhbuild.modules: Build brotli 1.0.1 from the official github repository.
3919         * Scripts/webkitpy/style/checker.py: Remove brotli.
3920
3921 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3922
3923         Stop linking with WebKitSystemInterface
3924         https://bugs.webkit.org/show_bug.cgi?id=177915
3925
3926         Reviewed by Antti Koivisto.
3927
3928         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3929         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3930         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3931         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3932         * WebKitTestRunner/Configurations/Base.xcconfig:
3933         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3934         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3935         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3936         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3937
3938 2017-10-04  Alex Christensen  <achristensen@webkit.org>
3939
3940         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
3941         https://bugs.webkit.org/show_bug.cgi?id=177912
3942
3943         Reviewed by Saam Barati.
3944
3945         * DumpRenderTree/mac/DumpRenderTree.mm:
3946
3947 2017-10-04  Megan Gardner  <megan_gardner@apple.com>
3948
3949         Break out new touch debugging code into seperate file
3950         https://bugs.webkit.org/show_bug.cgi?id=177796
3951
3952         Reviewed by Simon Fraser.
3953
3954         Encapsulate the new debug touch code into it's own file.
3955         This allows for cleaner code and a better way to show the touches
3956         in a completely separate window, which should also be in screen
3957         coordinates, and not subject to any transforms that get put on the
3958         WebViews.
3959
3960         * TestRunnerShared/spi/UIKitTestSPI.h:
3961         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3962         * WebKitTestRunner/ios/HIDDebugTouchWindow.h: Added.
3963         * WebKitTestRunner/ios/HIDDebugTouchWindow.mm: Added.
3964         (+[HIDDebugTouchWindow sharedHIDDebugTouchWindow]):
3965         (-[HIDDebugTouchWindow init]):
3966         (-[HIDDebugTouchWindow dealloc]):
3967         (-[HIDDebugTouchWindow updateDebugIndicatorForTouch:withPointInWindowCoordinates:isTouching:]):
3968         (-[HIDDebugTouchWindow initDebugViewsIfNeeded]):
3969         * WebKitTestRunner/ios/HIDEventGenerator.h:
3970         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3971         (-[HIDEventGenerator init]):
3972         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3973         (-[HIDEventGenerator _createIOHIDEventType:]):
3974         (-[HIDEventGenerator _updateTouchPoints:count:]):
3975         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
3976         (-[HIDEventGenerator touchDown:touchCount:]):
3977         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
3978         (-[HIDEventGenerator liftUp:touchCount:]):
3979         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3980         (-[HIDEventGenerator initDebugViewsIfNeeded]): Deleted.
3981         (-[HIDEventGenerator updateDebugIndicatorForTouch:withPoint:isTouching:]): Deleted.
3982         * WebKitTestRunner/ios/TestControllerIOS.mm:
3983         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
3984
3985 2017-10-04  JF Bastien  <jfbastien@apple.com>
3986
3987         WTF: Update std::expected to match current proposal
3988         https://bugs.webkit.org/show_bug.cgi?id=177881
3989
3990         Reviewed by Mark Lam.
3991
3992         The proposal is likely to be in C++20 and I've been asked to help co-champion
3993         it. I'm therefore updating our implementation to more closely match the current
3994         proposal, and to make sure it'll work for us if standardized.
3995
3996          - Rename UnexpectedType to Unexpected to match the proposal.
3997          - Remove relational operators, only equality / inequality remains.
3998          - Fix minor type signatures.
3999          - Add UnexpectedType typedef.
4000          - Uncomment rebind implementation.
4001          - Add in-place construction tag, as well as explicit error construction tag.
4002          - Add template unexpected constructor.
4003          - Note that make_unexpected isn't in the proposal anymore, but we keep it because we don't have C++17 deduction guides.
4004          - Remove hashing, which isn't in the proposal anymore.
4005
4006         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4007         (WTF::operator<<):
4008         (TestWebKitAPI::TEST):
4009
4010 2017-10-04  Lucas Forschler  <lforschler@apple.com>
4011
4012         https://bugs.webkit.org/show_bug.cgi?id=177888
4013         WebKitArchiveSupport - add API Gateway to source control
4014         This is a swagger configuration export via AWS API Gateway console.
4015
4016         Rubber-stamped by Alexey Proskuryakov.
4017
4018         * WebKitArchiveSupport/AWS-APIGateway: Added.
4019         * WebKitArchiveSupport/AWS-APIGateway/stage-v2.json: Added.
4020
4021 2017-10-04  Mark Lam  <mark.lam@apple.com>
4022
4023         Add support for using Probe DFG OSR Exit behind a runtime flag.
4024         https://bugs.webkit.org/show_bug.cgi?id=177844
4025         <rdar://problem/34801425>
4026
4027         Reviewed by Saam Barati.
4028
4029         Enable --useProbeOSrExit=true for dfg-eager and ftl-no-cjit-validate-sampling-profiler
4030         test configurations.
4031
4032         * Scripts/run-jsc-stress-tests:
4033
4034 2017-10-04  Jonathan Bedard  <jbedard@apple.com>
4035
4036         webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is flakey
4037         https://bugs.webkit.org/show_bug.cgi?id=177751
4038         <rdar://problem/34769470>
4039
4040         Reviewed by Daniel Bates.
4041
4042         Port._build_path() calls Tools/Scripts/webkit-build-directory and caches this
4043         result. When capturing output from the MockExecutive, the first invocation of
4044         Port._build_path() will log the running of Tools/Scripts/webkit-build-directory
4045         but subsequent invocations will not.
4046
4047         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4048         (StepsTest):
4049         (StepsTest.setUp): Cache the build path before running tests.
4050
4051 2017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4052
4053         [JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
4054         https://bugs.webkit.org/show_bug.cgi?id=177865
4055
4056         Reviewed by Michael Catanzaro.
4057
4058         Build freetype6 without harfbuzz support.
4059         This seems to be what distros like Fedora, Debian or OpenEmbedded do.
4060         Also explicitly enable support for freetype and fontconfig on harfbuzz.
4061
4062         * gtk/jhbuild.modules: Enable also support for icu.
4063         * wpe/jhbuild.modules:
4064
4065 2017-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4066
4067         [Test262] Update Test262 to Oct 4 version
4068         https://bugs.webkit.org/show_bug.cgi?id=177859
4069
4070         Reviewed by Sam Weinig.
4071
4072         * Scripts/import-test262-tests:
4073
4074 2017-10-04  Ryosuke Niwa  <rniwa@webkit.org>
4075
4076         Use blob URL when pasting RTFD instead of overriding DocumentLoader
4077         https://bugs.webkit.org/show_bug.cgi?id=177801
4078         <rdar://problem/34542270>
4079
4080         Reviewed by Wenson Hsieh.
4081
4082         Added a regression test for an assertion failure when pasting an empty RTFD as well as a test for pasting
4083         RTFD with an image, which should result in an image element with a blob URL.
4084
4085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4086         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4087         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
4088         * TestWebKitAPI/Tests/WebKitCocoa/paste-rtfd.html:
4089
4090 2017-10-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4091
4092         [GLib] Let WebCore know of low power situations
4093         https://bugs.webkit.org/show_bug.cgi?id=177810
4094
4095         Reviewed by Carlos Garcia Campos.
4096
4097         * gtk/install-dependencies: add upower-glib dev packages for Debian, Arch and Fedora.
4098
4099 2017-10-03  Saam Barati  <sbarati@apple.com>
4100
4101         Implement polymorphic prototypes
4102         https://bugs.webkit.org/show_bug.cgi?id=176391
4103
4104         Reviewed by Filip Pizlo.
4105
4106         * Scripts/run-jsc-stress-tests:
4107
4108 2017-10-03  Myles C. Maxfield  <mmaxfield@apple.com> 
4109
4110         Create a SPIR-V assembler 
4111         https://bugs.webkit.org/show_bug.cgi?id=177726 
4112
4113         Reviewed by Filip Pizlo. 
4114
4115         Khronos has released a json file containing every SPIR-V opcode and operand at 
4116         https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/1.2/spirv.core.grammar.json 
4117         This patch creates a function which loads this file (via the fetch API), parses it, and creates
4118         an object which holds two things: 
4119         - For each opcode, a class which accepts the appropriate operands 
4120         - For each enum type, an object which holds each enum value 
4121         The constructor for each opcode is smart enough to do some basic type-checking of the argument, 
4122         according to the types listed in Khronos's json file. 
4123
4124         This patch also includes an example .html file which outputs a dummy SPIR-V program, 
4125         which happens to be compatible with the SPIR-V demo at 
4126         https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/demos/cube.cpp 
4127         If you modify this demo to use the generated SPIR-V program, you can see the result in 
4128         action.
4129
4130         This patch also commits a copy of Khronos's json file mentioned above. This isn't the first 
4131         Khronos file we've committed into our repository with this license, so there shouldn't be any 
4132         problems there. 
4133
4134         * WebGPUShadingLanguageRI/SPIR-V.js: Added. 
4135         (SPIRV.): 
4136         (SPIRVAssembler): 
4137         (SPIRVAssembler.prototype.append): 
4138         (SPIRVAssembler.prototype.get size): 
4139         (SPIRVAssembler.prototype.get storage): 
4140         (SPIRVAssembler.prototype.get result): 
4141         * WebGPUShadingLanguageRI/SPIRV.html: Added. 
4142         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Added. 
4143
4144 2017-10-03  Chris Dumez  <cdumez@apple.com>
4145
4146         SharedStringHashStore should support removing hashes
4147         https://bugs.webkit.org/show_bug.cgi?id=177770
4148
4149         Reviewed by Alex Christensen.
4150
4151         Add API test coverage.
4152
4153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4154         * TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm: Added.
4155         (TestWebKitAPI::TEST):
4156
4157 2017-10-03  Dewei Zhu  <dewei_zhu@apple.com>
4158
4159         Fix missing import for BenchmarkRunner.
4160         https://bugs.webkit.org/show_bug.cgi?id=177842
4161
4162         Reviewed by Ryosuke Niwa.
4163
4164         'show_results' requires BenchmarkRunner.
4165
4166         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4167
4168 2017-10-03  Olivier Blin  <olivier.blin@softathome.com>
4169
4170         [WPE] Bump deps to add support for xdg-shell-unstable-v6 protocol
4171         https://bugs.webkit.org/show_bug.cgi?id=177820
4172
4173         Reviewed by Žan Doberšek.
4174
4175         gnome-shell does not advertize the xdg-shell protocol anymore, but xdg-shell-unstable-v6 instead.
4176         Support has been added in WPEBackend-mesa, we need to update the requirements.
4177         wayland-1.10 is needed for wl_proxy_get_version(), used in the generated headers.
4178
4179         * wpe/jhbuild.modules:
4180
4181 2017-10-03  Alex Christensen  <achristensen@webkit.org>
4182
4183         Add ObjC SPI equivalent to WKPageLoaderClient.willGoToBackForwardListItem
4184         https://bugs.webkit.org/show_bug.cgi?id=177825
4185         <rdar://problem/22387505>
4186
4187         Reviewed by Tim Horton.
4188
4189         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
4190         (-[BackForwardDelegate _webView:willGoToBackForwardListItem:inPageCache:]):
4191         (-[BackForwardDelegate webView:didFinishNavigation:]):
4192         (TEST):
4193
4194 2017-10-03  Antti Koivisto  <antti@apple.com>
4195
4196         Allow assigning WeakPtr<Derived> to WeakPtr<Base>
4197         https://bugs.webkit.org/show_bug.cgi?id=177817
4198
4199         Reviewed by Geoff Garen.
4200
4201         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4202         (TestWebKitAPI::Base::weakPtrFactory):
4203         (TestWebKitAPI::TEST):
4204
4205 2017-10-03  Youenn Fablet  <youenn@apple.com>
4206
4207         Remove no longer needed WebRTC build infrastructure
4208         https://bugs.webkit.org/show_bug.cgi?id=177756
4209
4210         Reviewed by Alejandro G. Castro.
4211
4212         * Scripts/generate-libwebrtc-cmake: Removed.
4213         * Scripts/webkitpy/libwebrtc/__init__.py: Removed.
4214         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Removed.
4215
4216 2017-10-03  Joanmarie Diggs  <jdiggs@igalia.com>
4217
4218         AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes
4219         https://bugs.webkit.org/show_bug.cgi?id=177763
4220
4221         Reviewed by Chris Fleizach.
4222
4223         Implement ariaIsGrabbed() and ariaDropEffects() for ATK.
4224
4225         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4226         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
4227         (WTR::AccessibilityUIElement::ariaDropEffects const):
4228
4229 2017-10-02  Myles C. Maxfield  <mmaxfield@apple.com>
4230
4231         Make WSL demo compatible with Microsoft Edge
4232         https://bugs.webkit.org/show_bug.cgi?id=177643
4233
4234         Reviewed by Saam Barati.
4235
4236         This patch does two things. The first is it migrates a loop over ParentNode.children to a legacy style loop
4237         because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
4238         the compilation behind a setTimeout(0) so there is some indication that something is happening during a
4239         compile.
4240
4241
4242         * Tools/WebGPUShadingLanguageRI/index.html:
4243
4244 2017-10-02  Joanmarie Diggs  <jdiggs@igalia.com>
4245
4246         AX: [ATK] The value of aria-level is not exposed on non-heading roles
4247         https://bugs.webkit.org/show_bug.cgi?id=177775
4248
4249         Reviewed by Chris Fleizach.
4250
4251         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4252         (WTR::AccessibilityUIElement::hierarchicalLevel const):
4253
4254 2017-10-02  Geoffrey Garen  <ggaren@apple.com>
4255
4256         WeakPtr should have a move constructor
4257         https://bugs.webkit.org/show_bug.cgi?id=177789
4258
4259         Reviewed by Chris Dumez.
4260
4261         Chris made me write an API test. It wasn't that painful.
4262
4263         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: