[GLib] Returning G_TYPE_OBJECT from a constructor does not work
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4         https://bugs.webkit.org/show_bug.cgi?id=195206
5
6         Reviewed by Žan Doberšek.
7
8         Add a new test case.
9
10         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
11         (testJSCClass):
12
13 2019-03-04  Charlie Turner  <cturner@igalia.com>
14
15         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
16         https://bugs.webkit.org/show_bug.cgi?id=194898
17
18         Reviewed by Žan Doberšek.
19
20         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
21         a GCC extension that permits arithmetic on void* pointer. Inline
22         the macro until this issue is fixed upstream.
23
24 2019-03-03  Tim Horton  <timothy_horton@apple.com>
25
26         Rid the world of WK_API_ENABLED
27         https://bugs.webkit.org/show_bug.cgi?id=195263
28
29         Reviewed by Dan Bernstein.
30
31         List of changed files elided because it's useless.
32
33 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
34
35         Unreviewed follow-up to r242292.
36
37         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
38
39         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
40         (TestWebKitAPI::testStrip): Renamed from strip.
41         (TestWebKitAPI::TEST):
42
43 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
44
45         Unreviewed, remove accidentally-committed URLHelpers.cpp test
46
47         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
48         and bug #194272 for details.
49
50         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
51
52 2019-03-03  Tim Horton  <timothy_horton@apple.com>
53
54         Remove some more unused 32-bit code
55         https://bugs.webkit.org/show_bug.cgi?id=195255
56
57         Reviewed by Darin Adler.
58
59         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
61         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
62         (NPP_New):
63         (NPP_HandleEvent):
64         (handleEventCarbon): Deleted.
65
66 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
67
68         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
69
70         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
71         (TestWebKitAPI::TEST):
72
73 2019-03-01  Darin Adler  <darin@apple.com>
74
75         Finish removing String::format
76         https://bugs.webkit.org/show_bug.cgi?id=194893
77
78         Reviewed by Daniel Bates.
79 '
80         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
81
82 2019-03-01  Alex Christensen  <achristensen@webkit.org>
83
84         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
85         https://bugs.webkit.org/show_bug.cgi?id=195229
86         <rdar://problem/48520362>
87
88         Reviewed by Chris Dumez.
89
90         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
91         (TEST):
92
93 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
94
95         Add a system trace scope for event region building
96         https://bugs.webkit.org/show_bug.cgi?id=195226
97
98         Reviewed by Jon Lee.
99
100         This trace scope measures the time spend converting element rects into Region objects,
101         which can be large on some pages.
102
103         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
104
105         * Tracing/SystemTracePoints.plist:
106
107 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
108
109         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
110         https://bugs.webkit.org/show_bug.cgi?id=194612
111
112         Reviewed by Alex Christensen.
113
114         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
115         Just test the new string-processing function and don't touch the actual environment.
116         (Test cases are all as before, but based on operator== instead of strcmp.)
117
118 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
119
120         [ews-app] Update primary keys for handling multiple Buildbot instances
121         https://bugs.webkit.org/show_bug.cgi?id=195120
122
123         Reviewed by Stephanie Lewis.
124
125         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
126         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
127         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
128
129         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
130         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
131         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
132         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
133         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
134         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
135
136 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
137
138         [WinCairo] Enable service worker
139         https://bugs.webkit.org/show_bug.cgi?id=188318
140
141         Reviewed by Youenn Fablet.
142
143         * DumpRenderTree/DumpRenderTreePrefix.h:
144         * TestWebKitAPI/PlatformWin.cmake:
145         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
146         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
147         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
148
149 2019-03-01  Justin Fan  <justin_fan@apple.com>
150
151         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
152         https://bugs.webkit.org/show_bug.cgi?id=195191
153
154         Rubber-stamped by Dean Jackson.
155
156         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
157
158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
159
160 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
161
162         Unreviewed, fix lldb webkitpy tests
163         https://bugs.webkit.org/show_bug.cgi?id=194375
164
165         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
166
167         * lldb/lldb_webkit.py:
168         (WTFStringImplProvider.is_8bit):
169
170 2019-02-28  David Quesada  <david_quesada@apple.com>
171
172         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
173         https://bugs.webkit.org/show_bug.cgi?id=195121
174         rdar://problem/48450302
175
176         Reviewed by Alex Christensen.
177
178         Add API tests for -WKNavigationAction._shouldPerformDownload in various
179         configurations where the 'download' attribute is absent, blank, or populated
180         with a filename, and where the anchor element is same-origin or cross-origin
181         (meaning the 'download' attribute shouldn't be honored).
182
183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
184         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
185         (-[NavigationActionTestDelegate init]):
186         (-[NavigationActionTestDelegate navigationAction]):
187         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
188         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
189         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
190         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
191         (TEST):
192
193 2019-02-28  Antoine Quint  <graouts@apple.com>
194
195         Enable the Pointer Events runtime flag by default
196         https://bugs.webkit.org/show_bug.cgi?id=195156
197
198         Reviewed by Dean Jackson.
199
200         * DumpRenderTree/mac/DumpRenderTree.mm:
201         (enableExperimentalFeatures):
202
203 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
204
205         Several PasteImage API tests are flaky
206         https://bugs.webkit.org/show_bug.cgi?id=195160
207
208         Reviewed by Tim Horton.
209
210         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
211         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
212         listening for a "load" event after image load is already complete.
213
214         To address this, make these tests first register a "load" event handler, then run script to insert an image
215         element into the document, and finally wait until the load event is observed before checking image size.
216
217         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
218
219 2019-02-28  Chris Dumez  <cdumez@apple.com>
220
221         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
222         https://bugs.webkit.org/show_bug.cgi?id=195107
223
224         Reviewed by Alex Christensen.
225
226         Give some time for the zoom level to get restored.
227
228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
229
230 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
231
232         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
233         https://bugs.webkit.org/show_bug.cgi?id=194958
234
235         Reviewed by Geoffrey Garen.
236
237         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
238         (TEST):
239
240 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews-app] Update method to save build to handle builder_display_name
243         https://bugs.webkit.org/show_bug.cgi?id=195047
244
245         Reviewed by Dewei Zhu.
246
247         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
248         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
249
250 2019-02-28  Justin Fan  <justin_fan@apple.com>
251
252         [Web GPU] Enable Web GPU only on 64-bit
253         https://bugs.webkit.org/show_bug.cgi?id=195139
254
255         Because Metal is only supported on 64 bit apps.
256
257         Unreviewed build fix.
258
259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
260
261 2019-02-27  Youenn Fablet  <youenn@apple.com>
262
263         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
264         https://bugs.webkit.org/show_bug.cgi?id=194959
265
266         Reviewed by Chris Dumez.
267
268         Spin loop until getting the condition to remove flakiness.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
271
272 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
273
274         [ews-build] Buildbot should include builder_display_name in the build events
275         https://bugs.webkit.org/show_bug.cgi?id=195045
276
277         Reviewed by Dewei Zhu.
278
279         * BuildSlaveSupport/ews-build/events.py:
280         (Events.buildStarted): Included builder_display_name in event data. Also renamed
281         buildername to builder_name to be consistent in naming style.
282         (Events.buildFinished): Ditto.
283
284 2019-02-27  Chris Dumez  <cdumez@apple.com>
285
286         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
287         https://bugs.webkit.org/show_bug.cgi?id=194480
288
289         Reviewed by Brady Eidson.
290
291         Update existing API test to make it more likely to reproduce the issue.
292
293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
294
295 2019-02-27  Brady Eidson  <beidson@apple.com>
296
297         Universal links from Google search results pages don't open the app.
298         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
299
300         Reviewed by Geoffrey Garen.
301
302         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
303         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
304         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
305         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
306
307 2019-02-27  Chris Dumez  <cdumez@apple.com>
308
309         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
310         https://bugs.webkit.org/show_bug.cgi?id=195102
311
312         Reviewed by Geoffrey Garen.
313
314         If the number of processes is not yet what we expect, wait a bit and check again to give
315         processes some time to exit.
316
317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
318
319 2019-02-27  Chris Dumez  <cdumez@apple.com>
320
321         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
322         https://bugs.webkit.org/show_bug.cgi?id=194545
323
324         Reviewed by Brady Eidson.
325
326         Make sure the test navigates forward and then back only once. Previously, navigating
327         back would trigger a navigation again in a timer.
328
329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
330
331 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
332
333         High Sierra Debug JSC test queue should use faster hardware
334         https://bugs.webkit.org/show_bug.cgi?id=194603
335
336         Rubber-stamped by Alexey Proskuryakov.
337
338         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
339
340         * BuildSlaveSupport/build.webkit.org-config/config.json:
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
342         (BubbleQueueServer):
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
344         (WebKitBuildbot):
345         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
346         * QueueStatusServer/config/queues.py:
347         * Scripts/webkitpy/common/config/ews.json:
348         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
349         (test_ews_name):
350
351 2019-02-27  John Wilander  <wilander@apple.com>
352
353         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
354         https://bugs.webkit.org/show_bug.cgi?id=195071
355         <rdar://problem/48417690>
356
357         Reviewed by Alex Christensen and Brent Fulgham.
358
359         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
360         (TestWebKitAPI::createURL):
361             Convenience function.
362         (TestWebKitAPI::TEST):
363             WebCore::AdClickAttribution now takes a URL when creating Source and
364             Destination.
365         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
366         (TestWebKitAPI::TEST):
367             WebCore::AdClickAttribution now takes a URL when creating Source and
368             Destination.
369
370 2019-02-27  Antoine Quint  <graouts@apple.com>
371
372         Support Pointer Events on macOS
373         https://bugs.webkit.org/show_bug.cgi?id=195008
374         <rdar://problem/47454419>
375
376         Reviewed by Dean Jackson.
377
378         * DumpRenderTree/mac/DumpRenderTree.mm:
379         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
381
382 2019-02-26  Mark Lam  <mark.lam@apple.com>
383
384         Remove remaining poisoning code.
385         https://bugs.webkit.org/show_bug.cgi?id=194138
386
387         Reviewed by Saam Barati.
388
389         * TestWebKitAPI/CMakeLists.txt:
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
392         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
393         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
394         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
395         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
396         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
397
398 2019-02-26  Alex Christensen  <achristensen@webkit.org>
399
400         Move ephemeral local storage from WebProcess to UIProcess
401         https://bugs.webkit.org/show_bug.cgi?id=195074
402         <rdar://problem/47937975>
403
404         Reviewed by Geoff Garen.
405
406         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
407
408 2019-02-20  Jer Noble  <jer.noble@apple.com>
409
410         [Cocoa] Media elements will restart network buffering just before suspending
411         https://bugs.webkit.org/show_bug.cgi?id=193691
412
413         Reviewed by Eric Carlson.
414
415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
417         (TEST):
418
419 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
420
421         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
422         https://bugs.webkit.org/show_bug.cgi?id=191652
423
424         Reviewed by Alex Christensen.
425
426         Fix WinCairo MiniBrowser behavior of authentication dialog.
427
428         * MiniBrowser/win/WebKitBrowserWindow.cpp:
429         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
430
431 2019-02-26  Youenn Fablet  <youenn@apple.com>
432
433         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
434         https://bugs.webkit.org/show_bug.cgi?id=195028
435         <rdar://problem/48243733>
436
437         Reviewed by Eric Carlson.
438
439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
440
441 2019-02-26  Philippe Normand  <pnormand@igalia.com>
442
443         [WPE] Add API for webview background color configuration
444         https://bugs.webkit.org/show_bug.cgi?id=192305
445
446         Reviewed by Michael Catanzaro.
447
448         * MiniBrowser/wpe/main.cpp:
449         (main): Add a new option to configure the webview background
450         color. Example: --bg-color=transparent.
451         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
452         (testWebViewBackgroundColor): Enable background color API tests for WPE.
453         (beforeAll): Ditto.
454
455 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
456
457         scalableNativeWebpageParameters() is not preserved on new page navigation.
458         https://bugs.webkit.org/show_bug.cgi?id=194892
459         <rdar://problem/47538280>
460
461         Reviewed by Wenson Hsieh.
462         
463         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
464
465         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
466         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
467         * DumpRenderTree/mac/UIScriptControllerMac.mm:
468         (WTR::UIScriptController::allowsViewportShrinkToFit):
469         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
470         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
471         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
472         * TestRunnerShared/UIScriptContext/UIScriptController.h:
473         * WebKitTestRunner/UIScriptControllerCocoa.mm:
474         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
475
476 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
477
478         [ews-app] Add model for handling multiple Buildbot instances
479         https://bugs.webkit.org/show_bug.cgi?id=194863
480
481         Reviewed by Stephanie Lewis.
482
483         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
484
485 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-app] Remove BuilderMapping table
488         https://bugs.webkit.org/show_bug.cgi?id=194961
489
490         Reviewed by Stephanie Lewis.
491
492         Store builder name directly in build table, instead of having a separate
493         table for it.
494
495         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
496         * BuildSlaveSupport/ews-app/ews/models/build.py:
497         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
498         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
499
500 2019-02-25  John Wilander  <wilander@apple.com>
501
502         Introduce and adopt new class RegistrableDomain for eTLD+1
503         https://bugs.webkit.org/show_bug.cgi?id=194791
504         <rdar://problem/48179240>
505
506         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
507
508         This patch adds an API test and replaces two instances of
509         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
510
511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
512         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
513         (TestWebKitAPI::TEST):
514             Changed two strings to make sure the registrable domains are still considered
515             invalid and pass the test.
516         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
517         (TestWebKitAPI::TEST):
518         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
519         (WTR::InjectedBundle::didReceiveMessageToPage):
520
521 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
522
523         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
524         https://bugs.webkit.org/show_bug.cgi?id=195001
525
526         Reviewed by Carlos Garcia Campos.
527
528         API version 1.0 always includes the functionality previously guarded with
529         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
530         unconditionally.
531
532         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
533         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
534         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
535         (WebViewTest::showInWindow): Ditto.
536         (WebViewTest::hideView): Ditto.
537         * wpe/backends/HeadlessViewBackend.cpp:
538         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
539         * wpe/backends/ViewBackend.cpp:
540         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
541         * wpe/backends/WindowViewBackend.cpp:
542         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
543         WPE_BACKEND_CHECK_VERSION().
544         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
545
546 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
547
548         [Flatpak] Add support for flatpak > 1.1.2
549         https://bugs.webkit.org/show_bug.cgi?id=194088
550
551         Flatpak 1.2 is now out so we need to support that
552         version now.
553
554         Reviewed by Michael Catanzaro.
555
556         * flatpak/flatpakutils.py:
557         (check_flatpak):
558         (FlatpakPackages.__init__):
559         (FlatpakPackages.__detect_packages):
560         (FlatpakPackages.__detect_packages.in):
561         (FlatpakRepos.update):
562
563 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
564
565         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
566         https://bugs.webkit.org/show_bug.cgi?id=194998
567
568         Reviewed by Carlos Garcia Campos.
569
570         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
571         to a Git checkout and using the latest commit containing various fixes
572         and improvements.
573
574 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
575
576         [WPE][GTK] Remove user agent quirk for washingtonpost.com
577         https://bugs.webkit.org/show_bug.cgi?id=194981
578
579         Reviewed by Žan Doberšek.
580
581         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
582         (TestWebKitAPI::TEST):
583
584 2019-02-23  Keith Miller  <keith_miller@apple.com>
585
586         Add new mac target numbers
587         https://bugs.webkit.org/show_bug.cgi?id=194955
588
589         Reviewed by Tim Horton.
590
591         * DumpRenderTree/mac/Configurations/Base.xcconfig:
592         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
593         * MiniBrowser/Configurations/Base.xcconfig:
594         * TestWebKitAPI/Configurations/Base.xcconfig:
595         * WebKitTestRunner/Configurations/Base.xcconfig:
596
597 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
598
599         [WinCairo] Enable wk1/wk2 suffix for platform search path.
600         https://bugs.webkit.org/show_bug.cgi?id=194846
601
602         Reviewed by Don Olmstead.
603
604         Added _search_paths() and _port_specific_expectations_files() for
605         WinCairoPort.
606
607         * Scripts/webkitpy/port/win.py:
608         (WinCairoPort.default_baseline_search_path):
609         (WinCairoPort):
610         (WinCairoPort._port_specific_expectations_files):
611         (WinCairoPort._search_paths):
612
613 2019-02-22  Tim Horton  <timothy_horton@apple.com>
614
615         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
616         https://bugs.webkit.org/show_bug.cgi?id=194963
617
618         Reviewed by Dean Jackson.
619
620         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
621         Do a `contains` check instead of `equals`, because in debug builds we
622         put the GraphicsLayer pointer in a prefix.
623
624 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
625
626         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
627         https://bugs.webkit.org/show_bug.cgi?id=194873
628         <rdar://problem/46701974>
629
630         Reviewed by Tim Horton.
631
632         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
633
634         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
635         (WTR::UIScriptController::menuRect const):
636         (WTR::UIScriptController::isShowingMenu const):
637         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
638         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
639         (WTR::UIScriptController::menuRect const):
640
641         Add a function to query the bounds of the callout menu in content coordinates.
642
643         (WTR::UIScriptController::isShowingMenu const):
644
645         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
646
647         * TestRunnerShared/UIScriptContext/UIScriptController.h:
648         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
649         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
650         (WTR::UIScriptController::rectForMenuAction const):
651         (WTR::UIScriptController::menuRect const):
652         (WTR::UIScriptController::isShowingMenu const):
653         (WTR::findViewInHierarchyOfType): Deleted.
654
655 2019-02-22  Chris Dumez  <cdumez@apple.com>
656
657         Regression(PSON) Unable to preview password-protected documents on iCloud.com
658         https://bugs.webkit.org/show_bug.cgi?id=194954
659         <rdar://problem/48127957>
660
661         Reviewed by Alex Christensen.
662
663         Add API test coverage.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
666         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
667         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
668         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
669
670 2019-02-22  Chris Dumez  <cdumez@apple.com>
671
672         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
673         https://bugs.webkit.org/show_bug.cgi?id=194924
674         <rdar://problem/48216125>
675
676         Reviewed by Geoffrey Garen.
677
678         Add API test coverage.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
681
682 2019-02-22  Chris Dumez  <cdumez@apple.com>
683
684         Unreviewed, disable API test added in r241928 on iOS.
685
686         The cache is not enabled on devices with less than 3GB of RAM.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689
690 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
691
692         Hardcode Visual Viewports on everywhere except iOS WK1
693         https://bugs.webkit.org/show_bug.cgi?id=194928
694
695         Reviewed by Zalan Bujtas.
696
697         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
698         change the default value of the Setting to 'true', and hardcode WebView on iOS to
699         set it to false. The setting has shipped for several years and there's no need to turn
700         it off now.
701
702         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
703         Visual Viewports are not enabled.
704         
705         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
706         that only runs in WK2
707
708         * MiniBrowser/mac/SettingsController.h:
709         * MiniBrowser/mac/SettingsController.m:
710         (-[SettingsController init]):
711         (-[SettingsController _populateMenu]):
712         (-[SettingsController validateMenuItem:]):
713         (-[SettingsController visualViewportEnabled]): Deleted.
714         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
715         * MiniBrowser/mac/WK1BrowserWindowController.m:
716         (-[WK1BrowserWindowController didChangeSettings]):
717         * MiniBrowser/mac/WK2BrowserWindowController.m:
718         (-[WK2BrowserWindowController didChangeSettings]):
719
720 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
721
722         Discard cached processes when clearing website data store
723         https://bugs.webkit.org/show_bug.cgi?id=194894
724
725         Reviewed by Chris Dumez.
726
727         Added a test case.
728
729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
730         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
731
732 2019-02-21  Alex Christensen  <achristensen@webkit.org>
733
734         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
735         https://bugs.webkit.org/show_bug.cgi?id=194914
736         <rdar://problem/47586889>
737
738         Reviewed by Geoffrey Garen.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
741         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
742         (TEST):
743         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
744
745 2019-02-21  David Kilzer  <ddkilzer@apple.com>
746
747         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
748         <https://webkit.org/b/194761>
749
750         Reviewed by Myles Maxfield.
751
752         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
753         (WTR::activateSystemCoreWebFonts): Log `error` to console if
754         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
755         to use ARC-compliant cast.
756         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
757         ARC-compliant cast.
758         (WTR::installFakeHelvetica): Log `error` to console if
759         CTFontManagerRegisterFontsForURL() fails, but only on supported
760         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
761         Call CFRelease() on `error` to fix the leak.  Update to use
762         ARC-compliant cast.
763         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
764         cast.
765
766 2019-02-21  Chris Dumez  <cdumez@apple.com>
767
768         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
769         https://bugs.webkit.org/show_bug.cgi?id=194481
770
771         Reviewed by Alex Christensen.
772
773         Give the processes a chance to shutdown and wait until we reached the expected number
774         of processes.
775
776         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
777
778 2019-02-21  Tim Horton  <timothy_horton@apple.com>
779
780         Fix the macOS build
781
782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
783
784 2019-02-21  Tim Horton  <timothy_horton@apple.com>
785
786         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
787
788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
789         I am a backwards.
790
791 2019-02-21  Tim Horton  <timothy_horton@apple.com>
792
793         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
794
795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
796         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
797         We could force on UI-side compositing, but I feel like the test might be more
798         valuable exercising the normal path on each platform (though the original
799         bug was also UI-side specific). Though we can't validate that the overlay
800         layer was installed successfully, there are layout tests that do that.
801
802 2019-02-21  Tim Horton  <timothy_horton@apple.com>
803
804         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
805         https://bugs.webkit.org/show_bug.cgi?id=194845
806         <rdar://problem/47944579>
807
808         Reviewed by Antti Koivisto.
809
810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
811         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
812
813 2019-02-21  Zalan Bujtas  <zalan@apple.com>
814
815         [LFC][Floats] Add support for placing formatting roots in-between floats.
816         https://bugs.webkit.org/show_bug.cgi?id=194902
817
818         Reviewed by Antti Koivisto.
819
820         * LayoutReloaded/misc/LFC-passing-tests.txt:
821
822 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
823
824         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
825         https://bugs.webkit.org/show_bug.cgi?id=194901
826
827         Unreviewed build fix.
828
829         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
830         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
831         WPEBackend-fdo-0.1 as library name.
832
833 2019-02-21  Rob Buis  <rbuis@igalia.com>
834
835         Update MIME type parser
836         https://bugs.webkit.org/show_bug.cgi?id=180526
837
838         Reviewed by Darin Adler.
839
840         Add tests involving leading and trailing whitespace, non-token
841         characters and quoted strings.
842
843         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
844         (TestWebKitAPI::TEST):
845
846 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
847
848         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
849         https://bugs.webkit.org/show_bug.cgi?id=194884
850
851         Reviewed by Michael Catanzaro.
852
853         * PlatformWin.cmake:
854
855 2019-02-20  Chris Dumez  <cdumez@apple.com>
856
857         Add API test for <rdar://problem/47471222>
858         https://bugs.webkit.org/show_bug.cgi?id=194847
859
860         Reviewed by Alex Christensen.
861
862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
863
864 2019-02-20  Chris Dumez  <cdumez@apple.com>
865
866         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
867         https://bugs.webkit.org/show_bug.cgi?id=194872
868         <rdar://problem/47924500>
869
870         Reviewed by Alex Christensen.
871
872         Add API test coverage.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
875
876 2019-02-20  Jer Noble  <jer.noble@apple.com>
877
878         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
879         https://bugs.webkit.org/show_bug.cgi?id=191332
880
881         Reviewed by Dean Jackson.
882
883         * Scripts/git-is-in-range: Added.
884
885 2019-02-20  Andy Estes  <aestes@apple.com>
886
887         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
888         https://bugs.webkit.org/show_bug.cgi?id=194869
889
890         Rubber-stamped by Jer Noble.
891
892         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
893         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
894         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
895         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
897         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
898
899 2019-02-20  Chris Dumez  <cdumez@apple.com>
900
901         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
902         https://bugs.webkit.org/show_bug.cgi?id=194857
903         <rdar://problem/47759323>
904
905         Reviewed by Alex Christensen.
906
907         Add API test coverage.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
910
911 2019-02-20  Chris Dumez  <cdumez@apple.com>
912
913         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
914         https://bugs.webkit.org/show_bug.cgi?id=194829
915         <rdar://problem/47889906>
916
917         Reviewed by Alexey Proskuryakov.
918
919         Every time the TestOptions were changing we were creating both a new Web view and
920         a new WKContext, which would start a new Network process. In most cases, we only
921         need to contruct a new Web view and we do can keep reusing the same WKContext.
922         This patch implements this optimization and thus avoids spinning a lot of new
923         Network processes while running the layout tests.
924
925         * WebKitTestRunner/TestController.cpp:
926         (WTR::TestController::generateContextConfiguration const):
927         (WTR::TestController::generatePageConfiguration):
928         (WTR::TestController::createWebViewWithOptions):
929         (WTR::TestController::resetPreferencesToConsistentValues):
930         (WTR::updateTestOptionsFromTestHeader):
931         * WebKitTestRunner/TestController.h:
932         * WebKitTestRunner/TestOptions.h:
933         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
934         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
935         (WTR::TestOptions::hasSameInitializationOptions const):
936         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
937         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
938         (WTR::TestController::platformAddTestOptions const):
939
940 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
941
942         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
943         https://bugs.webkit.org/show_bug.cgi?id=167941
944
945         Reviewed by Carlos Garcia Campos.
946
947         * MiniBrowser/gtk/main.c:
948         (filterSavedCallback): Added.
949         (main): Support loading a JSON rule set file for content filtering.
950         * MiniBrowser/wpe/main.cpp:
951         (filterSavedCallback): Added.
952         (main): Support loading a JSON rule set file for content filtering.
953         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
954         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
955         (WTF::derefGPtr): Ditto.
956         (testEmptyStore):
957         (testSaveInvalidFilter):
958         (testSaveLoadFilter):
959         (testSavedFilterIdentifierMatch):
960         (testRemoveFilter):
961         (testSaveMultipleFilters):
962         (testSaveFilterFromFile):
963         (testFilterPersistence):
964         (beforeAll):
965         (afterAll):
966         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
967         (removeOldInjectedContentAndResetLists): Also reset content filters.
968         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
969         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
970         the element affected by the style sheet.
971         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
972         and returns it to be used by tests.
973         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
974         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
975         (serverCallback): Add support for serving a CSS style sheet for testing.
976         (beforeAll): Add call to testUserContentManagerContentFilter().
977         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
978
979 2019-02-19  Keith Rollin  <krollin@apple.com>
980
981         Add timing information to build output
982         https://bugs.webkit.org/show_bug.cgi?id=194839
983         <rdar://problem/48219609>
984
985         Reviewed by Alexey Proskuryakov.
986
987         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
988         emit each project's build time to its output. E.g.,
989
990             ** BUILD SUCCEEDED ** [0.132 sec]
991
992         * Scripts/webkitdirs.pm:
993         (XcodeOptions):
994
995 2019-02-19  Truitt Savell  <tsavell@apple.com>
996
997         Unreviewed, rolling out r241784.
998
999         Broke all OpenSource builds.
1000
1001         Reverted changeset:
1002
1003         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1004         instances view"
1005         https://bugs.webkit.org/show_bug.cgi?id=172848
1006         https://trac.webkit.org/changeset/241784
1007
1008 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1009
1010         [LFC][Floats] Remove redundant intersecting logic
1011         https://bugs.webkit.org/show_bug.cgi?id=194804
1012
1013         Reviewed by Antti Koivisto.
1014
1015         * LayoutReloaded/misc/LFC-passing-tests.txt:
1016
1017 2019-02-19  Dean Jackson  <dino@apple.com>
1018
1019         Clean-up output from generate-xcfilelists so it can be filtered
1020         https://bugs.webkit.org/show_bug.cgi?id=194795
1021
1022         Reviewed by Joseph Pecoraro (and Keith Rollin).
1023
1024         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1025         make a slight tweak to filter-build-webkit so such lines are marked
1026         as plain.
1027
1028         * Scripts/filter-build-webkit:
1029         * Scripts/generate-xcfilelists:
1030
1031 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1032
1033         pytest is not correctly auto-installed
1034         https://bugs.webkit.org/show_bug.cgi?id=194707
1035
1036         Reviewed by Carlos Garcia Campos.
1037
1038         * Scripts/webkitpy/thirdparty/__init__.py:
1039         (AutoinstallImportHook._install_pytest):
1040
1041 2019-02-18  Chris Dumez  <cdumez@apple.com>
1042
1043         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1044         https://bugs.webkit.org/show_bug.cgi?id=194797
1045         <rdar://problem/48055151>
1046
1047         Reviewed by Geoffrey Garen.
1048
1049         Add API test coverage.
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1052
1053 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1054
1055         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1056         https://bugs.webkit.org/show_bug.cgi?id=194670
1057         <rdar://problem/39066529>
1058
1059         Reviewed by Tim Horton.
1060
1061         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1062         pasted in an editable area as attachment elements.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1065         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1066         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1067         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1068         (TestWebKitAPI::TEST):
1069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1070         (WTR::InjectedBundlePage::InjectedBundlePage):
1071
1072 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1073
1074         Fix API test after r241728
1075        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1076
1077         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1078         (TEST):
1079         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1080
1081 2019-02-18  Daniel Bates  <dabates@apple.com>
1082
1083         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1084         https://bugs.webkit.org/show_bug.cgi?id=192824
1085         <rdar://problem/47100332>
1086
1087         Reviewed by Wenson Hsieh.
1088
1089         Fix a bug where the wrong usage code was used for F13 thru F24.
1090
1091         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1092         (keyCodeForDOMFunctionKey):
1093
1094 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1095
1096         Bytecode cache should a have a boot-specific validation
1097         https://bugs.webkit.org/show_bug.cgi?id=194769
1098         <rdar://problem/48149509>
1099
1100         Reviewed by Keith Miller.
1101
1102         Add test for WTF::bootSessionUUIDString()
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1105         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1106         (TEST):
1107
1108 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1109
1110         Disable safe browsing in WKWebView and remove its WKPreferences API
1111         https://bugs.webkit.org/show_bug.cgi?id=194723
1112         <rdar://problem/48122993>
1113
1114         Reviewed by Geoffrey Garen.
1115
1116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1117         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1118         (TEST):
1119         (safeBrowsingView):
1120         Make tests use SPI instead of API.
1121
1122 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1123
1124         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1125         https://bugs.webkit.org/show_bug.cgi?id=194586
1126
1127         Reviewed by Ross Kirsling.
1128
1129         * DumpRenderTree/win/DumpRenderTree.cpp:
1130         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1131         * Scripts/webkitpy/port/driver.py:
1132         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1133
1134 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1135
1136         Unreviewed, rolling out r241620.
1137
1138         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1139         (Requested by ddkilzer on #webkit.)
1140
1141         Reverted changeset:
1142
1143         "[WTF] Add environment variable helpers"
1144         https://bugs.webkit.org/show_bug.cgi?id=192405
1145         https://trac.webkit.org/changeset/241620
1146
1147 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1148
1149         [LFC] RenderImage's default intrinsic size is 0.
1150         https://bugs.webkit.org/show_bug.cgi?id=194745
1151
1152         Reviewed by Antti Koivisto.
1153
1154         * LayoutReloaded/misc/LFC-passing-tests.txt:
1155
1156 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1157
1158         [LFC][BFC] Add support for block replaced intrinsic width.
1159         https://bugs.webkit.org/show_bug.cgi?id=194705
1160
1161         Reviewed by Simon Fraser.
1162
1163         * LayoutReloaded/misc/LFC-passing-tests.txt:
1164
1165 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1166
1167         [LFC] Apply min/max width constraints to preferred width computation
1168         https://bugs.webkit.org/show_bug.cgi?id=194739
1169
1170         Reviewed by Simon Fraser.
1171
1172         * LayoutReloaded/misc/LFC-passing-tests.txt:
1173
1174 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1175
1176         [WTF] Add environment variable helpers
1177         https://bugs.webkit.org/show_bug.cgi?id=192405
1178
1179         Reviewed by Michael Catanzaro.
1180
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (libraryPathForDumpRenderTree):
1183         * DumpRenderTree/win/DumpRenderTree.cpp:
1184         (libraryPathForDumpRenderTree):
1185         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1186         (setUpIOSLayoutTestCommunication):
1187         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1188         (beforeAll):
1189         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1190         (main):
1191         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1192         (WebKitTestBus::run):
1193         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1194         (WTR::getOutputDir):
1195         (WTR::initializeFontConfigSetting):
1196         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1197         (WTR::InjectedBundle::platformInitialize):
1198         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1199         (WTR::topLevelPath):
1200         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1201         (WTR::topLevelPath):
1202         (WTR::getOutputDir):
1203         (WTR::activateFonts):
1204         * WebKitTestRunner/TestController.cpp:
1205         (WTR::TestController::libraryPathForTesting):
1206         (WTR::TestController::generateContextConfiguration const):
1207         (WTR::TestController::generatePageConfiguration):
1208         (WTR::TestController::decideDestinationWithSuggestedFilename):
1209         (WTR::TestController::platformAdjustContext):
1210         * WebKitTestRunner/TestController.h:
1211         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1212         (WTR::TestController::cocoaPlatformInitialize):
1213         (WTR::TestController::platformAdjustContext):
1214         * WebKitTestRunner/gtk/main.cpp:
1215         (main):
1216         * WebKitTestRunner/mac/TestControllerMac.mm:
1217         (WTR::TestController::configureContentExtensionForTest):
1218         * WebKitTestRunner/wpe/main.cpp:
1219         (main):
1220         Utilize WTF::Environment where possible.
1221
1222 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1223
1224         [iOS] WKWebView callout bar is missing Change Writing Direction item
1225         https://bugs.webkit.org/show_bug.cgi?id=190015
1226         <rdar://problem/44810366>
1227
1228         Reviewed by Tim Horton.
1229
1230         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1231         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1234         (TestWebKitAPI::TEST):
1235
1236 2019-02-15  Chris Dumez  <cdumez@apple.com>
1237
1238         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1239         https://bugs.webkit.org/show_bug.cgi?id=194717
1240         <rdar://problem/47884404>
1241
1242         Reviewed by Brady Eidson.
1243
1244         Add API test coverage.
1245
1246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1247
1248 2019-02-15  Youenn Fablet  <youenn@apple.com>
1249
1250         Make navigator.mediaDevices SecureContext
1251         https://bugs.webkit.org/show_bug.cgi?id=194666
1252
1253         Reviewed by Eric Carlson.
1254
1255         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1256         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1257         (TEST_F):
1258
1259 2019-02-15  Brian Burg  <bburg@apple.com>
1260
1261         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1262         https://bugs.webkit.org/show_bug.cgi?id=194411
1263         <rdar://problem/47787614>
1264
1265         Reviewed by Joseph Pecoraro.
1266
1267         Remove unnecessary soft linking macro usage.
1268
1269         * DumpRenderTree/mac/TestRunnerMac.mm:
1270         (TestRunner::inspectorTestStubURL):
1271         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1272         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1273         (WTR::TestRunner::inspectorTestStubURL):
1274
1275 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1276
1277         Unreviewed, rolling out r241559 and r241566.
1278         https://bugs.webkit.org/show_bug.cgi?id=194710
1279
1280         Causes layout test crashes under GuardMalloc (Requested by
1281         ryanhaddad on #webkit).
1282
1283         Reverted changesets:
1284
1285         "[WTF] Add environment variable helpers"
1286         https://bugs.webkit.org/show_bug.cgi?id=192405
1287         https://trac.webkit.org/changeset/241559
1288
1289         "Unreviewed build fix for WinCairo Debug after r241559."
1290         https://trac.webkit.org/changeset/241566
1291
1292 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1293
1294         [LFC] Out-of-flow box is never a float box
1295         https://bugs.webkit.org/show_bug.cgi?id=194704
1296
1297         Reviewed by Antti Koivisto.
1298
1299         * LayoutReloaded/misc/LFC-passing-tests.txt:
1300
1301 2019-02-10  Darin Adler  <darin@apple.com>
1302
1303         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1304         https://bugs.webkit.org/show_bug.cgi?id=194487
1305
1306         Reviewed by Daniel Bates.
1307
1308         * DumpRenderTree/win/DumpRenderTree.cpp:
1309         (applicationId): Use makeString instead of String::format.
1310         (main): Ditto.
1311         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1312         (TestWebKitAPI::Util::createURLForResource): Ditto.
1313         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1314         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1315
1316         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1317         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1318         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1319         (WTR::createStringWithAttributes): Use appendLiteral.
1320         (WTR::AccessibilityUIElement::helpText const): Ditto.
1321         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1322         directly instead of using String::format.
1323         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1324         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1325
1326 2019-02-15  Truitt Savell  <tsavell@apple.com>
1327
1328         Unreviewed, rolling out r241564.
1329
1330         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1331
1332         Reverted changeset:
1333
1334         "[Mac] WebInspectorUI.framework does not need to be soft-
1335         linked anymore"
1336         https://bugs.webkit.org/show_bug.cgi?id=194411
1337         https://trac.webkit.org/changeset/241564
1338
1339 2019-02-15  Saam barati  <sbarati@apple.com>
1340
1341         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1342         https://bugs.webkit.org/show_bug.cgi?id=194036
1343
1344         Reviewed by Yusuke Suzuki.
1345
1346         * Scripts/run-jsc-stress-tests:
1347
1348 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1349
1350         Fix the build.
1351
1352         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1353         (WTR::UIScriptController::drawSquareInEditableImage):
1354         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1355         (TestWebKitAPI::drawSquareInEditableImage):
1356
1357 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1358
1359         Fix the build.
1360
1361         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1362         (WTR::UIScriptController::drawSquareInEditableImage):
1363         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1364         (TestWebKitAPI::drawSquareInEditableImage):
1365
1366 2019-02-14  Brian Burg  <bburg@apple.com>
1367
1368         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1369         https://bugs.webkit.org/show_bug.cgi?id=194411
1370         <rdar://problem/47787614>
1371
1372         Reviewed by Joseph Pecoraro.
1373
1374         Remove unnecessary soft linking macro usage.
1375
1376         * DumpRenderTree/mac/TestRunnerMac.mm:
1377         (TestRunner::inspectorTestStubURL):
1378         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1379         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1380         (WTR::TestRunner::inspectorTestStubURL):
1381
1382 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1383
1384         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1385         https://bugs.webkit.org/show_bug.cgi?id=194599
1386
1387         Reviewed by Lucas Forschler.
1388
1389         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1390         (StatusBubble._build_bubble):
1391
1392 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1393
1394         [ews-app] Set Foreign Key in Django build model
1395         https://bugs.webkit.org/show_bug.cgi?id=194667
1396
1397         Reviewed by Lucas Forschler.
1398
1399         * BuildSlaveSupport/ews-app/ews/models/build.py:
1400         (Build):
1401
1402 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1403
1404         [WTF] Add environment variable helpers
1405         https://bugs.webkit.org/show_bug.cgi?id=192405
1406
1407         Reviewed by Michael Catanzaro.
1408
1409         * DumpRenderTree/mac/DumpRenderTree.mm:
1410         (libraryPathForDumpRenderTree):
1411         * DumpRenderTree/win/DumpRenderTree.cpp:
1412         (libraryPathForDumpRenderTree):
1413         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1414         (setUpIOSLayoutTestCommunication):
1415         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1416         (TestWebKitAPI::strip):
1417         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1418         (beforeAll):
1419         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1420         (main):
1421         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1422         (WebKitTestBus::run):
1423         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1424         (WTR::getOutputDir):
1425         (WTR::initializeFontConfigSetting):
1426         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1427         (WTR::InjectedBundle::platformInitialize):
1428         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1429         (WTR::topLevelPath):
1430         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1431         (WTR::topLevelPath):
1432         (WTR::getOutputDir):
1433         (WTR::activateFonts):
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::TestController::libraryPathForTesting):
1436         (WTR::TestController::generateContextConfiguration const):
1437         (WTR::TestController::generatePageConfiguration):
1438         (WTR::TestController::decideDestinationWithSuggestedFilename):
1439         (WTR::TestController::platformAdjustContext):
1440         * WebKitTestRunner/TestController.h:
1441         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1442         (WTR::TestController::cocoaPlatformInitialize):
1443         (WTR::TestController::platformAdjustContext):
1444         * WebKitTestRunner/gtk/main.cpp:
1445         (main):
1446         * WebKitTestRunner/mac/TestControllerMac.mm:
1447         (WTR::TestController::configureContentExtensionForTest):
1448         * WebKitTestRunner/wpe/main.cpp:
1449         (main):
1450         Utilize WTF::Environment where possible.
1451
1452 2019-02-14  Chris Dumez  <cdumez@apple.com>
1453
1454         [PSON] Introduce a WebContent Process cache
1455         https://bugs.webkit.org/show_bug.cgi?id=194594
1456         <rdar://problem/46793397>
1457
1458         Reviewed by Geoff Garen.
1459
1460         Update API tests to turn on the WebContent Process cache.
1461
1462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1463
1464 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1465
1466         Unreviewed, build fix after r241480
1467
1468         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1469         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1470         (-[DragAndDropSimulator initWithWebView:]):
1471
1472 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1473
1474         AX: ARIA Reflection was disabled in error
1475         https://bugs.webkit.org/show_bug.cgi?id=194647
1476         <rdar://problem/48068336>
1477
1478         Reviewed by Ryosuke Niwa.
1479
1480         Remove test override now that this feature should be enabled by default.
1481
1482         * WebKitTestRunner/TestController.cpp:
1483         (WTR::TestController::resetPreferencesToConsistentValues):
1484
1485 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1486
1487         Unreviewed, rolling out r241486.
1488         https://bugs.webkit.org/show_bug.cgi?id=194655
1489
1490         causing API failures in builds (Requested by ShawnRoberts on
1491         #webkit).
1492
1493         Reverted changeset:
1494
1495         "[Cocoa] Media elements will restart network buffering just
1496         before suspending"
1497         https://bugs.webkit.org/show_bug.cgi?id=193691
1498         https://trac.webkit.org/changeset/241486
1499
1500 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1501
1502         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1503         https://bugs.webkit.org/show_bug.cgi?id=194622
1504
1505         Reviewed by Antti Koivisto.
1506
1507         * LayoutReloaded/misc/LFC-passing-tests.txt:
1508
1509 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1510
1511         [LFC] Shrink-to-fit-width should be constrained by min/max width
1512         https://bugs.webkit.org/show_bug.cgi?id=194653
1513
1514         Reviewed by Antti Koivisto.
1515
1516         * LayoutReloaded/misc/LFC-passing-tests.txt:
1517
1518 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1519
1520         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1521         https://bugs.webkit.org/show_bug.cgi?id=194641
1522
1523         Reviewed by Geoffrey Garen.
1524
1525         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1526         so that the test would fail without this fix.
1527
1528         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1529         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1530
1531 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1532
1533         [ews-app] Change log level for a log statement
1534
1535         Unreviewed minor fix.
1536
1537         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1538         (Patch.save_patch):
1539
1540 2019-02-13  Jer Noble  <jer.noble@apple.com>
1541
1542         [Cocoa] Media elements will restart network buffering just before suspending
1543         https://bugs.webkit.org/show_bug.cgi?id=193691
1544
1545         Reviewed by Eric Carlson.
1546
1547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1549         (TEST):
1550
1551 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-app] Fetch builder id to name mapping
1554         https://bugs.webkit.org/show_bug.cgi?id=194355
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1559         (Buildbot.get_builder_id_to_name_mapping):
1560         (Buildbot._get_display_name_from_builder_name):
1561
1562 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1563
1564         Further restricting webarchive loads
1565         https://bugs.webkit.org/show_bug.cgi?id=194567
1566         <rdar://problem/47610130>
1567
1568         Reviewed by Youenn Fablet.
1569
1570         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1571         navigations on drop.
1572
1573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1574         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1575         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1576         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1577         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1580         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1581         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1582         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1583         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1584         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1585         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1586
1587 2019-02-13  John Wilander  <wilander@apple.com>
1588
1589         Store Ad Click Attribution requests in the network process
1590         https://bugs.webkit.org/show_bug.cgi?id=194510
1591         <rdar://problem/47650118>
1592
1593         Reviewed by Alex Christensen and Daniel Bates.
1594
1595         This patch adds two TestRunner functions:
1596         - dumpAdClickAttribution()
1597         - clearAdClickAttribution()
1598
1599         They call into the network process to dump and clear Ad Click
1600         Attribution state, respectively.
1601
1602         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1604         (WTR::TestRunner::dumpAdClickAttribution):
1605         (WTR::TestRunner::clearAdClickAttribution):
1606         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1607         * WebKitTestRunner/TestController.cpp:
1608         (WTR::TestController::resetStateToConsistentValues):
1609         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1610         (WTR::adClickAttributionStringResultCallback):
1611         (WTR::TestController::dumpAdClickAttribution):
1612         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1613         (WTR::adClickAttributionVoidCallback):
1614         (WTR::TestController::clearAdClickAttribution):
1615         * WebKitTestRunner/TestController.h:
1616         * WebKitTestRunner/TestInvocation.cpp:
1617         (WTR::TestInvocation::dumpResults):
1618         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1619         (WTR::TestInvocation::dumpAdClickAttribution):
1620         * WebKitTestRunner/TestInvocation.h:
1621
1622 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-app] Generate status-bubble
1625         https://bugs.webkit.org/show_bug.cgi?id=194572
1626
1627         Reviewed by Lucas Forschler.
1628
1629         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1630         (StatusBubble._build_bubble):
1631         (StatusBubble._should_show_bubble_for):
1632         (StatusBubble._build_bubbles_for_patch):
1633
1634 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1635
1636         [ews-app] Add status bubble html template
1637         https://bugs.webkit.org/show_bug.cgi?id=194571
1638
1639         Reviewed by Lucas Forschler.
1640
1641         * BuildSlaveSupport/ews-app/ews/templates: Added.
1642         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1643
1644 2019-02-12  Chris Dumez  <cdumez@apple.com>
1645
1646         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1647         https://bugs.webkit.org/show_bug.cgi?id=194568
1648         <rdar://problem/47944490>
1649
1650         Reviewed by Ryosuke Niwa.
1651
1652         Add API test coverage.
1653
1654         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1655         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1656
1657 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1658
1659         webkitpy: Remove bug_dummy from parsed test expectations
1660         https://bugs.webkit.org/show_bug.cgi?id=194562
1661         <rdar://problem/47853999>
1662
1663         Reviewed by Lucas Forschler.
1664
1665         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1666         (TestExpectationParser):
1667         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1668         skipped tests.
1669         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1670
1671 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1672
1673         [ews-app] Add method to fetch patch
1674         https://bugs.webkit.org/show_bug.cgi?id=194518
1675
1676         Reviewed by Lucas Forschler.
1677
1678         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1679         (Patch.get_patch):
1680
1681 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1682
1683         [LFC] Expand tests coverage (60 new tests -> 860)
1684
1685         Unreviewed test gardening (run-singly, --child-processes=1).
1686
1687         * LayoutReloaded/misc/LFC-passing-tests.txt:
1688
1689 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1690
1691         Allow pages to trigger programmatic paste from script on iOS
1692         https://bugs.webkit.org/show_bug.cgi?id=194271
1693         <rdar://problem/47808810>
1694
1695         Reviewed by Tim Horton.
1696
1697         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1698
1699         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1700         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1701         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1702         (WTR::UIScriptController::rectForMenuAction const):
1703
1704         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1705         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1706         for when the menu is shown or hidden.
1707
1708         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1709         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1710         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1711         (WTR::UIScriptController::setDidShowMenuCallback):
1712         (WTR::UIScriptController::didShowMenuCallback const):
1713         (WTR::UIScriptController::setDidHideMenuCallback):
1714         (WTR::UIScriptController::didHideMenuCallback const):
1715         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1716         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1717         (WTR::UIScriptController::rectForMenuAction const):
1718         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::TestController::resetPreferencesToConsistentValues):
1721         (WTR::updateTestOptionsFromTestHeader):
1722         * WebKitTestRunner/TestOptions.h:
1723
1724         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1725         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1726
1727         (WTR::TestOptions::hasSameInitializationOptions const):
1728         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1729         (WTR::UIScriptController::calendarType const):
1730         (WTR::UIScriptController::platformUndoManager const):
1731         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1732         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1733         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1734         (-[TestRunnerWKWebView dealloc]):
1735         (-[TestRunnerWKWebView _didShowMenu]):
1736         (-[TestRunnerWKWebView _didHideMenu]):
1737
1738         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1739
1740         * WebKitTestRunner/ios/TestControllerIOS.mm:
1741         (WTR::handleMenuWillHideNotification):
1742         (WTR::handleMenuDidHideNotification):
1743         (WTR::TestController::platformInitialize):
1744         (WTR::TestController::platformDestroy):
1745         (WTR::TestController::platformResetStateToConsistentValues):
1746
1747         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1748         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1749
1750         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1751         (WTR::forEachViewInHierarchy):
1752         (WTR::findViewInHierarchyOfType):
1753
1754         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1755         functions that dig through a given view's hierarchy in search of a view of a given class.
1756
1757         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1758         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1759         (WTR::UIScriptController::selectionCaretViewRect const):
1760         (WTR::UIScriptController::selectionRangeViewRects const):
1761         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1762         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1763
1764         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1765
1766         (WTR::UIScriptController::rectForMenuAction const):
1767
1768         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1769         callout bar) whose label matches the given string.
1770
1771         (WTR::UIScriptController::platformContentView const):
1772
1773         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1774         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1775         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1776
1777         (WTR::UIScriptController::platformUndoManager const): Deleted.
1778         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1779         (WTR::UIScriptController::platformContentView const):
1780         (WTR::UIScriptController::platformUndoManager const): Deleted.
1781
1782 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1783
1784         webkitpy: No option to only show unexpected failures in results.html for iPad
1785         https://bugs.webkit.org/show_bug.cgi?id=194554
1786         <rdar://problem/47922442>
1787
1788         Rubber-stamped by Aakash Jain.
1789
1790         Just because a TestExpecations file does not exist for a specific platform does not mean that
1791         TestExpecations are not being used, given that platforms inherit test expectations.
1792
1793         * Scripts/webkitpy/port/base.py:
1794         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1795         * Scripts/webkitpy/port/base_unittest.py:
1796         (PortTest.test_uses_test_expectations_file):
1797
1798 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1799
1800         Remove setDefersLoading infrastructure from WebKit2
1801         https://bugs.webkit.org/show_bug.cgi?id=194506
1802
1803         Reviewed by Brady Eidson.
1804
1805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1806         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1807         (WTR::TestRunner::setDefersLoading): Deleted.
1808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1809
1810 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1811
1812         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1813         https://bugs.webkit.org/show_bug.cgi?id=194522
1814         <rdar://problem/47789393>
1815
1816         Reviewed by Chris Dumez.
1817
1818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1819         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1820         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1822
1823 2019-02-12  Andy Estes  <aestes@apple.com>
1824
1825         [iOSMac] Enable Parental Controls Content Filtering
1826         https://bugs.webkit.org/show_bug.cgi?id=194521
1827         <rdar://39732376>
1828
1829         Reviewed by Tim Horton.
1830
1831         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1832
1833 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1834
1835         [LFC][IFC] Add intrinsic width support for float boxes.
1836         https://bugs.webkit.org/show_bug.cgi?id=194528
1837
1838         Reviewed by Antti Koivisto.
1839
1840         Expand tests coverage (2 new tests -> 800).
1841         (This is the correct test ordering --runs-singly --child-processes=1)
1842
1843         * LayoutReloaded/misc/LFC-passing-tests.txt:
1844
1845 2019-02-12  Rob Buis  <rbuis@igalia.com>
1846
1847         Implement serializing in MIME type parser
1848         https://bugs.webkit.org/show_bug.cgi?id=193909
1849
1850         Reviewed by Darin Adler.
1851
1852         Add various tests involving upper case, non-ASCII, control/null characters,
1853         various HTTP whitespace, single quotes and an unpaired surrogate.
1854
1855         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1856         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1857         (TestWebKitAPI::serializeIfValid):
1858         (TestWebKitAPI::TEST):
1859
1860 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1861
1862         [Cocoa] Ask platform for generic font family mappings
1863         https://bugs.webkit.org/show_bug.cgi?id=187723
1864         <rdar://problem/41892438>
1865
1866         Reviewed by Brent Fulgham.
1867
1868         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1869
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (allowedFontFamilySet):
1872         * WebKitTestRunner/mac/TestControllerMac.mm:
1873         (WTR::allowedFontFamilySet):
1874
1875 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1876
1877         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1878         https://bugs.webkit.org/show_bug.cgi?id=193622
1879
1880         Reviewed by Michael Catanzaro.
1881
1882         This adds support for loading content extension rule sets from the JSON files which
1883         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1884         of WKTR for this could be removed, but that is left for a follow-up patch with
1885         cleanups.
1886
1887         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1888         * WebKitTestRunner/TestController.cpp:
1889         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1890         avoid having the null-terminator copied into the result.
1891         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1892         part of the preparations to run a test.
1893         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1894         (WTR::contentExtensionStoreCallback): Added.
1895         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1896         used for content extensions test.
1897         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1898         extensions and compiling the JSON rule set for tests involving content extensions.
1899         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1900         testing and disables content extensions.
1901         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1902         resetContentExtensions().
1903         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1904         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1905         configureContentExtensionForTest(), and userContentController().
1906
1907 2019-02-11  Daniel Bates  <dabates@apple.com>
1908
1909         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1910         https://bugs.webkit.org/show_bug.cgi?id=191446
1911         <rdar://problem/45929460>
1912
1913         Reviewed by Tim Horton.
1914
1915         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1916
1917         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1918         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1919         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1920         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1921         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1922         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1923         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1924         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1925         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1926         (WTR::arrayLength):
1927         (WTR::parseModifierArray):
1928         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1929         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1930         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1931         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1932
1933 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1934
1935         Unreviewed, rolling out r241272 and r241276.
1936         https://bugs.webkit.org/show_bug.cgi?id=194514
1937
1938         Broke the Apple Internal build and the fix requires human
1939         intervention :( (Requested by dydz on #webkit).
1940
1941         Reverted changesets:
1942
1943         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1944         https://bugs.webkit.org/show_bug.cgi?id=191446
1945         https://trac.webkit.org/changeset/241272
1946
1947         "Fix internal iOS build after r241272"
1948         https://bugs.webkit.org/show_bug.cgi?id=191446
1949         https://trac.webkit.org/changeset/241276
1950
1951 2019-02-11  Truitt Savell  <tsavell@apple.com>
1952
1953         Unreviewed, rolling out r241269.
1954
1955         Caused 5 layout tests crashes on Mac WK1
1956
1957         Reverted changeset:
1958
1959         "DumpRenderTree should report unknown options"
1960         https://bugs.webkit.org/show_bug.cgi?id=191303
1961         https://trac.webkit.org/changeset/241269
1962
1963 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1964
1965         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1966         https://bugs.webkit.org/show_bug.cgi?id=194313
1967
1968         Reviewed by Tim Horton.
1969
1970         Add a helper to determine whether the web view is presenting modal UI.
1971
1972         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1973         (WTR::UIScriptController::isPresentingModally const):
1974         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1975         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1976         (WTR::UIScriptController::isPresentingModally const):
1977         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1978         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1979         (WTR::UIScriptController::calendarType const): Deleted.
1980         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1981         (WTR::UIScriptController::isPresentingModally const):
1982         (WTR::UIScriptController::calendarType const):
1983         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1984         (WTR::UIScriptController::calendarType const):
1985
1986 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1987
1988         GCHeapInspector: Show the retained sizes in more places
1989         https://bugs.webkit.org/show_bug.cgi?id=194464
1990
1991         Reviewed by Simon Fraser.
1992
1993         * GCHeapInspector/gc-heap-inspector.html:
1994         * GCHeapInspector/script/interface.js:
1995         (HeapInspectorUtils.humanReadableSize):
1996         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1997         (HeapInspectorUtils.spanForNode.span.span):
1998         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1999         (HeapSnapshotInspector.prototype.buildRoots):
2000
2001 2019-02-11  Daniel Bates  <dabates@apple.com>
2002
2003         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2004         https://bugs.webkit.org/show_bug.cgi?id=191446
2005         <rdar://problem/45929460>
2006
2007         Reviewed by Tim Horton.
2008
2009         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2010
2011         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2012         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2013         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2014         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2015         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2016         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2017         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2018         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2019         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2020         (WTR::arrayLength):
2021         (WTR::parseModifierArray):
2022         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2023         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2024         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2025         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2026
2027 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2028
2029         DumpRenderTree should report unknown options
2030         https://bugs.webkit.org/show_bug.cgi?id=191303
2031
2032         Reviewed by Frédéric Wang.
2033
2034         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2035         to report unknown options.
2036         Added and assigned test options which are currently used in tests.
2037
2038         * DumpRenderTree/TestOptions.cpp:
2039         (TestOptions::TestOptions):
2040
2041 2019-02-11  Truitt Savell  <tsavell@apple.com>
2042
2043         Unreviewed, rolling out r241229.
2044
2045         Revision broke internal builds for watchOS.
2046
2047         Reverted changeset:
2048
2049         "[Cocoa] Ask platform for generic font family mappings"
2050         https://bugs.webkit.org/show_bug.cgi?id=187723
2051         https://trac.webkit.org/changeset/241229
2052
2053 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2054
2055         [WinCairo][MiniBrowser] Basic authentication always fails.
2056         https://bugs.webkit.org/show_bug.cgi?id=194496
2057
2058         Reviewed by Don Olmstead.
2059
2060         * MiniBrowser/win/DialogHelper.h:
2061         (Dialog::getText):
2062
2063 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2064
2065         [GStreamer] GstMappedBuffer testsuite build fails
2066         https://bugs.webkit.org/show_bug.cgi?id=194495
2067
2068         Reviewed by Carlos Garcia Campos.
2069
2070         Fix the build by explicitely adding the gstreamer1.0-audio include
2071         directories to the include path.
2072
2073         * TestWebKitAPI/PlatformGTK.cmake:
2074         * TestWebKitAPI/PlatformWPE.cmake:
2075
2076 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2077
2078         [GTK][WPE] Add enable-javascript-markup setting
2079         https://bugs.webkit.org/show_bug.cgi?id=193439
2080
2081         Reviewed by Michael Catanzaro.
2082
2083         Add test cases to check the new setting.
2084
2085         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2086         (testWebKitSettings):
2087         (testWebKitSettingsJavaScriptMarkup):
2088         (beforeAll):
2089
2090 2019-02-10  Darin Adler  <darin@apple.com>
2091
2092         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2093         https://bugs.webkit.org/show_bug.cgi?id=194485
2094
2095         Reviewed by Daniel Bates.
2096
2097         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2098
2099 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2100
2101         Add more tests for clampTo<>()
2102         https://bugs.webkit.org/show_bug.cgi?id=194462
2103
2104         Reviewed by Geoffrey Garen.
2105
2106         Darin suggested to test the very last floating point number
2107         at the boundaries when truncating to integer.
2108         I added test for max/min and max-1/min-1.
2109
2110         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2111         (TestWebKitAPI::TEST):
2112
2113 2019-02-09  Darin Adler  <darin@apple.com>
2114
2115         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2116         https://bugs.webkit.org/show_bug.cgi?id=194021
2117
2118         Reviewed by Geoffrey Garen.
2119
2120         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2121         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2122         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2123
2124 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2125
2126         [LFC][IFC] Add intrinsic width support for basic inline containers
2127         https://bugs.webkit.org/show_bug.cgi?id=194473
2128
2129         Reviewed by Antti Koivisto.
2130
2131         Expand tests coverage (11 new tests -> 798)
2132
2133         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2134
2135 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2136
2137         Fix MiniBrowser's entitlements
2138         https://bugs.webkit.org/show_bug.cgi?id=192431
2139
2140         Reviewed by Joseph Pecoraro.
2141
2142         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2143         files, making it impossible to load any extension.
2144
2145         * MiniBrowser/MiniBrowser.entitlements:
2146
2147 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2148
2149         [Cocoa] Ask platform for generic font family mappings
2150         https://bugs.webkit.org/show_bug.cgi?id=187723
2151         <rdar://problem/41892438>
2152
2153         Reviewed by Brent Fulgham.
2154
2155         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2156
2157         * DumpRenderTree/mac/DumpRenderTree.mm:
2158         (allowedFontFamilySet):
2159         * WebKitTestRunner/mac/TestControllerMac.mm:
2160         (WTR::allowedFontFamilySet):
2161
2162 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2163
2164         [GTK] Implement back/forward touchpad gesture
2165         https://bugs.webkit.org/show_bug.cgi?id=193919
2166
2167         Reviewed by Michael Catanzaro.
2168
2169         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2170         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2171
2172 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2173
2174         Add SPI to use networking daemon instead of XPC service
2175         https://bugs.webkit.org/show_bug.cgi?id=194427
2176
2177         Reviewed by Geoffrey Garen
2178
2179         * MiniBrowser/MiniBrowser.entitlements:
2180
2181 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2182
2183         [ews-build] Ensure that every builder in config.json has short name
2184         https://bugs.webkit.org/show_bug.cgi?id=194461
2185
2186         Reviewed by Lucas Forschler.
2187
2188         * BuildSlaveSupport/ews-build/loadConfig.py:
2189         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2190
2191 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2192
2193         [ews-build] Add short name to config.json
2194         https://bugs.webkit.org/show_bug.cgi?id=194456
2195
2196         Reviewed by Lucas Forschler.
2197
2198         * BuildSlaveSupport/ews-build/config.json: Added short name.
2199         * BuildSlaveSupport/ews-build/loadConfig.py:
2200         (loadBuilderConfig): Set the short name as the builder description.
2201
2202 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2203
2204         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2205         https://bugs.webkit.org/show_bug.cgi?id=194418
2206
2207         Reviewed by Lucas Forschler.
2208
2209         Do not include errors trying when finding crashlogs at the end of
2210         a run-webkit-tests run since we don't process those errors.
2211
2212         * Scripts/webkitpy/port/darwin.py:
2213         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2214         * Scripts/webkitpy/port/ios_device.py:
2215         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2216         * Scripts/webkitpy/port/watch_device.py:
2217         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2218
2219 2019-02-08  Beth Dakin  <bdakin@apple.com>
2220
2221         Add afterScreenUpdates to WKSnapshotConfiguration
2222         https://bugs.webkit.org/show_bug.cgi?id=194362
2223         -and corresponding-
2224         <rdar://problem/40655528> Please add an "after screen updates" property to 
2225         WKSnapshotConfiguration (to solve blank snapshots)
2226
2227         Reviewed by Tim Horton.
2228
2229         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2230         (TEST):
2231
2232 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2233
2234         clampTo(): do not convert the input to double when dealing with integers
2235         https://bugs.webkit.org/show_bug.cgi?id=194263
2236         <rdar://problem/47692312>
2237
2238         Reviewed by Darin Adler.
2239
2240         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2241         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2242         (TestWebKitAPI::testClampFloatingPointToInteger):
2243         (TestWebKitAPI::testClampSameSignIntegers):
2244         (TestWebKitAPI::testClampUnsignedToSigned):
2245         (TestWebKitAPI::testClampSignedToUnsigned):
2246
2247 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2248
2249         webkitpy: Respect --dedicated-simulators flag
2250         https://bugs.webkit.org/show_bug.cgi?id=194416
2251         <rdar://problem/47894722>
2252
2253         Reviewed by Lucas Forschler.
2254
2255         * Scripts/webkitpy/port/device_port.py:
2256         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2257         available devices can be safely ignored.
2258
2259 2019-02-07  Keith Rollin  <krollin@apple.com>
2260
2261         Remove extra copy of 100x100-red.tga
2262         https://bugs.webkit.org/show_bug.cgi?id=194371
2263         <rdar://problem/47873465>
2264
2265         Reviewed by Said Abou-Hallawa.
2266
2267         In order to help it pass its tests, Bug 194190 added a second copy of
2268         the file 100x100-red.tga. However, it turns out that this additional
2269         file wasn't actually needed, and that that sole previous copy was
2270         sufficient. At the same time, this second copy -- which was copied to
2271         the same location in the build output as the first copy -- now caused
2272         XCBuild to complain because there were two production rules for the
2273         same output file. Address this by removing the newly-added extra copy.
2274
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2276         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2277
2278 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2279
2280         Deprecate WKBundlePageSetDefersLoading
2281         https://bugs.webkit.org/show_bug.cgi?id=191394
2282
2283         Reviewed by Dean Jackson.
2284
2285         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2286         (WTR::TestRunner::setDefersLoading):
2287
2288 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2289
2290         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2291         https://bugs.webkit.org/show_bug.cgi?id=194391
2292
2293         Reviewed by Antti Koivisto.
2294
2295         * LayoutReloaded/misc/LFC-passing-tests.txt:
2296
2297 2019-02-06  Keith Rollin  <krollin@apple.com>
2298
2299         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2300         https://bugs.webkit.org/show_bug.cgi?id=193975
2301         <rdar://problem/47643306>
2302
2303         Reviewed by Tim Horton.
2304
2305         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2306         the Info.plist file into the bundle. This step is not necessary as the
2307         implicit "bundle up all the build products into a framework" build
2308         phase does this already. Having the Copy Bundle Resources phase do
2309         this causes a conflict under XCBuild, which objects to two build
2310         phases producing the same file (Info.plist). Address this by removing
2311         Info.plist from the Copy Bundle Resources phase.
2312
2313         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2314
2315 2019-02-06  Keith Rollin  <krollin@apple.com>
2316
2317         Really enable the automatic checking and regenerations of .xcfilelists during builds
2318         https://bugs.webkit.org/show_bug.cgi?id=194357
2319         <rdar://problem/47861231>
2320
2321         Reviewed by Chris Dumez.
2322
2323         Bug 194124 was supposed to enable the automatic checking and
2324         regenerating of .xcfilelist files during the build. While related
2325         changes were included in that patch, the change to actually enable the
2326         operation somehow was omitted. This patch actually enables the
2327         operation. The check-xcfilelist.sh scripts now check
2328         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2329         from the checking.
2330
2331         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2332         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2333
2334 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2335
2336         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2337         <https://webkit.org/b/194286>
2338         <rdar://problem/47815558>
2339
2340         Reviewed by Alexey Proskuryakov.
2341
2342         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2343         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2344         WKRetainPtr<> to avoid leaking the WKDataRef.
2345
2346 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2347
2348         Unreviewed, fix a typo
2349
2350         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2351
2352 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2353
2354         [GTK][WPE] force libpsl build to use ICU in jhbuild
2355         https://bugs.webkit.org/show_bug.cgi?id=194288
2356
2357         Reviewed by Carlos Garcia Campos.
2358
2359         * gtk/jhbuild.modules:
2360         Require ICU for libpsl build in jhbuild, like done in WPE.
2361
2362 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2363
2364         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2365         https://bugs.webkit.org/show_bug.cgi?id=194209
2366
2367         Reviewed by Carlos Garcia Campos.
2368
2369         Enhance TestCookieManager to ensure this doesn't happen again.
2370
2371         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2372         (testCookieManagerPersistentStorage):
2373         (beforeAll):
2374
2375 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2376
2377         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2378         https://bugs.webkit.org/show_bug.cgi?id=194324
2379
2380         Reviewed by Andy Estes.
2381
2382         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2383         part of the name is already implicit, since this is in testing code in TestOptions.
2384
2385         * WebKitTestRunner/TestController.cpp:
2386         (WTR::TestController::generateContextConfiguration const):
2387         (WTR::updateTestOptionsFromTestHeader):
2388         * WebKitTestRunner/TestOptions.h:
2389         (WTR::TestOptions::hasSameInitializationOptions const):
2390
2391 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2392
2393         [ews-build] Allow * as platform for builders and workers
2394         https://bugs.webkit.org/show_bug.cgi?id=188533
2395
2396         Reviewed by Lucas Forschler.
2397
2398         * BuildSlaveSupport/ews-build/loadConfig.py:
2399         (checkWorkersAndBuildersForConsistency):
2400
2401 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2402
2403         [ews-build] Add few bots to config.json
2404         https://bugs.webkit.org/show_bug.cgi?id=194304
2405
2406         Reviewed by Lucas Forschler.
2407
2408         * BuildSlaveSupport/ews-build/config.json:
2409
2410 2019-02-05  Keith Rollin  <krollin@apple.com>
2411
2412         Enable the automatic checking and regenerations of .xcfilelists during builds
2413         https://bugs.webkit.org/show_bug.cgi?id=194124
2414         <rdar://problem/47721277>
2415
2416         Reviewed by Tim Horton.
2417
2418         Bug 193790 add a facility for checking -- during build time -- that
2419         any needed .xcfilelist files are up-to-date and for updating them if
2420         they are not. This facility was initially opt-in by setting
2421         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2422         the process seemed robust. Its now time to enable this facility and
2423         make it opt-out. If there is a need to disable this facility, set and
2424         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2425         running `make` or `build-webkit`, or before running Xcode from the
2426         command line.
2427
2428         Additionally, remove the step that generates a list of source files
2429         going into the UnifiedSources build step. It's only necessarily to
2430         specify Sources.txt and SourcesCocoa.txt as inputs.
2431
2432         * Scripts/generate-xcfilelists:
2433
2434 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2435
2436         [GTK][WPE] force libpsl build to use ICU in jhbuild
2437         https://bugs.webkit.org/show_bug.cgi?id=194288
2438
2439         Reviewed by Philippe Normand.
2440
2441         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2442         This can cause build failures if libidn is detected but libunistring is not available.
2443
2444         Make sure that ICU is used for runtime and builtin PSL data.
2445
2446         * gtk/jhbuild.modules:
2447         * wpe/jhbuild.modules:
2448
2449 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-app] Modified timestamp should be updated on updating data
2452         https://bugs.webkit.org/show_bug.cgi?id=194295
2453
2454         Reviewed by Lucas Forschler.
2455
2456         * BuildSlaveSupport/ews-app/ews/models/build.py:
2457         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2458         * BuildSlaveSupport/ews-app/ews/models/step.py:
2459
2460 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2461
2462         Unreviewed, rolling out r240742.
2463
2464         Causes crashes on iOS simulator.
2465
2466         Reverted changeset:
2467
2468         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2469         not focused in a content-editable element"
2470         https://bugs.webkit.org/show_bug.cgi?id=192824
2471         https://trac.webkit.org/changeset/240742
2472
2473 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2474
2475         run-webkit-tests emits message "...running None" when running tests
2476         https://bugs.webkit.org/show_bug.cgi?id=194133
2477         <rdar://problem/47724738>
2478
2479         Reviewed by Lucas Forschler.
2480
2481         * Scripts/webkitpy/xcode/device_type.py:
2482         (DeviceType.__str__): Use both version mapping tables and use just the variant
2483         name if no version name is available.
2484         * Scripts/webkitpy/xcode/device_type_unittest.py:
2485         (DeviceTypeTest):
2486         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2487         an associated named.
2488
2489 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2490
2491         [WPE] require python3-setuptools for meson build in jhbuild
2492         https://bugs.webkit.org/show_bug.cgi?id=194287
2493
2494         Reviewed by Philippe Normand.
2495
2496         python3-setuptools is needed to build meson in jhbuild.
2497         It is already required by the GTK port.
2498
2499         * wpe/install-dependencies:
2500
2501 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2502
2503         [ews-app] Add method to save BuilderMapping to database
2504         https://bugs.webkit.org/show_bug.cgi?id=194264
2505
2506         Reviewed by Lucas Forschler.
2507
2508         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2509         (BuilderMapping.__str__):
2510         (BuilderMapping):
2511         (BuilderMapping.save_mapping):
2512         (BuilderMapping.update_mapping):
2513         (BuilderMapping.get_existing_mapping):
2514         (BuilderMapping.is_valid_mapping):
2515
2516 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2517
2518         [ews-app] Add timestamp fields for BuilderMappings
2519         https://bugs.webkit.org/show_bug.cgi?id=194266
2520
2521         Reviewed by Lucas Forschler.
2522
2523         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2524         (BuilderMapping):
2525
2526 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2527
2528         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2529         https://bugs.webkit.org/show_bug.cgi?id=174816
2530
2531         Reviewed by Michael Catanzaro.
2532
2533         Add tests for webkit_uri_for_display().
2534
2535         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2536         (testURIForDisplayUnaffected):
2537         (testURIForDisplayAffected):
2538         (beforeAll):
2539         (afterAll):
2540         * TestWebKitAPI/glib/CMakeLists.txt:
2541
2542 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2543
2544         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2545         https://bugs.webkit.org/show_bug.cgi?id=194158
2546         <rdar://problem/47737268>
2547
2548         Rubber-stamped by Aakash Jain.
2549
2550         * Scripts/webkitpy/port/device_port.py:
2551         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2552
2553 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2554
2555         [CG] Enable setAdditionalSupportedImageTypes for WK1
2556         https://bugs.webkit.org/show_bug.cgi?id=194190
2557
2558         Reviewed by Tim Horton.
2559
2560         Add a test similar to the one under WebKit Cocoa but make it create a
2561         WebView instead of a WKWebView.
2562
2563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2564         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2565         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2566         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2567         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2568         (TestWebKitAPI::runTest):
2569         (TestWebKitAPI::TEST):
2570
2571 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2572
2573         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2574         https://bugs.webkit.org/show_bug.cgi?id=194168
2575
2576         Reviewed by Simon Fraser.
2577
2578         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2579
2580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2581         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2582         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2583         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2584         (TEST):
2585         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2586         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2587
2588 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2589
2590         REGRESSION (r237269): webkit-patch what-broke is broken 
2591         https://bugs.webkit.org/show_bug.cgi?id=193025
2592
2593         Reviewed by Aakash Jain.
2594
2595         * Scripts/webkitpy/common/host.py:
2596         (Host.buildbot):
2597         (Host.bugzilla): Renamed to 'buildbot'.
2598
2599 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2600
2601         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2602         https://bugs.webkit.org/show_bug.cgi?id=194207
2603
2604         Reviewed by Tim Horton.
2605
2606         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2607         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2608         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2609         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2610         start and delete forwards to remove the original attachment.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2613         (TestWebKitAPI::TEST):
2614
2615 2019-02-04  Youenn Fablet  <youenn@apple.com>
2616
2617         Capture state should be managed consistently when doing process swapping
2618         https://bugs.webkit.org/show_bug.cgi?id=194122
2619         <rdar://problem/47609293>
2620
2621         Reviewed by Eric Carlson.
2622
2623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2624         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2625         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2626         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2627         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2629         (WTR::TestRunner::isDoingMediaCapture const):
2630         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2631         * WebKitTestRunner/TestController.cpp:
2632         (WTR::TestController::isDoingMediaCapture const):
2633         * WebKitTestRunner/TestController.h:
2634         * WebKitTestRunner/TestInvocation.cpp:
2635         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2637         (WTR::TestController::isDoingMediaCapture const):
2638
2639 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2640
2641         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2642         https://bugs.webkit.org/show_bug.cgi?id=194142
2643
2644         Reviewed by Ross Kirsling.
2645
2646         There three 'separator' variables in TestController.cpp. Renamed
2647         it 'pathSeparator', and unified them.
2648
2649         * WebKitTestRunner/TestController.cpp:
2650         (WTR::TestController::generateContextConfiguration const):
2651         (WTR::createTestURL):
2652         (WTR::TestController::platformAdjustContext):
2653
2654 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2655
2656         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2657         https://bugs.webkit.org/show_bug.cgi?id=194198
2658
2659         Reviewed by Antti Koivisto.
2660
2661         No need to set the banner heights on navigation now, since Page stores them.
2662
2663         * MiniBrowser/mac/WK2BrowserWindowController.m:
2664         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2665
2666 2019-02-03  John Wilander  <wilander@apple.com>
2667
2668         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2669         https://bugs.webkit.org/show_bug.cgi?id=194104
2670         <rdar://problem/47649991>
2671
2672         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2673
2674         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2675         (TestWebKitAPI::TEST):
2676             Changed numeric types from unsigned short to uint32_t.
2677
2678 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2679
2680         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2681         <https://webkit.org/b/194178>
2682         <rdar://problem/47753473>
2683
2684         Reviewed by Alexey Proskuryakov.
2685
2686         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2687         (WTR::uninstallFakeHelvetica): Pass nullptr into
2688         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2689
2690 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2691
2692         [LFC] Initialize ICB's style with fixed width/height.
2693         https://bugs.webkit.org/show_bug.cgi?id=194188
2694
2695         Reviewed by Antti Koivisto.
2696
2697         * LayoutReloaded/misc/LFC-passing-tests.txt:
2698
2699 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2700
2701         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2702         https://bugs.webkit.org/show_bug.cgi?id=194185
2703
2704         Reviewed by Antti Koivisto.
2705
2706         * LayoutReloaded/misc/LFC-passing-tests.txt:
2707
2708 2018-12-16  Darin Adler  <darin@apple.com>
2709
2710         Convert additional String::format clients to alternative approaches
2711         https://bugs.webkit.org/show_bug.cgi?id=192746
2712
2713         Reviewed by Alexey Proskuryakov.
2714
2715         * WebKitTestRunner/TestController.cpp:
2716         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2717         as an intermediate in code that ultimately constructs a WTF::String.
2718         (WTR::userMediaOriginHash): Use makeString.
2719         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2720         (WTR::TestController::didPerformClientRedirect): Ditto.
2721         (WTR::TestController::didPerformServerRedirect): Ditto.
2722         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2723
2724 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2725
2726         [ews-build] Add unit test to verify builder keys
2727         https://bugs.webkit.org/show_bug.cgi?id=194152
2728
2729         Reviewed by Lucas Forschler.
2730
2731         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2732         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2733
2734 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2735
2736         [LFC] Expand tests coverage (12 new tests -> 787)
2737
2738         Unreviewed test gardening.
2739
2740         * LayoutReloaded/misc/LFC-passing-tests.txt:
2741
2742 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2743
2744         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2745         https://bugs.webkit.org/show_bug.cgi?id=194163
2746
2747         Reviewed by Simon Fraser.
2748
2749         775
2750
2751         * LayoutReloaded/misc/LFC-passing-tests.txt:
2752
2753 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2754
2755         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2756         https://bugs.webkit.org/show_bug.cgi?id=194140
2757         <rdar://problem/47728098>
2758
2759         Reviewed by Tim Horton.
2760
2761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2763         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2764
2765         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2766         test to induce an IPC deadlock when presenting a modal alert during touch start.
2767
2768         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2769         * WebKitTestRunner/TestController.cpp:
2770         (WTR::runJavaScriptAlert):
2771
2772         Add a client callback function for running JavaScript alerts.
2773
2774         (WTR::TestController::createOtherPage):
2775         (WTR::TestController::generateContextConfiguration const):
2776
2777         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2778         the fix in this patch.
2779
2780         (WTR::TestController::createWebViewWithOptions):
2781
2782         Plumb TestOptions to generateContextConfiguration.
2783
2784         (WTR::TestController::resetPreferencesToConsistentValues):
2785         (WTR::TestController::resetStateToConsistentValues):
2786         (WTR::updateTestOptionsFromTestHeader):
2787         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2788         (WTR::TestController::handleJavaScriptAlert):
2789         * WebKitTestRunner/TestController.h:
2790         * WebKitTestRunner/TestInvocation.cpp:
2791         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2792         * WebKitTestRunner/TestOptions.h:
2793         (WTR::TestOptions::hasSameInitializationOptions const):
2794
2795 2019-02-01  Chris Dumez  <cdumez@apple.com>
2796
2797         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2798         https://bugs.webkit.org/show_bug.cgi?id=193740
2799         <rdar://problem/47527267>
2800
2801         Reviewed by Alex Christensen.
2802
2803         Add API test coverage.
2804
2805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2806
2807 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2808
2809         [ews-app] Add display name field to BuilderMapping model
2810         https://bugs.webkit.org/show_bug.cgi?id=194153
2811
2812         Reviewed by Lucas Forschler.
2813
2814         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2815         (BuilderMapping):
2816
2817 2019-02-01  Youenn Fablet  <youenn@apple.com>
2818
2819         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2820         https://bugs.webkit.org/show_bug.cgi?id=194155
2821
2822         Reviewed by Eric Carlson.
2823
2824         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2825         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2826         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2827
2828 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2829
2830         [LFC] Adjust replaced element's intrinsic ratio
2831         https://bugs.webkit.org/show_bug.cgi?id=194154
2832
2833         Reviewed by Antti Koivisto.
2834
2835         761
2836
2837         * LayoutReloaded/misc/LFC-passing-tests.txt:
2838
2839 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2840
2841         [WPE] Show test results in minibrowser
2842         https://bugs.webkit.org/show_bug.cgi?id=194150
2843
2844         Reviewed by Žan Doberšek.
2845
2846         * Scripts/webkitpy/port/wpe.py:
2847         (WPEPort.show_results_html_file):
2848
2849 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2850
2851         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2852         https://bugs.webkit.org/show_bug.cgi?id=194151
2853
2854         Reviewed by Žan Doberšek.
2855
2856         ALT + <- go back
2857         ALT + -> go forward
2858
2859         * MiniBrowser/wpe/main.cpp:
2860         (main):
2861
2862 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2863
2864         [LFC] Set intrinsic size on Layout::Replaced
2865         https://bugs.webkit.org/show_bug.cgi?id=194139
2866
2867         Reviewed by Antti Koivisto.
2868
2869         744
2870
2871         * LayoutReloaded/misc/LFC-passing-tests.txt:
2872
2873 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2874
2875         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2876         https://bugs.webkit.org/show_bug.cgi?id=194146
2877
2878         Reviewed by Xabier Rodriguez-Calvar.
2879
2880         It allows to open relative paths.
2881
2882         * MiniBrowser/wpe/main.cpp:
2883         (main):
2884
2885 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2886
2887         Update flakiness dashboard configuration after recent queue changes
2888         https://bugs.webkit.org/show_bug.cgi?id=194127
2889
2890         Rubber-stamped by Aakash Jain.
2891
2892         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2893
2894         * TestResultServer/static-dashboards/builders.jsonp:
2895
2896 2019-01-31  Youenn Fablet  <youenn@apple.com>
2897
2898         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2899         https://bugs.webkit.org/show_bug.cgi?id=194106
2900         <rdar://problem/47676333>
2901
2902         Reviewed by Ryosuke Niwa.
2903
2904         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2905         (TestWebKitAPI::didFinishNavigation):
2906         (TestWebKitAPI::TEST):
2907         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2908
2909 2019-01-31  Chris Dumez  <cdumez@apple.com>
2910
2911         Page zoom level is lost after a process swap or a crash
2912         https://bugs.webkit.org/show_bug.cgi?id=194105
2913         <rdar://problem/47610781>
2914
2915         Reviewed by Alex Christensen.
2916
2917         Add API test coverage.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2920         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2921
2922 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2923
2924         Revert r238819 which is unneeded and caused a performance regression.
2925         https://bugs.webkit.org/show_bug.cgi?id=192272
2926         <rdar://problem/46664625>
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2929         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2930         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2931
2932 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2933
2934         Formalize WebKitAdditions mechanism of LoadOptimizer
2935         https://bugs.webkit.org/show_bug.cgi?id=193886
2936         <rdar://problem/47696809>
2937
2938         Reviewed by Brent Fulgham.
2939
2940         * MiniBrowser/MiniBrowser.entitlements:
2941         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2942
2943 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2944
2945         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2946         https://bugs.webkit.org/show_bug.cgi?id=194090
2947
2948         Reviewed by Antti Koivisto.
2949
2950         * LayoutReloaded/misc/LFC-passing-tests.txt:
2951
2952 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2953
2954         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2955         https://bugs.webkit.org/show_bug.cgi?id=194074
2956
2957         Reviewed by Antti Koivisto.
2958
2959         * LayoutReloaded/misc/LFC-passing-tests.txt:
2960
2961 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2962
2963         [LFC][BFC] Add support for block level replaced box.
2964         https://bugs.webkit.org/show_bug.cgi?id=194071
2965
2966         Reviewed by Antti Koivisto.
2967
2968         * LayoutReloaded/misc/LFC-passing-tests.txt:
2969
2970 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2971
2972         Fix WebKitTestRunner's testPath with Windows full paths
2973         https://bugs.webkit.org/show_bug.cgi?id=194012
2974
2975         Reviewed by Alex Christensen.
2976
2977         updateTestOptionsFromTestHeader failed to open test files because
2978         testPath returned wrong file paths. It returned a path "/C:/..."
2979         if a URL "file:///C:/..." was given.
2980
2981         * WebKitTestRunner/TestController.cpp:
2982         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2983
2984 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         [WPE] Bump font related dependencies to match the GTK+ port
2987         https://bugs.webkit.org/show_bug.cgi?id=194017
2988
2989         Reviewed by Žan Doberšek.
2990
2991         * wpe/jhbuild.modules:
2992         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2993         * wpe/patches/icudata-stdlibs.patch: Added.
2994
2995 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2996
2997         Enable swipe tests on iOS
2998         https://bugs.webkit.org/show_bug.cgi?id=194076
2999
3000         Reviewed by Geoffrey Garen.
3001
3002         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3003         it causes a debug assertion failure in runUIScript.
3004
3005         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3006         (WTR::UIScriptController::beginBackSwipe):
3007         (WTR::UIScriptController::completeBackSwipe):
3008
3009 2019-01-30  Keith Rollin  <krollin@apple.com>
3010
3011         Use correct printf format specifier
3012         https://bugs.webkit.org/show_bug.cgi?id=194062
3013         <rdar://problem/47686167>
3014
3015         Reviewed by Alexey Proskuryakov.
3016
3017         LayoutTestSpellChecker.mm is trying to format a variable of type
3018         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3019         actually an unsigned long long. Fix this by formatting with %llu.
3020
3021         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3022         (-[LayoutTestTextCheckingResult description]):
3023
3024 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3025
3026         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3027         https://bugs.webkit.org/show_bug.cgi?id=193979
3028
3029         Reviewed by Wenson Hsieh.
3030
3031         Fix the test for iOS. Make the test work with iOS UA string.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3034
3035 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3036
3037         Replace High Sierra LLINT CLoop bot due to hardware failure
3038         https://bugs.webkit.org/show_bug.cgi?id=194066
3039
3040         Reviewed by Aakash Jain.
3041
3042         * BuildSlaveSupport/build.webkit.org-config/config.json:
3043
3044 2019-01-30  Keith Rollin  <krollin@apple.com>
3045
3046         [NSDragItem init] is unavailable
3047         https://bugs.webkit.org/show_bug.cgi?id=194059
3048         <rdar://problem/47685715>
3049
3050         Reviewed by Wenson Hsieh.
3051
3052         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3053         DumpRenderTree and TestWebKitAPI, which both try to create an
3054         NSDragItem in a manner that invokes this method. Address this by using
3055         -initWithPasteboardWriter instead.
3056
3057         Note that the parameter passed to initWithPasteboardWriter is likely
3058         incorrect. In both cases, the object passed does not conform to
3059         NSPasteboardWriting. However, with this fix, we're no worse off than
3060         before, and can now perform builds with newer compilers and SDKs until
3061         a real fix can be crafted. That work is tracked in
3062         https://bugs.webkit.org/show_bug.cgi?id=194060
3063
3064         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3065         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3066         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3067         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3068
3069 2019-01-30  Daniel Bates  <dabates@apple.com>
3070
3071         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3072         https://bugs.webkit.org/show_bug.cgi?id=192824
3073         <rdar://problem/47100332>
3074
3075         Reviewed by Wenson Hsieh.
3076
3077         Fix a bug where the wrong usage code was used for F13 thru F24.
3078
3079         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3080         (keyCodeForDOMFunctionKey):
3081
3082 2019-01-30  Chris Dumez  <cdumez@apple.com>
3083
3084         Regression(PSON) Load hang can occur on history navigation
3085         https://bugs.webkit.org/show_bug.cgi?id=194030
3086         <rdar://problem/47656939>
3087
3088         Reviewed by Antti Koivisto.
3089
3090         Add API test coverage.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3093
3094 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3095
3096         [LFC] Expand tests coverage.
3097
3098         Unreviewed test gardening.
3099
3100         * LayoutReloaded/misc/LFC-passing-tests.txt:
3101
3102 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3103
3104         [Flatpak] Add openjpeg support
3105         https://bugs.webkit.org/show_bug.cgi?id=194019
3106
3107         Reviewed by Michael Catanzaro.
3108
3109         * flatpak/org.webkit.CommonModules.yaml:
3110
3111 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3112
3113         Unreviewed, rolling out r240708.
3114         https://bugs.webkit.org/show_bug.cgi?id=194022
3115
3116         It broke WPE build (Requested by KaL on #webkit).
3117
3118         Reverted changeset:
3119
3120         "[WPE] Bump font related dependencies to match the GTK+ port"
3121         https://bugs.webkit.org/show_bug.cgi?id=194017
3122         https://trac.webkit.org/changeset/240708
3123
3124 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3125
3126         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3127         https://bugs.webkit.org/show_bug.cgi?id=194001
3128
3129         Reviewed by Antti Koivisto.
3130
3131         * LayoutReloaded/misc/LFC-passing-tests.txt:
3132
3133 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3134
3135         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3136         https://bugs.webkit.org/show_bug.cgi?id=194020
3137
3138         Reviewed by Antti Koivisto.
3139
3140         * LayoutReloaded/misc/LFC-passing-tests.txt:
3141
3142 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3143
3144         AX: Support color well on iOS
3145         https://bugs.webkit.org/show_bug.cgi?id=194010
3146
3147         Reviewed by Joanmarie Diggs.
3148
3149         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3150         (WTR::AccessibilityUIElement::stringAttributeValue):
3151
3152 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3153
3154         [WPE] Bump font related dependencies to match the GTK+ port
3155         https://bugs.webkit.org/show_bug.cgi?id=194017
3156
3157         Reviewed by Žan Doberšek.
3158
3159         * wpe/jhbuild.modules:
3160         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3161         * wpe/patches/icudata-stdlibs.patch: Added.
3162
3163 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3164
3165         [Mac] Update window scale API usage
3166         https://bugs.webkit.org/show_bug.cgi?id=193991
3167         rdar://problem/47614795
3168
3169         Reviewed by Tim Horton.
3170
3171         * DumpRenderTree/mac/DumpRenderTree.mm:
3172         (changeWindowScaleIfNeeded):
3173         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3174         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3175         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3176
3177 2019-01-29  Chris Dumez  <cdumez@apple.com>
3178
3179         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3180         https://bugs.webkit.org/show_bug.cgi?id=193977
3181         <rdar://problem/47643716>
3182
3183         Reviewed by Geoff Garen.
3184
3185         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3186         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3187         to the previous provisional committing *before* we make the last load. 
3188
3189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3190
3191 2019-01-29  Youenn Fablet  <youenn@apple.com>
3192
3193         Adopt new SPI to evaluate server certificate trust
3194         https://bugs.webkit.org/show_bug.cgi?id=193355
3195
3196         Reviewed by Alex Christensen.
3197
3198         Add infrastructure to handle HTTPS server trust evaluation testing.
3199
3200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3202         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3203         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3204         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3205         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3206         * WebKitTestRunner/TestController.cpp:
3207         (WTR::TestController::resetPreferencesToConsistentValues):
3208         (WTR::TestController::didReceiveAuthenticationChallenge):
3209         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3210         * WebKitTestRunner/TestController.h:
3211         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3212         * WebKitTestRunner/TestInvocation.cpp:
3213         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3214         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3215         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3216
3217 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3218
3219         [ews-build] Add build step to print bot Configuration
3220         https://bugs.webkit.org/show_bug.cgi?id=193887
3221
3222         Reviewed by Lucas Forschler.
3223
3224         * BuildSlaveSupport/ews-build/steps.py:
3225         (PrintConfiguration): Build step to print configuration.
3226         * BuildSlaveSupport/ews-build/factories.py:
3227
3228 2019-01-29  Chris Dumez  <cdumez@apple.com>
3229
3230         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3231         https://bugs.webkit.org/show_bug.cgi?id=193967
3232         <rdar://problem/47635348>
3233
3234         Reviewed by Alex Christensen.
3235
3236         Add API test coverage.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3239         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3240
3241 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3242
3243         [ews-app] Handle incoming results data
3244         https://bugs.webkit.org/show_bug.cgi?id=193973
3245
3246         Reviewed by Lucas Forschler.
3247
3248         * BuildSlaveSupport/ews-app/ews/views/results.py:
3249
3250 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3251
3252         [ews-app] Make the results url generic
3253         https://bugs.webkit.org/show_bug.cgi?id=193928
3254
3255         Reviewed by Lucas Forschler.
3256
3257         * BuildSlaveSupport/ews-app/ews/urls.py:
3258
3259 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3260
3261         [ews-build] Configure buildbot to send events to ews-app
3262         https://bugs.webkit.org/show_bug.cgi?id=193968
3263
3264         Reviewed by Lucas Forschler.
3265
3266         * BuildSlaveSupport/ews-build/events.py: Added.
3267         * BuildSlaveSupport/ews-build/master.cfg:
3268
3269 2019-01-29  Keith Rollin  <krollin@apple.com>
3270
3271         Add .xcfilelists to Run Script build phases
3272         https://bugs.webkit.org/show_bug.cgi?id=193792
3273         <rdar://problem/47201785>
3274
3275         Reviewed by Alex Christensen.
3276
3277         As part of supporting XCBuild, update the necessary Run Script build
3278         phases in their Xcode projects to refer to their associated
3279         .xcfilelist files.
3280
3281         Note that the addition of these files bumps the Xcode project version
3282         number to something that's Xcode 10 compatible. This change means that
3283         older versions of the Xcode IDE can't read these projects. Nor can it
3284         fully load workspaces that refer to these projects (the updated
3285         projects are shown as non-expandable placeholders). `xcodebuild` can
3286         still build these projects; it's just that the IDE can't open them.
3287
3288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3289         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3290
3291 2019-01-29  John Wilander  <wilander@apple.com>
3292
3293         Add data abstraction and validation for Ad Click Attribution
3294         https://bugs.webkit.org/show_bug.cgi?id=193916
3295         <rdar://problem/47603481>
3296
3297         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3298
3299         Ad click attribution has two steps. First, the storage of an ad
3300         campaign ID for a click that takes the user to a destination
3301         site. Second, a conversion on the destination site that can be
3302         attributed to the ad click.
3303
3304         This patch adds a class that represents a request for ad click
3305         attribution. Validation makes sure that the bits of entropy
3306         reported through this mechanism is limited.
3307
3308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3309         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3310         (TestWebKitAPI::TEST):
3311
3312 2019-01-29  Chris Dumez  <cdumez@apple.com>
3313
3314         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3315         https://bugs.webkit.org/show_bug.cgi?id=193932
3316         <rdar://problem/47598947>
3317
3318         Reviewed by Brady Eidson.
3319
3320         Add API test coverage.
3321
3322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3323
3324 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3325
3326         Adding new passing LFC tests.
3327
3328         Unreviewed test gardening.
3329
3330         * LayoutReloaded/misc/LFC-passing-tests.txt:
3331
3332 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3333
3334         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3335         https://bugs.webkit.org/show_bug.cgi?id=193964
3336
3337         Reviewed by Antti Koivisto.
3338
3339         * LayoutReloaded/misc/LFC-passing-tests.txt:
3340
3341 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3342
3343         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3344         https://bugs.webkit.org/show_bug.cgi?id=193954
3345
3346         Reviewed by Antti Koivisto.
3347
3348         * LayoutReloaded/misc/LFC-passing-tests.txt:
3349
3350 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3351
3352         WebDriver: add support for running subtests
3353         https://bugs.webkit.org/show_bug.cgi?id=193904
3354
3355         Reviewed by Michael Catanzaro.
3356
3357         pytest already supports it by passing test.py::subtest, so we can do the same.
3358
3359         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3360         (get_item_name): Made this global.
3361         (CollectRecorder.__init__): Receive the parameter to ignore.
3362         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3363         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3364         (collect): Add parameter to ignore.
3365         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3366         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3367         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3368         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3369         (WebDriverTestRunnerSelenium.run): Ditto.
3370         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3371         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3372         (WebDriverTestRunnerW3C.run): Ditto.
3373
3374 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3375
3376         User agent string override for navigator.userAgent should be site specific quirks
3377         https://bugs.webkit.org/show_bug.cgi?id=193950
3378
3379         Reviewed by Brent Fulgham.
3380
3381         Updated per the _WKWebsitePolicies rename.
3382
3383         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3384         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3385
3386 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3387
3388         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3389         https://bugs.webkit.org/show_bug.cgi?id=193941
3390
3391         Reviewed by Alex Christensen.
3392
3393         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3394         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3395         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3396         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3397         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3398         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3399         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3400         * TestWebKitAPI/Tests/WTF/Time.cpp:
3401         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3402         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3403         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3404         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3405
3406 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3407
3408         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3409
3410         * Scripts/webkitpy/common/config/contributors.json:
3411
3412 2019-01-28  Andy Estes  <aestes@apple.com>
3413
3414         [watchOS] Enable Parental Controls content filtering
3415         https://bugs.webkit.org/show_bug.cgi?id=193939
3416         <rdar://problem/46641912>
3417
3418         Reviewed by Ryosuke Niwa.
3419
3420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3421
3422 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3423
3424         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3425         <https://webkit.org/b/193884>
3426
3427         Reviewed by Jiewen Tan.
3428
3429         * Scripts/webkitpy/style/checkers/cpp.py:
3430         (check_language): Add LocalAuthentication to
3431         `frameworks_with_soft_links`.
3432
3433 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3434
3435         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3436         https://bugs.webkit.org/show_bug.cgi?id=193891
3437
3438         Reviewed by Ross Kirsling.
3439
3440         There were three problems in window sizes of WebView and the host window.
3441         1. The sizes of pixel image output were incorrect.
3442         2. The host window is going to appear after window.resize was invoked.
3443         3. window.resize resized only the host window, not WebView.
3444
3445         This change solves them with a following approach.
3446         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3447         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3448            as well as DumpRenderTree in order to match the client area and the window area.
3449         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3450         d. PlatformWebView::setWindowFrame changes both window sizes.
3451         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3452
3453         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3454         (WTR::PlatformWebView::PlatformWebView): Create the host window
3455         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3456         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3457         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3458
3459 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3460
3461         [ews-app] Add method to save Step data to database
3462         https://bugs.webkit.org/show_bug.cgi?id=193890
3463
3464         Reviewed by Lucas Forschler.
3465
3466         * BuildSlaveSupport/ews-app/ews/models/step.py:
3467         (Step.save_step): Method to save step data.
3468         (Step.update_step): Method to update step data.
3469         (Step.get_existing_step): Method to fetch existing step from database.
3470         (Step.is_valid_result): Method to validate valid step result.
3471
3472 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3473
3474         [ews-app] Add method to save Build data to database
3475         https://bugs.webkit.org/show_bug.cgi?id=193735
3476
3477         Reviewed by Lucas Forschler.
3478
3479         * BuildSlaveSupport/ews-app/ews/models/build.py:
3480         (Build.save_build): Method to save build information to database.
3481         (Build.get_existing_build): Method to fetch existing build from database.
3482         (Build.is_valid_result): Method to validate build result.
3483         * BuildSlaveSupport/ews-app/ews/common/util.py:
3484         (is_valid_int_id): Method to validate valid id.
3485
3486 2019-01-28  Chris Dumez  <cdumez@apple.com>
3487
3488         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3489         https://bugs.webkit.org/show_bug.cgi?id=193915
3490         <rdar://problem/47560907>
3491
3492         Reviewed by Alex Christensen.
3493
3494         Add API test coverage.
3495
3496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3497
3498 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-app] Rename id variables
3501         https://bugs.webkit.org/show_bug.cgi?id=193883
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-app/ews/models/build.py:
3506         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3507         * BuildSlaveSupport/ews-app/ews/models/step.py:
3508         * BuildSlaveSupport/ews-app/ews/urls.py:
3509         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3510         * BuildSlaveSupport/ews-app/ews/views/results.py:
3511         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3512
3513 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3514
3515         [ews-app] Allow certain fields to be empty
3516         https://bugs.webkit.org/show_bug.cgi?id=193892
3517
3518         Reviewed by Lucas Forschler.
3519
3520         * BuildSlaveSupport/ews-app/ews/models/build.py:
3521         * BuildSlaveSupport/ews-app/ews/models/step.py:
3522
3523 2019-01-28  Rob Buis  <rbuis@igalia.com>
3524
3525         Update MIME type parser
3526         https://bugs.webkit.org/show_bug.cgi?id=180526
3527
3528         Reviewed by Frédéric Wang.
3529
3530         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3531         (TestWebKitAPI::TEST):
3532
3533 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3534
3535         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3536         https://bugs.webkit.org/show_bug.cgi?id=193896
3537
3538         Reviewed by Antti Koivisto.
3539
3540         * LayoutReloaded/misc/LFC-passing-tests.txt:
3541
3542 2018-12-15  Darin Adler  <darin@apple.com>
3543
3544         Replace many uses of String::format with more type-safe alternatives
3545         https://bugs.webkit.org/show_bug.cgi?id=192742
3546
3547         Reviewed by Mark Lam.
3548
3549         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3550         (WTR::cacheTestRunnerCallback): Use makeString.
3551         * WebKitTestRunner/TestController.cpp:
3552         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3553         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3554
3555 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3556
3557         Use a load optimizer for some sites
3558         https://bugs.webkit.org/show_bug.cgi?id=193881
3559         <rdar://problem/46325455>
3560
3561         Reviewed by Brent Fulgham.
3562
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3565
3566 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3567
3568         AX: Introduce a static accessibility tree
3569         https://bugs.webkit.org/show_bug.cgi?id=193348
3570         <rdar://problem/47203295>
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3575
3576 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3577
3578         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3579         https://bugs.webkit.org/show_bug.cgi?id=193867
3580
3581         Reviewed by Antti Koivisto.
3582
3583         * LayoutReloaded/misc/LFC-passing-tests.txt:
3584
3585 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3586
3587         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3588         https://bugs.webkit.org/show_bug.cgi?id=193865
3589
3590         Reviewed by Antti Koivisto.
3591
3592         * LayoutReloaded/misc/LFC-passing-tests.txt:
3593
3594 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3595
3596         Need a mechanism to override navigator.userAgent
3597         https://bugs.webkit.org/show_bug.cgi?id=193762
3598         <rdar://problem/47504939>
3599
3600         Reviewed by Brent Fulgham.
3601
3602         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3605         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3606         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3607
3608 2019-01-25  Dean Jackson  <dino@apple.com>
3609
3610         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3611         https://bugs.webkit.org/show_bug.cgi?id=193831
3612         <rdar://problem/47399263>
3613
3614         Reviewed by Chris Dumez.
3615
3616         Two new tests that exercise cross-origin and same-origin System
3617         Previews.
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3620
3621 2019-01-25  Keith Rollin  <krollin@apple.com>
3622
3623         Update Xcode projects with "Check .xcfilelists" build phase
3624         https://bugs.webkit.org/show_bug.cgi?id=193790
3625         <rdar://problem/47201374>
3626
3627         Reviewed by Alex Christensen.
3628
3629         Support for XCBuild includes specifying inputs and outputs to various
3630         Run Script build phases. These inputs and outputs are specified as
3631         .xcfilelist files. Once created, these .xcfilelist files need to be
3632         kept up-to-date. In order to check that they are up-to-date or not,
3633         add an Xcode build step that invokes an external script that performs
3634         the checking. If the .xcfilelists are found to be out-of-date, update
3635         them, halt the build, and instruct the developer to restart the build
3636         with up-to-date files.
3637
3638         At this time, the checking and regenerating is performed only if the
3639         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3640         who want to use this facility can set this variable and test out the
3641         checking/regenerating. Once it seems like there are no egregious
3642         issues that upset a developer's workflow, we'll unconditionally enable
3643         this facility.
3644
3645         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3646         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3647         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3649
3650 2019-01-25  Keith Rollin  <krollin@apple.com>
3651
3652         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3653         https://bugs.webkit.org/show_bug.cgi?id=193781
3654         <rdar://problem/47201153>
3655
3656         Reviewed by Alex Christensen.
3657
3658         Part of generating the .xcfilelists used as part of adopting XCBuild
3659         includes running `make DerivedSources.make` from a standalone script.
3660         It’s important for this invocation to have the same environment as
3661         when the actual build invokes `make DerivedSources.make`. If the
3662         environments are different, then the two invocations will provide
3663         different results. In order to get the same environment in the
3664         standalone script, have the script launch xcodebuild targeting the
3665         "Apply Configuration to XCFileLists" build target, which will then
3666         re-invoke our standalone script. The script is now running again, this
3667         time in an environment with all workspace, project, target, xcconfig
3668         and other environment variables established.
3669
3670         The "Apply Configuration to XCFileLists" build target accomplishes
3671         this task via a small embedded shell script that consists only of:
3672
3673             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3674
3675         The process that invokes "Apply Configuration to XCFileLists" first
3676         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3677         evaluated and exports it into the shell environment. When xcodebuild
3678         is invoked, it inherits the value of this variable and can `eval` the
3679         contents of that variable. Our external standalone script can then set
3680         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3681         of command-line parameters needed to restart itself in the appropriate
3682         state.
3683
3684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3685         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3686
3687 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3688
3689         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3690         https://bugs.webkit.org/show_bug.cgi?id=193802
3691         <rdar://problem/46010580>
3692
3693         Reviewed by Andy Estes.
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3696         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3697         (TEST):
3698
3699 2019-01-25  Daniel Bates  <dabates@apple.com>
3700
3701         [iOS] uiController.keyDown() does not translate Control modified key
3702         https://bugs.webkit.org/show_bug.cgi?id=192898
3703
3704         Reviewed by Wenson Hsieh.
3705
3706         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3707         key translation, as applicable. Among other cases, key translation occurs when performing
3708         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3709         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3710         human pressing down and releasing key(s) using a hardware keyboard.
3711
3712         * WebKitTestRunner/ios/HIDEventGenerator.h:
3713         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3714         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3715
3716         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3717         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3718         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3719         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3720         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3721         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3722         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3723         (-[HIDEventGenerator longPress:completionBlock:]):
3724         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3725         Update code for above renaming.
3726
3727         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3728         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3729
3730         (-[HIDEventGenerator keyDown:]): Added.
3731         (-[HIDEventGenerator keyUp:]): Added.
3732         (-[HIDEventGenerator keyPress:completionBlock:]):
3733         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3734         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3735         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3736         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3737         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3738         (WTR::parseModifier): Deleted.
3739
3740 2019-01-25  Keith Rollin  <krollin@apple.com>
3741
3742         Complete the implementation of generate-xcfilelists
3743         https://bugs.webkit.org/show_bug.cgi?id=193782
3744
3745         Reviewed by Alex Christensen.
3746
3747         A preliminary version of generate-xcfilelists was added in r238008.
3748         This patch updates that script in order to:
3749
3750         - Support checking of .xcfilelists
3751         - Perform better execution of `make DerivedSources.make` by
3752           relaunching generate-xcfilelists under xcodebuild
3753         - Support incremental generation and checking of .xcfilelists
3754         - Support supplementary .xcfilelists files from WebKitAdditions
3755         - Support being wrapped by parallel version of generate-xcfilelists in
3756           Internal that adds support for (re)generating WebKit projects in
3757           that repo.
3758         - Support builds that have been performed in WebKitBuild as well as
3759           ~/Library/Developer/code/DerivedData
3760         - Increase robustness and debugging facilities.
3761
3762         * Scripts/generate-xcfilelists:
3763
3764 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3765
3766         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3767         https://bugs.webkit.org/show_bug.cgi?id=193297
3768         <rdar://problem/47158841>
3769
3770         Unreviewed test case fix.
3771
3772         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3773         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3774
3775         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3776         (TEST):
3777
3778 2019-01-25  Keith Rollin  <krollin@apple.com>
3779
3780         Update existing .xcfilelists
3781         https://bugs.webkit.org/show_bug.cgi?id=193791
3782         <rdar://problem/47201706>
3783
3784         Reviewed by Alex Christensen.
3785
3786         Many .xcfilelist files were added in r238824 in order to support
3787         XCBuild. Update these with recent changes to the set of build files
3788         and with the current generate-xcfilelist script.
3789
3790         * DumpRenderTree/DerivedSources-input.xcfilelist:
3791         * DumpRenderTree/DerivedSources-output.xcfilelist:
3792         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3793         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3794
3795 2019-01-25  Keith Rollin  <krollin@apple.com>
3796
3797         Fix missing dependencies in extract-dependencies-from-makefile
3798         https://bugs.webkit.org/show_bug.cgi?id=193783
3799         <rdar://problem/47201571>
3800
3801         Reviewed by Alex Christensen.
3802
3803         The extract-dependencies-from-makefile script generates .xcfilelists
3804         for XCBuild by invoking a makefile in --debug mode, parsing the
3805         dependency information in the output, and extracting information
3806         regarding targets and dependents. However, the way `make` emits this
3807         dependency information is not rigorous, and so we need to determine
3808         what lines to look for and parse by trial and error. This approach
3809         didn't coriginally atch all the information we needed to collect, so
3810         update the script to look for the additional lines we now know to look
3811         for.
3812
3813         * Scripts/extract-dependencies-from-makefile:
3814         (Parser):
3815         (Parser.addTarget):
3816         (Parser.addPrereq):
3817         (Parser.doParse):
3818
3819 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3820
3821         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3822         https://bugs.webkit.org/show_bug.cgi?id=193297
3823         <rdar://problem/47158841>
3824
3825         Reviewed by Alex Christensen.
3826
3827         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3828             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3830         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3831         activating the message used to trigger the callback when it is set.
3832
3833 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3834
3835         WKWebView.goBack should reload if there is a safe browsing warning
3836         https://bugs.webkit.org/show_bug.cgi?id=193805
3837         <rdar://problem/46908216>
3838
3839         Reviewed by Geoff Garen.
3840
3841         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3842         (+[Simple3LookupContext sharedLookupContext]):
3843         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3844         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3845         (TEST):
3846
3847 2019-01-25  Chris Dumez  <cdumez@apple.com>
3848
3849         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3850         https://bugs.webkit.org/show_bug.cgi?id=193788
3851         <rdar://problem/47531231>
3852
3853         Reviewed by Alex Christensen.
3854
3855         Add API test coverage.
3856
3857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3858         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3859
3860 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3861
3862         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3863         https://bugs.webkit.org/show_bug.cgi?id=193771
3864
3865         Unreviewed infrastructure fix.
3866
3867         * Scripts/webkitpy/port/darwin.py:
3868         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3869
3870 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3871
3872         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3873
3874 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3875
3876         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3877
3878         * Scripts/webkitpy/common/config/contributors.json:
3879
3880 2019-01-25  Chris Dumez  <cdumez@apple.com>
3881
3882         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3883         https://bugs.webkit.org/show_bug.cgi?id=193779
3884         <rdar://problem/46170903>
3885
3886         Reviewed by Antti Koivisto.
3887
3888         Add API test that quickly navigates forward to a previous process without waiting for it to
3889         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3890         the process' previous page when reconnecting the it for the forward navigation.
3891
3892         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3893
3894 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3895
3896         Need a way for JavaScript (or bundle) code to participate in undo
3897         https://bugs.webkit.org/show_bug.cgi?id=190009
3898         <rdar://problem/44807048>
3899
3900         Reviewed by Ryosuke Niwa.
3901
3902         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3903         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3904
3905         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3906         (WTR::UIScriptController::lastUndoLabel const):
3907         (WTR::UIScriptController::firstRedoLabel const):
3908         (WTR::UIScriptController::platformUndoManager const):
3909         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3910         (WTR::UIScriptController::lastUndoLabel const):
3911         (WTR::UIScriptController::firstRedoLabel const):
3912         (WTR::UIScriptController::platformUndoManager const):
3913         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3914         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3915         (WTR::UIScriptController::lastUndoLabel const):
3916         (WTR::UIScriptController::firstRedoLabel const):
3917         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3918         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3919         (WTR::UIScriptController::lastUndoLabel const):
3920         (WTR::UIScriptController::firstRedoLabel const):
3921         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3922         (WTR::UIScriptController::platformUndoManager const):
3923         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3924         (WTR::UIScriptController::platformUndoManager const):
3925
3926 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3927
3928         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3929         https://bugs.webkit.org/show_bug.cgi?id=193824
3930
3931         Reviewed by Antti Koivisto.
3932
3933         * LayoutReloaded/misc/LFC-passing-tests.txt:
3934
3935 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3936
3937         Update macOS JSC bot configurations
3938         https://bugs.webkit.org/show_bug.cgi?id=193739
3939
3940         Reviewed by Alexey Proskuryakov.
3941
3942         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3944         (BubbleQueueServer): Move JSC EWS to Mojave section.
3945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3946         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3947         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3948
3949 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3950
3951         [Win][WebKitTestRunner] Implement EventSenderProxy
3952         https://bugs.webkit.org/show_bug.cgi?id=193755
3953
3954         Reviewed by Don Olmstead.
3955
3956         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3957         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3958         (WTR::EventSenderProxy::dispatchMessage):
3959         (WTR::EventSenderProxy::EventSenderProxy):
3960         (WTR::EventSenderProxy::mouseDown):
3961         (WTR::EventSenderProxy::mouseUp):
3962         (WTR::EventSenderProxy::mouseMoveTo):
3963         (WTR::EventSenderProxy::mouseScrollBy):
3964         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3965
3966 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3967
3968         Unreviewed fix for API test failure after r240437.
3969
3970         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3971
3972         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3973
3974 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3975
3976         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3977         https://bugs.webkit.org/show_bug.cgi?id=193787
3978         <rdar://problem/47497634>
3979
3980         Reviewed by Alexey Proskuryakov.
3981
3982         * Scripts/webkitdirs.pm:
3983         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3984
3985 2019-01-24  Truitt Savell  <tsavell@apple.com>
3986
3987         Unreviewed, rolling out r240446.
3988
3989         Casued 5 API failures
3990
3991         Reverted changeset:
3992
3993         "Activate the WebResourceLoadStatisticsStore in the
3994         NetworkProcess and deactivate it in the UIProcess."
3995         https://bugs.webkit.org/show_bug.cgi?id=193297
3996         https://trac.webkit.org/changeset/240446
3997
3998 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3999
4000         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4001         https://bugs.webkit.org/show_bug.cgi?id=193741
4002         <rdar://problem/47135030>
4003
4004         Reviewed by Antti Koivisto and Simon Fraser.
4005
4006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4007         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4008         (TestWebKitAPI::TEST):
4009
4010 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4011
4012         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4013         https://bugs.webkit.org/show_bug.cgi?id=193297
4014         <rdar://problem/47158841>
4015
4016         Reviewed by Alex Christensen.
4017
4018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4019         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4020         activating the message used to trigger the callback when it is set.
4021
4022 2019-01-24  John Wilander  <wilander@apple.com>
4023
4024         Add Ad Click Attribution as an internal/experimental feature
4025         https://bugs.webkit.org/show_bug.cgi?id=193685
4026         <rdar://problem/47450399>
4027
4028         Reviewed by Brent Fulgham.
4029
4030         Added test option adClickAttributionEnabled.
4031
4032         * DumpRenderTree/TestOptions.cpp:
4033         (TestOptions::TestOptions):
4034         * DumpRenderTree/TestOptions.h:
4035         * DumpRenderTree/mac/DumpRenderTree.mm:
4036         (setWebPreferencesForTestOptions):
4037
4038 2019-01-24  Antti Koivisto  <antti@apple.com>
4039
4040         [PSON] Flash on back navigation on Mac
4041         https://bugs.webkit.org/show_bug.cgi?id=193716
4042         <rdar://problem/47148458>
4043
4044         Reviewed by Chris Dumez.
4045
4046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4047
4048         Closing of the previous page is delayed so waiting for didFinishNavigation is
4049         not sufficient to guarantee we have received all the messages. Wait for them.
4050
4051 2019-01-24  Chris Dumez  <cdumez@apple.com>
4052
4053         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4054         https://bugs.webkit.org/show_bug.cgi?id=193761
4055         <rdar://problem/47456405>
4056
4057         Reviewed by Alex Christensen.
4058
4059         Add API test coverage.
4060
4061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4062
4063 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4064
4065         webkitpy: Missing PID in crashlog name should not be fatal
4066         https://bugs.webkit.org/show_bug.cgi?id=193771
4067
4068         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4069         of raising an exception.
4070
4071         Reviewed by Lucas Forschler.
4072
4073         * Scripts/webkitpy/port/darwin.py:
4074         (DarwinPort._merge_crash_logs):
4075
4076 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4077
4078         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4079         https://bugs.webkit.org/show_bug.cgi?id=193746
4080
4081         Reviewed by Youenn Fablet.
4082
4083         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4084         so we'd best just not call it.
4085
4086         * Scripts/webkitpy/w3c/test_exporter.py:
4087         (WebPlatformTestExporter.create_branch_with_patch):
4088
4089 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4090
4091         Move FileSystem to WTF
4092         https://bugs.webkit.org/show_bug.cgi?id=193602
4093
4094         Reviewed by Yusuke Suzuki.
4095
4096         * DumpRenderTree/win/DumpRenderTree.cpp:
4097         * TestWebKitAPI/CMakeLists.txt:
4098         * TestWebKitAPI/PlatformGTK.cmake:
4099         * TestWebKitAPI/PlatformJSCOnly.cmake:
4100         * TestWebKitAPI/PlatformPlayStation.cmake:
4101         * TestWebKitAPI/PlatformWPE.cmake:
4102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4103         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4104         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4105         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4106         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4107         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4108         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4109         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4110         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4111         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4112
4113 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4114
4115         [WPE] Remove hard dependency on subprocess32 for the API tests
4116
4117         Rubber-stamped by Carlos Garcia Campos.
4118
4119         * glib/api_test_runner.py:
4120         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4121         its presence only when running WPEQt tests.
4122
4123 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4124
4125         [GLIB] Expose JavaScriptCore options in GLib public API
4126         https://bugs.webkit.org/show_bug.cgi?id=188742
4127
4128         Reviewed by Michael Catanzaro.
4129
4130         Add a test for the new API.
4131
4132         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4133         (testsJSCOptions):
4134         (main):
4135
4136 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4137
4138         [GTK][WPE] Support JPEG 2000 images
4139         https://bugs.webkit.org/show_bug.cgi?id=186272
4140
4141         Reviewed by Žan Doberšek.
4142
4143         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4144
4145         * gtk/jhbuild.modules:
4146         * wpe/jhbuild.modules:
4147
4148 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4149
4150         check-webkit-style should warn when using soft-linking macros in a header
4151         <https://webkit.org/b/193750>
4152
4153         Reviewed by Darin Adler.
4154
4155         * Scripts/webkitpy/style/checkers/cpp.py:
4156         (check_language): Add softlink/header check by refactoring the
4157         softlink/framework check.
4158         (CppChecker): Enable softlink/header check by default.
4159         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4160         (CppStyleTest.test_softlink_framework): Rename from
4161         CppStyleTest.test_softlink() and change test framework name in
4162         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4163         files. Set file_name for macros that only appear in headers.
4164         (CppStyleTest.test_softlink_header): Add tests for using
4165         soft-link macros in headers.
4166
4167 2019-01-23  Chris Dumez  <cdumez@apple.com>
4168
4169         Deprecate API to limit the maximum number of WebProcesses
4170         https://bugs.webkit.org/show_bug.cgi?id=193725
4171         <rdar://problem/47464879>
4172
4173         Reviewed by Geoff Garen.
4174
4175         Update existing API tests to stop using deprecated API.
4176
4177         * MiniBrowser/mac/AppDelegate.m:
4178         (defaultConfiguration):
4179         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4180         (TestWebKitAPI::TEST):
4181         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4182         (TestWebKitAPI::TEST):
4183         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4184         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4185         (TEST):
4186         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4187         (TEST):
4188
4189 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4190
4191         [ews-app] Rename ews model buildermappings to buildermapping
4192         https://bugs.webkit.org/show_bug.cgi?id=193729
4193
4194         Reviewed by Lucas Forschler.
4195
4196         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4197         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4198         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4199
4200 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4201
4202         [ews-app] Rename ews model steps to step
4203         https://bugs.webkit.org/show_bug.cgi?id=193697
4204
4205         Reviewed by Lucas Forschler.
4206
4207         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4208         (Step): Renamed Steps to Step.
4209
4210 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4211
4212         Clean up IndexedDB files between tests
4213         https://bugs.webkit.org/show_bug.cgi?id=192796
4214         <rdar://problem/46824999>
4215
4216         Reviewed by Geoffrey Garen.
4217
4218         * DumpRenderTree/mac/DumpRenderTree.mm:
4219         (runTest):
4220         * WebKitTestRunner/TestController.cpp:
4221         (WTR::TestController::resetStateToConsistentValues):
4222         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4223         (WTR::RemoveAllIndexedDatabasesCallback):
4224         (WTR::TestController::ClearIndexedDatabases):
4225         * WebKitTestRunner/TestController.h:
4226         * WebKitTestRunner/TestInvocation.cpp:
4227         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4228
4229 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4230
4231         [ews-app] Rename ews model Builds to Build
4232         https://bugs.webkit.org/show_bug.cgi?id=193695
4233
4234         Reviewed by Lucas Forschler.
4235
4236         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4237         (Build): Renamed Builds to Build.
4238
4239 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4240
4241         webkitpy: Wait longer when launching WebKitTestRunner
4242         https://bugs.webkit.org/show_bug.cgi?id=193734
4243
4244         Reviewed by Aakash Jain.
4245
4246         * Scripts/webkitpy/port/simulator_process.py:
4247         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4248
4249 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4250
4251         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4252         https://bugs.webkit.org/show_bug.cgi?id=193182
4253         <rdar://problem/47452154>
4254
4255         Reviewed by Tim Horton.
4256
4257         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4258         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4259         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4260
4261         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4262         preventing later tests from recognizing gestures.
4263
4264         * WebKitTestRunner/ios/TestControllerIOS.mm:
4265         (WTR::TestController::platformResetStateToConsistentValues):
4266
4267         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4268
4269 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4270
4271         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4272         https://bugs.webkit.org/show_bug.cgi?id=193722
4273         <rdar://problem/47481475>
4274
4275         Reviewed by Lucas Forschler.
4276
4277         iPhone and iPad ports should both use the iOS config.
4278
4279         * Scripts/webkitpy/port/ios_simulator.py:
4280         (IPhoneSimulatorPort.__init__):
4281         (IPadSimulatorPort.__init__):
4282
4283 2019-01-23  Rob Buis  <rbuis@igalia.com>
4284
4285         Update MIME type parser
4286         https://bugs.webkit.org/show_bug.cgi?id=180526
4287
4288         Reviewed by Frédéric Wang.
4289
4290         Add unit tests for both parse modes of ParsedContentType.
4291
4292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4293         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4294         (TestWebKitAPI::TEST):
4295
4296 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4297
4298         [ews-app] fetch loop should not stop on network issues
4299         https://bugs.webkit.org/show_bug.cgi?id=193666
4300
4301         Reviewed by Lucas Forschler.
4302
4303         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4304         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
4305
4306 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4307
4308         [iOS] Multiple WKWebViewAutofillTests are flaky failures
4309         https://bugs.webkit.org/show_bug.cgi?id=189165
4310         <rdar://problem/47433765>
4311
4312         Reviewed by Tim Horton.
4313
4314         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
4315         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
4316         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
4317         process in sufficient to ensure that any previous action that blurred the focused element in the web process
4318         would make its way to the UI process by the time the layer tree commit is finished.
4319
4320         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
4321         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
4322         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
4323         will fail because it asks for -_autofillContext too early.
4324
4325         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
4326         is handled in the UI process.
4327
4328         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4329
4330         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4331         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4332         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
4333         input session.
4334
4335         (-[AutofillTestView textInputHasAutofillContext]):
4336
4337         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
4338
4339         * TestWebKitAPI/cocoa/TestWKWebView.h:
4340         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4341         (nextInputSessionChangeCount):
4342
4343         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
4344         This includes changing the focused element from one to another.
4345
4346         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
4347         (-[TestWKWebView didStartFormControlInteraction]):
4348         (-[TestWKWebView didEndFormControlInteraction]):
4349         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
4350
4351         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
4352         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
4353         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
4354         that doesn't require an input session to one that doesn't.
4355
4356 2019-01-22  David Kilzer  <ddkilzer@apple.com>
4357
4358         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters