[GTK][WPE] outlook.live.com displays old-fashioned UI
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2
3         [GTK][WPE] outlook.live.com displays old-fashioned UI
4         https://bugs.webkit.org/show_bug.cgi?id=196642
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
9         (TestWebKitAPI::TEST): New Mac platform quirk test.
10
11 2019-04-07  Commit Queue  <commit-queue@webkit.org>
12
13         Unreviewed, rolling out r243956.
14         https://bugs.webkit.org/show_bug.cgi?id=196688
15
16         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
17         by aakashjain on #webkit).
18
19         Reverted changeset:
20
21         "Clicking "Go Back" from a safe browsing warning from an
22         iframe should navigate the WKWebView back to the previous
23         page"
24         https://bugs.webkit.org/show_bug.cgi?id=196665
25         https://trac.webkit.org/changeset/243956
26
27 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
28
29         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
30         https://bugs.webkit.org/show_bug.cgi?id=196669
31
32         Reviewed by Geoffrey Garen.
33
34         Added three new unit tests for WeakHashSet.
35
36         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
37         (WTF_WeakPtr.WeakHashSetConstObjects):
38         (WTF_WeakPtr.WeakHashSetComputesEmpty):
39         (WTF_WeakPtr.WeakHashSetComputeSize):
40
41 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
42
43         Hide next and previous form control buttons when WKWebView is editable
44         https://bugs.webkit.org/show_bug.cgi?id=196672
45         <rdar://problem/35625321>
46
47         Reviewed by Tim Horton.
48
49         Add a new API test.
50
51         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
52         (-[TestWKWebView lastTrailingBarButtonGroup]):
53         (TestWebKitAPI::TEST):
54         * TestWebKitAPI/ios/UIKitSPI.h:
55
56 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
57
58         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
59         https://bugs.webkit.org/show_bug.cgi?id=196077
60         <rdar://problem/49108202>
61
62         Reviewed by Chris Dumez.
63
64         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
65         on new web view.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
68
69 2019-04-05  Saam Barati  <sbarati@apple.com>
70
71         Make compare-results understand MotionMark
72         https://bugs.webkit.org/show_bug.cgi?id=196666
73
74         Reviewed by Yusuke Suzuki.
75
76         * Scripts/compare-results:
77         (PLT5Results):
78         (detectMotionMark):
79         (detectMotionMark1_1):
80         (motionMarkResults):
81         (motionMark1_1Results):
82         (detectBenchmark):
83         (biggerIsBetter):
84         (main):
85
86 2019-04-05  Alex Christensen  <achristensen@webkit.org>
87
88         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
89         https://bugs.webkit.org/show_bug.cgi?id=196665
90         <rdar://45115669>
91
92         Reviewed by Geoff Garen.
93
94         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
95         (goBack):
96         (+[SimpleLookupContext sharedLookupContext]):
97         (-[SimpleLookupContext lookUpURL:completionHandler:]):
98         (TEST):
99         (+[Simple3LookupContext sharedLookupContext]): Deleted.
100         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
101
102 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
103
104         [ews-build] Add configuration and architecture for windows builders
105         https://bugs.webkit.org/show_bug.cgi?id=196660
106
107         Reviewed by Lucas Forschler.
108
109         * BuildSlaveSupport/ews-build/config.json:
110
111 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
112
113         webkitpy: Don't run subsequent rounds if interrupted
114         https://bugs.webkit.org/show_bug.cgi?id=196646
115
116         Reviewed by Aakash Jain.
117
118         * Scripts/webkitpy/layout_tests/controllers/manager.py:
119         (Manager.run): Bail out if interrupted.
120
121 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
122
123         Test sessionStorage in PSON private browsing mode
124         https://bugs.webkit.org/show_bug.cgi?id=196561
125
126         Reviewed by Alex Christensen.
127
128         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
129
130 2019-04-05  Commit Queue  <commit-queue@webkit.org>
131
132         Unreviewed, rolling out r243833.
133         https://bugs.webkit.org/show_bug.cgi?id=196645
134
135         This change breaks build of WPE and GTK ports (Requested by
136         annulen on #webkit).
137
138         Reverted changeset:
139
140         "[CMake][WTF] Mirror XCode header directories"
141         https://bugs.webkit.org/show_bug.cgi?id=191662
142         https://trac.webkit.org/changeset/243833
143
144 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
145
146         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
147         https://bugs.webkit.org/show_bug.cgi?id=196635
148
149         Reviewed by Antti Koivisto.
150         
151         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
152         for a test to enable async frame scrolling via:
153             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
154         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
155         
156         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
157
158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
159         (WTR::InjectedBundle::beginTesting):
160         * WebKitTestRunner/TestController.cpp:
161         (WTR::TestController::resetPreferencesToConsistentValues):
162
163 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
164
165         Use a correct LC_RPATH when building with ASan
166         https://bugs.webkit.org/show_bug.cgi?id=196576
167
168         Reviewed by David Kilzer.
169
170         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
171         so that ../Frameworks is checked. This is simpler and more reliable than updating
172         each SPC service xcconfig.
173
174 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
175
176         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
177         https://bugs.webkit.org/show_bug.cgi?id=196629
178
179         Reviewed by Lucas Forschler.
180
181         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
182
183 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
186         https://bugs.webkit.org/show_bug.cgi?id=196618
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
191         (StatusBubble): Added QUEUE_TRIGGERS.
192         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
193         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
194         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
195         its parent(builder).
196
197 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
198
199         [ews-app] Status-bubble steps are sometimes displayed in reverse order
200         https://bugs.webkit.org/show_bug.cgi?id=196625
201
202         Reviewed by Lucas Forschler.
203
204         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
205         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
206
207 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
208
209         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
210         https://bugs.webkit.org/show_bug.cgi?id=196630
211
212         Reviewed by Wenson Hsieh.
213
214         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
215
216 2019-04-04  Youenn Fablet  <youenn@apple.com>
217
218         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
219         https://bugs.webkit.org/show_bug.cgi?id=196543
220
221         Reviewed by Alex Christensen.
222
223         * WebKitTestRunner/TestController.cpp:
224         (WTR::TestController::generatePageConfiguration):
225
226 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
227
228         [ews-app] Status bubble should not display skipped buildbot steps
229         https://bugs.webkit.org/show_bug.cgi?id=196584
230
231         Reviewed by Lucas Forschler.
232
233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
234
235 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
236
237         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
238         https://bugs.webkit.org/show_bug.cgi?id=196620
239
240         Reviewed by Lucas Forschler.
241
242         * BuildSlaveSupport/ews-app/ews/config.py:
243
244 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
245
246         [Win] DumpRenderTreeWatchDog.py is not checked into source
247         https://bugs.webkit.org/show_bug.cgi?id=196567
248         <rdar://problem/49525901>
249
250         Reviewed by Lucas Forschler.
251
252         This script is used on Win EWS bots to terminate hanging DRT processes.
253
254         * EWSTools/dumprendertreewatchdog.py: Added.
255
256 2019-04-04  Chris Dumez  <cdumez@apple.com>
257
258         Unreviewed, roll out r243858 which made tests time out.
259
260         Disable new API tests on Windows instead.
261
262         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
263         (TestWebKitAPI::TEST):
264
265 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
266
267         [ATK] Cleanup WebPageAccessibilityObjectAtk
268         https://bugs.webkit.org/show_bug.cgi?id=196537
269
270         Reviewed by Michael Catanzaro.
271
272         Also consider files under atk directories as exceptions for GObject conventions.
273
274         * Scripts/webkitpy/style/checkers/cpp.py:
275         (check_identifier_name_in_declaration):
276
277 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
278
279         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
280         https://bugs.webkit.org/show_bug.cgi?id=196588
281         <rdar://problem/49365787>
282
283         Unreviewed build fix for Windows port.
284
285         error C3861: 'kill': identifier not found
286
287         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
288         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
289
290 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-build] Cancel build and similar operations should have authentication
293         https://bugs.webkit.org/show_bug.cgi?id=196520
294
295         Reviewed by Dewei Zhu.
296
297         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
298         environment variables.
299
300 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
301
302         [ews-build] Do not trigger queues which are not in production yet
303         https://bugs.webkit.org/show_bug.cgi?id=196581
304
305         Reviewed by Dewei Zhu.
306
307         * BuildSlaveSupport/ews-build/config.json:
308
309 2019-04-03  Chris Dumez  <cdumez@apple.com>
310
311         Unreviewed, fix typo in the name of API test added in r243848.
312
313         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
314         (TestWebKitAPI::TEST):
315
316 2019-04-03  Chris Dumez  <cdumez@apple.com>
317
318         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
319         https://bugs.webkit.org/show_bug.cgi?id=196588
320         <rdar://problem/49365787>
321
322         Reviewed by Ryosuke Niwa.
323
324         Add API test coverage.
325
326         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
327         (TestWebKitAPI::nullJavaScriptCallback):
328         (TestWebKitAPI::didCrashCheckFrames):
329         (TestWebKitAPI::TEST):
330
331 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
332
333         run-webkit-tests: Upload test results (new results database)
334         https://bugs.webkit.org/show_bug.cgi?id=196577
335         <rdar://problem/34841155>
336
337         Reviewed by Lucas Forschler.
338
339         * Scripts/webkitpy/layout_tests/controllers/manager.py:
340         (Manager.run): Upload results after each device shard, since the configuration will be
341         different for each device.
342         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
343         uploaded to a results database.
344         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
345         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
346
347 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
348
349         -apple-trailing-word is needed for browser detection
350         https://bugs.webkit.org/show_bug.cgi?id=196575
351
352         Unreviewed.
353
354         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
355
356 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
357
358         [CMake][WTF] Mirror XCode header directories
359         https://bugs.webkit.org/show_bug.cgi?id=191662
360
361         Reviewed by Konstantin Tokarev.
362
363         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
364         builds.
365
366         * CMakeLists.txt:
367         * DumpRenderTree/CMakeLists.txt:
368         * DumpRenderTree/PlatformWin.cmake:
369         * MiniBrowser/win/CMakeLists.txt:
370         * TestWebKitAPI/CMakeLists.txt:
371         * TestWebKitAPI/PlatformWin.cmake:
372         * WebKitTestRunner/PlatformGTK.cmake:
373         * WebKitTestRunner/PlatformWin.cmake:
374
375 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-app] Status bubble should not display certain infrastructure status messages
378         https://bugs.webkit.org/show_bug.cgi?id=196550
379
380         Reviewed by Lucas Forschler.
381
382         Do not display the steps which are un-needed for end-user. This information is still avaiable
383         if the user click on the bubble and look at the Buildbot build.
384         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
385         (StatusBubble._steps_messages):
386         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
387
388 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
389
390         [ews-build] Use https for sending data to ews-app
391         https://bugs.webkit.org/show_bug.cgi?id=196492
392
393         Reviewed by Lucas Forschler.
394
395         * BuildSlaveSupport/ews-build/events.py:
396
397 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
398
399         Remove support for -apple-trailing-word
400         https://bugs.webkit.org/show_bug.cgi?id=196525
401
402         Reviewed by Zalan Bujtas.
403
404         This CSS property is nonstandard and not used.
405
406         * Scripts/webkitperl/FeatureList.pm:
407         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
408
409 2019-04-03  Youenn Fablet  <youenn@apple.com>
410
411         Add a test for DOMCache on multiple browsing in case of private browsing
412         https://bugs.webkit.org/show_bug.cgi?id=196524
413
414         Reviewed by Alex Christensen.
415
416         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
417         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
418
419 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
420
421         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
422         https://bugs.webkit.org/show_bug.cgi?id=196540
423
424         Reviewed by Aakash Jain.
425
426         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
427
428 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
429
430         Add plumbing for a compatibility mode preference in WebKit
431         https://bugs.webkit.org/show_bug.cgi?id=196005
432
433         Reviewed by Tim Horton.
434
435         Add new API tests.
436
437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
438         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
439
440 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
441
442         [WPE][GTK] Update libsrtp dependency package for Debian
443         https://bugs.webkit.org/show_bug.cgi?id=196528
444
445         Reviewed by Frédéric Wang.
446
447         * gtk/install-dependencies:
448         * wpe/install-dependencies:
449
450 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
451
452         [WK2] Add support for Window's beforeprint / afterprint events
453         https://bugs.webkit.org/show_bug.cgi?id=196478
454         <rdar://problem/49535124>
455
456         Unreviewed build fix for MSVC.
457
458         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
459
460         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
461
462         * WebKitTestRunner/TestController.cpp:
463         (WTR::printFrame): Use int and float literals.
464
465 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-build] Reassign bots to queues
468
469         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
470
471 2019-04-02  Chris Dumez  <cdumez@apple.com>
472
473         [WK2] Add support for Window's beforeprint / afterprint events
474         https://bugs.webkit.org/show_bug.cgi?id=196478
475
476         Reviewed by Alex Christensen.
477
478         Add minimal implementation for printFrame in WebKitTestRunner.
479
480         * WebKitTestRunner/TestController.cpp:
481         (WTR::printFrame):
482         (WTR::TestController::createOtherPage):
483         (WTR::TestController::createWebViewWithOptions):
484
485 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
488         https://bugs.webkit.org/show_bug.cgi?id=196491
489
490         Reviewed by Lucas Forschler.
491
492         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
493
494 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
495
496         [ews-build] Configure buildbot try credentials in environment variables
497         https://bugs.webkit.org/show_bug.cgi?id=196501
498
499         Reviewed by Lucas Forschler.
500
501         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
502         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
503         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
504
505 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
506
507         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
508         https://bugs.webkit.org/show_bug.cgi?id=196496
509         <rdar://problem/49521634>
510
511         Reviewed by Chris Dumez.
512
513         Add new API tests (see WebKit ChangeLog for more detail).
514
515         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
516         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
517         (TEST):
518
519 2019-04-02  David Kilzer  <ddkilzer@apple.com>
520
521         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
522         <https://webkit.org/b/196499>
523
524         Reviewed by Alexey Proskuryakov.
525
526         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
527         ENABLE_ADDRESS_SANITIZER.
528
529 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
530
531         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
532         https://bugs.webkit.org/show_bug.cgi?id=182757
533
534         Reviewed by Don Olmstead.
535
536         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
537         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
538
539 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
540
541         run-api-tests: Upload test results
542         https://bugs.webkit.org/show_bug.cgi?id=196323
543         <rdar://problem/49356714>
544
545         Reviewed by Lucas Forschler.
546
547         * Scripts/webkitpy/api_tests/manager.py:
548         (Manager):
549         (Manager.run): Upload results to a results database.
550         * Scripts/webkitpy/api_tests/run_api_tests.py:
551         (parse_args): Add upload arguments.
552         * Scripts/webkitpy/port/base.py:
553         (Port):
554         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
555         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
556         with commits from any other associated repositories.
557         * Scripts/webkitpy/port/device.py:
558         (Device):
559         (Device.build_version): Access build_versoin of underlying platform device.
560         * Scripts/webkitpy/port/ios_simulator_unittest.py:
561         (IOSSimulatorTest):
562         (IOSSimulatorTest.test_configuration_for_upload):
563         * Scripts/webkitpy/port/device_port.py:
564         (DevicePort):
565         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
566         the same as the machine uploading results.
567         * Scripts/webkitpy/port/mac.py:
568         (MacPort):
569         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
570         * Scripts/webkitpy/port/mac_unittest.py:
571         (MacTest):
572         (MacTest.test_configuration_for_upload):
573         * Scripts/webkitpy/xcode/simulated_device.py:
574         (SimulatedDeviceManager._create_device_with_runtime):
575         (SimulatedDevice.__init__): Create simulated device with a build_version.
576         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
577         (test_existing_simulator):
578
579 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
580
581         Remove extra newline characters (Follow-up fix to r243707)
582
583         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
584
585 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
586
587         [ews-app] Use API_KEY to accept results data
588         https://bugs.webkit.org/show_bug.cgi?id=196461
589
590         Reviewed by Dewei Zhu.
591
592         * BuildSlaveSupport/ews-app/ews/views/results.py:
593         (Results.post): Validate EWS_API_KEY before accepting any data.
594         * BuildSlaveSupport/ews-build/events.py:
595         (Events.sendData): Send EWS_API_KEY if available along with event data.
596
597 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         Unable to copy and paste a PDF from Notes into Mail compose body
600         https://bugs.webkit.org/show_bug.cgi?id=196442
601         <rdar://problem/48573098>
602
603         Reviewed by Tim Horton.
604
605         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
606         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
607         to be specified on the item providers.
608
609         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
610         (TestWebKitAPI::mapItemForTesting):
611         (TestWebKitAPI::contactItemForTesting):
612
613 2019-04-01  Tim Horton  <timothy_horton@apple.com>
614
615         Make UIWKDocumentContext rects per-character instead of per-word
616         https://bugs.webkit.org/show_bug.cgi?id=196459
617
618         Reviewed by Wenson Hsieh.
619
620         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
621         (TEST):
622         Adjust test results due to switching to per-character rects.
623
624 2019-04-01  Chris Dumez  <cdumez@apple.com>
625
626         UIProcess crash when a prewarmed process is terminated
627         https://bugs.webkit.org/show_bug.cgi?id=196451
628         <rdar://problem/49245471>
629
630         Reviewed by Geoffrey Garen.
631
632         Add API test coverage.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
635         (TEST):
636
637 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
638
639         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
640         https://bugs.webkit.org/show_bug.cgi?id=196449
641
642         Reviewed by Lucas Forschler.
643
644         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
645         (StatusBubble.get_os_details): Method to get OS and Xcode details.
646         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
647         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
648
649 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
650
651         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
652         https://bugs.webkit.org/show_bug.cgi?id=196444
653
654         Reviewed by Lucas Forschler.
655
656         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
657
658 2019-04-01  Alex Christensen  <achristensen@webkit.org>
659
660         Add SPI to canonicalize NSURLs with WTF::URL
661         https://bugs.webkit.org/show_bug.cgi?id=196415
662         <rdar://problem/44980271>
663
664         Reviewed by Darin Adler.
665
666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
668         (TestWebKitAPI::TEST):
669
670 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
671
672         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
673         https://bugs.webkit.org/show_bug.cgi?id=196441
674
675         Reviewed by Carlos Garcia Campos.
676
677         Don't cache the wpe_view_backend object that might not exist yet at the
678         time of EventSenderProxy constructor invocation, but instead retrieve
679         that object whenever it's required for event dispatching. This should
680         avoid crashes in this constructor now that it's invoked before any
681         PlatformWindow has been set up (as changed in r243496).
682
683         * WebKitTestRunner/EventSenderProxy.h:
684         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
685         (WTR::viewBackend):
686         (WTR::EventSenderProxy::EventSenderProxy):
687         (WTR::EventSenderProxy::mouseDown):
688         (WTR::EventSenderProxy::mouseUp):
689         (WTR::EventSenderProxy::mouseMoveTo):
690         (WTR::EventSenderProxy::mouseScrollBy):
691         (WTR::EventSenderProxy::keyDown):
692         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
693
694 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
695
696         [Win][WebKit] MiniBrowser should support high DPI display
697         https://bugs.webkit.org/show_bug.cgi?id=196391
698
699         Reviewed by Alex Christensen.
700
701         * MiniBrowser/win/WebKitBrowserWindow.cpp:
702         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
703         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
704         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
705
706 2019-03-31  Sam Weinig  <weinig@apple.com>
707
708         Remove more i386 specific configurations
709         https://bugs.webkit.org/show_bug.cgi?id=196430
710
711         Reviewed by Alexey Proskuryakov.
712
713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
714         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
715
716 2019-03-31  Andy Estes  <aestes@apple.com>
717
718         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
719         https://bugs.webkit.org/show_bug.cgi?id=196433
720         <rdar://problem/49293305>
721
722         Reviewed by Tim Horton.
723
724         Enhanced API test coverage to include all navigation response policy decisions in both
725         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
726
727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
728         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
729         (TestWebKitAPI::TEST):
730         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
731         (readFile):
732         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
733         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
734         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
735         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
736         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
737         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
738         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
739         (-[QuickLookDelegate _downloadDidStart:]):
740         (-[QuickLookDelegate _download:didReceiveResponse:]):
741         (-[QuickLookDelegate _download:didReceiveData:]):
742         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
743         (-[QuickLookDelegate _downloadDidFinish:]):
744         (-[QuickLookDelegate _download:didFailWithError:]):
745         (-[QuickLookDelegate _downloadDidCancel:]):
746         (-[QuickLookDelegate verifyDownload]):
747         (runTest):
748         (runTestDecideBeforeLoading):
749         (runTestDecideAfterLoading):
750         (TEST):
751         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
752         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
753         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
754         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
755         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
756         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
757         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
758         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
759         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
760         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
761         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
762         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
763         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
764         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
765
766 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
767
768         [CMake] add testdfg as target with build-jsc
769         https://bugs.webkit.org/show_bug.cgi?id=196393
770
771         Reviewed by Saam Barati.
772
773         Added testdfg as one of the targets to build when
774         using CMake.
775
776         * Scripts/build-jsc:
777
778 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
779
780         Delete WebMetal implementation in favor of WebGPU
781         https://bugs.webkit.org/show_bug.cgi?id=195418
782
783         Reviewed by Dean Jackson.
784
785         * DumpRenderTree/mac/DumpRenderTree.mm:
786         (enableExperimentalFeatures):
787         (resetWebPreferencesToConsistentValues):
788         * Scripts/webkitperl/FeatureList.pm:
789         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
791         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
792         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
793         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
794         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
795         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
796         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
797         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
798         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
799         (WTR::InjectedBundle::beginTesting):
800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
801         (WTR::TestRunner::setWebMetalEnabled): Deleted.
802         * WebKitTestRunner/InjectedBundle/TestRunner.h:
803
804 2019-03-29  Chris Dumez  <cdumez@apple.com>
805
806         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
807         https://bugs.webkit.org/show_bug.cgi?id=196405
808         <rdar://problem/49428130>
809
810         Reviewed by Wenson Hsieh.
811
812         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
813         the popover presentation methods to be no-ops. Use this in the new test added in
814         r243523 so that we do not swizzle those methods for all tests. This is needed because
815         those WatchOS tests rely on the popover getting presented and interactive.
816
817         * WebKitTestRunner/TestController.cpp:
818         (WTR::updateTestOptionsFromTestHeader):
819         * WebKitTestRunner/TestController.h:
820         * WebKitTestRunner/TestOptions.h:
821         (WTR::TestOptions::hasSameInitializationOptions const):
822         * WebKitTestRunner/ios/TestControllerIOS.mm:
823         (WTR::TestController::platformInitialize):
824         (WTR::TestController::platformResetStateToConsistentValues):
825
826 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
827
828         [Curl] Add Server Trust Evaluation Support.
829         https://bugs.webkit.org/show_bug.cgi?id=191646
830
831         Reviewed by Fujii Hironori.
832
833         Implemented MiniBrowser UI for asking if user trusts the server.
834
835         * MiniBrowser/win/Common.cpp:
836         (askServerTrustEvaluation):
837         (replaceString):
838         * MiniBrowser/win/Common.h:
839         * MiniBrowser/win/MiniBrowserLib.rc:
840         * MiniBrowser/win/MiniBrowserLibResource.h:
841         * MiniBrowser/win/WebKitBrowserWindow.cpp:
842         (createPEMString):
843         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
844         (WebKitBrowserWindow::canTrustServerCertificate):
845         * MiniBrowser/win/WebKitBrowserWindow.h:
846
847 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
848
849         Implement ResizeObserver.
850         https://bugs.webkit.org/show_bug.cgi?id=157743
851
852         Reviewed by Simon Fraser.
853
854         Support resizeObserverEnabled webPreferences.
855
856         * DumpRenderTree/TestOptions.cpp:
857         (TestOptions::TestOptions):
858         * DumpRenderTree/TestOptions.h:
859         * DumpRenderTree/mac/DumpRenderTree.mm:
860         (setWebPreferencesForTestOptions):
861         * DumpRenderTree/win/DumpRenderTree.cpp:
862         (enableExperimentalFeatures):
863         * Scripts/webkitperl/FeatureList.pm:
864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
865
866 2019-03-28  John Wilander  <wilander@apple.com>
867
868         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
869         https://bugs.webkit.org/show_bug.cgi?id=196281
870         <rdar://problem/48938748>
871
872         Reviewed by Alex Christensen.
873
874         This patch adds the function isStatisticsHasLocalStorage() to the
875         TestRunner. With it, the page can query the WebsiteDataStore in the
876         UI process to make sure that it sees LocalStorage.
877
878         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
880         (WTR::TestRunner::isStatisticsHasLocalStorage):
881         * WebKitTestRunner/InjectedBundle/TestRunner.h:
882         * WebKitTestRunner/TestController.cpp:
883         (WTR::TestController::isStatisticsHasLocalStorage):
884         * WebKitTestRunner/TestController.h:
885         * WebKitTestRunner/TestInvocation.cpp:
886         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
887
888 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
889
890         API::Data::createWithoutCopying should do a null check before calling CFRelease
891         https://bugs.webkit.org/show_bug.cgi?id=196276
892         <rdar://problem/48059859>
893
894         Reviewed by Alex Christensen.
895
896         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
897
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
900         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
901         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
902         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
903         (TestWebKitAPI::TEST):
904
905 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
906
907         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
908         https://bugs.webkit.org/show_bug.cgi?id=186276
909
910         Reviewed by Carlos Garcia Campos.
911
912         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
913         (webViewLoadChanged):
914         (testWebResourceGetDataError):
915         (testWebResourceGetDataEmpty):
916         (beforeAll):
917         (webViewloadChanged): Deleted.
918
919 2019-03-27  Andy Estes  <aestes@apple.com>
920
921         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
922         https://bugs.webkit.org/show_bug.cgi?id=196317
923
924         Reviewed by Dan Bernstein.
925
926         package-root copies built products into a staging directory using ditto(1), which does not
927         follow symbolic links as it traverses a directory. Now that the files in
928         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
929         itself, these become broken links when ditto'd into the staging directory.
930
931         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
932
933         * Scripts/package-root:
934
935 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
936
937         [ews-app] Update display text of Submit for ews analysis
938         https://bugs.webkit.org/show_bug.cgi?id=196309
939
940         Reviewed by Dewei Zhu.
941
942         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
943
944 2019-03-27  David Kilzer  <ddkilzer@apple.com>
945
946         run-webkit-tests should check for leaks in WebKit processes
947         <https://webkit.org/b/193772>
948         <rdar://problem/46526680>
949
950         Reviewed by Ryosuke Niwa.
951
952         This works by doing the following:
953         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
954           The list of child processes are returned one per line:
955           process.name: pid
956         - Run the "#LIST CHILD PROCESSES" command just before the
957           "#CHECK FOR WORLD LEAKS" command, and store the list of child
958           processes on the ServerProcess object.
959         - When the `--leaks` switch is handled, run check_for_leaks() on
960           each child process after the main test harness.
961
962         * DumpRenderTree/mac/DumpRenderTree.mm:
963         (handleControlCommand):
964         - Use strncmp() instead of strcmp().
965         - Add support for handling "#LIST CHILD PROCESSES" command.
966
967         * Scripts/webkitpy/port/base.py:
968         (Port.check_for_leaks):
969         * Scripts/webkitpy/port/darwin.py:
970         (DarwinPort.check_for_leaks):
971         - Rename redundant 'process_pid' argument to 'process_id'.
972
973         * Scripts/webkitpy/port/driver.py:
974         (Driver.do_post_tests_work):
975         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
976           longer the only command this sends to WebKitTestRunner.
977         - If the `--leaks` switch is present, send the
978           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
979           result using Port.set_webkit_processes().
980         (Driver._parse_child_processes_output):
981         - Add helper method to parse list of child process names and
982           process IDs returned from WebKitTestRunner.
983
984         * Scripts/webkitpy/port/ios_device.py:
985         (IOSDevicePort.check_for_leaks):
986         - Rename redundant 'process_pid' argument to 'process_id'.
987
988         * Scripts/webkitpy/port/leakdetector.py:
989         (LeakDetector._parse_leaks_output):
990         - Return early if there is no leaks_output.
991         (LeakDetector.check_for_leaks):
992         - Rename redundant 'process_pid' argument to 'process_id'.
993
994         * Scripts/webkitpy/port/server_process.py:
995         (ServerProcess.__init__):
996         (ServerProcess.child_processes):
997         (ServerProcess.set_child_processes):
998         - Add instance variable to Port to store list of child process
999           names and process IDs returned from WebKitTestRunner.
1000         (ServerProcess._start):
1001         - Clear self._child_processes.
1002         (ServerProcess.stop):
1003         - If self._child_processes is set, call
1004           self._port.check_for_leaks() for each child process.
1005
1006         * Scripts/webkitpy/port/server_process_unittest.py:
1007         (TrivialMockPort.check_for_leaks):
1008         - Rename redundant 'process_pid' argument to 'process_id'.
1009
1010         * Scripts/webkitpy/port/simulator_process.py:
1011         (SimulatorProcess.stop):
1012         - If self._child_processes is set, call
1013           self._port.check_for_leaks() for each child process.
1014
1015         * Scripts/webkitpy/port/watch_device.py:
1016         (WatchDevicePort.check_for_leaks):
1017         - Rename redundant 'process_pid' argument to 'process_id'.
1018
1019         * WebKitTestRunner/TestController.cpp:
1020         (WTR::TestController::dumpResponse):
1021         - Extract method from findAndDumpWorldLeaks() so that it may be
1022           reused by findAndDumpWebKitProcessIdentifiers().
1023         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1024         - Add method to output process name and process ID of both the
1025           WebContent and Networking processes.
1026         (WTR::TestController::findAndDumpWorldLeaks):
1027         - Fix missing newline in output when there were no abandoned
1028           documents.
1029         - Call dumpResponse() for extracted code.
1030         (WTR::TestController::handleControlCommand):
1031         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1032         - Use strncmp() instead of strcmp().
1033         - Call findAndDumpWebKitProcessIdentifiers() when
1034           "#LIST CHILD PROCESSES" command is sent.
1035         * WebKitTestRunner/TestController.h:
1036         (WTR::TestController::dumpResponse):
1037         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1038         - Declare methods.
1039
1040 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1041
1042         Unreviewed. Add GLib API test cases after r243434.
1043
1044         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1045         (testWebViewActiveURI):
1046         (serverCallback):
1047         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1048         (sendRequestCallback):
1049
1050 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         Geolocation request not complete when watch request was started in a different web process
1053         https://bugs.webkit.org/show_bug.cgi?id=195996
1054
1055         Reviewed by Alex Christensen.
1056
1057         Add a test case.
1058
1059         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1060         (TestWebKitAPI::runJavaScriptAlert):
1061         (TestWebKitAPI::TEST):
1062
1063 2019-03-26  Keith Rollin  <krollin@apple.com>
1064
1065         Update the way generate-xcfilelists returns strings from functions
1066         https://bugs.webkit.org/show_bug.cgi?id=195975
1067         <rdar://problem/49040807>
1068
1069         Reviewed by Dean Jackson.
1070
1071         There are places where generate-xcfilelists executes assignments with
1072         statements like:
1073
1074             FOO=$(some_function)
1075
1076         where "some_function" return a string by echoing it. E.g.
1077
1078             some_function()
1079             {
1080                 echo "Hello, World"
1081             }
1082
1083         This is a common idiom, but it has a problem if "some_function" needs
1084         to call "exit" in an attempt to halt the entire script right then and
1085         there. Since "some_function" is called inside of $(), it's being
1086         executed in a sub-shell. Calling exit in that sub-shell simply exits
1087         that shell; it doesn't not exit the outer shell in which the main part
1088         of the script is still running. As such, the main script keeps
1089         executing when the intent was for the script to halt.
1090
1091         The solution to this is to use a different idiom for returning
1092         strings. The one we now is to pass in the name of the variable to
1093         receive the string result:
1094
1095             some_function()
1096             {
1097                 variable_name=$1
1098                 eval $variable_name ="Hello, World"
1099             }
1100
1101         The call site now looks like
1102
1103             some_function FOO
1104
1105         Because there's no invocation of a sub-shell, some_function can now
1106         call "exit" if it wants to, and the entire script will exit at that
1107         point.
1108
1109         * Scripts/generate-xcfilelists:
1110
1111 2019-03-26  Chris Dumez  <cdumez@apple.com>
1112
1113         Add basic layout test coverage for File Picker on iOS
1114         https://bugs.webkit.org/show_bug.cgi?id=196265
1115
1116         Reviewed by Wenson Hsieh.
1117
1118         Add layout test infrastructure to test the file picker on iOS.
1119
1120         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1121         (WTR::UIScriptController::dismissFilePicker):
1122         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1123         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1124         (WTR::UIScriptController::dismissFilePicker):
1125         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1126         * WebKitTestRunner/TestController.cpp:
1127         (WTR::TestController::createWebViewWithOptions):
1128         (WTR::updateTestOptionsFromTestHeader):
1129         * WebKitTestRunner/TestOptions.h:
1130         (WTR::TestOptions::hasSameInitializationOptions const):
1131         * WebKitTestRunner/ios/TestControllerIOS.mm:
1132         (overridePresentViewController):
1133         (WTR::TestController::platformInitialize):
1134         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1135         (WTR::UIScriptController::dismissFilePicker):
1136
1137 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1138
1139         Implement async paste method on UIWKInteractionViewProtocol
1140         https://bugs.webkit.org/show_bug.cgi?id=196267
1141         <rdar://problem/49236346>
1142
1143         Reviewed by Tim Horton.
1144
1145         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1146         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1147         are now a part of all iOS 12 internal SDKs.
1148
1149         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1150
1151         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1152         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1153
1154         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1155         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1156         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1157         * TestWebKitAPI/ios/UIKitSPI.h:
1158
1159 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] Use PostgreSQL for ews.webkit.org database
1162         https://bugs.webkit.org/show_bug.cgi?id=196270
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1167
1168 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1169
1170         [ews] Reset simctl states on reboot
1171         https://bugs.webkit.org/show_bug.cgi?id=196260
1172
1173         Rubber-stamped by Aakash Jain.
1174
1175         * EWSTools/start-queue-mac.sh:
1176
1177 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1178
1179         [ews-build] Use PostgreSQL for ews-build database
1180         https://bugs.webkit.org/show_bug.cgi?id=196229
1181
1182         Reviewed by Lucas Forschler.
1183
1184         * BuildSlaveSupport/ews-build/master.cfg:
1185
1186 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1187
1188         [ews-build] Get master_hostname dynamically in master.cfg
1189         https://bugs.webkit.org/show_bug.cgi?id=196255
1190
1191         Reviewed by Lucas Forschler.
1192
1193         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1194         send events data in test mode.
1195
1196 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-app] Set db_constraint to False for Foreign Keys
1199         https://bugs.webkit.org/show_bug.cgi?id=196252
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/ews-app/ews/models/build.py:
1204         * BuildSlaveSupport/ews-app/ews/models/step.py:
1205
1206 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1207
1208         [ews-build] is_test_mode_enabled should default to True
1209         https://bugs.webkit.org/show_bug.cgi?id=196248
1210
1211         Reviewed by Lucas Forschler.
1212
1213         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1214
1215 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1216
1217         [ews-app] Add webkitperl to ENABLED_QUEUES
1218         https://bugs.webkit.org/show_bug.cgi?id=196253
1219
1220         Reviewed by Lucas Forschler.
1221
1222         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1223
1224 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1225
1226         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1227         https://bugs.webkit.org/show_bug.cgi?id=196211
1228         rdar://problem/49110552
1229
1230         Reviewed by Tim Horton.
1231
1232         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1233         Make sure that EventSenderProxy always exists when running tests. We used to create
1234         it when resetting before the first test, which is a bit too late.
1235
1236         * WebKitTestRunner/TestController.h:
1237         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1238         (WTR::TestController::platformCreateWebView):
1239         (WTR::TestController::platformCreateOtherPage):
1240         (WTR::TestController::finishCreatingPlatformWebView):
1241         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1242         (WTR::PlatformWebView::PlatformWebView):
1243         Moved some code that made NSWindow use NSEvent during web view creation. We may
1244         need to move more if some other case us found, but this is enough for now.
1245
1246 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         Unreviewed. Fix typo in GLib geolocation API after r243285.
1249
1250         gelocation -> geolocation.
1251
1252         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1253         (testGeolocationManagerWatchPosition):
1254
1255 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1256
1257         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1258         https://bugs.webkit.org/show_bug.cgi?id=196213
1259
1260         Reviewed by Geoff Garen.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1264         (credentialWithIdentityAndKeychainPath):
1265         (-[ChallengeDelegate webView:didFinishNavigation:]):
1266         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1267         (TestWebKitAPI::TEST):
1268
1269 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1270
1271         Expected shouldn't assume its contained types are copyable
1272         https://bugs.webkit.org/show_bug.cgi?id=195986
1273
1274         Reviewed by JF Bastien.
1275
1276         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1277         (TestWebKitAPI::NonCopyable::operator== const):
1278         (TestWebKitAPI::NonCopyable::operator!= const):
1279         (TestWebKitAPI::TEST):
1280
1281 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1282
1283         Remove some now-unnecessary dynamic class lookup
1284         https://bugs.webkit.org/show_bug.cgi?id=196237
1285
1286         Reviewed by Simon Fraser.
1287
1288         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1289         (makeRequest):
1290         (TEST):
1291
1292 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1293
1294         Unreviewed, rolling out r243450.
1295
1296         AppleWin and WinCairo port builds get broken.
1297
1298         Reverted changeset:
1299
1300         "Add test for fix of #196095"
1301         https://bugs.webkit.org/show_bug.cgi?id=196097
1302         https://trac.webkit.org/changeset/243450
1303
1304 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1305
1306         Unreviewed, rolling out r243465.
1307         https://bugs.webkit.org/show_bug.cgi?id=196226
1308
1309         the test doesn't build (Requested by thorton on #webkit).
1310
1311         Reverted changeset:
1312
1313         "Do not terminate the NetworkProcess if a third party
1314         application sends a NSCredential with a SecIdentityRef"
1315         https://bugs.webkit.org/show_bug.cgi?id=196213
1316         https://trac.webkit.org/changeset/243465
1317
1318 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1319
1320         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1321         https://bugs.webkit.org/show_bug.cgi?id=196213
1322
1323         Reviewed by Geoff Garen.
1324
1325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1326         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1327         (credentialWithIdentityAndKeychainPath):
1328         (-[ChallengeDelegate webView:didFinishNavigation:]):
1329         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1330         (TestWebKitAPI::TEST):
1331
1332 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1333
1334         [ews-build] Gracefully handle missing patch_id in events
1335         https://bugs.webkit.org/show_bug.cgi?id=196216
1336
1337         Reviewed by Lucas Forschler.
1338
1339         * BuildSlaveSupport/ews-build/events.py:
1340
1341 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1342
1343         [ews-build] use lz4 compression for improving buildbot performance
1344         https://bugs.webkit.org/show_bug.cgi?id=196155
1345
1346         Reviewed by Lucas Forschler.
1347
1348         * BuildSlaveSupport/ews-build/master.cfg:
1349
1350 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1351
1352         Pull some API testing helper methods out of TestWKWebView
1353         https://bugs.webkit.org/show_bug.cgi?id=196212
1354
1355         Reviewed by Tim Horton.
1356
1357         Refactor some more API testing utility methods, so that they can be used in
1358         tests that do not use TestWKWebView.
1359
1360         * TestWebKitAPI/cocoa/TestWKWebView.h:
1361         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1362         (-[WKWebView loadTestPageNamed:]):
1363         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1364         (-[WKWebView synchronouslyLoadHTMLString:]):
1365         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1366         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1367         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1368         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1369         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1370
1371 2019-03-25  Jer Noble  <jer.noble@apple.com>
1372
1373         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1374         https://bugs.webkit.org/show_bug.cgi?id=196097
1375
1376         Reviewed by Eric Carlson.
1377
1378         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1379
1380         * DumpRenderTree/mac/DumpRenderTree.mm:
1381         (resetWebPreferencesToConsistentValues):
1382         * WebKitTestRunner/TestController.cpp:
1383         (WTR::TestController::resetPreferencesToConsistentValues):
1384
1385 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1386
1387         Pull IPadUserInterfaceSwizzler out into a separate header file
1388         https://bugs.webkit.org/show_bug.cgi?id=196193
1389
1390         Reviewed by Anders Carlsson.
1391
1392         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1393         be used in other API tests.
1394
1395         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1396         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1397         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1398         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1399         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1400         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1401         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1402
1403 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1404
1405         Remove NavigatorContentUtils in WebCore/Modules
1406         https://bugs.webkit.org/show_bug.cgi?id=196070
1407
1408         Reviewed by Alex Christensen.
1409
1410         NavigatorContentUtils was to support the custom scheme spec [1].
1411         However, in WebKit side, no port has supported the feature in
1412         WebKit layer after EFL port was removed. So there has been the
1413         only IDL implementation of the NavigatorContentUtils in WebCore.
1414         So we don't need to keep the implementation in WebCore anymore.
1415
1416         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1417
1418         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1419
1420 2019-03-24  Andy Estes  <aestes@apple.com>
1421
1422         [watchOS] Remove unused Proximity Networking code
1423         https://bugs.webkit.org/show_bug.cgi?id=196188
1424
1425         Reviewed by Tim Horton.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1428         (TEST):
1429
1430 2019-03-23  Keith Miller  <keith_miller@apple.com>
1431
1432         Refactor clz/ctz and fix getLSBSet.
1433         https://bugs.webkit.org/show_bug.cgi?id=196162
1434
1435         Reviewed by Saam Barati.
1436
1437         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1438
1439         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1440         (TestWebKitAPI::TEST):
1441
1442 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1443
1444         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1445         https://bugs.webkit.org/show_bug.cgi?id=196143
1446
1447         Reviewed by Michael Catanzaro.
1448
1449         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1450         directories.
1451
1452         * Scripts/webkitpy/style/checkers/cpp.py:
1453         (check_identifier_name_in_declaration):
1454         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1455         (WebKitStyleTest.test_names):
1456
1457 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1458
1459         [Flatpak] Manifest expanding fails for qt WPE extension
1460         https://bugs.webkit.org/show_bug.cgi?id=196148
1461
1462         Reviewed by Alex Christensen.
1463
1464         * flatpak/flatpakutils.py:
1465         (expand_submodules_recurse): The last recurse manifest expand
1466         iteration might lead to a single module so take it into account
1467         and don't try to recurse further.
1468
1469 2019-03-22  Chris Dumez  <cdumez@apple.com>
1470
1471         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1472         https://bugs.webkit.org/show_bug.cgi?id=195348
1473         <rdar://problem/48622090>
1474
1475         Reviewed by Alex Christensen.
1476
1477         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1478         to NO when test.options().shouldIgnoreMetaViewport is false.
1479
1480         * WebKitTestRunner/ios/TestControllerIOS.mm:
1481         (WTR::TestController::platformConfigureViewForTest):
1482
1483 2019-03-22  Chris Dumez  <cdumez@apple.com>
1484
1485         Prewarmed processes should be usable with any website data store
1486         https://bugs.webkit.org/show_bug.cgi?id=196104
1487
1488         Reviewed by Alex Christensen.
1489
1490         Add API test coverage.
1491
1492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1493         (runInitialWarmedProcessUsedTest):
1494         (TEST):
1495
1496 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1497
1498         Back out local changes to Alex's Subversion working directory
1499
1500         They were accidentally committed.
1501
1502         * Scripts/webkitpy/common/system/abstractexecutive.py:
1503         (AbstractExecutive.wait_newest):
1504         * Scripts/webkitpy/common/system/executive.py:
1505         (Executive.running_pids):
1506         * Scripts/webkitpy/common/system/executive_mock.py:
1507         (MockExecutive.running_pids):
1508         * Scripts/webkitpy/common/system/executive_unittest.py:
1509         (ExecutiveTest.serial_test_running_pids):
1510         * Scripts/webkitpy/port/darwin.py:
1511         (DarwinPort.check_for_leaks):
1512         * Scripts/webkitpy/port/leakdetector.py:
1513         (LeakDetector.check_for_leaks):
1514         - This was the hack attached to Bug 193772.
1515
1516         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1517         (+[WebKitTestRunnerEvent mouseLocation]):
1518         - This works around a crash on an internal build.
1519
1520 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1521
1522         Fix the build after r243354
1523         https://bugs.webkit.org/show_bug.cgi?id=196138
1524         <rdar://problem/49145951>
1525
1526         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1527         (TEST):
1528         * TestWebKitAPI/ios/UIKitSPI.h:
1529
1530 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1531
1532         Adopt UIWKDocumentContext
1533         https://bugs.webkit.org/show_bug.cgi?id=196040
1534         <rdar://problem/48642440>
1535
1536         Reviewed by Ryosuke Niwa.
1537
1538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1539         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1540         (makeRequest):
1541         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1542         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1543         (applyStyle):
1544         (TEST):
1545         Add tests for UIWKDocumentContext.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1548         (TEST):
1549         (recursiveFindWKContentView): Deleted.
1550         * TestWebKitAPI/cocoa/TestWKWebView.h:
1551         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1552         (recursiveFindWKContentView):
1553         (-[TestWKWebView wkContentView]):
1554         * TestWebKitAPI/ios/UIKitSPI.h:
1555         Share the WKContentView finding code between tests.
1556
1557 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1558
1559         [iOS WK2] Turn on async overflow scrolling by default
1560         https://bugs.webkit.org/show_bug.cgi?id=196011
1561         rdar://problem/48453859
1562
1563         Reviewed by Antti Koivisto.
1564         
1565         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1566         since so many basic layout tests have different results when compositing is triggered for
1567         overflow.
1568         
1569         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1570
1571         * WebKitTestRunner/TestController.cpp:
1572         (WTR::TestController::resetPreferencesToConsistentValues):
1573
1574 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1575
1576         [ews-build] Retry API test in case of failures
1577         https://bugs.webkit.org/show_bug.cgi?id=196004
1578
1579         Reviewed by Lucas Forschler.
1580
1581         * BuildSlaveSupport/ews-build/steps.py:
1582         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1583         (CompileWebKitToT.doStepIf): Ditto.
1584         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1585         (ReRunAPITests): Re-run API tests.
1586         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1587         (RunAPITestsWithoutPatch): Run API tests without patch.
1588         (RunAPITestsWithoutPatch.doStepIf):
1589         (RunAPITestsWithoutPatch.hideStepIf):
1590         (RunAPITestsWithoutPatch.evaluateCommand):
1591         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1592         (AnalyzeAPITestsResults.start):
1593         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1594         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1595         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1596         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1597
1598 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1599
1600         [ews-build] Update queues configurations
1601         https://bugs.webkit.org/show_bug.cgi?id=196074
1602
1603         Reviewed by Dewei Zhu.
1604
1605         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1606         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1607
1608 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1609
1610         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1611         https://bugs.webkit.org/show_bug.cgi?id=195680
1612         <rdar://problem/48903534>
1613
1614         Unreviewed infrastructure fix.
1615
1616         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1617         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1618
1619 2019-03-21  Andy Estes  <aestes@apple.com>
1620
1621         [iOS] Apple Pay should be available in documents with no user agent scripts
1622         https://bugs.webkit.org/show_bug.cgi?id=196061
1623         <rdar://problem/48649391>
1624
1625         Reviewed by Brady Eidson.
1626
1627         Added API tests and related infrastructure.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1631         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1632         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1633         (TestWebKitAPI::TEST):
1634         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1635         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1636         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1637         * TestWebKitAPI/cocoa/TestProtocol.mm:
1638         (-[TestProtocol startLoading]):
1639         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1640         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1641         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1642         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1643
1644 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1645
1646         REGRESSSION (r243297): webkitpy tests broken
1647         https://bugs.webkit.org/show_bug.cgi?id=196108
1648
1649         Reviewed by Aakash Jain.
1650
1651         r243297 updated contributors.json, which broke a few unit tests.
1652
1653         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1654         (IRCCommandTest.test_whois):
1655         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1656
1657 2019-03-21  Chris Dumez  <cdumez@apple.com>
1658
1659         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1660         https://bugs.webkit.org/show_bug.cgi?id=196041
1661         <rdar://problem/49083230>
1662
1663         Reviewed by Alex Christensen.
1664
1665         Add API test coverage.
1666
1667         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1668         (TEST):
1669
1670 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1671
1672         Add SPI to inform applications of WKContentRuleList actions
1673         https://bugs.webkit.org/show_bug.cgi?id=195965
1674         <rdar://problem/42664365>
1675
1676         Reviewed by Geoff Garen.
1677
1678         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1679         (TestWebKitAPI::allActionsForResourceLoad):
1680         (TestWebKitAPI::testRequest):
1681         (TestWebKitAPI::TEST_F):
1682         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1683         (Notification::description):
1684         (Notification::operator== const):
1685         (toVector):
1686         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1687         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1688         (makeContentRuleList):
1689         (TEST):
1690         (makeWarnContentRuleList): Deleted.
1691
1692 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1693
1694         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1695         https://bugs.webkit.org/show_bug.cgi?id=196088
1696
1697         Reviewed by Brian Burg.
1698
1699         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1700         Support checks when only one platform is specified. Also deprecate macosx() and
1701         force the use of macos() instead.
1702
1703         * Scripts/webkitpy/style/checkers/cpp.py:
1704         (check_min_versions_of_wk_api_available):
1705         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1706         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1707
1708 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1709
1710         Update status inactive committers' status to 'contributor'.
1711
1712         * Scripts/webkitpy/common/config/contributors.json:
1713
1714 2019-03-21  Xan Lopez  <xan@igalia.com>
1715
1716         [JSC][x86] Drop support for x87 floating point
1717         https://bugs.webkit.org/show_bug.cgi?id=194853
1718
1719         Reviewed by Don Olmstead.
1720
1721         Force SSE2 on x86/32bit builds.
1722
1723         * Scripts/webkitdirs.pm:
1724         (generateBuildSystemFromCMakeProject):
1725
1726 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1727
1728         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1729         https://bugs.webkit.org/show_bug.cgi?id=196073
1730
1731         Reviewed by Michael Catanzaro.
1732
1733         Add test cases to check functions and constructors with no arguments but receiving user data.
1734
1735         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1736         (checkUserData):
1737         (testJSCFunction):
1738         (fooCreateWithUserData):
1739         (testJSCClass):
1740
1741 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1742
1743         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1744
1745         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1746
1747         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1748
1749 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1750
1751         [GTK][WPE] Add API to provide geolocation information
1752         https://bugs.webkit.org/show_bug.cgi?id=195940
1753
1754         Reviewed by Michael Catanzaro.
1755
1756         Add a new test to check the new API.
1757
1758         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1759         (testGeolocationManagerCurrentPosition):
1760         (testGeolocationManagerWatchPosition):
1761         (beforeAll):
1762         (afterAll):
1763         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1764         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1765         (beforeAll): Ditto.
1766         * TestWebKitAPI/glib/CMakeLists.txt:
1767
1768 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [GLib] Returning G_TYPE_OBJECT from a method does not work
1771         https://bugs.webkit.org/show_bug.cgi?id=195574
1772
1773         Reviewed by Michael Catanzaro.
1774
1775         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1776
1777         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1778         (getGFile):
1779         (getParent):
1780         (createGString):
1781         (getGString):
1782         (getGStringCopyWillRaise):
1783         (getGStringCopy):
1784         (getGStringStr):
1785         (getGStringLen):
1786         (freeGString):
1787         (testJSCClass):
1788
1789 2019-03-20  Saam Barati  <sbarati@apple.com>
1790
1791         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1792         https://bugs.webkit.org/show_bug.cgi?id=195721
1793
1794         Reviewed by Filip Pizlo.
1795
1796         * Scripts/run-javascriptcore-tests:
1797
1798 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1799
1800         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1801         https://bugs.webkit.org/show_bug.cgi?id=196049
1802
1803         Reviewed by Tim Horton.
1804
1805         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1806         overflow scrolling in general, so rename it.
1807
1808         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1809
1810 2019-03-20  Daniel Bates  <dabates@apple.com>
1811
1812         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1813         https://bugs.webkit.org/show_bug.cgi?id=196031
1814         <rdar://problem/49078172>
1815
1816         Reviewed by Tim Horton.
1817
1818         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1819         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1820         same code path used when the Done button is pressed to dismiss the <select> picker.
1821
1822         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1823         (TestWebKitAPI::TEST):
1824
1825 2019-03-20  Chris Dumez  <cdumez@apple.com>
1826
1827         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1828         https://bugs.webkit.org/show_bug.cgi?id=196029
1829         <rdar://problem/48954651>
1830
1831         Reviewed by Tim Horton.
1832
1833         Add API test coverage.
1834
1835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1836
1837 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-build] Improve failure summary string for ApplyPatch step
1840         https://bugs.webkit.org/show_bug.cgi?id=195995
1841
1842         Reviewed by Alexey Proskuryakov.
1843
1844         * BuildSlaveSupport/ews-build/steps.py:
1845         (ApplyPatch.getResultSummary): Override getResultSummary.
1846
1847 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1848
1849         AX: Implement support for new meter ARIA role
1850         https://bugs.webkit.org/show_bug.cgi?id=195966
1851
1852         Reviewed by Chris Fleizach.
1853
1854         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1855         to AXLevelIndicator.
1856
1857         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1858
1859 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1860
1861         [WebAuthN] Implement FIDO AppID extension
1862         https://bugs.webkit.org/show_bug.cgi?id=143491
1863         <rdar://problem/48298273>
1864
1865         Reviewed by Brent Fulgham.
1866
1867         Add a test that covers the new flag of convertToU2fSignCommand.
1868
1869         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1870         (TestWebKitAPI::TEST):
1871         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1872         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1873         (TestWebKitAPI::TEST):
1874
1875 2019-03-19  Keith Rollin  <krollin@apple.com>
1876
1877         Add support for more platforms to generate-xcfilelists
1878         https://bugs.webkit.org/show_bug.cgi?id=195977
1879
1880         Reviewed by Alexey Proskuryakov.
1881
1882         generate-xcfilelists incorrectly complains when involved with building
1883         WebKit for iphonesimulator:
1884
1885             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1886             …
1887             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1888
1889         Address this by teaching generate-xcfilelists about more platforms.
1890
1891         * Scripts/generate-xcfilelists:
1892
1893 2019-03-19  John Wilander  <wilander@apple.com>
1894
1895         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1896         https://bugs.webkit.org/show_bug.cgi?id=195923
1897         <rdar://problem/49001272>
1898
1899         Reviewed by Alex Christensen.
1900
1901         This patch does the following to the TestRunner:
1902         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1903         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1904         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1905
1906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1908         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1910         * WebKitTestRunner/TestController.cpp:
1911         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1912         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1913         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1914         * WebKitTestRunner/TestController.h:
1915         * WebKitTestRunner/TestInvocation.cpp:
1916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1917
1918 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1919
1920         [CMake] Support more clang and gcc sanitizers
1921         https://bugs.webkit.org/show_bug.cgi?id=195956
1922
1923         Reviewed by Michael Catanzaro.
1924
1925         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1926
1927 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Improve summary for PrintConfiguration step
1930         https://bugs.webkit.org/show_bug.cgi?id=195945
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-build/steps.py:
1935         (PrintConfiguration.getResultSummary): Override getResultSummary.
1936
1937 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-build] Improve summary for CheckOutSource step
1940         https://bugs.webkit.org/show_bug.cgi?id=195963
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * BuildSlaveSupport/ews-build/steps.py:
1945         (CheckOutSource.getResultSummary):
1946
1947 2019-03-19  Daniel Bates  <dabates@apple.com>
1948
1949         [iOS] Focus not preserved when switching between tabs
1950         https://bugs.webkit.org/show_bug.cgi?id=195820
1951         <rdar://problem/43614450>
1952
1953         Reviewed by Brent Fulgham.
1954
1955         Add tests to ensure that we restore focus when resigning and becoming first responder.
1956
1957         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1958         (TestWebKitAPI::TEST):
1959
1960 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1961
1962         Make WTFLogChannelState and WTFLogLevel enum classes
1963         https://bugs.webkit.org/show_bug.cgi?id=195904
1964
1965         Reviewed by Eric Carlson.
1966
1967         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1968         (TestWebKitAPI::TEST_F):
1969
1970 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1971
1972         [GStreamer][EME] Backported mssdemux protection data crash fix
1973         https://bugs.webkit.org/show_bug.cgi?id=195918
1974
1975         Reviewed by Philippe Normand.
1976
1977         * gstreamer/jhbuild.modules:
1978         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1979
1980 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1981
1982         Unreviewed, rolling out r243132.
1983
1984         Broke GTK build
1985
1986         Reverted changeset:
1987
1988         "Make WTFLogChannelState and WTFLogLevel enum classes"
1989         https://bugs.webkit.org/show_bug.cgi?id=195904
1990         https://trac.webkit.org/changeset/243132
1991
1992 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1993
1994         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1995
1996         * Scripts/webkitdirs.pm:
1997         (builtDylibPathForName): Adjust the shared library name that's changed
1998         with the API version bump in r243073.
1999
2000 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2001
2002         Make WTFLogChannelState and WTFLogLevel enum classes
2003         https://bugs.webkit.org/show_bug.cgi?id=195904
2004
2005         Reviewed by Eric Carlson.
2006
2007         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2008         (TestWebKitAPI::TEST_F):
2009
2010 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2011
2012         Disable flaky test added in r2431100
2013         https://webkit.org/b/195785
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2016         (TestWebKitAPI::TEST):
2017         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2018
2019 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2020
2021         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2022         https://bugs.webkit.org/show_bug.cgi?id=195916
2023
2024         Reviewed by Tim Horton.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2027         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2028
2029 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2030
2031         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2032
2033         * Scripts/webkitpy/common/config/contributors.json:
2034
2035 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2036
2037         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2038         https://bugs.webkit.org/show_bug.cgi?id=195785
2039
2040         Reviewed by Geoffrey Garen.
2041
2042         * TestWebKitAPI/TCPServer.cpp: Added.
2043         (TestWebKitAPI::TCPServer::TCPServer):
2044         (TestWebKitAPI::TCPServer::~TCPServer):
2045         (TestWebKitAPI::TCPServer::socketBindListen):
2046         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2047         * TestWebKitAPI/TCPServer.h: Added.
2048         (TestWebKitAPI::TCPServer::port const):
2049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2050         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2051         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2052         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2053         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2054         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2055         (TestWebKitAPI::respondSlowly):
2056         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2057         (TestWebKitAPI::downloadAtRate):
2058         (TestWebKitAPI::TEST):
2059
2060 2019-03-18  Saam Barati  <sbarati@apple.com>
2061
2062         Add a plan file for JetStream 2
2063         https://bugs.webkit.org/show_bug.cgi?id=190734
2064
2065         Reviewed by Mark Lam.
2066
2067         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2068
2069 2019-03-18  Chris Dumez  <cdumez@apple.com>
2070
2071         Delay WebProcess launch until a load is triggered in a Web view
2072         https://bugs.webkit.org/show_bug.cgi?id=195758
2073         <rdar://problem/48126013>
2074
2075         Reviewed by Geoff Garen.
2076
2077         Add API test coverage. Also update some existing API tests to not expect
2078         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2079
2080         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2081         (TestWebKitAPI::TEST):
2082         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2083         (TestWebKitAPI::TEST):
2084         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2085         (TEST):
2086         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2087         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2088         (TEST):
2089         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2090         (TEST):
2091         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2092
2093 2019-03-18  Xan Lopez  <xan@igalia.com>
2094
2095         [CMake] Prevent potential warning when determining $architecture
2096         https://bugs.webkit.org/show_bug.cgi?id=195891
2097
2098         Reviewed by Michael Catanzaro.
2099
2100         It's possible for generateBuildSystemForCMakeProject to be called
2101         before determineArchitecture() is ever called. This will make the
2102         first eq check with $architecture to be bogus (and print a
2103         warning). Change that to an eq check with architecture(), which
2104         implicitly calls determineArchitecture() if needed, and change all
2105         the other similar cases in the method in the same way to prevent
2106         future bugs like this one.
2107
2108         * Scripts/webkitdirs.pm:
2109         (generateBuildSystemFromCMakeProject):
2110
2111 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2112
2113         [WPE] Tarballs generated with “make dist” cannot build documentation
2114         https://bugs.webkit.org/show_bug.cgi?id=195885
2115
2116         Reviewed by Carlos Garcia Campos.
2117
2118         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2119
2120 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2121
2122         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2123         https://bugs.webkit.org/show_bug.cgi?id=195883
2124
2125         Reviewed by Carlos Garcia Campos.
2126
2127         * gtkdoc/gtkdoc.py:
2128         (GTKDoc._run_command): When commands fail to run, include the full command line for
2129         the program invocation and the output it has generated on the standard error stream.
2130
2131 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2132
2133         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2134         https://bugs.webkit.org/show_bug.cgi?id=195786
2135
2136         Reviewed by Philippe Normand.
2137
2138         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2139         * wpe/jhbuild.modules: Ditto.
2140
2141 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2142
2143         [ews-build] Don't run clean builds on EWS builders
2144         https://bugs.webkit.org/show_bug.cgi?id=195851
2145
2146         Reviewed by Geoffrey Garen.
2147
2148         * BuildSlaveSupport/ews-build/factories.py:
2149
2150 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2151
2152         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2153         https://bugs.webkit.org/show_bug.cgi?id=195849
2154
2155         Reviewed by Chris Dumez.
2156
2157         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2160         (runWebsiteDataStoreCustomPaths):
2161
2162 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2163
2164         webkitpy: Upload test results
2165         https://bugs.webkit.org/show_bug.cgi?id=195755
2166         <rdar://problem/48896182>
2167
2168         Reviewed by Aakash Jain.
2169
2170         Establish a new format for uploading results that is not tied to layout tests, apply
2171         that format to webkitpy tests.
2172
2173         * Scripts/webkitpy/common/checkout/scm/git.py:
2174         (Git.native_branch): Return what branch the current checkout is on.
2175         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2176         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2177         * Scripts/webkitpy/common/checkout/scm/svn.py:
2178         (SVN.native_branch): Ditto.
2179         * Scripts/webkitpy/common/system/platforminfo.py:
2180         (PlatformInfo.build_version): Return a build version for Mac.
2181         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2182         (MockPlatformInfo.__init__):
2183         (MockPlatformInfo.build_version):
2184         * Scripts/webkitpy/results: Added.
2185         * Scripts/webkitpy/results/__init__.py: Added.
2186         * Scripts/webkitpy/results/options.py: Added.
2187         (upload_options): OptParse list for upload options.
2188         * Scripts/webkitpy/results/upload.py: Added.
2189         (Upload): Class which enforces the upload format expected by the results server.
2190         (Upload.Expectations):
2191         (Upload.create_configuration):
2192         (Upload.create_commit):
2193         (Upload.create_details):
2194         (Upload.create_run_stats):
2195         (Upload.create_test_result):
2196         (Upload.__init__):
2197         (Upload.Encoder): Encode Upload object as json.
2198         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2199         * Scripts/webkitpy/results/upload_unittest.py: Added.
2200         * Scripts/webkitpy/test/main.py:
2201         (Tester._parse_args): Add upload arguments.
2202         (Tester._run_tests): Allow results to be uploaded.
2203         * Scripts/webkitpy/test/runner.py:
2204         (Runner.__init__): Record which tests were run, rather than just counting them.
2205         (Runner.handle):
2206         * Scripts/webkitpy/test/runner_unittest.py:
2207         (RunnerTest.test_run):
2208         * Scripts/webkitpy/thirdparty/__init__.py:
2209         (AutoinstallImportHook.find_module): Add requests auto-install.
2210         (AutoinstallImportHook._install_requests):
2211         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2212         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2213
2214 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2215
2216         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2217         https://bugs.webkit.org/show_bug.cgi?id=195810
2218
2219         Reviewed by Tim Horton.
2220
2221         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2222         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2223         ending certain layout tests.
2224
2225         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2226         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2227         (-[TestRunnerWKWebView dealloc]):
2228         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2229
2230         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2231         helper method when destroying the web view, and when resetting state between tests.
2232
2233         * WebKitTestRunner/ios/TestControllerIOS.mm:
2234         (WTR::TestController::platformResetStateToConsistentValues):
2235
2236         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2237
2238 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2239
2240         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2241         https://bugs.webkit.org/show_bug.cgi?id=190350
2242         <rdar://problem/45089503>
2243
2244         Reviewed by Geoffrey Garen.
2245
2246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2247         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2248         (TEST):
2249         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2250         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2251         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2252         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2253         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2254         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2255         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2256         (runTest):
2257         (createDirectories):
2258         (TEST):
2259         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2260         (TEST):
2261         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2262         (TEST):
2263
2264 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2265
2266         Add support to WebPage for getting the contents as an attributed string.
2267         https://bugs.webkit.org/show_bug.cgi?id=195636
2268         rdar://problem/45055697
2269
2270         Reviewed by Tim Horton.
2271
2272         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2273         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2274
2275 2019-03-15  Chris Dumez  <cdumez@apple.com>
2276
2277         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2278         https://bugs.webkit.org/show_bug.cgi?id=195747
2279
2280         Reviewed by Geoff Garen.
2281
2282         Add API test coverage.
2283
2284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2285
2286 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2287
2288         Unreviewed, rolling out r242952.
2289
2290         Causing API failures on iOS Simulator
2291
2292         Reverted changeset:
2293
2294         "[PSON] Make sure the WebProcessCache is leverage when
2295         relaunching a process after termination"
2296         https://bugs.webkit.org/show_bug.cgi?id=195747
2297         https://trac.webkit.org/changeset/242952
2298
2299 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2300
2301         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2302         https://bugs.webkit.org/show_bug.cgi?id=195740
2303
2304         Reviewed by Ross Kirsling.
2305
2306         window.open doesn't work for WebKitBrowserWindow because it is not
2307         implemented yet.
2308
2309         1. Implemented createNewPage callback of WKPageUIClient.
2310         2. Changed MainWindow to take a BrowserWindow factory function
2311           instead of BrowserWindowType to be flexible to create
2312           BrowserWindow with extra settings.
2313         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2314           because it is not relevant with MainWindow anymore.
2315
2316         * MiniBrowser/win/Common.cpp:
2317         (parseCommandLine):
2318         * MiniBrowser/win/Common.h:
2319         (CommandLineOptions::CommandLineOptions):
2320         * MiniBrowser/win/MainWindow.cpp:
2321         (MainWindow::MainWindow):
2322         (MainWindow::create):
2323         (MainWindow::init):
2324         (MainWindow::WndProc):
2325         * MiniBrowser/win/MainWindow.h:
2326         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2327         (PrintWebUIDelegate::createWebViewWithRequest):
2328         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2329         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2330         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2331         (WebKitBrowserWindow::updateProxySettings):
2332         (WebKitBrowserWindow::createNewPage):
2333         * MiniBrowser/win/WebKitBrowserWindow.h:
2334         * MiniBrowser/win/WinMain.cpp:
2335         (wWinMain):
2336
2337 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2338
2339         Make it possible to test scrolling tree layer manipulation more easily
2340         https://bugs.webkit.org/show_bug.cgi?id=195780
2341
2342         Reviewed by Tim Horton.
2343         
2344         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2345         cuts off communication of scrolling tree scrolls back to the web process
2346         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2347         allows tests to trigger scrolls which run the scrolling tree layer positioning
2348         logic, but never get another commit from the web process that might mask
2349         scrolling tree bugs.
2350         
2351         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2352         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2353         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2354
2355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2356         (WTR::UIScriptController::scrollUpdatesDisabled const):
2357         (WTR::UIScriptController::setScrollUpdatesDisabled):
2358         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2359         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2360         (WTR::UIScriptController::scrollUpdatesDisabled const):
2361         (WTR::UIScriptController::setScrollUpdatesDisabled):
2362         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2363         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2364         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2365         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2366         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2367         * WebKitTestRunner/ios/TestControllerIOS.mm:
2368         (WTR::TestController::platformResetStateToConsistentValues):
2369         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2370         (WTR::UIScriptController::scrollUpdatesDisabled const):
2371         (WTR::UIScriptController::setScrollUpdatesDisabled):
2372
2373 2019-03-14  Youenn Fablet  <youenn@apple.com>
2374
2375         Move IDB storage in private browsing mode to NetworkProcess
2376         https://bugs.webkit.org/show_bug.cgi?id=195602
2377
2378         Reviewed by Brady Eidson.
2379
2380         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2381         (TEST):
2382
2383 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2384
2385         [ews-build] Make descriptionDone messages more readable
2386         https://bugs.webkit.org/show_bug.cgi?id=195760
2387
2388         Reviewed by Lucas Forschler.
2389
2390         * BuildSlaveSupport/ews-build/steps.py:
2391         * BuildSlaveSupport/ews-build/steps_unittest.py:
2392
2393 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2394
2395         [ews-build] Generate status-bubble hover-over messages
2396         https://bugs.webkit.org/show_bug.cgi?id=195680
2397
2398         Reviewed by Lucas Forschler.
2399
2400         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2401         (StatusBubble):
2402         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2403         on hover-over.
2404         (StatusBubble._iso_time):
2405         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2406         hover-over message.
2407         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2408
2409 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [ews-app] Gracefully handle the case when state_string is None
2412         https://bugs.webkit.org/show_bug.cgi?id=195753
2413
2414         Reviewed by Lucas Forschler.
2415
2416         * BuildSlaveSupport/ews-app/ews/models/build.py:
2417         * BuildSlaveSupport/ews-app/ews/models/step.py:
2418
2419 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2420
2421         [ews-app] Status bubble display pending for currently running build step
2422         https://bugs.webkit.org/show_bug.cgi?id=195744
2423
2424         Reviewed by Lucas Forschler.
2425
2426         * BuildSlaveSupport/ews-build/events.py:
2427         (Events.stepStarted): If state_string is pending, replace it with step name.
2428
2429 2019-03-14  Chris Dumez  <cdumez@apple.com>
2430
2431         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2432         https://bugs.webkit.org/show_bug.cgi?id=195750
2433
2434         Reviewed by Geoffrey Garen.
2435
2436         Add API test coverage.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2439         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2440         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2441         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2442
2443 2019-03-14  Chris Dumez  <cdumez@apple.com>
2444
2445         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2446         https://bugs.webkit.org/show_bug.cgi?id=195747
2447
2448         Reviewed by Geoff Garen.
2449
2450         Add API test coverage.
2451
2452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2453
2454 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2455
2456         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2457         https://bugs.webkit.org/show_bug.cgi?id=195725
2458         <rdar://problem/48545062>
2459
2460         Reviewed by Tim Horton.
2461
2462         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2463         handler is nil.
2464
2465         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2466         (TestWebKitAPI::TEST):
2467
2468 2019-03-13  Sam Weinig  <sam@webkit.org>
2469
2470         Add utility function to allow easy reverse range-based iteration of a container
2471         https://bugs.webkit.org/show_bug.cgi?id=195542
2472
2473         Reviewed by Antti Koivisto.
2474
2475         * TestWebKitAPI/CMakeLists.txt:
2476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2477         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2478         (TestWebKitAPI::TEST):
2479         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2480
2481 2019-03-13  Chris Dumez  <cdumez@apple.com>
2482
2483         Use a ServiceWorker process per registrable domain
2484         https://bugs.webkit.org/show_bug.cgi?id=195649
2485
2486         Reviewed by Youenn Fablet.
2487
2488         Update API test coverage.
2489
2490         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2491
2492 2019-03-13  Chris Dumez  <cdumez@apple.com>
2493
2494         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2495         https://bugs.webkit.org/show_bug.cgi?id=195684
2496         <rdar://problem/48294714>
2497
2498         Reviewed by Antti Koivisto.
2499
2500         Add API test coverage.
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2503
2504 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2505
2506         [ews-app] Remove unused patch view
2507         https://bugs.webkit.org/show_bug.cgi?id=195669
2508
2509         Reviewed by Lucas Forschler.
2510
2511         * BuildSlaveSupport/ews-app/ews/urls.py:
2512         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2513
2514 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2515
2516         [ews-app] Use Buildbot result code variables
2517         https://bugs.webkit.org/show_bug.cgi?id=195668
2518
2519         Reviewed by Alexey Proskuryakov.
2520
2521         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2522         (Buildbot): Added Buildbot result code variables.
2523         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2524         (StatusBubble._build_bubble): Used Buildbot result code variables.
2525
2526 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2527
2528         [Flatpak] Expand submodule recursively
2529         https://bugs.webkit.org/show_bug.cgi?id=195672
2530
2531         Building WPE with flatpak was impossible without that as it was raising an exception.
2532         Also update wpebackend-fdo to match what is built in jhbuild
2533
2534         Reviewed by Philippe Normand.
2535
2536         * flatpak/flatpakutils.py:
2537         (expand_submodules_recurse):
2538         (expand_manifest):
2539         * flatpak/org.webkit.WPEModules.yaml:
2540
2541 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2542
2543         [ews-app] status bubble should be hidden for certain builds
2544         https://bugs.webkit.org/show_bug.cgi?id=194597
2545
2546         Reviewed by Dewei Zhu.
2547
2548         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2549         (StatusBubble._build_bubble):
2550         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2551         because the patch didn't have relevant changes.
2552         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2553         in production yet.
2554
2555 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2556
2557         [Win] Fix a slew of simple clang-cl warnings.
2558         https://bugs.webkit.org/show_bug.cgi?id=195652
2559
2560         Reviewed by Don Olmstead.
2561
2562         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2563         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2564
2565 2019-03-12  Justin Fan  <justin_fan@apple.com>
2566
2567         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2568         https://bugs.webkit.org/show_bug.cgi?id=195518
2569         <rdar://problem/46322356>
2570
2571         Reviewed by Myles C. Maxfield.
2572
2573         * DumpRenderTree/DerivedSources-input.xcfilelist:
2574         * DumpRenderTree/DerivedSources-output.xcfilelist:
2575
2576 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2577
2578         Unreviewed, rolling out r242825.
2579         https://bugs.webkit.org/show_bug.cgi?id=195648
2580
2581         "Broke webkitpy tests with my change to
2582         lldb_dump_class_layout.py" (Requested by rmorisset on
2583         #webkit).
2584
2585         Reverted changeset:
2586
2587         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2588         classes with suspicious padding"
2589         https://bugs.webkit.org/show_bug.cgi?id=195573
2590         https://trac.webkit.org/changeset/242825
2591
2592 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Show status bubbles while the patch is waiting in queue
2595         https://bugs.webkit.org/show_bug.cgi?id=195618
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2600         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2601         enabled in initial deployment.
2602         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2603         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2604         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2605         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2606         (StatusBubble._build_bubbles_for_patch):
2607
2608 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2609
2610         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2611         https://bugs.webkit.org/show_bug.cgi?id=195573
2612
2613         Reviewed by Simon Fraser.
2614
2615         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2616
2617         * Scripts/dump-class-layout:
2618         (main):
2619         * lldb/lldb_dump_class_layout.py:
2620         (ClassLayout.__init__):
2621         (ClassLayout._compute_padding_recursive):
2622         (LLDBDebuggerInstance.dump_layout_for_classname):
2623         (LLDBDebuggerInstance):
2624         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2625         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2626
2627 2019-03-12  Chris Dumez  <cdumez@apple.com>
2628
2629         Device Orientation access permission should be denied unless explicitly granted by the client
2630         https://bugs.webkit.org/show_bug.cgi?id=195625
2631
2632         Reviewed by Youenn Fablet.
2633
2634         add API test coverage.
2635
2636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2637         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2638         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2639         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2640         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2641         (runDeviceOrientationTest):
2642         (TEST):
2643         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2644         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2645
2646 2019-03-12  Jer Noble  <jer.noble@apple.com>
2647
2648         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2649         https://bugs.webkit.org/show_bug.cgi?id=195137
2650         <rdar://problem/48810307>
2651
2652         Reviewed by Eric Carlson.
2653
2654         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2655         (TestWebKitAPI::TEST):
2656
2657 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2658
2659         [ews-build] Change urls from uat to production
2660         https://bugs.webkit.org/show_bug.cgi?id=195566
2661
2662         Reviewed by Lucas Forschler.
2663
2664         * BuildSlaveSupport/ews-app/ews/config.py:
2665         * BuildSlaveSupport/ews-build/events.py:
2666         * BuildSlaveSupport/ews-build/steps.py:
2667
2668 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-build] change max_builds for local-worker to 1
2671         https://bugs.webkit.org/show_bug.cgi?id=195568
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-build/loadConfig.py:
2676
2677 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2678
2679         Fix the build
2680
2681         * TestRunnerShared/spi/PencilKitTestSPI.h:
2682         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2683
2684 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2685
2686         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2687         https://bugs.webkit.org/show_bug.cgi?id=194131
2688
2689         Reviewed by Michael Catanzaro.
2690
2691         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2692         (uriChanged):
2693         (testUnfinishedSubresourceLoad):
2694         (serverCallback):
2695         (beforeAll):
2696
2697 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2698
2699         WTF::Expected should use std::addressof instead of operator&
2700         https://bugs.webkit.org/show_bug.cgi?id=195604
2701
2702         Reviewed by Myles Maxfield.
2703
2704         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2705         (TestWebKitAPI::Unique::Unique):
2706         (TestWebKitAPI::Unique::operator&):
2707         (TestWebKitAPI::TEST):
2708
2709 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2710
2711         Add Optional to Forward.h.
2712         https://bugs.webkit.org/show_bug.cgi?id=195586
2713
2714         Reviewed by Darin Adler.
2715
2716         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2717         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2718         Remove unnecessary includes from headers.
2719
2720 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2721
2722         Add testing API to hit-test and scroll overflow scrollers
2723         https://bugs.webkit.org/show_bug.cgi?id=195278
2724
2725         Reviewed by Antti Koivisto.
2726         
2727         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2728         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2729         
2730         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2731
2732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2733         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2734         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2735         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2736         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2737         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2738         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2739         (WTR::enclosingScrollViewIncludingSelf):
2740         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2741
2742 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2743
2744         API test WebKit.RequestTextInputContext fails on iOS
2745         https://bugs.webkit.org/show_bug.cgi?id=195585
2746
2747         Reviewed by Wenson Hsieh and Simon Fraser.
2748
2749         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2750         (applyStyle):
2751         (TEST):
2752         Add a viewport, so that the coordinates match up on iOS.
2753         Scroll by moving the UIScrollView's contentOffset.
2754
2755 2019-03-11  Chris Dumez  <cdumez@apple.com>
2756
2757         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2758         https://bugs.webkit.org/show_bug.cgi?id=195506
2759         <rdar://problem/48733477>
2760
2761         Reviewed by Alex Christensen.
2762
2763         Add API test coverage.
2764
2765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2766
2767 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2768
2769         Adding myself to contributors.json
2770
2771         Unreviewed, addming myself to contributors.json .
2772
2773         * Scripts/webkitpy/common/config/contributors.json:
2774
2775 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2776
2777         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2778         https://bugs.webkit.org/show_bug.cgi?id=195511
2779         <rdar://problem/44873269>
2780
2781         Reviewed by Darin Adler.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2784         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2785         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2786         (TEST_F):
2787
2788 2019-03-11  Chris Dumez  <cdumez@apple.com>
2789
2790         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2791         https://bugs.webkit.org/show_bug.cgi?id=195561
2792
2793         Reviewed by Youenn Fablet.
2794
2795         Make sure the JS in the test requests for permission to receive device orientation events.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2798
2799 2019-03-11  Youenn Fablet  <youenn@apple.com>
2800
2801         Allow storage quota increase by default in WTR
2802         https://bugs.webkit.org/show_bug.cgi?id=195541
2803
2804         Reviewed by Geoffrey Garen.
2805
2806         Allow storage quota increase by default in WTR.
2807         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2808         Use this for tests that explicitly need cache increase.
2809
2810         Instead of increasing quota by 2, make sure the next request is
2811         granted by adding all given parameters.
2812
2813         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2815         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2816         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2818         * WebKitTestRunner/TestController.cpp:
2819         (WTR::TestController::setAllowStorageQuotaIncrease):
2820         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2821         * WebKitTestRunner/TestController.h:
2822         * WebKitTestRunner/TestInvocation.cpp:
2823         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2824         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2825         (WTR::TestController::cocoaResetStateToConsistentValues):
2826         (WTR::TestController::setAllowStorageQuotaIncrease):
2827         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2828         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2829         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2830
2831 2019-03-11  Xan Lopez  <xan@igalia.com>
2832
2833         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2834         https://bugs.webkit.org/show_bug.cgi?id=194147
2835
2836         Reviewed by Michael Saboff.
2837
2838         To make --32-bit work correctly on Linux/64bit we need to:
2839
2840         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2841         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2842         unfortunately CMake only allows us to do this during
2843         crosscompilation, which is overkill here.
2844         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2845         pkg-config detection module uses the x86 .pc files instead of the
2846         x86_64 ones.
2847         - Set the -m32 flags for the compiler.
2848
2849         * Scripts/webkitdirs.pm:
2850         (generateBuildSystemFromCMakeProject):
2851
2852 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2853
2854         Add MotionMark-1.1 plan file for run-benchmark script.
2855         https://bugs.webkit.org/show_bug.cgi?id=195481
2856
2857         Rubber-stamped by Darin Adler.
2858
2859         Run-benchmark script should support MontionMark-1.1.
2860
2861         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2862
2863 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-app] Add support for submit-to-ews url
2866         https://bugs.webkit.org/show_bug.cgi?id=195477
2867
2868         Reviewed by Lucas Forschler.
2869
2870         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2871         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2872         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2873         * BuildSlaveSupport/ews-app/ews/urls.py:
2874         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2875
2876 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2877
2878         Unreviewed, rolling out r242688, r242643, r242624.
2879
2880         Caused multiple layout test failures and crashes on iOS and macOS.
2881
2882         Reverted changeset:
2883
2884         "requestAnimationFrame should execute before the next frame"
2885         https://bugs.webkit.org/show_bug.cgi?id=177484
2886         https://trac.webkit.org/changeset/242624/webkit
2887
2888         * Tracing/SystemTracePoints.plist:
2889
2890 2019-03-11  John Wilander  <wilander@apple.com>
2891
2892         Resource Load Statistics: Make it possible exclude localhost from classification
2893         https://bugs.webkit.org/show_bug.cgi?id=195474
2894         <rdar://problem/47520577>
2895
2896         Reviewed by Brent Fulgham.
2897
2898         This patch allows for localhost to be excluded from classification and
2899         treatment as a prevalent resource.
2900
2901         The WebKit Tools change adds a new function called
2902         testRunner.setStatisticsIsRunningTest() which can be used to control this
2903         behavior.
2904
2905         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2906         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2907         (WTR::TestRunner::setStatisticsIsRunningTest):
2908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2909         * WebKitTestRunner/TestController.cpp:
2910         (WTR::TestController::setStatisticsIsRunningTest):
2911         * WebKitTestRunner/TestController.h:
2912         * WebKitTestRunner/TestInvocation.cpp:
2913         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2914
2915 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2916
2917         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2918         https://bugs.webkit.org/show_bug.cgi?id=195560
2919
2920         Reviewed by Lucas Forschler.
2921
2922         * BuildSlaveSupport/ews-build/master.cfg:
2923
2924 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2925
2926         Unreviewed, rolling out r242698.
2927
2928         API test crashes on bots.
2929
2930         Reverted changeset:
2931
2932         "Add a WKContentRuleList variant that uses copied memory
2933         instead of mmap'd shared memory for class A containerized
2934         apps"
2935         https://bugs.webkit.org/show_bug.cgi?id=195511
2936         https://trac.webkit.org/changeset/242698
2937
2938 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2939
2940         [WPE] Enable web process sandbox
2941         https://bugs.webkit.org/show_bug.cgi?id=195169
2942
2943         Reviewed by Daniel Bates.
2944
2945         * wpe/install-dependencies:
2946         * wpe/jhbuild.modules:
2947
2948 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2949
2950         [ews-app] Use port 17000 for worker communication
2951         https://bugs.webkit.org/show_bug.cgi?id=195558
2952
2953         Reviewed by Lucas Forschler.
2954
2955         * BuildSlaveSupport/ews-build/master.cfg:
2956
2957 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews-build] unit-tests fail when passwords.json is missing
2960         https://bugs.webkit.org/show_bug.cgi?id=195557
2961
2962         Reviewed by Lucas Forschler.
2963
2964         * BuildSlaveSupport/ews-build/loadConfig.py:
2965         (loadBuilderConfig):
2966         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2967         (ConfigDotJSONTest.test_configuration):
2968         * BuildSlaveSupport/ews-build/master.cfg:
2969
2970 2019-03-11  Truitt Savell  <tsavell@apple.com>
2971
2972         Unreviewed, rolling out r242702.
2973
2974         Broke High Sierra builders.
2975
2976         Reverted changeset:
2977
2978         "Add utility function to allow easy reverse range-based
2979         iteration of a container"
2980         https://bugs.webkit.org/show_bug.cgi?id=195542
2981         https://trac.webkit.org/changeset/242702
2982
2983 2019-03-11  Sam Weinig  <sam@webkit.org>
2984
2985         Add utility function to allow easy reverse range-based iteration of a container
2986         https://bugs.webkit.org/show_bug.cgi?id=195542
2987
2988         Reviewed by Antti Koivisto.
2989
2990         * TestWebKitAPI/CMakeLists.txt:
2991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2992         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2993         (TestWebKitAPI::TEST):
2994         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2995
2996 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2997
2998         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2999         https://bugs.webkit.org/show_bug.cgi?id=195511
3000         <rdar://problem/44873269>
3001
3002         Reviewed by Darin Adler.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3005         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3006         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3007         (TEST_F):
3008
3009 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3010
3011         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3012         https://bugs.webkit.org/show_bug.cgi?id=195499
3013
3014         Reviewed by Darin Adler.
3015
3016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3017         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3018         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3019         (-[WKWebView synchronouslyFocusTextInputContext:]):
3020         (applyStyle):
3021         (applyIframe):
3022         (TEST):
3023         Add some tests for this SPI.
3024
3025 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3026
3027         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3028         https://bugs.webkit.org/show_bug.cgi?id=181151
3029
3030         Reviewed by Don Olmstead.
3031
3032         * TestWebKitAPI/CMakeLists.txt:
3033         * TestWebKitAPI/PlatformWin.cmake:
3034         Enable TestWTF RunLoop tests in all platforms.
3035
3036         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3037         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3038         (TestWebKitAPI::DerivedOneShotTimer::fired):
3039         (TestWebKitAPI::TEST):
3040         Only a few platforms support nested RunLoop.
3041
3042         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3043         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3044
3045 2019-03-10  David Quesada  <david_quesada@apple.com>
3046
3047         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3048         https://bugs.webkit.org/show_bug.cgi?id=152480
3049
3050         Reviewed by Chris Dumez.
3051
3052         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3053         there are no additional references to the process pool besides the one held by
3054         the download, waits for the download to finish (in the sense that the
3055         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3056         measure, also check that the process pool has been deallocated at the end of the
3057         test. The test wouldn't be meaningful if the process pool were still alive.
3058
3059         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3060         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3061         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3062             The download will be canceled because the delegate does not implement the
3063             method to decide the download's destination, so this is where we know the
3064             DownloadProxyMap is done with the DownloadProxy.
3065         (TEST):
3066
3067 2019-03-08  Chris Dumez  <cdumez@apple.com>
3068
3069         Add support for Device Orientation / Motion permission API
3070         https://bugs.webkit.org/show_bug.cgi?id=195329
3071         <rdar://problem/47645367>
3072
3073         Reviewed by Geoffrey Garen.
3074
3075         Add test infrastructure to help test the Device Orientation / Motion permission API.
3076
3077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3079         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3081         * WebKitTestRunner/TestController.cpp:
3082         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3083         (WTR::TestController::createWebViewWithOptions):
3084         (WTR::TestController::resetStateToConsistentValues):
3085         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3086         * WebKitTestRunner/TestController.h:
3087         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3088         * WebKitTestRunner/TestInvocation.cpp:
3089         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3090
3091 2019-03-08  Saam barati  <sbarati@apple.com>
3092
3093         Add a compare-results script to compare benchmark results
3094         https://bugs.webkit.org/show_bug.cgi?id=195486
3095         <rdar://problem/48723397>
3096
3097         Reviewed by Geoffrey Garen.
3098
3099         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3100         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3101         to extend it to learn about our other benchmarks.
3102
3103         * Scripts/compare-results: Added.
3104         (readJSONFile):
3105         (detectJetStream2):
3106         (JetStream2Results):
3107         (detectSpeedometer2):
3108         (Speedometer2Results):
3109         (detectPLT5):
3110         (PLT5Results):
3111         (detectBenchmark):
3112         (biggerIsBetter):
3113         (ttest):
3114         (getOptions):
3115         (main):
3116
3117 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3118
3119         Ensure old tab state is cleared between iterations of run-benchmark
3120         https://bugs.webkit.org/show_bug.cgi?id=195393
3121         <rdar://problem/46885583>
3122
3123         Reviewed by Dewei Zhu.
3124
3125         a) ensure the default to restore state is not set
3126         b) terminate Safari correctly
3127         c) Set the system default to ignore Persistent State in Safari
3128
3129         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3130         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3131         (OSXBrowserDriver.prepare_env): 
3132         (OSXBrowserDriver.restore_env):
3133         (OSXBrowserDriver.close_browsers):
3134         (OSXBrowserDriver._terminate_processes):
3135         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3136         (OSXChromeDriver):
3137         (OSXChromeCanaryDriver):
3138         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3139         (OSXFirefoxDriver):
3140         (OSXFirefoxNightlyDriver):
3141         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3142         (OSXSafariDriver):
3143         (OSXSafariDriver.prepare_env):
3144
3145 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3146
3147         [GTK] Several InputMethodFilter tests are failing
3148         https://bugs.webkit.org/show_bug.cgi?id=195408
3149
3150         Reviewed by Carlos Garcia Campos.
3151
3152         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3153         Regressed in r241751.
3154         Hexadecimal values of keycodes are expressed now in upper letters.
3155         Composited characters should be cast to UTF8 strings.
3156
3157         (TestWebKitAPI::TEST):
3158
3159 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3160
3161         [GTK] Make Tools/gtkdoc python3 compatible
3162         https://bugs.webkit.org/show_bug.cgi?id=195359
3163
3164         Reviewed by Carlos Garcia Campos.
3165
3166         * gtkdoc/generate-gtkdoc:
3167         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3168         work with Python 2 and 3.
3169         (get_gtkdoc_module_paths):
3170         The iteritems() was removed in Python 3, so let's use items() that's
3171         available in Python 2 and 3.
3172         (get_generator_for_config):
3173         * gtkdoc/gtkdoc.py:
3174         (GTKDoc._run_command):
3175         The sys.stdout.write() is expecting str in Python 3 and not bytes
3176         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3177         for passing the bytes there.
3178
3179 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3180
3181         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3182         https://bugs.webkit.org/show_bug.cgi?id=195346
3183         <rdar://problem/48667048>
3184
3185         Unreviewed build fix for clang-cl.
3186
3187         * DumpRenderTree/win/DumpRenderTree.cpp:
3188         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3189
3190 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3191
3192         requestAnimationFrame should execute before the next frame
3193         https://bugs.webkit.org/show_bug.cgi?id=177484
3194
3195         Reviewed by Simon Fraser.
3196
3197         Add trace points for the page RenderingUpdate.
3198
3199         * Tracing/SystemTracePoints.plist:
3200
3201 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3202
3203         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3204         https://bugs.webkit.org/show_bug.cgi?id=195353
3205         <rdar://problem/48626394>
3206
3207         Reviewed by Simon Fraser.
3208
3209         * WebKitTestRunner/ios/TestControllerIOS.mm:
3210         (WTR::TestController::platformResetPreferencesToConsistentValues):
3211
3212 2019-03-07  John Wilander  <wilander@apple.com>
3213
3214         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3215         https://bugs.webkit.org/show_bug.cgi?id=195383
3216         <rdar://problem/48570136>
3217
3218         Reviewed by Brent Fulgham.
3219
3220         This patch adds test infrastructure to purge only script-accessible cookies,
3221         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3222
3223         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3224         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3225         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3226         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3227         * WebKitTestRunner/TestController.cpp:
3228         (WTR::TestController::statisticsDeleteCookiesForHost):
3229         * WebKitTestRunner/TestController.h:
3230         * WebKitTestRunner/TestInvocation.cpp:
3231         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3232
3233 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3234
3235         Unreviewed, rolling out r242354.
3236         https://bugs.webkit.org/show_bug.cgi?id=195402
3237
3238         breaks layout tests in all configurations (Requested by
3239         zdobersek on #webkit).
3240
3241         Reverted changeset:
3242
3243         "[WPE] Enable web process sandbox"
3244         https://bugs.webkit.org/show_bug.cgi?id=195169
3245         https://trac.webkit.org/changeset/242354
3246
3247 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3248
3249         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3250         https://bugs.webkit.org/show_bug.cgi?id=195346
3251
3252         Reviewed by Fujii Hironori.
3253
3254         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3255         (TestWebKitAPI::TEST):
3256         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3257
3258         * DumpRenderTree/win/DumpRenderTree.cpp:
3259         (findFontFallback):
3260         (addFontFallbackIfPresent):
3261         (removeFontFallbackIfPresent):
3262         (main):
3263         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3264         (TestWebKitAPI::Util::moduleDirectory):
3265         (TestWebKitAPI::Util::createInjectedBundlePath):
3266         Use wchar helpers as needed.
3267
3268 2019-03-06  Rob Buis  <rbuis@igalia.com>
3269
3270         Consider supporting the `referrerpolicy` attribute.
3271         https://bugs.webkit.org/show_bug.cgi?id=179053
3272
3273         Reviewed by Darin Adler.
3274
3275         Add a runtime flag for referrerpolicy attribute.
3276
3277         * DumpRenderTree/mac/DumpRenderTree.mm:
3278         (enableExperimentalFeatures):
3279
3280 2019-03-05  Daniel Bates  <dabates@apple.com>
3281
3282         Update expected API test result following r242379
3283         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3284
3285         Update expected x-coordinate of selection rect now that the left padding of
3286         a textarea is sized in ems (so dependent on the font size) just like the left
3287         padding of a text field.
3288
3289         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3290         (TestWebKitAPI::TEST):
3291
3292 2019-03-05  David Quesada  <david_quesada@apple.com>
3293
3294         [WK2] It should be possible to follow links with 'download' attributes
3295         https://bugs.webkit.org/show_bug.cgi?id=195145
3296         rdar://problem/48462642
3297
3298         Reviewed by Alex Christensen.
3299
3300         Add a unit test to verify that activating links with 'download' attributes now
3301         navigates to the linked resource, rather than starts downloading it. Add another
3302         to verify that it is still possible to explicitly download the link via the
3303         'Download' navigation action policy.
3304
3305         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3306         (-[DownloadAttributeTestDelegate init]):
3307         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3308         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3309         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3310         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3311         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3312         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3313         (TEST):
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::decidePolicyForNavigationAction):
3316         * WebKitTestRunner/TestController.h:
3317
3318 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3319
3320         [Curl] Implement Cookie Accept Policy.
3321         https://bugs.webkit.org/show_bug.cgi?id=191645
3322
3323         Reviewed by Fujii Hironori.
3324
3325         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3326         (TestWebKitAPI::Curl::TEST_F):
3327
3328 2019-03-05  Youenn Fablet  <youenn@apple.com>
3329
3330         Rename requestCacheStorageSpace to requestStorageSpace
3331         https://bugs.webkit.org/show_bug.cgi?id=195282
3332
3333         Reviewed by Chris Dumez.
3334
3335         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3336         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3337         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3338
3339 2019-03-05  Brady Eidson  <beidson@apple.com>
3340
3341         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3342         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3343
3344         Reviewed by Tim Horton.
3345
3346         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3347         different directory into that same WKWebView should work.
3348
3349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3350         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3351
3352 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3353
3354         Add WeakHashSet
3355         https://bugs.webkit.org/show_bug.cgi?id=195152
3356
3357         Reviewed by Antti Koivisto.
3358
3359         Added tests for WeakHashSet.
3360
3361         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3362         (TestWebKitAPI::Base::Base): Moved.
3363         (TestWebKitAPI::Derived::foo): Moved.
3364         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3365         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3366         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3367         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3368
3369 2019-03-04  Chris Dumez  <cdumez@apple.com>
3370
3371         Do not share WebProcesses between private and regular sessions
3372         https://bugs.webkit.org/show_bug.cgi?id=195189
3373         <rdar://problem/48421064>
3374
3375         Reviewed by Alex Christensen.
3376
3377         Add API test coverage.
3378
3379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3380         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3381
3382 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3383
3384         [WPE] Enable web process sandbox
3385         https://bugs.webkit.org/show_bug.cgi?id=195169
3386
3387         Reviewed by Daniel Bates.
3388
3389         * wpe/install-dependencies:
3390         * wpe/jhbuild.modules:
3391
3392 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3395         https://bugs.webkit.org/show_bug.cgi?id=195206
3396
3397         Reviewed by Žan Doberšek.
3398
3399         Add a new test case.
3400
3401         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3402         (testJSCClass):
3403
3404 2019-03-04  Charlie Turner  <cturner@igalia.com>
3405
3406         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3407         https://bugs.webkit.org/show_bug.cgi?id=194898
3408
3409         Reviewed by Žan Doberšek.
3410
3411         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3412         a GCC extension that permits arithmetic on void* pointer. Inline
3413         the macro until this issue is fixed upstream.
3414
3415 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3416
3417         Rid the world of WK_API_ENABLED
3418         https://bugs.webkit.org/show_bug.cgi?id=195263
3419
3420         Reviewed by Dan Bernstein.
3421
3422         List of changed files elided because it's useless.
3423
3424 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3425
3426         Unreviewed follow-up to r242292.
3427
3428         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3429
3430         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3431         (TestWebKitAPI::testStrip): Renamed from strip.
3432         (TestWebKitAPI::TEST):
3433
3434 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3435
3436         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3437
3438         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3439         and bug #194272 for details.
3440
3441         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3442
3443 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3444
3445         Remove some more unused 32-bit code
3446         https://bugs.webkit.org/show_bug.cgi?id=195255
3447
3448         Reviewed by Darin Adler.
3449
3450         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3451         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3452         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3453         (NPP_New):
3454         (NPP_HandleEvent):
3455         (handleEventCarbon): Deleted.
3456
3457 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3458
3459         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3460
3461         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3462         (TestWebKitAPI::TEST):
3463
3464 2019-03-01  Darin Adler  <darin@apple.com>
3465
3466         Finish removing String::format
3467         https://bugs.webkit.org/show_bug.cgi?id=194893
3468
3469         Reviewed by Daniel Bates.
3470 '
3471         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3472
3473 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3474
3475         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3476         https://bugs.webkit.org/show_bug.cgi?id=195229
3477         <rdar://problem/48520362>
3478
3479         Reviewed by Chris Dumez.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3482         (TEST):
3483
3484 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3485
3486         Add a system trace scope for event region building
3487         https://bugs.webkit.org/show_bug.cgi?id=195226
3488
3489         Reviewed by Jon Lee.
3490
3491         This trace scope measures the time spend converting element rects into Region objects,
3492         which can be large on some pages.
3493
3494         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3495
3496         * Tracing/SystemTracePoints.plist:
3497
3498 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3499
3500         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3501         https://bugs.webkit.org/show_bug.cgi?id=194612
3502
3503         Reviewed by Alex Christensen.
3504
3505         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3506         Just test the new string-processing function and don't touch the actual environment.
3507         (Test cases are all as before, but based on operator== instead of strcmp.)
3508
3509 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3510
3511         [ews-app] Update primary keys for handling multiple Buildbot instances
3512         https://bugs.webkit.org/show_bug.cgi?id=195120
3513
3514         Reviewed by Stephanie Lewis.
3515
3516         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3517         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3518         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3519
3520         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3521         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3522         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3523         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3524         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3525         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3526
3527 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3528
3529         [WinCairo] Enable service worker
3530         https://bugs.webkit.org/show_bug.cgi?id=188318
3531
3532         Reviewed by Youenn Fablet.
3533
3534         * DumpRenderTree/DumpRenderTreePrefix.h:
3535         * TestWebKitAPI/PlatformWin.cmake:
3536         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3537         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3538         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3539
3540 2019-03-01  Justin Fan  <justin_fan@apple.com>
3541
3542         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3543         https://bugs.webkit.org/show_bug.cgi?id=195191
3544
3545         Rubber-stamped by Dean Jackson.
3546
3547         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3548
3549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3550
3551 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3552
3553         Unreviewed, fix lldb webkitpy tests
3554         https://bugs.webkit.org/show_bug.cgi?id=194375
3555
3556         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3557
3558         * lldb/lldb_webkit.py:
3559         (WTFStringImplProvider.is_8bit):
3560
3561 2019-02-28  David Quesada  <david_quesada@apple.com>
3562
3563         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3564         https://bugs.webkit.org/show_bug.cgi?id=195121
3565         rdar://problem/48450302
3566
3567         Reviewed by Alex Christensen.
3568
3569         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3570         configurations where the 'download' attribute is absent, blank, or populated
3571         with a filename, and where the anchor element is same-origin or cross-origin
3572         (meaning the 'download' attribute shouldn't be honored).
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3576         (-[NavigationActionTestDelegate init]):
3577         (-[NavigationActionTestDelegate navigationAction]):
3578         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3579         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3580         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3581         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3582         (TEST):
3583
3584 2019-02-28  Antoine Quint  <graouts@apple.com>
3585
3586         Enable the Pointer Events runtime flag by default
3587         https://bugs.webkit.org/show_bug.cgi?id=195156
3588
3589         Reviewed by Dean Jackson.
3590
3591         * DumpRenderTree/mac/DumpRenderTree.mm:
3592         (enableExperimentalFeatures):
3593
3594 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3595
3596         Several PasteImage API tests are flaky
3597         https://bugs.webkit.org/show_bug.cgi?id=195160
3598
3599         Reviewed by Tim Horton.
3600
3601         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3602         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3603         listening for a "load" event after image load is already complete.
3604
3605         To address this, make these tests first register a "load" event handler, then run script to insert an image
3606         element into the document, and finally wait until the load event is observed before checking image size.
3607
3608         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3609
3610 2019-02-28  Chris Dumez  <cdumez@apple.com>
3611
3612         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3613         https://bugs.webkit.org/show_bug.cgi?id=195107
3614
3615         Reviewed by Alex Christensen.
3616
3617         Give some time for the zoom level to get restored.
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3620
3621 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3622
3623         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3624         https://bugs.webkit.org/show_bug.cgi?id=194958
3625
3626         Reviewed by Geoffrey Garen.
3627
3628         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3629         (TEST):
3630
3631 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3632
3633         [ews-app] Update method to save build to handle builder_display_name
3634         https://bugs.webkit.org/show_bug.cgi?id=195047
3635
3636         Reviewed by Dewei Zhu.
3637
3638         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3639         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3640
3641 2019-02-28  Justin Fan  <justin_fan@apple.com>
3642
3643         [Web GPU] Enable Web GPU only on 64-bit
3644         https://bugs.webkit.org/show_bug.cgi?id=195139
3645
3646         Because Metal is only supported on 64 bit apps.
3647
3648         Unreviewed build fix.
3649
3650         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3651
3652 2019-02-27  Youenn Fablet  <youenn@apple.com>
3653
3654         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3655         https://bugs.webkit.org/show_bug.cgi?id=194959
3656
3657         Reviewed by Chris Dumez.
3658
3659         Spin loop until getting the condition to remove flakiness.
3660
3661         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3662
3663 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3664
3665         [ews-build] Buildbot should include builder_display_name in the build events
3666         https://bugs.webkit.org/show_bug.cgi?id=195045
3667
3668         Reviewed by Dewei Zhu.
3669
3670         * BuildSlaveSupport/ews-build/events.py:
3671         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3672         buildername to builder_name to be consistent in naming style.
3673         (Events.buildFinished): Ditto.
3674
3675 2019-02-27  Chris Dumez  <cdumez@apple.com>
3676
3677         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3678         https://bugs.webkit.org/show_bug.cgi?id=194480
3679
3680         Reviewed by Brady Eidson.
3681
3682         Update existing API test to make it more likely to reproduce the issue.
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3685
3686 2019-02-27  Brady Eidson  <beidson@apple.com>
3687
3688         Universal links from Google search results pages don't open the app.
3689         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3690
3691         Reviewed by Geoffrey Garen.
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3694         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3695         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3696         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3697
3698 2019-02-27  Chris Dumez  <cdumez@apple.com>
3699
3700         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3701         https://bugs.webkit.org/show_bug.cgi?id=195102
3702
3703         Reviewed by Geoffrey Garen.
3704
3705         If the number of processes is not yet what we expect, wait a bit and check again to give
3706         processes some time to exit.
3707
3708         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3709
3710 2019-02-27  Chris Dumez  <cdumez@apple.com>
3711
3712         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3713         https://bugs.webkit.org/show_bug.cgi?id=194545
3714
3715         Reviewed by Brady Eidson.
3716
3717         Make sure the test navigates forward and then back only once. Previously, navigating
3718         back would trigger a navigation again in a timer.
3719
3720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3721
3722 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3723
3724         High Sierra Debug JSC test queue should use faster hardware
3725         https://bugs.webkit.org/show_bug.cgi?id=194603
3726
3727         Rubber-stamped by Alexey Proskuryakov.
3728
3729         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3730
3731         * BuildSlaveSupport/build.webkit.org-config/config.json:
3732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3733         (BubbleQueueServer):
3734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3735         (WebKitBuildbot):
3736         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3737         * QueueStatusServer/config/queues.py:
3738         * Scripts/webkitpy/common/config/ews.json:
3739         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3740         (test_ews_name):
3741
3742 2019-02-27  John Wilander  <wilander@apple.com>
3743
3744         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3745         https://bugs.webkit.org/show_bug.cgi?id=195071
3746         <rdar://problem/48417690>
3747
3748         Reviewed by Alex Christensen and Brent Fulgham.
3749
3750         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3751         (TestWebKitAPI::createURL):
3752             Convenience function.
3753         (TestWebKitAPI::TEST):
3754             WebCore::AdClickAttribution now takes a URL when creating Source and
3755             Destination.
3756         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3757         (TestWebKitAPI::TEST):
3758             WebCore::AdClickAttribution now takes a URL when creating Source and
3759             Destination.
3760
3761 2019-02-27  Antoine Quint  <graouts@apple.com>
3762
3763         Support Pointer Events on macOS
3764         https://bugs.webkit.org/show_bug.cgi?id=195008
3765         <rdar://problem/47454419>
3766
3767         Reviewed by Dean Jackson.
3768
3769         * DumpRenderTree/mac/DumpRenderTree.mm:
3770         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3771         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3772
3773 2019-02-26  Mark Lam  <mark.lam@apple.com>
3774
3775         Remove remaining poisoning code.
3776         https://bugs.webkit.org/show_bug.cgi?id=194138
3777
3778         Reviewed by Saam Barati.
3779
3780         * TestWebKitAPI/CMakeLists.txt:
3781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3782         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3783         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3784         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3785         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3786         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3787         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3788
3789 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3790
3791         Move ephemeral local storage from WebProcess to UIProcess
3792         https://bugs.webkit.org/show_bug.cgi?id=195074
3793         <rdar://problem/47937975>
3794
3795         Reviewed by Geoff Garen.
3796
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798
3799 2019-02-20  Jer Noble  <jer.noble@apple.com>
3800
3801         [Cocoa] Media elements will restart network buffering just before suspending
3802         https://bugs.webkit.org/show_bug.cgi?id=193691
3803
3804         Reviewed by Eric Carlson.
3805
3806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3807         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3808         (TEST):
3809
3810 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3811
3812         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3813         https://bugs.webkit.org/show_bug.cgi?id=191652
3814
3815         Reviewed by Alex Christensen.
3816
3817         Fix WinCairo MiniBrowser behavior of authentication dialog.
3818
3819         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3820         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3821
3822 2019-02-26  Youenn Fablet  <youenn@apple.com>
3823
3824         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3825         https://bugs.webkit.org/show_bug.cgi?id=195028
3826         <rdar://problem/48243733>
3827
3828         Reviewed by Eric Carlson.
3829
3830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3831
3832 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3833
3834         [WPE] Add API for webview background color configuration
3835         https://bugs.webkit.org/show_bug.cgi?id=192305
3836
3837         Reviewed by Michael Catanzaro.
3838
3839         * MiniBrowser/wpe/main.cpp:
3840         (main): Add a new option to configure the webview background
3841         color. Example: --bg-color=transparent.
3842         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3843         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3844         (beforeAll): Ditto.
3845
3846 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3847
3848         scalableNativeWebpageParameters() is not preserved on new page navigation.
3849         https://bugs.webkit.org/show_bug.cgi?id=194892
3850         <rdar://problem/47538280>
3851
3852         Reviewed by Wenson Hsieh.
3853         
3854         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3855
3856         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3857         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3858         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3859         (WTR::UIScriptController::allowsViewportShrinkToFit):
3860         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3861         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3862         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3863         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3864         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3865         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3866
3867 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3868
3869         [ews-app] Add model for handling multiple Buildbot instances
3870         https://bugs.webkit.org/show_bug.cgi?id=194863
3871
3872         Reviewed by Stephanie Lewis.
3873
3874         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3875
3876 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3877
3878         [ews-app] Remove BuilderMapping table
3879         https://bugs.webkit.org/show_bug.cgi?id=194961
3880
3881         Reviewed by Stephanie Lewis.
3882
3883         Store builder name directly in build table, instead of having a separate
3884         table for it.
3885
3886         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3887         * BuildSlaveSupport/ews-app/ews/models/build.py:
3888         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3890
3891 2019-02-25  John Wilander  <wilander@apple.com>
3892
3893         Introduce and adopt new class RegistrableDomain for eTLD+1
3894         https://bugs.webkit.org/show_bug.cgi?id=194791
3895         <rdar://problem/48179240>
3896
3897         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3898
3899         This patch adds an API test and replaces two instances of
3900         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3901
3902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3903         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3904         (TestWebKitAPI::TEST):
3905             Changed two strings to make sure the registrable domains are still considered
3906             invalid and pass the test.
3907         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3908         (TestWebKitAPI::TEST):
3909         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3910         (WTR::InjectedBundle::didReceiveMessageToPage):
3911
3912 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3913
3914         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3915         https://bugs.webkit.org/show_bug.cgi?id=195001
3916
3917         Reviewed by Carlos Garcia Campos.
3918
3919         API version 1.0 always includes the functionality previously guarded with
3920         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3921         unconditionally.
3922
3923         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3924         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3925         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3926         (WebViewTest::showInWindow): Ditto.
3927         (WebViewTest::hideView): Ditto.
3928         * wpe/backends/HeadlessViewBackend.cpp:
3929         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3930         * wpe/backends/ViewBackend.cpp:
3931         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3932         * wpe/backends/WindowViewBackend.cpp:
3933         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3934         WPE_BACKEND_CHECK_VERSION().
3935         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3936
3937 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3938
3939         [Flatpak] Add support for flatpak > 1.1.2
3940         https://bugs.webkit.org/show_bug.cgi?id=194088
3941
3942         Flatpak 1.2 is now out so we need to support that
3943         version now.
3944
3945         Reviewed by Michael Catanzaro.
3946
3947         * flatpak/flatpakutils.py:
3948         (check_flatpak):
3949         (FlatpakPackages.__init__):
3950         (FlatpakPackages.__detect_packages):
3951         (FlatpakPackages.__detect_packages.in):
3952         (FlatpakRepos.update):
3953
3954 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3955
3956         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3957         https://bugs.webkit.org/show_bug.cgi?id=194998
3958
3959         Reviewed by Carlos Garcia Campos.
3960
3961         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3962         to a Git checkout and using the latest commit containing various fixes
3963         and improvements.
3964
3965 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3966
3967         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3968         https://bugs.webkit.org/show_bug.cgi?id=194981
3969
3970         Reviewed by Žan Doberšek.
3971
3972         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3973         (TestWebKitAPI::TEST):
3974
3975 2019-02-23  Keith Miller  <keith_miller@apple.com>
3976
3977         Add new mac target numbers
3978         https://bugs.webkit.org/show_bug.cgi?id=194955
3979
3980         Reviewed by Tim Horton.
3981
3982         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3983         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3984         * MiniBrowser/Configurations/Base.xcconfig:
3985         * TestWebKitAPI/Configurations/Base.xcconfig:
3986         * WebKitTestRunner/Configurations/Base.xcconfig:
3987
3988 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3989
3990         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3991         https://bugs.webkit.org/show_bug.cgi?id=194846
3992
3993         Reviewed by Don Olmstead.
3994
3995         Added _search_paths() and _port_specific_expectations_files() for
3996         WinCairoPort.
3997
3998         * Scripts/webkitpy/port/win.py:
3999         (WinCairoPort.default_baseline_search_path):
4000         (WinCairoPort):
4001         (WinCairoPort._port_specific_expectations_files):
4002         (WinCairoPort._search_paths):
4003
4004 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4005
4006         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4007         https://bugs.webkit.org/show_bug.cgi?id=194963
4008
4009         Reviewed by Dean Jackson.
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4012         Do a `contains` check instead of `equals`, because in debug builds we
4013         put the GraphicsLayer pointer in a prefix.
4014
4015 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4016
4017         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4018         https://bugs.webkit.org/show_bug.cgi?id=194873
4019         <rdar://problem/46701974>
4020
4021         Reviewed by Tim Horton.
4022
4023         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4024
4025         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4026         (WTR::UIScriptController::menuRect const):
4027         (WTR::UIScriptController::isShowingMenu const):
4028         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4029         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4030         (WTR::UIScriptController::menuRect const):
4031
4032         Add a function to query the bounds of the callout menu in content coordinates.
4033
4034         (WTR::UIScriptController::isShowingMenu const):
4035
4036         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4037
4038         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4039         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4040         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4041         (WTR::UIScriptController::rectForMenuAction const):
4042         (WTR::UIScriptController::menuRect const):
4043         (WTR::UIScriptController::isShowingMenu const):
4044         (WTR::findViewInHierarchyOfType): Deleted.
4045
4046 2019-02-22  Chris Dumez  <cdumez@apple.com>
4047
4048         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4049         https://bugs.webkit.org/show_bug.cgi?id=194954
4050         <rdar://problem/48127957>
4051
4052         Reviewed by Alex Christensen.
4053
4054         Add API test coverage.
4055
4056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4057         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4058         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4059         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4060
4061 2019-02-22  Chris Dumez  <cdumez@apple.com>
4062
4063         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4064         https://bugs.webkit.org/show_bug.cgi?id=194924
4065         <rdar://problem/48216125>
4066
4067         Reviewed by Geoffrey Garen.
4068
4069         Add API test coverage.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4072
4073 2019-02-22  Chris Dumez  <cdumez@apple.com>
4074
4075         Unreviewed, disable API test added in r241928 on iOS.
4076
4077         The cache is not enabled on devices with less than 3GB of RAM.
4078
4079         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4080
4081 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4082
4083         Hardcode Visual Viewports on everywhere except iOS WK1
4084         https://bugs.webkit.org/show_bug.cgi?id=194928
4085
4086         Reviewed by Zalan Bujtas.
4087
4088         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4089         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4090         set it to false. The setting has shipped for several years and there's no need to turn
4091         it off now.
4092
4093         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4094         Visual Viewports are not enabled.
4095         
4096         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4097         that only runs in WK2
4098
4099         * MiniBrowser/mac/SettingsController.h:
4100         * MiniBrowser/mac/SettingsController.m:
4101         (-[SettingsController init]):
4102         (-[SettingsController _populateMenu]):
4103         (-[SettingsController validateMenuItem:]):
4104         (-[SettingsController visualViewportEnabled]): Deleted.
4105         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4106         * MiniBrowser/mac/WK1BrowserWindowController.m:
4107         (-[WK1BrowserWindowController didChangeSettings]):
4108         * MiniBrowser/mac/WK2BrowserWindowController.m:
4109         (-[WK2BrowserWindowController didChangeSettings]):
4110
4111 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4112
4113         Discard cached processes when clearing website data store
4114         https://bugs.webkit.org/show_bug.cgi?id=194894
4115
4116         Reviewed by Chris Dumez.
4117
4118         Added a test case.
4119
4120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4121         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4122
4123 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4124
4125         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4126         https://bugs.webkit.org/show_bug.cgi?id=194914
4127         <rdar://problem/47586889>
4128
4129         Reviewed by Geoffrey Garen.
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4132         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4133         (TEST):
4134         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4135
4136 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4137
4138         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4139         <https://webkit.org/b/194761>
4140
4141         Reviewed by Myles Maxfield.
4142
4143         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4144         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4145         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4146         to use ARC-compliant cast.
4147         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4148         ARC-compliant cast.
4149         (WTR::installFakeHelvetica): Log `error` to console if
4150         CTFontManagerRegisterFontsForURL() fails, but only on supported
4151         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4152         Call CFRelease() on `error` to fix the leak.  Update to use
4153         ARC-compliant cast.
4154         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4155         cast.
4156
4157 2019-02-21  Chris Dumez  <cdumez@apple.com>
4158
4159         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4160         https://bugs.webkit.org/show_bug.cgi?id=194481
4161
4162         Reviewed by Alex Christensen.
4163
4164         Give the processes a chance to shutdown and wait until we reached the expected number
4165         of processes.
4166
4167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4168
4169 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4170
4171         Fix the macOS build
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4174
4175 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4176
4177         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4180         I am a backwards.
4181
4182 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4183
4184         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4185
4186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4187         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4188         We could force on UI-side compositing, but I feel like the test might be more
4189         valuable exercising the normal path on each platform (though the original
4190         bug was also UI-side specific). Though we can't validate that the overlay
4191         layer was installed successfully, there are layout tests that do that.
4192
4193 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4194
4195         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4196         https://bugs.webkit.org/show_bug.cgi?id=194845
4197         <rdar://problem/47944579>
4198
4199         Reviewed by Antti Koivisto.
4200
4201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4203
4204 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4205
4206         [LFC][Floats] Add support for placing formatting roots in-between floats.
4207         https://bugs.webkit.org/show_bug.cgi?id=194902
4208
4209         Reviewed by Antti Koivisto.
4210
4211         * LayoutReloaded/misc/LFC-passing-tests.txt:
4212
4213 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4214
4215         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4216         https://bugs.webkit.org/show_bug.cgi?id=194901
4217
4218         Unreviewed build fix.
4219
4220         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4221         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4222         WPEBackend-fdo-0.1 as library name.
4223
4224 2019-02-21  Rob Buis  <rbuis@igalia.com>
4225
4226         Update MIME type parser
4227         https://bugs.webkit.org/show_bug.cgi?id=180526
4228
4229         Reviewed by Darin Adler.
4230
4231         Add tests involving leading and trailing whitespace, non-token
4232         characters and quoted strings.
4233
4234         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4235         (TestWebKitAPI::TEST):
4236
4237 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4238
4239         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4240         https://bugs.webkit.org/show_bug.cgi?id=194884
4241
4242         Reviewed by Michael Catanzaro.
4243
4244         * PlatformWin.cmake:
4245
4246 2019-02-20  Chris Dumez  <cdumez@apple.com>
4247
4248         Add API test for <rdar://problem/47471222>
4249         https://bugs.webkit.org/show_bug.cgi?id=194847
4250
4251         Reviewed by Alex Christensen.
4252
4253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4254
4255 2019-02-20  Chris Dumez  <cdumez@apple.com>
4256
4257         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4258         https://bugs.webkit.org/show_bug.cgi?id=194872
4259         <rdar://problem/47924500>
4260
4261         Reviewed by Alex Christensen.
4262
4263         Add API test coverage.
4264
4265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4266
4267 2019-02-20  Jer Noble  <jer.noble@apple.com>
4268
4269         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4270         https://bugs.webkit.org/show_bug.cgi?id=191332
4271
4272         Reviewed by Dean Jackson.
4273
4274         * Scripts/git-is-in-range: Added.
4275
4276 2019-02-20  Andy Estes  <aestes@apple.com>
4277
4278         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4279         https://bugs.webkit.org/show_bug.cgi?id=194869
4280
4281         Rubber-stamped by Jer Noble.
4282
4283         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4284         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4285         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4286         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4288         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4289
4290 2019-02-20  Chris Dumez  <cdumez@apple.com>
4291
4292         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4293         https://bugs.webkit.org/show_bug.cgi?id=194857
4294         <rdar://problem/47759323>
4295
4296         Reviewed by Alex Christensen.
4297
4298         Add API test coverage.
4299
4300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4301
4302 2019-02-20  Chris Dumez  <cdumez@apple.com>
4303
4304         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4305         https://bugs.webkit.org/show_bug.cgi?id=194829
4306         <rdar://problem/47889906>
4307
4308         Reviewed by Alexey Proskuryakov.
4309
4310         Every time the TestOptions were changing we were creating both a new Web view and
4311         a new WKContext, which would start a new Network process. In most cases, we only
4312         need to contruct a new Web view and we do can keep reusing the same WKContext.
4313         This patch implements this optimization and thus avoids spinning a lot of new
4314         Network processes while running the layout tests.
4315
4316         * WebKitTestRunner/TestController.cpp:
4317         (WTR::TestController::generateContextConfiguration const):
4318         (WTR::TestController::generatePageConfiguration):
4319         (WTR::TestController::createWebViewWithOptions):
4320         (WTR::TestController::resetPreferencesToConsistentValues):
4321         (WTR::updateTestOptionsFromTestHeader):
4322         * WebKitTestRunner/TestController.h:
4323         * WebKitTestRunner/TestOptions.h:
4324         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4325         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4326         (WTR::TestOptions::hasSameInitializationOptions const):
4327         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4328         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4329         (WTR::TestController::platformAddTestOptions const):
4330
4331 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4332
4333         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4334         https://bugs.webkit.org/show_bug.cgi?id=167941
4335
4336         Reviewed by Carlos Garcia Campos.
4337
4338         * MiniBrowser/gtk/main.c:
4339         (filterSavedCallback): Added.
4340         (main): Support loading a JSON rule set file for content filtering.
4341         * MiniBrowser/wpe/main.cpp:
4342         (filterSavedCallback): Added.
4343         (main): Support loading a JSON rule set file for content filtering.
4344         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4345         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4346         (WTF::derefGPtr): Ditto.
4347         (testEmptyStore):
4348         (testSaveInvalidFilter):
4349         (testSaveLoadFilter):
4350         (testSavedFilterIdentifierMatch):
4351         (testRemoveFilter):
4352         (testSaveMultipleFilters):
4353         (testSaveFilterFromFile):
4354         (testFilterPersistence):
4355         (beforeAll):
4356         (afterAll):
4357         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4358         (removeOldInjectedContentAndResetLists): Also reset content filters.
4359         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4360         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4361         the element affected by the style sheet.
4362         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4363         and returns it to be used by tests.
4364         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4365         from the WebKitUserContentManager results in the a CSS style sheet being blocked.