Viewport percentage tests that resize the viewport are flaky
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-31  Darin Adler  <darin@apple.com>
2
3         Viewport percentage tests that resize the viewport are flaky
4         https://bugs.webkit.org/show_bug.cgi?id=133351
5
6         Reviewed by Anders Carlsson.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
10         happens to be stored in the UI delegate object. This is part of resetting the
11         window position.
12
13         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
14         a frame rectangle. The size is stored in the size of the web view itself.
15         * DumpRenderTree/mac/UIDelegate.mm:
16         (-[UIDelegate resetWindowOrigin]): Added.
17         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
18         old version would store the frame, but not resize the web view!
19         (-[UIDelegate webViewFrame:]): Get the size from the web view.
20
21         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
22         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
23
24         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
25         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
26         the window.
27
28         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
29         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
30         window gets resized too, not just the web view.
31         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
32
33         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
34         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
35         window gets resized too, not just the web view.
36         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
37
38 2014-05-30  Michael Saboff  <msaboff@apple.com>
39
40         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
41         https://bugs.webkit.org/show_bug.cgi?id=133409
42
43         Reviewed by Filip Pizlo.
44
45         Handle creating a tarball the same way as running remote when processing
46         paths in prepareBundle.
47
48         * Scripts/run-jsc-stress-tests:
49
50 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
51
52         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
53         https://bugs.webkit.org/show_bug.cgi?id=132280
54
55         Reviewed by Chris Fleizach.
56
57         Remove implementation of logAccessibilityEvents() for ATK based
58         ports, as this has proved to be a flaky method of checking that
59         ATK events are being properly emitted. Instead, it's better to use
60         the addNotificationListener() functions and provide a JS callback
61         to check that the right events are being emmitted from the tests.
62
63         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
64         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
65         with dummy implementation.
66         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
67         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
68
69 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
70
71         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
72         https://bugs.webkit.org/show_bug.cgi?id=132280
73
74         Rubber stamped by Carlos Garcia Campos.
75
76         Fix two small issues with previous patch (r169483), that caused some tests to break.
77
78         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
79         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
80         duplicated entry.
81         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
82         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
83
84 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
85
86         [ATK] Added new accessibility signal: text-caret-moved.
87         Make AccessibilityUIElement.setSelectedTextRange work
88         as atk_text_set_caret_offset when given offset == 0.
89         https://bugs.webkit.org/show_bug.cgi?id=132527
90
91         Reviewed by Mario Sanchez Prada.
92
93         text-caret-moved signal in accessibilityController is needed to
94         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
95         as LayoutTests. Add the signal to the controller.
96
97         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
98         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
99         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
100         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
101         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
102         (setSelectedTextRange): Change return type to bool.
103         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
104         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
105         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
106         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
107         for extra arguments passed to handler and use it for text-caret-moved offset.
108         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
109         Connect callback to new listener for ATK:AtkText:text-caret-moved.
110         Refactor so that failures be reported.
111         Initialize atk interfaces before trying to connect to them, see
112         https://bugzilla.gnome.org/show_bug.cgi?id=729922
113         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
114         Simplify code by using a vector in place of dozen variables.
115         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
116         Comment about not synchronizing with accessibilityController.
117
118 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
119
120         [GTK] Add a WebKit2 Performance bot.
121         https://bugs.webkit.org/show_bug.cgi?id=132862
122
123         Reviewed by Csaba Osztrogonác.
124
125         This adds a GTK WebKit2 perf bot.
126
127         * BuildSlaveSupport/build.webkit.org-config/config.json:
128
129 2014-05-29  Dan Bernstein  <mitz@apple.com>
130
131         Fixed the WebKitTestRunner build after r169452.
132
133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
134         (WTR::InjectedBundle::initialize):
135
136 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
137
138         Unreviewed. Update my email addresses in contributors.json.
139
140         * Scripts/webkitpy/common/config/contributors.json:
141
142 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
143
144         Need an API test for bug #133193 (r169315)
145         <https://bugs.webkit.org/show_bug.cgi?id=133324>
146
147         This adds an API test that ensures that calling "stop loading" during a
148         "did fail provisional load" callback doesn't crash.
149
150         Reviewed by Andy Estes.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         Add new files to project.
154
155         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
156         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
157         If the message is the "test done" message, record that.
158         (TestWebKitAPI::setInjectedBundleClient):
159         Register a function for the "did receive message from injected bundle"
160         callback.
161         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
162         Assert that we received the message from the injected bundle, and set
163         'done' to finish the test.
164         (TestWebKitAPI::TEST):
165         Create a WebView, register a page loader client for the "did fail
166         provisional load" callback, and load a non-existent resource.
167
168         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
169         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
170         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
171         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
172         provisional load failed.
173         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
174         Register a page loader client for the "did fail provisional load"
175         callback.
176         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
177         Call WKBundlePageStopLoading() during the callback. This not crashing
178         is what we're ensuring with this test.
179
180 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [GTK] Make it possible to build with FTL enabled
183         https://bugs.webkit.org/show_bug.cgi?id=133219
184
185         Reviewed by Philippe Normand.
186
187         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
188         same revision than mac.
189
190 2014-05-27  Michael Saboff  <msaboff@apple.com>
191
192         REGRESSION(r169265): sh: line 0: cd: ../.vm
193         https://bugs.webkit.org/show_bug.cgi?id=133242
194
195         Rubber stamped by Oliver Hunt.
196
197         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
198         array since the command may contain character escapes that don't work with the
199         array form of system().
200
201         * Scripts/run-jsc-stress-tests:
202
203 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
204
205         [EFL] Change download url of freetype6
206         https://bugs.webkit.org/show_bug.cgi?id=133303
207
208         Reviewed by Csaba Osztrogonác.
209
210         freetype6 tarball isn't downloaded in Korea. So, we need to
211         change the url for now.
212
213         * efl/jhbuild.modules:
214
215 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
216
217         Remove BLOB guards
218         https://bugs.webkit.org/show_bug.cgi?id=132863
219
220         Reviewed by Csaba Osztrogonác.
221
222         * Scripts/webkitperl/FeatureList.pm:
223
224 2014-05-27  Alberto Garcia  <berto@igalia.com>
225
226         Remove leftover comment from r165182.
227
228         Rubber stamped by Carlos Garcia Campos.
229
230         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
231
232 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
233
234         [EFL] Add LLVM as optional jhbuild module for FTL developers
235         https://bugs.webkit.org/show_bug.cgi?id=133216
236
237         Reviewed by Gyuyoung Kim.
238
239         * efl/jhbuild.modules:
240
241 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
242
243         Fix test failures on python test
244         https://bugs.webkit.org/show_bug.cgi?id=133297
245
246         Reviewed by Dirk Schulze.
247
248         2 tests are failing because of unbounded local variable reference in test_importer.py.
249
250         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
251         (TestImporter.import_tests):
252
253 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
254
255         [GTK] GObject DOM bindings API break test fails in the tests bots
256         https://bugs.webkit.org/show_bug.cgi?id=133211
257
258         Reviewed by Martin Robinson.
259
260         When generating the built product archive on platform GTK, we need
261         to copy also the file gtkdoc-webkitdom.cfg and the directory
262         DerivedSources/webkitdom.
263
264         * BuildSlaveSupport/built-product-archive:
265         (archiveBuiltProduct):
266
267 2014-05-26  Commit Queue  <commit-queue@webkit.org>
268
269         Unreviewed, rolling out r169122.
270         https://bugs.webkit.org/show_bug.cgi?id=133288
271
272         Broke CJK font fallback (Requested by ap on #webkit).
273
274         Reverted changeset:
275
276         "[Mac] WebProcess doesn't follow localization of UI process
277         when run as a service"
278         https://bugs.webkit.org/show_bug.cgi?id=133126
279         http://trac.webkit.org/changeset/169122
280
281 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
282
283         [GTK] WebProcess leaked when closing pages with network process enabled
284         https://bugs.webkit.org/show_bug.cgi?id=129684
285
286         Reviewed by Anders Carlsson.
287
288         Enable the test to check that web processes finish when the web
289         view is destroyed.
290
291         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
292
293 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
296         https://bugs.webkit.org/show_bug.cgi?id=133279
297
298         Reviewed by Philippe Normand.
299
300         generator.saw_warnings is only set by GTKDoc::generate(), so it
301         should only be used after generate.
302
303         * gtk/generate-gtkdoc:
304         (generate_documentation_for_config): Do not check
305         generator.saw_warnings again, simply return the value returned by
306         generate_doc() which is generator.saw_warnings. When rebasing,
307         returns always False since there aren't warnings.
308
309 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
310
311         W3C test importer should catch exceptions coming from HTML/CSS conversion
312         https://bugs.webkit.org/show_bug.cgi?id=133176
313
314         Reviewed by Darin Adler.
315
316         Exceptions raised when converting HTML/CSS are caught.
317         Files for which conversion failed are still copied to the target directory.
318         Each individual conversion failure is logged.
319         Total conversion failure number is logged at the end of the import process.
320
321         * Scripts/webkitpy/w3c/test_importer.py:
322         (TestImporter.import_tests):
323
324 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
325
326         [GTK] Allow to run the tests on the native X display.
327         https://bugs.webkit.org/show_bug.cgi?id=133157
328
329         Reviewed by Benjamin Poulain.
330
331         This adds a new driver (xorgdriver) that runs the tests on the
332         X display referenced by the environment variable DISPLAY.
333
334         This new driver will be activated only if the environment variable
335         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
336         tests and performance tests.
337
338         This patch also makes the script run-perf-tests to check the
339         system dependencies before starting the tests. Previously this
340         was not checked, and if the system dependencies were not met,
341         the script tried to execute the tests anyway, causing massive
342         failures. For example, if you had Xvfb not installed and you
343         wanted to use the Xvfb driver (the default on GTK and EFL),
344         run-perf-tests would not abort.
345
346         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
347         (PerfTestsRunner._parse_args): Check the system dependencies of
348         the driver before starting the tests.
349         * Scripts/webkitpy/port/driver.py:
350         (Driver): Implement generic check_driver method.
351         (Driver.check_driver):
352         (Driver.check_driver.implementation):
353         * Scripts/webkitpy/port/gtk.py:
354         (GtkPort._driver_class): Check for environment variable
355         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
356         * Scripts/webkitpy/port/xorgdriver.py: Added.
357         (XorgDriver): Implement Xorg driver.
358         (XorgDriver.check_driver):
359         (XorgDriver._start):
360
361 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
362
363         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
364         https://bugs.webkit.org/show_bug.cgi?id=133215
365
366         Reviewed by Csaba Osztrogonác.
367
368         This reverts r166798.
369
370         * BuildSlaveSupport/kill-old-processes:
371         (main):
372
373 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
374
375         [EFL] Turn on ENABLE_CSS_FILTERS in build script
376         https://bugs.webkit.org/show_bug.cgi?id=133278
377
378         Reviewed by Gyuyoung Kim.
379
380         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
381
382 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
383
384         run-javascriptcore-tests warning fix on non Mac platforms
385         https://bugs.webkit.org/show_bug.cgi?id=133260
386
387         Reviewed by Darin Adler.
388
389         * Scripts/webkitdirs.pm:
390         (argumentsForConfiguration):
391
392 2014-05-23  Michael Saboff  <msaboff@apple.com>
393
394         REGRESSION(r169265): sh: line 0: cd: ../.vm
395         https://bugs.webkit.org/show_bug.cgi?id=133242
396
397         Rubber stamped by Geoffrey Garen.
398
399         Added missing shell escapes '\' required as part of previous fix.
400
401         * Scripts/run-jsc-stress-tests:
402
403 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
404
405         Revert the erroneous change committed in r169286.
406
407         * Scripts/webkitpy/performance_tests/perftest.py:
408         (PerfTest._run_with_driver):
409
410 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
411
412         run-perf-tests should ignore whitespace lines when snarfing test output
413         https://bugs.webkit.org/show_bug.cgi?id=133238
414
415         Reviewed by Ryosuke Niwa.
416
417         Required for PerformanceTests/Canvas/terrain.html.
418
419         * Scripts/webkitpy/performance_tests/perftest.py:
420         (PerfTest._run_with_driver):
421         (PerfTest):
422
423 2014-05-23  Michael Saboff  <msaboff@apple.com>
424
425         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
426         https://bugs.webkit.org/show_bug.cgi?id=133223
427
428         Reviewed by Geoffrey Garen.
429
430         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
431         string before calling IO.popen() to work with older versions of ruby.
432         Changed the remote path in runShellTestRunner to quote the command
433         string we want to run via ssh so that it will work correctly with array
434         to string conversion needed for popen.
435
436         * Scripts/run-jsc-stress-tests:
437
438 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
439
440         Remove 'css-shaders' option from the build-webkit
441         https://bugs.webkit.org/show_bug.cgi?id=133212
442
443         Reviewed by Daniel Bates.
444
445         Original CSS shaders removed in r162644.
446
447         * Scripts/webkitperl/FeatureList.pm:
448
449 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
450
451         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
452         https://bugs.webkit.org/show_bug.cgi?id=133209
453
454         Reviewed by Sergio Villar Senin.
455
456         Return FAILURE when the command failed to run.
457
458         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
459         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
460
461 2014-05-23  Alberto Garcia  <berto@igalia.com>
462
463         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
464         https://bugs.webkit.org/show_bug.cgi?id=133210
465
466         Reviewed by Carlos Garcia Campos.
467
468         * gtk/install-dependencies:
469
470 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
471
472         Add Yusuke Suzuki to the list of contributors (for real)
473
474         Wrong section...
475
476         * Scripts/webkitpy/common/config/contributors.json:
477
478 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
479
480         Add Yusuke Suzuki to the list of contributors
481
482         * Scripts/webkitpy/common/config/contributors.json:
483
484 2014-05-22  Michael Saboff  <msaboff@apple.com>
485
486         Eliminate n/total progress update from run-jsc-stress-tests output to file
487         https://bugs.webkit.org/show_bug.cgi?id=133191
488
489         Reviewed by Geoffrey Garen.
490
491         Changed progressMeter setting to be based on stdout being a tty instead of
492         stdin.  Unified the processing of output from the shell runner to match the
493         same processing as is used by the makefile runner.  As part of this, the 
494         shell runner script was simplified.  It now forwards the output of each
495         test_script just like the Makefile and doesn't provide its own progress.
496
497         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
498         * Scripts/run-jsc-stress-tests:
499
500 2014-05-22  Michael Saboff  <msaboff@apple.com>
501
502         Add option to run-jsc-stress-tests to use installed jsc
503         https://bugs.webkit.org/show_bug.cgi?id=133102
504
505         Reviewed by Geoffrey Garen.
506
507         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
508         provied with the --jsc option.
509
510         * Scripts/run-jsc-stress-tests:
511
512 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
513
514         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
515         https://bugs.webkit.org/show_bug.cgi?id=132907
516
517         Reviewed by Gyuyoung Kim.
518
519         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
520         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
521
522         * efl/install-dependencies:
523
524 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
525
526         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
527         https://bugs.webkit.org/show_bug.cgi?id=133145
528
529         Reviewed by Csaba Osztrogonác.
530
531         * Scripts/run-jsc-stress-tests:
532
533 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
534
535         [Mac] WebProcess doesn't follow localization of UI process when run as a service
536         https://bugs.webkit.org/show_bug.cgi?id=133126
537         <rdar://problem/13396515>
538         <rdar://problem/16561084>
539
540         Reviewed by Sam Weinig and Tim Horton.
541
542         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
543         (WTR::InjectedBundle::platformInitialize): It was too late to override language
544         here, and it's not necessary any more. Keeping the code for older OS versions in
545         case it did have effect in some code paths.
546
547 2014-05-19  David Farler  <dfarler@apple.com>
548
549         Move WebKitTestRunner to std::unique_ptr
550         https://bugs.webkit.org/show_bug.cgi?id=133081
551
552         Reviewed by Daniel Bates.
553
554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
555         (WTR::InjectedBundle::didCreatePage):
556         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
557         * WebKitTestRunner/TestController.cpp:
558         (WTR::TestController::initialize):
559         (WTR::TestController::createWebViewWithOptions):
560         (WTR::TestController::resetStateToConsistentValues):
561         (WTR::TestController::runTest):
562         * WebKitTestRunner/TestController.h:
563         * WebKitTestRunner/TestInvocation.cpp:
564         * WebKitTestRunner/TestInvocation.h:
565         * WebKitTestRunner/WorkQueueManager.cpp:
566         (WTR::WorkQueueManager::processWorkQueue):
567         (WTR::WorkQueueManager::enqueue):
568         * WebKitTestRunner/WorkQueueManager.h:
569
570 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
571
572         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
573         https://bugs.webkit.org/show_bug.cgi?id=133119
574
575         Reviewed by Sergio Villar Senin.
576
577         Check that redirect response parameter of
578         WebKitWebPage::send-request signal is NULL when not redirecting
579         and a valid WebKitURIResponse object when redirecting.
580
581         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
582         (testWebResourceSendRequest):
583         (serverCallback):
584         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
585         (sendRequestCallback):
586
587 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
588
589         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
590         https://bugs.webkit.org/show_bug.cgi?id=133117
591
592         Reviewed by Philippe Normand.
593
594         Bring back missing tests to the build.
595
596         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
597
598 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
599
600         Take care of some ARM64 test failures
601         https://bugs.webkit.org/show_bug.cgi?id=133090
602
603         Reviewed by Geoffrey Garen.
604
605         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
606
607 2014-05-19  David Kilzer  <ddkilzer@apple.com>
608
609         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
610         <http://webkit.org/b/133089>
611
612         Reviewed by Darin Adler.
613
614         * Scripts/webkitdirs.pm:
615         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
616         specified on the command line, we would remove the '--sdk'
617         arguments, but leave '--sim', potentially passing it along to
618         xcodebuild causing a build failure.  This happens when
619         'old-run-webkit-tests --release --sim' invokes
620         build-dumprendertree when DumpRenderTree hasn't been built yet.
621
622 2014-05-19  David Farler  <dfarler@apple.com>
623
624         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
625         https://bugs.webkit.org/show_bug.cgi?id=133086
626
627         Reviewed by Daniel Bates.
628
629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
630
631 2014-05-19  David Kilzer  <ddkilzer@apple.com>
632
633         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
634         <http://webkit.org/b/132954>
635
636         * Scripts/webkitdirs.pm:
637         (sharedCommandLineOptionsUsage): Remove the prototype for the
638         subroutine.  Older perls don't like the "+@" syntax.
639
640 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
641
642         run-javascriptcore-tests should sort the list of failing stress tests
643         https://bugs.webkit.org/show_bug.cgi?id=132989
644
645         Reviewed by Csaba Osztrogonác.
646
647         * Scripts/run-javascriptcore-tests:
648
649 2014-05-19  David Kilzer  <ddkilzer@apple.com>
650
651         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
652         <http://webkit.org/b/132954>
653
654         Reviewed by Darin Adler.
655
656         Extract code into setupMacWebKitEnvironment() for setting up
657         common environment variables so it may be shared.  Sets
658         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
659         using guardmalloc to some scripts.
660
661         Also adds support for parsing shared (common) command-line
662         switches, initially just -g|--guard-malloc.
663
664         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
665         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
666         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
667         local copy of %ENV when launching Safari so we don't have to
668         restore variables.
669
670         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
671         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
672         Check result of GetOptions() to catch invalid command-line
673         switches.
674         (runTest): Use a local copy of %ENV when running tests so we
675         don't have to restore variables.
676         (prepareEnvironmentForRunningTestTool): Call
677         setupMacWebKitEnvironment().
678
679         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
680         using sharedCommandLineOptions() and
681         sharedCommandLineOptionsUsage().  Call
682         setupMacWebKitEnvironment().
683
684         * Scripts/webkitdirs.pm:
685         (sharedCommandLineOptions): Return array of common switches to
686         pass to Getopt::Long::GetOptions().
687         (sharedCommandLineOptionsUsage): Return formatted string of
688         common switches for printing usage help text.
689         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
690         guardmalloc.
691         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
692         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
693         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
694         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
695         local copy of %ENV when launching Safari so we don't have to
696         restore variables.
697         (execMacWebKitAppForDebugging): Call
698         setupMacWebKitEnvironment().
699
700 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
701
702         support for navigator.hardwareConcurrency
703         https://bugs.webkit.org/show_bug.cgi?id=132588
704
705         Reviewed by Filip Pizlo.
706
707         * Scripts/webkitperl/FeatureList.pm:
708
709 2014-05-18  Anders Carlsson  <andersca@apple.com>
710
711         Implement Navigations for all methods declared returning one
712         https://bugs.webkit.org/show_bug.cgi?id=133048
713         <rdar://problem/16830064>
714
715         Reviewed by Sam Weinig.
716
717         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
718         Import WebKit.h.
719         
720         * MiniBrowser/mac/WK2BrowserWindowController.m:
721         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
722         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
723         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
724         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
725         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
726         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
727         Print out the navigations.
728
729 2014-05-17  Zalan Bujtas  <zalan@apple.com>
730
731         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
732         https://bugs.webkit.org/show_bug.cgi?id=133029
733
734         Reviewed by Simon Fraser.
735
736         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
737         toggling it on a WK2 window needs restart.
738         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
739         the WebPreferences just to support this temporary toggle.
740
741         * MiniBrowser/mac/BrowserWindowController.h:
742         * MiniBrowser/mac/MainMenu.xib:
743         * MiniBrowser/mac/WK1BrowserWindowController.m:
744         (-[WK1BrowserWindowController validateMenuItem:]):
745         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
746         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
747         * MiniBrowser/mac/WK2BrowserWindowController.m:
748         (-[WK2BrowserWindowController validateMenuItem:]):
749         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
750         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
751
752 2014-05-17  Anders Carlsson  <andersca@apple.com>
753
754         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
755         https://bugs.webkit.org/show_bug.cgi?id=133033
756         <rdar://problem/16830143>
757
758         Reviewed by Sam Weinig.
759
760         Set up the WebSQL and IndexedDB directories.
761
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::initialize):
764
765 2014-05-16  Martin Hock  <mhock@apple.com>
766
767         MemoryCache::addImageToCache should return the result of add().
768         https://bugs.webkit.org/show_bug.cgi?id=132928
769         <rdar://problem/16651547>
770
771         Reviewed by Alexey Proskuryakov.
772
773         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
775         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
776         (TestWebKitAPI::TEST):
777
778 2014-05-15  David Farler  <dfarler@apple.com>
779
780         old-run-webkit-tests: allow specifying a simulator app path
781         https://bugs.webkit.org/show_bug.cgi?id=132975
782
783         Reviewed by Anders Carlsson.
784
785         * Scripts/old-run-webkit-tests:
786         (openIPhoneSimulator):
787         Add new --simulator-app command line parameter for specifying the
788         absolute path to the simulator app to launch before starting a
789         session.
790
791 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
792
793         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
794         https://bugs.webkit.org/show_bug.cgi?id=131363
795
796         Reviewed by Csaba Osztrogonác.
797
798         * Scripts/webkitpy/common/checkout/checkout_mock.py:
799         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
800         (MockBugzilla):
801         * Scripts/webkitpy/tool/commands/download_unittest.py:
802         (test_create_rollout_multiple_revision_with_one_resolved):
803         (test_create_rollout_multiple_resolved):
804         (test_rollout_two_revisions):
805         (test_rollout_multiple_revisions):
806         (test_rollout_multiple_revisions_with_a_missing_bug_id):
807         * Scripts/webkitpy/tool/steps/createbug.py:
808         (CreateBug.run):
809         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
810         (ReopenBugAfterRollout.run):
811
812 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
813
814         [WK2] Change the remaining framework includes from WebKit2 to WebKit
815         https://bugs.webkit.org/show_bug.cgi?id=132956
816
817         Reviewed by Sam Weinig.
818
819         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
820         * MiniBrowser/mac/AppDelegate.m:
821         * MiniBrowser/mac/WK2BrowserWindowController.m:
822         * TestWebKitAPI/InjectedBundleController.h:
823         * TestWebKitAPI/InjectedBundleMain.cpp:
824         * TestWebKitAPI/JavaScriptTest.cpp:
825         * TestWebKitAPI/PlatformUtilities.h:
826         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
827         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
828         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
829         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
830         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
831         (TestWebKitAPI::TEST):
832         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
833         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
834         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
835         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
836         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
837         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
838         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
839         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
840         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
841         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
842         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
843         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
844         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
845         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
846         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
847         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
848         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
849         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
850         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
851         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
852         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
853         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
854         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
855         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
856         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
857         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
858         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
859         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
860         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
861         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
862         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
863         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
864         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
865         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
866         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
867         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
868         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
869         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
870         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
871         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
872         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
873         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
874         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
875         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
876         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
877         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
878         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
879         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
880         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
881         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
882         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
883         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
884         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
885         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
886         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
887         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
888         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
889         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
890         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
891         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
892         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
893         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
894         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
895         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
896         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
897         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
898         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
899         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
900         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
901         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
902         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
903         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
904         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
905         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
906         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
907         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
908         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
909         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
910         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
911         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
912         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
913         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
914         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
915         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
916         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
917         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
918         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
919         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
920         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
921         * TestWebKitAPI/config.h:
922         * TestWebKitAPI/efl/PlatformWebView.cpp:
923         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
924         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
925         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
926         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
927         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
928         * WebKitTestRunner/EventSenderProxy.h:
929         * WebKitTestRunner/GeolocationProviderMock.cpp:
930         * WebKitTestRunner/GeolocationProviderMock.h:
931         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
932         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
933         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
934         * WebKitTestRunner/InjectedBundle/GCController.cpp:
935         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
936         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
937         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
938         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
940         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
941         * WebKitTestRunner/InjectedBundle/TestRunner.h:
942         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
943         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
944         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
946         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
947         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
948         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
949         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
950         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
951         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
952         * WebKitTestRunner/PlatformWebView.h:
953         * WebKitTestRunner/StringFunctions.h:
954         * WebKitTestRunner/TestController.cpp:
955         * WebKitTestRunner/TestController.h:
956         * WebKitTestRunner/TestInvocation.cpp:
957         * WebKitTestRunner/TestInvocation.h:
958         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
959         * WebKitTestRunner/WebNotificationProvider.cpp:
960         * WebKitTestRunner/WebNotificationProvider.h:
961         * WebKitTestRunner/WorkQueueManager.cpp:
962         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
963         * WebKitTestRunner/cg/TestInvocationCG.cpp:
964         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
965         * WebKitTestRunner/config.h:
966         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
967         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
968         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
969         * WebKitTestRunner/ios/TestControllerIOS.mm:
970         * WebKitTestRunner/mac/EventSenderProxy.mm:
971         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
972         * WebKitTestRunner/mac/TestControllerMac.mm:
973
974 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
975
976         [EFL][WK2] Skip failing unit tests
977         https://bugs.webkit.org/show_bug.cgi?id=132979
978
979         Reviewed by Daniel Bates.
980
981         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
982
983 2014-05-15  David Kilzer  <ddkilzer@apple.com>
984
985         [iOS] Support TestWebKitAPI in the iOS Simulator
986         <http://webkit.org/b/129535>
987         <rdar://problem/16203529>
988
989         Reviewed by Daniel Bates.
990
991         * Scripts/run-api-tests:
992         (runTest):
993         (listAllTests):
994         - Extract common arguments into local variable.
995         - Use xcrun to find the sim tool in order to invoke
996         TestWebKitAPI properly in the iOS Simulator. 
997
998         * Scripts/webkitdirs.pm:
999         (argumentsForConfiguration): Set --device or --sim as
1000         appropriate to fix buildTestTool() in run-api-tests.
1001
1002 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1003
1004         Fix a logging typo in copy-webkitlibraries-to-product-directory
1005
1006         Reviewed by Dean Jackson.
1007
1008         * Scripts/copy-webkitlibraries-to-product-directory:
1009
1010 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1011
1012         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1013         <http://webkit.org/b/132959>
1014
1015         Reviewed by Dan Bernstein.
1016
1017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1018         Cocoa directory to project and move URLExtras.mm into it.
1019         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1020
1021 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         [GTK] Compile all installed resources as GResources
1024         https://bugs.webkit.org/show_bug.cgi?id=131099
1025
1026         Reviewed by Philippe Normand.
1027
1028         * Scripts/webkitpy/port/gtk.py:
1029         (GtkPort.setup_environ_for_server): Removed now unneeded
1030         AUDIO_RESOURCES_PATH env var.
1031
1032 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1033
1034         Remove CSS_STICKY_POSITION guards
1035         https://bugs.webkit.org/show_bug.cgi?id=132676
1036
1037         Reviewed by Simon Fraser.
1038
1039         * Scripts/webkitperl/FeatureList.pm:
1040
1041 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1042
1043         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1044         https://bugs.webkit.org/show_bug.cgi?id=132686
1045
1046         Reviewed by Philippe Normand.
1047
1048         Bring back InputMethodFilter test to the build and compile it into
1049         a single binary TestWebCore with the other WebCore tests. Also
1050         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1051
1052         * Scripts/run-gtk-tests:
1053         (TestRunner): Remove WebCoreGtk from the list of test directories.
1054         * TestWebKitAPI/PlatformGTK.cmake:
1055         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1056
1057 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1058
1059         [EFL] Make XVFBDriver optional
1060         https://bugs.webkit.org/show_bug.cgi?id=131036
1061
1062         Reviewed by Gyuyoung Kim.
1063
1064         * Scripts/webkitpy/port/efl.py:
1065         (EflPort._driver_class):
1066
1067 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1068
1069         Flakiness dashboard contains outdated list of bots on builders.jsonp
1070         https://bugs.webkit.org/show_bug.cgi?id=132874
1071
1072         Reviewed by Darin Adler.
1073
1074         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1075         file by changing to the directory Tools/TestResultServer and executing
1076         the script generate_builders_json.py
1077
1078 2014-05-11  Anders Carlsson  <andersca@apple.com>
1079
1080         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1081         https://bugs.webkit.org/show_bug.cgi?id=132809
1082
1083         Reviewed by Dan Bernstein.
1084
1085         * WebKitTestRunner/TestController.cpp:
1086         (WTR::TestController::initialize):
1087         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1088
1089 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1090
1091         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1092         https://bugs.webkit.org/show_bug.cgi?id=132739
1093
1094         Reviewed Anders Carlsson.
1095
1096         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1097         the JSC unit tests.
1098         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1099
1100 2014-05-11  Anders Carlsson  <andersca@apple.com>
1101
1102         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1103         https://bugs.webkit.org/show_bug.cgi?id=132806
1104
1105         Reviewed by Beth Dakin.
1106
1107         Migrate to WKContextConfiguration.
1108
1109         * WebKitTestRunner/TestController.cpp:
1110         (WTR::TestController::initialize):
1111
1112 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1115         https://bugs.webkit.org/show_bug.cgi?id=132685
1116
1117         Reviewed by Martin Robinson.
1118
1119         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1120
1121         * TestWebKitAPI/PlatformGTK.cmake:
1122
1123 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1124
1125         [iOS] Switch geolocation to an explicit authorization query model
1126         https://bugs.webkit.org/show_bug.cgi?id=132717
1127
1128         Reviewed by Sam Weinig.
1129
1130         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1131         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1132         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1133
1134 2014-05-09  David Farler  <dfarler@apple.com>
1135
1136         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1137         https://bugs.webkit.org/show_bug.cgi?id=132718
1138
1139         Reviewed by David Kilzer.
1140
1141         The simulator may not be able to look up runtimes by SDK paths
1142         and instead will map SDK versions to runtimes instead. In
1143         com.apple.iphonesimulator.startSession notifications,
1144         'runtimeIdentifier' (SDK version string) is preferred over
1145         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1146         when creating a new DRT or WKTR simulator session.
1147
1148         IPhoneSimulatorNotification.pm filters out keys for this
1149         notification's userInfo with a hard-coded list. There's no harm
1150         in including extra key-value pairs in an NSNotification userInfo
1151         dictionary anyway and the simulator may again change its
1152         userInfo schema for this notification.
1153
1154         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1155         (postStartSessionNotification):
1156         * Scripts/old-run-webkit-tests:
1157         (installAndLaunchDumpToolAppUsingNotification):
1158
1159 2014-05-09  Anders Carlsson  <andersca@apple.com>
1160
1161         Another build fix.
1162
1163         * Scripts/build-webkit:
1164         WebKit2 should always be built for OS X and iOS.
1165
1166 2014-05-09  Anders Carlsson  <andersca@apple.com>
1167
1168         Follow-up build fix.
1169
1170         * Scripts/build-webkit:
1171         WebKit2 should no longer be built before WebKit.
1172
1173 2014-05-09  Anders Carlsson  <andersca@apple.com>
1174
1175         Rename WebKit2.framework to WebKit.framework
1176         https://bugs.webkit.org/show_bug.cgi?id=132743
1177         <rdar://problem/15920046>
1178
1179         Reviewed by Dan Bernstein.
1180
1181         * Scripts/check-for-inappropriate-files-in-framework:
1182         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1183         Change WebKit2 to WebKit.
1184
1185         * Scripts/check-for-webkit-framework-include-consistency:
1186         Change WebKit to WebKitLegacy.
1187
1188 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1189
1190         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1191         https://bugs.webkit.org/show_bug.cgi?id=132732
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1198         (EWS): Remove GTK+ WK1 EWS.
1199
1200 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1201
1202         Add new u-szeged contributors.
1203
1204         Reviewed by Csaba Osztrogonác.
1205
1206         * Scripts/webkitpy/common/config/contributors.json:
1207
1208 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1209
1210         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1211         https://bugs.webkit.org/show_bug.cgi?id=132736
1212
1213         Reviewed by Philippe Normand.
1214
1215         There are two problems, the path returned by common.library_build_path() is wrong when
1216         common.binary_build_path() has previously been called, and the test is still looking for
1217         the .la instead of .so
1218
1219         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1220         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1221         of .la as extension of the injected bundle library.
1222         * gtk/common.py:
1223         (binary_build_path): Remove unused global variable and add a new
1224         one for binary_build_dir instead of sharing the same global
1225         variable for library_build_path and binary_build_path.
1226
1227 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1228
1229         [EFL] Enable MEDIA_STREAM for EFL port
1230         https://bugs.webkit.org/show_bug.cgi?id=132648
1231
1232         Reviewed by Gyuyoung Kim.
1233
1234         Script modified to enable MEDIA_STREAM for EFL build.
1235
1236         * Scripts/webkitperl/FeatureList.pm: 
1237
1238 2014-05-08  David Farler  <dfarler@apple.com>
1239
1240         old-run-webkit-tests: update strings for simulator devices and app name
1241         https://bugs.webkit.org/show_bug.cgi?id=132687
1242
1243         Reviewed by Darin Adler.
1244
1245         iPhone Retina (4-inch) -> iPhone 5
1246         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1247
1248         * Scripts/old-run-webkit-tests:
1249         (installAndLaunchDumpToolAppUsingNotification):
1250         (openIPhoneSimulator):
1251         (quitIPhoneSimulator):
1252         quit iOS Simulator, not iPhone Simulator.
1253
1254 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1255
1256         REGRESSION(r168471): Update the builder names on the scheduler list.
1257         https://bugs.webkit.org/show_bug.cgi?id=132699
1258
1259         Reviewed by Martin Robinson.
1260
1261         On r168471 I missed to update the builder names for the GTK build
1262         bots on the AnyBranchScheduler type scheduler list of bots.
1263
1264         * BuildSlaveSupport/build.webkit.org-config/config.json:
1265
1266 2014-05-08  Brady Eidson  <beidson@apple.com>
1267
1268         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1269         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1270
1271         Reviewed by Tim Horton.
1272
1273         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1274         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1275
1276 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1277
1278         REGRESSION(r168471): Duplicate builddirs broke the build master.
1279         https://bugs.webkit.org/show_bug.cgi?id=132688
1280
1281         Reviewed by Carlos Garcia Campos.
1282
1283         Rename the builddirs of the new GTK bots introduced on r168471 to
1284         be unique. Otherwise the master will break.
1285
1286         * BuildSlaveSupport/build.webkit.org-config/config.json:
1287
1288 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1289
1290         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1291         https://bugs.webkit.org/show_bug.cgi?id=132674
1292
1293         Reviewed by Philippe Normand.
1294
1295         Only ignore mkdir failure when exception is raised because the
1296         file already exists and it's a directory.
1297
1298         * gtk/webkitdom.py:
1299         (write_doc_files):
1300
1301 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1302
1303         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1304         https://bugs.webkit.org/show_bug.cgi?id=131358
1305
1306         Reviewed by Carlos Garcia Campos.
1307
1308         Current 64-bit GTK build bots (Release and Debug) not only test
1309         the build, but run all tests. Split each one of the bots in
1310         BuildOnly and TestWebKit2.
1311
1312         This will allow us to have a better overview of the status of
1313         the GTK port.
1314
1315         Original patch from Sergio Villar Senin <svillar@igalia.com>
1316
1317         * BuildSlaveSupport/build.webkit.org-config/config.json:
1318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1320         (WebKitBuildbot):
1321         * Scripts/webkitpy/port/builders.py:
1322         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1323         (TestRebaselineTest.test_baseline_directory):
1324         * TestResultServer/static-dashboards/builders.jsonp:
1325         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1326         (resetGlobals):
1327         * TestResultServer/static-dashboards/loader_unittests.js:
1328
1329 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1330
1331         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1332         https://bugs.webkit.org/show_bug.cgi?id=126022
1333
1334         Reviewed by Benjamin Poulain.
1335
1336         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1337
1338         Added an unit test case to check if scroll position and scale are restored properly.
1339
1340         * TestWebKitAPI/PlatformEfl.cmake:
1341         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1342         (TestWebKitAPI::didFinishLoadForFrame):
1343         (TestWebKitAPI::didChangeContentsPosition):
1344         (TestWebKitAPI::TEST):
1345         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1346         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1347
1348 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1349
1350         WebKit1 is flashy when compositing layers come and go
1351         https://bugs.webkit.org/show_bug.cgi?id=132655
1352         <rdar://problem/16830981&16788846>
1353
1354         Reviewed by Sam Weinig.
1355         
1356         Revert the change from r166117.
1357
1358         * DumpRenderTree/mac/DumpRenderTree.mm:
1359         (updateDisplay):
1360
1361 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1362
1363         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1364         https://bugs.webkit.org/show_bug.cgi?id=132622
1365
1366         Reviewed by Mario Sanchez Prada.
1367
1368         * DumpRenderTree/AccessibilityUIElement.cpp:
1369         (selectTextWithCriteriaCallback):
1370         (isEqualCallback):
1371         * DumpRenderTree/AccessibilityUIElement.h:
1372         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1373         (AccessibilityUIElement::selectTextWithCriteria):
1374         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1375         (AccessibilityUIElement::selectTextWithCriteria):
1376         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1377         (selectTextParameterizedAttributeForCriteria):
1378         (AccessibilityUIElement::selectTextWithCriteria):
1379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1380         (AccessibilityUIElement::selectTextWithCriteria):
1381         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1382         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1384         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1385         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1386         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1387         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1388         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1389         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1390         (WTR::selectTextParameterizedAttributeForCriteria):
1391         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1392
1393 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1394
1395         [SOUP] TLSErrors do not cause page load to fail when not ignored
1396         https://bugs.webkit.org/show_bug.cgi?id=121548
1397
1398         Reviewed by Sergio Villar Senin.
1399
1400         Add unit tests to check that the load fails with TLS errors in
1401         case of a redirection.
1402
1403         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1404         (testTLSErrorsRedirect):
1405         (httpsServerCallback):
1406         (beforeAll):
1407
1408 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1409
1410         [CSS Grid Layout] Remove runtime feature
1411         https://bugs.webkit.org/show_bug.cgi?id=132382
1412
1413         Reviewed by Benjamin Poulain.
1414
1415         Remove cssGridLayoutEnabled setting usage.
1416
1417         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1418         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1419         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1420         (TestRunner::overridePreference):
1421         * DumpRenderTree/mac/DumpRenderTree.mm:
1422         (resetWebPreferencesToConsistentValues):
1423
1424 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1425
1426         Add Makefile targets for copying static libraries (LLVM and WKSI)
1427         <http://webkit.org/b/132619>
1428
1429         Reviewed by Mark Rowe.
1430
1431         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1432         sensible default for product directory if not specified on
1433         either the command-line or in the environment (by Xcode) by
1434         calling productDir() in webkitdirs.pm.
1435
1436 2014-05-06  Brady Eidson  <beidson@apple.com>
1437
1438         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1439         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1440
1441         Reviewed by Sam Weinig.
1442
1443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1444
1445         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1446         (TestWebKitAPI::itemURLLastComponentIsString):
1447         (TestWebKitAPI::didFinishLoadForFrame):
1448         (TestWebKitAPI::willGoToBackForwardListItem):
1449         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1450         (TestWebKitAPI::setPageLoaderClient):
1451         (TestWebKitAPI::TEST):
1452         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1453         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1454
1455         * WebKitTestRunner/TestController.cpp:
1456         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1457
1458 2014-05-06  Darin Adler  <darin@apple.com>
1459
1460         Try to fix iOS build.
1461
1462         * DumpRenderTree/mac/TestRunnerMac.mm:
1463         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1464         Updated since I changed testRunner into a pointer instead of a reference.
1465         Updated argument names to avoid conflict with field names.
1466         (-[APITestDelegateIPhone run]): Ditto.
1467         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1468
1469 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1470
1471         Unreviewed, rolling out r168304.
1472         https://bugs.webkit.org/show_bug.cgi?id=132607
1473
1474         Broke the build (Requested by KaL on #webkit).
1475
1476         Reverted changeset:
1477
1478         "[GTK][CMake] Unable to do make install"
1479         https://bugs.webkit.org/show_bug.cgi?id=130188
1480         http://trac.webkit.org/changeset/168304
1481
1482 2014-05-04  Darin Adler  <darin@apple.com>
1483
1484         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1485         https://bugs.webkit.org/show_bug.cgi?id=80222
1486
1487         Reviewed by Alexey Proskuryakov.
1488
1489         * DumpRenderTree/mac/TestRunnerMac.mm:
1490         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1491         do more work here so we don't use RetainPtr local variables.
1492         (-[APITestDelegateIPhone dealloc]): Added.
1493         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1494         created. Updated for changes to member names and types.
1495         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1496         updated for changes to member names and types. Changed to two word spelling.
1497         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1498         name of _cleanUp method.
1499         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1500         Ditto.
1501         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1502
1503 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1504
1505         Clean up Image Document and tweak the layout and viewport
1506         https://bugs.webkit.org/show_bug.cgi?id=132552
1507
1508         Reviewed by Anders Carlsson.
1509
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (resetWebPreferencesToConsistentValues):
1512         Update the default settings to have something consistent with WebKit2.
1513
1514 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1515
1516         [GTK][CMake] Unable to do make install
1517         https://bugs.webkit.org/show_bug.cgi?id=130188
1518
1519         Reviewed by Carlos Garcia Campos.
1520
1521         * Scripts/webkitdirs.pm:
1522         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1523         will give an early signal that a change has broken the documentation.
1524
1525 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1526
1527         Update framework locations in package-root
1528         https://bugs.webkit.org/show_bug.cgi?id=132571
1529
1530         Reviewed by Simon Fraser.
1531
1532         * Scripts/package-root:
1533
1534 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1535
1536         [EFL][WK2] Refactor favicon database APIs
1537         https://bugs.webkit.org/show_bug.cgi?id=132519
1538
1539         Reviewed by Gyuyoung Kim.
1540
1541         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1542         (update_view_favicon):
1543         (on_icon_changed_cb):
1544         (window_free):
1545         (on_url_changed):
1546         (window_create):
1547         (on_view_favicon_changed): Deleted.
1548
1549 2014-05-02  Mark Rowe  <mrowe@apple.com>
1550
1551         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1552
1553         Reviewed by Dan Bernstein.
1554
1555         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1556         when determining which LLVM archive to extract.
1557
1558 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1559
1560         Add Jeremy as a committer.
1561         https://bugs.webkit.org/show_bug.cgi?id=132492
1562
1563         Reviewed by Jer Noble.
1564
1565         Add myself as a committer.
1566
1567         * Scripts/webkitpy/common/config/contributors.json:
1568
1569 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1570
1571         Add Jeremy as a committer.
1572         https://bugs.webkit.org/show_bug.cgi?id=132492
1573
1574         Reviewed by Jer Noble.
1575
1576         Add Jeremy Jones to the committers file.
1577
1578         * Scripts/webkitpy/common/config/contributors.json:
1579
1580 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1581
1582         Hard to figure out how to run a single test with run-api-tests
1583         https://bugs.webkit.org/show_bug.cgi?id=116332
1584
1585         Reviewed by Alexey Proskuryakov.
1586
1587         * Scripts/run-api-tests: add two examples to the help message.
1588
1589 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1590
1591         Fix several memory leaks found by code inspection
1592         https://bugs.webkit.org/show_bug.cgi?id=132472
1593
1594         Reviewed by Geoffrey Garen.
1595         
1596         Fix memory leaks.
1597
1598         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1599         (TestWebKitAPI::TEST):
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1601         (WTR::InjectedBundlePage::willSendRequestForFrame):
1602         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1603         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1604
1605 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1606
1607         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1608         https://bugs.webkit.org/show_bug.cgi?id=132446
1609
1610         Reviewed by Mark Hahnenberg.
1611         
1612         Test the FTL by default now that it's enabled by default.
1613
1614         * Scripts/run-javascriptcore-tests:
1615
1616 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1617
1618         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1619         https://bugs.webkit.org/show_bug.cgi?id=132240
1620
1621         Reviewed by Anders Carlsson.
1622
1623         Removed ewk_view_setting_tiled_backingstore related code.
1624
1625         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1626         (DumpRenderTreeChrome::createView):
1627         (shouldUseTiledBackingStore): Deleted.
1628         * EWebLauncher/main.c:
1629         (windowCreate):
1630         (parseUserArguments):
1631
1632 2014-05-01  Anders Carlsson  <andersca@apple.com>
1633
1634         window.testRunner.keepWebHistory() should update the UI process state
1635         https://bugs.webkit.org/show_bug.cgi?id=132440
1636
1637         Reviewed by Dan Bernstein.
1638
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1641         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1643         (WTR::TestRunner::keepWebHistory):
1644         * WebKitTestRunner/TestInvocation.cpp:
1645         (WTR::TestInvocation::invoke):
1646         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1647
1648 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1649
1650         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1651         <http://webkit.org/b/132432>
1652
1653         Reviewed by Tim Horton.
1654
1655         * Scripts/webkitperl/FeatureList.pm: Remove support for
1656         --plugin-proxy-for-video switch.
1657
1658 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1659
1660         Kernel sysctl interface hw.activecpu don't exists on Linux.
1661         https://bugs.webkit.org/show_bug.cgi?id=132286
1662
1663         Reviewed by Filip Pizlo.
1664
1665         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1666         calling sysctl over hw.activecpu
1667
1668 2014-04-30  Anders Carlsson  <andersca@apple.com>
1669
1670         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1671         https://bugs.webkit.org/show_bug.cgi?id=132399
1672         <rdar://problem/15920046>
1673
1674         Reviewed by Dan Bernstein.
1675
1676         * Scripts/check-for-webkit-framework-include-consistency:
1677         Allos WAK headers in WebKitLegacy as well as WebKit.
1678
1679         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1680         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1681         Update header imports.
1682
1683 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1684
1685         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1686         https://bugs.webkit.org/show_bug.cgi?id=131954
1687
1688         Reviewed by Darin Adler.
1689         
1690         WebKitTestRunner was adding application-specific information to crash reports
1691         to log the test path, but only in the web process. Fix it to also do this
1692         for the UI process, for both iOS and OS X.
1693         
1694         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1695         both iOS and OS X.
1696         
1697         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1698         a new TestController::platformWillRunTest() function on Mac and iOS.
1699         
1700         Also remove Xcode-added unit test junk from the project.
1701
1702         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1703         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1704         * WebKitTestRunner/TestController.cpp:
1705         (WTR::TestController::runTest):
1706         * WebKitTestRunner/TestController.h:
1707         * WebKitTestRunner/TestInvocation.cpp:
1708         (WTR::TestInvocation::url):
1709         * WebKitTestRunner/TestInvocation.h:
1710         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1711         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1712         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1713         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1714         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1715         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1716         (WTR::testPathFromURL):
1717         (WTR::setCrashReportApplicationSpecificInformationToURL):
1718         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1719         (WTR::TestController::platformWillRunTest):
1720         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1721         (WTR::TestController::platformWillRunTest):
1722         * WebKitTestRunner/ios/TestControllerIOS.mm:
1723         (WTR::TestController::platformWillRunTest):
1724         (WTR::TestController::setHidden):
1725         * WebKitTestRunner/mac/TestControllerMac.mm:
1726         (WTR::TestController::platformWillRunTest):
1727
1728 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1729
1730         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1731
1732         Reviewed by Tim Horton.
1733
1734         * DumpRenderTree/mac/DumpRenderTree.mm:
1735         (resetWebPreferencesToConsistentValues):
1736         (prepareConsistentTestingEnvironment):
1737
1738 2014-04-30  Anders Carlsson  <andersca@apple.com>
1739
1740         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1741         https://bugs.webkit.org/show_bug.cgi?id=132397
1742
1743         Reviewed by Dan Bernstein.
1744
1745         * Scripts/check-for-inappropriate-macros-in-external-headers:
1746
1747 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1748
1749         [GTK] Make it easier to run CMake for downstreams
1750         https://bugs.webkit.org/show_bug.cgi?id=132370
1751
1752         Reviewed by Carlos Garcia Campos.
1753
1754         * Scripts/webkitdirs.pm:
1755         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1756         the GTK+ port.
1757
1758 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1759
1760         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1761         
1762         Rubber stamped by Jessie Berlin.
1763
1764         JSON.pm was removed from our tools setup.
1765
1766         * Scripts/generate-coverage-data:
1767
1768 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1769
1770         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1771         https://bugs.webkit.org/show_bug.cgi?id=112840
1772
1773         Rubber stamped by Geoffrey Garen.
1774
1775         * Scripts/build-jsc: Enable it on Mac.
1776         * Scripts/build-webkit: Enable it on Mac.
1777         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1778
1779 2014-04-28  Sam Weinig  <sam@webkit.org>
1780
1781         REGRESSION (r167751): svn-create-patch is very slow
1782         https://bugs.webkit.org/show_bug.cgi?id=132300
1783
1784         Reviewed by Alexey Proskuryakov.
1785
1786         * Scripts/svn-create-patch:
1787         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1788         by calling `svn-create-patch --style`.
1789
1790 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1791
1792         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1793         https://bugs.webkit.org/show_bug.cgi?id=132190
1794
1795         Reviewed by Gustavo Noronha Silva.
1796
1797         * Scripts/webkitdirs.pm:
1798         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1799             if ninja is in the path.
1800         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1801             to the previous ninja generator if not.
1802
1803 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1804
1805         check-webkit-style should understand --git-index
1806         https://bugs.webkit.org/show_bug.cgi?id=125364
1807
1808         Reviewed by Csaba Osztrogonác.
1809
1810         * Scripts/webkitpy/common/checkout/scm/git.py:
1811         (Git.create_patch): The command now supports the --cached option.
1812         * Scripts/webkitpy/style/main.py:
1813         (CheckWebKitStyle.main): Passing the --git-index option.
1814         * Scripts/webkitpy/style/optparser.py:
1815         (CommandOptionValues.__init__): The git-index option is switched off by default.
1816         (CommandOptionValues.__eq__): Equality check for the new option.
1817         (ArgumentParser._create_option_parser):Adding the --git-index option
1818         (ArgumentParser.parse):
1819         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1820         (CommandOptionValuesTest.test_init): 
1821         (CommandOptionValuesTest.test_eq):
1822
1823 2014-04-28  Michael Saboff  <msaboff@apple.com>
1824
1825         Crash in platform/mac/accessibility/table-visible-rows.html
1826         https://bugs.webkit.org/show_bug.cgi?id=132146
1827
1828         Reviewed by Filip Pizlo.
1829
1830         Instead of creating a local JSValueRef array on the stack and passing that to
1831         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1832         values using the JSObjectSetPropertyAtIndex() API.
1833
1834         * DumpRenderTree/AccessibilityUIElement.cpp:
1835         (elementsForRangeCallback):
1836         (convertElementsToObjectArray):
1837         * DumpRenderTree/mac/TestRunnerMac.mm:
1838         (originsArrayToJS):
1839         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1840         (WTR::EventSendingController::contextClick):
1841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1842         (WTR::stringArrayToJS):
1843         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1844         (WTR::convertElementsToObjectArray):
1845
1846 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1847
1848         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1849         "no-cjit" runs force the old-school threshold.
1850
1851         Rubber stamped by Mark Hahnenberg.
1852
1853         * Scripts/run-jsc-stress-tests:
1854
1855 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1856
1857         [GTK] install-dependencies should also install ruby-json and ruby-highline
1858         https://bugs.webkit.org/show_bug.cgi?id=132292
1859
1860         Reviewed by Philippe Normand.
1861
1862         * gtk/install-dependencies: Install ruby json and highline packages.
1863
1864 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1865
1866         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1867         https://bugs.webkit.org/show_bug.cgi?id=132176
1868
1869         Reviewed by Gyuyoung Kim.
1870
1871         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1872         and turn off indexedDB feature until the sqlite implementation is introduced.
1873
1874         * Scripts/webkitperl/FeatureList.pm:
1875
1876 2014-04-25  James Craig  <jcraig@apple.com>
1877
1878         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1879         https://bugs.webkit.org/show_bug.cgi?id=132209
1880
1881         Reviewed by Daniel Bates.
1882
1883         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1884         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1885
1886         * Scripts/prepare-ChangeLog:
1887         (main): 
1888
1889 2014-04-25  Michael Saboff  <msaboff@apple.com>
1890
1891         Crash in platform/mac/accessibility/table-visible-rows.html
1892         https://bugs.webkit.org/show_bug.cgi?id=132146
1893
1894         Reviewed by Mark Lam.
1895
1896         Changed to use a local JSValueRef array temporary instead of a
1897         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1898         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1899         the temporary values could be collected.
1900
1901         * DumpRenderTree/AccessibilityUIElement.cpp:
1902         (convertElementsToObjectArray):
1903         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1904         (WTR::EventSendingController::contextClick):
1905         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1906         (WTR::convertElementsToObjectArray):
1907
1908 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1909
1910         Unreviewed GTK gardening
1911
1912         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1913         (TestRunner):
1914
1915 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1916
1917         prepare-ChangeLog reports as deleted methods that has not been removed.
1918         https://bugs.webkit.org/show_bug.cgi?id=131733
1919
1920         Reviewed by Ryosuke Niwa.
1921
1922         * Scripts/prepare-ChangeLog:
1923         (originalFile): Set merge base to origin/master by default.
1924
1925 2014-04-23  James Craig  <jcraig@apple.com>
1926
1927         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1928         https://bugs.webkit.org/show_bug.cgi?id=131115
1929
1930         Reviewed by Daniel Bates.
1931
1932         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1933
1934         * Scripts/commit-log-editor: Added --no-style.
1935         * Scripts/prepare-ChangeLog: Primary patch.
1936         (main): Primary patch.
1937         (createPatchCommand): Added --no-style.
1938         * Scripts/svn-create-patch: Primary patch.
1939         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1940         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1941         (SVN.create_patch): Added --no-style.
1942
1943 2014-04-23  Anders Carlsson  <andersca@apple.com>
1944
1945         Try to fix iOS build.
1946
1947         * DumpRenderTree/mac/DumpRenderTree.mm:
1948
1949 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
1950
1951         Eliminate internals.setMockScrollbarsEnabled()
1952         https://bugs.webkit.org/show_bug.cgi?id=132085
1953
1954         Reviewed by Tim Horton.
1955
1956         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
1957         No need to reset the preference, there is no way it can change.
1958
1959 2014-04-23  James Craig  <jcraig@apple.com>
1960
1961         Unreviewed. Moving myself from Contributors to Committers list.
1962
1963         * Scripts/webkitpy/common/config/contributors.json:
1964
1965 2014-04-23  Tim Horton  <timothy_horton@apple.com>
1966
1967         Mock scrollbars don't always work in DumpRenderTree
1968         https://bugs.webkit.org/show_bug.cgi?id=132082
1969
1970         Reviewed by Alexey Proskuryakov.
1971
1972         * DumpRenderTree/mac/DumpRenderTree.mm:
1973         (prepareConsistentTestingEnvironment):
1974         Set the mock scrollbar setting before creating the WebView, as this setting
1975         cannot be dynamically changed, so any scrollbars that are created during
1976         WebView initialization and are not replaced before snapshotting will end
1977         up being platform scrollbars instead of mock ones.
1978         WebKitTestRunner already sets this preference before creating WKViews,
1979         so we're just matching its behavior.
1980
1981 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1982
1983         [GTK] ShadowRoot API was removed in r164131
1984         https://bugs.webkit.org/show_bug.cgi?id=132059
1985
1986         Reviewed by Gustavo Noronha Silva.
1987
1988         Add WebKitDOMShadowRoot to the list of deleted classes to generate
1989         the API docs.
1990
1991         * gtk/webkitdom.py:
1992         (WebKitDOMDocGenerator):
1993
1994 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
1995
1996         [GTK] run-webkit-tests script is failing to invoke run-launcher
1997         https://bugs.webkit.org/show_bug.cgi?id=132051
1998
1999         Reviewed by Philippe Normand.
2000
2001         After the WK1 support was dropped, if run-webkit-tests is executed
2002         without --no-show-results parameter, the launcher is being called
2003         using a -2 parameter that is it causing the run-launcher to break.
2004
2005         * Scripts/webkitpy/port/gtk.py:
2006         (GtkPort.show_results_html_file):
2007
2008 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2009
2010         DumpRenderTree generates black snapshots on some platforms
2011         https://bugs.webkit.org/show_bug.cgi?id=132029
2012         <rdar://problem/16679363>
2013
2014         Reviewed by Simon Fraser.
2015
2016         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2017         (createBitmapContextFromWebView):
2018         DRT checks with the WebView to determine whether it can use the window's
2019         backing store directly or (because of compositing) needs to take a WindowServer
2020         snapshot. However, on some platforms and in some situations, the window can
2021         be layer backed without the WebView necessarily currently being composited.
2022         We should check with the window in addition to the WebView before going
2023         ahead and using its backing store.
2024
2025 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2026
2027         DumpRenderTree generates white snapshots on some platforms
2028         https://bugs.webkit.org/show_bug.cgi?id=132026
2029         <rdar://problem/16679363>
2030
2031         Reviewed by Simon Fraser.
2032
2033         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2034         Link DRT against QuartzCore.
2035
2036         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2037         (createBitmapContextFromWebView):
2038         Force CoreAnimation to synchronously update layers in a more explicit
2039         way that doesn't depend on AppKit behavior. This is very similar to what
2040         WebKitTestRunner does (indirectly) during its force repaint.
2041
2042 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2043
2044         [Win] Support Python 2.7 in Cygwin
2045         https://bugs.webkit.org/show_bug.cgi?id=132023
2046
2047         Reviewed by Michael Saboff.
2048
2049         * Scripts/webkitdirs.pm:
2050         (checkInstalledTools): Remove check for Python 2.7, since
2051         it now works properly.
2052
2053 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2054
2055         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2056         https://bugs.webkit.org/show_bug.cgi?id=130867
2057         <rdar://problem/16432456> 
2058
2059         Reviewed by Mark Hahnenberg.
2060
2061         * Scripts/build-webkit:
2062         * Scripts/copy-webkitlibraries-to-product-directory:
2063
2064 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2065
2066         [GTK] Fails to build documentation when output is redirected
2067         https://bugs.webkit.org/show_bug.cgi?id=131178
2068
2069         Reviewed by Martin Robinson.
2070
2071         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2072         explicitly to avoid encoding issues when they are redirected.
2073
2074 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2075
2076         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2077         https://bugs.webkit.org/show_bug.cgi?id=131911
2078
2079         Reviewed by Martin Robinson.
2080
2081         common.get_build_path returns release path even though Debug configuration
2082         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2083
2084         * gtk/ycm_extra_conf.py:
2085         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2086         (FlagsForFile):
2087
2088 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2089
2090         Unreviewed build fix.
2091
2092         * DumpRenderTree/mac/EventSendingController.mm:
2093         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2094         Correct a typo that prevented tests from working properly.
2095
2096 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2097
2098         [GTK] Should have the ability to output composited contents during layout testing
2099         https://bugs.webkit.org/show_bug.cgi?id=131864
2100
2101         Reviewed by Philippe Normand.
2102
2103         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2104         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2105         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2106         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2107         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2108
2109 2014-04-21  Sam Weinig  <sam@webkit.org>
2110
2111         Attempt to fix the tests.
2112
2113         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2114         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2115         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2116
2117 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2118
2119         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2120         being the same as a "quick run", which is meant for genuinely slow tests).
2121
2122         * Scripts/run-jsc-stress-tests:
2123
2124 2014-04-21  Darin Adler  <darin@apple.com>
2125
2126         Add HashSet::takeAny
2127         https://bugs.webkit.org/show_bug.cgi?id=131928
2128
2129         Reviewed by Benjamin Poulain.
2130
2131         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2132
2133 2014-04-20  Dan Bernstein  <mitz@apple.com>
2134
2135         Fixed a test timing out after r167572.
2136
2137         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2138         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2139         -webView:didFinishLoadingNavigation:.
2140
2141 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2142
2143         Unreviewed, rolling out r167510.
2144         https://bugs.webkit.org/show_bug.cgi?id=131915
2145
2146         broke GTK Debug bot (Requested by philn on #webkit).
2147
2148         Reverted changeset:
2149
2150         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2151         it when running layout tests"
2152         https://bugs.webkit.org/show_bug.cgi?id=131472
2153         http://trac.webkit.org/changeset/167510
2154
2155 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2156
2157         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2158         https://bugs.webkit.org/show_bug.cgi?id=131472
2159
2160         Reviewed by Philippe Normand.
2161
2162         * Scripts/webkitpy/port/gtk.py:
2163         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2164         when running WebKitTestRunner with run-webkit-tests.
2165         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2166         installed.
2167         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2168         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2169         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2170         deal.
2171
2172 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2173
2174         DownloadDecideDestinationCrash API test uses an incorrect value for path
2175         https://bugs.webkit.org/show_bug.cgi?id=131845
2176         <rdar://problem/15925560>
2177
2178         Reviewed by Enrica Casucci.
2179
2180         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2181         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2182
2183 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2184
2185         [Mac] AttributedStringTest API tests fail with async text input
2186         https://bugs.webkit.org/show_bug.cgi?id=131833
2187
2188         Reviewed by Enrica Casucci.
2189
2190         Don't run sync NSTextInputClient tests where we don't implement these calls.
2191
2192         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2193         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2194         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2195         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2196         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2197         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2198         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2199
2200 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2201
2202         Remove NETWORK_INFO support
2203         https://bugs.webkit.org/show_bug.cgi?id=131841
2204
2205         Reviewed by Gyuyoung Kim.
2206
2207         * Scripts/webkitperl/FeatureList.pm:
2208
2209 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2210
2211         [GTK] YouCompleteMe doesn't work for cmake build system.
2212         https://bugs.webkit.org/show_bug.cgi?id=131591
2213
2214         Reviewed by Martin Robinson.
2215
2216         Add cmake build system support for YouCompleteMe. It should work regardless of
2217         using make or ninja. In addition, autotools related code is removed since it's
2218         not used anymore in WebKit.
2219
2220         * Scripts/webkitdirs.pm:
2221         (generateBuildSystemFromCMakeProject):
2222         * gtk/ycm_extra_conf.py:
2223         (transform_relative_paths_to_absolute_paths):
2224         (FlagsForFile):
2225
2226 2014-04-17  Anders Carlsson  <andersca@apple.com>
2227
2228         Fix build.
2229
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2231         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2232         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2233
2234 2014-04-17  Anders Carlsson  <andersca@apple.com>
2235
2236         Remove unused API enums
2237         https://bugs.webkit.org/show_bug.cgi?id=131836
2238
2239         Reviewed by Tim Horton.
2240
2241         * MiniBrowser/mac/WK2BrowserWindowController.m:
2242         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2243
2244 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2245
2246         [Win] A few final cleanups to the DataObject classes.
2247         https://bugs.webkit.org/show_bug.cgi?id=131784
2248
2249         Reviewed by Anders Carlsson.
2250
2251         * DumpRenderTree/win/DRTDataObject.cpp:
2252         (DRTDataObject::clearData): Use 'last()' method.
2253         * DumpRenderTree/win/UIDelegate.cpp:
2254         (DRTUndoStack::pop): Use 'takeLast()' method.
2255
2256 2014-04-17  Andres Gomez  <agomez@igalia.com>
2257
2258         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2259         https://bugs.webkit.org/show_bug.cgi?id=131365
2260
2261         Reviewed by Brent Fulgham.
2262
2263         The cygwin installer is now downloading the wanted versions for
2264         the local installation given to the setup wizard.
2265
2266         * CygwinDownloader/cygwin-downloader.py:
2267         * CygwinDownloader/cygwin-downloader.zip:
2268
2269 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2270
2271         [GTK] Make run-webkit-tests always use WKTR
2272         https://bugs.webkit.org/show_bug.cgi?id=131737
2273
2274         Reviewed by Darin Adler.
2275
2276         Now that the GTK+ port only has support for WebKit2, instruct
2277         run-webkit-tests to always use WKTR. This avoids needing to pass
2278         flag "-2" every time.
2279
2280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2281         (_set_up_derived_options): Always set webkit_test_runner when
2282         the platform is GTK+.
2283
2284 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2285
2286         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2287         https://bugs.webkit.org/show_bug.cgi?id=131760
2288
2289         Reviewed by Philippe Normand.
2290
2291         * gtk/install-dependencies: Install ninja-build when it's available.
2292
2293 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2294
2295         [Win] run-javascriptcore-tests fails to run.
2296         https://bugs.webkit.org/show_bug.cgi?id=131761
2297
2298         Reviewed by Brent Fulgham.
2299
2300         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2301
2302 2014-04-16  Andres Gomez  <agomez@igalia.com>
2303
2304         [Win] Pass default parameters to cygwin setup wizard
2305         https://bugs.webkit.org/show_bug.cgi?id=131361
2306
2307         Reviewed by Brent Fulgham.
2308
2309         Added some parameters to the cygwin setup wizard so the user
2310         doesn't really have to do any interaction.
2311
2312         * CygwinDownloader/cygwin-downloader.py:
2313         * CygwinDownloader/cygwin-downloader.zip:
2314
2315 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2316
2317         [Win] Eliminate use of deleteAllValues in Windows Files
2318         https://bugs.webkit.org/show_bug.cgi?id=131631
2319
2320         Reviewed by Darin Adler.
2321
2322         Switch to std::unique_ptr for memory lifetime. Get rid of
2323         deleteAllValues now that it is no longer needed. Use ranged
2324         for loops where possible.
2325
2326         * DumpRenderTree/win/DRTDataObject.cpp:
2327         (WCEnumFormatEtc::WCEnumFormatEtc):
2328         (DRTDataObject::~DRTDataObject):
2329         (DRTDataObject::GetData):
2330         (DRTDataObject::QueryGetData):
2331         (DRTDataObject::SetData):
2332         (DRTDataObject::clearData):
2333         * DumpRenderTree/win/DRTDataObject.h:
2334         * DumpRenderTree/win/UIDelegate.cpp:
2335         (DRTUndoObject::DRTUndoObject):
2336         (DRTUndoObject::~DRTUndoObject):
2337         (DRTUndoStack::~DRTUndoStack):
2338         (DRTUndoStack::clear):
2339         (DRTUndoStack::pop):
2340         (DRTUndoManager::DRTUndoManager):
2341         (DRTUndoManager::redo):
2342         (DRTUndoManager::undo):
2343         (UIDelegate::UIDelegate):
2344         (UIDelegate::resetUndoManager):
2345         * DumpRenderTree/win/UIDelegate.h:
2346
2347 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2348
2349         [GTK] Unreviewed GTK gardening.
2350
2351         Update list of skipped unit tests:
2352
2353           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2354
2355           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2356           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2357
2358         * Scripts/run-gtk-tests:
2359         (TestRunner):
2360
2361 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2362
2363         check-webkit-style doesn't check code style in .mm or .m files
2364         https://bugs.webkit.org/show_bug.cgi?id=131708
2365
2366         Reviewed by Darin Adler.
2367
2368         * Scripts/webkitpy/style/checker.py:
2369         * Scripts/webkitpy/style/checker_unittest.py:
2370         (CheckerDispatcherDispatchTest.test_cpp_paths):
2371         (CheckerDispatcherDispatchTest.test_text_paths):
2372         Check .mm and .m files as C++.
2373
2374         * Scripts/webkitpy/style/checkers/cpp.py:
2375         (check_spacing):
2376         Add an override for our ordinary "missing spaces around =" for @synthesize,
2377         which should look like "@synthesize propertyName=_varName;"
2378
2379         Add an override for "missing space before {" for blocks' "^{".
2380
2381         Don't follow the "extra space before [" rule for Objective-C, because
2382         it breaks this rule in a multitude of ways because of method calls.
2383
2384         (check_braces):
2385         Don't complain about { not being on the end of the previous line if
2386         the previous line starts with "- (" or "+ (", which would indicate a
2387         Objective-C method definition.
2388
2389 2014-04-16  Darin Adler  <darin@apple.com>
2390
2391         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2392         https://bugs.webkit.org/show_bug.cgi?id=131735
2393
2394         Reviewed by Alexey Proskuryakov.
2395
2396         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2397         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2398         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2399         way, but gtest works better this way.
2400
2401 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2402
2403         [EFL] Fix problems with the pixel dump.
2404         https://bugs.webkit.org/show_bug.cgi?id=131265
2405
2406         Reviewed by Gyuyoung Kim.
2407
2408         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2409         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2410         which causes that nothing is drawn.
2411
2412         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2413         One of new functions is AcceleratedCompositingContext::extractImageData(),
2414         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2415         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2416
2417         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2418         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2419
2420 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2421
2422         Update LLVM export scrpt to handle the build directory being different from the
2423         source directory.
2424
2425         Rubber stamped by Geoffrey Garen.
2426
2427         * Scripts/export-llvm-build:
2428
2429 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2430
2431         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2432         https://bugs.webkit.org/show_bug.cgi?id=131695
2433
2434         Reviewed by Antti Koivisto.
2435
2436         Updated.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2439
2440 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2441
2442         [GTK] Reduce the binary size by compressing the text based web inspector resources
2443         https://bugs.webkit.org/show_bug.cgi?id=121545
2444
2445         Reviewed by Gustavo Noronha Silva.
2446
2447         Compress text based files when compiling inspector resources. It
2448         reduces the binary size in 3MB.
2449
2450         * gtk/generate-inspector-gresource-manifest.py:
2451         (find_all_files_in_directory):
2452         (is_compressible):
2453
2454 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2455
2456         Remove Gtk WebKit1 tester.
2457
2458         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2459         results over and over as fast as it could.
2460
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2462         (WebKitBuildbot):
2463
2464 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2465
2466         Wrong link for webkitpy tests results in dashboard popover
2467         https://bugs.webkit.org/show_bug.cgi?id=131664
2468
2469         Reviewed by Timothy Hatcher.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2472         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2473         Use a correct link.
2474
2475 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2478
2479         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2480
2481         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2482         (CommitMessageForThisCommitTest):
2483
2484 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2485
2486         Fix commit-log-editor bug revealed by r165447
2487         https://bugs.webkit.org/show_bug.cgi?id=130676
2488
2489         Reviewed by Csaba Osztrogonác.
2490
2491         * Scripts/commit-log-editor:
2492         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2493         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2494         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2495         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2496
2497 2014-04-13  Darin Adler  <darin@apple.com>
2498
2499         userVisibleString should not try to "encode" host names
2500         https://bugs.webkit.org/show_bug.cgi?id=131587
2501         rdar://problem/14686849
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2506
2507         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2508         Coverage is tiny at this point; we could add a lot more cases!
2509
2510 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2511
2512         Use #include instead of #import
2513         https://bugs.webkit.org/show_bug.cgi?id=131604
2514
2515         Reviewed by Darin Adler.
2516
2517         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2518
2519         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2520
2521 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2522
2523         Make slow-stress tests run faster by running fewer VM variants.
2524
2525         Rubber stamped by Geoffrey Garen.
2526
2527         * Scripts/run-javascriptcore-tests:
2528         * Scripts/run-jsc-stress-tests:
2529
2530 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2531
2532         [CMake] Add missing WTF unit tests
2533         https://bugs.webkit.org/show_bug.cgi?id=131459
2534
2535         Reviewed by Martin Robinson.
2536
2537         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2538         that should be compiled into the TestWTF binary.
2539
2540 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2541
2542         [Gtk] run-launcher doesn't work by default
2543         https://bugs.webkit.org/show_bug.cgi?id=131494
2544
2545         Reviewed by Philippe Normand.
2546
2547         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2548         * Scripts/webkitdirs.pm:
2549         (launcherName): Same.
2550         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2551         * gtk/common.py:
2552         (get_build_path.is_valid_build_directory): Same.
2553         * gtk/manifest.txt: Same.
2554
2555 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2556
2557         Unreviewed, rolling out r167046.
2558         https://bugs.webkit.org/show_bug.cgi?id=131479
2559
2560         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2561         on #webkit).
2562
2563         Reverted changeset:
2564
2565         "Remove "System Font" from whitelisted DRT fonts and char
2566         width calculations"
2567         https://bugs.webkit.org/show_bug.cgi?id=131411
2568         http://trac.webkit.org/changeset/167046
2569
2570 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2571
2572         Remove "System Font" from whitelisted DRT fonts and char width calculations
2573         https://bugs.webkit.org/show_bug.cgi?id=131411
2574
2575         Reviewed by Tim Horton.
2576
2577         Covered by existing tests.
2578
2579         * DumpRenderTree/mac/DumpRenderTree.mm:
2580         (allowedFontFamilySet):
2581
2582 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2583
2584         systemHiddenFontFamilySet in DRT is unnecessary
2585         https://bugs.webkit.org/show_bug.cgi?id=131414
2586
2587         Reviewed by Tim Horton.
2588
2589         It doesn't seem to affect test results on my machine.
2590
2591         * DumpRenderTree/mac/DumpRenderTree.mm:
2592         (drt_NSFontManager_availableFonts):
2593         (systemHiddenFontFamilySet): Deleted.
2594
2595 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2596
2597         [Win] Unreviewed test fix: Don't double-release BSTR.
2598
2599         * DumpRenderTree/win/DumpRenderTree.cpp:
2600         (dump): Remove unneeded call to SysFreeString now that we are
2601         using _bstr_t for this variable.
2602
2603 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2604
2605         [Win] Various DumpRenderTree Fixes.
2606         https://bugs.webkit.org/show_bug.cgi?id=131446.
2607
2608         Reviewed by Tim Horton.
2609
2610         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2611         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2612         (AccessibilityUIElement::description): Ditto.
2613         (AccessibilityUIElement::helpText): Ditto.
2614         (AccessibilityUIElement::intValue): Ditto.
2615         (AccessibilityUIElement::isPressActionSupported): Ditto.
2616         (AccessibilityUIElement::accessibilityValue): Ditto.
2617         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2618         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2619         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2620         (DRTDesktopNotificationPresenter::Release): Ditto.
2621         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2622         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2623         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2624         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2625         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2626         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2627         * DumpRenderTree/win/DumpRenderTree.cpp:
2628         (dumpFrameScrollPosition): Ditto.
2629         (dumpFramesAsText): Ditto.
2630         (compareHistoryItems): Ditto.
2631         (dumpHistoryItem): Ditto.
2632         (dump): Ditto.
2633         (resetDefaultsToConsistentValues): Ditto.
2634         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2635         (runTest): Ditto.
2636         (createWebViewAndOffscreenWindow): Ditto.
2637         * DumpRenderTree/win/EditingDelegate.cpp:
2638         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2639         (EditingDelegate::AddRef): Ditto.
2640         (EditingDelegate::Release): Ditto.
2641         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2642         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2643         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2644         (EditingDelegate::shouldInsertNode): Ditto.
2645         (EditingDelegate::shouldInsertText): Ditto.
2646         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2647         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2648         (EditingDelegate::shouldApplyStyle): Ditto.
2649         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2650         (EditingDelegate::doPlatformCommand): Ditto.
2651         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2652         (EditingDelegate::webViewDidChange): Ditto.
2653         (EditingDelegate::webViewDidEndEditing): Ditto.
2654         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2655         (EditingDelegate::webViewDidChangeSelection): Ditto.
2656         (EditingDelegate::checkSpellingOfString): Ditto.
2657         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2658         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2659         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2660         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2661         (FrameLoadDelegate::AddRef): Ditto.
2662         (FrameLoadDelegate::Release): Ditto.
2663         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2664         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2665         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2666         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2667         (FrameLoadDelegate::didReceiveTitle): Ditto.
2668         (FrameLoadDelegate::didChangeIcons): Ditto.
2669         (delegatesWithDelayedWork): Ditto.
2670         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2671         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2672         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2673         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2674         (FrameLoadDelegate::willCloseFrame): Ditto.
2675         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2676         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2677         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2678         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2679         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2680         * DumpRenderTree/win/FrameLoadDelegate.h:
2681         * DumpRenderTree/win/HistoryDelegate.cpp:
2682         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2683         (HistoryDelegate::updateHistoryTitle): Ditto.
2684         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2685         * DumpRenderTree/win/PolicyDelegate.cpp:
2686         (dumpPath):
2687         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2688         (PolicyDelegate::AddRef): Ditto.
2689         (PolicyDelegate::Release): Ditto.
2690         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2691         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2692         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2693         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2694         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2695         (ResourceLoadDelegate::AddRef): Ditto.
2696         (ResourceLoadDelegate::Release): Ditto.
2697         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2698         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2699         (ResourceLoadDelegate::willSendRequest): Ditto.
2700         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2701         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2702         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2703         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2704         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2705         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2706         (TestRunner::setUserStyleSheetLocation): Ditto.
2707         (TestRunner::execCommand): Ditto.
2708         (TestRunner::overridePreference): Ditto.
2709         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2710         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2711         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2712         (TextInputController::insertText): Ditto.
2713         * DumpRenderTree/win/UIDelegate.cpp:
2714         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2715         (UIDelegate::AddRef): Ditto.
2716         (UIDelegate::Release): Ditto.
2717         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2718         (UIDelegate::trackCustomPopupMenu): Ditto.
2719         (UIDelegate::registerUndoWithTarget): Ditto.
2720         (UIDelegate::removeAllActionsWithTarget): Ditto.
2721         (UIDelegate::setActionTitle): Ditto.
2722         (UIDelegate::undo): Ditto.
2723         (UIDelegate::redo): Ditto.
2724         (UIDelegate::canUndo): Ditto.
2725         (UIDelegate::canRedo): Ditto.
2726         (UIDelegate::printFrame): Ditto.
2727         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2728         (UIDelegate::webViewHeaderHeight): Ditto.
2729         (UIDelegate::webViewFooterHeight): Ditto.
2730         (UIDelegate::drawHeaderInRect): Ditto.
2731         (UIDelegate::drawFooterInRect): Ditto.
2732         (UIDelegate::webViewPrintingMarginRect): Ditto.
2733         (UIDelegate::canRunModal): Ditto.
2734         (UIDelegate::createModalDialog): Ditto.
2735         (UIDelegate::runModal): Ditto.
2736         (UIDelegate::isMenuBarVisible): Ditto.
2737         (UIDelegate::setMenuBarVisible): Ditto.
2738         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2739         (UIDelegate::paintCustomScrollbar): Ditto.
2740         (UIDelegate::paintCustomScrollCorner): Ditto.
2741         (UIDelegate::setFrame): Ditto.
2742         (UIDelegate::webViewFrame): Ditto.
2743         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2744         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2745         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2746         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2747         (UIDelegate::webViewAddMessageToConsole): Ditto.
2748         (UIDelegate::doDragDrop): Ditto.
2749         (UIDelegate::webViewGetDlgCode): Ditto.
2750         (UIDelegate::createWebViewWithRequest): Ditto.
2751         (UIDelegate::webViewClose): Ditto.
2752         (UIDelegate::webViewFocus): Ditto.
2753         (UIDelegate::webViewUnfocus): Ditto.
2754         (UIDelegate::webViewPainted): Ditto.
2755         (UIDelegate::exceededDatabaseQuota): Ditto.
2756         (UIDelegate::embeddedViewWithArguments): Ditto.
2757         (UIDelegate::webViewClosing): Ditto.
2758         (UIDelegate::webViewSetCursor): Ditto.
2759         (UIDelegate::webViewDidInvalidate): Ditto.
2760         (UIDelegate::setStatusText): Ditto.
2761         (UIDelegate::desktopNotificationsDelegate): Ditto.
2762         (UIDelegate::drawBackground): Ditto.
2763         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2764         (UIDelegate::didPressMissingPluginButton): Ditto.
2765         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2766         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2767         (LoadHTMLStringItem::invoke): Ditto.
2768         (ScriptItem::invoke): Ditto.
2769
2770 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2771
2772         Stylechecker: False positive on inline asm code.
2773         https://bugs.webkit.org/show_bug.cgi?id=130570
2774
2775         Reviewed by Csaba Osztrogonác.
2776
2777         Disable stylechecking in asm blocks.
2778
2779         * Scripts/webkitpy/style/checkers/cpp.py:
2780         (process_line):
2781         (_InlineASMState):
2782         (_InlineASMState.__init__):
2783         (_InlineASMState.process_line):
2784         (_InlineASMState.isInside):
2785         (_process_lines):
2786         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2787         (WebKitStyleTest.test_member_initialization_list):
2788
2789 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2790
2791         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2792         https://bugs.webkit.org/show_bug.cgi?id=131029
2793
2794         Reviewed by Philippe Normand.
2795
2796         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2797         tests and remove the getWebKit1TestResoucesDir() method.
2798
2799         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2800         (testDownloadLocalFile): Use Test::getResourcesDir().
2801         (testDownloadLocalFileError): Ditto.
2802         (serverCallback): Ditto.
2803         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2804         (serverCallback): Ditto.
2805         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2806         (httpServerCallback): Ditto.
2807         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2808         (serverCallback): Ditto.
2809         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2810         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2811         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2812         (Test::getWebKit1TestResoucesDir): Deleted.
2813
2814 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2815
2816         [WK2] HTTP authentication regression tests fail
2817         https://bugs.webkit.org/show_bug.cgi?id=81627
2818         <rdar://problem/11079296>
2819
2820         Reviewed by Anders Carlsson.
2821
2822         * WebKitTestRunner/TestController.h:
2823         * WebKitTestRunner/TestController.cpp:
2824         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2825         to pageLoaderClient structure.
2826         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2827         for password based authentication (we do get server trust challenges on some tests,
2828         which WKTR can't handle).
2829         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2830         calls won't be made, at least on CFNetwork based platforms.
2831         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2832         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2833         make sense to associate auth requests with individual resources - there can be
2834         multiple resources loading at once from the same protection space, so WebKit1 API
2835         that had a resource identifier was inherently racy.
2836
2837 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2838
2839         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2840         https://bugs.webkit.org/show_bug.cgi?id=131427
2841
2842         Reviewed by Gyuyoung Kim.
2843
2844         Since r166973, font path was changed.
2845
2846         * DumpRenderTree/PlatformEfl.cmake:
2847         * WebKitTestRunner/PlatformEfl.cmake:
2848
2849 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2850
2851         Fix the build-jsc build
2852         https://bugs.webkit.org/show_bug.cgi?id=131410
2853
2854         Reviewed by Michael Saboff.
2855
2856         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2857         WTF depends on it.
2858
2859 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2860
2861         [GTK] Remove WebKit1 unit tests
2862         https://bugs.webkit.org/show_bug.cgi?id=131359
2863
2864         Reviewed by Anders Carlsson.
2865
2866         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2867         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2868         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2869
2870         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2871         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2872         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2873         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2874         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2875         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2876         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2877         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2878         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2879         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2880         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2881         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2882         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2883         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2884         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2885         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2886         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2887         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2888         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2889         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2890         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2891         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2892         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2893         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2894         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2895         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2896         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2897         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2898         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2899         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2900         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2901         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2902         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2903         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2904         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2905         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2906         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2907         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2908
2909 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2910
2911         Unreviewed gardening (Take 2): Prevent users from attempting
2912         to build with known invalid cURL. 
2913
2914         * Scripts/webkitdirs.pm:
2915         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2916         7.33.0 (the known good version).
2917
2918 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2919
2920         [GTK] Remove DumpRenderTree and GtkLauncher
2921         https://bugs.webkit.org/show_bug.cgi?id=131373
2922
2923         Reviewed by Andreas Kling.
2924
2925         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2926         no longer necessary now that WebKit1 GTK+ will be removed.
2927
2928         * CMakeLists.txt:
2929         * DumpRenderTree/PlatformGTK.cmake: Removed.
2930         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2931         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2932         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2933         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2934         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2935         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2936         * DumpRenderTree/gtk/EventSender.h: Removed.
2937         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2938         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2939         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2940         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2941         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2942         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2943         * DumpRenderTree/gtk/TextInputController.h: Removed.
2944         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2945         * GtkLauncher/CMakeLists.txt: Removed.
2946         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2947         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2948         * GtkLauncher/main.c: Removed.
2949         * GtkLauncher/simple.svg: Removed.
2950         * GtkLauncher/text.html: Removed.
2951         * WebKitTestRunner/PlatformGTK.cmake:
2952         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
2953         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
2954         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
2955
2956 2014-04-08  Mark Rowe  <mrowe@apple.com>
2957
2958         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
2959         <https://webkit.org/b/131388> / <rdar://problem/16291687>
2960
2961         Reviewed by Alexey Proskuryakov.
2962
2963         * Scripts/webkitdirs.pm:
2964         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
2965         (execMacWebKitAppForDebugging): Ditto.
2966
2967 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2968
2969         Build bmalloc on iOS too
2970         https://bugs.webkit.org/show_bug.cgi?id=131381
2971
2972         Reviewed by Andreas Kling.
2973
2974         * Scripts/build-webkit:
2975
2976 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2977
2978         Unreviewed gardening: Prevent users from attempting
2979         to build with known invalid cURL.
2980
2981         * Scripts/webkitdirs.pm:
2982         (checkInstalledTools): Block build attempts with bad
2983         Cygwin tool set.
2984
2985 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2986
2987         Build bmalloc on Mac
2988         https://bugs.webkit.org/show_bug.cgi?id=131333
2989
2990         Reviewed by Mark Rowe.
2991
2992         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
2993         (Note: Just testing Mac is not good enough because in this
2994         script 'Mac' means 'Mac or iOS'.)
2995
2996 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
2997
2998         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
2999         https://bugs.webkit.org/show_bug.cgi?id=130951
3000
3001         Reviewed by Geoffrey Garen.
3002
3003         * Scripts/run-javascriptcore-tests:
3004
3005 2014-04-06  Darin Adler  <darin@apple.com>
3006
3007         Rework CSS calc logic, fixing some reference count mistakes in Length
3008         https://bugs.webkit.org/show_bug.cgi?id=131280
3009
3010         Reviewed by Andreas Kling.
3011
3012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3013         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3014
3015 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3016
3017         Enable WEB_REPLAY for PLATFORM(MAC)
3018         https://bugs.webkit.org/show_bug.cgi?id=130700
3019
3020         Reviewed by Timothy Hatcher.
3021
3022         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3023
3024 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3025
3026         [CMake] Include X11's include dirs in TestNetscapePlugin
3027         https://bugs.webkit.org/show_bug.cgi?id=131270
3028
3029         Reviewed by Martin Robinson.
3030
3031         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3032         TestNetscapePlugin includes WebCore code that includes X headers.
3033
3034 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3035
3036         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3037         <http://webkit.org/b/130986>
3038
3039         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3040         prefix to TileCache class names in exception list.
3041
3042 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3043
3044         [GTK] kill-old-processes should kill dbus-daemon processes
3045         https://bugs.webkit.org/show_bug.cgi?id=127352
3046
3047         Reviewed by Martin Robinson.
3048
3049         * BuildSlaveSupport/kill-old-processes:
3050         (main):
3051
3052 2014-04-04  Andres Gomez  <agomez@igalia.com>
3053
3054         [Win] Update obsolete packages in cygwin
3055         https://bugs.webkit.org/show_bug.cgi?id=126264
3056
3057         Reviewed by Brent Fulgham.
3058
3059         Removed "apache" and "minires" as the first has been replaced by
3060         "lighttpd" and the second is now integrated into
3061         "cygwin". Replaced the transitional and now obsolete "gcc" package
3062         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3063         since the newer version available is "2.7.3" which breaks the
3064         build due to some funniness with environment variable handling.
3065
3066         * CygwinDownloader/cygwin-downloader.py:
3067         * CygwinDownloader/cygwin-downloader.zip:
3068
3069 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3070
3071         check-webkit-style: Improve warnings on Objective-C @property syntax
3072         https://bugs.webkit.org/show_bug.cgi?id=131200
3073
3074         Reviewed by Dan Bernstein.
3075
3076         * Scripts/webkitpy/style/checkers/cpp.py:
3077         (check_spacing):
3078         (CppChecker):
3079         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3080         (CppStyleTest.test_spacing_in_objective_c_properties):
3081
3082 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3083
3084         Unreviewed. Moving my name to commiter section
3085
3086         * Scripts/webkitpy/common/config/contributors.json:
3087
3088 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3089
3090         Unreviewed. Add myself as a committer.
3091
3092         * Scripts/webkitpy/common/config/contributors.json:
3093
3094 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3095
3096         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3097         https://bugs.webkit.org/show_bug.cgi?id=130391
3098
3099         Reviewed by Gyuyoung Kim.
3100
3101         Change the implementation of the zoom functionality from ewk_view_scale_set
3102         to ewk_view_page_zoom_set.
3103
3104         * MiniBrowser/efl/main.c:
3105
3106 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3107
3108         [webkitpy] perf profiler does not understand --call-graph argument
3109         https://bugs.webkit.org/show_bug.cgi?id=131132
3110
3111         Reviewed by Ryosuke Niwa.
3112
3113         New versions of perf profiler have changed the argument from --call-graph to -g.
3114
3115         * Scripts/webkitpy/common/system/profiler.py:
3116         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3117         * Scripts/webkitpy/port/driver_unittest.py:
3118         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3119
3120 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3121
3122         Add EFL WK2 performance bot to build.webkit.org
3123         https://bugs.webkit.org/show_bug.cgi?id=131034
3124
3125         Fix after r166707, use "Perf" instead of "perf" for consistency.
3126
3127         Reviewed by Csaba Osztrogonác.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/config.json:
3130
3131 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3132
3133         Add EFL WK2 performance bot to build.webkit.org
3134         https://bugs.webkit.org/show_bug.cgi?id=131034
3135
3136         Reviewed by Csaba Osztrogonác.
3137
3138         * BuildSlaveSupport/build.webkit.org-config/config.json:
3139
3140 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3141
3142         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3143         https://bugs.webkit.org/show_bug.cgi?id=131151
3144
3145         Reviewed by Gyuyoung Kim.
3146
3147         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3148         (TouchEventInfo::TouchEventInfo):
3149         (sendTouchEvent):
3150         (addTouchPointCallback):
3151         (updateTouchPointCallback):
3152         (cancelTouchPointCallback):
3153         (releaseTouchPointCallback):
3154
3155 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3156
3157         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3158         <http://webkit.org/b/131045>
3159
3160         Reviewed by Daniel Bates.
3161
3162         * Scripts/filter-build-webkit:
3163         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3164         of clang, plus debug data for all DVTAssertions.
3165
3166 2014-04-01  Dean Jackson  <dino@apple.com>
3167
3168         Load Media Controls js/css from bundle
3169         https://bugs.webkit.org/show_bug.cgi?id=131086
3170
3171         Reviewed by Eric Carlson.
3172
3173         We're now putting CSS files into the bundle, so remove the test for them.
3174
3175         * Scripts/check-for-inappropriate-files-in-framework:
3176
3177 2014-04-02  Martin Hock  <mhock@apple.com>
3178
3179         Unify private browsing with sessions.
3180         https://bugs.webkit.org/show_bug.cgi?id=130099
3181
3182         Reviewed by Alexey Proskuryakov.
3183
3184         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3187         (TestWebKitAPI::didNavigateWithNavigationData):
3188         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3189         (TestWebKitAPI::TEST):
3190
3191         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3192         (TestWebKitAPI::didNavigateWithoutNavigationData):
3193         (TestWebKitAPI::didNavigateWithNavigationData):
3194         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3195         (TestWebKitAPI::TEST):
3196
3197 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3198
3199         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3200         https://bugs.webkit.org/show_bug.cgi?id=130343
3201
3202         Reviewed by Gustavo Noronha Silva.
3203
3204         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3205         of directories on the command line and look for all appropriate files in those directories for the
3206         GResource archive. Also make archive paths relative to those directories.
3207         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3208         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3209
3210 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3211
3212         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3213         https://bugs.webkit.org/show_bug.cgi?id=131106
3214
3215         Reviewed by Csaba Osztrogonác.
3216
3217         * Scripts/webkitpy/tool/commands/download.py:
3218         (AbstractRolloutPrepCommand._prepare_state):
3219         * Scripts/webkitpy/tool/commands/download_unittest.py:
3220         (test_prepare_rollout):
3221         (test_create_rollout):
3222         (test_create_rollout_resolved):
3223         (test_rollout):
3224
3225 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3226
3227         [EFL] Add option to use separate web process for new window in MiniBrowser
3228         https://bugs.webkit.org/show_bug.cgi?id=130190
3229
3230         Reviewed by Gyuyoung Kim.
3231
3232         New created window (CTRL + n) will be open in separated web process.
3233         This option is enabled by adding a flag (S/separate-process) with launching
3234         MiniBrowser.
3235
3236         * MiniBrowser/efl/main.c:
3237         (elm_main):
3238
3239 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3240
3241         [GTK] Move NEWS file to a new location
3242         https://bugs.webkit.org/show_bug.cgi?id=130901
3243
3244         Reviewed by Brent Fulgham.
3245
3246         * gtk/manifest.txt: Update the NEWS file path.
3247
3248 2014-04-01  Anders Carlsson  <andersca@apple.com>
3249
3250         Fix build.
3251
3252         * MiniBrowser/mac/WK2BrowserWindowController.m:
3253         (-[WK2BrowserWindowController awakeFromNib]):
3254         (-[WK2BrowserWindowController dealloc]):
3255         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3256
3257 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3258
3259         Unreviewed test gardening.
3260
3261         * Scripts/webkitpy/port/base_unittest.py:
3262         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3263
3264 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3265
3266         [CSS Exclusions] Remove exclusions parsing support
3267         https://bugs.webkit.org/show_bug.cgi?id=131046
3268
3269         Reviewed by David Hyatt.
3270
3271         * Scripts/webkitperl/FeatureList.pm:
3272
3273 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3274
3275         [GTK] Remove last reference to GTK+ WK1 EWS
3276         https://bugs.webkit.org/show_bug.cgi?id=131058
3277
3278         Reviewed by Martin Robinson.
3279
3280         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3281
3282         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3283
3284 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3285
3286         Add a 32bit JSC builder/tester.
3287         https://bugs.webkit.org/show_bug.cgi?id=131054
3288         
3289         Reviewed by Michael Saboff.
3290
3291         * BuildSlaveSupport/build.webkit.org-config/config.json:
3292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3293         (Compile32bitJSC):
3294         (Run32bitJSCTests):
3295         (Run32bitJSCTests.countFailures):
3296         (BuildAndTest32bitJSCFactory):
3297         (BuildAndTest32bitJSCFactory.__init__):
3298
3299 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3300
3301         [GTK] No longer build WebKit1 gtkdoc
3302         https://bugs.webkit.org/show_bug.cgi?id=130970
3303
3304         Reviewed by Anders Carlsson.
3305
3306         * gtk/common.py:
3307         (gtk_version_of_pkg_config_file): Deleted.
3308         * gtk/generate-gtkdoc:
3309         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3310         was only applicable for WebKit1.
3311         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3312
3313 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3314
3315         [GTK] Running minibrowser with url crashes in debug build
3316         https://bugs.webkit.org/show_bug.cgi?id=130492
3317
3318         Reviewed by Martin Robinson.
3319
3320         Update "uri-scheme" test not to use invalid URIs in it, so we
3321         don't get a mistmatch when comparing the original URI stored in
3322         the test class with the one returned by the WebKitWebView.
3323
3324         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3325         (testWebContextURIScheme): Update the test.
3326
3327 2014-04-01  Mihai Tica  <mitica@adobe.com>
3328
3329         Unreviewed: Add myself as a commiter to the contributors list.
3330
3331         * Scripts/webkitpy/common/config/contributors.json:
3332
3333 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3334
3335         [EFL][WK2] Extract the control of page background out of color_set
3336         https://bugs.webkit.org/show_bug.cgi?id=127539
3337
3338         Reviewed by Gyuyoung Kim.
3339
3340         Added an option(C) to change background color.
3341
3342         * MiniBrowser/efl/main.c:
3343         (window_create):
3344         (elm_main):
3345
3346 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3347
3348         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3349
3350         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3351
3352 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3353
3354         Unreviewed test correction after r166530.
3355
3356         * DumpRenderTree/mac/DumpRenderTree.mm:
3357         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3358         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3359
3360 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3361
3362         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3363         https://bugs.webkit.org/show_bug.cgi?id=130987
3364
3365         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3366         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3367
3368         Reviewed by Martin Robinson.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/config.json:
3371
3372 2014-03-31  Dean Jackson  <dino@apple.com>
3373
3374         Remove WEB_ANIMATIONS
3375         https://bugs.webkit.org/show_bug.cgi?id=130989
3376
3377         Reviewed by Simon Fraser.
3378
3379         Remove this feature flag until we plan to implement.
3380
3381         * Scripts/webkitperl/FeatureList.pm:
3382
3383 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3384
3385         Reduced Latched Scroll Test Flakiness
3386         https://bugs.webkit.org/show_bug.cgi?id=130983
3387
3388         Reviewed by Darin Adler.
3389
3390         * DumpRenderTree/mac/DumpRenderTree.mm:
3391         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3392         * DumpRenderTree/mac/EventSendingController.mm:
3393         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3394         with high resolution flags turned on.
3395         * WebKitTestRunner/mac/EventSenderProxy.mm:
3396         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3397
3398 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3399
3400         run-webkit-tests should have a --no-timeout option
3401         https://bugs.webkit.org/show_bug.cgi?id=128286
3402
3403         Reviewed by Joseph Pecoraro.
3404
3405         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3406         (Worker._run_test): Renaming _run_test_with_timeout()
3407         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3408         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3409         (Worker._run_test_in_this_thread):
3410         (Worker._run_test_with_timeout): Deleted.
3411         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3412         (parse_args): Added the --no-timeout option
3413
3414 2014-03-31  Samuel White  <samuel_white@apple.com>
3415
3416         AX: Need ability to get line range for text marker.
3417         https://bugs.webkit.org/show_bug.cgi?id=130906
3418
3419         Reviewed by Chris Fleizach.
3420
3421         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3422
3423         * DumpRenderTree/AccessibilityUIElement.cpp:
3424         (lineTextMarkerRangeForTextMarkerCallback):
3425         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3426         (AccessibilityUIElement::getJSClass):
3427         * DumpRenderTree/AccessibilityUIElement.h:
3428         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3429         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3430         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3431         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3432         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3433         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3434         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3435         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3436         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3437         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3438         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3439         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3440
3441 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3442
3443         More validation for FTL inline caches
3444         https://bugs.webkit.org/show_bug.cgi?id=130948
3445
3446         Reviewed by Geoffrey Garen.
3447
3448         * Scripts/run-jsc-stress-tests:
3449
3450 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3451
3452         [GTK] Do not run WebKit1 unit tests by default
3453         https://bugs.webkit.org/show_bug.cgi?id=130968
3454
3455         Reviewed by Martin Robinson.
3456
3457         * Scripts/run-gtk-tests:
3458         (TestRunner):
3459
3460 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3461
3462         [GTK] Remove scripts code only applicable to autotools
3463         https://bugs.webkit.org/show_bug.cgi?id=130841
3464
3465         Reviewed by Anders Carlsson.
3466
3467         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3468         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3469         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3470         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3471         * gtk/find-make-dist-errors: Removed.
3472         * gtk/generate-feature-defines-files: Removed.
3473         * gtk/manifest.txt: No longer need to consider autotools files.
3474
3475 2014-03-30  Andy Estes  <aestes@apple.com>
3476
3477         Fix two failing layout tests on Mountain Lion after r166466.
3478
3479         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3480         (-[DownloadDelegate _downloadDidStart:]):
3481
3482 2014-03-30  Andy Estes  <aestes@apple.com>
3483
3484         [Cocoa] Add an originatingWebView property to _WKDownload
3485         https://bugs.webkit.org/show_bug.cgi?id=130945
3486
3487         Reviewed by Anders Carlsson.
3488
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3490         (-[DownloadDelegate _downloadDidStart:]):
3491         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3492         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3493         (TEST):
3494
3495 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3496
3497         Land the stackmap register liveness glue with the uses of the liveness disabled
3498         https://bugs.webkit.org/show_bug.cgi?id=130924
3499
3500         Reviewed by Oliver Hunt.
3501
3502         * Scripts/run-jsc-stress-tests:
3503
3504 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3505
3506         Update WebKit1.StringTruncator for Mountain Lion.
3507
3508         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3509         due to different font metrics on 10.8.
3510
3511 2014-03-28  Darin Adler  <darin@apple.com>
3512
3513         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3514         https://bugs.webkit.org/show_bug.cgi?id=130889
3515
3516         Reviewed by Alexey Proskuryakov.
3517
3518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3519         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3520         WebStringTruncator methods; should be good for a start. These are dependent on the
3521         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3522
3523 2014-03-28  Martin Hock  <mhock@apple.com>
3524
3525         Unreviewed. Add myself as a committer.
3526
3527         * Scripts/webkitpy/common/config/contributors.json:
3528
3529 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3530
3531         Remove WebKit1 GTK+ bots
3532         https://bugs.webkit.org/show_bug.cgi?id=130904
3533
3534         Reviewed by Anders Carlsson.
3535
3536         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3537         all bots are testing WebKit2 only.
3538         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3539         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3540         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3541         * Scripts/webkitpy/port/builders.py: Ditto.
3542         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3543         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3544
3545 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3546
3547         Remove Brian Burg's apple.com email address.
3548
3549         * Scripts/webkitpy/common/config/contributors.json:
3550
3551 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3552
3553         bisect-builds should print Trac 'changeset' URL if only one build is detected
3554         <http://webkit.org/b/130903>
3555
3556         Reviewed by Dan Bernstein.
3557
3558         * Scripts/bisect-builds:
3559         (printTracLink): Print a direct link to the Trac 'changeset'
3560         URL if there is only one revision in the range.
3561
3562 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3563
3564         [EFL] Bump glib version from 2.36 to 2.38 
3565         https://bugs.webkit.org/show_bug.cgi?id=130886
3566
3567         Reviewed by Csaba Osztrogonác.
3568
3569         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3570         we need to bump glib version up to 2.38 as gtk port.
3571
3572         * efl/jhbuild.modules:
3573
3574 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3575
3576         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3577
3578         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3579         the globalhistory directory.
3580
3581         Reviewed by Sam Weinig.
3582
3583         * WebKitTestRunner/TestController.cpp:
3584         (WTR::TestController::TestController):
3585         (WTR::TestController::initialize): Set the history client.
3586         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3587         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3588         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3589         and we don't yet have API to access the data in question.
3590         (WTR::TestController::didPerformClientRedirect):
3591         (WTR::TestController::didPerformServerRedirect):
3592         (WTR::TestController::didUpdateHistoryTitle):
3593         * WebKitTestRunner/TestController.h:
3594         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3595         * WebKitTestRunner/TestInvocation.cpp:
3596         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3597         (WTR::TestInvocation::invoke):
3598
3599 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3600
3601         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
3602
3603         * Scripts/build-webkit:
3604         * Scripts/copy-webkitlibraries-to-product-directory:
3605
3606 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3607
3608         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3609         https://bugs.webkit.org/show_bug.cgi?id=130867
3610         <rdar://problem/16432456> 
3611
3612         Reviewed by Mark Hahnenberg.
3613
3614         * Scripts/build-webkit:
3615         * Scripts/copy-webkitlibraries-to-product-directory:
3616
3617 2014-03-26  Andy Estes  <aestes@apple.com>
3618
3619         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3620         https://bugs.webkit.org/show_bug.cgi?id=130805
3621
3622         Reviewed by Dan Bernstein.
3623
3624         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3625         (-[DownloadDelegate _download:didReceiveResponse:]):
3626         (-[DownloadDelegate _downloadDidFinish:]):
3627         (runTest):
3628         (TEST):
3629         (-[FailingDownloadDelegate _downloadDidFinish:]):
3630         (-[FailingDownloadDelegate _download:didFailWithError:]):
3631         (-[FailingDownloadDelegate _downloadDidCancel:]):
3632         (-[CancelledDownloadDelegate _downloadDidStart:]):
3633         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3634         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3635         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3636         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3637         (-[DownloadDelegate sourceURL]): Deleted.
3638         (runTestWithNavigationDelegate): Deleted.
3639
3640 2014-03-26  Anders Carlsson  <andersca@apple.com>
3641
3642         Change MiniBrowser to hold on to window controllers instead of windows
3643         https://bugs.webkit.org/show_bug.cgi?id=130797
3644
3645         Reviewed by Oliver Hunt.
3646
3647         * MiniBrowser/mac/AppDelegate.h:
3648         * MiniBrowser/mac/AppDelegate.m:
3649         (-[BrowserAppDelegate init]):
3650         (-[BrowserAppDelegate newWindow:]):
3651         (-[BrowserAppDelegate browserWindowWillClose:]):
3652         (-[BrowserAppDelegate applicationWillTerminate:]):
3653         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3654
3655 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3656
3657         Unreviewed, rolling out r166264.
3658         https://bugs.webkit.org/show_bug.cgi?id=130785
3659
3660         Broke some window.opener tests for WK2 Mavericks (Requested by
3661         brrian__ on #webkit).
3662
3663         Reverted changeset:
3664
3665         "Web Replay: resource unique identifiers should be unique-per-
3666         frame, not globally"
3667         https://bugs.webkit.org/show_bug.cgi?id=130632
3668         http://trac.webkit.org/changeset/166264
3669
3670 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3671
3672         [CSS Shapes] Remove shape-inside support
3673         https://bugs.webkit.org/show_bug.cgi?id=130698
3674
3675         Reviewed by David Hyatt.
3676
3677         * Scripts/webkitperl/FeatureList.pm:
3678
3679 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3680
3681         Unreviewed. Add myself as a committer.
3682
3683         * Scripts/webkitpy/common/config/contributors.json:
3684
3685 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3686
3687         run-launcher is Perl script so use elsif and not elif
3688         https://bugs.webkit.org/show_bug.cgi?id=130771
3689
3690         Reviewed by Carlos Garcia Campos.
3691
3692         * Scripts/run-launcher:
3693
3694 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3695
3696         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3697         https://bugs.webkit.org/show_bug.cgi?id=130575
3698
3699         Reviewed by Mario Sanchez Prada.
3700
3701         Change ATK version to 2.11.92. Adjust current implementation.
3702
3703         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3704         (AccessibilityUIElement::intValue):
3705         (AccessibilityUIElement::minValue):
3706         (AccessibilityUIElement::maxValue):
3707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3708         (WTR::AccessibilityUIElement::intValue):
3709         (WTR::AccessibilityUIElement::minValue):
3710         (WTR::AccessibilityUIElement::maxValue):
3711         * efl/jhbuild.modules:
3712         * gtk/jhbuild.modules:
3713
3714 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3715
3716         [GTK] The gnumake package is no longer needed in jhbuild
3717         https://bugs.webkit.org/show_bug.cgi?id=130121
3718
3719         Reviewed by Martin Robinson.
3720
3721         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3722         for a debug build cmake/system-gnumake worked just fine for me.
3723
3724         * gtk/jhbuild.modules: Removed gnumake.
3725         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3726         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3727
3728 2014-03-25  Andy Estes  <aestes@apple.com>
3729
3730         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3731
3732         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3733         (-[DownloadDelegate _download:didReceiveData:]):
3734         (-[DownloadDelegate _downloadDidFinish:]):
3735
3736 2014-03-25  Brian Burg  <bburg@apple.com>
3737
3738         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3739         https://bugs.webkit.org/show_bug.cgi?id=130623
3740
3741         Reviewed by Timothy Hatcher.
3742
3743         The resource loader callback dumping routines assumed that resource identifiers
3744         were globally unique. Its map of resource identifiers to URLs must also track the
3745         frame associated with the resource.
3746
3747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3748         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3749         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3750         stable as long as the frame is valid.
3751         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3752         (WTR::InjectedBundlePage::willSendRequestForFrame):
3753         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3754         (WTR::InjectedBundlePage::didFinishLoadForResource):
3755         (WTR::InjectedBundlePage::didFailLoadForResource):
3756
3757 2014-03-25  Andy Estes  <aestes@apple.com>
3758
3759         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3760
3761         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3762         (-[DownloadDelegate _download:didReceiveResponse:]):
3763         (-[DownloadDelegate _download:didReceiveData:]):
3764
3765 2014-03-25  Andy Estes  <aestes@apple.com>
3766
3767         Add some debug logging to an API test that's failing on Mountain Lion.
3768
3769         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3770         (-[DownloadDelegate _download:didReceiveResponse:]):
3771         (-[DownloadDelegate _downloadDidFinish:]):
3772
3773 2014-03-25  Anders Carlsson  <andersca@apple.com>
3774
3775         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3776         https://bugs.webkit.org/show_bug.cgi?id=130732
3777
3778         Reviewed by Tim Horton.
3779
3780         * MiniBrowser/mac/WK2BrowserWindowController.m:
3781         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3782
3783 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3784
3785         [GTK] Remove the autotools build
3786         https://bugs.webkit.org/show_bug.cgi?id=130717
3787
3788         Reviewed by Anders Carlsson.
3789
3790         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3791         * GNUmakefile.am: Removed.
3792         * GtkLauncher/GNUmakefile.am: Removed.
3793         * GtkLauncher/main.c: Remove references to the autotools configure file.
3794         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3795         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3796         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3797         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3798         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3799         * Scripts/build-webkit: No longer handle autotools.
3800         * Scripts/run-gtk-tests: Ditto.
3801         (TestRunner._setup_testing_environment):
3802         * Scripts/run-launcher: Ditto.
3803         * Scripts/webkitdirs.pm: Ditto.
3804         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3805         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3806         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3807         * Scripts/webkitpy/style/checker.py:
3808         * TestWebKitAPI/GNUmakefile.am: Removed.
3809         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3810         * WebKitTestRunner/GNUmakefile.am: Removed.
3811         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3812         * gtk/GNUmakefile.am: Removed.
3813         * gtk/common.py: Remove checks for the autotools build.
3814         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3815
3816 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3817
3818         prepare-ChangeLog throws false positive warnings for modified files.
3819         https://bugs.webkit.org/show_bug.cgi?id=130687
3820
3821         Reviewed by Darin Adler.
3822
3823         * Scripts/prepare-ChangeLog:
3824         (originalFile): Ignore git commit paremeter.
3825         We don't need this to get the unmodified file.
3826         (extractLineRangeBeforeChange):
3827         Simplify the if statement. Follow-up after r166189.
3828
3829 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3830
3831         [EFL] Add ARM64 build support
3832         https://bugs.webkit.org/show_bug.cgi?id=130506
3833
3834         Rubber stamped by Gyuyoung Kim.
3835
3836         * Scripts/webkitdirs.pm:
3837         (isARM): Detect aarch64 as ARM.
3838
3839 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3840
3841         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3842         https://bugs.webkit.org/show_bug.cgi?id=130137
3843
3844         Reviewed by Csaba Osztrogonác.
3845
3846         * Scripts/webkitpy/common/checkout/changelog.py:
3847         (ChangeLogEntry._parse_bug_description):
3848         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3849         (test_parse_log_entries_from_changelog):
3850         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3851         (CheckoutTest.test_commit_info_for_revision):
3852
3853 2014-03-24  Andy Estes  <aestes@apple.com>
3854
3855         Fix the iOS build of TestWebKitAPI.
3856
3857         * TestWebKitAPI/Configurations/Base.xcconfig:
3858         * TestWebKitAPI/PlatformUtilities.h:
3859
3860 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3861
3862         Fix prepare-ChangeLog after r166156.
3863         https://bugs.webkit.org/show_bug.cgi?id=130674
3864
3865         Reviewed by Darin Adler.
3866
3867         * Scripts/prepare-ChangeLog:
3868         (generateFunctionLists):
3869         (extractLineRangeBeforeChange):
3870
3871 2014-03-24  Andy Estes  <aestes@apple.com>
3872
3873         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3874         https://bugs.webkit.org/show_bug.cgi?id=129322
3875
3876         Reviewed by Anders Carlsson.
3877
3878         Add an API test suite for _WKDownload.
3879
3880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3881         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3882         (-[DownloadDelegate initWithSourceURL:]):
3883         (-[DownloadDelegate sourceURL]):
3884         (-[DownloadDelegate _downloadDidStart:]):
3885         (-[DownloadDelegate _download:didReceiveResponse:]):
3886         (-[DownloadDelegate _download:didReceiveData:]):
3887         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3888         (-[DownloadDelegate _downloadDidFinish:]):
3889         (TEST):
3890         (runTestWithNavigationDelegate):
3891         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3892         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3893
3894 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3895
3896         filter-build-webkit: reduce unfiltered output
3897         https://bugs.webkit.org/show_bug.cgi?id=130485
3898
3899         Reviewed by Brent Fulgham.
3900
3901         * Scripts/filter-build-webkit:
3902         (shouldIgnoreLine):
3903
3904 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3905
3906         prepare-ChangeLog should list functions that have been removed too.
3907         https://bugs.webkit.org/show_bug.cgi?id=130508
3908
3909         Reviewed by Darin Adler.
3910
3911         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3912         We have to read the functions and the line ranges of them from the source
3913         before the change, then search for overlaps between them and the changed
3914         line ranges from diff.
3915
3916         * Scripts/prepare-ChangeLog:
3917         (originalFile): Get original source command.
3918         (generateFunctionLists): Collect deleted functions too.
3919         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3920         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3921         deleted functions ranges too.
3922         (extractLineRange): Renamed to extractLineRangeAfterChange.
3923
3924 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3925
3926         Move all EFL typedefs into EflTypedefs.h.
3927         https://bugs.webkit.org/show_bug.cgi?id=130511
3928
3929         Reviewed by Gyuyoung Kim.
3930
3931         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3932         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3933         * WebKitTestRunner/PlatformWebView.h: Ditto.
3934
3935 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3936
3937         Don't flush compositing layers within FrameView::willPaintContents()
3938         https://bugs.webkit.org/show_bug.cgi?id=130627
3939         <rdar://problem/16368869>
3940
3941         Reviewed by Sam Weinig.
3942         
3943         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3944         does not flush.
3945         
3946         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3947         into an explicit function called before dumping. 
3948         
3949         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
3950         are flushed to CA. They will be pushed to the window by snapshotting.
3951
3952         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3953         Fix weird path to IOKit.framework.
3954         * DumpRenderTree/mac/DumpRenderTree.mm:
3955         (updateDisplay):
3956         (dump):
3957         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3958         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
3959         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
3960
3961 2014-03-21  David Kilzer  <ddkilzer@apple.com>
3962
3963         fix-blink-patch: tool to fix up renamed directory paths in Blink
3964         <http://webkit.org/b/130609>
3965
3966         Reviewed by Ryosuke Niwa.
3967
3968         Usage: cat blink.patch | fix-blink-patch | svn-apply
3969
3970         * Scripts/fix-blink-patch: Added.
3971
3972 2014-03-21  Darin Adler  <darin@apple.com>
3973
3974         Remove use of deprecatedCharacters in WebKit API tests
3975         https://bugs.webkit.org/show_bug.cgi?id=130602
3976
3977         Reviewed by Antti Koivisto.
3978
3979         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3980         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
3981         (TestWebKitAPI::expectEmpty): Use characters8.
3982         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
3983
3984         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3985         Removed the test that is entirely about 16-bit conversion since that's basically a test of
3986         the deprecatedCharacters function itself, which we are about to delete.
3987
3988 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3989
3990         [webkitpy] Fix has_valid_reviewer()
3991         https://bugs.webkit.org/show_bug.cgi?id=130589
3992
3993         Reviewed by Csaba Osztrogonác.
3994
3995         * Scripts/webkitpy/common/checkout/changelog.py:
3996         (ChangeLogEntry.has_valid_reviewer):
3997         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3998         (test_has_valid_reviewer):
3999         * Scripts/webkitpy/common/config/committers.py:
4000         (CommitterList._reviewer_only):
4001         (CommitterList.committer_by_name):
4002         (CommitterList.reviewer_by_email):
4003         (CommitterList):
4004         (CommitterList.reviewer_by_name):
4005
4006 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4007
4008         Add cache support for jhbuild
4009         https://bugs.webkit.org/show_bug.cgi?id=130588
4010
4011         Reviewed by Csaba Osztrogonác.
4012
4013         * jhbuild/jhbuildrc_common.py:
4014         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
4015
4016 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4017
4018         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
4019         https://bugs.webkit.org/show_bug.cgi?id=130504
4020
4021         Reviewed by Martin Robinson.
4022
4023         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
4024         CMake if not specified.
4025         * Scripts/webkitdirs.pm:
4026         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
4027         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
4028
4029 2014-03-21  Andreas Kling  <akling@apple.com>
4030
4031         RetainPtr API test should use CFArray instead of CFString for testing.
4032         <rdar://problem/16384899>
4033
4034         Unreviewed bot fix.
4035
4036         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4037         (TestWebKitAPI::TEST):
4038         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4039         (TestWebKitAPI::TEST):
4040
4041 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
4042
4043         Move to using std::unique_ptr for EFL objects.
4044         https://bugs.webkit.org/show_bug.cgi?id=129853
4045
4046         Reviewed by Gyuyoung Kim.
4047
4048         EflUniquePtr is a template alias of std::unique_ptr
4049         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
4050         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
4051
4052         * DumpRenderTree/efl/DumpRenderTree.cpp:
4053         (main):
4054         * ImageDiff/efl/ImageDiff.cpp:
4055         (initEfl):
4056         (main):
4057
4058 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
4059
4060         Unreviewed buildfix after r165983 for non Cocoa platforms
4061
4062         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
4063
4064         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
4065         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4066         * WebKitTestRunner/TestController.cpp:
4067
4068 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
4069
4070         [GTK][CMake] Add support for building with Clang
4071         https://bugs.webkit.org/show_bug.cgi?id=130260
4072
4073         Reviewed by Martin Robinson.
4074
4075         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
4076         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
4077         included GTest framework headers.
4078         * gtk/generate-gtkdoc:
4079         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
4080         in case of using Clang since that is now set by the CMake rule.
4081
4082 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
4083
4084         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4085         https://bugs.webkit.org/show_bug.cgi?id=130476
4086
4087         Reviewed by Anders Carlsson.
4088         
4089         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
4090
4091         * MiniBrowser/mac/WK1BrowserWindowController.m:
4092         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4093         Remove log.
4094         * MiniBrowser/mac/WK2BrowserWindowController.m:
4095         (-[WK2BrowserWindowController awakeFromNib]):
4096         (-[WK2BrowserWindowController validateMenuItem:]):
4097         (-[WK2BrowserWindowController reload:]):
4098         Hook up reload.
4099         (-[WK2BrowserWindowController toggleZoomMode:]):
4100         (-[WK2BrowserWindowController resetZoom:]):
4101         (-[WK2BrowserWindowController canResetZoom]):
4102         (-[WK2BrowserWindowController currentZoomFactor]):
4103         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
4104         (-[WK2BrowserWindowController canZoomIn]):
4105         (-[WK2BrowserWindowController canZoomOut]):
4106
4107 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
4108
4109         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
4110         https://bugs.webkit.org/show_bug.cgi?id=130463
4111
4112         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
4113
4114 2014-03-18  Samuel White  <samuel_white@apple.com>
4115
4116         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
4117         https://bugs.webkit.org/show_bug.cgi?id=130250
4118
4119         Reviewed by Chris Fleizach.
4120
4121         Added ability to toggle enhanced accessibility on and off to support tests that require it.
4122
4123         * DumpRenderTree/AccessibilityController.cpp:
4124         (enableEnhancedAccessibilityCallback):
4125         (getEnhancedAccessibilityEnabledCallback):
4126         (AccessibilityController::getJSClass):
4127         * DumpRenderTree/AccessibilityController.h:
4128         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4129         (AccessibilityController::enableEnhancedAccessibility):
4130         (AccessibilityController::enhancedAccessibilityEnabled):
4131         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
4132         (AccessibilityController::enableEnhancedAccessibility):
4133         (AccessibilityController::enhancedAccessibilityEnabled):
4134         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4135         (AccessibilityController::enableEnhancedAccessibility):
4136         (AccessibilityController::enhancedAccessibilityEnabled):
4137         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4138         (AccessibilityController::enableEnhancedAccessibility):
4139         (AccessibilityController::enhancedAccessibilityEnabled):
4140         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4141         (WTR::AccessibilityController::enableEnhancedAccessibility):
4142         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
4143         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4144         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4145
4146 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
4147
4148         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
4149         yet).
4150
4151         * Scripts/webkitpy/common/config/contributors.json:
4152
4153 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
4154
4155         Web Inspector: Remove stale ReportMemoryUsagePlugin
4156         https://bugs.webkit.org/show_bug.cgi?id=130405
4157
4158         Reviewed by Andreas Kling.
4159
4160         This clang plugin looks like it was used for the old Inspector memory
4161         instrumentation that was removed. So the tool can be removed.
4162
4163         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
4164         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
4165         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
4166         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
4167
4168 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4169
4170         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
4171         https://bugs.webkit.org/show_bug.cgi?id=130220
4172
4173         Reviewed by Csaba Osztrogonác.
4174
4175         * Scripts/webkitpy/common/checkout/changelog.py:
4176         (ChangeLog.set_reviewer):
4177         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4178         (test_set_reviewer):
4179
4180 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
4181
4182         More FTL enabling.
4183
4184         Rubber stamped by Dan Bernstein.
4185
4186         * Tools/Scripts/build-webkit:
4187
4188 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4189
4190         Renable pagination mode in WK2 MiniBrowser
4191         https://bugs.webkit.org/show_bug.cgi?id=130374
4192
4193         Reviewed by Anders Carlsson.
4194         
4195         Put the implementation of togglePaginationMode: back, and correctly
4196         enable the menu item.
4197
4198         * MiniBrowser/mac/WK2BrowserWindowController.m:
4199         (-[WK2BrowserWindowController validateMenuItem:]):
4200         (-[WK2BrowserWindowController isPaginated]):
4201         (-[WK2BrowserWindowController togglePaginationMode:]):
4202
4203 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4204
4205         Add --reset option to Tools/Scripts/set-webkit-configuration script
4206         https://bugs.webkit.org/show_bug.cgi?id=130401
4207
4208         Reviewed by Csaba Osztrogonác.
4209
4210         * Scripts/set-webkit-configuration:
4211
4212 2014-03-18  Alberto Garcia  <berto@igalia.com>
4213
4214         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
4215         https://bugs.webkit.org/show_bug.cgi?id=130388
4216
4217         Reviewed by Sergio Villar Senin.
4218
4219         * Scripts/webkitdirs.pm:
4220         (shouldRemoveCMakeCache): make sure that the build directory
4221         exists before attempting to create a file in it.
4222
4223 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
4224
4225         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
4226         https://bugs.webkit.org/show_bug.cgi?id=130336
4227
4228         Reviewed by Gyuyoung Kim.
4229
4230         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
4231         requires a space between literal and string macro [-Wliteral-suffix]'
4232         warning treated as error.
4233
4234         This patch applies a solution from r162448 to the EFL port.
4235
4236         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
4237         * efl/jhbuild.modules: Added appropriate patch section.
4238
4239 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
4240
4241         webkitpy test rebaseline.
4242
4243         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4244         (MainTest.test_default_args):
4245
4246 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
4247
4248         --profile should imply --test-runner-count=1 in run-perf-tests
4249         https://bugs.webkit.org/show_bug.cgi?id=130375
4250
4251         Reviewed by Benjamin Poulain.
4252
4253         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
4254
4255         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4256         (PerfTestsRunner._parse_args): Use -1 as the default value.
4257         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
4258         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
4259         should be 1.
4260
4261 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4262
4263         Address some style nits.
4264
4265         * MiniBrowser/mac/WK2BrowserWindowController.m:
4266
4267 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4268
4269         Add transparent window support back into MiniBrowser
4270         https://bugs.webkit.org/show_bug.cgi?id=130363
4271
4272         Reviewed by Anders Carlsson.
4273         
4274         Re-enable transparent window support for WK2.
4275
4276         * MiniBrowser/mac/WK2BrowserWindowController.m:
4277         (-[WK2BrowserWindowController validateMenuItem:]):
4278         (-[WK2BrowserWindowController toggleTransparentWindow:]):
4279
4280 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4281
4282         Fix the 32-bit build; make the open panel make a WK1 window.
4283
4284         * MiniBrowser/mac/AppDelegate.m:
4285         (-[BrowserAppDelegate openDocument:]):
4286
4287 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4288
4289         Convert MiniBrowser to use WKWebView API
4290         https://bugs.webkit.org/show_bug.cgi?id=130061
4291
4292         Reviewed by Anders Carlsson.
4293         
4294         Convert the MiniBrowser WK2 window to use WebKit2 API as much
4295         as possible.
4296         
4297         Some functionality was removed temporarily:
4298             - text zoom, page zoom
4299             - reload
4300             - pagination mode
4301             - transparent window
4302             - dumping source
4303             - window.open support
4304             - beforeUnload panel
4305             - find in page
4306
4307         * MiniBrowser/mac/AppDelegate.h:
4308         * MiniBrowser/mac/AppDelegate.m:
4309         (-[BrowserAppDelegate init]):
4310         (-[BrowserAppDelegate newWindow:]):
4311         (-[BrowserAppDelegate applicationWillTerminate:]):
4312         (-[BrowserAppDelegate openDocument:]):
4313         * MiniBrowser/mac/WK2BrowserWindowController.h:
4314         * MiniBrowser/mac/WK2BrowserWindowController.m:
4315         (-[WK2BrowserWindowController awakeFromNib]):
4316         (-[WK2BrowserWindowController dealloc