[WK2] webarchive/loading/javascript-url-iframe-crash.html fails
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
2
3         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
4         https://bugs.webkit.org/show_bug.cgi?id=96817
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
10         got overlooked when adding logging elsewhere.
11
12 2012-09-14  Peter Beverloo  <peter@chromium.org>
13
14         [Chromium] Build fix for DumpRenderTree following r128628
15         https://bugs.webkit.org/show_bug.cgi?id=96808
16
17         Reviewed by Tony Chang.
18
19         When building DumpRenderTree from the Chromium project, a compile error
20         shows up because including the header ForwardIOStreamsAndroid.h cannot
21         be located. TestWebKitAPI does this correctly.
22
23         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
24
25 2012-09-14  Dana Jansens  <danakj@chromium.org>
26
27         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
28         https://bugs.webkit.org/show_bug.cgi?id=96805
29
30         Reviewed by Dirk Pranke.
31
32         * Scripts/webkitpy/common/config/committers.py:
33         * Scripts/webkitpy/common/config/watchlist:
34
35 2012-09-14  Peter Beverloo  <peter@chromium.org>
36
37         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
38         https://bugs.webkit.org/show_bug.cgi?id=96687
39
40         Reviewed by Tony Chang.
41
42         Android's DumpRenderTree currently supports these arguments, implemented
43         as part of TestShellAndroid:
44         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
45
46         They're used by the layout test runner to get the STDOUT and STDERR while
47         a layout test run is in process, which is a safer alternative to parsing
48         all the logcat output manually. The implementation can be seen here:
49         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
50
51         This patch generalizes parsing of and applying the effects of these arguments
52         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
53         After this patch, this will make it possible to pull out the output-reading
54         code from Android's layout test port and generalize it so it can be re-used
55         in the new test-runner for the other two test suites.
56
57         This has no effect when compiling and running these tests as part of Chromium
58         code, which has a much more advanced test-runner that does parse complete log
59         output, but also directly depends on code licensed under Apache 2.
60
61         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
62         * DumpRenderTree/chromium/TestShellAndroid.cpp:
63         (platformInit):
64         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
65
66 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
67
68         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
69         https://bugs.webkit.org/show_bug.cgi?id=96656
70
71         Reviewed by Adam Barth.
72
73         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
74         macros in 1 line.
75
76         * Scripts/webkitpy/style/checkers/cpp.py:
77         (check_style.definitions):
78         (check_style): Add rule.
79         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
80         (WebKitStyleTest.test_line_breaking): Add unittest.
81
82 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
83
84         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
85         https://bugs.webkit.org/show_bug.cgi?id=57570
86
87         Reviewed by Kenneth Rohde Christiansen.
88
89         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
90         and dump the information expected by the test cases.
91
92         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
93         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
94         (WTR::InjectedBundle::beginTesting): Explicitly set the default
95         database quota.
96         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
97         (WTR::securityOriginToStr): New convenience function to convert
98         a security origin to the string expected in test results.
99         (WTR):
100         (WTR::InjectedBundlePage::InjectedBundlePage):
101         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
102         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
103         refactoring to share code with didExceedDatabaseQuota.
104         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
105         (InjectedBundlePage):
106         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
107         (WTR::TestRunner::TestRunner):
108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
109         (WTR::TestRunner::dumpDatabaseCallbacks):
110         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
111         (TestRunner):
112
113 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
114
115         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
116
117         Rubber-stamped by Simon Hausmann.
118
119         * qmake/mkspecs/features/default_post.prf:
120
121 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
122
123         [Qt] Remove old cruft from the qmake build system
124
125         Rubber-stamped by Simon Hausmann.
126
127         * DumpRenderTree/qt/DumpRenderTree.pro:
128         * qmake/mkspecs/features/default_post.prf:
129
130 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
131
132         [Qt] Enable force_static_libs_as_shared for development
133
134         Not enabled for buildbots or production-builds (part of Qt5)
135
136         Reviewed by Simon Hausmann.
137
138         * qmake/mkspecs/features/default_post.prf:
139
140 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
141
142         [Qt] Make force_static_libs_as_shared work on Mac OS
143
144         We had to move a few LIBS += around that were in the wrong place,
145         and not caught when everything was just linked into the final
146         QtWebKit library.
147
148         Reviewed by Simon Hausmann.
149
150         * qmake/mkspecs/features/default_post.prf:
151         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
152
153 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
154
155         [Qt] Fix build of WTR on Windows
156
157         Reviewed by Tor Arne Vestbø.
158
159         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
160         With qmake's unix makefile generator as well as with the MingW generator,
161         the directory where the pro file lives (WTR/) is automatically added to
162         the include search path, but not so with MSVC. Instead of relying on qmake's
163         implicit feature here, add WTR/ explicitly to the include search path.
164
165         * WebKitTestRunner/Target.pri:
166
167 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
168
169         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
170         https://bugs.webkit.org/show_bug.cgi?id=42691
171
172         Reviewed by Kenneth Rohde Christiansen.
173
174         Add implementation for testrunner.setStopProvisionalFrameLoads()
175         in WebKitTestRunner.
176
177         Original patch by Alexey Proskuryakov.
178
179         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
181         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
183         (WTR::TestRunner::TestRunner):
184         * WebKitTestRunner/InjectedBundle/TestRunner.h:
185         (TestRunner):
186         (WTR::TestRunner::setStopProvisionalFrameLoads):
187         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
188
189 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
190
191         [Qt] Fix handling of debug/release/debug_and_release/build_all
192
193         We now pick up the defaults from Qt, in default_pre (CONFIG already
194         contains the appropriate values for debug and release). We then let
195         the command line arguments to qmake, or the project files themselves,
196         override the configuration, and finally we sanitize the configuration
197         in default_post.
198
199         Reviewed by Simon Hausmann.
200
201         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
202         * Scripts/webkitdirs.pm:
203         (buildQMakeProjects):
204         * qmake/mkspecs/features/default_post.prf:
205         * qmake/mkspecs/features/default_pre.prf:
206         * qmake/mkspecs/features/mac/default_pre.prf:
207
208 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
209
210         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
211         https://bugs.webkit.org/show_bug.cgi?id=42687
212
213         Reviewed by Kenneth Rohde Christiansen.
214
215         Implement testRunner.setTabKeyCyclesThroughElements for
216         WebKitTestRunner.
217
218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
220         (WTR::InjectedBundle::beginTesting):
221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
222         (WTR::TestRunner::setTabKeyCyclesThroughElements):
223         (WTR):
224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
225         (TestRunner):
226
227 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
228
229         EventSendingController::keyDown does not support non-array modifier arguments
230         https://bugs.webkit.org/show_bug.cgi?id=96727
231
232         Reviewed by Kenneth Rohde Christiansen.
233
234         Add support for handling a string as modifier argument to
235         EventSendingController::keyDown.
236
237         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
238         (WTR::parseModifierArray):
239
240 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
241
242         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
243         https://bugs.webkit.org/show_bug.cgi?id=42546
244
245         Reviewed by Kenneth Rohde Christiansen.
246
247         Exported TestRunner::setCustomPolicyDelegate() method.
248         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
249
250         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
251         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
252         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
253
254 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
255
256         [GTK] Clear application cache between tests in DumpRenderTree
257         https://bugs.webkit.org/show_bug.cgi?id=96543
258
259         Reviewed by Philippe Normand.
260
261         Call the new DumpRenderTreeSupportGtk method to clear application cache
262         after each test in DumpRenderTree.
263
264         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
265         as well. It's now being set in XvfbDriver._start so that each driver is assigned
266         a cache directory that's constructed out of the driver's name and its worker
267         number. These directories are located in the layout tests results directory.
268         At least on the builders this ensures a driver-specific empty cache directory
269         with each test run.
270
271         * DumpRenderTree/gtk/DumpRenderTree.cpp:
272         (runTest):
273         * Scripts/webkitpy/layout_tests/port/gtk.py:
274         (GtkPort.setup_environ_for_server):
275         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
276         (XvfbDriver._start):
277
278 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
279
280         [Qt] Fix linking on Windows
281
282         Reviewed by Tor Arne Vestbø.
283
284         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
285         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
286         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
287         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
288
289         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
290         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
291         after the module. Therefore QT did never contain webkit anymore and we always passed
292         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
293
294         This patch introduces a creating_module configuration that is used to
295         scope the qt/pkgconfig sanitization.
296
297         * qmake/mkspecs/features/default_post.prf:
298
299 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
300
301         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
302         https://bugs.webkit.org/show_bug.cgi?id=96740
303
304         Reviewed by Kenneth Rohde Christiansen.
305
306         Dump information expected by the test cases about the following
307         frame load callbacks:
308         "didDisplayInsecureContentForFrame"
309         "didRunInsecureContentForFrame"
310         "didDetectXSSForFrame"
311
312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
313         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
314         as expected by test results by calling pathSuitableForTestResult() instead
315         of printing raw URL.
316         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
317         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
318         (WTR::InjectedBundlePage::didDetectXSSForFrame):
319
320 2012-09-14  Peter Beverloo  <peter@chromium.org>
321
322         The runtime/unsigned category should be valid in the cpp style-checker.
323         https://bugs.webkit.org/show_bug.cgi?id=96748
324
325         Reviewed by Csaba Osztrogonác.
326
327         This is causing the webkitpy tests to fail because it's not listed in the
328         category array. Furthermore, change an "int" to "long" because it's
329         throwing a double error in one of the earlier asserts.
330
331         * Scripts/webkitpy/style/checkers/cpp.py:
332         (CppChecker):
333         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
334         (WebKitStyleTest.test_names):
335
336 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
337
338         Evas_Object* is a ref'ed structure, so tread it as such
339         https://bugs.webkit.org/show_bug.cgi?id=96659
340
341         Reviewed by Adam Barth.
342
343         Replace OwnPtr<Evas_Object> with RefPtr.
344
345         * DumpRenderTree/efl/ImageDiff.cpp:
346         (calculateDifference):
347         (printImageDifferences):
348         (readImageFromStdin):
349         (main):
350
351 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
352
353         Unreviewed, rolling out r128507.
354         http://trac.webkit.org/changeset/128507
355         https://bugs.webkit.org/show_bug.cgi?id=96659
356
357         Revert. r128507 makes too many crashes in EFL layout test bots.
358
359         * DumpRenderTree/efl/ImageDiff.cpp:
360         (calculateDifference):
361         (printImageDifferences):
362         (readImageFromStdin):
363         (main):
364
365 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
366
367         Make compile with both OS(WINCE) and PLATFORM(QT) support
368         https://bugs.webkit.org/show_bug.cgi?id=95536
369
370         Reviewed by Simon Hausmann.
371
372         Fix wince support in qmake files
373
374         * Tools.pro:
375         * qmake/mkspecs/features/configure.prf:
376         * qmake/mkspecs/features/default_post.prf:
377         * qmake/mkspecs/features/features.prf:
378         * qmake/mkspecs/features/functions.prf:
379
380 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
381
382         [WK2] Add color picker API support for WebKit2
383         https://bugs.webkit.org/show_bug.cgi?id=95058
384
385         Reviewed by Gyuyoung Kim.
386
387         Initialization code for color picker callbacks in UI client.
388
389         * MiniBrowser/mac/BrowserWindowController.m:
390         (-[BrowserWindowController awakeFromNib]):
391         * MiniBrowser/win/BrowserView.cpp:
392         (BrowserView::create):
393         * WebKitTestRunner/TestController.cpp:
394         (WTR::TestController::createOtherPage):
395         (WTR::TestController::initialize):
396
397 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
398
399         Upgrade yutak to reviewer
400         https://bugs.webkit.org/show_bug.cgi?id=96721
401
402         Reviewed by Kent Tamura.
403
404         * Scripts/webkitpy/common/config/committers.py:
405
406 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
407
408         Make the style checker report usage of "unsigned int"
409         https://bugs.webkit.org/show_bug.cgi?id=96693
410
411         Reviewed by Dirk Pranke.
412
413         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
414
415         * Scripts/webkitpy/style/checkers/cpp.py:
416         (check_language):
417
418 2012-09-13  Philip Rogers  <pdr@google.com>
419
420         Add gender-neutral form of webkit-patch land-cowboy
421         https://bugs.webkit.org/show_bug.cgi?id=96709
422
423         Reviewed by Adam Barth.
424
425         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
426
427         * Scripts/webkitpy/tool/commands/download.py:
428         (LandCowhand):
429
430 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
431
432         [EFL] Remove some parameters in browserCreate()
433         https://bugs.webkit.org/show_bug.cgi?id=96499
434
435         Reviewed by Kenneth Rohde Christiansen.
436
437         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
438         And I have moved some parameters into User_Arguments.
439
440         * EWebLauncher/main.c:
441         (_User_Arguments):
442         (_ELauncher):
443         (on_key_down):
444         (browserCreate):
445         (findThemePath):
446         (parseUserArguments):
447         (main):
448
449 2012-09-13  Mark Lam  <mark.lam@apple.com>
450
451         Unreviewed. Adding myself to the committers list.
452
453         * Scripts/webkitpy/common/config/committers.py:
454
455 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
456
457         run-perf-tests output cryptic error when the config file is missing.
458         https://bugs.webkit.org/show_bug.cgi?id=96453
459
460         Reviewed by Tony Chang.
461
462         Add a special error message when a configuration file is missing.
463
464         Also update the help message of --source-json-path to signify the fact it specifies
465         the configuration file on performance tests bots.
466
467         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
468         (PerfTestsRunner._parse_args):
469         (PerfTestsRunner._generate_and_show_results):
470         (PerfTestsRunner._merge_slave_config_json):
471         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
472         (_test_run_with_json_output): Make upload to fail by default and assert the result
473         in the function so that we can return logs instead.
474         (_test_run_with_json_output.mock_upload_json):
475         (test_run_with_json_output):
476         (test_run_with_description):
477         (test_run_respects_no_results):
478         (test_run_with_slave_config_json):
479         (test_run_with_bad_slave_config_json):
480         (test_run_with_multiple_repositories):
481
482 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
483
484         Evas_Object* is a ref'ed structure, so tread it as such
485         https://bugs.webkit.org/show_bug.cgi?id=96659
486
487         Reviewed by Adam Barth.
488
489         Replace OwnPtr<Evas_Object> with RefPtr.
490
491         * DumpRenderTree/efl/ImageDiff.cpp:
492         (calculateDifference):
493         (printImageDifferences):
494         (readImageFromStdin):
495         (main):
496
497 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
498
499         One more unreviewed trivial fix after r128399.
500
501         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
502
503 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
504
505         Unreviewed trivial fix after r128399.
506
507         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
508         (getLatestSVNRevision):
509         (waitForSVNRevision):
510
511 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
512
513         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
514         https://bugs.webkit.org/show_bug.cgi?id=96366
515
516         Reviewed by Anders Carlsson.
517
518         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
519         by calling shouldClose() on the FrameLoader.
520
521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
523         (WTR::TestRunner::callShouldCloseOnWebView):
524         (WTR):
525         * WebKitTestRunner/InjectedBundle/TestRunner.h:
526         (TestRunner):
527
528 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
529
530         Unreviewed, rolling out r128453.
531         http://trac.webkit.org/changeset/128453
532         https://bugs.webkit.org/show_bug.cgi?id=96681
533
534         Having tests use the same appcache directory leads to timeouts
535         (Requested by zdobersek on #webkit).
536
537         * DumpRenderTree/gtk/DumpRenderTree.cpp:
538         (runTest):
539         * Scripts/webkitpy/layout_tests/port/gtk.py:
540         (GtkPort.setup_environ_for_server):
541
542 2012-09-13  James Robinson  <jamesr@chromium.org>
543
544         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
545         https://bugs.webkit.org/show_bug.cgi?id=96678
546
547         Reviewed by Dirk Pranke.
548
549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
550         (.):
551
552 2012-09-13  Rob Buis  <rbuis@rim.com>
553
554         Unreviewed changes to watchlist.
555
556         - Add myself to BlackBerry bugs
557
558         * Scripts/webkitpy/common/config/watchlist:
559
560 2012-09-13  Stephen Chenney  <schenney@chromium.org>
561
562         Add an SVG entry to the watchlist
563
564         Unreviewed config change.
565
566         * Scripts/webkitpy/common/config/watchlist:
567         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
568         - Added myself and pdr as watchers
569
570 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
571
572         [Qt] Make WebKit2 work on Windows with Qt 5
573         https://bugs.webkit.org/show_bug.cgi?id=76776
574
575         Reviewed by Tor Arne Vestbø.
576
577         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
578         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
579         that for the GL TextureMapper (it's only built when that feature is set).
580
581         * qmake/mkspecs/features/configure.prf:
582
583 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
584
585         [Qt] Ensure that QT is finalized before loading qt_module.prf
586
587         As qt_module.prf does dependency tracking based on the content of the
588         QT variable. The intermediate WebKit modules modify the variable in
589         their .pri files, so we have to ensure we've loaded all the modules
590         before loading qt_module.
591
592         Reviewed by Tor Arne Vestbø.
593         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
594
595         * qmake/mkspecs/features/default_post.prf:
596         * qmake/mkspecs/features/webkit_modules.prf: Added.
597
598 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
599
600         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
601         https://bugs.webkit.org/show_bug.cgi?id=96633
602
603         Reviewed by Csaba Osztrogonác.
604
605         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
606         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
607         It's the usual problem and the usual solution is to rename one of the conflicting files.
608         This patch chooses to rename DRT instead of WTR and MBR.
609
610         Fixed include order at the same time to match style guide.
611
612         * DumpRenderTree/qt/DumpRenderTree.pro:
613         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
614         (messageHandler):
615         (isOption):
616         (takeOptionValue):
617         (printUsage):
618         (main):
619
620 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
621
622         The Script run-launcher should support -2 in combination with --efl
623         https://bugs.webkit.org/show_bug.cgi?id=96639
624
625         Reviewed by Simon Hausmann.
626
627         Support running the MiniBrowser then supplied -2 as argument.
628
629         * Scripts/run-launcher:
630
631 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
632
633         Unreviewed, add my Intel email address to the list.
634
635         * Scripts/webkitpy/common/config/committers.py:
636
637 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
638
639         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
640
641         Reviewed by Ossy.
642
643         * qmake/mkspecs/features/default_post.prf:
644
645 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
646
647         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
648         https://bugs.webkit.org/show_bug.cgi?id=82294
649
650         Reviewed by Gyuyoung Kim.
651
652         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
653
654         * DumpRenderTree/efl/TestRunnerEfl.cpp:
655         (TestRunner::layerTreeAsText):
656
657 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
658
659         [GTK] Clear application cache between tests in DumpRenderTree
660         https://bugs.webkit.org/show_bug.cgi?id=96543
661
662         Reviewed by Philippe Normand.
663
664         Call the new DumpRenderTreeSupportGtk method to clear application cache
665         after each test.
666
667         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
668         as well. Currently it points to a subdirectory in the layout tests results
669         directory. At least on the builders this ensures an empty cache directory
670         with each test run.
671
672         * DumpRenderTree/gtk/DumpRenderTree.cpp:
673         (runTest):
674         * Scripts/webkitpy/layout_tests/port/gtk.py:
675         (GtkPort.setup_environ_for_server):
676
677 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
678
679         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
680
681         Unless it's actually a dependency of the public QtWebKit API.
682
683         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
684         files with their _PRIVATE equivivalent, but that's likely to break when
685         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
686         clean up the variables in default_post.
687
688         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
689         longer needed, as it was a workaround for the intermediate libraries ending
690         up in the prl file. And, since CONFIG -= staticlib was there to support
691         the explicitlib option, we can remove that too (as well as the exception
692         for gprof, since it would be empty). If gprof needs tweaks to always link
693         statically they should go in gprof.prf.
694
695         Reviewed by Simon Hausmann.
696
697         * qmake/mkspecs/features/default_post.prf:
698         * qmake/mkspecs/features/functions.prf:
699
700 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
701
702         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
703         https://bugs.webkit.org/show_bug.cgi?id=96632
704
705         Reviewed by Carlos Garcia Campos.
706
707         Fix this by using atk_object_get_n_accessible_children instead of
708         calling getChildren() from childCount.
709
710         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
711         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
712         loop by using atk_object_get_n_accessible_children().
713
714 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
715
716         [Qt][Win] Enable USE(3D_GRAPHICS)
717         https://bugs.webkit.org/show_bug.cgi?id=90879
718
719         Reviewed by Kenneth Rohde Christiansen.
720
721         Enable it on Windows as well as on QNX (bug fixed).
722
723         * qmake/mkspecs/features/features.prf:
724
725 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
726
727         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
728         https://bugs.webkit.org/show_bug.cgi?id=96359
729
730         Reviewed by Tor Arne Vestbø.
731
732         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
733         lexer. The only viable alternative I could find on Windows that provides
734         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
735         so let's use that one instead.
736
737         * Scripts/webkitdirs.pm:
738         (checkRequiredSystemConfig):
739         * qmake/mkspecs/features/default_pre.prf:
740
741 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
742
743         [Qt] Add configuration for production builds
744         https://bugs.webkit.org/show_bug.cgi?id=96607
745
746         Reviewed by Kenneth Rohde Christiansen.
747
748         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
749         and enable all-in-one-files optimizations.
750
751         * qmake/mkspecs/features/production_build.prf: Added.
752
753 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
754
755         [Qt] GStreamer detection does not work when cross-compiling
756         https://bugs.webkit.org/show_bug.cgi?id=96608
757
758         Reviewed by Kenneth Rohde Christiansen.
759
760         When cross-compiling it is not safe to just use system(pkg-config),
761         because there is a high probability that it will find packages in the
762         host system instead of in the target one. Instead use qmake's new
763         packagesExist() function that takes care of this delicate aspect of
764         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
765         PKG_CONFIG_LIBDIR accordingly.
766
767         * qmake/mkspecs/features/features.prf:
768
769 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
770
771         [WK2][WTR] More efficient string handling in InjectedBundlePage
772         https://bugs.webkit.org/show_bug.cgi?id=96609
773
774         Reviewed by Kenneth Rohde Christiansen.
775
776         Update StringBuilder usage in InjectedBundlePage to follow
777         the latest recommandations for efficient string handling:
778         http://trac.webkit.org/wiki/EfficientStrings
779
780         This involves using appendLiteral() or appendNumber()
781         instead of append() whenever possible.
782
783         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
784         (WTR::dumpPath):
785         (WTR::rangeToStr):
786         (WTR::styleDecToStr):
787         (WTR::frameToStr):
788         (WTR::dumpResourceURL):
789         (WTR):
790         (WTR::dumpFrameDescriptionSuitableForTestResult):
791         (WTR::dumpRequestDescriptionSuitableForTestResult):
792         (WTR::dumpResponseDescriptionSuitableForTestResult):
793         (WTR::dumpErrorDescriptionSuitableForTestResult):
794         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
795         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
796         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
797         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
798         (WTR::InjectedBundlePage::didCommitLoadForFrame):
799         (WTR::InjectedBundlePage::didFinishProgress):
800         (WTR::dumpFrameScrollPosition):
801         (WTR::dumpFrameText):
802         (WTR::dumpDescendantFramesText):
803         (WTR::InjectedBundlePage::didFinishLoadForFrame):
804         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
805         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
806         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
807         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
808         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
809         (WTR::InjectedBundlePage::willSendRequestForFrame):
810         (WTR::InjectedBundlePage::didReceiveResponseForResource):
811         (WTR::InjectedBundlePage::didFinishLoadForResource):
812         (WTR::InjectedBundlePage::didFailLoadForResource):
813         (WTR::InjectedBundlePage::shouldCacheResponse):
814         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
815         (WTR::InjectedBundlePage::willAddMessageToConsole):
816         (WTR::InjectedBundlePage::willSetStatusbarText):
817         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
818         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
819         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
820         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
821         (WTR::InjectedBundlePage::shouldBeginEditing):
822         (WTR::InjectedBundlePage::shouldEndEditing):
823         (WTR::InjectedBundlePage::shouldInsertNode):
824         (WTR::InjectedBundlePage::shouldInsertText):
825         (WTR::InjectedBundlePage::shouldDeleteRange):
826         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
827         (WTR::InjectedBundlePage::shouldApplyStyle):
828         (WTR::InjectedBundlePage::didBeginEditing):
829         (WTR::InjectedBundlePage::didEndEditing):
830         (WTR::InjectedBundlePage::didChange):
831         (WTR::InjectedBundlePage::didChangeSelection):
832         (WTR::InjectedBundlePage::supportsFullScreen):
833         (WTR::InjectedBundlePage::enterFullScreenForElement):
834         (WTR::InjectedBundlePage::exitFullScreenForElement):
835         (WTR::InjectedBundlePage::beganEnterFullScreen):
836         (WTR::InjectedBundlePage::beganExitFullScreen):
837         (WTR::InjectedBundlePage::closeFullScreen):
838         (WTR::dumpBackForwardListItem):
839         (WTR::InjectedBundlePage::dumpBackForwardList):
840
841 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
842
843         [Qt][WK2] Memory leaks in Qt's TestRunner
844         https://bugs.webkit.org/show_bug.cgi?id=96603
845
846         Reviewed by Csaba Osztrogonác.
847
848         Fix memory leaks in Qt's TestRunner code by adopting WKString
849         created with WKStringCreateWithUTF8CString().
850
851         * WebKitTestRunner/qt/TestControllerQt.cpp:
852         (WTR::TestController::initializeInjectedBundlePath):
853         (WTR::TestController::initializeTestPluginDirectory):
854
855 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
856
857         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
858         https://bugs.webkit.org/show_bug.cgi?id=96506
859
860         Reviewed by Dirk Pranke.
861
862         Lower the timeout value to 6 seconds for release configuration and 12 seconds
863         for debug configuration. These are the same values the Chromium port uses.
864
865         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
866         the layout tests under WebKit2 generally) requires more attention and gardening
867         than what the current effort produces.
868
869         The unit test is updated as well to test these changes.
870
871         * Scripts/webkitpy/layout_tests/port/gtk.py:
872         (GtkPort.default_timeout_ms):
873         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
874         (GtkPortTest.test_default_timeout_ms):
875         (GtkPortTest.assertLinesEqual):
876
877 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
878
879         Add SVN mirror handling feature to build.webkit.org
880         https://bugs.webkit.org/show_bug.cgi?id=85887
881
882         Reviewed by Dirk Pranke.
883
884         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
885         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
886         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
887         (ConfigureBuild.start):
888         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
889         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
890         (Factory.__init__):
891         (BuildFactory.__init__):
892         (TestFactory.__init__):
893         (BuildAndTestFactory.__init__):
894         (BuildAndPerfTestFactory.__init__):
895         (BuildAndPerfTestWebKit2Factory.__init__):
896         (DownloadAndPerfTestFactory.__init__):
897         (DownloadAndPerfTestWebKit2Factory.__init__):
898         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
899         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
900         (SVNMirrorTest):
901         (SVNMirrorTest.setUp): Load config.json once at startup.
902         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
903         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
904         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
905         (getLatestSVNRevision): Get the latest SVN revison from the given server.
906         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
907                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
908
909 2012-09-12  Kangil Han  <kangil.han@samsung.com>
910
911         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
912         https://bugs.webkit.org/show_bug.cgi?id=81606
913
914         Reviewed by Tim Horton.
915
916         6 seconds is harsh for some jquery test cases.
917         Therefore, adjust the value to match DumpRenderTree.
918
919         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
920         (WTR):
921
922 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
923
924         [EFL] Support download attribute feature
925         https://bugs.webkit.org/show_bug.cgi?id=96462
926
927         Reviewed by Gyuyoung Kim.
928
929         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
930         and add "download,request" callback to the DumpRenderTree for EFL.
931
932         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
933         (DumpRenderTreeChrome::createView):
934         (DumpRenderTreeChrome::onDownloadRequest):
935         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
936         (DumpRenderTreeChrome):
937         * Scripts/webkitperl/FeatureList.pm:
938
939 2012-09-12  Stephanie Lewis  <slewis@apple.com>
940
941         Reduce parallism on the wk2 testers.
942         https://bugs.webkit.org/show_bug.cgi?id=95906
943
944         Reviewed by Dirk Pranke.
945
946         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
947         resource contention.  Reducing the number of processes alleviates the issue.  
948
949         Starting by reducing 25%.
950
951         * Scripts/webkitpy/layout_tests/port/mac.py:
952         (MacPort.default_child_processes):
953
954 2012-09-12  Brady Eidson  <beidson@apple.com>
955
956         Assert in NetscapePlugin::destroy() with async plugin init
957         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
958
959         Reviewed by Anders Carlsson.
960
961         Expose NPN_Invoke to plug-in tests:
962         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
963         (PluginTest::NPN_Invoke):
964         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
965         (PluginTest):
966
967         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
968         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
969         (InvokeDestroysPluginWithinNPP_New):
970         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
971         (InvokeDestroysPluginWithinNPP_New::NPP_New):
972         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
973
974 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
975
976         refactor TestExpectations tokenization slightly in preparation for the new syntax
977         https://bugs.webkit.org/show_bug.cgi?id=96564
978
979         Reviewed by Ojan Vafai.
980
981         This change changes how we will tokenize/lex the
982         TestExpectations files, in preparation for supporting both the
983         old syntax and the new one. This change by itself should be a
984         no-op.
985
986         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
987         (TestExpectationParser._tokenize_line):
988         (TestExpectationParser):
989         (TestExpectationParser._tokenize_line_using_old_format):
990         (TestExpectationParser._tokenize_line_using_new_format):
991
992 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
993
994         remove unused testexpectations editing code from webkitpy, garden-o-matic
995         https://bugs.webkit.org/show_bug.cgi?id=96562
996
997         Reviewed by Adam Barth.
998
999         This code was prototyped but never fully realized. Removing
1000         until it reanimates :).
1001
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1004         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1005         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1006         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1007         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1008         (GardeningHTTPRequestHandler._run_webkit_patch):
1009         (GardeningHTTPRequestHandler.ping):
1010         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1011         (BuildCoverageExtrapolatorTest.test_extrapolate):
1012         (GardeningServerTest.test_rebaseline_new_port):
1013
1014 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1015
1016         Remove unused bot, apple-xserve-1.
1017         https://bugs.webkit.org/show_bug.cgi?id=96570
1018         
1019         Reviewed by Stephanie Lewis.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/config.json:
1022
1023 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1024
1025         [GTK] We attempt to rebase documentation even if it's not present
1026         https://bugs.webkit.org/show_bug.cgi?id=96553
1027
1028         Reviewed by Martin Robinson.
1029
1030         Do not make the documentation rebase step fatal. This allows make
1031         install to succeed when there's no documentation generated.
1032
1033         * gtk/generate-gtkdoc:
1034
1035 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1036
1037         Respect WEBKITOUTPUTDIR when running EFL tests
1038         https://bugs.webkit.org/show_bug.cgi?id=96528
1039
1040         Reviewed by Dirk Pranke.
1041
1042         Expose user set WEBKITOUTPUTDIR to the web process.
1043
1044         * Scripts/webkitpy/layout_tests/port/driver.py:
1045         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1046         of the web process and its potential jhbuild wrapper.
1047
1048 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1049
1050         webkitdirs: fix uname version handling for cygwin
1051         https://bugs.webkit.org/show_bug.cgi?id=96436
1052
1053         Reviewed by Jon Honeycutt.
1054
1055         Newer versions of cygwin embed an additional version string
1056         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1057         Update the code to handle that.
1058
1059         * Scripts/webkitdirs.pm:
1060         (setupAppleWinEnv):
1061
1062 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1063
1064         Regression(r128338): Broke Windows build
1065         https://bugs.webkit.org/show_bug.cgi?id=96537
1066
1067         Unreviewed build fix.
1068
1069         Fix Apple-Win build by allocating array dynamically
1070         since its size is not constant.
1071
1072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1073         (WTR::stringArrayToJS):
1074
1075 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1076
1077         [chromium] Add a virtual test suite for fast/hidpi
1078         https://bugs.webkit.org/show_bug.cgi?id=90192
1079
1080         Reviewed by Dirk Pranke.
1081
1082         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1083         on the hardware accelerated path as the software path.
1084
1085         * DumpRenderTree/chromium/WebPreferences.cpp:
1086         (WebPreferences::applyTo):
1087         * Scripts/webkitpy/layout_tests/port/chromium.py:
1088         (ChromiumPort.virtual_test_suites):
1089
1090 2012-09-12  Adam Klein  <adamk@chromium.org>
1091
1092         [chromium] Add content_browsertests to the flakiness dashboard
1093         https://bugs.webkit.org/show_bug.cgi?id=96535
1094
1095         Reviewed by Ojan Vafai.
1096
1097         * TestResultServer/static-dashboards/dashboard_base.js:
1098
1099 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1100
1101         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1102         https://bugs.webkit.org/show_bug.cgi?id=96496
1103
1104         Reviewed by Kenneth Rohde Christiansen.
1105
1106         Add implementation for originsWithApplicationCache to
1107         WebKitTestRunner.
1108
1109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1111         (WTR::stringArrayToJS):
1112         (WTR):
1113         (WTR::TestRunner::originsWithApplicationCache):
1114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1115         (TestRunner):
1116
1117 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1118
1119         Fix Qt/Windows build with Python3
1120         https://bugs.webkit.org/show_bug.cgi?id=96473
1121
1122         Reviewed by Csaba Osztrogonác.
1123
1124         In Python 3 print is a real function, so we must use parentheses around
1125         the function parameters. This is backwards compatible with Python 2.
1126
1127         * Scripts/generate-win32-export-forwards:
1128
1129 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1130
1131         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1132
1133         As pointed out by Kevin, we should inject the "set PATH=..." statement
1134         to add the GnuWin32 directory only if that directory actually exists.
1135
1136         * qmake/mkspecs/features/default_post.prf:
1137
1138 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1139
1140         [EFL] [WK2] Memory leaks in TestControllerEfl
1141         https://bugs.webkit.org/show_bug.cgi?id=96525
1142
1143         Reviewed by Kenneth Rohde Christiansen.
1144
1145         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1146         of WKString created with WKStringCreateWithUTF8CString().
1147
1148         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1149         (WTR::TestController::initializeInjectedBundlePath):
1150         (WTR::TestController::initializeTestPluginDirectory):
1151
1152 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1153
1154         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1155         https://bugs.webkit.org/show_bug.cgi?id=96374
1156
1157         Reviewed by Kenneth Rohde Christiansen.
1158
1159         Implement support for dumpApplicationCacheDelegateCallbacks
1160         and disallowIncreaseForApplicationCacheQuota in
1161         WebKitTestRunner and properly dump the information
1162         expected by the tests.
1163
1164         If the application cache quota is reached for a given
1165         security origin, WebKitTestRunner will reset the quota
1166         to its default value, unless intructed not to via
1167         disallowIncreaseForApplicationCacheQuota().
1168
1169         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1171         (WTR::InjectedBundlePage::InjectedBundlePage):
1172         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1173         (WTR):
1174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1175         (InjectedBundlePage):
1176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1177         (WTR::TestRunner::TestRunner):
1178         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1179         (WTR):
1180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1181         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1182         (TestRunner):
1183         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1184         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1185
1186 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1187
1188         [chromium] remove deprecated and unused sets import from chromium_android driver
1189         https://bugs.webkit.org/show_bug.cgi?id=96485
1190
1191         Reviewed by Dirk Pranke.
1192
1193         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1194
1195 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1196
1197         Flakiness dashboard doesn't recognize new Chromium Android test builder
1198         https://bugs.webkit.org/show_bug.cgi?id=96523
1199
1200         Reviewed by Ojan Vafai.
1201
1202         Properly return 'ANDROID' as the Chromium platform for Android builders.
1203
1204         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1205         (chromiumPlatform):
1206         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1207         (test):
1208
1209 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1210
1211         [Qt] Build on Windows requires bison/flex in PATH
1212         https://bugs.webkit.org/show_bug.cgi?id=96358
1213
1214         Reviewed by Tor Arne Vestbø.
1215
1216         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1217         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1218         a separate installation of various GNU tools is required as the operating system doesn't come with
1219         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1220         the gnuwin32 directory of the qt5.git top-level repository.
1221
1222         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1223
1224         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1225         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1226         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1227         updated with the new tool.
1228
1229         * Scripts/webkitdirs.pm:
1230         (checkRequiredSystemConfig):
1231         * qmake/mkspecs/features/default_post.prf:
1232
1233 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1234
1235         [Qt] Update build-jsc after r128174
1236
1237         Reviewed by Ossy.
1238
1239         * Scripts/build-jsc:
1240
1241 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1242
1243         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1244
1245         By hard-coding the names of the targets we defined we ended up just
1246         redefining the previous target when using addStrictSubdirOrderBetween
1247         more than once in a single project file.
1248
1249         We now embed the two base targets into the target names.
1250
1251         Reviewed by Simon Hausmann.
1252
1253         * qmake/mkspecs/features/functions.prf:
1254
1255 2012-09-12  Philippe Liard  <pliard@google.com>
1256
1257         Depend on {base,net} GYP targets rather than {base,net}_java.
1258         https://bugs.webkit.org/show_bug.cgi?id=95690
1259
1260         Reviewed by Adam Barth.
1261
1262         {base,net}_java became 'private' targets on the Chromium side that
1263         clients should not depend on (see
1264         https://chromiumcodereview.appspot.com/10913083/).
1265         This removes a bunch of trailing white spaces additionally in
1266         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1267
1268         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1269         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1270
1271 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1272
1273         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1274         https://bugs.webkit.org/show_bug.cgi?id=96494
1275
1276         Reviewed by Tor Arne Vestbø.
1277
1278         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1279         plugin process feature if we don't have NPAPI.
1280
1281         * qmake/mkspecs/features/features.prf:
1282
1283 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1284
1285         Unreviewed, rolling out r128280.
1286         http://trac.webkit.org/changeset/128280
1287         https://bugs.webkit.org/show_bug.cgi?id=96498
1288
1289         it broke compilation on windows debug bot (Requested by loislo
1290         on #webkit).
1291
1292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1294         (WTR::InjectedBundlePage::InjectedBundlePage):
1295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1296         (InjectedBundlePage):
1297         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1298         (WTR::TestRunner::TestRunner):
1299         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1300         (TestRunner):
1301
1302 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1303
1304         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1305         https://bugs.webkit.org/show_bug.cgi?id=96488
1306
1307         Reviewed by Tor Arne Vestbø.
1308
1309         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1310         because there are no such targets. We want the generated sources to be independent from release
1311         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1312         redirect to the same general-purpose target (first) of creating the derived sources.
1313
1314         * qmake/mkspecs/features/default_post.prf:
1315
1316 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1317
1318         [EFL] Make DumpRenderTree smarter at finding the fonts
1319         http://webkit.org/b/96281
1320
1321         Reviewed by Gyuyoung Kim.
1322
1323         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1324         Use CString consistently.
1325
1326         * DumpRenderTree/efl/FontManagement.cpp:
1327         (buildPath):
1328         (getCoreFontFiles):
1329         (addFontDirectory):
1330         (addFontFiles):
1331         (getCustomBuildDir):
1332         (getPlatformFontsPath):
1333         (addFontsToEnvironment):
1334
1335 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1336
1337         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1338         https://bugs.webkit.org/show_bug.cgi?id=96374
1339
1340         Reviewed by Kenneth Rohde Christiansen.
1341
1342         Implement support for dumpApplicationCacheDelegateCallbacks
1343         and disallowIncreaseForApplicationCacheQuota in
1344         WebKitTestRunner and properly dump the information
1345         expected by the tests.
1346
1347         If the application cache quota is reached for a given
1348         security origin, WebKitTestRunner will reset the quota
1349         to its default value, unless intructed not to via
1350         disallowIncreaseForApplicationCacheQuota().
1351
1352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1354         (WTR::InjectedBundlePage::InjectedBundlePage):
1355         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1356         (WTR):
1357         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1358         (InjectedBundlePage):
1359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1360         (WTR::TestRunner::TestRunner):
1361         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1362         (WTR):
1363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1364         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1365         (TestRunner):
1366         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1367         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1368
1369 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1370
1371         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1372         https://bugs.webkit.org/show_bug.cgi?id=96388
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         Exported TestRunner.workerThreadCount as readonly attribute.
1377
1378         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1379         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1380         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1381         (WTR):
1382         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1383         (TestRunner):
1384
1385 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1386
1387         [chromium] Consume a user gesture when creating a new view.
1388         https://bugs.webkit.org/show_bug.cgi?id=96373
1389
1390         Reviewed by Adam Barth.
1391
1392         * DumpRenderTree/chromium/WebViewHost.cpp:
1393         (WebViewHost::createView):
1394
1395 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1396
1397         [WK2][WTR] Some of TestRunner special options are not reset before testing
1398         https://bugs.webkit.org/show_bug.cgi?id=96384
1399
1400         Reviewed by Kenneth Rohde Christiansen.
1401
1402         Now values of the following special options are reset:
1403         void setAcceptsEditing(in boolean value);
1404         void setCloseRemainingWindowsWhenComplete(in boolean value);
1405         void setXSSAuditorEnabled(in boolean value);
1406         void setAllowFileAccessFromFileURLs(in boolean value);
1407         void setPluginsEnabled(in boolean value);
1408         void setPopupBlockingEnabled(in boolean value);
1409
1410         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1411         (WTR::InjectedBundle::beginTesting):
1412
1413 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1414
1415         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1416         https://bugs.webkit.org/show_bug.cgi?id=96273
1417
1418         Reviewed by Gyuyoung Kim.
1419
1420         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1421         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1422
1423         * WebKitTestRunner/CMakeLists.txt:
1424
1425 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1426
1427         [chromium] rename webkit_resources
1428         https://bugs.webkit.org/show_bug.cgi?id=95874
1429
1430         Reviewed by James Robinson.
1431
1432         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1433
1434 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1435
1436         [chromium] don't include content shell builders in the garden-o-matic view
1437         https://bugs.webkit.org/show_bug.cgi?id=96418
1438
1439         Reviewed by James Robinson.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1442
1443 2012-09-11  Adam Klein  <adamk@chromium.org>
1444
1445         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1446         https://bugs.webkit.org/show_bug.cgi?id=96411
1447
1448         Reviewed by Adam Barth.
1449
1450         Previously only the exact string "warning" was treated as a warning
1451         result. This patch treats any string with "warning" as a substring
1452         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1455         (.):
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1457
1458 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1459
1460         Restore original value of mock scrollbars enabled in InternalSettings
1461         https://bugs.webkit.org/show_bug.cgi?id=87680
1462
1463         Reviewed by Adam Barth.
1464
1465         Added backup support for mock scrollbars state in
1466         InternalSettings::Backup, and removed support for these
1467         from Qt's DumpRenderTree.
1468
1469         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1470         (WebCore::WebPage::resetSettings):
1471         * DumpRenderTree/qt/TestRunnerQt.cpp:
1472         (TestRunner::setFrameFlatteningEnabled):
1473         * DumpRenderTree/qt/TestRunnerQt.h:
1474         (TestRunner):
1475
1476 2012-09-11  Dan Bernstein  <mitz@apple.com>
1477
1478         Fixed a bug where kill-old-processes failed to kill clang++.
1479
1480         Rubber-stamped by Alexey Proskuryakov.
1481
1482         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1483         where it is passed as a regular expression to killall.
1484
1485 2012-09-11  Philippe Liard  <pliard@google.com>
1486
1487         Make sure that md5sum is not setup on non-Chromium Android platforms.
1488         https://bugs.webkit.org/show_bug.cgi?id=96393
1489
1490         Reviewed by Adam Barth.
1491
1492         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1493         which is also invoked on non-Chromium Android platforms. The following patch
1494         moves this logic to _startup_test() which is guaranteed to be invoked
1495         only on Android.
1496
1497         This also updates the prompt unit test in chromium_android_unittest.py.
1498
1499         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1500         (ChromiumAndroidDriver.__init__):
1501         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1502         (ChromiumAndroidDriver._setup_test):
1503
1504 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1505
1506         [EFL] Rewrite the EFL-related Find modules
1507         https://bugs.webkit.org/show_bug.cgi?id=95237
1508
1509         Reviewed by Kenneth Rohde Christiansen.
1510
1511         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1512         property and include all the Enlightenment Foundation Libraries
1513         required by the target.
1514         * EWebLauncher/CMakeLists.txt: Ditto.
1515         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1516         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1517         now that they are not added implicitly.
1518         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1519         property.
1520         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1521         property and include all the Enlightenment Foundation Libraries
1522         required by the target.
1523
1524 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1525
1526         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1527         https://bugs.webkit.org/show_bug.cgi?id=96379
1528
1529         Reviewed by Kenneth Rohde Christiansen.
1530
1531         Add implementation for setApplicationCacheOriginQuota
1532         to WebKitTestRunner.
1533
1534         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1536         (WTR::TestRunner::setApplicationCacheOriginQuota):
1537         (WTR):
1538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1539         (TestRunner):
1540
1541 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1542
1543         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1544         https://bugs.webkit.org/show_bug.cgi?id=91988
1545
1546         Reviewed by Kenneth Rohde Christiansen.
1547
1548         Regular key events generated by Qt for the tab key fill both
1549         keyCode and keyText, so we should do the same for our fake events.
1550
1551         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1552         (WTR::EventSenderProxy::keyDown):
1553
1554 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1555
1556         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1557         https://bugs.webkit.org/show_bug.cgi?id=96269
1558
1559         Reviewed by Kenneth Rohde Christiansen.
1560
1561         Exported missing testRunner.setSpatialNavigationEnabled() method.
1562
1563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1564         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1565         (WTR::InjectedBundle::beginTesting):
1566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1567         (WTR::TestRunner::setSpatialNavigationEnabled):
1568         (WTR):
1569         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1570         (TestRunner):
1571
1572 2012-09-11  Philippe Liard  <pliard@chromium.org>
1573
1574         Support LayoutTests on non-rooted devices for Chromium Android.
1575         https://bugs.webkit.org/show_bug.cgi?id=95346
1576
1577         Reviewed by Dirk Pranke.
1578
1579         We were requiring root permissions to sync resource files with the
1580         device by comparing host and device files' timestamp after we
1581         synchronized the device and host clocks.
1582         We now rely on md5sum provided by Chromium to handle data files
1583         synchronization.
1584
1585         * Scripts/webkitpy/layout_tests/port/chromium.py:
1586         (ChromiumPort._check_driver_build_up_to_date):
1587         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1588         (ChromiumAndroidDriver.__init__):
1589         (ChromiumAndroidDriver._setup_test):
1590         (ChromiumAndroidDriver._push_executable):
1591         (ChromiumAndroidDriver._push_test_resources):
1592         (ChromiumAndroidDriver._read_prompt):
1593
1594 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1595
1596         [Qt] Fix output paths on Windows
1597
1598         Reviewed by Tor Arne Vestbø.
1599
1600         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1601         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
1602         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
1603         incorrect here and instead for the calculation we should use forward slashes.
1604
1605         * qmake/mkspecs/features/default_pre.prf:
1606
1607 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1608
1609         [Qt] Fix passing of defines from the build system
1610
1611         We explicitly have to pass -DENABLE_FOO=0 for every single feature
1612         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
1613         will add it's own defaults if the features are not defined.
1614
1615         At some point we might want to run a configure-test to inspect what
1616         Platform.h will do, so we can sync up the build system's view of
1617         the feature-defines with the compile-time situation.
1618
1619         Reviewed by Simon Hausmann.
1620
1621         * qmake/mkspecs/features/functions.prf:
1622
1623 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1624
1625         [Qt] Fix --qt option to build-webkit
1626
1627         Reviewed by Ossy.
1628
1629         * Scripts/webkitdirs.pm:
1630         (buildQMakeProjects):
1631
1632 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1633
1634         [Qt] Add a configure step to the Qt build system
1635
1636         This allows building the Qt port using just 'qmake WebKit.pro'. Using
1637         the build-webkit script is still supported, and will add slightly more
1638         logic to the build, such as detecting the need for clean or incremental
1639         builds.
1640
1641         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
1642         all things related to configuring the build, such as use/have/enable flags,
1643         and these are translated to defines in default_post. Project files should
1644         no longer check contains(DEFINES,...) to detect features, but use the new
1645         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
1646         options have been translated into WEBKIT_CONFIG options as well, and can
1647         be checked using build?().
1648
1649         Reviewed by Simon Hausmann.
1650
1651         * DumpRenderTree/qt/DumpRenderTree.pro:
1652         * MiniBrowser/qt/MiniBrowser.pro:
1653         * QtTestBrowser/QtTestBrowser.pro:
1654         * Scripts/build-webkit:
1655         * Scripts/webkitdirs.pm:
1656         (qtFeatureDefaults):
1657         (buildQMakeProjects):
1658         * Tools.pro:
1659         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1660         * WebKitTestRunner/InjectedBundle/Target.pri:
1661         * WebKitTestRunner/Target.pri:
1662         * qmake/.qmake.cache: Added.
1663         * qmake/configure.pri: Removed.
1664         * qmake/configure.pro: Removed.
1665         * qmake/dump-features: Added.
1666         * qmake/mkspecs/features/configure.prf: Added.
1667         * qmake/mkspecs/features/default_post.prf:
1668         * qmake/mkspecs/features/default_pre.prf:
1669         * qmake/mkspecs/features/features.prf:
1670         * qmake/mkspecs/features/features.pri:
1671         * qmake/mkspecs/features/functions.prf:
1672         * qmake/mkspecs/features/gprof.prf:
1673         * qmake/mkspecs/features/mac/default_pre.prf:
1674         * qmake/mkspecs/features/win32/default_pre.prf:
1675
1676 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1677
1678         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
1679         https://bugs.webkit.org/show_bug.cgi?id=96372
1680
1681         Reviewed by Kenneth Rohde Christiansen.
1682
1683         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
1684
1685         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1686         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1687         (WTR::TestRunner::clearApplicationCacheForOrigin):
1688         (WTR):
1689         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1690         (TestRunner):
1691
1692 2012-09-11  Peter Beverloo  <peter@chromium.org>
1693
1694         Don't ignore .pak files when making an archive for Android
1695         https://bugs.webkit.org/show_bug.cgi?id=96375
1696
1697         Reviewed by Jochen Eisinger.
1698
1699         The .pak files do need to be pushed to the device, which is currently
1700         preventing the layout test runner from correctly pushing all files.
1701
1702         * BuildSlaveSupport/built-product-archive:
1703         (archiveBuiltProduct):
1704
1705 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1706
1707         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
1708         https://bugs.webkit.org/show_bug.cgi?id=96256
1709
1710         Reviewed by Kenneth Rohde Christiansen.
1711
1712         Exported TestRunner::setMinimumTimerInterval() method.
1713
1714         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1715         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1716         (WTR::InjectedBundle::beginTesting):
1717         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1718         (WTR::TestRunner::setMinimumTimerInterval):
1719         (WTR):
1720         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1721         (TestRunner):
1722
1723 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
1724
1725         MediaStream API: add RTCPeerConnection::onnegotiationneeded
1726         https://bugs.webkit.org/show_bug.cgi?id=96097
1727
1728         Reviewed by Adam Barth.
1729
1730         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1731         (MockWebRTCPeerConnectionHandler::addStream):
1732         (MockWebRTCPeerConnectionHandler::removeStream):
1733
1734 2012-09-11  Peter Beverloo  <peter@chromium.org>
1735
1736         Recognize the "--chromium-android" argument in run-webkit-tests
1737         https://bugs.webkit.org/show_bug.cgi?id=96369
1738
1739         Reviewed by Jochen Eisinger.
1740
1741         Chromium for the Android platform cannot determine the platform based on
1742         the host itself, so we'll use the --chromium-android argument as the build
1743         master passes to run-webkit-tests. Make sure the layout test runner
1744         can pick the right port when doing so.
1745
1746         * Scripts/run-webkit-tests:
1747         * Scripts/webkitpy/layout_tests/port/factory.py:
1748         (port_options):
1749
1750 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1751
1752         [QT] Fix build with newer qmake from Qt 5
1753
1754         Rubber-stamped by Tor Arne Vestbø.
1755
1756         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
1757         it with the use of QT_HOST_DATA/mkspecs.
1758         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
1759
1760         * Scripts/webkitdirs.pm:
1761         (builtDylibPathForName):
1762         (qtMakeCommand):
1763
1764 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1765
1766         [Qt] Remove Qt 4 syncqt, no longer needed
1767
1768         Reviewed by Simon Hausmann.
1769
1770         * qmake/syncqt-4.8: Removed.
1771
1772 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
1773
1774         [Qt][WK2] Fix the build with recent Qt5
1775         https://bugs.webkit.org/show_bug.cgi?id=96283
1776
1777         Reviewed by Simon Hausmann.
1778
1779         We should not use deprecated Qt API because doing that results
1780         in build failure since all the deprecated API was disabled
1781         in qtbase (https://codereview.qt-project.org/#change,24890).
1782
1783         * DumpRenderTree/qt/main.cpp:
1784         (main):
1785         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1786         (MiniBrowserApplication::notify):
1787         * MiniBrowser/qt/raw/View.cpp:
1788         (View::exposeEvent):
1789         (main):
1790
1791 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1792
1793         WTR needs an implementation of applicationCacheDiskUsageForOrigin
1794         https://bugs.webkit.org/show_bug.cgi?id=87188
1795
1796         Reviewed by Kenneth Rohde Christiansen.
1797
1798         Add implementation for applicationCacheDiskUsageForOrigin()
1799         in WebKitTestRunner.
1800
1801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1804         (WTR):
1805         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1806         (TestRunner):
1807
1808 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
1809
1810         Properly expose <legend> elements to ATs
1811         https://bugs.webkit.org/show_bug.cgi?id=84137
1812
1813         Reviewed by Chris Fleizach.
1814
1815         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1816         the expected platform role, ATK_ROLE_LABEL. Also established the needed
1817         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1818
1819         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1820         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
1821
1822 2012-09-10  Jer Noble  <jer.noble@apple.com>
1823
1824         Unreviewed; rolling out r128081.
1825         http://trac.webkit.org/changeset/128081
1826         https://bugs.webkit.org/show_bug.cgi?id=96134
1827
1828         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
1829
1830         * DumpRenderTree/TestRunner.cpp:
1831         (TestRunner::TestRunner):
1832         (TestRunner::staticFunctions):
1833         * DumpRenderTree/TestRunner.h:
1834         (TestRunner):
1835         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1836         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1838         (WTR::InjectedBundlePage::InjectedBundlePage):
1839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1840         (InjectedBundlePage):
1841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1842         (WTR::TestRunner::TestRunner):
1843         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1844         (TestRunner):
1845
1846 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1847
1848         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
1849         https://bugs.webkit.org/show_bug.cgi?id=96205
1850
1851         Reviewed by Tony Chang.
1852
1853         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
1854         internally, which means that it would support only 1 TestExpectations file per port. This
1855         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
1856         and efl-wk1 -> efl).
1857
1858         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
1859         instead so that all the ports TestExpectations are recognized. The ports are also
1860         constructed twice, with "webkit_test_runner" option set to True and False so that we
1861         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
1862
1863         * Scripts/webkitpy/style/checkers/test_expectations.py:
1864         (TestExpectationsChecker._determine_port_from_expectations_path):
1865         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
1866         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1867
1868 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
1869
1870         [WTR] Generated source files should include config.h
1871         https://bugs.webkit.org/show_bug.cgi?id=96254
1872
1873         Reviewed by Benjamin Poulain.
1874
1875         Current coding style has encouraged to include config.h at the first position,
1876         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
1877         this rule.
1878         Therefore, this patch added it.
1879
1880         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1881         (_generateImplementationFile):
1882
1883 2012-09-10  Rick Byers  <rbyers@chromium.org>
1884
1885         Add handling of new GestureTapCancel in DRT
1886         
1887         https://bugs.webkit.org/show_bug.cgi?id=96183
1888
1889         Reviewed by Adam Barth.
1890
1891         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1892         (TestWebPlugin::handleInputEvent):
1893
1894 2012-09-10  Brady Eidson  <beidson@apple.com>
1895
1896         Javascript in foreground tabs should not wait synchronously for plug-ins to load
1897         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
1898
1899         Reviewed by Geoff Garen.
1900
1901         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
1902
1903         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
1904         (PluginObject):
1905         (SlowNPPNew::PluginObject::PluginObject):
1906         (SlowNPPNew::PluginObject::~PluginObject):
1907         (SlowNPPNew::PluginObject::hasProperty):
1908         (SlowNPPNew::PluginObject::getProperty):
1909         (SlowNPPNew::NPP_GetValue):
1910         (SlowNPPNew):
1911
1912 2012-09-10  Tim Horton  <timothy_horton@apple.com>
1913
1914         WKTR often reports an unresponsive WebProcess on Mac bots
1915         https://bugs.webkit.org/show_bug.cgi?id=95906
1916
1917         Reviewed by Dan Bernstein.
1918
1919         Attempt to work around resource contention issues by increasing the NRWT
1920         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
1921
1922         * Scripts/webkitpy/layout_tests/port/base.py:
1923         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
1926
1927 2012-09-07  Jer Noble  <jer.noble@apple.com>
1928
1929         <audio> and <video> should send Do Not Track when appropriate
1930         https://bugs.webkit.org/show_bug.cgi?id=96134
1931
1932         Reviewed by Eric Carlson.
1933
1934         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
1935         WTR. Add FrameLoaderClient client methods for retrieving that value.
1936
1937         * DumpRenderTree/TestRunner.cpp:
1938         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
1939         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
1940         * DumpRenderTree/TestRunner.h:
1941         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
1942         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1943         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1944         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
1945             Pass the question on to the TestRunner.
1946         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1947         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1948         (WTR::InjectedBundlePage::InjectedBundlePage):
1949             Add the setShouldSendDoNotTrackHTTPHeader client function.
1950         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
1951             Pass the question on to the TestRunner.
1952         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1953         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1954         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1955         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
1956         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
1957
1958 2012-09-10  Ojan Vafai  <ojan@chromium.org>
1959
1960         Make EFL bots work on the flakiness dashboard
1961         https://bugs.webkit.org/show_bug.cgi?id=96164
1962
1963         Reviewed by Tony Chang.
1964
1965         Also, update outdated unittests that had started failing.
1966
1967         * TestResultServer/static-dashboards/builders.js:
1968         (isWebkitTestRunner):
1969         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1970         (nonChromiumPlatform):
1971         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1972         (test):
1973
1974 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
1975
1976         [chromium] MediaStream API: Remove the Descriptor postfix
1977         https://bugs.webkit.org/show_bug.cgi?id=96268
1978
1979         Reviewed by Adam Barth.
1980
1981         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
1982         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
1983
1984         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1985         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1986         (MockWebRTCPeerConnectionHandler::createOffer):
1987         (MockWebRTCPeerConnectionHandler::createAnswer):
1988         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1989         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1990         (MockWebRTCPeerConnectionHandler::localDescription):
1991         (MockWebRTCPeerConnectionHandler::remoteDescription):
1992         (MockWebRTCPeerConnectionHandler::addICECandidate):
1993         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1994         (MockWebRTCPeerConnectionHandler):
1995
1996 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1997
1998         [Gtk] failure to build jhbuild dependencies with cups 1.6
1999         https://bugs.webkit.org/show_bug.cgi?id=95991
2000
2001         Reviewed by Gustavo Noronha Silva.
2002
2003         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2004         building with cups >= 1.6 [GNOME #670373].
2005
2006         * gtk/jhbuild.modules:
2007
2008 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2009
2010         [EFL][DRT] Encoding issue in printed console messages
2011         https://bugs.webkit.org/show_bug.cgi?id=96263
2012
2013         Reviewed by Kenneth Rohde Christiansen.
2014
2015         Correctly handle CONSOLE messages that contain non-ascii
2016         characters in EFL's DRT. We need to use String::fromUTF8()
2017         to construct a WTF::String from a raw string.
2018
2019         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2020         (onConsoleMessage):
2021
2022 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2023
2024         [WK2][WTR] User style sheet location should be reset before each test
2025         https://bugs.webkit.org/show_bug.cgi?id=96262
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         User style sheet location is reset before each test now.
2030
2031         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2032         (WTR::InjectedBundle::beginTesting):
2033
2034 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2035
2036         Fix build of WTR with Qt on Windows
2037         https://bugs.webkit.org/show_bug.cgi?id=96249
2038
2039         Reviewed by Kenneth Rohde Christiansen.
2040
2041         Windows loves to define min and max as macros, which beautifully
2042         clashes in many places where min and max are used as variable or method
2043         names. It can be convinced not to do this when min and max are already
2044         define as macros (expanding to themselves). We have this kind of
2045         workaround in config.h files all over WebKit and as it turns out when
2046         building WTR with Qt on Windows we do end up with such a clash. Therefore
2047         we need the same workaround.
2048
2049         * WebKitTestRunner/config.h:
2050
2051 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2052
2053         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2054         https://bugs.webkit.org/show_bug.cgi?id=95936
2055
2056         Reviewed by Kenneth Rohde Christiansen.
2057
2058         Enable interactive form validation setting in WebKitTestRunner as
2059         we are currently doing in DumpRenderTree. This is needed for some
2060         tests to pass.
2061
2062         * WebKitTestRunner/TestController.cpp:
2063         (WTR::TestController::resetStateToConsistentValues):
2064
2065 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2066
2067         Clean up the code in XvfbDriver
2068         https://bugs.webkit.org/show_bug.cgi?id=96202
2069
2070         Reviewed by Philippe Normand.
2071
2072         Changes:
2073         - Remove unneeded imports,
2074         - assign the _lock_file member variable when the display number is determined,
2075         - no need for parentheses around a single string format argument,
2076         - use FileSystem.exists method when checking if lock file is present as it
2077         makes the intention much more clearer.
2078
2079         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2080         (XvfbDriver._start):
2081         (XvfbDriver.stop):
2082
2083 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2084
2085         Make the String initialization on the function side of String::number()
2086         https://bugs.webkit.org/show_bug.cgi?id=95940
2087
2088         Reviewed by Benjamin Poulain.
2089
2090         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2091         (testBoundaries):
2092         (testNumbers):
2093
2094 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2095
2096         [WK2] expose element rect for color input type
2097         https://bugs.webkit.org/show_bug.cgi?id=91664
2098
2099         Reviewed by Simon Hausmann.
2100
2101         Update the QML logic in MiniBrowser to take advantage of this.
2102         The picker size is now hardcoded and we try to place it below the
2103         input element if possible.
2104
2105         * MiniBrowser/qt/qml/ColorChooser.qml:
2106
2107 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2108
2109         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2110         https://bugs.webkit.org/show_bug.cgi?id=95329
2111
2112         Reviewed by Kenneth Rohde Christiansen.
2113
2114         Explicitely disable TabToLinks setting in WebKitTestRunner.
2115         Tests override the "WebKitTabToLinksPreferenceKey" preference
2116         to enable it.
2117
2118         * WebKitTestRunner/TestController.cpp:
2119         (WTR::TestController::resetStateToConsistentValues):
2120
2121 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2122
2123         webkit.py gdb pretty printer can't print CString
2124         https://bugs.webkit.org/show_bug.cgi?id=96068
2125
2126         Reviewed by Tony Chang.
2127
2128         Update WTFCStringPrinter to follow r126191.
2129
2130         * gdb/webkit.py:
2131         (WTFCStringPrinter.to_string):
2132
2133 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2134
2135         Rename the ustring() accessor to string()
2136         https://bugs.webkit.org/show_bug.cgi?id=95919
2137
2138         Reviewed by Geoffrey Garen.
2139
2140         Update EFL's DRT.
2141
2142         Fix some string conversion that have been made useless
2143         with recent changes.
2144
2145         * DumpRenderTree/efl/EventSender.cpp:
2146         (keyPadNameFromJSValue):
2147         (keyNameFromJSValue):
2148         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2149         (TestRunner::queueLoad):
2150         (TestRunner::addOriginAccessWhitelistEntry):
2151         (TestRunner::removeOriginAccessWhitelistEntry):
2152         (TestRunner::setUserStyleSheetLocation):
2153         (TestRunner::setValueForUser):
2154         (TestRunner::elementDoesAutoCompleteForElementWithId):
2155         (TestRunner::execCommand):
2156         (TestRunner::findString):
2157         (TestRunner::isCommandEnabled):
2158         (TestRunner::clearApplicationCacheForOrigin):
2159         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2160         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2161         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2162         (toInt):
2163         (TestRunner::overridePreference):
2164         (TestRunner::addUserScript):
2165         (TestRunner::addUserStyleSheet):
2166         (TestRunner::evaluateInWebInspector):
2167         (TestRunner::evaluateScriptInIsolatedWorld):
2168         (TestRunner::setTextDirection):
2169         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2170         (LoadItem::invoke):
2171         (LoadHTMLStringItem::invoke):
2172         (ScriptItem::invoke):
2173
2174 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2175
2176         Extend third-party storage blocking API to optionally allow blocking all storage
2177         https://bugs.webkit.org/show_bug.cgi?id=95915
2178
2179         Reviewed by Brady Eidson.
2180
2181         Modified API test to use new revised API.
2182
2183         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2184         (TestWebKitAPI::TEST):
2185
2186 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2187
2188         AX: WebCore accessibility roles should be cross-platform
2189         https://bugs.webkit.org/show_bug.cgi?id=94870
2190
2191         Reviewed by Chris Fleizach.
2192
2193         Add debug strings to Chromium for new accessibility roles.
2194
2195         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2196         (roleToString):
2197
2198 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2199
2200         AX: Chromium needs access to canvasHasFallbackContent
2201         https://bugs.webkit.org/show_bug.cgi?id=96124
2202
2203         Reviewed by Chris Fleizach.
2204
2205         Distinguish between canvas roles with and without fallback
2206         content on Chromium.
2207
2208         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2209         (getRole):
2210
2211 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2212
2213         Handle non-existant TestExpectations files gracefully
2214         https://bugs.webkit.org/show_bug.cgi?id=96149
2215
2216         Reviewed by Eric Seidel.
2217
2218         Even when we get rid of Skipped files, we shouldn't have each port
2219         require a TestExpectations file for each platform if it doesn't
2220         need one.
2221
2222         * Scripts/webkitpy/layout_tests/port/base.py:
2223         (Port.expectations_dict):
2224         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2225         (PortTest.test_nonexistant_expectations):
2226
2227 2012-09-07  Tony Chang  <tony@chromium.org>
2228
2229         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2230         https://bugs.webkit.org/show_bug.cgi?id=96136
2231
2232         Reviewed by Ojan Vafai.
2233
2234         When we renamed the file to TestExpectations, it was no longer considered a text file so
2235         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2236         from the port object, so I've removed that from the check. I'm not sure what it was
2237         supposed to do.
2238
2239         * Scripts/webkitpy/style/checker.py:
2240         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2241         * Scripts/webkitpy/style/checkers/test_expectations.py:
2242         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2243         (TestExpectationsChecker.check): Remove overrides param.
2244         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2245         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2246
2247 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2248
2249         [EFL] Use same default minimum logical font size in DRT and WTR
2250         https://bugs.webkit.org/show_bug.cgi?id=96116
2251
2252         Reviewed by Martin Robinson.
2253
2254         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2255         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2256         logical font size to 9 to match the value used in WTR.
2257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2258         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2259         logical font size to 9 (default value in WK2)
2260
2261 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2262
2263         MediaStream API: add RTCPeerConnection::createAnswer
2264         https://bugs.webkit.org/show_bug.cgi?id=96092
2265
2266         Reviewed by Adam Barth.
2267
2268         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2269
2270         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2271         (MockWebRTCPeerConnectionHandler::createOffer):
2272         (MockWebRTCPeerConnectionHandler::createAnswer):
2273         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2274         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2275         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2276         (MockWebRTCPeerConnectionHandler):
2277
2278 2012-09-07  Dean Jackson  <dino@apple.com>
2279
2280         Unreviewed changes to watchlist.
2281
2282         - Add new WebGL and Filters definitions
2283         - Add myself to OpenGL bugs
2284
2285         * Scripts/webkitpy/common/config/watchlist:
2286
2287 2012-09-07  Peter Beverloo  <peter@chromium.org>
2288
2289         Actually trigger the Android Tester
2290         https://bugs.webkit.org/show_bug.cgi?id=96118
2291
2292         Reviewed by Adam Barth.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/config.json:
2295
2296 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2297
2298         New time input needs accessibility
2299         https://bugs.webkit.org/show_bug.cgi?id=96032
2300
2301         Reviewed by Chris Fleizach.
2302
2303         Add support for valueDescription for testing.
2304
2305         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2306         (getValueDescription):
2307         (AccessibilityUIElement::AccessibilityUIElement):
2308         (AccessibilityUIElement::valueDescriptionGetterCallback):
2309         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2310         (AccessibilityUIElement):
2311
2312 2012-09-07  Peter Beverloo  <peter@chromium.org>
2313
2314         Add the google-android-tests build slave to the master's config
2315         https://bugs.webkit.org/show_bug.cgi?id=96113
2316
2317         Reviewed by Csaba Osztrogonác.
2318
2319         * BuildSlaveSupport/build.webkit.org-config/config.json:
2320
2321 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2322
2323         [WK2] [EFL] Set theme for WebKit2 API test runner
2324         https://bugs.webkit.org/show_bug.cgi?id=96100
2325
2326         Reviewed by Kenneth Rohde Christiansen.
2327
2328         Set the theme generated by the build for the WebKit2 API test runner.
2329
2330         * TestWebKitAPI/PlatformEfl.cmake:
2331         * TestWebKitAPI/efl/PlatformWebView.cpp:
2332         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2333
2334 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2335
2336         Unreviewed. Add Gábor Ballabás as contributor.
2337
2338         * Scripts/webkitpy/common/config/committers.py:
2339
2340 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2341
2342         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2343         https://bugs.webkit.org/show_bug.cgi?id=96078
2344
2345         Reviewed by Tor Arne Vestbø.
2346
2347         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2348
2349         * qmake/mkspecs/features/default_pre.prf:
2350
2351 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2352
2353         [EFL] Add TestExpectations file for efl-wk1
2354         https://bugs.webkit.org/show_bug.cgi?id=96019
2355
2356         Reviewed by Gyuyoung Kim.
2357
2358         Update TestExpectations cascading for EFL port
2359         so that we use efl-wk1 -> efl search paths
2360         for WebKit1 EFL.
2361
2362         * Scripts/webkitpy/layout_tests/port/efl.py:
2363         (EflPort._search_paths):
2364
2365 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2366
2367         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2368         https://bugs.webkit.org/show_bug.cgi?id=95097
2369
2370         Reviewed by Dirk Pranke.
2371
2372         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2373         terminating the process does not always work as expected, leading to timeouts
2374         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2375         as it's not removed by the killed Xvfb process.
2376
2377         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2378         is tested in different circumstances - whether pixel tests are enabled or not,
2379         with an arbitrary worker number or with an Xorg process already running on the system.
2380         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2381         and then set to None.
2382
2383         * BuildSlaveSupport/kill-old-processes:
2384         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2385         is left running, potentially clogging up a display at a certain position.
2386         * Scripts/webkitpy/common/system/executive_mock.py:
2387         (MockExecutive.__init__):
2388         The _running_pids is now a dictionary with process names as keys and pids
2389         as values.
2390         (MockExecutive.check_running_pid):
2391         Check whether the passed-in pid is in the _running_pids dictionary's values.
2392         (MockExecutive):
2393         (MockExecutive.running_pids):
2394         This method returns the list of all the process pids of which the name passes
2395         through the process_name_filter.
2396         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2397         Use the Executive object of the port's host to check for running pids and open
2398         new subprocesses or kill them throughout the class.
2399         (XvfbDriver._start):
2400         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2401         start the server process after it's created.
2402         (XvfbDriver.stop):
2403         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2404         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2405         (XvfbDriverTest):
2406         (XvfbDriverTest.make_driver):
2407         (XvfbDriverTest.assertDriverStartSuccessful):
2408         (XvfbDriverTest.test_start_no_pixel_tests):
2409         (XvfbDriverTest.test_start_pixel_tests):
2410         (XvfbDriverTest.test_start_arbitrary_worker_number):
2411         (XvfbDriverTest.test_start_existing_xorg_process):
2412         (XvfbDriverTest.test_stop):
2413         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2414
2415 2012-09-06  Peter Beverloo  <peter@chromium.org>
2416
2417         Introduce the Chromium Android Release (Tests) bot
2418         https://bugs.webkit.org/show_bug.cgi?id=95980
2419
2420         Reviewed by Adam Barth.
2421
2422         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2423         which will be running layout tests on actual Android devices. Right now,
2424         four Galaxy Nexus phones are attached.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/config.json:
2427
2428 2012-09-06  James Robinson  <jamesr@chromium.org>
2429
2430         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2431         https://bugs.webkit.org/show_bug.cgi?id=96007
2432
2433         Reviewed by Adrienne Walker.
2434
2435         Fixes initialization / settings code to use WebCompositorSupport.
2436
2437         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2438         (main):
2439         * DumpRenderTree/chromium/TestShell.cpp:
2440         (TestShell::initialize):
2441         (TestShell::setPerTilePaintingEnabled):
2442
2443 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2444
2445         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2446         https://bugs.webkit.org/show_bug.cgi?id=95995
2447
2448         Reviewed by Kenneth Rohde Christiansen.
2449
2450         Provide proper implementation for PlatformWebView::windowFrame()
2451         in EFL's WebKitTestRunner.
2452
2453         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2454         (WTR::PlatformWebView::windowFrame):
2455
2456 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2457
2458         Fix WTF.Lrint on 32-bit platforms
2459         https://bugs.webkit.org/show_bug.cgi?id=96003
2460
2461         Reviewed by Benjamin Poulain.
2462
2463         Fixed failing WTF.Lrint test on 32-bit platforms.
2464
2465         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2466         (TestWebKitAPI::TEST):
2467
2468 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2469
2470         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2471         https://bugs.webkit.org/show_bug.cgi?id=95839
2472
2473         Reviewed by Adam Barth.
2474
2475         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2476         up the task definitions a bit. There was no need to have them in the header file.
2477
2478         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2479         (RTCSessionDescriptionRequestSuccededTask):
2480         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2481         (RTCSessionDescriptionRequestFailedTask):
2482         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2483         (RTCVoidRequestTask):
2484         (RTCVoidRequestTask::RTCVoidRequestTask):
2485         (MockWebRTCPeerConnectionHandler::createOffer):
2486         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2487         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2488         (MockWebRTCPeerConnectionHandler::localDescription):
2489         (MockWebRTCPeerConnectionHandler::remoteDescription):
2490         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2491         (MockWebRTCPeerConnectionHandler):
2492
2493 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2494
2495         [Qt] Fix build on Mac OS X 10.6
2496         https://bugs.webkit.org/show_bug.cgi?id=95200
2497
2498         Reviewed by Tor Arne Vestbø.
2499
2500         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2501         10.7 and newer.
2502
2503         * qmake/mkspecs/features/features.prf:
2504
2505 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2506
2507         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2508         https://bugs.webkit.org/show_bug.cgi?id=95973
2509
2510         Reviewed by Kenneth Rohde Christiansen.
2511
2512         Correctly map "addSelectionKey" to "Control" modifier
2513         in WKTR's EventSender on other OSes than Mac OS X,
2514         instead of mapping it to the "Meta" modifier.
2515
2516         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2517         (WTR::parseModifier):
2518
2519 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2520
2521         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2522         https://bugs.webkit.org/show_bug.cgi?id=95710
2523
2524         Reviewed by Dirk Pranke.
2525
2526         The stdout / stderr output can be None so make sure
2527         we won't raise an exception in this case.
2528
2529         * Scripts/webkitpy/layout_tests/port/driver.py:
2530         (Driver.run_test):
2531
2532 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2533
2534         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2535         https://bugs.webkit.org/show_bug.cgi?id=95849
2536
2537         Reviewed by Kenneth Rohde Christiansen.
2538
2539         Sanitize URLs passed by the user as program
2540         argument or typed in the URL bar in order to
2541         be more tolerant.
2542
2543         * EWebLauncher/CMakeLists.txt:
2544         * EWebLauncher/main.c:
2545         (main):
2546         * EWebLauncher/url_bar.c:
2547         (_url_bar_url_get_with_protocol):
2548         (on_urlbar_key_down):
2549         * EWebLauncher/url_utils.c: Added.
2550         (has_scheme):
2551         (url_from_user_input): Add utility function to construct a
2552         URL from user input.
2553         * EWebLauncher/url_utils.h: Added.
2554         * MiniBrowser/efl/CMakeLists.txt:
2555         * MiniBrowser/efl/main.c:
2556         (main):
2557
2558 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2559
2560         [Qt] Various small Windows / MSVC build fixes
2561         https://bugs.webkit.org/show_bug.cgi?id=95934
2562
2563         Reviewed by Kenneth Rohde Christiansen.
2564
2565         setFocus takes a boolean as argument: Don't try to implicitly convert
2566         an enum to a boolean, MSVC doesn't like that. The intent here is to
2567         enable focus, so just pass true.
2568
2569         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2570         (WTR::PlatformWebView::focus):
2571
2572 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2573
2574         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2575         https://bugs.webkit.org/show_bug.cgi?id=95965
2576
2577         Reviewed by Tor Arne Vestbø.
2578
2579         Add ANGLE as a static library module to the Qt WebKit build system.
2580
2581         * qmake/mkspecs/features/default_post.prf:
2582         * qmake/mkspecs/modules/angle.prf: Added.
2583
2584 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2585
2586         [WK2] Make [Qt]ViewportHandler cross platform
2587         https://bugs.webkit.org/show_bug.cgi?id=91257
2588
2589         Reviewed by Kenneth Rohde Christiansen.
2590
2591         Remove initial scale from viewport info item since it is
2592         set to -1 after applied thus it does not hold any valuable
2593         information.
2594
2595         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2596
2597 2012-09-05  Tony Chang  <tony@chromium.org>
2598
2599         [chromium] Remove dependency on webkit_user_agent
2600         https://bugs.webkit.org/show_bug.cgi?id=95886
2601
2602         Reviewed by Adam Barth.
2603
2604         The code isn't used by DumpRenderTree.
2605
2606         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2607
2608 2012-09-05  Rick Byers  <rbyers@chromium.org>
2609
2610         Update chromium DumpRenderTree for new WebGestureEvent fields
2611         https://bugs.webkit.org/show_bug.cgi?id=95573
2612
2613         Reviewed by James Robinson.
2614
2615         Update EventSender to write gesture details into the appropriate
2616         type-specific WebGestureEvent fields.
2617         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2618         (EventSender::gestureEvent):
2619         (EventSender::gestureFlingStart):
2620
2621 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2622
2623         NRWT lies about the number of tests that it's skipping when used with --repeat-each
2624         https://bugs.webkit.org/show_bug.cgi?id=95789
2625
2626         Reviewed by Ojan Vafai.
2627
2628         Fix miscalculation in log message.
2629
2630         * Scripts/webkitpy/layout_tests/views/printing.py:
2631         (Printer.print_found):
2632
2633 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
2634
2635         Unreviewed, rolling out r127612, r127660, and r127664.
2636         http://trac.webkit.org/changeset/127612
2637         http://trac.webkit.org/changeset/127660
2638         http://trac.webkit.org/changeset/127664
2639         https://bugs.webkit.org/show_bug.cgi?id=95920
2640
2641         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2642         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2643         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2644         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2645         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2646         (MockWebRTCPeerConnectionHandler::createOffer):
2647         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2648         (MockWebRTCPeerConnectionHandler):
2649         (SuccessCallbackTask):
2650         (FailureCallbackTask):
2651
2652 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2653
2654         Ignore-metrics includes scroll offsets.
2655         https://bugs.webkit.org/show_bug.cgi?id=95845
2656
2657         Reviewed by Dirk Pranke.
2658
2659         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
2660
2661         * Scripts/old-run-webkit-tests:
2662         (stripMetrics):
2663         * Scripts/webkitpy/layout_tests/port/driver.py:
2664         (DriverOutput):
2665
2666 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
2667
2668         Unreviewed test fix.
2669
2670         Including a plugin source file into the build that was added in r127595.
2671
2672         * GNUmakefile.am:
2673
2674 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
2675
2676         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2677         https://bugs.webkit.org/show_bug.cgi?id=95839
2678
2679         Reviewed by Adam Barth.
2680
2681         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2682         up the task definitions a bit. There was no need to have them in the header file.
2683
2684         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2685         (RTCSessionDescriptionRequestSuccededTask):
2686         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2687         (RTCSessionDescriptionRequestFailedTask):
2688         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2689         (RTCVoidRequestTask):
2690         (RTCVoidRequestTask::RTCVoidRequestTask):
2691         (MockWebRTCPeerConnectionHandler::createOffer):
2692         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2693         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2694         (MockWebRTCPeerConnectionHandler::localDescription):
2695         (MockWebRTCPeerConnectionHandler::remoteDescription):
2696         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2697         (MockWebRTCPeerConnectionHandler):
2698
2699 2012-09-05  Kangil Han  <kangil.han@samsung.com>
2700
2701         [EFL] Remove '+=' usage in String
2702         https://bugs.webkit.org/show_bug.cgi?id=95808
2703
2704         Reviewed by Benjamin Poulain.
2705
2706         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
2707
2708         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2709         (descriptionSuitableForTestResult):
2710
2711 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2712
2713         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
2714         https://bugs.webkit.org/show_bug.cgi?id=95842
2715
2716         Reviewed by Kenneth Rohde Christiansen.
2717
2718         Provide proper implementation for TestRunner::pathToLocalResource()
2719         in EFL WKTR, identical to the one for DumpRenderTree.
2720
2721         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
2722         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
2723         are found my WebKitTestRunner.
2724
2725         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2726         (WTR::TestRunner::pathToLocalResource):
2727
2728 2012-09-05  Brady Eidson  <beidson@apple.com>
2729
2730         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
2731         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
2732
2733         Reviewed by Andy Estes.
2734
2735         Add a plug-in that always fails to initialize:
2736         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
2737         (NPPNewFails):
2738         (NPPNewFails::NPPNewFails):
2739         (NPPNewFails::NPP_New):
2740
2741         Add it to all the project files:
2742         * DumpRenderTree/DumpRenderTree.gypi:
2743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2744         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2745         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2746         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2747
2748 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2749
2750         [Qt] Fix makefile race condition between derived sources and target
2751
2752         r121966 removed too much of the old qmake logic, including the rule
2753         that ensured that qmake_all would not trigger dual runs of qmake --
2754         one of the derived sources -qmake-all rule, and one for making the
2755         derived sources.
2756
2757         We now follow a similar pattern as before, by introducing a custom
2758         target that explicitly depends on the derived sources' qmake-all before
2759         doing a manual run of make. That ensures a single qmake run for the derived
2760         sources.
2761
2762         https://bugs.webkit.org/show_bug.cgi?id=93847
2763
2764         Reviewed by Csaba Osztrogonác.
2765
2766         * qmake/mkspecs/features/functions.prf:
2767
2768 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
2769
2770         WKTR doesn't implement dumpWillCacheResponse()
2771         https://bugs.webkit.org/show_bug.cgi?id=94607
2772
2773         Reviewed by Kenneth Rohde Christiansen.
2774
2775         Define shouldCacheResponse() callback in resource
2776         load client and provide implementation for
2777         dumpWillCacheResponse() in WebKitTestRunner.
2778
2779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2780         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2781         (WTR::InjectedBundlePage::InjectedBundlePage):
2782         (WTR::InjectedBundlePage::shouldCacheResponse):
2783         (WTR):
2784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2785         (InjectedBundlePage):
2786         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2787         (WTR::TestRunner::TestRunner):
2788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2789         (WTR::TestRunner::dumpWillCacheResponse):
2790         (WTR::TestRunner::shouldDumpWillCacheResponse):
2791         (TestRunner):
2792
2793 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2794
2795         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2796         https://bugs.webkit.org/show_bug.cgi?id=92735
2797
2798         Reviewed by Hajime Morita.
2799
2800         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2801
2802         * DumpRenderTree/TestRunner.cpp:
2803         (TestRunner::staticFunctions):
2804         * DumpRenderTree/TestRunner.h:
2805         (TestRunner):
2806         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2807         (TestRunner::addUserStyleSheet):
2808         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2809         (DRTTestRunner::DRTTestRunner):
2810         (DRTTestRunner::hasCustomPageSizeStyle):
2811         * DumpRenderTree/chromium/DRTTestRunner.h:
2812         (DRTTestRunner):
2813         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2814         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2815         * DumpRenderTree/mac/TestRunnerMac.mm:
2816         * DumpRenderTree/qt/TestRunnerQt.cpp:
2817         (TestRunner::evaluateScriptInIsolatedWorld):
2818         * DumpRenderTree/qt/TestRunnerQt.h:
2819         (TestRunner):
2820         * DumpRenderTree/win/TestRunnerWin.cpp:
2821         * DumpRenderTree/wx/TestRunnerWx.cpp:
2822         (TestRunner::abortModal):
2823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2825         (WTR):
2826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2827         (TestRunner):
2828
2829 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2830
2831         [Qt] Automate the use of AllInOne files in the Qt build
2832         https://bugs.webkit.org/show_bug.cgi?id=95837
2833
2834         Reviewed by Tor Arne Vestbø.
2835
2836         New feature file that implements the all-in-one file automation by
2837         adding the requested all-in-one files to SOURCES and removing the files
2838         it includes from SOURCES.
2839
2840         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
2841
2842 2012-09-04  Tim Horton  <timothy_horton@apple.com>
2843
2844         Have NRWT log more output when crash logs are missing
2845         https://bugs.webkit.org/show_bug.cgi?id=95814
2846
2847         Reviewed by Dan Bernstein.
2848
2849         Log the stderr and stdout of the test, in order to provide slightly more
2850         context when the WebProcess times out while running tests.
2851
2852         * Scripts/webkitpy/layout_tests/port/driver.py:
2853         (Driver.run_test):
2854
2855 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2856
2857         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
2858         https://bugs.webkit.org/show_bug.cgi?id=95770
2859
2860         Reviewed by Adam Barth.
2861
2862         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2863         (ChromiumAndroidDriver.__init__):
2864         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
2865         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
2866         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
2867         (ChromiumAndroidDriver._push_executable):
2868         (ChromiumAndroidDriver._push_fonts):
2869         (ChromiumAndroidDriver._push_test_resources):
2870         (ChromiumAndroidDriver._run_adb_command):
2871         (ChromiumAndroidDriver._get_last_stacktrace):
2872         (ChromiumAndroidDriver._get_crash_log):
2873         (ChromiumAndroidDriver._start):
2874         (ChromiumAndroidDriver._start_once):
2875         (ChromiumAndroidDriver._start_once.deadlock_detector):
2876         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2877         (ChromiumAndroidDriverTest.test_get_crash_log):
2878
2879 2012-09-04  Satish Sampath  <satish@chromium.org>
2880
2881         Run git commands within the checkout directory
2882         https://bugs.webkit.org/show_bug.cgi?id=95742
2883
2884         Reviewed by Eric Seidel.
2885
2886         git commands run from scm/git.py are sometimes run with cwd set to the
2887         checkout_root and other times with whatever directory was the default cwd.
2888         Instead all these should run with the checkout root set as the cwd
2889         (except where we explicitly need a different path)
2890
2891         * Scripts/webkitpy/common/checkout/scm/git.py:
2892         (Git._run_git):
2893         (Git.find_checkout_root):
2894         (Git.discard_local_commits):
2895         (Git.local_commits):
2896         (Git.working_directory_is_clean):
2897         (Git.clean_working_directory):
2898         (Git.add_list):
2899         (Git.delete_list):
2900         (Git.exists):
2901         (Git._current_branch):
2902         (Git._changes_files_for_commit):
2903         (Git.revisions_changing_file):
2904         (Git.svn_revision):
2905         (Git._run_git_svn_find_rev):
2906         (Git.contents_at_revision):
2907         (Git.diff_for_file):
2908         (Git.show_head):
2909         (Git.committer_email_for_revision):
2910         (Git.apply_reverse_diff):
2911         (Git.revert_files):
2912         (Git.commit_with_message):
2913         (Git._commit_on_branch):
2914         (Git.svn_commit_log):
2915         (Git.last_svn_commit_log):
2916         (Git.svn_blame):
2917         (Git._branch_ref_exists):
2918         (Git.delete_branch):
2919         (Git.remote_merge_base):
2920         (Git.commit_locally_with_message):
2921         (Git.push_local_commits_to_server):
2922         (Git.commit_ids_from_commitish_arguments):
2923         (Git.commit_message_for_local_commit):
2924         (Git.files_changed_summary_for_commit):
2925
2926 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2927
2928         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
2929         https://bugs.webkit.org/show_bug.cgi?id=95734
2930
2931         Reviewed by Adam Barth.
2932
2933         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2934         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
2935         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
2936         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
2937         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
2938         (MockWebRTCPeerConnectionHandler::createOffer):
2939         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2940         (MockWebRTCPeerConnectionHandler):
2941         (MockWebRTCPeerConnectionHandler::taskList):
2942         (SuccessCallbackTask):
2943         (FailureCallbackTask):
2944
2945 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
2946
2947         [Chromium-Android] Output time and thread info in crash log
2948         https://bugs.webkit.org/show_bug.cgi?id=95768
2949
2950         Reviewed by Adam Barth.
2951
2952         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2953         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
2954
2955 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
2956
2957         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
2958         https://bugs.webkit.org/show_bug.cgi?id=95721
2959
2960         Reviewed by Adam Barth.
2961
2962         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2963         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
2964         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
2965         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2966         (MockWebMediaStreamCenter):
2967
2968 2012-09-04  Tony Chang  <tony@chromium.org>
2969
2970         Elide test names when running new-run-webkit-tests
2971         https://bugs.webkit.org/show_bug.cgi?id=95626
2972
2973         Reviewed by Dirk Pranke.
2974
2975         When the test name exceeds the number of terminal columns, it leaves
2976         text on the screen. Avoid this by eliding the test name when running
2977         tests. This is similar to what ninja does when compiling.
2978
2979         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2980         (MeteredStream):
2981         (MeteredStream.number_of_columns): Helper method to get number of
2982         terminal columns. Won't work on Win32 python, but meh.
2983         * Scripts/webkitpy/layout_tests/views/printing.py:
2984         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
2985         because stderr appears to be ascii only.
2986         (Printer.print_started_test): Route through _test_status_line.
2987         (Printer.print_finished_test): Route through _test_status_line.
2988         (Printer._print_test_trace): Route through _test_status_line.
2989         (Printer._print_baseline): Route through _test_status_line.
2990         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2991         (test_test_status_line): Test for _test_status_line.
2992
2993 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
2994
2995         [GTK] Print API missing documentation when generating gtkdoc
2996         https://bugs.webkit.org/show_bug.cgi?id=95703
2997
2998         Reviewed by Carlos Garcia Campos.
2999
3000         Print out API missing documentation when generating gtkdoc. This makes it
3001         easier to fix documentation errors.
3002
3003         * gtk/generate-gtkdoc:
3004         (print_missing_api): Added.
3005         (generate_doc): Inline the rebase step, since it now reports an error
3006         when you try to rebase without generating documentation first.
3007         * gtk/gtkdoc.py:
3008         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3009         generating documentation first to enable a small cleanup at the caller.
3010         (GTKDoc.api_missing_documentation): Added.
3011
3012 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3013
3014         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3015         https://bugs.webkit.org/show_bug.cgi?id=95628
3016
3017         Reviewed by James Robinson.
3018
3019         Future tests need the ability to respond asynchronously that
3020         pointer lock requests have been accepted or rejected. This patch
3021         adds the following:
3022             testRunner.setPointerLockWillRespondAsynchronously();
3023             testRunner.didAcquirePointerLock();
3024             testRunner.didNotAcquirePointerLock();
3025
3026         Tested in existing test:
3027             pointerlockchange-pointerlockerror-events.html
3028
3029         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3030         (DRTTestRunner::DRTTestRunner):
3031         (DRTTestRunner::didAcquirePointerLock):
3032         (DRTTestRunner::didNotAcquirePointerLock):
3033         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3034         * DumpRenderTree/chromium/DRTTestRunner.h:
3035         (DRTTestRunner):
3036         * DumpRenderTree/chromium/WebViewHost.cpp:
3037         (WebViewHost::requestPointerLock):
3038         (WebViewHost::didAcquirePointerLock):
3039         (WebViewHost::didNotAcquirePointerLock):
3040         * DumpRenderTree/chromium/WebViewHost.h:
3041         (WebViewHost):
3042         (WebViewHost::setPointerLockWillRespondAsynchronously):
3043
3044 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3045
3046         Move content shell bots to their own builder group
3047         https://bugs.webkit.org/show_bug.cgi?id=95765
3048
3049         Reviewed by Adam Barth.
3050
3051         In their current state of instability, they add too much noise. Once they get more stable,
3052         we can add them back to the regular group or just have them replace the other bots.
3053
3054         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3055
3056         * TestResultServer/static-dashboards/builders.js:
3057         (isWebkitTestRunner):
3058         (isChromiumContentShellTestRunner):
3059         (isChromiumWebkitTipOfTreeTestRunner):
3060         (loadBuildersList):
3061
3062 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3063
3064         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3065         https://bugs.webkit.org/show_bug.cgi?id=95689
3066
3067         Reviewed by Kenneth Rohde Christiansen.
3068
3069         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3070         So, there are bugs that key events are always generated in url bar although
3071         the user clicked the web view.
3072
3073         This patch recovers the focus of the web view when left button is pressed and
3074         adds for MiniBrowser to toggle the focus when middle button is pressed
3075         like EWebLauncher already did.
3076
3077         * EWebLauncher/main.c:
3078         (on_mouse_down):
3079         * MiniBrowser/efl/main.c:
3080         (on_mouse_down):
3081         (browserCreate):
3082
3083 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3084
3085         Added ANDROID_GDBSERVER definition for Ant
3086         https://bugs.webkit.org/show_bug.cgi?id=95265
3087
3088         Reviewed by Adam Barth.
3089
3090         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3091         is only used for finding the gdbserver.
3092
3093         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3094         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3095
3096 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3097
3098         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3099         https://bugs.webkit.org/show_bug.cgi?id=95565
3100
3101         Reviewed by Adam Barth.
3102
3103         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3104         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3105         (MockWebRTCPeerConnectionHandler::updateICE):
3106         (MockWebRTCPeerConnectionHandler::addICECandidate):
3107         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3108         (MockWebRTCPeerConnectionHandler):
3109
3110 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3111
3112         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3113         https://bugs.webkit.org/show_bug.cgi?id=95670
3114
3115         Reviewed by Kenneth Rohde Christiansen.
3116
3117         Fix layout issues related to the URL bar in Minibrowser
3118         and EWebLauncher when the window is resized.
3119
3120         The URL bar was not resized accordingly and the Web
3121         page was moved behing the URL bar, hiding part of it.
3122
3123         * EWebLauncher/main.c:
3124         (on_ecore_evas_resize):
3125         (closeWindow):
3126         * EWebLauncher/url_bar.c:
3127         (url_bar_width_set):
3128         (url_bar_add):
3129         * EWebLauncher/url_bar.h:
3130         * MiniBrowser/efl/main.c:
3131         (on_ecore_evas_resize):
3132         (main):
3133
3134 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3135
3136         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3137         https://bugs.webkit.org/show_bug.cgi?id=95605
3138
3139         Reviewed by Dirk Pranke.
3140
3141         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3142
3143         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3144         (ChromiumAndroidPort.check_sys_deps):
3145         (ChromiumAndroidPort.expectations_files):
3146         (ChromiumAndroidPort.clean_up_test_run):
3147
3148 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3149
3150         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3151         https://bugs.webkit.org/show_bug.cgi?id=95180
3152
3153         Reviewed by Chris Fleizach.
3154
3155         The bug that was fixed stood in the way of fully implementing stringValue().
3156         Testing that the bug is fixed requires stringValue() to be fully implemented
3157         and object replacement characters to be printable.
3158
3159         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3160         (replaceCharactersForResults): New method which turns object replacement
3161         characters into "<obj>" so that the characters can be properly shown in
3162         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3163         accessible text of a single object in the accessible tree doesn't mess up
3164         the readibility of the results.
3165         (AccessibilityUIElement::stringValue): Remove the code that immediately
3166         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3167         replaceCharactersForResults() prior to returning the accessible string
3168         value.
3169
3170 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3171
3172         MediaStream API: Add MediaStream management to RTCPeerConnection
3173         https://bugs.webkit.org/show_bug.cgi?id=95543
3174
3175         Reviewed by Adam Barth.
3176
3177         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3178
3179         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3180         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3181         (MockWebRTCPeerConnectionHandler::addStream):
3182         (MockWebRTCPeerConnectionHandler::removeStream):
3183         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3184         (MockWebRTCPeerConnectionHandler):
3185
3186 2012-08-31  Tony Chang  <tony@chromium.org>
3187
3188         Remove ENABLE_CSS3_FLEXBOX compile time flag
3189         https://bugs.webkit.org/show_bug.cgi?id=95382
3190
3191         Reviewed by Ojan Vafai.
3192
3193         Everyone is already enabling this by default and the spec has stablized.
3194
3195         * Scripts/webkitperl/FeatureList.pm:
3196         * qmake/mkspecs/features/features.pri:
3197
3198 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3199
3200         objc_msgSend and IMP should be cast appropriately before using
3201         https://bugs.webkit.org/show_bug.cgi?id=95242
3202
3203         Reviewed by Benjamin Poulain.
3204
3205         Fix for older compilers. Pass id as the return type to the template
3206         instead of relying on default type.
3207
3208         * DumpRenderTree/mac/DumpRenderTree.mm:
3209         (drt_NSFontManager_availableFontFamilies):
3210         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3211         (WTR::wtr_NSFontManager_availableFontFamilies):
3212
3213 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3214
3215         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3216         https://bugs.webkit.org/show_bug.cgi?id=89616
3217
3218         Reviewed by Eric Seidel.
3219
3220         Add the new 'executive' optional function argument to the SCM.in_working_directory
3221         class method. This way we get to reuse an Executive instance which is necessary in testing
3222         when we're operating with a mock version of the object.
3223
3224         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3225         the SCMDetector with the generator's FileSystem and Executive instances.
3226
3227         * Scripts/webkitpy/common/checkout/scm/detection.py:
3228         (SCMDetector.detect_scm_system):
3229         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3230         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3231         Executive output and test it against expected output.
3232         * Scripts/webkitpy/common/checkout/scm/git.py:
3233         (Git.in_working_directory):
3234         * Scripts/webkitpy/common/checkout/scm/scm.py:
3235         (SCM.in_working_directory):
3236         * Scripts/webkitpy/common/checkout/scm/svn.py:
3237         (SVN.in_working_directory):
3238         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3239         (JSONResultsGeneratorBase.__init__):
3240         (JSONResultsGeneratorBase._get_svn_revision):
3241
3242 2012-08-31  Jon Lee  <jonlee@apple.com>
3243
3244         [Tests] Add basic tests to http/tests/notifications
3245         https://bugs.webkit.org/show_bug.cgi?id=95493
3246         <rdar://problem/12209303>
3247
3248         Reviewed by Alexey Proskuryakov.
3249
3250         Add permission request support for WTR.
3251
3252         * WebKitTestRunner/TestController.cpp:
3253         (WTR::TestController::initialize):
3254         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3255         * WebKitTestRunner/TestController.h:
3256         (TestController):
3257
3258 2012-08-31  Jon Lee  <jonlee@apple.com>
3259
3260         [DRT] Make simulating a web click on a notification a queued task
3261         https://bugs.webkit.org/show_bug.cgi?id=95546
3262         <rdar://problem/12214170>
3263
3264         Reviewed by Alexey Proskuryakov.
3265
3266         Making the web click happen asynchronously better mimics user interaction with the platform.
3267
3268         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3269         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3270         not set.
3271         * DumpRenderTree/mac/DumpRenderTree.mm:
3272         (dump): Assert that the flag is not set.
3273         * DumpRenderTree/mac/TestRunnerMac.mm:
3274         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3275         notification. In the case where the block gets executed after the flag has been unset, we avoid
3276         performing the click.
3277
3278 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3279
3280         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3281         https://bugs.webkit.org/show_bug.cgi?id=95575
3282
3283         Reviewed by Csaba Osztrogonác.
3284
3285         Output 100% difference in the case of differing image dimensions so
3286         the test harness knows that we won't produce any output further.
3287         This matches the behavior of other ports.
3288
3289         * DumpRenderTree/qt/ImageDiff.cpp:
3290         (main):
3291
3292 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3293
3294         Unreviewed, rolling out r127261.
3295         http://trac.webkit.org/changeset/127261
3296         https://bugs.webkit.org/show_bug.cgi?id=95572
3297
3298         This patch depends on other build fixes (see blockers of bug
3299         95466) which should land first (Requested by milian on
3300         #webkit).
3301
3302         * qmake/mkspecs/features/features.prf:
3303
3304 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3305
3306         [Qt] Support WebKit2/QML on QNX
3307         https://bugs.webkit.org/show_bug.cgi?id=95466
3308
3309         Reviewed by Noam Rosenthal.
3310
3311         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3312         this should finally work now.
3313
3314         * qmake/mkspecs/features/features.prf:
3315
3316 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3317
3318         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3319         https://bugs.webkit.org/show_bug.cgi?id=95400
3320
3321         Reviewed by Dirk Pranke.
3322
3323         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3324
3325         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3326         (ChromiumAndroidPort.skipped_layout_tests):
3327
3328 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3329
3330         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3331         https://bugs.webkit.org/show_bug.cgi?id=95499
3332
3333         Unreviewed. One more fix to avoid trying to run the empty string.
3334
3335         * Scripts/webkitdirs.pm:
3336         (buildAutotoolsProject):
3337
3338 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3339
3340         Unreviewed, rolling out r127171.
3341         http://trac.webkit.org/changeset/127171
3342         https://bugs.webkit.org/show_bug.cgi?id=95505
3343
3344         testRunner does not need dumpWebNotificationCallbacks().
3345         (Requested by jonlee on #webkit).
3346
3347         * DumpRenderTree/TestRunner.cpp:
3348         (TestRunner::TestRunner):
3349         (TestRunner::staticFunctions):
3350         * DumpRenderTree/TestRunner.h:
3351         (TestRunner):
3352         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3353         (-[MockWebNotificationProvider webView:didShowNotification:]):
3354         (-[MockWebNotificationProvider webView:didClickNotification:]):
3355         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3356         * DumpRenderTree/mac/UIDelegate.mm:
3357         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3358
3359 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3360
3361         objc_msgSend and IMP should be cast appropriately before using
3362         https://bugs.webkit.org/show_bug.cgi?id=95242
3363
3364         Reviewed by Benjamin Poulain.
3365
3366         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3367         to a function pointer with right types when calling objc_msgSend and an
3368         IMP method directly.
3369
3370         * DumpRenderTree/mac/DumpRenderTree.mm:
3371         (drt_NSFontManager_availableFontFamilies):
3372         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3373         (WTR::wtr_NSFontManager_availableFontFamilies):
3374
3375 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3376
3377         Replace JSC::UString by WTF::String
3378         https://bugs.webkit.org/show_bug.cgi?id=95271
3379
3380         Reviewed by Geoffrey Garen.
3381
3382         Get rid of UString.
3383
3384         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3385         * gdb/webkit.py:
3386         (WTFStringPrinter.to_string):
3387         (JSCIdentifierPrinter.to_string):
3388         (JSCJSStringPrinter.to_string):
3389         (add_pretty_printers):
3390
3391 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3392
3393         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3394         https://bugs.webkit.org/show_bug.cgi?id=95495
3395
3396         Reviewed by Ojan Vafai.
3397
3398         This is a follow-on to bug 95370 that adds in support for
3399         platform/wk2/TestExpectations and
3400         platform/{mac,win}-$version/TestExpectations.
3401
3402         * Scripts/webkitpy/layout_tests/port/apple.py:
3403         (ApplePort.expectations_files):
3404         * Scripts/webkitpy/layout_tests/port/base.py:
3405         (Port._skipped_file_search_paths):
3406         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3407         (MacTest.test_expectations_files):
3408         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3409         (MockDRTPortTest.make_port):
3410         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3411         (WinPortTest.test_expectations_files):
3412
3413 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3414
3415         executive.run_in_parallel() hangs if given nothing to do
3416         https://bugs.webkit.org/show_bug.cgi?id=95387
3417
3418         Reviewed by Ojan Vafai.
3419
3420         Check to make sure that Executive.run_in_parallel() requires
3421         a non-empty list of commands to execute; passing an empty list
3422         seems surely like a programming error.
3423
3424         * Scripts/webkitpy/common/system/executive.py:
3425         (Executive.run_in_parallel):
3426         * Scripts/webkitpy/common/system/executive_unittest.py:
3427         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3428
3429 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3430
3431         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3432         https://bugs.webkit.org/show_bug.cgi?id=94746
3433
3434         Reviewed by Ojan Vafai.
3435
3436         Add an assertion to diff_image() to check that we are passing
3437         tolerance=0 explicitly when diffing ref test results.
3438
3439         * Scripts/webkitpy/layout_tests/port/test.py:
3440         (TestPort.diff_image):
3441
3442 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3443
3444         NRWT should look in mac-wk2 for a TestExpecations file
3445         https://bugs.webkit.org/show_bug.cgi?id=95370
3446
3447         Reviewed by Ojan Vafai.
3448
3449         Adds support for mac-wk2 and win-wk2 to expectations_files()
3450         for the apple mac and apple win ports.
3451         
3452         * Scripts/webkitpy/layout_tests/port/apple.py:
3453         (ApplePort.expectations_files):
3454         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3455         (MacTest.test_expectations_files):
3456         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3457         (WinTest.test_expectations_files):
3458         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3459         (PortTestCase.test_expectations_files):
3460
3461 2012-08-30  Jon Lee  <jonlee@apple.com>
3462
3463         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3464         https://bugs.webkit.org/show_bug.cgi?id=95232
3465         <rdar://problem/12190776>
3466
3467         Reviewed by Alexey Proskuryakov.
3468
3469         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3470
3471         * DumpRenderTree/TestRunner.cpp:
3472         (TestRunner::TestRunner):
3473         (dumpWebNotificationCallbacksCallback):
3474         (TestRunner::staticFunctions):
3475         * DumpRenderTree/TestRunner.h:
3476         (TestRunner):
3477         (TestRunner::dumpWebNotificationCallbacks):
3478         (TestRunner::setDumpWebNotificationCallbacks):
3479         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3480         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3481         (-[MockWebNotificationProvider webView:didShowNotification:]):
3482         (-[MockWebNotificationProvider webView:didClickNotification:]):
3483         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3484         * DumpRenderTree/mac/UIDelegate.mm:
3485         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3486
3487 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3488
3489         MediaStream API: Introduce MediaConstraints
3490         https://bugs.webkit.org/show_bug.cgi?id=95198
3491
3492         Reviewed by Adam Barth.
3493
3494         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3495
3496         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3497         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3498         (isSupportedConstraint):
3499         (isValidConstraint):
3500         (MockWebRTCPeerConnectionHandler::initialize):
3501         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3502         (MockWebRTCPeerConnectionHandler):
3503
3504 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3505
3506         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3507         https://bugs.webkit.org/show_bug.cgi?id=95454
3508
3509         Reviewed by Kenneth Rohde Christiansen.
3510
3511         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3512
3513         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3514         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3515
3516 2012-08-30  Leo Yang  <leoyang@rim.com>
3517
3518         Update my email address.
3519
3520         Not reviewed.
3521
3522         * Scripts/webkitpy/common/config/committers.py:
3523
3524 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3525
3526         [NRWT] Add support for recognizing arbitrary process names in crash lines
3527         https://bugs.webkit.org/show_bug.cgi?id=95435
3528
3529         Reviewed by Adam Barth.
3530
3531         When running layout tests in the chromium port using the content shell,
3532         we want to be able to report sub-process crashes as well.
3533
3534         * Scripts/webkitpy/layout_tests/port/driver.py:
3535         (Driver._check_for_driver_crash):
3536         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3537         (DriverTest.test_check_for_driver_crash):
3538
3539 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3540
3541         Random test-webkitpy failures on the buildbot
3542         https://bugs.webkit.org/show_bug.cgi?id=95096
3543
3544         Reviewed by Dirk Pranke.
3545
3546         Suppress occasional errors when running test-webkitpy on GTK builders
3547         by running these tests serially. The 64-bit Release builder is especially
3548         prone to these as it can run up to 24 tests in parallel.
3549
3550         Despite the tests not being run in parallel, the testing only lasts a handful
3551         of seconds more, so this is a worthy trade-off to avoid unnecessary
3552         false-alarm redness on the GTK builders.
3553
3554         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3555         (RunPythonTests.start):
3556
3557 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3558
3559         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3560         https://bugs.webkit.org/show_bug.cgi?id=95380
3561
3562         Reviewed by Michael Saboff.
3563
3564         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3565         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3566         the crash.
3567
3568 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3569
3570         AX: Canvas should have a distinct role
3571         https://bugs.webkit.org/show_bug.cgi?id=95248
3572
3573         Reviewed by Chris Fleizach.
3574
3575         Add support for canvas accessibility role.
3576
3577         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3578         (roleToString):
3579
3580 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3581
3582         [Gtk] Process Gtk 3.4 smooth scroll events properly
3583         https://bugs.webkit.org/show_bug.cgi?id=88070
3584
3585         Added continousMouseScrollBy support in WebKitTestRunner, and added
3586         implementation for gtk, and stub for Qt, mac and EFL.
3587
3588         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3589         scroll for emulating multi-tick mouseScrollBy events.
3590
3591         Reviewed by Martin Robinson.
3592
3593         * DumpRenderTree/gtk/EventSender.cpp:
3594         (mouseScrollByCallback):
3595         (continuousMouseScrollByCallback):
3596         * WebKitTestRunner/EventSenderProxy.h:
3597         (EventSenderProxy):
3598         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3599         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3600         (WTR::EventSendingController::mouseScrollBy):
3601         (WTR):
3602         (WTR::EventSendingController::continuousMouseScrollBy):
3603         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3604         (EventSendingController):
3605         * WebKitTestRunner/TestController.cpp:
3606         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3607         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3608         (WTR):
3609         (WTR::EventSenderProxy::mouseScrollBy):
3610         (WTR::EventSenderProxy::continuousMouseScrollBy):
3611         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3612         (WTR):
3613         (WTR::EventSenderProxy::continuousMouseScrollBy):
3614         * WebKitTestRunner/mac/EventSenderProxy.mm:
3615         (WTR::EventSenderProxy::continuousScrollBy):
3616         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3617         (WTR::EventSenderProxy::continuousMouseScrollBy):
3618         (WTR):
3619
3620 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
3621
3622         [chromium] Support high DIP pixel tests with DumpRenderTree
3623         https://bugs.webkit.org/show_bug.cgi?id=94935
3624
3625         Reviewed by James Robinson.
3626
3627         Adding device scale factor into the drt image dumping code
3628
3629         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3630         (DRTTestRunner::reset):
3631         (DRTTestRunner::setBackingScaleFactor):
3632         * DumpRenderTree/chromium/WebViewHost.cpp:
3633         (WebViewHost::setDeviceScaleFactor):
3634         (WebViewHost::paintInvalidatedRegion):
3635         (WebViewHost::canvas):
3636         * DumpRenderTree/chromium/WebViewHost.h:
3637         (WebViewHost):
3638
3639 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
3640
3641         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
3642         https://bugs.webkit.org/show_bug.cgi?id=95177
3643
3644         Reviewed by Dirk Pranke.
3645
3646         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
3647
3648         * Scripts/webkitpy/common/checkout/scm/git.py:
3649
3650 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3651
3652         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
3653         https://bugs.webkit.org/show_bug.cgi?id=95222
3654
3655         Reviewed by Adam Barth.
3656
3657         The code we had to remove REBASELINE lines from the
3658         TestExpectations files did not handle multiple files (in a
3659         cascade) correctly; we weren't limiting lines to a particular
3660         file correctly in without_rebaseline_modifier(). This patch
3661         fixes that and corrects the tests (which weren't correct and
3662         didn't cover things very well).
3663
3664         Note also that the webkit-patch rebaseline-commands are still
3665         using the include_overrides=False option in a couple places;
3666         this is never correct or needed at this point. This patch fixes
3667         the usage for webkit-patch rebaseline-expectations, but I still
3668         need to fix rebaseline-test-internal, which I will do in a
3669         separate patch (see bug 95268).
3670
3671         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3672         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3673         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3674         (RebaseliningTest.assertRemove):
3675         (RebaseliningTest.test_remove):
3676         * Scripts/webkitpy/tool/commands/rebaseline.py:
3677         (RebaselineExpectations._update_expectations_files):
3678
3679 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
3680
3681         webkit-patch rebaseline-expectations hangs
3682         https://bugs.webkit.org/show_bug.cgi?id=95243
3683
3684         Reviewed by Tony Chang.
3685
3686         Don't try to run no commands in parallel; report an error
3687         instead that we didn't find any tests to rebaseline.
3688
3689         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
3690
3691         * Scripts/webkitpy/tool/commands/rebaseline.py:
3692         (RebaselineExpectations.execute):
3693         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3694         (_assert_command):
3695         (test_rebaseline_expectations_noop):
3696
3697 2012-08-29  Brady Eidson  <beidson@apple.com>
3698
3699         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
3700         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
3701
3702         Reviewed by Sam Weinig.
3703
3704         Add a test plug-in that calls back into the page with info on the NPWindow passed
3705         in to NPP_SetWindow.
3706
3707         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3708         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
3709         (LogNPPSetWindow):
3710         (LogNPPSetWindow::LogNPPSetWindow):
3711         (LogNPPSetWindow::NPP_SetWindow):
3712
3713 2012-08-29  Jon Lee  <jonlee@apple.com>
3714
3715         [Mac] Basic DRT support for web notifications
3716         https://bugs.webkit.org/show_bug.cgi?id=79492
3717         <rdar://problem/10357639>
3718
3719         Reviewed by Alexey Proskuryakov.
3720
3721         This patch implements the stubs for web notification support on DRT. Assume that when
3722         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
3723         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
3724
3725         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
3726         * DumpRenderTree/mac/DumpRenderTree.mm:
3727         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
3728         web view.
3729         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
3730
3731         * DumpRenderTree/mac/TestRunnerMac.mm:
3732         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
3733         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
3734         (TestRunner::removeAllWebNotificationPermissions):
3735         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
3736         simulate the click. This is similar to how WTR performs the click.
3737         * DumpRenderTree/mac/UIDelegate.mm:
3738         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
3739         user allows web notifications.
3740
3741         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
3742         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
3743         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
3744         (+[MockWebNotificationProvider shared]): The provider is a singleton.
3745         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
3746         (-[MockWebNotificationProvider registerWebView:]):
3747         (-[MockWebNotificationProvider unregisterWebView:]):
3748         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
3749         notification did show.
3750         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
3751         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
3752         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
3753         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
3754         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
3755         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
3756         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
3757         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
3758         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
3759         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
3760         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
3761
3762 2012-08-29  Rob Buis  <rbuis@rim.com>
3763
3764         [BlackBerry] Adjust wtf include header style
3765         https://bugs.webkit.org/show_bug.cgi?id=95368
3766
3767         Reviewed by Yong Li.
3768
3769         Switch to #include <wtf/...> like the other ports.
3770
3771         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3772         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
3773         * DumpRenderTree/blackberry/PNGImageEncoder.h:
3774         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3775         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
3776         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3777
3778 2012-08-29  Roger Fong  <roger_fong@apple.com>
3779
3780         Update cygwin-downloader.zip to match modified downloader script.
3781         https://bugs.webkit.org/show_bug.cgi?id=76936
3782
3783         Rubber Stamped by Jon Honeycutt.
3784
3785         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
3786         Updating zip to reflect changes.
3787
3788         * CygwinDownloader/cygwin-downloader.zip:
3789
3790 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3791
3792         Stylechecker warns about comparison to zero when comparing to 0.5
3793         https://bugs.webkit.org/show_bug.cgi?id=94913
3794
3795         Reviewed by Dirk Pranke.
3796
3797         According to the python documentation, \W is the character group with all
3798         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
3799         to [^\w]. We need to exclude the dot "." as well, so that floating point
3800         values do not trigger this warning. Adding a unit test that shows the problem.
3801
3802         * Scripts/webkitpy/style/checkers/cpp.py:
3803         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
3804         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3805         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
3806
3807 2012-08-29  Jon Lee  <jonlee@apple.com>
3808
3809         WTR build fixes.
3810
3811         * WebKitTestRunner/CMakeLists.txt:
3812         * WebKitTestRunner/GNUmakefile.am:
3813         * WebKitTestRunner/Target.pri:
3814         * WebKitTestRunner/WebNotificationProvider.cpp:
3815         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
3816         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3817
3818 2012-08-29  Jon Lee  <jonlee@apple.com>
3819
3820         [WK2] Basic WTR support for web notifications
3821         https://bugs.webkit.org/show_bug.cgi?id=95154
3822         <rdar://problem/12184492>
3823
3824         Reviewed by Alexey Proskuryakov.
3825
3826         Implement WTR support, without platform event output (bug 95233).
3827
3828         Legacy APIs will not be supported, since many of the tests are skipped
3829         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
3830         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
3831         the tests to http/tests/notifications.
3832
3833         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
3834         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
3835         be invoked from the UIProcess.
3836
3837         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3838         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3839         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
3840         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
3841         notification's internal ID.
3842         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3843         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3844         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
3845         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
3846         (WTR::TestRunner::removeAllWebNotificationPermissions):
3847         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
3848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3849
3850         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
3851         class.
3852         * WebKitTestRunner/TestInvocation.cpp:
3853         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
3854         TestInvocation forwards that request to the TestController.
3855         * WebKitTestRunner/TestController.cpp:
3856         (WTR::TestController::initialize): Set the provider.
3857         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
3858         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
3859         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
3860
3861         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
3862         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
3863         * WebKitTestRunner/WebNotificationProvider.h: Added.
3864         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
3865         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
3866         the notification got shown.
3867         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
3868         got closed.
3869         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
3870         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
3871         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
3872         permissions. For testing purposes, we always want this set to be empty.
3873         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
3874         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
3875
3876         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
3877
3878 2012-08-29  Kamil Blank  <k.blank@samsung.com>
3879
3880         [EFL] Add setting API for allow universal/file access from file URLs.
3881         https://bugs.webkit.org/show_bug.cgi?id=83121
3882
3883         Reviewed by Eric Seidel.
3884
3885         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
3886
3887         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3888         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3889         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3890         (TestRunner::setAllowUniversalAccessFromFileURLs):
3891         (TestRunner::setAllowFileAccessFromFileURLs):
3892
3893 2012-08-29  Jon Lee  <jonlee@apple.com>
3894
3895         Update TestRunner API for web notifications
3896         https://bugs.webkit.org/show_bug.cgi?id=95093
3897         <rdar://problem/12179649>
3898
3899         Reviewed by Alexey Proskuryakov.
3900
3901         As it turns out the patch for this accidentally got squashed into the commit for
3902         bug 95099 (r126909). This amendment patch adds some comments about the renaming
3903         of the older TestRunner API for web notifications.
3904
3905         * DumpRenderTree/TestRunner.h:
3906         (TestRunner):
3907
3908 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3909
3910         Unreviewed, rolling out r126972.
3911         http://trac.webkit.org/changeset/126972
3912         https://bugs.webkit.org/show_bug.cgi?id=95349
3913
3914         accessibility/canvas-description-and-role.html has been
3915         failing consistently on several bots and Dominic needs some
3916         time to investigate why (Requested by jchaffraix on #webkit).
3917
3918         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3919         (roleToString):
3920
3921 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
3922
3923         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
3924         https://bugs.webkit.org/show_bug.cgi?id=84707
3925
3926         Reviewed by Gustavo Noronha Silva.
3927
3928         Most of the warnings have been fixed now that FindCairo.cmake and
3929         FindGLIB.cmake have been rewritten. The remaining one, related to
3930         FindFontconfig.cmake, shows up when building on a 64-bit
3931         Debian-based systems.
3932
3933         jhbuild installs libraries into lib64/ by default on 64-bit Linux
3934         installations, while CMake does not look for libraries in lib64/
3935         when /etc/debian_version exists on the system. The FIND_LIBRARY()
3936         would then sometimes end up using the system installation instead of
3937         the jhbuild one, causing mismatches and, when pkg-config is not used
3938         at all, failing to find libraries altogether.
3939
3940         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
3941         when use_lib64 is set to force CMake to look into lib64/ regardless
3942         of the presence of /etc/debian_version.
3943
3944 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
3945
3946         The 2d.imageData.object.round canvas test is failing
3947         https://bugs.webkit.org/show_bug.cgi?id=40272
3948
3949         Reviewed by Benjamin Poulain.
3950
3951         Updating patch to address Benjamin's review comments.
3952         Adding a WTF test to test lrint implementation.
3953
3954         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
3955         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
3956         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
3957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
3958         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
3959         (TestWebKitAPI):
3960         (TestWebKitAPI::TEST):
3961         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
3962
3963 2012-08-29  Florin Malita  <fmalita@chromium.org>
3964
3965         Unreviewed, updating Kelly Norton's email address at his request.
3966
3967         * Scripts/webkitpy/common/config/committers.py:
3968
3969 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3970
3971         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
3972         https://bugs.webkit.org/show_bug.cgi?id=93723
3973
3974         Reviewed by Dirk Pranke.
3975
3976         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3977         (TestExpectationParser.expectation_for_skipped_test):
3978         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3979         (SkippedTests.test_skipped_entry_dont_exist):
3980
3981 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3982
3983         Unreviewed, rolling out r120113.
3984         http://trac.webkit.org/changeset/120113
3985         https://bugs.webkit.org/show_bug.cgi?id=95320
3986
3987         Wrong fix for the problem, experimentally rolling it out for
3988         bug 95237. (Requested by rakuco on #webkit).
3989
3990         * efl/jhbuildrc:
3991
3992 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3993
3994         AX: Canvas should have a distinct role
3995         https://bugs.webkit.org/show_bug.cgi?id=95248
3996
3997         Reviewed by Chris Fleizach.
3998
3999         Add support for canvas accessibility role.
4000
4001         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4002         (roleToString):
4003
4004 2012-08-28  Eric Seidel  <eric@webkit.org>
4005
4006         cr-ews bot doesn't set CWD correctly when zipping layout test results
4007         https://bugs.webkit.org/show_bug.cgi?id=91265
4008
4009         Reviewed by Kenneth Russell.
4010
4011         This should make the zips slightly less cumbersome to deal with.
4012
4013         * Scripts/webkitpy/common/system/workspace.py:
4014         (Workspace.create_zip):
4015         * Scripts/webkitpy/common/system/workspace_unittest.py:
4016         (WorkspaceTest.test_create_zip):
4017         (WorkspaceTest.test_create_zip_exception):
4018
4019 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
4020
4021         Fix the Commiters script
4022
4023         Unreviewed.
4024
4025         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
4026
4027         * Scripts/webkitpy/common/config/committers.py:
4028
4029 2012-08-28  Roger Fong  <roger_fong@apple.com>
4030
4031         Unreviewed. Adding myself to committers list.
4032
4033         * Scripts/webkitpy/common/config/committers.py:
4034
4035 2012-08-28  Roger Fong  <roger_fong@apple.com>
4036
4037         Add minires to list of required cygwin install packages.
4038         https://bugs.webkit.org/show_bug.cgi?id=76936
4039
4040         Reviewed by Tim Horton.
4041
4042         * CygwinDownloader/cygwin-downloader.py:
4043
4044 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
4045
4046         [Chromium-Android] Upstream layout test expectations (Part 2)
4047         https://bugs.webkit.org/show_bug.cgi?id=95212
4048
4049         Reviewed by Adam Barth.
4050
4051         - Now run both gpu path and non-gpu path of 2d canvas layout tests
4052         because both are used in chromium-android.
4053
4054         - Exclude all webgl tests because webgl is not enabled yet.
4055
4056         - Removed 'win' from the baseline fallback list. This was a mistake.
4057
4058         - Moved some small directories to TestExpectations from skipped_layout_tests().
4059
4060         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4061         (ChromiumAndroidPort):
4062         (ChromiumAndroidPort.skipped_layout_tests):
4063
4064 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
4065
4066         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
4067         https://bugs.webkit.org/show_bug.cgi?id=95185
4068
4069         Reviewed by Chris Fleizach.
4070
4071         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4072         (AccessibilityUIElement::titleUIElement): Implemented
4073         Gets the ATK_RELATION_LABELLED_BY target.
4074         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
4075         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
4076         bug 95180 is fixed.
4077
4078 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
4079
4080         AX: Crash due to object getting deleted inside updateBackingStore
4081         https://bugs.webkit.org/show_bug.cgi?id=94619
4082
4083         Reviewed by Chris Fleizach.
4084
4085         Change isValid to !isDetached after deleting isValid from
4086         chromium WebAccessibilityObject as being redundant.
4087
4088         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4089         (AccessibilityUIElement::isValidGetterCallback):
4090
4091 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
4092
4093         Unreviewed, rolling out r126914.
4094         http://trac.webkit.org/changeset/126914
4095         https://bugs.webkit.org/show_bug.cgi?id=95239
4096
4097         it breaks everything and fixes nothing (Requested by pizlo on
4098         #webkit).
4099
4100         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4101         (MockWebSpeechInputController::addMockRecognitionResult):
4102         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4103         (NotificationPresenter::simulateClick):
4104         (NotificationPresenter::show):
4105         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4106         (CppBoundClass::~CppBoundClass):
4107         (CppBoundClass::invoke):
4108         (CppBoundClass::getProperty):
4109         (CppBoundClass::setProperty):
4110         (CppBoundClass::bindCallback):
4111         (CppBoundClass::bindProperty):
4112         * DumpRenderTree/chromium/WebPreferences.cpp:
4113         (applyFontMap):
4114         * DumpRenderTree/chromium/WebViewHost.cpp:
4115         (WebViewHost::printResourceDescription):
4116         * DumpRenderTree/mac/TestRunnerMac.mm:
4117         (worldIDForWorld):
4118         (TestRunner::evaluateScriptInIsolatedWorld):
4119         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4120         (AccessibilityController::~AccessibilityController):
4121         (AccessibilityController::winNotificationReceived):
4122         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4123         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4124         * DumpRenderTree/win/TestRunnerWin.cpp:
4125         (worldIDForWorld):
4126         (TestRunner::evaluateScriptInIsolatedWorld):
4127         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4128         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4129         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4130         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4132         (WTR::TestRunner::worldIDForWorld):
4133         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4134
4135 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4136
4137         Rename first/second to key/value in HashMap iterators
4138         https://bugs.webkit.org/show_bug.cgi?id=82784
4139
4140         Reviewed by Eric Seidel.
4141
4142         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4143         (MockWebSpeechInputController::addMockRecognitionResult):
4144         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4145         (NotificationPresenter::simulateClick):
4146         (NotificationPresenter::show):
4147         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4148         (CppBoundClass::~CppBoundClass):
4149         (CppBoundClass::invoke):
4150         (CppBoundClass::getProperty):
4151         (CppBoundClass::setProperty):
4152         (CppBoundClass::bindCallback):
4153         (CppBoundClass::bindProperty):
4154         * DumpRenderTree/chromium/WebPreferences.cpp:
4155         (applyFontMap):
4156         * DumpRenderTree/chromium/WebViewHost.cpp:
4157         (WebViewHost::printResourceDescription):
4158         * DumpRenderTree/mac/TestRunnerMac.mm:
4159         (worldIDForWorld):
4160         (TestRunner::evaluateScriptInIsolatedWorld):
4161         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4162         (AccessibilityController::~AccessibilityController):
4163         (AccessibilityController::winNotificationReceived):
4164         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4165         (ResourceLoadDelegate::descriptionSuitableForTestResult):
4166         * DumpRenderTree/win/TestRunnerWin.cpp:
4167         (worldIDForWorld):
4168         (TestRunner::evaluateScriptInIsolatedWorld):
4169         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4170         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
4171         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4172         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
4173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4174         (WTR::TestRunner::worldIDForWorld):
4175         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
4176
4177 2012-08-27  Jon Lee  <jonlee@apple.com>
4178
4179         Update TestRunner API for web notifications
4180         https://bugs.webkit.org/show_bug.cgi?id=95093
4181         <rdar://problem/12179649>
4182
4183         Reviewed by Jessie Berlin.
4184
4185         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
4186
4187         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
4188         This first patch renames the TestRunner calls to use the term "web notifications" instead of
4189         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
4190         additional calls that will be used in the tests that test the standard API.
4191
4192         * DumpRenderTree/TestRunner.h:
4193         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
4194         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
4195         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
4196         (TestRunner::TestRunner):
4197         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
4198         (simulateLegacyWebNotificationClickCallback): Renamed.
4199         (grantWebNotificationPermissionCallback): Renamed.
4200         (denyWebNotificationPermissionCallback): Added.
4201         (removeAllWebNotificationPermissionsCallback): Added.
4202         (simulateWebNotificationClickCallback): Added.
4203         (TestRunner::staticFunctions):
4204         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
4205
4206         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4207         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
4208         (DRTTestRunner::grantWebNotificationPermission):
4209         (DRTTestRunner::denyWebNotificationPermission): Stub.
4210         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
4211         (DRTTestRunner::simulateWebNotificationClick): Stub.
4212         (DRTTestRunner::simulateLegacyWebNotificationClick):
4213         * DumpRenderTree/chromium/DRTTestRunner.h:
4214         (DRTTestRunner):
4215
4216         Added stubs.
4217         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4218         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4219         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4220         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
4221         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
4222         * DumpRenderTree/win/TestRunnerWin.cpp:
4223
4224 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
4225
4226         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
4227         https://bugs.webkit.org/show_bug.cgi?id=94700
4228
4229         Reviewed by Eric Seidel.
4230
4231         Interrupting download with a timeout would be a possible solution.
4232         I imported the socket module and used the setdefaulttimeout() method.
4233         Fixing it is important, because EWS bots need to be restarted regularly
4234         because of this bug.
4235
4236         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4237         (Bugzilla._get_browser):
4238         (Bugzilla.setdefaulttimeout):
4239
4240 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
4241
4242         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
4243         https://bugs.webkit.org/show_bug.cgi?id=95194
4244
4245         Reviewed by Simon Hausmann.
4246
4247         * Scripts/webkitpy/layout_tests/port/qt.py:
4248         (QtPort.setup_environ_for_server):
4249
4250 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
4251
4252         [watchlist] Unreviewed, subscribe to Qt bugs.
4253
4254         * Scripts/webkitpy/common/config/watchlist:
4255
4256 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
4257
4258         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
4259         https://bugs.webkit.org/show_bug.cgi?id=95054
4260
4261         Reviewed by Eric Seidel.
4262
4263         Enable CSS_IMAGE_SET for the Qt build.
4264
4265         * qmake/mkspecs/features/features.pri:
4266
4267 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
4268
4269         [Qt] Enable CSS sticky position
4270         https://bugs.webkit.org/show_bug.cgi?id=95172
4271
4272         Reviewed by Simon Hausmann.
4273
4274         * qmake/mkspecs/features/features.pri:
4275
4276 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
4277
4278         [GTK] Memory cache should be cleared in between test runs
4279         https://bugs.webkit.org/show_bug.cgi?id=95105
4280
4281         Reviewed by Martin Robinson.
4282
4283         Call the new DumpRenderTreeSupportGtk helper method after every test
4284         to clear the memory cache.
4285
4286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4287         (runTest):
4288
4289 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
4290
4291         Unreviewed, rolling out r126836.
4292         http://trac.webkit.org/changeset/126836
4293         https://bugs.webkit.org/show_bug.cgi?id=95163
4294
4295         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
4296         #webkit).
4297
4298         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4299         (MockWebSpeechInputController::addMockRecognitionResult):
4300         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4301         (NotificationPresenter::simulateClick):
4302         (NotificationPresenter::show):
4303         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
4304         (CppBoundClass::~CppBoundClass):
4305         (CppBoundClass::invoke):