[WK2] Add test infrastructure and unit tests for data interaction
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [WK2] Add test infrastructure and unit tests for data interaction
4         https://bugs.webkit.org/show_bug.cgi?id=168159
5         <rdar://problem/30477634>
6
7         Reviewed by Tim Horton.
8
9         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
10         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
11         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
12         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
13         gesture has already been recognized) at regular intervals over the course of the test.
14
15         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
16         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
17         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
18         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
19
20         New test pages for data interaction.
21
22         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
23         (TestWebKitAPI::runTestsExpectingToObserveEvents):
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/cocoa/TestWKWebView.mm:
26         (-[TestWKWebView stringByEvaluatingJavaScript:]):
27         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
28         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
29         (-[MockLongPressGestureRecognizer initWithWindow:]):
30         (-[MockLongPressGestureRecognizer locationInView:]):
31         (-[MockLongPressGestureRecognizer state]):
32         (-[MockLongPressGestureRecognizer numberOfTouches]):
33         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
34         (-[DataInteractionSimulator dealloc]):
35         (-[DataInteractionSimulator run]):
36
37         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
38         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
39         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
40
41         (-[DataInteractionSimulator _advanceProgress]):
42
43         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
44         completed, and calls _finishDataInteraction when progress is at 1.
45
46         (-[DataInteractionSimulator _finishDataInteraction]):
47         (-[DataInteractionSimulator _currentLocation]):
48         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
49         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
50         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
51         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
52         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
53
54 2017-02-13  Alex Christensen  <achristensen@webkit.org>
55
56         Percent should be allowed in non-special URL hosts
57         https://bugs.webkit.org/show_bug.cgi?id=168255
58
59         Reviewed by Tim Horton.
60
61         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
62         (TestWebKitAPI::TEST_F):
63
64 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
65
66         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
67         https://bugs.webkit.org/show_bug.cgi?id=168221
68
69         Reviewed by Ryosuke Niwa.
70
71         There is a logic error in comparing mismatch ref test images. In
72         mismatch ref tests, it should be failed if two images has no diff.
73         But, if the hashes are different, nwtr unexpectedly pass the
74         mismatch ref test.
75
76         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
77         (SingleTestRunner._compare_output_with_reference): Fail the
78         mismatch ref test if hashes of two images are equal. Invoke
79         ImageDiff if the hashes don't match.
80
81 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
82
83         Update custom line breaking iterators to the latest version of Unicode
84         https://bugs.webkit.org/show_bug.cgi?id=168182
85
86         Reviewed by Zalan Bujtas.
87
88         Treat the system's ICU as the source of truth to compare breaking positions against.
89
90         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
91         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
92         (generateJavaScriptForTest):
93         (breakingLocationsFromICU):
94         (testAFewStrings):
95         (TEST):
96         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
97         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
98
99 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
100
101         [GTK] Several failing WebViewEditor API tests
102         https://bugs.webkit.org/show_bug.cgi?id=161608
103
104         Reviewed by Carlos Garcia Campos.
105
106         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
107         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
108         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
109         except the first one, which is still broken due to unrelated bug #151654.
110
111         * Scripts/run-gtk-tests:
112         (TestRunner):
113         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
114
115 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
116
117         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
118
119         * Scripts/run-gtk-tests:
120         (TestRunner):
121
122 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
123
124         Unreviewed, skip flaky form-controls-associated-signal test
125
126         * Scripts/run-gtk-tests:
127         (TestRunner):
128
129 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
130
131         [GTK] Handle caps lock indicator in event modifiers
132         https://bugs.webkit.org/show_bug.cgi?id=168186
133
134         Reviewed by Michael Catanzaro.
135
136         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
137         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
138
139 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
140
141         MiniBrowser WK1 fails to update URL for within-page navigations
142         https://bugs.webkit.org/show_bug.cgi?id=168173
143
144         Reviewed by Tim Horton.
145         
146         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
147         anchors updates the URL field.
148
149         * MiniBrowser/mac/WK1BrowserWindowController.m:
150         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
151
152 2017-02-10  John Wilander  <wilander@apple.com>
153
154         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
155         https://bugs.webkit.org/show_bug.cgi?id=167474
156         <rdar://problem/24681808>
157         <rdar://problem/24703286>
158         <rdar://problem/30290270>
159
160         This patch adds test infrastructure to allow testing 
161         of the various rules in place for data records removal.
162
163         Reviewed by Andy Estes.
164
165         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
166         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
167         (WTR::InjectedBundle::didReceiveMessageToPage):
168             Callback mechanism to tell pages that a website data store
169             scan has happened.
170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
171         (WTR::TestRunner::setStatisticsPrevalentResource):
172         (WTR::TestRunner::isStatisticsPrevalentResource):
173         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
174         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
175         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
176         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
177         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
178         (WTR::TestRunner::statisticsFireDataModificationHandler):
179         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
180         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
181         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
182         (WTR::TestRunner::statisticsResetToConsistentState):
183         * WebKitTestRunner/InjectedBundle/TestRunner.h:
184         * WebKitTestRunner/TestController.cpp:
185         (WTR::TestController::setStatisticsPrevalentResource):
186         (WTR::TestController::isStatisticsPrevalentResource):
187         (WTR::TestController::setStatisticsHasHadUserInteraction):
188         (WTR::TestController::isStatisticsHasHadUserInteraction):
189         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
190         (WTR::TestController::statisticsFireDataModificationHandler):
191         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
192         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
193         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
194         (WTR::TestController::statisticsResetToConsistentState):
195         * WebKitTestRunner/TestController.h:
196             These are all configuration and test functions.
197         * WebKitTestRunner/TestInvocation.cpp:
198         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
199
200 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
201
202         REGRESSION(r182916) run-perf-tests never timeouts
203         https://bugs.webkit.org/show_bug.cgi?id=167626
204
205         Reviewed by Ryosuke Niwa.
206
207         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
208         was beeing ignored because the driver was created with no_timeout=True
209         unconditionally.
210         This adds a new parameter --no-timeout (disabled by default), that
211         allows to use the driver with the expected timeout values.
212         It also passes --no-timeout to DRT/WTR to ensure that timeouts
213         are always controlled by the Python Driver.
214
215         * Scripts/webkitpy/performance_tests/perftest.py:
216         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
217         (PerfTest.run): Disabling timeout should be done when the Driver is created.
218         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
219         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
220         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
221         (_run_tests_set): Pass the no-timeout parameter.
222         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
223         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
224         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
225         (MainTest.test_parse_args): Test that the argument no-timeout.
226
227 2017-02-10  Daniel Bates  <dabates@apple.com>
228
229         Detach frame from document when entering page cache
230         https://bugs.webkit.org/show_bug.cgi?id=166774
231         <rdar://problem/29904368>
232
233         Reviewed by Chris Dumez.
234
235         * DumpRenderTree/mac/DumpRenderTree.mm:
236         (resetWebPreferencesToConsistentValues):
237         * DumpRenderTree/win/DumpRenderTree.cpp:
238         (resetWebPreferencesToConsistentValues):
239         * WebKitTestRunner/TestController.cpp:
240         (WTR::TestController::resetPreferencesToConsistentValues):
241
242 2017-02-10  Tim Horton  <timothy_horton@apple.com>
243
244         Infinite UI process hang under ensurePositionInformationIsUpToDate
245         https://bugs.webkit.org/show_bug.cgi?id=168154
246         <rdar://problem/30428673>
247
248         Reviewed by Simon Fraser.
249
250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
251         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
252         (recursiveFindHighlightLongPressRecognizer):
253         (TEST):
254         Add a somewhat nasty test that does an async interaction information update, but
255         kills the Web process before it arrives, and then does a sync interaction
256         information update, which will wait for the oustanding async interaction
257         information update if we still think it's coming. Before the patch, this
258         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
259
260 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
261
262         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
263         https://bugs.webkit.org/show_bug.cgi?id=168127
264         rdar://problem/30467120
265
266         Reviewed by Tim Horton.
267
268         Reparent the web view before we try to fetch it via:
269             [[[window contentView] subviews] objectAtIndex:0];
270         which would throw an exception if the test unparented it.
271
272         * DumpRenderTree/mac/DumpRenderTree.mm:
273         (resetWebViewToConsistentStateBeforeTesting):
274         (runTest):
275
276 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
277
278         [Resource Timing] Enable Resource Timing by default in Tests
279         https://bugs.webkit.org/show_bug.cgi?id=168145
280
281         Reviewed by Ryosuke Niwa.
282
283         * DumpRenderTree/mac/DumpRenderTree.mm:
284         (resetWebPreferencesToConsistentValues):
285         * DumpRenderTree/win/DumpRenderTree.cpp:
286         (resetWebPreferencesToConsistentValues):
287         * WebKitTestRunner/TestController.cpp:
288         (WTR::TestController::resetPreferencesToConsistentValues):
289
290 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
291
292         Removing LayoutTestRelay
293         https://bugs.webkit.org/show_bug.cgi?id=165927
294
295         Reviewed by Daniel Bates.
296         Part 2
297
298         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
299         simulators through simctl (iOS 10 and later), use this functionality instead.
300
301         * BuildSlaveSupport/built-product-archive:
302         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
303         Added a FIXME that we will need to implement similar archiving machinery once we build
304         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
305         * BuildSlaveSupport/kill-old-processes:
306         (main): Remove LayoutTestRelay from list of processes.
307         * LayoutTestRelay: Removed LayoutTestRelay.
308         * Makefile:
309         * Scripts/build-layouttestrelay: Removed.
310         * Scripts/build-webkit: Removed LayoutTestRelay references.
311
312 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
313
314         [WebCrypto] Add WebCryptoAPI to watchlist
315         https://bugs.webkit.org/show_bug.cgi?id=168138
316
317         Reviewed by Youenn Fablet.
318
319         * Scripts/webkitpy/common/config/watchlist:
320
321 2017-02-10  Brady Eidson  <beidson@apple.com>
322
323         Replace all WebKit Library Version checks in WK2 with SDK version checks.
324         https://bugs.webkit.org/show_bug.cgi?id=168124
325
326         Reviewed by Geoffrey Garen.
327
328         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
329         
330         * MiniBrowser/mac/main.m:
331         (main):
332         * MobileMiniBrowser/MobileMiniBrowser/main.m:
333         (main):
334         * TestWebKitAPI/ios/mainIOS.mm:
335         (main):
336         * TestWebKitAPI/mac/mainMac.mm:
337         (main):
338         * WebKitTestRunner/ios/mainIOS.mm:
339         (main):
340         * WebKitTestRunner/mac/main.mm:
341         (setDefaultsToConsistentValuesForTesting):
342
343 2017-02-10  Alex Christensen  <achristensen@webkit.org>
344
345         Fix El Capitan build.
346
347         * Scripts/build-webkit:
348         Don't build libwebrtc anywhere for now.
349
350 2017-02-10  Andy Estes  <aestes@apple.com>
351
352         Move two MiniBrowserBundle settings out of the .pbxproj
353         https://bugs.webkit.org/show_bug.cgi?id=168106
354
355         Reviewed by Tim Horton.
356
357         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
358         the project file. This removes the project file override.
359
360         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
361
362         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
363         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
364
365 2017-02-10  Alex Christensen  <achristensen@webkit.org>
366
367         Fix 32-and-64-bit build on El Capitan.
368
369         * Scripts/build-webkit:
370         Somebody's building with something like this:
371         build-webkit ARCHS="i386 x86_64"
372         We want this to also not build libwebrtc for now.
373
374 2017-02-10  Alex Christensen  <achristensen@webkit.org>
375
376         Fix 32-bit build on El Capitan.
377
378         * Scripts/build-webkit:
379         The bot uses ARCHS=i386 instead of --32-bit.
380         This is a hack, but it should fix the bot until I can do a better fix in the morning.
381
382 2017-02-10  Alex Christensen  <achristensen@webkit.org>
383
384         Fix 32-bit build on El Capitan.
385
386         * Scripts/build-webkit:
387         Don't build i386 libwebrtc.
388
389 2017-02-09  Alex Christensen  <achristensen@webkit.org>
390
391         Unreviewed, rolling out r212040.
392
393         Broke build.  I'm not surprised
394
395         Reverted changeset:
396
397         "[WebRTC][Mac] Activate libwebrtc"
398         https://bugs.webkit.org/show_bug.cgi?id=167293
399         http://trac.webkit.org/changeset/212040
400
401 2017-02-09  Alex Christensen  <achristensen@webkit.org>
402
403         Build libwebrtc on bots without using it yet
404         https://bugs.webkit.org/show_bug.cgi?id=168062
405
406         Reviewed by Brent Fulgham.
407
408         * Scripts/build-webkit:
409
410 2017-02-09  Alex Christensen  <achristensen@webkit.org>
411
412         Don't build libwebrtc.
413
414         * Scripts/build-webkit:
415         Not ready yet.  It broke El Capitan and iOS.
416
417 2017-02-09  Alex Christensen  <achristensen@webkit.org>
418
419         Build libwebrtc on bots without using it yet
420         https://bugs.webkit.org/show_bug.cgi?id=168062
421
422         Reviewed by Brent Fulgham.
423
424         * Scripts/build-webkit:
425
426 2017-02-09  Alex Christensen  <achristensen@webkit.org>
427
428         Rename isAppleMacWebKit to isAppleCocoaWebKit
429         https://bugs.webkit.org/show_bug.cgi?id=168075
430
431         Reviewed by Geoffrey Garen.
432
433         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
434
435         * Scripts/build-api-tests:
436         * Scripts/build-dumprendertree:
437         * Scripts/build-jsc:
438         (buildMyProject):
439         * Scripts/build-layouttestrelay:
440         * Scripts/build-webkit:
441         * Scripts/build-webkittestrunner:
442         * Scripts/run-api-tests:
443         (isSupportedPlatform):
444         (runTest):
445         (listAllTests):
446         (prepareEnvironmentForRunningTestTool):
447         * Scripts/run-content-extension-tester:
448         * Scripts/run-javascriptcore-tests:
449         * Scripts/run-minibrowser:
450         * Scripts/show-pretty-diff:
451         * Scripts/webkitdirs.pm:
452         (determineBaseProductDir):
453         (determineArchitecture):
454         (determinePassedArchitecture):
455         (safariPath):
456         (builtDylibPathForName):
457         (checkFrameworks):
458         (isAppleWebKit):
459         (isAppleCocoaWebKit):
460         (determineNmPath):
461         (launcherName):
462         (wrapperPrefixIfNeeded):
463         (isCMakeBuild):
464         (mobileSafariBundle):
465         (debugSafari):
466         (runSafari):
467         (runMiniBrowser):
468         (debugMiniBrowser):
469         (runWebKitTestRunner):
470         (debugWebKitTestRunner):
471         (isAppleMacWebKit): Deleted.
472         * Scripts/webkitperl/FeatureList.pm:
473
474 2017-02-09  Alex Christensen  <achristensen@webkit.org>
475
476         Revert r211991
477         https://bugs.webkit.org/show_bug.cgi?id=168062
478
479         * Scripts/build-webkit:
480         Not quite ready yet.
481
482 2017-02-09  Alex Christensen  <achristensen@webkit.org>
483
484         Build libwebrtc on bots without using it yet
485         https://bugs.webkit.org/show_bug.cgi?id=168062
486
487         Reviewed by Brent Fulgham.
488
489         * Scripts/build-webkit:
490         Build libwebrtc on Mac when we build ANGLE.
491
492 2017-02-09  Youenn Fablet  <youenn@apple.com>
493
494         Improve W3C importer command line options
495         https://bugs.webkit.org/show_bug.cgi?id=167448
496
497         Reviewed by Ryosuke Niwa.
498
499         Making the list of test paths to import the main arguments of the script.
500         Allow passing the source directory to import as a -s option.
501         Adding a warning when given test paths are skipped by default in ImportExpectations.
502
503         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
504         Link conversion rules do not change when imported tests are downloaded by the script.
505
506         * Scripts/webkitpy/w3c/test_importer.py:
507         (main):
508         (parse_args):
509         (TestImporter.__init__):
510         (TestImporter.do_import):
511         (TestImporter):
512         (TestImporter.check_imported_expectations):
513
514 2017-02-08  Chris Dumez  <cdumez@apple.com>
515
516         Update web-platform-tests resources
517         https://bugs.webkit.org/show_bug.cgi?id=168026
518
519         Reviewed by Youenn Fablet.
520
521         Stop copying testharness.js from resources/ to web-platform-tests/resources.
522
523         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
524         (WebPlatformTestServer._copy_webkit_test_files):
525
526 2017-02-08  Andy Estes  <aestes@apple.com>
527
528         Custom protocols should not continue loading after a network process crash
529         https://bugs.webkit.org/show_bug.cgi?id=168028
530         <rdar://problem/27607520>
531
532         Reviewed by Brady Eidson.
533
534         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
535         (processGroup):
536         (-[CloseWhileStartingProtocol startLoading]):
537         (-[CloseWhileStartingProtocol stopLoading]):
538         (TestWebKitAPI::runTest):
539         (TestWebKitAPI::TEST):
540
541 2017-02-08  Dan Bernstein  <mitz@apple.com>
542
543         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
544         https://bugs.webkit.org/show_bug.cgi?id=168031
545
546         Reviewed by Tim Horton.
547
548         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
549         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
550         (TEST):
551         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
552         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
553
554 2017-02-08  Chris Dumez  <cdumez@apple.com>
555
556         Use smaller tiles in windows that are not active to facilitate App Napping
557         https://bugs.webkit.org/show_bug.cgi?id=167997
558         <rdar://problem/30358835>
559
560         Reviewed by Simon Fraser.
561
562         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
563         (WTR::PlatformWebView::setWindowIsKey):
564         Actually update windowIsKey state of NSWindow so the WebView
565         properly updates its activity state.
566
567 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
568
569         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
570         https://bugs.webkit.org/show_bug.cgi?id=167942
571         <rdar://problem/30315079>
572
573         Reviewed by Tim Horton.
574
575         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
576         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
577         contenteditable in these cases.
578
579         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
580         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
581         performDragOperation:) directly.
582
583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
584         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
585         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
586         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
587         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
588         (-[DragSource draggingSourceOperationMaskForLocal:]):
589         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
590         (-[DragInfo lastMousePosition]):
591         (-[DragInfo setLastMousePosition:]):
592         (-[DragInfo draggingDestinationWindow]):
593         (-[DragInfo draggingSourceOperationMask]):
594         (-[DragInfo draggingLocation]):
595         (-[DragInfo draggedImageLocation]):
596         (-[DragInfo draggedImage]):
597         (-[DragInfo draggingPasteboard]):
598         (-[DragInfo draggingSource]):
599         (-[DragInfo draggingSequenceNumber]):
600         (-[DragInfo slideDraggedImageTo:]):
601         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
602         (-[DragInfo draggingFormation]):
603         (-[DragInfo setDraggingFormation:]):
604         (-[DragInfo animatesToDestination]):
605         (-[DragInfo setAnimatesToDestination:]):
606         (-[DragInfo numberOfValidItemsForDrop]):
607         (-[DragInfo setNumberOfValidItemsForDrop:]):
608         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
609         (-[DragInfo springLoadingHighlight]):
610         (-[DragInfo resetSpringLoading]):
611         (TestWebKitAPI::getTestImage):
612         (TestWebKitAPI::webViewAfterPerformingDragOperation):
613         (TestWebKitAPI::TEST):
614         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
615
616 2017-02-08  Jer Noble  <jer.noble@apple.com>
617
618         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
619         https://bugs.webkit.org/show_bug.cgi?id=168007
620
621         Reviewed by Alex Christensen.
622
623         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
624         (didFinishLoadForFrame):
625         (TestWebKitAPI::TEST):
626
627 2017-02-08  Commit Queue  <commit-queue@webkit.org>
628
629         Unreviewed, rolling out r211873.
630         https://bugs.webkit.org/show_bug.cgi?id=168001
631
632         It's in jhbuild for consistent layout tests (Requested by
633         mcatanzaro on #webkit).
634
635         Reverted changeset:
636
637         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
638         https://bugs.webkit.org/show_bug.cgi?id=167993
639         http://trac.webkit.org/changeset/211873
640
641 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
642
643         [GTK] Add icu packages to Tools/gtk/install-dependencies
644         https://bugs.webkit.org/show_bug.cgi?id=167993
645
646         Reviewed by Michael Catanzaro.
647
648         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
649         depending in the GNU/Linux distribution)
650
651 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
652
653         Update flakiness dashboard configuration.
654         https://bugs.webkit.org/show_bug.cgi?id=167957
655
656         Reviewed by Alexey Proskuryakov.
657
658         * TestResultServer/static-dashboards/builders.jsonp:
659
660 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
661
662         Replace a bot that has an incorrect configuration.
663         https://bugs.webkit.org/show_bug.cgi?id=167747
664
665         Rubber-stamped by Alexey Proskuryakov.
666
667         * BuildSlaveSupport/build.webkit.org-config/config.json:
668
669 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
670
671         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
672         https://bugs.webkit.org/show_bug.cgi?id=167927
673
674         Reviewed by Brent Fulgham.
675
676         Enable ComplexTextController API tests on the Win and GTK ports.
677
678         * TestWebKitAPI/PlatformGTK.cmake:
679         * TestWebKitAPI/PlatformWin.cmake:
680
681 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
682
683         File index appended to previous file in svn-create-patch with SVN 1.9
684         https://bugs.webkit.org/show_bug.cgi?id=167903
685         <rdar://problem/30387395>
686
687         Reviewed by Daniel Bates.
688
689         * Scripts/VCSUtils.pm:
690         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
691         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
692         trailing newline character from the expected result before comparing it to the actual result.
693
694 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
695
696         [webkitdirs] remove unused host_processor variable in determineArchitecture()
697         https://bugs.webkit.org/show_bug.cgi?id=167936
698
699         Reviewed by Michael Catanzaro.
700
701         * Scripts/webkitdirs.pm:
702         (determineArchitecture):
703         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
704         since r195083.
705
706 2017-02-07  Youenn Fablet  <youenn@apple.com>
707
708         Use a JSON file to define which WPT files/folders to import
709         https://bugs.webkit.org/show_bug.cgi?id=167923
710
711         Reviewed by Alex Christensen.
712
713         * Scripts/webkitpy/w3c/test_downloader.py:
714         (TestDownloader.__init__):
715         (TestDownloader._init_paths_from_expectations):
716         * Scripts/webkitpy/w3c/test_importer.py:
717         (parse_args):
718         * Scripts/webkitpy/w3c/test_importer_unittest.py:
719
720 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
721
722         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
723         https://bugs.webkit.org/show_bug.cgi?id=167916
724
725         Reviewed by Carlos Garcia Campos.
726
727         URL of mesa-11.0.6.tar.xz has been moved.
728
729         * gtk/jhbuild.modules: Fix the module path.
730
731 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
732
733         Static Analyzer: Address some leaks in MiniBrowser
734         https://bugs.webkit.org/show_bug.cgi?id=167897
735
736         Reviewed by Alexey Proskuryakov.
737
738         * MiniBrowser/mac/BrowserWindowController.m:
739         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
740         * MiniBrowser/mac/ExtensionManagerWindowController.m:
741         (-[ExtensionManagerWindowController add:]):
742         (-[ExtensionManagerWindowController remove:]):
743         * MiniBrowser/mac/SettingsController.m:
744         (-[SettingsController _populateMenu]):
745         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
746         Address obvious leaks caught by the static analyzer.
747
748 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
749
750         Migrate ComplexTextController to use platform-independent types
751         https://bugs.webkit.org/show_bug.cgi?id=167833
752
753         Reviewed by Brent Fulgham.
754
755         Migrate tests away from platform-dependent types.
756
757         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
758         (TestWebKitAPI::TEST_F):
759
760 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
761
762         Correct File Path Handling in SecurityOrigin and FileSystem
763         https://bugs.webkit.org/show_bug.cgi?id=167894
764         <rdar://problem/30380080>
765
766         Reviewed by Alexey Proskuryakov.
767
768         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
769         and perform same-volume checks using filesystem-compatible paths.        
770         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
771         filesystem paths, and perform validation of same-volume checks.
772         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
773         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
774         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
775         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
776
777 2017-02-06  Jer Noble  <jer.noble@apple.com>
778
779         Playback stalls when a SourceBuffer append causes frame eviction
780         https://bugs.webkit.org/show_bug.cgi?id=167834
781
782         Reviewed by Eric Carlson.
783
784         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
785         for the WTF::MediaTime class.
786
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
789         (TestWebKitAPI::TEST):
790         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
791         (WTF::operator<<):
792         (TestWebKitAPI::TestSample::create):
793         (TestWebKitAPI::TestSample::TestSample):
794         (TestWebKitAPI::TEST_F):
795
796 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
797
798         Change capitalization in platform name after r211735.
799
800         Unreviewed dashboard fix.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
803         (WebKitBuildbot):
804
805 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
806
807         Move the Leaks bot to Sierra
808         https://bugs.webkit.org/show_bug.cgi?id=167886
809
810         Reviewed by Daniel Bates.
811
812         * BuildSlaveSupport/build.webkit.org-config/config.json:
813         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
814         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
815         (LeaksViewer._displayURLPrompt):
816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
817         (WebKitBuildbot):
818
819 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
820
821         Prevent app crash on launch during simctl install workaround
822         https://bugs.webkit.org/show_bug.cgi?id=167685
823
824         Reviewed by Daniel Bates.
825
826         * Scripts/webkitpy/port/simulator_process.py:
827         (SimulatorProcess.__init__): Pass environment to install.
828         * Scripts/webkitpy/xcode/simulator.py:
829         (Device.install_app): Accept environment, pass environment to launch.
830
831 2017-02-06  Alex Christensen  <achristensen@webkit.org>
832
833         Rebase API tests after r211638
834         https://bugs.webkit.org/show_bug.cgi?id=167779
835
836         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
837         (TestWebKitAPI::TEST_F):
838         URLs with non-special schemes and characters like % in the host now fail to parse,
839         more like their special counterparts and according to spec.
840
841 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
842
843         Unreviewed trivial fix after r211697.
844         https://bugs.webkit.org/show_bug.cgi?id=167863
845
846         * Scripts/run-javascriptcore-tests:
847         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
848
849 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
850
851         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
852         https://bugs.webkit.org/show_bug.cgi?id=167850
853
854         Reviewed by Tim Horton.
855
856         * DumpRenderTree/TestRunner.cpp:
857         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
858
859 2017-02-04  Andreas Kling  <akling@apple.com>
860
861         Plug some leaks in TestController and UIScriptContext.
862         <https://webkit.org/b/167839>
863
864         Reviewed by Alexey Proskuryakov.
865
866         Fix a couple of the leaks seen on the leaks bot.
867
868         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
869         (UIScriptContext::runUIScript):
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
872         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
873
874 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
875
876         WK1 mouse events are missing movementX and movementY for pointerlock.
877         https://bugs.webkit.org/show_bug.cgi?id=167775
878         rdar://problem/30343810
879
880         Reviewed by Alexey Proskuryakov.
881
882         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
883
884         * DumpRenderTree/mac/EventSendingController.mm:
885         (-[EventSendingController mouseMoveToX:Y:]):
886         * WebKitTestRunner/mac/EventSenderProxy.mm:
887         (WTR::EventSenderProxy::mouseMoveTo):
888
889 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
890
891         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
892         https://bugs.webkit.org/show_bug.cgi?id=167774
893
894         Reviewed by Tim Horton.
895
896         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
897         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
898         web process are async, so the callback fires after the web process gets the new state.
899
900         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
901         (WTR::UIScriptController::removeViewFromWindow):
902         (WTR::UIScriptController::addViewToWindow):
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (createWebViewAndOffscreenWindow):
905         (resetWebViewToConsistentStateBeforeTesting):
906         * DumpRenderTree/mac/DumpRenderTreeMac.h:
907         * DumpRenderTree/mac/UIScriptControllerMac.mm:
908         (WTR::UIScriptController::removeViewFromWindow):
909         (WTR::UIScriptController::addViewToWindow):
910         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
911         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
912         (WTR::UIScriptController::removeViewFromWindow):
913         (WTR::UIScriptController::addViewToWindow):
914         * TestRunnerShared/UIScriptContext/UIScriptController.h:
915         * WebKitTestRunner/PlatformWebView.h:
916         * WebKitTestRunner/TestController.cpp:
917         (WTR::TestController::resetStateToConsistentValues):
918         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
919         (WTR::PlatformWebView::removeFromWindow):
920         (WTR::PlatformWebView::addToWindow):
921         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
922         (WTR::UIScriptController::removeViewFromWindow):
923         (WTR::UIScriptController::addViewToWindow):
924         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
925         (WTR::PlatformWebView::removeFromWindow):
926         (WTR::PlatformWebView::addToWindow):
927         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
928         (WTR::UIScriptController::removeViewFromWindow):
929         (WTR::UIScriptController::addViewToWindow):
930
931 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
932
933         Remove check for SkipSafariExecutableEntitlementChecks
934         https://bugs.webkit.org/show_bug.cgi?id=167762
935
936         Reviewed by Dan Bernstein.
937
938         Follow-up fix: don't break internal behavior.
939
940         * Scripts/webkitdirs.pm:
941         (safariPath):
942         (executableHasEntitlements): Deleted.
943         (safariPathFromSafariBundle): Deleted.
944         (installedSafariPath): Deleted.
945
946 2017-02-03  Daniel Bates  <dabates@apple.com>
947
948         [Mac][WK2] Add SPI to override the Content Security Policy of a page
949         https://bugs.webkit.org/show_bug.cgi?id=167810
950         <rdar://problem/30102568>
951
952         Reviewed by Anders Carlsson.
953
954         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
955
956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
957         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
958         (TEST):
959         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
960         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
961         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
962         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
963
964 2017-02-02  Alex Christensen  <achristensen@webkit.org>
965
966         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
967         https://bugs.webkit.org/show_bug.cgi?id=167773
968         <rdar://problem/30221102>
969
970         Reviewed by Ryosuke Niwa.
971
972         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
973         (TestWebKitAPI::TEST_F):
974
975 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
976
977         Remove check for SkipSafariExecutableEntitlementChecks
978         https://bugs.webkit.org/show_bug.cgi?id=167762
979         rdar://problem/22480673
980
981         Reviewed by Dan Bernstein.
982
983         * Scripts/webkitdirs.pm:
984         (safariPathFromSafariBundle):
985         (skipSafariExecutableEntitlementChecks): Deleted.
986
987 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
988
989         Undefined subroutine in svn-create-patch
990         https://bugs.webkit.org/show_bug.cgi?id=167742
991
992         Unreviewed build-fix after r211543.
993
994         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
995
996 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
997
998         Unreviewed. Fix jhbuild dependencies build.
999
1000         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1001         Patch updated.
1002
1003 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1004
1005         [EME][GStreamer] Fixed decryptor selection
1006         https://bugs.webkit.org/show_bug.cgi?id=167588
1007
1008         Reviewed by Žan Doberšek.
1009
1010         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1011
1012         * gtk/jhbuild.modules: Added patches to gstreamer and
1013         gst-plugins-good packages.
1014         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1015         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1016
1017 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1018
1019         Make run-benchmark script supports 'config' key in test plan.
1020         https://bugs.webkit.org/show_bug.cgi?id=167715
1021
1022         Reviewed by Ryosuke Niwa.
1023
1024         Add support for 'config' key in test paln.
1025         'config' key is a dictionary that specifies environment configurations while test is running.
1026         Specifies orientation to be portrait in MotionMark benchmark.
1027
1028         * Scripts/webkitpy/benchmark_runner/README.md:
1029         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1030         (BenchmarkRunner.__init__):
1031         (BenchmarkRunner._run_benchmark):
1032         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1033         (BrowserDriver.prepare_env):
1034         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1035         (LinuxBrowserDriver.prepare_env):
1036         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1037         (OSXBrowserDriver.prepare_env):
1038         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1039         (OSXSafariDriver.prepare_env):
1040         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1041
1042 2017-02-01  Daniel Bates  <dabates@apple.com>
1043
1044         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1045         https://bugs.webkit.org/show_bug.cgi?id=167169
1046
1047         Reviewed by David Kilzer.
1048
1049         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1050         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1051         header from the output of "svn diff" on a file that was copied or moved.
1052
1053         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1054         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1055         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1056         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1057         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1058         of a file with only a property change also does not contain any chunk range lines. Therefore
1059         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1060         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1061         we should directly test for the presence of a leading SVN diff header with an empty body and
1062         remove such lines from the diff.
1063
1064         * Scripts/VCSUtils.pm:
1065         (fixSVNPatchForAdditionWithHistory): Added.
1066         * Scripts/svn-create-patch:
1067         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1068         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1069         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1070
1071 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1072
1073         [Mac] Update CARingBuffer class
1074         https://bugs.webkit.org/show_bug.cgi?id=167656
1075
1076         Reviewed by Jer Noble.
1077
1078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1079         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1080         (TestWebKitAPI::CARingBufferTest::SetUp):
1081         (TestWebKitAPI::CARingBufferTest::setup):
1082         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1083         (TestWebKitAPI::CARingBufferTest::description):
1084         (TestWebKitAPI::CARingBufferTest::bufferList):
1085         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1086         (TestWebKitAPI::CARingBufferTest::capacity):
1087         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1088         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1089         (TestWebKitAPI::TEST_F):
1090         (TestWebKitAPI::MixingTest::run):
1091
1092 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1093
1094         [Mac] TestWebKitAPI includes system frameworks incorrectly
1095         https://bugs.webkit.org/show_bug.cgi?id=167703
1096         rdar://problem/30301498
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1101         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1102
1103         Also, reduced the number of subframework search paths, looks like we only need one now.
1104
1105         * TestWebKitAPI/Configurations/Base.xcconfig:
1106
1107 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1108
1109         Correct "filesHaveSameVolume" predicate
1110         https://bugs.webkit.org/show_bug.cgi?id=167696
1111         <rdar://problem/30298722>
1112
1113         Reviewed by David Kilzer.
1114
1115         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1116         percent-escaped path inputs.
1117
1118         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1119         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1120         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1121         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1122         (TestWebKitAPI::TEST_F):
1123
1124 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1125
1126         Unreviewed. Fix coding style in MiniBrowser
1127
1128         * MiniBrowser/gtk/BrowserWindow.c:
1129         (editingCommandCallback):
1130         (insertImageCommandCallback):
1131         (insertLinkCommandCallback):
1132
1133 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1134
1135         [GTK] Add an API to add a custom tab into the print dialog
1136         https://bugs.webkit.org/show_bug.cgi?id=151998
1137
1138         Reviewed by Carlos Garcia Campos.
1139
1140         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1141         that is testing a newly added API.
1142
1143         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1144         (testPrintCustomWidget):
1145         (beforeAll):
1146
1147 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1148
1149         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1150         https://bugs.webkit.org/show_bug.cgi?id=166529
1151
1152         Reviewed by Xabier Rodriguez-Calvar.
1153
1154         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1155         New patch version accepted in GStreamer upstream.
1156
1157 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1158
1159         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1160         https://bugs.webkit.org/show_bug.cgi?id=167498
1161
1162         Reviewed by Carlos Garcia Campos.
1163
1164         Depending on the distro version you can need either libxfont1-dev
1165         or libfont-dev to build with jhbuild.
1166
1167         * gtk/install-dependencies:
1168
1169 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1170
1171         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1172         https://bugs.webkit.org/show_bug.cgi?id=167594
1173
1174         Unreviewed test gardening.
1175
1176         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1177
1178         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1179         (TEST):
1180
1181 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1182
1183         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1184         https://bugs.webkit.org/show_bug.cgi?id=167676
1185
1186         Reviewed by Saam Barati.
1187
1188         * Scripts/run-javascriptcore-tests:
1189         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1190
1191 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1192
1193         Make Dump Render Tree not crash
1194         https://bugs.webkit.org/show_bug.cgi?id=167667
1195
1196         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1197         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1198         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1199         This does not fix any tests, it just fixes the crash.
1200         
1201         Reviewed by Simon Fraser.
1202
1203         * DumpRenderTree/TestRunner.cpp:
1204         (TestRunner::callUIScriptCallback):
1205
1206 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1207
1208         Workaround for simctl install failing to report install failure
1209         https://bugs.webkit.org/show_bug.cgi?id=167654
1210
1211         Reviewed by Daniel Bates.
1212
1213         simctl install will sometimes report success even though install has failed.
1214         To workaround this bug, we attempt an app launch after install to ensure
1215         install has succeeded.
1216
1217         * Scripts/webkitpy/xcode/simulator.py:
1218         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1219         (Device.launch_app): Correct comment.
1220
1221 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1222
1223         Unreviewed webkitpy fix after r211405.
1224
1225         * Scripts/webkitpy/xcode/simulator.py:
1226         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1227
1228 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1229
1230         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1231
1232         * gtk/manifest.txt.in:
1233
1234 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1235
1236         AX: enable search predication for iOS
1237         https://bugs.webkit.org/show_bug.cgi?id=167558
1238         <rdar://problem/30251367>
1239
1240         Reviewed by Joanmarie Diggs.
1241
1242         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1243         (AccessibilityUIElement::uiElementForSearchPredicate):
1244         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1245         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1246         (searchPredicateParameterizedAttributeForSearchCriteria):
1247         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1248         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1249         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1250         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1251         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1252         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1253         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1254         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1256         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1257         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1258
1259 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1260
1261         Workaround for simctl launch bug
1262         https://bugs.webkit.org/show_bug.cgi?id=167613
1263
1264         Reviewed by Daniel Bates.
1265
1266         simctl launch will sometimes fail because of a race condition when many
1267         simulators are being run simultaneously. These failures will always have
1268         an exit code of 1. This change attempts to launch an app multiple times
1269         before reporting a failure to workaround this bug.
1270
1271         * Scripts/webkitpy/xcode/simulator.py:
1272         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1273
1274 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1275
1276         Commit queue fails to look at real name aliases for the reviewer
1277         https://bugs.webkit.org/show_bug.cgi?id=167422
1278
1279         Reviewed by Joseph Pecoraro.
1280
1281         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1282         (test_has_valid_reviewer): Added tests.
1283
1284         * Scripts/webkitpy/common/config/committers.py:
1285         (CommitterList._name_to_contributor_map):
1286         Made _name_to_contributor_map include alias names.
1287
1288         * Scripts/webkitpy/common/config/committers_unittest.py:
1289         (CommittersTest.test_contributors_by_fuzzy_match):
1290         Removed subtests that are now obsolete, as these matches are strict. It is not
1291         obvious if distance based fuzzy matching for names is useful at all, but we can
1292         look into that some other time.
1293
1294 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1295
1296         QueueStatusServer should have an explicit timeout for _fetch_url
1297         https://bugs.webkit.org/show_bug.cgi?id=167467
1298
1299         Reviewed by Alexey Proskuryakov.
1300
1301         * Scripts/webkitpy/common/net/statusserver.py:
1302         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1303
1304 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1305
1306         Add support for Trac instances that host multiple projects.
1307         https://bugs.webkit.org/show_bug.cgi?id=167524
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         When multiple projects are hosted on a single Trac instance, the current
1312         behavior will retrieve changesets from all tracked projects.
1313         This patch teaches Trac.js to get project-specific changesets from Trac.
1314         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1315         when querying the Trac timeline.
1316
1317         To tell Trac to be aware of multi-project instances we leverage the 
1318         `options` parameter when creating a new instance: 
1319
1320             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1321
1322         If this option is not provided, the original behaviour will prevail.
1323         Additionally, add corresponding tests.
1324
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1326         (Trac): Reason about new optional parameter 'projectIdentifier'.
1327         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1328         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1329         replace default parameter `changeset=on` with `repo-projectname=on`.
1330         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1332         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1334         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1335         Add the following tests:
1336             test("revisionURL")
1337             test("revisionURL with Trac Identifier")
1338             test("_xmlTimelineURL")
1339             test("_xmlTimelineURL with Trac Identifier")
1340         (this.view._latestProductiveIteration): Fix missing ';'.
1341
1342 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1343
1344         Correct spacing regression on inter-element complex path shaping on some fonts
1345         https://bugs.webkit.org/show_bug.cgi?id=166013
1346
1347         Reviewed by Simon Fraser.
1348
1349         Unskip existing tests and make some new tests:
1350         - Testing complex text with no origins
1351         - Testing initial expansions
1352         - Testing the sign of vertical advances
1353
1354         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1355         (TestWebKitAPI::TEST_F):
1356
1357 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1358
1359         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1360         https://bugs.webkit.org/show_bug.cgi?id=167596
1361
1362         Reviewed by Daniel Bates.
1363
1364         We avoid needing a thin directory by invoking the zip program with
1365         the list of directories from the build directory to be zipped,
1366         and by using the zip feature to exclude files matching a pattern.
1367
1368         * BuildSlaveSupport/built-product-archive:
1369         (copyBuildFiles):
1370         (createZipFromList):
1371         (archiveBuiltProduct):
1372
1373 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1374
1375         Use simctl instead of LayoutTestRelay
1376         https://bugs.webkit.org/show_bug.cgi?id=165927
1377
1378         Reviewed by Daniel Bates.
1379
1380         Part 1
1381
1382         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1383         simulators through simctl (iOS 10 and later), use this functionality instead.
1384
1385         * Scripts/webkitpy/port/base.py:
1386         (Port.__init__): Added _test_runner_process_constructor.
1387         * Scripts/webkitpy/port/darwin.py:
1388         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1389         * Scripts/webkitpy/port/driver.py:
1390         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1391         (IOSSimulatorDriver): Deleted.
1392         * Scripts/webkitpy/port/driver_unittest.py:
1393         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1394         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1395         (DriverTest.test_start_actually_starts): Ditto.
1396         * Scripts/webkitpy/port/ios.py:
1397         (IOSSimulatorPort): Remove relay_name.
1398         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1399         (IOSSimulatorPort._create_simulators): Formatting change.
1400         (IOSSimulatorPort.relay_path): Deleted.
1401         (IOSSimulatorPort._check_relay): Deleted.
1402         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1403         (IOSSimulatorPort._build_relay): Deleted.
1404         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1405         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1406         * Scripts/webkitpy/port/ios_unittest.py:
1407         (iosTest.test_32bit): Update test.
1408         (iosTest.test_64bit): Update test.
1409         * Scripts/webkitpy/port/server_process.py:
1410         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1411         (ServerProcess._set_file_nonblocking): Added to share common code.
1412         * Scripts/webkitpy/port/server_process_mock.py:
1413         (MockServerProcess.__init__): Added argument worker_number.
1414         * Scripts/webkitpy/port/simulator_process.py: Added.
1415         (SimulatorProcess): Added.
1416         (SimulatorProcess.Popen): Added.
1417         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1418         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1419         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1420         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1421         (SimulatorProcess._reset): Added. Unlink fifos.
1422         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1423         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1424         * Scripts/webkitpy/xcode/simulator.py:
1425         (Device.__init__): Accept host to run install/launch/terminate.
1426         (Device.install_app): Install app to target Device.
1427         (Device.launch_app): Launch app on target Device.
1428         (Device.terminate_app): Shutdown app on target Device.
1429         (Simulator._parse_devices): Pass host to Device.
1430
1431 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1432
1433         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1434         https://bugs.webkit.org/show_bug.cgi?id=167411
1435
1436         Reviewed by Michael Catanzaro.
1437
1438         Disable the ARM iwMMXt fast path for pixman, because it triggers
1439         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1440
1441         * gtk/jhbuild.modules:
1442
1443 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1444
1445         [GTK] Add API to handle the accelerated compositing policy
1446         https://bugs.webkit.org/show_bug.cgi?id=167509
1447
1448         Reviewed by Michael Catanzaro.
1449
1450         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1451         as a special case. Also add test cases to the get/set API.
1452
1453         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1454         (hardwareAccelerationPolicyToString):
1455         (stringToHardwareAccelerationPolicy):
1456         (cellRendererChanged):
1457         (browserSettingsDialogConstructed):
1458         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1459         (testWebKitSettings):
1460
1461 2017-01-29  Andy Estes  <aestes@apple.com>
1462
1463         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1464         https://bugs.webkit.org/show_bug.cgi?id=167563
1465         <rdar://problem/30253207>
1466
1467         Reviewed by Andreas Kling.
1468
1469         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1470         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1471         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1472         (runTest):
1473         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1474         (TEST):
1475
1476 2017-01-29  Dan Bernstein  <mitz@apple.com>
1477
1478         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1479         https://bugs.webkit.org/show_bug.cgi?id=167565
1480
1481         Reviewed by Sam Weinig.
1482
1483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1484         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1485         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1486         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1487         (TEST):
1488         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1489         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1490         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1491         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1492
1493 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1494
1495         Add Link Preload as an off-by-default experimental feature menu item.
1496         https://bugs.webkit.org/show_bug.cgi?id=167201
1497
1498         Reviewed by Ryosuke Niwa.
1499
1500         * DumpRenderTree/mac/DumpRenderTree.mm:
1501         (resetWebPreferencesToConsistentValues):
1502         * DumpRenderTree/win/DumpRenderTree.cpp:
1503         (resetWebPreferencesToConsistentValues):
1504
1505 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1506
1507         Add User Timing Experimental Feature
1508         https://bugs.webkit.org/show_bug.cgi?id=167542
1509         <rdar://problem/22746307>
1510
1511         Reviewed by Ryosuke Niwa.
1512
1513         * DumpRenderTree/mac/DumpRenderTree.mm:
1514         (enableExperimentalFeatures):
1515         (resetWebPreferencesToConsistentValues):
1516         * DumpRenderTree/win/DumpRenderTree.cpp:
1517         (enableExperimentalFeatures):
1518
1519 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1520
1521         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1522         https://bugs.webkit.org/show_bug.cgi?id=167519
1523
1524         Reviewed by Ryosuke Niwa.
1525
1526         * QueueStatusServer/templates/statusbubble.html:
1527         To measure the bubbleContainer's width, it must not be wrapping based
1528         on its parent container. So when measuring the width temporarily set
1529         the parent to a very large width so as to not artificially wrap us.
1530         Restore the parent's width after measuring.
1531
1532 2017-01-27  Andy Estes  <aestes@apple.com>
1533
1534         [iOS] Add a test for _WKNSFileManagerExtras
1535         https://bugs.webkit.org/show_bug.cgi?id=167478
1536
1537         Reviewed by Andreas Kling.
1538
1539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1540         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1541         (expectAttributes):
1542         (TEST):
1543
1544 2017-01-27  Keith Miller  <keith_miller@apple.com>
1545
1546         run-benchmarks should make sure it passes the test url to the right application
1547         https://bugs.webkit.org/show_bug.cgi?id=167533
1548
1549         Reviewed by Joseph Pecoraro.
1550
1551         This fixes an issue when trying to run-benchmark script with the
1552         system default browser set to STP. Previously, it would run
1553         the test in STP rather than the provided build. Now, it should run
1554         in the provided build.
1555
1556         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1557         (OSXSafariDriver.launch_url):
1558
1559 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1560
1561         [Cocoa] Prepare ComplexTextController for unit testing
1562         https://bugs.webkit.org/show_bug.cgi?id=167493
1563
1564         Reviewed by Simon Fraser.
1565
1566         Addressing post-review comments from Simon Fraser.
1567
1568         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1569         (TestWebKitAPI::TEST_F):
1570
1571 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1572
1573         [Cocoa] Prepare ComplexTextController for unit testing
1574         https://bugs.webkit.org/show_bug.cgi?id=167493
1575
1576         Reviewed by Dean Jackson.
1577
1578         Create four unit tests.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1582         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1583         (TestWebKitAPI::TEST_F):
1584
1585 2017-01-26  Chris Dumez  <cdumez@apple.com>
1586
1587         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1588         https://bugs.webkit.org/show_bug.cgi?id=167421
1589         <rdar://problem/30188490>
1590
1591         Reviewed by Darin Adler.
1592
1593         Add a new setting allowing layout tests to enable PageCache in a window
1594         that has an opener, for convenience.
1595
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (resetWebPreferencesToConsistentValues):
1598         * DumpRenderTree/win/DumpRenderTree.cpp:
1599         (resetWebPreferencesToConsistentValues):
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::resetPreferencesToConsistentValues):
1602
1603 2017-01-26  Keith Miller  <keith_miller@apple.com>
1604
1605         classInfo should take a VM so it is not materialized from the object on each call
1606         https://bugs.webkit.org/show_bug.cgi?id=167424
1607
1608         Rubber Stamped by Michael Saboff.
1609
1610         Previously, classInfo() would get the VM from the target's
1611         MarkedBlock.  Most callers already have a VM on hand, so it is
1612         wasteful to compute the VM from the marked block every time. This
1613         patch refactors some of the most common callers of classInfo(),
1614         jsDynamicCast and inherits to take a VM as well.
1615
1616         * DumpRenderTree/TestRunner.cpp:
1617         (setAudioResultCallback):
1618
1619 2017-01-26  Jer Noble  <jer.noble@apple.com>
1620
1621         Autoplay muted videos stop playback of any streaming app in the background
1622         https://bugs.webkit.org/show_bug.cgi?id=163993
1623         <rdar://problem/29020431>
1624
1625         Reviewed by Eric Carlson.
1626
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1629         (TestWebKitAPI::TEST):
1630         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1631
1632 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1633
1634         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1635         https://bugs.webkit.org/show_bug.cgi?id=167466
1636
1637         Unreviewed test gardening.
1638
1639         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1640         (TEST):
1641
1642 2017-01-26  Matt Rajca  <mrajca@apple.com>
1643
1644         Notify clients when the user plays media otherwise prevented from autoplaying
1645         https://bugs.webkit.org/show_bug.cgi?id=167390
1646
1647         Reviewed by Alex Christensen.
1648
1649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1650         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1651         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1652         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1653         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1654         (TEST):
1655         * TestWebKitAPI/cocoa/TestWKWebView.h:
1656         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1657         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1658         (-[TestWKWebView waitForLoad]):
1659         (-[TestWKWebView mouseUpAtPoint:]):
1660         * WebKitTestRunner/TestController.cpp:
1661         (WTR::TestController::createOtherPage):
1662         (WTR::TestController::createWebViewWithOptions):
1663
1664 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1665
1666         Crash when setting custom scale factor.
1667         https://bugs.webkit.org/show_bug.cgi?id=167369
1668
1669         Reviewed by Sam Weinig.
1670
1671         Added API test.
1672
1673         * TestWebKitAPI/PlatformWin.cmake:
1674         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1675         (TestWebKitAPI::WebKitCreateInstance):
1676         (TestWebKitAPI::ScaleWebView::SetUp):
1677         (TestWebKitAPI::ScaleWebView::TearDown):
1678         (TestWebKitAPI::TEST_F):
1679
1680 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1681
1682         run-benchmark nests MotionMark results by the suite name twice
1683         https://bugs.webkit.org/show_bug.cgi?id=164948
1684
1685         Reviewed by Said Abou-Hallawa.
1686
1687         Use a single level MotionMark now that this is the name of the benchmark,
1688         and we no longer have tests that aren't part of the MotionMark suite.
1689
1690         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1691
1692 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1693
1694         Unreviewed, rolling out r211193.
1695
1696         This change broke internal builds.
1697
1698         Reverted changeset:
1699
1700         "Notify clients when the user plays media otherwise prevented
1701         from autoplaying"
1702         https://bugs.webkit.org/show_bug.cgi?id=167390
1703         http://trac.webkit.org/changeset/211193
1704
1705 2017-01-25  Matt Rajca  <mrajca@apple.com>
1706
1707         Notify clients when the user plays media otherwise prevented from autoplaying
1708         https://bugs.webkit.org/show_bug.cgi?id=167390
1709
1710         Reviewed by Alex Christensen.
1711
1712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1713         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1714         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1715         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1716         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1717         (TEST):
1718         * TestWebKitAPI/cocoa/TestWKWebView.h:
1719         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1720         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1721         (-[TestWKWebView waitForLoad]):
1722         (-[TestWKWebView mouseUpAtPoint:]):
1723         * WebKitTestRunner/TestController.cpp:
1724         (WTR::TestController::createOtherPage):
1725         (WTR::TestController::createWebViewWithOptions):
1726
1727 2017-01-25  Matt Rajca  <mrajca@apple.com>
1728
1729         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1730         https://bugs.webkit.org/show_bug.cgi?id=167385
1731
1732         Reviewed by Alex Christensen.
1733
1734         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1735         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1737         (TEST): Allow inline (rather than full screen) media playback on iOS.
1738
1739 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1740
1741         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1742         https://bugs.webkit.org/show_bug.cgi?id=167414
1743
1744         Reviewed by Michael Catanzaro.
1745
1746         Add a test case to check ephemeral web views don't write favicons to the database.
1747
1748         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1749         (ephemeralViewLoadChanged):
1750         (testPrivateBrowsing):
1751         (testFaviconDatabase):
1752
1753 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1754
1755         [GTK] Add a private browsing mode to MiniBrowser
1756         https://bugs.webkit.org/show_bug.cgi?id=167413
1757
1758         Reviewed by Michael Catanzaro.
1759
1760         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1761         private windows, even on non-private instances.
1762
1763         * MiniBrowser/gtk/BrowserWindow.c:
1764         (webViewTitleChanged): Add [Private] to title window for private windows.
1765         (webViewCreate): Pass web context to browser_window_new.
1766         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1767         (browserWindowFinalize): Disconnect web context signal handlers.
1768         (browser_window_init): Add shortcut for opening private window.
1769         (browser_window_new): It now receives the context and connect to download-started here.
1770         (browser_window_get_web_context): Return the context.
1771         * MiniBrowser/gtk/BrowserWindow.h:
1772         * MiniBrowser/gtk/main.c:
1773         (createBrowserTab): Create the web view for the window web context.
1774         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1775         (aboutDataHandleRequest): Ditto.
1776         (aboutURISchemeRequestCallback): Ditto.
1777         (main): Create ephemeral web context if private command line option is used.
1778
1779 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1780
1781         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1782         https://bugs.webkit.org/show_bug.cgi?id=167409
1783
1784         Reviewed by Antti Koivisto.
1785
1786         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1787         as well as tests for the newly added matchingElementInFlatTree.
1788
1789         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1790         (TestWebKitAPI::runJavaScriptAlert):
1791         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1792         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1793         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1794
1795 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1796
1797         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1798         https://bugs.webkit.org/show_bug.cgi?id=167370
1799
1800         Reviewed by Michael Catanzaro.
1801
1802         Add several test cases of ephemeral web views.
1803
1804         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1805         (testWebViewAuthenticationStorage):
1806         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1807         (ephemeralViewloadChanged):
1808         (testCookieManagerEphemeral):
1809         (beforeAll):
1810         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1811         (testWebKitSettings):
1812         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1813         (testWebContextEphemeral):
1814         (ephemeralViewloadChanged):
1815         (testWebContextProxySettings):
1816         (beforeAll):
1817         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1818         (ephemeralViewloadChanged):
1819         (testWebViewEphemeral):
1820         (beforeAll):
1821         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1822         (ephemeralViewloadChanged):
1823         (testWebsiteDataEphemeral):
1824         (beforeAll):
1825
1826 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1827
1828         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1829         https://bugs.webkit.org/show_bug.cgi?id=167402
1830
1831         Reviewed by Ryosuke Niwa.
1832
1833         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1834         (TestWebKitAPI::TEST):
1835
1836 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1837
1838         Add simple line layout toggle to MiniBrowser
1839         https://bugs.webkit.org/show_bug.cgi?id=167405
1840
1841         Reviewed by Andreas Kling.
1842
1843         * MiniBrowser/mac/SettingsController.h:
1844         * MiniBrowser/mac/SettingsController.m:
1845         (-[SettingsController _populateMenu]):
1846         (-[SettingsController validateMenuItem:]):
1847         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1848         (-[SettingsController simpleLineLayoutEnabled]):
1849         * MiniBrowser/mac/WK1BrowserWindowController.m:
1850         (-[WK1BrowserWindowController didChangeSettings]):
1851         * MiniBrowser/mac/WK2BrowserWindowController.m:
1852         (-[WK2BrowserWindowController didChangeSettings]):
1853
1854 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1855
1856         WKR does not include my nick when commit-queue lands my patch
1857         https://bugs.webkit.org/show_bug.cgi?id=167388
1858
1859         Reviewed by Ryosuke Niwa.
1860
1861         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1862         (NewCommitBot._summarize_commit_log):
1863         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1864         Perform nickname insertion before grabbing "Patch by" details.
1865         This way we can include the nickname with the full name.
1866
1867 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1868
1869         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1870         https://bugs.webkit.org/show_bug.cgi?id=167394
1871
1872         Reviewed by Ryosuke Niwa.
1873
1874         * Scripts/webkitperl/FeatureList.pm:
1875         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1876
1877 2017-01-24  Youenn Fablet  <youenn@apple.com>
1878
1879         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1880         https://bugs.webkit.org/show_bug.cgi?id=167353
1881
1882         Reviewed by Alex Christensen.
1883
1884         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1885         (CMakeGenerator.initialize_targets):
1886
1887 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1888
1889         WKR should not confuse Miguel Gomez with Andres Gomez
1890         https://bugs.webkit.org/show_bug.cgi?id=167389
1891
1892         Reviewed by Lucas Forschler.
1893
1894         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1895         "mAndres Gomez". Fix this.
1896
1897         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1898         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1899         space on each side of the email address, so expect both spaces to be there before
1900         considering the email for replacement.
1901         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1902
1903 2017-01-24  Matt Rajca  <mrajca@apple.com>
1904
1905         Pass down website autoplay policies to media elements
1906         https://bugs.webkit.org/show_bug.cgi?id=167355
1907
1908         Reviewed by Alex Christensen.
1909
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1912         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1913         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1914         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1915         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1916         (TEST):
1917
1918 2017-01-24  Nan Wang  <n_wang@apple.com>
1919
1920         AX: Speak Selection does not work in an iframe
1921         https://bugs.webkit.org/show_bug.cgi?id=166794
1922         <rdar://problem/29913013>
1923
1924         Reviewed by Chris Fleizach.
1925
1926         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1927         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1928         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1929         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1930         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1931         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1932         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1933         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1934         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1935         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1936         (-[TestRunnerWKWebView dealloc]):
1937         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1938         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1939         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1940         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1941         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1942
1943 2017-01-24  Daniel Bates  <dabates@apple.com>
1944
1945         StringView.split() should use an iterator design pattern instead of allocating a Vector
1946         https://bugs.webkit.org/show_bug.cgi?id=163225
1947
1948         Reviewed by Darin Adler.
1949
1950         Add unit tests for StringView.split().
1951
1952         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1953         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1954         used in the StringView.split() unit tests.
1955         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1956         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1957         object to a Vector of String objects.
1958         (TestWebKitAPI::TEST): Added the following tests:
1959             - WTF.StringViewSplitEmptyAndNullStrings
1960             - WTF.StringViewSplitBasic
1961             - WTF.StringViewSplitWithConsecutiveSeparators
1962
1963 2017-01-23  Anders Carlsson  <andersca@apple.com>
1964
1965         The Score Esports crashes on launch
1966         https://bugs.webkit.org/show_bug.cgi?id=167338
1967         rdar://problem/29948645
1968
1969         Reviewed by Dan Bernstein.
1970
1971         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1972         (TestWebKitAPI::TEST):
1973         Add a test.
1974
1975 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1976
1977         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1978         https://bugs.webkit.org/show_bug.cgi?id=146589
1979
1980         Reviewed by Michael Catanzaro.
1981
1982         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1983         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1984
1985         * MiniBrowser/gtk/BrowserWindow.c:
1986         (webViewDecidePolicy):
1987         (newTabCallback):
1988         * MiniBrowser/gtk/main.c:
1989         (createBrowserTab):
1990         (aboutDataRequestFree):
1991         (aboutDataRequestNew):
1992         (aboutDataRequestForView):
1993         (websiteDataRemovedCallback):
1994         (websiteDataClearedCallback):
1995         (aboutDataScriptMessageReceivedCallback):
1996         (domainListFree):
1997         (aboutDataFillTable):
1998         (gotWebsiteDataCallback):
1999         (aboutDataHandleRequest):
2000         (aboutURISchemeRequestCallback):
2001         (main):
2002         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2003         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2004         (serverCallback):
2005         (beforeAll):
2006         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2007         (serverCallback):
2008         (WebsiteDataTest::WebsiteDataTest):
2009         (WebsiteDataTest::~WebsiteDataTest):
2010         (WebsiteDataTest::fetch):
2011         (WebsiteDataTest::remove):
2012         (WebsiteDataTest::clear):
2013         (testWebsiteDataConfiguration):
2014         (testWebsiteDataCache):
2015         (testWebsiteDataStorage):
2016         (testWebsiteDataDatabases):
2017         (testWebsiteDataAppcache):
2018         (beforeAll):
2019         (afterAll):
2020
2021 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2022
2023         Unreviewed, rolling out r211062.
2024         https://bugs.webkit.org/show_bug.cgi?id=167354
2025
2026         broke API tests (Requested by alexchristensen on #webkit).
2027
2028         Reverted changeset:
2029
2030         "Pass down website autoplay policies to media elements"
2031         https://bugs.webkit.org/show_bug.cgi?id=167132
2032         http://trac.webkit.org/changeset/211062
2033
2034 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2035
2036         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2037         https://bugs.webkit.org/show_bug.cgi?id=167330
2038
2039         Reviewed by Tim Horton.
2040
2041         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2042         (TestWebKitAPI::TEST_F):
2043
2044 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2045
2046         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2047         https://bugs.webkit.org/show_bug.cgi?id=167317
2048
2049         Reviewed by Sam Weinig.
2050
2051         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2052         (TestWebKitAPI::TEST_F):
2053
2054 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2055
2056         svn-create-patch should emit properties when files are moved or copied
2057         https://bugs.webkit.org/show_bug.cgi?id=167264
2058
2059         Reviewed by Daniel Bates.
2060
2061         * Scripts/svn-create-patch:
2062         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2063
2064 2017-01-23  Youenn Fablet  <youenn@apple.com>
2065
2066         [WebRTC] Filter libwebrtc link flags
2067         https://bugs.webkit.org/show_bug.cgi?id=167287
2068
2069         Reviewed by Alex Christensen.
2070
2071         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2072         (CMakeGenerator._compute_link_flags):
2073         (CMakeGenerator._compute_link_flags.keep_flag):
2074         (CMakeGenerator._generate_compile_target_options):
2075
2076 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2077
2078         [WebRTC] Make VP8 optional in libwebrtc
2079         https://bugs.webkit.org/show_bug.cgi?id=167257
2080
2081         Reviewed by Darin Adler.
2082
2083         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2084         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2085
2086 2017-01-23  Jer Noble  <jer.noble@apple.com>
2087
2088         Video details does not apear and missing scrubber in Control Center
2089         https://bugs.webkit.org/show_bug.cgi?id=167233
2090
2091         Reviewed by Alex Christensen.
2092
2093         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2094         NowPlayingControlTests for iOS.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2098         (-[NowPlayingTestWebView setWindowVisible:]):
2099         (TestWebKitAPI::TEST):
2100         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2102         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2103         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2104         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2105         (SOFT_LINK_CLASS):
2106         (-[TestMessageHandler addMessage:withHandler:]):
2107         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2108         (__simulated_forceClickAssociatedEventsMask):
2109         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2110         (-[TestWKWebViewHostWindow isKeyWindow]):
2111         (-[TestWKWebViewHostWindow makeKeyWindow]):
2112         (-[TestWKWebViewHostWindow resignKeyWindow]):
2113         (-[TestWKWebView initWithFrame:]):
2114         (-[TestWKWebView initWithFrame:configuration:]):
2115         (-[TestWKWebView _setUpTestWindow:]):
2116         (-[TestWKWebView performAfterReceivingMessage:action:]):
2117         (-[TestWKWebView loadTestPageNamed:]):
2118         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2119         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2120         (-[TestWKWebView waitForMessage:]):
2121         (-[TestWKWebView performAfterLoading:]):
2122         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2123         (-[TestWKWebView typeCharacter:]):
2124
2125 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2126
2127         Unreviewed. Bring back gtk-doc error messages after r209981.
2128
2129         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2130         impossible to know what's wrong.
2131
2132         * gtk/gtkdoc.py:
2133         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2134
2135 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2136
2137         [WebRTC] Update build system to make G711 optional in libwebrtc
2138         https://bugs.webkit.org/show_bug.cgi?id=167256
2139
2140         Reviewed by Alex Christensen.
2141
2142         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2143         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2144
2145 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2146
2147         Cleanup RuntimeEnabledFeatures
2148         https://bugs.webkit.org/show_bug.cgi?id=167228
2149
2150         Reviewed by Simon Fraser.
2151
2152         * DumpRenderTree/mac/DumpRenderTree.mm:
2153         (enableExperimentalFeatures):
2154         (resetWebPreferencesToConsistentValues):
2155         (setWebPreferencesForTestOptions):
2156         (resetWebViewToConsistentStateBeforeTesting):
2157         * DumpRenderTree/win/DumpRenderTree.cpp:
2158         (enableExperimentalFeatures):
2159         (resetWebPreferencesToConsistentValues):
2160         More closely match WebKitTestRunner initialization of preferences
2161         for experimental features.
2162
2163 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2164
2165         Build Fix for Windows DumpRenderTree after r210976
2166         https://bugs.webkit.org/show_bug.cgi?id=167115
2167
2168         * DumpRenderTree/win/DumpRenderTree.cpp:
2169         (resetWebPreferencesToConsistentValues):
2170
2171 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2172
2173         Remove outdated ENABLE(CSP_NEXT) build flag
2174         https://bugs.webkit.org/show_bug.cgi?id=167252
2175
2176         Reviewed by Brent Fulgham.
2177
2178         * Scripts/webkitperl/FeatureList.pm:
2179         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2180
2181 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2182
2183         Build Fix for Windows DumpRenderTree after r210976
2184
2185         * DumpRenderTree/win/DumpRenderTree.cpp:
2186         (resetWebPreferencesToConsistentValues):
2187
2188 2017-01-20  Antoine Quint  <graouts@apple.com>
2189
2190         Web Animations should be off by default and enabled as an experimental feature
2191         https://bugs.webkit.org/show_bug.cgi?id=167115
2192         <rdar://problem/30048963>
2193
2194         Reviewed by Joseph Pecoraro.
2195
2196         Turn Web Animations on in DRT.
2197
2198         * DumpRenderTree/mac/DumpRenderTree.mm:
2199         (resetWebPreferencesToConsistentValues):
2200         * DumpRenderTree/win/DumpRenderTree.cpp:
2201         (resetWebPreferencesToConsistentValues):
2202
2203 2017-01-20  Youenn Fablet  <youenn@apple.com>
2204
2205         [WebRTC] Add libwebrtc build infrastructure
2206         https://bugs.webkit.org/show_bug.cgi?id=167207
2207
2208         Reviewed by Alex Christensen.
2209
2210         Adding a script doing the libwebrtc project json to CMake file conversion.
2211
2212         * Scripts/generate-libwebrtc-cmake: Added.
2213         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2214         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2215
2216 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2217
2218         Mini Browser: Show tooltip for Experimental Features
2219         https://bugs.webkit.org/show_bug.cgi?id=167225
2220
2221         Reviewed by Alex Christensen.
2222
2223         * MiniBrowser/mac/SettingsController.m:
2224         (-[SettingsController _populateMenu]):
2225         Include the full details string as a tooltip.
2226
2227 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2228
2229         [Win] Test output results should not be written twice.
2230         https://bugs.webkit.org/show_bug.cgi?id=167197
2231
2232         Reviewed by Brent Fulgham.
2233
2234         Prevent test output from being written twice by returning early from
2235         the dump() function, if it already has been called.
2236         This patch also adds a missing newline to a test output line. 
2237         
2238         * DumpRenderTree/win/DumpRenderTree.cpp:
2239         (dump):
2240
2241 2017-01-20  Antoine Quint  <graouts@apple.com>
2242
2243         [Modern Media Controls] Turn modern media controls on by default
2244         https://bugs.webkit.org/show_bug.cgi?id=165668
2245
2246         Reviewed by Dean Jackson.
2247
2248         Enabled modern media controls by default in test runners.
2249
2250         * DumpRenderTree/TestOptions.h:
2251         * WebKitTestRunner/TestOptions.h:
2252
2253 2017-01-19  Chris Dumez  <cdumez@apple.com>
2254
2255         iterable<> should be enabled on WK1
2256         https://bugs.webkit.org/show_bug.cgi?id=167221
2257         <rdar://problem/30108531>
2258
2259         Reviewed by Youenn Fablet.
2260
2261         * DumpRenderTree/mac/DumpRenderTree.mm:
2262         (resetWebPreferencesToConsistentValues):
2263         * DumpRenderTree/win/DumpRenderTree.cpp:
2264         (resetWebPreferencesToConsistentValues):
2265         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2266         (WTR::InjectedBundle::beginTesting):
2267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2268         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2270
2271 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2272
2273         Ensure status server logs go to log file
2274         https://bugs.webkit.org/show_bug.cgi?id=167210
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         * Scripts/webkitpy/common/net/statusserver.py:
2279         (StatusServer.next_work_item): Change log level from debug to info in
2280         order to facilitate deubgging issues.
2281         (StatusServer.update_work_items): Same.
2282
2283 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2284
2285         Additional selection tests and interpolation fix
2286         https://bugs.webkit.org/show_bug.cgi?id=167171
2287
2288         Reviewed by Simon Fraser.
2289
2290         We weren't adding the final event when interpolating event streams.
2291
2292         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2293         (-[HIDEventGenerator interpolatedEvents:]):
2294
2295 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2296
2297         [Cocoa] Variation fonts are erroneously disabled on iOS
2298         https://bugs.webkit.org/show_bug.cgi?id=167172
2299
2300         Reviewed by Simon Fraser.
2301
2302         OpenSource builders don't seem to understand sdk=embedded*.
2303
2304         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2305
2306 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2307
2308         Unreviewed. Fix GTK+ unit tests failing since r210531.
2309
2310         Avoid using paths to files that don't actually exist.
2311
2312         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2313         (testWebKitConsoleMessageNetworkError):
2314         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2315         (testContextMenuDefaultMenu):
2316         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2317         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2318         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2319
2320 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2321
2322         [GTK] Provide API to set proxy settings
2323         https://bugs.webkit.org/show_bug.cgi?id=128674
2324
2325         Reviewed by Michael Catanzaro.
2326
2327         Add tests for new proxy settings API.
2328
2329         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2330         (serverCallback):
2331         (ProxyTest::ProxyTest):
2332         (ProxyTest::~ProxyTest):
2333         (ProxyTest::loadURIAndGetMainResourceData):
2334         (ProxyTest::proxyServerPortAsString):
2335         (testWebContextProxySettings):
2336         (beforeAll):
2337
2338 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2339
2340         Add back my old email address so old commits will still match it.
2341
2342         * Scripts/webkitpy/common/config/contributors.json:
2343
2344 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2345
2346         Remove my old email address from contributors.json and watchlist.
2347
2348         * Scripts/validate-committer-lists:
2349         (CommitterListFromGit): Change the mapping to the correct email.
2350         * Scripts/webkitpy/common/config/contributors.json:
2351         * Scripts/webkitpy/common/config/watchlist:
2352
2353 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2354
2355         Unreviewed, rolling out r210848.
2356
2357         This change introduced media-related LayoutTest failures and
2358         crashes on macOS.
2359
2360         Reverted changeset:
2361
2362         "[Modern Media Controls] Turn modern media controls on by
2363         default"
2364         https://bugs.webkit.org/show_bug.cgi?id=165668
2365         http://trac.webkit.org/changeset/210848
2366
2367 2017-01-18  Andreas Kling  <akling@apple.com>
2368
2369         Document::securityOrigin() should return a reference.
2370         <https://webkit.org/b/167124>
2371
2372         Reviewed by Sam Weinig.
2373
2374         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2375         (TestWebKitAPI::TEST_F):
2376
2377 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2378
2379         [Win] Clipboard tests are flaky.
2380         https://bugs.webkit.org/show_bug.cgi?id=167088
2381
2382         Reviewed by Brent Fulgham.
2383
2384         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2385         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2386
2387         * DumpRenderTree/win/DumpRenderTree.cpp:
2388         (main):
2389
2390 2017-01-18  Antoine Quint  <graouts@apple.com>
2391
2392         [Modern Media Controls] Turn modern media controls on by default
2393         https://bugs.webkit.org/show_bug.cgi?id=165668
2394
2395         Reviewed by Dean Jackson.
2396
2397         Enabled modern media controls by default in test runners. 
2398
2399         * DumpRenderTree/TestOptions.h:
2400         * WebKitTestRunner/TestOptions.h:
2401
2402 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2403
2404         Unreviewed, rolling out r210834
2405         https://bugs.webkit.org/show_bug.cgi?id=165668
2406
2407         It introduced dozens of test timeouts.
2408
2409         Reverted changeset:
2410         "[Modern Media Controls] Turn modern media controls on by default"
2411         https://bugs.webkit.org/show_bug.cgi?id=165668
2412         http://trac.webkit.org/changeset/210834
2413
2414 2017-01-17  Antoine Quint  <graouts@apple.com>
2415
2416         [Modern Media Controls] Turn modern media controls on by default
2417         https://bugs.webkit.org/show_bug.cgi?id=165668
2418
2419         Reviewed by Dean Jackson.
2420
2421         Enabled modern media controls by default in test runners. 
2422
2423         * DumpRenderTree/TestOptions.h:
2424         * WebKitTestRunner/TestOptions.h:
2425
2426 2017-01-17  Chris Dumez  <cdumez@apple.com>
2427
2428         Document title changed twice when setting document.title
2429         https://bugs.webkit.org/show_bug.cgi?id=167065
2430
2431         Reviewed by Darin Adler.
2432
2433         Add WebKit2GTK API test that was written by Michael Catanzaro.
2434
2435         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2436         (testWebViewTitleChange):
2437         (beforeAll):
2438
2439 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2440
2441         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2442         https://bugs.webkit.org/show_bug.cgi?id=116551
2443         <rdar://problem/13949830>
2444
2445         Reviewed by Alex Christensen.
2446
2447         * Scripts/webkitperl/FeatureList.pm:
2448         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2449         that is part of the existing WEB_TIMING feature.
2450
2451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2452
2453 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2454
2455         'webkit-patch post' no longer works with moved/copied files
2456         https://bugs.webkit.org/show_bug.cgi?id=166914
2457         <rdar://problem/29979707>
2458
2459         Reviewed by Daniel Bates.
2460
2461         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2462         file outputs only the "Index:" line with an empty body.  This workaround
2463         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2464         public email list tracking this bug is below.
2465         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2466         
2467
2468         * Scripts/svn-create-patch:
2469         (generateDiff): Ignore an "Index:" line with an empty body.
2470
2471 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2472
2473         Remove the REQUEST_ANIMATION_FRAME flag
2474         https://bugs.webkit.org/show_bug.cgi?id=156980
2475         <rdar://problem/25906849>
2476
2477         Reviewed by Simon Fraser.
2478
2479         * Scripts/webkitperl/FeatureList.pm:
2480         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2481
2482 2017-01-15  Sam Weinig  <sam@webkit.org>
2483
2484         Add the ability to use numbers in makeString()
2485         https://bugs.webkit.org/show_bug.cgi?id=167087
2486
2487         Reviewed by Darin Adler.
2488
2489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2490         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2491         Add tests for StringConcatenate, focusing on new numeric additions.
2492
2493 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2494
2495         Unreviewed, remove stale comment.
2496
2497         This test was fixed by r163173.
2498
2499         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2500
2501 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2502
2503         Annotate large string tests with largeHeap
2504         https://bugs.webkit.org/show_bug.cgi?id=167054
2505
2506         Reviewed by Filip Pizlo.
2507
2508         * Scripts/run-javascriptcore-tests:
2509         * Scripts/run-jsc-stress-tests:
2510
2511 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2512
2513         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2514         https://bugs.webkit.org/show_bug.cgi?id=167043
2515
2516         Reviewed by Darin Adler.
2517
2518         * Scripts/webkitperl/FeatureList.pm:
2519
2520 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2521
2522         Remove ENABLE(DETAILS_ELEMENT) guards
2523         https://bugs.webkit.org/show_bug.cgi?id=167042
2524
2525         Reviewed by Alex Christensen.
2526
2527         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2528
2529 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2530
2531         26 MotionMark performance tests failing
2532         https://bugs.webkit.org/show_bug.cgi?id=166854
2533
2534         Reviewed by Ryosuke Niwa.
2535
2536         Unrelated change. This is the last place that we need to rename Animometer
2537         to MotionMark.
2538
2539         * Scripts/webkitpy/common/config/watchlist:
2540
2541 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2542
2543         run-jsc-benchmarks' echo should have -e option
2544         https://bugs.webkit.org/show_bug.cgi?id=167009
2545
2546         Reviewed by Sam Weinig.
2547
2548         echo requires `-e` option to use escape sequence.
2549         Without it, in some environment (in my Fedora 25), the escape sequence is not
2550         recognized and just dumped as `\c` etc.
2551
2552         * Scripts/run-jsc-benchmarks:
2553
2554 2017-01-12  Chris Dumez  <cdumez@apple.com>
2555
2556         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2557         https://bugs.webkit.org/show_bug.cgi?id=166995
2558
2559         Reviewed by Jer Noble.
2560
2561         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2562         as some people are having trouble building without it.
2563
2564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2565
2566 2017-01-12  Sam Weinig  <sam@webkit.org>
2567
2568         Add the ability to filter the set of bindings tests you want to run
2569         https://bugs.webkit.org/show_bug.cgi?id=166977
2570
2571         Reviewed by Tim Horton.
2572
2573         Allows doing things like:
2574             run-bindings-tests TestObj* TestCEReactions*
2575         
2576         to run only those tests that match the patterns.
2577
2578         * Scripts/run-bindings-tests:
2579         (main):
2580         Switch to using optparse and pass the remaining args as the filters.
2581
2582         * Scripts/webkitpy/bindings/main.py:
2583         (BindingsTests.__init__):
2584         Store the pattens.
2585
2586         (BindingsTests.test_matches_patterns):
2587         Add helper predicate to determine if a test should be run. When no
2588         patterns are present, all tests should run.
2589
2590         (BindingsTests.run_tests):
2591         Filter tests using the passed in patterns.
2592
2593 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2594
2595         Followup fix after r210503.
2596         https://bugs.webkit.org/show_bug.cgi?id=166887
2597
2598         Reviewed by Alex Christensen.
2599
2600         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2601         duplicated file handle on Windows. This patch fixes the remaining call sites.
2602
2603         * DumpRenderTree/PixelDumpSupport.cpp:
2604         * DumpRenderTree/TestRunner.cpp:
2605         (TestRunner::waitToDumpWatchdogTimerFired):
2606         * DumpRenderTree/TestRunner.h:
2607         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2608         * DumpRenderTree/win/DumpRenderTree.cpp:
2609         * DumpRenderTree/win/DumpRenderTreeWin.h:
2610         * DumpRenderTree/win/TestRunnerWin.cpp:
2611         (TestRunner::setSpellCheckerLoggingEnabled):
2612
2613 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2614
2615         Add committer status for Megan
2616         https://bugs.webkit.org/show_bug.cgi?id=166954
2617
2618         Reviewed by Tim Horton.
2619
2620         Add committer status for Megan Gardner
2621
2622         * Scripts/webkitpy/common/config/contributors.json:
2623
2624 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2625
2626         Unreviewed test fix after r210599.
2627
2628         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2629         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2630
2631 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2632
2633         Unreviewed build fix after r210599.
2634
2635         Add missing files.
2636
2637         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2638         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2639
2640 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2641
2642         File scheme should not allow access of a resource on a different volume.
2643         https://bugs.webkit.org/show_bug.cgi?id=158552
2644         <rdar://problem/15307582>
2645
2646         Reviewed by Alex Christensen.
2647
2648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2649         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2650         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2651
2652 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2653
2654         Unreviewed, rolling out r210571.
2655
2656         This change broke the 32-bit macOS build and caused LayoutTest
2657         failures.
2658
2659         Reverted changeset:
2660
2661         "File scheme should not allow access of a resource on a
2662         different volume."
2663         https://bugs.webkit.org/show_bug.cgi?id=158552
2664         http://trac.webkit.org/changeset/210571
2665
2666 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2667
2668         [GTK] install-dependencies script misses gdb
2669         https://bugs.webkit.org/show_bug.cgi?id=166917
2670
2671         Reviewed by Michael Catanzaro.
2672
2673         gdb is needed for generating the crash logs.
2674
2675         * gtk/install-dependencies:
2676
2677 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2678
2679         [GTK] No way for applications to set notification permissions without waiting for permission request
2680         https://bugs.webkit.org/show_bug.cgi?id=163366
2681
2682         Reviewed by Carlos Garcia Campos.
2683
2684         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2685         (testWebViewNotification):
2686         (setInitialNotificationPermissionsAllowedCallback):
2687         (setInitialNotificationPermissionsDisallowedCallback):
2688         (testWebViewNotificationInitialPermissionAllowed):
2689         (testWebViewNotificationInitialPermissionDisallowed):
2690         (beforeAll):
2691         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2692         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2693         (WebViewTest::WebViewTest):
2694         (WebViewTest::initializeWebView):
2695         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2696
2697 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2698
2699         MobileMiniBrowser tests don't work by default
2700         https://bugs.webkit.org/show_bug.cgi?id=166910
2701
2702         Reviewed by Alex Christensen.
2703
2704         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2705         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2706
2707 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2708
2709         File scheme should not allow access of a resource on a different volume.
2710         https://bugs.webkit.org/show_bug.cgi?id=158552
2711         <rdar://problem/15307582>
2712
2713         Reviewed by Alex Christensen.
2714
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2716         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2717         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2718
2719 2017-01-10  Mark Lam  <mark.lam@apple.com>
2720
2721         Reverting run-jsc-stress-tests' $buildType to use string values.
2722         https://bugs.webkit.org/show_bug.cgi?id=166912
2723
2724         Rubber stamped by Filip Pizlo.
2725
2726         This is so that we can test for it in the tests e.g.
2727         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2728
2729         * Scripts/run-jsc-stress-tests:
2730
2731 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2732
2733         Temporarily add back the file removed in r210463 to unbreak internal bots.
2734
2735         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2736
2737 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2738
2739         svn-apply failed to apply a patch (deleting file with svn property)
2740         https://bugs.webkit.org/show_bug.cgi?id=165953
2741
2742         Reviewed by Daniel Bates.
2743
2744         * Scripts/VCSUtils.pm:
2745         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2746         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2747
2748 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2749
2750         Update flakiness dashboard configuration.
2751         https://bugs.webkit.org/show_bug.cgi?id=166869
2752
2753         Reviewed by Alexey Proskuryakov.
2754
2755         * TestResultServer/static-dashboards/builders.jsonp:
2756         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2757
2758 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2759
2760         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2761         https://bugs.webkit.org/show_bug.cgi?id=165232
2762
2763         Unreviewed follow-up patch after r210539 and r210523.
2764
2765         Instead of using that environment variable, the argument
2766         --display-server=xorg should be passed now.
2767
2768         The GTK+ performance bot was the only bot using this, and is
2769         already passing --display-server=xorg after r210539.
2770
2771         * Scripts/webkitpy/port/gtk.py:
2772         (GtkPort._driver_class):
2773
2774 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2775
2776         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2777         https://bugs.webkit.org/show_bug.cgi?id=166872
2778
2779         Reviewed by Michael Catanzaro.
2780
2781         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2782         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2783         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2784         The step RunWebKitTests already has support for it.
2785
2786         * BuildSlaveSupport/build.webkit.org-config/config.json:
2787         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2788         (RunGtkAPITests.start):
2789         (RunAndUploadPerfTests.start):
2790         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2791
2792 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2793
2794         Unreviewed, rolling out r210531.
2795
2796         This change broke the 32-bit macOS build and caused LayoutTest
2797         failures.
2798
2799         Reverted changeset:
2800
2801         "File scheme should not allow access of a resource on a
2802         different volume."
2803         https://bugs.webkit.org/show_bug.cgi?id=158552
2804         http://trac.webkit.org/changeset/210531
2805
2806 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2807
2808         File scheme should not allow access of a resource on a different volume.
2809         https://bugs.webkit.org/show_bug.cgi?id=158552
2810         <rdar://problem/15307582>
2811
2812         Reviewed by Alex Christensen.
2813
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2815         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2816         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2817
2818 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2819
2820         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2821         https://bugs.webkit.org/show_bug.cgi?id=165232
2822
2823         Reviewed by Michael Catanzaro.
2824
2825         Add a new WaylandDriver to run the tests in the user current wayland session.
2826
2827         Also merge all the configuration options for selecting the display server inside one
2828         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2829
2830         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2831
2832         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2833         (TestRunner._create_driver):
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2835         (parse_args):
2836         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2837         (PerfTestsRunner._parse_args):
2838         * Scripts/webkitpy/port/gtk.py:
2839         (GtkPort.__init__):
2840         (GtkPort._driver_class):
2841         (GtkPort._search_paths):
2842         * Scripts/webkitpy/port/waylanddriver.py: Added.
2843         (WaylandDriver):
2844         (WaylandDriver.check_driver):
2845         (WaylandDriver._setup_environ_for_test):
2846         (WaylandDriver._start):
2847
2848 2017-01-09  Andy Estes  <aestes@apple.com>
2849
2850         [QuickLook] Add a layout test for webkit.org/b/135651
2851         https://bugs.webkit.org/show_bug.cgi?id=166855
2852
2853         Reviewed by Andreas Kling.
2854
2855         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2856         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2857         errors with code WebKitErrorCannotShowURL.
2858         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2859         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2860         not specific to WebKit2 error codes.
2861
2862 2017-01-09  Antoine Quint  <graouts@apple.com>
2863
2864         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2865         https://bugs.webkit.org/show_bug.cgi?id=166837
2866
2867         Reviewed by Alex Christensen.
2868
2869         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2870         the provided value when trying to determine the path to the test file. Failing
2871         that, we use the computed URL or the raw path provided to cover all cases.
2872         
2873         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2874         by applying this patch and seeing the number test failures dramatically reduced
2875         with WK1 due to the option to turn modern media controls off for older media controls
2876         tests.
2877
2878         * DumpRenderTree/DumpRenderTree.h:
2879         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2880         (parseInputLine):
2881         * DumpRenderTree/TestOptions.h:
2882         * DumpRenderTree/TestOptions.mm:
2883         (TestOptions::TestOptions):
2884         * DumpRenderTree/mac/DumpRenderTree.mm:
2885         (runTest):
2886
2887 2017-01-09  Milan Crha  <mcrha@redhat.com>
2888
2889         prepare-ChangeLog: Correct help string for --style option
2890         https://bugs.webkit.org/show_bug.cgi?id=166725
2891
2892         Reviewed by Alexey Proskuryakov.
2893
2894         * Scripts/prepare-ChangeLog:
2895         (main):
2896
2897 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2898
2899         https://bugs.webkit.org/show_bug.cgi?id=166839
2900         Add php7 support for macOS.
2901         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2902
2903         Reviewed by Alexey Proskuryakov.
2904
2905         * Scripts/webkitpy/port/base.py:
2906         (Port._is_darwin_php_version_7):
2907         (Port._debian_php_version):
2908         (Port):
2909         (Port._darwin_php_version):
2910         (Port._apache_config_file_name_for_platform):
2911
2912 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2913
2914         [GTK] Should support key and code properties on keyboard events
2915         https://bugs.webkit.org/show_bug.cgi?id=166759
2916
2917         Reviewed by Carlos Garcia Campos.
2918
2919         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2920         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2921         on tests.
2922
2923 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2924
2925         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2926         https://bugs.webkit.org/show_bug.cgi?id=166760
2927
2928         Reviewed by Darin Adler.
2929
2930         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2931         We can work around that by duplicating and redirecting stdout.
2932
2933         * DumpRenderTree/PixelDumpSupport.cpp:
2934         (dumpWebViewAsPixelsAndCompareWithExpected):
2935         (printPNG):
2936         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2937         (logEventProc):
2938         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2939         (DRTDesktopNotificationPresenter::showDesktopNotification):
2940         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2941         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2942         * DumpRenderTree/win/DumpRenderTree.cpp:
2943         (dumpFrameScrollPosition):
2944         (dumpHistoryItem):
2945         (dumpBackForwardList):
2946         (dump):
2947         (runTest):
2948         (main):
2949         * DumpRenderTree/win/DumpRenderTreeWin.h:
2950         * DumpRenderTree/win/EditingDelegate.cpp:
2951         (EditingDelegate::shouldBeginEditingInDOMRange):
2952         (EditingDelegate::shouldEndEditingInDOMRange):
2953         (EditingDelegate::shouldInsertNode):
2954         (EditingDelegate::shouldInsertText):
2955         (EditingDelegate::shouldDeleteDOMRange):
2956         (EditingDelegate::shouldChangeSelectedDOMRange):
2957         (EditingDelegate::shouldApplyStyle):
2958         (EditingDelegate::shouldChangeTypingStyle):
2959         (EditingDelegate::doPlatformCommand):
2960         (EditingDelegate::webViewDidBeginEditing):
2961         (EditingDelegate::webViewDidChange):
2962         (EditingDelegate::webViewDidEndEditing):
2963         (EditingDelegate::webViewDidChangeTypingStyle):
2964         (EditingDelegate::webViewDidChangeSelection):
2965         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2966         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2967         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2968         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2969         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2970         (FrameLoadDelegate::didCommitLoadForFrame):
2971         (FrameLoadDelegate::didReceiveTitle):
2972         (FrameLoadDelegate::didFinishLoadForFrame):
2973         (FrameLoadDelegate::didFailLoadWithError):
2974         (FrameLoadDelegate::willPerformClientRedirectToURL):
2975         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2976         (FrameLoadDelegate::windowScriptObjectAvailable):
2977         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2978         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2979         (FrameLoadDelegate::didDisplayInsecureContent):
2980         (FrameLoadDelegate::didRunInsecureContent):
2981         (FrameLoadDelegate::webViewProgressFinishedNotification):
2982         * DumpRenderTree/win/HistoryDelegate.cpp:
2983         (HistoryDelegate::didNavigateWithNavigationData):
2984         (HistoryDelegate::didPerformClientRedirectFromURL):
2985         (HistoryDelegate::didPerformServerRedirectFromURL):
2986         (HistoryDelegate::updateHistoryTitle):
2987         (HistoryDelegate::populateVisitedLinksForWebView):
2988         * DumpRenderTree/win/PolicyDelegate.cpp:
2989         (PolicyDelegate::decidePolicyForNavigationAction):
2990         (PolicyDelegate::unableToImplementPolicyWithError):
2991         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2992         (ResourceLoadDelegate::willSendRequest):
2993         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2994         (ResourceLoadDelegate::didReceiveResponse):
2995         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2996         (ResourceLoadDelegate::didFailLoadingWithError):
2997         * DumpRenderTree/win/TestRunnerWin.cpp:
2998         (TestRunner::addDisallowedURL):
2999         (TestRunner::originsWithApplicationCache):
3000         (TestRunner::setStorageDatabaseIdleInterval):
3001         (TestRunner::closeIdleLocalStorageDatabases):
3002         (TestRunner::copyDecodedHostName):
3003         (TestRunner::copyEncodedHostName):
3004         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3005         (TestRunner::isGeolocationProviderActive):
3006         (TestRunner::pathToLocalResource):
3007         (TestRunner::setMockDeviceOrientation):
3008         (TestRunner::setMockGeolocationPosition):
3009         (TestRunner::setMockGeolocationPositionUnavailableError):
3010         (TestRunner::setSpatialNavigationEnabled):
3011         (TestRunner::setAutomaticLinkDetectionEnabled):
3012         (TestRunner::isCommandEnabled):
3013         (TestRunner::authenticateSession):
3014         (TestRunner::addChromeInputField):
3015         (TestRunner::removeChromeInputField):
3016         (TestRunner::focusWebView):
3017         (TestRunner::grantWebNotificationPermission):
3018         (TestRunner::denyWebNotificationPermission):
3019         (TestRunner::removeAllWebNotificationPermissions):
3020         (TestRunner::simulateWebNotificationClick):
3021         (TestRunner::imageCountInGeneralPasteboard):
3022         * DumpRenderTree/win/UIDelegate.cpp:
3023         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3024         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3025         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3026         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3027         (UIDelegate::webViewAddMessageToConsole):
3028         (UIDelegate::exceededDatabaseQuota):
3029         (UIDelegate::setStatusText):
3030         (UIDelegate::didPressMissingPluginButton):
3031
3032 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3033
3034         Add a setting to create editable MiniBrowser windows by default
3035         https://bugs.webkit.org/show_bug.cgi?id=166806
3036
3037         Reviewed by Beth Dakin.
3038
3039         * MiniBrowser/mac/AppDelegate.m:
3040         (-[BrowserAppDelegate createBrowserWindowController:]):
3041         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3042         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3043         * MiniBrowser/mac/SettingsController.h:
3044         * MiniBrowser/mac/SettingsController.m:
3045         (-[SettingsController _populateMenu]):
3046         (-[SettingsController validateMenuItem:]):
3047         (-[SettingsController toggleCreateEditorByDefault:]):
3048         (-[SettingsController createEditorByDefault]):
3049         Add a setting and update the key equivalents accordingly.
3050         Also make sure to make the right kind of window on launch.
3051
3052 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3053
3054         Fix the 32-bit build.
3055
3056         * MiniBrowser/mac/BrowserWindowController.h:
3057         * MiniBrowser/mac/BrowserWindowController.m:
3058
3059 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3060
3061         Fix the 32-bit build.
3062
3063         * MiniBrowser/mac/BrowserWindowController.m:
3064
3065 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3066
3067         Make it possible to drop HTML files on the MiniBrowser icon
3068         https://bugs.webkit.org/show_bug.cgi?id=166802
3069
3070         Reviewed by Simon Fraser.
3071
3072         * MiniBrowser/mac/AppDelegate.m:
3073         (-[BrowserAppDelegate application:openFile:]):
3074         * MiniBrowser/mac/Info.plist:
3075         If you're using an editable window, the usual trick of dropping on the
3076         window doesn't work anymore (it makes an <attachment> instead).
3077
3078 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3079
3080         MiniBrowser window gets smaller each time it is instantiated
3081         https://bugs.webkit.org/show_bug.cgi?id=166807
3082
3083         Reviewed by Andy Estes.
3084
3085         * MiniBrowser/mac/BrowserWindowController.m:
3086         (-[BrowserWindowController windowDidLoad]):
3087         * MiniBrowser/mac/BrowserWindow.xib:
3088         Turn on full-window content view support with IB, instead of waiting
3089         until after the views have been loaded. This seems to resolve the
3090         longstanding ever-shrinking-window problem.
3091
3092 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3093
3094         Add indent/outdent items to MiniBrowser's new format menu
3095         https://bugs.webkit.org/show_bug.cgi?id=166805
3096
3097         Reviewed by Dan Bernstein.
3098
3099         * MiniBrowser/mac/MainMenu.xib:
3100
3101 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3102
3103         Add a stock Format menu to MiniBrowser
3104         https://bugs.webkit.org/show_bug.cgi?id=166804
3105
3106         Reviewed by Andy Estes.
3107
3108         * MiniBrowser/mac/MainMenu.xib:
3109         Many of the features automatically work with editable web views.
3110         However, this seems to expose a bug where none of the font-related features
3111         (Cmd-B, for example) work until the first time the font panel is shown,
3112         per process, which will need to be investigated separately.
3113
3114 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3115
3116         Remove unused applicationWillTerminate methods from MiniBrowser
3117         https://bugs.webkit.org/show_bug.cgi?id=166803
3118
3119         Reviewed by Andy Estes.
3120
3121         * MiniBrowser/mac/AppDelegate.m:
3122         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3123         * MiniBrowser/mac/BrowserWindowController.h:
3124         * MiniBrowser/mac/BrowserWindowController.m:
3125         (-[BrowserWindowController applicationTerminating]): Deleted.
3126         * MiniBrowser/mac/WK1BrowserWindowController.m:
3127         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3128         * MiniBrowser/mac/WK2BrowserWindowController.m:
3129         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3130
3131 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3132
3133         Add the ability to create empty contentEditable windows in MiniBrowser
3134         https://bugs.webkit.org/show_bug.cgi?id=166801
3135
3136         Reviewed by Wenson Hsieh.
3137
3138         * MiniBrowser/mac/AppDelegate.h:
3139         * MiniBrowser/mac/AppDelegate.m:
3140         (-[BrowserAppDelegate createBrowserWindowController:]):
3141         (-[BrowserAppDelegate newWindow:]):
3142         (-[BrowserAppDelegate newEditorWindow:]):
3143         (-[BrowserAppDelegate openDocument:]):
3144         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3145         * MiniBrowser/mac/BrowserWindowController.h:
3146         * MiniBrowser/mac/BrowserWindowController.m:
3147         (-[BrowserWindowController loadHTMLString:]):
3148         (-[BrowserWindowController toggleEditable:]):
3149         * MiniBrowser/mac/MainMenu.xib:
3150         * MiniBrowser/mac/WK1BrowserWindowController.m:
3151         (-[WK1BrowserWindowController awakeFromNib]):
3152         (-[WK1BrowserWindowController loadHTMLString:]):
3153         (-[WK1BrowserWindowController validateMenuItem:]):
3154         (-[WK1BrowserWindowController setEditable:]):
3155         (-[WK1BrowserWindowController updateTitle:]):
3156         * MiniBrowser/mac/WK2BrowserWindowController.m:
3157         (-[WK2BrowserWindowController awakeFromNib]):
3158         (-[WK2BrowserWindowController validateMenuItem:]):
3159         (-[WK2BrowserWindowController setEditable:]):
3160         (-[WK2BrowserWindowController updateTitle:]):
3161         (-[WK2BrowserWindowController loadHTMLString:]):
3162         Merge more functionality from WebEditingTester.
3163         Add two menu items for creating empty editable WebKit1/2 windows.
3164         Add a menu item to the Edit menu to toggle editability on any window.
3165
3166 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3167
3168         Implement find-in-page in MiniBrowser
3169         https://bugs.webkit.org/show_bug.cgi?id=166799
3170
3171         Reviewed by Andy Estes.
3172
3173         * MiniBrowser/mac/BrowserWindow.xib:
3174         * MiniBrowser/mac/BrowserWindowController.h:
3175         * MiniBrowser/mac/BrowserWindowController.m:
3176         (-[BrowserWindowController find:]): Deleted.
3177         * MiniBrowser/mac/MainMenu.xib:
3178         * MiniBrowser/mac/WK1BrowserWindowController.m:
3179         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3180         (-[WK1BrowserWindowController find:]): Deleted.
3181         * MiniBrowser/mac/WK2BrowserWindowController.m:
3182         (-[WK2BrowserWindowController awakeFromNib]):
3183         (-[WK2BrowserWindowController dealloc]):
3184         (-[WK2BrowserWindowController validateMenuItem:]):
3185         (-[WK2BrowserWindowController performTextFinderAction:]):
3186         (-[WK2BrowserWindowController findBarView]):
3187         (-[WK2BrowserWindowController setFindBarView:]):
3188         (-[WK2BrowserWindowController isFindBarVisible]):
3189         (-[WK2BrowserWindowController setFindBarVisible:]):
3190         (-[WK2BrowserWindowController contentView]):
3191         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3192         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3193         (-[WK2BrowserWindowController find:]): Deleted.
3194         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3195         protocol. At first glance, it's pretty broken, but vaguely works.
3196
3197 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3198
3199         Share the implementation of MiniBrowser view hiding functionality
3200         https://bugs.webkit.org/show_bug.cgi?id=166800
3201
3202         Reviewed by Andy Estes.
3203
3204         * MiniBrowser/mac/BrowserWindowController.m:
3205         (-[BrowserWindowController showHideWebView:]):
3206         (-[BrowserWindowController removeReinsertWebView:]):
3207         * MiniBrowser/mac/WK1BrowserWindowController.m:
3208         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3209         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3212         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3213         Move the implementation of these two things to the shared superclass,
3214         since they don't depend on WebKit-specific things.
3215         Also, there was no reason to retain the (WK)WebView while it was unparented,
3216         as the BrowserWindowController maintains a reference the entire time.
3217
3218 2017-01-06  Andy Estes  <aestes@apple.com>
3219
3220         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3221         https://bugs.webkit.org/show_bug.cgi?id=166789
3222
3223         Reviewed by Alex Christensen.
3224
3225         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3226         * DumpRenderTree/PlatformMac.cmake:
3227         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3228         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3229         * DumpRenderTree/mac/DumpRenderTree.mm:
3230         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3231         createXMLStringFromWebArchiveData().
3232         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3233         * WebKitTestRunner/Configurations/Base.xcconfig:
3234         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3236         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3237         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3238         createXMLStringFromWebArchiveData().
3239         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3240         * WebKitTestRunner/PlatformMac.cmake:
3241         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3242         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3243
3244 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3245
3246         Minor cleanups to IndentOutdentCommand and related code
3247         https://bugs.webkit.org/show_bug.cgi?id=166791
3248
3249         Reviewed by Simon Fraser.
3250
3251         * WebEditingTester/EditingOperations.m:
3252         (editingOperations):
3253         Add the outdent operation to WebEditingTester.
3254
3255 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3256
3257         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3258         https://bugs.webkit.org/show_bug.cgi?id=166785
3259
3260         Reviewed by Ryosuke Niwa.
3261
3262         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3263         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3264
3265 2017-01-06  Antoine Quint  <graouts@apple.com>
3266
3267         Support webkit-test-runner key-value pairs in http tests
3268         https://bugs.webkit.org/show_bug.cgi?id=149812
3269
3270         Reviewed by Alex Christensen.
3271
3272         We pass the absolute path for a test through to WKTR so that we can parse
3273         tests that are running as URLs for webkit-test-runner options.
3274
3275         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3276         (parseInputLine):
3277
3278         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3279
3280         * Scripts/webkitpy/port/driver.py:
3281         (Driver._command_from_driver_input):
3282
3283         Pass the absolute path to the file through the CLI.
3284
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::updateTestOptionsFromTestHeader):
3287         (WTR::TestController::testOptionsForTest):
3288         (WTR::parseInputLine):
3289         (WTR::TestController::runTest):
3290         * WebKitTestRunner/TestController.h:
3291
3292 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3293
3294         Warning about unconnectable outlets when opening a MiniBrowser window
3295         https://bugs.webkit.org/show_bug.cgi?id=166756
3296
3297         Reviewed by Dan Bernstein.
3298
3299         * MiniBrowser/mac/BrowserWindow.xib:
3300         When launching MiniBrowser, it says:
3301         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3302             (MBToolbarItem): missing setter or instance variable
3303         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3304             (NSButtonCell): missing setter or instance variable.
3305
3306         It looks like someone added the connection from the share button
3307         to the BrowserWindowController three times; only one of the connections
3308         is valid. Remove the other two.
3309
3310 2017-01-05  Keith Rollin  <krollin@apple.com>
3311
3312         Add WebCore::URL::protocolHostAndPort
3313         https://bugs.webkit.org/show_bug.cgi?id=166426
3314
3315         Reviewed by Alex Christensen.
3316
3317         Add test for protocolHostAndPort.
3318
3319         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3320         (TestWebKitAPI::TEST_F):
3321
3322 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3323
3324         [Win] Archive test result is failing.
3325         https://bugs.webkit.org/show_bug.cgi?id=166720
3326
3327         Reviewed by Alex Christensen.
3328
3329         Deleting the layout test result folder is sometimes failing
3330         on Windows. This is not a critical error.
3331
3332         * BuildSlaveSupport/test-result-archive:
3333         (archiveTestResults):
3334
3335 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3336
3337         [GTK] Minibrowser: Add printing support
3338         https://bugs.webkit.org/show_bug.cgi?id=165298
3339
3340         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3341         an error during the print, it's printed on the console.
3342
3343         Reviewed by Michael Catanzaro.
3344
3345         * MiniBrowser/gtk/BrowserWindow.c:
3346         (webKitPrintOperationFailedCallback):
3347         (printPage):
3348         (browser_window_init):
3349
3350 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3351
3352         [css-grid] Fix crash clamping grid lines
3353         https://bugs.webkit.org/show_bug.cgi?id=166637
3354
3355         Reviewed by Darin Adler.
3356
3357         Creates new unit test to verify that the maximum tracks limit
3358         is used in GridPosition too.
3359
3360         * TestWebKitAPI/PlatformEfl.cmake:
3361         * TestWebKitAPI/PlatformGTK.cmake:
3362         * TestWebKitAPI/PlatformWin.cmake:
3363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3364         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3365         (TestWebKitAPI::TEST):
3366
3367 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3368
3369         Move editing history scripts to WebCore PrivateHeaders
3370         https://bugs.webkit.org/show_bug.cgi?id=166709
3371         <rdar://problem/29876612>
3372
3373         Reviewed by Dan Bernstein.
3374
3375         Update references to editing script files in WebCore that were moved.
3376
3377         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3378
3379 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3380
3381         Unreviewed, build fix after r210313 part 2
3382         https://bugs.webkit.org/show_bug.cgi?id=166676
3383
3384         Add 'U' suffix.
3385
3386         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3387         (TestWebKitAPI::TEST):
3388         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3389         (TestWebKitAPI::TEST):
3390
3391 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3392
3393         Limit thread name appropriately
3394         https://bugs.webkit.org/show_bug.cgi?id=166676
3395
3396         Reviewed by Sam Weinig.
3397
3398         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3401         (TestWebKitAPI::TEST):
3402
3403 2017-01-04  Andy Estes  <aestes@apple.com>
3404
3405         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3406         https://bugs.webkit.org/show_bug.cgi?id=166696
3407
3408         Reviewed by Tim Horton.
3409
3410         * TestWebKitAPI/PlatformGTK.cmake:
3411         * TestWebKitAPI/PlatformWin.cmake:
3412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3413         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3414         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3415         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3416         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3417         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3418         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3419
3420 2017-01-03  Brian Burg  <bburg@apple.com>
3421
3422         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3423         https://bugs.webkit.org/show_bug.cgi?id=166003
3424         <rdar://problem/28718990>
3425
3426         Reviewed by Joseph Pecoraro.
3427
3428         Teach run-inspector-generator-tests to generate test output using the platform name
3429         derived from the directory that the test is in. For example, tests in the /generic/
3430         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3431
3432         * Scripts/webkitpy/inspector/main.py:
3433         (InspectorGeneratorTests.generate_from_json):
3434         (InspectorGeneratorTests.run_tests):
3435         (InspectorGeneratorTests.main):
3436
3437 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3438
3439         Unreviewed cmake buildfix after r210266.
3440
3441         * DumpRenderTree/PlatformMac.cmake:
3442
3443 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3444
3445         Provide a setting for clients to always prefer low-power WebGL
3446         https://bugs.webkit.org/show_bug.cgi?id=166675
3447         <rdar://problem/29834093>
3448
3449         Reviewed by Dan Bernstein.
3450
3451         * MiniBrowser/mac/Info.plist:
3452         Have MiniBrowser claim to be a modern app that supports
3453         automatic graphics switching. WebKit needs to support automatic
3454         graphics switching, so our test app might as well. Without this
3455         Info.plist parameter, this change has no effect, and bringing up
3456         a WebGL context still brings up the discrete GPU (also true of the
3457         existing web-exposed preferLowPowerToHighPerformance API).
3458
3459 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3460
3461         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3462         https://bugs.webkit.org/show_bug.cgi?id=166645
3463
3464         Reviewed by Carlos Garcia Campos.
3465
3466         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3467         (TestWebKitAPI::TEST):
3468
3469 2017-01-03  Andy Estes  <aestes@apple.com>
3470
3471         Place all the Cocoa WebCore API tests in the same directory
3472         https://bugs.webkit.org/show_bug.cgi?id=166673
3473
3474         Reviewed by Michael Catanzaro.
3475
3476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3477         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3478         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3479         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3480
3481 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3482
3483         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3484         https://bugs.webkit.org/show_bug.cgi?id=166450
3485         <rdar://problem/29447824>
3486
3487         Reviewed by Darin Adler.
3488
3489         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3490         * DumpRenderTree/TestRunner.cpp:
3491         (TestRunner::staticFunctions):
3492         * DumpRenderTree/mac/TestRunnerMac.mm:
3493         (setSpellCheckerLoggingEnabledCallback):
3494         * DumpRenderTree/win/TestRunnerWin.cpp:
3495         (setSpellCheckerLoggingEnabledCallback):
3496         * DumpRenderTree/mac/DumpRenderTree.mm:
3497         (resetWebViewToConsistentStateBeforeTesting):
3498         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3499         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3500         (stringForCorrectionResponse):
3501         (drt_NSSpellChecker_recordResponseToCorrection):
3502         (swizzleNSSpellCheckerMethodsIfNeeded):
3503         (setSpellCheckerLoggingEnabled):
3504         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3505         set to true, logs to stdout (which ends up in the test result) whenever
3506         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3507         is called, and then calls the original method. It is reset to false between tests.
3508
3509 2017-01-03  Sam Weinig  <sam@webkit.org>
3510
3511         Make WTF::Expected support Ref template parameters
3512         https://bugs.webkit.org/show_bug.cgi?id=166662
3513
3514         Reviewed by Alex Christensen.
3515
3516         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3517         (TestWebKitAPI::TEST):
3518         Add tests for using Ref with Expected.
3519
3520 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3521
3522         [GTK] Expose WebKitSecurityOrigin API
3523         https://bugs.webkit.org/show_bug.cgi?id=166632
3524
3525         Reviewed by Carlos Garcia Campos.
3526
3527         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3528         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3529         (testSecurityOriginBasicConstructor):
3530         (testSecurityOriginURIConstructor):
3531         (testSecurityOriginDefaultPort):
3532         (testSecurityOriginFileURI):
3533         (testSecurityOriginDataURI):
3534         (beforeAll):
3535         (afterAll):
3536
3537 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3538
3539         [GTK] HTTP auth layout tests are flaky
3540         https://bugs.webkit.org/show_bug.cgi?id=158919
3541
3542         Reviewed by Michael Catanzaro.
3543
3544         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3545         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3546         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3547         missing valac in the bots.
3548
3549 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3550
3551         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3552         https://bugs.webkit.org/show_bug.cgi?id=165797
3553
3554         Reviewed by Michael Catanzaro.
3555
3556         Move directory ruleset after all exclude rules of Source rulset.
3557
3558         * gtk/manifest.txt.in:
3559
3560 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3561
3562         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3563         https://bugs.webkit.org/show_bug.cgi?id=166636
3564
3565         Reviewed by Darin Adler.
3566
3567         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3568         (TestWebKitAPI::TEST):
3569
3570 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3571
3572         [GTK] WebCore/CSSParser unit test is not being built
3573         https://bugs.webkit.org/show_bug.cgi?id=166492
3574
3575         Reviewed by Michael Catanzaro.
3576
3577         This test was introduced in r175930, but we were not building
3578         it on GTK+ port since r176015.
3579         This patch marks the test to be built again on GTK+.
3580         JFTR, the test is passing right now.
3581
3582         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3583         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3584
3585 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3586
3587         AX: Expose block quote level to iOS API
3588         https://bugs.webkit.org/show_bug.cgi?id=166629
3589         <rdar://problem/29834793>
3590
3591         Reviewed by Darin Adler.
3592
3593         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3594         (AccessibilityUIElement::numberAttributeValue):
3595         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3596         (WTR::AccessibilityUIElement::numberAttributeValue):
3597
3598 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3599
3600         SecurityOrigin::create triplet constructor does not canonicalize port
3601         https://bugs.webkit.org/show_bug.cgi?id=166624
3602
3603         Reviewed by Daniel Bates.
3604
3605         * TestWebKitAPI/PlatformGTK.cmake:
3606         * TestWebKitAPI/PlatformWin.cmake:
3607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3608         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3609         (TestWebKitAPI::SecurityOriginTest::SetUp):
3610         (TestWebKitAPI::TEST_F):
3611
3612 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3613
3614         [GTK] Improve user agent construction
3615         https://bugs.webkit.org/show_bug.cgi?id=142074
3616
3617         Reviewed by Carlos Garcia Campos.
3618
3619         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3620         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3621         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3622         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3623         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3624         (TestWebKitAPI::TEST):
3625
3626 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3627
3628         [GTK] Improve user agent construction
3629         https://bugs.webkit.org/show_bug.cgi?id=142074
3630
3631         Reviewed by Carlos Garcia Campos.
3632
3633         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3634         (TestWebKitAPI::TEST):
3635
3636 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3637
3638         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3639         https://bugs.webkit.org/show_bug.cgi?id=166472
3640         rdar://problem/29675551
3641
3642         Reviewed by Tim Horton.
3643
3644         These changes are necessary to allow the mouse to leave the WTR window while
3645         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3646         (which DRT does); we'd always go through mouseMoved, which hits an early return
3647         in WebViewImpl::mouseMoved() when the point is outside the view.
3648
3649         * WebKitTestRunner/mac/EventSenderProxy.mm:
3650         (WTR::EventSenderProxy::mouseMoveTo):
3651
3652 2016-12-23  Andy Estes  <aestes@apple.com>
3653
3654         [iOS] Fix some crashing webarchive tests
3655         https://bugs.webkit.org/show_bug.cgi?id=166470
3656
3657         Reviewed by Andreas Kling.
3658
3659         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3660         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3661         so this change uses that on both platforms.
3662
3663         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3664         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3665         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3666         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3667         * WebKitTestRunner/PlatformMac.cmake:
3668         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3669         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3670
3671 2016-12-22  Saam Barati  <sbarati@apple.com>
3672
3673         WebAssembly: Silence the output of the spec-tests
3674         https://bugs.webkit.org/show_bug.cgi?id=166417
3675
3676         Reviewed by Mark Lam.
3677
3678         * Scripts/run-jsc-stress-tests:
3679
3680 2016-12-22  Zhuo Li  <zachli@apple.com>
3681
3682         [Cocoa] SPI for setloadsImagesAutomatically.
3683         https://bugs.webkit.org/show_bug.cgi?id=166401.
3684
3685         Reviewed by Darin Adler.
3686
3687         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3688         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3689         _loadsImagesAutomatically returns YES.
3690
3691 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3692
3693         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3694         https://bugs.webkit.org/show_bug.cgi?id=161328
3695         <rdar://problem/28475977>
3696
3697         Reviewed by Darin Adler.
3698
3699         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3700         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3701         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3702         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3703         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3704         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3705         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3706         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3707         we finish running a test and before we load the next test.
3708
3709         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3710         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3711         previous test started zooming and then finished before zooming completed. Since this happens before the next
3712         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3713
3714         * WebKitTestRunner/ios/TestControllerIOS.mm:
3715         (WTR::TestController::platformResetStateToConsistentValues):
3716
3717 2016-12-22  Jer Noble  <jer.noble@apple.com>
3718
3719         Muted media element playback should not interrupt other audio playback
3720         https://bugs.webkit.org/show_bug.cgi?id=166347
3721
3722         Reviewed by Eric Carlson.
3723
3724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3725         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3726         (TestWebKitAPI::TEST):
3727         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3728
3729 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3730
3731         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3732         https://bugs.webkit.org/show_bug.cgi?id=166346
3733
3734         Reviewed by Carlos Garcia Campos.
3735
3736         Enable WebRTC by default to simplify testing.
3737
3738         * MiniBrowser/gtk/main.c:
3739         (main):
3740
3741 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3742
3743         REGRESSION: API test failure: WKWebView.LocalStorageClear
3744         https://bugs.webkit.org/show_bug.cgi?id=166032
3745         <rdar://problem/29758423>
3746
3747         Reviewed by Simon Fraser.
3748
3749         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3750         to ensure that the view is destroyed before the callback fires.
3751
3752         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3753         (TEST):
3754
3755 2016-12-21  Saam Barati  <sbarati@apple.com>
3756
3757         WebAssembly: Import spec tests
3758         https://bugs.webkit.org/show_bug.cgi?id=166395
3759
3760         Rubber stamped by Keith Miller.
3761
3762         * Scripts/run-jsc-stress-tests:
3763
3764 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3765
3766         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3767         https://bugs.webkit.org/show_bug.cgi?id=166033
3768         <rdar://problem/29758428>
3769
3770         Reviewed by Simon Fraser.
3771
3772         Add an @autoreleasepool around the code that allocates the WKWebView, 
3773         so that it can be destroyed by removing the last reference in _downloadDidStart.
3774
3775         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3776         (TEST):
3777
3778 2016-12-21  Daniel Bates  <dabates@apple.com>
3779
3780         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3781         https://bugs.webkit.org/show_bug.cgi?id=166356
3782
3783         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3784         as a means to allow a test to explicit allow an embedding client to open a new windows
3785         such that the default behavior is for the embedding client to forbid such an action.
3786         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3787         it is currently skipped on WebKit2 because questions were raised in the patch for
3788         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3789         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3790         this test.
3791
3792         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3793         (WTR::TestRunner::setCanOpenWindows):
3794
3795 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3796
3797         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3798         https://bugs.webkit.org/show_bug.cgi?id=166031
3799
3800         Reviewed by Tim Horton.
3801         
3802         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3803         to ensure that the view is destroyed before the callback fires.
3804
3805         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3806
3807 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3808
3809         Throw Exception when test doesn't clean up HID Events properly
3810         https://bugs.webkit.org/show_bug.cgi?id=166271
3811
3812         Reviewed by Simon Fraser.
3813
3814         Add in a check when UIScriptController is deleted to make sure that the HID event
3815         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3816         the program to crash without any good information. Crashes are race-y, and will still
3817         happen with malformed test, but the information will be much more helpful. 
3818
3819         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3820         (WTR::UIScriptController::checkForClean):
3821         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3822         (UIScriptContext::~UIScriptContext):
3823         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3824         (WTR::UIScriptController::checkForClean):
3825         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3826         * WebKitTestRunner/ios/HIDEventGenerator.h:
3827         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3828         (-[HIDEventGenerator checkHIDCallbacksClear]):
3829         * WebKitTestRunner/ios/TestControllerIOS.mm:
3830         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3831         (WTR::UIScriptController::checkForClean):
3832
3833 2016-12-20  Andy Estes  <aestes@apple.com>
3834
3835         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3836         https://bugs.webkit.org/show_bug.cgi?id=165992
3837
3838         Reviewed by Brady Eidson.
3839
3840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3841         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3842         (expectException):
3843         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3844         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3845         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3846         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3847         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3848         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3849         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3850         (TEST):
3851         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3852
3853 2016-12-20  Dean Jackson  <dino@apple.com>
3854
3855         Remove INDIE_UI
3856         https://bugs.webkit.org/show_bug.cgi?id=165881
3857         <rdar://problem/29672532>
3858
3859         Reviewed by Simon Fraser.
3860
3861         The Indie UI work has been discontinued.
3862
3863         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3864
3865 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3866
3867         [ES6] Enable ES6 Modules
3868         https://bugs.webkit.org/show_bug.cgi?id=165849
3869
3870         Reviewed by Geoffrey Garen.
3871
3872         * DumpRenderTree/mac/DumpRenderTree.mm:
3873         (resetWebPreferencesToConsistentValues):
3874         * DumpRenderTree/win/DumpRenderTree.cpp:
3875         (resetWebPreferencesToConsistentValues):
3876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3877         (WTR::InjectedBundle::beginTesting):
3878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3879         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3881
3882 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3883
3884         Repurpose bots and clean up dashboard.
3885         https://bugs.webkit.org/show_bug.cgi?id=166045
3886
3887         Reviewed by Lucas Forschler.
3888
3889         * BuildSlaveSupport/build.webkit.org-config/config.json:
3890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3891         (BubbleQueueServer):
3892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3894         (WebKitBuildbot):
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3896         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3897
3898 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3899
3900         [CMake] TestWebKitAPIBase links to itself
3901         https://bugs.webkit.org/show_bug.cgi?id=165985
3902
3903         Reviewed by Alex Christensen.
3904
3905         Fix CMake warning about a target linking to itself, which makes no sense.
3906
3907         * TestWebKitAPI/CMakeLists.txt:
3908
3909 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3910
3911         [GTK] GtkDoc build should be quieter
3912         https://bugs.webkit.org/show_bug.cgi?id=165994
3913
3914         Reviewed by Carlos Garcia Campos.
3915
3916         Make it not print by default.
3917
3918         * gtk/generate-gtkdoc:
3919         (get_generator_for_config):
3920         (generate_doc):
3921         * gtk/gtkdoc.py:
3922         (GTKDoc._run_command):
3923         (GTKDoc._copy_doc_files_to_output_dir):
3924
3925 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3926
3927         Expose a way for MiniBrowser to simulate header and footer banners
3928         https://bugs.webkit.org/show_bug.cgi?id=166005
3929
3930         Reviewed by Wenson Hsieh.
3931         
3932         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3933         banners. This only works in WebKit2.
3934         
3935         We need to reset these on each navigation, since newly created FrameViews
3936         don't re-fetch the header and footer height stored on Page.
3937         
3938         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3939         as well as fixing webViewWebContentProcessDidTerminate:
3940
3941         * MiniBrowser/mac/SettingsController.h:
3942         * MiniBrowser/mac/SettingsController.m:
3943         (-[SettingsController _populateMenu]):
3944         (-[SettingsController validateMenuItem:]):
3945         (-[SettingsController toggleReserveSpaceForBanners:]):
3946         (-[SettingsController isSpaceReservedForBanners]):
3947         * MiniBrowser/mac/WK2BrowserWindowController.m:
3948         (-[WK2BrowserWindowController didChangeSettings]):
3949         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3950         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3951         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3952         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3953
3954 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3955
3956         Fix iOS test results after r209967.
3957         
3958         Subtracting out the status bar height was erroneously happening for all tests,
3959         not just for flexible viewport tests.
3960         
3961         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3962
3963         * WebKitTestRunner/PlatformWebView.h:
3964         * WebKitTestRunner/TestController.cpp:
3965         (WTR::TestController::resetStateToConsistentValues):
3966         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3967         (WTR::PlatformWebView::resizeTo):
3968         (WTR::PlatformWebView::setWindowFrame):
3969         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3970         (WTR::PlatformWebView::resizeTo):
3971         (WTR::PlatformWebView::setWindowFrame):
3972         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3973         (WTR::PlatformWebView::resizeTo):
3974         (WTR::PlatformWebView::setWindowFrame):
3975         * WebKitTestRunner/ios/TestControllerIOS.mm:
3976         (WTR::TestController::platformConfigureViewForTest):
3977         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3978         (WTR::PlatformWebView::resizeTo):
3979         (WTR::PlatformWebView::setWindowFrame):
3980
3981 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3982
3983         [EFL] bump EFL version to 1.18.4
3984         https://bugs.webkit.org/show_bug.cgi?id=166004
3985
3986         Reviewed by Gyuyoung Kim.
3987
3988         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3989
3990 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3991
3992         Visual viewports: bottom fixed elements disappear behind the keyboard
3993         https://bugs.webkit.org/show_bug.cgi?id=165983
3994         <rdar://problem/29409852>
3995
3996         Reviewed by Simon Fraser.
3997
3998         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3999         the keyboard when it is up.
4000
4001         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4002         (WTR::UIScriptController::inputViewBounds):
4003         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4004         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4005         (WTR::UIScriptController::inputViewBounds):
4006         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4007         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4008         (WTR::viewRectForWindowRect):
4009
4010         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4011         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4012         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4013
4014         (WTR::PlatformWebView::PlatformWebView):
4015         (WTR::PlatformWebView::setWindowFrame):
4016         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4017         (WTR::UIScriptController::inputViewBounds):
4018
4019 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4020
4021         Deleting a character converted from pinyin after an image causes a Safari crash
4022         https://bugs.webkit.org/show_bug.cgi?id=165839
4023         <rdar://problem/27951933>
4024
4025         Reviewed by Wenson Hsieh.
4026
4027         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4028         while the proposed range contains an image. This should not cause a WebProcess to crash
4029         or send an invalid message to the UIProcess.
4030
4031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4032         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4033         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4034         (TestWebKitAPI::didFinishLoadForFrame):
4035         (TestWebKitAPI::processDidCrash):
4036         (TestWebKitAPI::invalidMessageFunction):
4037         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4038
4039 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4040
4041         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4042         https://bugs.webkit.org/show_bug.cgi?id=165767
4043         <rdar://problem/29602382>
4044
4045         Reviewed by Simon Fraser.
4046
4047         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4048         WebKit2 ChangeLog for more details.
4049
4050         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4051         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4052         (WTR::UIScriptController::textSelectionCaretRect):
4053         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4054         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4055         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4056         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4057         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4058         (WTR::UIScriptController::textSelectionCaretRect):
4059         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4060         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4061         (-[TestRunnerWKWebView _setStableStateOverride:]):
4062
4063         Force the WKWebView to update its visible content rects when changing the stable state override.
4064
4065         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4066         (WTR::toNSDictionary):
4067         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4068         (WTR::UIScriptController::selectionRangeViewRects):
4069         (WTR::UIScriptController::textSelectionCaretRect):
4070         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4071         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4072
4073 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4074
4075         Arguments called in wrong order
4076         https://bugs.webkit.org/show_bug.cgi?id=165923
4077
4078         Reviewed by Simon Fraser.
4079
4080         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4081         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4082
4083         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4084         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4085         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4086
4087 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4088
4089         [EFL] Disable non-srcdir builds for failing libraries
4090         https://bugs.webkit.org/show_bug.cgi?id=165896
4091
4092         Reviewed by Gyuyoung Kim.
4093
4094         * efl/jhbuild.modules: Set non srcdir builds to no
4095
4096 2016-12-15  Daniel Bates  <dabates@apple.com>
4097
4098         check-style should not complain about code in icu directories
4099         https://bugs.webkit.org/show_bug.cgi?id=53929
4100
4101         Reviewed by Darin Adler.
4102
4103         Skip style checking of imported ICU headers to avoid a deluge of style issues
4104         as they do not conform to the WebKit Code Style guideline. We want to preserve
4105         the formatting of these headers so as to make it straightforward to merge
4106         changes to them, if necessary.
4107
4108         * Scripts/webkitpy/style/checker.py:
4109
4110 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4111
4112         Move JSC testers from Yosemite to Sierra
4113         https://bugs.webkit.org/show_bug.cgi?id=165925
4114
4115         Reviewed by Lucas Forschler.
4116
4117         * BuildSlaveSupport/build.webkit.org-config/config.json:
4118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4119         (WebKitBuildbot):
4120
4121 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4122
4123         Add coordinate space to event streams and streamline tests
4124         https://bugs.webkit.org/show_bug.cgi?id=165119
4125
4126         Reviewed by Simon Fraser.
4127
4128         Update event streams to allow for both content and global coordinate space.
4129         Update example script to more accurately show all the available options.
4130
4131         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4132         * WebKitTestRunner/ios/HIDEventGenerator.h:
4133         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4134         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4135         (WTR::convertCoordinates):
4136         (WTR::UIScriptController::sendEventStream):
4137
4138 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4139
4140         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4141         https://bugs.webkit.org/show_bug.cgi?id=165855
4142
4143         Reviewed by Philippe Normand.
4144
4145         GStreamer's autogen.sh enables gtk-doc always so we end up building
4146         docs even if we disable them. Use the configure script instead, since
4147         we build from packages and these include it already.
4148
4149         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4150         upstream gstreamer packages.
4151
4152 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4153
4154         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4155         https://bugs.webkit.org/show_bug.cgi?id=165885
4156         <rdar://problem/29476917>
4157
4158         Reviewed by Darin Adler.
4159
4160         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4161         (TestWebKitAPI::utf16String): Deleted.
4162         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4163         (TestWebKitAPI::TEST_F):
4164         * TestWebKitAPI/WTFStringUtilities.h:
4165         (utf16String):
4166         Moved from URLParser to share with other tests.
4167
4168 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4169
4170         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4171         https://bugs.webkit.org/show_bug.cgi?id=165843
4172
4173         Reviewed by Antti Koivisto.
4174
4175         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4176         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4177         and DumpRenderTree's runUIScript would hit an assertion :(
4178
4179         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4181         (WTR::TestRunner::isWebKit2):
4182
4183 2016-12-14  Brady Eidson  <beidson@apple.com>
4184
4185         IndexedDB 2.0: Massively speedup IDBIndex.get().
4186         https://bugs.webkit.org/show_bug.cgi?id=165802
4187
4188         Reviewed by Alex Christensen.
4189
4190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4191         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4192         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4193         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4194         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4195
4196 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4197
4198         [GTK][EFL] Update the JHBuild version.
4199         https://bugs.webkit.org/show_bug.cgi?id=165838
4200
4201         Reviewed by Michael Catanzaro.
4202
4203         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4204         usage of the JHBUILD_MIRROR feature with git repositories.
4205
4206 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4207
4208         [GTK] Yasm is needed for building the JHBuild after r208940
4209         https://bugs.webkit.org/show_bug.cgi?id=165837
4210
4211         Reviewed by Alejandro G. Castro.
4212
4213         * gtk/install-dependencies: Yasm is needed for building libvpx.
4214
4215 2016-12-14  Youenn Fablet  <youenn@apple.com>
4216
4217         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4218         https://bugs.webkit.org/show_bug.cgi?id=161310
4219
4220         Reviewed by Ryosuke Niwa.
4221
4222         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4223         When set, WTR and DRT output JS console log in the stderr and not the test output.
4224         This allows removing potentially flaky information while still being able to read it for investigation.
4225
4226         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4227
4228         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4229         This test should have this option when fetch API will start logging resource loader errors.
4230
4231         * DumpRenderTree/DumpRenderTree.h:
4232         (TestCommand::TestCommand): Deleted.
4233         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4234         (parseInputLine):
4235         * DumpRenderTree/TestRunner.h:
4236         (TestRunner::setDumpJSConsoleLogInStdErr):
4237         (TestRunner::dumpJSConsoleLogInStdErr):
4238         * DumpRenderTree/mac/DumpRenderTree.mm:
4239         (runTest):
4240         * DumpRenderTree/mac/UIDelegate.mm:
4241         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4242         * DumpRenderTree/win/DumpRenderTree.cpp:
4243         (runTest):
4244         * DumpRenderTree/win/UIDelegate.cpp:
4245         (UIDelegate::webViewAddMessageToConsole):
4246         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4247         (TestExpectationParser._tokenize_line):
4248         * Scripts/webkitpy/port/driver.py:
4249         (Driver._command_from_driver_input):
4250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4251         (WTR::InjectedBundle::didReceiveMessageToPage):
4252         (WTR::InjectedBundle::dumpToStdErr):
4253         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4254         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4255         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4256         (WTR::InjectedBundlePage::willAddMessageToConsole):
4257         * WebKitTestRunner/TestController.cpp:
4258         (WTR::parseInputLine):
4259         (WTR::TestController::runTest):
4260         (WTR::TestCommand::TestCommand): Deleted.
4261         * WebKitTestRunner/TestInvocation.cpp:
4262         (WTR::TestInvocation::invoke):
4263         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4264         * WebKitTestRunner/TestInvocation.h:
4265         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4266
4267
4268 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4269
4270         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4271         https://bugs.webkit.org/show_bug.cgi?id=164022
4272
4273         Reviewed by Xabier Rodriguez-Calvar.
4274
4275         * Scripts/webkitperl/FeatureList.pm:
4276           Re-enable MEDIA_SOURCE for the GTK+ port.
4277
4278 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4279
4280         Fix CMake build.
4281
4282         * DumpRenderTree/PlatformMac.cmake:
4283         Define NS_RETURNS_RETAINED as nothing for now.
4284
4285 2016-12-13  Jer Noble  <jer.noble@apple.com>
4286
4287         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4288         https://bugs.webkit.org/show_bug.cgi?id=165697
4289
4290         Reviewed by Tim Horton.
4291
4292         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4293         (TestWebKitAPI::TEST):
4294
4295 2016-12-13  Andy Estes  <aestes@apple.com>
4296
4297         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4298         https://bugs.webkit.org/show_bug.cgi?id=165785
4299         <rdar://problem/26929398>
4300
4301         Reviewed by Darin Adler.
4302
4303         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4304         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4305         expectations for the text, range, and action.
4306         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4307         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4308