Try to fix the 32-bit watchOS build.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Andy Estes  <aestes@apple.com>
2
3         Try to fix the 32-bit watchOS build.
4
5         * TestWebKitAPI/cocoa/TestWKWebView.mm:
6         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
7
8 2019-04-10  Antoine Quint  <graouts@apple.com>
9
10         Enable Pointer Events on watchOS
11         https://bugs.webkit.org/show_bug.cgi?id=196771
12         <rdar://problem/49040909>
13
14         Reviewed by Dean Jackson.
15
16         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
17
18 2019-04-10  Philippe Normand  <pnormand@igalia.com>
19
20         Unreviewed. Fix WPE accessibility tests after r244059.
21
22         We are failing to load the injected bundle due to undefined symbol
23         AccessibilityUIElement::replaceTextInRange().
24
25         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
26         (WTR::AccessibilityUIElement::replaceTextInRange):
27
28 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
29
30         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
31         https://bugs.webkit.org/show_bug.cgi?id=196727
32
33         Reviewed by Fujii Hironori.
34
35         * MiniBrowser/win/WebKitBrowserWindow.cpp:
36         (WebKitBrowserWindow::create):
37
38 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-build] Add unit tests for PrintConfiguration
41         https://bugs.webkit.org/show_bug.cgi?id=196752
42
43         Reviewed by Dewei Zhu.
44
45         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
46
47 2019-04-09  Keith Rollin  <krollin@apple.com>
48
49         Unreviewed build maintenance -- update .xcfilelists.
50
51         * DumpRenderTree/DerivedSources-input.xcfilelist:
52         * DumpRenderTree/DerivedSources-output.xcfilelist:
53
54 2019-04-09  Zalan Bujtas  <zalan@apple.com>
55
56         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
57         https://bugs.webkit.org/show_bug.cgi?id=196743
58         <rdar://problem/43897551>
59
60         Reviewed by Tim Horton.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
63         (TEST):
64
65 2019-04-09  Youenn Fablet  <youenn@apple.com>
66
67         Close service worker database on network process suspension
68         https://bugs.webkit.org/show_bug.cgi?id=196623
69         <rdar://problem/48930869>
70
71         Reviewed by Alex Christensen.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
74
75 2019-04-09  Daniel Bates  <dabates@apple.com>
76
77         [iPad] Should open popover when the spacebar is pressed
78         https://bugs.webkit.org/show_bug.cgi?id=196360
79         <rdar://problem/49389129>
80
81         Reviewed by Brent Fulgham.
82
83         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
84
85         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
86         (WTR::UIScriptController::isShowingPopover const): Added.
87         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
88         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
89         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
90         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
91         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
92         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
93         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
94         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
95         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
96         (WTR::UIScriptController::isShowingPopover const): Added.
97         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
98         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
99         * TestRunnerShared/UIScriptContext/UIScriptController.h:
100         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
101         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
102         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
103         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
104         (-[TestRunnerWKWebView _willPresentPopover]): Added.
105         (-[TestRunnerWKWebView _didDismissPopover]): Added.
106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
107         (WTR::UIScriptController::isShowingPopover const): Added.
108         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
109         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
110
111 2019-04-09  Alex Christensen  <achristensen@webkit.org>
112
113         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
114         https://bugs.webkit.org/show_bug.cgi?id=196665
115         <rdar://45115669>
116
117         Reviewed by Geoff Garen.
118
119         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
120         (goBack):
121         (+[SimpleLookupContext sharedLookupContext]):
122         (-[SimpleLookupContext lookUpURL:completionHandler:]):
123         (TEST):
124         (+[Simple3LookupContext sharedLookupContext]): Deleted.
125         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
126
127 2019-04-09  John Wilander  <wilander@apple.com>
128
129         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
130         https://bugs.webkit.org/show_bug.cgi?id=196558
131         <rdar://problem/47650245>
132
133         Reviewed by Youenn Fablet.
134
135         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
136         (TestWebKitAPI::TEST):
137             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
138
139 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
140
141         [CMake] Apple builds should use ICU_INCLUDE_DIRS
142         https://bugs.webkit.org/show_bug.cgi?id=196720
143
144         Reviewed by Konstantin Tokarev.
145
146         * TestWebKitAPI/PlatformMac.cmake:
147
148 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
149
150         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
151         https://bugs.webkit.org/show_bug.cgi?id=196694
152         <rdar://problem/48388734>
153
154         Rubber-stamped by Aakash Jain.
155
156         * Scripts/webkitpy/port/image_diff.py:
157         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
158         * Scripts/webkitpy/port/server_process.py:
159         (ServerProcess.has_available_stdout): Check if stdout has data in it.
160         (ServerProcess._wait_for_data_and_update_buffers_using_select):
161         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
162         * Scripts/webkitpy/port/server_process_mock.py:
163         (MockServerProcess.has_available_stdout):
164         * Scripts/webkitpy/port/server_process_unittest.py:
165         (TestServerProcess.serial_test_basic):
166
167 2019-04-09  Jer Noble  <jer.noble@apple.com>
168
169         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
170         https://bugs.webkit.org/show_bug.cgi?id=196097
171
172         Reviewed by Eric Carlson.
173
174         Drive-by bug fix: allow tests to play audio without a user gesture by default.
175
176         * DumpRenderTree/mac/DumpRenderTree.mm:
177         (resetWebPreferencesToConsistentValues):
178         * WebKitTestRunner/TestController.cpp:
179         (WTR::TestController::resetPreferencesToConsistentValues):
180
181 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
182
183         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
184         https://bugs.webkit.org/show_bug.cgi?id=196690
185
186         Reviewed by Michael Catanzaro.
187
188         * QueueStatusServer/config/queues.py:
189         * Scripts/webkitpy/common/config/ews.json:
190         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
191         (test_ews_name):
192
193 2019-04-09  Chris Dumez  <cdumez@apple.com>
194
195         Loads using loadHTMLString() cause flashing when process-swapping
196         https://bugs.webkit.org/show_bug.cgi?id=196714
197         <rdar://problem/49637354>
198
199         Reviewed by Antti Koivisto.
200
201         Add API test coverage.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
204
205 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
206
207         Unreviewed. Fix ATK accessibility tests after r244059.
208
209         We are failing to load the injected bundle due to undefined symbol
210         AccessibilityUIElement::replaceTextInRange().
211
212         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
213         (WTR::AccessibilityUIElement::replaceTextInRange):
214
215 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
216
217         AX: Support API: accessibilityReplaceRange:withText
218         https://bugs.webkit.org/show_bug.cgi?id=196636
219
220         Unreviewed build fix for Windows port.
221
222         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
223         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
224
225 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
226
227         [CMake][WinCairo] Separate copied headers into different directories
228         https://bugs.webkit.org/show_bug.cgi?id=196655
229
230         Reviewed by Michael Catanzaro.
231
232         * DumpRenderTree/CMakeLists.txt:
233         * MiniBrowser/win/CMakeLists.txt:
234         * TestWebKitAPI/CMakeLists.txt:
235         * TestWebKitAPI/PlatformWin.cmake:
236
237 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
238
239         Log stack-trace for run-webkit-tests when interrupted
240         https://bugs.webkit.org/show_bug.cgi?id=176393
241         <rdar://problem/34262310>
242
243         Reviewed by Lucas Forschler.
244
245         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
246         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
247         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
248         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
249         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
250         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
251         (main): Set handlers to log stack trace on interruption.
252
253 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
254
255         AX: Support API: accessibilityReplaceRange:withText
256         https://bugs.webkit.org/show_bug.cgi?id=196636
257
258         Unreviewed build fix for Windows port.
259
260         * DumpRenderTree/AccessibilityUIElement.cpp:
261         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
262
263 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
264
265         [ews-build] Scripts using Buildbot API have CORS error
266         https://bugs.webkit.org/show_bug.cgi?id=196709
267
268         Reviewed by Alexey Proskuryakov.
269
270         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
271
272 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
273
274         AX: Support API: accessibilityReplaceRange:withText
275         https://bugs.webkit.org/show_bug.cgi?id=196636
276
277         Reviewed by Daniel Bates.
278
279         * DumpRenderTree/AccessibilityUIElement.cpp:
280         (replaceTextInRangeCallback):
281         (AccessibilityUIElement::replaceTextInRange):
282         (AccessibilityUIElement::getJSClass):
283         * DumpRenderTree/AccessibilityUIElement.h:
284         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
285         (AccessibilityUIElement::replaceTextInRange):
286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
287         (AccessibilityUIElement::replaceTextInRange):
288         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
289         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
290         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
291         (WTR::AccessibilityUIElement::replaceTextInRange):
292         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
293         (WTR::AccessibilityUIElement::replaceTextInRange):
294
295 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
296
297         [iOS] Do not allow starting selection drags when selection views are not visible
298         https://bugs.webkit.org/show_bug.cgi?id=196686
299         <rdar://problem/49399192>
300
301         Reviewed by Tim Horton.
302
303         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
304         also add some new API tests to cover scenarios where the web view is not first responder.
305
306         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
307         (TestWebKitAPI::TEST):
308         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
309
310         Add a switch to optionally make the web view first responder when starting the simulated drag.
311
312         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
313         (-[DragAndDropSimulator initWithWebView:]):
314         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
315
316 2019-04-08  Justin Fan  <justin_fan@apple.com>
317
318         [Web GPU] Fix Web GPU experimental feature on iOS
319         https://bugs.webkit.org/show_bug.cgi?id=196632
320
321         Reviewed by Myles C. Maxfield.
322
323         Properly make Web GPU available on iOS 11+.
324
325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
326
327 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
328
329         [ews-build] Do not upload archive when Compile Fails
330         https://bugs.webkit.org/show_bug.cgi?id=196674
331
332         Reviewed by Alexey Proskuryakov.
333
334         * BuildSlaveSupport/ews-build/factories.py:
335         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
336         * BuildSlaveSupport/ews-build/steps.py:
337         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
338         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
339         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
340
341 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
342
343         Enable DFG on MIPS
344         https://bugs.webkit.org/show_bug.cgi?id=196689
345
346         Reviewed by Žan Doberšek.
347
348         Since the bytecode change, we enabled the baseline JIT on mips in
349         r240432, but DFG is still missing. With this change, all tests are
350         passing on a ci20 board.
351
352         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
353
354 2019-04-08  Philippe Normand  <pnormand@igalia.com>
355
356         [Flatpak] Second run update-webkitwpe-flatpak fails
357         https://bugs.webkit.org/show_bug.cgi?id=192702
358
359         Reviewed by Carlos Garcia Campos.
360
361         * flatpak/flatpakutils.py:
362         (FlatpakObject.flatpak): Fix typo.
363         (FlatpakPackage.install): When installing, also update to the configured remote commit.
364         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
365
366 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
367
368         [GTK][WPE] outlook.live.com displays old-fashioned UI
369         https://bugs.webkit.org/show_bug.cgi?id=196642
370
371         Reviewed by Carlos Garcia Campos.
372
373         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
374         (TestWebKitAPI::TEST): New Mac platform quirk test.
375
376 2019-04-07  Commit Queue  <commit-queue@webkit.org>
377
378         Unreviewed, rolling out r243956.
379         https://bugs.webkit.org/show_bug.cgi?id=196688
380
381         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
382         by aakashjain on #webkit).
383
384         Reverted changeset:
385
386         "Clicking "Go Back" from a safe browsing warning from an
387         iframe should navigate the WKWebView back to the previous
388         page"
389         https://bugs.webkit.org/show_bug.cgi?id=196665
390         https://trac.webkit.org/changeset/243956
391
392 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
393
394         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
395         https://bugs.webkit.org/show_bug.cgi?id=196669
396
397         Reviewed by Geoffrey Garen.
398
399         Added three new unit tests for WeakHashSet.
400
401         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
402         (WTF_WeakPtr.WeakHashSetConstObjects):
403         (WTF_WeakPtr.WeakHashSetComputesEmpty):
404         (WTF_WeakPtr.WeakHashSetComputeSize):
405
406 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
407
408         Hide next and previous form control buttons when WKWebView is editable
409         https://bugs.webkit.org/show_bug.cgi?id=196672
410         <rdar://problem/35625321>
411
412         Reviewed by Tim Horton.
413
414         Add a new API test.
415
416         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
417         (-[TestWKWebView lastTrailingBarButtonGroup]):
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/ios/UIKitSPI.h:
420
421 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
422
423         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
424         https://bugs.webkit.org/show_bug.cgi?id=196077
425         <rdar://problem/49108202>
426
427         Reviewed by Chris Dumez.
428
429         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
430         on new web view.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
433
434 2019-04-05  Saam Barati  <sbarati@apple.com>
435
436         Make compare-results understand MotionMark
437         https://bugs.webkit.org/show_bug.cgi?id=196666
438
439         Reviewed by Yusuke Suzuki.
440
441         * Scripts/compare-results:
442         (PLT5Results):
443         (detectMotionMark):
444         (detectMotionMark1_1):
445         (motionMarkResults):
446         (motionMark1_1Results):
447         (detectBenchmark):
448         (biggerIsBetter):
449         (main):
450
451 2019-04-05  Alex Christensen  <achristensen@webkit.org>
452
453         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
454         https://bugs.webkit.org/show_bug.cgi?id=196665
455         <rdar://45115669>
456
457         Reviewed by Geoff Garen.
458
459         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
460         (goBack):
461         (+[SimpleLookupContext sharedLookupContext]):
462         (-[SimpleLookupContext lookUpURL:completionHandler:]):
463         (TEST):
464         (+[Simple3LookupContext sharedLookupContext]): Deleted.
465         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
466
467 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
468
469         [ews-build] Add configuration and architecture for windows builders
470         https://bugs.webkit.org/show_bug.cgi?id=196660
471
472         Reviewed by Lucas Forschler.
473
474         * BuildSlaveSupport/ews-build/config.json:
475
476 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
477
478         webkitpy: Don't run subsequent rounds if interrupted
479         https://bugs.webkit.org/show_bug.cgi?id=196646
480
481         Reviewed by Aakash Jain.
482
483         * Scripts/webkitpy/layout_tests/controllers/manager.py:
484         (Manager.run): Bail out if interrupted.
485
486 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
487
488         Test sessionStorage in PSON private browsing mode
489         https://bugs.webkit.org/show_bug.cgi?id=196561
490
491         Reviewed by Alex Christensen.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
494
495 2019-04-05  Commit Queue  <commit-queue@webkit.org>
496
497         Unreviewed, rolling out r243833.
498         https://bugs.webkit.org/show_bug.cgi?id=196645
499
500         This change breaks build of WPE and GTK ports (Requested by
501         annulen on #webkit).
502
503         Reverted changeset:
504
505         "[CMake][WTF] Mirror XCode header directories"
506         https://bugs.webkit.org/show_bug.cgi?id=191662
507         https://trac.webkit.org/changeset/243833
508
509 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
510
511         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
512         https://bugs.webkit.org/show_bug.cgi?id=196635
513
514         Reviewed by Antti Koivisto.
515         
516         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
517         for a test to enable async frame scrolling via:
518             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
519         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
520         
521         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
522
523         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
524         (WTR::InjectedBundle::beginTesting):
525         * WebKitTestRunner/TestController.cpp:
526         (WTR::TestController::resetPreferencesToConsistentValues):
527
528 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
529
530         Use a correct LC_RPATH when building with ASan
531         https://bugs.webkit.org/show_bug.cgi?id=196576
532
533         Reviewed by David Kilzer.
534
535         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
536         so that ../Frameworks is checked. This is simpler and more reliable than updating
537         each SPC service xcconfig.
538
539 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
540
541         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
542         https://bugs.webkit.org/show_bug.cgi?id=196629
543
544         Reviewed by Lucas Forschler.
545
546         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
547
548 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
551         https://bugs.webkit.org/show_bug.cgi?id=196618
552
553         Reviewed by Lucas Forschler.
554
555         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
556         (StatusBubble): Added QUEUE_TRIGGERS.
557         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
558         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
559         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
560         its parent(builder).
561
562 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
563
564         [ews-app] Status-bubble steps are sometimes displayed in reverse order
565         https://bugs.webkit.org/show_bug.cgi?id=196625
566
567         Reviewed by Lucas Forschler.
568
569         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
570         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
571
572 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
573
574         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
575         https://bugs.webkit.org/show_bug.cgi?id=196630
576
577         Reviewed by Wenson Hsieh.
578
579         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
580
581 2019-04-04  Youenn Fablet  <youenn@apple.com>
582
583         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
584         https://bugs.webkit.org/show_bug.cgi?id=196543
585
586         Reviewed by Alex Christensen.
587
588         * WebKitTestRunner/TestController.cpp:
589         (WTR::TestController::generatePageConfiguration):
590
591 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
592
593         [ews-app] Status bubble should not display skipped buildbot steps
594         https://bugs.webkit.org/show_bug.cgi?id=196584
595
596         Reviewed by Lucas Forschler.
597
598         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
599
600 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
601
602         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
603         https://bugs.webkit.org/show_bug.cgi?id=196620
604
605         Reviewed by Lucas Forschler.
606
607         * BuildSlaveSupport/ews-app/ews/config.py:
608
609 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
610
611         [Win] DumpRenderTreeWatchDog.py is not checked into source
612         https://bugs.webkit.org/show_bug.cgi?id=196567
613         <rdar://problem/49525901>
614
615         Reviewed by Lucas Forschler.
616
617         This script is used on Win EWS bots to terminate hanging DRT processes.
618
619         * EWSTools/dumprendertreewatchdog.py: Added.
620
621 2019-04-04  Chris Dumez  <cdumez@apple.com>
622
623         Unreviewed, roll out r243858 which made tests time out.
624
625         Disable new API tests on Windows instead.
626
627         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
628         (TestWebKitAPI::TEST):
629
630 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
631
632         [ATK] Cleanup WebPageAccessibilityObjectAtk
633         https://bugs.webkit.org/show_bug.cgi?id=196537
634
635         Reviewed by Michael Catanzaro.
636
637         Also consider files under atk directories as exceptions for GObject conventions.
638
639         * Scripts/webkitpy/style/checkers/cpp.py:
640         (check_identifier_name_in_declaration):
641
642 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
643
644         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
645         https://bugs.webkit.org/show_bug.cgi?id=196588
646         <rdar://problem/49365787>
647
648         Unreviewed build fix for Windows port.
649
650         error C3861: 'kill': identifier not found
651
652         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
653         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
654
655 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
656
657         [ews-build] Cancel build and similar operations should have authentication
658         https://bugs.webkit.org/show_bug.cgi?id=196520
659
660         Reviewed by Dewei Zhu.
661
662         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
663         environment variables.
664
665 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
666
667         [ews-build] Do not trigger queues which are not in production yet
668         https://bugs.webkit.org/show_bug.cgi?id=196581
669
670         Reviewed by Dewei Zhu.
671
672         * BuildSlaveSupport/ews-build/config.json:
673
674 2019-04-03  Chris Dumez  <cdumez@apple.com>
675
676         Unreviewed, fix typo in the name of API test added in r243848.
677
678         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
679         (TestWebKitAPI::TEST):
680
681 2019-04-03  Chris Dumez  <cdumez@apple.com>
682
683         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
684         https://bugs.webkit.org/show_bug.cgi?id=196588
685         <rdar://problem/49365787>
686
687         Reviewed by Ryosuke Niwa.
688
689         Add API test coverage.
690
691         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
692         (TestWebKitAPI::nullJavaScriptCallback):
693         (TestWebKitAPI::didCrashCheckFrames):
694         (TestWebKitAPI::TEST):
695
696 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
697
698         run-webkit-tests: Upload test results (new results database)
699         https://bugs.webkit.org/show_bug.cgi?id=196577
700         <rdar://problem/34841155>
701
702         Reviewed by Lucas Forschler.
703
704         * Scripts/webkitpy/layout_tests/controllers/manager.py:
705         (Manager.run): Upload results after each device shard, since the configuration will be
706         different for each device.
707         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
708         uploaded to a results database.
709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
710         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
711
712 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
713
714         -apple-trailing-word is needed for browser detection
715         https://bugs.webkit.org/show_bug.cgi?id=196575
716
717         Unreviewed.
718
719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
720
721 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
722
723         [CMake][WTF] Mirror XCode header directories
724         https://bugs.webkit.org/show_bug.cgi?id=191662
725
726         Reviewed by Konstantin Tokarev.
727
728         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
729         builds.
730
731         * CMakeLists.txt:
732         * DumpRenderTree/CMakeLists.txt:
733         * DumpRenderTree/PlatformWin.cmake:
734         * MiniBrowser/win/CMakeLists.txt:
735         * TestWebKitAPI/CMakeLists.txt:
736         * TestWebKitAPI/PlatformWin.cmake:
737         * WebKitTestRunner/PlatformGTK.cmake:
738         * WebKitTestRunner/PlatformWin.cmake:
739
740 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
741
742         [ews-app] Status bubble should not display certain infrastructure status messages
743         https://bugs.webkit.org/show_bug.cgi?id=196550
744
745         Reviewed by Lucas Forschler.
746
747         Do not display the steps which are un-needed for end-user. This information is still avaiable
748         if the user click on the bubble and look at the Buildbot build.
749         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
750         (StatusBubble._steps_messages):
751         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
752
753 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
754
755         [ews-build] Use https for sending data to ews-app
756         https://bugs.webkit.org/show_bug.cgi?id=196492
757
758         Reviewed by Lucas Forschler.
759
760         * BuildSlaveSupport/ews-build/events.py:
761
762 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
763
764         Remove support for -apple-trailing-word
765         https://bugs.webkit.org/show_bug.cgi?id=196525
766
767         Reviewed by Zalan Bujtas.
768
769         This CSS property is nonstandard and not used.
770
771         * Scripts/webkitperl/FeatureList.pm:
772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
773
774 2019-04-03  Youenn Fablet  <youenn@apple.com>
775
776         Add a test for DOMCache on multiple browsing in case of private browsing
777         https://bugs.webkit.org/show_bug.cgi?id=196524
778
779         Reviewed by Alex Christensen.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
782         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
783
784 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
785
786         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
787         https://bugs.webkit.org/show_bug.cgi?id=196540
788
789         Reviewed by Aakash Jain.
790
791         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
792
793 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
794
795         Add plumbing for a compatibility mode preference in WebKit
796         https://bugs.webkit.org/show_bug.cgi?id=196005
797
798         Reviewed by Tim Horton.
799
800         Add new API tests.
801
802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
803         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
804
805 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
806
807         [WPE][GTK] Update libsrtp dependency package for Debian
808         https://bugs.webkit.org/show_bug.cgi?id=196528
809
810         Reviewed by Frédéric Wang.
811
812         * gtk/install-dependencies:
813         * wpe/install-dependencies:
814
815 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
816
817         [WK2] Add support for Window's beforeprint / afterprint events
818         https://bugs.webkit.org/show_bug.cgi?id=196478
819         <rdar://problem/49535124>
820
821         Unreviewed build fix for MSVC.
822
823         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
824
825         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
826
827         * WebKitTestRunner/TestController.cpp:
828         (WTR::printFrame): Use int and float literals.
829
830 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
831
832         [ews-build] Reassign bots to queues
833
834         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
835
836 2019-04-02  Chris Dumez  <cdumez@apple.com>
837
838         [WK2] Add support for Window's beforeprint / afterprint events
839         https://bugs.webkit.org/show_bug.cgi?id=196478
840
841         Reviewed by Alex Christensen.
842
843         Add minimal implementation for printFrame in WebKitTestRunner.
844
845         * WebKitTestRunner/TestController.cpp:
846         (WTR::printFrame):
847         (WTR::TestController::createOtherPage):
848         (WTR::TestController::createWebViewWithOptions):
849
850 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
851
852         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
853         https://bugs.webkit.org/show_bug.cgi?id=196491
854
855         Reviewed by Lucas Forschler.
856
857         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
858
859 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
860
861         [ews-build] Configure buildbot try credentials in environment variables
862         https://bugs.webkit.org/show_bug.cgi?id=196501
863
864         Reviewed by Lucas Forschler.
865
866         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
867         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
868         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
869
870 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
871
872         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
873         https://bugs.webkit.org/show_bug.cgi?id=196496
874         <rdar://problem/49521634>
875
876         Reviewed by Chris Dumez.
877
878         Add new API tests (see WebKit ChangeLog for more detail).
879
880         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
881         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
882         (TEST):
883
884 2019-04-02  David Kilzer  <ddkilzer@apple.com>
885
886         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
887         <https://webkit.org/b/196499>
888
889         Reviewed by Alexey Proskuryakov.
890
891         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
892         ENABLE_ADDRESS_SANITIZER.
893
894 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
895
896         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
897         https://bugs.webkit.org/show_bug.cgi?id=182757
898
899         Reviewed by Don Olmstead.
900
901         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
902         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
903
904 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
905
906         run-api-tests: Upload test results
907         https://bugs.webkit.org/show_bug.cgi?id=196323
908         <rdar://problem/49356714>
909
910         Reviewed by Lucas Forschler.
911
912         * Scripts/webkitpy/api_tests/manager.py:
913         (Manager):
914         (Manager.run): Upload results to a results database.
915         * Scripts/webkitpy/api_tests/run_api_tests.py:
916         (parse_args): Add upload arguments.
917         * Scripts/webkitpy/port/base.py:
918         (Port):
919         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
920         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
921         with commits from any other associated repositories.
922         * Scripts/webkitpy/port/device.py:
923         (Device):
924         (Device.build_version): Access build_versoin of underlying platform device.
925         * Scripts/webkitpy/port/ios_simulator_unittest.py:
926         (IOSSimulatorTest):
927         (IOSSimulatorTest.test_configuration_for_upload):
928         * Scripts/webkitpy/port/device_port.py:
929         (DevicePort):
930         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
931         the same as the machine uploading results.
932         * Scripts/webkitpy/port/mac.py:
933         (MacPort):
934         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
935         * Scripts/webkitpy/port/mac_unittest.py:
936         (MacTest):
937         (MacTest.test_configuration_for_upload):
938         * Scripts/webkitpy/xcode/simulated_device.py:
939         (SimulatedDeviceManager._create_device_with_runtime):
940         (SimulatedDevice.__init__): Create simulated device with a build_version.
941         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
942         (test_existing_simulator):
943
944 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
945
946         Remove extra newline characters (Follow-up fix to r243707)
947
948         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
949
950 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
951
952         [ews-app] Use API_KEY to accept results data
953         https://bugs.webkit.org/show_bug.cgi?id=196461
954
955         Reviewed by Dewei Zhu.
956
957         * BuildSlaveSupport/ews-app/ews/views/results.py:
958         (Results.post): Validate EWS_API_KEY before accepting any data.
959         * BuildSlaveSupport/ews-build/events.py:
960         (Events.sendData): Send EWS_API_KEY if available along with event data.
961
962 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
963
964         Unable to copy and paste a PDF from Notes into Mail compose body
965         https://bugs.webkit.org/show_bug.cgi?id=196442
966         <rdar://problem/48573098>
967
968         Reviewed by Tim Horton.
969
970         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
971         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
972         to be specified on the item providers.
973
974         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
975         (TestWebKitAPI::mapItemForTesting):
976         (TestWebKitAPI::contactItemForTesting):
977
978 2019-04-01  Tim Horton  <timothy_horton@apple.com>
979
980         Make UIWKDocumentContext rects per-character instead of per-word
981         https://bugs.webkit.org/show_bug.cgi?id=196459
982
983         Reviewed by Wenson Hsieh.
984
985         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
986         (TEST):
987         Adjust test results due to switching to per-character rects.
988
989 2019-04-01  Chris Dumez  <cdumez@apple.com>
990
991         UIProcess crash when a prewarmed process is terminated
992         https://bugs.webkit.org/show_bug.cgi?id=196451
993         <rdar://problem/49245471>
994
995         Reviewed by Geoffrey Garen.
996
997         Add API test coverage.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1000         (TEST):
1001
1002 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1003
1004         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1005         https://bugs.webkit.org/show_bug.cgi?id=196449
1006
1007         Reviewed by Lucas Forschler.
1008
1009         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1010         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1011         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1012         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1013
1014 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1015
1016         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1017         https://bugs.webkit.org/show_bug.cgi?id=196444
1018
1019         Reviewed by Lucas Forschler.
1020
1021         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1022
1023 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1024
1025         Add SPI to canonicalize NSURLs with WTF::URL
1026         https://bugs.webkit.org/show_bug.cgi?id=196415
1027         <rdar://problem/44980271>
1028
1029         Reviewed by Darin Adler.
1030
1031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1032         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1033         (TestWebKitAPI::TEST):
1034
1035 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1036
1037         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1038         https://bugs.webkit.org/show_bug.cgi?id=196441
1039
1040         Reviewed by Carlos Garcia Campos.
1041
1042         Don't cache the wpe_view_backend object that might not exist yet at the
1043         time of EventSenderProxy constructor invocation, but instead retrieve
1044         that object whenever it's required for event dispatching. This should
1045         avoid crashes in this constructor now that it's invoked before any
1046         PlatformWindow has been set up (as changed in r243496).
1047
1048         * WebKitTestRunner/EventSenderProxy.h:
1049         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1050         (WTR::viewBackend):
1051         (WTR::EventSenderProxy::EventSenderProxy):
1052         (WTR::EventSenderProxy::mouseDown):
1053         (WTR::EventSenderProxy::mouseUp):
1054         (WTR::EventSenderProxy::mouseMoveTo):
1055         (WTR::EventSenderProxy::mouseScrollBy):
1056         (WTR::EventSenderProxy::keyDown):
1057         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1058
1059 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1060
1061         [Win][WebKit] MiniBrowser should support high DPI display
1062         https://bugs.webkit.org/show_bug.cgi?id=196391
1063
1064         Reviewed by Alex Christensen.
1065
1066         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1067         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1068         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1069         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1070
1071 2019-03-31  Sam Weinig  <weinig@apple.com>
1072
1073         Remove more i386 specific configurations
1074         https://bugs.webkit.org/show_bug.cgi?id=196430
1075
1076         Reviewed by Alexey Proskuryakov.
1077
1078         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1079         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1080
1081 2019-03-31  Andy Estes  <aestes@apple.com>
1082
1083         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1084         https://bugs.webkit.org/show_bug.cgi?id=196433
1085         <rdar://problem/49293305>
1086
1087         Reviewed by Tim Horton.
1088
1089         Enhanced API test coverage to include all navigation response policy decisions in both
1090         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1094         (TestWebKitAPI::TEST):
1095         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1096         (readFile):
1097         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1098         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1099         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1100         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1101         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1102         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1103         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1104         (-[QuickLookDelegate _downloadDidStart:]):
1105         (-[QuickLookDelegate _download:didReceiveResponse:]):
1106         (-[QuickLookDelegate _download:didReceiveData:]):
1107         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1108         (-[QuickLookDelegate _downloadDidFinish:]):
1109         (-[QuickLookDelegate _download:didFailWithError:]):
1110         (-[QuickLookDelegate _downloadDidCancel:]):
1111         (-[QuickLookDelegate verifyDownload]):
1112         (runTest):
1113         (runTestDecideBeforeLoading):
1114         (runTestDecideAfterLoading):
1115         (TEST):
1116         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1117         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1118         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1119         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1120         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1121         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1122         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1123         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1124         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1125         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1126         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1127         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1128         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1129         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1130
1131 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1132
1133         [CMake] add testdfg as target with build-jsc
1134         https://bugs.webkit.org/show_bug.cgi?id=196393
1135
1136         Reviewed by Saam Barati.
1137
1138         Added testdfg as one of the targets to build when
1139         using CMake.
1140
1141         * Scripts/build-jsc:
1142
1143 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1144
1145         Delete WebMetal implementation in favor of WebGPU
1146         https://bugs.webkit.org/show_bug.cgi?id=195418
1147
1148         Reviewed by Dean Jackson.
1149
1150         * DumpRenderTree/mac/DumpRenderTree.mm:
1151         (enableExperimentalFeatures):
1152         (resetWebPreferencesToConsistentValues):
1153         * Scripts/webkitperl/FeatureList.pm:
1154         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1156         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1157         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1158         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1159         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1160         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1161         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1162         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1163         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1164         (WTR::InjectedBundle::beginTesting):
1165         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1167         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1168
1169 2019-03-29  Chris Dumez  <cdumez@apple.com>
1170
1171         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1172         https://bugs.webkit.org/show_bug.cgi?id=196405
1173         <rdar://problem/49428130>
1174
1175         Reviewed by Wenson Hsieh.
1176
1177         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1178         the popover presentation methods to be no-ops. Use this in the new test added in
1179         r243523 so that we do not swizzle those methods for all tests. This is needed because
1180         those WatchOS tests rely on the popover getting presented and interactive.
1181
1182         * WebKitTestRunner/TestController.cpp:
1183         (WTR::updateTestOptionsFromTestHeader):
1184         * WebKitTestRunner/TestController.h:
1185         * WebKitTestRunner/TestOptions.h:
1186         (WTR::TestOptions::hasSameInitializationOptions const):
1187         * WebKitTestRunner/ios/TestControllerIOS.mm:
1188         (WTR::TestController::platformInitialize):
1189         (WTR::TestController::platformResetStateToConsistentValues):
1190
1191 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1192
1193         [Curl] Add Server Trust Evaluation Support.
1194         https://bugs.webkit.org/show_bug.cgi?id=191646
1195
1196         Reviewed by Fujii Hironori.
1197
1198         Implemented MiniBrowser UI for asking if user trusts the server.
1199
1200         * MiniBrowser/win/Common.cpp:
1201         (askServerTrustEvaluation):
1202         (replaceString):
1203         * MiniBrowser/win/Common.h:
1204         * MiniBrowser/win/MiniBrowserLib.rc:
1205         * MiniBrowser/win/MiniBrowserLibResource.h:
1206         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1207         (createPEMString):
1208         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1209         (WebKitBrowserWindow::canTrustServerCertificate):
1210         * MiniBrowser/win/WebKitBrowserWindow.h:
1211
1212 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1213
1214         Implement ResizeObserver.
1215         https://bugs.webkit.org/show_bug.cgi?id=157743
1216
1217         Reviewed by Simon Fraser.
1218
1219         Support resizeObserverEnabled webPreferences.
1220
1221         * DumpRenderTree/TestOptions.cpp:
1222         (TestOptions::TestOptions):
1223         * DumpRenderTree/TestOptions.h:
1224         * DumpRenderTree/mac/DumpRenderTree.mm:
1225         (setWebPreferencesForTestOptions):
1226         * DumpRenderTree/win/DumpRenderTree.cpp:
1227         (enableExperimentalFeatures):
1228         * Scripts/webkitperl/FeatureList.pm:
1229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1230
1231 2019-03-28  John Wilander  <wilander@apple.com>
1232
1233         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1234         https://bugs.webkit.org/show_bug.cgi?id=196281
1235         <rdar://problem/48938748>
1236
1237         Reviewed by Alex Christensen.
1238
1239         This patch adds the function isStatisticsHasLocalStorage() to the
1240         TestRunner. With it, the page can query the WebsiteDataStore in the
1241         UI process to make sure that it sees LocalStorage.
1242
1243         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1245         (WTR::TestRunner::isStatisticsHasLocalStorage):
1246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1247         * WebKitTestRunner/TestController.cpp:
1248         (WTR::TestController::isStatisticsHasLocalStorage):
1249         * WebKitTestRunner/TestController.h:
1250         * WebKitTestRunner/TestInvocation.cpp:
1251         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1252
1253 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1254
1255         API::Data::createWithoutCopying should do a null check before calling CFRelease
1256         https://bugs.webkit.org/show_bug.cgi?id=196276
1257         <rdar://problem/48059859>
1258
1259         Reviewed by Alex Christensen.
1260
1261         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1262
1263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1264         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1265         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1266         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1267         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1268         (TestWebKitAPI::TEST):
1269
1270 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1271
1272         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1273         https://bugs.webkit.org/show_bug.cgi?id=186276
1274
1275         Reviewed by Carlos Garcia Campos.
1276
1277         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1278         (webViewLoadChanged):
1279         (testWebResourceGetDataError):
1280         (testWebResourceGetDataEmpty):
1281         (beforeAll):
1282         (webViewloadChanged): Deleted.
1283
1284 2019-03-27  Andy Estes  <aestes@apple.com>
1285
1286         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1287         https://bugs.webkit.org/show_bug.cgi?id=196317
1288
1289         Reviewed by Dan Bernstein.
1290
1291         package-root copies built products into a staging directory using ditto(1), which does not
1292         follow symbolic links as it traverses a directory. Now that the files in
1293         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1294         itself, these become broken links when ditto'd into the staging directory.
1295
1296         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1297
1298         * Scripts/package-root:
1299
1300 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-app] Update display text of Submit for ews analysis
1303         https://bugs.webkit.org/show_bug.cgi?id=196309
1304
1305         Reviewed by Dewei Zhu.
1306
1307         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1308
1309 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1310
1311         run-webkit-tests should check for leaks in WebKit processes
1312         <https://webkit.org/b/193772>
1313         <rdar://problem/46526680>
1314
1315         Reviewed by Ryosuke Niwa.
1316
1317         This works by doing the following:
1318         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1319           The list of child processes are returned one per line:
1320           process.name: pid
1321         - Run the "#LIST CHILD PROCESSES" command just before the
1322           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1323           processes on the ServerProcess object.
1324         - When the `--leaks` switch is handled, run check_for_leaks() on
1325           each child process after the main test harness.
1326
1327         * DumpRenderTree/mac/DumpRenderTree.mm:
1328         (handleControlCommand):
1329         - Use strncmp() instead of strcmp().
1330         - Add support for handling "#LIST CHILD PROCESSES" command.
1331
1332         * Scripts/webkitpy/port/base.py:
1333         (Port.check_for_leaks):
1334         * Scripts/webkitpy/port/darwin.py:
1335         (DarwinPort.check_for_leaks):
1336         - Rename redundant 'process_pid' argument to 'process_id'.
1337
1338         * Scripts/webkitpy/port/driver.py:
1339         (Driver.do_post_tests_work):
1340         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1341           longer the only command this sends to WebKitTestRunner.
1342         - If the `--leaks` switch is present, send the
1343           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1344           result using Port.set_webkit_processes().
1345         (Driver._parse_child_processes_output):
1346         - Add helper method to parse list of child process names and
1347           process IDs returned from WebKitTestRunner.
1348
1349         * Scripts/webkitpy/port/ios_device.py:
1350         (IOSDevicePort.check_for_leaks):
1351         - Rename redundant 'process_pid' argument to 'process_id'.
1352
1353         * Scripts/webkitpy/port/leakdetector.py:
1354         (LeakDetector._parse_leaks_output):
1355         - Return early if there is no leaks_output.
1356         (LeakDetector.check_for_leaks):
1357         - Rename redundant 'process_pid' argument to 'process_id'.
1358
1359         * Scripts/webkitpy/port/server_process.py:
1360         (ServerProcess.__init__):
1361         (ServerProcess.child_processes):
1362         (ServerProcess.set_child_processes):
1363         - Add instance variable to Port to store list of child process
1364           names and process IDs returned from WebKitTestRunner.
1365         (ServerProcess._start):
1366         - Clear self._child_processes.
1367         (ServerProcess.stop):
1368         - If self._child_processes is set, call
1369           self._port.check_for_leaks() for each child process.
1370
1371         * Scripts/webkitpy/port/server_process_unittest.py:
1372         (TrivialMockPort.check_for_leaks):
1373         - Rename redundant 'process_pid' argument to 'process_id'.
1374
1375         * Scripts/webkitpy/port/simulator_process.py:
1376         (SimulatorProcess.stop):
1377         - If self._child_processes is set, call
1378           self._port.check_for_leaks() for each child process.
1379
1380         * Scripts/webkitpy/port/watch_device.py:
1381         (WatchDevicePort.check_for_leaks):
1382         - Rename redundant 'process_pid' argument to 'process_id'.
1383
1384         * WebKitTestRunner/TestController.cpp:
1385         (WTR::TestController::dumpResponse):
1386         - Extract method from findAndDumpWorldLeaks() so that it may be
1387           reused by findAndDumpWebKitProcessIdentifiers().
1388         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1389         - Add method to output process name and process ID of both the
1390           WebContent and Networking processes.
1391         (WTR::TestController::findAndDumpWorldLeaks):
1392         - Fix missing newline in output when there were no abandoned
1393           documents.
1394         - Call dumpResponse() for extracted code.
1395         (WTR::TestController::handleControlCommand):
1396         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1397         - Use strncmp() instead of strcmp().
1398         - Call findAndDumpWebKitProcessIdentifiers() when
1399           "#LIST CHILD PROCESSES" command is sent.
1400         * WebKitTestRunner/TestController.h:
1401         (WTR::TestController::dumpResponse):
1402         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1403         - Declare methods.
1404
1405 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1406
1407         Unreviewed. Add GLib API test cases after r243434.
1408
1409         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1410         (testWebViewActiveURI):
1411         (serverCallback):
1412         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1413         (sendRequestCallback):
1414
1415 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1416
1417         Geolocation request not complete when watch request was started in a different web process
1418         https://bugs.webkit.org/show_bug.cgi?id=195996
1419
1420         Reviewed by Alex Christensen.
1421
1422         Add a test case.
1423
1424         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1425         (TestWebKitAPI::runJavaScriptAlert):
1426         (TestWebKitAPI::TEST):
1427
1428 2019-03-26  Keith Rollin  <krollin@apple.com>
1429
1430         Update the way generate-xcfilelists returns strings from functions
1431         https://bugs.webkit.org/show_bug.cgi?id=195975
1432         <rdar://problem/49040807>
1433
1434         Reviewed by Dean Jackson.
1435
1436         There are places where generate-xcfilelists executes assignments with
1437         statements like:
1438
1439             FOO=$(some_function)
1440
1441         where "some_function" return a string by echoing it. E.g.
1442
1443             some_function()
1444             {
1445                 echo "Hello, World"
1446             }
1447
1448         This is a common idiom, but it has a problem if "some_function" needs
1449         to call "exit" in an attempt to halt the entire script right then and
1450         there. Since "some_function" is called inside of $(), it's being
1451         executed in a sub-shell. Calling exit in that sub-shell simply exits
1452         that shell; it doesn't not exit the outer shell in which the main part
1453         of the script is still running. As such, the main script keeps
1454         executing when the intent was for the script to halt.
1455
1456         The solution to this is to use a different idiom for returning
1457         strings. The one we now is to pass in the name of the variable to
1458         receive the string result:
1459
1460             some_function()
1461             {
1462                 variable_name=$1
1463                 eval $variable_name ="Hello, World"
1464             }
1465
1466         The call site now looks like
1467
1468             some_function FOO
1469
1470         Because there's no invocation of a sub-shell, some_function can now
1471         call "exit" if it wants to, and the entire script will exit at that
1472         point.
1473
1474         * Scripts/generate-xcfilelists:
1475
1476 2019-03-26  Chris Dumez  <cdumez@apple.com>
1477
1478         Add basic layout test coverage for File Picker on iOS
1479         https://bugs.webkit.org/show_bug.cgi?id=196265
1480
1481         Reviewed by Wenson Hsieh.
1482
1483         Add layout test infrastructure to test the file picker on iOS.
1484
1485         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1486         (WTR::UIScriptController::dismissFilePicker):
1487         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1488         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1489         (WTR::UIScriptController::dismissFilePicker):
1490         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1491         * WebKitTestRunner/TestController.cpp:
1492         (WTR::TestController::createWebViewWithOptions):
1493         (WTR::updateTestOptionsFromTestHeader):
1494         * WebKitTestRunner/TestOptions.h:
1495         (WTR::TestOptions::hasSameInitializationOptions const):
1496         * WebKitTestRunner/ios/TestControllerIOS.mm:
1497         (overridePresentViewController):
1498         (WTR::TestController::platformInitialize):
1499         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1500         (WTR::UIScriptController::dismissFilePicker):
1501
1502 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1503
1504         Implement async paste method on UIWKInteractionViewProtocol
1505         https://bugs.webkit.org/show_bug.cgi?id=196267
1506         <rdar://problem/49236346>
1507
1508         Reviewed by Tim Horton.
1509
1510         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1511         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1512         are now a part of all iOS 12 internal SDKs.
1513
1514         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1515
1516         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1517         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1518
1519         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1520         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1521         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1522         * TestWebKitAPI/ios/UIKitSPI.h:
1523
1524 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1525
1526         [ews-build] Use PostgreSQL for ews.webkit.org database
1527         https://bugs.webkit.org/show_bug.cgi?id=196270
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1532
1533 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1534
1535         [ews] Reset simctl states on reboot
1536         https://bugs.webkit.org/show_bug.cgi?id=196260
1537
1538         Rubber-stamped by Aakash Jain.
1539
1540         * EWSTools/start-queue-mac.sh:
1541
1542 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1543
1544         [ews-build] Use PostgreSQL for ews-build database
1545         https://bugs.webkit.org/show_bug.cgi?id=196229
1546
1547         Reviewed by Lucas Forschler.
1548
1549         * BuildSlaveSupport/ews-build/master.cfg:
1550
1551 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-build] Get master_hostname dynamically in master.cfg
1554         https://bugs.webkit.org/show_bug.cgi?id=196255
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1559         send events data in test mode.
1560
1561 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1562
1563         [ews-app] Set db_constraint to False for Foreign Keys
1564         https://bugs.webkit.org/show_bug.cgi?id=196252
1565
1566         Reviewed by Lucas Forschler.
1567
1568         * BuildSlaveSupport/ews-app/ews/models/build.py:
1569         * BuildSlaveSupport/ews-app/ews/models/step.py:
1570
1571 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1572
1573         [ews-build] is_test_mode_enabled should default to True
1574         https://bugs.webkit.org/show_bug.cgi?id=196248
1575
1576         Reviewed by Lucas Forschler.
1577
1578         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1579
1580 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1581
1582         [ews-app] Add webkitperl to ENABLED_QUEUES
1583         https://bugs.webkit.org/show_bug.cgi?id=196253
1584
1585         Reviewed by Lucas Forschler.
1586
1587         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1588
1589 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1590
1591         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1592         https://bugs.webkit.org/show_bug.cgi?id=196211
1593         rdar://problem/49110552
1594
1595         Reviewed by Tim Horton.
1596
1597         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1598         Make sure that EventSenderProxy always exists when running tests. We used to create
1599         it when resetting before the first test, which is a bit too late.
1600
1601         * WebKitTestRunner/TestController.h:
1602         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1603         (WTR::TestController::platformCreateWebView):
1604         (WTR::TestController::platformCreateOtherPage):
1605         (WTR::TestController::finishCreatingPlatformWebView):
1606         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1607         (WTR::PlatformWebView::PlatformWebView):
1608         Moved some code that made NSWindow use NSEvent during web view creation. We may
1609         need to move more if some other case us found, but this is enough for now.
1610
1611 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1612
1613         Unreviewed. Fix typo in GLib geolocation API after r243285.
1614
1615         gelocation -> geolocation.
1616
1617         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1618         (testGeolocationManagerWatchPosition):
1619
1620 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1621
1622         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1623         https://bugs.webkit.org/show_bug.cgi?id=196213
1624
1625         Reviewed by Geoff Garen.
1626
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1629         (credentialWithIdentityAndKeychainPath):
1630         (-[ChallengeDelegate webView:didFinishNavigation:]):
1631         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1632         (TestWebKitAPI::TEST):
1633
1634 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1635
1636         Expected shouldn't assume its contained types are copyable
1637         https://bugs.webkit.org/show_bug.cgi?id=195986
1638
1639         Reviewed by JF Bastien.
1640
1641         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1642         (TestWebKitAPI::NonCopyable::operator== const):
1643         (TestWebKitAPI::NonCopyable::operator!= const):
1644         (TestWebKitAPI::TEST):
1645
1646 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1647
1648         Remove some now-unnecessary dynamic class lookup
1649         https://bugs.webkit.org/show_bug.cgi?id=196237
1650
1651         Reviewed by Simon Fraser.
1652
1653         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1654         (makeRequest):
1655         (TEST):
1656
1657 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1658
1659         Unreviewed, rolling out r243450.
1660
1661         AppleWin and WinCairo port builds get broken.
1662
1663         Reverted changeset:
1664
1665         "Add test for fix of #196095"
1666         https://bugs.webkit.org/show_bug.cgi?id=196097
1667         https://trac.webkit.org/changeset/243450
1668
1669 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1670
1671         Unreviewed, rolling out r243465.
1672         https://bugs.webkit.org/show_bug.cgi?id=196226
1673
1674         the test doesn't build (Requested by thorton on #webkit).
1675
1676         Reverted changeset:
1677
1678         "Do not terminate the NetworkProcess if a third party
1679         application sends a NSCredential with a SecIdentityRef"
1680         https://bugs.webkit.org/show_bug.cgi?id=196213
1681         https://trac.webkit.org/changeset/243465
1682
1683 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1684
1685         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1686         https://bugs.webkit.org/show_bug.cgi?id=196213
1687
1688         Reviewed by Geoff Garen.
1689
1690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1691         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1692         (credentialWithIdentityAndKeychainPath):
1693         (-[ChallengeDelegate webView:didFinishNavigation:]):
1694         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1695         (TestWebKitAPI::TEST):
1696
1697 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1698
1699         [ews-build] Gracefully handle missing patch_id in events
1700         https://bugs.webkit.org/show_bug.cgi?id=196216
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/ews-build/events.py:
1705
1706 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-build] use lz4 compression for improving buildbot performance
1709         https://bugs.webkit.org/show_bug.cgi?id=196155
1710
1711         Reviewed by Lucas Forschler.
1712
1713         * BuildSlaveSupport/ews-build/master.cfg:
1714
1715 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1716
1717         Pull some API testing helper methods out of TestWKWebView
1718         https://bugs.webkit.org/show_bug.cgi?id=196212
1719
1720         Reviewed by Tim Horton.
1721
1722         Refactor some more API testing utility methods, so that they can be used in
1723         tests that do not use TestWKWebView.
1724
1725         * TestWebKitAPI/cocoa/TestWKWebView.h:
1726         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1727         (-[WKWebView loadTestPageNamed:]):
1728         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1729         (-[WKWebView synchronouslyLoadHTMLString:]):
1730         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1731         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1732         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1733         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1734         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1735
1736 2019-03-25  Jer Noble  <jer.noble@apple.com>
1737
1738         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1739         https://bugs.webkit.org/show_bug.cgi?id=196097
1740
1741         Reviewed by Eric Carlson.
1742
1743         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (resetWebPreferencesToConsistentValues):
1747         * WebKitTestRunner/TestController.cpp:
1748         (WTR::TestController::resetPreferencesToConsistentValues):
1749
1750 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1751
1752         Pull IPadUserInterfaceSwizzler out into a separate header file
1753         https://bugs.webkit.org/show_bug.cgi?id=196193
1754
1755         Reviewed by Anders Carlsson.
1756
1757         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1758         be used in other API tests.
1759
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1761         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1762         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1763         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1764         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1765         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1766         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1767
1768 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1769
1770         Remove NavigatorContentUtils in WebCore/Modules
1771         https://bugs.webkit.org/show_bug.cgi?id=196070
1772
1773         Reviewed by Alex Christensen.
1774
1775         NavigatorContentUtils was to support the custom scheme spec [1].
1776         However, in WebKit side, no port has supported the feature in
1777         WebKit layer after EFL port was removed. So there has been the
1778         only IDL implementation of the NavigatorContentUtils in WebCore.
1779         So we don't need to keep the implementation in WebCore anymore.
1780
1781         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1782
1783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1784
1785 2019-03-24  Andy Estes  <aestes@apple.com>
1786
1787         [watchOS] Remove unused Proximity Networking code
1788         https://bugs.webkit.org/show_bug.cgi?id=196188
1789
1790         Reviewed by Tim Horton.
1791
1792         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1793         (TEST):
1794
1795 2019-03-23  Keith Miller  <keith_miller@apple.com>
1796
1797         Refactor clz/ctz and fix getLSBSet.
1798         https://bugs.webkit.org/show_bug.cgi?id=196162
1799
1800         Reviewed by Saam Barati.
1801
1802         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1803
1804         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1805         (TestWebKitAPI::TEST):
1806
1807 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1808
1809         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1810         https://bugs.webkit.org/show_bug.cgi?id=196143
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1815         directories.
1816
1817         * Scripts/webkitpy/style/checkers/cpp.py:
1818         (check_identifier_name_in_declaration):
1819         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1820         (WebKitStyleTest.test_names):
1821
1822 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1823
1824         [Flatpak] Manifest expanding fails for qt WPE extension
1825         https://bugs.webkit.org/show_bug.cgi?id=196148
1826
1827         Reviewed by Alex Christensen.
1828
1829         * flatpak/flatpakutils.py:
1830         (expand_submodules_recurse): The last recurse manifest expand
1831         iteration might lead to a single module so take it into account
1832         and don't try to recurse further.
1833
1834 2019-03-22  Chris Dumez  <cdumez@apple.com>
1835
1836         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1837         https://bugs.webkit.org/show_bug.cgi?id=195348
1838         <rdar://problem/48622090>
1839
1840         Reviewed by Alex Christensen.
1841
1842         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1843         to NO when test.options().shouldIgnoreMetaViewport is false.
1844
1845         * WebKitTestRunner/ios/TestControllerIOS.mm:
1846         (WTR::TestController::platformConfigureViewForTest):
1847
1848 2019-03-22  Chris Dumez  <cdumez@apple.com>
1849
1850         Prewarmed processes should be usable with any website data store
1851         https://bugs.webkit.org/show_bug.cgi?id=196104
1852
1853         Reviewed by Alex Christensen.
1854
1855         Add API test coverage.
1856
1857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1858         (runInitialWarmedProcessUsedTest):
1859         (TEST):
1860
1861 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1862
1863         Back out local changes to Alex's Subversion working directory
1864
1865         They were accidentally committed.
1866
1867         * Scripts/webkitpy/common/system/abstractexecutive.py:
1868         (AbstractExecutive.wait_newest):
1869         * Scripts/webkitpy/common/system/executive.py:
1870         (Executive.running_pids):
1871         * Scripts/webkitpy/common/system/executive_mock.py:
1872         (MockExecutive.running_pids):
1873         * Scripts/webkitpy/common/system/executive_unittest.py:
1874         (ExecutiveTest.serial_test_running_pids):
1875         * Scripts/webkitpy/port/darwin.py:
1876         (DarwinPort.check_for_leaks):
1877         * Scripts/webkitpy/port/leakdetector.py:
1878         (LeakDetector.check_for_leaks):
1879         - This was the hack attached to Bug 193772.
1880
1881         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1882         (+[WebKitTestRunnerEvent mouseLocation]):
1883         - This works around a crash on an internal build.
1884
1885 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1886
1887         Fix the build after r243354
1888         https://bugs.webkit.org/show_bug.cgi?id=196138
1889         <rdar://problem/49145951>
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1892         (TEST):
1893         * TestWebKitAPI/ios/UIKitSPI.h:
1894
1895 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1896
1897         Adopt UIWKDocumentContext
1898         https://bugs.webkit.org/show_bug.cgi?id=196040
1899         <rdar://problem/48642440>
1900
1901         Reviewed by Ryosuke Niwa.
1902
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1905         (makeRequest):
1906         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1907         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1908         (applyStyle):
1909         (TEST):
1910         Add tests for UIWKDocumentContext.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1913         (TEST):
1914         (recursiveFindWKContentView): Deleted.
1915         * TestWebKitAPI/cocoa/TestWKWebView.h:
1916         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1917         (recursiveFindWKContentView):
1918         (-[TestWKWebView wkContentView]):
1919         * TestWebKitAPI/ios/UIKitSPI.h:
1920         Share the WKContentView finding code between tests.
1921
1922 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1923
1924         [iOS WK2] Turn on async overflow scrolling by default
1925         https://bugs.webkit.org/show_bug.cgi?id=196011
1926         rdar://problem/48453859
1927
1928         Reviewed by Antti Koivisto.
1929         
1930         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1931         since so many basic layout tests have different results when compositing is triggered for
1932         overflow.
1933         
1934         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1935
1936         * WebKitTestRunner/TestController.cpp:
1937         (WTR::TestController::resetPreferencesToConsistentValues):
1938
1939 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1940
1941         [ews-build] Retry API test in case of failures
1942         https://bugs.webkit.org/show_bug.cgi?id=196004
1943
1944         Reviewed by Lucas Forschler.
1945
1946         * BuildSlaveSupport/ews-build/steps.py:
1947         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1948         (CompileWebKitToT.doStepIf): Ditto.
1949         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1950         (ReRunAPITests): Re-run API tests.
1951         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1952         (RunAPITestsWithoutPatch): Run API tests without patch.
1953         (RunAPITestsWithoutPatch.doStepIf):
1954         (RunAPITestsWithoutPatch.hideStepIf):
1955         (RunAPITestsWithoutPatch.evaluateCommand):
1956         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1957         (AnalyzeAPITestsResults.start):
1958         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1959         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1960         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1961         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1962
1963 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews-build] Update queues configurations
1966         https://bugs.webkit.org/show_bug.cgi?id=196074
1967
1968         Reviewed by Dewei Zhu.
1969
1970         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1971         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1972
1973 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1974
1975         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1976         https://bugs.webkit.org/show_bug.cgi?id=195680
1977         <rdar://problem/48903534>
1978
1979         Unreviewed infrastructure fix.
1980
1981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1982         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1983
1984 2019-03-21  Andy Estes  <aestes@apple.com>
1985
1986         [iOS] Apple Pay should be available in documents with no user agent scripts
1987         https://bugs.webkit.org/show_bug.cgi?id=196061
1988         <rdar://problem/48649391>
1989
1990         Reviewed by Brady Eidson.
1991
1992         Added API tests and related infrastructure.
1993
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1996         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1997         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1998         (TestWebKitAPI::TEST):
1999         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2000         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2001         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2002         * TestWebKitAPI/cocoa/TestProtocol.mm:
2003         (-[TestProtocol startLoading]):
2004         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2005         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2006         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2007         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2008
2009 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2010
2011         REGRESSSION (r243297): webkitpy tests broken
2012         https://bugs.webkit.org/show_bug.cgi?id=196108
2013
2014         Reviewed by Aakash Jain.
2015
2016         r243297 updated contributors.json, which broke a few unit tests.
2017
2018         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2019         (IRCCommandTest.test_whois):
2020         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2021
2022 2019-03-21  Chris Dumez  <cdumez@apple.com>
2023
2024         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2025         https://bugs.webkit.org/show_bug.cgi?id=196041
2026         <rdar://problem/49083230>
2027
2028         Reviewed by Alex Christensen.
2029
2030         Add API test coverage.
2031
2032         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2033         (TEST):
2034
2035 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2036
2037         Add SPI to inform applications of WKContentRuleList actions
2038         https://bugs.webkit.org/show_bug.cgi?id=195965
2039         <rdar://problem/42664365>
2040
2041         Reviewed by Geoff Garen.
2042
2043         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2044         (TestWebKitAPI::allActionsForResourceLoad):
2045         (TestWebKitAPI::testRequest):
2046         (TestWebKitAPI::TEST_F):
2047         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2048         (Notification::description):
2049         (Notification::operator== const):
2050         (toVector):
2051         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2052         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2053         (makeContentRuleList):
2054         (TEST):
2055         (makeWarnContentRuleList): Deleted.
2056
2057 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2058
2059         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2060         https://bugs.webkit.org/show_bug.cgi?id=196088
2061
2062         Reviewed by Brian Burg.
2063
2064         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2065         Support checks when only one platform is specified. Also deprecate macosx() and
2066         force the use of macos() instead.
2067
2068         * Scripts/webkitpy/style/checkers/cpp.py:
2069         (check_min_versions_of_wk_api_available):
2070         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2071         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2072
2073 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2074
2075         Update status inactive committers' status to 'contributor'.
2076
2077         * Scripts/webkitpy/common/config/contributors.json:
2078
2079 2019-03-21  Xan Lopez  <xan@igalia.com>
2080
2081         [JSC][x86] Drop support for x87 floating point
2082         https://bugs.webkit.org/show_bug.cgi?id=194853
2083
2084         Reviewed by Don Olmstead.
2085
2086         Force SSE2 on x86/32bit builds.
2087
2088         * Scripts/webkitdirs.pm:
2089         (generateBuildSystemFromCMakeProject):
2090
2091 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2092
2093         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2094         https://bugs.webkit.org/show_bug.cgi?id=196073
2095
2096         Reviewed by Michael Catanzaro.
2097
2098         Add test cases to check functions and constructors with no arguments but receiving user data.
2099
2100         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2101         (checkUserData):
2102         (testJSCFunction):
2103         (fooCreateWithUserData):
2104         (testJSCClass):
2105
2106 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2107
2108         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2109
2110         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2111
2112         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2113
2114 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2115
2116         [GTK][WPE] Add API to provide geolocation information
2117         https://bugs.webkit.org/show_bug.cgi?id=195940
2118
2119         Reviewed by Michael Catanzaro.
2120
2121         Add a new test to check the new API.
2122
2123         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2124         (testGeolocationManagerCurrentPosition):
2125         (testGeolocationManagerWatchPosition):
2126         (beforeAll):
2127         (afterAll):
2128         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2129         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2130         (beforeAll): Ditto.
2131         * TestWebKitAPI/glib/CMakeLists.txt:
2132
2133 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2134
2135         [GLib] Returning G_TYPE_OBJECT from a method does not work
2136         https://bugs.webkit.org/show_bug.cgi?id=195574
2137
2138         Reviewed by Michael Catanzaro.
2139
2140         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2141
2142         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2143         (getGFile):
2144         (getParent):
2145         (createGString):
2146         (getGString):
2147         (getGStringCopyWillRaise):
2148         (getGStringCopy):
2149         (getGStringStr):
2150         (getGStringLen):
2151         (freeGString):
2152         (testJSCClass):
2153
2154 2019-03-20  Saam Barati  <sbarati@apple.com>
2155
2156         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2157         https://bugs.webkit.org/show_bug.cgi?id=195721
2158
2159         Reviewed by Filip Pizlo.
2160
2161         * Scripts/run-javascriptcore-tests:
2162
2163 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2164
2165         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2166         https://bugs.webkit.org/show_bug.cgi?id=196049
2167
2168         Reviewed by Tim Horton.
2169
2170         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2171         overflow scrolling in general, so rename it.
2172
2173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2174
2175 2019-03-20  Daniel Bates  <dabates@apple.com>
2176
2177         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2178         https://bugs.webkit.org/show_bug.cgi?id=196031
2179         <rdar://problem/49078172>
2180
2181         Reviewed by Tim Horton.
2182
2183         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2184         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2185         same code path used when the Done button is pressed to dismiss the <select> picker.
2186
2187         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2188         (TestWebKitAPI::TEST):
2189
2190 2019-03-20  Chris Dumez  <cdumez@apple.com>
2191
2192         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2193         https://bugs.webkit.org/show_bug.cgi?id=196029
2194         <rdar://problem/48954651>
2195
2196         Reviewed by Tim Horton.
2197
2198         Add API test coverage.
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2201
2202 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2203
2204         [ews-build] Improve failure summary string for ApplyPatch step
2205         https://bugs.webkit.org/show_bug.cgi?id=195995
2206
2207         Reviewed by Alexey Proskuryakov.
2208
2209         * BuildSlaveSupport/ews-build/steps.py:
2210         (ApplyPatch.getResultSummary): Override getResultSummary.
2211
2212 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2213
2214         AX: Implement support for new meter ARIA role
2215         https://bugs.webkit.org/show_bug.cgi?id=195966
2216
2217         Reviewed by Chris Fleizach.
2218
2219         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2220         to AXLevelIndicator.
2221
2222         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2223
2224 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2225
2226         [WebAuthN] Implement FIDO AppID extension
2227         https://bugs.webkit.org/show_bug.cgi?id=143491
2228         <rdar://problem/48298273>
2229
2230         Reviewed by Brent Fulgham.
2231
2232         Add a test that covers the new flag of convertToU2fSignCommand.
2233
2234         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2235         (TestWebKitAPI::TEST):
2236         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2237         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2238         (TestWebKitAPI::TEST):
2239
2240 2019-03-19  Keith Rollin  <krollin@apple.com>
2241
2242         Add support for more platforms to generate-xcfilelists
2243         https://bugs.webkit.org/show_bug.cgi?id=195977
2244
2245         Reviewed by Alexey Proskuryakov.
2246
2247         generate-xcfilelists incorrectly complains when involved with building
2248         WebKit for iphonesimulator:
2249
2250             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2251             …
2252             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2253
2254         Address this by teaching generate-xcfilelists about more platforms.
2255
2256         * Scripts/generate-xcfilelists:
2257
2258 2019-03-19  John Wilander  <wilander@apple.com>
2259
2260         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2261         https://bugs.webkit.org/show_bug.cgi?id=195923
2262         <rdar://problem/49001272>
2263
2264         Reviewed by Alex Christensen.
2265
2266         This patch does the following to the TestRunner:
2267         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2268         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2269         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2270
2271         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2272         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2273         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2274         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2275         * WebKitTestRunner/TestController.cpp:
2276         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2277         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2278         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2279         * WebKitTestRunner/TestController.h:
2280         * WebKitTestRunner/TestInvocation.cpp:
2281         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2282
2283 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2284
2285         [CMake] Support more clang and gcc sanitizers
2286         https://bugs.webkit.org/show_bug.cgi?id=195956
2287
2288         Reviewed by Michael Catanzaro.
2289
2290         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2291
2292 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-build] Improve summary for PrintConfiguration step
2295         https://bugs.webkit.org/show_bug.cgi?id=195945
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-build/steps.py:
2300         (PrintConfiguration.getResultSummary): Override getResultSummary.
2301
2302 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [ews-build] Improve summary for CheckOutSource step
2305         https://bugs.webkit.org/show_bug.cgi?id=195963
2306
2307         Reviewed by Lucas Forschler.
2308
2309         * BuildSlaveSupport/ews-build/steps.py:
2310         (CheckOutSource.getResultSummary):
2311
2312 2019-03-19  Daniel Bates  <dabates@apple.com>
2313
2314         [iOS] Focus not preserved when switching between tabs
2315         https://bugs.webkit.org/show_bug.cgi?id=195820
2316         <rdar://problem/43614450>
2317
2318         Reviewed by Brent Fulgham.
2319
2320         Add tests to ensure that we restore focus when resigning and becoming first responder.
2321
2322         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2323         (TestWebKitAPI::TEST):
2324
2325 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2326
2327         Make WTFLogChannelState and WTFLogLevel enum classes
2328         https://bugs.webkit.org/show_bug.cgi?id=195904
2329
2330         Reviewed by Eric Carlson.
2331
2332         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2333         (TestWebKitAPI::TEST_F):
2334
2335 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2336
2337         [GStreamer][EME] Backported mssdemux protection data crash fix
2338         https://bugs.webkit.org/show_bug.cgi?id=195918
2339
2340         Reviewed by Philippe Normand.
2341
2342         * gstreamer/jhbuild.modules:
2343         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2344
2345 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2346
2347         Unreviewed, rolling out r243132.
2348
2349         Broke GTK build
2350
2351         Reverted changeset:
2352
2353         "Make WTFLogChannelState and WTFLogLevel enum classes"
2354         https://bugs.webkit.org/show_bug.cgi?id=195904
2355         https://trac.webkit.org/changeset/243132
2356
2357 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2358
2359         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2360
2361         * Scripts/webkitdirs.pm:
2362         (builtDylibPathForName): Adjust the shared library name that's changed
2363         with the API version bump in r243073.
2364
2365 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2366
2367         Make WTFLogChannelState and WTFLogLevel enum classes
2368         https://bugs.webkit.org/show_bug.cgi?id=195904
2369
2370         Reviewed by Eric Carlson.
2371
2372         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2373         (TestWebKitAPI::TEST_F):
2374
2375 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2376
2377         Disable flaky test added in r2431100
2378         https://webkit.org/b/195785
2379
2380         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2381         (TestWebKitAPI::TEST):
2382         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2383
2384 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2385
2386         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2387         https://bugs.webkit.org/show_bug.cgi?id=195916
2388
2389         Reviewed by Tim Horton.
2390
2391         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2392         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2393
2394 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2395
2396         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2397
2398         * Scripts/webkitpy/common/config/contributors.json:
2399
2400 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2401
2402         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2403         https://bugs.webkit.org/show_bug.cgi?id=195785
2404
2405         Reviewed by Geoffrey Garen.
2406
2407         * TestWebKitAPI/TCPServer.cpp: Added.
2408         (TestWebKitAPI::TCPServer::TCPServer):
2409         (TestWebKitAPI::TCPServer::~TCPServer):
2410         (TestWebKitAPI::TCPServer::socketBindListen):
2411         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2412         * TestWebKitAPI/TCPServer.h: Added.
2413         (TestWebKitAPI::TCPServer::port const):
2414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2415         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2416         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2417         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2418         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2419         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2420         (TestWebKitAPI::respondSlowly):
2421         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2422         (TestWebKitAPI::downloadAtRate):
2423         (TestWebKitAPI::TEST):
2424
2425 2019-03-18  Saam Barati  <sbarati@apple.com>
2426
2427         Add a plan file for JetStream 2
2428         https://bugs.webkit.org/show_bug.cgi?id=190734
2429
2430         Reviewed by Mark Lam.
2431
2432         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2433
2434 2019-03-18  Chris Dumez  <cdumez@apple.com>
2435
2436         Delay WebProcess launch until a load is triggered in a Web view
2437         https://bugs.webkit.org/show_bug.cgi?id=195758
2438         <rdar://problem/48126013>
2439
2440         Reviewed by Geoff Garen.
2441
2442         Add API test coverage. Also update some existing API tests to not expect
2443         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2444
2445         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2446         (TestWebKitAPI::TEST):
2447         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2448         (TestWebKitAPI::TEST):
2449         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2450         (TEST):
2451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2452         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2453         (TEST):
2454         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2455         (TEST):
2456         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2457
2458 2019-03-18  Xan Lopez  <xan@igalia.com>
2459
2460         [CMake] Prevent potential warning when determining $architecture
2461         https://bugs.webkit.org/show_bug.cgi?id=195891
2462
2463         Reviewed by Michael Catanzaro.
2464
2465         It's possible for generateBuildSystemForCMakeProject to be called
2466         before determineArchitecture() is ever called. This will make the
2467         first eq check with $architecture to be bogus (and print a
2468         warning). Change that to an eq check with architecture(), which
2469         implicitly calls determineArchitecture() if needed, and change all
2470         the other similar cases in the method in the same way to prevent
2471         future bugs like this one.
2472
2473         * Scripts/webkitdirs.pm:
2474         (generateBuildSystemFromCMakeProject):
2475
2476 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2477
2478         [WPE] Tarballs generated with “make dist” cannot build documentation
2479         https://bugs.webkit.org/show_bug.cgi?id=195885
2480
2481         Reviewed by Carlos Garcia Campos.
2482
2483         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2484
2485 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2486
2487         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2488         https://bugs.webkit.org/show_bug.cgi?id=195883
2489
2490         Reviewed by Carlos Garcia Campos.
2491
2492         * gtkdoc/gtkdoc.py:
2493         (GTKDoc._run_command): When commands fail to run, include the full command line for
2494         the program invocation and the output it has generated on the standard error stream.
2495
2496 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2497
2498         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2499         https://bugs.webkit.org/show_bug.cgi?id=195786
2500
2501         Reviewed by Philippe Normand.
2502
2503         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2504         * wpe/jhbuild.modules: Ditto.
2505
2506 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-build] Don't run clean builds on EWS builders
2509         https://bugs.webkit.org/show_bug.cgi?id=195851
2510
2511         Reviewed by Geoffrey Garen.
2512
2513         * BuildSlaveSupport/ews-build/factories.py:
2514
2515 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2516
2517         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2518         https://bugs.webkit.org/show_bug.cgi?id=195849
2519
2520         Reviewed by Chris Dumez.
2521
2522         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2523
2524         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2525         (runWebsiteDataStoreCustomPaths):
2526
2527 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2528
2529         webkitpy: Upload test results
2530         https://bugs.webkit.org/show_bug.cgi?id=195755
2531         <rdar://problem/48896182>
2532
2533         Reviewed by Aakash Jain.
2534
2535         Establish a new format for uploading results that is not tied to layout tests, apply
2536         that format to webkitpy tests.
2537
2538         * Scripts/webkitpy/common/checkout/scm/git.py:
2539         (Git.native_branch): Return what branch the current checkout is on.
2540         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2541         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2542         * Scripts/webkitpy/common/checkout/scm/svn.py:
2543         (SVN.native_branch): Ditto.
2544         * Scripts/webkitpy/common/system/platforminfo.py:
2545         (PlatformInfo.build_version): Return a build version for Mac.
2546         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2547         (MockPlatformInfo.__init__):
2548         (MockPlatformInfo.build_version):
2549         * Scripts/webkitpy/results: Added.
2550         * Scripts/webkitpy/results/__init__.py: Added.
2551         * Scripts/webkitpy/results/options.py: Added.
2552         (upload_options): OptParse list for upload options.
2553         * Scripts/webkitpy/results/upload.py: Added.
2554         (Upload): Class which enforces the upload format expected by the results server.
2555         (Upload.Expectations):
2556         (Upload.create_configuration):
2557         (Upload.create_commit):
2558         (Upload.create_details):
2559         (Upload.create_run_stats):
2560         (Upload.create_test_result):
2561         (Upload.__init__):
2562         (Upload.Encoder): Encode Upload object as json.
2563         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2564         * Scripts/webkitpy/results/upload_unittest.py: Added.
2565         * Scripts/webkitpy/test/main.py:
2566         (Tester._parse_args): Add upload arguments.
2567         (Tester._run_tests): Allow results to be uploaded.
2568         * Scripts/webkitpy/test/runner.py:
2569         (Runner.__init__): Record which tests were run, rather than just counting them.
2570         (Runner.handle):
2571         * Scripts/webkitpy/test/runner_unittest.py:
2572         (RunnerTest.test_run):
2573         * Scripts/webkitpy/thirdparty/__init__.py:
2574         (AutoinstallImportHook.find_module): Add requests auto-install.
2575         (AutoinstallImportHook._install_requests):
2576         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2577         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2578
2579 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2580
2581         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2582         https://bugs.webkit.org/show_bug.cgi?id=195810
2583
2584         Reviewed by Tim Horton.
2585
2586         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2587         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2588         ending certain layout tests.
2589
2590         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2591         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2592         (-[TestRunnerWKWebView dealloc]):
2593         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2594
2595         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2596         helper method when destroying the web view, and when resetting state between tests.
2597
2598         * WebKitTestRunner/ios/TestControllerIOS.mm:
2599         (WTR::TestController::platformResetStateToConsistentValues):
2600
2601         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2602
2603 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2604
2605         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2606         https://bugs.webkit.org/show_bug.cgi?id=190350
2607         <rdar://problem/45089503>
2608
2609         Reviewed by Geoffrey Garen.
2610
2611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2612         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2613         (TEST):
2614         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2615         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2616         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2617         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2618         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2619         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2620         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2621         (runTest):
2622         (createDirectories):
2623         (TEST):
2624         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2625         (TEST):
2626         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2627         (TEST):
2628
2629 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2630
2631         Add support to WebPage for getting the contents as an attributed string.
2632         https://bugs.webkit.org/show_bug.cgi?id=195636
2633         rdar://problem/45055697
2634
2635         Reviewed by Tim Horton.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2638         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2639
2640 2019-03-15  Chris Dumez  <cdumez@apple.com>
2641
2642         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2643         https://bugs.webkit.org/show_bug.cgi?id=195747
2644
2645         Reviewed by Geoff Garen.
2646
2647         Add API test coverage.
2648
2649         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2650
2651 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2652
2653         Unreviewed, rolling out r242952.
2654
2655         Causing API failures on iOS Simulator
2656
2657         Reverted changeset:
2658
2659         "[PSON] Make sure the WebProcessCache is leverage when
2660         relaunching a process after termination"
2661         https://bugs.webkit.org/show_bug.cgi?id=195747
2662         https://trac.webkit.org/changeset/242952
2663
2664 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2665
2666         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2667         https://bugs.webkit.org/show_bug.cgi?id=195740
2668
2669         Reviewed by Ross Kirsling.
2670
2671         window.open doesn't work for WebKitBrowserWindow because it is not
2672         implemented yet.
2673
2674         1. Implemented createNewPage callback of WKPageUIClient.
2675         2. Changed MainWindow to take a BrowserWindow factory function
2676           instead of BrowserWindowType to be flexible to create
2677           BrowserWindow with extra settings.
2678         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2679           because it is not relevant with MainWindow anymore.
2680
2681         * MiniBrowser/win/Common.cpp:
2682         (parseCommandLine):
2683         * MiniBrowser/win/Common.h:
2684         (CommandLineOptions::CommandLineOptions):
2685         * MiniBrowser/win/MainWindow.cpp:
2686         (MainWindow::MainWindow):
2687         (MainWindow::create):
2688         (MainWindow::init):
2689         (MainWindow::WndProc):
2690         * MiniBrowser/win/MainWindow.h:
2691         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2692         (PrintWebUIDelegate::createWebViewWithRequest):
2693         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2694         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2695         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2696         (WebKitBrowserWindow::updateProxySettings):
2697         (WebKitBrowserWindow::createNewPage):
2698         * MiniBrowser/win/WebKitBrowserWindow.h:
2699         * MiniBrowser/win/WinMain.cpp:
2700         (wWinMain):
2701
2702 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2703
2704         Make it possible to test scrolling tree layer manipulation more easily
2705         https://bugs.webkit.org/show_bug.cgi?id=195780
2706
2707         Reviewed by Tim Horton.
2708         
2709         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2710         cuts off communication of scrolling tree scrolls back to the web process
2711         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2712         allows tests to trigger scrolls which run the scrolling tree layer positioning
2713         logic, but never get another commit from the web process that might mask
2714         scrolling tree bugs.
2715         
2716         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2717         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2718         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2719
2720         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2721         (WTR::UIScriptController::scrollUpdatesDisabled const):
2722         (WTR::UIScriptController::setScrollUpdatesDisabled):
2723         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2724         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2725         (WTR::UIScriptController::scrollUpdatesDisabled const):
2726         (WTR::UIScriptController::setScrollUpdatesDisabled):
2727         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2728         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2729         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2730         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2731         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2732         * WebKitTestRunner/ios/TestControllerIOS.mm:
2733         (WTR::TestController::platformResetStateToConsistentValues):
2734         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2735         (WTR::UIScriptController::scrollUpdatesDisabled const):
2736         (WTR::UIScriptController::setScrollUpdatesDisabled):
2737
2738 2019-03-14  Youenn Fablet  <youenn@apple.com>
2739
2740         Move IDB storage in private browsing mode to NetworkProcess
2741         https://bugs.webkit.org/show_bug.cgi?id=195602
2742
2743         Reviewed by Brady Eidson.
2744
2745         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2746         (TEST):
2747
2748 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2749
2750         [ews-build] Make descriptionDone messages more readable
2751         https://bugs.webkit.org/show_bug.cgi?id=195760
2752
2753         Reviewed by Lucas Forschler.
2754
2755         * BuildSlaveSupport/ews-build/steps.py:
2756         * BuildSlaveSupport/ews-build/steps_unittest.py:
2757
2758 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2759
2760         [ews-build] Generate status-bubble hover-over messages
2761         https://bugs.webkit.org/show_bug.cgi?id=195680
2762
2763         Reviewed by Lucas Forschler.
2764
2765         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2766         (StatusBubble):
2767         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2768         on hover-over.
2769         (StatusBubble._iso_time):
2770         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2771         hover-over message.
2772         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2773
2774 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2775
2776         [ews-app] Gracefully handle the case when state_string is None
2777         https://bugs.webkit.org/show_bug.cgi?id=195753
2778
2779         Reviewed by Lucas Forschler.
2780
2781         * BuildSlaveSupport/ews-app/ews/models/build.py:
2782         * BuildSlaveSupport/ews-app/ews/models/step.py:
2783
2784 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2785
2786         [ews-app] Status bubble display pending for currently running build step
2787         https://bugs.webkit.org/show_bug.cgi?id=195744
2788
2789         Reviewed by Lucas Forschler.
2790
2791         * BuildSlaveSupport/ews-build/events.py:
2792         (Events.stepStarted): If state_string is pending, replace it with step name.
2793
2794 2019-03-14  Chris Dumez  <cdumez@apple.com>
2795
2796         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2797         https://bugs.webkit.org/show_bug.cgi?id=195750
2798
2799         Reviewed by Geoffrey Garen.
2800
2801         Add API test coverage.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2804         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2805         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2806         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2807
2808 2019-03-14  Chris Dumez  <cdumez@apple.com>
2809
2810         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2811         https://bugs.webkit.org/show_bug.cgi?id=195747
2812
2813         Reviewed by Geoff Garen.
2814
2815         Add API test coverage.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2818
2819 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2820
2821         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2822         https://bugs.webkit.org/show_bug.cgi?id=195725
2823         <rdar://problem/48545062>
2824
2825         Reviewed by Tim Horton.
2826
2827         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2828         handler is nil.
2829
2830         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2831         (TestWebKitAPI::TEST):
2832
2833 2019-03-13  Sam Weinig  <sam@webkit.org>
2834
2835         Add utility function to allow easy reverse range-based iteration of a container
2836         https://bugs.webkit.org/show_bug.cgi?id=195542
2837
2838         Reviewed by Antti Koivisto.
2839
2840         * TestWebKitAPI/CMakeLists.txt:
2841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2842         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2843         (TestWebKitAPI::TEST):
2844         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2845
2846 2019-03-13  Chris Dumez  <cdumez@apple.com>
2847
2848         Use a ServiceWorker process per registrable domain
2849         https://bugs.webkit.org/show_bug.cgi?id=195649
2850
2851         Reviewed by Youenn Fablet.
2852
2853         Update API test coverage.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2856
2857 2019-03-13  Chris Dumez  <cdumez@apple.com>
2858
2859         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2860         https://bugs.webkit.org/show_bug.cgi?id=195684
2861         <rdar://problem/48294714>
2862
2863         Reviewed by Antti Koivisto.
2864
2865         Add API test coverage.
2866
2867         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2868
2869 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2870
2871         [ews-app] Remove unused patch view
2872         https://bugs.webkit.org/show_bug.cgi?id=195669
2873
2874         Reviewed by Lucas Forschler.
2875
2876         * BuildSlaveSupport/ews-app/ews/urls.py:
2877         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2878
2879 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2880
2881         [ews-app] Use Buildbot result code variables
2882         https://bugs.webkit.org/show_bug.cgi?id=195668
2883
2884         Reviewed by Alexey Proskuryakov.
2885
2886         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2887         (Buildbot): Added Buildbot result code variables.
2888         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2889         (StatusBubble._build_bubble): Used Buildbot result code variables.
2890
2891 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2892
2893         [Flatpak] Expand submodule recursively
2894         https://bugs.webkit.org/show_bug.cgi?id=195672
2895
2896         Building WPE with flatpak was impossible without that as it was raising an exception.
2897         Also update wpebackend-fdo to match what is built in jhbuild
2898
2899         Reviewed by Philippe Normand.
2900
2901         * flatpak/flatpakutils.py:
2902         (expand_submodules_recurse):
2903         (expand_manifest):
2904         * flatpak/org.webkit.WPEModules.yaml:
2905
2906 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2907
2908         [ews-app] status bubble should be hidden for certain builds
2909         https://bugs.webkit.org/show_bug.cgi?id=194597
2910
2911         Reviewed by Dewei Zhu.
2912
2913         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2914         (StatusBubble._build_bubble):
2915         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2916         because the patch didn't have relevant changes.
2917         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2918         in production yet.
2919
2920 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2921
2922         [Win] Fix a slew of simple clang-cl warnings.
2923         https://bugs.webkit.org/show_bug.cgi?id=195652
2924
2925         Reviewed by Don Olmstead.
2926
2927         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2928         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2929
2930 2019-03-12  Justin Fan  <justin_fan@apple.com>
2931
2932         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2933         https://bugs.webkit.org/show_bug.cgi?id=195518
2934         <rdar://problem/46322356>
2935
2936         Reviewed by Myles C. Maxfield.
2937
2938         * DumpRenderTree/DerivedSources-input.xcfilelist:
2939         * DumpRenderTree/DerivedSources-output.xcfilelist:
2940
2941 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2942
2943         Unreviewed, rolling out r242825.
2944         https://bugs.webkit.org/show_bug.cgi?id=195648
2945
2946         "Broke webkitpy tests with my change to
2947         lldb_dump_class_layout.py" (Requested by rmorisset on
2948         #webkit).
2949
2950         Reverted changeset:
2951
2952         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2953         classes with suspicious padding"
2954         https://bugs.webkit.org/show_bug.cgi?id=195573
2955         https://trac.webkit.org/changeset/242825
2956
2957 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews-build] Show status bubbles while the patch is waiting in queue
2960         https://bugs.webkit.org/show_bug.cgi?id=195618
2961
2962         Reviewed by Lucas Forschler.
2963
2964         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2965         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2966         enabled in initial deployment.
2967         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2968         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2969         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2970         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2971         (StatusBubble._build_bubbles_for_patch):
2972
2973 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2974
2975         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2976         https://bugs.webkit.org/show_bug.cgi?id=195573
2977
2978         Reviewed by Simon Fraser.
2979
2980         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2981
2982         * Scripts/dump-class-layout:
2983         (main):
2984         * lldb/lldb_dump_class_layout.py:
2985         (ClassLayout.__init__):
2986         (ClassLayout._compute_padding_recursive):
2987         (LLDBDebuggerInstance.dump_layout_for_classname):
2988         (LLDBDebuggerInstance):
2989         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2990         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2991
2992 2019-03-12  Chris Dumez  <cdumez@apple.com>
2993
2994         Device Orientation access permission should be denied unless explicitly granted by the client
2995         https://bugs.webkit.org/show_bug.cgi?id=195625
2996
2997         Reviewed by Youenn Fablet.
2998
2999         add API test coverage.
3000
3001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3002         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3003         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3004         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3005         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3006         (runDeviceOrientationTest):
3007         (TEST):
3008         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3009         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3010
3011 2019-03-12  Jer Noble  <jer.noble@apple.com>
3012
3013         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3014         https://bugs.webkit.org/show_bug.cgi?id=195137
3015         <rdar://problem/48810307>
3016
3017         Reviewed by Eric Carlson.
3018
3019         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3020         (TestWebKitAPI::TEST):
3021
3022 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3023
3024         [ews-build] Change urls from uat to production
3025         https://bugs.webkit.org/show_bug.cgi?id=195566
3026
3027         Reviewed by Lucas Forschler.
3028
3029         * BuildSlaveSupport/ews-app/ews/config.py:
3030         * BuildSlaveSupport/ews-build/events.py:
3031         * BuildSlaveSupport/ews-build/steps.py:
3032
3033 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3034
3035         [ews-build] change max_builds for local-worker to 1
3036         https://bugs.webkit.org/show_bug.cgi?id=195568
3037
3038         Reviewed by Lucas Forschler.
3039
3040         * BuildSlaveSupport/ews-build/loadConfig.py:
3041
3042 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3043
3044         Fix the build
3045
3046         * TestRunnerShared/spi/PencilKitTestSPI.h:
3047         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3048
3049 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3050
3051         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3052         https://bugs.webkit.org/show_bug.cgi?id=194131
3053
3054         Reviewed by Michael Catanzaro.
3055
3056         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3057         (uriChanged):
3058         (testUnfinishedSubresourceLoad):
3059         (serverCallback):
3060         (beforeAll):
3061
3062 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3063
3064         WTF::Expected should use std::addressof instead of operator&
3065         https://bugs.webkit.org/show_bug.cgi?id=195604
3066
3067         Reviewed by Myles Maxfield.
3068
3069         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3070         (TestWebKitAPI::Unique::Unique):
3071         (TestWebKitAPI::Unique::operator&):
3072         (TestWebKitAPI::TEST):
3073
3074 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3075
3076         Add Optional to Forward.h.
3077         https://bugs.webkit.org/show_bug.cgi?id=195586
3078
3079         Reviewed by Darin Adler.
3080
3081         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3082         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3083         Remove unnecessary includes from headers.
3084
3085 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3086
3087         Add testing API to hit-test and scroll overflow scrollers
3088         https://bugs.webkit.org/show_bug.cgi?id=195278
3089
3090         Reviewed by Antti Koivisto.
3091         
3092         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3093         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3094         
3095         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3096
3097         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3098         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3099         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3100         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3101         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3103         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3104         (WTR::enclosingScrollViewIncludingSelf):
3105         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3106
3107 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3108
3109         API test WebKit.RequestTextInputContext fails on iOS
3110         https://bugs.webkit.org/show_bug.cgi?id=195585
3111
3112         Reviewed by Wenson Hsieh and Simon Fraser.
3113
3114         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3115         (applyStyle):
3116         (TEST):
3117         Add a viewport, so that the coordinates match up on iOS.
3118         Scroll by moving the UIScrollView's contentOffset.
3119
3120 2019-03-11  Chris Dumez  <cdumez@apple.com>
3121
3122         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3123         https://bugs.webkit.org/show_bug.cgi?id=195506
3124         <rdar://problem/48733477>
3125
3126         Reviewed by Alex Christensen.
3127
3128         Add API test coverage.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3131
3132 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3133
3134         Adding myself to contributors.json
3135
3136         Unreviewed, addming myself to contributors.json .
3137
3138         * Scripts/webkitpy/common/config/contributors.json:
3139
3140 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3141
3142         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3143         https://bugs.webkit.org/show_bug.cgi?id=195511
3144         <rdar://problem/44873269>
3145
3146         Reviewed by Darin Adler.
3147
3148         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3149         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3150         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3151         (TEST_F):
3152
3153 2019-03-11  Chris Dumez  <cdumez@apple.com>
3154
3155         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3156         https://bugs.webkit.org/show_bug.cgi?id=195561
3157
3158         Reviewed by Youenn Fablet.
3159
3160         Make sure the JS in the test requests for permission to receive device orientation events.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3163
3164 2019-03-11  Youenn Fablet  <youenn@apple.com>
3165
3166         Allow storage quota increase by default in WTR
3167         https://bugs.webkit.org/show_bug.cgi?id=195541
3168
3169         Reviewed by Geoffrey Garen.
3170
3171         Allow storage quota increase by default in WTR.
3172         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3173         Use this for tests that explicitly need cache increase.
3174
3175         Instead of increasing quota by 2, make sure the next request is
3176         granted by adding all given parameters.
3177
3178         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3180         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3181         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3183         * WebKitTestRunner/TestController.cpp:
3184         (WTR::TestController::setAllowStorageQuotaIncrease):
3185         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3186         * WebKitTestRunner/TestController.h:
3187         * WebKitTestRunner/TestInvocation.cpp:
3188         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3189         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3190         (WTR::TestController::cocoaResetStateToConsistentValues):
3191         (WTR::TestController::setAllowStorageQuotaIncrease):
3192         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3193         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3194         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3195
3196 2019-03-11  Xan Lopez  <xan@igalia.com>
3197
3198         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3199         https://bugs.webkit.org/show_bug.cgi?id=194147
3200
3201         Reviewed by Michael Saboff.
3202
3203         To make --32-bit work correctly on Linux/64bit we need to:
3204
3205         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3206         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3207         unfortunately CMake only allows us to do this during
3208         crosscompilation, which is overkill here.
3209         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3210         pkg-config detection module uses the x86 .pc files instead of the
3211         x86_64 ones.
3212         - Set the -m32 flags for the compiler.
3213
3214         * Scripts/webkitdirs.pm:
3215         (generateBuildSystemFromCMakeProject):
3216
3217 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3218
3219         Add MotionMark-1.1 plan file for run-benchmark script.
3220         https://bugs.webkit.org/show_bug.cgi?id=195481
3221
3222         Rubber-stamped by Darin Adler.
3223
3224         Run-benchmark script should support MontionMark-1.1.
3225
3226         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3227
3228 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3229
3230         [ews-app] Add support for submit-to-ews url
3231         https://bugs.webkit.org/show_bug.cgi?id=195477
3232
3233         Reviewed by Lucas Forschler.
3234
3235         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3236         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3237         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3238         * BuildSlaveSupport/ews-app/ews/urls.py:
3239         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3240
3241 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3242
3243         Unreviewed, rolling out r242688, r242643, r242624.
3244
3245         Caused multiple layout test failures and crashes on iOS and macOS.
3246
3247         Reverted changeset:
3248
3249         "requestAnimationFrame should execute before the next frame"
3250         https://bugs.webkit.org/show_bug.cgi?id=177484
3251         https://trac.webkit.org/changeset/242624/webkit
3252
3253         * Tracing/SystemTracePoints.plist:
3254
3255 2019-03-11  John Wilander  <wilander@apple.com>
3256
3257         Resource Load Statistics: Make it possible exclude localhost from classification
3258         https://bugs.webkit.org/show_bug.cgi?id=195474
3259         <rdar://problem/47520577>
3260
3261         Reviewed by Brent Fulgham.
3262
3263         This patch allows for localhost to be excluded from classification and
3264         treatment as a prevalent resource.
3265
3266         The WebKit Tools change adds a new function called
3267         testRunner.setStatisticsIsRunningTest() which can be used to control this
3268         behavior.
3269
3270         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3271         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3272         (WTR::TestRunner::setStatisticsIsRunningTest):
3273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3274         * WebKitTestRunner/TestController.cpp:
3275         (WTR::TestController::setStatisticsIsRunningTest):
3276         * WebKitTestRunner/TestController.h:
3277         * WebKitTestRunner/TestInvocation.cpp:
3278         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3279
3280 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3281
3282         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3283         https://bugs.webkit.org/show_bug.cgi?id=195560
3284
3285         Reviewed by Lucas Forschler.
3286
3287         * BuildSlaveSupport/ews-build/master.cfg:
3288
3289 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3290
3291         Unreviewed, rolling out r242698.
3292
3293         API test crashes on bots.
3294
3295         Reverted changeset:
3296
3297         "Add a WKContentRuleList variant that uses copied memory
3298         instead of mmap'd shared memory for class A containerized
3299         apps"
3300         https://bugs.webkit.org/show_bug.cgi?id=195511
3301         https://trac.webkit.org/changeset/242698
3302
3303 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3304
3305         [WPE] Enable web process sandbox
3306         https://bugs.webkit.org/show_bug.cgi?id=195169
3307
3308         Reviewed by Daniel Bates.
3309
3310         * wpe/install-dependencies:
3311         * wpe/jhbuild.modules:
3312
3313 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3314
3315         [ews-app] Use port 17000 for worker communication
3316         https://bugs.webkit.org/show_bug.cgi?id=195558
3317
3318         Reviewed by Lucas Forschler.
3319
3320         * BuildSlaveSupport/ews-build/master.cfg:
3321
3322 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3323
3324         [ews-build] unit-tests fail when passwords.json is missing
3325         https://bugs.webkit.org/show_bug.cgi?id=195557
3326
3327         Reviewed by Lucas Forschler.
3328
3329         * BuildSlaveSupport/ews-build/loadConfig.py:
3330         (loadBuilderConfig):
3331         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3332         (ConfigDotJSONTest.test_configuration):
3333         * BuildSlaveSupport/ews-build/master.cfg:
3334
3335 2019-03-11  Truitt Savell  <tsavell@apple.com>
3336
3337         Unreviewed, rolling out r242702.
3338
3339         Broke High Sierra builders.
3340
3341         Reverted changeset:
3342
3343         "Add utility function to allow easy reverse range-based
3344         iteration of a container"
3345         https://bugs.webkit.org/show_bug.cgi?id=195542
3346         https://trac.webkit.org/changeset/242702
3347
3348 2019-03-11  Sam Weinig  <sam@webkit.org>
3349
3350         Add utility function to allow easy reverse range-based iteration of a container
3351         https://bugs.webkit.org/show_bug.cgi?id=195542
3352
3353         Reviewed by Antti Koivisto.
3354
3355         * TestWebKitAPI/CMakeLists.txt:
3356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3357         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3358         (TestWebKitAPI::TEST):
3359         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3360
3361 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3362
3363         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3364         https://bugs.webkit.org/show_bug.cgi?id=195511
3365         <rdar://problem/44873269>
3366
3367         Reviewed by Darin Adler.
3368
3369         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3370         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3371         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3372         (TEST_F):
3373
3374 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3375
3376         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3377         https://bugs.webkit.org/show_bug.cgi?id=195499
3378
3379         Reviewed by Darin Adler.
3380
3381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3382         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3383         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3384         (-[WKWebView synchronouslyFocusTextInputContext:]):
3385         (applyStyle):
3386         (applyIframe):
3387         (TEST):
3388         Add some tests for this SPI.
3389
3390 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3391
3392         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3393         https://bugs.webkit.org/show_bug.cgi?id=181151
3394
3395         Reviewed by Don Olmstead.
3396
3397         * TestWebKitAPI/CMakeLists.txt:
3398         * TestWebKitAPI/PlatformWin.cmake:
3399         Enable TestWTF RunLoop tests in all platforms.
3400
3401         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3402         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3403         (TestWebKitAPI::DerivedOneShotTimer::fired):
3404         (TestWebKitAPI::TEST):
3405         Only a few platforms support nested RunLoop.
3406
3407         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3408         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3409
3410 2019-03-10  David Quesada  <david_quesada@apple.com>
3411
3412         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3413         https://bugs.webkit.org/show_bug.cgi?id=152480
3414
3415         Reviewed by Chris Dumez.
3416
3417         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3418         there are no additional references to the process pool besides the one held by
3419         the download, waits for the download to finish (in the sense that the
3420         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3421         measure, also check that the process pool has been deallocated at the end of the
3422         test. The test wouldn't be meaningful if the process pool were still alive.
3423
3424         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3425         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3426         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3427             The download will be canceled because the delegate does not implement the
3428             method to decide the download's destination, so this is where we know the
3429             DownloadProxyMap is done with the DownloadProxy.
3430         (TEST):
3431
3432 2019-03-08  Chris Dumez  <cdumez@apple.com>
3433
3434         Add support for Device Orientation / Motion permission API
3435         https://bugs.webkit.org/show_bug.cgi?id=195329
3436         <rdar://problem/47645367>
3437
3438         Reviewed by Geoffrey Garen.
3439
3440         Add test infrastructure to help test the Device Orientation / Motion permission API.
3441
3442         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3444         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3446         * WebKitTestRunner/TestController.cpp:
3447         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3448         (WTR::TestController::createWebViewWithOptions):
3449         (WTR::TestController::resetStateToConsistentValues):
3450         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3451         * WebKitTestRunner/TestController.h:
3452         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3453         * WebKitTestRunner/TestInvocation.cpp:
3454         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3455
3456 2019-03-08  Saam barati  <sbarati@apple.com>
3457
3458         Add a compare-results script to compare benchmark results
3459         https://bugs.webkit.org/show_bug.cgi?id=195486
3460         <rdar://problem/48723397>
3461
3462         Reviewed by Geoffrey Garen.
3463
3464         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3465         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3466         to extend it to learn about our other benchmarks.
3467
3468         * Scripts/compare-results: Added.
3469         (readJSONFile):
3470         (detectJetStream2):
3471         (JetStream2Results):
3472         (detectSpeedometer2):
3473         (Speedometer2Results):
3474         (detectPLT5):
3475         (PLT5Results):
3476         (detectBenchmark):
3477         (biggerIsBetter):
3478         (ttest):
3479         (getOptions):
3480         (main):
3481
3482 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3483
3484         Ensure old tab state is cleared between iterations of run-benchmark
3485         https://bugs.webkit.org/show_bug.cgi?id=195393
3486         <rdar://problem/46885583>
3487
3488         Reviewed by Dewei Zhu.
3489
3490         a) ensure the default to restore state is not set
3491         b) terminate Safari correctly
3492         c) Set the system default to ignore Persistent State in Safari
3493
3494         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3495         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3496         (OSXBrowserDriver.prepare_env): 
3497         (OSXBrowserDriver.restore_env):
3498         (OSXBrowserDriver.close_browsers):
3499         (OSXBrowserDriver._terminate_processes):
3500         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3501         (OSXChromeDriver):
3502         (OSXChromeCanaryDriver):
3503         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3504         (OSXFirefoxDriver):
3505         (OSXFirefoxNightlyDriver):
3506         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3507         (OSXSafariDriver):
3508         (OSXSafariDriver.prepare_env):
3509
3510 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3511
3512         [GTK] Several InputMethodFilter tests are failing
3513         https://bugs.webkit.org/show_bug.cgi?id=195408
3514
3515         Reviewed by Carlos Garcia Campos.
3516
3517         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3518         Regressed in r241751.
3519         Hexadecimal values of keycodes are expressed now in upper letters.
3520         Composited characters should be cast to UTF8 strings.
3521
3522         (TestWebKitAPI::TEST):
3523
3524 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3525
3526         [GTK] Make Tools/gtkdoc python3 compatible
3527         https://bugs.webkit.org/show_bug.cgi?id=195359
3528
3529         Reviewed by Carlos Garcia Campos.
3530
3531         * gtkdoc/generate-gtkdoc:
3532         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3533         work with Python 2 and 3.
3534         (get_gtkdoc_module_paths):
3535         The iteritems() was removed in Python 3, so let's use items() that's
3536         available in Python 2 and 3.
3537         (get_generator_for_config):
3538         * gtkdoc/gtkdoc.py:
3539         (GTKDoc._run_command):
3540         The sys.stdout.write() is expecting str in Python 3 and not bytes
3541         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3542         for passing the bytes there.
3543
3544 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3545
3546         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3547         https://bugs.webkit.org/show_bug.cgi?id=195346
3548         <rdar://problem/48667048>
3549
3550         Unreviewed build fix for clang-cl.
3551
3552         * DumpRenderTree/win/DumpRenderTree.cpp:
3553         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3554
3555 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3556
3557         requestAnimationFrame should execute before the next frame
3558         https://bugs.webkit.org/show_bug.cgi?id=177484
3559
3560         Reviewed by Simon Fraser.
3561
3562         Add trace points for the page RenderingUpdate.
3563
3564         * Tracing/SystemTracePoints.plist:
3565
3566 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3567
3568         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3569         https://bugs.webkit.org/show_bug.cgi?id=195353
3570         <rdar://problem/48626394>
3571
3572         Reviewed by Simon Fraser.
3573
3574         * WebKitTestRunner/ios/TestControllerIOS.mm:
3575         (WTR::TestController::platformResetPreferencesToConsistentValues):
3576
3577 2019-03-07  John Wilander  <wilander@apple.com>
3578
3579         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3580         https://bugs.webkit.org/show_bug.cgi?id=195383
3581         <rdar://problem/48570136>
3582
3583         Reviewed by Brent Fulgham.
3584
3585         This patch adds test infrastructure to purge only script-accessible cookies,
3586         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3587
3588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3590         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3591         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3592         * WebKitTestRunner/TestController.cpp:
3593         (WTR::TestController::statisticsDeleteCookiesForHost):
3594         * WebKitTestRunner/TestController.h:
3595         * WebKitTestRunner/TestInvocation.cpp:
3596         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3597
3598 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3599
3600         Unreviewed, rolling out r242354.
3601         https://bugs.webkit.org/show_bug.cgi?id=195402
3602
3603         breaks layout tests in all configurations (Requested by
3604         zdobersek on #webkit).
3605
3606         Reverted changeset:
3607
3608         "[WPE] Enable web process sandbox"
3609         https://bugs.webkit.org/show_bug.cgi?id=195169
3610         https://trac.webkit.org/changeset/242354
3611
3612 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3613
3614         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3615         https://bugs.webkit.org/show_bug.cgi?id=195346
3616
3617         Reviewed by Fujii Hironori.
3618
3619         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3620         (TestWebKitAPI::TEST):
3621         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3622
3623         * DumpRenderTree/win/DumpRenderTree.cpp:
3624         (findFontFallback):
3625         (addFontFallbackIfPresent):
3626         (removeFontFallbackIfPresent):
3627         (main):
3628         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3629         (TestWebKitAPI::Util::moduleDirectory):
3630         (TestWebKitAPI::Util::createInjectedBundlePath):
3631         Use wchar helpers as needed.
3632
3633 2019-03-06  Rob Buis  <rbuis@igalia.com>
3634
3635         Consider supporting the `referrerpolicy` attribute.
3636         https://bugs.webkit.org/show_bug.cgi?id=179053
3637
3638         Reviewed by Darin Adler.
3639
3640         Add a runtime flag for referrerpolicy attribute.
3641
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (enableExperimentalFeatures):
3644
3645 2019-03-05  Daniel Bates  <dabates@apple.com>
3646
3647         Update expected API test result following r242379
3648         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3649
3650         Update expected x-coordinate of selection rect now that the left padding of
3651         a textarea is sized in ems (so dependent on the font size) just like the left
3652         padding of a text field.
3653
3654         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3655         (TestWebKitAPI::TEST):
3656
3657 2019-03-05  David Quesada  <david_quesada@apple.com>
3658
3659         [WK2] It should be possible to follow links with 'download' attributes
3660         https://bugs.webkit.org/show_bug.cgi?id=195145
3661         rdar://problem/48462642
3662
3663         Reviewed by Alex Christensen.
3664
3665         Add a unit test to verify that activating links with 'download' attributes now
3666         navigates to the linked resource, rather than starts downloading it. Add another
3667         to verify that it is still possible to explicitly download the link via the
3668         'Download' navigation action policy.
3669
3670         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3671         (-[DownloadAttributeTestDelegate init]):
3672         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3673         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3674         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3675         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3676         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3677         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3678         (TEST):
3679         * WebKitTestRunner/TestController.cpp:
3680         (WTR::TestController::decidePolicyForNavigationAction):
3681         * WebKitTestRunner/TestController.h:
3682
3683 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3684
3685         [Curl] Implement Cookie Accept Policy.
3686         https://bugs.webkit.org/show_bug.cgi?id=191645
3687
3688         Reviewed by Fujii Hironori.
3689
3690         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3691         (TestWebKitAPI::Curl::TEST_F):
3692
3693 2019-03-05  Youenn Fablet  <youenn@apple.com>
3694
3695         Rename requestCacheStorageSpace to requestStorageSpace
3696         https://bugs.webkit.org/show_bug.cgi?id=195282
3697
3698         Reviewed by Chris Dumez.
3699
3700         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3701         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3702         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3703
3704 2019-03-05  Brady Eidson  <beidson@apple.com>
3705
3706         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3707         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3708
3709         Reviewed by Tim Horton.
3710
3711         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3712         different directory into that same WKWebView should work.
3713
3714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3715         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3716
3717 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3718
3719         Add WeakHashSet
3720         https://bugs.webkit.org/show_bug.cgi?id=195152
3721
3722         Reviewed by Antti Koivisto.
3723
3724         Added tests for WeakHashSet.
3725
3726         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3727         (TestWebKitAPI::Base::Base): Moved.
3728         (TestWebKitAPI::Derived::foo): Moved.
3729         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3730         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3731         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3732         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3733
3734 2019-03-04  Chris Dumez  <cdumez@apple.com>
3735
3736         Do not share WebProcesses between private and regular sessions
3737         https://bugs.webkit.org/show_bug.cgi?id=195189
3738         <rdar://problem/48421064>
3739
3740         Reviewed by Alex Christensen.
3741
3742         Add API test coverage.
3743
3744         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3745         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3746
3747 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3748
3749         [WPE] Enable web process sandbox
3750         https://bugs.webkit.org/show_bug.cgi?id=195169
3751
3752         Reviewed by Daniel Bates.
3753
3754         * wpe/install-dependencies:
3755         * wpe/jhbuild.modules:
3756
3757 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3758
3759         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3760         https://bugs.webkit.org/show_bug.cgi?id=195206
3761
3762         Reviewed by Žan Doberšek.
3763
3764         Add a new test case.
3765
3766         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3767         (testJSCClass):
3768
3769 2019-03-04  Charlie Turner  <cturner@igalia.com>
3770
3771         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3772         https://bugs.webkit.org/show_bug.cgi?id=194898
3773
3774         Reviewed by Žan Doberšek.
3775
3776         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3777         a GCC extension that permits arithmetic on void* pointer. Inline
3778         the macro until this issue is fixed upstream.
3779
3780 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3781
3782         Rid the world of WK_API_ENABLED
3783         https://bugs.webkit.org/show_bug.cgi?id=195263
3784
3785         Reviewed by Dan Bernstein.
3786
3787         List of changed files elided because it's useless.
3788
3789 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3790
3791         Unreviewed follow-up to r242292.
3792
3793         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3794
3795         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3796         (TestWebKitAPI::testStrip): Renamed from strip.
3797         (TestWebKitAPI::TEST):
3798
3799 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3800
3801         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3802
3803         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3804         and bug #194272 for details.
3805
3806         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3807
3808 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3809
3810         Remove some more unused 32-bit code
3811         https://bugs.webkit.org/show_bug.cgi?id=195255
3812
3813         Reviewed by Darin Adler.
3814
3815         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3816         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3817         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3818         (NPP_New):
3819         (NPP_HandleEvent):
3820         (handleEventCarbon): Deleted.
3821
3822 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3823
3824         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3825
3826         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3827         (TestWebKitAPI::TEST):
3828
3829 2019-03-01  Darin Adler  <darin@apple.com>
3830
3831         Finish removing String::format
3832         https://bugs.webkit.org/show_bug.cgi?id=194893
3833
3834         Reviewed by Daniel Bates.
3835 '
3836         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3837
3838 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3839
3840         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3841         https://bugs.webkit.org/show_bug.cgi?id=195229
3842         <rdar://problem/48520362>
3843
3844         Reviewed by Chris Dumez.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3847         (TEST):
3848
3849 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3850
3851         Add a system trace scope for event region building
3852         https://bugs.webkit.org/show_bug.cgi?id=195226
3853
3854         Reviewed by Jon Lee.
3855
3856         This trace scope measures the time spend converting element rects into Region objects,
3857         which can be large on some pages.
3858
3859         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3860
3861         * Tracing/SystemTracePoints.plist:
3862
3863 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3864
3865         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3866         https://bugs.webkit.org/show_bug.cgi?id=194612
3867
3868         Reviewed by Alex Christensen.
3869
3870         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3871         Just test the new string-processing function and don't touch the actual environment.
3872         (Test cases are all as before, but based on operator== instead of strcmp.)
3873
3874 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3875
3876         [ews-app] Update primary keys for handling multiple Buildbot instances
3877         https://bugs.webkit.org/show_bug.cgi?id=195120
3878
3879         Reviewed by Stephanie Lewis.
3880
3881         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3882         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3883         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3884
3885         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3886         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3887         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3888         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3889         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3890         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3891
3892 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3893
3894         [WinCairo] Enable service worker
3895         https://bugs.webkit.org/show_bug.cgi?id=188318
3896
3897         Reviewed by Youenn Fablet.
3898
3899         * DumpRenderTree/DumpRenderTreePrefix.h:
3900         * TestWebKitAPI/PlatformWin.cmake:
3901         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3902         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3903         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3904
3905 2019-03-01  Justin Fan  <justin_fan@apple.com>
3906
3907         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3908         https://bugs.webkit.org/show_bug.cgi?id=195191
3909
3910         Rubber-stamped by Dean Jackson.
3911
3912         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3913
3914         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3915
3916 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3917
3918         Unreviewed, fix lldb webkitpy tests
3919         https://bugs.webkit.org/show_bug.cgi?id=194375
3920
3921         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3922
3923         * lldb/lldb_webkit.py:
3924         (WTFStringImplProvider.is_8bit):
3925
3926 2019-02-28  David Quesada  <david_quesada@apple.com>
3927
3928         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3929         https://bugs.webkit.org/show_bug.cgi?id=195121
3930         rdar://problem/48450302
3931
3932         Reviewed by Alex Christensen.
3933
3934         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3935         configurations where the 'download' attribute is absent, blank, or populated
3936         with a filename, and where the anchor element is same-origin or cross-origin
3937         (meaning the 'download' attribute shouldn't be honored).
3938
3939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3940         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3941         (-[NavigationActionTestDelegate init]):
3942         (-[NavigationActionTestDelegate navigationAction]):
3943         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3944         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3945         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3946         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3947         (TEST):
3948
3949 2019-02-28  Antoine Quint  <graouts@apple.com>
3950
3951         Enable the Pointer Events runtime flag by default
3952         https://bugs.webkit.org/show_bug.cgi?id=195156
3953
3954         Reviewed by Dean Jackson.
3955
3956         * DumpRenderTree/mac/DumpRenderTree.mm:
3957         (enableExperimentalFeatures):
3958
3959 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3960
3961         Several PasteImage API tests are flaky
3962         https://bugs.webkit.org/show_bug.cgi?id=195160
3963
3964         Reviewed by Tim Horton.
3965
3966         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3967         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3968         listening for a "load" event after image load is already complete.
3969
3970         To address this, make these tests first register a "load" event handler, then run script to insert an image
3971         element into the document, and finally wait until the load event is observed before checking image size.
3972
3973         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3974
3975 2019-02-28  Chris Dumez  <cdumez@apple.com>
3976
3977         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3978         https://bugs.webkit.org/show_bug.cgi?id=195107
3979
3980         Reviewed by Alex Christensen.
3981
3982         Give some time for the zoom level to get restored.
3983
3984         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3985
3986 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3987
3988         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3989         https://bugs.webkit.org/show_bug.cgi?id=194958
3990
3991         Reviewed by Geoffrey Garen.
3992
3993         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3994         (TEST):
3995
3996 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3997
3998         [ews-app] Update method to save build to handle builder_display_name
3999         https://bugs.webkit.org/show_bug.cgi?id=195047
4000
4001         Reviewed by Dewei Zhu.
4002
4003         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4004         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4005
4006 2019-02-28  Justin Fan  <justin_fan@apple.com>
4007
4008         [Web GPU] Enable Web GPU only on 64-bit
4009         https://bugs.webkit.org/show_bug.cgi?id=195139
4010
4011         Because Metal is only supported on 64 bit apps.
4012
4013         Unreviewed build fix.
4014
4015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4016
4017 2019-02-27  Youenn Fablet  <youenn@apple.com>
4018
4019         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4020         https://bugs.webkit.org/show_bug.cgi?id=194959
4021
4022         Reviewed by Chris Dumez.
4023
4024         Spin loop until getting the condition to remove flakiness.
4025
4026         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4027
4028 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4029
4030         [ews-build] Buildbot should include builder_display_name in the build events
4031         https://bugs.webkit.org/show_bug.cgi?id=195045
4032
4033         Reviewed by Dewei Zhu.
4034
4035         * BuildSlaveSupport/ews-build/events.py:
4036         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4037         buildername to builder_name to be consistent in naming style.
4038         (Events.buildFinished): Ditto.
4039
4040 2019-02-27  Chris Dumez  <cdumez@apple.com>
4041
4042         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4043         https://bugs.webkit.org/show_bug.cgi?id=194480
4044
4045         Reviewed by Brady Eidson.
4046
4047         Update existing API test to make it more likely to reproduce the issue.
4048
4049         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4050
4051 2019-02-27  Brady Eidson  <beidson@apple.com>
4052
4053         Universal links from Google search results pages don't open the app.
4054         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4055
4056         Reviewed by Geoffrey Garen.
4057
4058         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4059         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4060         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4061         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4062
4063 2019-02-27  Chris Dumez  <cdumez@apple.com>
4064
4065         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4066         https://bugs.webkit.org/show_bug.cgi?id=195102
4067
4068         Reviewed by Geoffrey Garen.
4069
4070         If the number of processes is not yet what we expect, wait a bit and check again to give
4071         processes some time to exit.
4072
4073         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4074
4075 2019-02-27  Chris Dumez  <cdumez@apple.com>
4076
4077         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4078         https://bugs.webkit.org/show_bug.cgi?id=194545
4079
4080         Reviewed by Brady Eidson.
4081
4082         Make sure the test navigates forward and then back only once. Previously, navigating
4083         back would trigger a navigation again in a timer.
4084
4085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4086
4087 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4088
4089         High Sierra Debug JSC test queue should use faster hardware
4090         https://bugs.webkit.org/show_bug.cgi?id=194603
4091
4092         Rubber-stamped by Alexey Proskuryakov.
4093
4094         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4095
4096         * BuildSlaveSupport/build.webkit.org-config/config.json:
4097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4098         (BubbleQueueServer):
4099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4100         (WebKitBuildbot):
4101         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4102         * QueueStatusServer/config/queues.py:
4103         * Scripts/webkitpy/common/config/ews.json:
4104         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4105         (test_ews_name):
4106
4107 2019-02-27  John Wilander  <wilander@apple.com>
4108
4109         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4110         https://bugs.webkit.org/show_bug.cgi?id=195071
4111         <rdar://problem/48417690>
4112
4113         Reviewed by Alex Christensen and Brent Fulgham.
4114
4115         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4116         (TestWebKitAPI::createURL):
4117             Convenience function.
4118         (TestWebKitAPI::TEST):
4119             WebCore::AdClickAttribution now takes a URL when creating Source and
4120             Destination.
4121         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4122         (TestWebKitAPI::TEST):
4123             WebCore::AdClickAttribution now takes a URL when creating Source and
4124             Destination.
4125
4126 2019-02-27  Antoine Quint  <graouts@apple.com>
4127
4128         Support Pointer Events on macOS
4129         https://bugs.webkit.org/show_bug.cgi?id=195008
4130         <rdar://problem/47454419>
4131
4132         Reviewed by Dean Jackson.
4133
4134         * DumpRenderTree/mac/DumpRenderTree.mm:
4135         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4137
4138 2019-02-26  Mark Lam  <mark.lam@apple.com>
4139
4140         Remove remaining poisoning code.
4141         https://bugs.webkit.org/show_bug.cgi?id=194138
4142
4143         Reviewed by Saam Barati.
4144
4145         * TestWebKitAPI/CMakeLists.txt:
4146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4147         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4148         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4149         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4150         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4151         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4152         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4153
4154 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4155
4156         Move ephemeral local storage from WebProcess to UIProcess
4157         https://bugs.webkit.org/show_bug.cgi?id=195074
4158         <rdar://problem/47937975>
4159
4160         Reviewed by Geoff Garen.
4161
4162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4163
4164 2019-02-20  Jer Noble  <jer.noble@apple.com>
4165
4166         [Cocoa] Media elements will restart network buffering just before suspending
4167         https://bugs.webkit.org/show_bug.cgi?id=193691
4168
4169         Reviewed by Eric Carlson.
4170
4171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4173         (TEST):
4174
4175 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4176
4177         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4178         https://bugs.webkit.org/show_bug.cgi?id=191652
4179
4180         Reviewed by Alex Christensen.
4181
4182         Fix WinCairo MiniBrowser behavior of authentication dialog.
4183
4184         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4185         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4186
4187 2019-02-26  Youenn Fablet  <youenn@apple.com>
4188
4189         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4190         https://bugs.webkit.org/show_bug.cgi?id=195028
4191         <rdar://problem/48243733>
4192
4193         Reviewed by Eric Carlson.
4194
4195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4196
4197 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4198
4199         [WPE] Add API for webview background color configuration
4200         https://bugs.webkit.org/show_bug.cgi?id=192305
4201
4202         Reviewed by Michael Catanzaro.
4203
4204         * MiniBrowser/wpe/main.cpp:
4205         (main): Add a new option to configure the webview background
4206         color. Example: --bg-color=transparent.
4207         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4208         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4209         (beforeAll): Ditto.
4210
4211 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4212
4213         scalableNativeWebpageParameters() is not preserved on new page navigation.
4214         https://bugs.webkit.org/show_bug.cgi?id=194892
4215         <rdar://problem/47538280>
4216
4217         Reviewed by Wenson Hsieh.
4218         
4219         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4220
4221         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4222         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4223         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4224         (WTR::UIScriptController::allowsViewportShrinkToFit):
4225         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4226         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4227         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4228         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4229         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4230         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4231
4232 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4233
4234         [ews-app] Add model for handling multiple Buildbot instances
4235         https://bugs.webkit.org/show_bug.cgi?id=194863
4236
4237         Reviewed by Stephanie Lewis.
4238
4239         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4240
4241 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4242
4243         [ews-app] Remove BuilderMapping table
4244         https://bugs.webkit.org/show_bug.cgi?id=194961
4245
4246         Reviewed by Stephanie Lewis.
4247
4248         Store builder name directly in build table, instead of having a separate
4249         table for it.
4250
4251         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4252         * BuildSlaveSupport/ews-app/ews/models/build.py:
4253         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4254         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4255
4256 2019-02-25  John Wilander  <wilander@apple.com>
4257
4258         Introduce and adopt new class RegistrableDomain for eTLD+1
4259         https://bugs.webkit.org/show_bug.cgi?id=194791
4260         <rdar://problem/48179240>
4261
4262         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4263
4264         This patch adds an API test and replaces two instances of
4265         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4266
4267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4268         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4269         (TestWebKitAPI::TEST):
4270             Changed two strings to make sure the registrable domains are still considered
4271             invalid and pass the test.
4272         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4273         (TestWebKitAPI::TEST):
4274         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4275         (WTR::InjectedBundle::didReceiveMessageToPage):
4276
4277 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4278
4279         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4280         https://bugs.webkit.org/show_bug.cgi?id=195001
4281
4282         Reviewed by Carlos Garcia Campos.
4283
4284         API version 1.0 always includes the functionality previously guarded with
4285         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4286         unconditionally.
4287
4288         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4289         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4290         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4291         (WebViewTest::showInWindow): Ditto.
4292         (WebViewTest::hideView): Ditto.
4293         * wpe/backends/HeadlessViewBackend.cpp:
4294         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4295         * wpe/backends/ViewBackend.cpp:
4296         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4297         * wpe/backends/WindowViewBackend.cpp:
4298         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4299         WPE_BACKEND_CHECK_VERSION().
4300         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4301
4302 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4303
4304         [Flatpak] Add support for flatpak > 1.1.2
4305         https://bugs.webkit.org/show_bug.cgi?id=194088
4306
4307         Flatpak 1.2 is now out so we need to support that
4308         version now.
4309
4310         Reviewed by Michael Catanzaro.
4311
4312         * flatpak/flatpakutils.py:
4313         (check_flatpak):
4314         (FlatpakPackages.__init__):
4315         (FlatpakPackages.__detect_packages):
4316         (FlatpakPackages.__detect_packages.in):
4317         (FlatpakRepos.update):
4318
4319 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4320
4321         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4322         https://bugs.webkit.org/show_bug.cgi?id=194998
4323
4324         Reviewed by Carlos Garcia Campos.
4325
4326         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4327         to a Git checkout and using the latest commit containing various fixes
4328         and improvements.
4329
4330 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4331
4332         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4333         https://bugs.webkit.org/show_bug.cgi?id=194981
4334
4335         Reviewed by Žan Doberšek.
4336
4337         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4338         (TestWebKitAPI::TEST):
4339
4340 2019-02-23  Keith Miller  <keith_miller@apple.com>
4341
4342         Add new mac target numbers
4343         https://bugs.webkit.org/show_bug.cgi?id=194955
4344
4345         Reviewed by Tim Horton.
4346
4347         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4348         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4349         * MiniBrowser/Configurations/Base.xcconfig:
4350         * TestWebKitAPI/Configurations/Base.xcconfig:
4351         * WebKitTestRunner/Configurations/Base.xcconfig:
4352
4353 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4354
4355         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4356         https://bugs.webkit.org/show_bug.cgi?id=194846
4357
4358         Reviewed by Don Olmstead.
4359
4360         Added _search_paths() and _port_specific_expectations_files() for
4361         WinCairoPort.
4362
4363         * Scripts/webkitpy/port/win.py:
4364         (WinCairoPort.default_baseline_search_path):
4365         (WinCairoPort):
4366         (WinCairoPort._port_specific_expectations_files):
4367         (WinCairoPort._search_paths):
4368
4369 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4370
4371         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug&n