Bytecode cache should a have a boot-specific validation
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
2
3         Bytecode cache should a have a boot-specific validation
4         https://bugs.webkit.org/show_bug.cgi?id=194769
5         <rdar://problem/48149509>
6
7         Reviewed by Keith Miller.
8
9         Add test for WTF::bootSessionUUIDString()
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
13         (TEST):
14
15 2019-02-18  Alex Christensen  <achristensen@webkit.org>
16
17         Disable safe browsing in WKWebView and remove its WKPreferences API
18         https://bugs.webkit.org/show_bug.cgi?id=194723
19         <rdar://problem/48122993>
20
21         Reviewed by Geoffrey Garen.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
25         (TEST):
26         (safeBrowsingView):
27         Make tests use SPI instead of API.
28
29 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
30
31         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
32         https://bugs.webkit.org/show_bug.cgi?id=194586
33
34         Reviewed by Ross Kirsling.
35
36         * DumpRenderTree/win/DumpRenderTree.cpp:
37         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
38         * Scripts/webkitpy/port/driver.py:
39         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
40
41 2019-02-17  David Kilzer  <ddkilzer@apple.com>
42
43         Unreviewed, rolling out r241620.
44
45         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
46         (Requested by ddkilzer on #webkit.)
47
48         Reverted changeset:
49
50         "[WTF] Add environment variable helpers"
51         https://bugs.webkit.org/show_bug.cgi?id=192405
52         https://trac.webkit.org/changeset/241620
53
54 2019-02-16  Zalan Bujtas  <zalan@apple.com>
55
56         [LFC] RenderImage's default intrinsic size is 0.
57         https://bugs.webkit.org/show_bug.cgi?id=194745
58
59         Reviewed by Antti Koivisto.
60
61         * LayoutReloaded/misc/LFC-passing-tests.txt:
62
63 2019-02-16  Zalan Bujtas  <zalan@apple.com>
64
65         [LFC][BFC] Add support for block replaced intrinsic width.
66         https://bugs.webkit.org/show_bug.cgi?id=194705
67
68         Reviewed by Simon Fraser.
69
70         * LayoutReloaded/misc/LFC-passing-tests.txt:
71
72 2019-02-16  Zalan Bujtas  <zalan@apple.com>
73
74         [LFC] Apply min/max width constraints to preferred width computation
75         https://bugs.webkit.org/show_bug.cgi?id=194739
76
77         Reviewed by Simon Fraser.
78
79         * LayoutReloaded/misc/LFC-passing-tests.txt:
80
81 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
82
83         [WTF] Add environment variable helpers
84         https://bugs.webkit.org/show_bug.cgi?id=192405
85
86         Reviewed by Michael Catanzaro.
87
88         * DumpRenderTree/mac/DumpRenderTree.mm:
89         (libraryPathForDumpRenderTree):
90         * DumpRenderTree/win/DumpRenderTree.cpp:
91         (libraryPathForDumpRenderTree):
92         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
93         (setUpIOSLayoutTestCommunication):
94         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
95         (beforeAll):
96         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
97         (main):
98         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
99         (WebKitTestBus::run):
100         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
101         (WTR::getOutputDir):
102         (WTR::initializeFontConfigSetting):
103         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
104         (WTR::InjectedBundle::platformInitialize):
105         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
106         (WTR::topLevelPath):
107         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
108         (WTR::topLevelPath):
109         (WTR::getOutputDir):
110         (WTR::activateFonts):
111         * WebKitTestRunner/TestController.cpp:
112         (WTR::TestController::libraryPathForTesting):
113         (WTR::TestController::generateContextConfiguration const):
114         (WTR::TestController::generatePageConfiguration):
115         (WTR::TestController::decideDestinationWithSuggestedFilename):
116         (WTR::TestController::platformAdjustContext):
117         * WebKitTestRunner/TestController.h:
118         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
119         (WTR::TestController::cocoaPlatformInitialize):
120         (WTR::TestController::platformAdjustContext):
121         * WebKitTestRunner/gtk/main.cpp:
122         (main):
123         * WebKitTestRunner/mac/TestControllerMac.mm:
124         (WTR::TestController::configureContentExtensionForTest):
125         * WebKitTestRunner/wpe/main.cpp:
126         (main):
127         Utilize WTF::Environment where possible.
128
129 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
130
131         [iOS] WKWebView callout bar is missing Change Writing Direction item
132         https://bugs.webkit.org/show_bug.cgi?id=190015
133         <rdar://problem/44810366>
134
135         Reviewed by Tim Horton.
136
137         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
138         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
141         (TestWebKitAPI::TEST):
142
143 2019-02-15  Chris Dumez  <cdumez@apple.com>
144
145         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
146         https://bugs.webkit.org/show_bug.cgi?id=194717
147         <rdar://problem/47884404>
148
149         Reviewed by Brady Eidson.
150
151         Add API test coverage.
152
153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
154
155 2019-02-15  Youenn Fablet  <youenn@apple.com>
156
157         Make navigator.mediaDevices SecureContext
158         https://bugs.webkit.org/show_bug.cgi?id=194666
159
160         Reviewed by Eric Carlson.
161
162         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
163         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
164         (TEST_F):
165
166 2019-02-15  Brian Burg  <bburg@apple.com>
167
168         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
169         https://bugs.webkit.org/show_bug.cgi?id=194411
170         <rdar://problem/47787614>
171
172         Reviewed by Joseph Pecoraro.
173
174         Remove unnecessary soft linking macro usage.
175
176         * DumpRenderTree/mac/TestRunnerMac.mm:
177         (TestRunner::inspectorTestStubURL):
178         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
179         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
180         (WTR::TestRunner::inspectorTestStubURL):
181
182 2019-02-15  Commit Queue  <commit-queue@webkit.org>
183
184         Unreviewed, rolling out r241559 and r241566.
185         https://bugs.webkit.org/show_bug.cgi?id=194710
186
187         Causes layout test crashes under GuardMalloc (Requested by
188         ryanhaddad on #webkit).
189
190         Reverted changesets:
191
192         "[WTF] Add environment variable helpers"
193         https://bugs.webkit.org/show_bug.cgi?id=192405
194         https://trac.webkit.org/changeset/241559
195
196         "Unreviewed build fix for WinCairo Debug after r241559."
197         https://trac.webkit.org/changeset/241566
198
199 2019-02-15  Zalan Bujtas  <zalan@apple.com>
200
201         [LFC] Out-of-flow box is never a float box
202         https://bugs.webkit.org/show_bug.cgi?id=194704
203
204         Reviewed by Antti Koivisto.
205
206         * LayoutReloaded/misc/LFC-passing-tests.txt:
207
208 2019-02-10  Darin Adler  <darin@apple.com>
209
210         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
211         https://bugs.webkit.org/show_bug.cgi?id=194487
212
213         Reviewed by Daniel Bates.
214
215         * DumpRenderTree/win/DumpRenderTree.cpp:
216         (applicationId): Use makeString instead of String::format.
217         (main): Ditto.
218         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
219         (TestWebKitAPI::Util::createURLForResource): Ditto.
220         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
221         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
222
223         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
224         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
225         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
226         (WTR::createStringWithAttributes): Use appendLiteral.
227         (WTR::AccessibilityUIElement::helpText const): Ditto.
228         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
229         directly instead of using String::format.
230         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
231         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
232
233 2019-02-15  Truitt Savell  <tsavell@apple.com>
234
235         Unreviewed, rolling out r241564.
236
237         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
238
239         Reverted changeset:
240
241         "[Mac] WebInspectorUI.framework does not need to be soft-
242         linked anymore"
243         https://bugs.webkit.org/show_bug.cgi?id=194411
244         https://trac.webkit.org/changeset/241564
245
246 2019-02-15  Saam barati  <sbarati@apple.com>
247
248         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
249         https://bugs.webkit.org/show_bug.cgi?id=194036
250
251         Reviewed by Yusuke Suzuki.
252
253         * Scripts/run-jsc-stress-tests:
254
255 2019-02-14  Tim Horton  <timothy_horton@apple.com>
256
257         Fix the build.
258
259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
260         (WTR::UIScriptController::drawSquareInEditableImage):
261         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
262         (TestWebKitAPI::drawSquareInEditableImage):
263
264 2019-02-14  Tim Horton  <timothy_horton@apple.com>
265
266         Fix the build.
267
268         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
269         (WTR::UIScriptController::drawSquareInEditableImage):
270         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
271         (TestWebKitAPI::drawSquareInEditableImage):
272
273 2019-02-14  Brian Burg  <bburg@apple.com>
274
275         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
276         https://bugs.webkit.org/show_bug.cgi?id=194411
277         <rdar://problem/47787614>
278
279         Reviewed by Joseph Pecoraro.
280
281         Remove unnecessary soft linking macro usage.
282
283         * DumpRenderTree/mac/TestRunnerMac.mm:
284         (TestRunner::inspectorTestStubURL):
285         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
286         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
287         (WTR::TestRunner::inspectorTestStubURL):
288
289 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
290
291         [ews-app] status bubble should fetch builder name info from BuilderMapping table
292         https://bugs.webkit.org/show_bug.cgi?id=194599
293
294         Reviewed by Lucas Forschler.
295
296         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
297         (StatusBubble._build_bubble):
298
299 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
300
301         [ews-app] Set Foreign Key in Django build model
302         https://bugs.webkit.org/show_bug.cgi?id=194667
303
304         Reviewed by Lucas Forschler.
305
306         * BuildSlaveSupport/ews-app/ews/models/build.py:
307         (Build):
308
309 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
310
311         [WTF] Add environment variable helpers
312         https://bugs.webkit.org/show_bug.cgi?id=192405
313
314         Reviewed by Michael Catanzaro.
315
316         * DumpRenderTree/mac/DumpRenderTree.mm:
317         (libraryPathForDumpRenderTree):
318         * DumpRenderTree/win/DumpRenderTree.cpp:
319         (libraryPathForDumpRenderTree):
320         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
321         (setUpIOSLayoutTestCommunication):
322         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
323         (TestWebKitAPI::strip):
324         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
325         (beforeAll):
326         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
327         (main):
328         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
329         (WebKitTestBus::run):
330         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
331         (WTR::getOutputDir):
332         (WTR::initializeFontConfigSetting):
333         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
334         (WTR::InjectedBundle::platformInitialize):
335         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
336         (WTR::topLevelPath):
337         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
338         (WTR::topLevelPath):
339         (WTR::getOutputDir):
340         (WTR::activateFonts):
341         * WebKitTestRunner/TestController.cpp:
342         (WTR::TestController::libraryPathForTesting):
343         (WTR::TestController::generateContextConfiguration const):
344         (WTR::TestController::generatePageConfiguration):
345         (WTR::TestController::decideDestinationWithSuggestedFilename):
346         (WTR::TestController::platformAdjustContext):
347         * WebKitTestRunner/TestController.h:
348         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
349         (WTR::TestController::cocoaPlatformInitialize):
350         (WTR::TestController::platformAdjustContext):
351         * WebKitTestRunner/gtk/main.cpp:
352         (main):
353         * WebKitTestRunner/mac/TestControllerMac.mm:
354         (WTR::TestController::configureContentExtensionForTest):
355         * WebKitTestRunner/wpe/main.cpp:
356         (main):
357         Utilize WTF::Environment where possible.
358
359 2019-02-14  Chris Dumez  <cdumez@apple.com>
360
361         [PSON] Introduce a WebContent Process cache
362         https://bugs.webkit.org/show_bug.cgi?id=194594
363         <rdar://problem/46793397>
364
365         Reviewed by Geoff Garen.
366
367         Update API tests to turn on the WebContent Process cache.
368
369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
370
371 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
372
373         Unreviewed, build fix after r241480
374
375         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
376         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
377         (-[DragAndDropSimulator initWithWebView:]):
378
379 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
380
381         AX: ARIA Reflection was disabled in error
382         https://bugs.webkit.org/show_bug.cgi?id=194647
383         <rdar://problem/48068336>
384
385         Reviewed by Ryosuke Niwa.
386
387         Remove test override now that this feature should be enabled by default.
388
389         * WebKitTestRunner/TestController.cpp:
390         (WTR::TestController::resetPreferencesToConsistentValues):
391
392 2019-02-14  Commit Queue  <commit-queue@webkit.org>
393
394         Unreviewed, rolling out r241486.
395         https://bugs.webkit.org/show_bug.cgi?id=194655
396
397         causing API failures in builds (Requested by ShawnRoberts on
398         #webkit).
399
400         Reverted changeset:
401
402         "[Cocoa] Media elements will restart network buffering just
403         before suspending"
404         https://bugs.webkit.org/show_bug.cgi?id=193691
405         https://trac.webkit.org/changeset/241486
406
407 2019-02-14  Zalan Bujtas  <zalan@apple.com>
408
409         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
410         https://bugs.webkit.org/show_bug.cgi?id=194622
411
412         Reviewed by Antti Koivisto.
413
414         * LayoutReloaded/misc/LFC-passing-tests.txt:
415
416 2019-02-14  Zalan Bujtas  <zalan@apple.com>
417
418         [LFC] Shrink-to-fit-width should be constrained by min/max width
419         https://bugs.webkit.org/show_bug.cgi?id=194653
420
421         Reviewed by Antti Koivisto.
422
423         * LayoutReloaded/misc/LFC-passing-tests.txt:
424
425 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
426
427         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
428         https://bugs.webkit.org/show_bug.cgi?id=194641
429
430         Reviewed by Geoffrey Garen.
431
432         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
433         so that the test would fail without this fix.
434
435         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
436         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
437
438 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
439
440         [ews-app] Change log level for a log statement
441
442         Unreviewed minor fix.
443
444         * BuildSlaveSupport/ews-app/ews/models/patch.py:
445         (Patch.save_patch):
446
447 2019-02-13  Jer Noble  <jer.noble@apple.com>
448
449         [Cocoa] Media elements will restart network buffering just before suspending
450         https://bugs.webkit.org/show_bug.cgi?id=193691
451
452         Reviewed by Eric Carlson.
453
454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
456         (TEST):
457
458 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
459
460         [ews-app] Fetch builder id to name mapping
461         https://bugs.webkit.org/show_bug.cgi?id=194355
462
463         Reviewed by Lucas Forschler.
464
465         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
466         (Buildbot.get_builder_id_to_name_mapping):
467         (Buildbot._get_display_name_from_builder_name):
468
469 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
470
471         Further restricting webarchive loads
472         https://bugs.webkit.org/show_bug.cgi?id=194567
473         <rdar://problem/47610130>
474
475         Reviewed by Youenn Fablet.
476
477         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
478         navigations on drop.
479
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
482         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
483         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
484         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
487         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
488         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
489         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
490         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
491         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
492         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
493
494 2019-02-13  John Wilander  <wilander@apple.com>
495
496         Store Ad Click Attribution requests in the network process
497         https://bugs.webkit.org/show_bug.cgi?id=194510
498         <rdar://problem/47650118>
499
500         Reviewed by Alex Christensen and Daniel Bates.
501
502         This patch adds two TestRunner functions:
503         - dumpAdClickAttribution()
504         - clearAdClickAttribution()
505
506         They call into the network process to dump and clear Ad Click
507         Attribution state, respectively.
508
509         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
511         (WTR::TestRunner::dumpAdClickAttribution):
512         (WTR::TestRunner::clearAdClickAttribution):
513         * WebKitTestRunner/InjectedBundle/TestRunner.h:
514         * WebKitTestRunner/TestController.cpp:
515         (WTR::TestController::resetStateToConsistentValues):
516         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
517         (WTR::adClickAttributionStringResultCallback):
518         (WTR::TestController::dumpAdClickAttribution):
519         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
520         (WTR::adClickAttributionVoidCallback):
521         (WTR::TestController::clearAdClickAttribution):
522         * WebKitTestRunner/TestController.h:
523         * WebKitTestRunner/TestInvocation.cpp:
524         (WTR::TestInvocation::dumpResults):
525         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
526         (WTR::TestInvocation::dumpAdClickAttribution):
527         * WebKitTestRunner/TestInvocation.h:
528
529 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
530
531         [ews-app] Generate status-bubble
532         https://bugs.webkit.org/show_bug.cgi?id=194572
533
534         Reviewed by Lucas Forschler.
535
536         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
537         (StatusBubble._build_bubble):
538         (StatusBubble._should_show_bubble_for):
539         (StatusBubble._build_bubbles_for_patch):
540
541 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
542
543         [ews-app] Add status bubble html template
544         https://bugs.webkit.org/show_bug.cgi?id=194571
545
546         Reviewed by Lucas Forschler.
547
548         * BuildSlaveSupport/ews-app/ews/templates: Added.
549         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
550
551 2019-02-12  Chris Dumez  <cdumez@apple.com>
552
553         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
554         https://bugs.webkit.org/show_bug.cgi?id=194568
555         <rdar://problem/47944490>
556
557         Reviewed by Ryosuke Niwa.
558
559         Add API test coverage.
560
561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
562         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
563
564 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
565
566         webkitpy: Remove bug_dummy from parsed test expectations
567         https://bugs.webkit.org/show_bug.cgi?id=194562
568         <rdar://problem/47853999>
569
570         Reviewed by Lucas Forschler.
571
572         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
573         (TestExpectationParser):
574         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
575         skipped tests.
576         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
577
578 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
579
580         [ews-app] Add method to fetch patch
581         https://bugs.webkit.org/show_bug.cgi?id=194518
582
583         Reviewed by Lucas Forschler.
584
585         * BuildSlaveSupport/ews-app/ews/models/patch.py:
586         (Patch.get_patch):
587
588 2019-02-12  Zalan Bujtas  <zalan@apple.com>
589
590         [LFC] Expand tests coverage (60 new tests -> 860)
591
592         Unreviewed test gardening (run-singly, --child-processes=1).
593
594         * LayoutReloaded/misc/LFC-passing-tests.txt:
595
596 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
597
598         Allow pages to trigger programmatic paste from script on iOS
599         https://bugs.webkit.org/show_bug.cgi?id=194271
600         <rdar://problem/47808810>
601
602         Reviewed by Tim Horton.
603
604         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
605
606         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
607         (WTR::UIScriptController::platformSetDidShowMenuCallback):
608         (WTR::UIScriptController::platformSetDidHideMenuCallback):
609         (WTR::UIScriptController::rectForMenuAction const):
610
611         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
612         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
613         for when the menu is shown or hidden.
614
615         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
616         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
617         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
618         (WTR::UIScriptController::setDidShowMenuCallback):
619         (WTR::UIScriptController::didShowMenuCallback const):
620         (WTR::UIScriptController::setDidHideMenuCallback):
621         (WTR::UIScriptController::didHideMenuCallback const):
622         (WTR::UIScriptController::platformSetDidShowMenuCallback):
623         (WTR::UIScriptController::platformSetDidHideMenuCallback):
624         (WTR::UIScriptController::rectForMenuAction const):
625         * TestRunnerShared/UIScriptContext/UIScriptController.h:
626         * WebKitTestRunner/TestController.cpp:
627         (WTR::TestController::resetPreferencesToConsistentValues):
628         (WTR::updateTestOptionsFromTestHeader):
629         * WebKitTestRunner/TestOptions.h:
630
631         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
632         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
633
634         (WTR::TestOptions::hasSameInitializationOptions const):
635         * WebKitTestRunner/UIScriptControllerCocoa.mm:
636         (WTR::UIScriptController::calendarType const):
637         (WTR::UIScriptController::platformUndoManager const):
638         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
639         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
640         (-[TestRunnerWKWebView initWithFrame:configuration:]):
641         (-[TestRunnerWKWebView dealloc]):
642         (-[TestRunnerWKWebView _didShowMenu]):
643         (-[TestRunnerWKWebView _didHideMenu]):
644
645         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
646
647         * WebKitTestRunner/ios/TestControllerIOS.mm:
648         (WTR::handleMenuWillHideNotification):
649         (WTR::handleMenuDidHideNotification):
650         (WTR::TestController::platformInitialize):
651         (WTR::TestController::platformDestroy):
652         (WTR::TestController::platformResetStateToConsistentValues):
653
654         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
655         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
656
657         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
658         (WTR::forEachViewInHierarchy):
659         (WTR::findViewInHierarchyOfType):
660
661         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
662         functions that dig through a given view's hierarchy in search of a view of a given class.
663
664         (WTR::UIScriptController::selectionStartGrabberViewRect const):
665         (WTR::UIScriptController::selectionEndGrabberViewRect const):
666         (WTR::UIScriptController::selectionCaretViewRect const):
667         (WTR::UIScriptController::selectionRangeViewRects const):
668         (WTR::UIScriptController::platformSetDidShowMenuCallback):
669         (WTR::UIScriptController::platformSetDidHideMenuCallback):
670
671         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
672
673         (WTR::UIScriptController::rectForMenuAction const):
674
675         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
676         callout bar) whose label matches the given string.
677
678         (WTR::UIScriptController::platformContentView const):
679
680         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
681         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
682         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
683
684         (WTR::UIScriptController::platformUndoManager const): Deleted.
685         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
686         (WTR::UIScriptController::platformContentView const):
687         (WTR::UIScriptController::platformUndoManager const): Deleted.
688
689 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
690
691         webkitpy: No option to only show unexpected failures in results.html for iPad
692         https://bugs.webkit.org/show_bug.cgi?id=194554
693         <rdar://problem/47922442>
694
695         Rubber-stamped by Aakash Jain.
696
697         Just because a TestExpecations file does not exist for a specific platform does not mean that
698         TestExpecations are not being used, given that platforms inherit test expectations.
699
700         * Scripts/webkitpy/port/base.py:
701         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
702         * Scripts/webkitpy/port/base_unittest.py:
703         (PortTest.test_uses_test_expectations_file):
704
705 2019-02-12  Alex Christensen  <achristensen@webkit.org>
706
707         Remove setDefersLoading infrastructure from WebKit2
708         https://bugs.webkit.org/show_bug.cgi?id=194506
709
710         Reviewed by Brady Eidson.
711
712         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
714         (WTR::TestRunner::setDefersLoading): Deleted.
715         * WebKitTestRunner/InjectedBundle/TestRunner.h:
716
717 2019-02-12  Alex Christensen  <achristensen@webkit.org>
718
719         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
720         https://bugs.webkit.org/show_bug.cgi?id=194522
721         <rdar://problem/47789393>
722
723         Reviewed by Chris Dumez.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
727         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
729
730 2019-02-12  Andy Estes  <aestes@apple.com>
731
732         [iOSMac] Enable Parental Controls Content Filtering
733         https://bugs.webkit.org/show_bug.cgi?id=194521
734         <rdar://39732376>
735
736         Reviewed by Tim Horton.
737
738         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
739
740 2019-02-12  Zalan Bujtas  <zalan@apple.com>
741
742         [LFC][IFC] Add intrinsic width support for float boxes.
743         https://bugs.webkit.org/show_bug.cgi?id=194528
744
745         Reviewed by Antti Koivisto.
746
747         Expand tests coverage (2 new tests -> 800).
748         (This is the correct test ordering --runs-singly --child-processes=1)
749
750         * LayoutReloaded/misc/LFC-passing-tests.txt:
751
752 2019-02-12  Rob Buis  <rbuis@igalia.com>
753
754         Implement serializing in MIME type parser
755         https://bugs.webkit.org/show_bug.cgi?id=193909
756
757         Reviewed by Darin Adler.
758
759         Add various tests involving upper case, non-ASCII, control/null characters,
760         various HTTP whitespace, single quotes and an unpaired surrogate.
761
762         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
763         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
764         (TestWebKitAPI::serializeIfValid):
765         (TestWebKitAPI::TEST):
766
767 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
768
769         [Cocoa] Ask platform for generic font family mappings
770         https://bugs.webkit.org/show_bug.cgi?id=187723
771         <rdar://problem/41892438>
772
773         Reviewed by Brent Fulgham.
774
775         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
776
777         * DumpRenderTree/mac/DumpRenderTree.mm:
778         (allowedFontFamilySet):
779         * WebKitTestRunner/mac/TestControllerMac.mm:
780         (WTR::allowedFontFamilySet):
781
782 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
783
784         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
785         https://bugs.webkit.org/show_bug.cgi?id=193622
786
787         Reviewed by Michael Catanzaro.
788
789         This adds support for loading content extension rule sets from the JSON files which
790         accompany the corresponding layout test, using the C API. The Cocoa specific parts
791         of WKTR for this could be removed, but that is left for a follow-up patch with
792         cleanups.
793
794         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::testPath): Subtract one from the length when constructing the result std::string to
797         avoid having the null-terminator copied into the result.
798         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
799         part of the preparations to run a test.
800         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
801         (WTR::contentExtensionStoreCallback): Added.
802         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
803         used for content extensions test.
804         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
805         extensions and compiling the JSON rule set for tests involving content extensions.
806         (WTR::TestController::resetContentExtensions): Removes the content extension built for
807         testing and disables content extensions.
808         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
809         resetContentExtensions().
810         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
811         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
812         configureContentExtensionForTest(), and userContentController().
813
814 2019-02-11  Daniel Bates  <dabates@apple.com>
815
816         [iOS] Mouse/Touch/Pointer events are missing modifier keys
817         https://bugs.webkit.org/show_bug.cgi?id=191446
818         <rdar://problem/45929460>
819
820         Reviewed by Tim Horton.
821
822         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
823
824         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
825         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
826         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
827         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
828         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
829         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
830         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
831         * TestRunnerShared/UIScriptContext/UIScriptController.h:
832         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
833         (WTR::arrayLength):
834         (WTR::parseModifierArray):
835         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
836         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
837         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
838         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
839
840 2019-02-11  Commit Queue  <commit-queue@webkit.org>
841
842         Unreviewed, rolling out r241272 and r241276.
843         https://bugs.webkit.org/show_bug.cgi?id=194514
844
845         Broke the Apple Internal build and the fix requires human
846         intervention :( (Requested by dydz on #webkit).
847
848         Reverted changesets:
849
850         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
851         https://bugs.webkit.org/show_bug.cgi?id=191446
852         https://trac.webkit.org/changeset/241272
853
854         "Fix internal iOS build after r241272"
855         https://bugs.webkit.org/show_bug.cgi?id=191446
856         https://trac.webkit.org/changeset/241276
857
858 2019-02-11  Truitt Savell  <tsavell@apple.com>
859
860         Unreviewed, rolling out r241269.
861
862         Caused 5 layout tests crashes on Mac WK1
863
864         Reverted changeset:
865
866         "DumpRenderTree should report unknown options"
867         https://bugs.webkit.org/show_bug.cgi?id=191303
868         https://trac.webkit.org/changeset/241269
869
870 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
871
872         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
873         https://bugs.webkit.org/show_bug.cgi?id=194313
874
875         Reviewed by Tim Horton.
876
877         Add a helper to determine whether the web view is presenting modal UI.
878
879         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
880         (WTR::UIScriptController::isPresentingModally const):
881         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
882         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
883         (WTR::UIScriptController::isPresentingModally const):
884         * TestRunnerShared/UIScriptContext/UIScriptController.h:
885         * WebKitTestRunner/UIScriptControllerCocoa.mm:
886         (WTR::UIScriptController::calendarType const): Deleted.
887         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
888         (WTR::UIScriptController::isPresentingModally const):
889         (WTR::UIScriptController::calendarType const):
890         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
891         (WTR::UIScriptController::calendarType const):
892
893 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
894
895         GCHeapInspector: Show the retained sizes in more places
896         https://bugs.webkit.org/show_bug.cgi?id=194464
897
898         Reviewed by Simon Fraser.
899
900         * GCHeapInspector/gc-heap-inspector.html:
901         * GCHeapInspector/script/interface.js:
902         (HeapInspectorUtils.humanReadableSize):
903         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
904         (HeapInspectorUtils.spanForNode.span.span):
905         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
906         (HeapSnapshotInspector.prototype.buildRoots):
907
908 2019-02-11  Daniel Bates  <dabates@apple.com>
909
910         [iOS] Mouse/Touch/Pointer events are missing modifier keys
911         https://bugs.webkit.org/show_bug.cgi?id=191446
912         <rdar://problem/45929460>
913
914         Reviewed by Tim Horton.
915
916         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
917
918         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
919         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
920         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
921         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
922         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
923         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
924         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
925         * TestRunnerShared/UIScriptContext/UIScriptController.h:
926         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
927         (WTR::arrayLength):
928         (WTR::parseModifierArray):
929         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
930         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
931         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
932         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
933
934 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
935
936         DumpRenderTree should report unknown options
937         https://bugs.webkit.org/show_bug.cgi?id=191303
938
939         Reviewed by Frédéric Wang.
940
941         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
942         to report unknown options.
943         Added and assigned test options which are currently used in tests.
944
945         * DumpRenderTree/TestOptions.cpp:
946         (TestOptions::TestOptions):
947
948 2019-02-11  Truitt Savell  <tsavell@apple.com>
949
950         Unreviewed, rolling out r241229.
951
952         Revision broke internal builds for watchOS.
953
954         Reverted changeset:
955
956         "[Cocoa] Ask platform for generic font family mappings"
957         https://bugs.webkit.org/show_bug.cgi?id=187723
958         https://trac.webkit.org/changeset/241229
959
960 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
961
962         [WinCairo][MiniBrowser] Basic authentication always fails.
963         https://bugs.webkit.org/show_bug.cgi?id=194496
964
965         Reviewed by Don Olmstead.
966
967         * MiniBrowser/win/DialogHelper.h:
968         (Dialog::getText):
969
970 2019-02-11  Philippe Normand  <pnormand@igalia.com>
971
972         [GStreamer] GstMappedBuffer testsuite build fails
973         https://bugs.webkit.org/show_bug.cgi?id=194495
974
975         Reviewed by Carlos Garcia Campos.
976
977         Fix the build by explicitely adding the gstreamer1.0-audio include
978         directories to the include path.
979
980         * TestWebKitAPI/PlatformGTK.cmake:
981         * TestWebKitAPI/PlatformWPE.cmake:
982
983 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
984
985         [GTK][WPE] Add enable-javascript-markup setting
986         https://bugs.webkit.org/show_bug.cgi?id=193439
987
988         Reviewed by Michael Catanzaro.
989
990         Add test cases to check the new setting.
991
992         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
993         (testWebKitSettings):
994         (testWebKitSettingsJavaScriptMarkup):
995         (beforeAll):
996
997 2019-02-10  Darin Adler  <darin@apple.com>
998
999         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1000         https://bugs.webkit.org/show_bug.cgi?id=194485
1001
1002         Reviewed by Daniel Bates.
1003
1004         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1005
1006 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1007
1008         Add more tests for clampTo<>()
1009         https://bugs.webkit.org/show_bug.cgi?id=194462
1010
1011         Reviewed by Geoffrey Garen.
1012
1013         Darin suggested to test the very last floating point number
1014         at the boundaries when truncating to integer.
1015         I added test for max/min and max-1/min-1.
1016
1017         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1018         (TestWebKitAPI::TEST):
1019
1020 2019-02-09  Darin Adler  <darin@apple.com>
1021
1022         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1023         https://bugs.webkit.org/show_bug.cgi?id=194021
1024
1025         Reviewed by Geoffrey Garen.
1026
1027         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1028         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1029         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1030
1031 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1032
1033         [LFC][IFC] Add intrinsic width support for basic inline containers
1034         https://bugs.webkit.org/show_bug.cgi?id=194473
1035
1036         Reviewed by Antti Koivisto.
1037
1038         Expand tests coverage (11 new tests -> 798)
1039
1040         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1041
1042 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1043
1044         Fix MiniBrowser's entitlements
1045         https://bugs.webkit.org/show_bug.cgi?id=192431
1046
1047         Reviewed by Joseph Pecoraro.
1048
1049         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1050         files, making it impossible to load any extension.
1051
1052         * MiniBrowser/MiniBrowser.entitlements:
1053
1054 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1055
1056         [Cocoa] Ask platform for generic font family mappings
1057         https://bugs.webkit.org/show_bug.cgi?id=187723
1058         <rdar://problem/41892438>
1059
1060         Reviewed by Brent Fulgham.
1061
1062         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1063
1064         * DumpRenderTree/mac/DumpRenderTree.mm:
1065         (allowedFontFamilySet):
1066         * WebKitTestRunner/mac/TestControllerMac.mm:
1067         (WTR::allowedFontFamilySet):
1068
1069 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1070
1071         [GTK] Implement back/forward touchpad gesture
1072         https://bugs.webkit.org/show_bug.cgi?id=193919
1073
1074         Reviewed by Michael Catanzaro.
1075
1076         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1077         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1078
1079 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1080
1081         Add SPI to use networking daemon instead of XPC service
1082         https://bugs.webkit.org/show_bug.cgi?id=194427
1083
1084         Reviewed by Geoffrey Garen
1085
1086         * MiniBrowser/MiniBrowser.entitlements:
1087
1088 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1089
1090         [ews-build] Ensure that every builder in config.json has short name
1091         https://bugs.webkit.org/show_bug.cgi?id=194461
1092
1093         Reviewed by Lucas Forschler.
1094
1095         * BuildSlaveSupport/ews-build/loadConfig.py:
1096         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1097
1098 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] Add short name to config.json
1101         https://bugs.webkit.org/show_bug.cgi?id=194456
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/config.json: Added short name.
1106         * BuildSlaveSupport/ews-build/loadConfig.py:
1107         (loadBuilderConfig): Set the short name as the builder description.
1108
1109 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1110
1111         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1112         https://bugs.webkit.org/show_bug.cgi?id=194418
1113
1114         Reviewed by Lucas Forschler.
1115
1116         Do not include errors trying when finding crashlogs at the end of
1117         a run-webkit-tests run since we don't process those errors.
1118
1119         * Scripts/webkitpy/port/darwin.py:
1120         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1121         * Scripts/webkitpy/port/ios_device.py:
1122         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1123         * Scripts/webkitpy/port/watch_device.py:
1124         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1125
1126 2019-02-08  Beth Dakin  <bdakin@apple.com>
1127
1128         Add afterScreenUpdates to WKSnapshotConfiguration
1129         https://bugs.webkit.org/show_bug.cgi?id=194362
1130         -and corresponding-
1131         <rdar://problem/40655528> Please add an "after screen updates" property to 
1132         WKSnapshotConfiguration (to solve blank snapshots)
1133
1134         Reviewed by Tim Horton.
1135
1136         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1137         (TEST):
1138
1139 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1140
1141         clampTo(): do not convert the input to double when dealing with integers
1142         https://bugs.webkit.org/show_bug.cgi?id=194263
1143         <rdar://problem/47692312>
1144
1145         Reviewed by Darin Adler.
1146
1147         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1148         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1149         (TestWebKitAPI::testClampFloatingPointToInteger):
1150         (TestWebKitAPI::testClampSameSignIntegers):
1151         (TestWebKitAPI::testClampUnsignedToSigned):
1152         (TestWebKitAPI::testClampSignedToUnsigned):
1153
1154 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1155
1156         webkitpy: Respect --dedicated-simulators flag
1157         https://bugs.webkit.org/show_bug.cgi?id=194416
1158         <rdar://problem/47894722>
1159
1160         Reviewed by Lucas Forschler.
1161
1162         * Scripts/webkitpy/port/device_port.py:
1163         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1164         available devices can be safely ignored.
1165
1166 2019-02-07  Keith Rollin  <krollin@apple.com>
1167
1168         Remove extra copy of 100x100-red.tga
1169         https://bugs.webkit.org/show_bug.cgi?id=194371
1170         <rdar://problem/47873465>
1171
1172         Reviewed by Said Abou-Hallawa.
1173
1174         In order to help it pass its tests, Bug 194190 added a second copy of
1175         the file 100x100-red.tga. However, it turns out that this additional
1176         file wasn't actually needed, and that that sole previous copy was
1177         sufficient. At the same time, this second copy -- which was copied to
1178         the same location in the build output as the first copy -- now caused
1179         XCBuild to complain because there were two production rules for the
1180         same output file. Address this by removing the newly-added extra copy.
1181
1182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1183         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1184
1185 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1186
1187         Deprecate WKBundlePageSetDefersLoading
1188         https://bugs.webkit.org/show_bug.cgi?id=191394
1189
1190         Reviewed by Dean Jackson.
1191
1192         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1193         (WTR::TestRunner::setDefersLoading):
1194
1195 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1196
1197         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1198         https://bugs.webkit.org/show_bug.cgi?id=194391
1199
1200         Reviewed by Antti Koivisto.
1201
1202         * LayoutReloaded/misc/LFC-passing-tests.txt:
1203
1204 2019-02-06  Keith Rollin  <krollin@apple.com>
1205
1206         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1207         https://bugs.webkit.org/show_bug.cgi?id=193975
1208         <rdar://problem/47643306>
1209
1210         Reviewed by Tim Horton.
1211
1212         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1213         the Info.plist file into the bundle. This step is not necessary as the
1214         implicit "bundle up all the build products into a framework" build
1215         phase does this already. Having the Copy Bundle Resources phase do
1216         this causes a conflict under XCBuild, which objects to two build
1217         phases producing the same file (Info.plist). Address this by removing
1218         Info.plist from the Copy Bundle Resources phase.
1219
1220         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1221
1222 2019-02-06  Keith Rollin  <krollin@apple.com>
1223
1224         Really enable the automatic checking and regenerations of .xcfilelists during builds
1225         https://bugs.webkit.org/show_bug.cgi?id=194357
1226         <rdar://problem/47861231>
1227
1228         Reviewed by Chris Dumez.
1229
1230         Bug 194124 was supposed to enable the automatic checking and
1231         regenerating of .xcfilelist files during the build. While related
1232         changes were included in that patch, the change to actually enable the
1233         operation somehow was omitted. This patch actually enables the
1234         operation. The check-xcfilelist.sh scripts now check
1235         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1236         from the checking.
1237
1238         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1239         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1240
1241 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1242
1243         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1244         <https://webkit.org/b/194286>
1245         <rdar://problem/47815558>
1246
1247         Reviewed by Alexey Proskuryakov.
1248
1249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1250         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1251         WKRetainPtr<> to avoid leaking the WKDataRef.
1252
1253 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1254
1255         Unreviewed, fix a typo
1256
1257         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1258
1259 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1260
1261         [GTK][WPE] force libpsl build to use ICU in jhbuild
1262         https://bugs.webkit.org/show_bug.cgi?id=194288
1263
1264         Reviewed by Carlos Garcia Campos.
1265
1266         * gtk/jhbuild.modules:
1267         Require ICU for libpsl build in jhbuild, like done in WPE.
1268
1269 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1270
1271         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1272         https://bugs.webkit.org/show_bug.cgi?id=194209
1273
1274         Reviewed by Carlos Garcia Campos.
1275
1276         Enhance TestCookieManager to ensure this doesn't happen again.
1277
1278         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1279         (testCookieManagerPersistentStorage):
1280         (beforeAll):
1281
1282 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1283
1284         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1285         https://bugs.webkit.org/show_bug.cgi?id=194324
1286
1287         Reviewed by Andy Estes.
1288
1289         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1290         part of the name is already implicit, since this is in testing code in TestOptions.
1291
1292         * WebKitTestRunner/TestController.cpp:
1293         (WTR::TestController::generateContextConfiguration const):
1294         (WTR::updateTestOptionsFromTestHeader):
1295         * WebKitTestRunner/TestOptions.h:
1296         (WTR::TestOptions::hasSameInitializationOptions const):
1297
1298 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1299
1300         [ews-build] Allow * as platform for builders and workers
1301         https://bugs.webkit.org/show_bug.cgi?id=188533
1302
1303         Reviewed by Lucas Forschler.
1304
1305         * BuildSlaveSupport/ews-build/loadConfig.py:
1306         (checkWorkersAndBuildersForConsistency):
1307
1308 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1309
1310         [ews-build] Add few bots to config.json
1311         https://bugs.webkit.org/show_bug.cgi?id=194304
1312
1313         Reviewed by Lucas Forschler.
1314
1315         * BuildSlaveSupport/ews-build/config.json:
1316
1317 2019-02-05  Keith Rollin  <krollin@apple.com>
1318
1319         Enable the automatic checking and regenerations of .xcfilelists during builds
1320         https://bugs.webkit.org/show_bug.cgi?id=194124
1321         <rdar://problem/47721277>
1322
1323         Reviewed by Tim Horton.
1324
1325         Bug 193790 add a facility for checking -- during build time -- that
1326         any needed .xcfilelist files are up-to-date and for updating them if
1327         they are not. This facility was initially opt-in by setting
1328         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1329         the process seemed robust. Its now time to enable this facility and
1330         make it opt-out. If there is a need to disable this facility, set and
1331         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1332         running `make` or `build-webkit`, or before running Xcode from the
1333         command line.
1334
1335         Additionally, remove the step that generates a list of source files
1336         going into the UnifiedSources build step. It's only necessarily to
1337         specify Sources.txt and SourcesCocoa.txt as inputs.
1338
1339         * Scripts/generate-xcfilelists:
1340
1341 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1342
1343         [GTK][WPE] force libpsl build to use ICU in jhbuild
1344         https://bugs.webkit.org/show_bug.cgi?id=194288
1345
1346         Reviewed by Philippe Normand.
1347
1348         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1349         This can cause build failures if libidn is detected but libunistring is not available.
1350
1351         Make sure that ICU is used for runtime and builtin PSL data.
1352
1353         * gtk/jhbuild.modules:
1354         * wpe/jhbuild.modules:
1355
1356 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] Modified timestamp should be updated on updating data
1359         https://bugs.webkit.org/show_bug.cgi?id=194295
1360
1361         Reviewed by Lucas Forschler.
1362
1363         * BuildSlaveSupport/ews-app/ews/models/build.py:
1364         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1365         * BuildSlaveSupport/ews-app/ews/models/step.py:
1366
1367 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1368
1369         Unreviewed, rolling out r240742.
1370
1371         Causes crashes on iOS simulator.
1372
1373         Reverted changeset:
1374
1375         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1376         not focused in a content-editable element"
1377         https://bugs.webkit.org/show_bug.cgi?id=192824
1378         https://trac.webkit.org/changeset/240742
1379
1380 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1381
1382         run-webkit-tests emits message "...running None" when running tests
1383         https://bugs.webkit.org/show_bug.cgi?id=194133
1384         <rdar://problem/47724738>
1385
1386         Reviewed by Lucas Forschler.
1387
1388         * Scripts/webkitpy/xcode/device_type.py:
1389         (DeviceType.__str__): Use both version mapping tables and use just the variant
1390         name if no version name is available.
1391         * Scripts/webkitpy/xcode/device_type_unittest.py:
1392         (DeviceTypeTest):
1393         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1394         an associated named.
1395
1396 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1397
1398         [WPE] require python3-setuptools for meson build in jhbuild
1399         https://bugs.webkit.org/show_bug.cgi?id=194287
1400
1401         Reviewed by Philippe Normand.
1402
1403         python3-setuptools is needed to build meson in jhbuild.
1404         It is already required by the GTK port.
1405
1406         * wpe/install-dependencies:
1407
1408 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1409
1410         [ews-app] Add method to save BuilderMapping to database
1411         https://bugs.webkit.org/show_bug.cgi?id=194264
1412
1413         Reviewed by Lucas Forschler.
1414
1415         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1416         (BuilderMapping.__str__):
1417         (BuilderMapping):
1418         (BuilderMapping.save_mapping):
1419         (BuilderMapping.update_mapping):
1420         (BuilderMapping.get_existing_mapping):
1421         (BuilderMapping.is_valid_mapping):
1422
1423 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1424
1425         [ews-app] Add timestamp fields for BuilderMappings
1426         https://bugs.webkit.org/show_bug.cgi?id=194266
1427
1428         Reviewed by Lucas Forschler.
1429
1430         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1431         (BuilderMapping):
1432
1433 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1434
1435         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1436         https://bugs.webkit.org/show_bug.cgi?id=174816
1437
1438         Reviewed by Michael Catanzaro.
1439
1440         Add tests for webkit_uri_for_display().
1441
1442         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1443         (testURIForDisplayUnaffected):
1444         (testURIForDisplayAffected):
1445         (beforeAll):
1446         (afterAll):
1447         * TestWebKitAPI/glib/CMakeLists.txt:
1448
1449 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1450
1451         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1452         https://bugs.webkit.org/show_bug.cgi?id=194158
1453         <rdar://problem/47737268>
1454
1455         Rubber-stamped by Aakash Jain.
1456
1457         * Scripts/webkitpy/port/device_port.py:
1458         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1459
1460 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1461
1462         [CG] Enable setAdditionalSupportedImageTypes for WK1
1463         https://bugs.webkit.org/show_bug.cgi?id=194190
1464
1465         Reviewed by Tim Horton.
1466
1467         Add a test similar to the one under WebKit Cocoa but make it create a
1468         WebView instead of a WKWebView.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1472         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1473         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1474         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1475         (TestWebKitAPI::runTest):
1476         (TestWebKitAPI::TEST):
1477
1478 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1479
1480         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1481         https://bugs.webkit.org/show_bug.cgi?id=194168
1482
1483         Reviewed by Simon Fraser.
1484
1485         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1489         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1490         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1491         (TEST):
1492         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1493         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1494
1495 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1496
1497         REGRESSION (r237269): webkit-patch what-broke is broken 
1498         https://bugs.webkit.org/show_bug.cgi?id=193025
1499
1500         Reviewed by Aakash Jain.
1501
1502         * Scripts/webkitpy/common/host.py:
1503         (Host.buildbot):
1504         (Host.bugzilla): Renamed to 'buildbot'.
1505
1506 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1507
1508         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1509         https://bugs.webkit.org/show_bug.cgi?id=194207
1510
1511         Reviewed by Tim Horton.
1512
1513         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1514         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1515         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1516         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1517         start and delete forwards to remove the original attachment.
1518
1519         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1520         (TestWebKitAPI::TEST):
1521
1522 2019-02-04  Youenn Fablet  <youenn@apple.com>
1523
1524         Capture state should be managed consistently when doing process swapping
1525         https://bugs.webkit.org/show_bug.cgi?id=194122
1526         <rdar://problem/47609293>
1527
1528         Reviewed by Eric Carlson.
1529
1530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1531         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1532         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1533         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1534         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1536         (WTR::TestRunner::isDoingMediaCapture const):
1537         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1538         * WebKitTestRunner/TestController.cpp:
1539         (WTR::TestController::isDoingMediaCapture const):
1540         * WebKitTestRunner/TestController.h:
1541         * WebKitTestRunner/TestInvocation.cpp:
1542         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1543         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1544         (WTR::TestController::isDoingMediaCapture const):
1545
1546 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1547
1548         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1549         https://bugs.webkit.org/show_bug.cgi?id=194142
1550
1551         Reviewed by Ross Kirsling.
1552
1553         There three 'separator' variables in TestController.cpp. Renamed
1554         it 'pathSeparator', and unified them.
1555
1556         * WebKitTestRunner/TestController.cpp:
1557         (WTR::TestController::generateContextConfiguration const):
1558         (WTR::createTestURL):
1559         (WTR::TestController::platformAdjustContext):
1560
1561 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1562
1563         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1564         https://bugs.webkit.org/show_bug.cgi?id=194198
1565
1566         Reviewed by Antti Koivisto.
1567
1568         No need to set the banner heights on navigation now, since Page stores them.
1569
1570         * MiniBrowser/mac/WK2BrowserWindowController.m:
1571         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1572
1573 2019-02-03  John Wilander  <wilander@apple.com>
1574
1575         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1576         https://bugs.webkit.org/show_bug.cgi?id=194104
1577         <rdar://problem/47649991>
1578
1579         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1580
1581         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1582         (TestWebKitAPI::TEST):
1583             Changed numeric types from unsigned short to uint32_t.
1584
1585 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1586
1587         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1588         <https://webkit.org/b/194178>
1589         <rdar://problem/47753473>
1590
1591         Reviewed by Alexey Proskuryakov.
1592
1593         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1594         (WTR::uninstallFakeHelvetica): Pass nullptr into
1595         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1596
1597 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1598
1599         [LFC] Initialize ICB's style with fixed width/height.
1600         https://bugs.webkit.org/show_bug.cgi?id=194188
1601
1602         Reviewed by Antti Koivisto.
1603
1604         * LayoutReloaded/misc/LFC-passing-tests.txt:
1605
1606 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1607
1608         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1609         https://bugs.webkit.org/show_bug.cgi?id=194185
1610
1611         Reviewed by Antti Koivisto.
1612
1613         * LayoutReloaded/misc/LFC-passing-tests.txt:
1614
1615 2018-12-16  Darin Adler  <darin@apple.com>
1616
1617         Convert additional String::format clients to alternative approaches
1618         https://bugs.webkit.org/show_bug.cgi?id=192746
1619
1620         Reviewed by Alexey Proskuryakov.
1621
1622         * WebKitTestRunner/TestController.cpp:
1623         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1624         as an intermediate in code that ultimately constructs a WTF::String.
1625         (WTR::userMediaOriginHash): Use makeString.
1626         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1627         (WTR::TestController::didPerformClientRedirect): Ditto.
1628         (WTR::TestController::didPerformServerRedirect): Ditto.
1629         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1630
1631 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-build] Add unit test to verify builder keys
1634         https://bugs.webkit.org/show_bug.cgi?id=194152
1635
1636         Reviewed by Lucas Forschler.
1637
1638         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1639         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1640
1641 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1642
1643         [LFC] Expand tests coverage (12 new tests -> 787)
1644
1645         Unreviewed test gardening.
1646
1647         * LayoutReloaded/misc/LFC-passing-tests.txt:
1648
1649 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1650
1651         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1652         https://bugs.webkit.org/show_bug.cgi?id=194163
1653
1654         Reviewed by Simon Fraser.
1655
1656         775
1657
1658         * LayoutReloaded/misc/LFC-passing-tests.txt:
1659
1660 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1661
1662         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1663         https://bugs.webkit.org/show_bug.cgi?id=194140
1664         <rdar://problem/47728098>
1665
1666         Reviewed by Tim Horton.
1667
1668         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1669         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1670         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1671
1672         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1673         test to induce an IPC deadlock when presenting a modal alert during touch start.
1674
1675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1676         * WebKitTestRunner/TestController.cpp:
1677         (WTR::runJavaScriptAlert):
1678
1679         Add a client callback function for running JavaScript alerts.
1680
1681         (WTR::TestController::createOtherPage):
1682         (WTR::TestController::generateContextConfiguration const):
1683
1684         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1685         the fix in this patch.
1686
1687         (WTR::TestController::createWebViewWithOptions):
1688
1689         Plumb TestOptions to generateContextConfiguration.
1690
1691         (WTR::TestController::resetPreferencesToConsistentValues):
1692         (WTR::TestController::resetStateToConsistentValues):
1693         (WTR::updateTestOptionsFromTestHeader):
1694         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1695         (WTR::TestController::handleJavaScriptAlert):
1696         * WebKitTestRunner/TestController.h:
1697         * WebKitTestRunner/TestInvocation.cpp:
1698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1699         * WebKitTestRunner/TestOptions.h:
1700         (WTR::TestOptions::hasSameInitializationOptions const):
1701
1702 2019-02-01  Chris Dumez  <cdumez@apple.com>
1703
1704         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1705         https://bugs.webkit.org/show_bug.cgi?id=193740
1706         <rdar://problem/47527267>
1707
1708         Reviewed by Alex Christensen.
1709
1710         Add API test coverage.
1711
1712         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1713
1714 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-app] Add display name field to BuilderMapping model
1717         https://bugs.webkit.org/show_bug.cgi?id=194153
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1722         (BuilderMapping):
1723
1724 2019-02-01  Youenn Fablet  <youenn@apple.com>
1725
1726         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1727         https://bugs.webkit.org/show_bug.cgi?id=194155
1728
1729         Reviewed by Eric Carlson.
1730
1731         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1732         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1733         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1734
1735 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1736
1737         [LFC] Adjust replaced element's intrinsic ratio
1738         https://bugs.webkit.org/show_bug.cgi?id=194154
1739
1740         Reviewed by Antti Koivisto.
1741
1742         761
1743
1744         * LayoutReloaded/misc/LFC-passing-tests.txt:
1745
1746 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [WPE] Show test results in minibrowser
1749         https://bugs.webkit.org/show_bug.cgi?id=194150
1750
1751         Reviewed by Žan Doberšek.
1752
1753         * Scripts/webkitpy/port/wpe.py:
1754         (WPEPort.show_results_html_file):
1755
1756 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1757
1758         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1759         https://bugs.webkit.org/show_bug.cgi?id=194151
1760
1761         Reviewed by Žan Doberšek.
1762
1763         ALT + <- go back
1764         ALT + -> go forward
1765
1766         * MiniBrowser/wpe/main.cpp:
1767         (main):
1768
1769 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1770
1771         [LFC] Set intrinsic size on Layout::Replaced
1772         https://bugs.webkit.org/show_bug.cgi?id=194139
1773
1774         Reviewed by Antti Koivisto.
1775
1776         744
1777
1778         * LayoutReloaded/misc/LFC-passing-tests.txt:
1779
1780 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1783         https://bugs.webkit.org/show_bug.cgi?id=194146
1784
1785         Reviewed by Xabier Rodriguez-Calvar.
1786
1787         It allows to open relative paths.
1788
1789         * MiniBrowser/wpe/main.cpp:
1790         (main):
1791
1792 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1793
1794         Update flakiness dashboard configuration after recent queue changes
1795         https://bugs.webkit.org/show_bug.cgi?id=194127
1796
1797         Rubber-stamped by Aakash Jain.
1798
1799         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1800
1801         * TestResultServer/static-dashboards/builders.jsonp:
1802
1803 2019-01-31  Youenn Fablet  <youenn@apple.com>
1804
1805         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1806         https://bugs.webkit.org/show_bug.cgi?id=194106
1807         <rdar://problem/47676333>
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1812         (TestWebKitAPI::didFinishNavigation):
1813         (TestWebKitAPI::TEST):
1814         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1815
1816 2019-01-31  Chris Dumez  <cdumez@apple.com>
1817
1818         Page zoom level is lost after a process swap or a crash
1819         https://bugs.webkit.org/show_bug.cgi?id=194105
1820         <rdar://problem/47610781>
1821
1822         Reviewed by Alex Christensen.
1823
1824         Add API test coverage.
1825
1826         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1827         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1828
1829 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1830
1831         Revert r238819 which is unneeded and caused a performance regression.
1832         https://bugs.webkit.org/show_bug.cgi?id=192272
1833         <rdar://problem/46664625>
1834
1835         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1836         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1837         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1838
1839 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1840
1841         Formalize WebKitAdditions mechanism of LoadOptimizer
1842         https://bugs.webkit.org/show_bug.cgi?id=193886
1843         <rdar://problem/47696809>
1844
1845         Reviewed by Brent Fulgham.
1846
1847         * MiniBrowser/MiniBrowser.entitlements:
1848         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1849
1850 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1851
1852         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1853         https://bugs.webkit.org/show_bug.cgi?id=194090
1854
1855         Reviewed by Antti Koivisto.
1856
1857         * LayoutReloaded/misc/LFC-passing-tests.txt:
1858
1859 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1860
1861         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1862         https://bugs.webkit.org/show_bug.cgi?id=194074
1863
1864         Reviewed by Antti Koivisto.
1865
1866         * LayoutReloaded/misc/LFC-passing-tests.txt:
1867
1868 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1869
1870         [LFC][BFC] Add support for block level replaced box.
1871         https://bugs.webkit.org/show_bug.cgi?id=194071
1872
1873         Reviewed by Antti Koivisto.
1874
1875         * LayoutReloaded/misc/LFC-passing-tests.txt:
1876
1877 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1878
1879         Fix WebKitTestRunner's testPath with Windows full paths
1880         https://bugs.webkit.org/show_bug.cgi?id=194012
1881
1882         Reviewed by Alex Christensen.
1883
1884         updateTestOptionsFromTestHeader failed to open test files because
1885         testPath returned wrong file paths. It returned a path "/C:/..."
1886         if a URL "file:///C:/..." was given.
1887
1888         * WebKitTestRunner/TestController.cpp:
1889         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1890
1891 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1892
1893         [WPE] Bump font related dependencies to match the GTK+ port
1894         https://bugs.webkit.org/show_bug.cgi?id=194017
1895
1896         Reviewed by Žan Doberšek.
1897
1898         * wpe/jhbuild.modules:
1899         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1900         * wpe/patches/icudata-stdlibs.patch: Added.
1901
1902 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1903
1904         Enable swipe tests on iOS
1905         https://bugs.webkit.org/show_bug.cgi?id=194076
1906
1907         Reviewed by Geoffrey Garen.
1908
1909         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1910         it causes a debug assertion failure in runUIScript.
1911
1912         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1913         (WTR::UIScriptController::beginBackSwipe):
1914         (WTR::UIScriptController::completeBackSwipe):
1915
1916 2019-01-30  Keith Rollin  <krollin@apple.com>
1917
1918         Use correct printf format specifier
1919         https://bugs.webkit.org/show_bug.cgi?id=194062
1920         <rdar://problem/47686167>
1921
1922         Reviewed by Alexey Proskuryakov.
1923
1924         LayoutTestSpellChecker.mm is trying to format a variable of type
1925         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1926         actually an unsigned long long. Fix this by formatting with %llu.
1927
1928         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1929         (-[LayoutTestTextCheckingResult description]):
1930
1931 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1932
1933         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1934         https://bugs.webkit.org/show_bug.cgi?id=193979
1935
1936         Reviewed by Wenson Hsieh.
1937
1938         Fix the test for iOS. Make the test work with iOS UA string.
1939
1940         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1941
1942 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1943
1944         Replace High Sierra LLINT CLoop bot due to hardware failure
1945         https://bugs.webkit.org/show_bug.cgi?id=194066
1946
1947         Reviewed by Aakash Jain.
1948
1949         * BuildSlaveSupport/build.webkit.org-config/config.json:
1950
1951 2019-01-30  Keith Rollin  <krollin@apple.com>
1952
1953         [NSDragItem init] is unavailable
1954         https://bugs.webkit.org/show_bug.cgi?id=194059
1955         <rdar://problem/47685715>
1956
1957         Reviewed by Wenson Hsieh.
1958
1959         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1960         DumpRenderTree and TestWebKitAPI, which both try to create an
1961         NSDragItem in a manner that invokes this method. Address this by using
1962         -initWithPasteboardWriter instead.
1963
1964         Note that the parameter passed to initWithPasteboardWriter is likely
1965         incorrect. In both cases, the object passed does not conform to
1966         NSPasteboardWriting. However, with this fix, we're no worse off than
1967         before, and can now perform builds with newer compilers and SDKs until
1968         a real fix can be crafted. That work is tracked in
1969         https://bugs.webkit.org/show_bug.cgi?id=194060
1970
1971         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1972         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1973         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1974         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1975
1976 2019-01-30  Daniel Bates  <dabates@apple.com>
1977
1978         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1979         https://bugs.webkit.org/show_bug.cgi?id=192824
1980         <rdar://problem/47100332>
1981
1982         Reviewed by Wenson Hsieh.
1983
1984         Fix a bug where the wrong usage code was used for F13 thru F24.
1985
1986         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1987         (keyCodeForDOMFunctionKey):
1988
1989 2019-01-30  Chris Dumez  <cdumez@apple.com>
1990
1991         Regression(PSON) Load hang can occur on history navigation
1992         https://bugs.webkit.org/show_bug.cgi?id=194030
1993         <rdar://problem/47656939>
1994
1995         Reviewed by Antti Koivisto.
1996
1997         Add API test coverage.
1998
1999         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2000
2001 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2002
2003         [LFC] Expand tests coverage.
2004
2005         Unreviewed test gardening.
2006
2007         * LayoutReloaded/misc/LFC-passing-tests.txt:
2008
2009 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2010
2011         [Flatpak] Add openjpeg support
2012         https://bugs.webkit.org/show_bug.cgi?id=194019
2013
2014         Reviewed by Michael Catanzaro.
2015
2016         * flatpak/org.webkit.CommonModules.yaml:
2017
2018 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2019
2020         Unreviewed, rolling out r240708.
2021         https://bugs.webkit.org/show_bug.cgi?id=194022
2022
2023         It broke WPE build (Requested by KaL on #webkit).
2024
2025         Reverted changeset:
2026
2027         "[WPE] Bump font related dependencies to match the GTK+ port"
2028         https://bugs.webkit.org/show_bug.cgi?id=194017
2029         https://trac.webkit.org/changeset/240708
2030
2031 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2032
2033         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2034         https://bugs.webkit.org/show_bug.cgi?id=194001
2035
2036         Reviewed by Antti Koivisto.
2037
2038         * LayoutReloaded/misc/LFC-passing-tests.txt:
2039
2040 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2041
2042         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2043         https://bugs.webkit.org/show_bug.cgi?id=194020
2044
2045         Reviewed by Antti Koivisto.
2046
2047         * LayoutReloaded/misc/LFC-passing-tests.txt:
2048
2049 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2050
2051         AX: Support color well on iOS
2052         https://bugs.webkit.org/show_bug.cgi?id=194010
2053
2054         Reviewed by Joanmarie Diggs.
2055
2056         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2057         (WTR::AccessibilityUIElement::stringAttributeValue):
2058
2059 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2060
2061         [WPE] Bump font related dependencies to match the GTK+ port
2062         https://bugs.webkit.org/show_bug.cgi?id=194017
2063
2064         Reviewed by Žan Doberšek.
2065
2066         * wpe/jhbuild.modules:
2067         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2068         * wpe/patches/icudata-stdlibs.patch: Added.
2069
2070 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2071
2072         [Mac] Update window scale API usage
2073         https://bugs.webkit.org/show_bug.cgi?id=193991
2074         rdar://problem/47614795
2075
2076         Reviewed by Tim Horton.
2077
2078         * DumpRenderTree/mac/DumpRenderTree.mm:
2079         (changeWindowScaleIfNeeded):
2080         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2081         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2082         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2083
2084 2019-01-29  Chris Dumez  <cdumez@apple.com>
2085
2086         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2087         https://bugs.webkit.org/show_bug.cgi?id=193977
2088         <rdar://problem/47643716>
2089
2090         Reviewed by Geoff Garen.
2091
2092         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2093         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2094         to the previous provisional committing *before* we make the last load. 
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2097
2098 2019-01-29  Youenn Fablet  <youenn@apple.com>
2099
2100         Adopt new SPI to evaluate server certificate trust
2101         https://bugs.webkit.org/show_bug.cgi?id=193355
2102
2103         Reviewed by Alex Christensen.
2104
2105         Add infrastructure to handle HTTPS server trust evaluation testing.
2106
2107         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2108         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2109         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2110         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2111         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2112         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::resetPreferencesToConsistentValues):
2115         (WTR::TestController::didReceiveAuthenticationChallenge):
2116         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2117         * WebKitTestRunner/TestController.h:
2118         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2119         * WebKitTestRunner/TestInvocation.cpp:
2120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2122         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2123
2124 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2125
2126         [ews-build] Add build step to print bot Configuration
2127         https://bugs.webkit.org/show_bug.cgi?id=193887
2128
2129         Reviewed by Lucas Forschler.
2130
2131         * BuildSlaveSupport/ews-build/steps.py:
2132         (PrintConfiguration): Build step to print configuration.
2133         * BuildSlaveSupport/ews-build/factories.py:
2134
2135 2019-01-29  Chris Dumez  <cdumez@apple.com>
2136
2137         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2138         https://bugs.webkit.org/show_bug.cgi?id=193967
2139         <rdar://problem/47635348>
2140
2141         Reviewed by Alex Christensen.
2142
2143         Add API test coverage.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2146         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2147
2148 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2149
2150         [ews-app] Handle incoming results data
2151         https://bugs.webkit.org/show_bug.cgi?id=193973
2152
2153         Reviewed by Lucas Forschler.
2154
2155         * BuildSlaveSupport/ews-app/ews/views/results.py:
2156
2157 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2158
2159         [ews-app] Make the results url generic
2160         https://bugs.webkit.org/show_bug.cgi?id=193928
2161
2162         Reviewed by Lucas Forschler.
2163
2164         * BuildSlaveSupport/ews-app/ews/urls.py:
2165
2166 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-build] Configure buildbot to send events to ews-app
2169         https://bugs.webkit.org/show_bug.cgi?id=193968
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-build/events.py: Added.
2174         * BuildSlaveSupport/ews-build/master.cfg:
2175
2176 2019-01-29  Keith Rollin  <krollin@apple.com>
2177
2178         Add .xcfilelists to Run Script build phases
2179         https://bugs.webkit.org/show_bug.cgi?id=193792
2180         <rdar://problem/47201785>
2181
2182         Reviewed by Alex Christensen.
2183
2184         As part of supporting XCBuild, update the necessary Run Script build
2185         phases in their Xcode projects to refer to their associated
2186         .xcfilelist files.
2187
2188         Note that the addition of these files bumps the Xcode project version
2189         number to something that's Xcode 10 compatible. This change means that
2190         older versions of the Xcode IDE can't read these projects. Nor can it
2191         fully load workspaces that refer to these projects (the updated
2192         projects are shown as non-expandable placeholders). `xcodebuild` can
2193         still build these projects; it's just that the IDE can't open them.
2194
2195         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2196         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2197
2198 2019-01-29  John Wilander  <wilander@apple.com>
2199
2200         Add data abstraction and validation for Ad Click Attribution
2201         https://bugs.webkit.org/show_bug.cgi?id=193916
2202         <rdar://problem/47603481>
2203
2204         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2205
2206         Ad click attribution has two steps. First, the storage of an ad
2207         campaign ID for a click that takes the user to a destination
2208         site. Second, a conversion on the destination site that can be
2209         attributed to the ad click.
2210
2211         This patch adds a class that represents a request for ad click
2212         attribution. Validation makes sure that the bits of entropy
2213         reported through this mechanism is limited.
2214
2215         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2216         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2217         (TestWebKitAPI::TEST):
2218
2219 2019-01-29  Chris Dumez  <cdumez@apple.com>
2220
2221         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2222         https://bugs.webkit.org/show_bug.cgi?id=193932
2223         <rdar://problem/47598947>
2224
2225         Reviewed by Brady Eidson.
2226
2227         Add API test coverage.
2228
2229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2230
2231 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2232
2233         Adding new passing LFC tests.
2234
2235         Unreviewed test gardening.
2236
2237         * LayoutReloaded/misc/LFC-passing-tests.txt:
2238
2239 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2240
2241         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2242         https://bugs.webkit.org/show_bug.cgi?id=193964
2243
2244         Reviewed by Antti Koivisto.
2245
2246         * LayoutReloaded/misc/LFC-passing-tests.txt:
2247
2248 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2249
2250         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2251         https://bugs.webkit.org/show_bug.cgi?id=193954
2252
2253         Reviewed by Antti Koivisto.
2254
2255         * LayoutReloaded/misc/LFC-passing-tests.txt:
2256
2257 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2258
2259         WebDriver: add support for running subtests
2260         https://bugs.webkit.org/show_bug.cgi?id=193904
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         pytest already supports it by passing test.py::subtest, so we can do the same.
2265
2266         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2267         (get_item_name): Made this global.
2268         (CollectRecorder.__init__): Receive the parameter to ignore.
2269         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2270         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2271         (collect): Add parameter to ignore.
2272         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2273         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2274         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2275         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2276         (WebDriverTestRunnerSelenium.run): Ditto.
2277         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2278         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2279         (WebDriverTestRunnerW3C.run): Ditto.
2280
2281 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2282
2283         User agent string override for navigator.userAgent should be site specific quirks
2284         https://bugs.webkit.org/show_bug.cgi?id=193950
2285
2286         Reviewed by Brent Fulgham.
2287
2288         Updated per the _WKWebsitePolicies rename.
2289
2290         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2291         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2292
2293 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2294
2295         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2296         https://bugs.webkit.org/show_bug.cgi?id=193941
2297
2298         Reviewed by Alex Christensen.
2299
2300         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2301         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2302         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2303         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2304         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2305         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2306         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2307         * TestWebKitAPI/Tests/WTF/Time.cpp:
2308         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2309         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2310         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2311         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2312
2313 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2314
2315         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2316
2317         * Scripts/webkitpy/common/config/contributors.json:
2318
2319 2019-01-28  Andy Estes  <aestes@apple.com>
2320
2321         [watchOS] Enable Parental Controls content filtering
2322         https://bugs.webkit.org/show_bug.cgi?id=193939
2323         <rdar://problem/46641912>
2324
2325         Reviewed by Ryosuke Niwa.
2326
2327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2328
2329 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2330
2331         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2332         <https://webkit.org/b/193884>
2333
2334         Reviewed by Jiewen Tan.
2335
2336         * Scripts/webkitpy/style/checkers/cpp.py:
2337         (check_language): Add LocalAuthentication to
2338         `frameworks_with_soft_links`.
2339
2340 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2341
2342         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2343         https://bugs.webkit.org/show_bug.cgi?id=193891
2344
2345         Reviewed by Ross Kirsling.
2346
2347         There were three problems in window sizes of WebView and the host window.
2348         1. The sizes of pixel image output were incorrect.
2349         2. The host window is going to appear after window.resize was invoked.
2350         3. window.resize resized only the host window, not WebView.
2351
2352         This change solves them with a following approach.
2353         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2354         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2355            as well as DumpRenderTree in order to match the client area and the window area.
2356         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2357         d. PlatformWebView::setWindowFrame changes both window sizes.
2358         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2359
2360         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2361         (WTR::PlatformWebView::PlatformWebView): Create the host window
2362         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2363         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2364         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2365
2366 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2367
2368         [ews-app] Add method to save Step data to database
2369         https://bugs.webkit.org/show_bug.cgi?id=193890
2370
2371         Reviewed by Lucas Forschler.
2372
2373         * BuildSlaveSupport/ews-app/ews/models/step.py:
2374         (Step.save_step): Method to save step data.
2375         (Step.update_step): Method to update step data.
2376         (Step.get_existing_step): Method to fetch existing step from database.
2377         (Step.is_valid_result): Method to validate valid step result.
2378
2379 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Add method to save Build data to database
2382         https://bugs.webkit.org/show_bug.cgi?id=193735
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-app/ews/models/build.py:
2387         (Build.save_build): Method to save build information to database.
2388         (Build.get_existing_build): Method to fetch existing build from database.
2389         (Build.is_valid_result): Method to validate build result.
2390         * BuildSlaveSupport/ews-app/ews/common/util.py:
2391         (is_valid_int_id): Method to validate valid id.
2392
2393 2019-01-28  Chris Dumez  <cdumez@apple.com>
2394
2395         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2396         https://bugs.webkit.org/show_bug.cgi?id=193915
2397         <rdar://problem/47560907>
2398
2399         Reviewed by Alex Christensen.
2400
2401         Add API test coverage.
2402
2403         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2404
2405 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2406
2407         [ews-app] Rename id variables
2408         https://bugs.webkit.org/show_bug.cgi?id=193883
2409
2410         Reviewed by Lucas Forschler.
2411
2412         * BuildSlaveSupport/ews-app/ews/models/build.py:
2413         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2414         * BuildSlaveSupport/ews-app/ews/models/step.py:
2415         * BuildSlaveSupport/ews-app/ews/urls.py:
2416         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2417         * BuildSlaveSupport/ews-app/ews/views/results.py:
2418         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2419
2420 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2421
2422         [ews-app] Allow certain fields to be empty
2423         https://bugs.webkit.org/show_bug.cgi?id=193892
2424
2425         Reviewed by Lucas Forschler.
2426
2427         * BuildSlaveSupport/ews-app/ews/models/build.py:
2428         * BuildSlaveSupport/ews-app/ews/models/step.py:
2429
2430 2019-01-28  Rob Buis  <rbuis@igalia.com>
2431
2432         Update MIME type parser
2433         https://bugs.webkit.org/show_bug.cgi?id=180526
2434
2435         Reviewed by Frédéric Wang.
2436
2437         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2438         (TestWebKitAPI::TEST):
2439
2440 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2441
2442         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2443         https://bugs.webkit.org/show_bug.cgi?id=193896
2444
2445         Reviewed by Antti Koivisto.
2446
2447         * LayoutReloaded/misc/LFC-passing-tests.txt:
2448
2449 2018-12-15  Darin Adler  <darin@apple.com>
2450
2451         Replace many uses of String::format with more type-safe alternatives
2452         https://bugs.webkit.org/show_bug.cgi?id=192742
2453
2454         Reviewed by Mark Lam.
2455
2456         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2457         (WTR::cacheTestRunnerCallback): Use makeString.
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2460         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2461
2462 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2463
2464         Use a load optimizer for some sites
2465         https://bugs.webkit.org/show_bug.cgi?id=193881
2466         <rdar://problem/46325455>
2467
2468         Reviewed by Brent Fulgham.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2471         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2472
2473 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2474
2475         AX: Introduce a static accessibility tree
2476         https://bugs.webkit.org/show_bug.cgi?id=193348
2477         <rdar://problem/47203295>
2478
2479         Reviewed by Ryosuke Niwa.
2480
2481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2482
2483 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2484
2485         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2486         https://bugs.webkit.org/show_bug.cgi?id=193867
2487
2488         Reviewed by Antti Koivisto.
2489
2490         * LayoutReloaded/misc/LFC-passing-tests.txt:
2491
2492 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2493
2494         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2495         https://bugs.webkit.org/show_bug.cgi?id=193865
2496
2497         Reviewed by Antti Koivisto.
2498
2499         * LayoutReloaded/misc/LFC-passing-tests.txt:
2500
2501 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         Need a mechanism to override navigator.userAgent
2504         https://bugs.webkit.org/show_bug.cgi?id=193762
2505         <rdar://problem/47504939>
2506
2507         Reviewed by Brent Fulgham.
2508
2509         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2512         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2513         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2514
2515 2019-01-25  Dean Jackson  <dino@apple.com>
2516
2517         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2518         https://bugs.webkit.org/show_bug.cgi?id=193831
2519         <rdar://problem/47399263>
2520
2521         Reviewed by Chris Dumez.
2522
2523         Two new tests that exercise cross-origin and same-origin System
2524         Previews.
2525
2526         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2527
2528 2019-01-25  Keith Rollin  <krollin@apple.com>
2529
2530         Update Xcode projects with "Check .xcfilelists" build phase
2531         https://bugs.webkit.org/show_bug.cgi?id=193790
2532         <rdar://problem/47201374>
2533
2534         Reviewed by Alex Christensen.
2535
2536         Support for XCBuild includes specifying inputs and outputs to various
2537         Run Script build phases. These inputs and outputs are specified as
2538         .xcfilelist files. Once created, these .xcfilelist files need to be
2539         kept up-to-date. In order to check that they are up-to-date or not,
2540         add an Xcode build step that invokes an external script that performs
2541         the checking. If the .xcfilelists are found to be out-of-date, update
2542         them, halt the build, and instruct the developer to restart the build
2543         with up-to-date files.
2544
2545         At this time, the checking and regenerating is performed only if the
2546         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2547         who want to use this facility can set this variable and test out the
2548         checking/regenerating. Once it seems like there are no egregious
2549         issues that upset a developer's workflow, we'll unconditionally enable
2550         this facility.
2551
2552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2553         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2554         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2555         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2556
2557 2019-01-25  Keith Rollin  <krollin@apple.com>
2558
2559         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2560         https://bugs.webkit.org/show_bug.cgi?id=193781
2561         <rdar://problem/47201153>
2562
2563         Reviewed by Alex Christensen.
2564
2565         Part of generating the .xcfilelists used as part of adopting XCBuild
2566         includes running `make DerivedSources.make` from a standalone script.
2567         It’s important for this invocation to have the same environment as
2568         when the actual build invokes `make DerivedSources.make`. If the
2569         environments are different, then the two invocations will provide
2570         different results. In order to get the same environment in the
2571         standalone script, have the script launch xcodebuild targeting the
2572         "Apply Configuration to XCFileLists" build target, which will then
2573         re-invoke our standalone script. The script is now running again, this
2574         time in an environment with all workspace, project, target, xcconfig
2575         and other environment variables established.
2576
2577         The "Apply Configuration to XCFileLists" build target accomplishes
2578         this task via a small embedded shell script that consists only of:
2579
2580             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2581
2582         The process that invokes "Apply Configuration to XCFileLists" first
2583         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2584         evaluated and exports it into the shell environment. When xcodebuild
2585         is invoked, it inherits the value of this variable and can `eval` the
2586         contents of that variable. Our external standalone script can then set
2587         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2588         of command-line parameters needed to restart itself in the appropriate
2589         state.
2590
2591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2592         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2593
2594 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2595
2596         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2597         https://bugs.webkit.org/show_bug.cgi?id=193802
2598         <rdar://problem/46010580>
2599
2600         Reviewed by Andy Estes.
2601
2602         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2603         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2604         (TEST):
2605
2606 2019-01-25  Daniel Bates  <dabates@apple.com>
2607
2608         [iOS] uiController.keyDown() does not translate Control modified key
2609         https://bugs.webkit.org/show_bug.cgi?id=192898
2610
2611         Reviewed by Wenson Hsieh.
2612
2613         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2614         key translation, as applicable. Among other cases, key translation occurs when performing
2615         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2616         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2617         human pressing down and releasing key(s) using a hardware keyboard.
2618
2619         * WebKitTestRunner/ios/HIDEventGenerator.h:
2620         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2621         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2622
2623         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2624         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2625         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2626         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2627         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2628         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2629         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2630         (-[HIDEventGenerator longPress:completionBlock:]):
2631         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2632         Update code for above renaming.
2633
2634         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2635         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2636
2637         (-[HIDEventGenerator keyDown:]): Added.
2638         (-[HIDEventGenerator keyUp:]): Added.
2639         (-[HIDEventGenerator keyPress:completionBlock:]):
2640         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2641         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2642         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2643         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2644         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2645         (WTR::parseModifier): Deleted.
2646
2647 2019-01-25  Keith Rollin  <krollin@apple.com>
2648
2649         Complete the implementation of generate-xcfilelists
2650         https://bugs.webkit.org/show_bug.cgi?id=193782
2651
2652         Reviewed by Alex Christensen.
2653
2654         A preliminary version of generate-xcfilelists was added in r238008.
2655         This patch updates that script in order to:
2656
2657         - Support checking of .xcfilelists
2658         - Perform better execution of `make DerivedSources.make` by
2659           relaunching generate-xcfilelists under xcodebuild
2660         - Support incremental generation and checking of .xcfilelists
2661         - Support supplementary .xcfilelists files from WebKitAdditions
2662         - Support being wrapped by parallel version of generate-xcfilelists in
2663           Internal that adds support for (re)generating WebKit projects in
2664           that repo.
2665         - Support builds that have been performed in WebKitBuild as well as
2666           ~/Library/Developer/code/DerivedData
2667         - Increase robustness and debugging facilities.
2668
2669         * Scripts/generate-xcfilelists:
2670
2671 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2672
2673         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2674         https://bugs.webkit.org/show_bug.cgi?id=193297
2675         <rdar://problem/47158841>
2676
2677         Unreviewed test case fix.
2678
2679         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2680         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2683         (TEST):
2684
2685 2019-01-25  Keith Rollin  <krollin@apple.com>
2686
2687         Update existing .xcfilelists
2688         https://bugs.webkit.org/show_bug.cgi?id=193791
2689         <rdar://problem/47201706>
2690
2691         Reviewed by Alex Christensen.
2692
2693         Many .xcfilelist files were added in r238824 in order to support
2694         XCBuild. Update these with recent changes to the set of build files
2695         and with the current generate-xcfilelist script.
2696
2697         * DumpRenderTree/DerivedSources-input.xcfilelist:
2698         * DumpRenderTree/DerivedSources-output.xcfilelist:
2699         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2700         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2701
2702 2019-01-25  Keith Rollin  <krollin@apple.com>
2703
2704         Fix missing dependencies in extract-dependencies-from-makefile
2705         https://bugs.webkit.org/show_bug.cgi?id=193783
2706         <rdar://problem/47201571>
2707
2708         Reviewed by Alex Christensen.
2709
2710         The extract-dependencies-from-makefile script generates .xcfilelists
2711         for XCBuild by invoking a makefile in --debug mode, parsing the
2712         dependency information in the output, and extracting information
2713         regarding targets and dependents. However, the way `make` emits this
2714         dependency information is not rigorous, and so we need to determine
2715         what lines to look for and parse by trial and error. This approach
2716         didn't coriginally atch all the information we needed to collect, so
2717         update the script to look for the additional lines we now know to look
2718         for.
2719
2720         * Scripts/extract-dependencies-from-makefile:
2721         (Parser):
2722         (Parser.addTarget):
2723         (Parser.addPrereq):
2724         (Parser.doParse):
2725
2726 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2727
2728         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2729         https://bugs.webkit.org/show_bug.cgi?id=193297
2730         <rdar://problem/47158841>
2731
2732         Reviewed by Alex Christensen.
2733
2734         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2735             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2737         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2738         activating the message used to trigger the callback when it is set.
2739
2740 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2741
2742         WKWebView.goBack should reload if there is a safe browsing warning
2743         https://bugs.webkit.org/show_bug.cgi?id=193805
2744         <rdar://problem/46908216>
2745
2746         Reviewed by Geoff Garen.
2747
2748         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2749         (+[Simple3LookupContext sharedLookupContext]):
2750         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2751         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2752         (TEST):
2753
2754 2019-01-25  Chris Dumez  <cdumez@apple.com>
2755
2756         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2757         https://bugs.webkit.org/show_bug.cgi?id=193788
2758         <rdar://problem/47531231>
2759
2760         Reviewed by Alex Christensen.
2761
2762         Add API test coverage.
2763
2764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2765         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2766
2767 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2768
2769         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2770         https://bugs.webkit.org/show_bug.cgi?id=193771
2771
2772         Unreviewed infrastructure fix.
2773
2774         * Scripts/webkitpy/port/darwin.py:
2775         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2776
2777 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2778
2779         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2780
2781 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2782
2783         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2784
2785         * Scripts/webkitpy/common/config/contributors.json:
2786
2787 2019-01-25  Chris Dumez  <cdumez@apple.com>
2788
2789         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2790         https://bugs.webkit.org/show_bug.cgi?id=193779
2791         <rdar://problem/46170903>
2792
2793         Reviewed by Antti Koivisto.
2794
2795         Add API test that quickly navigates forward to a previous process without waiting for it to
2796         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2797         the process' previous page when reconnecting the it for the forward navigation.
2798
2799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2800
2801 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2802
2803         Need a way for JavaScript (or bundle) code to participate in undo
2804         https://bugs.webkit.org/show_bug.cgi?id=190009
2805         <rdar://problem/44807048>
2806
2807         Reviewed by Ryosuke Niwa.
2808
2809         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2810         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2811
2812         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2813         (WTR::UIScriptController::lastUndoLabel const):
2814         (WTR::UIScriptController::firstRedoLabel const):
2815         (WTR::UIScriptController::platformUndoManager const):
2816         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2817         (WTR::UIScriptController::lastUndoLabel const):
2818         (WTR::UIScriptController::firstRedoLabel const):
2819         (WTR::UIScriptController::platformUndoManager const):
2820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2822         (WTR::UIScriptController::lastUndoLabel const):
2823         (WTR::UIScriptController::firstRedoLabel const):
2824         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2825         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2826         (WTR::UIScriptController::lastUndoLabel const):
2827         (WTR::UIScriptController::firstRedoLabel const):
2828         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2829         (WTR::UIScriptController::platformUndoManager const):
2830         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2831         (WTR::UIScriptController::platformUndoManager const):
2832
2833 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2834
2835         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2836         https://bugs.webkit.org/show_bug.cgi?id=193824
2837
2838         Reviewed by Antti Koivisto.
2839
2840         * LayoutReloaded/misc/LFC-passing-tests.txt:
2841
2842 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2843
2844         Update macOS JSC bot configurations
2845         https://bugs.webkit.org/show_bug.cgi?id=193739
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2851         (BubbleQueueServer): Move JSC EWS to Mojave section.
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2853         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2854         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2855
2856 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2857
2858         [Win][WebKitTestRunner] Implement EventSenderProxy
2859         https://bugs.webkit.org/show_bug.cgi?id=193755
2860
2861         Reviewed by Don Olmstead.
2862
2863         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2864         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2865         (WTR::EventSenderProxy::dispatchMessage):
2866         (WTR::EventSenderProxy::EventSenderProxy):
2867         (WTR::EventSenderProxy::mouseDown):
2868         (WTR::EventSenderProxy::mouseUp):
2869         (WTR::EventSenderProxy::mouseMoveTo):
2870         (WTR::EventSenderProxy::mouseScrollBy):
2871         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2872
2873 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2874
2875         Unreviewed fix for API test failure after r240437.
2876
2877         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2878
2879         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2880
2881 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2882
2883         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2884         https://bugs.webkit.org/show_bug.cgi?id=193787
2885         <rdar://problem/47497634>
2886
2887         Reviewed by Alexey Proskuryakov.
2888
2889         * Scripts/webkitdirs.pm:
2890         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2891
2892 2019-01-24  Truitt Savell  <tsavell@apple.com>
2893
2894         Unreviewed, rolling out r240446.
2895
2896         Casued 5 API failures
2897
2898         Reverted changeset:
2899
2900         "Activate the WebResourceLoadStatisticsStore in the
2901         NetworkProcess and deactivate it in the UIProcess."
2902         https://bugs.webkit.org/show_bug.cgi?id=193297
2903         https://trac.webkit.org/changeset/240446
2904
2905 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2906
2907         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2908         https://bugs.webkit.org/show_bug.cgi?id=193741
2909         <rdar://problem/47135030>
2910
2911         Reviewed by Antti Koivisto and Simon Fraser.
2912
2913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2914         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2915         (TestWebKitAPI::TEST):
2916
2917 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2918
2919         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2920         https://bugs.webkit.org/show_bug.cgi?id=193297
2921         <rdar://problem/47158841>
2922
2923         Reviewed by Alex Christensen.
2924
2925         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2926         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2927         activating the message used to trigger the callback when it is set.
2928
2929 2019-01-24  John Wilander  <wilander@apple.com>
2930
2931         Add Ad Click Attribution as an internal/experimental feature
2932         https://bugs.webkit.org/show_bug.cgi?id=193685
2933         <rdar://problem/47450399>
2934
2935         Reviewed by Brent Fulgham.
2936
2937         Added test option adClickAttributionEnabled.
2938
2939         * DumpRenderTree/TestOptions.cpp:
2940         (TestOptions::TestOptions):
2941         * DumpRenderTree/TestOptions.h:
2942         * DumpRenderTree/mac/DumpRenderTree.mm:
2943         (setWebPreferencesForTestOptions):
2944
2945 2019-01-24  Antti Koivisto  <antti@apple.com>
2946
2947         [PSON] Flash on back navigation on Mac
2948         https://bugs.webkit.org/show_bug.cgi?id=193716
2949         <rdar://problem/47148458>
2950
2951         Reviewed by Chris Dumez.
2952
2953         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2954
2955         Closing of the previous page is delayed so waiting for didFinishNavigation is
2956         not sufficient to guarantee we have received all the messages. Wait for them.
2957
2958 2019-01-24  Chris Dumez  <cdumez@apple.com>
2959
2960         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2961         https://bugs.webkit.org/show_bug.cgi?id=193761
2962         <rdar://problem/47456405>
2963
2964         Reviewed by Alex Christensen.
2965
2966         Add API test coverage.
2967
2968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2969
2970 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2971
2972         webkitpy: Missing PID in crashlog name should not be fatal
2973         https://bugs.webkit.org/show_bug.cgi?id=193771
2974
2975         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2976         of raising an exception.
2977
2978         Reviewed by Lucas Forschler.
2979
2980         * Scripts/webkitpy/port/darwin.py:
2981         (DarwinPort._merge_crash_logs):
2982
2983 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2984
2985         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2986         https://bugs.webkit.org/show_bug.cgi?id=193746
2987
2988         Reviewed by Youenn Fablet.
2989
2990         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2991         so we'd best just not call it.
2992
2993         * Scripts/webkitpy/w3c/test_exporter.py:
2994         (WebPlatformTestExporter.create_branch_with_patch):
2995
2996 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2997
2998         Move FileSystem to WTF
2999         https://bugs.webkit.org/show_bug.cgi?id=193602
3000
3001         Reviewed by Yusuke Suzuki.
3002
3003         * DumpRenderTree/win/DumpRenderTree.cpp:
3004         * TestWebKitAPI/CMakeLists.txt:
3005         * TestWebKitAPI/PlatformGTK.cmake:
3006         * TestWebKitAPI/PlatformJSCOnly.cmake:
3007         * TestWebKitAPI/PlatformPlayStation.cmake:
3008         * TestWebKitAPI/PlatformWPE.cmake:
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3011         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3012         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3013         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3014         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3015         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3016         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3017         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3018         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3019
3020 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3021
3022         [WPE] Remove hard dependency on subprocess32 for the API tests
3023
3024         Rubber-stamped by Carlos Garcia Campos.
3025
3026         * glib/api_test_runner.py:
3027         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3028         its presence only when running WPEQt tests.
3029
3030 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3031
3032         [GLIB] Expose JavaScriptCore options in GLib public API
3033         https://bugs.webkit.org/show_bug.cgi?id=188742
3034
3035         Reviewed by Michael Catanzaro.
3036
3037         Add a test for the new API.
3038
3039         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3040         (testsJSCOptions):
3041         (main):
3042
3043 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3044
3045         [GTK][WPE] Support JPEG 2000 images
3046         https://bugs.webkit.org/show_bug.cgi?id=186272
3047
3048         Reviewed by Žan Doberšek.
3049
3050         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3051
3052         * gtk/jhbuild.modules:
3053         * wpe/jhbuild.modules:
3054
3055 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3056
3057         check-webkit-style should warn when using soft-linking macros in a header
3058         <https://webkit.org/b/193750>
3059
3060         Reviewed by Darin Adler.
3061
3062         * Scripts/webkitpy/style/checkers/cpp.py:
3063         (check_language): Add softlink/header check by refactoring the
3064         softlink/framework check.
3065         (CppChecker): Enable softlink/header check by default.
3066         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3067         (CppStyleTest.test_softlink_framework): Rename from
3068         CppStyleTest.test_softlink() and change test framework name in
3069         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3070         files. Set file_name for macros that only appear in headers.
3071         (CppStyleTest.test_softlink_header): Add tests for using
3072         soft-link macros in headers.
3073
3074 2019-01-23  Chris Dumez  <cdumez@apple.com>
3075
3076         Deprecate API to limit the maximum number of WebProcesses
3077         https://bugs.webkit.org/show_bug.cgi?id=193725
3078         <rdar://problem/47464879>
3079
3080         Reviewed by Geoff Garen.
3081
3082         Update existing API tests to stop using deprecated API.
3083
3084         * MiniBrowser/mac/AppDelegate.m:
3085         (defaultConfiguration):
3086         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3087         (TestWebKitAPI::TEST):
3088         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3089         (TestWebKitAPI::TEST):
3090         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3091         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3092         (TEST):
3093         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3094         (TEST):
3095
3096 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3097
3098         [ews-app] Rename ews model buildermappings to buildermapping
3099         https://bugs.webkit.org/show_bug.cgi?id=193729
3100
3101         Reviewed by Lucas Forschler.
3102
3103         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3104         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3105         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3106
3107 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3108
3109         [ews-app] Rename ews model steps to step
3110         https://bugs.webkit.org/show_bug.cgi?id=193697
3111
3112         Reviewed by Lucas Forschler.
3113
3114         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3115         (Step): Renamed Steps to Step.
3116
3117 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3118
3119         Clean up IndexedDB files between tests
3120         https://bugs.webkit.org/show_bug.cgi?id=192796
3121         <rdar://problem/46824999>
3122
3123         Reviewed by Geoffrey Garen.
3124
3125         * DumpRenderTree/mac/DumpRenderTree.mm:
3126         (runTest):
3127         * WebKitTestRunner/TestController.cpp:
3128         (WTR::TestController::resetStateToConsistentValues):
3129         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3130         (WTR::RemoveAllIndexedDatabasesCallback):
3131         (WTR::TestController::ClearIndexedDatabases):
3132         * WebKitTestRunner/TestController.h:
3133         * WebKitTestRunner/TestInvocation.cpp:
3134         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3135
3136 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3137
3138         [ews-app] Rename ews model Builds to Build
3139         https://bugs.webkit.org/show_bug.cgi?id=193695
3140
3141         Reviewed by Lucas Forschler.
3142
3143         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3144         (Build): Renamed Builds to Build.
3145
3146 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3147
3148         webkitpy: Wait longer when launching WebKitTestRunner
3149         https://bugs.webkit.org/show_bug.cgi?id=193734
3150
3151         Reviewed by Aakash Jain.
3152
3153         * Scripts/webkitpy/port/simulator_process.py:
3154         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3155
3156 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3157
3158         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3159         https://bugs.webkit.org/show_bug.cgi?id=193182
3160         <rdar://problem/47452154>
3161
3162         Reviewed by Tim Horton.
3163
3164         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3165         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3166         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3167
3168         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3169         preventing later tests from recognizing gestures.
3170
3171         * WebKitTestRunner/ios/TestControllerIOS.mm:
3172         (WTR::TestController::platformResetStateToConsistentValues):
3173
3174         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3175
3176 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3177
3178         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3179         https://bugs.webkit.org/show_bug.cgi?id=193722
3180         <rdar://problem/47481475>
3181
3182         Reviewed by Lucas Forschler.
3183
3184         iPhone and iPad ports should both use the iOS config.
3185
3186         * Scripts/webkitpy/port/ios_simulator.py:
3187         (IPhoneSimulatorPort.__init__):
3188         (IPadSimulatorPort.__init__):
3189
3190 2019-01-23  Rob Buis  <rbuis@igalia.com>
3191
3192         Update MIME type parser
3193         https://bugs.webkit.org/show_bug.cgi?id=180526
3194
3195         Reviewed by Frédéric Wang.
3196
3197         Add unit tests for both parse modes of ParsedContentType.
3198
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3201         (TestWebKitAPI::TEST):
3202
3203 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3204
3205         [ews-app] fetch loop should not stop on network issues
3206         https://bugs.webkit.org/show_bug.cgi?id=193666
3207
3208         Reviewed by Lucas Forschler.
3209
3210         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3211         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3212
3213 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3216         https://bugs.webkit.org/show_bug.cgi?id=189165
3217         <rdar://problem/47433765>
3218
3219         Reviewed by Tim Horton.
3220
3221         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3222         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3223         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3224         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3225         would make its way to the UI process by the time the layer tree commit is finished.
3226
3227         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3228         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3229         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3230         will fail because it asks for -_autofillContext too early.
3231
3232         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3233         is handled in the UI process.
3234
3235         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3236
3237         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3238         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3239         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3240         input session.
3241
3242         (-[AutofillTestView textInputHasAutofillContext]):
3243
3244         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3245
3246         * TestWebKitAPI/cocoa/TestWKWebView.h:
3247         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3248         (nextInputSessionChangeCount):
3249
3250         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3251         This includes changing the focused element from one to another.
3252
3253         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3254         (-[TestWKWebView didStartFormControlInteraction]):
3255         (-[TestWKWebView didEndFormControlInteraction]):
3256         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3257
3258         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3259         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3260         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3261         that doesn't require an input session to one that doesn't.
3262
3263 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3264
3265         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3266         <https://webkit.org/b/193676>
3267
3268         Reviewed by Alexey Proskuryakov.
3269
3270         * Scripts/webkitpy/style/checkers/cpp.py:
3271         (check_member_initialization_list):
3272         - Don't report missing whitespace around colon if the colon at
3273           the start of the line is formatted correctly.
3274         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3275         (WebKitStyleTest.test_member_initialization_list):
3276         - Add a test for a missing permutation of existing tests.
3277         - Add a test this false-positive.
3278         - Add blank lines between subtests to make them easier to read.
3279
3280 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3281
3282         [build.webkit.org] Unit-test failure after r237113
3283         https://bugs.webkit.org/show_bug.cgi?id=193669
3284
3285         Reviewed by Michael Catanzaro.
3286
3287         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3288         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3289         multiple or zero flags.
3290
3291 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3292
3293         Cache bytecode to disk
3294         https://bugs.webkit.org/show_bug.cgi?id=192782
3295         <rdar://problem/46084932>
3296
3297         Reviewed by Keith Miller.
3298
3299         Add test helper to execute bytecode-cache tests: it executes each test
3300         twice, the first with JSC_diskCachePath set to a temporary directory
3301         and second with JSC_forceDiskCache=true (in addition to the cache path)
3302         to guarantee that only the disk cache is being used and no new
3303         UnlinkedCodeBlocks are being created.
3304
3305         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3306         * Scripts/run-jsc-stress-tests:
3307
3308 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3309
3310         [css-logical] Implement flow-relative margin, padding and border shorthands
3311         https://bugs.webkit.org/show_bug.cgi?id=188697
3312
3313         Reviewed by Simon Fraser and Antti Koivisto.
3314
3315         * DumpRenderTree/TestOptions.cpp:
3316         (TestOptions::TestOptions):
3317         * DumpRenderTree/TestOptions.h:
3318         * DumpRenderTree/mac/DumpRenderTree.mm:
3319         (setWebPreferencesForTestOptions):
3320         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3321
3322         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3323         (JSONCSSPropertiesChecker.check_codegen_properties):
3324         Allow CSS property definitions to have a 'runtime-flag' parameter which
3325         disables the property when the specified runtime flag is disabled.
3326
3327 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3328
3329         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3330         https://bugs.webkit.org/show_bug.cgi?id=193643
3331
3332         Reviewed by Michael Catanzaro.
3333
3334         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3335         * wpe/jhbuild.modules: Ditto.
3336
3337 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3338
3339         [LFC][Floats] Take float top position into account when computing containing block height.
3340         https://bugs.webkit.org/show_bug.cgi?id=193655
3341
3342         Reviewed by Antti Koivisto.
3343
3344         * LayoutReloaded/misc/LFC-passing-tests.txt:
3345
3346 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3347
3348         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3349         <https://webkit.org/b/193645>
3350         <rdar://problem/47421574>
3351
3352         Reviewed by Alex Christensen.
3353
3354         - Now checks for local soft-linking of all frameworks that have
3355           their own *SoftLinking.{cpp,h,mm} files.
3356         - Changes softlink/uikit warning to softlink/framework.
3357
3358         * Scripts/webkitpy/style/checkers/cpp.py:
3359         (check_language):
3360         (CppChecker):
3361         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3362         (CppStyleTest):
3363
3364 2019-01-20  Saam Barati  <sbarati@apple.com>
3365
3366         Rollout r240210: It broke tests on iOS
3367         https://bugs.webkit.org/show_bug.cgi?id=193640
3368
3369         Unreviewed.
3370
3371         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3372         * Scripts/run-jsc-stress-tests:
3373
3374 2019-01-20  chris fleizach  <cfleizach@apple.com>
3375
3376         AX: Support returning relative frames for accessibility
3377         https://bugs.webkit.org/show_bug.cgi?id=193414
3378         <rdar://problem/47268501>
3379
3380         Reviewed by Zalan Bujtas.
3381
3382         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3383         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3384         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3385         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3386         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3387         (WTR::attributesOfElement):
3388         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3389
3390 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3391
3392         Unreviewed, add my new email address
3393
3394         * Scripts/webkitpy/common/config/contributors.json:
3395
3396 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3397
3398         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3399         https://bugs.webkit.org/show_bug.cgi?id=193617
3400
3401         Reviewed by Antti Koivisto.
3402
3403         * LayoutReloaded/misc/LFC-passing-tests.txt:
3404
3405 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3406
3407         Unreviewed, rolling out r240209.
3408
3409         Broke GTK/WPE injected bundle
3410
3411         Reverted changeset:
3412
3413         "AX: Support returning relative frames for accessibility"
3414         https://bugs.webkit.org/show_bug.cgi?id=193414
3415         https://trac.webkit.org/changeset/240209
3416
3417 2019-01-12  Dan Bernstein  <mitz@apple.com>
3418
3419         [Cocoa] Avoid importing directly from subumbrella frameworks
3420         https://bugs.webkit.org/show_bug.cgi?id=186016
3421         <rdar://problem/40591038>
3422
3423         Reviewed by Sam Weinig.
3424
3425         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3426           LaunchServices header.
3427         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3428           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3429         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3430           when using SDKs earlier than 10.13.
3431         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3432           and OTHER_CPLUSPLUSFLAGS.
3433         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3434           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3435         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3436           LaunchServices header.
3437
3438 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3439
3440         Cache bytecode to disk
3441         https://bugs.webkit.org/show_bug.cgi?id=192782
3442         <rdar://problem/46084932>
3443
3444         Reviewed by Keith Miller.
3445
3446         Add test helper to execute bytecode-cache tests: it executes each test
3447         twice, the first with JSC_diskCachePath set to a temporary directory
3448         and second with JSC_forceDiskCache=true (in addition to the cache path)
3449         to guarantee that only the disk cache is being used and no new
3450         UnlinkedCodeBlocks are being created.
3451
3452         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3453         * Scripts/run-jsc-stress-tests:
3454
3455 2019-01-20  chris fleizach  <cfleizach@apple.com>
3456
3457         AX: Support returning relative frames for accessibility
3458         https://bugs.webkit.org/show_bug.cgi?id=193414
3459         <rdar://problem/47268501>
3460
3461         Reviewed by Zalan Bujtas.
3462
3463         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3464         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3465         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3466         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3467         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3468         (WTR::attributesOfElement):
3469         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3470
3471 2019-01-20  Antoine Quint  <graouts@apple.com>
3472
3473         Add a POINTER_EVENTS feature flag
3474         https://bugs.webkit.org/show_bug.cgi?id=193577
3475         <rdar://problem/47408511>
3476
3477         Unreviewed. Also enable Pointer Events for iosmac.
3478
3479         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3480
3481 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3482
3483         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3484         https://bugs.webkit.org/show_bug.cgi?id=193613
3485
3486         Reviewed by Antti Koivisto.
3487
3488         * LayoutReloaded/misc/LFC-passing-tests.txt:
3489
3490 2019-01-19  Antoine Quint  <graouts@apple.com>
3491
3492         Add a POINTER_EVENTS feature flag
3493         https://bugs.webkit.org/show_bug.cgi?id=193577
3494
3495         Reviewed by Dean Jackson.
3496
3497         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3498
3499 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3500
3501         Disable the run-jsc-stress-test remote host key check [second round].
3502         https://bugs.webkit.org/show_bug.cgi?id=192988
3503
3504         Reviewed by Dewei Zhu.
3505
3506         * Scripts/run-jsc-stress-tests:
3507
3508 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3509
3510         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3511         https://bugs.webkit.org/show_bug.cgi?id=193597
3512
3513         Reviewed by Lucas Forschler.
3514
3515         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3516
3517 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3518
3519         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3520         https://bugs.webkit.org/show_bug.cgi?id=193595
3521
3522         Reviewed by Lucas Forschler.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3525         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3526         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3527
3528 2019-01-18  Chris Dumez  <cdumez@apple.com>
3529
3530         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3531         https://bugs.webkit.org/show_bug.cgi?id=193588
3532         <rdar://problem/47131566>
3533
3534         Reviewed by Alex Christensen.
3535
3536         Add layout test coverage.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3539
3540 2019-01-18  Jer Noble  <jer.noble@apple.com>
3541
3542         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3543         https://bugs.webkit.org/show_bug.cgi?id=189553
3544
3545         Reviewed by Tim Horton.
3546
3547         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3548
3549         * ContentExtensionTester/Configurations/Base.xcconfig:
3550         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3551         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3552         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3553         * ImageDiff/cg/Configurations/Base.xcconfig:
3554         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3555         * MiniBrowser/Configurations/Base.xcconfig:
3556         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3557         * MobileMiniBrowser/Configurations/Base.xcconfig:
3558         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3559         * Scripts/webkitpy/style/checker.py:
3560         (_all_categories):
3561         (FileType):
3562         (CheckerDispatcher._file_type):
3563         (CheckerDispatcher._create_checker):
3564         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3565         (SDKVariantChecker):
3566         (SDKVariantChecker.__init__):
3567         (SDKVariantChecker.check):
3568         * TestWebKitAPI/Configurations/Base.xcconfig:
3569         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3570         * WebEditingTester/Configurations/Base.xcconfig:
3571         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3572         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3573         * WebKitTestRunner/Configurations/Base.xcconfig:
3574         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3575         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3576         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3577
3578 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3579
3580         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3581         <https://webkit.org/b/193568>
3582         <rdar://problem/47381130>
3583
3584         Reviewed by Alex Christensen.
3585
3586         Make sure no one re-introduces UIKit soft-linking by adding a
3587         style rule.
3588
3589         * Scripts/webkitpy/style/checkers/cpp.py:
3590         (check_language): Add softlink/uikit check.
3591         (CppChecker): Enable softlink/uikit check.
3592         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3593         (CppStyleTest): Add test for softlink/uikit.
3594
3595 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3596
3597         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3598         https://bugs.webkit.org/show_bug.cgi?id=193584
3599
3600         Change "-dev" to "-devel".
3601
3602         Reviewed by Michael Catanzaro.
3603
3604         * gtk/install-dependencies:
3605
3606 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3607
3608         webkitpy: Add iPhone and iPad ports
3609         https://bugs.webkit.org/show_bug.cgi?id=193537
3610         <rdar://problem/47353390>
3611
3612         Reviewed by Lucas Forschler.
3613
3614         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3615         ports. Note that this separation is optional, the --ios-simulator command remains.
3616
3617         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3618         (RunTest.test_device_type_test_division): Drive-by fix.
3619         (RunTest.test_device_type_specific_listing): Ditto.
3620         (RunTest.test_ipad_test_division):
3621         (RunTest):
3622         (RunTest.test_ipad_listing):
3623         * Scripts/webkitpy/port/factory.py:
3624         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3625         (PortFactory):
3626         * Scripts/webkitpy/port/ios_simulator.py:
3627         (IPhoneSimulatorPort):
3628         (IPadSimulatorPort):
3629
3630 2019-01-18  Chris Dumez  <cdumez@apple.com>
3631
3632         Regression(PSON) Scroll position is not always restored properly when navigating back
3633         https://bugs.webkit.org/show_bug.cgi?id=193578
3634         <rdar://problem/47386331>
3635
3636         Reviewed by Tim Horton.
3637
3638         Add API test coverage.
3639
3640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3641
3642 2019-01-18  Youenn Fablet  <youenn@apple.com>
3643
3644         Add a new SPI to request for cache storage quota increase
3645         https://bugs.webkit.org/show_bug.cgi?id=193323
3646
3647         Reviewed by Alex Christensen.
3648
3649         Implement WebsiteDataStore quota delegate to handle quota requests.
3650         By default, do not update quota.
3651         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3652
3653         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3654         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3655         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3656         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3657         * WebKitTestRunner/TestController.cpp:
3658         (WTR::TestController::allowCacheStorageQuotaIncrease):
3659         * WebKitTestRunner/TestController.h:
3660         * WebKitTestRunner/TestInvocation.cpp:
3661         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3662         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3663         (-[CacheStorageQuotaManager init]):
3664         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3665         (WTR::initializeWebViewConfiguration):
3666         (WTR::TestController::cocoaResetStateToConsistentValues):
3667         (WTR::TestController::allowCacheStorageQuotaIncrease):
3668
3669 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3670
3671         [ews-build] Pass owner to the triggered builds
3672         https://bugs.webkit.org/show_bug.cgi?id=193574
3673
3674         Reviewed by Lucas Forschler.
3675
3676         * BuildSlaveSupport/ews-build/factories.py:
3677         (BuildFactory.propertiesToPassToTriggers):
3678
3679 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3680
3681         [ews-app] Send patch author as a build property
3682         https://bugs.webkit.org/show_bug.cgi?id=193560
3683
3684         Reviewed by Lucas Forschler.
3685
3686         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3687         (BugzillaPatchFetcher.fetch):
3688
3689 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3690
3691         webkitpy: Implement device type specific expected results (Follow-up fix)
3692         https://bugs.webkit.org/show_bug.cgi?id=192162
3693         <rdar://problem/46345449>
3694
3695         Unreviewed infrastructure fix.
3696
3697         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3698         (Manager.run): Don't boot a device if no tests are available to run on it.
3699
3700 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3701
3702         webkitpy: Implement device type specific expected results (Follow-up fix)
3703         https://bugs.webkit.org/show_bug.cgi?id=192162
3704         <rdar://problem/46345449>
3705
3706         Unreviewed infrastructure fix.
3707
3708         * Scripts/webkitpy/api_tests/manager.py:
3709         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3710
3711 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3712
3713         webkitpy: Implement device type specific expected results (Part 2)
3714         https://bugs.webkit.org/show_bug.cgi?id=192162
3715         <rdar://problem/46345449>
3716
3717         Rubber-stamped by Aakash Jain.
3718
3719         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3720         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3721         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3722
3723         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3724         (LayoutTestFinder.find_tests): Pass device_type through.
3725         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3726         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3727         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3728         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3729         (Manager._collect_tests): Pass device type to test finder.
3730         (Manager._needs_web_platform_test):
3731         (Manager._prepare_lists): Index _expectations by device type.
3732         (Manager._test_input_for_file):
3733         (Manager._test_is_slow): Ditto.
3734         (Manager._test_should_dump_jsconsolelog_in_stderr):
3735         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3736         (Manager._get_test_inputs):
3737         (Manager._update_worker_count):
3738         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3739         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3740         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3741         the one which runs the test.
3742         (Manager._run_test_subset):
3743         (Manager._run_tests): Index _expectations by current_device_type.
3744         (Manager._print_expectation_line_for_test): Ditto.
3745         (Manager._print_expectations_for_subset): Ditto.
3746         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3747         Unlike run, this function will behave the same regardless of what devices are available.
3748         (Manager._custom_device_for_test): Deleted.
3749         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3750         (ManagerTest.test_uses_custom_device): Deleted.
3751         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3752         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3753         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3754         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3755         all of the expectations.
3756         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3757         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3758         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3759         (TestExpectations.__init__): Allow device_type to be passed through.
3760         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3761         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3762         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3763         (summarize_results):
3764         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3765         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3766         a test ran with, one must check all expectations to find the first non-skip expectation.
3767         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3768         (RunTest.test_device_type_test_division):
3769         (RunTest):
3770         (RunTest.test_device_type_specific_listing):
3771         * Scripts/webkitpy/port/base.py:
3772         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3773         (Port.supported_device_types): The result of this function will change based on what devices are available.
3774         * Scripts/webkitpy/port/device_port.py:
3775         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3776         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3777         can be used.
3778         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3779         any, or the DEFAULT_DEVICE_TYPES of the port.
3780         * Scripts/webkitpy/port/ios.py:
3781         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3782         * Scripts/webkitpy/port/ios_simulator.py:
3783         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3784         * Scripts/webkitpy/port/watch.py:
3785         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3786         * Scripts/webkitpy/port/watch_simulator.py:
3787         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3788         * Scripts/webkitpy/xcode/device_type.py:
3789         (DeviceType):
3790         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3791
3792 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3793
3794         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3795         https://bugs.webkit.org/show_bug.cgi?id=193575
3796
3797         Reviewed by Michael Catanzaro.
3798
3799         Allow the script to run without explicit port argument because
3800         it's specific to the WPE port anyway.
3801
3802         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3803         and simplify the rest of the code accordingly.
3804
3805 2019-01-18  Charlie Turner  <cturner@igalia.com>
3806
3807         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3808         https://bugs.webkit.org/show_bug.cgi?id=192229
3809
3810         Reviewed by Xabier Rodriguez-Calvar.
3811
3812         * MiniBrowser/wpe/main.cpp:
3813         (main): Enable encrypted-media by default.
3814
3815 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3816
3817         [Flatpak] Missing KeyboardInterrupt exception handler
3818         https://bugs.webkit.org/show_bug.cgi?id=193570
3819
3820         Reviewed by Michael Catanzaro.
3821
3822         * flatpak/flatpakutils.py:
3823         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3824
3825 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3826
3827         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3828         https://bugs.webkit.org/show_bug.cgi?id=193564
3829
3830         Reviewed by Antti Koivisto.
3831
3832         * LayoutReloaded/misc/LFC-passing-tests.txt:
3833
3834 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3835
3836         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3837         https://bugs.webkit.org/show_bug.cgi?id=193562
3838
3839         Reviewed by Antti Koivisto.
3840
3841         * LayoutReloaded/misc/LFC-passing-tests.txt:
3842
3843 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3844
3845         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3846         https://bugs.webkit.org/show_bug.cgi?id=193555
3847
3848         Reviewed by Antti Koivisto.
3849
3850         * LayoutReloaded/misc/LFC-passing-tests.txt:
3851
3852 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3853
3854         [WPE] Add Qt extension
3855         https://bugs.webkit.org/show_bug.cgi?id=191464
3856
3857         Reviewed by Carlos Garcia Campos.
3858
3859         MiniBrowser and API tests for the WPE Qt API. To run the
3860         MiniBrowser a new script is introduced. Example invocation:
3861
3862         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3863
3864         Also note-worthy is the introduction of the python2-subprocess32
3865         dependency to run the GLib API tests.
3866
3867         * MiniBrowser/wpe/CMakeLists.txt:
3868         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3869         * MiniBrowser/wpe/qt/main.cpp: Added.
3870         (main):
3871         * MiniBrowser/wpe/qt/main.qml: Added.
3872         * MiniBrowser/wpe/qt/qml.qrc: Added.
3873         * Scripts/run-gtk-tests:
3874         (GtkTestRunner.is_google_test):
3875         (GtkTestRunner):
3876         (GtkTestRunner.is_qt_test):
3877         * Scripts/run-qt-wpe-minibrowser: Added.
3878         * Scripts/run-wpe-tests:
3879         (WPETestRunner):
3880         (WPETestRunner.is_google_test):
3881         (WPETestRunner.is_qt_test):
3882         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3883         (TestLoad::main):
3884         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3885         (TestLoadHtml::main):
3886         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3887         (TestLoadRequest::main):
3888         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3889         (TestRunJavaScript::main):
3890         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3891         (waitForSignal):
3892         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3893         (LoadSpy::LoadSpy):
3894         (LoadSpy::~LoadSpy):
3895         (LoadSpy::onLoadingChanged):
3896         (LoadStartedCatcher::LoadStartedCatcher):
3897         (LoadStartedCatcher::~LoadStartedCatcher):
3898         (LoadStartedCatcher::onLoadingChanged):
3899         (waitForLoadSucceeded):
3900         (waitForLoadFailed):
3901         * TestWebKitAPI/glib/CMakeLists.txt:
3902         * flatpak/flatpakutils.py:
3903         (WebkitFlatpak.load_from_args):
3904         (WebkitFlatpak.__init__):
3905         (WebkitFlatpak.clean_args):
3906         (WebkitFlatpak.run_in_sandbox):
3907         * flatpak/org.webkit.CommonModules.yaml:
3908         * flatpak/org.webkit.WPE.yaml:
3909         * flatpak/org.webkit.WPEModules.yaml:
3910         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3911         * flatpak/org.webkit.WebKit.yaml:
3912         * glib/api_test_runner.py:
3913         (TestRunner._run_test_qt):
3914         (TestRunner.is_qt_test):
3915         (TestRunner._run_test):
3916
3917 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3918
3919         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3920         https://bugs.webkit.org/show_bug.cgi?id=193494
3921         <rdar://problem/46859627>
3922
3923         Reviewed by Simon Fraser and Tim Horton.
3924
3925         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3926         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3927
3928         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3929         (WTR::UIScriptController::contentOffsetX const):
3930         (WTR::UIScriptController::contentOffsetY const):
3931         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3932         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3933         (WTR::UIScriptController::contentOffsetX const):
3934         (WTR::UIScriptController::contentOffsetY const):
3935         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3936
3937         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3938
3939         * WebKitTestRunner/TestController.cpp:
3940         (WTR::updateTestOptionsFromTestHeader):
3941         * WebKitTestRunner/TestOptions.h:
3942         (WTR::TestOptions::hasSameInitializationOptions const):
3943         * WebKitTestRunner/ios/TestControllerIOS.mm:
3944         (WTR::TestController::platformResetStateToConsistentValues):
3945         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3946         (WTR::UIScriptController::contentOffsetX const):
3947         (WTR::UIScriptController::contentOffsetY const):
3948
3949 2019-01-17  Truitt Savell  <tsavell@apple.com>
3950
3951         Unreviewed, rolling out r240124.
3952
3953         This commit broke an internal build.
3954
3955         Reverted changeset:
3956
3957         "SDK_VARIANT build destinations should be separate from non-
3958         SDK_VARIANT builds"
3959         https://bugs.webkit.org/show_bug.cgi?id=189553
3960         https://trac.webkit.org/changeset/240124
3961
3962 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3963
3964         Fix string concatenation API test after r239920
3965         https://bugs.webkit.org/show_bug.cgi?id=193551
3966         <rdar://problem/47359304>
3967
3968         Reviewed by Youenn Fablet.
3969
3970         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3971         (TestWebKitAPI::TEST):
3972         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3973         in WebKit's build configuration like it apparently is on Linux.
3974
3975 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3976
3977         [ews-build] validate-patch should handle the case when bug_id is None
3978         https://bugs.webkit.org/show_bug.cgi?id=193547
3979
3980         Reviewed by Lucas Forschler.
3981
3982         * BuildSlaveSupport/ews-build/steps.py:
3983         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3984         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3985
3986 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3987
3988         [ews-build] Add patch author information in build
3989         https://bugs.webkit.org/show_bug.cgi?id=193465
3990
3991         Reviewed by Lucas Forschler.
3992
3993         * BuildSlaveSupport/ews-build/steps.py:
3994         (ValidatePatch._is_patch_obsolete):
3995
3996 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3997
3998         [ews-build] Pass bug_id to the triggered builds
3999         https://bugs.webkit.org/show_bug.cgi?id=193548
4000
4001         Reviewed by Lucas Forschler.
4002
4003         * BuildSlaveSupport/ews-build/factories.py:
4004         (BuildFactory.propertiesToPassToTriggers):
4005
4006 2019-01-17  Jer Noble  <jer.noble@apple.com>
4007
4008         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4009         https://bugs.webkit.org/show_bug.cgi?id=189553
4010
4011         Reviewed by Tim Horton.
4012
4013         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4014
4015         * ContentExtensionTester/Configurations/Base.xcconfig:
4016         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4017         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4018         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4019         * ImageDiff/cg/Configurations/Base.xcconfig:
4020         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4021         * MiniBrowser/Configurations/Base.xcconfig:
4022         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4023         * MobileMiniBrowser/Configurations/Base.xcconfig:
4024         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4025         * Scripts/webkitpy/style/checker.py:
4026         (_all_categories):
4027         (FileType):
4028         (CheckerDispatcher._file_type):
4029         (CheckerDispatcher._create_checker):
4030         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4031         (SDKVariantChecker):
4032         (SDKVariantChecker.__init__):
4033         (SDKVariantChecker.check):
4034         * TestWebKitAPI/Configurations/Base.xcconfig:
4035         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4036         * WebEditingTester/Configurations/Base.xcconfig:
4037         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4038         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4039         * WebKitTestRunner/Configurations/Base.xcconfig:
4040         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4041         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4042         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4043
4044 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4045
4046         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4047         https://bugs.webkit.org/show_bug.cgi?id=193534
4048
4049         Reviewed by Antti Koivisto.
4050
4051         * LayoutReloaded/misc/LFC-passing-tests.txt:
4052
4053 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4054
4055         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4056         https://bugs.webkit.org/show_bug.cgi?id=193528
4057
4058         Reviewed by Antti Koivisto.
4059
4060         * LayoutReloaded/misc/LFC-passing-tests.txt:
4061
4062 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4063
4064         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4065         https://bugs.webkit.org/show_bug.cgi?id=193520
4066
4067         Reviewed by Antti Koivisto.
4068
4069         * LayoutReloaded/misc/LFC-passing-tests.txt:
4070
4071 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4072
4073         [ews-build] unapply-patch step should not update source
4074         https://bugs.webkit.org/show_bug.cgi?id=193234
4075
4076         Reviewed by Lucas Forschler.
4077
4078         * BuildSlaveSupport/ews-build/steps.py:
4079         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4080         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4081
4082 2019-01-16  Youenn Fablet  <youenn@apple.com>
4083
4084         Add a new SPI for controlling getUserMedia
4085         https://bugs.webkit.org/show_bug.cgi?id=192793
4086
4087         Reviewed by Eric Carlson.
4088
4089         * MiniBrowser/mac/WK2BrowserWindowController.m:
4090         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4091         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4092         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4093         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4094         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4095         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4096         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4097         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4098         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4099         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4100         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4101         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4102         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4103         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4104
4105 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4106
4107         [LFC][BFC] Inflow non-replaced used width should not be negative.
4108         https://bugs.webkit.org/show_bug.cgi?id=193495
4109
4110         Reviewed by Antti Koivisto.
4111
4112         * LayoutReloaded/misc/LFC-passing-tests.txt:
4113
4114 2019-01-16  Chris Dumez  <cdumez@apple.com>
4115
4116         Regression(PSON) View becomes blank after click a cross-site download link
4117         https://bugs.webkit.org/show_bug.cgi?id=193361
4118         <rdar://problem/47099573>
4119
4120         Reviewed by Geoffrey Garen.
4121
4122         Add API test coverage.
4123
4124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4125         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4126
4127 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4128
4129         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4130         https://bugs.webkit.org/show_bug.cgi?id=193470
4131
4132         Reviewed by Antti Koivisto.
4133
4134         * LayoutReloaded/misc/LFC-passing-tests.txt:
4135
4136 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4137
4138         [LFC] Adjust margin box verification.
4139         https://bugs.webkit.org/show_bug.cgi?id=193482
4140
4141         Reviewed by Antti Koivisto.
4142
4143         * LayoutReloaded/misc/LFC-passing-tests.txt:
4144
4145 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4146
4147         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4148         https://bugs.webkit.org/show_bug.cgi?id=193451
4149
4150         Reviewed by Geoffrey Garen.
4151
4152         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4153         (TEST):
4154         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4155         (runWebsiteDataStoreCustomPaths):
4156
4157 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4158
4159         webkitpy: Support boolean simctl isAvailable
4160         https://bugs.webkit.org/show_bug.cgi?id=193472
4161         <rdar://problem/47296150>
4162
4163         Reviewed by Ryosuke Niwa.
4164
4165         * Scripts/webkitpy/xcode/simulated_device.py:
4166         (SimulatedDeviceManager._create_runtimes):
4167         (SimulatedDeviceManager._create_device_with_runtime):
4168
4169 2019-01-15  Chris Dumez  <cdumez@apple.com>
4170
4171         Unreviewed, rolling out r239993, r239995, r239997, and
4172         r239999.
4173
4174         Caused assertions under
4175         ViewGestureController::disconnectFromProcess()
4176
4177         Reverted changesets:
4178
4179         "Regression(PSON) View becomes blank after click a cross-site
4180         download link"
4181         https://bugs.webkit.org/show_bug.cgi?id=193361
4182         https://trac.webkit.org/changeset/239993
4183
4184         "Unreviewed iOS build fix after r239993."
4185         https://trac.webkit.org/changeset/239995
4186
4187         "Fix iOS build after r239993"
4188         https://bugs.webkit.org/show_bug.cgi?id=193361
4189         https://trac.webkit.org/changeset/239997
4190
4191         "Unreviewed, revert part of r239997 as it is not needed to fix
4192         the build."
4193         https://trac.webkit.org/changeset/239999
4194
4195 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4196
4197         Cannot tab out of WKWebView on macOS
4198         https://bugs.webkit.org/show_bug.cgi?id=161448
4199         <rdar://problem/28100085>
4200
4201         Reviewed by Dean Jackson.
4202
4203         Add a test that tabbing into and out of WKWebView works correctly.
4204
4205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4206         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4207         (WebKit2_CommandBackForwardTest::SetUp):
4208         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4209         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4210         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4211         (-[FocusableView canBecomeKeyView]):
4212         (TEST):
4213         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4214         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4215         (-[OffscreenWindow initWithSize:]):
4216         (-[OffscreenWindow isKeyWindow]):
4217         (-[OffscreenWindow isVisible]):
4218         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4219         (TestWebKitAPI::PlatformWebView::initialize):
4220         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4221         (-[ActiveOffscreenWindow isVisible]): Deleted.
4222         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4223
4224 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4225
4226         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4227         https://bugs.webkit.org/show_bug.cgi?id=193459
4228
4229         Reviewed by Mark Lam.
4230
4231         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4232         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4233
4234 2019-01-15  Chris Dumez  <cdumez@apple.com>
4235
4236         Regression(PSON) View becomes blank after click a cross-site download link
4237         https://bugs.webkit.org/show_bug.cgi?id=193361
4238         <rdar://problem/47099573>
4239
4240         Reviewed by Geoff Garen.
4241
4242         Add API test coverage.
4243
4244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4245         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4246
4247 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4248
4249         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4250         https://bugs.webkit.org/show_bug.cgi?id=193448
4251
4252         Reviewed by Antti Koivisto.
4253
4254         * LayoutReloaded/misc/LFC-passing-tests.txt:
4255
4256 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4257
4258         webkitpy: Implement device type specific expected results (Part 1)
4259         https://bugs.webkit.org/show_bug.cgi?id=192162
4260
4261         Reviewed by Lucas Forschler.
4262
4263         Device type specific expected results covers two related ideas. The first (covered by this change)
4264         is where to search for -expected.* files. The second is which tests to run based on the
4265         TestExpectations.txt file.
4266
4267         After this change, the baseline search path will be determined by the type of device running a
4268         test. Device type will be passed into any function which picks a file based on the baseline search
4269         path.
4270
4271         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4272         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4273         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4274         (Manager.run): Print baseline search path for each round of devices.
4275         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4276         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4277         (SingleTestRunner._expected_driver_output): Ditto.
4278         (SingleTestRunner._driver_input): Ditto.
4279         * Scripts/webkitpy/layout_tests/views/printing.py:
4280         (Printer.print_config): Move printing of baseline search path to a separate function.
4281         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4282         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4283         (Testprinter.test_print_config):
4284         (Testprinter.test_print_baseline_search_path):
4285         * Scripts/webkitpy/port/base.py:
4286         (Port.baseline_search_path): Pass device_type through.
4287         (Port._expected_baselines_for_suffixes): Ditto.
4288         (Port.expected_baselines): Ditto.
4289         (Port.expected_filename): Ditto.
4290         (Port.expected_checksum): Ditto.
4291         (Port.expected_image): Ditto.
4292         (Port.expected_audio): Ditto.
4293         (Port.expected_text): Ditto.
4294         (Port.reference_files): Ditto.
4295         (Port.tests): Ditto.
4296         (Port._expanded_paths): Ditto.
4297         (Port.skipped_layout_tests): Ditto.
4298         (Port.expectations_dict): Ditto.
4299         (Port._port_specific_expectations_files): Ditto.
4300         (Port.expectations_files): Ditto.
4301         (Port.test_search_path): Ditto.
4302         (Port._tests_for_other_platforms): Ditto.
4303         * Scripts/webkitpy/port/base_unittest.py:
4304         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4305         (PortTest.test_nonexistant_expectations): Ditto.
4306         (test_ref_tests_platform_directory): Ditto.
4307         * Scripts/webkitpy/port/darwin.py:
4308         (DarwinPort._port_specific_expectations_files): Accept device_type.
4309         * Scripts/webkitpy/port/driver.py:
4310         (DriverProxy):
4311         (DriverProxy.host): Expose _target_host for device_type information.
4312         * Scripts/webkitpy/port/gtk.py:
4313         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4314         * Scripts/webkitpy/port/ios.py:
4315         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4316         * Scripts/webkitpy/port/mac.py:
4317         (MacPort. default_baseline_search_path): Ditto.
4318         * Scripts/webkitpy/port/port_testcase.py:
4319         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4320         * Scripts/webkitpy/port/test.py:
4321         * Scripts/webkitpy/port/watch.py:
4322         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4323         * Scripts/webkitpy/port/win.py:
4324         (WinPort.test_search_path): Accept, but do not use, device_type.
4325         * Scripts/webkitpy/port/wpe.py:
4326         (WPEPort._port_specific_expectations_files): Ditto.
4327         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4328         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4329
4330 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4331
4332         [LFC] Use the containing block's padding box to position out-of-flow elements.
4333         https://bugs.webkit.org/show_bug.cgi?id=193431
4334
4335         Reviewed by Antti Koivisto.