Unreviewed, rolling out r244400.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Truitt Savell  <tsavell@apple.com>
2
3         Unreviewed, rolling out r244400.
4
5         Caused testing to exit early with assertionon Debug WK2
6
7         Reverted changeset:
8
9         "UI↔Web deadlock when printing with a JavaScript alert
10         visible"
11         https://bugs.webkit.org/show_bug.cgi?id=196839
12         https://trac.webkit.org/changeset/244400
13
14 2019-04-17  Brady Eidson  <beidson@apple.com>
15
16         Link clicks in PDFs shouldn't send referrer headers.
17         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
18
19         Reviewed by Tim Horton.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
23         (putPDFBytesCallback):
24         (emptyReleaseInfoCallback):
25         (createPDFWithLinkToURL):
26         (TEST):
27
28 2019-04-17  Tim Horton  <timothy_horton@apple.com>
29
30         UI↔Web deadlock when printing with a JavaScript alert visible
31         https://bugs.webkit.org/show_bug.cgi?id=196839
32         <rdar://problem/49157642>
33
34         Reviewed by Andy Estes.
35
36         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
38         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
39         (TEST):
40
41 2019-04-17  Alex Christensen  <achristensen@webkit.org>
42
43         WKRetainPtr's adoption constructor should be private
44         https://bugs.webkit.org/show_bug.cgi?id=197019
45
46         Reviewed by Tim Horton.
47
48         * DumpRenderTree/mac/DumpRenderTree.mm:
49         (dumpFramesAsText):
50         * TestWebKitAPI/InjectedBundleController.cpp:
51         (TestWebKitAPI::InjectedBundleController::initialize):
52         * TestWebKitAPI/PlatformUtilities.cpp:
53         (TestWebKitAPI::Util::createContextWithInjectedBundle):
54         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
55         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
56         (TestWebKitAPI::Util::toWK):
57         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
60         (TestWebKitAPI::TEST):
61         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
62         (TestWebKitAPI::TEST):
63         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
64         (TestWebKitAPI::TEST):
65         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
66         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
67         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
68         (TestWebKitAPI::TEST):
69         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
70         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
71         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
72         (TestWebKitAPI::TEST):
73         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
74         (TestWebKitAPI::TEST):
75         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
76         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
77         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
80         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
81         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
82         (TestWebKitAPI::TEST):
83         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
84         (TestWebKitAPI::TEST):
85         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
86         (TestWebKitAPI::TEST):
87         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
88         (TestWebKitAPI::TEST):
89         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
90         (TestWebKitAPI::TEST):
91         * TestWebKitAPI/Tests/WebKit/Find.cpp:
92         (TestWebKitAPI::TEST):
93         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
94         (TestWebKitAPI::TEST):
95         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
96         (TestWebKitAPI::TEST):
97         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
98         (TestWebKitAPI::TEST):
99         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
100         (TestWebKitAPI::TEST):
101         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
102         (TestWebKitAPI::TEST):
103         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
106         (TestWebKitAPI::TEST):
107         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
108         (TestWebKitAPI::TEST):
109         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
110         (TestWebKitAPI::TEST):
111         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
112         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
113         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
114         (TestWebKitAPI::TEST):
115         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
116         (TestWebKitAPI::TEST):
117         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
118         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
119         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
120         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
123         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
124         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
125         (TestWebKitAPI::TEST):
126         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
129         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
130         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
133         (TestWebKitAPI::loadAlternateHTMLString):
134         (TestWebKitAPI::TEST):
135         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
136         (TestWebKitAPI::TEST):
137         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
138         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
139         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
140         (TestWebKitAPI::buildAndPerformTest):
141         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
144         (TestWebKitAPI::TEST):
145         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
146         (TestWebKitAPI::TEST):
147         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
148         (TestWebKitAPI::TEST):
149         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
150         (TestWebKitAPI::TEST):
151         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
154         (TestWebKitAPI::TEST):
155         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
156         (TestWebKitAPI::TEST):
157         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
158         (TestWebKitAPI::TEST):
159         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
160         (TestWebKitAPI::TEST):
161         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
164         (TestWebKitAPI::TEST):
165         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
170         (TestWebKitAPI::TEST):
171         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
172         (TestWebKitAPI::TEST):
173         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
174         (TestWebKitAPI::TEST):
175         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
178         (TestWebKitAPI::TEST):
179         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
184         (TestWebKitAPI::TEST):
185         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
186         (TestWebKitAPI::TEST):
187         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
188         (TestWebKitAPI::TEST):
189         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
192         (TestWebKitAPI::TEST):
193         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
196         (TestWebKitAPI::TEST):
197         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
200         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
201         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
202         (TestWebKitAPI::TEST):
203         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
206         (TestWebKitAPI::TEST):
207         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
212         (TestWebKitAPI::TEST):
213         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
216         (TestWebKitAPI::TEST):
217         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
223         (TEST):
224         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
225         (TEST):
226         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
227         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
228         (TEST):
229         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
232         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
233         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
234         (WTR::getMenuItemTitleCallback):
235         (WTR::createMouseMessageBody):
236         (WTR::EventSendingController::mouseDown):
237         (WTR::EventSendingController::mouseUp):
238         (WTR::EventSendingController::mouseMoveTo):
239         (WTR::EventSendingController::mouseForceClick):
240         (WTR::EventSendingController::startAndCancelMouseForceClick):
241         (WTR::EventSendingController::mouseForceDown):
242         (WTR::EventSendingController::mouseForceUp):
243         (WTR::EventSendingController::mouseForceChanged):
244         (WTR::EventSendingController::leapForward):
245         (WTR::EventSendingController::scheduleAsynchronousClick):
246         (WTR::createKeyDownMessageBody):
247         (WTR::EventSendingController::keyDown):
248         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
249         (WTR::EventSendingController::mouseScrollBy):
250         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
251         (WTR::EventSendingController::continuousMouseScrollBy):
252         (WTR::EventSendingController::addTouchPoint):
253         (WTR::EventSendingController::updateTouchPoint):
254         (WTR::EventSendingController::setTouchModifier):
255         (WTR::EventSendingController::setTouchPointRadius):
256         (WTR::EventSendingController::touchStart):
257         (WTR::EventSendingController::touchMove):
258         (WTR::EventSendingController::touchEnd):
259         (WTR::EventSendingController::touchCancel):
260         (WTR::EventSendingController::clearTouchPoints):
261         (WTR::EventSendingController::releaseTouchPoint):
262         (WTR::EventSendingController::cancelTouchPoint):
263         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
264         (WTR::InjectedBundle::didCreatePage):
265         (WTR::InjectedBundle::didReceiveMessage):
266         (WTR::InjectedBundle::didReceiveMessageToPage):
267         (WTR::InjectedBundle::booleanForKey):
268         (WTR::InjectedBundle::done):
269         (WTR::InjectedBundle::dumpToStdErr):
270         (WTR::InjectedBundle::outputText):
271         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
272         (WTR::InjectedBundle::postAddChromeInputField):
273         (WTR::InjectedBundle::postRemoveChromeInputField):
274         (WTR::InjectedBundle::postFocusWebView):
275         (WTR::InjectedBundle::postSetBackingScaleFactor):
276         (WTR::InjectedBundle::postSetWindowIsKey):
277         (WTR::InjectedBundle::postSetViewSize):
278         (WTR::InjectedBundle::postSimulateWebNotificationClick):
279         (WTR::InjectedBundle::postSetAddsVisitedLinks):
280         (WTR::InjectedBundle::setGeolocationPermission):
281         (WTR::InjectedBundle::setMockGeolocationPosition):
282         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
283         (WTR::InjectedBundle::isGeolocationProviderActive const):
284         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
285         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
286         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
287         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
288         (WTR::InjectedBundle::setCustomPolicyDelegate):
289         (WTR::InjectedBundle::setHidden):
290         (WTR::InjectedBundle::setCacheModel):
291         (WTR::InjectedBundle::shouldProcessWorkQueue const):
292         (WTR::InjectedBundle::processWorkQueue):
293         (WTR::InjectedBundle::queueBackNavigation):
294         (WTR::InjectedBundle::queueForwardNavigation):
295         (WTR::InjectedBundle::queueLoad):
296         (WTR::InjectedBundle::queueLoadHTMLString):
297         (WTR::InjectedBundle::queueReload):
298         (WTR::InjectedBundle::queueLoadingScript):
299         (WTR::InjectedBundle::queueNonLoadingScript):
300         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
301         (WTR::frameToStr):
302         (WTR::InjectedBundlePage::InjectedBundlePage):
303         (WTR::dumpFrameDescriptionSuitableForTestResult):
304         (WTR::dumpFrameScrollPosition):
305         (WTR::dumpDescendantFrameScrollPositions):
306         (WTR::dumpFrameText):
307         (WTR::dumpDescendantFramesText):
308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
309         (WTR::TestRunner::shouldDumpPixels const):
310         (WTR::TestRunner::setDumpPixels):
311         (WTR::TestRunner::whatToDump const):
312         (WTR::TestRunner::setWhatToDump):
313         (WTR::TestRunner::setWaitUntilDone):
314         (WTR::TestRunner::shouldWaitUntilDone const):
315         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
316         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
317         (WTR::TestRunner::clearAllDatabases):
318         (WTR::TestRunner::setIDBPerOriginQuota):
319         (WTR::TestRunner::originsWithApplicationCache):
320         (WTR::TestRunner::setCanOpenWindows):
321         (WTR::TestRunner::setXSSAuditorEnabled):
322         (WTR::TestRunner::setMediaDevicesEnabled):
323         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
324         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
325         (WTR::TestRunner::setCustomUserAgent):
326         (WTR::TestRunner::setWebAPIStatisticsEnabled):
327         (WTR::TestRunner::setModernMediaControlsEnabled):
328         (WTR::TestRunner::setWebGL2Enabled):
329         (WTR::TestRunner::setWritableStreamAPIEnabled):
330         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
331         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
332         (WTR::TestRunner::setAllowsAnySSLCertificate):
333         (WTR::TestRunner::setPluginsEnabled):
334         (WTR::TestRunner::setValueForUser):
335         (WTR::TestRunner::setAudioResult):
336         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
337         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
338         (WTR::TestRunner::setAlwaysAcceptCookies):
339         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
340         (WTR::TestRunner::isDoingMediaCapture const):
341         (WTR::TestRunner::queueLoad):
342         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
343         (WTR::TestRunner::setHandlesAuthenticationChallenges):
344         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
345         (WTR::TestRunner::setShouldLogDownloadCallbacks):
346         (WTR::TestRunner::setAuthenticationUsername):
347         (WTR::TestRunner::setAuthenticationPassword):
348         (WTR::TestRunner::secureEventInputIsEnabled const):
349         (WTR::TestRunner::setBlockAllPlugins):
350         (WTR::TestRunner::setPluginSupportedMode):
351         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
352         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
353         (WTR::TestRunner::setNavigationGesturesEnabled):
354         (WTR::TestRunner::setIgnoresViewportScaleLimits):
355         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
356         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
357         (WTR::TestRunner::terminateNetworkProcess):
358         (WTR::TestRunner::terminateServiceWorkerProcess):
359         (WTR::TestRunner::runUIScript):
360         (WTR::TestRunner::setStatisticsDebugMode):
361         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
362         (WTR::TestRunner::setStatisticsLastSeen):
363         (WTR::TestRunner::setStatisticsPrevalentResource):
364         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
365         (WTR::TestRunner::dumpResourceLoadStatistics):
366         (WTR::TestRunner::isStatisticsPrevalentResource):
367         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
368         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
369         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
370         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
371         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
372         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
373         (WTR::TestRunner::setStatisticsGrandfathered):
374         (WTR::TestRunner::isStatisticsGrandfathered):
375         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
376         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
377         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
378         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
379         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
380         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
381         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
382         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
383         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
384         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
385         (WTR::TestRunner::statisticsUpdateCookieBlocking):
386         (WTR::TestRunner::statisticsSubmitTelemetry):
387         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
388         (WTR::TestRunner::setStatisticsIsRunningTest):
389         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
390         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
391         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
392         (WTR::TestRunner::setStatisticsGrandfatheringTime):
393         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
394         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
395         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
396         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
397         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
398         (WTR::TestRunner::statisticsDeleteCookiesForHost):
399         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
400         (WTR::TestRunner::statisticsResetToConsistentState):
401         (WTR::TestRunner::setStorageAccessAPIEnabled):
402         (WTR::TestRunner::getAllStorageAccessEntries):
403         (WTR::TestRunner::addMockMediaDevice):
404         (WTR::TestRunner::clearMockMediaDevices):
405         (WTR::TestRunner::removeMockMediaDevice):
406         (WTR::TestRunner::resetMockMediaDevices):
407         (WTR::TestRunner::connectMockGamepad):
408         (WTR::TestRunner::disconnectMockGamepad):
409         (WTR::TestRunner::setMockGamepadDetails):
410         (WTR::TestRunner::setMockGamepadAxisValue):
411         (WTR::TestRunner::setMockGamepadButtonValue):
412         (WTR::TestRunner::removeAllSessionCredentials):
413         (WTR::TestRunner::clearDOMCache):
414         (WTR::TestRunner::clearDOMCaches):
415         (WTR::TestRunner::hasDOMCache):
416         (WTR::TestRunner::domCacheSize):
417         (WTR::TestRunner::setAllowStorageQuotaIncrease):
418         (WTR::TestRunner::getApplicationManifestThen):
419         (WTR::TestRunner::injectUserScript):
420         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
421         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
422         (WTR::TestRunner::addTestKeyToKeychain):
423         (WTR::TestRunner::cleanUpKeychain):
424         (WTR::TestRunner::keyExistsInKeychain):
425         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
426         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
427         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
428         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
429         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
430         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::initialize):
433         (WTR::parseStringTestHeaderValueAsRelativePath):
434         (WTR::updateTestOptionsFromTestHeader):
435         (WTR::TestController::runTest):
436         (WTR::TestController::didReceiveLiveDocumentsList):
437         (WTR::TestController::didReceiveMessageFromInjectedBundle):
438         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
439         (WTR::TestController::didFinishNavigation):
440         (WTR::TestController::didReceiveAuthenticationChallenge):
441         * WebKitTestRunner/TestInvocation.cpp:
442         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
443         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
444         (WTR::TestInvocation::uiScriptDidComplete):
445         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
446         * WebKitTestRunner/WebNotificationProvider.cpp:
447         (WTR::WebNotificationProvider::closeWebNotification):
448         * WebKitTestRunner/WorkQueueManager.cpp:
449         (WTR::ScriptItem::ScriptItem):
450         (WTR::WorkQueueManager::queueLoad):
451         (WTR::WorkQueueManager::queueLoadHTMLString):
452
453 2019-04-17  Alex Christensen  <achristensen@webkit.org>
454
455         Add a comment to make my test from r244139 less mysterious.
456         https://bugs.webkit.org/show_bug.cgi?id=196744
457
458         As suggested by Darin Adler.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
461         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
462
463 2019-04-17  Chris Dumez  <cdumez@apple.com>
464
465         Remember device orientation permission for the duration of the browsing session
466         https://bugs.webkit.org/show_bug.cgi?id=196992
467         <rdar://problem/49946067>
468
469         Reviewed by Alex Christensen.
470
471         Add API test coverage.
472
473         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
474         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
475         (TEST):
476
477 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
478
479         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
480         https://bugs.webkit.org/show_bug.cgi?id=196675
481
482         Reviewed by Lucas Forschler.
483
484         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
485         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
486
487 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
488
489         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
490         https://bugs.webkit.org/show_bug.cgi?id=196919
491         <rdar://problem/41630459>
492
493         Reviewed by Tim Horton.
494
495         Add iOS support for several new testing hooks. See below for more detail.
496
497         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
498         (WTR::UIScriptController::isDismissingMenu const):
499
500         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
501         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
502         by UIKit when dismissing the callout bar (i.e. UIMenuController).
503
504         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
505         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
506         (WTR::UIScriptController::isDismissingMenu const):
507         * TestRunnerShared/UIScriptContext/UIScriptController.h:
508         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
510         (WTR::InjectedBundle::didReceiveMessageToPage):
511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
512         (WTR::TestRunner::setAllowedMenuActions):
513
514         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
515         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
516         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
517         against the name of the custom action.
518
519         (WTR::TestRunner::installCustomMenuAction):
520
521         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
522         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
523         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
524         triggered.
525
526         (WTR::TestRunner::performCustomMenuAction):
527
528         Invoked when the custom menu action is triggered.
529
530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
531         * WebKitTestRunner/TestController.cpp:
532         (WTR::TestController::installCustomMenuAction):
533         (WTR::TestController::setAllowedMenuActions):
534         * WebKitTestRunner/TestController.h:
535         * WebKitTestRunner/TestInvocation.cpp:
536         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
537         (WTR::TestInvocation::performCustomMenuAction):
538
539         Add plumbing to call back into the injected bundle when performing the custom action.
540
541         * WebKitTestRunner/TestInvocation.h:
542         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
543         (WTR::TestController::installCustomMenuAction):
544         (WTR::TestController::setAllowedMenuActions):
545         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
546         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
547         (-[TestRunnerWKWebView initWithFrame:configuration:]):
548         (-[TestRunnerWKWebView becomeFirstResponder]):
549         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
550
551         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
552         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
553         in the Mail app on iOS.
554
555         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
556         (-[TestRunnerWKWebView setAllowedMenuActions:]):
557         (-[TestRunnerWKWebView resetCustomMenuAction]):
558         (-[TestRunnerWKWebView performCustomAction:]):
559         (-[TestRunnerWKWebView canPerformAction:withSender:]):
560         (-[TestRunnerWKWebView _willHideMenu]):
561         (-[TestRunnerWKWebView _didHideMenu]):
562         * WebKitTestRunner/ios/TestControllerIOS.mm:
563         (WTR::TestController::platformResetStateToConsistentValues):
564
565         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
566         if specified.
567
568         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
569         (WTR::UIScriptController::isDismissingMenu const):
570
571 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
572
573         Allow sharing from imageSheet on an image document
574         https://bugs.webkit.org/show_bug.cgi?id=196891
575         <rdar://problem/25377386>
576
577         Reviewed by Tim Horton.
578
579         Test to make sure that the correct imageURL is extracted from an image element.
580
581         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
582         (TestWebKitAPI::TEST):
583
584 2019-04-16  Alex Christensen  <achristensen@webkit.org>
585
586         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
587         https://bugs.webkit.org/show_bug.cgi?id=196995
588
589         Reviewed by Brady Eidson.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
592         (TEST):
593
594 2019-04-16  Chris Dumez  <cdumez@apple.com>
595
596         URL set by document.open() is not communicated to the UIProcess
597         https://bugs.webkit.org/show_bug.cgi?id=196941
598         <rdar://problem/49237544>
599
600         Reviewed by Geoff Garen.
601
602         Add API test coverage.
603
604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
605         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
606         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
607         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
608         (TEST):
609
610 2019-04-16  Commit Queue  <commit-queue@webkit.org>
611
612         Unreviewed, rolling out r244321.
613         https://bugs.webkit.org/show_bug.cgi?id=196968
614
615         Causing all WK2 Debug builds to exit early after Assertion
616         failures. (Requested by ShawnRoberts on #webkit).
617
618         Reverted changeset:
619
620         "URL set by document.open() is not communicated to the
621         UIProcess"
622         https://bugs.webkit.org/show_bug.cgi?id=196941
623         https://trac.webkit.org/changeset/244321
624
625 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
626
627         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
628         https://bugs.webkit.org/show_bug.cgi?id=196948
629
630         Reviewed by Zalan Bujtas.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
633         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
634
635 2019-04-15  Chris Dumez  <cdumez@apple.com>
636
637         URL set by document.open() is not communicated to the UIProcess
638         https://bugs.webkit.org/show_bug.cgi?id=196941
639         <rdar://problem/49237544>
640
641         Reviewed by Geoffrey Garen.
642
643         Add API test coverage.
644
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
646         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
647         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
648         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
649         (TEST):
650
651 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
652
653         Using Tools/Scripts/clean-webkit should not install requests
654         https://bugs.webkit.org/show_bug.cgi?id=196940
655
656         Reviewed by Lucas Forschler.
657
658         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
659         existing, depending on the path autoinstalled is run through.
660         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
661         needed.
662         (Port.configuration_for_upload):
663         (Port.commits_for_upload):
664
665 2019-04-15  Alex Christensen  <achristensen@webkit.org>
666
667         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
668         https://bugs.webkit.org/show_bug.cgi?id=196773
669
670         Reviewed by Jer Noble.
671
672         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
673         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
674         (TEST):
675
676 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
677
678         ews-build should clearly indicate flaky test failures
679         https://bugs.webkit.org/show_bug.cgi?id=196947
680
681         Reviewed by Lucas Forschler.
682
683         * BuildSlaveSupport/ews-build/steps.py:
684         (AnalyzeAPITestsResults.analyzeResults):
685
686 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
687
688         InjectedBundle parameters often need initialization function called before unarchiving
689         https://bugs.webkit.org/show_bug.cgi?id=189709
690         <rdar://problem/44573653>
691
692         Reviewed by Ryosuke Niwa.
693
694         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
695         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
696
697 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
698
699         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
700         https://bugs.webkit.org/show_bug.cgi?id=196681
701
702         Reviewed by Darin Adler.
703
704         Added tests.
705
706         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
707         (WTF_HashSet.RemoveIf):
708         (WTF_HashSet.RemoveIfShrinkToBestSize):
709
710 2019-04-15  John Wilander  <wilander@apple.com>
711
712         Send delayed Ad Click Attribution conversion requests to the click source
713         https://bugs.webkit.org/show_bug.cgi?id=196838
714         <rdar://problem/47650157>
715
716         Reviewed by Chris Dumez and Youenn Fablet.
717
718         This patch adds test infrastructure to override the default behavior in
719         WebKit::NetworkAdClickAttribution.
720
721         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
722         (TestWebKitAPI::TEST):
723         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
725         (WTR::TestRunner::dumpAdClickAttribution):
726         (WTR::TestRunner::clearAdClickAttribution):
727         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
728         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
732         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
733         * WebKitTestRunner/TestController.h:
734         * WebKitTestRunner/TestInvocation.cpp:
735         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
736
737 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
738
739         [ews-app] status-bubble should display position in queue
740         https://bugs.webkit.org/show_bug.cgi?id=196607
741
742         Reviewed by Lucas Forschler.
743
744         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
745         (StatusBubble._build_bubble):
746         (StatusBubble._queue_position): Method to calculate patch's position in queue.
747
748 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
749
750         [ews-build] Do not run clean build by default on EWS builders
751         https://bugs.webkit.org/show_bug.cgi?id=196897
752
753         Reviewed by Lucas Forschler.
754
755         * BuildSlaveSupport/ews-build/steps.py:
756         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
757         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
758         untracked directories like WebKitBuild).
759         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
760         untracked files/directories (like WebKitBuild).
761
762 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
763
764         TestRunner::notifyDone() should be safely reentrant
765         https://bugs.webkit.org/show_bug.cgi?id=196898
766
767         Reviewed by Darin Adler.
768
769         It is currently possible that TestRunner::notifyDone() will call itself, since
770         notifyDone() will force a repaint, which can start executing JavaScript, which
771         may call notifyDone() again. This can lead to test failures and flakiness.
772         Fix this by setting the m_waitToDump flag before calling the dump() method.
773
774         * DumpRenderTree/mac/TestRunnerMac.mm:
775         (TestRunner::notifyDone):
776         (TestRunner::forceImmediateCompletion):
777         * DumpRenderTree/win/TestRunnerWin.cpp:
778         (TestRunner::notifyDone):
779         (TestRunner::forceImmediateCompletion):
780
781 2019-04-15  Philippe Normand  <pnormand@igalia.com>
782
783         [GTK][WPE] Add enable-media websetting
784         https://bugs.webkit.org/show_bug.cgi?id=196863
785
786         Reviewed by Michael Catanzaro.
787
788         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
789         (testWebKitSettings): Add test for the enable-media web-setting.
790
791 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
792
793         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
794         https://bugs.webkit.org/show_bug.cgi?id=196905
795         <rdar://problem/49886096>
796
797         Reviewed by Tim Horton.
798
799         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
800         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
801         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
802         delay timer, we end up with this sequence of events in the problematic (failure) case:
803
804         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
805             ...IPC from UI to web process...
806         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
807             ...IPC from web to UI process...
808         (c) [UI]    Invoke completion handler for script #1
809         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
810             ...IPC from UI to web process...
811         (e) [Web]   Evaluate script #2 in the web process
812         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
813
814         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
815         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
816         #2 is run in step (e).
817
818         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
819         the UI process by waiting on a script message posted by the web process, after attachment updates are
820         dispatched.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
823         (TestWebKitAPI::TEST):
824
825 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
826
827         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
828         https://bugs.webkit.org/show_bug.cgi?id=196909
829
830         Reviewed by Wenson Hsieh.
831
832         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
833         (TestWebKitAPI::TEST):
834
835 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
836
837         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
838         https://bugs.webkit.org/show_bug.cgi?id=196880
839
840         Reviewed by Yusuke Suzuki.
841
842         Add a new function for bytecode cache tests that does not forceDiskCache
843         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
844         test added in this patch, since the code is invalid and therefore won't be
845         cached. It should also be useful for tests that evaluate dynamically
846         generated code.
847
848         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
849         * Scripts/run-jsc-stress-tests:
850
851 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
852
853         Update AudioSession route sharing policy
854         https://bugs.webkit.org/show_bug.cgi?id=196776
855         <rdar://problem/46501611>
856
857         Reviewed by Jer Noble.
858
859         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
860         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
861         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
862         (TestWebKitAPI::TEST):
863
864 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         [iOS] Software keyboard is shown too frequently on some websites
867         https://bugs.webkit.org/show_bug.cgi?id=195856
868         <rdar://problem/49191395>
869
870         Reviewed by Darin Adler.
871
872         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
873
874         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
875         (WTR::UIScriptController::setHardwareKeyboardAttached):
876         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
877         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
878         (WTR::UIScriptController::setHardwareKeyboardAttached):
879         * TestRunnerShared/UIScriptContext/UIScriptController.h:
880         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
881
882         Additionally link against GraphicsServices in WebKitTestRunner.
883
884         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
885         (WTR::TestController::platformResetStateToConsistentValues):
886         (WTR::UIScriptController::setHardwareKeyboardAttached):
887
888 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
889
890         [GTK][WPE] Fix pacman install-dependencies packages
891         https://bugs.webkit.org/show_bug.cgi?id=196817
892
893         Reviewed by Žan Doberšek.
894         
895         python3-setuptools is called python-setuptools
896         ruby-highline is only available on AUR
897         libv4l-devel is incorporated in v4l-utils
898
899         * gtk/install-dependencies:
900         * wpe/install-dependencies:
901
902 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
903
904         [GTK] REGRESSION(r243860): Many tests failing
905         https://bugs.webkit.org/show_bug.cgi?id=196791
906
907         Reviewed by Joanmarie Diggs.
908
909         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
910         multiple documents and check that accessibility hierarchy is updated after a navigation.
911
912         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
913         (loadChangedCallback):
914         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
915         (AccessibilityTest::AccessibilityTest):
916         (AccessibilityTest::~AccessibilityTest):
917         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
918         (AccessibilityTest::findTestServerApplication):
919         (AccessibilityTest::findDocumentWeb):
920         (AccessibilityTest::findRootObject):
921         (AccessibilityTest::waitUntilChildrenRemoved):
922         (AccessibilityTest::ensureProxy):
923         (testAtspiBasicHierarchy):
924         (beforeAll):
925         (afterAll):
926
927 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
928
929         [ews-build] Handle bug titles with unicode characters
930         https://bugs.webkit.org/show_bug.cgi?id=196802
931
932         Reviewed by Dewei Zhu.
933
934         * BuildSlaveSupport/ews-build/steps.py:
935         (ValidatePatch._is_bug_closed):
936
937 2019-04-11  Michael Saboff  <msaboff@apple.com>
938
939         Improve the Inline Cache Stats code
940         https://bugs.webkit.org/show_bug.cgi?id=196836
941
942         Reviewed by Saam Barati.
943
944         Added a new script to consolidate and arrange the output of --useICStats option.
945
946         This script merges the output from every group into one large table and sorts it from most common to
947         least common.  It also counts the slow path GetById and PutById variants and then calculates the
948         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
949         Put together, this is useful to see what property accesses are not getting cached.
950
951         * Scripts/ic-stats.py: Added.
952         (ICStats):
953         (ICStats.__init__):
954         (ICStats.parse):
955         (ICStats.dumpStats):
956         (usage):
957
958 2019-04-10  Alex Christensen  <achristensen@webkit.org>
959
960         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
961         https://bugs.webkit.org/show_bug.cgi?id=196809
962         <rdar://49800762>
963
964         Reviewed by Brady Eidson.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
967         (TEST):
968
969 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
970
971         requestAnimationFrame should execute before the next frame
972         https://bugs.webkit.org/show_bug.cgi?id=177484
973
974         Reviewed by Simon Fraser.
975
976         Add trace points for the page RenderingUpdate.
977
978         * Tracing/SystemTracePoints.plist:
979
980 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
981
982         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
983         https://bugs.webkit.org/show_bug.cgi?id=196760
984
985         Reviewed by Don Olmstead.
986
987         vswhere.exe has been bundled since Visual Studio 2017 version
988         15.2. We shouldn't download vswhere.exe.
989
990         * Scripts/build-jsc: Do not call update-vswhere.py.
991         * Scripts/build-webkit: Ditto.
992         * Scripts/update-vswhere.py: Removed.
993         * Scripts/webkitdirs.pm:
994         (requireModulesForVSWhere): Deleted.
995         (pickCurrentVisualStudioInstallation): Deleted.
996         (visualStudioInstallDirVSWhere): Return the latest installed VS
997         installation path by using the bundled vswhere.exe.
998         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
999         (visualStudioInstallDirFallback): Removed.
1000
1001 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1002
1003         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1004         https://bugs.webkit.org/show_bug.cgi?id=196780
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * BuildSlaveSupport/ews-build/steps.py:
1009         * BuildSlaveSupport/ews-build/steps_unittest.py:
1010
1011 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1012
1013         Add SPI WKNavigationResponse._downloadAttribute
1014         https://bugs.webkit.org/show_bug.cgi?id=196755
1015         <rdar://49587365>
1016
1017         Reviewed by Brady Eidson.
1018
1019         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1020         (-[NavigationResponseTestDelegate navigationResponse]):
1021         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1022         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1023         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1024         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1025         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1026         (readRequest):
1027         (writeResponse):
1028         (TEST):
1029
1030 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1031
1032         Add modern API for overriding the page's specified viewport configuration
1033         https://bugs.webkit.org/show_bug.cgi?id=167734
1034         <rdar://problem/30331795>
1035
1036         Reviewed by Simon Fraser.
1037
1038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1039         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1040
1041 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1042
1043         Add support for incremental bytecode cache updates
1044         https://bugs.webkit.org/show_bug.cgi?id=195000
1045
1046         Reviewed by Filip Pizlo.
1047
1048         Exit when the initial run to generate bytecode fails.
1049
1050         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1051
1052 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1053
1054         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1055         https://bugs.webkit.org/show_bug.cgi?id=196744
1056         <rdar://49415309>
1057
1058         Reviewed by Chris Dumez.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1061         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1062
1063 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1064
1065         Add a way to opt into modern compatibility mode in layout tests
1066         https://bugs.webkit.org/show_bug.cgi?id=196770
1067         <rdar://problem/49777550>
1068
1069         Reviewed by Antoine Quint.
1070
1071         Add a new test option to enable modern compatibility mode in layout tests.
1072
1073         * WebKitTestRunner/TestController.cpp:
1074         (WTR::updateTestOptionsFromTestHeader):
1075         * WebKitTestRunner/TestController.h:
1076         * WebKitTestRunner/TestOptions.h:
1077         (WTR::TestOptions::hasSameInitializationOptions const):
1078         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1079         (WTR::TestController::platformCreateWebView):
1080         (WTR::TestController::enableModernCompatibilityMode):
1081
1082 2019-04-10  Andy Estes  <aestes@apple.com>
1083
1084         Try to fix the 32-bit watchOS build.
1085
1086         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1087         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1088
1089 2019-04-10  Antoine Quint  <graouts@apple.com>
1090
1091         Enable Pointer Events on watchOS
1092         https://bugs.webkit.org/show_bug.cgi?id=196771
1093         <rdar://problem/49040909>
1094
1095         Reviewed by Dean Jackson.
1096
1097         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1098
1099 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1100
1101         Unreviewed. Fix WPE accessibility tests after r244059.
1102
1103         We are failing to load the injected bundle due to undefined symbol
1104         AccessibilityUIElement::replaceTextInRange().
1105
1106         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1107         (WTR::AccessibilityUIElement::replaceTextInRange):
1108
1109 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1110
1111         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1112         https://bugs.webkit.org/show_bug.cgi?id=196727
1113
1114         Reviewed by Fujii Hironori.
1115
1116         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1117         (WebKitBrowserWindow::create):
1118
1119 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1120
1121         [ews-build] Add unit tests for PrintConfiguration
1122         https://bugs.webkit.org/show_bug.cgi?id=196752
1123
1124         Reviewed by Dewei Zhu.
1125
1126         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1127
1128 2019-04-09  Keith Rollin  <krollin@apple.com>
1129
1130         Unreviewed build maintenance -- update .xcfilelists.
1131
1132         * DumpRenderTree/DerivedSources-input.xcfilelist:
1133         * DumpRenderTree/DerivedSources-output.xcfilelist:
1134
1135 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1136
1137         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1138         https://bugs.webkit.org/show_bug.cgi?id=196743
1139         <rdar://problem/43897551>
1140
1141         Reviewed by Tim Horton.
1142
1143         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1144         (TEST):
1145
1146 2019-04-09  Youenn Fablet  <youenn@apple.com>
1147
1148         Close service worker database on network process suspension
1149         https://bugs.webkit.org/show_bug.cgi?id=196623
1150         <rdar://problem/48930869>
1151
1152         Reviewed by Alex Christensen.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1155
1156 2019-04-09  Daniel Bates  <dabates@apple.com>
1157
1158         [iPad] Should open popover when the spacebar is pressed
1159         https://bugs.webkit.org/show_bug.cgi?id=196360
1160         <rdar://problem/49389129>
1161
1162         Reviewed by Brent Fulgham.
1163
1164         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1165
1166         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1167         (WTR::UIScriptController::isShowingPopover const): Added.
1168         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1169         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1171         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1172         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1173         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1174         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1175         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1176         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1177         (WTR::UIScriptController::isShowingPopover const): Added.
1178         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1179         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1180         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1182         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1183         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1184         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1185         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1186         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1187         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1188         (WTR::UIScriptController::isShowingPopover const): Added.
1189         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1190         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1191
1192 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1193
1194         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1195         https://bugs.webkit.org/show_bug.cgi?id=196665
1196         <rdar://45115669>
1197
1198         Reviewed by Geoff Garen.
1199
1200         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1201         (goBack):
1202         (+[SimpleLookupContext sharedLookupContext]):
1203         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1204         (TEST):
1205         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1206         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1207
1208 2019-04-09  John Wilander  <wilander@apple.com>
1209
1210         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1211         https://bugs.webkit.org/show_bug.cgi?id=196558
1212         <rdar://problem/47650245>
1213
1214         Reviewed by Youenn Fablet.
1215
1216         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1217         (TestWebKitAPI::TEST):
1218             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1219
1220 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1221
1222         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1223         https://bugs.webkit.org/show_bug.cgi?id=196720
1224
1225         Reviewed by Konstantin Tokarev.
1226
1227         * TestWebKitAPI/PlatformMac.cmake:
1228
1229 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1230
1231         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1232         https://bugs.webkit.org/show_bug.cgi?id=196694
1233         <rdar://problem/48388734>
1234
1235         Rubber-stamped by Aakash Jain.
1236
1237         * Scripts/webkitpy/port/image_diff.py:
1238         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1239         * Scripts/webkitpy/port/server_process.py:
1240         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1241         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1242         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1243         * Scripts/webkitpy/port/server_process_mock.py:
1244         (MockServerProcess.has_available_stdout):
1245         * Scripts/webkitpy/port/server_process_unittest.py:
1246         (TestServerProcess.serial_test_basic):
1247
1248 2019-04-09  Jer Noble  <jer.noble@apple.com>
1249
1250         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1251         https://bugs.webkit.org/show_bug.cgi?id=196097
1252
1253         Reviewed by Eric Carlson.
1254
1255         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1256
1257         * DumpRenderTree/mac/DumpRenderTree.mm:
1258         (resetWebPreferencesToConsistentValues):
1259         * WebKitTestRunner/TestController.cpp:
1260         (WTR::TestController::resetPreferencesToConsistentValues):
1261
1262 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1263
1264         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1265         https://bugs.webkit.org/show_bug.cgi?id=196690
1266
1267         Reviewed by Michael Catanzaro.
1268
1269         * QueueStatusServer/config/queues.py:
1270         * Scripts/webkitpy/common/config/ews.json:
1271         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1272         (test_ews_name):
1273
1274 2019-04-09  Chris Dumez  <cdumez@apple.com>
1275
1276         Loads using loadHTMLString() cause flashing when process-swapping
1277         https://bugs.webkit.org/show_bug.cgi?id=196714
1278         <rdar://problem/49637354>
1279
1280         Reviewed by Antti Koivisto.
1281
1282         Add API test coverage.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1285
1286 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1287
1288         Unreviewed. Fix ATK accessibility tests after r244059.
1289
1290         We are failing to load the injected bundle due to undefined symbol
1291         AccessibilityUIElement::replaceTextInRange().
1292
1293         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1294         (WTR::AccessibilityUIElement::replaceTextInRange):
1295
1296 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1297
1298         AX: Support API: accessibilityReplaceRange:withText
1299         https://bugs.webkit.org/show_bug.cgi?id=196636
1300
1301         Unreviewed build fix for Windows port.
1302
1303         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1304         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1305
1306 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1307
1308         [CMake][WinCairo] Separate copied headers into different directories
1309         https://bugs.webkit.org/show_bug.cgi?id=196655
1310
1311         Reviewed by Michael Catanzaro.
1312
1313         * DumpRenderTree/CMakeLists.txt:
1314         * MiniBrowser/win/CMakeLists.txt:
1315         * TestWebKitAPI/CMakeLists.txt:
1316         * TestWebKitAPI/PlatformWin.cmake:
1317
1318 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1319
1320         Log stack-trace for run-webkit-tests when interrupted
1321         https://bugs.webkit.org/show_bug.cgi?id=176393
1322         <rdar://problem/34262310>
1323
1324         Reviewed by Lucas Forschler.
1325
1326         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1327         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1328         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1329         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1330         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1331         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1332         (main): Set handlers to log stack trace on interruption.
1333
1334 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1335
1336         AX: Support API: accessibilityReplaceRange:withText
1337         https://bugs.webkit.org/show_bug.cgi?id=196636
1338
1339         Unreviewed build fix for Windows port.
1340
1341         * DumpRenderTree/AccessibilityUIElement.cpp:
1342         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1343
1344 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-build] Scripts using Buildbot API have CORS error
1347         https://bugs.webkit.org/show_bug.cgi?id=196709
1348
1349         Reviewed by Alexey Proskuryakov.
1350
1351         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1352
1353 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1354
1355         AX: Support API: accessibilityReplaceRange:withText
1356         https://bugs.webkit.org/show_bug.cgi?id=196636
1357
1358         Reviewed by Daniel Bates.
1359
1360         * DumpRenderTree/AccessibilityUIElement.cpp:
1361         (replaceTextInRangeCallback):
1362         (AccessibilityUIElement::replaceTextInRange):
1363         (AccessibilityUIElement::getJSClass):
1364         * DumpRenderTree/AccessibilityUIElement.h:
1365         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1366         (AccessibilityUIElement::replaceTextInRange):
1367         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1368         (AccessibilityUIElement::replaceTextInRange):
1369         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1370         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1371         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1372         (WTR::AccessibilityUIElement::replaceTextInRange):
1373         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1374         (WTR::AccessibilityUIElement::replaceTextInRange):
1375
1376 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1377
1378         [iOS] Do not allow starting selection drags when selection views are not visible
1379         https://bugs.webkit.org/show_bug.cgi?id=196686
1380         <rdar://problem/49399192>
1381
1382         Reviewed by Tim Horton.
1383
1384         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1385         also add some new API tests to cover scenarios where the web view is not first responder.
1386
1387         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1390
1391         Add a switch to optionally make the web view first responder when starting the simulated drag.
1392
1393         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1394         (-[DragAndDropSimulator initWithWebView:]):
1395         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1396
1397 2019-04-08  Justin Fan  <justin_fan@apple.com>
1398
1399         [Web GPU] Fix Web GPU experimental feature on iOS
1400         https://bugs.webkit.org/show_bug.cgi?id=196632
1401
1402         Reviewed by Myles C. Maxfield.
1403
1404         Properly make Web GPU available on iOS 11+.
1405
1406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1407
1408 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1409
1410         [ews-build] Do not upload archive when Compile Fails
1411         https://bugs.webkit.org/show_bug.cgi?id=196674
1412
1413         Reviewed by Alexey Proskuryakov.
1414
1415         * BuildSlaveSupport/ews-build/factories.py:
1416         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1417         * BuildSlaveSupport/ews-build/steps.py:
1418         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1419         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1420         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1421
1422 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1423
1424         Enable DFG on MIPS
1425         https://bugs.webkit.org/show_bug.cgi?id=196689
1426
1427         Reviewed by Žan Doberšek.
1428
1429         Since the bytecode change, we enabled the baseline JIT on mips in
1430         r240432, but DFG is still missing. With this change, all tests are
1431         passing on a ci20 board.
1432
1433         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1434
1435 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1436
1437         [Flatpak] Second run update-webkitwpe-flatpak fails
1438         https://bugs.webkit.org/show_bug.cgi?id=192702
1439
1440         Reviewed by Carlos Garcia Campos.
1441
1442         * flatpak/flatpakutils.py:
1443         (FlatpakObject.flatpak): Fix typo.
1444         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1445         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1446
1447 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1448
1449         [GTK][WPE] outlook.live.com displays old-fashioned UI
1450         https://bugs.webkit.org/show_bug.cgi?id=196642
1451
1452         Reviewed by Carlos Garcia Campos.
1453
1454         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1455         (TestWebKitAPI::TEST): New Mac platform quirk test.
1456
1457 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1458
1459         Unreviewed, rolling out r243956.
1460         https://bugs.webkit.org/show_bug.cgi?id=196688
1461
1462         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1463         by aakashjain on #webkit).
1464
1465         Reverted changeset:
1466
1467         "Clicking "Go Back" from a safe browsing warning from an
1468         iframe should navigate the WKWebView back to the previous
1469         page"
1470         https://bugs.webkit.org/show_bug.cgi?id=196665
1471         https://trac.webkit.org/changeset/243956
1472
1473 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1474
1475         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1476         https://bugs.webkit.org/show_bug.cgi?id=196669
1477
1478         Reviewed by Geoffrey Garen.
1479
1480         Added three new unit tests for WeakHashSet.
1481
1482         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1483         (WTF_WeakPtr.WeakHashSetConstObjects):
1484         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1485         (WTF_WeakPtr.WeakHashSetComputeSize):
1486
1487 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         Hide next and previous form control buttons when WKWebView is editable
1490         https://bugs.webkit.org/show_bug.cgi?id=196672
1491         <rdar://problem/35625321>
1492
1493         Reviewed by Tim Horton.
1494
1495         Add a new API test.
1496
1497         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1498         (-[TestWKWebView lastTrailingBarButtonGroup]):
1499         (TestWebKitAPI::TEST):
1500         * TestWebKitAPI/ios/UIKitSPI.h:
1501
1502 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1503
1504         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1505         https://bugs.webkit.org/show_bug.cgi?id=196077
1506         <rdar://problem/49108202>
1507
1508         Reviewed by Chris Dumez.
1509
1510         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1511         on new web view.
1512
1513         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1514
1515 2019-04-05  Saam Barati  <sbarati@apple.com>
1516
1517         Make compare-results understand MotionMark
1518         https://bugs.webkit.org/show_bug.cgi?id=196666
1519
1520         Reviewed by Yusuke Suzuki.
1521
1522         * Scripts/compare-results:
1523         (PLT5Results):
1524         (detectMotionMark):
1525         (detectMotionMark1_1):
1526         (motionMarkResults):
1527         (motionMark1_1Results):
1528         (detectBenchmark):
1529         (biggerIsBetter):
1530         (main):
1531
1532 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1533
1534         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1535         https://bugs.webkit.org/show_bug.cgi?id=196665
1536         <rdar://45115669>
1537
1538         Reviewed by Geoff Garen.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1541         (goBack):
1542         (+[SimpleLookupContext sharedLookupContext]):
1543         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1544         (TEST):
1545         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1546         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1547
1548 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1549
1550         [ews-build] Add configuration and architecture for windows builders
1551         https://bugs.webkit.org/show_bug.cgi?id=196660
1552
1553         Reviewed by Lucas Forschler.
1554
1555         * BuildSlaveSupport/ews-build/config.json:
1556
1557 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1558
1559         webkitpy: Don't run subsequent rounds if interrupted
1560         https://bugs.webkit.org/show_bug.cgi?id=196646
1561
1562         Reviewed by Aakash Jain.
1563
1564         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1565         (Manager.run): Bail out if interrupted.
1566
1567 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1568
1569         Test sessionStorage in PSON private browsing mode
1570         https://bugs.webkit.org/show_bug.cgi?id=196561
1571
1572         Reviewed by Alex Christensen.
1573
1574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1575
1576 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1577
1578         Unreviewed, rolling out r243833.
1579         https://bugs.webkit.org/show_bug.cgi?id=196645
1580
1581         This change breaks build of WPE and GTK ports (Requested by
1582         annulen on #webkit).
1583
1584         Reverted changeset:
1585
1586         "[CMake][WTF] Mirror XCode header directories"
1587         https://bugs.webkit.org/show_bug.cgi?id=191662
1588         https://trac.webkit.org/changeset/243833
1589
1590 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1591
1592         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1593         https://bugs.webkit.org/show_bug.cgi?id=196635
1594
1595         Reviewed by Antti Koivisto.
1596         
1597         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1598         for a test to enable async frame scrolling via:
1599             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1600         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1601         
1602         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1603
1604         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1605         (WTR::InjectedBundle::beginTesting):
1606         * WebKitTestRunner/TestController.cpp:
1607         (WTR::TestController::resetPreferencesToConsistentValues):
1608
1609 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Use a correct LC_RPATH when building with ASan
1612         https://bugs.webkit.org/show_bug.cgi?id=196576
1613
1614         Reviewed by David Kilzer.
1615
1616         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1617         so that ../Frameworks is checked. This is simpler and more reliable than updating
1618         each SPC service xcconfig.
1619
1620 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1621
1622         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1623         https://bugs.webkit.org/show_bug.cgi?id=196629
1624
1625         Reviewed by Lucas Forschler.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1628
1629 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1630
1631         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1632         https://bugs.webkit.org/show_bug.cgi?id=196618
1633
1634         Reviewed by Lucas Forschler.
1635
1636         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1637         (StatusBubble): Added QUEUE_TRIGGERS.
1638         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1639         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1640         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1641         its parent(builder).
1642
1643 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1644
1645         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1646         https://bugs.webkit.org/show_bug.cgi?id=196625
1647
1648         Reviewed by Lucas Forschler.
1649
1650         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1651         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1652
1653 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1654
1655         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1656         https://bugs.webkit.org/show_bug.cgi?id=196630
1657
1658         Reviewed by Wenson Hsieh.
1659
1660         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1661
1662 2019-04-04  Youenn Fablet  <youenn@apple.com>
1663
1664         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1665         https://bugs.webkit.org/show_bug.cgi?id=196543
1666
1667         Reviewed by Alex Christensen.
1668
1669         * WebKitTestRunner/TestController.cpp:
1670         (WTR::TestController::generatePageConfiguration):
1671
1672 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1673
1674         [ews-app] Status bubble should not display skipped buildbot steps
1675         https://bugs.webkit.org/show_bug.cgi?id=196584
1676
1677         Reviewed by Lucas Forschler.
1678
1679         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1680
1681 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1682
1683         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1684         https://bugs.webkit.org/show_bug.cgi?id=196620
1685
1686         Reviewed by Lucas Forschler.
1687
1688         * BuildSlaveSupport/ews-app/ews/config.py:
1689
1690 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1691
1692         [Win] DumpRenderTreeWatchDog.py is not checked into source
1693         https://bugs.webkit.org/show_bug.cgi?id=196567
1694         <rdar://problem/49525901>
1695
1696         Reviewed by Lucas Forschler.
1697
1698         This script is used on Win EWS bots to terminate hanging DRT processes.
1699
1700         * EWSTools/dumprendertreewatchdog.py: Added.
1701
1702 2019-04-04  Chris Dumez  <cdumez@apple.com>
1703
1704         Unreviewed, roll out r243858 which made tests time out.
1705
1706         Disable new API tests on Windows instead.
1707
1708         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1709         (TestWebKitAPI::TEST):
1710
1711 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1712
1713         [ATK] Cleanup WebPageAccessibilityObjectAtk
1714         https://bugs.webkit.org/show_bug.cgi?id=196537
1715
1716         Reviewed by Michael Catanzaro.
1717
1718         Also consider files under atk directories as exceptions for GObject conventions.
1719
1720         * Scripts/webkitpy/style/checkers/cpp.py:
1721         (check_identifier_name_in_declaration):
1722
1723 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1724
1725         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1726         https://bugs.webkit.org/show_bug.cgi?id=196588
1727         <rdar://problem/49365787>
1728
1729         Unreviewed build fix for Windows port.
1730
1731         error C3861: 'kill': identifier not found
1732
1733         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1734         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1735
1736 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-build] Cancel build and similar operations should have authentication
1739         https://bugs.webkit.org/show_bug.cgi?id=196520
1740
1741         Reviewed by Dewei Zhu.
1742
1743         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1744         environment variables.
1745
1746 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-build] Do not trigger queues which are not in production yet
1749         https://bugs.webkit.org/show_bug.cgi?id=196581
1750
1751         Reviewed by Dewei Zhu.
1752
1753         * BuildSlaveSupport/ews-build/config.json:
1754
1755 2019-04-03  Chris Dumez  <cdumez@apple.com>
1756
1757         Unreviewed, fix typo in the name of API test added in r243848.
1758
1759         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1760         (TestWebKitAPI::TEST):
1761
1762 2019-04-03  Chris Dumez  <cdumez@apple.com>
1763
1764         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1765         https://bugs.webkit.org/show_bug.cgi?id=196588
1766         <rdar://problem/49365787>
1767
1768         Reviewed by Ryosuke Niwa.
1769
1770         Add API test coverage.
1771
1772         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1773         (TestWebKitAPI::nullJavaScriptCallback):
1774         (TestWebKitAPI::didCrashCheckFrames):
1775         (TestWebKitAPI::TEST):
1776
1777 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1778
1779         run-webkit-tests: Upload test results (new results database)
1780         https://bugs.webkit.org/show_bug.cgi?id=196577
1781         <rdar://problem/34841155>
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1786         (Manager.run): Upload results after each device shard, since the configuration will be
1787         different for each device.
1788         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1789         uploaded to a results database.
1790         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1791         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1792
1793 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1794
1795         -apple-trailing-word is needed for browser detection
1796         https://bugs.webkit.org/show_bug.cgi?id=196575
1797
1798         Unreviewed.
1799
1800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1801
1802 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1803
1804         [CMake][WTF] Mirror XCode header directories
1805         https://bugs.webkit.org/show_bug.cgi?id=191662
1806
1807         Reviewed by Konstantin Tokarev.
1808
1809         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1810         builds.
1811
1812         * CMakeLists.txt:
1813         * DumpRenderTree/CMakeLists.txt:
1814         * DumpRenderTree/PlatformWin.cmake:
1815         * MiniBrowser/win/CMakeLists.txt:
1816         * TestWebKitAPI/CMakeLists.txt:
1817         * TestWebKitAPI/PlatformWin.cmake:
1818         * WebKitTestRunner/PlatformGTK.cmake:
1819         * WebKitTestRunner/PlatformWin.cmake:
1820
1821 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1822
1823         [ews-app] Status bubble should not display certain infrastructure status messages
1824         https://bugs.webkit.org/show_bug.cgi?id=196550
1825
1826         Reviewed by Lucas Forschler.
1827
1828         Do not display the steps which are un-needed for end-user. This information is still avaiable
1829         if the user click on the bubble and look at the Buildbot build.
1830         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1831         (StatusBubble._steps_messages):
1832         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1833
1834 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1835
1836         [ews-build] Use https for sending data to ews-app
1837         https://bugs.webkit.org/show_bug.cgi?id=196492
1838
1839         Reviewed by Lucas Forschler.
1840
1841         * BuildSlaveSupport/ews-build/events.py:
1842
1843 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1844
1845         Remove support for -apple-trailing-word
1846         https://bugs.webkit.org/show_bug.cgi?id=196525
1847
1848         Reviewed by Zalan Bujtas.
1849
1850         This CSS property is nonstandard and not used.
1851
1852         * Scripts/webkitperl/FeatureList.pm:
1853         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1854
1855 2019-04-03  Youenn Fablet  <youenn@apple.com>
1856
1857         Add a test for DOMCache on multiple browsing in case of private browsing
1858         https://bugs.webkit.org/show_bug.cgi?id=196524
1859
1860         Reviewed by Alex Christensen.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1863         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1864
1865 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1866
1867         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1868         https://bugs.webkit.org/show_bug.cgi?id=196540
1869
1870         Reviewed by Aakash Jain.
1871
1872         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1873
1874 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1875
1876         Add plumbing for a compatibility mode preference in WebKit
1877         https://bugs.webkit.org/show_bug.cgi?id=196005
1878
1879         Reviewed by Tim Horton.
1880
1881         Add new API tests.
1882
1883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1884         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1885
1886 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1887
1888         [WPE][GTK] Update libsrtp dependency package for Debian
1889         https://bugs.webkit.org/show_bug.cgi?id=196528
1890
1891         Reviewed by Frédéric Wang.
1892
1893         * gtk/install-dependencies:
1894         * wpe/install-dependencies:
1895
1896 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1897
1898         [WK2] Add support for Window's beforeprint / afterprint events
1899         https://bugs.webkit.org/show_bug.cgi?id=196478
1900         <rdar://problem/49535124>
1901
1902         Unreviewed build fix for MSVC.
1903
1904         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1905
1906         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1907
1908         * WebKitTestRunner/TestController.cpp:
1909         (WTR::printFrame): Use int and float literals.
1910
1911 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1912
1913         [ews-build] Reassign bots to queues
1914
1915         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1916
1917 2019-04-02  Chris Dumez  <cdumez@apple.com>
1918
1919         [WK2] Add support for Window's beforeprint / afterprint events
1920         https://bugs.webkit.org/show_bug.cgi?id=196478
1921
1922         Reviewed by Alex Christensen.
1923
1924         Add minimal implementation for printFrame in WebKitTestRunner.
1925
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::printFrame):
1928         (WTR::TestController::createOtherPage):
1929         (WTR::TestController::createWebViewWithOptions):
1930
1931 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1934         https://bugs.webkit.org/show_bug.cgi?id=196491
1935
1936         Reviewed by Lucas Forschler.
1937
1938         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1939
1940 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1941
1942         [ews-build] Configure buildbot try credentials in environment variables
1943         https://bugs.webkit.org/show_bug.cgi?id=196501
1944
1945         Reviewed by Lucas Forschler.
1946
1947         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1948         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1949         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1950
1951 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1952
1953         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1954         https://bugs.webkit.org/show_bug.cgi?id=196496
1955         <rdar://problem/49521634>
1956
1957         Reviewed by Chris Dumez.
1958
1959         Add new API tests (see WebKit ChangeLog for more detail).
1960
1961         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1962         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1963         (TEST):
1964
1965 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1966
1967         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1968         <https://webkit.org/b/196499>
1969
1970         Reviewed by Alexey Proskuryakov.
1971
1972         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1973         ENABLE_ADDRESS_SANITIZER.
1974
1975 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1976
1977         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1978         https://bugs.webkit.org/show_bug.cgi?id=182757
1979
1980         Reviewed by Don Olmstead.
1981
1982         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1983         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1984
1985 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1986
1987         run-api-tests: Upload test results
1988         https://bugs.webkit.org/show_bug.cgi?id=196323
1989         <rdar://problem/49356714>
1990
1991         Reviewed by Lucas Forschler.
1992
1993         * Scripts/webkitpy/api_tests/manager.py:
1994         (Manager):
1995         (Manager.run): Upload results to a results database.
1996         * Scripts/webkitpy/api_tests/run_api_tests.py:
1997         (parse_args): Add upload arguments.
1998         * Scripts/webkitpy/port/base.py:
1999         (Port):
2000         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2001         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2002         with commits from any other associated repositories.
2003         * Scripts/webkitpy/port/device.py:
2004         (Device):
2005         (Device.build_version): Access build_versoin of underlying platform device.
2006         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2007         (IOSSimulatorTest):
2008         (IOSSimulatorTest.test_configuration_for_upload):
2009         * Scripts/webkitpy/port/device_port.py:
2010         (DevicePort):
2011         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2012         the same as the machine uploading results.
2013         * Scripts/webkitpy/port/mac.py:
2014         (MacPort):
2015         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2016         * Scripts/webkitpy/port/mac_unittest.py:
2017         (MacTest):
2018         (MacTest.test_configuration_for_upload):
2019         * Scripts/webkitpy/xcode/simulated_device.py:
2020         (SimulatedDeviceManager._create_device_with_runtime):
2021         (SimulatedDevice.__init__): Create simulated device with a build_version.
2022         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2023         (test_existing_simulator):
2024
2025 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2026
2027         Remove extra newline characters (Follow-up fix to r243707)
2028
2029         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2030
2031 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-app] Use API_KEY to accept results data
2034         https://bugs.webkit.org/show_bug.cgi?id=196461
2035
2036         Reviewed by Dewei Zhu.
2037
2038         * BuildSlaveSupport/ews-app/ews/views/results.py:
2039         (Results.post): Validate EWS_API_KEY before accepting any data.
2040         * BuildSlaveSupport/ews-build/events.py:
2041         (Events.sendData): Send EWS_API_KEY if available along with event data.
2042
2043 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2044
2045         Unable to copy and paste a PDF from Notes into Mail compose body
2046         https://bugs.webkit.org/show_bug.cgi?id=196442
2047         <rdar://problem/48573098>
2048
2049         Reviewed by Tim Horton.
2050
2051         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2052         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2053         to be specified on the item providers.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2056         (TestWebKitAPI::mapItemForTesting):
2057         (TestWebKitAPI::contactItemForTesting):
2058
2059 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2060
2061         Make UIWKDocumentContext rects per-character instead of per-word
2062         https://bugs.webkit.org/show_bug.cgi?id=196459
2063
2064         Reviewed by Wenson Hsieh.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2067         (TEST):
2068         Adjust test results due to switching to per-character rects.
2069
2070 2019-04-01  Chris Dumez  <cdumez@apple.com>
2071
2072         UIProcess crash when a prewarmed process is terminated
2073         https://bugs.webkit.org/show_bug.cgi?id=196451
2074         <rdar://problem/49245471>
2075
2076         Reviewed by Geoffrey Garen.
2077
2078         Add API test coverage.
2079
2080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2081         (TEST):
2082
2083 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2084
2085         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2086         https://bugs.webkit.org/show_bug.cgi?id=196449
2087
2088         Reviewed by Lucas Forschler.
2089
2090         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2091         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2092         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2093         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2094
2095 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2098         https://bugs.webkit.org/show_bug.cgi?id=196444
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2103
2104 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2105
2106         Add SPI to canonicalize NSURLs with WTF::URL
2107         https://bugs.webkit.org/show_bug.cgi?id=196415
2108         <rdar://problem/44980271>
2109
2110         Reviewed by Darin Adler.
2111
2112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2113         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2114         (TestWebKitAPI::TEST):
2115
2116 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2117
2118         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2119         https://bugs.webkit.org/show_bug.cgi?id=196441
2120
2121         Reviewed by Carlos Garcia Campos.
2122
2123         Don't cache the wpe_view_backend object that might not exist yet at the
2124         time of EventSenderProxy constructor invocation, but instead retrieve
2125         that object whenever it's required for event dispatching. This should
2126         avoid crashes in this constructor now that it's invoked before any
2127         PlatformWindow has been set up (as changed in r243496).
2128
2129         * WebKitTestRunner/EventSenderProxy.h:
2130         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2131         (WTR::viewBackend):
2132         (WTR::EventSenderProxy::EventSenderProxy):
2133         (WTR::EventSenderProxy::mouseDown):
2134         (WTR::EventSenderProxy::mouseUp):
2135         (WTR::EventSenderProxy::mouseMoveTo):
2136         (WTR::EventSenderProxy::mouseScrollBy):
2137         (WTR::EventSenderProxy::keyDown):
2138         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2139
2140 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2141
2142         [Win][WebKit] MiniBrowser should support high DPI display
2143         https://bugs.webkit.org/show_bug.cgi?id=196391
2144
2145         Reviewed by Alex Christensen.
2146
2147         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2148         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2149         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2150         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2151
2152 2019-03-31  Sam Weinig  <weinig@apple.com>
2153
2154         Remove more i386 specific configurations
2155         https://bugs.webkit.org/show_bug.cgi?id=196430
2156
2157         Reviewed by Alexey Proskuryakov.
2158
2159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2160         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2161
2162 2019-03-31  Andy Estes  <aestes@apple.com>
2163
2164         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2165         https://bugs.webkit.org/show_bug.cgi?id=196433
2166         <rdar://problem/49293305>
2167
2168         Reviewed by Tim Horton.
2169
2170         Enhanced API test coverage to include all navigation response policy decisions in both
2171         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2177         (readFile):
2178         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2179         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2180         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2181         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2182         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2183         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2184         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2185         (-[QuickLookDelegate _downloadDidStart:]):
2186         (-[QuickLookDelegate _download:didReceiveResponse:]):
2187         (-[QuickLookDelegate _download:didReceiveData:]):
2188         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2189         (-[QuickLookDelegate _downloadDidFinish:]):
2190         (-[QuickLookDelegate _download:didFailWithError:]):
2191         (-[QuickLookDelegate _downloadDidCancel:]):
2192         (-[QuickLookDelegate verifyDownload]):
2193         (runTest):
2194         (runTestDecideBeforeLoading):
2195         (runTestDecideAfterLoading):
2196         (TEST):
2197         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2198         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2199         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2200         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2201         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2202         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2203         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2204         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2205         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2206         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2207         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2208         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2209         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2210         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2211
2212 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2213
2214         [CMake] add testdfg as target with build-jsc
2215         https://bugs.webkit.org/show_bug.cgi?id=196393
2216
2217         Reviewed by Saam Barati.
2218
2219         Added testdfg as one of the targets to build when
2220         using CMake.
2221
2222         * Scripts/build-jsc:
2223
2224 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2225
2226         Delete WebMetal implementation in favor of WebGPU
2227         https://bugs.webkit.org/show_bug.cgi?id=195418
2228
2229         Reviewed by Dean Jackson.
2230
2231         * DumpRenderTree/mac/DumpRenderTree.mm:
2232         (enableExperimentalFeatures):
2233         (resetWebPreferencesToConsistentValues):
2234         * Scripts/webkitperl/FeatureList.pm:
2235         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2238         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2239         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2240         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2241         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2242         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2243         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2244         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2245         (WTR::InjectedBundle::beginTesting):
2246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2247         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2249
2250 2019-03-29  Chris Dumez  <cdumez@apple.com>
2251
2252         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2253         https://bugs.webkit.org/show_bug.cgi?id=196405
2254         <rdar://problem/49428130>
2255
2256         Reviewed by Wenson Hsieh.
2257
2258         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2259         the popover presentation methods to be no-ops. Use this in the new test added in
2260         r243523 so that we do not swizzle those methods for all tests. This is needed because
2261         those WatchOS tests rely on the popover getting presented and interactive.
2262
2263         * WebKitTestRunner/TestController.cpp:
2264         (WTR::updateTestOptionsFromTestHeader):
2265         * WebKitTestRunner/TestController.h:
2266         * WebKitTestRunner/TestOptions.h:
2267         (WTR::TestOptions::hasSameInitializationOptions const):
2268         * WebKitTestRunner/ios/TestControllerIOS.mm:
2269         (WTR::TestController::platformInitialize):
2270         (WTR::TestController::platformResetStateToConsistentValues):
2271
2272 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2273
2274         [Curl] Add Server Trust Evaluation Support.
2275         https://bugs.webkit.org/show_bug.cgi?id=191646
2276
2277         Reviewed by Fujii Hironori.
2278
2279         Implemented MiniBrowser UI for asking if user trusts the server.
2280
2281         * MiniBrowser/win/Common.cpp:
2282         (askServerTrustEvaluation):
2283         (replaceString):
2284         * MiniBrowser/win/Common.h:
2285         * MiniBrowser/win/MiniBrowserLib.rc:
2286         * MiniBrowser/win/MiniBrowserLibResource.h:
2287         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2288         (createPEMString):
2289         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2290         (WebKitBrowserWindow::canTrustServerCertificate):
2291         * MiniBrowser/win/WebKitBrowserWindow.h:
2292
2293 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2294
2295         Implement ResizeObserver.
2296         https://bugs.webkit.org/show_bug.cgi?id=157743
2297
2298         Reviewed by Simon Fraser.
2299
2300         Support resizeObserverEnabled webPreferences.
2301
2302         * DumpRenderTree/TestOptions.cpp:
2303         (TestOptions::TestOptions):
2304         * DumpRenderTree/TestOptions.h:
2305         * DumpRenderTree/mac/DumpRenderTree.mm:
2306         (setWebPreferencesForTestOptions):
2307         * DumpRenderTree/win/DumpRenderTree.cpp:
2308         (enableExperimentalFeatures):
2309         * Scripts/webkitperl/FeatureList.pm:
2310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2311
2312 2019-03-28  John Wilander  <wilander@apple.com>
2313
2314         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2315         https://bugs.webkit.org/show_bug.cgi?id=196281
2316         <rdar://problem/48938748>
2317
2318         Reviewed by Alex Christensen.
2319
2320         This patch adds the function isStatisticsHasLocalStorage() to the
2321         TestRunner. With it, the page can query the WebsiteDataStore in the
2322         UI process to make sure that it sees LocalStorage.
2323
2324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2326         (WTR::TestRunner::isStatisticsHasLocalStorage):
2327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2328         * WebKitTestRunner/TestController.cpp:
2329         (WTR::TestController::isStatisticsHasLocalStorage):
2330         * WebKitTestRunner/TestController.h:
2331         * WebKitTestRunner/TestInvocation.cpp:
2332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2333
2334 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2335
2336         API::Data::createWithoutCopying should do a null check before calling CFRelease
2337         https://bugs.webkit.org/show_bug.cgi?id=196276
2338         <rdar://problem/48059859>
2339
2340         Reviewed by Alex Christensen.
2341
2342         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2343
2344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2345         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2346         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2347         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2348         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2349         (TestWebKitAPI::TEST):
2350
2351 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2352
2353         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2354         https://bugs.webkit.org/show_bug.cgi?id=186276
2355
2356         Reviewed by Carlos Garcia Campos.
2357
2358         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2359         (webViewLoadChanged):
2360         (testWebResourceGetDataError):
2361         (testWebResourceGetDataEmpty):
2362         (beforeAll):
2363         (webViewloadChanged): Deleted.
2364
2365 2019-03-27  Andy Estes  <aestes@apple.com>
2366
2367         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2368         https://bugs.webkit.org/show_bug.cgi?id=196317
2369
2370         Reviewed by Dan Bernstein.
2371
2372         package-root copies built products into a staging directory using ditto(1), which does not
2373         follow symbolic links as it traverses a directory. Now that the files in
2374         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2375         itself, these become broken links when ditto'd into the staging directory.
2376
2377         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2378
2379         * Scripts/package-root:
2380
2381 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2382
2383         [ews-app] Update display text of Submit for ews analysis
2384         https://bugs.webkit.org/show_bug.cgi?id=196309
2385
2386         Reviewed by Dewei Zhu.
2387
2388         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2389
2390 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2391
2392         run-webkit-tests should check for leaks in WebKit processes
2393         <https://webkit.org/b/193772>
2394         <rdar://problem/46526680>
2395
2396         Reviewed by Ryosuke Niwa.
2397
2398         This works by doing the following:
2399         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2400           The list of child processes are returned one per line:
2401           process.name: pid
2402         - Run the "#LIST CHILD PROCESSES" command just before the
2403           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2404           processes on the ServerProcess object.
2405         - When the `--leaks` switch is handled, run check_for_leaks() on
2406           each child process after the main test harness.
2407
2408         * DumpRenderTree/mac/DumpRenderTree.mm:
2409         (handleControlCommand):
2410         - Use strncmp() instead of strcmp().
2411         - Add support for handling "#LIST CHILD PROCESSES" command.
2412
2413         * Scripts/webkitpy/port/base.py:
2414         (Port.check_for_leaks):
2415         * Scripts/webkitpy/port/darwin.py:
2416         (DarwinPort.check_for_leaks):
2417         - Rename redundant 'process_pid' argument to 'process_id'.
2418
2419         * Scripts/webkitpy/port/driver.py:
2420         (Driver.do_post_tests_work):
2421         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2422           longer the only command this sends to WebKitTestRunner.
2423         - If the `--leaks` switch is present, send the
2424           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2425           result using Port.set_webkit_processes().
2426         (Driver._parse_child_processes_output):
2427         - Add helper method to parse list of child process names and
2428           process IDs returned from WebKitTestRunner.
2429
2430         * Scripts/webkitpy/port/ios_device.py:
2431         (IOSDevicePort.check_for_leaks):
2432         - Rename redundant 'process_pid' argument to 'process_id'.
2433
2434         * Scripts/webkitpy/port/leakdetector.py:
2435         (LeakDetector._parse_leaks_output):
2436         - Return early if there is no leaks_output.
2437         (LeakDetector.check_for_leaks):
2438         - Rename redundant 'process_pid' argument to 'process_id'.
2439
2440         * Scripts/webkitpy/port/server_process.py:
2441         (ServerProcess.__init__):
2442         (ServerProcess.child_processes):
2443         (ServerProcess.set_child_processes):
2444         - Add instance variable to Port to store list of child process
2445           names and process IDs returned from WebKitTestRunner.
2446         (ServerProcess._start):
2447         - Clear self._child_processes.
2448         (ServerProcess.stop):
2449         - If self._child_processes is set, call
2450           self._port.check_for_leaks() for each child process.
2451
2452         * Scripts/webkitpy/port/server_process_unittest.py:
2453         (TrivialMockPort.check_for_leaks):
2454         - Rename redundant 'process_pid' argument to 'process_id'.
2455
2456         * Scripts/webkitpy/port/simulator_process.py:
2457         (SimulatorProcess.stop):
2458         - If self._child_processes is set, call
2459           self._port.check_for_leaks() for each child process.
2460
2461         * Scripts/webkitpy/port/watch_device.py:
2462         (WatchDevicePort.check_for_leaks):
2463         - Rename redundant 'process_pid' argument to 'process_id'.
2464
2465         * WebKitTestRunner/TestController.cpp:
2466         (WTR::TestController::dumpResponse):
2467         - Extract method from findAndDumpWorldLeaks() so that it may be
2468           reused by findAndDumpWebKitProcessIdentifiers().
2469         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2470         - Add method to output process name and process ID of both the
2471           WebContent and Networking processes.
2472         (WTR::TestController::findAndDumpWorldLeaks):
2473         - Fix missing newline in output when there were no abandoned
2474           documents.
2475         - Call dumpResponse() for extracted code.
2476         (WTR::TestController::handleControlCommand):
2477         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2478         - Use strncmp() instead of strcmp().
2479         - Call findAndDumpWebKitProcessIdentifiers() when
2480           "#LIST CHILD PROCESSES" command is sent.
2481         * WebKitTestRunner/TestController.h:
2482         (WTR::TestController::dumpResponse):
2483         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2484         - Declare methods.
2485
2486 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2487
2488         Unreviewed. Add GLib API test cases after r243434.
2489
2490         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2491         (testWebViewActiveURI):
2492         (serverCallback):
2493         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2494         (sendRequestCallback):
2495
2496 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2497
2498         Geolocation request not complete when watch request was started in a different web process
2499         https://bugs.webkit.org/show_bug.cgi?id=195996
2500
2501         Reviewed by Alex Christensen.
2502
2503         Add a test case.
2504
2505         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2506         (TestWebKitAPI::runJavaScriptAlert):
2507         (TestWebKitAPI::TEST):
2508
2509 2019-03-26  Keith Rollin  <krollin@apple.com>
2510
2511         Update the way generate-xcfilelists returns strings from functions
2512         https://bugs.webkit.org/show_bug.cgi?id=195975
2513         <rdar://problem/49040807>
2514
2515         Reviewed by Dean Jackson.
2516
2517         There are places where generate-xcfilelists executes assignments with
2518         statements like:
2519
2520             FOO=$(some_function)
2521
2522         where "some_function" return a string by echoing it. E.g.
2523
2524             some_function()
2525             {
2526                 echo "Hello, World"
2527             }
2528
2529         This is a common idiom, but it has a problem if "some_function" needs
2530         to call "exit" in an attempt to halt the entire script right then and
2531         there. Since "some_function" is called inside of $(), it's being
2532         executed in a sub-shell. Calling exit in that sub-shell simply exits
2533         that shell; it doesn't not exit the outer shell in which the main part
2534         of the script is still running. As such, the main script keeps
2535         executing when the intent was for the script to halt.
2536
2537         The solution to this is to use a different idiom for returning
2538         strings. The one we now is to pass in the name of the variable to
2539         receive the string result:
2540
2541             some_function()
2542             {
2543                 variable_name=$1
2544                 eval $variable_name ="Hello, World"
2545             }
2546
2547         The call site now looks like
2548
2549             some_function FOO
2550
2551         Because there's no invocation of a sub-shell, some_function can now
2552         call "exit" if it wants to, and the entire script will exit at that
2553         point.
2554
2555         * Scripts/generate-xcfilelists:
2556
2557 2019-03-26  Chris Dumez  <cdumez@apple.com>
2558
2559         Add basic layout test coverage for File Picker on iOS
2560         https://bugs.webkit.org/show_bug.cgi?id=196265
2561
2562         Reviewed by Wenson Hsieh.
2563
2564         Add layout test infrastructure to test the file picker on iOS.
2565
2566         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2567         (WTR::UIScriptController::dismissFilePicker):
2568         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2569         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2570         (WTR::UIScriptController::dismissFilePicker):
2571         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2572         * WebKitTestRunner/TestController.cpp:
2573         (WTR::TestController::createWebViewWithOptions):
2574         (WTR::updateTestOptionsFromTestHeader):
2575         * WebKitTestRunner/TestOptions.h:
2576         (WTR::TestOptions::hasSameInitializationOptions const):
2577         * WebKitTestRunner/ios/TestControllerIOS.mm:
2578         (overridePresentViewController):
2579         (WTR::TestController::platformInitialize):
2580         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2581         (WTR::UIScriptController::dismissFilePicker):
2582
2583 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2584
2585         Implement async paste method on UIWKInteractionViewProtocol
2586         https://bugs.webkit.org/show_bug.cgi?id=196267
2587         <rdar://problem/49236346>
2588
2589         Reviewed by Tim Horton.
2590
2591         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2592         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2593         are now a part of all iOS 12 internal SDKs.
2594
2595         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2596
2597         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2598         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2599
2600         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2601         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2602         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2603         * TestWebKitAPI/ios/UIKitSPI.h:
2604
2605 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2606
2607         [ews-build] Use PostgreSQL for ews.webkit.org database
2608         https://bugs.webkit.org/show_bug.cgi?id=196270
2609
2610         Reviewed by Lucas Forschler.
2611
2612         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2613
2614 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2615
2616         [ews] Reset simctl states on reboot
2617         https://bugs.webkit.org/show_bug.cgi?id=196260
2618
2619         Rubber-stamped by Aakash Jain.
2620
2621         * EWSTools/start-queue-mac.sh:
2622
2623 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2624
2625         [ews-build] Use PostgreSQL for ews-build database
2626         https://bugs.webkit.org/show_bug.cgi?id=196229
2627
2628         Reviewed by Lucas Forschler.
2629
2630         * BuildSlaveSupport/ews-build/master.cfg:
2631
2632 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2633
2634         [ews-build] Get master_hostname dynamically in master.cfg
2635         https://bugs.webkit.org/show_bug.cgi?id=196255
2636
2637         Reviewed by Lucas Forschler.
2638
2639         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2640         send events data in test mode.
2641
2642 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-app] Set db_constraint to False for Foreign Keys
2645         https://bugs.webkit.org/show_bug.cgi?id=196252
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * BuildSlaveSupport/ews-app/ews/models/build.py:
2650         * BuildSlaveSupport/ews-app/ews/models/step.py:
2651
2652 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2653
2654         [ews-build] is_test_mode_enabled should default to True
2655         https://bugs.webkit.org/show_bug.cgi?id=196248
2656
2657         Reviewed by Lucas Forschler.
2658
2659         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2660
2661 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2662
2663         [ews-app] Add webkitperl to ENABLED_QUEUES
2664         https://bugs.webkit.org/show_bug.cgi?id=196253
2665
2666         Reviewed by Lucas Forschler.
2667
2668         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2669
2670 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2671
2672         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2673         https://bugs.webkit.org/show_bug.cgi?id=196211
2674         rdar://problem/49110552
2675
2676         Reviewed by Tim Horton.
2677
2678         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2679         Make sure that EventSenderProxy always exists when running tests. We used to create
2680         it when resetting before the first test, which is a bit too late.
2681
2682         * WebKitTestRunner/TestController.h:
2683         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2684         (WTR::TestController::platformCreateWebView):
2685         (WTR::TestController::platformCreateOtherPage):
2686         (WTR::TestController::finishCreatingPlatformWebView):
2687         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2688         (WTR::PlatformWebView::PlatformWebView):
2689         Moved some code that made NSWindow use NSEvent during web view creation. We may
2690         need to move more if some other case us found, but this is enough for now.
2691
2692 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2693
2694         Unreviewed. Fix typo in GLib geolocation API after r243285.
2695
2696         gelocation -> geolocation.
2697
2698         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2699         (testGeolocationManagerWatchPosition):
2700
2701 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2702
2703         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2704         https://bugs.webkit.org/show_bug.cgi?id=196213
2705
2706         Reviewed by Geoff Garen.
2707
2708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2709         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2710         (credentialWithIdentityAndKeychainPath):
2711         (-[ChallengeDelegate webView:didFinishNavigation:]):
2712         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2713         (TestWebKitAPI::TEST):
2714
2715 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2716
2717         Expected shouldn't assume its contained types are copyable
2718         https://bugs.webkit.org/show_bug.cgi?id=195986
2719
2720         Reviewed by JF Bastien.
2721
2722         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2723         (TestWebKitAPI::NonCopyable::operator== const):
2724         (TestWebKitAPI::NonCopyable::operator!= const):
2725         (TestWebKitAPI::TEST):
2726
2727 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2728
2729         Remove some now-unnecessary dynamic class lookup
2730         https://bugs.webkit.org/show_bug.cgi?id=196237
2731
2732         Reviewed by Simon Fraser.
2733
2734         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2735         (makeRequest):
2736         (TEST):
2737
2738 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2739
2740         Unreviewed, rolling out r243450.
2741
2742         AppleWin and WinCairo port builds get broken.
2743
2744         Reverted changeset:
2745
2746         "Add test for fix of #196095"
2747         https://bugs.webkit.org/show_bug.cgi?id=196097
2748         https://trac.webkit.org/changeset/243450
2749
2750 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2751
2752         Unreviewed, rolling out r243465.
2753         https://bugs.webkit.org/show_bug.cgi?id=196226
2754
2755         the test doesn't build (Requested by thorton on #webkit).
2756
2757         Reverted changeset:
2758
2759         "Do not terminate the NetworkProcess if a third party
2760         application sends a NSCredential with a SecIdentityRef"
2761         https://bugs.webkit.org/show_bug.cgi?id=196213
2762         https://trac.webkit.org/changeset/243465
2763
2764 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2765
2766         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2767         https://bugs.webkit.org/show_bug.cgi?id=196213
2768
2769         Reviewed by Geoff Garen.
2770
2771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2772         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2773         (credentialWithIdentityAndKeychainPath):
2774         (-[ChallengeDelegate webView:didFinishNavigation:]):
2775         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2776         (TestWebKitAPI::TEST):
2777
2778 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-build] Gracefully handle missing patch_id in events
2781         https://bugs.webkit.org/show_bug.cgi?id=196216
2782
2783         Reviewed by Lucas Forschler.
2784
2785         * BuildSlaveSupport/ews-build/events.py:
2786
2787 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2788
2789         [ews-build] use lz4 compression for improving buildbot performance
2790         https://bugs.webkit.org/show_bug.cgi?id=196155
2791
2792         Reviewed by Lucas Forschler.
2793
2794         * BuildSlaveSupport/ews-build/master.cfg:
2795
2796 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2797
2798         Pull some API testing helper methods out of TestWKWebView
2799         https://bugs.webkit.org/show_bug.cgi?id=196212
2800
2801         Reviewed by Tim Horton.
2802
2803         Refactor some more API testing utility methods, so that they can be used in
2804         tests that do not use TestWKWebView.
2805
2806         * TestWebKitAPI/cocoa/TestWKWebView.h:
2807         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2808         (-[WKWebView loadTestPageNamed:]):
2809         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2810         (-[WKWebView synchronouslyLoadHTMLString:]):
2811         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2812         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2813         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2814         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2815         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2816
2817 2019-03-25  Jer Noble  <jer.noble@apple.com>
2818
2819         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2820         https://bugs.webkit.org/show_bug.cgi?id=196097
2821
2822         Reviewed by Eric Carlson.
2823
2824         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2825
2826         * DumpRenderTree/mac/DumpRenderTree.mm:
2827         (resetWebPreferencesToConsistentValues):
2828         * WebKitTestRunner/TestController.cpp:
2829         (WTR::TestController::resetPreferencesToConsistentValues):
2830
2831 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2832
2833         Pull IPadUserInterfaceSwizzler out into a separate header file
2834         https://bugs.webkit.org/show_bug.cgi?id=196193
2835
2836         Reviewed by Anders Carlsson.
2837
2838         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2839         be used in other API tests.
2840
2841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2842         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2843         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2844         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2845         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2846         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2847         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2848
2849 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2850
2851         Remove NavigatorContentUtils in WebCore/Modules
2852         https://bugs.webkit.org/show_bug.cgi?id=196070
2853
2854         Reviewed by Alex Christensen.
2855
2856         NavigatorContentUtils was to support the custom scheme spec [1].
2857         However, in WebKit side, no port has supported the feature in
2858         WebKit layer after EFL port was removed. So there has been the
2859         only IDL implementation of the NavigatorContentUtils in WebCore.
2860         So we don't need to keep the implementation in WebCore anymore.
2861
2862         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2863
2864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2865
2866 2019-03-24  Andy Estes  <aestes@apple.com>
2867
2868         [watchOS] Remove unused Proximity Networking code
2869         https://bugs.webkit.org/show_bug.cgi?id=196188
2870
2871         Reviewed by Tim Horton.
2872
2873         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2874         (TEST):
2875
2876 2019-03-23  Keith Miller  <keith_miller@apple.com>
2877
2878         Refactor clz/ctz and fix getLSBSet.
2879         https://bugs.webkit.org/show_bug.cgi?id=196162
2880
2881         Reviewed by Saam Barati.
2882
2883         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2884
2885         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2886         (TestWebKitAPI::TEST):
2887
2888 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2889
2890         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2891         https://bugs.webkit.org/show_bug.cgi?id=196143
2892
2893         Reviewed by Michael Catanzaro.
2894
2895         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2896         directories.
2897
2898         * Scripts/webkitpy/style/checkers/cpp.py:
2899         (check_identifier_name_in_declaration):
2900         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2901         (WebKitStyleTest.test_names):
2902
2903 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2904
2905         [Flatpak] Manifest expanding fails for qt WPE extension
2906         https://bugs.webkit.org/show_bug.cgi?id=196148
2907
2908         Reviewed by Alex Christensen.
2909
2910         * flatpak/flatpakutils.py:
2911         (expand_submodules_recurse): The last recurse manifest expand
2912         iteration might lead to a single module so take it into account
2913         and don't try to recurse further.
2914
2915 2019-03-22  Chris Dumez  <cdumez@apple.com>
2916
2917         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2918         https://bugs.webkit.org/show_bug.cgi?id=195348
2919         <rdar://problem/48622090>
2920
2921         Reviewed by Alex Christensen.
2922
2923         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2924         to NO when test.options().shouldIgnoreMetaViewport is false.
2925
2926         * WebKitTestRunner/ios/TestControllerIOS.mm:
2927         (WTR::TestController::platformConfigureViewForTest):
2928
2929 2019-03-22  Chris Dumez  <cdumez@apple.com>
2930
2931         Prewarmed processes should be usable with any website data store
2932         https://bugs.webkit.org/show_bug.cgi?id=196104
2933
2934         Reviewed by Alex Christensen.
2935
2936         Add API test coverage.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2939         (runInitialWarmedProcessUsedTest):
2940         (TEST):
2941
2942 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2943
2944         Back out local changes to Alex's Subversion working directory
2945
2946         They were accidentally committed.
2947
2948         * Scripts/webkitpy/common/system/abstractexecutive.py:
2949         (AbstractExecutive.wait_newest):
2950         * Scripts/webkitpy/common/system/executive.py:
2951         (Executive.running_pids):
2952         * Scripts/webkitpy/common/system/executive_mock.py:
2953         (MockExecutive.running_pids):
2954         * Scripts/webkitpy/common/system/executive_unittest.py:
2955         (ExecutiveTest.serial_test_running_pids):
2956         * Scripts/webkitpy/port/darwin.py:
2957         (DarwinPort.check_for_leaks):
2958         * Scripts/webkitpy/port/leakdetector.py:
2959         (LeakDetector.check_for_leaks):
2960         - This was the hack attached to Bug 193772.
2961
2962         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2963         (+[WebKitTestRunnerEvent mouseLocation]):
2964         - This works around a crash on an internal build.
2965
2966 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2967
2968         Fix the build after r243354
2969         https://bugs.webkit.org/show_bug.cgi?id=196138
2970         <rdar://problem/49145951>
2971
2972         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2973         (TEST):
2974         * TestWebKitAPI/ios/UIKitSPI.h:
2975
2976 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2977
2978         Adopt UIWKDocumentContext
2979         https://bugs.webkit.org/show_bug.cgi?id=196040
2980         <rdar://problem/48642440>
2981
2982         Reviewed by Ryosuke Niwa.
2983
2984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2985         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2986         (makeRequest):
2987         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2988         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2989         (applyStyle):
2990         (TEST):
2991         Add tests for UIWKDocumentContext.
2992
2993         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2994         (TEST):
2995         (recursiveFindWKContentView): Deleted.
2996         * TestWebKitAPI/cocoa/TestWKWebView.h:
2997         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2998         (recursiveFindWKContentView):
2999         (-[TestWKWebView wkContentView]):
3000         * TestWebKitAPI/ios/UIKitSPI.h:
3001         Share the WKContentView finding code between tests.
3002
3003 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3004
3005         [iOS WK2] Turn on async overflow scrolling by default
3006         https://bugs.webkit.org/show_bug.cgi?id=196011
3007         rdar://problem/48453859
3008
3009         Reviewed by Antti Koivisto.
3010         
3011         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3012         since so many basic layout tests have different results when compositing is triggered for
3013         overflow.
3014         
3015         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3016
3017         * WebKitTestRunner/TestController.cpp:
3018         (WTR::TestController::resetPreferencesToConsistentValues):
3019
3020 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3021
3022         [ews-build] Retry API test in case of failures
3023         https://bugs.webkit.org/show_bug.cgi?id=196004
3024
3025         Reviewed by Lucas Forschler.
3026
3027         * BuildSlaveSupport/ews-build/steps.py:
3028         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3029         (CompileWebKitToT.doStepIf): Ditto.
3030         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3031         (ReRunAPITests): Re-run API tests.
3032         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3033         (RunAPITestsWithoutPatch): Run API tests without patch.
3034         (RunAPITestsWithoutPatch.doStepIf):
3035         (RunAPITestsWithoutPatch.hideStepIf):
3036         (RunAPITestsWithoutPatch.evaluateCommand):
3037         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3038         (AnalyzeAPITestsResults.start):
3039         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3040         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3041         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3042         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3043
3044 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3045
3046         [ews-build] Update queues configurations
3047         https://bugs.webkit.org/show_bug.cgi?id=196074
3048
3049         Reviewed by Dewei Zhu.
3050
3051         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3052         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3053
3054 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3055
3056         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3057         https://bugs.webkit.org/show_bug.cgi?id=195680
3058         <rdar://problem/48903534>
3059
3060         Unreviewed infrastructure fix.
3061
3062         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3063         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3064
3065 2019-03-21  Andy Estes  <aestes@apple.com>
3066
3067         [iOS] Apple Pay should be available in documents with no user agent scripts
3068         https://bugs.webkit.org/show_bug.cgi?id=196061
3069         <rdar://problem/48649391>
3070
3071         Reviewed by Brady Eidson.
3072
3073         Added API tests and related infrastructure.
3074
3075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3076         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3077         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3078         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3079         (TestWebKitAPI::TEST):
3080         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3081         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3082         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3083         * TestWebKitAPI/cocoa/TestProtocol.mm:
3084         (-[TestProtocol startLoading]):
3085         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3086         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3087         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3088         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3089
3090 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3091
3092         REGRESSSION (r243297): webkitpy tests broken
3093         https://bugs.webkit.org/show_bug.cgi?id=196108
3094
3095         Reviewed by Aakash Jain.
3096
3097         r243297 updated contributors.json, which broke a few unit tests.
3098
3099         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3100         (IRCCommandTest.test_whois):
3101         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3102
3103 2019-03-21  Chris Dumez  <cdumez@apple.com>
3104
3105         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3106         https://bugs.webkit.org/show_bug.cgi?id=196041
3107         <rdar://problem/49083230>
3108
3109         Reviewed by Alex Christensen.
3110
3111         Add API test coverage.
3112
3113         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3114         (TEST):
3115
3116 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3117
3118         Add SPI to inform applications of WKContentRuleList actions
3119         https://bugs.webkit.org/show_bug.cgi?id=195965
3120         <rdar://problem/42664365>
3121
3122         Reviewed by Geoff Garen.
3123
3124         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3125         (TestWebKitAPI::allActionsForResourceLoad):
3126         (TestWebKitAPI::testRequest):
3127         (TestWebKitAPI::TEST_F):
3128         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3129         (Notification::description):
3130         (Notification::operator== const):
3131         (toVector):
3132         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3133         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3134         (makeContentRuleList):
3135         (TEST):
3136         (makeWarnContentRuleList): Deleted.
3137
3138 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3139
3140         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3141         https://bugs.webkit.org/show_bug.cgi?id=196088
3142
3143         Reviewed by Brian Burg.
3144
3145         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3146         Support checks when only one platform is specified. Also deprecate macosx() and
3147         force the use of macos() instead.
3148
3149         * Scripts/webkitpy/style/checkers/cpp.py:
3150         (check_min_versions_of_wk_api_available):
3151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3152         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3153
3154 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3155
3156         Update status inactive committers' status to 'contributor'.
3157
3158         * Scripts/webkitpy/common/config/contributors.json:
3159
3160 2019-03-21  Xan Lopez  <xan@igalia.com>
3161
3162         [JSC][x86] Drop support for x87 floating point
3163         https://bugs.webkit.org/show_bug.cgi?id=194853
3164
3165         Reviewed by Don Olmstead.
3166
3167         Force SSE2 on x86/32bit builds.
3168
3169         * Scripts/webkitdirs.pm:
3170         (generateBuildSystemFromCMakeProject):
3171
3172 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3173
3174         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3175         https://bugs.webkit.org/show_bug.cgi?id=196073
3176
3177         Reviewed by Michael Catanzaro.
3178
3179         Add test cases to check functions and constructors with no arguments but receiving user data.
3180
3181         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3182         (checkUserData):
3183         (testJSCFunction):
3184         (fooCreateWithUserData):
3185         (testJSCClass):
3186
3187 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3188
3189         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3190
3191         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3192
3193         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3194
3195 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3196
3197         [GTK][WPE] Add API to provide geolocation information
3198         https://bugs.webkit.org/show_bug.cgi?id=195940
3199
3200         Reviewed by Michael Catanzaro.
3201
3202         Add a new test to check the new API.
3203
3204         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3205         (testGeolocationManagerCurrentPosition):
3206         (testGeolocationManagerWatchPosition):
3207         (beforeAll):
3208         (afterAll):
3209         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3210         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3211         (beforeAll): Ditto.
3212         * TestWebKitAPI/glib/CMakeLists.txt:
3213
3214 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3215
3216         [GLib] Returning G_TYPE_OBJECT from a method does not work
3217         https://bugs.webkit.org/show_bug.cgi?id=195574
3218
3219         Reviewed by Michael Catanzaro.
3220
3221         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3222
3223         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3224         (getGFile):
3225         (getParent):
3226         (createGString):
3227         (getGString):
3228         (getGStringCopyWillRaise):
3229         (getGStringCopy):
3230         (getGStringStr):
3231         (getGStringLen):
3232         (freeGString):
3233         (testJSCClass):
3234
3235 2019-03-20  Saam Barati  <sbarati@apple.com>
3236
3237         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3238         https://bugs.webkit.org/show_bug.cgi?id=195721
3239
3240         Reviewed by Filip Pizlo.
3241
3242         * Scripts/run-javascriptcore-tests:
3243
3244 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3245
3246         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3247         https://bugs.webkit.org/show_bug.cgi?id=196049
3248
3249         Reviewed by Tim Horton.
3250
3251         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3252         overflow scrolling in general, so rename it.
3253
3254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3255
3256 2019-03-20  Daniel Bates  <dabates@apple.com>
3257
3258         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3259         https://bugs.webkit.org/show_bug.cgi?id=196031
3260         <rdar://problem/49078172>
3261
3262         Reviewed by Tim Horton.
3263
3264         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3265         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3266         same code path used when the Done button is pressed to dismiss the <select> picker.
3267
3268         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3269         (TestWebKitAPI::TEST):
3270
3271 2019-03-20  Chris Dumez  <cdumez@apple.com>
3272
3273         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3274         https://bugs.webkit.org/show_bug.cgi?id=196029
3275         <rdar://problem/48954651>
3276
3277         Reviewed by Tim Horton.
3278
3279         Add API test coverage.
3280
3281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3282
3283 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3284
3285         [ews-build] Improve failure summary string for ApplyPatch step
3286         https://bugs.webkit.org/show_bug.cgi?id=195995
3287
3288         Reviewed by Alexey Proskuryakov.
3289
3290         * BuildSlaveSupport/ews-build/steps.py:
3291         (ApplyPatch.getResultSummary): Override getResultSummary.
3292
3293 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3294
3295         AX: Implement support for new meter ARIA role
3296         https://bugs.webkit.org/show_bug.cgi?id=195966
3297
3298         Reviewed by Chris Fleizach.
3299
3300         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3301         to AXLevelIndicator.
3302
3303         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3304
3305 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3306
3307         [WebAuthN] Implement FIDO AppID extension
3308         https://bugs.webkit.org/show_bug.cgi?id=143491
3309         <rdar://problem/48298273>
3310
3311         Reviewed by Brent Fulgham.
3312
3313         Add a test that covers the new flag of convertToU2fSignCommand.
3314
3315         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3316         (TestWebKitAPI::TEST):
3317         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3318         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3319         (TestWebKitAPI::TEST):
3320
3321 2019-03-19  Keith Rollin  <krollin@apple.com>
3322
3323         Add support for more platforms to generate-xcfilelists
3324         https://bugs.webkit.org/show_bug.cgi?id=195977
3325
3326         Reviewed by Alexey Proskuryakov.
3327
3328         generate-xcfilelists incorrectly complains when involved with building
3329         WebKit for iphonesimulator:
3330
3331             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3332             …
3333             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3334
3335         Address this by teaching generate-xcfilelists about more platforms.
3336
3337         * Scripts/generate-xcfilelists:
3338
3339 2019-03-19  John Wilander  <wilander@apple.com>
3340
3341         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3342         https://bugs.webkit.org/show_bug.cgi?id=195923
3343         <rdar://problem/49001272>
3344
3345         Reviewed by Alex Christensen.
3346
3347         This patch does the following to the TestRunner:
3348         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3349         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3350         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3351
3352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3354         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3355         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3356         * WebKitTestRunner/TestController.cpp:
3357         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3358         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3359         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3360         * WebKitTestRunner/TestController.h:
3361         * WebKitTestRunner/TestInvocation.cpp:
3362         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3363
3364 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3365
3366         [CMake] Support more clang and gcc sanitizers
3367         https://bugs.webkit.org/show_bug.cgi?id=195956
3368
3369         Reviewed by Michael Catanzaro.
3370
3371         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3372
3373 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3374
3375         [ews-build] Improve summary for PrintConfiguration step
3376         https://bugs.webkit.org/show_bug.cgi?id=195945
3377
3378         Reviewed by Lucas Forschler.
3379
3380         * BuildSlaveSupport/ews-build/steps.py:
3381         (PrintConfiguration.getResultSummary): Override getResultSummary.
3382
3383 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-build] Improve summary for CheckOutSource step
3386         https://bugs.webkit.org/show_bug.cgi?id=195963
3387
3388         Reviewed by Lucas Forschler.
3389
3390         * BuildSlaveSupport/ews-build/steps.py:
3391         (CheckOutSource.getResultSummary):
3392
3393 2019-03-19  Daniel Bates  <dabates@apple.com>
3394
3395         [iOS] Focus not preserved when switching between tabs
3396         https://bugs.webkit.org/show_bug.cgi?id=195820
3397         <rdar://problem/43614450>
3398
3399         Reviewed by Brent Fulgham.
3400
3401         Add tests to ensure that we restore focus when resigning and becoming first responder.
3402
3403         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3404         (TestWebKitAPI::TEST):
3405
3406 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3407
3408         Make WTFLogChannelState and WTFLogLevel enum classes
3409         https://bugs.webkit.org/show_bug.cgi?id=195904
3410
3411         Reviewed by Eric Carlson.
3412
3413         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3414         (TestWebKitAPI::TEST_F):
3415
3416 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3417
3418         [GStreamer][EME] Backported mssdemux protection data crash fix
3419         https://bugs.webkit.org/show_bug.cgi?id=195918
3420
3421         Reviewed by Philippe Normand.
3422
3423         * gstreamer/jhbuild.modules:
3424         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3425
3426 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3427
3428         Unreviewed, rolling out r243132.
3429
3430         Broke GTK build
3431
3432         Reverted changeset:
3433
3434         "Make WTFLogChannelState and WTFLogLevel enum classes"
3435         https://bugs.webkit.org/show_bug.cgi?id=195904
3436         https://trac.webkit.org/changeset/243132
3437
3438 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3439
3440         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3441
3442         * Scripts/webkitdirs.pm:
3443         (builtDylibPathForName): Adjust the shared library name that's changed
3444         with the API version bump in r243073.
3445
3446 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3447
3448         Make WTFLogChannelState and WTFLogLevel enum classes
3449         https://bugs.webkit.org/show_bug.cgi?id=195904
3450
3451         Reviewed by Eric Carlson.
3452
3453         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3454         (TestWebKitAPI::TEST_F):
3455
3456 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3457
3458         Disable flaky test added in r2431100
3459         https://webkit.org/b/195785
3460
3461         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3462         (TestWebKitAPI::TEST):
3463         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3464
3465 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3466
3467         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3468         https://bugs.webkit.org/show_bug.cgi?id=195916
3469
3470         Reviewed by Tim Horton.
3471
3472         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3473         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3474
3475 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3476
3477         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3478
3479         * Scripts/webkitpy/common/config/contributors.json:
3480
3481 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3482
3483         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3484         https://bugs.webkit.org/show_bug.cgi?id=195785
3485
3486         Reviewed by Geoffrey Garen.
3487
3488         * TestWebKitAPI/TCPServer.cpp: Added.
3489         (TestWebKitAPI::TCPServer::TCPServer):
3490         (TestWebKitAPI::TCPServer::~TCPServer):
3491         (TestWebKitAPI::TCPServer::socketBindListen):
3492         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3493         * TestWebKitAPI/TCPServer.h: Added.
3494         (TestWebKitAPI::TCPServer::port const):
3495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3496         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3497         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3498         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3499         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3500         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3501         (TestWebKitAPI::respondSlowly):
3502         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3503         (TestWebKitAPI::downloadAtRate):
3504         (TestWebKitAPI::TEST):
3505
3506 2019-03-18  Saam Barati  <sbarati@apple.com>
3507
3508         Add a plan file for JetStream 2
3509         https://bugs.webkit.org/show_bug.cgi?id=190734
3510
3511         Reviewed by Mark Lam.
3512
3513         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3514
3515 2019-03-18  Chris Dumez  <cdumez@apple.com>
3516
3517         Delay WebProcess launch until a load is triggered in a Web view
3518         https://bugs.webkit.org/show_bug.cgi?id=195758
3519         <rdar://problem/48126013>
3520
3521         Reviewed by Geoff Garen.
3522
3523         Add API test coverage. Also update some existing API tests to not expect
3524         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3525
3526         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3527         (TestWebKitAPI::TEST):
3528         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3529         (TestWebKitAPI::TEST):
3530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3531         (TEST):
3532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3533         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3534         (TEST):
3535         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3536         (TEST):
3537         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3538
3539 2019-03-18  Xan Lopez  <xan@igalia.com>
3540
3541         [CMake] Prevent potential warning when determining $architecture
3542         https://bugs.webkit.org/show_bug.cgi?id=195891
3543
3544         Reviewed by Michael Catanzaro.
3545
3546         It's possible for generateBuildSystemForCMakeProject to be called
3547         before determineArchitecture() is ever called. This will make the
3548         first eq check with $architecture to be bogus (and print a
3549         warning). Change that to an eq check with architecture(), which
3550         implicitly calls determineArchitecture() if needed, and change all
3551         the other similar cases in the method in the same way to prevent
3552         future bugs like this one.
3553
3554         * Scripts/webkitdirs.pm:
3555         (generateBuildSystemFromCMakeProject):
3556
3557 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3558
3559         [WPE] Tarballs generated with “make dist” cannot build documentation
3560         https://bugs.webkit.org/show_bug.cgi?id=195885
3561
3562         Reviewed by Carlos Garcia Campos.
3563
3564         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3565
3566 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3567
3568         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3569         https://bugs.webkit.org/show_bug.cgi?id=195883
3570
3571         Reviewed by Carlos Garcia Campos.
3572
3573         * gtkdoc/gtkdoc.py:
3574         (GTKDoc._run_command): When commands fail to run, include the full command line for
3575         the program invocation and the output it has generated on the standard error stream.
3576
3577 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3578
3579         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3580         https://bugs.webkit.org/show_bug.cgi?id=195786
3581
3582         Reviewed by Philippe Normand.
3583
3584         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3585         * wpe/jhbuild.modules: Ditto.
3586
3587 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3588
3589         [ews-build] Don't run clean builds on EWS builders
3590         https://bugs.webkit.org/show_bug.cgi?id=195851
3591
3592         Reviewed by Geoffrey Garen.
3593
3594         * BuildSlaveSupport/ews-build/factories.py:
3595
3596 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3597
3598         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3599         https://bugs.webkit.org/show_bug.cgi?id=195849
3600
3601         Reviewed by Chris Dumez.
3602
3603         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3606         (runWebsiteDataStoreCustomPaths):
3607
3608 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3609
3610         webkitpy: Upload test results
3611         https://bugs.webkit.org/show_bug.cgi?id=195755
3612         <rdar://problem/48896182>
3613
3614         Reviewed by Aakash Jain.
3615
3616         Establish a new format for uploading results that is not tied to layout tests, apply
3617         that format to webkitpy tests.
3618
3619         * Scripts/webkitpy/common/checkout/scm/git.py:
3620         (Git.native_branch): Return what branch the current checkout is on.
3621         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3622         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3623         * Scripts/webkitpy/common/checkout/scm/svn.py:
3624         (SVN.native_branch): Ditto.
3625         * Scripts/webkitpy/common/system/platforminfo.py:
3626         (PlatformInfo.build_version): Return a build version for Mac.
3627         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3628         (MockPlatformInfo.__init__):
3629         (MockPlatformInfo.build_version):
3630         * Scripts/webkitpy/results: Added.
3631         * Scripts/webkitpy/results/__init__.py: Added.
3632         * Scripts/webkitpy/results/options.py: Added.
3633         (upload_options): OptParse list for upload options.
3634         * Scripts/webkitpy/results/upload.py: Added.
3635         (Upload): Class which enforces the upload format expected by the results server.
3636         (Upload.Expectations):
3637         (Upload.create_configuration):
3638         (Upload.create_commit):
3639         (Upload.create_details):
3640         (Upload.create_run_stats):
3641         (Upload.create_test_result):
3642         (Upload.__init__):
3643         (Upload.Encoder): Encode Upload object as json.
3644         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3645         * Scripts/webkitpy/results/upload_unittest.py: Added.
3646         * Scripts/webkitpy/test/main.py:
3647         (Tester._parse_args): Add upload arguments.
3648         (Tester._run_tests): Allow results to be uploaded.
3649         * Scripts/webkitpy/test/runner.py:
3650         (Runner.__init__): Record which tests were run, rather than just counting them.
3651         (Runner.handle):
3652         * Scripts/webkitpy/test/runner_unittest.py:
3653         (RunnerTest.test_run):
3654         * Scripts/webkitpy/thirdparty/__init__.py:
3655         (AutoinstallImportHook.find_module): Add requests auto-install.
3656         (AutoinstallImportHook._install_requests):
3657         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3658         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3659
3660 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3661
3662         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3663         https://bugs.webkit.org/show_bug.cgi?id=195810
3664
3665         Reviewed by Tim Horton.
3666
3667         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3668         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3669         ending certain layout tests.
3670
3671         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3672         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3673         (-[TestRunnerWKWebView dealloc]):
3674         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3675
3676         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3677         helper method when destroying the web view, and when resetting state between tests.
3678
3679         * WebKitTestRunner/ios/TestControllerIOS.mm:
3680         (WTR::TestController::platformResetStateToConsistentValues):
3681
3682         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3683
3684 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3685
3686         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3687         https://bugs.webkit.org/show_bug.cgi?id=190350
3688         <rdar://problem/45089503>
3689
3690         Reviewed by Geoffrey Garen.
3691
3692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3693         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3694         (TEST):
3695         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3696         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3697         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3698         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3699         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3700         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3701         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3702         (runTest):
3703         (createDirectories):
3704         (TEST):
3705         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3706         (TEST):
3707         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3708         (TEST):
3709
3710 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3711
3712         Add support to WebPage for getting the contents as an attributed string.
3713         https://bugs.webkit.org/show_bug.cgi?id=195636
3714         rdar://problem/45055697
3715
3716         Reviewed by Tim Horton.
3717
3718         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3719         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3720
3721 2019-03-15  Chris Dumez  <cdumez@apple.com>
3722
3723         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3724         https://bugs.webkit.org/show_bug.cgi?id=195747
3725
3726         Reviewed by Geoff Garen.
3727
3728         Add API test coverage.
3729
3730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3731
3732 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3733
3734         Unreviewed, rolling out r242952.
3735
3736         Causing API failures on iOS Simulator
3737
3738         Reverted changeset:
3739
3740         "[PSON] Make sure the WebProcessCache is leverage when
3741         relaunching a process after termination"
3742         https://bugs.webkit.org/show_bug.cgi?id=195747
3743         https://trac.webkit.org/changeset/242952
3744
3745 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3746
3747         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3748         https://bugs.webkit.org/show_bug.cgi?id=195740
3749
3750         Reviewed by Ross Kirsling.
3751
3752         window.open doesn't work for WebKitBrowserWindow because it is not
3753         implemented yet.
3754
3755         1. Implemented createNewPage callback of WKPageUIClient.
3756         2. Changed MainWindow to take a BrowserWindow factory function
3757           instead of BrowserWindowType to be flexible to create
3758           BrowserWindow with extra settings.
3759         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3760           because it is not relevant with MainWindow anymore.
3761
3762         * MiniBrowser/win/Common.cpp:
3763         (parseCommandLine):
3764         * MiniBrowser/win/Common.h:
3765         (CommandLineOptions::CommandLineOptions):
3766         * MiniBrowser/win/MainWindow.cpp:
3767         (MainWindow::MainWindow):
3768         (MainWindow::create):
3769         (MainWindow::init):
3770         (MainWindow::WndProc):
3771         * MiniBrowser/win/MainWindow.h:
3772         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3773         (PrintWebUIDelegate::createWebViewWithRequest):
3774         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3775         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3776         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3777         (WebKitBrowserWindow::updateProxySettings):
3778         (WebKitBrowserWindow::createNewPage):
3779         * MiniBrowser/win/WebKitBrowserWindow.h:
3780         * MiniBrowser/win/WinMain.cpp:
3781         (wWinMain):
3782
3783 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3784
3785         Make it possible to test scrolling tree layer manipulation more easily
3786         https://bugs.webkit.org/show_bug.cgi?id=195780
3787
3788         Reviewed by Tim Horton.
3789         
3790         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3791         cuts off communication of scrolling tree scrolls back to the web process
3792         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3793         allows tests to trigger scrolls which run the scrolling tree layer positioning
3794         logic, but never get another commit from the web process that might mask
3795         scrolling tree bugs.
3796         
3797         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3798         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3799         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3800
3801         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3802         (WTR::UIScriptController::scrollUpdatesDisabled const):
3803         (WTR::UIScriptController::setScrollUpdatesDisabled):
3804         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3805         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3806         (WTR::UIScriptController::scrollUpdatesDisabled const):
3807         (WTR::UIScriptController::setScrollUpdatesDisabled):
3808         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3809         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3810         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3811         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3812         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3813         * WebKitTestRunner/ios/TestControllerIOS.mm:
3814         (WTR::TestController::platformResetStateToConsistentValues):
3815         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3816         (WTR::UIScriptController::scrollUpdatesDisabled const):
3817         (WTR::UIScriptController::setScrollUpdatesDisabled):
3818
3819 2019-03-14  Youenn Fablet  <youenn@apple.com>
3820
3821         Move IDB storage in private browsing mode to NetworkProcess
3822         https://bugs.webkit.org/show_bug.cgi?id=195602
3823
3824         Reviewed by Brady Eidson.
3825
3826         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3827         (TEST):
3828
3829 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3830
3831         [ews-build] Make descriptionDone messages more readable
3832         https://bugs.webkit.org/show_bug.cgi?id=195760
3833
3834         Reviewed by Lucas Forschler.
3835
3836         * BuildSlaveSupport/ews-build/steps.py:
3837         * BuildSlaveSupport/ews-build/steps_unittest.py:
3838
3839 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3840
3841         [ews-build] Generate status-bubble hover-over messages
3842         https://bugs.webkit.org/show_bug.cgi?id=195680
3843
3844         Reviewed by Lucas Forschler.
3845
3846         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3847         (StatusBubble):
3848         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3849         on hover-over.
3850         (StatusBubble._iso_time):
3851         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3852         hover-over message.
3853         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3854
3855 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3856
3857         [ews-app] Gracefully handle the case when state_string is None
3858         https://bugs.webkit.org/show_bug.cgi?id=195753
3859
3860         Reviewed by Lucas Forschler.
3861
3862         * BuildSlaveSupport/ews-app/ews/models/build.py:
3863         * BuildSlaveSupport/ews-app/ews/models/step.py:
3864
3865 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3866
3867         [ews-app] Status bubble display pending for currently running build step
3868         https://bugs.webkit.org/show_bug.cgi?id=195744
3869
3870         Reviewed by Lucas Forschler.
3871
3872         * BuildSlaveSupport/ews-build/events.py:
3873         (Events.stepStarted): If state_string is pending, replace it with step name.
3874
3875 2019-03-14  Chris Dumez  <cdumez@apple.com>
3876
3877         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3878         https://bugs.webkit.org/show_bug.cgi?id=195750
3879
3880         Reviewed by Geoffrey Garen.
3881
3882         Add API test coverage.
3883
3884         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3885         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3886         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3887         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3888
3889 2019-03-14  Chris Dumez  <cdumez@apple.com>
3890
3891         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3892         https://bugs.webkit.org/show_bug.cgi?id=195747
3893
3894         Reviewed by Geoff Garen.
3895
3896         Add API test coverage.
3897
3898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3899
3900 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3901
3902         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3903         https://bugs.webkit.org/show_bug.cgi?id=195725
3904         <rdar://problem/48545062>
3905
3906         Reviewed by Tim Horton.
3907
3908         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3909         handler is nil.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3912         (TestWebKitAPI::TEST):
3913
3914 2019-03-13  Sam Weinig  <sam@webkit.org>
3915
3916         Add utility function to allow easy reverse range-based iteration of a container
3917         https://bugs.webkit.org/show_bug.cgi?id=195542
3918
3919         Reviewed by Antti Koivisto.
3920
3921         * TestWebKitAPI/CMakeLists.txt:
3922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3923         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3924         (TestWebKitAPI::TEST):
3925         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3926
3927 2019-03-13  Chris Dumez  <cdumez@apple.com>
3928
3929         Use a ServiceWorker process per registrable domain
3930         https://bugs.webkit.org/show_bug.cgi?id=195649
3931
3932         Reviewed by Youenn Fablet.
3933
3934         Update API test coverage.
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3937
3938 2019-03-13  Chris Dumez  <cdumez@apple.com>
3939
3940         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3941         https://bugs.webkit.org/show_bug.cgi?id=195684
3942         <rdar://problem/48294714>
3943
3944         Reviewed by Antti Koivisto.
3945
3946         Add API test coverage.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3949
3950 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3951
3952         [ews-app] Remove unused patch view
3953         https://bugs.webkit.org/show_bug.cgi?id=195669
3954
3955         Reviewed by Lucas Forschler.
3956
3957         * BuildSlaveSupport/ews-app/ews/urls.py:
3958         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3959
3960 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3961
3962         [ews-app] Use Buildbot result code variables
3963         https://bugs.webkit.org/show_bug.cgi?id=195668
3964
3965         Reviewed by Alexey Proskuryakov.
3966
3967         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3968         (Buildbot): Added Buildbot result code variables.
3969         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3970         (StatusBubble._build_bubble): Used Buildbot result code variables.
3971
3972 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3973
3974         [Flatpak] Expand submodule recursively
3975         https://bugs.webkit.org/show_bug.cgi?id=195672
3976
3977         Building WPE with flatpak was impossible without that as it was raising an exception.
3978         Also update wpebackend-fdo to match what is built in jhbuild
3979
3980         Reviewed by Philippe Normand.
3981
3982         * flatpak/flatpakutils.py:
3983         (expand_submodules_recurse):
3984         (expand_manifest):
3985         * flatpak/org.webkit.WPEModules.yaml:
3986
3987 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3988
3989         [ews-app] status bubble should be hidden for certain builds
3990         https://bugs.webkit.org/show_bug.cgi?id=194597
3991
3992         Reviewed by Dewei Zhu.
3993
3994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3995         (StatusBubble._build_bubble):
3996         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3997         because the patch didn't have relevant changes.
3998         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3999         in production yet.
4000
4001 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4002
4003         [Win] Fix a slew of simple clang-cl warnings.
4004         https://bugs.webkit.org/show_bug.cgi?id=195652
4005
4006         Reviewed by Don Olmstead.
4007
4008         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4009         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4010
4011 2019-03-12  Justin Fan  <justin_fan@apple.com>
4012
4013         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4014         https://bugs.webkit.org/show_bug.cgi?id=195518
4015         <rdar://problem/46322356>
4016
4017         Reviewed by Myles C. Maxfield.
4018
4019         * DumpRenderTree/DerivedSources-input.xcfilelist:
4020         * DumpRenderTree/DerivedSources-output.xcfilelist:
4021
4022 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4023
4024         Unreviewed, rolling out r242825.
4025         https://bugs.webkit.org/show_bug.cgi?id=195648
4026
4027         "Broke webkitpy tests with my change to
4028         lldb_dump_class_layout.py" (Requested by rmorisset on
4029         #webkit).
4030
4031         Reverted changeset:
4032
4033         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4034         classes with suspicious padding"
4035         https://bugs.webkit.org/show_bug.cgi?id=195573
4036         https://trac.webkit.org/changeset/242825
4037
4038 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4039
4040         [ews-build] Show status bubbles while the patch is waiting in queue
4041         https://bugs.webkit.org/show_bug.cgi?id=195618
4042
4043         Reviewed by Lucas Forschler.
4044
4045         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4046         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4047         enabled in initial deployment.
4048         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4049         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4050         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4051         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4052         (StatusBubble._build_bubbles_for_patch):
4053
4054 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4055
4056         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4057         https://bugs.webkit.org/show_bug.cgi?id=195573
4058
4059         Reviewed by Simon Fraser.
4060
4061         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4062
4063         * Scripts/dump-class-layout:
4064         (main):
4065         * lldb/lldb_dump_class_layout.py:
4066         (ClassLayout.__init__):
4067         (ClassLayout._compute_padding_recursive):
4068         (LLDBDebuggerInstance.dump_layout_for_classname):
4069         (LLDBDebuggerInstance):
4070         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4071         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4072
4073 2019-03-12  Chris Dumez  <cdumez@apple.com>
4074
4075         Device Orientation access permission should be denied unless explicitly granted by the client
4076         https://bugs.webkit.org/show_bug.cgi?id=195625
4077
4078         Reviewed by Youenn Fablet.
4079
4080         add API test coverage.
4081
4082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4083         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4084         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4085         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4086         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4087         (runDeviceOrientationTest):
4088         (TEST):
4089         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4090         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4091
4092 2019-03-12  Jer Noble  <jer.noble@apple.com>
4093
4094         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4095         https://bugs.webkit.org/show_bug.cgi?id=195137
4096         <rdar://problem/48810307>
4097
4098         Reviewed by Eric Carlson.
4099
4100         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4101         (TestWebKitAPI::TEST):
4102
4103 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4104
4105         [ews-build] Change urls from uat to production
4106         https://bugs.webkit.org/show_bug.cgi?id=195566
4107
4108         Reviewed by Lucas Forschler.
4109
4110         * BuildSlaveSupport/ews-app/ews/config.py:
4111         * BuildSlaveSupport/ews-build/events.py:
4112         * BuildSlaveSupport/ews-build/steps.py:
4113
4114 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4115
4116         [ews-build] change max_builds for local-worker to 1
4117         https://bugs.webkit.org/show_bug.cgi?id=195568
4118
4119         Reviewed by Lucas Forschler.
4120
4121         * BuildSlaveSupport/ews-build/loadConfig.py:
4122
4123 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4124
4125         Fix the build
4126
4127         * TestRunnerShared/spi/PencilKitTestSPI.h:
4128         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4129
4130 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4131
4132         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4133         https://bugs.webkit.org/show_bug.cgi?id=194131
4134
4135         Reviewed by Michael Catanzaro.
4136
4137         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4138         (uriChanged):
4139         (testUnfinishedSubresourceLoad):
4140         (serverCallback):
4141         (beforeAll):
4142
4143 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4144
4145         WTF::Expected should use std::addressof instead of operator&
4146         https://bugs.webkit.org/show_bug.cgi?id=195604
4147
4148         Reviewed by Myles Maxfield.
4149
4150         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4151         (TestWebKitAPI::Unique::Unique):
4152         (TestWebKitAPI::Unique::operator&):
4153         (TestWebKitAPI::TEST):
4154
4155 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4156
4157         Add Optional to Forward.h.
4158         https://bugs.webkit.org/show_bug.cgi?id=195586
4159
4160         Reviewed by Darin Adler.
4161
4162         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4163         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4164         Remove unnecessary includes from headers.
4165
4166 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4167
4168         Add testing API to hit-test and scroll overflow scrollers
4169         https://bugs.webkit.org/show_bug.cgi?id=195278
4170
4171         Reviewed by Antti Koivisto.
4172         
4173         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4174         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4175         
4176         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4177
4178         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4179         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4180         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4181         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4182         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4183         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4184         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4185         (WTR::enclosingScrollViewIncludingSelf):
4186         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4187
4188 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4189
4190         API test WebKit.RequestTextInputContext fails on iOS
4191         https://bugs.webkit.org/show_bug.cgi?id=195585
4192
4193         Reviewed by Wenson Hsieh and Simon Fraser.
4194
4195         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4196         (applyStyle):
4197         (TEST):
4198         Add a viewport, so that the coordinates match up on iOS.
4199         Scroll by moving the UIScrollView's contentOffset.
4200
4201 2019-03-11  Chris Dumez  <cdumez@apple.com>
4202
4203         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4204         https://bugs.webkit.org/show_bug.cgi?id=195506
4205         <rdar://problem/48733477>
4206
4207         Reviewed by Alex Christensen.
4208
4209         Add API test coverage.
4210
4211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4212
4213 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4214
4215         Adding myself to contributors.json
4216
4217         Unreviewed, addming myself to contributors.json .
4218
4219         * Scripts/webkitpy/common/config/contributors.json:
4220
4221 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4222
4223         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4224         https://bugs.webkit.org/show_bug.cgi?id=195511
4225         <rdar://problem/44873269>
4226
4227         Reviewed by Darin Adler.
4228
4229         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4230         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4231         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4232         (TEST_F):
4233
4234 2019-03-11  Chris Dumez  <cdumez@apple.com>
4235
4236         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4237         https://bugs.webkit.org/show_bug.cgi?id=195561
4238
4239         Reviewed by Youenn Fablet.
4240
4241         Make sure the JS in the test requests for permission to receive device orientation events.
4242
4243         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4244
4245 2019-03-11  Youenn Fablet  <youenn@apple.com>
4246
4247         Allow storage quota increase by default in WTR
4248         https://bugs.webkit.org/show_bug.cgi?id=195541
4249
4250         Reviewed by Geoffrey Garen.
4251
4252         Allow storage quota increase by default in WTR.
4253         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4254         Use this for tests that explicitly need cache increase.
4255
4256         Instead of increasing quota by 2, make sure the next request is
4257         granted by adding all given parameters.
4258
4259         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4261         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4262         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4264         * WebKitTestRunner/TestController.cpp:
4265         (WTR::TestController::setAllowStorageQuotaIncrease):
4266         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4267         * WebKitTestRunner/TestController.h:
4268         * WebKitTestRunner/TestInvocation.cpp:
4269         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4270         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4271         (WTR::TestController::cocoaResetStateToConsistentValues):
4272         (WTR::TestController::setAllowStorageQuotaIncrease):
4273         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4274         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4275         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4276
4277 2019-03-11  Xan Lopez  <xan@igalia.com>
4278
4279         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
4280         https://bugs.webkit.org/show_bug.cgi?id=194147
4281
4282         Reviewed by Michael Saboff.
4283
4284         To make --32-bit work correctly on Linux/64bit we need to:
4285
4286         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
4287         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
4288         unfortunately CMake only allows us to do this during
4289         crosscompilation, which is overkill here.
4290         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
4291         pkg-config detection module uses the x86 .pc files instead of the
4292         x86_64 ones.
4293         - Set the -m32 flags for the compiler.
4294
4295         * Scripts/webkitdirs.pm:
4296         (generateBuildSystemFromCMakeProject):
4297
4298 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
4299
4300         Add MotionMark-1.1 plan file for run-benchmark script.
4301         https://bugs.webkit.org/show_bug.cgi?id=195481
4302
4303         Rubber-stamped by Darin Adler.
4304
4305         Run-benchmark script should support MontionMark-1.1.
4306
4307         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
4308
4309 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
4310
4311         [ews-app] Add support for submit-to-ews url
4312         https://bugs.webkit.org/show_bug.cgi?id=195477
4313
4314         Reviewed by Lucas Forschler.
4315
4316         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4317         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4318         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
4319         * BuildSlaveSupport/ews-app/ews/urls.py:
4320         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.