Unreviewed fix for API test failure after r240437.
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2
3         Unreviewed fix for API test failure after r240437.
4
5         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
6
7         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
8
9 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
10
11         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
12         https://bugs.webkit.org/show_bug.cgi?id=193787
13         <rdar://problem/47497634>
14
15         Reviewed by Alexey Proskuryakov.
16
17         * Scripts/webkitdirs.pm:
18         (iosSimulatorApplicationsPath): Pick from available runtime directories.
19
20 2019-01-24  Truitt Savell  <tsavell@apple.com>
21
22         Unreviewed, rolling out r240446.
23
24         Casued 5 API failures
25
26         Reverted changeset:
27
28         "Activate the WebResourceLoadStatisticsStore in the
29         NetworkProcess and deactivate it in the UIProcess."
30         https://bugs.webkit.org/show_bug.cgi?id=193297
31         https://trac.webkit.org/changeset/240446
32
33 2019-01-24  Zalan Bujtas  <zalan@apple.com>
34
35         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
36         https://bugs.webkit.org/show_bug.cgi?id=193741
37         <rdar://problem/47135030>
38
39         Reviewed by Antti Koivisto and Simon Fraser.
40
41         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
42         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
43         (TestWebKitAPI::TEST):
44
45 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
46
47         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
48         https://bugs.webkit.org/show_bug.cgi?id=193297
49         <rdar://problem/47158841>
50
51         Reviewed by Alex Christensen.
52
53         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
54         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
55         activating the message used to trigger the callback when it is set.
56
57 2019-01-24  John Wilander  <wilander@apple.com>
58
59         Add Ad Click Attribution as an internal/experimental feature
60         https://bugs.webkit.org/show_bug.cgi?id=193685
61         <rdar://problem/47450399>
62
63         Reviewed by Brent Fulgham.
64
65         Added test option adClickAttributionEnabled.
66
67         * DumpRenderTree/TestOptions.cpp:
68         (TestOptions::TestOptions):
69         * DumpRenderTree/TestOptions.h:
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (setWebPreferencesForTestOptions):
72
73 2019-01-24  Antti Koivisto  <antti@apple.com>
74
75         [PSON] Flash on back navigation on Mac
76         https://bugs.webkit.org/show_bug.cgi?id=193716
77         <rdar://problem/47148458>
78
79         Reviewed by Chris Dumez.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
82
83         Closing of the previous page is delayed so waiting for didFinishNavigation is
84         not sufficient to guarantee we have received all the messages. Wait for them.
85
86 2019-01-24  Chris Dumez  <cdumez@apple.com>
87
88         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
89         https://bugs.webkit.org/show_bug.cgi?id=193761
90         <rdar://problem/47456405>
91
92         Reviewed by Alex Christensen.
93
94         Add API test coverage.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
97
98 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
99
100         webkitpy: Missing PID in crashlog name should not be fatal
101         https://bugs.webkit.org/show_bug.cgi?id=193771
102
103         If we can't determine the PID of a crashlog, just ignore the crashlog instead
104         of raising an exception.
105
106         Reviewed by Lucas Forschler.
107
108         * Scripts/webkitpy/port/darwin.py:
109         (DarwinPort._merge_crash_logs):
110
111 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
112
113         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
114         https://bugs.webkit.org/show_bug.cgi?id=193746
115
116         Reviewed by Youenn Fablet.
117
118         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
119         so we'd best just not call it.
120
121         * Scripts/webkitpy/w3c/test_exporter.py:
122         (WebPlatformTestExporter.create_branch_with_patch):
123
124 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
125
126         Move FileSystem to WTF
127         https://bugs.webkit.org/show_bug.cgi?id=193602
128
129         Reviewed by Yusuke Suzuki.
130
131         * DumpRenderTree/win/DumpRenderTree.cpp:
132         * TestWebKitAPI/CMakeLists.txt:
133         * TestWebKitAPI/PlatformGTK.cmake:
134         * TestWebKitAPI/PlatformJSCOnly.cmake:
135         * TestWebKitAPI/PlatformPlayStation.cmake:
136         * TestWebKitAPI/PlatformWPE.cmake:
137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
138         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
139         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
140         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
141         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
142         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
143         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
144         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
145         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
146         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
147
148 2019-01-24  Philippe Normand  <pnormand@igalia.com>
149
150         [WPE] Remove hard dependency on subprocess32 for the API tests
151
152         Rubber-stamped by Carlos Garcia Campos.
153
154         * glib/api_test_runner.py:
155         (TestRunner._run_test_qt): Lazily import subprocess32 and check
156         its presence only when running WPEQt tests.
157
158 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
159
160         [GLIB] Expose JavaScriptCore options in GLib public API
161         https://bugs.webkit.org/show_bug.cgi?id=188742
162
163         Reviewed by Michael Catanzaro.
164
165         Add a test for the new API.
166
167         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
168         (testsJSCOptions):
169         (main):
170
171 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         [GTK][WPE] Support JPEG 2000 images
174         https://bugs.webkit.org/show_bug.cgi?id=186272
175
176         Reviewed by Žan Doberšek.
177
178         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
179
180         * gtk/jhbuild.modules:
181         * wpe/jhbuild.modules:
182
183 2019-01-23  David Kilzer  <ddkilzer@apple.com>
184
185         check-webkit-style should warn when using soft-linking macros in a header
186         <https://webkit.org/b/193750>
187
188         Reviewed by Darin Adler.
189
190         * Scripts/webkitpy/style/checkers/cpp.py:
191         (check_language): Add softlink/header check by refactoring the
192         softlink/framework check.
193         (CppChecker): Enable softlink/header check by default.
194         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
195         (CppStyleTest.test_softlink_framework): Rename from
196         CppStyleTest.test_softlink() and change test framework name in
197         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
198         files. Set file_name for macros that only appear in headers.
199         (CppStyleTest.test_softlink_header): Add tests for using
200         soft-link macros in headers.
201
202 2019-01-23  Chris Dumez  <cdumez@apple.com>
203
204         Deprecate API to limit the maximum number of WebProcesses
205         https://bugs.webkit.org/show_bug.cgi?id=193725
206         <rdar://problem/47464879>
207
208         Reviewed by Geoff Garen.
209
210         Update existing API tests to stop using deprecated API.
211
212         * MiniBrowser/mac/AppDelegate.m:
213         (defaultConfiguration):
214         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
219         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
220         (TEST):
221         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
222         (TEST):
223
224 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
225
226         [ews-app] Rename ews model buildermappings to buildermapping
227         https://bugs.webkit.org/show_bug.cgi?id=193729
228
229         Reviewed by Lucas Forschler.
230
231         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
232         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
233         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
234
235 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
236
237         [ews-app] Rename ews model steps to step
238         https://bugs.webkit.org/show_bug.cgi?id=193697
239
240         Reviewed by Lucas Forschler.
241
242         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
243         (Step): Renamed Steps to Step.
244
245 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
246
247         Clean up IndexedDB files between tests
248         https://bugs.webkit.org/show_bug.cgi?id=192796
249         <rdar://problem/46824999>
250
251         Reviewed by Geoffrey Garen.
252
253         * DumpRenderTree/mac/DumpRenderTree.mm:
254         (runTest):
255         * WebKitTestRunner/TestController.cpp:
256         (WTR::TestController::resetStateToConsistentValues):
257         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
258         (WTR::RemoveAllIndexedDatabasesCallback):
259         (WTR::TestController::ClearIndexedDatabases):
260         * WebKitTestRunner/TestController.h:
261         * WebKitTestRunner/TestInvocation.cpp:
262         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
263
264 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
265
266         [ews-app] Rename ews model Builds to Build
267         https://bugs.webkit.org/show_bug.cgi?id=193695
268
269         Reviewed by Lucas Forschler.
270
271         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
272         (Build): Renamed Builds to Build.
273
274 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
275
276         webkitpy: Wait longer when launching WebKitTestRunner
277         https://bugs.webkit.org/show_bug.cgi?id=193734
278
279         Reviewed by Aakash Jain.
280
281         * Scripts/webkitpy/port/simulator_process.py:
282         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
283
284 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
285
286         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
287         https://bugs.webkit.org/show_bug.cgi?id=193182
288         <rdar://problem/47452154>
289
290         Reviewed by Tim Horton.
291
292         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
293         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
294         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
295
296         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
297         preventing later tests from recognizing gestures.
298
299         * WebKitTestRunner/ios/TestControllerIOS.mm:
300         (WTR::TestController::platformResetStateToConsistentValues):
301
302         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
303
304 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
305
306         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
307         https://bugs.webkit.org/show_bug.cgi?id=193722
308         <rdar://problem/47481475>
309
310         Reviewed by Lucas Forschler.
311
312         iPhone and iPad ports should both use the iOS config.
313
314         * Scripts/webkitpy/port/ios_simulator.py:
315         (IPhoneSimulatorPort.__init__):
316         (IPadSimulatorPort.__init__):
317
318 2019-01-23  Rob Buis  <rbuis@igalia.com>
319
320         Update MIME type parser
321         https://bugs.webkit.org/show_bug.cgi?id=180526
322
323         Reviewed by Frédéric Wang.
324
325         Add unit tests for both parse modes of ParsedContentType.
326
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
329         (TestWebKitAPI::TEST):
330
331 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
332
333         [ews-app] fetch loop should not stop on network issues
334         https://bugs.webkit.org/show_bug.cgi?id=193666
335
336         Reviewed by Lucas Forschler.
337
338         * BuildSlaveSupport/ews-app/ews/fetcher.py:
339         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
340
341 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
342
343         [iOS] Multiple WKWebViewAutofillTests are flaky failures
344         https://bugs.webkit.org/show_bug.cgi?id=189165
345         <rdar://problem/47433765>
346
347         Reviewed by Tim Horton.
348
349         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
350         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
351         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
352         process in sufficient to ensure that any previous action that blurred the focused element in the web process
353         would make its way to the UI process by the time the layer tree commit is finished.
354
355         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
356         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
357         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
358         will fail because it asks for -_autofillContext too early.
359
360         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
361         is handled in the UI process.
362
363         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
364
365         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
366         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
367         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
368         input session.
369
370         (-[AutofillTestView textInputHasAutofillContext]):
371
372         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
373
374         * TestWebKitAPI/cocoa/TestWKWebView.h:
375         * TestWebKitAPI/cocoa/TestWKWebView.mm:
376         (nextInputSessionChangeCount):
377
378         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
379         This includes changing the focused element from one to another.
380
381         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
382         (-[TestWKWebView didStartFormControlInteraction]):
383         (-[TestWKWebView didEndFormControlInteraction]):
384         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
385
386         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
387         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
388         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
389         that doesn't require an input session to one that doesn't.
390
391 2019-01-22  David Kilzer  <ddkilzer@apple.com>
392
393         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
394         <https://webkit.org/b/193676>
395
396         Reviewed by Alexey Proskuryakov.
397
398         * Scripts/webkitpy/style/checkers/cpp.py:
399         (check_member_initialization_list):
400         - Don't report missing whitespace around colon if the colon at
401           the start of the line is formatted correctly.
402         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
403         (WebKitStyleTest.test_member_initialization_list):
404         - Add a test for a missing permutation of existing tests.
405         - Add a test this false-positive.
406         - Add blank lines between subtests to make them easier to read.
407
408 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
409
410         [build.webkit.org] Unit-test failure after r237113
411         https://bugs.webkit.org/show_bug.cgi?id=193669
412
413         Reviewed by Michael Catanzaro.
414
415         * BuildSlaveSupport/build.webkit.org-config/factories.py:
416         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
417         multiple or zero flags.
418
419 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
420
421         Cache bytecode to disk
422         https://bugs.webkit.org/show_bug.cgi?id=192782
423         <rdar://problem/46084932>
424
425         Reviewed by Keith Miller.
426
427         Add test helper to execute bytecode-cache tests: it executes each test
428         twice, the first with JSC_diskCachePath set to a temporary directory
429         and second with JSC_forceDiskCache=true (in addition to the cache path)
430         to guarantee that only the disk cache is being used and no new
431         UnlinkedCodeBlocks are being created.
432
433         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
434         * Scripts/run-jsc-stress-tests:
435
436 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
437
438         [css-logical] Implement flow-relative margin, padding and border shorthands
439         https://bugs.webkit.org/show_bug.cgi?id=188697
440
441         Reviewed by Simon Fraser and Antti Koivisto.
442
443         * DumpRenderTree/TestOptions.cpp:
444         (TestOptions::TestOptions):
445         * DumpRenderTree/TestOptions.h:
446         * DumpRenderTree/mac/DumpRenderTree.mm:
447         (setWebPreferencesForTestOptions):
448         Allow tests to enable the CSSLogicalEnabled flag in WK1.
449
450         * Scripts/webkitpy/style/checkers/jsonchecker.py:
451         (JSONCSSPropertiesChecker.check_codegen_properties):
452         Allow CSS property definitions to have a 'runtime-flag' parameter which
453         disables the property when the specified runtime flag is disabled.
454
455 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
456
457         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
458         https://bugs.webkit.org/show_bug.cgi?id=193643
459
460         Reviewed by Michael Catanzaro.
461
462         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
463         * wpe/jhbuild.modules: Ditto.
464
465 2019-01-21  Zalan Bujtas  <zalan@apple.com>
466
467         [LFC][Floats] Take float top position into account when computing containing block height.
468         https://bugs.webkit.org/show_bug.cgi?id=193655
469
470         Reviewed by Antti Koivisto.
471
472         * LayoutReloaded/misc/LFC-passing-tests.txt:
473
474 2019-01-21  David Kilzer  <ddkilzer@apple.com>
475
476         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
477         <https://webkit.org/b/193645>
478         <rdar://problem/47421574>
479
480         Reviewed by Alex Christensen.
481
482         - Now checks for local soft-linking of all frameworks that have
483           their own *SoftLinking.{cpp,h,mm} files.
484         - Changes softlink/uikit warning to softlink/framework.
485
486         * Scripts/webkitpy/style/checkers/cpp.py:
487         (check_language):
488         (CppChecker):
489         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
490         (CppStyleTest):
491
492 2019-01-20  Saam Barati  <sbarati@apple.com>
493
494         Rollout r240210: It broke tests on iOS
495         https://bugs.webkit.org/show_bug.cgi?id=193640
496
497         Unreviewed.
498
499         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
500         * Scripts/run-jsc-stress-tests:
501
502 2019-01-20  chris fleizach  <cfleizach@apple.com>
503
504         AX: Support returning relative frames for accessibility
505         https://bugs.webkit.org/show_bug.cgi?id=193414
506         <rdar://problem/47268501>
507
508         Reviewed by Zalan Bujtas.
509
510         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
511         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
512         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
513         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
514         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
515         (WTR::attributesOfElement):
516         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
517
518 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
519
520         Unreviewed, add my new email address
521
522         * Scripts/webkitpy/common/config/contributors.json:
523
524 2019-01-19  Zalan Bujtas  <zalan@apple.com>
525
526         [LFC][BFC] <body>'s overflow property value is propagated to viewport
527         https://bugs.webkit.org/show_bug.cgi?id=193617
528
529         Reviewed by Antti Koivisto.
530
531         * LayoutReloaded/misc/LFC-passing-tests.txt:
532
533 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
534
535         Unreviewed, rolling out r240209.
536
537         Broke GTK/WPE injected bundle
538
539         Reverted changeset:
540
541         "AX: Support returning relative frames for accessibility"
542         https://bugs.webkit.org/show_bug.cgi?id=193414
543         https://trac.webkit.org/changeset/240209
544
545 2019-01-12  Dan Bernstein  <mitz@apple.com>
546
547         [Cocoa] Avoid importing directly from subumbrella frameworks
548         https://bugs.webkit.org/show_bug.cgi?id=186016
549         <rdar://problem/40591038>
550
551         Reviewed by Sam Weinig.
552
553         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
554           LaunchServices header.
555         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
556           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
557         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
558           when using SDKs earlier than 10.13.
559         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
560           and OTHER_CPLUSPLUSFLAGS.
561         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
562           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
563         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
564           LaunchServices header.
565
566 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
567
568         Cache bytecode to disk
569         https://bugs.webkit.org/show_bug.cgi?id=192782
570         <rdar://problem/46084932>
571
572         Reviewed by Keith Miller.
573
574         Add test helper to execute bytecode-cache tests: it executes each test
575         twice, the first with JSC_diskCachePath set to a temporary directory
576         and second with JSC_forceDiskCache=true (in addition to the cache path)
577         to guarantee that only the disk cache is being used and no new
578         UnlinkedCodeBlocks are being created.
579
580         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
581         * Scripts/run-jsc-stress-tests:
582
583 2019-01-20  chris fleizach  <cfleizach@apple.com>
584
585         AX: Support returning relative frames for accessibility
586         https://bugs.webkit.org/show_bug.cgi?id=193414
587         <rdar://problem/47268501>
588
589         Reviewed by Zalan Bujtas.
590
591         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
592         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
593         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
594         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
595         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
596         (WTR::attributesOfElement):
597         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
598
599 2019-01-20  Antoine Quint  <graouts@apple.com>
600
601         Add a POINTER_EVENTS feature flag
602         https://bugs.webkit.org/show_bug.cgi?id=193577
603         <rdar://problem/47408511>
604
605         Unreviewed. Also enable Pointer Events for iosmac.
606
607         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
608
609 2019-01-19  Zalan Bujtas  <zalan@apple.com>
610
611         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
612         https://bugs.webkit.org/show_bug.cgi?id=193613
613
614         Reviewed by Antti Koivisto.
615
616         * LayoutReloaded/misc/LFC-passing-tests.txt:
617
618 2019-01-19  Antoine Quint  <graouts@apple.com>
619
620         Add a POINTER_EVENTS feature flag
621         https://bugs.webkit.org/show_bug.cgi?id=193577
622
623         Reviewed by Dean Jackson.
624
625         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
626
627 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
628
629         Disable the run-jsc-stress-test remote host key check [second round].
630         https://bugs.webkit.org/show_bug.cgi?id=192988
631
632         Reviewed by Dewei Zhu.
633
634         * Scripts/run-jsc-stress-tests:
635
636 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
637
638         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
639         https://bugs.webkit.org/show_bug.cgi?id=193597
640
641         Reviewed by Lucas Forschler.
642
643         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
644
645 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
646
647         [build.webkit.org] api tests failures are incorrectly named as unit test failures
648         https://bugs.webkit.org/show_bug.cgi?id=193595
649
650         Reviewed by Lucas Forschler.
651
652         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
653         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
654         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
655
656 2019-01-18  Chris Dumez  <cdumez@apple.com>
657
658         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
659         https://bugs.webkit.org/show_bug.cgi?id=193588
660         <rdar://problem/47131566>
661
662         Reviewed by Alex Christensen.
663
664         Add layout test coverage.
665
666         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
667
668 2019-01-18  Jer Noble  <jer.noble@apple.com>
669
670         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
671         https://bugs.webkit.org/show_bug.cgi?id=189553
672
673         Reviewed by Tim Horton.
674
675         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
676
677         * ContentExtensionTester/Configurations/Base.xcconfig:
678         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
679         * DumpRenderTree/mac/Configurations/Base.xcconfig:
680         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
681         * ImageDiff/cg/Configurations/Base.xcconfig:
682         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
683         * MiniBrowser/Configurations/Base.xcconfig:
684         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
685         * MobileMiniBrowser/Configurations/Base.xcconfig:
686         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
687         * Scripts/webkitpy/style/checker.py:
688         (_all_categories):
689         (FileType):
690         (CheckerDispatcher._file_type):
691         (CheckerDispatcher._create_checker):
692         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
693         (SDKVariantChecker):
694         (SDKVariantChecker.__init__):
695         (SDKVariantChecker.check):
696         * TestWebKitAPI/Configurations/Base.xcconfig:
697         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
698         * WebEditingTester/Configurations/Base.xcconfig:
699         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
700         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
701         * WebKitTestRunner/Configurations/Base.xcconfig:
702         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
703         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
704         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
705
706 2019-01-18  David Kilzer  <ddkilzer@apple.com>
707
708         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
709         <https://webkit.org/b/193568>
710         <rdar://problem/47381130>
711
712         Reviewed by Alex Christensen.
713
714         Make sure no one re-introduces UIKit soft-linking by adding a
715         style rule.
716
717         * Scripts/webkitpy/style/checkers/cpp.py:
718         (check_language): Add softlink/uikit check.
719         (CppChecker): Enable softlink/uikit check.
720         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
721         (CppStyleTest): Add test for softlink/uikit.
722
723 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
724
725         [GTK] install-dependencies tool looks for libunistring-dev for dnf
726         https://bugs.webkit.org/show_bug.cgi?id=193584
727
728         Change "-dev" to "-devel".
729
730         Reviewed by Michael Catanzaro.
731
732         * gtk/install-dependencies:
733
734 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
735
736         webkitpy: Add iPhone and iPad ports
737         https://bugs.webkit.org/show_bug.cgi?id=193537
738         <rdar://problem/47353390>
739
740         Reviewed by Lucas Forschler.
741
742         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
743         ports. Note that this separation is optional, the --ios-simulator command remains.
744
745         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
746         (RunTest.test_device_type_test_division): Drive-by fix.
747         (RunTest.test_device_type_specific_listing): Ditto.
748         (RunTest.test_ipad_test_division):
749         (RunTest):
750         (RunTest.test_ipad_listing):
751         * Scripts/webkitpy/port/factory.py:
752         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
753         (PortFactory):
754         * Scripts/webkitpy/port/ios_simulator.py:
755         (IPhoneSimulatorPort):
756         (IPadSimulatorPort):
757
758 2019-01-18  Chris Dumez  <cdumez@apple.com>
759
760         Regression(PSON) Scroll position is not always restored properly when navigating back
761         https://bugs.webkit.org/show_bug.cgi?id=193578
762         <rdar://problem/47386331>
763
764         Reviewed by Tim Horton.
765
766         Add API test coverage.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
769
770 2019-01-18  Youenn Fablet  <youenn@apple.com>
771
772         Add a new SPI to request for cache storage quota increase
773         https://bugs.webkit.org/show_bug.cgi?id=193323
774
775         Reviewed by Alex Christensen.
776
777         Implement WebsiteDataStore quota delegate to handle quota requests.
778         By default, do not update quota.
779         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
780
781         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
782         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
783         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
784         * WebKitTestRunner/InjectedBundle/TestRunner.h:
785         * WebKitTestRunner/TestController.cpp:
786         (WTR::TestController::allowCacheStorageQuotaIncrease):
787         * WebKitTestRunner/TestController.h:
788         * WebKitTestRunner/TestInvocation.cpp:
789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
790         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
791         (-[CacheStorageQuotaManager init]):
792         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
793         (WTR::initializeWebViewConfiguration):
794         (WTR::TestController::cocoaResetStateToConsistentValues):
795         (WTR::TestController::allowCacheStorageQuotaIncrease):
796
797 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
798
799         [ews-build] Pass owner to the triggered builds
800         https://bugs.webkit.org/show_bug.cgi?id=193574
801
802         Reviewed by Lucas Forschler.
803
804         * BuildSlaveSupport/ews-build/factories.py:
805         (BuildFactory.propertiesToPassToTriggers):
806
807 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
808
809         [ews-app] Send patch author as a build property
810         https://bugs.webkit.org/show_bug.cgi?id=193560
811
812         Reviewed by Lucas Forschler.
813
814         * BuildSlaveSupport/ews-app/ews/fetcher.py:
815         (BugzillaPatchFetcher.fetch):
816
817 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
818
819         webkitpy: Implement device type specific expected results (Follow-up fix)
820         https://bugs.webkit.org/show_bug.cgi?id=192162
821         <rdar://problem/46345449>
822
823         Unreviewed infrastructure fix.
824
825         * Scripts/webkitpy/layout_tests/controllers/manager.py:
826         (Manager.run): Don't boot a device if no tests are available to run on it.
827
828 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
829
830         webkitpy: Implement device type specific expected results (Follow-up fix)
831         https://bugs.webkit.org/show_bug.cgi?id=192162
832         <rdar://problem/46345449>
833
834         Unreviewed infrastructure fix.
835
836         * Scripts/webkitpy/api_tests/manager.py:
837         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
838
839 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
840
841         webkitpy: Implement device type specific expected results (Part 2)
842         https://bugs.webkit.org/show_bug.cgi?id=192162
843         <rdar://problem/46345449>
844
845         Rubber-stamped by Aakash Jain.
846
847         This change uses device_type to select a different set of TestExpectation files based on the type of device running
848         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
849         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
850
851         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
852         (LayoutTestFinder.find_tests): Pass device_type through.
853         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
854         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
855         * Scripts/webkitpy/layout_tests/controllers/manager.py:
856         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
857         (Manager._collect_tests): Pass device type to test finder.
858         (Manager._needs_web_platform_test):
859         (Manager._prepare_lists): Index _expectations by device type.
860         (Manager._test_input_for_file):
861         (Manager._test_is_slow): Ditto.
862         (Manager._test_should_dump_jsconsolelog_in_stderr):
863         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
864         (Manager._get_test_inputs):
865         (Manager._update_worker_count):
866         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
867         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
868         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
869         the one which runs the test.
870         (Manager._run_test_subset):
871         (Manager._run_tests): Index _expectations by current_device_type.
872         (Manager._print_expectation_line_for_test): Ditto.
873         (Manager._print_expectations_for_subset): Ditto.
874         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
875         Unlike run, this function will behave the same regardless of what devices are available.
876         (Manager._custom_device_for_test): Deleted.
877         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
878         (ManagerTest.test_uses_custom_device): Deleted.
879         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
880         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
881         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
882         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
883         all of the expectations.
884         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
885         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
886         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
887         (TestExpectations.__init__): Allow device_type to be passed through.
888         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
889         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
890         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
891         (summarize_results):
892         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
893         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
894         a test ran with, one must check all expectations to find the first non-skip expectation.
895         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
896         (RunTest.test_device_type_test_division):
897         (RunTest):
898         (RunTest.test_device_type_specific_listing):
899         * Scripts/webkitpy/port/base.py:
900         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
901         (Port.supported_device_types): The result of this function will change based on what devices are available.
902         * Scripts/webkitpy/port/device_port.py:
903         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
904         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
905         can be used.
906         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
907         any, or the DEFAULT_DEVICE_TYPES of the port.
908         * Scripts/webkitpy/port/ios.py:
909         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
910         * Scripts/webkitpy/port/ios_simulator.py:
911         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
912         * Scripts/webkitpy/port/watch.py:
913         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
914         * Scripts/webkitpy/port/watch_simulator.py:
915         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
916         * Scripts/webkitpy/xcode/device_type.py:
917         (DeviceType):
918         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
919
920 2019-01-18  Philippe Normand  <pnormand@igalia.com>
921
922         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
923         https://bugs.webkit.org/show_bug.cgi?id=193575
924
925         Reviewed by Michael Catanzaro.
926
927         Allow the script to run without explicit port argument because
928         it's specific to the WPE port anyway.
929
930         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
931         and simplify the rest of the code accordingly.
932
933 2019-01-18  Charlie Turner  <cturner@igalia.com>
934
935         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
936         https://bugs.webkit.org/show_bug.cgi?id=192229
937
938         Reviewed by Xabier Rodriguez-Calvar.
939
940         * MiniBrowser/wpe/main.cpp:
941         (main): Enable encrypted-media by default.
942
943 2019-01-18  Philippe Normand  <pnormand@igalia.com>
944
945         [Flatpak] Missing KeyboardInterrupt exception handler
946         https://bugs.webkit.org/show_bug.cgi?id=193570
947
948         Reviewed by Michael Catanzaro.
949
950         * flatpak/flatpakutils.py:
951         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
952
953 2019-01-18  Zalan Bujtas  <zalan@apple.com>
954
955         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
956         https://bugs.webkit.org/show_bug.cgi?id=193564
957
958         Reviewed by Antti Koivisto.
959
960         * LayoutReloaded/misc/LFC-passing-tests.txt:
961
962 2019-01-18  Zalan Bujtas  <zalan@apple.com>
963
964         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
965         https://bugs.webkit.org/show_bug.cgi?id=193562
966
967         Reviewed by Antti Koivisto.
968
969         * LayoutReloaded/misc/LFC-passing-tests.txt:
970
971 2019-01-18  Zalan Bujtas  <zalan@apple.com>
972
973         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
974         https://bugs.webkit.org/show_bug.cgi?id=193555
975
976         Reviewed by Antti Koivisto.
977
978         * LayoutReloaded/misc/LFC-passing-tests.txt:
979
980 2019-01-18  Philippe Normand  <pnormand@igalia.com>
981
982         [WPE] Add Qt extension
983         https://bugs.webkit.org/show_bug.cgi?id=191464
984
985         Reviewed by Carlos Garcia Campos.
986
987         MiniBrowser and API tests for the WPE Qt API. To run the
988         MiniBrowser a new script is introduced. Example invocation:
989
990         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
991
992         Also note-worthy is the introduction of the python2-subprocess32
993         dependency to run the GLib API tests.
994
995         * MiniBrowser/wpe/CMakeLists.txt:
996         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
997         * MiniBrowser/wpe/qt/main.cpp: Added.
998         (main):
999         * MiniBrowser/wpe/qt/main.qml: Added.
1000         * MiniBrowser/wpe/qt/qml.qrc: Added.
1001         * Scripts/run-gtk-tests:
1002         (GtkTestRunner.is_google_test):
1003         (GtkTestRunner):
1004         (GtkTestRunner.is_qt_test):
1005         * Scripts/run-qt-wpe-minibrowser: Added.
1006         * Scripts/run-wpe-tests:
1007         (WPETestRunner):
1008         (WPETestRunner.is_google_test):
1009         (WPETestRunner.is_qt_test):
1010         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1011         (TestLoad::main):
1012         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1013         (TestLoadHtml::main):
1014         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1015         (TestLoadRequest::main):
1016         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1017         (TestRunJavaScript::main):
1018         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1019         (waitForSignal):
1020         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1021         (LoadSpy::LoadSpy):
1022         (LoadSpy::~LoadSpy):
1023         (LoadSpy::onLoadingChanged):
1024         (LoadStartedCatcher::LoadStartedCatcher):
1025         (LoadStartedCatcher::~LoadStartedCatcher):
1026         (LoadStartedCatcher::onLoadingChanged):
1027         (waitForLoadSucceeded):
1028         (waitForLoadFailed):
1029         * TestWebKitAPI/glib/CMakeLists.txt:
1030         * flatpak/flatpakutils.py:
1031         (WebkitFlatpak.load_from_args):
1032         (WebkitFlatpak.__init__):
1033         (WebkitFlatpak.clean_args):
1034         (WebkitFlatpak.run_in_sandbox):
1035         * flatpak/org.webkit.CommonModules.yaml:
1036         * flatpak/org.webkit.WPE.yaml:
1037         * flatpak/org.webkit.WPEModules.yaml:
1038         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1039         * flatpak/org.webkit.WebKit.yaml:
1040         * glib/api_test_runner.py:
1041         (TestRunner._run_test_qt):
1042         (TestRunner.is_qt_test):
1043         (TestRunner._run_test):
1044
1045 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1046
1047         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1048         https://bugs.webkit.org/show_bug.cgi?id=193494
1049         <rdar://problem/46859627>
1050
1051         Reviewed by Simon Fraser and Tim Horton.
1052
1053         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1054         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1055
1056         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1057         (WTR::UIScriptController::contentOffsetX const):
1058         (WTR::UIScriptController::contentOffsetY const):
1059         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1060         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1061         (WTR::UIScriptController::contentOffsetX const):
1062         (WTR::UIScriptController::contentOffsetY const):
1063         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1064
1065         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1066
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::updateTestOptionsFromTestHeader):
1069         * WebKitTestRunner/TestOptions.h:
1070         (WTR::TestOptions::hasSameInitializationOptions const):
1071         * WebKitTestRunner/ios/TestControllerIOS.mm:
1072         (WTR::TestController::platformResetStateToConsistentValues):
1073         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1074         (WTR::UIScriptController::contentOffsetX const):
1075         (WTR::UIScriptController::contentOffsetY const):
1076
1077 2019-01-17  Truitt Savell  <tsavell@apple.com>
1078
1079         Unreviewed, rolling out r240124.
1080
1081         This commit broke an internal build.
1082
1083         Reverted changeset:
1084
1085         "SDK_VARIANT build destinations should be separate from non-
1086         SDK_VARIANT builds"
1087         https://bugs.webkit.org/show_bug.cgi?id=189553
1088         https://trac.webkit.org/changeset/240124
1089
1090 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1091
1092         Fix string concatenation API test after r239920
1093         https://bugs.webkit.org/show_bug.cgi?id=193551
1094         <rdar://problem/47359304>
1095
1096         Reviewed by Youenn Fablet.
1097
1098         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1099         (TestWebKitAPI::TEST):
1100         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1101         in WebKit's build configuration like it apparently is on Linux.
1102
1103 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1104
1105         [ews-build] validate-patch should handle the case when bug_id is None
1106         https://bugs.webkit.org/show_bug.cgi?id=193547
1107
1108         Reviewed by Lucas Forschler.
1109
1110         * BuildSlaveSupport/ews-build/steps.py:
1111         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1112         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1113
1114 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1115
1116         [ews-build] Add patch author information in build
1117         https://bugs.webkit.org/show_bug.cgi?id=193465
1118
1119         Reviewed by Lucas Forschler.
1120
1121         * BuildSlaveSupport/ews-build/steps.py:
1122         (ValidatePatch._is_patch_obsolete):
1123
1124 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1125
1126         [ews-build] Pass bug_id to the triggered builds
1127         https://bugs.webkit.org/show_bug.cgi?id=193548
1128
1129         Reviewed by Lucas Forschler.
1130
1131         * BuildSlaveSupport/ews-build/factories.py:
1132         (BuildFactory.propertiesToPassToTriggers):
1133
1134 2019-01-17  Jer Noble  <jer.noble@apple.com>
1135
1136         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1137         https://bugs.webkit.org/show_bug.cgi?id=189553
1138
1139         Reviewed by Tim Horton.
1140
1141         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1142
1143         * ContentExtensionTester/Configurations/Base.xcconfig:
1144         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1145         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1146         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1147         * ImageDiff/cg/Configurations/Base.xcconfig:
1148         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1149         * MiniBrowser/Configurations/Base.xcconfig:
1150         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1151         * MobileMiniBrowser/Configurations/Base.xcconfig:
1152         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1153         * Scripts/webkitpy/style/checker.py:
1154         (_all_categories):
1155         (FileType):
1156         (CheckerDispatcher._file_type):
1157         (CheckerDispatcher._create_checker):
1158         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1159         (SDKVariantChecker):
1160         (SDKVariantChecker.__init__):
1161         (SDKVariantChecker.check):
1162         * TestWebKitAPI/Configurations/Base.xcconfig:
1163         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1164         * WebEditingTester/Configurations/Base.xcconfig:
1165         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1166         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1167         * WebKitTestRunner/Configurations/Base.xcconfig:
1168         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1169         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1170         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1171
1172 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1173
1174         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1175         https://bugs.webkit.org/show_bug.cgi?id=193534
1176
1177         Reviewed by Antti Koivisto.
1178
1179         * LayoutReloaded/misc/LFC-passing-tests.txt:
1180
1181 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1182
1183         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1184         https://bugs.webkit.org/show_bug.cgi?id=193528
1185
1186         Reviewed by Antti Koivisto.
1187
1188         * LayoutReloaded/misc/LFC-passing-tests.txt:
1189
1190 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1191
1192         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1193         https://bugs.webkit.org/show_bug.cgi?id=193520
1194
1195         Reviewed by Antti Koivisto.
1196
1197         * LayoutReloaded/misc/LFC-passing-tests.txt:
1198
1199 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1200
1201         [ews-build] unapply-patch step should not update source
1202         https://bugs.webkit.org/show_bug.cgi?id=193234
1203
1204         Reviewed by Lucas Forschler.
1205
1206         * BuildSlaveSupport/ews-build/steps.py:
1207         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1208         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1209
1210 2019-01-16  Youenn Fablet  <youenn@apple.com>
1211
1212         Add a new SPI for controlling getUserMedia
1213         https://bugs.webkit.org/show_bug.cgi?id=192793
1214
1215         Reviewed by Eric Carlson.
1216
1217         * MiniBrowser/mac/WK2BrowserWindowController.m:
1218         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1219         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1220         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1221         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1222         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1223         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1224         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1225         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1226         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1227         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1228         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1229         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1230         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1231         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1232
1233 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1234
1235         [LFC][BFC] Inflow non-replaced used width should not be negative.
1236         https://bugs.webkit.org/show_bug.cgi?id=193495
1237
1238         Reviewed by Antti Koivisto.
1239
1240         * LayoutReloaded/misc/LFC-passing-tests.txt:
1241
1242 2019-01-16  Chris Dumez  <cdumez@apple.com>
1243
1244         Regression(PSON) View becomes blank after click a cross-site download link
1245         https://bugs.webkit.org/show_bug.cgi?id=193361
1246         <rdar://problem/47099573>
1247
1248         Reviewed by Geoffrey Garen.
1249
1250         Add API test coverage.
1251
1252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1253         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1254
1255 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1256
1257         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1258         https://bugs.webkit.org/show_bug.cgi?id=193470
1259
1260         Reviewed by Antti Koivisto.
1261
1262         * LayoutReloaded/misc/LFC-passing-tests.txt:
1263
1264 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1265
1266         [LFC] Adjust margin box verification.
1267         https://bugs.webkit.org/show_bug.cgi?id=193482
1268
1269         Reviewed by Antti Koivisto.
1270
1271         * LayoutReloaded/misc/LFC-passing-tests.txt:
1272
1273 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1274
1275         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1276         https://bugs.webkit.org/show_bug.cgi?id=193451
1277
1278         Reviewed by Geoffrey Garen.
1279
1280         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1281         (TEST):
1282         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1283         (runWebsiteDataStoreCustomPaths):
1284
1285 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1286
1287         webkitpy: Support boolean simctl isAvailable
1288         https://bugs.webkit.org/show_bug.cgi?id=193472
1289         <rdar://problem/47296150>
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         * Scripts/webkitpy/xcode/simulated_device.py:
1294         (SimulatedDeviceManager._create_runtimes):
1295         (SimulatedDeviceManager._create_device_with_runtime):
1296
1297 2019-01-15  Chris Dumez  <cdumez@apple.com>
1298
1299         Unreviewed, rolling out r239993, r239995, r239997, and
1300         r239999.
1301
1302         Caused assertions under
1303         ViewGestureController::disconnectFromProcess()
1304
1305         Reverted changesets:
1306
1307         "Regression(PSON) View becomes blank after click a cross-site
1308         download link"
1309         https://bugs.webkit.org/show_bug.cgi?id=193361
1310         https://trac.webkit.org/changeset/239993
1311
1312         "Unreviewed iOS build fix after r239993."
1313         https://trac.webkit.org/changeset/239995
1314
1315         "Fix iOS build after r239993"
1316         https://bugs.webkit.org/show_bug.cgi?id=193361
1317         https://trac.webkit.org/changeset/239997
1318
1319         "Unreviewed, revert part of r239997 as it is not needed to fix
1320         the build."
1321         https://trac.webkit.org/changeset/239999
1322
1323 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1324
1325         Cannot tab out of WKWebView on macOS
1326         https://bugs.webkit.org/show_bug.cgi?id=161448
1327         <rdar://problem/28100085>
1328
1329         Reviewed by Dean Jackson.
1330
1331         Add a test that tabbing into and out of WKWebView works correctly.
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1335         (WebKit2_CommandBackForwardTest::SetUp):
1336         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1337         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1338         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1339         (-[FocusableView canBecomeKeyView]):
1340         (TEST):
1341         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1342         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1343         (-[OffscreenWindow initWithSize:]):
1344         (-[OffscreenWindow isKeyWindow]):
1345         (-[OffscreenWindow isVisible]):
1346         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1347         (TestWebKitAPI::PlatformWebView::initialize):
1348         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1349         (-[ActiveOffscreenWindow isVisible]): Deleted.
1350         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1351
1352 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1353
1354         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1355         https://bugs.webkit.org/show_bug.cgi?id=193459
1356
1357         Reviewed by Mark Lam.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1360         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1361
1362 2019-01-15  Chris Dumez  <cdumez@apple.com>
1363
1364         Regression(PSON) View becomes blank after click a cross-site download link
1365         https://bugs.webkit.org/show_bug.cgi?id=193361
1366         <rdar://problem/47099573>
1367
1368         Reviewed by Geoff Garen.
1369
1370         Add API test coverage.
1371
1372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1373         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1374
1375 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1376
1377         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1378         https://bugs.webkit.org/show_bug.cgi?id=193448
1379
1380         Reviewed by Antti Koivisto.
1381
1382         * LayoutReloaded/misc/LFC-passing-tests.txt:
1383
1384 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1385
1386         webkitpy: Implement device type specific expected results (Part 1)
1387         https://bugs.webkit.org/show_bug.cgi?id=192162
1388
1389         Reviewed by Lucas Forschler.
1390
1391         Device type specific expected results covers two related ideas. The first (covered by this change)
1392         is where to search for -expected.* files. The second is which tests to run based on the
1393         TestExpectations.txt file.
1394
1395         After this change, the baseline search path will be determined by the type of device running a
1396         test. Device type will be passed into any function which picks a file based on the baseline search
1397         path.
1398
1399         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1400         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1401         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1402         (Manager.run): Print baseline search path for each round of devices.
1403         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1404         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1405         (SingleTestRunner._expected_driver_output): Ditto.
1406         (SingleTestRunner._driver_input): Ditto.
1407         * Scripts/webkitpy/layout_tests/views/printing.py:
1408         (Printer.print_config): Move printing of baseline search path to a separate function.
1409         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1410         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1411         (Testprinter.test_print_config):
1412         (Testprinter.test_print_baseline_search_path):
1413         * Scripts/webkitpy/port/base.py:
1414         (Port.baseline_search_path): Pass device_type through.
1415         (Port._expected_baselines_for_suffixes): Ditto.
1416         (Port.expected_baselines): Ditto.
1417         (Port.expected_filename): Ditto.
1418         (Port.expected_checksum): Ditto.
1419         (Port.expected_image): Ditto.
1420         (Port.expected_audio): Ditto.
1421         (Port.expected_text): Ditto.
1422         (Port.reference_files): Ditto.
1423         (Port.tests): Ditto.
1424         (Port._expanded_paths): Ditto.
1425         (Port.skipped_layout_tests): Ditto.
1426         (Port.expectations_dict): Ditto.
1427         (Port._port_specific_expectations_files): Ditto.
1428         (Port.expectations_files): Ditto.
1429         (Port.test_search_path): Ditto.
1430         (Port._tests_for_other_platforms): Ditto.
1431         * Scripts/webkitpy/port/base_unittest.py:
1432         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1433         (PortTest.test_nonexistant_expectations): Ditto.
1434         (test_ref_tests_platform_directory): Ditto.
1435         * Scripts/webkitpy/port/darwin.py:
1436         (DarwinPort._port_specific_expectations_files): Accept device_type.
1437         * Scripts/webkitpy/port/driver.py:
1438         (DriverProxy):
1439         (DriverProxy.host): Expose _target_host for device_type information.
1440         * Scripts/webkitpy/port/gtk.py:
1441         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1442         * Scripts/webkitpy/port/ios.py:
1443         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1444         * Scripts/webkitpy/port/mac.py:
1445         (MacPort. default_baseline_search_path): Ditto.
1446         * Scripts/webkitpy/port/port_testcase.py:
1447         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1448         * Scripts/webkitpy/port/test.py:
1449         * Scripts/webkitpy/port/watch.py:
1450         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1451         * Scripts/webkitpy/port/win.py:
1452         (WinPort.test_search_path): Accept, but do not use, device_type.
1453         * Scripts/webkitpy/port/wpe.py:
1454         (WPEPort._port_specific_expectations_files): Ditto.
1455         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1456         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1457
1458 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1459
1460         [LFC] Use the containing block's padding box to position out-of-flow elements.
1461         https://bugs.webkit.org/show_bug.cgi?id=193431
1462
1463         Reviewed by Antti Koivisto.
1464
1465         * LayoutReloaded/misc/LFC-passing-tests.txt:
1466
1467 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1468
1469         Move a test implementation file that got misplaced in the Xcode project
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472
1473 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1474
1475         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1476         r239913, and r239914.
1477         https://bugs.webkit.org/show_bug.cgi?id=193407
1478
1479         These revisions caused an internal failure (Requested by
1480         Truitt on #webkit).
1481
1482         Reverted changesets:
1483
1484         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1485         https://bugs.webkit.org/show_bug.cgi?id=186016
1486         https://trac.webkit.org/changeset/239901
1487
1488         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1489         https://trac.webkit.org/changeset/239909
1490
1491         "Tried to fix the build."
1492         https://trac.webkit.org/changeset/239910
1493
1494         "Fixed iOS builds after r239910."
1495         https://trac.webkit.org/changeset/239912
1496
1497         "More build fixing."
1498         https://trac.webkit.org/changeset/239913
1499
1500         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1501         https://trac.webkit.org/changeset/239914
1502
1503 2019-01-14  Mark Lam  <mark.lam@apple.com>
1504
1505         Re-enable ability to build --cloop builds.
1506         https://bugs.webkit.org/show_bug.cgi?id=192955
1507         <rdar://problem/46882363>
1508
1509         Reviewed by Saam barati and Keith Miller.
1510
1511         The --cloop build option was being ignored this whole time since r236381.
1512         This patch makes it possible to build CLoop builds again.
1513
1514         * Scripts/build-jsc:
1515         * Scripts/webkitperl/FeatureList.pm:
1516         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1517
1518 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1519
1520         webkitpy: Expose device_type from host-like objects
1521         https://bugs.webkit.org/show_bug.cgi?id=193406
1522         <rdar://problem/47262305>
1523
1524         Reviewed by Lucas Forschler.
1525
1526         Devices should expose device_type. As a result, all host objects should
1527         provide a device_type property, even if they do not yet define a device_type.
1528
1529         * Scripts/webkitpy/common/system/systemhost.py:
1530         (SystemHost):
1531         (SystemHost.device_type):
1532         * Scripts/webkitpy/common/system/systemhost_mock.py:
1533         (MockSystemHost):
1534         (MockSystemHost.device_type):
1535         * Scripts/webkitpy/port/device.py:
1536         (Device):
1537         (Device.device_type):
1538         * Scripts/webkitpy/xcode/simulated_device.py:
1539         (SimulatedDeviceManager._find_exisiting_device_for_request):
1540         (SimulatedDeviceManager._disambiguate_device_type):
1541         (SimulatedDeviceManager._does_fulfill_request):
1542         (SimulatedDeviceManager.device_count_for_type):
1543         (SimulatedDeviceManager.initialize_devices):
1544         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1545         (test_available_devices):
1546         (test_swapping_devices):
1547
1548 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1549
1550         webkitpy: Support alternate simctl device list output (Follow-up fix)
1551         https://bugs.webkit.org/show_bug.cgi?id=193362
1552         <rdar://problem/47122965>
1553
1554         Rubber-stamped by Lucas Forschler.
1555
1556         * Scripts/webkitpy/xcode/simulated_device.py:
1557         (SimulatedDeviceManager.populate_available_devices):
1558
1559 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1560
1561         [iOS] Expose SPI to access the current sentence boundary and selection state
1562         https://bugs.webkit.org/show_bug.cgi?id=193398
1563         <rdar://problem/45893108>
1564
1565         Reviewed by Dean Jackson.
1566
1567         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1568         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1569         expected.
1570
1571         * TestWebKitAPI/EditingTestHarness.h:
1572         * TestWebKitAPI/EditingTestHarness.mm:
1573         (-[EditingTestHarness moveBackward]):
1574         (-[EditingTestHarness moveForward]):
1575         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1576
1577         Add a couple of new helper methods on EditingTestHarness.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1580         (-[SelectionChangeObserver initWithWebView:]):
1581         (-[SelectionChangeObserver webView]):
1582         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1583         (-[SelectionChangeObserver currentSelectionAttributes]):
1584
1585 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1586
1587         [LFC][BFC] Add basic box-sizing support.
1588         https://bugs.webkit.org/show_bug.cgi?id=193392
1589
1590         Reviewed by Antti Koivisto.
1591
1592         * LayoutReloaded/misc/LFC-passing-tests.txt:
1593
1594 2019-01-14  Charlie Turner  <cturner@igalia.com>
1595
1596         [WPE] API test gardening
1597         https://bugs.webkit.org/show_bug.cgi?id=193319
1598
1599         Reviewed by Michael Catanzaro.
1600
1601         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1602         passing tests.
1603
1604 2019-01-14  Charlie Turner  <cturner@igalia.com>
1605
1606         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1607         https://bugs.webkit.org/show_bug.cgi?id=192977
1608
1609         Reviewed by Carlos Garcia Campos.
1610
1611         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1612         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1613         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1614         (TestWebKitAPI::GStreamerTest::SetUp):
1615         (TestWebKitAPI::GStreamerTest::TearDown):
1616         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1617         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1618         (TestWebKitAPI::TEST_F):
1619
1620 2019-01-14  Charlie Turner  <cturner@igalia.com>
1621
1622         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1623         https://bugs.webkit.org/show_bug.cgi?id=193332
1624
1625         Reviewed by Michael Catanzaro.
1626
1627         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1628         defined as a char16_t, which changed in ICU 59, the
1629         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1630         unsigned short. This test is relying on the behaviour that
1631         UChar=unsigned short, which doesn't hold across platforms and ICU
1632         library versions. The full fix would be a special syntax for
1633         literal characters so that these ambiguities do not arise. That
1634         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1635         (TestWebKitAPI::TEST):
1636
1637 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1638
1639         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1640
1641         * Scripts/make-dist:
1642         (Distcheck.configure):
1643
1644 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-build] Update macOS queue configurations
1647         https://bugs.webkit.org/show_bug.cgi?id=193365
1648         <rdar://problem/47221073>
1649
1650         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1651
1652         * BuildSlaveSupport/ews-build/config.json:
1653
1654 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1655
1656         [LFC] Adjust assert for statically positioned fixed elements
1657         https://bugs.webkit.org/show_bug.cgi?id=193385
1658
1659         Reviewed by Antti Koivisto.
1660
1661         * LayoutReloaded/misc/LFC-passing-tests.txt:
1662
1663 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1664
1665         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1666         https://bugs.webkit.org/show_bug.cgi?id=193387
1667
1668         Reviewed by Carlos Garcia Campos.
1669
1670         * MiniBrowser/wpe/main.cpp:
1671         (main):
1672
1673 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1674
1675         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1676         https://bugs.webkit.org/show_bug.cgi?id=191655
1677         rdar://problem/46074680
1678
1679         Reviewed by Megan Gardner.
1680
1681         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1682         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1683
1684 2019-01-12  Dan Bernstein  <mitz@apple.com>
1685
1686         [Cocoa] Avoid importing directly from subumbrella frameworks
1687         https://bugs.webkit.org/show_bug.cgi?id=186016
1688         <rdar://problem/40591038>
1689
1690         Reviewed by Sam Weinig.
1691
1692         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1693           LaunchServices header.
1694         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1695           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1696         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1697           when using SDKs earlier than 10.13.
1698         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1699           and OTHER_CPLUSPLUSFLAGS.
1700         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1701           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1702         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1703           LaunchServices header.
1704
1705 2019-01-11  John Wilander  <wilander@apple.com>
1706
1707         Compile out Web API Statistics Collection
1708         https://bugs.webkit.org/show_bug.cgi?id=193370
1709         <rdar://problem/45388584>
1710
1711         Reviewed by Brent Fulgham.
1712
1713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1714             Defined ENABLE_WEB_API_STATISTICS, off by default.
1715
1716 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1717
1718         [WPE] Add gtk-doc
1719         https://bugs.webkit.org/show_bug.cgi?id=178900
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         Add Tools/gtkdoc to manifest.txt.in files.
1724         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1725
1726         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1727         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1728
1729 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1730
1731         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1732         https://bugs.webkit.org/show_bug.cgi?id=193364
1733         <rdar://problem/47214117>
1734
1735         Reviewed by Tim Horton.
1736
1737         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1738         precise, whereas dragging near the middle of the textarea does.
1739
1740         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1741         (TestWebKitAPI::TEST):
1742
1743 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1744
1745         webkitpy: Support alternate simctl device list output
1746         https://bugs.webkit.org/show_bug.cgi?id=193362
1747         <rdar://problem/47122965>
1748
1749         Reviewed by Lucas Forschler.
1750
1751         * Scripts/webkitpy/xcode/simulated_device.py:
1752         (SimulatedDeviceManager.populate_available_devices):
1753
1754 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1755
1756         [ews-build] Update macOS queue configurations
1757         https://bugs.webkit.org/show_bug.cgi?id=193365
1758
1759         Reviewed by Lucas Forschler.
1760
1761         * BuildSlaveSupport/ews-build/config.json:
1762
1763 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1764
1765         webkitpy: Incorporate device type into baseline search path
1766         https://bugs.webkit.org/show_bug.cgi?id=193356
1767         <rdar://problem/47215515>
1768
1769         Reviewed by Lucas Forschler.
1770
1771         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1772
1773         * Scripts/webkitpy/port/base.py:
1774         (Port.default_baseline_search_path): Allow device type to be passed in.
1775         * Scripts/webkitpy/port/gtk.py:
1776         (GtkPort.default_baseline_search_path): Ignore device type.
1777         * Scripts/webkitpy/port/ios.py:
1778         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1779         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1780         * Scripts/webkitpy/port/ios_device_unittest.py:
1781         (IOSDeviceTest):
1782         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1783         (IOSSimulatorTest):
1784         * Scripts/webkitpy/port/mac.py:
1785         (MacPort.default_baseline_search_path): Ignore device type.
1786         * Scripts/webkitpy/port/watch.py:
1787         (WatchPort.default_baseline_search_path): Ditto.
1788         * Scripts/webkitpy/port/win.py:
1789         (WinPort.default_baseline_search_path): Ditto.
1790         (WinCairoPort.default_baseline_search_path): Ditto.
1791         * Scripts/webkitpy/port/wpe.py:
1792         (WPEPort.default_baseline_search_path): Ditto.
1793
1794 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1795
1796         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1797         https://bugs.webkit.org/show_bug.cgi?id=193352
1798         <rdar://problem/47210736>
1799
1800         Reviewed by Lucas Forschler.
1801
1802         * Scripts/webkitpy/layout_tests/views/printing.py:
1803         (Printer.print_config): Print list on only baseline search paths which exist. 
1804         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1805         (Testprinter.test_print_config):
1806
1807 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1808
1809         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1810         https://bugs.webkit.org/show_bug.cgi?id=193340
1811
1812         Reviewed by David Kilzer.
1813
1814         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1815         (WTR::InjectedBundle::didReceiveMessageToPage):
1816         Pull the strings out into a WKRetainPtr.
1817
1818         * WebKitTestRunner/WebNotificationProvider.cpp:
1819         (WTR::WebNotificationProvider::closeWebNotification):
1820         Adopt the created value into the WKRetainPtr.
1821
1822         * WebKitTestRunner/mac/TestControllerMac.mm:
1823         (WTR::generateWhitelist):
1824         Immediately adopt a created value to avoid potential mistakes.
1825
1826 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1827
1828         Enable DFG on ARM/Linux again
1829         https://bugs.webkit.org/show_bug.cgi?id=192496
1830
1831         Reviewed by Yusuke Suzuki.
1832
1833         After changing the bytecode format DFG was disabled on all 32-bit
1834         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1835         on ARM by default.
1836
1837         * Scripts/run-jsc-stress-tests:
1838
1839 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1840
1841         Unreviewed, fix #ifdef in API test added in r239851.
1842         https://bugs.webkit.org/show_bug.cgi?id=193327
1843         rdar://problem/47093222
1844
1845         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1846
1847 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1848
1849         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1850         https://bugs.webkit.org/show_bug.cgi?id=193109
1851         <rdar://problem/44807048>
1852
1853         Reviewed by Ryosuke Niwa.
1854
1855         Introduce and respect a test option to enable the UndoManager API.
1856
1857         * WebKitTestRunner/TestController.cpp:
1858         (WTR::updateTestOptionsFromTestHeader):
1859         * WebKitTestRunner/TestOptions.h:
1860         (WTR::TestOptions::hasSameInitializationOptions const):
1861         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1862         (WTR::TestController::platformCreateWebView):
1863
1864 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1865
1866         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1867         https://bugs.webkit.org/show_bug.cgi?id=193346
1868
1869         Reviewed by Antti Koivisto.
1870
1871         * LayoutReloaded/misc/LFC-passing-tests.txt:
1872
1873 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1874
1875         Unreviewed, fix typo that breaks dashboard link.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1878         (WebKitBuildbot):
1879
1880 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1881
1882         Update macOS queue configurations
1883         https://bugs.webkit.org/show_bug.cgi?id=193329
1884
1885         Reviewed by Alexey Proskuryakov.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/config.json:
1888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1889         (BubbleQueueServer):
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1892         (WebKitBuildbot):
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1894         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1895         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1896
1897 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1898
1899         MiniBrowser should be able to navigate to about:blank
1900         https://bugs.webkit.org/show_bug.cgi?id=193345
1901
1902         Reviewed by Simon Fraser.
1903
1904         * MiniBrowser/mac/BrowserWindowController.m:
1905         (-[BrowserWindowController addProtocolIfNecessary:]):
1906         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1907
1908         * MiniBrowser/mac/WK1BrowserWindowController.m:
1909         (-[WK1BrowserWindowController fetch:]):
1910         * MiniBrowser/mac/WK2BrowserWindowController.m:
1911         (-[WK2BrowserWindowController fetch:]):
1912         Clean up the code that uses this to match style.
1913
1914 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1915
1916         Remove MiniBrowser custom "Process Swap" menu item which does not work
1917         https://bugs.webkit.org/show_bug.cgi?id=193344
1918
1919         Reviewed by Simon Fraser.
1920
1921         There is a menu item under the Experimental menu that does work.
1922
1923         * MiniBrowser/mac/AppDelegate.m:
1924         (defaultConfiguration):
1925         * MiniBrowser/mac/SettingsController.h:
1926         * MiniBrowser/mac/SettingsController.m:
1927         (-[SettingsController _populateMenu]):
1928         (-[SettingsController validateMenuItem:]):
1929         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1930         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1931
1932 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1933
1934         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1935         https://bugs.webkit.org/show_bug.cgi?id=193327
1936         rdar://problem/47093222
1937
1938         Reviewed by Tim Horton.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1942         (TestWebKitAPI::didFinishNavigation):
1943         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1944         (TestWebKitAPI::TEST):
1945         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1946         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1947         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1948         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1949         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1950
1951 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1952
1953         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1954         https://bugs.webkit.org/show_bug.cgi?id=193338
1955         <rdar://problem/46664774>
1956
1957         Reviewed by David Kilzer.
1958
1959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1960         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1961
1962 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1963
1964         Unreviewed, rolling out r239825.
1965         https://bugs.webkit.org/show_bug.cgi?id=193330
1966
1967         Broke tests on armv7/linux bots (Requested by guijemont on
1968         #webkit).
1969
1970         Reverted changeset:
1971
1972         "Enable DFG on ARM/Linux again"
1973         https://bugs.webkit.org/show_bug.cgi?id=192496
1974         https://trac.webkit.org/changeset/239825
1975
1976 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1977
1978         Disable the run-jsc-stress-test remote host key check.
1979         https://bugs.webkit.org/show_bug.cgi?id=192988
1980
1981         Reviewed by Alexey Proskuryakov.
1982
1983         * Scripts/run-jsc-stress-tests:
1984
1985 2019-01-10  John Wilander  <wilander@apple.com>
1986
1987         Override the session configuration for cookieAcceptPolicy
1988         https://bugs.webkit.org/show_bug.cgi?id=190925
1989         <rdar://problem/45497382>
1990
1991         Reviewed by Alexey Proskuryakov and Alex Christensen.
1992
1993         Test infrastructure for setting a first-party-only cookie policy.
1994
1995         * DumpRenderTree/TestRunner.cpp:
1996         (setOnlyAcceptFirstPartyCookiesCallback):
1997         (TestRunner::staticFunctions):
1998         * DumpRenderTree/TestRunner.h:
1999         * DumpRenderTree/mac/TestRunnerMac.mm:
2000         (TestRunner::setOnlyAcceptFirstPartyCookies):
2001         * DumpRenderTree/win/TestRunnerWin.cpp:
2002         (TestRunner::setOnlyAcceptFirstPartyCookies):
2003         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2005         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2006         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2007         * WebKitTestRunner/TestInvocation.cpp:
2008         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2009
2010 2019-01-09  Matt Rajca  <mrajca@apple.com>
2011
2012         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2013         https://bugs.webkit.org/show_bug.cgi?id=193301
2014
2015         Reviewed by Jer Noble.
2016         
2017         Added API tests.
2018
2019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2020         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2021         (TEST):
2022         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2023
2024 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2025
2026         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2027         https://bugs.webkit.org/show_bug.cgi?id=193310
2028
2029         Reviewed by Antti Koivisto.
2030
2031         * LayoutReloaded/misc/LFC-passing-tests.txt:
2032
2033 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2034
2035         Enable DFG on ARM/Linux again
2036         https://bugs.webkit.org/show_bug.cgi?id=192496
2037
2038         Reviewed by Yusuke Suzuki.
2039
2040         After changing the bytecode format DFG was disabled on all 32-bit
2041         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2042         on ARM by default.
2043
2044         * Scripts/run-jsc-stress-tests:
2045
2046 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2047
2048         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2049         https://bugs.webkit.org/show_bug.cgi?id=193271
2050
2051         Reviewed by Brent Fulgham.
2052
2053         BSTR is a special data structure created by SysAllocString, not a
2054         wchar_t null-terminated string.
2055
2056         * DumpRenderTree/win/TestRunnerWin.cpp:
2057         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2058         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2059         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2060         BSTR from wide string literals.
2061
2062 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2063
2064         Tweak wording for build/version_check style checker error
2065         https://bugs.webkit.org/show_bug.cgi?id=193256
2066
2067         Reviewed by Tim Horton.
2068
2069         * Scripts/webkitpy/style/checkers/cpp.py:
2070         (check_os_version_checks):
2071         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2072         (WebKitStyleTest.test_os_version_checks):
2073
2074 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2075
2076         [ews-build] Add link to bug along with bug title
2077         https://bugs.webkit.org/show_bug.cgi?id=193293
2078
2079         Reviewed by Lucas Forschler.
2080
2081         * BuildSlaveSupport/ews-build/steps.py:
2082         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2083         (ConfigureBuild.add_bug_id_url): Deleted.
2084         (ConfigureBuild.getBugURL): Deleted.
2085
2086 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-build] Use https for ews-build server
2089         https://bugs.webkit.org/show_bug.cgi?id=193193
2090
2091         Reviewed by Lucas Forschler.
2092
2093         * BuildSlaveSupport/ews-build/steps.py:
2094
2095 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-build] Parse and display number of style failures
2098         https://bugs.webkit.org/show_bug.cgi?id=193280
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-build/steps.py:
2103         (CheckStyle): Use TestWithFailureCount as base class.
2104         (CheckStyle.countFailures): Count the number of style failures.
2105
2106 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2107
2108         [ews-build] use patch_id instead of ewspatchid
2109         https://bugs.webkit.org/show_bug.cgi?id=193235
2110
2111         Reviewed by Lucas Forschler.
2112
2113         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2114         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2115         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2116
2117 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2118
2119         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2120         https://bugs.webkit.org/show_bug.cgi?id=192625
2121
2122         Reviewed by Antti Koivisto.
2123
2124         * LayoutReloaded/misc/LFC-passing-tests.txt:
2125
2126 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2127
2128         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2129         https://bugs.webkit.org/show_bug.cgi?id=192841
2130
2131         Reviewed by Carlos Garcia Campos.
2132
2133         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2134         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2135         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2136
2137         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2138
2139         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2140         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2141         (WebKitWebEditorTest::testSelectionChanged):
2142         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2143         (WebKitFrameTest::testMainFrame):
2144         (WebKitFrameTest::testURI):
2145         (WebKitFrameTest::testJavaScriptContext):
2146         (WebKitFrameTest::testJavaScriptValues):
2147         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2148         (testWebViewAuthenticationRequest):
2149         (testWebViewAuthenticationLoadCancelled):
2150         (testWebViewAuthenticationFailure):
2151         (testWebViewAuthenticationStorage):
2152         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2153         (testWebViewAuthenticationProxy):
2154         (testWebViewAuthenticationProxyHTTPS):
2155         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2156         (testAutomationSessionRequestSession):
2157         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2158         (testBackForwardListNavigation):
2159         (testWebKitWebViewSessionState):
2160         (testWebKitWebViewSessionStateWithFormData):
2161         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2162         (ConsoleMessageTest::consoleMessageReceivedCallback):
2163         (testWebKitConsoleMessageConsoleAPI):
2164         (testWebKitConsoleMessageJavaScriptException):
2165         (testWebKitConsoleMessageNetworkError):
2166         (testWebKitConsoleMessageSecurityError):
2167         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2168         (testCookieManagerAcceptPolicy):
2169         (testCookieManagerCookiesChanged):
2170         (testCookieManagerPersistentStorage):
2171         (testCookieManagerPersistentStorageDeleteAll):
2172         (testCookieManagerEphemeral):
2173         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2174         (testWebKitDOMElementAutoFill):
2175         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2176         (downloadLocalFileSuccessfully):
2177         (createFileAtDestination):
2178         (testDownloadOverwriteDestinationDisallowed):
2179         (testDownloadLocalFileError):
2180         (testDownloadRemoteFile):
2181         (testDownloadRemoteFileError):
2182         (testWebViewDownloadURI):
2183         (testPolicyResponseDownload):
2184         (testPolicyResponseDownloadCancel):
2185         (testDownloadMIMEType):
2186         (contextMenuCallback):
2187         (testContextMenuDownloadActions):
2188         (testBlobDownload):
2189         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2190         (testWebKitWebEditorSelectionChanged):
2191         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2192         (testWebKitFrameMainFrame):
2193         (testWebKitFrameURI):
2194         (testWebKitFrameJavaScriptContext):
2195         (testWebKitFrameJavaScriptValues):
2196         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2197         (LoadStopTrackingTest::loadFailed):
2198         (testWebViewTitle):
2199         (testURIRequestHTTPHeaders):
2200         (testURIRequestHTTPMethod):
2201         (testURIResponseHTTPHeaders):
2202         (testRedirectToDataURI):
2203         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2204         (testProcessPerWebView):
2205         (testWebProcessLimit):
2206         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2207         (testWebViewResources):
2208         (testWebResourceLoading):
2209         (testWebResourceSuggestedFilename):
2210         (testWebResourceGetData):
2211         (testWebResourceGetDataError):
2212         (testWebViewResourcesHistoryCache):
2213         (testWebResourceSendRequest):
2214         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2215         (testSSL):
2216         (testInsecureContent):
2217         (testTLSErrorsPolicy):
2218         (testTLSErrorsRedirect):
2219         (testTLSErrorsHTTPAuth):
2220         (testLoadFailedWithTLSErrors):
2221         (testSubresourceLoadFailedWithTLSErrors):
2222         (httpsServerCallback):
2223         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2224         (testWebViewCreateNavigationData):
2225         (testWebViewJavaScriptDialogs):
2226         (testWebViewWindowProperties):
2227         (testWebViewMouseTarget):
2228         (testWebViewFileChooserRequest):
2229         (testWebViewColorChooserRequest):
2230         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2231         (testWebExtensionGetTitle):
2232         (testDocumentLoadedSignal):
2233         (testWebKitWebViewProcessCrashed):
2234         (testWebExtensionWindowObjectCleared):
2235         (testWebExtensionIsolatedWorld):
2236         (permissionRequestCallback):
2237         (didAssociateFormControlsCallback):
2238         (testWebExtensionFormControlsAssociated):
2239         (FormSubmissionTest::FormSubmissionTest):
2240         (FormSubmissionTest::testFormSubmissionResult):
2241         (testWebExtensionFormSubmissionSteps):
2242         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2243         (testNotInitialized):
2244         (testClearDatabase):
2245         (testPrivateBrowsing):
2246         (testGetFavicon):
2247         (testWebViewFavicon):
2248         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2249         (testFindControllerTextFound):
2250         (testFindControllerTextNotFound):
2251         (testFindControllerMatchCount):
2252         (testFindControllerMaxMatchCount):
2253         (testFindControllerNext):
2254         (testFindControllerPrevious):
2255         (testFindControllerCountedMatches):
2256         (testFindControllerOptions):
2257         (testFindControllerHide):
2258         (testFindControllerInstance):
2259         (testFindControllerGetters):
2260         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2261         (testNavigationPolicy):
2262         (testResponsePolicy):
2263         (testNewWindowPolicy):
2264         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2265         (testSecurityOriginBasicConstructor):
2266         (testSecurityOriginURIConstructor):
2267         (testSecurityOriginDefaultPort):
2268         (testSecurityOriginFileURI):
2269         (testOpaqueSecurityOrigin):
2270         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2271         (testWebKitSettings):
2272         (testWebKitSettingsNewWithSettings):
2273         (testWebKitSettingsUserAgent):
2274         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2275         (testWebViewNewWithUserContentManager):
2276         (isStyleSheetInjectedForURLAtPath):
2277         (isScriptInjectedForURLAtPath):
2278         (testUserContentManagerInjectedStyleSheet):
2279         (testUserContentManagerInjectedScript):
2280         (UserScriptMessageTest::scriptMessageReceived):
2281         (UserScriptMessageTest::waitUntilMessageReceived):
2282         (UserScriptMessageTest::runJavaScriptFinished):
2283         (testUserContentManagerScriptMessageReceived):
2284         (testUserContentManagerScriptMessageInWorldReceived):
2285         (testUserContentManagerScriptMessageFromDOMBindings):
2286         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2287         (testWebContextDefault):
2288         (testWebContextEphemeral):
2289         (testWebContextGetPlugins):
2290         (testWebContextURIScheme):
2291         (testWebContextSpellChecker):
2292         (testWebContextLanguages):
2293         (consoleMessageReceivedCallback):
2294         (testWebContextSecurityFileXHR):
2295         (ProxyTest::ProxyTest):
2296         (testWebContextProxySettings):
2297         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2298         (testWebViewWebContext):
2299         (testWebViewWebBackend):
2300         (testWebViewEphemeral):
2301         (testWebViewCustomCharset):
2302         (testWebViewSettings):
2303         (testWebViewRunJavaScript):
2304         (testWebViewCanShowMIMEType):
2305         (testWebViewSubmitForm):
2306         (testWebViewSave):
2307         (testWebViewPageVisibility):
2308         (testWebViewSnapshot):
2309         (testWebViewNotification):
2310         (testWebViewNotificationInitialPermissionAllowed):
2311         (testWebViewNotificationInitialPermissionDisallowed):
2312         (testWebViewIsPlayingAudio):
2313         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2314         (WebsiteDataTest::WebsiteDataTest):
2315         (WebsiteDataTest::remove):
2316         (WebsiteDataTest::clear):
2317         (testWebsiteDataConfiguration):
2318         (testWebsiteDataEphemeral):
2319         (testWebsiteDataCache):
2320         (testWebsiteDataStorage):
2321         (testWebsiteDataDatabases):
2322         (testWebsiteDataAppcache):
2323         (testWebsiteDataCookies):
2324         (testWebsiteDataDeviceIdHashSalt):
2325         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2326         (emitDocumentLoaded):
2327         (emitURIChanged):
2328         (sendRequestCallback):
2329         (contextMenuCallback):
2330         (consoleMessageSentCallback):
2331         (emitFormControlsAssociated):
2332         (formControlsAssociatedCallback):
2333         (emitFormSubmissionEvent):
2334         (willSubmitFormCallback):
2335         (windowObjectCleared):
2336         (methodCallCallback):
2337         (registerGResource):
2338         (webkit_web_extension_initialize_with_user_data):
2339         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2340         (checkLeaks):
2341         (WebProcessTest::create):
2342         (runTest):
2343         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2344         (AutocleanupsTest::testWebProcessAutocleanups):
2345         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2346         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2347         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2348         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2349         (WebKitDOMDOMWindowTest::testSignals):
2350         (WebKitDOMDOMWindowTest::testDispatchEvent):
2351         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2352         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2353         (WebKitDOMNodeFilterTest::testTreeWalker):
2354         (WebKitDOMNodeFilterTest::testNodeIterator):
2355         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2356         (WebKitDOMNodeTest::testHierarchyNavigation):
2357         (WebKitDOMNodeTest::testInsertion):
2358         (WebKitDOMNodeTest::testTagNamesNodeList):
2359         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2360         (WebKitDOMNodeTest::testDOMCache):
2361         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2362         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2363         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2364         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2365         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2366         (testUIProcessAutocleanups):
2367         (testWebProcessAutocleanups):
2368         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2369         (testContextMenuPopulateMenu):
2370         (testContextMenuDismissed):
2371         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2372         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2373         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2374         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2375         (testWebKitDOMDOMWindowSignals):
2376         (testWebKitDOMDOMWindowDispatchEvent):
2377         (testWebKitDOMDOMWindowGetComputedStyle):
2378         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2379         (testWebKitDOMNodeHierarchyNavigation):
2380         (testWebKitDOMNodeInsertion):
2381         (testWebKitDOMNodeTagNamesNodeList):
2382         (testWebKitDOMNodeTagNamesHTMLCollection):
2383         (testWebKitDOMObjectCache):
2384         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2385         (testWebKitDOMNodeFilterTreeWalker):
2386         (testWebKitDOMNodeFilterNodeIterator):
2387         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2388         (testWebKitDOMXPathNSResolverNative):
2389         (testWebKitDOMXPathNSResolverCustom):
2390         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2391         (testInspectorDefault):
2392         (testInspectorManualAttachDetach):
2393         (testInspectorCustomContainerDestroyed):
2394         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2395         (startTestServer):
2396         (testInspectorServerPageList):
2397         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2398         (OptionMenuTest::showOptionMenuCallback):
2399         (OptionMenuTest::menuCloseCallback):
2400         (OptionMenuTest::close):
2401         (OptionMenuTest::activateItem):
2402         (OptionMenuTest::selectItem):
2403         (testOptionMenuSimple):
2404         (testOptionMenuGroups):
2405         (testOptionMenuActivate):
2406         (testOptionMenuSelect):
2407         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2408         (testPrintOperationPrintSettings):
2409         (webViewPrintCallback):
2410         (testPrintOperationPrint):
2411         (testPrintCustomWidget):
2412         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2413         (checkAtspiAccessible):
2414         (testAtspiBasicHierarchy):
2415         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2416         (testWebKitCheckVersion):
2417         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2418         (testWebViewEditorCutCopyPasteNonEditable):
2419         (testWebViewEditorCutCopyPasteEditable):
2420         (testWebViewEditorSelectAllNonEditable):
2421         (testWebViewEditorSelectAllEditable):
2422         (loadContentsAndTryToCutSelection):
2423         (testWebViewEditorNonEditable):
2424         (testWebViewEditorEditable):
2425         (testWebViewEditorEditorStateTypingAttributes):
2426         (testWebViewEditorInsertImage):
2427         (testWebViewEditorCreateLink):
2428         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2429         (loadChangedCallback):
2430         (loadFailedCallback):
2431         (loadFailedWithTLSErrorsCallback):
2432         (LoadTrackingTest::LoadTrackingTest):
2433         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2434         (registerGResource):
2435         (removeNonEmptyDirectory):
2436         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2437         (Test::adoptView):
2438         (Test::~Test):
2439         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2440         (WebKitTestBus::getOrCreateConnection):
2441         (WebKitTestBus::createProxy):
2442         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2443         (WebKitTestServer::getWebSocketURIForPath const):
2444         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2445         (WebViewTest::initializeWebView):
2446         (WebViewTest::loadURI):
2447         (WebViewTest::loadHtml):
2448         (WebViewTest::loadPlainText):
2449         (WebViewTest::loadBytes):
2450         (WebViewTest::loadRequest):
2451         (WebViewTest::loadAlternateHTML):
2452         (WebViewTest::goBack):
2453         (WebViewTest::goForward):
2454         (WebViewTest::goToBackForwardListItem):
2455         (resourceGetDataCallback):
2456         (WebViewTest::mainResourceData):
2457         (WebViewTest::javascriptResultToCString):
2458         (WebViewTest::javascriptResultToNumber):
2459         (WebViewTest::javascriptResultToBoolean):
2460         (WebViewTest::javascriptResultIsNull):
2461         (WebViewTest::javascriptResultIsUndefined):
2462         (onSnapshotReady):
2463         (WebViewTest::runWebProcessTest):
2464         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2465         (WebViewTest::platformInitializeWebView):
2466         (WebViewTest::showInWindow):
2467         (WebViewTest::showInWindowAndWaitUntilMapped):
2468         (WebViewTest::mouseMoveTo):
2469         (WebViewTest::emitPopupMenuSignal):
2470         (WebViewTest::keyStroke):
2471         (WebViewTest::doMouseButtonEvent):
2472
2473 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2474
2475         [WPE] API tests can't run in flatpak environment
2476         https://bugs.webkit.org/show_bug.cgi?id=193242
2477
2478         Reviewed by Michael Catanzaro.
2479
2480         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2481         flatpakutils so that it knows which port it's dealing with.
2482         * glib/common.py: Remove build_dir globals so that subsequent
2483         calls actually take args into account.
2484         (library_build_path):
2485         (binary_build_path):
2486
2487 2019-01-08  Dean Jackson  <dino@apple.com>
2488
2489         Blob references for System Previews don't get a correct file extension
2490         https://bugs.webkit.org/show_bug.cgi?id=193268
2491         <rdar://problem/47133037>
2492
2493         Reviewed by Tim Horton.
2494
2495         New test that a Blob download of a USDZ file gets named correctly.
2496
2497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2498         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2499         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2500         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2501         (TEST):
2502         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2503
2504 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2505
2506         [WebAuthN] Support U2F HID Authenticators on macOS
2507         https://bugs.webkit.org/show_bug.cgi?id=191535
2508         <rdar://problem/47102027>
2509
2510         Reviewed by Brent Fulgham.
2511
2512         This patch:
2513         1) adds support for U2F mocking mechanism;
2514         2) updates tests to reflect U2fCommandConstructor changes.
2515
2516         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2521
2522 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2523
2524         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2525         https://bugs.webkit.org/show_bug.cgi?id=193229
2526         <rdar://problem/46717097>
2527
2528         Reviewed by Tim Horton.
2529
2530         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2531         prevents a drag from starting.
2532
2533         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2534         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2535
2536         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2537
2538 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2539   
2540         Layout test will generate a perf metric file to results dir.
2541         https://bugs.webkit.org/show_bug.cgi?id=192030
2542         <rdar://problem/32779516>
2543
2544         Reviewed by Aakash Jain.
2545
2546         Layout test running time will be collected to a perf metric file.
2547         For now, instead of outputing running time of all tests (which is huge),
2548         we aggregate them by test directories which are at most two level deep. 
2549
2550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2551         (Manager._end_test_run):
2552         (Manager._output_perf_metrics):
2553         (Manager._print_expectation_line_for_test):
2554         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2555         (add_test_perf_metric):
2556         (test_perf_metrics):
2557         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2558         (JSONGeneratorTest.test_test_timings_trie):
2559         (JSONGeneratorTest):
2560         (JSONGeneratorTest.test_test_perf_metrics):
2561         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2562         (RebaselineTest.test_reset_results):
2563         (RebaselineTest.test_missing_results):
2564         (RebaselineTest.test_new_baseline):
2565
2566 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2567
2568         [WPE][GTK] Add php-json to install-dependencies
2569         https://bugs.webkit.org/show_bug.cgi?id=193233
2570
2571         Reviewed by Michael Catanzaro.
2572
2573         * gtk/install-dependencies:
2574         * wpe/install-dependencies:
2575
2576 2019-01-08  Chris Dumez  <cdumez@apple.com>
2577
2578         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2579         https://bugs.webkit.org/show_bug.cgi?id=193224
2580         <rdar://problem/47097726>
2581
2582         Reviewed by Alex Christensen.
2583
2584         Add API test coverage.
2585
2586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2587
2588 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2589
2590         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2591         <https://webkit.org/b/193222>
2592         <rdar://problem/46862309>
2593
2594         Reviewed by Joseph Pecoraro.
2595
2596         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2597         (WTR::executeCallback): Fix camel case of variable name.
2598         (WTR::EventSendingController::callAfterScrollingCompletes): If
2599         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2600         false, make sure to release the ScrollCompletionCallbackData
2601         object.  This fixes the leak.
2602
2603 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2604
2605         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2606         https://bugs.webkit.org/show_bug.cgi?id=193044
2607
2608         Reviewed by Daniel Bates.
2609
2610         WinCairo EWS bots are using Windows Perl. Binary files should be
2611         opened as binary mode.
2612
2613         * Scripts/svn-apply:
2614         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2615
2616 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2617
2618         [CMake] Add ENABLE_CSS_TYPED_OM option
2619         https://bugs.webkit.org/show_bug.cgi?id=193216
2620
2621         Reviewed by Michael Catanzaro.
2622
2623         * Scripts/webkitperl/FeatureList.pm:
2624
2625 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2626
2627         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2628         <https://webkit.org/b/193056>
2629
2630         Reviewed by Alex Christensen.
2631
2632         * Scripts/webkitpy/style/checker.py:
2633         - Ignore use of new runtime/retainptr check in
2634           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2635           contains tests to ensure RetainPtr<NSObject *> is compatible
2636           with RetainPtr<NSObject>.
2637
2638         * Scripts/webkitpy/style/checkers/cpp.py:
2639         (check_language):
2640         (CppChecker):
2641         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2642           was used instead of a single regex so that angle brackets
2643           could be matched up when checking the type contained within
2644           the RetainPtr<> type.
2645
2646         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2647         (CppStyleTest):
2648         - Add unit test for new runtime/retainptr check.
2649
2650         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2651         * TestWebKitAPI/EditingTestHarness.h:
2652         - Remove '*' from RetainPtr<> type.
2653
2654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2655         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2656           regressed in r201938.
2657
2658         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2659         (TestWebKitAPI::TEST):
2660         - Update tests to match RetainPtr.mm tests (except for the
2661           `*SimilarNSType` tests since there is no CF equivalent of
2662           RetainPtr<NSString> and RetainPtr<NSString *>).
2663
2664         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2665         (TestWebKitAPI::TEST):
2666         - Update tests to:
2667           - Not conflict by name with equivalent CF tests in
2668             RetainPtr.cpp.
2669           - Add test cases for RetainPtr<NSObject>,
2670             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2671           - Add `*SimilarNSType` tests for converting between
2672             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2673           - Change `0` to `nil` as appropriate.
2674           - Re-alphabetize the tests by name.
2675           - Add Optional<RetainPtr<>> tests.
2676           - Add retainPtr() tests.
2677
2678         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2679         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2680         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2681         (TEST):
2682         - Remove '*' from RetainPtr<> type.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2685         (TEST(WebKit, JITEnabled)):
2686         - Add missing WTFMove().  Apparently a temporary was being
2687           created before in the argument list due to mismatched
2688           RetainPtr<> types.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2691         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2692         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2693         (TestWebKitAPI::TEST):
2694         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2695         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2696         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2697         (WTR::resourcesDirectoryURL):
2698         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2699         (WTR::InjectedBundle::platformInitialize):
2700         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2701         - Remove '*' from RetainPtr<> type.
2702
2703 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2704
2705         A MediaTime timescale must never be zero
2706         https://bugs.webkit.org/show_bug.cgi?id=193156
2707         <rdar://problem/32504501>
2708
2709         Reviewed by Jer Noble.
2710
2711         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2712         (TestWebKitAPI::TEST): Add tests for zero timescale.
2713
2714 2019-01-07  Youenn Fablet  <youenn@apple.com>
2715
2716         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2717         https://bugs.webkit.org/show_bug.cgi?id=193175
2718
2719         Reviewed by Chris Dumez.
2720
2721         Updated API test as we bumped the SW schema to version 4.
2722
2723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2724         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2725         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2726         (TEST):
2727
2728 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2729
2730         [Win][Clang] Fix compilation warnings of MiniBrowser
2731         https://bugs.webkit.org/show_bug.cgi?id=193029
2732
2733         Reviewed by Ross Kirsling.
2734
2735         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2736         and m_URLBarFont. Reorder member variables to fix -Wreorder
2737         warning.
2738         * MiniBrowser/win/PageLoadTestClient.cpp:
2739         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2740         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2741         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2742         m_currentURLIndex.
2743         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2744         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2745         navigationClient with '{ }' to fix the missing field warning.
2746         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2747         (initDocStruct): Changed the argument type docname to const.
2748
2749 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2750
2751         [WebAuthN] Import U2F command/response converters from Chromium
2752         https://bugs.webkit.org/show_bug.cgi?id=193150
2753         <rdar://problem/47054028>
2754
2755         Reviewed by Brent Fulgham.
2756
2757         Adds API tests.
2758
2759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2760         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2761         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2762         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2763         (TestWebKitAPI::getTestAttestationObjectBytes):
2764         (TestWebKitAPI::getTestSignResponse):
2765         (TestWebKitAPI::getTestU2fRegisterResponse):
2766         (TestWebKitAPI::TEST):
2767         (TestWebKitAPI::convertToVector): Deleted.
2768         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2769         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2770         (TestWebKitAPI::constructMakeCredentialRequest):
2771         (TestWebKitAPI::constructGetAssertionRequest):
2772         (TestWebKitAPI::TEST):
2773
2774 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2775
2776         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2777         https://bugs.webkit.org/show_bug.cgi?id=193136
2778
2779         Reviewed by Michael Catanzaro.
2780
2781         * gtk/install-dependencies:
2782         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2783         they are needed by update-webkitgtk-libs.
2784
2785 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2786
2787         Unreviewed follow-up fix to r239650
2788         https://bugs.webkit.org/show_bug.cgi?id=193140
2789         <rdar://problem/47063037>
2790
2791         Typecast patch_id to string.
2792
2793         * BuildSlaveSupport/ews-build/steps.py:
2794         (ValidatePatch._is_patch_obsolete):
2795
2796 2019-01-04  Daniel Bates  <dabates@apple.com>
2797
2798         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2799         https://bugs.webkit.org/show_bug.cgi?id=193024
2800
2801         Reviewed by Jer Noble.
2802
2803         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2804         for the bitmask type WebEventFlags as an example.
2805
2806         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2807         that can be used to register summary and synthetic child formatters for a bitmask type.
2808         For example, consider the following enum and bitmask typedefs:
2809
2810         typedef enum {
2811             A = 1 << 0,
2812             B = 1 << 1,
2813             C = 1 << 2,
2814         } SpecialFlagValues;
2815         typedef unsigned SpecialFlags;
2816
2817         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2818         __lldb_init_module():
2819
2820             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2821                     1 << 0: "A",
2822                     1 << 1: "B",
2823                     1 << 2: "C",
2824             })
2825
2826         * lldb/lldb_webkit.py:
2827         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2828         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2829         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2830         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2831         A convenience function to dynamically creaste a synthetic formatter class and summary
2832         string function for the specified bitmask type and enumerator value to name map. This
2833         function register the dynamically created class and function with LLDB.
2834
2835         (__lldb_init_module):
2836         (FlagEnumerationProvider):
2837         (FlagEnumerationProvider._enumerator_value_to_name_map):
2838         (FlagEnumerationProvider._bitmask):
2839         (FlagEnumerationProvider._update):
2840         (FlagEnumerationProvider.has_children):
2841         (FlagEnumerationProvider.num_children):
2842         (FlagEnumerationProvider.get_child_index):
2843         (FlagEnumerationProvider.get_child_at_index):
2844         (FlagEnumerationProvider.update):
2845         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2846
2847         (WTFOptionSetProvider):
2848         (WTFOptionSetProvider._enumerator_value_to_name_map):
2849         (WTFOptionSetProvider._bitmask):
2850         (WTFOptionSetProvider._update):
2851         Write in terms of the base class.
2852
2853         (RawBitmaskProviderBase):
2854         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2855         (RawBitmaskProviderBase._bitmask):
2856         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2857         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2858         {
2859             1 << 0: "A",
2860             1 << 1: "B",
2861             1 << 2: "C",
2862         }
2863         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2864         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2865
2866         (WTFOptionSetProvider.has_children): Deleted.
2867         (WTFOptionSetProvider.num_children): Deleted.
2868         (WTFOptionSetProvider.get_child_index): Deleted.
2869         (WTFOptionSetProvider.get_child_at_index): Deleted.
2870         (WTFOptionSetProvider.update): Deleted.
2871
2872 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2873
2874         [ews-build] Add build step to validate the patch before processing it
2875         https://bugs.webkit.org/show_bug.cgi?id=193140
2876
2877         Reviewed by Lucas Forschler.
2878
2879         * BuildSlaveSupport/ews-build/factories.py:
2880         (Factory.__init__): Added ValidatePatch step.
2881         * BuildSlaveSupport/ews-build/steps.py:
2882         (ValidatePatch):
2883         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2884         (ValidatePatch.get_patch_json): Get patch json data.
2885         (ValidatePatch.get_bug_json): Get bug json data.
2886         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2887         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2888         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2889         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2890         (ValidatePatch.skip_build): Skip the build.
2891         (ValidatePatch.start):
2892
2893 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2894
2895         Progress towards fixing Mac CMake build
2896         https://bugs.webkit.org/show_bug.cgi?id=193105
2897
2898         Reviewed by Don Olmstead.
2899
2900         * TestWebKitAPI/PlatformMac.cmake:
2901
2902 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2903
2904         Fix API test after r239631
2905         https://bugs.webkit.org/show_bug.cgi?id=193118
2906
2907         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2908         (TestWebKitAPI::TEST):
2909         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2910         Do the same thing via the API to fix the test.
2911
2912 2019-01-04  Jer Noble  <jer.noble@apple.com>
2913
2914         [WebKitLegacy] Media playback pauses on scroll
2915         https://bugs.webkit.org/show_bug.cgi?id=192829
2916
2917         Reviewed by Eric Carlson.
2918
2919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2920         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2921         (TestWebKitAPI::TEST):
2922         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2923         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2924         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2925         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2926         (TestWebKitAPI::TEST):
2927
2928 2019-01-04  Chris Dumez  <cdumez@apple.com>
2929
2930         Add support for toggling device orientation API support per site
2931         https://bugs.webkit.org/show_bug.cgi?id=193143
2932         <rdar://problem/46605724>
2933
2934         Reviewed by Alex Christensen.
2935
2936         Add API test coverage.
2937
2938         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2939         (-[DataMappingSchemeHandler setTaskHandler:]):
2940         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2941         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2942         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2943         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2944
2945 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-build] use svn-apply script to apply the patches
2948         https://bugs.webkit.org/show_bug.cgi?id=193138
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-build/factories.py:
2953         (Factory.__init__): Add the ApplyPatch step.
2954         * BuildSlaveSupport/ews-build/steps.py:
2955         (CheckOutSource): Added step name.
2956         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2957         (ApplyPatch): Build step to apply patch using svn-apply script.
2958         (UnApplyPatchIfRequired):
2959         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2960
2961 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2962
2963         Deprecate WKContextCreate
2964         https://bugs.webkit.org/show_bug.cgi?id=193118
2965
2966         Reviewed by Brady Eidson.
2967
2968         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2969         (WebKitBrowserWindow::WebKitBrowserWindow):
2970         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2973         (TestWebKitAPI::TEST):
2974         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2975         (TestWebKitAPI::TEST):
2976         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2977         (TestWebKitAPI::TEST):
2978         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2981         (TestWebKitAPI::TEST):
2982         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2983         (TestWebKitAPI::TEST):
2984         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2985         (TestWebKitAPI::TEST):
2986         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2991         (TestWebKitAPI::TEST):
2992         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2993         (TestWebKitAPI::TEST):
2994         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2995         (TestWebKitAPI::TEST):
2996         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2999         (TestWebKitAPI::TEST):
3000         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3001         (TestWebKitAPI::TEST):
3002         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3003         (TestWebKitAPI::TEST):
3004         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3005         (TestWebKitAPI::TEST):
3006         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3007         (TestWebKitAPI::loadAlternateHTMLString):
3008         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3009         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3010         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3011         (TestWebKitAPI::buildAndPerformTest):
3012         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3013         (TestWebKitAPI::TEST):
3014         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3015         (TestWebKitAPI::TEST):
3016         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3017         (TestWebKitAPI::TEST):
3018         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3019         (TestWebKitAPI::TEST):
3020         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3021         (TestWebKitAPI::TEST):
3022         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3023         (TestWebKitAPI::TEST):
3024         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3025         (TestWebKitAPI::TEST):
3026         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3029         (TestWebKitAPI::TEST):
3030         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3031         (TestWebKitAPI::TEST):
3032         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3033         (TestWebKitAPI::TEST):
3034         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3035         (TestWebKitAPI::TEST):
3036         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3037         (TestWebKitAPI::TEST):
3038         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3039         (TestWebKitAPI::TEST):
3040         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3041         (TestWebKitAPI::TEST):
3042         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3043         (TestWebKitAPI::TEST):
3044         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3045         (TestWebKitAPI::TEST):
3046         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3047         (TestWebKitAPI::TEST):
3048         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3049         (TestWebKitAPI::TEST):
3050         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3051         (TestWebKitAPI::TEST):
3052         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3053         (TestWebKitAPI::TEST):
3054         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3055         (TestWebKitAPI::TEST):
3056         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3057         (TestWebKitAPI::TEST):
3058         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3059         (TestWebKitAPI::TEST):
3060         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3061         (TestWebKitAPI::TEST):
3062         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3063         (TestWebKitAPI::TEST):
3064         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3065         (WebKit2_CommandBackForwardTestWKView::SetUp):
3066         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3067         (TestWebKitAPI::TEST):
3068         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3069         (TestWebKitAPI::TEST):
3070         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3073         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3074
3075 2019-01-03  Matt Rajca  <mrajca@apple.com>
3076
3077         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3078         https://bugs.webkit.org/show_bug.cgi?id=193128
3079         rdar://34554231
3080
3081         Reviewed by Jer Noble.
3082
3083         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3084         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3085         event along with a flag that indicates whether or not autoplay was actually prevented.
3086
3087         Tests: existing API tests were updated to reflect the new names. New API tests
3088         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3089
3090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3091         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3092         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3093         (TEST):
3094         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3095         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3096
3097 2019-01-04  Chris Dumez  <cdumez@apple.com>
3098
3099         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3100         https://bugs.webkit.org/show_bug.cgi?id=193120
3101
3102         Reviewed by Alex Christensen.
3103
3104         Add API test coverage.
3105
3106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3107
3108 2019-01-04  Chris Dumez  <cdumez@apple.com>
3109
3110         Crash under WebProcessPool::addSuspendedPage()
3111         https://bugs.webkit.org/show_bug.cgi?id=193110
3112
3113         Reviewed by Youenn Fablet.
3114
3115         Add API test coverage.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3118
3119 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3120
3121         [ews-build] Check patch relevance before applying the patch
3122         https://bugs.webkit.org/show_bug.cgi?id=193102
3123
3124         Reviewed by Lucas Forschler.
3125
3126         * BuildSlaveSupport/ews-build/factories.py:
3127         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3128
3129 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-build] Check patch relevance step should print patch id
3132         https://bugs.webkit.org/show_bug.cgi?id=193137
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-build/steps.py:
3137         (CheckPatchRelevance.start): Update the status to include patch id.
3138
3139 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3140
3141         webkitpy: Increase simulator teardown timeout
3142         https://bugs.webkit.org/show_bug.cgi?id=193141
3143         <rdar://problem/46174217>
3144
3145         Rubber-stamped by Aakash Jain.
3146
3147         * Scripts/webkitpy/xcode/simulated_device.py:
3148         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3149
3150 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3151
3152         test262-runner misbehaves when test file YAML has a trailing space
3153         https://bugs.webkit.org/show_bug.cgi?id=193053
3154
3155         Reviewed by Yusuke Suzuki.
3156
3157         * Scripts/test262/Runner.pm:
3158         (parseData):
3159         Accept trailing space when parsing a test file's YAML block.
3160
3161 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3162
3163         UserMedia test should use WKPageNavigationClient
3164         https://bugs.webkit.org/show_bug.cgi?id=192913
3165
3166         Reviewed by Youenn Fablet.
3167
3168         The test currently uses the deprecated WKPageLoaderClient. It should use
3169         WKPageNavigationClient instead, which provides the same callback under a similar name.
3170
3171         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3172         (TestWebKitAPI::TEST):
3173
3174 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3175
3176         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3177         https://bugs.webkit.org/show_bug.cgi?id=192944
3178
3179         Reviewed by Tim Horton.
3180
3181         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3182         (TestWebKitAPI::TEST):
3183
3184 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3185
3186         Add support for using the current text selection as the find string on iOS
3187         https://bugs.webkit.org/show_bug.cgi?id=193034
3188         <rdar://problem/45138739>
3189
3190         Reviewed by Tim Horton.
3191
3192         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3193         _setStringForFind) works as expected.
3194
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3196         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3197
3198 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3199
3200         [ews-build] Use git on OpenSource EWS bots
3201         https://bugs.webkit.org/show_bug.cgi?id=193092
3202
3203         Reviewed by Lucas Forschler.
3204
3205         * BuildSlaveSupport/ews-build/steps.py:
3206         (CheckOutSource): Use git instead of svn.
3207         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3208
3209 2019-01-02  Daniel Bates  <dabates@apple.com>
3210
3211         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3212         https://bugs.webkit.org/show_bug.cgi?id=193023
3213
3214         Reviewed by Simon Fraser.
3215
3216         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3217         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3218         enumerator values. We should just remove this code.
3219
3220         * lldb/lldb_webkit.py:
3221         (WTFOptionSetProvider.has_children):
3222         (WTFOptionSetProvider.num_children):
3223         (WTFOptionSetProvider.get_child_index):
3224         (WTFOptionSetProvider.get_child_at_index):
3225
3226 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3227
3228         .ycm_extra_conf.py should handle XXXInlines.h
3229         https://bugs.webkit.org/show_bug.cgi?id=193055
3230
3231         Reviewed by Carlos Garcia Campos.
3232
3233         compile_commands.json database only records flags and options for cpp source files.
3234         So, when we open headers, this database does not have any information for that.
3235         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3236         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3237         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3238         we attempt to find XXX.cpp and use the configuration if it exists.
3239
3240         * gtk/ycm_extra_conf.py:
3241         (getImplementationFilename):
3242         (FlagsForFile):
3243
3244 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3245
3246         Unreviewed. Support PHP 7.3 in Debian.
3247
3248         Add 7.3 to the list of php versions supported in Debian.
3249
3250         * Scripts/webkitpy/port/base.py:
3251         (Port._debian_php_version):
3252
3253 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3254
3255         Resurrect Mac CMake build
3256         https://bugs.webkit.org/show_bug.cgi?id=192658
3257
3258         Reviewed by Yusuke Suzuki.
3259
3260         * DumpRenderTree/PlatformMac.cmake:
3261         * MiniBrowser/mac/CMakeLists.txt:
3262         * TestWebKitAPI/PlatformMac.cmake:
3263
3264 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3265
3266         [Tools] Remove references to Bison and Flex
3267         https://bugs.webkit.org/show_bug.cgi?id=193033
3268
3269         Reviewed by Michael Catanzaro.
3270
3271         The Bison and Flex tools are not needed anymore since r209883.
3272
3273         * CygwinDownloader/cygwin-downloader.py:
3274         * EWSTools/ubuntu-ews-packages:
3275         * Scripts/filter-build-webkit:
3276         (shouldIgnoreLine):
3277         * gtk/install-dependencies:
3278         * wpe/install-dependencies:
3279
3280 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3281
3282         WebDriver: warn about non existing tests when parsing expectations
3283         https://bugs.webkit.org/show_bug.cgi?id=192979
3284
3285         Reviewed by Michael Catanzaro.
3286
3287         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3288         renamed.
3289
3290         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3291         (WebDriverTestRunner.__init__):
3292
3293 2018-12-21  Chris Dumez  <cdumez@apple.com>
3294
3295         navigator.userAgent in service workers does not reflect customUserAgent set by client
3296         https://bugs.webkit.org/show_bug.cgi?id=192951
3297
3298         Reviewed by Youenn Fablet.
3299
3300         Extend API test coverage.
3301
3302         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3303         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3304         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3305         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3306         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3307
3308 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3309
3310         [WebAuthN] userPresence should always be true
3311         https://bugs.webkit.org/show_bug.cgi?id=192835
3312         <rdar://problem/46538788>
3313
3314         Reviewed by Brent Fulgham.
3315
3316         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3317         (TestWebKitAPI::TEST):
3318
3319 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3320
3321         Add support to run-benchmark to use non-default copies of the browser apps
3322         https://bugs.webkit.org/show_bug.cgi?id=192905
3323         rdar://problem/46845840
3324
3325         Reviewed by Dewei Zhu.
3326         
3327         Add support for a --browser-path argument to run-benchmark, which allows you to use
3328         a custom app bundle for a given browser (only implemented for Safari at present).
3329
3330         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3331         (BenchmarkRunner.__init__):
3332         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3333         (BrowserDriver.__init__):
3334         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3335         (BrowserDriverFactory.create):
3336         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3337         (OSXBrowserDriver._launch_process):
3338         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3339         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3340         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3341         (OSXChromeCanaryDriver.launch_url):
3342         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3343         (OSXFirefoxNightlyDriver.launch_url):
3344         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3345         (OSXSafariDriver.__init__):
3346         (OSXSafariDriver.launch_url):
3347         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3348         (parse_args):
3349         (run_benchmark_plan):
3350         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3351         (WebServerBenchmarkRunner.__init__):
3352         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3353         (FakeBenchmarkRunner.__init__):
3354
3355 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3356
3357         [WebAuthN] Import an APDU coder from Chromium
3358         https://bugs.webkit.org/show_bug.cgi?id=192949
3359         <rdar://problem/46879933>
3360
3361         Reviewed by Brent Fulgham.
3362
3363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3364         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3365         (TestWebKitAPI::TEST):
3366
3367 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3368
3369         Setting the file wrapper and content type of an attachment to a PDF should update its image
3370         https://bugs.webkit.org/show_bug.cgi?id=192984
3371         <rdar://problem/46798028>
3372
3373         Reviewed by Tim Horton.
3374
3375         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3376         PDF data correctly updates the image element.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3379
3380 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3381
3382         Add JSCOnly to bot dashboard
3383         https://bugs.webkit.org/show_bug.cgi?id=192964
3384
3385         Reviewed by Alexey Proskuryakov.
3386
3387         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3388         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3389         useful if they were not so secret, so add them.
3390
3391         There appear to be no build-only bots, so the first column is blank. And of course there are
3392         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3393         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3394         and there's plenty of room in the final column for all the bots.
3395
3396         I had a hard time picking a logo to use, because the JavaScript language does not have an
3397         official logo. But I believe I've found one that will be satisfactory.
3398
3399         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3400
3401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3404         (BubbleQueueServer):
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3407         (WebKitBuildbot):
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3409         (table.queue-grid tr.platform.linux-jsconly img.logo):
3410
3411 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3412
3413         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3414         https://bugs.webkit.org/show_bug.cgi?id=192821
3415
3416         Reviewed by Chris Dumez.
3417
3418         * DumpRenderTree/mac/DumpRenderTree.mm:
3419         (createWebViewAndOffscreenWindow):
3420         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3421
3422 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3423
3424         [Win][Clang] Fix compilation warnings of DumpRenderTree
3425         https://bugs.webkit.org/show_bug.cgi?id=192924
3426
3427         Reviewed by Alex Christensen.
3428
3429         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3430         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3431         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3432         * DumpRenderTree/win/DumpRenderTree.cpp:
3433         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3434         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3435         object to the argument of setDefaultTextEncodingName instead of a
3436         const string literal.
3437         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3438         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3439         (setCacheFolder): Deleted.
3440         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3441         * DumpRenderTree/win/EditingDelegate.cpp:
3442         (dump): Use %d for int.
3443         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3444         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3445         (BSTRFromString): Deleted unused function.
3446         * DumpRenderTree/win/TestRunnerWin.cpp:
3447         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3448         the arguemnt of setQuota instead of const string literal.
3449         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3450         (jsStringRefToWString): Deleted unused function.
3451
3452 2018-12-20  Chris Dumez  <cdumez@apple.com>
3453
3454         Add API test coverage for customUserAgent client setting and service workers
3455         https://bugs.webkit.org/show_bug.cgi?id=192952
3456
3457         Reviewed by Alex Christensen.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3460         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3461         (-[SWSchemes webView:startURLSchemeTask:]):
3462         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3463         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3464
3465 2018-12-20  Chris Dumez  <cdumez@apple.com>
3466
3467         Use Optional::hasValue() instead of Optional::has_value()
3468         https://bugs.webkit.org/show_bug.cgi?id=192948
3469
3470         Reviewed by Tim Horton.
3471
3472         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3473         (TestWebKitAPI::TEST):
3474         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3475         (TestWebKitAPI::TEST):
3476         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3477         (TestWebKitAPI::TEST_F):
3478
3479 2018-12-20  Chris Dumez  <cdumez@apple.com>
3480
3481         Add style script rule to check for uses of std::optional<>
3482         https://bugs.webkit.org/show_bug.cgi?id=192931
3483
3484         Reviewed by Tim Horton.
3485
3486         * Scripts/webkitpy/style/checkers/cpp.py:
3487         (check_wtf_optional):
3488         (check_style):
3489
3490 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3491
3492         [WebAuthN] Add a runtime flag for local authenticator
3493         https://bugs.webkit.org/show_bug.cgi?id=192792
3494         <rdar://problem/46798738>
3495
3496         Reviewed by Brent Fulgham.
3497
3498         * DumpRenderTree/TestOptions.cpp:
3499         (TestOptions::TestOptions):
3500         * DumpRenderTree/TestOptions.h:
3501         * DumpRenderTree/mac/DumpRenderTree.mm:
3502         (enableExperimentalFeatures):
3503         (setWebPreferencesForTestOptions):
3504         * WebKitTestRunner/TestController.cpp:
3505         (WTR::TestController::resetPreferencesToConsistentValues):
3506         (WTR::updateTestOptionsFromTestHeader):
3507         * WebKitTestRunner/TestOptions.h:
3508         (WTR::TestOptions::hasSameInitializationOptions const):
3509
3510 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3511
3512         webkitpy: Autoinstall package URLs have changed
3513         https://bugs.webkit.org/show_bug.cgi?id=192909
3514         <rdar://problem/46860359>
3515
3516         Rubber-stamped by Alexey Proskuryakov.
3517
3518         PyPi urls have been moved around, we need to update our auto-installed packages.
3519
3520         We should check for Selenium before asking PyPi for the latest version.
3521
3522         * Scripts/webkitpy/thirdparty/__init__.py:
3523         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3524         (AutoinstallImportHook._install_keyring): Ditto.
3525         (AutoinstallImportHook._install_pep8): Ditto.
3526         (AutoinstallImportHook._install_mozlog): Ditto.
3527         (AutoinstallImportHook._install_mozprocess): Ditto.
3528         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3529         (AutoinstallImportHook._install_pytest): Ditto.
3530         (AutoinstallImportHook._install_pylint): Ditto.
3531         (AutoinstallImportHook._install_buildbot): Ditto.
3532         (AutoinstallImportHook._install_coverage): Ditto.
3533         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3534         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3535         for new Selenium if the installed version isn't sufficient.
3536         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3537
3538 2018-12-20  Chris Dumez  <cdumez@apple.com>
3539
3540         Use Optional::valueOr() instead of Optional::value_or()
3541         https://bugs.webkit.org/show_bug.cgi?id=192933
3542
3543         Reviewed by Geoffrey Garen.
3544
3545         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3546         (TestWebKitAPI::checkURL):
3547         (TestWebKitAPI::checkRelativeURL):
3548         (TestWebKitAPI::checkURLDifferences):
3549         (TestWebKitAPI::checkRelativeURLDifferences):
3550         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3551         (TestWebKitAPI::checkURL):
3552
3553 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3554
3555         Unreviewed, rolling out r239417.
3556
3557         Introduced two API test failures on macOS.
3558
3559         Reverted changeset:
3560
3561         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3562         occlusion changes"
3563         https://bugs.webkit.org/show_bug.cgi?id=192821
3564         https://trac.webkit.org/changeset/239417
3565
3566 2018-12-20  Devin Rousso  <drousso@apple.com>
3567
3568         Web Inspector: UIString should take an optional key and description to aid localization
3569         https://bugs.webkit.org/show_bug.cgi?id=153962
3570         <rdar://problem/24542505>
3571
3572         Reviewed by Brian Burg.
3573
3574         * Scripts/extract-localizable-js-strings:
3575
3576 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3577
3578         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3579         https://bugs.webkit.org/show_bug.cgi?id=192923
3580         <rdar://problem/46859068>
3581
3582         Reviewed by Wenson Hsieh.
3583
3584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3585         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3586         Add a test ensuring that both parented and unparented WKWebViews can
3587         retrieve main resource data when loading a PDF.
3588
3589 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3590
3591         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3592         https://bugs.webkit.org/show_bug.cgi?id=192852
3593
3594         Reviewed by Michael Catanzaro.
3595
3596         EmojiOne font was replaced by Noto Color Emoji.
3597
3598         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3599         * gtk/jhbuild.modules:
3600         * wpe/jhbuild.modules:
3601
3602 2018-12-19  Chris Dumez  <cdumez@apple.com>
3603
3604         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3605         https://bugs.webkit.org/show_bug.cgi?id=192728
3606         <rdar://problem/46746779>
3607
3608         Reviewed by Geoff Garen.
3609
3610         * DumpRenderTree/*:
3611         * MiniBrowser/*:
3612         * TestRunnerShared/*:
3613         * TestWebKitAPI/*:
3614         * WebGPUAPIStructure/*:
3615         * WebKitTestRunner/*:
3616
3617 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3618
3619         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3620         https://bugs.webkit.org/show_bug.cgi?id=192821
3621
3622         Reviewed by Chris Dumez.
3623
3624         * DumpRenderTree/mac/DumpRenderTree.mm:
3625         (createWebViewAndOffscreenWindow):
3626
3627 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3628
3629         Navigations away from the SafeBrowsing interstitial show a flash of old content
3630         https://bugs.webkit.org/show_bug.cgi?id=192676
3631
3632         Reviewed by Chris Dumez.
3633
3634         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3635         (safeBrowsingView):
3636         (TEST):
3637         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3638
3639 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3640
3641         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3642         https://bugs.webkit.org/show_bug.cgi?id=192855
3643
3644         Reviewed by Michael Catanzaro.
3645
3646         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3647         (WTR::TestController::notifyDone): Use the WPE implementation.
3648         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3649         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3650         (WTR::TestController::platformRunUntil): Honor the condition flag.
3651
3652 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3653
3654         Allow clients to set the navigator platform
3655         https://bugs.webkit.org/show_bug.cgi?id=192735
3656
3657         Reviewed by Tim Horton.
3658
3659         Add a test for setting a custom navigator platform.
3660
3661         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3662         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3663         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3664
3665 2018-12-19  Truitt Savell  <tsavell@apple.com>
3666
3667         Unreviewed, rolling out r239358.
3668
3669         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3670         crash on Debug bots
3671
3672         Reverted changeset:
3673
3674         "Clean up IndexedDB files between tests"
3675         https://bugs.webkit.org/show_bug.cgi?id=192796
3676         https://trac.webkit.org/changeset/239358
3677
3678 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3679
3680         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3681         https://bugs.webkit.org/show_bug.cgi?id=192842
3682         <rdar://problem/46823586>
3683
3684         Reviewed by Tim Horton.
3685
3686         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3687         item provider when dragging a rich text selection.
3688
3689         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3690
3691 2018-12-18  David Quesada  <david_quesada@apple.com>
3692
3693         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3694         https://bugs.webkit.org/show_bug.cgi?id=192810
3695         <rdar://problem/46812536>
3696
3697         Reviewed by Alex Christensen.
3698
3699         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3700         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3701             After releasing our reference to the web view, wait until the next turn of the runloop
3702             before checking that the originatingWebView has been zeroed, since the web view might
3703             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3704             testing general memory management of WKWebViews, only that _WKDownload does not retain
3705             its web view via the 'originatingWebView' property.
3706
3707 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3708
3709         Clean up IndexedDB files between tests
3710         https://bugs.webkit.org/show_bug.cgi?id=192796
3711
3712         Reviewed by Geoffrey Garen.
3713
3714         * DumpRenderTree/mac/DumpRenderTree.mm:
3715         (runTest):
3716         * WebKitTestRunner/TestController.cpp:
3717         (WTR::TestController::resetStateToConsistentValues):
3718         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3719         (WTR::RemoveAllIndexedDatabasesCallback):
3720         (WTR::TestController::ClearIndexedDatabases):
3721         * WebKitTestRunner/TestController.h:
3722
3723 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3724
3725         Fix API test introduced in r239339 on iOS.
3726         https://bugs.webkit.org/show_bug.cgi?id=192675
3727
3728         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3729         (TEST):
3730         The iOS implementation of the safe browsing warning is a little different.
3731         It does some element creation when it is added to the window so it knows how big it is.
3732         To test these elements, we need to simulate adding it to the window.
3733         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3734
3735 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3736
3737         webkitpy: Ignore device type for test when using --force
3738         https://bugs.webkit.org/show_bug.cgi?id=192786
3739         <rdar://problem/46794894>
3740
3741         Reviewed by Daniel Bates.
3742
3743         It is sometimes the case that a contributor will wish to run a test on a specific device,
3744         despite expectations which indicate a test should not be run on that device.
3745
3746         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3747         (parse_args):
3748         * Scripts/webkitpy/port/device_port.py:
3749         (DevicePort.default_child_processes): Strip device type information when using --force.
3750         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3751
3752 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3753
3754         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3755         https://bugs.webkit.org/show_bug.cgi?id=192675
3756
3757         Reviewed by Geoffrey Garen.
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3760         (goBack):
3761         (TEST):
3762         (visitUnsafeSite):
3763         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3764         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3765
3766 2018-12-18  Chris Dumez  <cdumez@apple.com>
3767
3768         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3769         https://bugs.webkit.org/show_bug.cgi?id=192772
3770
3771         Reviewed by Antti Koivisto.
3772
3773         Add API test coverage.
3774
3775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3776
3777 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3778
3779         Unreviewed, JHBuild GTK build fix attempt
3780
3781         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3782         There's no ninja module either, it should be provided by the
3783         host system.
3784
3785 2018-12-17  Chris Dumez  <cdumez@apple.com>
3786
3787         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3788         https://bugs.webkit.org/show_bug.cgi?id=192789
3789         <rdar://problem/46755277>
3790
3791         Reviewed by Alex Christensen.
3792
3793         Add API test coverage.
3794
3795         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3796         (TEST):
3797
3798 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3799
3800         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3801         https://bugs.webkit.org/show_bug.cgi?id=192780
3802         rdar://problem/43394387
3803
3804         Reviewed by Tim Horton.
3805
3806         No need to set "AppleFontSmoothing" defaults for WK2.
3807
3808         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3809         (WTR::InjectedBundle::platformInitialize):
3810
3811 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3812
3813         webkitpy: Handle case where stdout and stderr don't accept unicode
3814         https://bugs.webkit.org/show_bug.cgi?id=192775
3815         <rdar://problem/46497303>
3816
3817         Reviewed by Stephanie Lewis.
3818
3819         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3820         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3821         characters with '?'.
3822         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3823         (RegularTest.test_stream_with_encoding):
3824
3825 2018-12-17  Daniel Bates  <dabates@apple.com>
3826
3827         Support concatenating StringView with other string types
3828         https://bugs.webkit.org/show_bug.cgi?id=177566
3829
3830         Reviewed by Darin Adler.
3831
3832         Add some tests to ensure we do not regress the number of allocations needed when performing
3833         string concatenation with string views.
3834
3835         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3836         (TestWebKitAPI::TEST):
3837
3838 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3839
3840         Unreviewed, rolling out r239265 and r239274.
3841         https://bugs.webkit.org/show_bug.cgi?id=192765
3842
3843         unorm_normalize is deprecated, and broke an internal build
3844         (Requested by Truitt on #webkit).
3845
3846         Reverted changesets:
3847
3848         "[GTK][WPE] Need a function to convert internal URI to display
3849         ("pretty") URI"
3850         https://bugs.webkit.org/show_bug.cgi?id=174816
3851         https://trac.webkit.org/changeset/239265
3852
3853         "Fix the Apple Internal Mac build with a newer SDK"
3854         https://trac.webkit.org/changeset/239274
3855
3856 2018-12-17  Daniel Bates  <dabates@apple.com>
3857
3858         Implement UIScriptController::toggleCapsLock() for iOS
3859         https://bugs.webkit.org/show_bug.cgi?id=191815
3860
3861         Reviewed by Andy Estes.
3862
3863         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3864
3865         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3866         * WebKitTestRunner/TestController.cpp:
3867         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3868         before running a test. This ensures that the caps lock state does not persist between
3869         tests should a test enable caps lock and not disable it.
3870         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3871         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3872         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3873         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3874         create the event. Also substituted NSString* for const String& as the data type for the first
3875         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3876         below.
3877         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3878         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3879
3880 2018-12-17  Daniel Bates  <dabates@apple.com>
3881
3882         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3883         https://bugs.webkit.org/show_bug.cgi?id=192633
3884
3885         Reviewed by Wenson Hsieh.
3886
3887         Update code to use the modern initializer.
3888
3889         * DumpRenderTree/mac/EventSendingController.mm:
3890         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3891
3892 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3893
3894         Unreviewed, rolling out r239254.
3895
3896         This broke the Windows 10 Debug build
3897
3898         Reverted changeset:
3899
3900         "Replace many uses of String::format with more type-safe
3901         alternatives"
3902         https://bugs.webkit.org/show_bug.cgi?id=192742
3903         https://trac.webkit.org/changeset/239254
3904
3905 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3906
3907         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3908         <https://webkit.org/b/192751>
3909         <rdar://problem/46771623>
3910
3911         Reviewed by Daniel Bates.
3912
3913         Change loop variables to const references to avoid unnecessary
3914         copies.
3915
3916         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3917         (-[LocalPasteboard pasteboardItems]):
3918
3919 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3920
3921         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3922         https://bugs.webkit.org/show_bug.cgi?id=174816
3923
3924         Reviewed by Michael Catanzaro.
3925
3926         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3927
3928         * TestWebKitAPI/CMakeLists.txt:
3929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3930         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3931         (TestWebKitAPI::TEST):
3932         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3933         (testURIForDisplayUnaffected):
3934         (testURIForDisplayAffected):
3935         (beforeAll):
3936         (afterAll):
3937         * TestWebKitAPI/glib/CMakeLists.txt:
3938
3939 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3940
3941         [WPE] Add API to notify about frame displayed view backend callback
3942         https://bugs.webkit.org/show_bug.cgi?id=192224
3943
3944         Reviewed by Michael Catanzaro.
3945
3946         Add a test case to check the new API.
3947
3948         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3949         (testWebViewFrameDisplayed):
3950         (beforeAll):
3951         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3952
3953 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3954
3955         Unreviewed build fix after r239253
3956
3957         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3958
3959 2018-12-15  Darin Adler  <darin@apple.com>
3960
3961         Use warning-ignoring macros more consistently and simply
3962         https://bugs.webkit.org/show_bug.cgi?id=192743
3963
3964         Reviewed by Mark Lam.
3965
3966         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3967         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3968         * DumpRenderTree/mac/TextInputControllerMac.m:
3969         (-[TextInputController interpretKeyEvents:withSender:]): Use
3970         IGNORE_WARNINGS_BEGIN/END.
3971         * WebKitTestRunner/mac/EventSenderProxy.mm:
3972         (WTR::EventSenderProxy::mouseForceClick): Use
3973         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3974         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3975         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3976         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3977         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3978
3979 2018-12-15  Darin Adler  <darin@apple.com>
3980
3981         Replace many uses of String::format with more type-safe alternatives
3982         https://bugs.webkit.org/show_bug.cgi?id=192742
3983
3984         Reviewed by Mark Lam.
3985
3986         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3987         (WTR::cacheTestRunnerCallback): Use makeString.
3988         * WebKitTestRunner/TestController.cpp:
3989         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3990         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3991
3992 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3993
3994         [WPE][GTK] Add libpsl to JHBuild module sets
3995         https://bugs.webkit.org/show_bug.cgi?id=192740
3996
3997         Reviewed by Michael Catanzaro.
3998
3999         * gtk/jhbuild.modules: Add libpsl module.
4000         * wpe/jhbuild.modules: Ditto.
4001
4002 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4003
4004         Add a style checker rule for Xcode version macros use
4005         https://bugs.webkit.org/show_bug.cgi?id=192703
4006
4007         Reviewed by Alex Christensen.
4008
4009         * Scripts/webkitpy/style/checkers/cpp.py:
4010         (check_os_version_checks):
4011         (process_line):
4012         (CppChecker):
4013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4014         (WebKitStyleTest.test_os_version_checks):
4015
4016 2018-12-14  Chris Dumez  <cdumez@apple.com>
4017
4018         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4019         https://bugs.webkit.org/show_bug.cgi?id=192704
4020
4021         Reviewed by Geoffrey Garen.
4022
4023         Extend existing API test to reproduce the problem.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4026
4027 2018-12-14  Chris Dumez  <cdumez@apple.com>
4028
4029         [PSON] WebsitePolicies are lost on process-swap
4030         https://bugs.webkit.org/show_bug.cgi?id=192694
4031         <rdar://problem/46715748>
4032
4033         Reviewed by Brady Eidson.
4034
4035         Extend existing API test to reproduce the issue.
4036
4037         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4038
4039 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4040
4041         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4042         https://bugs.webkit.org/show_bug.cgi?id=192678
4043
4044         Reviewed by Carlos Garcia Campos.
4045
4046         Update our ancient versions of libsoup and glib-networking.
4047
4048         * gtk/install-dependencies:
4049         * gtk/jhbuild.modules:
4050         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4051         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4052         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4053         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4054         * wpe/install-dependencies:
4055         * wpe/jhbuild.modules:
4056         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4057
4058 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4059
4060         [WPE] Use new view state API from libwpe
4061         https://bugs.webkit.org/show_bug.cgi?id=191906
4062
4063         Reviewed by Žan Doberšek.
4064
4065         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4066         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4067         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4068         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4069         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4070         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4071         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4072         wpe_view_activity_state_focused state flags.
4073         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4074         * wpe/backends/HeadlessViewBackend.cpp:
4075         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4076         * wpe/backends/WindowViewBackend.cpp:
4077         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4078         received in configure callback.
4079         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4080
4081 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4082
4083         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4084         https://bugs.webkit.org/show_bug.cgi?id=192688
4085
4086         Reviewed by Ross Kirsling.
4087
4088         * win/DLLLauncher/DLLLauncherMain.cpp:
4089         (copyEnvironmentVariable): Moved.
4090         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4091         (applePathFromRegistry): Ditto.
4092         (appleApplicationSupportDirectory): Ditto.
4093         (prependPath): Ditto.
4094
4095 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4096
4097         Unreviewed. Changed my status to a reviewer.
4098
4099         * Scripts/webkitpy/common/config/contributors.json:
4100
4101 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4102
4103         [iOS] Support dropping contact card data (public.vcard) in editable content
4104         https://bugs.webkit.org/show_bug.cgi?id=192570
4105         <rdar://problem/35626913>
4106
4107         Reviewed by Tim Horton.
4108
4109         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4110
4111         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4112         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4113         additionally inserts a link).
4114
4115         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4116         (TestWebKitAPI::createMapItemForTesting):
4117         (TestWebKitAPI::createContactItemForTesting):
4118
4119         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4120         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4121         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4122         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4123         files.
4124
4125 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4126
4127         Unreviewed -- update my status to "reviewer".
4128
4129         * Scripts/webkitpy/common/config/contributors.json:
4130
4131 2018-12-13  Youenn Fablet  <youenn@apple.com>
4132
4133         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4134         https://bugs.webkit.org/show_bug.cgi?id=192657
4135
4136         Reviewed by Eric Carlson.
4137
4138         Add a test that loads a page registering ondevicechange,
4139         load another page in the same process, closes the first page.
4140         Ensure that the process does not crash in that case.
4141
4142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4143         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4144         (TestWebKitAPI::TEST):
4145         (TestWebKitAPI::didCrashCallback):
4146         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4147
4148 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4149
4150         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4151         https://bugs.webkit.org/show_bug.cgi?id=192643
4152
4153         Reviewed by Philippe Normand.
4154
4155         This problem happens with Arch Linux users which have libfdk-2.0.0
4156         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4157
4158         The problem has already been solved upstream at
4159         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4160
4161         Adding patches while this problem is not in a release yet.
4162
4163         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4164         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4165         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4166
4167 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4168
4169         [FreeType] Add initial implementation of variation fonts
4170         https://bugs.webkit.org/show_bug.cgi?id=192151
4171
4172         Reviewed by Michael Catanzaro.
4173
4174         Add cairo patch to avoid crashes.
4175
4176         * gtk/jhbuild.modules:
4177         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4178
4179 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
4180
4181         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
4182         https://bugs.webkit.org/show_bug.cgi?id=192618
4183
4184         Reviewed by Alex Christensen.
4185
4186         * DumpRenderTree/win/DRTDataObject.cpp:
4187         * DumpRenderTree/win/DRTDataObject.h:
4188         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4189         * DumpRenderTree/win/DRTDropSource.h:
4190         * DumpRenderTree/win/EditingDelegate.h:
4191         * DumpRenderTree/win/PolicyDelegate.h:
4192         * DumpRenderTree/win/UIDelegate.h:
4193
4194 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
4195
4196         Make TextInputController.legacyAttributedString take DOM nodes and offsets
4197         https://bugs.webkit.org/show_bug.cgi?id=192653
4198
4199         Reviewed by Wenson Hsieh.
4200
4201         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
4202         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
4203         shadow boundaries.
4204
4205         * DumpRenderTree/mac/TextInputControllerMac.m:
4206         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
4207         (+[TextInputController webScriptNameForSelector:]): Ditto.
4208         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
4209         start node and offset then end node and offset pairs.
4210
4211 2018-12-12  Alex Christensen  <achristensen@webkit.org>
4212
4213         Implement safe browsing in WebKit on WatchOS
4214         https://bugs.webkit.org/show_bug.cgi?id=192641
4215         <rdar://problem/46376188>
4216
4217         Reviewed by Geoff Garen.
4218
4219         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4220         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
4221         (safeBrowsingView):
4222         Add a test that the new delegate callback is called.
4223
4224 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4225
4226         Unreviewed manual rollout of r239100-r239102 and r239116
4227         https://bugs.webkit.org/show_bug.cgi?id=192151
4228         <rdar://problem/46655586>
4229
4230         * gtk/jhbuild.modules:
4231         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
4232
4233 2018-12-12  Commit Queue  <commit-queue@webkit.org>
4234
4235         Unreviewed, rolling out r239103.
4236         https://bugs.webkit.org/show_bug.cgi?id=192627
4237
4238         It broke the built because it depends on another patch that
4239         didn't land yet (Requested by KaL on #webkit).
4240
4241         Reverted changeset:
4242
4243         "[WPE] Add API to notify about frame displayed view backend
4244         callback"
4245         https://bugs.webkit.org/show_bug.cgi?id=192224
4246         https://trac.webkit.org/changeset/239103
4247
4248 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4249
4250         [WPE] Add API to notify about frame displayed view backend callback
4251         https://bugs.webkit.org/show_bug.cgi?id=192224
4252
4253         Reviewed by Michael Catanzaro.
4254
4255         Add a test case to check the new API.
4256
4257         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4258         (testWebViewFrameDisplayed):
4259         (beforeAll):
4260
4261 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4262
4263         [FreeType] Add initial implementation of variation fonts
4264         https://bugs.webkit.org/show_bug.cgi?id=192151
4265
4266         Reviewed by Michael Catanzaro.
4267
4268         Add cairo patch to avoid crashes.
4269
4270         * gtk/jhbuild.modules:
4271         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4272
4273 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
4274
4275         Implement feature flag for CSS Typed OM
4276         https://bugs.webkit.org/show_bug.cgi?id=192610
4277
4278         Reviewed by Ryosuke Niwa.
4279
4280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4281
4282 2018-12-11  Chris Dumez  <cdumez@apple.com>
4283
4284         Unreviewed, fix bad check in API test added in r239080.
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4287
4288 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
4289
4290         [Win][Clang] Fix warning -Wmissing-field-initializers
4291         https://bugs.webkit.org/show_bug.cgi?id=192584
4292
4293         Reviewed by Yusuke Suzuki.
4294
4295         Initialize a struct with '{ }' instead of '= {0}'.
4296
4297         * DumpRenderTree/win/DumpRenderTree.cpp:
4298         (runTest):
4299         * DumpRenderTree/win/EventSender.cpp:
4300         (makeMsg):
4301         (replaySavedEvents):
4302         (beginDragWithFilesCallback):