Unreviewed, fix a typo
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, fix a typo
4
5         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
6
7 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
8
9         [GTK][WPE] force libpsl build to use ICU in jhbuild
10         https://bugs.webkit.org/show_bug.cgi?id=194288
11
12         Reviewed by Carlos Garcia Campos.
13
14         * gtk/jhbuild.modules:
15         Require ICU for libpsl build in jhbuild, like done in WPE.
16
17 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
18
19         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
20         https://bugs.webkit.org/show_bug.cgi?id=194209
21
22         Reviewed by Carlos Garcia Campos.
23
24         Enhance TestCookieManager to ensure this doesn't happen again.
25
26         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
27         (testCookieManagerPersistentStorage):
28         (beforeAll):
29
30 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
31
32         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
33         https://bugs.webkit.org/show_bug.cgi?id=194324
34
35         Reviewed by Andy Estes.
36
37         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
38         part of the name is already implicit, since this is in testing code in TestOptions.
39
40         * WebKitTestRunner/TestController.cpp:
41         (WTR::TestController::generateContextConfiguration const):
42         (WTR::updateTestOptionsFromTestHeader):
43         * WebKitTestRunner/TestOptions.h:
44         (WTR::TestOptions::hasSameInitializationOptions const):
45
46 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
47
48         [ews-build] Allow * as platform for builders and workers
49         https://bugs.webkit.org/show_bug.cgi?id=188533
50
51         Reviewed by Lucas Forschler.
52
53         * BuildSlaveSupport/ews-build/loadConfig.py:
54         (checkWorkersAndBuildersForConsistency):
55
56 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
57
58         [ews-build] Add few bots to config.json
59         https://bugs.webkit.org/show_bug.cgi?id=194304
60
61         Reviewed by Lucas Forschler.
62
63         * BuildSlaveSupport/ews-build/config.json:
64
65 2019-02-05  Keith Rollin  <krollin@apple.com>
66
67         Enable the automatic checking and regenerations of .xcfilelists during builds
68         https://bugs.webkit.org/show_bug.cgi?id=194124
69         <rdar://problem/47721277>
70
71         Reviewed by Tim Horton.
72
73         Bug 193790 add a facility for checking -- during build time -- that
74         any needed .xcfilelist files are up-to-date and for updating them if
75         they are not. This facility was initially opt-in by setting
76         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
77         the process seemed robust. Its now time to enable this facility and
78         make it opt-out. If there is a need to disable this facility, set and
79         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
80         running `make` or `build-webkit`, or before running Xcode from the
81         command line.
82
83         Additionally, remove the step that generates a list of source files
84         going into the UnifiedSources build step. It's only necessarily to
85         specify Sources.txt and SourcesCocoa.txt as inputs.
86
87         * Scripts/generate-xcfilelists:
88
89 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
90
91         [GTK][WPE] force libpsl build to use ICU in jhbuild
92         https://bugs.webkit.org/show_bug.cgi?id=194288
93
94         Reviewed by Philippe Normand.
95
96         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
97         This can cause build failures if libidn is detected but libunistring is not available.
98
99         Make sure that ICU is used for runtime and builtin PSL data.
100
101         * gtk/jhbuild.modules:
102         * wpe/jhbuild.modules:
103
104 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
105
106         [ews-app] Modified timestamp should be updated on updating data
107         https://bugs.webkit.org/show_bug.cgi?id=194295
108
109         Reviewed by Lucas Forschler.
110
111         * BuildSlaveSupport/ews-app/ews/models/build.py:
112         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
113         * BuildSlaveSupport/ews-app/ews/models/step.py:
114
115 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
116
117         Unreviewed, rolling out r240742.
118
119         Causes crashes on iOS simulator.
120
121         Reverted changeset:
122
123         "[iOS] Keyups for non-modifier keys identified as "Dead" when
124         not focused in a content-editable element"
125         https://bugs.webkit.org/show_bug.cgi?id=192824
126         https://trac.webkit.org/changeset/240742
127
128 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
129
130         run-webkit-tests emits message "...running None" when running tests
131         https://bugs.webkit.org/show_bug.cgi?id=194133
132         <rdar://problem/47724738>
133
134         Reviewed by Lucas Forschler.
135
136         * Scripts/webkitpy/xcode/device_type.py:
137         (DeviceType.__str__): Use both version mapping tables and use just the variant
138         name if no version name is available.
139         * Scripts/webkitpy/xcode/device_type_unittest.py:
140         (DeviceTypeTest):
141         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
142         an associated named.
143
144 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
145
146         [WPE] require python3-setuptools for meson build in jhbuild
147         https://bugs.webkit.org/show_bug.cgi?id=194287
148
149         Reviewed by Philippe Normand.
150
151         python3-setuptools is needed to build meson in jhbuild.
152         It is already required by the GTK port.
153
154         * wpe/install-dependencies:
155
156 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
157
158         [ews-app] Add method to save BuilderMapping to database
159         https://bugs.webkit.org/show_bug.cgi?id=194264
160
161         Reviewed by Lucas Forschler.
162
163         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
164         (BuilderMapping.__str__):
165         (BuilderMapping):
166         (BuilderMapping.save_mapping):
167         (BuilderMapping.update_mapping):
168         (BuilderMapping.get_existing_mapping):
169         (BuilderMapping.is_valid_mapping):
170
171 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Add timestamp fields for BuilderMappings
174         https://bugs.webkit.org/show_bug.cgi?id=194266
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
179         (BuilderMapping):
180
181 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
182
183         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
184         https://bugs.webkit.org/show_bug.cgi?id=174816
185
186         Reviewed by Michael Catanzaro.
187
188         Add tests for webkit_uri_for_display().
189
190         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
191         (testURIForDisplayUnaffected):
192         (testURIForDisplayAffected):
193         (beforeAll):
194         (afterAll):
195         * TestWebKitAPI/glib/CMakeLists.txt:
196
197 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
198
199         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
200         https://bugs.webkit.org/show_bug.cgi?id=194158
201         <rdar://problem/47737268>
202
203         Rubber-stamped by Aakash Jain.
204
205         * Scripts/webkitpy/port/device_port.py:
206         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
207
208 2019-02-04  Said Abou-Hallawa  <said@apple.com>
209
210         [CG] Enable setAdditionalSupportedImageTypes for WK1
211         https://bugs.webkit.org/show_bug.cgi?id=194190
212
213         Reviewed by Tim Horton.
214
215         Add a test similar to the one under WebKit Cocoa but make it create a
216         WebView instead of a WKWebView.
217
218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
219         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
220         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
221         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
222         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
223         (TestWebKitAPI::runTest):
224         (TestWebKitAPI::TEST):
225
226 2019-02-04  Zalan Bujtas  <zalan@apple.com>
227
228         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
229         https://bugs.webkit.org/show_bug.cgi?id=194168
230
231         Reviewed by Simon Fraser.
232
233         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
237         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
238         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
239         (TEST):
240         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
241         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
242
243 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
244
245         REGRESSION (r237269): webkit-patch what-broke is broken 
246         https://bugs.webkit.org/show_bug.cgi?id=193025
247
248         Reviewed by Aakash Jain.
249
250         * Scripts/webkitpy/common/host.py:
251         (Host.buildbot):
252         (Host.bugzilla): Renamed to 'buildbot'.
253
254 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
255
256         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
257         https://bugs.webkit.org/show_bug.cgi?id=194207
258
259         Reviewed by Tim Horton.
260
261         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
262         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
263         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
264         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
265         start and delete forwards to remove the original attachment.
266
267         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
268         (TestWebKitAPI::TEST):
269
270 2019-02-04  Youenn Fablet  <youenn@apple.com>
271
272         Capture state should be managed consistently when doing process swapping
273         https://bugs.webkit.org/show_bug.cgi?id=194122
274         <rdar://problem/47609293>
275
276         Reviewed by Eric Carlson.
277
278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
279         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
280         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
281         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
284         (WTR::TestRunner::isDoingMediaCapture const):
285         * WebKitTestRunner/InjectedBundle/TestRunner.h:
286         * WebKitTestRunner/TestController.cpp:
287         (WTR::TestController::isDoingMediaCapture const):
288         * WebKitTestRunner/TestController.h:
289         * WebKitTestRunner/TestInvocation.cpp:
290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
291         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
292         (WTR::TestController::isDoingMediaCapture const):
293
294 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
295
296         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
297         https://bugs.webkit.org/show_bug.cgi?id=194142
298
299         Reviewed by Ross Kirsling.
300
301         There three 'separator' variables in TestController.cpp. Renamed
302         it 'pathSeparator', and unified them.
303
304         * WebKitTestRunner/TestController.cpp:
305         (WTR::TestController::generateContextConfiguration const):
306         (WTR::createTestURL):
307         (WTR::TestController::platformAdjustContext):
308
309 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
310
311         Make setNeedsLayout on the root more explicitly about triggering its side-effects
312         https://bugs.webkit.org/show_bug.cgi?id=194198
313
314         Reviewed by Antti Koivisto.
315
316         No need to set the banner heights on navigation now, since Page stores them.
317
318         * MiniBrowser/mac/WK2BrowserWindowController.m:
319         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
320
321 2019-02-03  John Wilander  <wilander@apple.com>
322
323         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
324         https://bugs.webkit.org/show_bug.cgi?id=194104
325         <rdar://problem/47649991>
326
327         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
328
329         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
330         (TestWebKitAPI::TEST):
331             Changed numeric types from unsigned short to uint32_t.
332
333 2019-02-02  David Kilzer  <ddkilzer@apple.com>
334
335         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
336         <https://webkit.org/b/194178>
337         <rdar://problem/47753473>
338
339         Reviewed by Alexey Proskuryakov.
340
341         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
342         (WTR::uninstallFakeHelvetica): Pass nullptr into
343         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
344
345 2019-02-02  Zalan Bujtas  <zalan@apple.com>
346
347         [LFC] Initialize ICB's style with fixed width/height.
348         https://bugs.webkit.org/show_bug.cgi?id=194188
349
350         Reviewed by Antti Koivisto.
351
352         * LayoutReloaded/misc/LFC-passing-tests.txt:
353
354 2019-02-02  Zalan Bujtas  <zalan@apple.com>
355
356         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
357         https://bugs.webkit.org/show_bug.cgi?id=194185
358
359         Reviewed by Antti Koivisto.
360
361         * LayoutReloaded/misc/LFC-passing-tests.txt:
362
363 2018-12-16  Darin Adler  <darin@apple.com>
364
365         Convert additional String::format clients to alternative approaches
366         https://bugs.webkit.org/show_bug.cgi?id=192746
367
368         Reviewed by Alexey Proskuryakov.
369
370         * WebKitTestRunner/TestController.cpp:
371         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
372         as an intermediate in code that ultimately constructs a WTF::String.
373         (WTR::userMediaOriginHash): Use makeString.
374         (WTR::TestController::didNavigateWithNavigationData): More of the same.
375         (WTR::TestController::didPerformClientRedirect): Ditto.
376         (WTR::TestController::didPerformServerRedirect): Ditto.
377         (WTR::TestController::didUpdateHistoryTitle): Ditto.
378
379 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
380
381         [ews-build] Add unit test to verify builder keys
382         https://bugs.webkit.org/show_bug.cgi?id=194152
383
384         Reviewed by Lucas Forschler.
385
386         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
387         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
388
389 2019-02-01  Zalan Bujtas  <zalan@apple.com>
390
391         [LFC] Expand tests coverage (12 new tests -> 787)
392
393         Unreviewed test gardening.
394
395         * LayoutReloaded/misc/LFC-passing-tests.txt:
396
397 2019-02-01  Zalan Bujtas  <zalan@apple.com>
398
399         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
400         https://bugs.webkit.org/show_bug.cgi?id=194163
401
402         Reviewed by Simon Fraser.
403
404         775
405
406         * LayoutReloaded/misc/LFC-passing-tests.txt:
407
408 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
409
410         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
411         https://bugs.webkit.org/show_bug.cgi?id=194140
412         <rdar://problem/47728098>
413
414         Reviewed by Tim Horton.
415
416         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
417         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
418         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
419
420         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
421         test to induce an IPC deadlock when presenting a modal alert during touch start.
422
423         * WebKitTestRunner/InjectedBundle/TestRunner.h:
424         * WebKitTestRunner/TestController.cpp:
425         (WTR::runJavaScriptAlert):
426
427         Add a client callback function for running JavaScript alerts.
428
429         (WTR::TestController::createOtherPage):
430         (WTR::TestController::generateContextConfiguration const):
431
432         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
433         the fix in this patch.
434
435         (WTR::TestController::createWebViewWithOptions):
436
437         Plumb TestOptions to generateContextConfiguration.
438
439         (WTR::TestController::resetPreferencesToConsistentValues):
440         (WTR::TestController::resetStateToConsistentValues):
441         (WTR::updateTestOptionsFromTestHeader):
442         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
443         (WTR::TestController::handleJavaScriptAlert):
444         * WebKitTestRunner/TestController.h:
445         * WebKitTestRunner/TestInvocation.cpp:
446         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
447         * WebKitTestRunner/TestOptions.h:
448         (WTR::TestOptions::hasSameInitializationOptions const):
449
450 2019-02-01  Chris Dumez  <cdumez@apple.com>
451
452         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
453         https://bugs.webkit.org/show_bug.cgi?id=193740
454         <rdar://problem/47527267>
455
456         Reviewed by Alex Christensen.
457
458         Add API test coverage.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
461
462 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
463
464         [ews-app] Add display name field to BuilderMapping model
465         https://bugs.webkit.org/show_bug.cgi?id=194153
466
467         Reviewed by Lucas Forschler.
468
469         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
470         (BuilderMapping):
471
472 2019-02-01  Youenn Fablet  <youenn@apple.com>
473
474         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
475         https://bugs.webkit.org/show_bug.cgi?id=194155
476
477         Reviewed by Eric Carlson.
478
479         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
480         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
481         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
482
483 2019-02-01  Zalan Bujtas  <zalan@apple.com>
484
485         [LFC] Adjust replaced element's intrinsic ratio
486         https://bugs.webkit.org/show_bug.cgi?id=194154
487
488         Reviewed by Antti Koivisto.
489
490         761
491
492         * LayoutReloaded/misc/LFC-passing-tests.txt:
493
494 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
495
496         [WPE] Show test results in minibrowser
497         https://bugs.webkit.org/show_bug.cgi?id=194150
498
499         Reviewed by Žan Doberšek.
500
501         * Scripts/webkitpy/port/wpe.py:
502         (WPEPort.show_results_html_file):
503
504 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
505
506         [WPE] MiniBrowser: add ky bindings for back/forward navigation
507         https://bugs.webkit.org/show_bug.cgi?id=194151
508
509         Reviewed by Žan Doberšek.
510
511         ALT + <- go back
512         ALT + -> go forward
513
514         * MiniBrowser/wpe/main.cpp:
515         (main):
516
517 2019-02-01  Zalan Bujtas  <zalan@apple.com>
518
519         [LFC] Set intrinsic size on Layout::Replaced
520         https://bugs.webkit.org/show_bug.cgi?id=194139
521
522         Reviewed by Antti Koivisto.
523
524         744
525
526         * LayoutReloaded/misc/LFC-passing-tests.txt:
527
528 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
531         https://bugs.webkit.org/show_bug.cgi?id=194146
532
533         Reviewed by Xabier Rodriguez-Calvar.
534
535         It allows to open relative paths.
536
537         * MiniBrowser/wpe/main.cpp:
538         (main):
539
540 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
541
542         Update flakiness dashboard configuration after recent queue changes
543         https://bugs.webkit.org/show_bug.cgi?id=194127
544
545         Rubber-stamped by Aakash Jain.
546
547         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
548
549         * TestResultServer/static-dashboards/builders.jsonp:
550
551 2019-01-31  Youenn Fablet  <youenn@apple.com>
552
553         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
554         https://bugs.webkit.org/show_bug.cgi?id=194106
555         <rdar://problem/47676333>
556
557         Reviewed by Ryosuke Niwa.
558
559         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
560         (TestWebKitAPI::didFinishNavigation):
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
563
564 2019-01-31  Chris Dumez  <cdumez@apple.com>
565
566         Page zoom level is lost after a process swap or a crash
567         https://bugs.webkit.org/show_bug.cgi?id=194105
568         <rdar://problem/47610781>
569
570         Reviewed by Alex Christensen.
571
572         Add API test coverage.
573
574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
575         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
576
577 2019-01-31  Alex Christensen  <achristensen@webkit.org>
578
579         Revert r238819 which is unneeded and caused a performance regression.
580         https://bugs.webkit.org/show_bug.cgi?id=192272
581         <rdar://problem/46664625>
582
583         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
584         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
585         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
586
587 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
588
589         Formalize WebKitAdditions mechanism of LoadOptimizer
590         https://bugs.webkit.org/show_bug.cgi?id=193886
591         <rdar://problem/47696809>
592
593         Reviewed by Brent Fulgham.
594
595         * MiniBrowser/MiniBrowser.entitlements:
596         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
597
598 2019-01-31  Zalan Bujtas  <zalan@apple.com>
599
600         [LFC] Margin before/after/start/end initial value is 0 and not auto.
601         https://bugs.webkit.org/show_bug.cgi?id=194090
602
603         Reviewed by Antti Koivisto.
604
605         * LayoutReloaded/misc/LFC-passing-tests.txt:
606
607 2019-01-31  Zalan Bujtas  <zalan@apple.com>
608
609         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
610         https://bugs.webkit.org/show_bug.cgi?id=194074
611
612         Reviewed by Antti Koivisto.
613
614         * LayoutReloaded/misc/LFC-passing-tests.txt:
615
616 2019-01-31  Zalan Bujtas  <zalan@apple.com>
617
618         [LFC][BFC] Add support for block level replaced box.
619         https://bugs.webkit.org/show_bug.cgi?id=194071
620
621         Reviewed by Antti Koivisto.
622
623         * LayoutReloaded/misc/LFC-passing-tests.txt:
624
625 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
626
627         Fix WebKitTestRunner's testPath with Windows full paths
628         https://bugs.webkit.org/show_bug.cgi?id=194012
629
630         Reviewed by Alex Christensen.
631
632         updateTestOptionsFromTestHeader failed to open test files because
633         testPath returned wrong file paths. It returned a path "/C:/..."
634         if a URL "file:///C:/..." was given.
635
636         * WebKitTestRunner/TestController.cpp:
637         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
638
639 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
640
641         [WPE] Bump font related dependencies to match the GTK+ port
642         https://bugs.webkit.org/show_bug.cgi?id=194017
643
644         Reviewed by Žan Doberšek.
645
646         * wpe/jhbuild.modules:
647         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
648         * wpe/patches/icudata-stdlibs.patch: Added.
649
650 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
651
652         Enable swipe tests on iOS
653         https://bugs.webkit.org/show_bug.cgi?id=194076
654
655         Reviewed by Geoffrey Garen.
656
657         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
658         it causes a debug assertion failure in runUIScript.
659
660         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
661         (WTR::UIScriptController::beginBackSwipe):
662         (WTR::UIScriptController::completeBackSwipe):
663
664 2019-01-30  Keith Rollin  <krollin@apple.com>
665
666         Use correct printf format specifier
667         https://bugs.webkit.org/show_bug.cgi?id=194062
668         <rdar://problem/47686167>
669
670         Reviewed by Alexey Proskuryakov.
671
672         LayoutTestSpellChecker.mm is trying to format a variable of type
673         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
674         actually an unsigned long long. Fix this by formatting with %llu.
675
676         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
677         (-[LayoutTestTextCheckingResult description]):
678
679 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
680
681         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
682         https://bugs.webkit.org/show_bug.cgi?id=193979
683
684         Reviewed by Wenson Hsieh.
685
686         Fix the test for iOS. Make the test work with iOS UA string.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
689
690 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
691
692         Replace High Sierra LLINT CLoop bot due to hardware failure
693         https://bugs.webkit.org/show_bug.cgi?id=194066
694
695         Reviewed by Aakash Jain.
696
697         * BuildSlaveSupport/build.webkit.org-config/config.json:
698
699 2019-01-30  Keith Rollin  <krollin@apple.com>
700
701         [NSDragItem init] is unavailable
702         https://bugs.webkit.org/show_bug.cgi?id=194059
703         <rdar://problem/47685715>
704
705         Reviewed by Wenson Hsieh.
706
707         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
708         DumpRenderTree and TestWebKitAPI, which both try to create an
709         NSDragItem in a manner that invokes this method. Address this by using
710         -initWithPasteboardWriter instead.
711
712         Note that the parameter passed to initWithPasteboardWriter is likely
713         incorrect. In both cases, the object passed does not conform to
714         NSPasteboardWriting. However, with this fix, we're no worse off than
715         before, and can now perform builds with newer compilers and SDKs until
716         a real fix can be crafted. That work is tracked in
717         https://bugs.webkit.org/show_bug.cgi?id=194060
718
719         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
720         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
721         * TestWebKitAPI/mac/TestDraggingInfo.mm:
722         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
723
724 2019-01-30  Daniel Bates  <dabates@apple.com>
725
726         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
727         https://bugs.webkit.org/show_bug.cgi?id=192824
728         <rdar://problem/47100332>
729
730         Reviewed by Wenson Hsieh.
731
732         Fix a bug where the wrong usage code was used for F13 thru F24.
733
734         * WebKitTestRunner/ios/HIDEventGenerator.mm:
735         (keyCodeForDOMFunctionKey):
736
737 2019-01-30  Chris Dumez  <cdumez@apple.com>
738
739         Regression(PSON) Load hang can occur on history navigation
740         https://bugs.webkit.org/show_bug.cgi?id=194030
741         <rdar://problem/47656939>
742
743         Reviewed by Antti Koivisto.
744
745         Add API test coverage.
746
747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
748
749 2019-01-30  Zalan Bujtas  <zalan@apple.com>
750
751         [LFC] Expand tests coverage.
752
753         Unreviewed test gardening.
754
755         * LayoutReloaded/misc/LFC-passing-tests.txt:
756
757 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
758
759         [Flatpak] Add openjpeg support
760         https://bugs.webkit.org/show_bug.cgi?id=194019
761
762         Reviewed by Michael Catanzaro.
763
764         * flatpak/org.webkit.CommonModules.yaml:
765
766 2019-01-30  Commit Queue  <commit-queue@webkit.org>
767
768         Unreviewed, rolling out r240708.
769         https://bugs.webkit.org/show_bug.cgi?id=194022
770
771         It broke WPE build (Requested by KaL on #webkit).
772
773         Reverted changeset:
774
775         "[WPE] Bump font related dependencies to match the GTK+ port"
776         https://bugs.webkit.org/show_bug.cgi?id=194017
777         https://trac.webkit.org/changeset/240708
778
779 2019-01-30  Zalan Bujtas  <zalan@apple.com>
780
781         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
782         https://bugs.webkit.org/show_bug.cgi?id=194001
783
784         Reviewed by Antti Koivisto.
785
786         * LayoutReloaded/misc/LFC-passing-tests.txt:
787
788 2019-01-30  Zalan Bujtas  <zalan@apple.com>
789
790         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
791         https://bugs.webkit.org/show_bug.cgi?id=194020
792
793         Reviewed by Antti Koivisto.
794
795         * LayoutReloaded/misc/LFC-passing-tests.txt:
796
797 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
798
799         AX: Support color well on iOS
800         https://bugs.webkit.org/show_bug.cgi?id=194010
801
802         Reviewed by Joanmarie Diggs.
803
804         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
805         (WTR::AccessibilityUIElement::stringAttributeValue):
806
807 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
808
809         [WPE] Bump font related dependencies to match the GTK+ port
810         https://bugs.webkit.org/show_bug.cgi?id=194017
811
812         Reviewed by Žan Doberšek.
813
814         * wpe/jhbuild.modules:
815         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
816         * wpe/patches/icudata-stdlibs.patch: Added.
817
818 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
819
820         [Mac] Update window scale API usage
821         https://bugs.webkit.org/show_bug.cgi?id=193991
822         rdar://problem/47614795
823
824         Reviewed by Tim Horton.
825
826         * DumpRenderTree/mac/DumpRenderTree.mm:
827         (changeWindowScaleIfNeeded):
828         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
829         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
830         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
831
832 2019-01-29  Chris Dumez  <cdumez@apple.com>
833
834         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
835         https://bugs.webkit.org/show_bug.cgi?id=193977
836         <rdar://problem/47643716>
837
838         Reviewed by Geoff Garen.
839
840         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
841         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
842         to the previous provisional committing *before* we make the last load. 
843
844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
845
846 2019-01-29  Youenn Fablet  <youenn@apple.com>
847
848         Adopt new SPI to evaluate server certificate trust
849         https://bugs.webkit.org/show_bug.cgi?id=193355
850
851         Reviewed by Alex Christensen.
852
853         Add infrastructure to handle HTTPS server trust evaluation testing.
854
855         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
856         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
857         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
858         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
859         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
860         * WebKitTestRunner/InjectedBundle/TestRunner.h:
861         * WebKitTestRunner/TestController.cpp:
862         (WTR::TestController::resetPreferencesToConsistentValues):
863         (WTR::TestController::didReceiveAuthenticationChallenge):
864         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
865         * WebKitTestRunner/TestController.h:
866         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
867         * WebKitTestRunner/TestInvocation.cpp:
868         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
869         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
870         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
871
872 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
873
874         [ews-build] Add build step to print bot Configuration
875         https://bugs.webkit.org/show_bug.cgi?id=193887
876
877         Reviewed by Lucas Forschler.
878
879         * BuildSlaveSupport/ews-build/steps.py:
880         (PrintConfiguration): Build step to print configuration.
881         * BuildSlaveSupport/ews-build/factories.py:
882
883 2019-01-29  Chris Dumez  <cdumez@apple.com>
884
885         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
886         https://bugs.webkit.org/show_bug.cgi?id=193967
887         <rdar://problem/47635348>
888
889         Reviewed by Alex Christensen.
890
891         Add API test coverage.
892
893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
894         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
895
896 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
897
898         [ews-app] Handle incoming results data
899         https://bugs.webkit.org/show_bug.cgi?id=193973
900
901         Reviewed by Lucas Forschler.
902
903         * BuildSlaveSupport/ews-app/ews/views/results.py:
904
905 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
906
907         [ews-app] Make the results url generic
908         https://bugs.webkit.org/show_bug.cgi?id=193928
909
910         Reviewed by Lucas Forschler.
911
912         * BuildSlaveSupport/ews-app/ews/urls.py:
913
914 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-build] Configure buildbot to send events to ews-app
917         https://bugs.webkit.org/show_bug.cgi?id=193968
918
919         Reviewed by Lucas Forschler.
920
921         * BuildSlaveSupport/ews-build/events.py: Added.
922         * BuildSlaveSupport/ews-build/master.cfg:
923
924 2019-01-29  Keith Rollin  <krollin@apple.com>
925
926         Add .xcfilelists to Run Script build phases
927         https://bugs.webkit.org/show_bug.cgi?id=193792
928         <rdar://problem/47201785>
929
930         Reviewed by Alex Christensen.
931
932         As part of supporting XCBuild, update the necessary Run Script build
933         phases in their Xcode projects to refer to their associated
934         .xcfilelist files.
935
936         Note that the addition of these files bumps the Xcode project version
937         number to something that's Xcode 10 compatible. This change means that
938         older versions of the Xcode IDE can't read these projects. Nor can it
939         fully load workspaces that refer to these projects (the updated
940         projects are shown as non-expandable placeholders). `xcodebuild` can
941         still build these projects; it's just that the IDE can't open them.
942
943         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
944         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
945
946 2019-01-29  John Wilander  <wilander@apple.com>
947
948         Add data abstraction and validation for Ad Click Attribution
949         https://bugs.webkit.org/show_bug.cgi?id=193916
950         <rdar://problem/47603481>
951
952         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
953
954         Ad click attribution has two steps. First, the storage of an ad
955         campaign ID for a click that takes the user to a destination
956         site. Second, a conversion on the destination site that can be
957         attributed to the ad click.
958
959         This patch adds a class that represents a request for ad click
960         attribution. Validation makes sure that the bits of entropy
961         reported through this mechanism is limited.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
965         (TestWebKitAPI::TEST):
966
967 2019-01-29  Chris Dumez  <cdumez@apple.com>
968
969         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
970         https://bugs.webkit.org/show_bug.cgi?id=193932
971         <rdar://problem/47598947>
972
973         Reviewed by Brady Eidson.
974
975         Add API test coverage.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
978
979 2019-01-29  Zalan Bujtas  <zalan@apple.com>
980
981         Adding new passing LFC tests.
982
983         Unreviewed test gardening.
984
985         * LayoutReloaded/misc/LFC-passing-tests.txt:
986
987 2019-01-29  Zalan Bujtas  <zalan@apple.com>
988
989         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
990         https://bugs.webkit.org/show_bug.cgi?id=193964
991
992         Reviewed by Antti Koivisto.
993
994         * LayoutReloaded/misc/LFC-passing-tests.txt:
995
996 2019-01-29  Zalan Bujtas  <zalan@apple.com>
997
998         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
999         https://bugs.webkit.org/show_bug.cgi?id=193954
1000
1001         Reviewed by Antti Koivisto.
1002
1003         * LayoutReloaded/misc/LFC-passing-tests.txt:
1004
1005 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         WebDriver: add support for running subtests
1008         https://bugs.webkit.org/show_bug.cgi?id=193904
1009
1010         Reviewed by Michael Catanzaro.
1011
1012         pytest already supports it by passing test.py::subtest, so we can do the same.
1013
1014         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1015         (get_item_name): Made this global.
1016         (CollectRecorder.__init__): Receive the parameter to ignore.
1017         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1018         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1019         (collect): Add parameter to ignore.
1020         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1021         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1022         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1023         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1024         (WebDriverTestRunnerSelenium.run): Ditto.
1025         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1026         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1027         (WebDriverTestRunnerW3C.run): Ditto.
1028
1029 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1030
1031         User agent string override for navigator.userAgent should be site specific quirks
1032         https://bugs.webkit.org/show_bug.cgi?id=193950
1033
1034         Reviewed by Brent Fulgham.
1035
1036         Updated per the _WKWebsitePolicies rename.
1037
1038         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1039         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1040
1041 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1042
1043         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1044         https://bugs.webkit.org/show_bug.cgi?id=193941
1045
1046         Reviewed by Alex Christensen.
1047
1048         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1049         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1050         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1051         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1052         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1053         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1054         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1055         * TestWebKitAPI/Tests/WTF/Time.cpp:
1056         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1057         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1058         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1059         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1060
1061 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1062
1063         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1064
1065         * Scripts/webkitpy/common/config/contributors.json:
1066
1067 2019-01-28  Andy Estes  <aestes@apple.com>
1068
1069         [watchOS] Enable Parental Controls content filtering
1070         https://bugs.webkit.org/show_bug.cgi?id=193939
1071         <rdar://problem/46641912>
1072
1073         Reviewed by Ryosuke Niwa.
1074
1075         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1076
1077 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1078
1079         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1080         <https://webkit.org/b/193884>
1081
1082         Reviewed by Jiewen Tan.
1083
1084         * Scripts/webkitpy/style/checkers/cpp.py:
1085         (check_language): Add LocalAuthentication to
1086         `frameworks_with_soft_links`.
1087
1088 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1089
1090         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1091         https://bugs.webkit.org/show_bug.cgi?id=193891
1092
1093         Reviewed by Ross Kirsling.
1094
1095         There were three problems in window sizes of WebView and the host window.
1096         1. The sizes of pixel image output were incorrect.
1097         2. The host window is going to appear after window.resize was invoked.
1098         3. window.resize resized only the host window, not WebView.
1099
1100         This change solves them with a following approach.
1101         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1102         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1103            as well as DumpRenderTree in order to match the client area and the window area.
1104         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1105         d. PlatformWebView::setWindowFrame changes both window sizes.
1106         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1107
1108         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1109         (WTR::PlatformWebView::PlatformWebView): Create the host window
1110         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1111         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1112         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1113
1114 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1115
1116         [ews-app] Add method to save Step data to database
1117         https://bugs.webkit.org/show_bug.cgi?id=193890
1118
1119         Reviewed by Lucas Forschler.
1120
1121         * BuildSlaveSupport/ews-app/ews/models/step.py:
1122         (Step.save_step): Method to save step data.
1123         (Step.update_step): Method to update step data.
1124         (Step.get_existing_step): Method to fetch existing step from database.
1125         (Step.is_valid_result): Method to validate valid step result.
1126
1127 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-app] Add method to save Build data to database
1130         https://bugs.webkit.org/show_bug.cgi?id=193735
1131
1132         Reviewed by Lucas Forschler.
1133
1134         * BuildSlaveSupport/ews-app/ews/models/build.py:
1135         (Build.save_build): Method to save build information to database.
1136         (Build.get_existing_build): Method to fetch existing build from database.
1137         (Build.is_valid_result): Method to validate build result.
1138         * BuildSlaveSupport/ews-app/ews/common/util.py:
1139         (is_valid_int_id): Method to validate valid id.
1140
1141 2019-01-28  Chris Dumez  <cdumez@apple.com>
1142
1143         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1144         https://bugs.webkit.org/show_bug.cgi?id=193915
1145         <rdar://problem/47560907>
1146
1147         Reviewed by Alex Christensen.
1148
1149         Add API test coverage.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1152
1153 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-app] Rename id variables
1156         https://bugs.webkit.org/show_bug.cgi?id=193883
1157
1158         Reviewed by Lucas Forschler.
1159
1160         * BuildSlaveSupport/ews-app/ews/models/build.py:
1161         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1162         * BuildSlaveSupport/ews-app/ews/models/step.py:
1163         * BuildSlaveSupport/ews-app/ews/urls.py:
1164         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1165         * BuildSlaveSupport/ews-app/ews/views/results.py:
1166         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1167
1168 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-app] Allow certain fields to be empty
1171         https://bugs.webkit.org/show_bug.cgi?id=193892
1172
1173         Reviewed by Lucas Forschler.
1174
1175         * BuildSlaveSupport/ews-app/ews/models/build.py:
1176         * BuildSlaveSupport/ews-app/ews/models/step.py:
1177
1178 2019-01-28  Rob Buis  <rbuis@igalia.com>
1179
1180         Update MIME type parser
1181         https://bugs.webkit.org/show_bug.cgi?id=180526
1182
1183         Reviewed by Frédéric Wang.
1184
1185         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1186         (TestWebKitAPI::TEST):
1187
1188 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1189
1190         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1191         https://bugs.webkit.org/show_bug.cgi?id=193896
1192
1193         Reviewed by Antti Koivisto.
1194
1195         * LayoutReloaded/misc/LFC-passing-tests.txt:
1196
1197 2018-12-15  Darin Adler  <darin@apple.com>
1198
1199         Replace many uses of String::format with more type-safe alternatives
1200         https://bugs.webkit.org/show_bug.cgi?id=192742
1201
1202         Reviewed by Mark Lam.
1203
1204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1205         (WTR::cacheTestRunnerCallback): Use makeString.
1206         * WebKitTestRunner/TestController.cpp:
1207         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1208         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1209
1210 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1211
1212         Use a load optimizer for some sites
1213         https://bugs.webkit.org/show_bug.cgi?id=193881
1214         <rdar://problem/46325455>
1215
1216         Reviewed by Brent Fulgham.
1217
1218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1219         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1220
1221 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1222
1223         AX: Introduce a static accessibility tree
1224         https://bugs.webkit.org/show_bug.cgi?id=193348
1225         <rdar://problem/47203295>
1226
1227         Reviewed by Ryosuke Niwa.
1228
1229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1230
1231 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1232
1233         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1234         https://bugs.webkit.org/show_bug.cgi?id=193867
1235
1236         Reviewed by Antti Koivisto.
1237
1238         * LayoutReloaded/misc/LFC-passing-tests.txt:
1239
1240 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1241
1242         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1243         https://bugs.webkit.org/show_bug.cgi?id=193865
1244
1245         Reviewed by Antti Koivisto.
1246
1247         * LayoutReloaded/misc/LFC-passing-tests.txt:
1248
1249 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1250
1251         Need a mechanism to override navigator.userAgent
1252         https://bugs.webkit.org/show_bug.cgi?id=193762
1253         <rdar://problem/47504939>
1254
1255         Reviewed by Brent Fulgham.
1256
1257         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1258
1259         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1260         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1261         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1262
1263 2019-01-25  Dean Jackson  <dino@apple.com>
1264
1265         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1266         https://bugs.webkit.org/show_bug.cgi?id=193831
1267         <rdar://problem/47399263>
1268
1269         Reviewed by Chris Dumez.
1270
1271         Two new tests that exercise cross-origin and same-origin System
1272         Previews.
1273
1274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1275
1276 2019-01-25  Keith Rollin  <krollin@apple.com>
1277
1278         Update Xcode projects with "Check .xcfilelists" build phase
1279         https://bugs.webkit.org/show_bug.cgi?id=193790
1280         <rdar://problem/47201374>
1281
1282         Reviewed by Alex Christensen.
1283
1284         Support for XCBuild includes specifying inputs and outputs to various
1285         Run Script build phases. These inputs and outputs are specified as
1286         .xcfilelist files. Once created, these .xcfilelist files need to be
1287         kept up-to-date. In order to check that they are up-to-date or not,
1288         add an Xcode build step that invokes an external script that performs
1289         the checking. If the .xcfilelists are found to be out-of-date, update
1290         them, halt the build, and instruct the developer to restart the build
1291         with up-to-date files.
1292
1293         At this time, the checking and regenerating is performed only if the
1294         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1295         who want to use this facility can set this variable and test out the
1296         checking/regenerating. Once it seems like there are no egregious
1297         issues that upset a developer's workflow, we'll unconditionally enable
1298         this facility.
1299
1300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1301         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1302         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1303         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1304
1305 2019-01-25  Keith Rollin  <krollin@apple.com>
1306
1307         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1308         https://bugs.webkit.org/show_bug.cgi?id=193781
1309         <rdar://problem/47201153>
1310
1311         Reviewed by Alex Christensen.
1312
1313         Part of generating the .xcfilelists used as part of adopting XCBuild
1314         includes running `make DerivedSources.make` from a standalone script.
1315         It’s important for this invocation to have the same environment as
1316         when the actual build invokes `make DerivedSources.make`. If the
1317         environments are different, then the two invocations will provide
1318         different results. In order to get the same environment in the
1319         standalone script, have the script launch xcodebuild targeting the
1320         "Apply Configuration to XCFileLists" build target, which will then
1321         re-invoke our standalone script. The script is now running again, this
1322         time in an environment with all workspace, project, target, xcconfig
1323         and other environment variables established.
1324
1325         The "Apply Configuration to XCFileLists" build target accomplishes
1326         this task via a small embedded shell script that consists only of:
1327
1328             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1329
1330         The process that invokes "Apply Configuration to XCFileLists" first
1331         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1332         evaluated and exports it into the shell environment. When xcodebuild
1333         is invoked, it inherits the value of this variable and can `eval` the
1334         contents of that variable. Our external standalone script can then set
1335         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1336         of command-line parameters needed to restart itself in the appropriate
1337         state.
1338
1339         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1340         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1341
1342 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1343
1344         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1345         https://bugs.webkit.org/show_bug.cgi?id=193802
1346         <rdar://problem/46010580>
1347
1348         Reviewed by Andy Estes.
1349
1350         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1351         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1352         (TEST):
1353
1354 2019-01-25  Daniel Bates  <dabates@apple.com>
1355
1356         [iOS] uiController.keyDown() does not translate Control modified key
1357         https://bugs.webkit.org/show_bug.cgi?id=192898
1358
1359         Reviewed by Wenson Hsieh.
1360
1361         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1362         key translation, as applicable. Among other cases, key translation occurs when performing
1363         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1364         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1365         human pressing down and releasing key(s) using a hardware keyboard.
1366
1367         * WebKitTestRunner/ios/HIDEventGenerator.h:
1368         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1369         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1370
1371         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1372         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1373         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1374         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1375         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1376         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1377         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1378         (-[HIDEventGenerator longPress:completionBlock:]):
1379         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1380         Update code for above renaming.
1381
1382         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1383         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1384
1385         (-[HIDEventGenerator keyDown:]): Added.
1386         (-[HIDEventGenerator keyUp:]): Added.
1387         (-[HIDEventGenerator keyPress:completionBlock:]):
1388         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1389         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1390         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1391         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1392         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1393         (WTR::parseModifier): Deleted.
1394
1395 2019-01-25  Keith Rollin  <krollin@apple.com>
1396
1397         Complete the implementation of generate-xcfilelists
1398         https://bugs.webkit.org/show_bug.cgi?id=193782
1399
1400         Reviewed by Alex Christensen.
1401
1402         A preliminary version of generate-xcfilelists was added in r238008.
1403         This patch updates that script in order to:
1404
1405         - Support checking of .xcfilelists
1406         - Perform better execution of `make DerivedSources.make` by
1407           relaunching generate-xcfilelists under xcodebuild
1408         - Support incremental generation and checking of .xcfilelists
1409         - Support supplementary .xcfilelists files from WebKitAdditions
1410         - Support being wrapped by parallel version of generate-xcfilelists in
1411           Internal that adds support for (re)generating WebKit projects in
1412           that repo.
1413         - Support builds that have been performed in WebKitBuild as well as
1414           ~/Library/Developer/code/DerivedData
1415         - Increase robustness and debugging facilities.
1416
1417         * Scripts/generate-xcfilelists:
1418
1419 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1420
1421         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1422         https://bugs.webkit.org/show_bug.cgi?id=193297
1423         <rdar://problem/47158841>
1424
1425         Unreviewed test case fix.
1426
1427         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1428         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1431         (TEST):
1432
1433 2019-01-25  Keith Rollin  <krollin@apple.com>
1434
1435         Update existing .xcfilelists
1436         https://bugs.webkit.org/show_bug.cgi?id=193791
1437         <rdar://problem/47201706>
1438
1439         Reviewed by Alex Christensen.
1440
1441         Many .xcfilelist files were added in r238824 in order to support
1442         XCBuild. Update these with recent changes to the set of build files
1443         and with the current generate-xcfilelist script.
1444
1445         * DumpRenderTree/DerivedSources-input.xcfilelist:
1446         * DumpRenderTree/DerivedSources-output.xcfilelist:
1447         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1448         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1449
1450 2019-01-25  Keith Rollin  <krollin@apple.com>
1451
1452         Fix missing dependencies in extract-dependencies-from-makefile
1453         https://bugs.webkit.org/show_bug.cgi?id=193783
1454         <rdar://problem/47201571>
1455
1456         Reviewed by Alex Christensen.
1457
1458         The extract-dependencies-from-makefile script generates .xcfilelists
1459         for XCBuild by invoking a makefile in --debug mode, parsing the
1460         dependency information in the output, and extracting information
1461         regarding targets and dependents. However, the way `make` emits this
1462         dependency information is not rigorous, and so we need to determine
1463         what lines to look for and parse by trial and error. This approach
1464         didn't coriginally atch all the information we needed to collect, so
1465         update the script to look for the additional lines we now know to look
1466         for.
1467
1468         * Scripts/extract-dependencies-from-makefile:
1469         (Parser):
1470         (Parser.addTarget):
1471         (Parser.addPrereq):
1472         (Parser.doParse):
1473
1474 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1475
1476         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1477         https://bugs.webkit.org/show_bug.cgi?id=193297
1478         <rdar://problem/47158841>
1479
1480         Reviewed by Alex Christensen.
1481
1482         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1483             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1484         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1485         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1486         activating the message used to trigger the callback when it is set.
1487
1488 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1489
1490         WKWebView.goBack should reload if there is a safe browsing warning
1491         https://bugs.webkit.org/show_bug.cgi?id=193805
1492         <rdar://problem/46908216>
1493
1494         Reviewed by Geoff Garen.
1495
1496         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1497         (+[Simple3LookupContext sharedLookupContext]):
1498         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1499         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1500         (TEST):
1501
1502 2019-01-25  Chris Dumez  <cdumez@apple.com>
1503
1504         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1505         https://bugs.webkit.org/show_bug.cgi?id=193788
1506         <rdar://problem/47531231>
1507
1508         Reviewed by Alex Christensen.
1509
1510         Add API test coverage.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1513         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1514
1515 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1516
1517         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1518         https://bugs.webkit.org/show_bug.cgi?id=193771
1519
1520         Unreviewed infrastructure fix.
1521
1522         * Scripts/webkitpy/port/darwin.py:
1523         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1524
1525 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1526
1527         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1528
1529 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1530
1531         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1532
1533         * Scripts/webkitpy/common/config/contributors.json:
1534
1535 2019-01-25  Chris Dumez  <cdumez@apple.com>
1536
1537         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1538         https://bugs.webkit.org/show_bug.cgi?id=193779
1539         <rdar://problem/46170903>
1540
1541         Reviewed by Antti Koivisto.
1542
1543         Add API test that quickly navigates forward to a previous process without waiting for it to
1544         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1545         the process' previous page when reconnecting the it for the forward navigation.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1548
1549 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1550
1551         Need a way for JavaScript (or bundle) code to participate in undo
1552         https://bugs.webkit.org/show_bug.cgi?id=190009
1553         <rdar://problem/44807048>
1554
1555         Reviewed by Ryosuke Niwa.
1556
1557         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1558         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1559
1560         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1561         (WTR::UIScriptController::lastUndoLabel const):
1562         (WTR::UIScriptController::firstRedoLabel const):
1563         (WTR::UIScriptController::platformUndoManager const):
1564         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1565         (WTR::UIScriptController::lastUndoLabel const):
1566         (WTR::UIScriptController::firstRedoLabel const):
1567         (WTR::UIScriptController::platformUndoManager const):
1568         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1569         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1570         (WTR::UIScriptController::lastUndoLabel const):
1571         (WTR::UIScriptController::firstRedoLabel const):
1572         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1573         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1574         (WTR::UIScriptController::lastUndoLabel const):
1575         (WTR::UIScriptController::firstRedoLabel const):
1576         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1577         (WTR::UIScriptController::platformUndoManager const):
1578         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1579         (WTR::UIScriptController::platformUndoManager const):
1580
1581 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1582
1583         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1584         https://bugs.webkit.org/show_bug.cgi?id=193824
1585
1586         Reviewed by Antti Koivisto.
1587
1588         * LayoutReloaded/misc/LFC-passing-tests.txt:
1589
1590 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1591
1592         Update macOS JSC bot configurations
1593         https://bugs.webkit.org/show_bug.cgi?id=193739
1594
1595         Reviewed by Alexey Proskuryakov.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1599         (BubbleQueueServer): Move JSC EWS to Mojave section.
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1601         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1602         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1603
1604 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1605
1606         [Win][WebKitTestRunner] Implement EventSenderProxy
1607         https://bugs.webkit.org/show_bug.cgi?id=193755
1608
1609         Reviewed by Don Olmstead.
1610
1611         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1612         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1613         (WTR::EventSenderProxy::dispatchMessage):
1614         (WTR::EventSenderProxy::EventSenderProxy):
1615         (WTR::EventSenderProxy::mouseDown):
1616         (WTR::EventSenderProxy::mouseUp):
1617         (WTR::EventSenderProxy::mouseMoveTo):
1618         (WTR::EventSenderProxy::mouseScrollBy):
1619         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1620
1621 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1622
1623         Unreviewed fix for API test failure after r240437.
1624
1625         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1626
1627         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1628
1629 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1630
1631         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1632         https://bugs.webkit.org/show_bug.cgi?id=193787
1633         <rdar://problem/47497634>
1634
1635         Reviewed by Alexey Proskuryakov.
1636
1637         * Scripts/webkitdirs.pm:
1638         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1639
1640 2019-01-24  Truitt Savell  <tsavell@apple.com>
1641
1642         Unreviewed, rolling out r240446.
1643
1644         Casued 5 API failures
1645
1646         Reverted changeset:
1647
1648         "Activate the WebResourceLoadStatisticsStore in the
1649         NetworkProcess and deactivate it in the UIProcess."
1650         https://bugs.webkit.org/show_bug.cgi?id=193297
1651         https://trac.webkit.org/changeset/240446
1652
1653 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1654
1655         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1656         https://bugs.webkit.org/show_bug.cgi?id=193741
1657         <rdar://problem/47135030>
1658
1659         Reviewed by Antti Koivisto and Simon Fraser.
1660
1661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1662         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1663         (TestWebKitAPI::TEST):
1664
1665 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1666
1667         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1668         https://bugs.webkit.org/show_bug.cgi?id=193297
1669         <rdar://problem/47158841>
1670
1671         Reviewed by Alex Christensen.
1672
1673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1674         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1675         activating the message used to trigger the callback when it is set.
1676
1677 2019-01-24  John Wilander  <wilander@apple.com>
1678
1679         Add Ad Click Attribution as an internal/experimental feature
1680         https://bugs.webkit.org/show_bug.cgi?id=193685
1681         <rdar://problem/47450399>
1682
1683         Reviewed by Brent Fulgham.
1684
1685         Added test option adClickAttributionEnabled.
1686
1687         * DumpRenderTree/TestOptions.cpp:
1688         (TestOptions::TestOptions):
1689         * DumpRenderTree/TestOptions.h:
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (setWebPreferencesForTestOptions):
1692
1693 2019-01-24  Antti Koivisto  <antti@apple.com>
1694
1695         [PSON] Flash on back navigation on Mac
1696         https://bugs.webkit.org/show_bug.cgi?id=193716
1697         <rdar://problem/47148458>
1698
1699         Reviewed by Chris Dumez.
1700
1701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1702
1703         Closing of the previous page is delayed so waiting for didFinishNavigation is
1704         not sufficient to guarantee we have received all the messages. Wait for them.
1705
1706 2019-01-24  Chris Dumez  <cdumez@apple.com>
1707
1708         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1709         https://bugs.webkit.org/show_bug.cgi?id=193761
1710         <rdar://problem/47456405>
1711
1712         Reviewed by Alex Christensen.
1713
1714         Add API test coverage.
1715
1716         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1717
1718 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1719
1720         webkitpy: Missing PID in crashlog name should not be fatal
1721         https://bugs.webkit.org/show_bug.cgi?id=193771
1722
1723         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1724         of raising an exception.
1725
1726         Reviewed by Lucas Forschler.
1727
1728         * Scripts/webkitpy/port/darwin.py:
1729         (DarwinPort._merge_crash_logs):
1730
1731 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1732
1733         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1734         https://bugs.webkit.org/show_bug.cgi?id=193746
1735
1736         Reviewed by Youenn Fablet.
1737
1738         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1739         so we'd best just not call it.
1740
1741         * Scripts/webkitpy/w3c/test_exporter.py:
1742         (WebPlatformTestExporter.create_branch_with_patch):
1743
1744 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1745
1746         Move FileSystem to WTF
1747         https://bugs.webkit.org/show_bug.cgi?id=193602
1748
1749         Reviewed by Yusuke Suzuki.
1750
1751         * DumpRenderTree/win/DumpRenderTree.cpp:
1752         * TestWebKitAPI/CMakeLists.txt:
1753         * TestWebKitAPI/PlatformGTK.cmake:
1754         * TestWebKitAPI/PlatformJSCOnly.cmake:
1755         * TestWebKitAPI/PlatformPlayStation.cmake:
1756         * TestWebKitAPI/PlatformWPE.cmake:
1757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1758         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1759         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1760         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1761         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1762         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1763         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1764         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1765         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1766         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1767
1768 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1769
1770         [WPE] Remove hard dependency on subprocess32 for the API tests
1771
1772         Rubber-stamped by Carlos Garcia Campos.
1773
1774         * glib/api_test_runner.py:
1775         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1776         its presence only when running WPEQt tests.
1777
1778 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1779
1780         [GLIB] Expose JavaScriptCore options in GLib public API
1781         https://bugs.webkit.org/show_bug.cgi?id=188742
1782
1783         Reviewed by Michael Catanzaro.
1784
1785         Add a test for the new API.
1786
1787         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1788         (testsJSCOptions):
1789         (main):
1790
1791 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1792
1793         [GTK][WPE] Support JPEG 2000 images
1794         https://bugs.webkit.org/show_bug.cgi?id=186272
1795
1796         Reviewed by Žan Doberšek.
1797
1798         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1799
1800         * gtk/jhbuild.modules:
1801         * wpe/jhbuild.modules:
1802
1803 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1804
1805         check-webkit-style should warn when using soft-linking macros in a header
1806         <https://webkit.org/b/193750>
1807
1808         Reviewed by Darin Adler.
1809
1810         * Scripts/webkitpy/style/checkers/cpp.py:
1811         (check_language): Add softlink/header check by refactoring the
1812         softlink/framework check.
1813         (CppChecker): Enable softlink/header check by default.
1814         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1815         (CppStyleTest.test_softlink_framework): Rename from
1816         CppStyleTest.test_softlink() and change test framework name in
1817         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1818         files. Set file_name for macros that only appear in headers.
1819         (CppStyleTest.test_softlink_header): Add tests for using
1820         soft-link macros in headers.
1821
1822 2019-01-23  Chris Dumez  <cdumez@apple.com>
1823
1824         Deprecate API to limit the maximum number of WebProcesses
1825         https://bugs.webkit.org/show_bug.cgi?id=193725
1826         <rdar://problem/47464879>
1827
1828         Reviewed by Geoff Garen.
1829
1830         Update existing API tests to stop using deprecated API.
1831
1832         * MiniBrowser/mac/AppDelegate.m:
1833         (defaultConfiguration):
1834         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1837         (TestWebKitAPI::TEST):
1838         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1839         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1840         (TEST):
1841         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1842         (TEST):
1843
1844 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1845
1846         [ews-app] Rename ews model buildermappings to buildermapping
1847         https://bugs.webkit.org/show_bug.cgi?id=193729
1848
1849         Reviewed by Lucas Forschler.
1850
1851         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1852         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1853         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1854
1855 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1856
1857         [ews-app] Rename ews model steps to step
1858         https://bugs.webkit.org/show_bug.cgi?id=193697
1859
1860         Reviewed by Lucas Forschler.
1861
1862         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1863         (Step): Renamed Steps to Step.
1864
1865 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1866
1867         Clean up IndexedDB files between tests
1868         https://bugs.webkit.org/show_bug.cgi?id=192796
1869         <rdar://problem/46824999>
1870
1871         Reviewed by Geoffrey Garen.
1872
1873         * DumpRenderTree/mac/DumpRenderTree.mm:
1874         (runTest):
1875         * WebKitTestRunner/TestController.cpp:
1876         (WTR::TestController::resetStateToConsistentValues):
1877         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1878         (WTR::RemoveAllIndexedDatabasesCallback):
1879         (WTR::TestController::ClearIndexedDatabases):
1880         * WebKitTestRunner/TestController.h:
1881         * WebKitTestRunner/TestInvocation.cpp:
1882         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1883
1884 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1885
1886         [ews-app] Rename ews model Builds to Build
1887         https://bugs.webkit.org/show_bug.cgi?id=193695
1888
1889         Reviewed by Lucas Forschler.
1890
1891         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1892         (Build): Renamed Builds to Build.
1893
1894 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1895
1896         webkitpy: Wait longer when launching WebKitTestRunner
1897         https://bugs.webkit.org/show_bug.cgi?id=193734
1898
1899         Reviewed by Aakash Jain.
1900
1901         * Scripts/webkitpy/port/simulator_process.py:
1902         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1903
1904 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1905
1906         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1907         https://bugs.webkit.org/show_bug.cgi?id=193182
1908         <rdar://problem/47452154>
1909
1910         Reviewed by Tim Horton.
1911
1912         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1913         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1914         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1915
1916         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1917         preventing later tests from recognizing gestures.
1918
1919         * WebKitTestRunner/ios/TestControllerIOS.mm:
1920         (WTR::TestController::platformResetStateToConsistentValues):
1921
1922         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1923
1924 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1925
1926         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1927         https://bugs.webkit.org/show_bug.cgi?id=193722
1928         <rdar://problem/47481475>
1929
1930         Reviewed by Lucas Forschler.
1931
1932         iPhone and iPad ports should both use the iOS config.
1933
1934         * Scripts/webkitpy/port/ios_simulator.py:
1935         (IPhoneSimulatorPort.__init__):
1936         (IPadSimulatorPort.__init__):
1937
1938 2019-01-23  Rob Buis  <rbuis@igalia.com>
1939
1940         Update MIME type parser
1941         https://bugs.webkit.org/show_bug.cgi?id=180526
1942
1943         Reviewed by Frédéric Wang.
1944
1945         Add unit tests for both parse modes of ParsedContentType.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1949         (TestWebKitAPI::TEST):
1950
1951 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1952
1953         [ews-app] fetch loop should not stop on network issues
1954         https://bugs.webkit.org/show_bug.cgi?id=193666
1955
1956         Reviewed by Lucas Forschler.
1957
1958         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1959         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1960
1961 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1962
1963         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1964         https://bugs.webkit.org/show_bug.cgi?id=189165
1965         <rdar://problem/47433765>
1966
1967         Reviewed by Tim Horton.
1968
1969         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1970         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1971         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1972         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1973         would make its way to the UI process by the time the layer tree commit is finished.
1974
1975         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1976         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1977         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1978         will fail because it asks for -_autofillContext too early.
1979
1980         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1981         is handled in the UI process.
1982
1983         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1984
1985         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1986         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1987         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1988         input session.
1989
1990         (-[AutofillTestView textInputHasAutofillContext]):
1991
1992         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1993
1994         * TestWebKitAPI/cocoa/TestWKWebView.h:
1995         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1996         (nextInputSessionChangeCount):
1997
1998         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1999         This includes changing the focused element from one to another.
2000
2001         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2002         (-[TestWKWebView didStartFormControlInteraction]):
2003         (-[TestWKWebView didEndFormControlInteraction]):
2004         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2005
2006         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2007         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2008         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2009         that doesn't require an input session to one that doesn't.
2010
2011 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2012
2013         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2014         <https://webkit.org/b/193676>
2015
2016         Reviewed by Alexey Proskuryakov.
2017
2018         * Scripts/webkitpy/style/checkers/cpp.py:
2019         (check_member_initialization_list):
2020         - Don't report missing whitespace around colon if the colon at
2021           the start of the line is formatted correctly.
2022         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2023         (WebKitStyleTest.test_member_initialization_list):
2024         - Add a test for a missing permutation of existing tests.
2025         - Add a test this false-positive.
2026         - Add blank lines between subtests to make them easier to read.
2027
2028 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2029
2030         [build.webkit.org] Unit-test failure after r237113
2031         https://bugs.webkit.org/show_bug.cgi?id=193669
2032
2033         Reviewed by Michael Catanzaro.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2036         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2037         multiple or zero flags.
2038
2039 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2040
2041         Cache bytecode to disk
2042         https://bugs.webkit.org/show_bug.cgi?id=192782
2043         <rdar://problem/46084932>
2044
2045         Reviewed by Keith Miller.
2046
2047         Add test helper to execute bytecode-cache tests: it executes each test
2048         twice, the first with JSC_diskCachePath set to a temporary directory
2049         and second with JSC_forceDiskCache=true (in addition to the cache path)
2050         to guarantee that only the disk cache is being used and no new
2051         UnlinkedCodeBlocks are being created.
2052
2053         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2054         * Scripts/run-jsc-stress-tests:
2055
2056 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2057
2058         [css-logical] Implement flow-relative margin, padding and border shorthands
2059         https://bugs.webkit.org/show_bug.cgi?id=188697
2060
2061         Reviewed by Simon Fraser and Antti Koivisto.
2062
2063         * DumpRenderTree/TestOptions.cpp:
2064         (TestOptions::TestOptions):
2065         * DumpRenderTree/TestOptions.h:
2066         * DumpRenderTree/mac/DumpRenderTree.mm:
2067         (setWebPreferencesForTestOptions):
2068         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2069
2070         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2071         (JSONCSSPropertiesChecker.check_codegen_properties):
2072         Allow CSS property definitions to have a 'runtime-flag' parameter which
2073         disables the property when the specified runtime flag is disabled.
2074
2075 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2076
2077         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2078         https://bugs.webkit.org/show_bug.cgi?id=193643
2079
2080         Reviewed by Michael Catanzaro.
2081
2082         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2083         * wpe/jhbuild.modules: Ditto.
2084
2085 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2086
2087         [LFC][Floats] Take float top position into account when computing containing block height.
2088         https://bugs.webkit.org/show_bug.cgi?id=193655
2089
2090         Reviewed by Antti Koivisto.
2091
2092         * LayoutReloaded/misc/LFC-passing-tests.txt:
2093
2094 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2095
2096         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2097         <https://webkit.org/b/193645>
2098         <rdar://problem/47421574>
2099
2100         Reviewed by Alex Christensen.
2101
2102         - Now checks for local soft-linking of all frameworks that have
2103           their own *SoftLinking.{cpp,h,mm} files.
2104         - Changes softlink/uikit warning to softlink/framework.
2105
2106         * Scripts/webkitpy/style/checkers/cpp.py:
2107         (check_language):
2108         (CppChecker):
2109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2110         (CppStyleTest):
2111
2112 2019-01-20  Saam Barati  <sbarati@apple.com>
2113
2114         Rollout r240210: It broke tests on iOS
2115         https://bugs.webkit.org/show_bug.cgi?id=193640
2116
2117         Unreviewed.
2118
2119         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2120         * Scripts/run-jsc-stress-tests:
2121
2122 2019-01-20  chris fleizach  <cfleizach@apple.com>
2123
2124         AX: Support returning relative frames for accessibility
2125         https://bugs.webkit.org/show_bug.cgi?id=193414
2126         <rdar://problem/47268501>
2127
2128         Reviewed by Zalan Bujtas.
2129
2130         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2131         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2132         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2133         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2134         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2135         (WTR::attributesOfElement):
2136         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2137
2138 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2139
2140         Unreviewed, add my new email address
2141
2142         * Scripts/webkitpy/common/config/contributors.json:
2143
2144 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2145
2146         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2147         https://bugs.webkit.org/show_bug.cgi?id=193617
2148
2149         Reviewed by Antti Koivisto.
2150
2151         * LayoutReloaded/misc/LFC-passing-tests.txt:
2152
2153 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2154
2155         Unreviewed, rolling out r240209.
2156
2157         Broke GTK/WPE injected bundle
2158
2159         Reverted changeset:
2160
2161         "AX: Support returning relative frames for accessibility"
2162         https://bugs.webkit.org/show_bug.cgi?id=193414
2163         https://trac.webkit.org/changeset/240209
2164
2165 2019-01-12  Dan Bernstein  <mitz@apple.com>
2166
2167         [Cocoa] Avoid importing directly from subumbrella frameworks
2168         https://bugs.webkit.org/show_bug.cgi?id=186016
2169         <rdar://problem/40591038>
2170
2171         Reviewed by Sam Weinig.
2172
2173         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2174           LaunchServices header.
2175         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2176           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2177         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2178           when using SDKs earlier than 10.13.
2179         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2180           and OTHER_CPLUSPLUSFLAGS.
2181         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2182           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2183         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2184           LaunchServices header.
2185
2186 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2187
2188         Cache bytecode to disk
2189         https://bugs.webkit.org/show_bug.cgi?id=192782
2190         <rdar://problem/46084932>
2191
2192         Reviewed by Keith Miller.
2193
2194         Add test helper to execute bytecode-cache tests: it executes each test
2195         twice, the first with JSC_diskCachePath set to a temporary directory
2196         and second with JSC_forceDiskCache=true (in addition to the cache path)
2197         to guarantee that only the disk cache is being used and no new
2198         UnlinkedCodeBlocks are being created.
2199
2200         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2201         * Scripts/run-jsc-stress-tests:
2202
2203 2019-01-20  chris fleizach  <cfleizach@apple.com>
2204
2205         AX: Support returning relative frames for accessibility
2206         https://bugs.webkit.org/show_bug.cgi?id=193414
2207         <rdar://problem/47268501>
2208
2209         Reviewed by Zalan Bujtas.
2210
2211         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2212         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2213         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2214         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2215         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2216         (WTR::attributesOfElement):
2217         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2218
2219 2019-01-20  Antoine Quint  <graouts@apple.com>
2220
2221         Add a POINTER_EVENTS feature flag
2222         https://bugs.webkit.org/show_bug.cgi?id=193577
2223         <rdar://problem/47408511>
2224
2225         Unreviewed. Also enable Pointer Events for iosmac.
2226
2227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2228
2229 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2230
2231         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2232         https://bugs.webkit.org/show_bug.cgi?id=193613
2233
2234         Reviewed by Antti Koivisto.
2235
2236         * LayoutReloaded/misc/LFC-passing-tests.txt:
2237
2238 2019-01-19  Antoine Quint  <graouts@apple.com>
2239
2240         Add a POINTER_EVENTS feature flag
2241         https://bugs.webkit.org/show_bug.cgi?id=193577
2242
2243         Reviewed by Dean Jackson.
2244
2245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2246
2247 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2248
2249         Disable the run-jsc-stress-test remote host key check [second round].
2250         https://bugs.webkit.org/show_bug.cgi?id=192988
2251
2252         Reviewed by Dewei Zhu.
2253
2254         * Scripts/run-jsc-stress-tests:
2255
2256 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2257
2258         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2259         https://bugs.webkit.org/show_bug.cgi?id=193597
2260
2261         Reviewed by Lucas Forschler.
2262
2263         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2264
2265 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2268         https://bugs.webkit.org/show_bug.cgi?id=193595
2269
2270         Reviewed by Lucas Forschler.
2271
2272         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2273         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2274         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2275
2276 2019-01-18  Chris Dumez  <cdumez@apple.com>
2277
2278         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2279         https://bugs.webkit.org/show_bug.cgi?id=193588
2280         <rdar://problem/47131566>
2281
2282         Reviewed by Alex Christensen.
2283
2284         Add layout test coverage.
2285
2286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2287
2288 2019-01-18  Jer Noble  <jer.noble@apple.com>
2289
2290         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2291         https://bugs.webkit.org/show_bug.cgi?id=189553
2292
2293         Reviewed by Tim Horton.
2294
2295         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2296
2297         * ContentExtensionTester/Configurations/Base.xcconfig:
2298         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2299         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2300         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2301         * ImageDiff/cg/Configurations/Base.xcconfig:
2302         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2303         * MiniBrowser/Configurations/Base.xcconfig:
2304         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2305         * MobileMiniBrowser/Configurations/Base.xcconfig:
2306         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2307         * Scripts/webkitpy/style/checker.py:
2308         (_all_categories):
2309         (FileType):
2310         (CheckerDispatcher._file_type):
2311         (CheckerDispatcher._create_checker):
2312         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2313         (SDKVariantChecker):
2314         (SDKVariantChecker.__init__):
2315         (SDKVariantChecker.check):
2316         * TestWebKitAPI/Configurations/Base.xcconfig:
2317         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2318         * WebEditingTester/Configurations/Base.xcconfig:
2319         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2320         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2321         * WebKitTestRunner/Configurations/Base.xcconfig:
2322         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2323         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2324         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2325
2326 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2327
2328         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2329         <https://webkit.org/b/193568>
2330         <rdar://problem/47381130>
2331
2332         Reviewed by Alex Christensen.
2333
2334         Make sure no one re-introduces UIKit soft-linking by adding a
2335         style rule.
2336
2337         * Scripts/webkitpy/style/checkers/cpp.py:
2338         (check_language): Add softlink/uikit check.
2339         (CppChecker): Enable softlink/uikit check.
2340         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2341         (CppStyleTest): Add test for softlink/uikit.
2342
2343 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2344
2345         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2346         https://bugs.webkit.org/show_bug.cgi?id=193584
2347
2348         Change "-dev" to "-devel".
2349
2350         Reviewed by Michael Catanzaro.
2351
2352         * gtk/install-dependencies:
2353
2354 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2355
2356         webkitpy: Add iPhone and iPad ports
2357         https://bugs.webkit.org/show_bug.cgi?id=193537
2358         <rdar://problem/47353390>
2359
2360         Reviewed by Lucas Forschler.
2361
2362         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2363         ports. Note that this separation is optional, the --ios-simulator command remains.
2364
2365         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2366         (RunTest.test_device_type_test_division): Drive-by fix.
2367         (RunTest.test_device_type_specific_listing): Ditto.
2368         (RunTest.test_ipad_test_division):
2369         (RunTest):
2370         (RunTest.test_ipad_listing):
2371         * Scripts/webkitpy/port/factory.py:
2372         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2373         (PortFactory):
2374         * Scripts/webkitpy/port/ios_simulator.py:
2375         (IPhoneSimulatorPort):
2376         (IPadSimulatorPort):
2377
2378 2019-01-18  Chris Dumez  <cdumez@apple.com>
2379
2380         Regression(PSON) Scroll position is not always restored properly when navigating back
2381         https://bugs.webkit.org/show_bug.cgi?id=193578
2382         <rdar://problem/47386331>
2383
2384         Reviewed by Tim Horton.
2385
2386         Add API test coverage.
2387
2388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2389
2390 2019-01-18  Youenn Fablet  <youenn@apple.com>
2391
2392         Add a new SPI to request for cache storage quota increase
2393         https://bugs.webkit.org/show_bug.cgi?id=193323
2394
2395         Reviewed by Alex Christensen.
2396
2397         Implement WebsiteDataStore quota delegate to handle quota requests.
2398         By default, do not update quota.
2399         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2400
2401         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2402         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2403         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2404         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2405         * WebKitTestRunner/TestController.cpp:
2406         (WTR::TestController::allowCacheStorageQuotaIncrease):
2407         * WebKitTestRunner/TestController.h:
2408         * WebKitTestRunner/TestInvocation.cpp:
2409         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2410         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2411         (-[CacheStorageQuotaManager init]):
2412         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2413         (WTR::initializeWebViewConfiguration):
2414         (WTR::TestController::cocoaResetStateToConsistentValues):
2415         (WTR::TestController::allowCacheStorageQuotaIncrease):
2416
2417 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2418
2419         [ews-build] Pass owner to the triggered builds
2420         https://bugs.webkit.org/show_bug.cgi?id=193574
2421
2422         Reviewed by Lucas Forschler.
2423
2424         * BuildSlaveSupport/ews-build/factories.py:
2425         (BuildFactory.propertiesToPassToTriggers):
2426
2427 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2428
2429         [ews-app] Send patch author as a build property
2430         https://bugs.webkit.org/show_bug.cgi?id=193560
2431
2432         Reviewed by Lucas Forschler.
2433
2434         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2435         (BugzillaPatchFetcher.fetch):
2436
2437 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2438
2439         webkitpy: Implement device type specific expected results (Follow-up fix)
2440         https://bugs.webkit.org/show_bug.cgi?id=192162
2441         <rdar://problem/46345449>
2442
2443         Unreviewed infrastructure fix.
2444
2445         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2446         (Manager.run): Don't boot a device if no tests are available to run on it.
2447
2448 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2449
2450         webkitpy: Implement device type specific expected results (Follow-up fix)
2451         https://bugs.webkit.org/show_bug.cgi?id=192162
2452         <rdar://problem/46345449>
2453
2454         Unreviewed infrastructure fix.
2455
2456         * Scripts/webkitpy/api_tests/manager.py:
2457         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2458
2459 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2460
2461         webkitpy: Implement device type specific expected results (Part 2)
2462         https://bugs.webkit.org/show_bug.cgi?id=192162
2463         <rdar://problem/46345449>
2464
2465         Rubber-stamped by Aakash Jain.
2466
2467         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2468         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2469         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2470
2471         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2472         (LayoutTestFinder.find_tests): Pass device_type through.
2473         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2474         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2475         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2476         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2477         (Manager._collect_tests): Pass device type to test finder.
2478         (Manager._needs_web_platform_test):
2479         (Manager._prepare_lists): Index _expectations by device type.
2480         (Manager._test_input_for_file):
2481         (Manager._test_is_slow): Ditto.
2482         (Manager._test_should_dump_jsconsolelog_in_stderr):
2483         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2484         (Manager._get_test_inputs):
2485         (Manager._update_worker_count):
2486         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2487         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2488         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2489         the one which runs the test.
2490         (Manager._run_test_subset):
2491         (Manager._run_tests): Index _expectations by current_device_type.
2492         (Manager._print_expectation_line_for_test): Ditto.
2493         (Manager._print_expectations_for_subset): Ditto.
2494         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2495         Unlike run, this function will behave the same regardless of what devices are available.
2496         (Manager._custom_device_for_test): Deleted.
2497         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2498         (ManagerTest.test_uses_custom_device): Deleted.
2499         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2500         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2501         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2502         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2503         all of the expectations.
2504         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2505         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2506         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2507         (TestExpectations.__init__): Allow device_type to be passed through.
2508         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2509         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2510         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2511         (summarize_results):
2512         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2513         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2514         a test ran with, one must check all expectations to find the first non-skip expectation.
2515         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2516         (RunTest.test_device_type_test_division):
2517         (RunTest):
2518         (RunTest.test_device_type_specific_listing):
2519         * Scripts/webkitpy/port/base.py:
2520         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2521         (Port.supported_device_types): The result of this function will change based on what devices are available.
2522         * Scripts/webkitpy/port/device_port.py:
2523         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2524         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2525         can be used.
2526         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2527         any, or the DEFAULT_DEVICE_TYPES of the port.
2528         * Scripts/webkitpy/port/ios.py:
2529         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2530         * Scripts/webkitpy/port/ios_simulator.py:
2531         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2532         * Scripts/webkitpy/port/watch.py:
2533         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2534         * Scripts/webkitpy/port/watch_simulator.py:
2535         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2536         * Scripts/webkitpy/xcode/device_type.py:
2537         (DeviceType):
2538         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2539
2540 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2541
2542         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2543         https://bugs.webkit.org/show_bug.cgi?id=193575
2544
2545         Reviewed by Michael Catanzaro.
2546
2547         Allow the script to run without explicit port argument because
2548         it's specific to the WPE port anyway.
2549
2550         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2551         and simplify the rest of the code accordingly.
2552
2553 2019-01-18  Charlie Turner  <cturner@igalia.com>
2554
2555         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2556         https://bugs.webkit.org/show_bug.cgi?id=192229
2557
2558         Reviewed by Xabier Rodriguez-Calvar.
2559
2560         * MiniBrowser/wpe/main.cpp:
2561         (main): Enable encrypted-media by default.
2562
2563 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2564
2565         [Flatpak] Missing KeyboardInterrupt exception handler
2566         https://bugs.webkit.org/show_bug.cgi?id=193570
2567
2568         Reviewed by Michael Catanzaro.
2569
2570         * flatpak/flatpakutils.py:
2571         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2572
2573 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2574
2575         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2576         https://bugs.webkit.org/show_bug.cgi?id=193564
2577
2578         Reviewed by Antti Koivisto.
2579
2580         * LayoutReloaded/misc/LFC-passing-tests.txt:
2581
2582 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2583
2584         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2585         https://bugs.webkit.org/show_bug.cgi?id=193562
2586
2587         Reviewed by Antti Koivisto.
2588
2589         * LayoutReloaded/misc/LFC-passing-tests.txt:
2590
2591 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2592
2593         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2594         https://bugs.webkit.org/show_bug.cgi?id=193555
2595
2596         Reviewed by Antti Koivisto.
2597
2598         * LayoutReloaded/misc/LFC-passing-tests.txt:
2599
2600 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2601
2602         [WPE] Add Qt extension
2603         https://bugs.webkit.org/show_bug.cgi?id=191464
2604
2605         Reviewed by Carlos Garcia Campos.
2606
2607         MiniBrowser and API tests for the WPE Qt API. To run the
2608         MiniBrowser a new script is introduced. Example invocation:
2609
2610         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2611
2612         Also note-worthy is the introduction of the python2-subprocess32
2613         dependency to run the GLib API tests.
2614
2615         * MiniBrowser/wpe/CMakeLists.txt:
2616         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2617         * MiniBrowser/wpe/qt/main.cpp: Added.
2618         (main):
2619         * MiniBrowser/wpe/qt/main.qml: Added.
2620         * MiniBrowser/wpe/qt/qml.qrc: Added.
2621         * Scripts/run-gtk-tests:
2622         (GtkTestRunner.is_google_test):
2623         (GtkTestRunner):
2624         (GtkTestRunner.is_qt_test):
2625         * Scripts/run-qt-wpe-minibrowser: Added.
2626         * Scripts/run-wpe-tests:
2627         (WPETestRunner):
2628         (WPETestRunner.is_google_test):
2629         (WPETestRunner.is_qt_test):
2630         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2631         (TestLoad::main):
2632         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2633         (TestLoadHtml::main):
2634         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2635         (TestLoadRequest::main):
2636         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2637         (TestRunJavaScript::main):
2638         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2639         (waitForSignal):
2640         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2641         (LoadSpy::LoadSpy):
2642         (LoadSpy::~LoadSpy):
2643         (LoadSpy::onLoadingChanged):
2644         (LoadStartedCatcher::LoadStartedCatcher):
2645         (LoadStartedCatcher::~LoadStartedCatcher):
2646         (LoadStartedCatcher::onLoadingChanged):
2647         (waitForLoadSucceeded):
2648         (waitForLoadFailed):
2649         * TestWebKitAPI/glib/CMakeLists.txt:
2650         * flatpak/flatpakutils.py:
2651         (WebkitFlatpak.load_from_args):
2652         (WebkitFlatpak.__init__):
2653         (WebkitFlatpak.clean_args):
2654         (WebkitFlatpak.run_in_sandbox):
2655         * flatpak/org.webkit.CommonModules.yaml:
2656         * flatpak/org.webkit.WPE.yaml:
2657         * flatpak/org.webkit.WPEModules.yaml:
2658         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2659         * flatpak/org.webkit.WebKit.yaml:
2660         * glib/api_test_runner.py:
2661         (TestRunner._run_test_qt):
2662         (TestRunner.is_qt_test):
2663         (TestRunner._run_test):
2664
2665 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2666
2667         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2668         https://bugs.webkit.org/show_bug.cgi?id=193494
2669         <rdar://problem/46859627>
2670
2671         Reviewed by Simon Fraser and Tim Horton.
2672
2673         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2674         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2675
2676         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2677         (WTR::UIScriptController::contentOffsetX const):
2678         (WTR::UIScriptController::contentOffsetY const):
2679         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2680         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2681         (WTR::UIScriptController::contentOffsetX const):
2682         (WTR::UIScriptController::contentOffsetY const):
2683         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2684
2685         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2686
2687         * WebKitTestRunner/TestController.cpp:
2688         (WTR::updateTestOptionsFromTestHeader):
2689         * WebKitTestRunner/TestOptions.h:
2690         (WTR::TestOptions::hasSameInitializationOptions const):
2691         * WebKitTestRunner/ios/TestControllerIOS.mm:
2692         (WTR::TestController::platformResetStateToConsistentValues):
2693         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2694         (WTR::UIScriptController::contentOffsetX const):
2695         (WTR::UIScriptController::contentOffsetY const):
2696
2697 2019-01-17  Truitt Savell  <tsavell@apple.com>
2698
2699         Unreviewed, rolling out r240124.
2700
2701         This commit broke an internal build.
2702
2703         Reverted changeset:
2704
2705         "SDK_VARIANT build destinations should be separate from non-
2706         SDK_VARIANT builds"
2707         https://bugs.webkit.org/show_bug.cgi?id=189553
2708         https://trac.webkit.org/changeset/240124
2709
2710 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2711
2712         Fix string concatenation API test after r239920
2713         https://bugs.webkit.org/show_bug.cgi?id=193551
2714         <rdar://problem/47359304>
2715
2716         Reviewed by Youenn Fablet.
2717
2718         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2719         (TestWebKitAPI::TEST):
2720         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2721         in WebKit's build configuration like it apparently is on Linux.
2722
2723 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2724
2725         [ews-build] validate-patch should handle the case when bug_id is None
2726         https://bugs.webkit.org/show_bug.cgi?id=193547
2727
2728         Reviewed by Lucas Forschler.
2729
2730         * BuildSlaveSupport/ews-build/steps.py:
2731         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2732         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2733
2734 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2735
2736         [ews-build] Add patch author information in build
2737         https://bugs.webkit.org/show_bug.cgi?id=193465
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * BuildSlaveSupport/ews-build/steps.py:
2742         (ValidatePatch._is_patch_obsolete):
2743
2744 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2745
2746         [ews-build] Pass bug_id to the triggered builds
2747         https://bugs.webkit.org/show_bug.cgi?id=193548
2748
2749         Reviewed by Lucas Forschler.
2750
2751         * BuildSlaveSupport/ews-build/factories.py:
2752         (BuildFactory.propertiesToPassToTriggers):
2753
2754 2019-01-17  Jer Noble  <jer.noble@apple.com>
2755
2756         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2757         https://bugs.webkit.org/show_bug.cgi?id=189553
2758
2759         Reviewed by Tim Horton.
2760
2761         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2762
2763         * ContentExtensionTester/Configurations/Base.xcconfig:
2764         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2765         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2766         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2767         * ImageDiff/cg/Configurations/Base.xcconfig:
2768         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2769         * MiniBrowser/Configurations/Base.xcconfig:
2770         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2771         * MobileMiniBrowser/Configurations/Base.xcconfig:
2772         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2773         * Scripts/webkitpy/style/checker.py:
2774         (_all_categories):
2775         (FileType):
2776         (CheckerDispatcher._file_type):
2777         (CheckerDispatcher._create_checker):
2778         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2779         (SDKVariantChecker):
2780         (SDKVariantChecker.__init__):
2781         (SDKVariantChecker.check):
2782         * TestWebKitAPI/Configurations/Base.xcconfig:
2783         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2784         * WebEditingTester/Configurations/Base.xcconfig:
2785         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2786         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2787         * WebKitTestRunner/Configurations/Base.xcconfig:
2788         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2789         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2790         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2791
2792 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2793
2794         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2795         https://bugs.webkit.org/show_bug.cgi?id=193534
2796
2797         Reviewed by Antti Koivisto.
2798
2799         * LayoutReloaded/misc/LFC-passing-tests.txt:
2800
2801 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2802
2803         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2804         https://bugs.webkit.org/show_bug.cgi?id=193528
2805
2806         Reviewed by Antti Koivisto.
2807
2808         * LayoutReloaded/misc/LFC-passing-tests.txt:
2809
2810 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2811
2812         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2813         https://bugs.webkit.org/show_bug.cgi?id=193520
2814
2815         Reviewed by Antti Koivisto.
2816
2817         * LayoutReloaded/misc/LFC-passing-tests.txt:
2818
2819 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] unapply-patch step should not update source
2822         https://bugs.webkit.org/show_bug.cgi?id=193234
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/steps.py:
2827         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2828         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2829
2830 2019-01-16  Youenn Fablet  <youenn@apple.com>
2831
2832         Add a new SPI for controlling getUserMedia
2833         https://bugs.webkit.org/show_bug.cgi?id=192793
2834
2835         Reviewed by Eric Carlson.
2836
2837         * MiniBrowser/mac/WK2BrowserWindowController.m:
2838         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2839         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2840         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2841         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2842         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2843         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2844         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2845         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2846         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2847         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2848         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2849         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2850         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2851         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2852
2853 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2854
2855         [LFC][BFC] Inflow non-replaced used width should not be negative.
2856         https://bugs.webkit.org/show_bug.cgi?id=193495
2857
2858         Reviewed by Antti Koivisto.
2859
2860         * LayoutReloaded/misc/LFC-passing-tests.txt:
2861
2862 2019-01-16  Chris Dumez  <cdumez@apple.com>
2863
2864         Regression(PSON) View becomes blank after click a cross-site download link
2865         https://bugs.webkit.org/show_bug.cgi?id=193361
2866         <rdar://problem/47099573>
2867
2868         Reviewed by Geoffrey Garen.
2869
2870         Add API test coverage.
2871
2872         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2873         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2874
2875 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2876
2877         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2878         https://bugs.webkit.org/show_bug.cgi?id=193470
2879
2880         Reviewed by Antti Koivisto.
2881
2882         * LayoutReloaded/misc/LFC-passing-tests.txt:
2883
2884 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2885
2886         [LFC] Adjust margin box verification.
2887         https://bugs.webkit.org/show_bug.cgi?id=193482
2888
2889         Reviewed by Antti Koivisto.
2890
2891         * LayoutReloaded/misc/LFC-passing-tests.txt:
2892
2893 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2894
2895         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2896         https://bugs.webkit.org/show_bug.cgi?id=193451
2897
2898         Reviewed by Geoffrey Garen.
2899
2900         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2901         (TEST):
2902         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2903         (runWebsiteDataStoreCustomPaths):
2904
2905 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2906
2907         webkitpy: Support boolean simctl isAvailable
2908         https://bugs.webkit.org/show_bug.cgi?id=193472
2909         <rdar://problem/47296150>
2910
2911         Reviewed by Ryosuke Niwa.
2912
2913         * Scripts/webkitpy/xcode/simulated_device.py:
2914         (SimulatedDeviceManager._create_runtimes):
2915         (SimulatedDeviceManager._create_device_with_runtime):
2916
2917 2019-01-15  Chris Dumez  <cdumez@apple.com>
2918
2919         Unreviewed, rolling out r239993, r239995, r239997, and
2920         r239999.
2921
2922         Caused assertions under
2923         ViewGestureController::disconnectFromProcess()
2924
2925         Reverted changesets:
2926
2927         "Regression(PSON) View becomes blank after click a cross-site
2928         download link"
2929         https://bugs.webkit.org/show_bug.cgi?id=193361
2930         https://trac.webkit.org/changeset/239993
2931
2932         "Unreviewed iOS build fix after r239993."
2933         https://trac.webkit.org/changeset/239995
2934
2935         "Fix iOS build after r239993"
2936         https://bugs.webkit.org/show_bug.cgi?id=193361
2937         https://trac.webkit.org/changeset/239997
2938
2939         "Unreviewed, revert part of r239997 as it is not needed to fix
2940         the build."
2941         https://trac.webkit.org/changeset/239999
2942
2943 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2944
2945         Cannot tab out of WKWebView on macOS
2946         https://bugs.webkit.org/show_bug.cgi?id=161448
2947         <rdar://problem/28100085>
2948
2949         Reviewed by Dean Jackson.
2950
2951         Add a test that tabbing into and out of WKWebView works correctly.
2952
2953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2954         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2955         (WebKit2_CommandBackForwardTest::SetUp):
2956         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2957         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2958         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2959         (-[FocusableView canBecomeKeyView]):
2960         (TEST):
2961         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2962         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2963         (-[OffscreenWindow initWithSize:]):
2964         (-[OffscreenWindow isKeyWindow]):
2965         (-[OffscreenWindow isVisible]):
2966         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2967         (TestWebKitAPI::PlatformWebView::initialize):
2968         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2969         (-[ActiveOffscreenWindow isVisible]): Deleted.
2970         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2971
2972 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2973
2974         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2975         https://bugs.webkit.org/show_bug.cgi?id=193459
2976
2977         Reviewed by Mark Lam.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2980         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2981
2982 2019-01-15  Chris Dumez  <cdumez@apple.com>
2983
2984         Regression(PSON) View becomes blank after click a cross-site download link
2985         https://bugs.webkit.org/show_bug.cgi?id=193361
2986         <rdar://problem/47099573>
2987
2988         Reviewed by Geoff Garen.
2989
2990         Add API test coverage.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2993         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2994
2995 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2996
2997         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2998         https://bugs.webkit.org/show_bug.cgi?id=193448
2999
3000         Reviewed by Antti Koivisto.
3001
3002         * LayoutReloaded/misc/LFC-passing-tests.txt:
3003
3004 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3005
3006         webkitpy: Implement device type specific expected results (Part 1)
3007         https://bugs.webkit.org/show_bug.cgi?id=192162
3008
3009         Reviewed by Lucas Forschler.
3010
3011         Device type specific expected results covers two related ideas. The first (covered by this change)
3012         is where to search for -expected.* files. The second is which tests to run based on the
3013         TestExpectations.txt file.
3014
3015         After this change, the baseline search path will be determined by the type of device running a
3016         test. Device type will be passed into any function which picks a file based on the baseline search
3017         path.
3018
3019         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3020         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3021         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3022         (Manager.run): Print baseline search path for each round of devices.
3023         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3024         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3025         (SingleTestRunner._expected_driver_output): Ditto.
3026         (SingleTestRunner._driver_input): Ditto.
3027         * Scripts/webkitpy/layout_tests/views/printing.py:
3028         (Printer.print_config): Move printing of baseline search path to a separate function.
3029         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3030         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3031         (Testprinter.test_print_config):
3032         (Testprinter.test_print_baseline_search_path):
3033         * Scripts/webkitpy/port/base.py:
3034         (Port.baseline_search_path): Pass device_type through.
3035         (Port._expected_baselines_for_suffixes): Ditto.
3036         (Port.expected_baselines): Ditto.
3037         (Port.expected_filename): Ditto.
3038         (Port.expected_checksum): Ditto.
3039         (Port.expected_image): Ditto.
3040         (Port.expected_audio): Ditto.
3041         (Port.expected_text): Ditto.
3042         (Port.reference_files): Ditto.
3043         (Port.tests): Ditto.
3044         (Port._expanded_paths): Ditto.
3045         (Port.skipped_layout_tests): Ditto.
3046         (Port.expectations_dict): Ditto.
3047         (Port._port_specific_expectations_files): Ditto.
3048         (Port.expectations_files): Ditto.
3049         (Port.test_search_path): Ditto.
3050         (Port._tests_for_other_platforms): Ditto.
3051         * Scripts/webkitpy/port/base_unittest.py:
3052         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3053         (PortTest.test_nonexistant_expectations): Ditto.
3054         (test_ref_tests_platform_directory): Ditto.
3055         * Scripts/webkitpy/port/darwin.py:
3056         (DarwinPort._port_specific_expectations_files): Accept device_type.
3057         * Scripts/webkitpy/port/driver.py:
3058         (DriverProxy):
3059         (DriverProxy.host): Expose _target_host for device_type information.
3060         * Scripts/webkitpy/port/gtk.py:
3061         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3062         * Scripts/webkitpy/port/ios.py:
3063         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3064         * Scripts/webkitpy/port/mac.py:
3065         (MacPort. default_baseline_search_path): Ditto.
3066         * Scripts/webkitpy/port/port_testcase.py:
3067         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3068         * Scripts/webkitpy/port/test.py:
3069         * Scripts/webkitpy/port/watch.py:
3070         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3071         * Scripts/webkitpy/port/win.py:
3072         (WinPort.test_search_path): Accept, but do not use, device_type.
3073         * Scripts/webkitpy/port/wpe.py:
3074         (WPEPort._port_specific_expectations_files): Ditto.
3075         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3076         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3077
3078 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3079
3080         [LFC] Use the containing block's padding box to position out-of-flow elements.
3081         https://bugs.webkit.org/show_bug.cgi?id=193431
3082
3083         Reviewed by Antti Koivisto.
3084
3085         * LayoutReloaded/misc/LFC-passing-tests.txt:
3086
3087 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3088
3089         Move a test implementation file that got misplaced in the Xcode project
3090
3091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3092
3093 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3094
3095         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3096         r239913, and r239914.
3097         https://bugs.webkit.org/show_bug.cgi?id=193407
3098
3099         These revisions caused an internal failure (Requested by
3100         Truitt on #webkit).
3101
3102         Reverted changesets:
3103
3104         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3105         https://bugs.webkit.org/show_bug.cgi?id=186016
3106         https://trac.webkit.org/changeset/239901
3107
3108         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3109         https://trac.webkit.org/changeset/239909
3110
3111         "Tried to fix the build."
3112         https://trac.webkit.org/changeset/239910
3113
3114         "Fixed iOS builds after r239910."
3115         https://trac.webkit.org/changeset/239912
3116
3117         "More build fixing."
3118         https://trac.webkit.org/changeset/239913
3119
3120         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3121         https://trac.webkit.org/changeset/239914
3122
3123 2019-01-14  Mark Lam  <mark.lam@apple.com>
3124
3125         Re-enable ability to build --cloop builds.
3126         https://bugs.webkit.org/show_bug.cgi?id=192955
3127         <rdar://problem/46882363>
3128
3129         Reviewed by Saam barati and Keith Miller.
3130
3131         The --cloop build option was being ignored this whole time since r236381.
3132         This patch makes it possible to build CLoop builds again.
3133
3134         * Scripts/build-jsc:
3135         * Scripts/webkitperl/FeatureList.pm:
3136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3137
3138 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3139
3140         webkitpy: Expose device_type from host-like objects
3141         https://bugs.webkit.org/show_bug.cgi?id=193406
3142         <rdar://problem/47262305>
3143
3144         Reviewed by Lucas Forschler.
3145
3146         Devices should expose device_type. As a result, all host objects should
3147         provide a device_type property, even if they do not yet define a device_type.
3148
3149         * Scripts/webkitpy/common/system/systemhost.py:
3150         (SystemHost):
3151         (SystemHost.device_type):
3152         * Scripts/webkitpy/common/system/systemhost_mock.py:
3153         (MockSystemHost):
3154         (MockSystemHost.device_type):
3155         * Scripts/webkitpy/port/device.py:
3156         (Device):
3157         (Device.device_type):
3158         * Scripts/webkitpy/xcode/simulated_device.py:
3159         (SimulatedDeviceManager._find_exisiting_device_for_request):
3160         (SimulatedDeviceManager._disambiguate_device_type):
3161         (SimulatedDeviceManager._does_fulfill_request):
3162         (SimulatedDeviceManager.device_count_for_type):
3163         (SimulatedDeviceManager.initialize_devices):
3164         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3165         (test_available_devices):
3166         (test_swapping_devices):
3167
3168 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3169
3170         webkitpy: Support alternate simctl device list output (Follow-up fix)
3171         https://bugs.webkit.org/show_bug.cgi?id=193362
3172         <rdar://problem/47122965>
3173
3174         Rubber-stamped by Lucas Forschler.
3175
3176         * Scripts/webkitpy/xcode/simulated_device.py:
3177         (SimulatedDeviceManager.populate_available_devices):
3178
3179 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3180
3181         [iOS] Expose SPI to access the current sentence boundary and selection state
3182         https://bugs.webkit.org/show_bug.cgi?id=193398
3183         <rdar://problem/45893108>
3184
3185         Reviewed by Dean Jackson.
3186
3187         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3188         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3189         expected.
3190
3191         * TestWebKitAPI/EditingTestHarness.h:
3192         * TestWebKitAPI/EditingTestHarness.mm:
3193         (-[EditingTestHarness moveBackward]):
3194         (-[EditingTestHarness moveForward]):
3195         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3196
3197         Add a couple of new helper methods on EditingTestHarness.
3198
3199         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3200         (-[SelectionChangeObserver initWithWebView:]):
3201         (-[SelectionChangeObserver webView]):
3202         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3203         (-[SelectionChangeObserver currentSelectionAttributes]):
3204
3205 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3206
3207         [LFC][BFC] Add basic box-sizing support.
3208         https://bugs.webkit.org/show_bug.cgi?id=193392
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * LayoutReloaded/misc/LFC-passing-tests.txt:
3213
3214 2019-01-14  Charlie Turner  <cturner@igalia.com>
3215
3216         [WPE] API test gardening
3217         https://bugs.webkit.org/show_bug.cgi?id=193319
3218
3219         Reviewed by Michael Catanzaro.
3220
3221         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3222         passing tests.
3223
3224 2019-01-14  Charlie Turner  <cturner@igalia.com>
3225
3226         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3227         https://bugs.webkit.org/show_bug.cgi?id=192977
3228
3229         Reviewed by Carlos Garcia Campos.
3230
3231         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3232         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3233         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3234         (TestWebKitAPI::GStreamerTest::SetUp):
3235         (TestWebKitAPI::GStreamerTest::TearDown):
3236         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3237         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3238         (TestWebKitAPI::TEST_F):
3239
3240 2019-01-14  Charlie Turner  <cturner@igalia.com>
3241
3242         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3243         https://bugs.webkit.org/show_bug.cgi?id=193332
3244
3245         Reviewed by Michael Catanzaro.
3246
3247         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3248         defined as a char16_t, which changed in ICU 59, the
3249         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3250         unsigned short. This test is relying on the behaviour that
3251         UChar=unsigned short, which doesn't hold across platforms and ICU
3252         library versions. The full fix would be a special syntax for
3253         literal characters so that these ambiguities do not arise. That
3254         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3255         (TestWebKitAPI::TEST):
3256
3257 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3258
3259         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3260
3261         * Scripts/make-dist:
3262         (Distcheck.configure):
3263
3264 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-build] Update macOS queue configurations
3267         https://bugs.webkit.org/show_bug.cgi?id=193365
3268         <rdar://problem/47221073>
3269
3270         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3271
3272         * BuildSlaveSupport/ews-build/config.json:
3273
3274 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3275
3276         [LFC] Adjust assert for statically positioned fixed elements
3277         https://bugs.webkit.org/show_bug.cgi?id=193385
3278
3279         Reviewed by Antti Koivisto.
3280
3281         * LayoutReloaded/misc/LFC-passing-tests.txt:
3282
3283 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3284
3285         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3286         https://bugs.webkit.org/show_bug.cgi?id=193387
3287
3288         Reviewed by Carlos Garcia Campos.
3289
3290         * MiniBrowser/wpe/main.cpp:
3291         (main):
3292
3293 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3294
3295         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3296         https://bugs.webkit.org/show_bug.cgi?id=191655
3297         rdar://problem/46074680
3298
3299         Reviewed by Megan Gardner.
3300
3301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3302         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3303
3304 2019-01-12  Dan Bernstein  <mitz@apple.com>
3305
3306         [Cocoa] Avoid importing directly from subumbrella frameworks
3307         https://bugs.webkit.org/show_bug.cgi?id=186016
3308         <rdar://problem/40591038>
3309
3310         Reviewed by Sam Weinig.
3311
3312         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3313           LaunchServices header.
3314         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3315           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3316         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3317           when using SDKs earlier than 10.13.
3318         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3319           and OTHER_CPLUSPLUSFLAGS.
3320         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3321           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3322         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3323           LaunchServices header.
3324
3325 2019-01-11  John Wilander  <wilander@apple.com>
3326
3327         Compile out Web API Statistics Collection
3328         https://bugs.webkit.org/show_bug.cgi?id=193370
3329         <rdar://problem/45388584>
3330
3331         Reviewed by Brent Fulgham.
3332
3333         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3334             Defined ENABLE_WEB_API_STATISTICS, off by default.
3335
3336 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3337
3338         [WPE] Add gtk-doc
3339         https://bugs.webkit.org/show_bug.cgi?id=178900
3340
3341         Reviewed by Michael Catanzaro.
3342
3343         Add Tools/gtkdoc to manifest.txt.in files.
3344         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3345
3346         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3347         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3348
3349 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3350
3351         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3352         https://bugs.webkit.org/show_bug.cgi?id=193364
3353         <rdar://problem/47214117>
3354
3355         Reviewed by Tim Horton.
3356
3357         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3358         precise, whereas dragging near the middle of the textarea does.
3359
3360         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3361         (TestWebKitAPI::TEST):
3362
3363 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3364
3365         webkitpy: Support alternate simctl device list output
3366         https://bugs.webkit.org/show_bug.cgi?id=193362
3367         <rdar://problem/47122965>
3368
3369         Reviewed by Lucas Forschler.
3370
3371         * Scripts/webkitpy/xcode/simulated_device.py:
3372         (SimulatedDeviceManager.populate_available_devices):
3373
3374 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-build] Update macOS queue configurations
3377         https://bugs.webkit.org/show_bug.cgi?id=193365
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * BuildSlaveSupport/ews-build/config.json:
3382
3383 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3384
3385         webkitpy: Incorporate device type into baseline search path
3386         https://bugs.webkit.org/show_bug.cgi?id=193356
3387         <rdar://problem/47215515>
3388
3389         Reviewed by Lucas Forschler.
3390
3391         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3392
3393         * Scripts/webkitpy/port/base.py:
3394         (Port.default_baseline_search_path): Allow device type to be passed in.
3395         * Scripts/webkitpy/port/gtk.py:
3396         (GtkPort.default_baseline_search_path): Ignore device type.
3397         * Scripts/webkitpy/port/ios.py:
3398         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3399         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3400         * Scripts/webkitpy/port/ios_device_unittest.py:
3401         (IOSDeviceTest):
3402         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3403         (IOSSimulatorTest):
3404         * Scripts/webkitpy/port/mac.py:
3405         (MacPort.default_baseline_search_path): Ignore device type.
3406         * Scripts/webkitpy/port/watch.py:
3407         (WatchPort.default_baseline_search_path): Ditto.
3408         * Scripts/webkitpy/port/win.py:
3409         (WinPort.default_baseline_search_path): Ditto.
3410         (WinCairoPort.default_baseline_search_path): Ditto.
3411         * Scripts/webkitpy/port/wpe.py:
3412         (WPEPort.default_baseline_search_path): Ditto.
3413
3414 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3415
3416         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3417         https://bugs.webkit.org/show_bug.cgi?id=193352
3418         <rdar://problem/47210736>
3419
3420         Reviewed by Lucas Forschler.
3421
3422         * Scripts/webkitpy/layout_tests/views/printing.py:
3423         (Printer.print_config): Print list on only baseline search paths which exist. 
3424         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3425         (Testprinter.test_print_config):
3426
3427 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3428
3429         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3430         https://bugs.webkit.org/show_bug.cgi?id=193340
3431
3432         Reviewed by David Kilzer.
3433
3434         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3435         (WTR::InjectedBundle::didReceiveMessageToPage):
3436         Pull the strings out into a WKRetainPtr.
3437
3438         * WebKitTestRunner/WebNotificationProvider.cpp:
3439         (WTR::WebNotificationProvider::closeWebNotification):
3440         Adopt the created value into the WKRetainPtr.
3441
3442         * WebKitTestRunner/mac/TestControllerMac.mm:
3443         (WTR::generateWhitelist):
3444         Immediately adopt a created value to avoid potential mistakes.
3445
3446 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3447
3448         Enable DFG on ARM/Linux again
3449         https://bugs.webkit.org/show_bug.cgi?id=192496
3450
3451         Reviewed by Yusuke Suzuki.
3452
3453         After changing the bytecode format DFG was disabled on all 32-bit
3454         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3455         on ARM by default.
3456
3457         * Scripts/run-jsc-stress-tests:
3458
3459 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3460
3461         Unreviewed, fix #ifdef in API test added in r239851.
3462         https://bugs.webkit.org/show_bug.cgi?id=193327
3463         rdar://problem/47093222
3464
3465         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3466
3467 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3468
3469         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3470         https://bugs.webkit.org/show_bug.cgi?id=193109
3471         <rdar://problem/44807048>
3472
3473         Reviewed by Ryosuke Niwa.
3474
3475         Introduce and respect a test option to enable the UndoManager API.
3476
3477         * WebKitTestRunner/TestController.cpp:
3478         (WTR::updateTestOptionsFromTestHeader):
3479         * WebKitTestRunner/TestOptions.h:
3480         (WTR::TestOptions::hasSameInitializationOptions const):
3481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3482         (WTR::TestController::platformCreateWebView):
3483
3484 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3485
3486         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3487         https://bugs.webkit.org/show_bug.cgi?id=193346
3488
3489         Reviewed by Antti Koivisto.
3490
3491         * LayoutReloaded/misc/LFC-passing-tests.txt:
3492
3493 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3494
3495         Unreviewed, fix typo that breaks dashboard link.
3496
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3498         (WebKitBuildbot):
3499
3500 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3501
3502         Update macOS queue configurations
3503         https://bugs.webkit.org/show_bug.cgi?id=193329
3504
3505         Reviewed by Alexey Proskuryakov.
3506
3507         * BuildSlaveSupport/build.webkit.org-config/config.json:
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3509         (BubbleQueueServer):
3510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3512         (WebKitBuildbot):
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3514         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3515         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3516
3517 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3518
3519         MiniBrowser should be able to navigate to about:blank
3520         https://bugs.webkit.org/show_bug.cgi?id=193345
3521
3522         Reviewed by Simon Fraser.
3523
3524         * MiniBrowser/mac/BrowserWindowController.m:
3525         (-[BrowserWindowController addProtocolIfNecessary:]):
3526         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3527
3528         * MiniBrowser/mac/WK1BrowserWindowController.m:
3529         (-[WK1BrowserWindowController fetch:]):
3530         * MiniBrowser/mac/WK2BrowserWindowController.m:
3531         (-[WK2BrowserWindowController fetch:]):
3532         Clean up the code that uses this to match style.
3533
3534 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3535
3536         Remove MiniBrowser custom "Process Swap" menu item which does not work
3537         https://bugs.webkit.org/show_bug.cgi?id=193344
3538
3539         Reviewed by Simon Fraser.
3540
3541         There is a menu item under the Experimental menu that does work.
3542
3543         * MiniBrowser/mac/AppDelegate.m:
3544         (defaultConfiguration):
3545         * MiniBrowser/mac/SettingsController.h:
3546         * MiniBrowser/mac/SettingsController.m:
3547         (-[SettingsController _populateMenu]):
3548         (-[SettingsController validateMenuItem:]):
3549         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3550         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3551
3552 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3553
3554         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3555         https://bugs.webkit.org/show_bug.cgi?id=193327
3556         rdar://problem/47093222
3557
3558         Reviewed by Tim Horton.
3559
3560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3561         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3562         (TestWebKitAPI::didFinishNavigation):
3563         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3564         (TestWebKitAPI::TEST):
3565         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3566         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3567         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3568         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3569         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3570
3571 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3572
3573         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3574         https://bugs.webkit.org/show_bug.cgi?id=193338
3575         <rdar://problem/46664774>
3576
3577         Reviewed by David Kilzer.
3578
3579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3580         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3581
3582 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3583
3584         Unreviewed, rolling out r239825.
3585         https://bugs.webkit.org/show_bug.cgi?id=193330
3586
3587         Broke tests on armv7/linux bots (Requested by guijemont on
3588         #webkit).
3589
3590         Reverted changeset:
3591
3592         "Enable DFG on ARM/Linux again"
3593         https://bugs.webkit.org/show_bug.cgi?id=192496
3594         https://trac.webkit.org/changeset/239825
3595
3596 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3597
3598         Disable the run-jsc-stress-test remote host key check.
3599         https://bugs.webkit.org/show_bug.cgi?id=192988
3600
3601         Reviewed by Alexey Proskuryakov.
3602
3603         * Scripts/run-jsc-stress-tests:
3604
3605 2019-01-10  John Wilander  <wilander@apple.com>
3606
3607         Override the session configuration for cookieAcceptPolicy
3608         https://bugs.webkit.org/show_bug.cgi?id=190925
3609         <rdar://problem/45497382>
3610
3611         Reviewed by Alexey Proskuryakov and Alex Christensen.
3612
3613         Test infrastructure for setting a first-party-only cookie policy.
3614
3615         * DumpRenderTree/TestRunner.cpp:
3616         (setOnlyAcceptFirstPartyCookiesCallback):
3617         (TestRunner::staticFunctions):
3618         * DumpRenderTree/TestRunner.h:
3619         * DumpRenderTree/mac/TestRunnerMac.mm:
3620         (TestRunner::setOnlyAcceptFirstPartyCookies):
3621         * DumpRenderTree/win/TestRunnerWin.cpp:
3622         (TestRunner::setOnlyAcceptFirstPartyCookies):
3623         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3624         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3625         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3626         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3627         * WebKitTestRunner/TestInvocation.cpp:
3628         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3629
3630 2019-01-09  Matt Rajca  <mrajca@apple.com>
3631
3632         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3633         https://bugs.webkit.org/show_bug.cgi?id=193301
3634
3635         Reviewed by Jer Noble.
3636         
3637         Added API tests.
3638
3639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3640         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3641         (TEST):
3642         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3643
3644 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3645
3646         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3647         https://bugs.webkit.org/show_bug.cgi?id=193310
3648
3649         Reviewed by Antti Koivisto.
3650
3651         * LayoutReloaded/misc/LFC-passing-tests.txt:
3652
3653 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3654
3655         Enable DFG on ARM/Linux again
3656         https://bugs.webkit.org/show_bug.cgi?id=192496
3657
3658         Reviewed by Yusuke Suzuki.
3659
3660         After changing the bytecode format DFG was disabled on all 32-bit
3661         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3662         on ARM by default.
3663
3664         * Scripts/run-jsc-stress-tests:
3665
3666 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3667
3668         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3669         https://bugs.webkit.org/show_bug.cgi?id=193271
3670
3671         Reviewed by Brent Fulgham.
3672
3673         BSTR is a special data structure created by SysAllocString, not a
3674         wchar_t null-terminated string.
3675
3676         * DumpRenderTree/win/TestRunnerWin.cpp:
3677         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3678         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3679         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3680         BSTR from wide string literals.
3681
3682 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3683
3684         Tweak wording for build/version_check style checker error
3685         https://bugs.webkit.org/show_bug.cgi?id=193256
3686
3687         Reviewed by Tim Horton.
3688
3689         * Scripts/webkitpy/style/checkers/cpp.py:
3690         (check_os_version_checks):
3691         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3692         (WebKitStyleTest.test_os_version_checks):
3693
3694 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-build] Add link to bug along with bug title
3697         https://bugs.webkit.org/show_bug.cgi?id=193293
3698
3699         Reviewed by Lucas Forschler.
3700
3701         * BuildSlaveSupport/ews-build/steps.py:
3702         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3703         (ConfigureBuild.add_bug_id_url): Deleted.
3704         (ConfigureBuild.getBugURL): Deleted.
3705
3706 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3707
3708         [ews-build] Use https for ews-build server
3709         https://bugs.webkit.org/show_bug.cgi?id=193193
3710
3711         Reviewed by Lucas Forschler.
3712
3713         * BuildSlaveSupport/ews-build/steps.py:
3714
3715 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3716
3717         [ews-build] Parse and display number of style failures
3718         https://bugs.webkit.org/show_bug.cgi?id=193280
3719
3720         Reviewed by Lucas Forschler.
3721
3722         * BuildSlaveSupport/ews-build/steps.py:
3723         (CheckStyle): Use TestWithFailureCount as base class.
3724         (CheckStyle.countFailures): Count the number of style failures.
3725
3726 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3727
3728         [ews-build] use patch_id instead of ewspatchid
3729         https://bugs.webkit.org/show_bug.cgi?id=193235
3730
3731         Reviewed by Lucas Forschler.
3732
3733         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3734         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3735         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3736
3737 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3738
3739         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3740         https://bugs.webkit.org/show_bug.cgi?id=192625
3741
3742         Reviewed by Antti Koivisto.
3743
3744         * LayoutReloaded/misc/LFC-passing-tests.txt:
3745
3746 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3747
3748         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3749         https://bugs.webkit.org/show_bug.cgi?id=192841
3750
3751         Reviewed by Carlos Garcia Campos.
3752
3753         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3754         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3755         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3756
3757         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3758
3759         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3760         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3761         (WebKitWebEditorTest::testSelectionChanged):
3762         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3763         (WebKitFrameTest::testMainFrame):
3764         (WebKitFrameTest::testURI):
3765         (WebKitFrameTest::testJavaScriptContext):
3766         (WebKitFrameTest::testJavaScriptValues):
3767         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3768         (testWebViewAuthenticationRequest):
3769         (testWebViewAuthenticationLoadCancelled):
3770         (testWebViewAuthenticationFailure):
3771         (testWebViewAuthenticationStorage):
3772         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3773         (testWebViewAuthenticationProxy):
3774         (testWebViewAuthenticationProxyHTTPS):
3775         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3776         (testAutomationSessionRequestSession):
3777         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3778         (testBackForwardListNavigation):
3779         (testWebKitWebViewSessionState):
3780         (testWebKitWebViewSessionStateWithFormData):
3781         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3782         (ConsoleMessageTest::consoleMessageReceivedCallback):
3783         (testWebKitConsoleMessageConsoleAPI):
3784         (testWebKitConsoleMessageJavaScriptException):
3785         (testWebKitConsoleMessageNetworkError):
3786         (testWebKitConsoleMessageSecurityError):
3787         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3788         (testCookieManagerAcceptPolicy):
3789         (testCookieManagerCookiesChanged):
3790         (testCookieManagerPersistentStorage):
3791         (testCookieManagerPersistentStorageDeleteAll):
3792         (testCookieManagerEphemeral):
3793         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3794         (testWebKitDOMElementAutoFill):
3795         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3796         (downloadLocalFileSuccessfully):
3797         (createFileAtDestination):
3798         (testDownloadOverwriteDestinationDisallowed):
3799         (testDownloadLocalFileError):
3800         (testDownloadRemoteFile):
3801         (testDownloadRemoteFileError):
3802         (testWebViewDownloadURI):
3803         (testPolicyResponseDownload):
3804         (testPolicyResponseDownloadCancel):
3805         (testDownloadMIMEType):
3806         (contextMenuCallback):
3807         (testContextMenuDownloadActions):
3808         (testBlobDownload):
3809         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3810         (testWebKitWebEditorSelectionChanged):
3811         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3812         (testWebKitFrameMainFrame):
3813         (testWebKitFrameURI):
3814         (testWebKitFrameJavaScriptContext):
3815         (testWebKitFrameJavaScriptValues):
3816         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3817         (LoadStopTrackingTest::loadFailed):
3818         (testWebViewTitle):
3819         (testURIRequestHTTPHeaders):
3820         (testURIRequestHTTPMethod):
3821         (testURIResponseHTTPHeaders):
3822         (testRedirectToDataURI):
3823         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3824         (testProcessPerWebView):
3825         (testWebProcessLimit):
3826         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3827         (testWebViewResources):
3828         (testWebResourceLoading):
3829         (testWebResourceSuggestedFilename):
3830         (testWebResourceGetData):
3831         (testWebResourceGetDataError):
3832         (testWebViewResourcesHistoryCache):
3833         (testWebResourceSendRequest):
3834         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3835         (testSSL):
3836         (testInsecureContent):
3837         (testTLSErrorsPolicy):
3838         (testTLSErrorsRedirect):
3839         (testTLSErrorsHTTPAuth):
3840         (testLoadFailedWithTLSErrors):
3841         (testSubresourceLoadFailedWithTLSErrors):
3842         (httpsServerCallback):
3843         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3844         (testWebViewCreateNavigationData):
3845         (testWebViewJavaScriptDialogs):
3846         (testWebViewWindowProperties):
3847         (testWebViewMouseTarget):
3848         (testWebViewFileChooserRequest):
3849         (testWebViewColorChooserRequest):
3850         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3851         (testWebExtensionGetTitle):
3852         (testDocumentLoadedSignal):
3853         (testWebKitWebViewProcessCrashed):
3854         (testWebExtensionWindowObjectCleared):
3855         (testWebExtensionIsolatedWorld):
3856         (permissionRequestCallback):
3857         (didAssociateFormControlsCallback):
3858         (testWebExtensionFormControlsAssociated):
3859         (FormSubmissionTest::FormSubmissionTest):
3860         (FormSubmissionTest::testFormSubmissionResult):
3861         (testWebExtensionFormSubmissionSteps):
3862         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3863         (testNotInitialized):
3864         (testClearDatabase):
3865         (testPrivateBrowsing):
3866         (testGetFavicon):
3867         (testWebViewFavicon):
3868         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3869         (testFindControllerTextFound):
3870         (testFindControllerTextNotFound):
3871         (testFindControllerMatchCount):
3872         (testFindControllerMaxMatchCount):
3873         (testFindControllerNext):
3874         (testFindControllerPrevious):
3875         (testFindControllerCountedMatches):
3876         (testFindControllerOptions):
3877         (testFindControllerHide):
3878         (testFindControllerInstance):
3879         (testFindControllerGetters):
3880         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3881         (testNavigationPolicy):
3882         (testResponsePolicy):
3883         (testNewWindowPolicy):
3884         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3885         (testSecurityOriginBasicConstructor):
3886         (testSecurityOriginURIConstructor):
3887         (testSecurityOriginDefaultPort):
3888         (testSecurityOriginFileURI):
3889         (testOpaqueSecurityOrigin):
3890         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3891         (testWebKitSettings):
3892         (testWebKitSettingsNewWithSettings):
3893         (testWebKitSettingsUserAgent):
3894         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3895         (testWebViewNewWithUserContentManager):
3896         (isStyleSheetInjectedForURLAtPath):
3897         (isScriptInjectedForURLAtPath):
3898         (testUserContentManagerInjectedStyleSheet):
3899         (testUserContentManagerInjectedScript):
3900         (UserScriptMessageTest::scriptMessageReceived):
3901         (UserScriptMessageTest::waitUntilMessageReceived):
3902         (UserScriptMessageTest::runJavaScriptFinished):
3903         (testUserContentManagerScriptMessageReceived):
3904         (testUserContentManagerScriptMessageInWorldReceived):
3905         (testUserContentManagerScriptMessageFromDOMBindings):
3906         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3907         (testWebContextDefault):
3908         (testWebContextEphemeral):
3909         (testWebContextGetPlugins):
3910         (testWebContextURIScheme):
3911         (testWebContextSpellChecker):
3912         (testWebContextLanguages):
3913         (consoleMessageReceivedCallback):
3914         (testWebContextSecurityFileXHR):
3915         (ProxyTest::ProxyTest):
3916         (testWebContextProxySettings):
3917         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3918         (testWebViewWebContext):
3919         (testWebViewWebBackend):
3920         (testWebViewEphemeral):
3921         (testWebViewCustomCharset):
3922         (testWebViewSettings):
3923         (testWebViewRunJavaScript):
3924         (testWebViewCanShowMIMEType):
3925         (testWebViewSubmitForm):
3926         (testWebViewSave):
3927         (testWebViewPageVisibility):
3928         (testWebViewSnapshot):
3929         (testWebViewNotification):
3930         (testWebViewNotificationInitialPermissionAllowed):
3931         (testWebViewNotificationInitialPermissionDisallowed):
3932         (testWebViewIsPlayingAudio):
3933         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3934         (WebsiteDataTest::WebsiteDataTest):
3935         (WebsiteDataTest::remove):
3936         (WebsiteDataTest::clear):
3937         (testWebsiteDataConfiguration):
3938         (testWebsiteDataEphemeral):
3939         (testWebsiteDataCache):
3940         (testWebsiteDataStorage):
3941         (testWebsiteDataDatabases):
3942         (testWebsiteDataAppcache):
3943         (testWebsiteDataCookies):
3944         (testWebsiteDataDeviceIdHashSalt):
3945         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3946         (emitDocumentLoaded):
3947         (emitURIChanged):
3948         (sendRequestCallback):
3949         (contextMenuCallback):
3950         (consoleMessageSentCallback):
3951         (emitFormControlsAssociated):
3952         (formControlsAssociatedCallback):
3953         (emitFormSubmissionEvent):
3954         (willSubmitFormCallback):
3955         (windowObjectCleared):
3956         (methodCallCallback):
3957         (registerGResource):
3958         (webkit_web_extension_initialize_with_user_data):
3959         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3960         (checkLeaks):
3961         (WebProcessTest::create):
3962         (runTest):
3963         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3964         (AutocleanupsTest::testWebProcessAutocleanups):
3965         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3966         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3967         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3968         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3969         (WebKitDOMDOMWindowTest::testSignals):
3970         (WebKitDOMDOMWindowTest::testDispatchEvent):
3971         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3972         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3973         (WebKitDOMNodeFilterTest::testTreeWalker):
3974         (WebKitDOMNodeFilterTest::testNodeIterator):
3975         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3976         (WebKitDOMNodeTest::testHierarchyNavigation):
3977         (WebKitDOMNodeTest::testInsertion):
3978         (WebKitDOMNodeTest::testTagNamesNodeList):
3979         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3980         (WebKitDOMNodeTest::testDOMCache):
3981         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3982         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3983         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3984         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3985         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3986         (testUIProcessAutocleanups):
3987         (testWebProcessAutocleanups):
3988         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3989         (testContextMenuPopulateMenu):
3990         (testContextMenuDismissed):
3991         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3992         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3993         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3994         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3995         (testWebKitDOMDOMWindowSignals):
3996         (testWebKitDOMDOMWindowDispatchEvent):
3997         (testWebKitDOMDOMWindowGetComputedStyle):
3998         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3999         (testWebKitDOMNodeHierarchyNavigation):
4000         (testWebKitDOMNodeInsertion):
4001         (testWebKitDOMNodeTagNamesNodeList):
4002         (testWebKitDOMNodeTagNamesHTMLCollection):
4003         (testWebKitDOMObjectCache):
4004         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4005         (testWebKitDOMNodeFilterTreeWalker):
4006         (testWebKitDOMNodeFilterNodeIterator):
4007         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4008         (testWebKitDOMXPathNSResolverNative):
4009         (testWebKitDOMXPathNSResolverCustom):
4010         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4011         (testInspectorDefault):
4012         (testInspectorManualAttachDetach):
4013         (testInspectorCustomContainerDestroyed):
4014         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4015         (startTestServer):
4016         (testInspectorServerPageList):
4017         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4018         (OptionMenuTest::showOptionMenuCallback):
4019         (OptionMenuTest::menuCloseCallback):
4020         (OptionMenuTest::close):
4021         (OptionMenuTest::activateItem):
4022         (OptionMenuTest::selectItem):
4023         (testOptionMenuSimple):
4024         (testOptionMenuGroups):
4025         (testOptionMenuActivate):
4026         (testOptionMenuSelect):
4027         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4028         (testPrintOperationPrintSettings):
4029         (webViewPrintCallback):
4030         (testPrintOperationPrint):
4031         (testPrintCustomWidget):
4032         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4033         (checkAtspiAccessible):
4034         (testAtspiBasicHierarchy):
4035         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4036         (testWebKitCheckVersion):
4037         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4038         (testWebViewEditorCutCopyPasteNonEditable):
4039         (testWebViewEditorCutCopyPasteEditable):
4040         (testWebViewEditorSelectAllNonEditable):
4041         (testWebViewEditorSelectAllEditable):
4042         (loadContentsAndTryToCutSelection):
4043         (testWebViewEditorNonEditable):
4044         (testWebViewEditorEditable):
4045         (testWebViewEditorEditorStateTypingAttributes):
4046         (testWebViewEditorInsertImage):
4047         (testWebViewEditorCreateLink):
4048         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4049         (loadChangedCallback):
4050         (loadFailedCallback):
4051         (loadFailedWithTLSErrorsCallback):
4052         (LoadTrackingTest::LoadTrackingTest):
4053         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4054         (registerGResource):
4055         (removeNonEmptyDirectory):
4056         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4057         (Test::adoptView):
4058         (Test::~Test):
4059         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4060         (WebKitTestBus::getOrCreateConnection):
4061         (WebKitTestBus::createProxy):
4062         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4063         (WebKitTestServer::getWebSocketURIForPath const):
4064         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4065         (WebViewTest::initializeWebView):
4066         (WebViewTest::loadURI):
4067         (WebViewTest::loadHtml):
4068         (WebViewTest::loadPlainText):
4069         (WebViewTest::loadBytes):
4070         (WebViewTest::loadRequest):
4071         (WebViewTest::loadAlternateHTML):
4072         (WebViewTest::goBack):
4073         (WebViewTest::goForward):
4074         (WebViewTest::goToBackForwardListItem):
4075         (resourceGetDataCallback):
4076         (WebViewTest::mainResourceData):
4077         (WebViewTest::javascriptResultToCString):
4078         (WebViewTest::javascriptResultToNumber):
4079         (WebViewTest::javascriptResultToBoolean):
4080         (WebViewTest::javascriptResultIsNull):
4081         (WebViewTest::javascriptResultIsUndefined):
4082         (onSnapshotReady):
4083         (WebViewTest::runWebProcessTest):
4084         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4085         (WebViewTest::platformInitializeWebView):
4086         (WebViewTest::showInWindow):
4087         (WebViewTest::showInWindowAndWaitUntilMapped):
4088         (WebViewTest::mouseMoveTo):
4089         (WebViewTest::emitPopupMenuSignal):
4090         (WebViewTest::keyStroke):
4091         (WebViewTest::doMouseButtonEvent):
4092
4093 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4094
4095         [WPE] API tests can't run in flatpak environment
4096         https://bugs.webkit.org/show_bug.cgi?id=193242
4097
4098         Reviewed by Michael Catanzaro.
4099
4100         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4101         flatpakutils so that it knows which port it's dealing with.
4102         * glib/common.py: Remove build_dir globals so that subsequent
4103         calls actually take args into account.
4104         (library_build_path):
4105         (binary_build_path):
4106
4107 2019-01-08  Dean Jackson  <dino@apple.com>
4108
4109         Blob references for System Previews don't get a correct file extension
4110         https://bugs.webkit.org/show_bug.cgi?id=193268
4111         <rdar://problem/47133037>
4112
4113         Reviewed by Tim Horton.
4114
4115         New test that a Blob download of a USDZ file gets named correctly.
4116
4117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4118         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4119         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4120         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4121         (TEST):
4122         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4123
4124 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4125
4126         [WebAuthN] Support U2F HID Authenticators on macOS
4127         https://bugs.webkit.org/show_bug.cgi?id=191535
4128         <rdar://problem/47102027>
4129
4130         Reviewed by Brent Fulgham.
4131
4132         This patch:
4133         1) adds support for U2F mocking mechanism;
4134         2) updates tests to reflect U2fCommandConstructor changes.
4135
4136         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4137         (TestWebKitAPI::TEST):
4138         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4139         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4140         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4141
4142 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4143
4144         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4145         https://bugs.webkit.org/show_bug.cgi?id=193229
4146         <rdar://problem/46717097>
4147
4148         Reviewed by Tim Horton.
4149
4150         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4151         prevents a drag from starting.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4154         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4155
4156         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4157
4158 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4159   
4160         Layout test will generate a perf metric file to results dir.
4161         https://bugs.webkit.org/show_bug.cgi?id=192030
4162         <rdar://problem/32779516>
4163
4164         Reviewed by Aakash Jain.
4165
4166         Layout test running time will be collected to a perf metric file.
4167         For now, instead of outputing running time of all tests (which is huge),
4168         we aggregate them by test directories which are at most two level deep. 
4169
4170         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4171         (Manager._end_test_run):
4172         (Manager._output_perf_metrics):
4173         (Manager._print_expectation_line_for_test):
4174         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4175         (add_test_perf_metric):
4176         (test_perf_metrics):
4177         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4178         (JSONGeneratorTest.test_test_timings_trie):
4179         (JSONGeneratorTest):
4180         (JSONGeneratorTest.test_test_perf_metrics):
4181         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4182         (RebaselineTest.test_reset_results):
4183         (RebaselineTest.test_missing_results):
4184         (RebaselineTest.test_new_baseline):
4185
4186 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
4187
4188         [WPE][GTK] Add php-json to install-dependencies
4189         https://bugs.webkit.org/show_bug.cgi?id=193233
4190
4191         Reviewed by Michael Catanzaro.
4192
4193         * gtk/install-dependencies:
4194         * wpe/install-dependencies:
4195
4196 2019-01-08  Chris Dumez  <cdumez@apple.com>
4197
4198         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4199         https://bugs.webkit.org/show_bug.cgi?id=193224
4200         <rdar://problem/47097726>
4201
4202         Reviewed by Alex Christensen.
4203
4204         Add API test coverage.
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4207
4208 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4209
4210         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4211         <https://webkit.org/b/193222>
4212         <rdar://problem/46862309>
4213
4214         Reviewed by Joseph Pecoraro.
4215
4216         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4217         (WTR::executeCallback): Fix camel case of variable name.
4218         (WTR::EventSendingController::callAfterScrollingCompletes): If
4219         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4220         false, make sure to release the ScrollCompletionCallbackData
4221         object.  This fixes the leak.
4222
4223 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4224
4225         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4226         https://bugs.webkit.org/show_bug.cgi?id=193044
4227
4228         Reviewed by Daniel Bates.
4229
4230         WinCairo EWS bots are using Windows Perl. Binary files should be
4231         opened as binary mode.
4232
4233         * Scripts/svn-apply:
4234         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4235
4236 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4237
4238         [CMake] Add ENABLE_CSS_TYPED_OM option
4239         https://bugs.webkit.org/show_bug.cgi?id=193216
4240
4241         Reviewed by Michael Catanzaro.
4242
4243         * Scripts/webkitperl/FeatureList.pm:
4244
4245 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4246
4247         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
4248         <https://webkit.org/b/193056>
4249
4250         Reviewed by Alex Christensen.
4251
4252         * Scripts/webkitpy/style/checker.py:
4253         - Ignore use of new runtime/retainptr check in
4254           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
4255           contains tests to ensure RetainPtr<NSObject *> is compatible
4256           with RetainPtr<NSObject>.
4257
4258         * Scripts/webkitpy/style/checkers/cpp.py:
4259         (check_language):
4260         (CppChecker):
4261         - Add checker for use of '*' in RetainPtr<> type.  A for loop
4262           was used instead of a single regex so that angle brackets
4263           could be matched up when checking the type contained within
4264           the RetainPtr<> type.
4265
4266         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4267         (CppStyleTest):
4268         - Add unit test for new runtime/retainptr check.
4269
4270         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
4271         * TestWebKitAPI/EditingTestHarness.h:
4272         - Remove '*' from RetainPtr<> type.
4273
4274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4275         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
4276           regressed in r201938.
4277
4278         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4279         (TestWebKitAPI::TEST):
4280         - Update tests to match RetainPtr.mm tests (except for the
4281           `*SimilarNSType` tests since there is no CF equivalent of
4282           RetainPtr<NSString> and RetainPtr<NSString *>).
4283
4284         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
4285         (TestWebKitAPI::TEST):
4286         - Update tests to:
4287           - Not conflict by name with equivalent CF tests in
4288             RetainPtr.cpp.
4289           - Add test cases for RetainPtr<NSObject>,
4290             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
4291           - Add `*SimilarNSType` tests for converting between
4292             RetainPtr<NSObject> and RetainPtr<NSObject *>.
4293           - Change `0` to `nil` as appropriate.
4294           - Re-alphabetize the tests by name.
4295           - Add Optional<RetainPtr<>> tests.
4296           - Add retainPtr() tests.
4297
4298         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4299         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4300         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
4301         (TEST):
4302         - Remove '*' from RetainPtr<> type.
4303
4304         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
4305         (TEST(WebKit, JITEnabled)):
4306         - Add missing WTFMove().  Apparently a temporary was being
4307           created before in the argument list due to mismatched
4308           RetainPtr<> types.
4309
4310         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4311         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
4312         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
4313         (TestWebKitAPI::TEST):
4314         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4315         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4316         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4317         (WTR::resourcesDirectoryURL):
4318         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4319         (WTR::InjectedBundle::platformInitialize):
4320         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4321         - Remove '*' from RetainPtr<> type.
4322