Fix more latched scrolling test flakiness and slowness
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2
3         Fix more latched scrolling test flakiness and slowness
4         https://bugs.webkit.org/show_bug.cgi?id=133601
5
6         Reviewed by Brent Fulgham.
7         
8         Latched scrolling tests were flakey for two reasons. First, the EventSender
9         wheel events were async from the web to the UI process, and the resulting
10         synthetic events also async from the UI to the web process. Make them sync
11         for testing.
12         
13         Secondly, the timer-based scrolling tree commit could result in the scrolling
14         tree (specifically the frame node's notion of the scrollable area and content
15         size) not being updated before the scrolling thread starts getting wheel events.
16         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
17         
18         Finally remove all the now-unnecessary timeouts from the tests.
19
20         * WebKitTestRunner/mac/EventSenderProxy.mm:
21         (WTR::EventSenderProxy::mouseMoveTo):
22         (WTR::EventSenderProxy::mouseScrollBy):
23         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
24
25 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
26
27         [EFL] Add parameter to MiniBrowser to disable web security
28         https://bugs.webkit.org/show_bug.cgi?id=121095
29
30         Reviewed by Gyuyoung Kim.
31
32         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
33         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
34         resources from other domains (cross-domain requests) such as access map location on another server.
35         Another possibility is to launch in a webkit browser local file tests that will refer to the links
36         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
37
38         * MiniBrowser/efl/main.c:
39         (window_create):
40         (elm_main):
41
42 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
43
44         32-bit build fix.
45
46         * WebKitTestRunner/mac/EventSenderProxy.mm:
47         (WTR::EventSenderProxy::mouseMoveTo):
48         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
49
50 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
51
52         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
53
54         * DumpRenderTree/mac/DumpRenderTree.mm:
55         (createWebViewAndOffscreenWindow):
56         * DumpRenderTree/mac/EventSendingController.mm:
57         (-[EventSendingController mouseScrollByX:andY:continuously:]):
58         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
59         * WebKitTestRunner/mac/EventSenderProxy.mm:
60         (WTR::EventSenderProxy::mouseScrollBy):
61         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
62
63 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
64
65         Latched scrolling tests are flakey on Mavericks
66         https://bugs.webkit.org/show_bug.cgi?id=133578
67         <rdar://problem/17180591>
68
69         Reviewed by Brent Fulgham.
70         
71         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
72         be wrong on machines with more than one screen. This is because we use
73         [NSScreen mainScreen] when computing the global coordinates of the events, but
74         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
75         
76         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
77         add comments clarifying why the coordinate math works (which is not obvious given
78         the events have no target window).
79         
80         Some scrolling tests also dispatched events outside the 800x600 test window, so
81         fix those tests, and add logging that will appear in test output when this happens.
82
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (createWebViewAndOffscreenWindow):
85         * DumpRenderTree/mac/EventSendingController.mm:
86         (-[EventSendingController mouseScrollByX:andY:continuously:]):
87         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
88         * WebKitTestRunner/mac/EventSenderProxy.mm:
89         (WTR::EventSenderProxy::mouseMoveTo):
90         (WTR::EventSenderProxy::mouseScrollBy):
91         (WTR::EventSenderProxy::continuousMouseScrollBy):
92         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
93
94 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
95
96         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
97         https://bugs.webkit.org/show_bug.cgi?id=133533
98
99         Reviewed by Carlos Garcia Campos.
100
101         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
102         (run): Remove the jhbuild-wrapper wrapper from here. It should be
103         on Scripts/webkitpy/port/gtk.py.
104         * Scripts/webkitpy/port/base.py:
105         (Port.set_option): Add a set_option(name, value) function to set
106         the optparse parameter "name" to the value "value", even if the
107         parameter "name" is already initialized.
108         * Scripts/webkitpy/port/gtk.py:
109         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
110         If another wrapper is specified via the option "-l --wrapper=x",
111         then prepend the jhbuild-wrapper to the one specified.
112
113 2014-06-04  David Farler  <dfarler@apple.com>
114
115         Build ASan WebKit for iOS Simulator
116         https://bugs.webkit.org/show_bug.cgi?id=133489
117
118         Reviewed by Darin Adler.
119
120         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
121         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
122         - Add missing ASan LDFLAGS.
123         * asan/asan.xcconfig:
124         - Split compiler-rt linker flags for OS X and iOS Simulator
125
126 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
127
128         Add myself (yoav@yoav.ws) to contributors.json
129         https://bugs.webkit.org/show_bug.cgi?id=133492
130
131         * Scripts/webkitpy/common/config/contributors.json:
132
133 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
134
135         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
136         https://bugs.webkit.org/show_bug.cgi?id=133149
137
138         Reviewed by Csaba Osztrogonác.
139
140         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
141
142 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
143
144         Add a verbose flag to binding tests
145         https://bugs.webkit.org/show_bug.cgi?id=122303
146
147         Reviewed by Csaba Osztrogonác.
148
149         This patch will:
150         - Add a verbose keyword argument to the BindingsTests constructor,
151         - Add --no-verbose option to the run-bindigs-test.
152         Verbose mode, which is on by default, prints positive results to stdout as before.
153         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
154
155         Original patch from Matthew Hanson <matthew_hanson@apple.com>
156
157         * Scripts/run-bindings-tests:
158         (main):
159         * Scripts/webkitpy/bindings/main.py:
160         (BindingsTests.__init__):
161         (BindingsTests.detect_changes):
162
163 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
164
165         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
166         https://bugs.webkit.org/show_bug.cgi?id=133455
167
168         Reviewed by Timothy Hatcher.
169
170         Since the perf. dashboard doesn't support following renamed benchmarks,
171         keep reporting Speedometer results as DoYouEvenBench results.
172
173         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
174         (_generate_results_dict):
175
176 2014-05-31  Darin Adler  <darin@apple.com>
177
178         Viewport percentage tests that resize the viewport are flaky
179         https://bugs.webkit.org/show_bug.cgi?id=133351
180
181         Reviewed by Anders Carlsson.
182
183         * DumpRenderTree/mac/DumpRenderTree.mm:
184         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
185         happens to be stored in the UI delegate object. This is part of resetting the
186         window position.
187
188         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
189         a frame rectangle. The size is stored in the size of the web view itself.
190         * DumpRenderTree/mac/UIDelegate.mm:
191         (-[UIDelegate resetWindowOrigin]): Added.
192         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
193         old version would store the frame, but not resize the web view!
194         (-[UIDelegate webViewFrame:]): Get the size from the web view.
195
196         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
197         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
198
199         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
200         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
201         the window.
202
203         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
204         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
205         window gets resized too, not just the web view.
206         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
207
208         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
209         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
210         window gets resized too, not just the web view.
211         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
212
213 2014-05-30  Michael Saboff  <msaboff@apple.com>
214
215         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
216         https://bugs.webkit.org/show_bug.cgi?id=133409
217
218         Reviewed by Filip Pizlo.
219
220         Handle creating a tarball the same way as running remote when processing
221         paths in prepareBundle.
222
223         * Scripts/run-jsc-stress-tests:
224
225 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
226
227         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
228         https://bugs.webkit.org/show_bug.cgi?id=132280
229
230         Reviewed by Chris Fleizach.
231
232         Remove implementation of logAccessibilityEvents() for ATK based
233         ports, as this has proved to be a flaky method of checking that
234         ATK events are being properly emitted. Instead, it's better to use
235         the addNotificationListener() functions and provide a JS callback
236         to check that the right events are being emmitted from the tests.
237
238         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
239         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
240         with dummy implementation.
241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
242         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
243
244 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
245
246         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
247         https://bugs.webkit.org/show_bug.cgi?id=132280
248
249         Rubber stamped by Carlos Garcia Campos.
250
251         Fix two small issues with previous patch (r169483), that caused some tests to break.
252
253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
254         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
255         duplicated entry.
256         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
257         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
258
259 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
260
261         [ATK] Added new accessibility signal: text-caret-moved.
262         Make AccessibilityUIElement.setSelectedTextRange work
263         as atk_text_set_caret_offset when given offset == 0.
264         https://bugs.webkit.org/show_bug.cgi?id=132527
265
266         Reviewed by Mario Sanchez Prada.
267
268         text-caret-moved signal in accessibilityController is needed to
269         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
270         as LayoutTests. Add the signal to the controller.
271
272         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
273         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
274         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
275         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
276         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
277         (setSelectedTextRange): Change return type to bool.
278         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
279         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
281         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
282         for extra arguments passed to handler and use it for text-caret-moved offset.
283         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
284         Connect callback to new listener for ATK:AtkText:text-caret-moved.
285         Refactor so that failures be reported.
286         Initialize atk interfaces before trying to connect to them, see
287         https://bugzilla.gnome.org/show_bug.cgi?id=729922
288         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
289         Simplify code by using a vector in place of dozen variables.
290         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
291         Comment about not synchronizing with accessibilityController.
292
293 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
294
295         [GTK] Add a WebKit2 Performance bot.
296         https://bugs.webkit.org/show_bug.cgi?id=132862
297
298         Reviewed by Csaba Osztrogonác.
299
300         This adds a GTK WebKit2 perf bot.
301
302         * BuildSlaveSupport/build.webkit.org-config/config.json:
303
304 2014-05-29  Dan Bernstein  <mitz@apple.com>
305
306         Fixed the WebKitTestRunner build after r169452.
307
308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
309         (WTR::InjectedBundle::initialize):
310
311 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
312
313         Unreviewed. Update my email addresses in contributors.json.
314
315         * Scripts/webkitpy/common/config/contributors.json:
316
317 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
318
319         Need an API test for bug #133193 (r169315)
320         <https://bugs.webkit.org/show_bug.cgi?id=133324>
321
322         This adds an API test that ensures that calling "stop loading" during a
323         "did fail provisional load" callback doesn't crash.
324
325         Reviewed by Andy Estes.
326
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         Add new files to project.
329
330         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
331         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
332         If the message is the "test done" message, record that.
333         (TestWebKitAPI::setInjectedBundleClient):
334         Register a function for the "did receive message from injected bundle"
335         callback.
336         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
337         Assert that we received the message from the injected bundle, and set
338         'done' to finish the test.
339         (TestWebKitAPI::TEST):
340         Create a WebView, register a page loader client for the "did fail
341         provisional load" callback, and load a non-existent resource.
342
343         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
344         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
345         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
346         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
347         provisional load failed.
348         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
349         Register a page loader client for the "did fail provisional load"
350         callback.
351         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
352         Call WKBundlePageStopLoading() during the callback. This not crashing
353         is what we're ensuring with this test.
354
355 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
356
357         [GTK] Make it possible to build with FTL enabled
358         https://bugs.webkit.org/show_bug.cgi?id=133219
359
360         Reviewed by Philippe Normand.
361
362         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
363         same revision than mac.
364
365 2014-05-27  Michael Saboff  <msaboff@apple.com>
366
367         REGRESSION(r169265): sh: line 0: cd: ../.vm
368         https://bugs.webkit.org/show_bug.cgi?id=133242
369
370         Rubber stamped by Oliver Hunt.
371
372         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
373         array since the command may contain character escapes that don't work with the
374         array form of system().
375
376         * Scripts/run-jsc-stress-tests:
377
378 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
379
380         [EFL] Change download url of freetype6
381         https://bugs.webkit.org/show_bug.cgi?id=133303
382
383         Reviewed by Csaba Osztrogonác.
384
385         freetype6 tarball isn't downloaded in Korea. So, we need to
386         change the url for now.
387
388         * efl/jhbuild.modules:
389
390 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
391
392         Remove BLOB guards
393         https://bugs.webkit.org/show_bug.cgi?id=132863
394
395         Reviewed by Csaba Osztrogonác.
396
397         * Scripts/webkitperl/FeatureList.pm:
398
399 2014-05-27  Alberto Garcia  <berto@igalia.com>
400
401         Remove leftover comment from r165182.
402
403         Rubber stamped by Carlos Garcia Campos.
404
405         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
406
407 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
408
409         [EFL] Add LLVM as optional jhbuild module for FTL developers
410         https://bugs.webkit.org/show_bug.cgi?id=133216
411
412         Reviewed by Gyuyoung Kim.
413
414         * efl/jhbuild.modules:
415
416 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
417
418         Fix test failures on python test
419         https://bugs.webkit.org/show_bug.cgi?id=133297
420
421         Reviewed by Dirk Schulze.
422
423         2 tests are failing because of unbounded local variable reference in test_importer.py.
424
425         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
426         (TestImporter.import_tests):
427
428 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
429
430         [GTK] GObject DOM bindings API break test fails in the tests bots
431         https://bugs.webkit.org/show_bug.cgi?id=133211
432
433         Reviewed by Martin Robinson.
434
435         When generating the built product archive on platform GTK, we need
436         to copy also the file gtkdoc-webkitdom.cfg and the directory
437         DerivedSources/webkitdom.
438
439         * BuildSlaveSupport/built-product-archive:
440         (archiveBuiltProduct):
441
442 2014-05-26  Commit Queue  <commit-queue@webkit.org>
443
444         Unreviewed, rolling out r169122.
445         https://bugs.webkit.org/show_bug.cgi?id=133288
446
447         Broke CJK font fallback (Requested by ap on #webkit).
448
449         Reverted changeset:
450
451         "[Mac] WebProcess doesn't follow localization of UI process
452         when run as a service"
453         https://bugs.webkit.org/show_bug.cgi?id=133126
454         http://trac.webkit.org/changeset/169122
455
456 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
457
458         [GTK] WebProcess leaked when closing pages with network process enabled
459         https://bugs.webkit.org/show_bug.cgi?id=129684
460
461         Reviewed by Anders Carlsson.
462
463         Enable the test to check that web processes finish when the web
464         view is destroyed.
465
466         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
467
468 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
469
470         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
471         https://bugs.webkit.org/show_bug.cgi?id=133279
472
473         Reviewed by Philippe Normand.
474
475         generator.saw_warnings is only set by GTKDoc::generate(), so it
476         should only be used after generate.
477
478         * gtk/generate-gtkdoc:
479         (generate_documentation_for_config): Do not check
480         generator.saw_warnings again, simply return the value returned by
481         generate_doc() which is generator.saw_warnings. When rebasing,
482         returns always False since there aren't warnings.
483
484 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
485
486         W3C test importer should catch exceptions coming from HTML/CSS conversion
487         https://bugs.webkit.org/show_bug.cgi?id=133176
488
489         Reviewed by Darin Adler.
490
491         Exceptions raised when converting HTML/CSS are caught.
492         Files for which conversion failed are still copied to the target directory.
493         Each individual conversion failure is logged.
494         Total conversion failure number is logged at the end of the import process.
495
496         * Scripts/webkitpy/w3c/test_importer.py:
497         (TestImporter.import_tests):
498
499 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
500
501         [GTK] Allow to run the tests on the native X display.
502         https://bugs.webkit.org/show_bug.cgi?id=133157
503
504         Reviewed by Benjamin Poulain.
505
506         This adds a new driver (xorgdriver) that runs the tests on the
507         X display referenced by the environment variable DISPLAY.
508
509         This new driver will be activated only if the environment variable
510         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
511         tests and performance tests.
512
513         This patch also makes the script run-perf-tests to check the
514         system dependencies before starting the tests. Previously this
515         was not checked, and if the system dependencies were not met,
516         the script tried to execute the tests anyway, causing massive
517         failures. For example, if you had Xvfb not installed and you
518         wanted to use the Xvfb driver (the default on GTK and EFL),
519         run-perf-tests would not abort.
520
521         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
522         (PerfTestsRunner._parse_args): Check the system dependencies of
523         the driver before starting the tests.
524         * Scripts/webkitpy/port/driver.py:
525         (Driver): Implement generic check_driver method.
526         (Driver.check_driver):
527         (Driver.check_driver.implementation):
528         * Scripts/webkitpy/port/gtk.py:
529         (GtkPort._driver_class): Check for environment variable
530         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
531         * Scripts/webkitpy/port/xorgdriver.py: Added.
532         (XorgDriver): Implement Xorg driver.
533         (XorgDriver.check_driver):
534         (XorgDriver._start):
535
536 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
537
538         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
539         https://bugs.webkit.org/show_bug.cgi?id=133215
540
541         Reviewed by Csaba Osztrogonác.
542
543         This reverts r166798.
544
545         * BuildSlaveSupport/kill-old-processes:
546         (main):
547
548 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
549
550         [EFL] Turn on ENABLE_CSS_FILTERS in build script
551         https://bugs.webkit.org/show_bug.cgi?id=133278
552
553         Reviewed by Gyuyoung Kim.
554
555         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
556
557 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
558
559         run-javascriptcore-tests warning fix on non Mac platforms
560         https://bugs.webkit.org/show_bug.cgi?id=133260
561
562         Reviewed by Darin Adler.
563
564         * Scripts/webkitdirs.pm:
565         (argumentsForConfiguration):
566
567 2014-05-23  Michael Saboff  <msaboff@apple.com>
568
569         REGRESSION(r169265): sh: line 0: cd: ../.vm
570         https://bugs.webkit.org/show_bug.cgi?id=133242
571
572         Rubber stamped by Geoffrey Garen.
573
574         Added missing shell escapes '\' required as part of previous fix.
575
576         * Scripts/run-jsc-stress-tests:
577
578 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
579
580         Revert the erroneous change committed in r169286.
581
582         * Scripts/webkitpy/performance_tests/perftest.py:
583         (PerfTest._run_with_driver):
584
585 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
586
587         run-perf-tests should ignore whitespace lines when snarfing test output
588         https://bugs.webkit.org/show_bug.cgi?id=133238
589
590         Reviewed by Ryosuke Niwa.
591
592         Required for PerformanceTests/Canvas/terrain.html.
593
594         * Scripts/webkitpy/performance_tests/perftest.py:
595         (PerfTest._run_with_driver):
596         (PerfTest):
597
598 2014-05-23  Michael Saboff  <msaboff@apple.com>
599
600         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
601         https://bugs.webkit.org/show_bug.cgi?id=133223
602
603         Reviewed by Geoffrey Garen.
604
605         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
606         string before calling IO.popen() to work with older versions of ruby.
607         Changed the remote path in runShellTestRunner to quote the command
608         string we want to run via ssh so that it will work correctly with array
609         to string conversion needed for popen.
610
611         * Scripts/run-jsc-stress-tests:
612
613 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
614
615         Remove 'css-shaders' option from the build-webkit
616         https://bugs.webkit.org/show_bug.cgi?id=133212
617
618         Reviewed by Daniel Bates.
619
620         Original CSS shaders removed in r162644.
621
622         * Scripts/webkitperl/FeatureList.pm:
623
624 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
625
626         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
627         https://bugs.webkit.org/show_bug.cgi?id=133209
628
629         Reviewed by Sergio Villar Senin.
630
631         Return FAILURE when the command failed to run.
632
633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
634         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
635
636 2014-05-23  Alberto Garcia  <berto@igalia.com>
637
638         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
639         https://bugs.webkit.org/show_bug.cgi?id=133210
640
641         Reviewed by Carlos Garcia Campos.
642
643         * gtk/install-dependencies:
644
645 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
646
647         Add Yusuke Suzuki to the list of contributors (for real)
648
649         Wrong section...
650
651         * Scripts/webkitpy/common/config/contributors.json:
652
653 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
654
655         Add Yusuke Suzuki to the list of contributors
656
657         * Scripts/webkitpy/common/config/contributors.json:
658
659 2014-05-22  Michael Saboff  <msaboff@apple.com>
660
661         Eliminate n/total progress update from run-jsc-stress-tests output to file
662         https://bugs.webkit.org/show_bug.cgi?id=133191
663
664         Reviewed by Geoffrey Garen.
665
666         Changed progressMeter setting to be based on stdout being a tty instead of
667         stdin.  Unified the processing of output from the shell runner to match the
668         same processing as is used by the makefile runner.  As part of this, the 
669         shell runner script was simplified.  It now forwards the output of each
670         test_script just like the Makefile and doesn't provide its own progress.
671
672         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
673         * Scripts/run-jsc-stress-tests:
674
675 2014-05-22  Michael Saboff  <msaboff@apple.com>
676
677         Add option to run-jsc-stress-tests to use installed jsc
678         https://bugs.webkit.org/show_bug.cgi?id=133102
679
680         Reviewed by Geoffrey Garen.
681
682         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
683         provied with the --jsc option.
684
685         * Scripts/run-jsc-stress-tests:
686
687 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
688
689         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
690         https://bugs.webkit.org/show_bug.cgi?id=132907
691
692         Reviewed by Gyuyoung Kim.
693
694         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
695         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
696
697         * efl/install-dependencies:
698
699 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
700
701         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
702         https://bugs.webkit.org/show_bug.cgi?id=133145
703
704         Reviewed by Csaba Osztrogonác.
705
706         * Scripts/run-jsc-stress-tests:
707
708 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
709
710         [Mac] WebProcess doesn't follow localization of UI process when run as a service
711         https://bugs.webkit.org/show_bug.cgi?id=133126
712         <rdar://problem/13396515>
713         <rdar://problem/16561084>
714
715         Reviewed by Sam Weinig and Tim Horton.
716
717         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
718         (WTR::InjectedBundle::platformInitialize): It was too late to override language
719         here, and it's not necessary any more. Keeping the code for older OS versions in
720         case it did have effect in some code paths.
721
722 2014-05-19  David Farler  <dfarler@apple.com>
723
724         Move WebKitTestRunner to std::unique_ptr
725         https://bugs.webkit.org/show_bug.cgi?id=133081
726
727         Reviewed by Daniel Bates.
728
729         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
730         (WTR::InjectedBundle::didCreatePage):
731         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
732         * WebKitTestRunner/TestController.cpp:
733         (WTR::TestController::initialize):
734         (WTR::TestController::createWebViewWithOptions):
735         (WTR::TestController::resetStateToConsistentValues):
736         (WTR::TestController::runTest):
737         * WebKitTestRunner/TestController.h:
738         * WebKitTestRunner/TestInvocation.cpp:
739         * WebKitTestRunner/TestInvocation.h:
740         * WebKitTestRunner/WorkQueueManager.cpp:
741         (WTR::WorkQueueManager::processWorkQueue):
742         (WTR::WorkQueueManager::enqueue):
743         * WebKitTestRunner/WorkQueueManager.h:
744
745 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
746
747         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
748         https://bugs.webkit.org/show_bug.cgi?id=133119
749
750         Reviewed by Sergio Villar Senin.
751
752         Check that redirect response parameter of
753         WebKitWebPage::send-request signal is NULL when not redirecting
754         and a valid WebKitURIResponse object when redirecting.
755
756         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
757         (testWebResourceSendRequest):
758         (serverCallback):
759         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
760         (sendRequestCallback):
761
762 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
763
764         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
765         https://bugs.webkit.org/show_bug.cgi?id=133117
766
767         Reviewed by Philippe Normand.
768
769         Bring back missing tests to the build.
770
771         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
772
773 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
774
775         Take care of some ARM64 test failures
776         https://bugs.webkit.org/show_bug.cgi?id=133090
777
778         Reviewed by Geoffrey Garen.
779
780         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
781
782 2014-05-19  David Kilzer  <ddkilzer@apple.com>
783
784         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
785         <http://webkit.org/b/133089>
786
787         Reviewed by Darin Adler.
788
789         * Scripts/webkitdirs.pm:
790         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
791         specified on the command line, we would remove the '--sdk'
792         arguments, but leave '--sim', potentially passing it along to
793         xcodebuild causing a build failure.  This happens when
794         'old-run-webkit-tests --release --sim' invokes
795         build-dumprendertree when DumpRenderTree hasn't been built yet.
796
797 2014-05-19  David Farler  <dfarler@apple.com>
798
799         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
800         https://bugs.webkit.org/show_bug.cgi?id=133086
801
802         Reviewed by Daniel Bates.
803
804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
805
806 2014-05-19  David Kilzer  <ddkilzer@apple.com>
807
808         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
809         <http://webkit.org/b/132954>
810
811         * Scripts/webkitdirs.pm:
812         (sharedCommandLineOptionsUsage): Remove the prototype for the
813         subroutine.  Older perls don't like the "+@" syntax.
814
815 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
816
817         run-javascriptcore-tests should sort the list of failing stress tests
818         https://bugs.webkit.org/show_bug.cgi?id=132989
819
820         Reviewed by Csaba Osztrogonác.
821
822         * Scripts/run-javascriptcore-tests:
823
824 2014-05-19  David Kilzer  <ddkilzer@apple.com>
825
826         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
827         <http://webkit.org/b/132954>
828
829         Reviewed by Darin Adler.
830
831         Extract code into setupMacWebKitEnvironment() for setting up
832         common environment variables so it may be shared.  Sets
833         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
834         using guardmalloc to some scripts.
835
836         Also adds support for parsing shared (common) command-line
837         switches, initially just -g|--guard-malloc.
838
839         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
840         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
841         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
842         local copy of %ENV when launching Safari so we don't have to
843         restore variables.
844
845         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
846         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
847         Check result of GetOptions() to catch invalid command-line
848         switches.
849         (runTest): Use a local copy of %ENV when running tests so we
850         don't have to restore variables.
851         (prepareEnvironmentForRunningTestTool): Call
852         setupMacWebKitEnvironment().
853
854         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
855         using sharedCommandLineOptions() and
856         sharedCommandLineOptionsUsage().  Call
857         setupMacWebKitEnvironment().
858
859         * Scripts/webkitdirs.pm:
860         (sharedCommandLineOptions): Return array of common switches to
861         pass to Getopt::Long::GetOptions().
862         (sharedCommandLineOptionsUsage): Return formatted string of
863         common switches for printing usage help text.
864         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
865         guardmalloc.
866         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
867         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
868         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
869         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
870         local copy of %ENV when launching Safari so we don't have to
871         restore variables.
872         (execMacWebKitAppForDebugging): Call
873         setupMacWebKitEnvironment().
874
875 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
876
877         support for navigator.hardwareConcurrency
878         https://bugs.webkit.org/show_bug.cgi?id=132588
879
880         Reviewed by Filip Pizlo.
881
882         * Scripts/webkitperl/FeatureList.pm:
883
884 2014-05-18  Anders Carlsson  <andersca@apple.com>
885
886         Implement Navigations for all methods declared returning one
887         https://bugs.webkit.org/show_bug.cgi?id=133048
888         <rdar://problem/16830064>
889
890         Reviewed by Sam Weinig.
891
892         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
893         Import WebKit.h.
894         
895         * MiniBrowser/mac/WK2BrowserWindowController.m:
896         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
897         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
898         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
899         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
900         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
901         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
902         Print out the navigations.
903
904 2014-05-17  Zalan Bujtas  <zalan@apple.com>
905
906         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
907         https://bugs.webkit.org/show_bug.cgi?id=133029
908
909         Reviewed by Simon Fraser.
910
911         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
912         toggling it on a WK2 window needs restart.
913         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
914         the WebPreferences just to support this temporary toggle.
915
916         * MiniBrowser/mac/BrowserWindowController.h:
917         * MiniBrowser/mac/MainMenu.xib:
918         * MiniBrowser/mac/WK1BrowserWindowController.m:
919         (-[WK1BrowserWindowController validateMenuItem:]):
920         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
921         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
922         * MiniBrowser/mac/WK2BrowserWindowController.m:
923         (-[WK2BrowserWindowController validateMenuItem:]):
924         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
925         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
926
927 2014-05-17  Anders Carlsson  <andersca@apple.com>
928
929         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
930         https://bugs.webkit.org/show_bug.cgi?id=133033
931         <rdar://problem/16830143>
932
933         Reviewed by Sam Weinig.
934
935         Set up the WebSQL and IndexedDB directories.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::initialize):
939
940 2014-05-16  Martin Hock  <mhock@apple.com>
941
942         MemoryCache::addImageToCache should return the result of add().
943         https://bugs.webkit.org/show_bug.cgi?id=132928
944         <rdar://problem/16651547>
945
946         Reviewed by Alexey Proskuryakov.
947
948         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
951         (TestWebKitAPI::TEST):
952
953 2014-05-15  David Farler  <dfarler@apple.com>
954
955         old-run-webkit-tests: allow specifying a simulator app path
956         https://bugs.webkit.org/show_bug.cgi?id=132975
957
958         Reviewed by Anders Carlsson.
959
960         * Scripts/old-run-webkit-tests:
961         (openIPhoneSimulator):
962         Add new --simulator-app command line parameter for specifying the
963         absolute path to the simulator app to launch before starting a
964         session.
965
966 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
967
968         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
969         https://bugs.webkit.org/show_bug.cgi?id=131363
970
971         Reviewed by Csaba Osztrogonác.
972
973         * Scripts/webkitpy/common/checkout/checkout_mock.py:
974         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
975         (MockBugzilla):
976         * Scripts/webkitpy/tool/commands/download_unittest.py:
977         (test_create_rollout_multiple_revision_with_one_resolved):
978         (test_create_rollout_multiple_resolved):
979         (test_rollout_two_revisions):
980         (test_rollout_multiple_revisions):
981         (test_rollout_multiple_revisions_with_a_missing_bug_id):
982         * Scripts/webkitpy/tool/steps/createbug.py:
983         (CreateBug.run):
984         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
985         (ReopenBugAfterRollout.run):
986
987 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
988
989         [WK2] Change the remaining framework includes from WebKit2 to WebKit
990         https://bugs.webkit.org/show_bug.cgi?id=132956
991
992         Reviewed by Sam Weinig.
993
994         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
995         * MiniBrowser/mac/AppDelegate.m:
996         * MiniBrowser/mac/WK2BrowserWindowController.m:
997         * TestWebKitAPI/InjectedBundleController.h:
998         * TestWebKitAPI/InjectedBundleMain.cpp:
999         * TestWebKitAPI/JavaScriptTest.cpp:
1000         * TestWebKitAPI/PlatformUtilities.h:
1001         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1002         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1003         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1004         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1005         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1006         (TestWebKitAPI::TEST):
1007         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1008         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1009         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1010         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1011         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1012         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1013         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1014         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1015         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1016         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1017         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1018         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1019         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1020         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1021         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1022         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1023         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1024         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1025         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1026         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1027         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1028         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1029         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1030         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1031         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1032         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1033         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1034         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1035         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1036         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1037         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1038         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1039         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1040         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1041         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1042         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1043         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1044         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1045         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1046         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1047         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1048         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1049         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1050         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1051         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1052         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1053         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1054         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1055         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1056         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1057         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1058         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1059         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1060         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1061         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1062         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1063         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1064         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1065         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1066         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1067         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1068         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1069         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1070         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1071         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1072         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1073         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1074         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1075         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1076         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1077         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1078         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1079         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1080         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1081         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1082         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1083         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1084         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1085         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1086         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1087         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1088         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1089         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1090         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1091         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1092         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1093         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1094         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1095         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1096         * TestWebKitAPI/config.h:
1097         * TestWebKitAPI/efl/PlatformWebView.cpp:
1098         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1099         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1100         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1101         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1102         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1103         * WebKitTestRunner/EventSenderProxy.h:
1104         * WebKitTestRunner/GeolocationProviderMock.cpp:
1105         * WebKitTestRunner/GeolocationProviderMock.h:
1106         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1107         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1108         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1109         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1110         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1111         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1112         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1116         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1117         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1118         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1120         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1121         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1122         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1123         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1124         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1125         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1126         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1127         * WebKitTestRunner/PlatformWebView.h:
1128         * WebKitTestRunner/StringFunctions.h:
1129         * WebKitTestRunner/TestController.cpp:
1130         * WebKitTestRunner/TestController.h:
1131         * WebKitTestRunner/TestInvocation.cpp:
1132         * WebKitTestRunner/TestInvocation.h:
1133         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1134         * WebKitTestRunner/WebNotificationProvider.cpp:
1135         * WebKitTestRunner/WebNotificationProvider.h:
1136         * WebKitTestRunner/WorkQueueManager.cpp:
1137         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1138         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1139         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1140         * WebKitTestRunner/config.h:
1141         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1142         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1143         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1144         * WebKitTestRunner/ios/TestControllerIOS.mm:
1145         * WebKitTestRunner/mac/EventSenderProxy.mm:
1146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1147         * WebKitTestRunner/mac/TestControllerMac.mm:
1148
1149 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1150
1151         [EFL][WK2] Skip failing unit tests
1152         https://bugs.webkit.org/show_bug.cgi?id=132979
1153
1154         Reviewed by Daniel Bates.
1155
1156         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1157
1158 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1159
1160         [iOS] Support TestWebKitAPI in the iOS Simulator
1161         <http://webkit.org/b/129535>
1162         <rdar://problem/16203529>
1163
1164         Reviewed by Daniel Bates.
1165
1166         * Scripts/run-api-tests:
1167         (runTest):
1168         (listAllTests):
1169         - Extract common arguments into local variable.
1170         - Use xcrun to find the sim tool in order to invoke
1171         TestWebKitAPI properly in the iOS Simulator. 
1172
1173         * Scripts/webkitdirs.pm:
1174         (argumentsForConfiguration): Set --device or --sim as
1175         appropriate to fix buildTestTool() in run-api-tests.
1176
1177 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1178
1179         Fix a logging typo in copy-webkitlibraries-to-product-directory
1180
1181         Reviewed by Dean Jackson.
1182
1183         * Scripts/copy-webkitlibraries-to-product-directory:
1184
1185 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1186
1187         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1188         <http://webkit.org/b/132959>
1189
1190         Reviewed by Dan Bernstein.
1191
1192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1193         Cocoa directory to project and move URLExtras.mm into it.
1194         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1195
1196 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1197
1198         [GTK] Compile all installed resources as GResources
1199         https://bugs.webkit.org/show_bug.cgi?id=131099
1200
1201         Reviewed by Philippe Normand.
1202
1203         * Scripts/webkitpy/port/gtk.py:
1204         (GtkPort.setup_environ_for_server): Removed now unneeded
1205         AUDIO_RESOURCES_PATH env var.
1206
1207 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1208
1209         Remove CSS_STICKY_POSITION guards
1210         https://bugs.webkit.org/show_bug.cgi?id=132676
1211
1212         Reviewed by Simon Fraser.
1213
1214         * Scripts/webkitperl/FeatureList.pm:
1215
1216 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1219         https://bugs.webkit.org/show_bug.cgi?id=132686
1220
1221         Reviewed by Philippe Normand.
1222
1223         Bring back InputMethodFilter test to the build and compile it into
1224         a single binary TestWebCore with the other WebCore tests. Also
1225         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1226
1227         * Scripts/run-gtk-tests:
1228         (TestRunner): Remove WebCoreGtk from the list of test directories.
1229         * TestWebKitAPI/PlatformGTK.cmake:
1230         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1231
1232 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1233
1234         [EFL] Make XVFBDriver optional
1235         https://bugs.webkit.org/show_bug.cgi?id=131036
1236
1237         Reviewed by Gyuyoung Kim.
1238
1239         * Scripts/webkitpy/port/efl.py:
1240         (EflPort._driver_class):
1241
1242 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1243
1244         Flakiness dashboard contains outdated list of bots on builders.jsonp
1245         https://bugs.webkit.org/show_bug.cgi?id=132874
1246
1247         Reviewed by Darin Adler.
1248
1249         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1250         file by changing to the directory Tools/TestResultServer and executing
1251         the script generate_builders_json.py
1252
1253 2014-05-11  Anders Carlsson  <andersca@apple.com>
1254
1255         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1256         https://bugs.webkit.org/show_bug.cgi?id=132809
1257
1258         Reviewed by Dan Bernstein.
1259
1260         * WebKitTestRunner/TestController.cpp:
1261         (WTR::TestController::initialize):
1262         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1263
1264 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1265
1266         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1267         https://bugs.webkit.org/show_bug.cgi?id=132739
1268
1269         Reviewed Anders Carlsson.
1270
1271         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1272         the JSC unit tests.
1273         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1274
1275 2014-05-11  Anders Carlsson  <andersca@apple.com>
1276
1277         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1278         https://bugs.webkit.org/show_bug.cgi?id=132806
1279
1280         Reviewed by Beth Dakin.
1281
1282         Migrate to WKContextConfiguration.
1283
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::TestController::initialize):
1286
1287 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1288
1289         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1290         https://bugs.webkit.org/show_bug.cgi?id=132685
1291
1292         Reviewed by Martin Robinson.
1293
1294         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1295
1296         * TestWebKitAPI/PlatformGTK.cmake:
1297
1298 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1299
1300         [iOS] Switch geolocation to an explicit authorization query model
1301         https://bugs.webkit.org/show_bug.cgi?id=132717
1302
1303         Reviewed by Sam Weinig.
1304
1305         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1306         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1307         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1308
1309 2014-05-09  David Farler  <dfarler@apple.com>
1310
1311         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1312         https://bugs.webkit.org/show_bug.cgi?id=132718
1313
1314         Reviewed by David Kilzer.
1315
1316         The simulator may not be able to look up runtimes by SDK paths
1317         and instead will map SDK versions to runtimes instead. In
1318         com.apple.iphonesimulator.startSession notifications,
1319         'runtimeIdentifier' (SDK version string) is preferred over
1320         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1321         when creating a new DRT or WKTR simulator session.
1322
1323         IPhoneSimulatorNotification.pm filters out keys for this
1324         notification's userInfo with a hard-coded list. There's no harm
1325         in including extra key-value pairs in an NSNotification userInfo
1326         dictionary anyway and the simulator may again change its
1327         userInfo schema for this notification.
1328
1329         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1330         (postStartSessionNotification):
1331         * Scripts/old-run-webkit-tests:
1332         (installAndLaunchDumpToolAppUsingNotification):
1333
1334 2014-05-09  Anders Carlsson  <andersca@apple.com>
1335
1336         Another build fix.
1337
1338         * Scripts/build-webkit:
1339         WebKit2 should always be built for OS X and iOS.
1340
1341 2014-05-09  Anders Carlsson  <andersca@apple.com>
1342
1343         Follow-up build fix.
1344
1345         * Scripts/build-webkit:
1346         WebKit2 should no longer be built before WebKit.
1347
1348 2014-05-09  Anders Carlsson  <andersca@apple.com>
1349
1350         Rename WebKit2.framework to WebKit.framework
1351         https://bugs.webkit.org/show_bug.cgi?id=132743
1352         <rdar://problem/15920046>
1353
1354         Reviewed by Dan Bernstein.
1355
1356         * Scripts/check-for-inappropriate-files-in-framework:
1357         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1358         Change WebKit2 to WebKit.
1359
1360         * Scripts/check-for-webkit-framework-include-consistency:
1361         Change WebKit to WebKitLegacy.
1362
1363 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1364
1365         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1366         https://bugs.webkit.org/show_bug.cgi?id=132732
1367
1368         Reviewed by Alexey Proskuryakov.
1369
1370         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1373         (EWS): Remove GTK+ WK1 EWS.
1374
1375 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1376
1377         Add new u-szeged contributors.
1378
1379         Reviewed by Csaba Osztrogonác.
1380
1381         * Scripts/webkitpy/common/config/contributors.json:
1382
1383 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1384
1385         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1386         https://bugs.webkit.org/show_bug.cgi?id=132736
1387
1388         Reviewed by Philippe Normand.
1389
1390         There are two problems, the path returned by common.library_build_path() is wrong when
1391         common.binary_build_path() has previously been called, and the test is still looking for
1392         the .la instead of .so
1393
1394         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1395         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1396         of .la as extension of the injected bundle library.
1397         * gtk/common.py:
1398         (binary_build_path): Remove unused global variable and add a new
1399         one for binary_build_dir instead of sharing the same global
1400         variable for library_build_path and binary_build_path.
1401
1402 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1403
1404         [EFL] Enable MEDIA_STREAM for EFL port
1405         https://bugs.webkit.org/show_bug.cgi?id=132648
1406
1407         Reviewed by Gyuyoung Kim.
1408
1409         Script modified to enable MEDIA_STREAM for EFL build.
1410
1411         * Scripts/webkitperl/FeatureList.pm: 
1412
1413 2014-05-08  David Farler  <dfarler@apple.com>
1414
1415         old-run-webkit-tests: update strings for simulator devices and app name
1416         https://bugs.webkit.org/show_bug.cgi?id=132687
1417
1418         Reviewed by Darin Adler.
1419
1420         iPhone Retina (4-inch) -> iPhone 5
1421         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1422
1423         * Scripts/old-run-webkit-tests:
1424         (installAndLaunchDumpToolAppUsingNotification):
1425         (openIPhoneSimulator):
1426         (quitIPhoneSimulator):
1427         quit iOS Simulator, not iPhone Simulator.
1428
1429 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1430
1431         REGRESSION(r168471): Update the builder names on the scheduler list.
1432         https://bugs.webkit.org/show_bug.cgi?id=132699
1433
1434         Reviewed by Martin Robinson.
1435
1436         On r168471 I missed to update the builder names for the GTK build
1437         bots on the AnyBranchScheduler type scheduler list of bots.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/config.json:
1440
1441 2014-05-08  Brady Eidson  <beidson@apple.com>
1442
1443         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1444         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1445
1446         Reviewed by Tim Horton.
1447
1448         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1449         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1450
1451 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1452
1453         REGRESSION(r168471): Duplicate builddirs broke the build master.
1454         https://bugs.webkit.org/show_bug.cgi?id=132688
1455
1456         Reviewed by Carlos Garcia Campos.
1457
1458         Rename the builddirs of the new GTK bots introduced on r168471 to
1459         be unique. Otherwise the master will break.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/config.json:
1462
1463 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1464
1465         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1466         https://bugs.webkit.org/show_bug.cgi?id=132674
1467
1468         Reviewed by Philippe Normand.
1469
1470         Only ignore mkdir failure when exception is raised because the
1471         file already exists and it's a directory.
1472
1473         * gtk/webkitdom.py:
1474         (write_doc_files):
1475
1476 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1477
1478         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1479         https://bugs.webkit.org/show_bug.cgi?id=131358
1480
1481         Reviewed by Carlos Garcia Campos.
1482
1483         Current 64-bit GTK build bots (Release and Debug) not only test
1484         the build, but run all tests. Split each one of the bots in
1485         BuildOnly and TestWebKit2.
1486
1487         This will allow us to have a better overview of the status of
1488         the GTK port.
1489
1490         Original patch from Sergio Villar Senin <svillar@igalia.com>
1491
1492         * BuildSlaveSupport/build.webkit.org-config/config.json:
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1495         (WebKitBuildbot):
1496         * Scripts/webkitpy/port/builders.py:
1497         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1498         (TestRebaselineTest.test_baseline_directory):
1499         * TestResultServer/static-dashboards/builders.jsonp:
1500         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1501         (resetGlobals):
1502         * TestResultServer/static-dashboards/loader_unittests.js:
1503
1504 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1505
1506         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1507         https://bugs.webkit.org/show_bug.cgi?id=126022
1508
1509         Reviewed by Benjamin Poulain.
1510
1511         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1512
1513         Added an unit test case to check if scroll position and scale are restored properly.
1514
1515         * TestWebKitAPI/PlatformEfl.cmake:
1516         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1517         (TestWebKitAPI::didFinishLoadForFrame):
1518         (TestWebKitAPI::didChangeContentsPosition):
1519         (TestWebKitAPI::TEST):
1520         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1521         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1522
1523 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1524
1525         WebKit1 is flashy when compositing layers come and go
1526         https://bugs.webkit.org/show_bug.cgi?id=132655
1527         <rdar://problem/16830981&16788846>
1528
1529         Reviewed by Sam Weinig.
1530         
1531         Revert the change from r166117.
1532
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (updateDisplay):
1535
1536 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1537
1538         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1539         https://bugs.webkit.org/show_bug.cgi?id=132622
1540
1541         Reviewed by Mario Sanchez Prada.
1542
1543         * DumpRenderTree/AccessibilityUIElement.cpp:
1544         (selectTextWithCriteriaCallback):
1545         (isEqualCallback):
1546         * DumpRenderTree/AccessibilityUIElement.h:
1547         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1548         (AccessibilityUIElement::selectTextWithCriteria):
1549         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1550         (AccessibilityUIElement::selectTextWithCriteria):
1551         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1552         (selectTextParameterizedAttributeForCriteria):
1553         (AccessibilityUIElement::selectTextWithCriteria):
1554         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1555         (AccessibilityUIElement::selectTextWithCriteria):
1556         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1557         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1558         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1559         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1561         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1562         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1563         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1564         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1565         (WTR::selectTextParameterizedAttributeForCriteria):
1566         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1567
1568 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1569
1570         [SOUP] TLSErrors do not cause page load to fail when not ignored
1571         https://bugs.webkit.org/show_bug.cgi?id=121548
1572
1573         Reviewed by Sergio Villar Senin.
1574
1575         Add unit tests to check that the load fails with TLS errors in
1576         case of a redirection.
1577
1578         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1579         (testTLSErrorsRedirect):
1580         (httpsServerCallback):
1581         (beforeAll):
1582
1583 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1584
1585         [CSS Grid Layout] Remove runtime feature
1586         https://bugs.webkit.org/show_bug.cgi?id=132382
1587
1588         Reviewed by Benjamin Poulain.
1589
1590         Remove cssGridLayoutEnabled setting usage.
1591
1592         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1593         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1594         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1595         (TestRunner::overridePreference):
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (resetWebPreferencesToConsistentValues):
1598
1599 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1600
1601         Add Makefile targets for copying static libraries (LLVM and WKSI)
1602         <http://webkit.org/b/132619>
1603
1604         Reviewed by Mark Rowe.
1605
1606         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1607         sensible default for product directory if not specified on
1608         either the command-line or in the environment (by Xcode) by
1609         calling productDir() in webkitdirs.pm.
1610
1611 2014-05-06  Brady Eidson  <beidson@apple.com>
1612
1613         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1614         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1615
1616         Reviewed by Sam Weinig.
1617
1618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1619
1620         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1621         (TestWebKitAPI::itemURLLastComponentIsString):
1622         (TestWebKitAPI::didFinishLoadForFrame):
1623         (TestWebKitAPI::willGoToBackForwardListItem):
1624         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1625         (TestWebKitAPI::setPageLoaderClient):
1626         (TestWebKitAPI::TEST):
1627         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1628         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1629
1630         * WebKitTestRunner/TestController.cpp:
1631         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1632
1633 2014-05-06  Darin Adler  <darin@apple.com>
1634
1635         Try to fix iOS build.
1636
1637         * DumpRenderTree/mac/TestRunnerMac.mm:
1638         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1639         Updated since I changed testRunner into a pointer instead of a reference.
1640         Updated argument names to avoid conflict with field names.
1641         (-[APITestDelegateIPhone run]): Ditto.
1642         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1643
1644 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1645
1646         Unreviewed, rolling out r168304.
1647         https://bugs.webkit.org/show_bug.cgi?id=132607
1648
1649         Broke the build (Requested by KaL on #webkit).
1650
1651         Reverted changeset:
1652
1653         "[GTK][CMake] Unable to do make install"
1654         https://bugs.webkit.org/show_bug.cgi?id=130188
1655         http://trac.webkit.org/changeset/168304
1656
1657 2014-05-04  Darin Adler  <darin@apple.com>
1658
1659         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1660         https://bugs.webkit.org/show_bug.cgi?id=80222
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         * DumpRenderTree/mac/TestRunnerMac.mm:
1665         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1666         do more work here so we don't use RetainPtr local variables.
1667         (-[APITestDelegateIPhone dealloc]): Added.
1668         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1669         created. Updated for changes to member names and types.
1670         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1671         updated for changes to member names and types. Changed to two word spelling.
1672         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1673         name of _cleanUp method.
1674         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1675         Ditto.
1676         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1677
1678 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1679
1680         Clean up Image Document and tweak the layout and viewport
1681         https://bugs.webkit.org/show_bug.cgi?id=132552
1682
1683         Reviewed by Anders Carlsson.
1684
1685         * DumpRenderTree/mac/DumpRenderTree.mm:
1686         (resetWebPreferencesToConsistentValues):
1687         Update the default settings to have something consistent with WebKit2.
1688
1689 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1690
1691         [GTK][CMake] Unable to do make install
1692         https://bugs.webkit.org/show_bug.cgi?id=130188
1693
1694         Reviewed by Carlos Garcia Campos.
1695
1696         * Scripts/webkitdirs.pm:
1697         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1698         will give an early signal that a change has broken the documentation.
1699
1700 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1701
1702         Update framework locations in package-root
1703         https://bugs.webkit.org/show_bug.cgi?id=132571
1704
1705         Reviewed by Simon Fraser.
1706
1707         * Scripts/package-root:
1708
1709 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1710
1711         [EFL][WK2] Refactor favicon database APIs
1712         https://bugs.webkit.org/show_bug.cgi?id=132519
1713
1714         Reviewed by Gyuyoung Kim.
1715
1716         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1717         (update_view_favicon):
1718         (on_icon_changed_cb):
1719         (window_free):
1720         (on_url_changed):
1721         (window_create):
1722         (on_view_favicon_changed): Deleted.
1723
1724 2014-05-02  Mark Rowe  <mrowe@apple.com>
1725
1726         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1727
1728         Reviewed by Dan Bernstein.
1729
1730         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1731         when determining which LLVM archive to extract.
1732
1733 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1734
1735         Add Jeremy as a committer.
1736         https://bugs.webkit.org/show_bug.cgi?id=132492
1737
1738         Reviewed by Jer Noble.
1739
1740         Add myself as a committer.
1741
1742         * Scripts/webkitpy/common/config/contributors.json:
1743
1744 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1745
1746         Add Jeremy as a committer.
1747         https://bugs.webkit.org/show_bug.cgi?id=132492
1748
1749         Reviewed by Jer Noble.
1750
1751         Add Jeremy Jones to the committers file.
1752
1753         * Scripts/webkitpy/common/config/contributors.json:
1754
1755 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1756
1757         Hard to figure out how to run a single test with run-api-tests
1758         https://bugs.webkit.org/show_bug.cgi?id=116332
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         * Scripts/run-api-tests: add two examples to the help message.
1763
1764 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1765
1766         Fix several memory leaks found by code inspection
1767         https://bugs.webkit.org/show_bug.cgi?id=132472
1768
1769         Reviewed by Geoffrey Garen.
1770         
1771         Fix memory leaks.
1772
1773         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1774         (TestWebKitAPI::TEST):
1775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1776         (WTR::InjectedBundlePage::willSendRequestForFrame):
1777         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1778         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1779
1780 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1781
1782         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1783         https://bugs.webkit.org/show_bug.cgi?id=132446
1784
1785         Reviewed by Mark Hahnenberg.
1786         
1787         Test the FTL by default now that it's enabled by default.
1788
1789         * Scripts/run-javascriptcore-tests:
1790
1791 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1792
1793         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1794         https://bugs.webkit.org/show_bug.cgi?id=132240
1795
1796         Reviewed by Anders Carlsson.
1797
1798         Removed ewk_view_setting_tiled_backingstore related code.
1799
1800         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1801         (DumpRenderTreeChrome::createView):
1802         (shouldUseTiledBackingStore): Deleted.
1803         * EWebLauncher/main.c:
1804         (windowCreate):
1805         (parseUserArguments):
1806
1807 2014-05-01  Anders Carlsson  <andersca@apple.com>
1808
1809         window.testRunner.keepWebHistory() should update the UI process state
1810         https://bugs.webkit.org/show_bug.cgi?id=132440
1811
1812         Reviewed by Dan Bernstein.
1813
1814         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1815         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1816         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1817         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1818         (WTR::TestRunner::keepWebHistory):
1819         * WebKitTestRunner/TestInvocation.cpp:
1820         (WTR::TestInvocation::invoke):
1821         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1822
1823 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1824
1825         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1826         <http://webkit.org/b/132432>
1827
1828         Reviewed by Tim Horton.
1829
1830         * Scripts/webkitperl/FeatureList.pm: Remove support for
1831         --plugin-proxy-for-video switch.
1832
1833 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1834
1835         Kernel sysctl interface hw.activecpu don't exists on Linux.
1836         https://bugs.webkit.org/show_bug.cgi?id=132286
1837
1838         Reviewed by Filip Pizlo.
1839
1840         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1841         calling sysctl over hw.activecpu
1842
1843 2014-04-30  Anders Carlsson  <andersca@apple.com>
1844
1845         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1846         https://bugs.webkit.org/show_bug.cgi?id=132399
1847         <rdar://problem/15920046>
1848
1849         Reviewed by Dan Bernstein.
1850
1851         * Scripts/check-for-webkit-framework-include-consistency:
1852         Allos WAK headers in WebKitLegacy as well as WebKit.
1853
1854         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1855         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1856         Update header imports.
1857
1858 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1859
1860         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1861         https://bugs.webkit.org/show_bug.cgi?id=131954
1862
1863         Reviewed by Darin Adler.
1864         
1865         WebKitTestRunner was adding application-specific information to crash reports
1866         to log the test path, but only in the web process. Fix it to also do this
1867         for the UI process, for both iOS and OS X.
1868         
1869         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1870         both iOS and OS X.
1871         
1872         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1873         a new TestController::platformWillRunTest() function on Mac and iOS.
1874         
1875         Also remove Xcode-added unit test junk from the project.
1876
1877         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1878         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1879         * WebKitTestRunner/TestController.cpp:
1880         (WTR::TestController::runTest):
1881         * WebKitTestRunner/TestController.h:
1882         * WebKitTestRunner/TestInvocation.cpp:
1883         (WTR::TestInvocation::url):
1884         * WebKitTestRunner/TestInvocation.h:
1885         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1886         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1887         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1888         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1889         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1890         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1891         (WTR::testPathFromURL):
1892         (WTR::setCrashReportApplicationSpecificInformationToURL):
1893         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1894         (WTR::TestController::platformWillRunTest):
1895         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1896         (WTR::TestController::platformWillRunTest):
1897         * WebKitTestRunner/ios/TestControllerIOS.mm:
1898         (WTR::TestController::platformWillRunTest):
1899         (WTR::TestController::setHidden):
1900         * WebKitTestRunner/mac/TestControllerMac.mm:
1901         (WTR::TestController::platformWillRunTest):
1902
1903 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1904
1905         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1906
1907         Reviewed by Tim Horton.
1908
1909         * DumpRenderTree/mac/DumpRenderTree.mm:
1910         (resetWebPreferencesToConsistentValues):
1911         (prepareConsistentTestingEnvironment):
1912
1913 2014-04-30  Anders Carlsson  <andersca@apple.com>
1914
1915         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1916         https://bugs.webkit.org/show_bug.cgi?id=132397
1917
1918         Reviewed by Dan Bernstein.
1919
1920         * Scripts/check-for-inappropriate-macros-in-external-headers:
1921
1922 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1923
1924         [GTK] Make it easier to run CMake for downstreams
1925         https://bugs.webkit.org/show_bug.cgi?id=132370
1926
1927         Reviewed by Carlos Garcia Campos.
1928
1929         * Scripts/webkitdirs.pm:
1930         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1931         the GTK+ port.
1932
1933 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1934
1935         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1936         
1937         Rubber stamped by Jessie Berlin.
1938
1939         JSON.pm was removed from our tools setup.
1940
1941         * Scripts/generate-coverage-data:
1942
1943 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1944
1945         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1946         https://bugs.webkit.org/show_bug.cgi?id=112840
1947
1948         Rubber stamped by Geoffrey Garen.
1949
1950         * Scripts/build-jsc: Enable it on Mac.
1951         * Scripts/build-webkit: Enable it on Mac.
1952         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1953
1954 2014-04-28  Sam Weinig  <sam@webkit.org>
1955
1956         REGRESSION (r167751): svn-create-patch is very slow
1957         https://bugs.webkit.org/show_bug.cgi?id=132300
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * Scripts/svn-create-patch:
1962         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1963         by calling `svn-create-patch --style`.
1964
1965 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1966
1967         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1968         https://bugs.webkit.org/show_bug.cgi?id=132190
1969
1970         Reviewed by Gustavo Noronha Silva.
1971
1972         * Scripts/webkitdirs.pm:
1973         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1974             if ninja is in the path.
1975         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1976             to the previous ninja generator if not.
1977
1978 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1979
1980         check-webkit-style should understand --git-index
1981         https://bugs.webkit.org/show_bug.cgi?id=125364
1982
1983         Reviewed by Csaba Osztrogonác.
1984
1985         * Scripts/webkitpy/common/checkout/scm/git.py:
1986         (Git.create_patch): The command now supports the --cached option.
1987         * Scripts/webkitpy/style/main.py:
1988         (CheckWebKitStyle.main): Passing the --git-index option.
1989         * Scripts/webkitpy/style/optparser.py:
1990         (CommandOptionValues.__init__): The git-index option is switched off by default.
1991         (CommandOptionValues.__eq__): Equality check for the new option.
1992         (ArgumentParser._create_option_parser):Adding the --git-index option
1993         (ArgumentParser.parse):
1994         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1995         (CommandOptionValuesTest.test_init): 
1996         (CommandOptionValuesTest.test_eq):
1997
1998 2014-04-28  Michael Saboff  <msaboff@apple.com>
1999
2000         Crash in platform/mac/accessibility/table-visible-rows.html
2001         https://bugs.webkit.org/show_bug.cgi?id=132146
2002
2003         Reviewed by Filip Pizlo.
2004
2005         Instead of creating a local JSValueRef array on the stack and passing that to
2006         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2007         values using the JSObjectSetPropertyAtIndex() API.
2008
2009         * DumpRenderTree/AccessibilityUIElement.cpp:
2010         (elementsForRangeCallback):
2011         (convertElementsToObjectArray):
2012         * DumpRenderTree/mac/TestRunnerMac.mm:
2013         (originsArrayToJS):
2014         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2015         (WTR::EventSendingController::contextClick):
2016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2017         (WTR::stringArrayToJS):
2018         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2019         (WTR::convertElementsToObjectArray):
2020
2021 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2022
2023         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2024         "no-cjit" runs force the old-school threshold.
2025
2026         Rubber stamped by Mark Hahnenberg.
2027
2028         * Scripts/run-jsc-stress-tests:
2029
2030 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2031
2032         [GTK] install-dependencies should also install ruby-json and ruby-highline
2033         https://bugs.webkit.org/show_bug.cgi?id=132292
2034
2035         Reviewed by Philippe Normand.
2036
2037         * gtk/install-dependencies: Install ruby json and highline packages.
2038
2039 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2040
2041         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2042         https://bugs.webkit.org/show_bug.cgi?id=132176
2043
2044         Reviewed by Gyuyoung Kim.
2045
2046         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2047         and turn off indexedDB feature until the sqlite implementation is introduced.
2048
2049         * Scripts/webkitperl/FeatureList.pm:
2050
2051 2014-04-25  James Craig  <jcraig@apple.com>
2052
2053         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2054         https://bugs.webkit.org/show_bug.cgi?id=132209
2055
2056         Reviewed by Daniel Bates.
2057
2058         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2059         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2060
2061         * Scripts/prepare-ChangeLog:
2062         (main): 
2063
2064 2014-04-25  Michael Saboff  <msaboff@apple.com>
2065
2066         Crash in platform/mac/accessibility/table-visible-rows.html
2067         https://bugs.webkit.org/show_bug.cgi?id=132146
2068
2069         Reviewed by Mark Lam.
2070
2071         Changed to use a local JSValueRef array temporary instead of a
2072         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2073         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2074         the temporary values could be collected.
2075
2076         * DumpRenderTree/AccessibilityUIElement.cpp:
2077         (convertElementsToObjectArray):
2078         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2079         (WTR::EventSendingController::contextClick):
2080         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2081         (WTR::convertElementsToObjectArray):
2082
2083 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2084
2085         Unreviewed GTK gardening
2086
2087         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2088         (TestRunner):
2089
2090 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2091
2092         prepare-ChangeLog reports as deleted methods that has not been removed.
2093         https://bugs.webkit.org/show_bug.cgi?id=131733
2094
2095         Reviewed by Ryosuke Niwa.
2096
2097         * Scripts/prepare-ChangeLog:
2098         (originalFile): Set merge base to origin/master by default.
2099
2100 2014-04-23  James Craig  <jcraig@apple.com>
2101
2102         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2103         https://bugs.webkit.org/show_bug.cgi?id=131115
2104
2105         Reviewed by Daniel Bates.
2106
2107         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2108
2109         * Scripts/commit-log-editor: Added --no-style.
2110         * Scripts/prepare-ChangeLog: Primary patch.
2111         (main): Primary patch.
2112         (createPatchCommand): Added --no-style.
2113         * Scripts/svn-create-patch: Primary patch.
2114         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2115         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2116         (SVN.create_patch): Added --no-style.
2117
2118 2014-04-23  Anders Carlsson  <andersca@apple.com>
2119
2120         Try to fix iOS build.
2121
2122         * DumpRenderTree/mac/DumpRenderTree.mm:
2123
2124 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2125
2126         Eliminate internals.setMockScrollbarsEnabled()
2127         https://bugs.webkit.org/show_bug.cgi?id=132085
2128
2129         Reviewed by Tim Horton.
2130
2131         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2132         No need to reset the preference, there is no way it can change.
2133
2134 2014-04-23  James Craig  <jcraig@apple.com>
2135
2136         Unreviewed. Moving myself from Contributors to Committers list.
2137
2138         * Scripts/webkitpy/common/config/contributors.json:
2139
2140 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2141
2142         Mock scrollbars don't always work in DumpRenderTree
2143         https://bugs.webkit.org/show_bug.cgi?id=132082
2144
2145         Reviewed by Alexey Proskuryakov.
2146
2147         * DumpRenderTree/mac/DumpRenderTree.mm:
2148         (prepareConsistentTestingEnvironment):
2149         Set the mock scrollbar setting before creating the WebView, as this setting
2150         cannot be dynamically changed, so any scrollbars that are created during
2151         WebView initialization and are not replaced before snapshotting will end
2152         up being platform scrollbars instead of mock ones.
2153         WebKitTestRunner already sets this preference before creating WKViews,
2154         so we're just matching its behavior.
2155
2156 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2157
2158         [GTK] ShadowRoot API was removed in r164131
2159         https://bugs.webkit.org/show_bug.cgi?id=132059
2160
2161         Reviewed by Gustavo Noronha Silva.
2162
2163         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2164         the API docs.
2165
2166         * gtk/webkitdom.py:
2167         (WebKitDOMDocGenerator):
2168
2169 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2170
2171         [GTK] run-webkit-tests script is failing to invoke run-launcher
2172         https://bugs.webkit.org/show_bug.cgi?id=132051
2173
2174         Reviewed by Philippe Normand.
2175
2176         After the WK1 support was dropped, if run-webkit-tests is executed
2177         without --no-show-results parameter, the launcher is being called
2178         using a -2 parameter that is it causing the run-launcher to break.
2179
2180         * Scripts/webkitpy/port/gtk.py:
2181         (GtkPort.show_results_html_file):
2182
2183 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2184
2185         DumpRenderTree generates black snapshots on some platforms
2186         https://bugs.webkit.org/show_bug.cgi?id=132029
2187         <rdar://problem/16679363>
2188
2189         Reviewed by Simon Fraser.
2190
2191         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2192         (createBitmapContextFromWebView):
2193         DRT checks with the WebView to determine whether it can use the window's
2194         backing store directly or (because of compositing) needs to take a WindowServer
2195         snapshot. However, on some platforms and in some situations, the window can
2196         be layer backed without the WebView necessarily currently being composited.
2197         We should check with the window in addition to the WebView before going
2198         ahead and using its backing store.
2199
2200 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2201
2202         DumpRenderTree generates white snapshots on some platforms
2203         https://bugs.webkit.org/show_bug.cgi?id=132026
2204         <rdar://problem/16679363>
2205
2206         Reviewed by Simon Fraser.
2207
2208         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2209         Link DRT against QuartzCore.
2210
2211         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2212         (createBitmapContextFromWebView):
2213         Force CoreAnimation to synchronously update layers in a more explicit
2214         way that doesn't depend on AppKit behavior. This is very similar to what
2215         WebKitTestRunner does (indirectly) during its force repaint.
2216
2217 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2218
2219         [Win] Support Python 2.7 in Cygwin
2220         https://bugs.webkit.org/show_bug.cgi?id=132023
2221
2222         Reviewed by Michael Saboff.
2223
2224         * Scripts/webkitdirs.pm:
2225         (checkInstalledTools): Remove check for Python 2.7, since
2226         it now works properly.
2227
2228 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2229
2230         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2231         https://bugs.webkit.org/show_bug.cgi?id=130867
2232         <rdar://problem/16432456> 
2233
2234         Reviewed by Mark Hahnenberg.
2235
2236         * Scripts/build-webkit:
2237         * Scripts/copy-webkitlibraries-to-product-directory:
2238
2239 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2240
2241         [GTK] Fails to build documentation when output is redirected
2242         https://bugs.webkit.org/show_bug.cgi?id=131178
2243
2244         Reviewed by Martin Robinson.
2245
2246         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2247         explicitly to avoid encoding issues when they are redirected.
2248
2249 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2250
2251         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2252         https://bugs.webkit.org/show_bug.cgi?id=131911
2253
2254         Reviewed by Martin Robinson.
2255
2256         common.get_build_path returns release path even though Debug configuration
2257         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2258
2259         * gtk/ycm_extra_conf.py:
2260         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2261         (FlagsForFile):
2262
2263 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2264
2265         Unreviewed build fix.
2266
2267         * DumpRenderTree/mac/EventSendingController.mm:
2268         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2269         Correct a typo that prevented tests from working properly.
2270
2271 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2272
2273         [GTK] Should have the ability to output composited contents during layout testing
2274         https://bugs.webkit.org/show_bug.cgi?id=131864
2275
2276         Reviewed by Philippe Normand.
2277
2278         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2279         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2280         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2281         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2282         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2283
2284 2014-04-21  Sam Weinig  <sam@webkit.org>
2285
2286         Attempt to fix the tests.
2287
2288         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2289         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2290         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2291
2292 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2293
2294         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2295         being the same as a "quick run", which is meant for genuinely slow tests).
2296
2297         * Scripts/run-jsc-stress-tests:
2298
2299 2014-04-21  Darin Adler  <darin@apple.com>
2300
2301         Add HashSet::takeAny
2302         https://bugs.webkit.org/show_bug.cgi?id=131928
2303
2304         Reviewed by Benjamin Poulain.
2305
2306         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2307
2308 2014-04-20  Dan Bernstein  <mitz@apple.com>
2309
2310         Fixed a test timing out after r167572.
2311
2312         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2313         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2314         -webView:didFinishLoadingNavigation:.
2315
2316 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2317
2318         Unreviewed, rolling out r167510.
2319         https://bugs.webkit.org/show_bug.cgi?id=131915
2320
2321         broke GTK Debug bot (Requested by philn on #webkit).
2322
2323         Reverted changeset:
2324
2325         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2326         it when running layout tests"
2327         https://bugs.webkit.org/show_bug.cgi?id=131472
2328         http://trac.webkit.org/changeset/167510
2329
2330 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2331
2332         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2333         https://bugs.webkit.org/show_bug.cgi?id=131472
2334
2335         Reviewed by Philippe Normand.
2336
2337         * Scripts/webkitpy/port/gtk.py:
2338         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2339         when running WebKitTestRunner with run-webkit-tests.
2340         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2341         installed.
2342         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2343         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2344         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2345         deal.
2346
2347 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2348
2349         DownloadDecideDestinationCrash API test uses an incorrect value for path
2350         https://bugs.webkit.org/show_bug.cgi?id=131845
2351         <rdar://problem/15925560>
2352
2353         Reviewed by Enrica Casucci.
2354
2355         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2356         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2357
2358 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2359
2360         [Mac] AttributedStringTest API tests fail with async text input
2361         https://bugs.webkit.org/show_bug.cgi?id=131833
2362
2363         Reviewed by Enrica Casucci.
2364
2365         Don't run sync NSTextInputClient tests where we don't implement these calls.
2366
2367         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2368         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2369         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2370         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2371         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2372         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2373         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2374
2375 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2376
2377         Remove NETWORK_INFO support
2378         https://bugs.webkit.org/show_bug.cgi?id=131841
2379
2380         Reviewed by Gyuyoung Kim.
2381
2382         * Scripts/webkitperl/FeatureList.pm:
2383
2384 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2385
2386         [GTK] YouCompleteMe doesn't work for cmake build system.
2387         https://bugs.webkit.org/show_bug.cgi?id=131591
2388
2389         Reviewed by Martin Robinson.
2390
2391         Add cmake build system support for YouCompleteMe. It should work regardless of
2392         using make or ninja. In addition, autotools related code is removed since it's
2393         not used anymore in WebKit.
2394
2395         * Scripts/webkitdirs.pm:
2396         (generateBuildSystemFromCMakeProject):
2397         * gtk/ycm_extra_conf.py:
2398         (transform_relative_paths_to_absolute_paths):
2399         (FlagsForFile):
2400
2401 2014-04-17  Anders Carlsson  <andersca@apple.com>
2402
2403         Fix build.
2404
2405         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2406         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2407         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2408
2409 2014-04-17  Anders Carlsson  <andersca@apple.com>
2410
2411         Remove unused API enums
2412         https://bugs.webkit.org/show_bug.cgi?id=131836
2413
2414         Reviewed by Tim Horton.
2415
2416         * MiniBrowser/mac/WK2BrowserWindowController.m:
2417         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2418
2419 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2420
2421         [Win] A few final cleanups to the DataObject classes.
2422         https://bugs.webkit.org/show_bug.cgi?id=131784
2423
2424         Reviewed by Anders Carlsson.
2425
2426         * DumpRenderTree/win/DRTDataObject.cpp:
2427         (DRTDataObject::clearData): Use 'last()' method.
2428         * DumpRenderTree/win/UIDelegate.cpp:
2429         (DRTUndoStack::pop): Use 'takeLast()' method.
2430
2431 2014-04-17  Andres Gomez  <agomez@igalia.com>
2432
2433         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2434         https://bugs.webkit.org/show_bug.cgi?id=131365
2435
2436         Reviewed by Brent Fulgham.
2437
2438         The cygwin installer is now downloading the wanted versions for
2439         the local installation given to the setup wizard.
2440
2441         * CygwinDownloader/cygwin-downloader.py:
2442         * CygwinDownloader/cygwin-downloader.zip:
2443
2444 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2445
2446         [GTK] Make run-webkit-tests always use WKTR
2447         https://bugs.webkit.org/show_bug.cgi?id=131737
2448
2449         Reviewed by Darin Adler.
2450
2451         Now that the GTK+ port only has support for WebKit2, instruct
2452         run-webkit-tests to always use WKTR. This avoids needing to pass
2453         flag "-2" every time.
2454
2455         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2456         (_set_up_derived_options): Always set webkit_test_runner when
2457         the platform is GTK+.
2458
2459 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2460
2461         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2462         https://bugs.webkit.org/show_bug.cgi?id=131760
2463
2464         Reviewed by Philippe Normand.
2465
2466         * gtk/install-dependencies: Install ninja-build when it's available.
2467
2468 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2469
2470         [Win] run-javascriptcore-tests fails to run.
2471         https://bugs.webkit.org/show_bug.cgi?id=131761
2472
2473         Reviewed by Brent Fulgham.
2474
2475         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2476
2477 2014-04-16  Andres Gomez  <agomez@igalia.com>
2478
2479         [Win] Pass default parameters to cygwin setup wizard
2480         https://bugs.webkit.org/show_bug.cgi?id=131361
2481
2482         Reviewed by Brent Fulgham.
2483
2484         Added some parameters to the cygwin setup wizard so the user
2485         doesn't really have to do any interaction.
2486
2487         * CygwinDownloader/cygwin-downloader.py:
2488         * CygwinDownloader/cygwin-downloader.zip:
2489
2490 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2491
2492         [Win] Eliminate use of deleteAllValues in Windows Files
2493         https://bugs.webkit.org/show_bug.cgi?id=131631
2494
2495         Reviewed by Darin Adler.
2496
2497         Switch to std::unique_ptr for memory lifetime. Get rid of
2498         deleteAllValues now that it is no longer needed. Use ranged
2499         for loops where possible.
2500
2501         * DumpRenderTree/win/DRTDataObject.cpp:
2502         (WCEnumFormatEtc::WCEnumFormatEtc):
2503         (DRTDataObject::~DRTDataObject):
2504         (DRTDataObject::GetData):
2505         (DRTDataObject::QueryGetData):
2506         (DRTDataObject::SetData):
2507         (DRTDataObject::clearData):
2508         * DumpRenderTree/win/DRTDataObject.h:
2509         * DumpRenderTree/win/UIDelegate.cpp:
2510         (DRTUndoObject::DRTUndoObject):
2511         (DRTUndoObject::~DRTUndoObject):
2512         (DRTUndoStack::~DRTUndoStack):
2513         (DRTUndoStack::clear):
2514         (DRTUndoStack::pop):
2515         (DRTUndoManager::DRTUndoManager):
2516         (DRTUndoManager::redo):
2517         (DRTUndoManager::undo):
2518         (UIDelegate::UIDelegate):
2519         (UIDelegate::resetUndoManager):
2520         * DumpRenderTree/win/UIDelegate.h:
2521
2522 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2523
2524         [GTK] Unreviewed GTK gardening.
2525
2526         Update list of skipped unit tests:
2527
2528           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2529
2530           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2531           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2532
2533         * Scripts/run-gtk-tests:
2534         (TestRunner):
2535
2536 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2537
2538         check-webkit-style doesn't check code style in .mm or .m files
2539         https://bugs.webkit.org/show_bug.cgi?id=131708
2540
2541         Reviewed by Darin Adler.
2542
2543         * Scripts/webkitpy/style/checker.py:
2544         * Scripts/webkitpy/style/checker_unittest.py:
2545         (CheckerDispatcherDispatchTest.test_cpp_paths):
2546         (CheckerDispatcherDispatchTest.test_text_paths):
2547         Check .mm and .m files as C++.
2548
2549         * Scripts/webkitpy/style/checkers/cpp.py:
2550         (check_spacing):
2551         Add an override for our ordinary "missing spaces around =" for @synthesize,
2552         which should look like "@synthesize propertyName=_varName;"
2553
2554         Add an override for "missing space before {" for blocks' "^{".
2555
2556         Don't follow the "extra space before [" rule for Objective-C, because
2557         it breaks this rule in a multitude of ways because of method calls.
2558
2559         (check_braces):
2560         Don't complain about { not being on the end of the previous line if
2561         the previous line starts with "- (" or "+ (", which would indicate a
2562         Objective-C method definition.
2563
2564 2014-04-16  Darin Adler  <darin@apple.com>
2565
2566         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2567         https://bugs.webkit.org/show_bug.cgi?id=131735
2568
2569         Reviewed by Alexey Proskuryakov.
2570
2571         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2572         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2573         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2574         way, but gtest works better this way.
2575
2576 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2577
2578         [EFL] Fix problems with the pixel dump.
2579         https://bugs.webkit.org/show_bug.cgi?id=131265
2580
2581         Reviewed by Gyuyoung Kim.
2582
2583         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2584         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2585         which causes that nothing is drawn.
2586
2587         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2588         One of new functions is AcceleratedCompositingContext::extractImageData(),
2589         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2590         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2591
2592         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2593         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2594
2595 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2596
2597         Update LLVM export scrpt to handle the build directory being different from the
2598         source directory.
2599
2600         Rubber stamped by Geoffrey Garen.
2601
2602         * Scripts/export-llvm-build:
2603
2604 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2605
2606         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2607         https://bugs.webkit.org/show_bug.cgi?id=131695
2608
2609         Reviewed by Antti Koivisto.
2610
2611         Updated.
2612
2613         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2614
2615 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2616
2617         [GTK] Reduce the binary size by compressing the text based web inspector resources
2618         https://bugs.webkit.org/show_bug.cgi?id=121545
2619
2620         Reviewed by Gustavo Noronha Silva.
2621
2622         Compress text based files when compiling inspector resources. It
2623         reduces the binary size in 3MB.
2624
2625         * gtk/generate-inspector-gresource-manifest.py:
2626         (find_all_files_in_directory):
2627         (is_compressible):
2628
2629 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2630
2631         Remove Gtk WebKit1 tester.
2632
2633         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2634         results over and over as fast as it could.
2635
2636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2637         (WebKitBuildbot):
2638
2639 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2640
2641         Wrong link for webkitpy tests results in dashboard popover
2642         https://bugs.webkit.org/show_bug.cgi?id=131664
2643
2644         Reviewed by Timothy Hatcher.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2647         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2648         Use a correct link.
2649
2650 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2651
2652         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2653
2654         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2655
2656         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2657         (CommitMessageForThisCommitTest):
2658
2659 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2660
2661         Fix commit-log-editor bug revealed by r165447
2662         https://bugs.webkit.org/show_bug.cgi?id=130676
2663
2664         Reviewed by Csaba Osztrogonác.
2665
2666         * Scripts/commit-log-editor:
2667         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2668         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2669         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2670         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2671
2672 2014-04-13  Darin Adler  <darin@apple.com>
2673
2674         userVisibleString should not try to "encode" host names
2675         https://bugs.webkit.org/show_bug.cgi?id=131587
2676         rdar://problem/14686849
2677
2678         Reviewed by Alexey Proskuryakov.
2679
2680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2681
2682         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2683         Coverage is tiny at this point; we could add a lot more cases!
2684
2685 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2686
2687         Use #include instead of #import
2688         https://bugs.webkit.org/show_bug.cgi?id=131604
2689
2690         Reviewed by Darin Adler.
2691
2692         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2693
2694         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2695
2696 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2697
2698         Make slow-stress tests run faster by running fewer VM variants.
2699
2700         Rubber stamped by Geoffrey Garen.
2701
2702         * Scripts/run-javascriptcore-tests:
2703         * Scripts/run-jsc-stress-tests:
2704
2705 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2706
2707         [CMake] Add missing WTF unit tests
2708         https://bugs.webkit.org/show_bug.cgi?id=131459
2709
2710         Reviewed by Martin Robinson.
2711
2712         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2713         that should be compiled into the TestWTF binary.
2714
2715 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2716
2717         [Gtk] run-launcher doesn't work by default
2718         https://bugs.webkit.org/show_bug.cgi?id=131494
2719
2720         Reviewed by Philippe Normand.
2721
2722         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2723         * Scripts/webkitdirs.pm:
2724         (launcherName): Same.
2725         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2726         * gtk/common.py:
2727         (get_build_path.is_valid_build_directory): Same.
2728         * gtk/manifest.txt: Same.
2729
2730 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2731
2732         Unreviewed, rolling out r167046.
2733         https://bugs.webkit.org/show_bug.cgi?id=131479
2734
2735         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2736         on #webkit).
2737
2738         Reverted changeset:
2739
2740         "Remove "System Font" from whitelisted DRT fonts and char
2741         width calculations"
2742         https://bugs.webkit.org/show_bug.cgi?id=131411
2743         http://trac.webkit.org/changeset/167046
2744
2745 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2746
2747         Remove "System Font" from whitelisted DRT fonts and char width calculations
2748         https://bugs.webkit.org/show_bug.cgi?id=131411
2749
2750         Reviewed by Tim Horton.
2751
2752         Covered by existing tests.
2753
2754         * DumpRenderTree/mac/DumpRenderTree.mm:
2755         (allowedFontFamilySet):
2756
2757 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2758
2759         systemHiddenFontFamilySet in DRT is unnecessary
2760         https://bugs.webkit.org/show_bug.cgi?id=131414
2761
2762         Reviewed by Tim Horton.
2763
2764         It doesn't seem to affect test results on my machine.
2765
2766         * DumpRenderTree/mac/DumpRenderTree.mm:
2767         (drt_NSFontManager_availableFonts):
2768         (systemHiddenFontFamilySet): Deleted.
2769
2770 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2771
2772         [Win] Unreviewed test fix: Don't double-release BSTR.
2773
2774         * DumpRenderTree/win/DumpRenderTree.cpp:
2775         (dump): Remove unneeded call to SysFreeString now that we are
2776         using _bstr_t for this variable.
2777
2778 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2779
2780         [Win] Various DumpRenderTree Fixes.
2781         https://bugs.webkit.org/show_bug.cgi?id=131446.
2782
2783         Reviewed by Tim Horton.
2784
2785         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2786         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2787         (AccessibilityUIElement::description): Ditto.
2788         (AccessibilityUIElement::helpText): Ditto.
2789         (AccessibilityUIElement::intValue): Ditto.
2790         (AccessibilityUIElement::isPressActionSupported): Ditto.
2791         (AccessibilityUIElement::accessibilityValue): Ditto.
2792         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2793         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2794         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2795         (DRTDesktopNotificationPresenter::Release): Ditto.
2796         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2797         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2798         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2799         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2800         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2801         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2802         * DumpRenderTree/win/DumpRenderTree.cpp:
2803         (dumpFrameScrollPosition): Ditto.
2804         (dumpFramesAsText): Ditto.
2805         (compareHistoryItems): Ditto.
2806         (dumpHistoryItem): Ditto.
2807         (dump): Ditto.
2808         (resetDefaultsToConsistentValues): Ditto.
2809         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2810         (runTest): Ditto.
2811         (createWebViewAndOffscreenWindow): Ditto.
2812         * DumpRenderTree/win/EditingDelegate.cpp:
2813         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2814         (EditingDelegate::AddRef): Ditto.
2815         (EditingDelegate::Release): Ditto.
2816         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2817         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2818         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2819         (EditingDelegate::shouldInsertNode): Ditto.
2820         (EditingDelegate::shouldInsertText): Ditto.
2821         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2822         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2823         (EditingDelegate::shouldApplyStyle): Ditto.
2824         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2825         (EditingDelegate::doPlatformCommand): Ditto.
2826         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2827         (EditingDelegate::webViewDidChange): Ditto.
2828         (EditingDelegate::webViewDidEndEditing): Ditto.
2829         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2830         (EditingDelegate::webViewDidChangeSelection): Ditto.
2831         (EditingDelegate::checkSpellingOfString): Ditto.
2832         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2833         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2834         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2835         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2836         (FrameLoadDelegate::AddRef): Ditto.
2837         (FrameLoadDelegate::Release): Ditto.
2838         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2839         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2840         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2841         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2842         (FrameLoadDelegate::didReceiveTitle): Ditto.
2843         (FrameLoadDelegate::didChangeIcons): Ditto.
2844         (delegatesWithDelayedWork): Ditto.
2845         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2846         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2847         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2848         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2849         (FrameLoadDelegate::willCloseFrame): Ditto.
2850         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2851         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2852         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2853         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2854         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2855         * DumpRenderTree/win/FrameLoadDelegate.h:
2856         * DumpRenderTree/win/HistoryDelegate.cpp:
2857         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2858         (HistoryDelegate::updateHistoryTitle): Ditto.
2859         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2860         * DumpRenderTree/win/PolicyDelegate.cpp:
2861         (dumpPath):
2862         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2863         (PolicyDelegate::AddRef): Ditto.
2864         (PolicyDelegate::Release): Ditto.
2865         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2866         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2867         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2868         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2869         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2870         (ResourceLoadDelegate::AddRef): Ditto.
2871         (ResourceLoadDelegate::Release): Ditto.
2872         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2873         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2874         (ResourceLoadDelegate::willSendRequest): Ditto.
2875         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2876         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2877         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2878         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2879         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2880         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2881         (TestRunner::setUserStyleSheetLocation): Ditto.
2882         (TestRunner::execCommand): Ditto.
2883         (TestRunner::overridePreference): Ditto.
2884         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2885         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2886         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2887         (TextInputController::insertText): Ditto.
2888         * DumpRenderTree/win/UIDelegate.cpp:
2889         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2890         (UIDelegate::AddRef): Ditto.
2891         (UIDelegate::Release): Ditto.
2892         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2893         (UIDelegate::trackCustomPopupMenu): Ditto.
2894         (UIDelegate::registerUndoWithTarget): Ditto.
2895         (UIDelegate::removeAllActionsWithTarget): Ditto.
2896         (UIDelegate::setActionTitle): Ditto.
2897         (UIDelegate::undo): Ditto.
2898         (UIDelegate::redo): Ditto.
2899         (UIDelegate::canUndo): Ditto.
2900         (UIDelegate::canRedo): Ditto.
2901         (UIDelegate::printFrame): Ditto.
2902         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2903         (UIDelegate::webViewHeaderHeight): Ditto.
2904         (UIDelegate::webViewFooterHeight): Ditto.
2905         (UIDelegate::drawHeaderInRect): Ditto.
2906         (UIDelegate::drawFooterInRect): Ditto.
2907         (UIDelegate::webViewPrintingMarginRect): Ditto.
2908         (UIDelegate::canRunModal): Ditto.
2909         (UIDelegate::createModalDialog): Ditto.
2910         (UIDelegate::runModal): Ditto.
2911         (UIDelegate::isMenuBarVisible): Ditto.
2912         (UIDelegate::setMenuBarVisible): Ditto.
2913         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2914         (UIDelegate::paintCustomScrollbar): Ditto.
2915         (UIDelegate::paintCustomScrollCorner): Ditto.
2916         (UIDelegate::setFrame): Ditto.
2917         (UIDelegate::webViewFrame): Ditto.
2918         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2919         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2920         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2921         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2922         (UIDelegate::webViewAddMessageToConsole): Ditto.
2923         (UIDelegate::doDragDrop): Ditto.
2924         (UIDelegate::webViewGetDlgCode): Ditto.
2925         (UIDelegate::createWebViewWithRequest): Ditto.
2926         (UIDelegate::webViewClose): Ditto.
2927         (UIDelegate::webViewFocus): Ditto.
2928         (UIDelegate::webViewUnfocus): Ditto.
2929         (UIDelegate::webViewPainted): Ditto.
2930         (UIDelegate::exceededDatabaseQuota): Ditto.
2931         (UIDelegate::embeddedViewWithArguments): Ditto.
2932         (UIDelegate::webViewClosing): Ditto.
2933         (UIDelegate::webViewSetCursor): Ditto.
2934         (UIDelegate::webViewDidInvalidate): Ditto.
2935         (UIDelegate::setStatusText): Ditto.
2936         (UIDelegate::desktopNotificationsDelegate): Ditto.
2937         (UIDelegate::drawBackground): Ditto.
2938         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2939         (UIDelegate::didPressMissingPluginButton): Ditto.
2940         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2941         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2942         (LoadHTMLStringItem::invoke): Ditto.
2943         (ScriptItem::invoke): Ditto.
2944
2945 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2946
2947         Stylechecker: False positive on inline asm code.
2948         https://bugs.webkit.org/show_bug.cgi?id=130570
2949
2950         Reviewed by Csaba Osztrogonác.
2951
2952         Disable stylechecking in asm blocks.
2953
2954         * Scripts/webkitpy/style/checkers/cpp.py:
2955         (process_line):
2956         (_InlineASMState):
2957         (_InlineASMState.__init__):
2958         (_InlineASMState.process_line):
2959         (_InlineASMState.isInside):
2960         (_process_lines):
2961         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2962         (WebKitStyleTest.test_member_initialization_list):
2963
2964 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2965
2966         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2967         https://bugs.webkit.org/show_bug.cgi?id=131029
2968
2969         Reviewed by Philippe Normand.
2970
2971         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2972         tests and remove the getWebKit1TestResoucesDir() method.
2973
2974         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2975         (testDownloadLocalFile): Use Test::getResourcesDir().
2976         (testDownloadLocalFileError): Ditto.
2977         (serverCallback): Ditto.
2978         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2979         (serverCallback): Ditto.
2980         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2981         (httpServerCallback): Ditto.
2982         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2983         (serverCallback): Ditto.
2984         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2985         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2986         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2987         (Test::getWebKit1TestResoucesDir): Deleted.
2988
2989 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2990
2991         [WK2] HTTP authentication regression tests fail
2992         https://bugs.webkit.org/show_bug.cgi?id=81627
2993         <rdar://problem/11079296>
2994
2995         Reviewed by Anders Carlsson.
2996
2997         * WebKitTestRunner/TestController.h:
2998         * WebKitTestRunner/TestController.cpp:
2999         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3000         to pageLoaderClient structure.
3001         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3002         for password based authentication (we do get server trust challenges on some tests,
3003         which WKTR can't handle).
3004         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3005         calls won't be made, at least on CFNetwork based platforms.
3006         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3007         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3008         make sense to associate auth requests with individual resources - there can be
3009         multiple resources loading at once from the same protection space, so WebKit1 API
3010         that had a resource identifier was inherently racy.
3011
3012 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3013
3014         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3015         https://bugs.webkit.org/show_bug.cgi?id=131427
3016
3017         Reviewed by Gyuyoung Kim.
3018
3019         Since r166973, font path was changed.
3020
3021         * DumpRenderTree/PlatformEfl.cmake:
3022         * WebKitTestRunner/PlatformEfl.cmake:
3023
3024 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3025
3026         Fix the build-jsc build
3027         https://bugs.webkit.org/show_bug.cgi?id=131410
3028
3029         Reviewed by Michael Saboff.
3030
3031         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3032         WTF depends on it.
3033
3034 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3035
3036         [GTK] Remove WebKit1 unit tests
3037         https://bugs.webkit.org/show_bug.cgi?id=131359
3038
3039         Reviewed by Anders Carlsson.
3040
3041         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3042         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3043         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3044
3045         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3046         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3047         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3048         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3049         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3050         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3051         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3052         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3053         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3054         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3055         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3056         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3057         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3058         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3059         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3060         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3061         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3062         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3063         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3064         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3065         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3066         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3067         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3068         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3069         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3070         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3071         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3072         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3073         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3074         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3075         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3076         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3077         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3078         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3079         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3080         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3081         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3082         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3083
3084 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3085
3086         Unreviewed gardening (Take 2): Prevent users from attempting
3087         to build with known invalid cURL. 
3088
3089         * Scripts/webkitdirs.pm:
3090         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3091         7.33.0 (the known good version).
3092
3093 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3094
3095         [GTK] Remove DumpRenderTree and GtkLauncher
3096         https://bugs.webkit.org/show_bug.cgi?id=131373
3097
3098         Reviewed by Andreas Kling.
3099
3100         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3101         no longer necessary now that WebKit1 GTK+ will be removed.
3102
3103         * CMakeLists.txt:
3104         * DumpRenderTree/PlatformGTK.cmake: Removed.
3105         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3106         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3107         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3108         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3109         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3110         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3111         * DumpRenderTree/gtk/EventSender.h: Removed.
3112         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3113         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3114         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3115         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3116         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3117         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3118         * DumpRenderTree/gtk/TextInputController.h: Removed.
3119         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3120         * GtkLauncher/CMakeLists.txt: Removed.
3121         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3122         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3123         * GtkLauncher/main.c: Removed.
3124         * GtkLauncher/simple.svg: Removed.
3125         * GtkLauncher/text.html: Removed.
3126         * WebKitTestRunner/PlatformGTK.cmake:
3127         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3128         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3129         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3130
3131 2014-04-08  Mark Rowe  <mrowe@apple.com>
3132
3133         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3134         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3135
3136         Reviewed by Alexey Proskuryakov.
3137
3138         * Scripts/webkitdirs.pm:
3139         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3140         (execMacWebKitAppForDebugging): Ditto.
3141
3142 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3143
3144         Build bmalloc on iOS too
3145         https://bugs.webkit.org/show_bug.cgi?id=131381
3146
3147         Reviewed by Andreas Kling.
3148
3149         * Scripts/build-webkit:
3150
3151 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3152
3153         Unreviewed gardening: Prevent users from attempting
3154         to build with known invalid cURL.
3155
3156         * Scripts/webkitdirs.pm:
3157         (checkInstalledTools): Block build attempts with bad
3158         Cygwin tool set.
3159
3160 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3161
3162         Build bmalloc on Mac
3163         https://bugs.webkit.org/show_bug.cgi?id=131333
3164
3165         Reviewed by Mark Rowe.
3166
3167         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3168         (Note: Just testing Mac is not good enough because in this
3169         script 'Mac' means 'Mac or iOS'.)
3170
3171 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3172
3173         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3174         https://bugs.webkit.org/show_bug.cgi?id=130951
3175
3176         Reviewed by Geoffrey Garen.
3177
3178         * Scripts/run-javascriptcore-tests:
3179
3180 2014-04-06  Darin Adler  <darin@apple.com>
3181
3182         Rework CSS calc logic, fixing some reference count mistakes in Length
3183         https://bugs.webkit.org/show_bug.cgi?id=131280
3184
3185         Reviewed by Andreas Kling.
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3188         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3189
3190 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3191
3192         Enable WEB_REPLAY for PLATFORM(MAC)
3193         https://bugs.webkit.org/show_bug.cgi?id=130700
3194
3195         Reviewed by Timothy Hatcher.
3196
3197         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3198
3199 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3200
3201         [CMake] Include X11's include dirs in TestNetscapePlugin
3202         https://bugs.webkit.org/show_bug.cgi?id=131270
3203
3204         Reviewed by Martin Robinson.
3205
3206         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3207         TestNetscapePlugin includes WebCore code that includes X headers.
3208
3209 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3210
3211         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3212         <http://webkit.org/b/130986>
3213
3214         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3215         prefix to TileCache class names in exception list.
3216
3217 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3218
3219         [GTK] kill-old-processes should kill dbus-daemon processes
3220         https://bugs.webkit.org/show_bug.cgi?id=127352
3221
3222         Reviewed by Martin Robinson.
3223
3224         * BuildSlaveSupport/kill-old-processes:
3225         (main):
3226
3227 2014-04-04  Andres Gomez  <agomez@igalia.com>
3228
3229         [Win] Update obsolete packages in cygwin
3230         https://bugs.webkit.org/show_bug.cgi?id=126264
3231
3232         Reviewed by Brent Fulgham.
3233
3234         Removed "apache" and "minires" as the first has been replaced by
3235         "lighttpd" and the second is now integrated into
3236         "cygwin". Replaced the transitional and now obsolete "gcc" package
3237         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3238         since the newer version available is "2.7.3" which breaks the
3239         build due to some funniness with environment variable handling.
3240
3241         * CygwinDownloader/cygwin-downloader.py:
3242         * CygwinDownloader/cygwin-downloader.zip:
3243
3244 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3245
3246         check-webkit-style: Improve warnings on Objective-C @property syntax
3247         https://bugs.webkit.org/show_bug.cgi?id=131200
3248
3249         Reviewed by Dan Bernstein.
3250
3251         * Scripts/webkitpy/style/checkers/cpp.py:
3252         (check_spacing):
3253         (CppChecker):
3254         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3255         (CppStyleTest.test_spacing_in_objective_c_properties):
3256
3257 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3258
3259         Unreviewed. Moving my name to commiter section
3260
3261         * Scripts/webkitpy/common/config/contributors.json:
3262
3263 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3264
3265         Unreviewed. Add myself as a committer.
3266
3267         * Scripts/webkitpy/common/config/contributors.json:
3268
3269 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3270
3271         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3272         https://bugs.webkit.org/show_bug.cgi?id=130391
3273
3274         Reviewed by Gyuyoung Kim.
3275
3276         Change the implementation of the zoom functionality from ewk_view_scale_set
3277         to ewk_view_page_zoom_set.
3278
3279         * MiniBrowser/efl/main.c:
3280
3281 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3282
3283         [webkitpy] perf profiler does not understand --call-graph argument
3284         https://bugs.webkit.org/show_bug.cgi?id=131132
3285
3286         Reviewed by Ryosuke Niwa.
3287
3288         New versions of perf profiler have changed the argument from --call-graph to -g.
3289
3290         * Scripts/webkitpy/common/system/profiler.py:
3291         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3292         * Scripts/webkitpy/port/driver_unittest.py:
3293         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3294
3295 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3296
3297         Add EFL WK2 performance bot to build.webkit.org
3298         https://bugs.webkit.org/show_bug.cgi?id=131034
3299
3300         Fix after r166707, use "Perf" instead of "perf" for consistency.
3301
3302         Reviewed by Csaba Osztrogonác.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/config.json:
3305
3306 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3307
3308         Add EFL WK2 performance bot to build.webkit.org
3309         https://bugs.webkit.org/show_bug.cgi?id=131034
3310
3311         Reviewed by Csaba Osztrogonác.
3312
3313         * BuildSlaveSupport/build.webkit.org-config/config.json:
3314
3315 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3316
3317         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3318         https://bugs.webkit.org/show_bug.cgi?id=131151
3319
3320         Reviewed by Gyuyoung Kim.
3321
3322         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3323         (TouchEventInfo::TouchEventInfo):
3324         (sendTouchEvent):
3325         (addTouchPointCallback):
3326         (updateTouchPointCallback):
3327         (cancelTouchPointCallback):
3328         (releaseTouchPointCallback):
3329
3330 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3331
3332         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3333         <http://webkit.org/b/131045>
3334
3335         Reviewed by Daniel Bates.
3336
3337         * Scripts/filter-build-webkit:
3338         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3339         of clang, plus debug data for all DVTAssertions.
3340
3341 2014-04-01  Dean Jackson  <dino@apple.com>
3342
3343         Load Media Controls js/css from bundle
3344         https://bugs.webkit.org/show_bug.cgi?id=131086
3345
3346         Reviewed by Eric Carlson.
3347
3348         We're now putting CSS files into the bundle, so remove the test for them.
3349
3350         * Scripts/check-for-inappropriate-files-in-framework:
3351
3352 2014-04-02  Martin Hock  <mhock@apple.com>
3353
3354         Unify private browsing with sessions.
3355         https://bugs.webkit.org/show_bug.cgi?id=130099
3356
3357         Reviewed by Alexey Proskuryakov.
3358
3359         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3361         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3362         (TestWebKitAPI::didNavigateWithNavigationData):
3363         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3364         (TestWebKitAPI::TEST):
3365
3366         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3367         (TestWebKitAPI::didNavigateWithoutNavigationData):
3368         (TestWebKitAPI::didNavigateWithNavigationData):
3369         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3370         (TestWebKitAPI::TEST):
3371
3372 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3373
3374         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3375         https://bugs.webkit.org/show_bug.cgi?id=130343
3376
3377         Reviewed by Gustavo Noronha Silva.
3378
3379         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3380         of directories on the command line and look for all appropriate files in those directories for the
3381         GResource archive. Also make archive paths relative to those directories.
3382         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3383         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3384
3385 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3386
3387         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3388         https://bugs.webkit.org/show_bug.cgi?id=131106
3389
3390         Reviewed by Csaba Osztrogonác.
3391
3392         * Scripts/webkitpy/tool/commands/download.py:
3393         (AbstractRolloutPrepCommand._prepare_state):
3394         * Scripts/webkitpy/tool/commands/download_unittest.py:
3395         (test_prepare_rollout):
3396         (test_create_rollout):
3397         (test_create_rollout_resolved):
3398         (test_rollout):
3399
3400 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3401
3402         [EFL] Add option to use separate web process for new window in MiniBrowser
3403         https://bugs.webkit.org/show_bug.cgi?id=130190
3404
3405         Reviewed by Gyuyoung Kim.
3406
3407         New created window (CTRL + n) will be open in separated web process.
3408         This option is enabled by adding a flag (S/separate-process) with launching
3409         MiniBrowser.
3410
3411         * MiniBrowser/efl/main.c:
3412         (elm_main):
3413
3414 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3415
3416         [GTK] Move NEWS file to a new location
3417         https://bugs.webkit.org/show_bug.cgi?id=130901
3418
3419         Reviewed by Brent Fulgham.
3420
3421         * gtk/manifest.txt: Update the NEWS file path.
3422
3423 2014-04-01  Anders Carlsson  <andersca@apple.com>
3424
3425         Fix build.
3426
3427         * MiniBrowser/mac/WK2BrowserWindowController.m:
3428         (-[WK2BrowserWindowController awakeFromNib]):
3429         (-[WK2BrowserWindowController dealloc]):
3430         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3431
3432 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3433
3434         Unreviewed test gardening.
3435
3436         * Scripts/webkitpy/port/base_unittest.py:
3437         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3438
3439 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3440
3441         [CSS Exclusions] Remove exclusions parsing support
3442         https://bugs.webkit.org/show_bug.cgi?id=131046
3443
3444         Reviewed by David Hyatt.
3445
3446         * Scripts/webkitperl/FeatureList.pm:
3447
3448 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3449
3450         [GTK] Remove last reference to GTK+ WK1 EWS
3451         https://bugs.webkit.org/show_bug.cgi?id=131058
3452
3453         Reviewed by Martin Robinson.
3454
3455         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3456
3457         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3458
3459 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3460
3461         Add a 32bit JSC builder/tester.
3462         https://bugs.webkit.org/show_bug.cgi?id=131054
3463         
3464         Reviewed by Michael Saboff.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/config.json:
3467         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3468         (Compile32bitJSC):
3469         (Run32bitJSCTests):
3470         (Run32bitJSCTests.countFailures):
3471         (BuildAndTest32bitJSCFactory):
3472         (BuildAndTest32bitJSCFactory.__init__):
3473
3474 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3475
3476         [GTK] No longer build WebKit1 gtkdoc
3477         https://bugs.webkit.org/show_bug.cgi?id=130970
3478
3479         Reviewed by Anders Carlsson.
3480
3481         * gtk/common.py:
3482         (gtk_version_of_pkg_config_file): Deleted.
3483         * gtk/generate-gtkdoc:
3484         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3485         was only applicable for WebKit1.
3486         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3487
3488 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3489
3490         [GTK] Running minibrowser with url crashes in debug build
3491         https://bugs.webkit.org/show_bug.cgi?id=130492
3492
3493         Reviewed by Martin Robinson.
3494
3495         Update "uri-scheme" test not to use invalid URIs in it, so we
3496         don't get a mistmatch when comparing the original URI stored in
3497         the test class with the one returned by the WebKitWebView.
3498
3499         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3500         (testWebContextURIScheme): Update the test.
3501
3502 2014-04-01  Mihai Tica  <mitica@adobe.com>
3503
3504         Unreviewed: Add myself as a commiter to the contributors list.
3505
3506         * Scripts/webkitpy/common/config/contributors.json:
3507
3508 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3509
3510         [EFL][WK2] Extract the control of page background out of color_set
3511         https://bugs.webkit.org/show_bug.cgi?id=127539
3512
3513         Reviewed by Gyuyoung Kim.
3514
3515         Added an option(C) to change background color.
3516
3517         * MiniBrowser/efl/main.c:
3518         (window_create):
3519         (elm_main):
3520
3521 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3522
3523         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3524
3525         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3526
3527 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3528
3529         Unreviewed test correction after r166530.
3530
3531         * DumpRenderTree/mac/DumpRenderTree.mm:
3532         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3533         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3534
3535 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3536
3537         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3538         https://bugs.webkit.org/show_bug.cgi?id=130987
3539
3540         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3541         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3542
3543         Reviewed by Martin Robinson.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/config.json:
3546
3547 2014-03-31  Dean Jackson  <dino@apple.com>
3548
3549         Remove WEB_ANIMATIONS
3550         https://bugs.webkit.org/show_bug.cgi?id=130989
3551
3552         Reviewed by Simon Fraser.
3553
3554         Remove this feature flag until we plan to implement.
3555
3556         * Scripts/webkitperl/FeatureList.pm:
3557
3558 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3559
3560         Reduced Latched Scroll Test Flakiness
3561         https://bugs.webkit.org/show_bug.cgi?id=130983
3562
3563         Reviewed by Darin Adler.
3564
3565         * DumpRenderTree/mac/DumpRenderTree.mm:
3566         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3567         * DumpRenderTree/mac/EventSendingController.mm:
3568         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3569         with high resolution flags turned on.
3570         * WebKitTestRunner/mac/EventSenderProxy.mm:
3571         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3572
3573 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3574
3575         run-webkit-tests should have a --no-timeout option
3576         https://bugs.webkit.org/show_bug.cgi?id=128286
3577
3578         Reviewed by Joseph Pecoraro.
3579
3580         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3581         (Worker._run_test): Renaming _run_test_with_timeout()
3582         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3583         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3584         (Worker._run_test_in_this_thread):
3585         (Worker._run_test_with_timeout): Deleted.
3586         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3587         (parse_args): Added the --no-timeout option
3588
3589 2014-03-31  Samuel White  <samuel_white@apple.com>
3590
3591         AX: Need ability to get line range for text marker.
3592         https://bugs.webkit.org/show_bug.cgi?id=130906
3593
3594         Reviewed by Chris Fleizach.
3595
3596         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3597
3598         * DumpRenderTree/AccessibilityUIElement.cpp:
3599         (lineTextMarkerRangeForTextMarkerCallback):
3600         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3601         (AccessibilityUIElement::getJSClass):
3602         * DumpRenderTree/AccessibilityUIElement.h:
3603         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3604         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3605         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3606         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3607         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3608         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3609         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3610         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3611         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3612         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3613         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3614         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3615
3616 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3617
3618         More validation for FTL inline caches
3619         https://bugs.webkit.org/show_bug.cgi?id=130948
3620
3621         Reviewed by Geoffrey Garen.
3622
3623         * Scripts/run-jsc-stress-tests:
3624
3625 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3626
3627         [GTK] Do not run WebKit1 unit tests by default
3628         https://bugs.webkit.org/show_bug.cgi?id=130968
3629
3630         Reviewed by Martin Robinson.
3631
3632         * Scripts/run-gtk-tests:
3633         (TestRunner):
3634
3635 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3636
3637         [GTK] Remove scripts code only applicable to autotools
3638         https://bugs.webkit.org/show_bug.cgi?id=130841
3639
3640         Reviewed by Anders Carlsson.
3641
3642         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3643         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3644         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3645         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3646         * gtk/find-make-dist-errors: Removed.
3647         * gtk/generate-feature-defines-files: Removed.
3648         * gtk/manifest.txt: No longer need to consider autotools files.
3649
3650 2014-03-30  Andy Estes  <aestes@apple.com>
3651
3652         Fix two failing layout tests on Mountain Lion after r166466.
3653
3654         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3655         (-[DownloadDelegate _downloadDidStart:]):
3656
3657 2014-03-30  Andy Estes  <aestes@apple.com>
3658
3659         [Cocoa] Add an originatingWebView property to _WKDownload
3660         https://bugs.webkit.org/show_bug.cgi?id=130945
3661
3662         Reviewed by Anders Carlsson.
3663
3664         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3665         (-[DownloadDelegate _downloadDidStart:]):
3666         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3667         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3668         (TEST):
3669
3670 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3671
3672         Land the stackmap register liveness glue with the uses of the liveness disabled
3673         https://bugs.webkit.org/show_bug.cgi?id=130924
3674
3675         Reviewed by Oliver Hunt.
3676
3677         * Scripts/run-jsc-stress-tests:
3678
3679 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3680
3681         Update WebKit1.StringTruncator for Mountain Lion.
3682
3683         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3684         due to different font metrics on 10.8.
3685
3686 2014-03-28  Darin Adler  <darin@apple.com>
3687
3688         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3689         https://bugs.webkit.org/show_bug.cgi?id=130889
3690
3691         Reviewed by Alexey Proskuryakov.
3692
3693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3694         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3695         WebStringTruncator methods; should be good for a start. These are dependent on the
3696         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3697
3698 2014-03-28  Martin Hock  <mhock@apple.com>
3699
3700         Unreviewed. Add myself as a committer.
3701
3702         * Scripts/webkitpy/common/config/contributors.json:
3703
3704 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3705
3706         Remove WebKit1 GTK+ bots
3707         https://bugs.webkit.org/show_bug.cgi?id=130904
3708
3709         Reviewed by Anders Carlsson.
3710
3711         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3712         all bots are testing WebKit2 only.
3713         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3714         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3715         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3716         * Scripts/webkitpy/port/builders.py: Ditto.
3717         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3718         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3719
3720 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3721
3722         Remove Brian Burg's apple.com email address.
3723
3724         * Scripts/webkitpy/common/config/contributors.json:
3725
3726 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3727
3728         bisect-builds should print Trac 'changeset' URL if only one build is detected
3729         <http://webkit.org/b/130903>
3730
3731         Reviewed by Dan Bernstein.
3732
3733         * Scripts/bisect-builds:
3734         (printTracLink): Print a direct link to the Trac 'changeset'
3735         URL if there is only one revision in the range.
3736
3737 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3738
3739         [EFL] Bump glib version from 2.36 to 2.38 
3740         https://bugs.webkit.org/show_bug.cgi?id=130886
3741
3742         Reviewed by Csaba Osztrogonác.
3743
3744         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3745         we need to bump glib version up to 2.38 as gtk port.
3746
3747         * efl/jhbuild.modules:
3748
3749 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3750
3751         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3752
3753         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3754         the globalhistory directory.
3755
3756         Reviewed by Sam Weinig.
3757
3758         * WebKitTestRunner/TestController.cpp:
3759         (WTR::TestController::TestController):
3760         (WTR::TestController::initialize): Set the history client.
3761         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3762         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3763         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3764         and we don't yet have API to access the data in question.
3765         (WTR::TestController::didPerformClientRedirect):
3766         (WTR::TestController::didPerformServerRedirect):
3767         (WTR::TestController::didUpdateHistoryTitle):
3768         * WebKitTestRunner/TestController.h:
3769         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3770         * WebKitTestRunner/TestInvocation.cpp:
3771         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3772         (WTR::TestInvocation::invoke):
3773
3774 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3775
3776         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
3777
3778         * Scripts/build-webkit:
3779         * Scripts/copy-webkitlibraries-to-product-directory:
3780
3781 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3782
3783         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3784         https://bugs.webkit.org/show_bug.cgi?id=130867
3785         <rdar://problem/16432456> 
3786
3787         Reviewed by Mark Hahnenberg.
3788
3789         * Scripts/build-webkit:
3790         * Scripts/copy-webkitlibraries-to-product-directory:
3791
3792 2014-03-26  Andy Estes  <aestes@apple.com>
3793
3794         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3795         https://bugs.webkit.org/show_bug.cgi?id=130805
3796
3797         Reviewed by Dan Bernstein.
3798
3799         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3800         (-[DownloadDelegate _download:didReceiveResponse:]):
3801         (-[DownloadDelegate _downloadDidFinish:]):
3802         (runTest):
3803         (TEST):
3804         (-[FailingDownloadDelegate _downloadDidFinish:]):
3805         (-[FailingDownloadDelegate _download:didFailWithError:]):
3806         (-[FailingDownloadDelegate _downloadDidCancel:]):
3807         (-[CancelledDownloadDelegate _downloadDidStart:]):
3808         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3809         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3810         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3811         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3812         (-[DownloadDelegate sourceURL]): Deleted.
3813         (runTestWithNavigationDelegate): Deleted.
3814
3815 2014-03-26  Anders Carlsson  <andersca@apple.com>
3816
3817         Change MiniBrowser to hold on to window controllers instead of windows
3818         https://bugs.webkit.org/show_bug.cgi?id=130797
3819
3820         Reviewed by Oliver Hunt.
3821
3822         * MiniBrowser/mac/AppDelegate.h:
3823         * MiniBrowser/mac/AppDelegate.m:
3824         (-[BrowserAppDelegate init]):
3825         (-[BrowserAppDelegate newWindow:]):
3826         (-[BrowserAppDelegate browserWindowWillClose:]):
3827         (-[BrowserAppDelegate applicationWillTerminate:]):
3828         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3829
3830 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3831
3832         Unreviewed, rolling out r166264.
3833         https://bugs.webkit.org/show_bug.cgi?id=130785
3834
3835         Broke some window.opener tests for WK2 Mavericks (Requested by
3836         brrian__ on #webkit).
3837
3838         Reverted changeset:
3839
3840         "Web Replay: resource unique identifiers should be unique-per-
3841         frame, not globally"
3842         https://bugs.webkit.org/show_bug.cgi?id=130632
3843         http://trac.webkit.org/changeset/166264
3844
3845 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3846
3847         [CSS Shapes] Remove shape-inside support
3848         https://bugs.webkit.org/show_bug.cgi?id=130698
3849
3850         Reviewed by David Hyatt.
3851
3852         * Scripts/webkitperl/FeatureList.pm:
3853
3854 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3855
3856         Unreviewed. Add myself as a committer.
3857
3858         * Scripts/webkitpy/common/config/contributors.json:
3859
3860 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3861
3862         run-launcher is Perl script so use elsif and not elif
3863         https://bugs.webkit.org/show_bug.cgi?id=130771
3864
3865         Reviewed by Carlos Garcia Campos.
3866
3867         * Scripts/run-launcher:
3868
3869 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3870
3871         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3872         https://bugs.webkit.org/show_bug.cgi?id=130575
3873
3874         Reviewed by Mario Sanchez Prada.
3875
3876         Change ATK version to 2.11.92. Adjust current implementation.
3877
3878         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3879         (AccessibilityUIElement::intValue):
3880         (AccessibilityUIElement::minValue):
3881         (AccessibilityUIElement::maxValue):
3882         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3883         (WTR::AccessibilityUIElement::intValue):
3884         (WTR::AccessibilityUIElement::minValue):
3885         (WTR::AccessibilityUIElement::maxValue):
3886         * efl/jhbuild.modules:
3887         * gtk/jhbuild.modules:
3888
3889 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3890
3891         [GTK] The gnumake package is no longer needed in jhbuild
3892         https://bugs.webkit.org/show_bug.cgi?id=130121
3893
3894         Reviewed by Martin Robinson.
3895
3896         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3897         for a debug build cmake/system-gnumake worked just fine for me.
3898
3899         * gtk/jhbuild.modules: Removed gnumake.
3900         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3901         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3902
3903 2014-03-25  Andy Estes  <aestes@apple.com>
3904
3905         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3906
3907         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3908         (-[DownloadDelegate _download:didReceiveData:]):
3909         (-[DownloadDelegate _downloadDidFinish:]):
3910
3911 2014-03-25  Brian Burg  <bburg@apple.com>
3912
3913         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3914         https://bugs.webkit.org/show_bug.cgi?id=130623
3915
3916         Reviewed by Timothy Hatcher.
3917
3918         The resource loader callback dumping routines assumed that resource identifiers
3919         were globally unique. Its map of resource identifiers to URLs must also track the
3920         frame associated with the resource.
3921
3922         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3923         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3924         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3925         stable as long as the frame is valid.
3926         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3927         (WTR::InjectedBundlePage::willSendRequestForFrame):
3928         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3929         (WTR::InjectedBundlePage::didFinishLoadForResource):
3930         (WTR::InjectedBundlePage::didFailLoadForResource):
3931
3932 2014-03-25  Andy Estes  <aestes@apple.com>
3933
3934         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3935
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3937         (-[DownloadDelegate _download:didReceiveResponse:]):
3938         (-[DownloadDelegate _download:didReceiveData:]):
3939
3940 2014-03-25  Andy Estes  <aestes@apple.com>
3941
3942         Add some debug logging to an API test that's failing on Mountain Lion.
3943
3944         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3945         (-[DownloadDelegate _download:didReceiveResponse:]):
3946         (-[DownloadDelegate _downloadDidFinish:]):
3947
3948 2014-03-25  Anders Carlsson  <andersca@apple.com>
3949
3950         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3951         https://bugs.webkit.org/show_bug.cgi?id=130732
3952
3953         Reviewed by Tim Horton.
3954
3955         * MiniBrowser/mac/WK2BrowserWindowController.m:
3956         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3957
3958 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3959
3960         [GTK] Remove the autotools build
3961         https://bugs.webkit.org/show_bug.cgi?id=130717
3962
3963         Reviewed by Anders Carlsson.
3964
3965         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3966         * GNUmakefile.am: Removed.
3967         * GtkLauncher/GNUmakefile.am: Removed.
3968         * GtkLauncher/main.c: Remove references to the autotools configure file.
3969         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3970         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3971         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3972         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3973         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3974         * Scripts/build-webkit: No longer handle autotools.
3975         * Scripts/run-gtk-tests: Ditto.
3976         (TestRunner._setup_testing_environment):
3977         * Scripts/run-launcher: Ditto.
3978         * Scripts/webkitdirs.pm: Ditto.
3979         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3980         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3981         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3982         * Scripts/webkitpy/style/checker.py:
3983         * TestWebKitAPI/GNUmakefile.am: Removed.
3984         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3985         * WebKitTestRunner/GNUmakefile.am: Removed.
3986         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3987         * gtk/GNUmakefile.am: Removed.
3988         * gtk/common.py: Remove checks for the autotools build.
3989         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3990
3991 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3992
3993         prepare-ChangeLog throws false positive warnings for modified files.
3994         https://bugs.webkit.org/show_bug.cgi?id=130687
3995
3996         Reviewed by Darin Adler.
3997
3998         * Scripts/prepare-ChangeLog:
3999         (originalFile): Ignore git commit paremeter.
4000         We don't need this to get the unmodified file.
4001         (extractLineRangeBeforeChange):
4002         Simplify the if statement. Follow-up after r166189.
4003
4004 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
4005
4006         [EFL] Add ARM64 build support
4007         https://bugs.webkit.org/show_bug.cgi?id=130506
4008
4009         Rubber stamped by Gyuyoung Kim.
4010
4011         * Scripts/webkitdirs.pm:
4012         (isARM): Detect aarch64 as ARM.
4013
4014 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4015
4016         [webkitpy] Improve _parse_bug_description to recognize more descriptions
4017         https://bugs.webkit.org/show_bug.cgi?id=130137
4018
4019         Reviewed by Csaba Osztrogonác.
4020
4021         * Scripts/webkitpy/common/checkout/changelog.py:
4022         (ChangeLogEntry._parse_bug_description):
4023         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4024         (test_parse_log_entries_from_changelog):
4025         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4026         (CheckoutTest.test_commit_info_for_revision):
4027
4028 2014-03-24  Andy Estes  <aestes@apple.com>
4029
4030         Fix the iOS build of TestWebKitAPI.
4031
4032         * TestWebKitAPI/Configurations/Base.xcconfig:
4033         * TestWebKitAPI/PlatformUtilities.h:
4034
4035 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
4036
4037         Fix prepare-ChangeLog after r166156.
4038         https://bugs.webkit.org/show_bug.cgi?id=130674
4039
4040         Reviewed by Darin Adler.
4041
4042         * Scripts/prepare-ChangeLog:
4043         (generateFunctionLists):
4044         (extractLineRangeBeforeChange):
4045
4046 2014-03-24  Andy Estes  <aestes@apple.com>
4047
4048         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
4049         https://bugs.webkit.org/show_bug.cgi?id=129322
4050
4051         Reviewed by Anders Carlsson.
4052
4053         Add an API test suite for _WKDownload.
4054
4055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4056         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
4057         (-[DownloadDelegate initWithSourceURL:]):
4058         (-[DownloadDelegate sourceURL]):
4059         (-[DownloadDelegate _downloadDidStart:]):
4060         (-[DownloadDelegate _download:didReceiveResponse:]):
4061         (-[DownloadDelegate _download:didReceiveData:]):
4062         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4063         (-[DownloadDelegate _downloadDidFinish:]):
4064         (TEST):
4065         (runTestWithNavigationDelegate):
4066         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4067         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4068
4069 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
4070
4071         filter-build-webkit: reduce unfiltered output
4072         https://bugs.webkit.org/show_bug.cgi?id=130485
4073
4074         Reviewed by Brent Fulgham.
4075
4076         * Scripts/filter-build-webkit:
4077         (shouldIgnoreLine):
4078
4079 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
4080
4081         prepare-ChangeLog should list functions that have been removed too.
4082         https://bugs.webkit.org/show_bug.cgi?id=130508
4083
4084         Reviewed by Darin Adler.
4085
4086         The prepare-ChangeLog does not list the deleted functions in the Changelog.
4087         We have to read the functions and the line ranges of them from the source
4088         before the change, then search for overlaps between them and the changed
4089         line ranges from diff.
4090
4091         * Scripts/prepare-ChangeLog:
4092         (originalFile): Get original source command.
4093         (generateFunctionLists): Collect deleted functions too.
4094         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
4095         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
4096         deleted functions ranges too.
4097         (extractLineRange): Renamed to extractLineRangeAfterChange.
4098
4099 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
4100
4101         Move all EFL typedefs into EflTypedefs.h.
4102         https://bugs.webkit.org/show_bug.cgi?id=130511
4103
4104         Reviewed by Gyuyoung Kim.
4105
4106         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
4107         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
4108         * WebKitTestRunner/PlatformWebView.h: Ditto.
4109
4110 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
4111
4112         Don't flush compositing layers within FrameView::willPaintContents()
4113         https://bugs.webkit.org/show_bug.cgi?id=130627
4114         <rdar://problem/16368869>
4115
4116         Reviewed by Sam Weinig.
4117         
4118         Fix DRT to correctly render tests with layers now that FrameView::paintContents
4119         does not flush.
4120         
4121         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
4122         into an explicit function called before dumping. 
4123         
4124         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
4125         are flushed to CA. They will be pushed to the window by snapshotting.
4126
4127         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4128         Fix weird path to IOKit.framework.
4129         * DumpRenderTree/mac/DumpRenderTree.mm:
4130         (updateDisplay):
4131         (dump):
4132         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4133         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
4134         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
4135
4136 2014-03-21  David Kilzer  <ddkilzer@apple.com>
4137
4138         fix-blink-patch: tool to fix up renamed directory paths in Blink
4139         <http://webkit.org/b/130609>
4140
4141         Reviewed by Ryosuke Niwa.
4142
4143         Usage: cat blink.patch | fix-blink-patch | svn-apply
4144
4145         * Scripts/fix-blink-patch: Added.
4146
4147 2014-03-21  Darin Adler  <darin@apple.com>
4148
4149         Remove use of deprecatedCharacters in WebKit API tests
4150         https://bugs.webkit.org/show_bug.cgi?id=130602
4151
4152         Reviewed by Antti Koivisto.
4153
4154         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4155         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
4156         (TestWebKitAPI::expectEmpty): Use characters8.
4157         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
4158
4159         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4160         Removed the test that is entirely about 16-bit conversion since that's basically a test of
4161         the deprecatedCharacters function itself, which we are about to delete.
4162
4163 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4164
4165         [webkitpy] Fix has_valid_reviewer()
4166         https://bugs.webkit.org/show_bug.cgi?id=130589
4167
4168         Reviewed by Csaba Osztrogonác.
4169
4170         * Scripts/webkitpy/common/checkout/changelog.py:
4171         (ChangeLogEntry.has_valid_reviewer):
4172         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4173         (test_has_valid_reviewer):
4174         * Scripts/webkitpy/common/config/committers.py:
4175         (CommitterList._reviewer_only):
4176         (CommitterList.committer_by_name):
4177         (CommitterList.reviewer_by_email):
4178         (CommitterList):
4179         (CommitterList.reviewer_by_name):
4180
4181 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4182
4183         Add cache support for jhbuild
4184         https://bugs.webkit.org/show_bug.cgi?id=130588
4185
4186         Reviewed by Csaba Osztrogonác.
4187
4188         * jhbuild/jhbuildrc_common.py:
4189         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
4190
4191 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4192
4193         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
4194         https://bugs.webkit.org/show_bug.cgi?id=130504
4195
4196         Reviewed by Martin Robinson.
4197
4198         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
4199         CMake if not specified.
4200         * Scripts/webkitdirs.pm:
4201         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
4202         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
4203
4204 2014-03-21  Andreas Kling  <akling@apple.com>
4205
4206         RetainPtr API test should use CFArray instead of CFString for testing.
4207         <rdar://problem/16384899>
4208
4209         Unreviewed bot fix.
4210
4211         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4212         (TestWebKitAPI::TEST):
4213         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4214         (TestWebKitAPI::TEST):
4215
4216 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
4217
4218         Move to using std::unique_ptr for EFL objects.
4219         https://bugs.webkit.org/show_bug.cgi?id=129853
4220
4221         Reviewed by Gyuyoung Kim.
4222
4223         EflUniquePtr is a template alias of std::unique_ptr
4224         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
4225         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
4226
4227         * DumpRenderTree/efl/DumpRenderTree.cpp:
4228         (main):
4229         * ImageDiff/efl/ImageDiff.cpp:
4230         (initEfl):
4231         (main):
4232
4233 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
4234
4235         Unreviewed buildfix after r165983 for non Cocoa platforms
4236
4237         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
4238
4239         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
4240         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4241         * WebKitTestRunner/TestController.cpp:
4242
4243 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
4244
4245         [GTK][CMake] Add support for building with Clang
4246         https://bugs.webkit.org/show_bug.cgi?id=130260
4247
4248         Reviewed by Martin Robinson.
4249
4250         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
4251         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
4252         included GTest framework headers.
4253         * gtk/generate-gtkdoc:
4254         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
4255         in case of using Clang since that is now set by the CMake rule.
4256
4257 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
4258
4259         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4260         https://bugs.webkit.org/show_bug.cgi?id=130476
4261
4262         Reviewed by Anders Carlsson.
4263         
4264         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
4265
4266         * MiniBrowser/mac/WK1BrowserWindowController.m:
4267         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4268         Remove log.
4269         * MiniBrowser/mac/WK2BrowserWindowController.m:
4270         (-[WK2BrowserWindowController awakeFromNib]):
4271         (-[WK2BrowserWindowController validateMenuItem:]):
4272         (-[WK2BrowserWindowController reload:]):
4273         Hook up reload.
4274         (-[WK2BrowserWindowController toggleZoomMode:]):
4275         (-[WK2BrowserWindowController resetZoom:]):
4276         (-[WK2BrowserWindowController canResetZoom]):
4277         (-[WK2BrowserWindowController currentZoomFactor]):
4278         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
4279         (-[WK2BrowserWindowController canZoomIn]):
4280         (-[WK2BrowserWindowController canZoomOut]):
4281
4282 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
4283
4284         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
4285         https://bugs.webkit.org/show_bug.cgi?id=130463
4286
4287         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
4288
4289 2014-03-18  Samuel White  <samuel_white@apple.com>
4290
4291         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
4292         https://bugs.webkit.org/show_bug.cgi?id=130250
4293
4294         Reviewed by Chris Fleizach.
4295
4296         Added ability to toggle enhanced accessibility on and off to support tests that require it.
4297
4298         * DumpRenderTree/AccessibilityController.cpp:
4299         (enableEnhancedAccessibilityCallback):
4300         (getEnhancedAccessibilityEnabledCallback):
4301         (AccessibilityController::getJSClass):
4302         * DumpRenderTree/AccessibilityController.h:
4303         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4304         (AccessibilityController::enableEnhancedAccessibility):
4305         (AccessibilityController::enhancedAccessibilityEnabled):
4306         * DumpRenderTree/ios/AccessibilityCon