[WTF] Align assumption in RunLoopWin to the other platform's RunLoop
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2
3         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
4         https://bugs.webkit.org/show_bug.cgi?id=181151
5
6         Reviewed by Don Olmstead.
7
8         * TestWebKitAPI/CMakeLists.txt:
9         * TestWebKitAPI/PlatformWin.cmake:
10         Enable TestWTF RunLoop tests in all platforms.
11
12         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
13         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
14         (TestWebKitAPI::DerivedOneShotTimer::fired):
15         (TestWebKitAPI::TEST):
16         Only a few platforms support nested RunLoop.
17
18         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
19         (TestWebKitAPI::DerivedRepeatingTimer::fired):
20
21 2019-03-10  David Quesada  <david_quesada@apple.com>
22
23         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
24         https://bugs.webkit.org/show_bug.cgi?id=152480
25
26         Reviewed by Chris Dumez.
27
28         Add a unit test based on Daniel Bates's test case that starts a download, ensures
29         there are no additional references to the process pool besides the one held by
30         the download, waits for the download to finish (in the sense that the
31         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
32         measure, also check that the process pool has been deallocated at the end of the
33         test. The test wouldn't be meaningful if the process pool were still alive.
34
35         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
36         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
37         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
38             The download will be canceled because the delegate does not implement the
39             method to decide the download's destination, so this is where we know the
40             DownloadProxyMap is done with the DownloadProxy.
41         (TEST):
42
43 2019-03-08  Chris Dumez  <cdumez@apple.com>
44
45         Add support for Device Orientation / Motion permission API
46         https://bugs.webkit.org/show_bug.cgi?id=195329
47         <rdar://problem/47645367>
48
49         Reviewed by Geoffrey Garen.
50
51         Add test infrastructure to help test the Device Orientation / Motion permission API.
52
53         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
54         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
55         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
56         * WebKitTestRunner/InjectedBundle/TestRunner.h:
57         * WebKitTestRunner/TestController.cpp:
58         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
59         (WTR::TestController::createWebViewWithOptions):
60         (WTR::TestController::resetStateToConsistentValues):
61         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
62         * WebKitTestRunner/TestController.h:
63         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
64         * WebKitTestRunner/TestInvocation.cpp:
65         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
66
67 2019-03-08  Saam barati  <sbarati@apple.com>
68
69         Add a compare-results script to compare benchmark results
70         https://bugs.webkit.org/show_bug.cgi?id=195486
71         <rdar://problem/48723397>
72
73         Reviewed by Geoffrey Garen.
74
75         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
76         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
77         to extend it to learn about our other benchmarks.
78
79         * Scripts/compare-results: Added.
80         (readJSONFile):
81         (detectJetStream2):
82         (JetStream2Results):
83         (detectSpeedometer2):
84         (Speedometer2Results):
85         (detectPLT5):
86         (PLT5Results):
87         (detectBenchmark):
88         (biggerIsBetter):
89         (ttest):
90         (getOptions):
91         (main):
92
93 2019-03-08  Stephanie Lewis  <slewis@apple.com>
94
95         Ensure old tab state is cleared between iterations of run-benchmark
96         https://bugs.webkit.org/show_bug.cgi?id=195393
97         <rdar://problem/46885583>
98
99         Reviewed by Dewei Zhu.
100
101         a) ensure the default to restore state is not set
102         b) terminate Safari correctly
103         c) Set the system default to ignore Persistent State in Safari
104
105         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
106         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
107         (OSXBrowserDriver.prepare_env): 
108         (OSXBrowserDriver.restore_env):
109         (OSXBrowserDriver.close_browsers):
110         (OSXBrowserDriver._terminate_processes):
111         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
112         (OSXChromeDriver):
113         (OSXChromeCanaryDriver):
114         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
115         (OSXFirefoxDriver):
116         (OSXFirefoxNightlyDriver):
117         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
118         (OSXSafariDriver):
119         (OSXSafariDriver.prepare_env):
120
121 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
122
123         [GTK] Several InputMethodFilter tests are failing
124         https://bugs.webkit.org/show_bug.cgi?id=195408
125
126         Reviewed by Carlos Garcia Campos.
127
128         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
129         Regressed in r241751.
130         Hexadecimal values of keycodes are expressed now in upper letters.
131         Composited characters should be cast to UTF8 strings.
132
133         (TestWebKitAPI::TEST):
134
135 2019-03-07  Tomas Popela  <tpopela@redhat.com>
136
137         [GTK] Make Tools/gtkdoc python3 compatible
138         https://bugs.webkit.org/show_bug.cgi?id=195359
139
140         Reviewed by Carlos Garcia Campos.
141
142         * gtkdoc/generate-gtkdoc:
143         ConfigParser was reworked in Python 3.2 so we have adapt the code to
144         work with Python 2 and 3.
145         (get_gtkdoc_module_paths):
146         The iteritems() was removed in Python 3, so let's use items() that's
147         available in Python 2 and 3.
148         (get_generator_for_config):
149         * gtkdoc/gtkdoc.py:
150         (GTKDoc._run_command):
151         The sys.stdout.write() is expecting str in Python 3 and not bytes
152         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
153         for passing the bytes there.
154
155 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
156
157         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
158         https://bugs.webkit.org/show_bug.cgi?id=195346
159         <rdar://problem/48667048>
160
161         Unreviewed build fix for clang-cl.
162
163         * DumpRenderTree/win/DumpRenderTree.cpp:
164         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
165
166 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
167
168         requestAnimationFrame should execute before the next frame
169         https://bugs.webkit.org/show_bug.cgi?id=177484
170
171         Reviewed by Simon Fraser.
172
173         Add trace points for the page RenderingUpdate.
174
175         * Tracing/SystemTracePoints.plist:
176
177 2019-03-07  Zalan Bujtas  <zalan@apple.com>
178
179         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
180         https://bugs.webkit.org/show_bug.cgi?id=195353
181         <rdar://problem/48626394>
182
183         Reviewed by Simon Fraser.
184
185         * WebKitTestRunner/ios/TestControllerIOS.mm:
186         (WTR::TestController::platformResetPreferencesToConsistentValues):
187
188 2019-03-07  John Wilander  <wilander@apple.com>
189
190         Resource Load Statistics: Make it possible to purge only script-accessible cookies
191         https://bugs.webkit.org/show_bug.cgi?id=195383
192         <rdar://problem/48570136>
193
194         Reviewed by Brent Fulgham.
195
196         This patch adds test infrastructure to purge only script-accessible cookies,
197         including a new testRunner function called statisticsDeleteCookiesForHost().git a
198
199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
201         (WTR::TestRunner::statisticsDeleteCookiesForHost):
202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
203         * WebKitTestRunner/TestController.cpp:
204         (WTR::TestController::statisticsDeleteCookiesForHost):
205         * WebKitTestRunner/TestController.h:
206         * WebKitTestRunner/TestInvocation.cpp:
207         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
208
209 2019-03-07  Commit Queue  <commit-queue@webkit.org>
210
211         Unreviewed, rolling out r242354.
212         https://bugs.webkit.org/show_bug.cgi?id=195402
213
214         breaks layout tests in all configurations (Requested by
215         zdobersek on #webkit).
216
217         Reverted changeset:
218
219         "[WPE] Enable web process sandbox"
220         https://bugs.webkit.org/show_bug.cgi?id=195169
221         https://trac.webkit.org/changeset/242354
222
223 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
224
225         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
226         https://bugs.webkit.org/show_bug.cgi?id=195346
227
228         Reviewed by Fujii Hironori.
229
230         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
231         (TestWebKitAPI::TEST):
232         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
233
234         * DumpRenderTree/win/DumpRenderTree.cpp:
235         (findFontFallback):
236         (addFontFallbackIfPresent):
237         (removeFontFallbackIfPresent):
238         (main):
239         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
240         (TestWebKitAPI::Util::moduleDirectory):
241         (TestWebKitAPI::Util::createInjectedBundlePath):
242         Use wchar helpers as needed.
243
244 2019-03-06  Rob Buis  <rbuis@igalia.com>
245
246         Consider supporting the `referrerpolicy` attribute.
247         https://bugs.webkit.org/show_bug.cgi?id=179053
248
249         Reviewed by Darin Adler.
250
251         Add a runtime flag for referrerpolicy attribute.
252
253         * DumpRenderTree/mac/DumpRenderTree.mm:
254         (enableExperimentalFeatures):
255
256 2019-03-05  Daniel Bates  <dabates@apple.com>
257
258         Update expected API test result following r242379
259         (https://bugs.webkit.org/show_bug.cgi?id=195125)
260
261         Update expected x-coordinate of selection rect now that the left padding of
262         a textarea is sized in ems (so dependent on the font size) just like the left
263         padding of a text field.
264
265         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
266         (TestWebKitAPI::TEST):
267
268 2019-03-05  David Quesada  <david_quesada@apple.com>
269
270         [WK2] It should be possible to follow links with 'download' attributes
271         https://bugs.webkit.org/show_bug.cgi?id=195145
272         rdar://problem/48462642
273
274         Reviewed by Alex Christensen.
275
276         Add a unit test to verify that activating links with 'download' attributes now
277         navigates to the linked resource, rather than starts downloading it. Add another
278         to verify that it is still possible to explicitly download the link via the
279         'Download' navigation action policy.
280
281         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
282         (-[DownloadAttributeTestDelegate init]):
283         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
284         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
285         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
286         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
287         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
288         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
289         (TEST):
290         * WebKitTestRunner/TestController.cpp:
291         (WTR::TestController::decidePolicyForNavigationAction):
292         * WebKitTestRunner/TestController.h:
293
294 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
295
296         [Curl] Implement Cookie Accept Policy.
297         https://bugs.webkit.org/show_bug.cgi?id=191645
298
299         Reviewed by Fujii Hironori.
300
301         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
302         (TestWebKitAPI::Curl::TEST_F):
303
304 2019-03-05  Youenn Fablet  <youenn@apple.com>
305
306         Rename requestCacheStorageSpace to requestStorageSpace
307         https://bugs.webkit.org/show_bug.cgi?id=195282
308
309         Reviewed by Chris Dumez.
310
311         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
312         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
313         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
314
315 2019-03-05  Brady Eidson  <beidson@apple.com>
316
317         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
318         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
319
320         Reviewed by Tim Horton.
321
322         Loading a file: URL into a WKWebView and then loading another file: url from a completely
323         different directory into that same WKWebView should work.
324
325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
326         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
327
328 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
329
330         Add WeakHashSet
331         https://bugs.webkit.org/show_bug.cgi?id=195152
332
333         Reviewed by Antti Koivisto.
334
335         Added tests for WeakHashSet.
336
337         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
338         (TestWebKitAPI::Base::Base): Moved.
339         (TestWebKitAPI::Derived::foo): Moved.
340         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
341         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
342         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
343         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
344
345 2019-03-04  Chris Dumez  <cdumez@apple.com>
346
347         Do not share WebProcesses between private and regular sessions
348         https://bugs.webkit.org/show_bug.cgi?id=195189
349         <rdar://problem/48421064>
350
351         Reviewed by Alex Christensen.
352
353         Add API test coverage.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
356         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
357
358 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
359
360         [WPE] Enable web process sandbox
361         https://bugs.webkit.org/show_bug.cgi?id=195169
362
363         Reviewed by Daniel Bates.
364
365         * wpe/install-dependencies:
366         * wpe/jhbuild.modules:
367
368 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
369
370         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
371         https://bugs.webkit.org/show_bug.cgi?id=195206
372
373         Reviewed by Žan Doberšek.
374
375         Add a new test case.
376
377         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
378         (testJSCClass):
379
380 2019-03-04  Charlie Turner  <cturner@igalia.com>
381
382         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
383         https://bugs.webkit.org/show_bug.cgi?id=194898
384
385         Reviewed by Žan Doberšek.
386
387         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
388         a GCC extension that permits arithmetic on void* pointer. Inline
389         the macro until this issue is fixed upstream.
390
391 2019-03-03  Tim Horton  <timothy_horton@apple.com>
392
393         Rid the world of WK_API_ENABLED
394         https://bugs.webkit.org/show_bug.cgi?id=195263
395
396         Reviewed by Dan Bernstein.
397
398         List of changed files elided because it's useless.
399
400 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
401
402         Unreviewed follow-up to r242292.
403
404         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
405
406         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
407         (TestWebKitAPI::testStrip): Renamed from strip.
408         (TestWebKitAPI::TEST):
409
410 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
411
412         Unreviewed, remove accidentally-committed URLHelpers.cpp test
413
414         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
415         and bug #194272 for details.
416
417         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
418
419 2019-03-03  Tim Horton  <timothy_horton@apple.com>
420
421         Remove some more unused 32-bit code
422         https://bugs.webkit.org/show_bug.cgi?id=195255
423
424         Reviewed by Darin Adler.
425
426         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
427         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
428         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
429         (NPP_New):
430         (NPP_HandleEvent):
431         (handleEventCarbon): Deleted.
432
433 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
434
435         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
436
437         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
438         (TestWebKitAPI::TEST):
439
440 2019-03-01  Darin Adler  <darin@apple.com>
441
442         Finish removing String::format
443         https://bugs.webkit.org/show_bug.cgi?id=194893
444
445         Reviewed by Daniel Bates.
446 '
447         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
448
449 2019-03-01  Alex Christensen  <achristensen@webkit.org>
450
451         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
452         https://bugs.webkit.org/show_bug.cgi?id=195229
453         <rdar://problem/48520362>
454
455         Reviewed by Chris Dumez.
456
457         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
458         (TEST):
459
460 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
461
462         Add a system trace scope for event region building
463         https://bugs.webkit.org/show_bug.cgi?id=195226
464
465         Reviewed by Jon Lee.
466
467         This trace scope measures the time spend converting element rects into Region objects,
468         which can be large on some pages.
469
470         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
471
472         * Tracing/SystemTracePoints.plist:
473
474 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
475
476         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
477         https://bugs.webkit.org/show_bug.cgi?id=194612
478
479         Reviewed by Alex Christensen.
480
481         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
482         Just test the new string-processing function and don't touch the actual environment.
483         (Test cases are all as before, but based on operator== instead of strcmp.)
484
485 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-app] Update primary keys for handling multiple Buildbot instances
488         https://bugs.webkit.org/show_bug.cgi?id=195120
489
490         Reviewed by Stephanie Lewis.
491
492         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
493         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
494         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
495
496         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
497         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
498         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
499         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
500         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
501         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
502
503 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
504
505         [WinCairo] Enable service worker
506         https://bugs.webkit.org/show_bug.cgi?id=188318
507
508         Reviewed by Youenn Fablet.
509
510         * DumpRenderTree/DumpRenderTreePrefix.h:
511         * TestWebKitAPI/PlatformWin.cmake:
512         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
513         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
514         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
515
516 2019-03-01  Justin Fan  <justin_fan@apple.com>
517
518         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
519         https://bugs.webkit.org/show_bug.cgi?id=195191
520
521         Rubber-stamped by Dean Jackson.
522
523         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
524
525         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
526
527 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
528
529         Unreviewed, fix lldb webkitpy tests
530         https://bugs.webkit.org/show_bug.cgi?id=194375
531
532         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
533
534         * lldb/lldb_webkit.py:
535         (WTFStringImplProvider.is_8bit):
536
537 2019-02-28  David Quesada  <david_quesada@apple.com>
538
539         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
540         https://bugs.webkit.org/show_bug.cgi?id=195121
541         rdar://problem/48450302
542
543         Reviewed by Alex Christensen.
544
545         Add API tests for -WKNavigationAction._shouldPerformDownload in various
546         configurations where the 'download' attribute is absent, blank, or populated
547         with a filename, and where the anchor element is same-origin or cross-origin
548         (meaning the 'download' attribute shouldn't be honored).
549
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
552         (-[NavigationActionTestDelegate init]):
553         (-[NavigationActionTestDelegate navigationAction]):
554         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
555         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
556         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
557         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
558         (TEST):
559
560 2019-02-28  Antoine Quint  <graouts@apple.com>
561
562         Enable the Pointer Events runtime flag by default
563         https://bugs.webkit.org/show_bug.cgi?id=195156
564
565         Reviewed by Dean Jackson.
566
567         * DumpRenderTree/mac/DumpRenderTree.mm:
568         (enableExperimentalFeatures):
569
570 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
571
572         Several PasteImage API tests are flaky
573         https://bugs.webkit.org/show_bug.cgi?id=195160
574
575         Reviewed by Tim Horton.
576
577         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
578         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
579         listening for a "load" event after image load is already complete.
580
581         To address this, make these tests first register a "load" event handler, then run script to insert an image
582         element into the document, and finally wait until the load event is observed before checking image size.
583
584         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
585
586 2019-02-28  Chris Dumez  <cdumez@apple.com>
587
588         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
589         https://bugs.webkit.org/show_bug.cgi?id=195107
590
591         Reviewed by Alex Christensen.
592
593         Give some time for the zoom level to get restored.
594
595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
596
597 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
598
599         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
600         https://bugs.webkit.org/show_bug.cgi?id=194958
601
602         Reviewed by Geoffrey Garen.
603
604         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
605         (TEST):
606
607 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
608
609         [ews-app] Update method to save build to handle builder_display_name
610         https://bugs.webkit.org/show_bug.cgi?id=195047
611
612         Reviewed by Dewei Zhu.
613
614         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
615         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
616
617 2019-02-28  Justin Fan  <justin_fan@apple.com>
618
619         [Web GPU] Enable Web GPU only on 64-bit
620         https://bugs.webkit.org/show_bug.cgi?id=195139
621
622         Because Metal is only supported on 64 bit apps.
623
624         Unreviewed build fix.
625
626         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
627
628 2019-02-27  Youenn Fablet  <youenn@apple.com>
629
630         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
631         https://bugs.webkit.org/show_bug.cgi?id=194959
632
633         Reviewed by Chris Dumez.
634
635         Spin loop until getting the condition to remove flakiness.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
638
639 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
640
641         [ews-build] Buildbot should include builder_display_name in the build events
642         https://bugs.webkit.org/show_bug.cgi?id=195045
643
644         Reviewed by Dewei Zhu.
645
646         * BuildSlaveSupport/ews-build/events.py:
647         (Events.buildStarted): Included builder_display_name in event data. Also renamed
648         buildername to builder_name to be consistent in naming style.
649         (Events.buildFinished): Ditto.
650
651 2019-02-27  Chris Dumez  <cdumez@apple.com>
652
653         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
654         https://bugs.webkit.org/show_bug.cgi?id=194480
655
656         Reviewed by Brady Eidson.
657
658         Update existing API test to make it more likely to reproduce the issue.
659
660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
661
662 2019-02-27  Brady Eidson  <beidson@apple.com>
663
664         Universal links from Google search results pages don't open the app.
665         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
666
667         Reviewed by Geoffrey Garen.
668
669         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
670         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
671         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
672         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
673
674 2019-02-27  Chris Dumez  <cdumez@apple.com>
675
676         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
677         https://bugs.webkit.org/show_bug.cgi?id=195102
678
679         Reviewed by Geoffrey Garen.
680
681         If the number of processes is not yet what we expect, wait a bit and check again to give
682         processes some time to exit.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
685
686 2019-02-27  Chris Dumez  <cdumez@apple.com>
687
688         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
689         https://bugs.webkit.org/show_bug.cgi?id=194545
690
691         Reviewed by Brady Eidson.
692
693         Make sure the test navigates forward and then back only once. Previously, navigating
694         back would trigger a navigation again in a timer.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
697
698 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
699
700         High Sierra Debug JSC test queue should use faster hardware
701         https://bugs.webkit.org/show_bug.cgi?id=194603
702
703         Rubber-stamped by Alexey Proskuryakov.
704
705         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
706
707         * BuildSlaveSupport/build.webkit.org-config/config.json:
708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
709         (BubbleQueueServer):
710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
711         (WebKitBuildbot):
712         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
713         * QueueStatusServer/config/queues.py:
714         * Scripts/webkitpy/common/config/ews.json:
715         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
716         (test_ews_name):
717
718 2019-02-27  John Wilander  <wilander@apple.com>
719
720         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
721         https://bugs.webkit.org/show_bug.cgi?id=195071
722         <rdar://problem/48417690>
723
724         Reviewed by Alex Christensen and Brent Fulgham.
725
726         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
727         (TestWebKitAPI::createURL):
728             Convenience function.
729         (TestWebKitAPI::TEST):
730             WebCore::AdClickAttribution now takes a URL when creating Source and
731             Destination.
732         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
733         (TestWebKitAPI::TEST):
734             WebCore::AdClickAttribution now takes a URL when creating Source and
735             Destination.
736
737 2019-02-27  Antoine Quint  <graouts@apple.com>
738
739         Support Pointer Events on macOS
740         https://bugs.webkit.org/show_bug.cgi?id=195008
741         <rdar://problem/47454419>
742
743         Reviewed by Dean Jackson.
744
745         * DumpRenderTree/mac/DumpRenderTree.mm:
746         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
747         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
748
749 2019-02-26  Mark Lam  <mark.lam@apple.com>
750
751         Remove remaining poisoning code.
752         https://bugs.webkit.org/show_bug.cgi?id=194138
753
754         Reviewed by Saam Barati.
755
756         * TestWebKitAPI/CMakeLists.txt:
757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
758         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
759         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
760         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
761         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
762         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
763         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
764
765 2019-02-26  Alex Christensen  <achristensen@webkit.org>
766
767         Move ephemeral local storage from WebProcess to UIProcess
768         https://bugs.webkit.org/show_bug.cgi?id=195074
769         <rdar://problem/47937975>
770
771         Reviewed by Geoff Garen.
772
773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
774
775 2019-02-20  Jer Noble  <jer.noble@apple.com>
776
777         [Cocoa] Media elements will restart network buffering just before suspending
778         https://bugs.webkit.org/show_bug.cgi?id=193691
779
780         Reviewed by Eric Carlson.
781
782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
784         (TEST):
785
786 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
787
788         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
789         https://bugs.webkit.org/show_bug.cgi?id=191652
790
791         Reviewed by Alex Christensen.
792
793         Fix WinCairo MiniBrowser behavior of authentication dialog.
794
795         * MiniBrowser/win/WebKitBrowserWindow.cpp:
796         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
797
798 2019-02-26  Youenn Fablet  <youenn@apple.com>
799
800         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
801         https://bugs.webkit.org/show_bug.cgi?id=195028
802         <rdar://problem/48243733>
803
804         Reviewed by Eric Carlson.
805
806         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
807
808 2019-02-26  Philippe Normand  <pnormand@igalia.com>
809
810         [WPE] Add API for webview background color configuration
811         https://bugs.webkit.org/show_bug.cgi?id=192305
812
813         Reviewed by Michael Catanzaro.
814
815         * MiniBrowser/wpe/main.cpp:
816         (main): Add a new option to configure the webview background
817         color. Example: --bg-color=transparent.
818         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
819         (testWebViewBackgroundColor): Enable background color API tests for WPE.
820         (beforeAll): Ditto.
821
822 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
823
824         scalableNativeWebpageParameters() is not preserved on new page navigation.
825         https://bugs.webkit.org/show_bug.cgi?id=194892
826         <rdar://problem/47538280>
827
828         Reviewed by Wenson Hsieh.
829         
830         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
831
832         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
833         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
834         * DumpRenderTree/mac/UIScriptControllerMac.mm:
835         (WTR::UIScriptController::allowsViewportShrinkToFit):
836         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
837         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
838         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
839         * TestRunnerShared/UIScriptContext/UIScriptController.h:
840         * WebKitTestRunner/UIScriptControllerCocoa.mm:
841         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
842
843 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
844
845         [ews-app] Add model for handling multiple Buildbot instances
846         https://bugs.webkit.org/show_bug.cgi?id=194863
847
848         Reviewed by Stephanie Lewis.
849
850         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
851
852 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-app] Remove BuilderMapping table
855         https://bugs.webkit.org/show_bug.cgi?id=194961
856
857         Reviewed by Stephanie Lewis.
858
859         Store builder name directly in build table, instead of having a separate
860         table for it.
861
862         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
863         * BuildSlaveSupport/ews-app/ews/models/build.py:
864         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
865         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
866
867 2019-02-25  John Wilander  <wilander@apple.com>
868
869         Introduce and adopt new class RegistrableDomain for eTLD+1
870         https://bugs.webkit.org/show_bug.cgi?id=194791
871         <rdar://problem/48179240>
872
873         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
874
875         This patch adds an API test and replaces two instances of
876         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
877
878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
879         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
880         (TestWebKitAPI::TEST):
881             Changed two strings to make sure the registrable domains are still considered
882             invalid and pass the test.
883         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
884         (TestWebKitAPI::TEST):
885         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
886         (WTR::InjectedBundle::didReceiveMessageToPage):
887
888 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
889
890         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
891         https://bugs.webkit.org/show_bug.cgi?id=195001
892
893         Reviewed by Carlos Garcia Campos.
894
895         API version 1.0 always includes the functionality previously guarded with
896         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
897         unconditionally.
898
899         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
900         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
901         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
902         (WebViewTest::showInWindow): Ditto.
903         (WebViewTest::hideView): Ditto.
904         * wpe/backends/HeadlessViewBackend.cpp:
905         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
906         * wpe/backends/ViewBackend.cpp:
907         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
908         * wpe/backends/WindowViewBackend.cpp:
909         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
910         WPE_BACKEND_CHECK_VERSION().
911         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
912
913 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
914
915         [Flatpak] Add support for flatpak > 1.1.2
916         https://bugs.webkit.org/show_bug.cgi?id=194088
917
918         Flatpak 1.2 is now out so we need to support that
919         version now.
920
921         Reviewed by Michael Catanzaro.
922
923         * flatpak/flatpakutils.py:
924         (check_flatpak):
925         (FlatpakPackages.__init__):
926         (FlatpakPackages.__detect_packages):
927         (FlatpakPackages.__detect_packages.in):
928         (FlatpakRepos.update):
929
930 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
931
932         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
933         https://bugs.webkit.org/show_bug.cgi?id=194998
934
935         Reviewed by Carlos Garcia Campos.
936
937         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
938         to a Git checkout and using the latest commit containing various fixes
939         and improvements.
940
941 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
942
943         [WPE][GTK] Remove user agent quirk for washingtonpost.com
944         https://bugs.webkit.org/show_bug.cgi?id=194981
945
946         Reviewed by Žan Doberšek.
947
948         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
949         (TestWebKitAPI::TEST):
950
951 2019-02-23  Keith Miller  <keith_miller@apple.com>
952
953         Add new mac target numbers
954         https://bugs.webkit.org/show_bug.cgi?id=194955
955
956         Reviewed by Tim Horton.
957
958         * DumpRenderTree/mac/Configurations/Base.xcconfig:
959         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
960         * MiniBrowser/Configurations/Base.xcconfig:
961         * TestWebKitAPI/Configurations/Base.xcconfig:
962         * WebKitTestRunner/Configurations/Base.xcconfig:
963
964 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
965
966         [WinCairo] Enable wk1/wk2 suffix for platform search path.
967         https://bugs.webkit.org/show_bug.cgi?id=194846
968
969         Reviewed by Don Olmstead.
970
971         Added _search_paths() and _port_specific_expectations_files() for
972         WinCairoPort.
973
974         * Scripts/webkitpy/port/win.py:
975         (WinCairoPort.default_baseline_search_path):
976         (WinCairoPort):
977         (WinCairoPort._port_specific_expectations_files):
978         (WinCairoPort._search_paths):
979
980 2019-02-22  Tim Horton  <timothy_horton@apple.com>
981
982         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
983         https://bugs.webkit.org/show_bug.cgi?id=194963
984
985         Reviewed by Dean Jackson.
986
987         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
988         Do a `contains` check instead of `equals`, because in debug builds we
989         put the GraphicsLayer pointer in a prefix.
990
991 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
992
993         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
994         https://bugs.webkit.org/show_bug.cgi?id=194873
995         <rdar://problem/46701974>
996
997         Reviewed by Tim Horton.
998
999         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1000
1001         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1002         (WTR::UIScriptController::menuRect const):
1003         (WTR::UIScriptController::isShowingMenu const):
1004         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1005         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1006         (WTR::UIScriptController::menuRect const):
1007
1008         Add a function to query the bounds of the callout menu in content coordinates.
1009
1010         (WTR::UIScriptController::isShowingMenu const):
1011
1012         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1013
1014         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1015         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1016         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1017         (WTR::UIScriptController::rectForMenuAction const):
1018         (WTR::UIScriptController::menuRect const):
1019         (WTR::UIScriptController::isShowingMenu const):
1020         (WTR::findViewInHierarchyOfType): Deleted.
1021
1022 2019-02-22  Chris Dumez  <cdumez@apple.com>
1023
1024         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1025         https://bugs.webkit.org/show_bug.cgi?id=194954
1026         <rdar://problem/48127957>
1027
1028         Reviewed by Alex Christensen.
1029
1030         Add API test coverage.
1031
1032         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1033         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1034         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1035         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1036
1037 2019-02-22  Chris Dumez  <cdumez@apple.com>
1038
1039         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1040         https://bugs.webkit.org/show_bug.cgi?id=194924
1041         <rdar://problem/48216125>
1042
1043         Reviewed by Geoffrey Garen.
1044
1045         Add API test coverage.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1048
1049 2019-02-22  Chris Dumez  <cdumez@apple.com>
1050
1051         Unreviewed, disable API test added in r241928 on iOS.
1052
1053         The cache is not enabled on devices with less than 3GB of RAM.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1056
1057 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1058
1059         Hardcode Visual Viewports on everywhere except iOS WK1
1060         https://bugs.webkit.org/show_bug.cgi?id=194928
1061
1062         Reviewed by Zalan Bujtas.
1063
1064         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1065         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1066         set it to false. The setting has shipped for several years and there's no need to turn
1067         it off now.
1068
1069         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1070         Visual Viewports are not enabled.
1071         
1072         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1073         that only runs in WK2
1074
1075         * MiniBrowser/mac/SettingsController.h:
1076         * MiniBrowser/mac/SettingsController.m:
1077         (-[SettingsController init]):
1078         (-[SettingsController _populateMenu]):
1079         (-[SettingsController validateMenuItem:]):
1080         (-[SettingsController visualViewportEnabled]): Deleted.
1081         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1082         * MiniBrowser/mac/WK1BrowserWindowController.m:
1083         (-[WK1BrowserWindowController didChangeSettings]):
1084         * MiniBrowser/mac/WK2BrowserWindowController.m:
1085         (-[WK2BrowserWindowController didChangeSettings]):
1086
1087 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         Discard cached processes when clearing website data store
1090         https://bugs.webkit.org/show_bug.cgi?id=194894
1091
1092         Reviewed by Chris Dumez.
1093
1094         Added a test case.
1095
1096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1097         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1098
1099 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1100
1101         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1102         https://bugs.webkit.org/show_bug.cgi?id=194914
1103         <rdar://problem/47586889>
1104
1105         Reviewed by Geoffrey Garen.
1106
1107         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1108         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1109         (TEST):
1110         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1111
1112 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1113
1114         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1115         <https://webkit.org/b/194761>
1116
1117         Reviewed by Myles Maxfield.
1118
1119         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1120         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1121         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1122         to use ARC-compliant cast.
1123         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1124         ARC-compliant cast.
1125         (WTR::installFakeHelvetica): Log `error` to console if
1126         CTFontManagerRegisterFontsForURL() fails, but only on supported
1127         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1128         Call CFRelease() on `error` to fix the leak.  Update to use
1129         ARC-compliant cast.
1130         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1131         cast.
1132
1133 2019-02-21  Chris Dumez  <cdumez@apple.com>
1134
1135         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1136         https://bugs.webkit.org/show_bug.cgi?id=194481
1137
1138         Reviewed by Alex Christensen.
1139
1140         Give the processes a chance to shutdown and wait until we reached the expected number
1141         of processes.
1142
1143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1144
1145 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1146
1147         Fix the macOS build
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1150
1151 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1152
1153         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1154
1155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1156         I am a backwards.
1157
1158 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1159
1160         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1161
1162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1163         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1164         We could force on UI-side compositing, but I feel like the test might be more
1165         valuable exercising the normal path on each platform (though the original
1166         bug was also UI-side specific). Though we can't validate that the overlay
1167         layer was installed successfully, there are layout tests that do that.
1168
1169 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1170
1171         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1172         https://bugs.webkit.org/show_bug.cgi?id=194845
1173         <rdar://problem/47944579>
1174
1175         Reviewed by Antti Koivisto.
1176
1177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1179
1180 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1181
1182         [LFC][Floats] Add support for placing formatting roots in-between floats.
1183         https://bugs.webkit.org/show_bug.cgi?id=194902
1184
1185         Reviewed by Antti Koivisto.
1186
1187         * LayoutReloaded/misc/LFC-passing-tests.txt:
1188
1189 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1190
1191         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1192         https://bugs.webkit.org/show_bug.cgi?id=194901
1193
1194         Unreviewed build fix.
1195
1196         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1197         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1198         WPEBackend-fdo-0.1 as library name.
1199
1200 2019-02-21  Rob Buis  <rbuis@igalia.com>
1201
1202         Update MIME type parser
1203         https://bugs.webkit.org/show_bug.cgi?id=180526
1204
1205         Reviewed by Darin Adler.
1206
1207         Add tests involving leading and trailing whitespace, non-token
1208         characters and quoted strings.
1209
1210         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1211         (TestWebKitAPI::TEST):
1212
1213 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1214
1215         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1216         https://bugs.webkit.org/show_bug.cgi?id=194884
1217
1218         Reviewed by Michael Catanzaro.
1219
1220         * PlatformWin.cmake:
1221
1222 2019-02-20  Chris Dumez  <cdumez@apple.com>
1223
1224         Add API test for <rdar://problem/47471222>
1225         https://bugs.webkit.org/show_bug.cgi?id=194847
1226
1227         Reviewed by Alex Christensen.
1228
1229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1230
1231 2019-02-20  Chris Dumez  <cdumez@apple.com>
1232
1233         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1234         https://bugs.webkit.org/show_bug.cgi?id=194872
1235         <rdar://problem/47924500>
1236
1237         Reviewed by Alex Christensen.
1238
1239         Add API test coverage.
1240
1241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1242
1243 2019-02-20  Jer Noble  <jer.noble@apple.com>
1244
1245         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1246         https://bugs.webkit.org/show_bug.cgi?id=191332
1247
1248         Reviewed by Dean Jackson.
1249
1250         * Scripts/git-is-in-range: Added.
1251
1252 2019-02-20  Andy Estes  <aestes@apple.com>
1253
1254         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1255         https://bugs.webkit.org/show_bug.cgi?id=194869
1256
1257         Rubber-stamped by Jer Noble.
1258
1259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1260         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1261         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1262         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1265
1266 2019-02-20  Chris Dumez  <cdumez@apple.com>
1267
1268         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1269         https://bugs.webkit.org/show_bug.cgi?id=194857
1270         <rdar://problem/47759323>
1271
1272         Reviewed by Alex Christensen.
1273
1274         Add API test coverage.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1277
1278 2019-02-20  Chris Dumez  <cdumez@apple.com>
1279
1280         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1281         https://bugs.webkit.org/show_bug.cgi?id=194829
1282         <rdar://problem/47889906>
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         Every time the TestOptions were changing we were creating both a new Web view and
1287         a new WKContext, which would start a new Network process. In most cases, we only
1288         need to contruct a new Web view and we do can keep reusing the same WKContext.
1289         This patch implements this optimization and thus avoids spinning a lot of new
1290         Network processes while running the layout tests.
1291
1292         * WebKitTestRunner/TestController.cpp:
1293         (WTR::TestController::generateContextConfiguration const):
1294         (WTR::TestController::generatePageConfiguration):
1295         (WTR::TestController::createWebViewWithOptions):
1296         (WTR::TestController::resetPreferencesToConsistentValues):
1297         (WTR::updateTestOptionsFromTestHeader):
1298         * WebKitTestRunner/TestController.h:
1299         * WebKitTestRunner/TestOptions.h:
1300         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1301         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1302         (WTR::TestOptions::hasSameInitializationOptions const):
1303         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1304         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1305         (WTR::TestController::platformAddTestOptions const):
1306
1307 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1308
1309         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1310         https://bugs.webkit.org/show_bug.cgi?id=167941
1311
1312         Reviewed by Carlos Garcia Campos.
1313
1314         * MiniBrowser/gtk/main.c:
1315         (filterSavedCallback): Added.
1316         (main): Support loading a JSON rule set file for content filtering.
1317         * MiniBrowser/wpe/main.cpp:
1318         (filterSavedCallback): Added.
1319         (main): Support loading a JSON rule set file for content filtering.
1320         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1321         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1322         (WTF::derefGPtr): Ditto.
1323         (testEmptyStore):
1324         (testSaveInvalidFilter):
1325         (testSaveLoadFilter):
1326         (testSavedFilterIdentifierMatch):
1327         (testRemoveFilter):
1328         (testSaveMultipleFilters):
1329         (testSaveFilterFromFile):
1330         (testFilterPersistence):
1331         (beforeAll):
1332         (afterAll):
1333         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1334         (removeOldInjectedContentAndResetLists): Also reset content filters.
1335         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1336         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1337         the element affected by the style sheet.
1338         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1339         and returns it to be used by tests.
1340         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1341         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1342         (serverCallback): Add support for serving a CSS style sheet for testing.
1343         (beforeAll): Add call to testUserContentManagerContentFilter().
1344         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1345
1346 2019-02-19  Keith Rollin  <krollin@apple.com>
1347
1348         Add timing information to build output
1349         https://bugs.webkit.org/show_bug.cgi?id=194839
1350         <rdar://problem/48219609>
1351
1352         Reviewed by Alexey Proskuryakov.
1353
1354         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1355         emit each project's build time to its output. E.g.,
1356
1357             ** BUILD SUCCEEDED ** [0.132 sec]
1358
1359         * Scripts/webkitdirs.pm:
1360         (XcodeOptions):
1361
1362 2019-02-19  Truitt Savell  <tsavell@apple.com>
1363
1364         Unreviewed, rolling out r241784.
1365
1366         Broke all OpenSource builds.
1367
1368         Reverted changeset:
1369
1370         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1371         instances view"
1372         https://bugs.webkit.org/show_bug.cgi?id=172848
1373         https://trac.webkit.org/changeset/241784
1374
1375 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1376
1377         [LFC][Floats] Remove redundant intersecting logic
1378         https://bugs.webkit.org/show_bug.cgi?id=194804
1379
1380         Reviewed by Antti Koivisto.
1381
1382         * LayoutReloaded/misc/LFC-passing-tests.txt:
1383
1384 2019-02-19  Dean Jackson  <dino@apple.com>
1385
1386         Clean-up output from generate-xcfilelists so it can be filtered
1387         https://bugs.webkit.org/show_bug.cgi?id=194795
1388
1389         Reviewed by Joseph Pecoraro (and Keith Rollin).
1390
1391         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1392         make a slight tweak to filter-build-webkit so such lines are marked
1393         as plain.
1394
1395         * Scripts/filter-build-webkit:
1396         * Scripts/generate-xcfilelists:
1397
1398 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1399
1400         pytest is not correctly auto-installed
1401         https://bugs.webkit.org/show_bug.cgi?id=194707
1402
1403         Reviewed by Carlos Garcia Campos.
1404
1405         * Scripts/webkitpy/thirdparty/__init__.py:
1406         (AutoinstallImportHook._install_pytest):
1407
1408 2019-02-18  Chris Dumez  <cdumez@apple.com>
1409
1410         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1411         https://bugs.webkit.org/show_bug.cgi?id=194797
1412         <rdar://problem/48055151>
1413
1414         Reviewed by Geoffrey Garen.
1415
1416         Add API test coverage.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1419
1420 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1421
1422         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1423         https://bugs.webkit.org/show_bug.cgi?id=194670
1424         <rdar://problem/39066529>
1425
1426         Reviewed by Tim Horton.
1427
1428         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1429         pasted in an editable area as attachment elements.
1430
1431         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1432         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1433         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1434         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1435         (TestWebKitAPI::TEST):
1436         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1437         (WTR::InjectedBundlePage::InjectedBundlePage):
1438
1439 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1440
1441         Fix API test after r241728
1442        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1443
1444         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1445         (TEST):
1446         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1447
1448 2019-02-18  Daniel Bates  <dabates@apple.com>
1449
1450         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1451         https://bugs.webkit.org/show_bug.cgi?id=192824
1452         <rdar://problem/47100332>
1453
1454         Reviewed by Wenson Hsieh.
1455
1456         Fix a bug where the wrong usage code was used for F13 thru F24.
1457
1458         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1459         (keyCodeForDOMFunctionKey):
1460
1461 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1462
1463         Bytecode cache should a have a boot-specific validation
1464         https://bugs.webkit.org/show_bug.cgi?id=194769
1465         <rdar://problem/48149509>
1466
1467         Reviewed by Keith Miller.
1468
1469         Add test for WTF::bootSessionUUIDString()
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1473         (TEST):
1474
1475 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1476
1477         Disable safe browsing in WKWebView and remove its WKPreferences API
1478         https://bugs.webkit.org/show_bug.cgi?id=194723
1479         <rdar://problem/48122993>
1480
1481         Reviewed by Geoffrey Garen.
1482
1483         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1484         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1485         (TEST):
1486         (safeBrowsingView):
1487         Make tests use SPI instead of API.
1488
1489 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1490
1491         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1492         https://bugs.webkit.org/show_bug.cgi?id=194586
1493
1494         Reviewed by Ross Kirsling.
1495
1496         * DumpRenderTree/win/DumpRenderTree.cpp:
1497         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1498         * Scripts/webkitpy/port/driver.py:
1499         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1500
1501 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1502
1503         Unreviewed, rolling out r241620.
1504
1505         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1506         (Requested by ddkilzer on #webkit.)
1507
1508         Reverted changeset:
1509
1510         "[WTF] Add environment variable helpers"
1511         https://bugs.webkit.org/show_bug.cgi?id=192405
1512         https://trac.webkit.org/changeset/241620
1513
1514 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1515
1516         [LFC] RenderImage's default intrinsic size is 0.
1517         https://bugs.webkit.org/show_bug.cgi?id=194745
1518
1519         Reviewed by Antti Koivisto.
1520
1521         * LayoutReloaded/misc/LFC-passing-tests.txt:
1522
1523 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1524
1525         [LFC][BFC] Add support for block replaced intrinsic width.
1526         https://bugs.webkit.org/show_bug.cgi?id=194705
1527
1528         Reviewed by Simon Fraser.
1529
1530         * LayoutReloaded/misc/LFC-passing-tests.txt:
1531
1532 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1533
1534         [LFC] Apply min/max width constraints to preferred width computation
1535         https://bugs.webkit.org/show_bug.cgi?id=194739
1536
1537         Reviewed by Simon Fraser.
1538
1539         * LayoutReloaded/misc/LFC-passing-tests.txt:
1540
1541 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1542
1543         [WTF] Add environment variable helpers
1544         https://bugs.webkit.org/show_bug.cgi?id=192405
1545
1546         Reviewed by Michael Catanzaro.
1547
1548         * DumpRenderTree/mac/DumpRenderTree.mm:
1549         (libraryPathForDumpRenderTree):
1550         * DumpRenderTree/win/DumpRenderTree.cpp:
1551         (libraryPathForDumpRenderTree):
1552         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1553         (setUpIOSLayoutTestCommunication):
1554         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1555         (beforeAll):
1556         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1557         (main):
1558         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1559         (WebKitTestBus::run):
1560         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1561         (WTR::getOutputDir):
1562         (WTR::initializeFontConfigSetting):
1563         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1564         (WTR::InjectedBundle::platformInitialize):
1565         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1566         (WTR::topLevelPath):
1567         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1568         (WTR::topLevelPath):
1569         (WTR::getOutputDir):
1570         (WTR::activateFonts):
1571         * WebKitTestRunner/TestController.cpp:
1572         (WTR::TestController::libraryPathForTesting):
1573         (WTR::TestController::generateContextConfiguration const):
1574         (WTR::TestController::generatePageConfiguration):
1575         (WTR::TestController::decideDestinationWithSuggestedFilename):
1576         (WTR::TestController::platformAdjustContext):
1577         * WebKitTestRunner/TestController.h:
1578         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1579         (WTR::TestController::cocoaPlatformInitialize):
1580         (WTR::TestController::platformAdjustContext):
1581         * WebKitTestRunner/gtk/main.cpp:
1582         (main):
1583         * WebKitTestRunner/mac/TestControllerMac.mm:
1584         (WTR::TestController::configureContentExtensionForTest):
1585         * WebKitTestRunner/wpe/main.cpp:
1586         (main):
1587         Utilize WTF::Environment where possible.
1588
1589 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1590
1591         [iOS] WKWebView callout bar is missing Change Writing Direction item
1592         https://bugs.webkit.org/show_bug.cgi?id=190015
1593         <rdar://problem/44810366>
1594
1595         Reviewed by Tim Horton.
1596
1597         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1598         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1599
1600         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1601         (TestWebKitAPI::TEST):
1602
1603 2019-02-15  Chris Dumez  <cdumez@apple.com>
1604
1605         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1606         https://bugs.webkit.org/show_bug.cgi?id=194717
1607         <rdar://problem/47884404>
1608
1609         Reviewed by Brady Eidson.
1610
1611         Add API test coverage.
1612
1613         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1614
1615 2019-02-15  Youenn Fablet  <youenn@apple.com>
1616
1617         Make navigator.mediaDevices SecureContext
1618         https://bugs.webkit.org/show_bug.cgi?id=194666
1619
1620         Reviewed by Eric Carlson.
1621
1622         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1623         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1624         (TEST_F):
1625
1626 2019-02-15  Brian Burg  <bburg@apple.com>
1627
1628         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1629         https://bugs.webkit.org/show_bug.cgi?id=194411
1630         <rdar://problem/47787614>
1631
1632         Reviewed by Joseph Pecoraro.
1633
1634         Remove unnecessary soft linking macro usage.
1635
1636         * DumpRenderTree/mac/TestRunnerMac.mm:
1637         (TestRunner::inspectorTestStubURL):
1638         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1639         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1640         (WTR::TestRunner::inspectorTestStubURL):
1641
1642 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1643
1644         Unreviewed, rolling out r241559 and r241566.
1645         https://bugs.webkit.org/show_bug.cgi?id=194710
1646
1647         Causes layout test crashes under GuardMalloc (Requested by
1648         ryanhaddad on #webkit).
1649
1650         Reverted changesets:
1651
1652         "[WTF] Add environment variable helpers"
1653         https://bugs.webkit.org/show_bug.cgi?id=192405
1654         https://trac.webkit.org/changeset/241559
1655
1656         "Unreviewed build fix for WinCairo Debug after r241559."
1657         https://trac.webkit.org/changeset/241566
1658
1659 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1660
1661         [LFC] Out-of-flow box is never a float box
1662         https://bugs.webkit.org/show_bug.cgi?id=194704
1663
1664         Reviewed by Antti Koivisto.
1665
1666         * LayoutReloaded/misc/LFC-passing-tests.txt:
1667
1668 2019-02-10  Darin Adler  <darin@apple.com>
1669
1670         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1671         https://bugs.webkit.org/show_bug.cgi?id=194487
1672
1673         Reviewed by Daniel Bates.
1674
1675         * DumpRenderTree/win/DumpRenderTree.cpp:
1676         (applicationId): Use makeString instead of String::format.
1677         (main): Ditto.
1678         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1679         (TestWebKitAPI::Util::createURLForResource): Ditto.
1680         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1681         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1682
1683         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1684         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1685         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1686         (WTR::createStringWithAttributes): Use appendLiteral.
1687         (WTR::AccessibilityUIElement::helpText const): Ditto.
1688         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1689         directly instead of using String::format.
1690         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1691         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1692
1693 2019-02-15  Truitt Savell  <tsavell@apple.com>
1694
1695         Unreviewed, rolling out r241564.
1696
1697         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1698
1699         Reverted changeset:
1700
1701         "[Mac] WebInspectorUI.framework does not need to be soft-
1702         linked anymore"
1703         https://bugs.webkit.org/show_bug.cgi?id=194411
1704         https://trac.webkit.org/changeset/241564
1705
1706 2019-02-15  Saam barati  <sbarati@apple.com>
1707
1708         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1709         https://bugs.webkit.org/show_bug.cgi?id=194036
1710
1711         Reviewed by Yusuke Suzuki.
1712
1713         * Scripts/run-jsc-stress-tests:
1714
1715 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1716
1717         Fix the build.
1718
1719         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1720         (WTR::UIScriptController::drawSquareInEditableImage):
1721         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1722         (TestWebKitAPI::drawSquareInEditableImage):
1723
1724 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1725
1726         Fix the build.
1727
1728         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1729         (WTR::UIScriptController::drawSquareInEditableImage):
1730         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1731         (TestWebKitAPI::drawSquareInEditableImage):
1732
1733 2019-02-14  Brian Burg  <bburg@apple.com>
1734
1735         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1736         https://bugs.webkit.org/show_bug.cgi?id=194411
1737         <rdar://problem/47787614>
1738
1739         Reviewed by Joseph Pecoraro.
1740
1741         Remove unnecessary soft linking macro usage.
1742
1743         * DumpRenderTree/mac/TestRunnerMac.mm:
1744         (TestRunner::inspectorTestStubURL):
1745         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1746         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1747         (WTR::TestRunner::inspectorTestStubURL):
1748
1749 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1752         https://bugs.webkit.org/show_bug.cgi?id=194599
1753
1754         Reviewed by Lucas Forschler.
1755
1756         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1757         (StatusBubble._build_bubble):
1758
1759 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1760
1761         [ews-app] Set Foreign Key in Django build model
1762         https://bugs.webkit.org/show_bug.cgi?id=194667
1763
1764         Reviewed by Lucas Forschler.
1765
1766         * BuildSlaveSupport/ews-app/ews/models/build.py:
1767         (Build):
1768
1769 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1770
1771         [WTF] Add environment variable helpers
1772         https://bugs.webkit.org/show_bug.cgi?id=192405
1773
1774         Reviewed by Michael Catanzaro.
1775
1776         * DumpRenderTree/mac/DumpRenderTree.mm:
1777         (libraryPathForDumpRenderTree):
1778         * DumpRenderTree/win/DumpRenderTree.cpp:
1779         (libraryPathForDumpRenderTree):
1780         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1781         (setUpIOSLayoutTestCommunication):
1782         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1783         (TestWebKitAPI::strip):
1784         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1785         (beforeAll):
1786         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1787         (main):
1788         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1789         (WebKitTestBus::run):
1790         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1791         (WTR::getOutputDir):
1792         (WTR::initializeFontConfigSetting):
1793         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1794         (WTR::InjectedBundle::platformInitialize):
1795         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1796         (WTR::topLevelPath):
1797         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1798         (WTR::topLevelPath):
1799         (WTR::getOutputDir):
1800         (WTR::activateFonts):
1801         * WebKitTestRunner/TestController.cpp:
1802         (WTR::TestController::libraryPathForTesting):
1803         (WTR::TestController::generateContextConfiguration const):
1804         (WTR::TestController::generatePageConfiguration):
1805         (WTR::TestController::decideDestinationWithSuggestedFilename):
1806         (WTR::TestController::platformAdjustContext):
1807         * WebKitTestRunner/TestController.h:
1808         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1809         (WTR::TestController::cocoaPlatformInitialize):
1810         (WTR::TestController::platformAdjustContext):
1811         * WebKitTestRunner/gtk/main.cpp:
1812         (main):
1813         * WebKitTestRunner/mac/TestControllerMac.mm:
1814         (WTR::TestController::configureContentExtensionForTest):
1815         * WebKitTestRunner/wpe/main.cpp:
1816         (main):
1817         Utilize WTF::Environment where possible.
1818
1819 2019-02-14  Chris Dumez  <cdumez@apple.com>
1820
1821         [PSON] Introduce a WebContent Process cache
1822         https://bugs.webkit.org/show_bug.cgi?id=194594
1823         <rdar://problem/46793397>
1824
1825         Reviewed by Geoff Garen.
1826
1827         Update API tests to turn on the WebContent Process cache.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1830
1831 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1832
1833         Unreviewed, build fix after r241480
1834
1835         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1836         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1837         (-[DragAndDropSimulator initWithWebView:]):
1838
1839 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1840
1841         AX: ARIA Reflection was disabled in error
1842         https://bugs.webkit.org/show_bug.cgi?id=194647
1843         <rdar://problem/48068336>
1844
1845         Reviewed by Ryosuke Niwa.
1846
1847         Remove test override now that this feature should be enabled by default.
1848
1849         * WebKitTestRunner/TestController.cpp:
1850         (WTR::TestController::resetPreferencesToConsistentValues):
1851
1852 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1853
1854         Unreviewed, rolling out r241486.
1855         https://bugs.webkit.org/show_bug.cgi?id=194655
1856
1857         causing API failures in builds (Requested by ShawnRoberts on
1858         #webkit).
1859
1860         Reverted changeset:
1861
1862         "[Cocoa] Media elements will restart network buffering just
1863         before suspending"
1864         https://bugs.webkit.org/show_bug.cgi?id=193691
1865         https://trac.webkit.org/changeset/241486
1866
1867 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1868
1869         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1870         https://bugs.webkit.org/show_bug.cgi?id=194622
1871
1872         Reviewed by Antti Koivisto.
1873
1874         * LayoutReloaded/misc/LFC-passing-tests.txt:
1875
1876 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1877
1878         [LFC] Shrink-to-fit-width should be constrained by min/max width
1879         https://bugs.webkit.org/show_bug.cgi?id=194653
1880
1881         Reviewed by Antti Koivisto.
1882
1883         * LayoutReloaded/misc/LFC-passing-tests.txt:
1884
1885 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1886
1887         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1888         https://bugs.webkit.org/show_bug.cgi?id=194641
1889
1890         Reviewed by Geoffrey Garen.
1891
1892         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1893         so that the test would fail without this fix.
1894
1895         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1896         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1897
1898 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1899
1900         [ews-app] Change log level for a log statement
1901
1902         Unreviewed minor fix.
1903
1904         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1905         (Patch.save_patch):
1906
1907 2019-02-13  Jer Noble  <jer.noble@apple.com>
1908
1909         [Cocoa] Media elements will restart network buffering just before suspending
1910         https://bugs.webkit.org/show_bug.cgi?id=193691
1911
1912         Reviewed by Eric Carlson.
1913
1914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1915         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1916         (TEST):
1917
1918 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1919
1920         [ews-app] Fetch builder id to name mapping
1921         https://bugs.webkit.org/show_bug.cgi?id=194355
1922
1923         Reviewed by Lucas Forschler.
1924
1925         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1926         (Buildbot.get_builder_id_to_name_mapping):
1927         (Buildbot._get_display_name_from_builder_name):
1928
1929 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1930
1931         Further restricting webarchive loads
1932         https://bugs.webkit.org/show_bug.cgi?id=194567
1933         <rdar://problem/47610130>
1934
1935         Reviewed by Youenn Fablet.
1936
1937         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1938         navigations on drop.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1942         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1943         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1944         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1945         (TestWebKitAPI::TEST):
1946         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1947         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1948         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1949         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1950         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1951         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1952         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1953
1954 2019-02-13  John Wilander  <wilander@apple.com>
1955
1956         Store Ad Click Attribution requests in the network process
1957         https://bugs.webkit.org/show_bug.cgi?id=194510
1958         <rdar://problem/47650118>
1959
1960         Reviewed by Alex Christensen and Daniel Bates.
1961
1962         This patch adds two TestRunner functions:
1963         - dumpAdClickAttribution()
1964         - clearAdClickAttribution()
1965
1966         They call into the network process to dump and clear Ad Click
1967         Attribution state, respectively.
1968
1969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::dumpAdClickAttribution):
1972         (WTR::TestRunner::clearAdClickAttribution):
1973         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1974         * WebKitTestRunner/TestController.cpp:
1975         (WTR::TestController::resetStateToConsistentValues):
1976         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1977         (WTR::adClickAttributionStringResultCallback):
1978         (WTR::TestController::dumpAdClickAttribution):
1979         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1980         (WTR::adClickAttributionVoidCallback):
1981         (WTR::TestController::clearAdClickAttribution):
1982         * WebKitTestRunner/TestController.h:
1983         * WebKitTestRunner/TestInvocation.cpp:
1984         (WTR::TestInvocation::dumpResults):
1985         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1986         (WTR::TestInvocation::dumpAdClickAttribution):
1987         * WebKitTestRunner/TestInvocation.h:
1988
1989 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1990
1991         [ews-app] Generate status-bubble
1992         https://bugs.webkit.org/show_bug.cgi?id=194572
1993
1994         Reviewed by Lucas Forschler.
1995
1996         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1997         (StatusBubble._build_bubble):
1998         (StatusBubble._should_show_bubble_for):
1999         (StatusBubble._build_bubbles_for_patch):
2000
2001 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2002
2003         [ews-app] Add status bubble html template
2004         https://bugs.webkit.org/show_bug.cgi?id=194571
2005
2006         Reviewed by Lucas Forschler.
2007
2008         * BuildSlaveSupport/ews-app/ews/templates: Added.
2009         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2010
2011 2019-02-12  Chris Dumez  <cdumez@apple.com>
2012
2013         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2014         https://bugs.webkit.org/show_bug.cgi?id=194568
2015         <rdar://problem/47944490>
2016
2017         Reviewed by Ryosuke Niwa.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2022         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2023
2024 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2025
2026         webkitpy: Remove bug_dummy from parsed test expectations
2027         https://bugs.webkit.org/show_bug.cgi?id=194562
2028         <rdar://problem/47853999>
2029
2030         Reviewed by Lucas Forschler.
2031
2032         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2033         (TestExpectationParser):
2034         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2035         skipped tests.
2036         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2037
2038 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2039
2040         [ews-app] Add method to fetch patch
2041         https://bugs.webkit.org/show_bug.cgi?id=194518
2042
2043         Reviewed by Lucas Forschler.
2044
2045         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2046         (Patch.get_patch):
2047
2048 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2049
2050         [LFC] Expand tests coverage (60 new tests -> 860)
2051
2052         Unreviewed test gardening (run-singly, --child-processes=1).
2053
2054         * LayoutReloaded/misc/LFC-passing-tests.txt:
2055
2056 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2057
2058         Allow pages to trigger programmatic paste from script on iOS
2059         https://bugs.webkit.org/show_bug.cgi?id=194271
2060         <rdar://problem/47808810>
2061
2062         Reviewed by Tim Horton.
2063
2064         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2065
2066         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2067         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2068         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2069         (WTR::UIScriptController::rectForMenuAction const):
2070
2071         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2072         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2073         for when the menu is shown or hidden.
2074
2075         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2076         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2077         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2078         (WTR::UIScriptController::setDidShowMenuCallback):
2079         (WTR::UIScriptController::didShowMenuCallback const):
2080         (WTR::UIScriptController::setDidHideMenuCallback):
2081         (WTR::UIScriptController::didHideMenuCallback const):
2082         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2083         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2084         (WTR::UIScriptController::rectForMenuAction const):
2085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::TestController::resetPreferencesToConsistentValues):
2088         (WTR::updateTestOptionsFromTestHeader):
2089         * WebKitTestRunner/TestOptions.h:
2090
2091         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2092         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2093
2094         (WTR::TestOptions::hasSameInitializationOptions const):
2095         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2096         (WTR::UIScriptController::calendarType const):
2097         (WTR::UIScriptController::platformUndoManager const):
2098         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2099         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2100         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2101         (-[TestRunnerWKWebView dealloc]):
2102         (-[TestRunnerWKWebView _didShowMenu]):
2103         (-[TestRunnerWKWebView _didHideMenu]):
2104
2105         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2106
2107         * WebKitTestRunner/ios/TestControllerIOS.mm:
2108         (WTR::handleMenuWillHideNotification):
2109         (WTR::handleMenuDidHideNotification):
2110         (WTR::TestController::platformInitialize):
2111         (WTR::TestController::platformDestroy):
2112         (WTR::TestController::platformResetStateToConsistentValues):
2113
2114         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2115         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2116
2117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2118         (WTR::forEachViewInHierarchy):
2119         (WTR::findViewInHierarchyOfType):
2120
2121         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2122         functions that dig through a given view's hierarchy in search of a view of a given class.
2123
2124         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2125         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2126         (WTR::UIScriptController::selectionCaretViewRect const):
2127         (WTR::UIScriptController::selectionRangeViewRects const):
2128         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2129         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2130
2131         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2132
2133         (WTR::UIScriptController::rectForMenuAction const):
2134
2135         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2136         callout bar) whose label matches the given string.
2137
2138         (WTR::UIScriptController::platformContentView const):
2139
2140         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2141         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2142         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2143
2144         (WTR::UIScriptController::platformUndoManager const): Deleted.
2145         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2146         (WTR::UIScriptController::platformContentView const):
2147         (WTR::UIScriptController::platformUndoManager const): Deleted.
2148
2149 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2150
2151         webkitpy: No option to only show unexpected failures in results.html for iPad
2152         https://bugs.webkit.org/show_bug.cgi?id=194554
2153         <rdar://problem/47922442>
2154
2155         Rubber-stamped by Aakash Jain.
2156
2157         Just because a TestExpecations file does not exist for a specific platform does not mean that
2158         TestExpecations are not being used, given that platforms inherit test expectations.
2159
2160         * Scripts/webkitpy/port/base.py:
2161         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2162         * Scripts/webkitpy/port/base_unittest.py:
2163         (PortTest.test_uses_test_expectations_file):
2164
2165 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2166
2167         Remove setDefersLoading infrastructure from WebKit2
2168         https://bugs.webkit.org/show_bug.cgi?id=194506
2169
2170         Reviewed by Brady Eidson.
2171
2172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2174         (WTR::TestRunner::setDefersLoading): Deleted.
2175         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2176
2177 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2178
2179         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2180         https://bugs.webkit.org/show_bug.cgi?id=194522
2181         <rdar://problem/47789393>
2182
2183         Reviewed by Chris Dumez.
2184
2185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2186         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2187         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2188         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2189
2190 2019-02-12  Andy Estes  <aestes@apple.com>
2191
2192         [iOSMac] Enable Parental Controls Content Filtering
2193         https://bugs.webkit.org/show_bug.cgi?id=194521
2194         <rdar://39732376>
2195
2196         Reviewed by Tim Horton.
2197
2198         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2199
2200 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2201
2202         [LFC][IFC] Add intrinsic width support for float boxes.
2203         https://bugs.webkit.org/show_bug.cgi?id=194528
2204
2205         Reviewed by Antti Koivisto.
2206
2207         Expand tests coverage (2 new tests -> 800).
2208         (This is the correct test ordering --runs-singly --child-processes=1)
2209
2210         * LayoutReloaded/misc/LFC-passing-tests.txt:
2211
2212 2019-02-12  Rob Buis  <rbuis@igalia.com>
2213
2214         Implement serializing in MIME type parser
2215         https://bugs.webkit.org/show_bug.cgi?id=193909
2216
2217         Reviewed by Darin Adler.
2218
2219         Add various tests involving upper case, non-ASCII, control/null characters,
2220         various HTTP whitespace, single quotes and an unpaired surrogate.
2221
2222         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2223         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2224         (TestWebKitAPI::serializeIfValid):
2225         (TestWebKitAPI::TEST):
2226
2227 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2228
2229         [Cocoa] Ask platform for generic font family mappings
2230         https://bugs.webkit.org/show_bug.cgi?id=187723
2231         <rdar://problem/41892438>
2232
2233         Reviewed by Brent Fulgham.
2234
2235         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2236
2237         * DumpRenderTree/mac/DumpRenderTree.mm:
2238         (allowedFontFamilySet):
2239         * WebKitTestRunner/mac/TestControllerMac.mm:
2240         (WTR::allowedFontFamilySet):
2241
2242 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2243
2244         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2245         https://bugs.webkit.org/show_bug.cgi?id=193622
2246
2247         Reviewed by Michael Catanzaro.
2248
2249         This adds support for loading content extension rule sets from the JSON files which
2250         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2251         of WKTR for this could be removed, but that is left for a follow-up patch with
2252         cleanups.
2253
2254         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2255         * WebKitTestRunner/TestController.cpp:
2256         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2257         avoid having the null-terminator copied into the result.
2258         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2259         part of the preparations to run a test.
2260         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2261         (WTR::contentExtensionStoreCallback): Added.
2262         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2263         used for content extensions test.
2264         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2265         extensions and compiling the JSON rule set for tests involving content extensions.
2266         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2267         testing and disables content extensions.
2268         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2269         resetContentExtensions().
2270         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2271         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2272         configureContentExtensionForTest(), and userContentController().
2273
2274 2019-02-11  Daniel Bates  <dabates@apple.com>
2275
2276         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2277         https://bugs.webkit.org/show_bug.cgi?id=191446
2278         <rdar://problem/45929460>
2279
2280         Reviewed by Tim Horton.
2281
2282         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2283
2284         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2285         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2286         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2287         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2288         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2289         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2290         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2291         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2292         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2293         (WTR::arrayLength):
2294         (WTR::parseModifierArray):
2295         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2296         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2297         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2298         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2299
2300 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2301
2302         Unreviewed, rolling out r241272 and r241276.
2303         https://bugs.webkit.org/show_bug.cgi?id=194514
2304
2305         Broke the Apple Internal build and the fix requires human
2306         intervention :( (Requested by dydz on #webkit).
2307
2308         Reverted changesets:
2309
2310         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2311         https://bugs.webkit.org/show_bug.cgi?id=191446
2312         https://trac.webkit.org/changeset/241272
2313
2314         "Fix internal iOS build after r241272"
2315         https://bugs.webkit.org/show_bug.cgi?id=191446
2316         https://trac.webkit.org/changeset/241276
2317
2318 2019-02-11  Truitt Savell  <tsavell@apple.com>
2319
2320         Unreviewed, rolling out r241269.
2321
2322         Caused 5 layout tests crashes on Mac WK1
2323
2324         Reverted changeset:
2325
2326         "DumpRenderTree should report unknown options"
2327         https://bugs.webkit.org/show_bug.cgi?id=191303
2328         https://trac.webkit.org/changeset/241269
2329
2330 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2331
2332         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2333         https://bugs.webkit.org/show_bug.cgi?id=194313
2334
2335         Reviewed by Tim Horton.
2336
2337         Add a helper to determine whether the web view is presenting modal UI.
2338
2339         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2340         (WTR::UIScriptController::isPresentingModally const):
2341         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2342         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2343         (WTR::UIScriptController::isPresentingModally const):
2344         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2345         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2346         (WTR::UIScriptController::calendarType const): Deleted.
2347         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2348         (WTR::UIScriptController::isPresentingModally const):
2349         (WTR::UIScriptController::calendarType const):
2350         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2351         (WTR::UIScriptController::calendarType const):
2352
2353 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2354
2355         GCHeapInspector: Show the retained sizes in more places
2356         https://bugs.webkit.org/show_bug.cgi?id=194464
2357
2358         Reviewed by Simon Fraser.
2359
2360         * GCHeapInspector/gc-heap-inspector.html:
2361         * GCHeapInspector/script/interface.js:
2362         (HeapInspectorUtils.humanReadableSize):
2363         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2364         (HeapInspectorUtils.spanForNode.span.span):
2365         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2366         (HeapSnapshotInspector.prototype.buildRoots):
2367
2368 2019-02-11  Daniel Bates  <dabates@apple.com>
2369
2370         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2371         https://bugs.webkit.org/show_bug.cgi?id=191446
2372         <rdar://problem/45929460>
2373
2374         Reviewed by Tim Horton.
2375
2376         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2377
2378         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2379         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2380         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2381         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2383         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2384         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2385         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2386         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2387         (WTR::arrayLength):
2388         (WTR::parseModifierArray):
2389         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2390         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2391         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2392         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2393
2394 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2395
2396         DumpRenderTree should report unknown options
2397         https://bugs.webkit.org/show_bug.cgi?id=191303
2398
2399         Reviewed by Frédéric Wang.
2400
2401         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2402         to report unknown options.
2403         Added and assigned test options which are currently used in tests.
2404
2405         * DumpRenderTree/TestOptions.cpp:
2406         (TestOptions::TestOptions):
2407
2408 2019-02-11  Truitt Savell  <tsavell@apple.com>
2409
2410         Unreviewed, rolling out r241229.
2411
2412         Revision broke internal builds for watchOS.
2413
2414         Reverted changeset:
2415
2416         "[Cocoa] Ask platform for generic font family mappings"
2417         https://bugs.webkit.org/show_bug.cgi?id=187723
2418         https://trac.webkit.org/changeset/241229
2419
2420 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2421
2422         [WinCairo][MiniBrowser] Basic authentication always fails.
2423         https://bugs.webkit.org/show_bug.cgi?id=194496
2424
2425         Reviewed by Don Olmstead.
2426
2427         * MiniBrowser/win/DialogHelper.h:
2428         (Dialog::getText):
2429
2430 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2431
2432         [GStreamer] GstMappedBuffer testsuite build fails
2433         https://bugs.webkit.org/show_bug.cgi?id=194495
2434
2435         Reviewed by Carlos Garcia Campos.
2436
2437         Fix the build by explicitely adding the gstreamer1.0-audio include
2438         directories to the include path.
2439
2440         * TestWebKitAPI/PlatformGTK.cmake:
2441         * TestWebKitAPI/PlatformWPE.cmake:
2442
2443 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2444
2445         [GTK][WPE] Add enable-javascript-markup setting
2446         https://bugs.webkit.org/show_bug.cgi?id=193439
2447
2448         Reviewed by Michael Catanzaro.
2449
2450         Add test cases to check the new setting.
2451
2452         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2453         (testWebKitSettings):
2454         (testWebKitSettingsJavaScriptMarkup):
2455         (beforeAll):
2456
2457 2019-02-10  Darin Adler  <darin@apple.com>
2458
2459         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2460         https://bugs.webkit.org/show_bug.cgi?id=194485
2461
2462         Reviewed by Daniel Bates.
2463
2464         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2465
2466 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2467
2468         Add more tests for clampTo<>()
2469         https://bugs.webkit.org/show_bug.cgi?id=194462
2470
2471         Reviewed by Geoffrey Garen.
2472
2473         Darin suggested to test the very last floating point number
2474         at the boundaries when truncating to integer.
2475         I added test for max/min and max-1/min-1.
2476
2477         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2478         (TestWebKitAPI::TEST):
2479
2480 2019-02-09  Darin Adler  <darin@apple.com>
2481
2482         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2483         https://bugs.webkit.org/show_bug.cgi?id=194021
2484
2485         Reviewed by Geoffrey Garen.
2486
2487         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2488         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2489         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2490
2491 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2492
2493         [LFC][IFC] Add intrinsic width support for basic inline containers
2494         https://bugs.webkit.org/show_bug.cgi?id=194473
2495
2496         Reviewed by Antti Koivisto.
2497
2498         Expand tests coverage (11 new tests -> 798)
2499
2500         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2501
2502 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2503
2504         Fix MiniBrowser's entitlements
2505         https://bugs.webkit.org/show_bug.cgi?id=192431
2506
2507         Reviewed by Joseph Pecoraro.
2508
2509         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2510         files, making it impossible to load any extension.
2511
2512         * MiniBrowser/MiniBrowser.entitlements:
2513
2514 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2515
2516         [Cocoa] Ask platform for generic font family mappings
2517         https://bugs.webkit.org/show_bug.cgi?id=187723
2518         <rdar://problem/41892438>
2519
2520         Reviewed by Brent Fulgham.
2521
2522         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2523
2524         * DumpRenderTree/mac/DumpRenderTree.mm:
2525         (allowedFontFamilySet):
2526         * WebKitTestRunner/mac/TestControllerMac.mm:
2527         (WTR::allowedFontFamilySet):
2528
2529 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2530
2531         [GTK] Implement back/forward touchpad gesture
2532         https://bugs.webkit.org/show_bug.cgi?id=193919
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2537         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2538
2539 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2540
2541         Add SPI to use networking daemon instead of XPC service
2542         https://bugs.webkit.org/show_bug.cgi?id=194427
2543
2544         Reviewed by Geoffrey Garen
2545
2546         * MiniBrowser/MiniBrowser.entitlements:
2547
2548 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] Ensure that every builder in config.json has short name
2551         https://bugs.webkit.org/show_bug.cgi?id=194461
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-build/loadConfig.py:
2556         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2557
2558 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] Add short name to config.json
2561         https://bugs.webkit.org/show_bug.cgi?id=194456
2562
2563         Reviewed by Lucas Forschler.
2564
2565         * BuildSlaveSupport/ews-build/config.json: Added short name.
2566         * BuildSlaveSupport/ews-build/loadConfig.py:
2567         (loadBuilderConfig): Set the short name as the builder description.
2568
2569 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2570
2571         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2572         https://bugs.webkit.org/show_bug.cgi?id=194418
2573
2574         Reviewed by Lucas Forschler.
2575
2576         Do not include errors trying when finding crashlogs at the end of
2577         a run-webkit-tests run since we don't process those errors.
2578
2579         * Scripts/webkitpy/port/darwin.py:
2580         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2581         * Scripts/webkitpy/port/ios_device.py:
2582         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2583         * Scripts/webkitpy/port/watch_device.py:
2584         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2585
2586 2019-02-08  Beth Dakin  <bdakin@apple.com>
2587
2588         Add afterScreenUpdates to WKSnapshotConfiguration
2589         https://bugs.webkit.org/show_bug.cgi?id=194362
2590         -and corresponding-
2591         <rdar://problem/40655528> Please add an "after screen updates" property to 
2592         WKSnapshotConfiguration (to solve blank snapshots)
2593
2594         Reviewed by Tim Horton.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2597         (TEST):
2598
2599 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2600
2601         clampTo(): do not convert the input to double when dealing with integers
2602         https://bugs.webkit.org/show_bug.cgi?id=194263
2603         <rdar://problem/47692312>
2604
2605         Reviewed by Darin Adler.
2606
2607         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2608         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2609         (TestWebKitAPI::testClampFloatingPointToInteger):
2610         (TestWebKitAPI::testClampSameSignIntegers):
2611         (TestWebKitAPI::testClampUnsignedToSigned):
2612         (TestWebKitAPI::testClampSignedToUnsigned):
2613
2614 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2615
2616         webkitpy: Respect --dedicated-simulators flag
2617         https://bugs.webkit.org/show_bug.cgi?id=194416
2618         <rdar://problem/47894722>
2619
2620         Reviewed by Lucas Forschler.
2621
2622         * Scripts/webkitpy/port/device_port.py:
2623         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2624         available devices can be safely ignored.
2625
2626 2019-02-07  Keith Rollin  <krollin@apple.com>
2627
2628         Remove extra copy of 100x100-red.tga
2629         https://bugs.webkit.org/show_bug.cgi?id=194371
2630         <rdar://problem/47873465>
2631
2632         Reviewed by Said Abou-Hallawa.
2633
2634         In order to help it pass its tests, Bug 194190 added a second copy of
2635         the file 100x100-red.tga. However, it turns out that this additional
2636         file wasn't actually needed, and that that sole previous copy was
2637         sufficient. At the same time, this second copy -- which was copied to
2638         the same location in the build output as the first copy -- now caused
2639         XCBuild to complain because there were two production rules for the
2640         same output file. Address this by removing the newly-added extra copy.
2641
2642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2643         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2644
2645 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2646
2647         Deprecate WKBundlePageSetDefersLoading
2648         https://bugs.webkit.org/show_bug.cgi?id=191394
2649
2650         Reviewed by Dean Jackson.
2651
2652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2653         (WTR::TestRunner::setDefersLoading):
2654
2655 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2656
2657         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2658         https://bugs.webkit.org/show_bug.cgi?id=194391
2659
2660         Reviewed by Antti Koivisto.
2661
2662         * LayoutReloaded/misc/LFC-passing-tests.txt:
2663
2664 2019-02-06  Keith Rollin  <krollin@apple.com>
2665
2666         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2667         https://bugs.webkit.org/show_bug.cgi?id=193975
2668         <rdar://problem/47643306>
2669
2670         Reviewed by Tim Horton.
2671
2672         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2673         the Info.plist file into the bundle. This step is not necessary as the
2674         implicit "bundle up all the build products into a framework" build
2675         phase does this already. Having the Copy Bundle Resources phase do
2676         this causes a conflict under XCBuild, which objects to two build
2677         phases producing the same file (Info.plist). Address this by removing
2678         Info.plist from the Copy Bundle Resources phase.
2679
2680         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2681
2682 2019-02-06  Keith Rollin  <krollin@apple.com>
2683
2684         Really enable the automatic checking and regenerations of .xcfilelists during builds
2685         https://bugs.webkit.org/show_bug.cgi?id=194357
2686         <rdar://problem/47861231>
2687
2688         Reviewed by Chris Dumez.
2689
2690         Bug 194124 was supposed to enable the automatic checking and
2691         regenerating of .xcfilelist files during the build. While related
2692         changes were included in that patch, the change to actually enable the
2693         operation somehow was omitted. This patch actually enables the
2694         operation. The check-xcfilelist.sh scripts now check
2695         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2696         from the checking.
2697
2698         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2699         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2700
2701 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2702
2703         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2704         <https://webkit.org/b/194286>
2705         <rdar://problem/47815558>
2706
2707         Reviewed by Alexey Proskuryakov.
2708
2709         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2710         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2711         WKRetainPtr<> to avoid leaking the WKDataRef.
2712
2713 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2714
2715         Unreviewed, fix a typo
2716
2717         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2718
2719 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2720
2721         [GTK][WPE] force libpsl build to use ICU in jhbuild
2722         https://bugs.webkit.org/show_bug.cgi?id=194288
2723
2724         Reviewed by Carlos Garcia Campos.
2725
2726         * gtk/jhbuild.modules:
2727         Require ICU for libpsl build in jhbuild, like done in WPE.
2728
2729 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2730
2731         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2732         https://bugs.webkit.org/show_bug.cgi?id=194209
2733
2734         Reviewed by Carlos Garcia Campos.
2735
2736         Enhance TestCookieManager to ensure this doesn't happen again.
2737
2738         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2739         (testCookieManagerPersistentStorage):
2740         (beforeAll):
2741
2742 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2743
2744         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2745         https://bugs.webkit.org/show_bug.cgi?id=194324
2746
2747         Reviewed by Andy Estes.
2748
2749         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2750         part of the name is already implicit, since this is in testing code in TestOptions.
2751
2752         * WebKitTestRunner/TestController.cpp:
2753         (WTR::TestController::generateContextConfiguration const):
2754         (WTR::updateTestOptionsFromTestHeader):
2755         * WebKitTestRunner/TestOptions.h:
2756         (WTR::TestOptions::hasSameInitializationOptions const):
2757
2758 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2759
2760         [ews-build] Allow * as platform for builders and workers
2761         https://bugs.webkit.org/show_bug.cgi?id=188533
2762
2763         Reviewed by Lucas Forschler.
2764
2765         * BuildSlaveSupport/ews-build/loadConfig.py:
2766         (checkWorkersAndBuildersForConsistency):
2767
2768 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2769
2770         [ews-build] Add few bots to config.json
2771         https://bugs.webkit.org/show_bug.cgi?id=194304
2772
2773         Reviewed by Lucas Forschler.
2774
2775         * BuildSlaveSupport/ews-build/config.json:
2776
2777 2019-02-05  Keith Rollin  <krollin@apple.com>
2778
2779         Enable the automatic checking and regenerations of .xcfilelists during builds
2780         https://bugs.webkit.org/show_bug.cgi?id=194124
2781         <rdar://problem/47721277>
2782
2783         Reviewed by Tim Horton.
2784
2785         Bug 193790 add a facility for checking -- during build time -- that
2786         any needed .xcfilelist files are up-to-date and for updating them if
2787         they are not. This facility was initially opt-in by setting
2788         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2789         the process seemed robust. Its now time to enable this facility and
2790         make it opt-out. If there is a need to disable this facility, set and
2791         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2792         running `make` or `build-webkit`, or before running Xcode from the
2793         command line.
2794
2795         Additionally, remove the step that generates a list of source files
2796         going into the UnifiedSources build step. It's only necessarily to
2797         specify Sources.txt and SourcesCocoa.txt as inputs.
2798
2799         * Scripts/generate-xcfilelists:
2800
2801 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2802
2803         [GTK][WPE] force libpsl build to use ICU in jhbuild
2804         https://bugs.webkit.org/show_bug.cgi?id=194288
2805
2806         Reviewed by Philippe Normand.
2807
2808         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2809         This can cause build failures if libidn is detected but libunistring is not available.
2810
2811         Make sure that ICU is used for runtime and builtin PSL data.
2812
2813         * gtk/jhbuild.modules:
2814         * wpe/jhbuild.modules:
2815
2816 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2817
2818         [ews-app] Modified timestamp should be updated on updating data
2819         https://bugs.webkit.org/show_bug.cgi?id=194295
2820
2821         Reviewed by Lucas Forschler.
2822
2823         * BuildSlaveSupport/ews-app/ews/models/build.py:
2824         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2825         * BuildSlaveSupport/ews-app/ews/models/step.py:
2826
2827 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2828
2829         Unreviewed, rolling out r240742.
2830
2831         Causes crashes on iOS simulator.
2832
2833         Reverted changeset:
2834
2835         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2836         not focused in a content-editable element"
2837         https://bugs.webkit.org/show_bug.cgi?id=192824
2838         https://trac.webkit.org/changeset/240742
2839
2840 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2841
2842         run-webkit-tests emits message "...running None" when running tests
2843         https://bugs.webkit.org/show_bug.cgi?id=194133
2844         <rdar://problem/47724738>
2845
2846         Reviewed by Lucas Forschler.
2847
2848         * Scripts/webkitpy/xcode/device_type.py:
2849         (DeviceType.__str__): Use both version mapping tables and use just the variant
2850         name if no version name is available.
2851         * Scripts/webkitpy/xcode/device_type_unittest.py:
2852         (DeviceTypeTest):
2853         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2854         an associated named.
2855
2856 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2857
2858         [WPE] require python3-setuptools for meson build in jhbuild
2859         https://bugs.webkit.org/show_bug.cgi?id=194287
2860
2861         Reviewed by Philippe Normand.
2862
2863         python3-setuptools is needed to build meson in jhbuild.
2864         It is already required by the GTK port.
2865
2866         * wpe/install-dependencies:
2867
2868 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2869
2870         [ews-app] Add method to save BuilderMapping to database
2871         https://bugs.webkit.org/show_bug.cgi?id=194264
2872
2873         Reviewed by Lucas Forschler.
2874
2875         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2876         (BuilderMapping.__str__):
2877         (BuilderMapping):
2878         (BuilderMapping.save_mapping):
2879         (BuilderMapping.update_mapping):
2880         (BuilderMapping.get_existing_mapping):
2881         (BuilderMapping.is_valid_mapping):
2882
2883 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2884
2885         [ews-app] Add timestamp fields for BuilderMappings
2886         https://bugs.webkit.org/show_bug.cgi?id=194266
2887
2888         Reviewed by Lucas Forschler.
2889
2890         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2891         (BuilderMapping):
2892
2893 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2894
2895         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2896         https://bugs.webkit.org/show_bug.cgi?id=174816
2897
2898         Reviewed by Michael Catanzaro.
2899
2900         Add tests for webkit_uri_for_display().
2901
2902         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2903         (testURIForDisplayUnaffected):
2904         (testURIForDisplayAffected):
2905         (beforeAll):
2906         (afterAll):
2907         * TestWebKitAPI/glib/CMakeLists.txt:
2908
2909 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2910
2911         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2912         https://bugs.webkit.org/show_bug.cgi?id=194158
2913         <rdar://problem/47737268>
2914
2915         Rubber-stamped by Aakash Jain.
2916
2917         * Scripts/webkitpy/port/device_port.py:
2918         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2919
2920 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2921
2922         [CG] Enable setAdditionalSupportedImageTypes for WK1
2923         https://bugs.webkit.org/show_bug.cgi?id=194190
2924
2925         Reviewed by Tim Horton.
2926
2927         Add a test similar to the one under WebKit Cocoa but make it create a
2928         WebView instead of a WKWebView.
2929
2930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2931         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2932         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2933         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2934         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2935         (TestWebKitAPI::runTest):
2936         (TestWebKitAPI::TEST):
2937
2938 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2939
2940         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2941         https://bugs.webkit.org/show_bug.cgi?id=194168
2942
2943         Reviewed by Simon Fraser.
2944
2945         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2946
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2949         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2950         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2951         (TEST):
2952         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2953         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2954
2955 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2956
2957         REGRESSION (r237269): webkit-patch what-broke is broken 
2958         https://bugs.webkit.org/show_bug.cgi?id=193025
2959
2960         Reviewed by Aakash Jain.
2961
2962         * Scripts/webkitpy/common/host.py:
2963         (Host.buildbot):
2964         (Host.bugzilla): Renamed to 'buildbot'.
2965
2966 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2967
2968         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2969         https://bugs.webkit.org/show_bug.cgi?id=194207
2970
2971         Reviewed by Tim Horton.
2972
2973         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2974         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2975         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2976         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2977         start and delete forwards to remove the original attachment.
2978
2979         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2980         (TestWebKitAPI::TEST):
2981
2982 2019-02-04  Youenn Fablet  <youenn@apple.com>
2983
2984         Capture state should be managed consistently when doing process swapping
2985         https://bugs.webkit.org/show_bug.cgi?id=194122
2986         <rdar://problem/47609293>
2987
2988         Reviewed by Eric Carlson.
2989
2990         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2991         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2992         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2993         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2996         (WTR::TestRunner::isDoingMediaCapture const):
2997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2998         * WebKitTestRunner/TestController.cpp:
2999         (WTR::TestController::isDoingMediaCapture const):
3000         * WebKitTestRunner/TestController.h:
3001         * WebKitTestRunner/TestInvocation.cpp:
3002         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3003         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3004         (WTR::TestController::isDoingMediaCapture const):
3005
3006 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3007
3008         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3009         https://bugs.webkit.org/show_bug.cgi?id=194142
3010
3011         Reviewed by Ross Kirsling.
3012
3013         There three 'separator' variables in TestController.cpp. Renamed
3014         it 'pathSeparator', and unified them.
3015
3016         * WebKitTestRunner/TestController.cpp:
3017         (WTR::TestController::generateContextConfiguration const):
3018         (WTR::createTestURL):
3019         (WTR::TestController::platformAdjustContext):
3020
3021 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3022
3023         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3024         https://bugs.webkit.org/show_bug.cgi?id=194198
3025
3026         Reviewed by Antti Koivisto.
3027
3028         No need to set the banner heights on navigation now, since Page stores them.
3029
3030         * MiniBrowser/mac/WK2BrowserWindowController.m:
3031         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3032
3033 2019-02-03  John Wilander  <wilander@apple.com>
3034
3035         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3036         https://bugs.webkit.org/show_bug.cgi?id=194104
3037         <rdar://problem/47649991>
3038
3039         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3040
3041         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3042         (TestWebKitAPI::TEST):
3043             Changed numeric types from unsigned short to uint32_t.
3044
3045 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3046
3047         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3048         <https://webkit.org/b/194178>
3049         <rdar://problem/47753473>
3050
3051         Reviewed by Alexey Proskuryakov.
3052
3053         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3054         (WTR::uninstallFakeHelvetica): Pass nullptr into
3055         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3056
3057 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3058
3059         [LFC] Initialize ICB's style with fixed width/height.
3060         https://bugs.webkit.org/show_bug.cgi?id=194188
3061
3062         Reviewed by Antti Koivisto.
3063
3064         * LayoutReloaded/misc/LFC-passing-tests.txt:
3065
3066 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3067
3068         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3069         https://bugs.webkit.org/show_bug.cgi?id=194185
3070
3071         Reviewed by Antti Koivisto.
3072
3073         * LayoutReloaded/misc/LFC-passing-tests.txt:
3074
3075 2018-12-16  Darin Adler  <darin@apple.com>
3076
3077         Convert additional String::format clients to alternative approaches
3078         https://bugs.webkit.org/show_bug.cgi?id=192746
3079
3080         Reviewed by Alexey Proskuryakov.
3081
3082         * WebKitTestRunner/TestController.cpp:
3083         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3084         as an intermediate in code that ultimately constructs a WTF::String.
3085         (WTR::userMediaOriginHash): Use makeString.
3086         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3087         (WTR::TestController::didPerformClientRedirect): Ditto.
3088         (WTR::TestController::didPerformServerRedirect): Ditto.
3089         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3090
3091 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3092
3093         [ews-build] Add unit test to verify builder keys
3094         https://bugs.webkit.org/show_bug.cgi?id=194152
3095
3096         Reviewed by Lucas Forschler.
3097
3098         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3099         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3100
3101 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3102
3103         [LFC] Expand tests coverage (12 new tests -> 787)
3104
3105         Unreviewed test gardening.
3106
3107         * LayoutReloaded/misc/LFC-passing-tests.txt:
3108
3109 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3110
3111         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3112         https://bugs.webkit.org/show_bug.cgi?id=194163
3113
3114         Reviewed by Simon Fraser.
3115
3116         775
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3121
3122         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3123         https://bugs.webkit.org/show_bug.cgi?id=194140
3124         <rdar://problem/47728098>
3125
3126         Reviewed by Tim Horton.
3127
3128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3130         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3131
3132         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3133         test to induce an IPC deadlock when presenting a modal alert during touch start.
3134
3135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3136         * WebKitTestRunner/TestController.cpp:
3137         (WTR::runJavaScriptAlert):
3138
3139         Add a client callback function for running JavaScript alerts.
3140
3141         (WTR::TestController::createOtherPage):
3142         (WTR::TestController::generateContextConfiguration const):
3143
3144         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3145         the fix in this patch.
3146
3147         (WTR::TestController::createWebViewWithOptions):
3148
3149         Plumb TestOptions to generateContextConfiguration.
3150
3151         (WTR::TestController::resetPreferencesToConsistentValues):
3152         (WTR::TestController::resetStateToConsistentValues):
3153         (WTR::updateTestOptionsFromTestHeader):
3154         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3155         (WTR::TestController::handleJavaScriptAlert):
3156         * WebKitTestRunner/TestController.h:
3157         * WebKitTestRunner/TestInvocation.cpp:
3158         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3159         * WebKitTestRunner/TestOptions.h:
3160         (WTR::TestOptions::hasSameInitializationOptions const):
3161
3162 2019-02-01  Chris Dumez  <cdumez@apple.com>
3163
3164         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3165         https://bugs.webkit.org/show_bug.cgi?id=193740
3166         <rdar://problem/47527267>
3167
3168         Reviewed by Alex Christensen.
3169
3170         Add API test coverage.
3171
3172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3173
3174 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3175
3176         [ews-app] Add display name field to BuilderMapping model
3177         https://bugs.webkit.org/show_bug.cgi?id=194153
3178
3179         Reviewed by Lucas Forschler.
3180
3181         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3182         (BuilderMapping):
3183
3184 2019-02-01  Youenn Fablet  <youenn@apple.com>
3185
3186         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3187         https://bugs.webkit.org/show_bug.cgi?id=194155
3188
3189         Reviewed by Eric Carlson.
3190
3191         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3192         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3193         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3194
3195 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3196
3197         [LFC] Adjust replaced element's intrinsic ratio
3198         https://bugs.webkit.org/show_bug.cgi?id=194154
3199
3200         Reviewed by Antti Koivisto.
3201
3202         761
3203
3204         * LayoutReloaded/misc/LFC-passing-tests.txt:
3205
3206 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3207
3208         [WPE] Show test results in minibrowser
3209         https://bugs.webkit.org/show_bug.cgi?id=194150
3210
3211         Reviewed by Žan Doberšek.
3212
3213         * Scripts/webkitpy/port/wpe.py:
3214         (WPEPort.show_results_html_file):
3215
3216 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3217
3218         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3219         https://bugs.webkit.org/show_bug.cgi?id=194151
3220
3221         Reviewed by Žan Doberšek.
3222
3223         ALT + <- go back
3224         ALT + -> go forward
3225
3226         * MiniBrowser/wpe/main.cpp:
3227         (main):
3228
3229 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3230
3231         [LFC] Set intrinsic size on Layout::Replaced
3232         https://bugs.webkit.org/show_bug.cgi?id=194139
3233
3234         Reviewed by Antti Koivisto.
3235
3236         744
3237
3238         * LayoutReloaded/misc/LFC-passing-tests.txt:
3239
3240 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3241
3242         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3243         https://bugs.webkit.org/show_bug.cgi?id=194146
3244
3245         Reviewed by Xabier Rodriguez-Calvar.
3246
3247         It allows to open relative paths.
3248
3249         * MiniBrowser/wpe/main.cpp:
3250         (main):
3251
3252 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3253
3254         Update flakiness dashboard configuration after recent queue changes
3255         https://bugs.webkit.org/show_bug.cgi?id=194127
3256
3257         Rubber-stamped by Aakash Jain.
3258
3259         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3260
3261         * TestResultServer/static-dashboards/builders.jsonp:
3262
3263 2019-01-31  Youenn Fablet  <youenn@apple.com>
3264
3265         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3266         https://bugs.webkit.org/show_bug.cgi?id=194106
3267         <rdar://problem/47676333>
3268
3269         Reviewed by Ryosuke Niwa.
3270
3271         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3272         (TestWebKitAPI::didFinishNavigation):
3273         (TestWebKitAPI::TEST):
3274         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3275
3276 2019-01-31  Chris Dumez  <cdumez@apple.com>
3277
3278         Page zoom level is lost after a process swap or a crash
3279         https://bugs.webkit.org/show_bug.cgi?id=194105
3280         <rdar://problem/47610781>
3281
3282         Reviewed by Alex Christensen.
3283
3284         Add API test coverage.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3287         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3288
3289 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3290
3291         Revert r238819 which is unneeded and caused a performance regression.
3292         https://bugs.webkit.org/show_bug.cgi?id=192272
3293         <rdar://problem/46664625>
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3296         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3297         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3298
3299 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3300
3301         Formalize WebKitAdditions mechanism of LoadOptimizer
3302         https://bugs.webkit.org/show_bug.cgi?id=193886
3303         <rdar://problem/47696809>
3304
3305         Reviewed by Brent Fulgham.
3306
3307         * MiniBrowser/MiniBrowser.entitlements:
3308         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3309
3310 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3311
3312         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3313         https://bugs.webkit.org/show_bug.cgi?id=194090
3314
3315         Reviewed by Antti Koivisto.
3316
3317         * LayoutReloaded/misc/LFC-passing-tests.txt:
3318
3319 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3320
3321         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3322         https://bugs.webkit.org/show_bug.cgi?id=194074
3323
3324         Reviewed by Antti Koivisto.
3325
3326         * LayoutReloaded/misc/LFC-passing-tests.txt:
3327
3328 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3329
3330         [LFC][BFC] Add support for block level replaced box.
3331         https://bugs.webkit.org/show_bug.cgi?id=194071
3332
3333         Reviewed by Antti Koivisto.
3334
3335         * LayoutReloaded/misc/LFC-passing-tests.txt:
3336
3337 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3338
3339         Fix WebKitTestRunner's testPath with Windows full paths
3340         https://bugs.webkit.org/show_bug.cgi?id=194012
3341
3342         Reviewed by Alex Christensen.
3343
3344         updateTestOptionsFromTestHeader failed to open test files because
3345         testPath returned wrong file paths. It returned a path "/C:/..."
3346         if a URL "file:///C:/..." was given.
3347
3348         * WebKitTestRunner/TestController.cpp:
3349         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3350
3351 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3352
3353         [WPE] Bump font related dependencies to match the GTK+ port
3354         https://bugs.webkit.org/show_bug.cgi?id=194017
3355
3356         Reviewed by Žan Doberšek.
3357
3358         * wpe/jhbuild.modules:
3359         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3360         * wpe/patches/icudata-stdlibs.patch: Added.
3361
3362 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3363
3364         Enable swipe tests on iOS
3365         https://bugs.webkit.org/show_bug.cgi?id=194076
3366
3367         Reviewed by Geoffrey Garen.
3368
3369         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3370         it causes a debug assertion failure in runUIScript.
3371
3372         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3373         (WTR::UIScriptController::beginBackSwipe):
3374         (WTR::UIScriptController::completeBackSwipe):
3375
3376 2019-01-30  Keith Rollin  <krollin@apple.com>
3377
3378         Use correct printf format specifier
3379         https://bugs.webkit.org/show_bug.cgi?id=194062
3380         <rdar://problem/47686167>
3381
3382         Reviewed by Alexey Proskuryakov.
3383
3384         LayoutTestSpellChecker.mm is trying to format a variable of type
3385         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3386         actually an unsigned long long. Fix this by formatting with %llu.
3387
3388         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3389         (-[LayoutTestTextCheckingResult description]):
3390
3391 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3392
3393         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3394         https://bugs.webkit.org/show_bug.cgi?id=193979
3395
3396         Reviewed by Wenson Hsieh.
3397
3398         Fix the test for iOS. Make the test work with iOS UA string.
3399
3400         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3401
3402 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3403
3404         Replace High Sierra LLINT CLoop bot due to hardware failure
3405         https://bugs.webkit.org/show_bug.cgi?id=194066
3406
3407         Reviewed by Aakash Jain.
3408
3409         * BuildSlaveSupport/build.webkit.org-config/config.json:
3410
3411 2019-01-30  Keith Rollin  <krollin@apple.com>
3412
3413         [NSDragItem init] is unavailable
3414         https://bugs.webkit.org/show_bug.cgi?id=194059
3415         <rdar://problem/47685715>
3416
3417         Reviewed by Wenson Hsieh.
3418
3419         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3420         DumpRenderTree and TestWebKitAPI, which both try to create an
3421         NSDragItem in a manner that invokes this method. Address this by using
3422         -initWithPasteboardWriter instead.
3423
3424         Note that the parameter passed to initWithPasteboardWriter is likely
3425         incorrect. In both cases, the object passed does not conform to
3426         NSPasteboardWriting. However, with this fix, we're no worse off than
3427         before, and can now perform builds with newer compilers and SDKs until
3428         a real fix can be crafted. That work is tracked in
3429         https://bugs.webkit.org/show_bug.cgi?id=194060
3430
3431         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3432         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3433         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3434         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3435
3436 2019-01-30  Daniel Bates  <dabates@apple.com>
3437
3438         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3439         https://bugs.webkit.org/show_bug.cgi?id=192824
3440         <rdar://problem/47100332>
3441
3442         Reviewed by Wenson Hsieh.
3443
3444         Fix a bug where the wrong usage code was used for F13 thru F24.
3445
3446         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3447         (keyCodeForDOMFunctionKey):
3448
3449 2019-01-30  Chris Dumez  <cdumez@apple.com>
3450
3451         Regression(PSON) Load hang can occur on history navigation
3452         https://bugs.webkit.org/show_bug.cgi?id=194030
3453         <rdar://problem/47656939>
3454
3455         Reviewed by Antti Koivisto.
3456
3457         Add API test coverage.
3458
3459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3460
3461 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3462
3463         [LFC] Expand tests coverage.
3464
3465         Unreviewed test gardening.
3466
3467         * LayoutReloaded/misc/LFC-passing-tests.txt:
3468
3469 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3470
3471         [Flatpak] Add openjpeg support
3472         https://bugs.webkit.org/show_bug.cgi?id=194019
3473
3474         Reviewed by Michael Catanzaro.
3475
3476         * flatpak/org.webkit.CommonModules.yaml:
3477
3478 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3479
3480         Unreviewed, rolling out r240708.
3481         https://bugs.webkit.org/show_bug.cgi?id=194022
3482
3483         It broke WPE build (Requested by KaL on #webkit).
3484
3485         Reverted changeset:
3486
3487         "[WPE] Bump font related dependencies to match the GTK+ port"
3488         https://bugs.webkit.org/show_bug.cgi?id=194017
3489         https://trac.webkit.org/changeset/240708
3490
3491 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3492
3493         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3494         https://bugs.webkit.org/show_bug.cgi?id=194001
3495
3496         Reviewed by Antti Koivisto.
3497
3498         * LayoutReloaded/misc/LFC-passing-tests.txt:
3499
3500 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3501
3502         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3503         https://bugs.webkit.org/show_bug.cgi?id=194020
3504
3505         Reviewed by Antti Koivisto.
3506
3507         * LayoutReloaded/misc/LFC-passing-tests.txt:
3508
3509 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3510
3511         AX: Support color well on iOS
3512         https://bugs.webkit.org/show_bug.cgi?id=194010
3513
3514         Reviewed by Joanmarie Diggs.
3515
3516         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3517         (WTR::AccessibilityUIElement::stringAttributeValue):
3518
3519 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3520
3521         [WPE] Bump font related dependencies to match the GTK+ port
3522         https://bugs.webkit.org/show_bug.cgi?id=194017
3523
3524         Reviewed by Žan Doberšek.
3525
3526         * wpe/jhbuild.modules:
3527         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3528         * wpe/patches/icudata-stdlibs.patch: Added.
3529
3530 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3531
3532         [Mac] Update window scale API usage
3533         https://bugs.webkit.org/show_bug.cgi?id=193991
3534         rdar://problem/47614795
3535
3536         Reviewed by Tim Horton.
3537
3538         * DumpRenderTree/mac/DumpRenderTree.mm:
3539         (changeWindowScaleIfNeeded):
3540         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3541         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3542         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3543
3544 2019-01-29  Chris Dumez  <cdumez@apple.com>
3545
3546         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3547         https://bugs.webkit.org/show_bug.cgi?id=193977
3548         <rdar://problem/47643716>
3549
3550         Reviewed by Geoff Garen.
3551
3552         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3553         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3554         to the previous provisional committing *before* we make the last load. 
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3557
3558 2019-01-29  Youenn Fablet  <youenn@apple.com>
3559
3560         Adopt new SPI to evaluate server certificate trust
3561         https://bugs.webkit.org/show_bug.cgi?id=193355
3562
3563         Reviewed by Alex Christensen.
3564
3565         Add infrastructure to handle HTTPS server trust evaluation testing.
3566
3567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3568         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3569         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3570         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3571         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3573         * WebKitTestRunner/TestController.cpp:
3574         (WTR::TestController::resetPreferencesToConsistentValues):
3575         (WTR::TestController::didReceiveAuthenticationChallenge):
3576         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3577         * WebKitTestRunner/TestController.h:
3578         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3579         * WebKitTestRunner/TestInvocation.cpp:
3580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3581         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3582         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3583
3584 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3585
3586         [ews-build] Add build step to print bot Configuration
3587         https://bugs.webkit.org/show_bug.cgi?id=193887
3588
3589         Reviewed by Lucas Forschler.
3590
3591         * BuildSlaveSupport/ews-build/steps.py:
3592         (PrintConfiguration): Build step to print configuration.
3593         * BuildSlaveSupport/ews-build/factories.py:
3594
3595 2019-01-29  Chris Dumez  <cdumez@apple.com>
3596
3597         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3598         https://bugs.webkit.org/show_bug.cgi?id=193967
3599         <rdar://problem/47635348>
3600
3601         Reviewed by Alex Christensen.
3602
3603         Add API test coverage.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3606         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3607
3608 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews-app] Handle incoming results data
3611         https://bugs.webkit.org/show_bug.cgi?id=193973
3612
3613         Reviewed by Lucas Forschler.
3614
3615         * BuildSlaveSupport/ews-app/ews/views/results.py:
3616
3617 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-app] Make the results url generic
3620         https://bugs.webkit.org/show_bug.cgi?id=193928
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-app/ews/urls.py:
3625
3626 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3627
3628         [ews-build] Configure buildbot to send events to ews-app
3629         https://bugs.webkit.org/show_bug.cgi?id=193968
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * BuildSlaveSupport/ews-build/events.py: Added.
3634         * BuildSlaveSupport/ews-build/master.cfg:
3635
3636 2019-01-29  Keith Rollin  <krollin@apple.com>
3637
3638         Add .xcfilelists to Run Script build phases
3639         https://bugs.webkit.org/show_bug.cgi?id=193792
3640         <rdar://problem/47201785>
3641
3642         Reviewed by Alex Christensen.
3643
3644         As part of supporting XCBuild, update the necessary Run Script build
3645         phases in their Xcode projects to refer to their associated
3646         .xcfilelist files.
3647
3648         Note that the addition of these files bumps the Xcode project version
3649         number to something that's Xcode 10 compatible. This change means that
3650         older versions of the Xcode IDE can't read these projects. Nor can it
3651         fully load workspaces that refer to these projects (the updated
3652         projects are shown as non-expandable placeholders). `xcodebuild` can
3653         still build these projects; it's just that the IDE can't open them.
3654
3655         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3656         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3657
3658 2019-01-29  John Wilander  <wilander@apple.com>
3659
3660         Add data abstraction and validation for Ad Click Attribution
3661         https://bugs.webkit.org/show_bug.cgi?id=193916
3662         <rdar://problem/47603481>
3663
3664         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3665
3666         Ad click attribution has two steps. First, the storage of an ad
3667         campaign ID for a click that takes the user to a destination
3668         site. Second, a conversion on the destination site that can be
3669         attributed to the ad click.
3670
3671         This patch adds a class that represents a request for ad click
3672         attribution. Validation makes sure that the bits of entropy
3673         reported through this mechanism is limited.
3674
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3676         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3677         (TestWebKitAPI::TEST):
3678
3679 2019-01-29  Chris Dumez  <cdumez@apple.com>
3680
3681         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3682         https://bugs.webkit.org/show_bug.cgi?id=193932
3683         <rdar://problem/47598947>
3684
3685         Reviewed by Brady Eidson.
3686
3687         Add API test coverage.
3688
3689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3690
3691 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3692
3693         Adding new passing LFC tests.
3694
3695         Unreviewed test gardening.
3696
3697         * LayoutReloaded/misc/LFC-passing-tests.txt:
3698
3699 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3700
3701         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3702         https://bugs.webkit.org/show_bug.cgi?id=193964
3703
3704         Reviewed by Antti Koivisto.
3705
3706         * LayoutReloaded/misc/LFC-passing-tests.txt:
3707
3708 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3709
3710         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3711         https://bugs.webkit.org/show_bug.cgi?id=193954
3712
3713         Reviewed by Antti Koivisto.
3714
3715         * LayoutReloaded/misc/LFC-passing-tests.txt:
3716
3717 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3718
3719         WebDriver: add support for running subtests
3720         https://bugs.webkit.org/show_bug.cgi?id=193904
3721
3722         Reviewed by Michael Catanzaro.
3723
3724         pytest already supports it by passing test.py::subtest, so we can do the same.
3725
3726         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3727         (get_item_name): Made this global.
3728         (CollectRecorder.__init__): Receive the parameter to ignore.
3729         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3730         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3731         (collect): Add parameter to ignore.
3732         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3733         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3734         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3735         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3736         (WebDriverTestRunnerSelenium.run): Ditto.
3737         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3738         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3739         (WebDriverTestRunnerW3C.run): Ditto.
3740
3741 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3742
3743         User agent string override for navigator.userAgent should be site specific quirks
3744         https://bugs.webkit.org/show_bug.cgi?id=193950
3745
3746         Reviewed by Brent Fulgham.
3747
3748         Updated per the _WKWebsitePolicies rename.
3749
3750         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3751         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3752
3753 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3754
3755         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3756         https://bugs.webkit.org/show_bug.cgi?id=193941
3757
3758         Reviewed by Alex Christensen.
3759
3760         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3761         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3762         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3763         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3764         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3765         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3766         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3767         * TestWebKitAPI/Tests/WTF/Time.cpp:
3768         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3769         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3770         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3771         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3772
3773 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3774
3775         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3776
3777         * Scripts/webkitpy/common/config/contributors.json:
3778
3779 2019-01-28  Andy Estes  <aestes@apple.com>
3780
3781         [watchOS] Enable Parental Controls content filtering
3782         https://bugs.webkit.org/show_bug.cgi?id=193939
3783         <rdar://problem/46641912>
3784
3785         Reviewed by Ryosuke Niwa.
3786
3787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3788
3789 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3790
3791         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3792         <https://webkit.org/b/193884>
3793
3794         Reviewed by Jiewen Tan.
3795
3796         * Scripts/webkitpy/style/checkers/cpp.py:
3797         (check_language): Add LocalAuthentication to
3798         `frameworks_with_soft_links`.
3799
3800 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3801
3802         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3803         https://bugs.webkit.org/show_bug.cgi?id=193891
3804
3805         Reviewed by Ross Kirsling.
3806
3807         There were three problems in window sizes of WebView and the host window.
3808         1. The sizes of pixel image output were incorrect.
3809         2. The host window is going to appear after window.resize was invoked.
3810         3. window.resize resized only the host window, not WebView.
3811
3812         This change solves them with a following approach.
3813         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3814         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3815            as well as DumpRenderTree in order to match the client area and the window area.
3816         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3817         d. PlatformWebView::setWindowFrame changes both window sizes.
3818         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3819
3820         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3821         (WTR::PlatformWebView::PlatformWebView): Create the host window
3822         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3823         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3824         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3825
3826 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3827
3828         [ews-app] Add method to save Step data to database
3829         https://bugs.webkit.org/show_bug.cgi?id=193890
3830
3831         Reviewed by Lucas Forschler.
3832
3833         * BuildSlaveSupport/ews-app/ews/models/step.py:
3834         (Step.save_step): Method to save step data.
3835         (Step.update_step): Method to update step data.
3836         (Step.get_existing_step): Method to fetch existing step from database.
3837         (Step.is_valid_result): Method to validate valid step result.
3838
3839 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3840
3841         [ews-app] Add method to save Build data to database
3842         https://bugs.webkit.org/show_bug.cgi?id=193735
3843
3844         Reviewed by Lucas Forschler.
3845
3846         * BuildSlaveSupport/ews-app/ews/models/build.py:
3847         (Build.save_build): Method to save build information to database.
3848         (Build.get_existing_build): Method to fetch existing build from database.
3849         (Build.is_valid_result): Method to validate build result.
3850         * BuildSlaveSupport/ews-app/ews/common/util.py:
3851         (is_valid_int_id): Method to validate valid id.
3852
3853 2019-01-28  Chris Dumez  <cdumez@apple.com>
3854
3855         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3856         https://bugs.webkit.org/show_bug.cgi?id=193915
3857         <rdar://problem/47560907>
3858
3859         Reviewed by Alex Christensen.
3860
3861         Add API test coverage.
3862
3863         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3864
3865 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3866
3867         [ews-app] Rename id variables
3868         https://bugs.webkit.org/show_bug.cgi?id=193883
3869
3870         Reviewed by Lucas Forschler.
3871
3872         * BuildSlaveSupport/ews-app/ews/models/build.py:
3873         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3874         * BuildSlaveSupport/ews-app/ews/models/step.py:
3875         * BuildSlaveSupport/ews-app/ews/urls.py:
3876         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3877         * BuildSlaveSupport/ews-app/ews/views/results.py:
3878         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3879
3880 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3881
3882         [ews-app] Allow certain fields to be empty
3883         https://bugs.webkit.org/show_bug.cgi?id=193892
3884
3885         Reviewed by Lucas Forschler.
3886
3887         * BuildSlaveSupport/ews-app/ews/models/build.py:
3888         * BuildSlaveSupport/ews-app/ews/models/step.py:
3889
3890 2019-01-28  Rob Buis  <rbuis@igalia.com>
3891
3892         Update MIME type parser
3893         https://bugs.webkit.org/show_bug.cgi?id=180526
3894
3895         Reviewed by Frédéric Wang.
3896
3897         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3898         (TestWebKitAPI::TEST):
3899
3900 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3901
3902         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3903         https://bugs.webkit.org/show_bug.cgi?id=193896
3904
3905         Reviewed by Antti Koivisto.
3906
3907         * LayoutReloaded/misc/LFC-passing-tests.txt:
3908
3909 2018-12-15  Darin Adler  <darin@apple.com>
3910
3911         Replace many uses of String::format with more type-safe alternatives
3912         https://bugs.webkit.org/show_bug.cgi?id=192742
3913
3914         Reviewed by Mark Lam.
3915
3916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3917         (WTR::cacheTestRunnerCallback): Use makeString.
3918         * WebKitTestRunner/TestController.cpp:
3919         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3920         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3921
3922 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3923
3924         Use a load optimizer for some sites
3925         https://bugs.webkit.org/show_bug.cgi?id=193881
3926         <rdar://problem/46325455>
3927
3928         Reviewed by Brent Fulgham.
3929
3930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3931         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3932
3933 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3934
3935         AX: Introduce a static accessibility tree
3936         https://bugs.webkit.org/show_bug.cgi?id=193348
3937         <rdar://problem/47203295>
3938
3939         Reviewed by Ryosuke Niwa.
3940
3941         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3942
3943 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3944
3945         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3946         https://bugs.webkit.org/show_bug.cgi?id=193867
3947
3948         Reviewed by Antti Koivisto.
3949
3950         * LayoutReloaded/misc/LFC-passing-tests.txt:
3951
3952 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3953
3954         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3955         https://bugs.webkit.org/show_bug.cgi?id=193865
3956
3957         Reviewed by Antti Koivisto.
3958
3959         * LayoutReloaded/misc/LFC-passing-tests.txt:
3960
3961 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3962
3963         Need a mechanism to override navigator.userAgent
3964         https://bugs.webkit.org/show_bug.cgi?id=193762
3965         <rdar://problem/47504939>
3966
3967         Reviewed by Brent Fulgham.
3968
3969         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3970
3971         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3972         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3973         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3974
3975 2019-01-25  Dean Jackson  <dino@apple.com>
3976
3977         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3978         https://bugs.webkit.org/show_bug.cgi?id=193831
3979         <rdar://problem/47399263>
3980
3981         Reviewed by Chris Dumez.
3982
3983         Two new tests that exercise cross-origin and same-origin System
3984         Previews.
3985
3986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3987
3988 2019-01-25  Keith Rollin  <krollin@apple.com>
3989
3990         Update Xcode projects with "Check .xcfilelists" build phase
3991         https://bugs.webkit.org/show_bug.cgi?id=193790
3992         <rdar://problem/47201374>
3993
3994         Reviewed by Alex Christensen.
3995
3996         Support for XCBuild includes specifying inputs and outputs to various
3997         Run Script build phases. These inputs and outputs are specified as
3998         .xcfilelist files. Once created, these .xcfilelist files need to be
3999         kept up-to-date. In order to check that they are up-to-date or not,
4000         add an Xcode build step that invokes an external script that performs
4001         the checking. If the .xcfilelists are found to be out-of-date, update
4002         them, halt the build, and instruct the developer to restart the build
4003         with up-to-date files.
4004
4005         At this time, the checking and regenerating is performed only if the
4006         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4007         who want to use this facility can set this variable and test out the
4008         checking/regenerating. Once it seems like there are no egregious
4009         issues that upset a developer's workflow, we'll unconditionally enable
4010         this facility.
4011
4012         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4013         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4014         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4016
4017 2019-01-25  Keith Rollin  <krollin@apple.com>
4018
4019         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4020         https://bugs.webkit.org/show_bug.cgi?id=193781
4021         <rdar://problem/47201153>
4022
4023         Reviewed by Alex Christensen.
4024
4025         Part of generating the .xcfilelists used as part of adopting XCBuild
4026         includes running `make DerivedSources.make` from a standalone script.
4027         It’s important for this invocation to have the same environment as
4028         when the actual build invokes `make DerivedSources.make`. If the
4029         environments are different, then the two invocations will provide
4030         different results. In order to get the same environment in the
4031         standalone script, have the script launch xcodebuild targeting the
4032         "Apply Configuration to XCFileLists" build target, which will then
4033         re-invoke our standalone script. The script is now running again, this
4034         time in an environment with all workspace, project, target, xcconfig
4035         and other environment variables established.
4036
4037         The "Apply Configuration to XCFileLists" build target accomplishes
4038         this task via a small embedded shell script that consists only of:
4039
4040             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
4041
4042         The process that invokes "Apply Configuration to XCFileLists" first
4043         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
4044         evaluated and exports it into the shell environment. When xcodebuild
4045         is invoked, it inherits the value of this variable and can `eval` the
4046         contents of that variable. Our external standalone script can then set
4047         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
4048         of command-line parameters needed to restart itself in the appropriate
4049         state.
4050
4051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4052         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4053
4054 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4055
4056         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
4057         https://bugs.webkit.org/show_bug.cgi?id=193802
4058         <rdar://problem/46010580>
4059
4060         Reviewed by Andy Estes.
4061
4062         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4063         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
4064         (TEST):
4065
4066 2019-01-25  Daniel Bates  <dabates@apple.com>
4067
4068         [iOS] uiController.keyDown() does not translate Control modified key
4069         https://bugs.webkit.org/show_bug.cgi?id=192898
4070
4071         Reviewed by Wenson Hsieh.
4072
4073         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
4074         key translation, as applicable. Among other cases, key translation occurs when performing
4075         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
4076         also makes the behavior of uiController.keyDown() more closely match the behavior of a
4077         human pressing down and releasing key(s) using a hardware keyboard.
4078
4079         * WebKitTestRunner/ios/HIDEventGenerator.h:
4080         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4081         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
4082
4083         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
4084         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
4085         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4086         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4087         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
4088         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4089         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
4090         (-[HIDEventGenerator longPress:completionBlock:]):
4091         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
4092         Update code for above renaming.
4093
4094         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
4095         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
4096
4097         (-[HIDEventGenerator keyDown:]): Added.
4098         (-[HIDEventGenerator keyUp:]): Added.
4099         (-[HIDEventGenerator keyPress:completionBlock:]):
4100         (-[HIDEventGenerator eventDispatchThreadEntry:]):
4101         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
4102         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4103         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
4104         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
4105         (WTR::parseModifier): Deleted.
4106
4107 2019-01-25  Keith Rollin  <krollin@apple.com>
4108
4109         Complete the implementation of generate-xcfilelists
4110         https://bugs.webkit.org/show_bug.cgi?id=193782
4111
4112         Reviewed by Alex Christensen.
4113
4114         A preliminary version of generate-xcfilelists was added in r238008.
4115         This patch updates that script in order to:
4116
4117         - Support checking of .xcfilelists
4118         - Perform better execution of `make DerivedSources.make` by
4119           relaunching generate-xcfilelists under xcodebuild
4120         - Support incremental generation and checking of .xcfilelists
4121         - Support supplementary .xcfilelists files from WebKitAdditions
4122         - Support being wrapped by parallel version of generate-xcfilelists in
4123           Internal that adds support for (re)generating WebKit projects in
4124           that repo.
4125         - Support builds that have been performed in WebKitBuild as well as
4126           ~/Library/Developer/code/DerivedData
4127         - Increase robustness and debugging facilities.
4128
4129         * Scripts/generate-xcfilelists:
4130
4131 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4132
4133         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4134         https://bugs.webkit.org/show_bug.cgi?id=193297
4135         <rdar://problem/47158841>
4136
4137         Unreviewed test case fix.
4138
4139         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
4140         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
4141
4142         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4143         (TEST):
4144
4145 2019-01-25  Keith Rollin  <krollin@apple.com>
4146
4147         Update existing .xcfilelists
4148         https://bugs.webkit.org/show_bug.cgi?id=193791
4149         <rdar://problem/47201706>
4150
4151         Reviewed by Alex Christensen.
4152
4153         Many .xcfilelist files were added in r238824 in order to support
4154         XCBuild. Update these with recent changes to the set of build files
4155         and with the current generate-xcfilelist script.
4156
4157         * DumpRenderTree/DerivedSources-input.xcfilelist:
4158         * DumpRenderTree/DerivedSources-output.xcfilelist:
4159         * WebKitTestRunner/DerivedSources-input.xcfilelist:
4160         * WebKitTestRunner/DerivedSources-output.xcfilelist:
4161
4162 2019-01-25  Keith Rollin  <krollin@apple.com>
4163
4164         Fix missing dependencies in extract-dependencies-from-makefile
4165         https://bugs.webkit.org/show_bug.cgi?id=193783
4166         <rdar://problem/47201571>
4167
4168         Reviewed by Alex Christensen.
4169
4170         The extract-dependencies-from-makefile script generates .xcfilelists
4171         for XCBuild by invoking a makefile in --debug mode, parsing the
4172         dependency information in the output, and extracting information
4173         regarding targets and dependents. However, the way `make` emits this
4174         dependency information is not rigorous, and so we need to determine
4175         what lines to look for and parse by trial and error. This approach
4176         didn't coriginally atch all the information we needed to collect, so
4177         update the script to look for the additional lines we now know to look
4178         for.
4179
4180         * Scripts/extract-dependencies-from-makefile:
4181         (Parser):
4182         (Parser.addTarget):
4183         (Parser.addPrereq):
4184         (Parser.doParse):
4185
4186 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4187
4188         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4189         https://bugs.webkit.org/show_bug.cgi?id=193297
4190         <rdar://problem/47158841>
4191
4192         Reviewed by Alex Christensen.
4193
4194         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4195             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4197         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4198         activating the message used to trigger the callback when it is set.
4199
4200 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4201
4202         WKWebView.goBack should reload if there is a safe browsing warning
4203         https://bugs.webkit.org/show_bug.cgi?id=193805
4204         <rdar://problem/46908216>
4205
4206         Reviewed by Geoff Garen.
4207
4208         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4209         (+[Simple3LookupContext sharedLookupContext]):
4210         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4211         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4212         (TEST):
4213
4214 2019-01-25  Chris Dumez  <cdumez@apple.com>
4215
4216         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4217         https://bugs.webkit.org/show_bug.cgi?id=193788
4218         <rdar://problem/47531231>
4219
4220         Reviewed by Alex Christensen.
4221
4222         Add API test coverage.
4223
4224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4225         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4226
4227 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4228
4229         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4230         https://bugs.webkit.org/show_bug.cgi?id=193771
4231
4232         Unreviewed infrastructure fix.
4233
4234         * Scripts/webkitpy/port/darwin.py:
4235         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4236
4237 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4238
4239         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4240
4241 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4242
4243         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4244
4245         * Scripts/webkitpy/common/config/contributors.json:
4246
4247 2019-01-25  Chris Dumez  <cdumez@apple.com>
4248
4249         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4250         https://bugs.webkit.org/show_bug.cgi?id=193779
4251         <rdar://problem/46170903>
4252
4253         Reviewed by Antti Koivisto.
4254
4255         Add API test that quickly navigates forward to a previous process without waiting for it to
4256         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4257         the process' previous page when reconnecting the it for the forward navigation.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4260
4261 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4262
4263         Need a way for JavaScript (or bundle) code to participate in undo
4264         https://bugs.webkit.org/show_bug.cgi?id=190009
4265         <rdar://problem/44807048>
4266
4267         Reviewed by Ryosuke Niwa.
4268
4269         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4270         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4271
4272         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4273         (WTR::UIScriptController::lastUndoLabel const):
4274         (WTR::UIScriptController::firstRedoLabel const):
4275         (WTR::UIScriptController::platformUndoManager const):
4276         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4277         (WTR::UIScriptController::lastUndoLabel const):
4278         (WTR::UIScriptController::firstRedoLabel const):
4279         (WTR::UIScriptController::platformUndoManager const):
4280         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4281         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4282         (WTR::UIScriptController::lastUndoLabel const):
4283         (WTR::UIScriptController::firstRedoLabel const):
4284         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4285         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4286         (WTR::UIScriptController::lastUndoLabel const):
4287         (WTR::UIScriptController::firstRedoLabel const):
4288         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4289         (WTR::UIScriptController::platformUndoManager const):
4290         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4291         (WTR::UIScriptController::platformUndoManager const):
4292
4293 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4294
4295         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4296         https://bugs.webkit.org/show_bug.cgi?id=193824
4297
4298         Reviewed by Antti Koivisto.
4299
4300         * LayoutReloaded/misc/LFC-passing-tests.txt:
4301
4302 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4303
4304         Update macOS JSC bot configurations
4305         https://bugs.webkit.org/show_bug.cgi?id=193739
4306
4307         Reviewed by Alexey Proskuryakov.
4308
4309         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4311         (BubbleQueueServer): Move JSC EWS to Mojave section.
4312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4313         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4314         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4315
4316 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4317
4318         [Win][WebKitTestRunner] Implement EventSenderProxy
4319         https://bugs.webkit.org/show_bug.cgi?id=193755
4320
4321         Reviewed by Don Olmstead.
4322
4323         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4324         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4325         (WTR::EventSenderProxy::dispatchMessage):
4326         (WTR::EventSenderProxy::EventSenderProxy):
4327         (WTR::EventSenderProxy::mouseDown):
4328         (WTR::EventSenderProxy::mouseUp):
4329         (WTR::EventSenderProxy::mouseMoveTo):
4330         (WTR::EventSenderProxy::mouseScrollBy):
4331         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4332
4333 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4334
4335         Unreviewed fix for API test failure after r240437.
4336
4337         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4338
4339         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4340
4341 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4342
4343         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4344         https://bugs.webkit.org/show_bug.cgi?id=193787
4345         <rdar://problem/47497634>
4346
4347         Reviewed by Alexey Proskuryakov.
4348
4349         * Scripts/webkitdirs.pm:
4350         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4351
4352 2019-01-24  Truitt Savell  <tsavell@apple.com>
4353
4354         Unreviewed, rolling out r240446.
4355
4356         Casued 5 API failures
4357
4358         Reverted changeset:
4359
4360         "Activate the WebResourceLoadStatisticsStore in the
4361         NetworkProcess and deactivate it in the UIProcess."