File index appended to previous file in svn-create-patch with SVN 1.9
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
2
3         File index appended to previous file in svn-create-patch with SVN 1.9
4         https://bugs.webkit.org/show_bug.cgi?id=167903
5         <rdar://problem/30387395>
6
7         Reviewed by Daniel Bates.
8
9         * Scripts/VCSUtils.pm:
10         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
11         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
12         trailing newline character from the expected result before comparing it to the actual result.
13
14 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
15
16         [webkitdirs] remove unused host_processor variable in determineArchitecture()
17         https://bugs.webkit.org/show_bug.cgi?id=167936
18
19         Reviewed by Michael Catanzaro.
20
21         * Scripts/webkitdirs.pm:
22         (determineArchitecture):
23         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
24         since r195083.
25
26 2017-02-07  Youenn Fablet  <youenn@apple.com>
27
28         Use a JSON file to define which WPT files/folders to import
29         https://bugs.webkit.org/show_bug.cgi?id=167923
30
31         Reviewed by Alex Christensen.
32
33         * Scripts/webkitpy/w3c/test_downloader.py:
34         (TestDownloader.__init__):
35         (TestDownloader._init_paths_from_expectations):
36         * Scripts/webkitpy/w3c/test_importer.py:
37         (parse_args):
38         * Scripts/webkitpy/w3c/test_importer_unittest.py:
39
40 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
41
42         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
43         https://bugs.webkit.org/show_bug.cgi?id=167916
44
45         Reviewed by Carlos Garcia Campos.
46
47         URL of mesa-11.0.6.tar.xz has been moved.
48
49         * gtk/jhbuild.modules: Fix the module path.
50
51 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
52
53         Static Analyzer: Address some leaks in MiniBrowser
54         https://bugs.webkit.org/show_bug.cgi?id=167897
55
56         Reviewed by Alexey Proskuryakov.
57
58         * MiniBrowser/mac/BrowserWindowController.m:
59         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
60         * MiniBrowser/mac/ExtensionManagerWindowController.m:
61         (-[ExtensionManagerWindowController add:]):
62         (-[ExtensionManagerWindowController remove:]):
63         * MiniBrowser/mac/SettingsController.m:
64         (-[SettingsController _populateMenu]):
65         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
66         Address obvious leaks caught by the static analyzer.
67
68 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
69
70         Migrate ComplexTextController to use platform-independent types
71         https://bugs.webkit.org/show_bug.cgi?id=167833
72
73         Reviewed by Brent Fulgham.
74
75         Migrate tests away from platform-dependent types.
76
77         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
78         (TestWebKitAPI::TEST_F):
79
80 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
81
82         Correct File Path Handling in SecurityOrigin and FileSystem
83         https://bugs.webkit.org/show_bug.cgi?id=167894
84         <rdar://problem/30380080>
85
86         Reviewed by Alexey Proskuryakov.
87
88         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
89         and perform same-volume checks using filesystem-compatible paths.        
90         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
91         filesystem paths, and perform validation of same-volume checks.
92         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
93         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
94         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
95         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
96
97 2017-02-06  Jer Noble  <jer.noble@apple.com>
98
99         Playback stalls when a SourceBuffer append causes frame eviction
100         https://bugs.webkit.org/show_bug.cgi?id=167834
101
102         Reviewed by Eric Carlson.
103
104         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
105         for the WTF::MediaTime class.
106
107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
108         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
109         (TestWebKitAPI::TEST):
110         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
111         (WTF::operator<<):
112         (TestWebKitAPI::TestSample::create):
113         (TestWebKitAPI::TestSample::TestSample):
114         (TestWebKitAPI::TEST_F):
115
116 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
117
118         Change capitalization in platform name after r211735.
119
120         Unreviewed dashboard fix.
121
122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
123         (WebKitBuildbot):
124
125 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
126
127         Move the Leaks bot to Sierra
128         https://bugs.webkit.org/show_bug.cgi?id=167886
129
130         Reviewed by Daniel Bates.
131
132         * BuildSlaveSupport/build.webkit.org-config/config.json:
133         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
134         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
135         (LeaksViewer._displayURLPrompt):
136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
137         (WebKitBuildbot):
138
139 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
140
141         Prevent app crash on launch during simctl install workaround
142         https://bugs.webkit.org/show_bug.cgi?id=167685
143
144         Reviewed by Daniel Bates.
145
146         * Scripts/webkitpy/port/simulator_process.py:
147         (SimulatorProcess.__init__): Pass environment to install.
148         * Scripts/webkitpy/xcode/simulator.py:
149         (Device.install_app): Accept environment, pass environment to launch.
150
151 2017-02-06  Alex Christensen  <achristensen@webkit.org>
152
153         Rebase API tests after r211638
154         https://bugs.webkit.org/show_bug.cgi?id=167779
155
156         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
157         (TestWebKitAPI::TEST_F):
158         URLs with non-special schemes and characters like % in the host now fail to parse,
159         more like their special counterparts and according to spec.
160
161 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
162
163         Unreviewed trivial fix after r211697.
164         https://bugs.webkit.org/show_bug.cgi?id=167863
165
166         * Scripts/run-javascriptcore-tests:
167         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
168
169 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
170
171         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
172         https://bugs.webkit.org/show_bug.cgi?id=167850
173
174         Reviewed by Tim Horton.
175
176         * DumpRenderTree/TestRunner.cpp:
177         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
178
179 2017-02-04  Andreas Kling  <akling@apple.com>
180
181         Plug some leaks in TestController and UIScriptContext.
182         <https://webkit.org/b/167839>
183
184         Reviewed by Alexey Proskuryakov.
185
186         Fix a couple of the leaks seen on the leaks bot.
187
188         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
189         (UIScriptContext::runUIScript):
190         * WebKitTestRunner/TestController.cpp:
191         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
192         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
193
194 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
195
196         WK1 mouse events are missing movementX and movementY for pointerlock.
197         https://bugs.webkit.org/show_bug.cgi?id=167775
198         rdar://problem/30343810
199
200         Reviewed by Alexey Proskuryakov.
201
202         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
203
204         * DumpRenderTree/mac/EventSendingController.mm:
205         (-[EventSendingController mouseMoveToX:Y:]):
206         * WebKitTestRunner/mac/EventSenderProxy.mm:
207         (WTR::EventSenderProxy::mouseMoveTo):
208
209 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
210
211         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
212         https://bugs.webkit.org/show_bug.cgi?id=167774
213
214         Reviewed by Tim Horton.
215
216         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
217         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
218         web process are async, so the callback fires after the web process gets the new state.
219
220         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
221         (WTR::UIScriptController::removeViewFromWindow):
222         (WTR::UIScriptController::addViewToWindow):
223         * DumpRenderTree/mac/DumpRenderTree.mm:
224         (createWebViewAndOffscreenWindow):
225         (resetWebViewToConsistentStateBeforeTesting):
226         * DumpRenderTree/mac/DumpRenderTreeMac.h:
227         * DumpRenderTree/mac/UIScriptControllerMac.mm:
228         (WTR::UIScriptController::removeViewFromWindow):
229         (WTR::UIScriptController::addViewToWindow):
230         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
231         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
232         (WTR::UIScriptController::removeViewFromWindow):
233         (WTR::UIScriptController::addViewToWindow):
234         * TestRunnerShared/UIScriptContext/UIScriptController.h:
235         * WebKitTestRunner/PlatformWebView.h:
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::resetStateToConsistentValues):
238         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
239         (WTR::PlatformWebView::removeFromWindow):
240         (WTR::PlatformWebView::addToWindow):
241         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
242         (WTR::UIScriptController::removeViewFromWindow):
243         (WTR::UIScriptController::addViewToWindow):
244         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
245         (WTR::PlatformWebView::removeFromWindow):
246         (WTR::PlatformWebView::addToWindow):
247         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
248         (WTR::UIScriptController::removeViewFromWindow):
249         (WTR::UIScriptController::addViewToWindow):
250
251 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
252
253         Remove check for SkipSafariExecutableEntitlementChecks
254         https://bugs.webkit.org/show_bug.cgi?id=167762
255
256         Reviewed by Dan Bernstein.
257
258         Follow-up fix: don't break internal behavior.
259
260         * Scripts/webkitdirs.pm:
261         (safariPath):
262         (executableHasEntitlements): Deleted.
263         (safariPathFromSafariBundle): Deleted.
264         (installedSafariPath): Deleted.
265
266 2017-02-03  Daniel Bates  <dabates@apple.com>
267
268         [Mac][WK2] Add SPI to override the Content Security Policy of a page
269         https://bugs.webkit.org/show_bug.cgi?id=167810
270         <rdar://problem/30102568>
271
272         Reviewed by Anders Carlsson.
273
274         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
275
276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
277         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
278         (TEST):
279         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
280         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
281         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
282         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
283
284 2017-02-02  Alex Christensen  <achristensen@webkit.org>
285
286         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
287         https://bugs.webkit.org/show_bug.cgi?id=167773
288         <rdar://problem/30221102>
289
290         Reviewed by Ryosuke Niwa.
291
292         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
293         (TestWebKitAPI::TEST_F):
294
295 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
296
297         Remove check for SkipSafariExecutableEntitlementChecks
298         https://bugs.webkit.org/show_bug.cgi?id=167762
299         rdar://problem/22480673
300
301         Reviewed by Dan Bernstein.
302
303         * Scripts/webkitdirs.pm:
304         (safariPathFromSafariBundle):
305         (skipSafariExecutableEntitlementChecks): Deleted.
306
307 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
308
309         Undefined subroutine in svn-create-patch
310         https://bugs.webkit.org/show_bug.cgi?id=167742
311
312         Unreviewed build-fix after r211543.
313
314         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
315
316 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
317
318         Unreviewed. Fix jhbuild dependencies build.
319
320         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
321         Patch updated.
322
323 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
324
325         [EME][GStreamer] Fixed decryptor selection
326         https://bugs.webkit.org/show_bug.cgi?id=167588
327
328         Reviewed by Žan Doberšek.
329
330         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
331
332         * gtk/jhbuild.modules: Added patches to gstreamer and
333         gst-plugins-good packages.
334         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
335         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
336
337 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
338
339         Make run-benchmark script supports 'config' key in test plan.
340         https://bugs.webkit.org/show_bug.cgi?id=167715
341
342         Reviewed by Ryosuke Niwa.
343
344         Add support for 'config' key in test paln.
345         'config' key is a dictionary that specifies environment configurations while test is running.
346         Specifies orientation to be portrait in MotionMark benchmark.
347
348         * Scripts/webkitpy/benchmark_runner/README.md:
349         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
350         (BenchmarkRunner.__init__):
351         (BenchmarkRunner._run_benchmark):
352         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
353         (BrowserDriver.prepare_env):
354         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
355         (LinuxBrowserDriver.prepare_env):
356         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
357         (OSXBrowserDriver.prepare_env):
358         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
359         (OSXSafariDriver.prepare_env):
360         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
361
362 2017-02-01  Daniel Bates  <dabates@apple.com>
363
364         REGRESSION (r210820): svn-create-patch does not emit property change only diff
365         https://bugs.webkit.org/show_bug.cgi?id=167169
366
367         Reviewed by David Kilzer.
368
369         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
370         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
371         header from the output of "svn diff" on a file that was copied or moved.
372
373         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
374         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
375         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
376         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
377         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
378         of a file with only a property change also does not contain any chunk range lines. Therefore
379         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
380         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
381         we should directly test for the presence of a leading SVN diff header with an empty body and
382         remove such lines from the diff.
383
384         * Scripts/VCSUtils.pm:
385         (fixSVNPatchForAdditionWithHistory): Added.
386         * Scripts/svn-create-patch:
387         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
388         we have a non empty patch for an added file with history (i.e. a copied or moved file).
389         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
390
391 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
392
393         [Mac] Update CARingBuffer class
394         https://bugs.webkit.org/show_bug.cgi?id=167656
395
396         Reviewed by Jer Noble.
397
398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
399         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
400         (TestWebKitAPI::CARingBufferTest::SetUp):
401         (TestWebKitAPI::CARingBufferTest::setup):
402         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
403         (TestWebKitAPI::CARingBufferTest::description):
404         (TestWebKitAPI::CARingBufferTest::bufferList):
405         (TestWebKitAPI::CARingBufferTest::ringBuffer):
406         (TestWebKitAPI::CARingBufferTest::capacity):
407         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
408         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
409         (TestWebKitAPI::TEST_F):
410         (TestWebKitAPI::MixingTest::run):
411
412 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
413
414         [Mac] TestWebKitAPI includes system frameworks incorrectly
415         https://bugs.webkit.org/show_bug.cgi?id=167703
416         rdar://problem/30301498
417
418         Reviewed by Ryosuke Niwa.
419
420         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
421         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
422
423         Also, reduced the number of subframework search paths, looks like we only need one now.
424
425         * TestWebKitAPI/Configurations/Base.xcconfig:
426
427 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
428
429         Correct "filesHaveSameVolume" predicate
430         https://bugs.webkit.org/show_bug.cgi?id=167696
431         <rdar://problem/30298722>
432
433         Reviewed by David Kilzer.
434
435         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
436         percent-escaped path inputs.
437
438         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
439         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
440         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
441         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
442         (TestWebKitAPI::TEST_F):
443
444 2017-02-01  Tomas Popela  <tpopela@redhat.com>
445
446         Unreviewed. Fix coding style in MiniBrowser
447
448         * MiniBrowser/gtk/BrowserWindow.c:
449         (editingCommandCallback):
450         (insertImageCommandCallback):
451         (insertLinkCommandCallback):
452
453 2017-02-01  Tomas Popela  <tpopela@redhat.com>
454
455         [GTK] Add an API to add a custom tab into the print dialog
456         https://bugs.webkit.org/show_bug.cgi?id=151998
457
458         Reviewed by Carlos Garcia Campos.
459
460         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
461         that is testing a newly added API.
462
463         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
464         (testPrintCustomWidget):
465         (beforeAll):
466
467 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
468
469         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
470         https://bugs.webkit.org/show_bug.cgi?id=166529
471
472         Reviewed by Xabier Rodriguez-Calvar.
473
474         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
475         New patch version accepted in GStreamer upstream.
476
477 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
478
479         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
480         https://bugs.webkit.org/show_bug.cgi?id=167498
481
482         Reviewed by Carlos Garcia Campos.
483
484         Depending on the distro version you can need either libxfont1-dev
485         or libfont-dev to build with jhbuild.
486
487         * gtk/install-dependencies:
488
489 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
490
491         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
492         https://bugs.webkit.org/show_bug.cgi?id=167594
493
494         Unreviewed test gardening.
495
496         Disabling this test while we investigate the cause of a timeout on ios-simulator.
497
498         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
499         (TEST):
500
501 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
502
503         Move slow-running microbenchmarks out of JSTests/microbenchmarks
504         https://bugs.webkit.org/show_bug.cgi?id=167676
505
506         Reviewed by Saam Barati.
507
508         * Scripts/run-javascriptcore-tests:
509         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
510
511 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
512
513         Make Dump Render Tree not crash
514         https://bugs.webkit.org/show_bug.cgi?id=167667
515
516         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
517         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
518         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
519         This does not fix any tests, it just fixes the crash.
520         
521         Reviewed by Simon Fraser.
522
523         * DumpRenderTree/TestRunner.cpp:
524         (TestRunner::callUIScriptCallback):
525
526 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
527
528         Workaround for simctl install failing to report install failure
529         https://bugs.webkit.org/show_bug.cgi?id=167654
530
531         Reviewed by Daniel Bates.
532
533         simctl install will sometimes report success even though install has failed.
534         To workaround this bug, we attempt an app launch after install to ensure
535         install has succeeded.
536
537         * Scripts/webkitpy/xcode/simulator.py:
538         (Device.install_app): Attempt app launch after install, retry install if launch fails.
539         (Device.launch_app): Correct comment.
540
541 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
542
543         Unreviewed webkitpy fix after r211405.
544
545         * Scripts/webkitpy/xcode/simulator.py:
546         (Device.launch_app): Remove @staticmethod on _log_debug_error.
547
548 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
549
550         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
551
552         * gtk/manifest.txt.in:
553
554 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
555
556         AX: enable search predication for iOS
557         https://bugs.webkit.org/show_bug.cgi?id=167558
558         <rdar://problem/30251367>
559
560         Reviewed by Joanmarie Diggs.
561
562         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
563         (AccessibilityUIElement::uiElementForSearchPredicate):
564         * DumpRenderTree/mac/AccessibilityCommonMac.h:
565         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
566         (searchPredicateParameterizedAttributeForSearchCriteria):
567         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
568         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
569         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
570         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
571         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
572         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
573         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
574         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
575         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
576         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
577         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
578
579 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
580
581         Workaround for simctl launch bug
582         https://bugs.webkit.org/show_bug.cgi?id=167613
583
584         Reviewed by Daniel Bates.
585
586         simctl launch will sometimes fail because of a race condition when many
587         simulators are being run simultaneously. These failures will always have
588         an exit code of 1. This change attempts to launch an app multiple times
589         before reporting a failure to workaround this bug.
590
591         * Scripts/webkitpy/xcode/simulator.py:
592         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
593
594 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
595
596         Commit queue fails to look at real name aliases for the reviewer
597         https://bugs.webkit.org/show_bug.cgi?id=167422
598
599         Reviewed by Joseph Pecoraro.
600
601         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
602         (test_has_valid_reviewer): Added tests.
603
604         * Scripts/webkitpy/common/config/committers.py:
605         (CommitterList._name_to_contributor_map):
606         Made _name_to_contributor_map include alias names.
607
608         * Scripts/webkitpy/common/config/committers_unittest.py:
609         (CommittersTest.test_contributors_by_fuzzy_match):
610         Removed subtests that are now obsolete, as these matches are strict. It is not
611         obvious if distance based fuzzy matching for names is useful at all, but we can
612         look into that some other time.
613
614 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
615
616         QueueStatusServer should have an explicit timeout for _fetch_url
617         https://bugs.webkit.org/show_bug.cgi?id=167467
618
619         Reviewed by Alexey Proskuryakov.
620
621         * Scripts/webkitpy/common/net/statusserver.py:
622         (StatusServer._fetch_url): Add an explicit timeout of 300s.
623
624 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
625
626         Add support for Trac instances that host multiple projects.
627         https://bugs.webkit.org/show_bug.cgi?id=167524
628
629         Reviewed by Alexey Proskuryakov.
630
631         When multiple projects are hosted on a single Trac instance, the current
632         behavior will retrieve changesets from all tracked projects.
633         This patch teaches Trac.js to get project-specific changesets from Trac.
634         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
635         when querying the Trac timeline.
636
637         To tell Trac to be aware of multi-project instances we leverage the 
638         `options` parameter when creating a new instance: 
639
640             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
641
642         If this option is not provided, the original behaviour will prevail.
643         Additionally, add corresponding tests.
644
645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
646         (Trac): Reason about new optional parameter 'projectIdentifier'.
647         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
648         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
649         replace default parameter `changeset=on` with `repo-projectname=on`.
650         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
652         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
654         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
655         Add the following tests:
656             test("revisionURL")
657             test("revisionURL with Trac Identifier")
658             test("_xmlTimelineURL")
659             test("_xmlTimelineURL with Trac Identifier")
660         (this.view._latestProductiveIteration): Fix missing ';'.
661
662 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
663
664         Correct spacing regression on inter-element complex path shaping on some fonts
665         https://bugs.webkit.org/show_bug.cgi?id=166013
666
667         Reviewed by Simon Fraser.
668
669         Unskip existing tests and make some new tests:
670         - Testing complex text with no origins
671         - Testing initial expansions
672         - Testing the sign of vertical advances
673
674         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
675         (TestWebKitAPI::TEST_F):
676
677 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
678
679         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
680         https://bugs.webkit.org/show_bug.cgi?id=167596
681
682         Reviewed by Daniel Bates.
683
684         We avoid needing a thin directory by invoking the zip program with
685         the list of directories from the build directory to be zipped,
686         and by using the zip feature to exclude files matching a pattern.
687
688         * BuildSlaveSupport/built-product-archive:
689         (copyBuildFiles):
690         (createZipFromList):
691         (archiveBuiltProduct):
692
693 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
694
695         Use simctl instead of LayoutTestRelay
696         https://bugs.webkit.org/show_bug.cgi?id=165927
697
698         Reviewed by Daniel Bates.
699
700         Part 1
701
702         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
703         simulators through simctl (iOS 10 and later), use this functionality instead.
704
705         * Scripts/webkitpy/port/base.py:
706         (Port.__init__): Added _test_runner_process_constructor.
707         * Scripts/webkitpy/port/darwin.py:
708         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
709         * Scripts/webkitpy/port/driver.py:
710         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
711         (IOSSimulatorDriver): Deleted.
712         * Scripts/webkitpy/port/driver_unittest.py:
713         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
714         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
715         (DriverTest.test_start_actually_starts): Ditto.
716         * Scripts/webkitpy/port/ios.py:
717         (IOSSimulatorPort): Remove relay_name.
718         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
719         (IOSSimulatorPort._create_simulators): Formatting change.
720         (IOSSimulatorPort.relay_path): Deleted.
721         (IOSSimulatorPort._check_relay): Deleted.
722         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
723         (IOSSimulatorPort._build_relay): Deleted.
724         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
725         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
726         * Scripts/webkitpy/port/ios_unittest.py:
727         (iosTest.test_32bit): Update test.
728         (iosTest.test_64bit): Update test.
729         * Scripts/webkitpy/port/server_process.py:
730         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
731         (ServerProcess._set_file_nonblocking): Added to share common code.
732         * Scripts/webkitpy/port/server_process_mock.py:
733         (MockServerProcess.__init__): Added argument worker_number.
734         * Scripts/webkitpy/port/simulator_process.py: Added.
735         (SimulatorProcess): Added.
736         (SimulatorProcess.Popen): Added.
737         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
738         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
739         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
740         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
741         (SimulatorProcess._reset): Added. Unlink fifos.
742         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
743         (SimulatorProcess._kill): Added. Shutdown app on simulator.
744         * Scripts/webkitpy/xcode/simulator.py:
745         (Device.__init__): Accept host to run install/launch/terminate.
746         (Device.install_app): Install app to target Device.
747         (Device.launch_app): Launch app on target Device.
748         (Device.terminate_app): Shutdown app on target Device.
749         (Simulator._parse_devices): Pass host to Device.
750
751 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
752
753         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
754         https://bugs.webkit.org/show_bug.cgi?id=167411
755
756         Reviewed by Michael Catanzaro.
757
758         Disable the ARM iwMMXt fast path for pixman, because it triggers
759         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
760
761         * gtk/jhbuild.modules:
762
763 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
764
765         [GTK] Add API to handle the accelerated compositing policy
766         https://bugs.webkit.org/show_bug.cgi?id=167509
767
768         Reviewed by Michael Catanzaro.
769
770         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
771         as a special case. Also add test cases to the get/set API.
772
773         * MiniBrowser/gtk/BrowserSettingsDialog.c:
774         (hardwareAccelerationPolicyToString):
775         (stringToHardwareAccelerationPolicy):
776         (cellRendererChanged):
777         (browserSettingsDialogConstructed):
778         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
779         (testWebKitSettings):
780
781 2017-01-29  Andy Estes  <aestes@apple.com>
782
783         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
784         https://bugs.webkit.org/show_bug.cgi?id=167563
785         <rdar://problem/30253207>
786
787         Reviewed by Andreas Kling.
788
789         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
790         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
791         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
792         (runTest):
793         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
794         (TEST):
795
796 2017-01-29  Dan Bernstein  <mitz@apple.com>
797
798         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
799         https://bugs.webkit.org/show_bug.cgi?id=167565
800
801         Reviewed by Sam Weinig.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
805         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
806         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
807         (TEST):
808         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
809         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
810         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
811         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
812
813 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
814
815         Add Link Preload as an off-by-default experimental feature menu item.
816         https://bugs.webkit.org/show_bug.cgi?id=167201
817
818         Reviewed by Ryosuke Niwa.
819
820         * DumpRenderTree/mac/DumpRenderTree.mm:
821         (resetWebPreferencesToConsistentValues):
822         * DumpRenderTree/win/DumpRenderTree.cpp:
823         (resetWebPreferencesToConsistentValues):
824
825 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
826
827         Add User Timing Experimental Feature
828         https://bugs.webkit.org/show_bug.cgi?id=167542
829         <rdar://problem/22746307>
830
831         Reviewed by Ryosuke Niwa.
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (enableExperimentalFeatures):
835         (resetWebPreferencesToConsistentValues):
836         * DumpRenderTree/win/DumpRenderTree.cpp:
837         (enableExperimentalFeatures):
838
839 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
840
841         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
842         https://bugs.webkit.org/show_bug.cgi?id=167519
843
844         Reviewed by Ryosuke Niwa.
845
846         * QueueStatusServer/templates/statusbubble.html:
847         To measure the bubbleContainer's width, it must not be wrapping based
848         on its parent container. So when measuring the width temporarily set
849         the parent to a very large width so as to not artificially wrap us.
850         Restore the parent's width after measuring.
851
852 2017-01-27  Andy Estes  <aestes@apple.com>
853
854         [iOS] Add a test for _WKNSFileManagerExtras
855         https://bugs.webkit.org/show_bug.cgi?id=167478
856
857         Reviewed by Andreas Kling.
858
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
861         (expectAttributes):
862         (TEST):
863
864 2017-01-27  Keith Miller  <keith_miller@apple.com>
865
866         run-benchmarks should make sure it passes the test url to the right application
867         https://bugs.webkit.org/show_bug.cgi?id=167533
868
869         Reviewed by Joseph Pecoraro.
870
871         This fixes an issue when trying to run-benchmark script with the
872         system default browser set to STP. Previously, it would run
873         the test in STP rather than the provided build. Now, it should run
874         in the provided build.
875
876         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
877         (OSXSafariDriver.launch_url):
878
879 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
880
881         [Cocoa] Prepare ComplexTextController for unit testing
882         https://bugs.webkit.org/show_bug.cgi?id=167493
883
884         Reviewed by Simon Fraser.
885
886         Addressing post-review comments from Simon Fraser.
887
888         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
889         (TestWebKitAPI::TEST_F):
890
891 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
892
893         [Cocoa] Prepare ComplexTextController for unit testing
894         https://bugs.webkit.org/show_bug.cgi?id=167493
895
896         Reviewed by Dean Jackson.
897
898         Create four unit tests.
899
900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
901         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
902         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
903         (TestWebKitAPI::TEST_F):
904
905 2017-01-26  Chris Dumez  <cdumez@apple.com>
906
907         Crash when navigating back to a page in PacheCache when one of its frames has been removed
908         https://bugs.webkit.org/show_bug.cgi?id=167421
909         <rdar://problem/30188490>
910
911         Reviewed by Darin Adler.
912
913         Add a new setting allowing layout tests to enable PageCache in a window
914         that has an opener, for convenience.
915
916         * DumpRenderTree/mac/DumpRenderTree.mm:
917         (resetWebPreferencesToConsistentValues):
918         * DumpRenderTree/win/DumpRenderTree.cpp:
919         (resetWebPreferencesToConsistentValues):
920         * WebKitTestRunner/TestController.cpp:
921         (WTR::TestController::resetPreferencesToConsistentValues):
922
923 2017-01-26  Keith Miller  <keith_miller@apple.com>
924
925         classInfo should take a VM so it is not materialized from the object on each call
926         https://bugs.webkit.org/show_bug.cgi?id=167424
927
928         Rubber Stamped by Michael Saboff.
929
930         Previously, classInfo() would get the VM from the target's
931         MarkedBlock.  Most callers already have a VM on hand, so it is
932         wasteful to compute the VM from the marked block every time. This
933         patch refactors some of the most common callers of classInfo(),
934         jsDynamicCast and inherits to take a VM as well.
935
936         * DumpRenderTree/TestRunner.cpp:
937         (setAudioResultCallback):
938
939 2017-01-26  Jer Noble  <jer.noble@apple.com>
940
941         Autoplay muted videos stop playback of any streaming app in the background
942         https://bugs.webkit.org/show_bug.cgi?id=163993
943         <rdar://problem/29020431>
944
945         Reviewed by Eric Carlson.
946
947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
948         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
949         (TestWebKitAPI::TEST):
950         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
951
952 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
953
954         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
955         https://bugs.webkit.org/show_bug.cgi?id=167466
956
957         Unreviewed test gardening.
958
959         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
960         (TEST):
961
962 2017-01-26  Matt Rajca  <mrajca@apple.com>
963
964         Notify clients when the user plays media otherwise prevented from autoplaying
965         https://bugs.webkit.org/show_bug.cgi?id=167390
966
967         Reviewed by Alex Christensen.
968
969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
970         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
971         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
972         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
973         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
974         (TEST):
975         * TestWebKitAPI/cocoa/TestWKWebView.h:
976         * TestWebKitAPI/cocoa/TestWKWebView.mm:
977         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
978         (-[TestWKWebView waitForLoad]):
979         (-[TestWKWebView mouseUpAtPoint:]):
980         * WebKitTestRunner/TestController.cpp:
981         (WTR::TestController::createOtherPage):
982         (WTR::TestController::createWebViewWithOptions):
983
984 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
985
986         Crash when setting custom scale factor.
987         https://bugs.webkit.org/show_bug.cgi?id=167369
988
989         Reviewed by Sam Weinig.
990
991         Added API test.
992
993         * TestWebKitAPI/PlatformWin.cmake:
994         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
995         (TestWebKitAPI::WebKitCreateInstance):
996         (TestWebKitAPI::ScaleWebView::SetUp):
997         (TestWebKitAPI::ScaleWebView::TearDown):
998         (TestWebKitAPI::TEST_F):
999
1000 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1001
1002         run-benchmark nests MotionMark results by the suite name twice
1003         https://bugs.webkit.org/show_bug.cgi?id=164948
1004
1005         Reviewed by Said Abou-Hallawa.
1006
1007         Use a single level MotionMark now that this is the name of the benchmark,
1008         and we no longer have tests that aren't part of the MotionMark suite.
1009
1010         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1011
1012 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1013
1014         Unreviewed, rolling out r211193.
1015
1016         This change broke internal builds.
1017
1018         Reverted changeset:
1019
1020         "Notify clients when the user plays media otherwise prevented
1021         from autoplaying"
1022         https://bugs.webkit.org/show_bug.cgi?id=167390
1023         http://trac.webkit.org/changeset/211193
1024
1025 2017-01-25  Matt Rajca  <mrajca@apple.com>
1026
1027         Notify clients when the user plays media otherwise prevented from autoplaying
1028         https://bugs.webkit.org/show_bug.cgi?id=167390
1029
1030         Reviewed by Alex Christensen.
1031
1032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1033         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1034         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1035         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1036         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1037         (TEST):
1038         * TestWebKitAPI/cocoa/TestWKWebView.h:
1039         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1040         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1041         (-[TestWKWebView waitForLoad]):
1042         (-[TestWKWebView mouseUpAtPoint:]):
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::createOtherPage):
1045         (WTR::TestController::createWebViewWithOptions):
1046
1047 2017-01-25  Matt Rajca  <mrajca@apple.com>
1048
1049         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1050         https://bugs.webkit.org/show_bug.cgi?id=167385
1051
1052         Reviewed by Alex Christensen.
1053
1054         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1055         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1057         (TEST): Allow inline (rather than full screen) media playback on iOS.
1058
1059 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1060
1061         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1062         https://bugs.webkit.org/show_bug.cgi?id=167414
1063
1064         Reviewed by Michael Catanzaro.
1065
1066         Add a test case to check ephemeral web views don't write favicons to the database.
1067
1068         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1069         (ephemeralViewLoadChanged):
1070         (testPrivateBrowsing):
1071         (testFaviconDatabase):
1072
1073 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         [GTK] Add a private browsing mode to MiniBrowser
1076         https://bugs.webkit.org/show_bug.cgi?id=167413
1077
1078         Reviewed by Michael Catanzaro.
1079
1080         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1081         private windows, even on non-private instances.
1082
1083         * MiniBrowser/gtk/BrowserWindow.c:
1084         (webViewTitleChanged): Add [Private] to title window for private windows.
1085         (webViewCreate): Pass web context to browser_window_new.
1086         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1087         (browserWindowFinalize): Disconnect web context signal handlers.
1088         (browser_window_init): Add shortcut for opening private window.
1089         (browser_window_new): It now receives the context and connect to download-started here.
1090         (browser_window_get_web_context): Return the context.
1091         * MiniBrowser/gtk/BrowserWindow.h:
1092         * MiniBrowser/gtk/main.c:
1093         (createBrowserTab): Create the web view for the window web context.
1094         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1095         (aboutDataHandleRequest): Ditto.
1096         (aboutURISchemeRequestCallback): Ditto.
1097         (main): Create ephemeral web context if private command line option is used.
1098
1099 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1100
1101         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1102         https://bugs.webkit.org/show_bug.cgi?id=167409
1103
1104         Reviewed by Antti Koivisto.
1105
1106         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1107         as well as tests for the newly added matchingElementInFlatTree.
1108
1109         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1110         (TestWebKitAPI::runJavaScriptAlert):
1111         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1112         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1113         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1114
1115 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1116
1117         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1118         https://bugs.webkit.org/show_bug.cgi?id=167370
1119
1120         Reviewed by Michael Catanzaro.
1121
1122         Add several test cases of ephemeral web views.
1123
1124         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1125         (testWebViewAuthenticationStorage):
1126         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1127         (ephemeralViewloadChanged):
1128         (testCookieManagerEphemeral):
1129         (beforeAll):
1130         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1131         (testWebKitSettings):
1132         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1133         (testWebContextEphemeral):
1134         (ephemeralViewloadChanged):
1135         (testWebContextProxySettings):
1136         (beforeAll):
1137         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1138         (ephemeralViewloadChanged):
1139         (testWebViewEphemeral):
1140         (beforeAll):
1141         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1142         (ephemeralViewloadChanged):
1143         (testWebsiteDataEphemeral):
1144         (beforeAll):
1145
1146 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1147
1148         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1149         https://bugs.webkit.org/show_bug.cgi?id=167402
1150
1151         Reviewed by Ryosuke Niwa.
1152
1153         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1154         (TestWebKitAPI::TEST):
1155
1156 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1157
1158         Add simple line layout toggle to MiniBrowser
1159         https://bugs.webkit.org/show_bug.cgi?id=167405
1160
1161         Reviewed by Andreas Kling.
1162
1163         * MiniBrowser/mac/SettingsController.h:
1164         * MiniBrowser/mac/SettingsController.m:
1165         (-[SettingsController _populateMenu]):
1166         (-[SettingsController validateMenuItem:]):
1167         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1168         (-[SettingsController simpleLineLayoutEnabled]):
1169         * MiniBrowser/mac/WK1BrowserWindowController.m:
1170         (-[WK1BrowserWindowController didChangeSettings]):
1171         * MiniBrowser/mac/WK2BrowserWindowController.m:
1172         (-[WK2BrowserWindowController didChangeSettings]):
1173
1174 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1175
1176         WKR does not include my nick when commit-queue lands my patch
1177         https://bugs.webkit.org/show_bug.cgi?id=167388
1178
1179         Reviewed by Ryosuke Niwa.
1180
1181         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1182         (NewCommitBot._summarize_commit_log):
1183         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1184         Perform nickname insertion before grabbing "Patch by" details.
1185         This way we can include the nickname with the full name.
1186
1187 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1188
1189         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1190         https://bugs.webkit.org/show_bug.cgi?id=167394
1191
1192         Reviewed by Ryosuke Niwa.
1193
1194         * Scripts/webkitperl/FeatureList.pm:
1195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1196
1197 2017-01-24  Youenn Fablet  <youenn@apple.com>
1198
1199         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1200         https://bugs.webkit.org/show_bug.cgi?id=167353
1201
1202         Reviewed by Alex Christensen.
1203
1204         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1205         (CMakeGenerator.initialize_targets):
1206
1207 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1208
1209         WKR should not confuse Miguel Gomez with Andres Gomez
1210         https://bugs.webkit.org/show_bug.cgi?id=167389
1211
1212         Reviewed by Lucas Forschler.
1213
1214         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1215         "mAndres Gomez". Fix this.
1216
1217         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1218         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1219         space on each side of the email address, so expect both spaces to be there before
1220         considering the email for replacement.
1221         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1222
1223 2017-01-24  Matt Rajca  <mrajca@apple.com>
1224
1225         Pass down website autoplay policies to media elements
1226         https://bugs.webkit.org/show_bug.cgi?id=167355
1227
1228         Reviewed by Alex Christensen.
1229
1230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1231         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1232         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1233         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1234         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1235         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1236         (TEST):
1237
1238 2017-01-24  Nan Wang  <n_wang@apple.com>
1239
1240         AX: Speak Selection does not work in an iframe
1241         https://bugs.webkit.org/show_bug.cgi?id=166794
1242         <rdar://problem/29913013>
1243
1244         Reviewed by Chris Fleizach.
1245
1246         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1247         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1248         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1249         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1250         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1251         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1252         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1253         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1254         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1255         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1256         (-[TestRunnerWKWebView dealloc]):
1257         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1258         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1260         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1261         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1262
1263 2017-01-24  Daniel Bates  <dabates@apple.com>
1264
1265         StringView.split() should use an iterator design pattern instead of allocating a Vector
1266         https://bugs.webkit.org/show_bug.cgi?id=163225
1267
1268         Reviewed by Darin Adler.
1269
1270         Add unit tests for StringView.split().
1271
1272         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1273         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1274         used in the StringView.split() unit tests.
1275         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1276         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1277         object to a Vector of String objects.
1278         (TestWebKitAPI::TEST): Added the following tests:
1279             - WTF.StringViewSplitEmptyAndNullStrings
1280             - WTF.StringViewSplitBasic
1281             - WTF.StringViewSplitWithConsecutiveSeparators
1282
1283 2017-01-23  Anders Carlsson  <andersca@apple.com>
1284
1285         The Score Esports crashes on launch
1286         https://bugs.webkit.org/show_bug.cgi?id=167338
1287         rdar://problem/29948645
1288
1289         Reviewed by Dan Bernstein.
1290
1291         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1292         (TestWebKitAPI::TEST):
1293         Add a test.
1294
1295 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1296
1297         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1298         https://bugs.webkit.org/show_bug.cgi?id=146589
1299
1300         Reviewed by Michael Catanzaro.
1301
1302         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1303         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1304
1305         * MiniBrowser/gtk/BrowserWindow.c:
1306         (webViewDecidePolicy):
1307         (newTabCallback):
1308         * MiniBrowser/gtk/main.c:
1309         (createBrowserTab):
1310         (aboutDataRequestFree):
1311         (aboutDataRequestNew):
1312         (aboutDataRequestForView):
1313         (websiteDataRemovedCallback):
1314         (websiteDataClearedCallback):
1315         (aboutDataScriptMessageReceivedCallback):
1316         (domainListFree):
1317         (aboutDataFillTable):
1318         (gotWebsiteDataCallback):
1319         (aboutDataHandleRequest):
1320         (aboutURISchemeRequestCallback):
1321         (main):
1322         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1323         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1324         (serverCallback):
1325         (beforeAll):
1326         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1327         (serverCallback):
1328         (WebsiteDataTest::WebsiteDataTest):
1329         (WebsiteDataTest::~WebsiteDataTest):
1330         (WebsiteDataTest::fetch):
1331         (WebsiteDataTest::remove):
1332         (WebsiteDataTest::clear):
1333         (testWebsiteDataConfiguration):
1334         (testWebsiteDataCache):
1335         (testWebsiteDataStorage):
1336         (testWebsiteDataDatabases):
1337         (testWebsiteDataAppcache):
1338         (beforeAll):
1339         (afterAll):
1340
1341 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1342
1343         Unreviewed, rolling out r211062.
1344         https://bugs.webkit.org/show_bug.cgi?id=167354
1345
1346         broke API tests (Requested by alexchristensen on #webkit).
1347
1348         Reverted changeset:
1349
1350         "Pass down website autoplay policies to media elements"
1351         https://bugs.webkit.org/show_bug.cgi?id=167132
1352         http://trac.webkit.org/changeset/211062
1353
1354 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1355
1356         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1357         https://bugs.webkit.org/show_bug.cgi?id=167330
1358
1359         Reviewed by Tim Horton.
1360
1361         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1362         (TestWebKitAPI::TEST_F):
1363
1364 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1365
1366         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1367         https://bugs.webkit.org/show_bug.cgi?id=167317
1368
1369         Reviewed by Sam Weinig.
1370
1371         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1372         (TestWebKitAPI::TEST_F):
1373
1374 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1375
1376         svn-create-patch should emit properties when files are moved or copied
1377         https://bugs.webkit.org/show_bug.cgi?id=167264
1378
1379         Reviewed by Daniel Bates.
1380
1381         * Scripts/svn-create-patch:
1382         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1383
1384 2017-01-23  Youenn Fablet  <youenn@apple.com>
1385
1386         [WebRTC] Filter libwebrtc link flags
1387         https://bugs.webkit.org/show_bug.cgi?id=167287
1388
1389         Reviewed by Alex Christensen.
1390
1391         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1392         (CMakeGenerator._compute_link_flags):
1393         (CMakeGenerator._compute_link_flags.keep_flag):
1394         (CMakeGenerator._generate_compile_target_options):
1395
1396 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1397
1398         [WebRTC] Make VP8 optional in libwebrtc
1399         https://bugs.webkit.org/show_bug.cgi?id=167257
1400
1401         Reviewed by Darin Adler.
1402
1403         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1404         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1405
1406 2017-01-23  Jer Noble  <jer.noble@apple.com>
1407
1408         Video details does not apear and missing scrubber in Control Center
1409         https://bugs.webkit.org/show_bug.cgi?id=167233
1410
1411         Reviewed by Alex Christensen.
1412
1413         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1414         NowPlayingControlTests for iOS.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1418         (-[NowPlayingTestWebView setWindowVisible:]):
1419         (TestWebKitAPI::TEST):
1420         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1421         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1422         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1423         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1424         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1425         (SOFT_LINK_CLASS):
1426         (-[TestMessageHandler addMessage:withHandler:]):
1427         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1428         (__simulated_forceClickAssociatedEventsMask):
1429         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1430         (-[TestWKWebViewHostWindow isKeyWindow]):
1431         (-[TestWKWebViewHostWindow makeKeyWindow]):
1432         (-[TestWKWebViewHostWindow resignKeyWindow]):
1433         (-[TestWKWebView initWithFrame:]):
1434         (-[TestWKWebView initWithFrame:configuration:]):
1435         (-[TestWKWebView _setUpTestWindow:]):
1436         (-[TestWKWebView performAfterReceivingMessage:action:]):
1437         (-[TestWKWebView loadTestPageNamed:]):
1438         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1439         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1440         (-[TestWKWebView waitForMessage:]):
1441         (-[TestWKWebView performAfterLoading:]):
1442         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1443         (-[TestWKWebView typeCharacter:]):
1444
1445 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         Unreviewed. Bring back gtk-doc error messages after r209981.
1448
1449         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1450         impossible to know what's wrong.
1451
1452         * gtk/gtkdoc.py:
1453         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1454
1455 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1456
1457         [WebRTC] Update build system to make G711 optional in libwebrtc
1458         https://bugs.webkit.org/show_bug.cgi?id=167256
1459
1460         Reviewed by Alex Christensen.
1461
1462         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1463         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1464
1465 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1466
1467         Cleanup RuntimeEnabledFeatures
1468         https://bugs.webkit.org/show_bug.cgi?id=167228
1469
1470         Reviewed by Simon Fraser.
1471
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (enableExperimentalFeatures):
1474         (resetWebPreferencesToConsistentValues):
1475         (setWebPreferencesForTestOptions):
1476         (resetWebViewToConsistentStateBeforeTesting):
1477         * DumpRenderTree/win/DumpRenderTree.cpp:
1478         (enableExperimentalFeatures):
1479         (resetWebPreferencesToConsistentValues):
1480         More closely match WebKitTestRunner initialization of preferences
1481         for experimental features.
1482
1483 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1484
1485         Build Fix for Windows DumpRenderTree after r210976
1486         https://bugs.webkit.org/show_bug.cgi?id=167115
1487
1488         * DumpRenderTree/win/DumpRenderTree.cpp:
1489         (resetWebPreferencesToConsistentValues):
1490
1491 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1492
1493         Remove outdated ENABLE(CSP_NEXT) build flag
1494         https://bugs.webkit.org/show_bug.cgi?id=167252
1495
1496         Reviewed by Brent Fulgham.
1497
1498         * Scripts/webkitperl/FeatureList.pm:
1499         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1500
1501 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1502
1503         Build Fix for Windows DumpRenderTree after r210976
1504
1505         * DumpRenderTree/win/DumpRenderTree.cpp:
1506         (resetWebPreferencesToConsistentValues):
1507
1508 2017-01-20  Antoine Quint  <graouts@apple.com>
1509
1510         Web Animations should be off by default and enabled as an experimental feature
1511         https://bugs.webkit.org/show_bug.cgi?id=167115
1512         <rdar://problem/30048963>
1513
1514         Reviewed by Joseph Pecoraro.
1515
1516         Turn Web Animations on in DRT.
1517
1518         * DumpRenderTree/mac/DumpRenderTree.mm:
1519         (resetWebPreferencesToConsistentValues):
1520         * DumpRenderTree/win/DumpRenderTree.cpp:
1521         (resetWebPreferencesToConsistentValues):
1522
1523 2017-01-20  Youenn Fablet  <youenn@apple.com>
1524
1525         [WebRTC] Add libwebrtc build infrastructure
1526         https://bugs.webkit.org/show_bug.cgi?id=167207
1527
1528         Reviewed by Alex Christensen.
1529
1530         Adding a script doing the libwebrtc project json to CMake file conversion.
1531
1532         * Scripts/generate-libwebrtc-cmake: Added.
1533         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1534         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1535
1536 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1537
1538         Mini Browser: Show tooltip for Experimental Features
1539         https://bugs.webkit.org/show_bug.cgi?id=167225
1540
1541         Reviewed by Alex Christensen.
1542
1543         * MiniBrowser/mac/SettingsController.m:
1544         (-[SettingsController _populateMenu]):
1545         Include the full details string as a tooltip.
1546
1547 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1548
1549         [Win] Test output results should not be written twice.
1550         https://bugs.webkit.org/show_bug.cgi?id=167197
1551
1552         Reviewed by Brent Fulgham.
1553
1554         Prevent test output from being written twice by returning early from
1555         the dump() function, if it already has been called.
1556         This patch also adds a missing newline to a test output line. 
1557         
1558         * DumpRenderTree/win/DumpRenderTree.cpp:
1559         (dump):
1560
1561 2017-01-20  Antoine Quint  <graouts@apple.com>
1562
1563         [Modern Media Controls] Turn modern media controls on by default
1564         https://bugs.webkit.org/show_bug.cgi?id=165668
1565
1566         Reviewed by Dean Jackson.
1567
1568         Enabled modern media controls by default in test runners.
1569
1570         * DumpRenderTree/TestOptions.h:
1571         * WebKitTestRunner/TestOptions.h:
1572
1573 2017-01-19  Chris Dumez  <cdumez@apple.com>
1574
1575         iterable<> should be enabled on WK1
1576         https://bugs.webkit.org/show_bug.cgi?id=167221
1577         <rdar://problem/30108531>
1578
1579         Reviewed by Youenn Fablet.
1580
1581         * DumpRenderTree/mac/DumpRenderTree.mm:
1582         (resetWebPreferencesToConsistentValues):
1583         * DumpRenderTree/win/DumpRenderTree.cpp:
1584         (resetWebPreferencesToConsistentValues):
1585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1586         (WTR::InjectedBundle::beginTesting):
1587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1588         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1590
1591 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1592
1593         Ensure status server logs go to log file
1594         https://bugs.webkit.org/show_bug.cgi?id=167210
1595
1596         Reviewed by Alexey Proskuryakov.
1597
1598         * Scripts/webkitpy/common/net/statusserver.py:
1599         (StatusServer.next_work_item): Change log level from debug to info in
1600         order to facilitate deubgging issues.
1601         (StatusServer.update_work_items): Same.
1602
1603 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1604
1605         Additional selection tests and interpolation fix
1606         https://bugs.webkit.org/show_bug.cgi?id=167171
1607
1608         Reviewed by Simon Fraser.
1609
1610         We weren't adding the final event when interpolating event streams.
1611
1612         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1613         (-[HIDEventGenerator interpolatedEvents:]):
1614
1615 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1616
1617         [Cocoa] Variation fonts are erroneously disabled on iOS
1618         https://bugs.webkit.org/show_bug.cgi?id=167172
1619
1620         Reviewed by Simon Fraser.
1621
1622         OpenSource builders don't seem to understand sdk=embedded*.
1623
1624         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1625
1626 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         Unreviewed. Fix GTK+ unit tests failing since r210531.
1629
1630         Avoid using paths to files that don't actually exist.
1631
1632         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1633         (testWebKitConsoleMessageNetworkError):
1634         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1635         (testContextMenuDefaultMenu):
1636         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1637         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1638         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1639
1640 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1641
1642         [GTK] Provide API to set proxy settings
1643         https://bugs.webkit.org/show_bug.cgi?id=128674
1644
1645         Reviewed by Michael Catanzaro.
1646
1647         Add tests for new proxy settings API.
1648
1649         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1650         (serverCallback):
1651         (ProxyTest::ProxyTest):
1652         (ProxyTest::~ProxyTest):
1653         (ProxyTest::loadURIAndGetMainResourceData):
1654         (ProxyTest::proxyServerPortAsString):
1655         (testWebContextProxySettings):
1656         (beforeAll):
1657
1658 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1659
1660         Add back my old email address so old commits will still match it.
1661
1662         * Scripts/webkitpy/common/config/contributors.json:
1663
1664 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1665
1666         Remove my old email address from contributors.json and watchlist.
1667
1668         * Scripts/validate-committer-lists:
1669         (CommitterListFromGit): Change the mapping to the correct email.
1670         * Scripts/webkitpy/common/config/contributors.json:
1671         * Scripts/webkitpy/common/config/watchlist:
1672
1673 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1674
1675         Unreviewed, rolling out r210848.
1676
1677         This change introduced media-related LayoutTest failures and
1678         crashes on macOS.
1679
1680         Reverted changeset:
1681
1682         "[Modern Media Controls] Turn modern media controls on by
1683         default"
1684         https://bugs.webkit.org/show_bug.cgi?id=165668
1685         http://trac.webkit.org/changeset/210848
1686
1687 2017-01-18  Andreas Kling  <akling@apple.com>
1688
1689         Document::securityOrigin() should return a reference.
1690         <https://webkit.org/b/167124>
1691
1692         Reviewed by Sam Weinig.
1693
1694         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1695         (TestWebKitAPI::TEST_F):
1696
1697 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1698
1699         [Win] Clipboard tests are flaky.
1700         https://bugs.webkit.org/show_bug.cgi?id=167088
1701
1702         Reviewed by Brent Fulgham.
1703
1704         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1705         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1706
1707         * DumpRenderTree/win/DumpRenderTree.cpp:
1708         (main):
1709
1710 2017-01-18  Antoine Quint  <graouts@apple.com>
1711
1712         [Modern Media Controls] Turn modern media controls on by default
1713         https://bugs.webkit.org/show_bug.cgi?id=165668
1714
1715         Reviewed by Dean Jackson.
1716
1717         Enabled modern media controls by default in test runners. 
1718
1719         * DumpRenderTree/TestOptions.h:
1720         * WebKitTestRunner/TestOptions.h:
1721
1722 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1723
1724         Unreviewed, rolling out r210834
1725         https://bugs.webkit.org/show_bug.cgi?id=165668
1726
1727         It introduced dozens of test timeouts.
1728
1729         Reverted changeset:
1730         "[Modern Media Controls] Turn modern media controls on by default"
1731         https://bugs.webkit.org/show_bug.cgi?id=165668
1732         http://trac.webkit.org/changeset/210834
1733
1734 2017-01-17  Antoine Quint  <graouts@apple.com>
1735
1736         [Modern Media Controls] Turn modern media controls on by default
1737         https://bugs.webkit.org/show_bug.cgi?id=165668
1738
1739         Reviewed by Dean Jackson.
1740
1741         Enabled modern media controls by default in test runners. 
1742
1743         * DumpRenderTree/TestOptions.h:
1744         * WebKitTestRunner/TestOptions.h:
1745
1746 2017-01-17  Chris Dumez  <cdumez@apple.com>
1747
1748         Document title changed twice when setting document.title
1749         https://bugs.webkit.org/show_bug.cgi?id=167065
1750
1751         Reviewed by Darin Adler.
1752
1753         Add WebKit2GTK API test that was written by Michael Catanzaro.
1754
1755         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1756         (testWebViewTitleChange):
1757         (beforeAll):
1758
1759 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1760
1761         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1762         https://bugs.webkit.org/show_bug.cgi?id=116551
1763         <rdar://problem/13949830>
1764
1765         Reviewed by Alex Christensen.
1766
1767         * Scripts/webkitperl/FeatureList.pm:
1768         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1769         that is part of the existing WEB_TIMING feature.
1770
1771         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1772
1773 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1774
1775         'webkit-patch post' no longer works with moved/copied files
1776         https://bugs.webkit.org/show_bug.cgi?id=166914
1777         <rdar://problem/29979707>
1778
1779         Reviewed by Daniel Bates.
1780
1781         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1782         file outputs only the "Index:" line with an empty body.  This workaround
1783         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1784         public email list tracking this bug is below.
1785         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1786         
1787
1788         * Scripts/svn-create-patch:
1789         (generateDiff): Ignore an "Index:" line with an empty body.
1790
1791 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1792
1793         Remove the REQUEST_ANIMATION_FRAME flag
1794         https://bugs.webkit.org/show_bug.cgi?id=156980
1795         <rdar://problem/25906849>
1796
1797         Reviewed by Simon Fraser.
1798
1799         * Scripts/webkitperl/FeatureList.pm:
1800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1801
1802 2017-01-15  Sam Weinig  <sam@webkit.org>
1803
1804         Add the ability to use numbers in makeString()
1805         https://bugs.webkit.org/show_bug.cgi?id=167087
1806
1807         Reviewed by Darin Adler.
1808
1809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1810         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1811         Add tests for StringConcatenate, focusing on new numeric additions.
1812
1813 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1814
1815         Unreviewed, remove stale comment.
1816
1817         This test was fixed by r163173.
1818
1819         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1820
1821 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1822
1823         Annotate large string tests with largeHeap
1824         https://bugs.webkit.org/show_bug.cgi?id=167054
1825
1826         Reviewed by Filip Pizlo.
1827
1828         * Scripts/run-javascriptcore-tests:
1829         * Scripts/run-jsc-stress-tests:
1830
1831 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1832
1833         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1834         https://bugs.webkit.org/show_bug.cgi?id=167043
1835
1836         Reviewed by Darin Adler.
1837
1838         * Scripts/webkitperl/FeatureList.pm:
1839
1840 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1841
1842         Remove ENABLE(DETAILS_ELEMENT) guards
1843         https://bugs.webkit.org/show_bug.cgi?id=167042
1844
1845         Reviewed by Alex Christensen.
1846
1847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1848
1849 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1850
1851         26 MotionMark performance tests failing
1852         https://bugs.webkit.org/show_bug.cgi?id=166854
1853
1854         Reviewed by Ryosuke Niwa.
1855
1856         Unrelated change. This is the last place that we need to rename Animometer
1857         to MotionMark.
1858
1859         * Scripts/webkitpy/common/config/watchlist:
1860
1861 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1862
1863         run-jsc-benchmarks' echo should have -e option
1864         https://bugs.webkit.org/show_bug.cgi?id=167009
1865
1866         Reviewed by Sam Weinig.
1867
1868         echo requires `-e` option to use escape sequence.
1869         Without it, in some environment (in my Fedora 25), the escape sequence is not
1870         recognized and just dumped as `\c` etc.
1871
1872         * Scripts/run-jsc-benchmarks:
1873
1874 2017-01-12  Chris Dumez  <cdumez@apple.com>
1875
1876         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1877         https://bugs.webkit.org/show_bug.cgi?id=166995
1878
1879         Reviewed by Jer Noble.
1880
1881         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1882         as some people are having trouble building without it.
1883
1884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1885
1886 2017-01-12  Sam Weinig  <sam@webkit.org>
1887
1888         Add the ability to filter the set of bindings tests you want to run
1889         https://bugs.webkit.org/show_bug.cgi?id=166977
1890
1891         Reviewed by Tim Horton.
1892
1893         Allows doing things like:
1894             run-bindings-tests TestObj* TestCEReactions*
1895         
1896         to run only those tests that match the patterns.
1897
1898         * Scripts/run-bindings-tests:
1899         (main):
1900         Switch to using optparse and pass the remaining args as the filters.
1901
1902         * Scripts/webkitpy/bindings/main.py:
1903         (BindingsTests.__init__):
1904         Store the pattens.
1905
1906         (BindingsTests.test_matches_patterns):
1907         Add helper predicate to determine if a test should be run. When no
1908         patterns are present, all tests should run.
1909
1910         (BindingsTests.run_tests):
1911         Filter tests using the passed in patterns.
1912
1913 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1914
1915         Followup fix after r210503.
1916         https://bugs.webkit.org/show_bug.cgi?id=166887
1917
1918         Reviewed by Alex Christensen.
1919
1920         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1921         duplicated file handle on Windows. This patch fixes the remaining call sites.
1922
1923         * DumpRenderTree/PixelDumpSupport.cpp:
1924         * DumpRenderTree/TestRunner.cpp:
1925         (TestRunner::waitToDumpWatchdogTimerFired):
1926         * DumpRenderTree/TestRunner.h:
1927         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1928         * DumpRenderTree/win/DumpRenderTree.cpp:
1929         * DumpRenderTree/win/DumpRenderTreeWin.h:
1930         * DumpRenderTree/win/TestRunnerWin.cpp:
1931         (TestRunner::setSpellCheckerLoggingEnabled):
1932
1933 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1934
1935         Add committer status for Megan
1936         https://bugs.webkit.org/show_bug.cgi?id=166954
1937
1938         Reviewed by Tim Horton.
1939
1940         Add committer status for Megan Gardner
1941
1942         * Scripts/webkitpy/common/config/contributors.json:
1943
1944 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1945
1946         Unreviewed test fix after r210599.
1947
1948         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1949         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1950
1951 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1952
1953         Unreviewed build fix after r210599.
1954
1955         Add missing files.
1956
1957         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1958         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1959
1960 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1961
1962         File scheme should not allow access of a resource on a different volume.
1963         https://bugs.webkit.org/show_bug.cgi?id=158552
1964         <rdar://problem/15307582>
1965
1966         Reviewed by Alex Christensen.
1967
1968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1969         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1970         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1971
1972 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1973
1974         Unreviewed, rolling out r210571.
1975
1976         This change broke the 32-bit macOS build and caused LayoutTest
1977         failures.
1978
1979         Reverted changeset:
1980
1981         "File scheme should not allow access of a resource on a
1982         different volume."
1983         https://bugs.webkit.org/show_bug.cgi?id=158552
1984         http://trac.webkit.org/changeset/210571
1985
1986 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1987
1988         [GTK] install-dependencies script misses gdb
1989         https://bugs.webkit.org/show_bug.cgi?id=166917
1990
1991         Reviewed by Michael Catanzaro.
1992
1993         gdb is needed for generating the crash logs.
1994
1995         * gtk/install-dependencies:
1996
1997 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1998
1999         [GTK] No way for applications to set notification permissions without waiting for permission request
2000         https://bugs.webkit.org/show_bug.cgi?id=163366
2001
2002         Reviewed by Carlos Garcia Campos.
2003
2004         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2005         (testWebViewNotification):
2006         (setInitialNotificationPermissionsAllowedCallback):
2007         (setInitialNotificationPermissionsDisallowedCallback):
2008         (testWebViewNotificationInitialPermissionAllowed):
2009         (testWebViewNotificationInitialPermissionDisallowed):
2010         (beforeAll):
2011         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2012         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2013         (WebViewTest::WebViewTest):
2014         (WebViewTest::initializeWebView):
2015         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2016
2017 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2018
2019         MobileMiniBrowser tests don't work by default
2020         https://bugs.webkit.org/show_bug.cgi?id=166910
2021
2022         Reviewed by Alex Christensen.
2023
2024         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2025         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2026
2027 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2028
2029         File scheme should not allow access of a resource on a different volume.
2030         https://bugs.webkit.org/show_bug.cgi?id=158552
2031         <rdar://problem/15307582>
2032
2033         Reviewed by Alex Christensen.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2036         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2037         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2038
2039 2017-01-10  Mark Lam  <mark.lam@apple.com>
2040
2041         Reverting run-jsc-stress-tests' $buildType to use string values.
2042         https://bugs.webkit.org/show_bug.cgi?id=166912
2043
2044         Rubber stamped by Filip Pizlo.
2045
2046         This is so that we can test for it in the tests e.g.
2047         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2048
2049         * Scripts/run-jsc-stress-tests:
2050
2051 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2052
2053         Temporarily add back the file removed in r210463 to unbreak internal bots.
2054
2055         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2056
2057 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2058
2059         svn-apply failed to apply a patch (deleting file with svn property)
2060         https://bugs.webkit.org/show_bug.cgi?id=165953
2061
2062         Reviewed by Daniel Bates.
2063
2064         * Scripts/VCSUtils.pm:
2065         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2066         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2067
2068 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2069
2070         Update flakiness dashboard configuration.
2071         https://bugs.webkit.org/show_bug.cgi?id=166869
2072
2073         Reviewed by Alexey Proskuryakov.
2074
2075         * TestResultServer/static-dashboards/builders.jsonp:
2076         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2077
2078 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2079
2080         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2081         https://bugs.webkit.org/show_bug.cgi?id=165232
2082
2083         Unreviewed follow-up patch after r210539 and r210523.
2084
2085         Instead of using that environment variable, the argument
2086         --display-server=xorg should be passed now.
2087
2088         The GTK+ performance bot was the only bot using this, and is
2089         already passing --display-server=xorg after r210539.
2090
2091         * Scripts/webkitpy/port/gtk.py:
2092         (GtkPort._driver_class):
2093
2094 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2095
2096         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2097         https://bugs.webkit.org/show_bug.cgi?id=166872
2098
2099         Reviewed by Michael Catanzaro.
2100
2101         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2102         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2103         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2104         The step RunWebKitTests already has support for it.
2105
2106         * BuildSlaveSupport/build.webkit.org-config/config.json:
2107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2108         (RunGtkAPITests.start):
2109         (RunAndUploadPerfTests.start):
2110         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2111
2112 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2113
2114         Unreviewed, rolling out r210531.
2115
2116         This change broke the 32-bit macOS build and caused LayoutTest
2117         failures.
2118
2119         Reverted changeset:
2120
2121         "File scheme should not allow access of a resource on a
2122         different volume."
2123         https://bugs.webkit.org/show_bug.cgi?id=158552
2124         http://trac.webkit.org/changeset/210531
2125
2126 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2127
2128         File scheme should not allow access of a resource on a different volume.
2129         https://bugs.webkit.org/show_bug.cgi?id=158552
2130         <rdar://problem/15307582>
2131
2132         Reviewed by Alex Christensen.
2133
2134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2135         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2136         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2137
2138 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2139
2140         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2141         https://bugs.webkit.org/show_bug.cgi?id=165232
2142
2143         Reviewed by Michael Catanzaro.
2144
2145         Add a new WaylandDriver to run the tests in the user current wayland session.
2146
2147         Also merge all the configuration options for selecting the display server inside one
2148         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2149
2150         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2151
2152         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2153         (TestRunner._create_driver):
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2155         (parse_args):
2156         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2157         (PerfTestsRunner._parse_args):
2158         * Scripts/webkitpy/port/gtk.py:
2159         (GtkPort.__init__):
2160         (GtkPort._driver_class):
2161         (GtkPort._search_paths):
2162         * Scripts/webkitpy/port/waylanddriver.py: Added.
2163         (WaylandDriver):
2164         (WaylandDriver.check_driver):
2165         (WaylandDriver._setup_environ_for_test):
2166         (WaylandDriver._start):
2167
2168 2017-01-09  Andy Estes  <aestes@apple.com>
2169
2170         [QuickLook] Add a layout test for webkit.org/b/135651
2171         https://bugs.webkit.org/show_bug.cgi?id=166855
2172
2173         Reviewed by Andreas Kling.
2174
2175         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2176         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2177         errors with code WebKitErrorCannotShowURL.
2178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2179         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2180         not specific to WebKit2 error codes.
2181
2182 2017-01-09  Antoine Quint  <graouts@apple.com>
2183
2184         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2185         https://bugs.webkit.org/show_bug.cgi?id=166837
2186
2187         Reviewed by Alex Christensen.
2188
2189         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2190         the provided value when trying to determine the path to the test file. Failing
2191         that, we use the computed URL or the raw path provided to cover all cases.
2192         
2193         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2194         by applying this patch and seeing the number test failures dramatically reduced
2195         with WK1 due to the option to turn modern media controls off for older media controls
2196         tests.
2197
2198         * DumpRenderTree/DumpRenderTree.h:
2199         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2200         (parseInputLine):
2201         * DumpRenderTree/TestOptions.h:
2202         * DumpRenderTree/TestOptions.mm:
2203         (TestOptions::TestOptions):
2204         * DumpRenderTree/mac/DumpRenderTree.mm:
2205         (runTest):
2206
2207 2017-01-09  Milan Crha  <mcrha@redhat.com>
2208
2209         prepare-ChangeLog: Correct help string for --style option
2210         https://bugs.webkit.org/show_bug.cgi?id=166725
2211
2212         Reviewed by Alexey Proskuryakov.
2213
2214         * Scripts/prepare-ChangeLog:
2215         (main):
2216
2217 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2218
2219         https://bugs.webkit.org/show_bug.cgi?id=166839
2220         Add php7 support for macOS.
2221         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2222
2223         Reviewed by Alexey Proskuryakov.
2224
2225         * Scripts/webkitpy/port/base.py:
2226         (Port._is_darwin_php_version_7):
2227         (Port._debian_php_version):
2228         (Port):
2229         (Port._darwin_php_version):
2230         (Port._apache_config_file_name_for_platform):
2231
2232 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2233
2234         [GTK] Should support key and code properties on keyboard events
2235         https://bugs.webkit.org/show_bug.cgi?id=166759
2236
2237         Reviewed by Carlos Garcia Campos.
2238
2239         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2240         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2241         on tests.
2242
2243 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2244
2245         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2246         https://bugs.webkit.org/show_bug.cgi?id=166760
2247
2248         Reviewed by Darin Adler.
2249
2250         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2251         We can work around that by duplicating and redirecting stdout.
2252
2253         * DumpRenderTree/PixelDumpSupport.cpp:
2254         (dumpWebViewAsPixelsAndCompareWithExpected):
2255         (printPNG):
2256         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2257         (logEventProc):
2258         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2259         (DRTDesktopNotificationPresenter::showDesktopNotification):
2260         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2261         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2262         * DumpRenderTree/win/DumpRenderTree.cpp:
2263         (dumpFrameScrollPosition):
2264         (dumpHistoryItem):
2265         (dumpBackForwardList):
2266         (dump):
2267         (runTest):
2268         (main):
2269         * DumpRenderTree/win/DumpRenderTreeWin.h:
2270         * DumpRenderTree/win/EditingDelegate.cpp:
2271         (EditingDelegate::shouldBeginEditingInDOMRange):
2272         (EditingDelegate::shouldEndEditingInDOMRange):
2273         (EditingDelegate::shouldInsertNode):
2274         (EditingDelegate::shouldInsertText):
2275         (EditingDelegate::shouldDeleteDOMRange):
2276         (EditingDelegate::shouldChangeSelectedDOMRange):
2277         (EditingDelegate::shouldApplyStyle):
2278         (EditingDelegate::shouldChangeTypingStyle):
2279         (EditingDelegate::doPlatformCommand):
2280         (EditingDelegate::webViewDidBeginEditing):
2281         (EditingDelegate::webViewDidChange):
2282         (EditingDelegate::webViewDidEndEditing):
2283         (EditingDelegate::webViewDidChangeTypingStyle):
2284         (EditingDelegate::webViewDidChangeSelection):
2285         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2286         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2287         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2288         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2289         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2290         (FrameLoadDelegate::didCommitLoadForFrame):
2291         (FrameLoadDelegate::didReceiveTitle):
2292         (FrameLoadDelegate::didFinishLoadForFrame):
2293         (FrameLoadDelegate::didFailLoadWithError):
2294         (FrameLoadDelegate::willPerformClientRedirectToURL):
2295         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2296         (FrameLoadDelegate::windowScriptObjectAvailable):
2297         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2298         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2299         (FrameLoadDelegate::didDisplayInsecureContent):
2300         (FrameLoadDelegate::didRunInsecureContent):
2301         (FrameLoadDelegate::webViewProgressFinishedNotification):
2302         * DumpRenderTree/win/HistoryDelegate.cpp:
2303         (HistoryDelegate::didNavigateWithNavigationData):
2304         (HistoryDelegate::didPerformClientRedirectFromURL):
2305         (HistoryDelegate::didPerformServerRedirectFromURL):
2306         (HistoryDelegate::updateHistoryTitle):
2307         (HistoryDelegate::populateVisitedLinksForWebView):
2308         * DumpRenderTree/win/PolicyDelegate.cpp:
2309         (PolicyDelegate::decidePolicyForNavigationAction):
2310         (PolicyDelegate::unableToImplementPolicyWithError):
2311         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2312         (ResourceLoadDelegate::willSendRequest):
2313         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2314         (ResourceLoadDelegate::didReceiveResponse):
2315         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2316         (ResourceLoadDelegate::didFailLoadingWithError):
2317         * DumpRenderTree/win/TestRunnerWin.cpp:
2318         (TestRunner::addDisallowedURL):
2319         (TestRunner::originsWithApplicationCache):
2320         (TestRunner::setStorageDatabaseIdleInterval):
2321         (TestRunner::closeIdleLocalStorageDatabases):
2322         (TestRunner::copyDecodedHostName):
2323         (TestRunner::copyEncodedHostName):
2324         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2325         (TestRunner::isGeolocationProviderActive):
2326         (TestRunner::pathToLocalResource):
2327         (TestRunner::setMockDeviceOrientation):
2328         (TestRunner::setMockGeolocationPosition):
2329         (TestRunner::setMockGeolocationPositionUnavailableError):
2330         (TestRunner::setSpatialNavigationEnabled):
2331         (TestRunner::setAutomaticLinkDetectionEnabled):
2332         (TestRunner::isCommandEnabled):
2333         (TestRunner::authenticateSession):
2334         (TestRunner::addChromeInputField):
2335         (TestRunner::removeChromeInputField):
2336         (TestRunner::focusWebView):
2337         (TestRunner::grantWebNotificationPermission):
2338         (TestRunner::denyWebNotificationPermission):
2339         (TestRunner::removeAllWebNotificationPermissions):
2340         (TestRunner::simulateWebNotificationClick):
2341         (TestRunner::imageCountInGeneralPasteboard):
2342         * DumpRenderTree/win/UIDelegate.cpp:
2343         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2344         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2345         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2346         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2347         (UIDelegate::webViewAddMessageToConsole):
2348         (UIDelegate::exceededDatabaseQuota):
2349         (UIDelegate::setStatusText):
2350         (UIDelegate::didPressMissingPluginButton):
2351
2352 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2353
2354         Add a setting to create editable MiniBrowser windows by default
2355         https://bugs.webkit.org/show_bug.cgi?id=166806
2356
2357         Reviewed by Beth Dakin.
2358
2359         * MiniBrowser/mac/AppDelegate.m:
2360         (-[BrowserAppDelegate createBrowserWindowController:]):
2361         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2362         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2363         * MiniBrowser/mac/SettingsController.h:
2364         * MiniBrowser/mac/SettingsController.m:
2365         (-[SettingsController _populateMenu]):
2366         (-[SettingsController validateMenuItem:]):
2367         (-[SettingsController toggleCreateEditorByDefault:]):
2368         (-[SettingsController createEditorByDefault]):
2369         Add a setting and update the key equivalents accordingly.
2370         Also make sure to make the right kind of window on launch.
2371
2372 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2373
2374         Fix the 32-bit build.
2375
2376         * MiniBrowser/mac/BrowserWindowController.h:
2377         * MiniBrowser/mac/BrowserWindowController.m:
2378
2379 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2380
2381         Fix the 32-bit build.
2382
2383         * MiniBrowser/mac/BrowserWindowController.m:
2384
2385 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2386
2387         Make it possible to drop HTML files on the MiniBrowser icon
2388         https://bugs.webkit.org/show_bug.cgi?id=166802
2389
2390         Reviewed by Simon Fraser.
2391
2392         * MiniBrowser/mac/AppDelegate.m:
2393         (-[BrowserAppDelegate application:openFile:]):
2394         * MiniBrowser/mac/Info.plist:
2395         If you're using an editable window, the usual trick of dropping on the
2396         window doesn't work anymore (it makes an <attachment> instead).
2397
2398 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2399
2400         MiniBrowser window gets smaller each time it is instantiated
2401         https://bugs.webkit.org/show_bug.cgi?id=166807
2402
2403         Reviewed by Andy Estes.
2404
2405         * MiniBrowser/mac/BrowserWindowController.m:
2406         (-[BrowserWindowController windowDidLoad]):
2407         * MiniBrowser/mac/BrowserWindow.xib:
2408         Turn on full-window content view support with IB, instead of waiting
2409         until after the views have been loaded. This seems to resolve the
2410         longstanding ever-shrinking-window problem.
2411
2412 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2413
2414         Add indent/outdent items to MiniBrowser's new format menu
2415         https://bugs.webkit.org/show_bug.cgi?id=166805
2416
2417         Reviewed by Dan Bernstein.
2418
2419         * MiniBrowser/mac/MainMenu.xib:
2420
2421 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2422
2423         Add a stock Format menu to MiniBrowser
2424         https://bugs.webkit.org/show_bug.cgi?id=166804
2425
2426         Reviewed by Andy Estes.
2427
2428         * MiniBrowser/mac/MainMenu.xib:
2429         Many of the features automatically work with editable web views.
2430         However, this seems to expose a bug where none of the font-related features
2431         (Cmd-B, for example) work until the first time the font panel is shown,
2432         per process, which will need to be investigated separately.
2433
2434 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2435
2436         Remove unused applicationWillTerminate methods from MiniBrowser
2437         https://bugs.webkit.org/show_bug.cgi?id=166803
2438
2439         Reviewed by Andy Estes.
2440
2441         * MiniBrowser/mac/AppDelegate.m:
2442         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2443         * MiniBrowser/mac/BrowserWindowController.h:
2444         * MiniBrowser/mac/BrowserWindowController.m:
2445         (-[BrowserWindowController applicationTerminating]): Deleted.
2446         * MiniBrowser/mac/WK1BrowserWindowController.m:
2447         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2448         * MiniBrowser/mac/WK2BrowserWindowController.m:
2449         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2450
2451 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2452
2453         Add the ability to create empty contentEditable windows in MiniBrowser
2454         https://bugs.webkit.org/show_bug.cgi?id=166801
2455
2456         Reviewed by Wenson Hsieh.
2457
2458         * MiniBrowser/mac/AppDelegate.h:
2459         * MiniBrowser/mac/AppDelegate.m:
2460         (-[BrowserAppDelegate createBrowserWindowController:]):
2461         (-[BrowserAppDelegate newWindow:]):
2462         (-[BrowserAppDelegate newEditorWindow:]):
2463         (-[BrowserAppDelegate openDocument:]):
2464         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2465         * MiniBrowser/mac/BrowserWindowController.h:
2466         * MiniBrowser/mac/BrowserWindowController.m:
2467         (-[BrowserWindowController loadHTMLString:]):
2468         (-[BrowserWindowController toggleEditable:]):
2469         * MiniBrowser/mac/MainMenu.xib:
2470         * MiniBrowser/mac/WK1BrowserWindowController.m:
2471         (-[WK1BrowserWindowController awakeFromNib]):
2472         (-[WK1BrowserWindowController loadHTMLString:]):
2473         (-[WK1BrowserWindowController validateMenuItem:]):
2474         (-[WK1BrowserWindowController setEditable:]):
2475         (-[WK1BrowserWindowController updateTitle:]):
2476         * MiniBrowser/mac/WK2BrowserWindowController.m:
2477         (-[WK2BrowserWindowController awakeFromNib]):
2478         (-[WK2BrowserWindowController validateMenuItem:]):
2479         (-[WK2BrowserWindowController setEditable:]):
2480         (-[WK2BrowserWindowController updateTitle:]):
2481         (-[WK2BrowserWindowController loadHTMLString:]):
2482         Merge more functionality from WebEditingTester.
2483         Add two menu items for creating empty editable WebKit1/2 windows.
2484         Add a menu item to the Edit menu to toggle editability on any window.
2485
2486 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2487
2488         Implement find-in-page in MiniBrowser
2489         https://bugs.webkit.org/show_bug.cgi?id=166799
2490
2491         Reviewed by Andy Estes.
2492
2493         * MiniBrowser/mac/BrowserWindow.xib:
2494         * MiniBrowser/mac/BrowserWindowController.h:
2495         * MiniBrowser/mac/BrowserWindowController.m:
2496         (-[BrowserWindowController find:]): Deleted.
2497         * MiniBrowser/mac/MainMenu.xib:
2498         * MiniBrowser/mac/WK1BrowserWindowController.m:
2499         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2500         (-[WK1BrowserWindowController find:]): Deleted.
2501         * MiniBrowser/mac/WK2BrowserWindowController.m:
2502         (-[WK2BrowserWindowController awakeFromNib]):
2503         (-[WK2BrowserWindowController dealloc]):
2504         (-[WK2BrowserWindowController validateMenuItem:]):
2505         (-[WK2BrowserWindowController performTextFinderAction:]):
2506         (-[WK2BrowserWindowController findBarView]):
2507         (-[WK2BrowserWindowController setFindBarView:]):
2508         (-[WK2BrowserWindowController isFindBarVisible]):
2509         (-[WK2BrowserWindowController setFindBarVisible:]):
2510         (-[WK2BrowserWindowController contentView]):
2511         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2512         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2513         (-[WK2BrowserWindowController find:]): Deleted.
2514         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2515         protocol. At first glance, it's pretty broken, but vaguely works.
2516
2517 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2518
2519         Share the implementation of MiniBrowser view hiding functionality
2520         https://bugs.webkit.org/show_bug.cgi?id=166800
2521
2522         Reviewed by Andy Estes.
2523
2524         * MiniBrowser/mac/BrowserWindowController.m:
2525         (-[BrowserWindowController showHideWebView:]):
2526         (-[BrowserWindowController removeReinsertWebView:]):
2527         * MiniBrowser/mac/WK1BrowserWindowController.m:
2528         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2529         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2530         * MiniBrowser/mac/WK2BrowserWindowController.m:
2531         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2532         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2533         Move the implementation of these two things to the shared superclass,
2534         since they don't depend on WebKit-specific things.
2535         Also, there was no reason to retain the (WK)WebView while it was unparented,
2536         as the BrowserWindowController maintains a reference the entire time.
2537
2538 2017-01-06  Andy Estes  <aestes@apple.com>
2539
2540         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2541         https://bugs.webkit.org/show_bug.cgi?id=166789
2542
2543         Reviewed by Alex Christensen.
2544
2545         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2546         * DumpRenderTree/PlatformMac.cmake:
2547         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2548         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2549         * DumpRenderTree/mac/DumpRenderTree.mm:
2550         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2551         createXMLStringFromWebArchiveData().
2552         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2553         * WebKitTestRunner/Configurations/Base.xcconfig:
2554         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2555         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2556         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2557         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2558         createXMLStringFromWebArchiveData().
2559         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2560         * WebKitTestRunner/PlatformMac.cmake:
2561         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2562         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2563
2564 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2565
2566         Minor cleanups to IndentOutdentCommand and related code
2567         https://bugs.webkit.org/show_bug.cgi?id=166791
2568
2569         Reviewed by Simon Fraser.
2570
2571         * WebEditingTester/EditingOperations.m:
2572         (editingOperations):
2573         Add the outdent operation to WebEditingTester.
2574
2575 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2576
2577         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2578         https://bugs.webkit.org/show_bug.cgi?id=166785
2579
2580         Reviewed by Ryosuke Niwa.
2581
2582         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2583         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2584
2585 2017-01-06  Antoine Quint  <graouts@apple.com>
2586
2587         Support webkit-test-runner key-value pairs in http tests
2588         https://bugs.webkit.org/show_bug.cgi?id=149812
2589
2590         Reviewed by Alex Christensen.
2591
2592         We pass the absolute path for a test through to WKTR so that we can parse
2593         tests that are running as URLs for webkit-test-runner options.
2594
2595         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2596         (parseInputLine):
2597
2598         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2599
2600         * Scripts/webkitpy/port/driver.py:
2601         (Driver._command_from_driver_input):
2602
2603         Pass the absolute path to the file through the CLI.
2604
2605         * WebKitTestRunner/TestController.cpp:
2606         (WTR::updateTestOptionsFromTestHeader):
2607         (WTR::TestController::testOptionsForTest):
2608         (WTR::parseInputLine):
2609         (WTR::TestController::runTest):
2610         * WebKitTestRunner/TestController.h:
2611
2612 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2613
2614         Warning about unconnectable outlets when opening a MiniBrowser window
2615         https://bugs.webkit.org/show_bug.cgi?id=166756
2616
2617         Reviewed by Dan Bernstein.
2618
2619         * MiniBrowser/mac/BrowserWindow.xib:
2620         When launching MiniBrowser, it says:
2621         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2622             (MBToolbarItem): missing setter or instance variable
2623         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2624             (NSButtonCell): missing setter or instance variable.
2625
2626         It looks like someone added the connection from the share button
2627         to the BrowserWindowController three times; only one of the connections
2628         is valid. Remove the other two.
2629
2630 2017-01-05  Keith Rollin  <krollin@apple.com>
2631
2632         Add WebCore::URL::protocolHostAndPort
2633         https://bugs.webkit.org/show_bug.cgi?id=166426
2634
2635         Reviewed by Alex Christensen.
2636
2637         Add test for protocolHostAndPort.
2638
2639         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2640         (TestWebKitAPI::TEST_F):
2641
2642 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2643
2644         [Win] Archive test result is failing.
2645         https://bugs.webkit.org/show_bug.cgi?id=166720
2646
2647         Reviewed by Alex Christensen.
2648
2649         Deleting the layout test result folder is sometimes failing
2650         on Windows. This is not a critical error.
2651
2652         * BuildSlaveSupport/test-result-archive:
2653         (archiveTestResults):
2654
2655 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2656
2657         [GTK] Minibrowser: Add printing support
2658         https://bugs.webkit.org/show_bug.cgi?id=165298
2659
2660         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2661         an error during the print, it's printed on the console.
2662
2663         Reviewed by Michael Catanzaro.
2664
2665         * MiniBrowser/gtk/BrowserWindow.c:
2666         (webKitPrintOperationFailedCallback):
2667         (printPage):
2668         (browser_window_init):
2669
2670 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2671
2672         [css-grid] Fix crash clamping grid lines
2673         https://bugs.webkit.org/show_bug.cgi?id=166637
2674
2675         Reviewed by Darin Adler.
2676
2677         Creates new unit test to verify that the maximum tracks limit
2678         is used in GridPosition too.
2679
2680         * TestWebKitAPI/PlatformEfl.cmake:
2681         * TestWebKitAPI/PlatformGTK.cmake:
2682         * TestWebKitAPI/PlatformWin.cmake:
2683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2685         (TestWebKitAPI::TEST):
2686
2687 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2688
2689         Move editing history scripts to WebCore PrivateHeaders
2690         https://bugs.webkit.org/show_bug.cgi?id=166709
2691         <rdar://problem/29876612>
2692
2693         Reviewed by Dan Bernstein.
2694
2695         Update references to editing script files in WebCore that were moved.
2696
2697         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2698
2699 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2700
2701         Unreviewed, build fix after r210313 part 2
2702         https://bugs.webkit.org/show_bug.cgi?id=166676
2703
2704         Add 'U' suffix.
2705
2706         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2709         (TestWebKitAPI::TEST):
2710
2711 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2712
2713         Limit thread name appropriately
2714         https://bugs.webkit.org/show_bug.cgi?id=166676
2715
2716         Reviewed by Sam Weinig.
2717
2718         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2719         (TestWebKitAPI::TEST):
2720         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2721         (TestWebKitAPI::TEST):
2722
2723 2017-01-04  Andy Estes  <aestes@apple.com>
2724
2725         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2726         https://bugs.webkit.org/show_bug.cgi?id=166696
2727
2728         Reviewed by Tim Horton.
2729
2730         * TestWebKitAPI/PlatformGTK.cmake:
2731         * TestWebKitAPI/PlatformWin.cmake:
2732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2733         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2734         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2735         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2736         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2737         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2738         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2739
2740 2017-01-03  Brian Burg  <bburg@apple.com>
2741
2742         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2743         https://bugs.webkit.org/show_bug.cgi?id=166003
2744         <rdar://problem/28718990>
2745
2746         Reviewed by Joseph Pecoraro.
2747
2748         Teach run-inspector-generator-tests to generate test output using the platform name
2749         derived from the directory that the test is in. For example, tests in the /generic/
2750         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2751
2752         * Scripts/webkitpy/inspector/main.py:
2753         (InspectorGeneratorTests.generate_from_json):
2754         (InspectorGeneratorTests.run_tests):
2755         (InspectorGeneratorTests.main):
2756
2757 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2758
2759         Unreviewed cmake buildfix after r210266.
2760
2761         * DumpRenderTree/PlatformMac.cmake:
2762
2763 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2764
2765         Provide a setting for clients to always prefer low-power WebGL
2766         https://bugs.webkit.org/show_bug.cgi?id=166675
2767         <rdar://problem/29834093>
2768
2769         Reviewed by Dan Bernstein.
2770
2771         * MiniBrowser/mac/Info.plist:
2772         Have MiniBrowser claim to be a modern app that supports
2773         automatic graphics switching. WebKit needs to support automatic
2774         graphics switching, so our test app might as well. Without this
2775         Info.plist parameter, this change has no effect, and bringing up
2776         a WebGL context still brings up the discrete GPU (also true of the
2777         existing web-exposed preferLowPowerToHighPerformance API).
2778
2779 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2780
2781         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2782         https://bugs.webkit.org/show_bug.cgi?id=166645
2783
2784         Reviewed by Carlos Garcia Campos.
2785
2786         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2787         (TestWebKitAPI::TEST):
2788
2789 2017-01-03  Andy Estes  <aestes@apple.com>
2790
2791         Place all the Cocoa WebCore API tests in the same directory
2792         https://bugs.webkit.org/show_bug.cgi?id=166673
2793
2794         Reviewed by Michael Catanzaro.
2795
2796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2797         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2798         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2799         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2800
2801 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2802
2803         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2804         https://bugs.webkit.org/show_bug.cgi?id=166450
2805         <rdar://problem/29447824>
2806
2807         Reviewed by Darin Adler.
2808
2809         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2810         * DumpRenderTree/TestRunner.cpp:
2811         (TestRunner::staticFunctions):
2812         * DumpRenderTree/mac/TestRunnerMac.mm:
2813         (setSpellCheckerLoggingEnabledCallback):
2814         * DumpRenderTree/win/TestRunnerWin.cpp:
2815         (setSpellCheckerLoggingEnabledCallback):
2816         * DumpRenderTree/mac/DumpRenderTree.mm:
2817         (resetWebViewToConsistentStateBeforeTesting):
2818         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2819         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2820         (stringForCorrectionResponse):
2821         (drt_NSSpellChecker_recordResponseToCorrection):
2822         (swizzleNSSpellCheckerMethodsIfNeeded):
2823         (setSpellCheckerLoggingEnabled):
2824         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2825         set to true, logs to stdout (which ends up in the test result) whenever
2826         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2827         is called, and then calls the original method. It is reset to false between tests.
2828
2829 2017-01-03  Sam Weinig  <sam@webkit.org>
2830
2831         Make WTF::Expected support Ref template parameters
2832         https://bugs.webkit.org/show_bug.cgi?id=166662
2833
2834         Reviewed by Alex Christensen.
2835
2836         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2837         (TestWebKitAPI::TEST):
2838         Add tests for using Ref with Expected.
2839
2840 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2841
2842         [GTK] Expose WebKitSecurityOrigin API
2843         https://bugs.webkit.org/show_bug.cgi?id=166632
2844
2845         Reviewed by Carlos Garcia Campos.
2846
2847         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2848         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2849         (testSecurityOriginBasicConstructor):
2850         (testSecurityOriginURIConstructor):
2851         (testSecurityOriginDefaultPort):
2852         (testSecurityOriginFileURI):
2853         (testSecurityOriginDataURI):
2854         (beforeAll):
2855         (afterAll):
2856
2857 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2858
2859         [GTK] HTTP auth layout tests are flaky
2860         https://bugs.webkit.org/show_bug.cgi?id=158919
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2865         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2866         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2867         missing valac in the bots.
2868
2869 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2872         https://bugs.webkit.org/show_bug.cgi?id=165797
2873
2874         Reviewed by Michael Catanzaro.
2875
2876         Move directory ruleset after all exclude rules of Source rulset.
2877
2878         * gtk/manifest.txt.in:
2879
2880 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2881
2882         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2883         https://bugs.webkit.org/show_bug.cgi?id=166636
2884
2885         Reviewed by Darin Adler.
2886
2887         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2888         (TestWebKitAPI::TEST):
2889
2890 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2891
2892         [GTK] WebCore/CSSParser unit test is not being built
2893         https://bugs.webkit.org/show_bug.cgi?id=166492
2894
2895         Reviewed by Michael Catanzaro.
2896
2897         This test was introduced in r175930, but we were not building
2898         it on GTK+ port since r176015.
2899         This patch marks the test to be built again on GTK+.
2900         JFTR, the test is passing right now.
2901
2902         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2903         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2904
2905 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2906
2907         AX: Expose block quote level to iOS API
2908         https://bugs.webkit.org/show_bug.cgi?id=166629
2909         <rdar://problem/29834793>
2910
2911         Reviewed by Darin Adler.
2912
2913         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2914         (AccessibilityUIElement::numberAttributeValue):
2915         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2916         (WTR::AccessibilityUIElement::numberAttributeValue):
2917
2918 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2919
2920         SecurityOrigin::create triplet constructor does not canonicalize port
2921         https://bugs.webkit.org/show_bug.cgi?id=166624
2922
2923         Reviewed by Daniel Bates.
2924
2925         * TestWebKitAPI/PlatformGTK.cmake:
2926         * TestWebKitAPI/PlatformWin.cmake:
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2929         (TestWebKitAPI::SecurityOriginTest::SetUp):
2930         (TestWebKitAPI::TEST_F):
2931
2932 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2933
2934         [GTK] Improve user agent construction
2935         https://bugs.webkit.org/show_bug.cgi?id=142074
2936
2937         Reviewed by Carlos Garcia Campos.
2938
2939         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2940         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2941         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2942         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2943         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2944         (TestWebKitAPI::TEST):
2945
2946 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2947
2948         [GTK] Improve user agent construction
2949         https://bugs.webkit.org/show_bug.cgi?id=142074
2950
2951         Reviewed by Carlos Garcia Campos.
2952
2953         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2954         (TestWebKitAPI::TEST):
2955
2956 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2957
2958         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2959         https://bugs.webkit.org/show_bug.cgi?id=166472
2960         rdar://problem/29675551
2961
2962         Reviewed by Tim Horton.
2963
2964         These changes are necessary to allow the mouse to leave the WTR window while
2965         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2966         (which DRT does); we'd always go through mouseMoved, which hits an early return
2967         in WebViewImpl::mouseMoved() when the point is outside the view.
2968
2969         * WebKitTestRunner/mac/EventSenderProxy.mm:
2970         (WTR::EventSenderProxy::mouseMoveTo):
2971
2972 2016-12-23  Andy Estes  <aestes@apple.com>
2973
2974         [iOS] Fix some crashing webarchive tests
2975         https://bugs.webkit.org/show_bug.cgi?id=166470
2976
2977         Reviewed by Andreas Kling.
2978
2979         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2980         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2981         so this change uses that on both platforms.
2982
2983         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2984         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2985         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2986         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2987         * WebKitTestRunner/PlatformMac.cmake:
2988         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2989         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2990
2991 2016-12-22  Saam Barati  <sbarati@apple.com>
2992
2993         WebAssembly: Silence the output of the spec-tests
2994         https://bugs.webkit.org/show_bug.cgi?id=166417
2995
2996         Reviewed by Mark Lam.
2997
2998         * Scripts/run-jsc-stress-tests:
2999
3000 2016-12-22  Zhuo Li  <zachli@apple.com>
3001
3002         [Cocoa] SPI for setloadsImagesAutomatically.
3003         https://bugs.webkit.org/show_bug.cgi?id=166401.
3004
3005         Reviewed by Darin Adler.
3006
3007         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3008         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3009         _loadsImagesAutomatically returns YES.
3010
3011 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3012
3013         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3014         https://bugs.webkit.org/show_bug.cgi?id=161328
3015         <rdar://problem/28475977>
3016
3017         Reviewed by Darin Adler.
3018
3019         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3020         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3021         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3022         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3023         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3024         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3025         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3026         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3027         we finish running a test and before we load the next test.
3028
3029         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3030         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3031         previous test started zooming and then finished before zooming completed. Since this happens before the next
3032         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3033
3034         * WebKitTestRunner/ios/TestControllerIOS.mm:
3035         (WTR::TestController::platformResetStateToConsistentValues):
3036
3037 2016-12-22  Jer Noble  <jer.noble@apple.com>
3038
3039         Muted media element playback should not interrupt other audio playback
3040         https://bugs.webkit.org/show_bug.cgi?id=166347
3041
3042         Reviewed by Eric Carlson.
3043
3044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3045         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3046         (TestWebKitAPI::TEST):
3047         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3048
3049 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3050
3051         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3052         https://bugs.webkit.org/show_bug.cgi?id=166346
3053
3054         Reviewed by Carlos Garcia Campos.
3055
3056         Enable WebRTC by default to simplify testing.
3057
3058         * MiniBrowser/gtk/main.c:
3059         (main):
3060
3061 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3062
3063         REGRESSION: API test failure: WKWebView.LocalStorageClear
3064         https://bugs.webkit.org/show_bug.cgi?id=166032
3065         <rdar://problem/29758423>
3066
3067         Reviewed by Simon Fraser.
3068
3069         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3070         to ensure that the view is destroyed before the callback fires.
3071
3072         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3073         (TEST):
3074
3075 2016-12-21  Saam Barati  <sbarati@apple.com>
3076
3077         WebAssembly: Import spec tests
3078         https://bugs.webkit.org/show_bug.cgi?id=166395
3079
3080         Rubber stamped by Keith Miller.
3081
3082         * Scripts/run-jsc-stress-tests:
3083
3084 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3085
3086         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3087         https://bugs.webkit.org/show_bug.cgi?id=166033
3088         <rdar://problem/29758428>
3089
3090         Reviewed by Simon Fraser.
3091
3092         Add an @autoreleasepool around the code that allocates the WKWebView, 
3093         so that it can be destroyed by removing the last reference in _downloadDidStart.
3094
3095         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3096         (TEST):
3097
3098 2016-12-21  Daniel Bates  <dabates@apple.com>
3099
3100         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3101         https://bugs.webkit.org/show_bug.cgi?id=166356
3102
3103         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3104         as a means to allow a test to explicit allow an embedding client to open a new windows
3105         such that the default behavior is for the embedding client to forbid such an action.
3106         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3107         it is currently skipped on WebKit2 because questions were raised in the patch for
3108         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3109         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3110         this test.
3111
3112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3113         (WTR::TestRunner::setCanOpenWindows):
3114
3115 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3116
3117         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3118         https://bugs.webkit.org/show_bug.cgi?id=166031
3119
3120         Reviewed by Tim Horton.
3121         
3122         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3123         to ensure that the view is destroyed before the callback fires.
3124
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3126
3127 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3128
3129         Throw Exception when test doesn't clean up HID Events properly
3130         https://bugs.webkit.org/show_bug.cgi?id=166271
3131
3132         Reviewed by Simon Fraser.
3133
3134         Add in a check when UIScriptController is deleted to make sure that the HID event
3135         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3136         the program to crash without any good information. Crashes are race-y, and will still
3137         happen with malformed test, but the information will be much more helpful. 
3138
3139         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3140         (WTR::UIScriptController::checkForClean):
3141         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3142         (UIScriptContext::~UIScriptContext):
3143         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3144         (WTR::UIScriptController::checkForClean):
3145         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3146         * WebKitTestRunner/ios/HIDEventGenerator.h:
3147         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3148         (-[HIDEventGenerator checkHIDCallbacksClear]):
3149         * WebKitTestRunner/ios/TestControllerIOS.mm:
3150         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3151         (WTR::UIScriptController::checkForClean):
3152
3153 2016-12-20  Andy Estes  <aestes@apple.com>
3154
3155         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3156         https://bugs.webkit.org/show_bug.cgi?id=165992
3157
3158         Reviewed by Brady Eidson.
3159
3160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3161         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3162         (expectException):
3163         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3164         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3165         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3166         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3167         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3168         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3169         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3170         (TEST):
3171         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3172
3173 2016-12-20  Dean Jackson  <dino@apple.com>
3174
3175         Remove INDIE_UI
3176         https://bugs.webkit.org/show_bug.cgi?id=165881
3177         <rdar://problem/29672532>
3178
3179         Reviewed by Simon Fraser.
3180
3181         The Indie UI work has been discontinued.
3182
3183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3184
3185 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3186
3187         [ES6] Enable ES6 Modules
3188         https://bugs.webkit.org/show_bug.cgi?id=165849
3189
3190         Reviewed by Geoffrey Garen.
3191
3192         * DumpRenderTree/mac/DumpRenderTree.mm:
3193         (resetWebPreferencesToConsistentValues):
3194         * DumpRenderTree/win/DumpRenderTree.cpp:
3195         (resetWebPreferencesToConsistentValues):
3196         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3197         (WTR::InjectedBundle::beginTesting):
3198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3199         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3201
3202 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3203
3204         Repurpose bots and clean up dashboard.
3205         https://bugs.webkit.org/show_bug.cgi?id=166045
3206
3207         Reviewed by Lucas Forschler.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/config.json:
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3211         (BubbleQueueServer):
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3214         (WebKitBuildbot):
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3216         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3217
3218 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3219
3220         [CMake] TestWebKitAPIBase links to itself
3221         https://bugs.webkit.org/show_bug.cgi?id=165985
3222
3223         Reviewed by Alex Christensen.
3224
3225         Fix CMake warning about a target linking to itself, which makes no sense.
3226
3227         * TestWebKitAPI/CMakeLists.txt:
3228
3229 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3230
3231         [GTK] GtkDoc build should be quieter
3232         https://bugs.webkit.org/show_bug.cgi?id=165994
3233
3234         Reviewed by Carlos Garcia Campos.
3235
3236         Make it not print by default.
3237
3238         * gtk/generate-gtkdoc:
3239         (get_generator_for_config):
3240         (generate_doc):
3241         * gtk/gtkdoc.py:
3242         (GTKDoc._run_command):
3243         (GTKDoc._copy_doc_files_to_output_dir):
3244
3245 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3246
3247         Expose a way for MiniBrowser to simulate header and footer banners
3248         https://bugs.webkit.org/show_bug.cgi?id=166005
3249
3250         Reviewed by Wenson Hsieh.
3251         
3252         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3253         banners. This only works in WebKit2.
3254         
3255         We need to reset these on each navigation, since newly created FrameViews
3256         don't re-fetch the header and footer height stored on Page.
3257         
3258         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3259         as well as fixing webViewWebContentProcessDidTerminate:
3260
3261         * MiniBrowser/mac/SettingsController.h:
3262         * MiniBrowser/mac/SettingsController.m:
3263         (-[SettingsController _populateMenu]):
3264         (-[SettingsController validateMenuItem:]):
3265         (-[SettingsController toggleReserveSpaceForBanners:]):
3266         (-[SettingsController isSpaceReservedForBanners]):
3267         * MiniBrowser/mac/WK2BrowserWindowController.m:
3268         (-[WK2BrowserWindowController didChangeSettings]):
3269         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3270         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3271         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3272         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3273
3274 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3275
3276         Fix iOS test results after r209967.
3277         
3278         Subtracting out the status bar height was erroneously happening for all tests,
3279         not just for flexible viewport tests.
3280         
3281         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3282
3283         * WebKitTestRunner/PlatformWebView.h:
3284         * WebKitTestRunner/TestController.cpp:
3285         (WTR::TestController::resetStateToConsistentValues):
3286         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3287         (WTR::PlatformWebView::resizeTo):
3288         (WTR::PlatformWebView::setWindowFrame):
3289         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3290         (WTR::PlatformWebView::resizeTo):
3291         (WTR::PlatformWebView::setWindowFrame):
3292         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3293         (WTR::PlatformWebView::resizeTo):
3294         (WTR::PlatformWebView::setWindowFrame):
3295         * WebKitTestRunner/ios/TestControllerIOS.mm:
3296         (WTR::TestController::platformConfigureViewForTest):
3297         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3298         (WTR::PlatformWebView::resizeTo):
3299         (WTR::PlatformWebView::setWindowFrame):
3300
3301 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3302
3303         [EFL] bump EFL version to 1.18.4
3304         https://bugs.webkit.org/show_bug.cgi?id=166004
3305
3306         Reviewed by Gyuyoung Kim.
3307
3308         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3309
3310 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3311
3312         Visual viewports: bottom fixed elements disappear behind the keyboard
3313         https://bugs.webkit.org/show_bug.cgi?id=165983
3314         <rdar://problem/29409852>
3315
3316         Reviewed by Simon Fraser.
3317
3318         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3319         the keyboard when it is up.
3320
3321         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3322         (WTR::UIScriptController::inputViewBounds):
3323         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3324         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3325         (WTR::UIScriptController::inputViewBounds):
3326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3327         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3328         (WTR::viewRectForWindowRect):
3329
3330         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3331         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3332         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3333
3334         (WTR::PlatformWebView::PlatformWebView):
3335         (WTR::PlatformWebView::setWindowFrame):
3336         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3337         (WTR::UIScriptController::inputViewBounds):
3338
3339 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3340
3341         Deleting a character converted from pinyin after an image causes a Safari crash
3342         https://bugs.webkit.org/show_bug.cgi?id=165839
3343         <rdar://problem/27951933>
3344
3345         Reviewed by Wenson Hsieh.
3346
3347         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3348         while the proposed range contains an image. This should not cause a WebProcess to crash
3349         or send an invalid message to the UIProcess.
3350
3351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3352         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3353         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3354         (TestWebKitAPI::didFinishLoadForFrame):
3355         (TestWebKitAPI::processDidCrash):
3356         (TestWebKitAPI::invalidMessageFunction):
3357         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3358
3359 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3360
3361         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3362         https://bugs.webkit.org/show_bug.cgi?id=165767
3363         <rdar://problem/29602382>
3364
3365         Reviewed by Simon Fraser.
3366
3367         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3368         WebKit2 ChangeLog for more details.
3369
3370         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3371         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3372         (WTR::UIScriptController::textSelectionCaretRect):
3373         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3374         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3375         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3376         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3377         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3378         (WTR::UIScriptController::textSelectionCaretRect):
3379         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3380         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3381         (-[TestRunnerWKWebView _setStableStateOverride:]):
3382
3383         Force the WKWebView to update its visible content rects when changing the stable state override.
3384
3385         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3386         (WTR::toNSDictionary):
3387         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3388         (WTR::UIScriptController::selectionRangeViewRects):
3389         (WTR::UIScriptController::textSelectionCaretRect):
3390         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3391         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3392
3393 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3394
3395         Arguments called in wrong order
3396         https://bugs.webkit.org/show_bug.cgi?id=165923
3397
3398         Reviewed by Simon Fraser.
3399
3400         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3401         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3402
3403         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3404         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3405         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3406
3407 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3408
3409         [EFL] Disable non-srcdir builds for failing libraries
3410         https://bugs.webkit.org/show_bug.cgi?id=165896
3411
3412         Reviewed by Gyuyoung Kim.
3413
3414         * efl/jhbuild.modules: Set non srcdir builds to no
3415
3416 2016-12-15  Daniel Bates  <dabates@apple.com>
3417
3418         check-style should not complain about code in icu directories
3419         https://bugs.webkit.org/show_bug.cgi?id=53929
3420
3421         Reviewed by Darin Adler.
3422
3423         Skip style checking of imported ICU headers to avoid a deluge of style issues
3424         as they do not conform to the WebKit Code Style guideline. We want to preserve
3425         the formatting of these headers so as to make it straightforward to merge
3426         changes to them, if necessary.
3427
3428         * Scripts/webkitpy/style/checker.py:
3429
3430 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3431
3432         Move JSC testers from Yosemite to Sierra
3433         https://bugs.webkit.org/show_bug.cgi?id=165925
3434
3435         Reviewed by Lucas Forschler.
3436
3437         * BuildSlaveSupport/build.webkit.org-config/config.json:
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3439         (WebKitBuildbot):
3440
3441 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3442
3443         Add coordinate space to event streams and streamline tests
3444         https://bugs.webkit.org/show_bug.cgi?id=165119
3445
3446         Reviewed by Simon Fraser.
3447
3448         Update event streams to allow for both content and global coordinate space.
3449         Update example script to more accurately show all the available options.
3450
3451         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3452         * WebKitTestRunner/ios/HIDEventGenerator.h:
3453         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3454         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3455         (WTR::convertCoordinates):
3456         (WTR::UIScriptController::sendEventStream):
3457
3458 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3459
3460         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3461         https://bugs.webkit.org/show_bug.cgi?id=165855
3462
3463         Reviewed by Philippe Normand.
3464
3465         GStreamer's autogen.sh enables gtk-doc always so we end up building
3466         docs even if we disable them. Use the configure script instead, since
3467         we build from packages and these include it already.
3468
3469         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3470         upstream gstreamer packages.
3471
3472 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3473
3474         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3475         https://bugs.webkit.org/show_bug.cgi?id=165885
3476         <rdar://problem/29476917>
3477
3478         Reviewed by Darin Adler.
3479
3480         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3481         (TestWebKitAPI::utf16String): Deleted.
3482         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3483         (TestWebKitAPI::TEST_F):
3484         * TestWebKitAPI/WTFStringUtilities.h:
3485         (utf16String):
3486         Moved from URLParser to share with other tests.
3487
3488 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3489
3490         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3491         https://bugs.webkit.org/show_bug.cgi?id=165843
3492
3493         Reviewed by Antti Koivisto.
3494
3495         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3496         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3497         and DumpRenderTree's runUIScript would hit an assertion :(
3498
3499         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3500         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3501         (WTR::TestRunner::isWebKit2):
3502
3503 2016-12-14  Brady Eidson  <beidson@apple.com>
3504
3505         IndexedDB 2.0: Massively speedup IDBIndex.get().
3506         https://bugs.webkit.org/show_bug.cgi?id=165802
3507
3508         Reviewed by Alex Christensen.
3509
3510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3511         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3512         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3513         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3514         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3515
3516 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3517
3518         [GTK][EFL] Update the JHBuild version.
3519         https://bugs.webkit.org/show_bug.cgi?id=165838
3520
3521         Reviewed by Michael Catanzaro.
3522
3523         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3524         usage of the JHBUILD_MIRROR feature with git repositories.
3525
3526 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3527
3528         [GTK] Yasm is needed for building the JHBuild after r208940
3529         https://bugs.webkit.org/show_bug.cgi?id=165837
3530
3531         Reviewed by Alejandro G. Castro.
3532
3533         * gtk/install-dependencies: Yasm is needed for building libvpx.
3534
3535 2016-12-14  Youenn Fablet  <youenn@apple.com>
3536
3537         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3538         https://bugs.webkit.org/show_bug.cgi?id=161310
3539
3540         Reviewed by Ryosuke Niwa.
3541
3542         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3543         When set, WTR and DRT output JS console log in the stderr and not the test output.
3544         This allows removing potentially flaky information while still being able to read it for investigation.
3545
3546         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3547
3548         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3549         This test should have this option when fetch API will start logging resource loader errors.
3550
3551         * DumpRenderTree/DumpRenderTree.h:
3552         (TestCommand::TestCommand): Deleted.
3553         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3554         (parseInputLine):
3555         * DumpRenderTree/TestRunner.h:
3556         (TestRunner::setDumpJSConsoleLogInStdErr):
3557         (TestRunner::dumpJSConsoleLogInStdErr):
3558         * DumpRenderTree/mac/DumpRenderTree.mm:
3559         (runTest):
3560         * DumpRenderTree/mac/UIDelegate.mm:
3561         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3562         * DumpRenderTree/win/DumpRenderTree.cpp:
3563         (runTest):
3564         * DumpRenderTree/win/UIDelegate.cpp:
3565         (UIDelegate::webViewAddMessageToConsole):
3566         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3567         (TestExpectationParser._tokenize_line):
3568         * Scripts/webkitpy/port/driver.py:
3569         (Driver._command_from_driver_input):
3570         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3571         (WTR::InjectedBundle::didReceiveMessageToPage):
3572         (WTR::InjectedBundle::dumpToStdErr):
3573         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3574         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3575         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3576         (WTR::InjectedBundlePage::willAddMessageToConsole):
3577         * WebKitTestRunner/TestController.cpp:
3578         (WTR::parseInputLine):
3579         (WTR::TestController::runTest):
3580         (WTR::TestCommand::TestCommand): Deleted.
3581         * WebKitTestRunner/TestInvocation.cpp:
3582         (WTR::TestInvocation::invoke):
3583         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3584         * WebKitTestRunner/TestInvocation.h:
3585         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3586
3587
3588 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3589
3590         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3591         https://bugs.webkit.org/show_bug.cgi?id=164022
3592
3593         Reviewed by Xabier Rodriguez-Calvar.
3594
3595         * Scripts/webkitperl/FeatureList.pm:
3596           Re-enable MEDIA_SOURCE for the GTK+ port.
3597
3598 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3599
3600         Fix CMake build.
3601
3602         * DumpRenderTree/PlatformMac.cmake:
3603         Define NS_RETURNS_RETAINED as nothing for now.
3604
3605 2016-12-13  Jer Noble  <jer.noble@apple.com>
3606
3607         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3608         https://bugs.webkit.org/show_bug.cgi?id=165697
3609
3610         Reviewed by Tim Horton.
3611
3612         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3613         (TestWebKitAPI::TEST):
3614
3615 2016-12-13  Andy Estes  <aestes@apple.com>
3616
3617         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3618         https://bugs.webkit.org/show_bug.cgi?id=165785
3619         <rdar://problem/26929398>
3620
3621         Reviewed by Darin Adler.
3622
3623         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3624         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3625         expectations for the text, range, and action.
3626         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3627         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3628         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3629         text in the web view did not change.
3630         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3631         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3632         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3633         parameter.
3634         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3635         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3636         and returned the value of _editingDelegateShouldInsertText.
3637         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3638         -shouldInsertText:replacingRange:givenAction:.
3639
3640 2016-12-13  Chris Dumez  <cdumez@apple.com>
3641
3642         Unreviewed, rolling out r209544.
3643
3644         Looks like r209489 did not cause the performance regression
3645         after all
3646
3647         Reverted changeset:
3648
3649         "Unreviewed, rolling out r209489."
3650         https://bugs.webkit.org/show_bug.cgi?id=165550
3651         http://trac.webkit.org/changeset/209544
3652
3653 2016-12-12  Sam Weinig  <sam@webkit.org>
3654
3655         [WebIDL] Remove use of Dictionary in ApplePaySession
3656         https://bugs.webkit.org/show_bug.cgi?id=165787
3657
3658         Reviewed by Anders Carlsson.
3659
3660         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3661         (WTR::initializeWebViewConfiguration):
3662         (WTR::TestController::platformCreateWebView):
3663         Enable ApplePay for the tests (where supported).
3664
3665 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3666
3667         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3668         https://bugs.webkit.org/show_bug.cgi?id=165251
3669
3670         Reviewed by Youenn Fablet.
3671
3672         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3673         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3674         the preferences have been set.
3675
3676 2016-12-08  Antti Koivisto  <antti@apple.com>
3677
3678         Enable network cache speculative revalidation in MiniBrowser
3679         https://bugs.webkit.org/show_bug.cgi?id=165616
3680
3681         Reviewed by Darin Adler.
3682
3683         Match Safari. Also add a menu item to disable it.
3684
3685         * MiniBrowser/mac/AppDelegate.m:
3686         (defaultConfiguration):
3687         * MiniBrowser/mac/SettingsController.h:
3688         * MiniBrowser/mac/SettingsController.m:
3689         (-[SettingsController _populateMenu]):
3690         (-[SettingsController validateMenuItem:]):
3691         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3692         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3693
3694 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3695
3696         ChangeLogs become readonly after resolving a conflict
3697         https://bugs.webkit.org/show_bug.cgi?id=165440
3698         rdar://problem/29491002
3699
3700         Reviewed by Darin Adler.
3701
3702         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3703         moving the file.
3704
3705 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3706
3707         Re-enable collectContinuously since it doesn't crash anymore
3708
3709         Rubber stamped by Michael Saboff.
3710
3711         * Scripts/run-jsc-stress-tests:
3712
3713 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3714
3715         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3716         https://bugs.webkit.org/show_bug.cgi?id=165686
3717
3718         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3719         so that right config.h comes first in include path.
3720
3721 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3722
3723         [CSS Parser] Make sure content extensions initialize AtomicString
3724         https://bugs.webkit.org/show_bug.cgi?id=165737
3725
3726         Reviewed by Darin Adler.
3727
3728         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3729         (TestWebKitAPI::makeBackend):
3730
3731 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3732
3733         [CSS Parser] Remove the old CSS Parser
3734         https://bugs.webkit.org/show_bug.cgi?id=165645
3735
3736         Reviewed by Daniel Bates.
3737
3738         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3739         (TestWebKitAPI::TEST):
3740
3741 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3742
3743         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3744         https://bugs.webkit.org/show_bug.cgi?id=165686
3745
3746         Reviewed by Michael Catanzaro.
3747
3748         This change reduces duplication of include path lists between modules,
3749         and reduces future need for fixes like r209605 (broken build because of
3750         WebCore header suddenly becoming used in WebKit2).
3751
3752         * DumpRenderTree/CMakeLists.txt:
3753         * DumpRenderTree/PlatformMac.cmake:
3754         * ImageDiff/CMakeLists.txt:
3755         * MiniBrowser/gtk/CMakeLists.txt:
3756         * MiniBrowser/mac/CMakeLists.txt:
3757         * MiniBrowser/win/CMakeLists.txt:
3758         * TestWebKitAPI/CMakeLists.txt:
3759         * TestWebKitAPI/PlatformEfl.cmake:
3760         * TestWebKitAPI/PlatformJSCOnly.cmake:
3761         * TestWebKitAPI/PlatformMac.cmake:
3762         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3763         * WebKitTestRunner/CMakeLists.txt:
3764         * WebKitTestRunner/PlatformGTK.cmake:
3765         * WebKitTestRunner/PlatformMac.cmake:
3766
3767 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3768
3769         Unreviewed buildfix after r209630.
3770
3771         * Scripts/build-jsc: Remove building the non-existing testWASM.
3772
3773 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3774
3775         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3776         https://bugs.webkit.org/show_bug.cgi?id=165251
3777
3778         Reviewed by Dean Jackson.
3779
3780         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3781
3782         * DumpRenderTree/mac/DumpRenderTree.mm:
3783         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3784
3785         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3786         (WTR::InjectedBundle::beginTesting): Ditto.
3787
3788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3789         (WTR::TestRunner::setMediaStreamEnabled): New.
3790         (WTR::TestRunner::setPeerConnectionEnabled): New.
3791         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3792
3793 2016-12-09  Brady Eidson  <beidson@apple.com> 
3794  
3795         Re-landing:
3796         Add _WKIconLoadingDelegate SPI. 
3797         https://bugs.webkit.org/show_bug.cgi?id=164894 
3798  
3799         Reviewed by Alex Christensen. 
3800         
3801         Add MiniBrowser support for this new SPI, configurable with a setting. 
3802  
3803         * MiniBrowser/mac/SettingsController.h: 
3804         * MiniBrowser/mac/SettingsController.m: 
3805         (-[SettingsController _populateMenu]): 
3806         (-[SettingsController validateMenuItem:]): 
3807         (-[SettingsController loadsAllSiteIcons]): 
3808         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3809         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3810         (-[WK2BrowserWindowController awakeFromNib]): 
3811         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3812
3813 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3814
3815         Fix the 32-bit build.
3816
3817         Unreviewed build fix.
3818
3819         * MiniBrowser/mac/SettingsController.h:
3820
3821 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3822
3823         Fedora also needs a PHP7 config file alternative
3824         https://bugs.webkit.org/show_bug.cgi?id=165606
3825
3826         Reviewed by Michael Catanzaro.
3827
3828         * Scripts/webkitpy/port/base.py:
3829         (Port._is_fedora_php_version_7): check for the php7 library.
3830         (Port._fedora_php_version): get the appropriate filename for Fedora.
3831         (Port._apache_config_file_name_for_platform):
3832
3833 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3834
3835         Complete the revert of r208865.
3836         https://bugs.webkit.org/show_bug.cgi?id=164894
3837
3838         Unreviewed build fix.
3839
3840         * MiniBrowser/mac/SettingsController.h:
3841         * MiniBrowser/mac/SettingsController.m:
3842         (-[SettingsController _populateMenu]):
3843         (-[SettingsController validateMenuItem:]):
3844         (-[SettingsController loadsAllSiteIcons]): Deleted.
3845         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3846         * MiniBrowser/mac/WK2BrowserWindowController.m:
3847         (-[WK2BrowserWindowController awakeFromNib]):
3848         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3849
3850 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3851
3852         [GTK] Force GDK backend to x11 when running with XvfbDriver
3853         https://bugs.webkit.org/show_bug.cgi?id=165612
3854
3855         Reviewed by Michael Catanzaro.
3856
3857         When the developer is running a Wayland session, GDK may get confused
3858         and try to use its Wayland backend (which is higher priority) instead.
3859         This ensures it will use the appropriate backend when running under
3860         Xvfb.
3861
3862         * Scripts/webkitpy/port/gtk.py:
3863         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3864         force GDK_BACKEND to x11.
3865
3866 2016-12-08  Keith Miller  <keith_miller@apple.com>
3867
3868         Add 64-bit signed LEB decode method
3869         https://bugs.webkit.org/show_bug.cgi?id=165630
3870
3871         Reviewed by Ryosuke Niwa.
3872
3873         Add tests for LEB int64 and uint64 decode since I guess
3874         I forgot to add tests before.
3875
3876         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3877         (TestWebKitAPI::testUInt32LEBDecode):
3878         (TestWebKitAPI::TEST):
3879         (TestWebKitAPI::testUInt64LEBDecode):
3880         (TestWebKitAPI::testInt32LEBDecode):
3881         (TestWebKitAPI::testInt64LEBDecode):
3882         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3883
3884 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3885
3886         Make it easy to enable --force-collectContinuously
3887         https://bugs.webkit.org/show_bug.cgi?id=165638
3888
3889         Reviewed by Keith Miller.
3890
3891         * Scripts/run-javascriptcore-tests:
3892         (runJSCStressTests):
3893
3894 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3895
3896         Disable the collectContinuously mode until I investigate failures.
3897
3898         Rubber stamped by Keith Miller.
3899         
3900         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3901         while I investigate.
3902
3903         * Scripts/run-jsc-stress-tests:
3904
3905 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3906
3907         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3908         https://bugs.webkit.org/show_bug.cgi?id=165621
3909
3910         Reviewed by Dan Bernstein.
3911
3912         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3913         (TestWebKitAPI::TEST_F):
3914
3915 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3916
3917         Concurrent GC should be stable enough to land enabled
3918         https://bugs.webkit.org/show_bug.cgi?id=164990
3919
3920         Reviewed by Geoffrey Garen.
3921         
3922         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3923         
3924         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3925         safe for debug. It might be too slow for debug.
3926
3927         * Scripts/run-jsc-stress-tests:
3928
3929 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3930
3931         Add SPI for sending WebsiteSettings to WebProcess during navigation
3932         https://bugs.webkit.org/show_bug.cgi?id=165517
3933         <rdar://29341068>
3934
3935         Reviewed by Anders Carlsson.
3936
3937         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3938         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3939         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3940         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3941         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3942         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3943         (TEST):
3944
3945 2016-12-08  Chris Dumez  <cdumez@apple.com>
3946
3947         Unreviewed, rolling out r209489.
3948
3949         Likely caused large regressions on JetStream, Sunspider and
3950         Speedometer
3951
3952         Reverted changeset:
3953
3954         "Add system trace points for JavaScript VM entry/exit"
3955         https://bugs.webkit.org/show_bug.cgi?id=165550
3956         http://trac.webkit.org/changeset/209489
3957
3958 2016-12-08  Keith Miller  <keith_miller@apple.com>
3959
3960         Move LEB tests to API tests
3961         https://bugs.webkit.org/show_bug.cgi?id=165586
3962
3963         Reviewed by Saam Barati.
3964
3965         Move the tests from testWasm.cpp and make them functions
3966         rather than macros.
3967
3968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3969         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3970         (TestWebKitAPI::testUnsignedLEBDecode):
3971         (TestWebKitAPI::TEST):
3972         (TestWebKitAPI::testInt32LEBDecode):
3973
3974 2016-12-08  Chris Dumez  <cdumez@apple.com>
3975
3976         Support running the layout tests offline
3977         https://bugs.webkit.org/show_bug.cgi?id=165534
3978
3979         Reviewed by Ryosuke Niwa.
3980
3981         * Scripts/webkitpy/common/system/autoinstall.py:
3982         (AutoInstaller._download_to_stream):
3983         getcode() returns None for file URLs so handle this.
3984
3985         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3986         (WebPlatformTestServer._install_modules):
3987         Deal with local path in the json file and resolve them into file URLs
3988         before using AutoInstall.
3989
3990 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3991
3992         Fix CMake build.
3993
3994         * DumpRenderTree/PlatformMac.cmake:
3995         Remove CheckedMalloc.cpp after r209516.
3996
3997 2016-12-07  Mark Lam  <mark.lam@apple.com>
3998
3999         DumpRenderTree should stop using CheckedMalloc.
4000         https://bugs.webkit.org/show_bug.cgi?id=165563
4001         <rdar://problem/28945820>
4002
4003         Reviewed by Geoffrey Garen.
4004
4005         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
4006            in CheckedMalloc.
4007         2. bmalloc does not honor the settings of CheckedMalloc.
4008
4009         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
4010         malloc.  As a result, DRT exhibits different behavior from the normal way we run
4011         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
4012         with WKTR.
4013
4014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4015         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
4016         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
4017         * DumpRenderTree/mac/DumpRenderTree.mm:
4018         (prepareConsistentTestingEnvironment):
4019
4020 2016-12-07  Dean Jackson  <dino@apple.com>
4021
4022         Remove runtime toggle for pointer-lock
4023         https://bugs.webkit.org/show_bug.cgi?id=165577
4024         <rdar://problems/29566996>
4025
4026         Reviewed by Jon Lee.
4027
4028         Remove any runtime calls to check if pointer-lock is enabled. It's
4029         either compiled in or out.
4030
4031         * DumpRenderTree/mac/DumpRenderTree.mm:
4032         (resetWebPreferencesToConsistentValues):
4033         * WebKitTestRunner/TestController.cpp:
4034         (WTR::TestController::resetPreferencesToConsistentValues):
4035
4036 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
4037
4038         [MediaStream][Mac] Revoke sandbox extensions when capture ends
4039         https://bugs.webkit.org/show_bug.cgi?id=165476
4040
4041         Reviewed by Brady Eidson.
4042         
4043         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
4044         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
4045         is reset and recreated when a web page exits and is reloaded.
4046
4047         * TestWebKitAPI/PlatformGTK.cmake:
4048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4049         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
4050         (TestWebKitAPI::checkUserMediaPermissionCallback):
4051         (TestWebKitAPI::TEST):
4052         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
4053
4054 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
4055
4056         One esc to exit fullscreen and pointer lock
4057         https://bugs.webkit.org/show_bug.cgi?id=165416
4058         rdar://problem/29430711
4059
4060         Reviewed by Jer Noble.
4061
4062         Implement WKPageUIClientV8 for pointer lock support.
4063         Add "escape" key support in EventSenderProxy.
4064
4065         * WebKitTestRunner/TestController.cpp:
4066         (WTR::requestPointerLock):
4067         (WTR::TestController::createOtherPage):
4068         (WTR::TestController::createWebViewWithOptions):
4069         * WebKitTestRunner/mac/EventSenderProxy.mm:
4070         (WTR::EventSenderProxy::keyDown):
4071
4072 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4073
4074         Add system trace points for JavaScript VM entry/exit
4075         https://bugs.webkit.org/show_bug.cgi?id=165550
4076
4077         Reviewed by Tim Horton.
4078
4079         Add trace points for entry/exit into/out of the JS VM.
4080
4081         * Tracing/SystemTracePoints.plist:
4082
4083 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
4084
4085         [GTK] Cannot build GTK+ with CUPS 2.* versions
4086         https://bugs.webkit.org/show_bug.cgi?id=163591
4087
4088         Reviewed by Michael Catanzaro.
4089
4090         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
4091         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
4092         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
4093         old gtk+ since it requires not only bumping up glib accordingly and its consequence
4094         causes many printing test failures. So, I propose to fix the configuration issue by
4095         applying the change to the configure file directly. By doing this, we don't need to
4096         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
4097
4098         * gtk/jhbuild.modules:
4099         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
4100
4101 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4102
4103         Fix use of enum in a WK2 C SPI header.
4104         rdar://problem/28725583
4105
4106         Followup to correctly prefix the enum values.
4107
4108         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4109         (WTR::InjectedBundlePage::prepare):
4110
4111 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
4112
4113         Fix use of enum in a WK2 C SPI header.
4114         rdar://problem/28725583
4115
4116         Reviewed by Dan Bernstein.
4117
4118         Use correct enum style for a C SPI header and fix the callers.
4119
4120         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4121         (WTR::InjectedBundlePage::prepare):
4122
4123 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4124
4125         Add a new project for recording and playing back editing commands in editable web content
4126         https://bugs.webkit.org/show_bug.cgi?id=165114
4127         <rdar://problem/29408135>
4128
4129         Reviewed by Beth Dakin.
4130
4131         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
4132         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
4133         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
4134         then be dragged into the playback test harness.
4135
4136         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
4137         steps:
4138
4139         1. Load the capture harness and perform test-specific editing on the web view.
4140         2. Let originalState be a dump of the DOM at this point in time.
4141         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
4142         4. Rewind all editing to the beginning.
4143         5. Playback all editing to the end.
4144         6. Dump the state of the DOM. This should be identical to originalState.
4145
4146         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
4147         * EditingHistory/EditingHistory/Info.plist: Added.
4148         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
4149         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
4150         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
4151         * EditingHistory/EditingHistory/TestRunner.h: Added.
4152         * EditingHistory/EditingHistory/TestRunner.m: Added.
4153         (injectedMessageEventHandlerScript):
4154         (-[TestRunner init]):
4155         (-[TestRunner deleteBackwards:]):
4156         (-[TestRunner typeString:]):
4157         (-[TestRunner bodyElementSubtree]):
4158         (-[TestRunner bodyTextContent]):
4159         (-[TestRunner editingHistoryJSON]):
4160         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
4161         (-[TestRunner numberOfUpdates]):
4162         (-[TestRunner jumpToUpdateIndex:]):
4163         (-[TestRunner expectEvents:afterPerforming:]):
4164         (-[TestRunner loadCaptureTestHarness]):
4165         (-[TestRunner setTextObfuscationEnabled:]):
4166         (-[TestRunner isDoneWaitingForPendingEvents]):
4167         (-[TestRunner userContentController:didReceiveScriptMessage:]):
4168
4169         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
4170         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
4171
4172         * EditingHistory/EditingHistory/TestUtil.h: Added.
4173         * EditingHistory/EditingHistory/TestUtil.m: Added.
4174         (waitUntilWithTimeout):
4175         (waitUntil):
4176
4177         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
4178
4179         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
4180         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
4181         (-[WKWebView loadPageFromBundleNamed:]):
4182         (-[WKWebView typeCharacter:]):
4183         (-[WKWebView keyPressWithCharacters:keyCode:]):
4184         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
4185
4186         Provides utilities for simulating interaction in a web view.
4187
4188         * EditingHistory/EditingHistory/main.m: Added.
4189         (main):
4190         * EditingHistory/EditingHistoryTests/Info.plist: Added.
4191         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
4192         (-[RewindAndPlaybackTests setUp]):
4193         (-[RewindAndPlaybackTests tearDown]):
4194         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
4195         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
4196         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
4197         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
4198         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
4199
4200 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4201
4202         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
4203         https://bugs.webkit.org/show_bug.cgi?id=165525
4204
4205         Reviewed by Carlos Garcia Campos.
4206
4207         * gtk/jhbuild.modules: gst-plugins-good should depend on the
4208         libvpx package built within jhbuild.
4209
4210 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4211
4212         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
4213         https://bugs.webkit.org/show_bug.cgi?id=165520
4214
4215         Reviewed by Carlos Garcia Campos.
4216
4217         * gtk/jhbuild.modules: Added missing dependency on openh264 in
4218         gst-plugins-bad, along with 2 upstream patches fixing the build
4219         against OpenSSL 1.1.0.
4220         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4221         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4222
4223 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
4224
4225         Correct SDKROOT values in xcconfig files
4226         https://bugs.webkit.org/show_bug.cgi?id=165487
4227         rdar://problem/29539209
4228
4229         Reviewed by Dan Bernstein.
4230
4231         Fix suggested by Dan Bernstein.
4232
4233         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
4234         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4235         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4236         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4237         * WebEditingTester/Configurations/DebugRelease.xcconfig:
4238         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4239
4240 2016-12-06  Daniel Bates  <dabates@apple.com>
4241
4242         WebKitTestRunner: Plugins are disabled in new windows
4243         https://bugs.webkit.org/show_bug.cgi?id=165410
4244
4245         Reviewed by Alex Christensen.
4246
4247         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
4248         a new window and loads a plugin will fail. We should enable plugins in all windows by
4249         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4250
4251         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4252         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4253         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4254
4255         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4256         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4257         WKBundleSetPluginsEnabled().
4258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4259         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
4260         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
4261
4262 2016-12-05  Dean Jackson  <dino@apple.com>
4263
4264         pointer lock needs to be feature detectable
4265         https://bugs.webkit.org/show_bug.cgi?id=165426
4266         <rdar://problem/29486715>
4267
4268         Reviewed by Antoine Quint.
4269
4270         Expose the comment line to turn on/off pointer lock.
4271
4272         * DumpRenderTree/TestOptions.h:
4273         * DumpRenderTree/TestOptions.mm:
4274         (TestOptions::TestOptions):
4275         * DumpRenderTree/mac/DumpRenderTree.mm:
4276         (resetWebPreferencesToConsistentValues):
4277         * WebKitTestRunner/TestController.cpp:
4278         (WTR::TestController::resetPreferencesToConsistentValues):
4279         (WTR::updateTestOptionsFromTestHeader):
4280         * WebKitTestRunner/TestOptions.h:
4281         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4282         (WTR::PlatformWebView::viewSupportsOptions):
4283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4284         (WTR::PlatformWebView::viewSupportsOptions):
4285
4286 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
4287
4288         Make it possible to use an existing simulator instance for one-off testing
4289         https://bugs.webkit.org/show_bug.cgi?id=164568
4290         <rdar://problem/29189133>
4291
4292         Reviewed by Daniel Bates.
4293
4294         With this patch, if a simulator is currently running on the machine and
4295         '--dedicated-simulators' is not passed into the application, only one simulator
4296         instance will be used, and this instance will be the existing instance.
4297         If no simulator is running or '--dedicated-simulators' is passed to the script,
4298         previous behavior will be used.
4299
4300         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4301         (parse_args):
4302         * Scripts/webkitpy/port/ios.py:
4303         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4304         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4305         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4306         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4307         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them.