[WTF] StringBuilder should set correct m_is8Bit flag when merging
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2
3         [WTF] StringBuilder should set correct m_is8Bit flag when merging
4         https://bugs.webkit.org/show_bug.cgi?id=197053
5
6         Reviewed by Saam Barati.
7
8         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
9         (TestWebKitAPI::TEST):
10
11 2019-04-17  Tim Horton  <timothy_horton@apple.com>
12
13         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
14         https://bugs.webkit.org/show_bug.cgi?id=197028
15         <rdar://problem/49985290>
16
17         Reviewed by Wenson Hsieh.
18
19         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
20         (TEST):
21         Liberal application of waitForNextPresentationUpdate works around a race
22         where if the page rapidly changes its viewport arguments (or an API client
23         rapidly changes its viewport arguments), we'd get stuck thinking that the
24         user had intentionally zoomed the page, and stop resetting the initial scale.
25         This deserves a separate bug, but no need to keep the test failing while
26         we think about it.
27
28 2019-04-17  Tim Horton  <timothy_horton@apple.com>
29
30         REGRESSION (r241988): Switching tabs is slow
31         https://bugs.webkit.org/show_bug.cgi?id=197037
32         <rdar://problem/49951473>
33
34         Reviewed by Simon Fraser.
35
36         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
38         (TEST):
39         * TestWebKitAPI/cocoa/TestWKWebView.h:
40         * TestWebKitAPI/cocoa/TestWKWebView.mm:
41         (-[TestWKWebView addToTestWindow]):
42         Add a test that hangs without this fix.
43
44 2019-04-17  Truitt Savell  <tsavell@apple.com>
45
46         Unreviewed, rolling out r244400.
47
48         Caused testing to exit early with assertionon Debug WK2
49
50         Reverted changeset:
51
52         "UI↔Web deadlock when printing with a JavaScript alert
53         visible"
54         https://bugs.webkit.org/show_bug.cgi?id=196839
55         https://trac.webkit.org/changeset/244400
56
57 2019-04-17  Brady Eidson  <beidson@apple.com>
58
59         Link clicks in PDFs shouldn't send referrer headers.
60         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
61
62         Reviewed by Tim Horton.
63
64         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
65         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
66         (putPDFBytesCallback):
67         (emptyReleaseInfoCallback):
68         (createPDFWithLinkToURL):
69         (TEST):
70
71 2019-04-17  Tim Horton  <timothy_horton@apple.com>
72
73         UI↔Web deadlock when printing with a JavaScript alert visible
74         https://bugs.webkit.org/show_bug.cgi?id=196839
75         <rdar://problem/49157642>
76
77         Reviewed by Andy Estes.
78
79         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
80         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
81         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
82         (TEST):
83
84 2019-04-17  Alex Christensen  <achristensen@webkit.org>
85
86         WKRetainPtr's adoption constructor should be private
87         https://bugs.webkit.org/show_bug.cgi?id=197019
88
89         Reviewed by Tim Horton.
90
91         * DumpRenderTree/mac/DumpRenderTree.mm:
92         (dumpFramesAsText):
93         * TestWebKitAPI/InjectedBundleController.cpp:
94         (TestWebKitAPI::InjectedBundleController::initialize):
95         * TestWebKitAPI/PlatformUtilities.cpp:
96         (TestWebKitAPI::Util::createContextWithInjectedBundle):
97         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
98         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
99         (TestWebKitAPI::Util::toWK):
100         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
101         (TestWebKitAPI::TEST):
102         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
105         (TestWebKitAPI::TEST):
106         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
109         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
110         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
111         (TestWebKitAPI::TEST):
112         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
113         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
114         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
117         (TestWebKitAPI::TEST):
118         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
119         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
120         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
123         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
124         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
125         (TestWebKitAPI::TEST):
126         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
129         (TestWebKitAPI::TEST):
130         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit/Find.cpp:
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
149         (TestWebKitAPI::TEST):
150         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
151         (TestWebKitAPI::TEST):
152         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
153         (TestWebKitAPI::TEST):
154         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
155         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
156         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
159         (TestWebKitAPI::TEST):
160         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
161         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
162         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
163         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
164         (TestWebKitAPI::TEST):
165         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
166         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
167         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
170         (TestWebKitAPI::TEST):
171         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
172         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
173         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
174         (TestWebKitAPI::TEST):
175         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
176         (TestWebKitAPI::loadAlternateHTMLString):
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
181         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
182         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
183         (TestWebKitAPI::buildAndPerformTest):
184         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
185         (TestWebKitAPI::TEST):
186         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
193         (TestWebKitAPI::TEST):
194         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
195         (TestWebKitAPI::TEST):
196         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
203         (TestWebKitAPI::TEST):
204         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
205         (TestWebKitAPI::TEST):
206         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
207         (TestWebKitAPI::TEST):
208         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
209         (TestWebKitAPI::TEST):
210         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
211         (TestWebKitAPI::TEST):
212         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
213         (TestWebKitAPI::TEST):
214         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
219         (TestWebKitAPI::TEST):
220         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
221         (TestWebKitAPI::TEST):
222         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
223         (TestWebKitAPI::TEST):
224         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
227         (TestWebKitAPI::TEST):
228         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
231         (TestWebKitAPI::TEST):
232         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
233         (TestWebKitAPI::TEST):
234         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
235         (TestWebKitAPI::TEST):
236         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
237         (TestWebKitAPI::TEST):
238         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
239         (TestWebKitAPI::TEST):
240         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
243         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
244         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
255         (TestWebKitAPI::TEST):
256         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
257         (TestWebKitAPI::TEST):
258         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
259         (TestWebKitAPI::TEST):
260         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
266         (TEST):
267         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
268         (TEST):
269         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
270         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
271         (TEST):
272         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
273         (TestWebKitAPI::TEST):
274         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
275         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
276         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
277         (WTR::getMenuItemTitleCallback):
278         (WTR::createMouseMessageBody):
279         (WTR::EventSendingController::mouseDown):
280         (WTR::EventSendingController::mouseUp):
281         (WTR::EventSendingController::mouseMoveTo):
282         (WTR::EventSendingController::mouseForceClick):
283         (WTR::EventSendingController::startAndCancelMouseForceClick):
284         (WTR::EventSendingController::mouseForceDown):
285         (WTR::EventSendingController::mouseForceUp):
286         (WTR::EventSendingController::mouseForceChanged):
287         (WTR::EventSendingController::leapForward):
288         (WTR::EventSendingController::scheduleAsynchronousClick):
289         (WTR::createKeyDownMessageBody):
290         (WTR::EventSendingController::keyDown):
291         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
292         (WTR::EventSendingController::mouseScrollBy):
293         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
294         (WTR::EventSendingController::continuousMouseScrollBy):
295         (WTR::EventSendingController::addTouchPoint):
296         (WTR::EventSendingController::updateTouchPoint):
297         (WTR::EventSendingController::setTouchModifier):
298         (WTR::EventSendingController::setTouchPointRadius):
299         (WTR::EventSendingController::touchStart):
300         (WTR::EventSendingController::touchMove):
301         (WTR::EventSendingController::touchEnd):
302         (WTR::EventSendingController::touchCancel):
303         (WTR::EventSendingController::clearTouchPoints):
304         (WTR::EventSendingController::releaseTouchPoint):
305         (WTR::EventSendingController::cancelTouchPoint):
306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
307         (WTR::InjectedBundle::didCreatePage):
308         (WTR::InjectedBundle::didReceiveMessage):
309         (WTR::InjectedBundle::didReceiveMessageToPage):
310         (WTR::InjectedBundle::booleanForKey):
311         (WTR::InjectedBundle::done):
312         (WTR::InjectedBundle::dumpToStdErr):
313         (WTR::InjectedBundle::outputText):
314         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
315         (WTR::InjectedBundle::postAddChromeInputField):
316         (WTR::InjectedBundle::postRemoveChromeInputField):
317         (WTR::InjectedBundle::postFocusWebView):
318         (WTR::InjectedBundle::postSetBackingScaleFactor):
319         (WTR::InjectedBundle::postSetWindowIsKey):
320         (WTR::InjectedBundle::postSetViewSize):
321         (WTR::InjectedBundle::postSimulateWebNotificationClick):
322         (WTR::InjectedBundle::postSetAddsVisitedLinks):
323         (WTR::InjectedBundle::setGeolocationPermission):
324         (WTR::InjectedBundle::setMockGeolocationPosition):
325         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
326         (WTR::InjectedBundle::isGeolocationProviderActive const):
327         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
328         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
329         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
330         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
331         (WTR::InjectedBundle::setCustomPolicyDelegate):
332         (WTR::InjectedBundle::setHidden):
333         (WTR::InjectedBundle::setCacheModel):
334         (WTR::InjectedBundle::shouldProcessWorkQueue const):
335         (WTR::InjectedBundle::processWorkQueue):
336         (WTR::InjectedBundle::queueBackNavigation):
337         (WTR::InjectedBundle::queueForwardNavigation):
338         (WTR::InjectedBundle::queueLoad):
339         (WTR::InjectedBundle::queueLoadHTMLString):
340         (WTR::InjectedBundle::queueReload):
341         (WTR::InjectedBundle::queueLoadingScript):
342         (WTR::InjectedBundle::queueNonLoadingScript):
343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
344         (WTR::frameToStr):
345         (WTR::InjectedBundlePage::InjectedBundlePage):
346         (WTR::dumpFrameDescriptionSuitableForTestResult):
347         (WTR::dumpFrameScrollPosition):
348         (WTR::dumpDescendantFrameScrollPositions):
349         (WTR::dumpFrameText):
350         (WTR::dumpDescendantFramesText):
351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
352         (WTR::TestRunner::shouldDumpPixels const):
353         (WTR::TestRunner::setDumpPixels):
354         (WTR::TestRunner::whatToDump const):
355         (WTR::TestRunner::setWhatToDump):
356         (WTR::TestRunner::setWaitUntilDone):
357         (WTR::TestRunner::shouldWaitUntilDone const):
358         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
359         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
360         (WTR::TestRunner::clearAllDatabases):
361         (WTR::TestRunner::setIDBPerOriginQuota):
362         (WTR::TestRunner::originsWithApplicationCache):
363         (WTR::TestRunner::setCanOpenWindows):
364         (WTR::TestRunner::setXSSAuditorEnabled):
365         (WTR::TestRunner::setMediaDevicesEnabled):
366         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
367         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
368         (WTR::TestRunner::setCustomUserAgent):
369         (WTR::TestRunner::setWebAPIStatisticsEnabled):
370         (WTR::TestRunner::setModernMediaControlsEnabled):
371         (WTR::TestRunner::setWebGL2Enabled):
372         (WTR::TestRunner::setWritableStreamAPIEnabled):
373         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
374         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
375         (WTR::TestRunner::setAllowsAnySSLCertificate):
376         (WTR::TestRunner::setPluginsEnabled):
377         (WTR::TestRunner::setValueForUser):
378         (WTR::TestRunner::setAudioResult):
379         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
380         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
381         (WTR::TestRunner::setAlwaysAcceptCookies):
382         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
383         (WTR::TestRunner::isDoingMediaCapture const):
384         (WTR::TestRunner::queueLoad):
385         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
386         (WTR::TestRunner::setHandlesAuthenticationChallenges):
387         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
388         (WTR::TestRunner::setShouldLogDownloadCallbacks):
389         (WTR::TestRunner::setAuthenticationUsername):
390         (WTR::TestRunner::setAuthenticationPassword):
391         (WTR::TestRunner::secureEventInputIsEnabled const):
392         (WTR::TestRunner::setBlockAllPlugins):
393         (WTR::TestRunner::setPluginSupportedMode):
394         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
395         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
396         (WTR::TestRunner::setNavigationGesturesEnabled):
397         (WTR::TestRunner::setIgnoresViewportScaleLimits):
398         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
399         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
400         (WTR::TestRunner::terminateNetworkProcess):
401         (WTR::TestRunner::terminateServiceWorkerProcess):
402         (WTR::TestRunner::runUIScript):
403         (WTR::TestRunner::setStatisticsDebugMode):
404         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
405         (WTR::TestRunner::setStatisticsLastSeen):
406         (WTR::TestRunner::setStatisticsPrevalentResource):
407         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
408         (WTR::TestRunner::dumpResourceLoadStatistics):
409         (WTR::TestRunner::isStatisticsPrevalentResource):
410         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
411         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
412         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
413         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
414         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
415         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
416         (WTR::TestRunner::setStatisticsGrandfathered):
417         (WTR::TestRunner::isStatisticsGrandfathered):
418         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
419         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
420         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
421         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
422         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
423         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
424         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
425         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
426         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
427         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
428         (WTR::TestRunner::statisticsUpdateCookieBlocking):
429         (WTR::TestRunner::statisticsSubmitTelemetry):
430         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
431         (WTR::TestRunner::setStatisticsIsRunningTest):
432         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
433         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
434         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
435         (WTR::TestRunner::setStatisticsGrandfatheringTime):
436         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
437         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
438         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
439         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
440         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
441         (WTR::TestRunner::statisticsDeleteCookiesForHost):
442         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
443         (WTR::TestRunner::statisticsResetToConsistentState):
444         (WTR::TestRunner::setStorageAccessAPIEnabled):
445         (WTR::TestRunner::getAllStorageAccessEntries):
446         (WTR::TestRunner::addMockMediaDevice):
447         (WTR::TestRunner::clearMockMediaDevices):
448         (WTR::TestRunner::removeMockMediaDevice):
449         (WTR::TestRunner::resetMockMediaDevices):
450         (WTR::TestRunner::connectMockGamepad):
451         (WTR::TestRunner::disconnectMockGamepad):
452         (WTR::TestRunner::setMockGamepadDetails):
453         (WTR::TestRunner::setMockGamepadAxisValue):
454         (WTR::TestRunner::setMockGamepadButtonValue):
455         (WTR::TestRunner::removeAllSessionCredentials):
456         (WTR::TestRunner::clearDOMCache):
457         (WTR::TestRunner::clearDOMCaches):
458         (WTR::TestRunner::hasDOMCache):
459         (WTR::TestRunner::domCacheSize):
460         (WTR::TestRunner::setAllowStorageQuotaIncrease):
461         (WTR::TestRunner::getApplicationManifestThen):
462         (WTR::TestRunner::injectUserScript):
463         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
464         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
465         (WTR::TestRunner::addTestKeyToKeychain):
466         (WTR::TestRunner::cleanUpKeychain):
467         (WTR::TestRunner::keyExistsInKeychain):
468         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
469         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
470         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
471         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
472         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
473         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
474         * WebKitTestRunner/TestController.cpp:
475         (WTR::TestController::initialize):
476         (WTR::parseStringTestHeaderValueAsRelativePath):
477         (WTR::updateTestOptionsFromTestHeader):
478         (WTR::TestController::runTest):
479         (WTR::TestController::didReceiveLiveDocumentsList):
480         (WTR::TestController::didReceiveMessageFromInjectedBundle):
481         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
482         (WTR::TestController::didFinishNavigation):
483         (WTR::TestController::didReceiveAuthenticationChallenge):
484         * WebKitTestRunner/TestInvocation.cpp:
485         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
486         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
487         (WTR::TestInvocation::uiScriptDidComplete):
488         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
489         * WebKitTestRunner/WebNotificationProvider.cpp:
490         (WTR::WebNotificationProvider::closeWebNotification):
491         * WebKitTestRunner/WorkQueueManager.cpp:
492         (WTR::ScriptItem::ScriptItem):
493         (WTR::WorkQueueManager::queueLoad):
494         (WTR::WorkQueueManager::queueLoadHTMLString):
495
496 2019-04-17  Alex Christensen  <achristensen@webkit.org>
497
498         Add a comment to make my test from r244139 less mysterious.
499         https://bugs.webkit.org/show_bug.cgi?id=196744
500
501         As suggested by Darin Adler.
502
503         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
504         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
505
506 2019-04-17  Chris Dumez  <cdumez@apple.com>
507
508         Remember device orientation permission for the duration of the browsing session
509         https://bugs.webkit.org/show_bug.cgi?id=196992
510         <rdar://problem/49946067>
511
512         Reviewed by Alex Christensen.
513
514         Add API test coverage.
515
516         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
517         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
518         (TEST):
519
520 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
521
522         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
523         https://bugs.webkit.org/show_bug.cgi?id=196675
524
525         Reviewed by Lucas Forschler.
526
527         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
528         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
529
530 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
531
532         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
533         https://bugs.webkit.org/show_bug.cgi?id=196919
534         <rdar://problem/41630459>
535
536         Reviewed by Tim Horton.
537
538         Add iOS support for several new testing hooks. See below for more detail.
539
540         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
541         (WTR::UIScriptController::isDismissingMenu const):
542
543         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
544         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
545         by UIKit when dismissing the callout bar (i.e. UIMenuController).
546
547         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
548         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
549         (WTR::UIScriptController::isDismissingMenu const):
550         * TestRunnerShared/UIScriptContext/UIScriptController.h:
551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
553         (WTR::InjectedBundle::didReceiveMessageToPage):
554         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
555         (WTR::TestRunner::setAllowedMenuActions):
556
557         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
558         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
559         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
560         against the name of the custom action.
561
562         (WTR::TestRunner::installCustomMenuAction):
563
564         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
565         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
566         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
567         triggered.
568
569         (WTR::TestRunner::performCustomMenuAction):
570
571         Invoked when the custom menu action is triggered.
572
573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::TestController::installCustomMenuAction):
576         (WTR::TestController::setAllowedMenuActions):
577         * WebKitTestRunner/TestController.h:
578         * WebKitTestRunner/TestInvocation.cpp:
579         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
580         (WTR::TestInvocation::performCustomMenuAction):
581
582         Add plumbing to call back into the injected bundle when performing the custom action.
583
584         * WebKitTestRunner/TestInvocation.h:
585         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
586         (WTR::TestController::installCustomMenuAction):
587         (WTR::TestController::setAllowedMenuActions):
588         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
589         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
590         (-[TestRunnerWKWebView initWithFrame:configuration:]):
591         (-[TestRunnerWKWebView becomeFirstResponder]):
592         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
593
594         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
595         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
596         in the Mail app on iOS.
597
598         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
599         (-[TestRunnerWKWebView setAllowedMenuActions:]):
600         (-[TestRunnerWKWebView resetCustomMenuAction]):
601         (-[TestRunnerWKWebView performCustomAction:]):
602         (-[TestRunnerWKWebView canPerformAction:withSender:]):
603         (-[TestRunnerWKWebView _willHideMenu]):
604         (-[TestRunnerWKWebView _didHideMenu]):
605         * WebKitTestRunner/ios/TestControllerIOS.mm:
606         (WTR::TestController::platformResetStateToConsistentValues):
607
608         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
609         if specified.
610
611         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
612         (WTR::UIScriptController::isDismissingMenu const):
613
614 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
615
616         Allow sharing from imageSheet on an image document
617         https://bugs.webkit.org/show_bug.cgi?id=196891
618         <rdar://problem/25377386>
619
620         Reviewed by Tim Horton.
621
622         Test to make sure that the correct imageURL is extracted from an image element.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
625         (TestWebKitAPI::TEST):
626
627 2019-04-16  Alex Christensen  <achristensen@webkit.org>
628
629         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
630         https://bugs.webkit.org/show_bug.cgi?id=196995
631
632         Reviewed by Brady Eidson.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
635         (TEST):
636
637 2019-04-16  Chris Dumez  <cdumez@apple.com>
638
639         URL set by document.open() is not communicated to the UIProcess
640         https://bugs.webkit.org/show_bug.cgi?id=196941
641         <rdar://problem/49237544>
642
643         Reviewed by Geoff Garen.
644
645         Add API test coverage.
646
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
649         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
650         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
651         (TEST):
652
653 2019-04-16  Commit Queue  <commit-queue@webkit.org>
654
655         Unreviewed, rolling out r244321.
656         https://bugs.webkit.org/show_bug.cgi?id=196968
657
658         Causing all WK2 Debug builds to exit early after Assertion
659         failures. (Requested by ShawnRoberts on #webkit).
660
661         Reverted changeset:
662
663         "URL set by document.open() is not communicated to the
664         UIProcess"
665         https://bugs.webkit.org/show_bug.cgi?id=196941
666         https://trac.webkit.org/changeset/244321
667
668 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
669
670         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
671         https://bugs.webkit.org/show_bug.cgi?id=196948
672
673         Reviewed by Zalan Bujtas.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
676         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
677
678 2019-04-15  Chris Dumez  <cdumez@apple.com>
679
680         URL set by document.open() is not communicated to the UIProcess
681         https://bugs.webkit.org/show_bug.cgi?id=196941
682         <rdar://problem/49237544>
683
684         Reviewed by Geoffrey Garen.
685
686         Add API test coverage.
687
688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
689         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
690         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
691         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
692         (TEST):
693
694 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
695
696         Using Tools/Scripts/clean-webkit should not install requests
697         https://bugs.webkit.org/show_bug.cgi?id=196940
698
699         Reviewed by Lucas Forschler.
700
701         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
702         existing, depending on the path autoinstalled is run through.
703         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
704         needed.
705         (Port.configuration_for_upload):
706         (Port.commits_for_upload):
707
708 2019-04-15  Alex Christensen  <achristensen@webkit.org>
709
710         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
711         https://bugs.webkit.org/show_bug.cgi?id=196773
712
713         Reviewed by Jer Noble.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
716         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
717         (TEST):
718
719 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
720
721         ews-build should clearly indicate flaky test failures
722         https://bugs.webkit.org/show_bug.cgi?id=196947
723
724         Reviewed by Lucas Forschler.
725
726         * BuildSlaveSupport/ews-build/steps.py:
727         (AnalyzeAPITestsResults.analyzeResults):
728
729 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
730
731         InjectedBundle parameters often need initialization function called before unarchiving
732         https://bugs.webkit.org/show_bug.cgi?id=189709
733         <rdar://problem/44573653>
734
735         Reviewed by Ryosuke Niwa.
736
737         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
738         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
739
740 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
741
742         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
743         https://bugs.webkit.org/show_bug.cgi?id=196681
744
745         Reviewed by Darin Adler.
746
747         Added tests.
748
749         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
750         (WTF_HashSet.RemoveIf):
751         (WTF_HashSet.RemoveIfShrinkToBestSize):
752
753 2019-04-15  John Wilander  <wilander@apple.com>
754
755         Send delayed Ad Click Attribution conversion requests to the click source
756         https://bugs.webkit.org/show_bug.cgi?id=196838
757         <rdar://problem/47650157>
758
759         Reviewed by Chris Dumez and Youenn Fablet.
760
761         This patch adds test infrastructure to override the default behavior in
762         WebKit::NetworkAdClickAttribution.
763
764         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
765         (TestWebKitAPI::TEST):
766         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
767         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
768         (WTR::TestRunner::dumpAdClickAttribution):
769         (WTR::TestRunner::clearAdClickAttribution):
770         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
771         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
773         * WebKitTestRunner/TestController.cpp:
774         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
775         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
776         * WebKitTestRunner/TestController.h:
777         * WebKitTestRunner/TestInvocation.cpp:
778         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
779
780 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
781
782         [ews-app] status-bubble should display position in queue
783         https://bugs.webkit.org/show_bug.cgi?id=196607
784
785         Reviewed by Lucas Forschler.
786
787         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
788         (StatusBubble._build_bubble):
789         (StatusBubble._queue_position): Method to calculate patch's position in queue.
790
791 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
792
793         [ews-build] Do not run clean build by default on EWS builders
794         https://bugs.webkit.org/show_bug.cgi?id=196897
795
796         Reviewed by Lucas Forschler.
797
798         * BuildSlaveSupport/ews-build/steps.py:
799         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
800         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
801         untracked directories like WebKitBuild).
802         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
803         untracked files/directories (like WebKitBuild).
804
805 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
806
807         TestRunner::notifyDone() should be safely reentrant
808         https://bugs.webkit.org/show_bug.cgi?id=196898
809
810         Reviewed by Darin Adler.
811
812         It is currently possible that TestRunner::notifyDone() will call itself, since
813         notifyDone() will force a repaint, which can start executing JavaScript, which
814         may call notifyDone() again. This can lead to test failures and flakiness.
815         Fix this by setting the m_waitToDump flag before calling the dump() method.
816
817         * DumpRenderTree/mac/TestRunnerMac.mm:
818         (TestRunner::notifyDone):
819         (TestRunner::forceImmediateCompletion):
820         * DumpRenderTree/win/TestRunnerWin.cpp:
821         (TestRunner::notifyDone):
822         (TestRunner::forceImmediateCompletion):
823
824 2019-04-15  Philippe Normand  <pnormand@igalia.com>
825
826         [GTK][WPE] Add enable-media websetting
827         https://bugs.webkit.org/show_bug.cgi?id=196863
828
829         Reviewed by Michael Catanzaro.
830
831         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
832         (testWebKitSettings): Add test for the enable-media web-setting.
833
834 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
835
836         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
837         https://bugs.webkit.org/show_bug.cgi?id=196905
838         <rdar://problem/49886096>
839
840         Reviewed by Tim Horton.
841
842         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
843         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
844         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
845         delay timer, we end up with this sequence of events in the problematic (failure) case:
846
847         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
848             ...IPC from UI to web process...
849         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
850             ...IPC from web to UI process...
851         (c) [UI]    Invoke completion handler for script #1
852         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
853             ...IPC from UI to web process...
854         (e) [Web]   Evaluate script #2 in the web process
855         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
856
857         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
858         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
859         #2 is run in step (e).
860
861         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
862         the UI process by waiting on a script message posted by the web process, after attachment updates are
863         dispatched.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
866         (TestWebKitAPI::TEST):
867
868 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
869
870         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
871         https://bugs.webkit.org/show_bug.cgi?id=196909
872
873         Reviewed by Wenson Hsieh.
874
875         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
876         (TestWebKitAPI::TEST):
877
878 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
879
880         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
881         https://bugs.webkit.org/show_bug.cgi?id=196880
882
883         Reviewed by Yusuke Suzuki.
884
885         Add a new function for bytecode cache tests that does not forceDiskCache
886         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
887         test added in this patch, since the code is invalid and therefore won't be
888         cached. It should also be useful for tests that evaluate dynamically
889         generated code.
890
891         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
892         * Scripts/run-jsc-stress-tests:
893
894 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
895
896         Update AudioSession route sharing policy
897         https://bugs.webkit.org/show_bug.cgi?id=196776
898         <rdar://problem/46501611>
899
900         Reviewed by Jer Noble.
901
902         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
903         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
904         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
905         (TestWebKitAPI::TEST):
906
907 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
908
909         [iOS] Software keyboard is shown too frequently on some websites
910         https://bugs.webkit.org/show_bug.cgi?id=195856
911         <rdar://problem/49191395>
912
913         Reviewed by Darin Adler.
914
915         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
916
917         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
918         (WTR::UIScriptController::setHardwareKeyboardAttached):
919         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
920         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
921         (WTR::UIScriptController::setHardwareKeyboardAttached):
922         * TestRunnerShared/UIScriptContext/UIScriptController.h:
923         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
924
925         Additionally link against GraphicsServices in WebKitTestRunner.
926
927         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
928         (WTR::TestController::platformResetStateToConsistentValues):
929         (WTR::UIScriptController::setHardwareKeyboardAttached):
930
931 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
932
933         [GTK][WPE] Fix pacman install-dependencies packages
934         https://bugs.webkit.org/show_bug.cgi?id=196817
935
936         Reviewed by Žan Doberšek.
937         
938         python3-setuptools is called python-setuptools
939         ruby-highline is only available on AUR
940         libv4l-devel is incorporated in v4l-utils
941
942         * gtk/install-dependencies:
943         * wpe/install-dependencies:
944
945 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
946
947         [GTK] REGRESSION(r243860): Many tests failing
948         https://bugs.webkit.org/show_bug.cgi?id=196791
949
950         Reviewed by Joanmarie Diggs.
951
952         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
953         multiple documents and check that accessibility hierarchy is updated after a navigation.
954
955         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
956         (loadChangedCallback):
957         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
958         (AccessibilityTest::AccessibilityTest):
959         (AccessibilityTest::~AccessibilityTest):
960         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
961         (AccessibilityTest::findTestServerApplication):
962         (AccessibilityTest::findDocumentWeb):
963         (AccessibilityTest::findRootObject):
964         (AccessibilityTest::waitUntilChildrenRemoved):
965         (AccessibilityTest::ensureProxy):
966         (testAtspiBasicHierarchy):
967         (beforeAll):
968         (afterAll):
969
970 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
971
972         [ews-build] Handle bug titles with unicode characters
973         https://bugs.webkit.org/show_bug.cgi?id=196802
974
975         Reviewed by Dewei Zhu.
976
977         * BuildSlaveSupport/ews-build/steps.py:
978         (ValidatePatch._is_bug_closed):
979
980 2019-04-11  Michael Saboff  <msaboff@apple.com>
981
982         Improve the Inline Cache Stats code
983         https://bugs.webkit.org/show_bug.cgi?id=196836
984
985         Reviewed by Saam Barati.
986
987         Added a new script to consolidate and arrange the output of --useICStats option.
988
989         This script merges the output from every group into one large table and sorts it from most common to
990         least common.  It also counts the slow path GetById and PutById variants and then calculates the
991         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
992         Put together, this is useful to see what property accesses are not getting cached.
993
994         * Scripts/ic-stats.py: Added.
995         (ICStats):
996         (ICStats.__init__):
997         (ICStats.parse):
998         (ICStats.dumpStats):
999         (usage):
1000
1001 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1002
1003         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1004         https://bugs.webkit.org/show_bug.cgi?id=196809
1005         <rdar://49800762>
1006
1007         Reviewed by Brady Eidson.
1008
1009         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1010         (TEST):
1011
1012 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1013
1014         requestAnimationFrame should execute before the next frame
1015         https://bugs.webkit.org/show_bug.cgi?id=177484
1016
1017         Reviewed by Simon Fraser.
1018
1019         Add trace points for the page RenderingUpdate.
1020
1021         * Tracing/SystemTracePoints.plist:
1022
1023 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1024
1025         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1026         https://bugs.webkit.org/show_bug.cgi?id=196760
1027
1028         Reviewed by Don Olmstead.
1029
1030         vswhere.exe has been bundled since Visual Studio 2017 version
1031         15.2. We shouldn't download vswhere.exe.
1032
1033         * Scripts/build-jsc: Do not call update-vswhere.py.
1034         * Scripts/build-webkit: Ditto.
1035         * Scripts/update-vswhere.py: Removed.
1036         * Scripts/webkitdirs.pm:
1037         (requireModulesForVSWhere): Deleted.
1038         (pickCurrentVisualStudioInstallation): Deleted.
1039         (visualStudioInstallDirVSWhere): Return the latest installed VS
1040         installation path by using the bundled vswhere.exe.
1041         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1042         (visualStudioInstallDirFallback): Removed.
1043
1044 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1045
1046         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1047         https://bugs.webkit.org/show_bug.cgi?id=196780
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         * BuildSlaveSupport/ews-build/steps.py:
1052         * BuildSlaveSupport/ews-build/steps_unittest.py:
1053
1054 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1055
1056         Add SPI WKNavigationResponse._downloadAttribute
1057         https://bugs.webkit.org/show_bug.cgi?id=196755
1058         <rdar://49587365>
1059
1060         Reviewed by Brady Eidson.
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1063         (-[NavigationResponseTestDelegate navigationResponse]):
1064         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1065         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1066         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1067         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1068         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1069         (readRequest):
1070         (writeResponse):
1071         (TEST):
1072
1073 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1074
1075         Add modern API for overriding the page's specified viewport configuration
1076         https://bugs.webkit.org/show_bug.cgi?id=167734
1077         <rdar://problem/30331795>
1078
1079         Reviewed by Simon Fraser.
1080
1081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1082         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1083
1084 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1085
1086         Add support for incremental bytecode cache updates
1087         https://bugs.webkit.org/show_bug.cgi?id=195000
1088
1089         Reviewed by Filip Pizlo.
1090
1091         Exit when the initial run to generate bytecode fails.
1092
1093         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1094
1095 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1096
1097         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1098         https://bugs.webkit.org/show_bug.cgi?id=196744
1099         <rdar://49415309>
1100
1101         Reviewed by Chris Dumez.
1102
1103         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1104         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1105
1106 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1107
1108         Add a way to opt into modern compatibility mode in layout tests
1109         https://bugs.webkit.org/show_bug.cgi?id=196770
1110         <rdar://problem/49777550>
1111
1112         Reviewed by Antoine Quint.
1113
1114         Add a new test option to enable modern compatibility mode in layout tests.
1115
1116         * WebKitTestRunner/TestController.cpp:
1117         (WTR::updateTestOptionsFromTestHeader):
1118         * WebKitTestRunner/TestController.h:
1119         * WebKitTestRunner/TestOptions.h:
1120         (WTR::TestOptions::hasSameInitializationOptions const):
1121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1122         (WTR::TestController::platformCreateWebView):
1123         (WTR::TestController::enableModernCompatibilityMode):
1124
1125 2019-04-10  Andy Estes  <aestes@apple.com>
1126
1127         Try to fix the 32-bit watchOS build.
1128
1129         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1130         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1131
1132 2019-04-10  Antoine Quint  <graouts@apple.com>
1133
1134         Enable Pointer Events on watchOS
1135         https://bugs.webkit.org/show_bug.cgi?id=196771
1136         <rdar://problem/49040909>
1137
1138         Reviewed by Dean Jackson.
1139
1140         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1141
1142 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1143
1144         Unreviewed. Fix WPE accessibility tests after r244059.
1145
1146         We are failing to load the injected bundle due to undefined symbol
1147         AccessibilityUIElement::replaceTextInRange().
1148
1149         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1150         (WTR::AccessibilityUIElement::replaceTextInRange):
1151
1152 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1153
1154         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1155         https://bugs.webkit.org/show_bug.cgi?id=196727
1156
1157         Reviewed by Fujii Hironori.
1158
1159         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1160         (WebKitBrowserWindow::create):
1161
1162 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1163
1164         [ews-build] Add unit tests for PrintConfiguration
1165         https://bugs.webkit.org/show_bug.cgi?id=196752
1166
1167         Reviewed by Dewei Zhu.
1168
1169         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1170
1171 2019-04-09  Keith Rollin  <krollin@apple.com>
1172
1173         Unreviewed build maintenance -- update .xcfilelists.
1174
1175         * DumpRenderTree/DerivedSources-input.xcfilelist:
1176         * DumpRenderTree/DerivedSources-output.xcfilelist:
1177
1178 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1179
1180         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1181         https://bugs.webkit.org/show_bug.cgi?id=196743
1182         <rdar://problem/43897551>
1183
1184         Reviewed by Tim Horton.
1185
1186         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1187         (TEST):
1188
1189 2019-04-09  Youenn Fablet  <youenn@apple.com>
1190
1191         Close service worker database on network process suspension
1192         https://bugs.webkit.org/show_bug.cgi?id=196623
1193         <rdar://problem/48930869>
1194
1195         Reviewed by Alex Christensen.
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1198
1199 2019-04-09  Daniel Bates  <dabates@apple.com>
1200
1201         [iPad] Should open popover when the spacebar is pressed
1202         https://bugs.webkit.org/show_bug.cgi?id=196360
1203         <rdar://problem/49389129>
1204
1205         Reviewed by Brent Fulgham.
1206
1207         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1208
1209         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1210         (WTR::UIScriptController::isShowingPopover const): Added.
1211         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1212         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1213         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1214         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1215         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1216         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1217         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1218         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1219         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1220         (WTR::UIScriptController::isShowingPopover const): Added.
1221         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1222         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1223         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1224         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1225         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1226         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1227         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1228         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1229         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1231         (WTR::UIScriptController::isShowingPopover const): Added.
1232         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1233         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1234
1235 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1236
1237         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1238         https://bugs.webkit.org/show_bug.cgi?id=196665
1239         <rdar://45115669>
1240
1241         Reviewed by Geoff Garen.
1242
1243         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1244         (goBack):
1245         (+[SimpleLookupContext sharedLookupContext]):
1246         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1247         (TEST):
1248         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1249         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1250
1251 2019-04-09  John Wilander  <wilander@apple.com>
1252
1253         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1254         https://bugs.webkit.org/show_bug.cgi?id=196558
1255         <rdar://problem/47650245>
1256
1257         Reviewed by Youenn Fablet.
1258
1259         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1260         (TestWebKitAPI::TEST):
1261             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1262
1263 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1264
1265         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1266         https://bugs.webkit.org/show_bug.cgi?id=196720
1267
1268         Reviewed by Konstantin Tokarev.
1269
1270         * TestWebKitAPI/PlatformMac.cmake:
1271
1272 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1273
1274         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1275         https://bugs.webkit.org/show_bug.cgi?id=196694
1276         <rdar://problem/48388734>
1277
1278         Rubber-stamped by Aakash Jain.
1279
1280         * Scripts/webkitpy/port/image_diff.py:
1281         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1282         * Scripts/webkitpy/port/server_process.py:
1283         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1284         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1285         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1286         * Scripts/webkitpy/port/server_process_mock.py:
1287         (MockServerProcess.has_available_stdout):
1288         * Scripts/webkitpy/port/server_process_unittest.py:
1289         (TestServerProcess.serial_test_basic):
1290
1291 2019-04-09  Jer Noble  <jer.noble@apple.com>
1292
1293         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1294         https://bugs.webkit.org/show_bug.cgi?id=196097
1295
1296         Reviewed by Eric Carlson.
1297
1298         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1299
1300         * DumpRenderTree/mac/DumpRenderTree.mm:
1301         (resetWebPreferencesToConsistentValues):
1302         * WebKitTestRunner/TestController.cpp:
1303         (WTR::TestController::resetPreferencesToConsistentValues):
1304
1305 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1306
1307         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1308         https://bugs.webkit.org/show_bug.cgi?id=196690
1309
1310         Reviewed by Michael Catanzaro.
1311
1312         * QueueStatusServer/config/queues.py:
1313         * Scripts/webkitpy/common/config/ews.json:
1314         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1315         (test_ews_name):
1316
1317 2019-04-09  Chris Dumez  <cdumez@apple.com>
1318
1319         Loads using loadHTMLString() cause flashing when process-swapping
1320         https://bugs.webkit.org/show_bug.cgi?id=196714
1321         <rdar://problem/49637354>
1322
1323         Reviewed by Antti Koivisto.
1324
1325         Add API test coverage.
1326
1327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1328
1329 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1330
1331         Unreviewed. Fix ATK accessibility tests after r244059.
1332
1333         We are failing to load the injected bundle due to undefined symbol
1334         AccessibilityUIElement::replaceTextInRange().
1335
1336         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1337         (WTR::AccessibilityUIElement::replaceTextInRange):
1338
1339 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1340
1341         AX: Support API: accessibilityReplaceRange:withText
1342         https://bugs.webkit.org/show_bug.cgi?id=196636
1343
1344         Unreviewed build fix for Windows port.
1345
1346         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1347         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1348
1349 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1350
1351         [CMake][WinCairo] Separate copied headers into different directories
1352         https://bugs.webkit.org/show_bug.cgi?id=196655
1353
1354         Reviewed by Michael Catanzaro.
1355
1356         * DumpRenderTree/CMakeLists.txt:
1357         * MiniBrowser/win/CMakeLists.txt:
1358         * TestWebKitAPI/CMakeLists.txt:
1359         * TestWebKitAPI/PlatformWin.cmake:
1360
1361 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1362
1363         Log stack-trace for run-webkit-tests when interrupted
1364         https://bugs.webkit.org/show_bug.cgi?id=176393
1365         <rdar://problem/34262310>
1366
1367         Reviewed by Lucas Forschler.
1368
1369         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1370         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1371         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1372         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1373         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1375         (main): Set handlers to log stack trace on interruption.
1376
1377 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1378
1379         AX: Support API: accessibilityReplaceRange:withText
1380         https://bugs.webkit.org/show_bug.cgi?id=196636
1381
1382         Unreviewed build fix for Windows port.
1383
1384         * DumpRenderTree/AccessibilityUIElement.cpp:
1385         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1386
1387 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-build] Scripts using Buildbot API have CORS error
1390         https://bugs.webkit.org/show_bug.cgi?id=196709
1391
1392         Reviewed by Alexey Proskuryakov.
1393
1394         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1395
1396 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1397
1398         AX: Support API: accessibilityReplaceRange:withText
1399         https://bugs.webkit.org/show_bug.cgi?id=196636
1400
1401         Reviewed by Daniel Bates.
1402
1403         * DumpRenderTree/AccessibilityUIElement.cpp:
1404         (replaceTextInRangeCallback):
1405         (AccessibilityUIElement::replaceTextInRange):
1406         (AccessibilityUIElement::getJSClass):
1407         * DumpRenderTree/AccessibilityUIElement.h:
1408         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1409         (AccessibilityUIElement::replaceTextInRange):
1410         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1411         (AccessibilityUIElement::replaceTextInRange):
1412         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1413         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1414         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1415         (WTR::AccessibilityUIElement::replaceTextInRange):
1416         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1417         (WTR::AccessibilityUIElement::replaceTextInRange):
1418
1419 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1420
1421         [iOS] Do not allow starting selection drags when selection views are not visible
1422         https://bugs.webkit.org/show_bug.cgi?id=196686
1423         <rdar://problem/49399192>
1424
1425         Reviewed by Tim Horton.
1426
1427         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1428         also add some new API tests to cover scenarios where the web view is not first responder.
1429
1430         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1431         (TestWebKitAPI::TEST):
1432         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1433
1434         Add a switch to optionally make the web view first responder when starting the simulated drag.
1435
1436         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1437         (-[DragAndDropSimulator initWithWebView:]):
1438         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1439
1440 2019-04-08  Justin Fan  <justin_fan@apple.com>
1441
1442         [Web GPU] Fix Web GPU experimental feature on iOS
1443         https://bugs.webkit.org/show_bug.cgi?id=196632
1444
1445         Reviewed by Myles C. Maxfield.
1446
1447         Properly make Web GPU available on iOS 11+.
1448
1449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1450
1451 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1452
1453         [ews-build] Do not upload archive when Compile Fails
1454         https://bugs.webkit.org/show_bug.cgi?id=196674
1455
1456         Reviewed by Alexey Proskuryakov.
1457
1458         * BuildSlaveSupport/ews-build/factories.py:
1459         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1460         * BuildSlaveSupport/ews-build/steps.py:
1461         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1462         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1463         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1464
1465 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1466
1467         Enable DFG on MIPS
1468         https://bugs.webkit.org/show_bug.cgi?id=196689
1469
1470         Reviewed by Žan Doberšek.
1471
1472         Since the bytecode change, we enabled the baseline JIT on mips in
1473         r240432, but DFG is still missing. With this change, all tests are
1474         passing on a ci20 board.
1475
1476         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1477
1478 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1479
1480         [Flatpak] Second run update-webkitwpe-flatpak fails
1481         https://bugs.webkit.org/show_bug.cgi?id=192702
1482
1483         Reviewed by Carlos Garcia Campos.
1484
1485         * flatpak/flatpakutils.py:
1486         (FlatpakObject.flatpak): Fix typo.
1487         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1488         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1489
1490 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1491
1492         [GTK][WPE] outlook.live.com displays old-fashioned UI
1493         https://bugs.webkit.org/show_bug.cgi?id=196642
1494
1495         Reviewed by Carlos Garcia Campos.
1496
1497         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1498         (TestWebKitAPI::TEST): New Mac platform quirk test.
1499
1500 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1501
1502         Unreviewed, rolling out r243956.
1503         https://bugs.webkit.org/show_bug.cgi?id=196688
1504
1505         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1506         by aakashjain on #webkit).
1507
1508         Reverted changeset:
1509
1510         "Clicking "Go Back" from a safe browsing warning from an
1511         iframe should navigate the WKWebView back to the previous
1512         page"
1513         https://bugs.webkit.org/show_bug.cgi?id=196665
1514         https://trac.webkit.org/changeset/243956
1515
1516 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1517
1518         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1519         https://bugs.webkit.org/show_bug.cgi?id=196669
1520
1521         Reviewed by Geoffrey Garen.
1522
1523         Added three new unit tests for WeakHashSet.
1524
1525         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1526         (WTF_WeakPtr.WeakHashSetConstObjects):
1527         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1528         (WTF_WeakPtr.WeakHashSetComputeSize):
1529
1530 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1531
1532         Hide next and previous form control buttons when WKWebView is editable
1533         https://bugs.webkit.org/show_bug.cgi?id=196672
1534         <rdar://problem/35625321>
1535
1536         Reviewed by Tim Horton.
1537
1538         Add a new API test.
1539
1540         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1541         (-[TestWKWebView lastTrailingBarButtonGroup]):
1542         (TestWebKitAPI::TEST):
1543         * TestWebKitAPI/ios/UIKitSPI.h:
1544
1545 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1546
1547         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1548         https://bugs.webkit.org/show_bug.cgi?id=196077
1549         <rdar://problem/49108202>
1550
1551         Reviewed by Chris Dumez.
1552
1553         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1554         on new web view.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1557
1558 2019-04-05  Saam Barati  <sbarati@apple.com>
1559
1560         Make compare-results understand MotionMark
1561         https://bugs.webkit.org/show_bug.cgi?id=196666
1562
1563         Reviewed by Yusuke Suzuki.
1564
1565         * Scripts/compare-results:
1566         (PLT5Results):
1567         (detectMotionMark):
1568         (detectMotionMark1_1):
1569         (motionMarkResults):
1570         (motionMark1_1Results):
1571         (detectBenchmark):
1572         (biggerIsBetter):
1573         (main):
1574
1575 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1576
1577         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1578         https://bugs.webkit.org/show_bug.cgi?id=196665
1579         <rdar://45115669>
1580
1581         Reviewed by Geoff Garen.
1582
1583         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1584         (goBack):
1585         (+[SimpleLookupContext sharedLookupContext]):
1586         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1587         (TEST):
1588         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1589         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1590
1591 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-build] Add configuration and architecture for windows builders
1594         https://bugs.webkit.org/show_bug.cgi?id=196660
1595
1596         Reviewed by Lucas Forschler.
1597
1598         * BuildSlaveSupport/ews-build/config.json:
1599
1600 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1601
1602         webkitpy: Don't run subsequent rounds if interrupted
1603         https://bugs.webkit.org/show_bug.cgi?id=196646
1604
1605         Reviewed by Aakash Jain.
1606
1607         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1608         (Manager.run): Bail out if interrupted.
1609
1610 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1611
1612         Test sessionStorage in PSON private browsing mode
1613         https://bugs.webkit.org/show_bug.cgi?id=196561
1614
1615         Reviewed by Alex Christensen.
1616
1617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1618
1619 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1620
1621         Unreviewed, rolling out r243833.
1622         https://bugs.webkit.org/show_bug.cgi?id=196645
1623
1624         This change breaks build of WPE and GTK ports (Requested by
1625         annulen on #webkit).
1626
1627         Reverted changeset:
1628
1629         "[CMake][WTF] Mirror XCode header directories"
1630         https://bugs.webkit.org/show_bug.cgi?id=191662
1631         https://trac.webkit.org/changeset/243833
1632
1633 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1634
1635         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1636         https://bugs.webkit.org/show_bug.cgi?id=196635
1637
1638         Reviewed by Antti Koivisto.
1639         
1640         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1641         for a test to enable async frame scrolling via:
1642             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1643         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1644         
1645         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1646
1647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1648         (WTR::InjectedBundle::beginTesting):
1649         * WebKitTestRunner/TestController.cpp:
1650         (WTR::TestController::resetPreferencesToConsistentValues):
1651
1652 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1653
1654         Use a correct LC_RPATH when building with ASan
1655         https://bugs.webkit.org/show_bug.cgi?id=196576
1656
1657         Reviewed by David Kilzer.
1658
1659         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1660         so that ../Frameworks is checked. This is simpler and more reliable than updating
1661         each SPC service xcconfig.
1662
1663 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1664
1665         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1666         https://bugs.webkit.org/show_bug.cgi?id=196629
1667
1668         Reviewed by Lucas Forschler.
1669
1670         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1671
1672 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1673
1674         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1675         https://bugs.webkit.org/show_bug.cgi?id=196618
1676
1677         Reviewed by Lucas Forschler.
1678
1679         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1680         (StatusBubble): Added QUEUE_TRIGGERS.
1681         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1682         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1683         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1684         its parent(builder).
1685
1686 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1687
1688         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1689         https://bugs.webkit.org/show_bug.cgi?id=196625
1690
1691         Reviewed by Lucas Forschler.
1692
1693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1694         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1695
1696 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1697
1698         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1699         https://bugs.webkit.org/show_bug.cgi?id=196630
1700
1701         Reviewed by Wenson Hsieh.
1702
1703         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1704
1705 2019-04-04  Youenn Fablet  <youenn@apple.com>
1706
1707         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1708         https://bugs.webkit.org/show_bug.cgi?id=196543
1709
1710         Reviewed by Alex Christensen.
1711
1712         * WebKitTestRunner/TestController.cpp:
1713         (WTR::TestController::generatePageConfiguration):
1714
1715 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1716
1717         [ews-app] Status bubble should not display skipped buildbot steps
1718         https://bugs.webkit.org/show_bug.cgi?id=196584
1719
1720         Reviewed by Lucas Forschler.
1721
1722         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1723
1724 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1725
1726         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1727         https://bugs.webkit.org/show_bug.cgi?id=196620
1728
1729         Reviewed by Lucas Forschler.
1730
1731         * BuildSlaveSupport/ews-app/ews/config.py:
1732
1733 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1734
1735         [Win] DumpRenderTreeWatchDog.py is not checked into source
1736         https://bugs.webkit.org/show_bug.cgi?id=196567
1737         <rdar://problem/49525901>
1738
1739         Reviewed by Lucas Forschler.
1740
1741         This script is used on Win EWS bots to terminate hanging DRT processes.
1742
1743         * EWSTools/dumprendertreewatchdog.py: Added.
1744
1745 2019-04-04  Chris Dumez  <cdumez@apple.com>
1746
1747         Unreviewed, roll out r243858 which made tests time out.
1748
1749         Disable new API tests on Windows instead.
1750
1751         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1752         (TestWebKitAPI::TEST):
1753
1754 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1755
1756         [ATK] Cleanup WebPageAccessibilityObjectAtk
1757         https://bugs.webkit.org/show_bug.cgi?id=196537
1758
1759         Reviewed by Michael Catanzaro.
1760
1761         Also consider files under atk directories as exceptions for GObject conventions.
1762
1763         * Scripts/webkitpy/style/checkers/cpp.py:
1764         (check_identifier_name_in_declaration):
1765
1766 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1767
1768         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1769         https://bugs.webkit.org/show_bug.cgi?id=196588
1770         <rdar://problem/49365787>
1771
1772         Unreviewed build fix for Windows port.
1773
1774         error C3861: 'kill': identifier not found
1775
1776         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1777         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1778
1779 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-build] Cancel build and similar operations should have authentication
1782         https://bugs.webkit.org/show_bug.cgi?id=196520
1783
1784         Reviewed by Dewei Zhu.
1785
1786         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1787         environment variables.
1788
1789 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1790
1791         [ews-build] Do not trigger queues which are not in production yet
1792         https://bugs.webkit.org/show_bug.cgi?id=196581
1793
1794         Reviewed by Dewei Zhu.
1795
1796         * BuildSlaveSupport/ews-build/config.json:
1797
1798 2019-04-03  Chris Dumez  <cdumez@apple.com>
1799
1800         Unreviewed, fix typo in the name of API test added in r243848.
1801
1802         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1803         (TestWebKitAPI::TEST):
1804
1805 2019-04-03  Chris Dumez  <cdumez@apple.com>
1806
1807         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1808         https://bugs.webkit.org/show_bug.cgi?id=196588
1809         <rdar://problem/49365787>
1810
1811         Reviewed by Ryosuke Niwa.
1812
1813         Add API test coverage.
1814
1815         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1816         (TestWebKitAPI::nullJavaScriptCallback):
1817         (TestWebKitAPI::didCrashCheckFrames):
1818         (TestWebKitAPI::TEST):
1819
1820 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1821
1822         run-webkit-tests: Upload test results (new results database)
1823         https://bugs.webkit.org/show_bug.cgi?id=196577
1824         <rdar://problem/34841155>
1825
1826         Reviewed by Lucas Forschler.
1827
1828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1829         (Manager.run): Upload results after each device shard, since the configuration will be
1830         different for each device.
1831         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1832         uploaded to a results database.
1833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1834         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1835
1836 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1837
1838         -apple-trailing-word is needed for browser detection
1839         https://bugs.webkit.org/show_bug.cgi?id=196575
1840
1841         Unreviewed.
1842
1843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1844
1845 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1846
1847         [CMake][WTF] Mirror XCode header directories
1848         https://bugs.webkit.org/show_bug.cgi?id=191662
1849
1850         Reviewed by Konstantin Tokarev.
1851
1852         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1853         builds.
1854
1855         * CMakeLists.txt:
1856         * DumpRenderTree/CMakeLists.txt:
1857         * DumpRenderTree/PlatformWin.cmake:
1858         * MiniBrowser/win/CMakeLists.txt:
1859         * TestWebKitAPI/CMakeLists.txt:
1860         * TestWebKitAPI/PlatformWin.cmake:
1861         * WebKitTestRunner/PlatformGTK.cmake:
1862         * WebKitTestRunner/PlatformWin.cmake:
1863
1864 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1865
1866         [ews-app] Status bubble should not display certain infrastructure status messages
1867         https://bugs.webkit.org/show_bug.cgi?id=196550
1868
1869         Reviewed by Lucas Forschler.
1870
1871         Do not display the steps which are un-needed for end-user. This information is still avaiable
1872         if the user click on the bubble and look at the Buildbot build.
1873         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1874         (StatusBubble._steps_messages):
1875         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1876
1877 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1878
1879         [ews-build] Use https for sending data to ews-app
1880         https://bugs.webkit.org/show_bug.cgi?id=196492
1881
1882         Reviewed by Lucas Forschler.
1883
1884         * BuildSlaveSupport/ews-build/events.py:
1885
1886 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1887
1888         Remove support for -apple-trailing-word
1889         https://bugs.webkit.org/show_bug.cgi?id=196525
1890
1891         Reviewed by Zalan Bujtas.
1892
1893         This CSS property is nonstandard and not used.
1894
1895         * Scripts/webkitperl/FeatureList.pm:
1896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1897
1898 2019-04-03  Youenn Fablet  <youenn@apple.com>
1899
1900         Add a test for DOMCache on multiple browsing in case of private browsing
1901         https://bugs.webkit.org/show_bug.cgi?id=196524
1902
1903         Reviewed by Alex Christensen.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1906         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1907
1908 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1909
1910         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1911         https://bugs.webkit.org/show_bug.cgi?id=196540
1912
1913         Reviewed by Aakash Jain.
1914
1915         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1916
1917 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1918
1919         Add plumbing for a compatibility mode preference in WebKit
1920         https://bugs.webkit.org/show_bug.cgi?id=196005
1921
1922         Reviewed by Tim Horton.
1923
1924         Add new API tests.
1925
1926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1927         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1928
1929 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1930
1931         [WPE][GTK] Update libsrtp dependency package for Debian
1932         https://bugs.webkit.org/show_bug.cgi?id=196528
1933
1934         Reviewed by Frédéric Wang.
1935
1936         * gtk/install-dependencies:
1937         * wpe/install-dependencies:
1938
1939 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1940
1941         [WK2] Add support for Window's beforeprint / afterprint events
1942         https://bugs.webkit.org/show_bug.cgi?id=196478
1943         <rdar://problem/49535124>
1944
1945         Unreviewed build fix for MSVC.
1946
1947         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1948
1949         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1950
1951         * WebKitTestRunner/TestController.cpp:
1952         (WTR::printFrame): Use int and float literals.
1953
1954 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1955
1956         [ews-build] Reassign bots to queues
1957
1958         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1959
1960 2019-04-02  Chris Dumez  <cdumez@apple.com>
1961
1962         [WK2] Add support for Window's beforeprint / afterprint events
1963         https://bugs.webkit.org/show_bug.cgi?id=196478
1964
1965         Reviewed by Alex Christensen.
1966
1967         Add minimal implementation for printFrame in WebKitTestRunner.
1968
1969         * WebKitTestRunner/TestController.cpp:
1970         (WTR::printFrame):
1971         (WTR::TestController::createOtherPage):
1972         (WTR::TestController::createWebViewWithOptions):
1973
1974 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1975
1976         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1977         https://bugs.webkit.org/show_bug.cgi?id=196491
1978
1979         Reviewed by Lucas Forschler.
1980
1981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1982
1983 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1984
1985         [ews-build] Configure buildbot try credentials in environment variables
1986         https://bugs.webkit.org/show_bug.cgi?id=196501
1987
1988         Reviewed by Lucas Forschler.
1989
1990         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1991         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1992         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1993
1994 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1995
1996         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1997         https://bugs.webkit.org/show_bug.cgi?id=196496
1998         <rdar://problem/49521634>
1999
2000         Reviewed by Chris Dumez.
2001
2002         Add new API tests (see WebKit ChangeLog for more detail).
2003
2004         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2005         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2006         (TEST):
2007
2008 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2009
2010         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2011         <https://webkit.org/b/196499>
2012
2013         Reviewed by Alexey Proskuryakov.
2014
2015         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2016         ENABLE_ADDRESS_SANITIZER.
2017
2018 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2019
2020         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2021         https://bugs.webkit.org/show_bug.cgi?id=182757
2022
2023         Reviewed by Don Olmstead.
2024
2025         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2026         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2027
2028 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2029
2030         run-api-tests: Upload test results
2031         https://bugs.webkit.org/show_bug.cgi?id=196323
2032         <rdar://problem/49356714>
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * Scripts/webkitpy/api_tests/manager.py:
2037         (Manager):
2038         (Manager.run): Upload results to a results database.
2039         * Scripts/webkitpy/api_tests/run_api_tests.py:
2040         (parse_args): Add upload arguments.
2041         * Scripts/webkitpy/port/base.py:
2042         (Port):
2043         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2044         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2045         with commits from any other associated repositories.
2046         * Scripts/webkitpy/port/device.py:
2047         (Device):
2048         (Device.build_version): Access build_versoin of underlying platform device.
2049         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2050         (IOSSimulatorTest):
2051         (IOSSimulatorTest.test_configuration_for_upload):
2052         * Scripts/webkitpy/port/device_port.py:
2053         (DevicePort):
2054         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2055         the same as the machine uploading results.
2056         * Scripts/webkitpy/port/mac.py:
2057         (MacPort):
2058         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2059         * Scripts/webkitpy/port/mac_unittest.py:
2060         (MacTest):
2061         (MacTest.test_configuration_for_upload):
2062         * Scripts/webkitpy/xcode/simulated_device.py:
2063         (SimulatedDeviceManager._create_device_with_runtime):
2064         (SimulatedDevice.__init__): Create simulated device with a build_version.
2065         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2066         (test_existing_simulator):
2067
2068 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2069
2070         Remove extra newline characters (Follow-up fix to r243707)
2071
2072         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2073
2074 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2075
2076         [ews-app] Use API_KEY to accept results data
2077         https://bugs.webkit.org/show_bug.cgi?id=196461
2078
2079         Reviewed by Dewei Zhu.
2080
2081         * BuildSlaveSupport/ews-app/ews/views/results.py:
2082         (Results.post): Validate EWS_API_KEY before accepting any data.
2083         * BuildSlaveSupport/ews-build/events.py:
2084         (Events.sendData): Send EWS_API_KEY if available along with event data.
2085
2086 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2087
2088         Unable to copy and paste a PDF from Notes into Mail compose body
2089         https://bugs.webkit.org/show_bug.cgi?id=196442
2090         <rdar://problem/48573098>
2091
2092         Reviewed by Tim Horton.
2093
2094         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2095         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2096         to be specified on the item providers.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2099         (TestWebKitAPI::mapItemForTesting):
2100         (TestWebKitAPI::contactItemForTesting):
2101
2102 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2103
2104         Make UIWKDocumentContext rects per-character instead of per-word
2105         https://bugs.webkit.org/show_bug.cgi?id=196459
2106
2107         Reviewed by Wenson Hsieh.
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2110         (TEST):
2111         Adjust test results due to switching to per-character rects.
2112
2113 2019-04-01  Chris Dumez  <cdumez@apple.com>
2114
2115         UIProcess crash when a prewarmed process is terminated
2116         https://bugs.webkit.org/show_bug.cgi?id=196451
2117         <rdar://problem/49245471>
2118
2119         Reviewed by Geoffrey Garen.
2120
2121         Add API test coverage.
2122
2123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2124         (TEST):
2125
2126 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2127
2128         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2129         https://bugs.webkit.org/show_bug.cgi?id=196449
2130
2131         Reviewed by Lucas Forschler.
2132
2133         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2134         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2135         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2136         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2137
2138 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2141         https://bugs.webkit.org/show_bug.cgi?id=196444
2142
2143         Reviewed by Lucas Forschler.
2144
2145         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2146
2147 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2148
2149         Add SPI to canonicalize NSURLs with WTF::URL
2150         https://bugs.webkit.org/show_bug.cgi?id=196415
2151         <rdar://problem/44980271>
2152
2153         Reviewed by Darin Adler.
2154
2155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2156         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2157         (TestWebKitAPI::TEST):
2158
2159 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2160
2161         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2162         https://bugs.webkit.org/show_bug.cgi?id=196441
2163
2164         Reviewed by Carlos Garcia Campos.
2165
2166         Don't cache the wpe_view_backend object that might not exist yet at the
2167         time of EventSenderProxy constructor invocation, but instead retrieve
2168         that object whenever it's required for event dispatching. This should
2169         avoid crashes in this constructor now that it's invoked before any
2170         PlatformWindow has been set up (as changed in r243496).
2171
2172         * WebKitTestRunner/EventSenderProxy.h:
2173         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2174         (WTR::viewBackend):
2175         (WTR::EventSenderProxy::EventSenderProxy):
2176         (WTR::EventSenderProxy::mouseDown):
2177         (WTR::EventSenderProxy::mouseUp):
2178         (WTR::EventSenderProxy::mouseMoveTo):
2179         (WTR::EventSenderProxy::mouseScrollBy):
2180         (WTR::EventSenderProxy::keyDown):
2181         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2182
2183 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2184
2185         [Win][WebKit] MiniBrowser should support high DPI display
2186         https://bugs.webkit.org/show_bug.cgi?id=196391
2187
2188         Reviewed by Alex Christensen.
2189
2190         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2191         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2192         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2193         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2194
2195 2019-03-31  Sam Weinig  <weinig@apple.com>
2196
2197         Remove more i386 specific configurations
2198         https://bugs.webkit.org/show_bug.cgi?id=196430
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2203         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2204
2205 2019-03-31  Andy Estes  <aestes@apple.com>
2206
2207         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2208         https://bugs.webkit.org/show_bug.cgi?id=196433
2209         <rdar://problem/49293305>
2210
2211         Reviewed by Tim Horton.
2212
2213         Enhanced API test coverage to include all navigation response policy decisions in both
2214         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2215
2216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2217         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2218         (TestWebKitAPI::TEST):
2219         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2220         (readFile):
2221         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2222         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2223         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2224         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2225         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2226         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2227         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2228         (-[QuickLookDelegate _downloadDidStart:]):
2229         (-[QuickLookDelegate _download:didReceiveResponse:]):
2230         (-[QuickLookDelegate _download:didReceiveData:]):
2231         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2232         (-[QuickLookDelegate _downloadDidFinish:]):
2233         (-[QuickLookDelegate _download:didFailWithError:]):
2234         (-[QuickLookDelegate _downloadDidCancel:]):
2235         (-[QuickLookDelegate verifyDownload]):
2236         (runTest):
2237         (runTestDecideBeforeLoading):
2238         (runTestDecideAfterLoading):
2239         (TEST):
2240         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2241         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2242         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2243         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2244         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2245         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2246         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2247         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2248         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2249         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2250         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2251         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2252         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2253         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2254
2255 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2256
2257         [CMake] add testdfg as target with build-jsc
2258         https://bugs.webkit.org/show_bug.cgi?id=196393
2259
2260         Reviewed by Saam Barati.
2261
2262         Added testdfg as one of the targets to build when
2263         using CMake.
2264
2265         * Scripts/build-jsc:
2266
2267 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2268
2269         Delete WebMetal implementation in favor of WebGPU
2270         https://bugs.webkit.org/show_bug.cgi?id=195418
2271
2272         Reviewed by Dean Jackson.
2273
2274         * DumpRenderTree/mac/DumpRenderTree.mm:
2275         (enableExperimentalFeatures):
2276         (resetWebPreferencesToConsistentValues):
2277         * Scripts/webkitperl/FeatureList.pm:
2278         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2280         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2281         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2282         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2283         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2284         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2285         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2286         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2288         (WTR::InjectedBundle::beginTesting):
2289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2290         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2291         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2292
2293 2019-03-29  Chris Dumez  <cdumez@apple.com>
2294
2295         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2296         https://bugs.webkit.org/show_bug.cgi?id=196405
2297         <rdar://problem/49428130>
2298
2299         Reviewed by Wenson Hsieh.
2300
2301         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2302         the popover presentation methods to be no-ops. Use this in the new test added in
2303         r243523 so that we do not swizzle those methods for all tests. This is needed because
2304         those WatchOS tests rely on the popover getting presented and interactive.
2305
2306         * WebKitTestRunner/TestController.cpp:
2307         (WTR::updateTestOptionsFromTestHeader):
2308         * WebKitTestRunner/TestController.h:
2309         * WebKitTestRunner/TestOptions.h:
2310         (WTR::TestOptions::hasSameInitializationOptions const):
2311         * WebKitTestRunner/ios/TestControllerIOS.mm:
2312         (WTR::TestController::platformInitialize):
2313         (WTR::TestController::platformResetStateToConsistentValues):
2314
2315 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2316
2317         [Curl] Add Server Trust Evaluation Support.
2318         https://bugs.webkit.org/show_bug.cgi?id=191646
2319
2320         Reviewed by Fujii Hironori.
2321
2322         Implemented MiniBrowser UI for asking if user trusts the server.
2323
2324         * MiniBrowser/win/Common.cpp:
2325         (askServerTrustEvaluation):
2326         (replaceString):
2327         * MiniBrowser/win/Common.h:
2328         * MiniBrowser/win/MiniBrowserLib.rc:
2329         * MiniBrowser/win/MiniBrowserLibResource.h:
2330         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2331         (createPEMString):
2332         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2333         (WebKitBrowserWindow::canTrustServerCertificate):
2334         * MiniBrowser/win/WebKitBrowserWindow.h:
2335
2336 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2337
2338         Implement ResizeObserver.
2339         https://bugs.webkit.org/show_bug.cgi?id=157743
2340
2341         Reviewed by Simon Fraser.
2342
2343         Support resizeObserverEnabled webPreferences.
2344
2345         * DumpRenderTree/TestOptions.cpp:
2346         (TestOptions::TestOptions):
2347         * DumpRenderTree/TestOptions.h:
2348         * DumpRenderTree/mac/DumpRenderTree.mm:
2349         (setWebPreferencesForTestOptions):
2350         * DumpRenderTree/win/DumpRenderTree.cpp:
2351         (enableExperimentalFeatures):
2352         * Scripts/webkitperl/FeatureList.pm:
2353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2354
2355 2019-03-28  John Wilander  <wilander@apple.com>
2356
2357         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2358         https://bugs.webkit.org/show_bug.cgi?id=196281
2359         <rdar://problem/48938748>
2360
2361         Reviewed by Alex Christensen.
2362
2363         This patch adds the function isStatisticsHasLocalStorage() to the
2364         TestRunner. With it, the page can query the WebsiteDataStore in the
2365         UI process to make sure that it sees LocalStorage.
2366
2367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2369         (WTR::TestRunner::isStatisticsHasLocalStorage):
2370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2371         * WebKitTestRunner/TestController.cpp:
2372         (WTR::TestController::isStatisticsHasLocalStorage):
2373         * WebKitTestRunner/TestController.h:
2374         * WebKitTestRunner/TestInvocation.cpp:
2375         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2376
2377 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2378
2379         API::Data::createWithoutCopying should do a null check before calling CFRelease
2380         https://bugs.webkit.org/show_bug.cgi?id=196276
2381         <rdar://problem/48059859>
2382
2383         Reviewed by Alex Christensen.
2384
2385         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2389         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2390         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2391         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2392         (TestWebKitAPI::TEST):
2393
2394 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2395
2396         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2397         https://bugs.webkit.org/show_bug.cgi?id=186276
2398
2399         Reviewed by Carlos Garcia Campos.
2400
2401         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2402         (webViewLoadChanged):
2403         (testWebResourceGetDataError):
2404         (testWebResourceGetDataEmpty):
2405         (beforeAll):
2406         (webViewloadChanged): Deleted.
2407
2408 2019-03-27  Andy Estes  <aestes@apple.com>
2409
2410         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2411         https://bugs.webkit.org/show_bug.cgi?id=196317
2412
2413         Reviewed by Dan Bernstein.
2414
2415         package-root copies built products into a staging directory using ditto(1), which does not
2416         follow symbolic links as it traverses a directory. Now that the files in
2417         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2418         itself, these become broken links when ditto'd into the staging directory.
2419
2420         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2421
2422         * Scripts/package-root:
2423
2424 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2425
2426         [ews-app] Update display text of Submit for ews analysis
2427         https://bugs.webkit.org/show_bug.cgi?id=196309
2428
2429         Reviewed by Dewei Zhu.
2430
2431         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2432
2433 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2434
2435         run-webkit-tests should check for leaks in WebKit processes
2436         <https://webkit.org/b/193772>
2437         <rdar://problem/46526680>
2438
2439         Reviewed by Ryosuke Niwa.
2440
2441         This works by doing the following:
2442         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2443           The list of child processes are returned one per line:
2444           process.name: pid
2445         - Run the "#LIST CHILD PROCESSES" command just before the
2446           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2447           processes on the ServerProcess object.
2448         - When the `--leaks` switch is handled, run check_for_leaks() on
2449           each child process after the main test harness.
2450
2451         * DumpRenderTree/mac/DumpRenderTree.mm:
2452         (handleControlCommand):
2453         - Use strncmp() instead of strcmp().
2454         - Add support for handling "#LIST CHILD PROCESSES" command.
2455
2456         * Scripts/webkitpy/port/base.py:
2457         (Port.check_for_leaks):
2458         * Scripts/webkitpy/port/darwin.py:
2459         (DarwinPort.check_for_leaks):
2460         - Rename redundant 'process_pid' argument to 'process_id'.
2461
2462         * Scripts/webkitpy/port/driver.py:
2463         (Driver.do_post_tests_work):
2464         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2465           longer the only command this sends to WebKitTestRunner.
2466         - If the `--leaks` switch is present, send the
2467           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2468           result using Port.set_webkit_processes().
2469         (Driver._parse_child_processes_output):
2470         - Add helper method to parse list of child process names and
2471           process IDs returned from WebKitTestRunner.
2472
2473         * Scripts/webkitpy/port/ios_device.py:
2474         (IOSDevicePort.check_for_leaks):
2475         - Rename redundant 'process_pid' argument to 'process_id'.
2476
2477         * Scripts/webkitpy/port/leakdetector.py:
2478         (LeakDetector._parse_leaks_output):
2479         - Return early if there is no leaks_output.
2480         (LeakDetector.check_for_leaks):
2481         - Rename redundant 'process_pid' argument to 'process_id'.
2482
2483         * Scripts/webkitpy/port/server_process.py:
2484         (ServerProcess.__init__):
2485         (ServerProcess.child_processes):
2486         (ServerProcess.set_child_processes):
2487         - Add instance variable to Port to store list of child process
2488           names and process IDs returned from WebKitTestRunner.
2489         (ServerProcess._start):
2490         - Clear self._child_processes.
2491         (ServerProcess.stop):
2492         - If self._child_processes is set, call
2493           self._port.check_for_leaks() for each child process.
2494
2495         * Scripts/webkitpy/port/server_process_unittest.py:
2496         (TrivialMockPort.check_for_leaks):
2497         - Rename redundant 'process_pid' argument to 'process_id'.
2498
2499         * Scripts/webkitpy/port/simulator_process.py:
2500         (SimulatorProcess.stop):
2501         - If self._child_processes is set, call
2502           self._port.check_for_leaks() for each child process.
2503
2504         * Scripts/webkitpy/port/watch_device.py:
2505         (WatchDevicePort.check_for_leaks):
2506         - Rename redundant 'process_pid' argument to 'process_id'.
2507
2508         * WebKitTestRunner/TestController.cpp:
2509         (WTR::TestController::dumpResponse):
2510         - Extract method from findAndDumpWorldLeaks() so that it may be
2511           reused by findAndDumpWebKitProcessIdentifiers().
2512         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2513         - Add method to output process name and process ID of both the
2514           WebContent and Networking processes.
2515         (WTR::TestController::findAndDumpWorldLeaks):
2516         - Fix missing newline in output when there were no abandoned
2517           documents.
2518         - Call dumpResponse() for extracted code.
2519         (WTR::TestController::handleControlCommand):
2520         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2521         - Use strncmp() instead of strcmp().
2522         - Call findAndDumpWebKitProcessIdentifiers() when
2523           "#LIST CHILD PROCESSES" command is sent.
2524         * WebKitTestRunner/TestController.h:
2525         (WTR::TestController::dumpResponse):
2526         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2527         - Declare methods.
2528
2529 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2530
2531         Unreviewed. Add GLib API test cases after r243434.
2532
2533         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2534         (testWebViewActiveURI):
2535         (serverCallback):
2536         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2537         (sendRequestCallback):
2538
2539 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2540
2541         Geolocation request not complete when watch request was started in a different web process
2542         https://bugs.webkit.org/show_bug.cgi?id=195996
2543
2544         Reviewed by Alex Christensen.
2545
2546         Add a test case.
2547
2548         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2549         (TestWebKitAPI::runJavaScriptAlert):
2550         (TestWebKitAPI::TEST):
2551
2552 2019-03-26  Keith Rollin  <krollin@apple.com>
2553
2554         Update the way generate-xcfilelists returns strings from functions
2555         https://bugs.webkit.org/show_bug.cgi?id=195975
2556         <rdar://problem/49040807>
2557
2558         Reviewed by Dean Jackson.
2559
2560         There are places where generate-xcfilelists executes assignments with
2561         statements like:
2562
2563             FOO=$(some_function)
2564
2565         where "some_function" return a string by echoing it. E.g.
2566
2567             some_function()
2568             {
2569                 echo "Hello, World"
2570             }
2571
2572         This is a common idiom, but it has a problem if "some_function" needs
2573         to call "exit" in an attempt to halt the entire script right then and
2574         there. Since "some_function" is called inside of $(), it's being
2575         executed in a sub-shell. Calling exit in that sub-shell simply exits
2576         that shell; it doesn't not exit the outer shell in which the main part
2577         of the script is still running. As such, the main script keeps
2578         executing when the intent was for the script to halt.
2579
2580         The solution to this is to use a different idiom for returning
2581         strings. The one we now is to pass in the name of the variable to
2582         receive the string result:
2583
2584             some_function()
2585             {
2586                 variable_name=$1
2587                 eval $variable_name ="Hello, World"
2588             }
2589
2590         The call site now looks like
2591
2592             some_function FOO
2593
2594         Because there's no invocation of a sub-shell, some_function can now
2595         call "exit" if it wants to, and the entire script will exit at that
2596         point.
2597
2598         * Scripts/generate-xcfilelists:
2599
2600 2019-03-26  Chris Dumez  <cdumez@apple.com>
2601
2602         Add basic layout test coverage for File Picker on iOS
2603         https://bugs.webkit.org/show_bug.cgi?id=196265
2604
2605         Reviewed by Wenson Hsieh.
2606
2607         Add layout test infrastructure to test the file picker on iOS.
2608
2609         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2610         (WTR::UIScriptController::dismissFilePicker):
2611         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2612         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2613         (WTR::UIScriptController::dismissFilePicker):
2614         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::createWebViewWithOptions):
2617         (WTR::updateTestOptionsFromTestHeader):
2618         * WebKitTestRunner/TestOptions.h:
2619         (WTR::TestOptions::hasSameInitializationOptions const):
2620         * WebKitTestRunner/ios/TestControllerIOS.mm:
2621         (overridePresentViewController):
2622         (WTR::TestController::platformInitialize):
2623         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2624         (WTR::UIScriptController::dismissFilePicker):
2625
2626 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2627
2628         Implement async paste method on UIWKInteractionViewProtocol
2629         https://bugs.webkit.org/show_bug.cgi?id=196267
2630         <rdar://problem/49236346>
2631
2632         Reviewed by Tim Horton.
2633
2634         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2635         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2636         are now a part of all iOS 12 internal SDKs.
2637
2638         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2639
2640         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2641         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2642
2643         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2644         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2645         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2646         * TestWebKitAPI/ios/UIKitSPI.h:
2647
2648 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-build] Use PostgreSQL for ews.webkit.org database
2651         https://bugs.webkit.org/show_bug.cgi?id=196270
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2656
2657 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2658
2659         [ews] Reset simctl states on reboot
2660         https://bugs.webkit.org/show_bug.cgi?id=196260
2661
2662         Rubber-stamped by Aakash Jain.
2663
2664         * EWSTools/start-queue-mac.sh:
2665
2666 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-build] Use PostgreSQL for ews-build database
2669         https://bugs.webkit.org/show_bug.cgi?id=196229
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-build/master.cfg:
2674
2675 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2676
2677         [ews-build] Get master_hostname dynamically in master.cfg
2678         https://bugs.webkit.org/show_bug.cgi?id=196255
2679
2680         Reviewed by Lucas Forschler.
2681
2682         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2683         send events data in test mode.
2684
2685 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2686
2687         [ews-app] Set db_constraint to False for Foreign Keys
2688         https://bugs.webkit.org/show_bug.cgi?id=196252
2689
2690         Reviewed by Lucas Forschler.
2691
2692         * BuildSlaveSupport/ews-app/ews/models/build.py:
2693         * BuildSlaveSupport/ews-app/ews/models/step.py:
2694
2695 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2696
2697         [ews-build] is_test_mode_enabled should default to True
2698         https://bugs.webkit.org/show_bug.cgi?id=196248
2699
2700         Reviewed by Lucas Forschler.
2701
2702         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2703
2704 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2705
2706         [ews-app] Add webkitperl to ENABLED_QUEUES
2707         https://bugs.webkit.org/show_bug.cgi?id=196253
2708
2709         Reviewed by Lucas Forschler.
2710
2711         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2712
2713 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2714
2715         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2716         https://bugs.webkit.org/show_bug.cgi?id=196211
2717         rdar://problem/49110552
2718
2719         Reviewed by Tim Horton.
2720
2721         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2722         Make sure that EventSenderProxy always exists when running tests. We used to create
2723         it when resetting before the first test, which is a bit too late.
2724
2725         * WebKitTestRunner/TestController.h:
2726         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2727         (WTR::TestController::platformCreateWebView):
2728         (WTR::TestController::platformCreateOtherPage):
2729         (WTR::TestController::finishCreatingPlatformWebView):
2730         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2731         (WTR::PlatformWebView::PlatformWebView):
2732         Moved some code that made NSWindow use NSEvent during web view creation. We may
2733         need to move more if some other case us found, but this is enough for now.
2734
2735 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2736
2737         Unreviewed. Fix typo in GLib geolocation API after r243285.
2738
2739         gelocation -> geolocation.
2740
2741         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2742         (testGeolocationManagerWatchPosition):
2743
2744 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2745
2746         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2747         https://bugs.webkit.org/show_bug.cgi?id=196213
2748
2749         Reviewed by Geoff Garen.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2753         (credentialWithIdentityAndKeychainPath):
2754         (-[ChallengeDelegate webView:didFinishNavigation:]):
2755         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2756         (TestWebKitAPI::TEST):
2757
2758 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2759
2760         Expected shouldn't assume its contained types are copyable
2761         https://bugs.webkit.org/show_bug.cgi?id=195986
2762
2763         Reviewed by JF Bastien.
2764
2765         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2766         (TestWebKitAPI::NonCopyable::operator== const):
2767         (TestWebKitAPI::NonCopyable::operator!= const):
2768         (TestWebKitAPI::TEST):
2769
2770 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2771
2772         Remove some now-unnecessary dynamic class lookup
2773         https://bugs.webkit.org/show_bug.cgi?id=196237
2774
2775         Reviewed by Simon Fraser.
2776
2777         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2778         (makeRequest):
2779         (TEST):
2780
2781 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2782
2783         Unreviewed, rolling out r243450.
2784
2785         AppleWin and WinCairo port builds get broken.
2786
2787         Reverted changeset:
2788
2789         "Add test for fix of #196095"
2790         https://bugs.webkit.org/show_bug.cgi?id=196097
2791         https://trac.webkit.org/changeset/243450
2792
2793 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2794
2795         Unreviewed, rolling out r243465.
2796         https://bugs.webkit.org/show_bug.cgi?id=196226
2797
2798         the test doesn't build (Requested by thorton on #webkit).
2799
2800         Reverted changeset:
2801
2802         "Do not terminate the NetworkProcess if a third party
2803         application sends a NSCredential with a SecIdentityRef"
2804         https://bugs.webkit.org/show_bug.cgi?id=196213
2805         https://trac.webkit.org/changeset/243465
2806
2807 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2808
2809         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2810         https://bugs.webkit.org/show_bug.cgi?id=196213
2811
2812         Reviewed by Geoff Garen.
2813
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2815         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2816         (credentialWithIdentityAndKeychainPath):
2817         (-[ChallengeDelegate webView:didFinishNavigation:]):
2818         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2819         (TestWebKitAPI::TEST):
2820
2821 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2822
2823         [ews-build] Gracefully handle missing patch_id in events
2824         https://bugs.webkit.org/show_bug.cgi?id=196216
2825
2826         Reviewed by Lucas Forschler.
2827
2828         * BuildSlaveSupport/ews-build/events.py:
2829
2830 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2831
2832         [ews-build] use lz4 compression for improving buildbot performance
2833         https://bugs.webkit.org/show_bug.cgi?id=196155
2834
2835         Reviewed by Lucas Forschler.
2836
2837         * BuildSlaveSupport/ews-build/master.cfg:
2838
2839 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2840
2841         Pull some API testing helper methods out of TestWKWebView
2842         https://bugs.webkit.org/show_bug.cgi?id=196212
2843
2844         Reviewed by Tim Horton.
2845
2846         Refactor some more API testing utility methods, so that they can be used in
2847         tests that do not use TestWKWebView.
2848
2849         * TestWebKitAPI/cocoa/TestWKWebView.h:
2850         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2851         (-[WKWebView loadTestPageNamed:]):
2852         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2853         (-[WKWebView synchronouslyLoadHTMLString:]):
2854         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2855         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2856         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2857         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2858         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2859
2860 2019-03-25  Jer Noble  <jer.noble@apple.com>
2861
2862         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2863         https://bugs.webkit.org/show_bug.cgi?id=196097
2864
2865         Reviewed by Eric Carlson.
2866
2867         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2868
2869         * DumpRenderTree/mac/DumpRenderTree.mm:
2870         (resetWebPreferencesToConsistentValues):
2871         * WebKitTestRunner/TestController.cpp:
2872         (WTR::TestController::resetPreferencesToConsistentValues):
2873
2874 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2875
2876         Pull IPadUserInterfaceSwizzler out into a separate header file
2877         https://bugs.webkit.org/show_bug.cgi?id=196193
2878
2879         Reviewed by Anders Carlsson.
2880
2881         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2882         be used in other API tests.
2883
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2885         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2886         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2887         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2888         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2889         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2890         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2891
2892 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2893
2894         Remove NavigatorContentUtils in WebCore/Modules
2895         https://bugs.webkit.org/show_bug.cgi?id=196070
2896
2897         Reviewed by Alex Christensen.
2898
2899         NavigatorContentUtils was to support the custom scheme spec [1].
2900         However, in WebKit side, no port has supported the feature in
2901         WebKit layer after EFL port was removed. So there has been the
2902         only IDL implementation of the NavigatorContentUtils in WebCore.
2903         So we don't need to keep the implementation in WebCore anymore.
2904
2905         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2906
2907         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2908
2909 2019-03-24  Andy Estes  <aestes@apple.com>
2910
2911         [watchOS] Remove unused Proximity Networking code
2912         https://bugs.webkit.org/show_bug.cgi?id=196188
2913
2914         Reviewed by Tim Horton.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2917         (TEST):
2918
2919 2019-03-23  Keith Miller  <keith_miller@apple.com>
2920
2921         Refactor clz/ctz and fix getLSBSet.
2922         https://bugs.webkit.org/show_bug.cgi?id=196162
2923
2924         Reviewed by Saam Barati.
2925
2926         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2927
2928         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2929         (TestWebKitAPI::TEST):
2930
2931 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2932
2933         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2934         https://bugs.webkit.org/show_bug.cgi?id=196143
2935
2936         Reviewed by Michael Catanzaro.
2937
2938         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2939         directories.
2940
2941         * Scripts/webkitpy/style/checkers/cpp.py:
2942         (check_identifier_name_in_declaration):
2943         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2944         (WebKitStyleTest.test_names):
2945
2946 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2947
2948         [Flatpak] Manifest expanding fails for qt WPE extension
2949         https://bugs.webkit.org/show_bug.cgi?id=196148
2950
2951         Reviewed by Alex Christensen.
2952
2953         * flatpak/flatpakutils.py:
2954         (expand_submodules_recurse): The last recurse manifest expand
2955         iteration might lead to a single module so take it into account
2956         and don't try to recurse further.
2957
2958 2019-03-22  Chris Dumez  <cdumez@apple.com>
2959
2960         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2961         https://bugs.webkit.org/show_bug.cgi?id=195348
2962         <rdar://problem/48622090>
2963
2964         Reviewed by Alex Christensen.
2965
2966         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2967         to NO when test.options().shouldIgnoreMetaViewport is false.
2968
2969         * WebKitTestRunner/ios/TestControllerIOS.mm:
2970         (WTR::TestController::platformConfigureViewForTest):
2971
2972 2019-03-22  Chris Dumez  <cdumez@apple.com>
2973
2974         Prewarmed processes should be usable with any website data store
2975         https://bugs.webkit.org/show_bug.cgi?id=196104
2976
2977         Reviewed by Alex Christensen.
2978
2979         Add API test coverage.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2982         (runInitialWarmedProcessUsedTest):
2983         (TEST):
2984
2985 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2986
2987         Back out local changes to Alex's Subversion working directory
2988
2989         They were accidentally committed.
2990
2991         * Scripts/webkitpy/common/system/abstractexecutive.py:
2992         (AbstractExecutive.wait_newest):
2993         * Scripts/webkitpy/common/system/executive.py:
2994         (Executive.running_pids):
2995         * Scripts/webkitpy/common/system/executive_mock.py:
2996         (MockExecutive.running_pids):
2997         * Scripts/webkitpy/common/system/executive_unittest.py:
2998         (ExecutiveTest.serial_test_running_pids):
2999         * Scripts/webkitpy/port/darwin.py:
3000         (DarwinPort.check_for_leaks):
3001         * Scripts/webkitpy/port/leakdetector.py:
3002         (LeakDetector.check_for_leaks):
3003         - This was the hack attached to Bug 193772.
3004
3005         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3006         (+[WebKitTestRunnerEvent mouseLocation]):
3007         - This works around a crash on an internal build.
3008
3009 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3010
3011         Fix the build after r243354
3012         https://bugs.webkit.org/show_bug.cgi?id=196138
3013         <rdar://problem/49145951>
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3016         (TEST):
3017         * TestWebKitAPI/ios/UIKitSPI.h:
3018
3019 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3020
3021         Adopt UIWKDocumentContext
3022         https://bugs.webkit.org/show_bug.cgi?id=196040
3023         <rdar://problem/48642440>
3024
3025         Reviewed by Ryosuke Niwa.
3026
3027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3028         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3029         (makeRequest):
3030         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3031         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3032         (applyStyle):
3033         (TEST):
3034         Add tests for UIWKDocumentContext.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3037         (TEST):
3038         (recursiveFindWKContentView): Deleted.
3039         * TestWebKitAPI/cocoa/TestWKWebView.h:
3040         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3041         (recursiveFindWKContentView):
3042         (-[TestWKWebView wkContentView]):
3043         * TestWebKitAPI/ios/UIKitSPI.h:
3044         Share the WKContentView finding code between tests.
3045
3046 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3047
3048         [iOS WK2] Turn on async overflow scrolling by default
3049         https://bugs.webkit.org/show_bug.cgi?id=196011
3050         rdar://problem/48453859
3051
3052         Reviewed by Antti Koivisto.
3053         
3054         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3055         since so many basic layout tests have different results when compositing is triggered for
3056         overflow.
3057         
3058         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3059
3060         * WebKitTestRunner/TestController.cpp:
3061         (WTR::TestController::resetPreferencesToConsistentValues):
3062
3063 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] Retry API test in case of failures
3066         https://bugs.webkit.org/show_bug.cgi?id=196004
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-build/steps.py:
3071         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3072         (CompileWebKitToT.doStepIf): Ditto.
3073         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3074         (ReRunAPITests): Re-run API tests.
3075         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3076         (RunAPITestsWithoutPatch): Run API tests without patch.
3077         (RunAPITestsWithoutPatch.doStepIf):
3078         (RunAPITestsWithoutPatch.hideStepIf):
3079         (RunAPITestsWithoutPatch.evaluateCommand):
3080         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3081         (AnalyzeAPITestsResults.start):
3082         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3083         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3084         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3085         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3086
3087 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3088
3089         [ews-build] Update queues configurations
3090         https://bugs.webkit.org/show_bug.cgi?id=196074
3091
3092         Reviewed by Dewei Zhu.
3093
3094         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3095         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3096
3097 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3098
3099         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3100         https://bugs.webkit.org/show_bug.cgi?id=195680
3101         <rdar://problem/48903534>
3102
3103         Unreviewed infrastructure fix.
3104
3105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3106         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3107
3108 2019-03-21  Andy Estes  <aestes@apple.com>
3109
3110         [iOS] Apple Pay should be available in documents with no user agent scripts
3111         https://bugs.webkit.org/show_bug.cgi?id=196061
3112         <rdar://problem/48649391>
3113
3114         Reviewed by Brady Eidson.
3115
3116         Added API tests and related infrastructure.
3117
3118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3119         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3120         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3121         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3124         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3125         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3126         * TestWebKitAPI/cocoa/TestProtocol.mm:
3127         (-[TestProtocol startLoading]):
3128         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3129         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3130         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3131         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3132
3133 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3134
3135         REGRESSSION (r243297): webkitpy tests broken
3136         https://bugs.webkit.org/show_bug.cgi?id=196108
3137
3138         Reviewed by Aakash Jain.
3139
3140         r243297 updated contributors.json, which broke a few unit tests.
3141
3142         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3143         (IRCCommandTest.test_whois):
3144         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3145
3146 2019-03-21  Chris Dumez  <cdumez@apple.com>
3147
3148         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3149         https://bugs.webkit.org/show_bug.cgi?id=196041
3150         <rdar://problem/49083230>
3151
3152         Reviewed by Alex Christensen.
3153
3154         Add API test coverage.
3155
3156         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3157         (TEST):
3158
3159 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3160
3161         Add SPI to inform applications of WKContentRuleList actions
3162         https://bugs.webkit.org/show_bug.cgi?id=195965
3163         <rdar://problem/42664365>
3164
3165         Reviewed by Geoff Garen.
3166
3167         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3168         (TestWebKitAPI::allActionsForResourceLoad):
3169         (TestWebKitAPI::testRequest):
3170         (TestWebKitAPI::TEST_F):
3171         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3172         (Notification::description):
3173         (Notification::operator== const):
3174         (toVector):
3175         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3176         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3177         (makeContentRuleList):
3178         (TEST):
3179         (makeWarnContentRuleList): Deleted.
3180
3181 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3182
3183         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3184         https://bugs.webkit.org/show_bug.cgi?id=196088
3185
3186         Reviewed by Brian Burg.
3187
3188         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3189         Support checks when only one platform is specified. Also deprecate macosx() and
3190         force the use of macos() instead.
3191
3192         * Scripts/webkitpy/style/checkers/cpp.py:
3193         (check_min_versions_of_wk_api_available):
3194         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3195         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3196
3197 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3198
3199         Update status inactive committers' status to 'contributor'.
3200
3201         * Scripts/webkitpy/common/config/contributors.json:
3202
3203 2019-03-21  Xan Lopez  <xan@igalia.com>
3204
3205         [JSC][x86] Drop support for x87 floating point
3206         https://bugs.webkit.org/show_bug.cgi?id=194853
3207
3208         Reviewed by Don Olmstead.
3209
3210         Force SSE2 on x86/32bit builds.
3211
3212         * Scripts/webkitdirs.pm:
3213         (generateBuildSystemFromCMakeProject):
3214
3215 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3216
3217         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3218         https://bugs.webkit.org/show_bug.cgi?id=196073
3219
3220         Reviewed by Michael Catanzaro.
3221
3222         Add test cases to check functions and constructors with no arguments but receiving user data.
3223
3224         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3225         (checkUserData):
3226         (testJSCFunction):
3227         (fooCreateWithUserData):
3228         (testJSCClass):
3229
3230 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3231
3232         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3233
3234         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3235
3236         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3237
3238 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3239
3240         [GTK][WPE] Add API to provide geolocation information
3241         https://bugs.webkit.org/show_bug.cgi?id=195940
3242
3243         Reviewed by Michael Catanzaro.
3244
3245         Add a new test to check the new API.
3246
3247         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3248         (testGeolocationManagerCurrentPosition):
3249         (testGeolocationManagerWatchPosition):
3250         (beforeAll):
3251         (afterAll):
3252         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3253         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3254         (beforeAll): Ditto.
3255         * TestWebKitAPI/glib/CMakeLists.txt:
3256
3257 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3258
3259         [GLib] Returning G_TYPE_OBJECT from a method does not work
3260         https://bugs.webkit.org/show_bug.cgi?id=195574
3261
3262         Reviewed by Michael Catanzaro.
3263
3264         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3265
3266         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3267         (getGFile):
3268         (getParent):
3269         (createGString):
3270         (getGString):
3271         (getGStringCopyWillRaise):
3272         (getGStringCopy):
3273         (getGStringStr):
3274         (getGStringLen):
3275         (freeGString):
3276         (testJSCClass):
3277
3278 2019-03-20  Saam Barati  <sbarati@apple.com>
3279
3280         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3281         https://bugs.webkit.org/show_bug.cgi?id=195721
3282
3283         Reviewed by Filip Pizlo.
3284
3285         * Scripts/run-javascriptcore-tests:
3286
3287 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3288
3289         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3290         https://bugs.webkit.org/show_bug.cgi?id=196049
3291
3292         Reviewed by Tim Horton.
3293
3294         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3295         overflow scrolling in general, so rename it.
3296
3297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3298
3299 2019-03-20  Daniel Bates  <dabates@apple.com>
3300
3301         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3302         https://bugs.webkit.org/show_bug.cgi?id=196031
3303         <rdar://problem/49078172>
3304
3305         Reviewed by Tim Horton.
3306
3307         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3308         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3309         same code path used when the Done button is pressed to dismiss the <select> picker.
3310
3311         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3312         (TestWebKitAPI::TEST):
3313
3314 2019-03-20  Chris Dumez  <cdumez@apple.com>
3315
3316         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3317         https://bugs.webkit.org/show_bug.cgi?id=196029
3318         <rdar://problem/48954651>
3319
3320         Reviewed by Tim Horton.
3321
3322         Add API test coverage.
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3325
3326 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3327
3328         [ews-build] Improve failure summary string for ApplyPatch step
3329         https://bugs.webkit.org/show_bug.cgi?id=195995
3330
3331         Reviewed by Alexey Proskuryakov.
3332
3333         * BuildSlaveSupport/ews-build/steps.py:
3334         (ApplyPatch.getResultSummary): Override getResultSummary.
3335
3336 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3337
3338         AX: Implement support for new meter ARIA role
3339         https://bugs.webkit.org/show_bug.cgi?id=195966
3340
3341         Reviewed by Chris Fleizach.
3342
3343         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3344         to AXLevelIndicator.
3345
3346         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3347
3348 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3349
3350         [WebAuthN] Implement FIDO AppID extension
3351         https://bugs.webkit.org/show_bug.cgi?id=143491
3352         <rdar://problem/48298273>
3353
3354         Reviewed by Brent Fulgham.
3355
3356         Add a test that covers the new flag of convertToU2fSignCommand.
3357
3358         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3361         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3362         (TestWebKitAPI::TEST):
3363
3364 2019-03-19  Keith Rollin  <krollin@apple.com>
3365
3366         Add support for more platforms to generate-xcfilelists
3367         https://bugs.webkit.org/show_bug.cgi?id=195977
3368
3369         Reviewed by Alexey Proskuryakov.
3370
3371         generate-xcfilelists incorrectly complains when involved with building
3372         WebKit for iphonesimulator:
3373
3374             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3375             …
3376             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3377
3378         Address this by teaching generate-xcfilelists about more platforms.
3379
3380         * Scripts/generate-xcfilelists:
3381
3382 2019-03-19  John Wilander  <wilander@apple.com>
3383
3384         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3385         https://bugs.webkit.org/show_bug.cgi?id=195923
3386         <rdar://problem/49001272>
3387
3388         Reviewed by Alex Christensen.
3389
3390         This patch does the following to the TestRunner:
3391         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3392         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3393         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3394
3395         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3396         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3397         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3399         * WebKitTestRunner/TestController.cpp:
3400         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3401         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3402         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3403         * WebKitTestRunner/TestController.h:
3404         * WebKitTestRunner/TestInvocation.cpp:
3405         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3406
3407 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3408
3409         [CMake] Support more clang and gcc sanitizers
3410         https://bugs.webkit.org/show_bug.cgi?id=195956
3411
3412         Reviewed by Michael Catanzaro.
3413
3414         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3415
3416 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-build] Improve summary for PrintConfiguration step
3419         https://bugs.webkit.org/show_bug.cgi?id=195945
3420
3421         Reviewed by Lucas Forschler.
3422
3423         * BuildSlaveSupport/ews-build/steps.py:
3424         (PrintConfiguration.getResultSummary): Override getResultSummary.
3425
3426 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3427
3428         [ews-build] Improve summary for CheckOutSource step
3429         https://bugs.webkit.org/show_bug.cgi?id=195963
3430
3431         Reviewed by Lucas Forschler.
3432
3433         * BuildSlaveSupport/ews-build/steps.py:
3434         (CheckOutSource.getResultSummary):
3435
3436 2019-03-19  Daniel Bates  <dabates@apple.com>
3437
3438         [iOS] Focus not preserved when switching between tabs
3439         https://bugs.webkit.org/show_bug.cgi?id=195820
3440         <rdar://problem/43614450>
3441
3442         Reviewed by Brent Fulgham.
3443
3444         Add tests to ensure that we restore focus when resigning and becoming first responder.
3445
3446         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3447         (TestWebKitAPI::TEST):
3448
3449 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3450
3451         Make WTFLogChannelState and WTFLogLevel enum classes
3452         https://bugs.webkit.org/show_bug.cgi?id=195904
3453
3454         Reviewed by Eric Carlson.
3455
3456         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3457         (TestWebKitAPI::TEST_F):
3458
3459 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3460
3461         [GStreamer][EME] Backported mssdemux protection data crash fix
3462         https://bugs.webkit.org/show_bug.cgi?id=195918
3463
3464         Reviewed by Philippe Normand.
3465
3466         * gstreamer/jhbuild.modules:
3467         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3468
3469 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3470
3471         Unreviewed, rolling out r243132.
3472
3473         Broke GTK build
3474
3475         Reverted changeset:
3476
3477         "Make WTFLogChannelState and WTFLogLevel enum classes"
3478         https://bugs.webkit.org/show_bug.cgi?id=195904
3479         https://trac.webkit.org/changeset/243132
3480
3481 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3482
3483         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3484
3485         * Scripts/webkitdirs.pm:
3486         (builtDylibPathForName): Adjust the shared library name that's changed
3487         with the API version bump in r243073.
3488
3489 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3490
3491         Make WTFLogChannelState and WTFLogLevel enum classes
3492         https://bugs.webkit.org/show_bug.cgi?id=195904
3493
3494         Reviewed by Eric Carlson.
3495
3496         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3497         (TestWebKitAPI::TEST_F):
3498
3499 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3500
3501         Disable flaky test added in r2431100
3502         https://webkit.org/b/195785
3503
3504         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3505         (TestWebKitAPI::TEST):
3506         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3507
3508 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3509
3510         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3511         https://bugs.webkit.org/show_bug.cgi?id=195916
3512
3513         Reviewed by Tim Horton.
3514
3515         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3516         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3517
3518 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3519
3520         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3521
3522         * Scripts/webkitpy/common/config/contributors.json:
3523
3524 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3525
3526         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3527         https://bugs.webkit.org/show_bug.cgi?id=195785
3528
3529         Reviewed by Geoffrey Garen.
3530
3531         * TestWebKitAPI/TCPServer.cpp: Added.
3532         (TestWebKitAPI::TCPServer::TCPServer):
3533         (TestWebKitAPI::TCPServer::~TCPServer):
3534         (TestWebKitAPI::TCPServer::socketBindListen):
3535         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3536         * TestWebKitAPI/TCPServer.h: Added.
3537         (TestWebKitAPI::TCPServer::port const):
3538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3539         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3540         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3541         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3542         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3543         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3544         (TestWebKitAPI::respondSlowly):
3545         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3546         (TestWebKitAPI::downloadAtRate):
3547         (TestWebKitAPI::TEST):
3548
3549 2019-03-18  Saam Barati  <sbarati@apple.com>
3550
3551         Add a plan file for JetStream 2
3552         https://bugs.webkit.org/show_bug.cgi?id=190734
3553
3554         Reviewed by Mark Lam.
3555
3556         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3557
3558 2019-03-18  Chris Dumez  <cdumez@apple.com>
3559
3560         Delay WebProcess launch until a load is triggered in a Web view
3561         https://bugs.webkit.org/show_bug.cgi?id=195758
3562         <rdar://problem/48126013>
3563
3564         Reviewed by Geoff Garen.
3565
3566         Add API test coverage. Also update some existing API tests to not expect
3567         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3568
3569         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3570         (TestWebKitAPI::TEST):
3571         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3572         (TestWebKitAPI::TEST):
3573         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3574         (TEST):
3575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3576         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3577         (TEST):
3578         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3579         (TEST):
3580         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3581
3582 2019-03-18  Xan Lopez  <xan@igalia.com>
3583
3584         [CMake] Prevent potential warning when determining $architecture
3585         https://bugs.webkit.org/show_bug.cgi?id=195891
3586
3587         Reviewed by Michael Catanzaro.
3588
3589         It's possible for generateBuildSystemForCMakeProject to be called
3590         before determineArchitecture() is ever called. This will make the
3591         first eq check with $architecture to be bogus (and print a
3592         warning). Change that to an eq check with architecture(), which
3593         implicitly calls determineArchitecture() if needed, and change all
3594         the other similar cases in the method in the same way to prevent
3595         future bugs like this one.
3596
3597         * Scripts/webkitdirs.pm:
3598         (generateBuildSystemFromCMakeProject):
3599
3600 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3601
3602         [WPE] Tarballs generated with “make dist” cannot build documentation
3603         https://bugs.webkit.org/show_bug.cgi?id=195885
3604
3605         Reviewed by Carlos Garcia Campos.
3606
3607         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3608
3609 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3610
3611         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3612         https://bugs.webkit.org/show_bug.cgi?id=195883
3613
3614         Reviewed by Carlos Garcia Campos.
3615
3616         * gtkdoc/gtkdoc.py:
3617         (GTKDoc._run_command): When commands fail to run, include the full command line for
3618         the program invocation and the output it has generated on the standard error stream.
3619
3620 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3621
3622         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3623         https://bugs.webkit.org/show_bug.cgi?id=195786
3624
3625         Reviewed by Philippe Normand.
3626
3627         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3628         * wpe/jhbuild.modules: Ditto.
3629
3630 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3631
3632         [ews-build] Don't run clean builds on EWS builders
3633         https://bugs.webkit.org/show_bug.cgi?id=195851
3634
3635         Reviewed by Geoffrey Garen.
3636
3637         * BuildSlaveSupport/ews-build/factories.py:
3638
3639 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3640
3641         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3642         https://bugs.webkit.org/show_bug.cgi?id=195849
3643
3644         Reviewed by Chris Dumez.
3645
3646         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3647
3648         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3649         (runWebsiteDataStoreCustomPaths):
3650
3651 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3652
3653         webkitpy: Upload test results
3654         https://bugs.webkit.org/show_bug.cgi?id=195755
3655         <rdar://problem/48896182>
3656
3657         Reviewed by Aakash Jain.
3658
3659         Establish a new format for uploading results that is not tied to layout tests, apply
3660         that format to webkitpy tests.
3661
3662         * Scripts/webkitpy/common/checkout/scm/git.py:
3663         (Git.native_branch): Return what branch the current checkout is on.
3664         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3665         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3666         * Scripts/webkitpy/common/checkout/scm/svn.py:
3667         (SVN.native_branch): Ditto.
3668         * Scripts/webkitpy/common/system/platforminfo.py:
3669         (PlatformInfo.build_version): Return a build version for Mac.
3670         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3671         (MockPlatformInfo.__init__):
3672         (MockPlatformInfo.build_version):
3673         * Scripts/webkitpy/results: Added.
3674         * Scripts/webkitpy/results/__init__.py: Added.
3675         * Scripts/webkitpy/results/options.py: Added.
3676         (upload_options): OptParse list for upload options.
3677         * Scripts/webkitpy/results/upload.py: Added.
3678         (Upload): Class which enforces the upload format expected by the results server.
3679         (Upload.Expectations):
3680         (Upload.create_configuration):
3681         (Upload.create_commit):
3682         (Upload.create_details):
3683         (Upload.create_run_stats):
3684         (Upload.create_test_result):
3685         (Upload.__init__):
3686         (Upload.Encoder): Encode Upload object as json.
3687         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3688         * Scripts/webkitpy/results/upload_unittest.py: Added.
3689         * Scripts/webkitpy/test/main.py:
3690         (Tester._parse_args): Add upload arguments.
3691         (Tester._run_tests): Allow results to be uploaded.
3692         * Scripts/webkitpy/test/runner.py:
3693         (Runner.__init__): Record which tests were run, rather than just counting them.
3694         (Runner.handle):
3695         * Scripts/webkitpy/test/runner_unittest.py:
3696         (RunnerTest.test_run):
3697         * Scripts/webkitpy/thirdparty/__init__.py:
3698         (AutoinstallImportHook.find_module): Add requests auto-install.
3699         (AutoinstallImportHook._install_requests):
3700         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3701         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3702
3703 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3704
3705         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3706         https://bugs.webkit.org/show_bug.cgi?id=195810
3707
3708         Reviewed by Tim Horton.
3709
3710         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3711         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3712         ending certain layout tests.
3713
3714         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3715         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3716         (-[TestRunnerWKWebView dealloc]):
3717         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3718
3719         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3720         helper method when destroying the web view, and when resetting state between tests.
3721
3722         * WebKitTestRunner/ios/TestControllerIOS.mm:
3723         (WTR::TestController::platformResetStateToConsistentValues):
3724
3725         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3726
3727 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3728
3729         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3730         https://bugs.webkit.org/show_bug.cgi?id=190350
3731         <rdar://problem/45089503>
3732
3733         Reviewed by Geoffrey Garen.
3734
3735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3736         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3737         (TEST):
3738         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3739         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3740         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3742         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3743         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3744         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3745         (runTest):
3746         (createDirectories):
3747         (TEST):
3748         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3749         (TEST):
3750         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3751         (TEST):
3752
3753 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3754
3755         Add support to WebPage for getting the contents as an attributed string.
3756         https://bugs.webkit.org/show_bug.cgi?id=195636
3757         rdar://problem/45055697
3758
3759         Reviewed by Tim Horton.
3760
3761         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3762         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3763
3764 2019-03-15  Chris Dumez  <cdumez@apple.com>
3765
3766         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3767         https://bugs.webkit.org/show_bug.cgi?id=195747
3768
3769         Reviewed by Geoff Garen.
3770
3771         Add API test coverage.
3772
3773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3774
3775 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3776
3777         Unreviewed, rolling out r242952.
3778
3779         Causing API failures on iOS Simulator
3780
3781         Reverted changeset:
3782
3783         "[PSON] Make sure the WebProcessCache is leverage when
3784         relaunching a process after termination"
3785         https://bugs.webkit.org/show_bug.cgi?id=195747
3786         https://trac.webkit.org/changeset/242952
3787
3788 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3789
3790         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3791         https://bugs.webkit.org/show_bug.cgi?id=195740
3792
3793         Reviewed by Ross Kirsling.
3794
3795         window.open doesn't work for WebKitBrowserWindow because it is not
3796         implemented yet.
3797
3798         1. Implemented createNewPage callback of WKPageUIClient.
3799         2. Changed MainWindow to take a BrowserWindow factory function
3800           instead of BrowserWindowType to be flexible to create
3801           BrowserWindow with extra settings.
3802         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3803           because it is not relevant with MainWindow anymore.
3804
3805         * MiniBrowser/win/Common.cpp:
3806         (parseCommandLine):
3807         * MiniBrowser/win/Common.h:
3808         (CommandLineOptions::CommandLineOptions):
3809         * MiniBrowser/win/MainWindow.cpp:
3810         (MainWindow::MainWindow):
3811         (MainWindow::create):
3812         (MainWindow::init):
3813         (MainWindow::WndProc):
3814         * MiniBrowser/win/MainWindow.h:
3815         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3816         (PrintWebUIDelegate::createWebViewWithRequest):
3817         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3818         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3819         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3820         (WebKitBrowserWindow::updateProxySettings):
3821         (WebKitBrowserWindow::createNewPage):
3822         * MiniBrowser/win/WebKitBrowserWindow.h:
3823         * MiniBrowser/win/WinMain.cpp:
3824         (wWinMain):
3825
3826 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3827
3828         Make it possible to test scrolling tree layer manipulation more easily
3829         https://bugs.webkit.org/show_bug.cgi?id=195780
3830
3831         Reviewed by Tim Horton.
3832         
3833         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3834         cuts off communication of scrolling tree scrolls back to the web process
3835         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3836         allows tests to trigger scrolls which run the scrolling tree layer positioning
3837         logic, but never get another commit from the web process that might mask
3838         scrolling tree bugs.
3839         
3840         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3841         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3842         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3843
3844         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3845         (WTR::UIScriptController::scrollUpdatesDisabled const):
3846         (WTR::UIScriptController::setScrollUpdatesDisabled):
3847         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3848         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3849         (WTR::UIScriptController::scrollUpdatesDisabled const):
3850         (WTR::UIScriptController::setScrollUpdatesDisabled):
3851         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3852         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3853         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3854         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3855         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3856         * WebKitTestRunner/ios/TestControllerIOS.mm:
3857         (WTR::TestController::platformResetStateToConsistentValues):
3858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3859         (WTR::UIScriptController::scrollUpdatesDisabled const):
3860         (WTR::UIScriptController::setScrollUpdatesDisabled):
3861
3862 2019-03-14  Youenn Fablet  <youenn@apple.com>
3863
3864         Move IDB storage in private browsing mode to NetworkProcess
3865         https://bugs.webkit.org/show_bug.cgi?id=195602
3866
3867         Reviewed by Brady Eidson.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3870         (TEST):
3871
3872 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3873
3874         [ews-build] Make descriptionDone messages more readable
3875         https://bugs.webkit.org/show_bug.cgi?id=195760
3876
3877         Reviewed by Lucas Forschler.
3878
3879         * BuildSlaveSupport/ews-build/steps.py:
3880         * BuildSlaveSupport/ews-build/steps_unittest.py:
3881
3882 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3883
3884         [ews-build] Generate status-bubble hover-over messages
3885         https://bugs.webkit.org/show_bug.cgi?id=195680
3886
3887         Reviewed by Lucas Forschler.
3888
3889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3890         (StatusBubble):
3891         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3892         on hover-over.
3893         (StatusBubble._iso_time):
3894         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3895         hover-over message.
3896         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3897
3898 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3899
3900         [ews-app] Gracefully handle the case when state_string is None
3901         https://bugs.webkit.org/show_bug.cgi?id=195753
3902
3903         Reviewed by Lucas Forschler.
3904
3905         * BuildSlaveSupport/ews-app/ews/models/build.py:
3906         * BuildSlaveSupport/ews-app/ews/models/step.py:
3907
3908 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3909
3910         [ews-app] Status bubble display pending for currently running build step
3911         https://bugs.webkit.org/show_bug.cgi?id=195744
3912
3913         Reviewed by Lucas Forschler.
3914
3915         * BuildSlaveSupport/ews-build/events.py:
3916         (Events.stepStarted): If state_string is pending, replace it with step name.
3917
3918 2019-03-14  Chris Dumez  <cdumez@apple.com>
3919
3920         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3921         https://bugs.webkit.org/show_bug.cgi?id=195750
3922
3923         Reviewed by Geoffrey Garen.
3924
3925         Add API test coverage.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3928         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3929         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3930         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3931
3932 2019-03-14  Chris Dumez  <cdumez@apple.com>
3933
3934         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3935         https://bugs.webkit.org/show_bug.cgi?id=195747
3936
3937         Reviewed by Geoff Garen.
3938
3939         Add API test coverage.
3940
3941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3942
3943 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3944
3945         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3946         https://bugs.webkit.org/show_bug.cgi?id=195725
3947         <rdar://problem/48545062>
3948
3949         Reviewed by Tim Horton.
3950
3951         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3952         handler is nil.
3953
3954         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3955         (TestWebKitAPI::TEST):
3956
3957 2019-03-13  Sam Weinig  <sam@webkit.org>
3958
3959         Add utility function to allow easy reverse range-based iteration of a container
3960         https://bugs.webkit.org/show_bug.cgi?id=195542
3961
3962         Reviewed by Antti Koivisto.
3963
3964         * TestWebKitAPI/CMakeLists.txt:
3965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3966         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3967         (TestWebKitAPI::TEST):
3968         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3969
3970 2019-03-13  Chris Dumez  <cdumez@apple.com>
3971
3972         Use a ServiceWorker process per registrable domain
3973         https://bugs.webkit.org/show_bug.cgi?id=195649
3974
3975         Reviewed by Youenn Fablet.
3976
3977         Update API test coverage.
3978
3979         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3980
3981 2019-03-13  Chris Dumez  <cdumez@apple.com>
3982
3983         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3984         https://bugs.webkit.org/show_bug.cgi?id=195684
3985         <rdar://problem/48294714>
3986
3987         Reviewed by Antti Koivisto.
3988
3989         Add API test coverage.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3992
3993 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3994
3995         [ews-app] Remove unused patch view
3996         https://bugs.webkit.org/show_bug.cgi?id=195669
3997
3998         Reviewed by Lucas Forschler.
3999
4000         * BuildSlaveSupport/ews-app/ews/urls.py:
4001         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4002
4003 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4004
4005         [ews-app] Use Buildbot result code variables
4006         https://bugs.webkit.org/show_bug.cgi?id=195668
4007
4008         Reviewed by Alexey Proskuryakov.
4009
4010         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4011         (Buildbot): Added Buildbot result code variables.
4012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4013         (StatusBubble._build_bubble): Used Buildbot result code variables.
4014
4015 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4016
4017         [Flatpak] Expand submodule recursively
4018         https://bugs.webkit.org/show_bug.cgi?id=195672
4019
4020         Building WPE with flatpak was impossible without that as it was raising an exception.
4021         Also update wpebackend-fdo to match what is built in jhbuild
4022
4023         Reviewed by Philippe Normand.
4024
4025         * flatpak/flatpakutils.py:
4026         (expand_submodules_recurse):
4027         (expand_manifest):
4028         * flatpak/org.webkit.WPEModules.yaml:
4029
4030 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4031
4032         [ews-app] status bubble should be hidden for certain builds
4033         https://bugs.webkit.org/show_bug.cgi?id=194597
4034
4035         Reviewed by Dewei Zhu.
4036
4037         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4038         (StatusBubble._build_bubble):
4039         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4040         because the patch didn't have relevant changes.
4041         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4042         in production yet.
4043
4044 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4045
4046         [Win] Fix a slew of simple clang-cl warnings.
4047         https://bugs.webkit.org/show_bug.cgi?id=195652
4048
4049         Reviewed by Don Olmstead.
4050
4051         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4052         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4053
4054 2019-03-12  Justin Fan  <justin_fan@apple.com>
4055
4056         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4057         https://bugs.webkit.org/show_bug.cgi?id=195518
4058         <rdar://problem/46322356>
4059
4060         Reviewed by Myles C. Maxfield.
4061
4062         * DumpRenderTree/DerivedSources-input.xcfilelist:
4063         * DumpRenderTree/DerivedSources-output.xcfilelist:
4064
4065 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4066
4067         Unreviewed, rolling out r242825.
4068         https://bugs.webkit.org/show_bug.cgi?id=195648
4069
4070         "Broke webkitpy tests with my change to
4071         lldb_dump_class_layout.py" (Requested by rmorisset on
4072         #webkit).
4073
4074         Reverted changeset:
4075
4076         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4077         classes with suspicious padding"
4078         https://bugs.webkit.org/show_bug.cgi?id=195573
4079         https://trac.webkit.org/changeset/242825
4080
4081 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4082
4083         [ews-build] Show status bubbles while the patch is waiting in queue
4084         https://bugs.webkit.org/show_bug.cgi?id=195618
4085
4086         Reviewed by Lucas Forschler.
4087
4088         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4089         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4090         enabled in initial deployment.
4091         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4092         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4093         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4094         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4095         (StatusBubble._build_bubbles_for_patch):
4096
4097 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4098
4099         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4100         https://bugs.webkit.org/show_bug.cgi?id=195573
4101
4102         Reviewed by Simon Fraser.
4103
4104         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4105
4106         * Scripts/dump-class-layout:
4107         (main):
4108         * lldb/lldb_dump_class_layout.py:
4109         (ClassLayout.__init__):
4110         (ClassLayout._compute_padding_recursive):
4111         (LLDBDebuggerInstance.dump_layout_for_classname):
4112         (LLDBDebuggerInstance):
4113         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4114         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4115
4116 2019-03-12  Chris Dumez  <cdumez@apple.com>
4117
4118         Device Orientation access permission should be denied unless explicitly granted by the client
4119         https://bugs.webkit.org/show_bug.cgi?id=195625
4120
4121         Reviewed by Youenn Fablet.
4122
4123         add API test coverage.
4124
4125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4126         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4127         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4128         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4129         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4130         (runDeviceOrientationTest):
4131         (TEST):
4132         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4133         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4134
4135 2019-03-12  Jer Noble  <jer.noble@apple.com>
4136
4137         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4138         https://bugs.webkit.org/show_bug.cgi?id=195137
4139         <rdar://problem/48810307>
4140
4141         Reviewed by Eric Carlson.
4142
4143         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4144         (TestWebKitAPI::TEST):
4145
4146 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-build] Change urls from uat to production
4149         https://bugs.webkit.org/show_bug.cgi?id=195566
4150
4151         Reviewed by Lucas Forschler.
4152
4153         * BuildSlaveSupport/ews-app/ews/config.py:
4154         * BuildSlaveSupport/ews-build/events.py:
4155         * BuildSlaveSupport/ews-build/steps.py:
4156
4157 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4158
4159         [ews-build] change max_builds for local-worker to 1
4160         https://bugs.webkit.org/show_bug.cgi?id=195568
4161
4162         Reviewed by Lucas Forschler.
4163
4164         * BuildSlaveSupport/ews-build/loadConfig.py:
4165
4166 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4167
4168         Fix the build
4169
4170         * TestRunnerShared/spi/PencilKitTestSPI.h:
4171         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4172
4173 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4174
4175         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4176         https://bugs.webkit.org/show_bug.cgi?id=194131
4177
4178         Reviewed by Michael Catanzaro.
4179
4180         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4181         (uriChanged):
4182         (testUnfinishedSubresourceLoad):
4183         (serverCallback):
4184         (beforeAll):
4185
4186 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4187
4188         WTF::Expected should use std::addressof instead of operator&
4189         https://bugs.webkit.org/show_bug.cgi?id=195604
4190
4191         Reviewed by Myles Maxfield.
4192
4193         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4194         (TestWebKitAPI::Unique::Unique):
4195         (TestWebKitAPI::Unique::operator&):
4196         (TestWebKitAPI::TEST):
4197
4198 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4199
4200         Add Optional to Forward.h.
4201         https://bugs.webkit.org/show_bug.cgi?id=195586
4202
4203         Reviewed by Darin Adler.
4204
4205         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4206         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4207         Remove unnecessary includes from headers.
4208
4209 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4210
4211         Add testing API to hit-test and scroll overflow scrollers
4212         https://bugs.webkit.org/show_bug.cgi?id=195278
4213
4214         Reviewed by Antti Koivisto.
4215         
4216         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4217         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4218         
4219         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4220
4221         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4222         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4223         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4225         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4226         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4227         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4228         (WTR::enclosingScrollViewIncludingSelf):
4229         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4230
4231 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4232
4233         API test WebKit.RequestTextInputContext fails on iOS
4234         https://bugs.webkit.org/show_bug.cgi?id=195585
4235
4236         Reviewed by Wenson Hsieh and Simon Fraser.
4237
4238         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4239         (applyStyle):
4240         (TEST):
4241         Add a viewport, so that the coordinates match up on iOS.
4242         Scroll by moving the UIScrollView's contentOffset.
4243
4244 2019-03-11  Chris Dumez  <cdumez@apple.com>
4245
4246         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4247         https://bugs.webkit.org/show_bug.cgi?id=195506
4248         <rdar://problem/48733477>
4249
4250         Reviewed by Alex Christensen.
4251
4252         Add API test coverage.
4253
4254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4255
4256 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4257
4258         Adding myself to contributors.json
4259
4260         Unreviewed, addming myself to contributors.json .
4261
4262         * Scripts/webkitpy/common/config/contributors.json:
4263
4264 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4265
4266         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4267         https://bugs.webkit.org/show_bug.cgi?id=195511
4268         <rdar://problem/44873269>
4269
4270         Reviewed by Darin Adler.
4271
4272         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4273         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4274         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4275         (TEST_F):
4276
4277 2019-03-11  Chris Dumez  <cdumez@apple.com>
4278
4279         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4280         https://bugs.webkit.org/show_bug.cgi?id=195561
4281
4282         Reviewed by Youenn Fablet.
4283
4284         Make sure the JS in the test requests for permission to receive device orientation events.
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4287
4288 2019-03-11  Youenn Fablet  <youenn@apple.com>
4289
4290         Allow storage quota increase by default in WTR
4291         https://bugs.webkit.org/show_bug.cgi?id=195541
4292
4293         Reviewed by Geoffrey Garen.
4294
4295         Allow storage quota increase by default in WTR.
4296         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4297         Use this for tests that explicitly need cache increase.
4298
4299         Instead of increasing quota by 2, make sure the next request is
4300         granted by adding all given parameters.
4301
4302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4304         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4305         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4307         * WebKitTestRunner/TestController.cpp:
4308         (WTR::TestController::setAllowStorageQuotaIncrease):
4309         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4310         * WebKitTestRunner/TestController.h:
4311         * WebKitTestRunner/TestInvocation.cpp:
4312         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4313         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4314         (WTR::TestController::cocoaResetStateToConsistentValues):
4315         (WTR::TestController::setAllowStorageQuotaIncrease):
4316         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4317         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4318         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4319
4320 2019-03-11  Xan Lopez  <xan@igalia.com