webkitbot refers to sheriffbot in help
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
2
3         webkitbot refers to sheriffbot in help
4         https://bugs.webkit.org/show_bug.cgi?id=114307
5
6         Reviewed by Benjamin Poulain.
7
8         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
9
10         * Scripts/webkitpy/tool/bot/irc_command.py:
11         (Help):
12         (Help.execute):
13         (RollChromiumDEPS.execute):
14         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
15         (IRCBotTest.test_help):
16         * Scripts/webkitpy/tool/bot/sheriff.py:
17         (Sheriff.name):
18
19 2013-04-06  Roger Fong  <roger_fong@apple.com>
20
21         Kill old processes between runs on WinEWS bots.
22         Temporarily disable tests to let bots catch up again.
23
24         * EWSTools/start-queue-win.sh:
25         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
26         (WinEWS):
27
28 2013-04-09  Glenn Adams  <glenn@skynav.com>
29
30         [webkitpy] Remove chromium deprecated port support.
31         https://bugs.webkit.org/show_bug.cgi?id=114228
32
33         Reviewed by Ryosuke Niwa.
34
35         * Scripts/webkitpy/common/config/ports.py:
36         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
37         (ChromiumPort): Removed.
38         (ChromiumAndroidPort): Removed.
39         (ChromiumXVFBPort): Removed.
40         * Scripts/webkitpy/common/config/ports_unittest.py:
41         (DeprecatedPortTest.test_chromium_port): Removed.
42         (DeprecatedPortTest.test_chromium_android_port): Removed.
43         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
44         * Scripts/webkitpy/tool/steps/update_unittest.py:
45         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
46         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
47
48 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
49
50         AX: The bounding paths should be made available through accessibility
51         https://bugs.webkit.org/show_bug.cgi?id=113817
52
53         Reviewed by David Kilzer.
54
55         Add a pathDescription property for testing so that it's possible
56         to verify that a path is being returned correctly.
57
58         * DumpRenderTree/AccessibilityUIElement.cpp:
59         (getPathDescriptionCallback):
60         (AccessibilityUIElement::pathDescription):
61         (AccessibilityUIElement::getJSClass):
62         * DumpRenderTree/AccessibilityUIElement.h:
63         (AccessibilityUIElement):
64         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
65         (_CGPathEnumerationIteration):
66         (AccessibilityUIElement::pathDescription):
67         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
68         (AccessibilityUIElement::pathDescription):
69         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
70         (WTR::AccessibilityUIElement::pathDescription):
71         (WTR):
72         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
73         (AccessibilityUIElement):
74         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
75         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
76         (WTR::AccessibilityUIElement::pathDescription):
77         (WTR):
78
79 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
80
81         [EFL] Declare TEST_THEME_DIR in a single place.
82         https://bugs.webkit.org/show_bug.cgi?id=114285
83
84         Reviewed by Anders Carlsson.
85
86         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
87
88         * DumpRenderTree/efl/CMakeLists.txt:
89         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
90         (DumpRenderTreeChrome::createView):
91         (DumpRenderTreeChrome::createInspectorView):
92         (DumpRenderTreeChrome::initialize):
93         (DumpRenderTreeChrome::onDownloadRequest):
94         * EWebLauncher/CMakeLists.txt:
95         * EWebLauncher/main.c:
96         (findThemePath):
97         * EWebLauncher/url_bar.c:
98         (url_bar_add):
99         * MiniBrowser/efl/CMakeLists.txt:
100         * MiniBrowser/efl/main.c:
101         (window_create):
102         * TestWebKitAPI/PlatformEfl.cmake:
103         * TestWebKitAPI/efl/PlatformWebView.cpp:
104         (TestWebKitAPI::PlatformWebView::PlatformWebView):
105         * WebKitTestRunner/PlatformEfl.cmake:
106         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
107         (WTR::PlatformWebView::PlatformWebView):
108
109 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
110
111         [GTK][AC] upversion of clutter and its dependecy
112         https://bugs.webkit.org/show_bug.cgi?id=114016
113
114         Reviewed by Gustavo Noronha Silva.
115
116         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
117
118         * gtk/jhbuild-optional.modules:
119
120 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
121
122         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
123         https://bugs.webkit.org/show_bug.cgi?id=89875
124
125         Reviewed by Maciej Stachowiak.
126
127         Add unit tests to verify if the handling of the open, openat, creat syscall
128         is being done right. We check if the Read/Write/ReadAndWrite permissions
129         are respected, if the canonical path is being resolved and if
130         the permissions are falling back to the topmost parent directory with a
131         policy set when the directory being opened has no policy.
132
133         We also test if any attempt of blocking SIGSYS is silently ignored.
134         SIGSYS cannot be blocked because in it's handler is where we hook
135         syscalls to the broker process.
136
137         Also added libseccomp to EFL's jhbuild to make the life of developers
138         willing to help easier.
139
140         * Scripts/webkitperl/FeatureList.pm:
141         * TestWebKitAPI/PlatformEfl.cmake:
142         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
143         (TestWebKitAPI):
144         (SeccompEnvironment):
145         (TestWebKitAPI::SeccompEnvironment::SetUp):
146         (TestWebKitAPI::SeccompEnvironment::TearDown):
147         (TestWebKitAPI::dummyHandler):
148         (TestWebKitAPI::TEST):
149         (TestWebKitAPI::stressTest):
150         * efl/jhbuild.modules:
151         * qmake/mkspecs/features/features.pri:
152
153 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
154
155         REGRESSION: Autocorrection doesn't work in DumpRenderTree
156         https://bugs.webkit.org/show_bug.cgi?id=113846
157
158         Reviewed by Alexey Proskuryakov.
159
160         The problem was that we were replacing NSSpellCheck's dictionary with our own
161         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
162
163         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
164         and "would" respectively in DumpRenderTree.
165
166         * DumpRenderTree/mac/DumpRenderTree.mm:
167         (resetDefaultsToConsistentValues):
168
169 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
170
171         Remove the gyp files for Tools
172         https://bugs.webkit.org/show_bug.cgi?id=114248
173
174         Reviewed by Ryosuke Niwa.
175
176         * DumpRenderTree/DumpRenderTree.gyp: Removed.
177         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
178         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
179         * DumpRenderTree/DumpRenderTree.gypi: Removed.
180         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
181         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
182         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
183         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
184
185 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
186
187         WKR (new-commit-bot) is too slow
188         https://bugs.webkit.org/show_bug.cgi?id=110087
189
190         Reviewed by Geoffrey Garen.
191
192         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
193         Just run "svn log -r <revision>" instead to cut down the delay.
194
195         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
196
197         * Scripts/webkitpy/tool/commands/newcommitbot.py:
198         (NewCommitBot):
199         (NewCommitBot.next_work_item):
200         (NewCommitBot._is_empty_log):
201         (NewCommitBot._update_checkout):
202
203 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
204
205         Build fix. Can't remove appendCustomBuildFlags.
206
207         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
208         (appendCustomBuildFlags):
209
210 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
211
212         Remove Chromium builders from build.webkit.org
213         https://bugs.webkit.org/show_bug.cgi?id=113990
214
215         Reviewed by Benjamin Poulain.
216
217         Removed.
218
219         * BuildSlaveSupport/build.webkit.org-config/config.json:
220         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
221         (InstallGtkDependencies):
222         (RunUnitTests.start):
223         (RunWebKit2Tests.start):
224         (Factory.__init__):
225         (unitTestsSupported):
226         (TestFactory.__init__):
227         (BuildAndTestFactory.__init__):
228         (BuildAndPerfTestFactory.__init__):
229         (BuildAndPerfTestWebKit2Factory.__init__):
230         (DownloadAndPerfTestFactory.__init__):
231         (loadBuilderConfig):
232         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
233
234 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
235
236         Remove HTML Notification
237         https://bugs.webkit.org/show_bug.cgi?id=114231
238
239         Reviewed by Ryosuke Niwa.
240
241         * qmake/mkspecs/features/features.pri:
242
243 2013-04-08  Glenn Adams  <glenn@skynav.com>
244
245         Remove chromium EWS support, and fix broken test.
246         https://bugs.webkit.org/show_bug.cgi?id=114221
247
248         Reviewed by Ryosuke Niwa.
249
250         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
251         (AbstractChromiumEWS): Removed.
252         (ChromiumLinuxEWS): Removed.
253         (ChromiumLinuxDebugEWS): Removed.
254         (ChromiumWindowsEWS): Removed.
255         (ChromiumAndroidEWS): Removed.
256         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
257         (EarlyWarningSystemTest): Fix misspelled class name.
258         (test_ewses): Fix entry point name to ensure test is run.
259
260 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
261
262         [WIN] Remove WebKit2 source code
263         https://bugs.webkit.org/show_bug.cgi?id=114096
264
265         Reviewed by Anders Carlsson.
266
267         Remove the windows specific parts of the MiniBrowser.
268
269         * MiniBrowser/MiniBrowser.vcproj: Removed.
270         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
271         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
272         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
273         * MiniBrowser/win/BrowserView.cpp: Removed.
274         * MiniBrowser/win/BrowserView.h: Removed.
275         * MiniBrowser/win/BrowserWindow.cpp: Removed.
276         * MiniBrowser/win/BrowserWindow.h: Removed.
277         * MiniBrowser/win/MiniBrowser.cpp: Removed.
278         * MiniBrowser/win/MiniBrowser.h: Removed.
279         * MiniBrowser/win/MiniBrowser.rc: Removed.
280         * MiniBrowser/win/main.cpp: Removed.
281         * MiniBrowser/win/resource.h: Removed.
282         * MiniBrowser/win/stdafx.cpp: Removed.
283         * MiniBrowser/win/stdafx.h: Removed.
284
285 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
286
287         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
288
289         * Scripts/webkitpy/common/config/irc.py:
290
291 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
292
293         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
294         https://bugs.webkit.org/show_bug.cgi?id=113139
295
296         Reviewed by Anders Carlsson.
297
298         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
299         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
300         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
301         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
302         (ToStringAndValueOfObject):
303         (ToStringAndValueOfObject::ToStringAndValueOfObject):
304         (ScriptableObject):
305         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
306         (ToStringAndValueOfObject::ScriptableObject::invoke):
307         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
308         (ToStringAndValueOfObject::NPP_GetValue):
309         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
310         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
311         * GNUmakefile.am:
312
313 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
314
315         [GTK] Bump gnome-themes-standard to 3.6.0
316         https://bugs.webkit.org/show_bug.cgi?id=114155
317
318         Reviewed by Martin Robinson.
319
320         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
321         dependency of gnome-themes-standard accordingly.
322
323 2013-04-08  David Levin  <levin@chromium.org>
324
325         Remove my watchlist entries.
326         https://bugs.webkit.org/show_bug.cgi?id=114180
327
328         Reviewed by Adam Barth.
329
330         * Scripts/webkitpy/common/config/committers.py:
331         * Scripts/webkitpy/common/config/watchlist:
332
333 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
334
335         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
336         https://bugs.webkit.org/show_bug.cgi?id=114161
337
338         Reviewed by Gyuyoung Kim.
339
340         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
341         as it is crashing due to Bug 111074.
342
343         * TestWebKitAPI/PlatformEfl.cmake:
344
345 2013-04-07  David Kilzer  <ddkilzer@apple.com>
346
347         Remove the rest of SVG_DOM_OBJC_BINDINGS
348         <http://webkit.org/b/114112>
349
350         Reviewed by Geoffrey Garen.
351
352         * Scripts/webkitperl/FeatureList.pm:
353         - Remove --svg-dom-objc-bindings switch.
354         * qmake/mkspecs/features/features.pri:
355         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
356
357 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
358
359         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
360         https://bugs.webkit.org/show_bug.cgi?id=114089
361
362         Reviewed by Chris Fleizach.
363
364         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
365         * DumpRenderTree/AccessibilityController.cpp:
366         * DumpRenderTree/AccessibilityUIElement.cpp:
367         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
368         (DumpRenderTreeChrome::DumpRenderTreeChrome):
369         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
370         (DumpRenderTreeChrome):
371
372 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
373
374         Build fix after r147857, remove remaining USE(JSC) guards.
375
376         Unreviewed.
377
378         * DumpRenderTree/config.h:
379         * TestWebKitAPI/config.h:
380         * WebKitTestRunner/config.h:
381
382 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
383
384         Rename sheriffbot to webkitbot
385         https://bugs.webkit.org/show_bug.cgi?id=114109
386
387         Reviewed by Benjamin Poulain.
388
389         Renamed since sheriffbot will be used in Blink.
390
391         * Scripts/webkitpy/tool/commands/sheriffbot.py:
392         (SheriffBot):
393         (SheriffBot.begin_work_queue):
394
395 2013-04-06  Oliver Hunt  <oliver@apple.com>
396
397         Unify the many and varied stack trace mechanisms, and make the result sane.
398         https://bugs.webkit.org/show_bug.cgi?id=114072
399
400         Reviewed by Filip Pizlo.
401
402         The commandline jsc executable no longer requires arguments, so
403         I've made run-jsc work without them.
404
405         * Scripts/run-jsc:
406
407 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
408
409         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
410         https://bugs.webkit.org/show_bug.cgi?id=114086
411
412         Reviewed by Tim Horton.
413
414         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
415
416 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
417
418         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
419         https://bugs.webkit.org/show_bug.cgi?id=114083
420
421         Reviewed by Ryosuke Niwa.
422
423         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
424         in TestWebKitAPI and WebKitTestRunner.
425
426         * TestWebKitAPI/config.h:
427         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
428         (TestWebKitAPI::InjectedBundleController::platformInitialize):
429         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
430         (WTR::InjectedBundle::platformInitialize):
431
432 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
433
434         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
435         https://bugs.webkit.org/show_bug.cgi?id=114094
436
437         Reviewed by Anders Carlsson.
438
439         * Scripts/run-jsc:
440
441 2013-04-05  Ojan Vafai  <ojan@chromium.org>
442
443         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
444         https://bugs.webkit.org/show_bug.cgi?id=114080
445
446         Reviewed by Ryosuke Niwa.
447
448         This way, the WebKit and Blink dashboard code can change as appropriate without
449         needing to consider the other project's needs. This still doesn't update the
450         buildbots to upload to the new location, or the dashboard code to pull the
451         results.json files from the new location, but it at least allows for changing the
452         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
453
454         * TestResultServer/app.yaml:
455
456 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
457
458         Re-enable testing on the commit queue
459         https://bugs.webkit.org/show_bug.cgi?id=114078
460
461         Reviewed by Darin Adler.
462
463         Re-enabled the feature and the associated tests.
464
465         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
466         (CommitQueueTask.run):
467         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
468         (CommitQueueTaskTest._run_through_task):
469         * Scripts/webkitpy/tool/commands/queues_unittest.py:
470         (CommitQueueTest._mock_test_result):
471
472 2013-04-05  Oliver Hunt  <oliver@apple.com>
473
474         Unify the many and varied stack trace mechanisms, and make the result sane.
475         https://bugs.webkit.org/show_bug.cgi?id=114072
476
477         Reviewed by Filip Pizlo.
478
479         The commandline jsc executable no longer requires arguments, so
480         I've made run-jsc work without them.
481
482         * Scripts/run-jsc:
483
484 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
485
486         AX: Make SVG Group containers accessible elements
487         https://bugs.webkit.org/show_bug.cgi?id=113939
488
489         Reviewed by Simon Fraser.
490
491         Implement axController.elementAtPoint for iOS.
492         Implement a correct version of clickPoint for iOS.
493
494         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
495         (AccessibilityController::elementAtPoint):
496         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
497         (AccessibilityUIElement::clickPointX):
498         (AccessibilityUIElement::clickPointY):
499
500 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
501
502         Unreviewed, rolling out r147773 and r147774.
503         http://trac.webkit.org/changeset/147773
504         http://trac.webkit.org/changeset/147774
505         https://bugs.webkit.org/show_bug.cgi?id=114056
506
507         Causing some exceptions on AppEngine I don't understand
508         (Requested by rniwa on #webkit).
509
510         * QueueStatusServer/config/queues.py:
511         * QueueStatusServer/model/queues.py:
512         (Queue.short_name):
513         (Queue.display_name):
514         * QueueStatusServer/model/queues_unittest.py:
515         (QueueTest.test_short_name):
516         (QueueTest.test_display_name):
517         (QueueTest.test_name_with_underscores):
518
519 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
520
521         Fixed run-bindings-tests by removing V8
522         https://bugs.webkit.org/show_bug.cgi?id=114053
523
524         Reviewed by Benjamin Poulain.
525
526         * Scripts/run-bindings-tests:
527         (main):
528
529 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
530
531         Build fix.
532
533         * QueueStatusServer/model/queues.py:
534         (Queue.short_name):
535         (Queue.display_name):
536
537 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
538
539         Remove Chromium EWS bots from the queue status server
540         https://bugs.webkit.org/show_bug.cgi?id=113988
541
542         Reviewed by Benjamin Poulain.
543
544         Removed Chromium EWS bots.
545
546         * QueueStatusServer/config/queues.py:
547         * QueueStatusServer/model/queues.py:
548         (Queue.short_name):
549         (Queue.display_name):
550         * QueueStatusServer/model/queues_unittest.py:
551         (QueueTest.test_short_name):
552         (QueueTest.test_display_name):
553         (QueueTest.test_name_with_underscores):
554
555 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
556
557         [EFL] Enable indexed database
558         https://bugs.webkit.org/show_bug.cgi?id=107248
559
560         Reviewed by Alexis Menard.
561
562         * Scripts/webkitperl/FeatureList.pm:
563
564 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
565
566         Remove vestiges of Chromium bits from watchlists.
567         https://bugs.webkit.org/show_bug.cgi?id=114047
568
569         Reviewed by Ryosuke Niwa.
570
571         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
572
573 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
574
575         Add James Craig to the contributors list.
576
577         * Scripts/webkitpy/common/config/committers.py:
578
579 2013-04-04  Kent Tamura  <tkent@chromium.org>
580
581         Remove ChromiumPublicApi pattern, and cc/message rules for it.
582
583         * Scripts/webkitpy/common/config/watchlist:
584
585 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
586
587         Temporarily disable the Python unittests broken by the commit queue not running layout tests
588         https://bugs.webkit.org/show_bug.cgi?id=113997
589
590         Reviewed by Ryosuke Niwa.
591
592         Disable the tests until Ryosuke gets the time and hardware to have
593         a testing commit-queue.
594
595         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
596         (CommitQueueTaskTest):
597         * Scripts/webkitpy/tool/commands/queues_unittest.py:
598         (CommitQueueTest):
599
600 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
601
602         Remove Chromium builders from build.webkit.org
603         https://bugs.webkit.org/show_bug.cgi?id=113990
604
605         Reviewed by Benjamin Poulain.
606
607         Land the part to disable triggering of Chromium builders first so that we may start
608         deleting more Chromium code that breaks the update step.
609
610         * BuildSlaveSupport/build.webkit.org-config/config.json:
611
612 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
613
614         Remove Chromium's DumpRenderTree
615         https://bugs.webkit.org/show_bug.cgi?id=113989
616
617         Reviewed by Kent Tamura.
618
619         On second thought, let's not go to Camelot. It is a silly place.
620
621         * DumpRenderTree/mac/DumpRenderTree.mm:
622         (resetDefaultsToConsistentValues):
623
624 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
625
626         Nixed the defunct chromium folder from DumpRenderTree
627         https://bugs.webkit.org/show_bug.cgi?id=113993
628
629         Reviewed by Ryosuke Niwa.
630
631         * DumpRenderTree/chromium: Removed.
632         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
633         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
634         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
635         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
636         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
637         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
638         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
639         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
640         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
641         * DumpRenderTree/chromium/MockPlatform.h: Removed.
642         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
643         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
644         * DumpRenderTree/chromium/Task.cpp: Removed.
645         * DumpRenderTree/chromium/Task.h: Removed.
646         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
647         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
648         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
649         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
650         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
651         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
652         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
653         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
654         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
655         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
656         * DumpRenderTree/chromium/TestRunner: Removed.
657         * DumpRenderTree/chromium/TestRunner/public: Removed.
658         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
659         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
660         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
661         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
662         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
663         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
664         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
665         * DumpRenderTree/chromium/TestRunner/src: Removed.
666         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
667         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
668         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
669         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
670         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
671         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
672         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
673         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
674         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
675         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
676         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
677         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
678         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
679         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
680         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
681         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
682         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
683         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
684         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
685         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
686         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
687         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
688         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
689         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
690         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
691         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
692         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
693         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
694         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
695         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
696         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
697         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
698         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
699         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
700         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
701         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
702         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
703         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
704         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
705         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
706         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
707         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
708         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
709         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
710         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
711         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
712         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
713         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
714         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
715         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
716         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
717         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
718         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
719         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
720         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
721         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
722         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
723         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
724         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
725         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
726         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
727         * DumpRenderTree/chromium/TestShell.cpp: Removed.
728         * DumpRenderTree/chromium/TestShell.h: Removed.
729         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
730         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
731         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
732         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
733         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
734         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
735         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
736         * DumpRenderTree/chromium/WebViewHost.h: Removed.
737         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
738         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
739         * DumpRenderTree/chromium/config.h: Removed.
740         * DumpRenderTree/chromium/fonts.conf: Removed.
741
742 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
743
744         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
745
746         Rubber stamped by Benjamin Poulain.
747
748         * RebaselineQueueServer: Removed.
749         * RebaselineQueueServer/app.yaml: Removed.
750         * RebaselineQueueServer/handlers: Removed.
751         * RebaselineQueueServer/handlers/__init__.py: Removed.
752         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
753         * RebaselineQueueServer/handlers/pages.py: Removed.
754         * RebaselineQueueServer/index.yaml: Removed.
755         * RebaselineQueueServer/main.py: Removed.
756         * RebaselineQueueServer/model: Removed.
757         * RebaselineQueueServer/model/__init__.py: Removed.
758         * RebaselineQueueServer/model/queueentry.py: Removed.
759         * RebaselineQueueServer/static: Removed.
760         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
761         * RebaselineQueueServer/static/styles.css: Removed.
762         * RebaselineQueueServer/templates: Removed.
763         * RebaselineQueueServer/templates/builder-picker.html: Removed.
764         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
765         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
766         * RebaselineQueueServer/templates/home.html: Removed.
767
768 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
769
770         Fix setup-commit-queue and temporarily disable testing on commit-queue
771         https://bugs.webkit.org/show_bug.cgi?id=113979
772
773         Reviewed by Benjamin Poulain.
774
775         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
776         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
777
778         * EWSTools/setup-commit-queue.sh:
779         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
780         (CommitQueueTask.run):
781
782 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
783
784         temporarily make flakiness dashboard work again webkit.org bots
785         https://bugs.webkit.org/show_bug.cgi?id=113972
786
787         Reviewed by Ojan Vafai.
788
789         This patch disables the chromium.org layout test bots TestExpectations
790         parsing temporarily until we can work out the right way to split into
791         two instances for webkit.org and chromium.org and figure out which
792         code to delete where :).
793
794         * TestResultServer/static-dashboards/flakiness_dashboard.js:
795
796 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
797
798         Fix webkitpy tests after r147678.
799
800         * Scripts/webkitpy/tool/commands/queues_unittest.py:
801         (CommitQueueTest.test_commit_queue):
802         (test_manual_reject_during_processing):
803
804 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
805
806         The commit queue should use Mac MountainLion port
807         https://bugs.webkit.org/show_bug.cgi?id=113971
808
809         Reviewed by Lucas Forschler.
810
811         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
812         * Scripts/webkitpy/tool/commands/queues.py:
813         (CommitQueue):
814
815 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
816
817         turn off running tests on chromium linux EWS bots
818         https://bugs.webkit.org/show_bug.cgi?id=113959
819
820         Reviewed by Geoffrey Garen.
821
822         Now that the Chromium port is no longer being maintained
823         there's little point in running the tests. Soon we should
824         just shut this bot off altogether.
825
826         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
827         (ChromiumLinuxEWS):
828
829 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
830
831         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
832
833         * Scripts/webkitpy/common/config/watchlist:
834
835 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
836
837         Indentation fix to get webkit-patch working again after r147625
838
839         Unreviewed.
840
841         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
842         (MacEWS):
843         (MacWK2EWS):
844
845 2013-04-04  Lucas Forschler  <lforschler@apple.com>
846
847         Turn tests back on for Mac WK1/WK2 EWS.
848         
849         Unreviewed.
850         
851         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
852         (MacEWS):
853         (MacWK2EWS):
854
855 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
856
857         [GTK][WK2] MiniBrowser custom URI scheme support
858         https://bugs.webkit.org/show_bug.cgi?id=112419
859
860         Reviewed by Carlos Garcia Campos.
861
862         Add support for about URIs in MiniBrowser. An example about page is show
863         with URI "about:minibrowser", the rest of the cases it will show a
864         proper message explaining that the about page didn't exist.
865
866         Internally it uses "minibrowser-about" prefix instead of "about", but
867         from the user point of view it works with "about" prefix.
868
869         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
870         (getInternalURI): Method to convert URIs from "about" prefix to
871         "minibrowser-about".
872         (getExternalURI): Opposite method.
873         (webViewURIChanged): Use "about" prefix to show the URI to users.
874         (webViewEnterFullScreen): Ditto.
875         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
876         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
877         (aboutURISchemeRequestCallback): Callback to manage about calls.
878         (main): Register the URI scheme to manage about URIs.
879
880 2013-04-03  Roger Fong  <roger_fong@apple.com>
881
882         Re-enable WinEWS tests.
883
884         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
885         (WinEWS):
886
887 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
888
889         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
890         https://bugs.webkit.org/show_bug.cgi?id=113883
891
892         Reviewed by Martin Robinson.
893
894         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
895         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
896         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
897
898 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
899
900         [GTK] Include Pango in jhbuild-optional.modules
901         https://bugs.webkit.org/show_bug.cgi?id=113878
902
903         Reviewed by Martin Robinson.
904
905         Since r147547 Pango 1.32.0 is required. Including the module in the
906         JHBuild optional moduleset.
907
908         * gtk/jhbuild-optional.modules: Add Pango module.
909
910 2013-04-03  Zeno Albisser  <zeno@webkit.org>
911
912         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
913         https://bugs.webkit.org/show_bug.cgi?id=113864
914
915         Moving setDefersLoading from TestRunnerQt to TestRunner
916         requires access to the non-Qt TestRunner.
917         As long as we instantiate both TestRunner and TestRunnerQt,
918         we need a separate getter for the non-Qt TestRunner instance.
919
920         Reviewed by Simon Hausmann.
921
922         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
923         (WebPage::resetSettings):
924         * DumpRenderTree/qt/DumpRenderTreeQt.h:
925         (DumpRenderTree::jscTestRunner):
926         * DumpRenderTree/qt/TestRunnerQt.cpp:
927         (TestRunner::setDefersLoading):
928             Moving setDefersLoading from TestRunnerQt
929             to TestRunner.
930         * DumpRenderTree/qt/TestRunnerQt.h:
931         (TestRunnerQt):
932
933 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
934
935         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
936         https://bugs.webkit.org/show_bug.cgi?id=104779
937
938         Reviewed by Carlos Garcia Campos.
939
940         * Scripts/run-gtk-tests:
941         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
942         passing in current trunk.
943
944 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
945
946         Fix HAVE(QTTESTSUPPORT) logic
947
948         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
949         resulting in HAVE(QTTESTSUPPORT) never being true.
950         Move that logic down in sanitizeFeatures.
951
952         Rubber-stamped by Tor Arne Vestbø.
953
954         * qmake/mkspecs/features/features.prf:
955
956 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
957
958         [GTK] Bump required versions of some dependencies
959         https://bugs.webkit.org/show_bug.cgi?id=113282
960
961         Reviewed by Martin Robinson.
962
963         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
964
965 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
966
967         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
968         https://bugs.webkit.org/show_bug.cgi?id=113809
969
970         Reviewed by Philippe Normand.
971
972         Newer Linux kernels have removed some deprecated macros from v4l2
973         headers, causing gst-plugins-good's build to break. We don't need it
974         right now, so just disable it.
975
976         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
977
978 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
979
980         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
981         https://bugs.webkit.org/show_bug.cgi?id=113535
982
983         Reviewed by Simon Hausmann.
984
985         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
986
987         * qmake/mkspecs/features/features.prf:
988
989 2013-04-03  Zeno Albisser  <zeno@webkit.org>
990
991         [Qt] Move logic of simple forwarding functions to TestRunner.
992         https://bugs.webkit.org/show_bug.cgi?id=113863
993
994         Reviewed by Simon Hausmann.
995
996         * DumpRenderTree/qt/TestRunnerQt.cpp:
997         (TestRunner::setTextDirection):
998         (TestRunner::goBack):
999         (TestRunner::evaluateScriptInIsolatedWorld):
1000         (TestRunner::addUserStyleSheet):
1001         * DumpRenderTree/qt/TestRunnerQt.h:
1002         (TestRunnerQt):
1003
1004 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1005
1006         [Qt] Disable media support using QuickTime if deployment target != SDK
1007
1008         We link to a single libWebKitSystemInterface static lib, so unless the
1009         deployment target matches the SDK let's not pretend like we'll be able
1010         to run on anything lower than the SDK version.
1011
1012         Reviewed by Simon Hausmann.
1013
1014         * qmake/mkspecs/features/features.prf:
1015
1016 2013-04-02  James Craig  <james@cookiecrook.com>
1017
1018         AXRoleDescripton for DL is "list"; should be "description list"
1019         https://bugs.webkit.org/show_bug.cgi?id=111665
1020
1021         Reviewed by Chris Fleizach.
1022
1023         Defining the role and description strings.
1024
1025         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1026
1027 2013-04-02  Roger Fong  <roger_fong@apple.com>
1028
1029         Unreviewed. Disable running tests on Win EWS queue.
1030
1031         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1032         (WinEWS):
1033
1034 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1035
1036         Disable running tests on the MAC WK2 EWS queue.
1037         
1038         Unreviewed.
1039         
1040         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1041         (MacWK2EWS):
1042
1043 2013-04-02  Julie Parent  <jparent@chromium.org>
1044
1045         Dashboard refactor: Move dashboard specific history related features to History.
1046         https://bugs.webkit.org/show_bug.cgi?id=113717
1047
1048         Reviewed by Ojan Vafai.
1049         
1050         Each dashboard now creates its own History object, with a custom
1051         configuration. This changes from just overriding global functions
1052         to passing in callbacks for generatePage, handleValidHashParameter,
1053         and handleQueryParameterChange. Same with passing in defaultStateValues
1054         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1055         variables.
1056         
1057         All functions related to these features are now (mostly) private
1058         function on History. 
1059         
1060         Loader no longer needs a loadingComplete callback, since it can just
1061         initialize the history object itself.
1062
1063         * TestResultServer/static-dashboards/aggregate_results.js:
1064         (handleValidHashParameter):
1065         * TestResultServer/static-dashboards/dashboard_base.js:
1066         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1067         (generatePage):
1068         (.switch.return):
1069         (handleQueryParameterChange):
1070         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1071         (resetGlobals):
1072         * TestResultServer/static-dashboards/history.js:
1073         (.):
1074         * TestResultServer/static-dashboards/loader.js:
1075         (.):
1076         * TestResultServer/static-dashboards/loader_unittests.js:
1077         * TestResultServer/static-dashboards/timeline_explorer.js:
1078         (generatePage):
1079         (initCurrentBuilderTestResults):
1080         * TestResultServer/static-dashboards/treemap.js:
1081         (generatePage):
1082         (.switch.return):
1083         (handleQueryParameterChange):
1084
1085 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1086
1087         Unreviewed, rolling out r147401.
1088         http://trac.webkit.org/changeset/147401
1089         https://bugs.webkit.org/show_bug.cgi?id=113767
1090
1091         The patch makes it extremely hard to set up the dependencies
1092         properly on the GTK builders (Requested by zdobersek on
1093         #webkit).
1094
1095         * gtk/jhbuild.modules:
1096
1097 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1098
1099         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1100         https://bugs.webkit.org/show_bug.cgi?id=113382
1101
1102         Reviewed by Gyuyoung Kim.
1103
1104         Do not show the empty tooltip box if the text is null.
1105
1106         * MiniBrowser/efl/main.c:
1107         (popup_menu_populate):
1108
1109 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         [GTK] Bump required versions of some dependencies
1112         https://bugs.webkit.org/show_bug.cgi?id=113282
1113
1114         Reviewed by Martin Robinson.
1115
1116         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1117
1118 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1119
1120         Unreviewed, rolling out r147319.
1121         http://trac.webkit.org/changeset/147319
1122         https://bugs.webkit.org/show_bug.cgi?id=113707
1123
1124         The unit test is still failing on the buildbot (Requested by
1125         zdobersek on #webkit).
1126
1127         * Scripts/run-gtk-tests:
1128         (TestRunner):
1129
1130 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1131
1132         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1133         https://bugs.webkit.org/show_bug.cgi?id=104779
1134
1135         Reviewed by Carlos Garcia Campos.
1136
1137         * Scripts/run-gtk-tests:
1138         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1139         passing in current trunk.
1140
1141 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1142
1143         Unreviewed, rolling out r147289.
1144         http://trac.webkit.org/changeset/147289
1145         https://bugs.webkit.org/show_bug.cgi?id=113678
1146
1147         broke Win7 (dbg) build (Requested by shinyak|gardener on
1148         #webkit).
1149
1150         * DumpRenderTree/DumpRenderTree.gypi:
1151         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1152         (WebTestRunner):
1153         (WebUserMediaClientMock):
1154         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1155         (WebTestRunner::WebUserMediaClientMock::taskList):
1156         * Scripts/webkitpy/style/checkers/cpp.py:
1157         (check_function_definition):
1158
1159 2013-03-31  Adam Barth  <abarth@webkit.org>
1160
1161         configure-svn-config.sh fails
1162         https://codereview.chromium.org/13392007/
1163
1164         Reviewed by Eric Seidel.
1165
1166         This script was trying to use "svn checkout" to dowload a file from
1167         svn.webkit.org, but "svn checkout" only works with directories.
1168         Instead, we should use "svn export".
1169
1170         * EWSTools/configure-svn-config.sh:
1171
1172 2013-03-31  Wei Jia  <wjia@chromium.org>
1173
1174         Allow WebUserMediaClientMock to be used by client
1175         https://bugs.webkit.org/show_bug.cgi?id=113633
1176
1177         Reviewed by Adam Barth.
1178
1179         Export WebUserMediaClientMock.
1180         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1181
1182         * DumpRenderTree/DumpRenderTree.gypi:
1183         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1184         (WebUserMediaClientMock):
1185         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1186         * Scripts/webkitpy/style/checkers/cpp.py:
1187         (check_function_definition):
1188
1189 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1190
1191         Expose FeatureObserver data to WebKit clients
1192         https://bugs.webkit.org/show_bug.cgi?id=113613
1193
1194         Reviewed by Sam Weinig.
1195
1196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1197         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1198
1199 2013-03-29  Greg Hughes  <ghughes@apple.com>
1200
1201         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1202         https://bugs.webkit.org/show_bug.cgi?id=112276
1203
1204         Reviewed by Chris Fleizach.
1205
1206         Added support to test accessibility search predicates with multiple keys.  
1207
1208         * DumpRenderTree/AccessibilityUIElement.cpp:
1209         (uiElementForSearchPredicateCallback):
1210         * DumpRenderTree/AccessibilityUIElement.h:
1211         (AccessibilityUIElement):
1212         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1213         (AccessibilityUIElement::uiElementForSearchPredicate):
1214         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1215         (AccessibilityUIElement::uiElementForSearchPredicate):
1216         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1217         (AccessibilityUIElement::uiElementForSearchPredicate):
1218         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1219         (AccessibilityUIElement::uiElementForSearchPredicate):
1220         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1221         (AccessibilityUIElement::uiElementForSearchPredicate):
1222         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1223         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1224         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1225         (AccessibilityUIElement):
1226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1227         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1228         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1229         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1230         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1231
1232 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1233
1234         Fix a typo in r147147 to fix Mac EWS.
1235
1236         * Scripts/webkitpy/tool/commands/queues.py:
1237         (PatchProcessingQueue._new_port_name_from_old):
1238
1239 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1240
1241         [EFL] Build break with latest EFL libraries after r146265
1242         https://bugs.webkit.org/show_bug.cgi?id=113558
1243
1244         Unreviewed build fix.
1245
1246         * TestWebKitAPI/PlatformWebView.h:
1247         * WebKitTestRunner/PlatformWebView.h:
1248
1249 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1250
1251         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1252
1253         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1254         in libgcrypt build.
1255
1256 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1257
1258         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1259
1260         Unreviewed.
1261
1262         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1263         (MacEWS):
1264
1265 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1266
1267         Use the right OS name on Mac EWS instead of mac-future.
1268
1269         Rubber-stamped by Dirk Pranke.
1270
1271         * Scripts/webkitpy/tool/commands/queues.py:
1272         (PatchProcessingQueue._new_port_name_from_old):
1273         (PatchProcessingQueue.begin_work_queue):
1274         (PatchProcessingQueue._upload_results_archive_for_patch):
1275
1276 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1277
1278         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1279         https://bugs.webkit.org/show_bug.cgi?id=112546
1280
1281         Reviewed by Martin Robinson.
1282
1283         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1284         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1285
1286 2013-03-28  Ming Xie  <mxie@blackberry.com>
1287
1288         [BlackBerry] Committer Email Updates
1289         https://bugs.webkit.org/show_bug.cgi?id=113435
1290
1291         Reviewed by Rob Buis.
1292
1293         Add the @blackberry.com email address for all our BlackBerry
1294         WebKit committers. This is the first step for our email address
1295         migration.
1296
1297         * Scripts/webkitpy/common/config/committers.py:
1298
1299 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1300
1301         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1302         https://bugs.webkit.org/show_bug.cgi?id=113508
1303
1304         Reviewed by Martin Robinson.
1305
1306         Prevent the GStreamer plugin scanner to load system-wide
1307         plugins. Only the ones built in JHBuild should be loaded and used
1308         at runtime.
1309
1310         * efl/jhbuildrc:
1311         * gtk/jhbuildrc:
1312
1313 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1314
1315         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1316         https://bugs.webkit.org/show_bug.cgi?id=113386
1317
1318         Reviewed by Carlos Garcia Campos.
1319
1320         * Scripts/webkitdirs.pm:
1321         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1322         version to 3.0. Reflect this change so the builtDylibPathForName
1323         function doesn't fail to report the library as found.
1324
1325 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1326
1327         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1328         https://bugs.webkit.org/show_bug.cgi?id=113484
1329
1330         Unreviewed build fix.
1331
1332         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1333
1334         * TestWebKitAPI/CMakeLists.txt:
1335         * WebKitTestRunner/CMakeLists.txt:
1336
1337 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1338
1339         Revision for the internal jhbuild is too old
1340         https://bugs.webkit.org/show_bug.cgi?id=113324
1341
1342         Reviewed by Martin Robinson.
1343
1344         Update the minimum required version to a point where jhbuild won't
1345         fail installing packages when trying to remove a symlink to a directory.
1346
1347         * jhbuild/jhbuild-wrapper: Updated revision.
1348
1349 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1350
1351         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1352         https://bugs.webkit.org/show_bug.cgi?id=113203
1353
1354         Reviewed by Philippe Normand.
1355
1356         We build our libsoup without GNOME support. gst-plugins-good does separate
1357         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1358         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1359         build failures as the headers of those diverge. We do not use souphttpsrc, so
1360         disable it when building gst-plugins-good.
1361
1362         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1363
1364 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1365
1366         Build fix after r146852. Please another reference to the Lion leaks builder.
1367
1368         * BuildSlaveSupport/build.webkit.org-config/config.json:
1369
1370 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1371
1372         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1373         https://bugs.webkit.org/show_bug.cgi?id=113421
1374
1375         Reviewed by Dirk Pranke.
1376
1377         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1378         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1379         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1380         in the GTK-specific TestExpectations files.
1381
1382         To avoid this only enable the warnings only when not using WKTR.
1383
1384         * Scripts/webkitpy/layout_tests/port/gtk.py:
1385         (GtkPort.warn_if_bug_missing_in_test_expectations):
1386
1387 2013-03-27  Antti Koivisto  <antti@apple.com>
1388
1389         Fix Zalan's email.
1390
1391         * Scripts/webkitpy/common/config/committers.py:
1392
1393 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1394
1395         master.cfg cleanup
1396         https://bugs.webkit.org/show_bug.cgi?id=113195
1397
1398         Reviewed by Ryosuke Niwa.
1399
1400         * BuildSlaveSupport/build.webkit.org-config/config.json:
1401         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1402
1403 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1404
1405         master.cfg fine-tuning for Qt Mountain Lion Release bot
1406         https://bugs.webkit.org/show_bug.cgi?id=113191
1407
1408         Reviewed by Ryosuke Niwa.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/config.json:
1411           - Rename the slave due to its location change.
1412           - Update the platform of the slave.
1413         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1414         (RunQtAPITests): Enable running WK2 API tests on Qt.
1415         (RunQtAPITests.start):
1416         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1417         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1418
1419 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1420
1421         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1422         https://bugs.webkit.org/show_bug.cgi?id=113403
1423
1424         Reviewed by Kenneth Rohde Christiansen.
1425
1426         As of Evas 1.7.5, when Wayland is detected on the system, support for
1427         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1428         The code, however, seems to depend on a few other flags which must be
1429         explicitly enabled.
1430
1431         If those additional GL-related options are passed, we end up
1432         having issues on the WebKit side, so disable Wayland support for
1433         now.
1434
1435         * efl/jhbuild.modules:
1436
1437 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1438
1439         Unreviewed, rolling out r146864.
1440         http://trac.webkit.org/changeset/146864
1441         https://bugs.webkit.org/show_bug.cgi?id=113391
1442
1443         causes crashes on Wk2 EFL release bot (Requested by drott on
1444         #webkit).
1445
1446         * Scripts/webkitperl/FeatureList.pm:
1447
1448 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1449
1450         [jhbuild] Correctly specify an alternate number of make jobs.
1451         https://bugs.webkit.org/show_bug.cgi?id=113396
1452
1453         Reviewed by Philippe Normand.
1454
1455         So far, we were using the `MAKEFLAGS' environment variable to pass the
1456         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1457         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1458
1459         We now behave more closely to the rest of the WebKit tools by first
1460         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1461         not set, just letting jhbuild itself figure out how many jobs to use.
1462
1463         * efl/jhbuildrc:
1464         * gtk/jhbuildrc:
1465
1466 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1467
1468         [Qt] Remove Qt specific WorkQueueItem definitions.
1469         https://bugs.webkit.org/show_bug.cgi?id=112891
1470
1471         This patch is preparation work for removing
1472         WorkQueue related code from TestRunnerQt and
1473         replacing it with generic TestRunner code.
1474
1475         Reviewed by Benjamin Poulain.
1476
1477         * DumpRenderTree/qt/TestRunnerQt.cpp:
1478         (TestRunnerQt::queueBackNavigation):
1479         (TestRunnerQt::queueForwardNavigation):
1480         (TestRunnerQt::queueLoadHTMLString):
1481         (TestRunnerQt::queueReload):
1482         (TestRunnerQt::queueLoadingScript):
1483         (TestRunnerQt::queueNonLoadingScript):
1484         (TestRunner::queueLoad):
1485         * DumpRenderTree/qt/TestRunnerQt.h:
1486         (TestRunnerQt):
1487         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1488         (LoadItem::invoke):
1489         (LoadHTMLStringItem::invoke):
1490         (LoadAlternateHTMLStringItem::invoke):
1491         (ReloadItem::invoke):
1492         (ScriptItem::invoke):
1493         (BackForwardItem::invoke):
1494         * DumpRenderTree/qt/WorkQueueItemQt.h:
1495         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1496         (LoadAlternateHTMLStringItem):
1497
1498 2013-03-26  Julie Parent  <jparent@chromium.org>
1499
1500         Flakiness dashboard: simplify logic around which tests to show.
1501         https://bugs.webkit.org/show_bug.cgi?id=113250
1502
1503         Reviewed by Ojan Vafai.
1504         
1505         The different filters for showing results are only used for layout
1506         tests, otherwise, we show everything.
1507         
1508         Change the defaults to false (what layout tests used), and only
1509         look at the values when viewing layout tests.
1510
1511         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1512         (htmlForTestsWithExpectationsButNoFailures):
1513         (shouldHideTest):
1514
1515 2013-03-26  Isaac Levy  <ilevy@google.com>
1516
1517         Update bots on test-results.appspot
1518         https://bugs.webkit.org/show_bug.cgi?id=113333
1519
1520         Reviewed by Ojan Vafai.
1521
1522         * TestResultServer/static-dashboards/builders.jsonp:
1523
1524 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1525
1526         Unreviewed GTK gardening.
1527
1528         * Scripts/run-gtk-tests:
1529         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1530
1531 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1532
1533         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1534         https://bugs.webkit.org/show_bug.cgi?id=113287
1535
1536         Reviewed by Jocelyn Turcotte.
1537
1538         * Scripts/run-qtwebkit-tests:
1539         (Options.__init__):
1540
1541 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1542
1543         [EFL] Enable IndexedDB by default
1544         https://bugs.webkit.org/show_bug.cgi?id=107248
1545
1546         Reviewed by Laszlo Gombos.
1547
1548         * Scripts/webkitperl/FeatureList.pm:
1549         Enable IndexedDB by default on EFL.
1550
1551 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1552
1553         Sheriffbot should explain rollout failures in a human readable form.
1554         https://bugs.webkit.org/show_bug.cgi?id=107092
1555
1556         Reviewed by Ryosuke Niwa.
1557
1558         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1559
1560         * Scripts/webkitpy/tool/bot/irc_command.py:
1561         (Rollout._check_diff_failure):
1562         (Rollout.execute):
1563         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1564         (IRCCommandTest.test_rollout):
1565
1566 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1567
1568         Unreviewed GTK gardening.
1569
1570         * Scripts/run-gtk-tests:
1571         (TestRunner): Skipping a failing unit test after r146518.
1572
1573 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1574
1575         Remove Lion leaks builder
1576         https://bugs.webkit.org/show_bug.cgi?id=113252
1577
1578         Reviewed by Andreas Kling.
1579
1580         Removed.
1581
1582         * BuildSlaveSupport/build.webkit.org-config/config.json:
1583
1584 2013-03-25  Kent Tamura  <tkent@chromium.org>
1585
1586         Rename ENABLE_INPUT_TYPE_DATETIME
1587         https://bugs.webkit.org/show_bug.cgi?id=113254
1588
1589         Reviewed by Kentaro Hara.
1590
1591         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1592         Actually I'd like to remove the code, but we shouldn't remove it yet
1593         because we shipped products with it on some platforms.
1594
1595         * Scripts/webkitperl/FeatureList.pm:
1596         * qmake/mkspecs/features/features.pri:
1597
1598 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1599
1600         Remove one more line that was intended to be removed in r146657.
1601
1602         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1603         (summarize_results):
1604
1605 2013-03-25  Roger Fong  <roger_fong@apple.com>
1606
1607         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1608         Re-enable WinEWS tests.
1609
1610         * Scripts/webkitpy/common/config/ports.py:
1611         (WinPort.run_bindings_tests_command):
1612         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1613         (WinEWS):
1614
1615 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1616
1617         Unreviewed, rolling out r146793.
1618         http://trac.webkit.org/changeset/146793
1619         https://bugs.webkit.org/show_bug.cgi?id=113248
1620
1621         Fix did not work (Requested by rfong on #webkit).
1622
1623         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1624         (WinEWS):
1625
1626 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1627
1628         REGRESSION(r146657): Test failures reported incorrectly
1629         https://bugs.webkit.org/show_bug.cgi?id=113223
1630
1631         Reviewed by Dirk Pranke.
1632
1633         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1634
1635         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1636         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1637
1638         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1639         (Manager.run):
1640
1641         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1642         (RunDetails.__init__):
1643         (summarize_results): Remove the line I intended to remove in r146657.
1644
1645         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1646         (logging_run): Return details instead of the exit code.
1647         (run_and_capture): Ditto.
1648
1649         (RunTest.test_full_results_html):
1650         (RunTest.test_hung_thread):
1651         (RunTest.test_no_tests_found):
1652         (RunTest.test_no_tests_found_2):
1653         (RunTest.test_repeat_each_iterations_num_tests):
1654         (RunTest.test_run_singly_actually_runs_tests):
1655         (RunTest.test_test_list):
1656         (RunTest.test_missing_and_unexpected_results):
1657         (RunTest.test_pixel_test_directories):
1658         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1659         (RunTest.test_crash_with_stderr):
1660         (RunTest.test_no_image_failure_with_image_diff):
1661         (RunTest.test_crash_log):
1662         (RunTest.test_exit_after_n_failures_upload):
1663         (RunTest.test_results_directory_absolute):
1664         (RunTest.test_results_directory_relative):
1665         (RunTest.test_retrying_and_flaky_tests):
1666         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1667         (RunTest.test_retrying_uses_retries_directory):
1668         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1669         (RunTest.test_output_diffs):
1670         (EndToEndTest.test_reftest_with_two_notrefs):
1671         (RebaselineTest.test_reset_results):
1672         (RebaselineTest.test_missing_results):
1673         (RebaselineTest.test_new_baseline):
1674
1675         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1676         (BuildBotPrinter.print_results):
1677         (BuildBotPrinter.print_unexpected_results):
1678         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1679         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1680
1681 2013-03-25  Julie Parent  <jparent@chromium.org>
1682
1683         Dashboard refactor: Move cross dashboard history related code into history.js.
1684         https://bugs.webkit.org/show_bug.cgi?id=113104
1685
1686         Reviewed by Ojan Vafai.
1687
1688         All functions relating to cross dashboard behavior move from being
1689         globals to methods on the history.History object. Names stay the same,
1690         except many are made private, ones that should have been constants now
1691         are, and the long standing TODO to change "currentState" to 
1692         dashboardSpecificState is done.
1693         
1694         We now create a global history object in dashboard_base, as an 
1695         intermediate measure.  Once the dashboard specific code is
1696         added to history, each DB will need to create its own, and this
1697         global will be eliminated.
1698         
1699         * TestResultServer/static-dashboards/aggregate_results.js:
1700         (handleValidHashParameter):
1701         (htmlForBuilder):
1702         (rawValuesHTML):
1703         * TestResultServer/static-dashboards/dashboard_base.js:
1704         (parseDashboardSpecificParameters):
1705         (defaultValue):
1706         (currentBuilderGroupCategory):
1707         (currentBuilderGroupName):
1708         (handleLocationChange):
1709         (expectationsMap):
1710         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1711         (generatePage):
1712         (.switch.return):
1713         (platformAndBuildType):
1714         (individualTests):
1715         (substringList):
1716         (processMissingAndExtraExpectations):
1717         (pathToFailureLog):
1718         (showPopupForBuild):
1719         (htmlForTestsWithExpectationsButNoFailures):
1720         (shouldHideTest):
1721         (isCrossBuilderView):
1722         (tableHeaders):
1723         (htmlForSingleTestRow):
1724         (htmlForTableColumnHeader):
1725         (generatePageForExpectationsUpdate):
1726         (handleUpdate):
1727         (nextUpdate):
1728         (setUpdateIndex):
1729         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1730         (.appendExpectationsItem):
1731         (loadExpectations):
1732         (.dummyNode.onload):
1733         (loadExpectationsLayoutTests):
1734         (appendExpectations):
1735         (htmlForNavBar):
1736         (checkBoxToToggleState):
1737         (linkHTMLToToggleState):
1738         (generatePageForBuilder):
1739         (isInvalidKeyForCrossBuilderView):
1740         (handleQueryParameterChange):
1741         (showLegend):
1742         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1743         (resetGlobals):
1744         (test):
1745         * TestResultServer/static-dashboards/history.js:
1746         (.):
1747         * TestResultServer/static-dashboards/history_unittests.js:
1748         * TestResultServer/static-dashboards/loader.js:
1749         (.):
1750         * TestResultServer/static-dashboards/loader_unittests.js:
1751         * TestResultServer/static-dashboards/timeline_explorer.js:
1752         (generatePage):
1753         (initCurrentBuilderTestResults):
1754         (selectBuild):
1755         (showResultsDelta):
1756         * TestResultServer/static-dashboards/treemap.js:
1757         (generatePage):
1758         (.switch.return):
1759         (handleFocus):
1760         * TestResultServer/static-dashboards/ui.js:
1761
1762 2013-03-25  Roger Fong  <roger_fong@apple.com>
1763
1764         Unreviewed. Enable WinEWS tests again.
1765
1766         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1767         (WinEWS):
1768
1769 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1770
1771         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1772         https://bugs.webkit.org/show_bug.cgi?id=112166
1773
1774         HarfBuzz 0.9.14 merged my patch for icu detection without
1775         pkg-config files, as needed by for example Ubuntu 12.04.
1776         This obsoletes our local workaround. Removed it for GTK and EFL.
1777
1778         Reviewed by Martin Robinson.
1779
1780         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1781         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1782         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1783         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1784
1785 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1786
1787         Unreviewed.  Move self from contributor to committer list.
1788
1789         * Scripts/webkitpy/common/config/committers.py:
1790
1791 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1792
1793         EWS should use a human readable port name when uploading layout test archives
1794         https://bugs.webkit.org/show_bug.cgi?id=113099
1795
1796         Reviewed by Dirk Pranke.
1797
1798         Use new port's object's name() method to report human readable port names.
1799         This will also help us resolving the bug to apply layout test results posted by EWS.
1800
1801         * Scripts/webkitpy/tool/bot/botinfo.py:
1802         (BotInfo.__init__): Take port's name.
1803         (BotInfo.summary_text):
1804
1805         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1806         (BotInfoTest.test_summary_text):
1807
1808         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1809         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1810
1811         * Scripts/webkitpy/tool/commands/queues.py:
1812         (PatchProcessingQueue.__init__): Initialize self._port.
1813         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1814         and use that for the attachment filename and the comment posted.
1815
1816         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1817         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1818         "mac-snowleopard" as expected for TestPort.
1819
1820 2013-03-22  Roger Fong  <roger_fong@apple.com>
1821
1822         Unreviewed. Turn off EWS test on Win again.
1823         The battle continues.
1824
1825         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1826         (WinEWS):
1827
1828 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1829
1830         NRWT: Enable pixel tests when retrying tests
1831         https://bugs.webkit.org/show_bug.cgi?id=112898
1832
1833         Reviewed by Dirk Pranke.
1834
1835         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1836         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1837         if we've forced pixel tests in the retry.
1838         (Manager._run_tests):
1839         (Manager._clean_up_run): Fixed the capitalizations.
1840         (Manager._force_pixel_tests_if_needed): Added.
1841
1842         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1843         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1844         'image_diff_percent' if it doesn't already exist.
1845
1846         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1847         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1848         treat this as a regular regression instead of a flakiness.
1849
1850         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1851         run had image diffs.
1852
1853         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1854         (summarized_results):
1855
1856         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1857         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1858         Also removed some dead code.
1859
1860         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1861         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1862         is set and pixel_tests_enabled is set to false.
1863         (EndToEndTest.test_reftest_with_two_notrefs):
1864
1865 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1866
1867         Make it possible to run layout tests on Retina MBP
1868         https://bugs.webkit.org/show_bug.cgi?id=93673
1869
1870         Reviewed by Ryosuke Niwa.
1871
1872         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1873         windows on 2x machines still run at 1x.
1874
1875         * DumpRenderTree/mac/DumpRenderTree.mm:
1876         (createWebViewAndOffscreenWindow):
1877         Reset the window resolution to 1x on creation.
1878         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1879         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1880         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1881         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1882         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1883         (WTR::PlatformWebView::PlatformWebView):
1884         Add NSWindow details, reset the window resolution to 1x on creation.
1885
1886 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1887
1888         Leak bots shouldn't build
1889         https://bugs.webkit.org/show_bug.cgi?id=112774
1890
1891         Reviewed by Simon Fraser.
1892
1893         Since leak bots use regular debug builds, there is no need to build on these bots.
1894         Simply downloading builds will dramatically improve the cycle time of these bots.
1895
1896         * BuildSlaveSupport/build.webkit.org-config/config.json:
1897         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1898         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1899         TestFactory instead of BuildAndTestFactory.
1900
1901 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1902
1903         [Qt] Fix the TestWebKitAPI build
1904         https://bugs.webkit.org/show_bug.cgi?id=113044
1905
1906         Reviewed by Tor Arne Vestbø.
1907
1908         The generate-forwarding-headers script would only be run
1909         after the targets in InjectedBundle.pri since the second
1910         addStrictSubdirOrderBetween call in
1911         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1912         the derived_sources -> injected_bundle order in SUBDIRS.
1913
1914         Fix it by only moving the dependent target at the end of
1915         SUBDIRS, don't touch its dependency.
1916
1917         * qmake/mkspecs/features/functions.prf:
1918
1919 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1920
1921         [EFL][WK2] View is not focused when fullscreen mode toggled
1922         https://bugs.webkit.org/show_bug.cgi?id=113009
1923
1924         Reviewed by Laszlo Gombos.
1925
1926         Set focus on view when fullscreen mode enabled/disabled
1927         by FullScreen API.
1928
1929         * MiniBrowser/efl/main.c:
1930         (on_fullscreen_accept):
1931         (on_fullscreen_deny):
1932
1933 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1934
1935         nrwt is no longer saving retry results in the retries/ subdirectory
1936         https://bugs.webkit.org/show_bug.cgi?id=112995
1937
1938         Reviewed by Ojan Vafai.
1939
1940         I think this has been broken a long time, unfortunately. This
1941         patch should fix that.
1942
1943         In order to do so, I had to pass the directory to use from
1944         the Worker object through the SingleTestWriter to the
1945         TestResultWriter. While I was plumbing that through, I rationalized
1946         the order of the parameter arguments a bit ...
1947
1948         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1949         (Worker._run_single_test):
1950         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1951         (run_single_test):
1952         (SingleTestRunner.__init__):
1953         (SingleTestRunner._run_compare_test):
1954         (SingleTestRunner._run_rebaseline):
1955         (SingleTestRunner._run_reftest):
1956         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1957         (write_test_result):
1958         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1959         (TestResultWriterTest.test_reftest_diff_image):
1960         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1961         (RunTest.test_retrying_uses_retries_directory):
1962
1963 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1964
1965         JSC profiler should have an at-a-glance report of the success of DFG optimization
1966         https://bugs.webkit.org/show_bug.cgi?id=112988
1967
1968         Reviewed by Geoffrey Garen.
1969
1970         * Scripts/display-profiler-output:
1971
1972 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1973
1974         [chromium] Linux ASAN WebKit canary is running out of memory
1975         https://bugs.webkit.org/show_bug.cgi?id=112978
1976
1977         Reviewed by Tony Chang.
1978
1979         Running the AddressSanitizer on a crash takes a lot of
1980         memory, so we should serialize access to it to avoid running
1981         out of memory on a machine.
1982
1983         * Scripts/webkitpy/layout_tests/port/chromium.py:
1984         (ChromiumPort._get_crash_log):
1985         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1986         (HttpLock.__init__):
1987         (HttpLock.wait_for_httpd_lock):
1988
1989 2013-03-21  Min Qin  <qinmin@chromium.org>
1990
1991         Cleanup android media layout test code
1992         https://bugs.webkit.org/show_bug.cgi?id=112944
1993
1994         Reviewed by Adam Barth.
1995
1996         Chromium change: https://codereview.chromium.org/12892010/
1997         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1998         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1999         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2000         Instead, we should switch to use content shell for layout tests.
2001
2002         * DumpRenderTree/chromium/TestShell.cpp:
2003         (TestShell::resetTestController):
2004
2005 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2006
2007         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2008         https://bugs.webkit.org/show_bug.cgi?id=112953
2009
2010         Reviewed by Tony Chang.
2011
2012         When I created the DumpRenderTree_resources target in r144863 I
2013         forgot to declare the needed dependencies on the other resource
2014         targets. Due to a quirk of ordering, this appears to have been fine
2015         w/ ninja but not w/ Xcode (which is still being used on the chromium
2016         mac valgrind bots). Declaring the dependencies fixes the build
2017         failures.
2018
2019         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2020
2021 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2022
2023         [WinCairo] Correct assert in Empty BitmapImage Test.
2024         https://bugs.webkit.org/show_bug.cgi?id=112934
2025
2026         Reviewed by Tim Horton.
2027
2028         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2029         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2030         to avoid ref counting assertion when leaving test scope.
2031
2032 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2033
2034         [GTK] generate-feature-defines-files is incompatible with Python3
2035         https://bugs.webkit.org/show_bug.cgi?id=112956
2036
2037         Reviewed by Martin Robinson.
2038
2039         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2040         method on the dictionary objects when iterating through said dictionaries.
2041
2042         * gtk/generate-feature-defines-files:
2043         (write_feature_defines_header):
2044         (write_flattened_feature_defines_file):
2045
2046 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2047
2048         kill-old-processes spits out error messages on Mac
2049         https://bugs.webkit.org/show_bug.cgi?id=112878
2050
2051         Reviewed by Jessie Berlin.
2052
2053         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2054         included in the list of options grep --help shows.
2055
2056         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2057
2058         * BuildSlaveSupport/kill-old-processes:
2059         (main):
2060
2061 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2062
2063         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2064         https://bugs.webkit.org/show_bug.cgi?id=112597
2065
2066         Reviewed by Xan Lopez.
2067
2068         These were introduced for the Chromium port in r105295. We need
2069         dummy implementations in order to compile the BlackBerry port.
2070
2071         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2072         (AccessibilityUIElement::scrollToMakeVisible):
2073         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2074         (AccessibilityUIElement::scrollToGlobalPoint):
2075
2076 2013-03-21  Roger Fong  <roger_fong@apple.com>
2077
2078         Re-enable WinEWS tests following r146376.
2079
2080         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2081         (WinEWS):
2082
2083 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2084
2085         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2086
2087         * Scripts/webkitpy/common/config/committers.py:
2088
2089 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2090
2091         [GTK] Missing atk in install-dependencies script
2092         https://bugs.webkit.org/show_bug.cgi?id=112272
2093
2094         Reviewed by Gustavo Noronha Silva.
2095
2096         * gtk/install-dependencies: Add missing atk dependency.
2097
2098 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2099
2100         [GTK] Missing backslash in install-dependencies script
2101         https://bugs.webkit.org/show_bug.cgi?id=112907
2102
2103         Reviewed by Philippe Normand.
2104
2105         * gtk/install-dependencies: Add missing backslash to dependencies
2106         list.
2107
2108 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2109
2110         EWS bots have stopped uploading results to bugzilla
2111         https://bugs.webkit.org/show_bug.cgi?id=101091
2112
2113         Reviewed by Adam Barth.
2114
2115         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2116         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2117         this relative file path resoled to a file inside a non-existent directory for "zip".
2118
2119         Fixed the bug by resolving both test results directory and zip archive paths in
2120         LayoutTestResultsReader.archive.
2121
2122         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2123         in the future.
2124
2125         * Scripts/webkitpy/common/system/filesystem_mock.py:
2126         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2127
2128         * Scripts/webkitpy/common/system/workspace.py:
2129         (Workspace.create_zip): Log the source path when "zip" failed.
2130
2131         * Scripts/webkitpy/common/system/workspace_mock.py:
2132         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2133
2134         * Scripts/webkitpy/common/system/workspace_unittest.py:
2135         (WorkspaceTest.test_create_zip_exception): Test that.
2136
2137         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2138         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2139         This is the actual bug fix.
2140
2141         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2142         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2143
2144 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2145
2146         [chromium] move WebThemeEngine implementations to TestRunner library
2147         https://bugs.webkit.org/show_bug.cgi?id=112751
2148
2149         Reviewed by Adam Barth.
2150
2151         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2152         * DumpRenderTree/DumpRenderTree.gypi:
2153         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2154         (WebKit):
2155         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2156         (WebTestRunner::TestInterfaces::themeEngine):
2157         (WebTestRunner):
2158         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2159         (WebKit):
2160         (TestInterfaces):
2161         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2162         (WebTestRunner::WebTestInterfaces::themeEngine):
2163         (WebTestRunner):
2164         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2165         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2166         (WebTestRunner):
2167         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2168         (WebTestRunner::WebTestThemeControlWin::box):
2169         (WebTestRunner::WebTestThemeControlWin::line):
2170         (WebTestRunner::WebTestThemeControlWin::triangle):
2171         (WebTestRunner::WebTestThemeControlWin::roundRect):
2172         (WebTestRunner::WebTestThemeControlWin::oval):
2173         (WebTestRunner::WebTestThemeControlWin::circle):
2174         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2175         (WebTestRunner::WebTestThemeControlWin::markState):
2176         (WebTestRunner::WebTestThemeControlWin::draw):
2177         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2178         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2179         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2180         (WebTestRunner):
2181         (WebTestThemeControlWin):
2182         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2183         (WebTestRunner):
2184         (WebTestThemeEngineMac):
2185         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2186         (+[FakeActiveWindow alwaysActiveWindow]):
2187         (+[FakeActiveWindow alwaysInactiveWindow]):
2188         (-[FakeActiveWindow initWithActiveControls:]):
2189         (-[FakeActiveWindow _hasActiveControls]):
2190         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2191         (WebTestRunner):
2192         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2193         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2194         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2195         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2196         (WebTestRunner):
2197         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2198         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2199         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2200         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2201         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2202         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2203         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2204         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2205         (WebTestRunner::WebTestThemeEngineWin::getSize):
2206         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2207         (WebTestRunner):
2208         (WebTestThemeEngineWin):
2209         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2210         * DumpRenderTree/chromium/TestShell.cpp:
2211         (TestShell::initialize):
2212         * DumpRenderTree/chromium/TestShell.h:
2213         (WebKit):
2214         * DumpRenderTree/chromium/TestShellMac.mm:
2215         (platformInit):
2216         * DumpRenderTree/chromium/TestShellWin.cpp:
2217         (platformInit):
2218         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2219
2220 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2221
2222         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2223
2224         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2225         New property sheet that does not link against CoreFoundation and
2226         CFNetwork.
2227         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2228         Use new TestWebKitAPICommonWinCairo property sheet.
2229         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2230         Ditto.
2231
2232 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2233
2234         [WinCairo] Unreviewed build fix for VS2010.
2235
2236         Had to add WinCairo-specific property sheets to deal with some
2237         library and path differences with the main Apple port.
2238
2239         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2240         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2241         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2242         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2243         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2244         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2245
2246 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2247
2248         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2249         https://bugs.webkit.org/show_bug.cgi?id=112849
2250
2251         Reviewed by Sam Weinig.
2252
2253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2256
2257 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2258
2259         [WinCairo] Build WebKit Tools under VS2010
2260         https://bugs.webkit.org/show_bug.cgi?id=112821
2261
2262         Reviewed by Tim Horton.
2263
2264         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2265         Add WinCairo-specific build target.
2266         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2267         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2268         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2269         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2270         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2271         Add WinCairo-specific build target.
2272         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2273         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2274         Add WinCairo-specific build target.
2275         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2276         WinCairo-specific build target.
2277         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2278         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2279         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2280         specific build target.
2281         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2282         WinCairo-specific build target.
2283         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2284         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2285         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2286
2287 2013-03-20  Roger Fong  <roger_fong@apple.com>
2288
2289         API test gardening AppleWin port.
2290
2291         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2292
2293         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2294         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2295
2296 2013-03-20  Roger Fong  <roger_fong@apple.com>
2297
2298         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2299
2300         * EWSTools/start-queue-win.sh:
2301
2302 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2303
2304         Unreviewed, add myself to committers.py.
2305
2306 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2307
2308         Unreviewed. Adding another email for me.
2309
2310         * Scripts/webkitpy/common/config/committers.py:
2311
2312 2013-03-20  Justin Novosad  <junov@google.com>
2313
2314         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2315         https://bugs.webkit.org/show_bug.cgi?id=112605
2316
2317         Reviewed by James Robinson.
2318
2319         Deleting all the code that was used for propagating and supporting
2320         the Chromium setting for disabling deferred 2d canvas rendering.
2321
2322         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2323         (main):
2324         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2325         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2326         (WebTestRunner::WebPreferences::reset):
2327         (WebTestRunner::WebPreferences::applyTo):
2328         * DumpRenderTree/chromium/TestShell.cpp:
2329         (TestShell::TestShell):
2330         (TestShell::resetWebSettings):
2331         (TestShell::runFileTest):
2332         * DumpRenderTree/chromium/TestShell.h:
2333         (TestShell):
2334
2335 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2336
2337         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2338         https://bugs.webkit.org/show_bug.cgi?id=112699.
2339
2340         Reviewed by Adam Barth.
2341
2342         * Scripts/webkitpy/layout_tests/port/qt.py:
2343         (QtPort._search_paths):
2344         (QtPort._port_specific_expectations_files):
2345         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2346         (QtPortTest):
2347         (QtPortTest._assert_search_path):
2348         (QtPortTest._assert_expectations_files):
2349
2350 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2351
2352         [Qt] Enable kerning by default
2353         https://bugs.webkit.org/show_bug.cgi?id=112704
2354
2355         Reviewed by Jocelyn Turcotte.
2356
2357         Disable kerning by default, since some reference test expectations
2358         expect kerning to be default off.
2359
2360         * DumpRenderTree/qt/TestRunnerQt.cpp:
2361         (TestRunnerQt::reset):
2362         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2363         (WTR::activateFonts):
2364
2365 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2366
2367         [Qt] Remove empty function stubs from TestRunnerQt.
2368         https://bugs.webkit.org/show_bug.cgi?id=112799
2369
2370         We are reducing the code in TestRunnerQt step by step,
2371         in order to finally replace all of it with the generic
2372         TestRunner implementation.
2373         This patch removes several simple function stubs that
2374         currently do not implement any actual functionality.
2375
2376         Reviewed by Kenneth Rohde Christiansen.
2377
2378         * DumpRenderTree/qt/TestRunnerQt.cpp:
2379         * DumpRenderTree/qt/TestRunnerQt.h:
2380         (TestRunnerQt):
2381
2382 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2383
2384         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2385         https://bugs.webkit.org/show_bug.cgi?id=112687
2386
2387         Reviewed by Kenneth Rohde Christiansen.
2388
2389         Hide the SearchBar by default on window creation.
2390
2391         * MiniBrowser/efl/main.c:
2392         (window_create):
2393
2394 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2395
2396         Unreviewed, rolling out r146304.
2397         http://trac.webkit.org/changeset/146304
2398         https://bugs.webkit.org/show_bug.cgi?id=112788
2399
2400         to many expectations to update (Requested by antonm on
2401         #webkit).
2402
2403         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2404         * DumpRenderTree/DumpRenderTree.gypi:
2405         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2406         (WebKit):
2407         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2408         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2409         (TestInterfaces):
2410         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2411         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2412         * DumpRenderTree/chromium/TestShell.cpp:
2413         (TestShell::initialize):
2414         * DumpRenderTree/chromium/TestShell.h:
2415         (WebKit):
2416         * DumpRenderTree/chromium/TestShellMac.mm:
2417         (platformInit):
2418         * DumpRenderTree/chromium/TestShellWin.cpp:
2419         (platformInit):
2420         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2421         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2422         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2423         (WebThemeControlDRTWin::box):
2424         (WebThemeControlDRTWin::line):
2425         (WebThemeControlDRTWin::triangle):
2426         (WebThemeControlDRTWin::roundRect):
2427         (WebThemeControlDRTWin::oval):
2428         (WebThemeControlDRTWin::circle):
2429         (WebThemeControlDRTWin::nestedBoxes):
2430         (WebThemeControlDRTWin::markState):
2431         (WebThemeControlDRTWin::draw):
2432         (WebThemeControlDRTWin::drawTextField):
2433         (WebThemeControlDRTWin::drawProgressBar):
2434         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2435         (WebThemeControlDRTWin):
2436         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2437         (WebThemeEngineDRTMac):
2438         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2439         (+[FakeActiveWindow alwaysActiveWindow]):
2440         (+[FakeActiveWindow alwaysInactiveWindow]):
2441         (-[FakeActiveWindow initWithActiveControls:]):
2442         (-[FakeActiveWindow _hasActiveControls]):
2443         (WebThemeEngineDRTMac::paintScrollbarThumb):
2444         (stateToHIEnableState):
2445         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2446         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2447         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2448         (webRectToSkIRect):
2449         (drawControl):
2450         (drawTextField):
2451         (drawProgressBar):
2452         (WebThemeEngineDRTWin::paintButton):
2453         (WebThemeEngineDRTWin::paintMenuList):
2454         (WebThemeEngineDRTWin::paintScrollbarArrow):
2455         (WebThemeEngineDRTWin::paintScrollbarThumb):
2456         (WebThemeEngineDRTWin::paintScrollbarTrack):
2457         (WebThemeEngineDRTWin::paintSpinButton):
2458         (WebThemeEngineDRTWin::paintTextField):
2459         (WebThemeEngineDRTWin::paintTrackbar):
2460         (WebThemeEngineDRTWin::paintProgressBar):
2461         (WebThemeEngineDRTWin::getSize):
2462         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2463         (WebThemeEngineDRTWin):
2464         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2465
2466 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2467
2468         [Qt] Support -webkit-font-smoothing
2469         https://bugs.webkit.org/show_bug.cgi?id=106009
2470
2471         Reviewed by Jocelyn Turcotte.
2472
2473         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2474
2475         * DumpRenderTree/qt/TestRunnerQt.cpp:
2476         (TestRunnerQt::reset):
2477
2478 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2479
2480         [GTK] accessibility/aria-scrollbar-role.html is failing
2481         https://bugs.webkit.org/show_bug.cgi?id=98358
2482
2483         Reviewed by Martin Robinson.
2484
2485         Adds support for checking accessibility object's orientation.
2486         Orientation is checked by retrieving proper state of accessibility object.
2487
2488         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2489         (checkElementState):
2490         (AccessibilityUIElement::orientation):
2491         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2492         (WTR::AccessibilityUIElement::orientation):
2493
2494 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2495
2496         [chromium] move WebThemeEngine implementations to TestRunner library
2497         https://bugs.webkit.org/show_bug.cgi?id=112751
2498
2499         Reviewed by Adam Barth.
2500
2501         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2502         * DumpRenderTree/DumpRenderTree.gypi:
2503         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2504         (WebKit):
2505         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2506         (WebTestRunner::TestInterfaces::themeEngine):
2507         (WebTestRunner):
2508         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2509         (WebKit):
2510         (TestInterfaces):
2511         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2512         (WebTestRunner::WebTestInterfaces::themeEngine):
2513         (WebTestRunner):
2514         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2515         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2516         (WebTestRunner):
2517         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2518         (WebTestRunner::WebTestThemeControlWin::box):
2519         (WebTestRunner::WebTestThemeControlWin::line):
2520         (WebTestRunner::WebTestThemeControlWin::triangle):
2521         (WebTestRunner::WebTestThemeControlWin::roundRect):
2522         (WebTestRunner::WebTestThemeControlWin::oval):
2523         (WebTestRunner::WebTestThemeControlWin::circle):
2524         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2525         (WebTestRunner::WebTestThemeControlWin::markState):
2526         (WebTestRunner::WebTestThemeControlWin::draw):
2527         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2528         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2529         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2530         (WebTestRunner):
2531         (WebTestThemeControlWin):
2532         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2533         (WebTestRunner):
2534         (WebTestThemeEngineMac):
2535         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2536         (+[FakeActiveWindow alwaysActiveWindow]):
2537         (+[FakeActiveWindow alwaysInactiveWindow]):
2538         (-[FakeActiveWindow initWithActiveControls:]):
2539         (-[FakeActiveWindow _hasActiveControls]):
2540         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2541         (WebTestRunner):
2542         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2543         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2544         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2545         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2546         (WebTestRunner):
2547         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2548         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2549         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2550         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2551         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2552         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2553         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2554         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2555         (WebTestRunner::WebTestThemeEngineWin::getSize):
2556         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2557         (WebTestRunner):
2558         (WebTestThemeEngineWin):
2559         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2560         * DumpRenderTree/chromium/TestShell.cpp:
2561         (TestShell::initialize):
2562         * DumpRenderTree/chromium/TestShell.h:
2563         (WebKit):
2564         * DumpRenderTree/chromium/TestShellMac.mm:
2565         (platformInit):
2566         * DumpRenderTree/chromium/TestShellWin.cpp:
2567         (platformInit):
2568         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2569
2570 2013-03-19  Tony Chang  <tony@chromium.org>
2571
2572         Move testRunner.setTouchDragDropEnabled to internals.settings
2573         https://bugs.webkit.org/show_bug.cgi?id=112739
2574
2575         Reviewed by Adam Barth.
2576
2577         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2578         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2579         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2580         (TestRunner): Remove unnecessary code.
2581         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2582         (WebTestRunner::WebPreferences::reset):
2583         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2584
2585 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2586
2587         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2588         https://bugs.webkit.org/show_bug.cgi?id=112754
2589
2590         Reviewed by Darin Fisher.
2591
2592         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2593         now that it's always defined.
2594
2595         * DumpRenderTree/chromium/WebViewHost.cpp:
2596         * DumpRenderTree/chromium/WebViewHost.h:
2597         (WebViewHost):
2598
2599 2013-03-19  Kenneth Russell  <kbr@google.com>
2600
2601         Unreviewed, rolling out r146290.
2602         http://trac.webkit.org/changeset/146290
2603         https://bugs.webkit.org/show_bug.cgi?id=112751
2604
2605         Broke Chromium Mac build.
2606
2607         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2608         * DumpRenderTree/DumpRenderTree.gypi:
2609         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2610         (WebKit):
2611         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2612         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2613         (TestInterfaces):
2614         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2615         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2616         * DumpRenderTree/chromium/TestShell.cpp:
2617         (TestShell::initialize):
2618         * DumpRenderTree/chromium/TestShell.h:
2619         (WebKit):
2620         * DumpRenderTree/chromium/TestShellMac.mm:
2621         (platformInit):
2622         * DumpRenderTree/chromium/TestShellWin.cpp:
2623         (platformInit):
2624         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2625         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2626         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2627         (WebThemeControlDRTWin::box):
2628         (WebThemeControlDRTWin::line):
2629         (WebThemeControlDRTWin::triangle):
2630         (WebThemeControlDRTWin::roundRect):
2631         (WebThemeControlDRTWin::oval):
2632         (WebThemeControlDRTWin::circle):
2633         (WebThemeControlDRTWin::nestedBoxes):
2634         (WebThemeControlDRTWin::markState):
2635         (WebThemeControlDRTWin::draw):
2636         (WebThemeControlDRTWin::drawTextField):
2637         (WebThemeControlDRTWin::drawProgressBar):
2638         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2639         (WebThemeControlDRTWin):
2640         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2641         (WebThemeEngineDRTMac):
2642         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2643         (+[FakeActiveWindow alwaysActiveWindow]):
2644         (+[FakeActiveWindow alwaysInactiveWindow]):
2645         (-[FakeActiveWindow initWithActiveControls:]):
2646         (-[FakeActiveWindow _hasActiveControls]):
2647         (WebThemeEngineDRTMac::paintScrollbarThumb):
2648         (stateToHIEnableState):
2649         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2650         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2651         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2652         (webRectToSkIRect):
2653         (drawControl):
2654         (drawTextField):
2655         (drawProgressBar):
2656         (WebThemeEngineDRTWin::paintButton):
2657         (WebThemeEngineDRTWin::paintMenuList):
2658         (WebThemeEngineDRTWin::paintScrollbarArrow):
2659         (WebThemeEngineDRTWin::paintScrollbarThumb):
2660         (WebThemeEngineDRTWin::paintScrollbarTrack):
2661         (WebThemeEngineDRTWin::paintSpinButton):
2662         (WebThemeEngineDRTWin::paintTextField):
2663         (WebThemeEngineDRTWin::paintTrackbar):
2664         (WebThemeEngineDRTWin::paintProgressBar):
2665         (WebThemeEngineDRTWin::getSize):
2666         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2667         (WebThemeEngineDRTWin):
2668         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2669
2670 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2671
2672         [EFL] canvas-fallback-content.html is failing
2673         https://bugs.webkit.org/show_bug.cgi?id=111998
2674
2675         Reviewed by Chris Fleizach.
2676
2677         Adds support for getting platform name.
2678
2679         * DumpRenderTree/TestRunner.cpp:
2680         (TestRunner::staticValues):
2681         * DumpRenderTree/TestRunner.h:
2682         (TestRunner):
2683         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2684         (TestRunner::platformName):
2685
2686 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2687
2688         [chromium] move WebThemeEngine implementations to TestRunner library
2689         https://bugs.webkit.org/show_bug.cgi?id=112751
2690
2691         Reviewed by Adam Barth.
2692
2693         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2694         * DumpRenderTree/DumpRenderTree.gypi:
2695         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2696         (WebKit):
2697         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2698         (WebTestRunner::TestInterfaces::themeEngine):
2699         (WebTestRunner):
2700         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2701         (WebKit):
2702         (TestInterfaces):
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2704         (WebTestRunner::WebTestInterfaces::themeEngine):
2705         (WebTestRunner):
2706         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2707         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2708         (WebTestRunner):
2709         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2710         (WebTestRunner::WebTestThemeControlWin::box):
2711         (WebTestRunner::WebTestThemeControlWin::line):
2712         (WebTestRunner::WebTestThemeControlWin::triangle):
2713         (WebTestRunner::WebTestThemeControlWin::roundRect):
2714         (WebTestRunner::WebTestThemeControlWin::oval):
2715         (WebTestRunner::WebTestThemeControlWin::circle):
2716         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2717         (WebTestRunner::WebTestThemeControlWin::markState):
2718         (WebTestRunner::WebTestThemeControlWin::draw):
2719         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2720         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2721         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2722         (WebTestRunner):
2723         (WebTestThemeControlWin):
2724         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2725         (WebTestRunner):
2726         (WebTestThemeEngineMac):
2727         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2728         (+[FakeActiveWindow alwaysActiveWindow]):
2729         (+[FakeActiveWindow alwaysInactiveWindow]):
2730         (-[FakeActiveWindow initWithActiveControls:]):
2731         (-[FakeActiveWindow _hasActiveControls]):
2732         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2733         (WebTestRunner):
2734         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2735         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2736         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2737         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2738         (WebTestRunner):
2739         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2740         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2741         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2742         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2743         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2744         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2745         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2746         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2747         (WebTestRunner::WebTestThemeEngineWin::getSize):
2748         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2749         (WebTestRunner):
2750         (WebTestThemeEngineWin):
2751         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2752         * DumpRenderTree/chromium/TestShell.cpp:
2753         (TestShell::initialize):
2754         * DumpRenderTree/chromium/TestShell.h:
2755         (WebKit):
2756         * DumpRenderTree/chromium/TestShellMac.mm:
2757         (platformInit):
2758         * DumpRenderTree/chromium/TestShellWin.cpp:
2759         (platformInit):
2760         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2761
2762 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2763
2764         [EFL][WK2] Separate WebView further from EwkView
2765         https://bugs.webkit.org/show_bug.cgi?id=111591
2766
2767         Reviewed by Caio Marcelo de Oliveira Filho.
2768
2769         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2770         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2771         since we can afford it having EWKViewGetWKView() private API to access WKView.
2772
2773         * TestWebKitAPI/PlatformWebView.h:
2774         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/efl/PlatformWebView.cpp:
2777         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2778         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2779         (TestWebKitAPI::PlatformWebView::resizeTo):
2780         (TestWebKitAPI::PlatformWebView::page):
2781         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2782         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2783         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2784         * WebKitTestRunner/PlatformWebView.h:
2785         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2786         (WTR::EventSenderProxy::dispatchEvent):
2787         (WTR::EventSenderProxy::keyDown):
2788         (WTR::EventSenderProxy::sendTouchEvent):
2789         (WTR::EventSenderProxy::setTouchModifier):
2790         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2791         (WTR::PlatformWebView::PlatformWebView):
2792         (WTR::PlatformWebView::~PlatformWebView):
2793         (WTR::PlatformWebView::resizeTo):
2794         (WTR::PlatformWebView::page):
2795         (WTR::PlatformWebView::focus):
2796         (WTR::PlatformWebView::windowSnapshotImage):
2797
2798 2013-03-19  Roger Fong  <roger_fong@apple.com>
2799
2800         Changes to VS2010 project files should only trigger builds on Windows bots.
2801         https://bugs.webkit.org/show_bug.cgi?id=112731
2802
2803         Reviewed by Timothy Horton.
2804
2805         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2806         (_should_file_trigger_build):
2807
2808 2013-03-19  Roger Fong  <roger_fong@apple.com>
2809
2810         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2811
2812         * Scripts/webkitpy/tool/steps/runtests.py:
2813         (RunTests.run):
2814         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2815         (RunTestsTest.test_webkit_run_unit_tests):
2816
2817 2013-03-19  Julie Parent  <jparent@chromium.org>
2818
2819         Dashboards: Introduce history namespace and unit tests.
2820         https://bugs.webkit.org/show_bug.cgi?id=112645
2821
2822         Reviewed by Ojan Vafai.
2823         
2824         Laying the framework for introducing the new history object and
2825         namespace.  This moves only static functions into the history
2826         namespace, and moves corresponding unit tests into seperate
2827         unit test file.
2828
2829         * TestResultServer/static-dashboards/aggregate_results.html:
2830         * TestResultServer/static-dashboards/dashboard_base.js:
2831         (parseCrossDashboardParameters):
2832         (parseDashboardSpecificParameters):
2833         (parseParameters):
2834         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2835         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2836         (.switch.return):
2837         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2838         * TestResultServer/static-dashboards/history.js: Added.
2839         * TestResultServer/static-dashboards/history_unittests.js: Added.
2840         * TestResultServer/static-dashboards/loader.js:
2841         (.):
2842         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2843         * TestResultServer/static-dashboards/run-unittests.html:
2844         * TestResultServer/static-dashboards/timeline_explorer.html:
2845         * TestResultServer/static-dashboards/timeline_explorer.js:
2846         * TestResultServer/static-dashboards/treemap.html:
2847         * TestResultServer/static-dashboards/treemap.js:
2848         (.switch.return):
2849         * TestResultServer/static-dashboards/ui.js:
2850
2851 2013-03-19  Daniel Bates  <dbates@webkit.org>
2852
2853         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2854         https://bugs.webkit.org/show_bug.cgi?id=112732
2855
2856         Reviewed by Eric Seidel.
2857
2858         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2859         of an existing file cannot be applied.
2860
2861         In particular, svn-{apply, unapply} compensate for differences in line endings
2862         by converting the line endings in a diff to match the line endings in the target
2863         file. The diff(1) command precedes the last line of a diff that adds a newline
2864         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2865         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2866         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2867         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2868         the newline characters in this special character sequence to match the line endings
2869         in the target file.
2870
2871         * Scripts/VCSUtils.pm:
2872         (parseDiff):
2873         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2874         Added tests:
2875             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2876             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2877             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2878             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2879         (escapeNewLineCharacters): Added.
2880         (toMacLineEndings): Added.
2881
2882 2013-03-19  James Robinson  <jamesr@chromium.org>
2883
2884         [chromium] Remove compositor settings that don't go through WebKit
2885         https://bugs.webkit.org/show_bug.cgi?id=112718
2886
2887         Reviewed by Adam Barth.
2888
2889         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2890         (main):
2891         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2892         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2893         (WebTestRunner::WebPreferences::reset):
2894         (WebTestRunner::WebPreferences::applyTo):
2895         * DumpRenderTree/chromium/TestShell.cpp:
2896         (TestShell::TestShell):
2897         (TestShell::resetWebSettings):
2898         * DumpRenderTree/chromium/TestShell.h:
2899         (TestShell):
2900
2901 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2902
2903         Unreviewed, rolling out r146101.
2904         https://bugs.webkit.org/show_bug.cgi?id=111884
2905
2906         re-enable custom freetype on asan; this needs to be on
2907         now that the bot is running lucid.
2908
2909         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2910
2911 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2912
2913         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2914         https://bugs.webkit.org/show_bug.cgi?id=112365
2915
2916         Reviewed by Benjamin Poulain.
2917
2918         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2919         harcoding it in wtf/Platform.h
2920
2921         * Scripts/webkitperl/FeatureList.pm:
2922
2923 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2924
2925         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2926         https://bugs.webkit.org/show_bug.cgi?id=94782
2927
2928         Based on patch by Csaba Osztrogonác.
2929         Reviewed by Jocelyn Turcotte.
2930
2931         The diff image is generated with bright red indicating errors, but letting the base image
2932         shine through so the context of the error-pixel can be identified.
2933
2934         * DumpRenderTree/qt/ImageDiff.cpp:
2935         (main):
2936
2937 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2938
2939         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2940
2941         Rubber-stamped by Csaba Osztrogonác.
2942
2943         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2944         since the latter might not cover the former.
2945
2946         * QtTestBrowser/launcherwindow.cpp:
2947         (LauncherWindow::print):
2948
2949 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2950
2951         Style tweeks to default.css.
2952         
2953         Rubber-stamped by David Kilzer.
2954         
2955         Give visited links a different color to other links, so you can
2956         see which builds you've viewed.
2957         
2958         Make the <small> text less tiny.
2959
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2961         (small):
2962         (a:link,a:visited,a:active):
2963         (a:visited):
2964
2965 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2966
2967         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2968         https://bugs.webkit.org/show_bug.cgi?id=112494
2969
2970         Reviewed by Dirk Pranke.
2971
2972         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2973         Also merged two pairs of methods to cleanup the code.
2974
2975         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2976         (PerfTestsRunner.run): Merged _upload_and_show_results.
2977         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2978
2979 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2980
2981         [chromium] build xdisplaycheck when building DRT
2982         https://bugs.webkit.org/show_bug.cgi?id=112636
2983
2984         Reviewed by Tony Chang.
2985
2986         It appears that we need xdisplaycheck to be built in order for
2987         Xvfb to be started correctly on the bots, and DRT was missing
2988         a dependency on it. This may be the cause of the ASAN bot not
2989         starting up properly (it only builds DRT).
2990
2991         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2992
2993 2013-03-18  David Levin  <levin@chromium.org>
2994
2995         Implement icon change notification dump for Chromium's test shell.
2996         https://bugs.webkit.org/show_bug.cgi?id=112614
2997
2998         This was previously implemented for some other platforms in r58111
2999         and r116547.
3000
3001         In r122806, fast/dom/icon-url-property.html stopped using it, but
3002         it is useful for tests, so I plan to re-add it to that test again.
3003
3004         Reviewed by Jochen Eisinger.
3005
3006         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3007         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3008          icon change notifications from WebKit may be logged in test output.
3009         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3010         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3011         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3012         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3013         (WebTestRunner):
3014         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3015         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3016         (TestRunner):
3017         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3018         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3019         (WebTestRunner):
3020         * DumpRenderTree/chromium/WebViewHost.cpp:
3021         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3022         * DumpRenderTree/chromium/WebViewHost.h:
3023         (WebViewHost):
3024
3025 2013-03-18  Julie Parent  <jparent@chromium.org>
3026
3027         Cleanup: Move js for treemap and aggregate_results into own js files.
3028         https://bugs.webkit.org/show_bug.cgi?id=112618
3029
3030         Reviewed by Dirk Pranke.
3031         
3032         No functional changes, just moving the code into separate js file
3033         rather than inlined in the html, so we can test it, make it more
3034         modular, etc.  Other dashboard types are already done this way.
3035
3036         * TestResultServer/static-dashboards/aggregate_results.html:
3037         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3038         (generatePage):
3039         (handleValidHashParameter):
3040         (htmlForBuilder):
3041         (rawValuesHTML):
3042         (chartHTML):
3043         (filteredValues):
3044         (chart):
3045         (htmlForRevisionRows):
3046         (wrapHTMLInTable):
3047         (htmlForSummaryTable):
3048         (valuesPerExpectation):
3049         (htmlForTestType):
3050         (htmlForTableRow):
3051         (extendedEncode):
3052         * TestResultServer/static-dashboards/treemap.html:
3053         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3054         (humanReadableTime):
3055         (convertToWebTreemapFormat):
3056         (reverseSortByAverage):
3057         (generatePage):
3058         (focusPath):
3059         (.switch.return):
3060         (handleQueryParameterChange):
3061         (extractName):
3062         (fullName):
3063         (handleFocus.):
3064         (handleFocus):
3065
3066 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3067
3068         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3069         https://bugs.webkit.org/show_bug.cgi?id=112622
3070
3071         Reviewed by Dirk Pranke.
3072
3073         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3074         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3075
3076 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3077
3078         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3079         https://bugs.webkit.org/show_bug.cgi?id=112619
3080
3081         Reviewed by Dirk Pranke.
3082
3083         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3084         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3085
3086         * Scripts/webkitpy/layout_tests/port/gtk.py:
3087         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3088         Port._webkit_baseline_path method.
3089         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3090         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3091         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3092         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3093         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3094         that are expected based on the builder name.
3095
3096 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3097
3098         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3099         https://bugs.webkit.org/show_bug.cgi?id=112571
3100
3101         Reviewed by Adam Barth.
3102
3103         Update function declarations for new WebFileSystemType enum. (All
3104         changes are behind an #ifdef so we can sync required changes in embedders.)
3105
3106         * DumpRenderTree/chromium/WebViewHost.cpp:
3107         (WebViewHost::openFileSystem):
3108         (WebViewHost::deleteFileSystem):
3109         * DumpRenderTree/chromium/WebViewHost.h:
3110         (WebViewHost):
3111
3112 2013-03-18  Julie Parent  <jparent@chromium.org>
3113
3114         Cleanup: Move timeline_exporer js out of html file into js.
3115         https://bugs.webkit.org/show_bug.cgi?id=112188
3116
3117         Reviewed by Dirk Pranke.
3118         
3119         Moves the javascript out of the html file and into a new js file.
3120         This follows the format of flakiness_dashboard.{html|js}.
3121         
3122         Also moves code from dashboard_base that is used only by this one
3123         dashboard, and makes it private to the dashboard.
3124
3125         * TestResultServer/static-dashboards/dashboard_base.js:
3126         * TestResultServer/static-dashboards/timeline_explorer.html:
3127         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3128         (generatePage):
3129         (initCurrentBuilderTestResults):
3130         (shouldShowWebKitRevisionsOnly):
3131         (updateTimelineForBuilder.):
3132         (updateTimelineForBuilder):
3133         (selectBuild):
3134         (updateBuildIndicator):
3135         (.addRow):
3136         (.addNumberRow):
3137         (.inspectorNode.getElementsByTagName.0.onclick):
3138         (.inspectorNode.getElementsByTagName.1.onclick):
3139         (.inspectorNode.getElementsByTagName.2.onclick):
3140         (updateBuildInspector):
3141         (showResultsDelta):
3142         (decompressResults.addFlakyDelta):
3143         (decompressResults):
3144
3145 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3146
3147         Unreviewed, rolling out r145272.
3148         http://trac.webkit.org/changeset/145272
3149         https://bugs.webkit.org/show_bug.cgi?id=111884
3150
3151         Turns out the ASAN build is still broken; possibly there's
3152         something still setting LD_LIBRARY_PATH, or possibly there's
3153         something else wrong. In the meantime, we need it to work again.
3154
3155         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3156
3157 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         delete-stale-build-files is too aggressive
3160         https://bugs.webkit.org/show_bug.cgi?id=112595
3161
3162         Reviewed by Tim Horton.
3163
3164         It appears that whitelisting file extensions to keep is not a good idea.
3165         Blacklist files to delete instead, and only delete .o files for now.
3166         We can add more file extensions as needed.
3167
3168         * BuildSlaveSupport/delete-stale-build-files:
3169
3170 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3171
3172         Disable accessibility notifications after each test
3173         https://bugs.webkit.org/show_bug.cgi?id=112579
3174
3175         Reviewed by Tim Horton.
3176         
3177         In WebKitTestRunner, if any tests triggered accessibility notifications,
3178         the global notification handler would thereafter be active, and fire
3179         notifications for all subsequent tests.
3180         
3181         Fix by implementing AccessibilityController::resetToConsistentState() for
3182         Mac, and using it to clear the global notification handler.
3183
3184         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3185         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3186         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3187         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3188         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3189         (e.g. because of -autorelease).
3190         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3191         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3192         if there is one.
3193         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3194         Add -stopObserving
3195         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3196         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3197         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3198         center.
3199
3200 2013-03-18  Dana Jansens  <danakj@chromium.org>
3201
3202         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3203         https://bugs.webkit.org/show_bug.cgi?id=112392
3204
3205         Reviewed by James Robinson.
3206
3207         Removes the command line flag option from DRT.
3208
3209         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3210         (main):
3211
3212 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3213
3214         [GTK] plugins/plugin-clip-subframe.html is failing
3215         https://bugs.webkit.org/show_bug.cgi?id=112570
3216
3217         Reviewed by Martin Robinson.
3218
3219         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3220
3221 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3222
3223         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3224         https://bugs.webkit.org/show_bug.cgi?id=112442
3225
3226         Reviewed by Gustavo Noronha Silva.
3227
3228         * GtkLauncher/main.c:
3229         (reloadCb):
3230         (createToolbar):
3231         (createWindow):
3232
3233 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3234
3235         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3236         https://bugs.webkit.org/show_bug.cgi?id=112205
3237
3238         Disable this API test until Geoff can fix it.
3239
3240         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3241         (TestWebKitAPI::TEST):
3242
3243 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3244
3245         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3246         https://bugs.webkit.org/show_bug.cgi?id=112478
3247
3248         Reviewed by Tony Chang.
3249
3250         There is nothing that ensures that the log messages from the plugin
3251         come in before the layout test finished loading.
3252
3253         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3254         (PassDifferentNPPStruct::NPP_SetWindow):
3255         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3256         (NPP_SetWindow):
3257
3258 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3259
3260         Have the mac port support per_test_timeout in webkitpy
3261         https://bugs.webkit.org/show_bug.cgi?id=112466
3262
3263         Reviewed by Dirk Pranke.
3264         
3265         Both WTR and DRT handle --timeout arguments, so we can
3266         have the scripts pass the timeout values down to the tools.
3267
3268         * Scripts/webkitpy/layout_tests/port/mac.py:
3269         (MacPort.supports_per_test_timeout):
3270
3271 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3272
3273         Remove setAsynchronousSpellCheckingEnabled from test runners
3274         https://bugs.webkit.org/show_bug.cgi?id=112362
3275
3276         Reviewed by Tony Chang.
3277
3278         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3279         in internals.settings, so all ports can share it.
3280
3281         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3282         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3283         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3284         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3285         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3286         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3287         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3288         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3289         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3290         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3291         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3292         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3293
3294 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3295
3296         Fix the stupid unit tests.
3297
3298         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3299         (test_sample_process):
3300
3301 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3302
3303         Collect samples for unresponsive web processes
3304         https://bugs.webkit.org/show_bug.cgi?id=112409
3305
3306         Reviewed by Tim Horton.
3307         
3308         When we detect that a subprocess was unresponsive, run the 'sample'
3309         tool on that process, for the Mac port.
3310         
3311         The sample will be linked to from the results.html page, next
3312         to the crash log link.
3313
3314         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3315         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3316         look for samples on disk.
3317         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3318         (TestResultWriter):
3319         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3320         -sample.txt files, and have it copy their contents to a new file
3321         next to the test that spawned them (as we do for crash logs).
3322         * Scripts/webkitpy/layout_tests/port/base.py:
3323         (Port.look_for_new_samples): Base class does nothing for sampling.
3324         * Scripts/webkitpy/layout_tests/port/driver.py:
3325         (Driver._check_for_driver_crash): Kick off a sample if we detected
3326         that the subprocess was unresponsive.
3327         * Scripts/webkitpy/layout_tests/port/mac.py:
3328         (MacPort.sample_file_path): Utility to generate the file path
3329         to the generated sample files at the top level of layout-test-results.
3330         (MacPort.look_for_new_crash_logs): Fix typo
3331         (MacPort.look_for_new_samples): New function to find sample files.
3332         (MacPort.sample_process): Use the utility function to get the file path.
3333
3334 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3335
3336         [Qt] Remove simple getters and setters from TestRunnerQt
3337         https://bugs.webkit.org/show_bug.cgi?id=112343
3338
3339         Reviewed by Benjamin Poulain.
3340
3341         The removed functions and boolean members
3342         are being replaced by the implementations in the
3343         generic TestRunner.h.
3344
3345         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3346         (DumpRenderTree::dumpFrameScrollPosition):
3347         (DumpRenderTree::dumpFramesAsText):
3348         (DumpRenderTree::dump):
3349         (DumpRenderTree::titleChanged):
3350         (DumpRenderTree::dumpDatabaseQuota):
3351         (DumpRenderTree::dumpApplicationCacheQuota):
3352         (DumpRenderTree::statusBarMessage):
3353         (DumpRenderTree::createWindow):
3354         * DumpRenderTree/qt/TestRunnerQt.cpp:
3355         (TestRunnerQt::reset):
3356         * DumpRenderTree/qt/TestRunnerQt.h:
3357         (TestRunnerQt):
3358
3359 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3360
3361         Update the link on build.webkit.org to refer to perf.webkit.org
3362         https://bugs.webkit.org/show_bug.cgi?id=112416
3363
3364         Reviewed by Philip Rogers.
3365
3366         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3367
3368         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3369
3370 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3371
3372         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3373         https://bugs.webkit.org/show_bug.cgi?id=112394
3374
3375         Reviewed by Philippe Normand.
3376
3377         * GtkLauncher/main.c:
3378         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3379
3380 2013-03-14  Andreas Kling  <akling@apple.com>
3381
3382         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3383         <http://webkit.org/b/111815>
3384         <rdar://problem/13380145>
3385
3386         Reviewed by Anders Carlsson.
3387
3388         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3389         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3390         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3391
3392         * WebKitTestRunner/PlatformWebView.h:
3393         (PlatformWebView):
3394         * WebKitTestRunner/TestController.cpp:
3395         (WTR::TestController::createOtherPage):
3396         (WTR::TestController::createWebViewWithOptions):
3397         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3398         (WTR::PlatformWebView::didInitializeClients):
3399
3400 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3401
3402         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3403         https://bugs.webkit.org/show_bug.cgi?id=112122
3404
3405         Reviewed by Kenneth Rohde Christiansen.
3406
3407         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3408
3409         * MiniBrowser/efl/main.c:
3410         (_Browser_Window):
3411         (search_box_show):
3412         (search_box_hide):
3413         (on_key_down):
3414         (on_url_changed):
3415         (on_search_field_aborted):
3416         (on_search_field_activated):
3417         (on_search_field_clicked):
3418         (on_search_backward_button_clicked):
3419         (on_search_forward_button_clicked):
3420         (window_create):
3421
3422 2013-03-14  Julie Parent  <jparent@chromium.org>
3423
3424         Cleanup: Remove g_resourceLoader.
3425         https://bugs.webkit.org/show_bug.cgi?id=112305
3426
3427         Reviewed by Dirk Pranke.
3428         
3429         Removing another global.
3430         
3431         Now, each dashboard creates its own loader, rather than having
3432         a general global one.
3433         
3434         Remove usage of g_resourceLoader.isLoadingComplete from 
3435         handleLocationChange by ensuring that handleLocationChange is
3436         never called before the loader is done.  It was called in two
3437         places before: 1 was from the callback when the loader is done,
3438         so that was obviously true, and the other was from onhashchange,
3439         where it would just return rather than running.  Instead, lets
3440         only register the onhashchange handler once the loader is
3441         setup, so the check is no longer necessary.
3442         
3443         Remove isLoadingComplete since it is now unused.
3444         
3445         Callback for loader is now initializeHistory, rather than just
3446         handleLocationChange which will set up the hashchange handler now.
3447         This will all eventually be moving to a new History object.
3448
3449         * TestResultServer/static-dashboards/aggregate_results.html:
3450         * TestResultServer/static-dashboards/dashboard_base.js:
3451         (handleLocationChange):
3452         (intializeHistory):
3453         (decompressResults):
3454         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3455         (generatePage):
3456         * TestResultServer/static-dashboards/loader.js:
3457         (.):
3458         * TestResultServer/static-dashboards/loader_unittests.js:
3459         * TestResultServer/static-dashboards/timeline_explorer.html:
3460         * TestResultServer/static-dashboards/treemap.html:
3461
3462 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3463
3464         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3465         https://bugs.webkit.org/show_bug.cgi?id=109404
3466
3467         Reviewed by Tony Chang.
3468
3469         Removes all the code related to smartInsertDeleteEnabled and
3470         selectTrailingWhitespaceEnabled settings as they will be managed from
3471         internals from now on.
3472
3473         * DumpRenderTree/TestRunner.cpp:
3474         (TestRunner::staticFunctions):
3475         * DumpRenderTree/TestRunner.h:
3476         (TestRunner):
3477         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3478         (WebKit):
3479         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3480         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3481         (DumpRenderTree):
3482         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3483         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3484         (WebTestRunner::WebTestProxy::didStopLoading):
3485         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3486         (WebTestRunner::TestRunner::TestRunner):
3487         (WebTestRunner::TestRunner::reset):
3488         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3489         (TestRunner):
3490         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3491         (WebTestRunner::WebPreferences::applyTo): Set default values for
3492         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3493         Chromium DRT default values are different from Chromium browser.
3494         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3495         * DumpRenderTree/chromium/WebViewHost.cpp:
3496         * DumpRenderTree/chromium/WebViewHost.h:
3497         (WebViewHost):
3498         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3499         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3500         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3501         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3502         (resetDefaultsToConsistentValues):
3503         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3504         * DumpRenderTree/mac/DumpRenderTree.mm:
3505         (resetWebViewToConsistentStateBeforeTesting):
3506         * DumpRenderTree/mac/TestRunnerMac.mm:
3507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3508         (WebCore::WebPage::resetSettings):
3509         * DumpRenderTree/qt/TestRunnerQt.cpp:
3510         * DumpRenderTree/qt/TestRunnerQt.h:
3511         (TestRunnerQt):
3512         * DumpRenderTree/win/DumpRenderTree.cpp:
3513         (resetWebViewToConsistentStateBeforeTesting):
3514         * DumpRenderTree/win/TestRunnerWin.cpp:
3515         * DumpRenderTree/wx/TestRunnerWx.cpp:
3516
3517 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3518
3519         [Qt] Disable DRT on Windows
3520
3521         Reviewed by Jocelyn Turcotte.
3522
3523         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3524
3525         * qmake/mkspecs/features/configure.prf:
3526
3527 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3528
3529         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3530         https://bugs.webkit.org/show_bug.cgi?id=110728
3531
3532         Reviewed by Gyuyoung Kim.
3533
3534         Use the page group to create the view object.
3535
3536         * MiniBrowser/efl/main.c:
3537         (window_create):
3538
3539 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3540
3541         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3542
3543         Reviewed by Tor Arne Vestbø.
3544
3545         The mock versions of these web facing features should be instantiated when
3546         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3547         such as QtLocation are actually needed.
3548
3549         This patch decouples enabling device orientation/motion and geolocation from
3550         the underlying Qt modules and makes them available in developer builds
3551         (!production_build) and backed by mock backends when running in drt.
3552
3553         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3554         developers the web facing features are always enabled (although requests will
3555         time out) and the mock backends are enabled inside DRT, allowing for the layout
3556         tests to run with less dependencies.
3557
3558         In addition this also enables the mock device motion client, which was
3559         previously never instantiated.
3560
3561         * qmake/mkspecs/features/features.prf:
3562
3563 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3564
3565         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3566         https://bugs.webkit.org/show_bug.cgi?id=112340
3567
3568         Reviewed by Simon Hausmann.
3569
3570         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3571         (DumpRenderTree::dump):
3572             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3573         (DumpRenderTree::dumpApplicationCacheQuota):
3574         * DumpRenderTree/qt/TestRunnerQt.cpp:
3575         (TestRunnerQt::reset):
3576         * DumpRenderTree/qt/TestRunnerQt.h:
3577         (TestRunnerQt):
3578
3579 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3580
3581         [Qt] Port DRT to use TestRunner::dumpAsText()
3582         https://bugs.webkit.org/show_bug.cgi?id=112260
3583
3584         Reviewed by Benjamin Poulain.
3585
3586         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3587         (WebCore::DumpRenderTree::open):
3588         (WebCore::methodNameStringForFailedTest):
3589             Change parameter from type TestRunnerQt* to TestRunner*.
3590         (WebCore::DumpRenderTree::dump):
3591             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3592             Instead we should rely on TestRunner::generatePixelResults().
3593         * DumpRenderTree/qt/TestRunnerQt.cpp:
3594         (TestRunnerQt::reset):
3595         * DumpRenderTree/qt/TestRunnerQt.h:
3596         (TestRunnerQt):
3597
3598 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3599
3600         Implement FontLoader interface
3601         https://bugs.webkit.org/show_bug.cgi?id=98395
3602
3603         Reviewed by Eric Seidel.
3604
3605         Enable FontLoadEvents runtime flag for TestShell.
3606
3607         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3608         (WebTestRunner::TestInterfaces::TestInterfaces):
3609
3610 2013-03-13  Julie Parent  <jparent@chromium.org>
3611
3612         CLeanup: remove unnecessary call to parseParameters.
3613         https://bugs.webkit.org/show_bug.cgi?id=112309
3614
3615         Reviewed by Ojan Vafai.
3616         
3617         We call parseCrossDashboardParameters when the dashboard initially
3618         loads to set the state required for loadBuildersList, and then we
3619         call it again once we are fully done with loading, so there is no
3620         reason to call it in the middle of the loading process here.
3621
3622         * TestResultServer/static-dashboards/loader.js:
3623         (.):
3624
3625 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3626
3627         Unreviewed. Now I'm a reviewer :)
3628
3629         * Scripts/webkitpy/common/config/committers.py:
3630
3631 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3632
3633         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3634         https://bugs.webkit.org/show_bug.cgi?id=112277
3635
3636         Reviewed by Adam Barth.
3637
3638         * Scripts/webkitperl/FeatureList.pm:
3639         * qmake/mkspecs/features/features.pri:
3640
3641 2013-03-13  Adam Barth  <abarth@webkit.org>
3642
3643         run-perf-tests should support content_shell
3644         https://bugs.webkit.org/show_bug.cgi?id=112291
3645
3646         Reviewed by Eric Seidel.
3647
3648         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3649         (PerfTestsRunner._parse_args):
3650
3651 2013-03-13  Oliver Hunt  <oliver@apple.com>
3652
3653         Simplify Checked<> multiplication
3654         https://bugs.webkit.org/show_bug.cgi?id=112286
3655
3656         Reviewed by James Robinson.
3657
3658         Add tests for multiplication by zero and max to ensure we don't
3659         mess them up should we ever make changes to Checked<> in future.
3660
3661         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3662         (TestWebKitAPI):
3663
3664 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3665
3666         [Qt] Unreviewed prospective Windows build fix
3667
3668         Do the usual thing, include the moc generated code in the .cpp file instead
3669         of compiling it standalone, to ensure that config.h is included, too, and
3670         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3671
3672         * DumpRenderTree/qt/EventSenderQt.cpp:
3673
3674 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3675
3676         [Qt] Port TestRunner::findString to shared interface
3677         https://bugs.webkit.org/show_bug.cgi?id=112147
3678
3679         Reviewed by Jocelyn Turcotte.
3680
3681         This patch also removes DumpRenderTree and some other helper classes from
3682         the WebCore namespace, to which they do not really belong.
3683
3684         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3685         (main):
3686         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3687         (DumpRenderTree::DumpRenderTree):
3688         (DumpRenderTree::~DumpRenderTree):
3689         (DumpRenderTree::instance):
3690         (DumpRenderTree::setShouldTimeout):
3691         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3692         (DumpRenderTree):
3693         * DumpRenderTree/qt/EventSenderQt.cpp:
3694         (EventSender::contextClick):
3695         (EventSender::sendEvent):
3696         (EventSender::postEvent):
3697         * DumpRenderTree/qt/EventSenderQt.h:
3698         (EventSender::isGraphicsBased):
3699         * DumpRenderTree/qt/TestRunnerQt.cpp:
3700         (TestRunnerQt::TestRunnerQt):
3701         (TestRunner::findString):
3702         (TestRunnerQt::setMockDeviceOrientation):
3703         (TestRunnerQt::setGeolocationPermission):
3704         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3705         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3706         (TestRunnerQt::setMockGeolocationPosition):
3707         * DumpRenderTree/qt/TestRunnerQt.h:
3708         (TestRunnerQt):
3709
3710 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3711
3712         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3713         https://bugs.webkit.org/show_bug.cgi?id=112129
3714
3715         Reviewed by Adam Barth.
3716
3717         Following Chromium
3718         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3719         this is being renamed to better explain what it does.
3720
3721         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3722
3723 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3724
3725         [Qt] Unreviewed trivial typo fix
3726
3727         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3728         TextRunner.h. Thanks Zeno :)
3729
3730 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3731
3732         [Qt] Prepare DRT for transition to shared TestRunner interface
3733         https://bugs.webkit.org/show_bug.cgi?id=112144
3734
3735         Reviewed by Benjamin Poulain.
3736
3737         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3738         the JSC C API based one.
3739
3740         This is impplemented by instantiating the QObject based testRunner in
3741         the global object, then instantiating the JSC C based TestRunner
3742         separately and placing it "behind" the QObject based testRunner through
3743         injection of the individual functions through proxies. (prototype
3744         chaining doesn't work due to the this object and Function.prototype.bind
3745         doesn't work due to the native function)
3746
3747         This allows for porting over method by method by removing the method
3748         from the QObject TestRunnerQt and implementing it in the JSC C based
3749         TestRunner.
3750
3751         In order for this to link and run dummy implementations of all the
3752         necessary TestRunner functions are provided.
3753
3754         * DumpRenderTree/qt/DumpRenderTree.pro:
3755         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3756         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3757         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3758         (WebCore::DumpRenderTree::initJSObjects):
3759         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3760         (DumpRenderTree):
3761         * DumpRenderTree/qt/TestRunnerQt.cpp:
3762         (TestRunner::~TestRunner):
3763         (TestRunner::addDisallowedURL):
3764         (TestRunner::queueLoad):
3765         (TestRunner::removeAllVisitedLinks):
3766         (TestRunner::setAcceptsEditing):
3767         (TestRunner::simulateLegacyWebNotificationClick):
3768         (TestRunner::setWindowIsKey):
3769         (TestRunner::setAlwaysAcceptCookies):
3770         (TestRunner::addOriginAccessWhitelistEntry):
3771         (TestRunner::setWebViewEditable):
3772         (TestRunner::clearAllApplicationCaches):
3773         (TestRunner::setTextDirection):
3774         (TestRunner::notifyDone):
3775         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3776         (TestRunner::overridePreference):
3777         (TestRunner::pathToLocalResource):
3778         (TestRunner::removeAllWebNotificationPermissions):
3779         (TestRunner::simulateWebNotificationClick):
3780         (TestRunner::closeIdleLocalStorageDatabases):
3781         (TestRunner::focusWebView):
3782         (TestRunner::setBackingScaleFactor):
3783         (TestRunner::removeChromeInputField):
3784         (TestRunner::addChromeInputField):
3785         (TestRunner::originsWithLocalStorage):
3786         (TestRunner::deleteAllLocalStorage):
3787         (TestRunner::deleteLocalStorageForOrigin):
3788         (TestRunner::observeStorageTrackerNotifications):
3789         (TestRunner::syncLocalStorage):
3790         (TestRunner::windowCount):
3791         (TestRunner::setWaitToDump):
3792         (TestRunner::waitForPolicyDelegate):
3793         (TestRunner::webHistoryItemCount):
3794         (TestRunner::showWebInspector):
3795         (TestRunner::closeWebInspector):
3796         (TestRunner::evaluateInWebInspector):
3797         (TestRunner::setSerializeHTTPLoads):
3798         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3799         (TestRunner::setCustomPolicyDelegate):
3800         (TestRunner::setDatabaseQuota):
3801         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3802         (TestRunner::resetPageVisibility):
3803         (TestRunner::keepWebHistory):
3804         (TestRunner::goBack):
3805         (TestRunner::originsWithApplicationCache):
3806         (TestRunner::applicationCacheDiskUsageForOrigin):
3807         (TestRunner::display):
3808         (TestRunner::dispatchPendingLoadRequests):
3809         (TestRunner::clearPersistentUserStyleSheet):
3810         (TestRunner::callShouldCloseOnWebView):
3811         (TestRunner::copyDecodedHostName):
3812         (TestRunner::clearBackForwardList):
3813         (TestRunner::clearAllDatabases):
3814         (TestRunner::clearApplicationCacheForOrigin):
3815         (TestRunner::apiTestGoToCurrentBackForwardItem):
3816         (TestRunner::authenticateSession):
3817         (TestRunner::abortModal):
3818         (TestRunner::setStorageDatabaseIdleInterval):
3819         (TestRunner::setAsynchronousSpellCheckingEnabled):
3820         (TestRunner::setXSSAuditorEnabled):
3821         (TestRunner::setSpatialNavigationEnabled):
3822         (TestRunner::setScrollbarPolicy):
3823         (TestRunner::setJavaScriptCanAccessClipboard):
3824         (TestRunner::setAutomaticLinkDetectionEnabled):
3825         (TestRunner::setUserStyleSheetEnabled):
3826         (TestRunner::setUserStyleSheetLocation):
3827         (TestRunner::setUseDashboardCompatibilityMode):
3828         (TestRunner::setTabKeyCyclesThroughElements):
3829         (TestRunner::setSmartInsertDeleteEnabled):
3830         (TestRunner::setSelectTrailingWhitespaceEnabled):
3831         (TestRunner::setPrivateBrowsingEnabled):
3832         (TestRunner::setPluginsEnabled):
3833         (TestRunner::setPopupBlockingEnabled):
3834         (TestRunner::setMockSpeechInputDumpRect):
3835         (TestRunner::setPersistentUserStyleSheetLocation):
3836         (TestRunner::setMockGeolocationPosition):
3837         (TestRunner::setMockGeolocationPositionUnavailableError):
3838         (TestRunner::setMockDeviceOrientation):
3839         (TestRunner::setMainFrameIsFirstResponder):
3840         (TestRunner::setIconDatabaseEnabled):
3841         (TestRunner::setGeolocationPermission):
3842         (TestRunner::setDefersLoading):
3843         (TestRunner::setCacheModel):
3844         (TestRunner::setAuthorAndUserStylesEnabled):
3845         (TestRunner::setAllowFileAccessFromFileURLs):
3846         (TestRunner::setAppCacheMaximumSize):
3847         (TestRunner::setAllowUniversalAccessFromFileURLs):
3848         (TestRunner::setApplicationCacheOriginQuota):
3849         (TestRunner::denyWebNotificationPermission):
3850         (TestRunner::grantWebNotificationPermission):
3851         (TestRunner::setValueForUser):
3852         (TestRunner::setViewModeMediaFeature):
3853         (TestRunner::setPageVisibility):
3854         (TestRunner::addMockSpeechInputResult):
3855         (TestRunner::removeOriginAccessWhitelistEntry):
3856         (TestRunner::addUserScript):
3857         (TestRunner::isCommandEnabled):
3858         (TestRunner::evaluateScriptInIsolatedWorld):
3859         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3860         (TestRunner::copyEncodedHostName):
3861         (TestRunner::addUserStyleSheet):
3862         (TestRunner::findString):
3863         (TestRunner::execCommand):
3864         (TestRunner::localStorageDiskUsageForOrigin):
3865
3866 2013-03-12  Julie Parent  <jparent@chromium.org>
3867
3868         Cleanup: Move flatten-trie to loader.
3869         https://bugs.webkit.org/show_bug.cgi?id=112196
3870
3871         Reviewed by Dirk Pranke.
3872
3873         flatten-trie is used only by the loader, so move it there and make it
3874         private, rather than global in dashbaord_base. Moved the corresponding
3875         unit test from flakiness_dashboard_unittests to loader_unittests.
3876         
3877         * TestResultServer/static-dashboards/dashboard_base.js:
3878         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3879         * TestResultServer/static-dashboards/loader.js:
3880         (.):
3881         * TestResultServer/static-dashboards/loader_unittests.js:
3882
3883 2013-03-12  Oliver Hunt  <oliver@apple.com>
3884
3885         Unbreak api tests
3886
3887         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3888         (TestWebKitAPI):
3889
3890 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3891
3892         Unreviewed, disabling tests for Win EWS.
3893
3894         win-ews obviously cannot keep up with running tests, it's >300 behind.
3895         Probably doesn't help that its (likely) running tests serially.
3896
3897         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3898         (WinEWS):
3899
3900 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3901
3902         Add a --build-directory argument to delete-stale-build-files
3903         https://bugs.webkit.org/show_bug.cgi?id=112198
3904
3905         Reviewed by Ryosuke Niwa.
3906
3907         * BuildSlaveSupport/delete-stale-build-files:
3908         (main): Add --build-directory argument.
3909
3910 2013-03-12  Oliver Hunt  <oliver@apple.com>
3911
3912         Appease MSVC
3913
3914         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3915         (TestWebKitAPI):
3916
3917 2013-03-12  Oliver Hunt  <oliver@apple.com>
3918
3919         Add more Checked<> tests
3920         https://bugs.webkit.org/show_bug.cgi?id=112190
3921
3922         Reviewed by Geoffrey Garen.
3923
3924         Tests!
3925
3926         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3927         (TestWebKitAPI):
3928
3929 2013-03-12  Julie Parent  <jparent@chromium.org>
3930
3931         Cleanup: Move loading complete function into callback, rather than global.
3932         https://bugs.webkit.org/show_bug.cgi?id=112167
3933
3934         Reviewed by Dirk Pranke.
3935         
3936         Stop calling global functions, pass in proper handler to Loader
3937         constructor. Note that the callback is optional, as tests, and
3938         some potential dashboards, do not need one.
3939
3940         * TestResultServer/static-dashboards/dashboard_base.js:
3941         * TestResultServer/static-dashboards/loader.js:
3942         (.):
3943         * TestResultServer/static-dashboards/loader_unittests.js:
3944
3945 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3946
3947         [EFL][WK2] Add popup menu support to MiniBrowser
3948         https://bugs.webkit.org/show_bug.cgi?id=108934
3949
3950         Reviewed by Kenneth Rohde Christiansen.
3951
3952         Implement popup menu support in MiniBrowser by handling popup_menu_show
3953         and popup_menu_hide smart functions on the view and using the Ewk popup
3954         menu API.
3955
3956         * MiniBrowser/efl/main.c:
3957         (_Browser_Window):
3958         (on_popup_menu_discarded):
3959         (on_popup_menu_item_clicked):
3960         (popup_menu_populate):
3961         (on_popup_menu_show):
3962         (on_popup_menu_hide):
3963         (window_create): Use calloc() instead of malloc() to allocate memory for
3964         Browser_Window. This makes sure all the structs members are initialized
3965         to 0 (such as the new elm_popup_menu pointer).
3966
3967 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3968
3969         [GTK] Set up the libPlatformGtk.la library
3970         https://bugs.webkit.org/show_bug.cgi?id=111738
3971
3972         Reviewed by Martin Robinson.
3973
3974         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3975         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3976         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3977
3978 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3979
3980         [GTK] Enable Web Audio in development builds
3981         https://bugs.webkit.org/show_bug.cgi?id=111831
3982
3983         Reviewed by Philippe Normand.
3984
3985         Web Audio is already quite well supported on the GTK port but still has a few issues
3986         that must be addressed before it is enabled by default. Despite that it should be enabled
3987         in development builds just so we are up-to-date with future feature infrastructure changes.
3988         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3989         that's an obvious goal before enabling the feature in release builds.
3990
3991         * Scripts/webkitperl/FeatureList.pm:
3992
3993 2013-03-11  Andreas Kling  <akling@apple.com>
3994
3995         [Mac][WK1] Add support for alert() in MiniBrowser.
3996         <http://webkit.org/b/112090>
3997
3998         Reviewed by Anders Carlsson.
3999
4000         * MiniBrowser/mac/WK1BrowserWindowController.m:
4001         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4002
4003 2013-03-11  Julie Parent  <jparent@chromium.org>
4004
4005         Dashboard cleanup: Create ui.Errors
4006         https://bugs.webkit.org/show_bug.cgi?id=111785
4007
4008         Reviewed by Ojan Vafai.
4009         
4010         Create ui.Errors for handling errors the dashboards
4011         encounter. Loader now has a Error object that it can add to,
4012         and individual dashboards can show errors when desired.
4013         Currently, only flakiness_db shows errors, but this is 
4014         generic and there is no reason why other dbs wouldn't want to
4015         show errors.
4016
4017         * TestResultServer/static-dashboards/dashboard_base.js:
4018         (resourceLoadingComplete):
4019         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4020         (generatePage):
4021         * TestResultServer/static-dashboards/loader.js:
4022         (.):
4023         * TestResultServer/static-dashboards/ui.js:
4024         (.):
4025
4026 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4027
4028         Some StringHasher tests are broken because of missing null termination
4029         https://bugs.webkit.org/show_bug.cgi?id=111284
4030
4031         Reviewed by Darin Adler.
4032
4033         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4034         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4035         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4036         the bug caught by it is now fixed.
4037
4038 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4039
4040         Unreviewed, rolling out r145200.
4041         http://trac.webkit.org/changeset/145200
4042         https://bugs.webkit.org/show_bug.cgi?id=112063
4043
4044         Broke a couple of unit tests (Requested by zdobersek on
4045         #webkit).
4046
4047         * Scripts/webkitperl/FeatureList.pm:
4048
4049 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4050
4051         [GTK] WebKit2-only build fails
4052         https://bugs.webkit.org/show_bug.cgi?id=112033
4053
4054         Reviewed by Gustavo Noronha Silva.
4055
4056         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4057         generic part, WebKit1-specific part and WebKit2-specific part.
4058         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4059         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4060         directly.
4061
4062 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4063
4064         Adding myself to the committers list.
4065
4066         Unreviewed.
4067
4068         * Scripts/webkitpy/common/config/committers.py:
4069
4070 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4071
4072         [BlackBerry] Disable MathML support
4073         https://bugs.webkit.org/show_bug.cgi?id=111929
4074
4075         Reviewed by Rob Buis.
4076
4077         * Scripts/webkitperl/FeatureList.pm:
4078
4079 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4080
4081         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4082         https://bugs.webkit.org/show_bug.cgi?id=111970
4083
4084         Reviewed by Chris Fleizach.
4085
4086         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4087         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4088         undefined symbol.
4089
4090         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4091         (WTR::AccessibilityUIElement::supportedActions):
4092         (WTR):
4093
4094 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4095
4096         [chromium] Android apk targets should depend directly on Java library targets
4097         https://bugs.webkit.org/show_bug.cgi?id=111746
4098
4099         Reviewed by Eric Seidel.
4100
4101         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4102         Make DumpRenderTree_apk depend directly on base_java and net_java.
4103         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4104         Make TestWebKitAPI_apk depend directly on base_java.
4105
4106 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4107
4108         [chromium] remove obsolete user gesture methods from WebFrame
4109         https://bugs.webkit.org/show_bug.cgi?id=111696
4110
4111         Reviewed by Adam Barth.
4112
4113         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4114         (WebTestRunner::TestPlugin::handleInputEvent):
4115         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4116
4117 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
4118
4119         Unreviewed, add myself to commiters.py.
4120
4121         * Scripts/webkitpy/common/config/committers.py:
4122
4123 2013-03-08  Julie Parent  <jparent@chromium.org>
4124
4125         Cleanup: Remove dead code.
4126         https://bugs.webkit.org/show_bug.cgi?id=111900
4127
4128         Reviewed by Dirk Pranke.
4129         
4130         Treemap overrides a global function that used to be in 
4131         dashboard_base, but was removed months ago in
4132         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
4133         no caller. 
4134
4135         * TestResultServer/static-dashboards/treemap.html:
4136
4137 2013-03-08  Harald Alvestrand  <hta@chromium.org>
4138
4139         Implemented new API for RTCStatsReport object.
4140         https://bugs.webkit.org/show_bug.cgi?id=110333
4141
4142         Reviewed by Adam Barth.
4143
4144         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
4145         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4146
4147 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
4148
4149         [chromium] use custom freetype on linux asan builds again
4150         https://bugs.webkit.org/show_bug.cgi?id=111884
4151
4152         Reviewed by Tony Chang.
4153
4154         We no longer need the workaround after chromium r186540.
4155
4156         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4157
4158 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
4159
4160         Warning about the user not having edit rights on Bugzilla is confusing new contributors
4161         https://bugs.webkit.org/show_bug.cgi?id=111798
4162
4163         Reviewed by Dirk Pranke.
4164
4165         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
4166
4167         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4168
4169 2013-03-08  James Robinson  <jamesr@chromium.org>
4170
4171         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
4172         https://bugs.webkit.org/show_bug.cgi?id=111632
4173
4174         Reviewed by Adrienne Walker.
4175
4176         * DumpRenderTree/chromium/WebViewHost.cpp:
4177         (WebViewHost::initializeLayerTreeView):
4178         * DumpRenderTree/chromium/WebViewHost.h:
4179         (WebViewHost):
4180
4181 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
4182
4183         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
4184         https://bugs.webkit.org/show_bug.cgi?id=111297
4185
4186         Reviewed by Kenneth Rohde Christiansen.
4187
4188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4189         (WTR::TestRunner::setViewModeMediaFeature):
4190
4191 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
4192
4193         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
4194         https://bugs.webkit.org/show_bug.cgi?id=111814
4195
4196         Reviewed by Ryosuke Niwa.
4197
4198         Add the needed supportedActions() attribute to WKTestRunner.
4199
4200         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4201         (WTR::AccessibilityUIElement::supportedActions):
4202         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4203         (AccessibilityUIElement):
4204         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4205         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4206         (WTR::AccessibilityUIElement::supportedActions):
4207
4208 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4209
4210         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
4211         https://bugs.webkit.org/show_bug.cgi?id=111851
4212
4213         Reviewed by Kenneth Rohde Christiansen.
4214
4215         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
4216         (TestWebKitAPI::TEST):
4217
4218             Fixed WKURLRef instance leaking.
4219
4220 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4221
4222         [EFL] [WK2] Some authentication tests fail in WebKit2
4223         https://bugs.webkit.org/show_bug.cgi?id=106407
4224
4225         Reviewed by Kenneth Rohde Christiansen.
4226
4227         Add patch from upstream for libsoup 2.40 to fix several authentication
4228         test cases.
4229
4230         * efl/jhbuild.modules:
4231         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
4232
4233 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
4234
4235         [GTK] Enable Web Audio in development builds
4236         https://bugs.webkit.org/show_bug.cgi?id=111831
4237
4238         Reviewed by Philippe Normand.
4239
4240         Web Audio is already quite well supported on the GTK port but still has a few issues
4241         that must be addressed before it is enabled by default. Despite that it should be enabled
4242         in development builds just so we are up-to-date with future feature infrastructure changes.
4243         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4244         that's an obvious goal before enabling the feature in release builds.
4245
4246         * Scripts/webkitperl/FeatureList.pm:
4247
4248 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4249
4250         [chromium] delay clearing the TestRunners until the main view was deleted
4251         https://bugs.webkit.org/show_bug.cgi?id=111823
4252
4253         Reviewed by Eric Seidel.
4254
4255         During WebViewHost::shutdown, we navigate the WebView to about:blank.
4256         This may call into the test runners which assume that the delegate is
4257         always non-NULL.
4258
4259         * DumpRenderTree/chromium/TestShell.cpp:
4260         (TestShell::~TestShell):
4261
4262 2013-03-07  Alan Cutter  <alancutter@chromium.org>
4263
4264         Sheriffbot whois command can't search by full name
4265         https://bugs.webkit.org/show_bug.cgi?id=111825
4266
4267         Reviewed by Eric Seidel.
4268
4269         Allowed multiple arguments to Sheriffbot's whois command.
4270         Updated test expectations.
4271
4272         * Scripts/webkitpy/tool/bot/irc_command.py:
4273         (Whois.execute):
4274         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4275         (IRCCommandTest.test_whois):
4276
4277 2013-03-07  Nils Barth  <nbarth@chromium.org>
4278
4279         Add Nils Barth and Koji Hara to committers.py
4280         https://bugs.webkit.org/show_bug.cgi?id=111806
4281
4282         Reviewed by Eric Seidel.
4283
4284         * Scripts/webkitpy/common/config/committers.py:
4285
4286 2013-03-07  Glenn Adams  <glenn@skynav.com>
4287
4288         run-pert-tests should have a --test-runner-count option
4289         https://bugs.webkit.org/show_bug.cgi?id=111726
4290
4291         Reviewed by Ryosuke Niwa.
4292
4293         Add --test-runner-count option to run-perf-tests, with default value of 4.
4294         This option allows command line configuration of the number of times to invoke
4295         the test runner (serially, not in parallel) when running a specific test in
4296         a test set.
4297
4298         * Scripts/webkitpy/performance_tests/perftest.py: